⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 2, 2011:

9:45 PM Changeset in webkit [74888] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-02 Adam Barth <abarth@webkit.org>

Skip this test for now. It's been failing for a while. I'm
investigating the root cause now, but having this red on the buildbot
isn't productive.

  • platform/mac/Skipped:
8:53 PM Changeset in webkit [74887] by mitz@apple.com
  • 13 edits in trunk

<rdar://problem/8812159> Update copyright strings

Rubber-stamped by Simon Fraser.

Source/JavaScriptCore:

  • Info.plist:

Source/JavaScriptGlue:

  • Info.plist:

WebCore:

  • Info.plist:

WebKit/mac:

  • Info.plist:

WebKit2:

  • Info.plist:
  • WebProcess/Info.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:
8:45 PM Changeset in webkit [74886] by mitz@apple.com
  • 2 edits
    1 add in trunk/WebCore

<rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
https://bugs.webkit.org/show_bug.cgi?id=51623

Reviewed by Sam Weinig.

  • editing/Editor.cpp:

(WebCore::Editor::countMatchesForText): Actually remember the original search range end
container and offset and restore them when needed, instead of using two references to the
same Range.

  • manual-tests/find-count-matches-after-text-control.html: Added.
7:29 PM Changeset in webkit [74885] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-02 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Two more fixes.

  • platform/chromium/test_expectations.txt:
7:18 PM Changeset in webkit [74884] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-02 Kent Tamura <tkent@chromium.org>

Unreviewed, correct test_expectations.txt syntax.

  • platform/chromium/test_expectations.txt:
6:18 PM Changeset in webkit [74883] by tkent@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2011-01-02 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • Add expectation files for application-plugin-plugins-disabled.html
  • Add some flaky tests to test_expectations.txt
  • platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
  • platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.png: Added.
  • platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
  • platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.png: Added.
  • platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
  • platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.png: Added.
  • platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:29 PM Changeset in webkit [74882] by benjamin.poulain@nokia.com
  • 5 edits in trunk

2011-01-02 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Csaba Osztrogonác.

WebKit 2 does not build on 64bits with a recent GCC
https://bugs.webkit.org/show_bug.cgi?id=51754

Use explicitely 64 bits types for the attributes of DatabaseDetails.

  • storage/DatabaseDetails.h: (WebCore::DatabaseDetails::expectedUsage): (WebCore::DatabaseDetails::currentUsage):

2011-01-02 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Csaba Osztrogonác.

WebKit 2 does not build on 64bits with a recent GCC
https://bugs.webkit.org/show_bug.cgi?id=51754

Change the argument coding for DatabaseDetails to use explicitely the 64 bits type.

  • Shared/OriginAndDatabases.h:
  • Shared/WebCoreArgumentCoders.h:
5:06 PM Changeset in webkit [74881] by Patrick Gansterer
  • 3 edits in trunk/Tools

2011-01-02 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Make EFL a core builder
https://bugs.webkit.org/show_bug.cgi?id=51804

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4:08 PM Changeset in webkit [74880] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Unreviewed fix after r74855 and r74875.

  • BuildSlaveSupport/built-product-archive:
    • Create directories explicitly.
    • Pass shell=True to subprocess.call().
3:38 PM Changeset in webkit [74879] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2011-01-02 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r74868.

  • platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::getImageData):
3:26 PM Changeset in webkit [74878] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Fix GTK+ build after r74855.

Reviewed by Xan Lopez.

  • GNUmakefile.am: Fix include pathes.
2:27 PM Changeset in webkit [74877] by commit-queue@webkit.org
  • 20 edits in trunk/WebCore

2011-01-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74847.
http://trac.webkit.org/changeset/74847
https://bugs.webkit.org/show_bug.cgi?id=51803

"Preprocessor guards should be in header files" (Requested by
ap on #webkit).

  • bindings/js/JSDOMWindowBase.cpp:
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • html/HTMLDocument.cpp:
  • loader/FrameLoader.cpp:
  • loader/ResourceLoadNotifier.cpp:
  • page/Chrome.cpp:
  • page/Console.cpp:
  • page/ContextMenuController.cpp:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
  • page/EventHandler.cpp:
  • page/Page.cpp:
  • storage/Database.cpp:
  • workers/AbstractWorker.cpp:
  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/SharedWorker.cpp:
  • workers/Worker.cpp:
  • workers/WorkerContext.cpp:
  • workers/WorkerMessagingProxy.cpp:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
2:11 PM Changeset in webkit [74876] by robert@webkit.org
  • 3 edits
    1 copy in trunk/LayoutTests

2011-01-02 Robert Hogan <robert@webkit.org>

Unreviewed, update expected results.

Update expected results for tests added in r74872

Skip test on Qt as Qt Styled Widgets are no longer getting
rendered when plugins are disabled. This is a bug.

  • platform/gtk/plugins/application-plugin-plugins-disabled-expected.txt: Copied from LayoutTests/plugins/application-plugin-plugins-disabled-expected.txt.
  • platform/qt/Skipped:
  • plugins/application-plugin-plugins-disabled-expected.txt:
1:44 PM Changeset in webkit [74875] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Unreviewed fix after r74855.

Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604

  • BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1:28 PM Changeset in webkit [74874] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Unreviewed run-javasriptcore-tests fix after r74855.

Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604

  • Scripts/webkitdirs.pm:
1:16 PM Changeset in webkit [74873] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604

Reviewed by Adam Barth.

Workaround until moving all sources to Source directory is finished.

  • Scripts/generate-forwarding-headers.pl: Add Sources to searching path for JavaScriptCore.
1:13 PM Changeset in webkit [74872] by robert@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-02 Robert Hogan <robert@webkit.org>

Unreviewed.

Layout tests from changeset r56661 were missed

This test was accidentally omitted from changeset 56661.

See also https://webkit.org/b/32196

https://bugs.webkit.org/show_bug.cgi?id=42562

  • platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • plugins/application-plugin-plugins-disabled.html: Added.
11:31 AM Changeset in webkit [74871] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2011-01-02 Patrick Gansterer <Patrick Gansterer>

[CMake] Unreviewed build fix.

  • CMakeLists.txt:
11:16 AM Changeset in webkit [74870] by Patrick Gansterer
  • 3 edits in trunk

2011-01-02 Patrick Gansterer <Patrick Gansterer>

[CMake] Unreviewed build fix.

  • CMakeLists.txt:
  • Source/cmake/OptionsCommon.cmake:
8:06 AM Changeset in webkit [74869] by robert@webkit.org
  • 2 edits in trunk/Tools

2011-01-02 Robert Hogan <robert@webkit.org>

Unreviewed, build fix.

[Qt] Fix DRT build after 74855

  • DumpRenderTree/qt/DumpRenderTree.pro:
2:38 AM Changeset in webkit [74868] by krit@webkit.org
  • 29 edits in trunk

2011-01-02 Dirk Schulze <krit@webkit.org>

Reviewed by Simon Fraser.

Clarify ImageBuffer and ImageData relationship
https://bugs.webkit.org/show_bug.cgi?id=51297

Use ByteArray instead of ImageData.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas):

2011-01-02 Dirk Schulze <krit@webkit.org>

Reviewed by Simon Fraser.

Clarify ImageBuffer and ImageData relationship
https://bugs.webkit.org/show_bug.cgi?id=51297

Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code,
since this was a layering violation, and replaced it by ByteArray.

No change of functionality, so no new test added.

  • html/ImageData.cpp: (WebCore::ImageData::create): (WebCore::ImageData::ImageData):
  • html/ImageData.h: Added new constructor with ByteArray input. (WebCore::ImageData::width): (WebCore::ImageData::height): (WebCore::ImageData::data):
  • html/canvas/CanvasPixelArray.cpp: (WebCore::CanvasPixelArray::create): (WebCore::CanvasPixelArray::CanvasPixelArray):
  • html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas. (WebCore::CanvasPixelArray::data): (WebCore::CanvasPixelArray::length): (WebCore::CanvasPixelArray::set): (WebCore::CanvasPixelArray::get):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData):
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::setDestinationPixels): (WebCore::FEConvolveMatrix::apply):
  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
  • platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::apply):
  • platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::apply):
  • platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::apply):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::asImageBuffer): (WebCore::FilterEffect::asUnmultipliedImage): (WebCore::FilterEffect::asPremultipliedImage): (WebCore::FilterEffect::copyImageBytes): (WebCore::FilterEffect::copyUnmultipliedImage): (WebCore::FilterEffect::copyPremultipliedImage): (WebCore::FilterEffect::createUnmultipliedImageResult): (WebCore::FilterEffect::createPremultipliedImageResult):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
1:51 AM Changeset in webkit [74867] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2011-01-02 Xan Lopez <xlopez@igalia.com>

Fix GTK+ build.

  • GNUmakefile.am: tests do actually include JSC.
1:12 AM Changeset in webkit [74866] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-02 Adam Barth <abarth@webkit.org>

One more .. missing in the Qt build.

  • jsc.pro:
1:06 AM Changeset in webkit [74865] by xan@webkit.org
  • 4 edits in trunk

WebKit/gtk:

2011-01-02 Xan Lopez <xlopez@igalia.com>

Fix GTK+ build.

  • GNUmakefile.am: remove individual -I$(srcdir)/Source when we'll already get them from javascriptcore_cppflags, and add it for the introspection build (which is not tested in the bots).

JavaScriptCore:

2011-01-02 Xan Lopez <xlopez@igalia.com>

Fix GTK+ build.

  • GNUmakefile.am: add -I$(srcdir)/Source to the JSC cppflags so that anyone can include its headers without adding the prefix 'Source/'.
12:28 AM Changeset in webkit [74864] by abarth@webkit.org
  • 2 edits in trunk/WebKit/gtk

2011-01-02 Adam Barth <abarth@webkit.org>

Speculative build fix for GTK. Add Source to the include paths.

  • GNUmakefile.am:
12:15 AM Changeset in webkit [74863] by abarth@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

2011-01-02 Carl Lobo <carllobo@gmail.com>

Reviewed by Adam Barth.

Fix Windows Build for non-production where VSPropsRedirectionDir is not defined.
https://bugs.webkit.org/show_bug.cgi?id=51797

Jan 1, 2011:

11:52 PM Changeset in webkit [74862] by abarth@webkit.org
  • 2 edits in trunk/WebKit2

2011-01-01 Adam Barth <abarth@webkit.org>

Speculative build fix for Qt. Add some more include paths.

  • WebKit2.pro:
11:42 PM Changeset in webkit [74861] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-01 Adam Barth <abarth@webkit.org>

Fix relative include paths in an attempt to fix the Qt build.

11:14 PM Changeset in webkit [74860] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-01 Adam Barth <abarth@webkit.org>

Another speculative build fix for GTK.

  • GNUmakefile.am:
11:09 PM Changeset in webkit [74859] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-01 Adam Barth <abarth@webkit.org>

Speculative build fix for GTK. Update the paths in GNUmakefile to
include "Source".

  • GNUmakefile.am:
10:46 PM Changeset in webkit [74858] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-01 Adam Barth <abarth@webkit.org>

Remove the assumption from the Qt and Gtk builds that every project is
in the root directory.

  • Scripts/build-webkit:
10:40 PM Changeset in webkit [74857] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-01 Adam Barth <abarth@webkit.org>

Update relative paths in JavaScriptCore.gyp to account for the extra
level of directories.

10:28 PM Changeset in webkit [74856] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Teach svn-apply how to apply patches even though JavaScriptCore has moved
https://bugs.webkit.org/show_bug.cgi?id=51796

After this change, svn-apply will magically apply patches to
JavaScriptCore/foo to Source/JavaScriptCore/foo.

  • Scripts/VCSUtils.pm:
10:22 PM Changeset in webkit [74855] by abarth@webkit.org
  • 57 edits
    1 move in trunk

Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604

Reviewed by Eric Seidel.

Update references to JavaScriptCore to point to the new location.

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • Makefile:
  • WebKit.pri:
  • WebKit.pro:
  • wscript:

Tools:

Update references to JavaScriptCore to point to the new location.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/ImageDiff.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • DumpRenderTree/wscript:
  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/run-javascriptcore-tests:
  • Scripts/update-javascriptcore-test-results:
  • Scripts/webkitdirs.pm:
  • Scripts/webkitpy/common/config/build_unittest.py:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
  • wx/build/settings.py:

WebCore:

Update references to JavaScriptCore.

  • Android.derived.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pro:
    • These changes are subtle and might not be 100% correct.
  • move-js-headers.sh:

WebKit/chromium:

WebKit/gtk:

  • GNUmakefile.am:
  • docs/GNUmakefile.am:

WebKit/qt:

  • WebKit_pch.h:
  • docs/qtwebkit.qdocconf:

WebKit/win:

  • WebKit.vcproj/WebKit.sln:

WebKit/wx:

  • bindings/python/wscript:
  • wscript:

WebKit2:

Websites/bugs.webkit.org:

  • PrettyPatch/PrettyPatch.rb:

Websites/webkit.org:

  • coding/assertion-guidelines.html:
8:33 PM Changeset in webkit [74854] by abarth@webkit.org
  • 5 edits
    7 adds in trunk

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340

We now pass the ScriptExecutionContext to window.close so it can find
the Frame and check whether navigation is allowed. This check will
almost always pass because you can only close top-level frames, but the
check will fail when the calling script is sandboxed.

Tests: fast/frames/sandboxed-iframe-close-top-noclose.html

fast/frames/sandboxed-iframe-close-top.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::close):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340

Test the interaction between the HTML5 sandbox and window.close.

  • fast/frames/resources/close-top.html: Added.
  • fast/frames/resources/sandboxed-iframe-close-top-does-close.html: Added.
  • fast/frames/resources/sandboxed-iframe-close-top-does-not-close.html: Added.
  • fast/frames/sandboxed-iframe-close-top-expected.txt: Added.
  • fast/frames/sandboxed-iframe-close-top-noclose-expected.txt: Added.
  • fast/frames/sandboxed-iframe-close-top-noclose.html: Added.
  • fast/frames/sandboxed-iframe-close-top.html: Added.
6:28 PM Changeset in webkit [74853] by abarth@webkit.org
  • 5 edits
    2 adds in trunk

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152

To enforce the sandbox restrictions on History, we need to pass the
ScriptExecutionContext to WebCore. This patch leaves the original
History methods in place because they are used directly by folks who
don't care about security checks.

Test: fast/frames/sandboxed-iframe-history-denied.html

  • page/History.cpp: (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
  • page/History.h:
  • page/History.idl:

2011-01-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Eric Seidel.

sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152

Test that sandboxed iframes cannot use history to navigate the top
frame. This test is less than ideal, as described in the test itself.
If I was really on top of things, I'd add a test for successful use of
the history API when allow-top-navigation is set, but that test would
be complicated and I'm lazy (enough to copy directly from abarth).

  • fast/frames/sandboxed-iframe-history-denied-expected.txt: Added.
  • fast/frames/sandboxed-iframe-history-denied.html: Added.
6:04 PM Changeset in webkit [74852] by abarth@webkit.org
  • 14 edits
    1 move in trunk

Move Sources to Source
https://bugs.webkit.org/show_bug.cgi?id=51794

Reviewed by Eric Seidel.

Update build files to point to the new location.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Makefile:
  • autogen.sh:
  • configure.ac:

Tools:

Update scripts to point to the new location.

  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:

Websites/bugs.webkit.org:

  • PrettyPatch/PrettyPatch.rb:
5:50 PM Changeset in webkit [74851] by abarth@webkit.org
  • 9 edits
    1 delete in trunk/WebCore

2011-01-01 Adam Barth <abarth@webkit.org>

Remove empty file.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Entity.cpp: Removed.
5:43 PM Changeset in webkit [74850] by abarth@webkit.org
  • 7 edits
    1 delete in trunk/WebCore

2011-01-01 Adam Barth <abarth@webkit.org>

Remove empty file.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSPopStateEventCustom.cpp: Removed.
5:37 PM Changeset in webkit [74849] by abarth@webkit.org
  • 5 edits
    2 deletes in trunk/WebCore

2011-01-01 Adam Barth <abarth@webkit.org>

Remove empty files.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/BindingFrame.h: Removed.
  • bindings/generic/BindingLocation.h: Removed.
4:35 PM Changeset in webkit [74848] by mitz@apple.com
  • 1 edit in trunk/WebKit2/WebKit2.xcodeproj

Changed WebKit2.xcodeproj's svn:ignore property up to match other projects'

10:00 AM Changeset in webkit [74847] by commit-queue@webkit.org
  • 20 edits in trunk/WebCore

2011-01-01 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by Darin Adler.

Don't include Inspector headers when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=51789

  • bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when Inspector is enabled
  • dom/Document.cpp: Include Inspector headers when Inspector is enabled (WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie handling
  • html/HTMLDocument.cpp: Include Inspector headers when Inspector is enabled
  • loader/FrameLoader.cpp: Include Inspector headers when Inspector is enabled
  • loader/ResourceLoadNotifier.cpp: Include Inspector headers when Inspector is enabled
  • page/Chrome.cpp: Include Inspector headers when Inspector is enabled
  • page/Console.cpp: Include Inspector headers when Inspector is enabled
  • page/ContextMenuController.cpp: Include Inspector headers when Inspector is enabled
  • page/DOMWindow.cpp: Include Inspector headers when Inspector is enabled (WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie handling
  • page/EventHandler.cpp: Include Inspector headers when Inspector is enabled
  • page/Page.cpp: Include Inspector headers when Inspector is enabled
  • storage/Database.cpp: Include Inspector headers when Inspector is enabled
  • workers/AbstractWorker.cpp: Include Inspector headers when Inspector is enabled
  • workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when Inspector is enabled
  • workers/SharedWorker.cpp: Include Inspector headers when Inspector is enabled
  • workers/Worker.cpp: Include Inspector headers when Inspector is enabled
  • workers/WorkerContext.cpp: Include Inspector headers when Inspector is enabled
  • workers/WorkerMessagingProxy.cpp: Include Inspector headers when Inspector is enabled
  • xml/XMLHttpRequest.cpp: Include Inspector headers when Inspector is enabled (WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled InspectorInstrumentationCookie handling
3:01 AM Changeset in webkit [74846] by tkent@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2011-01-01 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

One more rebaseline for a spelling test, and remove passing tests from
test_expectations.txt.

  • platform/chromium-linux/editing/spelling/inline_spelling_markers-expected.checksum: Added.
  • platform/chromium-linux/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.checksum: Added.
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

Dec 31, 2010:

10:54 PM Changeset in webkit [74845] by tkent@chromium.org
  • 371 edits in trunk/LayoutTests

Unreviewed, test expectation update.

r74844 enabled spell checker on Chromium Linux and Chromium
Windows. So we need to update all of images with misspelled words.

  • platform/chromium-linux/editing/deleting/delete-3928305-fix-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-3928305-fix-expected.png:
  • platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-linux/editing/deleting/delete-and-undo-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-linux/editing/deleting/delete-tab-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-tab-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-linux/editing/execCommand/5569741-expected.checksum:
  • platform/chromium-linux/editing/execCommand/5569741-expected.png:
  • platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.checksum:
  • platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.checksum:
  • platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-linux/editing/execCommand/outdent-selection-expected.checksum:
  • platform/chromium-linux/editing/execCommand/outdent-selection-expected.png:
  • platform/chromium-linux/editing/inserting/5418891-expected.checksum:
  • platform/chromium-linux/editing/inserting/5418891-expected.png:
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.checksum:
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-007-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-007-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-012-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-012-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-013-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-013-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-014-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-014-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-015-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-015-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-016-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-016-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-017-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-017-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-018-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-018-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-019-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-019-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-020-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-020-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-022-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-022-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-025-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-027-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-027-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-linux/editing/inserting/insert-tab-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-linux/editing/inserting/insert-tab-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-linux/editing/inserting/typing-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-002-expected.png:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/4242293-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4242293-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/8145-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/cut-text-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-4-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-table-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-012-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-013-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-013-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-014-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-014-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-019-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.png:
  • platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-linux/editing/selection/13804-expected.checksum:
  • platform/chromium-linux/editing/selection/13804-expected.png:
  • platform/chromium-linux/editing/selection/5234383-1-expected.checksum:
  • platform/chromium-linux/editing/selection/5234383-1-expected.png:
  • platform/chromium-linux/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-linux/editing/selection/5234383-2-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-character-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-linux/editing/selection/unrendered-002-expected.checksum:
  • platform/chromium-linux/editing/selection/unrendered-002-expected.png:
  • platform/chromium-linux/editing/spelling/spelling-expected.checksum:
  • platform/chromium-linux/editing/spelling/spelling-expected.png:
  • platform/chromium-linux/editing/style/5046875-2-expected.checksum:
  • platform/chromium-linux/editing/style/5046875-2-expected.png:
  • platform/chromium-linux/editing/style/block-styles-007-expected.checksum:
  • platform/chromium-linux/editing/style/block-styles-007-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-002-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-003-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-003-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-004-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-004-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-008-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-009-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-009-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-013-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-013-expected.png:
  • platform/chromium-linux/fast/dom/blur-contenteditable-expected.checksum:
  • platform/chromium-linux/fast/dom/blur-contenteditable-expected.png:
  • platform/chromium-win/editing/deleting/delete-3928305-fix-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-3928305-fix-expected.png:
  • platform/chromium-win/editing/deleting/delete-3959464-fix-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-win/editing/deleting/delete-and-undo-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-win/editing/deleting/delete-block-contents-003-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-win/editing/deleting/delete-tab-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-win/editing/deleting/delete-tab-003-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-win/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-003-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-004-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-win/editing/execCommand/5569741-expected.checksum:
  • platform/chromium-win/editing/execCommand/5569741-expected.png:
  • platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.checksum:
  • platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.checksum:
  • platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.checksum:
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.png:
  • platform/chromium-win/editing/inserting/5418891-expected.checksum:
  • platform/chromium-win/editing/inserting/5418891-expected.png:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.checksum:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-007-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-007-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-012-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-012-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-013-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-013-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-014-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-014-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-015-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-015-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-016-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-016-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-017-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-017-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-018-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-018-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-019-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-019-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-020-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-020-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-021-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-021-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-022-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-022-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-025-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-027-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-027-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-02-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-03-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-win/editing/inserting/insert-tab-002-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-win/editing/inserting/insert-tab-003-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-01-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-02-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-03-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-win/editing/inserting/typing-002-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-002-expected.png:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-win/editing/pasteboard/4242293-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4242293-expected.png:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-win/editing/pasteboard/8145-2-expected.checksum:
  • platform/chromium-win/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-win/editing/pasteboard/cut-text-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-table-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-table-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-013-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-013-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-014-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-014-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-019-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.png:
  • platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-win/editing/selection/13804-expected.checksum:
  • platform/chromium-win/editing/selection/13804-expected.png:
  • platform/chromium-win/editing/selection/5234383-1-expected.checksum:
  • platform/chromium-win/editing/selection/5234383-1-expected.png:
  • platform/chromium-win/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-win/editing/selection/5234383-2-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-character-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-line-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-win/editing/selection/unrendered-002-expected.checksum:
  • platform/chromium-win/editing/selection/unrendered-002-expected.png:
  • platform/chromium-win/editing/spelling/spelling-expected.checksum:
  • platform/chromium-win/editing/spelling/spelling-expected.png:
  • platform/chromium-win/editing/style/5046875-2-expected.checksum:
  • platform/chromium-win/editing/style/5046875-2-expected.png:
  • platform/chromium-win/editing/style/block-styles-007-expected.checksum:
  • platform/chromium-win/editing/style/block-styles-007-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.png:
  • platform/chromium-win/fast/dom/blur-contenteditable-expected.checksum:
  • platform/chromium-win/fast/dom/blur-contenteditable-expected.png:
10:06 PM Changeset in webkit [74844] by tkent@chromium.org
  • 2 edits in trunk/Tools

2010-12-31 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[DRT/Chromium] Enable mock spell checker on non-OSX
https://bugs.webkit.org/show_bug.cgi?id=51401

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::spellCheck):
6:38 PM Changeset in webkit [74843] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

fast/loader/about-blank-hash-change.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=51788

I'm unable to reproduce the failure locally, so this patch is slightly
speculative. We need to be slighly more careful how we compare the
fragment identifiers for Chromium because Chromium uses a URL parser
that is more agressive about canonicalization.

  • page/Location.cpp: (WebCore::Location::setHash):
6:17 PM Changeset in webkit [74842] by Martin Robinson
  • 3 edits in trunk/WebCore

2010-12-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use GLib/GIO API for FileSystemGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=51617

Complete implementation of FileSystem platform code for GLib. This
converts remaining API points using POSIX calls to platform-independent
GLib calls and fixes other compilation errors.

No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • platform/FileSystem.h: Added forward declarations for GLib types to avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
  • platform/gtk/FileSystemGtk.cpp: (WebCore::openTemporaryFile): Reimplement using only GLib calls. (WebCore::openFile): Ditto. (WebCore::closeFile): Ditto. (WebCore::seekFile): Added implementation. (WebCore::writeToFile): Reimplement using only GLib calls. (WebCore::readFromFile): Ditto.
4:58 PM Changeset in webkit [74841] by Darin Adler
  • 12 edits in trunk/WebCore

2010-12-31 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Some renaming and refactoring of form element code
https://bugs.webkit.org/show_bug.cgi?id=51784

  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): Call new overload of remove for option elements instead of putting the logic in the binding.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes. (WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to "event" instead of "evt". Also updated for name changes. (WebCore::HTMLButtonElement::isActivatedSubmit): Ditto. (WebCore::HTMLButtonElement::setActivatedSubmit): Ditto. (WebCore::HTMLButtonElement::appendFormData): Ditto.
  • html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit to match the getter function name. The name still doesn't seem great.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes. (WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function instead of m_autocomplete data member. (WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member instead of otherwise-unused isDemoted function. (WebCore::HTMLFormElement::submitImplicitly): Updated for name changes. (WebCore::HTMLFormElement::validateInteractively): Removed code to clear m_insubmit. This is now handled by the caller, prepareForSubmission. (WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission here from validateInteractively. Removed unneeded check of m_doingsubmit boolean before setting it. (WebCore::HTMLFormElement::submit): Factored this function into two. One for JavaScript and one for non-JavaScript. Neither function needs a frame argument, because the question being asked, anyPageIsProcessingUserGesture, is a question asked of an entire page group, not a specific frame or page, so it's not important which is the active frame. (WebCore::HTMLFormElement::submitFromJavaScript): Ditto. (WebCore::HTMLFormElement::reset): Updated for name changes. (WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse acceptAttr and got rid of code to set m_autocomplete. (WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw pointer. (WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer and the vector find function. Added a FIXME about the comment. (WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete function instead of m_autocomplete data member. (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto. (WebCore::HTMLFormElement::autoComplete): Ditto.
  • html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete function. Renamed prepareSubmit to prepareForSubmission. Got rid of the frame argument from the submit function and added a new submitFromJavaScript variant. Removed the unneeded isDemoted function. Changed the return type of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed, m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
  • html/HTMLFormElement.idl: Use the function named submitFromJavaScript instead of using CallWith=DynamicFrame because we don't need to know what frame is calling. If we did, it's not clear that the "dynamic" frame would be the right one anyway.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::remove): Added an overload that takes an option element, since the JavaScript binding supports this.
  • html/HTMLSelectElement.h: Ditto.
  • html/ImageInputType.cpp: (WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
  • html/ImageInputType.h: Ditto.
  • html/SubmitInputType.cpp: (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
4:48 PM Changeset in webkit [74840] by jberlin@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

The correct temporary fix for media/video-element-other-namespace-crash.html timing out on
the Windows 7 Release Test bots is to add it to the Windows skipped list.

Unreviewed.

https://bugs.webkit.org/show_bug.cgi?id=51787

  • platform/win/Skipped:
  • platform/win/media/video-element-other-namespace-crash-expected.txt: Removed.
4:36 PM Changeset in webkit [74839] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-12-31 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Pass style for <area> instead of associated <img> when querying whether
the theme draws the focus ring for an <area>
https://bugs.webkit.org/show_bug.cgi?id=51632

Fixes an issue where the style for the associated <img> of an <area>
was passed when considering whether the theme should draw a focus ring
for the <area>. Instead, we should pass the theme the style for the <area>.

It's not possible to test this at this time since there are no themes
that override focus ring drawing for <area>s.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing() such that it's called with respect to the focused <area>.
2:46 PM Changeset in webkit [74838] by abarth@webkit.org
  • 2 edits in trunk/WebKit

2010-12-31 Adam Barth <abarth@webkit.org>

Update SVN ignore property to hide two more external dependencies.

  • chromium: Modified property svn:ignore.
2:10 PM Changeset in webkit [74837] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows-specific (failing) expected results for
media/video-element-other-namespace-crash.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51787

  • platform/win/media/video-element-other-namespace-crash-expected.txt: Added.
1:45 PM Changeset in webkit [74836] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows-specific (failing) expected results for
svg/dom/length-list-parser.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51786

  • platform/win/svg/dom: Added.
  • platform/win/svg/dom/length-list-parser-expected.txt: Added.
12:36 PM Changeset in webkit [74835] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-12-31 Adam Barth <abarth@webkit.org>

Remove custom Chromium expectation for invalid-protocol. Now that we
share more code with JavaScriptCore, we throw exactly the same
exception and therefore can share results.

  • platform/chromium/fast/dom/Window/invalid-protocol-expected.txt: Removed.
12:12 PM Changeset in webkit [74834] by Darin Adler
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Added back the language.

Developers should be using Xcode 3.2.5 or newer.

11:56 AM Changeset in webkit [74833] by abarth@webkit.org
  • 8 edits in trunk/WebCore

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move V8 to WebCore Location implementation
https://bugs.webkit.org/show_bug.cgi?id=51768

  • bindings/generic/BindingFrame.h:
  • bindings/generic/BindingLocation.h:
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::setLocation):
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::hashAccessorSetter): (WebCore::V8Location::hostAccessorSetter): (WebCore::V8Location::hostnameAccessorSetter): (WebCore::V8Location::hrefAccessorSetter): (WebCore::V8Location::pathnameAccessorSetter): (WebCore::V8Location::portAccessorSetter): (WebCore::V8Location::protocolAccessorSetter): (WebCore::V8Location::searchAccessorSetter): (WebCore::V8Location::reloadCallback): (WebCore::V8Location::replaceCallback): (WebCore::V8Location::assignCallback):
9:58 AM Changeset in webkit [74832] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-31 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Eric Seidel.

Make retrieving extraMediaControlsStyleSheet be page dependent.
https://bugs.webkit.org/show_bug.cgi?id=51752

Use themeForPage to retrieve extraMediaControlsStyleSheet for media
controls.

No new tests because no platform-specific theme implementation uses
the passed page pointer yet.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
8:11 AM Changeset in webkit [74831] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Tools

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Ariya Hidayat.

Remove Tools/Scripts/wkstyle
https://bugs.webkit.org/show_bug.cgi?id=51774

This script appears to not have been touched in a while and seems to
have been replaced by check-webkit-style.

  • Scripts/wkstyle: Removed.
5:02 AM Changeset in webkit [74830] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.

https://bugs.webkit.org/show_bug.cgi?id=51709

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
4:43 AM Changeset in webkit [74829] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-12-31 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Add a fast case for ASCII strings in HashAndUTF8CharactersTranslator::equal
https://bugs.webkit.org/show_bug.cgi?id=50517

This change shows about 2% performance win on the xml-parser benchmark.

  • wtf/text/AtomicString.cpp: (WTF::HashAndUTF8CharactersTranslator::equal):
3:59 AM Changeset in webkit [74828] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-12-31 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix after r74800.

  • bindings/js/JSDOMWindowCustom.cpp: Add missing header.
  • bindings/js/JSLocationCustom.cpp: Ditto.
3:47 AM Changeset in webkit [74827] by loislo@chromium.org
  • 2 edits in trunk/Tools

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Coding style fix.

  • DumpRenderTree/chromium/TestShell.h:
3:41 AM Changeset in webkit [74826] by loislo@chromium.org
  • 4 edits in trunk/Tools

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).

It was a problem with Chromium DRT. DevToolsAgent object instance was
attached not only to the inspected page but to the DevTools window too.
As result all the inspector files were interpreted as a content of inspected page
and were transfered to the DevTools scripts panel for debugging etc.

https://bugs.webkit.org/show_bug.cgi?id=51735

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::bindJSObjectsToWindow): (TestShell::createNewWindow):
  • DumpRenderTree/chromium/TestShell.h:
2:16 AM Changeset in webkit [74825] by abarth@webkit.org
  • 2 edits
    1 copy
    1 add
    1 delete in trunk

Move HTML and XML parser benchmarks into PerformanceTests/Parser
https://bugs.webkit.org/show_bug.cgi?id=51772

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PerformanceTests/Parser: Copied from WebCore/benchmarks/parser.

PerformanceTests/Parser:

Add a ChangeLog for tracking changes to the Parser PerformanceTest.

  • ChangeLog: Added.

WebCore:

Remove the benchmarks folder now that it's empty. Future benchmarks
should go in the PerformanceTests directory.

  • benchmarks: Removed.
  • benchmarks/parser: Removed.
  • benchmarks/parser/html-parser.html: Removed.
  • benchmarks/parser/resources: Removed.
  • benchmarks/parser/resources/html5.html: Removed.
  • benchmarks/parser/resources/runner.js: Removed.
  • benchmarks/parser/xml-parser.html: Removed.
2:01 AM Changeset in webkit [74824] by abarth@webkit.org
  • 2 edits
    2 copies in trunk/WebCore

2010-12-31 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Add XML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51612

Move the JavaScript code of html parser into a separate file to share it with xml parser.

  • benchmarks/parser/html-parser.html:
  • benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html. (runFunction): (run): (start):
  • benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
1:51 AM Changeset in webkit [74823] by abarth@webkit.org
  • 9 edits
    1 move in trunk

Move PageLoadTests to PerformanceTests/PageLoad
https://bugs.webkit.org/show_bug.cgi?id=51771

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PageLoadTests: Removed.
  • PageLoadTests/svg: Removed.
  • PageLoadTests/svg/LICENSES: Removed.
  • PageLoadTests/svg/files: Removed.
  • PageLoadTests/svg/files/33041-Samurai.svg: Removed.
  • PageLoadTests/svg/files/42450-under the see.svg: Removed.
  • PageLoadTests/svg/files/42470-flower_from_my_garden_v2.svg: Removed.
  • PageLoadTests/svg/files/44057-drops on a blade.svg: Removed.
  • PageLoadTests/svg/files/Harvey_Rayner.svg: Removed.
  • PageLoadTests/svg/files/az-lizard_benji_park_01.svg: Removed.
  • PageLoadTests/svg/files/bamboo_01.svg: Removed.
  • PageLoadTests/svg/files/cacuts_01.svg: Removed.
  • PageLoadTests/svg/files/cowboy.svg: Removed.
  • PageLoadTests/svg/files/crawfish2_ganson.svg: Removed.
  • PageLoadTests/svg/files/deb9frac1.svg: Removed.
  • PageLoadTests/svg/files/food_leif_lodahl_01.svg: Removed.
  • PageLoadTests/svg/files/france.svg: Removed.
  • PageLoadTests/svg/files/francobollo_gnome_ezechi_02.svg: Removed.
  • PageLoadTests/svg/files/gearflowers.svg: Removed.
  • PageLoadTests/svg/files/hereGear4.svg: Removed.
  • PageLoadTests/svg/files/mtsthelens.svg: Removed.
  • PageLoadTests/svg/files/mtsthelens0.jpg: Removed.
  • PageLoadTests/svg/files/world-iso.svg: Removed.
  • PageLoadTests/svg/files/worldcup.svg: Removed.
  • PageLoadTests/svg/svg.pltsuite: Removed.
  • PerformanceTests/PageLoad: Copied from PageLoadTests.
  • Sources/cmake/WebKitPackaging.cmake:

PerformanceTests/PageLoad:

Update URLs to point to the new directory name.

  • svg/svg.pltsuite:

Tools:

Update references to PageLoadTests to point to the new location.

  • Scripts/run-pageloadtest:
  • Scripts/webkitpy/common/config/build.py:

Websites/bugs.webkit.org:

Update list of top-level open-source directories.

  • PrettyPatch/PrettyPatch.rb:
1:28 AM Changeset in webkit [74822] by abarth@webkit.org
  • 7 edits
    1 move
    1 add in trunk

Move SunSpider into PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=51769

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PerformanceTests: Added.
  • PerformanceTests/SunSpider: Copied from SunSpider.
  • Sources/cmake/WebKitPackaging.cmake:
  • SunSpider: Removed.
  • SunSpider/SunSpider.make: Removed.
  • SunSpider/TODO: Removed.
  • SunSpider/UNCOVERED: Removed.
  • SunSpider/hosted: Removed.
  • SunSpider/hosted/json2.js: Removed.
  • SunSpider/hosted/sunspider.css: Removed.
  • SunSpider/hosted/sunspider.html: Removed.
  • SunSpider/hosted/versions.html: Removed.
  • SunSpider/make-hosted: Removed.
  • SunSpider/resources: Removed.
  • SunSpider/resources/TEMPLATE.html: Removed.
  • SunSpider/resources/driver-TEMPLATE.html: Removed.
  • SunSpider/resources/results-TEMPLATE.html: Removed.
  • SunSpider/resources/sunspider-analyze-results.js: Removed.
  • SunSpider/resources/sunspider-compare-results.js: Removed.
  • SunSpider/resources/sunspider-standalone-compare.js: Removed.
  • SunSpider/resources/sunspider-standalone-driver.js: Removed.
  • SunSpider/sunspider: Removed.
  • SunSpider/sunspider-compare-results: Removed.
  • SunSpider/tests: Removed.
  • SunSpider/tests/parse-only: Removed.
  • SunSpider/tests/parse-only/LIST: Removed.
  • SunSpider/tests/parse-only/concat-jquery-mootools-prototype.js: Removed.
  • SunSpider/tests/parse-only/jquery-1.3.2.js: Removed.
  • SunSpider/tests/parse-only/mootools-1.2.2-core-nc.js: Removed.
  • SunSpider/tests/parse-only/prototype-1.6.0.3.js: Removed.
  • SunSpider/tests/sunspider-0.9: Removed.
  • SunSpider/tests/sunspider-0.9.1: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-cube.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-morph.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-raytrace.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/LIST: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-binary-trees.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-fannkuch.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-nbody.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-nsieve.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-3bit-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-bitwise-and.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-nsieve-bits.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/controlflow-recursive.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-aes.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-md5.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-sha1.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/date-format-tofte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/date-format-xparb.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-cordic.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-partial-sums.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-spectral-norm.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/regexp-dna.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-base64.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-fasta.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-tagcloud.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-unpack-code.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-validate-input.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-cube.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-morph.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-raytrace.js: Removed.
  • SunSpider/tests/sunspider-0.9/LIST: Removed.
  • SunSpider/tests/sunspider-0.9/access-binary-trees.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-fannkuch.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-nbody.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-nsieve.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-3bit-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-bitwise-and.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-nsieve-bits.js: Removed.
  • SunSpider/tests/sunspider-0.9/controlflow-recursive.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-aes.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-md5.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-sha1.js: Removed.
  • SunSpider/tests/sunspider-0.9/date-format-tofte.js: Removed.
  • SunSpider/tests/sunspider-0.9/date-format-xparb.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-cordic.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-partial-sums.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-spectral-norm.js: Removed.
  • SunSpider/tests/sunspider-0.9/regexp-dna.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-base64.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-fasta.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-tagcloud.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-unpack-code.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-validate-input.js: Removed.
  • SunSpider/tests/ubench: Removed.
  • SunSpider/tests/ubench/LIST: Removed.
  • SunSpider/tests/ubench/function-closure.js: Removed.
  • SunSpider/tests/ubench/function-correct-args.js: Removed.
  • SunSpider/tests/ubench/function-empty.js: Removed.
  • SunSpider/tests/ubench/function-excess-args.js: Removed.
  • SunSpider/tests/ubench/function-missing-args.js: Removed.
  • SunSpider/tests/ubench/function-sum.js: Removed.
  • SunSpider/tests/ubench/loop-empty-resolve.js: Removed.
  • SunSpider/tests/ubench/loop-empty.js: Removed.
  • SunSpider/tests/ubench/loop-sum.js: Removed.
  • SunSpider/tests/v8-v4: Removed.
  • SunSpider/tests/v8-v4/LIST: Removed.
  • SunSpider/tests/v8-v4/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v4/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v4/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v4/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v4/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v4/v8-richards.js: Removed.
  • SunSpider/tests/v8-v4/v8-splay.js: Removed.
  • SunSpider/tests/v8-v5: Removed.
  • SunSpider/tests/v8-v5/LIST: Removed.
  • SunSpider/tests/v8-v5/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v5/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v5/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v5/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v5/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v5/v8-richards.js: Removed.
  • SunSpider/tests/v8-v5/v8-splay.js: Removed.
  • SunSpider/tests/v8-v6: Removed.
  • SunSpider/tests/v8-v6/LIST: Removed.
  • SunSpider/tests/v8-v6/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v6/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v6/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v6/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v6/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v6/v8-richards.js: Removed.
  • SunSpider/tests/v8-v6/v8-splay.js: Removed.
  • SunSpider/xcopy.excludes: Removed.

Tools:

Update these scripts to point to the new location.

  • Scripts/run-sunspider:
  • Scripts/sunspider-compare-results:

Websites/bugs.webkit.org:

Update list of top-level open-source directories.

  • PrettyPatch/PrettyPatch.rb:

Dec 30, 2010:

8:02 PM Changeset in webkit [74821] by mihaip@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
https://bugs.webkit.org/show_bug.cgi?id=51728

Add implementation of the Mac WebThemeEngine that uses an NSScroller
to render top-level scrollbars. This makes them match the Mac port's
use of an NSScrollView, which means that we'll be able to share more
pixel baselines.

The new rendering code will not be activated until the
USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
ScrollbarThemeChromiumMac.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestShellMac.mm: (platformInit):
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added. (+[FakeActiveWindow alwaysActiveWindow]): (+[FakeActiveWindow alwaysInactiveWindow]): (-[FakeActiveWindow initWithActiveControls:]): (-[FakeActiveWindow _hasActiveControls]): (WebThemeEngineDRTMac::paintScrollbarThumb): (stateToHIEnableState): (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb): (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
https://bugs.webkit.org/show_bug.cgi?id=51728

Roll DEPS to pick up WebThemeEngine changes.

  • DEPS:
6:44 PM Changeset in webkit [74820] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716

  • fast/canvas/webgl/webgl-specific-expected.txt: Sync with khronos: refactor the test, also update the stencil setting test due to spec change.
  • fast/canvas/webgl/webgl-specific.html: Ditto.
5:53 PM Changeset in webkit [74819] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Skipping media/video-element-other-namespace-crash.html for chromium
since it uses codecs that chromium does not support.

  • platform/chromium/test_expectations.txt:
5:30 PM Changeset in webkit [74818] by zmo@google.com
  • 3 edits in trunk/WebCore

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings. (WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error. (WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto. (WebCore::WebGLRenderingContext::stencilMask): Ditto. (WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto. (WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
  • html/canvas/WebGLRenderingContext.h: Declare stencil setting members.

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716

  • fast/canvas/webgl/webgl-specific-expected.txt: Sync with khronos: refactor the test, also update the stencil setting test due to spec change.
  • fast/canvas/webgl/webgl-specific.html: Ditto.
5:03 PM Changeset in webkit [74817] by Martin Robinson
  • 4 edits
    2 adds in trunk/WebCore

2010-12-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=51755

Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
step to landing support for the new GTK+ 3.x theming API.

No new tests. This should not change functionality.

  • GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method. (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto. (WebCore::RenderThemeGtk::paintMediaButton): Ditto. (WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
  • platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
  • platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk that will eventually be platform-dependent.
  • platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
4:50 PM Changeset in webkit [74816] by jschuh@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Reverting r74292 because it introduced a crash with ruby text.
https://bugs.webkit.org/show_bug.cgi?id=51637

Test: fast/css/counters/counter-ruby-text-cleared.html

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addChild):
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode):

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Check for crash when deleting ruby text with counters.
https://bugs.webkit.org/show_bug.cgi?id=51637

  • fast/css/counters/counter-ruby-text-cleared-expected.txt: Added.
  • fast/css/counters/counter-ruby-text-cleared.html: Added.
4:39 PM Changeset in webkit [74815] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-12-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Ariya Hidayat.

[CMake] Add WTF_HEADERS
https://bugs.webkit.org/show_bug.cgi?id=51741

Add the WTF headers to show them in Visual Studio.

  • wtf/CMakeLists.txt:
  • wtf/CMakeListsWinCE.txt:
4:24 PM Changeset in webkit [74814] by Darin Adler
  • 7 edits
    2 deletes in trunk/WebCore

2010-12-30 Darin Adler <Darin Adler>

Reviewed by David Kilzer.

Remove unused JSBinding source files
https://bugs.webkit.org/show_bug.cgi?id=51762

  • bindings/js/JSBinding.h: Removed.
  • bindings/js/specialization: Removed.
  • bindings/js/specialization/JSBindingState.cpp: Removed.
  • bindings/js/specialization/JSBindingState.h: Removed.
  • CMakeLists.txt: Removed references to files.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
3:47 PM Changeset in webkit [74813] by commit-queue@webkit.org
  • 7 edits in trunk

2010-12-30 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672

  • WebKit.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1

2010-12-30 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672

  • wtf/wtf.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1

2010-12-30 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672

  • DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1
  • WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1
3:41 PM Changeset in webkit [74812] by tonyg@chromium.org
  • 13 edits in trunk/WebCore

2010-12-30 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Remove Document.h include from some headers where it isn't necessary
https://bugs.webkit.org/show_bug.cgi?id=51730

No new tests because no new functionality.

  • editing/EditingStyle.cpp:
  • editing/EditingStyle.h:
  • editing/SelectionController.h:
  • editing/visible_units.h:
  • html/HTMLAudioElement.h:
  • html/HTMLBodyElement.h:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.h:
  • xml/DOMParser.cpp:
  • xml/DOMParser.h: (WebCore::DOMParser::create): (WebCore::DOMParser::DOMParser):
3:30 PM Changeset in webkit [74811] by Laszlo Gombos
  • 2 edits in trunk/Tools

2010-12-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by David Kilzer.

[Qt] [Symbian] Fix build-webkit script for Symbian
https://bugs.webkit.org/show_bug.cgi?id=51509

Set the OUTPUT_DIR for Symbian to be the same as the source
directory.

  • Scripts/webkitdirs.pm:
1:55 PM Changeset in webkit [74810] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-12-30 Benjamin C Meyer <bmeyer@rim.com>

Reviewed by Darin Adler.

bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
which is required when NOTIFICATIONS is enabled.

https://bugs.webkit.org/show_bug.cgi?id=51761

  • CMakeLists.txt:
1:46 PM Changeset in webkit [74809] by Martin Robinson
  • 3 edits in trunk/Tools

2010-12-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Darin Adler.

check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
https://bugs.webkit.org/show_bug.cgi?id=51758

Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.

  • Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
12:59 PM Changeset in webkit [74808] by Antti Koivisto
  • 2 edits in trunk/WebCore

Not reviewed.

Revert accidental project file change.

  • WebCore.xcodeproj/project.pbxproj:
12:57 PM Changeset in webkit [74807] by Antti Koivisto
  • 11 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=51134
Move loading related code from MemoryCache to CachedResourceLoader

Reviewed by Darin Adler.

  • Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
  • Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
  • Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
  • Add MemoryCache::add
  • Refactor the decision on whether to reload, revalidate or use the existing resource to a single function, CachedResourceLoader::determineRevalidationPolicy
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
if ever taken (since it passes null CachedResourceLoader pointer).


  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):

Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.


(WebCore::CachedResource::setLoadPriority):

Check for Unresolved value before setting.


  • loader/cache/CachedResource.h:

(WebCore::CachedResource::setOwningCachedResourceLoader):

Rename to be bit less mysterious.


  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):

This was moved from MemoryCache.


(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):

This was moved/merged from MemoryCache.


(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

This combines MemoryCache::requestResource and the existing method.


(WebCore::CachedResourceLoader::revalidateResource):

This was moved from MemoryCache.


(WebCore::CachedResourceLoader::loadResource):

New method for initiating loading.


(WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):

Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus


  • loader/cache/CachedResourceLoader.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::add):

  • loader/cache/MemoryCache.h:

(WebCore::MemoryCache::remove):

12:53 PM Changeset in webkit [74806] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-12-30 Steve Block <steveblock@google.com>

Reviewed by Gavin Barraclough.

Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
https://bugs.webkit.org/show_bug.cgi?id=51740

This is a policy decision for Android.

No new tests, simply enabling existing, tested code on Android.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
12:29 PM Changeset in webkit [74805] by mihaip@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium baseline update.

[Chromium] svg/dom/length-list-parser.html fails on Chromium Linux after r74788 and r74803
https://bugs.webkit.org/show_bug.cgi?id=51759

r74803 added chromium-win baselines for svg/dom/length-list-parser.html
but chromium-linux shouldn't use them (despite having them in its
fallback path). Copy the base expectations into chromium-linux.

  • platform/chromium-linux/svg/dom/length-list-parser-expected.txt: Added.
12:21 PM Changeset in webkit [74804] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark a few inspector tests as slow, they occasionally time out with
debug builds.

  • platform/chromium/test_expectations.txt:
11:40 AM Changeset in webkit [74803] by jschuh@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-12-30 Justin Schuh <jschuh@chromium.org>

Unreviewed.

chromium test expectations after r74788 for svg/dom/length-list-parser.html

  • platform/chromium-win/svg/dom/length-list-parser-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:34 AM Changeset in webkit [74802] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-12-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use OS(WINDOWS) instead of COMPILER(MSVC) in FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=51743

Most of the ifdefs belong to windows and not to the MSVC compiler.

  • wtf/FastMalloc.cpp:
11:31 AM Changeset in webkit [74801] by yael.aharon@nokia.com
  • 6 edits
    2 adds in trunk

REGRESSION: fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342

Reviewed by Adam Barth.

WebCore:

Do not reload the page when submitting a form, using "GET" method, and the
form action url matches the location url, except for the fragment.

Test: fast/forms/submit-change-fragment.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldScrollToAnchor):

  • loader/FrameLoader.h:

LayoutTests:

  • fast/forms/submit-change-fragment-expected.txt: Added.
  • fast/forms/submit-change-fragment.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
11:27 AM Changeset in webkit [74800] by Darin Adler
  • 13 edits in trunk/WebCore

2010-12-30 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move security logic out of the JavaScript binding for location into the DOM class
https://bugs.webkit.org/show_bug.cgi?id=51714

  • WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h, and JSBinding.h. Later, we'll remove them from other project files and delete the source files.
  • bindings/js/JSBinding.h: Emptied out, marked for later deletion.
  • bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL function, unused toLexicalFrame function, unused completeURL function, unused getCachedDOMStructure and cacheDOMStructure overloads, and unused getCachedDOMConstructor and cacheDOMConstruction functions. (WebCore::activeDOMWindow): Added. (WebCore::firstDOMWindow): Added. (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through JSBindingState, since the latter is an unneeded abstraction. (WebCore::processingUserGesture): Changed to call ScriptController's function rather than calling through JSBindingState, which is an unneeded abstraction
  • bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly named allowsAccessFromFrame functions, which answer the question of whether script is allowed access *to* a frame.
  • bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes. (WebCore::JSDOMWindow::setLocation): Streamlined by using the new activeDOMWindow and firstDOMWindow functions. (WebCore::JSDOMWindow::open): Ditto. (WebCore::JSDOMWindow::showModalDialog): Ditto. (WebCore::JSDOMWindow::postMessage): Ditto.
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): Changed to pass the active and first windows through to the Location::setHref function, with it doing the rest of the work. This moves work out of the DOM binding that belongs in the DOM itself. Eventually such functions could even be automatically generated by the bindings script. (WebCore::JSLocation::setProtocol): Ditto. (WebCore::JSLocation::setHost): Ditto. (WebCore::JSLocation::setHostname): Ditto. (WebCore::JSLocation::setPort): Ditto. (WebCore::JSLocation::setPathname): Ditto. (WebCore::JSLocation::setSearch): Ditto. (WebCore::JSLocation::setHash): Ditto. (WebCore::JSLocation::replace): Ditto. (WebCore::JSLocation::reload): Ditto. (WebCore::JSLocation::assign): Ditto.
  • bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
  • bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us to use this function for Location::replace, which is the same as setLocation except that it locks both history and the back/forward list.
  • page/DOMWindow.h: Ditto.
  • page/Location.cpp: (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security logic there does not have to be repeated or even refactored. (WebCore::Location::setProtocol): Ditto. (WebCore::Location::setHost): Ditto. (WebCore::Location::setHostname): Ditto. (WebCore::Location::setPort): Ditto. (WebCore::Location::setPathname): Ditto. (WebCore::Location::setSearch): Ditto. (WebCore::Location::setHash): Ditto. (WebCore::Location::assign): Ditto. (WebCore::Location::replace): Ditto. (WebCore::Location::reload): Added. Security logic was refactored from the code in JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems possibly unneeded.
  • page/Location.h: Fixed indentation on the whole file. Added the new functions above. (WebCore::Location::create): (WebCore::Location::frame):
9:26 AM Changeset in webkit [74799] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-12-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Pasting a style property with value should automatically split it into prop/value
https://bugs.webkit.org/show_bug.cgi?id=51581

The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
and the edit focus is transferred to the value field.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.selectElement): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector.completeURL): Drive-by: return full URLs as-is. (WebInspector.startEditing.cleanUpAfterEditing): (WebInspector.startEditing): (WebInspector.startEditing.pasteEventListener): (WebInspector.startEditing.keyDownEventListener):
7:32 AM Changeset in webkit [74798] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
https://bugs.webkit.org/show_bug.cgi?id=51745

  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set enabled):
7:28 AM Changeset in webkit [74797] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
https://bugs.webkit.org/show_bug.cgi?id=51748

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts): (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
5:11 AM Changeset in webkit [74796] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-30 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip the test, it's running fine locally.

media/audio-delete-while-slider-thumb-clicked.html fails
https://bugs.webkit.org/show_bug.cgi?id=37546

  • platform/gtk/Skipped:
5:04 AM Changeset in webkit [74795] by mnaganov@chromium.org
  • 6 edits
    1 copy in trunk/WebCore

2010-12-30 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).

https://bugs.webkit.org/show_bug.cgi?id=51713

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::memoryAccessorGetter):
  • bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp. (WebCore::V8Performance::memoryAccessorGetter):
  • page/Console.idl:
  • page/Performance.idl:
3:32 AM Changeset in webkit [74794] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-12-30 Steve Block <steveblock@google.com>

Reviewed by Sam Weinig.

Visiting macnn.com often causes SQL spew via geolocation database
https://bugs.webkit.org/show_bug.cgi?id=51557

If the Geolocation position cache database path has not been set, early-out
rather than using an empty path and thus failing to open the database.
This avoids SQL log spew.

Also, avoid starting the database thread until the path has been set, and
shorten the thread name to avoid warnings due to exceeding 30 characters.

No new tests, implementation clean-up only.

  • page/GeolocationPositionCache.cpp: (WebCore::GeolocationPositionCache::addUser): (WebCore::GeolocationPositionCache::removeUser): (WebCore::GeolocationPositionCache::setDatabasePath): (WebCore::GeolocationPositionCache::startBackgroundThread):
3:02 AM Changeset in webkit [74793] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-30 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping another editing flacky test.

  • platform/gtk/Skipped: skip editing/selection/extend-by-character-005.html.
2:17 AM Changeset in webkit [74792] by Philippe Normand
  • 8 edits in trunk

2010-12-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] minimal build fails at link time due to missing sqlite3 symbols
https://bugs.webkit.org/show_bug.cgi?id=51327

  • configure.ac: Error out if SQLite3 wasn't found while at least one of the features depending on it has been enabled.

WebCore:

Reviewed by Martin Robinson.

[GTK] minimal build fails at link time due to missing sqlite3 symbols
https://bugs.webkit.org/show_bug.cgi?id=51327

Guard the code calling sqlite3 with the ENABLE(DATABASE) check.

No new tests, build fix only.

  • platform/sql/SQLiteAuthorizer.cpp:
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteFileSystem.cpp:
  • platform/sql/SQLiteStatement.cpp:
  • platform/sql/SQLiteTransaction.cpp:
1:29 AM Changeset in webkit [74791] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>

Chromium test expectation update for svg/dom/length-list-parser.html

  • platform/chromium/test_expectations.txt:
1:25 AM Changeset in webkit [74790] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>

Chromium test expectation update for media/video-element-other-namespace-crash.html

  • platform/chromium/test_expectations.txt:
1:18 AM WinCE edited by Patrick Gansterer
(diff)
12:29 AM Changeset in webkit [74789] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Skip media/video-element-other-namespace-crash.html, like other media tests on qt platform.

  • platform/qt/Skipped:
12:12 AM Changeset in webkit [74788] by jschuh@chromium.org
  • 5 edits in trunk

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/SVGLength.cpp: (WebCore::stringToLengthType): (WebCore::SVGLength::setValueAsString):

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Adding long float string to improve test coverage.
https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/dom/length-list-parser.html:
  • svg/dom/length-list-parser-expected.txt:
12:02 AM Changeset in webkit [74787] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Create a helper function for finding descendent video elements for a node.
https://bugs.webkit.org/show_bug.cgi?id=51696

Test: media/video-element-other-namespace-crash.html

  • html/MediaDocument.cpp: (WebCore::descendentVideoElement): helper function. (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions. (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.

2010-12-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that we do not crash when trying to find video elements in the media document.
https://bugs.webkit.org/show_bug.cgi?id=51696

  • media/video-element-other-namespace-crash-expected.txt: Added.
  • media/video-element-other-namespace-crash.html: Added.
Note: See TracTimeline for information about the timeline view.