Context Navigation

← Previous Period
Next Period →

Timeline

Jan 30, 2012:

11:50 PM Changeset in webkit [106339] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/Skipped: Skip failing tests.

11:45 PM Changeset in webkit [106338] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [BlackBerry] Add BlackBerry UA Strings to the Inspector's UA switcher
https://bugs.webkit.org/show_bug.cgi?id=77343

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-01-30
Reviewed by Yury Semikhatsky.

inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

11:37 PM Changeset in webkit [106337] by yurys@chromium.org

10 edits
2 adds in trunk

Web Inspector: should be possible to step through all event listeners when event listener breakpoint is hit
https://bugs.webkit.org/show_bug.cgi?id=77331

Source/WebCore:

Inspector instrumentation is called before and after each event handler invokation.
In case inspector front-end is closed it is no-op, otherwise it may stop execution
on an event listener breakpoint.

Reviewed by Pavel Feldman.

Test: inspector/debugger/step-through-event-listeners.html

dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willDispatchEventImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore):
(WebCore::InspectorInstrumentation::didHandleEventImpl):
(WebCore::InspectorInstrumentation::didDispatchEventImpl):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::didDispatchEventOnWindowImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willHandleEvent):
(WebCore):
(WebCore::InspectorInstrumentation::didHandleEvent):

LayoutTests:

Test that debugger will stop in each event listener when pausing on an event listener
breakpoint.

Reviewed by Pavel Feldman.

inspector/debugger/step-through-event-listeners-expected.txt: Added.
inspector/debugger/step-through-event-listeners.html: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:

10:36 PM Changeset in webkit [106336] by hayato@chromium.org

5 edits in trunk

Attach light children after removing a shadow root.
https://bugs.webkit.org/show_bug.cgi?id=74267

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html

fast/dom/shadow/dynamically-created-shadow-root.html:

dom/Element.cpp:

(WebCore::Element::removeShadowRoot):

LayoutTests:

fast/dom/shadow/dynamically-created-shadow-root-expected.html:
fast/dom/shadow/dynamically-created-shadow-root.html:

10:23 PM Changeset in webkit [106335] by commit-queue@webkit.org

22 edits in trunk/Source

Unreviewed, rolling out r106324.
http://trac.webkit.org/changeset/106324
https://bugs.webkit.org/show_bug.cgi?id=77406

Broke CCLayerTreeHostTestLayerOcclusion.runMultiThread and
runSingleThread (Requested by yuzo1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-30

Source/WebCore:

platform/graphics/FloatRect.cpp:
platform/graphics/FloatRect.h:

(WebCore):

platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

platform/graphics/chromium/Canvas2DLayerChromium.h:

(WebCore):
(Canvas2DLayerChromium):

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

platform/graphics/chromium/ContentLayerChromium.h:

(WebCore):
(ContentLayerChromium):

platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

platform/graphics/chromium/ImageLayerChromium.h:

(WebCore):
(ImageLayerChromium):

platform/graphics/chromium/LayerChromium.cpp:
platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::paintContentsIfDirty):
(LayerChromium):

platform/graphics/chromium/RenderSurfaceChromium.h:
platform/graphics/chromium/TiledLayerChromium.cpp:
platform/graphics/chromium/TiledLayerChromium.h:

(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):

platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::enclosedIntRect):
(WebCore):

Source/WebKit/chromium:

tests/CCLayerTreeHostCommonTest.cpp:

(WebCore):

tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):

tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

tests/TiledLayerChromiumTest.cpp:

(FakeLayerTextureUpdater):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::FakeLayerTextureUpdater::prepareToUpdate):

10:20 PM Changeset in webkit [106334] by rniwa@webkit.org

3 edits in trunk

Build fix after r106321.

Websites/webkit-perf.appspot.com/report_handler.py:
Websites/webkit-perf.appspot.com/manifest_handler.py:

(ManifestHandler.get):

9:51 PM Changeset in webkit [106333] by kevino@webkit.org

2 edits in trunk/Tools

[wx] Unreviewed. Update download URLs to new domain.

9:47 PM Changeset in webkit [106332] by commit-queue@webkit.org

3 edits
2 adds in trunk

Fix ASSERT fail within AudioBus::processWithGainFrom()
https://bugs.webkit.org/show_bug.cgi?id=76685

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-01-30
Reviewed by Daniel Bates.

Source/WebCore:

Test: webaudio/audionode-connect-order.html

webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):

LayoutTests:

webaudio/audionode-connect-order-expected.txt: Added.
webaudio/audionode-connect-order.html: Added.

9:04 PM Changeset in webkit [106331] by rolandsteiner@chromium.org

6 edits
10 adds in trunk

Source/WebCore:

Implementing support for <style scoped>:
Add a vector stack to CSSStyleSelector that keeps track of encountered scoping elements. This is
used for O(1) access to all relevant style sheets for a given element.
Adapt matching of author style sheets to also consult appropriate scoped sheets.
Finally, prevent style sharing from crossing into/out of scoped style boundaries.

Reviewed by Antti Koivisto.

Tests: fast/css/style-scoped/style-scoped-attach.html

fast/css/style-scoped/style-scoped-basic.html
fast/css/style-scoped/style-scoped-detach.html
fast/css/style-scoped/style-scoped-remove-scoped.html
fast/css/style-scoped/style-scoped-set-scoped.html

css/CSSStyleSelector.cpp:

(RuleSet):
(WebCore::CSSStyleSelector::CSSStyleSelector): add code for scoped style sheets
(WebCore::CSSStyleSelector::collectFeatures): ditto
(WebCore):
(WebCore::CSSStyleSelector::determineScopingElement): determine whether an author sheet is scoped (and to which scope), or global
(WebCore::CSSStyleSelector::scopedRuleSetForElement): returns the RuleSet for the <style scoped> contained by the passed-in element (if any), or 0
(WebCore::CSSStyleSelector::appendAuthorStylesheets): add code for scoped style sheets
(WebCore::CSSStyleSelector::setupScopingElementStack): determine scoping element ancestors of the given element
(WebCore::CSSStyleSelector::pushParent): simplify and refactor SelectorChecker::pushParent, as code in CSStyleSelector needs partial access
(WebCore::CSSStyleSelector::popParent): ditto
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules): helper function
(WebCore::CSSStyleSelector::matchAuthorRules): use AuthorRuleSetIterator to iterate over all relevant RuleSets
(WebCore::CSSStyleSelector::matchRules): adapt for scoped style rules
(WebCore::CSSStyleSelector::matchAllRules): ditto
(WebCore::CSSStyleSelector::locateCousinList): prevent style sharing across scope boundaries
(WebCore::CSSStyleSelector::canShareStyleWithElement): ditto
(WebCore::CSSStyleSelector::locateSharedStyle): ditto
(WebCore::CSSStyleSelector::pseudoStyleForElement): changed call to matchAuthorRules
(WebCore::CSSStyleSelector::styleForPage): add comment
(WebCore::CSSStyleSelector::checkRegionStyle): add global scope parameter
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement): changed call to matchAuthorRules
(WebCore::RuleSet::addRulesFromSheet): adapt for scoped style rules

css/CSSStyleSelector.h:

(CSSStyleSelector):
(WebCore::CSSStyleSelector::ScopeStackFrame::ScopeStackFrame): struct holding an Element pointer and a RuleSet pointer, to be used in a Vector
(WebCore::CSSStyleSelector::scopingElementStackIsConsistent): returns if the last seen parent matches the passed-in element

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::setupParentStack): set up the parent stack (refactoring)
(WebCore::SelectorChecker::pushParent): simplify and refactor

css/SelectorChecker.h:

(WebCore::SelectorChecker::popParent): ditto
(WebCore::SelectorChecker::parentStackIsEmpty): ditto
(WebCore::SelectorChecker::parentStackIsConsistent): make parameter const

LayoutTests:

Test that <style scoped> affects styles and is updated correctly:
-) basic test
-) test setting/un-setting the 'scoped' attribute
-) test inserting/removing a whole <style scoped> element

Reviewed by Antti Koivisto.

fast/css/style-scoped/style-scoped-attach-expected.txt: Added.
fast/css/style-scoped/style-scoped-attach.html: Added.
fast/css/style-scoped/style-scoped-basic-expected.txt: Added.
fast/css/style-scoped/style-scoped-basic.html: Added.
fast/css/style-scoped/style-scoped-detach-expected.txt: Added.
fast/css/style-scoped/style-scoped-detach.html: Added.
fast/css/style-scoped/style-scoped-remove-scoped-expected.txt: Added.
fast/css/style-scoped/style-scoped-remove-scoped.html: Added.
fast/css/style-scoped/style-scoped-set-scoped-expected.txt: Added.
fast/css/style-scoped/style-scoped-set-scoped.html: Added.

9:03 PM Changeset in webkit [106330] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/efl

[EFL] Define the names of view smart class
https://bugs.webkit.org/show_bug.cgi?id=76370

Patch by Eunsol Park <eunsol47.park@samsung.com> on 2012-01-30
Reviewed by Andreas Kling.

Strings of ewk_tiled_view's name were defined differently,
so the definitions were modified to make users not confused.

ewk/ewk_private.h:
ewk/ewk_view.cpp:
ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_class_new):

ewk/ewk_view_tiled.cpp:

(ewk_view_tiled_smart_set):
(_ewk_view_tiled_smart_class_new):

8:59 PM Changeset in webkit [106329] by mrowe@apple.com

3 edits
2 adds in tags/Safari-535.18.5

Merge r106305.

8:52 PM Changeset in webkit [106328] by mrowe@apple.com

5 edits in tags/Safari-535.18.5/Source

Versioning.

8:42 PM Changeset in webkit [106327] by mrowe@apple.com

1 copy in tags/Safari-535.18.5

New tag.

8:39 PM Changeset in webkit [106326] by kevino@webkit.org

4 edits in trunk

[wx] Update build dirs and includes after recent trunk changes.

8:37 PM Changeset in webkit [106325] by yuzo@google.com

2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change
plugins/crash-restoring-plugin-page-from-page-cache.html fails or timeouts.

platform/chromium/test_expectations.txt:

8:03 PM Changeset in webkit [106324] by commit-queue@webkit.org

22 edits in trunk/Source

[chromium] Compute occlusion during paint loop
https://bugs.webkit.org/show_bug.cgi?id=76858

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-30
Reviewed by James Robinson.

Source/WebCore:

New unit tests in TiledLayerChromiumTest.cpp, CCLayerTreeHostCommonTest.cpp, CCLayerTreeHostTest.cpp

platform/graphics/FloatRect.cpp:

(WebCore::enclosedIntRect):
(WebCore):

platform/graphics/FloatRect.h:

(WebCore):

platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):

platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::contentToScreenSpaceTransform):
(WebCore):
(WebCore::LayerChromium::addSelfToOccludedScreenSpace):
(WebCore::LayerChromium::isPaintedAxisAlignedInScreen):

platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::paintContentsIfDirty):
(LayerChromium):

platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):

platform/graphics/chromium/TiledLayerChromium.h:

(WebCore):
():

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(RenderSurfaceRegion):
(WebCore):
(WebCore::pushTargetRenderSurfaceRegion):
(WebCore::popAndPushTargetRenderSurfaceRegion):
(WebCore::CCLayerTreeHost::paintLayerContents):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
():

platform/graphics/chromium/cc/CCQuadCuller.cpp:

Source/WebKit/chromium:

tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):
(WebCore):

tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF):
(TestLayerChromium):
(WTF::TestLayerChromium::create):
(WTF::TestLayerChromium::paintContentsIfDirty):
(WTF::TestLayerChromium::drawsContent):
(WTF::TestLayerChromium::occludedScreenSpace):
(WTF::TestLayerChromium::clearOccludedScreenSpace):
(WTF::TestLayerChromium::TestLayerChromium):
(WTF::setLayerPropertiesForTesting):
(CCLayerTreeHostTestLayerOcclusion):
(WTF::CCLayerTreeHostTestLayerOcclusion::CCLayerTreeHostTestLayerOcclusion):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusion::afterTest):

tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

tests/TiledLayerChromiumTest.cpp:

(WTF::FakeLayerTextureUpdater::setOpaquePaintRect):
(FakeLayerTextureUpdater):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::FakeLayerTextureUpdater::prepareToUpdate):
(WTF::TEST):
(WTF):

7:53 PM Changeset in webkit [106323] by caio.oliveira@openbossa.org

14 edits
2 adds in trunk/Source/WebCore

Add ElementAttributeData class to replace internal uses of NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=77233

Reviewed by Andreas Kling.

Move part of non-DOM functionality of NamedNodeMap into a separate class. This is
the first step toward the goal of separating NamedNodeMap from internal attribute
storage, as described in https://bugs.webkit.org/show_bug.cgi?id=75069.

The internal attribute storage is exposed as attributeData() in Element, and when
necessary (because it has no back pointer to Element) via methods in Element.

No new tests. Except from setClass() change this is just moving the code, no new
feature was added.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
dom/DOMAllInOne.cpp:
dom/Element.cpp:

(WebCore::Element::idAttributeChanged):

dom/Element.h:

(WebCore::Element::attributeData):
(WebCore::Element::ensureAttributeData):
(Element):
(WebCore::Element::idForStyleResolution):

dom/ElementAttributeData.cpp: Added.

(WebCore):
(WebCore::ElementAttributeData::setClass): the only caller of this function
already deal with the case when the element has no class, so don't do it here.

dom/ElementAttributeData.h: Added.

(WebCore):
(ElementAttributeData):
(WebCore::ElementAttributeData::clearClass):
(WebCore::ElementAttributeData::classNames):
(WebCore::ElementAttributeData::idForStyleResolution):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::ElementAttributeData):

dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::clearAttributes):

dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::attributeData):
(NamedNodeMap):

dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged):

dom/StyledElement.h:

(WebCore::StyledElement::classNames):

html/ClassList.cpp:

(WebCore::ClassList::classNames):

7:28 PM Changeset in webkit [106322] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.6

Small build fixes.

configure.ac: Correct the version number to be 1.6.2 and fix

a bad merge of gtkdoc patches.

7:14 PM Changeset in webkit [106321] by rniwa@webkit.org

8 edits in trunk

Python code in webkit-perf.appspot.com uses camelCase
https://bugs.webkit.org/show_bug.cgi?id=77392

Reviewed by Adam Barth.

Use PEP8 style naming conventions instead of camelCase.

Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler.post):
(CreateHandler._create_builder):
(CreateHandler._create_branch):
(CreateHandler._create_platform):

Websites/webkit-perf.appspot.com/dashboard_handler.py:

(DashboardHandler.get):

Websites/webkit-perf.appspot.com/manifest_handler.py:

(ManifestHandler.get):

Websites/webkit-perf.appspot.com/merge_tests_handler.py:

(MergeTestsHandler.post):

Websites/webkit-perf.appspot.com/models.py:

(create_in_transaction_with_numeric_id_holder):
(delete_model_with_numeric_id_holder):
(modelFromNumericId):
(Builder.authenticate):
(Builder.hashed_password):
(Test.cache_key):

Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):
(ReportHandler._model_by_key_name_in_body_or_error):
(ReportHandler._integer_in_body):
(ReportHandler._timestamp_in_body):
(ReportHandler.bypass_authentication):
(ReportHandler._results_are_valid):
(ReportHandler._results_are_valid._is_float_convertible):
(ReportHandler._create_build_if_possible):
(ReportHandler._create_build_if_possible.execute):
(ReportHandler._add_test_if_needed):
(ReportHandler._add_test_if_needed.execute):
(ReportHandler):
(AdminReportHandler.bypass_authentication):

Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):

7:10 PM Changeset in webkit [106320] by commit-queue@webkit.org

12 edits in trunk/Source

Add Plumming to get graphics error messages to JS Console
https://bugs.webkit.org/show_bug.cgi?id=77238

Source/WebCore:

Patch by Gregg Tavares <Gregg Tavares> on 2012-01-30
Reviewed by Kenneth Russell.

No new tests. No change in behavior.

html/canvas/WebGLRenderingContext.cpp:

(WebGLRenderingContextErrorMessageCallback):
(WebCore::WebGLRenderingContextErrorMessageCallback::WebGLRenderingContextErrorMessageCallback):
(WebCore::WebGLRenderingContextErrorMessageCallback::onErrorMessage):
(WebCore::WebGLRenderingContextErrorMessageCallback::~WebGLRenderingContextErrorMessageCallback):
(WebCore):
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):

html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

platform/graphics/GraphicsContext3D.h:

(ErrorMessageCallback):
(WebCore::GraphicsContext3D::ErrorMessageCallback::~ErrorMessageCallback):
(GraphicsContext3D):

platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore):

platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore):

platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore):

Source/WebKit/chromium:

Patch by Gregg Tavares <gman@google.com> on 2012-01-30
Reviewed by Kenneth Russell.

public/platform/WebGraphicsContext3D.h:

(WebGraphicsErrorMessageCallback):
(WebKit::WebGraphicsContext3D::WebGraphicsErrorMessageCallback::~WebGraphicsErrorMessageCallback):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setErrorMessageCallback):

src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore):
(GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsErrorMessageCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):

src/GraphicsContext3DPrivate.h:

(WebCore):
():

6:58 PM Changeset in webkit [106319] by andersca@apple.com

4 edits in trunk/Source/WebCore

Simplify RenderLayerCompositor::frameViewDidScroll
https://bugs.webkit.org/show_bug.cgi?id=77398

Reviewed by Sam Weinig.

Remove the scrollPosition parameter from RenderLayerCompositor::frameViewDidScroll; we can just get it
from the associated FrameView object.

page/FrameView.cpp:

(WebCore::FrameView::scrollPositionChanged):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
Call frameViewDidScroll() here instead of setting the scroll layer position explicitly.

(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::RenderLayerCompositor::ensureRootLayer):

rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

6:55 PM Changeset in webkit [106318] by commit-queue@webkit.org

3 edits
2 adds in trunk

Don't select the next selectable index when deselecting an option in select elements with size set to a value greater than one.
https://bugs.webkit.org/show_bug.cgi?id=76389

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-30
Reviewed by Kent Tamura.

This behavior matches the rest of the browsers.

Source/WebCore:

Test: fast/forms/select/option-selecting.html

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::optionSelectionStateChanged):

LayoutTests:

fast/forms/select/option-selecting-expected.txt: Added.
fast/forms/select/option-selecting.html: Added.

6:43 PM Changeset in webkit [106317] by andersca@apple.com

2 edits in trunk/Source/WebCore

Scrollbars don't show when scrolling on the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=77396
<rdar://problem/10710736>

Reviewed by Sam Weinig.

Use ScrollAnimator::scrollToOffsetWithoutAnimation when updating the frame view scroll offset,
since that function will end up invalidating the scrollbars correctly.

page/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::didUpdateMainFrameScrollPosition):

6:43 PM Changeset in webkit [106316] by leviw@chromium.org

2 edits in trunk/LayoutTests

Layout Test plugins/crash-restoring-plugin-page-from-page-cache.html is slow on Chromium
https://bugs.webkit.org/show_bug.cgi?id=77397

Unreviewed gardening. Marking plugins/crash-restoring-plugin-page-from-page-cache.html slow
on Chromium.

platform/chromium/test_expectations.txt:

6:40 PM Changeset in webkit [106315] by haraken@chromium.org

4 edits in trunk/Tools

REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
output an empty method name (i.e. "()")
https://bugs.webkit.org/show_bug.cgi?id=77336

Reviewed by Darin Adler.

r105797 tried to detect a change outside methods, but it causes a bug that
prepare-ChangeLog can output an empty method name, like this:

foo/bar/baz.cpp: (method1): (): (method2):

This is because the cpp parser in prepare-ChangeLog cannot distinguish
'{' as the beginning of a method with '{' as the beginning of an array definition
at the top level.

int a[] = { 1, 2, 3 }; This '{' is the beginning of an array definition.

void func() { This '{' is the beginning of a method.

...;

}

This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.

Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_cpp): Modified as described above.
(generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
an empty method name. Ideally this should not happen but may happen, since the
parsers are not perfect.

Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.

(NameSpace7):
(NameSpace8):
(Class109):

Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:

6:22 PM Changeset in webkit [106314] by oliver@apple.com

4 edits in trunk/Source/JavaScriptCore

get_by_val_arguments is broken in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=77389

Reviewed by Gavin Barraclough.

When get_by_val had wad a value profile added, the same slot was not added to
get_by_val_arguments. This broke the interpreter as the interpreter falls
back on its regular get_by_val implementation.

No tests are added as the interpreter is fairly broken in its
current state (multiple tests fail due to this bug).

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

bytecode/Opcode.h:

(JSC):
():

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetArgumentByVal):

6:20 PM Changeset in webkit [106313] by leviw@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r106259.
http://trac.webkit.org/changeset/106259
https://bugs.webkit.org/show_bug.cgi?id=77395

Breaks shared builders as they also build webkittests with
-Wexit-time-destructors. (Requested by leviw on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-30

WebKitUnitTests.gyp:

6:11 PM Changeset in webkit [106312] by rniwa@webkit.org

2 edits in trunk/PerformanceTests

Skip inspector tests since they have been timing out.

Skipped:

6:04 PM Changeset in webkit [106311] by andersca@apple.com

5 edits in trunk/Source/WebCore

Show repaint counters in individual tiles
https://bugs.webkit.org/show_bug.cgi?id=77390
<rdar://problem/10767967>

Reviewed by Darin Adler.

platform/graphics/ca/mac/TileCache.h:
platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplayInRect):
Make sure to invalidate the repaint counter rect if necessary.

(WebCore::TileCache::drawLayer):
Draw the repaint counter.

(WebCore::TileCache::showRepaintCounter):
New function that determines whether we should show repaint counters for the given tile cache.

platform/graphics/ca/mac/WebTileLayer.h:
platform/graphics/ca/mac/WebTileLayer.mm:

(-[WebTileLayer incrementRepaintCount]):
Add method for getting the repaint count.

5:57 PM Changeset in webkit [106310] by mitz@apple.com

4 edits in trunk

<rdar://problem/10778045> REGRESSION (r91935): text-combine fails
https://bugs.webkit.org/show_bug.cgi?id=77373

Reviewed by Darin Adler.

Source/WebCore:

Removed tests that were failing because of this bug from the Lion skipped
list.

platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill): Changed to use CTFontGetGlyphsForCharacters,
rather than wkGetVerticalGlyphsForCharacters, for non-fullwidth fonts.

LayoutTests:

Removed tests that were failing because of this bug from the skipped list.

platform/mac-lion/Skipped:

5:36 PM Changeset in webkit [106309] by beidson@apple.com

1 edit
2 moves in trunk/LayoutTests

Fix typo in test name from my last commit.

Spotted and rubber-stamped by Darin Adler.

plugins/crash-restoring-plugin-page-from-page-cache-expected.txt: Copied from plugins/crash-restoring-pluging-page-from-page-cache-expected.txt.
plugins/crash-restoring-plugin-page-from-page-cache.html: Copied from plugins/crash-restoring-pluging-page-from-page-cache.html.
plugins/crash-restoring-pluging-page-from-page-cache-expected.txt: Removed.
plugins/crash-restoring-pluging-page-from-page-cache.html: Removed.

5:36 PM Changeset in webkit [106308] by rniwa@webkit.org

9 edits in trunk

Enable memcache on webkit-perf.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=77378

Reviewed by Adam Barth.

Eanble memcache on dashboard, manifest, and runs handlers. Clear appropriate caches when new runs are reported,
or new models are created. We flush all caches when tests are merged since it's hard to figure out dependencies
in that case. Luckily, we merge tests only occassionally and manually (or hope so) so this shouldn't be an issue.

Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler.post):

Websites/webkit-perf.appspot.com/dashboard_handler.py:

(DashboardHandler.get):

Websites/webkit-perf.appspot.com/manifest_handler.py:

(ManifestHandler.get):

Websites/webkit-perf.appspot.com/merge_tests_handler.py:

(MergeTestsHandler.post):

Websites/webkit-perf.appspot.com/models.py:

(createInTransactionWithNumericIdHolder):
(Test):
(Test.cacheKey):

Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):
(ReportHandler._addTestIfNeeded):

Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):

5:25 PM Changeset in webkit [106307] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

BlackBerry - Support Proxy-Authenticate headers when a proxy is configured
https://bugs.webkit.org/show_bug.cgi?id=77361

Though we have a proxy configured, we might not have the auth
credentials it requires. Support Proxy-Authenticate for that case.

Patch by Christopher Hutten-Czapski <chutten@rim.com> on 2012-01-30
Reviewed by George Staikos.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):
(WebCore::NetworkJob::handleAuthHeader):
(WebCore::NetworkJob::sendRequestWithCredentials):

platform/network/blackberry/NetworkJob.h:
platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

5:23 PM Changeset in webkit [106306] by jamesr@google.com

3 edits in trunk/Source/WebCore

[chromium] Remove unnecessary retry logic in LayerRendererChromium initialization for accelerated painting
https://bugs.webkit.org/show_bug.cgi?id=77247

Reviewed by Kenneth Russell.

The accelerate painting setting is done differently from other capability-dependent settings for no good reason,
requiring that we retry initialization with different settings. For all other settings we set the capabilities
bit to true if the setting is requested and if the required capabilities exist on the underlying context.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

5:10 PM Changeset in webkit [106305] by beidson@apple.com

3 edits
2 adds in trunk

<rdar://problem/10707072>
Crashes in WebProcess at WebCore::Node::rendererIsNeeded

Reviewed by Darin Adler.

Source/WebCore:

In specific circumstances a plugin element can be without a render style at the point in time where
the page navigated and enters the page cache.

When this is the cash, the element should not enter into the "custom style for renderer" mode and should
instead use the default render style machinery.

Test: plugins/crash-restoring-pluging-page-from-page-cache.html

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache): Only setHasCustomStyleForRenderer and

forceRecalc if there actually is a custom style to be used.

(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache): Only clearHasCustomStyleForRenderer if there

actually was a custom style to be cleared.

(WebCore::HTMLPlugInImageElement::customStyleForRenderer): This should only be called if there actually is a

custom style to be used. Otherwise the element would have to fallback to the "normal" RenderStyle which might
not exist.

LayoutTests:

plugins/crash-restoring-pluging-page-from-page-cache-expected.txt: Added.
plugins/crash-restoring-pluging-page-from-page-cache.html: Added.

5:07 PM Changeset in webkit [106304] by andersca@apple.com

7 edits in trunk/Source/WebCore

Show debug borders for individual tile cache tiles
https://bugs.webkit.org/show_bug.cgi?id=77388

Reviewed by Sam Weinig.

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::updateDebugIndicators):
Give tile cache tiles a thin dark blue border.

platform/graphics/ca/mac/TileCache.h:

(WebCore::TileCache::tileDebugBorderWidth):
(WebCore::TileCache::tileDebugBorderColor):
Add getters and member variables for the tile debug border width and color.

platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):
Initialize m_tileDebugBorderWidth.

(WebCore::TileCache::setTileDebugBorderWidth):
Update the border width of each tile layer.

(WebCore::TileCache::setTileDebugBorderColor):
Update the border color of each tile layer.

(WebCore::TileCache::createTileLayer):
Set the border color and border width.

platform/graphics/ca/mac/WebTileCacheLayer.h:
platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer borderColor]):
(-[WebTileCacheLayer setBorderColor:]):
(-[WebTileCacheLayer borderWidth]):
(-[WebTileCacheLayer setBorderWidth:]):
Call through to the TileCache.

platform/graphics/mac/WebLayer.mm:

(drawLayerContents):
Don't draw the repaint counter for tile cache layers, each tile will maintain its own repaint counter.

5:07 PM Changeset in webkit [106303] by eae@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/css

Change computed style calculations to round/truncate values at query as opposed to computation time to avoid loosing precision when adjusting values for zoom.

5:04 PM Changeset in webkit [106302] by ojan@chromium.org

6 edits in trunk/Tools

run-webkit-tests calls out to webkit-build-directory twice
https://bugs.webkit.org/show_bug.cgi?id=77248

Reviewed by Dirk Pranke.

This reduces to calls to webkit-build-directory to one call and
saves 500ms for run-webkit-tests over a single file.

Scripts/webkit-build-directory:

If called with no arguments, print out both the top-level directory and the
configuration directory.

Scripts/webkit-build-directory:
Scripts/webkitpy/layout_tests/port/config.py:

(Config.build_directory):
When called with no arguments, get and cache both the top-level and configuration directories.

Scripts/webkitpy/layout_tests/port/config_standalone.py:

(main):

Scripts/webkitpy/layout_tests/port/config_unittest.py:

(ConfigTest.assert_configuration):
(ConfigTest.test_build_directory.mock_webkit_build_directory):
(ConfigTest.test_build_directory):
(ConfigTest.test_default_configurationnotfound):

Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._build_path):
Cache the root directory in the options object so that other users
of the options object don't need to call out to webkit-build-directory.

4:35 PM Changeset in webkit [106301] by commit-queue@webkit.org

5 edits in trunk

single-file input elements should refuse multi-file drags
https://bugs.webkit.org/show_bug.cgi?id=25913

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-01-30
Reviewed by Eric Seidel.

Refuse the multiple file drags onto a single file input element.

Source/WebCore:

No new tests: Covered by existing tests, updated the expected results.

page/DragController.cpp:

(WebCore::DragController::tryDocumentDrag):
Setting the dragSession.numberOfItemsToBeAccepted to 0 so that drag operation is none if the
file input element under mouse is single input type and number of files dragged onto that
input element are more than 1.

LayoutTests:

editing/pasteboard/file-input-files-access-expected.txt:

Expected result changed.

editing/pasteboard/script-tests/file-input-files-access.js:

(runTest):
Removed the 'FIXME' debug and comment as it is not valid after this change.

4:29 PM Changeset in webkit [106300] by commit-queue@webkit.org

18 edits
1 move
3 deletes in trunk

[chromium] Use region reported painted opaque for draw culling
https://bugs.webkit.org/show_bug.cgi?id=76015

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-30
Reviewed by James Robinson.

Source/WebCore:

New unit tests in CCTiledLayerImplTest.cpp, CCQuadCullerTest.cpp, CCLayerTreeHostImplTest.cpp

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setOpaque):

platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::opaqueRect):
(WebCore):

platform/graphics/chromium/cc/CCDrawQuad.h:

(CCDrawQuad):
(WebCore::CCDrawQuad::needsBlending):

platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::cullOccludedQuads):

platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp:

(WebCore::CCSolidColorDrawQuad::CCSolidColorDrawQuad):

platform/graphics/chromium/cc/CCTileDrawQuad.cpp:

(WebCore::CCTileDrawQuad::create):
(WebCore::CCTileDrawQuad::CCTileDrawQuad):

platform/graphics/chromium/cc/CCTileDrawQuad.h:

(CCTileDrawQuad):

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(DrawableTile):
(WebCore::DrawableTile::opaqueRect):
(WebCore::DrawableTile::setOpaqueRect):
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::pushTileProperties):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

(WebKit::BlendStateCheckLayer::appendQuads):
(WebKit::BlendStateCheckLayer::setOpaqueColor):
(BlendStateCheckLayer):
(WebKit::BlendStateCheckLayer::BlendStateCheckLayer):
(WebKit::TEST_F):

tests/CCQuadCullerTest.cpp:

(WebCore::MakeTileQuad):
(WebCore::setQuads):
(WebCore::TEST):
(WebCore):

tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::createLayer):
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
(CCLayerTestCommon::coverageVisibleRectOnTileBoundaries):
(CCLayerTestCommon::coverageVisibleRectIntersectsTiles):
(CCLayerTestCommon::coverageVisibleRectIntersectsBounds):
(CCLayerTestCommon):

LayoutTests:

platform/chromium-linux/compositing/iframes/iframe-in-composited-layer-expected.png:
platform/chromium-mac-leopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed.
platform/chromium-win/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed.
platform/chromium/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/repaint/block-selection-gap-in-composited-layer-expected.png.
platform/chromium/test_expectations.txt:

4:22 PM Changeset in webkit [106299] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
Remove passing media/media-blocked-by-beforeload.html from test_expectations.txt
after r103509

Patch by Shadi Khalek <shadi@chromium.org> on 2012-01-30

platform/chromium/test_expectations.txt:

4:18 PM Changeset in webkit [106298] by rniwa@webkit.org

3 edits
2 adds in trunk

Crash in previousLinePosition when moving into a root inline box without leaves
https://bugs.webkit.org/show_bug.cgi?id=76812

Reviewed by Enrica Casucci.

Source/WebCore:

The crash was caused by us assuming that every root inline box has at least one leaf,
which isn't true when we create inline boxes for an empty text run with margin, border, etc...

Test: editing/selection/move-into-empty-root-inline-box.html

editing/visible_units.cpp:

(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

LayoutTests:

Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.

editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
editing/selection/move-into-empty-root-inline-box.html: Added.

3:59 PM Changeset in webkit [106297] by oliver@apple.com

5 edits in trunk

Unexpected syntax error
https://bugs.webkit.org/show_bug.cgi?id=77340

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Function calls and new expressions have the same semantics for
assignment, so should simply share their lhs handling.

parser/Parser.cpp:

(JSC::::parseMemberExpression):

LayoutTests:

Add new tests for correct parsing of new expressions

fast/js/parser-syntax-check-expected.txt:
fast/js/script-tests/parser-syntax-check.js:

(runTest):
(invalid):

3:56 PM Changeset in webkit [106296] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed ARMv7 build fix.

tools/CodeProfiling.cpp:

(JSC):
(JSC::setProfileTimer):
(JSC::CodeProfiling::begin):
(JSC::CodeProfiling::end):

3:35 PM Changeset in webkit [106295] by levin@chromium.org

2 edits in trunk/Source/JavaScriptCore

Using OS(WIN) or OS(MAC) should cause a build error.
https://bugs.webkit.org/show_bug.cgi?id=77162

Reviewed by Darin Adler.

wtf/Platform.h: Expand them into something that will cause a compile error.

3:16 PM Changeset in webkit [106294] by tony@chromium.org

2 edits in trunk/LayoutTests

css3/flexbox/cross-axis-scrollbar.html ref test fails on Windows Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=77309

Reviewed by Dirk Pranke.

It looks like the scrollbars on windows overflow by a pixel, so the
edge of the scrollbar is being covered up by the trailing green box.
Use z-order to force the scrollbar on top.

This is kind of speculative. I want to see if the test passes on the
bots before removing the line in test_expectations.txt.

css3/flexbox/cross-axis-scrollbar-expected.html:

3:16 PM Changeset in webkit [106293] by ojan@chromium.org

4 edits in trunk/Tools

Parsing test_expecations.txt + Skipped lists takes too long
https://bugs.webkit.org/show_bug.cgi?id=77059

Reviewed by Dirk Pranke.

This saves ~100ms on the Apple Mac port.
-memoize a bunch of path methods.
-Avoid doing multiple disk accesses per line.
-Parse the skipped list directly instead of turning it into a test_expecations.txt
formatting string and parsing that.

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):
(TestExpectationParser.expectation_for_skipped_test):
(TestExpectationParser._parse_line):
(TestExpectationParser._collect_matching_tests):
(TestExpectations.init):
(TestExpectations._add_skipped_tests):

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_add_skipped_tests):
(test_add_skipped_tests_duplicate):

Scripts/webkitpy/layout_tests/port/base.py:

(Port):
(Port.test_isfile):
(Port.normalize_test_name):
(Port.layout_tests_dir):
(Port.abspath_for_test):

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

3:06 PM Changeset in webkit [106292] by rniwa@webkit.org

6 edits
4 adds in trunk

webkit-perf.appspot.com should have an ability to merge tests
https://bugs.webkit.org/show_bug.cgi?id=77250

Reviewed by Adam Barth.

Added admin/merge-tests. This page allows administrators to easily merge test objects.

Also add the forgotten title.png and rename api/create to admin/create since we don't allow
non-admins to create new models anyway.

Websites/webkit-perf.appspot.com/app.yaml:
Websites/webkit-perf.appspot.com/css: Added.
Websites/webkit-perf.appspot.com/css/title.png: Added.
Websites/webkit-perf.appspot.com/main.py:
Websites/webkit-perf.appspot.com/merge_tests.yaml: Added.
Websites/webkit-perf.appspot.com/merge_tests_handler.py: Added.

(MergeTestHandler):
(MergeTestHandler.get):
(MergeTestHandler.post):

Websites/webkit-perf.appspot.com/models.py:

(deleteModelWithNumericIdHolder):

Websites/webkit-perf.appspot.com/static/create-models.html:

2:54 PM Changeset in webkit [106291] by leviw@chromium.org

2 edits in trunk/Source/WebCore

!m_insideRegionPaint assertion in RenderRegion.cpp is invalid
https://bugs.webkit.org/show_bug.cgi?id=77372

Reviewed by David Hyatt.

Removing the !m_insideRegionPaint assertion that's in three functions in
RenderRegion. It's triggering in numerous layout tests and isn't valid.

No new tests as this just removes assertions.

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::takeRenderBoxRegionInfo):
(WebCore::RenderRegion::removeRenderBoxRegionInfo):

2:48 PM Changeset in webkit [106290] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[BlackBerry] OS(QNX) also has TM_GMTOFF, TM_ZONE, and TIMEGM
https://bugs.webkit.org/show_bug.cgi?id=77360

Patch by Yong Li <yoli@rim.com> on 2012-01-30
Reviewed by Rob Buis.

Turn on HAVE(TM_GMTOFF), HAVE(TM_ZONE), and HAVE(TIMEGM)
for OS(QNX).

wtf/Platform.h:

2:10 PM Changeset in webkit [106289] by enne@google.com

9 edits in trunk/Source

[chromium] Always pre-reserve scrollbar and scroll corner textures
https://bugs.webkit.org/show_bug.cgi?id=77251

Reviewed by James Robinson.

Source/WebCore:

Add a flag to LayerChromium that says that a layer's textures should
always be reserved. Prior to painting layers, find all layers marked
as such and reserve their textures. This will prevent texture memory
limits from being hit before the root layer's scrollbars are reserved
and painted.

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::reserveTextures):
(WebCore::LayerChromium::setAlwaysReserveTextures):
(WebCore::LayerChromium::alwaysReserveTextures):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::reserveTextures):

platform/graphics/chromium/TiledLayerChromium.h:

():

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

():

Source/WebKit/chromium:

src/NonCompositedContentHost.cpp:

(WebKit::reserveScrollbarLayers):
(WebKit):
(WebKit::NonCompositedContentHost::setViewport):

2:07 PM Changeset in webkit [106288] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Speculative Windows build fix.

assembler/MacroAssemblerCodeRef.h:

(FunctionPtr):

2:01 PM Changeset in webkit [106287] by jocelyn.turcotte@nokia.com

2 edits in trunk/Source/WebKit2

[Qt] Disconnect the LayerTreeHost from layers when they get removed from their parent.
https://bugs.webkit.org/show_bug.cgi?id=77362

Reviewed by Noam Rosenthal.

This fixes crashes seen in layout tests under certain timing circumstances
that appeared after r106109 was landed.

WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):

1:44 PM Changeset in webkit [106286] by Beth Dakin

2 edits in trunk/Source/WebCore

Speculative 32-bit build-fix.

WebCore.exp.in:

1:22 PM Changeset in webkit [106285] by leviw@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/js/dfg-int32array-overflow-values.html as slow
for Chromium Debug bots.

platform/chromium/test_expectations.txt:

1:21 PM Changeset in webkit [106284] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from 119623 to 119700.

DEPS:

1:19 PM Changeset in webkit [106283] by leviw@chromium.org

3 edits in trunk/LayoutTests

fast/css/fontsize-unit-rems-crash.html should use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=77351

Reviewed by Simon Fraser.

Switching the above test to only use text results as the html element is display:none.

fast/css/fontsize-unit-rems-crash-expected.txt:
fast/css/fontsize-unit-rems-crash.html:

1:15 PM Changeset in webkit [106282] by alexis.menard@openbossa.org

2 edits in trunk/Tools

Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.

Scripts/webkitpy/common/config/watchlist:

1:11 PM Changeset in webkit [106281] by mihnea@adobe.com

14 edits in trunk

[CSSRegions]Add support for background-color in region styling
https://bugs.webkit.org/show_bug.cgi?id=71488

Reviewed by David Hyatt.

Source/WebCore:

Based on work by Alexandru Chiculita (Alexandru Chiculita).
Previous patches for region styling were touching RenderObject::style() method. After several attempts to avoid regressions
(including caching of RenderObject::style() pointer in most used methods), we decided to attempt a different approach:
Step1: before each region is repainted, we compute the style for each box that falls into the region
Step2: before paint, we store the box original style
Step3: paint the region contents using the style in region
Step4: after paint is finished, we restore the box original style (and store the box style in region for future region paint)

Tests for region styling are also enabled with this patch.

WebCore.exp.in:
rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::clearRenderBoxCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):

rendering/RenderFlowThread.h:

():

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):

rendering/RenderObject.cpp:
rendering/RenderObject.h:

(WebCore::RenderObject::style):
(RenderObject):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::setRegionBoxesRegionStyle):
(WebCore):
(WebCore::RenderRegion::restoreRegionBoxesOriginalStyle):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::takeRenderBoxRegionInfo):
(WebCore::RenderRegion::removeRenderBoxRegionInfo):
(WebCore::RenderRegion::renderBoxRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::clearBoxStyleInRegion):

rendering/RenderRegion.h:

(RenderRegion):

rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

rendering/RenderView.h:

(WebCore):
(RenderView):

LayoutTests:

Enable the region styling tests again.

platform/mac-snowleopard/Skipped:

1:08 PM Changeset in webkit [106280] by jberlin@webkit.org

2 edits
1 add in trunk/Source/WebCore

WebCore build exceeds address space on 32-bit Windows builders (again).
https://bugs.webkit.org/show_bug.cgi?id=77357

Reviewed by Adam Roben.

Add an Inspector All-In-One file, but only use it in Release and Production builds.
This differs from our other All-In-One files, but it is a better approach because it makes
debugging possible in the Debug configuration (the symbols will be in the correct .obj file
for the original .cpp files).

WebCore.vcproj/WebCore.vcproj:

Also, let VS have its way with the vcproj file.

inspector/InspectorAllInOne.cpp: Added.

1:07 PM Changeset in webkit [106279] by jsbell@chromium.org

2 edits
4 adds in trunk/LayoutTests

IndexedDB: Add tests for structured clone data
https://bugs.webkit.org/show_bug.cgi?id=74897

Validate that the types listed in the HTML5 "structured clone algorithm"
round trip properly through Indexed DB storage. Types with incomplete
support in the Chromium port are excluded (http://crbug.com/108012).
Landing disabled since cr-linux is failing test for unknown reasons.

Reviewed by Tony Chang.

platform/chromium/test_expectations.txt:
storage/indexeddb/resources/test-data.html: Added.
storage/indexeddb/resources/test-data.txt: Added.
storage/indexeddb/structured-clone-expected.txt: Added.
storage/indexeddb/structured-clone.html: Added.

12:59 PM Changeset in webkit [106278] by mdelaney@apple.com

3 edits in trunk/Source/WebCore

Limit periodic flushing inside ImageBufferCG to just Lion
https://bugs.webkit.org/show_bug.cgi?id=77353
<rdar://problem/10328309>

Reviewed by Chris Marrin.

platform/graphics/cg/ImageBufferCG.cpp:
platform/graphics/cg/ImageBufferDataCG.h:

12:57 PM Changeset in webkit [106277] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=77163
MacroAssemblerCodeRef.h uses OS(WIN) instead of OS(WINDOWS)

Rubber stamped by Geoff Garen

assembler/MacroAssemblerCodeRef.h:

12:38 PM Changeset in webkit [106276] by barraclough@apple.com

5 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for interpreter builds.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

bytecode/CodeBlock.h:

(CodeBlock):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

tools/CodeProfile.cpp:

(JSC::CodeProfile::sample):

12:25 PM Changeset in webkit [106275] by tommyw@google.com

3 edits
5 adds in trunk

Memory leak caused by PeerConnection add a NULL media stream
https://bugs.webkit.org/show_bug.cgi?id=76150

Source/WebCore:

It was my missunderstanding that the IDL keyword [StrictTypeChecking] also protects against
null or undefined arguments, it doesn't. Added checks for null pointers.

Reviewed by Adam Barth.

Test: fast/mediastream/peerconnection-addstream.html

mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):

LayoutTests:

Added a basic LayoutTest for null/undefined arguments to PeerConnection::addStream().

Reviewed by Adam Barth.

fast/mediastream/peerconnection-addstream-expected.txt: Added.
fast/mediastream/peerconnection-addstream.html: Added.
fast/mediastream/script-tests/peerconnection-addstream.js: Added.

12:01 PM Changeset in webkit [106274] by aestes@apple.com

7 edits in trunk/Source

[Windows] Optionally invert colors when drawing to a WebView's backing store.
https://bugs.webkit.org/show_bug.cgi?id=77168

Reviewed by Sam Weinig.

Source/WebCore:

css/CSSPrimitiveValueMappings.h: Assert that CompositeDifference is

not converted to a CSS value. Exposing a new compositing operation to
CSS is outside the scope of this patch.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

platform/graphics/GraphicsTypes.h: Add CompositeDifference as a

CompositeOperator. Also, remove an outdated comment.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation): Map
CompositeDifference to kCGBlendModeDifference.

Source/WebKit/win:

WebView.cpp:

(WebView::WebView): Initialize m_shouldInvertColors to false.
(WebView::paintIntoBackingStore): If m_shouldInvertColors is true, draw
an opaque white quad using the CompositeDifference blend mode. This
blend operation instructs CoreGraphics to take the difference between
the source pixel (white) and the background pixel, resulting in an
inverted pixel.

WebView.h: Define m_shouldInvertColors.

11:50 AM Changeset in webkit [106273] by mdelaney@apple.com

2 edits in trunk/Source/WebCore

Limit the shadow offset CG hack to just SL and Lion
https://bugs.webkit.org/show_bug.cgi?id=77348
<rdar://problem/10158016>

Reviewed by Chris Marrin.

No new tests, current tests cover this.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

11:47 AM Changeset in webkit [106272] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.6

Update NEWS and libtool version in preparation for the 1.6.2 release

11:47 AM Changeset in webkit [106271] by Beth Dakin

18 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=77263
PlatformScreenMac should not rely on NSWindow for important bits of data

Reviewed by Geoff Garen.

../WebCore:

The main problem is that we cannot rely on the NSWindow for information about
the deviceScaleFactor because we cannot access an NSWindow from within
WebCore for WebKit2 windows. Instead, we can fetch it from
WebCore::deviceScaleFactor(), but we need a Frame to call that. So
screenAvailableRect and screenRect both now take a FrameView* instead of a
Widget*. All existing call sites actually sent a FrameView in anyway, so this
is not a big change, but it does require touching a lot of platforms.

WebCore.exp.in:
platform/PlatformScreen.h:

(WebCore):

platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenAvailableRect):
(WebCore::screenRect):

platform/chromium/PlatformScreenChromium.cpp: