⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 13, 2012:

11:54 PM Changeset in webkit [107677] by mihaip@chromium.org
  • 3 edits
    2 deletes in trunk/Source/WebKit/chromium

[Chromium] Remove BoundObject
​https://bugs.webkit.org/show_bug.cgi?id=78531

Reviewed by Pavel Feldman.

Remove the BoundObject class, references to it were removed in r56999.

  • WebKit.gyp:
  • src/BoundObject.cpp: Removed.
  • src/BoundObject.h: Removed.
  • src/WebDevToolsFrontendImpl.cpp:
11:48 PM Changeset in webkit [107676] by pfeldman@chromium.org
  • 5 edits in trunk

[Qt] inspector/styles/undo-add-new-rule.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=78502

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::deleteRule):

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
11:38 PM Changeset in webkit [107675] by noel.gordon@gmail.com
  • 6 edits
    1 move
    2 adds
    2 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #5 of N

  • platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/image-css3-content-data-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-win/fast/images/image-css3-content-data-expected.png: Renamed from LayoutTests/platform/chromium/fast/images/image-css3-content-data-expected.png.
  • platform/chromium-win/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
  • platform/chromium/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Removed.
11:31 PM Changeset in webkit [107674] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

Initial upstreaming of selection handling code for BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=78136

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-02-13
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

  • blackberry/WebKitSupport/SelectionHandler.cpp: Added.
  • blackberry/WebKitSupport/SelectionHandler.h: Added.
11:22 PM Changeset in webkit [107673] by noel.gordon@gmail.com
  • 9 edits
    1 add
    1 delete in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #4 of N

  • platform/chromium-linux/fast/block/float/014-expected.png:
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/014-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/014-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac/fast/block/float/014-expected.png: Removed.
  • platform/chromium-win/fast/block/float/014-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium/test_expectations.txt:
10:45 PM Changeset in webkit [107672] by Nate Chapin
  • 12 edits in trunk

Source/WebCore: Reuse CachedRawResources (e.g., XHRs) that are stored
in the MemoryCache when appropriate.
​https://bugs.webkit.org/show_bug.cgi?id=76564

Reviewed by Antti Koivisto.

No new tests, expected behavior covered by existing tests.

  • html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL): Objects shouldn't remain in the

MemoryCache if revokeObjectURL is called on them.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent): Add CachedRawResource support.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setCacheDisabled): Immediately

evict resources, rather than waiting for navigation, since XHRs
should hit the cache if it has been disabled.

  • loader/cache/CachedRawResource.cpp:

(CachedRawResourceCallback): Encapsulates the async callback for

a cache hit for CachedRawResources.

(WebCore::CachedRawResource::sendCallbacks): Do the work defered in didAddClient.
(WebCore::CachedRawResource::didAddClient): Scheduled a CachedRawResourceCallback if

we already have a response, since async XHRs may not play nicely with receiving
their data synchronously.

(WebCore::CachedRawResource::removeClient): Ensure we cancel a callback to a client if

it removes itself.

(WebCore::CachedRawResource::canReuse): Provide some basic rules for when a

CachedRawResource can be reused.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy): Don't automatically reload

CachedRawResources, and add a check for whether this request has already been
made conditional.

  • xml/XMLHttpRequest.cpp:

LayoutTests: Test update for ​https://bugs.webkit.org/show_bug.cgi?id=76564.

Use sync XHRs instead of async in network-content-replacement-xhr.html,
since the inspector pulls async XHR data off of its CachedResource, instead
of a buffer it controls.

Reviewed by Antti Koivisto.

  • http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
10:41 PM Changeset in webkit [107671] by noel.gordon@gmail.com
  • 4 edits
    2 moves
    2 adds
    6 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #3 of N

  • fast/backgrounds/size/backgroundSize21-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize21-expected.txt.
  • fast/backgrounds/size/backgroundSize22-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize22-expected.txt.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.
10:30 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:25 PM Changeset in webkit [107670] by noel.gordon@gmail.com
  • 6 edits
    4 moves
    4 adds
    12 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #2 of N

  • fast/backgrounds/size/backgroundSize17-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize17-expected.txt.
  • fast/backgrounds/size/backgroundSize18-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize18-expected.txt.
  • fast/backgrounds/size/backgroundSize19-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize19-expected.txt.
  • fast/backgrounds/size/backgroundSize20-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize20-expected.txt.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize17-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize18-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize19-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
  • platform/qt/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.
9:57 PM Changeset in webkit [107669] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Set opaque flag on SkBitmap in per-tile layer updater
​https://bugs.webkit.org/show_bug.cgi?id=78498

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-13
Reviewed by Stephen White.

No new tests.

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

(SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::layerIsOpaque):

9:28 PM Changeset in webkit [107668] by noel.gordon@gmail.com
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #1 of N

  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
  • platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
9:19 PM Changeset in webkit [107667] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Add Linux ChromiumOS test results to flakiness dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=78495

Patch by Rob Flack <​flackr@chromium.org> on 2012-02-13
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:
9:05 PM Changeset in webkit [107666] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, remove svg/custom/grayscale-gradient-mask.svg CRASH expectation
​https://bugs.webkit.org/show_bug.cgi?id=78556

  • platform/chromium/test_expectations.txt:
8:41 PM Changeset in webkit [107665] by wjmaclean@chromium.org
  • 18 edits in trunk/Source

[chromium] Remove obsolete zoom animation pathway.
​https://bugs.webkit.org/show_bug.cgi?id=78359

Reviewed by James Robinson.

Source/WebCore:

Tests for existing pathways should not be broken. Tests for removed pathway removed previously.

This patch removes dead code from the previous incarnation of zoom animation for chromium.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • page/FrameView.cpp:
  • page/FrameView.h:

(FrameView):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/ScrollableArea.cpp:
  • platform/ScrollableArea.h:
  • testing/InternalSettings.cpp:
  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:
  • testing/Internals.cpp:

Source/WebKit/chromium:

This patch removes dead code from the previous incarnation of zoom animation for chromium.

  • src/WebViewImpl.cpp:

Source/WebKit2:

This patch removes dead code from the previous incarnation of zoom animation for chromium.

WebProcess/Plugins/PDF/BuiltInPDFView.h:
(BuiltInPDFView):

8:38 PM Changeset in webkit [107664] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

fast/text/atsui-multiple-renderers.html and related report IMAGE failure on commit queue
​https://bugs.webkit.org/show_bug.cgi?id=78544

Unreviewed. Test expectations update: PASS locally on linux but IMAGE on the queue.

  • platform/chromium/test_expectations.txt: fast/text/atsui-multiple-renderers.html fast/text/international/danda-space.html fast/text/international/thai-baht-space.html fast/text/international/thai-line-breaks.html platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
8:19 PM Changeset in webkit [107663] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebCore

[Regression] r107650 broke the windows build.
​https://bugs.webkit.org/show_bug.cgi?id=78569

Build fix, Unreviewed.

The variable defined in switch statement should not escape from the switch statement.

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):

8:03 PM Changeset in webkit [107662] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] Mutation Observers build is broken
​https://bugs.webkit.org/show_bug.cgi?id=78433

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-13
Reviewed by Martin Robinson.

Source/WebCore:

Added some files missed.

No new tests since no new feature.

  • GNUmakefile.list.am:

Tools:

Enabled mutation observers as a default feature for GTK port, too.

  • Scripts/build-webkit:

LayoutTests:

Removed fast/mutation, but added following 3 tests which are needed more time to pass.

GTK port DRT doesn't support some APIs like scheduleAsynchronousKeyDown.
I opened a new bug to deal with it. ​http://webkit.org/b/78481
And also see ​http://webkit.org/b/78290
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html

Needed to enable FileSystem API at the same time.
fast/mutation/filesystem-callback-delivery.html

  • platform/gtk/Skipped:
7:49 PM WebKitIDL edited by haraken@chromium.org
(diff)
7:15 PM Changeset in webkit [107661] by hayato@chromium.org
  • 23 edits in trunk

Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
​https://bugs.webkit.org/show_bug.cgi?id=77514

Reviewed by Dimitri Glazkov.

NodeType.SHADOW_ROOT_NODE type is finally gone.

Source/WebCore:

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

  • bindings/objc/DOM.mm:

(kitClass):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • dom/ContainerNode.cpp:

(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):

  • dom/Node.h:
  • dom/Range.cpp:

(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):

  • dom/ShadowRoot.cpp:
  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::toShadowRoot):

  • editing/FrameSelection.cpp:

(WebCore::nodeIsDetachedFromDocument):
(WebCore):
(WebCore::FrameSelection::textWillBeReplaced):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):

  • html/parser/HTMLElementStack.h:

(WebCore::isInHTMLNamespace):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode):

Source/WebKit/chromium:

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::buildContentForNode):

LayoutTests:

  • fast/dom/shadow/nodetype-expected.txt:
  • fast/dom/shadow/nodetype.html:
  • resources/dump-as-markup.js:

(Markup._get):

6:50 PM Changeset in webkit [107660] by tony@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

[chromium] Unreviewed gardening. Small cleanup after r107638.

  • platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/filter-empty-element-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:40 PM Changeset in webkit [107659] by ojan@chromium.org
  • 5 edits
    4 adds in trunk

Source/JavaScriptCore: Replace old strtod with new strtod
​https://bugs.webkit.org/show_bug.cgi?id=68044

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2012-02-12
Reviewed by Geoffrey Garen.

  • parser/Lexer.cpp: Added template argument. This version allows junk after numbers.

(JSC::::lex):

  • runtime/JSGlobalObjectFunctions.cpp: Ditto.

(JSC::parseInt):
(JSC::jsStrDecimalLiteral):

  • runtime/LiteralParser.cpp: Ditto.

(JSC::::Lexer::lexNumber):

  • wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter.

It takes a template argument to allow clients to determine statically whether it should allow
junk after the numbers or not.
(WTF):
(WTF::strtod):

  • wtf/dtoa.h:

(WTF):

  • wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers.

(WTF::toDoubleType):

Source/WebCore: rtl + flex-direction:column is positioning elements incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=78555

Reviewed by Tony Chang.

Do the y-axis flipping after we have adjusted the y-position for
flex-align instead of before.

Tests: css3/flexbox/flex-align-baseline.html

css3/flexbox/flex-align-end.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren):
The amount we adjust by also needs to be flipped for rtl+column,
so the flipping needs to be done after we align the flex items.

LayoutTests: rtl + flex-direction:column is positioning elements incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=78555

Reviewed by Tony Chang.

  • css3/flexbox/flex-align-baseline-expected.txt: Added.
  • css3/flexbox/flex-align-baseline.html: Added.
  • css3/flexbox/flex-align-end-expected.txt: Added.
  • css3/flexbox/flex-align-end.html: Added.
  • css3/flexbox/true-centering-expected.txt:
6:39 PM Changeset in webkit [107658] by bashi@chromium.org
  • 2 edits
    14 adds in trunk/LayoutTests

Unreviewed test expectations update.
Rebaselining font-face-synthetic-bold-italic.html and font-face-weight-matching.html.

  • platform/chromium-linux/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
  • platform/chromium-linux/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
  • platform/chromium-linux/fast/css/font-face-weight-matching-expected.png: Added.
  • platform/chromium-linux/fast/css/font-face-weight-matching-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-weight-matching-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-weight-matching-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-weight-matching-expected.txt: Added.
  • platform/chromium-win/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
  • platform/chromium-win/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
  • platform/chromium-win/fast/css/font-face-weight-matching-expected.png: Added.
  • platform/chromium-win/fast/css/font-face-weight-matching-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:36 PM Changeset in webkit [107657] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

The tile cache layer should have its background set to the page background
​https://bugs.webkit.org/show_bug.cgi?id=78560
<rdar://problem/10857472>

Reviewed by Sam Weinig.

  • page/FrameView.cpp:

(WebCore::FrameView::recalculateScrollbarOverlayStyle):
Inform the RenderLayerCompositor that the background color has changed.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateLayerBackgroundColor):
For tile cache layers we don't need a separate contents layer for the background color so
just set the background color on the layer directly.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::documentBackgroundColorDidChange):
If the root render layer is using a tile cache layer, update its background color.

6:24 PM Changeset in webkit [107656] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Allow to configure ENABLE_FTPDIR in build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=65098

Patch by Loïc Yhuel <​loic.yhuel_ext@softathome.com> on 2012-02-13
Reviewed by Eric Seidel.

Allow to disable ENABLE_FTPDIR by command line.
Remove ENABLE_FTPDIR from --minimal build

  • Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
  • qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,

as, for Qt platform, build-webkit does not add on command line what it thinks to be default values

6:21 PM Changeset in webkit [107655] by shinyak@chromium.org
  • 2 edits in trunk/Tools

Add shinyak as committer

6:17 PM Changeset in webkit [107654] by eae@chromium.org
  • 6 edits in branches/subpixellayout/Source/WebCore

Remove explicit AppUnit::toFloat calls in places where it is not needed.

6:10 PM Changeset in webkit [107653] by abarth@webkit.org
  • 4 edits in trunk/Tools

Implement start/stop_helper for ChromiumAndroidPort
​https://bugs.webkit.org/show_bug.cgi?id=78558

Reviewed by Dirk Pranke.

These functions (and their dependencies) set up the Android device for
testing.

This patch also includes a few tweaks on the previous patch recommended
by dpranke.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort.stop_helper):
(ChromiumAndroidPort._shut_down_http_server):
(ChromiumAndroidPort):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):
(ChromiumAndroidPort._restore_system_font):
(ChromiumAndroidPort._push_test_resources):
(ChromiumAndroidPort._push_to_device):
(ChromiumAndroidPort._pull_from_device):
(ChromiumAndroidPort._kill_device_process):
(ChromiumAndroidPort._setup_performance):
(ChromiumAndroidPort._teardown_performance):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase):
(PortTestCase.make_port):
(PortTestCase.test_default_worker_model):

5:40 PM Changeset in webkit [107652] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Implement Element.webkitRegionOverflow

[CSSRegions][CSSOM] Implement Element.regionOverflow
​https://bugs.webkit.org/show_bug.cgi?id=77863

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

On each layout, compute the overflowState for each region belonging to the flow thread

Tests: fast/regions/element-region-overflow-state-vertical-rl.html

fast/regions/element-region-overflow-state.html

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):
(WebCore):

  • dom/Element.h:
  • dom/Element.idl:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

  • rendering/RenderRegion.h:

(RenderRegion):
(WebCore::RenderRegion::regionState):
(WebCore::RenderRegion::setRegionState):

5:37 PM Changeset in webkit [107651] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

More windows build fixing

5:34 PM Changeset in webkit [107650] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

Implement Element.webkitRegionOverflow

[CSSRegions][CSSOM] Implement Element.regionOverflow
​https://bugs.webkit.org/show_bug.cgi?id=77863

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

Source/WebCore:

On each layout, compute the overflowState for each region belonging to the flow thread

Tests: fast/regions/element-region-overflow-state-vertical-rl.html

fast/regions/element-region-overflow-state.html

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):
(WebCore):

  • dom/Element.h:
  • dom/Element.idl:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

  • rendering/RenderRegion.h:

(RenderRegion):
(WebCore::RenderRegion::regionState):
(WebCore::RenderRegion::setRegionState):

LayoutTests:

  • fast/regions/element-region-overflow-state-expected.txt: Added.
  • fast/regions/element-region-overflow-state-vertical-rl-expected.txt: Added.
  • fast/regions/element-region-overflow-state-vertical-rl.html: Added.
  • fast/regions/element-region-overflow-state.html: Added.
5:32 PM Changeset in webkit [107649] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

File API IDLs are incorrect in Xcode project
​https://bugs.webkit.org/show_bug.cgi?id=78551

Rubber-stamped by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj: Corrected paths, and added missing files.
5:27 PM Changeset in webkit [107648] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

SharedBuffer::getSomeData() must support m_dataArray if NETWORK_CFDATA_ARRAY_CALLBACK is defined
​https://bugs.webkit.org/show_bug.cgi?id=77718

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-02-13
Reviewed by David Kilzer.

Previously, the last part of SharedBuffer::getSomeData() was systematically accessing
the data from the segments. When NETWORK_CFDATA_ARRAY_CALLBACK is defined, there can
be data in m_dataArray past the segment.

The previous code was making invalid memory access pass the segment vector. This patch
adds support for getting the data out of m_dataArray to make SharedBuffer::getSomeData()
works with NETWORK_CFDATA_ARRAY_CALLBACK.

This is covered by existing tests when NETWORK_CFDATA_ARRAY_CALLBACK is defined.
The test 'fast/events/constructors/track-event-constructor.html' is a reliable test
for this.

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::getSomeData):

  • platform/SharedBuffer.h:

(SharedBuffer):

  • platform/cf/SharedBufferCF.cpp:

(WebCore):
(WebCore::SharedBuffer::copySomeDataFromDataArray):

5:10 PM Changeset in webkit [107647] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Executing out of bounds in JSC::Yarr::YarrCodeBlock::execute / JSC::RegExp::match
​https://bugs.webkit.org/show_bug.cgi?id=76315

Reviewed by Gavin Barraclough.

Perform a 3 byte compare using two comparisons, rather than trying to perform the
operation with a four byte load.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):

5:07 PM Changeset in webkit [107646] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Force slow-scrolling mode when there are position:fixed elements on a page
​https://bugs.webkit.org/show_bug.cgi?id=78553
<rdar://problem/10247934>

Reviewed by Dan Bernstein.

Eventually, the scrolling tree will know about fixed positioning layers so their position can be updated
when the scroll layer position is updated. For now we'll take the simple route however.

  • page/FrameView.cpp:

(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):
Inform the scrolling coordinator when the number of fixed objects changes between 0 and 1.

  • page/FrameView.h:

(WebCore::FrameView::hasFixedObjects):
Make this public.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
Call updateShouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingCoordinator::frameViewHasFixedObjectsDidChange):
Call updateShouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
Make sure to update compositing layers here. Normally, they will be updated by layout but doing a layout
here is too intrusive since it could potentially change the size of the page.

(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
If we have fixed objects or slow repaint objects we need to update the scroll layer position on the main thread.

5:07 PM Changeset in webkit [107645] by enne@google.com
  • 5 edits in trunk/Source/WebCore

[chromium] Use HashMap<..., OwnPtr<Tile>> for compositor tilemap
​https://bugs.webkit.org/show_bug.cgi?id=74154

Reviewed by James Robinson.

Covered by the compositing/ layout tests.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::create):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::createTile):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::addTile):
(WebCore::CCLayerTilingData::takeTile):
(WebCore::CCLayerTilingData::tileAt):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::DrawableTile::create):
(WebCore::DrawableTile::DrawableTile):
(WebCore::CCTiledLayerImpl::createTile):

4:59 PM Changeset in webkit [107644] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

4:57 PM Changeset in webkit [107643] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, removing some tests that have been passing
as far back as the flakiness dashboard's history goes.

  • platform/chromium/test_expectations.txt:
4:56 PM Changeset in webkit [107642] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix

4:55 PM Changeset in webkit [107641] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.15

New tag.

4:53 PM Changeset in webkit [107640] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore/rendering

Converting drawLineForBoxSide to operate on integers (which makes sense). This mostly entails fixing the callers to use pixel snapping.

4:53 PM Changeset in webkit [107639] by jsbell@chromium.org
  • 3 edits
    2 copies in branches/chromium/1025

Merge 107278 - [Chromium] IndexedDB: IDBVersionChangeRequest V8 wrapper not generated as ActiveDOMObject
​https://bugs.webkit.org/show_bug.cgi?id=78167

Source/WebCore:

Add ActiveDOMObject annotation to IDBVersionChangeRequest.idl; it is not
automagically inherited from IDBRequest.idl.

Reviewed by Adam Barth.

Test: storage/indexeddb/versionchangerequest-activedomobject.html

  • storage/IDBVersionChangeRequest.idl:

LayoutTests:

Reviewed by Adam Barth.

  • storage/indexeddb/versionchangerequest-activedomobject-expected.txt: Added.
  • storage/indexeddb/versionchangerequest-activedomobject.html: Added.

TBR=​jsbell@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9390031

4:48 PM Changeset in webkit [107638] by senorblanco@chromium.org
  • 2 edits
    154 adds
    8 deletes in trunk/LayoutTests

[chromium] New baselines for css3/filters tests (unreviewed).

  • platform/chromium-linux/css3/filters: Added.
  • platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/filter-empty-element-crash-expected.png: Added.
  • platform/chromium-linux/css3/filters/filter-with-transform-expected.png: Added.
  • platform/chromium-linux/css3/filters/nested-filter-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters: Added.
  • platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-custom-combined-missing-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-custom-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-custom-parameters-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-grayscale-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters: Added.
  • platform/chromium-mac-snowleopard/css3/filters/add-filter-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/crash-filter-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-blur-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-blur-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-custom-combined-missing-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/filter-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/filter-with-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/filtered-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/nested-filter-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/nested-filters-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/regions-expanding-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/simple-filter-rendering-expected.png: Added.
  • platform/chromium-win/css3/filters: Added.
  • platform/chromium-win/css3/filters/add-filter-rendering-expected.png: Added.
  • platform/chromium-win/css3/filters/crash-filter-change-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-blur-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-blur-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-blur-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-brightness-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-brightness-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-combined-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-combined-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-combined-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-contrast-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-contrast-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-contrast-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-custom-combined-missing-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-custom-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-custom-parameters-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-drop-shadow-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-drop-shadow-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-grayscale-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-grayscale-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-grayscale-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-grayscale-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-hue-rotate-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-hue-rotate-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-invert-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-invert-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-invert-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-invert-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-opacity-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-opacity-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-opacity-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-opacity-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-saturate-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-saturate-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-saturate-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-sepia-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-sepia-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-sepia-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/filter-region-expected.png: Added.
  • platform/chromium-win/css3/filters/filter-repaint-expected.png: Added.
  • platform/chromium-win/css3/filters/filter-with-transform-expected.png: Added.
  • platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.png: Added.
  • platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • platform/chromium-win/css3/filters/filtered-inline-expected.png: Added.
  • platform/chromium-win/css3/filters/nested-filter-expected.png: Added.
  • platform/chromium-win/css3/filters/nested-filters-expected.png: Added.
  • platform/chromium-win/css3/filters/regions-expanding-expected.png: Added.
  • platform/chromium-win/css3/filters/regions-expanding-expected.txt: Added.
  • platform/chromium-win/css3/filters/simple-filter-rendering-expected.png: Added.
  • platform/chromium/css3/filters: Added.
  • platform/chromium/css3/filters/effect-custom-combined-missing-expected.txt: Added.
  • platform/chromium/css3/filters/effect-custom-disabled-expected.txt: Added.
  • platform/chromium/css3/filters/effect-custom-expected.txt: Added.
  • platform/chromium/css3/filters/effect-custom-parameters-expected.txt: Added.
  • platform/chromium/css3/filters/filter-property-computed-style-expected.txt: Added.
  • platform/chromium/css3/filters/filter-property-parsing-expected.txt: Added.
  • platform/chromium/css3/filters/filter-repaint-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
  • platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
  • platform/qt/css3/filters/filter-region-expected.txt: Removed.
  • platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
  • platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filter-expected.txt: Removed.
  • platform/qt/css3/filters/nested-filters-expected.txt: Removed.
  • platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.
4:48 PM Changeset in webkit [107637] by abarth@webkit.org
  • 4 edits in trunk/Tools

Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
​https://bugs.webkit.org/show_bug.cgi?id=78550

Reviewed by Eric Seidel.

Much of this code just forwards to the "host" port, which seems like a
reasonable thing to do.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.stop_helper):
(ChromiumAndroidPort):
(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_apache):
(ChromiumAndroidPort._path_to_apache_config_file):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_helper):
(ChromiumAndroidPort._path_to_image_diff):
(ChromiumAndroidPort._path_to_lighttpd):
(ChromiumAndroidPort._path_to_lighttpd_modules):
(ChromiumAndroidPort._path_to_lighttpd_php):
(ChromiumAndroidPort._path_to_wdiff):
(ChromiumAndroidPort._shut_down_http_server):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase):
(PortTestCase.make_port):
(PortTestCase.test_default_worker_model):

4:42 PM Changeset in webkit [107636] by haraken@chromium.org
  • 29 edits in trunk/Source/WebCore

Add [CustomToJSObject] to interfaces which have custom toJS() and toV8()
​https://bugs.webkit.org/show_bug.cgi?id=78489

Reviewed by Adam Barth.

This is the final step to remove hard-coding from HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch replaces [JSCustomToJS] with [CustomToJSObject]
for interfaces which have custom toJS() and custom toV8().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/TestTypedArray.idl:
  • css/CSSRule.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • dom/Document.idl:
  • dom/Event.idl:
  • dom/Node.idl:
  • fileapi/Blob.idl:
  • fileapi/Entry.idl:
  • fileapi/EntrySync.idl:
  • html/HTMLCollection.idl:
  • html/ImageData.idl:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • storage/IDBAny.idl:
  • storage/IDBKey.idl:
  • svg/SVGPathSeg.idl:
4:27 PM Changeset in webkit [107635] by eae@chromium.org
  • 7 edits in branches/subpixellayout/Source/WebCore

Changed ScrollView::contentsWidth/Height to int avoiding unnecessary type conversions.

4:16 PM Changeset in webkit [107634] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

chromium_android.py should implement "virtual" methods from ChromiumPort
​https://bugs.webkit.org/show_bug.cgi?id=78545

Reviewed by Dirk Pranke.

This patch adds basic implementations that specialize a bunch of
functions from ChromiumPort.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort):
(ChromiumAndroidPort.init):
(ChromiumAndroidPort.default_child_processes):
(ChromiumAndroidPort.baseline_search_path):
(ChromiumAndroidPort.check_build):
(ChromiumAndroidPort.check_sys_deps):
(ChromiumAndroidPort.default_worker_model):
(ChromiumAndroidPort.test_expectations):
(ChromiumAndroidPort.start_http_server):
(ChromiumAndroidPort.stop_http_server):
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort.stop_helper):

4:09 PM Changeset in webkit [107633] by fischman@chromium.org
  • 6 edits
    1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaselining post skia change (from a long time ago).
​http://code.google.com/p/chromium/issues/detail?id=105305

  • platform/chromium-gpu-linux/media/audio-repaint-expected.png: Removed.
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium/test_expectations.txt:
4:06 PM Changeset in webkit [107632] by commit-queue@webkit.org
  • 6 edits in trunk

Chrome crashes when attempting to add cue to track element
​https://bugs.webkit.org/show_bug.cgi?id=77951

Patch by Arun Patole <​bmf834@motorola.com> on 2012-02-13
Reviewed by Eric Carlson.

Source/WebCore:

Allocate text track's text track list of cues before using it.

  • html/TextTrack.cpp:

(WebCore::TextTrack::cues):
(WebCore::TextTrack::addCue):
(WebCore::TextTrack::removeCue): return if text track list of cues is not allocated.
(WebCore::TextTrack::ensureTextTrackCueList):Added.

  • html/TextTrack.h:

(TextTrack):

LayoutTests:

Updated add-remove-cue.html to handle adding a new cue to the text track created with addTextTrack.

  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-remove-cue.html:
3:57 PM Changeset in webkit [107631] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Rollout 105763.

3:55 PM Changeset in webkit [107630] by bashi@chromium.org
  • 3 edits in trunk/LayoutTests

Fix font-face-weight-matching.html and font-face-synthetic-bold-italic.html
​https://bugs.webkit.org/show_bug.cgi?id=78492

Fix the URL of Ahem.ttf.

Reviewed by Eric Seidel.

  • fast/css/font-face-synthetic-bold-italic.html:
  • fast/css/font-face-weight-matching.html:
3:54 PM Changeset in webkit [107629] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Windows build.

  • platform/PlatformPasteboard.h:

(PlatformPasteboard):

3:53 PM Changeset in webkit [107628] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-534.54-branch

Merged r107496.

3:46 PM Changeset in webkit [107627] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash with button in multi-column layout.
​https://bugs.webkit.org/show_bug.cgi?id=78378

Reviewed by David Hyatt.

Source/WebCore:

Button creates an anonymous wrapper and expects that new children
be added to its m_inner anonymous block. However, splitBlock code
incorrectly creates column blocks directly under the button.

Test: fast/multicol/span/split-flow-anonymous-wrapper-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):
(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

  • fast/multicol/span/split-flow-anonymous-wrapper-crash-expected.txt: Added.
  • fast/multicol/span/split-flow-anonymous-wrapper-crash.html: Added.
3:39 PM Changeset in webkit [107626] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit/win

Fix the Windows build.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::createPasteboardStrategy):

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

3:38 PM Changeset in webkit [107625] by mhahnenberg@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Replace old strtod with new strtod
​https://bugs.webkit.org/show_bug.cgi?id=68044

Reviewed by Geoffrey Garen.

  • parser/Lexer.cpp: Added template argument. This version allows junk after numbers.

(JSC::::lex):

  • runtime/JSGlobalObjectFunctions.cpp: Ditto.

(JSC::parseInt):
(JSC::jsStrDecimalLiteral):

  • runtime/LiteralParser.cpp: Ditto.

(JSC::::Lexer::lexNumber):

  • wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter.

It takes a template argument to allow clients to determine statically whether it should allow
junk after the numbers or not.
(WTF):
(WTF::strtod):

  • wtf/dtoa.h:

(WTF):

  • wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers.

(WTF::toDoubleType):

3:37 PM Changeset in webkit [107624] by ojan@chromium.org
  • 7 edits
    4 adds in trunk

nesting horizontal flexboxes is broken
​https://bugs.webkit.org/show_bug.cgi?id=76867

Reviewed by David Hyatt.

Source/WebCore:

This is copied from RenderDeprecatedFlexibleBox and updated
for RenderFlexibleBox and to handle vertical writing mode.

Tests: css3/flexbox/preferred-widths-orthogonal.html

css3/flexbox/preferred-widths.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::marginWidthForChild):
(WebCore):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/floated-flexbox-expected.txt:
  • css3/flexbox/line-wrapping.html:

The old results here were wrong because they wrapped the contents of each flex item.

  • css3/flexbox/preferred-widths-expected.txt: Added.
  • css3/flexbox/preferred-widths-orthogonal-expected.txt: Added.
  • css3/flexbox/preferred-widths-orthogonal.html: Added.
  • css3/flexbox/preferred-widths.html: Added.
3:35 PM Changeset in webkit [107623] by Lucas Forschler
  • 4 edits in branches/safari-534.54-branch

Merge r106388.

3:28 PM Changeset in webkit [107622] by mihnea@adobe.com
  • 7 edits
    2 adds in trunk

Crash in RenderFlowThread::setRegionBoxesRegionStyle
​https://bugs.webkit.org/show_bug.cgi?id=78298

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/set-box-style-in-region-crash.html

We have to make sure that anonymous block objects get their information in RenderFlowThread
removed properly.

  • dom/Node.cpp:

(WebCore::Node::diff):
Correct a comment.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseAnonymousBoxChild):
Remove the information for anonymous block from render flow thread.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore):
(WebCore::RenderFlowThread::setRegionRangeForBox):
Do not set region range if the flow thread does not have regions.

  • rendering/RenderFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):
Add an assert to make sure that after we remove an object, there is no remaining info
in any render flow thread.

LayoutTests:

  • fast/regions/set-box-style-in-region-crash-expected.txt: Added.
  • fast/regions/set-box-style-in-region-crash.html: Added.
3:22 PM Changeset in webkit [107621] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, skip http/tests/navigation/https-in-page-cache.html
because we don't enable the page cache in chromium.

  • platform/chromium/test_expectations.txt:
3:17 PM Changeset in webkit [107620] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Tools

Add a skeleton ChromiumAndroid port to webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=78543

Reviewed by Eric Seidel.

This patch just adds an empty ChromiumAndroid port object to webkitpy
and wires it up to the factory objects. An actual implementation will
follow.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.

(ChromiumAndroidPort):
(ChromiumAndroidPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory):

3:13 PM Changeset in webkit [107619] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, r107611 enabled layout tests in css3/filters,
but some are missing results.

  • platform/chromium/test_expectations.txt:
3:10 PM Changeset in webkit [107618] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac.
​https://bugs.webkit.org/show_bug.cgi?id=78246

This allows removing a bunch of code in chromium land (​https://chromiumcodereview.appspot.com/9374020/),
and helps with the component build on mac (InitWebCoreSystemInterface is not an
exported function, and it shouldn't be).

Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's
called twice, so it's safe to land this change, and remove the calls in client
code in a later CL.

Reviewed by Darin Fisher.

  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

3:07 PM Changeset in webkit [107617] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. We don't need to pass
platform/win/inverted-colors/non-composited.html.

  • platform/chromium/test_expectations.txt:
2:59 PM Changeset in webkit [107616] by fischman@chromium.org
  • 17 edits
    5 deletes in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaselining GPU results.

  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-linux/media/controls-strict-expected.png:
  • platform/chromium-gpu-linux/media/controls-styling-expected.png:
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.txt: Removed.
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-strict-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-styling-expected.txt: Removed.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Removed.
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
2:55 PM Changeset in webkit [107615] by tony@chromium.org
  • 14 edits
    4 deletes in trunk

Unreviewed, rolling out r107582.
​http://trac.webkit.org/changeset/107582
​https://bugs.webkit.org/show_bug.cgi?id=78349

Broke three inspector interactive_ui_tests

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._removeUISourceCode.get while):
(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Removed.
  • inspector/debugger/scripts-combobox-file-selector-history.html: Removed.
  • inspector/debugger/scripts-file-selector-expected.txt: Removed.
  • inspector/debugger/scripts-file-selector.html: Removed.
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/source-frame-count.html:
2:39 PM Changeset in webkit [107614] by abarth@webkit.org
  • 6 edits
    1 add in trunk/Tools

NRWT's HTTP servers should support additional directories for resources
​https://bugs.webkit.org/show_bug.cgi?id=78528

Reviewed by Eric Seidel.

This functionality will be used by the Chromium-Android port.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.start_http_server):

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd.init):

  • Scripts/webkitpy/layout_tests/servers/http_server.py:

(Lighttpd.init):
(Lighttpd._prepare_config):

2:26 PM Changeset in webkit [107613] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Incorrect children placement in multi-column layout.
​https://bugs.webkit.org/show_bug.cgi?id=78160

Reviewed by David Hyatt.

Test: fast/multicol/span/clone-before-after-content-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone): no longer need to take care of making
children noninline (remove fix r105769) since moveChild functions take
care of adding the child properly if type of children differ. this
function just makes sure to set the right value of childrenInline property.
(WebCore::RenderBlock::splitBlocks): similar to moveChild functions below.
(WebCore::RenderBlock::moveChildTo): when child is fullRemoveInsert (across
different parents, e.g clones), we should use addChild function to make sure
it handles the case of different type of children between fromBlock and
toBlock correctly (specifically making children non-inline/wrapping inline
children under anonymous blocks.).
(WebCore::RenderBlock::moveChildrenTo):

  • rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::moveAllChildrenTo): Rename to->toBlock.
(WebCore::RenderBlock::moveChildrenTo): Rename to->toBlock.

LayoutTests: Incorrect children placement in multi-column layout.
​https://bugs.webkit.org/show_bug.cgi?id=78160

Reviewed by David Hyatt.

  • fast/multicol/span/clone-before-after-content-crash-expected.txt: Added.
  • fast/multicol/span/clone-before-after-content-crash.html: Added.
2:25 PM Changeset in webkit [107612] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInline.cpp

Fix rounding in RenderInline

2:22 PM Changeset in webkit [107611] by senorblanco@chromium.org
  • 4 edits in trunk

Source/WebCore: [chromium] Implement Brightness and Contrast filters on composited
layers. Fix Saturation filter.
​https://bugs.webkit.org/show_bug.cgi?id=78527

Reviewed by Kenneth Russell.

Will be covered by existing tests in css3/filters, when enabled.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

LayoutTests: Unskip the css3/filters tests, so we can get some baselines off the
bots.
​https://bugs.webkit.org/show_bug.cgi?id=78527

Reviewed by Kenneth Russell.

  • platform/chromium/test_expectations.txt:
2:21 PM Changeset in webkit [107610] by Lucas Forschler
  • 4 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r107338.

2:17 PM Changeset in webkit [107609] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Turn off edge antialiasing for tile cache tile layers
​https://bugs.webkit.org/show_bug.cgi?id=78533
<rdar://problem/10710798>

Reviewed by Sam Weinig.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):

2:15 PM Changeset in webkit [107608] by enrica@apple.com
  • 4 edits in trunk/Source

Build fix. Unreviewed.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/qt:

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::createPasteboardStrategy):

2:12 PM Changeset in webkit [107607] by beidson@apple.com
  • 3 edits
    5 adds in trunk

<rdar://problem/7196487> and ​https://bugs.webkit.org/show_bug.cgi?id=26777 Add https pages to the page cache in some cases

Reviewed by Anders Carlsson.

Source/WebCore:

Test: http/tests/navigation/https-in-page-cache.html

  • history/PageCache.cpp:

(WebCore::PageCache::canCachePageContainingThisFrame): Allow HTTPS pages that do not specify cache-control: no-cache

or cache-control: no-store into the page cache. This will match Firefox's behavior for HTTPS in their bfcache.

LayoutTests:

  • http/tests/navigation/https-in-page-cache.html: Added.
  • http/tests/navigation/https-in-page-cache-expected.txt: Added.
  • http/tests/navigation/resources/https-in-page-cache-1.php: Added.
  • http/tests/navigation/resources/https-in-page-cache-2.php: Added.
  • http/tests/navigation/resources/https-in-page-cache-3.html: Added.
2:08 PM LayoutUnit edited by leviw@chromium.org
(diff)
2:04 PM Changeset in webkit [107606] by enrica@apple.com
  • 17 edits
    3 adds in trunk/Source

Source/WebCore: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
​https://bugs.webkit.org/show_bug.cgi?id=78282

This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.

Reviewed by Anders Carlsson.

No new tests. No change in behavior, just code refactoring.

  • WebCore.exp.in: Added exported class PlatformPasteboard.
  • WebCore.xcodeproj/project.pbxproj: Added new files to the build.
  • editing/mac/EditorMac.mm:

(WebCore::Editor::writeSelectionToPasteboard): New method signature that doesn't use OBJ-C types.

  • platform/Pasteboard.h:
  • platform/PasteboardStrategy.h: Added PasteboardStrategy abstract class.
  • platform/PlatformPasteboard.h: Added. This class implements access to NSPasteboard.
  • platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::pasteboardStrategy): Added.

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):

  • platform/mac/PasteboardMac.mm:

(WebCore::selectionPasteboardTypes): Changed to use Vector<String> instead of NSArray.
(WebCore::writableTypesForURL): Ditto.
(WebCore::createWritableTypesForImage): Ditto.
(WebCore::writableTypesForImage): Ditto.
(WebCore::Pasteboard::Pasteboard): Removed access to NSPasteboard.
(WebCore::Pasteboard::clear): Modified to use platformStrategies()->pasteboardStrategy().
(WebCore::Pasteboard::writeSelectionForTypes): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::writeURLForTypes): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::writeFileWrapperAsRTFDAttachment): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.
(WebCore::Pasteboard::writeClipboard): Ditto.
(WebCore::Pasteboard::canSmartReplace): Ditto.
(WebCore::Pasteboard::plainText): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.

  • platform/mac/PlatformPasteboardMac.mm: Added.

(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::getTypes):
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::copy):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::setPathnamesForType):
(WebCore::PlatformPasteboard::setStringForType):

Source/WebKit/mac: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.

​https://bugs.webkit.org/show_bug.cgi?id=78282


This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.


Reviewed by Anders Carlsson.


  • WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
  • WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface. (WebPlatformStrategies::createPasteboardStrategy): (WebPlatformStrategies::getTypes): (WebPlatformStrategies::bufferForType): (WebPlatformStrategies::getPathnamesForType): (WebPlatformStrategies::stringForType): (WebPlatformStrategies::copy): (WebPlatformStrategies::setTypes): (WebPlatformStrategies::setBufferForType): (WebPlatformStrategies::setPathnamesForType): (WebPlatformStrategies::setStringForType):

Source/WebKit/qt: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
​https://bugs.webkit.org/show_bug.cgi?id=78282

Build fix. Unreviewed.

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(WebPlatformStrategies::createPasteboardStrategy):

  • WebCoreSupport/PlatformStrategiesQt.h:

(PlatformStrategiesQt):

Source/WebKit2: Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
​https://bugs.webkit.org/show_bug.cgi?id=78282

This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added implementation of PasteboardStrategy

interface.
(WebKit::WebPlatformStrategies::createPasteboardStrategy):
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
2:02 PM Changeset in webkit [107605] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Regions] Inconsistent text selection behavior in regions
​https://bugs.webkit.org/show_bug.cgi?id=76456

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

Source/WebCore:

Use the proper bounding rect when doing hit testing on flow threads.
Based on initial patch by Alexandru Chiculita.

Test: fast/regions/hit-test-region.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestRegion):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::nodeAtPoint):

LayoutTests:

  • fast/regions/hit-test-region-expected.txt: Added.
  • fast/regions/hit-test-region.html: Added.
2:01 PM Changeset in webkit [107604] by Lucas Forschler
  • 13 edits in branches/safari-534.54-branch/Source/WebKit2

Rollout r104070 and r105100.

1:59 PM Changeset in webkit [107603] by aestes@apple.com
  • 13 edits
    9 adds in trunk

[Windows] Add API to enable inverted color drawing on a WebView
​https://bugs.webkit.org/show_bug.cgi?id=77382

Reviewed by Adam Roben.

Source/WebCore:

Implement CACFLayerTreeHost::setShouldInvertColors(), which instructs
the layer tree host to render composited content with inverted colors.

Test: platform/win/inverted-colors/non-composited.html

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::setShouldInvertColors):
(WebCore):

  • platform/graphics/ca/win/CACFLayerTreeHost.h:

(CACFLayerTreeHost):

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Use

SOFT_LINK_OPTIONAL since WKCACFViewSetShouldInvertColors might not
exist in older versions of WebKitQuartzCoreAdditions.
(WebCore::WKCACFViewLayerTreeHost::setShouldInvertColors):
(WebCore):

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:

(WKCACFViewLayerTreeHost):

Source/WebKit/win:

Add a new private WebPreference key called "WebKitShouldInvertColors"
and add private cover methods to get and set the preference. When this
preference changes on a WebPreference object, all WebViews listening to
that object will repaint to reflect the new value.

  • Interfaces/IWebPreferencesPrivate.idl: Add [setS|s]houldInvertColors()

cover methods for WebKitShouldInvertColorsPreferenceKey.

  • WebPreferenceKeysPrivate.h: Add WebKitShouldInvertColorsPreferenceKey.
  • WebPreferences.cpp:

(WebPreferences::shouldInvertColors):
(WebPreferences::setShouldInvertColors):

  • WebPreferences.h:

(WebPreferences):

  • WebView.cpp:

(WebView::setShouldInvertColors): If m_shouldInvertColors changes,
update the value on the WebView and in m_layerTreeHost, then repaint
the view.
(WebView::notifyPreferencesChanged):
(WebView::setAcceleratedCompositing): When creating a new layer tree
host, tell it whether it should be inverting colors.

  • WebView.h:

LayoutTests:

Add a test for non-composited inverted drawing. Testing the composited
path is blocked on <​https://bugs.webkit.org/show_bug.cgi?id=78439>.

  • platform/win-wk2/platform/win/inverted-colors/non-composited-expected.png: Added.
  • platform/win-wk2/platform/win/inverted-colors/non-composited-expected.txt: Added.
  • platform/win/inverted-colors/non-composited-expected.png: Added.
  • platform/win/inverted-colors/non-composited-expected.txt: Added.
  • platform/win/inverted-colors/non-composited.html: Added.
  • platform/win/inverted-colors/resources/gradient.png: Added.
1:55 PM Changeset in webkit [107602] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Marking some debug tests as failing.

  • platform/chromium/test_expectations.txt:
1:45 PM Changeset in webkit [107601] by andersca@apple.com
  • 12 edits in trunk/Source

The scrolling tree needs to know about the back forward state of the page
​https://bugs.webkit.org/show_bug.cgi?id=78523
<rdar://problem/10756548>

Reviewed by Sam Weinig.

Source/WebCore:

In order to know if a page should rubber-band in the horizontal direction, the scrolling tree
needs to know about the back/forward state of the page.

  • WebCore.exp.in:

Export new symbols.

  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize m_canGoBack and m_canGoForward.

(WebCore::ScrollingTree::updateBackForwardState):
Update m_canGoBack and m_canGoForward.

  • page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::canGoBack):
(WebCore::ScrollingTree::canGoForward):
Add getters.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::shouldRubberBandInDirection):
Implement this, using canGoBack and canGoForward.

Source/WebKit2:

Pass the back/forward state in the WheelEvent message. This is pretty hacky but works well.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC):
(CoreIPC::callMemberFunction):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebPage/EventDispatcher.messages.in:
1:34 PM Changeset in webkit [107600] by fischman@chromium.org
  • 5 edits
    2 moves
    1 add
    1 delete in trunk/LayoutTests

chromium gpu draws scrollbars slightly differently in debug vs. release modes on
​https://bugs.webkit.org/show_bug.cgi?id=58587

Unreviewed rebaseline (the scrollbar issue the bug is about was fixed previously).

  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/video-controls-rendering-expected.txt.
  • platform/chromium-mac/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac-future/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/mac/media/video-controls-rendering-expected.txt.
1:24 PM Changeset in webkit [107599] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2 build emits a warning about not stripping code-signed PluginProcess.app when copying it into the framework
​https://bugs.webkit.org/show_bug.cgi?id=78451

Reviewed by Sam Weinig.

  • Configurations/Base.xcconfig: Set COPY_PHASE_STRIP to NO.
1:17 PM Changeset in webkit [107598] by fischman@chromium.org
  • 73 edits
    3 copies
    8 moves
    7 adds
    3 deletes in trunk/LayoutTests

Rebaseline media layouttests following keyframe addition to test.ogv
​https://bugs.webkit.org/show_bug.cgi?id=78367

Unreviewed chromium rebaselining.

  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.txt: Added.
  • platform/chromium-gpu-mac/media/controls-strict-expected.png:
  • platform/chromium-gpu-mac/media/controls-styling-expected.png:
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.txt: Added.
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-expected.png:
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-win/media/controls-strict-expected.png:
  • platform/chromium-gpu-win/media/controls-strict-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-strict-expected.txt.
  • platform/chromium-gpu-win/media/controls-styling-expected.png:
  • platform/chromium-gpu-win/media/controls-styling-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-styling-expected.txt.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Copied from LayoutTests/platform/chromium/media/controls-without-preload-expected.txt.
  • platform/chromium-gpu-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-expected.png:
  • platform/chromium-linux-x86/media/video-display-toggle-expected.png: Added.
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-leopard/media/controls-strict-expected.png:
  • platform/chromium-mac-leopard/media/controls-styling-expected.png:
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-leopard/media/video-aspect-ratio-expected.png:
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-leopard/media/video-layer-crash-expected.png:
  • platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-leopard/media/video-transformed-expected.png:
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/video-zoom-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-after-reload-expected.txt.
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-strict-expected.txt.
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-styling-expected.txt.
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium/media/controls-without-preload-expected.txt.
  • platform/chromium-mac-snowleopard/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-canvas-alpha-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-layer-crash-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-playing-and-pause-expected.txt.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.png:
  • platform/chromium-mac-snowleopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac-snowleopard/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-volume-slider-expected.txt.
  • platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.png:
  • platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-zoom-controls-expected.txt.
  • platform/chromium-mac-snowleopard/media/video-zoom-expected.png: Added.
  • platform/chromium-mac/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-mac/media/video-canvas-alpha-expected.png: Removed.
  • platform/chromium-mac/media/video-zoom-expected.png: Removed.
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac-future/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/mac/media/controls-strict-expected.txt.
1:16 PM Changeset in webkit [107597] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Renaming convertToRoundedLayerCoords to convertToPixelSnappedLayerCoords, which better describes what's being done. Also, adding const to AppUnit's abs, round, ceil, and floor methods.

1:07 PM Changeset in webkit [107596] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=78520 Cleanup PageCache::canCachePageContainingThisFrame readability

Reviewed by Anders Carlsson.

No new tests. (Code cleanup, no change in behavior)

  • history/PageCache.cpp:

(WebCore::PageCache::canCachePageContainingThisFrame): Store three commonly

getter-accessed variables in local variables for readability.

12:57 PM Changeset in webkit [107595] by weinig@apple.com
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

Move JSC related assertions out of Assertions.h and into their own header
​https://bugs.webkit.org/show_bug.cgi?id=78508

Reviewed by Gavin Barraclough.

Add GCAssertions.h

  • heap/GCAssertions.h: Added.

Move assertions here.

  • runtime/WriteBarrier.h:

Add #include of GCAssertions.h

  • wtf/Assertions.h:

Remove JSC related assertions.

  • wtf/Compiler.h:

Add compiler check for has_trivial_destructor.

12:31 PM Changeset in webkit [107594] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Update MIPS patchOffsetGetByIdSlowCaseCall
​https://bugs.webkit.org/show_bug.cgi?id=78392

Patch by Chao-ying Fu <​fu@mips.com> on 2012-02-13
Reviewed by Gavin Barraclough.

  • jit/JIT.h:

(JIT):

12:14 PM Changeset in webkit [107593] by timothy@apple.com
  • 3 edits in trunk/Source/WebCore

Don't include a separator before the "Inspect Element" context menu item when the context menu is empty.

​https://webkit.org/b/78312

Reviewed by Brian Weinstein.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::addInspectElementItem): Check itemCount before appending the separator.

  • platform/gtk/ContextMenuGtk.cpp:

(WebCore::ContextMenu::itemCount): Added. Implement so this builds on GTK.

11:54 AM Changeset in webkit [107592] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

[WIN] Define HWND_MESSAGE if not done already
​https://bugs.webkit.org/show_bug.cgi?id=78341

Reviewed by Adam Roben.

HWND_MESSAGE is not defined on WinCE.
Set it to 0 when not defined to avoid #ifdefs.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::Pasteboard):

  • platform/win/WindowsExtras.h:

(WebCore):

11:39 AM Changeset in webkit [107591] by fischman@chromium.org
  • 2 edits in trunk/Tools

Add fischman as committer.

Unreviewed

  • Scripts/webkitpy/common/config/committers.py:
11:32 AM Changeset in webkit [107590] by rniwa@webkit.org
  • 2 edits in trunk

Yet another perf-o-matic build fix. It turns out that a task of the same name can't be
queued for days after the first task is completed. So don't use it. Updating persistent
caches more often than necessary is better than never updating them.

  • Websites/webkit-perf.appspot.com/controller.py:

(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):

11:30 AM Changeset in webkit [107589] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: <mark> element should be exposed through attributes
​https://bugs.webkit.org/show_bug.cgi?id=75727

Reviewed by Beth Dakin.

Source/WebCore:

Exposes an attribute indicating that an element has highlighting through attributedStringForRange.
Also allows the search mechanism to find elements with this style.

Test: platform/mac/accessibility/attributed-string-includes-highlighting.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::hasHighlighting):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilitySearchKeyMap):
(AXAttributeStringSetStyle):

LayoutTests:

  • platform/mac/accessibility/attributed-string-includes-highlighting-expected.txt: Added.
  • platform/mac/accessibility/attributed-string-includes-highlighting.html: Added.
11:23 AM Changeset in webkit [107588] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: the web area should report that focus can be set to itself
​https://bugs.webkit.org/show_bug.cgi?id=78272

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/webarea-can-set-focus.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::canSetFocusAttribute):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

Fixed erroneous comment.

LayoutTests:

  • platform/mac/accessibility/webarea-can-set-focus-expected.txt: Added.
  • platform/mac/accessibility/webarea-can-set-focus.html: Added.
11:05 AM Changeset in webkit [107587] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Remove obsolete #if from ThreadSpecific.h
​https://bugs.webkit.org/show_bug.cgi?id=78485

Reviewed by Adam Roben.

Since alle platform use either pthread or Win32 for threading,
we can remove all PLATFORM() preprocessor statements.

  • wtf/ThreadSpecific.h:

(ThreadSpecific):

10:54 AM Changeset in webkit [107586] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/InlineFlowBox.cpp

We don't actually need to snap the top of inline flow boxes to pixel boundaries. This issue was solved upstream.

10:39 AM LayoutUnit edited by leviw@chromium.org
(diff)
10:08 AM Changeset in webkit [107585] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Port RunLoop to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=76781

Reviewed by Adam Roben.

  • platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::registerRunLoopMessageWindowClass):

10:06 AM Changeset in webkit [107584] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, update mac-snowleopard result. This matches
the Apple Mac (Lion) result except for minor antialias differences.

  • platform/chromium-mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:
9:51 AM Changeset in webkit [107583] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix the Windows build.

9:50 AM Changeset in webkit [107582] by vsevik@chromium.org
  • 14 edits
    1 copy
    3 adds in trunk

Web Inspector: Make ScriptsNavigator default file selector.
​https://bugs.webkit.org/show_bug.cgi?id=78349

Reviewed by Pavel Feldman.

Source/WebCore:

Moved ScriptsNavigator out of experiments.
Introduced new setting "useScriptsNavigator" with true as default value.
Updated scripts panel tests related to file selector.

Tests: inspector/debugger/scripts-combobox-file-selector-history.html

inspector/debugger/scripts-file-selector.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):
(initialize_DebuggerTest.):

  • inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Added.
  • inspector/debugger/scripts-combobox-file-selector-history.html: Added.
  • inspector/debugger/scripts-file-selector-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-panel-expected.txt.
  • inspector/debugger/scripts-file-selector.html: Added.
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/source-frame-count.html:
9:47 AM Changeset in webkit [107581] by weinig@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Use C11's _Static_assert for COMPILE_ASSERT if it is available
​https://bugs.webkit.org/show_bug.cgi?id=78506

Rubber-stamped by Antti Koivisto.

Use C11's _Static_assert for COMPILE_ASSERT if it is available to give slightly
better error messages.

  • wtf/Assertions.h:

Use _Static_assert if it is available.

  • wtf/Compiler.h:

Add COMPILER_SUPPORTS support for _Static_assert when using the LLVM Compiler.

9:44 AM Changeset in webkit [107580] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Make HTMLTableCaptionElement inherit from HTMLElement.
<​http://webkit.org/b/78505>

Reviewed by Antti Koivisto.

HTMLTableCaptionElement was already bypassing its base class (HTMLTablePartElement)
and calling up to HTMLElement in all its overrides. Just make it an HTMLElement
instead since it doesn't use anything from HTMLTablePartElement.
Remove parseAttribute() overload since it's no longer needed.

  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
(WebCore::HTMLTableCaptionElement::isPresentationAttribute):
(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):

  • html/HTMLTableCaptionElement.h:
9:37 AM Changeset in webkit [107579] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLMarqueeElement: Don't cache presence of truespeed attribute.
<​http://webkit.org/b/78483>

Reviewed by Antti Koivisto.

Out-of-line minimumDelay() and look up the "truespeed" attribute there instead
of caching the minimum delay in parseAttribute().
Remove HTMLMarqueeElement::parseAttribute() as it's no longer needed.

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
(WebCore::HTMLMarqueeElement::minimumDelay):

  • html/HTMLMarqueeElement.h:

(HTMLMarqueeElement):

9:21 AM Changeset in webkit [107578] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

  • platform/qt/Skipped:
9:18 AM Changeset in webkit [107577] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):

9:11 AM Changeset in webkit [107576] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [refactoring] factor common timeline UI state into TimelinePresentationModel
​https://bugs.webkit.org/show_bug.cgi?id=78501

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createTopPane):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._createTimelineCategoryStatusBarCheckbox):
(WebInspector.TimelinePanel.prototype._onCategoryCheckboxClicked):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._updateBoundaries):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.get categories):
(WebInspector.TimelinePresentationModel.prototype.addCategory):
(WebInspector.TimelinePresentationModel.prototype.setWindowPosition):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):

8:39 AM Changeset in webkit [107575] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk

Use requestAnimationFrame callbacks to pump CSS animations
​https://bugs.webkit.org/show_bug.cgi?id=64591

Patch by Joel Webber <​jgw@google.com> on 2012-02-13
Reviewed by James Robinson.

No new tests needed (covered by tests in animations/*).

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
(WebCore::AnimationControllerPrivate::animationFrameCallbackFired):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::serviceAnimations):

  • page/animation/AnimationController.h:
  • page/animation/AnimationControllerPrivate.h:
8:29 AM Changeset in webkit [107574] by Patrick Gansterer
  • 3 edits
    1 add in trunk/Source/WebCore

Add WindowsExtras.h
​https://bugs.webkit.org/show_bug.cgi?id=78340

Reviewed by Adam Roben.

Add a new file to share common code for Win32/WinCE differences.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::PopupMenuWndProc):

  • platform/win/RunLoopWin.cpp:

(WebCore::RunLoop::RunLoopWndProc):

  • platform/win/WindowsExtras.h: Added.

(WebCore):
(WebCore::getWindowPointer):
(WebCore::setWindowPointer):

7:54 AM Changeset in webkit [107573] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't mark element for style recalc when modifying its attribute style.
<​http://webkit.org/b/78497>

Reviewed by Antti Koivisto.

StylePropertySet::setNeedsStyleRecalc() shouldn't do anything for attribute styles.
Their invalidation is handled exclusively by StyledElement::attributeChanged().
Elements with presentation attributes were being marked for style recalc twice,
once when the attribute changed, and again during attribute style update, below the
call to collectStyleForAttribute().

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setNeedsStyleRecalc):

7:10 AM Changeset in webkit [107572] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, add new chromium baselines for font-face-multiple-faces.html.

  • platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png:
  • platform/chromium-win/fast/css/font-face-multiple-faces-expected.png:
7:05 AM Changeset in webkit [107571] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Manage ShareableBitmap object lifecycle properly, when QImage is created
using the shared data.
​https://bugs.webkit.org/show_bug.cgi?id=77546

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-02-13
Reviewed by Simon Hausmann.

  • Shared/ShareableBitmap.h:

(ShareableBitmap):

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createQImage):
(WebKit):
(WebKit::ShareableBitmap::releaseSharedMemoryData):

7:02 AM Changeset in webkit [107570] by caio.oliveira@openbossa.org
  • 13 edits in trunk/Source/WebCore

Move attribute storage from NamedNodeMap to ElementAttributeData
​https://bugs.webkit.org/show_bug.cgi?id=77674

Reviewed by Andreas Kling.

Move m_attributes vector from NamedNodeMap to ElementAttributeData. Make the
remaining callsites interact with ElementAttributeData if possible. The parsing
code is still interacting with NamedNodeMap, so some functions remained as
wrappers there. A next change will it use ElementAttributeData instead.

The code for DOM exported functions remained in NamedNodeMap. This implementation
should move to Element in a next change, too.

  • dom/Attr.h:

(Attr):

  • dom/Element.cpp:

(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributeMap):
(WebCore::Element::removeAttribute):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):

  • dom/Element.h:

(Element):
(WebCore::Element::ensureUpdatedAttributes):
(WebCore::Element::ensureAttributeData):
(WebCore):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):
These *AttributeData functions are the correct correct way for callers to touch
the details of attribute storage. The "updated" variants will update invalid
attributes before return.

(WebCore::Element::setAttributesFromElement):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::~ElementAttributeData):
(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::detachAttributesFromElement):
(WebCore::ElementAttributeData::copyAttributesToVector):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::setAttributes): Make use of the assumption that
this will only be called with a valid Element, since the only call site is an
Element method.
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute): Make use of the assumption
this will only be called with a valid Element, since the only call site return
early if there's no Element.

  • dom/ElementAttributeData.h:

(ElementAttributeData):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::item):
(WebCore::NamedNodeMap::detachFromElement):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::length):
(WebCore::NamedNodeMap::isEmpty):
(WebCore::NamedNodeMap::attributeItem):
(WebCore::NamedNodeMap::getAttributeItem):
(WebCore::NamedNodeMap::getAttributeItemIndex):
(WebCore::NamedNodeMap::shrinkToLength):
(WebCore::NamedNodeMap::reserveInitialCapacity):
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

  • dom/StyledElement.h:

(WebCore::StyledElement::ensureInlineStyleDecl):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • svg/properties/SVGAnimatedPropertySynchronizer.h:
  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

6:50 AM Changeset in webkit [107569] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: wrong percent calculations for empty snapshot.
​https://bugs.webkit.org/show_bug.cgi?id=78329

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-02-13
Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):

6:33 AM Changeset in webkit [107568] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: add class filter to heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=78362

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-02-13
Reviewed by Yury Semikhatsky.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.insertChild):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._nameFilterChanged):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .constructors-view-grid):
(.detailed-heapshot-view .constructors-view-toolbar):
(.detailed-heapshot-view .constructors-view-toolbar input.constructors-view-filter):

6:27 AM Changeset in webkit [107567] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional
​https://bugs.webkit.org/show_bug.cgi?id=77917

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-02-13
Reviewed by Pavel Feldman.

Source/WebCore:

Property descriptor is fixed in Inspector.json. Also retroactively in
0.1 and 1.0.
Injected script in instructed to never return null property values.

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector-0.1.json:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:

LayoutTests:

"Undefined" getter and setter is now visible.

  • inspector/runtime/runtime-getProperties-expected.txt:
6:27 AM WebKitIDL edited by haraken@chromium.org
(diff)
6:24 AM WebKitIDL edited by haraken@chromium.org
(diff)
6:18 AM Changeset in webkit [107566] by mario@webkit.org
  • 6 edits in trunk/Source

[GTK] Add GSList to the list of GObject types in GOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=78487

Reviewed by Philippe Normand.

Source/JavaScriptCore:

Handle the GSList type in GOwnPtr, by calling g_slist_free in the
implementation of the freeOwnedGPtr template function.

  • wtf/gobject/GOwnPtr.cpp:

(WTF::GSList):
(WTF):

  • wtf/gobject/GOwnPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::runOpenPanel): Use GOwnPtr<GSList> for the
list of filenames returned by gtk_file_chooser_get_filenames().

6:16 AM Changeset in webkit [107565] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] Revise configuration for MHTML
​https://bugs.webkit.org/show_bug.cgi?id=78364

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-13
Reviewed by Gustavo Noronha Silva.

.:

Added some lines to show checking messages, whether mhtml is enabled or not
during configuration and the configuration result for mhtml.
MHTML is a web page archive format used to combine resources
that are typically represented by external links (such as images, Flash animations,
Java applets, audio files) together with HTML code into a single file.
​http://en.wikipedia.org/wiki/MHTML

  • configure.ac:

Source/WebCore:

Added mhtml directory and removed target files duplicated to build when enabling mhtml.
Archive.cpp, ArchiveFactory.cpp & their headers are included at the above line.
This duplication has caused build-break if mhtml is enabled.

No new tests, since no new features.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
6:15 AM WebKitIDL edited by haraken@chromium.org
(diff)
5:59 AM Changeset in webkit [107564] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/test_expectations.txt: Mark fast/js/dfg-inline-function-dot-caller.html as slow in debug mode.
5:42 AM Changeset in webkit [107563] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-13 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, add "IMAGE" to two svg/carto.net tests expectations.

  • platform/chromium/test_expectations.txt:
5:30 AM Changeset in webkit [107562] by kubo@profusion.mobi
  • 22 edits in trunk

[EFL] Drop support for the Curl network backend.
​https://bugs.webkit.org/show_bug.cgi?id=77874

Reviewed by Eric Seidel.

Nobody seems to be maintaining the Curl backend in WebCore, the
EFL port developers all seem to be using the Soup backend and the
port itself has many features which are only implemented for the
latter.

.:

  • Source/cmake/OptionsEfl.cmake: Remove network backend selection

checks and unconditionally require Glib and Libsoup, bump the
required LibSoup version to the same one the GTK+ port looks for,
since we share the same network backend.

Source/JavaScriptCore:

  • wtf/PlatformEfl.cmake: Always build the gobject-dependent source

files.

Source/WebCore:

No new tests, just some dependency plumbing.

  • PlatformEfl.cmake: Build the glib/soup source files

unconditionally.

  • platform/efl/FileSystemEfl.cpp: Remove ENABLE(GLIB_SUPPORT) check.

Source/WebKit/efl:

  • CMakeListsEfl.txt: Unconditionally build soup-dependent files

and always add the glib/soup include directories and libraries.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
Remove USE(SOUP) checks.

  • ewk/ewk_auth.cpp:

(ewk_auth_show_dialog_callback_set): Ditto.
(ewk_auth_credentials_set): Ditto.

  • ewk/ewk_cookies.cpp:

(ewk_cookies_file_set): Ditto.
(ewk_cookies_clear): Ditto.
(ewk_cookies_get_all): Ditto.
(ewk_cookies_cookie_del): Ditto.
(ewk_cookies_cookie_free): Ditto.
(ewk_cookies_policy_set): Ditto.
(ewk_cookies_policy_get): Ditto.

  • ewk/ewk_frame.cpp:

(ewk_frame_certificate_status_get): Ditto.

  • ewk/ewk_main.cpp:

(_ewk_init_body): Ditto.

  • ewk/ewk_network.cpp:

(ewk_network_proxy_uri_set): Ditto.
(ewk_network_proxy_uri_get): Ditto.
(ewk_network_tls_certificate_check_get): Ditto.
(ewk_network_tls_certificate_check_set): Ditto.
(ewk_network_tls_ca_certificates_path_get): Ditto.
(ewk_network_tls_ca_certificates_path_set): Ditto.
(ewk_network_default_soup_session_get): Ditto.

  • ewk/ewk_network.h: Update apidox for

ewk_network_default_soup_session_get() now that libsoup is the
only available backend.

Source/WebKit2:

  • PlatformEfl.cmake: Unconditionally build the glib/soup source

files and unconditionally add the required include directories and
libraries.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl): Remove USE(SOUP) check.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup

and always add the required include directories.

  • EWebLauncher/CMakeLists.txt: Add the required glib/libsoup

include directories and link to them.

5:12 AM Changeset in webkit [107561] by pfeldman@chromium.org
  • 6 edits
    4 adds in trunk

Web Inspector: wrap settings selector text and adding a rule with undoable actions.
​https://bugs.webkit.org/show_bug.cgi?id=78482

Reviewed by Yury Semikhatsky.

Source/WebCore:

Tests: inspector/styles/undo-add-new-rule.html

inspector/styles/undo-set-selector-text.html

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(InspectorCSSAgent::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::perform):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::undo):
(WebCore):
(InspectorCSSAgent::AddRuleAction):
(WebCore::InspectorCSSAgent::AddRuleAction::AddRuleAction):
(WebCore::InspectorCSSAgent::AddRuleAction::perform):
(WebCore::InspectorCSSAgent::AddRuleAction::undo):
(WebCore::InspectorCSSAgent::AddRuleAction::newRuleId):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::styleSheetChanged):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ruleSelector):
(WebCore):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
(WebCore::InspectorStyleSheet::fireStyleSheetChanged):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

  • inspector/InspectorStyleSheet.h:

(InspectorStyleSheet):
(WebCore::InspectorStyleSheet::styleId):
(InspectorStyleSheetForInlineStyle):

LayoutTests:

  • inspector/styles/undo-add-new-rule-expected.txt: Added.
  • inspector/styles/undo-add-new-rule.html: Added.
  • inspector/styles/undo-set-selector-text-expected.txt: Added.
  • inspector/styles/undo-set-selector-text.html: Added.
4:45 AM Changeset in webkit [107560] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

  • platform/qt/Skipped:
4:45 AM Changeset in webkit [107559] by bashi@chromium.org
  • 2 edits in trunk/Tools

[WebSocket] Update pywebsocket to 0.7.1
​https://bugs.webkit.org/show_bug.cgi?id=78484

pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.

Reviewed by Kent Tamura.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pywebsocket):

4:15 AM Changeset in webkit [107558] by hayato@chromium.org
  • 14 edits
    1 move
    1 add
    1 delete in trunk/Source/WebCore

Rename names defined in ContentInclutionSelector to more intuitive names.
​https://bugs.webkit.org/show_bug.cgi?id=78333

Reviewed by Hajime Morita.

This is just refactoring, renaming non-intuitive names to more intuitive names
so that they match the terms in the spec.

No tests. No change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::insertionPoint):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertionPointFor):
(WebCore::ShadowRoot::isSelectorActive):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::selector):
(WebCore::ShadowRoot::ensureSelector):

  • dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):

  • html/shadow/ContentInclusionSelector.h: Removed.
  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

  • html/shadow/HTMLContentElement.h:

(WebCore):
(WebCore::HTMLContentElement::selections):
(WebCore::HTMLContentElement::hasSelection):
(HTMLContentElement):

  • html/shadow/HTMLContentSelector.cpp: Renamed from Source/WebCore/html/shadow/ContentInclusionSelector.cpp.

(WebCore):
(WebCore::HTMLContentSeleciton::append):
(WebCore::HTMLContentSeleciton::unlink):
(WebCore::HTMLContentSelectionList::HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::~HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::find):
(WebCore::HTMLContentSelectionList::clear):
(WebCore::HTMLContentSelectionList::append):
(WebCore::HTMLContentSelector::HTMLContentSelector):
(WebCore::HTMLContentSelector::~HTMLContentSelector):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::unselect):
(WebCore::HTMLContentSelector::findFor):
(WebCore::HTMLContentSelector::didSelect):
(WebCore::HTMLContentSelector::willSelectOver):

  • html/shadow/HTMLContentSelector.h: Added.

(WebCore):
(HTMLContentSeleciton):
(WebCore::HTMLContentSeleciton::insertionPoint):
(WebCore::HTMLContentSeleciton::node):
(WebCore::HTMLContentSeleciton::next):
(WebCore::HTMLContentSeleciton::previous):
(WebCore::HTMLContentSeleciton::HTMLContentSeleciton):
(WebCore::HTMLContentSeleciton::create):
(HTMLContentSelectionList):
(WebCore::HTMLContentSelectionList::first):
(WebCore::HTMLContentSelectionList::last):
(WebCore::HTMLContentSelectionList::isEmpty):
(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::add):
(WebCore::HTMLContentSelectionSet::remove):
(WebCore::HTMLContentSelectionSet::isEmpty):
(Translator):
(WebCore::HTMLContentSelectionSet::Translator::hash):
(WebCore::HTMLContentSelectionSet::Translator::equal):
(WebCore::HTMLContentSelectionSet::Hash::hash):
(WebCore::HTMLContentSelectionSet::Hash::equal):
(Hash):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):
(WebCore::HTMLContentSelector::hasCandidates):

  • testing/Internals.cpp:

(WebCore::Internals::includerFor):

4:08 AM Changeset in webkit [107557] by pfeldman@chromium.org
  • 6 edits in branches/chromium/1025

Merge 107242 - Web Inspector: fix setOuterHTML for the case that adds / removes duplicate.
​https://bugs.webkit.org/show_bug.cgi?id=78235

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore):
(WebCore::nodeName):
(WebCore::DOMEditor::dumpMap):

  • inspector/DOMEditor.h:

(DOMEditor):

LayoutTests:

  • inspector/elements/set-outer-html-2-expected.txt:
  • inspector/elements/set-outer-html-2.html:
  • inspector/elements/set-outer-html-expected.txt:
  • inspector/elements/set-outer-html.html:

TBR=​pfeldman@chromium.org
BUG=113388
Review URL: ​https://chromiumcodereview.appspot.com/9389003

4:02 AM WebKitIDL edited by haraken@chromium.org
(diff)
4:00 AM RegressionTestResearch edited by Csaba Osztrogonác
(diff)
4:00 AM WebKitIDL edited by haraken@chromium.org
(diff)
3:57 AM WebKitIDL edited by haraken@chromium.org
(diff)
3:57 AM Changeset in webkit [107556] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Texmap] morphing-cubes animation appears too close when clicking the button
​https://bugs.webkit.org/show_bug.cgi?id=78476

Fixed bug in TextureMapperAnimation that made transform animations that go to/from identity
to not work.

Reviewed by Simon Hausmann.

No behavior changes.

  • platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::applyTransformAnimation):

3:43 AM RegressionTestResearch created by beszedes@inf.u-szeged.hu
Adding regression test improvement pages
3:40 AM Top100Invariant created by beszedes@inf.u-szeged.hu
Adding regression test improvement pages
3:39 AM SelectiveTestEWS created by beszedes@inf.u-szeged.hu
3:36 AM SelectiveTestBuildBot created by beszedes@inf.u-szeged.hu
Adding regression test improvement pages
3:30 AM Improving Regression Tests edited by beszedes@inf.u-szeged.hu
(diff)
3:27 AM Improving Regression Tests created by beszedes@inf.u-szeged.hu
Adding regression test improvement pages
3:22 AM WikiStart edited by beszedes@inf.u-szeged.hu
Adding regression test improvement pages (diff)
3:01 AM Changeset in webkit [107555] by commit-queue@webkit.org
  • 28 edits in trunk/Source

[Forms] Use enum instead of bool for HTMLInputElement::setValue
​https://bugs.webkit.org/show_bug.cgi?id=75217

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2012-02-13
Reviewed by Kent Tamura.

Source/WebCore:

Use TextFieldEventBehavior enum instead of sendChangeEvent bool
parameter for HTMLInputElement::setValue method. This new enum
parameter will be extended to dispatch input and change events
when user agent populates input field as specified in
"Common events behavior" of HTML5 standard.

This patch is required for fixing bug 75067 "[Forms] Spin buttons
of number input type should fire both input and change event."

No new tests. Existing tests cover this patch.

  • html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::setValue):

  • html/BaseButtonInputType.h:
  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::setValue):

  • html/BaseCheckableInputType.h:
  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::setValueAsNumber):

  • html/BaseDateAndTimeInputType.h:
  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::willDispatchClick):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::setValue):

  • html/ColorInputType.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::setValue):

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::applyStep):
(WebCore::HTMLInputElement::stepUp):
(WebCore::HTMLInputElement::stepDown):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::setValueForUser):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueInternal):
(WebCore::HTMLInputElement::setValueAsNumber):
(WebCore::HTMLInputElement::stepUpFromRenderer):

  • html/HTMLInputElement.h:
  • html/HTMLTextFormControlElement.h:
  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::setValue):

  • html/HiddenInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::setValueAsNumber):
(WebCore::InputType::setValue):

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::setValueAsNumber):

  • html/NumberInputType.h:
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::willDispatchClick):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::setValueAsNumber):
(WebCore::RangeInputType::handleKeydownEvent):
(WebCore::RangeInputType::setValue):

  • html/RangeInputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue):

  • html/TextFieldInputType.h:

Source/WebKit/chromium:

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::setValue): Use enum for HTMLInputElement::setValue

2:36 AM Changeset in webkit [107554] by kling@webkit.org
  • 67 edits in trunk/Source/WebCore

Move attribute style invalidation to attributeChanged().
<​http://webkit.org/b/78461>

Reviewed by Antti Koivisto.

Moved attribute style invalidation out of the parseAttribute() overloads
and added an "isPresentationAttribute(Attribute*) virtual to StyledElement.
Returning true for a given Attribute will cause attribute style invalidation
when that attribute passes through attributeChanged().

Removed a couple of parseAttribute() overloads whose only remaining purpose
was invalidating attribute style.

For form elements that deliberately don't map the "align" attribute, added
short-circuits in isPresentationAttribute instead of falling back to the
respective base class (which may othweise then map "align")

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

  • dom/StyledElement.h:

(WebCore::StyledElement::isPresentationAttribute):

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::isPresentationAttribute):

  • html/HTMLBRElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::isPresentationAttribute):
(WebCore::HTMLBodyElement::collectStyleForAttribute):
(WebCore::HTMLBodyElement::parseAttribute):

  • html/HTMLBodyElement.h:
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isPresentationAttribute):
(WebCore::HTMLButtonElement::parseAttribute):

  • html/HTMLButtonElement.h:
  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::isPresentationAttribute):

  • html/HTMLDivElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::isPresentationAttribute):
(WebCore::HTMLElement::parseAttribute):

  • html/HTMLElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::isPresentationAttribute):
(WebCore::HTMLEmbedElement::parseAttribute):

  • html/HTMLEmbedElement.h:
  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::isPresentationAttribute):

  • html/HTMLFontElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::isPresentationAttribute):
(WebCore::HTMLFrameSetElement::parseAttribute):

  • html/HTMLFrameSetElement.h:
  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::isPresentationAttribute):
(WebCore::HTMLHRElement::collectStyleForAttribute):

  • html/HTMLHRElement.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::isPresentationAttribute):
(WebCore::HTMLIFrameElement::collectStyleForAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):

  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::isPresentationAttribute):
(WebCore::HTMLImageElement::collectStyleForAttribute):
(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isPresentationAttribute):
(WebCore::HTMLInputElement::collectStyleForAttribute):
(WebCore::HTMLInputElement::parseAttribute):

  • html/HTMLInputElement.h:
  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::isPresentationAttribute):
(WebCore::HTMLLIElement::parseAttribute):

  • html/HTMLLIElement.h:
  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::isPresentationAttribute):
(WebCore::HTMLMarqueeElement::collectStyleForAttribute):
(WebCore::HTMLMarqueeElement::parseAttribute):

  • html/HTMLMarqueeElement.h:
  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::isPresentationAttribute):
(WebCore::HTMLOListElement::parseAttribute):

  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::isPresentationAttribute):
(WebCore::HTMLObjectElement::parseAttribute):

  • html/HTMLObjectElement.h:
  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::isPresentationAttribute):

  • html/HTMLParagraphElement.h:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::isPresentationAttribute):
(WebCore::HTMLPlugInElement::collectStyleForAttribute):

  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.cpp:

(WebCore::HTMLPreElement::isPresentationAttribute):
(WebCore::HTMLPreElement::collectStyleForAttribute):

  • html/HTMLPreElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::isPresentationAttribute):
(WebCore::HTMLSelectElement::parseAttribute):

  • html/HTMLSelectElement.h:
  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::isPresentationAttribute):
(WebCore::HTMLTableCaptionElement::parseAttribute):

  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::isPresentationAttribute):
(WebCore::HTMLTableCellElement::collectStyleForAttribute):
(WebCore::HTMLTableCellElement::parseAttribute):

  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::isPresentationAttribute):
(WebCore::HTMLTableColElement::parseAttribute):

  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::isPresentationAttribute):
(WebCore::HTMLTableElement::parseAttribute):

  • html/HTMLTableElement.h:
  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::isPresentationAttribute):
(WebCore::HTMLTablePartElement::collectStyleForAttribute):

  • html/HTMLTablePartElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::isPresentationAttribute):
(WebCore::HTMLTextAreaElement::parseAttribute):

  • html/HTMLTextAreaElement.h:
  • html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::isPresentationAttribute):
(WebCore::HTMLUListElement::collectStyleForAttribute):

  • html/HTMLUListElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::isPresentationAttribute):
(WebCore::HTMLVideoElement::parseAttribute):

  • html/HTMLVideoElement.h:
  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPresentationAttribute):
(WebCore::MathMLElement::collectStyleForAttribute):

  • mathml/MathMLElement.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::isPresentationAttribute):
(WebCore::SVGImageElement::parseAttribute):

  • svg/SVGImageElement.h:
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::isPresentationAttribute):
(WebCore::SVGStyledElement::parseAttribute):

  • svg/SVGStyledElement.h:
  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::isPresentationAttribute):
(WebCore::SVGTextContentElement::parseAttribute):

  • svg/SVGTextContentElement.h:
2:24 AM Changeset in webkit [107553] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Add [JSCustomToJSObject] IDL attribute to interfaces that have
custom toJS() but do not have custom toV8()
​https://bugs.webkit.org/show_bug.cgi?id=78466

Reviewed by Adam Barth.

This is the second step to remove hard-coding in HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch replaces [JSCustomToJS] with [JSCustomToJSObject]
for interfaces which have custom toJS() but do not have custom toV8().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(HasCustomToV8Implementation): I found that AbstractWorker and CanvasRenderingContext
are the only IDL files to which I need to add [JSCustomToJSObject].
Other IDL files which had been listed here do not have [JSCustomToJS].

  • html/canvas/CanvasRenderingContext.idl:
  • workers/AbstractWorker.idl:
2:23 AM Changeset in webkit [107552] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

Unreviewed gardening after r107544.

  • fast/dom/wrapper-classes-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
2:09 AM Changeset in webkit [107551] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid unnecessary work when evaluating style sharing candidates.
<​http://webkit.org/b/78220>

Reviewed by Antti Koivisto.

Do the cheap checks (bitfields, pointers) before calling virtuals and doing hash lookups.
Remove comparison of attributes that are reflected in the attribute styles (cellpadding.)
Moved comparison of "type" and "readonly" attributes into the more specific
canShareStyleWithControl() since they are only relevant for input elements. Don't bother
calling isFormControlElement() on both elements as they already have the same tagQName().

Altogether this knocks off ~8ms worth of samples per cycle of the "Moz" page cycler test.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::isCommonAttributeSelectorAttribute):

2:08 AM Changeset in webkit [107550] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-13 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, mark dfg-put-by-id-prototype-check.html as failing in chromium (new test).

  • platform/chromium/test_expectations.txt:
2:08 AM Changeset in webkit [107549] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r107485.

  • bytecode/PolymorphicPutByIdList.cpp:
1:47 AM Changeset in webkit [107548] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

<summary> is not keyboard accessible.
​https://bugs.webkit.org/show_bug.cgi?id=75478

Patch by Arko Saha <​arko@motorola.com> on 2012-02-13
Reviewed by Hajime Morita.

Source/WebCore:

Toggle the content of <details> element on pressing Enter or Spacebar
key on a focused <summary> element.

Test: fast/html/details-keyboard-show-hide.html

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::supportsFocus):
(WebCore):
(WebCore::HTMLSummaryElement::defaultEventHandler):

  • html/HTMLSummaryElement.h:

(HTMLSummaryElement):

LayoutTests:

  • fast/html/details-keyboard-show-hide-expected.txt: Added.
  • fast/html/details-keyboard-show-hide.html: Added.
  • platform/chromium/test_expectations.txt: <summary> is now focusable and clicking

it draws a focus ring. So we need to rebase failed test cases.

1:37 AM Changeset in webkit [107547] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r107518): It broke many tests
​https://bugs.webkit.org/show_bug.cgi?id=78471

  • platform/qt/Skipped: Unreviewed gardening, skip failing tests.
1:31 AM Changeset in webkit [107546] by podivilov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2012-02-13 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, add new baseline for font-face-default-font.html on linux.

  • platform/chromium-linux/fast/css/font-face-default-font-expected.txt: Added.
1:30 AM Changeset in webkit [107545] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

Rebaseline JPEG image results after r107389
​https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Preparation for a bunch of rebaselines.

  • platform/chromium/test_expectations.txt: unskip tests to allow bots to cycle and

produce the new JPEG image results.

1:28 AM Changeset in webkit [107544] by barraclough@apple.com
  • 29 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=78434
Unreviewed - temporarily reverting r107498 will I fix a couple of testcases.

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::::parseFunctionInfo):

  • runtime/ClassInfo.h:

(MethodTable):
(JSC):

  • runtime/JSCell.cpp:

(JSC):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC):

  • runtime/JSGlobalObjectFunctions.h:

(JSC):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:

(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSValue::get):

  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

  • runtime/JSValue.h:

(JSValue):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/Structure.h:

(JSC::Structure::setHasGetterSetterProperties):
(Structure):

Source/WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore):

  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

LayoutTests:

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/cyclic-prototypes-expected.txt:
  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/preventExtensions-expected.txt:
  • fast/js/prototypes-expected.txt:
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
  • fast/js/script-tests/cyclic-prototypes.js:
  • fast/js/script-tests/parser-syntax-check.js:
  • fast/js/script-tests/preventExtensions.js:
  • fast/js/script-tests/prototypes.js:
1:22 AM WebKitIDL edited by haraken@chromium.org
(diff)
1:01 AM Changeset in webkit [107543] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-13 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, remove missing test from expectations.

  • platform/chromium/test_expectations.txt:
12:53 AM Changeset in webkit [107542] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: get rid of cycles in containment view of an object.
​https://bugs.webkit.org/show_bug.cgi?id=78462

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

12:48 AM WebKitIDL edited by haraken@chromium.org
(diff)
12:36 AM WebKitIDL edited by haraken@chromium.org
(diff)
12:18 AM Changeset in webkit [107541] by abarth@webkit.org
  • 6 edits
    3 adds in trunk/Source/WebCore

Remove ENABLE(MEDIA_STREAM) from Navigator.h
​https://bugs.webkit.org/show_bug.cgi?id=78467

Reviewed by Kentaro Hara.

Navigator.webkitGetUser media doesn't really have anything to do with
Navigator.cpp. This patch moves it into the mediastream directory and
removes the ENABLE(MEDIA_STREAM) ifdefs in Navigator.h and
Navigator.cpp.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • mediastream/NavigatorMediaStream.cpp: Added.

(WebCore):
(WebCore::NavigatorMediaStream::NavigatorMediaStream):
(WebCore::NavigatorMediaStream::~NavigatorMediaStream):
(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • mediastream/NavigatorMediaStream.h: Added.

(WebCore):
(NavigatorMediaStream):

  • mediastream/NavigatorMediaStream.idl: Added.
  • page/Navigator.cpp:

(WebCore):

  • page/Navigator.h:

(WebCore):
(Navigator):

  • page/Navigator.idl:
12:17 AM Changeset in webkit [107540] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

This test is testing the argument handling behavior of this API. Now
that we autogenerate this code, we now throw consistent exceptions with
the rest of the platform. There shouldn't be a compat issue here
because this API hasn't shipped in production releases yet.

  • fast/dom/MediaStream/argument-types-expected.txt:
  • fast/dom/MediaStream/script-tests/argument-types.js:
12:10 AM Changeset in webkit [107539] by commit-queue@webkit.org
  • 2 edits
    178 adds in trunk/LayoutTests

[EFL][DRT] Add new expected layout results come from bug 78091.
​https://bugs.webkit.org/show_bug.cgi?id=78188

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-02-13
Reviewed by Ryosuke Niwa.

Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
This patch will activate around 1,900 test cases from skipped list in EFL port.

  • platform/efl/Skipped:
  • platform/efl/svg/css/composite-shadow-example-expected.txt: Added.
  • platform/efl/svg/css/composite-shadow-text-expected.txt: Added.
  • platform/efl/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/efl/svg/css/css-box-min-width-expected.txt: Added.
  • platform/efl/svg/css/group-with-shadow-expected.txt: Added.
  • platform/efl/svg/css/mask-with-shadow-expected.txt: Added.
  • platform/efl/svg/css/path-gradient-stroke-shadow-expected.txt: Added.
  • platform/efl/svg/css/path-with-shadow-expected.txt: Added.
  • platform/efl/svg/css/shadow-and-opacity-expected.txt: Added.
  • platform/efl/svg/css/shadow-changes-expected.txt: Added.
  • platform/efl/svg/css/shadow-with-large-radius-expected.txt: Added.
  • platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Added.
  • platform/efl/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/efl/svg/css/text-gradient-shadow-expected.txt: Added.
  • platform/efl/svg/css/text-shadow-multiple-expected.txt: Added.
  • platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
  • platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
  • platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Added.
  • platform/efl/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
  • platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
  • platform/efl/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
  • platform/efl/svg/hixie/cascade/001-broken-expected.txt: Added.
  • platform/efl/svg/hixie/cascade/002-expected.txt: Added.
  • platform/efl/svg/hixie/data-types/001-expected.txt: Added.
  • platform/efl/svg/hixie/data-types/002-expected.txt: Added.
  • platform/efl/svg/hixie/dynamic/002-expected.txt: Added.
  • platform/efl/svg/hixie/dynamic/003-expected.txt: Added.
  • platform/efl/svg/hixie/dynamic/004-expected.txt: Added.
  • platform/efl/svg/hixie/dynamic/005-expected.txt: Added.
  • platform/efl/svg/hixie/dynamic/006-expected.txt: Added.
  • platform/efl/svg/hixie/error/001-expected.txt: Added.
  • platform/efl/svg/hixie/error/002-expected.txt: Added.
  • platform/efl/svg/hixie/error/003-expected.txt: Added.
  • platform/efl/svg/hixie/error/006-expected.txt: Added.
  • platform/efl/svg/hixie/error/007-expected.txt: Added.
  • platform/efl/svg/hixie/error/008-expected.txt: Added.
  • platform/efl/svg/hixie/error/009-expected.txt: Added.
  • platform/efl/svg/hixie/error/010-expected.txt: Added.
  • platform/efl/svg/hixie/error/011-expected.txt: Added.
  • platform/efl/svg/hixie/error/012-expected.txt: Added.
  • platform/efl/svg/hixie/error/013-expected.txt: Added.
  • platform/efl/svg/hixie/error/014-expected.txt: Added.
  • platform/efl/svg/hixie/error/014-test-expected.txt: Added.
  • platform/efl/svg/hixie/error/015-expected.txt: Added.
  • platform/efl/svg/hixie/error/016-expected.txt: Added.
  • platform/efl/svg/hixie/error/017-expected.txt: Added.
  • platform/efl/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/efl/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/efl/svg/hixie/intrinsic/003-expected.txt: Added.
  • platform/efl/svg/hixie/links/002-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/003-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/004-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/005-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/006-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/007-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/008-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/009-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/010-expected.txt: Added.
  • platform/efl/svg/hixie/mixed/011-expected.txt: Added.
  • platform/efl/svg/hixie/painting/001-expected.txt: Added.
  • platform/efl/svg/hixie/perf/001-expected.txt: Added.
  • platform/efl/svg/hixie/perf/002-expected.txt: Added.
  • platform/efl/svg/hixie/perf/003-expected.txt: Added.
  • platform/efl/svg/hixie/perf/004-expected.txt: Added.
  • platform/efl/svg/hixie/perf/005-expected.txt: Added.
  • platform/efl/svg/hixie/perf/006-expected.txt: Added.
  • platform/efl/svg/hixie/perf/007-expected.txt: Added.
  • platform/efl/svg/hixie/processing-model/003-expected.txt: Added.
  • platform/efl/svg/hixie/processing-model/004-expected.txt: Added.
  • platform/efl/svg/hixie/processing-model/005-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/001-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/002-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/003-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/003a-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/004-expected.txt: Added.
  • platform/efl/svg/hixie/shapes/path/001-expected.txt: Added.
  • platform/efl/svg/hixie/text/001-expected.txt: Added.
  • platform/efl/svg/hixie/text/002-expected.txt: Added.
  • platform/efl/svg/hixie/text/003-expected.txt: Added.
  • platform/efl/svg/hixie/text/003a-expected.txt: Added.
  • platform/efl/svg/hixie/text/003b-expected.txt: Added.
  • platform/efl/svg/hixie/transform/001-expected.txt: Added.
  • platform/efl/svg/hixie/use/001-expected.txt: Added.
  • platform/efl/svg/hixie/use/002-expected.txt: Added.
  • platform/efl/svg/hixie/use/002-test-expected.txt: Added.
  • platform/efl/svg/hixie/viewbox/001-expected.txt: Added.
  • platform/efl/svg/hixie/viewbox/004-expected.txt: Added.
  • platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
  • platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
  • platform/efl/svg/in-html/by-reference-expected.txt: Added.
  • platform/efl/svg/in-html/circle-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-foreignObject-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
  • platform/efl/svg/repaint/filter-child-repaint-expected.txt: Added.
  • platform/efl/svg/repaint/filter-repaint-expected.txt: Added.
  • platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/efl/svg/transforms/animated-path-inside-transformed-html-expected.txt: Added.
  • platform/efl/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/efl/svg/transforms/svg-css-transforms-expected.txt: Added.
  • platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Added.
  • platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
  • platform/efl/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/efl/svg/wicd/sizing-flakiness-expected.txt: Added.
  • platform/efl/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/efl/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/efl/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/efl/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/efl/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/efl/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/efl/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/efl/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/efl/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.

Feb 12, 2012:

11:59 PM Changeset in webkit [107538] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping 2 tests failing because of bug 78434.

  • platform/gtk/Skipped:
11:30 PM Changeset in webkit [107537] by abarth@webkit.org
  • 5 edits
    2 deletes in trunk/Source/WebCore

Navigator.webkitGetUserMedia doesn't need to be custom
​https://bugs.webkit.org/show_bug.cgi?id=78464

Reviewed by Eric Seidel.

The code generator has gotten smarter since this function was added.

  • GNUmakefile.list.am:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/js/JSNavigatorCustom.cpp: Removed.
  • bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
  • page/Navigator.idl:
11:03 PM Changeset in webkit [107536] by abarth@webkit.org
  • 14 edits
    2 adds in trunk/Source/WebCore

Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp
​https://bugs.webkit.org/show_bug.cgi?id=78457

Reviewed by Hajime Morita.

This patch moves GAMEPAD-specific logic out of Navigator by introducing
the concept of a NavigatorSupplement, analogous to the recently
introduced PageSupplement.

  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::from):
(WebCore):
(WebCore::NavigatorGamepad::webkitGamepads):
(WebCore::NavigatorGamepad::gamepads):

  • Modules/gamepad/NavigatorGamepad.h:

(NavigatorGamepad):

  • WebCore.gypi:
  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::supplementName):

  • page/Navigator.cpp:

(WebCore::Navigator::provideSupplement):
(WebCore):
(WebCore::Navigator::requireSupplement):

  • page/Navigator.h:

(Navigator):

  • page/Page.h:

(Page):

  • page/PageSupplement.h:
    • This patch cleans up some nits in PageSupplement.

(WebCore):
(PageSupplement):

11:00 PM Changeset in webkit [107535] by rniwa@webkit.org
  • 2 edits in trunk

Another perf-o-matic build fix.

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler._create_build_if_possible):

10:47 PM Changeset in webkit [107534] by bashi@chromium.org
  • 4 edits
    1 move
    3 adds
    1 delete in trunk/LayoutTests

Unreviewed test expectations update after r107516.

  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-multiple-faces-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css/font-face-multiple-faces-expected.png.
  • platform/chromium-mac/fast/css/font-face-default-font-expected.png: Removed.
  • platform/chromium-win/fast/css/font-face-default-font-expected.png:
  • platform/chromium-win/fast/css/font-face-default-font-expected.txt:
10:41 PM Changeset in webkit [107533] by bashi@chromium.org
  • 1 edit
    18 deletes in trunk/LayoutTests

Remove fast/css/font-face-descriptor-multiple-values.html
​https://bugs.webkit.org/show_bug.cgi?id=78456

The test is no longer needed because WebKit now follow the current
draft(*1) and doesn't accept multiple font-weight descriptors.
(*1) ​http://dev.w3.org/csswg/css3-fonts/#descdef-font-weight

Reviewed by Hajime Morita.

  • fast/css/font-face-descriptor-multiple-values.html: Removed.
  • fast/css/resources/font-face-descriptor-multiple-values-parsing.js: Removed.
  • platform/chromium-linux/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
  • platform/chromium-win/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/chromium-win/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
  • platform/chromium-win/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
  • platform/efl/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/efl/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
  • platform/gtk/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/gtk/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
  • platform/mac-leopard/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
  • platform/qt/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
  • platform/qt/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
10:26 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:25 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:21 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:20 PM WebKitIDL edited by haraken@chromium.org
(diff)
10:20 PM Changeset in webkit [107532] by rniwa@webkit.org
  • 2 edits in trunk

Perf-o-matic build fix.

  • Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):

9:45 PM Changeset in webkit [107531] by rniwa@webkit.org
  • 5 edits in trunk

REGRESSION: Perf-o-matic adds duplicated test results
​https://bugs.webkit.org/show_bug.cgi?id=78373

Reviewed by Hajime Morita.

Add TestResult inside a transaction. We use high replication databsae but this should prevent
the duplication in the most of the time.

Also fixed random bugs in Controller and ReportHandler.

  • Websites/webkit-perf.appspot.com/controller.py:

(get_persistent_cache):

  • Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):
(ReportProcessHandler._add_test_if_needed):
(ReportProcessHandler):
(ReportProcessHandler._add_test_result_if_needed):
(ReportProcessHandler._add_test_result_if_needed._float_or_none):
(ReportProcessHandler._add_test_result_if_needed.execute):

9:35 PM Changeset in webkit [107530] by haraken@chromium.org
  • 17 edits in trunk/Source/WebCore

Add a [V8CustomToJSObject] IDL attribute
​https://bugs.webkit.org/show_bug.cgi?id=78450

Reviewed by Adam Barth.

This is the first step to remove hard-coding in HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch adds [V8CustomToJSObject]
to interfaces which have custom toV8() but do not have custom toJS().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm: Replaced hard-coding with [V8CustomToJSObject].

(HasCustomToV8Implementation):

  • css/CSSStyleSheet.idl: Added [V8CustomToJSObject].
  • dom/DOMStringMap.idl:
  • dom/Element.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/canvas/CanvasPixelArray.idl:
  • inspector/ScriptProfile.idl:
  • inspector/ScriptProfileNode.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElement.idl:
  • workers/WorkerContext.idl:
9:26 PM Changeset in webkit [107529] by commit-queue@webkit.org
  • 3 edits
    161 adds in trunk

[EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
​https://bugs.webkit.org/show_bug.cgi?id=78091

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-02-12
Reviewed by Hajime Morita.

Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
This patch will activate around 1,900 test cases from skipped list in EFL port.

Tools:

  • DumpRenderTree/efl/EventSender.cpp:

(textZoom):
(pageZoom):
(textZoomInCallback):
(textZoomOutCallback):
(zoomPageInCallback):
(zoomPageOutCallback):

LayoutTests:

  • platform/efl/fast/css/ignore-text-zoom-expected.txt: Added.
  • platform/efl/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/efl/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/efl/svg/as-background-image/animated-svg-as-background-expected.txt: Added.
  • platform/efl/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
  • platform/efl/svg/as-background-image/background-image-tiled-expected.txt: Added.
  • platform/efl/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-6-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-as-tiled-background-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-background-partial-redraw-expected.txt: Added.
  • platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.txt: Added.
  • platform/efl/svg/as-border-image/svg-as-border-image-2-expected.txt: Added.
  • platform/efl/svg/as-border-image/svg-as-border-image-expected.txt: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-expected.txt: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
  • platform/efl/svg/as-image/same-image-two-instances-expected.txt: Added.
  • platform/efl/svg/as-image/svg-as-image-expected.txt: Added.
  • platform/efl/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
  • platform/efl/svg/as-image/svg-image-change-content-size-expected.txt: Added.
  • platform/efl/svg/batik/filters/feTile-expected.txt: Added.
  • platform/efl/svg/batik/filters/filterRegions-expected.txt: Added.
  • platform/efl/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/efl/svg/batik/paints/gradientLimit-expected.txt: Added.
  • platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
  • platform/efl/svg/batik/paints/patternRegionA-expected.txt: Added.
  • platform/efl/svg/batik/paints/patternRegions-expected.txt: Added.
  • platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/efl/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/efl/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/efl/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/efl/svg/batik/text/textAnchor2-expected.txt: Added.
  • platform/efl/svg/batik/text/textAnchor3-expected.txt: Added.
  • platform/efl/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/efl/svg/batik/text/textDecoration2-expected.txt: Added.
  • platform/efl/svg/batik/text/textEffect-expected.txt: Added.
  • platform/efl/svg/batik/text/textEffect2-expected.txt: Added.
  • platform/efl/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/efl/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
  • platform/efl/svg/batik/text/textLayout-expected.txt: Added.
  • platform/efl/svg/batik/text/textLayout2-expected.txt: Added.
  • platform/efl/svg/batik/text/textLength-expected.txt: Added.
  • platform/efl/svg/batik/text/textOnPath-expected.txt: Added.
  • platform/efl/svg/batik/text/textOnPath2-expected.txt: Added.
  • platform/efl/svg/batik/text/textOnPath3-expected.txt: Added.
  • platform/efl/svg/batik/text/textOnPathSpaces-expected.txt: Added.
  • platform/efl/svg/batik/text/textPCDATA-expected.txt: Added.
  • platform/efl/svg/batik/text/textPosition-expected.txt: Added.
  • platform/efl/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/efl/svg/batik/text/textProperties-expected.txt: Added.
  • platform/efl/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/efl/svg/batik/text/textStyles-expected.txt: Added.
  • platform/efl/svg/batik/text/verticalText-expected.txt: Added.
  • platform/efl/svg/batik/text/verticalTextOnPath-expected.txt: Added.
  • platform/efl/svg/batik/text/xmlSpace-expected.txt: Added.
  • platform/efl/svg/carto.net/button-expected.txt: Added.
  • platform/efl/svg/carto.net/colourpicker-expected.txt: Added.
  • platform/efl/svg/carto.net/combobox-expected.txt: Added.
  • platform/efl/svg/carto.net/scrollbar-expected.txt: Added.
  • platform/efl/svg/carto.net/selectionlist-expected.txt: Added.
  • platform/efl/svg/carto.net/slider-expected.txt: Added.
  • platform/efl/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/efl/svg/carto.net/textbox-expected.txt: Added.
  • platform/efl/svg/carto.net/window-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-in-clip-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-in-mask-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-evenodd-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-nonzero-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-pixelation-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-recursive-call-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-text-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-transform-1-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-with-container-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Added.
  • platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt: Added.
  • platform/efl/svg/clip-path/clipper-placement-issue-expected.txt: Added.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Added.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Added.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Added.
  • platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Added.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Added.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Added.
  • platform/efl/svg/css/arrow-with-shadow-expected.txt: Added.
  • platform/efl/svg/css/clippath-with-shadow-expected.txt: Added.
9:20 PM Applications using WebKit edited by wesley
(diff)
9:18 PM Applications using WebKit edited by wesley
(diff)
9:00 PM Changeset in webkit [107528] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSS3 currentColor on outline-color gets treated as inherit
​https://bugs.webkit.org/show_bug.cgi?id=73180

Patch by David Barr <​davidbarr@chromium.org> on 2012-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

The CSS2 and CSS3 UI modules state that outline-color
is not inherited. Make it so.
​http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color
​http://www.w3.org/TR/css3-ui/#outline-color

Test: fast/css/outline-currentcolor.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

LayoutTests:

Adapted fast/css/background-currentcolor.html dumpRenderTree test
for outline-color.

  • fast/css/outline-currentcolor-expected.txt: Added.
  • fast/css/outline-currentcolor.html: Added.
9:00 PM Changeset in webkit [107527] by commit-queue@webkit.org
  • 5 edits in trunk

KeywordLookupGenerator.py script fails in some cases
​https://bugs.webkit.org/show_bug.cgi?id=77886

Patch by Ashod Nakashian <​ashodnakashian@yahoo.com> on 2012-02-12
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • parser/Keywords.table: Converted to LF-only.

Tools:

  • Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
  • Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.

(GlobalVariablesTest.test_path_rules_specifier):

8:58 PM Changeset in webkit [107526] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

CSSPageRule should inherit from CSSRule instead of CSSStyleRule
​https://bugs.webkit.org/show_bug.cgi?id=78452

Reviewed by Anders Carlsson.

This matches CSSOM and eliminates the only subclass of CSSStyleRule, enabling further refactoring.

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::~CSSPageRule):
(WebCore):
(WebCore::CSSPageRule::selectorText):
(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::cssText):

  • css/CSSPageRule.h:

(CSSPageRule):
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::selector):
(WebCore::CSSPageRule::properties):
(WebCore::CSSPageRule::adoptSelectorVector):
(WebCore::CSSPageRule::setDeclaration):

  • css/CSSRule.cpp:

(WebCore::CSSRule::cssText):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::generateSelectorText):

  • css/CSSStyleSelector.cpp:

(WebCore::RuleSet::pageRules):
(RuleSet):
(WebCore::RuleSet::addPageRule):
(WebCore::comparePageRules):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

8:15 PM Changeset in webkit [107525] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk/Source

Introduce ShadowRootList.
​https://bugs.webkit.org/show_bug.cgi?id=78069

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-12
Reviewed by Hajime Morita.

Source/JavaScriptCore:

DoublyLinkedList should have tail() method to take the last element.

  • wtf/DoublyLinkedList.h:

(DoublyLinkedList):
(WTF::::tail):
(WTF):

Source/WebCore:

This is a step to implement multiple shadow subtrees.

This patch introduces a shadow root list. ShadowRootList is a doubly linked list,
and each shadow root now has a younger shadow root and older shadow root,
which are a previous element and a next element respectively.
Since a visual tree traversal, which will be introduced in coming patches, will need a older shadow root,
we make a shadow root list a doubly linked list.

However, ShadowRootList does not have more than one shadow root now.
This will be changed in a series of coming patches.

Element::shadowRoot(), setShadowRoot(), ensureShadowRoot(), and removeShadowRoot() are
emulated using ShadowRootList for a while. These API will be replaced to ShadowRootList API later.

No new tests, no change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Element.cpp:

(WebCore::Element::hasShadowRoot):

Retruns true if an element has a shadowRoot.

(WebCore::Element::shadowRootList):

Gets shadow root list if any.

(WebCore::Element::shadowRoot):

Gets the first shadow root from the shadow root list.

(WebCore::Element::setShadowRoot):

Sets the first shadow root to the shadow root list.

(WebCore::Element::removeShadowRoot):

Removes all the shadow roots in the shadow root list.

  • dom/Element.h:

(WebCore):
(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):

Has shadow root lists instead of shadow root.

(WebCore::ElementRareData::~ElementRareData):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):

  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::ShadowRoot::youngerShadowRoot):
(WebCore::ShadowRoot::olderShadowRoot):

  • dom/ShadowRootList.cpp: Added.

(WebCore):
(WebCore::ShadowRootList::ShadowRootList):
(WebCore::ShadowRootList::~ShadowRootList):
(WebCore::ShadowRootList::pushShadowRoot):

Adds a shadow root into the list. Currently we limit the list can have only one shadow root.

(WebCore::ShadowRootList::popShadowRoot):

Removes and returns the youngest shadow root if any.

  • dom/ShadowRootList.h: Added.

(WebCore):
(ShadowRootList):
(WebCore::ShadowRootList::hasShadowRoot):
(WebCore::ShadowRootList::youngestShadowRoot):
(WebCore::ShadowRootList::oldestShadowRoot):

7:53 PM Changeset in webkit [107524] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

INPUT shouldn't create ShadowRoot dynamically.
​https://bugs.webkit.org/show_bug.cgi?id=77930

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-12
Reviewed by Dimitri Glazkov.

Source/WebCore:

When input type is changed, ShadowRoot was being re-created. This makes it difficult to
support multiple shadow subtrees. This patch makes input re-use the existing shadow root
instead of re-creating a shaow root. A shadow root should be created when an element is created.

Since media control elements are implemented using input elements, these elements should also
create a shadow root in their construction phase.

Test: fast/dom/shadow/input-shadow-nochange.html
Tests related to media controls should be covered by existing tests.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::createShadowSubtree):

  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):

  • html/shadow/MediaControlElements.cpp: Creates a shadow tree in the construction phase.

(WebCore::MediaControlPanelMuteButtonElement::create):
(WebCore::MediaControlVolumeSliderMuteButtonElement::create):
(WebCore::MediaControlPlayButtonElement::create):
(WebCore::MediaControlSeekForwardButtonElement::create):
(WebCore::MediaControlSeekBackButtonElement::create):
(WebCore::MediaControlRewindButtonElement::create):
(WebCore::MediaControlReturnToRealtimeButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlVolumeSliderElement::create):
(WebCore::MediaControlFullscreenVolumeSliderElement::create):
(WebCore::MediaControlFullscreenButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::create):

LayoutTests:

Ensures cheaging input type does not cause shadow root recreation.

  • fast/dom/shadow/input-shadow-nochange.html: Added.
  • fast/dom/shadow/input-shadow-nochange-expected.txt: Added.
7:35 PM Changeset in webkit [107523] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

SVGTRefElement shouldn't create a shadow root dynamically.
​https://bugs.webkit.org/show_bug.cgi?id=77938

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-12
Reviewed by Hajime Morita.

Source/WebCore:

SVGTRefElement creates a shadow root dynamically. This will cause a problem to support
multiple shadow subtrees. So it should be created in a constructor phase.

Test: svg/custom/tref-shadowdom.html

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::create):
(WebCore::SVGTRefElement::createShadowSubtree):
(WebCore):
(WebCore::SVGTRefElement::updateReferencedText):

  • svg/SVGTRefElement.h:

(SVGTRefElement):

LayoutTests:

Checks a shadow root exists of tref element in cases xlink:href is set and is not set.

  • svg/custom/tref-shadowdom-expected.txt: Added.
  • svg/custom/tref-shadowdom.html: Added.
7:15 PM Changeset in webkit [107522] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add toText and isTextNode helpers in Text class.
​https://bugs.webkit.org/show_bug.cgi?id=78140

Unit test case for the new style checker introduced.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest):
(CppStyleTest.test_static_cast_readability): Added a unit test case.

6:15 PM Changeset in webkit [107521] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Enable features supported by EFL port in build-webkit.
​https://bugs.webkit.org/show_bug.cgi?id=78348

Reviewed by Ryosuke Niwa.

Sync build-webkit with OptionEfl.cmake, as some features enabled in
OptionEfl.cmake are not enabled in build-webkit.

  • Scripts/build-webkit:
6:12 PM Changeset in webkit [107520] by haraken@chromium.org
  • 20 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore):
(WebCore::JSTestActiveDOMObject::destroy):
(WebCore::JSTestActiveDOMObject::~JSTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(JSTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::~JSTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(JSTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore):
(WebCore::JSTestEventConstructor::destroy):
(WebCore::JSTestEventConstructor::~JSTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(JSTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore):
(WebCore::JSTestEventTarget::destroy):
(WebCore::JSTestEventTarget::~JSTestEventTarget):

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(JSTestEventTarget):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):
(WebCore::JSTestInterface::destroy):
(WebCore::JSTestInterface::~JSTestInterface):

  • bindings/scripts/test/JS/JSTestInterface.h:

(JSTestInterface):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore):
(WebCore::JSTestMediaQueryListListener::destroy):
(WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(JSTestMediaQueryListListener):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore):
(WebCore::JSTestNamedConstructor::destroy):
(WebCore::JSTestNamedConstructor::~JSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(JSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::JSTestObj::destroy):
(WebCore::JSTestObj::~JSTestObj):

  • bindings/scripts/test/JS/JSTestObj.h:

(JSTestObj):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::JSTestSerializedScriptValueInterface::destroy):
(WebCore::JSTestSerializedScriptValueInterface::~JSTestSerializedScriptValueInterface):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterface):

5:59 PM Changeset in webkit [107519] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

Regression (r104528): Crash when moving nodes across documents.
​https://bugs.webkit.org/show_bug.cgi?id=78432

Reviewed by Hajime Morita.

Source/WebCore:

Test: fast/dom/node-move-to-new-document-crash-main.html

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

LayoutTests:

  • fast/dom/node-move-to-new-document-crash-main-expected.txt: Added.
  • fast/dom/node-move-to-new-document-crash-main.html: Added.
  • fast/dom/resources/node-move-to-new-document-crash.svg: Added.
5:18 PM Changeset in webkit [107518] by commit-queue@webkit.org
  • 26 edits
    2 copies in trunk/Source

Page should have less intrusive way to associate API implementation objects.
​https://bugs.webkit.org/show_bug.cgi?id=78085

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-02-12
Reviewed by Adam Barth.

Source/WebCore:

Introducing PageSupplement interface to attach behind-the-flag-ish
objects to Page instances.

This change aims to improve modularity of Modules/ entries. With
PageSupplement mechinary, we can eliminate ifdef conditionals from
Page.h/Page.cpp and are able to add Modules/ entries without
touching non-Module WebCore files. WebKit API classes like WebPage
can "provide" these objects dynamically during the Page setup phase.

In this change, DeviceMotionController and
DeviceOrientationController is updated to adopt PageSupplement
inteface for an illustrative purpose because they are going to
move into Modules/ shortly. Other Page associated API backing
objects also should be transformed to PageSupplement family.

Reviewed by Adam Barth.

No new tests. No behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DeviceMotionClient.h:

(WebCore):

  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::supplementName):
(WebCore):
(WebCore::DeviceMotionController::isActiveAt):
(WebCore::provideDeviceMotionTo):

  • dom/DeviceMotionController.h:

(DeviceMotionController):
(WebCore::DeviceMotionController::from):

  • dom/DeviceOrientationClient.h:

(WebCore):

  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::supplementName):
(WebCore):
(WebCore::DeviceOrientationController::isActiveAt):
(WebCore::provideDeviceOrientationTo):

  • dom/DeviceOrientationController.h:

(DeviceOrientationController):
(WebCore::DeviceOrientationController::from):

  • dom/Document.cpp:

(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):

  • history/PageCache.cpp:

(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

  • page/PageSupplement.cpp:

(WebCore::PageSupplement::~PageSupplement):
(WebCore::PageSupplement::provideTo):
(WebCore::PageSupplement::from):

  • page/PageSupplement.h:
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::provideSupplement):
(WebCore):
(WebCore::Page::requireSupplement):
(WebCore::Page::notifyDestroyedToSupplements):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockDeviceOrientation):

5:01 PM Changeset in webkit [107517] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

[chromium/mac] Change the type of webkit_system_interface from static_library to none
​https://bugs.webkit.org/show_bug.cgi?id=78441

This target exists only run an action and to add a dependency to the
action's output to targets depending on webkit_system_interface.
This is what target type 'none' is for. With this, no dummy source
file is needed, and no empty libwebkit_system_interface.a is created.
This also fixes this (harmless) libtool warning:

libtool: warning for library: libwebkit_system_interface.a the table
of contents is empty (no object file members in the library define
global symbols)

Patch by Nico Weber <​nicolasweber@gmx.de> on 2012-02-12
Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/mac/Empty.cpp: Removed.
4:43 PM Changeset in webkit [107516] by bashi@chromium.org
  • 6 edits
    2 adds
    2 deletes in trunk

If @font-face does not provide an explicit italic/bold variant, regular is used.
​https://bugs.webkit.org/show_bug.cgi?id=34147

Reviewed by Dan Bernstein.

Source/WebCore:

Update @font-face handling code so that it matches @font-face behavior to the current draft of CSS3 Font spec. The original patch was written by ​yusukes@chromium.org.

  • Drops support for "bolder", "lighter", and "all" value. These are no longer allowed.
  • Only allows one value for font-style and font-weight.

Tests: fast/css/font-face-synthetic-bold-italic.html

fast/css/font-face-weight-matching.html

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Removed "all", "lighter", "bolder" handling code.
(WebCore::compareFontFaces):Updated the weight matching algortihm.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Replaced parseFontStyle() call with checking primitive values.
(WebCore::CSSParser::parseFontWeight): Changed to allow only primitive values.
(WebCore::CSSParser::createFontFaceRule): Removed checks for font-weight and font-style.
(WebCore::CSSParser::deleteFontFaceOnlyValues): Ditto.

  • css/CSSParser.h: Removed parseFontStyle().

LayoutTests:

Added two tests to make sure font matching algorithm matches the current draft of CSS Fonts Module Level 3, and removed a test which uses obsoleted 'all' value for font-weight and font-style.

  • fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
  • fast/css/font-face-descriptor-multiple-values-parsing.html: Removed.
  • fast/css/font-face-synthetic-bold-italic.html: Added.
  • fast/css/font-face-weight-matching.html: Added.
  • platform/chromium/test_expectations.txt: Needs rebaselines.
4:35 PM Writing Layout Tests for DumpRenderTree edited by pdr@google.com
Add missing parenthesis (diff)
3:53 PM Changeset in webkit [107515] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Avoid unnecessary memset in per-tile layer updater.
​https://bugs.webkit.org/show_bug.cgi?id=78426

Patch by David Reveman <​reveman@chromium.org> on 2012-02-12
Reviewed by Stephen White.

Use our own SkBitmap and call SkBitmap::allocPixels() instead of
letting SkDevice construct a SkBitmap. This avoids an unnecessary
memset otherwise done by SkDevice.

No new tests.

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):

3:51 PM Changeset in webkit [107514] by kubo@profusion.mobi
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Move source files in WTF_HEADERS to WTF_SOURCES.
​https://bugs.webkit.org/show_bug.cgi?id=78436

Reviewed by Daniel Bates.

  • wtf/CMakeLists.txt: Move .cpp files from WTF_HEADERS to WTF_SOURCES,

and correctly sort the files which start with 'M'.

3:35 PM Changeset in webkit [107513] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Move the NumberOfCores.h/cpp files into the WTF group of JavaScriptCore.xcodeproj.

Rubber-stamped by Anders Carlsson.

12:50 PM Changeset in webkit [107512] by kubo@profusion.mobi
  • 4 edits in trunk/Source/JavaScriptCore

[CMake] Remove unused or empty variable definitions.
​https://bugs.webkit.org/show_bug.cgi?id=78437

Reviewed by Daniel Bates.

  • CMakeLists.txt: Remove unused JavaScriptCore_HEADERS definition.
  • shell/CMakeLists.txt: Remove unused JSC_HEADERS definition.
  • wtf/CMakeLists.txt: Remove empty WTF_LIBRARIES definition, it will

be defined later by Platform*.cmake via LIST(APPEND WTF_LIBRARIES).

10:39 AM Changeset in webkit [107511] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening. Update expected files.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
6:14 AM Changeset in webkit [107510] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed. Fix GTK+ build after r107454.

  • configure.ac: Disable Mutation observers build on GTK+ until it

can actually build.

3:27 AM Changeset in webkit [107509] by commit-queue@webkit.org
  • 37 edits in trunk

Add toText and isTextNode helpers in Text class.
​https://bugs.webkit.org/show_bug.cgi?id=78140

Source/WebCore:

Added a new helper function toText() in dom/Text.h which does the type casting operation to Text object.
Modified the code to make use of this helper function.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.

No new tests.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::accessibleNameForNode):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

  • dom/Attr.cpp:

(WebCore::Attr::childrenChanged):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/Node.cpp:

(WebCore::Node::normalize):

  • dom/Position.cpp:

(WebCore::Position::containerText):
(WebCore::Position::leadingWhitespacePosition):

  • dom/Range.cpp:

(WebCore::Range::insertNode):
(WebCore::Range::getBorderAndTextQuads):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::scriptContent):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcShadowTreeStyle):

  • dom/Text.h: Added new helper function toText.

(WebCore::toText): new helper function which does the type casting operation to Text object.
(WebCore):

  • editing/ApplyBlockElementCommand.cpp:

(WebCore::isNewLineAtPosition):
(WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitTextAtEnd):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):
(WebCore::ApplyStyleCommand::joinChildTextNodes):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNodeAt):
(WebCore::CompositeEditCommand::positionOutsideTabSpan):
(WebCore::CompositeEditCommand::canRebalance):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
(WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::removePlaceholderAt):
(WebCore::CompositeEditCommand::cleanupAfterDeletion):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):
(WebCore::DeleteSelectionCommand::fixupWhitespace):

  • editing/Editor.cpp:

(WebCore::Editor::setComposition):

  • editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):

  • editing/htmlediting.cpp:

(WebCore::lineBreakExistsAtPosition):

  • editing/visible_units.cpp:

(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • html/HTMLElement.cpp:

(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
(WebCore::mergeWithNextTextNode):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasFallbackContent):
(WebCore::HTMLObjectElement::updateDocNamedItem):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setText):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultValue):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::text):
(WebCore::HTMLTitleElement::setText):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setNodeValue):

  • rendering/RenderText.cpp:

(WebCore::RenderText::originalText):

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::originalText):
(WebCore::RenderTextFragment::previousCharacter):

Tools:

Added a style checker to use toText rather than static_cast<Text*>.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_language): Style checker for static_cast<Text*>.

3:16 AM Changeset in webkit [107508] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove [CPPCustom] from CodeGeneratorCPP.pm
​https://bugs.webkit.org/show_bug.cgi?id=78342

Reviewed by Adam Barth.

This patch removes [CPPCustom].

[CPPCustom] has been used in DOMWindow.location only to indicate that
DOMWindow.location should be ignored in CPP. However, there are many
other attributes and methods that CPP does not support (e.g. [CallWith=...],
[CustomSetter], etc), and they are not yet marked with [CPPCustom].
CPP just generates "meaningless" code for those unsupported attributes
and methods. Ideally we can mark all unsupported attributes and methods
with [CPPCustom], but it would not be so practical. Otherwise, removing
[CPPCustom] would make sense. The side effect of removing [CPPCustom]
is just that CPP will generate "meaningless" code for DOMWindow.location.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(ShouldSkipType):

  • page/DOMWindow.idl:
2:53 AM Changeset in webkit [107507] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, rebaseline after r107483 and r107498.

  • fast/dom/wrapper-classes-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
2:41 AM Changeset in webkit [107506] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Rename [JSCustomPrototypeDefineOwnProperty] to [JSCustomDefineOwnPropertyOnPrototype]
​https://bugs.webkit.org/show_bug.cgi?id=78354

Reviewed by Adam Barth.

This patch renames [JSCustomPrototypeDefineOwnProperty] to
[JSCustomDefineOwnPropertyOnPrototype], for naming consistency with
[JSCustomDefineOwnProperty] and [JSCustomNamedGetterOnPrototype].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • page/Location.idl:
2:23 AM Changeset in webkit [107505] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip mutation tests on GTK again after r107504.

  • platform/gtk/Skipped:
2:13 AM Changeset in webkit [107504] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, disable Mutation observers build on GTK until it can
actually build.

  • Scripts/build-webkit:

Feb 11, 2012:

11:59 PM Changeset in webkit [107503] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG::SpeculativeJIT calls fprintf() instead of dataLog in terminateSpeculativeExecution()
​https://bugs.webkit.org/show_bug.cgi?id=78431

Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

10:32 PM Changeset in webkit [107502] by benjamin@webkit.org
  • 5 edits
    14 adds in trunk

Add back WTFURL to WebKit
​https://bugs.webkit.org/show_bug.cgi?id=77291

Reviewed by Adam Barth.

Source/JavaScriptCore:

WTFURL was removed from WebKit in r86787.

This patch adds the code back to WTF with the following changes:
-Guard the feature with USE(WTFURL).
-Change the typename CHAR to CharacterType to follow recent WebKit conventions.
-Fix some coding style to make check-webkit-style happy.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Platform.h:
  • wtf/url/api/ParsedURL.cpp: Added.

(WTF):
(WTF::ParsedURL::ParsedURL):
(WTF::ParsedURL::scheme):
(WTF::ParsedURL::username):
(WTF::ParsedURL::password):
(WTF::ParsedURL::host):
(WTF::ParsedURL::port):
(WTF::ParsedURL::path):
(WTF::ParsedURL::query):
(WTF::ParsedURL::fragment):
(WTF::ParsedURL::segment):

  • wtf/url/api/ParsedURL.h: Added.

(WTF):
(ParsedURL):
(WTF::ParsedURL::spec):

  • wtf/url/api/URLString.h: Added.

(WTF):
(URLString):
(WTF::URLString::URLString):
(WTF::URLString::string):

  • wtf/url/src/RawURLBuffer.h: Added.

(WTF):
(RawURLBuffer):
(WTF::RawURLBuffer::RawURLBuffer):
(WTF::RawURLBuffer::~RawURLBuffer):
(WTF::RawURLBuffer::resize):

  • wtf/url/src/URLBuffer.h: Added.

(WTF):
(URLBuffer):
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):

  • wtf/url/src/URLCharacterTypes.cpp: Added.

(WTF):
():

  • wtf/url/src/URLCharacterTypes.h: Added.

(WTF):
(URLCharacterTypes):
(WTF::URLCharacterTypes::isQueryChar):
(WTF::URLCharacterTypes::isIPv4Char):
(WTF::URLCharacterTypes::isHexChar):
():
(WTF::URLCharacterTypes::isCharOfType):

  • wtf/url/src/URLComponent.h: Added.

(WTF):
(URLComponent):
(WTF::URLComponent::URLComponent):
(WTF::URLComponent::fromRange):
(WTF::URLComponent::isValid):
(WTF::URLComponent::isNonEmpty):
(WTF::URLComponent::isEmptyOrInvalid):
(WTF::URLComponent::reset):
(WTF::URLComponent::operator==):
(WTF::URLComponent::begin):
(WTF::URLComponent::setBegin):
(WTF::URLComponent::length):
(WTF::URLComponent::setLength):
(WTF::URLComponent::end):

  • wtf/url/src/URLEscape.cpp: Added.

(WTF):
():

  • wtf/url/src/URLEscape.h: Added.

(WTF):
(WTF::appendURLEscapedCharacter):

  • wtf/url/src/URLParser.h: Added.

(WTF):
(URLParser):
():
(WTF::URLParser::isPossibleAuthorityTerminator):
(WTF::URLParser::parseAuthority):
(WTF::URLParser::extractScheme):
(WTF::URLParser::parseAfterScheme):
(WTF::URLParser::parseStandardURL):
(WTF::URLParser::parsePath):
(WTF::URLParser::parsePathURL):
(WTF::URLParser::parseMailtoURL):
(WTF::URLParser::parsePort):
(WTF::URLParser::extractFileName):
(WTF::URLParser::extractQueryKeyValue):
(WTF::URLParser::isURLSlash):
(WTF::URLParser::shouldTrimFromURL):
(WTF::URLParser::trimURL):
(WTF::URLParser::consecutiveSlashes):
(WTF::URLParser::isPortDigit):
(WTF::URLParser::nextAuthorityTerminator):
(WTF::URLParser::parseUserInfo):
(WTF::URLParser::parseServerInfo):

  • wtf/url/src/URLQueryCanonicalizer.h: Added.

(WTF):
(URLQueryCanonicalizer):
(WTF::URLQueryCanonicalizer::canonicalize):
(WTF::URLQueryCanonicalizer::isAllASCII):
(WTF::URLQueryCanonicalizer::isRaw8Bit):
(WTF::URLQueryCanonicalizer::appendRaw8BitQueryString):
(WTF::URLQueryCanonicalizer::convertToQueryEncoding):

  • wtf/url/src/URLSegments.cpp: Added.

(WTF):
(WTF::URLSegments::length):
(WTF::URLSegments::charactersBefore):

  • wtf/url/src/URLSegments.h: Added.

(WTF):
(URLSegments):
():
(WTF::URLSegments::URLSegments):

Tools:

Add a flag to build-webkit to easily build WebKit with WTFURL.

  • Scripts/build-webkit:
7:54 PM Changeset in webkit [107501] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Old JIT put_by_id profiling counts every put_by_id_transition as taking slow path
​https://bugs.webkit.org/show_bug.cgi?id=78430
<rdar://problem/10849469> <rdar://problem/10849684>

Reviewed by Gavin Barraclough.

The old JIT's put_by_id transition caching involves repatching the slow call to
a generated stub. That means that the call is counted as "slow case". So, this
patch inserts code to decrement the slow case count if the stub succeeds.

Looks like a ~1% speed-up on V8.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

7:38 PM Changeset in webkit [107500] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for Qt.

  • wtf/DataLog.h:
7:21 PM Changeset in webkit [107499] by fpizlo@apple.com
  • 50 edits
    3 adds in trunk/Source

It should be possible to send all JSC debug logging to a file
​https://bugs.webkit.org/show_bug.cgi?id=78418

Reviewed by Sam Weinig.

Introduced wtf/DataLog, which defines WTF::dataFile, WTF::dataLog,
and WTF::dataLogV. Changed all debugging- and profiling-related printfs
to use WTF::dataLog() or one of its friends. By default, debug logging
goes to stderr, unless you change the setting in wtf/DataLog.cpp.

Source/JavaScriptCore:

(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::vprintfStdoutInstr):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::tallyFrequentExitSites):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/Opcode.cpp:

(JSC::OpcodeStats::~OpcodeStats):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingFlags::stop):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingTool::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCommon.h:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::eliminate):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::Propagator::performBlockCFA):
(JSC::DFG::Propagator::performForwardCFA):

  • dfg/DFGRegisterBank.h:

(JSC::DFG::RegisterBank::dump):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::dump):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

  • heap/Heap.cpp:

(JSC::Heap::destroy):

  • heap/MarkedBlock.h:
  • interpreter/CallFrame.cpp:

(JSC::CallFrame::dumpCaller):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • profiler/Profile.cpp:

(JSC::Profile::debugPrintData):
(JSC::Profile::debugPrintDataSampleStyle):

  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::dumpRegExpTrace):

  • runtime/RegExp.cpp:

(JSC::RegExp::matchCompareWithInterpreter):

  • runtime/SamplingCounter.cpp:

(JSC::AbstractSamplingCounter::dump):

  • runtime/SamplingCounter.h:

(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::print):

  • runtime/Structure.cpp:

(JSC::Structure::dumpStatistics):
(JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):

  • tools/CodeProfile.cpp:

(JSC::CodeProfile::report):

  • tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::dumpInternal):

  • wtf/CMakeLists.txt:
  • wtf/DataLog.cpp: Added.

(WTF):
(WTF::initializeLogFileOnce):
(WTF::initializeLogFile):
(WTF::dataFile):
(WTF::dataLogV):
(WTF::dataLog):

  • wtf/DataLog.h: Added.

(WTF):

  • wtf/HashTable.cpp:

(WTF::HashTableStats::~HashTableStats):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::dumpProfile):

  • wtf/text/WTFString.cpp:

(String::show):

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::dumpDisjunction):

Source/WebCore:

No new tests because behavior is unchanged.

  • ForwardingHeaders/wtf/DataLog.h: Added.

Source/WTF:

  • WTF.pro:
6:47 PM Changeset in webkit [107498] by barraclough@apple.com
  • 29 edits in trunk

Move special proto property to Object.prototype
​https://bugs.webkit.org/show_bug.cgi?id=78409

Reviewed by Oliver Hunt.

Re-implement this as a regular accessor property. This has three key benefits:
1) It makes it possible for objects to be given properties named proto.
2) Object.prototype.proto can be deleted, preventing object prototypes from being changed.
3) This largely removes the magic used the implement proto, it can just be made a regular accessor property.

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::::parseFunctionInfo):

  • No need to prohibit functions named proto.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • Add proto accessor to Object.prototype.
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):

  • Definition of the proto accessor functions.
  • runtime/JSGlobalObjectFunctions.h:
    • Declaration of the proto accessor functions.
  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • Remove the special handling for proto, there is still a check to allow for a fast guard for accessors excluding proto.

(JSC::JSObject::putDirectAccessor):

  • Track on the structure whether an object contains accessors other than one for proto.

(JSC::JSObject::defineOwnProperty):

  • No need to prohibit definition of own properties named proto.
  • runtime/JSObject.h:

(JSC::JSObject::inlineGetOwnPropertySlot):

  • Remove the special handling for proto.

(JSC::JSValue::get):

  • Remove the special handling for proto.
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

  • Remove the special handling for proto.
  • runtime/JSValue.h:

(JSValue):

  • Made synthesizePrototype public (this may be needed by the proto getter).
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

  • Perform the security check & call prototype() directly.
  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
  • runtime/Structure.h:

(JSC::Structure::hasGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(Structure):

  • Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.

Source/WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore):

  • expose allowsAccessFrom check to JSC.
  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

  • expose allowsAccessFrom check to JSC.

LayoutTests:

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/cyclic-prototypes-expected.txt:
  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/preventExtensions-expected.txt:
  • fast/js/prototypes-expected.txt:
    • Update results
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
    • proto is now a property of Object Prototype.
  • fast/js/script-tests/cyclic-prototypes.js:
    • setting an object's prototype to null removes proto setter, future usage won't set prototype.
  • fast/js/script-tests/parser-syntax-check.js:
    • Allow functions named proto
  • fast/js/script-tests/preventExtensions.js:
    • Setting proto should not throw.
  • fast/js/script-tests/prototypes.js:
    • Objects may contained own properties named proto, add new test cases.
6:33 PM Changeset in webkit [107497] by benjamin@webkit.org
  • 6 edits
    1 delete in trunk/Source/WebCore

Get rid of WebCore::URLString
​https://bugs.webkit.org/show_bug.cgi?id=78429

Reviewed by Adam Barth.

URLString is unused, remove the class.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.cpp:
  • platform/KURL.h:

(KURL):

  • platform/URLString.h: Removed.
6:26 PM Changeset in webkit [107496] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG CFA assumes that a WeakJSConstant's structure is known
​https://bugs.webkit.org/show_bug.cgi?id=78428
<rdar://problem/10849492> <rdar://problem/10849621>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

LayoutTests:

Rubber stamped by Gavin Barraclough.

  • fast/js/dfg-put-by-id-prototype-check-expected.txt: Added.
  • fast/js/dfg-put-by-id-prototype-check.html: Added.
  • fast/js/script-tests/dfg-put-by-id-prototype-check.js: Added.

(foo):
(Foo):

5:27 PM Changeset in webkit [107495] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Qt debug build fix

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor): Platforms that don't use clang will allocate
JSFinalObjects in the destuctor subspace, so we should remove this assert so it
doesn't cause crashes.

5:24 PM Changeset in webkit [107494] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Old 32_64 JIT should assert that its use of map() is consistent with the DFG
OSR exit's expectations
​https://bugs.webkit.org/show_bug.cgi?id=78419
<rdar://problem/10817121>

Reviewed by Oliver Hunt.

  • jit/JITInlineMethods.h:

(JSC::JIT::map):

5:18 PM Changeset in webkit [107493] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Reduce the reentrancy limit of the interpreter for the iOS simulator
​https://bugs.webkit.org/show_bug.cgi?id=78400

Reviewed by Gavin Barraclough.

  • interpreter/Interpreter.h: Lowered the maximum reentrancy limit for large thread stacks.

(JSC):

4:08 PM Changeset in webkit [107492] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

[DFG] Misuse of WeakJSConstants in silentFillGPR code.
​https://bugs.webkit.org/show_bug.cgi?id=78423
<rdar://problem/10849353> <rdar://problem/10804043>

Source/JavaScriptCore:

Reviewed by Sam Weinig.

The code was using Node::isConstant(), when it was supposed to use Node::hasConstant().
This patch is a surgical fix; the bigger problem is: why do we have isConstant() and
hasConstant() when hasConstant() is correct and isConstant() is almost always wrong?

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentFillGPR):

LayoutTests:

Rubber stamped by Sam Weinig.

  • fast/js/dfg-weak-js-constant-silent-fill.html: Added.
  • fast/js/dfg-weak-js-constant-silent-fill-expected.txt: Added.
  • fast/js/script-tests/dfg-weak-js-constant-silent-fill.js: Added.
3:58 PM Changeset in webkit [107491] by weinig@apple.com
  • 11 edits in trunk/Source/WebCore

Fix the windows build.

Since Windows uses an all-in-one file to compile, the isRespectedPresentationAttribute()
functions all need unique names.

  • html/HTMLBodyElement.cpp:
  • html/HTMLHRElement.cpp:
  • html/HTMLIFrameElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLInputElement.cpp:
  • html/HTMLMarqueeElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLTableCellElement.cpp:
  • html/HTMLTablePartElement.cpp:
  • mathml/MathMLElement.cpp:
3:36 PM Changeset in webkit [107490] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Overlay scrollbars don't appear when scrolling on the scrolling thread
​https://bugs.webkit.org/show_bug.cgi?id=78427

Reviewed by Sam Weinig.

Add a ScrollAnimator::notifyContentAreaScrolled and call it from ScrollAnimator::notifyContentAreaScrolled.
It is then overridden in ScrollAnimatorMac to tickle AppKit so that overlay scrollbars will be shown.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::notifyContentAreaScrolled):
(ScrollAnimator):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::notifyScrollPositionChanged):

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore):

3:10 PM Changeset in webkit [107489] by weinig@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Prepare JavaScriptCore to build with libc++
<rdar://problem/10426673>
​https://bugs.webkit.org/show_bug.cgi?id=78424

Reviewed by Anders Carlsson.

  • wtf/NullPtr.cpp:
  • wtf/NullPtr.h:

libc++ provides std::nullptr emulation, so we don't have to.

3:02 PM Changeset in webkit [107488] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Implement more ScrollElasticityControllerClient member functions
​https://bugs.webkit.org/show_bug.cgi?id=78425
<rdar://problem/10710727>

Reviewed by Sam Weinig.

  • page/scrolling/ScrollingTreeNode.h:

(ScrollingTreeNode):
(WebCore::ScrollingTreeNode::horizontalScrollElasticity):
(WebCore::ScrollingTreeNode::verticalScrollElasticity):
(WebCore::ScrollingTreeNode::hasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeNode::hasEnabledVerticalScrollbar):
Add new getters.

  • page/scrolling/mac/ScrollingTreeNodeMac.h:
  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::allowsHorizontalStretching):
(WebCore::ScrollingTreeNodeMac::allowsVerticalStretching):
(WebCore::ScrollingTreeNodeMac::stretchAmount):
(WebCore::ScrollingTreeNodeMac::pinnedInDirection):
(WebCore::ScrollingTreeNodeMac::canScrollHorizontally):
(WebCore::ScrollingTreeNodeMac::canScrollVertically):
(WebCore::ScrollingTreeNodeMac::absoluteScrollPosition):
(WebCore::ScrollingTreeNodeMac::immediateScrollByWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::startSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::stopSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::scrollByWithoutContentEdgeConstraints):
Implement ScrollElasticityControllerClient member functions.

1:44 PM Changeset in webkit [107487] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Add size assert for Length
​https://bugs.webkit.org/show_bug.cgi?id=78420

Rubber-stamped by Andreas Kling.

Length type is memory critical and must not grow.

  • platform/Length.cpp:

(SameSizeAsLength):
(WebCore):

1:37 PM Changeset in webkit [107486] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Pass wheel events to a scroll elasticity controller on the scrolling thread
​https://bugs.webkit.org/show_bug.cgi?id=78421

Reviewed by Sam Weinig.

Add a ScrollElasticityController to ScrollingTreeNodeMac and pass wheel events to it.
Fix ScrollingTreeNodeMac::scrollBy to clamp by the minimum and maximum scroll positions.

  • page/scrolling/mac/ScrollingTreeNodeMac.h:

(ScrollingTreeNodeMac):

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::ScrollingTreeNodeMac):
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
(WebCore::ScrollingTreeNodeMac::immediateScrollBy):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeNodeMac::minimumScrollPosition):
(WebCore):
(WebCore::ScrollingTreeNodeMac::maximumScrollPosition):
(WebCore::ScrollingTreeNodeMac::scrollBy):

1:07 PM Changeset in webkit [107485] by fpizlo@apple.com
  • 13 edits
    3 adds in trunk/Source/JavaScriptCore

DFG should have polymorphic put_by_id caching
​https://bugs.webkit.org/show_bug.cgi?id=78062
<rdar://problem/10326439> <rdar://problem/10824839>

Reviewed by Oliver Hunt.

Implemented polymorphic put_by_id caching in the DFG, and added much of the
machinery that would be needed to implement it in the old JIT as well.

I decided against using the old PolymorphicAccessStructureList mechanism as
this didn't quite fit with put_by_id. In particular, I wanted the ability to
have one list that captured all relevant cases (including proto put_by_id
if we ever decided to do it). And I wanted the code to have better
encapsulation. And I didn't want to get confused by the fact that the
original (non-list) put_by_id cache may itself consist of a stub routine.

This code is still sub-optimal (for example adding a replace to a list whose
previous elements are all transitions should just repatch the original code,
but here it will generate a stub) but it already generates a >20% speed-up
on V8-splay, leading to a 2% win overall in splay. Neutral elsewhere.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/PolymorphicPutByIdList.cpp: Added.

(JSC):
(JSC::PutByIdAccess::fromStructureStubInfo):
(JSC::PutByIdAccess::visitWeak):
(JSC::PolymorphicPutByIdList::PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::from):
(JSC::PolymorphicPutByIdList::~PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::isFull):
(JSC::PolymorphicPutByIdList::isAlmostFull):
(JSC::PolymorphicPutByIdList::addAccess):
(JSC::PolymorphicPutByIdList::visitWeak):

  • bytecode/PolymorphicPutByIdList.h: Added.

(JSC):
(PutByIdAccess):
(JSC::PutByIdAccess::PutByIdAccess):
(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::replace):
(JSC::PutByIdAccess::isSet):
(JSC::PutByIdAccess::operator!):
(JSC::PutByIdAccess::type):
(JSC::PutByIdAccess::isTransition):
(JSC::PutByIdAccess::isReplace):
(JSC::PutByIdAccess::oldStructure):
(JSC::PutByIdAccess::structure):
(JSC::PutByIdAccess::newStructure):
(JSC::PutByIdAccess::chain):
(JSC::PutByIdAccess::stubRoutine):
(PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::currentSlowPathTarget):
(JSC::PolymorphicPutByIdList::isEmpty):
(JSC::PolymorphicPutByIdList::size):
(JSC::PolymorphicPutByIdList::at):
(JSC::PolymorphicPutByIdList::operator[]):
(JSC::PolymorphicPutByIdList::kind):

  • bytecode/PutKind.h: Added.

(JSC):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):

  • bytecode/StructureStubInfo.h:

(JSC):
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::initPutByIdList):
(StructureStubInfo):
(JSC::StructureStubInfo::reset):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:

(DFG):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::appropriateGenericPutByIdFunction):
(JSC::DFG::appropriateListBuildingPutByIdFunction):
(DFG):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::dfgRepatchPutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::dfgBuildPutByIdList):
(JSC::DFG::dfgResetPutByID):

  • dfg/DFGRepatch.h:

(DFG):

  • runtime/WriteBarrier.h:

(WriteBarrierBase):
(JSC::WriteBarrierBase::copyFrom):

11:29 AM Changeset in webkit [107484] by kling@webkit.org
  • 67 edits in trunk/Source/WebCore

Attribute styles should be created lazily.
<​http://webkit.org/b/78381>

Reviewed by Antti Koivisto.

TL;DR summary: Lazily construct the StyledElement::attributeStyle() instead of
moving properties in/out of it in parseAttribute(). This allows us to enable
the matched declaration cache for elements with presentation attributes.

The matched declaration cache has been disabled for elements with presentation
attributes because attributeStyle() was mutable, and (simply put) the cache maps
a set of StylePropertySet pointers to a resulting RenderStyle. This requires
that the StylePropertySets are immutable.

To make them immutable, we now construct the attribute style lazily by adding
a flag (to Node) that gets set in parseAttribute() when a presentation attribute
respected by the element changes. A subsequent call to attributeStyle() checks
the flag and rebuilds the style by looping over the attributes and calling the
new virtual StyledElement::collectStyleForAttribute() on each one. Any dangling
references to the previous attribute style will be garbage collected by the
cache in CSSStyleSelector::sweepMatchedDeclarationCache().

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

Enable matched declaration cache for elements with attribute style.

  • dom/Node.h:

(WebCore::Node::attributeStyleDirty):
(WebCore::Node::setAttributeStyleDirty):
(WebCore::Node::clearAttributeStyleDirty):

Add a Node flag to signify that a presentation attribute has changed and
the attribute style needs to be rebuilt.

  • dom/ElementAttributeData.h:
  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::setAttributeStyle):

Added a setter for the attribute style, called by updateAttributeStyle().

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addHTMLLengthToStyle):
(WebCore::StyledElement::addHTMLColorToStyle):

Moved and renamed two of the old addCSS* helpers from StyledElement.

(WebCore::StyledElement::updateAttributeStyle):

Called by attributeStyle() in case the "attribute style dirty" flag is
set. Rebuilds the attribute style from scratch by looping over the
attribute map and calling collectStyleForAttribute() on each attribute.

  • dom/StyledElement.h:

(WebCore::StyledElement::collectStyleForAttribute):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::setNeedsAttributeStyleUpdate):

Helper, sets the attribute style dirty flag and marks the element for
full style recalc. This is what parseAttribute() calls in subclasses
when they encounter a presentation attribute.

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::collectStyleForAttribute):
(WebCore::HTMLBRElement::parseAttribute):

  • html/HTMLBRElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLBodyElement::collectStyleForAttribute):
(WebCore::HTMLBodyElement::parseAttribute):

  • html/HTMLBodyElement.h:
  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::collectStyleForAttribute):
(WebCore::HTMLDivElement::parseAttribute):

  • html/HTMLDivElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForAttribute):
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):

  • html/HTMLElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::collectStyleForAttribute):
(WebCore::HTMLEmbedElement::parseAttribute):

  • html/HTMLEmbedElement.h:
  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):
(WebCore::HTMLFontElement::parseAttribute):

  • html/HTMLFontElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::collectStyleForAttribute):
(WebCore::HTMLFrameSetElement::parseAttribute):

  • html/HTMLFrameSetElement.h:
  • html/HTMLHRElement.cpp:

(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLHRElement::collectStyleForAttribute):
(WebCore::HTMLHRElement::parseAttribute):

  • html/HTMLHRElement.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::collectStyleForAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):

  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLImageElement::collectStyleForAttribute):
(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLInputElement::collectStyleForAttribute):
(WebCore::HTMLInputElement::parseAttribute):

  • html/HTMLInputElement.h:
  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::collectStyleForAttribute):
(WebCore::HTMLLIElement::parseAttribute):

  • html/HTMLLIElement.h:
  • html/HTMLMarqueeElement.cpp:

(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLMarqueeElement::collectStyleForAttribute):
(WebCore::HTMLMarqueeElement::parseAttribute):

  • html/HTMLMarqueeElement.h:
  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::collectStyleForAttribute):
(WebCore::HTMLOListElement::parseAttribute):

  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::collectStyleForAttribute):
(WebCore::HTMLObjectElement::parseAttribute):

  • html/HTMLObjectElement.h:
  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::collectStyleForAttribute):
(WebCore::HTMLParagraphElement::parseAttribute):

  • html/HTMLParagraphElement.h:
  • html/HTMLPlugInElement.cpp:

(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLPlugInElement::collectStyleForAttribute):
(WebCore::HTMLPlugInElement::parseAttribute):

  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.cpp:

(WebCore::HTMLPreElement::collectStyleForAttribute):
(WebCore::HTMLPreElement::parseAttribute):

  • html/HTMLPreElement.h:
  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):
(WebCore::HTMLTableCaptionElement::parseAttribute):

  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.cpp:

(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLTableCellElement::collectStyleForAttribute):
(WebCore::HTMLTableCellElement::parseAttribute):

  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::collectStyleForAttribute):
(WebCore::HTMLTableColElement::parseAttribute):

  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::getBordersFromFrameAttributeValue):
(WebCore::HTMLTableElement::collectStyleForAttribute):
(WebCore::HTMLTableElement::parseAttribute):

  • html/HTMLTableElement.h:
  • html/HTMLTablePartElement.cpp:

(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLTablePartElement::collectStyleForAttribute):
(WebCore::HTMLTablePartElement::parseAttribute):

  • html/HTMLTablePartElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::collectStyleForAttribute):
(WebCore::HTMLTextAreaElement::parseAttribute):

  • html/HTMLTextAreaElement.h:
  • html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::collectStyleForAttribute):
(WebCore::HTMLUListElement::parseAttribute):

  • html/HTMLUListElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::collectStyleForAttribute):
(WebCore::HTMLVideoElement::parseAttribute):

  • html/HTMLVideoElement.h:
  • mathml/MathMLElement.cpp:

(WebCore::isRespectedPresentationAttribute):
(WebCore::MathMLElement::collectStyleForAttribute):
(WebCore::MathMLElement::parseAttribute):

  • mathml/MathMLElement.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::collectStyleForAttribute):
(WebCore::SVGImageElement::parseAttribute):

  • svg/SVGImageElement.h:
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::collectStyleForAttribute):
(WebCore::SVGStyledElement::parseAttribute):

  • svg/SVGStyledElement.h:
  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::collectStyleForAttribute):
(WebCore::SVGTextContentElement::parseAttribute):

  • svg/SVGTextContentElement.h:

Split handling of presentation attributes between parseAttribute() and
collectStyleForAttribute() as appropriate. Some minor refactorings here and
there (mostly in HTMLTableElement) to avoid excessive code duplication.
Also sprinkled FIXMEs about inefficiencies we should clean up.

10:51 AM Changeset in webkit [107483] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

HTML 5: Support click() method on HTMLElement.
​https://bugs.webkit.org/show_bug.cgi?id=27880

Patch by Arko Saha <​arko@motorola.com> on 2012-02-11
Reviewed by Timothy Hatcher.

Source/WebCore:

Test: fast/dom/click-method-on-html-element.html

  • bindings/objc/PublicDOMInterfaces.h: Added click() method in DOMHTMLElement

with availability macro AVAILABLE_AFTER_WEBKIT_VERSION_5_1.

  • html/HTMLButtonElement.idl: Moved click() method under LANGUAGE_OBJECTIVE_C.
  • html/HTMLElement.idl: Added click() IDL method.
  • html/HTMLInputElement.idl: Moved click() method under LANGUAGE_OBJECTIVE_C.

LayoutTests:

  • fast/dom/click-method-on-html-element-expected.txt: Added.
  • fast/dom/click-method-on-html-element.html: Added.
10:36 AM Changeset in webkit [107482] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] html5test.com says that gstreamer ports do not support WebM for audio
​https://bugs.webkit.org/show_bug.cgi?id=78244

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-11
Reviewed by Eric Seidel.

Specifically advertise support for audio/webm when we support the vorbis
audio codec. This is necessary because gstreamer doesn't advertise it.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::mimeTypeCache): Add an override for audio/webm.

10:18 AM Changeset in webkit [107481] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Windows build.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::scrollToRevealSelection):

9:46 AM Changeset in webkit [107480] by senorblanco@chromium.org
  • 12 edits
    2 adds in trunk/Source/WebCore

[chromium] Enable CSS filters on composited layers.
​https://bugs.webkit.org/show_bug.cgi?id=77266

Reviewed by James Robinson.

Will be covered by existing tests in css3/filters (when enabled).

  • WebCore.gypi:

Add CCRenderSurfaceFilters.* to the Chromium build.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setFilters):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

Override setFilters() virtual from GraphicsLayer.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setFilters):
Implement setFilters() to cache the filters here...
(WebCore::LayerChromium::pushPropertiesTo):
... and push them to the CCLayerImpl at commit time.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::filters):
Implement accessor.

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::setFilters):
Implement stub version of setFilters(), to satisfy the templates.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setFilters):
Implement setter to receive filters at commit time.

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::filters):
Implement member var and accessor for filters.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):
Add another clause here to force creation of a RenderSurface when
filters are present, and to forward them from the layer to the
RenderSurface.

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::drawLayer):
Check for filters at draw time, apply them, and forward the result
through the drawing traversal.
(WebCore::CCRenderSurface::drawSurface):
If filter bitmap is present, bind it instead of the normal
RenderSurface texture.
(WebCore::CCRenderSurface::applyFilters):
Apply filters to the render surface texture, and return the result.
This function is a no-op for the threaded compositor, due to use
of the SharedGraphicsContext3D.

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::setFilters):
(WebCore::CCRenderSurface::filters):
(CCRenderSurface):
Filters getters and setters.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp: Added.

(WebCore::CCRenderSurfaceFilters::apply):
External interface for this (static) class. All internal
implementation and helper functions are in the unnamed namespace.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.h: Added.
8:17 AM Changeset in webkit [107479] by kling@webkit.org
  • 3 edits
    2 adds in trunk

Node.isEqualNode() compares attributes twice.
<​http://webkit.org/b/78414>

Reviewed by Anders Carlsson.

Source/WebCore:

A single pass across the attribute maps should be enough for anyone.

Added a test verifying correct behavior of Node.isEqualNode() when comparing
two elements, one of which has had attributes that were all removed,
resulting in an empty but non-null NamedNodeMap hanging off of the element.
Note that this change is not fixing a regression, I'm just adding the test
since I came close to introducing a bug here.

Test: fast/dom/isEqualNode-after-removeAttribute.html

  • dom/Node.cpp:

(WebCore::Node::isEqualNode):

LayoutTests:

  • fast/dom/isEqualNode-after-removeAttribute-expected.txt: Added.
  • fast/dom/isEqualNode-after-removeAttribute.html: Added.
6:54 AM Changeset in webkit [107478] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

HTMLTablePartElement: Add helper method to find parent table.
<​http://webkit.org/b/78413>

Reviewed by Anders Carlsson.

Add HTMLTablePartElement::findParentTable() and use that in subclasses instead
of duplicating the code.

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::additionalAttributeStyle):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::additionalAttributeStyle):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::findParentTable):
(WebCore):

  • html/HTMLTablePartElement.h:

(WebCore):
(HTMLTablePartElement):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalAttributeStyle):

6:50 AM Changeset in webkit [107477] by kling@webkit.org
  • 22 edits in trunk/Source/WebCore

Use Element's hasName/hasID flags to avoid unnecessary work when looking up name/id attributes.
<​http://webkit.org/b/77845>

Reviewed by Anders Carlsson.

Have Element::getIdAttribute() check the hasID() flag before looking up the attribute.
Add an Element::getNameAttribute() to do the same thing with hasName().
Update call sites to make use of these helpers whenever possible.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityDescription):

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesId):

  • dom/Element.h:

(Element):
(WebCore::Element::getIdAttribute):
(WebCore):
(WebCore::Element::getNameAttribute):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::nodeMatches):

  • dom/StaticHashSetNodeList.cpp:

(WebCore::StaticHashSetNodeList::itemWithName):

  • dom/StaticNodeList.cpp:

(WebCore::StaticNodeList::itemWithName):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::name):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::createRenderer):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::updateNameCache):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::formControlName):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::name):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::name):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::formControlName):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • page/Frame.cpp:

(WebCore::Frame::matchLabelsAgainstElement):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::getElementById):

12:56 AM Changeset in webkit [107476] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening.

  • platform/qt/Skipped: Skip tests because ENABLE(MUTATION_OBSERVERS) is disabled.
12:33 AM Changeset in webkit [107475] by Csaba Osztrogonác
  • 14 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r107435.
​http://trac.webkit.org/changeset/107435
​https://bugs.webkit.org/show_bug.cgi?id=78410

It broke the Qt build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-11

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/mac/EditorMac.mm:

(WebCore::Editor::writeSelectionToPasteboard):

  • platform/Pasteboard.h:

(WebCore):
(Pasteboard):

  • platform/PasteboardStrategy.h: Removed.
  • platform/PlatformPasteboard.h: Removed.
  • platform/PlatformStrategies.h:

(WebCore):
(WebCore::PlatformStrategies::PlatformStrategies):
(PlatformStrategies):

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):

  • platform/mac/PasteboardMac.mm:

(WebCore):
(WebCore::selectionPasteboardTypes):
(WebCore::writableTypesForURL):
(WebCore::createWritableTypesForImage):
(WebCore::writableTypesForImage):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeSelection):
(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeURL):
(WebCore::writeFileWrapperAsRTFDAttachment):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::writeClipboard):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::documentFragmentWithRTF):
(WebCore::Pasteboard::documentFragment):

  • platform/mac/PlatformPasteboardMac.mm: Removed.

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::addVisitedLink):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

Feb 10, 2012:

11:52 PM Changeset in webkit [107474] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Move CSSOM wrapper pointer out of StylePropertySet
​https://bugs.webkit.org/show_bug.cgi?id=78406

Reviewed by Andreas Kling.

Most StylePropertySet instances never have CSSOM wrappers so having a pointer to one in
each and and every object makes no sense.

Move the PropertySetCSSStyleDeclaration instances to a global HashMap. This shrinks
StylePropertySet by a pointer.

Added COMPILE_ASSERT for StylePropertySet size.

  • css/StylePropertySet.cpp:

(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):

  • css/StylePropertySet.h:

(StylePropertySet):

8:28 PM Changeset in webkit [107473] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

MathML internals - use createXXX() function naming, ASSERT()s
​https://bugs.webkit.org/show_bug.cgi?id=78384

Patch by David Barton <Dave Barton> on 2012-02-10
Reviewed by Eric Seidel.

Standard RefPtr function naming uses "createXXX" instead of "makeXXX".
I also added a couple of ASSERT()s.

No new tests.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createBlockStyle):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::createOperatorStyle):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):

  • rendering/mathml/RenderMathMLFenced.h:

(RenderMathMLFenced):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::addChild):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::addChild):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::RenderMathMLSubSup):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver):
(WebCore::RenderMathMLUnderOver::addChild):

8:00 PM Changeset in webkit [107472] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Non-threaded scrolling build fix.

  • page/FrameView.cpp:

(WebCore::FrameView::requestScrollPositionUpdate):

7:58 PM Changeset in webkit [107471] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

BlackBerry Port - Input focus is suppressed during XHR loads
​https://bugs.webkit.org/show_bug.cgi?id=78368

Allow JS to trigger the VKB and input focus when XHR scripting
is active.

This switching the loaded state to checking the webpages loaded state
which is only updated after initial load. When additional loading
events happen for XHR, it remains false and focus events function.

Also add detailed FocusLog's to shouldAcceptInputFocus.

Patch by Mike Fenton <​mifenton@rim.com> on 2012-02-10
Reviewed by Rob Buis.

  • blackberry/WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):

7:10 PM Changeset in webkit [107470] by commit-queue@webkit.org
  • 6 edits in trunk

Change values for WEBKIT_KEYFRAMES_RULE, WEBKIT_KEYFRAME_RULE
​https://bugs.webkit.org/show_bug.cgi?id=71293

Patch by Edward O'Connor <Theresa O'Connor> on 2012-02-10
Reviewed by Chris Marrin.

Source/WebCore:

Tests: animations/animation-css-rule-types.html

  • css/CSSRule.h: Change WEBKIT_KEYFRAMES_RULE to 7 and

WEBKIT_KEYFRAME_RULE to 8.

  • css/CSSRule.idl: Ditto.

LayoutTests:

  • animations/animation-css-rule-types-expected.txt:
  • animations/script-tests/animation-css-rule-types.js: Update

expected WEBKIT_KEYFRAMES_RULE and WEBKIT_KEYFRAME_RULE values.

6:53 PM Changeset in webkit [107469] by tony@chromium.org
  • 17 edits
    8 deletes in trunk/LayoutTests

[chromium] Unreviewed gardening.
svg/text/non-bmp-positioning-lists.svg is missing glyphs. The other
tests are additional fallout from r107417.

  • platform/chromium-mac-leopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/carto.net/window-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/foreignObject-crash-on-hover-expected.png:
  • platform/chromium-mac-leopard/svg/custom/hit-test-unclosed-subpaths-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-mac-leopard/svg/custom/mask-invalidation-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-clipped-hit-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-detach-expected.png:
  • platform/chromium-mac-leopard/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-mac-leopard/svg/hixie/perf/004-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-detach-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/filters/animate-fill-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/004-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium/test_expectations.txt:
6:35 PM Changeset in webkit [107468] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

AtomicMarkupTokenBase::initializeAttributes should not create a StringImpl if it doesn't need to
​https://bugs.webkit.org/show_bug.cgi?id=78394

Reviewed by Adam Barth.

On the very next line is passes value to Attribute::create which takes
an AtomicString, so this code was just allocating a StringImpl (every time)
only to (much of the time) just release that StringImpl on the next line
when it got the AtomicString instead.

I discovered this while looking at DOM/Events.html, but it's unclear
if this fix actually makes that benchmark faster.

  • xml/parser/MarkupTokenBase.h:

(WebCore::::initializeAttributes):

6:33 PM Changeset in webkit [107467] by andersca@apple.com
  • 12 edits in trunk/Source/WebCore

Always update the scroll position through the scrolling coordinator
​https://bugs.webkit.org/show_bug.cgi?id=78403

Reviewed by Sam Weinig.

To get correct behavior, we always want to update the scrolling layer position
on the scrolling thread. Do this by allowing the scrolling coordinator to intercept
scroll position update requests and send them to the scrolling tree.

  • page/FrameView.cpp:

(WebCore::FrameView::requestScrollPositionUpdate):
Let the scrolling coordinator have a go at updating the scroll position for this frame view.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
If it's a frame view we're coordinating scrolling for, tell the scrolling tree to update
the scroll position.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::setMainFrameScrollPosition):
Call through to the scrolling tree node.

  • page/scrolling/ScrollingTreeNode.h:

Add a new pure virtual setScrollPosition member function.

(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Move most of the code from scrollBy here.

(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
Rename this member function from setScrollPosition to avoid conflicts.

(WebCore::ScrollingTreeNodeMac::scrollBy):
Just call setScsrollPosition.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Call requestScrollPositionUpdate, which allows subclasses of scrollable area to intercept
the scroll operation and call it asynchronously.

6:08 PM LayoutUnit edited by eae@chromium.org
Removed duplicate borders entry. (diff)
6:03 PM Changeset in webkit [107466] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

ScrollableArea should have a function for noting that the scroll position changed
​https://bugs.webkit.org/show_bug.cgi?id=78402

Reviewed by Sam Weinig.

The scrolling coordinator needs a specialized function to call whenever the main frame
scrolling position has changed, so add ScrollableArea::notifyScrollPositionChanged and
call it from the scrolling coordinator.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::notifyScrollPositionChanged):
New function.

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Call ScrollableArea::notifyScrollPositionChanged.

5:41 PM Changeset in webkit [107465] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fixing the build by removing a duplicate definition of pixelSnappedIntRect in LayoutTypes.h and
removing conflict markers from the changelog.

  • rendering/LayoutTypes.h:

(pixelSnappedIntRect):

  • ChangeLog:
5:37 PM Changeset in webkit [107464] by mikelawther@chromium.org
  • 3 edits in trunk/LayoutTests

CSS3 calc: convert font-size-fractional test to use pre/post js
​https://bugs.webkit.org/show_bug.cgi?id=78347

Reviewed by Ojan Vafai.

  • css3/calc/font-size-fractional-expected.txt:
  • css3/calc/font-size-fractional.html:
5:20 PM Changeset in webkit [107463] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Disable IndexedDB permissions check from shared workers
​https://bugs.webkit.org/show_bug.cgi?id=78316

We want to temporarily bypass this check because it causes a crash
when called from a shared worker. We'll have to fix it before
including idb on shared workers in a release but don't want to stop
developers from testing out idb on shared workers.

No new tests because it affects shared workers only, which aren't
testable by DRT.

Reviewed by Tony Chang.

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread):

5:03 PM Changeset in webkit [107462] by tony@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

[chromium] Unreviewed, remove a linux gpu result that is not needed after r107448.

  • platform/chromium-gpu-linux/media/video-empty-source-expected.png: Removed.
4:58 PM Changeset in webkit [107461] by leviw@chromium.org
  • 23 edits in trunk/Source/WebCore

Add pixelSnappedIntRect method
​https://bugs.webkit.org/show_bug.cgi?id=78054

Reviewed by Eric Seidel.

This patch introduces a pixelSnappedIntRect method that will snap a sub-pixel LayoutRect to
pixel boundaries. These pixel snapped forms are what is used to communicate with the graphics
engine (to paint at whole pixel boundaries) and the embedding app (so they don't need to
understand we're using sub-pixel units).

No new tests. No change in behavior.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):

  • dom/Range.cpp:

(WebCore::Range::boundingBox):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • page/Frame.cpp:

(WebCore::Frame::nodeImage):

  • page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::windowClipRectForLayer):

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::paintGraphicsLayerContents):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint):

  • rendering/LayoutTypes.h:

(WebCore::pixelSnappedIntRect):
(WebCore):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::selectionGaps):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::paint):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintIntoRegion):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
(WebCore::RenderFrameSet::positionFramesWithFlattening):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::calculateRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::paintScrollbar):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::addPDFURLRect):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::paint):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderFor):

4:55 PM Changeset in webkit [107460] by bweinstein@apple.com
  • 15 edits in trunk/Source

Source/WebCore: Web Inspector: Add the ability to jump to the source for a given frame
​https://bugs.webkit.org/show_bug.cgi?id=78396

Reviewed by Tim Hatcher.

  • WebCore.exp.in: Add a new exported function.
  • inspector/InspectorController.cpp: Add and expose the InspectorPageAgent.

(WebCore::InspectorController::InspectorController): Set m_pageAgent.

  • inspector/InspectorController.h: Add m_pageAgent.

(WebCore::InspectorController::pageAgent): Return m_pageAgent.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::showMainResourceForFrame): Get the inspector's frame ID

of the frame that was passed in, and add a call to evaluate on load.

  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.showMainResourceForFrame): Add a FIXME to show the source code for the main

resource of the given frame.

Source/WebKit2: Web Inspector: Add the ability to jump to the source for a given frame
​https://bugs.webkit.org/show_bug.cgi?id=78396

Add WebKit2 API for the ability to show the source of a frame in the web inspector. This calls down
from the WK API all the way to InspectorFrontendClientLocal::showMainResourceForFrame.

Reviewed by Tim Hatcher.

  • UIProcess/API/C/WKInspector.cpp:

(WKInspectorShowMainResourceForFrame): Call WebInspectorProxy::showMainResourceForFrame.

  • UIProcess/API/C/WKInspector.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::showMainResourceForFrame): Send a message to the web process, passing

the frame ID of the frame we want to show the main resource of.

  • UIProcess/WebInspectorProxy.h:
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::showMainResourceForFrame): Get the WebFrame for the frame we want to show the

main resource of from its ID. If we found a frame, call InspectorFrontendClientLocal::showMainResourceForFrame.

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebInspector.messages.in: Add a new message.
4:42 PM Changeset in webkit [107459] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Source/JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=72756
DOMHTMLElement’s accessKey property is declared as available in WebKit version that didn’t have it

Patch by Vineet Chaudhary <Vineet> on 2012-02-10
Reviewed by Timothy Hatcher.

  • API/WebKitAvailability.h: Added AVAILABLE_AFTER_WEBKIT_VERSION_5_1 and AVAILABLE_WEBKIT_VERSION_1_3_AND_LATER_BUT_DEPRECATED_AFTER_WEBKIT_VERSION_5_1 for the new versions.

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=72756
DOMHTMLElement’s accessKey property is declared as available in WebKit version that didn’t have it.

Patch by Vineet Chaudhary <Vineet> on 2012-02-10
Reviewed by Timothy Hatcher.

No new tests.

  • bindings/objc/PublicDOMInterfaces.h: Moving accessKey property to DOMHTMLElement with an appropriate availability macro AVAILABLE_AFTER_WEBKIT_VERSION_5_1. Also Moving accessKey property to HTMLAnchorElement, HTMLAreaElement, HTMLButtonElement, HTMLInputElement, HTMLLabelElement, HTMLLegendElement and HTMLTextAreaElement idls with an availability macro AVAILABLE_WEBKIT_VERSION_1_3_AND_LATER_BUT_DEPRECATED_AFTER_WEBKIT_VERSION_5_1.
  • html/HTMLAnchorElement.idl: Adding accessKey entries back to idls under LANGUAGE_OBJECTIVE_C.
  • html/HTMLAreaElement.idl: Ditto.
  • html/HTMLButtonElement.idl: Ditto.
  • html/HTMLInputElement.idl: Ditto.
  • html/HTMLLabelElement.idl: Ditto.
  • html/HTMLLegendElement.idl: Ditto.
  • html/HTMLTextAreaElement.idl: Ditto.
4:36 PM Changeset in webkit [107458] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Speculative build fix.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::scrollToRevealSelection):

4:35 PM Changeset in webkit [107457] by leviw@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore/rendering

Switching positionOverflowControls to operate on integers, as these overflow controls are always widgets on integer boundaries.

4:32 PM Changeset in webkit [107456] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixing windows build

Unreviewed build fix

4:13 PM Changeset in webkit [107455] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

These SVG tests all appear to pass (many due to my updating their
baselines last night).

  • platform/chromium/test_expectations.txt:
4:06 PM Changeset in webkit [107454] by adamk@chromium.org
  • 26 edits in trunk

Enable MUTATION_OBSERVERS by default on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=78196

Reviewed by Ojan Vafai.

.:

  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • UseV8.cmake: Add some previously-missing files.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • bindings/js/JSBindingsAllInOne.cpp: ditto.
  • dom/DOMAllInOne.cpp: ditto.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • platform/efl/Skipped: Stop skipping the tests except for those known to fail.
  • platform/gtk/Skipped: ditto.
  • platform/mac/Skipped: ditto.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
  • platform/wincairo/Skipped: ditto.
4:00 PM Changeset in webkit [107453] by leviw@chromium.org
  • 3 edits
    1 add in trunk/Source/WebCore

Add FractionalLayoutUnit type for sub-pixel layout
​https://bugs.webkit.org/show_bug.cgi?id=77485

Reviewed by Eric Seidel.

Add fixed point implementation (FractionalLayoutUnit).

FractionalLayoutUnit represents values as multiples of 1/60th pixel. This allows us
to represent sub-pixel values using integer math and avoids floating point precision
problems.

No new tests.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/FractionalLayoutUnit.h: Added.
3:53 PM Changeset in webkit [107452] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Add keyframes to LayoutTests/media/content/test.ogv to hasten test completion & avoid timeouts.
​https://bugs.webkit.org/show_bug.cgi?id=78058

Patch by Ami Fischman <​fischman@chromium.org> on 2012-02-10
Reviewed by Eric Carlson.
File was created with ffmpeg2theora v0.24, command-line:
ffmpeg2theora --no-upscaling --no-skeleton -e 6.02 -K 21 test.mp4 -o test.ogv
The important bit was the addition of "-K 21" to force keyframe creation.
The other flags are important to minimize breakage of tests that hardcode
expectations like "the first 100k will contain the metadata" etc.

Before this, seeking to 5.6s would use the (only) keyframe at 2.4s and
have to decode all the way forward from there, which would be sometimes
timeout (presumably on overloaded bots).

  • media/content/test.ogv:
  • platform/chromium/test_expectations.txt:
3:53 PM Changeset in webkit [107451] by abarth@webkit.org
  • 2 edits in trunk/Tools

Move garden-o-matic's All Failures out of experimental
​https://bugs.webkit.org/show_bug.cgi?id=78395

Reviewed by Dimitri Glazkov.

Several folks have tried this feature and found it useful.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3:49 PM Changeset in webkit [107450] by agl@chromium.org
  • 7 edits
    1 move in trunk

Don't lowercase ping URLs.

Previously, ping URLs would be lowercased when splitting them apart.
URLs are not, however, case-insensitive.

​https://bugs.webkit.org/show_bug.cgi?id=78371

Reviewed by Tony Chang.

Source/WebCore:

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::sendPings): Don't lowercase URL.

LayoutTests:

  • http/tests/navigation/image-load-in-unload-handler.html: update to new URL
  • http/tests/navigation/ping-cookie.html:
  • http/tests/navigation/ping-cross-origin.html:
  • http/tests/navigation/ping-same-origin.html:
  • http/tests/navigation/resources/save-Ping.php: Renamed from LayoutTests/http/tests/navigation/resources/save-ping.php.
3:41 PM WikiStart edited by eae@chromium.org
Added link to LayoutUnit wiki page (diff)
3:39 PM LayoutUnit edited by eae@chromium.org
(diff)
3:38 PM Changeset in webkit [107449] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

BlackBerry Port - JS focus on blur can cause recursion
​https://bugs.webkit.org/show_bug.cgi?id=78368

Prevent JS recursion of blur/focus by allowing focus
if we are already trying to prevent focus.

Patch by Mike Fenton <​mifenton@rim.com> on 2012-02-10
Reviewed by Rob Buis.

  • blackberry/WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
(BlackBerry::WebKit::InputHandler::setElementFocused):

  • blackberry/WebKitSupport/InputHandler.h:

(InputHandler):

3:30 PM Changeset in webkit [107448] by commit-queue@webkit.org
  • 7 edits
    9 adds in trunk/LayoutTests

media/video-empty-source.html needs a rebaseline for chromium
​https://bugs.webkit.org/show_bug.cgi?id=78233

Unreviewed rebaselining.

Patch by Ami Fischman <​fischman@chromium.org> on 2012-02-10

  • platform/chromium-linux-x86/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
  • platform/chromium-mac-leopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Added.
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Added.
  • platform/chromium-win-vista/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
  • platform/chromium-win-xp/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium/test_expectations.txt:
3:01 PM Changeset in webkit [107447] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

ENABLE(ASSEMBLER_WX_EXCLUSIVE): LinkBuffer can leave pages not marked as executable.
​https://bugs.webkit.org/show_bug.cgi?id=76724

Patch by Yong Li <​yoli@rim.com> on 2012-02-10
Reviewed by Rob Buis.

This issue only exists when both ENABLE(ASSEMBLER_WX_EXCLUSIVE) and ENABLE(BRANCH_COMPACTION) are on.
The size used to call makeExecutable can be smaller than the one that was used for makeWritable.
So it can leave pages behind that are not set back to default flags. When an assembly on one of those
pages is executed or JIT returns to those pages in the case it was already executing from there, the
software will crash.

  • assembler/LinkBuffer.h: Add m_initialSize and use it in performFinalization().

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
(LinkBuffer):

3:01 PM Changeset in webkit [107446] by ojan@chromium.org
  • 4 edits
    2 adds in trunk

flex-pack:center and flex-item-align:center should do true centering
​https://bugs.webkit.org/show_bug.cgi?id=77385

Reviewed by Tony Chang.

Source/WebCore:

Also, removed passing totalPositiveFlexibility around. We don't
need to know about positive/negative flex once we run the flexing algorithm.
We used to need to know this in order to flex margins, but margins can
no longer be flexed.

Test: css3/flexbox/true-centering.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/true-centering-expected.txt: Added.
  • css3/flexbox/true-centering.html: Added.
2:44 PM Changeset in webkit [107445] by mhahnenberg@apple.com
  • 22 edits in trunk/Source

Split MarkedSpace into destructor and destructor-free subspaces
​https://bugs.webkit.org/show_bug.cgi?id=77761

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject): Switched over to use destructor-free space.

  • heap/Heap.h:

(JSC::Heap::allocatorForObjectWithoutDestructor): Added to give clients (e.g. the JIT) the ability to
pick which subspace they want to allocate out of.
(JSC::Heap::allocatorForObjectWithDestructor): Ditto.
(Heap):
(JSC::Heap::allocateWithDestructor): Added private function for CellAllocator to use.
(JSC):
(JSC::Heap::allocateWithoutDestructor): Ditto.

  • heap/MarkedAllocator.cpp: Added the cellsNeedDestruction flag to allocators so that they can allocate

their MarkedBlocks correctly.
(JSC::MarkedAllocator::allocateBlock):

  • heap/MarkedAllocator.h:

(JSC::MarkedAllocator::cellsNeedDestruction):
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC):
(JSC::MarkedAllocator::init): Replaced custom set functions, which were only used upon initialization, with
an init function that does all of that stuff in fewer lines.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::create):
(JSC::MarkedBlock::recycle):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::callDestructor): Templatized, along with specializedSweep and sweepHelper, to make
checking the m_cellsNeedDestructor flag faster and cleaner looking.
(JSC):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):

  • heap/MarkedBlock.h:

(MarkedBlock):
(JSC::MarkedBlock::cellsNeedDestruction):
(JSC):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::TakeIfUnmarked::operator()):

  • heap/MarkedSpace.h:

(MarkedSpace):
(Subspace):
(JSC::MarkedSpace::allocatorFor): Needed function to differentiate between the two broad subspaces of
allocators.
(JSC):
(JSC::MarkedSpace::destructorAllocatorFor): Ditto.
(JSC::MarkedSpace::allocateWithoutDestructor): Ditto.
(JSC::MarkedSpace::allocateWithDestructor): Ditto.
(JSC::MarkedSpace::forEachBlock):

  • jit/JIT.h:
  • jit/JITInlineMethods.h: Modified to use the proper allocator for JSFinalObjects and others.

(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSFunction):

  • runtime/JSArray.cpp:

(JSC):

  • runtime/JSArray.h:

(JSArray):
(JSC::JSArray::create):
(JSC):
(JSC::JSArray::tryCreateUninitialized):

  • runtime/JSCell.h:

(JSCell):
(JSC):
(NeedsDestructor): Template struct that calculates at compile time whether the class in question requires
destruction or not using the compiler type trait has_trivial_destructor. allocateCell then checks this
constant to decide whether to allocate in the destructor or destructor-free parts of the heap.
(JSC::allocateCell):

  • runtime/JSFunction.cpp:

(JSC):

  • runtime/JSFunction.h:

(JSFunction):

  • runtime/JSObject.cpp:

(JSC):

  • runtime/JSObject.h:

(JSNonFinalObject):
(JSC):
(JSFinalObject):
(JSC::JSFinalObject::create):

Source/WebCore:

No new tests.

  • bindings/js/JSDOMWindowShell.cpp: Removed old operator new, which was just used in the create

function so that we can use allocateCell instead.
(WebCore):

  • bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::create):
(JSDOMWindowShell):

  • bindings/scripts/CodeGeneratorJS.pm: Added destructor back to root JS DOM nodes (e.g. JSNode, etc)

because their destroy functions need to be called, so we don't want the NeedsDestructor struct to
think they don't need destruction due to having empty/trivial destructors.
Removed ASSERT_HAS_TRIVIAL_DESTRUCTOR from all JS DOM wrapper auto-generated objects because their
ancestors now have non-trivial destructors.
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDefinition):

2:42 PM Changeset in webkit [107444] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[chromium] Unreviewed, adding Leopard pixel baselines for
fast/forms/select-overflow-scroll* tests. This was missed in r107084.

  • platform/chromium-mac-leopard/fast/forms/select-overflow-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
2:25 PM Changeset in webkit [107443] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove a bunch of unused ScrollableArea member functions
​https://bugs.webkit.org/show_bug.cgi?id=78388

Reviewed by Beth Dakin.

  • platform/ScrollableArea.cpp:
  • platform/ScrollableArea.h:
2:20 PM Changeset in webkit [107442] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

Fix a few typos in IDL exception names.
​https://bugs.webkit.org/show_bug.cgi?id=78356

Reviewed by Adam Barth.

  • dom/Node.idl:
  • notifications/NotificationCenter.idl:
  • page/Navigator.idl:
2:19 PM Changeset in webkit [107441] by tony@chromium.org
  • 9 edits
    1 copy
    2 deletes in trunk/LayoutTests

[chromium] Unreviewed, fix up some baselines that were landed in r107417.
Some bad results were checked in.

  • platform/chromium-linux-x86/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-linux/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-linux/svg/text/append-text-node-to-tspan-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/animate-fill-expected.txt: Renamed from LayoutTests/platform/chromium/svg/filters/animate-fill-expected.txt.
  • platform/chromium-win-vista/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-win-xp/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-win-xp/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-win/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
  • platform/chromium-win/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
2:17 PM Changeset in webkit [107440] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

DefaultLocalizationStrategy::htmlSelectMultipleItems() should use size_t instead of int
​https://bugs.webkit.org/show_bug.cgi?id=78374

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-02-10
Reviewed by Joseph Pecoraro.

The value comes from size_t and is converted to int for no good reason. We should use
size_t.

  • platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):

  • platform/DefaultLocalizationStrategy.h:

(DefaultLocalizationStrategy):

2:17 PM Changeset in webkit [107439] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Remove platform/win/test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=78382

Reviewed by Adam Barth.

This files is unused, since the Apple win port does not use new-run-webkit-tests, and causes unnecessary
confusion.

  • platform/win/test_expectations.txt:
2:09 PM WebKitlayouttypes.png attached to LayoutUnit by eae@chromium.org
pixelSnappedIntRect
2:01 PM Changeset in webkit [107438] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

More ScrollableArea cleanup
​https://bugs.webkit.org/show_bug.cgi?id=78383

Reviewed by Beth Dakin.

Get rid of setScrollOriginX and setScrollOriginY. Make ScrollableArea::setScrollOrigin private.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOrigin):

  • platform/ScrollableArea.h:

(ScrollableArea):

1:52 PM Changeset in webkit [107437] by eae@chromium.org
  • 3 edits in branches/subpixellayout/Source

Remove unnecessary type conversions.

1:43 PM Changeset in webkit [107436] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
​https://bugs.webkit.org/show_bug.cgi?id=78353

Reviewed by Adam Barth.

[JSCustomPrototypePutDelegate] is used to write custom code for named
getters on a prototype interface. "PutDelegate" is just a method name
in implementation and not so descriptive. This patch renames it to
[JSCustomNamedGetterOnPrototype]. This is also for naming consistency
with [CustomNamedGetter].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • page/Location.idl:
1:40 PM Changeset in webkit [107435] by enrica@apple.com
  • 14 edits
    3 adds in trunk/Source

Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
​https://bugs.webkit.org/show_bug.cgi?id=78282

This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests. No change in behavior, just code refactoring.

  • WebCore.exp.in: Added exported class PlatformPasteboard.
  • WebCore.xcodeproj/project.pbxproj: Added new files to the build.
  • editing/mac/EditorMac.mm:

(WebCore::Editor::writeSelectionToPasteboard): New method signature that doesn't use OBJ-C types.

  • platform/Pasteboard.h:
  • platform/PasteboardStrategy.h: Added PasteboardStrategy abstract class.
  • platform/PlatformPasteboard.h: Added. This class implements access to NSPasteboard.
  • platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::pasteboardStrategy): Added.

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):

  • platform/mac/PasteboardMac.mm:

(WebCore::selectionPasteboardTypes): Changed to use Vector<String> instead of NSArray.
(WebCore::writableTypesForURL): Ditto.
(WebCore::createWritableTypesForImage): Ditto.
(WebCore::writableTypesForImage): Ditto.
(WebCore::Pasteboard::Pasteboard): Removed access to NSPasteboard.
(WebCore::Pasteboard::clear): Modified to use platformStrategies()->pasteboardStrategy().
(WebCore::Pasteboard::writeSelectionForTypes): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::writeURLForTypes): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::writeFileWrapperAsRTFDAttachment): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.
(WebCore::Pasteboard::writeClipboard): Ditto.
(WebCore::Pasteboard::canSmartReplace): Ditto.
(WebCore::Pasteboard::plainText): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.

  • platform/mac/PlatformPasteboardMac.mm: Added.

(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::getTypes):
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::copy):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::setPathnamesForType):
(WebCore::PlatformPasteboard::setStringForType):

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
  • WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface.

(WebPlatformStrategies::createPasteboardStrategy):
(WebPlatformStrategies::getTypes):
(WebPlatformStrategies::bufferForType):
(WebPlatformStrategies::getPathnamesForType):
(WebPlatformStrategies::stringForType):
(WebPlatformStrategies::copy):
(WebPlatformStrategies::setTypes):
(WebPlatformStrategies::setBufferForType):
(WebPlatformStrategies::setPathnamesForType):
(WebPlatformStrategies::setStringForType):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added implementation of PasteboardStrategy

interface.
(WebKit::WebPlatformStrategies::createPasteboardStrategy):
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
1:33 PM Changeset in webkit [107434] by tony@chromium.org
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

[chromium] Unreviewed, update SnowLeopard results for
compositing/geometry/fixed-position-composited.html. Minor differences
in fonts between Leopard and SL.

  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Renamed from LayoutTests/platform/chromium/compositing/geometry/fixed-position-composited-page-scale-down-expected.png.
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Removed.
1:16 PM Changeset in webkit [107433] by scherkus@chromium.org
  • 4 edits in branches/chromium/1025

Merge 106730 - Source/WebCore: Patch by Swapna P <​spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.

Bug: iframe with scrolling=no incorrectly autoscrollable
​https://bugs.webkit.org/show_bug.cgi?id=61558

Added check for frame scrolling mode just before applying scroll on frame content in function RenderLayer::scrollRect

Testcase: LayoutTests/fast/events/autoscroll-with-non-scrollable-parent.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):

LayoutTests: Patch by Swapna P <​spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.

Bug: iframe with scrolling=no incorrectly autoscrollable
​https://bugs.webkit.org/show_bug.cgi?id=61558

Did change inorder to print correct log as per the description provided in test case.

  • fast/events/autoscroll-with-non-scrollable-parent.html:

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9385018

1:03 PM Changeset in webkit [107432] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

Rename [JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor]
​https://bugs.webkit.org/show_bug.cgi?id=78352

Reviewed by Adam Barth.

[JSCustomGetOwnPropertySlotDelegate] is used for "flexibly customizable"
named getter. It allows us to write custom code for getOwnPropertySlotDelegate()
and getOwnPropertyDescriptorDelegate(). To clarify that, we can rename
[JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl:
  • page/History.idl:
  • page/Location.idl:
  • workers/WorkerContext.idl:
1:00 PM Changeset in webkit [107431] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Minor ScrollAnimatorMac cleanup
​https://bugs.webkit.org/show_bug.cgi?id=78375

Reviewed by Beth Dakin.

Get rid of adjustScrollXPositionIfNecessary and adjustScrollYPositionIfNecessary.
Also, reduce nesting in willAdd/didAdd functions by using early returns.

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::immediateScrollBy):

1:00 PM Changeset in webkit [107430] by thakis@chromium.org
  • 4 edits in branches/chromium/1025/Source/WebKit/chromium

Merge 106401 (part of ​http://crbug.com/111266) -
[chromium] Expose windowResizerRectChanged() on WebWidget.
​https://bugs.webkit.org/show_bug.cgi?id=77453

Needed for ​http://crbug.com/111266

Reviewed by Darin Fisher.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::didChangeWindowResizerRect):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didChangeWindowResizerRect):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

TBR=​thakis@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9384018

12:49 PM Changeset in webkit [107429] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Minor ScrollableArea cleanup
​https://bugs.webkit.org/show_bug.cgi?id=78372

Reviewed by Beth Dakin.

Get rid of scrollToXOffsetWithoutAnimation and scrollToYOffsetWithoutAnimation.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):

  • platform/ScrollableArea.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computeLogicalHeight):
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::setScrollTop):

12:17 PM Changeset in webkit [107428] by benjamin@webkit.org
  • 4 edits in trunk/Source

[Mac] DYLIB_INSTALL_NAME_BASE should not be prefixed by the SDKROOT
​https://bugs.webkit.org/show_bug.cgi?id=78320

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-02-10
Reviewed by Joseph Pecoraro.

<rdar://problem/10839750>

Source/WebCore:

  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig:
12:15 PM Changeset in webkit [107427] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, mark compositing/rubberbanding tests as failing.
There's too much flipping in the tests for me to narrow it down to a revision.

  • platform/chromium/test_expectations.txt:
12:11 PM Changeset in webkit [107426] by rwlbuis@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

[BlackBerry] Upstream graphics helper classes in WebKitSupport
​https://bugs.webkit.org/show_bug.cgi?id=78278

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • blackberry/WebKitSupport/RenderQueue.cpp: Added.
  • blackberry/WebKitSupport/RenderQueue.h: Added.
12:07 PM Changeset in webkit [107425] by mikelawther@chromium.org
  • 3 edits in trunk/LayoutTests

CSS3 calc: update font-size test to use pre/post js
​https://bugs.webkit.org/show_bug.cgi?id=78325

Reviewed by Ojan Vafai.

  • css3/calc/font-size-expected.txt:
  • css3/calc/font-size.html:
12:06 PM Changeset in webkit [107424] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Update the non-fast-scrollable region for subframe layout as well
​https://bugs.webkit.org/show_bug.cgi?id=78366
<rdar://problem/10844064>

Reviewed by Beth Dakin.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):
Move the non-fast-scrollable region computation out into a new function.

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Always recompute the non-fast-scrollable region whenever a frame view's layout is updated,
not just the main frame.

11:54 AM Changeset in webkit [107423] by tony@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

[chromium] Unreviewed: The Leopard results were missed in r107140.
The getComputedStyle change is due to r107289.

  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug23151-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
11:41 AM Changeset in webkit [107422] by cmarrin@apple.com
  • 14 edits
    12 adds in trunk

Implement hardware animation of CSS filters
​https://bugs.webkit.org/show_bug.cgi?id=78155

Source/WebCore:

Added logic to PlatformCAAnimation to return enough information
to GraphicsLayerCA to be able to construct a keyPath animation
for each filter property. Some filters need to animate multiple
properties per filter, so PlatformCAAnimation also returns the number
of properties per filter and then an animation is constructed for
each one. Also added all the support logic to handle hardware filter
animation in the higher level logic, just like we do for transforms and
opacity.

Also stubbed out new PlatformCAAnimation functions for Windows. We don't yet
support hardware filters on Windows.

Reviewed by Dean Jackson.

Tests: css3/filters/filter-animation-from-none-hw.html

css3/filters/filter-animation-from-none-multi-hw.html
css3/filters/filter-animation-from-none-multi.html
css3/filters/filter-animation-hw.html
css3/filters/filter-animation-multi-hw.html
css3/filters/filter-animation-multi.html

  • page/animation/AnimationBase.cpp:

(WebCore):
(PropertyWrapperAcceleratedFilter):
(WebCore::PropertyWrapperAcceleratedFilter::PropertyWrapperAcceleratedFilter):
(WebCore::PropertyWrapperAcceleratedFilter::animationIsAccelerated):
(WebCore::PropertyWrapperAcceleratedFilter::blend):
(WebCore::AnimationBase::ensurePropertyMap):

  • platform/graphics/GraphicsLayer.cpp:

(WebCore):
(WebCore::filterOperationsAt):
(WebCore::GraphicsLayer::validateFilterOperations):

  • platform/graphics/GraphicsLayer.h:

(WebCore):
(FilterAnimationValue):
(WebCore::FilterAnimationValue::FilterAnimationValue):
(WebCore::FilterAnimationValue::clone):
(WebCore::FilterAnimationValue::value):
(GraphicsLayer):

  • platform/graphics/GraphicsLayerClient.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::propertyIdToString):
(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::createBasicAnimation):
(WebCore::GraphicsLayerCA::createKeyframeAnimation):
(WebCore::GraphicsLayerCA::setFilterAnimationEndpoints):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::cloneLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/PlatformCAAnimation.h:

(PlatformCAAnimation):

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::numAnimatedFilterProperties):
(PlatformCAAnimation::animatedFilterPropertyName):

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::numAnimatedFilterProperties):
(PlatformCAAnimation::animatedFilterPropertyName):

  • platform/graphics/filters/FilterOperation.h:

(FilterOperation):
(WebCore::FilterOperation::isDefault):
(DefaultFilterOperation):
(WebCore::DefaultFilterOperation::create):
(WebCore::DefaultFilterOperation::operator==):
(WebCore::DefaultFilterOperation::isDefault):
(WebCore::DefaultFilterOperation::DefaultFilterOperation):
(WebCore):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasFilter):
(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
(WebCore::RenderLayerBacking::graphicsLayerToCSSProperty):
(WebCore::RenderLayerBacking::cssToGraphicsLayerProperty):

LayoutTests:

New tests for hardware animated filters, cribbed from software animation tests.
Also added a -multi test, which uses 3 keyframes for each filter. Hardware animations
use the same logic for 2 keyframe animations and transitions, so this exercises the
other logic path.

Reviewed by Dean Jackson.

  • css3/filters/filter-animation-from-none-hw-expected.txt: Added.
  • css3/filters/filter-animation-from-none-hw.html: Added.
  • css3/filters/filter-animation-from-none-multi-expected.txt: Added.
  • css3/filters/filter-animation-from-none-multi-hw-expected.txt: Added.
  • css3/filters/filter-animation-from-none-multi-hw.html: Added.
  • css3/filters/filter-animation-from-none-multi.html: Added.
  • css3/filters/filter-animation-hw-expected.txt: Added.
  • css3/filters/filter-animation-hw.html: Added.
  • css3/filters/filter-animation-multi-expected.txt: Added.
  • css3/filters/filter-animation-multi-hw-expected.txt: Added.
  • css3/filters/filter-animation-multi-hw.html: Added.
  • css3/filters/filter-animation-multi.html: Added.
11:36 AM Changeset in webkit [107421] by enne@google.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove implicit copy constructor usage in HashMaps with OwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=78071

Reviewed by Darin Adler.

Change the return type of emptyValue() in PairHashTraits to be the
actual type returned rather than the trait type to avoid an implicit
generation of the OwnPtr copy constructor. This happens for hash
traits involving OwnPtr where the empty value is not zero and each
hash bucket needs to be initialized with emptyValue().

Also, update StructureTransitionTable to use default hash traits
rather than rolling its own, in order to update it to handle
EmptyValueType.

Test: patch from bug 74154 compiles on Clang with this patch

  • runtime/StructureTransitionTable.h:

(StructureTransitionTable):

  • wtf/HashTraits.h:

(GenericHashTraits):
(PairHashTraits):
(WTF::PairHashTraits::emptyValue):

11:33 AM Changeset in webkit [107420] by mikelawther@chromium.org
  • 3 edits in trunk/LayoutTests

CSS3 calc: convert font test to use pre/post js
​https://bugs.webkit.org/show_bug.cgi?id=78321

Reviewed by Ojan Vafai.

  • css3/calc/font-expected.txt:
  • css3/calc/font.html:
11:31 AM Changeset in webkit [107419] by tony@chromium.org
  • 5 edits in trunk/LayoutTests

[chromium] Unreviewed: Add baselines on Mac for 2 tests that got
missed in the jpeg change (r107389). I verified that the only diffs
were in the jpeg and very minor.

  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug86708-expected.png:
11:20 AM Changeset in webkit [107418] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed: Give fast/js/dfg-int8array.html more time to run in debug.

The flakiness dashboard show it timing out regularly on Mac and occasionally on Windows.

  • platform/chromium/test_expectations.txt:
11:16 AM Changeset in webkit [107417] by jchaffraix@webkit.org
  • 93 edits
    62 adds
    55 deletes in trunk/LayoutTests

Massive SVG rebaselining on Chromium after bug 77736 and al.

Output trimmed.

11:02 AM Changeset in webkit [107416] by leviw@chromium.org
  • 7 edits in branches/subpixellayout/Source/WebCore

Switching RenderLayer's tracked repaint and outline rects, and LayoutRepainter's tracked boundary rects to LayoutRects. This keeps us from losing precision and conducting unnecessary repaints.

10:50 AM Changeset in webkit [107415] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

NRWT should categorize options in --help
​https://bugs.webkit.org/show_bug.cgi?id=76221

Reviewed by Eric Seidel.

Use optparse's OptionGroup mechanism to logically group NRWT's options,
providing a better experience when scanning all the options.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

10:45 AM Changeset in webkit [107414] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1025

Merge 106488
BUG=112259
Review URL: ​https://chromiumcodereview.appspot.com/9379014

10:41 AM Changeset in webkit [107413] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/963

Merge 106488
BUG=112259
Review URL: ​https://chromiumcodereview.appspot.com/9385008

10:39 AM Changeset in webkit [107412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: properly resolve output types of commands
​https://bugs.webkit.org/show_bug.cgi?id=78025

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-02-10
Reviewed by Vsevolod Vlasov.

Code for generating ad-hoc types is added. It was reused from event
generator part.

  • inspector/CodeGeneratorInspector.py:

(Generator.process_event):
(Generator.process_command):
(Generator.resolve_type_and_generate_ad_hoc):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix.NameFix):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.add_type):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceForwardListener):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceForwardListener.add_type_data):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceResolveContext):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceGenerateContext):
(Generator):

10:35 AM Changeset in webkit [107411] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1025

Merge 107369
BUG=112055
Review URL: ​https://chromiumcodereview.appspot.com/9381012

10:28 AM Changeset in webkit [107410] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

Rename [CustomPropertyNames] to [CustomEnumerateProperty]
​https://bugs.webkit.org/show_bug.cgi?id=78351

Reviewed by Adam Barth.

This patch renames [CustomPropertyNames] to [CustomEnumerateProperty],
for clarification and for naming consistency with [CustomDeleteProperty].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):

  • css/CSSStyleDeclaration.idl:
  • dom/DOMStringMap.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • storage/Storage.idl:
10:27 AM Changeset in webkit [107409] by cevans@google.com
  • 3 edits in branches/chromium/1025/Source/WebKit/chromium/src

Merge 107174
BUG=108695
Review URL: ​https://chromiumcodereview.appspot.com/9380014

10:22 AM Changeset in webkit [107408] by cevans@google.com
  • 3 edits in branches/chromium/963/Source/WebKit/chromium/src

Merge 107174
BUG=108695
Review URL: ​https://chromiumcodereview.appspot.com/9383008

10:22 AM Changeset in webkit [107407] by Antti Koivisto
  • 21 edits in trunk/Source

Use underlying property set to refcount PropertySetCSSStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=78257

Reviewed by Andreas Kling.

Clean up the PropertySetCSSStyleDeclaration refcounting. PropertySetCSSStyleDeclaration now
forwards the ref/deref to the underlying StylePropertySet.

Also made CSSComputedStyleDeclaration construction use the standard create() pattern.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::ref):
(WebCore):
(WebCore::CSSComputedStyleDeclaration::deref):

  • css/CSSComputedStyleDeclaration.h:

(WebCore::CSSComputedStyleDeclaration::create):
(CSSComputedStyleDeclaration):
(WebCore):

  • css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):

  • css/StylePropertySet.cpp:

(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):

  • css/StylePropertySet.h:
  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::highestEmbeddingAncestor):
(WebCore::ApplyStyleCommand::computedFontSize):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::init):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::backgroundColorInEffect):

  • editing/Editor.cpp:

(WebCore::Editor::textDirectionForSelection):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getComputedStyleForNode):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getComputedStyle):

  • svg/SVGAnimateElement.cpp:

(WebCore::getPropertyValue):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::baseValueFor):

9:27 AM Changeset in webkit [107406] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

The test is not finishing on windows so now we are waiting 30 seconds
before killing it. Replacing the SLOW keyword with TIMEOUT as it did
not help.

9:19 AM Changeset in webkit [107405] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

win test_expectations and Skipped have duplicates
​https://bugs.webkit.org/show_bug.cgi?id=78260

Reviewed by Anders Carlsson.

  • platform/win/test_expectations.txt: Remove duplicated entries

from this file. They were wrongly added to Skipped too and looking
at the comment in r103876, it's better to keep the Skipped entries.

8:32 AM Changeset in webkit [107404] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Fix compiler warning in Visual Studio 2010 about TR1
​https://bugs.webkit.org/show_bug.cgi?id=63642

Patch by Aron Rosenberg <​arosenberg@logitech.com> on 2012-02-10
Reviewed by Simon Hausmann.

7:41 AM Changeset in webkit [107403] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-10

  • DEPS:
7:41 AM Changeset in webkit [107402] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [TextPrompt] TAB should complete suggestions up to their common prefix in Console
​https://bugs.webkit.org/show_bug.cgi?id=78236

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype._completeCommonPrefix):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.tabKeyPressed):

7:41 AM Changeset in webkit [107401] by rwlbuis@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebKit

[BlackBerry] Upstream graphics helper classes in WebKitSupport
​https://bugs.webkit.org/show_bug.cgi?id=78278

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • blackberry/WebKitSupport/SurfacePool.cpp: Added.
  • blackberry/WebKitSupport/SurfacePool.h: Added.
  • blackberry/WebKitSupport/TileIndex.h: Added.
  • blackberry/WebKitSupport/TileIndexHash.h: Added.
7:31 AM Changeset in webkit [107400] by msaboff@apple.com
  • 3 edits
    3 adds in trunk

Yarr assert with regexp where alternative in *-quantified group matches empty
​https://bugs.webkit.org/show_bug.cgi?id=67752

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Added backtracking for the prior alternative if it matched
but didn't consume any input characters.

  • yarr/YarrJIT.cpp:

(YarrOp): New jump.
(JSC::Yarr::YarrGenerator::generate): Emit conditional jump
when an alternative matches and no input was consumed. Moved the
zero length match check for a set of alternatives to the alternative
code from the parentheses cases to the alternative end cases.
Converted the existing zero length checks in the parentheses cases
to runtime assertion checks.
(JSC::Yarr::YarrGenerator::backtrack): Link new jump to backtrack
to prior term.

LayoutTests:

Added new tests for alternatives that match without consuming
any input characters.

  • fast/js/regexp-zero-length-alternatives-expected.txt: Added.
  • fast/js/regexp-zero-length-alternatives.html: Added.
  • fast/js/script-tests/regexp-zero-length-alternatives.js: Added.
5:15 AM Changeset in webkit [107399] by pfeldman@chromium.org
  • 17 edits
    2 copies
    2 adds in trunk

Web Inspector: implement undo for setOuterHTML via undo-ing nested primitive commands.
​https://bugs.webkit.org/show_bug.cgi?id=78346

Reviewed by Yury Semikhatsky.

Source/WebCore:

Tests: inspector/elements/undo-set-outer-html-2.html

inspector/elements/undo-set-outer-html.html

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::RemoveChildAction::RemoveChildAction):
(WebCore::DOMEditor::InsertBeforeAction::InsertBeforeAction):
(WebCore::DOMEditor::InsertBeforeAction::undo):
(WebCore::DOMEditor::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::SetAttributeAction):
(WebCore::DOMEditor::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::DOMEditor::SetOuterHTMLAction::perform):
(WebCore::DOMEditor::SetOuterHTMLAction::undo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::ReplaceWholeTextAction):
(DOMEditor::ReplaceChildNodeAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::ReplaceChildNodeAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::perform):
(WebCore::DOMEditor::ReplaceChildNodeAction::undo):
(WebCore):
(DOMEditor::SetNodeValueAction):
(WebCore::DOMEditor::SetNodeValueAction::SetNodeValueAction):
(WebCore::DOMEditor::SetNodeValueAction::perform):
(WebCore::DOMEditor::SetNodeValueAction::undo):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::setAttribute):
(WebCore::DOMEditor::removeAttribute):
(WebCore::DOMEditor::setOuterHTML):
(WebCore::DOMEditor::replaceWholeText):
(WebCore::DOMEditor::replaceChild):
(WebCore::DOMEditor::setNodeValue):
(WebCore::populateErrorString):

  • inspector/DOMEditor.h:

(DOMEditor):

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):
(WebCore):
(WebCore::DOMPatchSupport::DOMPatchSupport):
(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::insertBeforeAndMarkAsUsed):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):

  • inspector/DOMPatchSupport.h:

(WebCore):
(DOMPatchSupport):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::toErrorString):
(WebCore):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::undo):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorHistory.cpp:

(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::undo):

  • inspector/InspectorHistory.h:

(WebCore):
(Action):
(InspectorHistory):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::setDocumentContent):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::toggleProperty):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):

  • inspector/InspectorStyleSheet.h:

(InspectorStyle):
(InspectorStyleSheet):

LayoutTests:

  • inspector/elements/set-outer-html-2-expected.txt:
  • inspector/elements/set-outer-html-test.js:

(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTMLUseUndo):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML.dumpIdentity):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML.callback):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML):
(initialize_SetOuterHTMLTest):

  • inspector/elements/undo-dom-edits-expected.txt:
  • inspector/elements/undo-set-outer-html-2-expected.txt: Copied from LayoutTests/inspector/elements/set-outer-html-2-expected.txt.
  • inspector/elements/undo-set-outer-html-2.html: Added.
  • inspector/elements/undo-set-outer-html-expected.txt: Copied from LayoutTests/inspector/elements/set-outer-html-2-expected.txt.
  • inspector/elements/undo-set-outer-html.html: Added.
5:04 AM Changeset in webkit [107398] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Refactor on Qt5 Layout tests' structure
​https://bugs.webkit.org/show_bug.cgi?id=77450

  • platform/qt-4.8/Skipped: Add after r107397, because it was missing accidentally.
4:48 AM Changeset in webkit [107397] by Csaba Osztrogonác
  • 6 edits
    2 moves in trunk

[Qt][WK2] Refactor on Qt5 Layout tests' structure
​https://bugs.webkit.org/show_bug.cgi?id=77450

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2012-02-10
Reviewed by Csaba Osztrogonác.

Tools:

Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
to qt-5.0-wk2 and qt-5.0-wk1.

  • Scripts/old-run-webkit-tests:

(buildPlatformResultHierarchy):
(readSkippedFiles):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._wk2_port_name):
(QtPort._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest.test_baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._wk2_port_name):

LayoutTests:

The folders qt-wk2 and qt-wk1 have been renamed to qt-5.0-wk2 and qt-5.0-wk1, respectively,
and the skipped list from qt-wk1 has been copied into qt-4.8/Skipped.

  • platform/qt-4.8/Skipped: Copy entries from platform/qt-wk1.
  • platform/qt-5.0-wk1/: Renamed from platform/qt-wk1.
  • platform/qt-5.0-wk2/: Renamed from platform/qt-wk1.
  • platform/qt-wk1/: Removed.
  • platform/qt-wk2/: Removed.
4:38 AM Changeset in webkit [107396] by haraken@chromium.org
  • 18 edits in trunk/Source/WebCore

Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
​https://bugs.webkit.org/show_bug.cgi?id=78327

Reviewed by Adam Barth.

This patch replaces [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack],
and removes [CustomArgumentHandling].

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm: Modified to replace

[CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack].
(GenerateCallWith):
(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateCallWith):

  • bindings/scripts/CodeGeneratorGObject.pm: Ditto.

(SkipFunction):
(GenerateFunction):

  • bindings/scripts/CodeGeneratorCPP.pm: Simply removed [CustomArgumentHandling]

from the skipped list. By this fix, CodeGeneratorCPP.pm will generate
meaningless code for attributes or methods which was previously marked as
[CustomArgumentHandling], but this change will be harmless.
(ShouldSkipType):

  • bindings/v8/custom/V8ConsoleCustom.cpp: Changed the argument order.

(WebCore::V8Console::assertCallback):

  • page/Console.cpp: Ditto.

(WebCore::Console::assertCondition):
(WebCore::Console::timeEnd):

  • page/Console.h: Ditto.

(Console):

  • bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=ScriptArguments|CallStack].
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::withScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::setWithScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::withScriptArgumentsAndCallStack):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_with_script_arguments_and_call_stack):
(webkit_dom_test_obj_get_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_set_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj withScriptArgumentsAndCallStackAttribute]):
(-[DOMTestObj setWithScriptArgumentsAndCallStackAttribute:]):
(-[DOMTestObj withScriptArgumentsAndCallStack]):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

3:51 AM Changeset in webkit [107395] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] KURL::fileSystemPath() doesn't work if uri contains #
​https://bugs.webkit.org/show_bug.cgi?id=78339

Reviewed by Philippe Normand.

  • platform/gtk/KURLGtk.cpp:

(WebCore::KURL::fileSystemPath): Use GFile API instead of
g_filename_from_uri() to convert the uri to a local
path. g_file_get_path() removes the anchor from the uri and
returns a valid path instead of NULL.

3:46 AM Changeset in webkit [107394] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

CodeGeneratorJS doesn't always generate visitChildren() implementation when required
​https://bugs.webkit.org/show_bug.cgi?id=78336

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-02-10
Reviewed by Kentaro Hara.

In an IDL for an interface that declares no functions, but has
attributes with [CachedAttribute], the implementation of visitChildren()
is not generated by the JSC code generator.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::visitChildren):
(WebCore):

3:25 AM Changeset in webkit [107393] by rniwa@webkit.org
  • 5 edits in trunk

Perf-o-matic build fix after r107386.

  • Websites/webkit-perf.appspot.com/app.yaml:
  • Websites/webkit-perf.appspot.com/controller.py:

(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):

  • Websites/webkit-perf.appspot.com/merge_tests_handler.py:

(MergeTestsHandler.get):

  • Websites/webkit-perf.appspot.com/report_logs_handler.py:

(ReportLogsHandler.get):
(ReportLogsHandler.post):

3:23 AM Changeset in webkit [107392] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
3:04 AM Changeset in webkit [107391] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline and skipping another svg test
presenting floating-point issues.

  • platform/gtk/Skipped:
  • platform/gtk/editing/execCommand/insertImage-expected.txt:
  • platform/gtk/security/block-test-expected.txt:
2:48 AM Changeset in webkit [107390] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

[Qt] GC should be parallel on Qt platform
​https://bugs.webkit.org/show_bug.cgi?id=73309

Patch by Roland Takacs <​takacs.roland@stud.u-szeged.hu> on 2012-02-10
Reviewed by Zoltan Herczeg.

These changes made the parallel gc feature available for Qt port.
The implementation of "registerGCThread" and "isMainThreadOrGCThread",
and a local static function [initializeGCThreads] is moved from
MainThreadMac.mm to the common MainThread.cpp to make them available
for other platforms.

Measurement results:
V8 speed-up: 1.025x as fast [From: 663.4ms To: 647.0ms ]
V8 Splay speed-up: 1.185x as fast [From: 138.4ms To: 116.8ms ]

Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.

(WTF::initializeMainThread):
(WTF):
(WTF::initializeGCThreads):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

  • wtf/MainThread.h:

(WTF):

  • wtf/Platform.h:
  • wtf/mac/MainThreadMac.mm:

(WTF):

2:46 AM Changeset in webkit [107389] by noel.gordon@gmail.com
  • 4 edits in trunk

[chromium] Increase JPEG decoding performance some more
​https://bugs.webkit.org/show_bug.cgi?id=78323

Reviewed by Adam Barth.

Source/WebCore:

Increase JPEG image decoding speed by another 9% (avg) according to libjpeg-turbo tjbench.

No new tests. Covered by many existing tests, all requiring subsequent rebaselines.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(dctMethod): Fast decode on the jpeg-turbo using ports (Chrome Android, Chrome, Chromium).
(WebCore::JPEGImageReader::decode): Select DCT method via a helper routine.

LayoutTests:

  • platform/chromium/test_expectations.txt: tests containing jpeg images that will require

rebaselines, mostly together in a group, but some other expectations unattended to at the
current time, spread changes throughout the file. The following lists changed tests for
chrome mac and win:

compositing/geometry/horizontal-scroll-composited.html
compositing/geometry/vertical-scroll-composited.html
compositing/overflow/overflow-scaled-descendant-overlapping.html
fast/backgrounds/size/backgroundSize17.html
fast/backgrounds/size/backgroundSize18.html
fast/backgrounds/size/backgroundSize19.html
fast/backgrounds/size/backgroundSize20.html
fast/backgrounds/size/backgroundSize21.html
fast/backgrounds/size/backgroundSize22.html
fast/block/float/014.html
fast/images/color-jpeg-with-color-profile.html
fast/images/gray-scale-jpeg-with-color-profile.html
fast/images/image-css3-content-data.html
fast/images/ycbcr-with-cmyk-color-profile.html
fast/repaint/backgroundSizeRepaint.html
fast/repaint/block-layout-inline-children-replaced.html
fast/repaint/clipped-relative.html
fast/repaint/selected-replaced.html
fast/replaced/absolute-image-sizing.html
fast/replaced/image-onload.html
fast/replaced/image-sizing.html
fast/replaced/image-tag.html
fast/replaced/width100percent-image.html
fast/writing-mode/background-horizontal-bt.html
fast/writing-mode/background-vertical-lr.html
fast/writing-mode/background-vertical-rl.html
platform/chromium/compositing/img-layer-grow.html
svg/W3C-SVG-1.1/animate-elem-30-t.svg
svg/W3C-SVG-1.1/animate-elem-36-t.svg
svg/W3C-SVG-1.1/animate-elem-39-t.svg
svg/W3C-SVG-1.1/animate-elem-40-t.svg
svg/W3C-SVG-1.1/coords-viewattr-02-b.svg
svg/W3C-SVG-1.1/filters-image-01-b.svg
svg/W3C-SVG-1.1/struct-image-01-t.svg
svg/W3C-SVG-1.1/struct-image-02-b.svg
svg/W3C-SVG-1.1/struct-image-04-t.svg
svg/carto.net/scrollbar.svg
svg/carto.net/selectionlist.svg
svg/custom/image-rescale-clip.html
svg/custom/image-rescale-scroll.html
svg/custom/image-rescale.svg
svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html
svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html
tables/mozilla/bugs/bug101674.html
tables/mozilla/bugs/bug10565.html
tables/mozilla/bugs/bug11026.html
tables/mozilla/bugs/bug1188.html
tables/mozilla/bugs/bug120107.html
tables/mozilla/bugs/bug1271.html
tables/mozilla/bugs/bug12908-1.html
tables/mozilla/bugs/bug12908-2.html
tables/mozilla/bugs/bug1296.html
tables/mozilla/bugs/bug13169.html
tables/mozilla/bugs/bug1430.html
tables/mozilla/bugs/bug15544.html
tables/mozilla/bugs/bug17138.html
tables/mozilla/bugs/bug196870.html
tables/mozilla/bugs/bug29314.html
tables/mozilla/bugs/bug2981-2.html
tables/mozilla/bugs/bug4093.html
tables/mozilla/bugs/bug4284.html
tables/mozilla/bugs/bug4427.html
tables/mozilla/bugs/bug50695-2.html
tables/mozilla/bugs/bug56563.html
tables/mozilla/bugs/bug5797.html
tables/mozilla/bugs/bug625.html
tables/mozilla/bugs/bug6404.html
tables/mozilla/bugs/bug82946-2.html
tables/mozilla/bugs/bug86708.html
tables/mozilla/core/bloomberg.html
tables/mozilla/core/col_widths_auto_autoFix.html
tables/mozilla/core/misc.html
tables/mozilla/core/row_span.html
tables/mozilla/marvin/tbody_valign_baseline.html
tables/mozilla/marvin/tbody_valign_bottom.html
tables/mozilla/marvin/tbody_valign_middle.html
tables/mozilla/marvin/tbody_valign_top.html
tables/mozilla/marvin/td_valign_baseline.html
tables/mozilla/marvin/td_valign_bottom.html
tables/mozilla/marvin/td_valign_middle.html
tables/mozilla/marvin/td_valign_top.html
tables/mozilla/marvin/tfoot_valign_baseline.html
tables/mozilla/marvin/tfoot_valign_bottom.html
tables/mozilla/marvin/tfoot_valign_middle.html
tables/mozilla/marvin/tfoot_valign_top.html
tables/mozilla/marvin/th_valign_baseline.html
tables/mozilla/marvin/th_valign_bottom.html
tables/mozilla/marvin/th_valign_middle.html
tables/mozilla/marvin/th_valign_top.html
tables/mozilla/marvin/thead_valign_baseline.html
tables/mozilla/marvin/thead_valign_bottom.html
tables/mozilla/marvin/thead_valign_middle.html
tables/mozilla/marvin/thead_valign_top.html
tables/mozilla/marvin/tr_valign_baseline.html
tables/mozilla/marvin/tr_valign_bottom.html
tables/mozilla/marvin/tr_valign_middle.html
tables/mozilla/marvin/tr_valign_top.html
tables/mozilla/other/cell_widths.html
tables/mozilla_expected_failures/bugs/bug6933.html
tables/mozilla_expected_failures/bugs/bug85016.html
tables/mozilla_expected_failures/other/test4.html

2:10 AM Changeset in webkit [107388] by podivilov@chromium.org
  • 3 edits
    3 deletes in trunk/LayoutTests

Unreviewed, rebaseline svg/carto.net/selectionlist.svg.

  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt: Removed.
  • platform/chromium-win-xp/svg/carto.net/selectionlist-expected.png: Removed.
  • platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Removed.
2:02 AM Changeset in webkit [107387] by podivilov@chromium.org
  • 4 edits
    1 copy
    1 delete in trunk/LayoutTests

Unreviewed, rebaseline svg/carto.net/scrollbar-expected.png on chromium mac.

  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt:
  • platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.txt: Copied from LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt.
  • platform/mac/svg/carto.net/scrollbar-expected.png: Removed.
1:56 AM Changeset in webkit [107386] by rniwa@webkit.org
  • 6 edits
    1 copy
    1 move
    2 adds in trunk

Perf-o-matic should process reports in background
​https://bugs.webkit.org/show_bug.cgi?id=78309

Reviewed by Hajime Morita.

Split the logic to create Build, Test, and TestResult objects from ReportHandler into ReportProcessHandler.
ReportHandler now merely creates ReportLog and schedules a task to process it.

Also added ReportLogHandler to manage stale ReportLogs.

  • Websites/webkit-perf.appspot.com/app.yaml:
  • Websites/webkit-perf.appspot.com/controller.py:

(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):
(CachedRunsHandler.get):
(schedule_report_process):

  • Websites/webkit-perf.appspot.com/main.py:
  • Websites/webkit-perf.appspot.com/merge_tests.html: Renamed from Websites/webkit-perf.appspot.com/merge_tests.yaml.
  • Websites/webkit-perf.appspot.com/models.py:

(ReportLog):
(ReportLog._parsed_payload):
(ReportLog.get_value):
(ReportLog.results):
(ReportLog.builder):
(ReportLog.branch):
(ReportLog.platform):
(ReportLog.build_number):
(ReportLog.webkit_revision):
(ReportLog.chromium_revision):
(ReportLog._model_by_key_name_in_payload):
(ReportLog._integer_in_payload):
(ReportLog.timestamp):

  • Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):
(ReportHandler._output):
(ReportHandler._results_are_valid):
(ReportHandler._results_are_valid._is_float_convertible):
(ReportHandler):

  • Websites/webkit-perf.appspot.com/report_logs.html: Added.
  • Websites/webkit-perf.appspot.com/report_logs_handler.py: Added.

(ReportLogsHandler):
(ReportLogsHandler.get):
(ReportLogsHandler.post):
(ReportLogsHandler._error):

  • Websites/webkit-perf.appspot.com/report_process_handler.py: Copied from Websites/webkit-perf.appspot.com/report_handler.py.

(ReportProcessHandler):
(ReportProcessHandler.post):
(ReportProcessHandler._create_build_if_possible):
(ReportProcessHandler._create_build_if_possible.execute):
(ReportProcessHandler._add_test_if_needed):

1:41 AM Changeset in webkit [107385] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed test fix following r107373.
​https://bugs.webkit.org/show_bug.cgi?id=78254

This also resolves ​https://bugs.webkit.org/show_bug.cgi?id=77416.

  • inspector/timeline/timeline-receive-response-event.html:
  • platform/chromium/test_expectations.txt:
1:34 AM Changeset in webkit [107384] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: FileSelector should not depend on DebuggerPresentationModel.
​https://bugs.webkit.org/show_bug.cgi?id=78337

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype.reset):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.FileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.FileSelector.prototype.reset):
(WebInspector.ScriptsPanel.ComboBoxFileSelector):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.reset):

1:29 AM Changeset in webkit [107383] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed attempt to fix the test failure.

  • editing/spelling/spelling-marker-description.html:
1:28 AM Changeset in webkit [107382] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove [ConvertingNullStringTo] from CloseEvent.idl
​https://bugs.webkit.org/show_bug.cgi?id=78328

Reviewed by Adam Barth.

In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
(although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).

Anyway, the spec says that "The reason attribute must return the value it was
initialized to. When the object is created, this attribute must be initialized to empty string."
​http://dev.w3.org/html5/websockets/#event-definitions
Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.

Test: fast/events/constructors/close-event-constructor.html

  • websockets/CloseEvent.idl:
1:13 AM Changeset in webkit [107381] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-10 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix error in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
1:06 AM Changeset in webkit [107380] by pfeldman@chromium.org
  • 5 edits in trunk

[Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=78330

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::innerPatchChildren):

LayoutTests:

  • platform/chromium/test_expectations.txt:
1:04 AM Changeset in webkit [107379] by abarth@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests
  • platform/chromium-mac/storage/domstorage/quota-expected.txt: Removed.
  • platform/chromium-win/storage/domstorage/quota-expected.txt: Removed.
    • These baselines are wrong. Removing them shows that we pass this test now.
  • platform/chromium/test_expectations.txt:
    • According to the flakiness dashboard, these tests always pass now.
12:56 AM Changeset in webkit [107378] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip new asserting tests to paint the debug bot green.

  • platform/qt/Skipped:
12:52 AM Changeset in webkit [107377] by abarth@webkit.org
  • 52 edits
    54 adds
    36 deletes in trunk/LayoutTests

Update a large number of baselines for svg/custom. These baselines all
appear to be correct (or at least no less correct than the previous
baselines). There are a number of svg/custom tests that appear to be
actually failing, which I haven't rebaselined.

This patch does not update the test_expectations.txt file. Once this
patch has cycled through the bots, I'll clean up the expectations file
as appropriate.

  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/SVGPoint-matrixTransform-expected.png:
  • platform/chromium-linux/svg/custom/absolute-root-position-masking-expected.png: Added.
  • platform/chromium-linux/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
  • platform/chromium-linux/svg/custom/getTransformToElement-expected.png:
  • platform/chromium-linux/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-linux/svg/custom/js-update-style-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/marker-changes-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-linux/svg/custom/text-ctm-expected.png:
  • platform/chromium-linux/svg/custom/text-hit-test-expected.png:
  • platform/chromium-linux/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/use-font-face-crash-expected.png: Added.
  • platform/chromium-linux/svg/custom/use-property-changes-through-svg-dom-expected.png:
  • platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac-leopard/svg/custom/getTransformToElement-expected.png:
  • platform/chromium-mac-leopard/svg/custom/path-bad-data-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/path-bad-data-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/use-invalid-pattern-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/use-invalid-style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/absolute-root-position-masking-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/getTransformToElement-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/gradient-stroke-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/path-bad-data-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-text-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/repaint-on-image-bounds-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-font-face-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-forward-refs-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
  • platform/chromium-mac/svg/custom/gradient-stroke-width-expected.png: Removed.
  • platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png: Removed.
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png: Removed.
  • platform/chromium-mac/svg/custom/pointer-events-text-expected.png: Removed.
  • platform/chromium-mac/svg/custom/svg-fonts-fallback-expected.png: Removed.
  • platform/chromium-mac/svg/custom/svg-fonts-without-missing-glyph-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-font-face-crash-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-forward-refs-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win/svg/custom/SVGPoint-matrixTransform-expected.png:
  • platform/chromium-win/svg/custom/SVGPoint-matrixTransform-expected.txt:
  • platform/chromium-win/svg/custom/absolute-root-position-masking-expected.png: Added.
  • platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
  • platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-win/svg/custom/getTransformToElement-expected.png:
  • platform/chromium-win/svg/custom/getTransformToElement-expected.txt:
  • platform/chromium-win/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-win/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
  • platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/chromium-win/svg/custom/linking-uri-01-b-expected.png:
  • platform/chromium-win/svg/custom/marker-changes-expected.png: Added.
  • platform/chromium-win/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-image-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-win/svg/custom/text-ctm-expected.png:
  • platform/chromium-win/svg/custom/text-ctm-expected.txt:
  • platform/chromium-win/svg/custom/text-hit-test-expected.png:
  • platform/chromium-win/svg/custom/text-hit-test-expected.txt:
  • platform/chromium-win/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.png: Added.
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.txt: Added.
  • platform/chromium-win/svg/custom/use-forward-refs-expected.png:
  • platform/chromium/svg/custom/js-update-style-expected.txt: Removed.
  • platform/gtk/svg/custom/absolute-root-position-masking-expected.txt: Removed.
  • platform/gtk/svg/custom/gradient-stroke-width-expected.txt: Removed.
  • platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
  • platform/gtk/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
  • platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
  • platform/gtk/svg/custom/use-forward-refs-expected.txt: Removed.
  • platform/gtk/svg/custom/use-invalid-style-expected.txt: Removed.
  • platform/gtk/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
  • platform/mac/svg/custom/absolute-root-position-masking-expected.png: Removed.
  • platform/mac/svg/custom/absolute-root-position-masking-expected.txt: Removed.
  • platform/mac/svg/custom/gradient-stroke-width-expected.txt: Removed.
  • platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
  • platform/mac/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
  • platform/mac/svg/custom/use-forward-refs-expected.txt: Removed.
  • platform/mac/svg/custom/use-invalid-style-expected.txt: Removed.
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
  • platform/qt/svg/custom/absolute-root-position-masking-expected.png: Removed.
  • platform/qt/svg/custom/absolute-root-position-masking-expected.txt: Removed.
  • platform/qt/svg/custom/gradient-stroke-width-expected.txt: Removed.
  • platform/qt/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
  • platform/qt/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
  • platform/qt/svg/custom/use-forward-refs-expected.txt: Removed.
  • platform/qt/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
  • svg/custom/absolute-root-position-masking-expected.png: Added.
  • svg/custom/absolute-root-position-masking-expected.txt: Added.
  • svg/custom/gradient-stroke-width-expected.txt: Added.
  • svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
  • svg/custom/repaint-on-image-bounds-change-expected.txt: Added.
  • svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • svg/custom/use-forward-refs-expected.txt: Added.
  • svg/custom/use-invalid-style-expected.txt: Added.
  • svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Added.
12:32 AM Changeset in webkit [107376] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-10 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, gardening, mark editing/spelling/spelling-marker-description.html as failing.

  • platform/chromium/test_expectations.txt:
12:21 AM Changeset in webkit [107375] by abarth@webkit.org
  • 31 edits
    8 adds
    5 deletes in trunk/LayoutTests

Update baselines for svg/batik. These baselines either look quite
similar to the previous baselines or look like improvements (e.g., text
masking seems to work now).

  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textEffect-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/text/textEffect3-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/xmlSpace-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/xmlSpace-expected.png: Added.
  • platform/chromium-mac/svg/batik/filters: Removed.
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png: Removed.
  • platform/chromium-mac/svg/batik/text/textStyles-expected.png: Removed.
  • platform/chromium-mac/svg/batik/text/verticalText-expected.png: Removed.
  • platform/chromium-mac/svg/batik/text/xmlSpace-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/masking: Removed.
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win/svg/batik/text/textPCDATA-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium/test_expectations.txt:
12:05 AM Changeset in webkit [107374] by Philippe Normand
  • 3 edits in trunk/Tools

[GTK] EWS command-line option to run the tests
​https://bugs.webkit.org/show_bug.cgi?id=78211

Reviewed by Adam Barth.

New --run-tests option (defaults to False) for the EWS commands.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.review_patch):
(ChromiumLinuxEWS):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest._test_builder_ews):

12:05 AM Changeset in webkit [107373] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [refactoring] TimelineModel should not depend on TimelinePanel
​https://bugs.webkit.org/show_bug.cgi?id=78254

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._loadFromFile):
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype.startRecord):
(WebInspector.TimelineModel.prototype.stopRecord):
(WebInspector.TimelineModel.prototype._onRecordAdded):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype._loadFromFile):
(WebInspector.TimelineModel.prototype._reset):

Note: See TracTimeline for information about the timeline view.