Timeline
Oct 29, 2012:
- 11:56 PM Changeset in webkit [132873] by
-
- 7 edits in trunk
Unreviewed, rolling out r132819.
http://trac.webkit.org/changeset/132819
https://bugs.webkit.org/show_bug.cgi?id=100388
It made layout testing 40% slower and storage tests assert
Tools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::dump):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::reset):
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
LayoutTests:
- platform/qt/TestExpectations:
- 11:43 PM Changeset in webkit [132872] by
-
- 2 edits in trunk/Tools
[chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build
https://bugs.webkit.org/show_bug.cgi?id=100658
Reviewed by Tony Chang.
Before, this was compiled into DumpRenderTree. I also dropped the
include_dirs and dependencies block as TestRunner already has them.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 8:49 PM Changeset in webkit [132871] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Null-check WebViewImpl::m_client before calling invalidateRect() on it
https://bugs.webkit.org/show_bug.cgi?id=100716
Patch by James Robinson <jamesr@chromium.org> on 2012-10-29
Reviewed by Dirk Pranke.
This check was accidentally removed in r132862 and the value is null in at least some unit tests.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::invalidateRect):
- 8:42 PM Changeset in webkit [132870] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=98864
Reviewed by Martin Robinson.
Use a dedicated directory to store WebKit2 generated resources.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/TestMain.cpp:
(registerGResource): load the resource from the new directory.
- 8:34 PM Changeset in webkit [132869] by
-
- 2 edits in trunk/Source/WebCore
Fix a typo that caused SVG external resources to be blocked on
platforms other than Chromium.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
- 7:39 PM Changeset in webkit [132868] by
-
- 2 edits in trunk/Source/WebCore
NSLocale leaks in LocaleMac
https://bugs.webkit.org/show_bug.cgi?id=97628
Reviewed by Kent Tamura.
We need to adopt the NSLocale object so it doesn't leak and
determineLocale() should return a NSLocale without additional retain.
No new tests.
- platform/text/mac/LocaleMac.mm:
(WebCore::determineLocale): Returns a RetainPtr<NSLocale>.
(WebCore::Locale::create):
(WebCore::LocaleMac::LocaleMac): m_locale should adopt the NSLocale object.
(WebCore::LocaleMac::create): LocaleMac constructor takes NSLocale without additional retain.
- 7:37 PM Changeset in webkit [132867] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Disable redirect to data scheme for potential fishing.
https://bugs.webkit.org/show_bug.cgi?id=100713
Reviewed by George Staikos.
We will disable redirect to data scheme to avoid potential security concern,
described in klevjers.com/papers/phishing.pdf.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleRedirect):
- 6:58 PM Changeset in webkit [132866] by
-
- 1 edit in trunk/Tools/ChangeLog
Updated ChangeLog.
- 6:58 PM Changeset in webkit [132865] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Added myself as a committer.
- 5:05 PM Changeset in webkit [132864] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r132845.
http://trac.webkit.org/changeset/132845
https://bugs.webkit.org/show_bug.cgi?id=99975
Broke chromium builds, linker errors from
IDBBindingUtilitiesTest
Source/WebCore:
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore):
(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::idbKeyToScriptValue):
- bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::ensureAuxiliaryContext):
(WebCore):
- bindings/v8/V8PerIsolateData.h:
(V8PerIsolateData):
Source/WebKit/chromium:
- tests/IDBBindingUtilitiesTest.cpp:
(WebCore::TEST):
- 5:04 PM WebKit Team edited by
- add myself (Jonathan Dong) into committers list. (diff)
- 4:57 PM Changeset in webkit [132863] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build.
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::setHeaderFields):
- 4:49 PM Changeset in webkit [132862] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Defer commits between page unload and first invalidation in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=100702
Reviewed by Adrienne Walker.
In threaded compositing mode, it's not terribly useful to commit after unloading a page and before receiving
the first invalidation for the new page since the document is likely not loaded enough to paint usefully.
This defers commits from the time compositing is deactivated (which in force compositing mode only happens
at FrameView destruction) until we get the first invalidation from WebCore.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::invalidateContentsAndRootView):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::invalidateRect):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- 4:38 PM Changeset in webkit [132861] by
-
- 2 edits in trunk/Source/WebKit2
Coordinated Graphics: Delete cached ShareableSurfaces when purging backingStores.
https://bugs.webkit.org/show_bug.cgi?id=100705
Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-29
Reviewed by Noam Rosenthal.
LayerTreeCoordinatorProxy can be used after calling
LayerTreeCoordinatorProxy::purgeBackingStores(). So we should clear cached
ShareableSurfaces.
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):
- 4:36 PM Changeset in webkit [132860] by
-
- 32 edits in trunk
Simplify Xcode configuration settings that used to vary between OS versions.
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/JavaScriptCore.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/WebKit2.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 4:35 PM Changeset in webkit [132859] by
-
- 45 edits11 deletes in trunk
Remove references to unsupported OS and Xcode versions.
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Removed.
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
Source/ThirdParty:
- gtest/xcode/Config/CompilerVersion.xcconfig: Removed.
- gtest/xcode/Config/General.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Removed.
- Configurations/DebugRelease.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Removed.
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebCore.xcconfig:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Removed.
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Removed.
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- DerivedSources.make:
- WebKit2.xcodeproj/project.pbxproj:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig: Removed.
- Configurations/DebugRelease.xcconfig:
- WTF.xcodeproj/project.pbxproj:
Tools:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Removed.
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/CompilerVersion.xcconfig: Removed.
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Removed.
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Removed.
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 4:22 PM Changeset in webkit [132858] by
-
- 9 edits1 add in trunk/Source
AtomicString(CFStringRef) shouldn't unconditionally create a StringImpl
https://bugs.webkit.org/show_bug.cgi?id=100701
Reviewed by Dan Bernstein.
Source/WebCore:
- WebCore.exp.in:
Export AtomicString::add(CFStringRef).
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Add AtomicStringCF.cpp
- platform/text/cf/AtomicStringCF.cpp: Added.
(WTF::AtomicString::add):
When trying to add the atomic string to the table, first try to get a Latin-1 pointer
from the string. Second, try to get a Unicode pointer from the string.
If that also fails, copy the string to a temporary unicode buffer and add it from there.
- platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForKey):
Update for AtomicString::createCFString being removed.
Source/WTF:
- wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
Change the constructors that take a CFStringRef and an NSString * to call AtomicString::add(CFStringRef)
and remove AtomicString::createCFString.
(WTF::AtomicString::add):
Add new member function declaration. The definition is in a new file in WebCore, AtomicStringCF.cpp.
Also, fix the overload of add that takes a const char* to call the right other overload instead of itself.
- 4:18 PM Changeset in webkit [132857] by
-
- 2 edits2 adds in trunk/Source/WebKit2
[WK2] Add a NetworkingContext for NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=100708
Reviewed by Anders Carlsson.
Each request will have a context, because these are so lightweight on Mac, and
other platforms will need ResourceHandle refactored anyway to use NetworkProcess.
- NetworkProcess/mac/RemoteNetworkingContext.h: Added.
- NetworkProcess/mac/RemoteNetworkingContext.mm: Added. These go mac/ subdirectory, because NetworkingContext interface is different on each platform, as ResourceHandle needs dictate.
- WebKit2.xcodeproj/project.pbxproj:
- 4:15 PM Changeset in webkit [132856] by
-
- 5 edits2 adds in trunk
feImage should not be allowed to self reference
https://bugs.webkit.org/show_bug.cgi?id=94652
Reviewed by Eric Seidel.
Source/WebCore:
Add cycle detection for SVG filter application, and also fix a problem
with graphics context restore when filters are applied. This also
converts the flags in FilterData to a state tracking system, as the
number of flags was getting messy and only one flag is valid at any given time.
Test: svg/filters/feImage-self-and-other-referencing.html
- rendering/svg/RenderSVGResourceFilter.cpp: Convert to new FilterData
state management and enable cycle detection.
(WebCore):
(WebCore::RenderSVGResourceFilter::removeClientFromCache): Change isBuilt and markedForRemoval flags to state enums.
(WebCore::RenderSVGResourceFilter::applyResource): Change flags to state enums and detect cycles.
(WebCore::RenderSVGResourceFilter::postApplyResource): Change flags to state and add handling
for the various states.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged): Change isBuilt flag to state enums.
- rendering/svg/RenderSVGResourceFilter.h:
(WebCore::FilterData::FilterData):
(FilterData): Convert to a state tracking system.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced): Add a block around the
SVGRenderingContext so that it applies the filter and reverts the
context before the calling method restores the context.
LayoutTests:
Additional test case for situations when the filter is applied to multiple objects that it also references.
- svg/filters/feImage-self-and-other-referencing-expected.html: Added.
- svg/filters/feImage-self-and-other-referencing.html: Added.
- 4:10 PM Changeset in webkit [132855] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 3:56 PM Changeset in webkit [132854] by
-
- 2 edits in trunk/Source/WTF
Unreviewed. Correct my previous patch to disable external SVG
references only on PLATFORM(CHROMIUM).
- wtf/Platform.h:
- 3:50 PM Changeset in webkit [132853] by
-
- 3 edits3 adds in trunk
Non-special escape character sequences cause JSC::Lexer::parseString to create 16 bit strings
https://bugs.webkit.org/show_bug.cgi?id=100576
Reviewed by Darin Adler.
Source/JavaScriptCore:
Changed singleEscape() processing to be based on a lookup of a static table. The table
covers ASCII characters SPACE through DEL. If a character can be a single character escape,
then the table provides the non-zero result of that escape. Updated the result of
singleEscape to be an LChar to make the table as small as possible.
Added a new test fast/js/normal-character-escapes-in-string-literals.html to validated
the behavior.
- parser/Lexer.cpp:
(JSC::singleEscape):
(JSC::Lexer::parseString):
(JSC::Lexer::parseStringSlowCase):
LayoutTests:
Added a new test to validated the behavior of the corresponding changes to string processing
in the Lexer.
- fast/js/normal-character-escapes-in-string-literals-expected.txt: Added.
- fast/js/normal-character-escapes-in-string-literals.html: Added.
- fast/js/script-tests/normal-character-escapes-in-string-literals.js: Added.
- 3:35 PM Changeset in webkit [132852] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/12592716> REGRESSION (r132545): With full-page accelerated drawing, a
reproducible hang occurs at <http://www.cbsnews.com/stories/2010/01/24/ftn/main6136386.shtml>.
Reviewed by Anders Carlsson.
Work around <rdar://problem/12584492> by limiting the scope of the fix for <http://webkit.org/b/100413>.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::clipOut): Reverted to using CGContextGetClipBoundingBox() rather
than CGRectInfinite when the context is accelerated and has a transform that is not just
a translation or a scale.
- 2:53 PM Changeset in webkit [132851] by
-
- 5 edits in trunk/Source
[BlackBerry] Simplify AuthenticationChallengeManager::instance
https://bugs.webkit.org/show_bug.cgi?id=100614
Reviewed by Yong Li.
Internally reviewed by Lyon Chen.
Source/WebCore:
Use a standard Singleton pattern here, this makes sure we create lazily.
- platform/blackberry/AuthenticationChallengeManager.cpp:
(WebCore):
- platform/blackberry/AuthenticationChallengeManager.h:
(AuthenticationChallengeManager):
Source/WebKit/blackberry:
No need to call AuthenticationChallengeManager::init anymore.
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
- 2:36 PM Changeset in webkit [132850] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Feature introduced in r132708 is chromium only. Skipping related tests.
- platform/win/TestExpectations:
- 2:23 PM Changeset in webkit [132849] by
-
- 7 edits in trunk
Block SVG external references pending a security review
https://bugs.webkit.org/show_bug.cgi?id=100635
Reviewed by Eric Seidel.
Source/WebCore:
We need to do a security review of loading external SVG references
before we're sure that it is safe.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createFilterOperations):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
Source/WTF:
We need to do a security review of loading external SVG references
before we're sure that it is safe.
- wtf/Platform.h:
LayoutTests:
Skip tests that depend on external SVG references.
- platform/chromium/TestExpectations:
- 2:20 PM Changeset in webkit [132848] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Crash on checking version of corrupt backing store
https://bugs.webkit.org/show_bug.cgi?id=100692
Reviewed by Tony Chang.
If the backing store fails to open (due to corruption, non-writeable disk, etc)
the subsequent schema version check dereferences a null pointer. Fix to only
do the schema check if the database opened.
Chromium tests will be included with crrev.com/11196029
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::open):
- 2:07 PM Changeset in webkit [132847] by
-
- 7 edits in trunk/Source/WebCore
Let SVGElements have pending resources.
https://bugs.webkit.org/show_bug.cgi?id=99694
Reviewed by Eric Seidel.
Our SVG pending resource tracking is used for handling dynamic id changes. For example,
if an SVG element references an id that is not yet in the document (or has been removed),
the SVG element will be 'pending' an id. When styled elements are inserted into
the document, buildPendingResourcesIfNeeded() is called to force any pending elements
to resolve their dependencies. Only SVGStyledElement targets can be referenced using
this infrastructure, and that is not changed with this patch.
Previously, only SVGStyledElements could have pending resources. Some examples of where
this is violated are SVGAnimateElement and SVGMPathElement which are not a styled elements
but which can have pending references (they can reference styled elements and
paths, respectively). This patch changes the pending resource handling to allow
any SVGElement to have pending resources.
This patch is only a refactoring of code in preparation for WK99694 and does not
affect existing functionality or tests.
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval):
- svg/SVGDocumentExtensions.h:
(WebCore):
(SVGDocumentExtensions):
- svg/SVGElement.cpp:
(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::removedFrom):
(WebCore::SVGElement::hasPendingResources):
(WebCore):
(WebCore::SVGElement::setHasPendingResources):
(WebCore::SVGElement::clearHasPendingResourcesIfPossible):
- svg/SVGElement.h:
(SVGElement):
(WebCore::SVGElement::buildPendingResource):
- svg/SVGStyledElement.cpp:
(WebCore):
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
(WebCore::SVGStyledElement::removedFrom):
- svg/SVGStyledElement.h:
(SVGStyledElement):
(WebCore::SVGStyledElement::selfHasRelativeLengths):
- 2:06 PM Changeset in webkit [132846] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed rebaseline of webaudio/audiobuffersource-loop-points
- platform/chromium-win-xp/webaudio/audiobuffersource-loop-points-expected.wav: Added.
- platform/chromium-win/webaudio/audiobuffersource-loop-points-expected.wav: Added.
- 2:05 PM Changeset in webkit [132845] by
-
- 8 edits in trunk/Source
Remove ensureAuxiliaryContext
https://bugs.webkit.org/show_bug.cgi?id=99975
Patch by Dan Carney <dcarney@google.com> on 2012-10-29
Reviewed by Adam Barth.
Source/WebCore:
Removed auxilliaryContext as use if it is problematic in IDB.
No new tests. No change in functionality.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::setValueReady):
- Modules/indexeddb/IDBCursor.h:
(IDBCursor):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::put):
(WebCore):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):
- bindings/v8/IDBBindingUtilities.h:
(WebCore):
- bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
(WebCore):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8PerIsolateData.cpp:
(WebCore):
- bindings/v8/V8PerIsolateData.h:
Source/WebKit/chromium:
Updated tests to use correct v8 context.
- tests/IDBBindingUtilitiesTest.cpp:
(WebKit::checkKeyFromValueAndKeyPathInternal):
(WebKit::checkKeyPathNullValue):
(WebKit::injectKey):
(WebKit::checkInjection):
(WebKit::checkInjectionFails):
(WebKit::checkKeyPathStringValue):
(WebKit::checkKeyPathNumberValue):
(WebKit::scriptExecutionContext):
(WebKit):
(WebKit::TEST):
- 1:57 PM Changeset in webkit [132844] by
-
- 3 edits3 adds in trunk
[skia] Handle mask box image.
https://bugs.webkit.org/show_bug.cgi?id=100570
Reviewed by James Robinson.
Source/WebCore:
When drawing an image with source rectangle it should intersect with image rectangle.
This should be the case for drawing single image and tiling an image.
Test: fast/images/mask-box-image-crash.html
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):
LayoutTests:
Added a test for -webkit-mask-box-image. Test should complete without crashes.
Output image should be blank.
- fast/images/mask-box-image-crash-expected.png: Added.
- fast/images/mask-box-image-crash-expected.txt: Added.
- fast/images/mask-box-image-crash.html: Added.
- 1:16 PM Changeset in webkit [132843] by
-
- 5 edits2 adds in trunk/LayoutTests
Unreviewed gardening. LayoutTests/mathml/msubsup-fuzz.html passes locally but not on
cr-linux-ews. I need to see a stack trace to debug it. See webkit.org/b/100463.
- mathml/msubsup-fuzz-expected.txt: Added.
- mathml/msubsup-fuzz.html: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- 1:01 PM Changeset in webkit [132842] by
-
- 4 edits in trunk/Source/WebCore
Support captions when PLUGIN_PROXY_FOR_VIDEO
https://bugs.webkit.org/show_bug.cgi?id=100690
Reviewed by Simon Fraser.
When built with PLUGIN_PROXY_FOR_VIDEO, WebCore uses a plug-in for the media element's
platform media engine. Update this code path so the shadow DOM elements used to display
text tracks are created and configured correctly.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureMediaControls): Create media controls if necessary.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout): Set the position and size of the shadow DOM when the
position of the embedded element changes.
- rendering/RenderEmbeddedObject.h:
- 12:59 PM Changeset in webkit [132841] by
-
- 2 edits in trunk/Source/WebKit2
buildHTTPHeaders() should use a StringBuilder.appendLiteral() for separator
https://bugs.webkit.org/show_bug.cgi?id=100689
Reviewed by Darin Adler.
Changed from using a String temporary for the separator to using StringBuilder.appendLiteral(": ").
- WebProcess/Plugins/PluginView.cpp:
(WebKit::buildHTTPHeaders):
- 12:54 PM Changeset in webkit [132840] by
-
- 3 edits in trunk/Tools
webkitpy: change non-verbose log format for webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=100561
Reviewed by Ojan Vafai.
Logging the module name and the log level is annoying and nearly useless.
For starters, this change removes that unless you are doing verbose/
debug logging. In the future we should split out the concepts of
verbose and debug logging (like we did in test-webkitpy and
run-webkit-tests) so that you could get this in debug logging.
- Scripts/webkitpy/common/system/logutils.py:
(_default_handlers):
(configure_logging):
- Scripts/webkitpy/common/system/logutils_unittest.py:
(ConfigureLoggingTest.test_info_message):
(ConfigureLoggingTest):
(ConfigureLoggingTest.test_debug_message):
(ConfigureLoggingTest.test_two_messages):
(ConfigureLoggingVerboseTest):
(ConfigureLoggingVerboseTest._logging_level):
(ConfigureLoggingVerboseTest.test_info_message):
(ConfigureLoggingVerboseTest.test_debug_message):
(ConfigureLoggingCustomLevelTest.test_logged_message):
- 12:37 PM Changeset in webkit [132839] by
-
- 4 edits in trunk
[Chromium] flickering observed when copying 2D canvas to webGL texture
https://bugs.webkit.org/show_bug.cgi?id=100691
Reviewed by Stephen White.
Source/WebCore:
Added a flush to the webgl context after texture upload from an image
buffer to ensure proper graphics context synchronization with respect
to subsequent changes to the source image.
Tests: fast/canvas/webgl/canvas-2d-webgl-texture.html
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyToPlatformTexture):
LayoutTests:
Modified test by adding a canvas draw imediately after webgl texture
upload in order to exercise graphics context synchronization between
the webGL and 2D canvas graphics contexts.
- fast/canvas/webgl/canvas-2d-webgl-texture.html:
- 12:29 PM Changeset in webkit [132838] by
-
- 3 edits2 copies in branches/chromium/1271
Merge 132724
BUG=157363
Review URL: https://codereview.chromium.org/11340016
- 12:22 PM Changeset in webkit [132837] by
-
- 2 edits2 copies in branches/chromium/1271
Merge 132420
BUG=157462
Review URL: https://codereview.chromium.org/11339018
- 12:06 PM Changeset in webkit [132836] by
-
- 4 edits3 copies in branches/chromium/1271
Merge 132528
BUG=151854
Review URL: https://codereview.chromium.org/11337009
- 12:01 PM Changeset in webkit [132835] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/inspector/InspectorStyleSheet.cpp
Merge 132462
BUG=157778
Review URL: https://codereview.chromium.org/11348012
- 12:00 PM Changeset in webkit [132834] by
-
- 5 edits4 adds in trunk
[CSSOM] Extraneous whitespace in CSSImportRule.cssText
https://bugs.webkit.org/show_bug.cgi?id=100657
Patch by Glenn Adams <glenn@skynav.com> on 2012-10-29
Reviewed by Simon Fraser.
Source/WebCore:
Remove extraneous whitespace when serializing CSSImportRule.cssText when
media list is empty.
Test: cssom/cssimportrule-media.html
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::cssText):
Don't append extra whitespace if mediaText is empty.
LayoutTests:
Test (from CSS WG) that checks serializion of CSSImportRule.cssText.
- http/tests/css/shared-stylesheet-mutation-expected.txt:
- http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:
Fix expected output to match removal of extraneous space.
- cssom/cssimportrule-media-expected.txt: Added.
- cssom/cssimportrule-media.html: Added.
- cssom/resources/import.css: Added.
- 11:58 AM Changeset in webkit [132833] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/inspector/InspectorStyleSheet.cpp
Merge 131578
BUG=156282
Review URL: https://codereview.chromium.org/11273087
- 11:56 AM Changeset in webkit [132832] by
-
- 1 edit in branches/chromium/1271/Source/WebKit/chromium/src/WebFrameImpl.cpp
Merge 132746 (partial) - [Chromium] Find-in-page reports matches in hidden iframes
https://bugs.webkit.org/show_bug.cgi?id=100604
Reviewed by Eric Seidel.
This is actually a regression caused by
http://trac.webkit.org/changeset/128784. This patch adds back some code
removed in WebFrameImpl::shouldScopeMatches in r128784.
This patch also introduces a test so that we don't make this mistake
again.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::shouldScopeMatches):
TBR=abarth@webkit.org
Review URL: https://codereview.chromium.org/11343020
- 11:50 AM Changeset in webkit [132831] by
-
- 2 edits in trunk/Tools
[CMAKE] Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=100681
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
Reviewed by Anders Carlsson.
Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMake since
it is needed by plugins/npruntime/npruntime-calls-with-null-npp.html
layout test.
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
- 11:44 AM Changeset in webkit [132830] by
-
- 1 edit2 copies in branches/chromium/1271
Merge 131709
BUG=154617
Review URL: https://codereview.chromium.org/11273086
- 11:22 AM Changeset in webkit [132829] by
-
- 2 edits in branches/chromium/1271/Source/WebKit/chromium
Merge 130847
BUG=154465
Review URL: https://codereview.chromium.org/11273084
- 11:18 AM Changeset in webkit [132828] by
-
- 3 edits in trunk/Source/WTF
String::split(UChar, Vector<String>&) shouldn't create a temporary String
https://bugs.webkit.org/show_bug.cgi?id=100578
Reviewed by Anders Carlsson.
Changed split(UChar, Vector<String>&) to call split(UChar, bool, Vector<String>&) instead of creating a
string and calling the split(String,...) version and moved it to WTFString.h. Also moved
split(const String& separator, Vector<String>& result) to WTFString.h.
- wtf/text/WTFString.cpp:
(WTF::String::split):
- wtf/text/WTFString.h:
(WTF::String::split):
- 11:11 AM Changeset in webkit [132827] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding flaky crash expectations for tests that crash after r132699
if the accessibility object cache is populated.
- platform/gtk/TestExpectations:
- 11:07 AM Changeset in webkit [132826] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html test case
https://bugs.webkit.org/show_bug.cgi?id=100687
Unreviewed EFL gardening.
Skip fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html test case
since it is intrinsically flaky and cannot be fixed.
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
- platform/efl/TestExpectations:
- 11:05 AM Changeset in webkit [132825] by
-
- 2 edits in trunk/Source/WebKit2
WKStringCopyCFString() should directly use 8 bit Strings data instead of up converting
https://bugs.webkit.org/show_bug.cgi?id=100579
Reviewed by Oliver Hunt.
Changed to use CFStringCreateWithBytes() for 8 bit strings using characters8() for an 8 bit argument string.
Changed the current call to characters16().
- Shared/API/c/cf/WKStringCF.cpp:
(WKStringCopyCFString):
- 11:02 AM Changeset in webkit [132824] by
-
- 1 edit2 copies in branches/chromium/1271
Merge 130999
BUG=154284
Review URL: https://codereview.chromium.org/11339015
- 11:01 AM Changeset in webkit [132823] by
-
- 2 edits in trunk/Source/WebCore
webview not redrawn as needed when accelerated compositing is enabled.
https://bugs.webkit.org/show_bug.cgi?id=99109
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-29
Reviewed by Martin Robinson.
GL shared display is not in the gtk loop and therefore, its events are
not captured by gtk. So, we use gdk default instead.
No new tests, covered by existing tests.
- platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::resize):
- 10:54 AM Changeset in webkit [132822] by
-
- 4 edits in tags/Safari-537.16/Source
Versioning.
- 10:51 AM Changeset in webkit [132821] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.
https://bugs.webkit.org/show_bug.cgi?id=100683
Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
Reviewed by Pavel Feldman.
When in compact mode, style the Web Inspector toolbar using the same colors & gradients
as the Chromium toolbar (Chromium port only).
- src/js/devTools.css:
(body.compact.platform-mac #toolbar):
(body.compact.platform-mac.inactive #toolbar):
(body.platform-mac.inactive #toolbar .toolbar-label):
- 10:48 AM Changeset in webkit [132820] by
-
- 8 edits in branches/chromium/1271/Source/WebCore
Revert 128379 - IndexedDB: Use ScriptValue instead of SerializedScriptValue when possible
https://bugs.webkit.org/show_bug.cgi?id=94023
Patch by Alec Flett <alecflett@chromium.org> on 2012-09-12
Reviewed by Kentaro Hara.
Transition the put/add/update methods to accept direct ScriptValue
objects rather than SerializedScriptValues, to eliminate lots of
redundant deserialization/serialization steps while storing
values.
Also see https://bugs.webkit.org/show_bug.cgi?id=95409 for
followup get/openCursor work, following this.
No new tests, this is a performance refactor of core IDB
functionality. Most existing tests cover correctness. Tests that
might fail include:
storage/indexeddb/objectstore-basics.html
storage/indexeddb/keypath-basics.html
storage/indexeddb/index-basics.html
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
- Modules/indexeddb/IDBCursor.h:
(IDBCursor):
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore):
- Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStore.idl:
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::deserializeIDBValue):
(WebCore::canInjectIDBKeyIntoScriptValue):
- bindings/v8/IDBBindingUtilities.h:
(WebCore):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11336016
- 10:47 AM Changeset in webkit [132819] by
-
- 7 edits in trunk
[Qt] Flaky security tests
https://bugs.webkit.org/show_bug.cgi?id=100388
Reviewed by Jocelyn Turcotte.
Tools:
Disable text dumping and load a blank URL to ensure the documentLoader is cleared
before we start dumping text for the new page. Otherwise messages from the old page
may end up in the text output of the new test.
This matches what WebKitTestRunner does, and reuses the Qt code for waiting for flag.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::runUntil):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::finishedResetting):
(WebCore::DumpRenderTree::dump):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::resetDumping):
(TestRunner::reset):
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
LayoutTests:
Unskip no longer flaky tests.
- platform/qt/TestExpectations:
- 10:46 AM Changeset in webkit [132818] by
-
- 14 edits in branches/chromium/1271/Source
Revert 128789 - IndexedDB: Use ScriptValue instead of SerializedScriptValue for get/openCursor
https://bugs.webkit.org/show_bug.cgi?id=95409
Patch by Alec Flett <alecflett@chromium.org> on 2012-09-17
Reviewed by Kentaro Hara.
Source/WebCore:
This reduces a bunch of serialization/deserialization when writing
to objectstores with indexes.
No new tests, as this covers core functionality of IndexedDB, and
almost every test would fail. Some likely tests that would fail
fundamentally include:
storage/indexeddb/objectstore-basics.html
storage/indexeddb/cursor-basics.html
storage/indexeddb/index-basics.html
- Modules/indexeddb/IDBAny.cpp:
(WebCore::IDBAny::scriptValue):
(WebCore::IDBAny::integer):
(WebCore):
(WebCore::IDBAny::set):
- Modules/indexeddb/IDBAny.h:
(WebCore):
(IDBAny):
(WebCore::IDBAny::create):
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setValueReady):
- Modules/indexeddb/IDBCursor.h:
(WebCore):
(IDBCursor):
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::version):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::setResultCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore):
(WebCore::IDBRequest::onSuccessInternal):
(WebCore::IDBRequest::dispatchEvent):
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
- Modules/indexeddb/IDBTransactionCallbacks.h:
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):
- bindings/v8/IDBBindingUtilities.h:
(WebCore):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
Source/WebKit/chromium:
This removes a bunch of tests that have been migrated to
LayoutTests, in https://bugs.webkit.org/show_bug.cgi?id=96818.
- tests/IDBBindingUtilitiesTest.cpp:
(WebCore::checkKeyFromValueAndKeyPathInternal):
(WebCore::checkKeyPathNullValue):
(WebCore::injectKey):
(WebCore::checkInjection):
(WebCore::checkInjectionFails):
(WebCore::checkKeyPathStringValue):
(WebCore::checkKeyPathNumberValue):
(WebCore::TEST):
- tests/IDBKeyPathTest.cpp:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11348011
- 10:46 AM Changeset in webkit [132817] by
-
- 4 edits in branches/chromium/1271/Source/WebCore
Merge 132398
BUG=154055
Review URL: https://codereview.chromium.org/11350003
- 10:35 AM Changeset in webkit [132816] by
-
- 2 edits2 copies in branches/chromium/1271
Merge 131670
BUG=152585
Review URL: https://codereview.chromium.org/11342010
- 10:30 AM Changeset in webkit [132815] by
-
- 2 edits5 copies3 adds1 delete in trunk/PerformanceTests
Turn PageLoad tests into simple performancetests, commit #7 (last)
https://bugs.webkit.org/show_bug.cgi?id=99899
Reviewed by Ryosuke Niwa.
We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.
This is the #7 (last) commit of the whole patch.
- PageLoad: Removed.
- PageLoad/svg: Removed.
- PageLoad/svg/LICENSES: Removed.
- PageLoad/svg/files: Removed.
- PageLoad/svg/files/33041-Samurai.svg: Removed.
- PageLoad/svg/files/42450-under the see.svg: Removed.
- PageLoad/svg/files/world-iso.svg: Removed.
- PageLoad/svg/svg.pltsuite: Removed.
- SVG/Samurai.html: Added.
- SVG/UnderTheSee.html: Added.
- SVG/WorldIso.html: Added.
- SVG/resources/LICENSES: Copied from PerformanceTests/PageLoad/svg/LICENSES.
- SVG/resources/Samurai.svg: Copied from PerformanceTests/PageLoad/svg/files/33041-Samurai.svg.
- SVG/resources/UnderTheSee.svg: Copied from PerformanceTests/PageLoad/svg/files/42450-under%20the%20see.svg.
- SVG/resources/WorldIso.svg: Copied from PerformanceTests/PageLoad/svg/files/world-iso.svg.
- SVG/resources/svg.pltsuite: Copied from PerformanceTests/PageLoad/svg/svg.pltsuite.
- Skipped: Rename the files on the skipped list also.
- 10:28 AM Changeset in webkit [132814] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/loader/SubresourceLoader.cpp
Merge 132287 - Crash in WebCore::SubresourceLoader::willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=100147
Reviewed by Abhishek Arya.
No new tests. There is a test case that should cover this, but it doesn't
work correctly on many platforms due to its use of testRunner.addURLToRedirect().
See http/tests/loading/cross-origin-XHR-willLoadRequest.html.
Tested manually on http://www.nick.co.uk/shows/spongebob
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
TBR=Nate Chapin
Review URL: https://codereview.chromium.org/11312006
- 10:26 AM Changeset in webkit [132813] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: bind redo to Ctrl+Y on non-mac platforms
https://bugs.webkit.org/show_bug.cgi?id=100685
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._registerShortcuts):
- 10:10 AM Changeset in webkit [132812] by
-
- 9 edits in trunk/Source
Add ENABLE_USERSELECT_ALL feature flag.
https://bugs.webkit.org/show_bug.cgi?id=100559
Reviewed by Eric Seidel.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 10:03 AM Changeset in webkit [132811] by
-
- 2 edits in tags/Safari-537.16/Source/WebKit2
Merged r132714.
- 9:59 AM Changeset in webkit [132810] by
-
- 8 edits in tags/Safari-537.16/Source/WebCore
Rollout 132695.
- 9:56 AM Changeset in webkit [132809] by
-
- 2 edits2 copies in branches/chromium/1271
Merge 131488
BUG=143761
Review URL: https://codereview.chromium.org/11336015
- 9:50 AM Changeset in webkit [132808] by
-
- 10 edits2 adds in trunk/Source/WebCore
[CSS Shaders] Extract the CustomFilterParameterList to its own file
https://bugs.webkit.org/show_bug.cgi?id=100548
Reviewed by Dean Jackson.
Moved all the CustomFilterParameterList related methods to their own file.
Also made CustomFilterParameterList inherit from Vector instead of typedefing it,
so that we can add a different operator== and a blend method to it.
No new tests, just refactoring existing code.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/StyleResolver.h:
- platform/graphics/filters/CustomFilterOperation.cpp:
(WebCore::CustomFilterOperation::CustomFilterOperation):
(WebCore::CustomFilterOperation::blend):
- platform/graphics/filters/CustomFilterOperation.h:
(WebCore):
(WebCore::CustomFilterOperation::operator==):
- platform/graphics/filters/CustomFilterParameterList.cpp: Added.
(WebCore):
(WebCore::CustomFilterParameterList::operator==):
(WebCore::CustomFilterParameterList::checkAlphabeticalOrder):
(WebCore::CustomFilterParameterList::blend):
- platform/graphics/filters/CustomFilterParameterList.h: Added.
(WebCore):
(CustomFilterParameterList):
- 9:46 AM WebKit Team edited by
- (diff)
- 9:42 AM Changeset in webkit [132807] by
-
- 2 edits in trunk/Source/WebCore
Try to fix 32-bit builds after my incompletely tested m_identifier change.
Not reviewed.
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::identifier): Revert my "unsigned long" -> "uint64_t" change in two places.
- 9:40 AM Changeset in webkit [132806] by
-
- 8 edits in tags/Safari-537.16/Source/WebKit2
Merged r132738.
- 8:51 AM Changeset in webkit [132805] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Typo in WebPagePrivate::postponeDocumentRecalcStyle()
https://bugs.webkit.org/show_bug.cgi?id=100377
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-10-29
Reviewed by Adam Treat.
Should be void, not bool.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
- Api/WebPage_p.h:
(WebPagePrivate):
- 7:52 AM Changeset in webkit [132804] by
-
- 11 edits in trunk
[WK2][WKTR] Enable Shadow DOM at runtime if compiled with SHADOW_DOM support
https://bugs.webkit.org/show_bug.cgi?id=100668
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Add Bundle API to enable Shadow DOM functionality. This is
now needed by WebKitTestRunner.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetShadowDOMEnabled):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setShadowDOMEnabled):
(WebKit):
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
Tools:
Enable Shadow DOM functionality at run time in WebKitTestRunner
if compiled with SHADOW_DOM flag set. This is needed to run
the Shadow DOM layout tests.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
LayoutTests:
Remove Shadow DOM layout tests from the global wk2 TestExpectations
and add it to the mac-wk2 one. EFL and GTK ports have Shadow DOM
enabled so they don't need to be skipped for those ports. The Qt port
is already skipping those tests in its global TestExpectations file.
- platform/efl-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/wk2/TestExpectations:
- 7:50 AM Changeset in webkit [132803] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Fix cursor change detection in EwkViewImpl::setCursor()
https://bugs.webkit.org/show_bug.cgi?id=100662
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
Reviewed by Kenneth Rohde Christiansen.
Cursor change detection in EwkViewImpl::setCursor() relies on
addresses returned by Cursor::platformCursor(). However, the
value returned is currently assigned to a WKEinaSharedString
instead of a raw pointer. Therefore, the address is always
different and we keep recreating Evas Objects for the same
cursor.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::setCursor): Call smartData() after same cursor
detection since it is not needed if the cursor has not changed
and it may affect performance.
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
- 7:47 AM Changeset in webkit [132802] by
-
- 4 edits in trunk
[Qt] Text with zero font size renders as X px sometimes, causing fast/text/zero-font-size-2.html to fail
https://bugs.webkit.org/show_bug.cgi?id=100115
Reviewed by Noam Rosenthal.
Source/WebCore:
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::drawGlyphs):
LayoutTests:
- platform/qt/TestExpectations: Unskip fast/text/zero-font-size-2.html.
- 7:46 AM Changeset in webkit [132801] by
-
- 3 edits in trunk/Source/WebKit2
Coordinated Graphics: Make sure that we release images immediately when purging resources
https://bugs.webkit.org/show_bug.cgi?id=100661
Reviewed by Noam Rosenthal.
When we purge, we do both on the UI and web process at the same time,
both are expected to release references of the other process.
This creates problem when delaying the release of directly composited
images.
Release them immediately in that case.
Fixes the tst_QQuickWebView::removeFromCanvas API test.
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::purgeReleasedImages):
(WebKit):
(WebKit::LayerTreeCoordinator::purgeBackingStores):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- 7:37 AM Changeset in webkit [132800] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Avoid useless assignment in EwkViewImpl::setCustomTextEncodingName()
https://bugs.webkit.org/show_bug.cgi?id=100667
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
Reviewed by Kenneth Rohde Christiansen.
Remove useless m_customEncoding assignment in EwkViewImpl::setCustomTextEncodingName()
since the member is anyway assigned in EwkViewImpl::customTextEncodingName().
Have EwkViewImpl::setCustomTextEncodingName() take a String in argument instead
of a const char* to make the API more C++ and since we don't need a const char*
to assign to m_customEncoding anymore.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::setCustomTextEncodingName):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_setting_encoding_custom_set):
- 7:29 AM Changeset in webkit [132799] by
-
- 5 edits in trunk/Tools
[EFL][AC] Fix bugs preventing us from running layout tests with AC turned on
https://bugs.webkit.org/show_bug.cgi?id=100598
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-29
Reviewed by Kenneth Rohde Christiansen.
Make sure to use opengl_x11 engine when AC is turned on and X11 is in use.
We cannot create a gl context otherwise.
- MiniBrowser/efl/main.c:
(elm_main):
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::initEcoreEvas):
- DumpRenderTree/efl/DumpRenderTree.cpp:
(initEcoreEvas):
- EWebLauncher/efl/main.c:
(windowCreate):
- 7:26 AM Changeset in webkit [132798] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] Make GraphicsLayerAnimation choose a proper timing function.
https://bugs.webkit.org/show_bug.cgi?id=100623
Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-29
Reviewed by Noam Rosenthal.
Currently, GraphicsLayerAnimation chooses a timing function in the wrong
way. Other GraphicsLayers choose a timing function in the similar way to
GraphicsLayerCA::timingFunctionForAnimationValue(). The way consists of
the following steps.
- Try to query the timing function of the current keyframe animation value.
- If the timing function of #1 is null, try to query the timing function of Animation.
- If the timing function of #2 is null, return CubicBezierTimingFunction::defaultTimingFunction().
This patch makes GraphicsLayerAnimation choose a timing function in the same way
to other implementations.
Covered by existing animations tests.
- platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerAnimation::apply):
- 7:23 AM Changeset in webkit [132797] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Toolbar overflow appears outside window
https://bugs.webkit.org/show_bug.cgi?id=100663
Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
Reviewed by Pavel Feldman.
Since the search bar was removed from the toolbar, the overflow menu appears too far
to the right, and is unreadable. Fixed this by aligning it relative to the right side
of the window, rather than the left.
- inspector/front-end/Toolbar.js:
(WebInspector.ToolbarDropdown.prototype.show):
- inspector/front-end/inspector.css:
(#toolbar-dropdown .toolbar-label):
- 7:23 AM Changeset in webkit [132796] by
-
- 4 edits in trunk
[EFL][WK2] REGRESSION(r132342): fast/events/frame-tab-focus.html fails
https://bugs.webkit.org/show_bug.cgi?id=100646
Reviewed by Kenneth Rohde Christiansen.
Tools:
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::focus): Improve the check we perform to
decide whether the focus should be taken out of the view before
focusing it again so that we do not unnecessarily unfocus it and
cause blur/focus events to be triggered. Instead of just verifying
if the Evas_Object representing the view has focus, use the WK C
API to check that the currently focused frame is not the main
frame.
LayoutTests:
- platform/efl-wk2/TestExpectations: Unskip
fast/events/frame-tab-focus.html.
- 7:10 AM Changeset in webkit [132795] by
-
- 4 edits2 adds in trunk
[CSS Shaders] Implement CustomFilterArrayParameter::blend
https://bugs.webkit.org/show_bug.cgi?id=96437
Reviewed by Dean Jackson.
Source/WebCore:
This patch adds the missing code to blend values within
an array() when using Custom Filters.
Test: css3/filters/custom/custom-filter-array-blending.html
- platform/graphics/filters/CustomFilterArrayParameter.h:
(WebCore::CustomFilterArrayParameter::blend):
LayoutTests:
New tests to asses the correctness of CustomFilterArrayParameter::blend.
- animations/resources/animation-test-helpers.js:
(customFilterParameterMatch): A check for functions' parameters length has been added.
- css3/filters/custom/custom-filter-array-blending-expected.txt: Added.
- css3/filters/custom/custom-filter-array-blending.html: Added.
- 6:52 AM Changeset in webkit [132794] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Drag and drop a URL in inspector is not working as expected
https://bugs.webkit.org/show_bug.cgi?id=100527
Reviewed by Yury Semikhatsky.
Inhibit custom dragstart handling when the active element is A.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._ondragstart):
- 6:29 AM Changeset in webkit [132793] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Error/warning count is one pixel off.
https://bugs.webkit.org/show_bug.cgi?id=100660
Reviewed by Pavel Feldman.
The error/warning count div had a top padding of 6. That was one pixel
too many.
- inspector/front-end/inspector.css:
(#error-warning-count):
- 6:07 AM Changeset in webkit [132792] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix a build error
https://bugs.webkit.org/show_bug.cgi?id=100649
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-10-29
Reviewed by Kentaro Hara.
r127876 changed the signature of WebCore::EventHandler::hitTestResultAtPoint()
and this commit was later reverted. We need to update a call site in the
BlackBerry port to make it build.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- 5:51 AM Changeset in webkit [132791] by
-
- 4 edits in trunk/Source/WebCore
[Refactoring] Use isActiveInsertionPoint() instead of isInsertionPoint()
https://bugs.webkit.org/show_bug.cgi?id=100459
Reviewed by Hajime Morita.
Checking InsertionPoint and its activeness with two if-statement is error-prone. We would like to
use a utility function which checks both at once.
We rewrite some lines with such function.
No new tests, simple refactoring.
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseNode):
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::populate):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::distributeNodeChildrenTo):
- html/shadow/InsertionPoint.h:
(WebCore::isInsertionPoint): Since our convention is the argument of this kind of function should not be null,
we would like to make it similar to the other functions.
(WebCore::toInsertionPoint):
(WebCore::isLowerEncapsulationBoundary):
- 5:48 AM Changeset in webkit [132790] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Fix vertical alignment in toolbar backgrounds and overflow button.
https://bugs.webkit.org/show_bug.cgi?id=100373
Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
Reviewed by Pavel Feldman.
Fix the background image for the selected toolbar item to be vertically centered.
Make close button and toolbar overflow button vertically centered for any toolbar
height.
- inspector/front-end/Toolbar.js: Remove unused variable.
- inspector/front-end/inspector.css:
(.toolbar-item.toggleable):
(body.compact .toolbar-item.toggleable):
(.toolbar-item.toggleable.toggled-on):
(body.compact .toolbar-label):
(#toolbar-dropdown-arrow):
(#close-button-left, #close-button-right):
(.toolbar-item.close-left):
- inspector/front-end/inspector.html:
- 5:43 AM Changeset in webkit [132789] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Timeline: Overview bars do not correspond to timeline bars
https://bugs.webkit.org/show_bug.cgi?id=100500
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-29
Reviewed by Yury Semikhatsky.
Fix: do not shorten bars by nested records of the same category.
- inspector/front-end/TimelineOverviewPane.js: Check added.
- 5:40 AM Changeset in webkit [132788] by
-
- 11 edits in trunk/Source
Web Inspector: Timeline: make cpu-monitoring feature available only on capable browsers
https://bugs.webkit.org/show_bug.cgi?id=100530
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-29
Reviewed by Yury Semikhatsky.
Motivation: cpu-monitoring feature looks like a glitch,
when it is not supported by browser.
Source/WebCore:
- inspector/Inspector.json: Added capability getter to protocol.
- inspector/InspectorClient.h: Added capability getter.
- inspector/InspectorTimelineAgent.cpp: Proxy to request to client.
- inspector/InspectorTimelineAgent.h: Added capability getter.
- inspector/front-end/Settings.js: Added capability field.
- inspector/front-end/TimelinePanel.js: Check capability.
- inspector/front-end/inspector.js: Forward capability value.
Source/WebKit/chromium:
- src/InspectorClientImpl.cpp: Implemented capability getter.
- src/InspectorClientImpl.h:
- 5:37 AM Changeset in webkit [132787] by
-
- 6 edits in trunk/Source/WebCore
Move seamless stylesheet collecting to DocumentStyleSheetCollection
https://bugs.webkit.org/show_bug.cgi?id=100655
Reviewed by Andreas Kling.
Move the code from StyleResolver to DocumentStyleSheetCollection. StyleResolver should focus on resolving style.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
Use standard create() pattern.
(WebCore):
- css/StyleResolver.h:
(StyleResolver):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
Since parent activeAuthorStyleSheets() contains all seamlessly inherited sheets too, this does not need to
iterate to ancestors anymore.
(WebCore):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
- dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollection::create):
(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::styleSheetsForStyleSheetList):
(WebCore::DocumentStyleSheetCollection::activeAuthorStyleSheets):
activeAuthorStyleSheets() now includes the stylesheets inherited from the seamless parent too.
(WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):
- 4:44 AM Changeset in webkit [132786] by
-
- 14 edits in trunk/Source/WebCore
Don't expose implementation details of StylePropertySet storage.
<http://webkit.org/b/100644>
Reviewed by Antti Koivisto.
Add a StylePropertySet::PropertyReference class, now returned by propertyAt(index).
This will allow us to refactor the internal storage of StylePropertySet without
breaking its API.
A PropertyReference is a simple inlinable wrapper around a StylePropertySet&/index pair.
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSParser.cpp:
- css/CSSParser.h:
- css/SVGCSSParser.cpp:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::reportMemoryUsage):
- css/StylePropertySet.h:
(StylePropertySet):
(PropertyReference):
(WebCore::StylePropertySet::PropertyReference::PropertyReference):
(WebCore::StylePropertySet::PropertyReference::id):
(WebCore::StylePropertySet::PropertyReference::isImportant):
(WebCore::StylePropertySet::PropertyReference::isInherited):
(WebCore::StylePropertySet::PropertyReference::cssName):
(WebCore::StylePropertySet::PropertyReference::cssText):
(WebCore::StylePropertySet::PropertyReference::value):
(WebCore::StylePropertySet::PropertyReference::propertyInternal):
(WebCore::StylePropertySet::propertyAt):
(WebCore::StylePropertySet::propertyAtInternal):
(WebCore):
- css/StyleResolver.cpp:
(WebCore::attributeStylesEqual):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::resolveVariables):
- editing/ApplyStyleCommand.cpp:
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeStyle):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
- editing/Editor.cpp:
- editing/markup.cpp:
- page/Frame.cpp:
- svg/SVGFontFaceElement.cpp:
- 4:29 AM Changeset in webkit [132785] by
-
- 4 edits in trunk
Unreviewed, rolling out r132782.
http://trac.webkit.org/changeset/132782
https://bugs.webkit.org/show_bug.cgi?id=100653
It made 400+ tests fail and 180 tests flakey on Qt (Requested
by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-29
Tools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
LayoutTests:
- platform/qt/TestExpectations:
- 4:21 AM Changeset in webkit [132784] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r132736.
http://trac.webkit.org/changeset/132736
https://bugs.webkit.org/show_bug.cgi?id=100652
It broke all plugin related tests on GTK and on Qt (Requested
by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-29
- wtf/text/WTFString.cpp:
(WTF::String::fromUTF8):
- 3:53 AM Changeset in webkit [132783] by
-
- 3 edits1 delete in trunk/Source/WebKit/chromium
[Chromium] Merge LocalizedNumberICUTest into LocaleICUTest
https://bugs.webkit.org/show_bug.cgi?id=100648
Reviewed by Kentaro Hara.
LocalizedNumberICU was removed some months ago, and its features were
merged to LocaleICU. We merge the test too.
- WebKit.gypi: Remove LocalizedNumberICUTest.cpp
- tests/LocaleICUTest.cpp:
Move a #if because some headers are used unconditionally.
(testDecimalSeparator): Moved from LocalizedNumberICUTest.cpp.
(TEST_F): Ditto.
(testNumberIsReversible): Ditto.
(testNumbers): Ditto.
- tests/LocalizedNumberICUTest.cpp: Removed.
- 3:52 AM Changeset in webkit [132782] by
-
- 4 edits in trunk
[Qt] Flaky security tests
https://bugs.webkit.org/show_bug.cgi?id=100388
Reviewed by Jocelyn Turcotte.
Tools:
Disable text output and load a blank URL to ensure the documentLoader is cleared
before we start dumping text for the new page. Otherwise messages from the old page
may end up in the text output of the new test.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
LayoutTests:
Unskip no longer flaky tests.
- platform/qt/TestExpectations:
- 3:50 AM Changeset in webkit [132781] by
-
- 12 edits1 copy1 add in trunk/Tools
[chromium] remove remaining usages of webkit_support from the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=100344
Reviewed by Adam Barth.
The most important part is to not rely on calling out to gdk/X11 to
translate keycodes to hardware keycodes, as this is not possible inside
the sandbox.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/DRTTestRunner.h:
(WebKit):
(webkit_support):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::doDragDrop):
(WebTestRunner::EventSender::updateClickCountForButton):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::handleMouseWheel):
(WebTestRunner::EventSender::gestureEvent):
(WebTestRunner::EventSender::gestureFlingCancel):
(WebTestRunner::EventSender::gestureFlingStart):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.
(WebTestRunner):
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
(TestDelegate):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
(WebTestRunner):
(WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::getCurrentTimeInMillisecond):
(WebViewHost::getAbsoluteWebStringFromUTF8Path):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 3:28 AM Changeset in webkit [132780] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Enable delegated scrolling as soon as the FrameView is created when using fixed layout
https://bugs.webkit.org/show_bug.cgi?id=100383
Reviewed by Kenneth Rohde Christiansen.
Scroll requests and PageTransitionViewportReady messages depend on
delegated scrolling being set properly on the FrameView to behave
properly. Since we were waiting for the viewport information to be
ready before setting the flag this could cause those messages to be avoided.
This patch takes most of the flag set by setResizesToContentsUsingLayoutSize
and apply them as soon as possible in WebPage::setUseFixedLayout and
WebFrameLoaderClient::transitionToCommittedForNewPage.
The behavior should be the same except for the following settings which are
now set outside of USE(TILED_BACKING_STORE) if we're using fixed layout:
- setAcceleratedCompositingForFixedPositionEnabled
- setFixedElementsLayoutRelativeToFrame
- setFixedPositionCreatesStackingContext
This fixes the tst_QQuickWebView::scrollRequest auto test and improves the
reliability of the loadVisuallyCommitted signal with pages loaded from disk.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::setUseFixedLayout):
(WebKit::WebPage::setFixedLayoutSize):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- 3:07 AM Changeset in webkit [132779] by
-
- 2 edits in trunk/LayoutTests
2012-10-29 Pavel Podivilov <podivilov@google.com>
[Chromium] Test expectation update.
Unreviewed, mark recently added audiobuffersource-loop-points.html test as failing on windows.
- platform/chromium/TestExpectations:
- 2:44 AM Changeset in webkit [132778] by
-
- 2 edits1 move in trunk/Source/WebKit/chromium
[Chromium] Rename LocalizedDateICUTest.cpp to LocaleICUTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=100643
Reviewed by Kentaro Hara.
LocalizedDateICU was removed some months ago, and LocalizedDateICUTest
actually had tests for LocaleICU.
- WebKit.gypi:
- tests/LocaleICUTest.cpp:
- Renamed from Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp.
- Rename LocalizedDateICUTest class to LocaleICUTest.
- 2:18 AM Changeset in webkit [132777] by
-
- 3 edits2 moves in trunk/Source/WebCore
Move LocaleWin.{cpp,h} to platform/text/win/
https://bugs.webkit.org/show_bug.cgi?id=100641
Reviewed by Kentaro Hara.
We have platform/text/win/ directory. Windows-specific files should be
in it.
Note that these files are used only in Chromium-win for now.
No new tests. This doesn't change any behavior.
- WebCore.gyp/WebCore.gyp: Fix path names.
- WebCore.gypi: Ditto.
- platform/text/win/LocaleWin.cpp: Renamed from Source/WebCore/platform/text/LocaleWin.cpp.
- platform/text/win/LocaleWin.h: Renamed from Source/WebCore/platform/text/LocaleWin.h.
- 2:17 AM Changeset in webkit [132776] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r132709.
- Shared/WebMemorySampler.cpp: Include unistd.h for getpid(3).
- 2:11 AM Changeset in webkit [132775] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium-linux] Fix build.
- tests/LocalizedNumberICUTest.cpp:
(testNumberIsReversible): Rename an argument.
(testDecimalSeparator): Ditto.
- 1:51 AM Changeset in webkit [132774] by
-
- 35 edits in trunk/Source
Rename Localizer to Locale
https://bugs.webkit.org/show_bug.cgi?id=100634
Reviewed by Kentaro Hara.
Source/WebCore:
- Rename Localizer class to Locale
- Rename localizer with locale in variable names
- Rename localizer with locale in function names
No new tests. This doesn't make any behavior changes.
- dom/Document.h:
(WebCore): Declare Locale instead of Localizer.
(Document):
- Rename getCachedLocalizer to getCachedLocale.
- Rename LocaleToLocalizerMap to LocaleIdentifierToLocaleMap.
- Rename m_localizerCache to m_localeCache.
- dom/Document.cpp:
(WebCore::Document::getCachedLocale): Follow renamings.
- dom/Element.h:
(WebCore): Declare Locale instead of Localizer.
(Element): Rename localizer() to locale().
- dom/Element.cpp:
(WebCore::Element::locale): Follow renamings.
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::localizeValue): Ditto.
(WebCore::BaseDateAndTimeInputType::convertFromVisibleValue): Ditto.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Ditto.
- html/DateInputType.cpp:
(WebCore::DateInputType::fixedPlaceholder): Ditto.
(WebCore::DateInputType::setupLayoutParameters): Ditto.
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::setupLayoutParameters): Ditto.
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::setupLayoutParameters): Ditto.
- html/MonthInputType.cpp:
(WebCore::MonthInputType::setupLayoutParameters): Ditto.
- html/NumberInputType.cpp:
(WebCore::NumberInputType::localizeValue): Ditto.
(WebCore::NumberInputType::convertFromVisibleValue): Ditto.
- html/TimeInputType.cpp:
(WebCore::TimeInputType::localizeValue): Ditto.
(WebCore::TimeInputType::setupLayoutParameters): Ditto.
- html/shadow/DateTimeEditElement.h:
(WebCore): Declare Locale instead of Localizer.
(LayoutParameters): Rename localizer data member to locale.
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters): Follow renamings.
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitField): Ditto.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Rename localizerForOwner to localeForOwner.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::formatValue): Follow renamings.
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent): Ditto.
(WebCore::DateTimeNumericFieldElement::localeForOwner): Ditto.
- page/PagePopupClient.h:
(WebCore): Declare Locale instead of Localizer.
(PagePopupClient): Rename localizer member function to locale.
- page/PagePopupController.cpp:
(WebCore::PagePopupController::localizeNumberString): Follow renamings.
- platform/text/PlatformLocale.cpp: Rename the Localizer class to Locale.
(DateTimeStringBuilder):
(WebCore::DateTimeStringBuilder::DateTimeStringBuilder):
(WebCore::Locale::~Locale):
(WebCore::Locale::setLocaleData): Renamed from setLocalizerData.
(WebCore::Locale::convertToLocalizedNumber):
(WebCore::Locale::detectSignAndGetDigitRange):
(WebCore::Locale::matchedDecimalSymbolIndex):
(WebCore::Locale::convertFromLocalizedNumber):
(WebCore::Locale::localizedDecimalSeparator):
(WebCore::Locale::dateTimeFormatWithSeconds):
(WebCore::Locale::dateTimeFormatWithoutSeconds):
(WebCore::Locale::formatDateTime):
- platform/text/PlatformLocale.h: Update the ifndef macro.
(Locale): Renamed from Localizer. Also, renamed the followings:
- initializeLocalizerData -> initializeLocaleData
- setLocalizerData -> setLocaleData
- m_hasLocalizerData -> m_hasLocaleData
(WebCore::Locale::Locale):
(WebCore::Locale::createDefault):
- platform/text/LocaleICU.cpp: Follow renamings.
- platform/text/LocaleICU.h: Ditto.
- platform/text/LocaleNone.cpp: Ditto.
- platform/text/LocaleWin.cpp: Ditto.
- platform/text/LocaleWin.h: Ditto.
- platform/text/mac/LocaleMac.h: Ditto.
- platform/text/mac/LocaleMac.mm: Ditto.
Source/WebKit/chromium:
- src/ColorChooserUIController.h:
(ColorChooserUIController):
Rename m_localizer to m_locale, and follow other renamings.
- src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::ColorChooserUIController): Follow renamings.
(WebKit::ColorChooserUIController::locale): Ditto.
- src/DateTimeChooserImpl.h:
(DateTimeChooserImpl):
Rename m_localizer to m_locale, and follow other renamings.
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl): Follow renamings.
(WebKit::DateTimeChooserImpl::writeDocument): Ditto.
(WebKit::DateTimeChooserImpl::locale): Ditto.
- tests/LocaleMacTest.cpp:
(LocaleMacTest::formatTime): Ditto.
(testNumberIsReversible): Ditto.
- tests/LocalizedNumberICUTest.cpp:
(testNumberIsReversible): Ditto.
(testDecimalSeparator): Ditto.
- 1:49 AM Changeset in webkit [132773] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Error messages lines in console are 1px taller than regular messages
https://bugs.webkit.org/show_bug.cgi?id=100521
Reviewed by Pavel Feldman.
The inspector is adding a 1px bottom border to list elements inside
a disclosure list. This is unnecessary in the current layout; it's
causing console messages with stack traces to be one pixel taller than
other console messages, which this patch fixes.
As a drive-by, this patch also adjusts the disclosure triangle's
position to match.
- inspector/front-end/inspector.css:
(.outline-disclosure li):
(.outline-disclosure li.parent::before):
- 1:48 AM Changeset in webkit [132772] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: The bubble for repeated errors is misplaced.
https://bugs.webkit.org/show_bug.cgi?id=100525
Reviewed by Pavel Feldman.
The repeated-message bubble is displayed as an inline-block element,
which works well as long as no stack trace is present. If present, the
message is wrapped in an 'ol' element displayed as a block, which pushes
itself down to the next line.
To avoid that issue, this patch switches the wrapper element to flexbox,
glorious flexbox.
- inspector/front-end/inspector.css:
(.console-message .bubble):
(.repeated-message .outline-disclosure):
(.filter-all .console-log-level.repeated-message, .filter-logs .console-log-level.repeated-message):
- 1:45 AM Changeset in webkit [132771] by
-
- 3 edits1 copy in trunk/LayoutTests
[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=99818
The failure of month-multiple-fields-keyboard-events.html on SnowLeopard
and XP is expected.
- OS X SnowLeopard The month forma is "yyyy MMMM" on SnowLoepard though it's "MMMM yyyy" on other platforms.
- Windows XP It doesn't support the lang-attribute-aware-form-control-UI testing
feature.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt.
- platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
- platform/chromium/TestExpectations:
- 1:36 AM Changeset in webkit [132770] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip 2 tests failing due to missing drag'n drop support
https://bugs.webkit.org/show_bug.cgi?id=100638
Unreviewed EFL gardening.
Skip 2 test cases failing due to missing drag'n drop support
in EFL port.
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
- platform/efl/TestExpectations:
- 1:34 AM Changeset in webkit [132769] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip 2 jquery tests crashing after r132757
https://bugs.webkit.org/show_bug.cgi?id=100637
Unreviewed EFL gardening.
Skip 2 jquery test cases that started crashing after
r132757.
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-29
- platform/efl/TestExpectations:
- 1:30 AM Changeset in webkit [132768] by
-
- 5 edits2 adds in trunk
Web Inspector: [Styles] Handle non-parsedOk properties as inactive ones
https://bugs.webkit.org/show_bug.cgi?id=100119
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector/styles/inactive-properties.html
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.createExclamationMark):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
- inspector/front-end/elementsPanel.css:
(.styles-section.computed-style .properties li.not-parsed-ok):
(.styles-section.computed-style .properties li.not-parsed-ok img.exclamation-mark):
(.styles-section .properties .not-parsed-ok):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpStyleTreeItem):
- inspector/styles/inactive-properties-expected.txt: Added.
- inspector/styles/inactive-properties.html: Added.
- 1:17 AM Changeset in webkit [132767] by
-
- 2 edits in trunk/Websites/webkit.org
Technical Articles should link to an old talk I gave
https://bugs.webkit.org/show_bug.cgi?id=100624
Reviewed by Adam Barth.
- coding/technical-articles.html:
- 1:14 AM Changeset in webkit [132766] by
-
- 2 edits in trunk/Tools
Unreviewed. Add Jonathan Dong as a committer.
https://bugs.webkit.org/show_bug.cgi?id=100629
- Scripts/webkitpy/common/config/committers.py:
- 12:58 AM WebInspector edited by
- Removing spam links, moving links to blog posts into a chronological order. (diff)
- 12:51 AM Changeset in webkit [132765] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Skip some tests because SHADOW_DOM is disabled on Qt.
Unskip another one that doesn't exist already.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-29
- platform/qt/TestExpectations:
- 12:38 AM Changeset in webkit [132764] by
-
- 5 edits in trunk/Source/WebCore
Make rendering tables with <colgroups> twice as fast by avoiding walking the DOM for colgroups 4 times for each cell
https://bugs.webkit.org/show_bug.cgi?id=100630
Reviewed by Ojan Vafai.
This is not a complete fix. Our rendering of this large tables still takes 7.8 seconds
on my retina MBP (down from 14.3s before this change).
It's very expensive to walk the DOM each time we call RenderTable::colElement
so this caches the RenderTableCol* in a vector for easier walking.
We invalidate the cache any time a RenderTableCol is added or removed from the
rendering sub-tree to avoid holding a bad pointer.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::invalidateCachedColumns):
(WebCore):
(WebCore::RenderTable::addColumn):
(WebCore::RenderTable::removeColumn):
(WebCore::RenderTable::updateColumnCache):
(WebCore::RenderTable::slowColElement):
- rendering/RenderTable.h:
(RenderTable):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::insertedIntoTree):
(WebCore):
(WebCore::RenderTableCol::willBeRemovedFromTree):
- rendering/RenderTableCol.h:
- 12:29 AM Changeset in webkit [132763] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 12:27 AM WebInspector edited by
- (diff)
- 12:02 AM Changeset in webkit [132762] by
-
- 26 edits2 moves in trunk/Source
Rename Localizer.{cpp,h} to PlatformLocale.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=100627
Reviewed by Yuta Kitamura.
Source/WebCore:
We'd like to rename Localizer class to Locale class. However we use
PlatformLocale.cpp and PlatformLocale.h as their file names because
<locale.h> exists in the C standard. In this patch, we rename only file
names. We're going to rename the class name later.
No new tests. This doesn't make any behavior change.
- platform/text/PlatformLocale.h: Renamed from Source/WebCore/platform/text/Localizer.h.
- platform/text/PlatformLocale.cpp: Renamed from Source/WebCore/platform/text/Localizer.cpp.
Follow the Localizer.h -> PlatformLocale.cpp renaming.
- CMakeLists.txt: Follow the file name renaming.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Document.cpp: Ditto.
- html/BaseDateAndTimeInputType.cpp: Ditto.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp: Ditto.
- html/DateInputType.cpp: Ditto.
- html/DateTimeInputType.cpp: Ditto.
- html/DateTimeLocalInputType.cpp: Ditto.
- html/MonthInputType.cpp: Ditto.
- html/NumberInputType.cpp: Ditto.
- html/TimeInputType.cpp: Ditto.
- html/shadow/DateTimeEditElement.cpp: Ditto.
- html/shadow/DateTimeNumericFieldElement.cpp: Ditto.
- page/PagePopupController.cpp: Ditto.
- platform/text/LocaleICU.h: Ditto.
- platform/text/LocaleNone.cpp: Ditto.
- platform/text/LocaleWin.h: Ditto.
- platform/text/mac/LocaleMac.h: Ditto.
Source/WebKit/chromium:
- src/ColorChooserUIController.h: Follow the file name renaming.
- src/DateTimeChooserImpl.cpp: Ditto.
Oct 28, 2012:
- 10:13 PM Changeset in webkit [132761] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Fix the incorrect use of preprocessor statement in API header.
https://bugs.webkit.org/show_bug.cgi?id=100610
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-28
Reviewed by Timothy Hatcher.
Remove the preprocessor statement to check 'ENABLE_INSPECTOR' feature
from the WKPage.h.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetInspector):
- UIProcess/API/C/WKPage.h:
- 9:08 PM Changeset in webkit [132760] by
-
- 13 edits12 adds2 deletes in trunk
The shadow element is not reprojected to a nested ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=99228
Reviewed by Dimitri Glazkov.
Source/WebCore:
We support shadow reprojection; elements distributed to <shadow> element can be reprojected to <content> now.
First, we have a distribution vector for each InsertionPoint, even if InsertionPoint is a shadow insertion point.
And we update a node-distribution map. Basically We're creating a map from node to InsertionPoint in ElementShadow.
If a node can be distributed to several InsertionPoint (e.g. in case reprojection happens),
the InsertionPoint in older ShadowDOM is chosen.
We also fix ComposedShadowTreeWalker to consider shadow reprojection.
Tests: fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html
fast/dom/shadow/shadow-reprojection-click.html
fast/dom/shadow/shadow-reprojection-dynamic.html
fast/dom/shadow/shadow-reprojection-fallback.html
fast/dom/shadow/shadow-reprojection.html
fast/dom/shadow/shadow-reprojection2.html
- css/StyleResolver.cpp:
(WebCore::shouldResetStyleInheritance): Now context.insertionPoint() returns the final insertion point where
a node is distributed. So we don't have to trace shadow insertion point anymore here.
(WebCore::StyleResolver::styleForElement): Since a direct child of ShadowRoot can be distributed now. In that case,
we don't have any parentElement. The parent node is a ShadowRoot in that case.
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::nodeCanBeDistributed): If a node can be distributed, returns true.
(WebCore):
(WebCore::resolveReprojection): Resolves content-reprojection and shadow-reprojection both.
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost): A case ShadowRoot is assigned
to some InsertionPoint should be handled with in traverseSiblingOrBackToInsertionPoint. So we remove it.
(WebCore::AncestorChainWalker::parent): Now we have a case that a direct child of ShadowRoot can be distributed.
In that case, we should not update m_distributedNode.
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::insertionPointFor): Since we have a distribution vector for each InsertionPoint,
we don't have a special case that a ShadowRoot is assigned to some InsertionPoint. Actually the existing code
is not correct now due to shadow reprojection.
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::populate): Populate a POOL. If a node is InsertionPoint, we fill it with the
distributed nodes.
(WebCore):
(WebCore::ContentDistributor::distribute): Since we want to make a distribution vector for each InsertionPoint,
we have to resolve a shadow InsertionPoint
(WebCore::ContentDistributor::distributeNodeChildrenTo):
- html/shadow/ContentDistributor.h:
(ContentDistributor):
- html/shadow/HTMLShadowElement.h:
(WebCore::toHTMLShadowElement):
(WebCore):
- html/shadow/InsertionPoint.h:
(WebCore::parentNodeForDistribution):
(WebCore::parentElementForDistribution):
(WebCore):
LayoutTests:
- fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection-expected.txt: Added.
- fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html: Added. A walker test case for elements distributed
to shadow element are reprojected.
- fast/dom/shadow/composed-shadow-tree-walker.html:
- fast/dom/shadow/content-reprojection-complex.html:
- fast/dom/shadow/content-reprojection-fallback-expected.html:
- fast/dom/shadow/content-reprojection-fallback-reprojection-expected.html:
- fast/dom/shadow/shadow-reprojection-click-expected.txt: Added.
- fast/dom/shadow/shadow-reprojection-click.html: Added. Does some interactive with a shadow-reprojected node.
- fast/dom/shadow/shadow-reprojection-dynamic-expected.html: Added.
- fast/dom/shadow/shadow-reprojection-dynamic.html: Added. Adds dynamically elements shadow-reprojected.
- fast/dom/shadow/shadow-reprojection-expected.html: Added.
- fast/dom/shadow/shadow-reprojection-fallback-expected.html: Added.
- fast/dom/shadow/shadow-reprojection-fallback.html: Added. A test case for fallback elements of a shadow element
are reprojected.
- fast/dom/shadow/shadow-reprojection-prohibited-expected.html: Removed.
- fast/dom/shadow/shadow-reprojection-prohibited.html: Removed.
- fast/dom/shadow/shadow-reprojection.html: Added. A basic test case.
- fast/dom/shadow/shadow-reprojection2-expected.html: Added.
- fast/dom/shadow/shadow-reprojection2.html: Added. Another basic test case.
- 9:02 PM Changeset in webkit [132759] by
-
- 20 edits in trunk/Source/JavaScriptCore
DFG should be able to emit effectful structure checks
https://bugs.webkit.org/show_bug.cgi?id=99260
Reviewed by Oliver Hunt.
This change allows us to find out if an array access that has gone polymorphic
is operating over known structures - i.e. the primordial array structures of the
global object that the code block containing the array access belongs to. We
term this state "OriginalArray" for short. The fact that the access has gone
polymorphic means that the array profile will not be able to report the set of
structures it had seen - but if it can tell us that all of the structures were
primordial then it just so happens that we can deduce what the structure set
would have been by just querying the code block's global object. This allows us
to emit an ArrayifyToStructure instead of an Arrayify if we find that we need to
do conversions. The fast path of an ArrayifyToStructure is exactly like the fast
path of a CheckStructure and is mostly subject to the same optimizations. It
also burns one fewer registers.
Essentially the notion of OriginalArray is a super cheap way of getting the
array profile to tell us a structure set instead of a singleton structure.
Currently, the array profile can only tell us the structure seen at an array
access if there was exactly one structure. If there were multiple structures, it
won't tell us anything other than the array modes and other auxiliary profiling
data (whether there were stores to holes, for example). With OriginalArray, we
cheaply get a structure set if all of the structures were primordial for the
code block's global object, since in that case the array mode set (ArrayModes)
can directly tell us the structure set. In the future, we might consider adding
complete structure sets to the array profiles, but I suspect that we would hit
diminishing returns if we did so - it would only help if we have array accesses
that are both polymorphic and are cross-global-object accesses (rare) or if the
arrays had named properties or other structure transitions that are unrelated to
indexing type (also rare).
This also does away with Arrayify (and the new ArrayifyToStructure) returning
the butterfly pointer. This turns out to be faster and easier to CSE.
And, this also changes constant folding to be able to eliminate CheckStructure,
ForwardCheckStructure, and ArrayifyToStructure in addition to being able to
transform them into structure transition watchpoints. This is great for
ArrayifyToStructure because then CSE and CFA know that there is no side effect.
Converting CheckStructure and ForwardCheckStructure to also behave this way is
just a matter of elegance.
This has no performance impact right now. It's intended to alleviate some of the
regressions seen in the early implementation of
https://bugs.webkit.org/show_bug.cgi?id=98606.
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
- bytecode/ArrayProfile.h:
(JSC):
(JSC::ArrayProfile::ArrayProfile):
(ArrayProfile):
(JSC::ArrayProfile::usesOriginalArrayStructures):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::alreadyChecked):
(JSC::DFG::arrayClassToString):
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::withProfile):
(JSC::DFG::ArrayMode::isJSArray):
(ArrayMode):
(JSC::DFG::ArrayMode::isJSArrayWithOriginalStructure):
(JSC::DFG::ArrayMode::supportsLength):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getScopeRegistersLoadElimination):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::hasArrayMode):
(JSC::DFG::Node::arrayMode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
(JSC::DFG::SpeculativeJIT::arrayify):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::isOriginalArrayStructure):
- runtime/Structure.cpp:
(JSC::Structure::nonPropertyTransition):
- 7:50 PM Changeset in webkit [132758] by
-
- 6 edits in trunk
Webkit adds a boundary to the Content-Type: text/plain POST header
https://bugs.webkit.org/show_bug.cgi?id=100445
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-10-28
Reviewed by Kent Tamura.
Source/WebCore:
Fixed a bug where an empty boundary parameter was added to Content-Type
header when POSTing forms with enctype=text/plain.
Test: http/tests/misc/form-post-textplain.html
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::populateFrameLoadRequest): Add boundary parameter to
Content-Type only when a boundary string is generated.
LayoutTests:
Fixed test failure and added a test case for Content-Type header.
- http/tests/misc/form-post-textplain-expected.txt:
- http/tests/misc/form-post-textplain.html:
- http/tests/misc/resources/form-post-textplain.php:
Added a test case for testing Content-Type POST header.
Also fixed existing test case that attempted to test newline in the input value.
LF in the input value is replaced with CRLF durling the construction of the form data set.
- 7:16 PM Changeset in webkit [132757] by
-
- 4 edits in trunk/Source/JavaScriptCore
There should not be blind spots in array length array profiling
https://bugs.webkit.org/show_bug.cgi?id=100620
Reviewed by Oliver Hunt.
I don't think this has any performance impact. But it's good to not have random
programs occasionally emit a GetById for array length accesses.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::privateCompilePatchGetArrayLength):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::privateCompilePatchGetArrayLength):
- 4:39 PM Changeset in webkit [132756] by
-
- 6 edits in trunk/LayoutTests
[Chromium] Test expectation update
Rebaseline for http://trac.webkit.org/changeset/132753
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- 4:32 PM Changeset in webkit [132755] by
-
- 4 edits in trunk/Source/WebCore
Cache calcMode() value for SVG animations.
https://bugs.webkit.org/show_bug.cgi?id=99694
Reviewed by Eric Seidel.
This patch refactors SVGAnimationElement::calcMode() to return a cached value instead
of recalculating its value on every call. On a simple test of 100 rectangles with 100
animations each, calls to calcMode() account for 3% of the total animation. After this
patch, calcMode() no longer appears in animation profiles at all.
No new tests as this functionality is covered by existing tests.
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
The default calcMode for all animation types is linear except AnimateMotion,
which defaults to CalcModePaced.
See: http://www.w3.org/TR/SVG/single-page.html#animate-CalcModeAttribute
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::isSupportedAttribute):
(WebCore::SVGAnimationElement::parseAttribute):
(WebCore::SVGAnimationElement::setCalcMode):
- svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::calcMode):
(WebCore::SVGAnimationElement::setCalcMode):
(SVGAnimationElement):
- 3:35 PM Changeset in webkit [132754] by
-
- 5 edits in trunk/Source/WebCore
Get rid of StyleResolver state related to unknown pseudo-elements.
https://bugs.webkit.org/show_bug.cgi?id=100582
Reviewed by Eric Seidel.
All of the state, related to unknown pseudo-elements is already understood at the time of collecting rules.
We can just get rid of most of this code in StyleResolver.
At the time of matching rules, we know for certain that only rules that contain unknown pseudo-elements,
or are UA rules, or are explicitly invited by a TreeScope will match. So we can just return early in many cases.
No change in behavior, covered by existing tests.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector): Removed now-unnecessary param.
(WebCore::SelectorChecker::checkOneSelector): Ditto.
- css/SelectorChecker.h:
(SelectorChecker): Ditto.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver): Ditto.
(MatchingUARulesScope): Moved class definition here, since we now use it in a different place.
(WebCore::StyleResolver::collectMatchingRules): Changed the logic to stop matching rules that definitely won't match in a different scope.
(WebCore::StyleResolver::collectMatchingRulesForList): Removed code that's now unnecesssary.
(WebCore::StyleResolver::checkSelector): Removed now-unnecessary param.
(WebCore::StyleResolver::checkRegionSelector): Removed weird dead code.
- css/StyleResolver.h:
(StyleResolver): Removed now-unnecessary member.
- 2:42 PM Changeset in webkit [132753] by
-
- 12 edits21 adds6 deletes in trunk
Unreviewed, rolling out r132696.
http://trac.webkit.org/changeset/132696
https://bugs.webkit.org/show_bug.cgi?id=100609
Needs a bit more clean-up on Chrome Web UI side. (Requested by
dglazkov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-28
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderListBox.h:
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
- fast/forms/pseudo-elements-expected.html: Removed.
- fast/forms/pseudo-elements.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- 2:36 PM Changeset in webkit [132752] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, make always-true enum-to-int comparisons use casts.
- dfg/DFGFPRInfo.h:
(JSC::DFG::FPRInfo::debugName):
- dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
- 5:31 AM Changeset in webkit [132751] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2][AC] Viewport size does not change when the window size changes
https://bugs.webkit.org/show_bug.cgi?id=100573
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-28
Reviewed by Kenneth Rohde Christiansen.
The viewport size is set when we create the window the first time
and does not change automatically afterwards. When we change the window size,
we need to explicitly change the viewport size as well.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::createGLSurface):
- 5:17 AM Changeset in webkit [132750] by
-
- 17 edits in trunk/LayoutTests
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=100128
Rebaseline for http://trac.webkit.org/changeset/132718 and crrev.com/164515.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
- platform/chromium/TestExpectations:
- 1:20 AM Changeset in webkit [132749] by
-
- 4 edits in trunk/Source/JavaScriptCore
OSR exit compilation should defend against argument recoveries from code blocks that are no longer on the inline stack
https://bugs.webkit.org/show_bug.cgi?id=100601
Reviewed by Oliver Hunt.
This happened to me while I was fixing bugs for https://bugs.webkit.org/show_bug.cgi?id=100599.
I'm not sure how to reproduce this.
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(AssemblyHelpers):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- 12:06 AM Changeset in webkit [132748] by
-
- 2 edits7 adds in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip a failing test, update expected files.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
- platform/qt-5.0-wk2/http/tests/navigation/postredirect-basic-expected.txt: Added.
- platform/qt-5.0-wk2/http/tests/navigation/postredirect-goback1-expected.txt: Added.
Oct 27, 2012:
- 11:47 PM Changeset in webkit [132747] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for breakage to minimal bot caused by r132742.
Patch by Noam Rosenthal <noam.rosenthal@nokia.com> on 2012-10-27
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
Added appropriate ENABLE(REQUEST_ANIMATION_FRAME) flag.
- 11:27 PM Changeset in webkit [132746] by
-
- 3 edits1 add in trunk/Source/WebKit/chromium
[Chromium] Find-in-page reports matches in hidden iframes
https://bugs.webkit.org/show_bug.cgi?id=100604
Reviewed by Eric Seidel.
This is actually a regression caused by
http://trac.webkit.org/changeset/128784. This patch adds back some code
removed in WebFrameImpl::shouldScopeMatches in r128784.
This patch also introduces a test so that we don't make this mistake
again.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::shouldScopeMatches):
- tests/WebFrameTest.cpp:
- tests/data/find_in_hidden_frame.html: Added.
- 11:13 PM Changeset in webkit [132745] by
-
- 16 edits in trunk/Source/JavaScriptCore
DFG::Array::Mode needs to be cleaned up
https://bugs.webkit.org/show_bug.cgi?id=100599
Reviewed by Oliver Hunt.
Turn the previous massive Array::Mode enum into a class that contains four
fields, the type, whether it's a JSArray, the level of speculation, and the
kind of conversion to perform.
No performance or behavioral change.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::refine):
(JSC::DFG::ArrayMode::alreadyChecked):
(JSC::DFG::arrayTypeToString):
(JSC::DFG::arrayClassToString):
(DFG):
(JSC::DFG::arraySpeculationToString):
(JSC::DFG::arrayConversionToString):
(JSC::DFG::ArrayMode::toString):
- dfg/DFGArrayMode.h:
(DFG):
(ArrayMode):
(JSC::DFG::ArrayMode::ArrayMode):
(JSC::DFG::ArrayMode::type):
(JSC::DFG::ArrayMode::arrayClass):
(JSC::DFG::ArrayMode::speculation):
(JSC::DFG::ArrayMode::conversion):
(JSC::DFG::ArrayMode::asWord):
(JSC::DFG::ArrayMode::fromWord):
(JSC::DFG::ArrayMode::withSpeculation):
(JSC::DFG::ArrayMode::usesButterfly):
(JSC::DFG::ArrayMode::isJSArray):
(JSC::DFG::ArrayMode::isInBounds):
(JSC::DFG::ArrayMode::mayStoreToHole):
(JSC::DFG::ArrayMode::isOutOfBounds):
(JSC::DFG::ArrayMode::isSlowPut):
(JSC::DFG::ArrayMode::canCSEStorage):
(JSC::DFG::ArrayMode::lengthNeedsStorage):
(JSC::DFG::ArrayMode::modeForPut):
(JSC::DFG::ArrayMode::isSpecific):
(JSC::DFG::ArrayMode::supportsLength):
(JSC::DFG::ArrayMode::benefitsFromStructureCheck):
(JSC::DFG::ArrayMode::doesConversion):
(JSC::DFG::ArrayMode::arrayModesThatPassFiltering):
(JSC::DFG::ArrayMode::operator==):
(JSC::DFG::ArrayMode::operator!=):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape):
(JSC::DFG::canCSEStorage):
(JSC::DFG::lengthNeedsStorage):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
- dfg/DFGNode.h:
(JSC::DFG::Node::arrayMode):
(JSC::DFG::Node::setArrayMode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::typedArrayDescriptor):
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::putByValWillNeedExtraRegister):
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 11:10 PM Changeset in webkit [132744] by
-
- 4 edits in trunk/Source
All tests crash in WebKit1 mode
https://bugs.webkit.org/show_bug.cgi?id=100602
Reviewed by Sam Weinig.
- WebView/WebView.mm: (+[WebView _setLoadResourcesSerially:]): Resource load scheduler is created via a strategy, so strategies need to be initialized before using it.
- 10:49 PM Changeset in webkit [132743] by
-
- 12 edits in trunk/Source/WebKit2
Unreviewed, rolling out r132740.
http://trac.webkit.org/changeset/132740
https://bugs.webkit.org/show_bug.cgi?id=100603
"Causing many crashes" (Requested by weinig on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-27
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::DownloadProxy):
(WebKit::DownloadProxy::invalidate):
(WebKit):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createDownloadProxy):
(WebKit::WebContext::downloadFinished):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
(WebKit):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- UIProcess/WebPageProxy.h:
(CoreIPC):
(WebPageProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::~WebPageGroupProxy):
(WebKit):
(WebKit::WebPageGroupProxy::didReceiveMessage):
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
- WebProcess/WebPage/WebPageGroupProxy.h:
(CoreIPC):
(WebPageGroupProxy):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):
- 6:32 PM Changeset in webkit [132742] by
-
- 10 edits3 adds in trunk
Coordinated Graphics: Animation jerkiness when rAF is enabled
https://bugs.webkit.org/show_bug.cgi?id=100536
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
The jerkiness comes from the fact that we schedule animations excessively; That's because
the previous patch broke requestAnimationFrame behavior during CSS animations, since the
frame returns right away instead of waiting till the previous frame is actually rendered.
This patch makes sure that when animations are scheduled, they're only serviced after the
UI process has actually painted the previous frame. We do so by sending a
RequestAnimationFrame message to the UI process, which responds with AnimationFrameReady
after the UI process paints.
New test: fast/animations/request-animation-frame-too-rapid.html
Tests that we don't receive an unreasonably high number of callbacks from
requestAnimationFrame (> 1000FPS).
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::requestAnimationFrame):
(WebKit::LayerTreeCoordinatorProxy::animationFrameReady):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::paintToCurrentGLContext):
(WebKit):
(WebKit::LayerTreeRenderer::animationFrameReady):
(WebKit::LayerTreeRenderer::requestAnimationFrame):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit):
(WebKit::LayerTreeCoordinator::scheduleAnimation):
(WebKit::LayerTreeCoordinator::animationFrameReady):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.messages.in:
LayoutTests:
Added a test to make sure we don't respond too eagerly to requestAnimationFrame.
- fast/animation/request-animation-frame-too-rapid-expected.txt: Added.
- fast/animation/request-animation-frame-too-rapid.html: Added.
- fast/animation/script-tests/request-animation-frame-too-rapid.js: Added.
- 6:31 PM Changeset in webkit [132741] by
-
- 2 edits in trunk/Source/WebCore
Fix AVFoundation build.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::addKey):
- 1:48 PM Changeset in webkit [132740] by
-
- 12 edits in trunk/Source/WebKit2
Yet more MessageReceivering
https://bugs.webkit.org/show_bug.cgi?id=100325
Reviewed by Anders Carlsson.
Make DownloadProxy, WebPageProxy, and WebPageGroupProxy MessageReceivers.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::DownloadProxy):
(WebKit::DownloadProxy::invalidate):
(WebKit::DownloadProxy::didReceiveMessage):
(WebKit::DownloadProxy::didReceiveSyncMessage):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
Make a MessageReceiver.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::addMessageReceiver):
(WebKit::WebContext::removeMessageReceiver):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
Add additional MessageReceiverMap forwards, and stop dealing with DownloadProxy explicitly.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- UIProcess/WebPageProxy.h:
Make a MessageReceiver, but keep sub objects using didReceiveMessage for now (like WebPage).
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addMessageReceiver):
(WebKit::WebProcessProxy::removeMessageReceiver):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
Give WebProcessProxy a MessageReceiverMap and all the appropriate forwarding methods.
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
(WebKit::WebPageGroupProxy::~WebPageGroupProxy):
(WebKit::WebPageGroupProxy::didReceiveMessage):
- WebProcess/WebPage/WebPageGroupProxy.h:
(WebKit::WebPageGroupProxy::isVisibleToHistoryClient):
(WebPageGroupProxy):
Make a MessageReceiver and register/unregister with the WebProcess.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
Remove extraneous return statement.
(WebKit::WebProcess::didReceiveMessage):
Stop handling WebPageGroupProxy special.
- 1:33 PM Changeset in webkit [132739] by
-
- 4 edits in trunk/Source/WTF
Try to create AtomicString as 8 bit where possible
https://bugs.webkit.org/show_bug.cgi?id=100575
Reviewed by Oliver Hunt.
Added StringImpl::create8BitIfPossible() that first tries to create an 8 bit string. If it finds a 16 bit character
during processing, it calls the standard create() method. The assumption is that this will be used on mostly 8 bit
strings and ones that are shorter (in the tens of characters). Changed AtomicString to use the new creation method
for UChar based construction.
- wtf/text/AtomicString.cpp:
(WTF::UCharBufferTranslator::translate):
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::create8BitIfPossible):
- wtf/text/StringImpl.h:
(WTF::StringImpl::create8BitIfPossible):
- 1:31 PM Changeset in webkit [132738] by
-
- 8 edits in trunk/Source/WebKit2
Completely roll out https://bugs.webkit.org/show_bug.cgi?id=99251 (r131686)
It has caused too many crashes.
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/mac/WKView.mm:
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/mac/WKViewPrivate.h:
- UIProcess/mac/CorrectionPanel.mm:
- UIProcess/mac/WKFullScreenWindowController.mm:
- UIProcess/mac/WebFullScreenManagerProxyMac.mm:
- 11:27 AM Changeset in webkit [132737] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: m_next in LayoutState.cpp
https://bugs.webkit.org/show_bug.cgi?id=99796
Reviewed by Eric Seidel.
Before RenderMathMLBlock::computeChildrenPreferredLogicalHeights calls child->layoutIfNeeded(),
it must ensure a layoutState exists. We disable it in any case, since we are just calculating
metrics here, and the final layout may well happen again.
No new tests. I don't know how to create an automated test for this. The crashes users are
seeing are flaky.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
- 11:25 AM Changeset in webkit [132736] by
-
- 2 edits in trunk/Source/WTF
String::fromUTF8() should take advantage of the ASCII check in convertUTF8ToUTF16()
https://bugs.webkit.org/show_bug.cgi?id=100577
Reviewed by Oliver Hunt.
Passed is ASCII flag to convertUTF8ToUTF16() and if try, create an 8 bit string from the original arguments.
- wtf/text/WTFString.cpp:
(WTF::String::fromUTF8):
- 11:18 AM Changeset in webkit [132735] by
-
- 5 edits2 adds in trunk
[MathML] Improve some addChild methods
https://bugs.webkit.org/show_bug.cgi?id=98791
Reviewed by Eric Seidel.
Source/WebCore:
MathML addChild methods need to handle any anonymous renderers correctly. Actually, most MathML elements have a fixed
number of children, so conformant javascript won't be doing arbitrary addChild and removeChild calls. However, we don't
want any assertions to fail, and we do want addChild to work correctly when beforeChild == 0, to build up the original
renderer, and then replaceChild at least should work correctly after that. We therefore clean up these routines before
giving them to the chromium fuzzers.
It's best to build the anonymous wrappers just once initially if possible, so empty wrappers aren't left in the render
tree after later removeChild calls.
Test: mathml/presentation/dynamic.html added for mfrac and msqrt. There are already tests for dynamically changing
msub/sup elements, in mathml/presentation/m*-changed.xhtml.
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::addChild):
- The two wrappers are built initially. Also, the old RenderMathMLBlock::addChild(row, beforeChild); doesn't really work because beforeChild is buried inside a wrapper. This new routine allows the numerator and denominator to be added initially, and then later replaced with replaceChild. It's not clear whether e.g. a plain removeChild of a numerator should move the remaining child from the denominator to the numerator or not, so we ignore that for now.
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::addChild):
- A bit of bullet-proofing for the fuzzers.
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::addChild):
- Like RenderMathMLFraction::addChild, we create the wrappers once initially, and then fill them dynamically.
LayoutTests:
- mathml/presentation/dynamic-expected.html: Added.
- mathml/presentation/dynamic.html: Added.
- 11:17 AM Changeset in webkit [132734] by
-
- 2 edits in trunk/Source/WebKit2
buildHTTPHeaders() should use a StringBuilder instead of a Vector<UChar>
https://bugs.webkit.org/show_bug.cgi?id=100580
Reviewed by Oliver Hunt.
Replaced Vector<UChar> with StringBuilder in the HTTP header construction function buildHTTPHeaders.
This eliminates 8 -> 16 bit up conversion of the strings involved.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::buildHTTPHeaders):
- 11:16 AM Changeset in webkit [132733] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed gardening.
Removing my garbage, now from svn.
- platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png: Removed.
- 10:22 AM Changeset in webkit [132732] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed gardening.
Added one more png to a wrong path in my previous commit, removing it and hoping that
the directory will not stay in svn.
- platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Removed.
- 10:18 AM Changeset in webkit [132731] by
-
- 3 edits2 adds in trunk
Background images can incorrectly repeat with sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=94622
Reviewed by Emil A Eklund.
Source/WebCore:
Attempting to better match author expectations when painting tiled background images. When under
the effects of zoom with sub-pixel layout enabled, the drawn size of a rendered element can
differ depending on its location. This change looks at the size of the scaled tiled background
image size, and either ceils or floors that value depending on if tiling that value will
result in us being one pixel or less short of covering the background size. This is a heuristic,
as sub-pixel/zooming isn't specced.
Test: fast/sub-pixel/scaled-background-image.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::applySubPixelHeuristicForTileSize):
(WebCore):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
LayoutTests:
- fast/sub-pixel/scaled-background-image-expected.html: Added.
- fast/sub-pixel/scaled-background-image.html: Added.
- 10:15 AM Changeset in webkit [132730] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r132725.
http://trac.webkit.org/changeset/132725
https://bugs.webkit.org/show_bug.cgi?id=100596
it broke linking on chromium debug bots (Requested by loislo
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-27
- inspector/InspectorMemoryAgent.cpp:
(WebCore::addPlatformComponentsInfo):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
- platform/MemoryUsageSupport.h:
(ComponentInfo):
(WebCore::MemoryUsageSupport::ComponentInfo::ComponentInfo):
(MemoryUsageSupport):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
- platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
- platform/qt/MemoryUsageSupportQt.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
- 9:14 AM Changeset in webkit [132729] by
-
- 49 edits in trunk
REAL_PLATFORM_NAME build setting is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=100587
Reviewed by Mark Rowe.
Removed the definition of REAL_PLATFORM_NAME and replaced references to it with references
to PLATFORM_NAME.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/JSC.xcconfig:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/ToolExecutable.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/CompilerVersion.xcconfig:
- gtest/xcode/Config/General.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/BaseTarget.xcconfig:
- Configurations/CompilerVersion.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/WebKit2.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/CompilerVersion.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/CompilerVersion.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 9:07 AM Changeset in webkit [132728] by
-
- 1 edit27 adds in trunk/LayoutTests
Pixel tests need rebaseline https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed gardening.
Reland Qt-WebKit2 new expectations part 2 with fixed paths.
- platform/qt-5.0-wk2/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/full-screen-stacking-context-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/full-screen-zIndex-after-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/full-screen-zIndex-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
- platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png: Added.
- 9:05 AM Changeset in webkit [132727] by
-
- 1 edit75 adds in trunk/LayoutTests
Pixel tests need rebaseline https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed gardening.
Reland Qt-WebKit2 new expectations part 1 with fixed paths.
- platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Added.
- platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Added.
- platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Added.
- platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Added.
- platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Added.
- 8:13 AM Changeset in webkit [132726] by
-
- 12 edits in trunk
Remove internals shouldDisplayTrackKind methods; these are also on internals.settings
https://bugs.webkit.org/show_bug.cgi?id=100564
Reviewed by Adam Barth.
Source/WebCore:
Remove duplicate methods from internals that was just forwarding on the call to internals.settings.
Also fix a bug where we didn't reset these settings properly.
No new tests, this is covered by existing media/track tests.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Properly save display track settings.
(WebCore::InternalSettings::Backup::restoreTo): Restore display track settings.
- testing/InternalSettings.h:
- testing/InternalSettings.idl: Use [Conditional=VIDEO_TRACK].
- testing/Internals.cpp: Remove code.
- testing/Internals.h: Remove code.
- testing/Internals.idl: Remove code.
LayoutTests:
Update tests to use the internals.settings method.
- media/track/track-language-preference-expected.txt:
- media/track/track-language-preference.html:
- media/track/track-prefer-captions-expected.txt:
- media/track/track-prefer-captions.html:
- 8:11 AM Changeset in webkit [132725] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: instrument chromium GlyphCache. It keeps ~2mb.
https://bugs.webkit.org/show_bug.cgi?id=100515
Reviewed by Yury Semikhatsky.
I replaced old version with an abstract number with new one which precisely reports allocated SkGlyphCache objects and their sizes.
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::reportMemoryUsage):
- platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
- platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(reportMemoryUsage):
(WebCore::reportGlyphCache):
(WebCore):
(WebCore::MemoryUsageSupport::reportMemoryUsage):
- platform/qt/MemoryUsageSupportQt.cpp:
(WebCore::MemoryUsageSupport::reportMemoryUsage):
- 12:01 AM Changeset in webkit [132724] by
-
- 5 edits2 adds in trunk
Prevent NaN offset values in ElementTimeControl.
https://bugs.webkit.org/show_bug.cgi?id=100322
Reviewed by Abhishek Arya.
Source/WebCore:
NaN values can cause ElementTimeControl to go back in time!
If a value of NaN is passed to ElementTimeControl::beginElementAt(offset),
subsequent sorting will cause an assert in SVGSMILElement::findInstanceTime
because NaN values are not properly sorted. NaN SMILTime values
should not be allowed at all, so this patch adds a check for them in
ElementTimeControl's setters.
This patch also adds preventative asserts to catch if SMILTime is ever
initialized with NaN, or if addEndTime/addBeginTime are ever called
with NaN values.
Test: svg/custom/elementTimeControl-nan-crash.html
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):
- svg/animation/SMILTime.h:
(WebCore::SMILTime::SMILTime):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):
LayoutTests:
- svg/custom/elementTimeControl-nan-crash-expected.txt: Added.
- svg/custom/elementTimeControl-nan-crash.html: Added.
Oct 26, 2012:
- 11:55 PM Changeset in webkit [132723] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip new failing tests.
- platform/qt/TestExpectations:
- 11:00 PM Changeset in webkit [132722] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Browser prematurely sends wrong credentials
https://bugs.webkit.org/show_bug.cgi?id=100585
Reviewed by Yong Li.
Manually revert the patch for bug 96362, which causes regressions and the right patch has been
submitted with patch for bug 100448. Since the auto-revert fails, we use this patch to manually
revert.
No new tests. The test is coverted by patch for 100448.
- platform/network/blackberry/CredentialBackingStore.cpp:
- platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- 10:59 PM Changeset in webkit [132721] by
-
- 24 edits4 copies4 adds in trunk/Source
Have NetworkProcess manage resource load scheduling.
https://bugs.webkit.org/show_bug.cgi?id=100479
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Down in WebCore we need to virtualize a handful of ResourceLoadScheduler methods
to be overridden by WebKit's implementation.
No new tests (No change in Core behavior).
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- loader/ResourceLoadScheduler.cpp:
(WebCore::resourceLoadScheduler): Gracefully handle LoaderStrategies wanting to return the default scheduler.
(WebCore::ResourceLoadScheduler::scheduleLoad): Call notifyDidScheduleResourceRequest.
(WebCore::ResourceLoadScheduler::notifyDidScheduleResourceRequest): Moved InspectorInstrumentation call
here so derived classes can do it indirectly.
(WebCore::ResourceLoadScheduler::startResourceLoader): To allow derived classes the ability to call
ResourceLoader::start() which only ResourceLoadScheduler can do.
- loader/ResourceLoadScheduler.h:
(ResourceLoadScheduler): Virtualize some core public methods so they can be overridden.
(WebCore::ResourceLoadScheduler::setSerialLoadingEnabled): Make virtual.
(WebCore::ResourceLoadScheduler::isSuspendingPendingRequests): Make private as it's internal only.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::setIdentifier): Add this setter so outside clients can manually change the identifier.
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::identifier): Change identifier to explicitly be uint64_t.
(WebCore::ResourceLoader::request): Make public.
(ResourceLoader):
Source/WebKit2:
Implement a ResourceLoadScheduler that models the same behavior as WebCore::ResourceLoadScheduler.
The WebProcess scheduler acts as a marshall to the NetworkProcess scheduler via CoreIPC messaging.
Besides MainResourceLoads which are started directly in the WebProcess, all other loads are now
started only when the NetworkProcess tells them to start.
Build-system and messaging related stuff:
- DerivedSources.make:
- Platform/CoreIPC/MessageID.h:
- WebKit2.xcodeproj/project.pbxproj:
Add a new Network logging channel.
- Platform/Logging.cpp:
(WebKit::getChannelFromName):
- Platform/Logging.h:
Modeled after ResourceLoadScheduler::HostInformation but more specifically geared towards what NetworkProcess needs to track:
- NetworkProcess/HostRecord.cpp: Added.
(WebKit::HostRecord::HostRecord):
(WebKit::HostRecord::~HostRecord):
(WebKit::HostRecord::schedule):
(WebKit::HostRecord::addLoadInProgress):
(WebKit::HostRecord::remove):
(WebKit::HostRecord::hasRequests):
(WebKit::HostRecord::limitRequests):
- NetworkProcess/HostRecord.h:
(WebKit::HostRecord::name):
(WebKit::HostRecord::requestsPending):
Gateway messaging from the WebResourceLoadScheduler to the NetworkResourceLoadScheduler:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::registerObserver):
(WebKit::NetworkConnectionToWebProcess::unregisterObserver):
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::scheduleNetworkRequest):
(WebKit::NetworkConnectionToWebProcess::addLoadInProgress):
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):
(WebKit::NetworkConnectionToWebProcess::crossOriginRedirectReceived):
(WebKit::NetworkConnectionToWebProcess::servePendingRequests):
(WebKit::NetworkConnectionToWebProcess::suspendPendingRequests):
(WebKit::NetworkConnectionToWebProcess::resumePendingRequests):
(WebKit::NetworkConnectionToWebProcess::setSerialLoadingEnabled):
- NetworkProcess/NetworkConnectionToWebProcess.h:
(NetworkConnectionToWebProcessObserver): Add an observer interface so arbitrary objects can be notified if
a Network->WebProcess connection closes.
(WebKit::NetworkConnectionToWebProcessObserver::~NetworkConnectionToWebProcessObserver):
(WebKit::NetworkConnectionToWebProcess::isSerialLoadingEnabled):
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
Represents a request, ResourceLoadIdentifier, and connection that all correspond to the same pending NetworkLoad:
- NetworkProcess/NetworkRequest.cpp:
(WebKit::NetworkRequest::NetworkRequest):
(WebKit::NetworkRequest::~NetworkRequest):
(WebKit::NetworkRequest::connectionToWebProcessDidClose): Using the NetworkConnectionToWebProcessObserver interface,
if the connection closes then clear out the connection pointer for this request that is now irrelevant.
- NetworkProcess/NetworkRequest.h:
(WebKit::NetworkRequest::create):
(WebKit::NetworkRequest::identifier):
(WebKit::NetworkRequest::connectionToWebProcess):
Manages connection-per-host scheduling with the same structure as WebCore::ResourceLoadScheduling but also with IPC:
- NetworkProcess/NetworkResourceLoadScheduler.cpp: Added.
(WebKit::NetworkResourceLoadScheduler::NetworkResourceLoadScheduler):
(WebKit::NetworkResourceLoadScheduler::scheduleServePendingRequests):
(WebKit::NetworkResourceLoadScheduler::requestTimerFired):
(WebKit::NetworkResourceLoadScheduler::scheduleNetworkRequest):
(WebKit::NetworkResourceLoadScheduler::addLoadInProgress):
(WebKit::NetworkResourceLoadScheduler::hostForURL):
(WebKit::NetworkResourceLoadScheduler::removeLoadIdentifier):
(WebKit::NetworkResourceLoadScheduler::crossOriginRedirectReceived):
(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
(WebKit::NetworkResourceLoadScheduler::servePendingRequestsForHost): Serve as many requests for the host as we should,
skipping the NetworkRequests who have lost their connection to their WebProcess.
(WebKit::NetworkResourceLoadScheduler::suspendPendingRequests):
(WebKit::NetworkResourceLoadScheduler::resumePendingRequests):
- NetworkProcess/NetworkResourceLoadScheduler.h: Added.
- NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm: Added.
(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::networkResourceLoadScheduler): Add a scheduler global to the NetworkProcess.
A thin derivation of WebCore::ResourceLoadScheduler, most of what WebResourceLoadScheduler does is handle IPC to the NetworkProcess:
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::WebResourceLoadScheduler):
(WebKit::WebResourceLoadScheduler::scheduleSubresourceLoad):
(WebKit::WebResourceLoadScheduler::schedulePluginStreamLoad):
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::addMainResourceLoad):
(WebKit::WebResourceLoadScheduler::remove):
(WebKit::WebResourceLoadScheduler::crossOriginRedirectReceived):
(WebKit::WebResourceLoadScheduler::servePendingRequests):
(WebKit::WebResourceLoadScheduler::suspendPendingRequests):
(WebKit::WebResourceLoadScheduler::resumePendingRequests):
(WebKit::WebResourceLoadScheduler::setSerialLoadingEnabled):
(WebKit::WebResourceLoadScheduler::startResourceLoad):
- WebProcess/Network/WebResourceLoadScheduler.h:
Add the ability for the NetworkProcess to message back to the WebProcess telling it to start a resource load:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
(WebKit::NetworkProcessConnection::startResourceLoad):
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Network/NetworkProcessConnection.messages.in:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::resourceLoadScheduler): Only return the WebResourceLoadScheduler if NetworkProcess is enabled.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection): Actually keep the NetworkProcessConnection around in a member variable.
(WebKit::WebProcess::networkConnection):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::usesNetworkProcess): Expose this for platform strategies sake.
- 7:10 PM Changeset in webkit [132720] by
-
- 5 edits4 adds in trunk
Implement AudioBufferSourceNode .loopStart and .loopEnd attributes
https://bugs.webkit.org/show_bug.cgi?id=100170
Reviewed by Kenneth Russell.
Source/WebCore:
AudioBufferSourceNode currently only supports looping of an entire AudioBuffer.
Sample-based synthesis is a very common technique which requires "internal" loop-points.
For example, the first part of the sample data might represent the attack portion of
a synthesized instrument, which then enters a loop portion.
Tests: webaudio/audiobuffersource-loop-comprehensive.html
webaudio/audiobuffersource-loop-points.html
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):
- Modules/webaudio/AudioBufferSourceNode.h:
(AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::loopStart):
(WebCore::AudioBufferSourceNode::loopEnd):
(WebCore::AudioBufferSourceNode::setLoopStart):
(WebCore::AudioBufferSourceNode::setLoopEnd):
- Modules/webaudio/AudioBufferSourceNode.idl:
LayoutTests:
- webaudio/audiobuffersource-loop-comprehensive-expected.txt: Added.
- webaudio/audiobuffersource-loop-comprehensive.html: Added.
- webaudio/audiobuffersource-loop-points-expected.wav: Added.
- webaudio/audiobuffersource-loop-points.html: Added.
- 7:07 PM Changeset in webkit [132719] by
-
- 8 edits in trunk/LayoutTests
[Chromium] Test expectation update.
Rebaseline for recent forms changes.
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium/TestExpectations:
- 6:53 PM Changeset in webkit [132718] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Convert Chromium template string to an LDML date format
https://bugs.webkit.org/show_bug.cgi?id=100128
Reviewed by Tony Chang.
- src/LocalizedStrings.cpp:
(WebCore): Include WebCore/platform/text/DateTimeFormat.h.
(WebCore::weekFormatInLDML):
Replace $1 with yyyy, $2 with ww, and quote other parts.
- 6:37 PM Changeset in webkit [132717] by
-
- 1 edit1 add in trunk/PerformanceTests
Add a microbenchmark for Hindi (complex-text) line-layout
https://bugs.webkit.org/show_bug.cgi?id=100024
Reviewed by Ryosuke Niwa.
I wrote this to make sure that we don't regress line-breaking performance
for the complex-text codepath. This test has shown me that TOT is
already 5% slower than Safari 6.0.1 here. :(
- Layout/hindi-line-layout.html: Added.
- 6:31 PM Changeset in webkit [132716] by
-
- 7 edits2 adds in trunk
dragover's default action should prevent drop for file drags
https://bugs.webkit.org/show_bug.cgi?id=79173
Reviewed by Tony Chang.
Source/WebCore:
During a file drag, we need to keep track of whether or not the document has cancelled the
dragover action. We should only send a drop event if the dragover event was cancelled; this
matches the behavior of the spec, as well as IE, Gecko, and Opera. The relevant sections
from the spec are the sections pertaining to dragover and drop events at:
http://www.whatwg.org/specs/web-apps/current-work/#drag-and-drop-processing-model
Test: fast/events/only-valid-drop-targets-receive-file-drop.html
- page/DragController.cpp:
(WebCore::DragController::performDrag):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag):
- page/DragController.h:
(DragController): Cleanup to repurpose a variable that doesn't need to be a member anymore
and remove the corresponding getter/setter.
LayoutTests:
- fast/dom/shadow/drop-event-in-shadow.html:
Added dragover handler as required by the HTML specification.
- fast/events/input-element-display-none-in-dragleave-crash.html:
Added dragover handler as required by the HTML specification.
- fast/events/only-valid-drop-targets-receive-file-drop-expected.txt: Added.
- fast/events/only-valid-drop-targets-receive-file-drop.html: Added.
- http/tests/security/clipboard/clipboard-file-access.html:
Added dragover handler as required by the HTML specification.
- 6:20 PM Changeset in webkit [132715] by
-
- 2 edits in trunk/Source/WebCore
Fix a operator ordering bug in SVGSMILElement::calculateAnimationPercentAndRepeat
https://bugs.webkit.org/show_bug.cgi?id=94756
Reviewed by Dirk Schulze.
The function has an early exit for !simpleDuration.value(), so
!simpleDuration.value() always is 0 when passed as second parameter to
fmod(), which means fmod() always returns NaN, which always evaluates
to true. Simplify the code by removing that explicit check.
No observable behavior change.
Covered by existing svg tests.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
- 6:01 PM Changeset in webkit [132714] by
-
- 2 edits in trunk/Source/WebKit2
Crash in WebProces at WebCore::ResourceLoadScheduler::crossOriginRedirectReceived + 78
https://bugs.webkit.org/show_bug.cgi?id=100554
Reviewed by Alexey Proskuryakov.
For now, just have WebPlatformStrategies return the same default resourceLoadScheduler that
WebCore knows about.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::resourceLoadScheduler):
- 5:17 PM Changeset in webkit [132713] by
-
- 12 edits3 adds in trunk
Source/WebKit2: Crash when making NPRuntime calls with a null NPP pointer
https://bugs.webkit.org/show_bug.cgi?id=100569
<rdar://problem/11726426>
<rdar://problem/12352836>
Reviewed by Darin Adler.
Finally bite the bullet and remove the assertion from NetscapePlugin::fromNPP. The WebKit1 equivalent of this
function used to return the plug-in currently being initialized in NPP_New, but we've never done that in WebKit2
and it has never been necessary. The crashes fixed here are not from calls underneath NPP_New so fixing it wouldn't
do us any good anyway.
Also, make the PluginDestructionProtector handle a null plug-in gracefully.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::PluginDestructionProtector::PluginDestructionProtector):
(PluginDestructionProtector):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::fromNPP):
Tools: Crash when making NPRuntime calls with a null NPP pointer
https://bugs.webkit.org/show_bug.cgi?id=100569
Reviewed by Darin Adler.
Add new NPRuntimeCallsWithNullNPP plug-in test.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_ReleaseVariantValue):
(PluginTest::netscapeFuncs):
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
(PluginTest):
- DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp: Added.
(NPRuntimeCallsWithNullNPP):
(NPRuntimeCallsWithNullNPP::NPRuntimeCallsWithNullNPP):
(NPRuntimeCallsWithNullNPP::NPP_New):
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- GNUmakefile.am:
LayoutTests: Crash when making NPRuntime calls with a null NPP pointer
https://bugs.webkit.org/show_bug.cgi?id=100569
Reviewed by Darin Adler.
Add new tests.
- plugins/npruntime/npruntime-calls-with-null-npp-expected.txt: Added.
- plugins/npruntime/npruntime-calls-with-null-npp.html: Added.
- 4:55 PM Changeset in webkit [132712] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r132695.
http://trac.webkit.org/changeset/132695
https://bugs.webkit.org/show_bug.cgi?id=100581
caused 20+ test crashes on bots (Requested by estes on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::suspendPostAttachCallbacks):
(WebCore::ContainerNode::resumePostAttachCallbacks):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):
- loader/ResourceLoadScheduler.cpp:
(WebCore::resourceLoadScheduler):
- loader/ResourceLoadScheduler.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::willSendRequest):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::performPostLoadActions):
- 4:36 PM Changeset in webkit [132711] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r132689.
http://trac.webkit.org/changeset/132689
https://bugs.webkit.org/show_bug.cgi?id=100574
Broke HashMaps containing RetainPtrs (Requested by andersca on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- wtf/RetainPtr.h:
- 4:28 PM Changeset in webkit [132710] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r132702.
http://trac.webkit.org/changeset/132702
https://bugs.webkit.org/show_bug.cgi?id=100322
Compile error on Chromium Linux dbg builder (and others)
Source/WebCore:
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):
- svg/animation/SMILTime.h:
(WebCore::SMILTime::SMILTime):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):
LayoutTests:
- svg/custom/elementTimeControl-nan-crash-expected.txt: Removed.
- svg/custom/elementTimeControl-nan-crash.html: Removed.
- 4:21 PM Changeset in webkit [132709] by
-
- 3 edits in trunk/Source/WebKit2
Add pids to WebMemorySampleFiles.
https://bugs.webkit.org/show_bug.cgi?id=100449.
Reviewed by Tim Horton.
Make it easier to associate WebMemorySamples with a process. Add the pid to the filename and header.
- Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::initializeTimers): Update notification.
(WebKit::WebMemorySampler::stop): Update notification.
(WebKit::WebMemorySampler::writeHeaders): dump pid in the header.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::processDidFinishLaunching): append pid to filename.
- 4:03 PM Changeset in webkit [132708] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Allow embedder to enter/leave force compositing mode
https://bugs.webkit.org/show_bug.cgi?id=100458
Patch by James Robinson <jamesr@chromium.org> on 2012-10-26
Reviewed by Adrienne Walker.
This adds API for the embedder to decide when to enter and leave force compositing mode since it's
more efficient to only toggle this setting when the embedder is about to produce a frame.
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::enterForceCompositingMode):
- src/WebFrameImpl.cpp:
(WebKit::WebViewImpl::enterForceCompositingMode):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- 3:59 PM Changeset in webkit [132707] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, remove one more test that consistently passes according to the flakiness dashboard.
- platform/chromium/TestExpectations:
- 3:45 PM Changeset in webkit [132706] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2][AC] Build fix after r132647.
https://bugs.webkit.org/show_bug.cgi?id=100540
Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
AC enabled build is broken after the latest refactoring of EFL WK2.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::exitAcceleratedCompositingMode):
(EwkViewImpl::informContentsSizeChange):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
(EwkViewImpl::pageViewportControllerClient):
(EwkViewImpl::pageViewportController):
(EwkViewImpl::evasGl):
(EwkViewImpl::evasGlContext):
(EwkViewImpl::evasGlSurface):
(EwkViewImpl::resetEvasGlSurface):
- UIProcess/API/efl/ewk_view.cpp:
(mapToWebContent):
(_ewk_view_smart_calculate):
- 3:42 PM Changeset in webkit [132705] by
-
- 3 edits in trunk/LayoutTests
[chromium] Unreviewed, remove tests that consistently pass.
- platform/chromium-mac-mountainlion/TestExpectations: Some tests still need 10.8 baselines. Add them to this file.
- platform/chromium/TestExpectations:
- 3:36 PM Changeset in webkit [132704] by
-
- 8 edits in tags/Safari-537.16/Source/JavaScriptCore
Merged r132701.
- 3:31 PM Changeset in webkit [132703] by
-
- 8 edits in tags/Safari-537.16/Source/JavaScriptCore
Rollout r132674.
- 3:29 PM Changeset in webkit [132702] by
-
- 5 edits2 adds in trunk
Prevent NaN offset values in ElementTimeControl.
https://bugs.webkit.org/show_bug.cgi?id=100322
Reviewed by Abhishek Arya.
Source/WebCore:
NaN values can cause ElementTimeControl to go back in time!
If a value of NaN is passed to ElementTimeControl::beginElementAt(offset),
subsequent sorting will cause an assert in SVGSMILElement::findInstanceTime
because NaN values are not properly sorted. NaN SMILTime values
should not be allowed at all, so this patch adds a check for them in
ElementTimeControl's setters.
This patch also adds preventative asserts to catch if SMILTime is ever
initialized with NaN, or if addEndTime/addBeginTime are ever called
with NaN values.
Test: svg/custom/elementTimeControl-nan-crash.html
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):
- svg/animation/SMILTime.h:
(WebCore::SMILTime::SMILTime):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):
LayoutTests:
- svg/custom/elementTimeControl-nan-crash-expected.txt: Added.
- svg/custom/elementTimeControl-nan-crash.html: Added.
- 3:18 PM Changeset in webkit [132701] by
-
- 8 edits in trunk/Source/JavaScriptCore
Forward OSR calculation is wrong in the presence of multiple SetLocals, or a mix of SetLocals and Phantoms
https://bugs.webkit.org/show_bug.cgi?id=100461
Reviewed by Oliver Hunt and Gavin Barraclough.
This does a couple of things. First, it removes the part of the change in r131822 that made the forward
OSR exit calculator capable of handling multiple SetLocals. That change was wrong, because it would
blindly assume that all SetLocals had the same ValueRecovery, and would ignore the possibility that if
there is no value recovery then a ForwardCheckStructure on the first SetLocal would not know how to
recover the state associated with the second SetLocal. Then, it introduces the invariant that any bytecode
op that decomposes into multiple SetLocals must first emit dead SetLocals as hints and then emit a second
set of SetLocals to actually do the setting of the locals. This means that if a ForwardCheckStructure (or
any other hoisted forward speculation) is inserted, it will always be inserted on the second set of
SetLocals (since hoisting only touches the live ones), at which point OSR will already know about the
mov hints implied by the first set of (dead) SetLocals. This gives us the behavior we wanted, namely, that
a ForwardCheckStructure applied to a variant set by a resolve_with_base-like operation can correctly do a
forward exit while also ensuring that prior to exiting we set the appropriate locals.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
(OSRExit):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
- 2:59 PM Changeset in webkit [132700] by
-
- 57 edits in trunk
Move non-Settings Inspector methods from internals.settings to internals
https://bugs.webkit.org/show_bug.cgi?id=100392
Reviewed by Adam Barth.
Source/WebCore:
These methods don't have to do with the WebCore Settings object, so move them up to internals.
I moved the reset code from InternalSettings to Internals.
No new tests, this is just a rename. Existing tests should pass.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Remove inspector methods.
(WebCore::InternalSettings::Backup::restoreTo): Remove inspector methods.
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): New method for resetting page state. Named after similar
methods in WTR.
(WebCore::Internals::setInspectorResourcesDataSizeLimits): Moved from InspectorSettings.
(WebCore::Internals::setJavaScriptProfilingEnabled): Moved from InspectorSettings.
- testing/Internals.h:
- testing/Internals.idl:
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): Reset state in Internals.
- testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): Reset state in Internals.
LayoutTests:
Update tests to use internals.setJavaScriptProfilingEnabled instead of internals.settings.setJavaScriptProfilingEnabled.
Update tests to use internals.setInspectorResourcesDataSizeLimits instead of internals.settings.setInspectorResourcesDataSizeLimits.
- fast/profiler/anonymous-event-handler.html:
- fast/profiler/anonymous-function-called-from-different-contexts.html:
- fast/profiler/anonymous-function-calls-built-in-functions.html:
- fast/profiler/anonymous-function-calls-eval.html:
- fast/profiler/anonymous-functions-with-display-names.html:
- fast/profiler/apply.html:
- fast/profiler/built-in-function-calls-anonymous.html:
- fast/profiler/built-in-function-calls-user-defined-function.html:
- fast/profiler/call-register-leak.html:
- fast/profiler/call.html:
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
- fast/profiler/compare-multiple-profiles.html:
- fast/profiler/constructor.html:
- fast/profiler/dead-time.html:
- fast/profiler/document-dot-write.html:
- fast/profiler/event-handler.html:
- fast/profiler/execution-context-and-eval-on-same-line.html:
- fast/profiler/inline-event-handler.html:
- fast/profiler/many-calls-in-the-same-scope.html:
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
- fast/profiler/multiple-and-different-scoped-function-calls.html:
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html:
- fast/profiler/multiple-frames.html:
- fast/profiler/named-functions-with-display-names.html:
- fast/profiler/nested-anonymous-functon.html:
- fast/profiler/nested-start-and-stop-profiler.html:
- fast/profiler/no-execution-context.html:
- fast/profiler/one-execution-context.html:
- fast/profiler/profile-calls-in-included-file.html:
- fast/profiler/profile-with-no-title.html:
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
- fast/profiler/profiling-from-a-nested-location.html:
- fast/profiler/simple-event-call.html:
- fast/profiler/simple-no-level-change.html:
- fast/profiler/start-and-stop-profiler-multiple-times.html:
- fast/profiler/start-and-stop-profiling-in-the-same-function.html:
- fast/profiler/start-but-dont-stop-profiling.html:
- fast/profiler/stop-profiling-after-setTimeout.html:
- fast/profiler/stop-then-function-call.html:
- fast/profiler/two-execution-contexts.html:
- fast/profiler/user-defined-function-calls-built-in-functions.html:
- fast/profiler/window-dot-eval.html:
- http/tests/inspector/network-test.js:
(resetInspectorResourcesData):
- http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html:
- http/tests/inspector/network/network-content-replacement-embed.html:
- http/tests/inspector/network/network-content-replacement-xhr.html:
- inspector/profiler/cpu-profiler-profiling-without-inspector.html:
- 2:57 PM Changeset in webkit [132699] by
-
- 27 edits6 adds in trunk
AX: Notification should be sent when accessibilityIsIgnored changes
https://bugs.webkit.org/show_bug.cgi?id=99547
Reviewed by Chris Fleizach.
Source/WebCore:
Adds a new flag in AccessibilityObject that keeps track of the most recent
value of accessibilityIsIgnored(). After certain events such as an ARIA
attribute change or content change, checks the new value of
accessibilityIsIgnored() and posts a "children changed" notification on the
parent node if it changed, making sure the parent recomputes its vector of
(unignored) children.
Also moves handling of attribute changes to AXObjectCache, and sends
notifications for some attribute changes that were previously silent. On
Chromium, all changes to an accessibility object's attributes should
result in some notification.
Some tests would have broken because an AccessibilityScrollView was created
and holding a reference to a ScrollView for an iframe after it was deleted,
so this change switches AccessibilityScrollView to hold a weak reference
to ScrollView instead.
Tests: platform/chromium/accessibility/is-ignored-change-sends-notification.html
platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html
platform/chromium/accessibility/text-change-notification.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::textChanged):
(WebCore):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
(WebCore::AXObjectCache::recomputeIsIgnored):
- accessibility/AXObjectCache.h:
(AXObjectCache):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::textChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::recomputeIsIgnored):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::insertChild):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::cachedIsIgnoredValue):
(WebCore):
(WebCore::AccessibilityObject::setCachedIsIgnoredValue):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::textChanged):
(AccessibilityObject):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
(WebCore::AccessibilityRenderObject::textChanged):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::addChildren):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::~AccessibilityScrollView):
(WebCore):
(WebCore::AccessibilityScrollView::detach):
(WebCore::AccessibilityScrollView::isAttachment):
(WebCore::AccessibilityScrollView::widgetForAttachmentView):
(WebCore::AccessibilityScrollView::updateScrollbars):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::documentFrameView):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):
- accessibility/AccessibilityScrollView.h:
(WebCore::AccessibilityScrollView::scrollView):
(AccessibilityScrollView):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
- accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createAndAppendRootInlineBox):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
Source/WebKit/chromium:
Adds new accessibility notifications.
- public/WebAccessibilityNotification.h:
- src/AssertMatchingEnums.cpp:
Tools:
Add additional accessibility notifications.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::postAccessibilityNotification):
LayoutTests:
Adds 3 new test to ensure:
- A "children changed" notification is fired on the parent object when an object that was previously ignored becomes unignored.
- A notification is sent when an element's text (incl. title or label) changes.
- A notification is sent when another ARIA attribute changes.
Modifies add-to-menu-list-crashes because it was too brittle; it was
referencing a stale object rather than retrieving its latest handle.
Modifies aria-checkbox-sends-notification to listen on the correct
object on all platforms.
Simplifies notification-listeners so it doesn't generate additional
notifications that are inconsistent between platforms now.
- accessibility/aria-checkbox-sends-notification.html:
- accessibility/notification-listeners.html:
- platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt:
- platform/chromium/accessibility/add-to-menu-list-crashes.html:
- platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt: Added.
- platform/chromium/accessibility/is-ignored-change-sends-notification.html: Added.
- platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt: Added.
- platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html: Added.
- platform/chromium/accessibility/text-change-notification-expected.txt: Added.
- platform/chromium/accessibility/text-change-notification.html: Added.
- 2:55 PM Changeset in webkit [132698] by
-
- 9 edits in trunk/Source/WebCore
[WebKitIDL] Optional dictionary types should have default values of empty dictionary
https://bugs.webkit.org/show_bug.cgi?id=100547
Reviewed by Adam Barth.
Per WebIDL, "Optional dictionary type arguments are always considered to have a default
value of an empty dictionary." WebKitIDL already supported this via the extended attribute
[Optional=DefaultIsUndefined] but make this the default for Dictionary.
Binding test expectations updated.
- Modules/filesystem/DirectoryEntry.h: Remove default parameters.
(DirectoryEntry):
- Modules/indexeddb/IDBDatabase.h: Remove overloads.
(IDBDatabase):
- Modules/indexeddb/IDBObjectStore.h: Remove overloads.
(IDBObjectStore):
- Modules/mediastream/RTCPeerConnection.idl: Remove DefaultIsUndefined annotations.
- bindings/scripts/CodeGeneratorJS.pm: Special case for Optional Dictionary.
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOptionsObject): Updated expectation - no early call.
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::optionsObjectCallback): Ditto.
- 2:41 PM Changeset in webkit [132697] by
-
- 8 edits in tags/Safari-537.16/Source/WebCore
Merged r132695. <rdar://problem/12575514>
- 2:36 PM Changeset in webkit [132696] by
-
- 12 edits6 adds21 deletes in trunk
Generated should not be supported for things with a shadow
https://bugs.webkit.org/show_bug.cgi?id=98836
Unreviewed rollout of rollout of http://trac.webkit.org/changeset/132269.
Initial rollout was speculative and was shown not to be related to crashes.
Change author: Elliott Sprehn <esprehn@chromium.org>
Source/WebCore:
As far as CSS is concerned inputs and things with shadow content inside
shouldn't support pseudo elements like :before, :after or :first-letter.
Neither Gecko or Presto supports it, and we only accidentally supported
it.
Until the spec tells us what to do we should disable support. This is
also neccesary because the new generated content implementation doesn't
support shadows.
Test: fast/forms/pseudo-elements.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderListBox.h:
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
LayoutTests:
Change all pseudos on <input> tests to be ref tests and clean up the tests.
They now make sure we don't support generated content on things with a shadow.
Also added another test for the other form control types to ensure they don't
support pseudos either.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
- fast/forms/pseudo-elements-expected.html: Added.
- fast/forms/pseudo-elements.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
- platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
- 2:30 PM Changeset in webkit [132695] by
-
- 8 edits in trunk/Source/WebCore
Crash in WebProces at WebCore::ResourceLoadScheduler::crossOriginRedirectReceived + 78
<rdar://problem/12575514> and https://bugs.webkit.org/show_bug.cgi?id=100554
Reviewed by Alexey Proskuryakov.
This was fallout from http://trac.webkit.org/changeset/132501 where I missed some of the
spots that call resourceLoadScheduler().
As a result we were creating more than one ResourceLoadScheduler, allowing the host records
to get out of sync.
The fix that also results in less #ifdefs scattered throughout the code is to use a single
choke point for all ResourceLoadScheduler access.
No new tests
(No change of behavior for the default config, not testable at this time in the repro config)
Add a single choke point for accessing the correct ResourceLoadScheduler:
- loader/ResourceLoadScheduler.cpp:
(WebCore::defaultResourceLoadScheduler): New private function that keeps the singleton default ResourceLoadScheduler.
(WebCore::resourceLoadScheduler): Refactor this function to either ask the LoaderStrategy or call through to
Revert back to using that single choke point everywhere:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::suspendPostAttachCallbacks):
(WebCore::ContainerNode::resumePostAttachCallbacks):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::willSendRequest):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::performPostLoadActions):
- 2:25 PM Changeset in webkit [132694] by
-
- 2 edits1 delete in trunk/LayoutTests
Remove Chromium specific expectations for video-media-source-add-and-remove-buffers.html
https://bugs.webkit.org/show_bug.cgi?id=100160
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-26
Reviewed by Adam Barth.
The common expectations just reflected a bug in Chromium. The bug has been fixed and the common expectations
have been updated to reflect the correct behavior.
- http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt:
- platform/chromium/http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt: Removed.
- 2:20 PM Changeset in webkit [132693] by
-
- 2 edits3 moves3 adds in trunk/PerformanceTests
Turn PageLoad tests into simple performancetests, commit #6
https://bugs.webkit.org/show_bug.cgi?id=99899
Reviewed by Ryosuke Niwa.
We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.
This is the #6 commit of the whole patch.
- PageLoad/svg/files/gearflowers.svg: Removed.
- PageLoad/svg/files/hereGear4.svg: Removed.
- PageLoad/svg/files/worldcup.svg: Removed.
- SVG/GearFlowers.html: Added.
- SVG/HereGear.html: Added.
- SVG/Worldcup.html: Added.
- SVG/resources/GearFlowers.svg: Copied from PerformanceTests/PageLoad/svg/files/gearflowers.svg.
- SVG/resources/HereGear.svg: Copied from PerformanceTests/PageLoad/svg/files/hereGear4.svg.
- SVG/resources/Worldcup.svg: Copied from PerformanceTests/PageLoad/svg/files/worldcup.svg.
- Skipped: Rename the files on the skipped list also.
- 2:16 PM Changeset in webkit [132692] by
-
- 4 edits in trunk/Source/WebCore
Try to fix the windows build
https://bugs.webkit.org/show_bug.cgi?id=100556
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-26
Reviewed by Eric Seidel.
Touch files by adding whitespace to try and make the windows
build bot regenerate files.
No new tests, just kick the bot.
- dom/DOMAllInOne.cpp:
- html/HTMLElementsAllInOne.cpp:
- html/shadow/TextControlInnerElements.cpp:
- 1:59 PM Changeset in webkit [132691] by
-
- 1 edit3 copies in branches/chromium/1271
Merge 132371 - Crash when trying to write exception message to null console
https://bugs.webkit.org/show_bug.cgi?id=99658
Patch by Toni Barzic <tbarzic@chromium.org> on 2012-10-24
Reviewed by Adam Barth.
Source/WebCore:
DOMWindow::console may return NULL, so we should do a NULL check before adding message to it.
This may happen e.g. if a worker throws an exception just as the document is being replaced in the view.
The exception task could be processes after current window in the frame changes, and console in the document window is nulled.
Test: fast/workers/worker-exception-during-navigation.html
- dom/Document.cpp:
(WebCore::Document::addMessage):
LayoutTests:
The test creates bunch of workers that throw an exception as soon as they are loaded and then tries to change the current document.
The test passes if there is no crash.
Unfortuantely, the test is inherently flaky and may produce some false positive results (but should never fail if there is no bug).
- fast/workers/resources/worker-exception.js: Added.
- fast/workers/worker-exception-during-navigation-expected.txt: Added.
- fast/workers/worker-exception-during-navigation.html: Added.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11320014
- 1:41 PM Changeset in webkit [132690] by
-
- 2 edits in trunk/Tools
Get rid of (<X%) failing output for old-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=100447
Reviewed by Jessie Berlin.
Not a particularly useful piece of information. It's pretty much never above 1%.
new-run-webkit-tests does not output this either.
- Scripts/old-run-webkit-tests:
(printResults):
- 1:36 PM Changeset in webkit [132689] by
-
- 2 edits in trunk/Source/WTF
Add an operator& to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=100549
Reviewed by Dan Bernstein.
This is useful for APIs that return references using out parameters.
- wtf/RetainPtr.h:
(WTF::RetainPtr::operator&):
- 1:12 PM Changeset in webkit [132688] by
-
- 4 edits in trunk
[BlackBerry] Platform Abstraction for WebKit Resource/Image Loading
https://bugs.webkit.org/show_bug.cgi?id=100518
PR 231732
Reviewed by Yong Li.
.:
Remove RESOURCE_PATH from webkit, this is now abstracted in our platform layer.
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebCore:
Use the new resource/image loading abstraction ResourceStore.
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::Image::loadPlatformResource):
- 1:02 PM Changeset in webkit [132687] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry][FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
https://bugs.webkit.org/show_bug.cgi?id=100421
Reviewed by Yong Li.
Patch by Jacky Jiang <zhajiang@rim.com>.
PR: 231173
When leaving fullscreen, we need to suspend screen and backing store
updates before setting scroll position and changing transformation and
resume after they are done. In which way, we can get rid of a noticeable
glitch during the transition.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- 12:58 PM Changeset in webkit [132686] by
-
- 3 edits1 copy in trunk/Source/Platform
[chromium] Add additional memory management fields to WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=99703
Patch by Christopher Cameron <ccameron@chromium.org> on 2012-10-26
Reviewed by James Robinson.
Add new fields to WebGraphicsMemoryAllocation to allow for specifying
limits for when visible and not, and to allow for specifying priority
cutoffs (e.g, to allow specifying that backgrounded tabs should
retain only their visible textures).
Add sendManagedMemoryStatsCHROMIUM to WebGraphicsContext3D, and
add WebGraphicsManagedMemoryStats structure, to allow the GPU memory
manager to make more informed choices.
- chromium/public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::sendManagedMemoryStatsCHROMIUM):
- chromium/public/WebGraphicsMemoryAllocation.h:
(WebGraphicsMemoryAllocation):
(WebKit::WebGraphicsMemoryAllocation::WebGraphicsMemoryAllocation):
(WebKit):
(WebGraphicsManagedMemoryStats):
(WebKit::WebGraphicsManagedMemoryStats::WebGraphicsManagedMemoryStats):
- 12:57 PM Changeset in webkit [132685] by
-
- 3 edits3 adds in trunk
[CSS Exclusions] Block children have incorrect offset when shape-inside element lays out below other elements
https://bugs.webkit.org/show_bug.cgi?id=98189
Patch by Bear Travis <betravis@adobe.com> on 2012-10-26
Reviewed by Dirk Schulze.
Source/WebCore:
The initial code assumed that each block created a new layout state, such that
LayoutState::layoutOffset would be specific to each block child of a shape-inside.
Typically, however, block children of a shape-inside do not create a new layout state,
and therefore we use the current element's offset instead.
Test: fast/exclusions/shape-inside/shape-inside-subsequent-blocks.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Modified to use only logicalTop
rather than LayoutState::layoutOffset::width/height and logicalTop.
LayoutTests:
Test that block content in subsequent shape-insides lays out correctly. Introducing a script
that can eventually be used to simplify the rectangle cases.
- fast/exclusions/resources/simple-rectangle.js: Added.
(createRectangleTest): Generate a shape-inside rectangle test using the given parameters.
(createRectangleTestResult): Generate a shape-inside rectangle expected result using
the given parameters.
- fast/exclusions/shape-inside/shape-inside-subsequent-blocks-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-subsequent-blocks.html: Added.
- 12:28 PM Changeset in webkit [132684] by
-
- 9 edits in trunk/Source/WebCore
Remove setRenderStyle in favor of callbacks on HTMLOptionElement and HTMLOptGroupElement
https://bugs.webkit.org/show_bug.cgi?id=100397
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-26
Reviewed by Ojan Vafai.
Use Node custom callbacks to support the non-renderer style caching for option
and optgroup eliminating the need for setRenderStyle.
setRenderStyle only existed to support HTMLOptionElement and HTMLOptGroupElement
so they could store their RenderStyle even though they have no renderer. This
means all style setting went through the virtual call to setRenderStyle, and it
also hid the if statement protecting against null renderers meaning we end up
checking if the renderer is null repeatedly in recalcStyle. This refactor cleans
up recalcStyle to be more clear about what's going on.
No new tests needed, this is just a refactor.
- dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
(WebCore::Element::recalcStyle):
- dom/Node.cpp:
(WebCore::Node::createRenderer):
(WebCore::Node::setRenderStyle):
Removed this method because it was only here to support HTMLOptionElement
and HTMLOptGroupElement. Instead we can use node custom callbacks.
- dom/Node.h:
(WebCore::Node::nonRendererStyle): Renamed from nonRendererRenderStyle to match other style methods.
- dom/NodeRenderStyle.h:
(WebCore::Node::renderStyle):
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
(WebCore::HTMLOptGroupElement::attach): Reorder the logic to avoid calling styleForRenderer twice.
(WebCore::HTMLOptGroupElement::updateNonRenderStyle): Updates the cached non-renderer style.
(WebCore::HTMLOptGroupElement::nonRendererStyle):
(WebCore::HTMLOptGroupElement::customStyleForRenderer):
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement):
(WebCore::HTMLOptionElement::attach): Reorder the logic to avoid calling styleForRenderer twice.
(WebCore::HTMLOptionElement::updateNonRenderStyle): Updates the cached non-renderer style.
(WebCore::HTMLOptionElement::nonRendererStyle):
(WebCore::HTMLOptionElement::customStyleForRenderer):
(WebCore::HTMLOptionElement::didRecalcStyle): Requests the repaint of the select like setRenderStyle used to.
- html/HTMLOptionElement.h:
- 12:15 PM Changeset in webkit [132683] by
-
- 2 edits in trunk/Source/Platform
[chromium] Add implicit conversions between WebFloatPoint and gfx::PointF
https://bugs.webkit.org/show_bug.cgi?id=100435
Reviewed by James Robinson.
This is similar to other Web geometry types, but the WebFloatPoint is
missing it.
- chromium/public/WebFloatPoint.h:
(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator gfx::PointF):
- 12:06 PM Changeset in webkit [132682] by
-
- 3 edits2 adds in trunk
-webkit-clip-path property should just reference clipPath
https://bugs.webkit.org/show_bug.cgi?id=100531
Reviewed by Eric Seidel.
Source/WebCore:
The -webkit-clip-path property should just reference clipPath. Added a check for that.
Test: css3/masking/clip-path-reference-of-fake-clipPath.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
LayoutTests:
Check that anther SVG resource like mask can not be referenced as clipPath.
- css3/masking/clip-path-reference-of-fake-clipPath-expected.txt: Added.
- css3/masking/clip-path-reference-of-fake-clipPath.html: Added.
- 11:51 AM Changeset in webkit [132681] by
-
- 4 edits in trunk/Source/WebCore
Remove the circular reference between TextTrack and TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=100300
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-26
Reviewed by Eric Carlson.
Changed TextTrackCue.m_track to a normal pointer to break the circular
reference that was keeping both objects from ever getting deleted.
No new tests. This simply fixes a memory leak.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::~TextTrack):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::~TextTrackCue):
(WebCore::TextTrackCue::track):
(WebCore::TextTrackCue::setTrack):
- html/track/TextTrackCue.h:
(TextTrackCue):
- 11:47 AM Changeset in webkit [132680] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Breakpoints are not managed correctly when editing uiSourceCode that was bound to ScriptFile after JavaScriptSourceFrame creation.
https://bugs.webkit.org/show_bug.cgi?id=100535
Reviewed by Pavel Feldman.
Added SourceMappingChanged event to UISourceCode and made
JavaScriptSourceFrame update ScriptFile events listeners on it.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onSourceMappingChanged):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.setSourceMapping):
- 11:44 AM Changeset in webkit [132679] by
-
- 3 edits in trunk/Tools
Build bot gives incorrect link to EWS build failure
https://bugs.webkit.org/show_bug.cgi?id=100436
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(MockCommitQueue.init):
(MockCommitQueue.command_failed): Return incremental failure_status_id
(CommitQueueTaskTest.test_red_tree_patch_rejection): Check failure_status_id
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._test_patch): Use the failure_status_id of test with patch when test without patch fails and test with patch has unexpected failures.
- 11:41 AM Changeset in webkit [132678] by
-
- 10 edits in trunk
webkitpy: Pass the `Listen' Apache directive from webkitpy, not the httpd.conf files.
https://bugs.webkit.org/show_bug.cgi?id=98602
Reviewed by Dirk Pranke.
Tools:
Unify all the different `Listen' directives present in the several
httpd.conf files we have in LayoutTests/http/conf. For one, we
were already passing `Listen 127.0.0.1:8000' via webkitpy before,
and opening the other ports from the conf files.
The configuration files differed mostly in the way they handled
IPV6 ports. Some of them did not listen to IPV6 ports because the
systems which used them sometimes did not have IPV6 support. The
`http_server_supports_ipv6' method has been added to Port to
address that. cygwin, on its turn, still seems to use Apache 1.3,
which does not support IPV6 at all; the newly-added method has a
special case for that. Plus, perform a socket.getaddrinfo() call
the same way Apache itself does so we are sure we only enable IPV6
when setting that up in the httpd server is not going to fail.
- Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.is_cygwin):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.baseline_version_dir):
(Port.to.start_websocket_server):
(Port.to):
(Port.to.http_server_supports_ipv6):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_http_server_supports_ipv6):
(PortTest.test_build_path):
- Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd):
(LayoutTestApacheHttpd.init):
LayoutTests:
- http/conf/apache2-debian-httpd.conf: Remove the `Listen'
directive and related comments, it is passed to httpd by webkitpy
now.
- http/conf/apache2-httpd.conf: Ditto.
- http/conf/cygwin-httpd.conf: Ditto.
- http/conf/fedora-httpd.conf: Ditto.
- 11:18 AM Changeset in webkit [132677] by
-
- 2 edits in trunk/Tools
Unreviewed. Update my IRC nickname to a registered one.
- Scripts/webkitpy/common/config/committers.py:
- 10:52 AM Changeset in webkit [132676] by
-
- 1 edit2 copies in branches/chromium/1271
Merge 131315 - Calling WebCore::SharedBuffer::append(data, 0) on a shared buffer when
its current position is at a segment boundary (4096) ends up adding an
unitialized segment (with uninitialized memory) to the SharedBuffer.
https://bugs.webkit.org/show_bug.cgi?id=99000
Reviewed by Adam Barth.
Source/WebCore:
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):
LayoutTests:
- mhtml/shared_buffer_bug-expected.txt: Added.
- mhtml/shared_buffer_bug.mht: Added.
TBR=jcivelli@chromium.org
Review URL: https://codereview.chromium.org/11316005
- 10:49 AM WebKit Team edited by
- (diff)
- 10:49 AM Changeset in webkit [132675] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r132644.
http://trac.webkit.org/changeset/132644
https://bugs.webkit.org/show_bug.cgi?id=100497
Causes webkit_unit_tests
MemoryInstrumentationTest.ImageObserver to fail.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
- platform/network/ResourceRequestBase.h:
(ResourceRequestBase):
- platform/network/chromium/ResourceRequest.cpp:
- platform/network/chromium/ResourceRequest.h:
- 10:30 AM Changeset in webkit [132674] by
-
- 8 edits in tags/Safari-537.16/Source/JavaScriptCore
Merge fix for <rdar://problem/12551946>
- 10:30 AM Changeset in webkit [132673] by
-
- 12 edits8 copies2 moves2 adds2 deletes in trunk/LayoutTests
compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454
Reviewed by Dan Bernstein.
In r131009 I fixed layerTreeAsText() to not be flakey with tiled layers, by ensuring that
we flush layer state before dumping the layer tree. That makes these tests non-flakey. I was
also able to remove all the setTimeouts() from these tests.
The 'usingTiledLayer' property is only dumped on Mac, so made cross-platform results without
this flag, and added Mac-specific results with it.
Unskipped some tests on non-Mac platforms that should now pass.
- compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- compositing/tiling/huge-layer-add-remove-child-expected.txt:
- compositing/tiling/huge-layer-add-remove-child.html: Added.
- compositing/tiling/huge-layer-add-remove-child.html-disabled: Removed.
- compositing/tiling/huge-layer-expected.txt:
- compositing/tiling/huge-layer-img-expected.txt:
- compositing/tiling/huge-layer-img.html: Renamed from LayoutTests/compositing/tiling/huge-layer-img.html-disabled.
- compositing/tiling/huge-layer-resize-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-resize.html: Added.
- compositing/tiling/huge-layer-with-layer-children-resize.html-disabled: Removed.
- compositing/tiling/huge-layer-with-layer-children.html: Renamed from LayoutTests/compositing/tiling/huge-layer-with-layer-children.html-disabled.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Copied from LayoutTests/compositing/tiling/backface-preserve-3d-tiled-expected.txt.
- platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Copied from LayoutTests/compositing/tiling/crash-reparent-tiled-layer-expected.txt.
- platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-add-remove-child-expected.txt.
- platform/mac/compositing/tiling/huge-layer-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-expected.txt.
- platform/mac/compositing/tiling/huge-layer-img-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-img-expected.txt.
- platform/mac/compositing/tiling/huge-layer-resize-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-resize-expected.txt.
- platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-expected.txt.
- platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt.
- platform/qt-5.0-wk2/TestExpectations:
- 10:30 AM Changeset in webkit [132672] by
-
- 2 edits in trunk/LayoutTests
[chromium] Enable fast/images/exif-orientation.html
https://bugs.webkit.org/show_bug.cgi?id=100534
Unreviewed, TestExpecations change.
The baselines for this test landed yesterday.
- platform/chromium/TestExpectations:
- 10:19 AM Changeset in webkit [132671] by
-
- 2 edits in trunk/Source/WebCore
[Qt] MiniBrowser segfaults on exit after using WebGL.
https://bugs.webkit.org/show_bug.cgi?id=100523
The display connection must not be closed before
destroying the offscreen window.
Therefore opening the connection is moved to the
getXWindow() function. And closing the connection
is being moved to the destructor of the offscreen window.
Reviewed by Kenneth Rohde Christiansen.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::getXWindow):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::display):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
- 9:31 AM Changeset in webkit [132670] by
-
- 2 edits4 moves3 adds in trunk/PerformanceTests
Turn PageLoad tests into simple performancetests, commit #5
https://bugs.webkit.org/show_bug.cgi?id=99899
Reviewed by Ryosuke Niwa.
We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.
This is the #5 commit of the whole patch.
- PageLoad/svg/files/Harvey_Rayner.svg: Removed.
- PageLoad/svg/files/Sierpinski_carpet_6.svg: Removed.
- PageLoad/svg/files/mtsthelens.svg: Removed.
- PageLoad/svg/files/mtsthelens0.jpg: Removed.
- SVG/HarveyRayner.html: Added.
- SVG/MtSaintHelens.html: Added.
- SVG/SierpinskiCarpet.html: Added.
- SVG/resources/HarveyRayner.svg: Copied from PerformanceTests/PageLoad/svg/files/Harvey_Rayner.svg.
- SVG/resources/MtSaintHelens.svg: Copied from PerformanceTests/PageLoad/svg/files/mtsthelens.svg.
- SVG/resources/SierpinskiCarpet.svg: Copied from PerformanceTests/PageLoad/svg/files/Sierpinski_carpet_6.svg.
- SVG/resources/mtsthelens0.jpg: Copied from PerformanceTests/PageLoad/svg/files/mtsthelens0.jpg.
- Skipped: Rename the files on the skipped list also.
- 9:25 AM Changeset in webkit [132669] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
Generic ThreadUnsafe Singleton
https://bugs.webkit.org/show_bug.cgi?id=100529
Patch by Parth Patel <parpatel@rim.com> on 2012-10-26
Reviewed by Yong Li.
No new tests added as there was no behavioural change.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore):
- platform/network/blackberry/NetworkManager.h:
(NetworkManager):
- 9:12 AM Changeset in webkit [132668] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fix log-type icon alignment.
https://bugs.webkit.org/show_bug.cgi?id=100520
Reviewed by Yury Semikhatsky.
The icons are just a pixel or two off, and it's driving me nuts.
- inspector/front-end/inspector.css:
(.console-message::before, .console-user-command::before, #console-prompt::before, .console-group-title::before):
(.console-warning-level::before):
- 9:09 AM Changeset in webkit [132667] by
-
- 11 edits in trunk/Source/WebCore
Replaceable attributes should also have readonly
https://bugs.webkit.org/show_bug.cgi?id=91768
Reviewed by Adam Barth.
This updates the code generators for JSC and V8 to handle this case correctly.
- Modules/intents/DOMWindowIntents.idl:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
- 8:58 AM Changeset in webkit [132666] by
-
- 2 edits in trunk/Source/WebCore
Clear m_orientation in FrameData::clear() for skia
https://bugs.webkit.org/show_bug.cgi?id=100456
Reviewed by Stephen White.
clear() is only called by the FrameData destructor and for multi-image
images in BitmapImage::destroyDecodedData(). Multi-frame images don't
have exif data, so this patch should have no effect in practice. It
makes the skia code match the CG code in BitmapImageCG.cpp though.
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::FrameData::clear):
- 8:57 AM Changeset in webkit [132665] by
-
- 3 edits2 adds in trunk
Crash on loading SVG filter resource on HTML element
https://bugs.webkit.org/show_bug.cgi?id=100491
Reviewed by Dirk Schulze.
Source/WebCore:
Skip non-filter elements referenced via -webkit-filter.
Test: svg/filters/filter-reference-crash.html
- rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayerFilterInfo::updateReferenceFilterClients):
LayoutTests:
- svg/filters/filter-reference-crash-expected.txt: Added.
- svg/filters/filter-reference-crash.html: Added.
- 8:49 AM Changeset in webkit [132664] by
-
- 3 edits in trunk/Source/WebCore
Lots of time spent under DNSResolveQueue::platformProxyIsEnabledInSystemPreferences
https://bugs.webkit.org/show_bug.cgi?id=100514
Reviewed by Anders Carlsson.
DNSResolveQueue::platformProxyIsEnabledInSystemPreferences gets called for every link in
the document. The function is relatively slow.
This patch caches the result of the last check for 5 seconds. Based on code comments
prefetching is disabled with proxies due to regressing performance with some configurations.
Proxy status changes rarely and a slight reaction delay shoudn't cause practical problems.
- platform/network/DNSResolveQueue.cpp:
(WebCore::DNSResolveQueue::DNSResolveQueue):
Add constructor. Also fixes a bug, m_requestsInFlight was not initialized.
(WebCore):
(WebCore::DNSResolveQueue::isUsingProxy):
(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::fired):
- platform/network/DNSResolveQueue.h:
(DNSResolveQueue):
- 8:42 AM Changeset in webkit [132663] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r132662.
http://trac.webkit.org/changeset/132662
https://bugs.webkit.org/show_bug.cgi?id=100528
It is not necessary any more. (Requested by loislo on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- platform/qt/MemoryUsageSupportQt.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
(WebCore):
- 8:36 AM Changeset in webkit [132662] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for Qt builders.
- platform/qt/MemoryUsageSupportQt.cpp:
- 8:33 AM Changeset in webkit [132661] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r132658.
http://trac.webkit.org/changeset/132658
https://bugs.webkit.org/show_bug.cgi?id=100515
It broke the Qt build
- inspector/InspectorMemoryAgent.cpp:
(WebCore::addPlatformComponentsInfo):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
- platform/MemoryUsageSupport.h:
(ComponentInfo):
(WebCore::MemoryUsageSupport::ComponentInfo::ComponentInfo):
(MemoryUsageSupport):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
- platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::memoryUsageByComponents):
- 8:21 AM Changeset in webkit [132660] by
-
- 37 deletes in trunk/LayoutTests/platform/qt-5.0-wk2
Unreviewed. Remove empty buggy directories.
- 8:13 AM Changeset in webkit [132659] by
-
- 27 edits in trunk/Source/WebCore
Web Inspector: Some context menu items are duplicated on Resources and Sources panels.
https://bugs.webkit.org/show_bug.cgi?id=100522
Reviewed by Pavel Feldman.
Method appendApplicableItems now receives event as a parameter.
HandlerRegistry now makes sure that it is not called more than once for certain context menu event.
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.Placard.prototype._placardContextMenu):
- inspector/front-end/ConsoleView.js:
- inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenu):
(WebInspector.ContextMenu.prototype.show):
(WebInspector.ContextMenu.prototype.appendApplicableItems):
(WebInspector.ContextMenu.Provider.prototype.appendApplicableItems):
- inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._contextMenu):
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._contextMenu):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):
- inspector/front-end/ElementsPanelDescriptor.js:
(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
- inspector/front-end/HandlerRegistry.js:
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):
- inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._contextMenu):
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.handleContextMenu):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._contextMenu):
- inspector/front-end/NetworkPanelDescriptor.js:
(WebInspector.NetworkPanelDescriptor.prototype.appendApplicableItems):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuFired):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IndexedDBTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FileSystemListTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IDBDatabaseTreeElement.prototype._handleContextMenuEvent):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
- inspector/front-end/ScriptsPanelDescriptor.js:
(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._contextMenu):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._emptyElementContextMenu):
(WebInspector.WatchExpressionTreeElement.prototype._contextMenu):
- 8:07 AM Changeset in webkit [132658] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: instrument chromium GlyphCache. It keeps ~2mb data on gmail.
https://bugs.webkit.org/show_bug.cgi?id=100515
Reviewed by Yury Semikhatsky.
I replaced old version with an abstract number with new one which precisely reports allocated SkGlyphCache objects and their sizes.
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::reportMemoryUsage):
- platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
- platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(reportMemoryUsage):
(WebCore::reportGlyphCache):
(WebCore):
(WebCore::MemoryUsageSupport::reportMemoryUsage):
- 7:58 AM Changeset in webkit [132657] by
-
- 6 edits2 deletes in trunk/Source/WebKit2
[EFL][WK2] Get rid of C'ism in text checker API
https://bugs.webkit.org/show_bug.cgi?id=100513
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Make Ewk_Text_Checker a C++ class and move the
WebKitTextChecker code to this new class. This
gets rid of the C'ism in the text checker code
and make it consistent with other Ewk classes.
- PlatformEfl.cmake:
- UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::Ewk_Context):
- UIProcess/API/efl/ewk_settings.cpp:
(spellCheckingLanguagesSetUpdate):
(ewk_settings_continuous_spell_checking_enabled_set):
(ewk_settings_spell_checking_available_languages_get):
(ewk_settings_spell_checking_languages_get):
- UIProcess/API/efl/ewk_text_checker.cpp:
(ClientCallbacks):
(textCheckerEnchant):
(clientCallbacks):
(isContinuousSpellCheckingEnabled):
(setContinuousSpellCheckingEnabled):
(uniqueSpellDocumentTag):
(closeSpellDocumentWithTag):
(checkSpellingOfString):
(guessesForWord):
(learnWord):
(ignoreWord):
(Ewk_Text_Checker):
(Ewk_Text_Checker::availableSpellCheckingLanguages):
(Ewk_Text_Checker::updateSpellCheckingLanguages):
(Ewk_Text_Checker::loadedSpellCheckingLanguages):
(Ewk_Text_Checker::initialize):
- UIProcess/API/efl/ewk_text_checker_private.h:
(Ewk_Text_Checker):
- UIProcess/efl/WebKitTextChecker.cpp: Removed.
- UIProcess/efl/WebKitTextChecker.h: Removed.
- 7:58 AM Changeset in webkit [132656] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Build fix for r132650.
https://bugs.webkit.org/show_bug.cgi?id=100482
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::timeFormat):
- 7:49 AM Changeset in webkit [132655] by
-
- 2 edits in trunk/Source/WebCore
[v8] Memory instrumentation: don't count memory of WrapperTypeInfo
https://bugs.webkit.org/show_bug.cgi?id=100517
Reviewed by Alexander Pavlov.
- bindings/v8/V8PerIsolateData.cpp: when estimating bindings memory size skip
pointers to WrapperTypeInfo objects as they are static fields and belong to
the data segment.
(WTF):
- 7:43 AM Changeset in webkit [132654] by
-
- 6 edits in trunk/LayoutTests
[WK2] should enable two postredirect tests
https://bugs.webkit.org/show_bug.cgi?id=100508
Unreviewed gardening.
The EFL results for these tests seem to have been wrong from the beginning.
Update expected results, enable tests for WK2 (based on comment in
TestExpectations these were skipped because efl failed).
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-26
- platform/efl/http/tests/navigation/postredirect-basic-expected.png:
- platform/efl/http/tests/navigation/postredirect-basic-expected.txt:
- platform/efl/http/tests/navigation/postredirect-goback1-expected.png:
- platform/efl/http/tests/navigation/postredirect-goback1-expected.txt:
- platform/wk2/TestExpectations:
- 7:30 AM Changeset in webkit [132653] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] ASSERT currentThreadIsHoldingLock() failed in MarkedAllocator::allocateSlowCase()
https://bugs.webkit.org/show_bug.cgi?id=100504
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-10-26
Reviewed by Yong Li.
PR #232038 The similar PR # 200724.
Reviewed internally by Petter Wang.
This issue is same as bug 95492, and this patch is same as its patch.
Hold the JSLock for the current thread before we call toRef to avoid
the ASSERT failure.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
- 7:26 AM Changeset in webkit [132652] by
-
- 1 copy in tags/Safari-537.16
New Tag.
- 7:25 AM Changeset in webkit [132651] by
-
- 1 delete in tags/Safari-537.16
Remove Tag.
- 7:22 AM Changeset in webkit [132650] by
-
- 10 edits in trunk/Source/WebCore
Refactor Localizer-related classes.
https://bugs.webkit.org/show_bug.cgi?id=100482
Reviewed by Kentaro Hara.
- Localizer has unused code Localizer should have function implementations only if they are used in multiple subclasses.
- Some Localizer subclasses hide Localizer data members
- Should use String::isNull to check initialization-or-not
No new tests. This should not change any behavior.
- platform/text/Localizer.h:
(Localizer):
- timeFormat, shortTimeFormat, and timeAMPMLabels should be pure virtual.
- Remove m_localizedDateFormatText, m_localizedShortTimeFormatText, and m_timeAMPMLabels
- platform/text/Localizer.cpp:
Remove implementations of timeFormat, shortTimeFormat, and timeAMPMLabels.
- platform/text/LocaleICU.h:
(LocaleICU): Introduce m_timeFormatWithSeconds and m_timeFormatWithoutSeconds.
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeDateTimeFormat):
Use new data members instead of Localizer data members.
(WebCore::LocaleICU::dateFormat): Use isNull.
- platform/text/LocaleNone.cpp:
(LocaleNone): Add timeFormat, shortTimeFormat, timeAMPMLabels
implementations, and m_timeAMPMLabels.
(WebCore::LocaleNone::timeFormat): Returns the HTML time format.
(WebCore::LocaleNone::shortTimeFormat): Returns the HTML time format.
(WebCore::LocaleNone::timeAMPMLabels): Returns "AM" and "PM".
- platform/text/LocaleWin.h:
(LocaleWin): Add m_timeFormatWithSeconds.
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::dateFormat): Use isNull.
(WebCore::LocaleWin::timeFormat): Use m_timeFormatWithSeconds.
- platform/text/mac/LocaleMac.h:
(LocaleMac): Rename m_localized*TimeFormatText to m_timeFormatWith*Seconds.
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::timeFormat): Follow the renaming.
(WebCore::LocaleMac::shortTimeFormat): Ditto.
- 7:19 AM Changeset in webkit [132649] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip a few tests which produce wrong pixel expectations.
- platform/efl/TestExpectations:
- 7:07 AM Changeset in webkit [132648] by
-
- 4 edits in trunk/Source/WebCore
Crash in PagePopupController by events after WebPagePopupImpl::closePopup
https://bugs.webkit.org/show_bug.cgi?id=100454
Reviewed by Hajime Morita.
No new tests. The bug is timing-dependent.
- page/DOMWindowPagePopup.cpp:
(WebCore::DOMWindowPagePopup::~DOMWindowPagePopup):
Calls clearPagePopupClient for the associalated PagePopupController object.
- page/PagePopupController.cpp:
(WebCore::PagePopupController::setValueAndClosePopup):
Do nothing if m_popupClient is 0.
(WebCore::PagePopupController::localizeNumberString): Ditto.
(WebCore::PagePopupController::clearPagePopupClient): Added.
- page/PagePopupController.h:
(PagePopupController): Declare clearPagePopupClient.
- 6:43 AM Changeset in webkit [132647] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Clean up construction/destruction code in Ewk_view
https://bugs.webkit.org/show_bug.cgi?id=100232
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Simplified a lot of initialization and destruction code of Ewk_view and EwkViewImpl
put all the impl stuff to its constructor and destructor, also made EwkViewImpl member
variables private.
- UIProcess/API/efl/EwkViewImpl.cpp:
(pageViewMap):
(EwkViewImpl::addToPageViewMap):
(EwkViewImpl::removeFromPageViewMap):
(EwkViewImpl::viewFromPageViewMap):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::~EwkViewImpl):
(EwkViewImpl::wkPage):
(EwkViewImpl::title):
(EwkViewImpl::setThemePath):
(EwkViewImpl::customTextEncodingName):
(EwkViewImpl::setCustomTextEncodingName):
(EwkViewImpl::informIconChange):
(EwkViewImpl::informWebProcessCrashed):
(EwkViewImpl::updateTextInputState):
(EwkViewImpl::informURLChange):
(EwkViewImpl::onFaviconChanged):
- UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
(EwkViewImpl::view):
(EwkViewImpl::page):
(EwkViewImpl::ewkContext):
(EwkViewImpl::backForwardList):
- UIProcess/API/efl/ewk_settings.cpp:
(Ewk_Settings::preferences):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(createEwkViewSmartClass):
(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):
(ewk_view_add_with_context):
(ewk_view_url_set):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_back_forward_list_get):
(ewk_view_html_string_load):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
(ewk_view_text_matches_count):
(ewk_view_feed_touch_event):
(ewk_view_inspector_show):
(ewk_view_inspector_close):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):
- 6:32 AM Changeset in webkit [132646] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] Add custom expectation for test added in r131557.
- platform/efl/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
- 6:27 AM Changeset in webkit [132645] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Bring device geolocation and orientation emulation from behind the experiment
https://bugs.webkit.org/show_bug.cgi?id=100220
Reviewed by Yury Semikhatsky.
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SettingsScreen.js:
(WebInspector.UserAgentSettingsTab):
- 6:20 AM Changeset in webkit [132644] by
-
- 5 edits in trunk/Source/WebCore
Memory instrumentation: report memory occupied by ResourceRequest instead of its base ResourceRequestBase
https://bugs.webkit.org/show_bug.cgi?id=100497
Reviewed by Alexander Pavlov.
Added memory reporting method to Chromium implementation of ResourceRequest.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsageBase): Renamed reportMemoryUsage
on ResourceRequestBase to reportMemoryUsageBase and made it protected. I'd
rather make ResourceRequestBase::reportMemoryUsage virtual and override it
in the descendant but ResourceRequestBase doesn't have any virtual methods
and shouldn't be used directly (ResourceRequest should be used instead).
- platform/network/ResourceRequestBase.h:
(ResourceRequestBase):
- platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::reportMemoryUsage):
(WebCore):
- platform/network/chromium/ResourceRequest.h:
(ResourceRequest):
- 6:17 AM Changeset in webkit [132643] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Initialize Ewk_Context class members in initialization list
https://bugs.webkit.org/show_bug.cgi?id=100503
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Move Ewk_Context class members initialization from the
constructor body to the initialization list for
efficiency.
- UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::Ewk_Context):
- 6:14 AM Changeset in webkit [132642] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove the on-hover highlighting of console messages
https://bugs.webkit.org/show_bug.cgi?id=100511
Reviewed by Pavel Feldman.
This clashes with the hovered element highlight in console messages.
- inspector/front-end/inspector.css:
(ol.watch-expressions > li.hovered):
- 6:13 AM Changeset in webkit [132641] by
-
- 7 edits4 deletes in trunk
Unreviewed, rolling out r132612.
http://trac.webkit.org/changeset/132612
https://bugs.webkit.org/show_bug.cgi?id=100512
Crashes fast/events/tabindex-focus-blur-all.html in debug mode
(Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
Source/WebCore:
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
(WebCore::RenderTableCol::computePreferredLogicalWidths):
- rendering/RenderTableCol.h:
(RenderTableCol):
LayoutTests:
- fast/table/col-span-change-relayout-expected.txt: Removed.
- fast/table/col-span-change-relayout.html: Removed.
- fast/table/simplified-layout-table-expected.html: Removed.
- fast/table/simplified-layout-table.html: Removed.
- 5:55 AM Changeset in webkit [132640] by
-
- 4 edits in trunk/Source/WebKit2
LayerTreeCoordinator: Make sure that dependent layers are deleted before their directly composited image
https://bugs.webkit.org/show_bug.cgi?id=100495
Reviewed by Kenneth Rohde Christiansen.
Since r128980 layers removals are delayed until we flush the layer tree.
This causes a crash if such a layer had a directly composited image since
the image is now deleted while the layer is still active in the UI process
and tries to access a deleted backing store.
Fix it by delaying the directly composited image removal as well.
Fixes a crash in tst_QQuickWebView::basicRenderingSanity since showWebView is
called first and loads direct-image-compositing.html.
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer): Remove unused variable.
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
- 5:55 AM Changeset in webkit [132639] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fast return upon setting the same dock side.
https://bugs.webkit.org/show_bug.cgi?id=100510
Reviewed by Vsevolod Vlasov.
Added fast return.
- inspector/front-end/DockController.js:
- 5:54 AM Changeset in webkit [132638] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Apple Win gardening.
- platform/win/TestExpectations: Skipping XHR timeout tests.
- 5:48 AM Changeset in webkit [132637] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
German de.po translation needs update
https://bugs.webkit.org/show_bug.cgi?id=91349
Patch by Christian Kirbach <Christian.Kirbach@gmail.com> on 2012-10-26
Rubber-stamped by Gustavo Noronha.
- de.po: updated with proof-read version.
- 5:48 AM Changeset in webkit [132636] by
-
- 8 edits in trunk
[Qt] Fix the LLInt build on Windows
https://bugs.webkit.org/show_bug.cgi?id=97648
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-26
Reviewed by Tor Arne Vestbø.
Source/JavaScriptCore:
The main change for the port on Windows is changing the way offsets are extracted
and the LLIntAssembly.h is generated to accomodate release and debug configurations.
Firstly the LLIntOffsetsExtractor binary is now built as-is (no DESTDIR set) and
placed into debug\LLIntOffsetsExtractor.exe and release\LLIntOffsetsExtractor.exe
on Windows debug_and_release builds. On other patforms it remainds in the regular
out directory.
Secondly the LLIntAssembly.h files must be different for different build types,
so the LLIntAssembly.h generator in DerivedSources.pri operates no on the extractor
binary files as input. Using a simple exists() check we verify the presence of either
a regular, a debug\LLIntOffsetsExtractor and a release\LLIntOffsetsExtractor binary
and process all of them. The resulting assembly files consequently end up in
generated\debug\LLIntAssembly.h and generated\release\LLIntAssembly.h.
In Target.pri we have to also make sure that those directories are in the include
path according to the release or debug configuration.
Lastly a small tweak - swapping WTF.pri and JSC.pri inclusions - in the
LLIntOffsetsExtractor build was needed to make sure that we include
JavaScriptCore/config.h instead of WTF/config.h, required to fix the
build issues originally pasted in bug #97648.
- DerivedSources.pri:
- JavaScriptCore.pro:
- LLIntOffsetsExtractor.pro:
- Target.pri:
Tools:
Added BIN_EXTENSION variable - similar to automake - that expands to .exe as suffix for
executable programs on Windows. Empty otherwise. Also added support for force_build_all
to allow overriding us disabling build_all for TEMPLATE = app.
- qmake/mkspecs/features/default_pre.prf:
- 5:40 AM Changeset in webkit [132635] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Removing bogus '#EOF\n' data in the listed PNG file that's
positioned after the IEND PNG chunk.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- 5:38 AM Changeset in webkit [132634] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed trivial build fix: It's glXGetCurrentContext not glxGetCurrentContext :)
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
- 5:27 AM Changeset in webkit [132633] by
-
- 3 edits2 adds in trunk
Printing should use use high resolution images when available
https://bugs.webkit.org/show_bug.cgi?id=100488
Reviewed by Antti Koivisto.
The images loaded using -webkit-device-pixel-ratio depends on
the display type (deviceScaleFactor) and thus affects which
images are being used for printing. Printing should always
use the higher resolution images (aka 'retina' images).
Source/WebCore:
Test: fast/media/mq-pixel-ratio-print.html
- css/MediaQueryEvaluator.cpp:
(WebCore::device_pixel_ratioMediaFeatureEval):
LayoutTests:
Added a test testing -webkit-device-pixel-ratio media query
in conjuntion with 'print' media type.
- fast/media/mq-pixel-ratio-print-expected.txt: Added.
- fast/media/mq-pixel-ratio-print.html: Added.
- 5:25 AM Changeset in webkit [132632] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: NMI instrument InspectorResourceAgent. it caches resources for the front-end.
https://bugs.webkit.org/show_bug.cgi?id=100496
Reviewed by Yury Semikhatsky.
It is plain instrumentation for InspectorResourceAgent and NetworkResourceData which is used by the agent.
- dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
- dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::reportMemoryUsage):
(WebCore):
- inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
- inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):
- inspector/NetworkResourcesData.h:
(XHRReplayData):
(ResourceData):
(NetworkResourcesData):
- 5:25 AM Changeset in webkit [132631] by
-
- 2 edits in trunk/LayoutTests
[EFL] ... And another pixel rebaseline after r131941 and r131991.
- platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png:
- 5:24 AM Changeset in webkit [132630] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r132493.
http://trac.webkit.org/changeset/132493
https://bugs.webkit.org/show_bug.cgi?id=100509
It didn't fix the tests on the bot as we had hoped. (Requested
by drott on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError):
- 5:19 AM Changeset in webkit [132629] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Temporarily disable use of QXcbNativeInterface in GraphicsSurfaceGLX.
https://bugs.webkit.org/show_bug.cgi?id=100493
Once QXcbNativeInterface::nativeResourceForContext() can provide the
GLXContext for an existing QOpenGLContext, this patch shall be reverted.
Patch by Zeno Albisser <zeno@webkit.org> on 2012-10-26
Reviewed by Simon Hausmann.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
- 5:19 AM Changeset in webkit [132628] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Remove QOpenGL specific code from GraphicsSurfaceGLX.
https://bugs.webkit.org/show_bug.cgi?id=100492
This patch removes most of the QOpenGLContext related code
from GraphicsSurfaceGLX. This allows sharing almost all
GraphicsSurfaceGLX code with EFL, by relying on pure GLX.
Patch by Zeno Albisser <zeno@webkit.org> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):
- 5:18 AM Changeset in webkit [132627] by
-
- 13 edits in trunk
[EFL][WK2] Enable WebGL
https://bugs.webkit.org/show_bug.cgi?id=97652
Patch by Regina Chung <heejin.r.chung@samsung.com> on 2012-10-26
Reviewed by Gyuyoung Kim.
.:
Use Graphics Surface to enable WebGL for WebKit2 EFL.
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
Implemented GraphicsSurface for EFL to enable WebGL for WebKit2.
Depends on GLX since Evas doesn't provide the necessary functionality.
No new tests. Covered by existing tests.
- PlatformEfl.cmake:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::createGraphicsSurfaces):
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::reshape):
- platform/graphics/surfaces/efl: Added.
- platform/graphics/surfaces/efl/GraphicsSurfaceEfl.cpp: Added.
(WebCore):
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.h: Added.
(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::glContext):
(WebCore::resolveGLMethods):
- platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore):
(WebCore::OffScreenRootWindow::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
Source/WebKit2:
Set WebGLEnabled to true when WebGL is enabled.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize):
- 5:16 AM Changeset in webkit [132626] by
-
- 3 edits1 add in trunk/LayoutTests
Not reviewed: chromium baselines for selection-after-remove updated.
- platform/chromium-mac-lion/fast/repaint/selection-after-remove-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/selection-after-remove-expected.png:
- platform/chromium-win/fast/repaint/selection-after-remove-expected.png:
- 5:05 AM Changeset in webkit [132625] by
-
- 1 edit27 deletes in trunk/LayoutTests
Unreviewed, rolling out r132607.
http://trac.webkit.org/changeset/132607
https://bugs.webkit.org/show_bug.cgi?id=100502
"SOS! More wrong paths." (Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-iframe-zIndex-expected.png: Removed.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-remove-ancestor-after-expected.png: Removed.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-stacking-context-expected.png: Removed.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-after-expected.png: Removed.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png/SVGLengthList-appendItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png/SVGLengthList-basics-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png/SVGLengthList-getItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png/SVGLengthList-initialize-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png/SVGLengthList-insertItemBefore-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png/SVGLengthList-removeItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png/SVGLengthList-replaceItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png/SVGLengthList-xml-dom-modifications-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png/SVGLocatable-getCTM-svg-root-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png/SVGNumberList-basics-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png/SVGPathSegList-appendItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png/SVGPathSegList-clear-and-initialize-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png/SVGPathSegList-insertItemBefore-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png/SVGPathSegList-removeItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png/SVGPathSegList-replaceItem-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png/SVGPathSegList-xml-dom-synchronization-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png/SVGPointList-basics-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png/SVGStringList-basics-expected.png: Removed.
- platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png/SVGTransformList-basics-expected.png: Removed.
- platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png/feImage-animated-transform-on-target-rect-expected.png: Removed.
- platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png/image-href-change-expected.png: Removed.
- platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png/image-with-clip-path-expected.png: Removed.
- 4:58 AM Changeset in webkit [132624] by
-
- 1 edit74 deletes in trunk/LayoutTests
Unreviewed, rolling out r132604.
http://trac.webkit.org/changeset/132604
https://bugs.webkit.org/show_bug.cgi?id=100501
"SOS! Wrong paths." (Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Removed.
- platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Removed.
- platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Removed.
- platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Removed.
- platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Removed.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Removed.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Removed.
- platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
- platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Removed.
- platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Removed.
- platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Removed.
- platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Removed.
- platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png/file-input-pressed-state-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png/css3-color-stop-units-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png/css3-color-stops-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png/css3-linear-angle-gradients-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png/css3-linear-right-angle-gradients-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png/css3-radial-gradients-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png/css3-radial-gradients2-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png/css3-radial-gradients3-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png/css3-repeating-linear-gradients-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png/css3-repeating-linear-gradients2-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png/css3-repeating-radial-gradients-expected.png: Removed.
- platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png/gradient-after-transparent-border-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Removed.
- platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Removed.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png/scroll-with-transform-composited-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png/scroll-with-transform-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Removed.
- platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Removed.
- platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Removed.
- platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Removed.
- 4:55 AM Changeset in webkit [132623] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: [Overrides] Do not persist the User Agent "master switch"
https://bugs.webkit.org/show_bug.cgi?id=100484
Reviewed by Yury Semikhatsky.
The User Agent override state is managed in the front-end, just like for other override-able parameters.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::disable):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
- inspector/front-end/SettingsScreen.js:
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.set checkboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement):
- inspector/front-end/UserAgentSupport.js:
(WebInspector.UserAgentSupport):
(WebInspector.UserAgentSupport.prototype.toggleUserAgentOverride):
(WebInspector.UserAgentSupport.prototype._userAgentChanged):
- 4:53 AM Changeset in webkit [132622] by
-
- 11 edits1 add in trunk/LayoutTests
[EFL] More pixel rebaselines after r131941 and r131991.
- platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
- platform/efl/fast/dynamic/containing-block-change-expected.png:
- platform/efl/fast/forms/listbox-clip-expected.png:
- platform/efl/fast/frames/inline-object-inside-frameset-expected.png:
- platform/efl/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
- platform/efl/fast/layers/inline-dirty-z-order-lists-expected.png:
- platform/efl/fast/layers/layer-content-visibility-change-expected.png:
- platform/efl/fast/layers/remove-layer-with-nested-stacking-expected.png:
- platform/efl/fast/reflections/inline-crash-expected.png:
- platform/efl/fast/replaced/width100percent-textarea-expected.png:
- platform/efl/fast/text/font-initial-expected.png:
- 4:42 AM Changeset in webkit [132621] by
-
- 8 edits2 adds in trunk
[Shadow]: removing styles in shadow dom subtree causes crash.
https://bugs.webkit.org/show_bug.cgi?id=100455
Reviewed by Hajime Morita.
Source/WebCore:
To quickly check whether shadow roots or elements have any scoped
styles or not, elements have hasStyleScoped flag. If elements have
any scoped styles, the styles are direct children of the element.
The original code just sees how many chilren are scoped style or not.
However styles in shadow dom subtree are registered with the shadow
root but are not always direct children of shadow roots. So to check
whether shadow roots have any scoped styles, modified to count
number of styles registered with the shadow root.
Test: fast/dom/shadow/remove-styles-in-shadow-crash.html
- dom/Node.cpp:
(WebCore::Node::registerScopedHTMLStyleChild):
(WebCore::Node::unregisterScopedHTMLStyleChild):
Made the above two method virtual. class ShadowRoot overrides these
methods.
(WebCore::Node::numberOfScopedHTMLStyleChildren):
Moved HTMLStyleElement.cpp to Node.cpp, because the above two methods
are moved into Node.cpp.
- dom/Node.h:
(Node):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::registerScopedHTMLStyleChild):
(WebCore::ShadowRoot::unregisterScopedHTMLStyleChild):
Modify to count how many styles are registered with the shadow root.
The "counting" is done when styles are registered and unregistered
with the shadow root, i.e. style element is inserted into document or
removed from document. When unregister some style, there are no more
styles registered with the shadow root. Set style scoped flag false.
- dom/ShadowRoot.h:
(ShadowRoot):
- html/HTMLStyleElement.cpp:
- html/HTMLStyleElement.h:
(WebCore::HTMLStyleElement::isRegisteredAsScoped):
Now isRegisteredAsScoped is used in Node.cpp, so removed inline and
moved .cpp to .h.
LayoutTests:
- fast/dom/shadow/remove-styles-in-shadow-crash-expected.txt: Added.
- fast/dom/shadow/remove-styles-in-shadow-crash.html: Added.
- 4:40 AM Changeset in webkit [132620] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r132589.
http://trac.webkit.org/changeset/132589
https://bugs.webkit.org/show_bug.cgi?id=100498
Breaks font-face layout tests (Requested by pfeldman on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- 4:39 AM Changeset in webkit [132619] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=100481
Unreviewed EFL gardening.
Skip failing test and also unskip tests that are
consistently passing.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-26
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 4:33 AM Changeset in webkit [132618] by
-
- 15 edits2 adds in trunk
[Shadow DOM] Needs @host rule for ShadowDOM styling
https://bugs.webkit.org/show_bug.cgi?id=88606
Reviewed by Hajime Morita.
Source/WebCore:
Implemented @host-@rules according to the shadow dom spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#host-at-rule
The design doc is:
https://docs.google.com/document/d/1P2yorchF8lci2sccr-mVSRf2dtvjKeiuyQWzCB2bEA8/edit
Test: fast/dom/shadow/athost-atrules.html
- css/CSSGrammar.y.in:
Added rules for parsing @host @-rules.
- css/CSSParser.cpp:
(WebCore::CSSParser::detectAtToken):
Added a new token "@host".
(WebCore::CSSParser::createHostRule):
Added a new method to create an @host @-rule, which is invoked from
(WebCore):
- css/CSSParser.h:
Added a declaration of the above new method: createHostRule.
- css/CSSPropertySourceData.h:
Added HOST_RULE to enum Type.
- css/RuleSet.cpp:
(WebCore::RuleData::RuleData):
Modified multiple bool arguments into one argument. Now it
uses combinations of values from enum AddRuleFlags.
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addStyleRule):
Updated according to the RuleData's change.
Modified to Invoke increaseSpecificity if the given rule is @host
@-rule.
(WebCore::RuleSet::addRulesFromSheet):
Invoked addHostRule if the given rule is @host @-rule.
- css/RuleSet.h:
(RuleData):
(WebCore::RuleData::increaseSpecificity):
Added a new method to increase selector's specificity. This method is
used to make @host @-rules' specificity larger than normal author
rules' specificity.
(RuleSet):
- css/StyleResolver.cpp:
(WebCore::makeRuleSet):
(WebCore::StyleResolver::addHostRule):
A wrapper method to invoke StyleScopeResolver::addHostRule. The method
is used to make only StyleResolver know an implementation detail about
class StyleScopeResolver.
(WebCore::StyleResolver::appendAuthorStylesheets):
Updated according to the RuleData's change.
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
A new method to find matched host rules when an element is given.
This method invokes
StyleScopeResolver::styleSharingCandidateMatchesHostRules to find
matched host rules.
(WebCore):
(WebCore::StyleResolver::matchHostRules):
A new method to find matched host rules when an element is given.
This method invokes StyleScopeResolver::matchHostRules to find
matched host rules.
(WebCore::StyleResolver::matchScopedAuthorRules):
Modified to invoke matchHostRules.
(WebCore::StyleResolver::locateSharedStyle):
Disable sibling style cache if the given element is a shadow host and
any @host @-rules are applied to the element.
- css/StyleResolver.h:
(WebCore::StyleResolver::ensureScopeResolver):
If no scopeResolver is created, create and return the instance.
If created, just return the instance.
(StyleResolver):
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleHost::StyleRuleHost):
Implemented class StyleRuleHost. The class is almost the same as
StyleRuleBlock except type.
(WebCore):
- css/StyleRule.h:
(WebCore::StyleRuleBase::isHostRule):
(StyleRuleHost):
(WebCore::StyleRuleHost::create):
(WebCore::StyleRuleHost::copy):
(WebCore):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::ensureAtHostRuleSetFor):
A new method to create a new RuleSet for the given shadow root.
(WebCore):
(WebCore::StyleScopeResolver::atHostRuleSetFor):
A new private inline method to obtain @host @-rules declared in
the given shadow root.
(WebCore::StyleScopeResolver::addHostRule):
Added a new method to register @host @-rules with shadow roots.
(WebCore::StyleScopeResolver::styleSharingCandidateMatchesHostRules):
A new method to find whether any @host @-rules are applied to
the given host element.
(WebCore::StyleScopeResolver::matchHostRules):
A new method to find matched rules for the given host element.
(WebCore::StyleScopeResolver::reportMemoryUsage):
- css/StyleScopeResolver.h:
(WebCore):
(StyleScopeResolver):
- css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
LayoutTests:
- fast/dom/shadow/athost-atrules-expected.txt: Added.
- fast/dom/shadow/athost-atrules.html: Added.
- 4:32 AM Changeset in webkit [132617] by
-
- 9 edits4 adds in trunk/Source/WebKit2
[EFL][WK2] Add Ewk_Color_Picker API
https://bugs.webkit.org/show_bug.cgi?id=100472
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Move the color picker code out of EwkViewImpl and into
a new Ewk_Color_Picker class to avoid cluttering the
view code.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::requestColorPicker):
(EwkViewImpl::dismissColorPicker):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
- UIProcess/API/efl/ewk_color_picker.cpp: Added.
(Ewk_Color_Picker::Ewk_Color_Picker):
(Ewk_Color_Picker::setColor):
(Ewk_Color_Picker::color):
(ewk_color_picker_color_set):
(ewk_color_picker_color_get):
- UIProcess/API/efl/ewk_color_picker.h: Added.
- UIProcess/API/efl/ewk_color_picker_private.h: Added.
(Ewk_Color_Picker):
(Ewk_Color_Picker::create):
- UIProcess/API/efl/ewk_view.cpp:
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_color_picker.cpp: Added.
(onColorPickerDone):
(setColorPickerColor):
(showColorPicker):
(hideColorPicker):
(hideColorPickerByRemovingElement):
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::showColorPicker):
- 4:26 AM Changeset in webkit [132616] by
-
- 2 edits in trunk/LayoutTests
[EFL] Fix test pixel expectation.
- platform/efl/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- 4:21 AM Changeset in webkit [132615] by
-
- 4 edits in trunk/Source/WebKit/efl
[Texmap][EFL] Implementation of AC related functions in ChromeClientEfl and ewkView.
https://bugs.webkit.org/show_bug.cgi?id=82315
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
This patch implements accelerated-compositing-related functions
to enter accelerated-compositing mode and sync layers
in ChromeClientEfl and ewkView.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::attachRootGraphicsLayer):
(WebCore::ChromeClientEfl::setNeedsOneShotDrawingSynchronization):
(WebCore::ChromeClientEfl::scheduleCompositingLayerFlush):
(WebCore::ChromeClientEfl::allowedCompositingTriggers):
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_accelerated_compositing_cb):
Sync and render layers.
(_ewk_view_accelerated_compositing_context_create_if_needed):
Create a new AcceleratedCompositingContext.
(ewk_view_accelerated_compositing_object_create):
Create a new evas_image_object act as render target surface.
(ewk_view_accelerated_compositing_context_get):
Return the GraphicsContext3D for accelerated compositing.
(ewk_view_root_graphics_layer_set):
Set the root layer to AcceleratedCompositingContext.
(ewk_view_mark_for_sync):
Mark the evas_image_object for accelerated compositing as dirty to make it update.
- ewk/ewk_view_private.h:
(WebCore):
- 4:21 AM Changeset in webkit [132614] by
-
- 1 edit80 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel gardening.
Added a bunch of pixel expectations for Qt-WebKit2 - part 5 (svg/dynamic-updates).
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Added.
- 4:17 AM Changeset in webkit [132613] by
-
- 2 edits in trunk/Source/WebCore
[CMAKE] Add TextAutosizer.cpp in WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=100476
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-26
Reviewed by Kentaro Hara.
ENABLE_TEXT_AUTOSIZING option is added in CMAKE,
but the source file for that feature is omitted.
No new tests. Covered by existing tests.
- CMakeLists.txt:
- 4:13 AM Changeset in webkit [132612] by
-
- 7 edits4 adds in trunk
RenderTableCol::computePreferredLogicalWidths and RenderTableCol::layout should never be called
https://bugs.webkit.org/show_bug.cgi?id=99861
Reviewed by Ojan Vafai.
Source/WebCore:
RenderTableCol's computePreferredLogicalWidths and layout's only purpose were to clear the preferred logical
widths dirty / layout flag so that we would properly propagate the information to our containing table. This
led to clunky code where the table layout code had to forcefully call RenderTableCol::computePreferredLogicalWidths
or else we would ignore the next layout hint on the <col> or <colgroup>.
Tests: fast/table/col-span-change-relayout.html
fast/table/simplified-layout-table.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
Simplified the code now that we only need to iterate over the sections.
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
Removed call to computePreferredLogicalWidths.
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
Forward a layout hint to the table so that we properly recompute the cell's logical withs.
(WebCore::RenderTableCol::computePreferredLogicalWidths):
(WebCore::RenderTableCol::layout):
Change our implementations of those 2 methods to be no-ops, while enforcing that they are
never called when it was possible.
(WebCore::RenderTableCol::propagateLayoutCueToTable):
New helper function that forward any layout cue to the containing table, this works around
us not clearing the flags which confuses RenderObject markContainingBlocksForLayout and
invalidateContainerPreferredLogicalWidths.
- rendering/RenderTableCol.h:
Made the function that we are not expected to be called private.
LayoutTests:
Added 2 tests:
- 1 to cover the code in RenderTableCol::updateFromElement.
- 1 to cover simplified layout on a table.
- fast/table/col-span-change-relayout-expected.txt: Added.
- fast/table/col-span-change-relayout.html: Added.
- fast/table/simplified-layout-table-expected.html: Added.
- fast/table/simplified-layout-table.html: Added.
- 4:08 AM Changeset in webkit [132611] by
-
- 1 edit100 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel gardening.
Added a bunch of pixel expectations for Qt-WebKit2 - part 4 (svg/dynamic-updates).
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
- 4:07 AM Changeset in webkit [132610] by
-
- 1 edit2 adds in trunk/Tools
[BlackBerry] Support pixel tests for BlackBerry DRT
https://bugs.webkit.org/show_bug.cgi?id=100210
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-10-26
Reviewed by Rob Buis.
(The following 2 files are missed in previous patch(r132582), adding them
again.)
- DumpRenderTree/blackberry/build: Added.
- DumpRenderTree/blackberry/src.pro: Added.
Adds 2 files for building ImageDiff, by Christopher Wells.
- 4:01 AM FeatureFlags edited by
- (diff)
- 4:00 AM Changeset in webkit [132609] by
-
- 1 edit101 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel gardening.
Added a bunch of pixel expectations for Qt-WebKit2 - part 3 (svg/dynamic-updates).
- platform/qt-5.0-wk2/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.
- 4:00 AM AddingFeatures edited by
- (diff)
- 3:52 AM Changeset in webkit [132608] by
-
- 14 edits in trunk
Unreviewed, rolling out r132601.
http://trac.webkit.org/changeset/132601
https://bugs.webkit.org/show_bug.cgi?id=100494
It broke the Qt build (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
.:
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
- PlatformEfl.cmake:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::createGraphicsSurfaces):
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::reshape):
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):
Source/WebKit:
- PlatformEfl.cmake:
Source/WebKit2:
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize):
- 3:51 AM Changeset in webkit [132607] by
-
- 1 edit53 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel gardening.
Added a bunch of pixel expectations for Qt-WebKit2 - part 1.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-stacking-context-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-after-expected.png: Added.
- platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png/SVGLengthList-appendItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png/SVGLengthList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png/SVGLengthList-getItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png/SVGLengthList-initialize-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png/SVGLengthList-insertItemBefore-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png/SVGLengthList-removeItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png/SVGLengthList-replaceItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png/SVGLengthList-xml-dom-modifications-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png/SVGLocatable-getCTM-svg-root-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png/SVGNumberList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png/SVGPathSegList-appendItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png/SVGPathSegList-clear-and-initialize-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png/SVGPathSegList-insertItemBefore-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png/SVGPathSegList-removeItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png/SVGPathSegList-replaceItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png/SVGPointList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png/SVGStringList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png/SVGTransformList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png/feImage-animated-transform-on-target-rect-expected.png: Added.
- platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png/image-href-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png/image-with-clip-path-expected.png: Added.
- 3:50 AM Changeset in webkit [132606] by
-
- 6 edits in trunk/Source
[Qt] Enable JSC's disassembler on x86, x86_64 Linux
https://bugs.webkit.org/show_bug.cgi?id=100386
Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-10-26
Reviewed by Simon Hausmann.
It works fine on Linux x86, x86_64 just needs to be enabled in the
QtWebKit build system.
Source/JavaScriptCore:
- DerivedSources.pri:
- JavaScriptCore.pri:
- Target.pri:
Source/WTF:
- wtf/Platform.h:
- 3:50 AM Changeset in webkit [132605] by
-
- 2 edits in trunk/Source/WebCore
Memory instrumentation: do not report memory occupied by v8::String
https://bugs.webkit.org/show_bug.cgi?id=100487
Reviewed by Alexander Pavlov.
Pointers to v8::String are skipped when reporting memory usage of V8 bindings'
string cache.
- bindings/v8/V8Binding.cpp:
(WTF):
- 3:45 AM Changeset in webkit [132604] by
-
- 1 edit94 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel gardening.
Added a bunch of pixel expectations for Qt-WebKit2 - part 1.
- platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Added.
- platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Added.
- platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Added.
- platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png/file-input-pressed-state-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png/css3-color-stop-units-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png/css3-color-stops-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png/css3-linear-angle-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png/css3-linear-right-angle-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png/css3-radial-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png/css3-radial-gradients2-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png/css3-radial-gradients3-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png/css3-repeating-linear-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png/css3-repeating-linear-gradients2-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png/css3-repeating-radial-gradients-expected.png: Added.
- platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png/gradient-after-transparent-border-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png/scroll-with-transform-composited-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png/scroll-with-transform-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
- platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Added.
- platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Added.
- 3:40 AM Changeset in webkit [132603] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening, skip a new failing test.
- platform/qt-5.0-wk2/TestExpectations:
- 3:31 AM Changeset in webkit [132602] by
-
- 6 edits36 adds in trunk
[CSSRegions] Add support for auto-height regions with region-breaks
https://bugs.webkit.org/show_bug.cgi?id=99952
Reviewed by David Hyatt.
Source/WebCore:
This patch takes region breaks into account when computing the height for auto logical height regions.
When a region break is encountered before/after an element from within a flow thread and we are in the layout
phase in which we lay out the flow threads in regions unconstrained, we use the region break to
compute the region override logical content height if the region break fits inside an auto logical height region.
A region break inside an auto logical height region determines the region override logical content height, taking
min/max height into account.
Tests: fast/regions/autoheight-allregions-nobreaks.html
fast/regions/autoheight-allregions.html
fast/regions/autoheight-breakafteralways-maxheight.html
fast/regions/autoheight-breakbeforealways.html
fast/regions/autoheight-firstregion-breakalways.html
fast/regions/autoheight-lastregion-overflowauto-breaksignored.html
fast/regions/autoheight-lastregion-overflowauto.html
fast/regions/autoheight-middleregion.html
fast/regions/autoheight-secondregion-breakoutside.html
fast/regions/autoheight-secondregion.html
fast/regions/autoheight-singleregion-breakafteralways-maxheight.html
fast/regions/autoheight-singleregion-breakafteralways.html
fast/regions/autoheight-singleregion-breakaftermargin.html
fast/regions/autoheight-singleregion-breakbeforealways-minheight.html
fast/regions/autoheight-singleregion-breakbeforealways.html
fast/regions/autoheight-singleregion-multiplebreaks.html
fast/regions/autoheight-singleregion-overflowauto-breaksignored.html
fast/regions/autoheight-singleregion-overflowauto.html
- rendering/RenderBlock.cpp: When encounter a region break before/after an element inside a flow thread,
try to use it to determine the override logical content height for auto logical height regions.
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
Simulate a region break at the end of the flow thread content.
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::clearOverrideLogicalContentHeightInRegions):
Helper method used to clear the overrideLogicalContentHeight for auto logical height regions.
(WebCore::RenderFlowThread::addForcedRegionBreak):
Extend the method to process region breaks. The method returns true if at least one auto logical height region
has its override logical content height computed.
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp: Make these methods work with auto logical height regions.
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
LayoutTests:
Add tests for auto logical height regions with content having region breaks.
- fast/regions/autoheight-allregions-expected.html: Added.
- fast/regions/autoheight-allregions-nobreaks-expected.html: Added.
- fast/regions/autoheight-allregions-nobreaks.html: Added.
- fast/regions/autoheight-allregions.html: Added.
- fast/regions/autoheight-breakafteralways-maxheight-expected.html: Added.
- fast/regions/autoheight-breakafteralways-maxheight.html: Added.
- fast/regions/autoheight-breakbeforealways-expected.html: Added.
- fast/regions/autoheight-breakbeforealways.html: Added.
- fast/regions/autoheight-firstregion-breakalways-expected.html: Added.
- fast/regions/autoheight-firstregion-breakalways.html: Added.
- fast/regions/autoheight-lastregion-overflowauto-breaksignored-expected.html: Added.
- fast/regions/autoheight-lastregion-overflowauto-breaksignored.html: Added.
- fast/regions/autoheight-lastregion-overflowauto-expected.html: Added.
- fast/regions/autoheight-lastregion-overflowauto.html: Added.
- fast/regions/autoheight-middleregion-expected.html: Added.
- fast/regions/autoheight-middleregion.html: Added.
- fast/regions/autoheight-secondregion-breakoutside-expected.html: Added.
- fast/regions/autoheight-secondregion-breakoutside.html: Added.
- fast/regions/autoheight-secondregion-expected.html: Added.
- fast/regions/autoheight-secondregion.html: Added.
- fast/regions/autoheight-singleregion-breakafteralways-expected.html: Added.
- fast/regions/autoheight-singleregion-breakafteralways-maxheight-expected.html: Added.
- fast/regions/autoheight-singleregion-breakafteralways-maxheight.html: Added.
- fast/regions/autoheight-singleregion-breakafteralways.html: Added.
- fast/regions/autoheight-singleregion-breakaftermargin-expected.html: Added.
- fast/regions/autoheight-singleregion-breakaftermargin.html: Added.
- fast/regions/autoheight-singleregion-breakbeforealways-expected.html: Added.
- fast/regions/autoheight-singleregion-breakbeforealways-minheight-expected.html: Added.
- fast/regions/autoheight-singleregion-breakbeforealways-minheight.html: Added.
- fast/regions/autoheight-singleregion-breakbeforealways.html: Added.
- fast/regions/autoheight-singleregion-multiplebreaks-expected.html: Added.
- fast/regions/autoheight-singleregion-multiplebreaks.html: Added.
- fast/regions/autoheight-singleregion-overflowauto-breaksignored-expected.html: Added.
- fast/regions/autoheight-singleregion-overflowauto-breaksignored.html: Added.
- fast/regions/autoheight-singleregion-overflowauto-expected.html: Added.
- fast/regions/autoheight-singleregion-overflowauto.html: Added.
- 3:22 AM Changeset in webkit [132601] by
-
- 13 edits in trunk
[EFL][WK2] Enable WebGL
https://bugs.webkit.org/show_bug.cgi?id=97652
Patch by Regina Chung <heejin.r.chung@samsung.com> on 2012-10-26
Reviewed by Gyuyoung Kim.
.:
Use Graphics Surface to enable WebGL for WebKit2 EFL.
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
Implemented GraphicsSurface for EFL to enable WebGL for WebKit2.
Depends on GLX since Evas doesn't provide the necessary functionality.
No new tests. Covered by existing tests.
- PlatformEfl.cmake:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::createGraphicsSurfaces):
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::reshape):
- platform/graphics/surfaces/efl: Added.
- platform/graphics/surfaces/efl/GraphicsSurfaceEfl.cpp: Added.
(WebCore):
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.h: Added.
(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::glContext):
(WebCore::resolveGLMethods):
- platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore):
(WebCore::OffScreenRootWindow::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
Source/WebKit2:
Set WebGLEnabled to true when WebGL is enabled.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize):
- 3:20 AM Changeset in webkit [132600] by
-
- 18 edits in trunk
Add feature flags for CSS Device Adaptation
https://bugs.webkit.org/show_bug.cgi?id=95960
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- GNUmakefile.features.am:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 3:18 AM Changeset in webkit [132599] by
-
- 9 edits2 adds in trunk
fast/forms/file/input-file-write-files.html should cover correct setting value
https://bugs.webkit.org/show_bug.cgi?id=100085
Patch by Li Yin <li.yin@intel.com> on 2012-10-26
Reviewed by Kentaro Hara.
Source/WebCore:
From Spec: http://dev.w3.org/html5/spec/single-page.html#dom-input-value-filename
On setting, if the new value is the empty string, it must empty the list of selected
files; otherwise, it must throw an InvalidStateError exception.
Test: fast/forms/file/input-file-value.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue):
(WebCore):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLInputElement.idl:
LayoutTests:
The test input-file-value.html is split from input-file-write-test.html.
And add correct setting value for files attribute, verify the files attribute
is writable or not.
- fast/forms/file/input-file-value-expected.txt: Added.
- fast/forms/file/input-file-value.html: Added.
- fast/forms/file/input-file-write-files-expected.txt:
- fast/forms/file/input-file-write-files.html:
- 3:09 AM Changeset in webkit [132598] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after bug 99824
https://bugs.webkit.org/show_bug.cgi?id=100469
Unreviewed, EFL gardening.
Unskip following 3 test cases after bug 99824 is resolved.
- fast/lists/w3-css3-list-styles-alphabetic.html
- fast/lists/w3-css3-list-styles-fallback-style.html
- fast/lists/w3-list-styles.html
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-26
- platform/efl-wk1/TestExpectations:
- 3:00 AM Changeset in webkit [132597] by
-
- 12 edits2 deletes in trunk/Tools
Unreviewed, rolling out r132552.
http://trac.webkit.org/changeset/132552
https://bugs.webkit.org/show_bug.cgi?id=100486
Makes typeahead tests crash in debug. (Requested by pfeldman
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/DRTTestRunner.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::doDragDrop):
(WebTestRunner::EventSender::updateClickCountForButton):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::handleMouseWheel):
(WebTestRunner::EventSender::gestureEvent):
(WebTestRunner::EventSender::gestureFlingCancel):
(WebTestRunner::EventSender::gestureFlingStart):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
(TestDelegate):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebKit):
(webkit_support):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestInterfaces::Internal):
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 2:56 AM Changeset in webkit [132596] by
-
- 2 edits in trunk/Source/WebCore
Refactor calendar picker to remove _x/_y from DaysTable
https://bugs.webkit.org/show_bug.cgi?id=100460
Reviewed by Kent Tamura.
_x/_y properties keep the coordinates for the selection but when we add
week and month picking capabilities, the selection can't be expressed as
a set of coordinates. This change will remove it.
No new tests. Covered by calendar-picker-*.html tests.
- Resources/pagepopups/calendarPicker.js:
(DaysTable): Removed _x/_y properties.
(DaysTable.prototype._hasSelection): Changed to refer to the DOM to see if we have a selection.
(DaysTable.prototype.navigateToMonthAndKeepSelectionPosition): Lookup the selection position.
(DaysTable.prototype.selectDate): Deselect first so we don't have two selections.
(DaysTable.prototype._selectRangeContainingNode): Selects date/week/month containing the given day node.
(DaysTable.prototype._selectRangeAtPosition): Selects date/week/month at the given position.
(DaysTable.prototype._firstNodeInSelectedRange): Returns first selected day node.
(DaysTable.prototype._deselect): Deselects all selections.
(DaysTable.prototype._handleMouseOver): Use _selectRangeContainingNode so we don't have many places handling the selection.
(DaysTable.prototype._handleMouseOut): Use _deselect.
(DaysTable.prototype._handleKey): Lookup the selection position.
(DaysTable.prototype.updateSelection): Use _selectRangeAtPosition.
- 2:40 AM Changeset in webkit [132595] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip svg/foreignObject/viewport-foreignobject-crash.html
https://bugs.webkit.org/show_bug.cgi?id=100467
Unreviewed, EFL gardening.
Removing a test failure expectations, the test was fixed in r132548.
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-26
- platform/efl-wk2/TestExpectations:
- 2:40 AM Changeset in webkit [132594] by
-
- 6 edits2 adds in trunk/Source/WebKit2
[EFL][WK2] Move input method code out of EwkViewImpl
https://bugs.webkit.org/show_bug.cgi?id=100468
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Move input method code out of EwkViewImpl and into
a new InputMethodContextEfl class to avoid cluttering
the view code.
- PlatformEfl.cmake:
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::inputMethodContext):
- UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_key_down):
- UIProcess/efl/InputMethodContextEfl.cpp: Added.
(WebKit):
(WebKit::InputMethodContextEfl::InputMethodContextEfl):
(WebKit::InputMethodContextEfl::~InputMethodContextEfl):
(WebKit::InputMethodContextEfl::onIMFInputSequenceComplete):
(WebKit::InputMethodContextEfl::onIMFPreeditSequenceChanged):
(WebKit::InputMethodContextEfl::createIMFContext):
(WebKit::InputMethodContextEfl::handleMouseUpEvent):
(WebKit::InputMethodContextEfl::handleKeyDownEvent):
(WebKit::InputMethodContextEfl::updateTextInputState):
- UIProcess/efl/InputMethodContextEfl.h: Added.
(WebKit):
(InputMethodContextEfl):
(WebKit::InputMethodContextEfl::create):
- UIProcess/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::updateTextInputState):
- 2:39 AM Changeset in webkit [132593] by
-
- 3 edits in trunk/LayoutTests
[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html fails every 3 days
https://bugs.webkit.org/show_bug.cgi?id=100480
Reviewed by Pavel Feldman.
Because the date field in the test has step=3, the availability of
[Today] button depends on the current date. We make the test stable by
specifying max attribute.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:
- 2:37 AM Changeset in webkit [132592] by
-
- 2 edits in trunk/Source/WebCore
FileReader abort case causes Chromium renderer crash
https://bugs.webkit.org/show_bug.cgi?id=99142
Patch by Ningxin Hu <ningxin.hu@intel.com> on 2012-10-26
Reviewed by Kentaro Hara.
Before dispatching load event, FileReader should check if it is
in aborting.
Test: manually launch fast/files/file-reader-abort.html in Chromium
browser and compare the result with
fast/files/file-reader-abort-expected.txt.
- fileapi/FileReader.cpp:
(WebCore::FileReader::didFinishLoading):
- 2:34 AM Changeset in webkit [132591] by
-
- 5 edits in trunk
Generate less repaint calls during subtree detaching
https://bugs.webkit.org/show_bug.cgi?id=99741
Reviewed by Eric Seidel.
Source/WebCore:
Following bug 98336, detach is now a subtree top-down operation. Because we
track visual overflow from our children during layout for most cases, we can
generate a repaint only on the subtree root.
On http://dglazkov.github.com/performance-tests/redraw.html, this ups the FPS to
26 fps from 22 fps on my MBP (+ 15%). On PerformanceTests/layout/subtree-detach.html,
it decreases the time by 35%. This is due to being the best case and we now generate
only one repaint per detach phase.
Covered by existing pixels tests (including but not limited to repaint ones).
- rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
Changed the function not to be recursive anymore to generate one painting for
our root only. Added a FIXME about using our RenderLayer for repainting to avoid
the cost of computing our absolute repaint rectangle.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Removed the logic for repainting in the general case. However we still force a repaint
if we have a RenderLayer as we don't track their overflow in some cases (e.g. positioned
objects). This check is conservative and could be narrowed down (e.g overflow RenderLayers
are properly accounted for in our clipppedOverflowRectForRepaint).
LayoutTests:
- platform/chromium-linux/fast/repaint/selection-after-remove-expected.png:
Rebaselined this test after the change. It is progressing as we still properly repaint
the selection, but repaint less (ie don't repaint the top border which didn't change).
- 2:33 AM Changeset in webkit [132590] by
-
- 2 edits in trunk/Source/JavaScriptCore
[WIN] Make LLInt offsets extractor work on Windows
https://bugs.webkit.org/show_bug.cgi?id=100369
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.
Open the input file explicitly in binary mode to prevent ruby/Windows from thinking that
it's a text mode file that needs even new line conversions. The binary mode parameter is
ignored on other platforms.
- offlineasm/offsets.rb:
- 2:09 AM Changeset in webkit [132589] by
-
- 2 edits in trunk/Source/WebCore
local(Helvetica) in src descriptor prevent fallback
https://bugs.webkit.org/show_bug.cgi?id=100446
Reviewed by Dan Bernstein.
FontCache::getCachedFontData() has a mechanism that aliases a few pairs
of font family names, so that if the family name specified in the font-family
property is not available on the system, but the its alias is available,
it will be used instead. This is appropriate for the font-family property,
but not for font family names specified in the local() function of the src
descriptor in a @font-face rule.
This patch disables the mechanism while checking src descriptor of @font-face.
No new tests. It's difficult to test the change because 'Helvetica' can
be mapped any other font. For example, chromium DRT uses FontConfig to
map Helvetica to Times New Roman. Other ports may map Helvetica to other
fonts. We can't define the expected result.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
Call fontCache()->getCachedFontData() with checkingAlternateName = true.
This disables aliasing font family names in FontCache.
- 2:06 AM Changeset in webkit [132588] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: Doctype Audits panel code
https://bugs.webkit.org/show_bug.cgi?id=100371
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-26
Reviewed by Alexander Pavlov.
This is a preparation step for ongoing refactoring.
It is much easier to read doctyped code.
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
Replaced "undefined" with "null"
- inspector/front-end/AuditsPanel.js:
(WebInspector.AuditCategory.prototype.callbackWrapper):
Removed callback parameter indirection.
(WebInspector.AuditRuleResult.prototype.addFormatted):
Converted private instance function to scoped function.
- 2:01 AM Changeset in webkit [132587] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=100471
- platform/chromium/TestExpectations:
We should do rebaseline for time-suggestion-picker-*.html too.
- 1:39 AM Changeset in webkit [132586] by
-
- 4 edits in trunk
Disable ENABLE_INPUT_TYPE_WEEK on Chromium/Android
https://bugs.webkit.org/show_bug.cgi?id=100457
Reviewed by Kentaro Hara.
Source/WebKit/chromium:
It was enabled accidentally. Week input is not implemented in
Android.
- features.gypi: Remove ENABLE_INPUT_TYPE_WEEK=1 in the common block,
add ENABLE_INPUT_TYPE_WEEK=0 in Android block, and add
ENABLE_INPUT_TYPE_WEEK=1 in non-Android block.
LayoutTests:
- platform/chromium/TestExpectations:
Tests in fast/forms/week/ may fail on Android.
- 1:25 AM Changeset in webkit [132585] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromiuim expectations updated.
- platform/chromium/TestExpectations:
- 1:24 AM Changeset in webkit [132584] by
-
- 4 edits301 adds in trunk/LayoutTests
[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323
Unreviewed pixel rebaseline.
Adding new expectations, mark failures.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/bgCompositeCopy-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize01-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize04-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize05-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize06-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize07-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize12-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize13-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize14-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize17-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize18-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize19-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize20-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize21-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize22-expected.png: Added.
- platform/qt-5.0-wk2/svg/css/arrow-with-shadow-expected.png: Added.
- platform/qt/TestExpectations:
- platform/qt/animations/state-at-end-event-expected.png: Added.
- platform/qt/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.png: Added.
- platform/qt/compositing/overflow/nested-scrolling-expected.png: Added.
- platform/qt/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.png: Added.
- platform/qt/compositing/overflow/remove-overflow-crash2-expected.png: Added.
- platform/qt/css2.1/t1004-c43-rpl-ibx-00-d-ag-expected.png: Added.
- platform/qt/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
- platform/qt/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
- platform/qt/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
- platform/qt/css2.1/t1202-counters-04-b-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-00-c-ag-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-01-c-ag-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-02-c-ag-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-03-c-ag-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-04-c-ag-expected.png: Added.
- platform/qt/css2.1/t140201-c534-bgreps-05-c-ag-expected.png: Added.
- platform/qt/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
- platform/qt/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
- platform/qt/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
- platform/qt/css2.1/t1604-c542-letter-sp-01-b-a-expected.png: Added.
- platform/qt/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
- platform/qt/css3/flexbox/flexbox-baseline-expected.png: Added.
- platform/qt/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
- platform/qt/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
- platform/qt/fast/backgrounds/bgCompositeCopy-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize01-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize03-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize04-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize05-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize06-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize07-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize08-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize09-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize10-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize11-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize12-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize13-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize14-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize17-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize18-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize19-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize20-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize21-expected.png: Added.
- platform/qt/fast/backgrounds/size/backgroundSize22-expected.png: Added.
- platform/qt/fast/block/float/009-expected.png: Added.
- platform/qt/fast/block/float/034-expected.png: Added.
- platform/qt/fast/block/float/4145535Crash-expected.png: Added.
- platform/qt/fast/block/float/negative-margin-clear-expected.png: Added.
- platform/qt/fast/block/float/nowrap-clear-min-width-expected.png: Added.
- platform/qt/fast/borders/border-image-scaled-gradient-expected.png: Added.
- platform/qt/fast/borders/border-radius-circle-expected.png: Added.
- platform/qt/fast/borders/border-radius-groove-01-expected.png: Added.
- platform/qt/fast/borders/border-radius-groove-02-expected.png: Added.
- platform/qt/fast/borders/border-radius-groove-03-expected.png: Added.
- platform/qt/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
- platform/qt/fast/borders/border-radius-wide-border-01-expected.png: Added.
- platform/qt/fast/borders/border-radius-wide-border-02-expected.png: Added.
- platform/qt/fast/borders/border-radius-wide-border-03-expected.png: Added.
- platform/qt/fast/borders/border-radius-wide-border-04-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDashed04-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDashed05-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDashed06-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDotted04-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDotted05-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDotted06-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble04-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble05-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble06-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble07-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble08-expected.png: Added.
- platform/qt/fast/borders/borderRadiusDouble09-expected.png: Added.
- platform/qt/fast/borders/outline-offset-min-assert-expected.png: Added.
- platform/qt/fast/css/006-expected.png: Added.
- platform/qt/fast/css/background-clip-values-expected.png: Added.
- platform/qt/fast/css/bogus-color-span-expected.png: Added.
- platform/qt/fast/css/box-shadow-and-border-radius-expected.png:
- platform/qt/fast/css/content-dynamic-expected.png: Added.
- platform/qt/fast/css/contentDiv-expected.png: Added.
- platform/qt/fast/css/contentDivWithChildren-expected.png: Added.
- platform/qt/fast/css/contentImage-expected.png: Added.
- platform/qt/fast/css/pseudo-first-line-border-width-expected.png: Added.
- platform/qt/fast/css/replaced-element-implicit-size-expected.png: Added.
- platform/qt/fast/dom/attr_dead_doc-expected.png: Added.
- platform/qt/fast/dom/css-cached-import-rule-expected.png: Added.
- platform/qt/fast/dom/css-insert-import-rule-expected.png: Added.
- platform/qt/fast/dynamic/001-expected.png: Added.
- platform/qt/fast/dynamic/005-expected.png: Added.
- platform/qt/fast/dynamic/anonymous-block-layer-lost-expected.png: Added.
- platform/qt/fast/dynamic/staticY-expected.png: Added.
- platform/qt/fast/forms/002-expected.png: Added.
- platform/qt/fast/forms/003-expected.png: Added.
- platform/qt/fast/forms/004-expected.png: Added.
- platform/qt/fast/forms/005-expected.png: Added.
- platform/qt/fast/forms/006-expected.png: Added.
- platform/qt/fast/forms/007-expected.png: Added.
- platform/qt/fast/forms/HTMLOptionElement_label01-expected.png: Added.
- platform/qt/fast/forms/HTMLOptionElement_label02-expected.png: Added.
- platform/qt/fast/forms/HTMLOptionElement_label03-expected.png: Added.
- platform/qt/fast/forms/HTMLOptionElement_label04-expected.png: Added.
- platform/qt/fast/forms/button-submit-expected.png: Added.
- platform/qt/fast/forms/caret-rtl-expected.png: Added.
- platform/qt/fast/forms/control-clip-expected.png: Added.
- platform/qt/fast/forms/fieldset-with-float-expected.png: Added.
- platform/qt/fast/forms/form-added-to-table-expected.png: Added.
- platform/qt/fast/forms/form-in-malformed-markup-expected.png: Added.
- platform/qt/fast/forms/formmove-expected.png: Added.
- platform/qt/fast/forms/formmove2-expected.png: Added.
- platform/qt/fast/forms/image-border-expected.png: Added.
- platform/qt/fast/forms/indeterminate-expected.png: Added.
- platform/qt/fast/forms/input-align-image-expected.png: Added.
- platform/qt/fast/forms/input-first-letter-expected.png: Added.
- platform/qt/fast/forms/input-no-renderer-expected.png: Added.
- platform/qt/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Added.
- platform/qt/fast/forms/menulist-deselect-update-expected.png: Added.
- platform/qt/fast/forms/menulist-no-overflow-expected.png: Added.
- platform/qt/fast/forms/option-index-expected.png: Added.
- platform/qt/fast/forms/option-script-expected.png: Added.
- platform/qt/fast/forms/option-text-clip-expected.png: Added.
- platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
- platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.png: Added.
- platform/qt/fast/forms/select-align-expected.png: Added.
- platform/qt/fast/forms/select-change-listbox-to-popup-expected.png: Added.
- platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
- platform/qt/fast/forms/select-disabled-appearance-expected.png: Added.
- platform/qt/fast/forms/select-display-none-style-resolve-expected.png: Added.
- platform/qt/fast/forms/select-empty-option-height-expected.png: Added.
- platform/qt/fast/forms/select-selected-expected.png: Added.
- platform/qt/fast/forms/select-size-expected.png: Added.
- platform/qt/fast/forms/select-style-expected.png: Added.
- platform/qt/fast/forms/stuff-on-my-optgroup-expected.png: Added.
- platform/qt/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
- platform/qt/fast/frames/002-expected.png: Added.
- platform/qt/fast/frames/calculate-round-expected.png: Added.
- platform/qt/fast/frames/content-opacity-1-expected.png: Added.
- platform/qt/fast/frames/content-opacity-2-expected.png: Added.
- platform/qt/fast/frames/empty-cols-attribute-expected.png: Added.
- platform/qt/fast/frames/empty-frame-src-expected.png: Added.
- platform/qt/fast/frames/frame-length-fractional-expected.png: Added.
- platform/qt/fast/frames/frame-set-whitespace-attributes-expected.png: Added.
- platform/qt/fast/frames/iframe-text-contents-expected.png: Added.
- platform/qt/fast/frames/no-frame-borders-expected.png: Added.
- platform/qt/fast/gradients/border-image-gradient-expected.png: Added.
- platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
- platform/qt/fast/images/embed-image-expected.png: Added.
- platform/qt/fast/images/favicon-as-image-expected.png: Added.
- platform/qt/fast/images/image-css3-content-data-expected.png: Added.
- platform/qt/fast/images/object-image-expected.png: Added.
- platform/qt/fast/images/pdf-as-image-expected.png: Added.
- platform/qt/fast/inline-block/004-expected.png: Added.
- platform/qt/fast/inline-block/005-expected.png: Added.
- platform/qt/fast/invalid/015-expected.png: Added.
- platform/qt/fast/invalid/table-residual-style-crash-expected.png: Added.
- platform/qt/fast/js/exception-linenums-in-html-3-expected.png: Added.
- platform/qt/fast/js/missing-style-end-tag-js-expected.png: Added.
- platform/qt/fast/js/missing-title-end-tag-js-expected.png: Added.
- platform/qt/fast/layers/opacity-stacking-expected.png: Added.
- platform/qt/fast/layers/positioned-inside-root-with-margins-expected.png: Added.
- platform/qt/fast/layers/zindex-ridonkulous-expected.png: Added.
- platform/qt/fast/media/implicit-media-all-expected.png: Added.
- platform/qt/fast/media/media-query-invalid-value-expected.png: Added.
- platform/qt/fast/media/monochrome-expected.png: Added.
- platform/qt/fast/media/mq-min-pixel-ratio-expected.png: Added.
- platform/qt/fast/overflow/position-relative-expected.png: Added.
- platform/qt/fast/overflow/unreachable-content-test-expected.png: Added.
- platform/qt/fast/parser/comment-in-script-expected.png: Added.
- platform/qt/fast/parser/style-script-head-test-expected.png: Added.
- platform/qt/fast/reflections/table-cell-expected.png: Added.
- platform/qt/fast/repaint/background-generated-expected.png: Added.
- platform/qt/fast/repaint/background-misaligned-expected.png: Added.
- platform/qt/fast/repaint/canvas-putImageData-expected.png: Added.
- platform/qt/fast/repaint/erase-overflow-expected.png: Added.
- platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
- platform/qt/fast/repaint/float-new-in-block-expected.png: Added.
- platform/qt/fast/repaint/inline-block-resize-expected.png: Added.
- platform/qt/fast/repaint/intermediate-layout-position-clip-expected.png: Added.
- platform/qt/fast/repaint/intermediate-layout-position-expected.png: Added.
- platform/qt/fast/repaint/layer-full-repaint-expected.png: Added.
- platform/qt/fast/repaint/table-col-background-expected.png: Added.
- platform/qt/fast/repaint/table-outer-border-expected.png: Added.
- platform/qt/fast/repaint/table-row-expected.png: Added.
- platform/qt/fast/repaint/table-section-overflow-expected.png: Added.
- platform/qt/fast/replaced/008-expected.png: Added.
- platform/qt/fast/replaced/image-tag-expected.png: Added.
- platform/qt/fast/replaced/selection-rect-expected.png: Added.
- platform/qt/fast/table/008-expected.png: Added.
- platform/qt/fast/table/024-expected.png: Added.
- platform/qt/fast/table/031-expected.png: Added.
- platform/qt/fast/table/caption-relayout-expected.png: Added.
- platform/qt/fast/table/colspanMinWidth-vertical-expected.png: Added.
- platform/qt/fast/table/div-as-col-span-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png: Added.
- platform/qt/fast/table/fixed-table-with-small-percent-width-expected.png: Added.
- platform/qt/fast/table/giantRowspan-expected.png: Added.
- platform/qt/fast/table/growCellForImageQuirk-expected.png: Added.
- platform/qt/fast/table/percent-widths-stretch-expected.png: Added.
- platform/qt/fast/table/vertical-align-baseline-readjust-expected.png: Added.
- platform/qt/fast/text/align-center-rtl-spill-expected.png: Added.
- platform/qt/fast/text/basic/013-expected.png: Added.
- platform/qt/fast/text/basic/015-expected.png: Added.
- platform/qt/fast/text/line-breaks-expected.png: Added.
- platform/qt/fast/text/soft-hyphen-3-expected.png: Added.
- platform/qt/fast/text/stripNullFromText-expected.png: Added.
- platform/qt/fast/text/whitespace/017-expected.png: Added.
- platform/qt/fast/tokenizer/missing-style-end-tag-1-expected.png: Added.
- platform/qt/fast/tokenizer/missing-style-end-tag-2-expected.png: Added.
- platform/qt/fast/tokenizer/script-after-frameset-expected.png: Added.
- platform/qt/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Added.
- platform/qt/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-background-1-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-background-2-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-background-3-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-background-6-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-background-expected.png: Added.
- platform/qt/svg/as-background-image/svg-as-tiled-background-expected.png: Added.
- platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.png: Added.
- platform/qt/svg/as-image/svg-as-image-expected.png: Added.
- platform/qt/svg/as-image/svg-as-relative-image-expected.png: Added.
- platform/qt/svg/css/arrow-with-shadow-expected.png: Added.
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.png: Added.
- platform/qt/svg/css/path-with-shadow-expected.png: Added.
- platform/qt/svg/css/shadow-and-opacity-expected.png: Added.
- platform/qt/svg/css/shadow-with-large-radius-expected.png: Added.
- platform/qt/svg/css/shadow-with-negative-offset-expected.png: Added.
- platform/qt/svg/custom/animation-currentColor-expected.png: Added.
- platform/qt/svg/custom/clip-path-id-changes-expected.png: Added.
- platform/qt/svg/custom/createImageElement-expected.png: Added.
- platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
- platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
- platform/qt/svg/custom/js-update-image-and-display-expected.png: Added.
- platform/qt/svg/custom/js-update-image-and-display2-expected.png: Added.
- platform/qt/svg/custom/js-update-image-and-display3-expected.png: Added.
- platform/qt/svg/custom/marker-opacity-expected.png: Added.
- platform/qt/svg/custom/marker-referencePoint-expected.png: Added.
- platform/qt/svg/custom/marker-strokeWidth-changes-expected.png: Added.
- platform/qt/svg/custom/mask-on-multiple-objects-expected.png: Added.
- platform/qt/svg/custom/mask-with-default-value-expected.png: Added.
- platform/qt/svg/custom/outer-svg-unknown-feature-expected.png: Added.
- platform/qt/svg/custom/pan-direction-expected.png: Added.
- platform/qt/svg/custom/pattern-excessive-malloc-expected.png: Added.
- platform/qt/svg/custom/repaint-shadow-expected.png: Added.
- platform/qt/svg/custom/transformedMaskFails-expected.png: Added.
- platform/qt/svg/custom/use-inherit-style-expected.png: Added.
- platform/qt/svg/custom/xhtml-no-svg-renderer-expected.png: Added.
- platform/qt/svg/filters/feGaussianBlur-expected.png: Added.
- platform/qt/svg/filters/feLighting-crash-expected.png: Added.
- platform/qt/svg/filters/feMerge-expected.png: Added.
- platform/qt/svg/filters/feMerge-wrong-input-expected.png: Added.
- platform/qt/svg/filters/feOffset-expected.png: Added.
- platform/qt/svg/filters/feTile-expected.png: Added.
- platform/qt/svg/filters/filter-clip-expected.png: Added.
- platform/qt/svg/filters/filter-rounding-issues-expected.png: Added.
- platform/qt/svg/filters/shadow-on-filter-expected.png: Added.
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/qt/svg/filters/subRegion-in-userSpace-expected.png: Added.
- platform/qt/svg/hixie/error/006-expected.png: Added.
- platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug120107-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug1271-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug12908-2-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug12910-2-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug131020-2-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug13169-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug137388-3-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug1818-3-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug1818-6-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug196870-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug222336-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug222467-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug269566-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug277062-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug28933-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug2954-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug50695-2-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug56201-expected.png: Added.
- platform/qt/tables/mozilla/bugs/bug8032-2-expected.png: Added.
- platform/qt/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Added.
- platform/qt/transitions/opacity-transition-zindex-expected.png: Added.
- platform/qt/transitions/transition-end-event-rendering-expected.png: Added.
- 1:24 AM Changeset in webkit [132583] by
-
- 2 edits in trunk/Source/WebCore
[Qt]REGRESSION(r131428): cookies.db created on wrong place
https://bugs.webkit.org/show_bug.cgi?id=99445
Patch by János Badics <János Badics> on 2012-10-26
Reviewed by Simon Hausmann.
Added a slash to the path of cookies.db in CookieJarQt.cpp.
- platform/qt/CookieJarQt.cpp:
(WebCore::SharedCookieJarQt::SharedCookieJarQt):
- 1:11 AM Changeset in webkit [132582] by
-
- 9 edits in trunk
[BlackBerry] Support pixel tests for BlackBerry DRT
https://bugs.webkit.org/show_bug.cgi?id=100210
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-10-26
Reviewed by Rob Buis.
Source/WebKit:
Adds a step to build ImageDiff from Qt for DRT. Most of the works are
accomplished by Christopher Wells.
- PlatformBlackBerry.cmake:
Tools:
The implementation is based on the patch from Christopher Wells.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::runTest):
(BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::DumpRenderTree::runTests):
(BlackBerry::WebKit::DumpRenderTree::dump):
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(DumpRenderTree):
- DumpRenderTree/blackberry/PNGImageEncoder.cpp:
(BGRAtoRGBA):
(encodeBitmapToPNG):
- DumpRenderTree/blackberry/PNGImageEncoder.h:
The changes to PNGImageEncoder files are from master_40, patched by Tyler
Abbott and Rob Buis.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(createBitmapContextFromWebView):
(computeMD5HashStringForBitmapContext):
(printPNG):
(dumpBitmap):
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
(BitmapContext::createByAdoptingData):
(BitmapContext::~BitmapContext):
(BitmapContext):
(BitmapContext::BitmapContext):
- DumpRenderTree/blackberry/build: Added.
- DumpRenderTree/blackberry/src.pro: Added.
Adds 2 files for building ImageDiff, by Christopher Wells.
- 1:10 AM Changeset in webkit [132581] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. This ASSERT is no longer correct (and fires on many tests.)
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
- 12:51 AM Changeset in webkit [132580] by
-
- 2 edits in trunk/LayoutTests
Not reviewed: chromiuim expectations updated.
- platform/chromium/TestExpectations:
- 12:43 AM Changeset in webkit [132579] by
-
- 12 edits in trunk
[Chromium-Win] Support shortTimeFormat
https://bugs.webkit.org/show_bug.cgi?id=100471
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests. Covered by fast/forms/time-multiple-fields/ and
WebKit/chromium/tests/LocaleWinTest.
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::shortTimeFormat):
Gets a format by LOCALE_SSHORTTIME. If it fails, remove "<delimiter>ss"
from the format by LOCALE_STIMEFORMAT.
- platform/text/LocaleWin.h:
(LocaleWin): Declare m_timeFormatWithoutSeconds.
Source/WebKit/chromium:
- tests/LocaleWinTest.cpp:
(TEST_F): Update test expectations for the behavior change.
LayoutTests:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
- platform/chromium/TestExpectations:
- 12:35 AM Changeset in webkit [132578] by
-
- 2 edits in trunk/Source/WebKit2
Implement {get,set}FloatValueForKey
https://bugs.webkit.org/show_bug.cgi?id=100452
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-26
Reviewed by Anders Carlsson.
Implement missing functions in WebPreferencesStore.
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::setFloatValueForKey):
(WebKit):
(WebKit::WebPreferencesStore::getFloatValueForKey):
- 12:32 AM Changeset in webkit [132577] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Skip a new failing test introduced in r132554 that fails on 32 bit platforms.
Remove another one that does not exists already.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-26
- platform/qt/TestExpectations:
- 12:15 AM Changeset in webkit [132576] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed. Update run-bindings-tests results after recent active DOM
object changes.
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::wrap):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::wrap):
- 12:07 AM Changeset in webkit [132575] by
-
- 2 edits in trunk/Source/WebCore
[V8] REGRESSION(132540) Assertion failure on V8DOMWrapper::setJSWrapperForDOMNode()
https://bugs.webkit.org/show_bug.cgi?id=100462
Patch by MORITA Hajime <morrita@google.com> on 2012-10-26
Reviewed by Adam Barth.
Removed the no longer correct assertion statement.
No new tests. Covered by breaking tests.
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
