Timeline
Aug 4, 2014:
- 10:09 PM Changeset in webkit [172027] by
-
- 5 edits in trunk
AX: Select activity behavior does not work when an existing range is already selected
https://bugs.webkit.org/show_bug.cgi?id=135579
Reviewed by Mario Sanchez Prada.
Source/WebCore:
If you have an existing range selected, and try to apply a select and replace operation, like capitalize,
searching for that range will fail because it skips the currently selected range.
For these cases, it seems the best way is to start the search from the start position, rather than relying on the
entire range.
Updated existing test: platform/mac/accessibility/select-text.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectText):
LayoutTests:
- platform/mac/accessibility/select-text-expected.txt:
- platform/mac/accessibility/select-text.html:
- 8:58 PM Changeset in webkit [172026] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Seeking past buffered range will not resume playback when seek completes.
https://bugs.webkit.org/show_bug.cgi?id=135591
Reviewed by Eric Carlson.
If a seek is delayed due to seeking into an unbuffered area, playback will not be restarted
at that point. Instead, playback must resume when enough media data has been added, and
the MediaSource indicates the seek should complete.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekCompleted):
- 8:57 PM Changeset in webkit [172025] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Videos will report a stall when within 1 frame-duration before the end of a movie.
https://bugs.webkit.org/show_bug.cgi?id=135586
Reviewed by Eric Carlson.
Under certain circumstances, videos which are within 1/24 seconds before the end of a media stream when
monitorSourceBuffers() is called will fail the hasFutureTime() check. This is because hasFutureTime()
checks whether enough media is buffered to play back at least some time in the future, but when the
current time is close to the duration, not enough data is buffered to satisfy that check.
Add some logic which will break out early when the SourceBuffer has buffered up to and including the
media's duration, and return that the buffer indeed hasFutureTime() available.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::hasFutureTime):
- 8:40 PM Changeset in webkit [172024] by
-
- 5 edits2 adds in trunk
Simplify the StyleInvalidation mode of rule collection
https://bugs.webkit.org/show_bug.cgi?id=135521
Reviewed by Antti Koivisto.
Source/WebCore:
There are two branches where StyleInvalidation code is removed:
-Pseudo elements for shadow dom elements.
-Pseudo elements without dom tree counterpart.
The first can never be hit because StyleInvalidationAnalysis does a complete invalidation
when there is any shadow dom styling involved in the stylesheets.
Even if that branch was hit, not failing on custom pseudo elements would be equivalent
to ignoring those pseudo elements from the Selector. By doing so, we would match elements
that do not have shadow dom and invalidate pretty much everything.
Unlike pseudo elements without real elements, shadow dom elements are not matched separately with a different
context, thus we could generalize StyleInvalidationAnalysis to handle this case.
The second case handle pseudo elements that do not have a real element. That case no longer need to be handled
separately at the filter time, it has become a special case of SelectorChecker::match() after everything else
has matched.
The only condition for this to work is that the Context's pseudoId must be NOPSEUDO. This is the case
in practice since matching specific pseudo types would be a waste of time. ElementRuleCollector::collectMatchingRules()
has a new assertion to enforce that.
Test: fast/css/stylesheet-change-updates-pseudo-elements.html
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
LayoutTests:
This test by:
1) Forcing the recalc of the user-agent stylesheet.
2) Wait for the page to finish loading.
3) Add a style changing only pseudo elements without corresponding shadow element.
- fast/css/stylesheet-change-updates-pseudo-elements-expected.html: Added.
- fast/css/stylesheet-change-updates-pseudo-elements.html: Added.
- 8:25 PM Changeset in webkit [172023] by
-
- 15 edits in trunk
Add a flag for the CSS Selectors level 4 implementation
https://bugs.webkit.org/show_bug.cgi?id=135535
Reviewed by Andreas Kling.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props:
- 7:51 PM Changeset in webkit [172022] by
-
- 2 edits in trunk/Tools
[GTK] run-launcher --gtk is broken
https://bugs.webkit.org/show_bug.cgi?id=135571
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-08-04
Reviewed by Martin Robinson.
- Scripts/webkitdirs.pm:
(builtDylibPathForName): Search for libwebkit2gtk-4.0
- 7:47 PM Changeset in webkit [172021] by
-
- 3 edits in trunk/Source/WebCore
AX: add AccessibilityObject::computedLabelString() for WebAXI
https://bugs.webkit.org/show_bug.cgi?id=129939
Reviewed by Mario Sanchez Prada.
Provide a method that the WebKit Inspector can call in order to
display an accessible name for an AX node.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityComputedLabel):
- accessibility/AccessibilityObject.h:
- 7:01 PM Changeset in webkit [172020] by
-
- 5 edits in tags/Safari-600.1.2.6/Source
Versioning.
- 6:54 PM Changeset in webkit [172019] by
-
- 6 edits in tags/Safari-600.1.2.6
Apply custom patch from https://bugs.webkit.org/show_bug.cgi?id=135543
- 6:39 PM Changeset in webkit [172018] by
-
- 2 edits in trunk/Source/WebCore
Lots of crashes in WebKit1 after r172013.
https://bugs.webkit.org/show_bug.cgi?id=135582
<rdar://problem/17837636>
Reviewed by Enrica Casucci.
- editing/SelectionRectGatherer.cpp:
(WebCore::SelectionRectGatherer::addRect):
(WebCore::SelectionRectGatherer::addGapRects):
Don't try to do local-to-absolute coordinate conversion if we don't have
a repaint container, which happens a lot in WebKit1.
- 6:31 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 6:28 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 6:22 PM Changeset in webkit [172017] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Report and mark new failures after 172008 and r172010.
Remove expectations for test that now pass after r171964 (revert of r171957).
Update expectations for new flaky tests.
- 6:04 PM Changeset in webkit [172016] by
-
- 4 edits in trunk/Source
Check for null frame when processing geolocation authorization request
https://bugs.webkit.org/show_bug.cgi?id=135577
<rdar://problem/17896295>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-04
Reviewed by Geoffrey Garen.
Source/WebKit/mac:
- WebCoreSupport/WebGeolocationClient.mm:
(WebGeolocationClient::requestPermission):
Source/WebKit2:
I could have put the null check in GeolocationController instead of the WebKit layer,
but that would be a little weird as GeolocationController knows nothing about how
the WebKit layer decides what to do with requests.
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
- 5:58 PM Changeset in webkit [172015] by
-
- 1 copy in tags/Safari-600.1.2.6
New Tag.
- 5:30 PM Changeset in webkit [172014] by
-
- 8 edits3 adds in trunk
Progress towards CMake on Mac.
https://bugs.webkit.org/show_bug.cgi?id=135528
Reviewed by Gyuyoung Kim.
.:
- Source/cmake/OptionsMac.cmake:
Made options list based on FeatureDefines.xcconfig files.
Source/JavaScriptCore:
- CMakeLists.txt:
Include necessary directories and copy all necessary forwarding headers.
Only compile UDis86Disassembler.cpp if we're using UDIS86.
- PlatformMac.cmake: Added.
- tools/CodeProfiling.cpp:
Compile fix. Include sys/time.h on darwin, too.
Source/WebCore:
- PlatformMac.cmake: Added.
Source/WTF:
- wtf/CMakeLists.txt:
Include text directory.
- wtf/PlatformMac.cmake: Added.
- 5:28 PM Changeset in webkit [172013] by
-
- 4 edits in trunk/Source/WebCore
Selection services menu dropdown is in the wrong place when selecting some text on Yelp
https://bugs.webkit.org/show_bug.cgi?id=135582
<rdar://problem/17837636>
Reviewed by Simon Fraser.
- editing/SelectionRectGatherer.cpp:
(WebCore::SelectionRectGatherer::addRect):
(WebCore::SelectionRectGatherer::addGapRects):
(WebCore::SelectionRectGatherer::addRects): Deleted.
Rename addRects to addGapRects for clarity.
Map rects and gapRects to absolute RenderView coordinates so that
they are in a form WebKit2 can use. Previously they were sometimes
relative to a different repaint container, but that information was
lost when moving through SelectionRectGatherer.
Ideally we would keep selection rects as full quads instead of rects
for more of their life, but that problem is much deeper than just SelectionRectGatherer.
- editing/SelectionRectGatherer.h:
Add a comment clarifying the coordinate space of the stored selection rects.
- rendering/RenderView.cpp:
(WebCore::RenderView::applySubtreeSelection):
Rename addRects to addGapRects for clarity.
- 4:06 PM Changeset in webkit [172012] by
-
- 2 edits in trunk/Tools
lldb_webkit.py throws exception when generating summary of null StringImpl
https://bugs.webkit.org/show_bug.cgi?id=129448
Patch by Matt Baker <Matt Baker> on 2014-08-04
Reviewed by Jer Noble.
Added checks for null StringImpl and 0 byte ReadMemory calls.
- lldb/lldb_webkit.py:
(WTFStringImpl_SummaryProvider):
(ustring_to_string):
(lstring_to_string):
(WTFStringImplProvider.to_string):
(WTFStringImplProvider.is_initialized):
- 3:25 PM Changeset in webkit [172011] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 3:17 PM Changeset in webkit [172010] by
-
- 3 edits3 adds in trunk
[CSS Shapes] shape-margin not respected when it extends beyond an explicitly set margin
https://bugs.webkit.org/show_bug.cgi?id=135308
Reviewed by Dean Jackson.
Source/WebCore:
When a zero height line is supplied and the image shape extends into
the margin box (only possible when a shape-margin is supplied), then
only an empty interval was being returned. This patch makes it
properly return the interval for the line in question.
Test: fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShape::getExcludedIntervals): Handle the zero height
line case.
LayoutTests:
Test case based on the one supplied by Rebecca Hauck in the bug
report.
- fast/shapes/resources/square.png: Added.
- fast/shapes/shape-outside-floats/shape-outside-image-shape-margin-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html: Added.
- 3:04 PM Changeset in webkit [172009] by
-
- 4 edits in trunk/Source/JavaScriptCore
Create a more generic way for VMEntryScope to notify those interested that it will be destroyed
https://bugs.webkit.org/show_bug.cgi?id=135358
Patch by Saam Barati <sbarati@apple.com> on 2014-08-04
Reviewed by Geoffrey Garen.
When VMEntryScope is destroyed, and it has a flag set indicating that the
Debugger needs to recompile all functions, it calls Debugger::recompileAllJSFunctions.
This flag is only used by Debugger to have VMEntryScope notify it when the
Debugger is safe to recompile all functions. This patch will substitute this
Debugger-specific recompilation flag with a list of callbacks that are notified
when the outermost VMEntryScope dies. This creates a general purpose interface
for being notified when the VM stops executing code via the event of the outermost
VMEntryScope dying.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::addEntryScopeDidPopListener):
(JSC::VMEntryScope::~VMEntryScope):
- runtime/VMEntryScope.h:
(JSC::VMEntryScope::setRecompilationNeeded): Deleted.
- 3:01 PM Changeset in webkit [172008] by
-
- 7 edits2 adds in trunk
Subpixel rendering: InlineTextBox mistakenly rounds offset value before painting.
https://bugs.webkit.org/show_bug.cgi?id=135470
Reviewed by Simon Fraser.
This patch removes the premature paint offset adjustment for inlines. Premature snapping
could alter the final painting coordinates and push content to wrong positions.
This patch also enforces WebCore's pixel snapping strategy (round) on text painting.
It ensures that text positioning is in sync with other painting related operations including
clipping, box decorations etc. Underlying graphics libraries can take different directions on
text snapping, for example CG ceils text coordinates vertically (in horizontal context,
with the current settings). It can lead to undesired side effects.
Source/WebCore:
Test: fast/inline/hidpi-inline-selection-leaves-gap.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects): wrong direction used at r171896.
- rendering/SimpleLineLayoutFunctions.cpp: we don't paint vertical content here.
(WebCore::SimpleLineLayout::paintFlow):
LayoutTests:
- fast/inline/hidpi-inline-selection-leaves-gap-expected.html: Added.
- fast/inline/hidpi-inline-selection-leaves-gap.html: Added.
- fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html:
- fast/multicol/newmulticol/multicol-clip-rounded-corners.html: pixels are distributed properly.
No need to have the special 122px shortened width for col2.
- 2:58 PM Changeset in webkit [172007] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r171992, r171995, & r172000.
The cumulative effect of those revisions was to cause decoding errors when switching resolutions on YouTube.
Reverted changesets:
https://bugs.webkit.org/show_bug.cgi?id=135422 / http://trac.webkit.org/changeset/171992
https://bugs.webkit.org/show_bug.cgi?id=135424 / http://trac.webkit.org/changeset/171995
https://bugs.webkit.org/show_bug.cgi?id=135572 / http://trac.webkit.org/changeset/172000
- 2:57 PM Changeset in webkit [172006] by
-
- 2 edits in trunk/Source/WebCore
Always clear ConsoleClient when Page/WindowShell is destroyed
https://bugs.webkit.org/show_bug.cgi?id=135569
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-04
Reviewed by Mark Lam.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
Whenever a window shell goes away, clear the console client.
We did this in clearWindowShell but not before destroying.
- 2:56 PM Changeset in webkit [172005] by
-
- 5 edits in trunk
AX: isWordEndMatch should allow for multiple word selections
https://bugs.webkit.org/show_bug.cgi?id=135573
Reviewed by Mario Sanchez Prada.
Source/WebCore:
isWordEndMatch was searching from the beginning of the selected range, which meant
that if the result was multiple words, we'd reject the result.
Instead, we should search from the end of the range, so that we encompass all words.
Modified existing test: platform/mac/accessibility/select-text-should-match-whole-words.html
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::isWordEndMatch):
LayoutTests:
- platform/mac/accessibility/select-text-should-match-whole-words-expected.txt:
- platform/mac/accessibility/select-text-should-match-whole-words.html:
- 2:25 PM Changeset in webkit [172004] by
-
- 1 delete in tags/Safari-600.1.2.5/safari-600.1.4-branch
Delete incorrect Tag.
- 2:18 PM Changeset in webkit [172003] by
-
- 1 copy in tags/Safari-600.1.4.5
New Tag.
- 2:17 PM Changeset in webkit [172002] by
-
- 3 edits2 adds in trunk
AX: Secure text fields need to support Search parameterized attributes
https://bugs.webkit.org/show_bug.cgi?id=135568
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Secure text fields still need to support the fast searching that WebKit exposes, even though they don't support
other parameterized attributes.
Test: platform/mac/accessibility/secure-text-field-supports-fast-search.html
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
LayoutTests:
- platform/mac/accessibility/secure-text-field-supports-fast-search-expected.txt: Added.
- platform/mac/accessibility/secure-text-field-supports-fast-search.html: Added.
- 2:13 PM Changeset in webkit [172001] by
-
- 1 copy in tags/Safari-600.1.2.5/safari-600.1.4-branch
New Tag.
- 1:54 PM Changeset in webkit [172000] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Further fixes for "fast forward" playback after seeking in YouTube behavior.
https://bugs.webkit.org/show_bug.cgi?id=135572
Reviewed by Eric Carlson.
Two related fixes:
In reenqueueMediaForTime(), update TrackBuffer.lastEnqueuedPresentationTime when we flush samples, so that
the next time samples are re-enqueued, the starting point for re-enqueueing is correct.
In sourceBufferPrivateDidReceiveSample(), do not add samples to the decode queue if they are before the
current media time.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::reenqueueMediaForTime):
- 1:50 PM Changeset in webkit [171999] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: All-caps CSS properties are not shown in Computed pane
https://bugs.webkit.org/show_bug.cgi?id=133700
Patch by Matt Baker <Matt Baker> on 2014-08-04
Reviewed by Timothy Hatcher.
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::styleWithProperties):
- 1:32 PM Changeset in webkit [171998] by
-
- 4 edits2 copies in branches/safari-600.1.4-branch
Merged r171882. <rdar://problem/17802531>
- 10:42 AM Changeset in webkit [171997] by
-
- 5 edits in trunk
AX: SelectText functionality always selects text after current selection even if closer selection is behind it
https://bugs.webkit.org/show_bug.cgi?id=135546
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Logic was incorrect for comparing ranges found before the current selection.
ASSERT was incorrect for allowed ranges. We need to allow ranges that are right at the boundaries of our found ranges.
Extended existing test: platform/mac/accessibility/select-text.html
- accessibility/AccessibilityObject.cpp:
(WebCore::rangeClosestToRange):
LayoutTests:
- platform/mac/accessibility/select-text-expected.txt:
- platform/mac/accessibility/select-text.html:
- 10:32 AM Changeset in webkit [171996] by
-
- 5 edits2 adds in trunk
AX: AXSelectTextWithCriteriaParameterizedAttribute incorrectly selects the beginning letters of a word
https://bugs.webkit.org/show_bug.cgi?id=135547
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Allow text search to specify that it wants to match end of words as well as start of words.
This allows select text criteria to match on whole words only.
Test: platform/mac/accessibility/select-text-should-match-whole-words.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection):
- editing/FindOptions.h:
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::isWordEndMatch):
(WebCore::SearchBuffer::search):
LayoutTests:
- platform/mac/accessibility/select-text-should-match-whole-words-expected.txt: Added.
- platform/mac/accessibility/select-text-should-match-whole-words.html: Added.
- 10:26 AM Changeset in webkit [171995] by
-
- 3 edits in trunk/Source/WebCore
[MSE] Re-enqueing due to overlapping appended samples can cause stuttering playback
https://bugs.webkit.org/show_bug.cgi?id=135424
Reviewed by Eric Carlson.
If it become necessary to re-enqueue samples (due to appending overlapping samples which cause
existing samples to be removed), the previous behavior was to flush and re-enqueue the new
samples dependencies; i.e., everything up to and including the previous sync sample. This causes
the decoder to visibly stall while it decodes those non-displaying samples, which could be
a second or more worth of encoded video samples, depending on the frequency of sync samples.
Instead, when we are asked to re-enqueue, we will look for the next occurring sync sample.
If found, we can switch over to the replacement samples at that point in the decode queue.
This limits the overhead of a stream switch, and should allow for a visually seamless switch,
at the cost of having to wait for the next sync sample to occur to affect the switch.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::seekToTime): Clear the decode queue when seeking.
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Call reenqueueMediaForCurrentTime.
(WebCore::SourceBuffer::reenqueueMediaForCurrentTime): Switch over to the new stream only
at the next sync sample.
- 10:23 AM Changeset in webkit [171994] by
-
- 3 edits2 adds in trunk
AX: The Dictation command "Replace <phrase> with <phrase>" always capitalizes the replacement string
https://bugs.webkit.org/show_bug.cgi?id=135557
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When replacing text, we should match the capitalization of the word being replaced
(unless the replacement looks like an abbreviation).
Test: platform/mac/accessibility/find-and-replace-match-capitalization.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectText):
LayoutTests:
- platform/mac/accessibility/find-and-replace-match-capitalization-expected.txt: Added.
- platform/mac/accessibility/find-and-replace-match-capitalization.html: Added.
- 10:19 AM Changeset in webkit [171993] by
-
- 5 edits in trunk/Source/WebCore
QuickLook resources are cache-replaced with their original binary data causing ASSERT(m_data->size() == newBuffer->size()) in CachedResource.cpp
https://bugs.webkit.org/show_bug.cgi?id=135548
<rdar://problem/17891321>
Reviewed by David Kilzer.
When loading QuickLook resources, the SharedBuffer in the CachedResource is actually a
converted representation of the real QuickLook resource. Replacing this with the actual
network resource (which is what tryReplaceEncodedData() tried to do) is wrong and triggered
asserts in the code.
Fix this by having CachedRawResource::mayTryReplaceEncodedData() return false if we are
loading a QuickLook resource.
No new tests because we don't have a way to test QuickLook documents.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::didCreateQuickLookHandle):
Set a flag to indicate that we are loading a QuickLook document.
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::isQuickLookResource):
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::CachedRawResource):
(WebCore::CachedRawResource::finishLoading):
Check if we were loading a QuickLook document and if so disable encoded data
replacement.
- loader/cache/CachedRawResource.h:
Add a new bool field returned by mayTryReplaceEncodedData(). Default is true but it is
set to false in finishLoading() if we were loading QuickLook document.
- 10:17 AM Changeset in webkit [171992] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Seeking occasionally causes many frames to be displayed in "fast forward" mode
https://bugs.webkit.org/show_bug.cgi?id=135422
Reviewed by Eric Carlson.
When a seek is pending, but samples for the new time is not yet present in the SourceBuffer,
the SourceBufferPrivate may signal that it's ready for new samples through the
sourceBufferPrivateDidBecomeReadyForMoreSamples() method. In this situation, we should not
continue to provideMediaData(), as that will append samples from the prior-to-seeking media
timeline. Since the timeline may have moved forward due to the seek, a decoder may decide to
display those frames as quickly as possible (the "fast forward" behavior) in order to catch
up to the new current time.
If a re-enqueue is pending, don't provide media data in response to being notified that the
SourceBufferPrivate is ready for more samples. Wait until samples for the new current time
are appended.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidBecomeReadyForMoreSamples):
- dom/Document.cpp:
(WebCore::Document::unregisterCollection):
- 8:08 AM Changeset in webkit [171991] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Install all unstable webkitdom headers
https://bugs.webkit.org/show_bug.cgi?id=135544
Reviewed by Gustavo Noronha Silva.
We were checking whether generated file existed before they had
been generated.
- PlatformGTK.cmake: Add Unstable.h header for all stable classes
to GObjectDOMBindingsUnstable_INSTALLED_HEADERS and split the
install command for stable and unstable headers making unstable
headers optional.
- 6:31 AM Changeset in webkit [171990] by
-
- 6 edits6 adds in trunk/LayoutTests
Unreviewed EFL gardening
- platform/efl/TestExpectations: Add or update test expectations for failing tests.
- platform/efl/fast/text/international/cjk-segmentation-expected.txt: Added.
- platform/efl/js/dom/global-constructors-attributes-expected.txt: Rebaseline after r167632.
- platform/efl/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
- platform/efl/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.
- platform/efl/svg/text/non-bmp-positioning-lists-expected.png: Rebaseline after r168350 and r168543.
- platform/efl/svg/text/non-bmp-positioning-lists-expected.txt: Ditto.
- platform/efl/transforms/2d/hindi-rotated-expected.txt: Fix baseline.
- 1:47 AM Changeset in webkit [171989] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error in OpenTypeMathData.cpp.
https://bugs.webkit.org/show_bug.cgi?id=135541
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-08-04
Reviewed by Brent Fulgham.
The SharedBuffer class needs to be defined.
Also, the OpenTypeMathData constructor should be implemented when OPENTYPE_MATH is not enabled.
- platform/graphics/opentype/OpenTypeMathData.cpp:
- 12:17 AM Changeset in webkit [171988] by
-
- 2 edits in trunk
[GTK] Windowing target support should reflect the support in the GTK+ dependency
https://bugs.webkit.org/show_bug.cgi?id=134736
Reviewed by Martin Robinson.
- Source/cmake/FindGTK3.cmake: Don't error out if the GTK+ dependency doesn't
support the X11 or Wayland windowing targets -- instead, if there's no support
the specific target is disabled, and an error is thrown only if neither of the
backends is enabled at the end..
For now the X11 target remains enabled by default, and the Wayland target is
kept disabled. Once it's possible to have both targets enabled at runtime in
WebKit, the Wayland target will be enabled as well and we'll leave it to the
GTK+ dependency to determine which targets can be enabled.
- 12:10 AM Changeset in webkit [171987] by
-
- 1 edit1 add in trunk
[CMake] Add FindWayland.cmake
https://bugs.webkit.org/show_bug.cgi?id=135540
Reviewed by Martin Robinson.
- Source/cmake/FindWayland.cmake: Added. Enables finding the Wayland
dependency. For now bundles the wayland-client, wayland-server and
wayland-egl pkg-config targets into one dependency, but these could
be split in the future if necessary.
- 12:00 AM Changeset in webkit [171986] by
-
- 2 edits in trunk/Tools
[GTK] Do not include JavaScriptCore stress tests in release tarballs
https://bugs.webkit.org/show_bug.cgi?id=135503
Reviewed by Martin Robinson.
- gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
Aug 3, 2014:
- 7:12 PM Changeset in webkit [171985] by
-
- 2 edits in trunk
[EFL] Move DATA_INSTALL_DIR to ewebkit2-0
https://bugs.webkit.org/show_bug.cgi?id=135553
Reviewed by Gyuyoung Kim.
Since WebKit1/Efl is dropped, we don't need to use ewebkit-1 and ewebkit2-1.
And removed WebKit_OUTPUT_NAME variable which is not used anymore on the EFL port.
- Source/cmake/OptionsEfl.cmake:
- 12:21 PM Changeset in webkit [171984] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/17782529> REGRESSION: OS marketing version in iOS Simulator user-agent string is the host OS’s
https://bugs.webkit.org/show_bug.cgi?id=135549
Reviewed by Mark Rowe.
- platform/cocoa/SystemVersion.mm:
(WebCore::createSystemMarketingVersion): On the iOS Simulator, locate the system Library
directory relative to the Simulator root.
- 1:16 AM Changeset in webkit [171983] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 1:12 AM Changeset in webkit [171982] by
-
- 1 copy in tags/Safari-600.1.4.4
New tag.
- 1:03 AM Changeset in webkit [171981] by
-
- 2 edits1 add in branches/safari-600.1.4-branch/Source/JavaScriptCore
Merged patch for <rdar://problem/17887398>.
- 12:56 AM Changeset in webkit [171980] by
-
- 12 edits in branches/safari-600.1.4-branch/Source
Merged r171973. <rdar://problem/17834694>
- 12:45 AM Changeset in webkit [171979] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebKit2
Merged r171959. <rdar://problem/17671574>
- 12:43 AM Changeset in webkit [171978] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/JavaScriptCore
Merged r171949. <rdar://problem/17888408>
- 12:40 AM Changeset in webkit [171977] by
-
- 5 edits in branches/safari-600.1.4-branch/Source/JavaScriptCore
Merged r171946. <rdar://problem/17888408>
- 12:37 AM Changeset in webkit [171976] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merged r171944. <rdar://problem/17879156>
- 12:34 AM Changeset in webkit [171975] by
-
- 9 edits in branches/safari-600.1.4-branch/Source/WebKit2
Merged r171943. <rdar://problem/17869279>
- 12:28 AM Changeset in webkit [171974] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebKit2
Merged r171887. <rdar://problem/17864139>
Aug 2, 2014:
- 5:03 PM Changeset in webkit [171973] by
-
- 12 edits in trunk/Source
Support both window and view based video fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=135525
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-08-02
Reviewed by Simon Fraser.
Source/WebCore:
Presenting in a separate window gives greater flexibility for rotation separately from the app.
Presenting in the same window works better if the interface is rehosted in another process.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController enterFullscreen:]): Use clientRect instead of screenRect.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h: Add m_window and m_parentView.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVVideoLayer setBounds:]): Parent view might not be fullscreen; use window instead.
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): Conditionally create UIWindow and UIViewController for fullscreen.
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): Video, not the container should have black background.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Conditionally translate finalRect.
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreen): Clean up UIWindow and force status bar to correct orientation.
(WebVideoFullscreenInterfaceAVKit::invalidate): Clean up UIWindow.
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): Hide window and exit without animation.
- platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::setVideoFullscreenLayer): Apply frame, because it may have been set before the layer.
Source/WebKit/mac:
Parenting in the view instead of the window gives the fullscreen implementation more latitude
in how it implements the animation.
- WebView/WebView.mm:
(-[WebView _enterFullscreenForNode:]): Use view instead of window.
Source/WebKit2:
Parenting in the view instead of the window gives the fullscreen implementation more latitude
in how it implements the animation.
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): Use view instead of window.
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::clientRectForNode): Use client rect instead of screen rect.
(WebKit::WebVideoFullscreenManager::enterFullscreenForNode): ditto
(WebKit::WebVideoFullscreenManager::exitFullscreenForNode): ditto
(WebKit::screenRectForNode): Deleted.
- 1:51 PM Changeset in webkit [171972] by
-
- 8 edits in trunk/Source/WebCore
Update the SearchFieldResultsButtonElement shadow Pseudo Id when HTMLInputElement's maxResults change
https://bugs.webkit.org/show_bug.cgi?id=135491
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-02
Reviewed by Ryosuke Niwa.
Replace the shadowPseudoId() override + manual style invalidation by the generic pseudo ID update.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- html/InputType.cpp:
(WebCore::InputType::maxResultsAttributeChanged):
- html/InputType.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
(WebCore::updateResultButtonPseudoType):
(WebCore::SearchInputType::maxResultsAttributeChanged):
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::destroyShadowSubtree):
- html/SearchInputType.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::shadowPseudoId): Deleted.
- html/shadow/TextControlInnerElements.h:
- 1:47 PM Changeset in webkit [171971] by
-
- 3 edits in trunk/Source/WebCore
Add warnings for the buggy implementations of shadowPseudoId()
https://bugs.webkit.org/show_bug.cgi?id=135477
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-02
Reviewed by Ryosuke Niwa.
Dean is going to look into fixing media element styling.
In the meantime, add warnings to prevent this from spreading.
- dom/Element.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):
- 11:35 AM Changeset in webkit [171970] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
[Win] Unreviewed build fix.
- src/libGLESv2/renderer/d3d11/BufferStorage11.cpp:
(rx::BufferStorage11::copyData): Help compiler make
decision about types.
- 11:04 AM Changeset in webkit [171969] by
-
- 5 edits in trunk/Tools
build-webkittestrunner doesn't build the app target for iOS SDKs
https://bugs.webkit.org/show_bug.cgi?id=135433
Reviewed by Dan Bernstein.
- Scripts/build-dumprendertree: Build the app target on iOS.
- Scripts/build-webkittestrunner: Build the app target on iOS.
- Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
(buildXCodeProject):
- Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
(IOSSimulatorPort._build_driver_flags):
- 11:03 AM Changeset in webkit [171968] by
-
- 2 edits1 delete in trunk/Tools
Remove iOS Perl DumpRenderTree support target
https://bugs.webkit.org/show_bug.cgi?id=135271
Reviewed by Dan Bernstein.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
- DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
- DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
- DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
- DumpRenderTree/ios/PerlSupport/Makefile: Removed.
- 11:01 AM Changeset in webkit [171967] by
-
- 1 edit1 delete in trunk/Tools
Remove old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=135374
Reviewed by Csaba Osztrogonác.
- Scripts/old-run-webkit-tests: Removed.
- 10:34 AM Changeset in webkit [171966] by
-
- 2 edits in trunk/Tools
prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
https://bugs.webkit.org/show_bug.cgi?id=135542
Reviewed by Tim Horton.
- Scripts/prepare-ChangeLog:
(main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
findChangeLogs.
(findChangeLogs): Don’t require a ChangeLog file to exist if unless the
requireChangeLogToExist argument is true.
Aug 1, 2014:
- 11:06 PM Changeset in webkit [171965] by
-
- 4 edits in trunk/Source
<rdar://problem/17891752> [iOS] WebKit links against libraries it doesn’t use
https://bugs.webkit.org/show_bug.cgi?id=135536
Reviewed by Tim Horton.
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from
OTHER_LDFLAGS_iphoneos.
Source/WebKit2:
- Configurations/WebKit.xcconfig: Removed -lassertion_extension and -framework MobileAsset
from FRAMEWORK_AND_LIBRARY_LDFLAGS_iphonesimulator.
- 10:10 PM Changeset in webkit [171964] by
-
- 20 edits in trunk/Source/WebCore
Unreviewed, rolling out r171957.
https://bugs.webkit.org/show_bug.cgi?id=135538
Caused GTK assertions and test failures (Requested by smfr on
#webkit).
Reverted changeset:
"Clean up image subsampling code, make it less iOS-specific"
https://bugs.webkit.org/show_bug.cgi?id=134916
http://trac.webkit.org/changeset/171957
- 9:13 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:00 PM Changeset in webkit [171963] by
-
- 3 edits2 adds in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Report and mark new failures and flaky tests after 171341, r171591, r171567 and others.
- platform/gtk/fast/css/viewport-units-dynamic-expected.txt: Added. Rebaseline after r171567.
- platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt: Added. Rebaseline after r171609.
- platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt: Rebaseline after 171341.
- 5:46 PM Changeset in webkit [171962] by
-
- 2 edits in trunk/Source
[CMake] Allow CMake to find GLib on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=132530
Patch by Myles C. Maxfield <litherum@gmail.com> on 2014-08-01
Reviewed by Gustavo Noronha Silva.
On FreeBSD, glibconfig.h is at /usr/local/include/glib-2.0/glibconfig.h.
- Source/cmake/FindGLIB.cmake:
- 5:10 PM Changeset in webkit [171961] by
-
- 4 edits in trunk/Source
REGRESSION(r171942): [CMAKE] [GTK] build broken (clean build).
https://bugs.webkit.org/show_bug.cgi?id=135522
Reviewed by Martin Robinson.
Source/JavaScriptCore:
- CMakeLists.txt: Output the inspector headers inside inspector
subdirectory.
Source/WebCore:
No new tests required, no new functionality.
- CMakeLists.txt: Add missing include to the inspector headers
and fix the path to InspectorJSTypeBuilders.h
- 5:00 PM Changeset in webkit [171960] by
-
- 2 edits in trunk/Source/WebCore
Fix resource leak in FillLayersPropertyWrapper object member
https://bugs.webkit.org/show_bug.cgi?id=135462
Reviewed by Andreas Kling.
Fix leak of m_fillLayerPropertyWrapper by using unique_ptr<>.
Based on patch by Przemyslaw Kuczynski.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
- 4:57 PM Changeset in webkit [171959] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Add extension read permission to network sandbox profile
<rdar://problem/17671574>
Reviewed by Alexey Proskuryakov and Oliver Hunt.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- 4:55 PM Changeset in webkit [171958] by
-
- 2 edits in trunk/LayoutTests
Unreviewed post-review test fixup
- editing/pasteboard/img-srcset-copy-paste-canonicalization.html:
- 4:22 PM Changeset in webkit [171957] by
-
- 20 edits in trunk/Source/WebCore
Clean up image subsampling code, make it less iOS-specific
https://bugs.webkit.org/show_bug.cgi?id=134916
Reviewed by Dean Jackson.
Compile the image subsampling code on both Mac and iOS, and make it more platform
neutral in general. Add a setting to allow it to be enabled on Mac for testing.
The most significant changes are in ImageSourceCG and BitmapImageCG. CG's ImageSource
is no longer stateful with respect to subsampling; its functions take a SubsamplingLevel
when appropriate. CG's BitmapImage now determines which level of subsampling to use
for a given frame, storing the subsampling level in the frame data. It can replace
an aggressively subsampled frame with a less subsampled frame if necessary.
To reduce the chances of subsampling affecting rendering, BitmapImage::size() now
always returns the non-subsampled size; subsampling is strictly internal to BitmapImage.
BitmapImage::draw() takes care of scaling the srcRect for subsampled images.
iOS had a code path that enabled caching of frame metadata in BitmapImage without
actually decoding the frame; make this cross-platform.
- WebCore.exp.in: Changed signature for GraphicsContext::drawNativeImage().
- WebCore.xcodeproj/project.pbxproj: Added ImageSource.cpp, which is not built
for Cocoa but useful for reference.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer): Remove iOS-specific subsampling code.
(WebCore::CachedImage::createImage): Call setAllowSubsampling() on the image if we
can get to Settings (m_loader is null for image documents).
(WebCore::CachedImage::currentFrameKnownToBeOpaque): This forced decode always
caused creation of the non-subsampled image, so remove it. There's no reason to
eagerly decode the frame here.
- loader/cache/CachedImage.h: Fix comment.
- page/Settings.cpp: Add defaultImageSubsamplingEnabled, true for iOS and false for Mac.
- page/Settings.in: Added imageSubsamplingEnabled.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Init some more things. Default m_allowSubsampling to
true for iOS to catch images created in code paths where we can't get to Settings.
(WebCore::BitmapImage::haveFrameAtIndex): Handy helper.
(WebCore::BitmapImage::cacheFrame): Now takes the subsampling level and whether to cache
just metadata, or also the frame.
(WebCore::BitmapImage::didDecodeProperties): No need to store originalSize.
(WebCore::BitmapImage::updateSize): When we get the size for the first time, call
determineMinimumSubsamplingLevel() to choose a reasonable subsampling level which takes
platform-specific limits into account.
(WebCore::BitmapImage::dataChanged): Comment.
(WebCore::BitmapImage::ensureFrameIsCached): Take ImageFrameCaching into account.
(WebCore::BitmapImage::frameAtIndex): Choose a subsampling level given the scale,
then determine if we can use the currently cached frame, or whether we should resample.
(WebCore::BitmapImage::frameIsCompleteAtIndex): Caching m_isComplete is now done when caching
frame metadata.
(WebCore::BitmapImage::frameDurationAtIndex):
(WebCore::BitmapImage::frameHasAlphaAtIndex): The 'true' return is the safe return value.
(WebCore::BitmapImage::frameOrientationAtIndex): Caching m_orientation is now done when caching
frame metadata.
(WebCore::BitmapImage::cacheFrameInfo): Deleted.
(WebCore::BitmapImage::originalSize): Deleted.
(WebCore::BitmapImage::originalSizeRespectingOrientation): Deleted.
(WebCore::BitmapImage::currentFrameSize): Deleted.
(WebCore::BitmapImage::ensureFrameInfoIsCached): Deleted.
- platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
- platform/graphics/GraphicsContext.h: No need to pass a scale param now.
- platform/graphics/ImageSource.cpp: Non-Cocoa changes.
(WebCore::ImageSource::subsamplingLevelForScale):
(WebCore::ImageSource::allowSubsamplingOfFrameAtIndex):
(WebCore::ImageSource::size):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameBytesAtIndex):
- platform/graphics/ImageSource.h: No longer stores subsampling state.
(WebCore::ImageSource::isSubsampled): Deleted.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::determineMinimumSubsamplingLevel):
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage): Init more members.
(WebCore::BitmapImage::determineMinimumSubsamplingLevel): Choose a minimum subsampling
level for the platform (subsample until the image area falls under a threshold).
(WebCore::BitmapImage::checkForSolidColor): Don't bother decoding frames if the image
is not 1x1. Also take care not to decode a non-subsampled image.
(WebCore::BitmapImage::draw): The actual bug fix is here; remove logic that
computed srcRectForCurrentFrame from m_size and m_originalSize; for some callers
srcRect was computed using the pre-subsampled size, and for others it was the subsampled size.
Instead, scale srcRect by mapping between the non-subsampled size, and the size of the CGImageRef
which is affected by subsampling.
(WebCore::BitmapImage::copyUnscaledFrameAtIndex):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage): Remove #ifdeffed code.
(WebCore::GraphicsContext3D::paintToCanvas):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage): No more weird scaling!
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::draw):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::ImageSource):
(WebCore::createImageSourceOptions): Helper that always returns a new CFDictionaryRef.
(WebCore::imageSourceOptions): If not subsampling, return the cached CFDictionaryRef, otherwise
make a new options dict and return it.
(WebCore::ImageSource::subsamplingLevelForScale): Helper that returns a subsampling level
between 0 and 3 given a scale.
(WebCore::ImageSource::isSizeAvailable): SkipMetadata is a default value for the param now.
(WebCore::ImageSource::allowSubsamplingOfFrameAtIndex): We turn off subsampling for progressive
JPEGs because of a bug, so need this to know if a frame should be subsampled.
(WebCore::ImageSource::frameSizeAtIndex): The looping to find a subsampling level is now in BitmapImageCG.
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::size): Always use a subsampling level of 0 for size().
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex): The caller mapped a scale to a level.
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameBytesAtIndex):
(WebCore::ImageSource::imageSourceOptions): Deleted.
(WebCore::ImageSource::originalSize): Deleted.
- platform/graphics/mac/ImageMac.mm:
(WebCore::BitmapImage::invalidatePlatformData): 0 -> nullptr
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::determineMinimumSubsamplingLevel):
- 4:20 PM Changeset in webkit [171956] by
-
- 7 edits in trunk/Source/WebCore
Many DOM objects have InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero for no reason.
<https://webkit.org/b/135519>
Don't set this structure flag unless the object actually has an override
for getOwnPropertySlotByIndex().
Reviewed by Geoffrey Garen.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- 4:14 PM Changeset in webkit [171955] by
-
- 3 edits in trunk/Source/WebCore
SVG Font kerning can take an early out if the font has no kerning information
https://bugs.webkit.org/show_bug.cgi?id=135524
Reviewed by Dean Jackson.
Rather than calling SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs() again
and again, skip the iteration entirely if every call would return 0.
No new tests because there is no behavior change.
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::applySVGKerning):
- svg/SVGFontElement.h:
- 4:10 PM Changeset in webkit [171954] by
-
- 3 edits in trunk/Tools
commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
https://bugs.webkit.org/show_bug.cgi?id=135527
Reviewed by Tim Horton.
- Scripts/commit-log-editor:
In the case of a git repository when there are no changed ChangeLog files, changed to pass
the --delimiters option to prepare-ChangeLog, then process each entry in the output using
commitMessageFromChangeLogEntry.
(commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
(sortKey): Factored out from createCommitMessage.
(createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
subroutines.
- Scripts/prepare-ChangeLog:
(main): Parse new --delimiters option.
(generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
the label before each change log entry, and a "~" delimiter on a new line after each entry.
- 3:49 PM Changeset in webkit [171953] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add some structure related assertions.
<https://webkit.org/b/135523>
Reviewed by Geoffrey Garen.
Adding 2 assertions:
- assert that we don't index pass the end of the StructureIDTable. This should never happen, but this assertion will help catch bugs where a bad structureID gets passed in.
- assert that cells in MarkedBlock::callDestructor() that are not zapped should have a non-null StructureID. This will help us catch bugs where the other cell header flag bits get set after the cell is zapped, thereby making the cell look like an unzapped cell but has a null structureID.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor):
- runtime/StructureIDTable.h:
(JSC::StructureIDTable::get):
- 3:47 PM Changeset in webkit [171952] by
-
- 2 edits in trunk/Source/WebCore
Inspector highlights clipped at the bottom on the page in WK1 views with
contentInsets
https://bugs.webkit.org/show_bug.cgi?id=135480
-and corresponding-
<rdar://problem/17850323>
Forgot to commit this one very critical part with
http://trac.webkit.org/changeset/171951
- platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSizeIncludingObscuredArea):
- 3:39 PM Changeset in webkit [171951] by
-
- 7 edits in trunk/Source/WebCore
Inspector highlights clipped at the bottom on the page in WK1 views with
contentInsets
https://bugs.webkit.org/show_bug.cgi?id=135480
-and corresponding-
<rdar://problem/17850323>
Reviewed by Simon Fraser.
unscaledTotalVisibleContentSize() was the main function on Mac that was expected
to return the rect representing ALL visible content, including content that might
be in an inset area and obscured by UI elements. This patch re-names that function
to unscaledVisibleContentSizeIncludingObscuredArea(), and that patch makes that
function return the right thing in the platformWidget() case.
Re-name.
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
Return platformVisibleContentSizeIncludingObscuredArea() for the platformWidget()
case and re-name.
- platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSizeIncludingObscuredArea):
This was just wrong. It was returning the big rectangle instead of the small one
for platformWidget().
(WebCore::ScrollView::unscaledUnobscuredVisibleContentSize):
New platform functions.
(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea):
(WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea):
(WebCore::ScrollView::unscaledTotalVisibleContentSize): Deleted.
- platform/ScrollView.h:
- platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea):
(WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea):
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformVisibleContentRect):
(WebCore::ScrollView::platformVisibleContentSize):
(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea):
(WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea):
Re-name.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::ensureRootLayer):
- 3:33 PM Changeset in webkit [171950] by
-
- 2 edits in trunk/Source/WebCore
SVGGlyph wastes space due to padding
https://bugs.webkit.org/show_bug.cgi?id=135520
Reviewed by Dean Jackson.
Rearrange members in SVGGlyph so there is no wasted padding space.
No new tests because there is no behavior change.
- platform/graphics/SVGGlyph.h:
(WebCore::SVGGlyph::SVGGlyph):
- 1:58 PM Changeset in webkit [171949] by
-
- 2 edits in trunk/Source/JavaScriptCore
URTBF after r171946 to fix non-Apple builds.
- bytecode/InlineCallFrameSet.cpp:
- 1:46 PM Changeset in webkit [171948] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r171891): platform/mac/fast/scrolling/scroll-select-bottom-test.html
failing
https://bugs.webkit.org/show_bug.cgi?id=135485
Now that WK1 really tests contentInset, this test no longer works on platforms
that do not support the real contentInset
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 1:43 PM Changeset in webkit [171947] by
-
- 8 edits in trunk
[Feature Queries] Enable Feature Queries on EFL/GTK
https://bugs.webkit.org/show_bug.cgi?id=134902
Reviewed by Benjamin Poulain.
.:
Enable CSS Feature Queries by default on the EFL and GTK
platforms.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
Tools:
Turn the feature on by default for the build script.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Resume running the CSS Feature Query tests on the EFL and GTK platforms.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 1:17 PM Changeset in webkit [171946] by
-
- 5 edits in trunk/Source/JavaScriptCore
CodeBlock fails to visit the Executables of its InlineCallFrames
https://bugs.webkit.org/show_bug.cgi?id=135471
Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2014-08-01
Reviewed by Geoffrey Garen.
CodeBlock needs to visit its InlineCallFrames' owner Executables. If it doesn't, they
can be prematurely collected and cause crashes.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
- bytecode/CodeOrigin.h:
(JSC::InlineCallFrame::visitAggregate):
- bytecode/InlineCallFrameSet.cpp:
(JSC::InlineCallFrameSet::visitAggregate):
- bytecode/InlineCallFrameSet.h:
- 1:01 PM Changeset in webkit [171945] by
-
- 3 edits in trunk/Tools
Build fix for 32-bit after r171926.
- MiniBrowser/mac/SettingsController.h:
- MiniBrowser/mac/SettingsController.m:
- 12:42 PM Changeset in webkit [171944] by
-
- 2 edits in trunk/Source/WebCore
[Media iOS] Ensure there is a nice default fallback for missing wireless target names
https://bugs.webkit.org/show_bug.cgi?id=135488
<rdar://problem/17879156>
Reviewed by Eric Carlson.
We occasionally run into cases where this.host.externalDeviceDisplayName
is empty or null, creating a pretty ugly/confusing string in the
wireless playback status screen.
If this happens, we should default to using "Apple TV".
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.updateWirelessPlaybackStatus): Check if the externalDeviceDisplayName
is empty or null, and fall back to "Apple TV" if so.
- 12:19 PM Changeset in webkit [171943] by
-
- 9 edits in trunk/Source/WebKit2
Various frameworks may want to use the container temp directory, so our current restrictions are too tight
https://bugs.webkit.org/show_bug.cgi?id=135518
<rdar://17869279>
Reviewed by Anders Carlsson.
We don't (and can't) have complete knowledge of what different frameworks
will want to use the container temporary directory for, and so our
current attempt to heavily restrict access is simply too tight.
This patch recognises this by simply giving read-write access to the
entire NSTemporary() directory (e.g. $container/tmp in the general case),
rather than the single sub directory we wishfully thought that we would
be able to get away with.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::mediaCacheDirectory): Deleted.
- UIProcess/WebContext.h:
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::containerTemporaryDirectory):
(WebKit::WebContext::platformMediaCacheDirectory): Deleted.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::containerTemporaryDirectory):
(WebKit::WebContext::platformMediaCacheDirectory): Deleted.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::containerTemporaryDirectory):
(WebKit::WebContext::platformMediaCacheDirectory): Deleted.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 12:19 PM Changeset in webkit [171942] by
-
- 11 edits2 adds in trunk
Progress towards cmake on Windows.
https://bugs.webkit.org/show_bug.cgi?id=135484
Reviewed by Martin Robinson.
.:
- CMakeLists.txt:
Added Mac to list of ports, even though it is not done yet.
Changed minimum bison version to version installed on Macs.
- Source/cmake/OptionsAppleWin.cmake:
Added some definitions.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
Set WTF_LIBRARY_TYPE to STATIC to not change WTF linking on EFL or GTK ports.
- Source/cmake/OptionsMac.cmake: Added blank for now.
- Source/cmake/OptionsWinCairo.cmake:
- Source/cmake/OptionsWindows.cmake:
Added some definitions.
Removed /WX (warnings treated as error while compiling).
Copied warnings to ignore from WebKitLibraries/win/tools/vsprops/common.props.
Source/JavaScriptCore:
- CMakeLists.txt:
Generate code directly to inspector directory to avoid using the cp command
which is not available on Windows.
- PlatformWin.cmake: Added.
Source/WTF:
- wtf/CMakeLists.txt:
Added WTF_LIBRARY_TYPE because Windows needs WTF to be a shared library.
- 12:08 PM Changeset in webkit [171941] by
-
- 9 edits3 adds in trunk
URLs in srcset attributes are not made absolute upon copy and paste
https://bugs.webkit.org/show_bug.cgi?id=135448
Reviewed by Ryosuke Niwa.
Source/WebCore:
When pasting, canonicalize URLs in srcset the same way we do with src.
Test: editing/pasteboard/img-srcset-copy-paste-canonicalization.html
- dom/Element.cpp:
(WebCore::Element::completeURLsInAttributeValue): Initial implemention, moved from markup.cpp.
- dom/Element.h:
(WebCore::Element::attributeContainsURL): New function for completeURLs to call.
(WebCore::Element::completeURLsInAttributeValue): Only called if attributeContainsURL returns
true. Default implementation simply calls isURLAttribute().
- editing/markup.cpp:
(WebCore::completeURLs): Call attributeContainsURL() and completeURLsInAttributeValue() to
complete the URL, so nodes can perform their own behavior.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::attributeContainsURL): Return true for srcset.
(WebCore::HTMLImageElement::completeUrlAttributeValue): Use our existing srcset parser to
parse the srcset attribute, then use its output to canonicalize URLs, and build it back up
into a string.
- html/HTMLImageElement.h:
(WebCore::HTMLImageElement::attributeContainsURL):
(WebCore::HTMLImageElement::completeUrlAttributeValue):
- html/parser/HTMLSrcsetParser.cpp: Make parseImageCandidatesFromSrcsetAttribute() public
and change its signature to return its result.
(WebCore::parseImageCandidatesFromSrcsetAttribute):
- html/parser/HTMLSrcsetParser.h: Ditto.
LayoutTests:
Copy and paste a srcset image with relative URLs, and make sure that the
pasted srcset attribute doesn't match what it was before. I can't actually
dump the new srcset because it will include a full path of the file on the
user's system, and would therefore be machine-specific.
- editing/pasteboard/img-srcset-copy-paste-canonicalization-expected.txt:
- editing/pasteboard/img-srcset-copy-paste-canonicalization.html: Paste and check.
- editing/pasteboard/resources/img-srcset-copy-paste-canonicalization-iframe.html:
This has to be an iframe because we don't perform any url canonicalization if we
are copying and pasting from a document into itself.
- 12:06 PM Changeset in webkit [171940] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Timeline header height doesn't match style updates.
https://bugs.webkit.org/show_bug.cgi?id=135516
Reviewed by Timothy Hatcher.
Update the timeline header height to match the updates
to the navigation bars in other panels made in
https://bugs.webkit.org/show_bug.cgi?id=135445. Also
update the shadows on some of the search bars.
- UserInterface/Views/FilterBar.css:
(.filter-bar > input[type="search"]):
(body.mac-platform.legacy .filter-bar > input[type="search"]):
- UserInterface/Views/FindBanner.css:
(.find-banner > input[type="search"]):
(body.mac-platform.legacy .find-banner > input[type="search"]):
- UserInterface/Views/LogContentView.css:
(.search-bar.log-search-bar > input[type="search"]):
(body.mac-platform.legacy .search-bar.log-search-bar > input[type="search"]):
Remove inset shadows on search bars.
- UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .status-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-status):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-status):
(.sidebar > .panel.navigation.timeline > .title-bar.timelines):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timelines):
(.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(.sidebar > .panel.navigation.timeline > .timelines-content):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content):
(.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder):
Update the height of the timeline status bar.
- 11:57 AM Changeset in webkit [171939] by
-
- 87 edits in trunk/Source
Remove the JSC::OverridesVisitChildren flag.
<https://webkit.org/b/135489>
Source/JavaScriptCore:
Except for 3 special classes, the visitChildren() call is always
dispatched through the method table (see SlotVisitor.cpp.)
The OverridesVisitChildren flag doesn't actually do anything.
It could be used to implement a non-virtual direct call to
JSCell::visitChildren, bypassing the method table for some objects,
but such a micro-optimization seems like a weak trade for all this
code complexity. Instead, just remove the flag.
This change frees up an inline flag bit in JSCell.
Reviewed by Geoffrey Garen.
- API/JSAPIWrapperObject.h:
- API/JSAPIWrapperObject.mm:
(JSC::JSAPIWrapperObject::visitChildren):
- API/JSCallbackObject.h:
(JSC::JSCallbackObject::visitChildren):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::visitChildren):
(JSC::UnlinkedCodeBlock::visitChildren):
(JSC::UnlinkedProgramCodeBlock::visitChildren):
- bytecode/UnlinkedCodeBlock.h:
- debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::visitChildren):
- debugger/DebuggerScope.h:
- jsc.cpp:
- runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
- runtime/Arguments.h:
- runtime/Executable.cpp:
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
- runtime/Executable.h:
- runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
- runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
- runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
- runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
- runtime/JSActivation.h:
- runtime/JSArrayIterator.cpp:
(JSC::JSArrayIterator::visitChildren):
- runtime/JSArrayIterator.h:
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::visitChildren):
- runtime/JSBoundFunction.h:
- runtime/JSCellInlines.h:
(JSC::JSCell::setStructure):
- runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildren):
- runtime/JSFunction.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
- runtime/JSMap.h:
- runtime/JSMapIterator.cpp:
(JSC::JSMapIterator::visitChildren):
- runtime/JSMapIterator.h:
- runtime/JSNameScope.cpp:
(JSC::JSNameScope::visitChildren):
- runtime/JSNameScope.h:
- runtime/JSPromise.cpp:
(JSC::JSPromise::visitChildren):
- runtime/JSPromise.h:
- runtime/JSPromiseDeferred.cpp:
(JSC::JSPromiseDeferred::visitChildren):
- runtime/JSPromiseDeferred.h:
- runtime/JSPromiseReaction.cpp:
(JSC::JSPromiseReaction::visitChildren):
- runtime/JSPromiseReaction.h:
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
- runtime/JSPropertyNameIterator.h:
- runtime/JSProxy.cpp:
(JSC::JSProxy::visitChildren):
- runtime/JSProxy.h:
- runtime/JSScope.cpp:
(JSC::JSScope::visitChildren):
- runtime/JSScope.h:
- runtime/JSSegmentedVariableObject.cpp:
(JSC::JSSegmentedVariableObject::visitChildren):
- runtime/JSSegmentedVariableObject.h:
- runtime/JSSet.h:
- runtime/JSSetIterator.cpp:
(JSC::JSSetIterator::visitChildren):
- runtime/JSSetIterator.h:
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::visitChildren):
- runtime/JSSymbolTableObject.h:
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::overridesVisitChildren): Deleted.
- runtime/JSWeakMap.h:
- runtime/JSWithScope.cpp:
(JSC::JSWithScope::visitChildren):
- runtime/JSWithScope.h:
- runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
- runtime/JSWrapperObject.h:
- runtime/MapData.h:
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
- runtime/NativeErrorConstructor.h:
- runtime/PropertyMapHashTable.h:
- runtime/PropertyTable.cpp:
(JSC::PropertyTable::visitChildren):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::visitChildren):
- runtime/RegExpConstructor.h:
- runtime/RegExpMatchesArray.cpp:
(JSC::RegExpMatchesArray::visitChildren):
- runtime/RegExpMatchesArray.h:
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
- runtime/RegExpObject.h:
- runtime/SparseArrayValueMap.h:
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::visitChildren):
- runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):
- runtime/StructureChain.h:
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::visitChildren):
- runtime/StructureRareData.h:
- runtime/WeakMapData.h:
Source/WebCore:
Tweak the bindings code generator to stop spitting out the flag.
Reviewed by Geoffrey Garen.
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildren):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- 11:54 AM Changeset in webkit [171938] by
-
- 1 delete in tags/Safari-600.1.2.5/Safari-600.1.2.4
Remove extraneous tag.
- 11:53 AM Changeset in webkit [171937] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Volume is not remembered between items in a YouTube playlist
https://bugs.webkit.org/show_bug.cgi?id=135479
Reviewed by Eric Carlson.
When an AVSampleBufferAudioRenderer is added to the player, set its -volume and -muted
properties with the current values from the HTMLMediaElement.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
- 11:50 AM Changeset in webkit [171936] by
-
- 3 edits1 copy in tags/Safari-600.1.2.5
Merge r171903. <rdar://problem/17877481>
- 11:44 AM Changeset in webkit [171935] by
-
- 4 edits in trunk/Tools
Confusing build fix after r171926.
- MiniBrowser/mac/AppDelegate.h:
- MiniBrowser/mac/AppDelegate.m:
- MiniBrowser/mac/SettingsController.m:
- 11:33 AM Changeset in webkit [171934] by
-
- 2 edits in tags/Safari-600.1.4.3/Source/WebCore
Merge r171259. <rdar://problem/17718984>
- 11:32 AM Changeset in webkit [171933] by
-
- 2 edits in tags/Safari-600.1.4.3/Source/WebCore
Merge r171259. <rdar://problem/17718984>
- 11:30 AM Changeset in webkit [171932] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build after r171891
- platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):
- 11:29 AM Changeset in webkit [171931] by
-
- 15 edits in trunk/Source/WebCore
Remove EventNames.h include from header files
https://bugs.webkit.org/show_bug.cgi?id=135486
Reviewed by Alexey Proskuryakov.
No new tests because no functional changes.
- Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h:
- Modules/gamepad/GamepadEvent.h:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.h:
- Modules/mediastream/RTCStatsResponse.h:
- Modules/websockets/WebSocket.h:
- css/FontLoader.h:
- dom/SecurityPolicyViolationEvent.h:
- loader/appcache/DOMApplicationCache.h:
- workers/AbstractWorker.h:
- workers/Worker.h:
- workers/WorkerGlobalScope.h:
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestProgressEvent.h:
- 11:28 AM Changeset in webkit [171930] by
-
- 5 edits in tags/Safari-600.1.4.3/Source
Versioning.
- 11:26 AM Changeset in webkit [171929] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171259. <rdar://problem/17718984>
- 11:22 AM Changeset in webkit [171928] by
-
- 6 edits in trunk/Source/WebKit2
<rdar://problem/17862013> REGRESSION (r169357): Disabling "allow plug-ins" doesn't stick on quit/relaunch
https://bugs.webkit.org/show_bug.cgi?id=135511
Reviewed by Alexey Proskuryakov.
Since the values map in the preferences store doesn’t include values that are equal to the
defaults, we need to update it when a new default is registered.
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::createWithLegacyDefaults): Changed to use new member functions
for registering defaults.
(WebKit::WebPreferences::registerDefaultBoolValueForKey): Added. Sets an override default
in the store, and sets the user default, if there is one, on top of it.
(WebKit::WebPreferences::registerDefaultUInt32ValueForKey): Ditto.
- UIProcess/WebPreferences.h: Declared new member functions for getting the user default
value for a key.
- UIProcess/efl/WebPreferencesEfl.cpp:
(WebKit::WebPreferences::platformGetStringUserValueForKey): Added an implementation that
returns false, because the EFL port doesn’t support persistent user defaults.
(WebKit::WebPreferences::platformGetBoolUserValueForKey): Ditto.
(WebKit::WebPreferences::platformGetUInt32UserValueForKey): Ditto.
(WebKit::WebPreferences::platformGetDoubleUserValueForKey): Ditto.
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformGetStringUserValueForKey): Ditto for the GTK port.
(WebKit::WebPreferences::platformGetBoolUserValueForKey): Ditto.
(WebKit::WebPreferences::platformGetUInt32UserValueForKey): Ditto.
(WebKit::WebPreferences::platformGetDoubleUserValueForKey): Ditto.
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::WebPreferences::platformGetStringUserValueForKey): Added. Replaces
setStringValueIfInUserDefaults, on which it is based.
(WebKit::WebPreferences::platformGetBoolUserValueForKey): Similarly for booleans.
(WebKit::WebPreferences::platformGetUInt32UserValueForKey): Similarly for integers.
(WebKit::WebPreferences::platformGetDoubleUserValueForKey): Similarly for doubles.
(WebKit::WebPreferences::platformInitializeStore): Changed to use the above functions.
- 11:21 AM Changeset in webkit [171927] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171259. <rdar://problem/17718984>
- 11:21 AM Changeset in webkit [171926] by
-
- 8 edits2 adds in trunk/Tools
Make it easer to add switches to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=135499
Reviewed by Simon Fraser.
Add a single class to manage a set of persistent, global settings for MiniBrowser.
Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
Add SettingsController.{m, h}.
- MiniBrowser/mac/AppDelegate.h:
Move _browserWindowControllers to the implementation.
Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
of that; instead, we'll receive didChangeSettings.
- MiniBrowser/mac/AppDelegate.m:
Move the default URL, default URL preference key, and use-WebKit2-by-default
preference key into SettingsController.
(-[BrowserAppDelegate awakeFromNib]):
Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
(-[BrowserAppDelegate newWindow:]):
Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
(-[BrowserAppDelegate applicationDidFinishLaunching:]):
SettingsController now takes care of reading the default URL preference.
WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
(-[BrowserAppDelegate didChangeSettings]):
When settings change, update the key equivalents for the new-window menu items, as they
might have changed (as use-WebKit2-by-default is one of the settings).
Dispatch settings change notifications to all live BrowserControllers.
(-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
(-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
(-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
(-[BrowserAppDelegate validateMenuItem:]): Deleted.
All menu item validation for settings is moved into SettingsController.
- MiniBrowser/mac/BrowserWindowController.h:
Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
- MiniBrowser/mac/MainMenu.xib:
Remove the settings menu items from the "Debug" menu.
- MiniBrowser/mac/SettingsController.h: Added.
- MiniBrowser/mac/SettingsController.m: Added.
(+[SettingsController shared]):
(-[SettingsController menu]):
(-[SettingsController _addItemWithTitle:action:indented:]):
(-[SettingsController _addHeaderWithTitle:]):
NSMenuItem-creating helpers.
(-[SettingsController _populateMenu]):
Build the menu. Ideally this and the validation step would eventually be made more dynamic.
(-[SettingsController validateMenuItem:]):
Validate menu items; since they can be used to toggle the default state of a setting,
we'll always return YES. However, we will use this opportunity to set the 'checked' state
of each item.
(-[SettingsController _toggleBooleanDefault:]):
Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
(-[SettingsController toggleUseWebKit2ByDefault:]):
(-[SettingsController useWebKit2ByDefault]):
(-[SettingsController toggleUseTransparentWindows:]):
(-[SettingsController useTransparentWindows]):
(-[SettingsController toggleUsePaginatedMode:]):
(-[SettingsController usePaginatedMode]):
(-[SettingsController toggleUseUISideCompositing:]):
(-[SettingsController useUISideCompositing]):
(-[SettingsController toggleShowLayerBorders:]):
(-[SettingsController layerBordersVisible]):
(-[SettingsController toggleShowTiledScrollingIndicator:]):
(-[SettingsController tiledScrollingIndicatorVisible]):
(-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
(-[SettingsController subPixelCSSOMMetricsEnabled]):
(-[SettingsController defaultURL]):
Toggle or return the current state of each preference.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController awakeFromNib]):
(-[WK1BrowserWindowController validateMenuItem:]):
(-[WK1BrowserWindowController windowWillClose:]):
(-[WK1BrowserWindowController find:]):
(-[WK1BrowserWindowController dumpSourceToConsole:]):
(-[WK1BrowserWindowController didChangeSettings]):
(-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
(-[WK1BrowserWindowController isPaginated]): Deleted.
(-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
(-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
(-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
(-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
(-[WK1BrowserWindowController layerBordersVisible]): Deleted.
(-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController forceRepaint:]):
(-[WK2BrowserWindowController windowWillClose:]):
(-[WK2BrowserWindowController didChangeSettings]):
(-[WK2BrowserWindowController isPaginated]): Deleted.
(-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
(-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
(-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
(-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
(-[WK2BrowserWindowController layerBordersVisible]): Deleted.
(-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
(-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
(-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
- 11:20 AM Changeset in webkit [171925] by
-
- 2 edits in trunk/Source/WebCore
nullptr goodness in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=135512
Reviewed by Brent Fulgham.
Use nullptr in RenderLayer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateDescendantDependentFlags):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateClipRects):
- 11:19 AM Changeset in webkit [171924] by
-
- 3 edits in trunk/Tools
MiniBrowser doesn't support data URLs
https://bugs.webkit.org/show_bug.cgi?id=135492
Reviewed by Simon Fraser.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController addProtocolIfNecessary:]):
Don't add http:// to data: URLs.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController fetch:]):
(-[WK2BrowserWindowController updateTextFieldFromURL:]):
Percent-escape the contents of the address field before trying to make a URL.
Percent-unescape the URL when displaying it in the address field.
This is not great, but trivial and good-enough-for-Minibrowser.
- 11:16 AM Changeset in webkit [171923] by
-
- 2 edits in trunk/Source/WebCore
Build fix for iOS
- bindings/objc/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
We use CGImageRef instead of NSImage here on iOS.
- 11:13 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 10:46 AM Changeset in webkit [171922] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 10:44 AM Changeset in webkit [171921] by
-
- 1 copy in tags/Safari-600.1.4.3
New Tag.
- 10:38 AM Changeset in webkit [171920] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Fullscreen mode for some applications shows only a black screen.
https://bugs.webkit.org/show_bug.cgi?id=135493
<rdar://problem/17628212>
Reviewed by Jer Noble.
In some applications, the window hosting the WKView is an InProcess layer hosting mode.
The fullscreen window created by the WKFullScreenWindowController defaults to an
OutOfProcess mode.
When this kind of mismatch is encountered, the WK2 layer in the UI process is supposed
to send a message back to the WebProcess indicating that the layer hosting mode of the
containing window is different, so that the WebProcess can adjust its logic accordingly.
Unfortunately, the notification that this had happened was not getting sent to the
WebProcess due to an optimization in window state change logic (see Bug 135509 for
details).
The fix is to check layer hosting mode state when a WKView is added to a window, and
notify the WebProcess when it needs to change state to match.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]): When moving to a new window, always call
'layerHostingModeDidChange' to pick up any changes in the layer hosting mode.
- 10:32 AM Changeset in webkit [171919] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r171895. <rdar://problem/17835345>
- 10:02 AM Changeset in webkit [171918] by
-
- 1 copy in tags/Safari-600.1.2.5/Safari-600.1.2.4
New Tag.
- 9:15 AM Changeset in webkit [171917] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: listNode in WebCore::RenderListItem::updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=134970
Patch by Renato Nagy <nagy.renato@stud.u-szeged.hu> on 2014-08-01
Reviewed by Zalan Bujtas.
Removed an unnecessary assert, because the null return value of enclosingList() is
handled properly after this assert.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateListMarkerNumbers):
- 6:42 AM Changeset in webkit [171916] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for failing tests. Remove flaky test expectations that are
no longer correct.
- platform/efl/TestExpectations:
- platform/efl/fast/text/khmer-lao-font-expected.txt: Update expected result.
- svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Update after r171046.
- 6:34 AM Changeset in webkit [171915] by
-
- 7 edits in trunk
[CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version
https://bugs.webkit.org/show_bug.cgi?id=135501
Reviewed by Gyuyoung Kim.
Use PROJECT_VERSION_MICRO instead.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitHelpers.cmake:
Source/WebKit2:
- UIProcess/API/efl/EWebKit2.h.in:
- UIProcess/API/gtk/WebKitVersion.h.in:
- 3:48 AM Changeset in webkit [171914] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Add missing sections to documentation.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add
WebKitUserContent and WebKitUserContentManager sections to the
documentation.
- 2:59 AM Changeset in webkit [171913] by
-
- 1 copy in releases/WebKitGTK/webkit-2.5.1
WebKitGTK+ 2.5.1
- 1:14 AM Changeset in webkit [171912] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Update test expectations for crashing webgl tests.
- platform/efl/TestExpectations:
- 12:26 AM Changeset in webkit [171911] by
-
- 2 edits in trunk/Source/WebCore
Replace DEPRECATED_DEFINE_STATIC_LOCAL with NeverDestroyed<T> in NavigatorContentUtils
https://bugs.webkit.org/show_bug.cgi?id=135494
Reviewed by Andrei Bucur.
Use static NeverDestroyed<T> variables instead of the DEPRECATED_DEFINE_STATIC_LOCAL macro.
No new tests, no behavior changes.
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::customHandlersStateString):
(WebCore::NavigatorContentUtils::isProtocolHandlerRegistered):
- 12:24 AM Changeset in webkit [171910] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Unable to do make install since r171901
https://bugs.webkit.org/show_bug.cgi?id=135497
Reviewed by Gyuyoung Kim.
- PlatformEfl.cmake: Removed ewk_defins.h from the installation list.
