Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 16, 2015:

10:20 PM Changeset in webkit [192508] by benjamin@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Make FTLOutput's load8() and load16() compatible with B3
​https://bugs.webkit.org/show_bug.cgi?id=151336

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-11-16
Reviewed by Filip Pizlo.

B3 does not have 8bit and 16bit types. Make FTLOutput abstract enough
to handle LLVM IR and B3.

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToLLVM::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToLLVM::compileStringCharCodeAt):
(JSC::FTL::DFG::LowerDFGToLLVM::compileNotifyWrite):
(JSC::FTL::DFG::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckHasInstance):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckWatchdogTimer):
(JSC::FTL::DFG::LowerDFGToLLVM::speculateTruthyObject):
(JSC::FTL::DFG::LowerDFGToLLVM::boolify):
(JSC::FTL::DFG::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::DFG::LowerDFGToLLVM::switchStringRecurse):
(JSC::FTL::DFG::LowerDFGToLLVM::isObject):
(JSC::FTL::DFG::LowerDFGToLLVM::isNotObject):
(JSC::FTL::DFG::LowerDFGToLLVM::isArrayType):
(JSC::FTL::DFG::LowerDFGToLLVM::isExoticForTypeof):
(JSC::FTL::DFG::LowerDFGToLLVM::isType):
(JSC::FTL::DFG::LowerDFGToLLVM::speculateNonNullObject):
(JSC::FTL::DFG::LowerDFGToLLVM::loadCellState):
(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):

• ftl/FTLOutput.h:

(JSC::FTL::Output::load8SignExt32):
(JSC::FTL::Output::load8ZeroExt32):
(JSC::FTL::Output::load16SignExt32):
(JSC::FTL::Output::load16ZeroExt32):
(JSC::FTL::Output::constInt8): Deleted.
(JSC::FTL::Output::load8): Deleted.
(JSC::FTL::Output::load16): Deleted.
(JSC::FTL::Output::store8): Deleted.
(JSC::FTL::Output::storeFloat): Deleted.
(JSC::FTL::Output::isZero8): Deleted.
(JSC::FTL::Output::notZero8): Deleted.
(JSC::FTL::Output::testIsZero8): Deleted.
(JSC::FTL::Output::testNonZero8): Deleted.

7:51 PM Changeset in webkit [192507] by matthew_hanson@apple.com

• 1 move in tags/Safari-601.1.46.81

Fixup tag name.

7:45 PM Changeset in webkit [192506] by matthew_hanson@apple.com

• 1 move in tags/Safari-601.1.46.81-branch

Fixup tag name.

7:29 PM Changeset in webkit [192505] by commit-queue@webkit.org

• 2 edits in trunk/PerformanceTests

Remove the option for animating using setInterval from the graphics benchmark
​https://bugs.webkit.org/show_bug.cgi?id=151283

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-11-16
Reviewed by Darin Adler.

Get rid of the option to run animation using setInterval().

• Animometer/tests/resources/main.js:

(Animator.prototype.animate):
(Benchmark):
(Benchmark.prototype.start):
(Animator.prototype.start): Deleted.

7:27 PM Changeset in webkit [192504] by matthew_hanson@apple.com

• 1 copy in tags/safari-601.1.46.81-branch

New Tag.

6:52 PM Changeset in webkit [192503] by eric.carlson@apple.com

• 18 edits
  2 copies
  2 adds in trunk

[MediaStream] VideoTrack should respond to MediaStreamTrack state changes
​https://bugs.webkit.org/show_bug.cgi?id=151299

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/MediaStream-video-element-track-stop.html

• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::ended): Check m_ended.
(WebCore::MediaStreamTrack::stopProducingData): Set m_ended before telling private track to

stop so we won't fire an 'ended' event.

(WebCore::MediaStreamTrack::trackEnded): Set m_ended, add comments from spec.

• Modules/mediastream/MediaStreamTrack.h:

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Live streams have infinite duration,

not indefinite.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::platformLayer): Return NULL when displayMode

is None.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentDisplayMode): Calculate current

displayMode based on MediaStream state.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayMode): Renamed from

setPausedImageVisible, use m_displayMode. Don't start/stop clock, it makes more sense
to do that in play and pause.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::play): Start clock.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pause): Stop clock.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentReadyState): Call updateDisplayMode.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::activeStatusChanged): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateIntrinsicSize):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createPreviewLayers): Always try to create

both layers if necessary.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::renderingModeChanged): New, update displayMode

and call back to the media element.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::characteristicsChanged):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks): Get rid of some unused locals.

React to a change in the enabled video track.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext): Paint black when

the active video track is disabled.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setPausedImageVisible): Deleted.

• platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::updateActiveState): Split the logic of updating the active video

track out into updateActiveVideoTrack.

(WebCore::MediaStreamPrivate::hasVideo): Check for track.ended.
(WebCore::MediaStreamPrivate::hasAudio): Ditto.
(WebCore::MediaStreamPrivate::paintCurrentFrameInContext): Don't call the source directly.
(WebCore::MediaStreamPrivate::updateActiveVideoTrack): New.
(WebCore::MediaStreamPrivate::trackEnabledChanged): Call updateActiveVideoTrack.
(WebCore::MediaStreamPrivate::trackEnded): new.

• platform/mediastream/MediaStreamPrivate.h:

• platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::setEnabled): Call observers if enabled state changes.
(WebCore::MediaStreamTrackPrivate::endTrack): Call observers.
(WebCore::MediaStreamTrackPrivate::paintCurrentFrameInContext): New.
(WebCore::MediaStreamTrackPrivate::preventSourceFromStopping): Add comments.

• platform/mediastream/MediaStreamTrackPrivate.h:

• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::paintCurrentFrameInContext): Remove a commented-out line.

LayoutTests:

• fast/mediastream/MediaStream-video-element-expected.txt:
• fast/mediastream/MediaStream-video-element-track-stop-expected.txt: Added.
• fast/mediastream/MediaStream-video-element-track-stop.html: Added.
• fast/mediastream/MediaStream-video-element.html:
• platform/gtk/TestExpectations: Skip new test.
• platform/ios-simulator/TestExpectations: Ditto.
• platform/mac-wk2/TestExpectations: Ditto.
• platform/win/TestExpectations: Ditto.

6:10 PM Changeset in webkit [192502] by commit-queue@webkit.org

• 4 edits in trunk

Fix CMake build and make PluginProcess executable
​https://bugs.webkit.org/show_bug.cgi?id=151332

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-11-16
Reviewed by Tim Horton.

.:

• Source/cmake/OptionsMac.cmake:

Source/WebKit2:

• PlatformMac.cmake:

5:56 PM Changeset in webkit [192501] by matthew_hanson@apple.com

• 6 edits in branches/safari-601.1.46-branch/Source

Merge r192284. rdar://problem/23564973

5:21 PM Changeset in webkit [192500] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Multi-WKWebView find completes after the first view
​https://bugs.webkit.org/show_bug.cgi?id=151325

Reviewed by Anders Carlsson.

• UIProcess/mac/WKTextFinderClient.mm:

(-[WKTextFinderClient findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:]):
Update progress before calling the completion handler; NSTextFinder assumes
that if the progress doesn't change, the search is complete.

5:19 PM Changeset in webkit [192499] by Brent Fulgham

• 3 edits
  2 adds in trunk

Source/WebCore:
Fixes the buffer-overflow when reading characters from textRun
​https://bugs.webkit.org/attachment.cgi?bugid=151055
<rdar://problem/23251789>

Patch by Pranjal Jumde <​pjumde@apple.com> on 2015-11-16
Reviewed by Brent Fulgham.

• platform/graphics/FontCascade.cpp

LayoutTests:
Checks for buffer-overflows when reading characters from textRun
​https://bugs.webkit.org/attachment.cgi?bugid=151055
<rdar://problem/23251789>

Patch by Pranjal Jumde <​pjumde@apple.com> on 2015-11-16
Reviewed by Brent Fulgham.

• webgl/1.0.3/151055_asan-expected.txt
• webgl/1.0.3/151055_asan.html

4:53 PM Changeset in webkit [192498] by benjamin@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix a typo in AirIteratedRegisterCoalescing

I forgot to fix that review comment from Geoff.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-11-16

• b3/air/AirIteratedRegisterCoalescing.cpp:

(JSC::B3::Air::IteratedRegisterCoalescingAllocator::build):

4:44 PM Changeset in webkit [192497] by benjamin@webkit.org

• 9 edits in trunk/Source/JavaScriptCore

[JSC] Add support for the extra registers that can be clobbered by Specials
​https://bugs.webkit.org/show_bug.cgi?id=151246

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-11-16
Reviewed by Geoffrey Garen.

Specials can clobber arbitrary registers. This was not handled correctly by Air
and nothing was preventing us from re-allocating those registers.

This patch adds support for the extra clobbered registers in the two register allocators.

I also fixed the re-spilling FIXME of the iterated allocator because the test might
not always converge without it. Since we are at maximum register pressure at the patch point,
we could be always spilling the return value, which would loop forever.

To fix the re-spilling, I just kept a Set of every value spilled or filled so far. When selecting
a spill candidate, we never pick a Tmp from that set.

• b3/air/AirGenerate.cpp:

(JSC::B3::Air::generate):

• b3/air/AirHandleCalleeSaves.cpp:

(JSC::B3::Air::handleCalleeSaves):

• b3/air/AirInst.h:
• b3/air/AirInstInlines.h:

(JSC::B3::Air::Inst::forEachDefAndExtraClobberedTmp):

• b3/air/AirIteratedRegisterCoalescing.cpp:

(JSC::B3::Air::IteratedRegisterCoalescingAllocator::IteratedRegisterCoalescingAllocator):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::build):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::addEdges):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::selectSpill):
(JSC::B3::Air::addSpillAndFillToProgram):
(JSC::B3::Air::iteratedRegisterCoalescingOnType):
(JSC::B3::Air::iteratedRegisterCoalescing):

• b3/air/AirSpillEverything.cpp:

(JSC::B3::Air::spillEverything):

• b3/testb3.cpp:

(JSC::B3::testSimplePatchpointWithoutOuputClobbersGPArgs):
(JSC::B3::testSimplePatchpointWithOuputClobbersGPArgs):
(JSC::B3::testSimplePatchpointWithoutOuputClobbersFPArgs):
(JSC::B3::testSimplePatchpointWithOuputClobbersFPArgs):
(JSC::B3::run):

• jit/RegisterSet.h:

4:26 PM Changeset in webkit [192496] by ryuan.choi@navercorp.com

• 2 edits in trunk/Source/WebKit2

WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction calls an std::function after it's been moved from
​https://bugs.webkit.org/show_bug.cgi?id=151248

Reviewed by Darin Adler.

Like r188287, calling an empty std::function results in a std::bad_function_call
exception being thrown when sendSync is failed.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

4:14 PM Changeset in webkit [192495] by benjamin@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Build fix after r192492

Last second change broke the build.

• b3/air/AirIteratedRegisterCoalescing.cpp:

(JSC::B3::Air::IteratedRegisterCoalescingAllocator::OrderedMoveSet::contains):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::OrderedMoveSet::takeMove):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::OrderedMoveSet::takeLastMove):

3:52 PM Changeset in webkit [192494] by commit-queue@webkit.org

• 5 edits in trunk/PerformanceTests

Highlight the alarming test results in the graphics benchmark results page
​https://bugs.webkit.org/show_bug.cgi?id=151286

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-11-16
Reviewed by Simon Fraser.

When showing the results of a test in the graphics benchmark the following
criteria is going to be applied:

1. If the standard deviation of the test complexity or the frame rate is equal to or more than 10%, the standard deviation and the test name will be displayed in red.
2. If the average frame rate is not in the range = [(desired_frame_rate - 2) .. (desired_frame_rate + 2)], the average frame rate and the test name will be displayed in red.

• Animometer/resources/extensions.js:

(ResultsTable.prototype._showHeaderRow):
(ResultsTable.prototype._showHeader):
(ResultsTable.prototype._showEmptyCell):
(ResultsTable.prototype._showText):
(ResultsTable.prototype._showFixedNumber):
(ResultsTable.prototype.):
(ResultsTable.prototype._showGraph):
(ResultsTable.prototype._showJSON):
(ResultsTable.prototype._isAlarmingMeasurement):
(ResultsTable.prototype._isAlarmingTestResults):
(ResultsTable.prototype._showEmptyCells):
(ResultsTable.prototype._showEmptyRow):
(ResultsTable.prototype._showTest):
(ResultsTable.prototype._showSuite):
(ResultsTable.prototype._showIteration):
(ResultsTable.prototype.showRecord):
(ResultsTable.prototype.showIterations):
(ResultsTable.prototype._showEmpty): Deleted.

• Animometer/runner/resources/animometer.js:

(window.benchmarkRunnerClient.didFinishLastIteration):

• Animometer/tests/resources/stage.js:

(StageBenchmark.prototype.showResults):

3:49 PM Changeset in webkit [192493] by benjamin@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

[JSC] Add trivial lowering for B3's Div with doubles
​https://bugs.webkit.org/show_bug.cgi?id=151292

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-11-16
Reviewed by Geoffrey Garen.

Filip had already made the constant propagation for it.
The Air Opcode was all we had left.

• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::lower):

• b3/air/AirOpcode.opcodes:
• b3/testb3.cpp:

(JSC::B3::testDivArgDouble):
(JSC::B3::testDivArgsDouble):
(JSC::B3::testDivArgImmDouble):
(JSC::B3::testDivImmArgDouble):
(JSC::B3::testDivImmsDouble):
(JSC::B3::run):

3:47 PM Changeset in webkit [192492] by benjamin@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Speed up the coalescing-related operation of the iterated register allocator
​https://bugs.webkit.org/show_bug.cgi?id=151290

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-11-16
Reviewed by Geoffrey Garen.

One step closer to removing the Hash structures:

For the coalescing operation, we need to keep track of Move instructions. We do not strictly
need those to be the Air Move, just any abstract operation that copy a Tmp into another Tmp.

In this patch, I exploit that to remove the Hash structure related to the Inst. Instead of
using the Move Inst, we just keep track of the Use() and Def() of the instructions.
Those are added in the global list m_coalescingCandidates and the index in that list represent
the move for the remaining of the algorithm.

With Moves transformed into dense indices, we can start using arrays to make fast sets.

The m_activeMoves Set is easy since we only need simple add/remove/contains. It is transformed
into a BitVector.
The bit vector is always fully allocated to allow for quick uniform access. The assumtion is that
activeMoves will contains a few values for non trivial cases.

The worklist m_worklistMoves is more complicated. I want it to be ordered to coalesce moves starting
at the top of blocks. Having a fast remove() operation is also useful for mass coalescing.
It also needs Set operations, especially a fast contains().

For m_worklistMoves, I created a new structure: OrderedMoveSet.
It contains a list of ordered values, and a map of each value to its position in the list.

This resembles Briggs' Sparse Set but it is not exactly the same. When removing a value,
I set a special marker in the map (UINT_MAX). The reason is that I want contains() to be fast
instead of remove(). The marker in the map allows contains() with a single memory operation instead of two.

• b3/air/AirIteratedRegisterCoalescing.cpp:

(JSC::B3::Air::IteratedRegisterCoalescingAllocator::build):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::allocate):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::forEachNodeMoves):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::isMoveRelated):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::enableMovesOnValue):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::coalesce):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::combine):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::freezeMoves):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::dumpWorkLists):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::OrderedMoveSet::addMove):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::OrderedMoveSet::isEmpty):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::OrderedMoveSet::contains):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::OrderedMoveSet::takeMove):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::OrderedMoveSet::takeLastMove):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::OrderedMoveSet::returnMove):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::OrderedMoveSet::clear):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::assignColors): Deleted.

3:22 PM Changeset in webkit [192491] by commit-queue@webkit.org

• 9 edits in trunk/PerformanceTests

Clean referencing the options object in the graphics benchmark
​https://bugs.webkit.org/show_bug.cgi?id=151284

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-11-16
Reviewed by Simon Fraser.

Get rid of the Benchmark.options member and rely only on the private member
Benchmark._options. The animator need to have its own options member instead
of accessing it from its reference to Benchmark object.

• Animometer/tests/bouncing-particles/resources/bouncing-canvas-particles.js:

(BouncingCanvasParticlesAnimator):
(BouncingCanvasParticlesBenchmark.prototype.createAnimator):

• Animometer/tests/bouncing-particles/resources/bouncing-particles.js:

(BouncingParticle.prototype.animate):
(BouncingParticlesAnimator):
(BouncingParticlesBenchmark.prototype.createAnimator):

• Animometer/tests/examples/resources/canvas-electrons.js:

(CanvasElectronsStage.prototype.animate):
(CanvasElectronsAnimator):
(CanvasElectronsBenchmark.prototype.createAnimator):
(window.benchmarkClient.create):

• Animometer/tests/examples/resources/canvas-stars.js:

(CanvasStarsStage.prototype.animate):
(CanvasStarsAnimator):
(CanvasStarsBenchmark.prototype.createAnimator):
(window.benchmarkClient.create):

• Animometer/tests/resources/main.js:

(BenchmarkState.prototype.currentProgress):
(Animator):
(Animator.prototype.animate):
(Benchmark):
(Benchmark.prototype.update):

• Animometer/tests/resources/stage.js:

(Stage.prototype.clear):
(StageAnimator):
(StageBenchmark.prototype.createAnimator):
(StageBenchmark.prototype.tune):
(StageBenchmark.prototype.showResults):

• Animometer/tests/simple/resources/simple-canvas.js:

(SimpleCanvasStage.prototype.animate):
(SimpleCanvasAnimator):
(SimpleCanvasAnimator.prototype.animate):
(SimpleCanvasBenchmark.prototype.createAnimator):

• Animometer/tests/template/resources/template-canvas.js:

(TemplateCanvasStage.prototype.animate):
(TemplateCanvasBenchmark.prototype.createAnimator):
(window.benchmarkClient.create):

3:17 PM Changeset in webkit [192490] by beidson@apple.com

• 28 edits
  22 adds in trunk

Modern IDB:Make in-memory ObjectStore cursors work.
​https://bugs.webkit.org/show_bug.cgi?id=151196

Reviewed by Darin Adler.

Source/WebCore:

Tests: storage/indexeddb/modern/cursor-2.html

storage/indexeddb/modern/cursor-3.html
storage/indexeddb/modern/cursor-4.html
storage/indexeddb/modern/cursor-5.html
storage/indexeddb/modern/cursor-6.html
storage/indexeddb/modern/cursor-7.html
storage/indexeddb/modern/cursor-8.html
storage/indexeddb/modern/objectstore-cursor-advance-failures.html
storage/indexeddb/modern/objectstore-cursor-continue-failures.html

Object store cursors directly hold on to a std::set<>::iterator to act as the cursor.

The object store tells all of its cursors when it is cleared or records are deleted
so the cursors can invalidate their iterators as needed.

In case of such invalidation, the cursor hangs on to the current key value so it can
pick up where it left off in case it is iterated.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

• Modules/indexeddb/IDBGetResult.h:

(WebCore::IDBGetResult::isolatedCopy):

• Modules/indexeddb/IDBKeyRangeData.cpp:

(WebCore::IDBKeyRangeData::containsKey):
(WebCore::IDBKeyRangeData::loggingString):

• Modules/indexeddb/IDBKeyRangeData.h:

• Modules/indexeddb/client/IDBAnyImpl.cpp:

(WebCore::IDBClient::IDBAny::modernIDBCursor):

• Modules/indexeddb/client/IDBCursorImpl.cpp:

(WebCore::IDBClient::IDBCursor::update):
(WebCore::IDBClient::IDBCursor::advance):
(WebCore::IDBClient::IDBCursor::continueFunction):
(WebCore::IDBClient::IDBCursor::setGetResult):

• Modules/indexeddb/client/IDBCursorImpl.h:

• Modules/indexeddb/client/IDBRequestImpl.cpp:

(WebCore::IDBClient::IDBRequest::dispatchEvent):
(WebCore::IDBClient::IDBRequest::didOpenOrIterateCursor):

• Modules/indexeddb/client/IDBRequestImpl.h:

(WebCore::IDBClient::IDBRequest::pendingCursor):

• Modules/indexeddb/client/IDBTransactionImpl.cpp:

(WebCore::IDBClient::IDBTransaction::addRequest): Deleted.

• Modules/indexeddb/client/TransactionOperation.cpp:

(WebCore::IDBClient::TransactionOperation::TransactionOperation):

• Modules/indexeddb/client/TransactionOperation.h:

(WebCore::IDBClient::TransactionOperation::cursorIdentifier):

• Modules/indexeddb/server/IDBBackingStore.h:

• Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:

(WebCore::IDBServer::MemoryBackingStoreTransaction::objectStoreCleared):
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):

• Modules/indexeddb/server/MemoryBackingStoreTransaction.h:

• Modules/indexeddb/server/MemoryCursor.cpp: Added.

(WebCore::IDBServer::cursorMap):
(WebCore::IDBServer::MemoryCursor::MemoryCursor):
(WebCore::IDBServer::MemoryCursor::~MemoryCursor):
(WebCore::IDBServer::MemoryCursor::cursorForIdentifier):

• Modules/indexeddb/server/MemoryCursor.h: Added.

• Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::openCursor):
(WebCore::IDBServer::MemoryIDBBackingStore::iterateCursor):

• Modules/indexeddb/server/MemoryIDBBackingStore.h:

• Modules/indexeddb/server/MemoryObjectStore.cpp:

(WebCore::IDBServer::MemoryObjectStore::clear):
(WebCore::IDBServer::MemoryObjectStore::replaceKeyValueStore):
(WebCore::IDBServer::MemoryObjectStore::deleteRecord):
(WebCore::IDBServer::MemoryObjectStore::addRecord):
(WebCore::IDBServer::MemoryObjectStore::updateCursorsForPutRecord):
(WebCore::IDBServer::MemoryObjectStore::updateCursorsForDeleteRecord):
(WebCore::IDBServer::MemoryObjectStore::maybeOpenCursor):

• Modules/indexeddb/server/MemoryObjectStore.h:

(WebCore::IDBServer::MemoryObjectStore::orderedKeys):

• Modules/indexeddb/server/MemoryObjectStoreCursor.cpp: Added.

(WebCore::IDBServer::MemoryObjectStoreCursor::create):
(WebCore::IDBServer::MemoryObjectStoreCursor::MemoryObjectStoreCursor):
(WebCore::IDBServer::MemoryObjectStoreCursor::objectStoreCleared):
(WebCore::IDBServer::MemoryObjectStoreCursor::keyDeleted):
(WebCore::IDBServer::MemoryObjectStoreCursor::keyAdded):
(WebCore::IDBServer::MemoryObjectStoreCursor::setFirstInRemainingRange):
(WebCore::IDBServer::MemoryObjectStoreCursor::firstForwardIteratorInRemainingRange):
(WebCore::IDBServer::MemoryObjectStoreCursor::firstReverseIteratorInRemainingRange):
(WebCore::IDBServer::MemoryObjectStoreCursor::currentData):
(WebCore::IDBServer::MemoryObjectStoreCursor::incrementForwardIterator):
(WebCore::IDBServer::MemoryObjectStoreCursor::incrementReverseIterator):
(WebCore::IDBServer::MemoryObjectStoreCursor::hasValidPosition):
(WebCore::IDBServer::MemoryObjectStoreCursor::iterate):

• Modules/indexeddb/server/MemoryObjectStoreCursor.h: Added.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::iterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::performIterateCursor):

• Modules/indexeddb/server/UniqueIDBDatabase.h:

• Modules/indexeddb/shared/IDBCursorInfo.h:

(WebCore::IDBCursorInfo::range):

• Modules/indexeddb/shared/IDBRequestData.cpp:

(WebCore::IDBRequestData::IDBRequestData):
(WebCore::IDBRequestData::cursorIdentifier):

• Modules/indexeddb/shared/IDBRequestData.h:

LayoutTests:

• storage/indexeddb/modern/cursor-1-expected.txt:
• storage/indexeddb/modern/cursor-2-expected.txt: Added.
• storage/indexeddb/modern/cursor-2.html: Added.
• storage/indexeddb/modern/cursor-3-expected.txt: Added.
• storage/indexeddb/modern/cursor-3.html: Added.
• storage/indexeddb/modern/cursor-4-expected.txt: Added.
• storage/indexeddb/modern/cursor-4.html: Added.
• storage/indexeddb/modern/cursor-5-expected.txt: Added.
• storage/indexeddb/modern/cursor-5.html: Added.
• storage/indexeddb/modern/cursor-6-expected.txt: Added.
• storage/indexeddb/modern/cursor-6.html: Added.
• storage/indexeddb/modern/cursor-7-expected.txt: Added.
• storage/indexeddb/modern/cursor-7.html: Added.
• storage/indexeddb/modern/cursor-8-expected.txt: Added.
• storage/indexeddb/modern/cursor-8.html: Added.
• storage/indexeddb/modern/objectstore-cursor-advance-failures-expected.txt: Added.
• storage/indexeddb/modern/objectstore-cursor-advance-failures.html: Added.
• storage/indexeddb/modern/objectstore-cursor-continue-failures-expected.txt: Added.
• storage/indexeddb/modern/objectstore-cursor-continue-failures.html: Added.

3:13 PM Changeset in webkit [192489] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Removed Yosemite modifier for flaky test http/tests/media/video-preload.html
​https://bugs.webkit.org/show_bug.cgi?id=141084

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:05 PM Changeset in webkit [192488] by matthew_hanson@apple.com

• 6 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r191895. rdar://problem/23501902

2:46 PM Changeset in webkit [192487] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking webarchive/loading/missing-data.html as flaky due to intermittent crashes.
​https://bugs.webkit.org/show_bug.cgi?id=151326

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

2:38 PM Changeset in webkit [192486] by Beth Dakin

• 6 edits
  4 adds in trunk/Source/WebKit2

Add SPI for handling inline link navigation for peek/pop
​https://bugs.webkit.org/show_bug.cgi?id=151270
-and corresponding-
rdar://problem/22233739

Reviewed by Darin Adler.

This patch adds three new SPI methods. If a client wants to disable previews
entirely for the given element, they should return NO in
shouldPreviewElement:. Returning NO in shouldPreviewElement will prevent the
other methods from being invoked. The client can provide a custom preview by
returning their own UIViewController from
previewingViewControllerForElement:defaultActions:. Returning nil will result
in the default preview behavior for that element. This will allow clients to
implement this method to handle http link navigation inline, but still opt
into UIKit’s built-in DataDetectors behaviors for DD links once we start
supporting DD links in WK2.

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:

Added linkURL to _WKElementInfo. linkURL will be nil for elements that are
not links.

• UIProcess/API/Cocoa/_WKElementInfo.h:
• UIProcess/API/Cocoa/_WKElementInfo.mm:

(-[_WKElementInfo copyWithZone:]):
(-[_WKElementInfo linkURL]):

• UIProcess/API/Cocoa/_WKElementInfoInternal.h: Added.

_WKPreviewingElementInfo inherits from _WKElementInfo. Added a constructor.

• UIProcess/API/Cocoa/_WKPreviewElementInfo.h: Added.
• UIProcess/API/Cocoa/_WKPreviewElementInfo.mm: Added.

(-[_WKPreviewElementInfo _initWithLinkURL:]):

• UIProcess/API/Cocoa/_WKPreviewElementInfoInternal.h: Added.

Invoke shouldPreviewElement:.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):

Invoke previewingViewControllerForElement: for all potentially preview-able
elements that have a default implementations, which will be limited to links
at this time.
(-[WKContentView _presentedViewControllerForPreviewItemController:]):

Invoke commitPreviewingViewController:
(-[WKContentView _previewItemController:commitPreview:]):

• WebKit2.xcodeproj/project.pbxproj:

2:10 PM Changeset in webkit [192485] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

DFGEdge's dump method should print "Untyped:" for untyped uses.
​https://bugs.webkit.org/show_bug.cgi?id=151314

Rubber stamped by Filip Pizlo.

• dfg/DFGEdge.cpp:

(JSC::DFG::Edge::dump):

2:04 PM Changeset in webkit [192484] by Wenson Hsieh

• 10 edits in trunk/LayoutTests

Enable passing tests in LayoutTests/fast/mediastream
​https://bugs.webkit.org/show_bug.cgi?id=151311

Reviewed by Eric Carlson.

Mark LayoutTests/fast/mediastream as passing by default, and skip only the tests that currently
fail. Also unprefixes some tests that fail due to invoking the webkitMediaStream constructor
rather than MediaStream. As we implement more functionality in the Media Stream and Capture
spec, we will remove entries from the fast/mediastream section under Mac TestExpectations.

• fast/events/constructors/media-stream-event-constructor.html:
• fast/mediastream/MediaStream-add-ended-tracks.html:
• fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html:
• fast/mediastream/MediaStream-construct-with-ended-tracks.html:
• fast/mediastream/MediaStreamConstructor-expected.txt:
• fast/mediastream/MediaStreamConstructor.html:
• fast/mediastream/MediaStreamTrack-onended.html:
• platform/mac-wk1/TestExpectations:
• platform/mac/TestExpectations:

12:50 PM Changeset in webkit [192483] by bshafiei@apple.com

• 5 edits in branches/safari-601.2.7.2-branch/Source

Versioning.

12:48 PM Changeset in webkit [192482] by bshafiei@apple.com

• 1 copy in tags/Safari-601.2.7.2.3

New tag.

12:46 PM Changeset in webkit [192481] by andersca@apple.com

• 5 edits
  2 adds in trunk/Source

Add identifier strings for a bunch of context menu items
​https://bugs.webkit.org/show_bug.cgi?id=151272

Reviewed by Dan Bernstein.

Source/WebCore:

Have NSMenuItem conform to NSUserInterfaceItemIdentification.

• platform/spi/mac/NSMenuSPI.h:

Source/WebKit2:

• UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm: Added.
• UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h: Added.
• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::createShareMenuItem):
(WebKit::WebContextMenuProxyMac::createContextMenuItem):

• WebKit2.xcodeproj/project.pbxproj:

12:42 PM Changeset in webkit [192480] by bshafiei@apple.com

• 3 edits in branches/safari-601.2.7.2-branch/Source/WebCore

Merged r192166. rdar://problem/22956040

11:45 AM Changeset in webkit [192479] by matthew_hanson@apple.com

• 24 edits in branches/safari-601.1.46-branch/Source

Merge r192138. rdar://problem/22846841

11:29 AM Changeset in webkit [192478] by fpizlo@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Make sure that the address matcher correctly handles Shl(x, 1)
​https://bugs.webkit.org/show_bug.cgi?id=151316

Reviewed by Geoffrey Garen.

This optimization isn't really that awesome, but the nicest part of the change is just the
testing. If we ever do more cleverness with shifts, these tests will come in handy.

• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::effectiveAddr):

• b3/testb3.cpp:

(JSC::B3::testLoadOffsetUsingAddNotConstant):
(JSC::B3::testLoadAddrShift):
(JSC::B3::testFramePointer):
(JSC::B3::run):

11:04 AM Changeset in webkit [192477] by jiewen_tan@apple.com

• 4 edits
  4 adds in trunk

Null-pointer dereference in WebCore::firstEditablePositionAfterPositionInRoot
​https://bugs.webkit.org/show_bug.cgi?id=151288
<rdar://problem/23450367>

Reviewed by Darin Adler.

Source/WebCore:

Some problematic organization of body element could cause problems to JustifyRight
and Indent commnads.

Tests: editing/execCommand/justify-right-then-indent-with-problematic-body.html

editing/execCommand/justify-right-with-problematic-body.html

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
Assertion at l1017 is not held anymore with the testcase:
editing/execCommand/justify-right-with-problematic-body.html.
Therefore, change it to an if statement.
Also, add a guardance before calling insertNewDefaultParagraphElementAt()
as insertNodeAt() requires an editable position.
(WebCore::CompositeEditCommand::moveParagraphWithClones):
Add a guardance before calling insertNodeAt() as it requires an editable position.

• editing/htmlediting.cpp:

(WebCore::firstEditablePositionAfterPositionInRoot):
(WebCore::lastEditablePositionBeforePositionInRoot):

LayoutTests:

• editing/execCommand/justify-right-then-indent-with-problematic-body-expected.txt: Added.
• editing/execCommand/justify-right-then-indent-with-problematic-body.html: Added.
• editing/execCommand/justify-right-with-problematic-body-expected.txt: Added.
• editing/execCommand/justify-right-with-problematic-body.html: Added.

10:50 AM Changeset in webkit [192476] by Simon Fraser

• 4 edits in trunk/Source

Sort the Xcode project files.

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

• WebKit2.xcodeproj/project.pbxproj:

10:41 AM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

9:51 AM Changeset in webkit [192475] by matthew_hanson@apple.com

• 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r189637. rdar://problem/22846841

9:31 AM Changeset in webkit [192474] by Carlos Garcia Campos

• 2 edits in trunk/Tools

Unreviewed. Fix GTK+ unit tests after r192469.

In r192469 jhbuild version was updated and coinfig lcas API changed.

• jhbuild/jhbuildutils.py:

(enter_jhbuild_environment_if_available): Pass an empty list for
conditions to the Config constructor.

8:56 AM Changeset in webkit [192473] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Rebaselining LayoutTest js/dom/global-constructors-attributes on Mac
​https://bugs.webkit.org/show_bug.cgi?id=150166

Unreviewed test gardening.

• platform/mac/js/dom/global-constructors-attributes-expected.txt:

8:18 AM Changeset in webkit [192472] by Carlos Garcia Campos

• 2 edits in trunk/Tools

Unreviewed. Use commit id instead of tag name for jhbuild revision.

In r192469 I updated the jhbuild version to 3.12.0, and used the
tag instead of the commit id to make it easier to read and
remember. But we use the commit id to check if the current
revision is up to date, and when compared to the tag id it always
fails and jhbuild is always updated.

• jhbuild/jhbuild-wrapper: Use commit id and add a comment to

remember this is the id of 3.12.0.

8:13 AM Changeset in webkit [192471] by Carlos Garcia Campos

• 2 edits in trunk/Tools

Unreviewed. Fix GTK+ layout tests running after r192469.

We fail to find the Gallium llvmpipe driver because of the build
directory change in r192469.

• gtk/jhbuildrc: Use buildroot instead of checkoutdir to build

the LLVMPIPE_LIBGL_PATH.

6:15 AM Changeset in webkit [192470] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

WebRTC: Expose RTCPeerConnectionInternals functions to JS builtins.
​https://bugs.webkit.org/show_bug.cgi?id=151302

Patch by Sebastian Dröge <​sebastian@centricular.com> on 2015-11-16
Reviewed by Youenn Fablet.

• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::finishCreation):
Expose RTCPeerConnectionInternals functions to JS builtins.

5:02 AM Changeset in webkit [192469] by Carlos Garcia Campos

• 15 edits
  4 deletes in trunk

[GTK] Use FTL by default when LLVM 3.7 is available
​https://bugs.webkit.org/show_bug.cgi?id=142128

Reviewed by Csaba Osztrogonác.

.:

Enable FTL by default when architecture is X86_64. It requires
LLVM 3.7, but can be disabled manually as a cmake configure
argument.

• Source/cmake/FindLLVM.cmake: In debian llvm-config is only

available if the metapackage is installed and it points to
llvm-config-3.5. So, here we check first if the llvm-config is
from a recent enough version, and if not we check several
llvm-config-<version> programs, so this should work on any distro.

• Source/cmake/OptionsGTK.cmake: Enable FTL by default when

target architecture is X86_64, and check the LLVM is at least
3.7. The option is now public, since we want people to be able to
disable it manually.

Source/JavaScriptCore:

• PlatformGTK.cmake: Install libllvmForJSC.so.
• llvm/InitializeLLVMLinux.cpp:

(JSC::getLLVMInitializerFunction): For developer build try to load first
libllvmForJSC.so from standard paths since not installed binaries
have the RPATH set. If it fails try the installed one. For
production buils load always the installed one.

Tools:

• Scripts/run-javascriptcore-tests: Enable FTL for GTK+ port when

architecture is x86_64.

• Scripts/update-webkit-libs-jhbuild:

(cleanJhbuild): Remove also the separate Build directory used by
GTK+ port now.

• Scripts/webkitdirs.pm:

(isX86_64):

• Scripts/webkitperl/FeatureList.pm: Enable FTL by default for

GTK+ port when architecture is x86_64.

• gtk/jhbuild-optional.modules: Remove llvm.
• gtk/jhbuild.modules: Add llvm 3.7 and include it as dependecy

only when architecture is x86_64.

• gtk/jhbuildrc: Set a buildroot to use a separate build

directory. LLVM 3.7 fails to build if configure script is run from
source dir. Since it's not possible to use a separate build dir
only for llvm, we do it now globally. Modules not supporting non
source build dirs are marked in the moduleset. Also set x86_64
condition when the architecture is x86_64.

• gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
• gtk/patches/llvm-elf-add-stackmaps.patch: Removed.
• gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
• gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed.
• jhbuild/jhbuild-wrapper: Use a newer jhbuild version to be able

to use conditions.

3:00 AM Changeset in webkit [192468] by youenn.fablet@crf.canon.fr

• 1 edit
  1 delete in trunk/LayoutTests/imported/w3c

Finalization of ​https://bugs.webkit.org/show_bug.cgi?id=151190, removing empty files

2:37 AM Changeset in webkit [192467] by youenn.fablet@crf.canon.fr

• 2 edits
  45 deletes in trunk/LayoutTests/imported/w3c

Clean imported/w3c/web-platform-tests folder
​https://bugs.webkit.org/show_bug.cgi?id=151190

Reviewed by Chris Dumez.

Adding missing files.
Removing resource files that are not needed anymore.
Removing some dangling expected.txt files.

• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/empty.html.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/empty.svg.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/empty.xhtml.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/empty.xml.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_mathml.html: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_mathml.svg: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_mathml.xhtml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_mathml.xml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_svg.html: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_svg.svg: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_svg.xhtml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_svg.xml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_xhtml.html: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_xhtml.svg: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_xhtml.xhtml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/bare_xhtml.xml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/generate.py: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/mathml.html: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/mathml.svg: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/mathml.xhtml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/mathml.xml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/minimal_html.html: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/minimal_html.svg: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/minimal_html.xhtml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/minimal_html.xml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/svg.html: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/svg.svg: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/svg.xhtml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/svg.xml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml.html: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml.svg: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml.xhtml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml.xml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml_ns_changed.html: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml_ns_changed.svg: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml_ns_changed.xhtml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml_ns_changed.xml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml_ns_removed.html: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml_ns_removed.svg: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml_ns_removed.xhtml: Removed.
• web-platform-tests/dom/nodes/resources/Document-createElement-namespace-tests/xhtml_ns_removed.xml: Removed.
• web-platform-tests/dom/nodes/resources/Node-parentNode-iframe.html: Removed.
• web-platform-tests/dom/nodes/resources/ParentNode-querySelector-All-content.html: Removed.
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01-expected.txt: Removed.
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script-expected.txt: Removed.
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_01-expected.txt: Removed.
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_02-expected.txt: Removed.
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_03-expected.txt: Removed.
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04-expected.txt: Removed.
• web-platform-tests/w3c-import.log:

2:21 AM Changeset in webkit [192466] by calvaris@igalia.com

• 10 edits in trunk

[Streams API] Update the implementation up to spec of Nov 11 2015
​https://bugs.webkit.org/show_bug.cgi?id=151195

Reviewed by Youenn Fablet.

Source/WebCore:

Updated the implementation of Readable and Writable Streams to the latest changes in the spec. Main changes are
the removal of the error and the state from the reader, readers are not automatically released and then minor or
style changes.

Implementation is up to date with version
​https://github.com/whatwg/streams/commit/48c8a3c30ea7e76c5e4eb9f157a438dd755bcc8e.

Tests: streams/reference-implementation/readable-stream-templated.html

streams/reference-implementation/readable-stream-reader.html

• Modules/streams/ReadableStream.js:

(getReader): Removed check for locked stream.

• Modules/streams/ReadableStreamInternals.js:

(privateInitializeReadableStreamReader): Removed setting @error and @state and initialized owner and owner's
reader as per spec.
(teeReadableStreamPullFunction): Added assertions.
(isReadableStreamReader): Added comment about resetting the reader owner to null instead of undefined as a means
to distinguish between not having the slot and having it unset.
(finishClosingReadableStream): Inline @closeReadableStreamReader as it is used only here now.
(readFromReadableStreamReader): Reworked the state and error to use the stream one and changed the conditions to
pull again as per spec.
(errorReadableStream): Not releasing the reader and removed the reader error and state management.
(releaseReadableStreamReader): Deleted.
(closeReadableStreamReader): Deleted.

• Modules/streams/ReadableStreamReader.js:

(cancel): Removed some checks and assertions as per spec.
(read): Added check for owner.
(releaseLock): No closing the reader and rejecting close promise and unlinking reader and owner instead.

• Modules/streams/WritableStream.js:

(abort): Style change.

• Modules/streams/WritableStreamInternals.js:

(writableStreamAdvanceQueue):
(closeWritableStream): Used @call instead of @apply.

LayoutTests:

Updated expectations.

• streams/reference-implementation/readable-stream-reader-expected.txt:
• streams/reference-implementation/readable-stream-templated-expected.txt:
• streams/reference-implementation/readable-stream-templated.html:

Nov 15, 2015:

11:42 PM Changeset in webkit [192465] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

64-bit in the DFG: non tail Calls unnecessarily store the argument count twice on the callee frame and tails calls unnecessarily store it once
​https://bugs.webkit.org/show_bug.cgi?id=151297

Reviewed by Geoffrey Garen.

Non tail calls only need to store the count once. Tail calls
never need to store the count on the callee frame because they
will be reusing the caller's frame.

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

2:00 PM Changeset in webkit [192464] by adam.bergkvist@ericsson.com

• 34 edits
  7 copies
  5 moves
  4 adds
  7 deletes in trunk

WebRTC: Update RTCPeerConnection API and introduce PeerConnectionBackend
​https://bugs.webkit.org/show_bug.cgi?id=150166

Reviewed by Eric Carlson and Youenn Fablet

Source/JavaScriptCore:

Added generic isDictionary() function to GlobalObject.js that tests if a
value can be interpreted as a dictionary.

• builtins/GlobalObject.js:

(isDictionary):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

Source/WebCore:

This change introduces PeerConnectionBackend which is a WebCore interface
that allows RTCPeerConnection to have platform abstractions at different
levels. For example, the MediaEndpoint interface [1] is a lower level
WebRTC backend abstraction where a big part of the WebRTC specification
is implemented in WebCore to be reusable. RTCPeerConnectionHandler (in
the repo today) is on the other hand a higher level WebRTC backend
abstraction where the calls are mostly forwarded directly to the
backend. The PeerConnectionBackend interface facilitates both approaches.

RTCPeerConnection

| (has)
|

PeerConnectionBackend

| |
| | (realizes)
| MediaEndpointPeerConnection
| | (has)
| |
| MediaEndpoint (platform interface)
|
| (realizes)

RTCPeerHandlerPeerConnection

| (has)
|

RCPeerConnectionHandler (existing platform interface)

Notable changes:

# Overloaded methods on RTCPeerConnection (Promise + legacy callback
signatures) are implemented with JSBuiltins.

# "Queued operations" ([1] Section 4.3.1) is implemented in JS bindings
with Promises.

# New RTCPeerConnection features

• add/removeTrack()
• pending/currentLocal/RemoteDescription attributes
• RTCRtpSender/Receiver

# Information carrying objects like RTCSessionDescription and
RTCCandidate don't encapsulate a "mirrored" platform object anymore.

# Remove RTCPeerConnection specific callback implementations (not used
with JS bindings)

[1] ​http://webkit.org/b/150165
[2] ​https://w3c.github.io/webrtc-pc/archives/20151006/webrtc.html

Tests: Mock should be added to test future WebRTC backend abstractions.

• CMakeLists.txt:
• DerivedSources.make:
• Modules/mediastream/PeerConnectionBackend.cpp: Added.

(WebCore::createPeerConnectionBackend):

• Modules/mediastream/PeerConnectionBackend.h: Added.

(WebCore::PeerConnectionBackendClient::~PeerConnectionBackendClient):
(WebCore::PeerConnectionBackend::~PeerConnectionBackend):

• Modules/mediastream/PeerConnectionStates.h: Added.
• Modules/mediastream/RTCConfiguration.cpp: Added.

(WebCore::validateIceServerURL):
(WebCore::parseIceServer):
(WebCore::RTCConfiguration::create):
(WebCore::RTCConfiguration::RTCConfiguration):
(WebCore::RTCConfiguration::initialize):

• Modules/mediastream/RTCConfiguration.h:

(WebCore::RTCConfiguration::iceTransportPolicy):
(WebCore::RTCConfiguration::bundlePolicy):
(WebCore::RTCConfiguration::iceServers):
(WebCore::RTCConfiguration::create): Deleted.
(WebCore::RTCConfiguration::appendServer): Deleted.
(WebCore::RTCConfiguration::numberOfServers): Deleted.
(WebCore::RTCConfiguration::server): Deleted.
(WebCore::RTCConfiguration::iceTransports): Deleted.
(WebCore::RTCConfiguration::setIceTransports): Deleted.
(WebCore::RTCConfiguration::requestIdentity): Deleted.
(WebCore::RTCConfiguration::setRequestIdentity): Deleted.
(WebCore::RTCConfiguration::privateConfiguration): Deleted.
(WebCore::RTCConfiguration::RTCConfiguration): Deleted.

• Modules/mediastream/RTCConfiguration.idl:
• Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::create):
(WebCore::RTCIceCandidate::RTCIceCandidate):
(WebCore::RTCIceCandidate::~RTCIceCandidate): Deleted.
(WebCore::RTCIceCandidate::candidate): Deleted.
(WebCore::RTCIceCandidate::sdpMid): Deleted.
(WebCore::RTCIceCandidate::sdpMLineIndex): Deleted.
(WebCore::RTCIceCandidate::descriptor): Deleted.

• Modules/mediastream/RTCIceCandidate.h:

(WebCore::RTCIceCandidate::~RTCIceCandidate):
(WebCore::RTCIceCandidate::candidate):
(WebCore::RTCIceCandidate::setCandidate):
(WebCore::RTCIceCandidate::sdpMid):
(WebCore::RTCIceCandidate::setSdpMid):
(WebCore::RTCIceCandidate::sdpMLineIndex):
(WebCore::RTCIceCandidate::setSdpMLineIndex):

• Modules/mediastream/RTCIceCandidate.idl:
• Modules/mediastream/RTCIceCandidateEvent.cpp:

(WebCore::RTCIceCandidateEvent::create):
(WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):

• Modules/mediastream/RTCIceCandidateEvent.h:
• Modules/mediastream/RTCIceServer.h:

(WebCore::RTCIceServer::urls):
(WebCore::RTCIceServer::credential):
(WebCore::RTCIceServer::username):
(WebCore::RTCIceServer::RTCIceServer):
(WebCore::RTCIceServer::create): Deleted.
(WebCore::RTCIceServer::privateServer): Deleted.

• Modules/mediastream/RTCOfferAnswerOptions.cpp:

(WebCore::RTCOfferAnswerOptions::RTCOfferAnswerOptions):
(WebCore::RTCOfferAnswerOptions::initialize):
(WebCore::RTCOfferOptions::RTCOfferOptions):
(WebCore::RTCOfferOptions::initialize):
(WebCore::RTCAnswerOptions::create):
(WebCore::RTCAnswerOptions::initialize):
(WebCore::RTCOfferAnswerOptions::create): Deleted.

• Modules/mediastream/RTCOfferAnswerOptions.h:

(WebCore::RTCOfferAnswerOptions::voiceActivityDetection):
(WebCore::RTCOfferOptions::offerToReceiveVideo):
(WebCore::RTCOfferOptions::offerToReceiveAudio):
(WebCore::RTCOfferOptions::iceRestart):
(WebCore::RTCAnswerOptions::RTCAnswerOptions):
(WebCore::RTCOfferAnswerOptions::requestIdentity): Deleted.
(WebCore::RTCOfferAnswerOptions::privateOfferAnswerOptions): Deleted.
(WebCore::RTCOfferAnswerOptions::RTCOfferAnswerOptions): Deleted.
(WebCore::RTCOfferOptions::voiceActivityDetection): Deleted.
(WebCore::RTCOfferOptions::privateOfferOptions): Deleted.
(WebCore::RTCOfferOptions::~RTCOfferOptions): Deleted.
(WebCore::RTCOfferOptions::RTCOfferOptions): Deleted.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::getSenders):
(WebCore::RTCPeerConnection::getReceivers):
(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::queuedCreateOffer):
(WebCore::RTCPeerConnection::queuedCreateAnswer):
(WebCore::RTCPeerConnection::queuedSetLocalDescription):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::currentLocalDescription):
(WebCore::RTCPeerConnection::pendingLocalDescription):
(WebCore::RTCPeerConnection::queuedSetRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):
(WebCore::RTCPeerConnection::currentRemoteDescription):
(WebCore::RTCPeerConnection::pendingRemoteDescription):
(WebCore::RTCPeerConnection::queuedAddIceCandidate):
(WebCore::RTCPeerConnection::signalingState):
(WebCore::RTCPeerConnection::iceGatheringState):
(WebCore::RTCPeerConnection::iceConnectionState):
(WebCore::RTCPeerConnection::setConfiguration):
(WebCore::RTCPeerConnection::privateGetStats):
(WebCore::RTCPeerConnection::createDataChannel):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::setSignalingState):
(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):
(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):
(WebCore::RTCPeerConnection::fireEvent):
(WebCore::validateIceServerURL): Deleted.
(WebCore::processIceServer): Deleted.
(WebCore::RTCPeerConnection::parseConfiguration): Deleted.
(WebCore::RTCPeerConnection::~RTCPeerConnection): Deleted.
(WebCore::RTCPeerConnection::createOffer): Deleted.
(WebCore::RTCPeerConnection::createAnswer): Deleted.
(WebCore::RTCPeerConnection::checkStateForLocalDescription): Deleted.
(WebCore::RTCPeerConnection::checkStateForRemoteDescription): Deleted.
(WebCore::RTCPeerConnection::setLocalDescription): Deleted.
(WebCore::RTCPeerConnection::setRemoteDescription): Deleted.
(WebCore::RTCPeerConnection::updateIce): Deleted.
(WebCore::RTCPeerConnection::addIceCandidate): Deleted.
(WebCore::RTCPeerConnection::addStream): Deleted.
(WebCore::RTCPeerConnection::removeStream): Deleted.
(WebCore::RTCPeerConnection::getLocalStreams): Deleted.
(WebCore::RTCPeerConnection::getRemoteStreams): Deleted.
(WebCore::RTCPeerConnection::getStreamById): Deleted.
(WebCore::RTCPeerConnection::getStats): Deleted.
(WebCore::RTCPeerConnection::hasLocalStreamWithTrackId): Deleted.
(WebCore::RTCPeerConnection::createDTMFSender): Deleted.
(WebCore::RTCPeerConnection::negotiationNeeded): Deleted.
(WebCore::RTCPeerConnection::didGenerateIceCandidate): Deleted.
(WebCore::RTCPeerConnection::didChangeSignalingState): Deleted.
(WebCore::RTCPeerConnection::didChangeIceGatheringState): Deleted.
(WebCore::RTCPeerConnection::didChangeIceConnectionState): Deleted.
(WebCore::RTCPeerConnection::didAddRemoteStream): Deleted.
(WebCore::RTCPeerConnection::didRemoveRemoteStream): Deleted.
(WebCore::RTCPeerConnection::didAddRemoteDataChannel): Deleted.
(WebCore::RTCPeerConnection::didAddOrRemoveTrack): Deleted.
(WebCore::RTCPeerConnection::changeSignalingState): Deleted.
(WebCore::RTCPeerConnection::changeIceGatheringState): Deleted.
(WebCore::RTCPeerConnection::changeIceConnectionState): Deleted.
(WebCore::RTCPeerConnection::scheduleDispatchEvent): Deleted.
(WebCore::RTCPeerConnection::scheduledEventTimerFired): Deleted.

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCPeerConnection.js: Added.

(createOffer):
(createAnswer):
(setLocalDescription):
(setRemoteDescription):
(addIceCandidate):
(getStats):

• Modules/mediastream/RTCPeerConnectionErrorCallback.h:

(WebCore::RTCPeerConnectionErrorCallback::~RTCPeerConnectionErrorCallback): Deleted.

• Modules/mediastream/RTCPeerConnectionInternals.js: Added.

(runNext):
(enqueueOperation):
(setLocalOrRemoteDescription):
(extractCallbackArg):

• Modules/mediastream/RTCRtpReceiver.cpp: Added.

(WebCore::RTCRtpReceiver::RTCRtpReceiver):

• Modules/mediastream/RTCRtpReceiver.h: Added.

(WebCore::RTCRtpReceiver::create):

• Modules/mediastream/RTCRtpReceiver.idl: Added.
• Modules/mediastream/RTCRtpSender.cpp: Added.

(WebCore::RTCRtpSender::RTCRtpSender):

• Modules/mediastream/RTCRtpSender.h: Added.

(WebCore::RTCRtpSender::create):
(WebCore::RTCRtpSender::mediaStreamId):

• Modules/mediastream/RTCRtpSender.idl: Added.
• Modules/mediastream/RTCRtpSenderReceiverBase.h: Added.

(WebCore::RTCRtpSenderReceiverBase::~RTCRtpSenderReceiverBase):
(WebCore::RTCRtpSenderReceiverBase::track):
(WebCore::RTCRtpSenderReceiverBase::RTCRtpSenderReceiverBase):

• Modules/mediastream/RTCSessionDescription.cpp:

(WebCore::RTCSessionDescription::create):
(WebCore::RTCSessionDescription::RTCSessionDescription):
(WebCore::RTCSessionDescription::setType):
(WebCore::RTCSessionDescription::~RTCSessionDescription): Deleted.
(WebCore::RTCSessionDescription::type): Deleted.
(WebCore::RTCSessionDescription::sdp): Deleted.
(WebCore::RTCSessionDescription::setSdp): Deleted.
(WebCore::RTCSessionDescription::descriptor): Deleted.

• Modules/mediastream/RTCSessionDescription.h:

(WebCore::RTCSessionDescription::~RTCSessionDescription):
(WebCore::RTCSessionDescription::type):
(WebCore::RTCSessionDescription::sdp):
(WebCore::RTCSessionDescription::setSdp):

• Modules/mediastream/RTCSessionDescriptionCallback.h:

(WebCore::RTCSessionDescriptionCallback::~RTCSessionDescriptionCallback): Deleted.

• Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp: Removed.

(WebCore::RTCSessionDescriptionRequestImpl::create): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::stop): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::activeDOMObjectName): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::canSuspendForPageCache): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::clear): Deleted.

• Modules/mediastream/RTCSessionDescriptionRequestImpl.h: Removed.
• Modules/mediastream/RTCStatsCallback.h: Removed.

(WebCore::RTCStatsCallback::~RTCStatsCallback): Deleted.

• Modules/mediastream/RTCStatsCallback.idl: Removed.
• Modules/mediastream/RTCStatsRequestImpl.cpp: Removed.

(WebCore::RTCStatsRequestImpl::create): Deleted.
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl): Deleted.
(WebCore::RTCStatsRequestImpl::~RTCStatsRequestImpl): Deleted.
(WebCore::RTCStatsRequestImpl::createResponse): Deleted.
(WebCore::RTCStatsRequestImpl::hasSelector): Deleted.
(WebCore::RTCStatsRequestImpl::track): Deleted.
(WebCore::RTCStatsRequestImpl::requestSucceeded): Deleted.
(WebCore::RTCStatsRequestImpl::requestFailed): Deleted.
(WebCore::RTCStatsRequestImpl::stop): Deleted.
(WebCore::RTCStatsRequestImpl::activeDOMObjectName): Deleted.
(WebCore::RTCStatsRequestImpl::canSuspendForPageCache): Deleted.
(WebCore::RTCStatsRequestImpl::clear): Deleted.

• Modules/mediastream/RTCStatsRequestImpl.h: Removed.
• Modules/mediastream/RTCTrackEvent.cpp: Added.

(WebCore::RTCTrackEventInit::RTCTrackEventInit):
(WebCore::RTCTrackEvent::create):
(WebCore::RTCTrackEvent::RTCTrackEvent):

• Modules/mediastream/RTCTrackEvent.h: Added.

(WebCore::RTCTrackEvent::receiver):
(WebCore::RTCTrackEvent::track):
(WebCore::RTCTrackEvent::eventInterface):

• Modules/mediastream/RTCTrackEvent.idl: Added.
• Modules/mediastream/RTCVoidRequestImpl.cpp: Removed.

(WebCore::RTCVoidRequestImpl::create): Deleted.
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl): Deleted.
(WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl): Deleted.
(WebCore::RTCVoidRequestImpl::requestSucceeded): Deleted.
(WebCore::RTCVoidRequestImpl::requestFailed): Deleted.
(WebCore::RTCVoidRequestImpl::stop): Deleted.
(WebCore::RTCVoidRequestImpl::activeDOMObjectName): Deleted.
(WebCore::RTCVoidRequestImpl::canSuspendForPageCache): Deleted.
(WebCore::RTCVoidRequestImpl::clear): Deleted.

• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

• bindings/js/JSDictionary.h:
• bindings/js/WebCoreBuiltinNames.h:
• bindings/js/WebCoreJSBuiltinInternals.h:

(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions):
(WebCore::JSBuiltinInternalFunctions::rTCPeerConnectionInternals):
(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::init):

• bindings/js/WebCoreJSBuiltins.cpp:
• bindings/js/WebCoreJSBuiltins.h:

(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::rTCPeerConnectionBuiltins):
(WebCore::JSBuiltinFunctions::rTCPeerConnectionInternalsBuiltins):

• dom/EventNames.in:

LayoutTests:

Updated expected results (listed below) with the new types added by
this change (RTCRtpSender, RTCRtpReceiver and RTCTrackEvent).

• platform/efl/js/dom/global-constructors-attributes-expected.txt:
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:

10:52 AM Changeset in webkit [192463] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Unreviewed, rolling out r192462.
​https://bugs.webkit.org/show_bug.cgi?id=151295

failing python tests (Requested by youenn on #webkit).

Reverted changeset:

"WPT server should use its own testharness.js file and
generate a warning when it does not match WebKit version"
​https://bugs.webkit.org/show_bug.cgi?id=150332
​http://trac.webkit.org/changeset/192462

10:17 AM Changeset in webkit [192462] by youenn.fablet@crf.canon.fr

• 2 edits in trunk/Tools

WPT server should use its own testharness.js file and generate a warning when it does not match WebKit version
​https://bugs.webkit.org/show_bug.cgi?id=150332

Reviewed by Darin Adler.

• Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(WebPlatformTestServer.init): Removed testharness.js as file to copy from WK to WPT.
(WebPlatformTestServer._copy_webkit_test_files): Added warning generation when WK testharness.js is not matching WPT version.

8:01 AM Changeset in webkit [192461] by youenn.fablet@crf.canon.fr

• 3 edits in trunk/LayoutTests

WebKit should not need to modify testharness.js
​https://bugs.webkit.org/show_bug.cgi?id=151262

Reviewed by Darin Adler.

• resources/testharness.js: Resetting global testharness.js timeout values to the default ones.
• resources/testharnessreport.js: Disabling global testharness.js timeout.

12:42 AM Changeset in webkit [192460] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r192404): Fix tvOS and watchOS builds

• platform/spi/cocoa/QuartzCoreSPI.h: Add more version checks to

fix all the builds.

Nov 14, 2015:

11:56 PM Changeset in webkit [192459] by Gyuyoung Kim

• 3 edits in trunk/Source/WebCore

[EFL][GTK] Remove use of String::format() in versionForUAString()
​https://bugs.webkit.org/show_bug.cgi?id=151250

Reviewed by Darin Adler.

As String::format() will be deprecated due to the security problem, reimplement
versionForUAString() using a macro.

• platform/efl/UserAgentEfl.cpp:

(WebCore::versionForUAString):

• platform/gtk/UserAgentGtk.cpp:

(WebCore::platformVersionForUAString):
(WebCore::versionForUAString):

9:23 PM Changeset in webkit [192458] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Regression(r188820): Downloads of data URLs is broken
​https://bugs.webkit.org/show_bug.cgi?id=150900
rdar://problem/23399223

Reviewed by Darin Adler.

No test, the current test infrastructure only allows testing policy decisions, not the actual download.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):

Use normal download path for data URLs instead of trying to convert the main resource load.
Since we decode data URLs locally there is no associated resource load on WebKit side.

6:40 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

5:18 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

3:51 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

1:13 PM Changeset in webkit [192457] by msaboff@apple.com

• 3 edits
  3 adds in trunk

REGRESSION (r190370): CrashTracer: [USER] com.apple.WebKit.WebContent at com.apple.JavaScriptCore: JSC::JITCode::execute + 158
​https://bugs.webkit.org/show_bug.cgi?id=151279

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

We need to restore callee saves even when we take the slow path in a polymorphic call stub.
Move the restoration to the top of the stub so that it is done for all paths.

• jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

LayoutTests:

New regression test.

• js/regress-151279-expected.txt: Added.
• js/regress-151279.html: Added.
• js/script-tests/regress-151279.js: Added.

1:09 PM BuildingQtOnLinux edited by BJ Burg

Add disclaimer about QT not existing any more in WebKit. (diff)

1:39 AM Changeset in webkit [192456] by n_wang@apple.com

• 11 edits
  2 adds in trunk

AX: add a new trait for elements in fieldset on iOS
​https://bugs.webkit.org/show_bug.cgi?id=151281

Reviewed by Chris Fleizach.

Source/WebCore:

Added a new trait for elements in the fieldset, so VoiceOver can speak the legend
information for those elements.

Test: accessibility/ios-simulator/fieldset-traits.html

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper _accessibilityTableAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityFieldsetAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):

Tools:

• DumpRenderTree/AccessibilityUIElement.cpp:

(assistiveTechnologySimulatedFocusCallback):
(fieldsetAncestorElementCallback):
(childAtIndexCallback):
(getElementTextLengthCallback):
(hasContainedByFieldsetTraitCallback):
(AccessibilityUIElement::getJSClass):

• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::elementTextLength):
(AccessibilityUIElement::hasContainedByFieldsetTrait):
(AccessibilityUIElement::fieldsetAncestorElement):
(AccessibilityUIElement::url):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::scrollPageDown):
(WTR::AccessibilityUIElement::scrollPageLeft):
(WTR::AccessibilityUIElement::scrollPageRight):
(WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
(WTR::AccessibilityUIElement::fieldsetAncestorElement):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::identifier):
(WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
(WTR::AccessibilityUIElement::fieldsetAncestorElement):
(WTR::AccessibilityUIElement::rowCount):

LayoutTests:

• accessibility/ios-simulator/fieldset-traits-expected.txt: Added.
• accessibility/ios-simulator/fieldset-traits.html: Added.

Nov 13, 2015:

9:51 PM Changeset in webkit [192455] by commit-queue@webkit.org

• 3 edits in trunk/PerformanceTests

Eliminate a request for layout every time an item is added to the stage of the graphics benchmark
​https://bugs.webkit.org/show_bug.cgi?id=151289

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-11-13
Reviewed by Simon Fraser.

Cache the stage size when it is created instead of requesting every time
an object is added via clientWidth and clientHeight.

• Animometer/resources/extensions.js:

(Insets.elementPadding):

• Animometer/tests/resources/stage.js:

(Stage):
(Stage.prototype.get size):

8:03 PM Changeset in webkit [192454] by commit-queue@webkit.org

• 5 edits
  2 deletes in trunk/Source

Unreviewed, rolling out r192445, r192451, and r192452.
​https://bugs.webkit.org/show_bug.cgi?id=151291

Broke Mavericks build (and thus EWS) (Requested by ap on
#webkit).

Reverted changesets:

"Add identifier strings for a bunch of context menu items"
​https://bugs.webkit.org/show_bug.cgi?id=151272
​http://trac.webkit.org/changeset/192445

"Try to fix the 32-bit build"
​http://trac.webkit.org/changeset/192451

"Try to fix the 32-bit build"
​http://trac.webkit.org/changeset/192452

5:18 PM Changeset in webkit [192453] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r192416 and r192443.
​https://bugs.webkit.org/show_bug.cgi?id=151285

Broke 32-bit in some mysterious way I need to understand
(Requested by kling on #webkit).

Reverted changesets:

"[JSC] JSPropertyNameEnumerator could be destructorless."
​https://bugs.webkit.org/show_bug.cgi?id=151242
​http://trac.webkit.org/changeset/192416

"Follow-up for 32-bit test failures after..."
​https://bugs.webkit.org/show_bug.cgi?id=151242
​http://trac.webkit.org/changeset/192443

4:56 PM Changeset in webkit [192452] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::createShareMenuItem):

4:41 PM Changeset in webkit [192451] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):

4:40 PM Changeset in webkit [192450] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r192401.
​https://bugs.webkit.org/show_bug.cgi?id=151282

"caused crashes on animometer" (Requested by thorton on
#webkit).

Reverted changeset:

"Restore CodeBlock jettison code I accidentally removed"
​https://bugs.webkit.org/show_bug.cgi?id=151241
​http://trac.webkit.org/changeset/192401

4:30 PM Changeset in webkit [192449] by keith_miller@apple.com

• 2 edits in trunk/Tools

Unreviewed, change JavaScriptCore watchlist to exclude inspector things.

• Scripts/webkitpy/common/config/watchlist:

4:05 PM Changeset in webkit [192448] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit2

WK2 iOS interaction tests in LayoutTests/fast/events/ios are flaky
​https://bugs.webkit.org/show_bug.cgi?id=151199
<rdar://problem/23518459>

Reviewed by Tim Horton.

While transforming touch positions from document to global coordinates, HIDEventGenerator
sometimes uses an old scale of the webview in computing the transformed position. This happens
in spite of how we force the UI script to run after the UI process receives a layer tree commit
because we invoke the callback before calling WebPageProxy::didCommitLayerTree, which is where
we actually use the layer transaction information to update the WKWebView.

To fix this, we run the drawing-ensured callbacks after committing the layer tree, so the
callbacks will have updated information about the web view's scale and dimensions.

• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

4:00 PM Changeset in webkit [192447] by timothy_horton@apple.com

• 7 edits in trunk

Support printing in WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=151276
<rdar://problem/23525715>

Reviewed by Beth Dakin.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _printOperationWithPrintInfo:]):
(-[WKWebView _printOperationWithPrintInfo:forFrame:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

Expose SPI similar to what we have on WKView.

• MiniBrowser/mac/MainMenu.xib:
• MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController printWebView:]):

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController printWebView:]):
Hook up printing to Minibrowser!

3:47 PM Changeset in webkit [192446] by Joseph Pecoraro

• 2 edits in trunk/Source/WebKit2

Follow-up to r192437. Add availability macros.

Reviewed by Tim Horton.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

3:37 PM Changeset in webkit [192445] by andersca@apple.com

• 5 edits
  2 adds in trunk/Source

Add identifier strings for a bunch of context menu items
​https://bugs.webkit.org/show_bug.cgi?id=151272

Reviewed by Dan Bernstein.

Source/WebCore:

Have NSMenuItem conform to NSUserInterfaceItemIdentification.

• platform/spi/mac/NSMenuSPI.h:

Source/WebKit2:

• UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm: Added.
• UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h: Added.
• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::createShareMenuItem):
(WebKit::WebContextMenuProxyMac::createContextMenuItem):

• WebKit2.xcodeproj/project.pbxproj:

3:11 PM Changeset in webkit [192444] by Alan Bujtas

• 12 edits in trunk

Always render at least a device pixel line when border/outline width > 0.
​https://bugs.webkit.org/show_bug.cgi?id=151269

This matches Firefox behaviour.

Reviewed by Simon Fraser.

Source/WebCore:

Existing test is modified to reflect the new behaviour.

• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertLineWidth):

• rendering/BorderEdge.cpp:

(WebCore::BorderEdge::BorderEdge): Deleted.

• rendering/BorderEdge.h:

LayoutTests:

• fast/borders/hidpi-border-width-flooring-expected.html:
• fast/borders/hidpi-border-width-flooring.html:

2:16 PM Changeset in webkit [192443] by akling@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Follow-up for 32-bit test failures after...
[JSC] JSPropertyNameEnumerator could be destructorless.
<​https://webkit.org/b/151242>

Reviewed by Mark Lam

Apparently copied space allocations need to be in multiples of 8 bytes.
Have JSPropertyNameEnumerator do what other copied space clients already do
and round the allocation size up to a multiple of 8.

Added a little helper function to compute the allocation size so this doesn't
have to be repeated everywhere.

• runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::finishCreation):
(JSC::JSPropertyNameEnumerator::visitChildren):
(JSC::JSPropertyNameEnumerator::copyBackingStore):

• runtime/JSPropertyNameEnumerator.h:

1:51 PM Changeset in webkit [192442] by bshafiei@apple.com

• 5 edits in branches/safari-601.1.46.60-branch/Source

Versioning.

1:49 PM Changeset in webkit [192441] by peavo@outlook.com

• 2 edits in trunk/Source/WebCore

[WinCairo][MediaFoundation] Video rendered at wrong position.
​https://bugs.webkit.org/show_bug.cgi?id=151271

Reviewed by Alex Christensen.

The source rectangle used when blitting a frame to the graphics context
should have offset (0, 0).

• platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::paintCurrentFrame):

1:47 PM Changeset in webkit [192440] by bshafiei@apple.com

• 1 copy in branches/safari-601.1.46.60-branch

New Branch.

1:36 PM Changeset in webkit [192439] by sbarati@apple.com

• 10 edits
  1 add in trunk/Source/JavaScriptCore

sub IC does not properly handle exception handling now that try/catch is compiled in the FTL
​https://bugs.webkit.org/show_bug.cgi?id=151080

Reviewed by Geoffrey Garen.

This patch implements proper exception handling for ArithSubs with binaryUseKind as
UntypedUse inside try/catch. We implement this in a very similar way as we implement
exception handling from GetById/PutById/LazySlowPaths callOperation calls. We do the needed
spilling if the result is the same register as the left/right register because in the event
of an exception, we don't want to do value recovery on the garbage result, we
want to do it on the original lhs/rhs of the operation.

This patch also does some refactoring. No longer does OSRExitDescriptor
have a long list of booleans that correspond to different OSR exit types.
It now just has an enum property called ExceptionType that tells us
what type of exception handler the OSR exit is. Then, we can just ask
interesting questions about the OSR exit and get answers based on its
ExceptionType property.

• ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

• ftl/FTLExceptionHandlerManager.cpp:

(JSC::FTL::ExceptionHandlerManager::addNewExit):
(JSC::FTL::ExceptionHandlerManager::callOperationExceptionTarget):
(JSC::FTL::ExceptionHandlerManager::lazySlowPathExceptionTarget):
(JSC::FTL::ExceptionHandlerManager::getByIdOSRExit):
(JSC::FTL::ExceptionHandlerManager::subOSRExit):
(JSC::FTL::ExceptionHandlerManager::getCallOSRExitCommon):
(JSC::FTL::ExceptionHandlerManager::getOrPutByIdCallOperationExceptionTarget): Deleted.

• ftl/FTLExceptionHandlerManager.h:
• ftl/FTLExitThunkGenerator.cpp:

(JSC::FTL::ExitThunkGenerator::emitThunk):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::lower):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutById):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::DFG::LowerDFGToLLVM::getById):
(JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitArgumentsForPatchpointIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::emitBranchToOSRExitIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::lowBlock):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitDescriptor):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToLLVM::buildExitArguments):

• ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExitDescriptor::OSRExitDescriptor):
(JSC::FTL::OSRExitDescriptor::willArriveAtExitFromIndirectExceptionCheck):
(JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromGenericUnwind):
(JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromCallOperation):
(JSC::FTL::OSRExitDescriptor::needsRegisterRecoveryOnGenericUnwindOSRExitPath):
(JSC::FTL::OSRExitDescriptor::isExceptionHandler):
(JSC::FTL::OSRExitDescriptor::validateReferences):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::gatherRegistersToSpillForCallIfException):
(JSC::FTL::OSRExit::spillRegistersToSpillSlot):
(JSC::FTL::OSRExit::recoverRegistersFromSpillSlot):

• ftl/FTLOSRExit.h:
• ftl/FTLOSRExitCompilationInfo.h:

(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):

• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

• tests/stress/ftl-try-catch-arith-sub-exception.js: Added.

(assert):
(let.o.valueOf):
(baz):
(foo):
(bar):

1:29 PM Changeset in webkit [192438] by bshafiei@apple.com

• 1 copy in tags/Safari-601.1.46.60

New tag.

11:46 AM Changeset in webkit [192437] by Joseph Pecoraro

• 15 edits in trunk/Source

Web Inspector: Provide a way to override the WKWebView remote inspector name
​https://bugs.webkit.org/show_bug.cgi?id=151075

Reviewed by Tim Horton.

Source/WebCore:

• page/Page.cpp:

(WebCore::Page::remoteInspectionNameOverride):
(WebCore::Page::setRemoteInspectionNameOverride):

• page/Page.h:
• page/PageDebuggable.cpp:

(WebCore::PageDebuggable::name):
(WebCore::PageDebuggable::setNameOverride):

• page/PageDebuggable.h:

Source/WebKit2:

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _remoteInspectionNameOverride]):
(-[WKWebView _setRemoteInspectionNameOverride:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setRemoteInspectionNameOverride):
(WebKit::WebPageProxy::creationParameters):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::remoteInspectionNameOverride):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldDispatchFakeMouseMoveEvents):
(WebKit::WebPage::setRemoteInspectionNameOverride):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

11:13 AM Changeset in webkit [192436] by commit-queue@webkit.org

• 10 edits
  3 adds in trunk/Source/JavaScriptCore

Allow any LeftHandSideExpression as a valid AssignmentElement
​https://bugs.webkit.org/show_bug.cgi?id=151026

Patch by Caitlin Potter <​caitpotter88@gmail.com> on 2015-11-13
Reviewed by Geoffrey Garen.

• bytecompiler/NodesCodegen.cpp:

(JSC::AssignmentElementNode::collectBoundIdentifiers):
(JSC::AssignmentElementNode::bindValue):
(JSC::AssignmentElementNode::toString):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::isAssignmentLocation):
(JSC::ASTBuilder::createAssignmentElement):

• parser/NodeConstructors.h:

(JSC::AssignmentElementNode::AssignmentElementNode):

• parser/Nodes.h:

(JSC::AssignmentElementNode::assignmentTarget):
(JSC::AssignmentElementNode::divotStart):
(JSC::AssignmentElementNode::divotEnd):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::createAssignmentElement):
(JSC::Parser<LexerType>::parseDestructuringPattern):

• parser/Parser.h:
• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::operatorStackPop):

11:10 AM Changeset in webkit [192435] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] GTK gardening.

Unreviewed.

• platform/gtk/TestExpectations: Update the expectation for a renamed

test and mark as failing some of the tests from imported/blink.

10:52 AM Changeset in webkit [192434] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

op_assert should declare that it uses the first register argument
​https://bugs.webkit.org/show_bug.cgi?id=151183

Reviewed by Geoffrey Garen.

op_assert(conditionRegister, lineNumber) should declare that it
*uses* (in terms of use-def) the first conditionRegister and
it does not define any variables.

• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

10:36 AM Changeset in webkit [192433] by jiewen_tan@apple.com

• 3 edits
  2 adds in trunk

Element::focus() should acquire the ownership of Frame.
​https://bugs.webkit.org/show_bug.cgi?id=150204
<rdar://problem/23136794>

Reviewed by Brent Fulgham.

Source/WebCore:

The FrameSelection::setSelection method sometimes releases the last reference to a frame.
When this happens, the Element::updateFocusAppearance would attempt to use dereferenced memory.
Instead, we should ensure that the Frame lifetime is guaranteed to extend through the duration
of the method call.

Test: editing/selection/focus-iframe-removal-crash.html

• dom/Element.cpp:

(WebCore::Element::updateFocusAppearance):

LayoutTests:

• editing/selection/focus-iframe-removal-crash-expected.txt: Added.
• editing/selection/focus-iframe-removal-crash.html: Added.

10:11 AM Changeset in webkit [192432] by timothy_horton@apple.com

• 15 edits
  2 adds in trunk

Hardware keyboard spacebar scrolls too far on iOS
​https://bugs.webkit.org/show_bug.cgi?id=151227
<rdar://problem/23500681>

Reviewed by Simon Fraser.

There were two bugs conspiring here to make spacebar scrolling very wrong on iOS:

1) Incoming key events were being handled twice

• fix this by only propagating the event to super if we don't end up handling the event ourselves

2) _scrollByOffset was not converting the offset delta out of content coordinates

• fix this by doing the relevant conversion and renaming the function to make it more clear exactly what it does

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _scrollByOffset:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewInternal.h:

Rename to _scrollByContentOffset to make it clear that this is
in content coordinates, and do the conversion from content coordinates
(apply the scale) so that we scroll by the right amount.

• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::doneWithKeyEvent):
Pass whether the event was handled through to WKContentView.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKWebEvent dealloc]):
Add WKWebEvent, which is a WebEvent and retains a reference to the UIEvent
from which it came.

(-[WKContentView _handleKeyUIEvent:]):
Only pass the event to super immediately if we don't try to handle it.
We'll re-send it to super asynchronously if we decide not to handle it.

(-[WKContentView handleKeyEvent:]):
If we're in the middle of resending an event we didn't handle the first
time, just ignore it.

Make a WKWebEvent and store the UIEvent on it.

(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
If the event wasn't handled, and is one of our special events with a
wrapped UIEvent, resend it to super. We'll ignore it as noted above.

(-[WKContentView _interpretKeyEvent:isCharEvent:]):
Factor out unobscured content rect retrieval.
Make use of Scrollbar::pageStep to match the Mac behavior of not
scrolling quite a whole page when scrolling with the spacebar.

• fast/events/ios/keyboard-scrolling-distance-expected.txt: Added.
• fast/events/ios/keyboard-scrolling-distance.html: Added.

Add a test that records how much we scroll when pressing the spacebar.
The test is at a fixed scale of 1.5 to expose the bug fixed by this patch.

• WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
• WebKitTestRunner/UIScriptContext/UIScriptContext.h:
• WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setDidEndScrollingCallback):
(WTR::UIScriptController::didEndScrollingCallback):
(WTR::UIScriptController::platformSetDidEndScrollingCallback):

• WebKitTestRunner/UIScriptContext/UIScriptController.h:
• WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
• WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView dealloc]):
(-[TestRunnerWKWebView _didFinishScrolling]):

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::platformSetDidEndScrollingCallback):
(WTR::UIScriptController::platformClearAllCallbacks):
Expose _didFinishScrolling on WKWebView to the UIScriptController.

10:08 AM Changeset in webkit [192431] by Brent Fulgham

• 2 edits in trunk/Tools

[Win] Unreviewed test fix.

• Scripts/webkitpy/port/win.py:

(WinPort.results_directory): Our 'results_directory' should be an absolute path (even when not
using Cygwin), but should be in DOS format for non-Cygwin clients.

9:56 AM Changeset in webkit [192430] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Removing a deleted test from mac-wk2 test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=151103

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:03 AM Changeset in webkit [192429] by matthew_hanson@apple.com

• 8 edits in branches/safari-601.1.46-branch

Merge r192269. rdar://problem/23189742

9:03 AM Changeset in webkit [192428] by matthew_hanson@apple.com

• 3 edits
  2 adds in branches/safari-601.1.46-branch

Merge r192120. rdar://problem/23189774

9:03 AM Changeset in webkit [192427] by matthew_hanson@apple.com

• 7 edits
  2 adds in branches/safari-601.1.46-branch

Merge r192042. rdar://problem/23189765

9:03 AM Changeset in webkit [192426] by matthew_hanson@apple.com

• 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r191872. rdar://problem/23395972

9:03 AM Changeset in webkit [192425] by matthew_hanson@apple.com

• 4 edits
  2 adds in branches/safari-601.1.46-branch

Merge r190595. rdar://problem/23432378

9:03 AM Changeset in webkit [192424] by matthew_hanson@apple.com

• 8 edits
  2 adds in branches/safari-601.1.46-branch

Merge r190446. rdar://problem/23432369

9:03 AM Changeset in webkit [192423] by matthew_hanson@apple.com

• 79 edits
  2 copies
  1 add in branches/safari-601.1.46-branch

Merge r188647. rdar://problem/23432373

9:03 AM Changeset in webkit [192422] by matthew_hanson@apple.com

• 18 edits
  4 adds in branches/safari-601.1.46-branch

Merge r188530. rdar://problem/23432371

9:03 AM Changeset in webkit [192421] by matthew_hanson@apple.com

• 8 edits
  5 adds in branches/safari-601.1.46-branch

Merge r188514. rdar://problem/23432371

9:02 AM Changeset in webkit [192420] by matthew_hanson@apple.com

• 18 edits
  4 adds in branches/safari-601.1.46-branch

Merge r188512. rdar://problem/23432371

9:02 AM Changeset in webkit [192419] by matthew_hanson@apple.com

• 7 edits in branches/safari-601.1.46-branch/Source

Merge r190574. rdar://problem/22846841

9:02 AM Changeset in webkit [192418] by matthew_hanson@apple.com

• 4 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r189635. rdar://problem/22846841

9:02 AM Changeset in webkit [192417] by matthew_hanson@apple.com

• 4 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r189628. rdar://problem/22846841

7:59 AM Changeset in webkit [192416] by akling@apple.com

• 4 edits in trunk/Source/JavaScriptCore

[JSC] JSPropertyNameEnumerator could be destructorless.
<​https://webkit.org/b/151242>

Reviewed by Mark Lam.

Make JSPropertyNameEnumerator destructorless and have it store the property names
cache in CopiedSpace. This was the most popular occupant of 64-byte destructor cells
in MarkedSpace, so making it destructorless gets rid of some ill-filled MarkedBlocks.

• heap/CopyToken.h:
• runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::finishCreation):
(JSC::JSPropertyNameEnumerator::visitChildren):
(JSC::JSPropertyNameEnumerator::copyBackingStore):
(JSC::JSPropertyNameEnumerator::destroy): Deleted.

• runtime/JSPropertyNameEnumerator.h:

5:49 AM WebKitGTK/Gardening/Howto edited by clopez@igalia.com

(diff)

4:50 AM Changeset in webkit [192415] by svillar@igalia.com

• 3 edits in trunk/LayoutTests

[css-grid] Fix swap-lines-if-start-is-further-endward-than-end-line.html
​https://bugs.webkit.org/show_bug.cgi?id=151257

Reviewed by Mario Sanchez Prada.

I forgot to add a link to resources/grid.css stylesheet when I
added this test so it was not actually testing Grid Layout
code.

• fast/css-grid-layout/swap-lines-if-start-is-further-endward-than-end-line-expected.html:
• fast/css-grid-layout/swap-lines-if-start-is-further-endward-than-end-line.html:

4:48 AM Changeset in webkit [192414] by svillar@igalia.com

• 3 edits in trunk/Source/WebCore

[css-grid] Remove unused GridResolvedPosition constructor
​https://bugs.webkit.org/show_bug.cgi?id=151133

Reviewed by Mario Sanchez Prada.

No new tests required, just deleting dead code.

• rendering/style/GridResolvedPosition.cpp:

(WebCore::GridResolvedPosition::GridResolvedPosition): Deleted.

• rendering/style/GridResolvedPosition.h:

3:13 AM Changeset in webkit [192413] by svillar@igalia.com

• 4 edits
  2 adds in trunk

ASSERTION FAILED: m_isEngaged in WTF::Optional::value
​https://bugs.webkit.org/show_bug.cgi?id=151094

Reviewed by Darin Adler.

Source/WebCore:

That ASSERT was hit because the precondition was incorrectly
met, i.e., we're considering that the main axis length was
definite when it was actually not. The problem is that to
determine whether it was indefinite or not we're using
RenderBox::hasDefiniteLogicalHeight() which did not perfectly
match RenderBox::computePercentageLogicalHeight() for the case
of RenderTables. So computePercentageLogicalHeight() was
returning Nullopt (i.e. indefinite) while
hasDefiniteLogicalHeight() was returning true (so definite).

Some checks were refactored in a helper function to solve the
inconsistency so that both functions behave the same way even
in this particular situation.

Test: css3/flexbox/inline-flex-percentage-height-in-table-crash.html

• rendering/RenderBox.cpp:

(WebCore::tableCellShouldHaveZeroInitialSize):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::percentageLogicalHeightIsResolvable):
(WebCore::RenderBox::percentageLogicalHeightIsResolvableFromBlock):

• rendering/RenderBox.h:

LayoutTests:

• css3/flexbox/inline-flex-percentage-height-in-table-crash-expected.txt: Added.
• css3/flexbox/inline-flex-percentage-height-in-table-crash.html: Added.

2:47 AM Changeset in webkit [192412] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Unreviewed, really fix the Mac CMake build after r192376.

• PlatformMac.cmake:

2:43 AM Changeset in webkit [192411] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Unreviewed, fix the Mac CMake build after r192376.

• PlatformMac.cmake: