Timeline
Jul 16, 2017:
- 11:58 PM Changeset in webkit [219553] by
-
- 3 edits in trunk/Source/WebCore
-Wreorder warning caused by GraphicsContext3D cleanup
https://bugs.webkit.org/show_bug.cgi?id=174511
Reviewed by Carlos Garcia Campos.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 10:29 PM Changeset in webkit [219552] by
-
- 6 edits4 adds in trunk
Dismissing the captions panel using the mouse is too eager to remove the captions panel and media controls
https://bugs.webkit.org/show_bug.cgi?id=174571
<rdar://problem/33294968>
Patch by Antoine Quint <Antoine Quint> on 2017-07-16
Reviewed by Eric Carlson.
Source/WebCore:
We did several things wrong when dismissing the tracks panel:
- we did not check whether we were hosted in a shadow root when figuring if a click was on the tracks panel
- we did not check whether we clicked over the media when dismissing the tracks panel
- we did not check whether auto-hide was on before fading the media controls out when we clicked outside the media controls bounds
We now correctly account for all of those cases and implement the following behavior when clickng as the tracks
panel is presented:
- dismiss the panel if the click is outside of the panel
- dismiss the panel and the media controls if the click is outside the video and the media controls have auto-hide on (ie. media is playing)
- dismiss the panel and the media controls after the track selection animation is finished if a track is selected
Tests: media/modern-media-controls/tracks-panel/tracks-panel-up-click-outside-media-does-not-dimiss-media-controls-when-media-is-paused.html
media/modern-media-controls/tracks-panel/tracks-panel-up-click-over-media-does-not-dimiss-media-controls-when-media-is-playing.html
- Modules/modern-media-controls/controls/media-controls.js:
(MediaControls.prototype.hideTracksPanel): Only hide the media controls if we clicked outside of the media
controls bounds and if we have auto-hide on when idle (ie. the media is playing).
(MediaControls.prototype.isPointInControls): Add an option to specify whether the container should be
considered when checking if a point is contained within the media controls bounds.
- Modules/modern-media-controls/controls/tracks-panel.js:
(TracksPanel.prototype._handleMousedown):
(TracksPanel.prototype._isPointInTracksPanel): Correctly check whether the element that we started pressing
on is contained within the tracks panel, accounting for the case where we are presented within a shadow root
(ie. always when runing inside a Web page).
LayoutTests:
Adding a method to show the tracks panel for a given shadow root and adding new tests to check the correct
behavior when dismissing the tracks panel when clicking over the media element or outside the media element
when it's paused.
- media/modern-media-controls/resources/media-controls-utils.js:
(pressOnElement):
(pressAtPoint):
(showTracksPanel):
(finishMediaControlsTest): Deleted.
- media/modern-media-controls/tracks-panel/tracks-panel-up-click-outside-media-does-not-dimiss-media-controls-when-media-is-paused-expected.txt: Added.
- media/modern-media-controls/tracks-panel/tracks-panel-up-click-outside-media-does-not-dimiss-media-controls-when-media-is-paused.html: Added.
- media/modern-media-controls/tracks-panel/tracks-panel-up-click-over-media-does-not-dimiss-media-controls-when-media-is-playing-expected.txt: Added.
- media/modern-media-controls/tracks-panel/tracks-panel-up-click-over-media-does-not-dimiss-media-controls-when-media-is-playing.html: Added.
- platform/mac/TestExpectations:
- 7:10 PM Changeset in webkit [219551] by
-
- 6 edits2 adds in trunk
DisallowUserAgentShadowContent moves out of non-UA shadow roots
https://bugs.webkit.org/show_bug.cgi?id=165647
Patch by Ali Juma <ajuma@chromium.org> on 2017-07-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
Make rect-based hit-testing include nodes in non-UA shadow trees when the
HitTestRequest has type DisallowUserAgentShadowContent.
Test: fast/dom/nodesFromRect/nodesFromRect-shadow.html
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
- testing/Internals.h:
LayoutTests:
- fast/dom/nodesFromRect/nodesFromRect-shadow-expected.txt: Added.
- fast/dom/nodesFromRect/nodesFromRect-shadow.html: Added.
- fast/dom/nodesFromRect/resources/nodesFromRect.js:
(check):
(checkShadowContent):
(nodesFromRectAsString):
- 6:43 PM Changeset in webkit [219550] by
-
- 5 edits in trunk
Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
<rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
Reviewed by Tim Horton.
Source/WebKit:
Instead of holding a weak reference to its owning API::WebsiteDataStore,
API::HTTPCookieStore can hold a strong reference to the owner's implementation
WebKit::WebsiteDataStore.
- UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::HTTPCookieStore):
(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::setCookie):
(API::HTTPCookieStore::deleteCookie):
(API::HTTPCookieStore::registerObserver):
(API::HTTPCookieStore::unregisterObserver):
(API::HTTPCookieStore::cookieManagerDestroyed):
(API::HTTPCookieStore::registerForNewProcessPoolNotifications):
- UIProcess/API/APIHTTPCookieStore.h:
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
(-[CookieNavigationDelegate webView:didFinishNavigation:]):
(TEST):
- 3:23 PM Changeset in webkit [219549] by
-
- 4 edits2 adds in trunk
Clicking edges of media control buttons changes visual state of button (pressed) but doesn't execute action
https://bugs.webkit.org/show_bug.cgi?id=174565
<rdar://problem/33294833>
Patch by Antoine Quint <Antoine Quint> on 2017-07-16
Reviewed by Dean Jackson.
Source/WebCore:
WebCore doesn't dispatch a "click" event to a parent element when a child that was the original target when
the "mousedown" occured is no longer hit-testing at the location where the mouse pointer is at when the "mouseup"
occurs (see webkit.org/b/174564). Since button icons, which are a <picture> element that is a child of the
<button> element for media controls buttons, shrink to 89% of their size when the ":active" pseudo-class matches,
clicking on the edges of the media controls buttons would not trigger the expected action.
Test: media/modern-media-controls/button/button-click-on-edges.html
- Modules/modern-media-controls/controls/button.css:
(button > picture):
LayoutTests:
Add a new test where we click on the edge of a button and check that we trigger the Button's
UI delegate. This test fails prior to this patch.
- media/modern-media-controls/button/button-click-on-edges-expected.txt: Added.
- media/modern-media-controls/button/button-click-on-edges.html: Added.
- platform/ios-simulator/TestExpectations:
- 2:36 PM Changeset in webkit [219548] by
-
- 11 edits in trunk/Source/WebCore
Make the decision for asynchronously decoding an image be in one place
https://bugs.webkit.org/show_bug.cgi?id=174479
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-07-16
Reviewed by Tim Horton.
Move all the logic of whether a large image should be asynchronously decoded
or not be in one place: RenderBoxModelObject::decodingModeForImageDraw().
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::addPendingImageDrawingClient): Fixing unrelated
spelling error.
- platform/RuntimeApplicationChecks.h:
- platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isIBooks):
(WebCore::IOSApplication::isIBooksStorytime):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::updateFromSettings): Remove reading the setting
largeImageAsyncDecodingEnabled from this function because it will be read
by RenderBoxModelObject::decodingModeForImageDraw().
(WebCore::BitmapImage::dataChanged):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::shouldAnimate):
(WebCore::BitmapImage::canAnimate):
(WebCore::BitmapImage::canUseAsyncDecodingForLargeImages):
(WebCore::BitmapImage::shouldUseAsyncDecodingForAnimatedImages):
(WebCore::BitmapImage::canDestroyDecodedData):
(WebCore::BitmapImage::shouldUseAsyncDecodingForLargeImages): Deleted.
- platform/graphics/BitmapImage.h:
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::canUseAsyncDecoding): It is okay to keep the
decoded frame if canUseAsyncDecodingForLargeImages() is true by the setting
largeImageAsyncDecodingEnabled is false.
(WebCore::ImageSource::shouldUseAsyncDecoding): Deleted.
- platform/graphics/ImageSource.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::decodingModeForImageDraw): The plan is to
add a new Internal settings to force asynchronous image decoding regardless
of the image size and the settings.
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderBoxModelObject.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
- 7:28 AM Changeset in webkit [219547] by
-
- 7 edits in trunk
[CMake] Raise minimum CMake requirement
https://bugs.webkit.org/show_bug.cgi?id=174545
Reviewed by Konstantin Tokarev.
.:
- CMakeLists.txt:
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsJSCOnly.cmake:
Source/WebCore:
- WebCoreMacros.cmake:
- 5:51 AM Changeset in webkit [219546] by
-
- 2 edits in trunk/Tools
[GTK] Sort inspector GResource manifest to ensure reproducible builds
https://bugs.webkit.org/show_bug.cgi?id=174540
Patch by Bernhard M. Wiedemann <bwiedemann@suse.de> on 2017-07-16
Reviewed by Michael Catanzaro.
- gtk/generate-inspector-gresource-manifest.py:
(get_filenames): sort list of input files
Jul 15, 2017:
- 11:57 PM Changeset in webkit [219545] by
-
- 11 edits2 adds in trunk
Make sure all CFHTTPCookieStorageRefs we create are scheduled.
<rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
Reviewed by Tim Horton.
Source/WebCore:
- platform/spi/cf/CFNetworkSPI.h:
Source/WebKit:
Whenever we create a CFHTTPCookieStorage from identifying data it is unscheduled.
We need to schedule it on the appropriate RunLoop.
This patch also cleans up the creation of the identifying data itself.
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
- Shared/cf/CookieStorageUtilsCF.h: Added.
- Shared/cf/CookieStorageUtilsCF.mm: Added.
(WebKit::cookieStorageFromIdentifyingData):
(WebKit::identifyingDataFromCookieStorage):
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setSharedHTTPCookieStorage):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
(TEST): Make this test more reliable by clearing everything beforehand.
- 11:08 PM Changeset in webkit [219544] by
-
- 18 edits in trunk/Source/WebCore
Rename RenderStyle::fontSize() to RenderStyle::computedFontPixelSize()
https://bugs.webkit.org/show_bug.cgi?id=174509
Reviewed by Simon Fraser.
We have three font size functions:
- computedFontSize(): returns a float
- specifiedFontSize(): also returns a float
- fontSize(): returns the rounded computedFontSize()
FontDescription uses the convention of labelling rounded values as "pixel",
so a better name font fontSize() is computedFontPixelSize().
Also, because font sizes can never be negative, switch the type from an int
to an unsigned.
No new tests because there is no behavior change.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::computedPixelSize):
(WebCore::FontDescription::fontSelectionRequest):
- rendering/RenderBlock.cpp:
(WebCore::styleForFirstLetter):
- rendering/RenderRubyRun.cpp:
(WebCore::shouldOverhang):
(WebCore::RenderRubyRun::getOverhang):
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):
- rendering/RenderThemeGtk.cpp:
(WebCore::adjustSearchFieldIconStyle):
(WebCore::paintSearchFieldIcon):
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustCheckboxStyle):
(WebCore::RenderThemeIOS::adjustRadioStyle):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::controlSizeForFont):
(WebCore::RenderThemeMac::controlSizeForSystemFont):
(WebCore::RenderThemeMac::paintMenuListButtonDecorations):
(WebCore::RenderThemeMac::popupInternalPaddingBox):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
- rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintTextDecoration):
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computeLineVerticalStretch):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::computedFontPixelSize):
(WebCore::RenderStyle::computedLineHeight):
(WebCore::RenderStyle::fontSize): Deleted.
- rendering/style/RenderStyle.h:
- style/InlineTextBoxStyle.cpp:
(WebCore::visualOverflowForDecorations):
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEMS):
(WebCore::SVGLengthContext::convertValueFromEMSToUserUnits):
- 10:52 PM Changeset in webkit [219543] by
-
- 4 edits2 adds in trunk
line-height: <number> gets visually applied twice when text autosizing is in effect
https://bugs.webkit.org/show_bug.cgi?id=174536
<rdar://problem/33338259>
Reviewed by Simon Fraser.
Source/WebCore:
StyleBuilderConverter::convertLineHeight() converts line-height: <number> into a
"percentage" length. Then, when layout needs to know what the computed value of
line-height is, RenderStyle::computedLineHeight() multiplies this percentage by
the computed font size.
With autosizing, the computed font size already incorporates the autosizing
multiplier, so we shouldn't also incorporate this multiplier into the percentage
value itself. getComputedStyle()'s lineHeightFromStyle() was compensating for
this double application by multiplying the percentage by the font-size's specified
value instead of its computed value, which is incorrect.
Test: fast/text-autosizing/line-height-number.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::lineHeightFromStyle):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertLineHeight):
LayoutTests:
- fast/text-autosizing/line-height-number-expected.html: Added.
- fast/text-autosizing/line-height-number.html: Added.
- 9:47 PM Changeset in webkit [219542] by
-
- 2 edits in trunk/Tools
Make it possible to extend check-webkit-style with Apple-internal checkers
<https://webkit.org/b/174464>
<rdar://problem/25564402>
Reviewed by Darin Adler.
- Scripts/webkitpy/style/checker.py: Import apple_additions.
(_all_categories): Add categories from apple_additions() if it
exists.
(CheckerDispatcher._create_checker): Create python checker
from apple_additions() if it exists.
- 9:01 PM Changeset in webkit [219541] by
-
- 9 edits2 adds in trunk
[iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
https://bugs.webkit.org/show_bug.cgi?id=174539
<rdar://problem/33307395>
Reviewed by Darin Adler.
Source/WebCore:
Currently, if TextIndicator fails to take a snapshot in TextIndicator::createWithRange, we will enter an
inconsistent state in the web process where Editor will continue to ignore selection changes until the next time
Editor::setIgnoreSelectionChanges(false) is called. This causes us to indefinitely defer EditorState updates to
the UI process, which leads to selection UI appearing unresponsive.
To fix this, we introduce a new TemporarySelectionChange object to simplify selection changes and/or
EditorState-update-ignoring behaviors within the scope of a single function. The constructor applies these
temporary changes, and the destructor reverts them as needed to their prior values.
This patch only adopts TemporarySelectionChange in order to fix this bug, but future patches will replace the
remaining places where we temporarily change selection and/or ignore selection with this helper.
Test: ActionSheetTests.ImageMapDoesNotDestroySelection.
- editing/Editor.cpp:
(WebCore::TemporarySelectionChange::TemporarySelectionChange):
(WebCore::TemporarySelectionChange::~TemporarySelectionChange):
- editing/Editor.h:
- editing/FrameSelection.h:
(WebCore::FrameSelection::isUpdateAppearanceEnabled):
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithRange):
Source/WebKit:
Small tweak to avoid presenting at the element rect or text rect if the interaction information failed to
capture valid bounds for the element. We instead fall back to presenting at the touch location. This addresses
problems when presenting the action sheet popover on image maps on iPad, where GetPositionInformation fails to
capture correct data about for the <area>.
- UIProcess/ios/WKActionSheetAssistant.mm:
(presentationStyleForView):
Tools:
Adds a new unit test suite to cover action sheet popover presentation.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
- TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
(-[ActionSheetObserver waitForActionSheetAfterBlock:]):
Runs the given block and waits until the UI process has indicated that it will present an action sheet.
(-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
(TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
(TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
(TestWebKitAPI::TEST):
- 8:45 PM Changeset in webkit [219540] by
-
- 2 edits in trunk/Tools
[Scripts] Make svn-create-patch work better when called in sub directories
https://bugs.webkit.org/show_bug.cgi?id=174551
Reviewed by Darin Adler.
- Fixes manufacturePatchForAdditionWithHistory to use the correct path by ensuring that the prefix is applied as is done in generateDiff.
- Silence output of explanatory lines from svn stat (" > move to ...") that show up in STDERR when running svn-create-patch.
- Add verbose logging that I found useful while debugging this issue.
- Scripts/svn-create-patch:
(findBaseUrl):
(findMimeType):
(findSourceFileAndRevision):
(generateDiff):
(generateFileList):
(manufacturePatchForAdditionWithHistory):
- 3:03 PM Changeset in webkit [219539] by
-
- 4 edits in trunk/Source/WebCore
Clean up line-height and minimumFontSize functions
https://bugs.webkit.org/show_bug.cgi?id=174535
Reviewed by Simon Fraser.
No behavior change.
No new tests because there is no behavior change.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertLineHeight):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::cascadedPropertiesForRollback):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::checkForZoomChange):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::CascadedProperties::set):
(WebCore::StyleResolver::applyCascadedProperties):
- style/StyleFontSizeFunctions.cpp:
(WebCore::Style::computedFontSizeFromSpecifiedSize):
(WebCore::Style::computedFontSizeFromSpecifiedSizeForSVGInlineText):
(): Deleted.
- 2:47 PM Changeset in webkit [219538] by
-
- 2 edits in trunk/Tools
Unreviewed build fix after r219537.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
Jul 14, 2017:
- 10:41 PM Changeset in webkit [219537] by
-
- 22 edits1 copy in trunk
Add iOS 11 SPI
https://bugs.webkit.org/show_bug.cgi?id=174430
<rdar://problem/33269288>
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Add sqlite3SPI.h header.
- platform/ios/PlatformPasteboardIOS.mm: Move UIKit SPI to UIKitSPI.h.
- platform/ios/WebItemProviderPasteboard.mm: Ditto.
- platform/network/cf/FormDataStreamCFNet.cpp: Explicitly define fnfErr and remove
MacErrors.h header for iOS.
- platform/spi/cocoa/IOSurfaceSPI.h: IOSurface is no longer SPI in iOS 11.
- platform/spi/cocoa/PassKitSPI.h: Do not re-define setRequiredShippingContactFields
and setRequiredBillingContactFields in iOS 11.
- platform/spi/cocoa/QuartzCoreSPI.h: Added QuartzCoreSPI used in iOS 11.
- platform/spi/ios/UIKitSPI.h: Add drag-and-drop SPI.
- platform/spi/ios/sqlite3SPI.h: Define required sqlite3 macros.
- platform/sql/SQLiteFileSystem.cpp: Use sqlite3SPI.h.
Source/WebKit:
- Platform/spi/ios/UIKitSPI.h: Add drag-and-drop SPI for iOS 11.
- UIProcess/ios/WKContentViewInteraction.mm: Move UIKit SPI to UIKitSPI.h.
Source/WebKitLegacy:
- Storage/StorageTracker.cpp: sqlite3_private.h no longer exists in the iOS
Simulator SDK, explicitly define the required macro.
Source/WTF:
- Configurations/WTF.xcconfig: Exclude MachExceptions.def when building iOS 11 for
the iOS simulator.
Tools:
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
- TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
- TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
- 10:23 PM Changeset in webkit [219536] by
-
- 4 edits in trunk
[GCrypt] Implement CryptoKeyRSA PKCS#8 exports
https://bugs.webkit.org/show_bug.cgi?id=173697
Reviewed by Jiewen Tan.
Source/WebCore:
Implement the PKCS#8 import operation for RSA keys for platforms that use
libgcrypt.
In CryptoKeyRSA::exportPkcs8(), we bail early with an invalid access exception if
this export is not being done for a private key. Otherwise, we start with creating
theRSAPrivateKeyASN.1 structure, writing out '0' under theversionelement
and then retrieving the modulus, public and private exponent and both primes.
MPI data for those parameters is written out into corresponding elements in the
RSAPrivateKeystructure. We then manually compute values of both exponents and
the coefficient parameters, using the private exponent's and both primes' MPI
values. The p and q parameters (i.e. the primes) are switched in libgcrypt,
deviating from the standard practice, so we have to operate with those two
accordingly. We eliminate the optionalotherPrimeInfosattribute on the
RSAPrivateKeystructure. Support for this attribute will be added later.
We then create the
PrivateKeyInfoASN.1 structure, and write out '0' under the
versionelement. The id-rsaEncryption object identifier is written out under
thealgorithm.algorithmelement. In the future, an object identifier that
matches this key's algorithm will have to be written out here (id-RSASSA-PSS or
id-RSAES-OAEP), along with the appropriate parameters structure, but no test in
WebKit or the web-platform-tests suite covers this detail. For now, a null value
is written out under thealgorithm.parameterselement.
Data for the
RSAPrivateKeystructure is retrieved and written out under the
privateKeyelement. The optionalattributeselement on thePrivateKeyInfo
structure is eliminated.
Data that was encoded through the
PrivateKeyInfostructure is then retrieved
and returned from the exportPkcs8() method.
No new tests -- related tests are now passing and are unskipped.
- crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:
(WebCore::CryptoKeyRSA::exportPkcs8):
LayoutTests:
- platform/gtk/TestExpectations: Unskip the RSA PKCS#8 export tests
- 10:20 PM Changeset in webkit [219535] by
-
- 4 edits in trunk
[GCrypt] Implement CryptoKeyRSA PKCS#8 imports
https://bugs.webkit.org/show_bug.cgi?id=173696
Reviewed by Jiewen Tan.
Source/WebCore:
Implement the PKCS#8 import operation for RSA keys for platforms that use
libgcrypt.
In CryptoKeyRSA::importPkcs8(), the provided key data is decoded against the
'PrivateKeyInfoASN.1 structure. We then validate theversion` element and
check that theprivateKeyAlgorithm.algorithmelement contains a supported
object identifier. This check is for now mostly superficial, only ensuring
that the object identifier is either id-rsaEncryption, id-RSAES-OAEP or
id-RSASSA-PSS. This has to be further extended to also check the
id-sha{1,256,384,512}WithRSAEncryption identifiers as well as decoding the
privateKeyAlgorithm.parameterselement against a specific ASN.1 structure, if
necessary (RSASSA-PSS-params or RSAES-OAEP-params), and cross-checking the
specified digest algorithm with the algorithm that's specified through the main
object identifier or the structure contained inprivateKeyAlgorithm.parameters.
This is avoided for now because no test in WebKit or the web-platform-tests
suite covers this detail of the specification.
Data under the
privateKeyelement is decoded against theRSAPrivateKeyASN.1
structure, and theversionelement of that structure is validated. We then
retrieve data from that structure for the modulus, public exponent, private
exponent, both primes, both exponents and the coefficient parameters, bailing if
any of them is missing. Because libgcrypt switches the use of p and q parameters,
deviating from the standard use, we have to recompute the u parameter (the
coefficient). With that calculated, we're then able to construct theprivate-key
s-expression, embedding into it all the necessary parameters, and transferring
the ownership of this object to the new CryptoKeyRSA object that's then returned
from the importPkcs8() method.
No new tests -- related tests are now passing and are unskipped.
- crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:
(WebCore::CryptoKeyRSA::importPkcs8):
LayoutTests:
- platform/gtk/TestExpectations: Unskip the RSA PKCS#8 import tests
that are now passing.
- 5:29 PM Changeset in webkit [219534] by
-
- 2 edits in trunk/Tools
Failing to install on iPad simulators
https://bugs.webkit.org/show_bug.cgi?id=174532
<rdar://problem/33328347>
Reviewed by Stephanie Lewis.
- Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.install_app): Place install command in retry try-except block.
- 4:13 PM Changeset in webkit [219533] by
-
- 5 edits in trunk
Source/WebKit:
-[WKWebProcessBundleParameters setParametersForKeyWithDictionary:] passing wrong parameters to -setParameter:forKey
https://bugs.webkit.org/show_bug.cgi?id=174524
Reviewed by Sam Weinig.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
(-[WKWebProcessBundleParameters setParametersForKeyWithDictionary:]):
Pass the dictionary key and value in the correct order.
Tools:
Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
https://bugs.webkit.org/show_bug.cgi?id=174524
Reviewed by Sam Weinig.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
(TEST):
Renamed TestParameter to TestParameter1.
Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
(-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
Observe changes for two bundle parameters.
(-[BundleParametersPlugIn dealloc]):
Remove observers for two bundle parameters.
- 4:03 PM Changeset in webkit [219532] by
-
- 2 edits in trunk/Source/WebKitLegacy/win
[Curl] Don't start downloading more than once for same request
https://bugs.webkit.org/show_bug.cgi?id=174172
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-07-14
Reviewed by Alex Christensen.
- WebDownloadCurl.cpp:
(WebDownload::init):
- 4:02 PM Changeset in webkit [219531] by
-
- 3 edits3 adds in trunk
Possible crash in ~UserGestureIndicator() when on non-main thread
https://bugs.webkit.org/show_bug.cgi?id=174522
<rdar://problem/30283071>
Reviewed by Sam Weinig.
Source/WebCore:
UserGestureIndicator objects may be constructed / destructed in worker thread
(e.g. in DOMTimer::fired()). The UserGestureIndicator constructor / destructor
are supposed to be no-op on non-main threads so that it is safe. However,
we were mistakenly initializing m_previousToken data member in the constructor
on background thread, which meant that we could crash later on in the
UserGestureIndicator destructor when destroying m_previousToken.
Test: fast/workers/worker-user-gesture.html
- dom/UserGestureIndicator.cpp:
(WebCore::currentToken):
(WebCore::UserGestureIndicator::UserGestureIndicator):
LayoutTests:
Add layout test coverage.
- fast/workers/worker-user-gesture-expected.txt: Added.
- fast/workers/worker-user-gesture.html: Added.
- fast/workers/worker-user-gesture.js: Added.
(setInterval):
- 3:52 PM Changeset in webkit [219530] by
-
- 3 edits in trunk/Source/WebKit
Monitor directory for new statistics files after a delete operation
https://bugs.webkit.org/show_bug.cgi?id=174521
<rdar://problem/33322189>
Reviewed by Chris Dumez.
Create a FileMonitor to watch the data directory when the statistics file is
deleted by an external process. If it sees the file get created externally, merge
those data into the in-memory store.
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp:
(WebKit::ResourceLoadStatisticsPersistentStorage::startMonitoringDisk): Added.
(WebKit::ResourceLoadStatisticsPersistentStorage::monitorDirectoryForNewStatistics):
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h:
- 3:51 PM Changeset in webkit [219529] by
-
- 9 edits2 deletes in trunk/Source
Unreviewed, rolling out r219516.
This caused an API failure on macOS.
Reverted changeset:
"Make sure all CFHTTPCookieStorageRefs we create are
scheduled."
https://bugs.webkit.org/show_bug.cgi?id=174513
http://trac.webkit.org/changeset/219516
- 3:27 PM Changeset in webkit [219528] by
-
- 4 edits3 adds in trunk
REGRESSION (r219013): Compute source frame info for frameless document
https://bugs.webkit.org/show_bug.cgi?id=174385
<rdar://problem/33217736>
Reviewed by Brady Eidson.
Source/WebKit:
Fixes an issue where we would crash in WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction()
when computing the frame info for a now-frameless document. One way this can happen is when the frame
that contains the document that initiated the navigation is removed from the page.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction): Check that we have a valid page ID before
looking up the WebPage object corresponding to it.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Compute a FrameInfoData
object from the source document directly as opposed to using WebFrame::info() as the latter requires
that we have a valid WebCore frame and the source document may not have a frame.
LayoutTests:
- http/tests/navigation/resources/window-open-redirect-and-remove-opener.html: Added.
- http/tests/navigation/window-open-redirect-and-remove-opener-expected.txt: Added.
- http/tests/navigation/window-open-redirect-and-remove-opener.html: Added.
- 3:25 PM Changeset in webkit [219527] by
-
- 2 edits in trunk/LayoutTests
Fixed expectations after Mac expectation change.
https://trac.webkit.org/changeset/219507/webkit
Unreviewed test gardening.
- platform/wk2/TestExpectations:
- 3:04 PM Changeset in webkit [219526] by
-
- 23 edits in trunk/Source
Allow clients to override their own hardware media requirements where no fallback media exists.
https://bugs.webkit.org/show_bug.cgi?id=174426
<rdar://problem/32537704>
Reviewed by Eric Carlson.
Source/WebCore:
Add a new setting which allows clients to specify their own mediaContentTypesRequiringHardwareSupport should be
ignared in the case where no fallback exists, such as the case of a single <source> element, or setting the src
attribute directly.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::havePotentialSourceChild):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::sourceWasAdded):
(WebCore::HTMLMediaElement::sourceWasRemoved):
(WebCore::HTMLMediaElement::mediaPlayerShouldCheckHardwareSupport):
- html/HTMLMediaElement.h:
- page/Settings.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::shouldCheckHardwareSupport):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerShouldCheckHardwareSupport):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset):
Source/WebKit:
Add a new WKWebViewConfiguration property, as well as a new WKPreferences function, both to control
WebCore's new allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesGetAllowMediaContentTypesRequiringHardwareSupportAsFallback):
(WKPreferencesSetAllowMediaContentTypesRequiringHardwareSupportAsFallback):
- UIProcess/API/C/WKPreferencesRef.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
(-[WKWebViewConfiguration _allowMediaContentTypesRequiringHardwareSupportAsFallback]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WebKitLegacy/mac:
Add a new WebPreferences property to control WebCore's new
allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
(-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 2:45 PM Changeset in webkit [219525] by
-
- 5 edits in trunk/Source
Possible crash under NetworkSocketStream::didFailSocketStream()
https://bugs.webkit.org/show_bug.cgi?id=174526
<rdar://problem/32831441>
Reviewed by Brent Fulgham.
Source/WebCore:
Call m_client.didFailSocketStream() asynchronously in the constructor as our
caller (the client) is also being initialized at this point.
- platform/network/cf/SocketStreamHandleImplCFNet.cpp:
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
Source/WebKit:
For robustness, initialize the SocketStreamHandleImpl after the other
data members. We are passing |this| to the SocketStreamHandleImpl when
constructing it so it is unsafe to have uninitialized data members
at this point.
- NetworkProcess/NetworkSocketStream.cpp:
(WebKit::NetworkSocketStream::NetworkSocketStream):
- NetworkProcess/NetworkSocketStream.h:
- 2:43 PM Changeset in webkit [219524] by
-
- 4 edits4 adds in trunk
WebRTC: silence data not sent for disabled audio track
https://bugs.webkit.org/show_bug.cgi?id=174456
<rdar://problem/33284623>
Patch by Youenn Fablet <youenn@apple.com> on 2017-07-14
Reviewed by Eric Carlson.
Source/WebCore:
Test: webrtc/audio-muted-stats.html
webrtc/audio-muted-stats2.html
Adding a timer-based approach to send 10ms of silence every second.
This is consistent with how muted video tracks are implemented.
In case the audio track is muted at the time it is added, no silence data is sent.
- platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:
(WebCore::RealtimeOutgoingAudioSource::RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::initializeConverter):
(WebCore::RealtimeOutgoingAudioSource::stop):
(WebCore::RealtimeOutgoingAudioSource::sourceMutedChanged):
(WebCore::RealtimeOutgoingAudioSource::sourceEnabledChanged):
(WebCore::RealtimeOutgoingAudioSource::handleMutedIfNeeded):
(WebCore::RealtimeOutgoingAudioSource::sendSilence):
- platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
LayoutTests:
- webrtc/audio-muted-stats-expected.txt: Added.
- webrtc/audio-muted-stats.html: Added.
- webrtc/audio-muted-stats2-expected.txt: Added.
- webrtc/audio-muted-stats2.html: Added.
- 2:26 PM Changeset in webkit [219523] by
-
- 1 edit181 adds in trunk/LayoutTests
Add High Sierra test expectations
https://bugs.webkit.org/show_bug.cgi?id=174518
<rdar://problem/32716970>
Unreviewed test gardening.
- platform/mac-highsierra: Added.
- platform/mac-highsierra-wk1: Added.
- platform/mac-highsierra-wk2: Added.
- 1:29 PM Changeset in webkit [219522] by
-
- 9 edits1 copy1 delete in trunk
[CMake] Unclear distinction between WebKitHelpers and WebKitMacros
https://bugs.webkit.org/show_bug.cgi?id=153189
Reviewed by Antonio Gomes.
.:
Merge WebKitHelpers.cmake into WebKitMacros.cmake, since there is no meaningful distinction
between the macros that belong in each file. Then, move the macros that are only needed by
one project into project-specific CMake files. Retain here only the macros that are needed
in multiple places.
- Source/cmake/OptionsCommon.cmake: Update a comment.
- Source/cmake/OptionsGTK.cmake: New location for libtool macro, exclusively needed here.
- Source/cmake/WebKitCommon.cmake: Do not include WebKitHelpers.cmake.
- Source/cmake/WebKitHelpers.cmake: Removed.
- Source/cmake/WebKitMacros.cmake:
Source/WebCore:
- CMakeLists.txt: Include WebCoreMacros.cmake.
- WebCoreMacros.cmake: Added.
Source/WebKit:
New location for macros that are exclusively needed here.
- CMakeLists.txt:
- 1:27 PM Changeset in webkit [219521] by
-
- 5 edits in trunk
Unreviewed, rolling out r219510.
https://bugs.webkit.org/show_bug.cgi?id=174525
Need to revert length() == 0 check for null string (Requested
by yusukesuzuki on #webkit).
Reverted changeset:
"[WTF] Newly added AtomicStringImpl should use BufferInternal
static string if StringImpl is static"
https://bugs.webkit.org/show_bug.cgi?id=174501
http://trac.webkit.org/changeset/219510
- 1:17 PM Changeset in webkit [219520] by
-
- 2 edits in trunk/Source/WebCore
Fix style for name of class alloc function in WebVideoFullscreenInterfaceAVKit.
https://bugs.webkit.org/show_bug.cgi?id=174476
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-14
Reviewed by Alex Christensen.
No new tests because no behavior change.
This is a rename for per style requirements.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(allocWebAVPictureInPicturePlayerLayerViewInstance):
(WebAVPlayerLayerView_pictureInPicturePlayerLayerView):
(allocWebAVPlayerLayerViewInstance):
(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
(getWebAVPictureInPicturePlayerLayerViewClass): Deleted.
(getWebAVPlayerLayerViewClass): Deleted.
- 1:08 PM Changeset in webkit [219519] by
-
- 7 edits2 adds in trunk
[MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
https://bugs.webkit.org/show_bug.cgi?id=174514
Reviewed by Sam Weinig.
Source/WebCore:
Test: media/media-source/media-source-remove-decodeorder-crash.html
Fix the algorithm in removeCodedFrames() so that it's not possible to have a removePresentationStart >
removePresentationEnd (and also removeDecodeStart > removeDecodeEnd).
- Modules/mediasource/SampleMap.cpp:
(WebCore::PresentationOrderSampleMap::findSampleContainingOrAfterPresentationTime):
(WebCore::PresentationOrderSampleMap::findSampleStartingAfterPresentationTime):
- Modules/mediasource/SampleMap.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removeCodedFrames):
Tools:
- TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
(TestWebKitAPI::TEST_F):
LayoutTests:
- media/media-source/media-source-remove-decodeorder-crash-expected.txt: Added.
- media/media-source/media-source-remove-decodeorder-crash.html: Added.
- 1:04 PM Changeset in webkit [219518] by
-
- 2 edits in trunk/LayoutTests
Correcting test expectations after mac-expectation changes.
https://bugs.webkit.org/show_bug.cgi?id=174472
Unreviews test gardening.
- platform/mac/TestExpectations:
- 12:34 PM Changeset in webkit [219517] by
-
- 2 edits in trunk/Source/WebCore
Increase CoreAudio render audio buffer sizes for WebRTC
https://bugs.webkit.org/show_bug.cgi?id=174508
Patch by Youenn Fablet <youenn@apple.com> on 2017-07-14
Reviewed by Eric Carlson.
Covered by manually testing audio rendering through WebRTC sites.
- platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
(WebCore::AudioTrackPrivateMediaStreamCocoa::createAudioUnit): Setting audio buffer size equivalent to 20 ms.
- 12:16 PM Changeset in webkit [219516] by
-
- 9 edits2 adds in trunk/Source
Make sure all CFHTTPCookieStorageRefs we create are scheduled.
<rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
Reviewed by Tim Horton.
Source/WebCore:
- platform/spi/cf/CFNetworkSPI.h:
Source/WebKit:
Whenever we create a CFHTTPCookieStorage from identifying data it is unscheduled.
We need to schedule it on a RunLoop.
This patch also cleans up the creation of the identifying data itself.
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
- Shared/cf/CookieStorageUtilsCF.cpp: Added.
(WebKit::cookieStorageFromIdentifyingData):
(WebKit::identifyingDataFromCookieStorage):
- Shared/cf/CookieStorageUtilsCF.h: Added.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setSharedHTTPCookieStorage):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
- 12:02 PM Changeset in webkit [219515] by
-
- 2 edits in trunk/Source/WebCore
Remove CoreAudioCaptureSource speaker configuration
https://bugs.webkit.org/show_bug.cgi?id=174512
Patch by Youenn Fablet <youenn@apple.com> on 2017-07-14
Reviewed by Eric Carlson.
Covered by manually testing audio rendering through WebRTC sites.
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioSharedUnit::setupAudioUnit):
- 11:55 AM Changeset in webkit [219514] by
-
- 2 edits in trunk/Source/WebKit
Potential null-dereference under NetworkRTCProvider::resolvedName()
https://bugs.webkit.org/show_bug.cgi?id=174507
<rdar://problem/32597868>
Reviewed by Youenn Fablet.
NetworkRTCProvider::resolvedName() could do a null dereference of m_connection
because m_connection is nullified in NetworkRTCProvider::close() but resolvers
were only closed later on in the NetworkRTCProvider destructor.
To address the issue, we now stop DNS resolvers earlier, in NetworkRTCProvider::close().
Also fix unsafe modification of m_resolvers HashMap when iterating over it.
- NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::~NetworkRTCProvider):
(WebKit::NetworkRTCProvider::close):
(WebKit::NetworkRTCProvider::Resolver::~Resolver):
(WebKit::NetworkRTCProvider::stopResolver):
- 11:35 AM Changeset in webkit [219513] by
-
- 2 edits in trunk/Source/WebCore
[MediaStream] Limit the number of remote video samples queued
https://bugs.webkit.org/show_bug.cgi?id=174505
<rdar://problem/33223015>
Reviewed by Youenn Fablet.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::removeOldSamplesFromPendingQueue): Only
enqueue a fixed number of frames with invalid or negative decode times.
- 10:47 AM Changeset in webkit [219512] by
-
- 4 edits in trunk
Fix ambiguous description text in ARES-6 about the data the benchmark measures
https://bugs.webkit.org/show_bug.cgi?id=174510
Rubber stamped by Filip Pizlo.
- ARES-6/about.html:
- 10:44 AM Changeset in webkit [219511] by
-
- 9 edits in trunk/Source
Report CoreAudioCaptureSource failure in case shared unit stops working properly
https://bugs.webkit.org/show_bug.cgi?id=174494
Patch by Youenn Fablet <youenn@apple.com> on 2017-07-14
Reviewed by Eric Carlson.
Source/WebCore:
Manual test by interrupting an audio capture on Mac.
This patch adds a timer to CoreAudioSharedUnit.
In case the capture callback is not called after one second, the shared unit is said to fail.
Each source is notified that capture is failing.
This will in turn trigger onend track event so that web pages can remedy capture failure.
Timer starts with 10 seconds for audio data to start being captured.
It is then decreased to 2 seconds.
- platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::captureFailed):
- platform/mediastream/RealtimeMediaSource.h:
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioSharedUnit::CoreAudioSharedUnit):
(WebCore::CoreAudioSharedUnit::processMicrophoneSamples):
(WebCore::CoreAudioSharedUnit::startInternal):
(WebCore::CoreAudioSharedUnit::verifyIsCapturing):
(WebCore::CoreAudioSharedUnit::stopInternal):
Source/WebKit:
In case of capture failure, send a CaptureFailure message so that the
correct behavior happens in the Web process.
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::captureFailed):
- WebProcess/cocoa/UserMediaCaptureManager.h:
- WebProcess/cocoa/UserMediaCaptureManager.messages.in:
- 10:37 AM Changeset in webkit [219510] by
-
- 5 edits in trunk
[WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
https://bugs.webkit.org/show_bug.cgi?id=174501
Reviewed by Darin Adler.
Source/WTF:
When creating AtomicStringImpl from static StringImpl, we can just use createWithoutCopying
to create a BufferInternal AtomicStringImpl which m_data{8,16} is static string's one.
- wtf/text/AtomicStringImpl.cpp:
(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::AtomicStringImpl::add):
(WTF::HashTranslatorCharBuffer::HashTranslatorCharBuffer):
(WTF::UCharBufferTranslator::hash):
(WTF::UCharBufferTranslator::equal):
(WTF::UCharBufferTranslator::translate):
(WTF::LCharBufferTranslator::hash):
(WTF::LCharBufferTranslator::equal):
(WTF::LCharBufferTranslator::translate):
(WTF::BufferFromStaticDataTranslator::hash):
(WTF::BufferFromStaticDataTranslator::equal):
(WTF::BufferFromStaticDataTranslator::translate):
(WTF::AtomicStringImpl::addLiteral):
(WTF::addSymbol):
(WTF::addStatic):
(WTF::AtomicStringImpl::addSlowCase):
(WTF::AtomicStringImpl::lookUp):
(WTF::CharBufferFromLiteralDataTranslator::hash): Deleted.
(WTF::CharBufferFromLiteralDataTranslator::equal): Deleted.
(WTF::CharBufferFromLiteralDataTranslator::translate): Deleted.
(WTF::addSubstring): Deleted.
- wtf/text/StringImpl.h:
Tools:
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- 10:33 AM Changeset in webkit [219509] by
-
- 4 edits2 adds in trunk
Adding the 'autoplay' attribute to a media element during a user gesture should remove user gesture restrictions.
https://bugs.webkit.org/show_bug.cgi?id=174373
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-add-autoplay-user-gesture.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
LayoutTests:
- media/video-add-autoplay-user-gesture-expected.txt: Added.
- media/video-add-autoplay-user-gesture.html: Added.
- media/platform/ios/TestExpectations: Skipped; requires EventSender.
- 10:31 AM Changeset in webkit [219508] by
-
- 5 edits in trunk
Unreviewed, rolling out r219500.
The test is consistently failing on iOS simulator.
Reverted changeset:
"AX: VoiceOver silent or skipping over time values on media
player."
https://bugs.webkit.org/show_bug.cgi?id=174324
http://trac.webkit.org/changeset/219500
- 10:15 AM Changeset in webkit [219507] by
-
- 7 edits in trunk
Tools:
Bring mac expectations in-line with other platforms
https://bugs.webkit.org/show_bug.cgi?id=174472
<rdar://problem/33297388>
Reviewed by David Kilzer.
The override order for Mac test expectations does not conform to the pattern used by iOS,
GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
platform/mac-wk2
platform/wk2
platform/mac-elcapitan
platform/mac-sierra
generic
After this change, El Capitan's baseline search path looks like this:
platform/mac-sierra-wk2
platform/mac-sierra
platform/mac-wk2
platform/wk2
generic
- Scripts/webkitpy/port/mac.py:
(MacPort.init): If a specific version is specified in the port name, use that
as the os version.
(MacPort.default_baseline_search_path): Expectation search paths should work the
same way they do on other ports. Port + version overrides port, port overrides generic
and wk1/wk2 should override expectations for the two combined.
- Scripts/webkitpy/port/mac_unittest.py:
(MacTest.test_tests_for_other_platforms): Deleted.
(MacTest._assert_search_path): Deleted.
(MacTest.test_baseline_search_path): Deleted.
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
(test_rebaseline_test_and_print_scm_changes): Ditto.
(test_rebaseline_and_copy_test): Ditto.
(test_rebaseline_and_copy_test_no_existing_result): Ditto.
(test_rebaseline_and_copy_test_with_lion_result): Ditto.
(test_rebaseline_and_copy_no_overwrite_test): Ditto.
LayoutTests:
Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
https://bugs.webkit.org/show_bug.cgi?id=174438
<rdar://problem/33277112>
Reviewed by David Kilzer.
- platform/mac-wk2/TestExpectations: Move skipped tests because of webkit.org/b/174504.
- platform/wk2/TestExpectations: Ditto.
- 9:03 AM Changeset in webkit [219506] by
-
- 7 edits in trunk/Source
[WTF] Use std::unique_ptr for StackTrace
https://bugs.webkit.org/show_bug.cgi?id=174495
Reviewed by Alex Christensen.
Source/JavaScriptCore:
- runtime/ExceptionScope.cpp:
(JSC::ExceptionScope::unexpectedExceptionMessage):
- runtime/VM.cpp:
(JSC::VM::throwException):
Source/WTF:
Instead of returning pointer to heap allocated StackTrace,
we should return std::unique_ptr<StackTrace>.
And we also move WTFGetBackTrace from Assertions.cpp to
StackTrace.cpp to consolidate stack trace related operations
into StackTrace.cpp.
- wtf/Assertions.cpp:
- wtf/StackTrace.cpp:
(WTFGetBacktrace):
(WTF::StackTrace::captureStackTrace):
- wtf/StackTrace.h:
- 8:58 AM Changeset in webkit [219505] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] error 'm_compositorTexture': undeclared identifier since Bug 174345
https://bugs.webkit.org/show_bug.cgi?id=174493
Patch by Fujii Hironori <Fujii Hironori> on 2017-07-14
Reviewed by Alex Christensen.
Compilation errors are reported by the code using a member
m_compositorTexture of GraphicsContext3D which exists only if
USE(COORDINATED_GRAPHICS_THREADED). WinCairo port doesn't use it.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
Use m_compositorTexture only if USE(COORDINATED_GRAPHICS_THREADED).
(WebCore::GraphicsContext3D::~GraphicsContext3D): Ditto.
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
Ditto. Fix the wrong indentation level.
- 8:54 AM Changeset in webkit [219504] by
-
- 3 edits2 adds in trunk
[HarfBuzz] Decomposed Vietnamese characters are rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=174418
Patch by Fujii Hironori <Fujii Hironori> on 2017-07-14
Reviewed by Michael Catanzaro.
Source/WebCore:
HarfBuzzShaper should normalize the input text before collecting
HarfBuzzRuns. Actually, HarfBuzzShaper::setNormalizedBuffer does
the task. But, this function hasn't been called from anywhere
since Bug 108077.
Test: fast/text/international/vietnamese-nfd.html
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
Call setNormalizedBuffer instead of normalizeCharacters.
(WebCore::normalizeCharacters): Deleted.
LayoutTests:
- fast/text/international/vietnamese-nfd-expected.html: Added.
- fast/text/international/vietnamese-nfd.html: Added.
- 5:06 AM Changeset in webkit [219503] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Build broken "Cannot open include file: 'GL/glext.h'" since Bug 172104
https://bugs.webkit.org/show_bug.cgi?id=174492
Patch by Fujii Hironori <Fujii Hironori> on 2017-07-14
Reviewed by Žan Doberšek.
WinCairo port uses GLES. OpenGLShims.h shouldn't be included.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
Include "OpenGLShims.h" only if !USE(OPENGL_ES_2) instead of USE(OPENGL).
- 1:21 AM Changeset in webkit [219502] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Use WTFMove to prune liveness in DFGAvailabilityMap
https://bugs.webkit.org/show_bug.cgi?id=174423
Reviewed by Saam Barati.
- dfg/DFGAvailabilityMap.cpp:
(JSC::DFG::AvailabilityMap::pruneHeap):
(JSC::DFG::AvailabilityMap::pruneByLiveness):
- 1:17 AM Changeset in webkit [219501] by
-
- 4 edits in trunk/Source/WebCore
PageCache::removeAllItemsForPage(Page&) may reenter itself and cause crashes
https://bugs.webkit.org/show_bug.cgi?id=174473
<rdar://problem/32177485>
Reviewed by Antti Koivisto.
This could happen when a Page containing an SVGImage is removed from PageCache and
this resulted in the destruction of the SVGImage. Because the SVGImage has an internal
utility Page, it will also call PageCache::removeAllItemsForPage(WebCore::Page&) upon
destruction, causing us to reenter.
Address the issue by not calling PageCache::removeAllItemsForPage() for utility pages
since those cannot be in PageCache in the first place.
Also add assertions to make sure:
- We never insert a utility page into PageCache
- PageCache::removeAllItemsForPage() does not reenter
No new tests, because I was unable to write a test which reproduced the crash. This
is in theory testable using an API test which enables PageCache, loads a page
containing an SVGImage, navigates away from this page so that it goes into PageCache,
and then calls [WebView _close]. However, when I tried writing such test, I could
not get the SVGImage to get destroyed while PageCache::removeAllItemsForPage() is
called for the top-level page for some reason. Something seems to be keeping the
SVGImage alive longer. I tried disabling the MemoryCache but it did not help.
- history/PageCache.cpp:
(WebCore::PageCache::addIfCacheable):
(WebCore::PageCache::removeAllItemsForPage):
- history/PageCache.h:
- page/Page.cpp:
(WebCore::Page::~Page):
- 12:07 AM Changeset in webkit [219500] by
-
- 5 edits in trunk
AX: VoiceOver silent or skipping over time values on media player.
https://bugs.webkit.org/show_bug.cgi?id=174324
<rdar://problem/32021784>
Patch by Aaron Chu <aaron_chu@apple.com> on 2017-07-14
Reviewed by Antoine Quint.
Added role attribute to modern media controls time lable class so that VoiceOver can access the time label when the media is playing.
Source/WebCore:
Updated: media/modern-media-controls/time-label/time-label.html
- Modules/modern-media-controls/controls/time-label.js:
LayoutTests:
- media/modern-media-controls/time-label/time-label-expected.txt:
- media/modern-media-controls/time-label/time-label.html:
Jul 13, 2017:
- 11:39 PM Changeset in webkit [219499] by
-
- 4 edits in trunk/Source/WebKit
Better deal with changes to the ResourceLoadStatisticsStore file on disk
https://bugs.webkit.org/show_bug.cgi?id=174487
Reviewed by Brent Fulgham.
Rename WebResourceLoadStatisticsStore's resetDataFromDecoder() to mergeWithDataFromDecoder()
and update it so that it actual merges the data from the disk with the one we have in memory,
instead of replacing it. This avoid data loss.
We leverage the existing WebResourceLoadStatisticsStore::mergeStatistics() to merge the
statistics.
To faciliate merging the operating dates, they are now represented as OperatingDate objects
instead of WallTime objects. OperatingDate only include date precision, no time information.
As a result, the merge 2 vectors of OperatingDate objects, we can:
- Merge the 2 sorted vectors (using std::merge())
- Get rid of duplicates (easy because of date-level precision)
- Drop old dates until the vector has at most 30 items.
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp:
(WebKit::ResourceLoadStatisticsPersistentStorage::refreshMemoryStoreFromDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::populateMemoryStoreFromDisk):
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::OperatingDate::fromWallTime):
(WebKit::OperatingDate::today):
(WebKit::OperatingDate::secondsSinceEpoch):
(WebKit::OperatingDate::operator==):
(WebKit::OperatingDate::operator<):
(WebKit::OperatingDate::operator<=):
(WebKit::OperatingDate::OperatingDate):
(WebKit::mergeOperatingDates):
(WebKit::WebResourceLoadStatisticsStore::createEncoderFromData):
(WebKit::WebResourceLoadStatisticsStore::mergeWithDataFromDecoder):
(WebKit::WebResourceLoadStatisticsStore::includeTodayAsOperatingDateIfNecessary):
(WebKit::WebResourceLoadStatisticsStore::hasStatisticsExpired):
- UIProcess/WebResourceLoadStatisticsStore.h:
- 11:18 PM Changeset in webkit [219498] by
-
- 1 edit2 copies1 move in trunk/JSTests
Add some additional test cases for bug 170896.
https://bugs.webkit.org/show_bug.cgi?id=174491
Reviewed by Filip Pizlo.
- stress/regress-170896-with-contiguous-shape-profile.js: Copied from JSTests/stress/regress-170896.js.
- stress/regress-170896-with-double-shape-profile.js: Added.
(test):
- stress/regress-170896-with-int32-shape-profile.js: Added.
(test):
- stress/regress-170896.js: Removed.
- 8:56 PM Changeset in webkit [219497] by
-
- 2 edits in trunk/Tools
Fix style checker unit test
Unreviewed WebKit2 => WebKit fixup.
- Scripts/webkitpy/style/checker_unittest.py:
(CheckerDispatcherSkipTest.test_should_skip_with_warning):
- 8:53 PM Changeset in webkit [219496] by
-
- 3 edits in trunk
[GTK][WPE] Avoid setting settings that are set by default
Unreviewed.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
- 8:45 PM Changeset in webkit [219495] by
-
- 2 edits in trunk
Unreviewed, Windows ports should enable WebKitLegacy and disable
WebKit.
- Source/cmake/OptionsWin.cmake:
- 8:36 PM Changeset in webkit [219494] by
-
- 2 edits in trunk
Fix the Mac CMake build.
Unreviewed build fix.
Fix the Mac CMake build after r219488 broke it. r219488 erroneously updated
the variable name DERIVED_SOURCES_WEBKITLEGACY_DIR to DERIVED_SOURCES_WEBKIT_LEGACY_DIR
without updating subsequent users of that variable.
- Source/cmake/WebKitFS.cmake:
Rename DERIVED_SOURCES_WEBKIT_LEGACY_DIR back to DERIVED_SOURCES_WEBKITLEGACY_DIR.
- 8:09 PM Changeset in webkit [219493] by
-
- 2 edits in trunk/Tools
Use the old WebKit/WebKit2 targets for CMake builds. (v2)
Unreviewed build fix.
r219492 missed one hunk from its partial revert of r219489.
This patch reverts that hunk.
- TestWebKitAPI/CMakeLists.txt:
- 7:56 PM Changeset in webkit [219492] by
-
- 2 edits in trunk/Tools
Use the old WebKit/WebKit2 targets for CMake builds.
Unreviewed build fix.
We can update the target names to match the Framework names in a future patch.
This is a partial revert of r219489.
- TestWebKitAPI/CMakeLists.txt:
WebKitLegacy => WebKit
WebKit => WebKit2
- 7:53 PM Changeset in webkit [219491] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, annotate inline for operator==/!= for FastAllocator
https://bugs.webkit.org/show_bug.cgi?id=174366
- wtf/FastMalloc.h:
(WTF::operator==):
(WTF::operator!=):
- 7:39 PM Changeset in webkit [219490] by
-
- 2 edits3 deletes in trunk/Source
Removed empty project directories left behind after the rename
Source/WebKit:
- WebKit2.xcodeproj: Removed.
Source/WebKitLegacy:
- WebKit.vcxproj: Removed.
- WebKit.xcodeproj: Removed.
- 7:29 PM Changeset in webkit [219489] by
-
- 4 edits in trunk/Tools
Fix TestWebKit API.
https://bugs.webkit.org/show_bug.cgi?id=174164
rdar://problem/33137595
Reviewed by Dan Bernstein.
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- TestWebKitAPI/PlatformGTK.cmake:
- 7:29 PM Changeset in webkit [219488] by
-
- 12 edits in trunk
Fix the cMake builds (GTK and WPE.)
https://bugs.webkit.org/show_bug.cgi?id=174164
rdar://problem/33137595
Reviewed by Dan Bernstein.
.:
- Source/CMakeLists.txt:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsJSCOnly.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWPE.cmake:
- Source/cmake/WebKitFS.cmake:
- Source/cmake/WebKitPackaging.cmake:
Source/WebCore/platform/gtk/po:
- POTFILES.in:
Source/WebKit:
- Scripts/generate-forwarding-headers.pl:
(collectFrameworkHeaderPaths):
(createForwardingHeadersForFramework):
- 7:29 PM Changeset in webkit [219487] by
-
- 4 edits1 move1 add in trunk
Rename WebKit2.xcodeproj to WebKit.xcodeproj.
https://bugs.webkit.org/show_bug.cgi?id=174164
rdar://problem/33137595
Reviewed by Dan Bernstein.
.:
- WebKit.xcworkspace/contents.xcworkspacedata:
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Renamed from Source/WebKit/WebKit2.xcodeproj/project.pbxproj.
- 7:29 PM Changeset in webkit [219486] by
-
- 23 edits in trunk
Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
https://bugs.webkit.org/show_bug.cgi?id=174164
rdar://problem/33137595
Reviewed by Dan Bernstein.
.:
- Source/Makefile:
- Source/PlatformGTK.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFS.cmake:
- Source/cmake/WebKitPackaging.cmake:
- WebKit.xcworkspace/contents.xcworkspacedata:
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
Source/WebKit:
- PlatformGTK.cmake:
- Shared/API/c/wpe/WebKit.h:
Tools:
- BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
(ShouldBuildTest):
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- Scripts/build-webkit:
- Scripts/do-file-rename:
- Scripts/do-webcore-rename:
- Scripts/update-webkit-localizable-strings:
- Scripts/webkitpy/common/config/watchlist:
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checkers/featuredefines.py:
- gtk/make-dist.py:
(ensure_version_if_possible):
- gtk/manifest.txt.in:
- 7:29 PM Changeset in webkit [219485] by
-
- 1 edit1 move1 add in trunk/Source/WebKitLegacy
Update the Visual Studio project name from WebKit to WebKitLegacy.
https://bugs.webkit.org/show_bug.cgi?id=174162
rdar://problem/33137594
Reviewed by Dan Bernstein.
Rename WebKit to WebKitLegacy.
- WebKitLegacy.vcxproj/WebKitLegacy.proj: Renamed from Source/WebKitLegacy/WebKit.vcxproj/WebKit.proj.
- 7:29 PM Changeset in webkit [219484] by
-
- 4 edits1 move1 add in trunk
Update the Xcode project name from WebKit to WebKitLegacy.
https://bugs.webkit.org/show_bug.cgi?id=174162
rdar://problem/33137594
Reviewed by Dan Bernstein.
Rename WebKit to WebKitLegacy.
.:
- WebKit.xcworkspace/contents.xcworkspacedata:
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
Source/WebKitLegacy:
- WebKitLegacy.xcodeproj/project.pbxproj: Renamed from Source/WebKitLegacy/WebKit.xcodeproj/project.pbxproj.
- 7:29 PM Changeset in webkit [219483] by
-
- 18 edits in trunk
Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
https://bugs.webkit.org/show_bug.cgi?id=174162
rdar://problem/33137594
Reviewed by Dan Bernstein.
.:
Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource cmake files
and Xcode project files.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFS.cmake:
- WebKit.xcworkspace/contents.xcworkspacedata:
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
Tools:
Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
- BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
- DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
- EWSTools/configure-clang-linux.sh:
- Scripts/build-webkit:
- Scripts/do-file-rename:
- Scripts/do-webcore-rename:
- Scripts/update-webkit-localizable-strings:
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
- Scripts/webkitpy/style/checkers/changelog_unittest.py:
- Scripts/webkitpy/style/checkers/featuredefines.py:
- gtk/manifest.txt.in:
- 7:12 PM Changeset in webkit [219482] by
-
- 1 move in trunk/Source/WebKit
Rename Source/WebKit2 to Source/WebKit.
- 7:11 PM Changeset in webkit [219481] by
-
- 1 move in trunk/Source/WebKitLegacy
Rename Source/WebKit to Source/WebKitLegacy.
- 6:48 PM Changeset in webkit [219480] by
-
- 10 edits in trunk
Fix compiler warnings when building with GCC 7
https://bugs.webkit.org/show_bug.cgi?id=174463
Reviewed by Darin Adler.
.:
- Source/cmake/OptionsCommon.cmake:
Source/JavaScriptCore:
- disassembler/udis86/udis86_decode.c:
(decode_operand):
Source/ThirdParty:
- brotli/CMakeLists.txt:
Source/WebCore:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setShouldManageAudioSessionCategory):
Source/WebKit2:
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::sendOutputMessage):
- 6:38 PM Changeset in webkit [219479] by
-
- 2 edits in trunk/Source/WebCore
Incorrect call to StyledElement::setInlineStyleProperty in ImageDocument::createDocumentStructure
https://bugs.webkit.org/show_bug.cgi?id=174470
Reviewed by Darin Adler.
- html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
- 5:23 PM Changeset in webkit [219478] by
-
- 2 edits in trunk/LayoutTests
Skipped multiple http/tests/webrtc/ test on iOS simulator.
https://bugs.webkit.org/show_bug.cgi?id=173861
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 5:20 PM Changeset in webkit [219477] by
-
- 1 edit1 add in trunk/Tools
Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
https://bugs.webkit.org/show_bug.cgi?id=174438
<rdar://problem/33277112>
Reviewed by Aakash Jain.
Given a patch, this will convert the changes from the path to the new directory structure.
- Scripts/rebase-patch-after-webkit-move: Added.
(append_source): Append 'Source' to the provided path.
(is_editable_line): Return true if a line the script expects to modify.
(needs_rebase): Return if a line needs to be rebased based on it's content.
(rebase_line): Rebase the provided line.
(rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
(parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
were provided.
- 4:09 PM Changeset in webkit [219476] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build.
- platform/graphics/GraphicsContext3D.h:
- 4:08 PM Changeset in webkit [219475] by
-
- 6 edits3 adds in trunk/Source/WebKit2
Moved filesystem code out of WebResourceLoadStatisticsStore class
https://bugs.webkit.org/show_bug.cgi?id=174435
Reviewed by Brent Fulgham.
Moved filesystem code out of WebResourceLoadStatisticsStore class and into
a new ResourceLoadStatisticsPersistentStorage class to decrease complexity.
- CMakeLists.txt:
- UIProcess/Cocoa/WebResourceLoadStatisticsStoreCocoa.mm:
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp: Added.
(WebKit::hasFileChangedSince):
(WebKit::createDecoderForFile):
(WebKit::ResourceLoadStatisticsPersistentStorage::ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::~ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::storageDirectoryPath):
(WebKit::ResourceLoadStatisticsPersistentStorage::resourceLogFilePath):
(WebKit::ResourceLoadStatisticsPersistentStorage::startMonitoringDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::stopMonitoringDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::refreshMemoryStoreFromDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::populateMemoryStoreFromDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::writeMemoryStoreToDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore):
(WebKit::ResourceLoadStatisticsPersistentStorage::clear):
(WebKit::ResourceLoadStatisticsPersistentStorage::finishAllPendingWorkSynchronously):
(WebKit::ResourceLoadStatisticsPersistentStorage::excludeFromBackup):
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h: Added.
- UIProcess/Storage/ios/ResourceLoadStatisticsPersistentStorageIOS.mm: Added.
(WebKit::ResourceLoadStatisticsPersistentStorage::excludeFromBackup):
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::processStatisticsAndDataRecords):
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::WebResourceLoadStatisticsStore::applicationWillTerminate):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebResourceLoadStatisticsStore::resetDataFromDecoder):
- UIProcess/WebResourceLoadStatisticsStore.h:
- WebKit2.xcodeproj/project.pbxproj:
- 4:04 PM Changeset in webkit [219474] by
-
- 3 edits4 moves in trunk/Source/WebCore
Rename GraphicsContext[3D]Mac to Cocoa and move things into graphics/cocoa
https://bugs.webkit.org/show_bug.cgi?id=174453
<rdar://problem/33281481>
Reviewed by Simon Fraser.
Two renames, two moves:
graphics/mac/GraphicsContext3DMac.mm -> graphics/cocoa/GraphicsContext3DCocoa.mm
graphics/mac/GraphicsContext.mm -> graphics/cocoa/GraphicsContextCocoa.mm
graphics/mac/WebGLLayer.h -> graphics/cocoa/WebGLLayer.h
graphics/mac/WebGLLayer.mm -> graphics/cocoa/WebGLLayer.mm
- PlatformMac.cmake:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/cocoa/GraphicsContext3DCocoa.mm: Renamed from Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm.
- platform/graphics/cocoa/GraphicsContextCocoa.mm: Renamed from Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm.
- platform/graphics/cocoa/WebGLLayer.h: Renamed from Source/WebCore/platform/graphics/mac/WebGLLayer.h.
- platform/graphics/cocoa/WebGLLayer.mm: Renamed from Source/WebCore/platform/graphics/mac/WebGLLayer.mm.
- 3:59 PM Changeset in webkit [219473] by
-
- 4 edits in trunk/Source/WebCore
Clean-up some things in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=174452
<rdar://problem/33281257>
Reviewed by Simon Fraser.
General clean-up in GC3D.
Covered by existing tests.
- platform/graphics/GraphicsContext3D.h: Use initial values where possible.
(WebCore::GraphicsContext3D::GraphicsContext3DState::GraphicsContext3DState): Deleted.
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D): Nearly everything can come from the
initial values now.
(WebCore::GraphicsContext3D::~GraphicsContext3D): Remove code that won't be enabled
on this platform.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): While unlikely to happen,
and possibly harmless in this case, add some checked arithmetic to make sure we don't overflow
when working out how big a buffer to create.
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData): Ditto.
(WebCore::GraphicsContext3D::reshape): Do nothing if we are ever given negative
width or height. Again unlikely.
- 3:49 PM Changeset in webkit [219472] by
-
- 5 edits in trunk/Source/WebCore
Avoid unnecessary copy of framebuffer into WebGL Layer
https://bugs.webkit.org/show_bug.cgi?id=174345
<rdar://problem/33228950>
Reviewed by Sam Weinig.
On macOS, we're unnecessarily copying the framebuffer into another
texture before pushing it into the compositing layer. Instead we
should simply render the FBO into the CALayer we use to draw on
the screen.
Covered by the existing WebGL tests.
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::platformTexture): Return the FBO texture instead.
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D): No need to have a compositing
texture.
(WebCore::GraphicsContext3D::~GraphicsContext3D):
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture): Don't copy the pixels from
the FBO into the compositing texture
- 3:43 PM Changeset in webkit [219471] by
-
- 5 edits in branches/safari-603-branch/Source
Versioning.
- 3:40 PM Changeset in webkit [219470] by
-
- 1 copy in tags/Safari-603.3.8
Tag Safari-603.3.8.
- 3:26 PM Changeset in webkit [219469] by
-
- 7 edits in branches/safari-604.1.31-branch/Source
Versioning.
- 3:22 PM Changeset in webkit [219468] by
-
- 1 copy in tags/Safari-604.1.31.2
Tag Safari-604.1.31.2.
- 3:04 PM Changeset in webkit [219467] by
-
- 6 edits3 deletes in trunk/Source/WebKit2
Unreviewed, rolling out r219453.
Seems to cause some crashes on the bots
Reverted changeset:
"Moved filesystem code out of WebResourceLoadStatisticsStore
class"
https://bugs.webkit.org/show_bug.cgi?id=174435
http://trac.webkit.org/changeset/219453
- 3:02 PM Changeset in webkit [219466] by
-
- 2 edits in trunk/LayoutTests
Marked imported/w3c/web-platform-tests/IndexedDB/large-nested-cloning.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=173487
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 2:44 PM Changeset in webkit [219465] by
-
- 3 edits in branches/safari-603-branch
Cherry-pick r215451. rdar://problem/31651319
- 2:16 PM Changeset in webkit [219464] by
-
- 3 edits in branches/safari-604.1.31-branch/Source/WebCore/PAL
Cherry-pick r219455. rdar://problem/33288831
- 2:02 PM Changeset in webkit [219463] by
-
- 2 edits in trunk/LayoutTests
Skipping media/video-source-before-src.html.
https://bugs.webkit.org/show_bug.cgi?id=174284
Unreviewed test gardening.
- 1:39 PM Changeset in webkit [219462] by
-
- 2 edits in trunk/Source/JavaScriptCore
Incorrect assertion in JSC::CallLinkInfo::callTypeFor
https://bugs.webkit.org/show_bug.cgi?id=174467
Reviewed by Saam Barati.
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::callTypeFor):
- 1:19 PM Changeset in webkit [219461] by
-
- 1 edit1 add in trunk/LayoutTests
REGRESSION: "visibility:hidden" does not hide play button for video elements
https://bugs.webkit.org/show_bug.cgi?id=174258
<rdar://problem/33181452>
Unreviewed test gardening.
Add a missing expectation file which is designed to be empty and is now just a space.
- media/modern-media-controls/css/visibility-hidden-expected.html: Added.
- 12:16 PM Changeset in webkit [219460] by
-
- 13 edits in trunk/Source/WebCore
Implementors of memoryCost() need to be thread-safe.
https://bugs.webkit.org/show_bug.cgi?id=172738
<rdar://problem/32474881>
Reviewed by Keith Miller.
No new tests. This patch fixes a race condition bug that can result in random
crashes (and other unpredictable behavior), and is very difficult to test for.
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::releaseMemory):
(WebCore::AudioBuffer::memoryCost):
- Modules/webaudio/AudioBuffer.h:
- dom/ChildNodeList.h:
- dom/CollectionIndexCache.h:
(WebCore::CollectionIndexCache::memoryCost):
- dom/LiveNodeList.h:
- html/CachedHTMLCollection.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::memoryCost):
(WebCore::HTMLCanvasElement::externalMemoryCost):
(WebCore::HTMLCanvasElement::setImageBuffer):
- html/HTMLCanvasElement.h:
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::invalidateNamedElementCache):
- html/HTMLCollection.h:
(WebCore::CollectionNamedElementCache::memoryCost):
(WebCore::HTMLCollection::memoryCost):
(WebCore::HTMLCollection::setNamedItemCache):
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::memoryCost):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::memoryCost):
(WebCore::ImageBuffer::externalMemoryCost):
- 11:41 AM Changeset in webkit [219459] by
-
- 12 edits in trunk/Source
Fix style. Use #pragma once in VideoFullscreen and PlaybackSession headers.
https://bugs.webkit.org/show_bug.cgi?id=174448
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-13
Reviewed by Eric Carlson.
No behavior change.
Source/WebCore:
- platform/cocoa/WebPlaybackSessionInterface.h:
- platform/cocoa/WebVideoFullscreenChangeObserver.h:
- platform/cocoa/WebVideoFullscreenModel.h:
- platform/cocoa/WebVideoFullscreenModelVideoElement.h:
- platform/ios/WebPlaybackSessionInterfaceAVKit.h:
- platform/ios/WebVideoFullscreenControllerAVKit.h:
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
- platform/mac/WebVideoFullscreenInterfaceMac.h:
Source/WebKit2:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
- WebProcess/cocoa/WebVideoFullscreenManager.h:
- 11:21 AM Changeset in webkit [219458] by
-
- 5 edits in trunk
Deleting last URLSearchParams key should remove trailing ? in associated URL
https://bugs.webkit.org/show_bug.cgi?id=174465
Patch by Alex Christensen <achristensen@webkit.org> on 2017-07-13
Reviewed by Chris Dumez.
Source/WebCore:
This makes us match the behavior of Chrome and Firefox, and the spec after https://github.com/whatwg/url/issues/332 is approved.
This will be covered by an upcoming web platform test, and I updated fast/dom/DOMURL/searchparams.html to cover it now.
- platform/URLParser.cpp:
(WebCore::URLParser::serialize):
If there are no tuples, serialize to the null string instead of a non-null empty string.
This makes it so URL::setQuery removes the ?
LayoutTests:
- fast/dom/DOMURL/searchparams-expected.txt:
- fast/dom/DOMURL/searchparams.html:
- 11:21 AM Changeset in webkit [219457] by
-
- 5 edits in trunk/Source
Style fix. Replace strongThis with protectedThis.
https://bugs.webkit.org/show_bug.cgi?id=174444
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-13
Reviewed by Eric Carlson.
Rename, no behavior change.
Source/WebCore:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::finish):
- platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::WebCoreDecompressionSession::maybeBecomeReadyForMoreMediaData):
(WebCore::WebCoreDecompressionSession::enqueueSample):
(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):
(WebCore::WebCoreDecompressionSession::enqueueDecodedSample):
(WebCore::WebCoreDecompressionSession::requestMediaDataWhenReady):
(WebCore::WebCoreDecompressionSession::flush):
Source/WebKit2:
- WebProcess/cocoa/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::didSetupFullscreen):
(WebKit::WebVideoFullscreenManager::didEnterFullscreen):
(WebKit::WebVideoFullscreenManager::didExitFullscreen):
(WebKit::WebVideoFullscreenManager::didCleanupFullscreen):
- 11:19 AM Changeset in webkit [219456] by
-
- 3 edits in trunk/Source/WebCore
Fix block style in WebVideoFullscreen classes.
https://bugs.webkit.org/show_bug.cgi?id=174446
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-13
Reviewed by Eric Carlson.
No behavior change.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::setVideoLayerFrame):
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer layoutSublayers]):
(getWebAVPictureInPicturePlayerLayerViewClass):
(getWebAVPlayerLayerViewClass):
- 11:17 AM Changeset in webkit [219455] by
-
- 3 edits in trunk/Source/WebCore/PAL
[Win] Build error when building WebCore from WebCore.proj project file.
https://bugs.webkit.org/show_bug.cgi?id=174462
Reviewed by Brent Fulgham.
Add required include directory to list of include directories.
- pal/CMakeLists.txt:
- pal/PlatformWin.cmake:
- 11:03 AM Changeset in webkit [219454] by
-
- 20 edits in trunk/Source
Web Inspector: Remove unused and untested Page domain commands
https://bugs.webkit.org/show_bug.cgi?id=174429
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-07-13
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/protocol/Page.json:
Source/WebCore:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad): Deleted.
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad): Deleted.
- inspector/InspectorPageAgent.h:
Source/WebInspectorUI:
- UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
- Versions/Inspector-iOS-10.0.json:
- Versions/Inspector-iOS-10.3.json:
- Versions/Inspector-iOS-11.0.json:
- Versions/Inspector-iOS-7.0.json:
- Versions/Inspector-iOS-8.0.json:
- Versions/Inspector-iOS-9.0.json:
- Versions/Inspector-iOS-9.3.json:
- 10:52 AM Changeset in webkit [219453] by
-
- 6 edits3 adds in trunk/Source/WebKit2
Moved filesystem code out of WebResourceLoadStatisticsStore class
https://bugs.webkit.org/show_bug.cgi?id=174435
Reviewed by Brent Fulgham.
Moved filesystem code out of WebResourceLoadStatisticsStore class and into
a new ResourceLoadStatisticsPersistentStorage class to decrease complexity.
- CMakeLists.txt:
- UIProcess/Cocoa/WebResourceLoadStatisticsStoreCocoa.mm:
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp: Added.
(WebKit::hasFileChangedSince):
(WebKit::createDecoderForFile):
(WebKit::ResourceLoadStatisticsPersistentStorage::ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::~ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::storageDirectoryPath):
(WebKit::ResourceLoadStatisticsPersistentStorage::resourceLogFilePath):
(WebKit::ResourceLoadStatisticsPersistentStorage::startMonitoringDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::stopMonitoringDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::refreshMemoryStoreFromDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::populateMemoryStoreFromDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::writeMemoryStoreToDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore):
(WebKit::ResourceLoadStatisticsPersistentStorage::clear):
(WebKit::ResourceLoadStatisticsPersistentStorage::finishAllPendingWorkSynchronously):
(WebKit::ResourceLoadStatisticsPersistentStorage::excludeFromBackup):
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h: Added.
- UIProcess/Storage/ios/ResourceLoadStatisticsPersistentStorageIOS.mm: Added.
(WebKit::ResourceLoadStatisticsPersistentStorage::excludeFromBackup):
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::processStatisticsAndDataRecords):
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::WebResourceLoadStatisticsStore::applicationWillTerminate):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebResourceLoadStatisticsStore::resetDataFromDecoder):
- UIProcess/WebResourceLoadStatisticsStore.h:
- WebKit2.xcodeproj/project.pbxproj:
- 10:34 AM Changeset in webkit [219452] by
-
- 5 edits in branches/safari-604.1.31-branch/Source/WebKit2
Cherry-pick r219440. rdar://problem/33272627
- 10:03 AM Changeset in webkit [219451] by
-
- 3 edits1 add in trunk
Missing exception check in JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=174455
<rdar://problem/31384608>
Reviewed by Mark Lam.
JSTests:
- stress/has-instance-exception-check.js: Added.
(assert):
(let.getter.Object.getOwnPropertyDescriptor.get foo):
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
- 8:51 AM Changeset in webkit [219450] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Update expectations of several tests failing at r219449.
- platform/gtk/TestExpectations:
- 3:09 AM Changeset in webkit [219449] by
-
- 5 edits in trunk
[GCrypt] Implement CryptoKeyRSA SPKI exports
https://bugs.webkit.org/show_bug.cgi?id=173695
Reviewed by Jiewen Tan.
Source/WebCore:
Implement the SPKI export operation for RSA keys for platforms that use
libgcrypt.
In CryptoKeyRSA::exportSpki(), we bail early with an invalid access exception if
this export is not being done for a public key. Otherwise, we start with creating
theRSAPublicKeyASN.1 structure, filling in the modulus and public exponent
data that's retrieved from thepublic-keys-expression in the signed MPI format.
We then create the
SubjectPublicKeyInfoASN.1 structure and fill it out with
the necessary data. The id-rsaEncryption object identifier is written out under
thealgorithm.algorithmelement, and a null value is written out under the
algorithm.parameterselement. This doesn't follow the specification at the
moment, since id-RSASSA-PSS would have to be written for the RSA-PSS algorithm,
and id-RSAES-OAEP for the RSA-OAEP algorithm, along with specific parameter
structures. But no test in WebKit or the web-platform-tests suite covers this,
so this deviation should be addressed later.
Data of the previously-constructed
RSAPublicKeystructure is retrieved and
written out under thesubjectPublicKeyelement, before finally retrieving
data of theSubjectPublicKeyInfostructure and returning that to the caller.
A helper mpiSignedData() function is added, providing overloads for gcry_mpi_t
and gcry_sexp_t parameters. MPI data for that parameter is retrieved and the
first byte of that data is tested, inserting an additional 0x00 byte at the
beginning of the Vector if that first byte has the first bit set, avoiding this
data accidentally being interpreted as a signed integer.
No new tests -- related tests are now passing and are unskipped.
- crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:
(WebCore::CryptoKeyRSA::exportSpki):
- crypto/gcrypt/GCryptUtilities.h:
(WebCore::mpiSignedData):
LayoutTests:
- platform/gtk/TestExpectations: Unskip the RSA SPKI export tests
that are now passing.
- 3:00 AM Changeset in webkit [219448] by
-
- 4 edits in trunk
[GCrypt] Implement CryptoKeyRSA SPKI imports
https://bugs.webkit.org/show_bug.cgi?id=173694
Reviewed by Jiewen Tan.
Source/WebCore:
Implement the SPKI import operation for RSA keys for platforms that use
libgcrypt.
The passed-in key data is decoded against the
SubjectPublicKeyInfoASN.1
structure. We then validate thealgorithm.algorithmelement, ensuring that
the value under that represents a supported object identifier. This check is
for now mostly superficial, only ensuring that the object identifier is either
id-rsaEncryption, id-RSAES-OAEP or id-RSASSA-PSS. This has to be further extended
to also check the id-sha{1,256,384,512}WithRSAEncryption identifiers as well as
decoding thealgorithm.parameterselement against a specific ASN.1 structure,
if necessary (RSASSA-PSS-params or RSAES-OAEP-params), and cross-checking the
specified digest algorithm with the algorithm that's specified through the main
object identifier or the structure contained inalgorithm.parameters. This is
avoided for now because no test in WebKit or the web-platform-tests suite covers
this detail of the specification.
After the algorithm is identified as supported, we proceed with decoding the
subjectPublicKeydata against theRSAPublicKeyASN.1 structure. From there,
we retrieve themodulusandpublicExponentdata from which we can construct
an RSApublic-keys-expression that can be used through libgcrypt. A new
CryptoKeyRSA object is then created, taking over ownership of thepublic-key
s-expression, and returned.
No new tests -- related tests are now passing and are unskipped.
- crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:
(WebCore::supportedAlgorithmIdentifier):
(WebCore::CryptoKeyRSA::importSpki):
LayoutTests:
- platform/gtk/TestExpectations: Unskip the RSA SPKI import tests
that are now passing.
- 2:38 AM Changeset in webkit [219447] by
-
- 7 edits in trunk
REGRESSION(r219332): [GTK] 9 new failures on fast/forms spinbutton related tests
https://bugs.webkit.org/show_bug.cgi?id=174395
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Covered by existing tests.
Before r219332 the height of the spin button widget was
calculated as the maximum value between the individual button
( the [+] or [-] ) width (33 pixels) and height (16 pixels).
And r219332 caused the height of the widget to be calculated as
the height of the button (16 pixels), which was incorrect as
each button should be first expanded vertically to fit the
preferred size of the widget.
Fix this by making the calculations about the spin button widget
on a new function spinButtonSize() that takes this into account,
and use this values both for adjusting the style of the input
field and the spin button widget itself.
- rendering/RenderThemeGtk.cpp:
(WebCore::spinButtonSize):
(WebCore::RenderThemeGtk::adjustTextFieldStyle):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
LayoutTests:
- fast/forms/number/number-spinbutton-in-multi-column.html: Instead of assuming that the width will be 100, calculate a -7 offset dinamically.
- platform/gtk/TestExpectations: Remove expected failures now orking.
- platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png: Rebaseline.
- platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt: Rebaseline.
- 2:21 AM Changeset in webkit [219446] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
eglplatform.h does not support Wayland
https://bugs.webkit.org/show_bug.cgi?id=163482
This makes it possible to build WebKitGTK+ when the target system has only Wayland support,
but no X11 (and therefore the X11 headers are not present).
Reviewed by Alex Christensen.
- include/EGL/eglplatform.h: Add Wayland typedefs when WL_EGL_PLATFORM is defined (for example
by including wayland-egl.h before including EGL/egl.h). Also, include the X11 headers only
when ANGLE_USE_X11 is defined and, for consistency with Mesa's version of the header, when
MESA_EGL_NO_X11_HEADERS is not defined.
- 1:21 AM Changeset in webkit [219445] by
-
- 2 edits in trunk/Source/WebCore
[GTK][WPE] border-radius with non visible border doesn't work on images that have their own RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=174157
Reviewed by Carlos Garcia Campos.
Do not allow direct compositing of images when they have a border-radius property on WebKitGTK+ and WPE.
These platforms don't support clipping using rounded rectangles during composition, which is required
when using border-radius and the border is not visible. Due to this, they need to perform the clippping
with cairo.
This is a temporal fix, until appropriate clipping is implemented in the TextureMapper.
No new tests.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
- 12:47 AM Changeset in webkit [219444] by
-
- 2 edits in trunk/Source/WebCore
AX: WebView crashes app after opening VoiceOver context box menu from modal dialog
https://bugs.webkit.org/show_bug.cgi?id=163999
<rdar://problem/28949013>
Reviewed by Joanmarie Diggs.
Protect when m_object goes away.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
- 12:11 AM Changeset in webkit [219443] by
-
- 13 edits3 adds in trunk
[ESnext] Implement Object Spread
https://bugs.webkit.org/show_bug.cgi?id=167963
Reviewed by Saam Barati.
JSTests:
- stress/obj-rest-destructuring-order.js: Added.
(assert):
(o.get z):
(o.get a):
- stress/obj-spread-order.js: Added.
(assert):
(o.get z):
(o.get a):
- stress/object-spread.js: Added.
(let.assert):
(assert.sameValue):
(let.o.get a):
(let.obj.get c):
(cthulhu.get x):
(let.obj.set c):
(calls.o.get z):
(calls.o.get a):
(try.let.obj.get foo):
(get calls):
Source/JavaScriptCore:
This patch implements ECMA262 stage 3 Object Spread proposal [1].
It's implemented using CopyDataPropertiesNoExclusions to copy
all enumerable keys from object being spreaded. The implementation of
CopyDataPropertiesNoExclusions follows the CopyDataProperties
implementation, however we don't receive excludedNames as parameter.
[1] - https://github.com/tc39/proposal-object-rest-spread
- builtins/GlobalOperations.js:
(globalPrivate.copyDataPropertiesNoExclusions):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoad):
- bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
(JSC::ObjectSpreadExpressionNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createObjectSpreadExpression):
(JSC::ASTBuilder::createProperty):
- parser/NodeConstructors.h:
(JSC::PropertyNode::PropertyNode):
(JSC::ObjectSpreadExpressionNode::ObjectSpreadExpressionNode):
- parser/Nodes.h:
(JSC::ObjectSpreadExpressionNode::expression):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseProperty):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createObjectSpreadExpression):
(JSC::SyntaxChecker::createProperty):
LayoutTests:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
