⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 8, 2007:

11:32 PM Changeset in webkit [23244] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

When does "merge" != "merge"? When you make the change yourself
pre-emptively and make a typo.

11:32 PM Changeset in webkit [20801] by oliver
  • 2 edits in trunk/WebCore

2007-04-08 Oliver Hunt <​oliver@apple.com>

rs=Adam.

Add ASSERT(selectedRange) to previous change

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
11:25 PM Changeset in webkit [23243] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20800.

11:18 PM Changeset in webkit [20800] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Use keyIdentifier instead of keyCode.

11:14 PM Changeset in webkit [20799] by oliver
  • 2 edits in trunk/WebCore

2007-04-08 Oliver Hunt <​oliver@apple.com>

rs=Adam.

Fix minor error when writing selection to pasteboard.
This shouldn't have an effect as selectedRange should be the
selected range from source frame, however this is safer.

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
11:11 PM Changeset in webkit [20798] by hyatt
  • 3 edits in trunk/WebCore

Fix mouseover/out failing layout tests.

Reviewed by aroben

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::updateMouseEventTargetNode): (WebCore::EventHandler::dispatchMouseEvent):
  • page/EventHandler.h:
10:50 PM Changeset in webkit [23242] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20797.

10:49 PM Changeset in webkit [23241] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20796.

10:46 PM Changeset in webkit [23240] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

<rdar://problem/5119804> Web Inspector isn't resizable
<rdar://problem/5119805> Can't move Web Inspector

  • WebInspector/WebInspector.cpp: (WebInspectorPrivate::WebInspectorPrivate): (WebInspector::WebInspector): Subclass the WebView so we can intercept its messages. (WebInspector::onDestroy): Undo the subclassing. (WebInspector::handleMessageSentToWebView): Added. (WebInspector::onLButtonDown): Added. (WebInspector::onLButtonUp): Added. (WebInspector::onMouseMove): Added. (WebInspectorWndProc): Added cases for mouse messages. (SubclassedWebViewWndProc): Added.
  • WebInspector/WebInspector.h:
10:04 PM Changeset in webkit [20797] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Search comment nodes also.

9:51 PM Changeset in webkit [20796] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

A better Xpath query for the simple search case.

9:30 PM Changeset in webkit [20795] by oliver
  • 2 edits in trunk/WebCore

2007-04-08 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for <rdar://problem/5113621> REGRESSION: Dragging PDF as image does not give any feedback

If we fail when attempting to create a drag image for a dragged
image, we fall back to the appropriate icon.

  • page/DragController.cpp: (WebCore::DragController::doImageDrag):
8:55 PM Changeset in webkit [23239] by aroben
  • 4 edits
    3 adds
    2 deletes in branches/WindowsMerge/WebKitWin

Merge in r20793.

8:42 PM Changeset in webkit [23238] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20792.

8:41 PM Changeset in webkit [23237] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20791.

8:38 PM Changeset in webkit [23236] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Stubbed out Frame::dashboardRegionsChanged now that it's not
Mac-specific.

  • bridge/win/FrameWin.cpp: (WebCore::Frame::dashboardRegionsChanged):
8:32 PM Changeset in webkit [20794] by aroben
  • 18 edits
    1 delete in trunk/WebCore

Reviewed by Oliver.

Bestowed the gift of -webkit-dashboard-region upon all platforms, since
there's nothing Mac-specific about it other than the name. This also
allowed me to get rid of FrameViewMac.mm.

Removed a lot of #if PLATFORM(MAC):

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getDashboardRegionValue): (WebCore::CSSPrimitiveValue::):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseDashboardRegions):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • page/Frame.cpp: (WebCore::Frame::paint):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::updateDashboardRegions): Moved from FrameViewMac.mm.
  • page/FrameView.h:
  • page/qt/FrameQt.cpp: (WebCore::Frame::dashboardRegionsChanged): Stubbed out.
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::dashboardRegionsChanged): Ditto.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
  • WebCore.xcodeproj/project.pbxproj: Removed FrameViewMac.mm.
  • bridge/mac/FrameViewMac.mm: Removed.
7:52 PM Changeset in webkit [20793] by thatcher
  • 3 edits
    2 moves
    1 add in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Rename our AppleScrollbar and AppleScrollArea classes and copy in the resize.png image.

5:51 PM Changeset in webkit [20792] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Fixes a typo that was showing the id attribute twice in the tree.

5:50 PM Changeset in webkit [20791] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Use Xpath for the plain text search case. This is faster than walking the DOM in JavaScript.

5:48 PM Changeset in webkit [20790] by bdash
  • 2 edits in branches/WebInspectorRefresh/WebKit

2007-04-09 Mark Rowe <​mrowe@apple.com>

Build fix.

  • WebInspector/WebInspector.m:
5:20 PM Changeset in webkit [23235] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20789.

2:15 PM Changeset in webkit [20789] by thatcher
  • 3 edits in branches/WebInspectorRefresh/WebKit

Implement document searching in JavaScript.

12:08 PM WikiStart edited by kevino@theolliviers.com
Making the page more general so it can fit more info. (diff)
12:02 PM WikiStart edited by kevino@theolliviers.com
Adding page about the Bakefile build system (diff)
11:57 AM Changeset in webkit [23234] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebInspector/WebInspector.cpp:
4:32 AM BuildingQtOnLinux created by sil-webkit@kryogenix.org
4:26 AM WikiStart edited by sil-webkit@kryogenix.org
(diff)
3:15 AM Changeset in webkit [20788] by bdash
  • 2 edits in trunk/WebCore

2007-04-08 Mark Rowe <​mrowe@apple.com>

Qt build fix.

  • platform/qt/TemporaryLinkStubs.cpp:
2:45 AM Changeset in webkit [20787] by mjs
  • 3 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

  • shrink RegexpObjectImp by 4 bytes


Somewhat inexplicably, this seems to be a .33% speedup on JS iBench.


  • kjs/regexp_object.cpp: (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::performMatch): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
  • kjs/regexp_object.h:
2:33 AM Changeset in webkit [20786] by mjs
  • 3 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.


  • shrink ArrayInstance objects by 4 bytes


I did this by storing the capacity before the beginning of the storage array. It turns out
it is rarely needed and is by definition 0 when the storage array is null.

  • kjs/array_instance.h: (KJS::ArrayInstance::capacity):
  • kjs/array_object.cpp: (allocateStorage): (reallocateStorage): (ArrayInstance::ArrayInstance): (ArrayInstance::~ArrayInstance): (ArrayInstance::resizeStorage):
2:22 AM Changeset in webkit [20785] by mjs
  • 3 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

  • fix build issue with last change


  • kjs/function.h:
  • kjs/function.cpp: (KJS::ActivationImp::createArgumentsObject):
1:51 AM Changeset in webkit [23233] by aroben
  • 12 edits
    1 move
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

<rdar://problem/4769828> Web Inspector

  • WebInspector/WebInspector.cpp: Renamed from WebInspector.m. Ported Mac code. Some parts are left commented out to aid later implementation.
  • WebInspector/WebInspector.h: Ditto.
1:48 AM Changeset in webkit [20784] by mjs
  • 6 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.


  • discard the arguments List for an ActivationImp when the corresponding Context is destroyed (1.7% speedup)

Based an idea by Christopher E. Hyde <​C.Hyde@parableuk.force9.co.uk>. His patch to do
this also had many other List changes and I found this much simpler subset of the changes
was actually a hair faster.


This optimization is valid because the arguments list is only kept around to
lazily make the arguments object. If it's not made by the time the function
exits, it never will be, since any function that captures the continuation will
have its own local arguments variable in scope.


Besides the 1.7% speed improvement, it shrinks List by 4 bytes
(which in turn shrinks ActivationImp by 4 bytes).


  • kjs/Context.cpp: (KJS::Context::~Context): Clear the activation's arguments list.
  • kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Adjusted for list changes. (KJS::ActivationImp::mark): No need to mark, lists are always protected (this doesn't cause a ref-cycle for reasons stated above). (KJS::ActivationImp::createArgumentsObject): Clear arguments list.
  • kjs/function.h:
  • kjs/list.cpp: (KJS::List::List): No more needsMarking boolean (KJS::List::operator=): ditto
  • kjs/list.h: (KJS::List::List): ditto (KJS::List::reset): ditto (KJS::List::deref): ditto

Apr 7, 2007:

11:35 PM Changeset in webkit [23232] by aroben
  • 1 edit
    28 adds in branches/WindowsMerge/WebKitWin

Forked most of the WebInspector directory from
r20780 of branches/WebInspectorRefresh/WebKit/WebInspector.

1:25 PM Changeset in webkit [20783] by kevino
  • 1 copy in branches/wx-port-alpha/trunk

Initial copy for wx experimental branch.

1:23 PM Changeset in webkit [20782] by kevino
  • 1 add in branches/wx-port-alpha

Creating wx experimental branch.

12:32 PM Changeset in webkit [20781] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Layout tests for one more case of <rdar://problem/5112273> REGRESSION(TOT):
Reproducible crash loading an old version of amazon.com as a web archive

  • fast/dom/null-document-xmlhttprequest-open-expected.txt: Added.
  • fast/dom/null-document-xmlhttprequest-open.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed one more case of <rdar://problem/5112273> REGRESSION(TOT):
Reproducible crash loading an old version of amazon.com as a web archive

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):

Apr 6, 2007:

10:52 PM Changeset in webkit [23231] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-04-06 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for rdar://problem/5097227 Can't drag Flash-based
scrollbar on mtv.com


The problem was when creating a mouse move event for the
plugin we weren't passing on the mouse button state.


The opensource side of this patch adds logic that allows
us to distinguish between a MouseEvent with NoButton and
a MouseEvent with LeftButton, so we can then provide the
correct information to the plugin.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):


10:44 PM Changeset in webkit [20780] by oliver
  • 4 edits in trunk/WebCore

2007-04-06 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix MouseEvent so it's possible to distinguish between
a MouseMouseEvent with NoButton down, and a move with
LeftButton down. It would be nice if the DOM allowed
for NoButton to exist, but it doesn't so this is necessary.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): (WebCore::MouseEvent::initMouseEvent):
  • dom/MouseEvent.h: (WebCore::MouseEvent::noButton):
9:24 PM Changeset in webkit [20779] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-07 Mark Rowe <​mrowe@apple.com>

Not reviewed. Update to match some configuration changes that have been active on build.webkit.org.

  • BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
8:31 PM Changeset in webkit [20778] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/gdk/MouseEventGdk.cpp:
8:08 PM Changeset in webkit [20777] by kjk
  • 2 edits in trunk/WebCore

Reviewed by darin.

Coverity fix. Coverity says:
"Event var_deref_op: Variable "info_ptr" tracked as NULL was dereferenced."

  • platform/image-decoders/png/pngrutil.c: (png_handle_gAMA):
8:05 PM Changeset in webkit [20776] by kjk
  • 2 edits in trunk/WebCore

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 20709)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,13 @@
+2007-04-04 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>
+
+ Reviewed by darin.
+
+ Coverity fix. Coverity says:
+ "Event var_deref_model: Variable "(this)->clientptr" tracked as NULL was passed to a function that dereferences it."
+
+ * platform/image-decoders/gif/GIFImageReader.cpp:
+ (GIFImageReader::read):
+

2007-04-04 Adele Peterson <​adele@apple.com>


Reviewed by Oliver.

Index: WebCore/platform/image-decoders/gif/GIFImageReader.cpp
===================================================================
--- WebCore/platform/image-decoders/gif/GIFImageReader.cpp (revision 20709)
+++ WebCore/platform/image-decoders/gif/GIFImageReader.cpp (working copy)
@@ -760,7 +760,8 @@ bool GIFImageReader::read(const unsigned

if (query == GIFImageDecoder::GIFSizeQuery
haltAtFrame == images_decoded) {

The decoder needs to stop. Hand back the number of bytes we consumed from
 buffer minus 9 (the amount we consumed to read the header).

  • clientptr->decodingHalted(len + 9);

+ if (clientptr)
+ clientptr->decodingHalted(len + 9);

GETN(9, gif_image_header);
return true;

}

8:02 PM Changeset in webkit [20775] by kjk
  • 2 edits in trunk/JavaScriptCore

Index: JavaScriptCore/ChangeLog
===================================================================
--- JavaScriptCore/ChangeLog (revision 20709)
+++ JavaScriptCore/ChangeLog (working copy)
@@ -1,3 +1,14 @@
+2007-04-04 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>
+
+ Reviewed by darin.
+
+ Coverity fix. Coverity says:
+ "Event var_deref_model: Variable "sourceRanges" tracked as NULL was passed to a
+ function that dereferences it"
+
+ * kjs/string_object.cpp:
+ (KJS::replace):
+

2007-04-03 Kevin McCullough <​kmccullough@apple.com>


Reviewed by Adam.

Index: JavaScriptCore/kjs/string_object.cpp
===================================================================
--- JavaScriptCore/kjs/string_object.cpp (revision 20709)
+++ JavaScriptCore/kjs/string_object.cpp (working copy)
@@ -387,7 +387,9 @@ static JSValue *replace(ExecState *exec,

if (lastIndex < source.size())

pushSourceRange(sourceRanges, sourceRangeCount, sourceRangeCapacity, UString::Range(lastIndex, source.size() - lastIndex));


  • UString result = source.spliceSubstringsWithSeparators(sourceRanges, sourceRangeCount, replacements, replacementCount);

+ UString result;
+ if (sourceRanges)
+ result = source.spliceSubstringsWithSeparators(sourceRanges, sourceRangeCount, replacements, replacementCount);

delete [] sourceRanges;
delete [] replacements;

6:53 PM Changeset in webkit [20774] by bdash
  • 1 edit in tags/Safari-5522.5.1/WebCore/Configurations/Version.xcconfig

Versioning.

6:51 PM Changeset in webkit [20773] by bdash
  • 2 edits in tags/Safari-5522.5.1/WebCore

Merge in r20764.

6:36 PM Changeset in webkit [20772] by bdash
  • 1 copy in tags/Safari-5522.5.1/WebCore

New tag (part 2).

6:35 PM Changeset in webkit [20771] by bdash
  • 1 add in tags/Safari-5522.5.1

New tag (part 1).

6:24 PM Changeset in webkit [20770] by bdash
  • 1 delete in tags/Safari-5522.6.1

Remove tag.

6:09 PM Changeset in webkit [20769] by bdash
  • 1 copy in tags/Safari-5522.6.1/WebCore

New tag (part 2).

6:07 PM Changeset in webkit [20768] by bdash
  • 1 add in tags/Safari-5522.6.1

New tag (part 1).

5:56 PM Changeset in webkit [20767] by hyatt
  • 2 edits in trunk/WebCore

Fix more of the layout test failures caused by fixing the slider layout test failure (sigh). clear()
needs to null out the capturingMouseEventsNode in the case where a mousedown or move while captured
causes a navigation to another page.

  • page/EventHandler.cpp: (WebCore::EventHandler::clear): (WebCore::EventHandler::handleMouseReleaseEvent):
5:15 PM Changeset in webkit [20766] by hyatt
  • 2 edits in trunk/WebCore

Fix failing slider layout test. Don't clear the subframe capture unless we really were capturing on a
subframe.

Reviewed by adele, darin

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
4:59 PM Changeset in webkit [20765] by thatcher
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.mm

Build fix attempt.

4:56 PM Changeset in webkit [20764] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Geoff and Darin.

Fix for <rdar://problem/4875433> WebView underlines are too thick
when scaled small

When we have a small scale factor, we should follow the line-
drawing code as if we were printing. Meaning, specifically, that we
should not round to device pixels and we should antialias.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText):
4:12 PM Changeset in webkit [20763] by ggaren
  • 3 edits
    10 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Layout tests for <rdar://problem/5112273> REGRESSION(TOT): Reproducible
crash loading an old version of amazon.com as a web archive

  • fast/dom/null-document-location-assign-crash-expected.txt: Added.
  • fast/dom/null-document-location-assign-crash.html: Added.
  • fast/dom/null-document-location-href-put-crash-expected.txt: Added.
  • fast/dom/null-document-location-href-put-crash.html: Added.
  • fast/dom/null-document-location-put-crash-expected.txt: Added.
  • fast/dom/null-document-location-put-crash.html: Added.
  • fast/dom/null-document-location-replace-crash-expected.txt: Added.
  • fast/dom/null-document-location-replace-crash.html: Added.
  • fast/dom/null-document-window-open-crash-expected.txt: Added.
  • fast/dom/null-document-window-open-crash.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed <rdar://problem/5112273> REGRESSION(TOT): Reproducible crash loading
an old version of amazon.com as a web archive


The problem was JavaScript executing inside a frame with a NULL document.
It's probably a bug that the document was NULL, but we don't want a minor
bug to be a crasher, and we don't want the DOM to depend on the implementation
details of the JS bindings, so I added NULL checks.

  • bindings/js/kjs_window.cpp: Call FrameLoader::completeURL instead of Document::completeURL, since FrameLoader::completeURL is safe against a NULL document. (KJS::Window::put): (KJS::WindowFunc::callAsFunction): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
3:11 PM Changeset in webkit [20762] by aroben
  • 5 edits in trunk/LayoutTests

Reviewed by Adele.

These two editing tests were using the wrong case for
dumpEditingCallbacks, which meant that they were falling into DRT's
invokeUndefinedMethodFromWebScript instead of actually turning on the
callback dumping.


This patch fixes the case of the call and updates the results.

  • editing/execCommand/4641880-1-expected.txt:
  • editing/execCommand/4641880-1.html:
  • editing/execCommand/4641880-2-expected.txt:
  • editing/execCommand/4641880-2.html:
2:52 PM Changeset in webkit [23230] by hyatt
  • 11 edits in branches/WindowsMerge

Fix for bug 13274

2:37 PM Changeset in webkit [20761] by hyatt
  • 6 edits in trunk/WebCore

Fix for bug 13274. Rework mouse events so that subframe capturing works again. Make sure
everything just comes down through the top FrameView even when capturing is in effect. Update
scrollbar handling logic so that scrollbars receive events correctly while capturing is in
effect. Eliminate the notion of widget capture. Fix mouse moves so that they only fire
on the innermost hit frame.

Reviewed by olliej

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::subframeForTargetNode): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent):
  • page/EventHandler.h:
  • platform/PopupMenu.h: (WebCore::PopupMenu::scrollbarCapturingMouse): (WebCore::PopupMenu::setScrollbarCapturingMouse):
  • platform/ScrollBar.h: (WebCore::Scrollbar::handleMouseReleaseEvent):
  • platform/Widget.h: (WebCore::Widget::geometryChanged):
1:34 PM Changeset in webkit [23229] by bdash
  • 3 edits in branches/WindowsMerge/WebCore

2007-04-07 Mark Rowe <​mrowe@apple.com>

Internal build fox after opensource r20753.

  • platform/win/PlatformMouseEventWin.cpp:
  • platform/win/TemporaryLinkStubs.cpp:
11:59 AM Changeset in webkit [20760] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/5115601>
REGRESSION: Crash deleting a selection that starts in an editable table cell

  • editing/deleting/5115601-expected.checksum: Added.
  • editing/deleting/5115601-expected.png: Added.
  • editing/deleting/5115601-expected.txt: Added.
  • editing/deleting/5115601.html: Added.

WebCore:

Reviewed by john

<rdar://problem/5115601>
REGRESSION: Crash deleting a selection that starts in an editable table cell


The selection starts at the start of an editable
root that's embedded in a non-editable ToDo (table).
Removing the selection removes all editable
VisiblePositions from the root. Then, the creation
of mergeDestination fails, and using it causes a crash.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Nil-check mergeDestination to avoid crashing and also insert a break in that case at m_upstreamStart, so that we can create a valid mergeDestination and perform the merge.
11:36 AM Changeset in webkit [20759] by ggaren
  • 2 edits in trunk/JavaScriptCore

Rubber stamped by Adele Peterson.

  • kjs/ExecState.h: Removed obsolete forward/friend declaration of RuntimeMethodImp.
10:47 AM Changeset in webkit [20758] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by.

  • Fixing a test failure.
  • http/tests/misc/iframe-invalid-source-crash-expected.txt:
9:55 AM Changeset in webkit [20757] by bdash
  • 7 edits in trunk

Versioning and ChangeLog markers.

9:31 AM Changeset in webkit [20756] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebKit.xcodeproj/project.pbxproj

Remove WebInspectorOutlineView from the project.

9:29 AM Changeset in webkit [20755] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Mark Rowe.

Adds a build phase script that ensures WebKit's version dosen't end in a 4.
If our version ends in 4, some sites might think we are Netscape 4 in their
user agent checks.

  • Configurations/Version.xcconfig:
  • WebKit.xcodeproj/project.pbxproj:
8:03 AM Changeset in webkit [20754] by bdash
  • 3 edits in tags/Safari-5522.6

Versioning.

7:58 AM Changeset in webkit [20753] by bdash
  • 7 edits in trunk/WebCore

2007-04-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Oliver.

Eliminate PlatformMouseEvent::currentEvent.

No test possible (no change to functionality).

  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag):
  • platform/PlatformMouseEvent.h:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/mac/PlatformMouseEventMac.mm: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/qt/PlatformMouseEventQt.cpp:
  • platform/win/TemporaryLinkStubs.cpp:
7:56 AM Changeset in webkit [20752] by bdash
  • 1 edit in trunk/WebKit/ChangeLog

Fix typo in ChangeLog.

7:47 AM Changeset in webkit [20751] by bdash
  • 1 copy in tags/Safari-5522.6

New tag.

6:21 AM Changeset in webkit [20750] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-04-05 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by ​zbujtas@gmail.com
DESC: fix wrong meta tag detection.
​http://bugs.webkit.org/show_bug.cgi?id=13290

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/misc/decoder.cpp: (Decoder::decode):
6:17 AM Changeset in webkit [20749] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2007-04-05 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by ​zbujtas@gmail.com
DESC: fix wrong meta tag detection.
​http://bugs.webkit.org/show_bug.cgi?id=13290

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/misc/decoder.cpp: (Decoder::decode):
3:26 AM Changeset in webkit [20748] by mjs
  • 4 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.


  • shrink PropertyMap by 8 bytes and therefore shrink CELL_SIZE to 40 (for 32-bit; similar shrinkage for 64-bit)

Inspired by similar changes by Christopher E. Hyde <​C.Hyde@parableuk.force9.co.uk>
done in the kjs-tweaks branch of KDE's kjs. However, this version is somewhat
cleaner style-wise and avoids some of the negative speed impact (at least on gcc/x86)
of his version.


This is nearly a wash performance-wise, maybe a slight slowdown, but worth doing
to eventually reach cell size 32.


  • kjs/collector.cpp: (KJS::):
  • kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::expand): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::getSparseArrayPropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::checkConsistency):
  • kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): (KJS::PropertyMap::setHasGetterSetterProperties): (KJS::PropertyMap::): (KJS::PropertyMap::PropertyMap):
1:26 AM Changeset in webkit [20747] by mjs
  • 2 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.


  • change blocks to 64k in size, and use various platform-specific calls to allocate at 64k-aligned addresses
  • kjs/collector.cpp: (KJS::allocateBlock): (KJS::freeBlock): (KJS::Collector::allocate): (KJS::Collector::collect):

Apr 5, 2007:

11:45 PM Changeset in webkit [20746] by oliver
  • 3 edits
    4 adds in trunk

2007-04-05 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

WebCore:

Fix for rdar://problem/4849948 -- JSCanvasRenderingContext2D::drawImage
crashes when given invalid arguments.

JSCanvasRenderingContext2D frequently casts from JSValue* to JSObject*
and then checks isObject *after* the cast. JSObject::isObject is unsafe
if applied to a JSImmediate value (null, undefined, etc). This patch
corrects the logic in a number of places by performing the isObject check
before casting to JSObject.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::createPattern):

LayoutTests:

Layout tests for rdar://problem/4849948
Make sure we don't crash when passing invalid args to Canvas::drawImage

  • fast/canvas/drawImage-with-invalid-args-expected.checksum: Added.
  • fast/canvas/drawImage-with-invalid-args-expected.png: Added.
  • fast/canvas/drawImage-with-invalid-args-expected.txt: Added.
  • fast/canvas/drawImage-with-invalid-args.html: Added.
11:19 PM Changeset in webkit [20745] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.css

Add -webkit-dashboard-region to select and input elements to prevent dragging the window in those areas.

11:09 PM Changeset in webkit [20744] by aroben
  • 2 edits in branches/WebInspectorRefresh/WebKit

Reviewed by Tim.

When navigating to a parent node via the inspector's popup menu, don't
blow away all the children in the list so that it's easy to get back
to them later.

  • WebInspector/webInspector/inspector.js: (function updateTreeOutline): Don't reset the popup if we're navigating to a node already in the popup.
10:25 PM Changeset in webkit [20743] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/4965597> REGRESSION: mouseup doesn't fire for slider (causes it to always default to max)

  • fast/forms/slider-mouse-events-expected.txt: Added.
  • fast/forms/slider-mouse-events.html: Added.

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/4965597> REGRESSION: mouseup doesn't fire for slider (causes it to always default to max)

Test: fast/forms/slider-mouse-events.html

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Since the actual target node of the event can't be a shadow node, set the target node to the capturing node before adjusting it.
8:05 PM Changeset in webkit [20742] by andersca
  • 10 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adam.

<rdar://problem/5083023>
REGRESSION: In Real Player (10.1.0), video continues to play after closing window

Add a test where a window containing a plugin is opened and then closed. The window is closed
without calling -[WebView close].


  • plugins/open-and-close-window-with-plugin-expected.txt: Added.
  • plugins/open-and-close-window-with-plugin.html: Added.
  • plugins/resources/open-and-close-window-with-plugin.html: Added.

WebKit:

Reviewed by Adam.

<rdar://problem/5083023>
REGRESSION: In Real Player (10.1.0), video continues to play after closing window


This broke in revision 18422 because now the plugin isn't stopped when the window is closed. Since the window is retained
by the plugin view for as long as it is running (so that removeTrackingRect works even though the window has been closed),
we would end up with a reference cycle (NSWindow -> WebView -> PluginView -> NSWindow) and stopping the plug-in when the window
was closed would break that cycle.


Applications that call -[WebView close] when closing aren't affected, but RealPlayer doesn't do this.


The bug that 18422 was supposed to fix was fixed by 19275, which is why it's safe to add back the check.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (-[WebBaseNetscapePluginView windowWillClose:]):

WebKitTools:

Reviewed by Adam.

Add support for opening new windows in DumpRenderTree.


(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(+[LayoutTestController webScriptNameForSelector:]):
(-[LayoutTestController setCallCloseOnWebViews:]):
(-[LayoutTestController setCanOpenWindows]):
Add two new methods callable from JavaScript. setCanOpenWindows controls whether a test
can open new windows, and setCallCloseOnWebViews controls whether -[WebView close] should be called on
web views that are about to be closed.


(runTest):
Make sure that only the main window is around when a test has finished running.


(-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
(-[DumpRenderTreeWindow dealloc]):
Manage the set of windows.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_Destroy): Add a "logDestroy" property which controls whether plugins should print when they are destroyed or not.


  • DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:createWebViewWithRequest:]): Create new windows.


(-[UIDelegate webViewClose:]):
Close windows.

6:46 PM Changeset in webkit [20741] by andersca
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

Move WebView and NSWindow creation to a separate function in preparation of supporting opening new
windows in DRT.

  • DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree):
6:05 PM Changeset in webkit [20740] by kmccullo
  • 14 edits in trunk

LayoutTests:

Reviewed by Darin.

  • Now we add a console message when local resources are blocked.
  • http/tests/security/local-CSS-from-remote-expected.txt:
  • http/tests/security/local-JavaScript-from-remote-expected.txt:
  • http/tests/security/local-iFrame-from-remote-expected.txt:
  • http/tests/security/local-image-from-remote-expected.txt:

WebCore:

Reviewed by Darin.

  • Added reportLocalLoadFailed to FrameLoader to send an error to the console when calls to canLoad fail.
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::load): (WebCore::FrameLoader::reportLocalLoadFailed):
  • loader/FrameLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):

WebKit:

Reviewed by Darin.

  • Moved registerURLSchemeAsLocal to the public API.
  • WebView/WebView.h:
  • WebView/WebView.mm: (+[WebView registerURLSchemeAsLocal:]):
  • WebView/WebViewPrivate.h:
5:42 PM Changeset in webkit [20739] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Add text-align: -webkit-auto for form controls. Buttons already override this property to center their text.

  • css/html4.css:
3:52 PM Changeset in webkit [20738] by kjk
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

Coverity fix. Coverity says:
"Event check_after_deref: Pointer "dateString" dereferenced before NULL check"

  • kjs/date_object.cpp: (KJS::parseDate):
3:50 PM Changeset in webkit [20737] by kjk
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

Coverity fix. Coverity says:
"Event check_after_deref: Pointer "re" dereferenced before NULL check"

  • pcre/pcre_study.c: (pcre_study):
3:45 PM Changeset in webkit [20736] by kjk
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

Coverity fixes. Coverity says:
"Event leaked_storage: Returned without freeing storage "buffer""
and:
"Event leaked_storage: Returned without freeing storage "script""

  • kjs/testkjs.cpp: (doIt): (createStringWithContentsOfFile):
3:42 PM Changeset in webkit [20735] by kjk
  • 2 edits in trunk/WebCore

Reviewed by rwlbuis.

Coverity fix. Coverity says:
"Event var_deref_model: Variable "page" tracked as NULL was passed to a function that dereferences it."

  • platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):
3:38 PM Changeset in webkit [20734] by kjk
  • 2 edits in trunk/WebCore

Reviewed by darin.

Coverity fix. Coverity says:
"Event var_deref_model: Variable "unicode" tracked as NULL was passed to a
function that dereferences it."

  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::DeprecatedString):
3:33 PM Changeset in webkit [20733] by kjk
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

Coverity fix: in single-threaded case currentThreadIsMainThread is always true
so the code in if (!currentThreadIsMainThread) cannot possibly be reached
and Coverity complains about dead code.

  • kjs/collector.cpp: (KJS::Collector::collect):
2:26 PM Changeset in webkit [20732] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5113593> REGRESSION: Search fields in RSS pages don't show ibeam cursor

  • css/html4.css: Set the cursor values explicitly for input, textarea (to auto), & select (to default).
2:21 PM Changeset in webkit [20731] by hyatt
  • 3 edits in trunk/WebCore

Fix for <rdar://problem/5078866> tables should only reset text-align
in quirks mode.

Reviewed by beth

  • css/html4.css:
  • css/quirks.css:
1:40 PM Changeset in webkit [20730] by sfalken
  • 1 copy in tags/Safari-522.5.5b

New tag.

1:36 PM Changeset in webkit [20729] by adele
  • 2 edits in trunk/WebCore

Fixing typo that's crashing.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Use evt instead of null variable k.
1:30 PM Changeset in webkit [20728] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5021500> Cursor should stay as pointer when slider is being dragged

Don't set the selection ibeam cursor when there's a node that's capturing mouse events.

  • page/EventHandler.cpp: (WebCore::selectCursor): (WebCore::EventHandler::handleMouseMoveEvent):
12:55 PM Changeset in webkit [20727] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-04-04 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Setting status to KErrCancel when the request dispatcher does not define a loader causes a problem for the history stack, reverting to previous.
​http://bugs.webkit.org/show_bug.cgi?id=13232

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
12:55 PM Changeset in webkit [20726] by spadma
  • 2 edits in S60/trunk/WebKit

2007-04-04 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Setting status to KErrCancel when the request dispatcher does not define a loader causes a problem for the history stack, reverting to previous.
​http://bugs.webkit.org/show_bug.cgi?id=13232

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
12:33 PM Changeset in webkit [20725] by ggaren
  • 12 edits in trunk/WebCore

Reviewed by Beth Dakin.

More clean-up while fixing <rdar://problem/5112273> REGRESSION(TOT):
Reproducible crash loading an old version of amazon.com as a web archive


Layout tests pass.


Removed more superfluous document NULL checks. (Node::document() never
returns NULL, and it asserts as much.)


Merged some duplicate editing code into a static inline function.


  • page/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings): Removed superfluous static_cast.
11:41 AM Changeset in webkit [20724] by adele
  • 8 edits in trunk/WebCore

Reviewed by Darin.

A little cleanup from my last checkin. Always check if an Event is really a MouseEvent or a KeyboardEvent
before casting it.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler): (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):
10:48 AM Changeset in webkit [20723] by ggaren
  • 9 edits in trunk/WebCore

Reviewed by Beth Dakin.


Some clean-up while fixing <rdar://problem/5112273> REGRESSION(TOT):
Reproducible crash loading an old version of amazon.com as a web archive


Removed superfluous document NULL checks. (Node::document() never returns
NULL, and it asserts as much.)


Removed duplicate implementation of displayString.


Layout tests pass.

  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMInternal.mm:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::supportsFocus):
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • rendering/HitTestResult.cpp: (WebCore::displayString):
  • rendering/HitTestResult.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateHoverActiveState):
9:35 AM Changeset in webkit [20722] by mjs
  • 2 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.


  • remove the concept of oversize objects, now that there aren't any (for now only enforced with an assert).

This change is a .66% speedup on JS iBench for 32-bit platforms, probably much more
for 64-bit since it finally gives a reasonable cell size, but I did not test that.


  • kjs/collector.cpp: (KJS::): Use different cell size for 32-bit and 64-bit, now that there is no oversize allocation. (KJS::Collector::allocate): Remove oversize allocator. (KJS::Collector::markStackObjectsConservatively): Don't check oversize objects. (KJS::Collector::markMainThreadOnlyObjects): Ditto. (KJS::Collector::collect): Ditto.
8:24 AM Changeset in webkit [20721] by yongjzha
  • 4 edits in S60/trunk/WebKit

hongzhao, reviewed by ​yongjun.zhang@nokia.com

DESC: [S60]Animated images with DRM content won't be displayed in Browser in 3.2
Fix: Handle DRM image content during construct the content.
​http://bugs.webkit.org/show_bug.cgi?id=13258

  • BrowserCore/Renderers/inc/AnimationDecoder.h:
  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CRawData::DecodeDRMImageContentL): (CStaticImageDecoder::LoadNextImage):
3:20 AM Changeset in webkit [20720] by oliver
  • 3 edits
    3 adds in trunk

2007-04-05 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

Fix rdar://problem/5030934 -- landscape PDFs embedded as an image are cut off
also fixes scaling of pdf images

PDFDocumentImage was not accounting for page rotation in a number of places

  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::size): we need to account for rotation of the pdf image effecting our bounds (WebCore::PDFDocumentImage::draw): When compensating for flipped coords we need to use the correct rect for the coordinate space. We can't pass size() to CGContextDrawPDFDocument as it returns the rotated bounds now -- this is also save the old FloatSize -> IntSize -> FloatSize conversions.

LayoutTests:

Testcase for landscape pdfs as image

rdar://problem/5030934 -- landscape PDFs embedded as an image are cut off

  • fast/images/pdf-as-image-landscape-expected.txt: Added.
  • fast/images/pdf-as-image-landscape.html: Added.
  • fast/images/resources/pdf_test_landscape.pdf: Added.
3:08 AM Changeset in webkit [20719] by mjs
  • 4 edits in branches/js-collector-tweaks/WebCore

Not reviewed - experimental work.

  • move most of Window's data members into a separate private object, to avoid needing to use the oversize allocator for it


It was the only remaining JSObject subclass to use the ocersize
allocator on 32-bit platforms, and having oversize objects around
makes garbage collection slower so this would hurt performance
with many tabs/windows open.


No significant effect on JS iBench.

  • bindings/js/kjs_events.cpp: (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): (KJS::JSEventListener::JSEventListener): (KJS::JSEventListener::~JSEventListener): (KJS::JSLazyEventListener::parseCode):
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::Window): (KJS::Window::~Window): (KJS::Window::location): (KJS::Window::selection): (KJS::Window::locationbar): (KJS::Window::menubar): (KJS::Window::personalbar): (KJS::Window::statusbar): (KJS::Window::toolbar): (KJS::Window::scrollbars): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::findJSEventListener): (KJS::Window::findJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear): (KJS::Window::setCurrentEvent): (KJS::Window::setReturnValueSlot): (KJS::Window::clearAllTimeouts): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::Window::clearTimeout): (KJS::Window::timerFired): (KJS::Window::disconnectFrame): (KJS::Window::jsEventListeners): (KJS::Window::jsHTMLEventListeners): (KJS::Window::jsUnprotectedEventListeners): (KJS::Window::jsUnprotectedHTMLEventListeners):
  • bindings/js/kjs_window.h:
3:03 AM Changeset in webkit [20718] by mjs
  • 1 copy in branches/js-collector-tweaks

vn cp ​svn+ssh://mjs@svn.opensource.apple.com/svn/webkit/trunk/JavaScriptCore ​svn+ssh://mjs@svn.opensource.apple.com/svn/webkit/branches/js-collector-tweaks/JavaScriptCore
Enter passphrase for key '/Users/mjs/.ssh/id_rsa':
subversion/libsvn_repos/commit.c:392: (apr_err=160016)
svn: Path 'branches/js-collector-tweaks' not present

Apr 4, 2007:

11:04 PM Changeset in webkit [20717] by thatcher
  • 4 edits in branches/WebInspectorRefresh/WebKit/WebInspector

Move the tree splitter resize code down into JavaScript. Some other cleanup work.

10:24 PM Changeset in webkit [20716] by bdash
  • 2 edits in trunk/WebKitSite

2007-04-05 Mark Malone <​markmalone@mac.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13273
Bug 13273: DOM Interfaces Nav link should go somewhere more useful

  • nav.inc: Link directly to the hierarchy.
10:22 PM Changeset in webkit [20715] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Make selecting a new root element from the root popup menu work. Also reverse the order of the parent nodes shown in the popup, with the document at the top. Fixes bug 6615.

9:40 PM Changeset in webkit [20714] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13278
REGRESSION: cannot change SELECT option

Test: fast/forms/option-change-single-selected.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): If multiple selection is not allowed, be sure to deselect the previous option.
9:39 PM Changeset in webkit [20713] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/WebInspector.m

Remove my machine specific path.

9:37 PM Changeset in webkit [20712] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/AppleScrollbar.js

Only call this.refresh() if this.hidden is true. This was causing a 'maximum call stack size' exception.

9:26 PM Changeset in webkit [20711] by thatcher
  • 3 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Move our override scrollbar and scroll-area code to our copies of AppleScrollbar.js and AppleScrollArea.js.

8:43 PM Changeset in webkit [20710] by thatcher
  • 2 edits
    2 adds in branches/WebInspectorRefresh/WebKit/WebInspector

Keep our own copy of AppleScrollbar.js and AppleScrollArea.js, copied /System/Library/WidgetResources/AppleClasses.

6:39 PM Changeset in webkit [23228] by oliver
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-04-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada.


Fix <rdar://problem/5111027> Dragging a link on page
shows URL thumbnail as nearly-transparent instead
semi-transparent

Error in createDragImageForLink led me to get wrong
maximum drag image size, now logic and maximum drag
image size corrected.

  • WebDragClient.cpp: (WebDragClient::createDragImageForLink):


6:05 PM Changeset in webkit [20709] by adele
  • 9 edits in trunk/WebCore

Reviewed by Oliver.

Fix for <rdar://5105009> Prepare for fix to send mousedown and mouseup (but not click) events when right-clicking

  • page/EventHandler.cpp: Don't ever send click events for right-clicks. (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent):


Check that the mousedown and mouseup are not with the right button before performing default behavior.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler): (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
  • ksvg2/svg/SVGAElement.cpp:(WebCore::SVGAElement::defaultEventHandler):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):
2:40 PM Changeset in webkit [23227] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Release build fix for TestNetscapePlugin.

  • WebKit.vcproj/WebKit.vcproj: Make the Release post-build step the same as the Debug one so that the npapi headers get copied.
1:52 PM Changeset in webkit [20708] by sfalken
  • 19 edits in branches/Safari-522/WebCore

Re-merge fix from r20674

1:49 PM Changeset in webkit [20707] by justing
  • 4 edits
    12 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5026848> Can cut/delete To Do subunits

This tests to make sure that non-editable content
that is in both the start and end editable roots
is removed:

  • editing/deleting/5026848-1-expected.checksum: Added.
  • editing/deleting/5026848-1-expected.png: Added.
  • editing/deleting/5026848-1-expected.txt: Added.
  • editing/deleting/5026848-1.html: Added. This tests to make sure that non-editable content that is not in both the start and end editable roots is not removed:
  • editing/deleting/5026848-2-expected.checksum: Added.
  • editing/deleting/5026848-2-expected.png: Added.
  • editing/deleting/5026848-2-expected.txt: Added.
  • editing/deleting/5026848-2.html: Added. This tests to make sure that editable regions that are not in both the start and end editable roots are cleared (not removed, unless they are in another editable region):
  • editing/deleting/5026848-3-expected.checksum: Added.
  • editing/deleting/5026848-3-expected.png: Added.
  • editing/deleting/5026848-3-expected.txt: Added.
  • editing/deleting/5026848-3.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5026848> Can cut/delete ToDo subunits


We were removing non-editable content during a delete.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Set m_startRoot and m_endRoot. (WebCore::DeleteSelectionCommand::removeNode): If a node is not inside both the start and end roots, remove it only if it is in editable content.
  • editing/DeleteSelectionCommand.h: Added m_startRoot and m_endRoot, the editable roots that contain the start and end of the selection, respectively. We consult these every time we remove a node, and don't want to recompute them on every call to removeNode().
1:39 PM Changeset in webkit [20706] by sfalken
  • 19 edits in branches/Safari-522/WebCore

Roll out r20705,r20701

11:24 AM Changeset in webkit [20705] by sfalken
  • 1 edit in branches/Safari-522/WebCore/loader/DocLoader.cpp

Fix merge from r20674

10:33 AM Changeset in webkit [20704] by zbujtas
  • 3 edits in S60/trunk/WebCore

2007-04-04 bujtas <​zbujtas@gmail.com>

Reviewed by Sriram.
DESC: change nested <q> behavior so that q q {} gets ' instead of " -antti(c).
​http://bugs.webkit.org/show_bug.cgi?id=13280


  • khtml/css/html4.css:
  • khtml/css/html4_gcce.css:
10:30 AM Changeset in webkit [20703] by andersca
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5107536>
​http://bugs.webkit.org/show_bug.cgi?id=13264
REGRESSION: Crash when canceling about:blank in Activity viewer


  • WebView/WebFrame.mm: (-[WebFrame stopLoading]): Add a null check for the frame loader - it can be null when the frame has been disconnected from the web page.
10:28 AM Changeset in webkit [20702] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2007-04-04 bujtas <​zbujtas@gmail.com>

Reviewed by Sriram.
DESC: change nested <q> behavior so that q q {} gets ' instead of "
​http://bugs.webkit.org/show_bug.cgi?id=13280


  • khtml/css/html4.css:
  • khtml/css/html4_gcce.css:
10:28 AM Changeset in webkit [20701] by sfalken
  • 19 edits in branches/Safari-522/WebCore

Merged fix from r20674

10:12 AM Changeset in webkit [20700] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merged fix from r20669

9:47 AM Changeset in webkit [20699] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Turn's out Brady's not the only one who can rewrite history!

1:25 AM Changeset in webkit [23226] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • Skipped: Re-enable some tests that no longer crash.

Apr 3, 2007:

11:39 PM Changeset in webkit [20698] by thatcher
  • 6 edits
    2 deletes in branches/WebInspectorRefresh/WebKit/WebInspector

Convert the Web Inspector NSOutlineView into an HTML and JavaScript based tree view. Not everything is working yet.

11:36 PM Changeset in webkit [20697] by thatcher
  • 1 copy in branches/WebInspectorRefresh

New branch to update the Web Inspector to use more HTML and JavaScript and remove the NSOutlineView.

10:55 PM Changeset in webkit [23225] by aroben
  • 6 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Anders.

DRT part of fix for <rdar://problem/5103999> All dom/svg tests are
failing due to extra/missing newlines

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Call IDOMElementPrivate::innerText to match Mac DRT.

WebKitWin:

Reviewed by Anders.

WebKit part of fix for <rdar://problem/5103999> All dom/svg tests are
failing due to extra/missing newlines

  • DOMCoreClasses.cpp: (DOMElement::innerText): Added.
  • DOMCoreClasses.h: Added declaration.
  • Interfaces/DOMPrivate.idl: Ditto.
10:32 PM Changeset in webkit [23224] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Rubberstamped by Adele.

Make all layout tests paint to match Mac DRT. This fixes many tests in
svg/hixie.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Always force a paint.
7:12 PM Changeset in webkit [20696] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Testing a post-commit hook.
6:32 PM Changeset in webkit [20695] by andersca
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Adam.

<rdar://problem/5107534>
​http://bugs.webkit.org/show_bug.cgi?id=13265
REGRESSION: Crash in KJS::Bindings::convertValueToNPVariant


  • bindings/NP_jsobject.cpp: (_NPN_InvokeDefault): Return false if the object isn't a function.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5107534>
​http://bugs.webkit.org/show_bug.cgi?id=13265
REGRESSION: Crash in KJS::Bindings::convertValueToNPVariant

  • plugins/netscape-invoke-default.html: Test calling NPN_InvokeDefault on an object that isn't a function.
5:22 PM Changeset in webkit [20694] by andersca
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5028178>
Crash occurs at WebCore::FrameLoader::activeDocumentLoader() after loading Froggster widget

  • plugins/get-url-that-the-resource-load-delegate-will-disallow-expected.txt: Added.
  • plugins/get-url-that-the-resource-load-delegate-will-disallow.html: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/5028178>
Crash occurs at WebCore::FrameLoader::activeDocumentLoader() after loading Froggster widget


  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream start]): If load returns no the plugin loader has already been removed by the didFail callback.

WebKitTools:

Reviewed by Darin.

Add the notion of a "disallowed URL", which the resource loader won't allow to be loaded.


  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController addDisallowedURL:]): (runTest):
  • DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
4:31 PM Changeset in webkit [20693] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5108896>, make sure the assert for setEncodedSize
deals with the error case.

Reviewed by andersca

  • loader/CachedResource.cpp: (WebCore::CachedResource::setEncodedSize):
4:22 PM Changeset in webkit [20692] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • loader/ImageDocument.cpp: Don't call error() in stopParsing.
3:50 PM Changeset in webkit [20691] by justing
  • 5 edits
    1 delete in trunk/LayoutTests

Reviewed by darin


<​http://bugs.webkit.org/show_bug.cgi?id=13268>
Make editing/selection/drag-in-iframe.html valid and deterministic

  • editing/resources/select-and-drag-iframe.html: Removed.
  • editing/selection/drag-in-iframe-expected.checksum:
  • editing/selection/drag-in-iframe-expected.png:
  • editing/selection/drag-in-iframe-expected.txt:
  • editing/selection/drag-in-iframe.html:
3:12 PM Changeset in webkit [23223] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-04-03 Oliver Hunt <​oliver@apple.com>

Buildfix

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):

Adding .get() calls

3:07 PM Changeset in webkit [20690] by adele
  • 4 edits in trunk/LayoutTests

Updated results for recent change to always lighten disabled text color for black text.

  • fast/forms/input-disabled-color-expected.checksum:
  • fast/forms/input-disabled-color-expected.png:
  • fast/forms/input-disabled-color-expected.txt:
2:57 PM Changeset in webkit [20689] by justing
  • 119 edits in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5107422>
TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app

moveParagraphs no longer calls shouldInsert:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-001-expected.txt:
  • editing/deleting/delete-block-merge-contents-002-expected.txt:
  • editing/deleting/delete-block-merge-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-004-expected.txt:
  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-007-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:
  • editing/deleting/delete-block-merge-contents-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-010-expected.txt:
  • editing/deleting/delete-block-merge-contents-012-expected.txt:
  • editing/deleting/delete-block-merge-contents-013-expected.txt:
  • editing/deleting/delete-block-merge-contents-014-expected.txt:
  • editing/deleting/delete-block-merge-contents-015-expected.txt:
  • editing/deleting/delete-block-merge-contents-016-expected.txt:
  • editing/deleting/delete-block-merge-contents-017-expected.txt:
  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-020-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-block-merge-contents-022-expected.txt:
  • editing/deleting/delete-block-table-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-line-002-expected.txt:
  • editing/deleting/delete-line-004-expected.txt:
  • editing/deleting/delete-line-006-expected.txt:
  • editing/deleting/delete-line-007-expected.txt:
  • editing/deleting/delete-line-008-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
  • editing/deleting/delete-listitem-001-expected.txt:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • editing/deleting/merge-different-styles-expected.txt:
  • editing/deleting/merge-no-br-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/pruning-after-merge-2-expected.txt:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/execCommand/format-block-with-braces-expected.txt:
  • editing/execCommand/format-block-with-trailing-br-expected.txt:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/insert-list-and-stitch-expected.txt:
  • editing/execCommand/insert-list-with-id-expected.txt:
  • editing/execCommand/nsresponder-indent-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/execCommand/queryCommandState-01-expected.txt:
  • editing/execCommand/remove-list-1-expected.txt:
  • editing/execCommand/remove-list-from-range-selection-expected.txt:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:
  • editing/inserting/multiple-lines-selected-expected.txt:
  • editing/inserting/return-key-with-selection-001-expected.txt:
  • editing/inserting/return-key-with-selection-002-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4700297-expected.txt:
  • editing/pasteboard/8145-3-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/interchange-newline-2-expected.txt:
  • editing/pasteboard/merge-after-delete-1-expected.txt:
  • editing/pasteboard/merge-after-delete-2-expected.txt:
  • editing/pasteboard/merge-after-delete-expected.txt:
  • editing/pasteboard/merge-end-1-expected.txt:
  • editing/pasteboard/merge-end-2-expected.txt:
  • editing/pasteboard/merge-end-3-expected.txt:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/merge-end-5-expected.txt:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/merge-end-borders-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/pasteboard/smart-paste-008-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • editing/style/style-boundary-005-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5107422>
TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app
<rdar://problem/5107413>
TOT REGRESSION: Crash deleting text in email (infinite recursion in shouldInsertNode)

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Back out the call to shouldInsert until we add WebViewInsertActionMoved, because Mail returns NO from shouldInsert for WebViewInsertActionPasted to override our Paste operation.
2:39 PM Changeset in webkit [20688] by andersca
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Add tests for innerWidth/innerHeight and clientWidth/clientHeight in quirks mode.

Modify the strict clientWidth/clientHeight test to test the behavior with scrollbars visible.


  • fast/dom/client-width-height-quirks-expected.txt: Added.
  • fast/dom/client-width-height-quirks.html: Added.
  • fast/dom/client-width-height.html:
  • fast/dom/inner-width-height-expected.txt: Added.
  • fast/dom/inner-width-height.html: Added.

WebCore:

Reviewed by Mitz.

Make window.innerWidth/innerHeight include the size of any present scrollbar to match Firefox.


Make document.body.clientWidth/clientHeight return the width/height of the visible content when in
quirks mode to match WinIE.


  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Return the width and height of the scroll view, not the visible width and height.


  • dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): Return the visible size if the element is the body element and we're in quirks mode.
1:51 PM Changeset in webkit [20687] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2007-03-30 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: When the request dispatcher does not define a loader

no pending transaction will exist, so set this undefined status
to KErrCancel so the callers don't wait indefinitely. Also, create, use,
and close the download property string when it's needed to avoid closing
the rstring after the string pool which it's using has somehow gone away.

​http://bugs.webkit.org/show_bug.cgi?id=13232

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/BaseTransaction.h:
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::~CHttpTransaction): (CHttpTransaction::MHFRunL): (CHttpTransaction::MHFRunError): (CHttpTransaction::HandleGotResponseHeadersL):
1:50 PM Changeset in webkit [20686] by spadma
  • 4 edits in S60/trunk/WebKit

2007-03-30 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: When the request dispatcher does not define a loader

no pending transaction will exist, so set this undefined status
to KErrCancel so the callers don't wait indefinitely. Also, create, use,
and close the download property string when it's needed to avoid closing
the rstring after the string pool which it's using has somehow gone away.

​http://bugs.webkit.org/show_bug.cgi?id=13232

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/BaseTransaction.h:
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::~CHttpTransaction): (CHttpTransaction::MHFRunL): (CHttpTransaction::MHFRunError): (CHttpTransaction::HandleGotResponseHeadersL):
1:15 PM Changeset in webkit [23222] by mjs
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Alice.

  • fixed <rdar://problem/5107069> WebCore leaks a copy of the CFHTTPMessage CFDictionary (from CFHTTPMessageCopyAllHeaderFields)
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Use RetainPtr (once to avoid a leak and once just as style cleanup).
12:22 PM Changeset in webkit [20685] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Updated fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements

  • platform/graphics/Color.cpp: Moved optimization for lightening black and darkening white into the Color class. (WebCore::Color::light): (WebCore::Color::dark):
  • rendering/RenderTextControl.cpp: (WebCore::disabledTextColor): Skip the difference calculation for black text, which will always be lightened.
11:35 AM Changeset in webkit [20684] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Tim.

<rdar://problem/4649516>
Turn off slow script dialog or crank up time that makes it come up


  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): Increase the timeout to 10 seconds to match Firefox.
11:30 AM Changeset in webkit [23221] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix crashes seen when running the plugin layout tests.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Fill in the enumerate pointer, not the evaluate pointer (it's already been filled in).


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFinishLoading): Handle the case where there was no plugin stream data at all.
7:51 AM Changeset in webkit [20683] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2007-03-27 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun.
DESC: Connection shown as Normal in secure page
​http://bugs.webkit.org/show_bug.cgi?id=13206
TSW ID: HMNN-6ZGH6J

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::CertInfo):
  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::HeadersL):
7:44 AM Changeset in webkit [20682] by yongjzha
  • 2 edits in S60/trunk/WebKit

rathnasa, reviewed by Yongjun.

DESC: Reset the iDownloadContent flag properly.

TSW Id: TKWG-6Z477F-Browser auto exit when browsing web Page

​http://bugs.webkit.org/show_bug.cgi?id=13207

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::ProcessHeadersL):
7:39 AM Changeset in webkit [20681] by yongjzha
  • 4 edits in S60/branches/3.1m/WebKit

2007-04-02 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by ​yongjun.zhang@nokia.com
DESC: [S60]Animated images with DRM content won't be displayed in Browser in 3.1m.
Fix: Handle DRM image content during construct the content.
​http://bugs.webkit.org/show_bug.cgi?id=13258

  • BrowserCore/Renderers/inc/AnimationDecoder.h:
  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CRawData::DecodeDRMImageContentL): (CStaticImageDecoder::LoadNextImage):
7:29 AM Changeset in webkit [20680] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2007-04-02 ligman <​joseph.ligman@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com
DESC: Animated gif in xhtml fails. Start the animation timer for single scaled animated bitmaps.
​http://bugs.webkit.org/show_bug.cgi?id=13254

  • BrowserCore/Renderers/inc/ImageRenderer.h: (CImageRenderer::GetParent):
  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::DrawImageInRect): (NextFrameCb): (CImageRenderer::NextFrame): (CImageRenderer::InitAnimationCallback):
7:26 AM Changeset in webkit [20679] by yongjzha
  • 3 edits in S60/trunk/WebKit

ligman, reviewed by <reviewer>

DESC: Animated gif in xhtml fails. Start animation timer for single animated gifs
​http://bugs.webkit.org/show_bug.cgi?id=13255

  • BrowserCore/Renderers/inc/ImageRenderer.h: (CImageRenderer::GetParent):
  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::DrawImageInRect): (NextFrameCb): (CImageRenderer::NextFrame): (CImageRenderer::InitAnimationCallback):
5:56 AM Changeset in webkit [20678] by bdash
  • 8 edits in trunk

2007-04-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Covered by existing editing tests.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getFloatValue): Added ASSERTs that the requested conversion is from a scalar type to a scalar type. The intermittent failures in the test were the result of trying to convert an identifier type to a scalar type.
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::checkForLegacyHTMLStyleChange): Added a check that the font-size property value is an absolute length. If it is not (such as in the case of relative units or keywords like "x-large"), then no corresponding 'size' attribute will be generated for legacy HTML.

2007-04-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/fontsize-1-expected.txt:
5:51 AM Changeset in webkit [20677] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-04-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • manual-tests/stale-currentEvent.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::hoverTimerFired): Instead of faking a mouse event, just hit-test the last mouse event coordinates and update for hover state changes. This eliminates the use of currentEvent, which can be a non-mouse event or even a stale event.
4:24 AM Changeset in webkit [20676] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Antti.

  • BuildSlaveSupport/build-launcher-dmg: Use bzip2 compression in nightly build disk images rather than gzip.

Apr 2, 2007:

10:54 PM Changeset in webkit [20675] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements

Hardcode disabled text colors for the most common cases- black and white.

  • rendering/RenderTextControl.cpp: (WebCore::disabledTextColor):
6:11 PM Changeset in webkit [20674] by hyatt
  • 19 edits in trunk/WebCore

Fix for <rdar://problem/5105784>, assertion failure in cache. Encoded sizes were being set to
garbage by accident because of a mismatch between derived class and base class constructors. This
patch cleans all of this up and gets rid of expiration date as a concept separate from the response.

Reviewed by anders

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::finish):
  • loader/CachedResource.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::requestResource):
  • loader/DocLoader.h:
6:01 PM Changeset in webkit [20673] by antti
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 3


These changes shrink all RenderBlocks by additional 28 bytes. Together with parts 1 and 2
RenderBlock goes from 172 bytes to 128 bytes, a saving of 26%.


  • Pack bitfields together in RenderFlow
  • Move top/bottom min/max margin values to a struct that is only allocated in case these variables have non default values. Usually this is <5% of all blocks.
  • Move rarely used column variables to hash
  • rendering/RenderBlock.cpp: (WebCore::ColumnInfo::ColumnInfo): (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::setCollapsedBottomMargin): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcColumnWidth): (WebCore::RenderBlock::setDesiredColumnCountAndWidth): (WebCore::RenderBlock::desiredColumnWidth): (WebCore::RenderBlock::desiredColumnCount): (WebCore::RenderBlock::columnRects): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents): (WebCore::RenderBlock::adjustRectForColumns): (WebCore::RenderBlock::setMaxTopMargins): (WebCore::RenderBlock::setMaxBottomMargins):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::maxTopMargin): (WebCore::RenderBlock::maxBottomMargin): (WebCore::RenderBlock::maxTopPosMargin): (WebCore::RenderBlock::maxTopNegMargin): (WebCore::RenderBlock::maxBottomPosMargin): (WebCore::RenderBlock::maxBottomNegMargin): (WebCore::RenderBlock::initMaxMarginValues): (WebCore::RenderBlock::MaxMargin::MaxMargin): (WebCore::RenderBlock::MaxMargin::topPosDefault): (WebCore::RenderBlock::MaxMargin::topNegDefault): (WebCore::RenderBlock::MaxMargin::bottomPosDefault): (WebCore::RenderBlock::MaxMargin::bottomNegDefault):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow): (WebCore::RenderFlow::hasColumns):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline):
  • rendering/RenderInline.h:
6:00 PM Changeset in webkit [23220] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin
5:54 PM Changeset in webkit [23219] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

Check that NPStream pointers passed to NPN_DestroyStream are valid.


  • plugins/win/PluginStreamWin.cpp: (WebCore::streams): (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::ownerForStream):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::destroyStream):
5:22 PM Changeset in webkit [20672] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test you don't crash when you have abs positioned elements inside rel inline.

  • fast/block/positioning/abs-inside-inline-rel-expected.checksum: Added.
  • fast/block/positioning/abs-inside-inline-rel-expected.png: Added.
  • fast/block/positioning/abs-inside-inline-rel-expected.txt: Added.
  • fast/block/positioning/abs-inside-inline-rel.html: Added.

WebCore:

Reviewed by Hyatt.

Fix asserts, these may also be called for rel positioned elements

  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY):
4:49 PM Changeset in webkit [20671] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

Fix crash when running plugins/destroy-stream-twice.html under GuardMalloc

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (+[WebBaseNetscapePluginStream ownerForStream:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): Change the streams hash map to contain an NPStream*, and change ownerForStream to take an NPStream*.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]): Check that the NPStream pointer is valid before accessing stream->ndata.
4:41 PM Changeset in webkit [20670] by hyatt
  • 2 edits in trunk/WebCore

Throw in an assert to try to track down a problem where an image is being set to a smaller encoded
size.

  • loader/CachedResource.cpp: (WebCore::CachedResource::setEncodedSize):
4:32 PM Changeset in webkit [23218] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

<rdar://problem/5095582>
PluginViewWin doesn't implement NPN_DestroyStream.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Handle the case where NPN_DestroyStream is called from the newstream handler.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::destroyStream): Implement this.
3:29 PM Changeset in webkit [20669] by adachan
  • 2 edits in trunk/WebCore

2007-04-02 Ada Chan <​adachan@apple.com>

Reviewed by Adele.

<rdar://5105331> Missing null check in Editor::execCommand
Added null check.

  • editing/Editor.cpp: (WebCore::Editor::execCommand):
3:19 PM Changeset in webkit [23217] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/5097225>
Mouse cursors don't work with windowless plugins


  • platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor): Add an "ignoreNextSetCursor" boolean and don't call SetCursor if it's true.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Store away the current cursor and make sure that it won't be reset.
2:28 PM Changeset in webkit [23216] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix logic in windowless paint functions.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::invalidateRegion): (WebCore::PluginViewWin::forceRedraw):
2:15 PM Changeset in webkit [20668] by darin
  • 3 edits in trunk/WebKit

Reviewed by Geoff.

  • set clip path for CoreGraphics plug-ins in the same way we do for QuickDraw plug-ins this is a better fix for <rdar://problem/4939511> WebKit should set the the CG clip path for plug-ins that draw using Core Graphics

Incorporates changes from a patch by Mark Ambachtsheer.

Here are the changes:

1) Don't try to use the offscreen code path if GGBitmapContextGetData returns 0.
2) Handle kCGBitmapByteOrderDefault when computing the QD pixel format, even though

we don't have any evidence that this happens in practice.

3) Keep the GWorld around until we create a new one or the plug-in is destroyed.
4) Use the GWorld pointer itself as a flag to indicate whether we are using an

offscreen GWorld.

5) Set up clipping for CoreGraphics in the same way we do for QuickDraw; remove an

earlier attempt that handled CoreGraphics differently.

  • Plugins/WebBaseNetscapePluginView.h: Added a field named offscreenGWorld to hold the GWorld until it's needed.
  • Plugins/WebBaseNetscapePluginView.mm: (getQDPixelFormatForBitmapContext): Replaced QDPixelFormatFromCGBitmapInfo. Used the "get" prefix so we don't intrude on the QD namespace. Added code to handle the kCGBitmapByteOrderDefault case, although I'm not sure it will really come up in practice -- it wasn't really coming up in the buggy case. (getNPRect): Added helper functions. Used to make the code below clearer. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Use getNPRect to streamline code. Use GetGWorld to save the port since we use SetGWorld to restore it later. Store the GWorld we create in the offscreenGWorld field and dispose the existing one. Don't treat the CGBitmapContext as an offscreen bitmap if it has a data pointer of 0. Set up the clip based on the result of -[NSView getRectsBeingDrawn:count] when setting up the port for CoreGraphics (after saving the port state). (-[WebBaseNetscapePluginView restorePortState:]): Remove now-unneeded code to destroy the offscreen GWorld, and simplified the code that restores the port so we don't need a separate case for offscreen. (-[WebBaseNetscapePluginView fini]): Renamed from freeAttributeKeysAndValues, since this method now does more than just the attributes. This is the shared method that does things needed in both dealloc and finalize. Added a call to DisposeGWorld here. (-[WebBaseNetscapePluginView dealloc]): Updated for name change. (-[WebBaseNetscapePluginView finalize]): Ditto. (-[WebBaseNetscapePluginView drawRect:]): Removed code to set clip. This is done in the saveAndSetNewPortStateForUpdate: method instead.
1:38 PM Changeset in webkit [20667] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-03-30 jadhan <​jade.han@nokia.com>

Reviewed by Zalan <​zbujtas@gmail.com>
DESC: special handling for utf8 encoding of danish character. Merged fix from 3.2 to 3.1
​http://bugs.webkit.org/show_bug.cgi?id=13231

WARNING: NO TEST CASES ADDED OR CHANGED

  • ChangeLog:
  • kwq/KWQTextCodec.cpp: (validateUtf8):
1:30 PM Changeset in webkit [23215] by andersca
  • 2 edits in branches/WindowsMerge/WebKitTools
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Add TestNetscapeObject project.
1:23 PM Changeset in webkit [23214] by andersca
  • 1 edit in branches/WindowsMerge/WebKitTools/ChangeLog

Adam is not a nobody.

1:23 PM Changeset in webkit [23213] by andersca
  • 4 edits
    4 adds in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by NOBODY (OOPS!).

Add netscape test plugin VC project. Make DumpRenderTree look for the test plugin.


12:46 PM Changeset in webkit [20666] by bdash
  • 5 edits in branches/Safari-522/WebKit

Merge r20571.

12:37 PM Changeset in webkit [20665] by bdash
  • 7 edits in branches/Safari-522

Merge r20593 and r20596.

12:33 PM Changeset in webkit [20664] by andersca
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Don't use #import in a header included by C files.
12:23 PM Changeset in webkit [20663] by bdash
  • 5 edits in branches/Safari-522

Merge r20555 and r20560.

11:37 AM Changeset in webkit [20662] by spadma
  • 4 edits in S60/trunk/WebKit

2007-04-02 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: user hits cancel on connection dialog, send EventLoadError to the host app
​http://bugs.webkit.org/show_bug.cgi?id=13257

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequestCancelled):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::FinalProgressComplete):
11:37 AM Changeset in webkit [20661] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2007-04-02 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: user hits cancel on connection dialog, send EventLoadError to the host app
​http://bugs.webkit.org/show_bug.cgi?id=13257

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequestCancelled):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::FinalProgressComplete):
11:23 AM Changeset in webkit [20660] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5058163>
Hitting return inserts a new line between two To Dos, but caret is position after second ToDo

  • editing/inserting/5058163-1-expected.checksum: Added.
  • editing/inserting/5058163-1-expected.png: Added.
  • editing/inserting/5058163-1-expected.txt: Added.
  • editing/inserting/5058163-1.html: Added.
  • editing/inserting/5058163-2-expected.checksum: Added.
  • editing/inserting/5058163-2-expected.png: Added.
  • editing/inserting/5058163-2-expected.txt: Added.
  • editing/inserting/5058163-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5058163>
Hitting return inserts a new line between two To Dos, but caret is position after second ToDo

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Removed refPos, it was unused. Don't assume that upstream() moves to a different node. This assumption caused the line break to be inserted *after* the caret and a bad position to be set (added a testcase). Use isStartOfParagraph instead of checking for the existence of a br because the line might be broken by a newline character in text that preserves newlines. Paragraphs that are created in other ways, like with blocks, are handled above (added a testcase).
11:22 AM Changeset in webkit [20659] by spadma
  • 5 edits in S60/trunk/WebKit

2007-04-02 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: implement client side accept header support
​http://bugs.webkit.org/show_bug.cgi?id=13256

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::SetParamL):
  • ResourceLoader/inc/LoaderContainer.h: (CLoaderContainer::ClientAcceptHeaders):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
  • ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetClientAcceptHeadersL):
11:22 AM Changeset in webkit [20658] by spadma
  • 5 edits in S60/branches/3.1m/WebKit

2007-04-02 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: implement client side accept header support
​http://bugs.webkit.org/show_bug.cgi?id=13256

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::SetParamL):
  • ResourceLoader/inc/LoaderContainer.h: (CLoaderContainer::ClientAcceptHeaders):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
  • ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetClientAcceptHeadersL):
10:39 AM Changeset in webkit [20657] by zbujtas
  • 3 edits in S60/trunk/WebCore

2007-04-02 yongjzha <​yonjun.zhang@nokia.com>

Reviewed by ​bjutas@gmail.com.
DESC: suppress false memory leaking alert.
​http://bugs.webkit.org/show_bug.cgi?id=13253

  • khtml/css/css_base.h: (DOM::):
  • khtml/css/cssparser.h: (DOM::Value::): (DOM::qString): (DOM::domString): (DOM::atomicString): (DOM::):
10:36 AM Changeset in webkit [20656] by harrison
  • 2 edits in trunk/WebCore

2007-04-02 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4906488> text attributes are not working for frame based web page

Attribute handling now treats each WebArea as its own world, rather than sometimes
referring back up to the top WebArea. e.g. getting/setting the selection now
operates on the WebArea containing the WebCoreAXObject that is being messaged (self).
The methods that sit above this and are able to go into arbitrary WebAreas
are accessibilityFocusedUIElement and doAXTextMarkerForPosition, allowing VoiceOver
to navigate between frames.


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject topRenderer]): (-[WebCoreAXObject frameView]): (-[WebCoreAXObject topFrameView]): Removed topDocument, renamed topView to topFrameView, added frameView.


(-[WebCoreAXObject accessibilityAttributeValue:]):
AXSelectedTextMarkerRange, AXStartTextMarker, and AXEndTextMarker now use
self's WebArea, rather than the top WebArea.


(-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
Use self's WebArea, rather than the top WebArea.

(-[WebCoreAXObject doAXTextMarkerForPosition:]):
Use renamed methods for accessing top WebArea.


(-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
Use renamed methods for accessing self's WebArea.

(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetFont):
(AXAttributeStringSetStyle):
(AXAttributeStringSetElement):
(-[WebCoreAXObject rendererForView:]):
Clean up uses of nil and NULL.


(-[WebCoreAXObject accessibilityFocusedUIElement]):
Find the focused node on the whole page. If there is no focused node,
return the WebArea for the focused document.


(-[WebCoreAXObject doSetAXSelectedTextMarkerRange:]):
Use self's WebArea, rather than the top WebArea.

10:36 AM Changeset in webkit [20655] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2007-04-02 yongjzha <​yonjun.zhang@nokia.com>

Reviewed by ​bjutas@gmail.com.
DESC: suppress false memory leaking alert.
​http://bugs.webkit.org/show_bug.cgi?id=13253

  • khtml/css/css_base.h: (DOM::):
  • khtml/css/cssparser.h: (DOM::Value::): (DOM::qString): (DOM::domString): (DOM::atomicString): (DOM::):
3:06 AM Changeset in webkit [20654] by antti
  • 2 edits in trunk/WebCore

Fix build. This one was not supposed to be checked in.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
2:43 AM Changeset in webkit [20653] by antti
  • 9 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 2


  • Move staticX and staticY variables to RenderLayer since they are only applicable to positioned objects
  • Move very rarely used overrideSize variable to hash


These changes shrink all box types by 12 bytes

  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::destroy): (WebCore::RenderBox::overrideSize): (WebCore::RenderBox::setOverrideSize): (WebCore::RenderBox::overrideWidth): (WebCore::RenderBox::overrideHeight): (WebCore::RenderBox::position): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::staticX): (WebCore::RenderBox::staticY): (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::staticX): (WebCore::RenderLayer::staticY): (WebCore::RenderLayer::setStaticX): (WebCore::RenderLayer::setStaticY):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject):
  • rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::hasOverrideSize): (WebCore::RenderObject::setHasOverrideSize):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

Apr 1, 2007:

8:04 PM Changeset in webkit [20652] by sfalken
  • 1 copy in tags/Safari-522.5.4b

New tag.

4:29 PM Changeset in webkit [20651] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20570

4:27 PM Changeset in webkit [20650] by sfalken
  • 14 edits in branches/Safari-522

Merge fix from r20565

4:01 PM Changeset in webkit [20649] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/gdk/TemporaryLinkStubs.cpp: (Font::selectionRectForComplexText): (Font::drawComplexText):

Mar 31, 2007:

10:41 PM Changeset in webkit [20648] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12778
REGRESSION: Nightly won't load Curl plugin for full page use

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Re-order cases to give more priority to plugins. This also fixes Adobe SVG Viewer and any plugins that register XML MIME types. Added a case for XHTML to avoid enumerating plugins.
10:33 PM Changeset in webkit [23212] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Remove bogus comment.

10:30 PM Changeset in webkit [23211] by hyatt
  • 5 edits in branches/WindowsMerge/WebCore

Fix layout of justified selected text.

10:21 PM Changeset in webkit [20647] by hyatt
  • 4 adds in trunk/LayoutTests/fast/text
10:20 PM Changeset in webkit [20646] by hyatt
  • 13 edits in trunk/WebCore

Fix for bug 13234, layout of selected justified text is broken. Rework TextRuns to avoid having
from/to members. Let those be passed in only by the functions that need them (drawing and selection rect).

Reviewed by mitz

fast/text/justified-selection-at-edge.html

  • platform/Font.cpp: (WebCore::WidthIterator::WidthIterator): (WebCore::WidthIterator::advance): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPositionForSimpleText):
  • platform/Font.h: (WebCore::TextRun::m_len):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/graphics/GraphicsContext.h:
  • platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/qt/FontQt.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText):
  • platform/qt/TemporaryLinkStubs.cpp: (Font::selectionRectForComplexText):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::width):
10:04 PM Changeset in webkit [20645] by bdash
  • 2 edits in trunk/WebCore

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

<rdar://problem/5103226>

REGRESSION (r20506): Repro crash/assert when using scroll wheel on a list box taller than its contents

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::setValue): Cleaned up a little. (WebCore::Scrollbar::scroll): Changed to apply the minimum and maximum constraints in the right order, and cleaned up a little.
9:59 PM Changeset in webkit [20644] by andrew
  • 3 edits
    2 adds in trunk

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/images/text-content-crash-expected.txt: Added.
  • fast/images/text-content-crash.html: Added.

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/images/text-content-crash.html

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Added a check that the renderer is an image. (WebCore::HTMLImageElement::attach): Ditto.
9:50 PM Changeset in webkit [20643] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-31 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=13239
Bug 13239: REGRESSION (r20343): Drosera hits exception trying to call "count" cross-process

Use -[WebScriptObject valueForKey:@"length"] to retrieve the length of a JavaScript array
rather than -[WebScriptObject count].

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument webScriptAttributeKeysForScriptObject:]):
9:48 PM Changeset in webkit [20642] by bdash
  • 3 edits in trunk/WebCore

2007-03-31 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

A more correct fix for ​http://bugs.webkit.org/show_bug.cgi?id=13129
Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup

The previous attempt at a fix in r20343 attempted to conditionally expose the 'count'
method. It did not work which resulted in 'count' always being hidden. This change
disables -[WebScriptObject count] completely until it can be determined whether it is
needed and how to support it without breaking third-party applications.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject count]):
  • bindings/objc/WebScriptObjectPrivate.h:
9:28 PM Changeset in webkit [23210] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

Filesystem layout changes:

<rdar://problem/5091159> Boomer has no bundle identifier - is the bundle correctly formed?
<rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"

11:24 AM Changeset in webkit [23209] by adele
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adam.

A little cleanup from my last change. Added a comment, and moved a JSStringRelease call to a better place.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback):
8:32 AM Changeset in webkit [20641] by ddkilzer
  • 3 edits in trunk/LayoutTests

Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.
Fixed one instance where 'allow-tabs' property and 'true' value were reversed.

4:30 AM Changeset in webkit [20640] by ddkilzer
  • 2 edits in trunk/LayoutTests/fast/js/resources

Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.

3:25 AM Changeset in webkit [20639] by ap
  • 2 edits
    4 adds in trunk

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

  • pixel test for partially selected justified text
  • fast/text/justified-selection-expected.checksum: Added.
  • fast/text/justified-selection-expected.png: Added.
  • fast/text/justified-selection-expected.txt: Added.
  • fast/text/justified-selection.html: Added.
3:18 AM Changeset in webkit [20638] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

A layout test documenting shrink-to-fit width calculation for floating elements.

  • fast/block/float/shrink-to-fit-width-expected.checksum: Added.
  • fast/block/float/shrink-to-fit-width-expected.png: Added.
  • fast/block/float/shrink-to-fit-width-expected.txt: Added.
  • fast/block/float/shrink-to-fit-width.html: Added.
3:07 AM Changeset in webkit [20637] by ap
  • 3 edits
    2 adds in trunk

2007-03-31 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=13184
HTMLImageElement longdesc should be complete resolved URL

Test: fast/dom/HTMLImageElement/image-longdesc-absolute-url.html

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::longDesc): Return absolute URL. Behaviour now matches Firefox and Opera.
1:26 AM Changeset in webkit [20636] by ap
  • 5 edits
    4 adds in trunk

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/repaint/list-marker-2.html

A list marker can increase the horizontal overflow after layoutInlineChildren(),
so made that function return only the vertical bounds of the repaint rect. As the
horizontal bounds, made layoutBlock() just use the overflow bounds after layout.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
12:59 AM Changeset in webkit [20635] by ap
  • 3 edits
    4 adds in trunk

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/text/wide-zero-width-space.html

  • platform/FontData.cpp: (WebCore::FontData::FontData): Force the ZERO WIDTH SPACE glyph to have width 0, unless the SPACE character maps to the same glyph.
12:49 AM Changeset in webkit [20634] by ap
  • 11 edits
    2 adds in trunk

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

WebCore:

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Made "<" terminate tag and attribute names. This matches Firefox.

LayoutTests:

  • fast/overflow/002-expected.checksum:
  • fast/overflow/002-expected.png:
  • fast/overflow/002-expected.txt:
  • fast/overflow/002.html: Added missing ">" to one of the BR tags.
  • fast/text/atsui-multiple-renderers-expected.checksum:
  • fast/text/atsui-multiple-renderers-expected.png:
  • fast/text/atsui-multiple-renderers-expected.txt:
  • fast/text/atsui-multiple-renderers.html: Added missing ">" to the TITLE tag.
  • fast/tokenizer/lessthan-terminates-tags-and-attrs-expected.txt: Added.
  • fast/tokenizer/lessthan-terminates-tags-and-attrs.html: Added.

Mar 30, 2007:

8:39 PM Changeset in webkit [20633] by sfalken
  • 1 copy in tags/Safari-522.5.3b

New tag.

7:41 PM Changeset in webkit [20632] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20543

7:25 PM Changeset in webkit [20631] by ddkilzer
  • 1 edit in trunk/LayoutTests/fast/js/resources/dot-node-base-exception.js

Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.

4:13 PM Changeset in webkit [23208] by adele
  • 4 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Beth.

Fix for <rdar://problem/5079824> editing/deleting/delete-by-word-001 is failing

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback): Added hack to convert option-delete to ctrl-delete. Also fixed this to correctly convert ascii codes to virtual key codes, which removes the need for the special conversion of '\n' to VK_RETURN.

WebKitWin:

Reviewed by Beth.

Fix <rdar://problem/5079824> editing/deleting/delete-by-word-001 is failing

  • WebView.cpp: Add DeleteWordForward and DeleteWordBackward to key command table.
3:31 PM Changeset in webkit [23207] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adele.

<rdar://problem/5101970>
Crash when submitting form, running under App Verifier


  • WebActionPropertyBag.cpp: (findMouseEvent): Return the right event.
2:56 PM Changeset in webkit [20630] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20558

2:53 PM Changeset in webkit [20629] by sfalken
  • 5 edits
    8 copies in branches/Safari-522

Merge fix from r20542

2:51 PM Changeset in webkit [20628] by sfalken
  • 2 edits in branches/Safari-522/WebKit

Merge fix from r20537

2:46 PM Changeset in webkit [20627] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20535

2:43 PM Changeset in webkit [20626] by sfalken
  • 3 edits
    16 copies in branches/Safari-522

Merge fix from r20520

2:41 PM Changeset in webkit [20625] by andersca
  • 5 edits in trunk

LayoutTests:

Reviewed by Geoff.

  • plugins/destroy-stream-twice.html: Put the scripts before the embed element. Set the timeout in the onstreamload handler.

WebKitTools:

Reviewed by Geoff.

Add an "onstreamload" attribute to the plugin which is called when a stream starts loading.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): Look for the onstreamload attribute.


(NPP_Destroy):
Free the onstreamload attribute.


(NPP_NewStream):
Call the onstreamload handler.

2:40 PM Changeset in webkit [20624] by sfalken
  • 3 edits
    4 copies in branches/Safari-522

Merge fix from r20503

2:33 PM Changeset in webkit [20623] by sfalken
  • 4 edits
    3 copies in branches/Safari-522

Merge fix from r20502

1:57 PM Changeset in webkit [20622] by ap
  • 2 edits in trunk/WebCore

Debug build fix.

  • xml/XPathValue.cpp: (WebCore::XPath::): Define Value::adopt.
1:54 PM Changeset in webkit [20621] by ggaren
  • 2 edits in trunk/WebKitTools

Removing an assertion I just added because it's crashing the Leopard
buildbot. The related layout test will still report a failure, so we
don't really need this assertion.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke):
1:31 PM Changeset in webkit [20620] by ap
  • 11 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13021
XPath can be very slow

This patch finally makes us faster than Firefox 2.0 on this test case.

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunConcat::evaluate): Use a Vector buffer for faster appending. (WebCore::XPath::FunId::evaluate): Move the result NodeSet into Value instead of copying it. (WebCore::XPath::FunLocalName::evaluate): Cosmetic changes. (WebCore::XPath::FunNamespaceURI::evaluate): Ditto. (WebCore::XPath::FunName::evaluate): Ditto. (WebCore::XPath::FunNormalizeSpace::evaluate): Ditto.
  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNodeSet): (WebCore::XPath::Value::modifiableNodeSet): (WebCore::XPath::Value::toBoolean): (WebCore::XPath::Value::toNumber): (WebCore::XPath::Value::toString):
  • xml/XPathValue.h: (WebCore::XPath::ValueData::ValueData): (WebCore::XPath::Value::Value): Made Value copying faster by putting large data members into a separate refcounted ValueData class. Added provisions for moving a NodeSet in and out of Value without copying. Made construction safer by moving bool version to a template constructor. Removed an (almost) unused default constructor.
  • xml/XPathPredicate.h: Store a Value for literal string and number expressions to avoid constructing one each time.
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): (WebCore::XPath::LocationPath::evaluate): (WebCore::XPath::Path::evaluate):
  • xml/XPathPath.h:
  • xml/XPathPredicate.cpp: (WebCore::XPath::NumericOp::evaluate): (WebCore::XPath::Union::evaluate):
  • xml/XPathResult.cpp: (WebCore::XPathResult::snapshotItem):
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis):
  • xml/XPathStep.h: Got rid of unnecessary NodeSet copying in many cases.
1:13 PM Changeset in webkit [20619] by andersca
  • 3 edits in trunk/WebKitTools

Reviewed by Geoff.

  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: (testAllocate): (testEnumerate): Add casts.


  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Don't use #import, use #include.
1:12 PM Changeset in webkit [23206] by andersca
  • 12 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::addExtraPluginPath):
  • plugins/win/PluginDatabaseWin.h: New function for adding an extra plugin path, to be used by DRT.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Set the current directory tho the plugin directory while loading the plugin. Add new NPN callbacks.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::invalidateRegion): (WebCore::PluginViewWin::forceRedraw): Don't do anything if the plugin is windowed.


  • plugins/win/npapi.cpp: (NPN_PushPopupsEnabledState): (NPN_PopPopupsEnabledState): Add stubs.


  • plugins/win/npfunctions.h: Add new methods and merge some fixes from the open source version.

WebKitWin:

Reviewed by Geoff.

  • Interfaces/IWebViewPrivate.idl: Add addAdditionalPluginPath method.


  • WebKit.vcproj/WebKit.vcproj: Copy NP includes so they can be included by the test plugin.


  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString): Hold JSLock while we call JSValue::getString().


(WebView::addAdditionalPluginPath):

  • WebView.h: Implement addAdditionalPluginPath.
12:59 PM Changeset in webkit [20618] by andersca
  • 2 edits in trunk/WebKitTools

Reviewed by Alexey.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): Free the identifier string.
12:50 PM Changeset in webkit [20617] by justing
  • 4 edits
    9 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/5076323> Only one To Do can be created by a selection in a message

  • editing/selection/5076323-1-expected.checksum: Added.
  • editing/selection/5076323-1-expected.txt: Added.
  • editing/selection/5076323-1.html: Added.
  • editing/selection/5076323-2-expected.checksum: Added.
  • editing/selection/5076323-2-expected.txt: Added.
  • editing/selection/5076323-2.html: Added.
  • editing/selection/5076323-3-expected.checksum: Added.
  • editing/selection/5076323-3-expected.txt: Added.
  • editing/selection/5076323-3.html: Added.

WebCore:

Reviewed by john

<rdar://problem/5076323> Only one To Do can be created by a selection in a message

When Mail's ToDoify operation called moveToEndOfDocument:
with a selection that started just before a ToDo, we'd
move them to the end of the document, not to the end
of the editable root, because we incorrectly checked
for the editability of positions before ToDos. Then Mail
would refuse to create a ToDo because the selection was
outside of the region where they allowed editing.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): Check the position for editability, not the position's node, since there are editable positions of the form [node, offset] where node is contenteditable=false. Re-use pos. Nothing that happens after it's created can invalidate it or the position and affinity used to create it. (WebCore::SelectionController::modifyMovingRightForward): Ditto. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto. (WebCore::SelectionController::modifyMovingLeftBackward): Ditto.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): Ditto.
11:24 AM Changeset in webkit [20616] by beidson
  • 3 edits in trunk/LayoutTests

Reviewed by Brian Dash

Fixes an intermittent failure in the port blocking layout test where
some sort of indeterminacy would change the error code the networking
layer reported.

  • security/block-test-expected.txt:
  • security/block-test.html: Use 255.255.255.255 instead of a bogus domain name
11:13 AM Changeset in webkit [20615] by adele
  • 4 edits in trunk

WebCore:

Reviewed by Darin.

Added DeleteWordBackward and DeleteWordForward to execCommand.

  • editing/Editor.cpp: (WebCore::execDeleteWordBackward): (WebCore::execDeleteWordForward): (WebCore::CommandEntry::):

WebKit:

Reviewed by Darin.

Call execCommand for deleteWordForward and deleteWordBackward instead of calling
deleteWithDirection directly.

  • WebView/WebHTMLView.mm: (-[WebHTMLView deleteWordForward:]): (-[WebHTMLView deleteWordBackward:]):
11:10 AM Changeset in webkit [20614] by andersca
  • 2 edits in trunk/JavaScriptCore

Build fix.


  • bindings/NP_jsobject.cpp: (_NPN_Enumerate):
10:45 AM Changeset in webkit [23205] by andersca
  • 1 edit
    2 adds in branches/WindowsMerge/WebKitTools

Reviewed by Geoff.

10:29 AM Changeset in webkit [20613] by andersca
  • 20 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

Implement _NPN_Enumerate support.


  • JavaScriptCore.exp:
  • bindings/NP_jsobject.cpp: (_NPN_Enumerate):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::getPropertyNames):
  • bindings/c/c_instance.h:
  • bindings/npapi.h:
  • bindings/npruntime.h:
  • bindings/npruntime_impl.h:
  • bindings/runtime.h: (KJS::Bindings::Instance::getPropertyNames):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::getPropertyNames):
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::getInternalInstance):

LayoutTests:

Reviewed by Geoff.

Add enumeration test.


  • plugins/netscape-enumerate-expected.txt: Added.
  • plugins/netscape-enumerate.html: Added.

WebKit:

Reviewed by Geoff.

  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): Initialize pushpopupsenabledstate, poppopupsenabledstate and enumerate.


  • Plugins/npapi.m: (NPN_PushPopupsEnabledState): (NPN_PopPopupsEnabledState): Add stubs for these functions.


  • Plugins/npfunctions.h: Add new methods to NPNetscapeFuncs.

WebKitTools:

Reviewed by Geoff.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add TestObject.c and TestObject.h


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginGetProperty): Implement the testObject property.


(pluginInvoke):
Implement testEnumerate which takes an object and an array and enumerates
the properties of the object and adds them to the array.


(pluginAllocate):
Allocate the test object.


(pluginDeallocate):
Free the test object.


  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Added.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Added. Add a test object with two enumerable properties.
8:33 AM Changeset in webkit [20612] by hausmann
  • 2 edits in trunk/WebCore

Fix Qt release builds

5:55 AM Changeset in webkit [20611] by antti
  • 2 edits in trunk/WebCore

Reviewed by bdash.

Spotted an int that should be float in previous patch.

  • platform/Font.cpp: (WebCore::WidthIterator::advance):
2:59 AM Changeset in webkit [20610] by antti
  • 12 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 1


  • Eliminate caching of monospace char width from RenderText. This optimization is not needed anymore since Font already caches space width (RenderText -4 bytes)
  • Eliminate caching of tab width from RenderBlock. Similary this optimization has become obsolete (RenderBlock -4 bytes)
  • platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::Font::spaceWidth):
  • platform/Font.h: (WebCore::Font::tabWidth):
  • platform/TextStyle.h: (WebCore::TextStyle::TextStyle): (WebCore::TextStyle::allowTabs):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::setStyle):
  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::setStyle): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidthInternal): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::width):
  • rendering/RenderText.h: (WebCore::RenderText::allowTabs):
  • rendering/bidi.cpp:
2:51 AM Changeset in webkit [20609] by hyatt
  • 4 edits
    4 adds in trunk

Fix (take 2) for bug 4334, flickering when floating elements gain/lose transparency.

Reviewed by mitz

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):

Mar 29, 2007:

8:17 PM Changeset in webkit [20608] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for <rdar://problem/5061807>. (This one's for you, Boyscout!)

  • fast/frames/remove-frame-with-scrollbars-crash-expected.txt: Added.
  • fast/frames/remove-frame-with-scrollbars-crash.html: Added.
7:36 PM Changeset in webkit [20607] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/tokenizer/write-partial-entity-expected.txt: Added.
  • fast/tokenizer/write-partial-entity.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/tokenizer/write-partial-entity.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Reordered to avoid resetting the buffer position after script execution which can write to the buffer.
5:11 PM Changeset in webkit [20606] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position

Tests for the bug:

  • editing/deleting/5099303-expected.checksum: Added.
  • editing/deleting/5099303-expected.png: Added.
  • editing/deleting/5099303-expected.txt: Added.
  • editing/deleting/5099303.html: Added. Tests that extending an editable selection skips non-editable content:
  • editing/selection/5099303-expected.checksum: Added.
  • editing/selection/5099303-expected.png: Added.
  • editing/selection/5099303-expected.txt: Added.
  • editing/selection/5099303.html: Added.

WebCore:

Reviewed by john

<rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position


We were failing to create the correct selection
for DeleteSelectionCommand because the selection extension
operations don't skip over non-editable content for editable
selections.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): When extending an editable selection, don't extend into non-editable content. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto.
5:04 PM Changeset in webkit [20605] by thatcher
  • 1 edit in tags/Safari-5522.5/WebKit/Configurations/Version.xcconfig

Versioning.

5:04 PM Changeset in webkit [20604] by thatcher
  • 1 edit in tags/Safari-5522.5/WebCore/Configurations/Version.xcconfig

Versioning.

5:03 PM Changeset in webkit [20603] by thatcher
  • 1 edit in tags/Safari-5522.5/JavaScriptGlue/Configurations/Version.xcconfig

Versioning.

5:03 PM Changeset in webkit [20602] by thatcher
  • 1 edit in tags/Safari-5522.5/JavaScriptCore/Configurations/Version.xcconfig

Versioning.

4:58 PM Changeset in webkit [20601] by thatcher
  • 2 edits in tags/Safari-5522.5/WebKit

Merge fix from r20516.

4:50 PM Changeset in webkit [20600] by thatcher
  • 10 edits in tags/Safari-5522.5/WebCore

Merge fix from r20565.

4:49 PM Changeset in webkit [20599] by thatcher
  • 3 edits in tags/Safari-5522.5/WebCore

Merge fix from r20542.

4:47 PM Changeset in webkit [20598] by thatcher
  • 2 edits in tags/Safari-5522.5/WebCore

Merge fix from r20520.

4:26 PM Changeset in webkit [20597] by ggaren
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)

  • plugins/destroy-stream-twice-expected.txt: Added.
  • plugins/destroy-stream-twice.html: Added.

WebKit:

Reviewed by Beth Dakin, reviewed by Maciej Stachowiak.


Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)


Changed LOG_ERROR to LOG so the layout test doesn't produce console spew
every time you run it.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]):

WebKitTools:

Reviewed by Beth Dakin.


Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)


Added hasStream property and destroyStream function, used by layout test.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginGetProperty): (pluginInvoke): (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_NewStream):
4:24 PM Changeset in webkit [20596] by bdakin
  • 3 edits in trunk/WebKitLibraries

Rubber-stamped by Adam.

Keep OpenSource building.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:24 PM Changeset in webkit [20595] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/4918397> Exception raise inspecting note contents in the background

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject subrole]): (-[WebCoreAXObject title]): Check that attachment supports the attribute before requesting it.
4:16 PM Changeset in webkit [20594] by justing
  • 1 add in trunk/LayoutTests/editing/deleting/5032066-expected.txt

I forgot add this expected result in my previous checkin.

4:13 PM Changeset in webkit [20593] by bdakin
  • 4 edits in trunk/WebKit

Reviewed by Brady.

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

-and-

<rdar://problem/4992521> Please adjust WebKit's Acrobat-workaround
methodology

The fix for the first bug is to compare against the bundle
identifiers for Adobe Reader and the non-Pro Adobe Acrobat in
addition to Adobe Acrobat Pro. The fix for the second bug is to
check the version number of Acrobat/Reader through
WebKitSystemInterface instead of checking which version of WebKit
it has been linked against.

  • English.lproj/StringsNotToBeLocalized.txt: Two new bundle identifiers.
  • Misc/WebKitVersionChecks.h: Remove Acrobat quirk constant.
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
4:01 PM Changeset in webkit [20592] by thatcher
  • 1 copy in tags/Safari-5522.5

New tag based on r20497.

3:34 PM Changeset in webkit [20591] by justing
  • 126 edits
    3 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/5032066> <Delete> should work between To Dos

Demonstrates the fix:

  • editing/deleting/5032066-expected.checksum: Added.
  • editing/deleting/5032066-expected.png: Added.
  • editing/deleting/5032066-expected.txt: Added.
  • editing/deleting/5032066.html: Added.


Fixed:

  • editing/deleting/delete-block-table-expected.checksum:
  • editing/deleting/delete-block-table-expected.png:
  • editing/deleting/delete-block-table-expected.txt:


shouldInsertNode:... now being called during moves:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-001-expected.txt:
  • editing/deleting/delete-block-merge-contents-002-expected.txt:
  • editing/deleting/delete-block-merge-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-004-expected.txt:
  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-007-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:
  • editing/deleting/delete-block-merge-contents-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-010-expected.txt:
  • editing/deleting/delete-block-merge-contents-012-expected.txt:
  • editing/deleting/delete-block-merge-contents-013-expected.txt:
  • editing/deleting/delete-block-merge-contents-014-expected.txt:
  • editing/deleting/delete-block-merge-contents-015-expected.txt:
  • editing/deleting/delete-block-merge-contents-016-expected.txt:
  • editing/deleting/delete-block-merge-contents-017-expected.txt:
  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-020-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-block-merge-contents-022-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-line-002-expected.txt:
  • editing/deleting/delete-line-004-expected.txt:
  • editing/deleting/delete-line-006-expected.txt:
  • editing/deleting/delete-line-007-expected.txt:
  • editing/deleting/delete-line-008-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
  • editing/deleting/delete-listitem-001-expected.txt:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • editing/deleting/merge-different-styles-expected.txt:
  • editing/deleting/merge-no-br-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/pruning-after-merge-2-expected.txt:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/execCommand/format-block-with-braces-expected.txt:
  • editing/execCommand/format-block-with-trailing-br-expected.txt:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/insert-list-and-stitch-expected.txt:
  • editing/execCommand/insert-list-with-id-expected.txt:
  • editing/execCommand/nsresponder-indent-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/execCommand/queryCommandState-01-expected.txt:
  • editing/execCommand/remove-list-1-expected.txt:
  • editing/execCommand/remove-list-from-range-selection-expected.txt:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:
  • editing/inserting/multiple-lines-selected-expected.txt:
  • editing/inserting/return-key-with-selection-001-expected.txt:
  • editing/inserting/return-key-with-selection-002-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4700297-expected.txt:
  • editing/pasteboard/8145-3-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/interchange-newline-2-expected.txt:
  • editing/pasteboard/merge-after-delete-1-expected.txt:
  • editing/pasteboard/merge-after-delete-2-expected.txt:
  • editing/pasteboard/merge-after-delete-expected.txt:
  • editing/pasteboard/merge-end-1-expected.txt:
  • editing/pasteboard/merge-end-2-expected.txt:
  • editing/pasteboard/merge-end-3-expected.txt:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/merge-end-5-expected.txt:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/merge-end-borders-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/pasteboard/smart-paste-008-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • editing/style/style-boundary-005-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:

WebCore:

Reviewed by john

<rdar://problem/5032066> Delete should work between ToDos


Stop selecting the table when the user attempts to delete
the line break just after it, instead, extend the selection
into the last table cell.
Let deletion merge content into table cells (as long as
its not from another table cell).
Start calling shouldInsertNode:replacingDOMRange:givenAction:
when moving content with moveParagraphs, so that Mail can
modify content before it is moved into a ToDo during a delete.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Ask the delegate before performing the move. This will let Mail prevent styles from entering a ToDo. Added a FIXME about adding a new WebViewInsertAction
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Allow merging into table cells from content not in a table.
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): Don't select the table when extending by character/word from just before it. This code was here to make it easier to select tables in order to delete them, but the deletion UI makes it largely unnecessary. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto.
  • editing/TypingCommand.cpp: (WebCore::isFirstPositionAfterTable): Added. (WebCore::isLastPositionBeforeTable): Ditto. (WebCore::TypingCommand::deleteKeyPressed): When pressing the delete key with a caret at the beginning of a paragraph just after a table, move the paragraph into the last table cell. Do not do this if it would mean moving a block table. Removed some old irrelevant comments.
  • editing/htmlediting.cpp: Removed unused functions.
  • editing/htmlediting.h:
3:14 PM Changeset in webkit [20590] by thatcher
  • 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

Build fix for Leopard.

1:39 PM Changeset in webkit [20589] by yongjzha
  • 2 edits in S60/trunk/WebKit

vbradley, reviewed by yongjun

DESC: Fix cursor when browser is brought back from background and a

plugin has focus.

​http://bugs.webkit.org/show_bug.cgi?id=13225

  • Plugin/src/PluginWin.cpp: (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
1:37 PM Changeset in webkit [20588] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-29 vbradley <​vincent.bradley@nokia.com>

Reviewed by Yongjan.
DESC: Fix cursor when browser is brought back from background and a plugin has focus.
​http://bugs.webkit.org/show_bug.cgi?id=13225

  • Plugin/src/PluginWin.cpp: (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
1:36 PM Changeset in webkit [20587] by yongjzha
  • 4 edits in S60/trunk/WebCore

yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Zalan <​zbujtas@gmail.com>
DESC: refreshing crashes the browser on some sites (kauppalehti.fi, hs.fi)

fix: stop the tokenizer timer when switching to final document from preview document.

​http://bugs.webkit.org/show_bug.cgi?id=13219

  • khtml/html/htmltokenizer.cpp: (khtml::):
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp: (KHTMLPart::switchToDocWithPendingSrc):
1:18 PM Changeset in webkit [20586] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-03-28 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: RVCT complier is not handling bitfields properly
​http://bugs.webkit.org/show_bug.cgi?id=13217

  • khtml/rendering/render_table.h:
1:11 PM Changeset in webkit [20585] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-27 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun.
DESC: Regression due to patch r20436
TSW Id: TKWG-6Z477F-Browser auto exit when browsing web Page
​http://bugs.webkit.org/show_bug.cgi?id=13207

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::ResponseCompleteL):


1:03 PM Changeset in webkit [20584] by yongjzha
  • 2 edits in S60/trunk/WebKit

Steve, reviewed by Yongjun Zhang

DESC:
​http://bugs.webkit.org/show_bug.cgi?id=13296

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::SizeChanged):
1:01 PM Changeset in webkit [20583] by yongjzha
  • 4 edits in S60/trunk/WebKit

hongzhao, reviewed by ​yongjun.zhang@nokia.com.

DESC: [S60] Browser doesn't support for DRM image content in 3.2.
Fix: Add function to handle DRM image decoder.
​http://bugs.webkit.org/show_bug.cgi?id=13220

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CStaticImageDecoder::LoadNextImage): (CStaticImageDecoder::DecodeDRMImageL):
  • group/webkit.mmp:
12:13 PM Changeset in webkit [20582] by bdash
  • 1 edit in tags/WebCore-5522.4.2/WebCore/Info.plist

Versioning.

12:12 PM Changeset in webkit [20581] by bdash
  • 10 edits in tags/WebCore-5522.4.2/WebCore

Merge in r20565.

12:10 PM Changeset in webkit [20580] by bdash
  • 1 copy in tags/WebCore-5522.4.2

New tag.

12:00 PM Changeset in webkit [20579] by staikos
  • 1 edit in trunk/WebCore/platform/qt/FontQt.cpp

Add a comment since our current fix is not really acceptable.

11:44 AM Changeset in webkit [20578] by staikos
  • 2 edits in trunk/WebCore

Remove redundant line.

11:18 AM Changeset in webkit [20577] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2007-03-28 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: RVCT complier is not handling bitfields properly
​http://bugs.webkit.org/show_bug.cgi?id=13217

  • khtml/rendering/render_table.h:
11:05 AM BuildingOnWindows edited by tommy@ech-wel.nl
(diff)
10:34 AM Changeset in webkit [20576] by yongjzha
  • 4 edits in S60/branches/3.1m/WebKit

2007-03-29 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] Browser doesn't support for DRM image content.
Fix: Make some changes based on Yongjun's comments for the previous 3.1m patch.
​http://bugs.webkit.org/show_bug.cgi?id=13220

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CStaticImageDecoder::LoadNextImage): (CStaticImageDecoder::DecodeDRMImageL):
  • group/webkit.mmp:
10:07 AM Changeset in webkit [20575] by staikos
  • 2 edits in trunk

correct the changelog entry for the patch author.

10:05 AM Changeset in webkit [20574] by staikos
  • 2 edits in trunk/WebCore

Take into account the entire run length to get a proper selection.
Doesn't seem to affect the Mac build but is a problem for Qt.

10:01 AM Changeset in webkit [20573] by ggaren
  • 2 edits
    1 move in trunk/WebKit

Rubber stamped by Beth Dakin.


WebBaseNetscapePluginStream.m => WebBaseNetscapePluginStream.mm, since
it's ObjC++ now.

  • Plugins/WebBaseNetscapePluginStream.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
9:59 AM Changeset in webkit [20572] by darin
  • 4 edits
    2 adds in trunk/LayoutTests

Layout test for <rdar://problem/4545060>, technorati and arstechnica fail
because of getComputedStyle not reporting display:none.
​http://bugs.webkit.org/show_bug.cgi?id=13103

  • fast/css/computed-style-display-none.html: Added.
  • fast/css/computed-style-display-none-expected.txt: Added.
  • fast/css/computed-style-negative-top.html: Updated to work with Gecko.
  • fast/css/computed-style-negative-top-expected.txt: Newline change needed because of change above.
  • fast/css/computed-style.html: Updated to work with Gecko.
8:18 AM Changeset in webkit [20571] by ggaren
  • 5 edits in trunk/WebKit

Reluctantly tolerated by Darin Adler.


Fixed <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)


The problem was that the DivX plug-in would ask us to destroy an NPStream
that had already been destroyed, causing us to wander off into freed
memory. (I believe the reason this was a regression was that we never used
to destroy plug-in streams, period.)


The solution here is to track the NPStreams belonging to a plug-in, and
guard against plug-ins making calls with NPStreams that don't belong to
them. (It turns out that NPN_DestroyStream is the only stream-based
plug-in call we support.)

(CarbonPathFromPOSIXPath): Fixed up a cast to be C++ compatible.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]): The actual fix. Use helper method to guard against a plug-in using an NPStream that doesn't belong to it.
  • WebKit.xcodeproj/project.pbxproj: Made WebBaseNetscapePluginView ObjC++ so I could use HashMap.
1:41 AM Changeset in webkit [20570] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
reporting display:none properly when it is set. This is bugzilla bug 13103.

Reviewed by mitz

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
12:49 AM Changeset in webkit [23204] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Enable CG's local font cache.

Mar 28, 2007:

11:20 PM Changeset in webkit [20569] by dsmith
  • 13 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:

  • holes in arrays should be skipped, not treated as undefined, by all such methods
  • an element with value undefined is not a hole
  • Array.prototype.forEach should return undefined
  • kjs/array_object.cpp: (ArrayInstance::getOwnPropertySlot): (ArrayProtoFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:

  • holes in arrays should be skipped, not treated as undefined, by all such methods
  • an element with value undefined is not a hole
  • Array.prototype.forEach should return undefined
  • fast/js/array-every-expected.txt:
  • fast/js/array-filter-expected.txt: Added.
  • fast/js/array-filter.html: Added.
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html:
  • fast/js/array-indexof-expected.txt:
  • fast/js/array-indexof.html:
  • fast/js/array-lastIndexOf-expected.txt:
  • fast/js/array-map-expected.txt: Added.
  • fast/js/array-map.html: Added.
  • fast/js/array-some-expected.txt:
  • fast/js/array-some.html:
  • fast/js/resources/array-every.js:
  • fast/js/resources/array-lastIndexOf.js:
11:15 PM Changeset in webkit [20568] by oliver
  • 5 edits in trunk/WebCore

2007-03-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Hyatt.

Rename DocLoader::setPasteInProgress, etc to more generic
setAllowStaleResources, etc

  • editing/Editor.cpp: (WebCore::Editor::paste):
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::checkForReload):
  • loader/DocLoader.h: (WebCore::DocLoader::setAllowStaleResources):
  • page/DragController.cpp: (WebCore::DragController::concludeDrag):
9:59 PM Changeset in webkit [20567] by oliver
  • 19 edits in trunk/WebCore

2007-03-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders and Steve.

Add a flag to DocLoader to prevent it from reloading
when performing a paste or drop operation.


Remove m_cachePolicy from CachedResource as it is never used


Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures
dragging image into GMail message in _web_writeImage and
documentFragmentFromDragData

  • editing/Editor.cpp: (WebCore::Editor::paste): prevent the docloader from reloading resources on paste
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::createResource):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader):

Tidy up constructor initialise new field

(WebCore::DocLoader::checkForReload):

Prevent reload when pasting

  • loader/DocLoader.h: (WebCore::DocLoader::setPasteInProgress): new field and setter
  • page/DragController.cpp: (WebCore::DragController::concludeDrag): prevent the docloader from reloading resources on drop
6:45 PM Changeset in webkit [20566] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - fix typo in gdk build.

  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::contentsToWindow):
6:18 PM Changeset in webkit [23203] by mjs
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

  • updates for <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
6:17 PM Changeset in webkit [20565] by mjs
  • 14 edits in trunk

LayoutTests:

Reviewed by Darin.


  • <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
  • fast/overflow/scrollRevealButton-expected.checksum:
  • fast/overflow/scrollRevealButton-expected.png:
  • fast/overflow/scrollRevealButton-expected.txt:

WebCore:

Reviewed by Darin.


  • fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)


Handle scrolling external scrollviews around the webview during
autoscroll or when scrolling into view.


This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.

  • page/FrameView.cpp: (WebCore::FrameView::scrollRectIntoViewRecursively):
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::updateContents):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
5:15 PM Changeset in webkit [20564] by thatcher
  • 1 edit in tags/JavaScriptCore-5522.4.2/JavaScriptCore/Info.plist

Versioning.

5:14 PM Changeset in webkit [20563] by thatcher
  • 2 edits in tags/JavaScriptCore-5522.4.2/JavaScriptCore

Merge a minimal version of r20351.

5:13 PM Changeset in webkit [20562] by thatcher
  • 1 copy in tags/JavaScriptCore-5522.4.2

New tag.

4:48 PM JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
4:45 PM Changeset in webkit [20561] by sfalken
  • 1 copy in tags/Safari-522.5.2b

New tag.

3:18 PM Changeset in webkit [20560] by adele
  • 3 edits in trunk/WebKit

Reviewed by Brady.

Update to last fix.

  • Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK.
  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): Added check to only use the VitalSource workaround if the app is not linked on or after the defined WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK version number.
2:52 PM Changeset in webkit [20559] by darin
  • 2 edits in trunk/WebCore

Reviewed and landed by Darin

Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
​http://bugs.webkit.org/show_bug.cgi?id=13138

  • platform/StringImpl.cpp: (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::equalIgnoringCase):
2:28 PM Changeset in webkit [20558] by antti
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix <rdar://problem/5092653>
REGRESSION: Image decoding making scrolling slow


If decoder gave back a null frame (which I think happens regularly if you don't have full frame
data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
led to massive growth in calculated image size and eventually made cache prune constantly.


No test, I don't know how to make one for this.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::cacheFrame):
2:19 PM Changeset in webkit [20557] by thatcher
  • 2 edits in branches/Safari-522/WebKit

<rdar://problem/5093473> incomplete render of menu (assertion failing in -[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]) (13026)

Rolling out r20042, and these build fixes that followed: r20050, r20058, r20064 and r20077.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView restorePortState:]):
2:13 PM Changeset in webkit [20556] by yongjzha
  • 4 edits in S60/branches/3.1m/WebCore

2007-03-28 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Zalan <​zbujtas@gmail.com>
DESC: refreshing crashes the browser on some sites (kauppalehti.fi, hs.fi)

fix: stop the tokenizer timer when switching to final document from preview document.

​http://bugs.webkit.org/show_bug.cgi?id=13219

  • khtml/html/htmltokenizer.cpp: (khtml::):
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp: (KHTMLPart::switchToDocWithPendingSrc):
1:59 PM Changeset in webkit [20555] by adele
  • 4 edits in trunk

WebCore:

Reviewed by Kevin M.

WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Convert return value to a string. This matches the behavior in Safari 2.0.

WebKit:

Reviewed by Kevin M.

WebKit part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings. We used to allow this
but now we throw a JavaScript exception for return statements that aren't in functions.

Filed this evangelism bug so we can notify VitalSource of the problem:
<rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
9:48 AM Changeset in webkit [20554] by ap
  • 8 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13190
XPath incorrectly handles namespaces on attributes

WebCore:

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but measurable performance improvement for bug 13021. (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.
  • xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::NodeTest): (WebCore::XPath::Step::NodeTest::namespaceURI): (WebCore::XPath::Step::nodeTest): (WebCore::XPath::Step::setNodeTest): Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).
  • xml/XPathGrammar.y:
  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::optimizeStepPair): Accounted for the above change.

LayoutTests:

  • fast/xpath/attr-namespace-expected.txt: Added.
  • fast/xpath/attr-namespace.html: Added.
  • fast/xpath/xpath-namespaces-expected.txt:
  • fast/xpath/xpath-namespaces.html: Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).
8:39 AM Changeset in webkit [20553] by sfalken
  • 1 copy in tags/Safari-522.5.1b

New tag.

4:31 AM Changeset in webkit [20552] by antti
  • 2 edits in trunk/WebKitLibraries

Update libWebKitSystemInterface, previous version was out of date.

  • libWebKitSystemInterface.a:
1:41 AM Changeset in webkit [20551] by oliver
  • 2 edits in trunk/WebCore

2007-03-28 Oliver Hunt <​oliver@apple.com>

rs=Hyatt.

Rollout local changes :-/

  • loader/Cache.cpp: (WebCore::Cache::pruneAllResources): (WebCore::Cache::remove):
1:38 AM Changeset in webkit [20550] by oliver
  • 2 edits in trunk/WebCore

2007-03-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Hyatt.

Roll out r20511 due to incredible badness

  • loader/Cache.cpp: (WebCore::Cache::pruneAllResources): (WebCore::Cache::remove):
12:18 AM Changeset in webkit [20549] by sfalken
  • 2 copies in branches/Safari-522

Add files missed by svn merge.

Mar 27, 2007:

11:19 PM Changeset in webkit [20548] by sfalken
  • 7 edits
    1 add in branches/Safari-522

Merge fix from r20476.

11:10 PM Changeset in webkit [20547] by sfalken
  • 30 edits
    1 delete in branches/Safari-522

Merge fix from r20475.

10:05 PM Changeset in webkit [20546] by darin
  • 2 edits in trunk/LayoutTests
  • svg/hixie/text/003-expected.txt: Updated results for this one test that now has different results due to the painting Adele added to DumpRenderTree. Long term, we just have to fix SVG so that painting doesn't cause changes to the render tree!
9:22 PM Changeset in webkit [20545] by oliver
  • 3 edits
    4 adds in trunk

2007-03-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Don't enforce text-selection drag delay when we are
going to drag an image anyway.

Fixes rdar://problem/4668935

  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag):

Layout tests:

Test to ensure there is no delay forced when dragging a selected image

  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable.html: Added.
4:38 PM Changeset in webkit [20544] by andersca
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

  • bindings/NP_jsobject.cpp: (_NPN_InvokeDefault): Call JSObject:call for native JavaScript objects.

LayoutTests:

Reviewed by Geoff.

Add NPN_InvokeDefault test.


  • plugins/netscape-invoke-default-expected.txt: Added.
  • plugins/netscape-invoke-default.html: Added.

WebKitTools:

Reviewed by Geoff.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): Add new function which takes a function and calls it using NPN_InvokeDefault.
4:29 PM Changeset in webkit [20543] by justing
  • 2 edits in trunk/WebCore

Build fix


  • editing/markup.cpp: (WebCore::startMarkup):
3:55 PM Changeset in webkit [20542] by justing
  • 5 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family

Demonstrates the bug fixed:

  • editing/style/5091898-expected.checksum: Added.
  • editing/style/5091898-expected.png: Added.
  • editing/style/5091898-expected.txt: Added.
  • editing/style/5091898.html: Added. Demonstrates a related bug fixed (deleting the line break before a paragraph could remove its underlining):
  • editing/deleting/5091898-expected.checksum: Added.
  • editing/deleting/5091898-expected.png: Added.
  • editing/deleting/5091898-expected.txt: Added.
  • editing/deleting/5091898.html: Added. Demonstrates that a link now (correctly) exists, instead of just underlined text:
  • editing/pasteboard/4840662-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family


createMarkup skipped elements if they were blocks
when called from moveParagraphs (because that function
must receive only inline content). This patch adds
code to inline these blocks instead of skipping them
so that we don't lose any of the style that they
contribute to the copied markup.

  • editing/markup.cpp: (WebCore::startMarkup): Add an inlineBlocks option. Make sure to overwrite display:block coming from a style sheet or the inline style declaration. (WebCore::createMarkup): Don't refuse to include a specialCommonAncestor that's a block if we were asked to include only inline content, since we can now inline block elements in startMarkup.
3:53 PM Changeset in webkit [20541] by adele
  • 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

Oops- my comment was missing a word.

3:50 PM Changeset in webkit [20540] by adele
  • 2 edits in trunk/WebKitTools

Adding comment.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
3:41 PM Changeset in webkit [20539] by adele
  • 2 edits in trunk/WebKitTools

Fix svg tests by calling displayIfNeeded.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
3:13 PM Changeset in webkit [20538] by zbujtas
  • 12 edits in S60/trunk

yadavall, reviewed by <​zbujtas@gmail.com>

DESC: Rich File Upload implementation
​http://bugs.webkit.org/show_bug.cgi?id=13195

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreFormControls.h:
  • khtml/html/html_formimpl.cpp: (DOM::):
  • khtml/html/html_formimpl.h:
  • khtml/rendering/render_form.cpp: (RenderFileButton::updateFromElement):
  • kwq/KWQFileButton.cpp: (KWQFileButton::setAccept):
  • kwq/KWQFileButton.h:
3:10 PM Changeset in webkit [20537] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim


  • fixed <rdar://problem/5092556> Default UA spoofing is always off until explicitly toggled
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences]
2:59 PM Changeset in webkit [20536] by thatcher
  • 3 edits
    2 copies in branches/Safari-522

Merge fix from r20456 and r20457.

2:58 PM Changeset in webkit [20535] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery

This disables the paint that occurs after WebCore finishes loading the document. We should reenable this when we
move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call. See <rdar://problem/5092361>.

  • dom/Document.cpp: (WebCore::Document::implicitClose):
2:56 PM Changeset in webkit [20534] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20441.

2:52 PM Changeset in webkit [20533] by thatcher
  • 4 edits in branches/Safari-522/WebCore

Merge fix from r20425.

2:22 PM Changeset in webkit [20532] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20474.

2:18 PM Changeset in webkit [20531] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20473.

2:16 PM Changeset in webkit [20530] by thatcher
  • 5 edits in branches/Safari-522/WebKit

Merge fix from r20471.

2:14 PM Changeset in webkit [20529] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20461.

2:12 PM Changeset in webkit [20528] by thatcher
  • 3 edits in branches/Safari-522/WebKit

Merge build fix from r20427.

1:47 PM Changeset in webkit [20527] by thatcher
  • 4 edits in branches/Safari-522/WebCore

Merge fix from r20460.

1:45 PM Changeset in webkit [20526] by thatcher
  • 3 edits
    2 copies in branches/Safari-522

Merge fix from r20458.

1:43 PM Changeset in webkit [20525] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20454.

1:41 PM Changeset in webkit [20524] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20453.

1:39 PM Changeset in webkit [20523] by thatcher
  • 7 edits
    8 copies in branches/Safari-522

Merge fix from r20449.

1:35 PM Changeset in webkit [20522] by thatcher
  • 5 edits
    2 copies in branches/Safari-522

Merge fix from r20440.

1:29 PM Changeset in webkit [20521] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20419.

1:21 PM Changeset in webkit [23202] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix for 5090964, arabic text piled on top of itself.

1:09 PM Changeset in webkit [20520] by justing
  • 3 edits
    16 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
<rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
<rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
<rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

  • editing/pasteboard/5065605-expected.checksum: Added.
  • editing/pasteboard/5065605-expected.png: Added.
  • editing/pasteboard/5065605-expected.txt: Added.
  • editing/pasteboard/5065605.html: Added.
  • editing/style/4916887-expected.checksum: Added.
  • editing/style/4916887-expected.png: Added.
  • editing/style/4916887-expected.txt: Added.
  • editing/style/4916887.html: Added.
  • editing/style/5065910-expected.checksum: Added.
  • editing/style/5065910-expected.png: Added.
  • editing/style/5065910-expected.txt: Added.
  • editing/style/5065910.html: Added.
  • editing/style/5084241-expected.checksum: Added.
  • editing/style/5084241-expected.png: Added.
  • editing/style/5084241-expected.txt: Added.
  • editing/style/5084241.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
<rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
<rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
<rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): If a node's text fill color is invalid, then its children use their font-color as their text fill color (they don't inherit it). Likewise for stroke color.
1:07 PM Changeset in webkit [23201] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Fixed <rdar://problem/5085076> WebView stops painting after
loading stand-alone netflix movie preview in WMP format


The stand-alone WMP plug-in seems to do all its drawing in
the WM_ERASEBKGN phase, not the WM_PAINT phase, so our
InvalidateRect call for plug-in windows needs to specify
'true' for whether the background region should be erased.


A smart plug-in that wants to avoid background draws can
still do so by just returning 1 in response to WM_ERASEBKGN,
or by setting its background brush to NULL.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow):
12:58 PM Changeset in webkit [20519] by yongjzha
  • 2 edits in S60/trunk/WebKit

yaharon, reviewed by <reviewer>

DESC: [S60] S60 3.2 Touch Help: Application crash when tapping scroll bar of XHTML topic
​http://bugs.webkit.org/show_bug.cgi?id=13196

  • BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::HandleScrollEventL):
11:06 AM Changeset in webkit [23200] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

<rdar://problem/5091459>
Crash when destroying "null plugin"


<rdar://problem/5056845>
Invoking itunes page has missing plugin icon on it


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paintMissingPluginIcon): Clip before painting.


(WebCore::freeStringArray):
Add null-check.


(WebCore::PluginViewWin::PluginViewWin):
Initialize plugin names and values.

9:40 AM Changeset in webkit [20518] by andersca
  • 2 edits in trunk/WebCore
  • platform/ScrollBar.h: Use wtf/MathExtras.h instead of math.h
6:02 AM Changeset in webkit [20517] by bdash
  • 1 edit in tags/Safari-4522.5.3/WebKit/Configurations/Version.xcconfig

Versioning.

6:02 AM Changeset in webkit [20516] by bdash
  • 2 edits in tags/Safari-4522.5.3/WebKit

Merge in r20513.

5:58 AM Changeset in webkit [20515] by bdash
  • 1 copy in tags/Safari-4522.5.3/WebKit

New tag (part 2).

5:57 AM Changeset in webkit [20514] by bdash
  • 1 add in tags/Safari-4522.5.3

New tag (part 1).

5:49 AM Changeset in webkit [20513] by bdash
  • 2 edits in trunk/WebKit

2007-03-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Harrison.

  • Configurations/WebKit.xcconfig: Include UMBRELLA_FRAMEWORKS_DIR in framework search path.
4:08 AM Changeset in webkit [20512] by zack
  • 2 edits in trunk/WebCore

Fix the build

3:02 AM Changeset in webkit [20511] by oliver
  • 2 edits
    1 add in trunk/WebCore

2007-03-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

The WebArchiver needs all the subresources of a document to be accessible
through the DocLoader, so we can't remove a CachedResource simultaneously
from the global Cache and all DocLoaders, just because it needs to be
reloaded in one.

Fixes rdar://problem/5044366

  • loader/Cache.cpp: (WebCore::Cache::remove):

Don't evict the resource from all DocLoaders

  • manual-tests/test-iframes-loading-the-same-resource.html: Added.

Alas it wasn't possible to make a nice layout test, even this manual test
is not entirely deterministic

2:14 AM Changeset in webkit [20510] by bdash
  • 2 edits in trunk/WebCore

2007-03-27 Mark Rowe <​mrowe@apple.com>

Build fix.

  • platform/GlyphBuffer.h: (WebCore::GlyphBuffer::clear):
2:04 AM Changeset in webkit [20509] by zack
  • 3 edits in trunk/WebKitQt

Fix the rendering crashes due to triggered
asserts and improve a bit the layout scheduling in the
Qt port

1:59 AM Changeset in webkit [23199] by hyatt
  • 3 edits in branches/WindowsMerge/WebCore

Add support for glyph offsets to the GlyphBuffer.

1:52 AM Changeset in webkit [20508] by hyatt
  • 3 edits in trunk/WebCore

Add support for glyph offsets to the GlyphBuffer.

1:32 AM Changeset in webkit [20507] by antti
  • 2 edits in trunk/WebCore

Keep buildbot happy.

  • platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::scrollbarHit):
1:10 AM Changeset in webkit [23198] by antti
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Darin.


Initialize new m_isContinuous field in WheelEvent

  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1:03 AM Changeset in webkit [20506] by antti
  • 18 edits in trunk

WebCore:

Reviewed by Darin.


On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
​http://bugs.webkit.org/show_bug.cgi?id=13134
<rdar://problem/5076249?

  • WebCore.exp:

Export _wkGetWheelEventDeltas

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):

Remove (0, 0) scroll event hack, it is not needed anymore.
Do per-pixel scrolling for fine grained events.

  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::isContinuous):

Add new m_isContinuous boolean to indicate fine grained wheel events.

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll):
  • platform/ScrollBar.h: (WebCore::Scrollbar::value):

Use float to represent current position to support finer grained scrolling.
Add ScrollByPixel, remove ScrollByWheel (which was same as ScrollByLine anyway)

  • platform/ScrollTypes.h: (WebCore::):
  • platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Initalize m_isContinuous

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Add wkGetWheelEventDeltas for getting fine grained wheel events

  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Get the wheel deltas using new wkGetWheelEventDeltas interface

  • platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Initalize m_isContinuous

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight):

Pass item height to scrollbar

WebKit:

Reviewed by Darin.


On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
​http://bugs.webkit.org/show_bug.cgi?id=13134
<rdar://problem/5076249?

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Expose GetWheelEventDeltas()

WebKitLibraries:

Reviewed by Darin.


Added wkGetWheelEventDeltas

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
12:02 AM Changeset in webkit [23197] by hyatt
  • 6 edits in branches/WindowsMerge

Enable complex text.

Mar 26, 2007:

9:45 PM Changeset in webkit [23196] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

This one didn't actually have any leaks, but I just felt like doing the
same style cleanup as the others :)


  • WebPreferences.cpp: (WebPreferences::stringValueForKey): (WebPreferences::integerValueForKey): (WebPreferences::floatValueForKey): (WebPreferences::setStringValue): (WebPreferences::setIntegerValue): (WebPreferences::save): (WebPreferences::load):
8:49 PM Changeset in webkit [20505] by ddkilzer
  • 2 edits in trunk

Added Radar references.

7:46 PM Changeset in webkit [20504] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

fixed up order of ChangeLog entries

7:36 PM Changeset in webkit [20503] by ggaren
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin Adler.


Layout tests for <rdar://problem/5088234> REGRESSION: Crash occurs at
WebCore::Node::createRendererIfNeeded() when changing map views with MS
Virtual Earth (​http://www.ziprealty.com/)

  • fast/dom/mutation-event-remove-inserted-node-expected.txt: Added.
  • fast/dom/mutation-event-remove-inserted-node.html: Added.
  • fast/dom/script-element-remove-self-expected.txt: Added.
  • fast/dom/script-element-remove-self.html: Added.

WebCore:

Reviewed by Darin, landed by Anders.

Manual test case for ​http://bugs.webkit.org/show_bug.cgi?id=13142

  • manual-tests/liveconnect-applet-get-boolean.html: Added.
  • manual-tests/resources/CheckerApplet.class: Added.
  • manual-tests/resources/CheckerApplet.java: Added.
7:33 PM Changeset in webkit [23195] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

<rdar://5090412> - Plug CFNumberRef leaks in WebCache


  • WebCache.cpp: (WebCache::statistics):
6:57 PM Changeset in webkit [20502] by andersca
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin, landed by Anders.

Fix for: ​http://bugs.webkit.org/show_bug.cgi?id=13142

The previous fix ​http://bugs.webkit.org/show_bug.cgi?id=12636
introduced new JNIType to enum in jni_utility.h This is a
problem on the Mac as it seems that the JNIType enum is also
used in the JVM, it is used to specify the return type in
jni_objc.mm
Corrected the fix by moving type to the end, and changing
jni_objc.mm to convert the new type to an old compatible
type.

  • bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):
  • bindings/jni/jni_utility.h:

WebCore:

Reviewed by Darin, landed by Anders.

Manual test case for ​http://bugs.webkit.org/show_bug.cgi?id=13142

  • manual-tests/liveconnect-applet-get-boolean.html: Added.
  • manual-tests/resources/CheckerApplet.class: Added.
  • manual-tests/resources/CheckerApplet.java: Added.
6:11 PM Changeset in webkit [20501] by aroben
  • 5 edits in trunk/JavaScriptCore

Reviewed/landed by Adam.

Bug 13198: Move build settings from project file to xcconfig file for apollo
port JSCore
​http://bugs.webkit.org/show_bug.cgi?id=13198

  • Moving build settings from xcode project file to xcconfig files.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
5:12 PM Changeset in webkit [23194] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Geoff.

Fix build without breaking anything.

  • WebHistory.cpp: (releaseUserInfo): Added silly void statement for now.
4:55 PM Changeset in webkit [23193] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubber-stamped by Brady.

Build fix for release build.

  • WebHistory.cpp: (releaseUserInfo): Do not store userInfo->Release() in a local variable since it is only used for an ASSERT.
4:52 PM Changeset in webkit [20500] by beidson
  • 3 edits in trunk/JavaScriptCore

Rubberstamped by Anders and Maciej aand Geoff (oh my!)


Since CFTypeRef is really void*, a RetainPtr couldn't be used.
RefType was "void", which doesn't actually exist as a type.
Since RefType only existed for operator*(), and since that operator
doesn't make any sense for RetainPtr, I removed them!

  • kjs/nodes.cpp: Touch this to force a rebuild and (hopefully) help the compiler with dependencies
  • wtf/RetainPtr.h: Nuke RefType and operator*()
4:46 PM Changeset in webkit [20499] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • fast/replaced/selection-rect-in-table-cell-expected.checksum: Added.
  • fast/replaced/selection-rect-in-table-cell-expected.png: Added.
  • fast/replaced/selection-rect-in-table-cell-expected.txt: Added.
  • fast/replaced/selection-rect-in-table-cell.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/replaced/selection-rect-in-table-cell.html

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect):
3:09 PM Changeset in webkit [20498] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison


  • fixed <rdar://problem/4769772> Problem with Find on certain PDF page
  • WebView/WebPDFView.mm: (-[WebPDFView _scaledAttributedString:]): We were hitting an exception trying to set the font attribute to nil, which was happening because the result of -[PDFSelection attributedString] had no attributes. That PDFSelection bug is now filed separately, but this works around the exception.
1:55 PM Changeset in webkit [23192] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.


<rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"

  • WebIconDatabase.cpp: (userIconDatabasePath): Move icon database to non-roaming location
1:32 PM Changeset in webkit [20497] by ggaren
  • 2 edits in trunk/JavaScriptCore

Touched a file to (hopefully) help the compiler with RetainPtr dependencies.

  • kjs/nodes.cpp: (Node::deref):
1:31 PM Changeset in webkit [20496] by ggaren
  • 9 edits in trunk/WebCore

Removed now-stale #includes of <assert.h>.


  • WebCorePrefix.h:
  • config.h:
  • css/CSSGrammar.y:
  • platform/Arena.cpp:
  • platform/KURL.cpp:
  • platform/SegmentedString.h:
  • rendering/DataRef.h:
  • rendering/RenderArena.cpp:
1:08 PM Changeset in webkit [20495] by ggaren
  • 56 edits in trunk/WebCore

Reviewed by Kevin McCulough.

Global replace of "assert(" with "ASSERT(" to assist debugging. Removed
one instance of commented-out code containing "assert(" instead of replacing it.

1:00 PM Changeset in webkit [23191] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5088844> Popup menu is not positioned correctly on a yahoo comics page


Fixes test: fast/forms/control-restrict-line-height.html


This change was made in RenderThemeMac a while ago, and will fix the line height for aqua popup buttons,
buttons and search fields.


9:57 AM Changeset in webkit [20494] by darin
  • 2 edits in trunk/WebKitSite
  • coding/coding-style.html: Let's misquote George Orwell: "Wrong is right. Right is wrong."

Mar 25, 2007:

9:10 PM Changeset in webkit [20493] by darin
  • 2 edits in trunk/WebKitSite
  • coding/coding-style.html: Put !important on right/wrong colors so they override the green color that comes from the green.css stylesheet.
9:07 PM Changeset in webkit [20492] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: A couple minor wording tweaks.
9:05 PM Changeset in webkit [20491] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: Put the operator name "new" in the oblique style as with other identifiers.
8:54 PM Changeset in webkit [23190] by beidson
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver

<rdar://problem/5086888> - WebHistory(Item) Leak

  • platform/win/COMPtr.h: (COMPtr::COMPtr): An an adoptRef constructor


WebKitWin:

Reviewed by Oliver


<rdar://problem/5086888> - WebHistory(Item) Leak


This is a pretty thourough touchup up style and correctness that
plugs at least 1 definite leak and many potential leaks with
extensive use of RetainPtr and COMPtr.


This should result in no change in behavior

  • MarshallingHelpers.cpp: Add kIUnknownDictionaryValueCallBacks
  • MarshallingHelpers.h: Ditto


  • WebHistory.cpp: (createUserInfoFromArray): (createUserInfoFromHistoryItem): (releaseUserInfo): (WebHistory::WebHistory): (WebHistory::~WebHistory): (WebHistory::loadFromURL): (createHistoryListFromStream): Split of the Structured Exception Handling to a seperate function to cooperate with C++ (WebHistory::loadHistoryGutsFromURL): (WebHistory::saveToURL): (WebHistory::saveHistoryGuts): (WebHistory::datesArray): (WebHistory::addItems): (WebHistory::removeItems): (WebHistory::removeAllItems): (WebHistory::orderedLastVisitedDays): (WebHistory::orderedItemsLastVisitedOnDay): (WebHistory::removeItem): (WebHistory::addItem): (WebHistory::addItemForURL): (WebHistory::itemForURLString): (WebHistory::itemForURL): (WebHistory::containsItemForURLString): (WebHistory::removeItemForURLString): (WebHistory::addItemToDateCaches): (WebHistory::removeItemFromDateCaches): (WebHistory::findIndex): (WebHistory::insertItem): (WebHistory::ageLimitDate):
  • WebHistory.h:


  • WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation): (WebHistoryItem::mergeAutoCompleteHints):
4:45 PM Changeset in webkit [23189] by aroben
  • 2 edits
    4 adds in branches/WindowsMerge/LayoutTests

LayoutTestsWin:

Reviewed by Anders.

Fix <rdar://problem/5066290> boomer-run-webkit-tests doesn't support
http tests

  • Skipped: Removed http tests from the skipped list.
  • http/conf/cygwin-httpd.conf: Added.
  • http/conf/libphp4.dll: Added.
3:42 PM Changeset in webkit [20490] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adam.


Test for <rdar://problem/5049842>
Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()

  • editing/pasteboard/drag-drop-dead-frame-expected.checksum: Added.
  • editing/pasteboard/drag-drop-dead-frame-expected.png: Added.
  • editing/pasteboard/drag-drop-dead-frame-expected.txt: Added.
  • editing/pasteboard/drag-drop-dead-frame.html: Added.

WebCore:

Reviewed by Adam.

Fix <rdar://problem/5049842>
Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()

Null check frame in m_dragTarget, it might be gone already.

  • page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::cancelDragAndDrop): (WebCore::EventHandler::performDragAndDrop):
1:14 PM Changeset in webkit [23188] by aroben
  • 11 edits
    4 adds in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Oliver.

  • Skipped: Added two more crashers for when we enable http tests.

WebKitToolsWin:

Reviewed by Oliver.

Fix <rdar://problem/5086934> DumpRenderTree doesn't support
layoutTestController.queueLoad

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Ported Mac code to check the MIME type before dumping. (runTest): Clear the work queue before each test.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added new files.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (notifyDoneCallback): Only dump if the work queue is empty. (jsValueToCString): Added. (queueLoadCallback): Added. (queueReloadCallback): Added. (queueScriptCallback): Added. (queueBackNavigationCallback): Added. (queueForwardNavigationCallback): Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::processWork): Added. (processWorkTimer): Added. (WaitUntilDoneDelegate::locationChangeDone): Changed to match Mac.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Added declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Added. (WorkQueue::shared): (WorkQueue::WorkQueue): (WorkQueue::queue): (WorkQueue::dequeue): (WorkQueue::count): (WorkQueue::clear):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Added. (WorkQueue::setFrozen):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Added. (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Added. (LoadItem::LoadItem): (LoadItem::url): (LoadItem::target): (ScriptItem::ScriptItem): (ScriptItem::script): (BackItem::BackItem): (ForwardItem::ForwardItem):

WebKitWin:

Reviewed by Oliver.

WebKit part of <rdar://problem/5086934> DumpRenderTree doesn't support
layoutTestController.queueLoad

  • WebFrame.cpp: (WebFrame::findFrameNamed): Implemented.
  • WebHistoryItem.cpp: (WebHistoryItem::children): Don't increment i twice per loop!
8:10 AM Changeset in webkit [20489] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-26 Mark Rowe <​mrowe@apple.com>

Reviewed by Sam Weinig.

Upload crash logs from DumpRenderTree as part of the test results to ease debugging
of hard-to-reproduce crashes.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3:33 AM Changeset in webkit [20488] by bdash
  • 2 edits in trunk/WebKitSite

2007-03-25 Mark Rowe <​mrowe@apple.com>

Fix grammar error that Mitz pointed out. Replace raw ampersands in hyperlink URL with named entity.

  • coding/RefPtr.html:
3:25 AM Changeset in webkit [23187] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebDownload.h: Include RetainPtr from WTF.
1:39 AM Changeset in webkit [20487] by ap
  • 6 edits in trunk/WebCore

Reviewed by Darin.

A partial fix for ​http://bugs.webkit.org/show_bug.cgi?id=13021
XPath can be very slow

  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Reset a reference to the context node, as this may prevent the whole document from being destroyed in time.
  • dom/Attr.cpp: (WebCore::Attr::createTextChild): Instead of calling appendChild(), just do the few operations it really needs to perform.
  • dom/ContainerNode.h: (WebCore::ContainerNode::fastSetFirstChild): (WebCore::ContainerNode::fastSetLastChild): Added operations that let Attr hack internal ContainerNode data (evil, but fast!).
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis): (WebCore::XPath::Step::nodeMatches):
  • xml/XPathStep.h: Merged node testing into axis enumeration. This saves a lot of Vector resizing and passing, and is necessary for future optimizations (sometimes, we can just pick the single result node instead of enumerating and filtering the whole axis).
12:43 AM Changeset in webkit [20486] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: A couple wording tweaks.
12:11 AM Changeset in webkit [20485] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: More formatting tweaks. Added a possible new topic for the document, suggested by Anders.

Mar 24, 2007:

11:52 PM Changeset in webkit [20484] by darin
  • 2 edits in trunk/WebKitSite
  • css/main.css: Try tighter spacing for code examples.
11:48 PM Changeset in webkit [20483] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: <span> -> </span>
11:44 PM Changeset in webkit [20482] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: "smart pointer" -> "smart pointers"
11:38 PM Changeset in webkit [20481] by darin
  • 17 edits
    1 add in trunk/WebKitSite
  • coding/RefPtr.html: Added. First draft of a document about RefPtr.

Also tweaked the MIME types of a few files and removed a stray executable bit.

11:37 PM Changeset in webkit [20480] by hyatt
  • 2 edits in trunk/WebKit

Amend the statistics reporting for the WebCore cache to include XSL and to report live/decoded sizes.

  • Misc/WebCache.mm: (+[WebCache statistics]):
11:28 PM Changeset in webkit [20479] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/text/midword-break-after-breakable-char-expected.checksum: Added.
  • fast/text/midword-break-after-breakable-char-expected.png: Added.
  • fast/text/midword-break-after-breakable-char-expected.txt: Added.
  • fast/text/midword-break-after-breakable-char.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/text/midword-break-after-breakable-char.html

Breaking in the middle of the word
is allowed only if no breaking opportunity between words has occurred yet. The
first position on the line should not be considered "between words" even if
it is a breaking opportunity.


  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Changed according to the above. Also cleaned up a couple of lines.
10:53 PM Changeset in webkit [20478] by hyatt
  • 13 edits in trunk/WebCore

Fix for bugzilla bug 13187, place a hard limit on the amount of decoded data that WebCore will keep
around even on live pages (pages being displayed in tabs/windows or in the back/forward cache).
Images will decode to paint and once the decoded data exceeds the cache size, the decoded data will be
tossed.

Refine the flushing algorithm to apply the two-pass decode/evict model to each LRU-SP queue individually, rather
than to all the lists at once. This allows the cache to evict large encoded resources before flushing small
or frequently accessed decoded onces.

Added information on live/decoded data to the cache statistics.

Reviewed by darin

  • loader/Cache.cpp: (WebCore::Cache::Cache): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneAllResources): (WebCore::Cache::setMaximumSize): (WebCore::Cache::remove): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::liveLRUListFor): (WebCore::Cache::removeFromLiveResourcesList): (WebCore::Cache::insertInLiveResourcesList): (WebCore::Cache::addToLiveResourcesSize): (WebCore::Cache::removeFromLiveResourcesSize): (WebCore::Cache::adjustSize): (WebCore::Cache::getStatistics):
  • loader/Cache.h: (WebCore::Cache::TypeStatistic::TypeStatistic):
  • loader/CachedImage.cpp: (WebCore::CachedImage::decodedSizeWillChange): (WebCore::CachedImage::decodedSizeChanged):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::ref): (WebCore::CachedResource::deref): (WebCore::CachedResource::setEncodedSize): (WebCore::CachedResource::liveResourceAccessed):
  • loader/CachedResource.h: (WebCore::CachedResource::liveAccessCount): (WebCore::CachedResource::resetLiveAccessCount): (WebCore::CachedResource::increaseLiveAccessCount):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::cacheFrame):
  • platform/graphics/ImageObserver.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorderImage):
10:14 PM Changeset in webkit [23186] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-24 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • WebDownload.h: Remove WebCore namespace
9:31 PM Changeset in webkit [23185] by aroben
  • 9 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Fix <rdar://problem/5086932> DumpRenderTree doesn't support
layoutTestController.dumpBackForwardList

Unfortunately the ported code is mostly untested due to
<rdar://problem/5086934>.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (compareHistoryItems): Ported from Mac. (dumpHistoryItem): Ditto. (dumpBackForwardList): Ditto. (dump): Dump the back-forward list if requested. (runTest): Initialize new globals.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpBackForwardListCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

WebKit part of <rdar://problem/5086932> DumpRenderTree doesn't support
layoutTestController.dumpBackForwardList

  • Interfaces/IWebHistoryItemPrivate.idl: Added declarations.
  • WebFrame.cpp: (WebFrame::childFrames): Removed unused variable.
  • WebHistoryItem.cpp: (WebHistoryItem::target): Implemented. (WebHistoryItem::isTargetItem): Implemented. (WebHistoryItem::children): Implemented.
  • WebHistoryItem.h: Added declarations.
7:48 PM Changeset in webkit [20477] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

  • fast/css/css-selector-text-expected.txt: Added.
  • fast/css/css-selector-text.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/css/css-selector-text.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText): Add the namespace prefix for tag or attribute names, the sub-selector for :not, and the argument for :lang.
6:27 PM Changeset in webkit [23184] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fix <rdar://problem/5076610> Crash in PluginViewWin::updateWindow when
loading a PDF page for the first time after installing Acrobat Reader

Don't call PluginPackageWin::load() until the PluginViewWin has been
inserted into the Widget tree. load() can result in arbitrary code
execution (in this case, a EULA window appears which takes focus from
the WebView, causing Frame::setIsActive(false) to be called), and we
don't want to be in a transitional state when that happens.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): Call PluginViewWin's one and only constructor.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setParent): Call init() after inserting ourselves into the Widget tree. (WebCore::PluginViewWin::PluginViewWin): Defer all real work until init() is called. (WebCore::PluginViewWin::init): Added. Calls m_plugin->load(), then does the rest of the work that was once done by the constructor.
  • plugins/win/PluginViewWin.h: Removed createNullPlugin and simplified constructor, added setParent override and new init method.
6:22 PM Changeset in webkit [20476] by beidson
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Adam

Whoops, RetainPtr should be in the WTF namespace

  • wtf/RetainPtr.h:

WebKit:

Reviewed by Adam

RetainPtr is no longer in the WebCore namespace

  • History/WebBackForwardList.mm:
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebView/WebDocumentLoaderMac.h:
4:27 PM Changeset in webkit [23183] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF for WebKitWin and the App

  • WebCore.vcproj/WebCore.vcproj: Add the ForwardingHeader to the vcprojs
4:21 PM Changeset in webkit [20475] by beidson
  • 30 edits
    1 move
    2 adds in trunk

JavaScriptCore:

Reviewed by Adam


<rdar://problem/5086210> - Move RetainPtr to WTF

WebCore:

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF

  • ForwardingHeaders/wtf/RetainPtr.h: Added.
  • WebCore.xcodeproj/project.pbxproj: Removed WebCore/RetainPtr.h


  • history/HistoryItem.h: Changed #include to <wtf/RetainPtr.h>
  • history/PageCache.h: Ditto
  • page/mac/WebCoreFrameBridge.mm: Ditto
  • platform/ContextMenu.h: Ditto
  • platform/ContextMenuItem.h: Ditto
  • platform/DragImage.h: Ditto
  • platform/FileChooser.h: Ditto
  • platform/PlatformKeyboardEvent.h: Ditto
  • platform/PopupMenu.h: Ditto
  • platform/SharedBuffer.h: Ditto
  • platform/cf/RetainPtr.h: Removed.
  • platform/graphics/Icon.h: Changed #include
  • platform/mac/ClipboardMac.h: Ditto
  • platform/mac/PasteboardMac.mm: Ditto
  • platform/mac/WidgetMac.mm: Ditto
  • platform/network/AuthenticationChallenge.h: Ditto
  • platform/network/ResourceError.h: Ditto
  • platform/network/ResourceHandle.h: Ditto
  • platform/network/ResourceRequest.h: Ditto
  • platform/network/ResourceResponse.h: Ditto
  • rendering/RenderThemeMac.mm: Ditto

WebKit:

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF


  • ForwardingHeaders/wtf/RetainPtr.h: Added.
  • History/WebBackForwardList.mm: Changed #import to <wtf/RetainPtr.h>
  • WebCoreSupport/WebEditorClient.h: Ditto
  • WebCoreSupport/WebFrameLoaderClient.h: Ditto
  • WebView/WebDocumentLoaderMac.h: Ditto
4:15 PM Changeset in webkit [20474] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5086797>, layoutPending is now reporting incorrect results, which will lead
to all sorts of layout issues. This is in bugzilla as 13179.

Reviewed by hyatt

Moved the root->needsLayout() check from layoutPending() to needsLayout()
to restore the behavior before r20324.

  • page/FrameView.cpp: (WebCore::FrameView::layoutPending): (WebCore::FrameView::needsLayout):
3:13 PM Changeset in webkit [20473] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Adele.

<rdar://problem/5084478>

Another debug build crash from ASSERTION FAILED: !needsLayout()

No test possible because updateRendering() is always called after script
execution.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Get the layout root after calling recalcStyle() since a style recalc may result in needing to do start layout at the root.
2:53 PM Changeset in webkit [20472] by zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Build fix.
Fix FloatRect vs. IntRect confusion.

10:25 AM Changeset in webkit [20471] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Adele

  • fixed <rdar://problem/5084872> Need to add flickr to spoof list in WebKit
  • only do site-specific spoofing if a preference is set
  • WebView/WebPreferenceKeysPrivate.h: added WebKitUseSiteSpecificSpoofingPreferenceKey


  • WebView/WebPreferences.m: (+[WebPreferences initialize]): initialize WebKitUseSiteSpecificSpoofingPreferenceKey to false (-[WebPreferences _useSiteSpecificSpoofing]): get value of WebKitUseSiteSpecificSpoofingPreferenceKey (-[WebPreferences _setUseSiteSpecificSpoofing:]): set value of WebKitUseSiteSpecificSpoofingPreferenceKey


  • WebView/WebPreferencesPrivate.h: declare _useSiteSpecificSpoofing and _setUseSiteSpecificSpoofing


  • WebView/WebView.mm: cache the value of WebKitUseSiteSpecificSpoofingPreferenceKey in a bool in _private (-[WebView _preferencesChangedNotification:]): update the cached value (-[WebView setPreferences:]): ditto (-[WebView WebCore::_userAgentForURL:WebCore::]): Only spoof here if the new site-specific spoofing preference is enabled. If it is, pass Safari 2.0.4's user agent string for flickr.com. We can remove this case when 5081617 is addressed.
6:26 AM Changeset in webkit [20470] by bdash
  • 2 edits in trunk/WebCore

Fix incorrect radar number.

5:27 AM Changeset in webkit [20469] by zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Oliver.

Fix all known RenderSVGImage problems.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12126 (RenderSVGImage seems to suffer from integer overflow)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12442 (raster images disappearing during script execution (SVG))
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12572 (WebKit does not properly invalidate image region after image load)

Added test: svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html

3:25 AM Changeset in webkit [20468] by bdash
  • 2 edits in trunk/WebCore

2007-03-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize):
3:16 AM Changeset in webkit [20467] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5086400>, images scrolled offscreen continue to animate. Safari 2 would
halt animations when images were no longer visible.

Reviewed by mjs, olliej

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::advanceAnimation):
2:24 AM Changeset in webkit [20466] by bdash
  • 1 edit in tags/Safari-4522.5.2/JavaScriptGlue/Configurations/Version.xcconfig

Versioning.

2:24 AM Changeset in webkit [20465] by bdash
  • 2 edits in tags/Safari-4522.5.2/JavaScriptGlue

Merge in r20461.

2:22 AM Changeset in webkit [20464] by bdash
  • 1 copy in tags/Safari-4522.5.2/JavaScriptGlue

New tag (part 2).

2:21 AM Changeset in webkit [20463] by bdash
  • 1 add in tags/Safari-4522.5.2

New tag (part 1).

2:20 AM Changeset in webkit [20462] by bdash
  • 2 edits in trunk/JavaScriptGlue

2007-03-24 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Hyatt.

  • JavaScriptGlue.xcodeproj/project.pbxproj: Use GCC 4.0 for testjsglue.
12:07 AM Changeset in webkit [20461] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/508328>, sluggish text entry in search field. Make sure
our size actually changed before we decide to do a full repaint because of background/border
complexities.

Reviewed by aroben

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):

Mar 23, 2007:

11:24 PM Changeset in webkit [20460] by hyatt
  • 4 edits in trunk/WebCore

Fix Gmail spurious glyphs issue.

9:38 PM Changeset in webkit [20459] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

  • editing/selection/doubleclick-crash-expected.checksum:
  • editing/selection/doubleclick-crash-expected.png:
  • fast/text/selection-hard-linebreak-expected.checksum: Added.
  • fast/text/selection-hard-linebreak-expected.png: Added.
  • fast/text/selection-hard-linebreak-expected.txt: Added.
  • fast/text/selection-hard-linebreak.html: Added.

WebCore:

Reviewed by Adele.

  • fix a bug where selecting across a soft line break did not highlight to the end of the first line if it contained skipped whitespace

Test: fast/text/selection-hard-linebreak.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): Changed to treat a selection that ends on the end of a hard line break as if it ends after the line break. Fixed the case of a selection that starts and ends in the same text object as the box but does not intersect it to return SelectionNone instead of selectionBoth.
9:05 PM Changeset in webkit [20458] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/frames/hover-timer-crash-expected.txt: Added.
  • fast/frames/hover-timer-crash.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/frames/hover-timer-crash.html

  • page/Frame.cpp: (WebCore::Frame::setView): Added a call to EventHandler::clear().
8:56 PM Changeset in webkit [23182] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam


<rdar://5086194> - WebHistory overreleases a CFNumber


  • WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL): Don't CFRelease what we didn't legitimately get a ref for!
6:41 PM Changeset in webkit [23181] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

WebKit part of <rdar://problem/5084881> Add a "turn of site-specific
hacks" menu item to the Debug menu

Added new IWebPrivate::setAllowSiteSpecificHacks SPI.

  • Interfaces/IWebViewPrivate.idl: Added declaration.
  • WebView.cpp: (WebView::userAgentForKURL): Only give a site-specific UA if site-specific hacks are turned on. (WebView::setAllowSiteSpecificHacks): Added.
  • WebView.h: (WebView::allowSiteSpecificHacks): Added.
6:18 PM Changeset in webkit [20457] by justing
  • 1 edit in trunk/WebCore/editing/ReplaceSelectionCommand.cpp

Forgot to include these nil checks in my previous checkin.

5:58 PM Changeset in webkit [20456] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by adele

<rdar://problem/5078739>
Crash in in ReplaceSelectionCommand if the fragment contains only a style span

  • editing/pasteboard/5078739-expected.txt: Added.
  • editing/pasteboard/5078739.html: Added.

WebCore:

Reviewed by adele

<rdar://problem/5078739>
Crash in in ReplaceSelectionCommand if the fragment contains only a style span

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Check for an empty fragment after removing a redundant style span instead of before.
3:54 PM Changeset in webkit [23180] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5083928> In editable webviews, caps lock key is ignored

  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Removed code to store lowercase characters in m_text. Now that we use the character code to create m_text this is already taken care of. This does mean that m_unmodifiedText is not right. This is used for accesskeys, which don't work yet, so that is covered in rdar://5085596. This also fixes line endings in this file.
3:32 PM Changeset in webkit [23179] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Hyatt.

Fix for <rdar://problem/5083914> Cursor is wrong for all context
menus

  • WebView.cpp: (WebView::handleContextMenuEvent): Set the cursor to the pointer cursor.
3:26 PM Changeset in webkit [20455] by aroben
  • 3 edits
    2 adds in trunk/JavaScriptCore

Reviewed/landed by Adam.

Bug 13175: Make apollo mac project files for JavaScriptCore actually
build something
​http://bugs.webkit.org/show_bug.cgi?id=13175

  • JavaScriptCore.apolloproj/ForwardingSources/grammar.cpp: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
2:48 PM Changeset in webkit [20454] by hyatt
  • 2 edits in trunk/WebCore

<rdar://problem/5085063>

Fix non-looping animation on cuteoverload.com. Just always flush
decoded data for large animated images to avoid our cache getting
out of sync with the image source.

Reviewed by ggaren

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::advanceAnimation):
2:09 PM Changeset in webkit [20453] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5061024> REGRESSION: Returning false from onkeypress event on Input is ignored when key is Tab
​http://bugs.webkit.org/show_bug.cgi?id= 13020

No known way to add a layout test for this. We would need a way to know exactly how the event was consumed.

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): If the keypress event has its default behavior prevented, then we should consider the keydown event handled.
1:53 PM Changeset in webkit [20452] by brmorris
  • 2 edits in S60/trunk/WebCore

rathnasa, reviewed by zalan

DESC: [S60] ESMS-6YDMWP: TRUE - GSM - broswer crashes on certain web pages
Quick fix to validate null pointers
​http://bugs.webkit.org/show_bug.cgi?id=13074

1:53 PM Changeset in webkit [23178] by aroben
  • 2 edits in branches/WindowsMerge

Being a Boy Scout.

1:50 PM Changeset in webkit [23177] by aliceli1
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Reviewed by Adam.

Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit

  • WebView.cpp: (WebView::userAgentForKURL): added flickr spoof
1:49 PM Changeset in webkit [23176] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by NOBODY (OOPS!).

Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit

  • WebView.cpp: (WebView::userAgentForKURL): added flickr spoof
1:48 PM Changeset in webkit [20451] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-03-23 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: onFocus/onClick could destroy the node (and the associated rendered) under the cursor. fix to check
if the renderer is still valid.
​http://bugs.webkit.org/show_bug.cgi?id=13172

  • kwq/KWQKHTMLPart.cpp:
1:43 PM Changeset in webkit [20450] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-03-23 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: onFocus/onClick could destroy the node (and the associated rendered) under the cursor. fix to check
if the renderer is still valid.
​http://bugs.webkit.org/show_bug.cgi?id=13172

  • kwq/KWQKHTMLPart.cpp:
1:42 PM Changeset in webkit [20449] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin

Fixed (was missing a newline):

  • editing/execCommand/4917055-expected.txt: Tests setting a caet before the image and changing its alignment:
  • editing/execCommand/5080333-1-expected.checksum: Added.
  • editing/execCommand/5080333-1-expected.png: Added.
  • editing/execCommand/5080333-1-expected.txt: Added.
  • editing/execCommand/5080333-1.html: Added. Tests selecting the image and changing its alignment:
  • editing/execCommand/5080333-2-expected.checksum: Added.
  • editing/execCommand/5080333-2-expected.png: Added.
  • editing/execCommand/5080333-2-expected.txt: Added.
  • editing/execCommand/5080333-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5080333>
REGRESSION: Selection changes when changing the alignment of an image


Regression occurred when we started using moveParagraphs
to move content in applyBlockStyle. moveParagraphs
moves by copying, deleting and reinserting content, and
so must be accompanied by selection preservation code.
That code uses rangeFromLocationAndLength and rangeLength,
which use TextIterators, which don't emit anything for images
and other replaced elements, causing this bug.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Ask rangeLength and rangeFromLocationAndLength to request that their TextIterators emit spaces for replaced elements. Use rangeCompliantEquivalent()s when creating a Range from VisiblePositions, since some VisiblePositions have illegal deepEquivalent()s.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::handleReplacedElement): Emit a space if requested. (WebCore::TextIterator::representNodeOffsetZero): Emit ranges before m_node, not around m_lastTextNode. These ranges should represent the part of the document associated with the emitted character. (WebCore::TextIterator::rangeLength): Take in the new bool. (WebCore::TextIterator::rangeFromLocationAndLength): Ditto. Also, don't loop an extra time after finding the end of the range when we're looking for zero length ranges. This appeared to be a workaround for the bugs fixed in representNodeOffsetZero in this patch.
  • editing/TextIterator.h:
1:05 PM Changeset in webkit [20448] by bdash
  • 4 edits in tags/Safari-4522.5.1

Versioning.

1:03 PM Changeset in webkit [20447] by bdash
  • 8 edits in tags/Safari-4522.5.1

Merge in r20445.

12:58 PM Changeset in webkit [20446] by bdash
  • 1 copy in tags/Safari-4522.5.1

New tag.

12:51 PM Changeset in webkit [20445] by bdash
  • 8 edits in trunk

2007-03-24 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/JavaScriptCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/JavaScriptGlue.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/WebCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/WebKit.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.
12:13 PM Changeset in webkit [20444] by zbujtas
  • 2 edits in S60/trunk/WebCore

yadavall, reviewed by <​zbujtas@gmail.com>

DESC: Fix NULL pointer check for CacheImage
​http://bugs.webkit.org/show_bug.cgi?id=13094

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NavigableNodeUnderCursor):
11:39 AM Changeset in webkit [20443] by darin
  • 2 edits in trunk/WebCore
  • html/HTMLBodyElement.cpp: Fix comment typo.
11:38 AM Changeset in webkit [20442] by staikos
  • 2 edits in trunk/WebCore

Patch from Adam Treat to make the Qt build work without SVG and XSLT as well as
with.

11:25 AM Changeset in webkit [20441] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/5074439> handle margins on frame and iframe elements without involving FrameView, FrameLoader, etc.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument): Grab the margin from the frame directly here. There was no real benefit to doing this via FrameView. Later we can delete quite a bit of unneeded code here and in WebKit that exists only to set up the margin values in FrameView, which are now unused.
11:24 AM Changeset in webkit [20440] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
​http://bugs.webkit.org/show_bug.cgi?id=13121

  • fast/dom/HTMLInputElement/input-hidden-value-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-hidden-value.html: Added.
  • fast/forms/input-value-expected.txt:

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
​http://bugs.webkit.org/show_bug.cgi?id=13121

Rolled out the change for 11866 that made hidden input elements store the value separately from the value attribute.
Added an m_originalValue field that gets set when the element is done being parsed (in closeRenderer). In reset,
use the m_originalValue for hidden input elements.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::closeRenderer): (WebCore::HTMLInputElement::reset): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
  • html/HTMLInputElement.h:
11:01 AM Changeset in webkit [20439] by staikos
  • 2 edits in trunk/WebKitTools

Patch by Adam Treat. Removes hardcoded path to .pro file.

10:48 AM Changeset in webkit [20438] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-22 spadma <​sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
​http://bugs.webkit.org/show_bug.cgi?id=13160
TSW ID: PNIO-6T5GMC

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
10:45 AM Changeset in webkit [20437] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-22 spadma <​sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
​http://bugs.webkit.org/show_bug.cgi?id=13160
TSW ID: PNIO-6T5GMC

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
8:08 AM Changeset in webkit [20436] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-20 spadma <​sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser closes when clicked RSS20 feed icons on motime web
​http://bugs.webkit.org/show_bug.cgi?id=13131
TSW ID: AKKO-6Z3AM2


  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::HandleError):
8:07 AM Changeset in webkit [20435] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-20 spadma <​sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser closes when clicked RSS20 feed icons on motime web
​http://bugs.webkit.org/show_bug.cgi?id=13131
TSW ID: AKKO-6Z3AM2


  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::HandleError):
8:05 AM Changeset in webkit [20434] by spadma
  • 4 edits in S60/trunk

2007-03-20 sareen

Reviewed by Zalan/Sachin.
DESC: Pointer cannot be moved after opening flash to player and returning to page ( MLIO-6YEGYC )
​http://bugs.webkit.org/show_bug.cgi?id=13014

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):
8:02 AM Changeset in webkit [20433] by spadma
  • 4 edits in S60/branches/3.1m

2007-03-20 sareen

Reviewed by Zalan/Sachin.
DESC: Pointer cannot be moved after opening flash to player and returning to page ( MLIO-6YEGYC )
​http://bugs.webkit.org/show_bug.cgi?id=13014

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):
7:57 AM Changeset in webkit [20432] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-22 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by ​zbujtas@gmail.com
DESC: [S60] Some images crash when browsing some wap page - TKWG-6Z59YX in 3.1m branch
Fix: Remove extra image content-type strings added by the server before passing it to the image decoder.
​http://bugs.webkit.org/show_bug.cgi?id=13151

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::ConstructL):
7:56 AM Changeset in webkit [20431] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-22 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by ​zbujtas@gmail.com
DESC: [S60] Some images crash when browsing some wap page - TKWG-6Z59YX in 3.1m branch
Fix: Remove extra image content-type strings added by the server before passing it to the image decoder.
​http://bugs.webkit.org/show_bug.cgi?id=13151

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::ConstructL):
4:47 AM Changeset in webkit [23175] by aroben
  • 9 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Implemented dumping of frame scroll positions.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFrameScrollPosition): Ported from Mac. (dump): Added call to dumpFrameScrollPosition. (runTest): Initialize new global.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpChildFrameScrollPositionsCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

Implemented some WebFrame methods to support dumping frame scroll
offsets in DRT.

  • Interfaces/IWebFrame.idl: Changed signature of IWebFrame::childFrames.
  • Interfaces/IWebFramePrivate.idl: Added scrollOffset declaration.
  • WebFrame.cpp: (WebFrame::name): Implemented. (WebFrame::childFrames): Implemented. (WebFrame::scrollOffset): Implemented.
  • WebFrame.h: Updated/added declarations.
4:41 AM Changeset in webkit [20430] by bdash
  • 1 edit in trunk/WebCore/ChangeLog

Add radar reference.

4:37 AM Changeset in webkit [20429] by bdash
  • 3 edits
    4 adds in trunk

2007-03-23 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/lists/marker-image-error.html

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged): Mark ourselves for relayout if the image failed to load, since that means we will use a bullet instead.

2007-03-23 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/lists/marker-image-error-expected.checksum: Added.
  • fast/lists/marker-image-error-expected.png: Added.
  • fast/lists/marker-image-error-expected.txt: Added.
  • fast/lists/marker-image-error.html: Added.
4:23 AM Changeset in webkit [20428] by zack
  • 2 edits in trunk/WebCore

Fix the compile

2:25 AM Changeset in webkit [20427] by bdash
  • 3 edits in trunk/WebKit

2007-03-23 Mark Rowe <​mrowe@apple.com>

Build fix for when BUILDING_ON_TIGER is not defined.

  • Misc/WebTypesInternal.h:
  • WebView/WebHTMLView.mm:
1:32 AM Changeset in webkit [23174] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Oliver.

WebKit part of fix for <rdar://problem/4990740>.

Added IWebDataSourcePrivate::mainDocumentError.

  • Interfaces/IWebDataSource.idl: Added method declaration and updated copyrights.
  • WebDataSource.cpp: (WebDataSource::mainDocumentError): Implemented.
  • WebDataSource.h: Added declaration.
12:29 AM Changeset in webkit [23173] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-23 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


<rdar://problem/5083645> Spoofed UA for gmail doesn't work - should be removed

  • WebView.cpp: (WebView::userAgentForKURL): Remove gmail spoof
12:24 AM Changeset in webkit [20426] by andersca
  • 5 edits in trunk/LayoutTests

Reviewed by Adam.

Make script-add.html more deterministic.


  • fast/dom/resources/script3.js:
  • fast/dom/resources/script4.js:
  • fast/dom/resources/script5.js:
  • fast/dom/script-add.html:

Mar 22, 2007:

11:14 PM Changeset in webkit [23172] by hyatt
  • 3 edits in branches/WindowsMerge/WebKitWin

Fix for print stylesheets not being honored.

11:07 PM Changeset in webkit [20425] by hyatt
  • 4 edits in trunk/WebCore

printing changes

10:59 PM Changeset in webkit [23171] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam Roben.


Fixed <rdar://problem/5082985> Select menus are too see-through

Upped alpha value from 90 to 95. Menus will still seem a little
more see-through than on the mac, since their backgrounds are
white, not grey, but white matches other Windows browsers.


  • ChangeLog:
  • platform/win/PopupMenuWin.cpp:
10:58 PM Changeset in webkit [20424] by bdash
  • 4 edits in tags/Safari-4522.5

Versioning.

10:55 PM Changeset in webkit [20423] by sfalken
  • 1 copy in tags/Safari-522.4.2b

New tag.

10:55 PM Changeset in webkit [20422] by aroben
  • 1 edit
    8 adds in trunk/JavaScriptCore

Reviewed/landed by Adam.

  • Adding mac project files for apollo port of JavaScriptCore. Currently project just builds dftables.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Added.
10:50 PM Changeset in webkit [20421] by bdash
  • 2 edits in tags/Safari-4522.5/WebCore

Merge in r20390.

10:47 PM Changeset in webkit [20420] by bdash
  • 1 copy in tags/Safari-4522.5

New tag.

10:00 PM Changeset in webkit [20419] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Ada.

<rdar://problem/5074974>
CrashTracer: [USER] repro crash in Safari at com.apple.WebCore: WebCore::FrameLoader::activeDocumentLoader const + 6


  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Don't use ResourceResponse:isHTTP here since that only looks at the protocol instead of if the response came from a HTTP server (and not a web archive).
9:41 PM Changeset in webkit [20418] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merged 20416 from TOT

9:07 PM Changeset in webkit [20417] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/graphics/cairo/ImageSourceCairo.cpp:
8:36 PM Changeset in webkit [20416] by hyatt
  • 2 edits in trunk/WebCore

Fix wheeling issue on gamespot.com

8:33 PM Changeset in webkit [20415] by thatcher
  • 1 copy in branches/Safari-522

New branch.

8:33 PM Changeset in webkit [20414] by thatcher
  • 1 delete in branches/Safari-522

Removing this branch.

6:43 PM Changeset in webkit [23170] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

<rdar://problem/5081539>
QT content is dupped on a page, if page is being previewed or printed.


Don't update the frame geometry if the document is in printing mode.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry):
6:26 PM Changeset in webkit [23169] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.

<rdar://problem/5082270>
Crash in windows media player at MTV.COM


Ignore any WM_PAINT events we get while painting.


  • WebView.cpp: (WebView::WebView): (WebView::updateBackingStore): (WebView::paint): (WebViewWndProc):
  • WebView.h: (WebView::isPainting):
5:32 PM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Removed mouseClick() since it's been removed in r20407. (diff)
5:25 PM Changeset in webkit [20413] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by kevin


<rdar://problem/5081257>
REGRESSION: New Mail signatures start out empty


  • editing/selection/5081257-1-expected.checksum: Added.
  • editing/selection/5081257-1-expected.png: Added.
  • editing/selection/5081257-1-expected.txt: Added.
  • editing/selection/5081257-1.html: Added.
  • editing/selection/5081257-2-expected.checksum: Added.
  • editing/selection/5081257-2-expected.png: Added.
  • editing/selection/5081257-2-expected.txt: Added.
  • editing/selection/5081257-2.html: Added.

WebCore:

Reviewed by kevin

<rdar://problem/5081257>
REGRESSION: New Mail signatures start out empty

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Allow descent from positions inside the document into an editable body.
5:16 PM Changeset in webkit [23168] by bdakin
  • 2 edits in branches/WindowsMerge/WebCore

Fix by Hyatt, reviewed and committed by me.

Fix for <rdar://problem/5082360> Incomplete frame paint when
shrinking window @ google.com

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setFrameGeometry): Wrong order!
5:15 PM Changeset in webkit [20412] by ddkilzer
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Darin.

Use BUILDING_ON_TIGER from WebKitPrefix.h instead of local
MAC_OS_X_VERSION_MAX_ALLOWED <= MAC_OS_X_VERSION_10_4 tests.

  • Misc/WebTypesInternal.h:
  • WebView/WebHTMLView.mm:
4:57 PM Changeset in webkit [20411] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adele and John

<rdar://5043528> - Prepare for new API


  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::clearAuthentication): Clear CF type
4:26 PM Changeset in webkit [23167] by aroben
  • 5 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adele.

Implemented layoutTestController.dumpTitleChanges.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize new global.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpTitleChangesCallback): Implemented.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didReceiveTitle): Implemented.
3:14 PM Changeset in webkit [20410] by bdakin
  • 2 edits in trunk/WebCore

Patch by Hyatt, reviewed and committed by me.

Does not reproduce consistently, so a layout test does not seem
possible.

Fix for <rdar://problem/5082421> Constantly hitting ASSERT(!
needsLayout()) in RenderView::paint()

  • page/FrameView.cpp: (WebCore::FrameView::layoutPending): It is not enough to ask if the layout timer is active. There may be times that we don't have a body yet so we cannot schedule layout yet, but the root still needs layout.
3:08 PM Changeset in webkit [20409] by spadma
  • 7 edits in S60/branches/3.1m

2007-03-22 spadma

Reviewed by Zalan.
DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
​http://bugs.webkit.org/show_bug.cgi?id=13162

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::SetPageUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
3:08 PM Changeset in webkit [20408] by spadma
  • 7 edits in S60/trunk

2007-03-22 spadma

Reviewed by Zalan.
DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
​http://bugs.webkit.org/show_bug.cgi?id=13162

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::SetPageUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
2:58 PM Changeset in webkit [23166] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Rubberstamped by Geoff.

Removed eventSender.mouseClick now that it isn't used.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
2:53 PM Changeset in webkit [20407] by aroben
  • 8 edits
    2 deletes in trunk

LayoutTests:

Reviewed by Geoff.

Replaced all calls to eventSender.mouseClick with paired calls to
mouseDown/mouseUp.

  • fast/events/click-count.html:
  • fast/events/event-sender-mouse-click-expected.txt: Removed.
  • fast/events/event-sender-mouse-click.html: Removed.
  • fast/events/frame-click-focus.html:
  • fast/events/objc-event-api.html:
  • fast/forms/focus-selection-input.html:
  • fast/forms/focus-selection-textarea.html:

WebKitTools:

Reviewed by Geoff.

Removed eventSender.mouseClick because it was only useful for AppKit
controls, which we don't use anymore.

  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): Removed mouseClick.
2:52 PM Changeset in webkit [23165] by adele
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Fix for <rdar://problem/5071358> window.open won't work with empty urls (24fun test)

  • Interfaces/IWebURLRequest.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::isEmpty): Added. Checks whether the ResourceRequest is empty. On the mac, NSURLRequests created from empty ResourceRequests are nil. We may want to consider that in the future, but there were too many places in the app that expected the IWebURLRequest to be non-null.
  • WebMutableURLRequest.h:
2:52 PM Changeset in webkit [20406] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-21 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: ASAA-6X5DX8 : NewsTicker SVG icon doesn't display
​http://bugs.webkit.org/show_bug.cgi?id=13144

  • Plugin/src/PluginWin.cpp: (CPluginWin::WriteStreamToFileL):
2:50 PM Changeset in webkit [20405] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-21 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: ASAA-6X5DX8 : NewsTicker SVG icon doesn't display
​http://bugs.webkit.org/show_bug.cgi?id=13144

  • Plugin/src/PluginWin.cpp: (CPluginWin::WriteStreamToFileL):
2:20 PM Changeset in webkit [20404] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


Followup for recent fix to 5079700, found by assertion added to Safari.

  • page/mac/FrameMac.mm: (WebCore::Frame::searchForLabelsBeforeElement): Fixed another place in this method where an empty NSString was being returned instead of nil. Cleaned up the style a little too.
2:03 PM Changeset in webkit [20403] by thatcher
  • 1 edit in tags/JavaScriptCore-5522.4.1/JavaScriptCore/Info.plist

Versioning

2:03 PM Changeset in webkit [20402] by thatcher
  • 2 edits in tags/JavaScriptCore-5522.4.1/JavaScriptCore

Merging fix from r20368.

2:00 PM Changeset in webkit [20401] by thatcher
  • 1 copy in tags/JavaScriptCore-5522.4.1/JavaScriptCore

New tag (part 2.)

2:00 PM Changeset in webkit [20400] by thatcher
  • 1 delete in tags/JavaScriptCore-5522.4.1/JavaScriptCore

Removing bad tag.

1:59 PM Changeset in webkit [20399] by thatcher
  • 1 copy in tags/JavaScriptCore-5522.4.1/JavaScriptCore

New tag (part 2.)

1:58 PM Changeset in webkit [20398] by thatcher
  • 1 add in tags/JavaScriptCore-5522.4.1

New tag (part 1.)

1:56 PM Changeset in webkit [20397] by thatcher
  • 1 move in tags/WebCore-5522.4.1

Move this tag.

1:53 PM Changeset in webkit [20396] by thatcher
  • 1 edit in tags/Safari-5522.4.1/WebCore/Info.plist

Versiong.

1:52 PM Changeset in webkit [20395] by thatcher
  • 5 edits in tags/Safari-5522.4.1/WebCore

Merging fix from r20381.

1:51 PM Changeset in webkit [20394] by thatcher
  • 1 copy in tags/Safari-5522.4.1/WebCore

New tag (part 2.)

1:50 PM Changeset in webkit [20393] by thatcher
  • 1 add in tags/Safari-5522.4.1

New tag (part 1.)

1:45 PM Changeset in webkit [20392] by hyatt
  • 4 edits in trunk/WebCore

Remove unnecessary destroyFrameAtIndex call. Now that we throw away
the image source, it is no longer needed.

Reviewed by beth

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
12:28 PM Changeset in webkit [20391] by brmorris
  • 2 edits in S60/trunk/WebKit

borges, reviewed by bradley

DESC: minor fix to renderer.mmpi for new build system
​http://bugs.webkit.org/show_bug.cgi?id=13027

  • group/renderer.mmpi:
12:09 PM Changeset in webkit [20390] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Geoff, Darin.

<rdar://problem/5077892> In RapidWeaver 3.5.1, a crash occurs when attempting to load Safari Bookmarks in iMedia Browser


  • platform/mac/ThreadCheck.mm: (WebCore::_WebCoreThreadViolationCheck): Change default on Tiger to NSLog rather than raise an exception.
11:22 AM Changeset in webkit [20389] by darin
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • use binary_search instead of hash table; slightly better performance and less memory use
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Use binary_search.
11:17 AM Changeset in webkit [20388] by darin
  • 4 edits in trunk

WebCore:

Reviewed by Adele.

  • fix <rdar://problem/5074630> detachChildren call should move from WebKit to WebCore
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDocumentLoader): Add a call to detachChildren() after the call to prepareForDataSourceReplacement(). There was no reason for this crucial loading step to be left to the client.

WebKit:

Reviewed by Adele.

  • fix <rdar://problem/5074630> detachChildren call should move from WebKit to WebCore
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::prepareForDataSourceReplacement): Remove call to detachChildren. This should be a WebCore responsibility.
3:55 AM Changeset in webkit [23164] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix crasher in RenderTableSection::paint

3:55 AM Changeset in webkit [23163] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Fix crasher in RenderTableSection::paint

3:55 AM Changeset in webkit [23162] by hyatt
  • 4 edits in branches/WindowsMerge/WebKitWin

Fix crasher in RenderTableSection::paint

3:47 AM Changeset in webkit [20387] by hyatt
  • 1 edit in trunk/WebCore/platform/ScrollView.h


2:21 AM Changeset in webkit [20386] by aroben
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Ada.

Added a new test to make sure that eventSender.mouseClick works
correctly.

  • fast/events/click-count-expected.txt: Added.
  • fast/events/click-count.html: Added.

Updated results for some tests that depended on the broken version of
eventSender.mouseClick.

  • fast/events/objc-event-api-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:

WebKitTools:

Reviewed by Ada.

Make eventSender.mouseClick actually send a mouse up event.

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseClick]):
2:13 AM Changeset in webkit [20385] by hyatt
  • 5 edits in trunk/WebCore

Minor refactoring and cleanup of the bridge calls that want to control layout settings on the RenderView.
Have the bridge talk through the FrameView instead of just asking for the RenderView directly.

Add an assert to help catch situations where the RenderView needs layout at paint time, since this is a known
catastrophic scenario that will (much of the time) result in a crash in RenderTableSection::paint.

Reviewed by aroben

  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::needsLayout): (WebCore::FrameView::setNeedsLayout):
  • page/FrameView.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge needsLayout]): (-[WebCoreFrameBridge setNeedsLayout]):
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
1:51 AM Changeset in webkit [23161] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-22 Ada Chan <​adachan@apple.com>

WebKitWin:

Reviewed by Hyatt and Alice.


Changed the mouse event processing in the WebView wndproc so we actually
allow a mouse event with click count > 3, which matches the mac safari behavior.


Set globalPrevButton and globalPrevPoint also in mouse down.

  • WebView.cpp: (WebView::handleMouseEvent):
12:04 AM Changeset in webkit [23160] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix wheel events.

Mar 21, 2007:

10:55 PM Changeset in webkit [20384] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin.


Re-worked the fix in r20375. 'M' and 'm' are not the only commands that
accept "extra" coordinates -- virtually all commands accept them.

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
10:54 PM Changeset in webkit [20383] by ddkilzer
  • 2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by NOBODY (more word tweaking).

  • building/checkout.html: By popular demand, the link to the svn 1.3 client has been removed.
10:48 PM Changeset in webkit [20382] by ddkilzer
  • 2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by NOBODY (tweaked wording).

  • building/checkout.html: Got rid of "click here" link and restructured sentences linking to svn clients.
10:17 PM Changeset in webkit [23159] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Hyatt.

Force SVG tests to paint to match the Mac results.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Force a paint if we're running an SVG test.
9:31 PM Changeset in webkit [20381] by harrison
  • 5 edits in trunk/WebCore

Reviewed by hyatt.

<rdar://problem/5072460> CrashTracer: [USER] 1 crashes in Xcode at com.apple.ImageIO.framework: getBandProcPNG + 168

An NSData object was being alloc/init'd, then returned callers who cast the pointer as a
CFDataRef, including calling CFRelease on it. The problem is that under garbage collection, the NS
retain count is ignored (it's always 0), but the CFRetain and CFRelease are not ignored. This
caused the object to be over-released. The solution that works in both GC and non-GC is to "transfer"
the initial NS retain count to the CF retain count, using HardRetainWithNSRelease.


The creator of the NSData was SharedBuffer::createNSData. The callers were PDFDocumentImage::dataChanged()
and ImageSource::setData(). This particular crash involved the ImageSource::setData() case.

  • platform/SharedBuffer.h: Declare createCFData().


  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData): Call createCFData instead of createNSData.


  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): Call createCFData instead of createNSData.


  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createCFData): Implement createCFData(). Use HardRetainWithNSRelease for gc safety.
9:16 PM Changeset in webkit [20380] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin. Patch by Mitz.

  • fast/dynamic/view-overflow-expected.checksum: Added.
  • fast/dynamic/view-overflow-expected.png: Added.
  • fast/dynamic/view-overflow-expected.txt: Added.
  • fast/dynamic/view-overflow.html: Added.

WebCore:

Reviewed by Darin. Patch by Mitz.

Test: fast/dynamic/view-overflow.html

  • rendering/RenderView.cpp: (WebCore::RenderView::layout): Reset overflowHeight() and overflowWidth() before calling docHeight() and docWidth(), since the former act as a lower bound for the latter.
9:11 PM Changeset in webkit [20379] by ddkilzer
  • 2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by Adam.

  • building/checkout.html: Add link to svn 1.4 client for Mac OS X 10.4.
9:09 PM Changeset in webkit [20378] by ggaren
  • 2 edits in trunk/LayoutTests

Fixed bad version of results that I check in accidentally.

  • svg/dom/string-list-parser-expected.txt:
9:05 PM Changeset in webkit [20377] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Beth Dakin.


A little cleanup based work I've been doing on the SVG parsers.

  • ksvg2/svg/SVGParserUtilities.h: (WebCore::skipString):
  • ksvg2/svg/SVGPreserveAspectRatio.cpp: Moved checkString into SVGParserUtilities.h, so it could be with all its friends. Renamed "checkString" to "skipString" to match the rest of the code and to be clear about which functions move the buffer pointer. (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute): Changed gotos into returns. Removed unnecessary magic number.
8:50 PM Changeset in webkit [20376] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Added fuzz tester for the SVG rgb color parser.

  • svg/dom/rgb-color-parser-expected.txt: Added.
  • svg/dom/rgb-color-parser.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed <rdar://problem/5078471> SVG rgb color parser runs past end of
buffer when running fuzzing test

  • ksvg2/svg/SVGColor.cpp: (WebCore::parseNumberOrPercent): Check for past the end condition. (WebCore::SVGColor::colorFromRGBColorString): Reversed "read past end of buffer, then check if you're past the end" logic.
8:37 PM Changeset in webkit [20375] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Added fuzz tester for the path parser.

  • svg/dom/path-parser-expected.txt: Added.
  • svg/dom/path-parser.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed <rdar://problem/5079410> SVG path parser hangs, exhausts memory when
running fuzzer test

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): Don't assume that extra digits are always preceded by an 'M' or an 'm'.
8:28 PM Changeset in webkit [20374] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.


Added fuzz tester for the string list parser.

  • svg/dom/string-list-parser-expected.txt: Added.
  • svg/dom/string-list-parser.html: Added.
8:26 PM Changeset in webkit [20373] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.


Added fuzz tester for the length list parser.

  • svg/dom/length-list-parser-expected.txt: Added.
  • svg/dom/length-list-parser.html: Added.
8:21 PM Changeset in webkit [20372] by ggaren
  • 2 edits
    2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.


Factored randomizing functions into their own file, in preparation for future
tests that rely on them.


  • svg/dom/resources/scripted-random.js: Added.
  • svg/dom/transform-parser.html: Factored out scripted-random.js, added a small string that increases the normal-seemingness of the last test.
8:12 PM Changeset in webkit [20371] by thatcher
  • 4 edits in trunk/LayoutTests

New results after rolling out r19828 in r20352.

  • fast/overflow/scrollRevealButton-expected.checksum:
  • fast/overflow/scrollRevealButton-expected.png:
  • fast/overflow/scrollRevealButton-expected.txt:
6:42 PM Changeset in webkit [20370] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Adam


  • fixed <rdar://problem/5079700> REGRESSION (r19702): Name/password aren't autofilled or saved for .Mac homepage login
  • page/mac/FrameMac.mm: (WebCore::Frame::searchForLabelsBeforeElement): don't count empty strings as valid results
6:21 PM Changeset in webkit [23158] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Oliver.

  • Skipped: Added an SVG test that causes a debug ASSERT in the C Runtime.
6:15 PM Changeset in webkit [23157] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by Oliver.

Make W3C SVG tests render at the correct dimensions.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Resize the WebView if we're running a W3C SVG test. (runTest): Save the current test filename.
5:48 PM Changeset in webkit [20369] by justing
  • 4 edits in trunk

Reviewed by darin

  • editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Release the RefPtr to avoid increasing/decreasing the refcount unnecessarily. (WebCore::propertyMissingOrEqualToNone): Added and used instead of converting values to strings. (WebCore::elementHasTextDecorationProperty): (WebCore::createMarkup):
5:31 PM Changeset in webkit [20368] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/5076599> JavaScriptCore has a weak export (vtable for KJS::JSCell)

5:07 PM Changeset in webkit [23156] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • WebView.cpp: (WebView::initWithFrame): Remove #ifdef now that DRT no longer crashes.
4:59 PM Changeset in webkit [20367] by mjs
  • 1 edit
    6 adds in trunk/WebKitSite
  • some specs to propose by email
  • specs/HTML_Timed_Media_Elements.html: Added.
  • specs/Timed_Media_CSS.html: Added.
  • specs/Timed_Media_Elements-Open_Issues.html: Added.
  • specs/mediaelement.css: Added.
  • specs/movie-status-states.png: Added.
4:58 PM Changeset in webkit [20366] by justing
  • 3 edits
    12 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5075944>
REGRESSION: Partially selected underlined content pastes as plain text

Tests for the bug:

  • editing/pasteboard/5075944-expected.checksum: Added.
  • editing/pasteboard/5075944-expected.png: Added.
  • editing/pasteboard/5075944-expected.txt: Added.
  • editing/pasteboard/5075944.html: Added. Tests that the element that has the text-decoration and all its descendants down to the common ancestor are included in the copied markup (instead of the text-decoration property being treated as though it were inheritable and placed on the style span wrapper):
  • editing/pasteboard/5075944-2-expected.checksum: Added.
  • editing/pasteboard/5075944-2-expected.png: Added.
  • editing/pasteboard/5075944-2-expected.txt: Added.
  • editing/pasteboard/5075944-2.html: Added. Tests that moveParagraphs gets underlining right (it doesn't use annotation):
  • editing/pasteboard/5075944-3-expected.checksum: Added.
  • editing/pasteboard/5075944-3-expected.png: Added.
  • editing/pasteboard/5075944-3-expected.txt: Added.
  • editing/pasteboard/5075944-3.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5075944>
REGRESSION: Partially selected underlined content pastes as plain text


We stopped adding markup for all the ancestors
of lastClosed up to the commonAncestorBlock
because it was adding a lot of unnecessary markup.
This caused us to lose underlining when copying a
partially selected underlined element (even though
we put all styles that the copied markup inherits
into a style span, because the text-decoration
isn't inheritable).

  • editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Moved code here. (WebCore::elementHasTextDecorationProperty): Added. (WebCore::createMarkup): If the copied markup has a text-decoration because some common ancestor has a text-decoration property set, include that ancestor and all its descendants in the copied markup.
4:40 PM Changeset in webkit [23155] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Fix broken changelog.

4:37 PM Changeset in webkit [23154] by hyatt
  • 3 edits in branches/WindowsMerge/WebCore

Advanced text improvements.

4:28 PM Changeset in webkit [20365] by thatcher
  • 1 copy in branches/Safari-522

New branch.

2:59 PM Changeset in webkit [20364] by oliver
  • 5 edits
    2 adds in trunk

2007-03-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Antti.

WebCore:

Update a few SVG attribute parsers to be more defensive against
reading beyond the end of input.

Fixes rdar://problem/5077218 -- SVG transform parser runs past
end of buffer when running fuzzing test

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
  • ksvg2/svg/SVGParserUtilities.h: (WebCore::skipOptionalSpacesOrDelimiter):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::parseTransformParamList): (WebCore::SVGTransformable::parseTransformAttribute):

LayoutTests:

Fuzz test for SVG transform parser

  • svg/dom/transform-parser-expected.txt: Added.
  • svg/dom/transform-parser.html: Added.
2:34 PM Changeset in webkit [23153] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/5074274> right-clicking in certain iframes ends up
left-clicking, and context menu appears far away

  • WebView.cpp: (WebView::handleContextMenuEvent): We were always calling sendContextMenuEvent() on the main frame!! Instead, call it on the focused or main frame.
2:22 PM Changeset in webkit [23152] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

LayoutTestsWin:

Reviewed by David Kilzer (yay!).

Re-enable the editing tests, except for two crashers.

  • Skipped:
12:06 PM Changeset in webkit [20363] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=13140
Crash after loading SVG fragment with XMLHttpRequest (Yosemite Map Geology Layer)

Test: svg/carto.net/frameless-svg-parse-error.html

  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportError): Added a null check. (WebCore::SVGDocumentExtensions::reportWarning): Ditto.
11:03 AM Changeset in webkit [23151] by adele
  • 7 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Adam.


Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails


Call updateActiveState on the WebView in didCommitLoadForFrame. This is required so that nodes can be properly focused in the document.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didCommitLoadForFrame):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:

WebKitWin:

Reviewed by Adam.


Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails


Added updateActiveState SPI for DumpRenderTree.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebViewWndProc): Added comments where we do similar work when the webview gets and loses focus. We should merge this logic into updateActiveState eventually. (WebView::updateActiveState):
  • WebView.h:
10:55 AM Changeset in webkit [20362] by adele
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • API/JSStringRef.cpp: (JSStringIsEqual): Added JSLock.
2:30 AM Changeset in webkit [20361] by zack
  • 2 edits in trunk/JavaScriptCore

Fix the compile when USE(MULTIPLE_THREADS) isn't defined

12:24 AM Changeset in webkit [20360] by bdakin
  • 5 edits in trunk/WebCore

Fix for <rdar://problem/5072678> Crash in
RenderLayer::scrollRectToVisible with MallocScribble enabled

I tried to fix this earlier today but my fix caused a regression
scrolling through RSS pages. It turns out that sometimes scroll
events need to propagate immediately, and sometimes they must be
delayed or they risk deleting objects that are expected to be
around after the event has propagated. Mitz's original fix made
sheduleEvent() only delay events that happen during layout. This
fix marks two other places in addition to layout where events also
need to be delayed. These two places are places that were marked
with FIXMEs that Mitz removed in his original patch. (There was a
third FIXME in RenderLayer::updateScrollInfoAfterLayout() but that
case is only called through layout and is covered by Mitz's
original patch.)

  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): Added assertion. (WebCore::FrameView::layout): Call new functions to increment and decrement the queued events count. (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): Decrement queued events count and dispatch events if the count has zeroed.
  • page/FrameView.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::Marquee::start):
12:21 AM Changeset in webkit [20359] by bdash
  • 2 edits in trunk/WebCore

2007-03-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by John Sullivan.

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): Reordered the code to allow resizing to be terminated by a mouseup event regardless of whether the frameset needs layout.

Mar 20, 2007:

10:46 PM Changeset in webkit [20358] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5077252>
In NetNewsWire 2.1.1 and 3.0d62, a crash occurs after triple-clicking a link on the page


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Move the m_inStopAllLoaders check to the load function that's common for loading a request or substitute data.
10:39 PM Changeset in webkit [20357] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Anders

<rdar://problem/5073391> and ​http://bugs.webkit.org/show_bug.cgi?id=13137

Crash in IconDatabase when private browsing is enabled.

The problem was caused by ​http://trac.webkit.org/projects/webkit/changeset/20182
which changed many uses of char[] and Vector<char> to SharedBuffer. The patch
tended to literally replace a Vector<char> with RefPtr<SharedBuffers> but forgot
to enforce the concept that Vector<char>'s always exist, whereas RefPtr<SharedBuffers>
can be null. This led to derefs.

I took the opportunity to rework the iconDB functions to live in a SharedBuffer
world, as that didn't exist when they were originally written - now they just return
SharedBuffers instead of taking a Vector<char>& as a parameter

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::imageDataForIconURL): Return a SharedBuffer (WebCore::IconDatabase::iconForPageURL): Null check the SharedBuffer before asking it if it's empty (WebCore::IconDatabase::imageDataForIconURLQuery): Return a new SharedBuffer
  • loader/icon/IconDatabase.h: Return SharedBuffer's instead of taking Vector<char>&'s
9:25 PM Changeset in webkit [23150] by aroben
  • 5 edits in branches/WindowsMerge/WebKitTools

Reviewed by Brady.

Always use CCom* smart pointers when possible to avoid memory management issues.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Changed _T() to TEXT(). (dump): (runTest): (initializePreferences): (main):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: (dumpPath): (dump): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (mouseDownCallback): (doMouseUp): (mouseClickCallback): (doMouseMove): (keyDownCallback):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (setAcceptsEditingCallback): (setTabKeyCyclesThroughElementsCallback):
8:53 PM Changeset in webkit [23149] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

8:49 PM Changeset in webkit [20356] by sfalken
  • 1 copy in tags/Safari-522.4.1b

New tag.

6:50 PM Changeset in webkit [23148] by mjs
  • 1 edit in branches/WindowsMerge/WebKitTools/ChangeLog

Removed conflict markers.

6:47 PM Changeset in webkit [23147] by mjs
  • 4 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Geoff and Adam.


  • fixed some bugs in --threaded fond in the course of testing.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runJavaScriptThread): Be smarter about thread dictionary. (startJavaScriptThreads): Ditto. (stopJavaScriptThreads): Ditto. (main): Account for --threaded command-line argument better.

WebKitWin:

Reviewed by Geoff and Adam.

  • <rdar://problem/4041141> JavaScriptCore is not thread-safe on Windows
  • WebView.cpp: (WebView::WebView): Tell JavaScriptCore what the main thread is.
6:29 PM Changeset in webkit [23146] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Adele.

Roll out r12355 now that OpenSource r20348 has been rolled out.

  • Skipped: Also removed a crash that was caused by 20348.
6:24 PM Changeset in webkit [20355] by aroben
  • 2 edits in trunk/WebCore

Rubberstamped by Adele.

Roll out r20348 because it was causing crashes.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent):
5:54 PM Changeset in webkit [23145] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Hyatt.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Install Helevetica Neue.
5:46 PM Changeset in webkit [20354] by bdash
  • 2 edits in trunk/WebKitSite

2007-03-20 Matt Lilek <​pewtermoose@gmail.com>

Reviewed by Darin.

Clear up the steps necessary to get a patch landed.

​http://bugs.webkit.org/show_bug.cgi?id=12877 - Bug 12877: "Contributing Code" page could be clearer
​http://bugs.webkit.org/show_bug.cgi?id=8690 - Bug 8690: Contributing code doesn't mention what to do with new files

  • coding/contributing.html:
5:13 PM Changeset in webkit [23144] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Beth.

  • Skipped: Added the real crasher (arrow-navigation.html just fails, doesn't crash).
5:11 PM Changeset in webkit [20353] by thatcher
  • 1 edit in trunk/JavaScriptCore/kjs/collector.cpp

Build fix.

4:57 PM Changeset in webkit [20352] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Kevin Decker.

Rolling out part of r19828 that caused a scrolling regression in Mail.

<rdar://problem/4820817> Message jumps around when trying to select text

  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::updateContents):
4:57 PM Changeset in webkit [20351] by mjs
  • 10 edits in trunk/JavaScriptCore

Reviewed by Geoff and Adam.



  • fixed a threadsafety bug discovered by testing this


  • enhanced threadsafety assertions in collector
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::~JSCallbackObject): This destructor can't DropAllLocks around the finalize callback, because it gets called from garbage collection and we can't let other threads collect!
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/JSLock.cpp: (KJS::JSLock::currentThreadIsHoldingLock): Added new function to allow stronger assertions than just that the lock is held by some thread (you can now assert that the current thread is holding it, given the new JSLock design).
  • kjs/JSLock.h:
  • kjs/collector.cpp: Refactored for portability plus added some stronger assertions. (KJS::Collector::allocate): (KJS::currentThreadStackBase): (KJS::Collector::registerAsMainThread): (KJS::onMainThread): (KJS::PlatformThread::PlatformThread): (KJS::getCurrentPlatformThread): (KJS::Collector::Thread::Thread): (KJS::destroyRegisteredThread): (KJS::Collector::registerThread): (KJS::Collector::markCurrentThreadConservatively): (KJS::suspendThread): (KJS::resumeThread): (KJS::getPlatformThreadRegisters): (KJS::otherThreadStackPointer): (KJS::otherThreadStackBase): (KJS::Collector::markOtherThreadConservatively): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collectOnMainThreadOnly): (KJS::Collector::markMainThreadOnlyObjects): (KJS::Collector::collect):
  • kjs/collector.h:
  • wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded):
  • wtf/FastMallocInternal.h:
  • wtf/Platform.h:
4:25 PM Changeset in webkit [23143] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Release build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed bogus extra linker options.
4:24 PM Changeset in webkit [20350] by beidson
  • 2 edits in trunk/WebCore

Reviewed by John

<rdar://5071341> - Crash in IconLoader::finishLoading()


Though the reproducibility of the crash is still elusive, there's been a crasher likely uncovered
Hyatt's recent caching changings to the IconLoader. This crash tends to hit on sites without favicons,
that serve up complex 404 pages, often when the load is cancelled or redirected. Occasionally, it *seems*
the IconLoader is getting failed/cancelled twice.


This patch adds some assertions and a "fail gracefully in a release build" check that will have to
serve us until we know more about the cause.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFail): Add an assertion to catch this case (WebCore::IconLoader::finishLoading): Add an assertion to catch the case, and fail gracefully in debug builds. Also add an efficiency check to not commit to the DB if there is no IconURL
4:15 PM Changeset in webkit [23142] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Beth.

  • Skipped: Added another crasher.
3:06 PM Changeset in webkit [23141] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Adele.

Added some tests that fail due to font metric differences.

  • Skipped:
3:01 PM Changeset in webkit [20349] by antti
  • 8 edits in trunk/WebCore

Reviewed by Darin.


Eat smooth scroll events in WebCore if pointer is over scrollable area. Not
really a good fix, smooth scrolling should be supported properly. It should do for now.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isScrollable):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::isScrollable):
  • rendering/RenderObject.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::isScrollable):
  • rendering/RenderTextControl.h:
2:02 PM Changeset in webkit [23140] by adele
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adam.

Explicitly pass VK_RETURN when using keyDown for "\n".


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback):
1:47 PM Changeset in webkit [23139] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Release build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Set libpath.
1:29 PM Changeset in webkit [23138] by bdakin
  • 2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Adam.

Re-enabling fast/layers/removed-by-scroll-handler.html because
5072678 is fixed.

1:13 PM Changeset in webkit [20348] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Covered by existing test case.

Fix for <rdar://problem/5072678> Crash in
RenderLayer::scrollRectToVisible with MallocScribble enabled

This removes some code that was added with ​http://bugs.webkit.org/
show_bug.cgi?id=8360. This code was not needed to fix that bug, but
the idea behind it was that there are times when it is safe for
scheduleEvent() to propagate the event immediately. The
MallocScribble crash revealed that this assumption was a bit too
broad; the cause of the crash was that we were propagating events
immediately when it was not safe. Mitz and I discussed this online
and we agree that the safest solution is to revert to the old
behavior here, and always delay the propagation of the event.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent):
12:56 PM Changeset in webkit [20347] by beidson
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan

Add some very helpful logging to the IconLoader's SubresourceLoaderClient impl.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFail): (WebCore::IconLoader::didFinishLoading):
12:09 PM Changeset in webkit [20346] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5071074>
REGRESSION: Links are pasted as plain text at certain positions

  • editing/pasteboard/5071074-2-expected.checksum: Added.
  • editing/pasteboard/5071074-2-expected.png: Added.
  • editing/pasteboard/5071074-2-expected.txt: Added.
  • editing/pasteboard/5071074-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links are pasted as plain text at certain positions


moveParagraphs calls createMarkup without annotation, which leaves
out anchor elements that aren't fully selected.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): We don't want createMarkup to do full annotation here. Doing so could include special ancestor blocks, which would prevent the copied content from appearing in the destination paragraph when it's re-inserted. Annotation would also inline styles from style sheets, which is unnecessary because the content is being moved to the same document it's being moved from. Added a new bool to createMarkup that when true allows markup for special ancestors as long as they are inline when annotation is off.
  • editing/markup.cpp: (WebCore::createMarkup): Don't set specialCommonAncestor if annotation is off, unless it's inline and we've been told it's ok to include such elements.
  • editing/markup.h:
11:48 AM Changeset in webkit [23137] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

Added null-checks for ResourceHandle::cookieStorage() before passing it
into CFNetwork functions, which are not null-safe.

  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies):
11:20 AM Changeset in webkit [23136] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added XPathNodeSet.(cpp|h).
10:21 AM Changeset in webkit [20345] by ap
  • 30 edits
    5 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12497
Implement XPath result ordering.

WebCore:

XPath::NodeVector typedef is replaced with a real XPath::NodeSet class that knows how
to sort itself, and can remember whether it has been already sorted.

  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Added XPathNodeSet files.
  • xml/XPathExpression.cpp: Fixed includes.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate): Mark the resulting node-set as unsorted. (WebCore::XPath::FunLocalName::evaluate): Replacing NodeVector with NodeSet. (WebCore::XPath::FunNamespaceURI::evaluate): Ditto. (WebCore::XPath::FunName::evaluate): Ditto. (WebCore::XPath::FunCount::evaluate): Ditto. (WebCore::XPath::FunSum::evaluate): Ditto.
  • xml/XPathNodeSet.cpp: Added. (WebCore::XPath::parentWithDepth): (WebCore::XPath::sortBlock): (WebCore::XPath::NodeSet::sort): Sort the node-set in document order. (WebCore::XPath::NodeSet::reverse): Reverse the order (useful for making axes such as parent or ancestor sorted). (WebCore::XPath::NodeSet::firstNode): Returns the first node in document order; currently implemented via fully sorting the node-set, but this can obviously be optimized. (WebCore::XPath::NodeSet::anyNode): Added for symmetry with firstNode().


  • xml/XPathNodeSet.h: Added. (WebCore::XPath::NodeSet::NodeSet): (WebCore::XPath::NodeSet::operator=): (WebCore::XPath::NodeSet::size): (WebCore::XPath::NodeSet::isEmpty): (WebCore::XPath::NodeSet::operator[]): (WebCore::XPath::NodeSet::reserveCapacity): (WebCore::XPath::NodeSet::clear): (WebCore::XPath::NodeSet::swap): (WebCore::XPath::NodeSet::append): (WebCore::XPath::NodeSet::markSorted): (WebCore::XPath::NodeSet::isSorted): Most of these methods just call Vector counterparts.
  • xml/XPathParser.cpp: Updated the copyright notice.
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Replacing NodeVector with NodeSet. (WebCore::XPath::Path::evaluate): Ditto. (WebCore::XPath::LocationPath::evaluate): Replacing NodeVector with NodeSet. This function always marks the result as unsorted, because it is hard to tell whether a step breaks node order. Identifying and implementing special cases when it is not necessary to do so is an important future optimization.
  • xml/XPathPath.h: Replacing NodeVector with NodeSet.
  • xml/XPathPredicate.cpp: (WebCore::XPath::EqTestOp::compare): Replacing NodeVector with NodeSet. (WebCore::XPath::Union::evaluate): Replacing NodeVector with NodeSet. Currently, Union just marks the result as unordered; we can consider using merge sort to avoid this.
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult): Replacing NodeVector with NodeSet. (WebCore::XPathResult::singleNodeValue): Ditto. (WebCore::XPathResult::snapshotLength): Ditto. (WebCore::XPathResult::iterateNext): Ditto. (WebCore::XPathResult::snapshotItem): Ditto. (WebCore::XPathResult::convertTo): Ditto. Sort the result when requested to.
  • xml/XPathResult.h: Replacing NodeVector with NodeSet.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): If the input is not sorted, mark the output as such, too. (WebCore::XPath::Step::nodesInAxis): Fixed a number of bugs when enumerating with an attribute context node. (WebCore::XPath::Step::nodeTestMatches): Replacing NodeVector with NodeSet.
  • xml/XPathStep.h: Ditto.
  • xml/XPathUtil.cpp: (WebCore::XPath::isValidContextNode): XPath data model doesn't put attribute data into child nodes, so passing such node as a context could cause problems.
  • xml/XPathUtil.h: Removed NodeVector typedef.
  • xml/XPathValue.cpp: (WebCore::XPath::Value::Value): (WebCore::XPath::Value::toNodeSet): (WebCore::XPath::Value::toBoolean): (WebCore::XPath::Value::toNumber): (WebCore::XPath::Value::toString):
  • xml/XPathValue.h: (WebCore::XPath::Value::): (WebCore::XPath::Value::isNodeSet): Replacing NodeVector with NodeSet.

LayoutTests:

  • fast/xpath/document-order-expected.txt: Added.
  • fast/xpath/document-order.html: Added.
  • fast/xpath/text-nodes-expected.txt:
  • fast/xpath/text-nodes.html:
  • fast/xpath/4XPath/Core/test_step-expected.txt: Updated results for tests that now pass.
  • fast/xpath/xpath-test-pre.js: Added.
  • fast/xpath/4XPath/Core/test.js: Moved checkSnapshot() to a separate file.
  • fast/xpath/4XPath/Core/test_core_functions.html:
  • fast/xpath/4XPath/Core/test_location_path.html:
  • fast/xpath/4XPath/Core/test_nodeset_expr.html:
  • fast/xpath/4XPath/Core/test_parser.html:
  • fast/xpath/4XPath/Core/test_predicate_list.html:
  • fast/xpath/4XPath/Core/test_step.html: Load xpath-test-pre.js for checkSnapshot().
9:44 AM Open Source Contributors created by ddkilzer@webkit.org
Initial page with fake contributor.
9:37 AM WikiStart edited by ddkilzer@webkit.org
Added link to page for open source contributors. (diff)
8:18 AM Changeset in webkit [20344] by bdash
  • 2 edits in trunk/WebCore

2007-03-21 Mark Rowe <​mrowe@apple.com>

Build fix.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject methodForSelector:]): (-[WebScriptObject respondsToSelector:]):
8:11 AM Changeset in webkit [20343] by bdash
  • 3 edits in trunk/WebCore

2007-03-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13129.
Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup.

Some cross-language scripting bridges use the presence of -(int)count to determine
whether to treat objects as sequence-like. All WebScriptObject's exposed this method
which lead to non-collection WebScriptObject's being mishandled by PyObjC. We now
expose -count only when the object we wrap looks like a collection from a JavaScript
point of view (eg, it has a length property).

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject _shouldRespondToCount]): (-[WebScriptObject methodForSelector:]): (-[WebScriptObject respondsToSelector:]): (-[WebScriptObject _count]):
  • bindings/objc/WebScriptObjectPrivate.h:
7:51 AM Changeset in webkit [20342] by darin
  • 2 edits in trunk/WebCore
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Fix obvious typo in the change from last night -- forgot to assign to the variable.
4:51 AM Changeset in webkit [23135] by andersca
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

<rdar://problem/5050512>
Need invalid/expired certificate alerts


Add setAllowsAnyHTTPSCertificate method to IWebMutableURLRequest and have it
call down to WebCore.


  • Interfaces/IWebMutableURLRequest.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
  • WebMutableURLRequest.h:
4:24 AM Changeset in webkit [23134] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Made the metrics of styled selects match those on the Mac to get
fast/forms/001.html passing.

4:22 AM Changeset in webkit [23133] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Anders.

Workaround a CFNetwork crash that affects DRT.

  • WebView.cpp: (WebView::initWithFrame): Commented out cookie storage initialization.
3:27 AM Changeset in webkit [23132] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebView.cpp: Added missing #include.
3:18 AM Changeset in webkit [23131] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Fix typo.
3:14 AM Changeset in webkit [23130] by aroben
  • 8 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Implemented layoutTestController.setTabKeyCyclesThroughElements() to
fix fast/events/keypress-insert-tab.html.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback): Removed unnecessary string comparison.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (setTabKeyCyclesThroughElementsCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

Implemented [set]TabKeyCyclesThroughElements.

  • Interfaces/IWebViewPrivate.idl: Added new declarations.
  • WebView.cpp: (WebView::setTabKeyCyclesThroughElements): Implemented. (WebView::tabKeyCyclesThroughElements): Implemented.
  • WebView.h: Updated.
2:45 AM Changeset in webkit [23129] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Oliver.

Implemented layoutTestController.clearBackForwardList() to fix
fast/dom/location-hash.html.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (clearBackForwardListCallback): Implemented.
2:13 AM Changeset in webkit [23128] by hyatt
  • 5 edits
    2 adds in branches/WindowsMerge/WebCore

Land advanced text ( turned off )

2:12 AM Changeset in webkit [23127] by hyatt
  • 2 edits in branches/WindowsMerge/WebKitWin

Land advanced text ( turned off )

2:11 AM Changeset in webkit [23126] by andersca
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4921198>
Cookie acceptance policy not settable

  • platform/network/cf/ResourceHandleCFNet.cpp:


(WebCore::willSendRequest):
(WebCore::willCacheResponse):
Remove FIXMEs.


(WebCore::makeFinalRequest):
New function that makes a final CFURLRequest depending on cookie policy and whether any
invalid SSL certificates should be ignored.


(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
Use makeFinalRequest.


(WebCore::ResourceHandle::cookieStorageAcceptPolicy):
(WebCore::ResourceHandle::setCookieStorageAcceptPolicy):
(WebCore::ResourceHandle::cookieStorage):
(WebCore::ResourceHandle::setCookieStorage):
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
New functions for setting cookie policy, the deafult cookie storage and whether invalid
SSL certificates should result in an error.


  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Set cookie storage, cookie policy and SSL properties.
  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): Use same functions as the mac (sorta).


(WebCore::cookiesEnabled):
Implement this.

WebKitWin:

Reviewed by Adam.

<rdar://problem/4921198>
Cookie acceptance policy not settable


  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): Update the cookie storage accept policy.


(WebView::initWithFrame):
Initialize the cookie storage.

2:11 AM Changeset in webkit [20341] by hyatt
  • 5 edits in trunk/WebCore

Refactor fonts a bit for portability.

2:06 AM Changeset in webkit [23125] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Oliver.

Remove Arial fonts because of <rdar://problem/5074441>.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Don't install Arial.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Bold Italic.ttf: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Bold.ttf: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Italic.ttf: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial.ttf: Removed.
2:04 AM Changeset in webkit [20340] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Stub out a couple of CFNetwork backend functions.


  • platform/network/ResourceHandle.h:
1:19 AM Changeset in webkit [23124] by oliver
  • 2 edits in branches/WindowsMerge/LayoutTests

2007-03-20 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.


Removing mouseover-mouseout2.html from skip list

  • Skipped:
1:10 AM Changeset in webkit [20339] by oliver
  • 2 edits in trunk/WebCore

2007-03-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada.

Protect against possibility of JS detaching a frame (and losing its view)
midway through a mouse move.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):


12:39 AM Changeset in webkit [23123] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Ada.

  • Skipped: Added more international text tests, plus those that use textInputController.

Mar 19, 2007:

11:56 PM Changeset in webkit [23122] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Ada.

  • Skipped: Added tests that relay on DRT's built-in plugin, or on the QuickTime WebKit plugin.
10:58 PM Changeset in webkit [20338] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13107
XPath should raise an exception when trying to parse an unknown function

Test: fast/xpath/invalid-functions.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::createFunction): Return 0 if the function couldn't be created.
  • xml/XPathGrammar.y: Handle nulls returned from createFunction().
10:47 PM Changeset in webkit [23121] by aroben
  • 4 edits in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Ada.

  • Skipped: Added some more international text tests.

WebKitToolsWin:

Reviewed by Ada.

Made DRT output UTF8 strings.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Convert to UTF8 before printing.
9:01 PM Changeset in webkit [23120] by aroben
  • 3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Geoff.

Added support for --threaded.

Note that this always crashes right now due to
<rdar://problem/5051141> JavaScriptCore is not thread-safe,
but that's why we need this feature!

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Changed NULL to 0. (runTest): Ditto. (pthread_equal): Added. (javaScriptThreads): Ported from Mac. (runJavaScriptThread): Ditto. (startJavaScriptThreads): Ditto. (stopJavaScriptThreads): Ditto. (main): Parse --threaded argument and start/stop threads if needed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Link against pthreadVC2.lib, and added include/pthreads to the include path.
7:45 PM Changeset in webkit [20337] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Dave Hyatt.

<rdar://problem/5067983>
iSale: Crash occurs at WebFrameLoaderClient::dispatchDecidePolicyForMIMEType() when attempting to load a HTML template


Restore old behavior (broke in r14533) where the resource load and download delegates are retained for as long as the
data source is loading.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader):
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::setDataSource): (WebDocumentLoaderMac::decreaseLoadCount):
6:05 PM Changeset in webkit [20336] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/value.h: Roll ~JSValue change out. It was causing problems. I'll do it right later.
5:50 PM Changeset in webkit [20335] by ggaren
  • 2 edits in trunk/WebKit

Speculative fix for why ASSERT_MAIN_THREAD didn't work for me. (The
documentation says "non-zero," not "1."

  • Misc/WebKitLogging.m: (WebKitRunningOnMainThread):
5:46 PM Changeset in webkit [20334] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

Fixed <rdar://problem/5073380> REGRESSION: Crash occurs at WTF::fastFree()
when reloading liveconnect page (applet)


Best to use free when you use malloc, especially when malloc and delete
use completely different libraries.

  • bindings/jni/jni_runtime.cpp: (JavaMethod::~JavaMethod):
5:30 PM Changeset in webkit [20333] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=13087
<rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

  • fast/forms/radio_checked_name-expected.txt: Added.
  • fast/forms/radio_checked_name.html: Added.

WebCore:

Reviewed by Beth.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13087
<rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

Test: fast/forms/radio_checked_name.html

We were matching a WinIE quirk that does not allow a user to check and uncheck an unnamed radio button. But they still
allow the checked attribute to be set in html, and changed in javascript. So this change matches that behavior.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): We no longer need a special call to setChecked when parsing the name attribute, since we setChecked will now work with unnamed radio buttons. (WebCore::HTMLInputElement::preDispatchEventHandler): Added comment. (WebCore::HTMLInputElement::setChecked): Don't check for the unnamed radio button case here. (WebCore::HTMLInputElement::postDispatchEventHandler): Don't call setChecked for unnamed radio buttons. (WebCore::HTMLInputElement::defaultEventHandler): ditto.
5:27 PM Changeset in webkit [20332] by aroben
  • 2 edits in trunk/WebCore

Rubberstamped by Oliver.

  • bridge/JavaScriptStatistics.cpp: Added missing header for correctness.
5:16 PM Changeset in webkit [20331] by andrew
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

JavaScriptGlue:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • WebKit.xcodeproj/project.pbxproj:
5:13 PM Changeset in webkit [23119] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebKit.vcproj/WebKitGUID.vcproj:
4:50 PM Changeset in webkit [20330] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • Changed list size threshold to 5 based on testing.

I was testing the i-Bench JavaScript with the list statistics
dumping on, and discovered that there were many 5-element lists.
The fast case for lists was for 4 elements and fewer. By changing
the threshold to 5 elements we get a measurable speedup. I believe
this will help real web pages too, not just the benchmark.

  • kjs/list.cpp: Change constant from 4 to 5.
4:36 PM Changeset in webkit [23118] by aroben
  • 12 edits
    3 copies
    2 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders and Darin.

Added JavaScriptStatistics to the project for
<rdar://problems/5071653>.

  • WebCore.vcproj/WebCore.vcproj: Added include/pthreads to the include path, and added JavaScriptStatistics.(cpp|h).

WebKitToolsWin:

Reviewed by Anders and Darin.

Fix <rdar://problem/5071653> DumpRenderTree needs to be able to
trigger GC on a separate thread

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added GCController.(cpp|h) to the project.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Added. (collectCallback): (collectOnAlternateThreadCallback): (getJSObjectCountCallback): (getClass): (makeGCController):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::windowScriptObjectAvailable): Add the GCController to the window object.

WebKitWin:

Reviewed by Anders and Darin.

Added WebJavaScriptCollector for <rdar://problems/5071653>.

  • Interfaces/IWebJavaScriptCollector.idl: Added.
  • Interfaces/WebKit.idl:
  • WebJavaScriptCollector.cpp: Added. (WebJavaScriptCollector::WebJavaScriptCollector): (WebJavaScriptCollector::~WebJavaScriptCollector): (WebJavaScriptCollector::createInstance): (WebJavaScriptCollector::QueryInterface): (WebJavaScriptCollector::AddRef): (WebJavaScriptCollector::Release): (WebJavaScriptCollector::collect): (WebJavaScriptCollector::collectOnAlternateThread): (WebJavaScriptCollector::objectCount):
  • WebJavaScriptCollector.h: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebJavaScriptCollector.idl.
  • WebKit.vcproj/WebKit.vcproj: Added WebJavaScriptCollector.(cpp|h).
  • WebKit.vcproj/WebKitGUID.vcproj: Added IWebJavaScriptCollector_i.c.
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Added cases for WebJavaScriptCollector.
  • WebKitDLL.cpp: (DllGetClassObject): Ditto.
4:28 PM Changeset in webkit [20329] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/value.h: Oops, fix build.
4:12 PM Changeset in webkit [20328] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • remove ~JSValue; tiny low-risk performance boost
  • kjs/value.h: Remove unneeded empty virtual destructor from JSValue. The only class derived from JSValue is JSCell and it already has a virtual destructor. Declaring an empty constructor in JSValue had one good effect: it marked the destructor private, making it a compile time error to try to destroy a JSValue; but that's not a likely mistake for someone to make. It had two bad effects: (1) it caused gcc, at least, to generate code to fix up the virtual table pointer to point to the JSValue version of the virtual table inside the destructor of all classes derived from JSValue directly or indirectly; (2) it caused JSValue to be a polymorphic class so required a virtual table for it. It's cleaner to not have either of those.
3:54 PM Changeset in webkit [20327] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
3:39 PM Changeset in webkit [20326] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links that aren't fully selected copy and paste as only text

  • editing/pasteboard/5071074-expected.checksum: Added.
  • editing/pasteboard/5071074-expected.png: Added.
  • editing/pasteboard/5071074-expected.txt: Added.
  • editing/pasteboard/5071074.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5071074>
REGRESSION: Links that aren't fully selected copy and paste as only text


We stopped adding markup for all commonAncestorBlocks
and the ancestors of lastClosed up to them because it
was adding a lot of unnecessary markup.

  • editing/markup.cpp: (WebCore::createMarkup): Also include markup for nodes up to an enclosing anchor. Cleaned up the code for including special common ancestors a bit.
2:39 PM Changeset in webkit [23117] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Release build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Set the include path for release to the same as for debug.
1:22 PM Changeset in webkit [23116] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adele.

Fix eventSender.keyDown() to create WM_CHAR messages as well, since these
are needed by WebCore.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (dispatchMessage): Added. (mouseDownCallback): Call dispatchMessage instead of DispatchMessage. (doMouseUp): Ditto. (mouseClickCallback): Ditto. (doMouseMove): Ditto. (keyDownCallback): Ditto.
12:41 PM Changeset in webkit [20325] by zimmermann
  • 3 edits
    1 move
    3 adds in trunk

Reviewed by Lars Knoll.

Fix crash when opening a SVG document which contains SVG elements, but no <svg> root element.
Moving the mouse was crashing WebKit. Fixes svg/hixie/dynamic/006.xml.

12:31 PM Changeset in webkit [20324] by adele
  • 4 edits in trunk/WebCore

Reviewed by Hyatt.

  • page/Frame.cpp: (WebCore::Frame::forceLayout): Added a flag to allow partial relayout.
  • page/Frame.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): Allow partial relayout if not adjusting view size. (-[WebCoreFrameBridge needsLayout]): Changed to check for pending subtree layout instead of just whether the root needs layout.
12:28 PM Changeset in webkit [20323] by zimmermann
  • 5 edits in trunk

Reviewed by Maciej.

Make JS function calls on POD-types (ie. SVGLength) take effect.
Calling ie. newValueInSpecifiedUnits on SVGLength works as expected.

This worked fine before we switched to SVGLength POD type, so this
can be considered as P1 regression fix.

Partly fix svg/hixie/dynamic/005-broken.svg. We match Opera now though
it's not yet completly fixed. Setting baseVal attribute on SVGAnimatedString
doesn't work as expected - needs a seperated fix.

12:07 PM Changeset in webkit [23115] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Maciej.

Skip tests with international text due to <rdar://problems/4516194>.

  • Skipped:
11:21 AM Changeset in webkit [20322] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Adding comments and a little cleanup from my last checkin.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Removed commented out assert. Added comment about how we use onChange. (WebCore::HTMLSelectElement::selectAll): Added comment about how we use saveLastSelection and onChange. (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto. (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::menuListOnChange): Added assert that usesMenuList() is true. (WebCore::HTMLSelectElement::listBoxOnChange): Added assert that usesMenuList() is false. (WebCore::HTMLSelectElement::saveLastSelection): Added early return for menu lists.
11:14 AM JavaScript and DOM Benchmarks edited by timothy@apple.com
(diff)
9:57 AM Changeset in webkit [20321] by zimmermann
  • 1 edit
    300 adds in trunk/LayoutTests

Reviewed by Maciej.

Import Hixie's SVG testsuite. It highlights one bug, one regression in JS and one crash.
The crashing file is marked with "-disabled", the broken ones with "-broken".

Landing fixes for the certain bugs/regressions seperated.

6:17 AM Changeset in webkit [20320] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Justin


  • fixed <rdar://problem/5071238> REGRESSION: opt-cmd-B to show Bookmarks view does nothing when form field has focus
  • WebView/WebHTMLView.mm: (-[WebHTMLView _handleStyleKeyEquivalent:]): we were counting any set of modifiers plus 'b' as the standard key equivalent for toggling Bold; now we only accept command+'b'
5:46 AM Changeset in webkit [20319] by bdash
  • 7 edits
    2 adds in trunk

2007-03-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Tim Hatcher.

Test: fast/innerHTML/additional-inline-style.html

  • editing/markup.cpp: (WebCore::startMarkup): Changed to add inline style based on CSS rules only in AnnotateForInterchange mode.

2007-03-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Tim Hatcher.

  • editing/pasteboard/paste-table-002-expected.txt:
  • fast/innerHTML/additional-inline-style-expected.txt: Added.
  • fast/innerHTML/additional-inline-style.html: Added.
  • webarchive/test-duplicate-resources-expected.txt:
  • webarchive/test-frameset-expected.txt:
  • webarchive/test-link-href-expected.txt:
2:32 AM Changeset in webkit [23114] by aroben
  • 4 edits in branches/WindowsMerge/WebKitTools

Reviewed by Hyatt.

Implemented some more layoutTestController methods:

  • display
  • testRepaint
  • repaintSweepHorizontally

The last two don't have any effect yet because we don't support pixel
tests yet (<rdar://problem/5071708>).

This gets all but one test in fast/repaint passing, and fixes various
other tests that use these methods as well.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize new globals.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declarations.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (displayCallback): Implemented. (testRepaintCallback): Implemented. (repaintSweepHorizontallyCallback): Implemented.
1:19 AM Changeset in webkit [20318] by zack
  • 2 edits in trunk/WebCore

compile fix for qt

1:00 AM Changeset in webkit [20317] by aroben
  • 5 edits
    2 moves in trunk

WebCore:

Reviewed by Hyatt and Maciej.

Renamed WebCoreJavaScript to JavaScriptStatistics and made it C++ as
part of <rdar://problem/5071653>.

All layout tests pass.

  • WebCore.exp: Updated.
  • WebCore.xcodeproj/project.pbxproj: Updated.
  • bridge/JavaScriptStatistics.cpp: Moved from bridge/mac/WebCoreJavaScript.mm, and converted to C++. (WebCore::collect): (WebCore::JavaScriptStatistics::objectCount): (WebCore::JavaScriptStatistics::interpreterCount): (WebCore::JavaScriptStatistics::protectedObjectCount): (WebCore::JavaScriptStatistics::rootObjectTypeCounts): (WebCore::JavaScriptStatistics::garbageCollect): (WebCore::JavaScriptStatistics::garbageCollectOnAlternateThread): (WebCore::JavaScriptStatistics::shouldPrintExceptions): (WebCore::JavaScriptStatistics::setShouldPrintExceptions):
  • bridge/JavaScriptStatistics.h: Added.
  • bridge/mac/WebCoreJavaScript.h: Removed.
  • bridge/mac/WebCoreJavaScript.mm: Removed.

WebKit:

Reviewed by Hyatt and Maciej.

Updated WebCoreStatistics for the conversion of WebCoreJavaScript to
C++.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): (+[WebCoreStatistics javaScriptInterpretersCount]): (+[WebCoreStatistics javaScriptProtectedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectTypeCounts]): Moved conversion to NSCountedSet here from WebCore. (+[WebCoreStatistics garbageCollectJavaScriptObjects]): (+[WebCoreStatistics garbageCollectJavaScriptObjectsOnAlternateThread:]): (+[WebCoreStatistics shouldPrintExceptions]): (+[WebCoreStatistics setShouldPrintExceptions:]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectClasses]):
12:49 AM Changeset in webkit [23113] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • Interfaces/IWebView.idl:
12:40 AM Changeset in webkit [20316] by hyatt
  • 293 edits in trunk/LayoutTests/svg

Update SVG tests now that painting happens after onload.

12:36 AM Changeset in webkit [20315] by hyatt
  • 2 edits in trunk/LayoutTests/http/tests/misc

Update tests for minimum font size change.

12:35 AM Changeset in webkit [20314] by hyatt
  • 3 edits in trunk/LayoutTests/fast/forms

Update tests for minimum font size change.

12:34 AM Changeset in webkit [20313] by hyatt
  • 4 edits in trunk/LayoutTests/fast/css

Update tests for minimum font size change.

12:34 AM Changeset in webkit [20312] by hyatt
  • 3 edits in trunk/LayoutTests/fast/box-sizing

Update tests for minimum font size change.

12:32 AM Changeset in webkit [20311] by hyatt
  • 2 edits in trunk/WebKitTools

Update the minimum font size pref to match the actual default setting in Safari. It should have been 1
all this time and not 9.

Reviewed by aroben

  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree):

Mar 18, 2007:

11:52 PM Changeset in webkit [23112] by aroben
  • 10 edits
    2 adds in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Hyatt.

Fix DRT part of <rdar://problem/5066482> DumpRenderTree on Windows
doesn't dump editing callbacks

However, we still don't dump anything because of
<rdar://problem/5071598>.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize shouldDumpEditingCallbacks. (main): Set the WebView's editing delegate.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added EditingDelegate.(cpp|h) to the project.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Added. (EditingDelegate::EditingDelegate): (EditingDelegate::QueryInterface): (EditingDelegate::AddRef): (EditingDelegate::Release): (dumpPath): (dump): (EditingDelegate::shouldBeginEditingInDOMRange): (EditingDelegate::shouldEndEditingInDOMRange): (EditingDelegate::shouldInsertNode): (EditingDelegate::shouldInsertText): (EditingDelegate::shouldDeleteDOMRange): (EditingDelegate::shouldChangeSelectedDOMRange): (EditingDelegate::shouldApplyStyle): (EditingDelegate::shouldChangeTypingStyle): (EditingDelegate::doPlatformCommand): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Added. (EditingDelegate::setAcceptsEditing): (EditingDelegate::undoManagerForWebView):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpEditingCallbacksCallback): Ported from Mac. (setAcceptsEditingCallback): Ditto.

WebKitWin:

Reviewed by Hyatt.

Implemented getting/setting of the editing delegate (we don't actually
use it for anything yet, though. See <rdar://problem/5071598>).

  • Interfaces/IWebEditingDelegate.idl: Renamed IWebViewEditingDelegate to IWebEditingDelegate to match our other delegates.
  • Interfaces/IWebView.idl: Updated for rename.
  • WebView.cpp: (WebView::setEditingDelegate): Implemented. (WebView::editingDelegate): Ditto.
  • WebView.h: Updated for rename.
10:43 PM Changeset in webkit [20310] by mjs
  • 45 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Mark.


  • avoid static construction (and global variable access) in a smarter, more portable way, to later enable MUTLI_THREAD mode to work on other platforms and compilers.


  • kjs/CommonIdentifiers.cpp: Added. New class to hold all the shared identifiers. (KJS::CommonIdentifiers::CommonIdentifiers): (KJS::CommonIdentifiers::shared):
  • kjs/CommonIdentifiers.h: Added.
  • kjs/ExecState.h: (KJS::ExecState::propertyNames): Hand the CommonIdentifiers instance here for easy access. (KJS::ExecState::ExecState):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor):
  • CMakeLists.txt:
  • JavaScriptCore.exp:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • bindings/runtime_array.cpp: (RuntimeArray::getOwnPropertySlot): (RuntimeArray::put):
  • bindings/runtime_method.cpp: (RuntimeMethod::getOwnPropertySlot):
  • kjs/array_object.cpp: (ArrayInstance::getOwnPropertySlot): (ArrayInstance::put): (ArrayInstance::deleteProperty): (ArrayProtoFunc::ArrayProtoFunc): (ArrayProtoFunc::callAsFunction): (ArrayObjectImp::ArrayObjectImp):
  • kjs/bool_object.cpp: (BooleanPrototype::BooleanPrototype): (BooleanProtoFunc::BooleanProtoFunc): (BooleanProtoFunc::callAsFunction): (BooleanObjectImp::BooleanObjectImp):
  • kjs/completion.h: (KJS::Completion::Completion):
  • kjs/date_object.cpp: (KJS::DateProtoFunc::DateProtoFunc): (KJS::DateObjectImp::DateObjectImp): (KJS::DateObjectFuncImp::DateObjectFuncImp):
  • kjs/error_object.cpp: (ErrorPrototype::ErrorPrototype): (ErrorProtoFunc::ErrorProtoFunc): (ErrorProtoFunc::callAsFunction): (ErrorObjectImp::ErrorObjectImp): (ErrorObjectImp::construct): (NativeErrorPrototype::NativeErrorPrototype): (NativeErrorImp::NativeErrorImp): (NativeErrorImp::construct): (NativeErrorImp::callAsFunction):
  • kjs/function.cpp: (KJS::FunctionImp::getOwnPropertySlot): (KJS::FunctionImp::put): (KJS::FunctionImp::deleteProperty): (KJS::FunctionImp::getParameterName): (KJS::DeclaredFunctionImp::construct): (KJS::IndexToNameMap::unMap): (KJS::Arguments::Arguments): (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::deleteProperty): (KJS::GlobalFuncImp::GlobalFuncImp):
  • kjs/function_object.cpp: (FunctionPrototype::FunctionPrototype): (FunctionProtoFunc::FunctionProtoFunc): (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::FunctionObjectImp): (FunctionObjectImp::construct):
  • kjs/grammar.y:
  • kjs/identifier.cpp:
  • kjs/identifier.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::init): (KJS::Interpreter::initGlobalObject):
  • kjs/interpreter.h:
  • kjs/lookup.h:
  • kjs/math_object.cpp: (MathFuncImp::MathFuncImp):
  • kjs/nodes.cpp: (ArrayNode::evaluate): (FuncDeclNode::processFuncDecl): (FuncExprNode::evaluate):
  • kjs/number_object.cpp: (NumberPrototype::NumberPrototype): (NumberProtoFunc::NumberProtoFunc): (NumberObjectImp::NumberObjectImp):
  • kjs/object.cpp: (KJS::JSObject::put): (KJS::JSObject::defaultValue): (KJS::JSObject::hasInstance):
  • kjs/object.h: (KJS::JSObject::getOwnPropertySlot):
  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): (ObjectProtoFunc::ObjectProtoFunc): (ObjectObjectImp::ObjectObjectImp):
  • kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): (RegExpProtoFunc::RegExpProtoFunc): (RegExpObjectImp::RegExpObjectImp):
  • kjs/string_object.cpp: (KJS::StringInstance::getOwnPropertySlot): (KJS::StringInstance::put): (KJS::StringInstance::deleteProperty): (KJS::StringPrototype::StringPrototype): (KJS::StringProtoFunc::StringProtoFunc): (KJS::StringProtoFunc::callAsFunction): (KJS::StringObjectImp::StringObjectImp): (KJS::StringObjectFuncImp::StringObjectFuncImp):
  • kjs/testkjs.cpp: (TestFunctionImp::TestFunctionImp):

WebCore:

Reviewed by Mark.

  • avoid static construction (and global variable access) in a smarter, more portable way, to later enable MUTLI_THREAD mode to work on other platforms and compilers.


  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBaseFunction::JSHTMLInputElementBaseFunction):
  • bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
  • bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodeMap::getOwnPropertySlot): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::HTMLElementFunction): (KJS::JSHTMLCollection::getOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
  • bindings/objc/WebScriptObject.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
10:41 PM Changeset in webkit [23111] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix the CSS2 system font for 'menu' to match Mac. Makes the system fonts layout test pass.

10:28 PM Changeset in webkit [23110] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Changed the file upload button to say "Choose File" to match Mac.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::fileButtonChooseFileLabel):
10:05 PM Changeset in webkit [20309] by andrew
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Mark Rowe


Set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

JavaScriptGlue:

Reviewed by Mark Rowe


Set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Mark Rowe

Set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Mark Rowe


Set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • WebKit.xcodeproj/project.pbxproj:
9:57 PM Changeset in webkit [20308] by hyatt
  • 36 edits in trunk/LayoutTests/http/tests/navigation

land update results for frame pixel changes.

9:53 PM Changeset in webkit [20307] by hyatt
  • 28 edits in trunk/LayoutTests/fast/frames

Land updated results for frames pixel tests.

9:53 PM Changeset in webkit [20306] by hyatt
  • 4 adds in trunk/LayoutTests/fast/frames

Add layout test for frame borders case.

9:50 PM Changeset in webkit [20305] by hyatt
  • 12 edits in trunk/WebCore

Fix for REGRESSION bug 13108, frame borders being painted when they shouldn't be. Rework both frame borders
and resizing to be more like other browsers.

Reviewed by ggaren

fast/frames/no-frame-borders.html

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): (WebCore::HTMLFrameElement::attach): (WebCore::HTMLFrameElement::parseMappedAttribute):
  • html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::hasFrameBorder):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::attach):
  • html/HTMLFrameSetElement.h: (WebCore::HTMLFrameSetElement::hasFrameBorder):
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::edgeInfo):
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): (WebCore::RenderFrameSet::GridAxis::resize): (WebCore::RenderFrameSet::fillFromEdgeInfo): (WebCore::RenderFrameSet::computeEdgeInfo): (WebCore::RenderFrameSet::edgeInfo): (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::startResizing): (WebCore::RenderFrameSet::continueResizing): (WebCore::RenderFrameSet::canResizeRow): (WebCore::RenderFrameSet::canResizeColumn): (WebCore::RenderFrameSet::splitPosition): (WebCore::RenderFrameSet::hitTestSplit): (WebCore::RenderFrameSet::dump):
  • rendering/RenderFrameSet.h: (WebCore::): (WebCore::FrameEdgeInfo::FrameEdgeInfo): (WebCore::FrameEdgeInfo::preventResize): (WebCore::FrameEdgeInfo::allowBorder): (WebCore::FrameEdgeInfo::setPreventResize): (WebCore::FrameEdgeInfo::setAllowBorder):
9:32 PM Changeset in webkit [20304] by bdash
  • 53 edits in trunk

2007-03-19 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Brady.

Update references to bugzilla.opendarwin.org with bugs.webkit.org.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16):
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction):
  • kjs/grammar.y:
  • kjs/keywords.table:
  • kjs/lexer.cpp: (KJS::Lexer::shift):

2007-03-19 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Brady.

Update references to bugzilla.opendarwin.org with bugs.webkit.org.

  • ChangeLog:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • manual-tests/ATSU-bad-layout.html:
  • manual-tests/accidental-strict-mode.html:
  • manual-tests/applet-param-no-name.html:
  • manual-tests/bidi-parens.html:
  • manual-tests/bugzilla-3855.html:
  • manual-tests/bugzilla-4840.html:
  • manual-tests/bugzilla-6821.html:
  • manual-tests/containing-block-position-chage.html:
  • manual-tests/contenteditable-link.html:
  • manual-tests/css3-cursor-fallback-quirks.html:
  • manual-tests/css3-cursor-fallback-strict.html:
  • manual-tests/custom-cursors.html:
  • manual-tests/dictionary-scrolled-iframe.html:
  • manual-tests/dom-manipulation-on-resize.html:
  • manual-tests/drag-image-to-address-bar.html:
  • manual-tests/empty-link-target.html:
  • manual-tests/empty-title-popup.html:
  • manual-tests/first-line-style-crash.html:
  • manual-tests/invalid-mouse-event.html:
  • manual-tests/left-overflow-repaint.html:
  • manual-tests/linkjump-3.html:
  • manual-tests/log-keypress-events.html:
  • manual-tests/named-window-blank-target.html:
  • manual-tests/plain-text-paste.html:
  • manual-tests/plugin-controller-datasource.html:
  • manual-tests/pre-tab-selection-rect.html:
  • manual-tests/redirection-target.html:
  • manual-tests/redraw-page-cache-visited-links.html:
  • manual-tests/reset-initiatedDrag.html:
  • manual-tests/resources/named-window-blank-target-step2.html:
  • manual-tests/resources/named-window-blank-target-step3.html:
  • manual-tests/resources/named-window-blank-target-step4.html:
  • manual-tests/resources/redraw-page-cache-visited-links-2.html:
  • manual-tests/scrollbar-hittest.html:
  • manual-tests/scrollbar-hittest2.html:
  • manual-tests/subview-click-assertion.html:
  • manual-tests/tabbing-input-google.html:
  • manual-tests/text-field-autoscroll.html:
  • manual-tests/textarea-after-stylesheet-link.html:
  • manual-tests/textarea-focus.html:
  • manual-tests/whitespace-pre-affinity.html:

2007-03-19 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Brady.

Update references to bugzilla.opendarwin.org with bugs.webkit.org.

  • WebInspector/webInspector/inspector.css:
  • WebView/WebHTMLView.mm: (-[WebHTMLView firstRectForCharacterRange:]):
  • WebView/WebView.mm: (-[WebView initWithFrame:frameName:groupName:]):
8:36 PM Changeset in webkit [23109] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Maciej.

  • Skipped: Added another crasher.
8:01 PM JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
7:34 PM Changeset in webkit [20303] by mjs
  • 1 edit
    2 adds in trunk/WebKitSite

Added a random JS benchmark.

  • misc/morph.html: Added.
7:18 PM JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
7:14 PM JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
7:11 PM JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
6:53 PM Changeset in webkit [23108] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver Hunt.

Fixed <rdar://problem/5061807> STRESS (2): Crash in PlatformScrollbar::setRect

No test case because I can't seem to get the Windows DRT to cooperate. I'll try again tomorrow.

The problem was that the FrameView would try to reset the document's scrollbars after having
been removed from the page, so its page pointer would be NULL. Added NULL checks.

This situation ultimately results from the FrameView's non-trivial destructor, which
creates a fragile dependency on tear-down timing. It looks like the timing on Windows
is slightly different from the timing on Mac. I didn't see any obvious resulting bugs,
though, so the NULL checks should be sufficient for now.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::addToDirtyRegion): (WebCore::ScrollView::scrollBackingStore): (WebCore::ScrollView::updateBackingStore):
6:50 PM JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
6:50 PM Changeset in webkit [20302] by bdash
  • 4 edits
    2 deletes in trunk

Roll out r20297, fix for ​http://bugs.webkit.org/show_bug.cgi?id=13091, as it causes regressions in layout tests.

6:40 PM Changeset in webkit [20301] by weinig
  • 13 edits in trunk/LayoutTests

Reviewed by Mark.

Update results after Hyatt's patch in r20268.

  • tables/mozilla/bugs/bug137388-2-expected.checksum:
  • tables/mozilla/bugs/bug137388-2-expected.png:
  • tables/mozilla/bugs/bug137388-2-expected.txt:
  • tables/mozilla/bugs/bug137388-3-expected.checksum:
  • tables/mozilla/bugs/bug137388-3-expected.png:
  • tables/mozilla/bugs/bug137388-3-expected.txt:
  • tables/mozilla/bugs/bug50695-2-expected.checksum:
  • tables/mozilla/bugs/bug50695-2-expected.png:
  • tables/mozilla/bugs/bug50695-2-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
6:32 PM Changeset in webkit [23107] by aroben
  • 18 edits
    3 adds in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Geoff.

  • Skipped: Added a new crasher.

WebKitToolsWin:

Reviewed by Geoff.

Added a basic implementation of eventSender. It supports mouse and key
events.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Added. (DraggingInfo::DraggingInfo): (DraggingInfo::~DraggingInfo): (DraggingInfo::dataObject): (DraggingInfo::dropSource):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): Made the WebView's HWND a global so that EventSender can access it.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declarations.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added new files to project.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Added. (getDragModeCallback): (setDragModeCallback): (leapForwardCallback): (currentEventTime): (makeMsg): (mouseDownCallback): (pointl): (doMouseUp): (mouseUpCallback): (mouseClickCallback): (doMouseMove): (mouseMoveToCallback): (replaySavedEvents): (keyDownCallback): (getClass): (makeEventSender):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Re-ordered #includes.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Changed #include to forward declarations.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::windowScriptObjectAvailable): Make the eventSender available. (WaitUntilDoneDelegate::doDragDrop): Implemented.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:

WebKitWin:

Reviewed by Geoff.

Added IWebFramePrivate::layout to support eventSender in DRT.

Made IWebView inherit from IDropTarget to match Mac, and added
IWebUIDelegatePrivate::doDragDrop to support drag-and-drop in DRT.

  • Interfaces/IWebFramePrivate.idl: Added layout().
  • Interfaces/IWebUIDelegatePrivate.idl: Added doDragDrop().
  • Interfaces/IWebView.idl: Added inheritance from IDropTarget.
  • WebDragClient.cpp: (WebDragClient::startDrag): Call the UI delegate if possible, otherwise fallback to OLE's DoDragDrop.
  • WebFrame.cpp: (WebFrame::layout): Implemented.
  • WebFrame.h:
  • WebView.h:
6:01 PM JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
5:59 PM JavaScript and DOM Benchmarks created by mjs@apple.com
5:59 PM WikiStart edited by mjs@apple.com
(diff)
5:39 PM Changeset in webkit [20300] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::update): add a stub
5:37 PM Changeset in webkit [20299] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

​http://bugs.webkit.org/show_bug.cgi?id=13111
When stopped a load before it completes, partial images become the
broken image icon

  • loader/loader.cpp: (WebCore::Loader::didFail): Split off into a method that knows the difference between failed and cancelled. If a load is cancelled, don't call error() on the object - only remove it from the cache (WebCore::Loader::cancelRequests): Call didFail(loader, true)
  • loader/loader.h: Added didFail(SubresourceLoader*, bool cancelled)
4:42 PM Changeset in webkit [20298] by bdash
  • 3 edits
    4 adds in trunk

2007-03-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

Test: fast/forms/input-text-word-wrap.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): Force the inner block to 'word-wrap:normal'.

2007-03-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

  • fast/forms/input-text-word-wrap-expected.checksum: Added.
  • fast/forms/input-text-word-wrap-expected.png: Added.
  • fast/forms/input-text-word-wrap-expected.txt: Added.
  • fast/forms/input-text-word-wrap.html: Added.
4:40 PM Changeset in webkit [20297] by bdash
  • 4 edits
    2 adds in trunk

2007-03-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Tim Hatcher.

Test: fast/innerHTML/additional-inline-style.html

  • editing/markup.cpp: (WebCore::startMarkup): Changed to add inline style based on CSS rules only in AnnotateForInterchange mode.

2007-03-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Tim Hatcher.

  • editing/pasteboard/paste-table-002-expected.txt:
  • fast/innerHTML/additional-inline-style-expected.txt: Added.
  • fast/innerHTML/additional-inline-style.html: Added.
4:25 PM Changeset in webkit [20296] by bdash
  • 6 edits
    2 adds in trunk

2007-03-18 Dan Waylonis <​waylonis@mac.com>

Reviewed by Tim Hatcher.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=13005
Bug 13005: WebScriptObject +throwException needs NULL check.

Add checking for NULL interpreter before throwing exception.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]):

2007-03-18 Dan Waylonis <​waylonis@mac.com>

Reviewed by Tim Hatcher.

DumpRenderTree changes for ​http://bugs.webkit.org/show_bug.cgi?id=13005
Bug 13005: WebScriptObject +throwException needs NULL check.

Add tests to ensure that a plugin can safely throw an exception in dealloc.

  • DumpRenderTree/ObjCPlugin.h:
  • DumpRenderTree/ObjCPlugin.m: (+[ObjCPlugin webScriptNameForKey:]): (+[ObjCPlugin isKeyExcludedFromWebScript:]): (-[ObjCPlugin dealloc]):

2007-03-18 Dan Waylonis <​waylonis@mac.com>

Reviewed by Tim Hatcher.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=13005
Bug 13005: WebScriptObject +throwException needs NULL check.

A plugin that throws on dealloc can crash WebKit.

  • plugins/throw-on-dealloc-expected.txt: Added.
  • plugins/throw-on-dealloc.html: Added.
4:02 PM Changeset in webkit [20295] by ggaren
  • 6 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Oliver Hunt.


Exposed some extra toUInt32 functionality, as part of the fix for
REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
(Style Change Through JavaScript Blanks Content)

LayoutTests:

Reviewed by Oliver Hunt.


Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=13106
REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
(Style Change Through JavaScript Blanks Content)

  • fast/dom/collection-null-like-arguments-expected.txt: Added.
  • fast/dom/collection-null-like-arguments.html: Added.

WebCore:

Reviewed by Oliver Hunt.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=13106
REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
(Style Change Through JavaScript Blanks Content)


When indexing into collections, treat the empty string as an invalid argument,
instead of the number 0.

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLCollection::getOwnPropertySlot): (KJS::JSHTMLCollection::callAsFunction): (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
11:42 AM Changeset in webkit [23106] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

11:39 AM Changeset in webkit [20294] by sfalken
  • 1 copy in tags/Safari-521.35.10b

New tag.

11:10 AM Changeset in webkit [20293] by ggaren
  • 2 edits in trunk/JavaScriptCore

Removed duplicate export name.


11:07 AM Changeset in webkit [20292] by ggaren
  • 13 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/5064964> Repro ASSERT failure in JS Bindings when
closing window @ lowtrades.bptrade.com


Unfortunately, the bindings depend on UString and Identifier as string
representations. So, they need to acquire the JSLock when doing something
that will ref/deref their strings.

Layout tests, the original site, and Java, Flash, and Quicktime on the
web work. No leaks reported. No automated test for this because testing
the Java bindings, like math, is hard.


  • bindings/runtime.h: Made Noncopyable, just to be sure.


  • bindings/c/c_class.cpp: (KJS::Bindings::CClass::~CClass): Acquire the JSLock and explicitly clear the keys in our hashtable, since they're UString::Reps, and ref/deref aren't thread-safe. (KJS::Bindings::CClass::methodsNamed): Also acquire the JSLock when adding keys to the table, since the table ref's them. (KJS::Bindings::CClass::fieldNamed): ditto.
  • bindings/c/c_utility.cpp: Removed dead function. (KJS::Bindings::convertValueToNPVariant): Acquire the JSLock because doing it recursively is pretty cheap, and it's just too confusing to tell whether all our callers do it for us. (KJS::Bindings::convertNPVariantToValue): ditto
  • bindings/c/c_utility.h:
  • bindings/jni/jni_class.cpp: Same deal as c_class.cpp. (JavaClass::JavaClass): (JavaClass::~JavaClass):
  • bindings/jni/jni_instance.cpp: Same deal as c_utility.cpp. (JavaInstance::stringValue):
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject):
  • bindings/jni/jni_runtime.cpp: (JavaMethod::~JavaMethod): Moved from header, for clarity. (appendClassName): Made this static, so the set of callers is known, and we can assert that we hold the JSLock. Also changed it to take a UString reference, which makes the calling code simpler. (JavaMethod::signature): Store the ASCII value we care about instead of a UString, since UString is so much more hassle. Hold the JSLock while building up the temporary UString.
  • bindings/jni/jni_runtime.h: Nixed dead code in JavaMethod. (KJS::Bindings::JavaString::JavaString): Hold a UString::Rep instead of a UString, so we can acquire the JSLock and explicitly release it. (KJS::Bindings::JavaString::_commonInit): (KJS::Bindings::JavaString::~JavaString): (KJS::Bindings::JavaString::UTF8String): (KJS::Bindings::JavaString::uchars): (KJS::Bindings::JavaString::length): (KJS::Bindings::JavaString::ustring):
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertArrayInstanceToJavaArray): Made this static, so the set of callers is known, and we can assert that we hold the JSLock. (KJS::Bindings::convertValueToJValue): Acquire the JSLock because doing it recursively is pretty cheap, and it's just too confusing to tell whether all our callers do it for us.
  • bindings/objc/objc_runtime.h: Nixed some dead code.
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertNSStringToString): Same drill as above.
10:39 AM Changeset in webkit [20291] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=13105
REGRESSION: an exception raised when calculating base value of a dot expression is not returned

Test: fast/js/dot-node-base-exception.html

  • kjs/nodes.cpp: (FunctionCallDotNode::evaluate): Added the necessary KJS_CHECKEXCEPTIONVALUE.
10:36 AM Changeset in webkit [20290] by sfalken
  • 2 edits in trunk/JavaScriptCore

2007-03-18 Steve Falkenburg <​sfalken@apple.com>

Build fix.

4:34 AM Changeset in webkit [20289] by hyatt
  • 3 edits in trunk/WebCore

Use fillRect instead of drawLine, since drawLine has some odd behavior (it's only used for borders).

Reviewed by aroben

  • platform/graphics/IntRect.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paintColumnBorder): (WebCore::RenderFrameSet::paintRowBorder):
4:11 AM Changeset in webkit [20288] by hyatt
  • 2 edits in trunk/WebCore

Change the frameborder color to be light gray for framesets.

Reviewed by aroben

  • rendering/RenderFrameSet.cpp: (WebCore::borderFillColor): (WebCore::RenderFrameSet::paintColumnBorder): (WebCore::RenderFrameSet::paintRowBorder):
3:53 AM Changeset in webkit [20287] by hyatt
  • 2 edits in trunk/WebCore

Make iframes work properly with frameborder="0".

Reviewed by aroben

  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::mapToEntry): (WebCore::HTMLIFrameElement::parseMappedAttribute):
3:52 AM Changeset in webkit [20286] by hyatt
  • 4 adds in trunk/LayoutTests/fast/frames

Add new iframe layout test.

3:00 AM Changeset in webkit [20285] by hyatt
  • 72 edits in trunk/LayoutTests/http/tests

Land corrected results for frame changes.

2:58 AM Changeset in webkit [20284] by hyatt
  • 3 edits in trunk/LayoutTests/fast/replaced

Land corrected results for frame changes.

2:57 AM Changeset in webkit [20283] by hyatt
  • 3 edits in trunk/LayoutTests/fast/repaint

Land corrected results for frame changes.

2:57 AM Changeset in webkit [20282] by hyatt
  • 3 edits in trunk/LayoutTests/fast/overflow

Land corrected results for frame changes.

2:56 AM Changeset in webkit [20281] by hyatt
  • 3 edits in trunk/LayoutTests/fast/loader

Land corrected results for frame changes.

2:56 AM Changeset in webkit [20280] by hyatt
  • 3 edits in trunk/LayoutTests/fast/forms

Land corrected results for frame changes.

2:55 AM Changeset in webkit [20279] by hyatt
  • 6 edits in trunk/LayoutTests/fast/events

Land corrected results for frame changes.

2:54 AM Changeset in webkit [20278] by hyatt
  • 3 edits in trunk/LayoutTests/fast/encoding

Land corrected results for frame changes.

2:54 AM Changeset in webkit [20277] by hyatt
  • 54 edits in trunk/LayoutTests/fast/dom

Land corrected results for frame changes.

2:52 AM Changeset in webkit [20276] by hyatt
  • 6 edits in trunk/LayoutTests/fast/block

Land corrected results for frame changes.

2:51 AM Changeset in webkit [20275] by hyatt
  • 150 edits in trunk/LayoutTests/editing/selection

Land corrected results for frame changes.

2:50 AM Changeset in webkit [20274] by hyatt
  • 126 edits in trunk/LayoutTests/editing/pasteboard

Land corrected results for frame changes.

2:48 AM Changeset in webkit [20273] by hyatt
  • 59 edits in trunk/LayoutTests/editing/execCommand

Land corrected results for frame changes.

2:47 AM Changeset in webkit [20272] by hyatt
  • 10 edits in trunk/LayoutTests/dom/xhtml/level2/html

Land corrected XHTML DOM test results for frames changes.

2:35 AM Changeset in webkit [20271] by hyatt
  • 65 edits in trunk/LayoutTests/fast/frames

Reset frames results.

2:33 AM Changeset in webkit [20270] by hyatt
  • 2 edits in trunk/WebCore

Add a 2px border by default to <iframe>s for compatibility with other browsers.

Reviewed by aroben

  • css/html4.css:
2:21 AM Changeset in webkit [20269] by hyatt
  • 18 edits in trunk

WebCore:

Move frame borders out of WebKit and into WebCore.

Reviewed by aroben, olliej

  • bridge/mac/FrameViewMac.mm:
  • css/html4.css:
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::mapToEntry): (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::attach):
  • html/HTMLFrameSetElement.h: (WebCore::HTMLFrameSetElement::hasBorderColor):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate):
  • page/FrameView.h:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/IntRect.h: (WebCore::IntRect::topLeft): (WebCore::IntRect::topRight): (WebCore::IntRect::bottomLeft): (WebCore::IntRect::bottomRight):
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared):
  • rendering/RenderFrameSet.cpp: (WebCore::borderStartEdgeColor): (WebCore::borderEndEdgeColor): (WebCore::RenderFrameSet::paintColumnBorder): (WebCore::RenderFrameSet::paintRowBorder): (WebCore::RenderFrameSet::paint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::viewCleared):
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):

WebKit:

Move frame borders out of WebKit and into WebCore.

Reviewed by aroben, olliej

  • WebCoreSupport/WebFrameBridge.mm:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrameView.mm: (-[WebFrameView drawRect:]): (-[WebFrameView setFrameSize:]):
  • WebView/WebFrameViewInternal.h:

Mar 17, 2007:

10:23 PM Changeset in webkit [23105] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

The internal side of the patch that ensures Boomer paints twice on ibench. Don't let the timer beat out
that first paint.

Reviewed by aroben

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::update):
10:18 PM Changeset in webkit [20268] by hyatt
  • 4 edits in trunk/WebCore

Make onload do an explicit paint when a top-level document is ready (to ensure that a first paint always
happens before any timers set by the onload can fire).

Reviewed by aroben

  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::update):
10:01 PM Changeset in webkit [23104] by aroben
  • 3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Hyatt.

Implemented console message dumping.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::QueryInterface): Added cases for IWebUIDelegate[Private] (WaitUntilDoneDelegate::webViewAddMessageToConsole): Implemented.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Now inherits from IWebUIDelegatePrivate
7:26 PM Changeset in webkit [23103] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fix fast/dom/isindex-002.html.

Add default strings to our two remaining unimplemented localizable
strings in WebCore.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::searchableIndexIntroduction): Added English string from Mac. (WebCore::inputElementAltText): Ditto.
5:54 PM Changeset in webkit [20267] by hyatt
  • 2 edits in trunk/WebCore

Tweaks to prevent timers from starving user input or painting.

5:11 PM Changeset in webkit [20266] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/5070967> REGRESSION (r20211): Repro crash when
closing View Source window


I award myself 0 points, and may God have mercy on my soul.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
5:04 PM Changeset in webkit [20265] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/gdk/TemporaryLinkStubs.cpp: (Pasteboard::writeURL):
4:39 PM Changeset in webkit [20264] by hyatt
  • 2 edits in trunk/WebCore

Fix tiny PLT regression. Don't examine the border/background data for RenderImage when images change
unless we actually have a border/background.

Reviewed by Brady

  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged):
4:17 PM Changeset in webkit [23102] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

Fix repro ASSERT when logging in to facebook.com.

  • WebMutableURLRequest.cpp: (WebMutableURLRequest::valueForHTTPHeaderField): Implemented.
10:21 AM Changeset in webkit [20263] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher


Discovered while working on <rdar://problem/5070334> that many WebView calls will crash if called
after -[WebView close] has executed because _private->page is deferenced after it's been set to 0.
It might be silly/wrong to call these methods after -close, but obviously it shouldn't crash. Made
each use of _private->page robust against nil-dereferencing.

  • WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView _updateWebCoreSettingsFromPreferences:]): (-[WebView _setDashboardBehavior:to:]): (-[WebView _dashboardBehavior:]): (-[WebView goBack]): (-[WebView goForward]): (-[WebView goToBackForwardItem:]): (-[WebView canGoBack]): (-[WebView canGoForward]): (-[WebView setTabKeyCyclesThroughElements:]): (-[WebView tabKeyCyclesThroughElements]): (-[WebView setEditable:]):
8:38 AM Changeset in webkit [20262] by zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Sam Weinig.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=13046 (CSS styles on hover and focus are broken for <use>)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> CSS styles broken)
Added test: svg/custom/use-css-events.svg

In general this fixes the peepo.co.uk website.

Forgot to pass the actual StyleChange to the recalcStyle() function,
when calling it on the shadow tree root element.

7:49 AM Changeset in webkit [20261] by thatcher
  • 12 edits in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/Version.xcconfig:

JavaScriptGlue:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

  • Configurations/JavaScriptGlue.xcconfig:
  • Configurations/Version.xcconfig:

WebCore:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

  • Configurations/Version.xcconfig:
  • Configurations/WebCore.xcconfig:

WebKit:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

  • Configurations/Version.xcconfig:
  • Configurations/WebKit.xcconfig:
4:53 AM Changeset in webkit [20260] by antti
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=12595
REGRESSION: Can't add item to cart at lnt.com (JS type error)
<rdar://problem/4722863>


Expanded version of Darin's test case.

  • fast/forms/old-names-expected.txt: Added.
  • fast/forms/old-names.html: Added.

WebCore:

Reviewed by Adele.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12595
REGRESSION: Can't add item to cart at lnt.com (JS type error)
<rdar://problem/4722863>


Emulate Firefox behavior where form elements accessed by a name
can be accessed with that name later even if the name changes or
even if element is removed from the document.


This is loosely based on Darin's earlier patch for the same problem but
is much less expansive. It takes somewhat different approach to more closely
mimic Firefox behavior. Includes expanded test case.

  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::canGetItemsForName):

Use new the HTMLFormElement::getNamedElements() method

(WebCore::JSHTMLFormElement::nameGetter):

Use new the HTMLFormElement::getNamedElements() method

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::elementForAlias): (WebCore::HTMLFormElement::addElementAlias):

Maintain a map of known element aliases

(WebCore::HTMLFormElement::getNamedElements):

Get a list of elements matching the name, based both their
current names and known aliases (earlier names).
Keep the alias list in sync.

  • html/HTMLFormElement.h:
12:46 AM Changeset in webkit [23101] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4960391> REGRESSION (r18922): onChange never fired after selecting an item from a menulist

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Initialize m_focusedIndex to 0. Instead of using the client to track the focused index, we'll keep track of it internally. Our old behavior was trying to match Firefox by updating the selected index as you focus items, but that doesn't seem necessary if the selection never gets committed. (WebCore::PopupMenu::show): Initialize the focused index to the client's selected index. (WebCore::PopupMenu::setFocusedIndex): Remove the fireOnChange argument. Remove the call to valueChanged. (WebCore::PopupMenu::focusedIndex): Return m_focusedIndex instead of getting this from the client. (WebCore::PopupMenu::down): Use the focusedIndex. (WebCore::PopupMenu::up): ditto. (WebCore::PopupMenu::paint): Paint a selected appearance for the item with the focused index.
12:40 AM Changeset in webkit [20259] by adele
  • 9 edits in trunk

LayoutTests:

Reviewed by Hyatt.

Updated test for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
​http://bugs.webkit.org/show_bug.cgi?id=12725

  • fast/forms/listbox-onchange-expected.txt:
  • fast/forms/listbox-onchange.html:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
​http://bugs.webkit.org/show_bug.cgi?id=12725

Test: updated fast/forms/listbox-onchange.html

Added HTMLSelectElement::saveLastSelection that is called before changing a selection that could result
in onChange being called. m_lastOnChangeIndex and m_lastOnChangeSelection no longer have to be up-to date all the time,
they just have to be up-to-date before we execute an action that may trigger onChange.

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelectedState): Added. The HTMLSelectElement will only set an option's selected state with this method. This ensures that notifyOptionSelected won't get called when the call originates from the select element.
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): Calls setSelectedState. (WebCore::HTMLSelectElement::setSelectedIndex): ditto. Don't update the last selection variables here. Scroll to the new selection. The scrolling call used to only be in notifyOptionSelected. There's no reason we shouldn't scroll when the selection is set through the HTMLSelectElement. (WebCore::HTMLSelectElement::setValue): Call setSelectedIndex to update all options selected state. (WebCore::HTMLSelectElement::restoreState): Call setSelectedState. (WebCore::HTMLSelectElement::selectAll): Call saveLastSelection before making the selection, and calling onChange. (WebCore::HTMLSelectElement::recalcListItems): Call setSelectedState. Don't need to save selection here anymore, since it will get saved before we call onChange. (WebCore::HTMLSelectElement::reset): ditto. (WebCore::HTMLSelectElement::dispatchFocusEvent): Added. Call saveLastSelection for menu lists, since onChange can be fired on blur. (WebCore::HTMLSelectElement::dispatchBlurEvent): Call menuListOnChange. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Call saveLastSelection before showing the popup window. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Call saveLastSelection during mousedown (to prepare for an onchange during mouseup, or after autoscroll). (WebCore::HTMLSelectElement::updateListBoxSelection): Call setSelectedState.

(WebCore::HTMLSelectElement::menuListOnChange): Added. Compares the m_lastOnChangeIndex to the selectedIndex().
(WebCore::HTMLSelectElement::listBoxOnChange): Move the m_lastOnChangeSelection creation to saveLastSelection.
(WebCore::HTMLSelectElement::saveLastSelection): Added. Sets m_lastOnChangeIndex or m_lastOnChangeSelection.

  • html/HTMLSelectElement.h:
  • platform/PopupMenu.h:

Mar 16, 2007:

9:59 PM Changeset in webkit [20258] by oliver
  • 14 edits in trunk

2007-03-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Hyatt.

WebCore:

The old canSaveAsWebArchive call was necessary as stand alone
images used to be rendered by ImageDocument.

Fixes rdar://problem/5061252

  • dom/Clipboard.cpp:
  • dom/Clipboard.h: (WebCore::Clipboard::setDragHasStarted):
  • page/DragClient.h: (WebCore::DragClient::declareAndWriteDragImage):
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage):

WebKit:

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteDragImage):
  • WebKit.xcodeproj/project.pbxproj:

LayoutTests:

Updating layout test to allow stand alone image to be
dragged into a content editable div

  • fast/events/standalone-image-drag-to-editable-expected.checksum:
  • fast/events/standalone-image-drag-to-editable-expected.png:
  • fast/events/standalone-image-drag-to-editable-expected.txt:
  • fast/events/standalone-image-drag-to-editable.html:
6:23 PM Changeset in webkit [23100] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver

Make the WebDownload fix a little more correct.


  • WebDownload.cpp: (WebDownload::init): Release the connection from the ResourceHandle after the CFURLDownload has been created
6:01 PM Changeset in webkit [20257] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4869095>
default content type changed for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)


  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
5:43 PM Changeset in webkit [20256] by thatcher
  • 4 edits in trunk

64-bit build fix.

5:36 PM Changeset in webkit [20255] by beidson
  • 2 edits in trunk/LayoutTests

Reviewed by Braveheart

Updated layouttest results because I added a window property

  • fast/dom/Window/window-properties-expected.txt:
4:57 PM Changeset in webkit [20254] by beidson
  • 2 edits in trunk/WebCore

Rubberstamped by Tim Hatcher

Update the hash table header for Window object properties

  • bindings/js/kjs_window.cpp:
4:49 PM Changeset in webkit [20253] by beidson
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Anders

<rdar://problem/5061826> and
​http://bugs.webkit.org/show_bug.cgi?id=12863
Implement window.stop()

  • http/tests/misc/window-dot-stop-expected.txt: Added.
  • http/tests/misc/window-dot-stop.html: Added.

WebCore:

Reviewed by Anders

<rdar://problem/5061826> and
​http://bugs.webkit.org/show_bug.cgi?id=12863
Implement window.stop()

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Add case Window::Stop
  • bindings/js/kjs_window.h: (KJS::Window::): Add "Stop"
4:41 PM Changeset in webkit [23099] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Lou.

Fix for <rdar://problem/5065040> cannot mousedown + drag in a <select> menu

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Set the capture when the popup window comes up. (WebCore::PopupWndProc): Release the capture only when the mouse is not down, and the mouse moves outside the popup window, or if you mouse up inside the window, and you're about to hide the popup. The mouse will get recaptured if you mouse down again in the window.
4:19 PM Changeset in webkit [20252] by thatcher
  • 4 edits in trunk

Adding ChangeLog markers.

4:18 PM Changeset in webkit [20251] by thatcher
  • 1 edit in tags/Safari-5522.4/JavaScriptGlue/Info.plist

Versioning.

4:16 PM Changeset in webkit [20250] by thatcher
  • 1 edit in tags/Safari-5522.4/JavaScriptCore/Info.plist

Versioning.

4:14 PM Changeset in webkit [20249] by thatcher
  • 1 edit in tags/Safari-5522.4/WebKit/Info.plist

Versioning.

4:12 PM Changeset in webkit [20248] by thatcher
  • 1 edit in tags/Safari-5522.4/WebCore/Info.plist

Versioning.

4:11 PM Changeset in webkit [23098] by ggaren
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Dave Hyatt.


Fixed "called Frame::paint with nil renderer" console messages.
You can now launch and exit the app without seeing any
error messages!

  • WebView.cpp: (WebView::paintIntoBackingStore): Only tell the FrameView to paint if it has a renderer. This isn't an issue on the Mac because we don't create a FrameView until you load a page.
4:11 PM Changeset in webkit [20247] by thatcher
  • 3 edits in tags/Safari-5522.4/WebCore

Merging fix for r20228.

4:09 PM Changeset in webkit [20246] by thatcher
  • 18 edits in tags/Safari-5522.4/WebCore

Merging fix for r20214.

4:03 PM Changeset in webkit [20245] by thatcher
  • 1 copy in tags/Safari-5522.4

New tag from r20197.

3:39 PM Changeset in webkit [20244] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

fixed changelog order -- do you need a changelog entry for a changelog fix???

3:37 PM Changeset in webkit [20243] by ggaren
  • 2 edits in trunk/WebCore

Fix for 13084, assertion failure in the Cache. Convert the client list
to a HashCountedSet so that multiple refs and derefs are allowed.

Fix RenderImage so that if it has the same image used as a background/border
and as the foreground that it will repaint properly (can be tested using
border-image and a foreground image).

Optimize list marker so that it doesn't waste time in the base class method,
since list markers don't support background or border images.

Reviewed by andersca

  • ChangeLog:
  • loader/CachedResource.cpp: (WebCore::CachedResource::ref):
  • loader/CachedResource.h:
  • loader/CachedResourceClientWalker.cpp: (WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
  • loader/CachedResourceClientWalker.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged):
3:29 PM Changeset in webkit [20242] by hyatt
  • 7 edits in trunk/WebCore

Fix for 13084, assertion failure in the Cache. Convert the client list
to a HashCountedSet so that multiple refs and derefs are allowed.

Fix RenderImage so that if it has the same image used as a background/border
and as the foreground that it will repaint properly (can be tested using
border-image and a foreground image).

Optimize list marker so that it doesn't waste time in the base class method,
since list markers don't support background or border images.

Reviewed by andersca

  • ChangeLog:
  • loader/CachedResource.cpp: (WebCore::CachedResource::ref):
  • loader/CachedResource.h:
  • loader/CachedResourceClientWalker.cpp: (WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
  • loader/CachedResourceClientWalker.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged):
3:26 PM Changeset in webkit [20241] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Attempt to fix the 64-bit build.

3:04 PM Changeset in webkit [23097] by andersca
  • 5 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Add setters and getters for cookie storage accept policy.


  • Interfaces/IWebPreferences.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::cookieStorageAcceptPolicy): (WebPreferences::setCookieStorageAcceptPolicy):
  • WebPreferences.h:
1:22 PM Changeset in webkit [23096] by andersca
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Add Radar

1:16 PM Changeset in webkit [23095] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam and Dave Hyatt.

Fix acid2 test.


  • WebFrame.cpp: (WebFrame::shouldFallBack): Implement this function.
1:10 PM Changeset in webkit [20240] by ggaren
  • 5 edits in trunk/WebCore

Reviewed by Anders Carlsson.


Fixed <rdar://problem/5065399> REGRESSION: leaks in Frame::bindingRootObject
seen on buildbot

The problem was that we were initializing the same WebScriptObject twice.
This caused it to leak its original set of ivars.


I think some refactoring could prevent this situation from arising in the
first place, but I'm just adding a check at the call site for now, to do
the simplest thing.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject _setImp:originRootObject:rootObject:]): Added ASSERTs against multiple calls.
  • bindings/objc/WebScriptObjectPrivate.h: Renamed _initializeWithObjectImp to setImp because "init" vs "initialize" was a too subtle indication that one was a Cocoa initializer and one was not.
12:27 PM Changeset in webkit [23094] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-03-16 Ada Chan <​adachan@apple.com>

WebKitWin:

Reviewed by Steve.


Implemented a couple of DOM methods so we can set the font-size of an element directly in the app.

  • DOMCSSClasses.cpp: (DOMCSSStyleDeclaration::setProperty):
  • DOMCoreClasses.cpp: (DOMElement::style):
10:47 AM Changeset in webkit [20239] by brmorris
  • 2 edits in S60/trunk/WebKit

spadma, reviewed by <yongjun>

DESC: Prevent unnecessary redraws.
​http://bugs.webkit.org/show_bug.cgi?id=13093
TSW ID: RCHI-6Z2V49

10:45 AM Changeset in webkit [20238] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

yinxcai, reviewed by <Yongjun>

DESC: TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly
​http://bugs.webkit.org/show_bug.cgi?id=12901

7:33 AM Changeset in webkit [20237] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan.
DESC: [S60] ESMS-6YDMWP: TRUE - GSM - broswer crashes on certain web pages
Quick fix to validate null pointers
​http://bugs.webkit.org/show_bug.cgi?id=13074

5:40 AM Changeset in webkit [20236] by lars
  • 2 edits in trunk/WebCore

don't use #import in .cpp files.

5:36 AM Changeset in webkit [20235] by lars
  • 6 edits in trunk

Fix the Qt build once again.

2:52 AM Changeset in webkit [23093] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/PasteboardWin.cpp

Fix boomer build bustage.

Mar 15, 2007:

11:52 PM Changeset in webkit [20234] by bdash
  • 3 edits in trunk/WebCore

2007-03-15 Shrikant Gangoda <​shrikant.gangoda@celunite.com>

Gdk build fix.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::blockedError):
  • loader/gdk/FrameLoaderClientGdk.h:
11:50 PM Changeset in webkit [20233] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13088 REGRESSION
(r19761-19779): Copy image no longer includes image address
(rdar://5067927)

writeURL() does not need an isImage parameter. Now that it accepts
the types as a parameter, we can just declare the appropriate image
types within writeImage and send them to writeURL(). Also,
declaring the types twice is what broke this.

  • platform/Pasteboard.h:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage):
11:18 PM Changeset in webkit [20232] by adele
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker.

Fix for <rdar://problem/4926179> Text in menulist control should never update if menu is open

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Only setTextFromOption if the menu isn't visible.
10:36 PM Changeset in webkit [23092] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Ada.

Fixing some leaks

  • WebFrame.cpp: (WebFrame::dispatchDidReceiveAuthenticationChallenge): (WebFrame::dispatchDidCancelAuthenticationChallenge):
10:31 PM Changeset in webkit [23091] by beidson
  • 4 edits in branches/WindowsMerge

WebKitWin:

Reviewed by Oliver

CFNetwork related cleanup that was a work around for previous deficiencies in CFURLDownload
This might fix some of the random crashers we see on stress testing if they end up
downloading links.

  • WebDownload.cpp: (WebDownload::init): Release the connection from the handle so it no longer refers to it

WebCoreWin:

Reviewed by Oliver

CFNetwork related cleanup that was a work around for previous deficiencies in CFURLDownload
This might fix some of the random crashers we see on stress testing if they end up
downloading links.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): Always call cancel if theres a connection - the ref-count-check hack is no longer neccesary (WebCore::ResourceHandle::releaseConnectionForDownload): Give up the CFURLConnection without derefing it


10:25 PM Changeset in webkit [20231] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Oliver

A few platform specific tweaks

  • platform/cf/RetainPtr.h: (WebCore::RetainPtr::releaseRef): Fixed releaseRef to work with CF


  • platform/network/ResourceHandle.h: Added a "releaseRef" style call
10:25 PM Changeset in webkit [20230] by mjs
  • 2 edits in trunk/JavaScriptCore

Not reviewed.


  • build fix
  • wtf/TCSystemAlloc.cpp:
10:22 PM Changeset in webkit [23090] by mjs
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff and Steve.


  • fixed <rdar://problem/5029776> iBench JavaScript test slower than Opera
  • fixes to use FastMalloc on Windows
  • config.h: Don't force USE_SYSTEM_MALLOC

WebKitWin:

Reviewed by Geoff and Steve.


  • fixed <rdar://problem/5029776> iBench JavaScript test slower than Opera
  • fixes to use FastMalloc on Windows
  • WebKit.vcproj/WebKit.def: Add exports of WTF symbols.
  • WebKit.vcproj/WebKit_debug.def: ditto
  • WebKit.vcproj/WebKit.vcproj: Link pthreads, now needed by WTF.
10:12 PM Changeset in webkit [20229] by mjs
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff and Steve.


  • fix some portability issues with TCMalloc.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • kjs/config.h:
  • wtf/FastMalloc.cpp: (WTF::SizeClass): (WTF::InitSizeClasses): (WTF::TCMalloc_PageHeap::Split): (WTF::TCMalloc_PageHeap::RegisterSizeClass): (WTF::TCMalloc_Central_FreeList::length): (WTF::TCMalloc_ThreadCache::InitTSD): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
  • wtf/TCSpinLock.h:
  • wtf/TCSystemAlloc.cpp: (TryVirtualAlloc): (TCMalloc_SystemAlloc):

WebCore:

Reviewed by Geoff and Steve.

  • config.h: Remove unneeded hack.
9:45 PM Changeset in webkit [23089] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Alice


Due to OpenSource r20178, all of the sudden we were trying to handle page caching on Windows
even though it is not hooked up yet. The resulted in very particular cases ending up calling
clear() in FrameLoader::provisionalLoadStarted(). One such particular case was if a page *would*
be "cachable" (no frames, no passwords, etc etc), and you start a download from that page.


The fix for now is to manually set the pageCacheSize to 0 whenever we create new pages on Windows.
This prevents the "Should I cache this page?" checking from getting far enough to clear the document.
It so happens this involves exactly one line.


  • WebView.cpp: (WebView::initWithFrame): Set page cache size to zero on new pages, and add a fixme to remove later
9:22 PM Changeset in webkit [20228] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/5062376>
REGRESSION: In Mail and Gmail, can't change alignment to text after it has been applied

  • editing/execCommand/5062376-expected.checksum: Added.
  • editing/execCommand/5062376-expected.png: Added.
  • editing/execCommand/5062376-expected.txt: Added.
  • editing/execCommand/5062376.html: Added.

WebCore:

Reviewed by john


<rdar://problem/5062376>
REGRESSION: In Mail and Gmail, can't change alignment to text after it has been applied


Bring back the remove step in applyBlockStyle. It's
necessary because addBlockStyleIfNeeded assumes that
the properties it adds aren't already on the block that
it adds them to.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Bring back the remove step (added a testcase). Don't do the add step if m_removeOnly is true (no testcase because there aren't any clients using removeOnly functionality to remove styles yet, only styled elemets). Moved the code for creating new blocks up one level to this function so that we can pass blocks to removeCSSStyle. When converting VisiblePositions to indices and vice versa, use the highest node in the shadow tree if we're in one as the scope (working on a testcase). (WebCore::ApplyStyleCommand::addBlockStyle): Moved code to applyBlockStyle.
  • editing/ApplyStyleCommand.h:
8:16 PM Changeset in webkit [23088] by beidson
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej

<rdar://problem/4429701>
Implements a port blocking black list that matches Firefox's


  • Interfaces/IWebError.idl: Add the custom error code for blocked error
  • WebFrame.cpp: (WebFrame::blockedError): FrameLoaderClient fill-in + a Fixme (WebFrame::interruptForPolicyChangeError): Add a Fixme for localization
  • WebFrame.h:
8:12 PM Changeset in webkit [20227] by beidson
  • 17 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adele

<rdar://problem/4429701>
Implements a port blocking black list that matches Firefox's

The layout test attempts to load an image at an invalid domain name on each
of the black listed ports. Using dumpResourceLoadCallbacks(), DRT is able
to see the error codes for each resource. A successful test shows the blocked
error for each image load except for the few that are standard or should
succeed due to exemptions.

  • security/block-test-expected.txt: Added.
  • security/block-test.html: Added.

WebCore:

Reviewed by Maciej

<rdar://problem/4429701>
Implements a port blocking black list that matches Firefox's

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::blockedError): Call through to the client for blockedError
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h: Get the "port blocked" error for the current platform
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::wasBlocked): ResourceHandleClient method to pass on the didFail(error) (WebCore::ResourceLoader::blockedError): Following the pattern of "CancelledError()", get the error to fail with for the didFail() call
  • loader/ResourceLoader.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::blockedError): Added stub
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): If the port is blocked, create the handle but schedule it for deferred failure on a timer (WebCore::ResourceHandle::scheduleBlockedFailure): Do the timer scheduling (WebCore::ResourceHandle::fireBlockedFailure): Fire the timer here (WebCore::ResourceHandle::portAllowed): Implements checking of Mozilla's
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::wasBlocked): Virtual for clients to get the "blocked" message

WebKit:

Reviewed by Maciej

<rdar://problem/4429701>
Implements a port blocking black list that matches Firefox's

  • English.lproj/Localizable.strings: Added localizable string for port blocked error code
  • Misc/WebKitErrors.h:
  • Misc/WebKitErrors.m: (registerErrors): Add new port blocked error code to WebKitErrorDomain
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::cancelledError): Fixed coding style (WebFrameLoaderClient::blockedError): Return a ResourceError with the new custom error code
6:16 PM Changeset in webkit [20226] by thatcher
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Yet another build fix.

5:55 PM Changeset in webkit [20225] by thatcher
  • 8 edits in trunk

Finally a real build fix.

5:37 PM Changeset in webkit [20224] by thatcher
  • 1 edit in trunk/JavaScriptGlue/JavaScriptGlue.h

Yet another build fix. Sigh.

5:33 PM Changeset in webkit [23087] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Ada.

Second part of two-step dance to rename AHEM.TTF to AHEM.ttf.

This is to work around <rdar://problem/5063416>.

Also made all the ttf files in DumpRenderTree/Resources executable again to appease Windows.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/AHEM.ttf: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/renameMe.ttf: Removed.
5:25 PM Changeset in webkit [20223] by thatcher
  • 1 edit in trunk/JavaScriptGlue/Configurations/JavaScriptGlue.xcconfig

Another build fix attempt.

5:15 PM Changeset in webkit [20222] by thatcher
  • 1 edit in trunk/JavaScriptCore/Configurations/JavaScriptCore.xcconfig

Attempt to fix the build.

5:07 PM Changeset in webkit [20221] by thatcher
  • 4 edits in trunk

Build fix.

5:04 PM Changeset in webkit [20220] by bdakin
  • 4 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5065396> REGRESSION: leaks in
RenderBlock::layoutInlineChildren seen on buildbot

This leak appeared after ​http://trac.webkit.org/projects/webkit/
changeset/20188. This change shifted line boxes around in
removeChild(). But since removeChild() calls
setNeedsLayoutAndMinMaxRecalc(), all of the line boxes will be
removed once we actually lay out anyway. So this patch fixes the
leak by deleting the line boxes instead of shifting them around.

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): Call into updateLayout(). This fixes an assertion I got in editing/ execCommand/4976800.html This is very similar to the line box fix I made recently (​http://trac.webkit.org/projects/webkit/changeset/ 20177). We need to update layout before relying on VisiblePositions after removing a node.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::deleteLinesForBlock): New helper function since this functionality is needed in three places now. (WebCore::RenderBlock::makeChildrenNonInline): Call into new deleteLinesForBlock(). (WebCore::RenderBlock::removeChild): Same.
  • rendering/RenderBlock.h:
4:50 PM Changeset in webkit [20219] by thatcher
  • 14 edits
    20 adds in trunk

JavaScriptCore:

Reviewed by John.

  • Factored out most of our common build settings into .xcconfig files. Anything that was common in each build configuration was factored out into the shared .xcconfig file.
  • Adds a Version.xcconfig file to define the current framework version, to be used in other places.
  • Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
  • Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/JavaScriptCore.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Info.plist:
  • JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

Reviewed by John.

  • Factored out most of our common build settings into .xcconfig files. Anything that was common in each build configuration was factored out into the shared .xcconfig file.
  • Adds a Version.xcconfig file to define the current framework version, to be used in other places.
  • Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
  • Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/JavaScriptGlue.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Info.plist:
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by John.

  • Factored out most of our common build settings into .xcconfig files. Anything that was common in each build configuration was factored out into the shared .xcconfig file.
  • Adds a Version.xcconfig file to define the current framework version, to be used in other places.
  • Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
  • Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Configurations/WebCore.xcconfig: Added.
  • Info.plist:
  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by John.

  • Fixes: <rdar://problem/4927747> WebKit's Current Library Version number should match the Info.plist Version
  • Factored out most of our common build settings into .xcconfig files. Anything that was common in each build configuration was factored out into the shared .xcconfig file.
  • Adds a Version.xcconfig file to define the current framework version, to be used in other places.
  • Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
  • Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
  • Make WebKit use the same warning flags as the other projects. This required two casts to be added to fix new warnings.
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Configurations/WebKit.xcconfig: Added.
  • Info.plist:
  • Misc/WebKitVersionChecks.h:
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
  • WebKit.xcodeproj/project.pbxproj:
4:33 PM Changeset in webkit [23086] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

4:30 PM Changeset in webkit [20218] by sfalken
  • 1 copy in tags/Safari-521.35.9b

New tag.

3:25 PM Changeset in webkit [23085] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Ada.

First part of a two-step dance to rename AHEM.TTF to AHEM.ttf.

First, rename AHEM.TTF to renameMe.ttf.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/AHEM.TTF: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/renameMe.ttf: Added.
3:20 PM Changeset in webkit [23084] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Rubberstamped by Hyatt.

  • platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit): Move the code to get the font face to the top of the function for easier debugging.
  • platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): ASSERT that we got a valid CGFontRef back from CG, as CG and GDI should agree on the fonts installed.
2:42 PM Changeset in webkit [23083] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Adele.

  • Skipped: Turn off AppleScript tests.
2:37 PM Changeset in webkit [23082] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Brady.

  • WebKitLogging.cpp: Turn of Download logging by default.
2:28 PM Changeset in webkit [20217] by kdecker
  • 5 edits in trunk/WebKit

Reviewed by Anders.

Fixed: <rdar://problem/5001428> stationery background images do not display


Change 19244 fixed the method -[WebResource _shouldIgnoreWhenUnarchiving], but also broke Mail stationery.


The problem was that with archivedResourceForURL now fixed, the engine will try to decode the images. These images wouldn't decode because
Mail re-encodes and directly manipulates the image data in such a way that prevented WebKit from decoding the image. Because Mail was giving
us bad data, the images wouldn't render. This was never an issue before because archivedResourceForURL (broken) always returned nil, thus the
engine would never attempt to decode the resource, therefore the responsibility was delegated to Mail's protocol handler, which would do the
right thing and load the image.


Since Mail is relying on the fact it can store arbitrary data in WebArchives, I've introduced SPI that acts as a hint for us to ignore certain
subresources while unarchiving. This SPI is -[WebResource _shouldIgnoreWhenUnarchiving].


  • WebView/WebResource.mm: Addd private ivar shouldIgnoreWhenUnarchiving. (-[WebResource _ignoreWhenUnarchiving]): Added. (-[WebResource _shouldIgnoreWhenUnarchiving]): Added.
  • WebView/WebResourcePrivate.h: Added two methods to private header.
  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]): Check if we should ignore the resource.
1:51 PM Changeset in webkit [23081] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Anders.

  • Skipped: Added editing, http, and webarchive directories since they all rely on unimplemented parts of DRT, boomer-run-webkit-tests, and WebKit, respectively. Also re-enabled tests that no longer crash.
1:20 PM Changeset in webkit [20216] by kjk
  • 4 edits in trunk/WebCore

Not reviewed - gdk build fixes.

  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::handleKeypress):
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::loadPlatformResource):
12:12 PM Changeset in webkit [20215] by justing
  • 29 edits in trunk

LayoutTests:

Reviewed by john

Removed an unnecessary block (one that was fully
selected but whose markup wasn't needed to preserve
appearance):

  • editing/pasteboard/paste-text-011-expected.txt: Removed unnecessary style spans:
  • editing/pasteboard/merge-end-blockquote-expected.txt: Removed unnecessary empty anonymous blocks:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt: Now (correctly) includes fully selected root:
  • editing/pasteboard/paste-text-015-expected.checksum:
  • editing/pasteboard/paste-text-015-expected.png:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt: Demonstrates a bug that already existed (we don't inline the font styles from the Preference Pane on copy):
  • editing/pasteboard/5027857-expected.checksum:
  • editing/pasteboard/5027857-expected.png:
  • editing/pasteboard/5027857-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.checksum:
  • editing/pasteboard/paste-pre-002-expected.png:
  • editing/pasteboard/paste-pre-002-expected.txt:

WebCore:

Reviewed by john


~2x speed up of 5k rich text paste:
​http://shakespeare.mit.edu/hamlet/full.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Remove the top level style span if its unnecessary before inserting into the document, its faster than doing it after.
  • editing/ReplaceSelectionCommand.h: Exposed ReplacementFragment::removeNodePreservingChildren so that the style span can be removed using non-undoable removes, like the rest of the removes done on the ReplacementFragment.
  • editing/markup.cpp: (WebCore::createMarkup): Make the style span the top level element, otherwise it's useless. This also facilitates the optimization mentioned above. When including markup for a fully selected root, include markup for all the nodes beneath that fully selected root, to preserve the structure and appearance of the copied markup. Did this by merging with the code for adding markup for descendants of special commonAncestorBlocks.
12:07 PM Changeset in webkit [20214] by bdakin
  • 19 edits
    2 deletes in trunk

Rubber-stamped by Adele.

Rolling out ​http://trac.webkit.org/projects/webkit/changeset/20148
(which is a fix for ​http://bugs.webkit.org/show_bug.cgi?id=12595
and rdar://4722863) because it causes a horrible memory-trasher.

6:26 AM Changeset in webkit [20213] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-03-16 Shrikant Gangoda <​shrikant.gangoda@celunite.com>

Gdk build fix.

  • kjs/DateMath.cpp: gettimeofday comes from <sys/time.h> on Linux.
5:15 AM Changeset in webkit [20212] by bdash
  • 2 edits in trunk/WebKit

2007-03-15 Mark Rowe <​mrowe@apple.com>

Reviewed by Antti.

Fix for <rdar://problem/5065060> ASSERTION FAILURE: newUsername && newPassword
when submitting an authentication form without password.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): Don't omit form fields with empty values from the dictionary passed to the delegate.
12:11 AM Changeset in webkit [20211] by ggaren
  • 2 edits in trunk/WebCore

Added an assert to help catch a bug. Hopefully someone will hit it!


  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
12:07 AM Changeset in webkit [23080] by adachan
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-03-14 Ada Chan <​adachan@apple.com>

Reviewed by Lou.

<rdar://4966656> dragging scrollbar thumb in suggestion window does not work
<rdar://5056925> Should be able to select items from autocomplete list with the mouse
Added some tricks to get mouse clicking to work in auto-complete windows without
them going away.

WebKitWin:

Added a method in IWebViewPrivate to clear the current focus node. This is called in the app
when focus has been transferred to the address field or search field.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::clearFocusNode):
  • WebView.h:

Mar 14, 2007:

11:42 PM Changeset in webkit [20210] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Dave Hyatt.

Don't add the data twice, it's also done by didReceiveData.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::deliverArchivedResources):
11:30 PM Changeset in webkit [20209] by oliver
  • 3 edits
    2 adds in trunk

2007-03-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Adele.

Fix for rdar://problem/5061737.


This was a regression from the original Objective-C -> C++ conversion
for the drag logic. We don't need to call Range::startNode as we just
need the document that contains the range.

  • page/DragController.cpp: (WebCore::documentFragmentFromDragData):

LayoutTests:

Layout tests for rdar://problem/5061737

  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe.html: Added.
10:07 PM Changeset in webkit [23079] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Rubberstamped by Anders.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize done to false just like Mac does.
9:59 PM Changeset in webkit [20208] by andersca
  • 2 edits in trunk/WebKit

Fix segmentation fault when running layout tests.

Remove bogus check that that I added on purpose to see how good Geoff is at spotting mistakes when reviewing code.
(Turns out he's not that good!)


  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::increaseLoadCount):
9:58 PM Changeset in webkit [23078] by aroben
  • 8 edits in branches/WindowsMerge/WebKitTools

Fixed line-endings and svn properties on DRT files.

9:55 PM Changeset in webkit [23077] by aroben
  • 6 edits in branches/WindowsMerge/WebKitTools

Reviewed by Anders.

Make DRT on Windows behave more like DRT on Mac with respect to
waitUntilDone()/waitUntilDone().

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added "done" and "topLoadingFrame" globals to match Mac, removed readyToDump. (dump): Set done to true. (runTest): Removed readyToDump, initialized topLoadingFrame.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declarations for globals.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (notifyDoneCallback): Changed condition to match Mac.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didStartProvisionalLoadForFrame): Set topLoadingFrame. (WaitUntilDoneDelegate::locationChangeDone): Ported from Mac. (WaitUntilDoneDelegate::didFinishLoadForFrame): Call locationChangeDone. (WaitUntilDoneDelegate::didFailLoadWithError): Ditto.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Moved implementation of didFailLoadWithError to .cpp file.
9:09 PM Changeset in webkit [20207] by kmccullo
  • 2 edits in trunk/WebKitSite

Reviewed by .

Silly wrapping change for testing a post-commit hook change.

  • contact.html:
9:00 PM Changeset in webkit [20206] by andersca
  • 3 edits in trunk/WebKit

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=13076
REGRESSION: Multiple loading tabs cause assertion in WebDocumentLoaderMac::decreaseLoadCount(unsigned long)

Store the identifier set in the document loader since identifiers are per-webview and not global.


  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac): (WebDocumentLoaderMac::attachToFrame): (WebDocumentLoaderMac::increaseLoadCount): (WebDocumentLoaderMac::decreaseLoadCount):
8:42 PM Changeset in webkit [20205] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by .

  • Fixed one more build breakage
  • kjs/date_object.cpp: (KJS::formatLocaleDate):
8:23 PM Changeset in webkit [20204] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by .

  • Fixed a build breakage.
  • kjs/DateMath.cpp:
  • kjs/date_object.cpp: (KJS::formatLocaleDate): (KJS::DateObjectImp::construct):
7:21 PM Changeset in webkit [20203] by kmccullo
  • 13 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

  • rdar://problem/5045720
  • DST changes in US affect JavaScript date calculations (12975) This fix was to ensure we properly test for the new changes to DST in the US. Also this fixes when we apply DST, now we correctly map most past years to current DST rules. We still have a small issue with years before 1900 or after 2100. rdar://problem/5055038
  • kjs/DateMath.cpp: Fix DST to match spec better. (KJS::getCurrentUTCTime): (KJS::mimimumYearForDST): (KJS::maximumYearForDST): (KJS::equivalentYearForDST): (KJS::getDSTOffset):
  • kjs/DateMath.h: Consolodated common funtionality.
  • kjs/date_object.cpp: Consolodated common functionality. (KJS::formatLocaleDate): (KJS::DateObjectImp::construct):
  • tests/mozilla/ecma/jsref.js: Added functions for finding the correct days when DST starts and ends.
  • tests/mozilla/ecma/shell.js: Added back in the old DST functions for ease of merging with mozilla if needed.
  • tests/mozilla/ecma_2/jsref.js: Added functions for finding the correct days when DST starts and ends.
  • tests/mozilla/ecma_3/Date/shell.js: Added functions for finding the correct days when DST starts and ends.
  • tests/mozilla/expected.html: Updated to show all date tests passing.

LayoutTests:

Reviewed by Geoff.

  • rdar://problem/5045720
  • DST changes in US affect JavaScript date calculations (12975) Changed layout tests to properly check for the new changes to DST in the US. Also these now test that equivalent years return the same results for DST.
  • fast/js/date-DST-time-cusps-expected.txt:
  • fast/js/date-big-setdate-expected.txt:
  • fast/js/resources/date-DST-time-cusps.js:
  • fast/js/resources/date-big-setdate.js:
6:36 PM Changeset in webkit [20202] by weinig
  • 3 edits
    5 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • test for://bugs.webkit.org/show_bug.cgi?id=13071 REGRESSION: Plain text files no longer wrap lines longer than the width of the browser window
  • fast/loader/resources/text-document-wrapping.txt: Added.
  • fast/loader/text-document-wrapping-expected.checksum: Added.
  • fast/loader/text-document-wrapping-expected.png: Added.
  • fast/loader/text-document-wrapping-expected.txt: Added.
  • fast/loader/text-document-wrapping.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/loader/text-document-wrapping.html

  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write): Specified word-wrap:break-word for the <pre> element.
6:22 PM Changeset in webkit [20201] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/5009625> REGRESSION: Aperture 1.5: Can't select entire line of text after correcting a misspelled word

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection):
  • WebCoreSupport/WebFrameBridge.mm: Provide compatibility by not sending WebViewDidChangeSelectionNotification if the app is Aperture and is linked against WebKit 2.0.
6:22 PM Changeset in webkit [20200] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/text/whitespace/pre-wrap-last-char-expected.checksum: Added.
  • fast/text/whitespace/pre-wrap-last-char-expected.png: Added.
  • fast/text/whitespace/pre-wrap-last-char-expected.txt: Added.
  • fast/text/whitespace/pre-wrap-last-char.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/text/whitespace/pre-wrap-last-char.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Undid the change from r15617.
5:31 PM Changeset in webkit [23076] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Ada.

Allow empty commands to be sent by doTextFieldCommandFromEvent. Our autocomplete code relies on this.

  • WebEditorClient.cpp: (WebEditorClient::doTextFieldCommandFromEvent):
5:28 PM Changeset in webkit [20199] by hyatt
  • 2 edits in trunk/WebCore

Add asserts to help catch double refs and double derefs of CachedResources.

Reviewed by mjs

  • loader/CachedResource.cpp: (WebCore::CachedResource::ref): (WebCore::CachedResource::deref):
4:40 PM Changeset in webkit [20198] by aliceli1
  • 2 edits in trunk/WebCore

Rubber-stamped by Hyatt.

Adding null check to prevent the crash that happens on 2nd run of iBench HTML load test

  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase):
3:45 PM Changeset in webkit [23075] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Use CFURLResponseCopySuggestedFilename.


  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::suggestedFilenameForResponse):
2:49 PM Changeset in webkit [23074] by aroben
  • 6 edits in branches/WindowsMerge/WebKitTools

Reviewed by Anders.

Use Mac fonts when running regression tests to match Mac's metrics.

This makes many layout tests pass when run against results generated on the Mac.

2:47 PM Changeset in webkit [20197] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5062898> REGRESSION: autocomplete window in text fields doesn't come up

When we moved the initialization of a bunch of variables in the HTMLFormElement constructor, m_autocomplete accidently got initialized to false.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement):
2:45 PM Changeset in webkit [20196] by sfalken
  • 2 edits in trunk/WebCore

2007-03-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Added missing null check in case this is called on a subframe
that hasn't started loading.

  • page/Frame.cpp: (WebCore::Frame::setMarkedTextMatchesAreHighlighted): Check for a null document.
2:43 PM Changeset in webkit [20195] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/5058714>
​http://bugs.webkit.org/show_bug.cgi?id=13050


World leaks seen on Leopard after opening then closing tab (13050)

Add a hash set to prevent the load count to be increased twice for the same resource.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading):
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (loadingResources): (WebDocumentLoaderMac::increaseLoadCount): (WebDocumentLoaderMac::decreaseLoadCount):
2:43 PM Changeset in webkit [23073] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou, Adam.

<rdar://problem/5050470> Reproducible crash doing find on page at cnn.com


Add frame->document() null checks in cases where frame could be a
sub-frame that hasn't started loading yet.

  • WebView.cpp: (WebView::rectsForTextMatches): Add null check
1:53 PM Changeset in webkit [23072] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Use CG to get xHeight.

  • platform/win/FontDataWin.cpp: (WebCore::scaleEmToUnits): Made robust against divide-by-zero errors. (WebCore::FontData::platformInit): Ported Mac code to get xHeight using CG.
1:38 PM Changeset in webkit [20194] by antti
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=13060
REGRESSION: Repro ASSERT failure in Cache::adjustSize running layout tests
<rdar://5060208>


Script evaluation may have dereffed the CachedScript object already, causing double deref and
eventually m_liveResourcesSize underflow.

  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::notifyFinished):
1:32 PM Changeset in webkit [20193] by adele
  • 7 edits in trunk

WebCore:

Reviewed by Darin.

Added InsertTab, InsertBacktab, InsertLineBreak, and InsertNewline to the editing command table.
Added Event parameter to execCommand, and to all of the enabled and exec functions. Right now,
the event is only used by the newly added commands. But in the future, many (and possibly all) of
these editing commands will need to consider the event so they are applied to the correct selection.

  • WebCore.exp:
  • editing/Editor.cpp: (WebCore::execCopy): (WebCore::execCut): (WebCore::execDelete): (WebCore::execBackwardDelete): (WebCore::execForwardDelete): (WebCore::execMoveBackward): (WebCore::execMoveBackwardAndModifySelection): (WebCore::execMoveUpByPageAndModifyCaret): (WebCore::execMoveDown): (WebCore::execMoveDownAndModifySelection): (WebCore::execMoveForward): (WebCore::execMoveForwardAndModifySelection): (WebCore::execMoveDownByPageAndModifyCaret): (WebCore::execMoveLeft): (WebCore::execMoveLeftAndModifySelection): (WebCore::execMoveRight): (WebCore::execMoveRightAndModifySelection): (WebCore::execMoveToBeginningOfDocument): (WebCore::execMoveToBeginningOfDocumentAndModifySelection): (WebCore::execMoveToBeginningOfSentence): (WebCore::execMoveToBeginningOfSentenceAndModifySelection): (WebCore::execMoveToBeginningOfLine): (WebCore::execMoveToBeginningOfLineAndModifySelection): (WebCore::execMoveToBeginningOfParagraph): (WebCore::execMoveToBeginningOfParagraphAndModifySelection): (WebCore::execMoveToEndOfDocument): (WebCore::execMoveToEndOfDocumentAndModifySelection): (WebCore::execMoveToEndOfSentence): (WebCore::execMoveToEndOfSentenceAndModifySelection): (WebCore::execMoveToEndOfLine): (WebCore::execMoveToEndOfLineAndModifySelection): (WebCore::execMoveToEndOfParagraph): (WebCore::execMoveToEndOfParagraphAndModifySelection): (WebCore::execMoveParagraphBackwardAndModifySelection): (WebCore::execMoveParagraphForwardAndModifySelection): (WebCore::execMoveUp): (WebCore::execMoveUpAndModifySelection): (WebCore::execMoveWordBackward): (WebCore::execMoveWordBackwardAndModifySelection): (WebCore::execMoveWordForward): (WebCore::execMoveWordForwardAndModifySelection): (WebCore::execMoveWordLeft): (WebCore::execMoveWordLeftAndModifySelection): (WebCore::execMoveWordRight): (WebCore::execMoveWordRightAndModifySelection): (WebCore::execPaste): (WebCore::execSelectAll): (WebCore::execToggleBold): (WebCore::execToggleItalic): (WebCore::execRedo): (WebCore::execUndo): (WebCore::execInsertTab): (WebCore::execInsertBacktab): (WebCore::execInsertNewline): (WebCore::execInsertLineBreak): (WebCore::enabled): (WebCore::canPaste): (WebCore::hasEditableSelection): (WebCore::hasEditableRangeSelection): (WebCore::hasRangeSelection): (WebCore::hasRichlyEditableSelection): (WebCore::canRedo): (WebCore::canUndo): (WebCore::CommandEntry::): (WebCore::Editor::toggleBold):

(WebCore::Editor::execCommand): Added optional event parameter.
(WebCore::Editor::insertText): Added. Calls handleTextInputEvent.
(WebCore::Editor::insertTextWithoutSendingTextEvent): Renamed from insertText.

Performs the actual insertion without dispatching any event.

  • editing/Editor.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler): Call insertTextWithoutSendingTextEvent.

WebKit:

Reviewed by Darin.

Removed _insertTextWithEvent, _insertNewlineWithEvent, and _insertTextWithEvent.
Instead, use execCommand and insertText methods on the Editor.

  • WebView/WebHTMLView.mm: (-[WebHTMLView insertTab:]): (-[WebHTMLView insertBacktab:]): (-[WebHTMLView insertNewline:]): (-[WebHTMLView insertLineBreak:]): (-[WebHTMLView insertParagraphSeparator:]): (-[WebHTMLView insertNewlineIgnoringFieldEditor:]): (-[WebHTMLView insertTabIgnoringFieldEditor:]): (-[WebHTMLView yank:]): (-[WebHTMLView yankAndSelect:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
1:32 PM Changeset in webkit [23071] by adele
  • 6 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/5057371> REGRESSION: Shift-selection stopped working in text fields

This fixes doCommandBySelector to take a command string instead of a key code.

  • Interfaces/IWebEditingDelegate.idl: Changed parameter to BSTR.
  • Interfaces/IWebFormDelegate.idl: ditto.
  • WebEditorClient.cpp: (WebEditorClient::doTextFieldCommandFromEvent): Calls doCommandBySelector with a BString that it gets from interpretKeyEvent instead of a key code. (WebEditorClient::textWillBeDeletedInTextField): Calls doCommandBySelector with a BString to represent the BackwardDelete command. (WebEditorClient::handleKeypress): Calls handleEditingKeyboardEvent with just the KeyboardEvent.
  • WebView.cpp: Added commands that will be used by doCommandBySelector to the table (Cancel, InsertTab, InsertBacktab, InsertNewline). (WebView::interpretKeyEvent): Added. Returns a command string for a KeyboardEvent. Removed static editCommandForKey. (WebView::handleEditingKeyboardEvent): Call Editor methods instead of calling handleTextInputEvent directly.
  • WebView.h:
1:06 PM Changeset in webkit [20192] by justing
  • 1 edit in trunk/LayoutTests/fast/lists/drag-into-marker-expected.txt

I forgot to update this expected result in my previous checkin.

12:32 PM Changeset in webkit [20191] by justing
  • 26 edits in trunk

LayoutTests:

Reviewed by darin

Removed unnecessary style spans:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/execCommand/4916541-expected.txt:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/execCommand/format-block-with-braces-expected.txt:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/remove-list-from-range-selection-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:
  • editing/pasteboard/4861080-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • editing/pasteboard/paste-table-002-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:

WebCore:

Reviewed by darin


~3x speedup pasting 5k lines of rich text:
​http://shakespeare.mit.edu/hamlet/full.html
~2x speedup pasting 10k lines of plain text


  • css/CSSComputedStyleDeclaration.cpp: (WebCore::computedStyle): Added for convenience.
  • css/CSSComputedStyleDeclaration.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): The code that pushed down the top level style span had a bug in it that made it do unnecessary work. Instead of fixing the bug I removed the code because it was used to help see more redundancies in second level style spans, but createMarkup now *only* creates a top level style span. Only remove redundant styles from style spans and only remove unstyled elements if they are style spans. FF doesn't remove redundant styles from elements, or remove redundant font tags on copy/paste. We could offer this functionality through a separate "cleanup" command.
  • editing/markup.cpp: (WebCore::createMarkup): Only add markup for ancestors of lastClosed if we're including markup for acommonAncestorBlock (we do this for commonAncestorBlocks like tables and lists), otherwise it's unnecessary/redundant.
11:50 AM Changeset in webkit [20190] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Ada.

Make sure to call ResourceLoader::didReceiveData to ensure that there's a shared buffer with the resource
data, since SubresourceLoaderClients now make use of that buffer.


  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveData):
10:56 AM Changeset in webkit [23070] by andersca
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Build fixes.


  • platform/graphics/win/ImageWin.cpp: (WebCore::Image::loadPlatformResource):
  • platform/win/EditorWin.cpp:

WebKitWin:

Build fixes.


  • WebDataSource.cpp: (WebDataSource::subresourceForURL):
  • WebKitDLL.cpp: (loadResourceIntoBuffer):
10:38 AM Changeset in webkit [20189] by andersca
  • 3 edits in trunk/WebCore

Get the size from the shared buffer.


  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged):
10:25 AM Changeset in webkit [20188] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt, thumbs up by Darin.

  • fast/dynamic/anonymous-block-orphaned-lines-expected.checksum: Added.
  • fast/dynamic/anonymous-block-orphaned-lines-expected.png: Added.
  • fast/dynamic/anonymous-block-orphaned-lines-expected.txt: Added.
  • fast/dynamic/anonymous-block-orphaned-lines.html: Added.

WebCore:

Reviewed by Hyatt, thumbs up by Darin.

Test: fast/dynamic/anonymous-block-orphaned-lines.html

  • rendering/InlineBox.cpp: (WebCore::InlineBox::root): Added an assertion that we return a root inline box.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): Added code to adopt the line boxes of anonymous blocks being destroyed instead of leaving them orphaned, which is what caused this crash. The boxes will be deleted on the next layout, but this ensures consistency in the mean time.
6:38 AM Changeset in webkit [20187] by lars
  • 4 edits in trunk/WebCore

Reviewed by Antti.

Fix the Qt build.
Add a getter to SharedBuffer that returns a reference to the internal
Vector to avoid an extra copy of the data.

4:37 AM Changeset in webkit [20186] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.


Test case for <rdar://problem/5058774>
REGRESSION: In Mail, caret appears oversized when typing in a To Do note

  • editing/style/highlight-expected.checksum: Added.
  • editing/style/highlight-expected.png: Added.
  • editing/style/highlight-expected.txt: Added.
  • editing/style/highlight.html: Added.

WebCore:

Reviewed by Mitz.


Fix <rdar://problem/5058774>
REGRESSION: In Mail, caret appears oversized when typing in a To Do note


Horizontal and vertical were switched. Was regression from
​http://trac.webkit.org/projects/webkit/changeset/20103

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow):
4:02 AM Changeset in webkit [20185] by hyatt
  • 4 edits in trunk/WebCore

Tweak the data() functions of stylesheets and scripts to be internally consistent.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedScript.cpp: (WebCore::CachedScript::data):
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::data):
2:20 AM Changeset in webkit [20184] by hyatt
  • 3 edits in trunk/WebCore

Fix Radar 5050688.

For large animated GIFs, destroy and recreate the source for every animation frame. This keeps
the memory consumption down while giant images are animating.

Reviewed by andersca

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::dataChanged): (WebCore::BitmapImage::advanceAnimation):
  • platform/graphics/BitmapImage.h:
1:49 AM Changeset in webkit [20183] by hyatt
  • 3 edits in trunk/WebCore

Make sure to use CFDataCreateWithBytesNoCopy where we can.

Reviewed by andersca

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged):
1:07 AM Changeset in webkit [20182] by hyatt
  • 40 edits in trunk

WebCore:

Fix for bugzilla bug 13050 and also radar p1 5050645.

This patch reworks resource loading to avoid having redundant buffers in the icon database and in cached
images in the WebCore cache. It also avoids overcopying in top-level image documents and in the icon
database.

There is now only one SharedBuffer for a resource and everybody observes that buffer now instead of ever
making their own. Even ImageIO uses the SharedBuffer while decoding.

The page in 13050 dropped from 145mb down to 45mb of memory use with this change for a stunning savings
of 100mb.

Reviewed by olliej, mjs

  • WebCore.exp:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::data):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::data):
  • loader/CachedScript.cpp: (WebCore::CachedScript::data):
  • loader/CachedScript.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::data):
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::checkCacheObjectStatus):
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::writeRawData): (WebCore::ImageTokenizer::finish):
  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::setImageData): (WebCore::IconDataCache::writeToDatabase):
  • loader/icon/IconDataCache.h:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::imageDataForIconURLQuery):
  • loader/icon/IconDatabase.h:
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFail): (WebCore::IconLoader::finishLoading): (WebCore::IconLoader::clearLoadingState):
  • loader/icon/IconLoader.h:
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::getColumnBlobAsVector): (WebCore::SQLStatement::isExpired):
  • loader/icon/SQLStatement.h:
  • loader/loader.cpp: (WebCore::Loader::didFinishLoading): (WebCore::Loader::didReceiveData):
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
  • platform/SharedBuffer.h: (WebCore::SharedBuffer::isEmpty):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::dataChanged):
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.cpp: (WebCore::Image::setData):
  • platform/graphics/Image.h: (WebCore::Image::dataChanged): (WebCore::Image::data):
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged):
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/mac/ImageMac.mm: (WebCore::Image::loadPlatformResource):
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData):
  • platform/mac/PasteboardMac.mm: (WebCore::fileWrapperForImage):

WebKit:

Fixes to ensure that the resource loader's shared buffer can always be used.

Reviewed by olliej, mjs

  • Misc/WebIconDatabase.mm: (-[WebIconDatabase _convertToWebCoreFormat]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::deliverArchivedResources):

Mar 13, 2007:

10:37 PM Changeset in webkit [20181] by justing
  • 14 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5046875>
Gmail Editor: Applying alignment to selected text in message also applies alignment to signature

Added:

  • editing/style/5046875-1-expected.checksum: Added.
  • editing/style/5046875-1-expected.png: Added.
  • editing/style/5046875-1-expected.txt: Added.
  • editing/style/5046875-1.html: Added.
  • editing/style/5046875-2-expected.checksum: Added.
  • editing/style/5046875-2-expected.png: Added.
  • editing/style/5046875-2-expected.txt: Added.
  • editing/style/5046875-2.html: Added. moveParagraphs doesn't move unnecessary brs:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt: moveParagraphs clears out unrendered text during the move:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5046875>
Gmail Editor: Applying alignment to selected text in message also applies alignment to signature

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Don't call applyBlockStyle unless there is a block style to apply. (WebCore::ApplyStyleCommand::applyBlockStyle): Don't do the remove step. It was unnecessary and removed properties from blocks that could contain content outside the range being operated on (added a testcase). (WebCore::ApplyStyleCommand::addBlockStyleIfNeeded): Used an early return instead of if-nesting.
  • editing/ApplyStyleCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Return the new block, if one was created. Use moveParagraphs to move paragraphs into the new block, instead of moving nodes. The old code moved too much (added a testcase).
  • editing/CompositeEditCommand.h:
10:00 PM Changeset in webkit [20180] by oliver
  • 6 edits
    2 adds in trunk

2007-03-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady.

WebCore:

To fix <rdar://problem/5044366> we now pass a NSString
representation of the URL extracted with _web_originalDataAsString
instead of relying on [NSURL absoluteString] in the bridge

  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]):

WebKit:

Modify subresourceForURL to take NSString argument
so we can avoid [NSURL absoluteString]

  • WebView/WebDataSource.mm: (-[WebDataSource subresourceForURL:]):

LayoutTests:

Test for <rdar://problem/5044366> make sure we can create
a WebArchive from a page with a partially decoded url.

  • webarchive/archive-with-unencoded-url-expected.txt: Added.
  • webarchive/archive-with-unencoded-url.html: Added.
9:44 PM Changeset in webkit [20179] by beidson
  • 3 edits in trunk/WebKit

Rubberstamped by Alice

Meant to be part of my previous checkin... pruning unused code from WebKit

  • WebView/WebFrame.mm: Removed _canCachePage
  • WebView/WebFrameInternal.h: Ditto
8:59 PM Changeset in webkit [20178] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Anders

<rdar://problem/5048818> - REGRESSION: Incompletely loaded resources being saved to the object cache

Due to a subtle change in loader behavior back in 10904, we would stop all loaders before calling
didFail() on them in the Cache loader. As a result, we basically cleared all of the Subresource Loaders
out of the Cache loader before more properly failing them as errored out. The result? Partially loaded
resources being cached.


Since Loader::didFail() both calls error() on the object *and* removes the loader, the solution is to call
didFail() for all cancelled loaders instead of *only* removing them from the set of active loaders.


In addition, pages that didn't completely load were being saved to the back/forward cache. To fix that,
I added a null check on the DocumentLoader's error to see if the page ended in an error, or did indeed
completely load.

Note that the layout test for this - if possible - will require other enhancements including possibly adding
support for window.stop(). That task is documented in <rdar://problem/5061826>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): Fixed a few bugs relating to my original BFCache rewrite to more perfectly restore the original behavior - including only caching HTML documents via the m_client->canCachePage() call (WebCore::FrameLoader::canCachePage): Don't make the call to m_client->canCachePage() as that serves a different purpose
    • Check the mainDocumentError to see if the load ended in error as a further criteria in determining the cachability of a page
  • loader/loader.cpp: (WebCore::Loader::cancelRequests): Call didFail(cancelledError()) instead of just removing the loaders from the loaders-in-progress set. This adds the effect of properly cleaning up the cached object.
8:56 PM Changeset in webkit [20177] by bdakin
  • 6 edits
    4 adds in trunk

WebCore:

Rendering part reviewed by Hyatt. Editing part consulted with and
rubber stamped by Justin and Harrison.

Fix for <rdar://problem/5025925> A hang occurs in Safari when
attempting to print page at ​http://www.pcadvisor.co.uk

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): RenderBlock::makeChildrenNonInline() takes a block's inline children and turns them into block children. If the children had line boxes, those boxes were being leaked. In the layout test I added with the change (and at pcadvisor.co.uk during printing) children were being made non-inline, and then they were being made inline again. This meant that some of the children ended up pointing to totally stale line boxes that are normally just leaked. This caused an infinite loop in RenderFlow::destroy(). This patch simply deletes everyone's line boxes in RenderBlock::makeChildrenNonInline()
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): The other part of this fix is that I added a call to updateLayout in InsertParagraphSeparatorCommand::doApply(). One layout test (editing/spelling/spelling.html) was changed by my patch to RenderBlock. doApply() inserts a node into the render tree. In at least one case in spelling.html, that caused some line boxes to be deleted. Back in doApply() this meant that the RenderTree was out- of-date, and we mistakenly thought we were at the end of the paragraph. This caused us to insert a RenderBR() at the end of the tree instead of an empty RenderText(). No one seems to know exactly why we insert either, or if the change is necessarily a problem. It is clear, though, that the RenderTree in doApply() is out-of-date after inserting the node and deleting some line boxes, so it seems prudent to call into updateLayout().

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5025925> A hang occurs in Safari when
attempting to print page at ​http://www.pcadvisor.co.uk

  • fast/block/float/nestedAnonymousBlocks-expected.checksum: Added.
  • fast/block/float/nestedAnonymousBlocks-expected.png: Added.
  • fast/block/float/nestedAnonymousBlocks-expected.txt: Added.
  • fast/block/float/nestedAnonymousBlocks.html: Added.
7:42 PM Changeset in webkit [23069] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Anders.

  • platform/win/FontDataWin.cpp: (WebCore::scaleEmToUnits): Ported from FontDataMac. (WebCore::FontData::platformInit): Use CG for metrics, and apply Mac's line-height hack for Times, Helvetica, and Courier. (WebCore::FontData::platformWidthForGlyph): Call wkGetGlyphAdvances to use some CG SPI to match Mac.
7:37 PM Changeset in webkit [20176] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • platform/FontData.h: Added m_isSystemFont parameter to match NSFont.
5:39 PM Changeset in webkit [20175] by harrison
  • 3 edits in trunk/LayoutTests

<rdar://problem/5031181> cntl-k at end of paragraph adds nothing to the kill ring
<rdar://problem/5031189> REGRESSION: cntl-y yanks only the most recently killed content

Updated results.

  • editing/deleting/delete-to-end-of-paragraph-expected.checksum:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
4:55 PM Changeset in webkit [20174] by bdakin
  • 1 edit in trunk/WebCore/ChangeLog

typo fix. thanks aroben!

4:51 PM Changeset in webkit [20173] by bdakin
  • 4 edits in trunk

WebCore:

Reviewed by Maciej.

Export DocumentLoader::setFrame(). Part for fix for <rdar://
problem/4277074> 8F32: Help Viewer crashed on clicking link -
KHTMLView::viewportMouseReleaseEvent (12647)

  • WebCore.exp:

WebKit:

Reviewed by Maciej.

Fix for <rdar://problem/4277074> 8F32: Help Viewer crashed on
clicking link - KHTMLView::viewportMouseReleaseEvent (12647)

Re-set the DocumentLoader's frame when loading it from the page
cache before setting the document view.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromPageCache):
4:32 PM Changeset in webkit [23068] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

4:29 PM Changeset in webkit [20172] by sfalken
  • 1 copy in tags/Safari-521.35.8b

New tag.

4:25 PM Changeset in webkit [20171] by darin
  • 1 edit in trunk/WebCore/ChangeLog

of -> be

4:18 PM Changeset in webkit [20170] by darin
  • 6 edits
    12 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/canvas/canvas-hides-fallback-expected.txt: Added.
  • fast/canvas/canvas-hides-fallback.html: Added.
  • fast/canvas/script-inside-canvas-fallback-expected.txt: Added.
  • fast/canvas/script-inside-canvas-fallback.html: Added.
  • fast/canvas/unclosed-canvas-1-expected.txt: Added.
  • fast/canvas/unclosed-canvas-1.html: Added.
  • fast/canvas/unclosed-canvas-2-expected.txt: Added.
  • fast/canvas/unclosed-canvas-2.html: Added.
  • fast/canvas/unclosed-canvas-3-expected.txt: Added.
  • fast/canvas/unclosed-canvas-3.html: Added.
  • fast/canvas/unclosed-canvas-4-expected.txt: Added.
  • fast/canvas/unclosed-canvas-4.html: Added.

WebCore:

Reviewed by Maciej.

Change <canvas> elements so that their contents are parsed normally,
but not rendered. This change fixes the bug, because normal parsing
rules close the <canvas> element in that case. The special parser
stuff was just getting in the way.

Also do some basic cleanup to the HTML parser. This was motivated by
an earlier version of this patch that made even more changes to the
parser, but the cleanup is still worth landing.

Test: fast/canvas/canvas-hides-fallback.html
Test: fast/canvas/script-inside-canvas-fallback.html
Test: fast/canvas/unclosed-canvas-1.html
Test: fast/canvas/unclosed-canvas-2.html
Test: fast/canvas/unclosed-canvas-3.html
Test: fast/canvas/unclosed-canvas-4.html

  • html/HTMLCanvasElement.h: Added a data member to keep track of whether the renderer is a RenderHTMLCanvas or not.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createRenderer): If JavaScript is enabled, create a RenderHTMLCanvas. If it's not, let the default code create the default type of renderer, which will result in fallback content being visible. The RenderHTMLCanvas class already hides all of its children. Set the m_rendererIsCanvas boolean accordingly. Since the actual storage for the canvas is allocated lazily when you actually get a drawing context, we don't need to do anything special to prevent it when JavaScript is disabled; the relevant functions won't be called. (WebCore::HTMLCanvasElement::reset): Protect the code that manipulates the RenderHTMLCanvas with a check of m_rendererIsCanvas. This is the only code inside the DOM element that relies on the renderer type.
  • html/HTMLParser.h: Removed unneeded includes. Marked HTMLParser as Noncopyable. Changed the Document parameter to the constructor to instead of HTMLDocument. Renamed discard_until to m_skipModeTag for clarity. Removed unused noSpaces function and unneeded public doc() function. Moved data members all down to the end so you can see them together in order. Renamed map to m_currentMapElement and isindex to m_isindexElement. Removed unused end and headLoaded data members. Renamed m_fragment to m_isParsingFragment to make it clearer that it's a boolean, not a fragment.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): Changed to use member construction syntax instead of calling reset(). This is especially helpful in the fragment case, where calling reset() later on is illegal, so not using it in the constructor lets us assert. (WebCore::HTMLParser::~HTMLParser): Did an explicit deref instead of calling setCurrent for its side effect. (WebCore::HTMLParser::reset): Updated for member name changes and removal and to use document instead of doc(). (WebCore::HTMLParser::setCurrent): Use document instead of doc(). (WebCore::HTMLParser::setSkipMode): Added. No longer inline. Now sets the m_inCanvasBeforeFirstOpenTag data member to false. (WebCore::HTMLParser::parseToken): Tightened up the skip mode logic at the top of the function, and added a FIXME about the strange case there where we don't skip yet stay in skip mode. Updated for renaming and doc(). (WebCore::HTMLParser::insertNode): Updated for renaming and doc(). (WebCore::HTMLParser::handleError): Ditto. (WebCore::HTMLParser::framesetCreateErrorCheck): Ditto. (WebCore::HTMLParser::isindexCreateErrorCheck): Changed to use RefPtr. (WebCore::HTMLParser::noscriptCreateErrorCheck): Updated for renaming and doc(). (WebCore::HTMLParser::mapCreateErrorCheck): Ditto. (WebCore::HTMLParser::getNode): Removed the special case for canvas here. Canvas fallback is now handled in the DOM, not the parser. Updated for renaming and doc(). (WebCore::HTMLParser::allowNestedRedundantTag): Changed a #define into a C++ constant. (WebCore::HTMLParser::processCloseTag): Updated for renaming and doc(). (WebCore::HTMLParser::isInline): Ditto. (WebCore::HTMLParser::tagIsOnStack): Added. Used by new canvas logic. (WebCore::HTMLParser::popBlock): Updated for renaming and doc(). Also renamed the local variable Elem to elem. (WebCore::HTMLParser::createHead): Ditto. (WebCore::HTMLParser::handleIsindex): Changed to use RefPtr. (WebCore::HTMLParser::startBody): Updated for renaming and doc(). (WebCore::HTMLParser::finished): Ditto.
4:07 PM Changeset in webkit [20169] by hyatt
  • 3 edits in trunk/WebCore

Two more cleanup fixes to the cache. Don't call destroyDecodedData in the BitmapImage destructor, since
clearing the image source and calling setData on it again causes it to do an extra copy of the encoded
data. Since we're about to be destroyed this is just wasteful.

When the cache prunes, don't allow it to destroy the decoded data of an image that is still actively loading,
since we've established that ImageIO can actually crash if you yank the rug out from under it like that.

Reviewed by ggaren

  • loader/Cache.cpp: (WebCore::Cache::prune):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::~BitmapImage):
3:46 PM Changeset in webkit [20168] by andersca
  • 2 edits in trunk/WebCore

Try fixing the Qt build.


  • editing/Editor.h: (WebCore::Editor::setStartNewKillRingSequence):
3:40 PM Changeset in webkit [20167] by thatcher
  • 8 edits in trunk

Reviewed by Geoff.

<rdar://problem/5057117> Spoof user agent on Yahoo.com with Safari and WebKit as version 4xx

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView userAgent]): Stop using the deprecated lossyCString method.
  • WebCoreSupport/WebFrameBridge.mm: Removed dead code, userAgentForURL: wasn't used.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::userAgent): Call WebView's _userAgentForURL:.
  • WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): Call userAgentForURL: instead of _userAgent. (-[WebView userAgentForURL:]): Call _userAgentForURL:. (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): New method to construct a UA. (-[WebView _computeUserAgent]): Ractored out into _userAgentWithApplicationName:andWebKitVersion: (-[WebView _userAgentForURL:]): Tail compare for Yahoo.com, and return a UA with an older WebKit version.
  • WebView/WebViewInternal.h: Declare _userAgentForURL:.
3:31 PM Changeset in webkit [20166] by harrison
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

<rdar://problem/5031181> cntl-k at end of paragraph adds nothing to the kill ring
<rdar://problem/5031189> REGRESSION: cntl-y yanks only the most recently killed content

  • editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.png: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001.html: Added.

WebCore:

Reviewed by Justin.

<rdar://problem/5031181> cntl-k at end of paragraph adds nothing to the kill ring
<rdar://problem/5031189> REGRESSION: cntl-y yanks only the most recently killed content

For rdar://5031181, properly extend the selection before the killring handling, and
make sure plainText of that selection returns a linefeed.


For rdar://5031189, restore Editor::deleteRange() code that continued current killring,
even though the range deletion implicitly stopped it via changing the selection.


A byproduct of this change is the elimination of RUNDFINDER vs CONTENT TextIterator. The
only difference between the two was whether to emit a newline when the range started
with a blockflow element. No callers actually need that any more.

Tests added:

  • editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.png: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt: Added.
  • editing/pasteboard/emacs-ctrl-k-y-001.html: Added.
  • editing/Editor.cpp: (WebCore::Editor::deleteRange): Clear the "start new kill ring sequence" setting, because it was set to true when the selection was updated by deleting the range.


(WebCore::Editor::deleteWithDirection):
If extending the selection to the end of paragraph resulted in a caret selection,
extend by character, to handle the case when the selection started as a caret at
the end of paragraph.


  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Initialize new member variables for tracking handling of the beginning of the range.


(WebCore::TextIterator::advance):
Call representNodeOffsetZero on the m_endContainer.
Move visibility checks into handleTextNode and handleReplacedElement.


(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextBox):
Call emitText.


(WebCore::TextIterator::handleReplacedElement):
Moved visibility check into here.


(WebCore::shouldEmitNewlinesBeforeAndAfterNode):


(WebCore::TextIterator::shouldRepresentNodeOffsetZero):
(WebCore::TextIterator::representNodeOffsetZero):
New. Emits proper sequence when encountering offset 0 of a node, including the
m_endContainer. Started with code from handleNonTextNode.


(WebCore::TextIterator::handleNonTextNode):
Call representNodeOffsetZero.


(WebCore::TextIterator::exitNode):
Similar to shouldRepresentNodeOffsetZero, do not emit the newline if the node
was collapsed, and before any other emitted content.


(WebCore::TextIterator::emitCharacter):


(WebCore::TextIterator::emitText):
New. Consolidates code used by handleText and handleTextBox.


(WebCore::CharacterIterator::CharacterIterator):
Removed RUNFINDER.

(WebCore::WordAwareIterator::WordAwareIterator):
Removed RUNFINDER.


(WebCore::WordAwareIterator::advance):
Formatting.

(WebCore::TextIterator::rangeLength):
Formatting.


  • editing/TextIterator.h: Added member variables for tracking handling of the beginning of the range. Eliminated concept of RUNDFINDER vs CONTENT TextIterator.


  • editing/visible_units.cpp: (WebCore::nextBoundary): Eliminated concept of RUNDFINDER vs CONTENT TextIterator.
3:11 PM Changeset in webkit [20165] by hyatt
  • 2 edits in trunk/WebCore

Clean up the null image case in CachedImage::data to make sure the size totals will stay accurate.
I'm not convinced this case can even be hit, but I'm cleaning it up just in case.

  • loader/CachedImage.cpp: (WebCore::CachedImage::data):
3:10 PM Changeset in webkit [20164] by lars
  • 2 edits in trunk/LayoutTestResults

Add a test that currently crashes the Qt build.

3:03 PM Changeset in webkit [20163] by hyatt
  • 2 edits in trunk/WebCore

Reorder the call to allReferencesRemoved, since otherwise the live object size will become
incorrect.

  • loader/CachedResource.cpp: (WebCore::CachedResource::deref):
3:00 PM Changeset in webkit [20162] by lars
  • 2 edits in trunk/WebKitQt

Reviewed by George.

Don't try to load <object> tags with an invalid url.
Fixes LayoutTests/fast/dom/object-plugin-hides-properties.html
which hit an assertion in the frameloader.

2:57 PM Changeset in webkit [20161] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

brmorris, rs'd by sachin

DESC: merge of r20160 to s60's 3.1m branch. MLIO-6Y2BV3

2:54 PM Changeset in webkit [20160] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris, rubberstamped by sachin

DESC: Content change for SCM sync MLIO-6Y2BV3

  • BrowserView/src/LoadListeners.cpp: copyright update
2:41 PM Changeset in webkit [20159] by antti
  • 3 edits
    6 adds in trunk

LayoutTests:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=11083
REGRESSION: Typing tab key fails to insert a tab character in Google Docs editable area
<rdar://problem/4757650>

  • editing/inserting/typing-tab-designmode-expected.txt: Added.
  • editing/inserting/typing-tab-designmode-forms-expected.checksum: Added.
  • editing/inserting/typing-tab-designmode-forms-expected.png: Added.
  • editing/inserting/typing-tab-designmode-forms-expected.txt: Added.
  • editing/inserting/typing-tab-designmode-forms.html: Added.
  • editing/inserting/typing-tab-designmode.html: Added.

WebCore:

Reviewed by Darin.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=11083
REGRESSION: Typing tab key fails to insert a tab character in Google Docs editable area
<rdar://problem/4757650>


Allow inserting tabs in designMode. Backtab behaves like before (matches FF).

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTabEventHandler):
2:31 PM Changeset in webkit [20158] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fixes builds using buildit.

1:25 PM Changeset in webkit [20157] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by .

  • Adding expected failures until the are truly fixed.
  • rdar://problem/5060302
  • tests/mozilla/expected.html:
1:18 PM Changeset in webkit [20156] by hyatt
  • 2 edits in trunk/WebCore

Fix two counting errors in the decoded size of objects in the WebCore cache. We need to explicitly
destroy decoded data when clearing out a partially loaded image that had an error, since the destructor
(although it does destroy the data) disconnects the observer so that the notification doesn't happen.

Some CachedImages aren't in the cache (like image documents). When the decoded size of such an image
changes we should not notify the cache, since - newsflash - we aren't actually in it.

Reviewed by ggaren

  • loader/CachedImage.cpp: (WebCore::CachedImage::clear): (WebCore::CachedImage::decodedSizeChanged):
1:06 PM Changeset in webkit [20155] by brmorris
  • 2 edits in S60/trunk/WebKit

spaltis, reviewed by padmae

DESC: 3.2 IDO: Got Error message for Non-Drm downloads: TSW HLUU-6YUVE6
Fix: Removal of old code to prevent setting HTTP Request Accept Header in case of WML page.
​http://bugs.webkit.org/show_bug.cgi?id=13058

12:33 PM Changeset in webkit [20154] by thatcher
  • 1 edit in trunk/WebKitSite/contact.html

Silly wrapping change for testing a post-commit hook change.

12:20 PM Changeset in webkit [20153] by lars
  • 3 edits in trunk/WebKitQt

Fix 99% of the crashes in the loader I've been seeing lately.

11:22 AM Changeset in webkit [20152] by darin
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher and John Sullivan.

  • fix <rdar://problem/4915303> CrashTracer: 36 crashes in Safari at com.apple.AppKit: -[NSView getRectsBeingDrawn:count:] + 502
  • page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect): This was calling drawRect: directly, but NSView's getRectsBeingDrawn:count: method was never really safe to call unless it was AppKit that called your drawRect: method. Changed it to call drawSingleRect: instead. A little ugly, but seems to work and will almost certainly fix the bug.
9:53 AM Changeset in webkit [20151] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12974

Call forgetGenericContext in JSSVGPathSeg destructor, otherwhise
we'll hit an ASSERT in a debug build, when running svg/custom/js-update-path-changes.svg
a few dozen times in a single WebKit instance. The ASSERT is good and just warns that
there was already a generic context pointer registered, and the new "to be registered"
object already exists, but pointing to a different object. That's because garbage collection
calls the JSSVGPathSeg destructor, but that didn't cleanup the generic context map.

Only JSSVGPathSeg is hit by this problem, as it's the only non SVGAnimated* type
using the generic context system while using a custom JSSVGPathSegList implementation.

Also cleanup JSSVGPathSegListCustom code to call the static forgetGenericContext
method instead of doing the same using custom code.

  • bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::removeFromPathSegContextMap): (WebCore::JSSVGPathSegList::clear): (WebCore::JSSVGPathSegList::removeItem):
  • bindings/scripts/CodeGeneratorJS.pm:
8:12 AM Changeset in webkit [20150] by brmorris
  • 2 edits in S60/branches/3.1m/MemoryManager

spadma, Reviewed by Yongjun.

DESC: Browsers OOM Plug-in functionality is disabled HMAA-6Z3HMM
​http://bugs.webkit.org/show_bug.cgi?id=13047

7:47 AM Changeset in webkit [20149] by darin
  • 2 edits in trunk/LayoutTests
  • fast/js/kde/RegExp-expected.txt: Fix the one other test affected by the js-test-pre.js change.
7:19 AM Changeset in webkit [20148] by darin
  • 21 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/old-names-expected.txt: Added.
  • fast/forms/old-names.html: Added.
  • check in files that were somehow left out in the last check-in
  • fast/js/resources/js-test-pre.js: Improve the format of the failure message when both the real results and expected results are strings.
  • fast/dom/wrapper-classes-expected.txt: Changed back to use the new format.

WebCore:

Reviewed by Adele.

Test: fast/forms/old-names.html

  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::canGetItemsForName): If the form collection has nothing for a given name, try the form's oldNamedElement function. (WebCore::JSHTMLFormElement::nameGetter): Ditto.
  • bindings/js/kjs_dom.h: Removed the DOMNamedNodesCollection. Instead we will use a class derived from NodeList.
  • bindings/js/kjs_dom.cpp: Ditto.
  • bindings/js/kjs_html.cpp: (KJS::VectorNodeList::VectorNodeList): Added. Constructor for a new class derived from NodeList to be used for the named items result from a collection -- uses a vector of node pointers. (KJS::VectorNodeList::length): Added. (KJS::VectorNodeList::item): Added. (KJS::JSHTMLCollection::getNamedItems): Use VectorNodeList and the existing wrapper for NodeList rather than a custom JavaScript class, DOMNamedNodesCollection.
  • dom/ChildNodeList.h:
  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::ChildNodeList): Updated to derive from TreeNodeList, since NodeList is now a simpler class. (WebCore::ChildNodeList::elementMatches): Updated for name and parameter change.
  • dom/NameNodeList.h:
  • dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): Updated to derive from TreeNodeList, since NodeList is now a simpler class. (WebCore::NameNodeList::rootNodeAttributeChanged): Updated for name and parameter change.
  • dom/Node.h: Change register/unregister functions to take TreeNodeList.
  • dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): Updated to derive from TreeNodeList, since NodeList is now a simpler abstract class. (WebCore::TagNodeList::elementMatches): Updated for name and parameter change. (WebCore::Node::registerNodeList): Changed type from NodeList to TreeNodeList. (WebCore::Node::unregisterNodeList): Ditto.
  • dom/NodeList.h: Broke NodeList into a simpler base class and a derived class with the machinery for iterating a tree, called TreeNodeList.
  • dom/NodeList.cpp: (WebCore::NodeList::~NodeList): Added. (WebCore::NodeList::itemWithName): Factored out of the old itemWithName. (WebCore::TreeNodeList::TreeNodeList): Renamed from NodeList. (WebCore::TreeNodeList::~TreeNodeList): Ditto. (WebCore::TreeNodeList::recursiveLength): Ditto. (WebCore::TreeNodeList::itemForwardsFromCurrent): Ditto. (WebCore::TreeNodeList::itemBackwardsFromCurrent): Ditto. (WebCore::TreeNodeList::recursiveItem): Ditto. (WebCore::TreeNodeList::itemWithName): Factored half of this into this function, the other half in NodeList::itemWithName. (WebCore::TreeNodeList::rootNodeAttributeChanged): Added. No longer inline. (WebCore::TreeNodeList::rootNodeChildrenChanged): Renamed from NodeList.
  • html/HTMLFormElement.h: Added formElementNameChanged and oldNamedElement fucntions, and a map called m_oldNames. Also removed m_boundary, which I thought I had already done.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Initialize m_oldNames to 0. Switched the rest of the members to initialization syntax. (WebCore::HTMLFormElement::~HTMLFormElement): Delete m_oldNames. (WebCore::HTMLFormElement::formElementNameChanged): Added. Stores a reference to one element under each of its old names. (WebCore::HTMLFormElement::oldNamedElement): Added. Returns the old element that once had a given name.
  • html/HTMLGenericFormElement.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::parseMappedAttribute): When the name attribute changes, tell the form about the old name. (WebCore::HTMLGenericFormElement::insertedIntoTree): When telling a form about an element, also store away the old name so that we can use it when the name changes later.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Added a call to the base class in the nameAttr case, so the code in HTMLGenericFormElement above will get called in the input element case.
7:17 AM Changeset in webkit [20147] by weinig
  • 5 edits in trunk/LayoutTests

Reviewed by Lars.

Update text in tests to match expected output.

  • fast/dom/gc-6-expected.txt:
  • fast/dom/gc-6.html:
  • fast/dom/gc-7-expected.txt:
  • fast/dom/gc-7.html:
6:36 AM Changeset in webkit [20146] by antti
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Alexey.


Test for DOS using composed character.

  • fast/text/large-text-composed-char-dos-expected.txt: Added.
  • fast/text/large-text-composed-char-dos.html: Added.

WebCore:

Reviewed by Alexey.

Alexey spotted a DOS by using string of 64k unbreakable character in
fix for ​http://bugs.webkit.org/show_bug.cgi?id=12833

  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
5:54 AM Changeset in webkit [20145] by thatcher
  • 10 edits in trunk/LayoutTests

Reviewed by Tim H.

  • fast/dom/gc-6-expected.txt: Renamed DOMHTMLElement to HTMLElement.
  • fast/dom/gc-7-expected.txt: Ditto.
  • fast/dom/prototype-chain-expected.txt: Renamed DOMHTMLElementPrototype to HTMLElementPrototype.
  • fast/dom/undetectable-document-all-expected.txt: Renamed Collection to HTMLCollection.
  • fast/dom/wrapper-classes-expected.txt: Updated for change to output for string comparison failure in fast/js/resources/js-test-pre.js.
  • fast/events/mouseclick-target-and-positioning-expected.txt: Renamed DOMHTMLElement to HTMLElement.
  • fast/tokenizer/external-script-document-write-expected.checksum: Ditto.
  • fast/tokenizer/external-script-document-write-expected.png: Ditto.
  • fast/tokenizer/external-script-document-write-expected.txt: Ditto.
3:13 AM Changeset in webkit [20144] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Tweaked again.

3:11 AM Changeset in webkit [20143] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Added bug references and a period.

3:03 AM Changeset in webkit [20142] by lars
  • 2 edits in trunk/WebCore

Fix the Qt build.

2:21 AM Changeset in webkit [20141] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Have the nightly launcher prefer Safari found in /Applications or ~/Applications
if present, otherwise fall back on using LaunchServices to locate it elsewhere
on the system. The motivation for this is to make the behaviour of the nightly
builds more predictable on machines with multiple copies of Safari present.

  • WebKitLauncher/main.m: (locateSafariBundle): (main):
1:00 AM Changeset in webkit [20140] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12576
WebKit does not support xlink:show attributes

Make an exception for non-empty targets, these should be opened
in a new window, unless the value is _self.

12:32 AM Changeset in webkit [20139] by hyatt
  • 2 edits in trunk/WebCore

Double the encoded size of images for now. We do this to account for a bug in ImageIO where they hold
a separate copy of image data.

Reviewed by aroben

  • loader/CachedImage.cpp: (WebCore::CachedImage::data):

Mar 12, 2007:

9:24 PM Changeset in webkit [20138] by harrison
  • 6 edits in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4743256> ctrl-y key binding (yank) should do nothing when kill ring is empty

  • editing/pasteboard/emacs-cntl-y-001-expected.checksum:
  • editing/pasteboard/emacs-cntl-y-001-expected.png:
  • editing/pasteboard/emacs-cntl-y-001-expected.txt:
  • editing/pasteboard/emacs-cntl-y-001.html:

WebKit:

Reviewed by Darin.

<rdar://problem/4743256> ctrl-y key binding (yank) should do nothing when kill ring is empty

Test updated:

  • editing/pasteboard/emacs-cntl-y-001.html:


  • WebView/WebHTMLView.mm: (-[WebHTMLView yank:]): (-[WebHTMLView yankAndSelect:]): Do nothing if the killring is empty.
9:05 PM Changeset in webkit [20137] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/gdk/TemporaryLinkStubs.cpp: (SearchPopupMenu::enabled): add missing stub.
8:57 PM Changeset in webkit [23067] by darin
  • 2 edits in branches/WindowsMerge/WebCore
  • WebCore.vcproj/WebCore.vcproj: Added new JavaScript wrapper derived source files.
8:52 PM Changeset in webkit [20136] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

  • html/HTMLFormElement.cpp: (WebCore::getUniqueBoundaryString): Speculative fix: remove dashes from the boundary prefix that appear after non-dash characters.
8:48 PM Changeset in webkit [20135] by ddkilzer
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Anders.

  • fast/loader/onunload-form-submit-crash-2-expected.txt: Added.
  • fast/loader/onunload-form-submit-crash-2.html: Added.

WebCore:

Reviewed by Anders.

Test: fast/loader/onunload-form-submit-crash-2.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): Added null check.
7:13 PM Changeset in webkit [20134] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Remove conflict marker.

7:11 PM Changeset in webkit [20133] by andersca
  • 1 edit
    1 add in trunk/LayoutTests

Add expected results.


  • fast/frames/frame-navigation-expected.txt: Added.
6:09 PM Changeset in webkit [20132] by andersca
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4900071>
​http://bugs.webkit.org/show_bug.cgi?id=6454
ASSERTION: Navigating 'back' in frameset: !_private->previousItem (6454)

  • fast/frames/frame-navigation.html: Added.
  • fast/frames/resources/frame-navigation-child.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4900071>
​http://bugs.webkit.org/show_bug.cgi?id=6454
ASSERTION: Navigating 'back' in frameset: !_private->previousItem (6454)

Change back the behavior of checkLoadComplete to traverse the entire frame tree instead of
just the parent frames of the current frame. This is needed in order to reset the previous history item
for all frames when doing a frame navigation. (This was changed in revision 11819)


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::recursiveCheckLoadComplete): (WebCore::FrameLoader::checkLoadComplete):
  • loader/FrameLoader.h:
5:53 PM Changeset in webkit [20131] by justing
  • 3 edits
    4 adds in trunk

Reviewed by darin


<rdar://problem/5056619>
REGRESSION: Gmail Editor: Dragging text into Reply (textarea) field results in a crash at WebCore::InsertNodeBeforeCommand::doApply()


  • editing/SelectionController.cpp: (WebCore::removingNodeRemovesPosition): Added. (WebCore::SelectionController::nodeWillBeRemoved): Clear the selection if it's inside a shadow tree.
  • page/DragController.cpp: (WebCore::setSelectionToDragCaret): Return false to signal to clients that a drop shouldn't be performed if the second attempt to set a selection ends up in non-editable content.
5:49 PM Changeset in webkit [20130] by darin
  • 39 edits
    2 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

  • added a test that checks the classes of wrappers created by both the JavaScript binding and the Objective-C binding
  • fast/dom/wrapper-classes-expected.txt: Added.
  • fast/dom/wrapper-classes.html: Added.
  • fast/js/resources/js-test-pre.js: Improve the format of the failure message when both the real results and expected results are strings.

WebCore:

Reviewed by Tim Hatcher.

  • fixed JavaScript wrapper classes to be correct for a variety of cases that a new test uncovered: was broken for at least 5 classes
  • fixed Objective-C wrapper classes to be correct for a variety of cases that a test case uncovered: was broken for ast least 50 classes
  • added missing DOM API for creating OverflowEvent and WheelEvent instances

Test: fast/dom/wrapper-classes.html

  • DerivedSources.make: Added missing bindings: HTMLCanvasElement for ObjC, CDATASection, Comment, and EntityReference for JavaScript.
  • WebCore.xcodeproj/project.pbxproj: Added those new generated files.
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper): Corrected the wrapper classes for <keygen>, which needs an HTMLSelectElement wrapper, and <xmp>, which needs an HTMLPreElement wrapper.
  • bindings/objc/DOMInternal.h: Updated for new naming scheme. Also moved createDOMWrapper from the KJS namespace to the WebCore namespace.
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper): Broke the core function into a separate one, and left it in the KJS namespace because Objective-C++ rules make it impossible for it to work in the WebCore namespace. Used a macro-based implementation to cut down on repeated code, and added missing cases for Counter, HTMLOptionsCollection, Range, XPathExpression, XPathResult, Event, RGBColor, Rect, Window, DOMImplementation, NodeIterator, TreeWalker, and HTMLCollection. (WebCore::createDOMWrapper): The other half of the function.
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): Corrected the wrapper classes for <canvas>, which needs a DOMHTMLCanvasElement wrapper, <del>, which needs a DOMHTMLModElement wrapper, <embed>, which needs a DOMHTMLEmbedElement wrapper, <ins>, which needs a DOMHTMLModElement wrapper, <th>, which needs a DOMHTMLTableCellElement wrapper, and <xmp>, which needs an DOMHTMLPreElement wrapper. (+[DOMNode _wrapNode:]): Updated for new naming scheme. (+[DOMNode _wrapEventTarget:]): Ditto. (+[DOMNodeFilter _wrapNodeFilter:]): Ditto. (ObjCNodeFilterCondition::acceptNode): Ditto. (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Ditto. (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Ditto. (WebCore::ObjCEventListener::handleEvent): Ditto.
  • dom/Document.cpp: (WebCore::Document::createEvent): Added cases for OverflowEvent and WheelEvent.
  • dom/OverflowEvent.h: Added empty constructor and initOverflowEvent.
  • dom/OverflowEvent.cpp: (WebCore::OverflowEvent::OverflowEvent): Added. (WebCore::OverflowEvent::initOverflowEvent): Added.
  • dom/OverflowEvent.idl: Added initOverflowEvent.
  • bindings/objc/PublicDOMInterfaces.h: Added initOverflowEvent.
  • bindings/objc/DOMCSS.mm: (+[DOMStyleSheet _wrapStyleSheet:]): Updated for new naming scheme. (+[DOMCSSRule _wrapCSSRule:]): Corrected wrapper for CSSUnknownRule. (+[DOMCSSValue _wrapCSSValue:]): Updated for new naming scheme.
  • bindings/js/kjs_css.h: (KJS::DOMRGBColor::impl): Added. Used when making an ObjC wrapper. (KJS::DOMRect::impl): Ditto.
  • bindings/js/kjs_dom.cpp: (KJS::toJS): Corrected the wrapper classes for CDATASection, Comment, and EntityReference.
  • bindings/js/kjs_html.cpp: Corrected the class name for HTMLElement (was "DOMHTMLElement") and HTMLCollection (was "Collection").
  • bindings/objc/DOMImplementationFront.h:
  • bindings/objc/DOMImplementationFront.cpp: (WebCore::implementationFront): Added new overload that returns a front given a JavaScript wrapper. Needed by the code that makes the Objective-C wrapper.
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]): Updated since createDOMWrapper is now in the WebCore namespace.
  • bindings/scripts/CodeGeneratorObjC.pm: Update the naming scheme for the wrapper creation functions to use _wrapElement: rather then _elementWith: style. Removed now-unneeded special cases for things that needed to stay upper-case, since we don't have to do the whole lcfirst thing.
  • html/HTMLCanvasElement.idl: Added #if so we can successfully generate the Objective-C wrapper for this class, even though we can't yet handle the DOMObject return type.
  • html/HTMLOptionsCollection.idl: Added GenerateNativeConverter so we get an appropriate toJS function.
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _wrapEvent:]):
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): (-[DOMHTMLDocument createDocumentFragmentWithText:]):
  • bindings/objc/DOMObject.mm: (-[DOMObject sheet]):
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (+[DOMRGBColor _wrapRGBColor:]):
  • bindings/objc/DOMSVGPathSegInternal.mm: (+[DOMSVGPathSeg _wrapSVGPathSeg:]):
  • bindings/objc/DOMXPath.mm: (+[DOMNativeXPathNSResolver _wrapXPathNSResolver:]):
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge nodesFromList:]): (-[WebCoreFrameBridge elementWithName:inForm:]): (-[WebCoreFrameBridge formForElement:]): (-[WebCoreFrameBridge currentForm]): (-[WebCoreFrameBridge controlsInForm:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebCoreFrameBridge convertNSRangeToDOMRange:]): (-[WebCoreFrameBridge markDOMRange]): (-[WebCoreFrameBridge markedTextDOMRange]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreFrameBridge documentFragmentWithText:inContext:]): (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]): (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge replaceSelectionWithText:selectReplacement:smartReplace:]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]): (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]): (-[WebCoreFrameBridge dragCaretDOMRange]): (-[WebCoreFrameBridge editableDOMRangeForPoint:]): (-[WebCoreFrameBridge characterRangeAtPoint:]): (-[WebCoreFrameBridge typingStyle]): (-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): Updated for new naming scheme.

WebKit:

Reviewed by Tim Hatcher.

  • update for the new naming scheme for the Objective-C wrapper-creation functions: _wrapElement: instead of _elementWith:, etc.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): (WebFrameLoaderClient::createJavaAppletWidget):
  • WebView/WebFrame.mm: (kit): Use the _wrapElement-style functions.
5:34 PM Changeset in webkit [20129] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4990691> REGRESSION: Selecting text in Adium's Messages field causes horizontal shift

Corrected the recursive point conversion and scrolling done in scrollPointRecursively to use the
document view of each NSClipView.

  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::scrollPointRecursively): Call convertPoint:fromView: on the document views, not the clip views as we encounter them. Then call constrainScrollPoint: on the converted point to constrain to the document view bounds. And finally call scrollPoint: on the document view, not the clip view.
5:07 PM Changeset in webkit [20128] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • add a DumpRenderTree feature where you can get the Objective-C class name of a JavaScript object
  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): Add the objCClassNameOf: selector. (+[LayoutTestController webScriptNameForSelector:]): Add the objCClassNameOf: selector, with the name "objCClassName". (-[LayoutTestController objCClassNameOf:]): Added.
4:57 PM Changeset in webkit [20127] by antti
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Alexey


Test that this works correctly with composed characters
​http://bugs.webkit.org/show_bug.cgi?id=12833
REGRESSION: Selecting text in 6.6MB txt file is sluggish as of the Feb 19th nightly
<rdar://problem/5028159>

  • fast/text/large-text-composed-char-expected.checksum: Added.
  • fast/text/large-text-composed-char-expected.png: Added.
  • fast/text/large-text-composed-char-expected.txt: Added.
  • fast/text/large-text-composed-char.html: Added.

WebCore:

Reviewed by Alexey.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12833
REGRESSION: Selecting text in 6.6MB txt file is sluggish as of the Feb 19th nightly
<rdar://problem/5028159>


Divide large text blocks (>64kB) over multiple text nodes. This limits linebox searches to
a manageable subset.


  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
  • dom/Text.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
4:48 PM Changeset in webkit [20126] by hyatt
  • 2 edits in trunk/WebCore

Fix a regression in printing. Printer fonts need to be part of the
font cache key, since printer fonts have different glyph widths.
(Integer antialiasing is used for screen fonts but not for printer fonts.)

Reviewed by aroben

  • platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontCache::getCachedFontPlatformData):
4:07 PM Changeset in webkit [20125] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/5057575>
REGRESSION: Repro Crash in FrameLoader::frame loading about:blank in PLT


Always get the web view from the current web frame, since the document loader's frame can have been zeroed out
(for example when detaching the document loader).


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading):
2:58 PM Changeset in webkit [23066] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

<rdar://problem/5054694>
Repro crash when viewing fast/dom/HTMLObjectElement/object-as-frame.html


  • bridge/win/FrameWin.cpp: (WebCore::Frame::createScriptInstanceForWidget): Return 0 for frame views.
2:32 PM Changeset in webkit [20124] by lars
  • 2 edits in trunk/WebCore

add missing symbol to fix the Qt build again.

2:23 PM Changeset in webkit [23065] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/5054713>
Crash in suggestedFilenameForResponse in two fast/encoding tests.


Add null checks.


  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::suggestedFilenameForResponse):
1:45 PM Changeset in webkit [23064] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix for <rdar://problem/5053618> Disable "recent searches" search field menu.

  • platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenu::enabled):
1:43 PM Changeset in webkit [20123] by adele
  • 4 edits in trunk/WebCore

Reviewed by Oliver.

Adding the ability to enable or disable a SearchPopupMenu.

  • platform/SearchPopupMenu.h:
  • platform/mac/SearchPopupMenuMac.mm: (WebCore::SearchPopupMenu::enabled):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::showPopup):
1:17 PM Changeset in webkit [20122] by rwlbuis
  • 17 edits in trunk

Reviewed by Nikolas Zimmermann.

​http://bugs.webkit.org/show_bug.cgi?id=12500
SVG fails to correctly handle all link style selectors
​http://bugs.webkit.org/show_bug.cgi?id=12567
<text> elements ignore <a> children

Allow <a> inside svg text and handle xlink:show.

12:05 PM Changeset in webkit [20121] by kmccullo
  • 32 edits in trunk/JavaScriptCore

Reviewed by .

  • Actually update tests for new DST rules.
  • tests/mozilla/ecma/Date/15.9.3.1-1.js:
  • tests/mozilla/ecma/Date/15.9.3.1-2.js:
  • tests/mozilla/ecma/Date/15.9.3.1-3.js:
  • tests/mozilla/ecma/Date/15.9.3.1-4.js:
  • tests/mozilla/ecma/Date/15.9.3.1-5.js:
  • tests/mozilla/ecma/Date/15.9.3.2-1.js:
  • tests/mozilla/ecma/Date/15.9.3.2-2.js:
  • tests/mozilla/ecma/Date/15.9.3.2-3.js:
  • tests/mozilla/ecma/Date/15.9.3.2-4.js:
  • tests/mozilla/ecma/Date/15.9.3.2-5.js:
  • tests/mozilla/ecma/Date/15.9.3.8-1.js:
  • tests/mozilla/ecma/Date/15.9.3.8-2.js:
  • tests/mozilla/ecma/Date/15.9.3.8-3.js:
  • tests/mozilla/ecma/Date/15.9.3.8-4.js:
  • tests/mozilla/ecma/Date/15.9.3.8-5.js:
  • tests/mozilla/ecma/Date/15.9.5.10-1.js:
  • tests/mozilla/ecma/Date/15.9.5.10-10.js:
  • tests/mozilla/ecma/Date/15.9.5.10-11.js:
  • tests/mozilla/ecma/Date/15.9.5.10-12.js:
  • tests/mozilla/ecma/Date/15.9.5.10-13.js:
  • tests/mozilla/ecma/Date/15.9.5.10-2.js:
  • tests/mozilla/ecma/Date/15.9.5.10-3.js:
  • tests/mozilla/ecma/Date/15.9.5.10-4.js:
  • tests/mozilla/ecma/Date/15.9.5.10-5.js:
  • tests/mozilla/ecma/Date/15.9.5.10-6.js:
  • tests/mozilla/ecma/Date/15.9.5.10-7.js:
  • tests/mozilla/ecma/Date/15.9.5.10-8.js:
  • tests/mozilla/ecma/Date/15.9.5.10-9.js:
  • tests/mozilla/ecma/jsref.js:
  • tests/mozilla/ecma_2/jsref.js:
  • tests/mozilla/ecma_3/Date/shell.js:
11:56 AM Changeset in webkit [23063] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Anders.

  • Skipped: Updated for current set of crashing tests.
11:56 AM Changeset in webkit [23062] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by Darin.

Get DRT to size the WebView correctly, and added font family prefs.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Make the DRT window an off-screen tool window so it isn't visible to the user despite having been "shown". (initializePreferences): Set font preferences. (main): Initially size the WebView to 0x0, then do a SetWindowPos to the desired size (this is what Boomer does).
11:52 AM Changeset in webkit [23061] by adele
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.


WebCore part of fix for <rdar://problem/5044790> preventing default of keypress event doesn't work (affects .mac)

  • platform/win/KeyEventWin.cpp: (WebCore::singleCharacterString): Added inline keyword. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Renamed arguments to be more meaningful. Added characterCode argument to be used when constructing m_text.

WebKitWin:

Reviewed by Oliver.

Fix for <rdar://problem/5044790> preventing default of keypress event doesn't work (affects .mac)

Removed special handling of the WM_CHAR message. All this work is now done by WM_KEYDOWN, which will dispatch the keydown event,
which causes the keypress event to be dispatched, which calls WebEditorClient::handleKeyPress to do all the hard work.


  • WebEditorClient.cpp: (WebEditorClient::handleKeypress): Removed special call to doTextFieldCommandFromEvent since this will now happen during normal key event processing. Call handleEditingKeyboardEvent. Now editing actions can be prevented from the keypress event handler.
  • WebView.cpp: (WebView::WebView): Added m_currentCharacterCode, so we can reuse the computed code from keyDown for keyUp events. (WebView::keyUp): Renamed arguments. Don't dispatch event for shift, ctrl, or capslock keys. Use m_currentCharacterCode when constructing the PlatformKeyboardEvent. (WebView::handleEditingKeyboardEvent): Now takes a KeyboardEvent instead of a PlatformKeyboardEvent. If no editCommand is created from the event, then call handleTextInputEvent. (WebView::keyDown): Peek at the next message in the message loop. If its a WM_CHAR, then get the character code and remove that message from the queue. Renamed arguments. Don't dispatch event for shift, ctrl, or capslock keys. Set m_currentCharacterCode and use it when constructing the PlatformKeyboardEvent. (WebViewWndProc): Removed handling of WM_CHAR, since this is now done from WM_KEYDOWN by dispatching the keydown event, which will eventually call handleKeyPress.
  • WebView.h: Made handleEditingKeyboardEvent public so it can be accessed from WebEditorClient.
11:49 AM Changeset in webkit [20120] by adele
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

Add a missing parameter to the constructor.

  • platform/PlatformKeyboardEvent.h:
  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
11:45 AM Changeset in webkit [20119] by brmorris
  • 2 edits in S60/trunk/WebKit

hongzhao, reviewed by ​Yongjun.zhang@nokia.com

DESC: Part 2/2 (see also r20116). Plugin Window shouldn't cover the scroll bars when it's oversize HZHO-6YZR4X
Fix: Calculate the clipRect based on the Browser mainframe rect and the plugin object rect and use it as the plugin cliprect.
​http://bugs.webkit.org/show_bug.cgi?id=13003

11:15 AM Changeset in webkit [23060] by adele
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Updating ChangeLog w/ revision

11:11 AM Changeset in webkit [23059] by adele
  • 2 edits
    1 add in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Forking KeyEventWin.cpp.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/KeyEventWin.cpp: Added.
10:44 AM Changeset in webkit [20118] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by .

  • Update tests for new DST rules.
  • tests/mozilla/ecma/shell.js:
9:47 AM Changeset in webkit [20117] by brmorris
  • 23 edits in S60/trunk

borges, reviewed by Bradley

DESC: related with task 14594 for S60 build feature work
​http://bugs.webkit.org/show_bug.cgi?id=13027

8:31 AM Changeset in webkit [20116] by brmorris
  • 4 edits in S60/trunk/WebKit

hongzhao, reviewed by ​Yongjun.zhang@nokia.com

DESC: Plugin Window shouldn't cover the scroll bars if they are oversize HZHO-6YZR4X
Fix: Intersects the plugin object rect and the rect of main frame in Browser, then set it as clip rect to pass for plugin window.
​http://bugs.webkit.org/show_bug.cgi?id=13003

8:09 AM Changeset in webkit [20115] by ggaren
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Oliver Hunt.


Fixed <rdar://problem/4681051> Installer crashes in KJS::Collector::
markOtherThreadConservatively(KJS::Collector::Thread*) trying to install
iLife 06 using Rosetta on an Intel Machine


The problem was that our thread-specific data destructor would modify the
list of active JavaScript threads without holding the JSLock, corrupting
the list. Corruption was especially likely if one JavaScript thread exited
while another was starting up.

  • JavaScriptCore.exp:
  • kjs/JSLock.cpp: Don't conflate locking the JSLock with registering a thread, since the thread-specific data destructor needs to lock without registering a thread. Instead, treat thread registration as a part of the convenience of the JSLock object, and whittle down JSLock::lock() to just the bits that actually do the locking. (KJS::JSLock::lock): (KJS::JSLock::registerThread):
  • kjs/JSLock.h: Updated comments to mention the new behavior above, and other recent changes. (KJS::JSLock::JSLock):
  • kjs/collector.cpp: (KJS::destroyRegisteredThread): Lock here. (KJS::Collector::registerThread): To match, assert that we're locked here.

JavaScriptGlue:

Reviewed by Oliver Hunt.


Updated in light of fix for <rdar://problem/4681051> Installer crashes
in KJS::Collector::markOtherThreadConservatively(KJS::Collector::Thread*)
trying to install iLife 06 using Rosetta on an Intel Machine


  • JavaScriptGlue.cpp: (JSLockInterpreter): Ensure backwards compatibility by calling registerThread() when explicitly taking the JSLock. (This doesn't happen automatically anymore.) I doubt this actally matters, but in JavaScriptGlue territory, that kind of thinking will get you killed.

WebKitTools:

Reviewed by Oliver Hunt.


Beefed up --threaded mode in light of <rdar://problem/4681051> Installer
crashes in KJS::Collector::markOtherThreadConservatively(KJS::Collector::Thread*)
trying to install iLife 06 using Rosetta on an Intel Machine


--threaded mode now runs a bunch of different JavaScript threads, randomly
killing and respawning them. This was sufficient for reproducing the
bug on my MacBook Pro.

  • DumpRenderTree/DumpRenderTree.m: (javaScriptThreads): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads): (dumpRenderTree):
8:02 AM Changeset in webkit [20114] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

fhodgkin, Reviewed by sachin

DESC: merge r20113 to s60's 3.1m branch. crash when exiting browser after trying to load a big file: TMCN-6YDJPJ
​http://bugs.webkit.org/show_bug.cgi?id=12967

8:00 AM Changeset in webkit [20113] by brmorris
  • 2 edits in S60/trunk/WebKit

fhodgkin, Reviewed by sachin

DESC: crash when exiting browser after trying to load a big file: TSW TMCN-6YDJPJ
​http://bugs.webkit.org/show_bug.cgi?id=12967

2:18 AM Changeset in webkit [20112] by lars
  • 7 edits in trunk/WebCore

Fix the Qt build. I still get crashes though :/

Mar 11, 2007:

12:21 AM Changeset in webkit [20102] by ap
  • 16 edits in trunk

Reviewed by Darin.

A partial fix for ​http://bugs.webkit.org/show_bug.cgi?id=13021
XPath can be very slow

  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Cache evaluationContext in a local variable.
  • xml/XPathExpressionNode.cpp: (WebCore::XPath::Expression::evaluationContext):
  • xml/XPathExpressionNode.h: (WebCore::XPath::Expression::addSubExpression): (WebCore::XPath::Expression::subExprCount): (WebCore::XPath::Expression::subExpr):
  • xml/XPathFunctions.cpp:
  • xml/XPathFunctions.h: (WebCore::XPath::Function::setName): (WebCore::XPath::Function::arg): (WebCore::XPath::Function::argCount): (WebCore::XPath::Function::name): Made one-liners critical for performance inline.
  • xml/XPathGrammar.y: Fully parse NodeTests, so that strings are no longer passed for what is essentially an enum. Use LocationPath accessors to add steps, instead of directly manipulating internal data members.
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::parseStatement): (WebCore::XPath::Parser::registerNodeTest): (WebCore::XPath::Parser::deleteNodeTest):
  • xml/XPathParser.h: Added support methods for changes in XPathGrammar.y.
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Cache evaluationContext in a local variable. Use swap() to avoid performing vector assignments. (WebCore::XPath::LocationPath::evaluate): Use swap() to avoid performing vector assignments. (WebCore::XPath::LocationPath::optimizeStepPair): This new method is called during LocationPath construction, to simplify the path as it's being built. Currently, the only optimized case is "*" - it is a basis for important operations that cannot be efficiently written in XPath 1.0, but can be optimized with a little bit of XPath 2.0. (WebCore::XPath::LocationPath::appendStep): A new accessor that modifies m_steps and calls optimizeStepPair(). (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
  • xml/XPathPath.h: (WebCore::XPath::LocationPath::setAbsolute): A new accessor.
  • xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::): (WebCore::XPath::Step::NodeTest::NodeTest): (WebCore::XPath::Step::NodeTest::kind): (WebCore::XPath::Step::NodeTest::data): Step::NodeTest is a new sub-class that represents a fully parsed NodeTest. (WebCore::XPath::Step::axis): (WebCore::XPath::Step::nodeTest): (WebCore::XPath::Step::nodeTestData): (WebCore::XPath::Step::namespaceURI): (WebCore::XPath::Step::predicates): (WebCore::XPath::Step::setAxis): (WebCore::XPath::Step::setNodeTest): (WebCore::XPath::Step::setNodeTestData): (WebCore::XPath::Step::setNamespaceURI): (WebCore::XPath::Step::setPredicates): New accessors that let optimizeStepPair() manipulate Step data.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::Step): Use the new NodeTest class. (WebCore::XPath::Step::evaluate): Cache evaluationContext in a local variable. Use swap() to avoid performing unneeded vector assignments. (WebCore::XPath::Step::nodesInAxis): Cosmetic changes. (WebCore::XPath::Step::nodeTestMatches): Use NodeTest instead of parsing the test from string each time. Added a partial implementation of XPath 2.0 element() node test.
12:10 AM Changeset in webkit [20101] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12249
FCKeditor: <hr>, <ul> and <ol> have id="undefined"

This fixes the attached reduction, but not the original issue.

Test: editing/execCommand/default-parameters.html

  • dom/Document.h:
  • dom/Document.idl: Make second and third execCommand() parameters optional.

Mar 10, 2007:

10:49 PM Changeset in webkit [20111] by kjk
  • 5 edits in trunk/WebCore

Not reviewed - gdk build fixes.

  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::respondToChangedSelection): add stub
  • platform/gdk/EditorClientGdk.h:
  • platform/gdk/FrameGdk.cpp:
  • platform/gdk/TemporaryLinkStubs.cpp: (Editor::markMisspellings): add stub
10:39 PM Changeset in webkit [20110] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=12560
W3C XPath test Text_Nodes.svg fails

WebCore:

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches): Revert the fix, as the behavior doesn't appear all that desirable as it did at first glance.

LayoutTests:

  • dom/svg/level3/xpath/Text_Nodes-expected.txt: This fails again.
  • fast/xpath/4XPath/Borrowed/kd_20010423-expected.txt:
  • fast/xpath/4XPath/Borrowed/kd_20010423.html: Brought the test back to its original form (in which Firefox passes).
  • fast/xpath/text-nodes-expected.txt: Added.
  • fast/xpath/text-nodes.html: Added. A new test for text nodes, verifying some more arcane cases.
10:34 PM Changeset in webkit [20109] by oliver
  • 3 edits
    2 adds in trunk

2007-03-11 Oliver Hunt <​oliver@apple.com>

Reviewed by hyatt.

Fix for <rdar://problem/5055690> ASSERTION failure on drop into
editable element with content changed on drop

After setting the selection for a drop into an editable region
we make sure the we succeeded. If we didn't we assume a focus handler
or similar altered the element contents and try again, if the second
attempt fails we bail out.

  • page/DragController.cpp: (WebCore::setSelectionToDragCaret): (WebCore::DragController::concludeDrag):

LayoutTests:

<rdar://problem/5055690> ASSERTION failure on drop into editable element with content changed on drop

  • fast/events/content-changed-during-drop-expected.txt: Added.
  • fast/events/content-changed-during-drop.html: Added.
9:46 PM Changeset in webkit [23058] by oliver
  • 5 edits in branches/WindowsMerge

2007-03-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Adele.

WebCoreWin:

Removed Frame::respondToChangedSelection stub
added Editor::markMisspellings stub

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::markMisspellings):

WebKitWin:

Stubbed WebEditorClient::respondToChangedSelection

  • WebEditorClient.cpp: (WebEditorClient::respondToChangedSelection):
  • WebEditorClient.h:
9:41 PM Changeset in webkit [20108] by oliver
  • 16 edits in trunk

2007-03-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Adele.

WebCore:

Moving Frame{Mac}::respondToChangedSelection to Frame.cpp
Added new EditorClient method to handle old bridge function


  • bridge/EditorClient.h:

Added respondToChangedSelection to replace old bridge function

  • editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection):

Add client call to replace old bridge call from Frame::respondToChangedSelection

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):

No longer directly call Editor as Frame::respondToChangedSelection
makes the call

  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):

Moved from FrameMac, replaced bridge call with call to Editor

  • page/mac/FrameMac.mm:

Moved respondToChangedSelection to Frame.cpp

  • page/mac/WebCoreFrameBridge.h:

Removed respondToChangedSelection from bridge

  • page/qt/FrameQt.cpp:

Remove stub method for respondToChangedSelection

WebKit:

Moved respondToChangedSelection from FrameBridge to EditorClient

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection):
  • WebCoreSupport/WebFrameBridge.mm: Removed respondToChangedSelection from bridge

WebKitQt:

Stub for EditorClientQt::respondToChangedSelection

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::respondToChangedSelection):
  • WebCoreSupport/EditorClientQt.h:
8:24 PM Changeset in webkit [20107] by darin
  • 2 edits in trunk/WebKit

Reviewed by Adele.

  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): At every place we call the plug-in, since it could destroy the stream, get pluginView into a local variable; it will be set to nil if the stream is destroyed. (-[WebBaseNetscapePluginStream _destroyStream]): Added calls to retain/release to handle the case where one of the calls to the plug-in destroys the stream. Added a call to cancelPreviousPerformRequestsWithTarget in case _deliverData has been scheduled but not yet delivered. Also get pluginView into a local variable as mentioned above, and check at strategic points and exit if the stream was already destroyed to avoid multiple calls to NPP_DestroyStream or NPP_URLNotify. (-[WebBaseNetscapePluginStream _deliverData]): Ditto.
6:32 PM Changeset in webkit [20106] by beidson
  • 2 edits in trunk

Fixed my name in the 2 ChangeLogs kjk just comitted

6:09 PM Changeset in webkit [20105] by kjk
  • 4 edits in trunk

WebCore:

Reviewed by Brady Edison.

Linux/gdk fix.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem): return true so that FrameLoader:goBackOrForwards() works.

WebKitTools:

Reviewed by Brady Edison.

Add forward/backward/quit menus for easier testing.

  • GdkLauncher/main.cpp: (menuMainBackCb): (menuMainForwardCb): (menuMainQuitCb): (main):
5:01 PM Changeset in webkit [23057] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin Adler.

Fixed <rdar://problem/4587763> PAC file: lock inversion between QT and
JSCore causes a hang @ www.panoramas.dk


See JavaScriptCore ChangeLog for details.


Stress test doesn't show any problems.


Drop the JSLock before making calls through the plug-in API from functions
that may have been called by JavaScript.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): (WebCore::PluginViewWin::handleKeyboardEvent): (WebCore::PluginViewWin::handleMouseEvent): (WebCore::PluginViewWin::setNPWindowRect): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::bindingInstance):
4:57 PM Changeset in webkit [20104] by ggaren
  • 23 edits in trunk

JavaScriptCore:

Reviewed by Darin Adler.

Fixed <rdar://problem/4587763> PAC file: lock inversion between QT and
JSCore causes a hang @ www.panoramas.dk


With a PAC file, run-webkit-tests --threaded passes, the reported site
works, and all the Quicktime/JavaScript and Flash/JavaScript examples
I found through Google work, too.


Any time JavaScript causes arbitrary non-JavaScript code to execute, it
risks deadlock, because that code may block, trying to acquire a lock
owned by a thread that is waiting to execute JavaScript. In this case,
the thread was a networking thread that was waiting to interpret a PAC file.


Because non-JavaScript code may execute in response to, well, anything,
a perfect solution to this problem is impossible. I've implemented an
optimistic solution, instead: JavaScript will drop its lock whenever it
makes a direct call to non-JavaScript code through a bridging/plug-in API,
but will blissfully ignore the indirect ways it may cause non-JavaScript
code to run (resizing a window, for example).


Unfortunately, this solution introduces significant locking overhead in
the bridging APIs. I don't see a way around that.

This patch includes some distinct bug fixes I saw along the way:


  • bindings/objc/objc_instance.mm: Fixed a bug where a nested begin() call would leak its autorelease pool, because it would NULL out _pool without draining it.
  • bindings/runtime_object.cpp: (RuntimeObjectImp::methodGetter): Don't copy an Identifier to ASCII only to turn around and make an Identifier from the ASCII. In an earlier version of this patch, the copy caused an assertion failure. Now it's just unnecessary work. (RuntimeObjectImp::getOwnPropertySlot): ditto
  • bindings/objc/objc_instance.h: Removed overrides of setVAlueOfField and getValueOfField, because they did exactly what the base class versions did. Removed overrides of Noncopyable declarations for the same reason.
  • bindings/runtime.h: Inherit from Noncopyable instead of rolling our own.
  • bindings/c/c_instance.h: ditto

And the actual patch:


  • API/JSCallbackConstructor.cpp: Drop all locks when calling out to C. (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackFunction.cpp: ditto (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackObject.cpp: ditto (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::~JSCallbackObject): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::hasInstance): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::getPropertyNames): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):


  • bindings/c/c_instance.cpp: Drop all locks when calling out to C. (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
  • bindings/c/c_runtime.cpp: Drop all locks when calling out to C. (KJS::Bindings::CField::valueFromInstance): (KJS::Bindings::CField::setValueToInstance):
  • bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall): Drop all locks when calling out to Java.
  • bindings/objc/objc_instance.mm: The changes here are to accomodate the fact that C++ unwinding of DropAllLocks goes crazy when you put it inside a @try block. I moved all JavaScript stuff outside of the @try blocks, and then prefixed the whole blocks with DropAllLocks objects. This required some supporting changes in other functions, which now acquire the JSLock for themselves, intead of relying on their callers to do so. (ObjcInstance::end): (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: Same as above, except I didn't want to change throwError to acquire the JSLock for itself. (ObjcField::valueFromInstance): (ObjcField::setValueToInstance):
  • bindings/objc/objc_utility.mm: Supporting changes mentioned above. (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
  • kjs/JSLock.cpp: (1) Fixed DropAllLocks to behave as advertised, and drop the JSLock only if the current thread actually acquired it in the first place. This is important because WebKit needs to ensure that the JSLock has been dropped before it makes a plug-in call, even though it doesn't know if the current thread actually acquired the JSLock. (We don't want WebKit to accidentally drop a lock belonging to *another thread*.) (2) Used the new per-thread code written for (1) to make recursive calls to JSLock very cheap. JSLock now knows to call pthread_mutext_lock/ pthread_mutext_unlock only at nesting level 0. (KJS::createDidLockJSMutex): (KJS::JSLock::lock): (KJS::JSLock::unlock): (KJS::DropAllLocks::DropAllLocks): (KJS::DropAllLocks::~DropAllLocks): (KJS::JSLock::lockCount):
  • kjs/JSLock.h: Don't duplicate Noncopyable. (KJS::JSLock::~JSLock):
  • wtf/Assertions.h: Blind attempt at helping the Windows build.

WebCore:

Reviewed by Darin Adler.

Fixed <rdar://problem/4587763> PAC file: lock inversion between QT and
JSCore causes a hang @ www.panoramas.dk


See JavaScriptCore ChangeLog for details.


  • bindings/objc/WebScriptObject.mm: (_didExecute): Added helpful ASSERT. (+[WebScriptObject throwException:]): Added missing JSLock.

WebKit:

Reviewed by Darin Adler.

Fixed <rdar://problem/4587763> PAC file: lock inversion between QT and
JSCore causes a hang @ www.panoramas.dk


See JavaScriptCore ChangeLog for details.

Drop the JSLock before making calls through the plug-in API from functions
that may have been called by JavaScript.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView setWindowIfNecessary]): (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView createPluginScriptableObject]): (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]):
  • Plugins/WebPluginController.mm: (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): (-[WebPluginController startAllPlugins]): (-[WebPluginController stopAllPlugins]): (-[WebPluginController addPlugin:]): (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]):
4:14 AM Changeset in webkit [20103] by antti
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

Optimize linebox memory consumption:

  • move all bitfields to baseclass compacting them
  • make InlineTextBox::m_truncation unsigned short and make it relative to m_start
  • remove extremely rarely used EllipsisBox pointer from RootInlineBox and instead use a global hashmap to store it if needed
  • use minimum required number of bits to store BidiStatus enum variables in RootInlineBox
  • move overflow variables in RootInlineBox to a separate struct that is instantiated only if any of the variables is set to a value that can't trivially be derived from box x, y, width and height


As a result line box objects shrink:

InlineBox: 44 -> 44 bytes
InlineTextBox: 68 -> 60 bytes
InlineFlowBox: 68 -> 64 bytes
RootInlineBox: 128 -> 88 bytes


The optimizations possiblity was noticed when debugging ​http://bugs.webkit.org/show_bug.cgi?id=12833
Bug 12833: REGRESSION: Selecting text in 6.6MB txt file is sluggish as of the Feb 19th nightly
<rdar://problem/5028159>


On that page the patch saves 11.5MB or some 21% of linebox memory consumption. It also
actually improves selection performance somewhat by improving memory locality.

  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::nodeAtPoint): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::InlineTextBox):
  • rendering/RootInlineBox.cpp: (WebCore::throw): (WebCore::RootInlineBox::Overflow::operator delete): (WebCore::RootInlineBox::Overflow::destroy): (WebCore::RootInlineBox::destroy): (WebCore::RootInlineBox::detachEllipsisBox): (WebCore::RootInlineBox::clearTruncation): (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::nodeAtPoint): (WebCore::RootInlineBox::adjustPosition): (WebCore::RootInlineBox::selectionTop): (WebCore::RootInlineBox::setLineBreakInfo): (WebCore::RootInlineBox::ellipsisBox): (WebCore::RootInlineBox::setVerticalOverflowPositions): (WebCore::RootInlineBox::setHorizontalOverflowPositions): (WebCore::RootInlineBox::setVerticalSelectionPositions):
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::RootInlineBox): (WebCore::RootInlineBox::topOverflow): (WebCore::RootInlineBox::bottomOverflow): (WebCore::RootInlineBox::leftOverflow): (WebCore::RootInlineBox::rightOverflow): (WebCore::RootInlineBox::lineBreakBidiStatus): (WebCore::RootInlineBox::selectionBottom): (WebCore::RootInlineBox::Overflow::Overflow):

Mar 10, 2007:

3:37 PM Changeset in webkit [20100] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13028
REGRESSION: textField:doCommandBySelector:inFrame: not being called properly

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Before calling the base class defaultEventHandler, which will call handleKeypress, call doTextFieldCommandFromEvent.
2:46 PM Changeset in webkit [20099] by ddkilzer
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/listbox-typeahead-scroll-expected.txt: Added.
  • fast/forms/listbox-typeahead-scroll.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/listbox-typeahead-scroll.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Reordered to set the active selection's anchor and end before selecting the option, since the active selection is used to decide where to scroll when the selection is made. (WebCore::HTMLSelectElement::defaultEventHandler): Removed redundant check.
2:43 PM Changeset in webkit [20098] by ddkilzer
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/css-cached-import-rule-expected.checksum: Added.
  • fast/dom/css-cached-import-rule-expected.png: Added.
  • fast/dom/css-cached-import-rule-expected.txt: Added.
  • fast/dom/css-cached-import-rule.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/css-cached-import-rule.html

Replaced some direct calls to document->stylesheetLoaded() with calls to
the sheet's checkLoaded(). The latter calls back to the element's sheetLoaded() --
which notifies the document of the load -- and then updates the sheet's
loadCompleted() flag, ensuring that it stays in sync with whether the stylesheet
is still considered pending by the document.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::parseStyleSheet):
  • dom/StyleElement.cpp: (WebCore::StyleElement::childrenChanged):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setCSSStyleSheet):
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::sheetLoaded):
  • ksvg2/svg/SVGStyleElement.h:
2:38 PM Changeset in webkit [20097] by ddkilzer
  • 4 edits in trunk

WebCore:

Reviewed by Darin.

  • WebCore.exp: Export WebCore::Image::loadPlatformResource(const char*) for use in [WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:].

WebKit:

Reviewed by Darin.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Use WebCore::Image::loadPlatformResource(const char*) to load the missingImage image.
12:17 AM Changeset in webkit [23056] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • DOMCoreClasses.cpp: (DOMNode::textContent): Implement this.
12:08 AM Changeset in webkit [20096] by bdash
  • 2 edits in trunk/WebKit

2007-03-10 Mark Rowe <​mrowe@apple.com>

Reviewed by John.

<rdar://problem/5051827> HIWebView handling of kEventControlGetData is broken in 64-bit

On Leopard the kEventParamControlDataBufferSize event parameter is of type typeByteCount.
The 32-bit implementation of GetEventParameter will coerce between integer types and
typeByteCount while the 64-bit version will return a failure. As typeByteCount is new
in Leopard we must continue using typeSInt32 when building for Tiger.

  • Carbon/HIWebView.m: (HIWebViewEventHandler):

Mar 9, 2007:

7:23 PM Changeset in webkit [23055] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-09 Oliver Hunt <​oliver@apple.com>

Reviewed by John.

Fix the doubled text in the image used to drag a link

  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreDrawDoubledTextAtPoint):


5:06 PM Changeset in webkit [23054] by andersca
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Implement setting the suggested filename for a response.


  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::filenameFromHTTPContentDisposition): (WebCore::filenameHasSaneExtension): (WebCore::suggestedFilenameForResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):
  • platform/win/MimeTypeRegistryWin.cpp: (WebCore::getMIMETypeForUTI):


(WebCore::mimeTypeForExtension):
Fix two bugs in this function.


(WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):

WebKitWin:

Reviewed by Adam.

  • WebURLResponse.cpp: (WebURLResponse::suggestedFilename): Get the suggested filename from the ResourceResponse object.
4:41 PM Changeset in webkit [20095] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Force diff to treat files that svn-create-patch thinks are text as text.

  • Scripts/svn-create-patch: Added -a switch to diff command.
4:07 PM Changeset in webkit [23053] by andersca
  • 2 edits in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by Adam.

Fix build and do some general cleanup.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (WaitUntilDoneDelegate::didFailProvisionalLoadWithError): (WaitUntilDoneDelegate::didCommitLoadForFrame): (WaitUntilDoneDelegate::didReceiveIcon): (WaitUntilDoneDelegate::didFailLoadWithError): (WaitUntilDoneDelegate::didChangeLocationWithinPageForFrame): (WaitUntilDoneDelegate::willPerformClientRedirectToURL): (WaitUntilDoneDelegate::didCancelClientRedirectForFrame): (WaitUntilDoneDelegate::willCloseFrame): (WaitUntilDoneDelegate::createWebViewWithRequest): (WaitUntilDoneDelegate::webViewShow): (WaitUntilDoneDelegate::webViewClose): (WaitUntilDoneDelegate::webViewFocus): (WaitUntilDoneDelegate::webViewUnfocus): (WaitUntilDoneDelegate::webViewFirstResponder): (WaitUntilDoneDelegate::makeFirstResponder): (WaitUntilDoneDelegate::setStatusText): (WaitUntilDoneDelegate::webViewStatusText): (WaitUntilDoneDelegate::webViewAreToolbarsVisible): (WaitUntilDoneDelegate::setToolbarsVisible): (WaitUntilDoneDelegate::webViewIsStatusBarVisible): (WaitUntilDoneDelegate::setStatusBarVisible): (WaitUntilDoneDelegate::webViewIsResizable): (WaitUntilDoneDelegate::setResizable): (WaitUntilDoneDelegate::setFrame): (WaitUntilDoneDelegate::webViewFrame): (WaitUntilDoneDelegate::setContentRect): (WaitUntilDoneDelegate::webViewContentRect): (WaitUntilDoneDelegate::runJavaScriptConfirmPanelWithMessage): (WaitUntilDoneDelegate::runJavaScriptTextInputPanelWithPrompt): (WaitUntilDoneDelegate::runBeforeUnloadConfirmPanelWithMessage): (WaitUntilDoneDelegate::runOpenPanelForFileButtonWithResultListener): (WaitUntilDoneDelegate::mouseDidMoveOverElement): (WaitUntilDoneDelegate::contextMenuItemsForElement): (WaitUntilDoneDelegate::validateUserInterfaceItem): (WaitUntilDoneDelegate::shouldPerformAction): (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction): (WaitUntilDoneDelegate::dragSourceActionMaskForPoint): (WaitUntilDoneDelegate::willPerformDragSourceAction): (WaitUntilDoneDelegate::contextMenuItemSelected): (WaitUntilDoneDelegate::trackCustomPopupMenu): (WaitUntilDoneDelegate::measureCustomMenuItem): (WaitUntilDoneDelegate::drawCustomMenuItem): (WaitUntilDoneDelegate::cleanUpCustomMenuDrawingData): (WaitUntilDoneDelegate::canTakeFocus): (WaitUntilDoneDelegate::takeFocus): (WaitUntilDoneDelegate::registerUndoWithTarget): (WaitUntilDoneDelegate::removeAllActionsWithTarget): (WaitUntilDoneDelegate::setActionTitle): (WaitUntilDoneDelegate::undo): (WaitUntilDoneDelegate::redo): (WaitUntilDoneDelegate::canUndo): (WaitUntilDoneDelegate::canRedo): (WaitUntilDoneDelegate::addCustomMenuDrawingData):
2:58 PM Changeset in webkit [20094] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4976254> Please get off _NSSoftLinkingGetFrameworkFuncPtr

Use dlopen and dlsym to access the DCSShowDictionaryServiceWindow function.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
12:02 PM Changeset in webkit [23052] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Steve.

B&I build fix.

  • WebKit.vcproj/WebKit.vcproj: Removed all references to iconv.
11:45 AM Changeset in webkit [20093] by darin
  • 2 edits in trunk/WebKitSite
  • blog/wp-content/themes/webkit/style.css: Removed rule for code since we want it to match pre, and the default font looks fine -- no need to ask for "Courier New" explicitly.
10:54 AM Changeset in webkit [20092] by darin
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

  • editing/pasteboard/paste-xml-expected.checksum: Added.
  • editing/pasteboard/paste-xml-expected.png: Added.
  • editing/pasteboard/paste-xml-expected.txt: Added.
  • editing/pasteboard/paste-xml.xhtml: Added.

WebCore:

Reviewed by Justin.

Test: editing/pasteboard/paste-xml.xhtml

  • editing/markup.cpp: (WebCore::createFragmentFromMarkup): Added a check for 0 here, since createContextualFragment can return 0 for XML documents that fail to parse. In my testing, callers all seem equipped to handle 0.

WebKit:

Reviewed by Justin.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _hasHTMLDocument]): Added. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Don't call AppKit's conversion from the DOM to an attributed string if the document is not an HTML document, to work around an AppKit limitation (Radar 5052390).
8:32 AM Changeset in webkit [23051] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Fixup comments and remove an obsolete FIXME.
8:19 AM Changeset in webkit [20091] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
8:05 AM Changeset in webkit [20090] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • http/tests/misc/onload-remove-iframe-crash-2-expected.txt: Added.
  • http/tests/misc/onload-remove-iframe-crash-2.html: Added.
  • http/tests/misc/resources/onload-remove-iframe-crash-2.html: Added.
  • http/tests/misc/resources/onload-remove-iframe.html: Added.

WebCore:

Reviewed by Darin.

Test: http/tests/misc/onload-remove-iframe-crash-2.html

The resulted from an iframe's load event handler removing the iframe
from the document.

  • dom/Document.cpp: (WebCore::Document::implicitClose): Bail out early if an event handler removed the frame.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkCompleted): Protect the frame from deletion by event handlers. (WebCore::FrameLoader::checkCompletedTimerFired): (WebCore::FrameLoader::scheduleCheckCompleted): (WebCore::FrameLoader::detachFromParent): Schedule a completion check on the parent (in case the child is what has been keeping it from completing).
  • loader/FrameLoader.h:
4:35 AM Changeset in webkit [20089] by rwlbuis
  • 1 edit in trunk/WebCore/ChangeLog

I forgot to commit my ChangeLog as part of r20028, sorry about that.

2:00 AM Changeset in webkit [20088] by bdash
  • 3 edits
    2 deletes in trunk

Roll out r20078 as it's causing a crash during layout tests.

1:23 AM Changeset in webkit [23050] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

1:20 AM Changeset in webkit [20087] by sfalken
  • 1 copy in tags/Safari-521.35.7b

New tag.

1:08 AM Changeset in webkit [23049] by oliver
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Forgot to save changelog with reviewer name, correcting

1:01 AM Changeset in webkit [23048] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Steve.

Executing a script for a plugin can cause cause this to be deleted
so we take a reference to our parent prior to executing the script

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
Note: See TracTimeline for information about the timeline view.