⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 10, 2007:

11:20 PM Changeset in webkit [24183] by ggaren
  • 4 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

  • Fixed <rdar://problem/5049509> REGRESSION(10.4.9-9A377a): REAP Suite installer shows empty modal alert window (hangs) if user cancels during "installing shared components" phase


Added Adobe installers to the family of apps that need a data load
loading quirk.


Added a linked-on-or-after check because this code is no longer
Tiger-only.


I tested this code on Tiger and Leopard.

  • Misc/WebKitVersionChecks.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentLoaderMac.mm: (needsDataLoadWorkaround): (WebDocumentLoaderMac::setDataSource):
10:10 PM Changeset in webkit [24182] by weinig
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

  • fast/dom/Window/get-set-properties-expected.txt: Added.
  • fast/dom/Window/get-set-properties.html: Added.

WebCore:

Reviewed by Oliver.

Move more attributes from the pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings

Test: fast/dom/Window/get-set-properties.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Change to use propHashTable in JSDOMWindow instead of KJS::Window
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm: Cleanup getValueProperty and put generation to reduce code duplication.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::closed): (WebCore::DOMWindow::length): (WebCore::DOMWindow::name): (WebCore::DOMWindow::setName): (WebCore::DOMWindow::status): (WebCore::DOMWindow::setStatus): (WebCore::DOMWindow::defaultStatus): (WebCore::DOMWindow::setDefaultStatus):
  • page/DOMWindow.h: (WebCore::DOMWindow::defaultstatus): (WebCore::DOMWindow::setDefaultstatus):
  • page/DOMWindow.idl:
8:46 PM Changeset in webkit [24181] by weinig
  • 4 edits
    3 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for <rdar://problem/5326791>

  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt: Added.
  • http/tests/security/cross-frame-access-put.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html: Added.

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/5326791> XSS vulnerability: ability to set window.defaultStatus,
window.defaultstatus and window.status cross domains

Test: http/tests/security/cross-frame-access-put.html

  • bindings/js/kjs_window.cpp: (KJS::Window::put): Adds isSafeScript check for defaultStatus, defaultstatus and status cases.
8:11 PM Changeset in webkit [24180] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Add an ignore item for a leak in Tiger's Foundation's multipart/mixed-replace support -- I already verified that the bug has been fixed.
7:13 PM Changeset in webkit [24179] by aliceli1
  • 2 edits in trunk/WebKitTools

rubber stamped by Maciej.

fixed <rdar://5137972> editing/selection/editable-links.html fails on Windows

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences): set editable link behavior to match Mac DRT.
6:42 PM Changeset in webkit [24178] by weinig
  • 2 edits in trunk/WebCore

Fix build for BuildBot.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY):
6:38 PM Changeset in webkit [24177] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Sam

<rdar://problem/5326653> - REGRESSION: [WebBackForwardList forwardListCount] might return incorrect result

No layout test because this is an API issue that can't be tested in DRT or the browser

  • history/BackForwardList.cpp: (WebCore::BackForwardList::forwardListCount): If the index is NoCurrentItemIndex, return 0
5:28 PM Changeset in webkit [24176] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Move more readonly attributes from pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Sort the hashmap comment into categories to make further migration easier.
  • bindings/js/kjs_window.h: Sort the enum into categories to make further migration easier. (KJS::Window::):
  • page/DOMWindow.cpp: Add new methods. (WebCore::DOMWindow::focus): (WebCore::DOMWindow::blur): (WebCore::DOMWindow::offscreenBuffering): (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::getComputedStyle): (WebCore::DOMWindow::getMatchedCSSRules): Add null Document assertion. (WebCore::DOMWindow::devicePixelRatio): Add null Frame and Page checks.
  • page/DOMWindow.h: (WebCore::DOMWindow::screenLeft): (WebCore::DOMWindow::screenTop): (WebCore::DOMWindow::pageXOffset): (WebCore::DOMWindow::pageYOffset):
  • page/DOMWindow.idl:
5:23 PM Changeset in webkit [24175] by oliver
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5326417> Editor::unmarkText needs to be crossplatform

Missed this in earlier patch to make text marking platform independent.

  • editing/Editor.cpp: (WebCore::Editor::unmarkText):

Add platform independent impl

  • editing/mac/EditorMac.mm:

Remove the old mac path.

4:52 PM Changeset in webkit [24174] by ggaren
  • 4 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

Added a Page counter. This helped me while investigating
<rdar://problem/5314463> 40MB of WebKit memory still allocated after
closing large email in Mail

  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.cpp: (WebCore::): (WebCore::PageCounter::~PageCounter): (WebCore::Page::Page): (WebCore::Page::~Page):

WebKitTools:

Reviewed by Tim Hatcher.

Ignore Page.o in debug builds because it now has a static PageCounter
object.

  • Scripts/check-for-global-initializers:
4:44 PM Changeset in webkit [24173] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5326126> InspectorResource holds onto more data than it needs

Reduces the fixed size of InspectorResource from 630 bytes to 224 bytes. Now
selectively pick out parts of the ResourceRequest and ResourceResponse objects
for the info needed and store that directly in InspectorResource.

The ResourceRequest and ResourceResponse objects hold a reference to the original
NSURL object, so almost double the data was being kept around. So the struct size
reduction is just the tip of the ice burg on what this really saves.

In a test of 100,000 XMLHTTPRequests using a 85 byte long data URL, I see ~21 MB less
RSIZE compared to Safari running without this change.

  • page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::type): (WebCore::addSourceToFrame): (WebCore::scriptObjectForRequest): (WebCore::scriptObjectForResponse): (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::addAndUpdateScriptResource): (WebCore::updateResourceRequest): (WebCore::updateResourceResponse): (WebCore::InspectorController::updateScriptResourceRequest): (WebCore::InspectorController::updateScriptResourceResponse): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • page/InspectorController.h:
3:42 PM Changeset in webkit [24172] by zimmermann
  • 3 edits in branches/feature-branch/WebCore

Forgot to commit the ChangeLog and two files in my last commit!

3:37 PM Changeset in webkit [24171] by darin
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • fix crash introduced by my patch for 5318732, only seen in release builds
  • page/Page.cpp: (WebCore::Page::~Page): Added a missing null check.
3:30 PM Changeset in webkit [24170] by staikos
  • 2 edits in trunk/WebCore

Patch from Andrea Cavalli to fix sunken state of text fields.
Bug #14576

3:29 PM Changeset in webkit [24169] by zimmermann
  • 17 edits
    5 adds in branches/feature-branch

Reviewed by Sam.

Recognizee <textPath> in SVG JS bindings.
Add JSSVGTextPathElement to JSSVGElementWrapperFactory.

Add SVGException.idl just for the JS generation.
Turn on all SVG JS constructors and add them to DOMWindow.idl.

Testcase added: LayoutTests/svg/custom/js-svg-constructors.svg

3:13 PM Changeset in webkit [24168] by staikos
  • 3 edits in trunk/WebCore

Patch from Qing Zhao to draw focus rects on non-QStyle rendered nodes. Needs a
bit more work once we figure out how to use QPainterPathStroker in a more
sophisticated manner.

3:10 PM Changeset in webkit [24167] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris, reviewed by johnshi

DESC: remove generated header from releasables list.


Turns out some build systems delete the releasables list after the
makmake phase but before the compilation, and hence the generated
header was not found at compile time.

3:04 PM BuildingGdk edited by zecke@selfish.org
(diff)
3:04 PM BuildingGdk edited by zecke@selfish.org
(diff)
2:53 PM Changeset in webkit [24166] by adachan
  • 2 edits in trunk/WebKit/win

2007-07-10 Ada Chan <​adachan@apple.com>

Fixed build.

  • WebView.cpp:
2:46 PM Changeset in webkit [24165] by zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix 'unsigned int' overflow in CodeGeneratorJS.pm.
This fixes hashing of "SVG_FEBLEND_MODE_NORMAL". Its hashvalue exceeded 232, which
is no problem in perl but in the cpp code. Emulate C/C++ behaviour by using "% 232" in
the perl code. Testcase available in feature-branch soon (js-svg-constructors.svg).

2:45 PM Changeset in webkit [24164] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Disabled Arena recycling in RenderArena. PLT shows no regression
(possibly a small speedup), and this can reduce allocated memory in
WebKit clients by about 120K (4K per Arena * 30 Arenas).


I happened upon this optimization while investigating
<rdar://problem/5314463> WebKit hangs on to 40MB RAM after closing
large email in Mail (appears to be render tree arena allocator),
although I don't think it will come close to fixing that bug
completely.

  • rendering/RenderArena.cpp: (WebCore::RenderArena::~RenderArena): Use FinishArenaPool, which frees the ArenaPool's Arenas immediately.
2:37 PM Changeset in webkit [24163] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/replaced/absolute-position-percentage-height-expected.checksum: Added.
  • fast/replaced/absolute-position-percentage-height-expected.png: Added.
  • fast/replaced/absolute-position-percentage-height-expected.txt: Added.
  • fast/replaced/absolute-position-percentage-height.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/replaced/absolute-position-percentage-height.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing): For positioned elements, evaluate the percentage with respect to the container's final height.
1:21 PM Changeset in webkit [24162] by thatcher
  • 1 edit in trunk/WebCore/platform/DeprecatedString.cpp

Build fix.

1:13 PM Changeset in webkit [24161] by beidson
  • 1 edit in trunk/WebCore/platform/DeprecatedString.cpp

Correctness fix

1:08 PM Changeset in webkit [24160] by zbujtas
  • 7 edits in S60/branches/3.1m/WebKit

2007-07-03 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by ​zbujtas@gmail.com.
DESC: merge fixes SYAI-73AS6K and SYAI-73ARXK from 3.2
​http://bugs.webkit.org/show_bug.cgi?id=14389

1:03 PM Changeset in webkit [24159] by darin
  • 2 edits in trunk/WebKit
  • fix build
  • WebView/WebHTMLView.mm: Add include of ContextMenu.h.
12:54 PM Changeset in webkit [24158] by beidson
  • 7 edits in trunk/WebCore

Reviewed by Mark Rowe

Add 64-bit integer converters to our string classes for future work

  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt64):
  • platform/DeprecatedString.h:
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::toInt64): (WebCore::String::toUInt64):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64):
  • platform/StringImpl.h:
12:45 PM Changeset in webkit [24157] by aliceli1
  • 2 edits in trunk/LayoutTests
  • win/Skipped: removing tests that were blocked on lack of support for smart pasting and DOM Paste API
12:21 PM Changeset in webkit [24156] by darin
  • 9 edits in trunk/WebCore

Reviewed by Anders.

  • fix <rdar://problem/5318732> REGRESSION: In Mail, a crash occurs when attempting to send a HTML based message (nytimes.com, washingtonpost.com, latimes.com)

Did an audit of calls to get the inspector and most other uses of Page* and added null
checks since Frame* can outlast its Page*.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Added null check. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::transitionToCommitted): Ditto. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Ditto. (WebCore::FrameLoader::addExtraFieldsToRequest): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto. (WebCore::FrameLoader::requestFromDelegate): Ditto. (WebCore::FrameLoader::canGoBackOrForward): Ditto. (WebCore::FrameLoader::getHistoryLength): Ditto. (WebCore::FrameLoader::historyURL): Ditto. (WebCore::FrameLoader::cachePageForHistoryItem): Ditto. (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Ditto. (WebCore::FrameLoader::goToItem): Ditto. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Ditto. (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto. (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto. (WebCore::FrameLoader::dispatchWillSendRequest): Ditto. (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto. (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto. (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
  • page/ContextMenuController.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): Removed unneeded and unused Page* parameter. (WebCore::openNewWindow): Added null check. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
  • page/InspectorController.h: (WebCore::InspectorController::pageDestroyed): Added. Since this object is owned by the Page and has a back-pointer to it, it needs an explicit disconnect. There's already a higher-level one, but this is more reliable than that.
  • page/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable): Added null check. (WebCore::InspectorController::windowUnloading): Ditto.
  • page/Page.cpp: (WebCore::Page::Page): Updated for change in parameters of ContextMenuController constructor. (WebCore::Page::~Page): Added call to InspectorController pageDestroyed().
  • page/Chrome.cpp: Updated includes.
  • page/DragController.cpp: Ditto.
11:47 AM Changeset in webkit [24155] by darin
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • <rdar://problem/5321953> remove workaround for fixed AppKit mouse moved bug
  • WebView/WebHTMLView.mm: Put the workaround for bug 3429631 inside an ifdef BUILDING_ON_TIGER.
10:44 AM Changeset in webkit [24154] by bdash
  • 1 copy in tags/WebKit-419.3/WebKit

New tag (part 2).

10:43 AM Changeset in webkit [24153] by bdash
  • 1 add in tags/WebKit-419.3

New tag (part 1).

10:42 AM Changeset in webkit [24152] by bdash
  • 1 copy in tags/WebCore-418.23/WebCore

New tag (part 2).

10:42 AM Changeset in webkit [24151] by bdash
  • 1 add in tags/WebCore-418.23

New tag (part 1).

10:39 AM Changeset in webkit [24150] by bdash
  • 4 edits in branches/Safari-2.0-system

Versioning.

9:39 AM Changeset in webkit [24149] by staikos
  • 2 edits in trunk/WebCore

Patch from Adam Treat to make the scroll wheel behave sanely

9:25 AM Changeset in webkit [24148] by ggaren
  • 4 edits
    5 adds in trunk

LayoutTests:

Reviewed by Maciej Stachowiak.

  • fast/events/onload-after-document-close-no-subresource-expected.txt: Added.
  • fast/events/onload-after-document-close-no-subresource.html: Added.
  • fast/events/onload-after-document-close-with-subresource-expected.txt: Added.
  • fast/events/onload-after-document-close-with-subresource.html: Added.
  • fast/events/resources/onload-image.png: Added.

WebCore:

Reviewed by Maciej Stachowiak.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=13241 | <rdar://problem/5126396>
onload fires before content is finished loading (woot.com)


  • dom/Document.cpp: (WebCore::Document::close): Try to go through the normal "Am I done loading?" machinery before dispatching the load event. As the comment indicates, we can't do this in all cases, so the fix isn't perfect. However, a perfect solution would require much riskier sweeping changes to the loader, which are best left for later, I think.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Removed a slightly worse solution to the same problem.
3:25 AM Changeset in webkit [24147] by bdash
  • 2 edits in trunk/WebKitQt

2007-07-10 Mark Rowe <​mrowe@apple.com>

Qt build fix after r24126.

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
2:21 AM Changeset in webkit [24146] by rwlbuis
  • 28 edits
    6 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=8007
createElement() and XHTML (A dynamically created table not rendered as such)

Follow the HTML5 rules of making the name lowercase and then
creating the element in the xhtml namespace.

1:20 AM Changeset in webkit [24145] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-2.0-dashboard.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
1:20 AM Changeset in webkit [24144] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r18365 from ToT to Safari-2.0-dashboard.

2006-12-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

  • bindings/js/kjs_window.cpp: (KJS::Location::toString):
1:20 AM Changeset in webkit [24143] by bdash
  • 3 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-2.0-dashboard.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:
1:20 AM Changeset in webkit [24142] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-2.0-dashboard.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
1:20 AM Changeset in webkit [24141] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-2.0-dashboard.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
1:10 AM Changeset in webkit [24140] by bdash
  • 2 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-1-3-branch.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
1:10 AM Changeset in webkit [24139] by bdash
  • 3 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-1-3-branch.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:
1:10 AM Changeset in webkit [24138] by bdash
  • 2 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-1-3-branch.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
1:10 AM Changeset in webkit [24137] by bdash
  • 2 edits in branches/Safari-1-3-branch/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-1-3-branch.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
1:08 AM Changeset in webkit [24136] by bdash
  • 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-2.0-system.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
1:08 AM Changeset in webkit [24135] by bdash
  • 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r18365 from ToT to Safari-2.0-system.

2006-12-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

  • bindings/js/kjs_window.cpp: (KJS::Location::toString):
1:08 AM Changeset in webkit [24134] by bdash
  • 3 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-2.0-system.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:
1:08 AM Changeset in webkit [24133] by bdash
  • 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-2.0-system.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
1:08 AM Changeset in webkit [24132] by bdash
  • 2 edits in branches/Safari-2.0-system/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-2.0-system.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

Jul 9, 2007:

6:43 PM Changeset in webkit [24131] by staikos
  • 6 edits
    1 add in trunk/WebCore

Patch from Qing Zhao to add context menu support for Qt.

4:38 PM Changeset in webkit [24130] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Moved leaks from Tiger that are marked as fixed in Leopard to a Tiger-only section.
4:23 PM Changeset in webkit [24129] by aliceli1
  • 10 edits in trunk

LayoutTests:

  • win/Skipped: removed one test from skipped list to see whether it will pass with the new DOM Paste API change that is being added simultaneously.

WebKitTools:

Reviewed by Adam Roben.

setting DOM Paste Allowed Pref

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences):

win:

Reviewed by Adam Roben.


Adding DOM Paste Allowed preference, setters and getters
for the purpose of layout tests.

  • Interfaces/IWebPreferences.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::isDOMPasteAllowed): (WebPreferences::setDOMPasteAllowed):
  • WebPreferences.h:
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
4:19 PM Changeset in webkit [24128] by andersca
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
4:18 PM Changeset in webkit [24127] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
3:10 PM Changeset in webkit [24126] by andersca
  • 10 edits in trunk/WebCore

Reviewed by Geoff.

Get rid of the node argument in our various script execution functions.


  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
  • bindings/js/kjs_proxy.h:
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::notifyFinished):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript):
  • loader/FrameLoader.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
3:06 PM Changeset in webkit [24125] by kmccullo
  • 1 edit
    20 adds in trunk/WebKitTools

Reviewed by Adam, Sam, and Ada.

  • Inital checkin of Drosera for Win. This isn't pretty and doesn't connect to Safari but debug builds and runs.
  • Drosera/Images/Drosera.ico: Added.
  • Drosera/Images/small.ico: Added.
  • Drosera/win: Added.
  • Drosera/win/BaseDelegate.h: Added. (BaseDelegate::QueryInterface): (BaseDelegate::didFinishLoadForFrame): (BaseDelegate::windowScriptObjectAvailable): (BaseDelegate::didStartProvisionalLoadForFrame): (BaseDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (BaseDelegate::didFailProvisionalLoadWithError): (BaseDelegate::didCommitLoadForFrame): (BaseDelegate::didReceiveTitle): (BaseDelegate::didReceiveIcon): (BaseDelegate::didFailLoadWithError): (BaseDelegate::didChangeLocationWithinPageForFrame): (BaseDelegate::willPerformClientRedirectToURL): (BaseDelegate::didCancelClientRedirectForFrame): (BaseDelegate::willCloseFrame): (BaseDelegate::createWebViewWithRequest): (BaseDelegate::webViewShow): (BaseDelegate::webViewClose): (BaseDelegate::webViewFocus): (BaseDelegate::webViewUnfocus): (BaseDelegate::webViewFirstResponder): (BaseDelegate::makeFirstResponder): (BaseDelegate::setStatusText): (BaseDelegate::webViewStatusText): (BaseDelegate::webViewAreToolbarsVisible): (BaseDelegate::setToolbarsVisible): (BaseDelegate::webViewIsStatusBarVisible): (BaseDelegate::setStatusBarVisible): (BaseDelegate::webViewIsResizable): (BaseDelegate::setResizable): (BaseDelegate::setFrame): (BaseDelegate::webViewFrame): (BaseDelegate::setContentRect): (BaseDelegate::webViewContentRect): (BaseDelegate::runJavaScriptAlertPanelWithMessage): (BaseDelegate::runJavaScriptConfirmPanelWithMessage): (BaseDelegate::runJavaScriptTextInputPanelWithPrompt): (BaseDelegate::runBeforeUnloadConfirmPanelWithMessage): (BaseDelegate::runOpenPanelForFileButtonWithResultListener): (BaseDelegate::mouseDidMoveOverElement): (BaseDelegate::contextMenuItemsForElement): (BaseDelegate::validateUserInterfaceItem): (BaseDelegate::shouldPerformAction): (BaseDelegate::dragDestinationActionMaskForDraggingInfo): (BaseDelegate::willPerformDragDestinationAction): (BaseDelegate::dragSourceActionMaskForPoint): (BaseDelegate::willPerformDragSourceAction): (BaseDelegate::contextMenuItemSelected): (BaseDelegate::hasCustomMenuImplementation): (BaseDelegate::trackCustomPopupMenu): (BaseDelegate::measureCustomMenuItem): (BaseDelegate::drawCustomMenuItem): (BaseDelegate::addCustomMenuDrawingData): (BaseDelegate::cleanUpCustomMenuDrawingData): (BaseDelegate::canTakeFocus): (BaseDelegate::takeFocus): (BaseDelegate::registerUndoWithTarget): (BaseDelegate::removeAllActionsWithTarget): (BaseDelegate::setActionTitle): (BaseDelegate::undo): (BaseDelegate::redo): (BaseDelegate::canUndo): (BaseDelegate::canRedo):
  • Drosera/win/DebuggerApplication.cpp: Added. (DebuggerApplication::serverLoaded): (DebuggerApplication::serverUnloaded): (DebuggerApplication::attach): (DebuggerApplication::numberOfRowsInTableView): (DebuggerApplication::tableView):
  • Drosera/win/DebuggerApplication.h: Added. (DebuggerApplication::DebuggerApplication): (DebuggerApplication::knownServers):
  • Drosera/win/DebuggerObjectCallbacks.cpp: Added. (breakpointEditorHTMLCallback): (currentFunctionStackCallback): (doubleClickMillisecondsCallback): (evaluateScript_inCallFrame_Callback): (isPausedCallback): (localScopeVariableNamesForCallFrame_Callback): (pauseCallback): (resumeCallback): (stepIntoCallback): (valueForScopeVariableNamed_inCallFrame_Callback): (staticFunctions):
  • Drosera/win/DebuggerObjectCallbacks.h: Added.
  • Drosera/win/Drosera.cpp: Added. (_tWinMain): (RegisterDroseraClass): (DroseraWndProc): (About): (Attach): (Drosera::Drosera): (Drosera::initUI): (Drosera::QueryInterface): (Drosera::AddRef): (Drosera::Release): (Drosera::didFinishLoadForFrame): (getDroseraJSClass): (Drosera::windowScriptObjectAvailable): (Drosera::webViewClose): (Drosera::validateUserInterfaceItem): (Drosera::runJavaScriptAlertPanelWithMessage): (Drosera::onSize):
  • Drosera/win/Drosera.h: Added. (Drosera::webViewLoaded):
  • Drosera/win/Drosera.vcproj: Added.
  • Drosera/win/Drosera.vcproj/Drosera.rc: Added.
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Added.
  • Drosera/win/Drosera.vcproj/debug.vsprops: Added.
  • Drosera/win/Drosera.vcproj/release.vsprops: Added.
  • Drosera/win/HelperFunctions.h: Added. (CFStringToBSTR):
  • Drosera/win/Info.plist: Added.
  • Drosera/win/resource.h: Added.
  • Drosera/win/stdafx.cpp: Added.
  • Drosera/win/stdafx.h: Added.
2:25 PM Changeset in webkit [24124] by staikos
  • 2 edits in trunk/WebKitQt

Patch from Eli Fidler to properly decode data: urls.

2:23 PM Changeset in webkit [24123] by justing
  • 7 edits
    1 add
    1 delete in trunk

LayoutTests:

Rolling the fix for 5310404 back in now that 5310404 has been fixed in Mail.

  • editing/deleting/4845371-expected.checksum:
  • editing/deleting/4845371-expected.txt:
  • editing/deleting/4845371.html:
  • editing/deleting/5126166-expected.txt:
  • editing/deleting/5290534.html: Added.
  • editing/deleting/5290534.html-disabled: Removed.

WebCore:

Rolling the fix for 5290534 back in now that 5310404 has been fixed in Mail.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2:08 PM Changeset in webkit [24122] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little more FrameLoader cleanup while working on <rdar://problem/5126396>.


Rename: "checkEmitLoadEvent" => "checkCallImplicitClose" because the function
doesn't emit the load event; it just calls implicitClose.


Rename: "m_wasLoadEventEmitted" => "m_didCallImplicitClose" because the variable
tracks whether implicitClose was called.

  • dom/Document.cpp: (WebCore::Document::implicitClose): Turned 12 lines of code into 6, adding ASSERT.
  • loader/FrameLoader.h: Removed bogus declaration of non-existent emitLoadEvent().
2:06 PM Changeset in webkit [24121] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris, rs'd by sachin

DESC: remove a compile warning by generating version info earlier

in the build process.

1:27 PM Changeset in webkit [24120] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/5156801> REGRESSION: Crash when deleting table content in Leopard Mail

  • editing/deleting/5156801-expected.checksum: Added.
  • editing/deleting/5156801-expected.png: Added.
  • editing/deleting/5156801-expected.txt: Added.
  • editing/deleting/5156801.html: Added.

WebCore:

Reviewed by John.


REGRESSION: Crash when deleting table content in Leopard Mail

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr for the next node to delete, in case it is destroyed when the current node is deleted. In the crash reported in the radar, we crash because the next node is the div that holds the delete button and it's destroyed when the node that contains the selection is removed.
12:41 PM Changeset in webkit [24119] by staikos
  • 18 edits in trunk

Patch from Adam Treat to convert QWebFrame from QFrame to QObject. Fixes many
regressions from the previous patch.

11:28 AM Changeset in webkit [24118] by andersca
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0


Add tests.


  • plugins/return-error-from-new-stream-callback-in-full-frame-plugin-expected.txt: Added.
  • plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html: Added.

WebCore:

Reviewed by Oliver.

Add DocumentLoader::isLoadingMainResource.

  • WebCore.exp:

WebKit:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0

Add a new initWithFrameLoader: method to WebNetscapePluginStream which is to be used when
the stream is a "fake" stream for full frame plug-ins.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream initWithFrameLoader:]): (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):

WebKitTools:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0


If the src url is "data:application/x-webkit-test-netscape,returnerrorfromnewstream",
return an error from NPP_NewStream.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): (NPP_NewStream):
10:45 AM Changeset in webkit [24117] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin


  • fixed <rdar://problem/5320208> WebKit should prevent Time Machine from backing up WebKit clients' icon databases
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Re-added the code to exclude the icon database from backups. We now do this at the same time we (try to) import the old icon database format, which happens only once per icon database's lifetime. (-[WebIconDatabase _importToWebCoreFormat]): Assert that we haven't imported yet rather than bailing out. It's now the caller's responsibility to check whether we've imported yet.
10:44 AM Changeset in webkit [24116] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

added missing Reviewer to previous checkin

10:43 AM Changeset in webkit [24115] by sullivan
  • 2 edits in trunk/WebCore
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj: exported String::createCFString, needed for <rdar://problem/5320208>
10:21 AM Changeset in webkit [24114] by staikos
  • 2 edits in trunk/WebKitQt

Fix a minor memory leak in the loader

9:52 AM Changeset in webkit [24113] by staikos
  • 2 edits in trunk/WebKitQt

Fix a massive memory leak in the loader.

8:04 AM Changeset in webkit [24112] by yongjzha
  • 2 edits in S60/branches/3.1m/JavaScriptCore

ligman, reviewed by Yongjun Zhang

DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
​http://bugs.webkit.org/show_bug.cgi?id=14435

  • pcre/pcre.c: (compile_branch): (match):
8:01 AM Changeset in webkit [24111] by yongjzha
  • 2 edits in S60/trunk/JavaScriptCore

ligman, reviewed by Yongjun Zhang

DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
​http://bugs.webkit.org/show_bug.cgi?id=14435

  • pcre/pcre.c: (compile_branch): (match):
7:54 AM Changeset in webkit [24110] by yongjzha
  • 4 edits in S60/branches/3.1m/WebCore

2007-06-29 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
​http://bugs.webkit.org/show_bug.cgi?id=14464

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
  • khtml/misc/loader.h: (khtml::):
  • khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):
7:53 AM Changeset in webkit [24109] by yongjzha
  • 4 edits in S60/trunk/WebCore

2007-06-29 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
​http://bugs.webkit.org/show_bug.cgi?id=14464

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
  • khtml/misc/loader.h: (khtml::):
  • khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):
7:50 AM Changeset in webkit [24108] by staikos
  • 4 edits in trunk/WebKitQt

Rework much of WebCoreHttp to make it more stable and support Proxy and SSL.

12:57 AM Changeset in webkit [24107] by mjs
  • 1 edit
    1 add in trunk/WebCore

Reviewed by Maciej.

Test case for the bug below, which is ​http://bugs.webkit.org/show_bug.cgi?id=14207

  • manual-tests/flash-unload-tab.html: Added.
12:39 AM Changeset in webkit [24106] by mjs
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Oliver.


  • JavaScriptCore part of fix for: <rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11


WebCore:

Reviewed by Oliver.

<rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11


Automated test case is not possible. Did not bother with manual test this time.

  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject): Check that runtime root isn't null, as well as instance; this should cover the case where the plugin is already shut down and onunload time.

Jul 8, 2007:

11:29 PM Changeset in webkit [24105] by mjs
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Sam.

  • bindings/js/kjs_window.cpp: (KJS::createWindow): No longer take an immediate argument - always do immediate loads on a newly created Window. Also, do a load of "" to make sure that the right info makes it to the app. (KJS::showModalDialog): Updated for above. (KJS::WindowFunc::callAsFunction): Updated for above.
  • dom/Document.cpp: (WebCore::Document::shouldBeAllowedToLoadLocalResources): If our URL is about:blank, we're allowed if our opener is (since the opener must have written the contents).
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): Add a variant which takes a KURL, which it expects to be pre-completed. This is to avoid completing "" to the opener URL. (WebCore::FrameLoader::urlSelected): Allow loading empty URLs.
  • loader/FrameLoader.h:


Test case is manual only, since it takes particular app behavior to reproduce:


  • manual-tests/new-window-subresource-crash.html: Added.
3:43 PM Changeset in webkit [24104] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python

Expose WebView events to the Python bindings.

2:02 PM Changeset in webkit [24103] by bdash
  • 2 edits in trunk/WebCore

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fix leaks introduced in r24099
  • dom/Element.cpp: (WebCore::Element::~Element): Do not delete the cached computed style here. (WebCore::Element::detach): Delete the computed style here instead. (WebCore::Element::computedStyle): Removed a redundant ref() which was causing the leak. Changed to return 0 if the element is not attached, because in that case there is currently no way to tell when to delete the computed style.
12:36 PM Changeset in webkit [24102] by bdash
  • 2 edits in trunk/WebKitTools

2007-07-08 Mark Rowe <​mrowe@apple.com>

Change name from WebKit/Qt to WebKit.

  • CodeCoverage/regenerate-coverage-display:
11:55 AM Changeset in webkit [24101] by sullivan
  • 2 edits in trunk/WebKit
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Removed the code to exclude the icon database from backups. We still want to do this, but in a way that only runs once ever, instead of once per launch, due to performance concerns.
11:47 AM Changeset in webkit [24100] by bdash
  • 3 edits in trunk/WebKitTools

Mark code coverage scripts as executable.

10:51 AM Changeset in webkit [24099] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/css/computed-style-without-renderer-expected.txt: Added.
  • fast/css/computed-style-without-renderer.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/css/computed-style-without-renderer.html

Implement rich computed style for elements that do not have a renderer.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getPositionOffsetValue): Changed to take a RenderStyle instead of a RenderObject. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to use the computed style returned by the node instead of going through the renderer. Changed properties that compute by measuring the renderer to fall back on returning the length from the RenderStyle if a renderer does not exist. (WebCore::CSSComputedStyleDeclaration::length): Changed to return the number of properties we can compute even if the element has no renderer. (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Changed to use the computed style returned by the node instead of going through the renderer.
  • dom/Element.cpp: (WebCore::ElementRareData::ElementRareData): Added a computed style member, used to cache computed style for elements that do not have a renderer. (WebCore::ElementRareData::resetComputedStyle): Added. (WebCore::Element::~Element): Delete the cached computed style. (WebCore::Element::recalcStyle): Added code to delete the cached computed style when necessary. (WebCore::Element::computedStyle): Added. Returns the style used in rendering the element, if available. Otherwise uses the style selector to compute style for the element.
  • dom/Element.h:
  • dom/Node.cpp: (WebCore::Node::computedStyle): Added. This method returns either the style used in rendering the node, or the style that would be used if the node had a renderer.
  • dom/Node.h:
10:40 AM Changeset in webkit [24098] by bdash
  • 2 edits in trunk/WebCore

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWheelEventToWidget): Changed to return false if the event coordinates are not inside the widget's NSView hierarchy.
8:37 AM Changeset in webkit [24097] by rwlbuis
  • 10 edits
    4 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=10752
The inspector should not respond to Make Text Smaller/Bigger commands

Use the -webkit-text-size-adjust property to ignore text sizing
and do not take the zoom factor into account for line height when
-webkit-text-size-adjust is set to none.

4:49 AM Changeset in webkit [24096] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/5318994> Integer overflow in WebCore's Base64.cpp:base64Encode
  • platform/Base64.cpp: (WebCore::base64Encode): Check against a maximum size. (WebCore::base64Decode): Ditto.
4:47 AM Changeset in webkit [24095] by darin
  • 8 edits in trunk

WebCore:

Reviewed by Maciej.

  • fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check
  • platform/ThreadCheck.h: Renamed _WebCoreThreadViolationCheck to reportThreadViolation since it's in the WebCore namespace and also we shouldn't use leading underscores since those are reserved for the compiler and standard library. Added a new function named setDefaultThreadViolationBehavior and an enum for the parameter. Removed the threadViolationIsException parameter from WebCoreReportThreadViolation since we use a global variable for it now. Got rid of the unnecessary use of do while (0) in the WebCoreThreadViolationCheck macro -- since it's only a single function call it's already a statement and doesn't need to be turned into one with the do while (0) trick.
  • platform/mac/ThreadCheck.mm: (WebCore::readThreadViolationBehaviorFromUserDefaults): Moved the code to read from NSUserDefaults into this helper function. Changed it to use stringForKey instead of objectForKey so we don't get a "method not found" if someone puts something other than a string in there. Updated to use the new globals. (WebCore::setDefaultThreadViolationBehavior): Added. (WebCore::reportThreadViolation): Simplified, now that most of the work is in the readThreadViolationBehaviorFromUserDefaults function. (WebCoreReportThreadViolation): Changed to use a global variable instead of parameter to determine how to report a violation. Added LogOnFirstThreadViolation, which will log only once for each function that violates.
  • WebCore.exp: Updated for above changes.

WebKit:

Reviewed by Maciej.

  • fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check
  • Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_MAIN_THREAD_EXCEPTIONS.
  • WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): In first-time initialization block, check for binaries linked against older versions of WebKit, and set the default thread violation behavior to LogOnFirstThreadViolation.
  • WebView/WebView.mm: (+[WebView initialize]): Improved comments.
2:54 AM Changeset in webkit [24094] by bdash
  • 3 edits
    4 adds in trunk

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/css-generated-content/before-with-first-letter.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer): If a child of the existing 'before' container is not text, do not assume that it is an image, since it can also be an inline wrapping a first-letter. In that case, do not update its style (so in particular, keep it a FIRST_LETTER type style) and leave it to updateFirstLetter() to take care of.

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/css-generated-content/before-with-first-letter-expected.checksum: Added.
  • fast/css-generated-content/before-with-first-letter-expected.png: Added.
  • fast/css-generated-content/before-with-first-letter-expected.txt: Added.
  • fast/css-generated-content/before-with-first-letter.html: Added.

Jul 7, 2007:

6:40 PM Changeset in webkit [24093] by weinig
  • 4 edits in trunk

LayoutTests:

Reviewed by Oliver Hunt.

  • update results after removing extraneous calls to isSafeScript for readonly attributes.
  • http/tests/security/cross-frame-access-expected.txt:

WebCore:

Reviewed by Oliver Hunt.

Bailout early in Window::put() if attribute is readonly to avoid
extra calls to isSafeScript().

  • bindings/js/kjs_window.cpp: (KJS::Window::put):
2:35 PM Changeset in webkit [24092] by darin
  • 4 edits in trunk/LayoutTests
  • updated results (I changed the test at the last minute, but didn't regenerate results)
  • fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Updated.
  • fast/canvas/fill-stroke-clip-reset-path-expected.png: Updated.
  • fast/canvas/fill-stroke-clip-reset-path-expected.txt: Updated.
1:42 PM Changeset in webkit [24091] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

  • test for <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame
  • fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
  • fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
  • fast/canvas/fill-stroke-clip-reset-path.html: Added.

WebCore:

Reviewed by Oliver Hunt.

  • fix <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame

Updated Dashboard quirk so it affects fill, stroke, and clip, rather than just stroke.

Test: fast/canvas/fill-stroke-clip-reset-path.html

  • html/CanvasRenderingContext2D.h: Added clearPathForDashboardBackwardCompatibilityMode.
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode): Added. (WebCore::CanvasRenderingContext2D::fill): Call the new function. (WebCore::CanvasRenderingContext2D::stroke): Replaced in-line code with a call to the new function. (WebCore::CanvasRenderingContext2D::clip): Call the new function.
1:14 PM Changeset in webkit [24090] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Testcase for:
​http://bugs.webkit.org/show_bug.cgi?id=8994
Canvas doesn't reset on resize

  • fast/canvas/canvas-resize-reset-expected.checksum: Added.
  • fast/canvas/canvas-resize-reset-expected.png: Added.
  • fast/canvas/canvas-resize-reset-expected.txt: Added.
  • fast/canvas/canvas-resize-reset.html: Added.

WebCore:

Reviewed and tweaked by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=8994
Canvas doesn't reset on resize

Also reset the rendering context when resetting the canvas.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::drawingContext):
3:11 AM Changeset in webkit [24089] by ap
  • 2 edits in trunk/LayoutTests

Fixed a mismatch between test output and expected results (a typo that was only fixed in the former).

  • fast/loader/early-load-cancel-expected.txt:
3:00 AM Changeset in webkit [24088] by ap
  • 7 edits
    5 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14525
Support exslt:node-set()

Test: fast/xsl/exslt-node-set.xml

  • xml/XSLTExtensions.cpp: Added. (WebCore::exsltNodeSetFunction): A copy of exslt:node-set() implementation from libexslt 1.1.11 (shipped with Tiger). (WebCore::registerXSLTExtensions): This function registers any WebCore-provided extensions on a context. Currently, the only extension is exslt:node-set().
  • xml/XSLTExtensions.h: Added.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Register extensions when creating a context.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add XSLTExtensions.{h,cpp} to projects.

Jul 6, 2007:

11:29 PM Changeset in webkit [24087] by mjs
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Oliver.

  • test case for <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message


  • fast/loader/early-load-cancel-expected.txt: Added.
  • fast/loader/early-load-cancel.html: Added.
  • fast/loader/resources/early-load-cancel-inner.html: Added.

WebCore:

Reviewed by Oliver.

  • fixed <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message


test case: fast/loader/early-load-cancel.html

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel): Don't send cancel-related client callbacks if we never even sent willSendRequest because we were deferred.
9:28 PM Changeset in webkit [24086] by bdash
  • 2 edits in trunk/WebKitTools

2007-07-07 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

  • DumpRenderTree/DumpRenderTree.m: (convertWebResourceResponseToDictionary): Fix leak of two NSMutableString's introduced in r24076.
9:01 PM Changeset in webkit [24085] by oliver
  • 13 edits in trunk

WebCore:

Reviewed by Maciej.

Pulled a number of methods from WebKit and WebCoreFrameBridge into
C++ objects.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::replaceMarkedText):

From -[WebCoreFrameBridge replaceMarkedTextWithText:]

  • editing/Editor.h:
  • page/Frame.cpp: (WebCore::Frame::setMarkedTextRange):

Pulled platform independent logic from Mac specific implementation

(WebCore::Frame::selectRangeInMarkedText):

Converted from -[WebHTMLView _selectRangeInMarkedText:]

  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::setMarkedTextRange):

Now only does Mac specific logic when manipulating initial
NSAttributedString

  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm:

Removed -[WebCoreFrameBridge replaceMarkedTextWithText:]

WebKit:

Reviewed by Maciej.

<rdar://problem/5318756> Need to refactor IM/Marked text code to share logic with windows.

Moved a number of methods from WebHTMLView into WebCore.
Replaced bridge methods with calls directly into WebCore objects.

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView setMarkedText:selectedRange:]): Now calls WebCore object methods directly, rather than calling via the bridge.
7:37 PM Changeset in webkit [24084] by bdash
  • 7 edits
    4 adds in trunk

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/css/first-letter-capitalized.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Moved the call to setFirstLetter further down so that the first letter is not destroyed if a text transform is applied to the remaining text fragment when it is add to the render tree.
  • rendering/RenderText.cpp: (WebCore::RenderText::previousCharacter): Factored out of setTextInternal. (WebCore::RenderText::setTextInternal): Changed to call previousCharacter().
  • rendering/RenderText.h:
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::previousCharacter): Override to return the character in the original string before the start of the fragment.
  • rendering/RenderTextFragment.h:

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/css/first-letter-capitalized-expected.checksum: Added.
  • fast/css/first-letter-capitalized-expected.png: Added.
  • fast/css/first-letter-capitalized-expected.txt: Added.
  • fast/css/first-letter-capitalized.html: Added.
7:35 PM Changeset in webkit [24083] by bdash
  • 2 edits in trunk/WebCore

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Beth.

No test possible because there is no change in functionality.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle): Reset the height and the width in the old style to avoid getting a layout hint as a result of having mutated the old style during layout. (WebCore::RenderTextControl::layout): Update children's layout if an inner block's dimensions should change. This need for layout was previously masked by the bug.
6:02 PM Changeset in webkit [24082] by darin
  • 2 edits in trunk/LayoutTests
  • mac/leopard/Skipped: Updated bug numbers for some bugs that were duplicates.
5:27 PM Changeset in webkit [24081] by beidson
  • 2 edits in trunk/WebCore

Fix builds that use IconDatabaseNone.cpp - better, this time

  • loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::isOpen):
5:20 PM Changeset in webkit [24080] by beidson
  • 2 edits in trunk/WebCore

Fix builds that use IconDatabaseNone.cpp

  • loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::databasePath):
4:48 PM Changeset in webkit [24079] by thatcher
  • 3 edits in trunk/LayoutTests

Reviewed by Adam.

<rdar://problem/5313506> Some attributed string layout tests have an extra space character on Leopard

Leopard serializes empty attribute dictionaries as "{ }", turn these into "{}" to match Tiger.

  • fast/text/attributed-substring-from-range-001.html:
  • mac/leopard/Skipped: Don't skip this test anymore.
4:44 PM Changeset in webkit [24078] by thatcher
  • 1 edit in trunk/WebKitTools/ChangeLog

Fix typo.

4:43 PM Changeset in webkit [24077] by sullivan
  • 8 edits in trunk

WebCore:

Reviewed by Brady


  • WebCore part of fix for: <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files


  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::isOpen): made this method const (necessary to make IconDatabase::databasePath const) (WebCore::IconDatabase::databasePath): new method, returns SQLDatabase's path if open, otherwise empty string


  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::open): don't append a null character to the m_path ivar. The appended null character was making the path() method return a String with a trailing null, which is bad. However, there were no callers to the path() method until now. Instead of appending a null character to the ivar, use charactersWithNullTermination() instead of characters() when opening the database.


  • loader/icon/SQLDatabase.h: (WebCore::SQLDatabase::isOpen): made this method const (necessary to make IconDatabase::databasePath const) (WebCore::SQLDatabase::path): made this method const (not required for these changes, but seemed worth doing at the same time)
  • WebCore.exp: added symbol for IconDatabase::databasePath

WebKit:

Reviewed by Brady

  • WebKit part of fix for: <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Use CSBackupSetItemExcluded to tell Time Machine not to back up the icon database file
4:40 PM Changeset in webkit [24076] by andersca
  • 15 edits in trunk

LayoutTests:

Reviewed by David Kilzer.

<rdar://problem/5313502>
Many webarchive tests fail due to different NSURLResponse serialization on Leopard


  • mac/leopard/Skipped:
  • webarchive/archive-with-unencoded-url-expected.txt:
  • webarchive/test-body-background-expected.txt:
  • webarchive/test-duplicate-resources-expected.txt:
  • webarchive/test-frameset-expected.txt:
  • webarchive/test-img-src-expected.txt:
  • webarchive/test-input-src-expected.txt:
  • webarchive/test-link-href-expected.txt:
  • webarchive/test-object-data-expected.txt:
  • webarchive/test-script-src-expected.txt:
  • webarchive/test-table-background-expected.txt:
  • webarchive/test-td-background-expected.txt:

WebKitTools:

Reviewed by David Kilzer.

<rdar://problem/5313502>
Many webarchive tests fail due to different NSURLResponse serialization on Leopard

Don't dump the serialized form of NSURLResponse. Instead, create a dictionary with the
response's attributes. Also change the JavaScript MIME type to be "text/javascript".


  • DumpRenderTree/DumpRenderTree.m: (convertMIMEType): (convertWebResourceDataToString): (convertWebResourceResponseToDictionary): (serializeWebArchiveToXML):
4:22 PM Changeset in webkit [24075] by thatcher
  • 5 edits in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/5313506> Some attributed string layout tests have an extra space character on Leopard

Don't dump the attributed string's description, this isn't helpfull for the test. Just log
the attribute names at index 0, which we expect to be nothing, to make sure the string
has no attributes.

  • fast/forms/attributed-strings-expected.txt:
  • fast/forms/attributed-strings.html:

WebKitTools:

Reviewed by Oliver.

Initlize the NSMutableAttributedString directly instead of creating
a NSAttributedString first.

  • DumpRenderTree/TextInputController.m: (-[TextInputController attributedStringWithString:]):
3:44 PM Changeset in webkit [24074] by staikos
  • 1 edit in trunk/WebCore/WebCore.pro

missed in previous checkin

3:36 PM Changeset in webkit [24073] by staikos
  • 2 edits
    1 add in trunk/WebCore

Move locatizations into another file.

2:54 PM Changeset in webkit [24072] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little more FrameLoader cleanup while working on <rdar://problem/5126396>.


Moved url() and URL() methods next to each other to highlight their subtlety.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::url):
  • loader/FrameLoader.h:
2:37 PM Changeset in webkit [24071] by andersca
  • 16 edits in trunk

LayoutTests:

Reviewed by David Kilzer.

Update tests.


  • webarchive/archive-empty-frame-dom-expected.txt:
  • webarchive/archive-empty-frame-source-expected.txt:
  • webarchive/archive-with-unencoded-url-expected.txt:
  • webarchive/test-body-background-expected.txt:
  • webarchive/test-duplicate-resources-expected.txt:
  • webarchive/test-frameset-expected.txt:
  • webarchive/test-img-src-expected.txt:
  • webarchive/test-input-src-expected.txt:
  • webarchive/test-link-href-expected.txt:
  • webarchive/test-object-data-expected.txt:
  • webarchive/test-script-src-expected.txt:
  • webarchive/test-table-background-expected.txt:
  • webarchive/test-td-background-expected.txt:

WebKitTools:

Reviewed by David Kilzer.

Replace "Apple Computer" with "Apple" in the DTD declaration.

  • DumpRenderTree/DumpRenderTree.m: (serializeWebArchiveToXML):
2:30 PM Changeset in webkit [24070] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little FrameLoader cleanup while working on <rdar://problem/5126396>.


Renamed endIfNotLoading() to endIfNotLoadingMainResource() because "loading"
and "loadingMainResource" have distinct meanings and this function
honors the latter.

(WebCore::FrameLoader::endIfNotLoadingMainResource): Protect after the
early return to avoid ref count churn.

  • loader/FrameLoader.h: (WebCore::FrameLoader::isLoadingMainResource): Inlined this function.
2:06 PM Changeset in webkit [24069] by staikos
  • 15 edits in trunk

Patch from Adam Treat to convert QWebFrame to a QFrame from a QAbstractScrollArea.

1:52 PM Changeset in webkit [24068] by andersca
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

<rdar://problem/5280532>
REGRESSION: Can't access nested embed by document.name if object is not immediate parent


  • plugins/embed-inside-object-expected.txt: Added.
  • plugins/embed-inside-object.html: Added.

WebCore:

Reviewed by Mitz.

<rdar://problem/5280532>
REGRESSION: Can't access nested embed by document.name if object is not immediate parent


Traverse up the tree looking for an object element.


  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance):
1:29 PM Changeset in webkit [24067] by aroben
  • 2 edits in trunk/LayoutTests

Add another Leopard failure

  • mac/leopard/Skipped:
11:11 AM Changeset in webkit [24066] by aroben
  • 2 edits in trunk/LayoutTests

Add another crasher to the Skipped file

Also moved a test that had a bug filed about it out of the section of
unfiled failures.

  • win/Skipped:
11:00 AM Changeset in webkit [24065] by andersca
  • 4 edits in trunk/LayoutTests

Reviewed by Alexey.

<rdar://problem/5313518> fast/events/iframe-object-onload.html shows events out of order on Leopard


Fix test so that it doesn't matter in what order the frames/objects are loaded. This is done by keeping
the load logs in an array and sort it before dumping it.


  • fast/events/iframe-object-onload-expected.txt:
  • fast/events/iframe-object-onload.html:
  • mac/leopard/Skipped:
10:28 AM Changeset in webkit [24064] by staikos
  • 2 edits in trunk/WebCore

Don't clobber variables that are already set, resulting in a broken build.

10:08 AM Changeset in webkit [24063] by andersca
  • 6 edits
    4 deletes in trunk/LayoutTests

Reviewed by Alexey.

<rdar://problem/5313512> fast/frames/frame-set-same-{location,src}.html sometimes hang on Leopard


Make these tests more robust against frames loading in a different order. Also, turn the tests
into text tests and remove them from the Leopard skipped list.


  • fast/frames/frame-set-same-location-expected.checksum: Removed.
  • fast/frames/frame-set-same-location-expected.png: Removed.
  • fast/frames/frame-set-same-location-expected.txt:
  • fast/frames/frame-set-same-location.html:
  • fast/frames/frame-set-same-src-expected.checksum: Removed.
  • fast/frames/frame-set-same-src-expected.png: Removed.
  • fast/frames/frame-set-same-src-expected.txt:
  • fast/frames/frame-set-same-src.html:
  • mac/leopard/Skipped:
9:54 AM Changeset in webkit [24062] by staikos
  • 2 edits in trunk/WebKitTools

Add --qmakearg=foo to make it possible to configure the build without editing
the .pro files each time.

7:56 AM Changeset in webkit [24061] by bdash
  • 2 edits in trunk/WebKit

2007-07-07 Mark Rowe <​mrowe@apple.com>

Build fix. Update WebDynamicScrollBarsView.h to include methods added and used in r24060.

  • WebView/WebDynamicScrollBarsView.h:
7:40 AM Changeset in webkit [24060] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5236277> REGRESSION-9A458: SPI for setting scroll bar behavior doesn't work

Calling setHorizontalScrollingMode: calls updateScrollers before returning, this will cause
WebCore to reset the scrolling mode based on the CSS overflow rules. So the setAlwaysShowHorizontalScroller:
and setAlwaysShowVerticalScroller: methods needed a way to lock the scrolling mode before
calling updateScrollers.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:andLock:]):
  • WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView setAlwaysShowHorizontalScroller:]):
5:09 AM Changeset in webkit [24059] by mjs
  • 12 edits in trunk

JavaScriptCore:

Reviewed by Antti.

  • <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings


  • Configurations/Base.xcconfig: Re-enable -Wstrict-aliasing
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJNIEnv): Type-pun via a union instead of a pointer cast.
  • wtf/HashMap.h: (WTF::): Instead of doing type-punned assignments via pointer cast, do one of three things: (1) assign directly w/o cast if storage type matches real type; (2) assign using cast via union if type does not need reffing; (3) copy with memcpy and ref/deref manually if type needs reffing. This is ok peref-wise because memcpy of a constant length gets optomized. HashTraits are now expected to make ref()/deref() take the storage type, not the true type.
  • wtf/HashSet.h: (WTF::): Same basic idea.
  • wtf/HashTable.h: (WTF::): Added Assigner template for use by HashMap/HashSet. Change RefCounter to call ref() and deref() via storage type, avoiding the need to type-pun. (WTF::RefCounter::ref): ditto (WTF::RefCounter::deref): ditto
  • wtf/HashTraits.h: (WTF::): Change ref() and deref() for RefPtr HashTraits to take the storage type; cast via union to pointer type.
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::init): Changed from constructor to init function so this can go in a union. (WTF::): redefine pageheap macro in terms of getPageHeap(). (WTF::getPageHeap): new inline function, helper for pageheap macro. This hides the cast in a union. (WTF::TCMalloc_ThreadCache::InitModule): Call init() instead of using placement new to initialize page heap.
  • wtf/TCPageMap.h: (TCMalloc_PageMap1::init): Changed from constructor to init function. (TCMalloc_PageMap2::init): ditto (TCMalloc_PageMap3::init): ditto

WebCore:

Reviewed by Antti.

  • <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings
  • platform/StringHash.h: (WTF::): Adapt to newer way to do storage types.
4:42 AM Changeset in webkit [24058] by bdash
  • 2 edits in trunk/WebCore

2007-07-06 Bernhard Rosenkraenzer <​bero@arklinux.org>

Reviewed by Sam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13985
Bug 13985: WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x

  • rendering/RenderTable.cpp: (WebKit::RenderTable::calcBorderLeft) (WebKit::RenderTable::calcBorderRight)
3:31 AM Changeset in webkit [24057] by bdash
  • 2 edits
    3 adds in trunk/WebCore

2007-07-06 Maxime Britto <​mbritto@pleyo.com>

Reviewed by Maciej.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=13038

Bug 13038: ASSERTION FAILED: item->target().isEmpty()
m_mainFrame->tree()->find(item->target()) == m_mainFrame

Modify an ASSERT in goToItem related to going back/forward in history. We don't need to check the frameset if the target is _blank.
The attached test case is a manual one since it relies on having pages opened in tabs in Safari.

  • manual-tests/goBack-blank-tab-page.html: Added.
  • manual-tests/resources/before-go-back.html: Added.
  • manual-tests/resources/will-go-back.html: Added.
  • page/Page.cpp: (WebCore::Page::goToItem):
3:21 AM Changeset in webkit [24056] by bdash
  • 5 edits in trunk/LayoutTests

2007-07-06 Mark Rowe <​mrowe@apple.com>

Unreviewed. Update test results.

  • fast/encoding/utf-32-big-endian-bom-expected.txt:
  • fast/encoding/utf-32-big-endian-nobom-expected.txt:
  • fast/encoding/utf-32-little-endian-bom-expected.txt:
  • fast/encoding/utf-32-little-endian-nobom-expected.txt:
3:06 AM Changeset in webkit [24055] by bdash
  • 4 edits
    2 adds in trunk

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Test: fast/forms/button-state-restore.html

  • dom/Document.h: (WebCore::Document::isFormElementRegistered): Added.
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form element state only if the element is registered with the document to have its state saved.

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fast/forms/button-state-restore-expected.txt: Added.
  • fast/forms/button-state-restore.html: Added.
3:05 AM Changeset in webkit [24054] by bdash
  • 3 edits
    4 adds in trunk

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Test: fast/repaint/border-fit-lines.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Do a full repaint if -webkit-border-fit:lines was specified.

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fast/repaint/border-fit-lines-expected.checksum: Added.
  • fast/repaint/border-fit-lines-expected.png: Added.
  • fast/repaint/border-fit-lines-expected.txt: Added.
  • fast/repaint/border-fit-lines.html: Added.
3:03 AM Changeset in webkit [24053] by bdash
  • 3 edits
    3 adds in trunk

2007-07-06 Tony Chang <​idealisms@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14516
Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

NULL check m_resourceData to prevent a crash in Safari on Windows.

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::clearResourceData):

2007-07-06 Tony Chang <​idealisms@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14516
Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

  • http/tests/multipart/resources/multipart-nodashes.php: Added.
  • http/tests/multipart/win-boundary-crash-expected.txt: Added.
  • http/tests/multipart/win-boundary-crash.html: Added.
3:00 AM Changeset in webkit [24052] by bdash
  • 7 edits
    8 adds in trunk

2007-07-06 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Alexey.

Test:

  • fast/encoding/utf-32-big-endian-bom.html
  • fast/encoding/utf-32-big-endian-nobom.xml
  • fast/encoding/utf-32-little-endian-bom.html
  • fast/encoding/utf-32-little-endian-nobom.xml
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForBOM): (WebCore::TextResourceDecoder::checkForHeadCharset):
  • platform/TextDecoder.cpp: (WebCore::TextDecoder::checkForBOM):
  • platform/TextDecoder.h:
  • platform/TextEncoding.cpp: (WebCore::UTF32BigEndianEncoding): (WebCore::UTF32LittleEndianEncoding):
  • platform/TextEncoding.h:

2007-07-06 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Alexey.

  • fast/encoding/utf-32-big-endian-bom-expected.txt: Added.
  • fast/encoding/utf-32-big-endian-bom.html: Added.
  • fast/encoding/utf-32-big-endian-nobom-expected.txt: Added.
  • fast/encoding/utf-32-big-endian-nobom.xml: Added.
  • fast/encoding/utf-32-little-endian-bom-expected.txt: Added.
  • fast/encoding/utf-32-little-endian-bom.html: Added.
  • fast/encoding/utf-32-little-endian-nobom-expected.txt: Added.
  • fast/encoding/utf-32-little-endian-nobom.xml: Added.
2:56 AM Changeset in webkit [24051] by bdash
  • 3 edits in trunk/WebCore

2007-07-06 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Maciej.

Start implementening RenderThemeGdk/Gtk using GtkStyle. The approach is
to allocate one native control for each widget type. And use margins, spacing,
style properties from the Widget. And for drawing use GtkStyle on the rect supplied.

This should allow nice integration and be relative resource friendly. Mozilla is using
a similiar approach. They seem to share the GdkPixmap among several operations and this
will be an obvious candidate for improvements. Create a normally big enough GdkPixmap and
use that for drawing and then set clip regions for cairo to make sure to not go beyond the
width and height.

The next steps will be to introduce states for the widgets, add more widgets, handle focus,
and various other style attributes, honor the size and margin and use that to propagate this
back to RenderStyle*.

  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::RenderThemeGdk): (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::copyToContext): (WebCore::RenderThemeGdk::gtkButton): (WebCore::RenderThemeGdk::gtkCheckbox): (WebCore::RenderThemeGdk::gtkRadioButton): (WebCore::RenderThemeGdk::gtkWindowContainer):
  • platform/gdk/RenderThemeGdk.h:
2:52 AM Changeset in webkit [24050] by bdash
  • 2 edits in trunk/WebKit

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView scrollWheel:]): Override the superclass implementation to forward the wheel event to the next responder if this view does not allow scrolling in the event's direction.
2:11 AM Changeset in webkit [24049] by rwlbuis
  • 1 edit in trunk/WebCore/html/CanvasGradient.cpp

Fix build.

2:00 AM Changeset in webkit [24048] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=14442
Adding a stop with value 1.0 to a gradient that has already been used has no effect

Implement start and end stop handling differently so they are not
in the color stop array.

1:44 AM Changeset in webkit [24047] by aroben
  • 7 edits in trunk

Fix <rdar://problem/5301994> Garbled text still showing on some sites

WebCore:

Fix <rdar://problem/5301994> Garbled text still showing on some sites

Replace calls to GetGlyphIndices with wkGetGlyphs.

Reviewed by Alice.

  • platform/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill): Use wkGetGlyphs.
  • platform/win/FontDataWin.cpp: (WebCore::FontData::containsCharacters):

WebKitLibraries:

Update WebKitSystemInterface.{h,lib} for <rdar://problem/5301994>

Reviewed by Alice.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
12:41 AM Changeset in webkit [24046] by pewtermoose
  • 1 edit in trunk/WebKitSite/ChangeLog

Forgot ChangeLog description

12:37 AM Changeset in webkit [24045] by pewtermoose
  • 2 edits in trunk/WebKitSite

Reviewed by Adam Roben.

  • building/build.html:
12:01 AM Changeset in webkit [24044] by pewtermoose
  • 2 edits in trunk/WebCore

Not reviewed - Windows build fix.

  • bridge/win/FrameWin.cpp: (WebCore::imageFromSelection):

Jul 5, 2007:

11:14 PM Changeset in webkit [24043] by staikos
  • 2 edits in trunk/WebKitTools

Add optional --qmake= and --qt arguments to force Qt builds and force with a
specific qmake binary

10:12 PM Changeset in webkit [24042] by staikos
  • 5 edits in trunk

Switch USE(ICONDATABASE) to ENABLE(ICONDATABASE)

8:49 PM Changeset in webkit [24041] by sullivan
  • 18 edits in trunk

WebCore:

Reviewed by Adam

  • WebCore part of fix for <rdar://problem/5315033>
  • rendering/RenderObject.h: replaced PaintRestrictionSelectionOnlyWhiteText with PaintRestrictionSelectionOnlyBlackText (WebCore::RenderObject::PaintInfo::PaintInfo): replaced forceWhiteText with forceBlackText
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false; this method is unimplemented at this level so this has no effect.
  • rendering/RenderText.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false. If true, use the vertical position and height returned by selectionRect rather than replacing it with the more tight-fitting position and height of the line box.
  • dom/Range.h:
  • dom/Range.cpp: (WebCore::Range::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false. Passes this along to RenderObject.
  • page/Frame.h: renamed parameter to selectionImage
  • page/Frame.cpp: (WebCore::Frame::selectionTextRects): pass true for addLineBoxRects new useSelectionHeight parameter, so the rects returned by this new method will match the height that the selection would be painted here (WebCore::Frame::paint): updated for white->black name changes


  • page/mac/FrameMac.mm: (WebCore::Frame::selectionImage): updated for white->black name changes


  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): updated for white->black name changes
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): updated for white->black name changes
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): updated for white->black name changes, and actually use black instead of white. This was the goal of all the name changes.

WebKit:

Reviewed by Adam


  • WebKit part of fix for <rdar://problem/5315033>
  • WebView/WebDocumentPrivate.h: new selectionImageForcingBlackText: method. selectionImageForcingWhiteText: is no longer used and was never in an official release of WebKit, so it could be removed, except that doing so would cause trouble for people using nightly WebKit with Safari 3.0 beta. So I left it in, but made it just force black text instead of white text, which will look different for those nightly WebKit/Safari 3.0 beta people but not break anything.


  • Misc/WebSearchableTextView.m: (-[WebSearchableTextView selectionImageForcingBlackText:]): new unimplemented protocol method for this obsolete class


  • WebView/WebHTMLView.mm: (-[WebHTMLView selectionImageForcingBlackText:]): calls through to WebCore the way selectionImageForcingWhiteText: used to (-[WebHTMLView selectionImageForcingWhiteText:]): now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name


  • WebView/WebPDFView.mm: (-[WebPDFView selectionImageForcingBlackText:]): guts of old selectionImageForcingWhiteText:, but with black substituted for white (-[WebPDFView selectionImageForcingWhiteText:]): now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name
8:33 PM Changeset in webkit [24040] by aroben
  • 1 edit in trunk/LayoutTests/win/Skipped

Forgot the file extension

8:31 PM Changeset in webkit [24039] by aroben
  • 2 edits in trunk/LayoutTests

Updated the Windows Skipped file

  • win/Skipped:
7:28 PM Changeset in webkit [24038] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Fix layout test failures.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Don't make a representation if we're creating the initial document.
6:58 PM Changeset in webkit [24037] by aroben
  • 4 edits
    4 adds
    4 deletes in trunk

Fix Bug 14388: Input in text fields limited to 1024 characters

WebCore:

2007-07-05 Alp Toker <​alp.toker@collabora.co.uk>

Fix Bug 14388: Input in text fields limited to 1024 characters
​http://bugs.webkit.org/show_bug.cgi?id=14388

Slightly modified by Adam Roben.

Reviewed by Adele.

Test: fast/forms/input-length.html

  • html/HTMLInputElement.cpp: Bump limit to 524288. (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLInputElement.h:

LayoutTests:

Added two tests for Bug 14388: Input in text fields limited to 1024 characters

fast/forms/input-maxlength-2.html is obsoleted by
fast/forms/input-maxlength.html.

Reviewed by Adele.

  • fast/forms/input-implicit-length-limit-expected.txt: Added.
  • fast/forms/input-implicit-length-limit.html: Added.
  • fast/forms/input-maxlength-2-expected.checksum: Removed.
  • fast/forms/input-maxlength-2-expected.png: Removed.
  • fast/forms/input-maxlength-2-expected.txt: Removed.
  • fast/forms/input-maxlength-2.html: Removed.
  • fast/forms/input-maxlength-expected.txt: Added.
  • fast/forms/input-maxlength.html: Added.
6:58 PM Changeset in webkit [24036] by aroben
  • 2 edits in trunk/LayoutTests

Add another hanging test to the Leopard Skipped file

Rubberstamped by Adele.

  • mac/leopard/Skipped:
6:14 PM Changeset in webkit [24035] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/RenderThemeWx.cpp

Selected text under MSW should be white too.

6:02 PM Changeset in webkit [24034] by justing
  • 1 edit in trunk/LayoutTests/fast/frames/iframe-double-attach-expected.txt

Updating expected results for r24027.

5:56 PM Changeset in webkit [24033] by kevino
  • 3 edits in branches/wx-port-alpha/trunk/WebKit/wx

Get RunScript working and add a way to test it in the demo.

5:40 PM Changeset in webkit [24032] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/webview.i

Add checks to ensure that you won't get a crash when trying to create a wxWebView or wxWebFrame without a running wx app instance.

5:34 PM Changeset in webkit [24031] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ColorWx.cpp

Fix wxColor->Color conversion.

4:12 PM Changeset in webkit [24030] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init):
4:04 PM Changeset in webkit [24029] by ggaren
  • 2 edits in trunk/LayoutTests

Forgot to add this file for the test for <rdar://problem/5303566> REGRESSION:
XMLHttpRequest.responseXML. Darin added a dummy file before -- here's the
real one.

  • fast/loader/resources/plist.app:
3:56 PM Changeset in webkit [24028] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Geoff.

Add focus, blur and close functions to DOMWindow implementation class
and move bindings from Window to JSDOMWindow.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm: Move prototype function declaration from the implementation to the header.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::focus): (WebCore::DOMWindow::blur): (WebCore::DOMWindow::close):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
3:52 PM Changeset in webkit [24027] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body


Demonstrates bug:

  • editing/style/5279521-expected.checksum: Added.
  • editing/style/5279521-expected.png: Added.
  • editing/style/5279521-expected.txt: Added.
  • editing/style/5279521.html: Added.


Fixed:

  • fast/forms/radio-check-click-and-drag-expected.txt:
  • fast/forms/textarea-type-spaces-expected.txt:

WebCore:

Reviewed by Harrison.

<rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body

  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Previously emitted content shouldn't have to come from a text node in order to emit a '\n' as we exit block containers.
3:50 PM Changeset in webkit [24026] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5315284> REGRESSION: Leopard Launch Time - plugins are being accessed at startup.

Set a response that has a MIME type of "text/html" on the document loader so WebKit won't refresh the
plugin database looking for a plug-in that can handle the document's MIME type (which will be null anyway).


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init):
3:34 PM Changeset in webkit [24025] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5106788>
WebKit loads user style sheets too late as seen in Mail (breaks DataDetectors; Mail flashes wrong font)

Let the document know when the user style sheet is loading so that it try not to display anything
until the user style sheet has finished loading.


  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet): (WebCore::Frame::setUserStyleSheetLocation):
2:02 PM Changeset in webkit [24024] by aroben
  • 2 edits in trunk/WebKit/win

Fix a leak in WebView::setToolTip

Reviewed by Beth.

  • WebView.cpp:

(WebView::setToolTip):

1:43 PM Changeset in webkit [24023] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5314993> Shiira 2.1 throws an exception open a new window: -window: unrecognized selector

Add an empty implementation of this method to prevent Shiira from throwing an exception.
Also log that this method is obsolete and the class will be removed.

  • WebInspector/WebInspector.mm: (-window):
1:16 PM Changeset in webkit [24022] by aroben
  • 4 edits in trunk/WebKit/win

Fix Bug 14143: Tooltips not displayed on Windows
​http://bugs.webkit.org/show_bug.cgi?id=14143
<rdar://problem/4719799>

Reviewed by Oliver.

  • WebChromeClient.cpp:

(WebChromeClient::setToolTip): Call up to WebView.

  • WebView.cpp:

(WebView::WebView): Initialize m_toolTipHwnd member.
(WebView::initWithFrame): Set up the tool tip window.
(initCommonControls): Added.
(WebView::initializeToolTipWindow): Added.
(WebView::setToolTip): Set the tool tip text and enable/disable the
tool tip.

  • WebView.h: Added/updated declarations.
1:11 PM Applications using WebKit edited by jalkut@red-sweater.com
Update MarsEdit info with info and link pertinent to Red Sweater … (diff)
11:09 AM Changeset in webkit [24021] by weinig
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Move JSDOMWindow overriding getOwnPropertySlot logic from KJS::Window
up into JSDOMWindow. No change in functionality so no testcase required.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot):
  • bindings/js/kjs_window.h:
10:51 AM Changeset in webkit [24020] by darin
  • 3 edits
    1 copy
    2 adds in trunk/LayoutTests
  • tweaked IDN test and checked in both Tiger results and Leopard
  • fast/encoding/idn-security.html: Changed test to only test lowercase "a" since the behavior for uppercase letters has changed in the new ICU. Also added code to detect the older ICU and expect different results.
  • fast/encoding/idn-security-expected.txt: Regenerated results.
  • mac/leopard/fast/encoding/idn-security-expected.txt: Copied from fast/encoding/idn-security-expected.txt. The modified.
10:02 AM Changeset in webkit [24019] by weinig
  • 2 edits in trunk/WebCore

Reviewed and Landed by Sam.

  • fix bug 14465 for window.showModalDialog
  • bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures): (KJS::showModalDialog):
9:14 AM Changeset in webkit [24018] by weinig
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14465
window.open() uses the literal "undefined" as the URL

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): add checks for undefined and null values when setting the url.
  • manual-tests/open-url-undefined.html: Added.
6:51 AM Changeset in webkit [24017] by bdash
  • 4 edits in trunk/WebCore

2007-07-05 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Rob Buis.

Rework FontData and FontPlatformData for the Gdk work to make valgrind
happy.

Move destroying of FontConfig and Cairo objects held in FontPlatformData
to FontData::platformDestroy. The ownership of these objects is held by
FontData. This is following the Mac and Qt port at least.

Currently it is possible that FontPlatformData will not create cairo resources
in this case at least make sure the variables are initialized to 0.
Initialize x,y of the cairo_glyph_t with zero to avoid extents.x_advance depending
on subtracing with not defined values.

FontPlatformData::hash. Using FontDescription is a bad idea as we don't have a clue
about how it is packed, if holes are present, etc. The FcPattern and the m_fontMatrix
should be good enough to describe the Font. All other objects are created using these
variables

Replace C-style casts with C++ casts, in this case reinterpret_cast.

  • platform/gdk/FontDataGdk.cpp: (WebCore::FontData::platformInit): Don't assert (WebCore::FontData::platformDestroy): Take over ownership (WebCore::FontData::platformWidthForGlyph): initialize (WebCore::FontData::setFont): be paranoid and assert
  • platform/gdk/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): Initialize everything (WebCore::FontPlatformData::hash): make valgrind happy and don't use m_fontDescription
  • platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): FontData::platformDestroy will do this (WebCore::FontPlatformData::list): Don't use C-style casts. (WebCore::FontPlatformData::setFont): m_fontFace, m_fontMatrix, m_options might not be initialized (WebCore::FontPlatformData::operator==): Don't use C-style casts.
6:47 AM Changeset in webkit [24016] by bdash
  • 4 edits in trunk/WebCore

2007-07-05 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=14445
GraphicsContextCairo code style cleanup

Follow the cr naming convention for cairo_t*.
Remove trailing whitespace.
Replace C casts with C++ casts.
Avoid needless casts.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::adjustLineToPixelBoundaries): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): Save/restore the graphics state. (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/cairo/ImageCairo.cpp: Avoid the confusing ctxt/context naming scheme. (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
6:45 AM Changeset in webkit [24015] by bdash
  • 2 edits in trunk/WebCore

2007-07-05 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=14531
Cairo SVGImage::nativeImageForCurrentFrame() has no return

Return the Cairo surface from the frame cache.

Also add a fall-through else macro with notImplemented() so that future
ports do not make the same mistake.

  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
6:43 AM Changeset in webkit [24014] by bdash
  • 2 edits in trunk/WebCore

2007-07-05 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=14513
Cairo animated GIF support is broken

Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex):
2:15 AM Changeset in webkit [24013] by aroben
  • 1 edit
    3 adds in trunk/LayoutTests

Add a Skipped file for Leopard.

Reviewed by Mark.

  • mac/leopard/Skipped: Added.
1:21 AM Changeset in webkit [24012] by aroben
  • 2 edits in trunk/WebKitTools

Warn about tests in the Skipped file that succeeded

  • Scripts/run-webkit-tests:
1:10 AM Changeset in webkit [24011] by aroben
  • 1 edit
    1 delete in trunk/WebKitTools

Removed unused install-win-extras script

Rubberstamped by Mark.

  • Scripts/install-win-extras: Removed.
12:51 AM Changeset in webkit [24010] by aroben
  • 2 edits in trunk/WebKitTools

Show the test's extension in the results page

  • Scripts/run-webkit-tests:
12:49 AM Changeset in webkit [24009] by aroben
  • 2 edits in trunk/WebKitTools

Add more options for controlling the interpretation of the Skipped file

Reviewed by Mark.

  • Scripts/run-webkit-tests:

Jul 4, 2007:

11:56 PM Changeset in webkit [24008] by aroben
  • 2 edits in trunk/WebKitTools

Add --skipped-only option to run-webkit-tests

When this option is specified, only those tests listed in the Skipped
file are run.

Reviewed by Mark.

  • Scripts/run-webkit-tests:
11:42 PM Changeset in webkit [24007] by aroben
  • 2 edits in trunk/WebKitTools

Clean up/alphabetize the run-webkit-tests help message

  • Scripts/run-webkit-tests:
11:24 PM Changeset in webkit [24006] by aroben
  • 3 edits in trunk/WebKitTools

Enable a Leopard-specific Skipped list.

Reviewed by Mark.

  • Scripts/run-webkit-tests: Check for Leopard.
  • Scripts/webkitdirs.pm: Added isTiger/isLeopard.
11:12 PM Changeset in webkit [24005] by bdash
  • 2 edits in trunk

... and it was reviewed by Adam.

11:08 PM Changeset in webkit [24004] by bdash
  • 3 edits
    9 adds in trunk

2007-07-04 Matt Perry <​mpComplete@gmail.com>

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/5153025>

Treat userGesture as always true for setLocation, forcing a back/forward
entry to be created.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setLocation):

2007-07-04 Matt Perry <​mpComplete@gmail.com>

Test for ​http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/5153025>

Test that assigning to document.location in various ways adds an
item to the back/forward list.

  • http/tests/navigation/document-location-click-expected.txt: Added.
  • http/tests/navigation/document-location-click-timeout-expected.txt: Added.
  • http/tests/navigation/document-location-click-timeout.html: Added.
  • http/tests/navigation/document-location-click.html: Added.
  • http/tests/navigation/document-location-mouseover-expected.txt: Added.
  • http/tests/navigation/document-location-mouseover.html: Added.
  • http/tests/navigation/document-location-onload-expected.txt: Added.
  • http/tests/navigation/document-location-onload.html: Added.
  • http/tests/navigation/resources/document-location.js: Added.
11:04 PM Changeset in webkit [24003] by aroben
  • 2 edits in trunk/WebCore

Restore MouseEventWithHitTestResults::targetNode's old behavior

Reviewed by Mark.

Fixes fast/images/imagemap-case and fast/replace/image-map.

  • page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
node, not the inner non-shared node.

10:21 PM Changeset in webkit [24002] by aroben
  • 5 edits in trunk/WebCore

Mac, Qt, and Gdk build fixes.

  • page/EventHandler.h:
  • page/gdk/EventHandlerGdk.cpp:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passSubframeEventToSubframe):

  • page/qt/EventHandlerQt.cpp:
8:23 PM Changeset in webkit [24001] by aroben
  • 3 edits in trunk/WebCore

Fix the Qt/Gdk builds.

  • page/gdk/EventHandlerGdk.cpp:
  • page/qt/EventHandlerQt.cpp:
8:00 PM Changeset in webkit [24000] by aroben
  • 20 edits in trunk

Move tooltip logic down into WebCore so that it can be shared cross-platform

WebCore:

Move tooltip logic down into WebCore so that it can be shared cross-platform

Reviewed by Sam.

  • page/Chrome.cpp: (WebCore::Chrome::setToolTip): Added.
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
  • platform/graphics/svg/SVGImageEmptyClients.h:

Added stubs for Gdk:

  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::setToolTip):

WebKit:

Move tooltip logic down into WebCore so that it can be shared cross-platform

Reviewed by Sam.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setToolTip): Added.
  • WebView/WebHTMLView.mm: Removed _resetCachedWebPreferences. (-[WebHTMLView _updateMouseoverWithEvent:]): Removed tooltip code. (-[WebHTMLView initWithFrame:]): Removed call to _resetCachedWebPreferences. (-[WebHTMLView setDataSource:]): Ditto.
  • WebView/WebHTMLViewInternal.h: Removed showsURLsInToolTips ivar.
  • WebView/WebHTMLViewPrivate.h: Added declaration for _setTooltip so that WebChromeClient can call it.

WebKit/win:

Added a stub for WebChromeClient::setToolTip

Reviewed by Sam.

  • WebChromeClient.cpp:
  • WebChromeClient.h:

WebKitQt:

Added a stub for ChromeClientQt::setToolTip

Reviewed by Sam.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::setToolTip):
  • WebCoreSupport/ChromeClientQt.h:
8:00 PM Changeset in webkit [23999] by aroben
  • 8 edits in trunk

Add/initialize Settings::showsURLsInToolTips

WebCore:

Add Settings::showsURLsInToolTips

Reviewed by Sam.

  • WebCore.exp:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:

WebKit:

Initialize Settings::showsURLsInToolTips

Reviewed by Sam.

  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKit/win:

Initialize Settings::showsURLsInToolTips

Reviewed by Sam.

  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
8:00 PM Changeset in webkit [23998] by aroben
  • 9 edits in trunk

Move logic for calling mouseDidMoveOverElement into WebCore

WebCore:

Move logic for calling mouseDidMoveOverElement into WebCore

Reviewed by Sam.

  • page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement. (WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional HitTestResult* parameter which is used to communicate to the caller the node the mouse is over.
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::mouseMoved): Changed to call the overloaded mouseMoved(). (WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode through to the subframe so we can get the deepest node hovered, not just the node's parent frame.
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.

WebKit:

Removed call to mouseDidMoveOverElement now that WebCore handles it

Reviewed by Sam.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]):

WebKit/win:

Removed call to mouseDidMoveOverElement now that WebCore handles it

Reviewed by Sam.

  • WebView.cpp: (WebView::handleMouseEvent):
8:00 PM Changeset in webkit [23997] by aroben
  • 16 edits in trunk

Add Chrome::mouseDidMoveOverElement

WebCore:

Add Chrome::mouseDidMoveOverElement

This does the work of calling up to the ChromeClient (which will call
the UI delegate).

Reviewed by Sam.

  • page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement): Added.
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to ChromeClient.
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::mouseDidMoveOverElement):

WebKit:

Add WebChromeClient::mouseDidMoveOverElement

This is not called yet.

Reviewed by Sam.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

WebKit/win:

Add WebChromeClient::mouseDidMoveOverElement

This is not called yet.

Reviewed by Sam.

  • WebChromeClient.cpp: (WebChromeClient::mouseDidMoveOverElement):
  • WebChromeClient.h:

WebKitQt:

Added a stub for ChromeClientQt::mouseDidMoveOverElement

Reviewed by Sam.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement):
  • WebCoreSupport/ChromeClientQt.h:
8:00 PM Changeset in webkit [23996] by aroben
  • 4 edits in trunk/WebCore

Changed PlatformMouseEvent to store the modifier flags of the event

Reviewed by Sam.

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/mac/PlatformMouseEventMac.mm:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/win/PlatformMouseEventWin.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

7:59 PM Changeset in webkit [23995] by aroben
  • 4 edits in trunk/WebCore

Add HitTestResult::setToNonShadowAncestor

Reviewed by Sam.

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint): Moved logic into
HitTestResult::setToNonShadowAncestor.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setToNonShadowAncestor):

  • rendering/HitTestResult.h:
7:59 PM Changeset in webkit [23994] by aroben
  • 4 edits in trunk/WebCore

Change MouseEventWithHitTestResults to hold onto a HitTestResult

Reviewed by Sam.

  • dom/Document.cpp:

(WebCore::Document::prepareMouseEvent):

  • page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
(WebCore::MouseEventWithHitTestResults::targetNode):
(WebCore::MouseEventWithHitTestResults::localPoint):
(WebCore::MouseEventWithHitTestResults::scrollbar):

  • page/MouseEventWithHitTestResults.h:

(WebCore::MouseEventWithHitTestResults::event):
(WebCore::MouseEventWithHitTestResults::hitTestResult):

7:52 PM Changeset in webkit [23993] by darin
  • 3 edits in trunk/LayoutTests
  • take out infinity tests from the test for bug 5292262 (see below) for now since they give different results on PowerPC and Intel and are not an important part of the intent of this test anyway; the bug was about normal numbers, not edge cases like infinity

If we want to test the infinity behavior, we should make a separate test later.

  • fast/objc/longlongTest-expected.txt: Removed results from infinity tests.
  • fast/objc/longlongTest.html: Removed infinity tests.
6:16 PM Changeset in webkit [23992] by pewtermoose
  • 2 edits in trunk/WebCore

Not reviewed, gdk build fix.

  • platform/gdk/FrameGdk.cpp:
3:54 PM Changeset in webkit [23991] by antti
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by John.


Test for Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
<rdar://problem/5237811>

  • fast/table/incomplete-table-in-fragment-hang-expected.txt: Added.
  • fast/table/incomplete-table-in-fragment-hang.html: Added.

WebCore:

Reviewed by John.


Fix Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
<rdar://problem/5237811>


It is possible to add table parts (thead etc) without table ancestor to a document fragment. If a new table element
was added to such a part, as in


div.innerHTML = '<tbody><table>';


the parser error handling code would try to pop the previous table as normal. However since
the table does not actually exist nothing would happen and parser would go to infinite recursion.


Solution here is to pop table parts one by one when handling the error inside a fragment instead of trying to pop
the table straight away (as it might not exist).

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
2:57 PM Changeset in webkit [23990] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx

Fix transparent image support on Windows, and likely GTK too.

2:33 PM Changeset in webkit [23989] by staikos
  • 2 edits in trunk/WebCore

Patch from Qing Zhao to fix combobox rendering

2:23 PM Changeset in webkit [23988] by staikos
  • 3 edits in trunk/WebCore

Compile

1:04 PM Changeset in webkit [23987] by weinig
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14504
REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly

  • fast/dom/Window/window-property-shadowing-expected.txt: Added.
  • fast/dom/Window/window-property-shadowing.html: Added.

WebCore:

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14504
REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly

  • Made it possible (again) to shadow window properties with local variable names.

Test: fast/dom/Window/window-property-shadowing.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customPut):
  • bindings/js/kjs_window.cpp: (KJS::Window::put):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
11:37 AM Changeset in webkit [23986] by aliceli1
  • 10 edits
    3 adds in trunk/WebCore

Reviewed by Adam.

Fixed <rdar://problem/5225119> support smart pasting on Windows

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added new files

  • editing/SmartReplace.cpp: Added. (WebCore::isCharacterSmartReplaceExempt):

Added non-CF implementation placeholder

  • editing/SmartReplace.h: Added.
  • editing/SmartReplaceCF.cpp: Added. (WebCore::getSmartSet): (WebCore::isCharacterSmartReplaceExempt):

Added new implementation

  • bridge/win/FrameWin.cpp:
  • page/Frame.h:
  • page/mac/FrameMac.mm:

Removed old declaration and implementation

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):

Changed to call the new function instead of old

  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm:

Removed old declaration and implementation

(-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):

Changed to call the new function instead of old

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::Pasteboard):

Register new clipboard format

(WebCore::Pasteboard::writeSelection):

Set data for smartpaste format on clipboard

(WebCore::Pasteboard::canSmartReplace):

Added non-stub implementation

11:33 AM Changeset in webkit [23985] by thatcher
  • 2 edits in trunk

Reenable some code for 64-bit now that <rdar://problem/5311640> and <rdar://problem/5311690> are resolved.

8:15 AM Changeset in webkit [23984] by staikos
  • 2 edits in trunk/WebCore

Patch from Qing Zhao: Similar to the PlatformScrollbar fixes, adjust the
painter to make the styler draw all subcontrols, and in this case the focus
rect, in the proper location

3:56 AM Changeset in webkit [23983] by bdash
  • 3 edits in trunk/WebCore

2007-07-04 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

No test possible because DumpRenderTree cannot query the current cursor.

  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Changed into a member function and added that if the last mouse down event could not have started a selection, then the cursor should not change to an I-beam unconditionally. (WebCore::EventHandler::handleMouseMoveEvent):
  • page/EventHandler.h:
3:52 AM Changeset in webkit [23982] by bdash
  • 2 edits in trunk/WebCore

2007-07-04 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Rob Buis.

A little progress in tracking dependencies.

  • WebCore.pro: Add DEPENDPATH for the Gdk port.
12:13 AM Changeset in webkit [23981] by bdash
  • 1 edit in tags/Safari-5522.10.1/WebCore/Configurations/Version.xcconfig

Versioning.

12:13 AM Changeset in webkit [23980] by bdash
  • 1 delete in tags/Safari-5522.10.1/WebCore/ForwardingHeaders/JavaScriptCore

Build fix.

12:10 AM Changeset in webkit [23979] by bdash
  • 1 copy in tags/Safari-5522.10.1

New tag.

Jul 3, 2007:

8:02 PM Changeset in webkit [23978] by darin
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
6:07 PM Changeset in webkit [23977] by thatcher
  • 10 edits
    1 copy in trunk/WebKit

Reviewed by Darin.

Remove HIWebView in 64-bit.

Also disable a few calls that are now gone in 64-bit and filed these bugs:

<rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
<rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
<rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (SyncFrame):
  • Configurations/WebKit.xcconfig:
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView getCarbonEvent:]): (TSMEventHandler):
  • WebKit.LP64.exp: Added.
  • WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):
6:04 PM Changeset in webkit [23976] by thatcher
  • 2 edits in trunk

Disable the strict aliasing warning until <rdar://problem/5311093> is fixed.

6:02 PM Changeset in webkit [23975] by thatcher
  • 1 edit in trunk/WebCore/page/mac/FrameMac.mm

64-bit build fix.

5:58 PM Changeset in webkit [23974] by aroben
  • 2 edits
    1 delete in trunk/WebKitTools

Fixed update-webkit-localizable-strings to work with new extract-localizable-strings

Got rid of extract-webkit-localizable-strings because it was trying to
do update-webkit-localizable-strings' job.

Rubberstamped by Darin.

  • Scripts/extract-webkit-localizable-strings: Removed.
  • Scripts/update-webkit-localizable-strings: Renamed from

extract-localizable-strings.

5:56 PM Changeset in webkit [23973] by thatcher
  • 10 edits
    1 copy in tags/Safari-5522.10/WebKit

Reviewed by Darin.

Remove HIWebView in 64-bit.

Also disable a few calls that are now gone in 64-bit and filed these bugs:

<rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
<rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
<rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (SyncFrame):
  • Configurations/WebKit.xcconfig:
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView getCarbonEvent:]): (TSMEventHandler):
  • WebKit.LP64.exp: Added.
  • WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):
5:40 PM Changeset in webkit [23972] by aroben
  • 6 edits
    1 move
    1 add
    1 delete in trunk

Merge the Windows and Mac localized strings and exceptions files

WebKit:

Merge the Windows and Mac localized strings and exceptions files

Reviewed by Darin and Anders.

  • English.lproj/Localizable.strings: Added Windows strings.
  • StringsNotToBeLocalized.txt: Renamed from WebKit/English.lproj/StringsNotToBeLocalized.txt.

WebKit/win:

Merge the Windows and Mac localized strings and exceptions files

Reviewed by Darin and Anders.

  • English.lproj/Localizable.strings: Added Mac strings.
  • English.lproj/StringsNotToBeLocalized.txt: Removed.

WebKitTools:

Modify scripts to keep Mac/Windows localized strings in sync

extract-webkit-localizable-strings now handles extracting strings from
both the Mac and Windows WebKit ports and updating their respective
Localizable.strings files. extract-localizable-strings is now really a
piece of plumbing rather than a top-level tool.

Reviewed by Darin and Anders.

  • Scripts/extract-localizable-strings: Changed to handle multiple directories.
  • Scripts/extract-webkit-localizable-strings: Added.
5:29 PM Changeset in webkit [23971] by adele
  • 2 edits in trunk/WebKit

Removed printf I accidently left in.

  • Misc/WebNSURLExtras.m: (mapHostNames):
5:06 PM Changeset in webkit [23970] by thatcher
  • 4 edits in tags/Safari-5522.10/WebKit

Merge r23946 to fix 64-bit build.

5:04 PM Changeset in webkit [23969] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

  • tests for <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
  • editing/style/font-family-with-space-expected.txt: Added.
  • editing/style/font-family-with-space.html: Added.
  • fast/inspector/style-expected.txt: Updated expected results to expect "Lucida Grande" in quote marks.

WebCore:

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes

Test: editing/style/font-family-with-space.html

  • css/FontFamilyValue.cpp: (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does. (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just checking for a leading "#" character.
  • editing/markup.cpp: (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency. (WebCore::renderedText): Changed to return a String for better efficiency. (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup. (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call to escapeTextForMarkup in the special case for the style property. (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing call to escapeTextForMarkup in two special cases for the style property.
4:56 PM Changeset in webkit [23968] by thatcher
  • 1 edit in tags/Safari-5522.10/WebCore/page/mac/FrameMac.mm

64-bit build fix.

4:54 PM Changeset in webkit [23967] by adele
  • 1 edit in trunk/WebKit/Misc/WebNSURLExtras.m

Updating comment

4:46 PM Changeset in webkit [23966] by thatcher
  • 2 edits in tags/Safari-5522.10

Disable the strict aliasing warning, not strict aliasing.

4:21 PM Changeset in webkit [23965] by thatcher
  • 2 edits in tags/Safari-5522.10

Turn off strict aliasing until <rdar://problem/5311093> is fixed.

4:19 PM Changeset in webkit [23964] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Twelfth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add casts and accompanying FIXMEs to avoid remaining compiler errors.
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages):
  • loader/FrameLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse):
4:16 PM Changeset in webkit [23963] by adele
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • fast/encoding/idn-security-expected.txt: Added.
  • fast/encoding/idn-security.html: Added.
  • win/Skipped: Blocked by <rdar://problem/5301954>.

WebKit:

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

WebKitTools:

Reviewed by Darin.

Extended DumpRenderTree to test encoding and decoding host names.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added cases for encodeHostName and decodeHostName. (+[LayoutTestController webScriptNameForSelector:]): ditto. (-[LayoutTestController decodeHostName:]): Added. (-[LayoutTestController encodeHostName:]): Added.
4:03 PM Changeset in webkit [23962] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/samples/simple.py

Add some more functionality to the basic sample.

3:51 PM Changeset in webkit [23961] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add functions to test long long and unsigned long long.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController objCLongLongRoundTrip:]): (-[LayoutTestController objCUnsignedLongLongRoundTrip:]):
3:37 PM Changeset in webkit [23960] by weinig
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Fixes a real bug where where we were setting long long and unsigned long long values to a long field.
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):

LayoutTests:

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • fast/objc: Added.
  • fast/objc/longlongTest-expected.txt: Added.
  • fast/objc/longlongTest.html: Added.
3:11 PM Changeset in webkit [23959] by thatcher
  • 2 edits in tags/Safari-5522.10/WebCore

Merge r23894.

3:04 PM Changeset in webkit [23958] by thatcher
  • 3 edits in tags/Safari-5522.10

Turn off -Wshorten-64-to-32 until <rdar://problems/5292100&5292113&5292262> are fixed.

3:02 PM Changeset in webkit [23957] by darin
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

  • fix <rdar://problem/5310848> WebDataSource lifetime problem -- may be cause of the leaks seen on the buildbot
  • WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): Added a call to the new detachDataSource function. (-[WebDataSourcePrivate finalize]): Ditto.
  • WebView/WebDocumentLoaderMac.h: Added detachDataSource function to be used when the WebDataSource is deallocated. Added retain/releaseDataSource helper functions to be used to retain and release the data source object. Replaced the m_hasEverBeenDetached boolean with a more primitive and hence easier to understand m_isDataSourceRetained boolean.
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac): Initialize m_isDataSourceRetained to false. (WebDocumentLoaderMac::setDataSource): Call retainDataSource instead of calling HardRetain on the dataSource parameter. Also updated a comment. (WebDocumentLoaderMac::attachToFrame): Call retainDataSource unconditionally rather than trying to use m_hasEverBeenDetached to decide if a retain is needed. Also got rid of an assertion that m_loadingResources is empty -- not important any more. (WebDocumentLoaderMac::detachFromFrame): Call releaseDataSource instead of using HardRelease, but only if m_loadingResources is empty. If it's non-empty, then we'll do the releaseDataSource later in decreaseLoadCount. (WebDocumentLoaderMac::increaseLoadCount): Call retainDataSource unconditionally rather than calling HardRetain only if the old set of resources was empty. (WebDocumentLoaderMac::decreaseLoadCount): Call releaseDataSource if m_loadingResources is empty and we're not attached to a frame. If we are attached to a frame, then we'll do the releaseDataSource later in detachFromFrame. (WebDocumentLoaderMac::retainDataSource): Added. Calls CFRetain, but only if the data source is not already retained (according to the boolean). (WebDocumentLoaderMac::releaseDataSource): Added. Calls CFRelease, but only if the data source is currently retained (according to the boolean). (WebDocumentLoaderMac::detachDataSource): Added. Sets m_dataSource to nil. Since this is only called from WebDataSource's dealloc and finalize methods, it won't ever be called when the m_isDataSourceRetained boolean is true.
3:01 PM Changeset in webkit [23956] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5093862>
Nothing shown in plugin area when trying to play content using the DivX plugin


Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks):
2:35 PM Changeset in webkit [23955] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Brady Eidson.

Tenth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add explicit casts.
  • kjs/dtoa.cpp: (Bigint::):
2:21 PM Changeset in webkit [23954] by darin
  • 2 edits in trunk/WebKit
  • forgot to check in one file in the fix for <rdar://problem/5307880> some classes need finalize methods because of non-trivial work done in dealloc methods
  • WebView/WebView.mm: (-[WebViewPrivate finalize]): Delete identifierMap so it doesn't leak.
2:17 PM Changeset in webkit [23953] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Brady Eidson.

Ninth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Fix function signature to use unsigned long instead of unsigned long long.
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::completeProgress):
  • loader/ProgressTracker.h:
2:11 PM Changeset in webkit [23952] by thatcher
  • 1 copy in tags/Safari-5522.10

New tag.

1:46 PM Changeset in webkit [23951] by weinig
  • 44 edits in trunk/WebCore

Reviewed by Oliver.

Eighth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Convert SVG implementation files to use floats instead of doubles to match the spec/IDLs.
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::getEndTime): (WebCore::SVGAnimationElement::getStartTime): (WebCore::SVGAnimationElement::getCurrentTime): (WebCore::SVGAnimationElement::getSimpleDuration):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox):
  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString):
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGMatrix.idl:
  • ksvg2/svg/SVGNumber.idl:
  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc): (WebCore::SVGPathParser::svgLineToHorizontal): (WebCore::SVGPathParser::svgLineToVertical): (WebCore::SVGPathParser::svgCurveToCubicSmooth): (WebCore::SVGPathParser::svgCurveToQuadratic): (WebCore::SVGPathParser::svgCurveToQuadraticSmooth): (WebCore::SVGPathParser::svgArcTo):
  • ksvg2/svg/SVGParserUtilities.h:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::getPathSegAtLength): (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathElement::svgMoveTo): (WebCore::SVGPathElement::svgLineTo): (WebCore::SVGPathElement::svgLineToHorizontal): (WebCore::SVGPathElement::svgLineToVertical): (WebCore::SVGPathElement::svgCurveToCubic): (WebCore::SVGPathElement::svgCurveToCubicSmooth): (WebCore::SVGPathElement::svgCurveToQuadratic): (WebCore::SVGPathElement::svgCurveToQuadraticSmooth): (WebCore::SVGPathElement::svgArcTo): (WebCore::SVGPathElement::parseMappedAttribute):
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs): (WebCore::SVGPathSegArcAbs::setX): (WebCore::SVGPathSegArcAbs::x): (WebCore::SVGPathSegArcAbs::setY): (WebCore::SVGPathSegArcAbs::y): (WebCore::SVGPathSegArcAbs::setR1): (WebCore::SVGPathSegArcAbs::r1): (WebCore::SVGPathSegArcAbs::setR2): (WebCore::SVGPathSegArcAbs::r2): (WebCore::SVGPathSegArcAbs::setAngle): (WebCore::SVGPathSegArcAbs::angle): (WebCore::SVGPathSegArcRel::SVGPathSegArcRel): (WebCore::SVGPathSegArcRel::setX): (WebCore::SVGPathSegArcRel::x): (WebCore::SVGPathSegArcRel::setY): (WebCore::SVGPathSegArcRel::y): (WebCore::SVGPathSegArcRel::setR1): (WebCore::SVGPathSegArcRel::r1): (WebCore::SVGPathSegArcRel::setR2): (WebCore::SVGPathSegArcRel::r2): (WebCore::SVGPathSegArcRel::setAngle): (WebCore::SVGPathSegArcRel::angle):
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.cpp: (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs): (WebCore::SVGPathSegCurvetoCubicAbs::setX): (WebCore::SVGPathSegCurvetoCubicAbs::x): (WebCore::SVGPathSegCurvetoCubicAbs::setY): (WebCore::SVGPathSegCurvetoCubicAbs::y): (WebCore::SVGPathSegCurvetoCubicAbs::setX1): (WebCore::SVGPathSegCurvetoCubicAbs::x1): (WebCore::SVGPathSegCurvetoCubicAbs::setY1): (WebCore::SVGPathSegCurvetoCubicAbs::y1): (WebCore::SVGPathSegCurvetoCubicAbs::setX2): (WebCore::SVGPathSegCurvetoCubicAbs::x2): (WebCore::SVGPathSegCurvetoCubicAbs::setY2): (WebCore::SVGPathSegCurvetoCubicAbs::y2): (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel): (WebCore::SVGPathSegCurvetoCubicRel::setX): (WebCore::SVGPathSegCurvetoCubicRel::x): (WebCore::SVGPathSegCurvetoCubicRel::setY): (WebCore::SVGPathSegCurvetoCubicRel::y): (WebCore::SVGPathSegCurvetoCubicRel::setX1): (WebCore::SVGPathSegCurvetoCubicRel::x1): (WebCore::SVGPathSegCurvetoCubicRel::setY1): (WebCore::SVGPathSegCurvetoCubicRel::y1): (WebCore::SVGPathSegCurvetoCubicRel::setX2): (WebCore::SVGPathSegCurvetoCubicRel::x2): (WebCore::SVGPathSegCurvetoCubicRel::setY2): (WebCore::SVGPathSegCurvetoCubicRel::y2):
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX): (WebCore::SVGPathSegCurvetoCubicSmoothRel::x): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY): (WebCore::SVGPathSegCurvetoCubicSmoothRel::y): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::x2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp: (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathSegCurvetoQuadraticAbs::setX): (WebCore::SVGPathSegCurvetoQuadraticAbs::x): (WebCore::SVGPathSegCurvetoQuadraticAbs::setY): (WebCore::SVGPathSegCurvetoQuadraticAbs::y): (WebCore::SVGPathSegCurvetoQuadraticAbs::setX1): (WebCore::SVGPathSegCurvetoQuadraticAbs::x1): (WebCore::SVGPathSegCurvetoQuadraticAbs::setY1): (WebCore::SVGPathSegCurvetoQuadraticAbs::y1): (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathSegCurvetoQuadraticRel::setX): (WebCore::SVGPathSegCurvetoQuadraticRel::x): (WebCore::SVGPathSegCurvetoQuadraticRel::setY): (WebCore::SVGPathSegCurvetoQuadraticRel::y): (WebCore::SVGPathSegCurvetoQuadraticRel::setX1): (WebCore::SVGPathSegCurvetoQuadraticRel::x1): (WebCore::SVGPathSegCurvetoQuadraticRel::setY1): (WebCore::SVGPathSegCurvetoQuadraticRel::y1):
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.cpp: (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs): (WebCore::SVGPathSegLinetoAbs::setX): (WebCore::SVGPathSegLinetoAbs::x): (WebCore::SVGPathSegLinetoAbs::setY): (WebCore::SVGPathSegLinetoAbs::y): (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel): (WebCore::SVGPathSegLinetoRel::setX): (WebCore::SVGPathSegLinetoRel::x): (WebCore::SVGPathSegLinetoRel::setY): (WebCore::SVGPathSegLinetoRel::y):
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.cpp: (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathSegLinetoHorizontalAbs::setX): (WebCore::SVGPathSegLinetoHorizontalAbs::x): (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel): (WebCore::SVGPathSegLinetoHorizontalRel::setX): (WebCore::SVGPathSegLinetoHorizontalRel::x):
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.cpp: (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs): (WebCore::SVGPathSegLinetoVerticalAbs::setY): (WebCore::SVGPathSegLinetoVerticalAbs::y): (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel): (WebCore::SVGPathSegLinetoVerticalRel::setY): (WebCore::SVGPathSegLinetoVerticalRel::y):
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPathSegMoveto.cpp: (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs): (WebCore::SVGPathSegMovetoAbs::setX): (WebCore::SVGPathSegMovetoAbs::x): (WebCore::SVGPathSegMovetoAbs::setY): (WebCore::SVGPathSegMovetoAbs::y): (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel): (WebCore::SVGPathSegMovetoRel::setX): (WebCore::SVGPathSegMovetoRel::x): (WebCore::SVGPathSegMovetoRel::setY): (WebCore::SVGPathSegMovetoRel::y):
  • ksvg2/svg/SVGPathSegMoveto.h:
  • ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgPolyTo):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::getCurrentTime):
  • ksvg2/svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): (WebCore::SVGStopElement::parseMappedAttribute):
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGTransform.cpp: (SVGTransform::translate): (SVGTransform::scale):
  • ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::distance):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
1:15 PM Changeset in webkit [23950] by andersca
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5289718>
​http://bugs.webkit.org/show_bug.cgi?id=14437
CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)


Add test from Alexey Proskuryakov.


  • plugins/plugin-remove-subframe-expected.txt: Added.
  • plugins/plugin-remove-subframe.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5289718>
​http://bugs.webkit.org/show_bug.cgi?id=14437
CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)


Based on a patch from Maxime Britto.


  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys its frame.

(-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
ASSERT that this is only called on the main frame.

WebKit:

Reviewed by Darin.

  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): ASSERT that the value returned isn't nil. It can't be nil when invoked on the main frame.
12:22 PM Changeset in webkit [23949] by sullivan
  • 2 edits in trunk/WebCore

Written by Darin, reviewed by me


  • fixed <rdar://problem/5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local documents more than once due to canonicalization change
  • loader/mac/LoaderNSURLExtras.m: (canonicalURL): pass URL through KURL so we get KURL's version of canonicalization as well as NSURLProtocol's version of canonicalization
12:14 PM Changeset in webkit [23948] by weinig
  • 38 edits in trunk

LayoutTests:

Reviewed by Darin.

Seventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Change from double -> float caused some slight changes.
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:

WebCore:

Reviewed by Darin.

Seventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
  • Changes over more implicit conversions to use new functions.
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • platform/graphics/FloatPoint.cpp: (WebCore::FloatPoint::matrixTransform): (WebCore::FloatPoint::narrowPrecision):
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.cpp: (WebCore::FloatRect::narrowPrecision):
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp: (WebCore::FloatSize::narrowPrecision):
  • platform/graphics/FloatSize.h:
  • platform/graphics/Path.cpp: (WebCore::Path::createRoundedRectangle): (WebCore::Path::createRectangle): (WebCore::Path::createEllipse):
  • platform/graphics/mac/ColorMac.mm: (WebCore::nsColor):
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::paint):
  • platform/graphics/svg/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::CGShadingRefForRadialGradient): (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache): (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::mapAbsolutePointToLocal):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::calcViewport):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::relativeBBox):
10:55 AM Changeset in webkit [23947] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5261523>
Crash playing MP11 on cnbc.com


The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
always removing the "windowlessvideo" parameter before passing it to the plugin.
According to ​http://msdn2.microsoft.com/en-us/library/bb249373.aspx, "The windowlessVideo property is not
supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::paint): (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::setParameters): (WebCore::PluginViewWin::PluginViewWin): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::):
9:21 AM Changeset in webkit [23946] by bdash
  • 4 edits in trunk/WebKit

2007-07-04 Mark Rowe <​mrowe@apple.com>

Unreviewed 64-bit build fixes.

  • WebCoreSupport/WebInspectorClient.mm: Let the compiler know that WebFrameView is a subclass of NSView.
  • WebView/WebDocumentInternal.h: Remove our preprocessor macro once we're done with it.
  • WebView/WebHTMLView.mm: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Fix argument types.
8:29 AM Changeset in webkit [23945] by staikos
  • 2 edits in trunk/WebCore

Patch from Qing Zhao to fix sunken state improperly set.

6:42 AM Changeset in webkit [23944] by antti
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.


Test for REGRESSION: misplaced selection ring remains after link is no longer focused.
<rdar://problem/5205580>

  • fast/repaint/focus-layers-expected.checksum: Added.
  • fast/repaint/focus-layers-expected.png: Added.
  • fast/repaint/focus-layers-expected.txt: Added.
  • fast/repaint/focus-layers.html: Added.

WebCore:

Reviewed by Maciej.


REGRESSION: misplaced selection ring remains after link is no longer focused.
<rdar://problem/5205580>


Fix placement of selection ring when part of the ring is in a different layer.

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Don't reset state variables when not necessary. When repaint() was called at the end of setSyle() it would get repaint rects wrong in some cases.
6:31 AM Changeset in webkit [23943] by antti
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
<rdar://problem/5263939>


No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
m_frame could be null for a live FrameView object.

  • page/FrameView.cpp: (WebCore::FrameView::needsLayout):
5:58 AM Changeset in webkit [23942] by rwlbuis
  • 2 edits in branches/feature-branch/LayoutTests

Correcting the pixel test result that was supposed to go in during r23849.

Jul 2, 2007:

10:52 PM Changeset in webkit [23941] by aroben
  • 2 edits in trunk/LayoutTests

Update the Windows Skipped list.

  • win/Skipped:
6:36 PM Changeset in webkit [23940] by aroben
  • 6 edits in trunk/LayoutTests

Update results after r23938.

  • fast/inline-block/14498-positionForCoordinates-expected.txt:
  • fast/table/click-near-anonymous-table-expected.txt:
  • svg/custom/pointer-events-image-expected.txt:
  • svg/custom/pointer-events-path-expected.txt:
  • svg/custom/text-hit-test-expected.txt:
5:53 PM Changeset in webkit [23939] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5098378> single-pixel image optimization needs to be rewritten to not depend on floating point bitmap
Tested by fast/replaced/image-solid-color-with-alpha.html

Switch from float to byte based bitmap when pulling the color from 1x1 pixel images so
that we can use the single pixel image optimisation in WebKit/win.

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::checkForSolidColor):
4:54 PM Changeset in webkit [23938] by aroben
  • 3 edits
    2 adds in trunk

Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error

WebCore:

Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
​http://bugs.webkit.org/show_bug.cgi?id=14498

There were two bugs:
1) xPos/yPos were flipped
2) + binds tighter than ?:, so the order of operations was incorrect

Reviewed by Darin.

Test: fast/inline-block/14498-positionForCoordinates.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates):

LayoutTests:

Test for Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
​http://bugs.webkit.org/show_bug.cgi?id=14498

Reviewed by Darin.

  • fast/inline-block/14498-positionForCoordinates-expected.txt: Added.
  • fast/inline-block/14498-positionForCoordinates.html: Added.
4:30 PM Changeset in webkit [23937] by darin
  • 6 edits in trunk/WebKit

Reviewed by Kevin Decker and Tim Hatcher.

  • fix <rdar://problem/5307880> some classes need finalize methods because of non-trivial work done in dealloc methods
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer dealloc]): Added a comment about how this probably won't work under GC.
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight dealloc]): Ditto.
  • WebView/WebDataSource.mm: (+[WebDataSourcePrivate initialize]): Added. Makes finalize run on main thread. (-[WebDataSourcePrivate finalize]): Added. Calls deref on the document loader.
  • WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]): Added. Makes finalize run on main thread. (-[WebHTMLViewPrivate finalize]): Added. Calls deref on promisedDragTIFFDataSource.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode be Xcode.
4:29 PM Changeset in webkit [23936] by darin
  • 4 edits in trunk/WebCore

Reviewed by Kevin Decker and Tim Hatcher.

  • fix <rdar://problem/5307906> some classes need finalize methods because of non-trivial work done in dealloc methods
  • bindings/objc/DOMRGBColor.mm: (+[DOMRGBColor initialize]): Added. Tells finalizer to run on main thread, which is needed because we are sharing a CFDictionary here with no locking.
  • bridge/mac/WebCoreAXObject.mm: (+[WebCoreAXObject initialize]): Added. Tells finalizer to run on main thread. (-[WebCoreAXObject finalize]): Added. Calls detach.
  • WebCore.xcodeproj/project.pbxproj: Let Xcode do what it wants to do.
4:20 PM Changeset in webkit [23935] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Darin.

Sixth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Use new narrowPrecisionToFloat() and narrowPrecisionToCGFloat() where
appropriate.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::handleTimerEvent): (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • platform/graphics/cg/AffineTransformCG.cpp: (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::map): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::shear):
4:05 PM Changeset in webkit [23934] by kevino
  • 6 edits in branches/wx-port-alpha/trunk

Enable RTTI and exceptions for now, fix a linking issue with libjpeg on Win, and improve support for building with Python versions other than 2.5.

3:14 PM Changeset in webkit [23933] by sullivan
  • 2 edits in trunk/WebCore
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): added a comment
1:47 PM Changeset in webkit [23932] by weinig
  • 5 edits
    1 move in trunk/WebCore

Rubberstamped by Darin.

Rename FloatConversionUtilities.h to FloatConversion.h.
Fix Win32 build.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DeprecatedString.cpp:
  • platform/FloatConversion.h: Copied from platform/FloatConversionUtilities.h.
  • platform/FloatConversionUtilities.h: Removed.
  • platform/StringImpl.cpp:
1:41 PM Changeset in webkit [23931] by weinig
  • 12 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Kevin McCullough.

Fourth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add custom piDouble and piFloat constants to use instead of M_PI.

  • kjs/math_object.cpp: (MathObjectImp::getValueProperty):
  • wtf/MathExtras.h: (wtf_atan2):

WebCore:

Reviewed by Darin.

Fifth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add toFloat() method to string classes and use it where appropriate.

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.cpp: (WebCore::CSSParser::lex):
  • ksvg2/svg/SVGAngle.cpp: (WebCore::SVGAngle::setValueAsString):
  • platform/AtomicString.h: (WebCore::AtomicString::toFloat):
  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::toFloat):
  • platform/DeprecatedString.h:
  • platform/FloatConversionUtilities.h: Added. (WebCore::narrowPrecisionToFloat): (WebCore::narrowPrecisionToCGFloat):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::toFloat):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toFloat):
  • platform/StringImpl.h:
11:44 AM Changeset in webkit [23930] by weinig
  • 11 edits in trunk

JavaScriptCore:

Reviewed by Kevin McCullough.

Third round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add custom piDouble and piFloat constants to use instead of M_PI.

  • kjs/math_object.cpp: (MathObjectImp::getValueProperty):
  • wtf/MathExtras.h: (wtf_atan2):

WebCore:

Reviewed by Kevin McCullough.

Third round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Use new piDouble and piFloat constants instead of M_PI.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::rotate):
  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::calculateArc):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::createEllipse):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc):
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::setCurrentPage):
  • platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
  • rendering/RenderPath.cpp: (WebCore::drawMarkerWithData):
11:12 AM BuildingGdk edited by alp@atoker.com
Update deps and tasks (diff)
8:52 AM Changeset in webkit [23929] by brmorris
  • 2 edits in S60/trunk/WebKit

brad, rs'd by sachin.

DESC: merge r23928 to trunk: noise suppression - typo in version.mk
causing a scanlog error ..

  • group/version.mk: typo in RELEASABLES phase.
8:50 AM Changeset in webkit [23928] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

brad, rs'd by sachin.

DESC: noise suppression - typo in version.mk causing a scanlog error ..

  • group/version.mk: typo in RELEASABLES phase.
7:08 AM Changeset in webkit [23927] by bdash
  • 2 edits in trunk/WebKitSite

2007-07-02 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • quality/reduction.html:
12:42 AM Changeset in webkit [23926] by oliver
  • 2 edits in trunk/WebKit

Reviewed by Justin.

Fix for

<rdar://problem/5290113> WebKit does not correctly handle replacement ranges from the IM in -[WebHTMLView insertText:]
​http://bugs.webkit.org/show_bug.cgi?id=13664

We replicate the logic of -[WebHTMLView setMarkedText:selectedRange:] to handle the Input Method
feeding us a replacement string through insertText: so we can handle IMs that use insertText to
replace text.

  • WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]):

Jul 1, 2007:

10:48 PM Changeset in webkit [23925] by aroben
  • 2 edits in trunk/WebCore

Clarify/fix {Shadow,BorderImage}ParseContext's memory management

Prefast emitted warnings that drew my attention to
{Shadow,BorderImage}ParseContext::failed(). It turned out that these
methods were actually correct, but rather confusing. "failed" really
meant "abort and clean up" rather than "did you fail?", which was
unclear. However, once I figured that out, the "and clean up" part was
still a bit confusing, because all failed() did was to set a flag that
would later cause the ParseContext's members to be deleted in the
destructor. To clear this up, I've gotten rid of the failed() method
altogether. It always returned false, so I've replaced all calls to
it with the value false.

I also noticed that the lifetime management of the ParseContexts'
members was in all cases confusing, and in some cases wrong. The
m_border{Top,Right,Bottom,Left} members of BorderImageParseContext
were leaked whenever a border-image property was successfully parsed.
I fixed that by holding these members in OwnPtrs. The
CSSPrimitiveValue members of {Shadow,BorderImage}ParseContext, which
inherit from Shared, were being explicitly deleted, which is not a
safe way to manage the lifetime of objects that inherit from Shared.
To fix this, I put those members inside RefPtrs. These two changes
allowed me to remove the destructors entirely.

Reviewed by Darin.

All regression tests pass.

  • css/cssparser.cpp:

(WebCore::ShadowParseContext::commitValue): Use .release() to avoid
ref-count churn.
(WebCore::ShadowParseContext::commitLength): Use a RefPtr for the new value to
avoid a leak.
(WebCore::CSSParser::parseShadow): Use 'false' instead of
'context.failed()', and use .release() to avoid ref-count churn.
(WebCore::BorderImageParseContext::commitWidth): Updated to use
OwnPtr.
(WebCore::CSSParser::parseBorderImage): Use 'false' instead of
'context.failed'.

10:18 PM Changeset in webkit [23924] by oliver
  • 2 edits in trunk/WebKit

Reviewed by Alexey.

Fix for <rdar://problem/5306210> Some events are still passed to WebCore despite being handled by the IM
​http://bugs.webkit.org/show_bug.cgi?id=14457

We have to assume that the IM will consume all events, so we remove the dependency
on -[WebHTMLView hasMarkedText].

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
9:13 PM Changeset in webkit [23923] by andersca
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/5297146>
Crash in Mail at WebCore::Frame::setUserStyleSheetLocation (reproducible w/ particular message)


  • loader/Cache.cpp: (WebCore::Cache::requestResource): Only insert the resource in the LRU list if the cache is enabled.


(WebCore::Cache::insertInLRUList):
(WebCore::Cache::resourceAccessed):
Assert that the resource is in the cache.

7:26 PM Changeset in webkit [23922] by darin
  • 3 edits
    4 deletes in trunk
  • css/tokenizer.flex: Rolled out the fix for 14453. The layout test wasn't passing. We'll try again.
5:51 PM Changeset in webkit [23921] by kevino
  • 8 edits in branches/wx-port-alpha/trunk

Restore the Windows build after libpng/libjpeg and Python extension changes.

5:44 PM Changeset in webkit [23920] by aroben
  • 2 edits in trunk/WebCore

Fix a crash in ~PluginViewWin()

This crash was introduced in r23827.

Reviewed by Anders.

Fixes dom/html/level2/html/HTMLAnchorElement01.html

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.

4:47 PM Changeset in webkit [23919] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Regression test for:
​http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone

  • css2.1/hex-color-regression-expected.checksum: Added.
  • css2.1/hex-color-regression-expected.png: Added.
  • css2.1/hex-color-regression-expected.txt: Added.
  • css2.1/hex-color-regression.html: Added.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone


  • css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
4:22 PM Changeset in webkit [23918] by darin
  • 2 edits in trunk/LayoutTests

Fixed a no-SVG test failure by removing a node that was affecting the test results differently
depending on whether SVG support was compiled in or not.

  • fast/xpath/namespace-vs-predicate.xhtml: Remove the r_00 node at the end of the test.
4:01 PM Changeset in webkit [23917] by aroben
  • 2 edits in trunk/WebKitTools

Fix some paths to make http tests work again on Windows

Rubberstamped by Sam.

  • Scripts/run-webkit-tests:
10:38 AM Changeset in webkit [23916] by weinig
  • 15 edits in trunk

LayoutTests:

Reviewed by Oliver.

Third round of implicit 64-32 bit conversion errors fixes.
<rdar://problem/5292262>

getFloatValue() used to return a double and now returns a float for a small
loss of precision.

  • fast/css/getFloatValueForUnit-expected.checksum:
  • fast/css/getFloatValueForUnit-expected.png:
  • fast/css/getFloatValueForUnit-expected.txt:
  • fast/css/getFloatValueForUnit.html:

WebCore:

Reviewed by Oliver.

Third round of implicit 64-32 bit conversion errors fixes.
<rdar://problem/5292262>

  • Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue() methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthInt): (WebCore::CSSPrimitiveValue::computeLengthIntForLength): (WebCore::CSSPrimitiveValue::computeLengthShort): (WebCore::CSSPrimitiveValue::computeLengthFloat): (WebCore::CSSPrimitiveValue::computeLengthDouble): (WebCore::CSSPrimitiveValue::getDoubleValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
  • css/Counter.h: (WebCore::Counter::listStyleNumber):
  • css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
  • css/cssparser.cpp: (WebCore::BorderImageParseContext::commitBorderImage):
  • css/cssstyleselector.cpp: (WebCore::convertToLength): (WebCore::applyCounterList): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundSize): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::cssPrimitiveToLength): (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
10:23 AM Changeset in webkit [23915] by darin
  • 1 edit
    2 moves in trunk/LayoutTests

Fixed a no-SVG test failure by moving a test that requires SVG into the svg directory.

  • fast/dom/svg-element-attribute-js-null-expected.txt: Removed.
  • fast/dom/svg-element-attribute-js-null.xhtml: Removed.
  • svg/dom/svg-element-attribute-js-null-expected.txt: Copied from fast/dom/svg-element-attribute-js-null-expected.txt.
  • svg/dom/svg-element-attribute-js-null.xhtml: Copied from fast/dom/svg-element-attribute-js-null.xhtml.
10:05 AM Changeset in webkit [23914] by darin
  • 1 edit
    1 add in trunk/LayoutTests

Added a missing file for the test for <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML

  • fast/loader/resources/plist.app: Added. Just some random XML file I found somewhere; seems to make the test succeed instead of failing every time!
8:52 AM Changeset in webkit [23913] by bdash
  • 3 edits
    2 deletes in trunk

Roll out r23911 as it introduced two layout test failures.

7:26 AM Changeset in webkit [23912] by bdash
  • 7 edits in trunk

2007-07-01 Pamela Greene <​pamg.bugs@gmail.com>

Reviewed by Darin.

Fix for <​http://bugs.webkit.org/show_bug.cgi?id=14320>
Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
<rdar://problem/5290084>

Use std::stable_sort() instead of qsort() to sort gradient stops.
Adjust the comparison function accordingly.

  • html/CanvasGradient.cpp: (WebCore::compareStops): (WebCore::CanvasGradient::findStop):

2007-07-01 Pamela Greene <​pamg.bugs@gmail.com>

Reviewed by Darin.

Tests for <​http://bugs.webkit.org/show_bug.cgi?id=14320>
Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
<rdar://problem/5290084>

Add tests for various combinations of stops, including multiple stops at
the same offsets, sorted and unsorted. Update results accordingly.

  • fast/canvas/fillrect_gradient-expected.checksum:
  • fast/canvas/fillrect_gradient-expected.png:
  • fast/canvas/fillrect_gradient-expected.txt:
  • fast/canvas/fillrect_gradient.html:
7:20 AM Changeset in webkit [23911] by bdash
  • 3 edits
    2 adds in trunk

2007-07-01 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14448
HTMLObjectElement::data should return an absolute URL

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): (WebCore::HTMLObjectElement::data):

2007-07-01 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=14448
HTMLObjectElement::data should return an absolute URL

  • fast/dom/object-data-absurl-expected.txt: Added.
  • fast/dom/object-data-absurl.html: Added.
7:17 AM Changeset in webkit [23910] by bdash
  • 2 edits in trunk/WebCore

2007-07-01 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Darin.

m_usesPageCache was not initialized. As the b/f cache is only
implemented in the Mac port and WebView.mm is taking care of calling
Settings::setUsesPageCache I decided to make it false by default.

  • page/Settings.cpp: (WebCore::Settings::Settings): m_usesPageCache was not initialized
7:16 AM Changeset in webkit [23909] by bdash
  • 2 edits in trunk/WebCore

2007-07-01 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Darin.

Inherited- and NonInheritedFlags is a bit field. But for comparsion
the other part of the union _iflags/_niflags is used for comparions.
This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
Make sure the unused bits have a specified value.

  • ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits have a value as well.
7:14 AM Changeset in webkit [23908] by bdash
  • 2 edits in trunk/WebKitSite

2007-07-01 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • coding/lgpl-license.html:

Jun 30, 2007:

9:53 PM Changeset in webkit [23907] by aroben
  • 2 edits in trunk/WebCore

Compile WebCore with /W4 on Windows

Some more warnings were disabled globally, including assignment within
a conditional, unused variable, and various warnings related to
inability to instantiate opaque structs.

In addition, the "unreachable code" warning was turned off for
CSSGrammar.cpp and XPathGrammar.cpp.

Reviewed by Oliver.

  • WebCore.vcproj/WebCore.vcproj:
9:53 PM Changeset in webkit [23906] by aroben
  • 17 edits
    2 adds in trunk

Give CString an equality operator to fix a bug in HTMLFormElement::formData

WebCore:

Give CString an equality operator to fix a bug in HTMLFormElement::formData

The bug was spotted by MSVC /W4. The problem was that we were comparing
a CString to a char* using ==, but CString had no equality operator.
The result was that the CString was being cast to a const char* and a
pointer comparison was being done, which would (essentially) always
return false.

There are two parts to the fix: get rid of CString's const char*
casting operator, and add an equality operator. Previous uses of the
casting operator have been changed to use CString::data().

Test: http/misc/isindex-formdata.html

Reviewed by Oliver.

  • dom/XMLTokenizer.cpp: (WebCore::parseXMLDocumentFragment):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::determineParseMode):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForCSSCharset):
  • platform/CString.cpp: (WebCore::operator==):
  • platform/CString.h:
  • platform/KURL.cpp: (WebCore::encodeRelativeString):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toDouble):
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody):
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::setHTTPBody):
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::markupToCF_HTML):
  • plugins/win/PluginPackageWin.cpp: (WebCore::splitString):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::sendJavaScriptStream): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::start): (WebCore::createUTF8String): (WebCore::PluginViewWin::userAgent):
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::locateStylesheetSubResource):
  • xml/XSLTProcessor.cpp: (WebCore::xsltParamArrayFromParameterMap):

LayoutTests:

New test that makes sure we handle putting isindex into form data correctly.

Reviewed by Oliver.

  • http/tests/misc/isindex-formdata-expected.txt: Added.
  • http/tests/misc/isindex-formdata.html: Added.
9:53 PM Changeset in webkit [23905] by aroben
  • 3 edits in trunk/WebCore

Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized

Reviewed by John.

  • editing/Editor.cpp:

(WebCore::Editor::advanceToNextMisspelling):

  • html/HTMLParser.cpp:
9:53 PM Changeset in webkit [23904] by aroben
  • 2 edits in trunk/WebCore

Fix some possibly unitialized variables found by MSVC /W4

Reviewed by John.

  • rendering/bidi.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

9:52 PM Changeset in webkit [23903] by aroben
  • 2 edits in trunk/WebCore

Remove bogus cast found by MSVC /W4

Reviewed by John and Oliver.

  • ksvg2/css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

9:52 PM Changeset in webkit [23902] by aroben
  • 3 edits in trunk/WebCore

Remove unused local functions uncovered by MSVC /W4

Reviewed by John and Oliver.

  • platform/win/SearchPopupMenuWin.cpp:
  • rendering/RenderText.cpp:
9:52 PM Changeset in webkit [23901] by aroben
  • 5 edits in trunk/WebCore

Don't take the address of temporary values to appease MSVC /W4

Reviewed by Oliver.

No regression test possible.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::invalidateItem):
(WebCore::PopupMenu::valueChanged):
(WebCore::PopupWndProc):

  • platform/win/ScrollViewWin.cpp:

(WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):

  • platform/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/win/WidgetWin.cpp:

(WebCore::Widget::invalidateRect):

9:52 PM Changeset in webkit [23900] by aroben
  • 2 edits in trunk/WebCore

Make an int -> UINT conversion explicit that MSVC /W4 complains about

Reviewed by John and Oliver.

No regression test possible.

  • platform/win/SoundWin.cpp:
9:51 PM Changeset in webkit [23899] by aroben
  • 8 edits in trunk/WebCore

Remove unreachable code uncovered by MSVC /W4

Reviewed by Oliver.

No regression test possible.

  • html/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createPattern):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isLiveLink):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::contentEditable):

  • platform/DeprecatedString.cpp:

(WebCore::allocateHandle):
(WebCore::freeHandle):

  • plugins/win/npapi.cpp:

(pluginViewForInstance):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isWidthSpecified):
(WebCore::RenderImage::isHeightSpecified):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isControlStyled):

11:08 AM Changeset in webkit [23898] by sfalken
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.make

Build fix.

9:29 AM Changeset in webkit [23897] by sullivan
  • 10 edits in trunk

WebCore:

Reviewed by Oliver Hunt.


  • WebCore support for accessing the set of rectangles that encompass the selected text


  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::selectionTextRects): new function, fills in a passed Vector with the line box rects that represent the selected range
  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
  • WebCore.exp: exported symbol for this new function

WebKit:

Reviewed by Oliver Hunt.

  • WebKit support for accessing the set of rectangles that encompass the selected text
  • WebView/WebDocumentPrivate.h: added -selectionTextRects to WebDocumentSelection protocol; tweaked comments
  • WebView/WebHTMLView.mm: (-[WebHTMLView _selectionDraggingRect]): use selectionRect instead of selectionImageRect since they're the same and maybe we can get rid of selectionImageRect someday (-[WebHTMLView selectionTextRects]): added implementation of new protocol method, which calls through to WebCore


  • WebView/WebPDFView.mm: (-[WebPDFView selectionTextRects]): added simple implementation of new protocol method, which just returns the single selection rect. PDFKit doesn't support obtaining multiple rects to describe a multi-line selection. (-[WebPDFView selectionImageForcingWhiteText:]): use selectionRect instead of selectionImageRect since they're the same and maybe we can get rid of selectionImageRect someday


  • Misc/WebSearchableTextView.m: (-[WebSearchableTextView selectionTextRects]): added no-op implementation of new protocol method to this obsolete class

Jun 29, 2007:

8:37 PM Changeset in webkit [23896] by kevino
  • 4 edits
    6 adds in branches/wx-port-alpha/trunk

Adding wxPython bindings for wxWebKit.

8:35 PM Changeset in webkit [23895] by sfalken
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.make

Build fix.

2:56 PM Changeset in webkit [23894] by justing
  • 7 edits
    1 add
    1 delete in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do


Backing out a change made in r23787.

  • editing/deleting/4845371-expected.txt:
  • editing/deleting/4845371.html:
  • editing/deleting/5126166-expected.txt:
  • editing/deleting/5290534.html: Removed.
  • editing/deleting/5290534.html-disabled: Added.

WebCore:

Reviewed by Harrison.


<rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do


Rolled out a change made in r23787.


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2:45 PM Changeset in webkit [23893] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin Adler, Anders Carlsson.


Test for <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML
returns NULL if response MIME type is not XML -- breaks Wikipedia widget

  • fast/loader/xmlhttprequest-bad-mimetype-expected.txt: Added.
  • fast/loader/xmlhttprequest-bad-mimetype.html: Added.

WebCore:

Reviewed by Darin Adler, Anders Carlsson.


Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML
returns NULL if response MIME type is not XML -- breaks Wikipedia widget


The spec says that responseXML must return null for any HTTP response
with a non-XML MIME type. Technically, that leaves non-HTTP responses
free to do whatever they want.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML MIME types if the response was HTTP.
2:36 PM Changeset in webkit [23892] by weinig
  • 12 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Second pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add a toFloat() method to JSValue for float conversion.
  • JavaScriptCore.exp:
  • kjs/value.cpp: (KJS::JSValue::toFloat):
  • kjs/value.h:

WebCore:

Reviewed by Darin.

Second pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Use new JSValue::toFloat() method instead of toNumber() where appropriate.
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow):
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove):
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::rotateFromVector):
  • bindings/js/kjs_events.cpp: (KJS::JSClipboardPrototypeFunction::callAsFunction):
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::executeScript):
2:29 PM Changeset in webkit [23891] by adele
  • 4 edits
    8 deletes in trunk

LayoutTests:

Rolling out tests for <rdar://problem/5301322>.

  • fast/forms/input-readonly-select-all-expected.checksum: Removed.
  • fast/forms/input-readonly-select-all-expected.png: Removed.
  • fast/forms/input-readonly-select-all-expected.txt: Removed.
  • fast/forms/input-readonly-select-all.html: Removed..
  • fast/forms/textarea-readonly-select-all-expected.checksum: Removed.
  • fast/forms/textarea-readonly-select-all-expected.png: Removed.
  • fast/forms/textarea-readonly-select-all-expected.txt: Removed.
  • fast/forms/textarea-readonly-select-all.html: Removed.

WebCore:

Rolling out fix for <rdar://problem/5301322> since it broke layout tests.

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.h:
1:51 PM Changeset in webkit [23890] by brmorris
  • 2 edits
    3 adds in S60/branches/3.1m/WebKit

brad, reviewed by sachin

DESC: merge of r23888 to 3.1 (generate browserversiongenerated.bat + about:version )

This is part of IAD.


  • ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
  • data/version.txt: Added.
  • group/version.mk: Added.
  • group/versiontext.bat: Added.
1:37 PM Changeset in webkit [23889] by ggaren
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver Hunt.


Layout tests for <rdar://problem/4962298> REGRESSION: Synchronous XHR for
missing local file throws exception -- breaks Wikipedia widget

  • fast/loader/xmlhttprequest-missing-file-exception-expected.txt: Added.
  • fast/loader/xmlhttprequest-missing-file-exception.html: Added.

WebCore:

Reviewed by Oliver Hunt.

Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing
local file throws exception -- breaks Wikipedia widget

  • WebCore.xcodeproj/project.pbxproj:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
1:35 PM Changeset in webkit [23888] by brmorris
  • 3 edits
    3 adds in S60/trunk/WebKit

brad, reviewed by sachin

DESC: generate browserversiongenerated.bat + about:version


  • ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
  • data/version.txt: Added.
  • group/bld.inf:
  • group/version.mk: Added.
  • group/versiontext.bat: Added.
1:28 PM Changeset in webkit [23887] by spadma
  • 2 edits in S60/trunk/WebKit

2007-06-29 Vikram Malaiya, reviewed by Sachin

DESC: YDAI-73QAL9 - Browser does not render any content from a data:URL.
​http://bugs.webkit.org/show_bug.cgi?id=14436

  • ResourceLoader/src/DataTransaction.cpp: (CDataTransaction::CreateHeaderResponseLC):
12:38 PM Changeset in webkit [23886] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

ligman, reviewed by <reviewer>

DESC: The pluginloader does not handle top level loads correctly when the plugin is in an iframe. Always load page from the MainFrame.
​http://bugs.webkit.org/show_bug.cgi?id=14447

  • Plugin/src/PluginLoader.cpp: (CPluginLoader::LoadPluginContentL):
12:29 PM Changeset in webkit [23885] by yongjzha
  • 3 edits in S60/branches/3.1m/MemoryManager

2007-06-29 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Zalan.
DESC: implement mmanp & munmap in Symbian OS.
​http://bugs.webkit.org/show_bug.cgi?id=14461

  • Group/MemMan.mmp:
  • Src/fast_malloc.cpp: (fast_set_rescue_buffer_size): (release_rescue_buffer): (alloc_rescue_buffer): (chunkMoreCore): (symbian_mmap): (symbian_munmap): (log_abort): (fast_pre_check): (fast_post_check):
12:27 PM Changeset in webkit [23884] by yongjzha
  • 7 edits in S60/trunk

hongzhao, reviewed by <​Yongjun.zhang@nokia.com>

DESC: Video continue to play after closing the page view.
​http://bugs.webkit.org/show_bug.cgi?id=14434

  • WebKit/BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • WebKit/BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):
  • WebKit/BrowserView/inc/WebKitFrame.h:
  • WebKit/BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::RemovePluginWin):
  • WebKit/Plugin/inc/PluginSkin.h:
  • WebKit/Plugin/src/PluginSkin.cpp: (CPluginSkin::RemovePluginWin):
12:22 PM Changeset in webkit [23883] by adachan
  • 2 edits in trunk/WebCore

2007-06-29 Ada Chan <​adachan@apple.com>

Reviewed by Adam.

Fixed a previous fix to a signed/unsigned mismatch.

  • plugins/win/PluginPackageWin.cpp: (WebCore::splitString):
12:22 PM Changeset in webkit [23882] by yongjzha
  • 18 edits in S60/trunk

yongjzha, reviewed by Zalan

DESC: Implement Linux-like mmap and munmap in Symbian OS

​http://bugs.webkit.org/show_bug.cgi?id=14461

  • Group/MemMan.mmp:
  • Src/fast_malloc.cpp: (free_memory): (fast_set_rescue_buffer_size): (release_rescue_buffer): (alloc_rescue_buffer): (chunkMoreCore): (symbian_mmap): (symbian_munmap): (log_abort): (fast_pre_check): (fast_post_check):
11:15 AM Changeset in webkit [23881] by adele
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by Ada and Kevin McCullough.

Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

  • fast/forms/input-readonly-select-all-expected.checksum: Added.
  • fast/forms/input-readonly-select-all-expected.png: Added.
  • fast/forms/input-readonly-select-all-expected.txt: Added.
  • fast/forms/input-readonly-select-all.html: Added.
  • fast/forms/textarea-readonly-select-all-expected.checksum: Added.
  • fast/forms/textarea-readonly-select-all-expected.png: Added.
  • fast/forms/textarea-readonly-select-all-expected.txt: Added.
  • fast/forms/textarea-readonly-select-all.html: Added.

WebCore:

Reviewed by Ada and Kevin McCullough.

Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.

Tests:
fast/forms/input-readonly-select-all.html
fast/forms/textarea-readonly-select-all.html

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::canSelectAll): (WebCore::HTMLInputElement::selectAll):
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::canSelectAll): (WebCore::HTMLTextAreaElement::selectAll):
10:58 AM Changeset in webkit [23880] by aroben
  • 2 edits in trunk/WebCore

Build fix

This is what happens when you test your patch on two OSs and then
commit from the wrong one.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::valueChanged):
(WebCore::RenderTextControl::itemText):
(WebCore::RenderTextControl::itemIsSeparator):

10:50 AM Changeset in webkit [23879] by aroben
  • 2 edits in trunk/WebCore

Start compiling WebCore with /W3 under MSVC

One warning was globally disabled: implicit conversion of int to bool.

Reviewed by Darin.

  • WebCore.vcproj/WebCore.vcproj:
10:50 AM Changeset in webkit [23878] by aroben
  • 3 edits in trunk/WebCore

Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3

DeprecatedStringData now has no public copy constructor. The single
call to the old one has been replaced with a call to the new
DeprecatedStringData::createAndAdopt static method.

Reviewed by Darin.

All regression tests pass.

  • platform/DeprecatedString.cpp:

(WebCore::DeprecatedStringData::createAndAdopt):
(WebCore::DeprecatedStringData::adopt):
(WebCore::DeprecatedString::detachIfInternal):

  • platform/DeprecatedString.h:
10:50 AM Changeset in webkit [23877] by aroben
  • 9 edits in trunk/WebCore

Fix more signed/unsigned mismatches uncovered by MSVC /W3

Reviewed by John.

No regression tests possible.

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::filenameHasSaneExtension):

  • platform/win/FontDataWin.cpp:

(WebCore::FontData::containsCharacters):

  • platform/win/PlatformScrollBarSafari.cpp:

(WebCore::):

  • platform/win/UniscribeController.cpp:

(WebCore::UniscribeController::advance):
(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/win/WebCoreTextRenderer.cpp:

(WebCore::doDrawTextAtPoint):

  • plugins/win/PluginDatabaseWin.cpp:

(WebCore::parseVersionString):

  • plugins/win/PluginPackageWin.cpp:

(WebCore::splitString):

  • plugins/win/PluginViewWin.cpp:

(WebCore::freeStringArray):
(WebCore::PluginViewWin::invalidateTimerFired):

10:50 AM Changeset in webkit [23876] by aroben
  • 8 edits in trunk/WebCore

Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3

Reviewed by John.

No regression test possible.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler):

  • platform/PopupMenuClient.h:
  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupMenu::focusFirst):
(WebCore::PopupMenu::focusLast):
(WebCore::PopupMenu::down):
(WebCore::PopupMenu::up):
(WebCore::PopupMenu::paint):

  • rendering/RenderMenuList.cpp:
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControl.h:
10:50 AM Changeset in webkit [23875] by aroben
  • 3 edits in trunk/WebCore

Fix two typos spotted by MSVC /W3

Both typos were a semicolon following the condition of an if. This
would cause the intended body of the if to always execute.

Unfortunately neither of these fixes are testable.
BackForwardList::goForward is only called from WebBackForwardList, and
the createDragImageFromImage bug would only manifest itself when
CreateCompatibleDC failed.

Reviewed by Mark.

  • history/BackForwardList.cpp:

(WebCore::BackForwardList::goForward):

  • platform/win/DragImageWin.cpp:

(WebCore::createDragImageFromImage):

7:19 AM Changeset in webkit [23874] by staikos
  • 2 edits in trunk/WebCore

Patch from Adam Treat to improve scroll wheel support for Qt.

6:28 AM Changeset in webkit [23873] by antti
  • 2 edits in branches/feature-branch/WebKitTools

Add VIDEO build flag

6:26 AM Changeset in webkit [23872] by antti
  • 2 edits
    85 adds in branches/feature-branch/LayoutTests

Basic tests for <video> and <audio>

6:25 AM Changeset in webkit [23871] by antti
  • 32 edits
    9 copies
    22 adds in branches/feature-branch/WebCore

Support for HTML5 <video> and <audio> elements

6:25 AM Changeset in webkit [23870] by antti
  • 6 edits in branches/feature-branch

Squashed commit of the following:

commit 0116a51745ee1ebe9a03ac3101f4c19f77e7459c
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:30:25 2007 +0300

delete video/

commit a31e7f20d0d6859853d414ddbeaf687f646768eb
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:21:12 2007 +0300

update ChangeLog

commit a918e88bf5b4b335d391975ff623e4b2d7981378
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:17:36 2007 +0300

move layout tests to media directory

commit 18d7cc5037909ded7f886fff4dde1d07e442120b
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:08:16 2007 +0300

add new window properties to test case

commit 59d0817997df6997a58ae807385c3cf107933025
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:06:43 2007 +0300

Implement review comments

commit 5fc7dcc6e943ae71f49ae5b9604094fa1b63036d
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 14:10:32 2007 +0300

Squashed commit of the following:

commit 3e7ca5b62c8106a3e5585e8f6a8bbb8a680f7b58
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:12:20 2007 +0300

use WebCoreSystemInterface for SPIs

random fixes

commit e32105832dbe42f1f5b7f173906fd7ee40c2cc79
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:11:34 2007 +0300

update ChangeLog

commit 621efda557bdaf8c670c60b2678ba205daab5d16
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:09:14 2007 +0300

SPIs

commit 9b2f4e7f72c3ca3e407d1cf7e3888a05e4abd418
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:21:50 2007 +0300

merge

commit 18d2a487635dae8bc61afe86e4520368074dd7f4
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:36:56 2007 +0300

Update ChangeLog

commit 919dc27a8de220ba934c4e2df88c4aa0ea621b10
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:35:59 2007 +0300

Use +/-inf for empty and deleted float hash keys

commit 109e1820d84d005c7d16bcbe15ed16ea720a7d27
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:53:11 2007 -0700

use SPI instead of private QTKit headers

commit 1987e31a5782f53b553a7c93f3c35048d85152f5
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:52:07 2007 -0700

  • add test video without audio track
  • more tolerant test cases

commit 51f34157309633502e76f157e374599313e4eb3f
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 15:25:37 2007 -0700

looser timing for test

commit 2735133a86c81cf71c67f293e7a1764ee3663f24
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 14:49:10 2007 -0700

fix int->float time conversion bug

fix cue point at 0

commit e6fd255201421644296841457c23ac023f03c262
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 13:28:56 2007 -0700

Update tests

commit 89cedff67fc5306980913b2f4cc321e8e6361ada
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:46:32 2007 -0700

update test files

commit 7d8923712a21ce09fb01806ceb333966c74565fb
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:35:59 2007 -0700

new test files

commit f1650455847033298087c2752288fb8843eda6e0
Author: Antti Koivisto <Antti Koivisto>
Date: Wed Jun 20 17:58:36 2007 -0700

fix float hash

commit 88ca8d32e2268342ad62611a4ed8c7a52dfbf65a
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:50:51 2007 -0700

don't crash with empty idl interfaces

commit cc54f83f5da73cd3ac04990cb5d310c5fa685074
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:48:42 2007 -0700

add test video

commit 478d0bc891a69d8862cdd79cadbe596bc39c1999
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 17:21:18 2007 -0700

tests

commit f647bef8037665128ed8985e6b9d12578ec8e7a6
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:53:29 2007 -0700

Some more files

commit 0fc70d1b08149d695b95ed3069a8774140308ddc
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:52:18 2007 -0700

Import video to feature branch

commit 3e7ca5b62c8106a3e5585e8f6a8bbb8a680f7b58
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:12:20 2007 +0300

use WebCoreSystemInterface for SPIs

random fixes

commit e32105832dbe42f1f5b7f173906fd7ee40c2cc79
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:11:34 2007 +0300

update ChangeLog

commit 621efda557bdaf8c670c60b2678ba205daab5d16
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:09:14 2007 +0300

SPIs

commit 9b2f4e7f72c3ca3e407d1cf7e3888a05e4abd418
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:21:50 2007 +0300

merge

commit 18d2a487635dae8bc61afe86e4520368074dd7f4
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:36:56 2007 +0300

Update ChangeLog

commit 919dc27a8de220ba934c4e2df88c4aa0ea621b10
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:35:59 2007 +0300

Use +/-inf for empty and deleted float hash keys

commit 109e1820d84d005c7d16bcbe15ed16ea720a7d27
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:53:11 2007 -0700

use SPI instead of private QTKit headers

commit 1987e31a5782f53b553a7c93f3c35048d85152f5
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:52:07 2007 -0700

  • add test video without audio track
  • more tolerant test cases

commit 51f34157309633502e76f157e374599313e4eb3f
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 15:25:37 2007 -0700

looser timing for test

commit 2735133a86c81cf71c67f293e7a1764ee3663f24
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 14:49:10 2007 -0700

fix int->float time conversion bug

fix cue point at 0

commit e6fd255201421644296841457c23ac023f03c262
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 13:28:56 2007 -0700

Update tests

commit 89cedff67fc5306980913b2f4cc321e8e6361ada
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:46:32 2007 -0700

update test files

commit 7d8923712a21ce09fb01806ceb333966c74565fb
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:35:59 2007 -0700

new test files

commit f1650455847033298087c2752288fb8843eda6e0
Author: Antti Koivisto <Antti Koivisto>
Date: Wed Jun 20 17:58:36 2007 -0700

fix float hash

commit 88ca8d32e2268342ad62611a4ed8c7a52dfbf65a
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:50:51 2007 -0700

don't crash with empty idl interfaces

commit cc54f83f5da73cd3ac04990cb5d310c5fa685074
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:48:42 2007 -0700

add test video

commit 478d0bc891a69d8862cdd79cadbe596bc39c1999
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 17:21:18 2007 -0700

tests

commit f647bef8037665128ed8985e6b9d12578ec8e7a6
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:53:29 2007 -0700

Some more files

commit 0fc70d1b08149d695b95ed3069a8774140308ddc
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:52:18 2007 -0700

Import video to feature branch

1:18 AM Changeset in webkit [23869] by antti
  • 3 edits in trunk/WebKitLibraries

Reviewed by Maciej.


Added WKQTMovieDataRate and WKQTMovieMaxTimeLoaded

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:

Jun 28, 2007:

10:49 PM Changeset in webkit [23868] by aroben
  • 7 edits in trunk/WebCore

Get WebCore compiling with /W2 on Windows

Reviewed by Steve.

No regression tests affected.

  • WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and

disable two warnings: implicit int <=> float conversion, and class vs.
struct inconsistency.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::deleteData): Cast to int before negating.

  • loader/Cache.cpp:

(WebCore::Cache::remove): Ditto.

  • platform/graphics/Path.cpp:

(WebCore::pathLengthApplierFunction): Consistently use floats.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawEllipse): Ditto.

  • platform/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.

9:16 PM Changeset in webkit [23867] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease
pool => pathologically high high water mark


I couldn't measure any performance problems with iBench HTML or PLT.

  • WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
  • platform/mac/SharedTimerMac.cpp: (WebCore::timerFired): Added autorelease pool.
7:46 PM Changeset in webkit [23866] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth.

  • fast/dynamic/recursive-layout-expected.txt: Added.
  • fast/dynamic/recursive-layout.html: Added.

WebCore:

Reviewed by Beth.

Test: fast/dynamic/recursive-layout.html

  • page/FrameView.cpp: (WebCore::FrameView::layout): Removed the midLayout guards around the calls to invalidateSelection() and updateWidgetPositions(). Those calls may dirty the layout, but in that case they also update it, so they should be allowed to do it. Added an ASSERT to make sure that when they return, the root is not marked for layout.
6:05 PM Changeset in webkit [23865] by slewis
  • 4 edits in trunk/WebKitTools

Reviewed by Adam,

Allow tests to use pre-built roots instead of building the tests.

  • Scripts/run-javascriptcore-tests: added --root option
  • Scripts/run-webkit-tests: added --root option
  • Scripts/webkitdirs.pm: added support for using a root
5:06 PM Changeset in webkit [23864] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5287569> WEBVIEW: Creating a webview in IB 3.0 (v2.0) NIB later crashes Interface Builder 2.5.4 on Tiger

Prevent encoding any of the WebView subviews. The subviews are ignored by -[WebView initWithCoder:] and will be recreated.
The Tiger 2.0 code crashed when the WebView released the subviews in initWithCoder:, so now there are no subviews to release.
This never happened before because the Tiger 2.0 code and IB wouldn't encode a WebView that has a WebHTMLView.

  • WebView/WebView.mm: (-[WebView encodeWithCoder:]):
4:02 PM Changeset in webkit [23863] by weinig
  • 3 edits
    4 deletes in trunk

LayoutTests:

Rubberstamped by Adam Roben.

Roll out r23861. It caused the buildbot to fail on intel.

  • http/tests/navigation/goBack-blank-tab-page-expected.txt: Removed.
  • http/tests/navigation/goBack-blank-tab-page.html: Removed.
  • http/tests/navigation/resources/before-go-back.html: Removed.
  • http/tests/navigation/resources/will-go-back.html: Removed.

WebCore:

Rubberstamped by Adam Roben.

Roll out r23861. It caused the buildbot to fail on intel.

  • page/Page.cpp: (WebCore::Page::goToItem):
2:57 PM Changeset in webkit [23862] by antti
  • 3 edits in branches/feature-branch/JavaScriptCore

Reviewed by Maciej.


Use intHash to hash floats and doubles too.

  • ChangeLog:
  • wtf/HashFunctions.h: (WTF::FloatHash::hash): (WTF::FloatHash::equal): (WTF::):
  • wtf/HashTraits.h: (WTF::FloatHashTraits::emptyValue): (WTF::FloatHashTraits::deletedValue): (WTF::):
2:08 PM Changeset in webkit [23861] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=13038

ASSERTION FAILED: item->target().isEmpty()
m_mainFrame->tree()->find(item->target()) == m_mainFrame

Although the test works with the script, it can't detect an eventually
error automatically since the first link must be opened in a new tab with
a _blank target to reproduce the crash. So it should be launched manually
following the steps decribed in there, then it's effective.

  • http/tests/navigation/goBack-blank-tab-page-expected.txt: Added.
  • http/tests/navigation/goBack-blank-tab-page.html: Added.
  • http/tests/navigation/resources/before-go-back.html: Added.
  • http/tests/navigation/resources/will-go-back.html: Added.

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13038

ASSERTION FAILED: item->target().isEmpty()
m_mainFrame->tree()->find(item->target()) == m_mainFrame

Modification of an ASSERT on goToItem related to go back/forward in
history.Don't need to check the frameset if the target is _blank.

  • page/Page.cpp: (WebCore::Page::goToItem):
1:16 PM Changeset in webkit [23860] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Tabs are bad

1:13 PM Changeset in webkit [23859] by andersca
  • 2 edits in trunk/LayoutTests

Remove tests that don't need to be skipped anymore.

  • win/Skipped:
1:05 PM Changeset in webkit [23858] by spadma
  • 2 edits in S60/trunk/WebKit

ligman, reviewed by <reviewer>

DESC: The pluginloader does not handle top level loads correctly when the plugin is in an iframe. Always load page from the MainFrame.
​http://bugs.webkit.org/show_bug.cgi?id=14447

  • Plugin/src/PluginLoader.cpp: (CPluginLoader::LoadPluginContentL):
12:46 PM Changeset in webkit [23857] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5234139>
<object> with PNG src rendered as image document.


Complete the URL before passing it to the frame loader client.


  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType):
11:48 AM Changeset in webkit [23856] by spadma
  • 7 edits in S60/trunk

2007-06-27 Prashanth Narayanaswamy <​prashanth.narayanaswamy@nokia.com>

Reviewed by Sachin Padma.
DESC: SKWK-745NC7 - On going download files from Browser can be seen in Music Shop

  • WebKit\ResourceLoader\inc\LoaderContainer.h: (CLoaderContainer::SetDownloadAppClientUID): new function for storing App UID in LoaderContainer (CLoaderContainer::DownloadAppClientUID): new function for retrieving App UID from LoaderContainer (CLoaderContainer::iDownloadClientAppUID): TUid instance for storing App Uid
  • WebKit\ResourceLoader\src\LoaderContainer.cpp: (CLoaderContainer::ConstructL): initialized iDownloadClientAppUID with default browser Uid - KCRUidBrowser
  • WebKit\ResourceLoader\src\HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL): while connecting to download manager server, use the application Uid which is passed by the client, instead of always using Browser's App Uid
  • WebKit\BrowserView\src\WebKitControl.cpp (CWebKitControl::SetBrowserSettingL): Store the Application Uid in LoaderContainer
9:59 AM Changeset in webkit [23855] by rwlbuis
  • 5 edits in trunk/LayoutTests

Forgot committing this change in my previous commit.

9:00 AM Changeset in webkit [23854] by rwlbuis
  • 11 edits
    4 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14373
CSS1: selectors (classes and IDs) cannot start with a dash or with a digit

Make sure the id selector validates against the CSS2.1 identfier
definition, not the hexcolor/HASH definition.

7:44 AM Changeset in webkit [23853] by hausmann
  • 3 edits in trunk/WebKitQt

Propagate mouse double click events from Qt to WebCore.

7:16 AM Changeset in webkit [23852] by hausmann
  • 4 edits in trunk/WebKitQt

Implemented clipboard functions in QWebPage, in particular can(Cut|Copy|Paste), cut/copy/paste as slot as well as a selectionChanged() signal.

7:16 AM Changeset in webkit [23851] by hausmann
  • 2 edits in trunk/WebCore

Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.

6:54 AM Changeset in webkit [23850] by antti
  • 15 edits in trunk

LayoutTests:

Reviewed by Mitz.


Test changes for ​http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/5290123>


  • expand empty-cells.html to cover non-zero cellpadding case too
  • update other related tests (none of these affect pixel results)
  • fast/css/acid2-expected.txt:
  • fast/css/acid2-pixel-expected.txt:
  • fast/table/032-expected.txt:
  • fast/table/empty-cells-expected.checksum:
  • fast/table/empty-cells-expected.png:
  • fast/table/empty-cells-expected.txt:
  • fast/table/empty-cells.html:
  • fast/table/empty-section-crash-expected.txt:
  • http/tests/misc/acid2-expected.txt:
  • http/tests/misc/acid2-pixel-expected.txt:
  • tables/mozilla/bugs/bug222467-expected.txt:
  • tables/mozilla/bugs/bug78162-expected.txt:

WebCore:

Reviewed by Mitz.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/5290123>


Cells in table with non-zero cellpadding are not considered empty.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
1:58 AM Changeset in webkit [23849] by rwlbuis
  • 4 edits
    4 adds in branches/feature-branch

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14241
SVG <image> with height or width less than 1 fails to render image

Keep extra member vars to get width/height as floats for accurate
calculations.

12:48 AM Changeset in webkit [23848] by aroben
  • 2 edits in trunk/WebCore

Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject

Reviewed by Hyatt.

No layout test possible, as this bug didn't have any effect since
"bool & bool" has the same value as "bool && bool"

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject): Changed & to &&.

12:30 AM Changeset in webkit [23847] by aroben
  • 3 edits
    2 adds in trunk

Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value

WebCore:

Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value

The bug was caused by two typos found by prefast.

Reviewed by Hyatt.

  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Fixed typos.

LayoutTests:

New test for <rdar://problem/5300443> word-break and -webkit-user-modify allow any value

Reviewed by Hyatt.

  • fast/css/word-break-user-modify-allowed-values-expected.txt: Added.
  • fast/css/word-break-user-modify-allowed-values.html: Added.

Jun 27, 2007:

11:53 PM Changeset in webkit [23846] by kmccullo
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

  • <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
  • Correctly evaluate the return value of _pcre_ucp_findchar.
  • pcre/pcre_compile.c: (compile_branch):
  • pcre/pcre_exec.c: (match):

LayoutTests:

Reviewed by Darin.

  • <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
  • Correctly evaluate the return value of _pcre_ucp_findchar.
  • fast/js/regexp-unicode-overflow-expected.txt: Added.
  • fast/js/regexp-unicode-overflow.html: Added.
  • fast/js/resources/regexp-unicode-overflow.js: Added.
11:18 PM Changeset in webkit [23845] by bdash
  • 2 edits in trunk/WebCore

2007-06-20 Matt Perry <​mpComplete@gmail.com>

Reviewed by Adam.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of a call to saveLastSelection in the "Enter" key handler for select controls that was preventing onchange from firing.
11:01 PM Changeset in webkit [23844] by weinig
  • 1 edit in trunk/WebCore/page/DOMSelection.cpp

Yet another build fix :(

10:32 PM Changeset in webkit [23843] by weinig
  • 3 edits in trunk/WebCore

Fix Gdk, Qt, and Win32 builds.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
10:25 PM Changeset in webkit [23842] by weinig
  • 12 edits
    3 adds in trunk

LayoutTests:

Reviewed by Geoff.

Update tests for ​http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/toString-and-valueOf-override-expected.txt:
  • http/tests/security/cross-frame-access-expected.txt:

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings

  • Renames JS Object Selection to DOMSelection to avoid a name conflict.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::clearHelperObjectProperties): (KJS::WindowFunc::callAsFunction): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/DOMSelection.cpp: Added. (WebCore::DOMSelection::DOMSelection): (WebCore::DOMSelection::frame): (WebCore::DOMSelection::disconnectFrame): (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::extentOffset): (WebCore::DOMSelection::isCollapsed): (WebCore::DOMSelection::type): (WebCore::DOMSelection::rangeCount): (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::collapseToEnd): (WebCore::DOMSelection::collapseToStart): (WebCore::DOMSelection::empty): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::removeAllRanges): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::toString):
  • page/DOMSelection.h: Added.
  • page/DOMSelection.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::getSelection):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
8:34 PM Changeset in webkit [23841] by weinig
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

2nd patch for ​http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding

  • Cleanup kjs_events
  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::JSAbstractEventListener): (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSAbstractEventListener::isHTMLEventListener): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::listenerObj): (WebCore::JSUnprotectedEventListener::windowObj): (WebCore::JSUnprotectedEventListener::clearWindowObj): (WebCore::JSUnprotectedEventListener::mark): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::listenerObj): (WebCore::JSEventListener::windowObj): (WebCore::JSEventListener::clearWindowObj): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::listenerObj): (WebCore::JSLazyEventListener::parseCode): (WebCore::getNodeEventListener): (WebCore::JSClipboard::JSClipboard): (WebCore::JSClipboard::getValueProperty): (WebCore::JSClipboard::putValueProperty): (WebCore::JSClipboardPrototypeFunction::callAsFunction): (WebCore::toJS): (WebCore::toClipboard):
  • bindings/js/kjs_events.h: (WebCore::JSClipboard::classInfo): (WebCore::JSClipboard::impl):
  • bindings/js/kjs_window.h:
  • ksvg2/events/JSSVGLazyEventListener.h:
8:19 PM Changeset in webkit [23840] by weinig
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by Adam Roben.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/5286670>

  • fast/forms/thumbslider-crash-expected.checksum: Added.
  • fast/forms/thumbslider-crash-expected.png: Added.
  • fast/forms/thumbslider-crash-expected.txt: Added.
  • fast/forms/thumbslider-crash.html: Added.
  • fast/forms/thumbslider-no-parent-slider-expected.checksum: Added.
  • fast/forms/thumbslider-no-parent-slider-expected.png: Added.
  • fast/forms/thumbslider-no-parent-slider-expected.txt: Added.
  • fast/forms/thumbslider-no-parent-slider.html: Added.

WebCore:

Reviewed by Adam Roben.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/5286670>

Test: fast/forms/thumbslider-no-parent-slider.html
Test: fast/forms/thumbslider-crash.html

  • rendering/RenderObject.h: (WebCore::RenderObject::isSlider):
  • rendering/RenderSlider.h: (WebCore::RenderSlider::isSlider):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Only paint thumbslider if the parent renderer is a RenderSlider.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):
6:50 PM Changeset in webkit [23839] by staikos
  • 1 edit in trunk/WebKitQt/QtLauncher/main.cpp

Missed this file as part of #23832

6:36 PM Changeset in webkit [23838] by staikos
  • 2 edits in trunk/WebCore

Make Qt builds link when XSLT is disabled

5:23 PM Changeset in webkit [23837] by sfalken
  • 2 edits in trunk/WebCore

Turn on static code analysis (Windows only).

Affects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.


Reviewed by Oliver.

  • WebCore.vcproj/WebCore.vcproj:
5:04 PM Changeset in webkit [23836] by staikos
  • 2 edits in trunk/WebCore

Remove files that no longer exist (were commented out)

4:14 PM Changeset in webkit [23835] by staikos
  • 5 edits in trunk/WebCore

revert IDL change until the code generator is fixed

4:08 PM Changeset in webkit [23834] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/5247341> REGRESSION: Pasting sometimes loses trailing newline


Demonstrates the bug:

  • editing/pasteboard/5247341-expected.checksum: Added.
  • editing/pasteboard/5247341-expected.png: Added.
  • editing/pasteboard/5247341-expected.txt: Added.
  • editing/pasteboard/5247341.html: Added.


The changes in this patch exposed three bugs (5296964, 5296977, and 5299425).
Added FIXMES for them. Also removed tabs in them:

  • editing/pasteboard/paste-table-003-expected.checksum:
  • editing/pasteboard/paste-table-003-expected.png:
  • editing/pasteboard/paste-table-003-expected.txt:
  • editing/pasteboard/paste-table-003.html:
  • fast/forms/textarea-paste-newline.html:


Equivalent trees:

  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:

WebCore:

Reviewed by John.

<rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline


Pasting with a trailing interchange newline doesn't work when pasting
into an empty line. Code that handles removing brs at the insertion
position tries to also handle trailing interchange newlines by re-using
those brs and fails. Removed that code and handle all interchange
newlines with code later in doApply().

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the endBR when there's a trailing interchange newline.
3:21 PM Changeset in webkit [23833] by staikos
  • 5 edits in trunk/WebCore

Use the proper macros so that it builds with !SVG and !XPATH

3:06 PM Changeset in webkit [23832] by staikos
  • 6 edits in trunk/WebKitQt

Fix compilation with various Qt configurations

3:05 PM Changeset in webkit [23831] by sfalken
  • 1 edit in trunk/WebKit/win/ChangeLog

Fix ChangeLog.

3:01 PM Changeset in webkit [23830] by sfalken
  • 3 edits
    1 add in trunk/WebKit/win

Turn on static code analysis.

Reviewed by Oliver.


Effects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.

  • CodeAnalysisConfig.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebLocalizableStrings.cpp: (createWebKitBundle):
2:55 PM Changeset in webkit [23829] by sfalken
  • 3 edits in trunk/WebKit/win

Prefast: Remove variable redefinitions in inner scopes.


Reviewed by Ada.

  • WebDownload.cpp: (WebDownload::didFinish):
  • WebNotificationCenter.cpp: (WebNotificationCenter::postNotificationInternal): (WebNotificationCenter::removeObserver):
2:28 PM Changeset in webkit [23828] by sfalken
  • 2 edits in trunk/WebKit/win

Remove SEH block from around history plist read, since the underlying bug has been fixed.


Reviewed by Darin.

  • WebHistory.cpp: (createHistoryListFromStream):
2:27 PM Changeset in webkit [23827] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5253950>
When Shockwave plugin has been loaded, exiting crashes Safari


Add a "load count" for plugin packages. When the load count is zero, unload the plugin.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): (WebCore::PluginPackageWin::load): (WebCore::PluginPackageWin::unload): (WebCore::PluginPackageWin::unloadWithoutShutdown):
  • plugins/win/PluginPackageWin.h:


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::~PluginViewWin): Make sure to unload the plugin package and clear any references to plugin script objects.
1:45 PM Changeset in webkit [23826] by staikos
  • 2 edits in trunk/WebCore

We were compiling purely out of luck, but if qmake sets up the build order
slightly differently it fails. This forces a dependency to generate HTMLNames.h
in time.

1:13 PM Changeset in webkit [23825] by staikos
  • 2 edits in trunk/WebKitQt

Patch from Eli Fidler to compile when QT_NO_IMAGE_TEXT is defined.

1:06 PM Changeset in webkit [23824] by staikos
  • 2 edits in trunk/WebKitQt

Patch from Eli Fidler to remove QT3_SUPPORT dependency in ICO handler.

1:04 PM Changeset in webkit [23823] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list

Splits a quoted list w/o splitting a list item:

  • editing/execCommand/4580583-1-expected.checksum: Added.
  • editing/execCommand/4580583-1-expected.png: Added.
  • editing/execCommand/4580583-1-expected.txt: Added.
  • editing/execCommand/4580583-1.html: Added.


Split a quoted list item:

  • editing/execCommand/4580583-2-expected.checksum: Added.
  • editing/execCommand/4580583-2-expected.png: Added.
  • editing/execCommand/4580583-2-expected.txt: Added.
  • editing/execCommand/4580583-2.html: Added.

WebCore:

Reviewed by John.

<rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list


When a quoted numbered list is broken in half, it's cloned
to make the second list. That second list needs its start attribute
set so that the numbers of the list items in it will be preserved.

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute of a cloned list to be the original number of the first list item in it.
10:28 AM Changeset in webkit [23822] by sfalken
  • 2 edits in trunk/WebKit/win

Prefast: Fix misplaced parenthesis.


Reviewed by Darin.

  • WebView.cpp: (core):
10:21 AM Changeset in webkit [23821] by ap
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=14413
GIF animation throttling is different from MSIE

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameDurationAtIndex): Change the cut-off value to 50ms to match MSIE.
10:15 AM Changeset in webkit [23820] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin


  • WebKit support for displaying multiple text matches in PDF views (<rdar://problem/4601967>)
  • WebView/WebPDFView.h: new ivars textMatches and lastScrollPosition; now conforms to WebMultipleTextMatches protocol


  • WebView/WebPDFView.mm: (-[WebPDFView dealloc]): release textMatches (-[WebPDFView viewDidMoveToWindow]): start observing bounds changes in the PDF document's enclosing clip view, so we can notice when scrolling takes place (-[WebPDFView viewWillMoveToWindow:]): stop observing bounds changes in the PDF document's enclosing clip view (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]): most of the code here has been moved into the new method _nextMatchFor::::, which this now calls (-[WebPDFView setMarkedTextMatchesAreHighlighted:]): implementation of WebMultipleTextMatches protocol method, does nothing useful here because we don't support inline highlighting of matches in PDF documents (-[WebPDFView markedTextMatchesAreHighlighted]): implementation of WebMultipleTextMatches protocol method (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]): implementation of WebMultipleTextMatches protocol method; calls _nextMatchFor:::: in a loop until entire document is searched or limit is hit; records results by saving PDFSelections in textMatches ivar (-[WebPDFView unmarkAllTextMatches]): implementation of WebMultipleTextMatches protocol method; clears saved textMatches (-[WebPDFView rectsForTextMatches]): implementation of WebMultipleTextMatches protocol method; converts saved PDFSelections into NSValue objects that represent NSRects (-[WebPDFView _clipViewForPDFDocumentView]): new helper method to find the clip view whose bounds determine the current scroll position (-[WebPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]): new helper method, extracted from searchFor::::: (-[WebPDFView _PDFDocumentViewMightHaveScrolled:]): new notification callback; tells webView's delegate when document has scrolled (-[WebPDFView _setTextMatches:]): new helper method, stores value in ivar
10:13 AM Changeset in webkit [23819] by sfalken
  • 2 edits in trunk/WebKit/win

Prefast: Add null check prior to writing into allocated BSTR.


Reviewed by Darin.

  • MarshallingHelpers.cpp: (MarshallingHelpers::CFStringRefToBSTR):
9:53 AM Changeset in webkit [23818] by sfalken
  • 2 edits in trunk/WebKit/win

Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.

Reviewed by Sam, Darin.


Allocation failure will result in a null dereference in this case,
so it isn't exploitable.

  • DefaultDownloadDelegate.cpp: (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
9:47 AM Changeset in webkit [23817] by ap
  • 1 add in trunk/LayoutTests/fast/dom/resources/1251.html

Forgot to commit this file with r23815.

9:43 AM Changeset in webkit [23816] by weinig
  • 29 edits in trunk

JavaScriptCore:

Reviewed by Darin.

First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add 'f' suffix where necessary.
  • kjs/testkjs.cpp: (StopWatch::getElapsedMS):

WebCore:

Reviewed by Darin.

First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add 'f' suffix where necessary.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
  • css/csshelper.h:
  • css/cssstyleselector.cpp: (WebCore::): (WebCore::CSSStyleSelector::largerFontSize): (WebCore::CSSStyleSelector::smallerFontSize):
  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::createPattern):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/events/SVGZoomEvent.cpp: (WebCore::SVGZoomEvent::SVGZoomEvent):
  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::value): (WebCore::SVGLength::setValue): (WebCore::SVGLength::valueAsPercentage): (WebCore::SVGLength::PercentageOfViewport):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::pixelUnitToMillimeterX): (WebCore::SVGSVGElement::pixelUnitToMillimeterY): (WebCore::SVGSVGElement::getScreenCTM):
  • ksvg2/svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::getComputedTextLength): (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::getRotationOfChar):
  • ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::distance):
  • page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource):
  • platform/graphics/FloatPoint3D.cpp: (WebCore::FloatPoint3D::normalize):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::createRoundedRectangle):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::FrameData::clear):
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameDurationAtIndex):
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::setCurrentPage):
  • platform/graphics/svg/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::externalRepresentation):
  • platform/graphics/svg/SVGPaintServerRadialGradient.cpp: (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::cgGradientCallback): (WebCore::CGShadingRefForRadialGradient): (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
  • platform/mac/FontDataMac.mm: (WebCore::webFallbackFontFamily):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setValueForPosition): (WebCore::RenderSlider::setPositionFromValue):
9:36 AM Changeset in webkit [23815] by ap
  • 5 edits
    2 adds in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=14288
XMLHttpRequest doesn't use a correct content type for ​file:// URLs

Test: fast/dom/xmlhttprequest-html-response-encoding.html

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by the network layer, since it provides it even for non-HTTP responses.
8:00 AM Changeset in webkit [23814] by zbujtas
  • 5 edits in S60/trunk/WebKit

rathnasa, reviewed by <​zbujtas@gmail.com>

DESC: Widget Menu API needs refinement
​http://bugs.webkit.org/show_bug.cgi?id=14389

6:27 AM BuildingQtOnLinux edited by treat@kde.org
(diff)
6:27 AM BuildingQtOnLinux edited by treat@kde.org
add heading (diff)
6:21 AM BuildingQtOnLinux edited by treat@kde.org
Don't focus on one or two distros and update minimum version of Qt. (diff)
1:19 AM Changeset in webkit [23813] by oliver
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

Hopefully fix remainder of the IME issues on Mac.
We now assume that the IME silently consumes any event given
to it during text composition, and only override this assumption
if the NSTextInput or NSResponder callbacks are made.

This prevents us from treating those events that the IME has
consumed internally (eg. candidate window navigation) as unhandled
events that should be bubbled.

This fixes:

<rdar://problem/5107538> Major problems handling key press event with non-english Input Methods
<rdar://problem/4196249> REGRESSION: Mail: Inputting space (U+0020) with IM deletes subsequent line breaks on Mail.app
<rdar://problem/5015544> REGRESSION: Reverse conversion keyboard command does not work in Safari.
<rdar://problem/5045121> REGRESSION: Inline is confirmed after press left/right arrow keys, happens in Mail but not in TextEdit.
<rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
<rdar://problem/5085781> REGRESSION: Active input area lost "selected" highlight
<rdar://problem/5094200> space key pressed to close the associated words candidate window gets inserted as text
<rdar://problem/5228294> Candidate item for character matrix is sometimes skipped

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView launchKeyEvent:]): (-[WebHTMLView keyDown:]): (-[WebHTMLView keyUp:]): (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView unmarkText]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):

Jun 26, 2007:

10:45 PM Changeset in webkit [23812] by bdash
  • 2 edits in trunk/WebCore

2007-06-26 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=14061
Implement more of FrameLoaderClientGdk

Make FrameLoaderClientGdk work properly when the MIME type is set.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::canShowMIMEType):
10:44 PM Changeset in webkit [23811] by bdash
  • 6 edits in trunk/WebCore

2007-06-26 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14058
Gdk font backend cleanup

  • platform/FontData.h: Remove obsolete function.
  • platform/gdk/FontDataGdk.cpp: (WebCore::FontData::containsCharacters): Lock/unlock only once. (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
  • platform/gdk/FontPlatformData.h: Remove obsolete function.
  • platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): Pass the actual size, not the pixel size. (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
  • platform/gdk/GlyphPageTreeNodeGdk.cpp: (WebCore::GlyphPage::fill): Lock/unlock only once.
10:33 PM Changeset in webkit [23810] by bdash
  • 5 edits
    2 moves
    6 adds
    6 deletes in trunk

2007-06-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Covered by existing tests.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::collapsedBottomBorder):

2007-06-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

  • tables/mozilla/core/table_rules-expected.checksum: Added.
  • tables/mozilla/core/table_rules-expected.png: Added.
  • tables/mozilla/core/table_rules-expected.txt: Added.
  • tables/mozilla/core/table_rules.html: Copied from LayoutTests/tables/mozilla_expected_failures/core/table_rules.html.
  • tables/mozilla/marvin/x_table_rules_groups-expected.checksum: Added.
  • tables/mozilla/marvin/x_table_rules_groups-expected.png: Added.
  • tables/mozilla/marvin/x_table_rules_groups-expected.txt: Added.
  • tables/mozilla/marvin/x_table_rules_groups.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml.
  • tables/mozilla_expected_failures/core/table_rules-expected.checksum: Removed.
  • tables/mozilla_expected_failures/core/table_rules-expected.png: Removed.
  • tables/mozilla_expected_failures/core/table_rules-expected.txt: Removed.
  • tables/mozilla_expected_failures/core/table_rules.html: Removed.
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml: Removed.
9:46 PM Changeset in webkit [23809] by bdash
  • 4 edits
    5 adds in trunk

2007-06-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Oliver.

Test: fast/repaint/text-selection-rect-in-overflow-2.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account for overflow scroll and columns.
  • rendering/RenderText.cpp: (WebCore::RenderText::selectionRect): Adjust for columns only in the non-clipped case, since RenderObject::absolutePosition() does not.

2007-06-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Oliver.

  • fast/repaint/resources/text-selection-rect-in-overflow-frame.html: Added.
  • fast/repaint/text-selection-rect-in-overflow-2-expected.checksum: Added.
  • fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
  • fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
  • fast/repaint/text-selection-rect-in-overflow-2.html: Added.
9:43 PM Changeset in webkit [23808] by bdash
  • 2 edits in trunk/WebCore

2007-06-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam.

  • rendering/RenderObject.h:
9:07 PM Changeset in webkit [23807] by aroben
  • 1 edit in trunk/WebCore/config.h

Touching config.h to force WebCore to rebuild after r23806

8:16 PM Changeset in webkit [23806] by bdash
  • 5 edits
    6 adds
    2 deletes in trunk/WebCore

2007-06-26 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Maciej.

Implement ​http://bugs.webkit.org/show_bug.cgi?id=14225
Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs

This change moves the bulk of ResourceRequest into a base class named
ResourceRequestBase with all platform-specific bits pushed into
ResourceRequest. This allows ports to easily add new members to a
ResourceRequest without having to #ifdef the code that is shared
between ports.

  • WebCore.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/ResourceRequest.cpp: Removed.
  • platform/network/ResourceRequest.h: Removed.
  • platform/network/ResourceRequestBase.cpp: Added. (WebCore::ResourceRequestBase::asResourceRequest): (WebCore::ResourceRequestBase::isEmpty): (WebCore::ResourceRequestBase::isNull): (WebCore::ResourceRequestBase::url): (WebCore::ResourceRequestBase::setURL): (WebCore::ResourceRequestBase::cachePolicy): (WebCore::ResourceRequestBase::setCachePolicy): (WebCore::ResourceRequestBase::timeoutInterval): (WebCore::ResourceRequestBase::setTimeoutInterval): (WebCore::ResourceRequestBase::mainDocumentURL): (WebCore::ResourceRequestBase::setMainDocumentURL): (WebCore::ResourceRequestBase::httpMethod): (WebCore::ResourceRequestBase::setHTTPMethod): (WebCore::ResourceRequestBase::httpHeaderFields): (WebCore::ResourceRequestBase::httpHeaderField): (WebCore::ResourceRequestBase::setHTTPHeaderField): (WebCore::ResourceRequestBase::httpBody): (WebCore::ResourceRequestBase::setHTTPBody): (WebCore::ResourceRequestBase::allowHTTPCookies): (WebCore::ResourceRequestBase::setAllowHTTPCookies): (WebCore::ResourceRequestBase::addHTTPHeaderField): (WebCore::ResourceRequestBase::addHTTPHeaderFields): (WebCore::operator==): (WebCore::ResourceRequestBase::isConditional): (WebCore::ResourceRequestBase::updatePlatformRequest): (WebCore::ResourceRequestBase::updateResourceRequest):
  • platform/network/ResourceRequestBase.h: Added. (WebCore::): (WebCore::ResourceRequestBase::httpContentType): (WebCore::ResourceRequestBase::setHTTPContentType): (WebCore::ResourceRequestBase::httpReferrer): (WebCore::ResourceRequestBase::setHTTPReferrer): (WebCore::ResourceRequestBase::clearHTTPReferrer): (WebCore::ResourceRequestBase::httpUserAgent): (WebCore::ResourceRequestBase::setHTTPUserAgent): (WebCore::ResourceRequestBase::httpAccept): (WebCore::ResourceRequestBase::setHTTPAccept): (WebCore::ResourceRequestBase::ResourceRequestBase): (WebCore::operator!=):
  • platform/network/cf/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest):
  • platform/network/curl/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
  • platform/network/mac/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest):
  • platform/network/qt/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
8:13 PM Changeset in webkit [23805] by bdash
  • 2 edits in trunk/WebKit

2007-06-26 Jim Correia <​jim.correia@pobox.com>

Reviewed by Darin.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14411
Bug 14411: WebNetscapePluginPackage overagressively sets CurApRefNum, which affects shipping versions of BBEdit.
<rdar://problem/5297268>

  • Plugins/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage initialize]): Force the Resource Manager to lazy initialize, and only set CurApRefNum to the system file if CurApRefNum is still -1 after that forced lazy initialization.
7:13 PM Changeset in webkit [23804] by aroben
  • 1 edit in trunk/WebCore/ChangeLog

Add ChangeLog entries from the Windows merge.

Reviewed by Maciej.

  • ChangeLog:
6:44 PM Changeset in webkit [23803] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Make sure not to enumerate the toString() function.
<rdar://problem/5297118>

  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/toString-dontEnum-expected.txt: Added.
  • fast/js/toString-dontEnum.html: Added.

WebCore:

Reviewed by Maciej.

Make sure not to enumerate the toString() function.
<rdar://problem/5297118>

  • bindings/js/kjs_window.cpp:
  • bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
  • html/HTMLAnchorElement.idl:
4:26 PM Changeset in webkit [23802] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/5296627> JSGarbageCollect headerdoc suggests that
using JavaScriptCore requires leaking memory

  • API/JSBase.h: Changed documentation to explain that you can pass NULL to JSGarbageCollect.
4:07 PM Changeset in webkit [23801] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Mitz, landed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=14421
Implement GraphicsContext::clearRect()

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clearRect):
4:05 PM Changeset in webkit [23800] by andersca
  • 2 edits in trunk/WebCore

Reviewed and landed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=14416
Content does not render fully in some cases

Fix mismatched calls to cairo_save/restore due to an early method return.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLine):
2:31 PM Changeset in webkit [23799] by tristan
  • 3 edits in trunk/WebCore

Reviewed by John Sullivan.

Added two accessor functions for <rdar://problem/4119138>

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]): Added an accessor to the isEdited value of a DOM node's render object
  • bindings/objc/DOMPrivate.h: Added header definitions for _isEdited
1:17 PM Changeset in webkit [23798] by spadma
  • 2 edits in S60/trunk/WebCore

spadma, reviewed by zalan

DESC: Fix build bustage

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):
1:07 PM Changeset in webkit [23797] by weinig
  • 2 edits in trunk/WebCore

Fix Win32 build.

  • WebCore.vcproj/WebCore.vcproj:
1:05 PM Changeset in webkit [23796] by weinig
  • 2 edits in trunk/WebCore

Fix Qt and Gdk builds.

  • WebCore.pro:
12:55 PM Changeset in webkit [23795] by weinig
  • 15 edits
    1 add in trunk

LayoutTests:

Reviewed by Geoff.

Update tests for ​http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding

  • fast/dom/prototype-chain-expected.txt: DOMEventPrototype is no longer in the prototype chain.
  • fast/dom/xmlhttprequest-get-expected.txt:

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding

  • Moves the dataTransfer method into MouseEvent where it should be.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: Added. (WebCore::JSEvent::clipboardData): (WebCore::toJS):
  • bindings/js/JSEventTargetNode.cpp:
  • bindings/js/JSXMLHttpRequest.cpp:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_events.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Event.h: (WebCore::Event::returnValue): (WebCore::Event::setReturnValue): (WebCore::Event::clipboardData):
  • dom/Event.idl:
  • dom/MouseEvent.h: (WebCore::MouseEvent::dataTransfer):
  • dom/MouseEvent.idl:
7:47 AM Changeset in webkit [23794] by spadma
  • 6 edits in S60/trunk/WebKit

winship, reviewed by <reviewer>

DESC: SYAI-73ARXK - Widget UI must not have scrollbars, always ON status pane & fullscreen mode
​http://bugs.webkit.org/show_bug.cgi?id=14384

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/inc/BrCtlInterface.h:
  • BrowserView/inc/WidgetExtension.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::ForegroundEvent):
  • BrowserView/src/WidgetExtension.cpp: (CWidgetExtension::SetRightSoftKeyLabel): (CWidgetExtension::HideSoftkeys): (CWidgetExtension::ShowSoftkeys): (CWidgetExtension::SetDisplayLandscape): (CWidgetExtension::SetDisplayPortrait):
7:44 AM Changeset in webkit [23793] by spadma
  • 3 edits in S60/trunk/WebKit

2007-06-25 Vikram Malaiya, reviewed by Sachin

DESC: YDAI-73QAL9 - Cursor is invisible on second created browser control.
​http://bugs.webkit.org/show_bug.cgi?id=14285

  • BrowserView/inc/WebKitCursor.h:
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CWebKitCursor): (CWebKitCursor::ConstructL): (CWebKitCursor::SetCurrentView): (CWebKitCursor::ConstructSprite): (CWebKitCursor::CursorUpdate):
7:41 AM Changeset in webkit [23792] by spadma
  • 2 edits in S60/trunk/WebCore

spadma, reviewed by zalan

DESC: [S60] Pointer event in a blank browser window causes crash
​http://bugs.webkit.org/show_bug.cgi?id=14387
TSW ID : YDAI-73V998

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):
7:40 AM Changeset in webkit [23791] by staikos
  • 1 add in trunk/WebCore/loader/icon/IconDatabaseNone.cpp

Missed checking in this file when checking in icon database patch from Adam Treat. Unused on all platforms presently.

5:51 AM Web Inspector edited by timothy@apple.com
(diff)
5:28 AM Changeset in webkit [23790] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
​http://bugs.webkit.org/show_bug.cgi?id=14385

Correctly remember the "Show implicit properties" setting as you switch nodes.

  • page/inspector/ResourcePanel.js:
1:55 AM Changeset in webkit [23789] by rwlbuis
  • 4 edits
    1 move
    3 adds
    3 deletes in branches/feature-branch

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=9976
Fix negative width issue in Hixie's test

Refuse to render zero or negative width/height.

12:47 AM Changeset in webkit [23788] by rwlbuis
  • 14 edits
    8 adds in branches/feature-branch

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12062
WebCore does not handle CSS-specified fill fallback correctly

Implement fallback for fill and stroke.

Jun 25, 2007:

11:52 PM Changeset in webkit [23787] by justing
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/5290534> Crash RenderTextControl::calcHeight() after deleting text in a search field

Demonstrates the bug:

  • editing/deleting/5290534-expected.txt: Added.
  • editing/deleting/5290534.html: Added.

Fixed a bug (an extra br was inserted) and removed a FIXME:

  • editing/deleting/4845371-expected.checksum:
  • editing/deleting/4845371-expected.png:
  • editing/deleting/4845371-expected.txt:
  • editing/deleting/4845371.html:


Removed an unrendered br that was being incorrectly inserted:

  • editing/deleting/5126166-expected.txt:

WebCore:

Reviewed by John.

<rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field


Editing removed a node that was part of a search field's internal
structure that should not be removed.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the selection to delete ends at [container, x], where x is the number of children in container, don't remove container. Special case code elsewhere in this function will remove it if necessary.
11:34 PM Changeset in webkit [23786] by weinig
  • 4 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype

  • fast/js/constructor-expected.txt: Added.
  • fast/js/constructor.html: Added.
  • fast/js/resources/constructor.js: Added.

WebCore:

Reviewed by Maciej.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype

Test: fast/js/constructor.html

  • bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to classes with constructors. It is an non-enumeratable, non-deletable, readonly attribute.
10:23 PM Changeset in webkit [23785] by staikos
  • 2 edits in trunk/WebCore

Repair the OS X build.

10:12 PM Changeset in webkit [23784] by aroben
  • 1 edit
    1 delete in trunk

Really remove LayoutTestResults.

  • LayoutTestResults: Removed.
10:00 PM Changeset in webkit [23783] by aroben
  • 3 edits
    297 copies
    2455 moves
    105 adds
    297 deletes in trunk

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt

Top Level:

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
​http://bugs.webkit.org/show_bug.cgi?id=14405

Reviewed by Anders.

  • LayoutTestResults: Removed.

WebKitTools:

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
​http://bugs.webkit.org/show_bug.cgi?id=14405

Reviewed by Anders.

  • Scripts/run-webkit-tests:
9:56 PM Changeset in webkit [23782] by staikos
  • 5 edits in trunk

Patch from Adam Treat to make the SQLite icon database optional.

9:38 PM Changeset in webkit [23781] by aroben
  • 2 edits in trunk/WebKitTools

Enable running the regression tests on Windows.

These changes were developed alongside the Windows WebKit port and
have been well tested.

Rubberstamped by Sam.

  • Scripts/run-webkit-tests:
9:18 PM Changeset in webkit [23780] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14369
HTML syntax highlighting colors and DOM tree colors should be the same

  • css/view-source.css:
  • page/inspector/ResourcePanel.js:
  • page/inspector/inspector.css:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
8:18 PM Changeset in webkit [23779] by aroben
  • 2 edits in trunk/WebCore

Fix Bug 14402: Main resource of ​http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"

The solution was to make KURL::lastPathComponent ignore trailing
slashes, which is what -[NSURL lastPathComponent] does, too.

Reviewed by Oliver.

  • platform/KURL.cpp:

(WebCore::KURL::lastPathComponent):

8:09 PM Changeset in webkit [23778] by aroben
  • 2 edits in trunk/WebKitTools

Fix Bug 14403: prepare-ChangeLog --git-commit doesn't support --diff
​http://bugs.webkit.org/show_bug.cgi?id=14403

Reviewed by Mark Rowe.

  • Scripts/prepare-ChangeLog: Don't spew to stdout, use stderr instead.

(sub createPatchCommand): Generate a correct diff in the $gitCommit
case.

5:56 PM Changeset in webkit [23777] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5294036> -[WebView customTextEncodingName] API may return empty string instead of nil

  • WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]): Addded the nsStringNilIfEmpty() inline to the data being returned because our API says "The custom text encoding name or nil if no custom text encoding name has been set." I also verified the standing Tiger WebKit behavior for this method and it does indeed return nil if a custom encoding wasn't set.
5:51 PM Changeset in webkit [23776] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14257
Web Inspector lists favicon.ico as "other" instead of "image"

  • page/InspectorController.cpp: (WebCore::InspectorResource::type):
5:43 PM Changeset in webkit [23775] by aroben
  • 2 edits
    13 adds in trunk/WebKitTools

Land pdevenv and supporting scripts/programs

pdevenv is a script that will open an instance of Visual Studio that
can compile multiple files in parallel, similar to make -jN. It uses
the following scripts/programs to accomplish this:

CLWrapper: Compiles to vcbin/cl.exe. Calls Scripts/parallelcl.

parallelcl: Actually performs the parallel compilation by forking
multiple instances of the Microsoft-supplied cl.exe.

MIDLWrapper: Compiles to vcbin/midl.exe. Calls through to the
Microsoft-supplied midl.exe. This avoids having to invoke perl for
every invocation of midl.exe, which would be quite slow.

Rubberstamped by Sam.

  • CLWrapper/CLWrapper.cpp: Added.

(wmain):

  • CLWrapper/CLWrapper.sln: Added.
  • CLWrapper/CLWrapper.vcproj: Added.
  • MIDLWrapper/MIDLWrapper.cpp: Added.

(wmain):

  • MIDLWrapper/MIDLWrapper.sln: Added.
  • MIDLWrapper/MIDLWrapper.vcproj: Added.
  • Scripts/parallelcl: Added.
  • Scripts/pdevenv: Added.
  • vcbin/cl.exe: Added.
  • vcbin/midl.exe: Added.
5:30 PM Changeset in webkit [23774] by sullivan
  • 6 edits in trunk/WebKit

Reviewed by Darin


  • WebKit part of <rdar://problem/5293820>, needed to support multiple matches in PDFs
  • WebView/WebDocumentInternal.h: Added WebMultipleTextMatches protocol, containing five methods that were formerly implemented in WebHTMLView
  • WebView/WebHTMLViewPrivate.h: Removed declarations for the methods that are now in WebMultipleTextMatches protocol


  • WebView/WebHTMLView.mm: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): moved this method into the WebDocumentInternalProtocols portion of the file (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): ditto (-[WebHTMLView markedTextMatchesAreHighlighted]): ditto (-[WebHTMLView unmarkAllTextMatches]): ditto (-[WebHTMLView rectsForTextMatches]): ditto
  • WebView/WebView.mm: (-[WebView canMarkAllTextMatches]): new method, returns YES only if the documentView of every frame implements WebMultipleTextMatches (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): check for WebMultipleTextMatches protocol instead of checking for WebHTMLView class (-[WebView unmarkAllTextMatches]): ditto (-[WebView rectsForTextMatches]): ditto
  • WebView/WebViewPrivate.h: declared new method canMarkAllTextMatches
5:07 PM Changeset in webkit [23773] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for: <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
​http://bugs.webkit.org/show_bug.cgi?id=14297

  • fast/overflow/hidden-scrollbar-resize-expected.checksum: Added.
  • fast/overflow/hidden-scrollbar-resize-expected.png: Added.
  • fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
  • fast/overflow/hidden-scrollbar-resize.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
​http://bugs.webkit.org/show_bug.cgi?id=14297

Test: fast/overflow/hidden-scrollbar-resize.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Updated our shouldPaint check to consider visibility.
3:59 PM Changeset in webkit [23772] by oliver
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info

Fixing logic error in DragController

  • manual-tests/drop-text-acquires-style.html: Added.
  • page/DragController.cpp: (WebCore::documentFragmentFromDragData):
2:36 PM Changeset in webkit [23771] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Annotate prototypes by adding "Prototype" subtitle.

  • page/inspector/ResourcePanel.js:
2:29 PM Changeset in webkit [23770] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix.

11:20 AM Changeset in webkit [23769] by staikos
  • 10 edits in trunk

Some work on adding HTTP proxy and SSL errors to WebKitQt, as well as preparing
for upcoming patches to do authentication.

10:48 AM Changeset in webkit [23768] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin


Fixed <rdar://problem/5292259> Find on Page doesn't work (throws exception) on page that includes PDF in a subframe

  • WebView/WebView.mm: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): We were testing whether the view was an HTMLView, but then running code that assumed it was an HTMLView outside of that test. That's a bad idea.
9:04 AM Changeset in webkit [23767] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=14386
Gdk build fix

  • WebCore.pro: Fix gtk/gdk typo.
8:44 AM Changeset in webkit [23766] by zbujtas
  • 3 edits in S60/trunk/WebCore

2007-06-22 hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Zalan (​zbujtas@gmail.com).
DESC: Bug 14214: [S60] Dropdown not opened if it has size defined in 3.1m.
​http://bugs.webkit.org/show_bug.cgi?id=14214

8:41 AM Changeset in webkit [23765] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2007-06-22 hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Zalan (​zbujtas@gmail.com).
DESC: Bug 14214: [S60] Dropdown not opened if it has size defined in 3.1m.
​http://bugs.webkit.org/show_bug.cgi?id=14214

7:51 AM Changeset in webkit [23764] by thatcher
  • 5 edits in trunk/WebCore

Reviewed by Anders.

Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
​http://bugs.webkit.org/show_bug.cgi?id=14385

Add a toggle to show implict computed properties.

  • page/inspector/ResourcePanel.js:
  • page/inspector/inspector.css:
  • page/inspector/inspector.js:
5:57 AM Changeset in webkit [23763] by bdash
  • 4 edits
    62 deletes in trunk

2007-06-25 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Mark.

​http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng

  • WebKit.pri: Link against external libjpeg and libpng.

2007-06-25 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Mark.

​http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng

  • WebCore.pro: Remove bundled libjpeg and libpng sources.
  • platform/image-decoders/jpeg: Remove sources.
  • platform/image-decoders/png: Remove sources.
3:31 AM Changeset in webkit [23762] by bdash
  • 24 edits
    4 adds in trunk

2007-06-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/table/caption-relayout.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Mark the caption for layout if the table width changed.

2007-06-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/table/caption-relayout-expected.checksum: Added.
  • fast/table/caption-relayout-expected.png: Added.
  • fast/table/caption-relayout-expected.txt: Added.
  • fast/table/caption-relayout.html: Added.
  • tables/mozilla/marvin/x_caption_class-expected.checksum:
  • tables/mozilla/marvin/x_caption_class-expected.png:
  • tables/mozilla/marvin/x_caption_class-expected.txt:
  • tables/mozilla/marvin/x_caption_id-expected.checksum:
  • tables/mozilla/marvin/x_caption_id-expected.png:
  • tables/mozilla/marvin/x_caption_id-expected.txt:
  • tables/mozilla/marvin/x_caption_style-expected.checksum:
  • tables/mozilla/marvin/x_caption_style-expected.png:
  • tables/mozilla/marvin/x_caption_style-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3166-5-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3166-6-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3166-9-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
3:29 AM Changeset in webkit [23761] by bdash
  • 3 edits
    4 adds in trunk

2007-06-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/inline/br-text-decoration.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width is zero. Also changed the line stroke to a rect fill, so that lines with length shorter than their thickness paint correctly.

2007-06-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/inline/br-text-decoration-expected.checksum: Added.
  • fast/inline/br-text-decoration-expected.png: Added.
  • fast/inline/br-text-decoration-expected.txt: Added.
  • fast/inline/br-text-decoration.html: Added.
3:27 AM Changeset in webkit [23760] by bdash
  • 5 edits in trunk/LayoutTests

2007-06-25 Matt Perry <​mpComplete@gmail.com>

Reviewed by Sam Weinig.

Modify test to wait until the second frame loads, and update its expected output to match.

  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum:
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837.html:
3:23 AM Changeset in webkit [23759] by bdash
  • 6 edits
    2 moves
    6 adds
    6 deletes in trunk

2007-06-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Covered by existing tests.

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl):

2007-06-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • tables/mozilla/marvin/table_rules_none-expected.checksum: Added.
  • tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • tables/mozilla/marvin/table_rules_none-expected.txt: Added.
  • tables/mozilla/marvin/table_rules_none.html: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/table_rules_none.html.
  • tables/mozilla/marvin/x_table_rules_none-expected.checksum: Added.
  • tables/mozilla/marvin/x_table_rules_none-expected.png: Added.
  • tables/mozilla/marvin/x_table_rules_none-expected.txt: Added.
  • tables/mozilla/marvin/x_table_rules_none.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_none.xml.
  • tables/mozilla_expected_failures/core/table_rules-expected.checksum:
  • tables/mozilla_expected_failures/core/table_rules-expected.png:
  • tables/mozilla_expected_failures/core/table_rules-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/table_rules_none-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/table_rules_none.html: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/x_table_rules_none.xml: Removed.
12:10 AM Changeset in webkit [23758] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14379
Anchor elements show up as their href in the properties pane, not HTMLAnchorElement

  • page/inspector/ResourcePanel.js: make sure not to call an overriden toString() by using Object.prototype.toString.call().

Jun 24, 2007:

10:09 PM Changeset in webkit [23757] by aroben
  • 2 edits in trunk/WebCore

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14374
Bug 14374: Computed Style section should be expanded by default

Reviewed by Sam.

No regression test possible.

  • page/inspector/ResourcePanel.js: Expand all style sections.
5:28 PM Changeset in webkit [23756] by aroben
  • 5 edits in trunk/WebCore

Unify the style of enums in the Inspector JS

All our enums are now represented by an object with a property for
each enum value.

Reviewed by Sam.

No regression test possible.

  • page/inspector/ConsolePanel.js:
  • page/inspector/Resource.js:
  • page/inspector/ResourcePanel.js:
  • page/inspector/inspector.js:
1:59 PM Changeset in webkit [23755] by weinig
  • 2 edits in trunk/WebKitSite

Reviewed by Adam Roben.

Fix broken link.

  • building/build.html:
1:53 PM Changeset in webkit [23754] by weinig
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=14321
getComputedStyle(...).zIndex returns string "normal"

  • fast/css/computed-style-expected.txt:
  • fast/css/getComputedStyle-zIndex-auto-expected.txt: Added.
  • fast/css/getComputedStyle-zIndex-auto.html: Added.

WebCore:

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14321
getComputedStyle(...).zIndex returns string "normal"

Test: fast/css/getComputedStyle-zIndex-auto.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
1:40 PM Web Inspector edited by mitz@webkit.org
windows -> Windows (diff)
12:22 PM Changeset in webkit [23753] by pewtermoose
  • 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 14265: Cannot resize columns in webinspector
​http://bugs.webkit.org/show_bug.cgi?id=14265

  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js:
11:51 AM Changeset in webkit [23752] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Added Bugzilla bug number for revision 23727.

12:07 AM Web Inspector edited by Adam Roben
(diff)

Jun 23, 2007:

5:37 PM Changeset in webkit [23751] by bdash
  • 2 edits in trunk/WebKitSite

2007-06-23 Mark Rowe <​mrowe@apple.com>

Not reviewed.

  • building/checkout.html: Update link to bypass caching proxy as it has a habit of breaking huge downloads.
12:23 PM Changeset in webkit [23750] by ggaren
  • 2 edits in trunk/LayoutTests

Uploading the correct expected results -- the ones checked in expected
an "unkown" callback, which was incorrect behavior.

  • fast/loader/user-style-sheet-resource-load-callbacks-expected.txt:
11:35 AM Changeset in webkit [23749] by aroben
  • 3 edits
    1 add in trunk

Fix the "num-cpus not found" warning the Windows WebCore build emits

WebCore:

Silence a build warning about not finding num-cpus

Reviewed by Mark Rowe.

  • WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new location.

WebKitTools:

Land num-cpus for the Windows build.

Reviewed by Mark Rowe.

  • Scripts/num-cpus: Added.
1:49 AM Changeset in webkit [23748] by hausmann
  • 2 edits in trunk/WebKitTools

Added support for populating ChangeLog entries from given git commits
using --git-commit=<commitish> and --git-reviewer=<name>.

Jun 22, 2007:

4:06 PM Changeset in webkit [23747] by adele
  • 2 edits in trunk/WebKit

Reviewed by Geoff and Darin.

Fix for: <rdar://problem/5239236> Other slash characters should not be permitted as part of a domain name

  • Misc/WebNSURLExtras.m: (isSlashOrPeriodLookalike): (allCharactersInIDNScriptWhiteList):
3:19 PM Changeset in webkit [23746] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFinishLoading): No need to fetch the size from resourceData.
3:16 PM Changeset in webkit [23745] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5288617>
Crash playing a very large QuickTime movie inside Safari.

Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for
plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
3:03 PM Changeset in webkit [23744] by bdakin
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Oliver and Darin.

Tests for <rdar://problem/5266999> Loading page from MangleMe fuzz
tester crashes in RenderTableRow::addChild (giant ROWSPAN)

The results of this test have changed because we now clamp rowspan
at 8190 to match Firefox.

  • fast/table/giantRowspan-expected.checksum:
  • fast/table/giantRowspan-expected.png:
  • fast/table/giantRowspan-expected.txt:

A new test that crashes our old heuristic for too-large rowspan,
but succeeds with the new one.

  • fast/table/giantRowspan2-expected.checksum: Added.
  • fast/table/giantRowspan2-expected.png: Added.
  • fast/table/giantRowspan2-expected.txt: Added.
  • fast/table/giantRowspan2.html: Added.

WebCore:

Reviewed by Oliver and Darin.

Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz
tester crashes in RenderTableRow::addChild (giant ROWSPAN)

We already have code that tries to prevent allocating too-large
rowspans. The rowspan in this test, however, was small enough that
we thought it was okay in that code, even though clearly it was
still too large. I did a bunch of testing in Firefox, and it seems
that they set a hard limit on the maximum rowspan right in the DOM
-- 8k. So that is what this patch implements.

  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::parseMappedAttribute):
2:57 PM Changeset in webkit [23743] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


<rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines when pressing return

Demonstrates bug:

  • editing/deleting/5272440-expected.checksum: Added.
  • editing/deleting/5272440-expected.png: Added.
  • editing/deleting/5272440-expected.txt: Added.
  • editing/deleting/5272440.html: Added.


upstream() now works for the positions visually equivalent to [span, 0]
where span is an inline root editable element:

  • editing/deleting/delete-mixed-editable-content-001-expected.txt:

WebCore:

Reviewed by Darin.


<rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete


Deletion inserts a placeholder after it removes full paragraphs if
one doesn't already exist. The code that looked for a pre-existing
placeholder didn't work because of a bug in enclosingNodeOfType.

  • editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): We start looking at node->parentNode(), but don't go above an editing root.
12:47 PM Changeset in webkit [23742] by andersca
  • 1 edit
    1 add in trunk/LayoutTests

Add result.


  • fast/loader/user-style-sheet-resource-load-callbacks-expected.txt: Added.
12:04 PM Changeset in webkit [23741] by andersca
  • 20 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/5244734>
WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)

  • fast/loader/resources/user-style-sheet.css: Added.
  • fast/loader/user-style-sheet-resource-load-callbacks.html: Added.

WebCore:

Reviewed by Maciej and Geoff.

<rdar://problem/5244734>
WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)


Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks
argument to a bunch of classes).


  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::sendResourceLoadCallbacks):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
  • loader/DocLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader):
  • loader/Request.cpp: (WebCore::Request::Request):
  • loader/Request.h: (WebCore::Request::sendResourceLoadCallbacks):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::sendResourceLoadCallbacks):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
  • loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::servePendingRequests):
  • loader/loader.h:
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
11:27 AM Changeset in webkit [23740] by thatcher
  • 6 edits in trunk

LayoutTests:

Reviewed by Anders.

<rdar://problem/5228168> Leopard regression test failures: fast/applescript


New results to match the DumpRenderTree changes.

  • fast/AppleScript/001-expected.txt:
  • fast/AppleScript/array-expected.txt:
  • fast/AppleScript/date-expected.txt:

WebKitTools:

Reviewed by Anders.

<rdar://problem/5228168> Leopard regression test failures: fast/applescript

There were some changes in Leopard that made our test output inconsistent with Tiger.

NSAppleEventDescriptor no longer returns a stringValue for typeType descriptors
on Leopard, so output our own readable string for typeType descriptors.

NSArray's description also changed on Leopard to output more whitespace, so
make our own string representation for typeAEList descriptors. This requires
a special case typeUnicodeText too, so the output is a quoted string.

  • DumpRenderTree/AppleScriptController.m: (convertAEDescToObject):
10:28 AM Changeset in webkit [23739] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2007-06-21 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: SCHY-72JNXK: 3.1 Voda: The alt text and broken images are not displayed correctly for IMG element.
​http://bugs.webkit.org/show_bug.cgi?id=14243

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::paint):
9:56 AM Changeset in webkit [23738] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 14305: Web Inspector marks local files with server-side compression tip
​http://bugs.webkit.org/show_bug.cgi?id=14305

  • page/inspector/Resource.js: (WebInspector.Resource._shouldCompress): Prevent server-side compression tip from being given to local files
12:00 AM Changeset in webkit [23737] by bdash
  • 3 edits
    2 adds in trunk

2007-06-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading

  • platform/StringImpl.cpp: (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string. This avoids returning a length of zero when the string is collapsed to empty by whitespace simplification.

2007-06-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

Test for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading

  • fast/frames/frame-set-whitespace-attributes-expected.txt: Added.
  • fast/frames/frame-set-whitespace-attributes.html: Added.

Jun 21, 2007:

11:05 PM Changeset in webkit [23736] by hyatt
  • 2 edits in trunk/WebCore

Fix large font size crash on Windows.

10:01 PM Changeset in webkit [23735] by andrew
  • 2 edits in trunk/WebCore

Reviewed by Timothy.

Stop shift+scroll wheel performing a horizontal scroll in Web Inspector

  • page/inspector/inspector.css: Set body margin to 0
9:11 PM Changeset in webkit [23734] by thatcher
  • 1 delete in trunk/WebKit/win/WebInspector

Remove some empty directories.

8:29 PM Changeset in webkit [23733] by staikos
  • 9 edits in trunk

Patch from Adam Treat to implement default icons / resources for Qt. Also does
a small cleanup to QWebPage::icon. This is a great example of how QWebSettings
is not ideal.

6:40 PM Changeset in webkit [23732] by oliver
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Use RetainPtr for holding currentEvent. This removes explicit HardRetain/Release calls
and makes reference handling simpler in advance of IME refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/EventHandlerMac.mm: (WebCore::currentEvent): (WebCore::EventHandler::currentNSEvent): (WebCore::EventHandler::wheelEvent): (WebCore::EventHandler::keyEvent): (WebCore::lastEventIsMouseUp): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::eventLoopHandleMouseUp): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::mouseDown): (WebCore::EventHandler::mouseDragged): (WebCore::EventHandler::mouseUp): (WebCore::EventHandler::mouseMoved):
5:41 PM Changeset in webkit [23731] by weinig
  • 1 edit
    1 delete in trunk/WebKit

Reviewed by Antti.

Remove empty directories

5:26 PM Changeset in webkit [23730] by staikos
  • 7 edits in trunk/WebCore

Add rendered and stylable scrollbars for Qt

5:11 PM Changeset in webkit [23729] by sfalken
  • 1 copy in tags/Safari-522.13.1b

New tag.

4:05 PM Changeset in webkit [23728] by ggaren
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt.


Fixed <rdar://problem/4977124> | ​http://bugs.webkit.org/show_bug.cgi?id=12646
REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML
effects when clicking on its links (12646)


Added layout test for this bug:

  • fast/invalid/nestedh3s-rapidweaver-expected.txt: Added.
  • fast/invalid/nestedh3s-rapidweaver.html: Added.

Reversed the expected results for this test because I rolled out r7703:

  • fast/invalid/nestedh3s-expected.checksum:
  • fast/invalid/nestedh3s-expected.png:
  • fast/invalid/nestedh3s-expected.txt:
  • fast/invalid/nestedh3s.html:

WebCore:

Reviewed by Dave Hyatt.


Fixed <rdar://problem/4977124> | ​http://bugs.webkit.org/show_bug.cgi?id=12646
REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML
effects when clicking on its links (12646)


I'm rolling our r7703 for these reasons:

  1. It broke RapidWeaver.


  1. WebKit is now orders of magnitude faster when handling deep nesting (5 seconds vs 3 minutes on my MBP in this particular case).
  1. Firefox, IE, and HTML5 all allow nested heading tags.


  1. Hyatt said so.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
3:34 PM Changeset in webkit [23727] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Remove assert for now as it is causing the back button to not
work in debug builds.

  • page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
2:45 PM Changeset in webkit [23726] by justing
  • 2 edits in trunk/WebKit

Reviewed by Tim.


<rdar://problem/5237524>
REGRESSION: Keyboard commands don't work in a message window until you click inside the message


When you open a message in its own window, Mail creates an empty
WebView, makes that WebView firstResponder and then sets off a
load inside that WebView.


When we're asked to create the empty WebView, we put an empty
WebHTMLView inside it (in r21367 we began creating a document
for empty frames). When Mail makes the WebView first responder
we make that empty WebHTMLView firstResponder. Then when the
load finishes we create a new WebHTMLView and set it as the
document view.


Inside _setDocumentView, if the old document view or one of its
descendants was the first responder, we'd makeFirstResponder:nil
so that the window wouldn't be left with a firstResponder that
was no longer inside of it. This change fixes the bug by instead
transferring firstResponder status to the new document view.


We could also fix this by not allowing the WebHTMLView to become
firstResponder when it's in the provisional state mentioned above.

  • WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]):
2:35 PM Changeset in webkit [23725] by thatcher
  • 1 copy in tags/Safari-5522.9

New tag.

2:26 PM Changeset in webkit [23724] by thatcher
  • 4 edits in trunk

Versioning

2:14 PM Changeset in webkit [23723] by andersca
  • 9 edits in trunk

LayoutTests:

Reviewed by Geoff.


Update test results.

  • http/tests/loading/bad-scheme-subframe-expected.txt:
  • http/tests/loading/bad-server-subframe-expected.txt:
  • http/tests/loading/basic-expected.txt:
  • http/tests/loading/empty-subframe-expected.txt:
  • http/tests/loading/simple-subframe-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:

WebKitTools:

Reviewed by Geoff.

Don't dump didFirstLayout callbacks, they happen intermittently.


  • DumpRenderTree/FrameLoadDelegate.m:
1:30 PM Changeset in webkit [23722] by lars
  • 2 edits in trunk/WebCore

Remove some debug output.

1:21 PM Changeset in webkit [23721] by andersca
  • 2 edits in trunk/LayoutTests

Reviewed by Geoff.

Update test result.


  • fast/dom/xmlhttprequest-invalid-values-expected.txt:
12:28 PM Changeset in webkit [23720] by staikos
  • 2 edits in trunk/WebCore

Fix the Qt Mac OS X build

12:19 PM Changeset in webkit [23719] by lars
  • 26 edits in trunk/LayoutTestResults

update test results after my font refactoring.

12:01 PM Changeset in webkit [23718] by ap
  • 6 edits
    1 add in trunk

Reviewed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=13905
REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding

Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
(regardless of the actual response MIME type). This was corrected a while ago to match other
browsers and the draft XHR spec.

Now restoring this functionality for "text/html", with spec editor's blessing.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::responseMIMEType): (WebCore::XMLHttpRequest::responseIsXML): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:
11:15 AM Changeset in webkit [23717] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Adele


  • fixed <rdar://problem/5268673> REGRESSION: Context menu missing for PDF in frame when there's no selection


This was surprisingly interesting. It turns out that at least for Safari, the method [WebDefaultUIDelegate
webView:contextMenuItemsForElement:defaultMenuItems:] is only exercised from WebPDFView these days. It mimics
some of the code that was moved to WebCore as part of the Great Context Menu Refactoring of 2006, but is
independent of that code. And it was partly broken/incomplete, probably as a result of said refactoring.

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm: (localizedMenuTitleFromAppKit()): deleted this function since I removed all callers (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Handle WebMenuItemTagOpenFrameInNewWindow tag, since code later in this file was relying on it. Added ASSERT_NOT_REACHED to the default case, since returning nil from this method is bad. Also, use WebKit versions of menu title strings rather than AppKit versions. We added these strings to WebKit a while back so we don't need to sneakily find them in AppKit anymore. (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): make the WebView be the target of the Open Frame in New Window item; previously it was self, but that was just silly (probably a leftover from some code shuffling when context menus were reimplemented)
  • WebView/WebView.mm: (-[WebView _openFrameInNewWindowFromMenu:]): new method, used by Open Frame in New Window menu item.
  • WebView/WebViewInternal.h: Declare new method used by menu item. This isn't necessary for compilation, but could prevent the accidental deletion of the method implementation.
8:04 AM Changeset in webkit [23716] by spadma
  • 2 edits in S60/trunk/WebKit

2007-06-18 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: stream requests are cancelled after "javascript:" execution
​http://www.v28power.com/flash.htm

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): return after executing javascript.
8:01 AM Changeset in webkit [23715] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-06-20 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: EYLG-6ZVCLT - Chinese candidate and autofill boxes overlap
​http://bugs.webkit.org/show_bug.cgi?id=14239

  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::FormDataManagerHandlerL):
7:09 AM Changeset in webkit [23714] by andrew
  • 2 edits in trunk/WebCore

Mac build fix.

  • platform/Font.h:
4:02 AM Changeset in webkit [23713] by lars
  • 2 edits in trunk/WebCore

another small fix for letter spacing

4:01 AM Changeset in webkit [23712] by lars
  • 2 edits in trunk/WebCore

fix word-spacing

4:01 AM Changeset in webkit [23711] by lars
  • 6 edits in trunk/WebCore

fix letterspacing and small caps.

4:01 AM Changeset in webkit [23710] by lars
  • 3 edits in trunk/WebCore

store the metrics and space width in the Font object

4:01 AM Changeset in webkit [23709] by lars
  • 2 edits in trunk/WebCore

simplify some codepaths

4:00 AM Changeset in webkit [23708] by lars
  • 2 edits in trunk/WebCore

fix copyright header

4:00 AM Changeset in webkit [23707] by lars
  • 2 edits in trunk/WebCore

correctly load fonts when a list of font families is given

4:00 AM Changeset in webkit [23706] by lars
  • 2 edits in trunk/WebCore

fix some more of the font support

4:00 AM Changeset in webkit [23705] by lars
  • 2 edits in trunk/WebKitTools

look for the Qt library in the installed location

3:59 AM Changeset in webkit [23704] by lars
  • 3 edits in trunk/WebCore

Compile fixes

3:59 AM Changeset in webkit [23703] by lars
  • 2 edits in trunk/WebCore

Some more work on the implementation of FontQt.

3:59 AM Changeset in webkit [23702] by lars
  • 6 edits in trunk/WebCore

Started work on the new font infrastructure for the Qt port.

12:49 AM Changeset in webkit [23701] by aroben
  • 4 edits in trunk/WebCore

More Gdk build fixes.

  • page/gdk/ContextMenuClientGdk.cpp:

(WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):

  • page/gdk/ContextMenuClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp:
12:25 AM Changeset in webkit [23700] by aroben
  • 2 edits in trunk/WebCore

Speculative Gdk build fix.

  • page/InspectorController.h: Only include the JS headers we really

need to avoid pulling in ones like JSStringRefCF.h.

12:00 AM Changeset in webkit [23699] by aroben
  • 2 edits in trunk

Reviewed by Simon Hausmann.

More Gdk build fixing.

  • WebKit.pro:

Jun 20, 2007:

11:56 PM Web Inspector edited by timothy@apple.com
Corrections about the new inspector. (diff)
11:51 PM Changeset in webkit [23698] by aroben
  • 2 edits in trunk/WebCore

Speculative Gdk build fix.

  • WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
11:11 PM Changeset in webkit [23697] by aroben
  • 2 edits in trunk/WebCore

Windows build fix.

  • WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after

everything but $WebKitLibrariesDir so that we will pick up
JavaScriptCore headers directly.

11:00 PM Changeset in webkit [23696] by sfalken
  • 1 copy in tags/Safari-522.12.6b

New tag.

10:46 PM Changeset in webkit [23695] by staikos
  • 2 edits in trunk/WebCore

add missing symbol

10:42 PM Changeset in webkit [23694] by staikos
  • 3 edits in trunk/JavaScriptCore

More missing files for building with Qt

10:32 PM Changeset in webkit [23693] by sfalken
  • 2 edits in trunk/WebCore

Merge fix from r23692.

10:22 PM Changeset in webkit [23692] by sfalken
  • 2 edits in branches/Safari-522-2/WebCore

Reviewed by Maciej, Anders.


<rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on ​http://lcamtuf.coredump.cx/ierace/

Keep a reference to the Page (via the main frame) for the
load deferred pages.


Reference is held via the frame since Page isn't refcounted.

  • page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
10:01 PM Changeset in webkit [23691] by staikos
  • 11 edits
    4 adds in trunk

Patch from Adam Treat to add ICO support to the Qt build.

9:55 PM Changeset in webkit [23690] by ap
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Anders.

One more test for XHR header injection.

  • http/tests/xmlhttprequest/inject-header-expected.txt: Added.
  • http/tests/xmlhttprequest/inject-header.html: Added.
9:43 PM Changeset in webkit [23689] by staikos
  • 3 edits in trunk/JavaScriptCore

One last build fix - now it runs again

9:31 PM Changeset in webkit [23688] by staikos
  • 9 edits
    2 adds in trunk

Repair the Qt build

8:44 PM Changeset in webkit [23687] by beidson
  • 5 edits in branches/Safari-522/LayoutTests

Merged r23616

8:38 PM Changeset in webkit [23686] by aroben
  • 3 edits
    2 adds in trunk

WebCore:

More speculative Qt/Gdk build fixes.

  • WebCore.pro: Add new files.

WebKitQt:

More speculative Qt build fixes.

Add a stub implementation of InspectorClientQt.

  • WebCoreSupport/InspectorClientQt.cpp: Added. (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::createPage): (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow): (WebCore::InspectorClientQt::attachWindow): (WebCore::InspectorClientQt::detachWindow): (WebCore::InspectorClientQt::highlight): (WebCore::InspectorClientQt::hideHighlight):
  • WebCoreSupport/InspectorClientQt.h: Added.
8:21 PM Changeset in webkit [23685] by aroben
  • 1 edit
    8 adds in trunk/WebCore

Speculative Qt/Gdk build fix.

Added forwarding headers for JavaScriptCore. We may eventually move
InspectorController off of the JSC API, but for now this is the
quickest way to a working build.

  • ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
  • ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
  • ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
  • ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
  • ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
  • ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
  • ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
8:18 PM Changeset in webkit [23684] by weinig
  • 6 edits in trunk/WebCore

Rubber stamped by Adam Roben.

Add licenses.

  • page/inspector/ConsolePanel.js:
  • page/inspector/NetworkPanel.js:
  • page/inspector/Resource.js:
  • page/inspector/ResourceCategory.js:
  • page/inspector/ResourcePanel.js:
8:17 PM Changeset in webkit [23683] by bdash
  • 1 edit in trunk/WebKit/ChangeLog

Add Bugzilla info to ChangeLog entry.

8:11 PM Changeset in webkit [23682] by bdash
  • 5 edits
    2 adds in trunk

2007-06-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Adam.

Reinstate the WebInspector class so WebKit clients that currently depend on it
will build and run correctly.

2007-06-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Adam.

  • WebCore.exp: Export InspectorController::inspect so WebKit can see it.
7:59 PM Changeset in webkit [23681] by aroben
  • 3 edits in trunk/WebCore

Addressed some of Geoff's comments.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::handleContextMenuEvent): Added a
FIXME.

  • platform/ContextMenu.cpp:

(WebCore::ContextMenu::addInspectElementItem): Null-check
frame->page().

7:46 PM Changeset in webkit [23680] by ggaren
  • 6 edits in trunk

WebCore:

Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.

Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5:
Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString
returning nil instead of "")

I'm basically rolling out the change for <rdar://problem/4782422> because
my testing shows that it was backwards.


  • html/HTMLElement.cpp: (dumpInnerHTML): New debug-only function to work around gdb being perpetually suck-tastic.
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):


Return "", not nil. This function never used to return nil, so let's not
start now. I've filed <rdar://problem/5283271> to cover the documentation bug,

WebKitTools:

Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.

Added tests for stringByEvaluatingJavaScriptFromString.

  • DumpRenderTree/DumpRenderTree.m: (testStringByEvaluatingJavaScriptFromString): (dumpRenderTree):
7:34 PM Changeset in webkit [23679] by aroben
  • 2 edits in trunk/WebCore

Fix crash in fast/dom/dir-no-body.html

Reviewed by Mark.

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::createTokenizer): Don't assume we have a
Frame, since we won't if someone creates an HTMLDocument from JS.

6:57 PM Changeset in webkit [23678] by andersca
  • 2 edits in trunk/LayoutTests

Reviewed by Geoff.

Make sure that the test case tests '\n' and '\r' too.


  • fast/dom/xmlhttprequest-invalid-values.html:
6:37 PM Changeset in webkit [23677] by aroben
  • 58 edits
    4 copies
    8 moves
    98 adds
    51 deletes in trunk

Land the new Inspector.

WebCore:

Land the new Inspector.

Co-written with Tim Hatcher.

Reviewed by Anders, Adele, Hyatt, and Sam.

No regression tests possible.

Add a new InspectorController that is in charge of the Inspector. It
has an InspectorClient that controls the Inspector's window and node
highlight.

  • page/InspectorClient.h: Added. (WebCore::InspectorClient::~InspectorClient):
  • page/InspectorController.cpp: Added. (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::InspectorResource::): Represents a single resource that the Inspector knows about. (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::~InspectorResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::setScriptObject): (WebCore::addSourceToFrame): Callback available from JS. (WebCore::getResourceDocumentNode): Ditto. (WebCore::highlightDOMNode): Ditto. (WebCore::hideDOMNodeHighlight): Ditto. (WebCore::loaded): Ditto. (WebCore::unloading): Ditto. (WebCore::attach): Ditto. (WebCore::detach): Ditto. (WebCore::log): Ditto. (WebCore::search): Ditto. (WebCore::inspectedWindow): Ditto. (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspect): Called by ContextMenuController to inspect a node. (WebCore::InspectorController::focusNode): (WebCore::InspectorController::highlight): (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::windowVisible): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::attachWindow): (WebCore::InspectorController::detachWindow): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::windowUnloading): (WebCore::addHeaders): Static helper function. (WebCore::objectForRequest): Ditto. (WebCore::objectForResponse): Ditto. (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::addAndUpdateScriptResource): (WebCore::InspectorController::removeScriptResource): (WebCore::InspectorController::updateScriptResource): (WebCore::InspectorController::populateScriptResources): (WebCore::InspectorController::addScriptConsoleMessage): (WebCore::callClearFunction): Static helper function. (WebCore::InspectorController::clearScriptResources): (WebCore::InspectorController::clearScriptConsoleMessages): (WebCore::InspectorController::clearNetworkTimeline): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): Callback from FrameLoader. (WebCore::InspectorController::frameDetachedFromParent): Ditto. (WebCore::InspectorController::addResource): Ditto. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto. (WebCore::InspectorController::identifierForInitialRequest): Ditto. (WebCore::InspectorController::willSendRequest): Ditto. (WebCore::InspectorController::didReceiveResponse): Ditto. (WebCore::InspectorController::didReceiveContentLength): Ditto. (WebCore::InspectorController::didFinishLoading): Ditto. (WebCore::InspectorController::didFailLoading): Ditto.
  • page/InspectorController.h: Added. (WebCore::InspectorController::inspectedPage): (WebCore::InspectorController::scriptContext): (WebCore::InspectorController::setScriptContext): (WebCore::InspectorController::resources): (WebCore::InspectorController::removeAllResources):

Add the JavaScript that defines most of the behavior of the Inspector.

  • page/inspector/ConsolePanel.js: Added.
  • page/inspector/NetworkPanel.js: Added.
  • page/inspector/Resource.js: Added.
  • page/inspector/ResourceCategory.js: Added.
  • page/inspector/ResourcePanel.js: Added.
  • page/inspector/inspector.js: Added.
  • page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
  • page/inspector/utilities.js: Added.

Add the Inspector's CSS and HTML.

  • page/inspector/inspector.css: Added.
  • page/inspector/inspector.html: Added.

Hang the InspectorController off of Page. We only create an
InspectorController if an InspectorClient is given to the Page.

  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::inspectorController):

Use FrameLoader to notify the InspectorController of resource loads.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::assignIdentifierToInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::dispatchWindowObjectAvailable): (WebCore::FrameLoader::dispatchDidCommitLoad): (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): (WebCore::FrameLoader::dispatchWillSendRequest): (WebCore::FrameLoader::dispatchDidReceiveResponse): (WebCore::FrameLoader::dispatchDidReceiveContentLength): (WebCore::FrameLoader::dispatchDidFinishLoading): (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
  • loader/FrameLoader.h:

Send console messages to the InspectorController.

  • page/Chrome.cpp: (WebCore::Chrome::addMessageToConsole): Send all console messages to the InspectorController.
  • page/Chrome.h: Add a new MessageLevel and MessageSource that are used in the Inspector JS.

Report HTML errors when the Inspector window is open.
We don't report errors when the window is closed because we don't want
to slow down the HTMLTokenizer.

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser):
  • html/HTMLParser.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer):
  • html/HTMLTokenizer.h:

Append the "Inspect Element" context menu item after passing the
context menu to the ContextMenuClient. This work used to be done in
WebKit.

  • page/ContextMenuClient.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Add the "Inspect Element" item. (WebCore::ContextMenuController::contextMenuItemSelected): Handle the "Inspect Element" item.
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::addInspectElementItem): (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect Element" item.
  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h: (WebCore::): Add ContextMenuItemTagInspectElement.
  • platform/graphics/svg/SVGImageEmptyClients.h:
  • page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized string.
  • platform/LocalizedStrings.h: Ditto.
  • platform/mac/LocalizedStringsMac.mm: (WebCore::contextMenuItemTagInspectElement): Ditto.

Miscellaneous changes:

  • css/view-source.css: Add message bubble styles.
  • loader/DocumentLoader.h: Add a frame getter.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars): Respect Frame::prohibitsScrolling.

Add new images needed for the Inspector.

  • page/inspector/Images/attachedShadow.png: Added.
  • page/inspector/Images/bottomShadow.png: Added.
  • page/inspector/Images/breadcrumbBackground.png: Added.
  • page/inspector/Images/checker.png: Added.
  • page/inspector/Images/console.png: Added.
  • page/inspector/Images/darkShadow.png: Added.
  • page/inspector/Images/disclosureDownPressed.png: Added.
  • page/inspector/Images/disclosureRightDown.png: Added.
  • page/inspector/Images/disclosureRightPressed.png: Added.
  • page/inspector/Images/document.png: Added.
  • page/inspector/Images/domViewButton.png: Added.
  • page/inspector/Images/domViewButtonSelected.png: Added.
  • page/inspector/Images/downTriangle.png: Added.
  • page/inspector/Images/errorIcon.png: Added.
  • page/inspector/Images/errorMediumIcon.png: Added.
  • page/inspector/Images/folder.png: Added.
  • page/inspector/Images/goArrow.png: Added.
  • page/inspector/Images/gradient.png: Added.
  • page/inspector/Images/gradientHighlight.png: Added.
  • page/inspector/Images/gradientHighlightBottom.png: Added.
  • page/inspector/Images/hideStatusWidget.png: Added.
  • page/inspector/Images/hideStatusWidgetPressed.png: Added.
  • page/inspector/Images/network.png: Added.
  • page/inspector/Images/paneBottomGrow.png: Added.
  • page/inspector/Images/paneBottomGrowActive.png: Added.
  • page/inspector/Images/paneGrowHandleLine.png: Added.
  • page/inspector/Images/paneHeader.png: Added.
  • page/inspector/Images/paneHeaderActive.png: Added.
  • page/inspector/Images/plainDocument.png: Added.
  • page/inspector/Images/popupArrows.png: Added.
  • page/inspector/Images/rightTriangle.png: Added.
  • page/inspector/Images/segment.png: Added.
  • page/inspector/Images/segmentEnd.png: Added.
  • page/inspector/Images/segmentHover.png: Added.
  • page/inspector/Images/segmentHoverEnd.png: Added.
  • page/inspector/Images/segmentSelected.png: Added.
  • page/inspector/Images/segmentSelectedEnd.png: Added.
  • page/inspector/Images/showStatusWidget.png: Added.
  • page/inspector/Images/showStatusWidgetPressed.png: Added.
  • page/inspector/Images/sidbarItemBackground.png: Added.
  • page/inspector/Images/sidebarActionWidget.png: Added.
  • page/inspector/Images/sidebarActionWidgetPressed.png: Added.
  • page/inspector/Images/sidebarAttachWidget.png: Added.
  • page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
  • page/inspector/Images/sidebarDetachWidget.png: Added.
  • page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
  • page/inspector/Images/sidebarResizeWidget.png: Added.
  • page/inspector/Images/sidebarSelection.png: Added.
  • page/inspector/Images/sidebarSelectionBlurred.png: Added.
  • page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
  • page/inspector/Images/sidebarSelectionGray.png: Added.
  • page/inspector/Images/sidebarSelectionGrayTall.png: Added.
  • page/inspector/Images/sidebarSelectionTall.png: Added.
  • page/inspector/Images/sidebarStatusAreaBackground.png: Added.
  • page/inspector/Images/sourceViewButton.png: Added.
  • page/inspector/Images/sourceViewButtonSelected.png: Added.
  • page/inspector/Images/splitviewDimple.png: Added.
  • page/inspector/Images/splitviewDividerBackground.png: Added.
  • page/inspector/Images/tab.png: Added.
  • page/inspector/Images/tabSelected.png: Added.
  • page/inspector/Images/timelinePillBlue.png: Added.
  • page/inspector/Images/timelinePillGray.png: Added.
  • page/inspector/Images/timelinePillGreen.png: Added.
  • page/inspector/Images/timelinePillOrange.png: Added.
  • page/inspector/Images/timelinePillPurple.png: Added.
  • page/inspector/Images/timelinePillRed.png: Added.
  • page/inspector/Images/timelinePillYellow.png: Added.
  • page/inspector/Images/tipBalloon.png: Added.
  • page/inspector/Images/tipBalloonBottom.png: Added.
  • page/inspector/Images/tipIcon.png: Added.
  • page/inspector/Images/tipIconPressed.png: Added.
  • page/inspector/Images/toggleDown.png: Added.
  • page/inspector/Images/toggleUp.png: Added.
  • page/inspector/Images/toolbarBackground.png: Added.
  • page/inspector/Images/toolbarBackgroundInactive.png: Added.
  • page/inspector/Images/toolbarButton.png: Added.
  • page/inspector/Images/toolbarButtonInactive.png: Added.
  • page/inspector/Images/toolbarButtonPressed.png: Added.
  • page/inspector/Images/toolbarButtonPressedInactive.png: Added.
  • page/inspector/Images/toolbarSplitButtonDivider.png: Added.
  • page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
  • page/inspector/Images/treeDownTriangleBlack.png: Added.
  • page/inspector/Images/treeDownTriangleWhite.png: Added.
  • page/inspector/Images/treeLeftTriangleBlack.png: Added.
  • page/inspector/Images/treeRightTriangleBlack.png: Added.
  • page/inspector/Images/treeRightTriangleWhite.png: Added.
  • page/inspector/Images/warningIcon.png: Added.
  • page/inspector/Images/warningMediumIcon.png: Added.
  • page/inspector/Images/warningsErrors.png: Added.

Build-fu:

  • WebCore.exp: Added new symbols.
  • WebCore.xcodeproj/project.pbxproj: Added new source files and resources.
  • WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to $WebKitOutputDir.

Windows build fixes:

  • history/HistoryItem.h: ResourceRequest is a struct.
  • loader/FrameLoaderClient.h: Ditto.

WebKit:

Land the new Inspector.

Co-written with Tim Hatcher.

Reviewed by Anders, Adele, Hyatt, and Sam.

Implement the InspectorClient interface.

  • WebCoreSupport/WebInspectorClient.h: Added.
  • WebCoreSupport/WebInspectorClient.mm: Added. (WebInspectorClient::WebInspectorClient): (WebInspectorClient::inspectorDestroyed): (WebInspectorClient::createPage): (WebInspectorClient::showWindow): (WebInspectorClient::closeWindow): (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorClient::inspectedURLChanged): (WebInspectorClient::updateWindowTitle): (-[WebInspectorWindowController init]): (-[WebInspectorWindowController initWithInspectedWebView:]): (-[WebInspectorWindowController dealloc]): (-[WebInspectorWindowController inspectorVisible]): (-[WebInspectorWindowController webView]): (-[WebInspectorWindowController window]): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController close]): (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]): (-[WebInspectorWindowController highlightAndScrollToNode:]): (-[WebInspectorWindowController highlightNode:]): (-[WebInspectorWindowController hideHighlight]): (-[WebInspectorWindowController animationDidEnd:]):

Add an easier-to-see highlight.

  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m: (-[NSView _web_convertRect:toView:]):
  • WebInspector/WebNodeHighlight.h:
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlightFadeInAnimation setCurrentProgress:]): (-[WebNodeHighlight initWithTargetView:]): (-[WebNodeHighlight setHighlightedNode:]): (-[WebNodeHighlight highlightedNode]): (-[WebNodeHighlight dealloc]): (-[WebNodeHighlight attachHighlight]): (-[WebNodeHighlight delegate]): (-[WebNodeHighlight detachHighlight]): (-[WebNodeHighlight show]): (-[WebNodeHighlight hide]): (-[WebNodeHighlight animationDidEnd:]): (-[WebNodeHighlight ignoresMouseEvents]): (-[WebNodeHighlight highlightView]): (-[WebNodeHighlight setDelegate:]): (-[WebNodeHighlight setHolesNeedUpdateInTargetViewRect:]): (-[WebNodeHighlight setIgnoresMouseEvents:]): (-[WebNodeHighlight targetView]): (-[WebNodeHighlight _computeHighlightWindowFrame]): (-[WebNodeHighlight _repositionHighlightWindow]):
  • WebInspector/WebNodeHighlightView.h:
  • WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView initWithWebNodeHighlight:]): (-[WebNodeHighlightView dealloc]): (-[WebNodeHighlightView detachFromWebNodeHighlight]): (-[WebNodeHighlightView drawRect:]): (-[WebNodeHighlightView webNodeHighlight]): (-[WebNodeHighlightView fractionFadedIn]): (-[WebNodeHighlightView setFractionFadedIn:]): (-[WebNodeHighlightView setHolesNeedUpdateInRect:]): (-[WebNodeHighlightView _holes]):

WebView changes needed for the new Inspector.

  • WebView/WebView.mm: Remove the old _inspectElement method now that this is handled by WebCore. (-[WebView _isClosed]): Added. (-[WebView initWithFrame]): Give each Page an InspectorClient to enable the Inspector.
  • WebView/WebViewPrivate.h:

Updates needed for WebCore changes.

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagInspectElement]):
  • WebView/WebUIDelegatePrivate.h:

Remove old Inspector code.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchDidFinishLoading):
  • WebInspector/WebInspector.m: Removed.
  • WebInspector/WebInspectorPanel.h: Removed.
  • WebInspector/WebInspectorPanel.m: Removed.
  • WebInspector/webInspector/Images/button.png: Removed.
  • WebInspector/webInspector/Images/buttonDivider.png: Removed.
  • WebInspector/webInspector/Images/buttonPressed.png: Removed.
  • WebInspector/webInspector/Images/close.png: Removed.
  • WebInspector/webInspector/Images/closePressed.png: Removed.
  • WebInspector/webInspector/Images/downTriangle.png: Removed.
  • WebInspector/webInspector/Images/menu.png: Removed.
  • WebInspector/webInspector/Images/menuPressed.png: Removed.
  • WebInspector/webInspector/Images/popup.png: Removed.
  • WebInspector/webInspector/Images/popupPressed.png: Removed.
  • WebInspector/webInspector/Images/resize.png: Removed.
  • WebInspector/webInspector/Images/rightTriangle.png: Removed.
  • WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
  • WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
  • WebInspector/webInspector/Images/scrollTrackBottom.png: Removed.
  • WebInspector/webInspector/Images/upTriangle.png: Removed.
  • WebInspector/webInspector/inspector.css: Removed.
  • WebInspector/webInspector/inspector.html: Removed.
  • WebInspector/webInspector/inspector.js: Removed.
  • WebInspector/webInspector/scrollarea.js: Removed.
  • WebInspector/webInspector/scrollbar.js: Removed.
  • WebInspector/webInspector/utilities.js: Removed.
  • WebView/WebFrame.mm: (-[WebFramePrivate dealloc]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]):

Build-fu:

  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:

WebKit/win:

Land the new Inspector.

Co-written with Tim Hatcher.

Reviewed by Anders, Adele, Hyatt, and Sam.

Implement the InspectorClient interface.

  • WebInspectorClient.cpp: Added. (WebInspectorClient::WebInspectorClient): (WebInspectorClient::~WebInspectorClient): (WebInspectorClient::inspectorDestroyed): (WebInspectorClient::createPage): (WebInspectorClient::showWindow): (WebInspectorClient::closeWindow): (WebInspectorClient::windowVisible): (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorClient::inspectedURLChanged): (WebInspectorClient::updateWindowTitle): (WebInspectorClient::onSize): (WebInspectorClient::onClose): (WebInspectorClient::onWebViewWindowPosChanging): (WebInspectorWndProc): (SubclassedWebViewWndProc): (registerWindowClass):
  • WebInspectorClient.h: Added.

Add an easier-to-see highlight.

  • WebNodeHighlight.cpp: Added. (WebNodeHighlight::WebNodeHighlight): (WebNodeHighlight::~WebNodeHighlight): (WebNodeHighlight::highlight): (WebNodeHighlight::hide): (WebNodeHighlight::visible): (WebNodeHighlight::updateWindow): (WebNodeHighlight::removeSubclass): (registerOverlayClass): (OverlayWndProc): (SubclassedWndProc):
  • WebNodeHighlight.h: Added.

WebView changes needed for the new Inspector.

  • WebView.cpp: Removed old inspectElement method now that this is handled by WebCore. (WebView::WebView): (WebView::close): (WebView::performContextMenuAction): Removed handling of the Inspect Element context menu item. (WebView::initWithFrame): Give each Page an InspectorClient to enable the Inspector. (WebView::setProhibitsMainFrameScrolling): Added.
  • WebView.h:

Updates needed for WebCore changes.

  • Interfaces/IWebUIDelegate.idl:
  • WebContextMenuClient.cpp: (WebContextMenuClient::getCustomMenuFromDefaultItems):
  • WebContextMenuClient.h:
  • WebCoreLocalizedStrings.cpp:

Remove old Inspector code.

  • WebFrame.cpp:
  • WebFrame.h:
  • WebInspector/WebInspector.cpp: Removed.
  • WebInspector/WebInspector.h: Removed.
  • WebInspector/webInspector/Images/button.png: Removed.
  • WebInspector/webInspector/Images/buttonDivider.png: Removed.
  • WebInspector/webInspector/Images/buttonPressed.png: Removed.
  • WebInspector/webInspector/Images/close.png: Removed.
  • WebInspector/webInspector/Images/closePressed.png: Removed.
  • WebInspector/webInspector/Images/downTriangle.png: Removed.
  • WebInspector/webInspector/Images/menu.png: Removed.
  • WebInspector/webInspector/Images/menuPressed.png: Removed.
  • WebInspector/webInspector/Images/popup.png: Removed.
  • WebInspector/webInspector/Images/popupPressed.png: Removed.
  • WebInspector/webInspector/Images/resize.png: Removed.
  • WebInspector/webInspector/Images/rightTriangle.png: Removed.
  • WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
  • WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
  • WebInspector/webInspector/Images/scrollTrackMiddle.png: Removed.
  • WebInspector/webInspector/Images/upTriangle.png: Removed.
  • WebInspector/webInspector/inspector.css: Removed.
  • WebInspector/webInspector/inspector.html: Removed.
  • WebInspector/webInspector/inspector.js: Removed.
  • WebInspector/webInspector/scrollarea.js: Removed.
  • WebInspector/webInspector/scrollbar.js: Removed.
  • WebInspector/webInspector/treeoutline.js: Removed.
  • WebInspector/webInspector/utilities.js: Removed.

Build-fu:

  • WebKit.vcproj/WebKit.vcproj:
5:09 PM Changeset in webkit [23676] by bdash
  • 3 edits
    4 adds in trunk

2007-06-20 Mitz Pettel <​mitz@webkit.org>

Reviewed by Beth.

Test: fast/repaint/table-row.html

  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the table row also needs layout, so it doesn't get a repaint in setStyle().

2007-06-20 Mitz Pettel <​mitz@webkit.org>

Reviewed by Beth.

  • fast/repaint/table-row-expected.checksum: Added.
  • fast/repaint/table-row-expected.png: Added.
  • fast/repaint/table-row-expected.txt: Added.
  • fast/repaint/table-row.html: Added.
5:00 PM Changeset in webkit [23675] by bdash
  • 5 edits in trunk

2007-06-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14244
Bug 14244: Data corruption when using a replace() callback function with data containing "$"

  • kjs/string_object.cpp: (KJS::replace): When 'replacement' is a function, do not replace $n placeholders in its return value. This matches the behaviour described in ECMA 262 3rd Ed section 15.5.4.1, and as implemented in Firefox.

2007-06-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14244
Bug 14244: Data corruption when using a replace() callback function with data containing "$"

  • fast/js/resources/string-replace-2.js: Update to test with 'replaceValue' being a function returning strings with "$n" placeholders.
  • fast/js/string-replace-2-expected.txt:
4:38 PM Changeset in webkit [23674] by thatcher
  • 1 copy in tags/WebCore-315.14.8/WebCore

New tag (part 2.)

4:37 PM Changeset in webkit [23673] by thatcher
  • 1 add in tags/WebCore-315.14.8

New tag (part 1.)

4:27 PM Changeset in webkit [23672] by thatcher
  • 1 copy in tags/WebCore-4522.12/WebCore

New tag (part 2.)

4:26 PM Changeset in webkit [23671] by thatcher
  • 1 add in tags/WebCore-4522.12

New tag (part 1.)

4:26 PM Changeset in webkit [23670] by thatcher
  • 1 edit in branches/Safari-522/WebCore/Configurations/Version.xcconfig

Versioning

4:24 PM Changeset in webkit [23669] by thatcher
  • 1 copy in tags/WebCore-419.1.2/WebCore

New tag (part 2.)

4:22 PM Changeset in webkit [23668] by thatcher
  • 1 add in tags/WebCore-419.1.2

New tag (part 1.)

4:17 PM Changeset in webkit [23667] by thatcher
  • 1 copy in tags/WebCore-418.22.2/WebCore

New tag (part 2.)

4:14 PM Changeset in webkit [23666] by thatcher
  • 1 add in tags/WebCore-418.22.2

New tag (part 1.)

4:10 PM Changeset in webkit [23665] by thatcher
  • 2 edits in branches/Safari-2.0-system/WebCore

Versioning

4:08 PM Changeset in webkit [23664] by thatcher
  • 2 edits in branches/Safari-2.0-dashboard/WebCore

Versioning

4:06 PM Changeset in webkit [23663] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

3:39 PM Changeset in webkit [23662] by sfalken
  • 1 copy in tags/Safari-522.12.5b

New tag.

3:03 PM BuildingOnWindows edited by bdash@webkit.org
(diff)
2:56 PM Changeset in webkit [23661] by adele
  • 4 edits
    5 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/borders/border-image-01-expected.checksum: Added.
  • fast/borders/border-image-01-expected.png: Added.
  • fast/borders/border-image-01-expected.txt: Added.
  • fast/borders/border-image-01.html: Added.
  • fast/borders/resources/border-image.png: Added.

WebCore:

Reviewed by Adele.

Test: fast/borders/border-image-01.html

Correctly account for the fact that "pattern space" is flipped.

  • platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):
2:52 PM Changeset in webkit [23660] by andersca
  • 2 edits in branches/Safari-2.0-system/WebCore

Merge 23655

2:52 PM Changeset in webkit [23659] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged r23658.

2:50 PM Changeset in webkit [23658] by andersca
  • 2 edits in branches/Safari-2.0-dashboard/WebCore

Merge 23655

2:40 PM Changeset in webkit [23657] by andersca
  • 2 edits in branches/Safari-522-2/WebCore

Reviewed by Darin.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader


Check for either '\r' or '\n' in the header value.


  • xml/xmlhttprequest.cpp: (WebCore::isValidHeaderValue):
2:35 PM Changeset in webkit [23656] by andersca
  • 2 edits in branches/Safari-522/WebCore

Merge 23655

2:29 PM Changeset in webkit [23655] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader


Check for either '\r' or '\n' in the header value.


  • xml/xmlhttprequest.cpp: (WebCore::isValidHeaderValue):
2:16 PM Changeset in webkit [23654] by justing
  • 2 edits in trunk/WebKit

Reviewed by Darin.


<rdar://problem/5263541> REGRESSION (Safari 3 Beta 1): Pressing Delete doesn't delete an HTML message in Mail


Mail wasn't receiving the keyDown event because WebFrameView was blocking it.
It blocks the event and moves back/forward on Delete/Shift+Delete if the
back/forward list is enabled.

  • WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Check to see if the BackForwardList is enabled. It always exists.
1:56 PM Changeset in webkit [23653] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/4882527> VO should speak URL of image links that lack tags

Add additional change from review


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Check if the element has imgTag before asking for its url
1:08 PM Changeset in webkit [23652] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/4882527> VO should speak URL of image links that lack tags

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeNames]): (-[WebCoreAXObject accessibilityAttributeValue:]): Return the url of images.
9:07 AM Changeset in webkit [23651] by andersca
  • 2 edits in trunk/LayoutTests

Remove the XPath tests, they all pass now.


  • win/Skipped:
12:14 AM Changeset in webkit [23650] by rwlbuis
  • 5 edits
    4 adds in branches/feature-branch

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=14157
Rotated shape has wrong gradient rendering

Use the untransformed bbox in objectBoundingBoxMode. Also
don't do objectBoundingBoxMode should the bbox width ort height
be zero.

Jun 19, 2007:

7:41 PM Changeset in webkit [23649] by kevino
  • 2 edits in branches/wx-port-alpha/trunk

Bakefile changes to build against wx jpeg lib and sys png.

7:28 PM Changeset in webkit [23648] by kevino
  • 62 deletes in branches/wx-port-alpha/trunk/WebCore/platform/image-decoders

Remove libjpeg and libpng from sources, as we need to use system-provided versions instead. These can be removed from TOT as well once the GDK port has moved over.

6:36 PM Changeset in webkit [23647] by thatcher
  • 2 edits in tags/WebCore-419.1.1/WebCore

Correct versioning.

6:34 PM Changeset in webkit [23646] by thatcher
  • 2 edits in tags/WebKit-419.1.1/WebKit

Correct versioning.

6:33 PM Changeset in webkit [23645] by thatcher
  • 1 move in tags/WebKit-419.1.1

Move this tag.

6:33 PM Changeset in webkit [23644] by thatcher
  • 1 move in tags/WebCore-419.1.1

Move this tag.

6:31 PM Changeset in webkit [23643] by thatcher
  • 4 edits in branches/Safari-2.0-dashboard

Correct versioning.

6:08 PM Changeset in webkit [23642] by thatcher
  • 1 copy in tags/WebCore-4522.11/WebCore

New tag (part 2.)

6:08 PM Changeset in webkit [23641] by thatcher
  • 1 copy in tags/WebKit-4522.11/WebKit

New tag (part 2.)

6:07 PM Changeset in webkit [23640] by thatcher
  • 1 add in tags/WebKit-4522.11

New tag (part 1.)

6:04 PM Changeset in webkit [23639] by thatcher
  • 1 add in tags/WebCore-4522.11

New tag (part 1.)

6:01 PM Changeset in webkit [23638] by thatcher
  • 1 copy in tags/WebCore-315.14.7/WebCore

New tag (part 2.)

6:01 PM Changeset in webkit [23637] by thatcher
  • 1 add in tags/WebCore-315.14.7

New tag (part 1.)

6:00 PM Changeset in webkit [23636] by thatcher
  • 1 copy in tags/WebCore-418.22.1-system/WebCore

New tag (part 2.)

5:59 PM Changeset in webkit [23635] by thatcher
  • 1 copy in tags/WebKit-419.2.1-system/WebKit

New tag (part 2.)

5:59 PM Changeset in webkit [23634] by thatcher
  • 1 add in tags/WebKit-419.2.1-system

New tag (part 1.)

5:58 PM Changeset in webkit [23633] by thatcher
  • 1 add in tags/WebCore-418.22.1-system

New tag (part 1.)

5:57 PM Changeset in webkit [23632] by thatcher
  • 1 copy in tags/WebKit-419.2.1/WebKit

New tag (part 2.)

5:57 PM Changeset in webkit [23631] by thatcher
  • 1 copy in tags/WebCore-418.22.1/WebCore

New tag (part 2.)

5:56 PM Changeset in webkit [23630] by thatcher
  • 1 add in tags/WebCore-418.22.1

New tag (part 1.)

5:56 PM Changeset in webkit [23629] by thatcher
  • 1 add in tags/WebKit-419.2.1

New tag (part 1.)

5:27 PM Changeset in webkit [23628] by thatcher
  • 6 edits in branches/Safari-522

Merge r23627.

5:23 PM Changeset in webkit [23627] by andersca
  • 7 edits in trunk

WebCore:

Reviewed by Kevin Decker.

<rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed


Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::deferMainResourceDataLoad):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::handleDataLoadSoon): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::setDefersLoading):

WebKit:

Reviewed by Kevin Decker.

<rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed

  • WebView/WebDocumentLoaderMac.mm: (needsAppKitWorkaround): New function which checks if the frame load delegate belongs to AppKit.


(WebDocumentLoaderMac::setDataSource):
If the frame load delegate belongs to AppKit, set m_deferMainResourceDataLoad to false.

5:00 PM Changeset in webkit [23626] by andrew
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.


Support applications with spaces or special characters in their names

  • Scripts/run-webkit-app:
4:37 PM Changeset in webkit [23625] by sfalken
  • 1 copy in tags/Safari-522.12.3b

New tag.

4:37 PM Changeset in webkit [23624] by thatcher
  • 1 move in branches/Safari-2.0-dashboard

Rename this branch to be clear what it is for now.

4:22 PM Changeset in webkit [23623] by hyatt
  • 2 edits in trunk/WebKit/win

Add support to Windows for Backspace back/forward navigation and for Ctrl+arrow key back/forward navigation.

3:59 PM Changeset in webkit [23622] by thatcher
  • 2 edits in branches/Safari-522

Versioning

3:40 PM Changeset in webkit [23621] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

3:37 PM Changeset in webkit [23620] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merge r23602 and r23607.

3:37 PM Changeset in webkit [23619] by zimmermann
  • 30 edits in branches/feature-branch/LayoutTests

Not reviewed.
Forgot to commit new layout tests results, now that <foreignObject> is enabled again.

3:29 PM Changeset in webkit [23618] by zimmermann
  • 11 edits
    20 adds in branches/feature-branch

Reviewed by Eric & Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14198

Reeanble <foreignObject>. Explicitely disallow <use> on <foreignObject>
as it may lead to bad problems.

While I'm at it disallow <use> on any non-svg element.

3:24 PM Changeset in webkit [23617] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merge r23580.

3:21 PM Changeset in webkit [23616] by ggaren
  • 5 edits in trunk/LayoutTests

Reviewed by Sam Weinig.


Fixed up these tests because they broke the bot.


  • Removed reliance on suppressConsoleMessages because I never checked that in and I decided it would just be a headache on other platforms.
  • Removed call to frames[0].stop() because it was nonsense.
  • Added console messages to results.
  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-first-time-expected.txt:
  • http/tests/security/cross-frame-access-first-time.html:
  • http/tests/security/cross-frame-access.html:
3:21 PM Changeset in webkit [23615] by thatcher
  • 2 edits in branches/Safari-2.0-system/WebKit

Versioning

3:20 PM Changeset in webkit [23614] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

3:18 PM Changeset in webkit [23613] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:17 PM Changeset in webkit [23612] by thatcher
  • 2 edits in branches/Safari-2.0-system/WebCore

Versioning

3:12 PM Changeset in webkit [23611] by thatcher
  • 10 edits in branches/Safari-2.0-system

Revert changes for Dashboard that are not part of the system frameworks.

2:59 PM Changeset in webkit [23610] by thatcher
  • 1 move in branches/Safari-2.0-system

Rename

2:53 PM Changeset in webkit [23609] by thatcher
  • 1 copy in branches/Safari-2.0-update

New branch.

2:18 PM Changeset in webkit [23608] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text

  • editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endPositionForLine): (WebCore::endOfLine): Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid. An example would be when lineStart/lineEnd at different line than the input position. This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, specifically a line without webkit-line-break:after-white-space style.
2:14 PM Changeset in webkit [23607] by kmccullo
  • 4 edits in branches/Safari-2-0-branch/WebCore

Reviewed by.

  • Fixing my own merging mistake.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • khtml/rendering/render_frames.h: (khtml::RenderFrame::isFrame):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isFrame):
2:10 PM Changeset in webkit [23606] by sfalken
  • 5 edits
    5 copies in branches/Safari-522-2

Merged fix from r32599.

2:00 PM Changeset in webkit [23605] by weinig
  • 5 edits
    5 adds in branches/Safari-522

LayoutTests:

Merged r23599 from TOT.


Reviewed by Darin Adler.

Tests for cross-frame access. <rdar://problem/5251309>.

  • http/tests/security/cross-frame-access-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time.html: Added.
  • http/tests/security/cross-frame-access.html: Added.
  • http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

Merged r23599 from TOT.

Reviewed by Darin Adler.

Fixed cross-frame access. <rdar://problem/5251309>.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
1:54 PM Changeset in webkit [23604] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]): Improve the accuracy of the bounds for a given range
1:45 PM Changeset in webkit [23603] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5130630>
XPath fails LayoutTests on Windows


  • xml/XPathPredicate.cpp: Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.


  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNumber): Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
1:34 PM Changeset in webkit [23602] by kmccullo
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tristan and Anders.

  • Changed location of isChildAllowed to avoid breaking rendering.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::isChildAllowed):
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_object.h:
1:28 PM Changeset in webkit [23601] by weinig
  • 1 edit in branches/Safari-522/WebCore/WebCore.exp

Build Fix

1:16 PM Changeset in webkit [23600] by sfalken
  • 4 edits in branches/Safari-522-2

Undo r23598.

12:28 PM Changeset in webkit [23599] by ggaren
  • 5 edits
    5 adds in trunk

LayoutTests:

Reviewed by Darin Adler.

Tests for cross-frame access. <rdar://problem/5251309>.

  • http/tests/security/cross-frame-access-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time-expected.txt: Added.
  • http/tests/security/cross-frame-access-first-time.html: Added.
  • http/tests/security/cross-frame-access.html: Added.
  • http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

Reviewed by Darin Adler.

Fixed cross-frame access. <rdar://problem/5251309>.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
11:52 AM Changeset in webkit [23598] by sfalken
  • 4 edits in branches/Safari-522-2

Merged fix from r23577.

11:24 AM Changeset in webkit [23597] by sfalken
  • 3 edits
    2 copies in branches/Safari-522-2

Merged fix from r21981.

11:18 AM Changeset in webkit [23596] by sfalken
  • 6 edits in branches/Safari-522-2

Merged fix from r21797.

11:18 AM Changeset in webkit [23595] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • platform/win/PopupMenuWin.cpp:
11:14 AM Changeset in webkit [23594] by sfalken
  • 4 edits
    4 copies in branches/Safari-522-2

Merged fix from r21602.

11:10 AM Changeset in webkit [23593] by thatcher
  • 3 edits
    2 copies in branches/Safari-522

Merge r21981.

11:08 AM Changeset in webkit [23592] by sfalken
  • 1 edit in branches/Safari-522-2/WebCore/ChangeLog

Merged fix from r20855.

10:54 AM Changeset in webkit [23591] by thatcher
  • 5 edits in branches/Safari-522/WebCore

Merge r21797.

10:41 AM Drosera edited by pewtermoose@gmail.com
Tweak the instructions for enabling Drosera; remove the Windows info … (diff)
10:38 AM Changeset in webkit [23590] by thatcher
  • 2 edits in branches/Safari-522/WebKit

Merge r23578.

10:17 AM Changeset in webkit [23589] by andersca
  • 5 edits in branches/Safari-2-0-branch/WebCore

Revert 23587.

10:13 AM Changeset in webkit [23588] by staikos
  • 2 edits in trunk/WebKitQt

Add https support

9:49 AM Changeset in webkit [23587] by kmccullo
  • 5 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tristan.

  • Merged security fix for <rdar://problem/5277156> Tiger: Memory corruption in Apple Safari: WebKit (Rhys #2)
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • khtml/rendering/render_frames.h: (khtml::RenderFrame::isFrame):
  • khtml/rendering/render_object.cpp: (RenderObject::isChildAllowed):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isFrame):
9:07 AM Changeset in webkit [23586] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • fixed <rdar://problem/5272011> Hole for find-on-page match in subframe isn't clipped by frame bounds
  • WebView/WebView.mm: (-[WebView rectsForTextMatches]): intersect the HTMLView's computed rect with the visible rect for that view
3:13 AM Changeset in webkit [23585] by lars
  • 2 edits in trunk/WebCore

Implement these methods correctly.

1:00 AM Changeset in webkit [23584] by weinig
  • 14 edits
    3 moves
    3 adds in trunk/WebCore

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14226
Move the History object out of the JS bindings

  • Autogenerate JSHistory.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
  • bridge/History.h: Removed.
  • bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
  • bridge/mac/HistoryMac.mm: Removed.
  • bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
  • bridge/win/HistoryWin.cpp: Removed.
  • css/cssstyleselector.cpp:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::history):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/History.cpp: Added. (WebCore::History::History): (WebCore::History::frame): (WebCore::History::disconnectFrame): (WebCore::History::length): (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
  • page/History.h: Added.
  • page/History.idl: Added.
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
12:37 AM Changeset in webkit [23583] by rwlbuis
  • 9 edits
    4 adds in branches/feature-branch

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=14144
All tx/ty (parentX/parentY) usage should be removed from SVG renders
​http://bugs.webkit.org/show_bug.cgi?id=13981
<br> prevents click handler from firing

Fix the hit testing issues by making RenderSVGRoot take its m_x, m_y
into account in the absolute transform.

Jun 18, 2007:

9:56 PM Changeset in webkit [23582] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker


  • Carbon/HIWebView.m: (WindowHandler): HIObjectIsOfClass requires non-NULL input on Tiger. Reworked Kevin Decker's patch to remove the conditional compilation for Tiger, yet still avoid crashing BBEdit.
7:12 PM Changeset in webkit [23581] by weinig
  • 2 edits in trunk/WebCore

Qt build fix.

  • platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
7:05 PM Changeset in webkit [23580] by andersca
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Kevin McCullough.

Merged fix from TOT to Safari-2-0-branch


2007-06-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter

Check method names, header names and header values and throw exceptions if any of them are
invalid. This is what the new XMLHttpRequest spec states that we should do.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::isValidToken): (KJS::isValidHeaderValue): (KJS::XMLHttpRequestProtoFunc::tryCall):
7:03 PM Changeset in webkit [23579] by weinig
  • 10 edits in trunk

WebCore:

Reviewed by Beth.

Fix build and update licenses.

  • WebCore.xcodeproj/project.pbxproj:
  • page/BarInfo.cpp:
  • page/BarInfo.h:
  • page/BarInfo.idl:
  • page/Screen.cpp: (WebCore::Screen::height): (WebCore::Screen::width): (WebCore::Screen::colorDepth): (WebCore::Screen::pixelDepth): (WebCore::Screen::availLeft): (WebCore::Screen::availTop): (WebCore::Screen::availHeight): (WebCore::Screen::availWidth):
  • page/Screen.h:
  • page/Screen.idl:

WebKit:

Reviewed by Beth.

Build fix.

  • WebCoreSupport/WebChromeClient.mm:
6:30 PM Changeset in webkit [23578] by kdecker
  • 2 edits in trunk/WebKit

2007-06-18 Kevin Decker <​kdecker@apple.com>

  • Carbon/HIWebView.m: (WindowHandler): Fixed the Tiger build; ControlKind wasn't defined.
6:14 PM Changeset in webkit [23577] by andersca
  • 6 edits in trunk

LayoutTests:

Reviewed by John Sullivan.

Update result, we shouldn't call didFinishLoadForFrame if the URL isn't valid.


  • http/tests/loading/bad-scheme-subframe-expected.txt:

WebCore:

Reviewed by John Sullivan.

<rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]


Don't send any frame load callbacks if the document load hasn't been
committed for real.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

WebKitTools:

Reviewed by John Sullivan.

Assert that the frame has a dataSource.


  • DumpRenderTree/FrameLoadDelegate.m: (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
5:08 PM Changeset in webkit [23576] by weinig
  • 18 edits
    4 moves
    4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Updates tests for ​http://bugs.webkit.org/show_bug.cgi?id=14193
Move the Screen object out of the JS bindings

  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14193
Move the Screen object out of the JS bindings

  • Renames Screen.h to PlatformScreen.h to accommodate new class.
  • Autogenerates JSScreen.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • css/MediaQueryEvaluator.cpp:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::~DOMWindow): (WebCore::DOMWindow::frame): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::screen):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Screen.cpp: Added. (WebCore::Screen::Screen): (WebCore::Screen::disconnectFrame): (WebCore::Screen::height): (WebCore::Screen::width): (WebCore::Screen::colorDepth): (WebCore::Screen::pixelDepth): (WebCore::Screen::availLeft): (WebCore::Screen::availTop): (WebCore::Screen::availHeight): (WebCore::Screen::availWidth):
  • page/Screen.h: Added.
  • page/Screen.idl: Added.
  • page/mac/WebCoreFrameBridge.mm:
  • platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
  • platform/Screen.h: Removed.
  • platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
  • platform/gdk/ScreenGdk.cpp: Removed.
  • platform/mac/PlatformMouseEventMac.mm:
  • platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
  • platform/mac/ScreenMac.mm: Removed.
  • platform/qt/PlatformScreenQt.cpp: Added. (WebCore::WebCore::screenDepth): (WebCore::WebCore::screenDepthPerComponent): (WebCore::WebCore::screenIsMonochrome): (WebCore::WebCore::screenRect): (WebCore::WebCore::screenAvailableRect):
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
  • platform/win/ScreenWin.cpp: Removed.
  • rendering/RenderObject.cpp:
5:06 PM Changeset in webkit [23575] by thatcher
  • 2 edits in branches/Safari-522/WebKit

Merge r23574.

5:01 PM Changeset in webkit [23574] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Fixed: <rdar://problem/5276135> With Safari 3 Tiger Beta installed, a crash occurs in BBEdit while mousing down and dragging outside of HTML preview window

  • Carbon/HIWebView.m: (WindowHandler): Because the fix for 5051616 causes Tiger to crash in HIToolbox (but not on Leopard), I reverted back to using GetControlKind on Tiger only, instead of HIObjectIsOfClass.
4:04 PM Changeset in webkit [23573] by weinig
  • 10 edits
    3 adds in trunk/WebCore

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14211
Move the BarInfo object out of the JS bindings

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/BarInfo.cpp: Added. (WebCore::BarInfo::BarInfo): (WebCore::BarInfo::disconnectFrame): (WebCore::BarInfo::visible):
  • page/BarInfo.h: Added. (WebCore::BarInfo::):
  • page/BarInfo.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::~DOMWindow): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::locationbar): (WebCore::DOMWindow::menubar): (WebCore::DOMWindow::personalbar): (WebCore::DOMWindow::scrollbars): (WebCore::DOMWindow::statusbar): (WebCore::DOMWindow::toolbar):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
3:52 PM Changeset in webkit [23572] by thatcher
  • 4 edits
    4 copies in branches/Safari-522

Merge r21602.

3:45 PM Changeset in webkit [23571] by thatcher
  • 5 edits in branches/Safari-522

Merge r21529.

3:04 PM Changeset in webkit [23570] by staikos
  • 2 edits in trunk/WebKitTools

Reflect the library name change for WebKitQt in the perl scripts. Patch from
Adam Treat

1:11 PM Changeset in webkit [23569] by hyatt
  • 2 edits in trunk/WebKit/win

Groundwork for Ctrl+Enter URL bar support.

10:27 AM Changeset in webkit [23568] by andersca
  • 7 edits in branches/Safari-522

Merge 21104, 21254 and 21776.

10:15 AM Changeset in webkit [23567] by weinig
  • 10 edits in trunk

LayoutTests:

Reviewed by Darin.

Update tests now that window.frames points to window and not FrameArray
(which has been removed).

  • fast/dom/Window/resources/window-appendages-cleared-results.html:
  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-appendages-cleared.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/toString-and-valueOf-override-expected.txt:
  • fast/js/toString-and-valueOf-override.html:

WebCore:

Reviewed by Darin.

Remove the FrameArray class and instead make window.frames another
self-reference for window (like window.window, window.self, etc).
This is what Firefox and what the HTML5 dictates.

  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h:
9:58 AM Changeset in webkit [23566] by bdash
  • 3 edits in trunk/WebKitTools

2007-06-18 Jake Helfert <​jake@jakeonthenet.com>

Reviewed by Adam.

  • Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):

-Changed IWebViewExt to IWebViewPrivate
-Changed Co[Un]initialize to Ole[Un]initialize because WebKit now calls

the WIN32 function RegisterDragDrop which requires the Ole* calls.

  • Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::didReceiveIcon): Updated method signature. (SpinneretWebHost::willPerformClientRedirectToURL): Updated method signature. (SpinneretWebHost::windowScriptObjectAvailable): Updated method signature.
9:55 AM Changeset in webkit [23565] by bdash
  • 3 edits
    2 adds in trunk

2007-06-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

Test: fast/forms/input-zero-height-focus.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange): Avoid setting the selection in a zero-height text control.

2007-06-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

  • fast/forms/input-zero-height-focus-expected.txt: Added.
  • fast/forms/input-zero-height-focus.html: Added.
9:49 AM Changeset in webkit [23564] by bdash
  • 3 edits
    1 add in trunk/WebCore

2007-06-18 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=14052
Implement SoundGdk

  • WebCore.pro:
  • platform/gdk/SoundGdk.cpp: Added. (WebCore::systemBeep):
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::systemBeep):
12:16 AM Changeset in webkit [23563] by hyatt
  • 3 edits in trunk/WebKit/win

Add support for horizontal mouse wheeling (WebKit part).

12:14 AM Changeset in webkit [23562] by hyatt
  • 3 edits in trunk/WebCore

Add support for horizontal mouse wheeling (WebCore part).

Jun 17, 2007:

11:40 PM Changeset in webkit [23561] by hyatt
  • 2 edits in trunk/WebKit/win

Add support for Ctrl+Mouse Wheel to do text zooming on Win32.

1:20 PM Changeset in webkit [23560] by weinig
  • 2 edits in trunk/WebCore

Win32 build fix.

  • WebCore.vcproj/WebCore.vcproj:

Jun 16, 2007:

10:51 PM Changeset in webkit [23559] by hyatt
  • 4 edits in trunk/WebKit

Back out fix for 13972. Quicktime will no longer clip correctly. :(
Too many regressions in Mail caused by inserting an extra view into the
hierarchy. Can revisit later.

Reviewed by olliej

  • Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView addSubview:]): (-[WebHTMLView willRemoveSubview:]):

Jun 15, 2007:

8:14 PM Changeset in webkit [23558] by hyatt
  • 4 edits in trunk/WebCore

Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
because of a botched 'round' support removal. Also update for a change in
the spec that has the second stretch/round/repeat keyword match the first
if omitted.


Reviewed by olliej

  • css/cssparser.cpp: (WebCore::BorderImageParseContext::commitBorderImage):
  • platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
  • platform/graphics/Image.h: (WebCore::Image::):
6:47 PM Changeset in webkit [23557] by weinig
  • 22 edits
    1 move in trunk

LayoutTests:

Reviewed by Darin.

Update test for ​http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

  • Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList and DOMRGBColor to JSRGBColor
  • Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp: (WebCore::): (WebCore::JSStyleSheetList::JSStyleSheetList): (WebCore::JSStyleSheetList::~JSStyleSheetList): (WebCore::JSStyleSheetList::getValueProperty): (WebCore::JSStyleSheetList::indexGetter): (WebCore::JSStyleSheetList::nameGetter): (WebCore::JSStyleSheetList::getOwnPropertySlot): (WebCore::toJS): (WebCore::JSStyleSheetListFunc::callAsFunction): (WebCore::JSRGBColor::JSRGBColor): (WebCore::JSRGBColor::~JSRGBColor): (WebCore::JSRGBColor::getOwnPropertySlot): (WebCore::JSRGBColor::getValueProperty): (WebCore::getJSRGBColor):
  • bindings/js/kjs_css.h: (WebCore::JSStyleSheetList::classInfo): (WebCore::JSStyleSheetList::): (WebCore::JSStyleSheetList::impl): (WebCore::JSRGBColor::classInfo): (WebCore::JSRGBColor::): (WebCore::JSRGBColor::impl):
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::CSSBorderImageValue):
  • css/CSSBorderImageValue.h:
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::):
  • css/DashboardRegion.h:
  • css/Rect.h: Copied from css/RectImpl.h. (WebCore::Rect::~Rect): (WebCore::Rect::top): (WebCore::Rect::right): (WebCore::Rect::bottom): (WebCore::Rect::left): (WebCore::Rect::setTop): (WebCore::Rect::setRight): (WebCore::Rect::setBottom): (WebCore::Rect::setLeft):
  • css/Rect.idl:
  • css/RectImpl.h: Removed.
  • css/cssparser.cpp: (WebCore::CSSParser::parseShape): (WebCore::BorderImageParseContext::commitBorderImage):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/DOMWindow.idl:

WebKit:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

  • Fix conflicts by using ::Rect instead of Rect.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView tellQuickTimeToChill]): (-[WebBaseNetscapePluginView invalidateRegion:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]):
5:53 PM Changeset in webkit [23556] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKitTools/Scripts/build-wxwebkit

Allow users to specify whether they're using a debug or wxPython build of wx.

5:29 PM Changeset in webkit [23555] by kevino
  • 5 edits in branches/wx-port-alpha/trunk

Fix for cases where the wxpresets don't define WX_PYTHON, and only have the webcore and jscore templates include flags. (these are not linked to directly by wx clients)

4:21 PM Changeset in webkit [23554] by zimmermann
  • 19 edits
    9 adds in branches/feature-branch

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14015 (SVGTransformList::initialize() has no effect)

Fix SVGTransformList usage in SVG DOM exposed to JS.
This also fixes SVG space invaders including most repainting issues. (still some unrelated ones left)

This is basically the _same_ fix applied to SVGPointList some months ago. We just forgot
to add JSSVGTransformListCustom when switching from SVGTransform* -> SVGTransform (POD type).

3:07 PM Changeset in webkit [23553] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Kevin.

A better fix for <rdar://problem/5271774>. Only try to access the element if the
view has an associated window. This also works with GC. (Fix suggested by Kevin.)

  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):
2:17 PM Changeset in webkit [23552] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/5271774> REGRESSION: A crash occurs when closing a window that contains a QT movie


In some cases, calling [super dealloc] might end up calling visibleRect, so make sure to
set _element to 0 so we won't send a message to a freed object and crash.


  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):
12:21 PM Changeset in webkit [23551] by zimmermann
  • 4 edits
    4 adds in branches/feature-branch

Reviewed by Eric.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14155

JSSVGMatrix was not working properly.
"matrix.translate(10, 10)" actually altered 'matrix' instead of returning a
new SVGMatrix object, as described in SVG 1.1 specification.

10:32 AM Changeset in webkit [23550] by spadma
  • 2 edits in S60/trunk/WebKit

vbradley, reviewed by Sachin

DESC: EYLG-6ZVCLT - Chinese candidate and autofill boxes overlap
​http://bugs.webkit.org/show_bug.cgi?id=13925

  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::FormDataManagerHandlerL):
10:27 AM Changeset in webkit [23549] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-06-14 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: Plug-in request for execution of JavaScript through NpnGetUrl API not working
​http://waplabdc.nokia-boston.com/browser/users/MaheshKK/geturl.html

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): Do not resolve URL when "javascript:" is in the URL


10:25 AM Changeset in webkit [23548] by spadma
  • 2 edits in S60/trunk/WebKit

007-06-14 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: Plug-in request for execution of JavaScript through NpnGetUrl API not working
​http://waplabdc.nokia-boston.com/browser/users/MaheshKK/geturl.html

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): Do not resolve URL when "javascript:" is in the URL
9:54 AM Changeset in webkit [23547] by eseidel
  • 2 edits in branches/feature-branch/WebCore

2007-06-15 Eric Seidel <​eric@webkit.org>

Reviewed by Niko.

Fix the release build.

  • rendering/SVGRootInlineBox.cpp: (WebCore::applyTextAnchorToTextChunk):

Jun 14, 2007:

7:51 PM Changeset in webkit [23546] by staikos
  • 3 edits in trunk/WebKitQt

Add evaluateJavaScript() method

7:31 PM Changeset in webkit [23545] by staikos
  • 7 edits in trunk

Add quite a bit of keyboard handling in editing and non-editing mode for
QtWebKit, as well as some focus fixes.

6:41 PM Changeset in webkit [23544] by rwlbuis
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=14051
<svg:image> fails to position correctly when <svg> is inside an inline <div>

Leave parent translation to the containers.

5:02 PM Changeset in webkit [23543] by zimmermann
  • 5 edits in branches/feature-branch/WebCore

Reviewed by Eric.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=13963

Fix SVG space invaders. It actually highlighted a bad problem with our JSSVGPODTypeWrapper's.
Introduce a new "2nd-level cache" for all readwrite POD properties. Subsequent calls to ie.
myRect.x.baseVal.value don't create a new wrapper everytime, but are properly cached now.
This leads to a massive reduction in created wrappers.

4:50 PM Changeset in webkit [23542] by thatcher
  • 12 edits
    4 copies in branches/Safari-522

Merge r21212.

4:39 PM Changeset in webkit [23541] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge r20855.

3:15 PM Changeset in webkit [23540] by andersca
  • 2 edits in trunk/JavaScriptCore

Fix Windows build.


  • bindings/runtime_object.cpp: (RuntimeObjectImp::canPut):
2:58 PM Changeset in webkit [23539] by hyatt
  • 3 edits in trunk/WebCore

Fix for missing text in non-English Windows installs.

2:43 PM Changeset in webkit [23538] by andersca
  • 14 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Darin.

<rdar://problem/5103077>
Crash at _NPN_ReleaseObject when quitting page at ​http://eshop.macsales.com/shop/ModBook


<rdar://problem/5183692>
​http://bugs.webkit.org/show_bug.cgi?id=13547
REGRESSION: Crash in _NPN_ReleaseObject when closing Safari on nba.com (13547)


<rdar://problem/5261499>
CrashTracer: [USER] 75 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::CInstance::~CInstance + 40


Have the root object track all live instances of RuntimeObjectImp. When invalidating
the root object, also invalidate all live runtime objects by zeroing out their instance ivar.
This prevents instances from outliving their plug-ins which lead to crashes.


  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject):
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
  • bindings/runtime_array.cpp: (RuntimeArray::RuntimeArray):
  • bindings/runtime_array.h: (KJS::RuntimeArray::getConcreteArray):
  • bindings/runtime_method.cpp: (RuntimeMethod::callAsFunction):
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::~RuntimeObjectImp): (RuntimeObjectImp::invalidate): (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::implementsCall): (RuntimeObjectImp::callAsFunction): (RuntimeObjectImp::getPropertyNames): (RuntimeObjectImp::throwInvalidAccessError):
  • bindings/runtime_object.h:
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::invalidate): (KJS::Bindings::RootObject::addRuntimeObject): (KJS::Bindings::RootObject::removeRuntimeObject):
  • bindings/runtime_root.h:

LayoutTests:

Reviewed by Darin.

Add test that manipulates plug-in script objects after the plug-in has been destroyed.


  • plugins/netscape-destroy-plugin-script-objects-expected.txt: Added.
  • plugins/netscape-destroy-plugin-script-objects.html: Added.
2:42 PM Changeset in webkit [23537] by weinig
  • 3 edits in trunk/WebKitTools

Reviewed by Brady.

Update set of files to download for cygwin to include
diffutils and regenerate the zip file. This should fix
an issue on vista where svn-create-patch doesn't work.

  • CygwinDownloader/cygwin-downloader.py:
  • CygwinDownloader/cygwin-downloader.zip:
2:08 PM Changeset in webkit [23536] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
for a given plug-in.

  • WebCore.exp:
  • page/Frame.cpp: (WebCore::Frame::cleanupScriptObjectsForPlugin):
  • page/Frame.h:
2:06 PM Changeset in webkit [23535] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

Call cleanupScriptObjectsForPlugin on the frame after destroying the plug-in.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView _destroyPlugin]):
  • Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]):
1:02 PM Changeset in webkit [23534] by kdecker
  • 2 edits in branches/Safari-2-0-branch/WebKit

Reviewed by John and Darin and Anders!

Fixed: <rdar://problem/5269008> REGRESSION (Safari 3 Beta 1): Package Tracker widget fails (can't find localized strings due to bundle ID)

  • Misc.subproj/WebLocalizableStrings.m: The problem was that WebLocalizableStrings.m has the system WebKit bundle identifier, not WebKitForDashboard's bundle identifier. The code therefore couldn't find the localizable string "Recent searches", thus returned a nil string and therefore triggered an assertion failure in NSMenuItem. I fixed this by changing the bundle constant to "com.apple.WebKitForDashboard".
12:22 PM Changeset in webkit [23533] by eseidel
  • 4 edits in branches/feature-branch/WebCore

2007-06-14 Eric Seidel <​eric@webkit.org>

Reviewed by Niko.

Text gradients are broken on feature branch
​http://bugs.webkit.org/show_bug.cgi?id=14142

  • rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent):
  • rendering/SVGRootInlineBox.cpp: (WebCore::prepareTextRendering): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::paintInlineBoxes): (WebCore::SVGRootInlineBox::paintChildInlineTextBox): (WebCore::SVGRootInlineBox::paintChildInlineFlowBox):
  • rendering/SVGRootInlineBox.h:
12:16 PM Changeset in webkit [23532] by zimmermann
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Sam.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11273

Implement pixelUnitToMillimeterX(), pixelUnitToMillimeterY() in SVGSVGElement.
Use cssPixelsPerInch, just like done in CSSPrimitiveValue & SVGLength.

11:43 AM Applications using WebKit edited by ruben@mailplaneapp.com
Added Mailplane (diff)
11:33 AM Changeset in webkit [23531] by bdash
  • 2 edits in trunk/WebKitTools

2007-06-14 Mark Rowe <​mrowe@apple.com>

Update script to match new nightly.webkit.org infrastructure.

  • BuildSlaveSupport/build-launcher-dmg: Upload to the live web server, not the caching proxy. Let the server know it's a Mac build.
10:50 AM Changeset in webkit [23530] by rwlbuis
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=9752
%-sizing of elements with a html parent is broken

Calculate width/height for length percentages when embedded in xhtml.

10:21 AM Changeset in webkit [23529] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.


  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
10:13 AM Changeset in webkit [23528] by staikos
  • 8 edits in trunk

Implement the javascript dialogs and file chooser dialog, along with some
cleanups.

9:47 AM Changeset in webkit [23527] by staikos
  • 2 edits in trunk/WebCore

Add missing null-init of pointer (will fix an upcoming crash)

9:13 AM Changeset in webkit [23526] by andersca
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Mitz.

<rdar://problem/5244948>
Safari keeps on complaining about slow script playing NBC TV video (14133)

​http://bugs.webkit.org/show_bug.cgi?id=14133
Runaway JavaScript timer fires when spinning around in Google Maps street view

Make sure to start and stop the timeout checker around calls to JS.


  • bindings/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate):
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::call): (JavaJSObject::eval):

WebCore:

Reviewed by Mitz.

<rdar://problem/5244948>
Safari keeps on complaining about slow script playing NBC TV video (14133)

​http://bugs.webkit.org/show_bug.cgi?id=14133
Runaway JavaScript timer fires when spinning around in Google Maps street view

Make sure to start and stop the timeout checker around calls to JS.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
4:41 AM Changeset in webkit [23525] by hausmann
  • 2 edits in trunk/WebKitQt

Removed QWebHistoryItem::parent() as it is not implemented and WebCore's

HistoryItem itself doesn't seem to have a parent pointer either.

4:40 AM Changeset in webkit [23524] by hausmann
  • 3 edits in trunk/WebKitQt

Make it possible to copy QWebHistoryItem objects.

Jun 13, 2007:

11:59 PM Changeset in webkit [23523] by staikos
  • 3 edits
    2 adds in trunk

Fix mod-by-zero crash when typeahead is triggered on an empty select.

11:55 PM Changeset in webkit [23522] by rwlbuis
  • 2 edits in branches/feature-branch/WebCore

Build fix.

9:58 PM Changeset in webkit [23521] by darin
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

Test: fast/js/sort-large-array.html

  • kjs/array_instance.h: Replaced pushUndefinedObjectsToEnd with compactForSorting, and removed ExecState parameters.
  • kjs/array_object.cpp: (ArrayInstance::sort): Changed to call compactForSorting. (ArrayInstance::compactForSorting): Do the get and delete of the properties directly on the property map instead of using public calls from JSObject. The public calls would just read the undefined values from the compacted sort results array!

LayoutTests:

Reviewed by Mark Rowe.

  • fast/js/resources/sort-large-array.js: Added.
  • fast/js/sort-large-array-expected.txt: Added.
  • fast/js/sort-large-array.html: Added.
9:25 PM Changeset in webkit [23520] by lars
  • 2 edits in trunk/WebKitQt

Fix a crash when a request from the plugin resulted
in a HTTP redirect.

8:28 PM Changeset in webkit [23519] by lars
  • 2 edits in trunk/WebKitQt

Work around a bug in Qt's QHttp implementation and
get web pages to load again.

7:48 PM Changeset in webkit [23518] by staikos
  • 2 edits in trunk/JavaScriptCore

Fix Mac OS X build

7:32 PM Changeset in webkit [23517] by staikos
  • 1 edit in trunk/WebCore/WebCore.pro

missed this in my last checkin - obsolete line

7:24 PM Changeset in webkit [23516] by staikos
  • 4 edits in trunk

Compile without trying to link ourself.

7:23 PM Changeset in webkit [23515] by lars
  • 4 edits in trunk/JavaScriptCore

Disable FastMalloc for the Qt build and make sure we
don't reimplement the global new/delete operators
when using the system malloc.

6:11 PM Changeset in webkit [23514] by darin
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker.

  • fix <rdar://problem/5264923> Safari frequently "stalls" beneath +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
  • platform/mac/WebFontCache.mm: (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily. Took out the auto-activation code. (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily, then calls NSFont to trigger activation if that returned nil, then calls internalFontWithFamily again.
5:55 PM Changeset in webkit [23513] by sfalken
  • 1 copy in tags/Safari-522.12.1b

New tag.

5:10 PM Changeset in webkit [23512] by andersca
  • 17 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

Make sure that bindings instances get correct root objects.


  • JavaScriptCore.exp:
  • bindings/NP_jsobject.cpp: (listFromVariantArgs): (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_SetProperty):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
  • bindings/c/c_runtime.cpp: (KJS::Bindings::CField::valueFromInstance):
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
  • bindings/c/c_utility.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcArray::valueAt):
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.h:

WebCore:

Reviewed by Geoff.

Pass the root object to methods that end up creating new ObjcInstance objects.


  • bindings/objc/WebScriptObject.mm: (listFromNSArray): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]):
4:44 PM Changeset in webkit [23511] by andersca
  • 2 edits in branches/Safari-522-2/WebCore

Merge r23510

4:31 PM Changeset in webkit [23510] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5267992>
Make sure an alert doesn't allow loading to continue inside a script.


Make sure to defer all loads where it's possible for a second main loop to be running.


  • page/Chrome.cpp: (WebCore::Chrome::runModal): (WebCore::Chrome::runBeforeUnloadConfirmPanel): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::setDefersLoading): Implement this.
4:14 PM Changeset in webkit [23509] by rwlbuis
  • 19 edits
    2 adds
    2 deletes in branches/feature-branch/WebCore

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12207
RenderSVGContainer should be split into multiple classes
​http://bugs.webkit.org/show_bug.cgi?id=14125
KCanvasRenderingStyle should be removed

Introduce the RenderSVGRoot class and kill the KCanvas enums.

3:26 PM Changeset in webkit [23508] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adele Peterson


  • fixed <rdar://problem/5267607> Clicking the "Save to Downloads" button in PDF overlay too soon results in corrupt file
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): Just beep if the document isn't available yet, since trying to save it as a file really isn't a good idea.
2:28 PM Nightly Builds edited by ordody@freeshell.org
(diff)
1:39 PM Changeset in webkit [23507] by bdash
  • 4 edits
    8 adds in trunk/WebCore

2007-06-13 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Rob.

​http://bugs.webkit.org/show_bug.cgi?id=14060
Cairo SVG support

  • WebCore.pro: Add new files to the build.
  • platform/graphics/svg/SVGPaintServerPattern.h:
  • platform/graphics/svg/SVGPaintServerSolid.h:
  • platform/graphics/svg/cairo: Added.
  • platform/graphics/svg/cairo/RenderPathCairo.cpp: Added. (WebCore::RenderPath::strokeContains): (WebCore::RenderPath::strokeBBox):
  • platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added. (WebCore::SVGPaintServer::draw): (WebCore::SVGPaintServer::teardown): (WebCore::SVGPaintServer::renderPath):
  • platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added. (WebCore::SVGPaintServerGradient::setup):
  • platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added. (WebCore::SVGPaintServerPattern::setup):
  • platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added. (WebCore::SVGPaintServerSolid::setup):
  • platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
1:30 PM Changeset in webkit [23506] by sfalken
  • 1 copy in tags/Safari-522.11.5b

New tag.

12:27 PM Changeset in webkit [23505] by sfalken
  • 2 edits in branches/Safari-522-2/WebCore

Merged fix from r20855.

11:45 AM Web Inspector edited by ordody@freeshell.org
(diff)
11:39 AM Drosera edited by ordody@freeshell.org
(diff)
11:27 AM BuildingOnWindows edited by ordody@freeshell.org
environment updates (diff)
8:25 AM BuildingOnWindows edited by thiago.correa@gmail.com
Missing pkg-config dependency (diff)
8:01 AM Changeset in webkit [23504] by hausmann
  • 4 edits in trunk

Fix the build: WebKitQt is now called QtWebKit

7:38 AM Changeset in webkit [23503] by hausmann
  • 3 edits
    2 adds in trunk

Added a make install target that installs the Qt port and renamed
WebKitQt to QtWebKit

7:25 AM Changeset in webkit [23502] by spadma
  • 2 edits in S60/trunk/WebKit

yaharon, reviewed by sachin

DESC: [S60] Fix a crash when tapping the page before it is loaded
​http://bugs.webkit.org/show_bug.cgi?id=13955

  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):
7:17 AM Changeset in webkit [23501] by spadma
  • 2 edits in S60/trunk/WebKit

spadma, reviewed by Zalan

DESC: Memory leak in BrowserNG, RArray needs to be closed
​http://bugs.webkit.org/show_bug.cgi?id=13952

TSW ID: AVAO-73NFEK

  • BrowserView/src/SmartLinkMap.cpp: (CSmartLinkMap::IndexingCallbackL):
6:05 AM Changeset in webkit [23500] by hausmann
  • 3 edits in trunk/WebKitQt

Added httpHeaderField setter/getter to QWebNetworkRequest for convenience.

6:05 AM Changeset in webkit [23499] by hausmann
  • 4 edits in trunk/WebKitQt

Changed QWebObjectPluginConnector::requestUrl to take a QWebNetworkRequest as argument.

6:05 AM Changeset in webkit [23498] by hausmann
  • 4 edits in trunk/WebKitQt

Added a QWebNetworkRequest convenience constructor.

6:04 AM Changeset in webkit [23497] by hausmann
  • 3 edits in trunk/WebKitQt

Changed the QWebPage::open(const QUrl &url, const QHttpRequestHeader &httpHeader, const QByteArray &postData)
overload to take a QWebNetworkRequest instead.

6:04 AM Changeset in webkit [23496] by hausmann
  • 2 edits in trunk/WebKitQt

In QWebPage::open(const QUrl &, const QHttpRequestHeader &, ...) don't make the population
of the WebCore::ResourceRequest depend on the validity of the QHttpRequestHeader but just
pick the individual fields if we can use them.

6:04 AM Changeset in webkit [23495] by hausmann
  • 3 edits in trunk/WebKitQt

Minor QWebNetworkRequet API fixlet

6:04 AM Changeset in webkit [23494] by hausmann
  • 7 edits in trunk/WebKitQt

Use QWebNetworkRequest for QWebPage::navigationRequested.

6:04 AM Changeset in webkit [23493] by hausmann
  • 2 edits in trunk/WebKitQt

Some docs for QWebNetworkRequest

6:03 AM Changeset in webkit [23492] by hausmann
  • 4 edits in trunk/WebKitQt

Moved QWebNetworkJob::Method enum into QWebNetworkRequest.

6:03 AM Changeset in webkit [23491] by hausmann
  • 3 edits in trunk/WebKitQt

Rename QWebNetworkJob::request() into QWebNetworkJob::httpHeader() and added

6:03 AM Changeset in webkit [23490] by hausmann
  • 5 edits in trunk/WebKitQt

Introduce QWebNetworkRequest in the public API.

6:03 AM Changeset in webkit [23489] by hausmann
  • 4 edits in trunk/WebKitQt

Changed QWebNetworkJobPrivate to aggregate a QWebNetworkRequest instead of inheriting from it.

6:03 AM Changeset in webkit [23488] by hausmann
  • 4 edits in trunk/WebKitQt

Rename QWebNetworkRequest::request into QWebNetworkRequest::httpHeader.

12:25 AM Changeset in webkit [23487] by aroben
  • 2 edits in trunk/WebCore

Fix one more BITMAPINFO/BITMAPINFOHEADER typo.

Rubberstamped by Oliver.

  • platform/win/DragImageWin.cpp: (WebCore::allocImage):

Jun 12, 2007:

11:56 PM Changeset in webkit [23486] by oliver
  • 5 edits in trunk

WebCore:

Reviewed by Darin.

Use correct size for BITMAPINFOHEADER -- whoops.

  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):

WebKit:

Reviewed by Darin.

Use correct size for BITMAPINFOHEADER -- whoops.

  • win/WebIconDatabase.cpp: (createDIB): (WebIconDatabase::getOrCreateDefaultIconBitmap):
11:53 PM Changeset in webkit [23485] by sfalken
  • 5 edits in branches/Safari-522-2

Merged fix from r21529.

11:20 PM Changeset in webkit [23484] by sfalken
  • 1 copy in branches/Safari-522-2

Branched Safari-522 from r21983.

9:57 PM Changeset in webkit [23483] by andersca
  • 2 edits in trunk/JavaScriptCore

Another build fix.


  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtInstance::invokeMethod):
9:52 PM Changeset in webkit [23482] by andersca
  • 8 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Move the notion of field type to the JNI runtime since that's the only
one that was actually using it.


  • bindings/c/c_runtime.h: (KJS::Bindings::CField::CField):
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm:
  • bindings/qt/qt_runtime.h:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp:
9:43 PM Changeset in webkit [23481] by andersca
  • 3 edits in trunk/JavaScriptCore

Build fix.


  • bindings/qt/qt_class.cpp: (KJS::Bindings::QtClass::methodsNamed):
  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtInstance::invokeMethod):
9:42 PM Changeset in webkit [23480] by staikos
  • 2 edits in trunk/WebKitQt

Fix from Lars to remove duplicate symbols.

9:25 PM Changeset in webkit [23479] by andersca
  • 12 edits in trunk/JavaScriptCore

Reviewed by Oliver.


Get rid of the MethodList class and use a good ol' Vector instead.

  • bindings/c/c_class.cpp: (KJS::Bindings::CClass::methodsNamed):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod):
  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed):
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
  • bindings/runtime.cpp:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter): (RuntimeMethod::callAsFunction):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::getOwnPropertySlot):
9:06 PM Changeset in webkit [23478] by andersca
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Make RuntimeMethod's method list a pointer so that the object size doesn't
grow beyond 32 bytes when we later will replace MethodList with a Vector.


  • bindings/runtime_method.cpp: (RuntimeMethod::RuntimeMethod): (RuntimeMethod::lengthGetter): (RuntimeMethod::callAsFunction):
  • bindings/runtime_method.h:
8:57 PM Changeset in webkit [23477] by andersca
  • 5 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Get rid of the Parameter class.


  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_runtime.cpp: (JavaMethod::signature):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaParameter::JavaParameter): (KJS::Bindings::JavaParameter::~JavaParameter): (KJS::Bindings::JavaParameter::type): (KJS::Bindings::JavaMethod::parameterAt): (KJS::Bindings::JavaMethod::numParameters):
  • bindings/runtime.h:
8:54 PM Changeset in webkit [23476] by andersca
  • 1 edit in trunk/JavaScriptCore/bindings/qt/qt_class.h
8:54 PM Changeset in webkit [23475] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Build fix.


  • bindings/qt/qt_class.h:
8:49 PM Changeset in webkit [23474] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-06-12 Mark Rowe <​mrowe@apple.com>

Build fix.

  • bindings/objc/objc_runtime.h:
8:43 PM Changeset in webkit [23473] by andersca
  • 8 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Get rid of Constructor and its only subclass JavaConstructor.


  • bindings/c/c_class.h:
  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_runtime.cpp:
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_class.h:
  • bindings/runtime.h:
8:24 PM Changeset in webkit [23472] by andersca
  • 8 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Use RetainPtr throughout the bindings code.


  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::ObjcClass): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
  • bindings/objc/objc_instance.h: (KJS::Bindings::ObjcInstance::getObject):
  • bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): (ObjcInstance::~ObjcInstance): (ObjcInstance::implementsCall): (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::defaultValue):
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcMethod::setJavaScriptName): (KJS::Bindings::ObjcMethod::javaScriptName): (KJS::Bindings::ObjcArray::getObjcArray):
  • bindings/objc/objc_runtime.mm: (ObjcField::name): (ObjcArray::ObjcArray): (ObjcArray::setValueAt): (ObjcArray::valueAt): (ObjcArray::getLength):
  • wtf/RetainPtr.h:
7:40 PM Changeset in webkit [23471] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Oliver.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14109
Cleanup JSEvent and JSClipboard in preperation for autogeneration

  • bindings/js/kjs_events.cpp: (KJS::DOMEvent::DOMEvent): (KJS::DOMEvent::getValueProperty): (KJS::DOMEvent::put): (KJS::DOMEvent::putValueProperty): (KJS::DOMEventPrototypeFunction::callAsFunction): (KJS::toJS): (KJS::toEvent): (KJS::): (KJS::JSClipboard::JSClipboard): (KJS::JSClipboard::~JSClipboard): (KJS::JSClipboard::getOwnPropertySlot): (KJS::JSClipboard::getValueProperty): (KJS::JSClipboard::put): (KJS::JSClipboard::putValueProperty): (KJS::JSClipboardPrototypeFunction::callAsFunction): (KJS::toClipboard):
  • bindings/js/kjs_events.h: (KJS::DOMEvent::): (KJS::DOMEvent::impl): (KJS::JSClipboard::impl):
  • dom/ClipboardEvent.h:
  • dom/Event.h: (WebCore::Event::srcElement): (WebCore::Event::returnValue): (WebCore::Event::clipboardData): (WebCore::Event::dataTransfer): (WebCore::Event::clipboard):
  • dom/MouseEvent.h:
6:48 PM Changeset in webkit [23470] by andersca
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Have JSCell inherit from Noncopyable.


  • bindings/objc/objc_runtime.h:
  • bindings/runtime_object.h:
  • kjs/value.h:
6:22 PM Changeset in webkit [23469] by lars
  • 4 edits in trunk

Fix compilation, and remove dependency on Qt
private header.

5:39 PM Changeset in webkit [23468] by lars
  • 10 edits
    1 add in trunk

Parts of the patch done by Zack.
Fix up some parts in the implementation of QWebNetworkInterface
so it can be used by plugins.
Change the plugin API so we can actually get all the information
required by the JS bridge from them as well.
Implement the parts required for the JS bridge
to know about the plugins.

5:22 PM Changeset in webkit [23467] by andersca
  • 14 edits in trunk/JavaScriptCore

Reviewed by Darin and Maciej.

More cleanup. Use our Noncopyable WTF class, add a root object member
to the Array class.


  • bindings/c/c_class.h:
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaArray::JavaArray):
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcArray::ObjcArray):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.cpp: (KJS::Bindings::Array::Array): (KJS::Bindings::Array::~Array):
  • bindings/runtime.h:
  • bindings/runtime_object.h:
  • bindings/runtime_root.h:
4:58 PM Changeset in webkit [23466] by aroben
  • 3 edits
    5 adds in trunk

WebKitTools:

Land CygwinDownloader.

Rubberstamped by Hyatt.

  • CygwinDownloader/cygwin-downloader.py: Added.
  • CygwinDownloader/cygwin-downloader.zip: Added.
  • CygwinDownloader/make-zip.sh: Added.
  • CygwinDownloader/setup.py: Added.

WebKitSite:

Update the location of cygwin-downloader.zip.

Rubberstamped by Hyatt.

  • building/tools.html:
3:40 PM Changeset in webkit [23465] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivate.h

Fix build bustage.

2:53 PM Changeset in webkit [23464] by aroben
  • 8 edits
    1 add in trunk/WebKitSite

Add Windows checkout/build instructions to website.

2:51 PM Changeset in webkit [23463] by aroben
  • 21 edits
    1 copy
    2 adds
    5 deletes in trunk

Update scripts and project paths to make the Windows build work.

2:50 PM Changeset in webkit [23462] by aroben
  • 112 copies in trunk

Merge WindowsMerge to trunk

12:46 AM Changeset in webkit [23461] by aroben
  • 9 adds in branches/WindowsMerge/LibrariesWin

Check in WebKitSystemInterface

Jun 11, 2007:

3:45 PM Changeset in webkit [22098] by zimmermann
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Eric.
Fix regression: SVG images drawn in the wrong paint phase.

1:33 PM Known incompatibilities between open-source WebKit and Safari edited by pewtermoose@gmail.com
(diff)
8:37 AM Changeset in webkit [22097] by rwlbuis
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=14064
fill property is reported as type SVGColor

Do the checks in the right order.

6:49 AM Changeset in webkit [22096] by hausmann
  • 3 edits in trunk/WebKitQt

Added a QWebPage::open overload to allow specifying the http header and post data.
(it's an overload instead of a merged openUrl to avoid including qhttp.h in qwebpage.h,
which would imply that one has to have QT += network in the .pro file for using WebKitQt)

6:49 AM Changeset in webkit [22095] by hausmann
  • 5 edits in trunk/WebKitQt

Added the possibility to intercept url requests through QWebPage::navigationRequested.

6:49 AM Changeset in webkit [22094] by hausmann
  • 3 edits in trunk/WebKitQt

Added a QWebNetworkRequest::init overload that takes a WebCore::ResourceRequest,
to be called from FrameLoaderClientQt in the near future.

6:49 AM Changeset in webkit [22093] by hausmann
  • 2 edits in trunk/WebKitQt

Moved the postData setup into QWebNetworkRequest::init.

6:49 AM Changeset in webkit [22092] by hausmann
  • 2 edits in trunk/WebKitQt

Moved HTTP header field propagation to QWebNetworkRequest::init.

6:48 AM Changeset in webkit [22091] by hausmann
  • 4 edits in trunk/WebKitQt

Started moving the code to separate a WebCore::ResourceRequest into a QUrl, postData
and QHttpRequestHeader into a separate little QWebNetworkRequest struct.

12:30 AM Changeset in webkit [22090] by zack
  • 2 edits in trunk/WebKitQt

Forgot to export the plugin exporter. Fixing it.

Jun 10, 2007:

6:02 PM Changeset in webkit [22089] by ggaren
  • 2 edits in trunk/LayoutTests

Reviewed by Beth Dakin.


Made confusing work-around to ObjC bindings bug <rdar://problem/5262101>
less confusing.


Fixed test to actually call queueReload.

  • fast/frames/resources/iframe-focus.html:
3:58 PM Changeset in webkit [22088] by bdash
  • 2 edits in trunk/WebCore

2007-06-10 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Maciej.


Disable whole-view editing for the Gdk port in order to improve the browsing experience.


  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::isEditable): Return false to disable whole-view editing
3:18 PM Changeset in webkit [22087] by bdakin
  • 2 edits in trunk/LayoutTests

Reviewed by Adele.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13933 REGRESSION:
fast/history/clicked-link-is-visited is failing

  • fast/frames/resources/iframe-focus.html: Cause the page to reload with layoutTestController.queueReload instead of using JavaScript to reload. Using JS seems to get DRT's history all messed up (off by one?!).
1:50 PM Changeset in webkit [22086] by sfalken
  • 1 copy in tags/Safari-522.11.3b

New tag.

12:41 PM Changeset in webkit [22085] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Beth Dakin.


Cleaned up formatting on the check out page.

  • building/checkout.html:
12:14 AM Changeset in webkit [22084] by hyatt
  • 2 edits in trunk/WebKit

Fix for bug 14037, make sure respondsToSelector does the write thing
when invoked on a WebKit plugin's container view.

Reviewed by Mark Rowe

  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView respondsToSelector:]):
Note: See TracTimeline for information about the timeline view.