⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 10, 2007:

10:33 PM Changeset in webkit [25488] by staikos
  • 2 edits in trunk/WebCore

2007-09-11 George Staikos <​staikos@kde.org>

Reviewed by Anders.

Work around gcc bug with some old gcc versions.

  • platform/qt/WidgetQt.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):
10:19 PM Changeset in webkit [25487] by bdash
  • 3 edits
    4 adds in trunk

2007-09-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej Stachowiak.

Test: fast/repaint/body-background-image.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): Refined the logic for when the root takes over painting the background, to match paintBoxDecorations(). In particular, if the root has defined a background, the body should paint its own background.

2007-09-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej Stachowiak.

  • fast/repaint/body-background-image.html: Added.
  • platform/mac/fast/repaint/body-background-image-expected.checksum: Added.
  • platform/mac/fast/repaint/body-background-image-expected.png: Added.
  • platform/mac/fast/repaint/body-background-image-expected.txt: Added.
10:17 PM Changeset in webkit [25486] by bdash
  • 2 edits in trunk/WebKit/gtk

2007-09-10 Nigel Tao <​nigeltao@gnome.org>

Reviewed by Mark Rowe.

Fix a typo where webkit_gtk_page_can_copy was declared twice,
rather than webkit_gtk_page_can_paste.

  • Api/webkitgtkpage.h:
8:53 PM Changeset in webkit [25485] by ggaren
  • 2 edits in trunk/WebKit

Fixed 64-bit build (I think).

  • WebView/WebView.mm: (max): Added. In 64-bit land, -diskCapacity magically starts returning unsigned long instead of unsigned, so we define a custom max() that's willing to compare unsigned to unsigned long.
6:03 PM Changeset in webkit [25484] by harrison
  • 9 edits
    8 adds in trunk

WebCore:

Reviewed by Kevin and Tristan.

Tests added:

  • editing/pasteboard/paste-into-anchor-text.html: Added.
  • editing/pasteboard/paste-table-cells.html: Added.

Source changes:

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Nil check enclosingAnchor.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeNodeAndPruneAncestors): New. Keeps m_firstNodeInserted and m_lastLeafInserted updated.


(WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
Added a comment.


(WebCore::ReplaceSelectionCommand::removeRedundantStyles):
Let ReplaceSelectionCommand::removeNodeAndPruneAncestors() update the nodes.


(WebCore::ReplaceSelectionCommand::doApply):
Pass originalVisPosBeforeEndBR to shouldRemoveEndBR()


(WebCore::ReplaceSelectionCommand::shouldRemoveEndBR):
Don't remove the br if nothing was inserted.


  • editing/ReplaceSelectionCommand.h: Add VisiblePosition parameter to shouldRemoveEndBR()


  • editing/markup.cpp: (WebCore::createMarkup): Wrap orphan tr element with a table element, just like we were doing for tobody elements.

LayoutTests:

Reviewed by Kevin and Tristan.

<rdar://problem/5456800> Mail crashes at WebCore::nextCandidate() after pasting back into a <table> multiple times

  • editing/pasteboard/paste-into-anchor-text.html: Added.
  • editing/pasteboard/paste-table-cells.html: Added.
  • editing/pasteboard/quirks-mode-br-1-expected.checksum:
  • editing/pasteboard/quirks-mode-br-1-expected.txt:
  • editing/pasteboard/quirks-mode-br-1.html:
  • platform/mac/editing/pasteboard/paste-into-anchor-text-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-into-anchor-text-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-into-anchor-text-expected.txt: Added.
  • platform/mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-table-cells-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-table-cells-expected.txt: Added.
5:16 PM Changeset in webkit [25483] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

<rdar://problem/5456224> CrashTracer: [USER] 2 crashes in Toast Titanium at com.apple.CoreServices.CarbonCore: CSMemDisposePtr + 37

Removed the implementation of these malloc zone functions. We do not have the ability to
check if a pointer is valid or not, so we can't correctly implement them. The system free
does not fail if you pass in a bad pointer.

  • wtf/FastMalloc.cpp: (WTF::FastMallocZone::size): (WTF::FastMallocZone::zoneMalloc): (WTF::FastMallocZone::zoneCalloc): (WTF::FastMallocZone::zoneFree): (WTF::FastMallocZone::zoneRealloc):
4:29 PM Changeset in webkit [25482] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by Oliver.

  • Updated Skipped list to remove tests that are now passing.
  • platform/win/Skipped:
4:13 PM Changeset in webkit [25481] by kmccullo
  • 4 edits
    3 deletes in trunk/WebKitTools

Reviewed by Adam.

  • Made an order-of-deletion mistake.
  • Drosera/DebuggerDocument.h:
  • Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
  • Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
  • Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
  • Drosera/mac/DebuggerClient.mm: (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3:59 PM Changeset in webkit [25480] by kmccullo
  • 5 edits
    2 moves
    3 adds in trunk/WebKitTools

Reviewed by Darin.

  • Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
  • Drosera/DebuggerDocument.cpp: (DebuggerDocument::DebuggerDocument):
  • Drosera/DebuggerDocument.h:
  • Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
  • Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
  • Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
  • Drosera/mac/DebuggerApplication.mm: (-[DebuggerApplication attach:]):
  • Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
  • Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm. (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
  • Drosera/mac/DebuggerDocumentMac.h: Removed.
  • Drosera/mac/DebuggerDocumentMac.mm: Removed.
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3:53 PM Changeset in webkit [25479] by thatcher
  • 1 edit in tags/Safari-5523.5.1/WebKit/Configurations/Version.xcconfig

Versioning

3:49 PM Changeset in webkit [25478] by thatcher
  • 7 edits in tags/Safari-5523.5.1/WebKit

Merge r25476.

3:41 PM Changeset in webkit [25477] by thatcher
  • 1 copy in tags/Safari-5523.5.1

New tag.

3:39 PM Changeset in webkit [25476] by darin
  • 7 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • <rdar://problem/5471082> Removing WebURLPboardType from headers broke SPI-using applications

Rolled out my fix for bug 4582212 and fixed it in a much simpler way.

  • Misc/WebNSPasteboardExtras.h:
  • Misc/WebNSPasteboardExtras.mm:
  • WebCoreSupport/WebPasteboardHelper.mm:
  • WebKit.exp:
  • WebView/WebHTMLView.mm:
  • WebView/WebView.mm: Rolled out the new PasteboardType functions and changed the PboardType globals to be initialized with constant values.
2:47 PM Changeset in webkit [25475] by sfalken
  • 2 edits in trunk/WebKit/win

Remove site-specific hacks that we don't need anymore.

Reviewed by Adam.

  • WebView.cpp: (WebView::userAgentForKURL):
2:32 PM Changeset in webkit [25474] by sfalken
  • 3 edits in trunk/WebKit/win

Prevent WebKit version numbers from containing "4" in Windows.

Reviewed by Darin.

  • WebKit.vcproj/VERSION: Bump version since our current version ends in 4.
  • WebKit.vcproj/auto-version.sh: Add version checking code.
2:23 PM Changeset in webkit [25473] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Rubberstamped by Kevin Decker.

No test required since there is no change in functionality.

  • history/BackForwardList.cpp: (WebCore::BackForwardList::BackForwardList): Fix misspelling of DefaultCapacitiy to DefaultCapacity.
2:21 PM Changeset in webkit [25472] by staikos
  • 2 edits in trunk/WebKitQt

Don't double-encode URL fragments

2:15 PM Changeset in webkit [25471] by tristan
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Adele Peterson.

Test: fast/forms/menulist-clip.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::controlClipRect): Use correct coordinates for the inner block's content rect.

LayoutTests:

Reviewed by Adele Peterson.

  • fast/forms/menulist-clip.html: Added.
  • platform/mac/fast/forms/menulist-clip-expected.checksum: Added.
  • platform/mac/fast/forms/menulist-clip-expected.png: Added.
  • platform/mac/fast/forms/menulist-clip-expected.txt: Added.
2:08 PM Changeset in webkit [25470] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Darin, Sam, Oliver, Geoff, probably others - what a fun one to review!

<rdar://problem/5471641> - URLs get the wrong icon

Turns out sqlite3_reset() doesn't clear bindings, so previously bound icons were being
written out for pages without icons. Easy fix!

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase): For null icons, manually bind NULL - otherwise, the previously bound icon will be written out to disk
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::bindNull): Access to sqlite3_bind_null
  • loader/icon/SQLStatement.h:
2:05 PM Changeset in webkit [25469] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver and Darin.

<rdar://problem/5468613>
Using shockwave pages first time after plugin install crashed safari in PluginPing.


Only restore the window proc if the plugin didn't override it.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::stop):
1:55 PM Changeset in webkit [25468] by justing
  • 14 edits
    2 adds
    2 deletes in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5467405>
Revert back behavior of -webkit-user-select to fix widget selection problems


Rolled out r25086 and r25057. I will be re-opening:
<rdar://problem/5333725> -webkit-user-select: none makes selection difficult
Which we will either to defer or fix by introducing a new value of -webkit-user-select.
<rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
Which we will either defer or fix with Adele's patch that doesn't involve making
-webkit-user-select inherited.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::canMouseDownStartSelect):
  • page/EventHandler.h:
  • rendering/RenderObject.cpp: (WebCore::selectStartNode): (WebCore::RenderObject::canSelect): (WebCore::RenderObject::shouldSelect): (WebCore::RenderObject::draggableNode):
  • rendering/RenderObject.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::): (WebCore::RenderStyle::userSelect): (WebCore::RenderStyle::setUserSelect): (WebCore::RenderStyle::initialUserSelect):

LayoutTests:

Reviewed by Darin.


<rdar://problem/5467405>
Revert back behavior of -webkit-user-select to fix widget selection problems

  • editing/selection/5333725.html: Removed.
  • editing/selection/5333725.html-disabled: Added.
  • editing/selection/user-select-text-inside-user-select-ignore.html: Removed.
  • editing/selection/user-select-text-inside-user-select-ignore.html-disabled: Added.
  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
10:51 AM Changeset in webkit [25467] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Always animate when calling _scrollTo.

  • WebView/WebFrameView.mm: (-[WebFrameView _scrollVerticallyBy:]): (-[WebFrameView _scrollHorizontallyBy:]):
7:55 AM Changeset in webkit [25466] by antti
  • 6 edits
    3 adds in trunk

WebCore:

Reviewed by Kevin.

Fix <rdar://problem/5444866>
REGRESSION: missing text in Acrobat "Getting Started" screen due to change in load ordering of large resources


Make external scripts loaded using file: wait until all style sheet loads have completed before executing.
Fixes a class of problems where there is a dependency between script and stylesheet and results would effectively
get randomized based on which order the resources arrived. In Tiger file loads were effectively serialized by
lower level components, which is why this regressed.

Test: http/tests/local/stylesheet-and-script-load-order.html

  • dom/Document.cpp: (WebCore::Document::removePendingSheet):
  • dom/Tokenizer.h: (WebCore::Tokenizer::executeScriptsWaitingForStylesheets):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::executeScriptsWaitingForStylesheets): (WebCore::HTMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.h:

LayoutTests:

Reviewed by Kevin.


Test for <rdar://problem/5444866>
REGRESSION: missing text in Acrobat "Getting Started" screen due to change in load ordering of large resources

  • http/tests/local/stylesheet-and-script-load-order-expected.txt: Added.
  • http/tests/local/stylesheet-and-script-load-order.html: Added.
  • http/tests/local/stylesheet-dependent.js: Added.

Sep 9, 2007:

9:56 PM Changeset in webkit [25465] by weinig
  • 1 edit
    2 moves in trunk/LayoutTests

Disable more occasionally failing tests.

  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html-disabled: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html-disabled: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html.
8:32 PM Changeset in webkit [25464] by dsmith
  • 3 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.


​http://bugs.webkit.org/show_bug.cgi?id=15148
Bug 15148: Poor performance on crazy DOM raytracer


Switch data structures to avoid quadratic behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObjects): Update for ListHashSet (WebCore::RenderBlock::markPositionedObjectsForLayout): Update for ListHashSet (WebCore::RenderBlock::insertPositionedObject): Use ListHashSet to avoid expensive uniqueing (WebCore::RenderBlock::removePositionedObject): Update for ListHashSet (WebCore::RenderBlock::removePositionedObjects): Update for ListHashSet (WebCore::RenderBlock::lowestPosition): Update for ListHashSet (WebCore::RenderBlock::rightmostPosition): Update for ListHashSet (WebCore::RenderBlock::leftmostPosition): Update for ListHashSet (WebCore::RenderBlock::rightBottom): Update for ListHashSet
  • rendering/RenderBlock.h: Change m_positionedObjects from DeprecatedPtrList to ListHashSet
7:08 PM Changeset in webkit [25463] by beidson
  • 2 edits in trunk/WebCore

Rubberstamped by Darin

pthread_main_np() is a Darwin thing, not a Mac thing

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase):
5:05 PM Changeset in webkit [25462] by weinig
  • 5 edits in trunk

WebKitTools:

Reviewed by Mark Rowe.

Remove 'objC' prefix from methods now in the ObjCController.

  • DumpRenderTree/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController classNameOf:]): (-[ObjCController objectOfClass:]): (-[ObjCController identityIsEqual::]): (-[ObjCController longLongRoundTrip:]): (-[ObjCController unsignedLongLongRoundTrip:]):

LayoutTests:

Reviewed by Mark Rowe.

Update tests now that the 'objC' prefix is no longer used for methods of the ObjCController.

  • fast/dom/wrapper-classes.html:
  • platform/mac/fast/objc/longlongTest.html:
4:48 PM Known incompatibilities between open-source WebKit and Safari edited by bdash@webkit.org
(diff)
4:48 PM Known incompatibilities between open-source WebKit and Safari edited by bdash@webkit.org
(diff)
4:41 PM Changeset in webkit [25461] by weinig
  • 10 edits
    4 adds in trunk

WebKitTools:

Reviewed by Oliver.

Initial refactor of DumpRenderTree in preparation of making it more platform independent.

  • Move LayoutTestController into its own file.
  • Move Objective-C only functions on LayoutTestController into a new controller called the ObjCController.
  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.m: (displayWebView):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/FrameLoadDelegate.m: (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
  • DumpRenderTree/LayoutTestController.h: Added.
  • DumpRenderTree/LayoutTestController.m: Added. (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController clearBackForwardList]): (-[LayoutTestController setUseDashboardCompatibilityMode:]): (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]): (-[LayoutTestController setCustomPolicyDelegate:]): (-[LayoutTestController keepWebHistory]): (-[LayoutTestController setCallCloseOnWebViews:]): (-[LayoutTestController setCanOpenWindows]): (-[LayoutTestController waitUntilDone]): (-[LayoutTestController waitUntilDoneWatchdogFired]): (-[LayoutTestController notifyDone]): (-[LayoutTestController dumpAsText]): (-[LayoutTestController addFileToPasteboardOnDrag]): (-[LayoutTestController addDisallowedURL:]): (-[LayoutTestController setUserStyleSheetLocation:]): (-[LayoutTestController setUserStyleSheetEnabled:]): (-[LayoutTestController dumpDOMAsWebArchive]): (-[LayoutTestController dumpSourceAsWebArchive]): (-[LayoutTestController dumpSelectionRect]): (-[LayoutTestController dumpTitleChanges]): (-[LayoutTestController dumpBackForwardList]): (-[LayoutTestController windowCount]): (-[LayoutTestController dumpChildFrameScrollPositions]): (-[LayoutTestController dumpChildFramesAsText]): (-[LayoutTestController dumpEditingCallbacks]): (-[LayoutTestController dumpResourceLoadCallbacks]): (-[LayoutTestController dumpFrameLoadCallbacks]): (-[LayoutTestController setWindowIsKey:]): (-[LayoutTestController setMainFrameIsFirstResponder:]): (-[LayoutTestController display]): (-[LayoutTestController testRepaint]): (-[LayoutTestController repaintSweepHorizontally]): (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]): (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]): (-[LayoutTestController _doLoad:target:]): (-[LayoutTestController _doBackOrForwardNavigation:]): (-[LayoutTestController queueBackNavigation:]): (-[LayoutTestController queueForwardNavigation:]): (-[LayoutTestController queueReload]): (-[LayoutTestController queueScript:]): (-[LayoutTestController queueLoad:target:]): (-[LayoutTestController setAcceptsEditing:]): (-[LayoutTestController setTabKeyCyclesThroughElements:]): (-[LayoutTestController storeWebScriptObject:]): (-[LayoutTestController accessStoredWebScriptObject]): (-[LayoutTestController dealloc]): (-[LayoutTestController decodeHostName:]): (-[LayoutTestController encodeHostName:]):
  • DumpRenderTree/ObjCController.h: Added.
  • DumpRenderTree/ObjCController.m: Added. (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController objCClassNameOf:]): (-[ObjCController objCObjectOfClass:]): (-[ObjCController objCIdentityIsEqual::]): (-[ObjCController objCLongLongRoundTrip:]): (-[ObjCController objCUnsignedLongLongRoundTrip:]): (-[ObjCController testWrapperRoundTripping:]):

LayoutTests:

Reviewed by Oliver.

Change objective-c tests to use the new ObjCController.

  • fast/dom/Window/window-properties.html:
  • fast/dom/wrapper-classes.html:
  • platform/mac/fast/dom/wrapper-round-tripping.html:
  • platform/mac/fast/objc/longlongTest.html:
4:34 PM Known incompatibilities between open-source WebKit and Safari edited by beidson@apple.com
Added comment about icon db not working fully with current released Safaris (diff)
3:54 PM Changeset in webkit [25460] by zimmermann
  • 13 edits
    24 adds in branches/feature-branch

Reviewed by Oliver.

Rework <pattern> support to take overflow & viewBox into account.
Also fix all possible combinations of patternUnits/patternContentUnits, tested by several batik testcases.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12221 (Webkit ToT fails to render this pattern example)

6:23 AM Changeset in webkit [25459] by zecke
  • 2 edits in trunk/WebCore

2007-09-09 Holger Hans Peter Freyther <​zecke@selfish.org>

Build fix for Gtk+ by adding WebCore::callOnMainThread to the TemporaryLinkStubs.

  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::callOnMainThread):
12:11 AM Changeset in webkit [25458] by weinig
  • 1 edit
    3 moves in trunk/LayoutTests

Rubber-stamped by Oliver.

Disable occasionally failing tests until the reason for their failure can be determined.

  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html-disabled: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html-disabled: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html-disabled: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html.

Sep 8, 2007:

10:31 PM Changeset in webkit [25457] by staikos
  • 1 edit in trunk/WebCore/WebCore.pro

missed file in previous checkin

10:14 PM Changeset in webkit [25456] by staikos
  • 2 edits
    2 adds in trunk/WebCore

implement a couple of FileSystem functions and stub out the new thread function
for future implementation

8:13 PM Changeset in webkit [25455] by bdash
  • 4 edits in trunk

2007-09-08 Mark Rowe <​mrowe@apple.com>

Build fix for when ENABLE(ICONDATABASE) is not set.

  • loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::~IconDatabase):

2007-09-08 Mark Rowe <​mrowe@apple.com>

Qt build fix. Move stub method implementations to the right class.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didPerformFirstNavigation):
7:50 PM Changeset in webkit [25454] by bdash
  • 4 edits in trunk/WebCore

2007-09-08 Mark Rowe <​mrowe@apple.com>

More fixes for the Qt and Gtk builds.

  • WebCore.pro: Update for file changes.
  • loader/icon/IconDatabase.cpp: Include errno.h for EDEADLK.
  • loader/icon/PageURLRecord.h:
5:22 PM Changeset in webkit [25453] by justing
  • 4 edits
    2 adds
    2 deletes in trunk

WebCore:

Backing my change back in without the changes to VisiblePosition::next
and previous that weren't necessary to fix the bug and were causing some
layout test failures. Most of the failures appeared to be fixes but I
want more time to investigate and have to move to on to another task.

  • editing/Selection.cpp: (WebCore::Selection::validate):
  • editing/visible_units.cpp: (WebCore::endOfWord):

LayoutTests:

Re-enabling these tests.

  • editing/selection/5057506-2.html: Added.
  • editing/selection/5057506-2.html-disabled: Removed.
  • editing/selection/5057506.html: Added.
  • editing/selection/5057506.html-disabled: Removed.
4:15 PM Changeset in webkit [25452] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe

Fix the _NSAutoreleaseNoPool() errors on launch - We were using NSFileManager on the secondary
thread with no NSAutoreleasePool in place

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconDatabaseSyncThread):
3:45 PM Changeset in webkit [25451] by weinig
  • 3 edits in trunk/WebCore

Add fix to the correct file.

  • loader/icon/SQLDatabase.h:
  • loader/icon/SQLStatement.h:
3:25 PM Changeset in webkit [25450] by weinig
  • 2 edits in trunk/WebCore

Fix Windows build.

  • loader/icon/SQLStatement.h: Disable boolean conversion warning.
2:45 PM Changeset in webkit [25449] by bdash
  • 1 copy in tags/Safari-4523.5

New tag.

2:44 PM Changeset in webkit [25448] by beidson
  • 2 edits in trunk/WebKitQt

YABF (Yet Another Build Fix)

  • Api/qwebsettings.cpp: (QWebSettings::iconDatabaseEnabled):
2:35 PM Changeset in webkit [25447] by beidson
  • 3 edits in trunk/WebKit/gtk

Better build fix

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::registerForIconNotification):
  • WebCoreSupport/FrameLoaderClientGtk.h:
2:30 PM Changeset in webkit [25446] by beidson
  • 3 edits in trunk/WebKitQt

Better build fix

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClient::registerForIconNotification):
  • WebCoreSupport/FrameLoaderClientQt.h:
2:24 PM Changeset in webkit [25445] by beidson
  • 3 edits in trunk/WebKit/gtk

Build fix

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::registerForIconNotification):
  • WebCoreSupport/FrameLoaderClientGtk.h:
2:19 PM Changeset in webkit [25444] by beidson
  • 3 edits in trunk/WebKitQt

Build fix

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClient::registerForIconNotification):
  • WebCoreSupport/FrameLoaderClientQt.h:
2:09 PM Changeset in webkit [25443] by beidson
  • 2 edits in trunk/WebCore

Build fix for non-Mac platforms that use Icon Database

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): Apparently only Mac has the beauty that is pthread_main_np()
1:58 PM Changeset in webkit [25442] by bdash
  • 4 edits in trunk

Versioning.

1:57 PM Changeset in webkit [25441] by bdash
  • 1 copy in tags/Safari-5523.5

New tag.

1:48 PM Changeset in webkit [25440] by bdash
  • 2 edits in trunk/WebCore

2007-09-08 Mark Rowe <​mrowe@apple.com>

Build fix.

  • WebCore.xcodeproj/project.pbxproj: Headers used up in WebKit need to be be "private" rather than "project".
1:33 PM Changeset in webkit [25439] by beidson
  • 28 edits
    9 adds
    2 deletes in trunk

WebCore:

Reviewed by Darin

<rdar://problem/5434431> - Asynchronous Icon Database

The IconDatabase API was originally designed to be fully asynchronous - if an icon wasn't read in from disk
when you asked for it, you would be notified when it was.

Safari 2 did writes on a background thread, but reads blocked the main thread.

The current WebCore implementation using SQLite attempted to get rid of the background thread by defering expensive
writes via timers, but falls short in moderate to extreme usage cases

Time to make the IconDatabase live up to it's fully asynchronous destiny.

This should -

  • Make the browser instantly usable while converting Safari 2 icons in the background occurs
  • Remedy any UI slowness/blocking when on slow network home directories
  • Remedy random UI slowness, pauses, and stutters do to random I/O occurring at the exact wrong time or under heavy disk usage from swapping or other apps on the system
  • Allow certain long-running procedures to be interruptible (Safari 2 import, reading icons in from disk when trying to quit, etc)

This will have a noticeable effect on current Safari 2 and Safari 3 beta browsers, including icons not appearing in bookmarks, history,
or the location field the first time they're asked for, as current released Safari's don't properly listen for these async notifations.
The second time such a menu or view is brought up, the icon should be there.

Additionally this includes a SQLite schema change which will be a lot more efficient but will result in the loss of current SQLite icons.
Converting from Safari 2 style icons will still work.

WebCore, welcome to multi-threadedness

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcproj/WebCore.vcproj:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::iconLoadDecisionAvailable): Called when an Icon becomes available that was requested by this DocumentLoader (to support the webView:didReceiveIcon: delegate call in WebKit)
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconLoadDecisionAvailable): Called from the DocumentLoaders who get notified - if the FrameLoader ends up not caring because the WebView has transitioned to a new page, nothing occurs. Otherwise, the FrameLoader possibly starts it Icon Loader and possibly sends the webView:didReceiveIcon: delegate call (WebCore::FrameLoader::startIconLoader): Instead of "Yes, load the icon now" or "No, don't load it" there is a third possibility - "You might be asked to load your icon later." Add supporting logic for receiving this state, and being called a second time when the load decision is finally available.
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h: Added "registerForIconNotification" which is a way to tell WebViews "The icon you are interested in might become available via the generic WebIconDatabaseDidAddIconNotification instead of a targeted delegate call" A WebView can then receive the generic notification and pass on it's own targeted delegate call.
  • loader/icon/IconDataCache.cpp: Removed.
  • loader/icon/IconDataCache.h: Removed.
  • loader/icon/IconDatabase.cpp: (WebCore::urlForLogging): Cut a URL down in length for sane logging and debugging (WebCore::defaultClient): Return the default, empty IconDatabaseClient incase the API doesn't set one.

Following block of methods are for the Main thread's usage -
(WebCore::IconDatabase::setClient):
(WebCore::makeAllDirectories): Small optimization that checks to see if the entire path exists already, and doesn't try to loop

through each patch component if the full path is already present

(WebCore::IconDatabase::open): Makes all directories to the target path and kicks off the background thread - nothing more.
(WebCore::IconDatabase::close): Signals the thread to quit and waits for it to do so
(WebCore::IconDatabase::removeAllIcons): Purge the icon database
(WebCore::IconDatabase::iconForPageURL):
(WebCore::IconDatabase::readIconForPageURLFromDisk):
(WebCore::IconDatabase::iconURLForPageURL):
(WebCore::IconDatabase::defaultIcon):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::loadDecisionForIconURL): Determine if an icon loader should load now. If the decision is "maybe later", then

mark the DocumentLoader to be notified later when the final decision is available.

(WebCore::IconDatabase::iconDataKnownForIconURL): Determine if the actual image data has been read from disk (or set from the loader) for

icon URL in question

(WebCore::IconDatabase::setEnabled):
(WebCore::IconDatabase::isEnabled):
(WebCore::IconDatabase::setPrivateBrowsingEnabled):
(WebCore::IconDatabase::isPrivateBrowsingEnabled):
(WebCore::IconDatabase::delayDatabaseCleanup): Restore this method from a year ago, as asynchronous pruning of icons can now occur on a

background thread.

(WebCore::IconDatabase::allowDatabaseCleanup):
(WebCore::IconDatabase::checkIntegrityBeforeOpening):
(WebCore::IconDatabase::pageURLMappingCount):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::iconRecordCount):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::~IconDatabase):
(WebCore::IconDatabase::notifyPendingLoadDecisions): Tell all the registered DocumentLoaders "Hey, we've read in all URL mappings from disk,

so check to see if you are interested in any of them"

(WebCore::IconDatabase::notifyPendingLoadDecisionsInternal):
(WebCore::IconDatabase::wakeSyncThread): Wake the sync thread, if it is idle
(WebCore::IconDatabase::scheduleOrDeferSyncTimer): Even though we're on a background thread, we still defer writing out to disk during

periods of high activity

(WebCore::IconDatabase::syncTimerFired): Call wakeSyncThread()

Following block of methods may be used by either thread -
(WebCore::IconDatabase::isOpen):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::defaultDatabaseFilename):
(WebCore::IconDatabase::getOrCreateIconRecord):
(WebCore::IconDatabase::getOrCreatePageURLRecord):

Following block of methods are used by the secondary thread only -
(WebCore::IconDatabase::importIconURLForPageURL): For the Safari 2 import procedure - write a URL mapping directly out to disk
(WebCore::IconDatabase::importIconDataForIconURL): For the Safari 2 import procedure - write an Icon directly out to disk
(WebCore::IconDatabase::shouldStopThreadActivity): To check and see if the thread should stop what it is doing now to do something

more important (such as quit, or delete all icons)

(WebCore::IconDatabase::iconDatabaseSyncThreadStart):
(WebCore::IconDatabase::iconDatabaseSyncThread): Entry point for the background thread
(WebCore::databaseVersionNumber):
(WebCore::isValidDatabase):
(WebCore::createDatabaseTables):
(WebCore::IconDatabase::performOpenInitialization): Open and validate the SQLite database, making sure it's schema jives with what

is expected

(WebCore::IconDatabase::checkIntegrity):
(WebCore::IconDatabase::performURLImport): Import all the Page URL -> Icon URL mappings from the database. Done "1st thing" on startup,

this is necessary to be able to give the loader decisions about whether or not it should load icons from the network

(WebCore::IconDatabase::syncThreadMainLoop): Main loop - sleeps until woken up, then does a read cycle and a write cycle until both cycles

do no work - then it goes back to sleep.

(WebCore::IconDatabase::readFromDatabase): Reads icons from the database that clients are waiting on
(WebCore::IconDatabase::writeToDatabase): Writes any changes page -> icon url mappings to disk, as well as any new image data that has

been received from the loader

(WebCore::IconDatabase::pruneUnretainedIcons): Done only once, and only after the first write to the database, this procedure removes all

icons and page URLs from disk that haven't been retained by any client. Note that the prune can be delayed by utilizing delayDatabaseCleanup()

(WebCore::IconDatabase::checkForDanglingPageURLs): Usually part of the prune procedure, prunes any pages who point to icons that no longer exist

in the database

(WebCore::IconDatabase::removeAllIconsOnThread): Completely purge both the on-disk and in memory records of all icons
(WebCore::IconDatabase::deleteAllPreparedStatements): Part of removeAllIcons and the thread cleanup procedure
(WebCore::IconDatabase::cleanupSyncThread): Write out any last remaining writes to disk, close the database, and then end the thread
(WebCore::IconDatabase::imported): Checks the DB to see if the Safari 2 import has occured
(WebCore::IconDatabase::setImported): Sets the "Safari 2 imported" flag
(WebCore::readySQLStatement):
(WebCore::IconDatabase::setIconURLForPageURLInSQLDatabase): This and the following "SQLDatabase" suffixed methods are pretty self explanatory
(WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase):
(WebCore::IconDatabase::removePageURLFromSQLDatabase):
(WebCore::IconDatabase::getIconIDForIconURLFromSQLDatabase):
(WebCore::IconDatabase::addIconURLToSQLDatabase):
(WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):
(WebCore::IconDatabase::removeIconFromSQLDatabase):
(WebCore::IconDatabase::writeIconSnapshotToSQLDatabase):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseClient.h: Added. (WebCore::IconDatabaseClient::~IconDatabaseClient): (WebCore::IconDatabaseClient::performImport): Perform the Safari 2 import, implemented by WebKit (WebCore::IconDatabaseClient::dispatchDidRemoveAllIcons): Send the API notification (WebCore::IconDatabaseClient::dispatchDidAddIconForPageURL): Ditto
  • loader/icon/IconDatabaseNone.cpp: Best attempt to keep non icon-DB platforms building (WebCore::IconDatabase::defaultDatabaseFilename): (WebCore::IconDatabase::readIconForPageURLFromDisk): (WebCore::IconDatabase::loadDecisionForIconURL): (WebCore::IconDatabase::iconDataKnownForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::isEnabled): (WebCore::IconDatabase::delayDatabaseCleanup): (WebCore::IconDatabase::allowDatabaseCleanup): (WebCore::IconDatabase::setClient):
  • loader/icon/IconRecord.cpp: Added. (WebCore::IconRecord::IconRecord): IconRecord used to be "IconDataCache" - it is merely a container for the url, timestamp, and image for a site icon. It is Shared, and therefore ref counted - PageURLRecords are the owning containers. This is a tricky way to track how many page urls are retaining an IconRecord and therefore tracking when we should try to get rid of one. (WebCore::IconRecord::~IconRecord): (WebCore::IconRecord::image): (WebCore::IconRecord::setImageData): (WebCore::IconRecord::loadImageFromResource): (WebCore::IconRecord::imageDataStatus): Return whether the image data hasn't been read yet, exists in memory, or is absent (site with no icon) (WebCore::IconRecord::snapshot): Returns a snapshot of the icon's data - url, timestamp, and image data - to be written to disk
  • loader/icon/IconRecord.h: Added. (WebCore::IconSnapshot::IconSnapshot): (WebCore::IconRecord::getTimestamp): (WebCore::IconRecord::setTimestamp): (WebCore::IconRecord::iconURL): (WebCore::IconRecord::retainingPageURLs):
  • loader/icon/PageURLRecord.cpp: Added. (WebCore::PageURLRecord::PageURLRecord): PageURLRecord is fundamentally a pairing of a Page URL to an Icon. It has manual ref counting for the sake of "retainIconForPageURL" and "releaseIconForPageURL", and can provide a quick snapshot of it's Page URL -> Icon URL mapping for writing to the database (WebCore::PageURLRecord::setIconRecord): (WebCore::PageURLRecord::snapshot):
  • loader/icon/PageURLRecord.h: Added. (WebCore::PageURLSnapshot::PageURLSnapshot): (WebCore::PageURLRecord::url): (WebCore::PageURLRecord::PageURLRecord::iconRecord): (WebCore::PageURLRecord::retain): (WebCore::PageURLRecord::release): (WebCore::PageURLRecord::retainCount):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::copy): Added a deep copy method for the purposes of handing icon data across the thread boundary into the icon database
  • platform/SharedBuffer.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::registerForIconNotification):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::callOnMainThread): Only other IconDatabase utilizing platform - keep their build going

WebKit:

Reviewed by Darin

<rdar://problem/5434431> - Asynchronous Icon Database

WebKit side of things
Mainly, there are Notifications WebKit has to listen for now that tell it when to either call back into WebCore
for some purpose or to send the webView:didReceiveIcon: delegate call

Many smaller tweaks as well.

  • Misc/WebIconDatabase.h:
  • Misc/WebIconDatabase.mm: (defaultClient): (-[WebIconDatabase init]): (+[WebIconDatabase delayDatabaseCleanup]): Accessor so clients can prevent the thread from cleaning up the database before they've done all their necessary retaining of icons. (+[WebIconDatabase allowDatabaseCleanup]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _sendNotificationForURL:]): (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): (-[WebIconDatabase _databaseDirectory]):

(-[ThreadEnabler threadEnablingSelector:]): Quick and dirty class to enabled Cocoa multithreading
(+[ThreadEnabler enableThreading]):
(importToWebCoreFormat):

  • Misc/WebIconDatabaseInternal.h: Expose the internal methods of WebIconDatabase that are required by WebIconDatabaseClient
  • Misc/WebNSNotificationCenterExtras.h: Added. - Great utility class whose design was borrowed from Colloquy that allows the posting of a Cocoa notification on the main thread from *any* thread
  • Misc/WebNSNotificationCenterExtras.m: Added. (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:]): (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:userInfo:]): (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:userInfo:waitUntilDone:]): (+[NSNotificationCenter _postNotificationName:]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon): Send the webView:didReceiveIcon: delegate call (WebFrameLoaderClient::registerForIconNotification):
  • WebCoreSupport/WebIconDatabaseClient.h: Added.
  • WebCoreSupport/WebIconDatabaseClient.mm: Added. (WebIconDatabaseClient::performImport): Perform the Safari 2 icon import (WebIconDatabaseClient::dispatchDidRemoveAllIcons): Send the NSNotification (WebIconDatabaseClient::dispatchDidAddIconForPageURL): Ditto
  • WebView/WebView.mm: (-[WebView _receivedIconChangedNotification:]): Check and see if this notification is for this WebView's current URL by calling back into the IconDatabase (-[WebView _registerForIconNotification:]): Support for WebIconDatabaseClient (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Dispatch this delegate call as well as unregister for the notification
  • WebView/WebViewInternal.h:
  • WebKit.xcodeproj/project.pbxproj:

win:

<rdar://problem/5434431> - Asynchronous Icon Database

  • WebFrame.cpp: (WebFrame::didPerformFirstNavigation): Empty impl for now (WebFrame::registerForIconNotification): Ditto
  • WebFrame.h:

Sep 7, 2007:

9:00 PM Changeset in webkit [25438] by oliver
  • 1 edit in trunk/LayoutTests/ChangeLog

Spell Sams name correctly.

8:59 PM Changeset in webkit [25437] by oliver
  • 1 edit
    42 deletes in trunk/LayoutTests

RS=Same

r25382 moved a number of tests from platform/mac back to the cross-platform
directories, but did not commit the platform/mac changes themselves.


This patch actually does.


  • platform/mac/editing/execCommand/nsresponder-outdent-expected.txt: Removed.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.checksum: Removed.
  • platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum: Removed.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.png: Removed.
  • platform/mac/editing/execCommand/nsresponder-outdent-expected.png: Removed.
  • platform/mac/editing/execCommand/nsresponder-indent.html: Removed.
  • platform/mac/editing/execCommand/nsresponder-outdent.html: Removed.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.txt: Removed.
  • platform/mac/editing/selection/5195166-1-expected.png: Removed.
  • platform/mac/editing/selection/5195166-2-expected.png: Removed.
  • platform/mac/editing/selection/select-line-expected.txt: Removed.
  • platform/mac/editing/selection/selection-actions-expected.checksum: Removed.
  • platform/mac/editing/selection/selection-actions.html: Removed.
  • platform/mac/editing/selection/4947387-expected.txt: Removed.
  • platform/mac/editing/selection/4947387-expected.png: Removed.
  • platform/mac/editing/selection/5195166-1-expected.checksum: Removed.
  • platform/mac/editing/selection/5195166-2-expected.checksum: Removed.
  • platform/mac/editing/selection/selection-actions-expected.txt: Removed.
  • platform/mac/editing/selection/5195166-1.html: Removed.
  • platform/mac/editing/selection/5195166-2.html: Removed.
  • platform/mac/editing/selection/selection-actions-expected.png: Removed.
  • platform/mac/editing/selection/select-line.html: Removed.
  • platform/mac/editing/selection/4947387-expected.checksum: Removed.
  • platform/mac/editing/selection/5195166-1-expected.txt: Removed.
  • platform/mac/editing/selection/4947387.html: Removed.
  • platform/mac/editing/selection/5195166-2-expected.txt: Removed.
  • platform/mac/editing/deleting/smart-delete-003-expected.checksum: Removed.
  • platform/mac/editing/deleting/smart-delete-004-expected.checksum: Removed.
  • platform/mac/editing/deleting/smart-delete-003.html: Removed.
  • platform/mac/editing/deleting/smart-delete-004.html: Removed.
  • platform/mac/editing/deleting/5300379-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Removed.
  • platform/mac/editing/deleting/5300379.html: Removed.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph.html: Removed.
  • platform/mac/editing/deleting/smart-delete-003-expected.txt: Removed.
  • platform/mac/editing/deleting/smart-delete-004-expected.txt: Removed.
  • platform/mac/editing/deleting/5300379-expected.txt: Removed.
  • platform/mac/editing/deleting/smart-delete-003-expected.png: Removed.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
  • platform/mac/editing/deleting/smart-delete-004-expected.png: Removed.
  • platform/mac/editing/deleting/5300379-expected.png: Removed.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
8:24 PM Changeset in webkit [25436] by oliver
  • 1 edit
    17 adds in trunk/LayoutTests

Reviewed by Sam.

Re-adding a few mac specific directories that accidentally got clobbered
during my recent layout test rearranging

  • platform/mac/editing/input: Added.
  • platform/mac/editing/input/hangul-enter-confirms-and-sends-keypress-expected.txt: Added.
  • platform/mac/editing/input/hangul-enter-confirms-and-sends-keypress.html: Added.
  • platform/mac/editing/input/hangul.js: Added.
  • platform/mac/editing/input/kotoeri-enter-to-confirm-and-newline-expected.txt: Added.
  • platform/mac/editing/input/kotoeri-enter-to-confirm-and-newline.html: Added.
  • platform/mac/editing/input/kotoeri.js: Added.
  • platform/mac/editing/input/logger.js: Added.
  • platform/mac/fast/AppleScript: Added.
  • platform/mac/fast/AppleScript/001-expected.txt: Added.
  • platform/mac/fast/AppleScript/001.html: Added.
  • platform/mac/fast/AppleScript/array-expected.txt: Added.
  • platform/mac/fast/AppleScript/array.html: Added.
  • platform/mac/fast/AppleScript/date-expected.txt: Added.
  • platform/mac/fast/AppleScript/date.html: Added.
  • platform/mac/fast/objc: Added.
  • platform/mac/fast/objc/longlongTest-expected.txt: Added.
  • platform/mac/fast/objc/longlongTest.html: Added.
8:10 PM Changeset in webkit [25435] by ddkilzer
  • 2 edits
    1 delete in trunk/WebCore

WebCore:

Reviewed by Timothy Hatcher.

Housekeeping. No test required.

  • bindings/objc/WebScriptObjectInternal.h: Removed unused file.
  • bindings/objc/WebScriptObjectPrivate.h: Updated copyright statement.
7:31 PM Changeset in webkit [25434] by justing
  • 6 edits
    2 adds
    2 deletes in trunk

WebCore:

Rolling out my changes from r25421 while I investigate the layout test failures
they caused.


  • editing/Selection.cpp: (WebCore::Selection::validate):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::lastEditablePositionAtOrBefore): (WebCore::VisiblePosition::firstEditablePositionAtOrAfter):
  • editing/VisiblePosition.h:
  • editing/visible_units.cpp: (WebCore::endOfWord): (WebCore::previousWordPosition): (WebCore::nextWordPosition): (WebCore::startOfLine): (WebCore::endOfLine): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition):

LayoutTests:

Disabling the layout tests checked in with r25421 while I investigate
some layout test failures that that change caused.

  • editing/selection/5057506-2.html: Removed.
  • editing/selection/5057506-2.html-disabled: Added.
  • editing/selection/5057506.html: Removed.
  • editing/selection/5057506.html-disabled: Added.
7:23 PM Changeset in webkit [25433] by weinig
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Remove a duplicate test.
6:40 PM Changeset in webkit [25432] by ggaren
  • 2 edits in trunk/WebKit

Suggested by Maciej Stachowiak.


Added wKiosk Browser to the browser list. Pretty sweet app.

  • WebView/WebPreferences.m: (cacheModelForMainBundle):
6:17 PM Changeset in webkit [25431] by ggaren
  • 2 edits in trunk/WebKit

Build fix.

  • WebView/WebView.mm: (+[WebView _setCacheModel:]):
5:40 PM Changeset in webkit [25430] by ggaren
  • 25 edits in trunk

gtk:

Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.


Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
memory cache, or a very tiny one


Keep the GTK build working with an empty stub.


  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didPerformFirstNavigation):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebCore:

Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.


Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
memory cache, or a very tiny one

Added a client callback to notify WebKit when the first navigation has
taken place. "Navigation" here means a transition from one page to
another that ends up in the back/forward list.


WebKit Mac uses this notification to grow its cache model under certain
circumstances.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addBackForwardItemClippedAtTarget):
  • loader/FrameLoaderClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::didPerformFirstNavigation): Ah, SVGEmptyFrameLoaderClient, my old friend.

WebKit:

Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.


Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
memory cache, or a very tiny one


High level explanation:

  • Added SPI for specifying a cache model on a per-WebView basis. (Hopefully, this will become API soon.) We balance competing cache models simply by using the largest one that pertains at a given time.
  • Added heuristic for guessing a default cache model in WebViews that don't specify one:

1) Default to DocumentViewer for apps linked on or after this
WebKit. Default to DocumentBrowser otherwise.

2) Assign specific defaults to well-known clients based on
bundle ID.

3) Grow the default to DocumentBrowser if a navigation takes
place.

  • As a part of the DocumentBrowser & PrimaryWebBrowser settings:

1) Make the Foundation disk cache much much bigger than the
default 20MB, if space allows. (This is a hedge against a small
WebCore cache in DocumentBrowser mode, but also an all-around
win for page load speed.)

2) Scaled the Foundation memory cache's capacity with physical
RAM, just like we do with other caches. This is a small win on
low memory systems.

  • Misc/WebKitSystemBits.h:
  • Misc/WebKitSystemBits.m: (WebMemorySize): Renamed from "WebSystemMainMemory." (WebHomeDirectoryFreeSize): Added function to measure the free space on the user's home directory. We use this as a factor in determining the disk cache's cacpacity.
  • Misc/WebKitVersionChecks.h: Support for linked on or after check.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didPerformFirstNavigation): Implementation of heuristic rule #3.
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (cacheModelForMainBundle): Implementation of heuristic rule #2. (-[NSMutableDictionary _web_checkLastReferenceForIdentifier:]): Added notification for when a WebPreferences instance becomes inert. We use this to shrink the cache model back down if possible. Moved this code into a WebPreferences method, since it's not really a feature of NSDictionary.
  • WebView/WebPreferencesPrivate.h: SPI declarations.


  • WebView/WebView.mm: Replaced manual notification posts with calls to the _postPreferencesChangesNotification convenience method.

(-[WebView _preferencesChangedNotification:]): Merged dispersed code
for updating preferences-related settings into this one function. This
was needed for an earlier version of the patch, even though the
current version could probably do without it.

(+[WebView _preferencesChangedNotification:]): Added a class-level
listener for WebPreferences changes. This listener takes care of
modifying the class-level global cache model setting if necessary.

(+[WebPreferences standardPreferences]): Removed call to
_postPreferencesChangesNotification because the notification already
posts when you create the WebPreferences object. (I noticed this
inefficiency because my new _preferencesChangedNotification: method was
called excessively at startup.)

Also Added explicit tracking of WebPreferences clients, so we know when
a WebPreferences instance becomes inert:


(-[WebPreferences didRemoveFromWebView]):
(-[WebPreferences willAddToWebView]):

(+[WebView _setCacheModel:]): Translates a cache model into actual
settings in various APIs. Caches that have unbounded value grow
linearly relative to available space. Caches that have bounded value
grow inverse-squaredly relative to available space.

WebKitQt:

Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.


Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
memory cache, or a very tiny one


Keep the Qt build working with an empty stub.


  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClient::didPerformFirstNavigation):
  • WebCoreSupport/FrameLoaderClientQt.h:

win:

Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.


Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
memory cache, or a very tiny one


Keep the Windows build working with an empty stub.


  • WebFrame.cpp: (FrameLoaderClient::didPerformFirstNavigation):
  • WebFrame.h:
4:53 PM Changeset in webkit [25429] by adele
  • 6 edits
    2 adds in trunk

WebCore:

Reviewed by Dave Harrison.

Fix for <rdar://problem/5428427> Wrong characters are re-converted after doing reconversion with Kotoeri

Revert change for<rdar://problem/5279521> and add nil checks for the result of TextIterator::rangeFromLocationAndLength
TextIterator::exitNode shouldn't require the m_lastTextNode to be true, but we can't change that without making the logic in _web_attributedStringFromRange match.
We'll get that for free when we switch to use TextIterator in _web_attributedStringFromRange.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Added nil checks.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): ditto.
  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Re-added check for m_lastTextNode before emitting newline.

LayoutTests:

Reviewed by Dave Harrison.

Tests for <rdar://problem/5428427> Wrong characters are re-converted after doing reconversion with Kotoeri

  • platform/mac/fast/text/attributed-substring-from-range-002-expected.txt: Added.
  • platform/mac/fast/text/attributed-substring-from-range-002.html: Added.
  • fast/forms/textarea-type-spaces-expected.txt: Revert back to old result.
4:45 PM Changeset in webkit [25428] by adachan
  • 2 edits in trunk/WebKit/win

Need to let the OS handle Alt+F4.

Reviewed by Hyatt.

  • WebView.cpp: (WebView::keyUp): (WebView::keyDown):
3:46 PM Changeset in webkit [25427] by andersca
  • 2 edits in trunk/WebKit/win

Reviewed by Oliver.

<rdar://problem/5461487>
Seed: Embedded media content (Flash Player 9) inside RSS reported as unknown MIME type.


Don't return ObjectContentNone if the URL's extension can't be mapped to a MIME type. If the MIME type is empty,
we will try to display the content in a subframe instead, just like Mac WebKit.


  • WebFrame.cpp: (WebFrame::objectContentType):
3:39 PM Changeset in webkit [25426] by adachan
  • 6 edits in trunk

<rdar://problem/5395928> Need to be able to handle context menu item selection by index


Reviewed by Beth.

WebCore:

  • platform/ContextMenu.h: Added method to retrieve context menu item by index
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): call setPlatformDescription() since that will handle adding the MNS_NOTIFYBYPOS style to the context menu. (WebCore::contextMenuItemByIdOrPosition): helper method so we don't have to duplicate code between itemWithAction() and itemAtIndex(). (WebCore::ContextMenu::itemWithAction): (WebCore::ContextMenu::itemAtIndex): (WebCore::ContextMenu::setPlatformDescription): add MNS_NOTIFYBYPOS style to the context menu so we will get notified by menu position through WM_MENUCOMMAND when the item is selected.


WebKit/win:

  • WebView.cpp: (WebView::performContextMenuAction): performContextMenuAction() can now handle context menu item selection via WM_MENUCOMMAND (by specifying byPosition to be true). In that case, we get the ContextMenuItem by position rather than by action id. (WebViewWndProc): handle WM_MENUCOMMAND
  • WebView.h:
3:01 PM Changeset in webkit [25425] by weinig
  • 4 edits in trunk

WebKitTools:

Reviewed by Alice.

Strip trailing and leading space/newline characters from skiplist file names.

  • Scripts/run-webkit-tests:

LayoutTests:

  • platform/win/Skipped: fix typo
2:39 PM Changeset in webkit [25424] by aliceli1
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: removing a duplicated test
2:34 PM Changeset in webkit [25423] by aliceli1
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: moved a bunch of editing tests that actually succeed in both Debug and Release into a section at the end of the skip list. The reason I'm not just removing these tests from the skip list right now is because the windows bots are not stable and green yet, and I was asked to do this removal at a later time when regressions are easier to spot.
12:42 PM Changeset in webkit [25422] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Steve Falkenburg.

  • fix crash seen on Windows release builds
  • wtf/FastMalloc.cpp: Change pthread_getspecific optimization to be done only on the DARWIN platform. Also correct a couple reinterpret_cast that should be static_cast instead.
12:18 PM Changeset in webkit [25421] by justing
  • 7 edits
    8 adds in trunk

WebCore:

Reviewed by Darin.


<rdar://problem/5057506> Double-clicking after ToDo content doesn't select the paragraph break


  • editing/Selection.cpp: (WebCore::Selection::validate): Moved the code that moves across a paragraph boundary when expanding selections by word granularity from endOfWord to here. In the word and paragraph granularity cases, if the end of the selection is at the end of the last paragraph in the last cell of a block table, expand it so that it ends at the start of the paragraph after the table, instead of just after the table, so that ToDo content gets the same double/tripled click behavior that normal paragraphs get (added two testcases). When expanding the selection to include paragraph breaks, pass VisiblePosition::next true so that it doesn't change editability.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): Renamed the bool because it's now also used to keep non-editable positions non-editable. (WebCore::VisiblePosition::previous): Ditto. (WebCore::VisiblePosition::lastPositionWithSameEditabilityAtOrBefore): Renamed this function and made it also work with non-editable positions. (WebCore::VisiblePosition::firstPositionWithSameEditabilityAtOrAfter): Ditto.
  • editing/VisiblePosition.h:
  • editing/visible_units.cpp: (WebCore::endOfWord): Called the renamed function. (WebCore::previousWordPosition): Ditto. (WebCore::nextWordPosition): Ditto. (WebCore::startOfLine): Ditto. (WebCore::endOfLine): Ditto. (WebCore::previousSentencePosition): Ditto. (WebCore::nextSentencePosition): Ditto.

LayoutTests:

Reviewed by Darin.


<rdar://problem/5333725> -webkit-user-select: none makes selection difficult

  • editing/selection/5057506-2.html: Added.
  • editing/selection/5057506.html: Added.
  • platform/mac/editing/selection/5057506-2-expected.checksum: Added.
  • platform/mac/editing/selection/5057506-2-expected.png: Added.
  • platform/mac/editing/selection/5057506-2-expected.txt: Added.
  • platform/mac/editing/selection/5057506-expected.checksum: Added.
  • platform/mac/editing/selection/5057506-expected.png: Added.
  • platform/mac/editing/selection/5057506-expected.txt: Added.
12:07 PM Changeset in webkit [25420] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebDragClient.mm

Attempt to fix the PPC build.

12:04 PM Changeset in webkit [25419] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Sam

<rdar://problem/5089241> - ASSERT and other funky effects in IconLoader with large 404 pages

There were two problems:
1 - I originally didn't expect SubresourceLoader to keep pulling in data after it received a 404 response,

but if the server sends back a complex 404 page, the loader did just that. That could result in the
IconLoader "finishing" twice

2 - In this case, the long messy 404 page would be committed to the database as image data. This would

result in wasted space on disk, wasted space in RAM, and wasting processor time trying to parse 50k+
of HTML as image data

Fix is two parts - 1, monitor the "m_loadIsInProgress" flag and 2, make ::finishLoading() take an actual
SharedBuffer argument that is what should be committed to the database so the ResourceHandle is unnecessary

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): If the response is not valid, commit null data (WebCore::IconLoader::didFail): If we've already finished loading once (the 404 response), don't finish again! (WebCore::IconLoader::didFinishLoading): Ditto (WebCore::IconLoader::finishLoading): Take a SharedBuffer argumnt as the actual data to commit
  • loader/icon/IconLoader.h: Add a SharedBuffer arg to ::finishLoading()
10:59 AM Changeset in webkit [25418] by beidson
  • 1 edit in trunk/WebCore/platform/AutodrainedPool.h

Build fix (sigh)

10:49 AM Changeset in webkit [25417] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Darin

Inline the in-header definitions for non-Mac platforms

  • platform/AutodrainedPool.h: (WebCore::AutodrainedPool::AutodrainedPool): (WebCore::AutodrainedPool::~AutodrainedPool): (WebCore::AutodrainedPool::cycle):
10:39 AM Changeset in webkit [25416] by beidson
  • 2 edits
    4 adds in trunk/WebCore

Reviewed by Darin

Add some AutoreleasePool and Threading utilities in preparation for the multi-threaded
fix for <rdar://problem/5434431>

AutodrainedPool wraps an NSAutoreleasePool and tracks a "cycle" count. This allows clients
in WebCore to simply call ::cycle() and after a preset number of iterations the pool will drain
and recreate the underlying NSAutoreleasePool


Threading utilities include C++ wrappers for pthread mutexes and conditions, as well as a generic
"callOnMainThread()" function for any non-main thread to use.

  • platform/AutodrainedPool.h: Added. (WebCore::AutodrainedPool::AutodrainedPool): Empty implementations for all non-mac platforms (WebCore::AutodrainedPool::~AutodrainedPool): ditto (WebCore::AutodrainedPool::cycle): ditto
  • platform/mac/AutodrainedPool.mm: Added. (WebCore::AutodrainedPool::AutodrainedPool): (WebCore::AutodrainedPool::~AutodrainedPool): (WebCore::AutodrainedPool::cycle): Keep track of number of cycles, and drain/recreate the pool if the cycle limit is hit
  • platform/Threading.h: Added. (WebCore::Mutex::Mutex): C++ wrapper for pthread_mutex (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock): (WebCore::MutexLocker::MutexLocker): Handles automatically locking/unlocking a Mutex (for early returns from a function, for example) (WebCore::MutexLocker::~MutexLocker): (WebCore::ThreadCondition::ThreadCondition): C++ wrapper for pthread_condition (WebCore::ThreadCondition::~ThreadCondition): (WebCore::ThreadCondition::wait): (WebCore::ThreadCondition::signal): (WebCore::ThreadCondition::broadcast):
  • platform/mac/Threading.mm: Added. (-[WebCoreFunctionWrapper initWithFunction:]): Obj-C implementation of "callOnMainThread" (-[WebCoreFunctionWrapper _call]): (WebCore::callOnMainThread):
10:27 AM Changeset in webkit [25415] by adachan
  • 5 edits in trunk/WebKit/win

<rdar://problem/5453494> Better lifetime management of WebDataSource and WebDocumentLoader
The problem was that WebDataSource does not hold a strong reference to the WebDocumentLoader. If
a WebDataSource is still around after the loader has been destroyed, it'll just point to
a stale WebDocumentLoader.
To fix this without a circular reference, WebDataSource now holds a strong reference to the
WebDocumentLoader. The WebDocumentLoader holds a strong reference to the WebDataSource
until it's detached from the WebFrame. When the WebDataSource is destroyed, it'll notify
its WebDocumentLoader so the loader will clear any references to it.

Reviewed by Darin.

  • WebDataSource.cpp: (WebDataSource::~WebDataSource): call WebDocumentLoader::detachDataSource() so the loader will clear any references to this data source (WebDataSource::documentLoader): m_loader is now a RefPtr so we need to call get().
  • WebDataSource.h:
  • WebDocumentLoader.cpp: (WebDocumentLoader::WebDocumentLoader): initialize m_dataSource since it's no longer a COMPtr. (WebDocumentLoader::~WebDocumentLoader): release m_dataSource if necessary (WebDocumentLoader::setDataSource): add a reference to m_dataSource (WebDocumentLoader::dataSource): (WebDocumentLoader::detachDataSource): clear m_detachedDataSource. (WebDocumentLoader::attachToFrame): call setDataSource() so it'll add the reference to the data source if necessary. (WebDocumentLoader::detachFromFrame): release the reference to the data source
  • WebDocumentLoader.h:
10:21 AM Changeset in webkit [25414] by weinig
  • 2 edits
    18 moves in trunk/LayoutTests

Reviewed by Kevin McCullough.

Fix embarassing spelling mistakes.

  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe-expected.txt.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe.html.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open-expected.txt.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open.html.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe-expected.txt: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open-expected.txt: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-expected.txt.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change-expected.txt.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open-expected.txt.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-expected.txt: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change-expected.txt: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open-expected.txt: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open.html: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe-expected.txt.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe.html.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open-expected.txt.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open.html.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe-expected.txt: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe.html: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open-expected.txt: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open.html: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe-expected.txt.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe.html.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open-expected.txt.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open.html.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe-expected.txt: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe.html: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open-expected.txt: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open.html: Removed.
  • platform/win/Skipped:
9:52 AM Changeset in webkit [25413] by kmccullo
  • 5 edits
    1 move in trunk

JavaScriptCore:

Reviewed by Maciej.

  • Moved JSRetainPtr to the API.
  • API/JSRetainPtr.h: Copied from kjs/JSRetainPtr.h. (JSRetain): (JSRelease): (JSRetainPtr::JSRetainPtr): (JSRetainPtr::~JSRetainPtr): (JSRetainPtr::get): (JSRetainPtr::releaseRef): (JSRetainPtr::operator->): (JSRetainPtr::operator!): (JSRetainPtr::operator UnspecifiedBoolType): (::operator): (::adopt): (::swap): (swap): (operator==): (operator!=):
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/JSRetainPtr.h: Removed.

WebKitTools:

Reviewed by Maciej.

  • Changed Drosera to take advantage of the JSRetainPtr changes.
  • Drosera/DebuggerDocument.cpp: (DebuggerDocument::breakpointEditorHTML): (DebuggerDocument::evaluateScript): (DebuggerDocument::valueForScopeVariableNamed): (DebuggerDocument::log): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::toJSArray): (DebuggerDocument::callFunctionOnObject): (DebuggerDocument::logException):
  • Drosera/mac/DebuggerDocumentMac.mm: (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]): (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
9:29 AM Changeset in webkit [25412] by staikos
  • 4 edits in trunk

Fix typo in previous commit

7:49 AM Changeset in webkit [25411] by staikos
  • 6 edits in trunk

Patch from Qing Zhao to export more of the progress details and expose it from
QWebPage

Sep 6, 2007:

8:48 PM Changeset in webkit [25410] by tristan
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Maciej Stachowiak.


<rdar://problem/5333496> Back button stopped working on sfgate.com (14957)


This fix is specifically targted to address sfgate.com and reuters.com with minimal
impact to other areas of the frameloader. It does not cause any regression tests to fail.
I've added two layout tests: One to detect this particular bug, and one to address
a secondary issue: if an iframe navigation occurs during onload by a timeout an
additional history item is added, similarly to firefox. We tried to match firefox
more than IE with this fix but did gain a little bit of IE compatability.

Tests: http/tests/navigation/onload-navigation-iframe-timeout.html

http/tests/navigation/onload-navigation-iframe.html

  • dom/Document.h: (WebCore::Document::processingLoadEvent): Return the m_processingLoadEvent boolean so FrameLoader knows that the document is in the middle of calling <body onload>


  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
  • html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::createdByParser): (WebCore::HTMLFrameOwnerElement::setCreatedByParser): Added support for a new member variable of frame elements: m_createdByParser. This lets us specifically target the fix to only iframes created via JS and not in-document.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): Initialize m_navigationDuringLoad to false


(WebCore::FrameLoader::provisionalLoadStarted):
Determine if the load we're about to start is occuring during
an onload.


(WebCore::FrameLoader::updateHistoryForStandardLoad):
If the current frameloader is for a child frame, and the navigation is occuring
during an onload update the current history item rather than adding a new one.


  • loader/FrameLoader.h: Added a new member variable, m_navigationDuringLoad to track the navigation status during the on load, rather than trying to determine the status after (which is nearly impossible due to a new runloop spin).

LayoutTests:

Reviewed by Maciej Stachowiak.

  • http/tests/navigation/onload-navigation-iframe-expected.txt: Added.
  • http/tests/navigation/onload-navigation-iframe-timeout-expected.txt: Added.
  • http/tests/navigation/onload-navigation-iframe-timeout.html: Added.
  • http/tests/navigation/onload-navigation-iframe.html: Added.
7:53 PM Changeset in webkit [25409] by mjs
  • 4 edits
    1 delete in trunk/JavaScriptCore

Reviewed by Darin.


  • Remove single-threaded optimization for FastMalloc.


It does not appear to help anywhere but Mac OS X on PPC, due to
pthread_getspecific being slow there. On Intel, removing the
optimization results in a ~1.5% PLT speedup, a ~1-5% JS iBench
speedup, and a ~1.5% HTML iBench speedup. On PPC this change is a
speedup on some benchmarks, a slight hit on others.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/collector.cpp: (KJS::Collector::registerThread):
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_ThreadCache::GetCache): (WTF::TCMalloc_ThreadCache::GetCacheIfPresent): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary): (WTF::do_malloc):
  • wtf/FastMallocInternal.h: Removed.
7:02 PM Changeset in webkit [25408] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Kevin McCullough.

Update the Windows skiplist with the current failing tests.

  • platform/win/Skipped:
5:14 PM Changeset in webkit [25407] by sfalken
  • 1 copy in tags/Safari-523.4b

New tag.

5:14 PM Changeset in webkit [25406] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

3:38 PM Changeset in webkit [25405] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

The implementation of BackForwardList::clearPageCache() was removed in r21793.
It's now safe to remove it from the header.

  • history/BackForwardList.h: Removed clearPageCache().
3:34 PM Changeset in webkit [25404] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebDragClient.mm

Even better build fix.

3:17 PM Changeset in webkit [25403] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebDragClient.mm

Better build fix.

3:15 PM Changeset in webkit [25402] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebDragClient.mm

Build fix.

2:28 PM Changeset in webkit [25401] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Ada.

<rdar://problem/5457844>
Crash when using mouse wheel with plug-ins disabled.

Null check the widget.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
2:15 PM Changeset in webkit [25400] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Small tweak.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream):
2:12 PM Changeset in webkit [25399] by andersca
  • 2 edits
    1 move in trunk/LayoutTests

Reviewed by Mitz.

Re-enable and the npapi-response-headers.html test so it no longer
relies on the ordering of the requests being made.


  • http/tests/plugins/npapi-response-headers-expected.txt:
  • http/tests/plugins/npapi-response-headers.html: Copied from http/tests/plugins/npapi-response-headers.html.disabled.
  • http/tests/plugins/npapi-response-headers.html.disabled: Removed.
2:04 PM Changeset in webkit [25398] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam and Steve.

<rdar://problem/5459321>
ADOBE: Safari 3 on Windows is passing bogus values in stream->headers in NPP_NewStream, causing Flash Player to crash.


Serialize the headers into a stream and pass it to NPP_NewStream in stream->headers.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream):
  • plugins/win/PluginStreamWin.h:
1:57 PM Changeset in webkit [25397] by darin
  • 5 edits in trunk/WebCore

Reviewed by Hyatt.

Back out the willRemove() part of the previous patch.
It was incorrect and not needed to fix the bug anyway.

  • dom/Document.cpp: (WebCore::Document::detach): Remove willRemove().
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Put the willRemove() call back here where it was originally before the previous fix.
  • history/CachedPage.cpp: (WebCore::CachedPage::clear):
  • page/Frame.cpp: (WebCore::Frame::setView): (WebCore::Frame::setDocument): Added FIXMEs about the fact that we call detach() on the document but not willRemove().
1:43 PM Changeset in webkit [25396] by thatcher
  • 18 edits in trunk

WebCore:

Reviewed by Darin.

Changed the blocked exception log message to match AppKit's blocked exception message.

  • platform/mac/BlockExceptions.mm: (ReportBlockedObjCException):

WebKit:

Reviewed by Darin.

<rdar://problem/5443883> Uncaught Objective-C exceptions in WebKit clients lead to hard-to-diagnose crashes

Changed all the direct delegate calls to use helper functions that have direct access to
WebView's delegate objects. These helper methods will catch any ObjC exceptions and call
ReportDiscardedDelegateException to log the discarded exception. WebView's that have
catchesDelegateExceptions set to NO will not pay the cost of a @try/@catch. The delegate
forwarders also have the same behavior.

  • Misc/WebKitLogging.h:
  • Misc/WebKitLogging.m: (ReportDiscardedDelegateException):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]):
  • Plugins/WebNullPluginView.mm: (-[WebNullPluginView viewDidMoveToWindow]):
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog): (WebChromeClient::runModal): (WebChromeClient::toolbarsVisible): (WebChromeClient::statusbarVisible): (WebChromeClient::addMessageToConsole): (WebChromeClient::canRunBeforeUnloadConfirmPanel): (WebChromeClient::runBeforeUnloadConfirmPanel): (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::shouldInterruptJavaScript): (WebChromeClient::setStatusbarText): (WebChromeClient::print):
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::getCustomMenuFromDefaultItems): (WebContextMenuClient::contextMenuItemSelected):
  • WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag):
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithFrame:URL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::willCacheResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource):
  • WebView/WebHTMLView.mm: (-[WebHTMLView callDelegateDoCommandBySelectorIfNeeded:]): (-[WebHTMLView validateUserInterfaceItem:]):
  • WebView/WebPDFView.mm: (-[WebPDFView validateUserInterfaceItem:]): (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
  • WebView/WebView.mm: (-[WebView _openNewWindowWithRequest:]): (-[WebView _menuForElement:defaultItems:]): (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView _cacheResourceLoadDelegateImplementations]): (-[WebView _cacheFrameLoadDelegateImplementations]): (-[WebView _policyDelegateForwarder]): (-[WebView _UIDelegateForwarder]): (-[WebView _editingDelegateForwarder]): (-[WebView _scriptDebugDelegateForwarder]): (-[WebView _setCatchesDelegateExceptions:]): (-[WebView _catchesDelegateExceptions]): (-[_WebSafeForwarder initWithTarget:defaultTarget:]): (-[_WebSafeForwarder forwardInvocation:]): (-[_WebSafeForwarder methodSignatureForSelector:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView validateUserInterfaceItem:]): (-[WebView _headerHeight]): (-[WebView _footerHeight]): (-[WebView _drawHeaderInRect:]): (-[WebView _drawFooterInRect:]): (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (CallDelegate): (CallDelegateReturningFloat): (CallDelegateReturningBoolean): (CallUIDelegate): (CallUIDelegateReturningFloat): (CallUIDelegateReturningBoolean): (CallFrameLoadDelegate): (CallResourceLoadDelegate): (CallFormDelegate): (CallFormDelegateReturningBoolean):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
12:39 PM Changeset in webkit [25395] by darin
  • 5 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/5457865> REGRESSION (9A527): Safari crashes when opening a page that immediately redirects to a PDF

I don't know how to make an automated test that trips over this.

The immediate cause of this regression was making a back/forward list entry in
this case. Earlier, the quick redirect would not results in a separate entry.
That's possibly a bug too, but it's better to fix the crash first.

The page cache was putting the document into a strange state: Still attached but
with the renderer set to 0. There was no good reason to do this, so got rid of it.
Moved the responsibility to the caller of not calling detach() when moving into
the page cache. This is more of a frame loader thing than a document thing.

  • dom/Document.cpp: (WebCore::Document::detach): Added assertions that this is only called on a document that's attached and not in the page cache. Also moved the call to willRemove in here, so that callers can't make the mistake of not calling that function. Removed the incorrectly-positioned code that made this function do less if it was called on a document in the page cache.
  • history/CachedPage.cpp: (WebCore::CachedPage::clear): Removed the code to handle a document with a renderer of 0. There was no need to put the document into this state. Any document in the page cache will always be "attached".
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Added a check to prevent from calling an unnecessary cancelParsing() on a document that's in the page cache and guard the call to detach() with a check of attached(), like all other calls to detach() on DOM objects.
  • page/Frame.cpp: (WebCore::Frame::setView): Added a missing check of attached(), like all other calls to detach() on DOM objects. Also added code to not call detach() on the document when it's in the page cache. (WebCore::Frame::setDocument): This call site already had the attached() check, but was missing the page cache check.
11:48 AM Changeset in webkit [25394] by kmccullo
  • 14 edits
    1 copy
    3 adds in trunk

JavaScriptCore:

Reviewed by Adam, Sam, Darin.

  • Created a JSRetainPtr specifically for JSStringRefs so they can be automatically refed and derefed.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/JSRetainPtr.h: Copied from wtf/RetainPtr.h. (KJS::JSRetain): (KJS::JSRelease): (KJS::): (KJS::JSRetainPtr::JSRetainPtr): (KJS::JSRetainPtr::~JSRetainPtr): (KJS::JSRetainPtr::get): (KJS::JSRetainPtr::releaseRef): (KJS::JSRetainPtr::operator->): (KJS::JSRetainPtr::operator UnspecifiedBoolType): (KJS::::operator): (KJS::::adopt): (KJS::::swap): (KJS::swap): (KJS::operator==): (KJS::operator!=):

WebKitTools:

Reviewed by Adam, Sam, Darin.

  • Separated what is platform dependant from what is not. Creating the structure needed for Drosera for Win.
  • Drosera/Debugger.h: Added.
  • Drosera/DebuggerDocument.cpp: (DebuggerDocument::breakpointEditorHTMLCallback): (DebuggerDocument::isPausedCallback): (DebuggerDocument::pauseCallback): (DebuggerDocument::resumeCallback): (DebuggerDocument::stepIntoCallback): (DebuggerDocument::evaluateScriptCallback): (DebuggerDocument::currentFunctionStackCallback): (DebuggerDocument::localScopeVariableNamesForCallFrameCallback): (DebuggerDocument::valueForScopeVariableNamedCallback): (DebuggerDocument::logCallback): (DebuggerDocument::breakpointEditorHTML): (DebuggerDocument::isPaused): (DebuggerDocument::pause): (DebuggerDocument::resume): (DebuggerDocument::stepInto): (DebuggerDocument::evaluateScript): (DebuggerDocument::currentFunctionStack): (DebuggerDocument::localScopeVariableNamesForCallFrame): (DebuggerDocument::valueForScopeVariableNamed): (DebuggerDocument::log): (DebuggerDocument::toolbarPause): (DebuggerDocument::toolbarResume): (DebuggerDocument::toolbarStepInto): (DebuggerDocument::toolbarStepOver): (DebuggerDocument::toolbarStepOut): (DebuggerDocument::toolbarShowConsole): (DebuggerDocument::toolbarCloseCurrentFile): (DebuggerDocument::updateFileSource): (DebuggerDocument::didParseScript): (DebuggerDocument::willExecuteStatement): (DebuggerDocument::didEnterCallFrame): (DebuggerDocument::willLeaveCallFrame): (DebuggerDocument::exceptionWasRaised): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::toJSArray): (DebuggerDocument::callGlobalFunction): (DebuggerDocument::callFunctionOnObject): (DebuggerDocument::getDroseraJSClass): (DebuggerDocument::staticFunctions): (DebuggerDocument::logException):
  • Drosera/DebuggerDocument.h: (DebuggerDocument::DebuggerDocument):
  • Drosera/ForwardingHeaders: Added.
  • Drosera/ForwardingHeaders/wtf: Added.
  • Drosera/ForwardingHeaders/wtf/Platform.h: Added.
  • Drosera/config.h:
  • Drosera/console.html:
  • Drosera/console.js:
  • Drosera/debugger.js:
  • Drosera/mac/DebuggerApplication.mm: (-[DebuggerApplication attach:]):
  • Drosera/mac/DebuggerDocumentMac.h:
  • Drosera/mac/DebuggerDocumentMac.mm: (+[NSString stringOrNilFromWebScriptResult:]): (+[DebuggerClientMac log:]): (-[DebuggerClientMac initWithServerName:]): (-[DebuggerClientMac dealloc]): (-[DebuggerClientMac pause]): (-[DebuggerClientMac resume]): (-[DebuggerClientMac pause:]): (-[DebuggerClientMac resume:]): (-[DebuggerClientMac stepInto:]): (-[DebuggerClientMac stepOver:]): (-[DebuggerClientMac stepOut:]): (-[DebuggerClientMac showConsole:]): (-[DebuggerClientMac closeCurrentFile:]): (-[DebuggerClientMac validateUserInterfaceItem:]): (-[DebuggerClientMac webView:windowScriptObjectAvailable:]): (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]): (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::platformCurrentFunctionStack): (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
11:42 AM Changeset in webkit [25393] by oliver
  • 1 edit in trunk/LayoutTests/ChangeLog

Appease Sam[e]

11:42 AM Changeset in webkit [25392] by oliver
  • 1 edit
    2 moves
    3 adds in trunk/LayoutTests

Reviewed by Same and Darin


Split the wrapper test into seperate Obj-C and JS tests so the we can use the JS tests on other platforms.

  • fast/dom/resources/wrapper-identity-base.js: Added -- This provides the basic utility functions and variables needed for the wrapper tests
  • fast/dom/wrapper-identity-expected.txt: Added.
  • fast/dom/wrapper-identity.html: Added.
  • platform/mac/fast/dom/objc-wrapper-identity-expected.txt: Copied from platform/mac/fast/dom/wrapper-identity-expected.txt.
  • platform/mac/fast/dom/objc-wrapper-identity.html: Copied from platform/mac/fast/dom/wrapper-identity.html.
  • platform/mac/fast/dom/wrapper-identity-expected.txt: Removed.
  • platform/mac/fast/dom/wrapper-identity.html: Removed.
11:11 AM Changeset in webkit [25391] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Adam Roben.

Add fast/frames/onload-remove-iframe-crash.html to the windows skiplist becuase it currently crashes.

  • platform/win/Skipped:
11:07 AM Changeset in webkit [25390] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Register the WebKit DLL on initialization of the DumpRenderTree.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize):
10:05 AM Changeset in webkit [25389] by staikos
  • 2 edits in trunk/WebKitQt

Make popup windows work again

9:56 AM Changeset in webkit [25388] by harrison
  • 1 edit in trunk/WebCore/editing/TextIterator.cpp

Check in source change now that I committed the changelog!

9:55 AM Changeset in webkit [25387] by harrison
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Darin.

Follow up on my fix for <rdar://problem/5306171>.
My first patch (r25373) broke svg/custom/stroke-width-click.svg.

  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Add currPos.isNotNull() check because positions in non-html content (like svg) do not have visible positions, and we don't want to emit for them either.
9:55 AM BuildingQtOnLinux edited by technomancy@gmail.com
libicu36-dev dependency (diff)
5:20 AM Changeset in webkit [25386] by bdash
  • 6 edits in trunk/WebCore

2007-09-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adam Roben.

  • platform/PlatformString.h: (WebCore::String::defaultWritingDirection):
  • platform/StringImpl.cpp: (WebCore::StringImpl::defaultWritingDirection): Moved textDirectionForParagraph() from RenderMenuList.cpp here.
  • platform/StringImpl.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural): Changed to return 'true'. (WebCore::PopupMenu::paint): Changed to use natural directionality for menu items.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Use defaultWritingDirection.
3:31 AM Changeset in webkit [25385] by mjs
  • 1 edit
    1 add in trunk/WebKitSite

Forgot the JS file.

  • misc/WebKitDetect.js: Added.
3:09 AM Changeset in webkit [25384] by mjs
  • 1 edit
    1 add in trunk/WebKitSite

Not reviewed - copy of WebKitDetect script from wiki

  • misc/WebKitDetect.html: Added.
2:25 AM Changeset in webkit [25383] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fixed <rdar://problem/5455457> REGRESSION (9A527-9A535): Colloquy crash on launch in WebCoreScriptDebugger initWithDelegate (with announce.js plug-in installed)
  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): Ensure that -[WebView windowScriptObject] and -[WebFrame windowObject] return null until the windowScriptObjectAvailable: delegate method is sent.

Sep 5, 2007:

9:34 PM Changeset in webkit [25382] by oliver
  • 2 edits
    42 copies in trunk/LayoutTests

Reviewed by Stephanie.

Moved a number of tests from platform/mac that are not currently cross-platform,
but should eventually be updated to work across all platforms.

  • editing/deleting/5300379-expected.checksum: Copied from platform/mac/editing/deleting/5300379-expected.checksum.
  • editing/deleting/5300379-expected.png: Copied from platform/mac/editing/deleting/5300379-expected.png.
  • editing/deleting/5300379-expected.txt: Copied from platform/mac/editing/deleting/5300379-expected.txt.
  • editing/deleting/5300379.html: Copied from platform/mac/editing/deleting/5300379.html.
  • editing/deleting/delete-to-end-of-paragraph-expected.checksum: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum.
  • editing/deleting/delete-to-end-of-paragraph-expected.png: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png.
  • editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt.
  • editing/deleting/delete-to-end-of-paragraph.html: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph.html.
  • editing/deleting/smart-delete-003-expected.checksum: Copied from platform/mac/editing/deleting/smart-delete-003-expected.checksum.
  • editing/deleting/smart-delete-003-expected.png: Copied from platform/mac/editing/deleting/smart-delete-003-expected.png.
  • editing/deleting/smart-delete-003-expected.txt: Copied from platform/mac/editing/deleting/smart-delete-003-expected.txt.
  • editing/deleting/smart-delete-003.html: Copied from platform/mac/editing/deleting/smart-delete-003.html.
  • editing/deleting/smart-delete-004-expected.checksum: Copied from platform/mac/editing/deleting/smart-delete-004-expected.checksum.
  • editing/deleting/smart-delete-004-expected.png: Copied from platform/mac/editing/deleting/smart-delete-004-expected.png.
  • editing/deleting/smart-delete-004-expected.txt: Copied from platform/mac/editing/deleting/smart-delete-004-expected.txt.
  • editing/deleting/smart-delete-004.html: Copied from platform/mac/editing/deleting/smart-delete-004.html.
  • editing/execCommand/nsresponder-indent-expected.checksum: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.checksum.
  • editing/execCommand/nsresponder-indent-expected.png: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.png.
  • editing/execCommand/nsresponder-indent-expected.txt: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.txt.
  • editing/execCommand/nsresponder-indent.html: Copied from platform/mac/editing/execCommand/nsresponder-indent.html.
  • editing/execCommand/nsresponder-outdent-expected.checksum: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum.
  • editing/execCommand/nsresponder-outdent-expected.png: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.png.
  • editing/execCommand/nsresponder-outdent-expected.txt: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.txt.
  • editing/execCommand/nsresponder-outdent.html: Copied from platform/mac/editing/execCommand/nsresponder-outdent.html.
  • editing/selection/4947387-expected.checksum: Copied from platform/mac/editing/selection/4947387-expected.checksum.
  • editing/selection/4947387-expected.png: Copied from platform/mac/editing/selection/4947387-expected.png.
  • editing/selection/4947387-expected.txt: Copied from platform/mac/editing/selection/4947387-expected.txt.
  • editing/selection/4947387.html: Copied from platform/mac/editing/selection/4947387.html.
  • editing/selection/5195166-1-expected.checksum: Copied from platform/mac/editing/selection/5195166-1-expected.checksum.
  • editing/selection/5195166-1-expected.png: Copied from platform/mac/editing/selection/5195166-1-expected.png.
  • editing/selection/5195166-1-expected.txt: Copied from platform/mac/editing/selection/5195166-1-expected.txt.
  • editing/selection/5195166-1.html: Copied from platform/mac/editing/selection/5195166-1.html.
  • editing/selection/5195166-2-expected.checksum: Copied from platform/mac/editing/selection/5195166-2-expected.checksum.
  • editing/selection/5195166-2-expected.png: Copied from platform/mac/editing/selection/5195166-2-expected.png.
  • editing/selection/5195166-2-expected.txt: Copied from platform/mac/editing/selection/5195166-2-expected.txt.
  • editing/selection/5195166-2.html: Copied from platform/mac/editing/selection/5195166-2.html.
  • editing/selection/select-line-expected.txt: Copied from platform/mac/editing/selection/select-line-expected.txt.
  • editing/selection/select-line.html: Copied from platform/mac/editing/selection/select-line.html.
  • editing/selection/selection-actions-expected.checksum: Copied from platform/mac/editing/selection/selection-actions-expected.checksum.
  • editing/selection/selection-actions-expected.png: Copied from platform/mac/editing/selection/selection-actions-expected.png.
  • editing/selection/selection-actions-expected.txt: Copied from platform/mac/editing/selection/selection-actions-expected.txt.
  • editing/selection/selection-actions.html: Copied from platform/mac/editing/selection/selection-actions.html.
  • platform/win/Skipped:
6:47 PM Changeset in webkit [25381] by harrison
  • 5 edits in trunk/LayoutTests

Updated results for:
<rdar://problem/5306171> Mail: The first return after an attachment in multipart/mixed message is lost

  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
  • http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-to-javscript-url-expected.txt:
  • http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level-expected.txt:
5:32 PM Changeset in webkit [25380] by weinig
  • 3 edits in trunk/LayoutTests

Reviewed by Kevin McCullough.

Use correct part of the test for cross-platform testing.

  • plugins/bindings-test-expected.txt:
  • plugins/bindings-test.html:
4:57 PM Changeset in webkit [25379] by weinig
  • 4 edits
    1 copy
    1 add in trunk/LayoutTests

Reviewed by Geoff Garen.

Split out mac specific tests from plugins/bindings-test.html into its own test.

  • platform/mac/plugins/bindings-test-objc-expected.txt: Added.
  • platform/mac/plugins/bindings-test-objc.html: Copied from plugins/bindings-test.html.
  • platform/win/Skipped:
  • plugins/bindings-test-expected.txt:
  • plugins/bindings-test.html:
4:39 PM Changeset in webkit [25378] by oliver
  • 2 edits in trunk/LayoutTests

Reviewed by Adam and Niko.

Force run-webkit-tests to not run the tests in platform/mac

  • platform/win/Skipped:
4:02 PM Changeset in webkit [25377] by hyatt
  • 3 edits in trunk/WebKit/win

Fix ALT+key combos so that they go into the DOM.

3:39 PM Changeset in webkit [25376] by weinig
  • 4 edits in trunk/LayoutTests

Reviewed by Geoff Garen.

Don't log DumpRenderTree injected properties in fast/dom/Window/window-properties.html. This change makes
it pass on Windows so it can be removed from the Skipped list.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • platform/win/Skipped:
3:23 PM Changeset in webkit [25375] by zimmermann
  • 18 edits
    4 adds
    1 delete in branches/feature-branch/LayoutTests

Reviewed by Anders.

Fix paths to css style sheets in the last added files. Enable smallFonts.svg as it doesn't crash anymore.
Fix paths to external <use> element reference, to make Batik happy. (We don't support it, yet.)

1:58 PM Changeset in webkit [25374] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver.

Fix many layout test failures caused by r25364.
Set text size to standand size at the begining of each test matching the mac.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest):
1:46 PM Changeset in webkit [25373] by harrison
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Kevin Decker.

<rdar://problem/5306171> Mail: The first return after an attachment in multipart/mixed message is lost

Test added: editing/selection/toString-1.html


Source changes:

  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
  • Remove outdated and erroneous check for m_lastTextNode.
  • Fix VisiblePosition check to look for line diff. Simple position diff gives the wrong answer when the start is table/0 and the current is the first position inside the content of the table.

LayoutTests:

Reviewed by Kevin Decker.

Testcase for:
<rdar://problem/5306171> Mail: The first return after an attachment in multipart/mixed message is lost

  • editing/selection/toString-1-expected.txt: Added.
  • editing/selection/toString-1.html: Added.
1:36 PM webkit_xl.zip attached to DetectingWebKit by timothy@apple.com
Updated to detect mobile Safari.
1:34 PM webkit_normal.zip attached to DetectingWebKit by timothy@apple.com
Updated to detect mobile Safari.
1:25 PM Changeset in webkit [25372] by zimmermann
  • 3 edits
    5 adds in branches/feature-branch

Reviewed by Oliver.
Fix <mask> in userSpaceOnUse coordinates. Verified by new testcase taken from Batik.

11:45 AM Changeset in webkit [25371] by zimmermann
  • 20 edits in branches/feature-branch/WebCore

(Oops, forgot to commit WebCore/ changes!)
Reviewed by Oliver.

Rewrite text painting code path, to be based on "text chunks" instead of using the InlineBox* hierarchy.
This allows us to reuse paint servers as long as possible - and to actually paint in the way didacted by the spec.

This also implements advanced SVG text decorations (ie. stroked/filled decos with gradient/pattern).
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=7200 (Gradient appears and disappears in SVG when text is off screen)

Fixes paint server usage on text paths. (ie. styled text paths, with gradients/filters).

11:19 AM Changeset in webkit [25370] by zimmermann
  • 175 edits
    13 adds in branches/feature-branch/LayoutTests

Reviewed by Oliver.

Rewrite text painting code path, to be based on "text chunks" instead of using the InlineBox* hierarchy.
This allows us to reuse paint servers as long as possible - and to actually paint in the way didacted by the spec.

This also implements advanced SVG text decorations (ie. stroked/filled decos with gradient/pattern).
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=7200 (Gradient appears and disappears in SVG when text is off screen)

Fixes paint server usage on text paths. (ie. styled text paths, with gradients/filters).

7:24 AM Changeset in webkit [25369] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-09-05 Mark Rowe <​mrowe@apple.com>

Unreviewed Qt build fix.

  • wtf/unicode/qt4/UnicodeQt4.h: Fix the constness of the src argument to toUpper to prevent build failures.

Sep 4, 2007:

11:10 PM Changeset in webkit [25368] by bdash
  • 9 edits in trunk/WebCore

2007-09-04 Marvin Decker <​marv.decker@gmail.com>

Reviewed by Maciej Stachowiak.

​http://bugs.webkit.org/show_bug.cgi?id=15072
Bug 15072: Fix ImageDecoder.cpp to not copy incoming data

Change ImageDecoder::setData to take a SharedBuffer*.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::bytes): (WebCore::RGBA32Buffer::height): (WebCore::ImageDecoder::setData):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setData): (WebCore::GIFImageDecoder::frameCount): (WebCore::GIFImageDecoder::decode): (WebCore::GIFImageDecoder::decodingHalted): (WebCore::GIFImageDecoder::initFrameBuffer):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::setData): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::setData): (WebCore::PNGImageDecoder::decode): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/png/PNGImageDecoder.h:
10:16 PM Changeset in webkit [25367] by oliver
  • 2 edits
    76 moves
    6 adds
    3 deletes in trunk/LayoutTests

RS=Adam


Moving a number of mac specific tests into LayoutTests/platform/mac so that they
don't need to be in the windows Skiplist.


This includes most of the tests that used textInputController as it is a test
of the mac-specific NSTextInput API.

  • editing/deleting/5300379-expected.checksum: Removed.
  • editing/deleting/5300379-expected.png: Removed.
  • editing/deleting/5300379-expected.txt: Removed.
  • editing/deleting/5300379.html: Removed.
  • editing/deleting/delete-to-end-of-paragraph-expected.checksum: Removed.
  • editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
  • editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
  • editing/deleting/delete-to-end-of-paragraph.html: Removed.
  • editing/deleting/smart-delete-003-expected.checksum: Removed.
  • editing/deleting/smart-delete-003-expected.png: Removed.
  • editing/deleting/smart-delete-003-expected.txt: Removed.
  • editing/deleting/smart-delete-003.html: Removed.
  • editing/deleting/smart-delete-004-expected.checksum: Removed.
  • editing/deleting/smart-delete-004-expected.png: Removed.
  • editing/deleting/smart-delete-004-expected.txt: Removed.
  • editing/deleting/smart-delete-004.html: Removed.
  • editing/execCommand/nsresponder-indent-expected.checksum: Removed.
  • editing/execCommand/nsresponder-indent-expected.png: Removed.
  • editing/execCommand/nsresponder-indent-expected.txt: Removed.
  • editing/execCommand/nsresponder-indent.html: Removed.
  • editing/execCommand/nsresponder-outdent-expected.checksum: Removed.
  • editing/execCommand/nsresponder-outdent-expected.png: Removed.
  • editing/execCommand/nsresponder-outdent-expected.txt: Removed.
  • editing/execCommand/nsresponder-outdent.html: Removed.
  • editing/input/firstrectforcharacterrange-plain-expected.txt: Removed.
  • editing/input/firstrectforcharacterrange-plain.html: Removed.
  • editing/input/firstrectforcharacterrange-styled-expected.txt: Removed.
  • editing/input/firstrectforcharacterrange-styled.html: Removed.
  • editing/input/mac: Removed.
  • editing/input/mac/hangul-enter-confirms-and-sends-keypress-expected.txt: Removed.
  • editing/input/mac/hangul-enter-confirms-and-sends-keypress.html: Removed.
  • editing/input/mac/hangul.js: Removed.
  • editing/input/mac/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
  • editing/input/mac/kotoeri-enter-to-confirm-and-newline.html: Removed.
  • editing/input/mac/kotoeri.js: Removed.
  • editing/input/mac/logger.js: Removed.
  • editing/input/range-for-empty-document-expected.txt: Removed.
  • editing/input/range-for-empty-document.html: Removed.
  • editing/input/replace-invalid-range-expected.txt: Removed.
  • editing/input/replace-invalid-range.html: Removed.
  • editing/input/text-input-controller-expected.txt: Removed.
  • editing/input/text-input-controller.html: Removed.
  • editing/input/wrapped-line-char-rect-expected.txt: Removed.
  • editing/input/wrapped-line-char-rect.html: Removed.
  • editing/selection/4947387-expected.checksum: Removed.
  • editing/selection/4947387-expected.png: Removed.
  • editing/selection/4947387-expected.txt: Removed.
  • editing/selection/4947387.html: Removed.
  • editing/selection/5195166-1-expected.checksum: Removed.
  • editing/selection/5195166-1-expected.png: Removed.
  • editing/selection/5195166-1-expected.txt: Removed.
  • editing/selection/5195166-1.html: Removed.
  • editing/selection/5195166-2-expected.checksum: Removed.
  • editing/selection/5195166-2-expected.png: Removed.
  • editing/selection/5195166-2-expected.txt: Removed.
  • editing/selection/5195166-2.html: Removed.
  • editing/selection/select-line-expected.txt: Removed.
  • editing/selection/select-line.html: Removed.
  • editing/selection/selection-actions-expected.checksum: Removed.
  • editing/selection/selection-actions-expected.png: Removed.
  • editing/selection/selection-actions-expected.txt: Removed.
  • editing/selection/selection-actions.html: Removed.
  • fast/AppleScript: Removed.
  • fast/AppleScript/001-expected.txt: Removed.
  • fast/AppleScript/001.html: Removed.
  • fast/AppleScript/array-expected.txt: Removed.
  • fast/AppleScript/array.html: Removed.
  • fast/AppleScript/date-expected.txt: Removed.
  • fast/AppleScript/date.html: Removed.
  • fast/dom/character-index-for-point-expected.txt: Removed.
  • fast/dom/character-index-for-point.html: Removed.
  • fast/dom/wrapper-identity-expected.txt: Removed.
  • fast/dom/wrapper-identity.html: Removed.
  • fast/dom/wrapper-round-tripping-expected.txt: Removed.
  • fast/dom/wrapper-round-tripping.html: Removed.
  • fast/encoding/char-decoding-mac-expected.txt: Removed.
  • fast/encoding/char-decoding-mac.html: Removed.
  • fast/forms/attributed-strings-expected.txt: Removed.
  • fast/forms/attributed-strings.html: Removed.
  • fast/objc: Removed.
  • fast/objc/longlongTest-expected.txt: Removed.
  • fast/objc/longlongTest.html: Removed.
  • fast/text/attributed-substring-from-range-001-expected.txt: Removed.
  • fast/text/attributed-substring-from-range-001.html: Removed.
  • fast/text/attributed-substring-from-range-expected.txt: Removed.
  • fast/text/attributed-substring-from-range-in-textfield-expected.txt: Removed.
  • fast/text/attributed-substring-from-range-in-textfield.html: Removed.
  • fast/text/attributed-substring-from-range.html: Removed.
  • fast/text/justified-text-rect-expected.checksum: Removed.
  • fast/text/justified-text-rect-expected.png: Removed.
  • fast/text/justified-text-rect-expected.txt: Removed.
  • fast/text/justified-text-rect.html: Removed.
  • platform/mac/editing/deleting/5300379-expected.checksum: Copied from editing/deleting/5300379-expected.checksum.
  • platform/mac/editing/deleting/5300379-expected.png: Copied from editing/deleting/5300379-expected.png.
  • platform/mac/editing/deleting/5300379-expected.txt: Copied from editing/deleting/5300379-expected.txt.
  • platform/mac/editing/deleting/5300379.html: Copied from editing/deleting/5300379.html.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Copied from editing/deleting/delete-to-end-of-paragraph-expected.checksum.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Copied from editing/deleting/delete-to-end-of-paragraph-expected.png.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from editing/deleting/delete-to-end-of-paragraph-expected.txt.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph.html: Copied from editing/deleting/delete-to-end-of-paragraph.html.
  • platform/mac/editing/deleting/smart-delete-003-expected.checksum: Copied from editing/deleting/smart-delete-003-expected.checksum.
  • platform/mac/editing/deleting/smart-delete-003-expected.png: Copied from editing/deleting/smart-delete-003-expected.png.
  • platform/mac/editing/deleting/smart-delete-003-expected.txt: Copied from editing/deleting/smart-delete-003-expected.txt.
  • platform/mac/editing/deleting/smart-delete-003.html: Copied from editing/deleting/smart-delete-003.html.
  • platform/mac/editing/deleting/smart-delete-004-expected.checksum: Copied from editing/deleting/smart-delete-004-expected.checksum.
  • platform/mac/editing/deleting/smart-delete-004-expected.png: Copied from editing/deleting/smart-delete-004-expected.png.
  • platform/mac/editing/deleting/smart-delete-004-expected.txt: Copied from editing/deleting/smart-delete-004-expected.txt.
  • platform/mac/editing/deleting/smart-delete-004.html: Copied from editing/deleting/smart-delete-004.html.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.checksum: Copied from editing/execCommand/nsresponder-indent-expected.checksum.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.png: Copied from editing/execCommand/nsresponder-indent-expected.png.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.txt: Copied from editing/execCommand/nsresponder-indent-expected.txt.
  • platform/mac/editing/execCommand/nsresponder-indent.html: Copied from editing/execCommand/nsresponder-indent.html.
  • platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum: Copied from editing/execCommand/nsresponder-outdent-expected.checksum.
  • platform/mac/editing/execCommand/nsresponder-outdent-expected.png: Copied from editing/execCommand/nsresponder-outdent-expected.png.
  • platform/mac/editing/execCommand/nsresponder-outdent-expected.txt: Copied from editing/execCommand/nsresponder-outdent-expected.txt.
  • platform/mac/editing/execCommand/nsresponder-outdent.html: Copied from editing/execCommand/nsresponder-outdent.html.
  • platform/mac/editing/input: Copied from editing/input/mac.
  • platform/mac/editing/input/firstrectforcharacterrange-plain-expected.txt: Copied from editing/input/firstrectforcharacterrange-plain-expected.txt.
  • platform/mac/editing/input/firstrectforcharacterrange-plain.html: Copied from editing/input/firstrectforcharacterrange-plain.html.
  • platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt: Copied from editing/input/firstrectforcharacterrange-styled-expected.txt.
  • platform/mac/editing/input/firstrectforcharacterrange-styled.html: Copied from editing/input/firstrectforcharacterrange-styled.html.
  • platform/mac/editing/input/range-for-empty-document-expected.txt: Copied from editing/input/range-for-empty-document-expected.txt.
  • platform/mac/editing/input/range-for-empty-document.html: Copied from editing/input/range-for-empty-document.html.
  • platform/mac/editing/input/replace-invalid-range-expected.txt: Copied from editing/input/replace-invalid-range-expected.txt.
  • platform/mac/editing/input/replace-invalid-range.html: Copied from editing/input/replace-invalid-range.html.
  • platform/mac/editing/input/text-input-controller-expected.txt: Copied from editing/input/text-input-controller-expected.txt.
  • platform/mac/editing/input/text-input-controller.html: Copied from editing/input/text-input-controller.html.
  • platform/mac/editing/input/wrapped-line-char-rect-expected.txt: Copied from editing/input/wrapped-line-char-rect-expected.txt.
  • platform/mac/editing/input/wrapped-line-char-rect.html: Copied from editing/input/wrapped-line-char-rect.html.
  • platform/mac/editing/selection/4947387-expected.checksum: Copied from editing/selection/4947387-expected.checksum.
  • platform/mac/editing/selection/4947387-expected.png: Copied from editing/selection/4947387-expected.png.
  • platform/mac/editing/selection/4947387-expected.txt: Copied from editing/selection/4947387-expected.txt.
  • platform/mac/editing/selection/4947387.html: Copied from editing/selection/4947387.html.
  • platform/mac/editing/selection/5195166-1-expected.checksum: Copied from editing/selection/5195166-1-expected.checksum.
  • platform/mac/editing/selection/5195166-1-expected.png: Copied from editing/selection/5195166-1-expected.png.
  • platform/mac/editing/selection/5195166-1-expected.txt: Copied from editing/selection/5195166-1-expected.txt.
  • platform/mac/editing/selection/5195166-1.html: Copied from editing/selection/5195166-1.html.
  • platform/mac/editing/selection/5195166-2-expected.checksum: Copied from editing/selection/5195166-2-expected.checksum.
  • platform/mac/editing/selection/5195166-2-expected.png: Copied from editing/selection/5195166-2-expected.png.
  • platform/mac/editing/selection/5195166-2-expected.txt: Copied from editing/selection/5195166-2-expected.txt.
  • platform/mac/editing/selection/5195166-2.html: Copied from editing/selection/5195166-2.html.
  • platform/mac/editing/selection/select-line-expected.txt: Copied from editing/selection/select-line-expected.txt.
  • platform/mac/editing/selection/select-line.html: Copied from editing/selection/select-line.html.
  • platform/mac/editing/selection/selection-actions-expected.checksum: Copied from editing/selection/selection-actions-expected.checksum.
  • platform/mac/editing/selection/selection-actions-expected.png: Copied from editing/selection/selection-actions-expected.png.
  • platform/mac/editing/selection/selection-actions-expected.txt: Copied from editing/selection/selection-actions-expected.txt.
  • platform/mac/editing/selection/selection-actions.html: Copied from editing/selection/selection-actions.html.
  • platform/mac/fast/AppleScript: Copied from fast/AppleScript.
  • platform/mac/fast/dom: Added.
  • platform/mac/fast/dom/character-index-for-point-expected.txt: Copied from fast/dom/character-index-for-point-expected.txt.
  • platform/mac/fast/dom/character-index-for-point.html: Copied from fast/dom/character-index-for-point.html.
  • platform/mac/fast/dom/wrapper-identity-expected.txt: Copied from fast/dom/wrapper-identity-expected.txt.
  • platform/mac/fast/dom/wrapper-identity.html: Copied from fast/dom/wrapper-identity.html.
  • platform/mac/fast/dom/wrapper-round-tripping-expected.txt: Copied from fast/dom/wrapper-round-tripping-expected.txt.
  • platform/mac/fast/dom/wrapper-round-tripping.html: Copied from fast/dom/wrapper-round-tripping.html.
  • platform/mac/fast/encoding: Added.
  • platform/mac/fast/encoding/char-decoding-mac-expected.txt: Copied from fast/encoding/char-decoding-mac-expected.txt.
  • platform/mac/fast/encoding/char-decoding-mac.html: Copied from fast/encoding/char-decoding-mac.html.
  • platform/mac/fast/forms: Added.
  • platform/mac/fast/forms/attributed-strings-expected.txt: Copied from fast/forms/attributed-strings-expected.txt.
  • platform/mac/fast/forms/attributed-strings.html: Copied from fast/forms/attributed-strings.html.
  • platform/mac/fast/objc: Copied from fast/objc.
  • platform/mac/fast/text: Added.
  • platform/mac/fast/text/attributed-substring-from-range-001-expected.txt: Copied from fast/text/attributed-substring-from-range-001-expected.txt.
  • platform/mac/fast/text/attributed-substring-from-range-001.html: Copied from fast/text/attributed-substring-from-range-001.html.
  • platform/mac/fast/text/attributed-substring-from-range-expected.txt: Copied from fast/text/attributed-substring-from-range-expected.txt.
  • platform/mac/fast/text/attributed-substring-from-range-in-textfield-expected.txt: Copied from fast/text/attributed-substring-from-range-in-textfield-expected.txt.
  • platform/mac/fast/text/attributed-substring-from-range-in-textfield.html: Copied from fast/text/attributed-substring-from-range-in-textfield.html.
  • platform/mac/fast/text/attributed-substring-from-range.html: Copied from fast/text/attributed-substring-from-range.html.
  • platform/mac/fast/text/justified-text-rect-expected.checksum: Copied from fast/text/justified-text-rect-expected.checksum.
  • platform/mac/fast/text/justified-text-rect-expected.png: Copied from fast/text/justified-text-rect-expected.png.
  • platform/mac/fast/text/justified-text-rect-expected.txt: Copied from fast/text/justified-text-rect-expected.txt.
  • platform/mac/fast/text/justified-text-rect.html: Copied from fast/text/justified-text-rect.html.
  • platform/mac/plugins: Added.
  • platform/mac/plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Copied from plugins/pluginDocumentView-deallocated-dataSource-expected.txt.
  • platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html: Copied from plugins/pluginDocumentView-deallocated-dataSource.html.
  • platform/win/Skipped:
  • plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Removed.
  • plugins/pluginDocumentView-deallocated-dataSource.html: Removed.
10:15 PM Changeset in webkit [25366] by mjs
  • 4 edits
    1 add in trunk/JavaScriptCore

Back out accidentally committed change.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/collector.cpp: (KJS::Collector::registerThread):
  • wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded): (WTF::TCMalloc_ThreadCache::GetCache): (WTF::TCMalloc_ThreadCache::GetCacheIfPresent): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary): (WTF::do_malloc):
  • wtf/FastMallocInternal.h: Added.
10:01 PM Changeset in webkit [25365] by mjs
  • 8 edits
    1 add
    1 delete in trunk/JavaScriptCore

Reviewed by Darin.


  • Added Vector::appendRange(), which appends to a vector based on a given start and end iterator
  • Added keys() and values() functions to HashMap iterators, which give keys-only and values-only iterators


Together, these allow easy copying of a set, or the keys or values of a map, into a Vector. Examples:


HashMap<int, int> map;
HashSet<int> set;
Vector<int> vec;
...
vec.appendRange(set.begin(), set.end());
vec.appendRange(map.begin().keys(), map.end().keys());
vec.appendRange(map.begin().values(), map.end().values());

This also allows for a slightly nicer syntax when iterating a map. Instead of saying
(*it)->first, you can say *it.values(). Similarly for keys. Example:


HashMap<int, int>::const_iterator end = map.end();
for (HashMap<int, int>::const_iterator it = map.begin(); it != end; ++it)
printf(" [%d => %d]", *it.keys(), *it.values());

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/HashIterators.h: Added. (WTF::): (WTF::HashTableConstKeysIterator::HashTableConstKeysIterator): (WTF::HashTableConstKeysIterator::get): (WTF::HashTableConstKeysIterator::operator*): (WTF::HashTableConstKeysIterator::operator->): (WTF::HashTableConstKeysIterator::operator++): (WTF::HashTableConstValuesIterator::HashTableConstValuesIterator): (WTF::HashTableConstValuesIterator::get): (WTF::HashTableConstValuesIterator::operator*): (WTF::HashTableConstValuesIterator::operator->): (WTF::HashTableConstValuesIterator::operator++): (WTF::HashTableKeysIterator::HashTableKeysIterator): (WTF::HashTableKeysIterator::get): (WTF::HashTableKeysIterator::operator*): (WTF::HashTableKeysIterator::operator->): (WTF::HashTableKeysIterator::operator++): (WTF::HashTableKeysIterator::operator HashTableConstKeysIterator<HashTableType, KeyType, MappedType>): (WTF::HashTableValuesIterator::HashTableValuesIterator): (WTF::HashTableValuesIterator::get): (WTF::HashTableValuesIterator::operator*): (WTF::HashTableValuesIterator::operator->): (WTF::HashTableValuesIterator::operator++): (WTF::HashTableValuesIterator::operator HashTableConstValuesIterator<HashTableType, KeyType, MappedType>): (WTF::operator==): (WTF::operator!=):
  • wtf/HashTable.h:
  • wtf/Vector.h: (WTF::::appendRange):
8:58 PM Changeset in webkit [25364] by weinig
  • 4 edits in trunk

WebKitTools:

Reviewed by Adam.

Fix for <rdar://problem/5382277>
Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (textZoomInCallback): (textZoomOutCallback):

LayoutTests:

Reviewed by Adam.

Fix for <rdar://problem/5382277>
Remove fast/css/ignore-text-zoom.html from skip list now that
eventSender.textZoomIn is supported.

  • platform/win/Skipped:
5:25 PM Changeset in webkit [25363] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5452908> NIBs saved in the Pre-10.2 format while Safari 3 installed do not work without Safari 3

This happened because we encoded a new field that the old WebKit does not know how to read.
And NSCoder throws an exception if initWithCoder finishes while there is still unread data in the archive.

The WebViewVersion is now 4 to distinguish that we do not encode/decode allowsUndo.

  • WebView/WebView.mm: (-[WebView initWithCoder:]): Only try to read allowsUndo if the version is 3. (-[WebView encodeWithCoder:]): No longer encode allowsUndo.
5:16 PM Changeset in webkit [25362] by weinig
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebKit.vcproj/WebKit.vcproj:
4:23 PM Changeset in webkit [25361] by hyatt
  • 1 edit in trunk/WebCore/page/Frame.cpp

Fix build bustage.

3:58 PM Changeset in webkit [25360] by hyatt
  • 12 edits in trunk

WebCore:

Fix for <rdar://problem/5271213>, resizing iChat window is slower than in
Tiger. This patch implements a fast scaling mode that can be used by
WebViews, e.g., during window resizing.

Reviewed by John Sullivan

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Frame.cpp: (WebCore::FramePrivate::FramePrivate):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::inLowQualityImageInterpolationMode): (WebCore::Page::setInLowQualityImageInterpolationMode):
  • page/Page.h:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage):
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::setUseLowQualityImageInterpolation): (WebCore::GraphicsContext::useLowQualityImageInterpolation):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setUseLowQualityImageInterpolation): (WebCore::GraphicsContext::useLowQualityImageInterpolation):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):

WebKit:

Fix for <rdar://problem/5271213>, resizing iChat window is slower than in
Tiger. This patch implements a fast scaling mode that can be used by
WebViews, e.g., during window resizing.

Reviewed by John Sullivan

  • WebView/WebView.mm: (-[WebView _setUseFastImageScalingMode:]): (-[WebView _inFastImageScalingMode]):
  • WebView/WebViewPrivate.h:
3:47 PM Changeset in webkit [25359] by darin
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

  • WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): Added missing null check. (-[WebView _setInitiatedDrag:]): Ditto. (-[WebView _clearUndoRedoOperations]): Ditto. (-[WebView encodeWithCoder:]): Ditto. (-[WebView backForwardList]): Ditto. (-[WebView setMaintainsBackForwardList:]): Ditto.
3:14 PM Changeset in webkit [25358] by adele
  • 3 edits in trunk/LayoutTests

Updated test for <rdar://problem/5279521>. The old test didn't crash before the fix.

  • editing/style/5279521.html:
  • editing/style/5279521-expected.txt:
2:56 PM Changeset in webkit [25357] by beidson
  • 1 edit in trunk/WebCore/loader/icon/SQLDatabase.h

Blind attempt at fixing Windows debug build

1:32 PM Changeset in webkit [25356] by beidson
  • 6 edits in trunk/WebCore

Reviewed by Adam

Some SQLite tweaks for debugging
-In debug builds, track the thread that opened the database and enforce that any statements

that operate on the SQLDatabase do so from the thread that opened it

-Track whether or not a transaction is in progress for the SQLDatabase to find cases where

someone opens a new transaction while there is still one outstanding (a SQLite logic error)

  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::SQLDatabase): (WebCore::SQLDatabase::open): Track the opening thread. Also, return false if the DB failed to open instead of trying to run a PRAGMA on it! (WebCore::SQLDatabase::close): Reset the opening thread
  • loader/icon/SQLDatabase.h: (WebCore::SQLDatabase::transactionInProgress): (WebCore::SQLDatabase::sqlite3Handle): For access to the raw sqlite3* handle to do a thread safety check
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): Use the new sqlite3Handle accessor (WebCore::SQLStatement::step): Ditto
  • loader/icon/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): Removed the c'tor form that could automatically begin the transaction - never used and shouldn't be in practice! (WebCore::SQLTransaction::begin): Maintain the transaction-in-progress flag on the DB (WebCore::SQLTransaction::commit): Ditto (WebCore::SQLTransaction::rollback): Ditto
  • loader/icon/SQLTransaction.h:
12:50 PM Changeset in webkit [25355] by tristan
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.


<rdar://problem/5454935> Can't reply to this message in Mail -- -[DOMRange webArchive] is throwing an exception

  • WebView/WebArchiver.mm: (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): Guard the creation of WebResource by ensuring that the passed in responseURL is never nil.
9:55 AM Changeset in webkit [25354] by harrison
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Maciej and John.

<rdar://problem/5452675> CrashTracer: [USER] 10 crashes in Mail at com.apple.WebCore: WebCore::Node::nodeIndex const + 6

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Adjust pos to pos.downstream() after the refNode is calculated, but before the insertion. Doing it earlier undid the logic of positionAvoidingSpecialElementBoundary(). The downstream is still needed just to set the ending selection.

LayoutTests:

Reviewed by Maciej and John.

Testcase for:
<rdar://problem/5452675> CrashTracer: [USER] 10 crashes in Mail at com.apple.WebCore: WebCore::Node::nodeIndex const + 6

  • editing/inserting/insert-paragraph-05.html: Added.
  • platform/mac/editing/inserting/insert-paragraph-05-expected.checksum: Added.
  • platform/mac/editing/inserting/insert-paragraph-05-expected.png: Added.
  • platform/mac/editing/inserting/insert-paragraph-05-expected.txt: Added.
7:50 AM Changeset in webkit [25353] by antti
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.


Fix <rdar://problem/5452112>
REGRESSION: Initially focused textfield on www.mac.com login page has no insertion point, and doesn't accept typed characters


Use updateLayoutIgnorePendingStylesheets() instead of updateLayout(). We need to have rendering to set input focus.

Test: fast/forms/focus-style-pending.html

  • dom/Element.cpp: (WebCore::Element::focus):

LayoutTests:

Reviewed by Maciej.


Test for <rdar://problem/5452112>
REGRESSION: Initially focused textfield on www.mac.com login page has no insertion point, and doesn't accept typed characters

  • fast/forms/focus-style-pending-expected.txt: Added.
  • fast/forms/focus-style-pending.html: Added.
6:02 AM Changeset in webkit [25352] by hausmann
  • 2 edits in trunk/WebCore

Fixed Qt build on Windows

Sep 3, 2007:

9:31 AM Changeset in webkit [25351] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker.

<rdar://problem/5456785> REGRESSION (r15963-r15970): Heading text not placed in VoiceOver Item Chooser (15132)

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject title]): For headings, return the text under the element instead of nil.
6:48 AM Changeset in webkit [25350] by zecke
  • 2 edits in trunk/WebCore

2007-08-20 Oleg Sukhodolsky <​son.two@gmail.com>

Reviewed by Mark.

WebKitQt/WebCoreSupport should not be added to INCLUDEPATH for gdk-port

  • WebCore.pro:
2:56 AM Changeset in webkit [25349] by bdash
  • 12 edits in trunk

2007-09-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5452164> Production build with in symbols directory has no debug info

Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.

  • Configurations/Base.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:

2007-09-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5452164> Production build with in symbols directory has no debug info

Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.

  • Configurations/Base.xcconfig:
  • JavaScriptGlue.xcodeproj/project.pbxproj:

2007-09-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5452164> Production build with in symbols directory has no debug info

Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.

  • Configurations/Base.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:

2007-09-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5452164> Production build with in symbols directory has no debug info

Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.

  • Configurations/Base.xcconfig:
  • WebKit.xcodeproj/project.pbxproj:

Sep 2, 2007:

6:37 PM Changeset in webkit [25348] by beidson
  • 8 edits in trunk

WebCore:

Reviewed by John Sullivan and Mark Rowe

Groundwork for support for monitoring IconDatabase in-memory statistics

  • WebCore.exp:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pageURLMappingCount): Stub for now (WebCore::IconDatabase::retainedPageURLCount): Ditto (WebCore::IconDatabase::iconRecordCount): Ditto (WebCore::IconDatabase::iconRecordCountWithData): Ditto
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by John Sullivan and Mark Rowe

Groundwork for support for monitoring IconDatabase in-memory statistics


  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics iconPageURLMappingCount]): (+[WebCoreStatistics iconRetainedPageURLCount]): (+[WebCoreStatistics iconRecordCount]): (+[WebCoreStatistics iconsWithDataCount]):
6:17 PM Changeset in webkit [25347] by bdash
  • 2 edits in trunk/WebCore

2007-09-02 Mark Rowe <​mrowe@apple.com>

Reviewed by Antti.

<rdar://problem/5454704> WebKit seems to get too-narrow widths for "Monotype Corsiva", so lays out incorrectly

  • platform/mac/FontDataMac.mm: (WebCore::FontData::determinePitch): Work around NSFont incorrectly reporting Monotype Corsiva as fixed pitch.
8:19 AM UsingSafari2WithSafari3PublicBetaInstalled created by ddkilzer@webkit.org
7:52 AM WikiStart edited by ddkilzer@webkit.org
(diff)

Sep 1, 2007:

9:44 PM Changeset in webkit [25346] by darin
  • 3 edits
    1 delete in trunk

WebCore:

  • rolled out fix for bug 12988 because it broke getElementById in a layout test I'm working on a new fix.
  • dom/Document.cpp: Rolled out.

LayoutTests:

  • rolled out the test case for 12988 until we re-fix it
  • fast/dom/duplicate-ids-document-order.html: Removed.
4:04 PM Changeset in webkit [25345] by oliver
  • 24 edits in trunk

gtk:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions


EditorClient::setInputMethodState stub

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState):
  • WebCoreSupport/EditorClientGtk.h:

WebCore:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

Adding a new EditorClient method so it is possible to inform WebKit of focus changes.
Also added new virtual method Node::shouldUseInputMethod to allow us to trivially check
whether an input method should be used when processing input for the currently focused
Node.

  • bridge/EditorClient.h:
  • dom/Node.cpp: (WebCore::Node::shouldUseInputMethod):
  • dom/Node.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::shouldUseInputMethod):
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::shouldUseInputMethod):
  • html/HTMLTextAreaElement.h:
  • page/FocusController.cpp: (WebCore::FocusController::setFocusedNode):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::setInputMethodState):

WebKit:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

EditorClient::setInputMethodState stub

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setInputMethodState):

WebKitQt:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions


EditorClient::setInputMethodState stub

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
  • WebCoreSupport/EditorClientQt.h:

win:

Reviewed by Sam.

<rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions


When focusing a password field or a non-editable element we disassociate any IME that may have
been active, and reassociate should a non-password editable element is focused.

This makes password input with an IME active simpler, and brings our IME behaviour in line with
IE.

  • WebEditorClient.cpp: (WebEditorClient::setInputMethodState):
  • WebEditorClient.h:
  • WebView.cpp: (IMMDict::IMMDict): (WebView::setInputMethodState):
  • WebView.h:
7:05 AM Changeset in webkit [25344] by bdash
  • 1 edit in tags/Safari-5523.3.1/WebKit/Configurations/Version.xcconfig

Versioning.

7:05 AM Changeset in webkit [25343] by bdash
  • 2 edits in tags/Safari-5523.3.1/WebKit

Merge r25300.

2007-08-29 Anders Carlsson <​andersca@apple.com>

Fix 64-bit build.

  • WebCoreSupport/WebFrameBridge.mm:
6:55 AM Changeset in webkit [25342] by bdash
  • 1 copy in tags/Safari-5523.3.1

New tag.

1:08 AM Changeset in webkit [25341] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first

Reset the element id cache when id's are added or removed and there
are duplicates for that id.

12:43 AM Changeset in webkit [25340] by rwlbuis
  • 9 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15083
Some symbols in WebKit do not need to be exported

Do not export these symbols.

Aug 31, 2007:

10:44 PM Changeset in webkit [25339] by sfalken
  • 2 edits in trunk/WebKit/win

<rdar://problem/5432594> Safari quits when hovering over mailto links on a webpage


In addition to substituting %@ with %s, we also need to substitute %{1-9}$@ with %{1-9}$s.

7:11 PM Changeset in webkit [25338] by bdash
  • 1 copy in tags/Safari-4523.3

New tag.

5:56 PM Changeset in webkit [25337] by sfalken
  • 1 copy in tags/Safari-523.3b

New tag.

5:56 PM Changeset in webkit [25336] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

4:02 PM Changeset in webkit [25335] by aliceli1
  • 5 edits
    4 adds in trunk

WebCore:

Reviewed by Tim Hatcher.

Fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Factored out the code in ::show() that created and styled the elements of the Deletion UI

(WebCore::DeleteButtonController::createDeletionUI):
Neglecting to move the append of the deletionUI elements into the same clause that handles the creation
of them ended up creating multiple elements at were repeatedly appended to the target, resulting in a
bloated table deletion UI which was slow to show and hide.

  • editing/DeleteButtonController.h: (WebCore::DeleteButtonController::enabled): Restore this function to how it used to be pre-r25305, sans asserts
  • editing/EditCommand.cpp: Add disable/enable sandwich when undoing/redoing commands too (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):

LayoutTests:

Reviewed by Tim Hatcher.

Test for <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box

  • editing/deleting/deletionUI-single-instance.html: Added.
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.checksum: Added.
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.png: Added.
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt: Added.
3:09 PM Changeset in webkit [25334] by antti
  • 3 edits in trunk/WebCore

Reviewed by Anders.

Fix <rdar://problem/5452943>
REGRESSION (r25283): Reproducible crash in HTMLObjectElement::getInstance under guard malloc


Calling updateLayoutIgnorePendingStylesheets() may do arbitrary things to render tree so
no RenderObjects can be cached over it.

  • html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer): (WebCore::HTMLEmbedElement::getInstance):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance):
2:57 PM Changeset in webkit [25333] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

<rdar://problem/5443936>
Crash after QT movie completes playback at apple.com/imac


If the plug-in or one of its children have focus, set it to NULL to prevent the web view window from getting the focus,
which can cause a layout to happen while in HTMLObjectElement::detach. (This is what we do on the Mac).


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setParent):
11:51 AM Changeset in webkit [25332] by adele
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Justin.

Fix for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)

Test: editing/pasteboard/paste-plaintext-user-select-none.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering): Copy the user-select style from the current selection node and apply it so it is considered during the test rendering. This is important since we recently changed user-select to be inherited. When we consider valid VisiblePositions for the test rendering, we need to have the correct user-select value that will actually be used for the real insertion.

LayoutTests:

Reviewed by Justin.

Test for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)

  • editing/pasteboard/paste-plaintext-user-select-none-expected.txt: Added.
  • editing/pasteboard/paste-plaintext-user-select-none.html: Added.
  • fast/forms/textarea-paste-newline.html: Updated to escape '\n' in failure description.
11:16 AM Changeset in webkit [25331] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5423939>
​http://bugs.webkit.org/show_bug.cgi?id=15013
ASSERTION FAILED !m_inDestructor in WebCore::Shared<WebCore::PluginStreamWin>::ref() on Windows


Protect the stream in case it's destroyed by the plug-in.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):
9:13 AM Changeset in webkit [25330] by darin
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode): Change assertion so that it only fires when actually modifying the selection. This isn't nearly as helpful, because the old assertion could catch potential problems in more cases, but it's not obvious how to do better.

Aug 30, 2007:

9:33 PM Changeset in webkit [25329] by oliver
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Adam.


<rdar://problem/5430772> REGRESSION(303-310A5) list items do not show with mouse over on istweb.apple.com/quack.apple.com


VC++ treats bitfields as signed members, so Node::m_styleChange would be
sign extended if it was assigned the value FullStyleChange. This caused
style recalculation to stop propagating.


We work around this VC++ oddity by storing the enum as an unsigned, and
casting back to StyleChangeType in the getter.


Test: fast/css/hover-affects-child.html

  • dom/Node.h: (WebCore::Node::styleChangeType):

LayoutTests:

Reviewed by Adam.


Simple test case to ensure that hover affects are correctly propagated

  • fast/css/hover-affects-child-expected.txt: Added.
  • fast/css/hover-affects-child.html: Added.
6:40 PM Changeset in webkit [25328] by justing
  • 1 edit in trunk/WebCore/editing/InsertParagraphSeparatorCommand.cpp

Fixing comma placement.

6:36 PM Changeset in webkit [25327] by justing
  • 9 edits
    14 adds
    11 deletes in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5368833>
REGRESSION: Pasting a triple-clicked line of quoted text at the top of a message adds an extra, quoted line

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertParagraphSeparator): Added an option for using a plain div to hold the new paragraph, instead of a clone of the previous block.
  • editing/CompositeEditCommand.h:
  • editing/InsertParagraphSeparatorCommand.cpp: Ditto. (WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Ditto. (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
  • editing/InsertParagraphSeparatorCommand.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Use a default block element when creating new paragraphs, so that empty paragraphs don't contain the block style of the previous one. Don't expand collapsed brs at the end of inserted content, this was the root of the bug. We'd copy <blockquote>hello<br></blockquote><br class="Apple-interchange-newline"> and get an extra paragraph. The removed code used to make sure that if the copied selection ends with a paragraph break that is represented in the copied markup by a regular br (not an interchange newline br), that that paragraph break appears in the pasted content, but shouldMergeEnd, which was introduced after this code was written, now takes care of that. (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Inserted content should always displace placeholder brs, even if that inserted content ends with a br.
  • editing/markup.cpp: (WebCore::needInterchangeNewlineAfter): This code failed to add an interchange newline if the user copied <div>hello</div><br>, only don't add an interchange newline when copying hello<br><br>, because then the copied paragraph break will already be represented in the copied markup by a br. (WebCore::createMarkup):

LayoutTests:

Reviewed by Darin.


<rdar://problem/5368833>
REGRESSION: Pasting a triple-clicked line of quoted text at the top of a message adds an extra, quoted line


Tested for behavior that we no longer want to have:

  • editing/pasteboard/quirks-mode-br-2-expected.checksum: Removed.
  • editing/pasteboard/quirks-mode-br-2-expected.png: Removed.
  • editing/pasteboard/quirks-mode-br-2-expected.txt: Removed.
  • editing/pasteboard/quirks-mode-br-2.html: Removed.


  • platform/mac/editing/pasteboard: Added.


Demonstrates bug:

  • editing/pasteboard/5368833.html: Added.
  • platform/mac/editing/pasteboard/5368833-expected.checksum: Added.
  • platform/mac/editing/pasteboard/5368833-expected.png: Added.
  • platform/mac/editing/pasteboard/5368833-expected.txt: Added.


Regenerated these expected results to reflect new behavior:

  • editing/pasteboard/paste-text-012-expected.checksum: Removed.
  • editing/pasteboard/paste-text-012-expected.png: Removed.
  • editing/pasteboard/paste-text-012-expected.txt: Removed.
  • editing/pasteboard/paste-text-013-expected.checksum: Removed.
  • editing/pasteboard/paste-text-016-expected.checksum: Removed.
  • editing/pasteboard/paste-text-016-expected.png: Removed.
  • editing/pasteboard/paste-text-016-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-012-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-text-012-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-text-012-expected.txt: Added.
  • platform/mac/editing/pasteboard/paste-text-013-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-text-013-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-text-013-expected.txt: Added.
  • platform/mac/editing/pasteboard/paste-text-016-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-text-016-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-text-016-expected.txt: Added.
6:04 PM Changeset in webkit [25326] by bdash
  • 10 edits in tags/Safari-5523.3

Merge r25283.

WebCore:

Reviewed by Darin.

<rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent

Restore the previous behavior, creating plug-ins on attach, for WebKit plug-ins. Netscape plug-ins
are still created during the first layout.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance): Only call layout if the renderer doesn't have a widget.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance): Likewise.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldUsePlugin): Update for enum change.
  • loader/FrameLoaderTypes.h: Add ObjectContentNetscapePlugin and ObjectContentOtherPlugin.
  • page/mac/WebCoreFrameBridge.h: Get rid of the enum here, we can use the one in FrameLoaderTypes.h
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Only create the plug-in if it's not a Netscape plug-in.

(WebCore::RenderPartObject::layout):
Fix indentation.

WebKit:

Reviewed by Darin.

<rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent

  • WebCoreSupport/WebFrameBridge.mm: Use the enum from FrameLoaderTypes.h.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): Return ObjectContentNetscapePlugin and ObjectContentOtherPlugin depending on the plug-in type.
5:58 PM Changeset in webkit [25325] by bdash
  • 4 edits in trunk

Versioning.

5:56 PM Changeset in webkit [25324] by bdash
  • 1 copy in tags/Safari-5523.3

New tag.

5:10 PM Changeset in webkit [25323] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5423900> Seed: safari crashes on submit feedback page in -[WebCoreAXObject isAttachment]

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isAttachment]): Add nil check since element could be detached.
3:38 PM Changeset in webkit [25322] by bdash
  • 110 edits in trunk

2007-08-30 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth): When measuring option text, use the same WebCore run rounding behavior that is used to draw it in the popup button.

2007-08-30 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • editing/pasteboard/4641033-expected.checksum:
  • editing/pasteboard/4641033-expected.png:
  • editing/pasteboard/4641033-expected.txt:
  • fast/forms/HTMLOptionElement_label02-expected.checksum:
  • fast/forms/HTMLOptionElement_label02-expected.png:
  • fast/forms/HTMLOptionElement_label02-expected.txt:
  • fast/forms/HTMLOptionElement_label03-expected.checksum:
  • fast/forms/HTMLOptionElement_label03-expected.png:
  • fast/forms/HTMLOptionElement_label03-expected.txt:
  • fast/forms/control-restrict-line-height-expected.checksum:
  • fast/forms/control-restrict-line-height-expected.png:
  • fast/forms/control-restrict-line-height-expected.txt:
  • fast/forms/menulist-restrict-line-height-expected.checksum:
  • fast/forms/menulist-restrict-line-height-expected.png:
  • fast/forms/menulist-restrict-line-height-expected.txt:
  • fast/forms/menulist-width-change-expected.checksum:
  • fast/forms/menulist-width-change-expected.png:
  • fast/forms/menulist-width-change-expected.txt:
  • fast/forms/select-change-listbox-to-popup-expected.checksum:
  • fast/forms/select-change-listbox-to-popup-expected.png:
  • fast/forms/select-change-listbox-to-popup-expected.txt:
  • fast/forms/select-disabled-appearance-expected.checksum:
  • fast/forms/select-disabled-appearance-expected.png:
  • fast/forms/select-disabled-appearance-expected.txt:
  • fast/forms/stuff-on-my-optgroup-expected.checksum:
  • fast/forms/stuff-on-my-optgroup-expected.png:
  • fast/forms/stuff-on-my-optgroup-expected.txt:
  • fast/parser/document-write-option-expected.checksum:
  • fast/parser/document-write-option-expected.png:
  • fast/parser/document-write-option-expected.txt:
  • http/tests/navigation/anchor-basic-expected.txt:
  • http/tests/navigation/anchor-frames-expected.txt:
  • http/tests/navigation/anchor-goback-expected.checksum:
  • http/tests/navigation/anchor-goback-expected.png:
  • http/tests/navigation/anchor-goback-expected.txt:
  • http/tests/navigation/anchor-subframeload-expected.txt:
  • http/tests/navigation/javascriptlink-basic-expected.checksum:
  • http/tests/navigation/javascriptlink-basic-expected.png:
  • http/tests/navigation/javascriptlink-basic-expected.txt:
  • http/tests/navigation/javascriptlink-frames-expected.txt:
  • http/tests/navigation/javascriptlink-goback-expected.checksum:
  • http/tests/navigation/javascriptlink-goback-expected.png:
  • http/tests/navigation/javascriptlink-goback-expected.txt:
  • http/tests/navigation/javascriptlink-subframeload-expected.txt:
  • http/tests/navigation/metaredirect-basic-expected.checksum:
  • http/tests/navigation/metaredirect-basic-expected.png:
  • http/tests/navigation/metaredirect-basic-expected.txt:
  • http/tests/navigation/metaredirect-frames-expected.txt:
  • http/tests/navigation/metaredirect-goback-expected.checksum:
  • http/tests/navigation/metaredirect-goback-expected.png:
  • http/tests/navigation/metaredirect-goback-expected.txt:
  • http/tests/navigation/metaredirect-subframeload-expected.txt:
  • http/tests/navigation/post-goback2-expected.checksum:
  • http/tests/navigation/post-goback2-expected.png:
  • http/tests/navigation/post-goback2-expected.txt:
  • http/tests/navigation/postredirect-goback2-expected.checksum:
  • http/tests/navigation/postredirect-goback2-expected.png:
  • http/tests/navigation/postredirect-goback2-expected.txt:
  • http/tests/navigation/redirect302-basic-expected.checksum:
  • http/tests/navigation/redirect302-basic-expected.png:
  • http/tests/navigation/redirect302-basic-expected.txt:
  • http/tests/navigation/redirect302-frames-expected.txt:
  • http/tests/navigation/redirect302-goback-expected.checksum:
  • http/tests/navigation/redirect302-goback-expected.png:
  • http/tests/navigation/redirect302-goback-expected.txt:
  • http/tests/navigation/redirect302-subframeload-expected.txt:
  • http/tests/navigation/relativeanchor-basic-expected.txt:
  • http/tests/navigation/relativeanchor-frames-expected.txt:
  • http/tests/navigation/relativeanchor-goback-expected.txt:
  • http/tests/navigation/slowmetaredirect-basic-expected.checksum:
  • http/tests/navigation/slowmetaredirect-basic-expected.png:
  • http/tests/navigation/slowmetaredirect-basic-expected.txt:
  • http/tests/navigation/slowtimerredirect-basic-expected.checksum:
  • http/tests/navigation/slowtimerredirect-basic-expected.png:
  • http/tests/navigation/slowtimerredirect-basic-expected.txt:
  • http/tests/navigation/success200-basic-expected.checksum:
  • http/tests/navigation/success200-basic-expected.png:
  • http/tests/navigation/success200-basic-expected.txt:
  • http/tests/navigation/success200-frames-expected.txt:
  • http/tests/navigation/success200-frames-loadsame-expected.txt:
  • http/tests/navigation/success200-goback-expected.checksum:
  • http/tests/navigation/success200-goback-expected.png:
  • http/tests/navigation/success200-goback-expected.txt:
  • http/tests/navigation/success200-loadsame-expected.checksum:
  • http/tests/navigation/success200-loadsame-expected.png:
  • http/tests/navigation/success200-loadsame-expected.txt:
  • http/tests/navigation/success200-reload-expected.checksum:
  • http/tests/navigation/success200-reload-expected.png:
  • http/tests/navigation/success200-reload-expected.txt:
  • http/tests/navigation/success200-subframeload-expected.txt:
  • http/tests/navigation/timerredirect-basic-expected.checksum:
  • http/tests/navigation/timerredirect-basic-expected.png:
  • http/tests/navigation/timerredirect-basic-expected.txt:
  • http/tests/navigation/timerredirect-frames-expected.txt:
  • http/tests/navigation/timerredirect-goback-expected.checksum:
  • http/tests/navigation/timerredirect-goback-expected.png:
  • http/tests/navigation/timerredirect-goback-expected.txt:
  • http/tests/navigation/timerredirect-subframeload-expected.txt:
  • tables/mozilla/bugs/bug33855-expected.checksum:
  • tables/mozilla/bugs/bug33855-expected.png:
  • tables/mozilla/bugs/bug33855-expected.txt:
  • tables/mozilla/dom/tableDom-expected.checksum:
  • tables/mozilla/dom/tableDom-expected.png:
  • tables/mozilla/dom/tableDom-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
3:33 PM Changeset in webkit [25321] by bdash
  • 5 edits in trunk

2007-08-30 Riku Voipio <​riku.voipio@iki.fi>

Reviewed by Dave Kilzer.

Better ARM defines.

  • kjs/ustring.h: Update comments to reflect the change and update test to fit changes to Platform.h.
  • wtf/Platform.h: Forced packing is only needed on oldabi ARM. Set middle-endian floats only for little-endian oldabi ARM. Set big-endian define for big-endian ARM.

2007-08-30 Riku Voipio <​riku.voipio@iki.fi>

Reviewed by Dave Kilzer.

Better ARM defines.

  • platform/DeprecatedString.h: Update comments to reflect the change and update test to fit changes to Platform.h.
2:14 PM Changeset in webkit [25320] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Tim.


<rdar://problem/5439953> REGRESSION: Cannot load feeds in widgets in Dashcode due to change in WebKit delegate methods

  • WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]): Don't create the debugger object if the frame has not yet created its script interpreter, to avoid premature dispatch of windowScriptObjectAvailable/Cleared delegate methods. The script debugger will be created in any case when the window object does appear.
11:06 AM Changeset in webkit [25319] by darin
  • 5 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::checkConsistency):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::checkConsistency):
  • rendering/RenderText.cpp: (WebCore::RenderText::checkConsistency): Put the actual consistency check inside an ifdef. If you need it you can turn it on. There's still some function call overhead in builds that don't have NDEBUG defined, but that's worth it so we can turn this on and off without recompiling the world.
  • small code style improvement to recently changed function
  • editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer): Use a typedef and make_pair to make the code dealing with the pair simpler to read.
7:44 AM Changeset in webkit [25318] by hausmann
  • 2 edits in trunk/WebKitQt

Use QKeySequence::StandardKey for the page wise scrolling shortcuts.

7:44 AM Changeset in webkit [25317] by hausmann
  • 2 edits in trunk/WebKitQt

When scrolling with the keyboard don't call update() on the entire widget.
The scrollbar/scrollview implementation is already smart enough to scroll with bitblt
on a value change.

7:44 AM Changeset in webkit [25316] by hausmann
  • 2 edits in trunk/WebKitQt

Fix scrolling with the keyboard if only one of the two scrollbars is visible.

7:26 AM Changeset in webkit [25315] by hausmann
  • 2 edits in trunk/WebCore

Fix Qt/Gdk build.

6:12 AM Changeset in webkit [25314] by antti
  • 2 edits in trunk/WebCore

Reviewed by Antti.


  • fix <rdar://problem/5423270> CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore: WebCore::plainTextToMallocAllocatedBuffer + 762
  • editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer): Check for a malloc failure and exit the function if it failed.

Aug 29, 2007:

6:32 PM Changeset in webkit [25313] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5404329>
Plugin content starves WM_TIMER events on UI thread (affects idle behavior of app) on ​http://www.vincent-vella.com/, ​http://www.sagmeister.com/


Add a tiny delay to invalidation timer to prevent it from starving other timers.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect):
5:45 PM Changeset in webkit [25312] by darin
  • 7 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • Misc/WebNSPasteboardExtras.h: Got rid of the global data objects and replaced them with global functions.
  • Misc/WebNSPasteboardExtras.mm: (initializePasteboardTypes): Changed the initialize method to be this function. (WebURLPasteboardType): Added, calls the initialize function and then returns the value of the global. (WebURLNamePasteboardType): Ditto. (+[NSPasteboard _web_writableTypesForURL]): Changed to call the new function instead of getting at the global directly. (+[NSPasteboard _web_dragTypesForURL]): Ditto. (-[NSPasteboard _web_writeURL:andTitle:types:]): Ditto.
  • WebCoreSupport/WebPasteboardHelper.mm: (WebPasteboardHelper::urlFromPasteboard): Ditto.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
  • WebView/WebView.mm: (+[WebView initialize]): Added a call to one of the functions to take advantage of the side effect that initializes the globals; this is to help out old versions of Safari. (+[WebView URLTitleFromPasteboard:]): Changed to call the new function instead of getting at the global directly.
  • WebKit.exp: Add exports of the new functions.
5:32 PM Changeset in webkit [25311] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode): Fix an assert that was firing for me all the time when doing editing operations.
5:23 PM Changeset in webkit [25310] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5386098>
Repro hang with some Flash plugin content (​http://dougmccune.com/blog/2007/07/25/coming-to-flexcamp-at-adobe/)


In some cases, Flash ends up starving the main loop by sending a lot of WM_USER + 1 messages. Throttle these
messages so they won't end up hanging the web browser.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): (WebCore::PluginMessageThrottlerWin::~PluginMessageThrottlerWin): (WebCore::PluginMessageThrottlerWin::appendMessage): (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired): (WebCore::PluginMessageThrottlerWin::allocateMessage): (WebCore::PluginMessageThrottlerWin::isInlineMessage): (WebCore::PluginMessageThrottlerWin::freeMessage): (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::wndProc): (WebCore::PluginViewWin::determineQuirks):
  • plugins/win/PluginViewWin.h: (WebCore::): (WebCore::PluginViewWin::pluginWndProc):
4:15 PM Changeset in webkit [25309] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5436800> REGRESSION: PLT is 1.5% slower due
to r24593 and r25098

In r25098, we only called setCreatedByParser for XML! This patch
calls it for HTML too, and takes care of the performance
regression.

  • html/HTMLElementFactory.cpp: (WebCore::styleConstructor):
3:46 PM Changeset in webkit [25308] by antti
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Mitz.


Fix <rdar://problem/5425951>
REGRESSION: change to updateLayoutIgnorePendingStylesheets causes SAP Portal page to render wrong


If new nodes have been added or style recalc has been done with style sheets still pending, some nodes
may not have had their real style calculated yet. Normally this state gets cleaned when style sheets arrive
but in updateLayoutIgnorePendingStylesheets() we need to do full style recalc to get up-to-date style immediatly.


Added a document flag to track if there are any nodes that did not have their real style calculated due to
pending stylesheets.

Test: fast/dynamic/style-access-late-stylesheet-load.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::recalcStyle): (WebCore::Document::updateLayoutIgnorePendingStylesheets):
  • dom/Document.h: (WebCore::Document::setHasNodesWithPlaceholderStyle):

LayoutTests:

Reviewed by Mitz.


Test for <rdar://problem/5425951>
REGRESSION: change to updateLayoutIgnorePendingStylesheets causes SAP Portal page to render wrong

  • fast/dynamic/style-access-late-stylesheet-load-expected.txt: Added.
  • fast/dynamic/style-access-late-stylesheet-load.html: Added.
3:05 PM Changeset in webkit [25307] by adele
  • 5 edits in trunk/WebKit

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15098
<rdar://problem/5440319> REGRESSION (9A530-9A534): Double scroll bar on pdfs

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): Don't suppress scrollbars before the view creation if we're making the view for a non-html view
  • WebView/WebFrameViewInternal.h: Make _scrollView return a WebDynamicScrollBarsView since so many clients were relying on it being that type anyway.
  • WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): (-[WebFrameView _scrollView]): (-[WebFrameView setAllowsScrolling:]): (-[WebFrameView allowsScrolling]):
  • WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]):
2:29 PM Changeset in webkit [25306] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

We disable the DeleteButton UI before applying any editing commands.
This patch simply moves those disable/enable calls to a more correct place, closer to the actual application of the editing command.

  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::applyCommand):
2:27 PM Changeset in webkit [25305] by aliceli1
  • 8 edits in trunk/WebCore

fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply()

after dropping a selected image over container's close box

Reviewed by Darin and Maciej.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): (WebCore::DeleteButtonController::hide):
  • editing/DeleteButtonController.h: (WebCore::DeleteButtonController::enabled): General changes made to DeleteButtonController: when hiding, it's not necessary to clear out the m_containerElement and m_target, especially since to fix this bug we need to keep their values around. It's sufficient to just detach the container from target.
  • editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand): Move the selection out of the deletion UI since we don't want to expose the deletion UI to any editing.
  • editing/Editor.cpp: (WebCore::Editor::rangeForPoint): Move the range out of the deletion UI since we don't want to expose the deletion UI to any editing.
  • editing/htmlediting.cpp:
  • editing/htmlediting.h: (WebCore::avoidIntersectionWithNode): Moved function that operates on Range from markup.cpp to here Added new implementation for function that operates on Selection
  • editing/markup.cpp: (WebCore::createMarkup): Moved function out of this file to htmlediting.cpp, and renamed to avoidIntersectionWithNode
2:27 PM Changeset in webkit [25304] by hyatt
  • 1 edit in trunk/WebKit/WebView/WebHTMLView.mm

Tiger build fix.

2:25 PM Changeset in webkit [25303] by hyatt
  • 1 edit in trunk/WebKit/WebView/WebHTMLView.mm

Tiger build fix.

2:25 PM Changeset in webkit [25302] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

Added case-insensitivity to checks for adding regression tests.

  • Scripts/prepare-ChangeLog: (generateFileList):
2:17 PM Changeset in webkit [25301] by hyatt
  • 2 edits in trunk/WebKit

The method that was swizzled to fix 5441281 does not exist on Tiger.
Tiger has to do a double swizzle instead (of resetCursorRects and NSCursor's
set method) in order to roughly achieve the same effect.

Reviewed by darin

  • WebView/WebHTMLView.mm: (resetCursorRects): (setCursor): (+[WebHTMLViewPrivate initialize]):
1:39 PM Changeset in webkit [25300] by andersca
  • 2 edits in trunk/WebKit

Fix 64-bit build.


  • WebCoreSupport/WebFrameBridge.mm:
12:58 PM Changeset in webkit [25299] by adachan
  • 5 edits in trunk/WebKit/win

<rdar://problem/5074612> Added SPI to retrieve certificate info from a WebError.

Reviewed by Steve.

  • Interfaces/IWebErrorPrivate.idl: Added IWebErrorPrivate
  • WebError.cpp: (WebError::QueryInterface): WebError now also implements IWebErrorPrivate (WebError::sslPeerCertificate): retrieves certificate info from CFError's user info.
  • WebError.h:
  • WebKit.vcproj/WebKitGUID.vcproj: Added IWebErrorPrivate_i.c
12:48 PM Changeset in webkit [25298] by hyatt
  • 7 edits in trunk

WebCore:

Fix for 5441281, remove our dependency on cursor rects and drag margins
in AppKit for a large performance boost on the PLT and iBench.

Reviewed by darin

  • platform/mac/WidgetMac.mm: (WebCore::safeRemoveFromSuperview): (WebCore::Widget::addToSuperview): Suppress the resetting of drag margins when views are added and removed.

(WebCore::Widget::setCursor):
Just use NSCursor's set method to immediately set the cursor. We no longer
rely on NSScrollView/NSClipView setDocumentCursor, since that is implemented
using cursor rects.

WebKit:

Fix for 5441281, remove our dependency on cursor rects and drag margins
in AppKit for a large performance boost on the PLT and iBench.

Reviewed by darin

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendNullEvent]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView stop]): Clean up cursor setting from Netscape plugins. Don't unconditionally mutate the cursor when a plugin stops.
  • WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): Suppress the resetting of drag margins while the new document view is being added to the view hierarchy.
  • WebView/WebHTMLView.mm: (-[NSWindow _web_borderView]): Expose the border view of the NSWindow so that it can be hit tested.

(setCursorForMouseLocation):
Apply a method swizzle to override the private AppKit method, _setCursorForMouseLocation.
We have to do this to suppress the cursor rect invalidation handling from resetting
the cursor for no reason.

The swizzle will do a hit test and allow the cursor set to occur if the mouse ends up
being over a plugin or over a view other than a WebHTMLView.

(+[WebHTMLViewPrivate initialize]):
The swizzle for setCursorForMouseLocation is set up here.

(-[WebHTMLView _frameOrBoundsChanged]):
Add a 100ms delay to the fake mouse moved event that fires when the view moves
under the mouse (without the mouse moving). This happens on iBench when the
pages get scrolled. By adding a delay we ensure that even with the mouse inside
the window, we don't experience cursor thrashing when pages are updating and
scrolling rapidly.

10:39 AM Changeset in webkit [25297] by bdash
  • 2 edits in trunk/WebCore

2007-08-29 Rick <​rick@writhe.org.uk>

Reviewed by Tim Hatcher.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=14853
Bug 14853: Incorrect implementation of ArrayImpl's equality operator

  • platform/ArrayImpl.cpp: (WebCore::ArrayImpl::operator==): Fixed typo so that correct variable is used in equality comparison.
10:35 AM Changeset in webkit [25296] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-08-29 Ryan Leavengood <​leavengood@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15043

  • posix_memalign takes a void as its first parameter. My port makes use of this function call.
  • kjs/collector.cpp: (KJS::allocateBlock):
10:34 AM Changeset in webkit [25295] by bdash
  • 4 edits in trunk/WebCore

2007-08-29 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Maciej.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameDurationAtIndex):
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameDurationAtIndex):
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
10:31 AM Changeset in webkit [25294] by bdash
  • 2 edits in trunk/WebCore

2007-08-29 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Maciej.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::PNGImageDecoder): (WebCore::PNGImageDecoder::frameBufferAtIndex): (WebCore::PNGImageDecoder::decode): (WebCore::PNGImageDecoder::rowAvailable): (WebCore::PNGImageDecoder::pngComplete):
10:29 AM Changeset in webkit [25293] by bdash
  • 2 edits in trunk/WebCore

2007-08-29 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Maciej.

  • fix ​http://bugs.webkit.org/show_bug.cgi?id=15104 Don't double-compensate for sizeof(unsigned) when making a buffer overflow check in the GIF decoder. Now interlaced GIFs don't sometimes get nothing/garbage in some of the bottom rows.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
8:53 AM Changeset in webkit [25292] by sfalken
  • 1 copy in tags/Safari-523.2b

New tag.

8:53 AM Changeset in webkit [25291] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

6:41 AM QtWebKitTodo edited by Simon Hausmann
(diff)
6:27 AM QtWebKitTodo edited by Simon Hausmann
(diff)
1:32 AM Changeset in webkit [25290] by sfalken
  • 1 edit in trunk/WebKit/win/WebFrame.cpp

Fix build.

1:27 AM JavaScript performance improvement ideas created by mjs@apple.com
12:56 AM Changeset in webkit [25289] by hausmann
  • 2 edits in trunk/WebKitQt

Fix compilation

12:46 AM Changeset in webkit [25288] by sfalken
  • 4 edits in trunk/WebKit/win

<rdar://problem/5079253> Cannot set different margins for the page


Added support for setting margins via page setup for Windows printing.


Reviewed by Adam.

12:04 AM Changeset in webkit [25287] by bdash
  • 2 edits in trunk/WebKit

2007-08-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej Stachowiak.

Fix fallout from the fix for <rdar://problem/5437983> (Loading history containing 100,000 entries adds 20s to Safari's startup)
in r25275. The array of entries for each day was being maintained in the reverse of the order that was expected.

  • History/WebHistory.mm: (-[WebHistoryPrivate insertItem:forDateKey:]): Maintain the array of entries in descending order.

Aug 28, 2007:

7:51 PM Changeset in webkit [25286] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Removed test files in /resources/ subdirectories.

7:49 PM Changeset in webkit [25285] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Maciej.

Ignore files in /resources/ subdirectories when creating a list of added tests.

  • Scripts/prepare-ChangeLog: (generateFileList):
5:32 PM Changeset in webkit [25284] by weinig
  • 4 edits
    7 adds in trunk

WebCore:

Reviewed by Darin.

Update fix landed in r25249 to account for XMLHttpRequest, which can also be EventTargets.

Tests: http/tests/security/listener/resources/childWithXMLHttpRequest.html

http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html
http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html
http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html
http/tests/security/listener/xss-XMLHttpRequest-shortcut.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::putValueProperty): Use the Window object associated with document's frame, not the active Window. (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): ditto
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::document): Expose Document member so bindings can access the correct frame.

LayoutTests:

Reviewed by Darin.

Additional tests for <rdar://problem/5426142>

  • http/tests/security/listener/resources/childWithXMLHttpRequest.html: Added.
  • http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html: Added.
  • http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Added.
  • http/tests/security/listener/xss-XMLHttpRequest-shortcut.html: Added.
5:15 PM Changeset in webkit [25283] by andersca
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent

Restore the previous behavior, creating plug-ins on attach, for WebKit plug-ins. Netscape plug-ins
are still created during the first layout.


  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance): Only call layout if the renderer doesn't have a widget.


  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance): Likewise.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldUsePlugin): Update for enum change.


  • loader/FrameLoaderTypes.h: Add ObjectContentNetscapePlugin and ObjectContentOtherPlugin.


  • page/mac/WebCoreFrameBridge.h: Get rid of the enum here, we can use the one in FrameLoaderTypes.h


  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Only create the plug-in if it's not a Netscape plug-in.


(WebCore::RenderPartObject::layout):
Fix indentation.

WebKit:

Reviewed by Darin.

<rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent


  • WebCoreSupport/WebFrameBridge.mm: Use the enum from FrameLoaderTypes.h.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): Return ObjectContentNetscapePlugin and ObjectContentOtherPlugin depending on the plug-in type.
4:36 PM Changeset in webkit [25282] by honeycutt
  • 2 edits in trunk/WebKit/win

2007-08-28 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

<rdar://problem/5444457>: Content is cut when page orientation changed
in print preview
Fix: Don't return WebFrame::m_pageRects if it exists; let
computePageRectsForFrame clear and rewrite it.

  • WebFrame.cpp: (WebFrame::computePageRects): Removed an early-return case. Added a space.
3:08 PM Changeset in webkit [25281] by harrison
  • 1 edit
    9 adds in trunk/LayoutTests

Reviewed by Darin.

<rdar://problem/5415006> Command Left in a To Do causes caret to disappear

  • editing/selection/mixed-editability-8.html: Added.
  • editing/selection/mixed-editability-9.html: Added.
  • platform/mac/editing/selection: Added.
  • platform/mac/editing/selection/mixed-editability-8-expected.checksum: Added.
  • platform/mac/editing/selection/mixed-editability-8-expected.png: Added.
  • platform/mac/editing/selection/mixed-editability-8-expected.txt: Added.
  • platform/mac/editing/selection/mixed-editability-9-expected.checksum: Added.
  • platform/mac/editing/selection/mixed-editability-9-expected.png: Added.
  • platform/mac/editing/selection/mixed-editability-9-expected.txt: Added.
3:06 PM Changeset in webkit [25280] by harrison
  • 5 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5415006> Command Left in a To Do causes caret to disappear

The selection was ending up inside non-editable content at the To Do Options
arrow image, rather then at the editable position just to the left of that image.
The problem was that startPositionForLine looked only at line boxes, and there
is no linebox for the editable position at the far left of a To Do, which is
a table. Addressed by having startPositionForLine use table offset 0 instead
of the first VisiblePosition inside the table.


Found and fixed the similar case with option-left (move by word position).


Test cases:

  • editing/selection/mixed-editability-8.html: Added.
  • editing/selection/mixed-editability-9.html: Added.

Source changes:

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyMovingLeftBackward):


  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::stayInEditableContentLeft): (WebCore::VisiblePosition::stayInEditableContentRight): Factored stayInEditableContentLeft() and stayInEditableContentRight() out of previous() and next().


  • editing/VisiblePosition.h: Declare stayInEditableContentLeft() and stayInEditableContentRight().
  • editing/visible_units.cpp: (WebCore::previousWordPosition): (WebCore::nextWordPosition): (WebCore::startOfLine): (WebCore::endOfLine): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): Call stayInEditableContentLeft() or stayInEditableContentRight(), as appropriate, so prevent crossing from editable content into uneditable content.


(WebCore::startPositionForLine):
Use table offset 0 instead of the first VisiblePosition in the table.

1:24 PM Changeset in webkit [25279] by bdash
  • 2 edits in trunk/WebKit

2007-08-28 Mark Rowe <​mrowe@apple.com>

Fix the buildbot build.

  • History/WebHistory.mm: (timeIntervalForBeginningOfDay): Explicitly cast to silence compiler warning.
1:12 PM Changeset in webkit [25278] by bdash
  • 2 edits in trunk/WebCore

2007-08-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5443453> Decreasing history expiration time from 1 year to 1 week can lead to long hang while icon database syncs

Perform the sync inside a SQLite transaction. This drops the time taken for the sync from over 90s to under half a second in the
extreme case of over 90,000 URLs being pruned.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncDatabase):
1:06 PM Changeset in webkit [25277] by andersca
  • 3 edits in trunk/LayoutTests

Use the correct test paths.


  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:55 PM Changeset in webkit [25276] by bdash
  • 1 edit in trunk/WebCore/ChangeLog

Put ChangeLog back to UTF-8 after FileMerge went and mangled it for my last commit.

12:48 PM Changeset in webkit [25275] by bdash
  • 10 edits
    2 deletes in trunk

2007-08-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup

Move WebHistoryItemPrivate from using a sorted array of NSCalendarDate's that map to a sorted array of arrays
of WebHistoryItem's over to using a HashMap of NSTimeIntervals and arrays of WebHistoryItems. NSTimeInterval
uses less memory and is substantially cheaper during comparisons than NSCalendarDate. The use of the HashMap
avoids the needs to repeatedly search within an array to locate the array that corresponds to the given days
history items.

The result of these changes is that loading 100,000 history items drops from around 25s to 1.6s. Loading
100 items drops from 0.003s to 0.002s.

  • History/WebHistory.mm: (-[WebHistoryPrivate init]): (-[WebHistoryPrivate dealloc]): (timeIntervalForBeginningOfDay): Return the NSTimeInterval representing the beginning of the specified day. (-[WebHistoryPrivate findKey:forDay:]): (-[WebHistoryPrivate insertItem:forDateKey:]): Perform a binary search within the day's history items rather than a linear search. (-[WebHistoryPrivate _removeItemFromDateCaches:]): (-[WebHistoryPrivate _addItemToDateCaches:]): (-[WebHistoryPrivate removeAllItems]): (-[WebHistoryPrivate orderedLastVisitedDays]): Generate and cache the sorted NSArray of NSCalendarDate's exposed in the API. This cache is invalidated by _removeItemFromDateCaches: and _addItemToDateCaches: when needed. (-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]): (-[WebHistoryPrivate arrayRepresentation]): (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Use an autorelease pool to keep the number of live autoreleased objects generated to a reasonable level.
  • History/WebHistoryItem.mm: (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): Use the new HistoryItem constructor that accepts the alternate title rather than setting it after construction. This prevents a modification notification from being sent for each WebHistoryItem that is loaded.
  • History/WebHistoryItemInternal.h:
  • History/WebHistoryPrivate.h:
  • Misc/WebNSCalendarDateExtras.h: Removed as _webkit_compareDay: is no longer used.
  • Misc/WebNSCalendarDateExtras.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:

2007-08-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup

Add a new constructor for HistoryItem that initializes the alternate title. This prevents WebHistoryItem
in WebKit from having explicitly set the display title, which triggers a history item changed notification
to be posted, for each history item loaded.

  • WebCore.exp:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • history/HistoryItem.h:
12:05 PM Changeset in webkit [25274] by andersca
  • 20 edits
    3 adds in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues


Add a shouldContentSniff flag to ResourceLoader and ResourceHandle and have XMLHttpRequest
pass in false when creating its subresource loader.


  • WebCore.exp:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::loadNow):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::load):
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):

WebKit:

Reviewed by Darin.

<rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues


Expose WKSetNSURLRequestShouldContentSniff to WebCore.


  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

LayoutTests:

Reviewed by Darin.

<rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues


  • http/tests/xmlhttprequest/resources/small-chunks.cgi: Added.
  • http/tests/xmlhttprequest/small-chunks-response-text-expected.txt: Added.
  • http/tests/xmlhttprequest/small-chunks-response-text.html: Added.
  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:03 PM Changeset in webkit [25273] by andersca
  • 3 edits in trunk/WebKitLibraries

Add WKSetNSURLRequestShouldContentSniff.


  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
10:23 AM Changeset in webkit [25272] by adachan
  • 5 edits
    1 add in trunk/WebKit/win

<rdar://problem/4876242> Added SPI to fetch SSL certificate information.

Reviewed by Adam and Steve.

  • Interfaces/IWebURLResponsePrivate.idl: Added.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebURLResponse.cpp: (WebURLResponse::QueryInterface): (WebURLResponse::sslPeerCertificate): gets peer certificate context from CFNetwork (WebURLResponse::certificateDictionary): gets the dictionary that contains SSL certificate info from CFNetwork. We retain the dictionary to ensure the certificate context is valid throughout the lifetime of the WebURLResponse.
  • WebURLResponse.h:


10:20 AM Changeset in webkit [25271] by adachan
  • 4 edits in trunk/WebKitLibraries

<rdar://problem/4876242> Added SPI to fetch SSL certificate information.
Updated libraries.


Reviewed by Adam.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:


9:29 AM Changeset in webkit [25270] by sfalken
  • 4 edits in trunk

<rdar://problem/5424801> REGRESSION (r25151): Web page area of window doesn't redraw if page isn't loaded


Don't bypass WebView WM_PAINT if the WebView has never committed a page.
Added getter for committedFirstRealDocumentLoad.


Reviewed by Maciej.

  • WebView.cpp: (WebViewWndProc): Don't skip painting if we haven't committed any pages in this view.
  • loader/FrameLoader.h: Added committedFirstRealDocumentLoad. (WebCore::FrameLoader::committedFirstRealDocumentLoad): Added.

Aug 27, 2007:

11:35 PM Changeset in webkit [25269] by oliver
  • 2 edits in trunk/LayoutTests

Reviewed by NOBODY (layout test result fix).

Output of layoutTestController.dumpChildFramesAsText changes in non-relevant way
when running this test on its own vs. running as part of the full suite.


Correcting test result for the output produced while running the full suite.

  • fast/encoding/frame-default-enc-expected.txt:
10:59 PM Changeset in webkit [25268] by oliver
  • 10 edits
    2 adds
    6 deletes in trunk/LayoutTests

rs=brady


Convert all the encoding tests to plain text dumps.

  • fast/encoding/char-decoding-expected.txt:
  • fast/encoding/char-decoding-mac-expected.txt: Added.
  • fast/encoding/char-decoding-mac.html: Added. char-decoding-mac tests the ability to decode the mac specific legacy x-nextstep charset.
  • fast/encoding/char-decoding.html:
  • fast/encoding/frame-default-enc-expected.checksum: Removed.
  • fast/encoding/frame-default-enc-expected.png: Removed.
  • fast/encoding/frame-default-enc-expected.txt:
  • fast/encoding/frame-default-enc.html:
  • fast/encoding/mispositioned-meta-expected.checksum: Removed.
  • fast/encoding/mispositioned-meta-expected.png: Removed.
  • fast/encoding/mispositioned-meta-expected.txt:
  • fast/encoding/mispositioned-meta.html:
  • fast/encoding/tag-in-title-expected.checksum: Removed.
  • fast/encoding/tag-in-title-expected.png: Removed.
  • fast/encoding/tag-in-title-expected.txt:
  • fast/encoding/tag-in-title.html:
  • platform/win/Skipped: Skip char-decoding-mac
4:09 PM Changeset in webkit [25267] by antti
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.


Fix <rdar://problem/5433144>
REGRESSION: Unable to click "Select" link at Expedia for car rentals


javascript: URLs need special handling when serializing. Escaping them like
normal attribute values can do bad things. Try hard to not escape anything,
escape quote characters only if really necessary. Try to match Firefox.

Test: fast/innerHTML/javascript-url.html

  • editing/markup.cpp: (WebCore::urlAttributeToQuotedString): (WebCore::startMarkup):

LayoutTests:

Reviewed by Maciej.


Test for <rdar://problem/5433144>
REGRESSION: Unable to click "Select" link at Expedia for car rentals

  • fast/innerHTML/javascript-url-expected.txt: Added.
  • fast/innerHTML/javascript-url.html: Added.
3:46 PM Changeset in webkit [25266] by oliver
  • 2 edits in trunk/LayoutTests

rs=adam

Remove tests effected by <rdar://problem/5317287> from the windows skiplist

  • platform/win/Skipped:
2:57 PM Changeset in webkit [25265] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderInline.cpp
2:57 PM Changeset in webkit [25264] by hyatt
  • 5 edits in trunk/WebCore

Fix for 5441224, micro-optimizations to improve the PLT by 1%.

Reviewed by Darin

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement):
  • platform/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::requiresLayer):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::isBody):
  • rendering/RenderObject.h: (WebCore::RenderObject::renderArena): (WebCore::RenderObject::isRoot):
1:43 PM Changeset in webkit [25263] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by John.

  • Removed Leopard leaks list since all of those radars were fixed.
  • Scripts/run-webkit-tests:
10:57 AM Changeset in webkit [25262] by bdash
  • 3 edits
    5 adds in trunk

2007-08-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/replaced/applet-disabled-positioned.html

  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Changed to call RenderObject::createObject(), which accounts for style.

2007-08-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/replaced/applet-disabled-positioned.html: Added.
  • platform/mac/fast/replaced: Added.
  • platform/mac/fast/replaced/applet-disabled-positioned-expected.checksum: Added.
  • platform/mac/fast/replaced/applet-disabled-positioned-expected.png: Added.
  • platform/mac/fast/replaced/applet-disabled-positioned-expected.txt: Added.
6:36 AM Changeset in webkit [25261] by zimmermann
  • 9 edits in branches/feature-branch/WebCore

Reviewed by Mitz.

Expose unitsPerEm() in Font classes.
This is needed to implement SVG's advanced text decorations. We won't draw lines for text-decorations
but fillable & strokable rectangles with a certain height, computed through unitsPerEm & font size.

1:13 AM Changeset in webkit [25260] by oliver
  • 2 edits in branches/feature-branch/WebCore

Reviewed by NOBODY (Build fix).

Initialise iterators to appease gcc

  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::closestCharacterToPosition):
1:13 AM Changeset in webkit [25259] by aroben
  • 2 edits in trunk/WebKitTools

Rubberstamped by Mark.

  • Scripts/pdevenv: Pass arguments along to devenv.com.

Aug 26, 2007:

11:40 PM Changeset in webkit [25258] by darin
  • 2 edits in trunk/JavaScriptCore
  • quick follow on to that last check-in
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): Need to initialize m_class to 0.
11:17 PM Changeset in webkit [25257] by bdash
  • 5 edits in trunk/JavaScriptCore

2007-08-26 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/4949002> JSGlobalContextCreate can cause crashes because it passes a NULL JSContextRef to the globalObjectClass's initialize callback

JSCallbackObject now tracks whether it was constructed with a null ExecState. This will happen when the object is being used as the global object,
as the Interpreter needs to be created after the global object. In this situation the initialization is deferred until after the Interpreter's
ExecState is available to be passed down to the initialize callbacks.

  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): Track whether we successfully initialized. (KJS::JSCallbackObject::initializeIfNeeded): Attempt to initialize with the new ExecState.
  • API/JSCallbackObject.h:
  • API/JSContextRef.cpp: (JSGlobalContextCreate): Initialize the JSCallbackObject with the Interpreter's ExecState.
  • API/testapi.c: (testInitializeOfGlobalObjectClassHasNonNullContext): (main): Verify that the context passed to the initialize callback is non-null.
11:02 PM Changeset in webkit [25256] by bdash
  • 3 edits in trunk/JavaScriptCore

2007-08-26 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5438496> JSGlobalContextCreate crashes when passed a custom class

  • API/JSContextRef.cpp: (JSGlobalContextCreate): Specify jsNull() as the prototype and let Interpreter's constructor fix it up to point at builtinObjectPrototype().
  • API/testapi.c: (main): Use an instance of a custom class as the global object to ensure the code path is exercised in the test.
5:11 PM Changeset in webkit [25255] by antti
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.


Fix for <rdar://problem/5433726>
Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (​http://www.yahoo.com/)

Test: editing/style/temporary-span-crash.html

  • page/Frame.cpp: (WebCore::Frame::styleForSelectionStart): Temporary span created here might not have renderer if document has style sheet that makes it display:none. Set display:inline explicitly in spans style attribute. This temporary span does not need to get its display value from actual document style sheets. Null check the renderer too to be sure.

LayoutTests:

Reviewed by Darin.


Test for <rdar://problem/5433726>
Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (​http://www.yahoo.com/)

  • editing/style/temporary-span-crash-expected.txt: Added.
  • editing/style/temporary-span-crash.html: Added.
6:39 AM Changeset in webkit [25254] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Mark Rowe.

Update prepare-ChangeLog to generate the datestamp in the correct timezone.

  • Scripts/prepare-ChangeLog: (changeLogDate): Added.
6:20 AM Changeset in webkit [25253] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Mark Rowe and David Kilzer.

Fix build failure on arm.

  • wtf/Platform.h: Also test if arm is defined.
5:46 AM Changeset in webkit [25252] by zimmermann
  • 1 edit
    5 adds in branches/feature-branch/LayoutTests

Rubberstamped by Mark.
Add missing SVG filter testcase (forgot to include in last commit).

Aug 25, 2007:

7:16 PM Changeset in webkit [25251] by oliver
  • 2 edits in trunk/WebKit/win

Reviewed by Adam and Sam


<rdar://problem/5269732> Safari 3.0 for Windows cuts off text in textarea boxes during sending forms (14562)
<​http://bugs.webkit.org/show_bug.cgi?id=14562> [Win] Textarea contents partially eaten on submit/copy


WebView::handleEditingKeyboardEvent assumed all keycodes that did not trigger a named command were
to be inserted. This could cause unexpected behaviour when control characters (eg. escape) are sent,
or could cause data loss when sent a null character (as happens when dead keys are used for international
input).


This patch corrects WebView::handleEditingKeyboardEvent to prevent such characters from being sent
to Editor::insertText. This behaviour matches Firefox.

  • WebView.cpp: (WebView::handleEditingKeyboardEvent):
1:42 PM Changeset in webkit [25250] by ddkilzer
  • 2 edits in trunk/LayoutTests

LayoutTests:

Reviewed by NOBODY (fixes layout tests).

Don't pass any options to window.open() in target-frame-from-window.html, specifically
those that cause the window to be resized. This caused a downstream failure in
cross-frame-access-put.html because the window.outerHeight and window.outerWidth
properties were sometimes affected by the new window size used in the popup window.

  • http/tests/navigation/target-frame-from-window.html:
12:08 PM Changeset in webkit [25249] by weinig
  • 4 edits
    16 adds in trunk

WebCore:

Reviewed by Adele.

Fix for <rdar://problem/5426142>

Use the EventTarget's frame when creating the EventListener.

Tests: http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html

http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html
http/tests/security/listener/xss-window-onclick-addEventListener.html
http/tests/security/listener/xss-window-onclick-shortcut.html

  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::setListener): (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction):
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):

LayoutTests:

Reviewed by Adele.

Tests for <rdar://problem/5426142>

  • http/tests/security/listener: Added.
  • http/tests/security/listener/resources: Added.
  • http/tests/security/listener/resources/childWindow.html: Added.
  • http/tests/security/listener/resources/childWithButton.html: Added.
  • http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-addEventListener.html: Added.
  • http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-shortcut.html: Added.
  • http/tests/security/listener/resources/targetChild-window-onclick-addEventListener.html: Added.
  • http/tests/security/listener/resources/targetChild-window-onclick-shortcut.html: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Added.
  • http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html: Added.
  • http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Added.
  • http/tests/security/listener/xss-window-onclick-addEventListener.html: Added.
  • http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Added.
  • http/tests/security/listener/xss-window-onclick-shortcut.html: Added.
12:02 PM Changeset in webkit [25248] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

  • manual-tests/drag-out-of-background-window.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): Added missing coordinate conversion.
11:12 AM Changeset in webkit [25247] by bdash
  • 1 copy in tags/Safari-4523.2

New tag.

9:57 AM Changeset in webkit [25246] by rwlbuis
  • 3 edits
    8 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14848
DOM table rules are not updated when changed

On a dynamic rules attr change, mark the table cells and
their ancestors (up to and including the table tag) as
changed.

9:35 AM Changeset in webkit [25245] by adele
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15073
<rdar://problem/5426557> REGRESSION: Can no longer drag text from textareas


Test: fast/forms/drag-out-of-textarea.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControlInnerBlock::nodeAtPoint): Only restricts hit testing if the placeholder text is visible.
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::placeholderIsVisible): Added.

LayoutTests:

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=15073
<rdar://problem/5426557> REGRESSION: Can no longer drag text from textareas

  • fast/forms/drag-out-of-textarea-expected.txt: Added.
  • fast/forms/drag-out-of-textarea.html: Added.
9:08 AM Changeset in webkit [25244] by bdash
  • 21 edits
    2 deletes in tags/Safari-5523.2

Roll out r25128 to prevent <rdar://5424866>.

8:49 AM Changeset in webkit [25243] by bdash
  • 4 edits in trunk

Versioning.

8:48 AM Changeset in webkit [25242] by bdash
  • 1 copy in tags/Safari-5523.2

New tag.

7:03 AM Changeset in webkit [25241] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-08-25 Peter Kasting <​zerodpx@gmail.org>

Reviewed by Maciej Stachowiak.

Part 3 of ​http://bugs.webkit.org/show_bug.cgi?id=14967
Bug 14967: Reduce wtf::Vector::operator[]() overloads

  • wtf/Vector.h: (WTF::Vector::operator[]): Only provide versions of operator[] that takes a size_t argument.
7:00 AM Changeset in webkit [25240] by bdash
  • 7 edits in trunk

2007-08-25 Peter Kasting <​zerodpx@gmail.org>

Reviewed by Sam Weinig.

Part 2 of ​http://bugs.webkit.org/show_bug.cgi?id=14967.
Eliminate all remaining implicit conversions of wtf::Vector<T> to T*. Where code was
previously checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()
instead.

  • wtf/Vector.h: (WTF::Vector::data):

2007-08-25 Peter Kasting <​zerodpx@gmail.org>

Reviewed by Sam Weinig.

Part 2 of ​http://bugs.webkit.org/show_bug.cgi?id=14967.
Eliminate all remaining implicit conversions of wtf::Vector<T> to T*. Where code was
previously checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()
instead.

  • bindings/js/kjs_navigator.cpp: (KJS::PluginBase::cachePluginDataIfNecessary):
  • loader/mac/LoaderNSURLExtras.m: (suggestedFilenameWithMIMEType):
  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): (WebCore::FrameView::dispatchScheduledEvents):
  • platform/mac/PlugInInfoStoreMac.mm: (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
5:58 AM Changeset in webkit [25239] by bdash
  • 1 edit
    1 move in trunk/LayoutTests

2007-08-25 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Mitz.

Disable fast/js/string-concatenate-outofmemory.html until <​http://bugs.webkit.org/show_bug.cgi?id=15046> is resolved.

  • fast/js/string-concatenate-outofmemory.html: Removed.
  • fast/js/string-concatenate-outofmemory.html-disabled: Copied from LayoutTests/fast/js/string-concatenate-outofmemory.html.
5:37 AM Changeset in webkit [25238] by bdash
  • 1 edit
    1 delete in trunk/WebCore

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Rubber-stamped by Adam Roben

  • remove unused file
  • platform/win/MouseEventWin.cpp: Removed.
5:35 AM Changeset in webkit [25237] by bdash
  • 2 edits in trunk/WebCore

2007-08-25 Jasper Bryant-Greene <​m@ni.ac.nz>

Reviewed by Oliver Hunt.

Set paintingDisabled to true in Cairo's GraphicsContext constructor
when passed a null PlatformGraphicsContext.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext):
5:30 AM Changeset in webkit [25236] by bdash
  • 6 edits in trunk

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Covered by fast/parser/residual-style-close-across-n-blocks.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): If the residual style was closed before anything else in the block (so it does not apply to anything inside the block) avoid creating an empty element for it inside the block.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/parser/residual-style-close-across-n-blocks-expected.txt:
  • fast/parser/residual-style-close-across-n-blocks.html:
  • tables/mozilla/other/wa_table_tr_align-expected.txt:
5:26 AM Changeset in webkit [25235] by bdash
  • 3 edits
    2 adds in trunk

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: editing/selection/move-by-line-003.html

  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Changed hit testing so that each line is tested for hits between its overflow top and the next line's overflow top. This matches RenderBlock::positionForCoordinates.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • editing/selection/move-by-line-003-expected.txt: Added.
  • editing/selection/move-by-line-003.html: Added.
5:21 AM Changeset in webkit [25234] by bdash
  • 13 edits
    2 adds in trunk

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Justin.

Test: editing/pasteboard/newlines-around-floating-or-positioned.html

  • editing/TextIterator.cpp: (WebCore::shouldEmitNewlinesBeforeAndAfterNode): Do not emit newlines around floating or positioned blocks. This behavior seems to match WinIE's.

2007-08-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Justin.

  • editing/pasteboard/newlines-around-floating-or-positioned-expected.txt: Added.
  • editing/pasteboard/newlines-around-floating-or-positioned.html: Added.
  • fast/events/capture-on-target-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/events/mouseover-mouseout-expected.txt:
  • fast/events/mouseover-mouseout2-expected.txt:
  • fast/events/window-events-bubble-expected.txt:
  • fast/events/window-events-bubble2-expected.txt:
  • fast/events/window-events-capture-expected.txt:
  • fast/forms/input-appearance-elementFromPoint-expected.txt:
  • fast/forms/onselect-textarea-expected.txt:
  • fast/forms/onselect-textfield-expected.txt:

Aug 24, 2007:

10:52 PM Changeset in webkit [25233] by sfalken
  • 1 copy in tags/Safari-523.1.3b

New tag.

10:52 PM Changeset in webkit [25232] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

9:12 PM Changeset in webkit [25231] by weinig
  • 34 edits in trunk

WebKitTools:

Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.

win:

Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.

6:23 PM Changeset in webkit [25230] by justing
  • 2 adds in trunk/LayoutTests/editing/execCommand
6:20 PM Changeset in webkit [25229] by justing
  • 4 edits
    7 adds in trunk

WebCore:

Reviewed by Darin.


<rdar://problem/5432254> GoogleDocs: A hang occurs when applying list style to selected table


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the position that marked the start of the range to delete has been removed from the document, and it was inside the node that holds the position that marks the end of the range to delete, don't remove any children of that node, because we don't know how many to remove. For example, if the end is [a, 5] and the start was in some descendant of a and was removed, don't remove any of the children of a. We will now refuse to remove some content incorrectly, but that's less dangerous than removing content incorrectly. Long term we need to update these positions as we remove content from the document, but that seems like a more risky change. Added a testcase.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::modifyRange): If the end of the selection to modify is just after a table, and if the start of the selection is inside that table, the last paragraph that we'll want modify is the last one inside the table, not the paragraph that contains the table itself. Adjust startOfLastParagraph here to avoid infinite recursion.

LayoutTests:

Reviewed by Darin.


<rdar://problem/5432254> GoogleDocs: A hang occurs when applying list style to selected table

  • editing/execCommand/5432254-1.html: Added.
  • editing/execCommand/5432254-2.html: Added.
  • platform/mac/editing/execCommand: Added.
  • platform/mac/editing/execCommand/5432254-1-expected.checksum: Added.
  • platform/mac/editing/execCommand/5432254-1-expected.png: Added.
  • platform/mac/editing/execCommand/5432254-1-expected.txt: Added.
  • platform/mac/editing/execCommand/5432254-2-expected.checksum: Added.
  • platform/mac/editing/execCommand/5432254-2-expected.png: Added.
  • platform/mac/editing/execCommand/5432254-2-expected.txt: Added.
5:49 PM Changeset in webkit [25228] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Remove conflict marker.

5:47 PM Changeset in webkit [25227] by andersca
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Geoff.

<rdar://problem/5430165>
REGRESSION: Dynamically loaded images fail to load

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::HTMLImageLoader): Initialize the m_elementIsProtected member.

(WebCore::HTMLImageLoader::~HTMLImageLoader):
Assert that the element is not protected.


(WebCore::HTMLImageLoader::setLoadingImage):
If the image is not null, protect the element. Otherwise, unprotect it.


(WebCore::HTMLImageLoader::dispatchLoadEvent):
Unprotect the element here.

(WebCore::HTMLImageLoader::protectElement):
(WebCore::HTMLImageLoader::unprotectElement):
New methods which protect and unprotect the element.


  • html/HTMLImageLoader.h:

LayoutTests:

Reviewed by Geoff.

<rdar://problem/5430165>
REGRESSION: Dynamically loaded images fail to load


  • fast/dom/HTMLImageElement/image-loading-gc-expected.txt: Added.
  • fast/dom/HTMLImageElement/image-loading-gc.html: Added.
5:33 PM Changeset in webkit [25226] by kmccullo
  • 1 edit in trunk/WebKit/ChangeLog

Reviewed by Darin.

<rdar://problem/5437038> 1 credential object leaked for each call to credentialWithUser:password:persistence

  • Use initWithUser instead of credentialWithUser because credentialWithUser leaks.
  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
5:30 PM Changeset in webkit [25225] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog
  • Updated ChangeLog
5:28 PM Changeset in webkit [25224] by bdakin
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Hyatt and Adele.

Fix for <rdar://problem/5417203> Google Gmail 1.0 widget - unread
count is missing

  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): Calc pref widths for our cells, if needed.

LayoutTests:

Reviewed by Hyatt and Adele.

Test for <rdar://problem/5417203> Google Gmail 1.0 widget - unread
count is missing

  • fast/table/cell-pref-width-invalidation.html: Added.
  • platform/mac/fast/table/cell-pref-width-invalidation-expected.checksum: Added.
  • platform/mac/fast/table/cell-pref-width-invalidation-expected.png: Added.
  • platform/mac/fast/table/cell-pref-width-invalidation-expected.txt: Added.
5:18 PM Changeset in webkit [25223] by kmccullo
  • 5 edits in trunk

WebCore:

Reviewed by Darin.

  • Use initWithUser instead of credentialWithUser because credentialWithUser leaks.
  • platform/network/mac/AuthenticationMac.mm: (WebCore::mac):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):

WebKit:

Reviewed by Darin.

  • Use initWithUser instead of credentialWithUser because credentialWithUser leaks.
  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
5:09 PM Changeset in webkit [25222] by adele
  • 4 edits in trunk/WebKit

Fix by Darin, reviewed by Adele.

Fix for <rdar://problem/5433422> Upon quitting, WebKit loads the WebPlugin shared database and immediately closes it

  • Plugins/WebPluginDatabase.h: Added closeSharedDatabase, which won't create a new database if we're just trying to close it.
  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase closeSharedDatabase]): Added.
  • WebView/WebView.mm: (-[WebView _close]): Call closeSharedDatabase. (+[WebView _applicationWillTerminate]): Call closeSharedDatabase.
4:51 PM Changeset in webkit [25221] by adachan
  • 2 edits in trunk/WebKit/win

<rdar://problem/5147315> and <rdar://problem/5183935>
Added accelerator key mappings for Select All, Undo, and Redo.

Reviewed by Adam.

  • WebView.cpp:
3:59 PM Changeset in webkit [25220] by honeycutt
  • 2 edits in trunk/WebKit/win

2007-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Part of <rdar://problem/5433236> Print preview of empty txt file crashes
Safari

  • WebFrame.cpp: (WebFrame::computePageRects): Pass m_pageRects by reference into computePageRectsForFrame
3:56 PM Changeset in webkit [25219] by thatcher
  • 1 edit in trunk/WebKit/Carbon/HIWebView.m

Build fix.

3:54 PM Changeset in webkit [25218] by honeycutt
  • 3 edits in trunk/WebCore

2007-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5433236> Print preview of empty txt file crashes Safari
Fix: Adjust computePageRectsForFrame to always return at least one
page rect, even if document height is zero.

  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.h: Added Vector& parameter to computePagesRectsForFrame; changed its return type to void.
  • bridge/win/FrameWin.cpp: (WebCore::computePageRectsForFrame): Reordered the loop that inserts rects into the vector.
3:20 PM Changeset in webkit [25217] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/5410937> HIWebView in SimpleCarbonWeb doesn't seem to be getting adequate invalidation when window is resized

This is a more localized fix for yesterday's change. Now explicitly call _web_layoutIfNeededRecursive inside the
HIWebView Draw() function. Adds a FIXME to explain that we need to do layout before Carbon has decided what regions to draw.
Doing layout in Draw() will potentially cause drawing to happen in two passes, but this has always been a problem in Carbon.

  • Carbon/HIWebView.m: (Draw): Call _web_layoutIfNeededRecursive on the main WebHTMLView. (SetFocusPart): Fix to work in ObjC++ (now that HIWebView.m is treated as a ObjC++ file.)
  • WebView/WebView.mm: Removes the 4 displayIfNeeded methods from yesterday's change.
  • WebKit.xcodeproj/project.pbxproj: Force the file type of HIWebView.m to ObjC++ so WebHTMLViewInternal.h can be included.
1:19 PM Changeset in webkit [25216] by weinig
  • 34 edits in trunk

WebKitTools:

Rubber-stamped by Adam Roben.

<rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration

Rename COM DOM bindings to use Deprecated prefix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFramesAsText): (dump):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: (dumpPath): (dump): (EditingDelegate::shouldBeginEditingInDOMRange): (EditingDelegate::shouldEndEditingInDOMRange): (EditingDelegate::shouldInsertNode): (EditingDelegate::shouldInsertText): (EditingDelegate::shouldDeleteDOMRange): (EditingDelegate::shouldChangeSelectedDOMRange): (EditingDelegate::shouldApplyStyle): (EditingDelegate::shouldChangeTypingStyle):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:

win:

Rubber-stamped by Adam Roben.

<rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration

Rename COM DOM bindings to use Deprecated prefix.

  • DOMCSSClasses.cpp: (DeprecatedDOMCSSStyleDeclaration::DeprecatedDOMCSSStyleDeclaration): (DeprecatedDOMCSSStyleDeclaration::~DeprecatedDOMCSSStyleDeclaration): (DeprecatedDOMCSSStyleDeclaration::createInstance): (DeprecatedDOMCSSStyleDeclaration::QueryInterface): (DeprecatedDOMCSSStyleDeclaration::cssText): (DeprecatedDOMCSSStyleDeclaration::setCssText): (DeprecatedDOMCSSStyleDeclaration::getPropertyValue): (DeprecatedDOMCSSStyleDeclaration::getPropertyCSSValue): (DeprecatedDOMCSSStyleDeclaration::removeProperty): (DeprecatedDOMCSSStyleDeclaration::getPropertyPriority): (DeprecatedDOMCSSStyleDeclaration::setProperty): (DeprecatedDOMCSSStyleDeclaration::length): (DeprecatedDOMCSSStyleDeclaration::item): (DeprecatedDOMCSSStyleDeclaration::parentRule):
  • DOMCSSClasses.h: (DeprecatedDOMCSSStyleDeclaration::AddRef): (DeprecatedDOMCSSStyleDeclaration::Release): (DeprecatedDOMCSSStyleDeclaration::throwException): (DeprecatedDOMCSSStyleDeclaration::callWebScriptMethod): (DeprecatedDOMCSSStyleDeclaration::evaluateWebScript): (DeprecatedDOMCSSStyleDeclaration::removeWebScriptKey): (DeprecatedDOMCSSStyleDeclaration::stringRepresentation): (DeprecatedDOMCSSStyleDeclaration::webScriptValueAtIndex): (DeprecatedDOMCSSStyleDeclaration::setWebScriptValueAtIndex): (DeprecatedDOMCSSStyleDeclaration::setException):
  • DOMCoreClasses.cpp: (DeprecatedDOMObject::QueryInterface): (DeprecatedDOMNode::QueryInterface): (DeprecatedDOMNode::nodeName): (DeprecatedDOMNode::nodeValue): (DeprecatedDOMNode::setNodeValue): (DeprecatedDOMNode::nodeType): (DeprecatedDOMNode::parentNode): (DeprecatedDOMNode::childNodes): (DeprecatedDOMNode::firstChild): (DeprecatedDOMNode::lastChild): (DeprecatedDOMNode::previousSibling): (DeprecatedDOMNode::nextSibling): (DeprecatedDOMNode::attributes): (DeprecatedDOMNode::ownerDocument): (DeprecatedDOMNode::insertBefore): (DeprecatedDOMNode::replaceChild): (DeprecatedDOMNode::removeChild): (DeprecatedDOMNode::appendChild): (DeprecatedDOMNode::hasChildNodes): (DeprecatedDOMNode::cloneNode): (DeprecatedDOMNode::normalize): (DeprecatedDOMNode::isSupported): (DeprecatedDOMNode::namespaceURI): (DeprecatedDOMNode::prefix): (DeprecatedDOMNode::setPrefix): (DeprecatedDOMNode::localName): (DeprecatedDOMNode::hasAttributes): (DeprecatedDOMNode::isSameNode): (DeprecatedDOMNode::isEqualNode): (DeprecatedDOMNode::textContent): (DeprecatedDOMNode::setTextContent): (DeprecatedDOMNode::addEventListener): (DeprecatedDOMNode::removeEventListener): (DeprecatedDOMNode::dispatchEvent): (DeprecatedDOMNode::DeprecatedDOMNode): (DeprecatedDOMNode::~DeprecatedDOMNode): (DeprecatedDOMNode::createInstance): (DeprecatedDOMNodeList::QueryInterface): (DeprecatedDOMNodeList::item): (DeprecatedDOMNodeList::length): (DeprecatedDOMNodeList::DeprecatedDOMNodeList): (DeprecatedDOMNodeList::~DeprecatedDOMNodeList): (DeprecatedDOMNodeList::createInstance): (DeprecatedDOMDocument::QueryInterface): (DeprecatedDOMDocument::doctype): (DeprecatedDOMDocument::implementation): (DeprecatedDOMDocument::documentElement): (DeprecatedDOMDocument::createElement): (DeprecatedDOMDocument::createDocumentFragment): (DeprecatedDOMDocument::createTextNode): (DeprecatedDOMDocument::createComment): (DeprecatedDOMDocument::createCDATASection): (DeprecatedDOMDocument::createProcessingInstruction): (DeprecatedDOMDocument::createAttribute): (DeprecatedDOMDocument::createEntityReference): (DeprecatedDOMDocument::getElementsByTagName): (DeprecatedDOMDocument::importNode): (DeprecatedDOMDocument::createElementNS): (DeprecatedDOMDocument::createAttributeNS): (DeprecatedDOMDocument::getElementsByTagNameNS): (DeprecatedDOMDocument::getElementById): (DeprecatedDOMDocument::getComputedStyle): (DeprecatedDOMDocument::createEvent): (DeprecatedDOMDocument::DeprecatedDOMDocument): (DeprecatedDOMDocument::~DeprecatedDOMDocument): (DeprecatedDOMDocument::createInstance): (DeprecatedDOMElement::QueryInterface): (DeprecatedDOMElement::boundingBox): (DeprecatedDOMElement::lineBoxRects): (DeprecatedDOMElement::tagName): (DeprecatedDOMElement::getAttribute): (DeprecatedDOMElement::setAttribute): (DeprecatedDOMElement::removeAttribute): (DeprecatedDOMElement::getAttributeNode): (DeprecatedDOMElement::setAttributeNode): (DeprecatedDOMElement::removeAttributeNode): (DeprecatedDOMElement::getElementsByTagName): (DeprecatedDOMElement::getAttributeNS): (DeprecatedDOMElement::setAttributeNS): (DeprecatedDOMElement::removeAttributeNS): (DeprecatedDOMElement::getAttributeNodeNS): (DeprecatedDOMElement::setAttributeNodeNS): (DeprecatedDOMElement::getElementsByTagNameNS): (DeprecatedDOMElement::hasAttribute): (DeprecatedDOMElement::hasAttributeNS): (DeprecatedDOMElement::focus): (DeprecatedDOMElement::blur): (DeprecatedDOMElement::coreElement): (DeprecatedDOMElement::isEqual): (DeprecatedDOMElement::isFocused): (DeprecatedDOMElement::innerText): (DeprecatedDOMElement::style): (DeprecatedDOMElement::offsetLeft): (DeprecatedDOMElement::offsetTop): (DeprecatedDOMElement::offsetWidth): (DeprecatedDOMElement::offsetHeight): (DeprecatedDOMElement::offsetParent): (DeprecatedDOMElement::clientWidth): (DeprecatedDOMElement::clientHeight): (DeprecatedDOMElement::scrollLeft): (DeprecatedDOMElement::setScrollLeft): (DeprecatedDOMElement::scrollTop): (DeprecatedDOMElement::setScrollTop): (DeprecatedDOMElement::scrollWidth): (DeprecatedDOMElement::scrollHeight): (DeprecatedDOMElement::scrollIntoView): (DeprecatedDOMElement::scrollIntoViewIfNeeded): (DeprecatedDOMElement::DeprecatedDOMElement): (DeprecatedDOMElement::~DeprecatedDOMElement): (DeprecatedDOMElement::createInstance):
  • DOMCoreClasses.h: (DeprecatedDOMNode::AddRef): (DeprecatedDOMNode::Release): (DeprecatedDOMNode::throwException): (DeprecatedDOMNode::callWebScriptMethod): (DeprecatedDOMNode::evaluateWebScript): (DeprecatedDOMNode::removeWebScriptKey): (DeprecatedDOMNode::stringRepresentation): (DeprecatedDOMNode::webScriptValueAtIndex): (DeprecatedDOMNode::setWebScriptValueAtIndex): (DeprecatedDOMNode::setException): (DeprecatedDOMNodeList::AddRef): (DeprecatedDOMNodeList::Release): (DeprecatedDOMNodeList::throwException): (DeprecatedDOMNodeList::callWebScriptMethod): (DeprecatedDOMNodeList::evaluateWebScript): (DeprecatedDOMNodeList::removeWebScriptKey): (DeprecatedDOMNodeList::stringRepresentation): (DeprecatedDOMNodeList::webScriptValueAtIndex): (DeprecatedDOMNodeList::setWebScriptValueAtIndex): (DeprecatedDOMNodeList::setException): (DeprecatedDOMDocument::AddRef): (DeprecatedDOMDocument::Release): (DeprecatedDOMDocument::throwException): (DeprecatedDOMDocument::callWebScriptMethod): (DeprecatedDOMDocument::evaluateWebScript): (DeprecatedDOMDocument::removeWebScriptKey): (DeprecatedDOMDocument::stringRepresentation): (DeprecatedDOMDocument::webScriptValueAtIndex): (DeprecatedDOMDocument::setWebScriptValueAtIndex): (DeprecatedDOMDocument::setException): (DeprecatedDOMDocument::nodeName): (DeprecatedDOMDocument::nodeValue): (DeprecatedDOMDocument::setNodeValue): (DeprecatedDOMDocument::nodeType): (DeprecatedDOMDocument::parentNode): (DeprecatedDOMDocument::childNodes): (DeprecatedDOMDocument::firstChild): (DeprecatedDOMDocument::lastChild): (DeprecatedDOMDocument::previousSibling): (DeprecatedDOMDocument::nextSibling): (DeprecatedDOMDocument::attributes): (DeprecatedDOMDocument::ownerDocument): (DeprecatedDOMDocument::insertBefore): (DeprecatedDOMDocument::replaceChild): (DeprecatedDOMDocument::removeChild): (DeprecatedDOMDocument::appendChild): (DeprecatedDOMDocument::hasChildNodes): (DeprecatedDOMDocument::cloneNode): (DeprecatedDOMDocument::normalize): (DeprecatedDOMDocument::isSupported): (DeprecatedDOMDocument::namespaceURI): (DeprecatedDOMDocument::prefix): (DeprecatedDOMDocument::setPrefix): (DeprecatedDOMDocument::localName): (DeprecatedDOMDocument::hasAttributes): (DeprecatedDOMDocument::isSameNode): (DeprecatedDOMDocument::isEqualNode): (DeprecatedDOMDocument::textContent): (DeprecatedDOMDocument::setTextContent): (DeprecatedDOMElement::AddRef): (DeprecatedDOMElement::Release): (DeprecatedDOMElement::throwException): (DeprecatedDOMElement::callWebScriptMethod): (DeprecatedDOMElement::evaluateWebScript): (DeprecatedDOMElement::removeWebScriptKey): (DeprecatedDOMElement::stringRepresentation): (DeprecatedDOMElement::webScriptValueAtIndex): (DeprecatedDOMElement::setWebScriptValueAtIndex): (DeprecatedDOMElement::setException): (DeprecatedDOMElement::nodeName): (DeprecatedDOMElement::nodeValue): (DeprecatedDOMElement::setNodeValue): (DeprecatedDOMElement::nodeType): (DeprecatedDOMElement::parentNode): (DeprecatedDOMElement::childNodes): (DeprecatedDOMElement::firstChild): (DeprecatedDOMElement::lastChild): (DeprecatedDOMElement::previousSibling): (DeprecatedDOMElement::nextSibling): (DeprecatedDOMElement::attributes): (DeprecatedDOMElement::ownerDocument): (DeprecatedDOMElement::insertBefore): (DeprecatedDOMElement::replaceChild): (DeprecatedDOMElement::removeChild): (DeprecatedDOMElement::appendChild): (DeprecatedDOMElement::hasChildNodes): (DeprecatedDOMElement::cloneNode): (DeprecatedDOMElement::normalize): (DeprecatedDOMElement::isSupported): (DeprecatedDOMElement::namespaceURI): (DeprecatedDOMElement::prefix): (DeprecatedDOMElement::setPrefix): (DeprecatedDOMElement::localName): (DeprecatedDOMElement::hasAttributes): (DeprecatedDOMElement::isSameNode): (DeprecatedDOMElement::isEqualNode): (DeprecatedDOMElement::textContent): (DeprecatedDOMElement::setTextContent):
  • DOMEventsClasses.cpp: (DeprecatedDOMEventListener::QueryInterface): (DeprecatedDOMEventListener::handleEvent): (DeprecatedDOMEvent::DeprecatedDOMEvent): (DeprecatedDOMEvent::~DeprecatedDOMEvent): (DeprecatedDOMEvent::createInstance): (DeprecatedDOMEvent::QueryInterface): (DeprecatedDOMEvent::type): (DeprecatedDOMEvent::target): (DeprecatedDOMEvent::currentTarget): (DeprecatedDOMEvent::eventPhase): (DeprecatedDOMEvent::bubbles): (DeprecatedDOMEvent::cancelable): (DeprecatedDOMEvent::timeStamp): (DeprecatedDOMEvent::stopPropagation): (DeprecatedDOMEvent::preventDefault): (DeprecatedDOMEvent::initEvent): (DeprecatedDOMUIEvent::QueryInterface): (DeprecatedDOMUIEvent::view): (DeprecatedDOMUIEvent::detail): (DeprecatedDOMUIEvent::initUIEvent): (DeprecatedDOMUIEvent::keyCode): (DeprecatedDOMUIEvent::charCode): (DeprecatedDOMUIEvent::layerX): (DeprecatedDOMUIEvent::layerY): (DeprecatedDOMUIEvent::pageX): (DeprecatedDOMUIEvent::pageY): (DeprecatedDOMUIEvent::which): (DeprecatedDOMKeyboardEvent::QueryInterface): (DeprecatedDOMKeyboardEvent::keyIdentifier): (DeprecatedDOMKeyboardEvent::keyLocation): (DeprecatedDOMKeyboardEvent::ctrlKey): (DeprecatedDOMKeyboardEvent::shiftKey): (DeprecatedDOMKeyboardEvent::altKey): (DeprecatedDOMKeyboardEvent::metaKey): (DeprecatedDOMKeyboardEvent::altGraphKey): (DeprecatedDOMKeyboardEvent::getModifierState): (DeprecatedDOMKeyboardEvent::initKeyboardEvent): (DeprecatedDOMMouseEvent::QueryInterface): (DeprecatedDOMMouseEvent::screenX): (DeprecatedDOMMouseEvent::screenY): (DeprecatedDOMMouseEvent::clientX): (DeprecatedDOMMouseEvent::clientY): (DeprecatedDOMMouseEvent::ctrlKey): (DeprecatedDOMMouseEvent::shiftKey): (DeprecatedDOMMouseEvent::altKey): (DeprecatedDOMMouseEvent::metaKey): (DeprecatedDOMMouseEvent::button): (DeprecatedDOMMouseEvent::relatedTarget): (DeprecatedDOMMouseEvent::initMouseEvent): (DeprecatedDOMMouseEvent::offsetX): (DeprecatedDOMMouseEvent::offsetY): (DeprecatedDOMMouseEvent::x): (DeprecatedDOMMouseEvent::y): (DeprecatedDOMMouseEvent::fromElement): (DeprecatedDOMMouseEvent::toElement): (DeprecatedDOMMutationEvent::QueryInterface): (DeprecatedDOMMutationEvent::relatedNode): (DeprecatedDOMMutationEvent::prevValue): (DeprecatedDOMMutationEvent::newValue): (DeprecatedDOMMutationEvent::attrName): (DeprecatedDOMMutationEvent::attrChange): (DeprecatedDOMMutationEvent::initMutationEvent): (DeprecatedDOMOverflowEvent::QueryInterface): (DeprecatedDOMOverflowEvent::orient): (DeprecatedDOMOverflowEvent::horizontalOverflow): (DeprecatedDOMOverflowEvent::verticalOverflow): (DeprecatedDOMWheelEvent::QueryInterface): (DeprecatedDOMWheelEvent::screenX): (DeprecatedDOMWheelEvent::screenY): (DeprecatedDOMWheelEvent::clientX): (DeprecatedDOMWheelEvent::clientY): (DeprecatedDOMWheelEvent::ctrlKey): (DeprecatedDOMWheelEvent::shiftKey): (DeprecatedDOMWheelEvent::altKey): (DeprecatedDOMWheelEvent::metaKey): (DeprecatedDOMWheelEvent::wheelDelta): (DeprecatedDOMWheelEvent::wheelDeltaX): (DeprecatedDOMWheelEvent::wheelDeltaY): (DeprecatedDOMWheelEvent::offsetX): (DeprecatedDOMWheelEvent::offsetY): (DeprecatedDOMWheelEvent::x): (DeprecatedDOMWheelEvent::y): (DeprecatedDOMWheelEvent::isHorizontal): (DeprecatedDOMWheelEvent::initWheelEvent):
  • DOMEventsClasses.h: (DeprecatedDOMEventListener::AddRef): (DeprecatedDOMEventListener::Release): (DeprecatedDOMEventListener::throwException): (DeprecatedDOMEventListener::callWebScriptMethod): (DeprecatedDOMEventListener::evaluateWebScript): (DeprecatedDOMEventListener::removeWebScriptKey): (DeprecatedDOMEventListener::stringRepresentation): (DeprecatedDOMEventListener::webScriptValueAtIndex): (DeprecatedDOMEventListener::setWebScriptValueAtIndex): (DeprecatedDOMEventListener::setException): (DeprecatedDOMEvent::AddRef): (DeprecatedDOMEvent::Release): (DeprecatedDOMEvent::throwException): (DeprecatedDOMEvent::callWebScriptMethod): (DeprecatedDOMEvent::evaluateWebScript): (DeprecatedDOMEvent::removeWebScriptKey): (DeprecatedDOMEvent::stringRepresentation): (DeprecatedDOMEvent::webScriptValueAtIndex): (DeprecatedDOMEvent::setWebScriptValueAtIndex): (DeprecatedDOMEvent::setException): (DeprecatedDOMUIEvent::DeprecatedDOMUIEvent): (DeprecatedDOMUIEvent::AddRef): (DeprecatedDOMUIEvent::Release): (DeprecatedDOMUIEvent::throwException): (DeprecatedDOMUIEvent::callWebScriptMethod): (DeprecatedDOMUIEvent::evaluateWebScript): (DeprecatedDOMUIEvent::removeWebScriptKey): (DeprecatedDOMUIEvent::stringRepresentation): (DeprecatedDOMUIEvent::webScriptValueAtIndex): (DeprecatedDOMUIEvent::setWebScriptValueAtIndex): (DeprecatedDOMUIEvent::setException): (DeprecatedDOMUIEvent::type): (DeprecatedDOMUIEvent::target): (DeprecatedDOMUIEvent::currentTarget): (DeprecatedDOMUIEvent::eventPhase): (DeprecatedDOMUIEvent::bubbles): (DeprecatedDOMUIEvent::cancelable): (DeprecatedDOMUIEvent::timeStamp): (DeprecatedDOMUIEvent::stopPropagation): (DeprecatedDOMUIEvent::preventDefault): (DeprecatedDOMUIEvent::initEvent): (DeprecatedDOMKeyboardEvent::DeprecatedDOMKeyboardEvent): (DeprecatedDOMKeyboardEvent::AddRef): (DeprecatedDOMKeyboardEvent::Release): (DeprecatedDOMKeyboardEvent::throwException): (DeprecatedDOMKeyboardEvent::callWebScriptMethod): (DeprecatedDOMKeyboardEvent::evaluateWebScript): (DeprecatedDOMKeyboardEvent::removeWebScriptKey): (DeprecatedDOMKeyboardEvent::stringRepresentation): (DeprecatedDOMKeyboardEvent::webScriptValueAtIndex): (DeprecatedDOMKeyboardEvent::setWebScriptValueAtIndex): (DeprecatedDOMKeyboardEvent::setException): (DeprecatedDOMKeyboardEvent::type): (DeprecatedDOMKeyboardEvent::target): (DeprecatedDOMKeyboardEvent::currentTarget): (DeprecatedDOMKeyboardEvent::eventPhase): (DeprecatedDOMKeyboardEvent::bubbles): (DeprecatedDOMKeyboardEvent::cancelable): (DeprecatedDOMKeyboardEvent::timeStamp): (DeprecatedDOMKeyboardEvent::stopPropagation): (DeprecatedDOMKeyboardEvent::preventDefault): (DeprecatedDOMKeyboardEvent::initEvent): (DeprecatedDOMKeyboardEvent::view): (DeprecatedDOMKeyboardEvent::detail): (DeprecatedDOMKeyboardEvent::initUIEvent): (DeprecatedDOMKeyboardEvent::keyCode): (DeprecatedDOMKeyboardEvent::charCode): (DeprecatedDOMKeyboardEvent::layerX): (DeprecatedDOMKeyboardEvent::layerY): (DeprecatedDOMKeyboardEvent::pageX): (DeprecatedDOMKeyboardEvent::pageY): (DeprecatedDOMKeyboardEvent::which): (DeprecatedDOMMouseEvent::DeprecatedDOMMouseEvent): (DeprecatedDOMMouseEvent::AddRef): (DeprecatedDOMMouseEvent::Release): (DeprecatedDOMMouseEvent::throwException): (DeprecatedDOMMouseEvent::callWebScriptMethod): (DeprecatedDOMMouseEvent::evaluateWebScript): (DeprecatedDOMMouseEvent::removeWebScriptKey): (DeprecatedDOMMouseEvent::stringRepresentation): (DeprecatedDOMMouseEvent::webScriptValueAtIndex): (DeprecatedDOMMouseEvent::setWebScriptValueAtIndex): (DeprecatedDOMMouseEvent::setException): (DeprecatedDOMMouseEvent::type): (DeprecatedDOMMouseEvent::target): (DeprecatedDOMMouseEvent::currentTarget): (DeprecatedDOMMouseEvent::eventPhase): (DeprecatedDOMMouseEvent::bubbles): (DeprecatedDOMMouseEvent::cancelable): (DeprecatedDOMMouseEvent::timeStamp): (DeprecatedDOMMouseEvent::stopPropagation): (DeprecatedDOMMouseEvent::preventDefault): (DeprecatedDOMMouseEvent::initEvent): (DeprecatedDOMMouseEvent::view): (DeprecatedDOMMouseEvent::detail): (DeprecatedDOMMouseEvent::initUIEvent): (DeprecatedDOMMouseEvent::keyCode): (DeprecatedDOMMouseEvent::charCode): (DeprecatedDOMMouseEvent::layerX): (DeprecatedDOMMouseEvent::layerY): (DeprecatedDOMMouseEvent::pageX): (DeprecatedDOMMouseEvent::pageY): (DeprecatedDOMMouseEvent::which): (DeprecatedDOMMutationEvent::DeprecatedDOMMutationEvent): (DeprecatedDOMMutationEvent::AddRef): (DeprecatedDOMMutationEvent::Release): (DeprecatedDOMMutationEvent::throwException): (DeprecatedDOMMutationEvent::callWebScriptMethod): (DeprecatedDOMMutationEvent::evaluateWebScript): (DeprecatedDOMMutationEvent::removeWebScriptKey): (DeprecatedDOMMutationEvent::stringRepresentation): (DeprecatedDOMMutationEvent::webScriptValueAtIndex): (DeprecatedDOMMutationEvent::setWebScriptValueAtIndex): (DeprecatedDOMMutationEvent::setException): (DeprecatedDOMMutationEvent::type): (DeprecatedDOMMutationEvent::target): (DeprecatedDOMMutationEvent::currentTarget): (DeprecatedDOMMutationEvent::eventPhase): (DeprecatedDOMMutationEvent::bubbles): (DeprecatedDOMMutationEvent::cancelable): (DeprecatedDOMMutationEvent::timeStamp): (DeprecatedDOMMutationEvent::stopPropagation): (DeprecatedDOMMutationEvent::preventDefault): (DeprecatedDOMMutationEvent::initEvent): (DeprecatedDOMOverflowEvent::DeprecatedDOMOverflowEvent): (DeprecatedDOMOverflowEvent::AddRef): (DeprecatedDOMOverflowEvent::Release): (DeprecatedDOMOverflowEvent::throwException): (DeprecatedDOMOverflowEvent::callWebScriptMethod): (DeprecatedDOMOverflowEvent::evaluateWebScript): (DeprecatedDOMOverflowEvent::removeWebScriptKey): (DeprecatedDOMOverflowEvent::stringRepresentation): (DeprecatedDOMOverflowEvent::webScriptValueAtIndex): (DeprecatedDOMOverflowEvent::setWebScriptValueAtIndex): (DeprecatedDOMOverflowEvent::setException): (DeprecatedDOMOverflowEvent::type): (DeprecatedDOMOverflowEvent::target): (DeprecatedDOMOverflowEvent::currentTarget): (DeprecatedDOMOverflowEvent::eventPhase): (DeprecatedDOMOverflowEvent::bubbles): (DeprecatedDOMOverflowEvent::cancelable): (DeprecatedDOMOverflowEvent::timeStamp): (DeprecatedDOMOverflowEvent::stopPropagation): (DeprecatedDOMOverflowEvent::preventDefault): (DeprecatedDOMOverflowEvent::initEvent): (DeprecatedDOMWheelEvent::DeprecatedDOMWheelEvent): (DeprecatedDOMWheelEvent::AddRef): (DeprecatedDOMWheelEvent::Release): (DeprecatedDOMWheelEvent::throwException): (DeprecatedDOMWheelEvent::callWebScriptMethod): (DeprecatedDOMWheelEvent::evaluateWebScript): (DeprecatedDOMWheelEvent::removeWebScriptKey): (DeprecatedDOMWheelEvent::stringRepresentation): (DeprecatedDOMWheelEvent::webScriptValueAtIndex): (DeprecatedDOMWheelEvent::setWebScriptValueAtIndex): (DeprecatedDOMWheelEvent::setException): (DeprecatedDOMWheelEvent::type): (DeprecatedDOMWheelEvent::target): (DeprecatedDOMWheelEvent::currentTarget): (DeprecatedDOMWheelEvent::eventPhase): (DeprecatedDOMWheelEvent::bubbles): (DeprecatedDOMWheelEvent::cancelable): (DeprecatedDOMWheelEvent::timeStamp): (DeprecatedDOMWheelEvent::stopPropagation): (DeprecatedDOMWheelEvent::preventDefault): (DeprecatedDOMWheelEvent::initEvent): (DeprecatedDOMWheelEvent::view): (DeprecatedDOMWheelEvent::detail): (DeprecatedDOMWheelEvent::initUIEvent): (DeprecatedDOMWheelEvent::keyCode): (DeprecatedDOMWheelEvent::charCode): (DeprecatedDOMWheelEvent::layerX): (DeprecatedDOMWheelEvent::layerY): (DeprecatedDOMWheelEvent::pageX): (DeprecatedDOMWheelEvent::pageY): (DeprecatedDOMWheelEvent::which):
  • DOMHTMLClasses.cpp: (DeprecatedDOMHTMLCollection::DeprecatedDOMHTMLCollection): (DeprecatedDOMHTMLCollection::createInstance): (DeprecatedDOMHTMLCollection::QueryInterface): (DeprecatedDOMHTMLCollection::length): (DeprecatedDOMHTMLCollection::item): (DeprecatedDOMHTMLCollection::namedItem): (DeprecatedDOMHTMLOptionsCollection::QueryInterface): (DeprecatedDOMHTMLOptionsCollection::length): (DeprecatedDOMHTMLOptionsCollection::setLength): (DeprecatedDOMHTMLOptionsCollection::item): (DeprecatedDOMHTMLOptionsCollection::namedItem): (DeprecatedDOMHTMLDocument::QueryInterface): (DeprecatedDOMHTMLDocument::title): (DeprecatedDOMHTMLDocument::setTitle): (DeprecatedDOMHTMLDocument::referrer): (DeprecatedDOMHTMLDocument::domain): (DeprecatedDOMHTMLDocument::URL): (DeprecatedDOMHTMLDocument::body): (DeprecatedDOMHTMLDocument::setBody): (DeprecatedDOMHTMLDocument::images): (DeprecatedDOMHTMLDocument::applets): (DeprecatedDOMHTMLDocument::links): (DeprecatedDOMHTMLDocument::forms): (DeprecatedDOMHTMLDocument::anchors): (DeprecatedDOMHTMLDocument::cookie): (DeprecatedDOMHTMLDocument::setCookie): (DeprecatedDOMHTMLDocument::open): (DeprecatedDOMHTMLDocument::close): (DeprecatedDOMHTMLDocument::write): (DeprecatedDOMHTMLDocument::writeln): (DeprecatedDOMHTMLDocument::getElementById_): (DeprecatedDOMHTMLDocument::getElementsByName): (DeprecatedDOMHTMLElement::QueryInterface): (DeprecatedDOMHTMLElement::idName): (DeprecatedDOMHTMLElement::setIdName): (DeprecatedDOMHTMLElement::title): (DeprecatedDOMHTMLElement::setTitle): (DeprecatedDOMHTMLElement::lang): (DeprecatedDOMHTMLElement::setLang): (DeprecatedDOMHTMLElement::dir): (DeprecatedDOMHTMLElement::setDir): (DeprecatedDOMHTMLElement::className): (DeprecatedDOMHTMLElement::setClassName): (DeprecatedDOMHTMLElement::innerHTML): (DeprecatedDOMHTMLElement::setInnerHTML): (DeprecatedDOMHTMLElement::innerText): (DeprecatedDOMHTMLElement::setInnerText): (DeprecatedDOMHTMLFormElement::QueryInterface): (DeprecatedDOMHTMLFormElement::elements): (DeprecatedDOMHTMLFormElement::length): (DeprecatedDOMHTMLFormElement::name): (DeprecatedDOMHTMLFormElement::setName): (DeprecatedDOMHTMLFormElement::acceptCharset): (DeprecatedDOMHTMLFormElement::setAcceptCharset): (DeprecatedDOMHTMLFormElement::action): (DeprecatedDOMHTMLFormElement::setAction): (DeprecatedDOMHTMLFormElement::encType): (DeprecatedDOMHTMLFormElement::setEnctype): (DeprecatedDOMHTMLFormElement::method): (DeprecatedDOMHTMLFormElement::setMethod): (DeprecatedDOMHTMLFormElement::target): (DeprecatedDOMHTMLFormElement::setTarget): (DeprecatedDOMHTMLFormElement::submit): (DeprecatedDOMHTMLFormElement::reset): (DeprecatedDOMHTMLSelectElement::QueryInterface): (DeprecatedDOMHTMLSelectElement::type): (DeprecatedDOMHTMLSelectElement::selectedIndex): (DeprecatedDOMHTMLSelectElement::setSelectedIndx): (DeprecatedDOMHTMLSelectElement::value): (DeprecatedDOMHTMLSelectElement::setValue): (DeprecatedDOMHTMLSelectElement::length): (DeprecatedDOMHTMLSelectElement::form): (DeprecatedDOMHTMLSelectElement::options): (DeprecatedDOMHTMLSelectElement::disabled): (DeprecatedDOMHTMLSelectElement::setDisabled): (DeprecatedDOMHTMLSelectElement::multiple): (DeprecatedDOMHTMLSelectElement::setMultiple): (DeprecatedDOMHTMLSelectElement::name): (DeprecatedDOMHTMLSelectElement::setName): (DeprecatedDOMHTMLSelectElement::size): (DeprecatedDOMHTMLSelectElement::setSize): (DeprecatedDOMHTMLSelectElement::tabIndex): (DeprecatedDOMHTMLSelectElement::setTabIndex): (DeprecatedDOMHTMLSelectElement::add): (DeprecatedDOMHTMLSelectElement::remove): (DeprecatedDOMHTMLSelectElement::activateItemAtIndex): (DeprecatedDOMHTMLOptionElement::QueryInterface): (DeprecatedDOMHTMLOptionElement::form): (DeprecatedDOMHTMLOptionElement::defaultSelected): (DeprecatedDOMHTMLOptionElement::setDefaultSelected): (DeprecatedDOMHTMLOptionElement::text): (DeprecatedDOMHTMLOptionElement::index): (DeprecatedDOMHTMLOptionElement::disabled): (DeprecatedDOMHTMLOptionElement::setDisabled): (DeprecatedDOMHTMLOptionElement::label): (DeprecatedDOMHTMLOptionElement::setLabel): (DeprecatedDOMHTMLOptionElement::selected): (DeprecatedDOMHTMLOptionElement::setSelected): (DeprecatedDOMHTMLOptionElement::value): (DeprecatedDOMHTMLOptionElement::setValue): (DeprecatedDOMHTMLInputElement::QueryInterface): (DeprecatedDOMHTMLInputElement::defaultValue): (DeprecatedDOMHTMLInputElement::setDefaultValue): (DeprecatedDOMHTMLInputElement::defaultChecked): (DeprecatedDOMHTMLInputElement::setDefaultChecked): (DeprecatedDOMHTMLInputElement::form): (DeprecatedDOMHTMLInputElement::accept): (DeprecatedDOMHTMLInputElement::setAccept): (DeprecatedDOMHTMLInputElement::accessKey): (DeprecatedDOMHTMLInputElement::setAccessKey): (DeprecatedDOMHTMLInputElement::align): (DeprecatedDOMHTMLInputElement::setAlign): (DeprecatedDOMHTMLInputElement::alt): (DeprecatedDOMHTMLInputElement::setAlt): (DeprecatedDOMHTMLInputElement::checked): (DeprecatedDOMHTMLInputElement::setChecked): (DeprecatedDOMHTMLInputElement::disabled): (DeprecatedDOMHTMLInputElement::setDisabled): (DeprecatedDOMHTMLInputElement::maxLength): (DeprecatedDOMHTMLInputElement::setMaxLength): (DeprecatedDOMHTMLInputElement::name): (DeprecatedDOMHTMLInputElement::setName): (DeprecatedDOMHTMLInputElement::readOnly): (DeprecatedDOMHTMLInputElement::setReadOnly): (DeprecatedDOMHTMLInputElement::size): (DeprecatedDOMHTMLInputElement::setSize): (DeprecatedDOMHTMLInputElement::src): (DeprecatedDOMHTMLInputElement::setSrc): (DeprecatedDOMHTMLInputElement::tabIndex): (DeprecatedDOMHTMLInputElement::setTabIndex): (DeprecatedDOMHTMLInputElement::type): (DeprecatedDOMHTMLInputElement::setType): (DeprecatedDOMHTMLInputElement::useMap): (DeprecatedDOMHTMLInputElement::setUseMap): (DeprecatedDOMHTMLInputElement::value): (DeprecatedDOMHTMLInputElement::setValue): (DeprecatedDOMHTMLInputElement::select): (DeprecatedDOMHTMLInputElement::click): (DeprecatedDOMHTMLInputElement::setSelectionStart): (DeprecatedDOMHTMLInputElement::selectionStart): (DeprecatedDOMHTMLInputElement::setSelectionEnd): (DeprecatedDOMHTMLInputElement::selectionEnd): (DeprecatedDOMHTMLInputElement::isTextField): (DeprecatedDOMHTMLInputElement::rectOnScreen): (DeprecatedDOMHTMLInputElement::replaceCharactersInRange): (DeprecatedDOMHTMLInputElement::selectedRange): (DeprecatedDOMHTMLInputElement::setAutofilled): (DeprecatedDOMHTMLInputElement::isUserEdited): (DeprecatedDOMHTMLTextAreaElement::QueryInterface): (DeprecatedDOMHTMLTextAreaElement::defaultValue): (DeprecatedDOMHTMLTextAreaElement::setDefaultValue): (DeprecatedDOMHTMLTextAreaElement::form): (DeprecatedDOMHTMLTextAreaElement::accessKey): (DeprecatedDOMHTMLTextAreaElement::setAccessKey): (DeprecatedDOMHTMLTextAreaElement::cols): (DeprecatedDOMHTMLTextAreaElement::setCols): (DeprecatedDOMHTMLTextAreaElement::disabled): (DeprecatedDOMHTMLTextAreaElement::setDisabled): (DeprecatedDOMHTMLTextAreaElement::name): (DeprecatedDOMHTMLTextAreaElement::setName): (DeprecatedDOMHTMLTextAreaElement::readOnly): (DeprecatedDOMHTMLTextAreaElement::setReadOnly): (DeprecatedDOMHTMLTextAreaElement::rows): (DeprecatedDOMHTMLTextAreaElement::setRows): (DeprecatedDOMHTMLTextAreaElement::tabIndex): (DeprecatedDOMHTMLTextAreaElement::setTabIndex): (DeprecatedDOMHTMLTextAreaElement::type): (DeprecatedDOMHTMLTextAreaElement::value): (DeprecatedDOMHTMLTextAreaElement::setValue): (DeprecatedDOMHTMLTextAreaElement::select): (DeprecatedDOMHTMLTextAreaElement::isUserEdited):
  • DOMHTMLClasses.h: (DeprecatedDOMHTMLCollection::AddRef): (DeprecatedDOMHTMLCollection::Release): (DeprecatedDOMHTMLCollection::throwException): (DeprecatedDOMHTMLCollection::callWebScriptMethod): (DeprecatedDOMHTMLCollection::evaluateWebScript): (DeprecatedDOMHTMLCollection::removeWebScriptKey): (DeprecatedDOMHTMLCollection::stringRepresentation): (DeprecatedDOMHTMLCollection::webScriptValueAtIndex): (DeprecatedDOMHTMLCollection::setWebScriptValueAtIndex): (DeprecatedDOMHTMLCollection::setException): (DeprecatedDOMHTMLOptionsCollection::AddRef): (DeprecatedDOMHTMLOptionsCollection::Release): (DeprecatedDOMHTMLOptionsCollection::throwException): (DeprecatedDOMHTMLOptionsCollection::callWebScriptMethod): (DeprecatedDOMHTMLOptionsCollection::evaluateWebScript): (DeprecatedDOMHTMLOptionsCollection::removeWebScriptKey): (DeprecatedDOMHTMLOptionsCollection::stringRepresentation): (DeprecatedDOMHTMLOptionsCollection::webScriptValueAtIndex): (DeprecatedDOMHTMLOptionsCollection::setWebScriptValueAtIndex): (DeprecatedDOMHTMLOptionsCollection::setException): (DeprecatedDOMHTMLDocument::DeprecatedDOMHTMLDocument): (DeprecatedDOMHTMLDocument::AddRef): (DeprecatedDOMHTMLDocument::Release): (DeprecatedDOMHTMLDocument::throwException): (DeprecatedDOMHTMLDocument::callWebScriptMethod): (DeprecatedDOMHTMLDocument::evaluateWebScript): (DeprecatedDOMHTMLDocument::removeWebScriptKey): (DeprecatedDOMHTMLDocument::stringRepresentation): (DeprecatedDOMHTMLDocument::webScriptValueAtIndex): (DeprecatedDOMHTMLDocument::setWebScriptValueAtIndex): (DeprecatedDOMHTMLDocument::setException): (DeprecatedDOMHTMLDocument::nodeName): (DeprecatedDOMHTMLDocument::nodeValue): (DeprecatedDOMHTMLDocument::nodeType): (DeprecatedDOMHTMLDocument::parentNode): (DeprecatedDOMHTMLDocument::childNodes): (DeprecatedDOMHTMLDocument::firstChild): (DeprecatedDOMHTMLDocument::lastChild): (DeprecatedDOMHTMLDocument::previousSibling): (DeprecatedDOMHTMLDocument::nextSibling): (DeprecatedDOMHTMLDocument::attributes): (DeprecatedDOMHTMLDocument::ownerDocument): (DeprecatedDOMHTMLDocument::insertBefore): (DeprecatedDOMHTMLDocument::replaceChild): (DeprecatedDOMHTMLDocument::removeChild): (DeprecatedDOMHTMLDocument::appendChild): (DeprecatedDOMHTMLDocument::hasChildNodes): (DeprecatedDOMHTMLDocument::cloneNode): (DeprecatedDOMHTMLDocument::normalize): (DeprecatedDOMHTMLDocument::isSupported): (DeprecatedDOMHTMLDocument::namespaceURI): (DeprecatedDOMHTMLDocument::prefix): (DeprecatedDOMHTMLDocument::setPrefix): (DeprecatedDOMHTMLDocument::localName): (DeprecatedDOMHTMLDocument::hasAttributes): (DeprecatedDOMHTMLDocument::isSameNode): (DeprecatedDOMHTMLDocument::isEqualNode): (DeprecatedDOMHTMLDocument::textContent): (DeprecatedDOMHTMLDocument::setTextContent): (DeprecatedDOMHTMLDocument::doctype): (DeprecatedDOMHTMLDocument::implementation): (DeprecatedDOMHTMLDocument::documentElement): (DeprecatedDOMHTMLDocument::createElement): (DeprecatedDOMHTMLDocument::createDocumentFragment): (DeprecatedDOMHTMLDocument::createTextNode): (DeprecatedDOMHTMLDocument::createComment): (DeprecatedDOMHTMLDocument::createCDATASection): (DeprecatedDOMHTMLDocument::createProcessingInstruction): (DeprecatedDOMHTMLDocument::createAttribute): (DeprecatedDOMHTMLDocument::createEntityReference): (DeprecatedDOMHTMLDocument::getElementsByTagName): (DeprecatedDOMHTMLDocument::importNode): (DeprecatedDOMHTMLDocument::createElementNS): (DeprecatedDOMHTMLDocument::createAttributeNS): (DeprecatedDOMHTMLDocument::getElementsByTagNameNS): (DeprecatedDOMHTMLDocument::getElementById): (DeprecatedDOMHTMLElement::DeprecatedDOMHTMLElement): (DeprecatedDOMHTMLElement::AddRef): (DeprecatedDOMHTMLElement::Release): (DeprecatedDOMHTMLElement::throwException): (DeprecatedDOMHTMLElement::callWebScriptMethod): (DeprecatedDOMHTMLElement::evaluateWebScript): (DeprecatedDOMHTMLElement::removeWebScriptKey): (DeprecatedDOMHTMLElement::stringRepresentation): (DeprecatedDOMHTMLElement::webScriptValueAtIndex): (DeprecatedDOMHTMLElement::setWebScriptValueAtIndex): (DeprecatedDOMHTMLElement::setException): (DeprecatedDOMHTMLElement::nodeName): (DeprecatedDOMHTMLElement::nodeValue): (DeprecatedDOMHTMLElement::setNodeValue): (DeprecatedDOMHTMLElement::nodeType): (DeprecatedDOMHTMLElement::parentNode): (DeprecatedDOMHTMLElement::childNodes): (DeprecatedDOMHTMLElement::firstChild): (DeprecatedDOMHTMLElement::lastChild): (DeprecatedDOMHTMLElement::previousSibling): (DeprecatedDOMHTMLElement::nextSibling): (DeprecatedDOMHTMLElement::attributes): (DeprecatedDOMHTMLElement::ownerDocument): (DeprecatedDOMHTMLElement::insertBefore): (DeprecatedDOMHTMLElement::replaceChild): (DeprecatedDOMHTMLElement::removeChild): (DeprecatedDOMHTMLElement::appendChild): (DeprecatedDOMHTMLElement::hasChildNodes): (DeprecatedDOMHTMLElement::cloneNode): (DeprecatedDOMHTMLElement::normalize): (DeprecatedDOMHTMLElement::isSupported): (DeprecatedDOMHTMLElement::namespaceURI): (DeprecatedDOMHTMLElement::prefix): (DeprecatedDOMHTMLElement::setPrefix): (DeprecatedDOMHTMLElement::localName): (DeprecatedDOMHTMLElement::hasAttributes): (DeprecatedDOMHTMLElement::isSameNode): (DeprecatedDOMHTMLElement::isEqualNode): (DeprecatedDOMHTMLElement::textContent): (DeprecatedDOMHTMLElement::setTextContent): (DeprecatedDOMHTMLElement::tagName): (DeprecatedDOMHTMLElement::getAttribute): (DeprecatedDOMHTMLElement::setAttribute): (DeprecatedDOMHTMLElement::removeAttribute): (DeprecatedDOMHTMLElement::getAttributeNode): (DeprecatedDOMHTMLElement::setAttributeNode): (DeprecatedDOMHTMLElement::removeAttributeNode): (DeprecatedDOMHTMLElement::getElementsByTagName): (DeprecatedDOMHTMLElement::getAttributeNS): (DeprecatedDOMHTMLElement::setAttributeNS): (DeprecatedDOMHTMLElement::removeAttributeNS): (DeprecatedDOMHTMLElement::getAttributeNodeNS): (DeprecatedDOMHTMLElement::setAttributeNodeNS): (DeprecatedDOMHTMLElement::getElementsByTagNameNS): (DeprecatedDOMHTMLElement::hasAttribute): (DeprecatedDOMHTMLElement::hasAttributeNS): (DeprecatedDOMHTMLElement::focus): (DeprecatedDOMHTMLElement::blur): (DeprecatedDOMHTMLFormElement::DeprecatedDOMHTMLFormElement): (DeprecatedDOMHTMLFormElement::AddRef): (DeprecatedDOMHTMLFormElement::Release): (DeprecatedDOMHTMLFormElement::throwException): (DeprecatedDOMHTMLFormElement::callWebScriptMethod): (DeprecatedDOMHTMLFormElement::evaluateWebScript): (DeprecatedDOMHTMLFormElement::removeWebScriptKey): (DeprecatedDOMHTMLFormElement::stringRepresentation): (DeprecatedDOMHTMLFormElement::webScriptValueAtIndex): (DeprecatedDOMHTMLFormElement::setWebScriptValueAtIndex): (DeprecatedDOMHTMLFormElement::setException): (DeprecatedDOMHTMLFormElement::nodeName): (DeprecatedDOMHTMLFormElement::nodeValue): (DeprecatedDOMHTMLFormElement::setNodeValue): (DeprecatedDOMHTMLFormElement::nodeType): (DeprecatedDOMHTMLFormElement::parentNode): (DeprecatedDOMHTMLFormElement::childNodes): (DeprecatedDOMHTMLFormElement::firstChild): (DeprecatedDOMHTMLFormElement::lastChild): (DeprecatedDOMHTMLFormElement::previousSibling): (DeprecatedDOMHTMLFormElement::nextSibling): (DeprecatedDOMHTMLFormElement::attributes): (DeprecatedDOMHTMLFormElement::ownerDocument): (DeprecatedDOMHTMLFormElement::insertBefore): (DeprecatedDOMHTMLFormElement::replaceChild): (DeprecatedDOMHTMLFormElement::removeChild): (DeprecatedDOMHTMLFormElement::appendChild): (DeprecatedDOMHTMLFormElement::hasChildNodes): (DeprecatedDOMHTMLFormElement::cloneNode): (DeprecatedDOMHTMLFormElement::normalize): (DeprecatedDOMHTMLFormElement::isSupported): (DeprecatedDOMHTMLFormElement::namespaceURI): (DeprecatedDOMHTMLFormElement::prefix): (DeprecatedDOMHTMLFormElement::setPrefix): (DeprecatedDOMHTMLFormElement::localName): (DeprecatedDOMHTMLFormElement::hasAttributes): (DeprecatedDOMHTMLFormElement::isSameNode): (DeprecatedDOMHTMLFormElement::isEqualNode): (DeprecatedDOMHTMLFormElement::textContent): (DeprecatedDOMHTMLFormElement::setTextContent): (DeprecatedDOMHTMLFormElement::tagName): (DeprecatedDOMHTMLFormElement::getAttribute): (DeprecatedDOMHTMLFormElement::setAttribute): (DeprecatedDOMHTMLFormElement::removeAttribute): (DeprecatedDOMHTMLFormElement::getAttributeNode): (DeprecatedDOMHTMLFormElement::setAttributeNode): (DeprecatedDOMHTMLFormElement::removeAttributeNode): (DeprecatedDOMHTMLFormElement::getElementsByTagName): (DeprecatedDOMHTMLFormElement::getAttributeNS): (DeprecatedDOMHTMLFormElement::setAttributeNS): (DeprecatedDOMHTMLFormElement::removeAttributeNS): (DeprecatedDOMHTMLFormElement::getAttributeNodeNS): (DeprecatedDOMHTMLFormElement::setAttributeNodeNS): (DeprecatedDOMHTMLFormElement::getElementsByTagNameNS): (DeprecatedDOMHTMLFormElement::hasAttribute): (DeprecatedDOMHTMLFormElement::hasAttributeNS): (DeprecatedDOMHTMLFormElement::focus): (DeprecatedDOMHTMLFormElement::blur): (DeprecatedDOMHTMLFormElement::idName): (DeprecatedDOMHTMLFormElement::setIdName): (DeprecatedDOMHTMLFormElement::title): (DeprecatedDOMHTMLFormElement::setTitle): (DeprecatedDOMHTMLFormElement::lang): (DeprecatedDOMHTMLFormElement::setLang): (DeprecatedDOMHTMLFormElement::dir): (DeprecatedDOMHTMLFormElement::setDir): (DeprecatedDOMHTMLFormElement::className): (DeprecatedDOMHTMLFormElement::setClassName): (DeprecatedDOMHTMLFormElement::innerHTML): (DeprecatedDOMHTMLFormElement::setInnerHTML): (DeprecatedDOMHTMLFormElement::innerText): (DeprecatedDOMHTMLFormElement::setInnerText): (DeprecatedDOMHTMLSelectElement::DeprecatedDOMHTMLSelectElement): (DeprecatedDOMHTMLSelectElement::AddRef): (DeprecatedDOMHTMLSelectElement::Release): (DeprecatedDOMHTMLSelectElement::throwException): (DeprecatedDOMHTMLSelectElement::callWebScriptMethod): (DeprecatedDOMHTMLSelectElement::evaluateWebScript): (DeprecatedDOMHTMLSelectElement::removeWebScriptKey): (DeprecatedDOMHTMLSelectElement::stringRepresentation): (DeprecatedDOMHTMLSelectElement::webScriptValueAtIndex): (DeprecatedDOMHTMLSelectElement::setWebScriptValueAtIndex): (DeprecatedDOMHTMLSelectElement::setException): (DeprecatedDOMHTMLSelectElement::nodeName): (DeprecatedDOMHTMLSelectElement::nodeValue): (DeprecatedDOMHTMLSelectElement::setNodeValue): (DeprecatedDOMHTMLSelectElement::nodeType): (DeprecatedDOMHTMLSelectElement::parentNode): (DeprecatedDOMHTMLSelectElement::childNodes): (DeprecatedDOMHTMLSelectElement::firstChild): (DeprecatedDOMHTMLSelectElement::lastChild): (DeprecatedDOMHTMLSelectElement::previousSibling): (DeprecatedDOMHTMLSelectElement::nextSibling): (DeprecatedDOMHTMLSelectElement::attributes): (DeprecatedDOMHTMLSelectElement::ownerDocument): (DeprecatedDOMHTMLSelectElement::insertBefore): (DeprecatedDOMHTMLSelectElement::replaceChild): (DeprecatedDOMHTMLSelectElement::removeChild): (DeprecatedDOMHTMLSelectElement::appendChild): (DeprecatedDOMHTMLSelectElement::hasChildNodes): (DeprecatedDOMHTMLSelectElement::cloneNode): (DeprecatedDOMHTMLSelectElement::normalize): (DeprecatedDOMHTMLSelectElement::isSupported): (DeprecatedDOMHTMLSelectElement::namespaceURI): (DeprecatedDOMHTMLSelectElement::prefix): (DeprecatedDOMHTMLSelectElement::setPrefix): (DeprecatedDOMHTMLSelectElement::localName): (DeprecatedDOMHTMLSelectElement::hasAttributes): (DeprecatedDOMHTMLSelectElement::isSameNode): (DeprecatedDOMHTMLSelectElement::isEqualNode): (DeprecatedDOMHTMLSelectElement::textContent): (DeprecatedDOMHTMLSelectElement::setTextContent): (DeprecatedDOMHTMLSelectElement::tagName): (DeprecatedDOMHTMLSelectElement::getAttribute): (DeprecatedDOMHTMLSelectElement::setAttribute): (DeprecatedDOMHTMLSelectElement::removeAttribute): (DeprecatedDOMHTMLSelectElement::getAttributeNode): (DeprecatedDOMHTMLSelectElement::setAttributeNode): (DeprecatedDOMHTMLSelectElement::removeAttributeNode): (DeprecatedDOMHTMLSelectElement::getElementsByTagName): (DeprecatedDOMHTMLSelectElement::getAttributeNS): (DeprecatedDOMHTMLSelectElement::setAttributeNS): (DeprecatedDOMHTMLSelectElement::removeAttributeNS): (DeprecatedDOMHTMLSelectElement::getAttributeNodeNS): (DeprecatedDOMHTMLSelectElement::setAttributeNodeNS): (DeprecatedDOMHTMLSelectElement::getElementsByTagNameNS): (DeprecatedDOMHTMLSelectElement::hasAttribute): (DeprecatedDOMHTMLSelectElement::hasAttributeNS): (DeprecatedDOMHTMLSelectElement::focus): (DeprecatedDOMHTMLSelectElement::blur): (DeprecatedDOMHTMLSelectElement::idName): (DeprecatedDOMHTMLSelectElement::setIdName): (DeprecatedDOMHTMLSelectElement::title): (DeprecatedDOMHTMLSelectElement::setTitle): (DeprecatedDOMHTMLSelectElement::lang): (DeprecatedDOMHTMLSelectElement::setLang): (DeprecatedDOMHTMLSelectElement::dir): (DeprecatedDOMHTMLSelectElement::setDir): (DeprecatedDOMHTMLSelectElement::className): (DeprecatedDOMHTMLSelectElement::setClassName): (DeprecatedDOMHTMLSelectElement::innerHTML): (DeprecatedDOMHTMLSelectElement::setInnerHTML): (DeprecatedDOMHTMLSelectElement::innerText): (DeprecatedDOMHTMLSelectElement::setInnerText): (DeprecatedDOMHTMLOptionElement::DeprecatedDOMHTMLOptionElement): (DeprecatedDOMHTMLOptionElement::AddRef): (DeprecatedDOMHTMLOptionElement::Release): (DeprecatedDOMHTMLOptionElement::throwException): (DeprecatedDOMHTMLOptionElement::callWebScriptMethod): (DeprecatedDOMHTMLOptionElement::evaluateWebScript): (DeprecatedDOMHTMLOptionElement::removeWebScriptKey): (DeprecatedDOMHTMLOptionElement::stringRepresentation): (DeprecatedDOMHTMLOptionElement::webScriptValueAtIndex): (DeprecatedDOMHTMLOptionElement::setWebScriptValueAtIndex): (DeprecatedDOMHTMLOptionElement::setException): (DeprecatedDOMHTMLOptionElement::nodeName): (DeprecatedDOMHTMLOptionElement::nodeValue): (DeprecatedDOMHTMLOptionElement::setNodeValue): (DeprecatedDOMHTMLOptionElement::nodeType): (DeprecatedDOMHTMLOptionElement::parentNode): (DeprecatedDOMHTMLOptionElement::childNodes): (DeprecatedDOMHTMLOptionElement::firstChild): (DeprecatedDOMHTMLOptionElement::lastChild): (DeprecatedDOMHTMLOptionElement::previousSibling): (DeprecatedDOMHTMLOptionElement::nextSibling): (DeprecatedDOMHTMLOptionElement::attributes): (DeprecatedDOMHTMLOptionElement::ownerDocument): (DeprecatedDOMHTMLOptionElement::insertBefore): (DeprecatedDOMHTMLOptionElement::replaceChild): (DeprecatedDOMHTMLOptionElement::removeChild): (DeprecatedDOMHTMLOptionElement::appendChild): (DeprecatedDOMHTMLOptionElement::hasChildNodes): (DeprecatedDOMHTMLOptionElement::cloneNode): (DeprecatedDOMHTMLOptionElement::normalize): (DeprecatedDOMHTMLOptionElement::isSupported): (DeprecatedDOMHTMLOptionElement::namespaceURI): (DeprecatedDOMHTMLOptionElement::prefix): (DeprecatedDOMHTMLOptionElement::setPrefix): (DeprecatedDOMHTMLOptionElement::localName): (DeprecatedDOMHTMLOptionElement::hasAttributes): (DeprecatedDOMHTMLOptionElement::isSameNode): (DeprecatedDOMHTMLOptionElement::isEqualNode): (DeprecatedDOMHTMLOptionElement::textContent): (DeprecatedDOMHTMLOptionElement::setTextContent): (DeprecatedDOMHTMLOptionElement::tagName): (DeprecatedDOMHTMLOptionElement::getAttribute): (DeprecatedDOMHTMLOptionElement::setAttribute): (DeprecatedDOMHTMLOptionElement::removeAttribute): (DeprecatedDOMHTMLOptionElement::getAttributeNode): (DeprecatedDOMHTMLOptionElement::setAttributeNode): (DeprecatedDOMHTMLOptionElement::removeAttributeNode): (DeprecatedDOMHTMLOptionElement::getElementsByTagName): (DeprecatedDOMHTMLOptionElement::getAttributeNS): (DeprecatedDOMHTMLOptionElement::setAttributeNS): (DeprecatedDOMHTMLOptionElement::removeAttributeNS): (DeprecatedDOMHTMLOptionElement::getAttributeNodeNS): (DeprecatedDOMHTMLOptionElement::setAttributeNodeNS): (DeprecatedDOMHTMLOptionElement::getElementsByTagNameNS): (DeprecatedDOMHTMLOptionElement::hasAttribute): (DeprecatedDOMHTMLOptionElement::hasAttributeNS): (DeprecatedDOMHTMLOptionElement::focus): (DeprecatedDOMHTMLOptionElement::blur): (DeprecatedDOMHTMLOptionElement::idName): (DeprecatedDOMHTMLOptionElement::setIdName): (DeprecatedDOMHTMLOptionElement::title): (DeprecatedDOMHTMLOptionElement::setTitle): (DeprecatedDOMHTMLOptionElement::lang): (DeprecatedDOMHTMLOptionElement::setLang): (DeprecatedDOMHTMLOptionElement::dir): (DeprecatedDOMHTMLOptionElement::setDir): (DeprecatedDOMHTMLOptionElement::className): (DeprecatedDOMHTMLOptionElement::setClassName): (DeprecatedDOMHTMLOptionElement::innerHTML): (DeprecatedDOMHTMLOptionElement::setInnerHTML): (DeprecatedDOMHTMLOptionElement::innerText): (DeprecatedDOMHTMLOptionElement::setInnerText): (DeprecatedDOMHTMLInputElement::DeprecatedDOMHTMLInputElement): (DeprecatedDOMHTMLInputElement::AddRef): (DeprecatedDOMHTMLInputElement::Release): (DeprecatedDOMHTMLInputElement::throwException): (DeprecatedDOMHTMLInputElement::callWebScriptMethod): (DeprecatedDOMHTMLInputElement::evaluateWebScript): (DeprecatedDOMHTMLInputElement::removeWebScriptKey): (DeprecatedDOMHTMLInputElement::stringRepresentation): (DeprecatedDOMHTMLInputElement::webScriptValueAtIndex): (DeprecatedDOMHTMLInputElement::setWebScriptValueAtIndex): (DeprecatedDOMHTMLInputElement::setException): (DeprecatedDOMHTMLInputElement::nodeName): (DeprecatedDOMHTMLInputElement::nodeValue): (DeprecatedDOMHTMLInputElement::setNodeValue): (DeprecatedDOMHTMLInputElement::nodeType): (DeprecatedDOMHTMLInputElement::parentNode): (DeprecatedDOMHTMLInputElement::childNodes): (DeprecatedDOMHTMLInputElement::firstChild): (DeprecatedDOMHTMLInputElement::lastChild): (DeprecatedDOMHTMLInputElement::previousSibling): (DeprecatedDOMHTMLInputElement::nextSibling): (DeprecatedDOMHTMLInputElement::attributes): (DeprecatedDOMHTMLInputElement::ownerDocument): (DeprecatedDOMHTMLInputElement::insertBefore): (DeprecatedDOMHTMLInputElement::replaceChild): (DeprecatedDOMHTMLInputElement::removeChild): (DeprecatedDOMHTMLInputElement::appendChild): (DeprecatedDOMHTMLInputElement::hasChildNodes): (DeprecatedDOMHTMLInputElement::cloneNode): (DeprecatedDOMHTMLInputElement::normalize): (DeprecatedDOMHTMLInputElement::isSupported): (DeprecatedDOMHTMLInputElement::namespaceURI): (DeprecatedDOMHTMLInputElement::prefix): (DeprecatedDOMHTMLInputElement::setPrefix): (DeprecatedDOMHTMLInputElement::localName): (DeprecatedDOMHTMLInputElement::hasAttributes): (DeprecatedDOMHTMLInputElement::isSameNode): (DeprecatedDOMHTMLInputElement::isEqualNode): (DeprecatedDOMHTMLInputElement::textContent): (DeprecatedDOMHTMLInputElement::setTextContent): (DeprecatedDOMHTMLInputElement::tagName): (DeprecatedDOMHTMLInputElement::getAttribute): (DeprecatedDOMHTMLInputElement::setAttribute): (DeprecatedDOMHTMLInputElement::removeAttribute): (DeprecatedDOMHTMLInputElement::getAttributeNode): (DeprecatedDOMHTMLInputElement::setAttributeNode): (DeprecatedDOMHTMLInputElement::removeAttributeNode): (DeprecatedDOMHTMLInputElement::getElementsByTagName): (DeprecatedDOMHTMLInputElement::getAttributeNS): (DeprecatedDOMHTMLInputElement::setAttributeNS): (DeprecatedDOMHTMLInputElement::removeAttributeNS): (DeprecatedDOMHTMLInputElement::getAttributeNodeNS): (DeprecatedDOMHTMLInputElement::setAttributeNodeNS): (DeprecatedDOMHTMLInputElement::getElementsByTagNameNS): (DeprecatedDOMHTMLInputElement::hasAttribute): (DeprecatedDOMHTMLInputElement::hasAttributeNS): (DeprecatedDOMHTMLInputElement::focus): (DeprecatedDOMHTMLInputElement::blur): (DeprecatedDOMHTMLInputElement::idName): (DeprecatedDOMHTMLInputElement::setIdName): (DeprecatedDOMHTMLInputElement::title): (DeprecatedDOMHTMLInputElement::setTitle): (DeprecatedDOMHTMLInputElement::lang): (DeprecatedDOMHTMLInputElement::setLang): (DeprecatedDOMHTMLInputElement::dir): (DeprecatedDOMHTMLInputElement::setDir): (DeprecatedDOMHTMLInputElement::className): (DeprecatedDOMHTMLInputElement::setClassName): (DeprecatedDOMHTMLInputElement::innerHTML): (DeprecatedDOMHTMLInputElement::setInnerHTML): (DeprecatedDOMHTMLInputElement::innerText): (DeprecatedDOMHTMLInputElement::setInnerText): (DeprecatedDOMHTMLTextAreaElement::DeprecatedDOMHTMLTextAreaElement): (DeprecatedDOMHTMLTextAreaElement::AddRef): (DeprecatedDOMHTMLTextAreaElement::Release): (DeprecatedDOMHTMLTextAreaElement::throwException): (DeprecatedDOMHTMLTextAreaElement::callWebScriptMethod): (DeprecatedDOMHTMLTextAreaElement::evaluateWebScript): (DeprecatedDOMHTMLTextAreaElement::removeWebScriptKey): (DeprecatedDOMHTMLTextAreaElement::stringRepresentation): (DeprecatedDOMHTMLTextAreaElement::webScriptValueAtIndex): (DeprecatedDOMHTMLTextAreaElement::setWebScriptValueAtIndex): (DeprecatedDOMHTMLTextAreaElement::setException): (DeprecatedDOMHTMLTextAreaElement::nodeName): (DeprecatedDOMHTMLTextAreaElement::nodeValue): (DeprecatedDOMHTMLTextAreaElement::setNodeValue): (DeprecatedDOMHTMLTextAreaElement::nodeType): (DeprecatedDOMHTMLTextAreaElement::parentNode): (DeprecatedDOMHTMLTextAreaElement::childNodes): (DeprecatedDOMHTMLTextAreaElement::firstChild): (DeprecatedDOMHTMLTextAreaElement::lastChild): (DeprecatedDOMHTMLTextAreaElement::previousSibling): (DeprecatedDOMHTMLTextAreaElement::nextSibling): (DeprecatedDOMHTMLTextAreaElement::attributes): (DeprecatedDOMHTMLTextAreaElement::ownerDocument): (DeprecatedDOMHTMLTextAreaElement::insertBefore): (DeprecatedDOMHTMLTextAreaElement::replaceChild): (DeprecatedDOMHTMLTextAreaElement::removeChild): (DeprecatedDOMHTMLTextAreaElement::appendChild): (DeprecatedDOMHTMLTextAreaElement::hasChildNodes): (DeprecatedDOMHTMLTextAreaElement::cloneNode): (DeprecatedDOMHTMLTextAreaElement::normalize): (DeprecatedDOMHTMLTextAreaElement::isSupported): (DeprecatedDOMHTMLTextAreaElement::namespaceURI): (DeprecatedDOMHTMLTextAreaElement::prefix): (DeprecatedDOMHTMLTextAreaElement::setPrefix): (DeprecatedDOMHTMLTextAreaElement::localName): (DeprecatedDOMHTMLTextAreaElement::hasAttributes): (DeprecatedDOMHTMLTextAreaElement::isSameNode): (DeprecatedDOMHTMLTextAreaElement::isEqualNode): (DeprecatedDOMHTMLTextAreaElement::textContent): (DeprecatedDOMHTMLTextAreaElement::setTextContent): (DeprecatedDOMHTMLTextAreaElement::tagName): (DeprecatedDOMHTMLTextAreaElement::getAttribute): (DeprecatedDOMHTMLTextAreaElement::setAttribute): (DeprecatedDOMHTMLTextAreaElement::removeAttribute): (DeprecatedDOMHTMLTextAreaElement::getAttributeNode): (DeprecatedDOMHTMLTextAreaElement::setAttributeNode): (DeprecatedDOMHTMLTextAreaElement::removeAttributeNode): (DeprecatedDOMHTMLTextAreaElement::getElementsByTagName): (DeprecatedDOMHTMLTextAreaElement::getAttributeNS): (DeprecatedDOMHTMLTextAreaElement::setAttributeNS): (DeprecatedDOMHTMLTextAreaElement::removeAttributeNS): (DeprecatedDOMHTMLTextAreaElement::getAttributeNodeNS): (DeprecatedDOMHTMLTextAreaElement::setAttributeNodeNS): (DeprecatedDOMHTMLTextAreaElement::getElementsByTagNameNS): (DeprecatedDOMHTMLTextAreaElement::hasAttribute): (DeprecatedDOMHTMLTextAreaElement::hasAttributeNS): (DeprecatedDOMHTMLTextAreaElement::focus): (DeprecatedDOMHTMLTextAreaElement::blur): (DeprecatedDOMHTMLTextAreaElement::idName): (DeprecatedDOMHTMLTextAreaElement::setIdName): (DeprecatedDOMHTMLTextAreaElement::title): (DeprecatedDOMHTMLTextAreaElement::setTitle): (DeprecatedDOMHTMLTextAreaElement::lang): (DeprecatedDOMHTMLTextAreaElement::setLang): (DeprecatedDOMHTMLTextAreaElement::dir): (DeprecatedDOMHTMLTextAreaElement::setDir): (DeprecatedDOMHTMLTextAreaElement::className): (DeprecatedDOMHTMLTextAreaElement::setClassName): (DeprecatedDOMHTMLTextAreaElement::innerHTML): (DeprecatedDOMHTMLTextAreaElement::setInnerHTML): (DeprecatedDOMHTMLTextAreaElement::innerText): (DeprecatedDOMHTMLTextAreaElement::setInnerText):
  • Interfaces/DOMCSS.idl:
  • Interfaces/DOMCore.idl:
  • Interfaces/DOMEvents.idl:
  • Interfaces/DOMExtensions.idl:
  • Interfaces/DOMHTML.idl:
  • Interfaces/DOMPrivate.idl:
  • Interfaces/DOMRange.idl:
  • Interfaces/DOMWindow.idl:
  • Interfaces/IWebEditingDelegate.idl:
  • Interfaces/IWebFormDelegate.idl:
  • Interfaces/IWebFrame.idl:
  • Interfaces/IWebHTMLRepresentation.idl:
  • Interfaces/IWebView.idl:
  • WebEditorClient.cpp: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldInsertText): (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea):
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::Read):
  • WebFrame.cpp: (elementFromDOMElement): (formElementFromDOMElement): (inputElementFromDOMElement): (WebFrame::DOMDocument): (WebFrame::frameElement): (WebFrame::currentForm): (WebFrame::elementWithName): (WebFrame::formForElement): (WebFrame::elementDoesAutoComplete): (WebFrame::controlsInForm): (WebFrame::elementIsPassword): (WebFrame::searchForLabelsBeforeElement): (WebFrame::matchLabelsAgainstElement): (WebFrame::dispatchWillSubmitForm):
  • WebFrame.h:
  • WebHTMLRepresentation.cpp: (WebHTMLRepresentation::attributedStringFromDOMNodes): (WebHTMLRepresentation::elementWithName): (WebHTMLRepresentation::elementDoesAutoComplete): (WebHTMLRepresentation::elementIsPassword): (WebHTMLRepresentation::formForElement): (WebHTMLRepresentation::currentForm): (WebHTMLRepresentation::controlsInForm): (WebHTMLRepresentation::searchForLabels): (WebHTMLRepresentation::matchLabels):
  • WebHTMLRepresentation.h:
  • WebView.cpp: (WebView::mainFrameDocument): (WebView::computedStyleForElement): (WebView::editableDOMRangeForPoint): (WebView::setSelectedDOMRange): (WebView::selectedDOMRange): (WebView::setTypingStyle): (WebView::typingStyle): (WebView::styleDeclarationWithText): (WebView::replaceSelectionWithNode): (WebView::applyStyle):
  • WebView.h:
12:38 PM Changeset in webkit [25215] by antti
  • 3 edits in trunk/WebCore

Reviewed by Oliver

Fix <rdar://problem/5393758>
Crash in WebCore::FontData::platformInit


Null check glyph page.


If font has somehow failed to initialize it is possible to have null glyph page. Based on
crash dumps this seems to occasionally happen when running Mail under guard malloc.


No test case, I don't know how to get to this state.

  • platform/FontData.cpp: (WebCore::FontData::FontData):
  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):
12:35 PM Changeset in webkit [25214] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=15071
[cairo] SVG skews are incorrect

Fix Cairo implementation of AffineTransform::shear so that shearing is
done in the correct direction.

  • platform/graphics/cairo/AffineTransformCairo.cpp: (WebCore::AffineTransform::shear):
12:24 AM Changeset in webkit [25213] by oliver
  • 2 edits in trunk/WebKitTools

Reviewed by John H.

WebDataSource::response can legitimately have a null response, so we
must check that case.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (queueLoadCallback):

Aug 23, 2007:

5:41 PM Changeset in webkit [25212] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Dave Hyatt.

<rdar://problem/5410937> HIWebView in SimpleCarbonWeb doesn't seem to be getting adequate invalidation when window is resized

The Carbon HIWebView was relying on layout happening when displayIfNeededInRect: was called on the WebView.
This would happen on Tiger because _recursiveDisplayRectIfNeededIgnoringOpacity: would always do a layout if needed.
Doing a layout in _recursiveDisplayRectIfNeededIgnoringOpacity was removed in Leopard in favor of viewWillDraw, and
the fact that adding new dirty rects inside _recursiveDisplayRectIfNeededIgnoringOpacity on Leopard will not
cause a drawRect in the same display loop.

So any client on Leopard calling displayIfNeeded* on the WebView would get a layout and any new dirty rects. So
_web_layoutIfNeededRecursive needs to be called on the main frame's WebHTMLView to make sure we layout and
display anything that is really needed.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _layoutIfNeeded]): (-[WebHTMLView _web_layoutIfNeededRecursive]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.mm: (-[WebView displayIfNeeded]): Call _web_layoutIfNeededRecursive on the main WebHTMLView. (-[WebView displayIfNeededIgnoringOpacity]): Ditto. (-[WebView displayIfNeededInRect:]): Ditto. (-[WebView displayIfNeededInRectIgnoringOpacity:]): Ditto.
4:31 PM Changeset in webkit [25211] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by .

  • window-resize.html now passes.
  • platform/win/Skipped:
3:41 PM Changeset in webkit [25210] by sfalken
  • 1 copy in tags/Safari-523.1.2b

New tag.

3:41 PM Changeset in webkit [25209] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

2:25 PM Changeset in webkit [25208] by weinig
  • 14 edits in trunk

Make life on Windows a little better by adding generated VS files to svn:ignore list

1:18 PM Changeset in webkit [25207] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Steve.

If necessary, re-set the window proc after each call to NPP_SetWindow. This is to ensure that
our window proc is always run even if a plug-in subclasses the window and replaces the window proc.


Also, make sure that the default window proc is of type ASCII so we can eliminate the

  • plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::setNPWindowRect): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::PluginViewWin): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::): (WebCore::PluginViewWin::pluginWndProc):
1:13 PM Changeset in webkit [25206] by ddkilzer
  • 6 edits
    5 adds in trunk

WebCore:

Updated old ChangeLog entry with bug title and test information.

WebKitTools:

Reviewed by Darin and Adam.

Use a frame group name for all WebViews created by DumpRenderTree to
allow testing of cross-page frame lookup.

  • DumpRenderTree/DumpRenderTree.m: (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).

LayoutTests:

Reviewed by Adam.

  • http/tests/navigation/resources/target-frame-from-window-end.html: Added.
  • http/tests/navigation/resources/target-frame-from-window-popup.html: Added.
  • http/tests/navigation/resources/target-frame-from-window-start.html: Added.
  • http/tests/navigation/target-frame-from-window-expected.txt: Added.
  • http/tests/navigation/target-frame-from-window.html: Added.
  • platform/win/Skipped: Added http/tests/navigation/target-frame-from-window.html to skip list.
12:14 PM Changeset in webkit [25205] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-08-23 w3liu <​wei.liu@nokia.com>

Reviewed by <​sriram.yadavalli@nokia.com>.
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly (extra fix to handle js disable)
​http://bugs.webkit.org/show_bug.cgi?id=15049

12:09 PM Changeset in webkit [25204] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-08-23 w3liu <​wei.liu@nokia.com>

Reviewed by <​sriram.yadavalli@nokia.com>.
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly (extra fix to handle js disable)
​http://bugs.webkit.org/show_bug.cgi?id=15049

11:11 AM Changeset in webkit [25203] by justing
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Adele.

<rdar://problem/5156801> REGRESSION: Crash at DeleteSelectionCommand::doApply() when deleting table content

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr for node. If the node to be removed contains the selection, and if the next node to be removed (nextNode) is inside the deletion UI, removing node will remove nextNode from the document. nextNode is a RefPtr, but node isn't and when nextNode falls out of scope the node that node points to will be destroyed and we'll end up using a stale pointer. Long term we should probably just disable the deletion UI before editing operations because the undo of the removal of node in the situation described above relies on the presence of the deletion UI, but it isn't present because its added and removed in a non-undoable way.

LayoutTests:

Reviewed by Adele.


<rdar://problem/5156801> REGRESSION: Crash at DeleteSelectionCommand::doApply() when deleting table content

  • editing/deleting/5156801-2.html: Added.
  • platform/mac/editing/deleting: Added.
  • platform/mac/editing/deleting/5156801-2-expected.checksum: Added.
  • platform/mac/editing/deleting/5156801-2-expected.png: Added.
  • platform/mac/editing/deleting/5156801-2-expected.txt: Added.
10:20 AM Changeset in webkit [25202] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

Quote the $sslCertificate path in case it contains a space.

  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
9:47 AM Changeset in webkit [25201] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-08-22 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin.
DESC: TSW ID: SJUN-73XBVC. Text appears overlapped with document.write in onload
​http://bugs.webkit.org/show_bug.cgi?id=14915


  • BrowserView/src/WebKitView.cpp: (CWebKitView::SyncRepaint):
9:46 AM Changeset in webkit [25200] by spadma
  • 2 edits in S60/trunk/WebKit

rathnasa, reviewed by spadma

DESC: TSW ID: SJUN-73XBVC. Text appears overlapped with document.write in onload
​http://bugs.webkit.org/show_bug.cgi?id=14915


  • BrowserView/src/WebKitView.cpp: (CWebKitView::SyncRepaint):


5:37 AM Changeset in webkit [25199] by zbujtas
  • 4 edits in S60/trunk/WebCore

2007-08-22 w3liu <​wei.liu@nokia.com>

Reviewed by <​sriram.yadavalli@nokia.com>
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly

5:34 AM Changeset in webkit [25198] by zbujtas
  • 4 edits in S60/branches/3.1m/WebCore

2007-08-22 w3liu <​wei.liu@nokia.com>

Reviewed by <​sriram.yadavalli@nokia.com>
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly

12:44 AM Changeset in webkit [25197] by andrew
  • 4 edits
    1 add in trunk/WebCore

2007-08-23 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

WebKit copies the width and height attributes of an <embed> to its
nearest <object> ancestor. This used to be done in updateWidget(), but
that could lead to the document being dirty right after layout and
before painting. The patch moves the copying of the attributes to when
the <embed> is inserted into the document or its attributes change.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::insertedIntoDocument): (WebCore::HTMLEmbedElement::attributeChanged):
  • html/HTMLEmbedElement.h:
  • manual-tests/bugzilla-14899.html: Added.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):

Aug 22, 2007:

10:02 PM Changeset in webkit [25196] by oliver
  • 2 edits in trunk/WebKitTools

Reviewed by John and Adam.


WebDataSource::response can legitimately have a null response, so we
must check that case.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump):
5:31 PM Changeset in webkit [25195] by honeycutt
  • 4 edits in trunk/WebKit/win

2007-08-22 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

Refactoring of <radr://problem/5220598> Dragging URL out and back
inserts a second copy of the URL

  • Interfaces/IWebViewPrivate.idl: Added setCustomDropTarget and removeCustomDropTarget
  • WebView.cpp: (WebView::WebView): Initialize m_hasCustomDropTarget (WebView::setCustomDropTarget): Revoke any existing drop target and set the incoming drop target. (WebView::removeCustomDropTarget): Revoke any existing drop target and set the default drop target.
  • WebView.h:
5:22 PM Changeset in webkit [25194] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin and Oliver.

<rdar://problem/5422410>
​http://bugs.webkit.org/show_bug.cgi?id=15019
REGRESSION (r25124-r25140): New posts and hot topics won't show at mobile01.com

Remove the call to checkCallImplicitClose(). Calling it in loadPlugin is bad for two reasons:


  1. It could cause onload to be dispatched even when the page has subresources that are still loading, such as images.


  1. Now that loadPlugin is called during layout, it could cause onload to be dispatched during layout, which can execute javascript and do pretty much anything while the render tree is in an inconsistent state.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin):
4:56 PM Changeset in webkit [25193] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5430584>
​http://bugs.webkit.org/show_bug.cgi?id=15053
WebKit does not check Windows Registry HKEY_CURRENT_USER for NPAPI plugin locations


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginsFromRegistry): (WebCore::PluginDatabaseWin::getPluginsInPaths):
2:56 PM Changeset in webkit [25192] by justing
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Adam.


<rdar://problem/5418891> CrashTracer: [USER] 1 crash in Mail at -[WebViewEditor webView:shouldInsertText:replacingDOMRange:givenAction:]

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): We're reusing the topBlockquote variable. Null it out first. If there is no new topBlockquote and we don't null it out first, we'll assume that there was a new one and crash.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5418891> CrashTracer: [USER] 1 crash in Mail at -[WebViewEditor webView:shouldInsertText:replacingDOMRange:givenAction:]

  • editing/inserting/5418891.html: Added.
  • platform/mac/editing/inserting: Added.
  • platform/mac/editing/inserting/5418891-expected.checksum: Added.
  • platform/mac/editing/inserting/5418891-expected.png: Added.
  • platform/mac/editing/inserting/5418891-expected.txt: Added.
2:23 PM Changeset in webkit [25191] by thatcher
  • 12 edits in trunk/WebKit

Rolling out r25102 for <rdar://problem/5410937> until
<rdar://problem/5429920> is resolved.

  • Carbon/CarbonUtils.m: (WebInitForCarbon): (PoolCleaner):
  • Carbon/CarbonWindowAdapter.h:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.h:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.h:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.h:
  • Carbon/HIViewAdapter.m:
  • Carbon/HIWebView.h:
  • Carbon/HIWebView.m:
1:38 PM Changeset in webkit [25190] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

malaiya, reviewed by <​zbujtas@gmail.com>

DESC: TSW Id: ESMS-766JBW - Browser goes back in history when leaving input field
​http://bugs.webkit.org/show_bug.cgi?id=15050

1:36 PM Changeset in webkit [25189] by zbujtas
  • 2 edits in S60/trunk/WebCore

malaiya, reviewed by <​zbujtas@gmail.com>

DESC: TSW Id: ESMS-766JBW - Browser goes back in history when leaving input field
​http://bugs.webkit.org/show_bug.cgi?id=15050

1:10 PM Changeset in webkit [25188] by kmccullo
  • 5 edits in trunk

LayoutTests:

Reviewed by Adele.

  • rdar:5423067 Reapplying the change but only when the text area is in focus.
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/cursor-position.html:

WebCore:

Reviewed by Adele.

  • rdar:5423067 Reapplyingthe change but only when the text area is in focus.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
12:58 PM Changeset in webkit [25187] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5249757> Painting of JPGs in WebKit is too slow.

Use a new Leopard API for fast tiling of images. We only use this API
when the whole image is being tiled and when the current CGImageRef to tile
has a size that matches the size of the whole image.

We can optimize border-image in the future by adding a cache of the 9
sub-images.

Reviewed by darin

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
11:12 AM Changeset in webkit [25186] by kmccullo
  • 5 edits in trunk

LayoutTests:

  • Rolling back since I neeed to update some layouttests this change broke.
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/cursor-position.html:

WebCore:

  • Rolling back since I need to update some layouttests this change breaks.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
10:43 AM Changeset in webkit [25185] by kmccullo
  • 5 edits in trunk

LayoutTests:

Reviewed by Geof, Adam, Hyatt, Maciej and Oliver.

  • In order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area instead of remembering the location of the selection.
  • <rdar://problem/5423067> gmail is super annoying when trying to add a new name to the TO, CC or BCC fields
  • fast/forms/cursor-position-expected.txt:
  • fast/forms/cursor-position.html:

WebCore:

Reviewed by Geof, Adam, Hyatt, Maciej and Oliver.

  • In order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area instead of remembering the location of the selection.
  • <rdar://problem/5423067> gmail is super annoying when trying to add a new name to the TO, CC or BCC fields
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
10:40 AM Changeset in webkit [25184] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by Geof.

  • Changing the usage to be more clear.
  • Scripts/run-testkjs:

Aug 21, 2007:

11:33 PM Changeset in webkit [25183] by rwlbuis
  • 10 edits in branches/feature-branch

Reviewed by Sam.

​http://bugs.webkit.org/show_bug.cgi?id=12059
SVG colors have two separate parsing paths (one CSS and one SVGColor::setRGBColor)

Reuse the css parser as much as possible in setRGBColor.

6:35 PM Changeset in webkit [25182] by aroben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added a couple more failures.
4:40 PM Changeset in webkit [25181] by aroben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some more failing tests.
3:32 PM Changeset in webkit [25180] by adachan
  • 2 edits in trunk/WebKit/win

Fix <rdar://problem/5416630> Accelerator to open link in window in background opens window in foreground instead
Placing tooltip window at the topmost in z-order brought windows that were opened in the
background to the front. Use HWND_TOP instead.

Reviewed by Adam.


  • WebView.cpp: (WebView::initializeToolTipWindow):
3:08 PM Changeset in webkit [25179] by aroben
  • 3 edits in trunk/WebCore

Build fix for Mac

Keep FrameView::layoutIfNeededRecursive Windows- and Gtk-only for now
(sadly). This will have to wait until we merge ScrollView and FrameView.

Reviewed by NOBODY.

  • page/FrameView.cpp:
  • page/FrameView.h:
2:49 PM Changeset in webkit [25178] by aroben
  • 2 edits in trunk/WebCore

Fix an ASSERT when using Find in Page

Reviewed by Darin.

No test possible.

  • bridge/win/FrameWin.cpp: (WebCore::imageFromSelection): Make sure to update layout before painting so we don't hit an ASSERT in painting code (Frame::selectionImage in FrameMac.mm does this as well).
2:49 PM Changeset in webkit [25177] by aroben
  • 7 edits in trunk

Switch Windows to using FrameView::layoutIfNeededRecursive

WebCore:

Made FrameView::layoutIfNeededRecursive available to all platforms

Currently it's only used on Gtk+ and Windows.

Reviewed by Darin.

  • page/FrameView.cpp: Removed #ifdef.
  • page/FrameView.h: Ditto.

WebKit/win:

Switch Windows to using FrameView::layoutIfNeededRecursive

Reviewed by Darin.

  • WebFrame.cpp: Removed layoutIfNeededRecursive.
  • WebFrame.h: Ditto.
  • WebView.cpp: (WebView::updateBackingStore): Call FrameView::layoutIfNeededRecursive.
2:44 PM Changeset in webkit [25176] by zimmermann
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Allow to pass a filename to dumpOutputImage via debugger.
Make it only available in debug builds and remove the runtime define: DEBUG_OUTPUT_IMAGE.

2:28 PM Changeset in webkit [25175] by zimmermann
  • 195 edits in branches/feature-branch

Reviewed by Oliver.

Large SVG filter rework. Bring it back in a useable state.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5527 (Filters need subregion support)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5579 (WebKit+SVG renders full-filters-example incorrectly)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5976 (filterUnits="userSpaceOnUse" is broken (breaking feTile test case))
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12064 (Need function for manual style-resolution for things like gradient stops)

filters-blend-01-b.svg & filters-example-01-b.svg & filters-displace-01-b.svg & filters-diffuse-01-f.svg are fixed now.

In detail:

  • flood-color & flood-opacity have been incorrectly resolved on the <feBlend> parent element!
  • sizing of filter region was truncated in some cases, as the bbox was used to resolve the needed filter region instead of the filter rect
  • add subregion support to all filter primitives (primitiveUnits & filterUnits handled in all cases)
  • WKDisplacmentMap.cikernel incorrectly flipped the y-axis.
  • Correctly specify default values for all filter primitives in ksvg2/svg!
  • Initialize all variables of the SVGFE* classes in platform/graphics/svg/filters.
  • Fix 'flood-color' initial value (was set to the _stop_ color initial value)

-> both initial values were pointing to 'black' though, so it was no visible problem.

  • Parse 'lighting-color' css property, no more hacking in SVGFEDiffuseLighting.

-> Correct it's initial from black to white value fixes SVG lighting filters!

  • Add diffuseConstant support to feDiffuseLighting filter.
  • Centralize manual style resolution (needed for stop-color, flood-color & flood-opacity, lighting-color)
12:12 PM Changeset in webkit [25174] by adele
  • 2 edits in trunk/WebCore

Build fix for release build.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
11:01 AM Changeset in webkit [25173] by spadma
  • 2 edits in S60/trunk/WebKit

2007-08-02 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: ZBUS-744GX5 - No key events for text input
​http://bugs.webkit.org/show_bug.cgi?id=13877

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::OfferKeyEventL):
10:59 AM Changeset in webkit [25172] by spadma
  • 3 edits in S60/trunk/WebKit

yadavall, reviewed by <sachin>

DESC: Fast display mode must be turned OFF for widgets
​http://bugs.webkit.org/show_bug.cgi?id=14966

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateChildFrameNamed):
10:57 AM Changeset in webkit [25171] by adele
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/table/max-width-integer-overflow.html

Avoid integer overflows when dealing with maximum widths by
1) using floating point arithmetic when summing or multiplying column max widths
2) capping max widths at INT_MAX / 2

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcPrefWidths): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):

LayoutTests:

Reviewed by Darin.

  • fast/table/max-width-integer-overflow.html: Added.
  • platform/mac/fast/table: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.checksum: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.png: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.txt: Added.
9:28 AM Changeset in webkit [25170] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

Removed stray conflict marker.

7:32 AM Changeset in webkit [25169] by sullivan
  • 17 edits
    1 add in trunk

WebCore:

Reviewed by Adam Roben

WebCore part of fix for:
<rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings


Adele wrote the first version of this patch. No test cases added because I made sure the
layout tests are unaffected. Two additional bug fixes were made in passing, but neither
of them had any effect on any known real-world case, and both were too difficult to write
test cases for to be worthwhile.

  • WebCore.exp: added symbols for these new functions so WebKit can call them


  • WebCore.xcodeproj/project.pbxproj: updated for new file


  • platform/graphics/mac/ColorMac.h: Added. New file to hold the increasing amount of Mac-specific color stuff.


  • platform/graphics/Color.h: removed #if PLATFORM(MAC) code, which is now in ColorMac.h


  • platform/graphics/mac/ColorMac.mm: (WebCore::makeRGBAFromNSColor): new static function to convert an NSColor object to an RGBA32 struct (WebCore::colorFromNSColor): new public function to convert an NSColor object to a WebCore-style Color object (WebCore::focusRingColor): Uses (cached) systemFocusRingColor instead of hardwired values, unless usesTestModeFocusRingColor is true, in which case it uses the old hardwired color (WebCore::usesTestModeFocusRingColor): returns value of global var (WebCore::setUsesTestModeFocusRingColor): sets value of global var (+[WebCoreControlTintObserver controlTintDidChange]): Uses [NSColor keyboardFocusIndicatorColor] to set systemFocusRingColor; don't compile if COLORMATCH_EVERYTHING is set since we don't know what it would take to satisfy this state.
  • bindings/objc/DOMRGBColor.mm: now includes ColorMac.h to account for moved declarations
  • bridge/mac/WebCoreAXObject.mm: ditto


  • page/mac/FrameMac.mm: (WebCore::convertAttributesToUnderlines): now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because this function is only used to convert the color of an input manager's marked text underline, which is always black


  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setBaseBackgroundColor:]): now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because this function is only called with a grayscale color perhaps containing an alpha value


  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations): just updated a comment

WebKit:

Reviewed by Adam Roben


WebKit part of fix for:
<rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings

  • Misc/WebNSAttributedStringExtras.mm: now includes <WebCore/ColorMac.h> to account for moved declaration
  • WebView/WebFrame.mm: ditto


  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm: (+[WebView _setUsesTestModeFocusRingColor:]): new SPI, calls through to new WebCore function. This is used by DumpRenderTree to make sure the focus ring color is always the same when performing layout tests, regardless of OS X version. (+[WebView _usesTestModeFocusRingColor]): new SPI, calls through to new WebCore function

WebKitTools:

Reviewed by Adam Roben

  • DumpRenderTree/DumpRenderTree.m: (runTest): call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors in layout tests on Tiger and Leopard

Aug 20, 2007:

6:37 PM Changeset in webkit [25168] by pewtermoose
  • 3 edits
    6 adds in trunk

WebCore:

2007-08-20 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/repaint/layer-visibility.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): Cache the layer's rects when it changes to visible.

LayoutTests:

2007-08-20 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/repaint/layer-visibility.html: Added.
  • platform/mac/fast: Added.
  • platform/mac/fast/repaint: Added.
  • platform/mac/fast/repaint/layer-visibility-expected.checksum: Added.
  • platform/mac/fast/repaint/layer-visibility-expected.png: Added.
  • platform/mac/fast/repaint/layer-visibility-expected.txt: Added.
5:14 PM Changeset in webkit [25167] by aroben
  • 2 edits in trunk/WebKitSite

Remove any mention of drwtsn32.log, as it is almost never useful for tracking down crashes

Reviewed by Oliver.

  • quality/crashlogs.html:
5:08 PM Changeset in webkit [25166] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/5325262> REGRESSION (Tiger-Leopard): PictureTalk plug-in doesn't work

The problem was that this particular plug-in handles "text/ptf", but WebCore wasn't giving the plug-in a chance to load
any type with "text/"

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Allow plug-ins to once again use "text/" MIME types, but only if the MIME type is not "text/plain". Disallowing plug-ins to use text/plain prevents plug-ins from hijacking a fundamental type that the browser is expected to handle, and also serves as an optimization to prevent loading the plug-in database in the common case.
4:46 PM Changeset in webkit [25165] by aroben
  • 2 edits in trunk/LayoutTests

Removed a now-working test from the Windows Skipped file

  • platform/win/Skipped:
4:36 PM Changeset in webkit [25164] by aroben
  • 2 edits in trunk/WebKitTools

Put LayoutTests after all other ChangeLogs in commit logs

We use "~" to sort LayoutTests after all the other ChangeLogs because
"~" is the last ASCII character (other than "DEL").

Reviewed by Sam.

  • Scripts/commit-log-editor:
4:18 PM Changeset in webkit [25163] by aroben
  • 2 edits in trunk/WebKitTools

Detect that DRT crashed even if a crash dialog is running

On Windows, when DRT crashes a crash dialog commonly appears. The DRT
process is still running at this point, so run-webkit-tests wouldn't
detect that DRT had crashed. We now record the crash in our SIGPIPE
handler so that we know if DRT crashed even if the crash dialog is up.

Reviewed by Sam.

  • Scripts/run-webkit-tests: (sub catch_pipe): Set the crashed bit. (sub openDumpTool): Reset the crashed bit. (sub dumpToolDidCrash): Check the crashed bit.
4:04 PM Changeset in webkit [25162] by aroben
  • 3 edits
    4 adds in trunk

Remove workarounds for <rdar://problem/5386894> now that it's been fixed

WebCore:

Remove workarounds for <rdar://problem/5386894> now that it's been fixed

Reviewed by Darin.

Tests: fast/loader/local-svg-parsed-as-svg.svg

fast/loader/local-xhtml-parsed-as-xhtml.xhtml

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Removed hackish workaround.

LayoutTests:

Tests to ensure that local .xhtml and .svg files end up being parsed as XHTML and SVG, respectively

Reviewed by Darin.

  • fast/loader/local-svg-parsed-as-svg-expected.txt: Added.
  • fast/loader/local-svg-parsed-as-svg.svg: Added.
  • fast/loader/local-xhtml-parsed-as-xhtml-expected.txt: Added.
  • fast/loader/local-xhtml-parsed-as-xhtml.xhtml: Added.
3:05 PM Changeset in webkit [25161] by kmccullo
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff and Adam.

  • Changing stack depth to 500 (from 100 on mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045)
  • kjs/object.cpp:

LayoutTests:

Reviewed by Geoff and Adam.

  • Changing stack depth toi 500 (from 100 in mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045).
  • fast/js/deep-recursion-test-expected.txt: Added.
  • fast/js/deep-recursion-test.html: Added.
2:41 PM Changeset in webkit [25160] by aroben
  • 2 edits in trunk/WebKitTools

Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog

​http://bugs.webkit.org/show_bug.cgi?id=15026

Reviewed by NOBODY (OOPS!).

  • Scripts/prepare-ChangeLog: (sub isModifiedStatus): Split out from isModifiedOrAddedStatus. (sub isAddedStatus): Ditto. (sub testListForChangeLog): Added.
1:32 PM Changeset in webkit [25159] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5412988>
Crash when visiting ​http://www.rockonflash.com/blog/?p=58


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Just return if the plugin view hasn't been inserted in the hierarchy yet.
11:10 AM Changeset in webkit [25158] by antti
  • 2 edits in trunk/WebKit

Reviewed by John.


Fix <rdar://problem/5378390>
Crash at Range::startContainer() when creating multiple ToDos on the same line


Null check range.


No layout test, this only happens with ObjC API.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _expandSelectionToGranularity:]):
6:30 AM Changeset in webkit [25157] by zecke
  • 2 edits in trunk/WebCore

2007-08-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Zack.

Do not define svg as ImageMIMEType if we can use ksvg2.

  • platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
12:11 AM Changeset in webkit [25156] by mjs
  • 2 edits in trunk/WebKit

Not reviewed, fix for crash on launch bug in last patch.

  • WebView/WebHTMLView.mm: (-[WebHTMLView setDataSource:]): Remove an assertion, fix code to work right in the face of that condition.
12:04 AM Changeset in webkit [25155] by rwlbuis
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=14924
rotated rect with pattern draws incorrectly

Use the bounding box before transformation.

12:01 AM Changeset in webkit [25154] by mjs
  • 6 edits in trunk/LayoutTests

Not reviewed - test case fixes.


  • fix some test cases where expected results were altered by the last change (I reviewed all the new results.)
  • fast/events/focusingUnloadedFrame-expected.txt:
  • http/tests/loading/simple-subframe-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:

Aug 19, 2007:

5:04 PM Changeset in webkit [25153] by aroben
  • 2 edits in trunk/WebCore

Gtk+ build fix.

  • platform/gdk/TemporaryLinkStubs.cpp: Removed const.
3:07 PM Changeset in webkit [25152] by aroben
  • 7 edits in trunk/WebCore

Fix <rdar://5395835> REGRESSION (r24527): Context menu for edit fields is missing "Font & Writing Direction"

The problem was that ContextMenuItem::setSubMenu was just copying the
HMENU from the ContextMenu passed in on Windows, but that HMENU was
later getting destroyed when the ContextMenu went out of scope.

I added a new ContextMenu::releasePlatformDescription method that is
used in setSubMenu instead. I think an ultimately better design would
be for setSubMenu to take ownership of the ContextMenu that's passed in
(as should insertItem and appendItem), but I decided to be conservative
and just make the changes needed to fix the bug.

Reviewed by Darin.

No test possible.

  • platform/ContextMenu.h: Added releasePlatformDescription.
  • platform/gdk/TemporaryLinkStubs.cpp: Added stub implementation.
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::releasePlatformDescription): Implemented, though it's never called on this platform.
  • platform/qt/ContextMenuQt.cpp: (WebCore::ContextMenu::releasePlatformDescription): Ditto.
  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::setSubMenu): Call releasePlatformDescription since we need to take ownership of the HMENU.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::releasePlatformDescription): Implemented.
2:40 PM Changeset in webkit [25151] by mjs
  • 11 edits in trunk

LayoutTests:

Reviewed by Darin.

  • update for fix to <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)


No longer expect windowScriptObject delegate method in frames that never
use script.

  • http/tests/loading/bad-scheme-subframe-expected.txt:
  • http/tests/loading/bad-server-subframe-expected.txt:
  • http/tests/loading/empty-subframe-expected.txt:
  • http/tests/loading/slow-parsing-subframe-expected.txt:

WebCore:

Reviewed by Darin.

  • fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)


There were three main cuases of extra time due to creating the initial empty document:


1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
2) Parsing the minimal markup for the initial document's contents.
3) Clearing the Window object an extra time and dispatching the corresponding delegate method.


The WebCore part of the fixes addresses 2 and 3.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Don't parse "<html><body>" for the initial empty document; it turns out not to be needed. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Don't dispatch the delegate if we haven't created a ScriptInterpreter yet.
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded): Dispatch the window object delegate when we first create the interpreter, since that is now done lazily.
  • loader/FrameLoader.h: (WebCore::FrameLoader::committingFirstRealLoad): Helper for WebKit to know when to reuse a WebHTMLView.

WebKit:

Reviewed by Darin.


  • fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

There were three main cuases of extra time due to creating the initial empty document:


1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
2) Parsing the minimal markup for the initial document's contents.
3) Clearing the Window object an extra time and dispatching the corresponding delegate method.


The WebKit part of the fixes addresses 1.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): When switching from the initial empty document to the first real document, reuse the WebHTMLView.


It might actually be a significant performance improvement to always
reuse the WebHTMLView, but that is a much riskier change and not
needed to fix the regression right now.

11:26 AM Changeset in webkit [25150] by pewtermoose
  • 3 edits
    2 adds in trunk

LayoutTests:

2007-08-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adam Roben.

  • fast/images/text-content-crash-2-expected.txt: Added.
  • fast/images/text-content-crash-2.html: Added.

WebCore:

2007-08-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adam Roben.

Test: fast/images/text-content-crash-2.html

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): Added a check that the renderer is an image. (WebCore::HTMLImageLoader::updateFromElement): Ditto. (WebCore::HTMLImageLoader::notifyFinished): Ditto.
10:10 AM Changeset in webkit [25149] by staikos
  • 2 edits in trunk/WebKitQt

Don't export ICO symbols

9:51 AM Changeset in webkit [25148] by ddkilzer
  • 1 edit
    2 adds in trunk/LayoutTests

LayoutTests:

Reviewed by Adam and Geoff within one minute of each other.

Tests that the '-apple-opacity', '-khtml-opacity' and '-webkit-opacity' styles
all map to the 'opacity' style.

  • fast/css/legacy-opacity-styles-expected.txt: Added.
  • fast/css/legacy-opacity-styles.html: Added.
5:07 AM Changeset in webkit [25147] by bdash
  • 2 edits in trunk/LayoutTests

2007-08-19 Mark Rowe <​mrowe@apple.com>

Update expected results. The results that were landed with the test did not match the wording
in the test that was landed.

  • fast/encoding/namespace-tolerance-expected.txt:
4:13 AM Changeset in webkit [25146] by zecke
  • 2 edits in trunk/WebKitTools

2007-08-19 Oleg Sukhodolsky <​son.two@gmail.com>

Reviewed by Mark.

-fixes ​http://bugs.webkit.org/show_bug.cgi?id=14632

  • Scripts/webkitdirs.pm: qt and gtk ports now explicitly pass debug (or release) mode to qmake.
1:05 AM Changeset in webkit [25145] by rwlbuis
  • 33 edits
    4 adds in branches/feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=14926
WebKit has 'em' length handling problems related to CSS properties

Parse the properties in inline style attributes non-strict for SVG.

Aug 18, 2007:

10:15 PM Changeset in webkit [25144] by staikos
  • 3 edits in trunk/WebKitQt

Fix compilation

11:20 AM Changeset in webkit [25143] by zecke
  • 2 edits in trunk/WebKit/gtk

2007-08-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Build fix. Add const to the first parameter of createPlugin

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

Aug 17, 2007:

8:48 PM Changeset in webkit [25142] by mjs
  • 4 edits in trunk

WebCore:

Reviewed by Darin.

  • WebCore part of fix to scrollbar suppression hack for Leopard
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Suppress scrollbars earlier, so it happens before any potential view swap.

WebKit:

Reviewed by Darin.

  • WebKit part of fix to scrollbar suppression hack for Leopard
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Don't call the superclass method when scrollbars are suppressed. (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): Instead call it here, when unsuppressing.
7:41 PM Changeset in webkit [25141] by bdash
  • 1 copy in tags/Safari-4523.1

New tag.

7:00 PM Changeset in webkit [25140] by aroben
  • 8 edits
    1 add in trunk/WebKit/win

Fix <rdar://5192578> Inspect Element should not appear in context menu in non-debug mode

We now follow the same logic as Mac WebKit for displaying the Inspect Element item:

1) If DisableWebKitDeveloperExtras is set to true, don't display it
2) If not, and we're in a debug build, display it
3) If not, and we're in a release build, display it if

WebKitDeveloperExtras is set to true

Reviewed by Ada.

  • Interfaces/IWebPreferencesPrivate.idl: Added.
  • WebKit.vcproj/Interfaces.vcproj: Add new IWebPreferencesPrivate.idl file to project.
  • WebKit.vcproj/WebKitGUID.vcproj: Added generated .c file for IWebPreferencesPrivate to project.
  • WebPreferenceKeysPrivate.h: Added new keys.
  • WebPreferences.cpp: Added IID_WebPreferences. (WebPreferences::postPreferencesChangesNotification): Added an explicit cast needed now that WebPreferences implements two interfaces. (WebPreferences::QueryInterface): Added new cases. (WebPreferences::setDeveloperExtrasEnabled): Added. (WebPreferences::developerExtrasEnabled): Added. (WebPreferences::developerExtrasDisabledByOverride): Added.
  • WebPreferences.h: Now implements IWebPreferencesPrivate.
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): Call developerExtrasEnabled. (WebView::developerExtrasEnabled): Ported from -[WebView _developerExtrasEnabled].
  • WebView.h:
7:00 PM Changeset in webkit [25139] by aroben
  • 6 edits in trunk/WebKit/win

Add WebPreferences::sharedStandardPreferences

This is a convenience method to get the standard preferences object so
that within WebKit we don't have to deal with the fact that COM doesn't
support static methods.

Reviewed by Ada.

  • WebHistory.cpp: (WebHistory::WebHistory): Use sharedStandardPreferences.
  • WebIconDatabase.cpp: (WebIconDatabase::init): Ditto.
  • WebPreferences.cpp: (WebPreferences::sharedStandardPreferences): Added. (WebPreferences::getInstanceForIdentifier): Use sharedStandardPreferences. (WebPreferences::standardPreferences): Ditto.
  • WebPreferences.h:
  • WebView.cpp: (WebView::preferences): Ditto.
6:23 PM Changeset in webkit [25138] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.

  • don't look for Apple-style localizable strings in the GTK version of WebKit
  • Scripts/extract-localizable-strings: Add a feature where you can pass in the name of subdirectories to skip.
  • Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory to skip.
6:08 PM Changeset in webkit [25137] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • fix <rdar://problem/5414518> Use root URL as origin URL when quarantining downloads
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setOriginalURLForDownload): Extract only the scheme and host name and make the originating URL from that.
  • WebKit/StringsNotToBeLocalized.txt: Updated for recent changes.
5:04 PM Changeset in webkit [25136] by andersca
  • 3 edits in trunk/WebKit/gtk

Build fix.


  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
  • WebCoreSupport/FrameLoaderClientGtk.h:
5:01 PM Changeset in webkit [25135] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebHTMLView.mm

Fix a spelling mistake.

4:53 PM Changeset in webkit [25134] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5398301> Xcode threw mutation exception while enumerating subviews (GC only)

I was never able to reproduce this exception. But there can be cases where layout will
trigger JavaScript or plugin code that can modify the WebView view hierarchy during a
recursive enumeration of all the subviews.

This patch does two things:
1) Adds a check in debug builds that will LOG when any view is added or removed during layout.
Noting that added views will not recieve layout this round and might paint without first recieving layout.

2) Recursivly builds up an array of descendant WebHTMLViews before calling layout on them.
This matches the behavior of makeObjectsPerformSelector: in the non-GC case (making a copy
before enumerating.)

  • WebView/WebHTMLView.mm: (-[WebHTMLView _web_setPrintingModeRecursive]): Use _web_addDescendantWebHTMLViewsToArray to build up an array of WebHTMLViews to enumerate. (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto. (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto. (-[WebHTMLView _web_layoutIfNeededRecursive]): Ditto. (-[WebHTMLView _layoutIfNeeded]): Moved to WebHTMLViewFileInternal category. (-[WebHTMLView didAddSubview:]): LOG in debug builds. (-[WebHTMLView willRemoveSubview:]): Ditto. (-[NSView _web_addDescendantWebHTMLViewsToArray:]): Recursivly build an array of descendant WebHTMLViews.
  • WebView/WebHTMLViewInternal.h: Added a BOOL in WebHTMLViewPrivate to track subview changes (debug only.)
4:45 PM Changeset in webkit [25133] by andersca
  • 2 edits in trunk/WebKitTools

Build fix.


  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_SetWindow):
4:29 PM Changeset in webkit [25132] by antti
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5403773>
CrashTracer: [USER] 88 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::paint + 846


Changed results for fast/dynamic/containing-block-change.html are progression
(even though new results don't match Firefox and old ones did!)

  • fast/dynamic/ancestor-to-absolute-expected.txt: Added.
  • fast/dynamic/ancestor-to-absolute.html: Added.
  • fast/dynamic/containing-block-change-expected.checksum:
  • fast/dynamic/containing-block-change-expected.png:
  • fast/dynamic/containing-block-change-expected.txt:

WebCore:

Reviewed by Hyatt.


Fix <rdar://problem/5403773>
CrashTracer: [USER] 88 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::paint + 846

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removePositionedObjects):


Fix crash in ​http://www.infobae.com/interior/home.html
Positioned objects removed from m_positionedObjects would in some cases not get added back to any
positioned objects list. Adding objects happens in block layout but since layout was not invalidated
correctly in removePositionedObjects() it would not get invoked. As a result some positioned objects
would stay in layout dirty state leading to crashes and other bad things.


  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):


Add needLayout() guard to eliminate this class of crashes from release builds.
Assert commented out for now since one existing layout test can't handle it.

3:58 PM Changeset in webkit [25131] by andersca
  • 3 edits in trunk/WebKit/win

Build fix.


  • WebFrame.cpp: (WebFrame::createPlugin):
  • WebFrame.h:
3:48 PM Changeset in webkit [25130] by kdecker
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.

<rdar://problem/5252836> Adobe Help Viewer: Japanese characters in the Help Tree structure are shown as garbage
This test ensures a UTF-8 encoding is properly set. The code tests compatibility of documents which:

(1) use namespace prefixes on HTML elements
(2) specify a non-latin charset
(3) contain non-latin characters


If this test passes, the UTF-8 character below should exactly match the character the character in namespace-tolerance-expected.txt.

  • fast/encoding/namespace-tolerance-expected.txt: Added.
  • fast/encoding/namespace-tolerance.html: Added.
3:45 PM Changeset in webkit [25129] by kdecker
  • 2 edits in trunk/WebCore

2007-08-17 Kevin Decker <​kdecker@apple.com>

Code change by Darin, landed and reviewed by me.

Fixed: <rdar://problem/5252836> Adobe Help Viewer: Japanese characters in the Help Tree structure are shown as garbage
Added fast/encoding/namespace-tolerance.html test.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Slightly loosen the charset decoder heuristic by tweaking it to ignore namespaces. This restores compatibility to documents which (1) use namespace prefixes on HTML elements (2) specify a non-latin charset and (3) contain non-latin characters.


Added fast/encoding/namespace-tolerance.html test.

3:12 PM Changeset in webkit [25128] by andersca
  • 21 edits
    2 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt.

<rdar://problem/5379040>
REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes


Add test.


  • plugins/netscape-plugin-setwindow-size-expected.txt: Added.
  • plugins/netscape-plugin-setwindow-size.html: Added.

WebCore:

Reviewed by Dave Hyatt.


<rdar://problem/5379040>
REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes

Instantiate plug-ins during the first layout instead of doing so when creating the renderer.
This ensures that the plug-in widget will have a correct initial size.


  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance): Force a layout if the plug-in doesn't have an instance.


(WebCore::HTMLEmbedElement::attach):
Pass true to updateWidget, causing it to only create a widget if it won't be a plug-in.


  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Pass false to updateWidget, this will only create subframes anyway.


  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance): Force a layout if the plug-in doesn't have an instance.


(WebCore::HTMLObjectElement::attach):
Pass true to updateWidget, causing it to only create a widget if it won't be a plug-in.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin): Get the size from the renderer and pass it to the client.


  • loader/FrameLoaderClient.h:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::createPlugin): Update declarations.


  • rendering/RenderPart.cpp: (WebCore::RenderPart::setWidget): No need to mark the renderer as dirty here.


  • rendering/RenderPartObject.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Add a parameter, onlyCreateNonPlugins. If this is true the widget will only be created if it's not a plug-in.


(WebCore::RenderPartObject::layout):
Call updateWidget here if m_widget is 0, causing the plug-in to be instantiated.

WebKit:

Reviewed by Dave Hyatt.

<rdar://problem/5379040>
REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes


Pass the right size when creating the views.


  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithFrame:URL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):

WebKitTools:

Reviewed by Dave Hyatt.

<rdar://problem/5379040>
REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes

Add a way for the plug-in to dump the width and height when it gets its NPP_SetWindow call.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): (NPP_SetWindow):
1:50 PM Changeset in webkit [25127] by zbujtas
  • 3 edits in S60/trunk/WebCore

rathnasa, reviewed by Zbujtas

DESC: TSW Id SJUN-73XBVC document.write does not work in onload, onclick events
​http://bugs.webkit.org/show_bug.cgi?id=14915

WARNING: NO TEST CASES ADDED OR CHANGED

1:48 PM Changeset in webkit [25126] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2007-08-09 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by zbujtas
DESC: TSW Id SJUN-73XBVC document.write does not work in onload, onclick events

​http://bugs.webkit.org/show_bug.cgi?id=14915

1:10 PM Changeset in webkit [25125] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Correct ChangeLog to reference correct person

1:42 AM Changeset in webkit [25124] by oliver
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Simple test to ensure we don't crash when creating a pattern

  • fast/canvas/create-pattern-does-not-crash-expected.txt: Added.
  • fast/canvas/create-pattern-does-not-crash.html: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14189
<rdar://problem/5319511> REPRODUCIBLE CRASH: Canvas createPattern(canvas, ...) crashes on Windows (14189)

Ensure that we actually retain the CG pattern correctly.

Credit to Philip Taylor <​excors@gmail.com> for finding the cause of this.

  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::~CanvasPattern): (WebCore::CanvasPattern::createPattern):
  • html/CanvasPattern.h: (WebCore::CanvasPattern::platformImage):

Aug 16, 2007:

11:49 PM Changeset in webkit [25123] by rwlbuis
  • 4 edits
    4 adds in branches/feature-branch

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=14927
use element in SVG does not render after parent is displayed off and on

Also detach the shadow tree when detaching the <use>.

10:29 PM Changeset in webkit [25122] by bdash
  • 4 edits in trunk

Versioning.

10:20 PM Changeset in webkit [25121] by bdash
  • 2 edits in tags/Safari-5523.1/JavaScriptCore

Merge r25078.

Reviewed by Sam.

  • fix <rdar://problem/5410570> Global initializer introduced by use of std::numeric_limits in r24919
  • kjs/ustring.cpp: (KJS::overflowIndicator): Turned into a function. (KJS::maxUChars): Ditto. (KJS::allocChars): Use the functions. (KJS::reallocChars): Ditto. (KJS::UString::expandedSize): Ditto.
10:20 PM Changeset in webkit [25120] by bdash
  • 5 edits
    4 adds in tags/Safari-5523.1

Merge r25076.

LayoutTests:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • editing/deleting/5408255.html: Added.
  • editing/deleting/5408255-expected.checksum: Added.
  • editing/deleting/5408255-expected.png: Added.
  • editing/deleting/5408255-expected.txt: Added.

WebCore:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Use -webkit-user-select:ignore for the deletion UI.

WebKitTools:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES only for elements with the class needsDeletionUI.
10:19 PM Changeset in webkit [25119] by bdash
  • 27 edits in tags/Safari-5523.1/WebCore

Merge r25098.

Reviewed by Hyatt.

Rolling back in. I made a silly mistake in XMLTokenizer that caused
this patch to crash SVG tests. It's fixed now!

Refactor of change for <rdar://problem/5404899> REGRESSION: Mail
crash in WebCore::FontFallbackList::fontDataAt() after dragging
image into text multiple times

The original fix that I made last night prevents the pending style
sheet count from being incremented until the element is in the
document. This fix prevents the style sheet from loading at all
until it is in the document.

Here is the fix.

  • dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): Call process. (WebCore::StyleElement::removedFromDocument): This can be reverted to its original state before my patch last night. (WebCore::StyleElement::process): childrenChanged is now called process. Return early if your not in the document. (WebCore::StyleElement::createSheet): Revert change from last night. The inDocument check is now in caller childrenChanged.
  • dom/StyleElement.h: insertedIntoDocument() must now accept an element in addition to a document.

This is an optimization to prevent calling updateStyleSelector()
too frequently.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement): (WebCore::HTMLStyleElement::finishedParsing): (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::childrenChanged): (WebCore::HTMLStyleElement::sheetLoaded):
  • html/HTMLStyleElement.h:
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement): (WebCore::SVGStyleElement::finishedParsing): (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::childrenChanged): (WebCore::SVGStyleElement::sheetLoaded):
  • ksvg2/svg/SVGStyleElement.h: (WebCore::SVGStyleElement::setCreatedByParser):

This is a name change. Document::stylesheetLoaded()
is now Document::removePendingSheet()

  • dom/Document.cpp: (WebCore::Document::removePendingSheet):
  • dom/Document.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::sheetLoaded):
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet):

This is another name change. closeRenderer() is now
finishedParsing()

  • dom/Node.h: (WebCore::Node::finishedParsing):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::finishedParsing):
  • html/HTMLAppletElement.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLFormControlElementWithState::finishedParsing):
  • html/HTMLGenericFormElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::finishedParsing):
  • html/HTMLObjectElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::popOneBlockCommon):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::finishedParsing):
  • html/HTMLScriptElement.h: (WebCore::HTMLStyleElement::setCreatedByParser):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::finishedParsing):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::finishedParsing):
  • ksvg2/svg/SVGElement.h:
10:19 PM Changeset in webkit [25118] by bdash
  • 4 edits in tags/Safari-5523.1/WebCore

Merge r25068.

Reviewed by Maciej.

Fix for <rdar://problem/5404899> REGRESSION: Mail crash in
WebCore::FontFallbackList::fontDataAt() after dragging image into
text multiple times

We were crashing because style information was not up-to-date. This
patch fixes the problem in two ways:

Style information was not up to date at the time of the crash
because the document thought there was still a pending style sheet.
The pending style sheet counter was incremented when a call to
cloneNode from Mail cloned a style node with an imported style
sheet. Because Mail disables the cache, the style sheet did not
load immediately for the cloned node, and we do not check again to
see if it has loaded in time to decrement the pending style sheet
counter before the crash point. The fix here is only to increment
the pending style sheet counter for elements that are already in
the document.

  • dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): If we have a CSS style sheet that is currently loading, increment the pending style sheet counter. This should keep the counter accurate in the case where a style node is cloned and then immediately inserted into the document. (WebCore::StyleElement::removedFromDocument): If we have a CSS style sheet that is currently loading, decrement the pending style sheet count. This is required to keep the correct balance, given the change above. (WebCore::StyleElement::createSheet): Only addPendingSheet() and checkLoaded() if we are in the document.

Here is Darin's original fix. It seems worth keeping this fix too.
Font style information should not cause a crash if there are still
pending style sheets. This is good belt-and-suspenders in case
there is another way to run into this bug with a wacky timing
issue.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): Update the font.
10:08 PM Changeset in webkit [25117] by bdash
  • 1 copy in tags/Safari-5523.1

New tag.

8:10 PM Changeset in webkit [25116] by ggaren
  • 2 edits in trunk/WebCore

Build fix. (Maybe?)


  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
5:29 PM Changeset in webkit [25115] by justing
  • 5 edits
    6 adds in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5378473> Undoing a deletion that is part of an open typing command fails to reinsert the caret

  • editing/undo/5378473.html: Added.
  • platform/mac/editing: Added.
  • platform/mac/editing/undo: Added.
  • platform/mac/editing/undo/5378473-expected.checksum: Added.
  • platform/mac/editing/undo/5378473-expected.png: Added.
  • platform/mac/editing/undo/5378473-expected.txt: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/5378473>
REGRESSION: Undoing a deletion that is part of an open typing command fails to reinsert the caret


We recently made Undo of a series of deletes select all of the
characters that were deleted, not just the most recently deleted
character. But the code that did this set a new starting selection
after every delete, even those that were part of an open typing
command that started with character insertions or forward deletes,
operations that when undone, remove the starting selection being
set from the document.


After this change we only set a new starting selection if the open typing
command was opened by a backward delete. The new behavior matches TextEdit.
We don't do something similar or forward deletes because TextEdit opens
and closes a new typing command on forward delete (added a FIXME about this).

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): Initialize m_openedByBackwardDelete. (WebCore::TypingCommand::forwardDeleteKeyPressed): Added a FIXME about how in TextEdit, forward deletes open and close a new typing command. (WebCore::TypingCommand::doApply): Set m_openedByBackwardDelete appropriately. (WebCore::TypingCommand::deleteKeyPressed): Only set the starting selection if this delete is the first one in an open typing command or one in a series of deletes that opened the typing command.
  • editing/TypingCommand.h: Added m_openedByBackwardDelete.
4:43 PM Changeset in webkit [25114] by ggaren
  • 12 edits in trunk

WebCore:

Reviewed by Dave Hyatt.


Tweaked the cache eviction model to better balance between live and
dead resources.


For the sake of avoiding evictions during the PLT, the old model
required the sum of dead and live resources to grow to twice the cache
capacity before evicting, and would then evict dead or live down to 0
if necessary. This was a too-high high water mark, which would nullify
much of the value of eviction, and a too-low low water mark, which
would nullify much of the value of the LRU-SP strategy.


This patch changes the model in 3 ways.


  1. The new model for dead resources is a flexible window with a fixed minimum and maximum. The dead resource window is big when live resource pressure is small, and vice versa. This has the immediate advantage of cutting the high water mark by up to 50%. It also enables the following tunable optimizations in future patches:
    1. A dead resource limit of 0 for clients who want that. (Just set the fixed maximum to 0.)
    2. A much higher low water mark. (Just set the fixed minimum to, say, 25% of the cache's capacity.)
    3. A much lower high water mark for users who browse simple pages in one tab. (Just set the fixed maximum to, say, 50% of the cache's capacity.)


I plan to make the changes that actually take advantage of these
tunable optimizations in another check-in.

The new model won't hurt the PLT because it will notice the PLT's low
live resource size, and up the dead resource capacity in response. For
the same reason, the new model should establish a good balance in
real-world use.


  1. Live resource eviction is now based on size(), not encodedSize(). So, a page with lots of large, encoded images will start evicting resources, if necessary, even before all the images paint. This allows you to more accurately stipulate an exact high water mark.


  1. When pruning, prune to a small percentage below capacity, to avoid just having to prune again immediately.

Layout tests pass. PLT shows no regression.

  • history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow): Updated for rename.
  • loader/Cache.cpp: Implemented the algorithm explained above.
  • loader/Cache.h: Removed explicit tracking of decoded data size, since it was unused.
  • loader/CachedResource.cpp: ditto on tracking of decoded data size

WebKit:

Reviewed by Dave Hyatt.


WebKit changes to support new cache eviction model in WebCore.

  • WebView/WebPreferences.m: (+[WebPreferences initialize]): Modified to reflect new API in WebCore.
  • WebView/WebView.mm: (+[WebView _initializeCacheSizesIfNecessary]): Slightly increased cache size on low memory systems to avoid affecting the PLT for now.

win:

Reviewed by Dave Hyatt.

WebKit changes to support new cache eviction model in WebCore.

  • WebPreferences.cpp: (WebPreferences::initialize):
  • WebView/WebPreferences.m: Modified to reflect new API in WebCore.
  • WebView.cpp: (WebView::initializeCacheSizesIfNecessary): Slightly increased cache size on low memory systems to avoid affecting the PLT for now.
4:12 PM Changeset in webkit [25113] by aliceli1
  • 2 edits in trunk/LayoutTests

Removed a fixed test from the skip list. r25112 fixed this test.

  • platform/mac-leopard/Skipped:
4:09 PM Changeset in webkit [25112] by aliceli1
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail

  • DumpRenderTree/DumpRenderTree.m: (createWebView): Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow. (dumpRenderTree): Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow.
1:50 PM Changeset in webkit [25111] by bdakin
  • 2 edits in trunk/LayoutTests

Reviewed by Hyatt.

Changing this test to get it to pass again after ​http://
trac.webkit.org/projects/webkit/changeset/25098

The test is changing because our new behavior seems correct, though
not completely consistent. ​http://bugs.webkit.org/show_bug.cgi?
id=14979 is tracking the fact that the behavior is not consistent
regarding style elements that are not in the document.

  • fast/css/css-selector-text.html:
12:05 PM Changeset in webkit [25110] by kmccullo
  • 3 edits
    5 adds in trunk

LayoutTests:

Reviewed by Adam.

  • Added tests for regressions in other components. In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
  • fast/cookies: Added.
  • fast/cookies/local-file-can-set-cookies-expected.txt: Added.
  • fast/cookies/local-file-can-set-cookies.html: Added.
  • platform/mac-tiger: Added.
  • platform/mac-tiger/Skipped: Added.

WebKitTools:

Reviewed by Adam.

  • Added tests for regressions in other components. In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
  • Scripts/run-webkit-tests:
11:52 AM Changeset in webkit [25109] by darin
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5415029> In Mail, a crash occurs at WebCore::Node::isDescendantOf() when attempting to delete a selection in a table

The bug was caused by createMarkup trying to operate on a range that
has an endpoint in the delete button DOM, because it removes that DOM
during its operation! Still working on a regression test -- it's hard
to make the kind of bad selection that's needed with the DOM, so I might
have to use the eventSender.

  • editing/DeleteButtonController.h: Made some of the identifiers private. We can make them public if we need to use them. Added a getter function for the container element so we can figure out if a given node is inside the DOM added for the delete button.
  • editing/markup.cpp: (WebCore::moveEndpointsBeforeNode): Added. General purpose helper function that moves endpoints of a range to before a given node -- we do this before removing the delete button, so the endpoint is where the delete button was, rather than having an endpoint that's not in the document. (WebCore::createMarkup): Always return empty string, not null string. Get the document by calling ownerDocument on the range rather than getting the document of the commonAncestorContainer. That's because we need to get at the delete button before calling commonAncestorContainer. Call moveEndpointsBeforeNode to move the range endpoints out of the delete button interface before calling disable() which will remove it from the DOM if it's in there. Added an early return for the case where commonAncestor is non-0. If this happens, we would crash later because pastEndNode would not be in the tree. This change alone would prevent the crash, but we'd get bad markup, so we need the moveEndpointsBeforeNode fix. Added null checks for the frame to the range version as in the single-node version so this won't crash immediately on documents that are not in a frame. For the single-node version, added a check if a ndoe of 0 and a node inside the delete button user interface, and return the empty string for those cases.
11:51 AM Changeset in webkit [25108] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.


<rdar://problem/5378847>
After creating and removing a ToDo, the caret disappears as soon as I start to type

  • editing/inserting/5378847-expected.txt: Added.
  • editing/inserting/5378847.html: Added.

WebCore:

Reviewed by Maciej.


<rdar://problem/5378847> After creating and removing a ToDo, the caret disappears as soon as I start to type


  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): A whitespace text node inserted by Mail when a ToDo is removed is completely removed by deleteInsignificantWhitespace, and since it contains the text insertion position, insertion fails. Save the position before the node where text insertion will occur, and if that node is removed, use the saved position for insertion.
9:29 AM Changeset in webkit [25107] by darin
  • 11 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/5413488> REGRESSION: every DOM element is about 40 bytes bigger because it has a Timer

Moved the timer to the document from the element.

  • dom/Document.h: Made frame() inline. Added updateFocusApperanceSoon(), cancelFocusAppearanceUpdate(), m_updateFocusAppearanceTimer, clearXMLVersion(), and updateFocusAppearanceTimerFired(). Also made everything that was previously protected be private instead.
  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_updateFocusAppearanceTimer. (WebCore::Document::updateFocusAppearanceSoon): Added. Starts timer. (WebCore::Document::cancelFocusAppearanceUpdate): Added. Stops timer. (WebCore::Document::updateFocusAppearanceTimerFired): Added. If the focused node is a focusable element, then calls updateFocusAppearance(false) on it.
  • dom/Element.h: Removed default value of the boolean parameter to updateFocusAppareance. Removed needsFocusAppearanceUpdate(), setNeedsFocusAppearanceUpdate(), updateFocusAppearanceTimerFired(), stopUpdateFocusAppearanceTimer(), m_updateFocusAppearanceTimer, and m_needsFocusAppearanceUpdate. Added updateFocusAppearanceSoonAfterAttach() and cancelFocusAppearanceUpdate().
  • dom/Element.cpp: (WebCore::ElementRareData::ElementRareData): Added initializer for m_needsFocusAppearanceUpdateSoonAfterAttach. (WebCore::Element::Element): Removed initializers for m_updateFocusAppearanceTimer and m_needsFocusAppearanceUpdate. (WebCore::Element::attach): Updated code that starts the focus appearance timer to instead call updateFocusAppearanceSoon() on the document. (WebCore::Element::detach): Replaced call to stopUpdateFocusAppearanceTimer with call to cancelFocusAppearanceUpdate. (WebCore::Element::focus): Added check for node that's already focused, to match the logic that's in the derived classes. This makes it safe for us to remove the override in the derived classes. Also replaced the code that called setNeedsFocusAppearanceUpdate(true) with code to set the rare data flag m_needsFocusAppearanceUpdateSoonAfterAttach and added a call to cancelFocusAppearanceUpdate() in the case where there's no focus appearance update. (WebCore::Element::blur): Replaced call to stopUpdateFocusAppearanceTimer with call to cancelFocusAppearanceUpdate. (WebCore::Element::cancelFocusAppearanceUpdate): Added. Sets m_needsFocusAppearanceUpdateSoonAfterAttach to false, and then calls cancelFocusAppearanceUpdate() on the document, but only if the element is the focused node of the document.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): Replaced code that sets m_xmlVersion directly with a call to a new inline clearXMLVersion() function. (WebCore::HTMLDocument::setCookie): Replaced use of m_policyBaseURL with policyBaseURL(). (WebCore::HTMLDocument::createTokenizer): Replaced uses of m_frame with frame(). (WebCore::HTMLDocument::determineParseMode): Replaced code that sets pMode and hMode directly with calls to setParseMode and setHTMLMode. Replaced use of m_styleSelector with styleSelector().
  • html/HTMLInputElement.h: Removed now-unneed override of focus(). Removed default value of the boolean parameter to updateFocusAppareance.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): Pass the restorePreviousSelection boolean through -- while it's ignored, it no longer has a default value.
  • html/HTMLTextAreaElement.h: Removed now-unneed override of focus(). Removed default value of the boolean parameter to updateFocusAppareance.
  • html/HTMLTextAreaElement.cpp: Ditto.
  • WebCore.exp: Removed the Document::frame() symbol, since it's now inline.
9:13 AM Changeset in webkit [25106] by antti
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.


Test for <rdar://problem/5388936>
Crash while setting display:none for a table cell with selection

  • fast/table/destroy-cell-with-selection-crash-expected.txt: Added.
  • fast/table/destroy-cell-with-selection-crash.html: Added.

WebCore:

Reviewed by Maciej.


Fix <rdar://problem/5388936>
Crash while setting display:none for a table cell with selection


Super class destroy() could (through some selection code in removeChild()) trigger section recalc
in middle of RenderTableCell::destroy(), cleaning section dirty bit. This would later crash in
layout since cell grid would still have refence to the dead cell.


Ensure table sections are dirty when leaving destroy method.


I can't figure out tests for row and section changes but they look like
they could crash in similar way as cell.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::destroy):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::destroy):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::destroy):

Aug 15, 2007:

10:17 PM BuildingOnWindows edited by kevino@theolliviers.com
Added note about copying dlls to get tests running. (diff)
9:34 PM Changeset in webkit [25105] by mjs
  • 2 edits in trunk/WebCore/platform/graphics

2007-08-15 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.

<rdar://problem/5389696> leak of 32-byte NSData object (and more?) in WebIconDatabase code path with each refresh of ​http://www.apple.com


  • platform/graphics/BitmapImage.h: Use RetainPtr for m_nsImage and m_tiffRep
  • platform/graphics/mac/ImageMac.mm: (WebCore::BitmapImage::initPlatformData): No need to do anything now (WebCore::BitmapImage::invalidatePlatformData): Simplify (WebCore::BitmapImage::getTIFFRepresentation): Use RetainPtr to avoid leaks (WebCore::BitmapImage::getNSImage): Use RetainPtr to avoid leaks
8:56 PM Changeset in webkit [25104] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Geoff.

<rdar://problem/5389696> leak of 32-byte NSData object (and more?) in WebIconDatabase code path with each refresh of ​http://www.apple.com


  • platform/graphics/BitmapImage.h: Use RetainPtr for m_nsImage and m_tiffRep
  • platform/graphics/mac/ImageMac.mm: (WebCore::BitmapImage::initPlatformData): No need to do anything now (WebCore::BitmapImage::invalidatePlatformData): Simplify (WebCore::BitmapImage::getTIFFRepresentation): Use RetainPtr to avoid leaks (WebCore::BitmapImage::getNSImage): Use RetainPtr to avoid leaks
8:10 PM Changeset in webkit [25103] by darin
  • 7 edits in trunk/WebCore

Reviewed by Anders.

  • fix <rdar://problem/5094895> REGRESSION (r19094): JavaScript timers don't work inside showModalDialog; caret also doesn't blink
  • platform/Timer.h: Added fireTimersInNestedEventLoop.
  • platform/Timer.cpp: (WebCore::TimerBase::fireTimers): Added code to exit if the timersReadyToFire is cleared. This indicates that someone fired the timers in the nested event loop, so we should not fire any more timers ourselves. (WebCore::TimerBase::fireTimersInNestedEventLoop): Added. Sets timersReadyToFire to 0 so we won't return early and do nothing if the shared timer first. Then calls updateSharedTimer() so the shared timer will get scheduled as needed based on any pending timers.
  • page/Chrome.cpp: (WebCore::Chrome::runModal): Call fireTimersInNestedEventLoop before calling runModal on the client.
  • manual-tests/modal-dialog.html: Added a test that uses a timeout.
  • manual-tests/show-modal-dialog-test.html: Fixed a typo.
4:27 PM Changeset in webkit [25102] by thatcher
  • 12 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5410937> HIWebView in SimpleCarbonWeb doesn't seem to be getting adequate invalidation when window is resized

HIWebViewCreate now just returns a HIViewRef created with HICocoaViewCreate. This eliminates lots of old code and
makes HIWebView a better citizen starting with Leopard. The old code paths are still needed for Tiger, so now
most of the files in the WebKit/Carbon directory are #ifdef BUILDING_ON_TIGER.

The Tiger code is unchanged and dosen't exhibit the invalidation problem when the window resizes.

  • Carbon/CarbonUtils.m: (WebInitForCarbon): #ifdef BUILDING_ON_TIGER portions of this code that is not needed on Leopard.
  • Carbon/CarbonWindowAdapter.h: #ifdef BUILDING_ON_TIGER
  • Carbon/CarbonWindowAdapter.m: Ditto.
  • Carbon/CarbonWindowContentView.h: Ditto.
  • Carbon/CarbonWindowContentView.m: Ditto.
  • Carbon/CarbonWindowFrame.h: Ditto.
  • Carbon/CarbonWindowFrame.m: Ditto.
  • Carbon/HIViewAdapter.h: Ditto.
  • Carbon/HIViewAdapter.m: Ditto.
  • Carbon/HIWebView.h: Consolidate two #ifdef OBJC blocks into one.
  • Carbon/HIWebView.m: Implement Leopard specific HIWebViewCreate, HIWebViewCreateWithClass and HIWebViewGetWebView. (HIWebViewCreate): Call HIWebViewCreateWithClass passing [WebView class]. (HIWebViewCreateWithClass): Call HICocoaViewCreate with an instance of the class passed in. (HIWebViewGetWebView): Call HICocoaViewGetView.
2:29 PM Changeset in webkit [25101] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=14971
REGRESSION: cannot select reporter's e-mail in bugzilla


  • editing/selection/14971-expected.checksum: Added.
  • editing/selection/14971-expected.png: Added.
  • editing/selection/14971-expected.txt: Added.
  • editing/selection/14971.html: Added.

WebCore:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=14971
REGRESSION: cannot select reporter's e-mail in bugzilla

  • page/EventHandler.cpp: (WebCore::EventHandler::canMouseDragExtendSelect): Allow drag-selecting inside a -webkit-user-select:ignore region.
1:47 PM Changeset in webkit [25100] by darin
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.make

Clear a stray executable bit.

1:10 PM Changeset in webkit [25099] by bdakin
  • 1 edit
    2 adds in trunk/LayoutTests

Test for new support of empty style sheets.

  • fast/css/emptyStyleTag-expected.txt: Added.
  • fast/css/emptyStyleTag.html: Added.
1:04 PM Changeset in webkit [25098] by bdakin
  • 27 edits in trunk/WebCore

Reviewed by Hyatt.

Rolling back in. I made a silly mistake in XMLTokenizer that caused
this patch to crash SVG tests. It's fixed now!

Refactor of change for <rdar://problem/5404899> REGRESSION: Mail
crash in WebCore::FontFallbackList::fontDataAt() after dragging
image into text multiple times

The original fix that I made last night prevents the pending style
sheet count from being incremented until the element is in the
document. This fix prevents the style sheet from loading at all
until it is in the document.

Here is the fix.

  • dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): Call process. (WebCore::StyleElement::removedFromDocument): This can be reverted to its original state before my patch last night. (WebCore::StyleElement::process): childrenChanged is now called process. Return early if your not in the document. (WebCore::StyleElement::createSheet): Revert change from last night. The inDocument check is now in caller childrenChanged.
  • dom/StyleElement.h: insertedIntoDocument() must now accept an element in addition to a document.

This is an optimization to prevent calling updateStyleSelector()
too frequently.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement): (WebCore::HTMLStyleElement::finishedParsing): (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::childrenChanged): (WebCore::HTMLStyleElement::sheetLoaded):
  • html/HTMLStyleElement.h:
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement): (WebCore::SVGStyleElement::finishedParsing): (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::childrenChanged): (WebCore::SVGStyleElement::sheetLoaded):
  • ksvg2/svg/SVGStyleElement.h: (WebCore::SVGStyleElement::setCreatedByParser):

This is a name change. Document::stylesheetLoaded()
is now Document::removePendingSheet()

  • dom/Document.cpp: (WebCore::Document::removePendingSheet):
  • dom/Document.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::sheetLoaded):
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet):

This is another name change. closeRenderer() is now
finishedParsing()

  • dom/Node.h: (WebCore::Node::finishedParsing):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::finishedParsing):
  • html/HTMLAppletElement.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLFormControlElementWithState::finishedParsing):
  • html/HTMLGenericFormElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::finishedParsing):
  • html/HTMLObjectElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::popOneBlockCommon):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::finishedParsing):
  • html/HTMLScriptElement.h: (WebCore::HTMLStyleElement::setCreatedByParser):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::finishedParsing):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::finishedParsing):
  • ksvg2/svg/SVGElement.h:
11:45 AM Changeset in webkit [25097] by thatcher
  • 2 edits in trunk/WebKitTools

Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.

Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
this prevents making "build" directories in each project folder.

  • Scripts/webkitdirs.pm:
11:41 AM Changeset in webkit [25096] by darin
  • 2 edits in trunk

Add trailing newlines.

11:37 AM Changeset in webkit [25095] by darin
  • 2 adds in trunk

Add a copy of the ICU license to the copy of ICU headers that's there for
building on Mac OS X 10.4, for clarity. We might want to move these icu
directories inside a "mac/tiger" subdirectory at some point to make sure
people don't get confused about why these are here.

8:06 AM Changeset in webkit [25094] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Antti Koivisto.

<rdar://problem/5411803> Bumpercar crashes when loading a partial URL (FrameLoader::receivedMainResourceError())

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError): Nil check for the FrameLoader.
7:11 AM Changeset in webkit [25093] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2007-08-13 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin (​sachin.padma@nokia.com).
DESC: Fast display mode must be turned OFF for widgets
​http://bugs.webkit.org/show_bug.cgi?id=14966

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateChildFrameNamed):
7:07 AM Changeset in webkit [25092] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2007-08-03 asong

Reviewed by sachin.
DESC: [S60]: Title area displayed in Security Confirmation querries even though there is no title TSWID: ELTA-75H9ZB
​http://bugs.webkit.org/show_bug.cgi?id=14870

  • BrowserView/src/FormDataLoginStore.cpp: Add KEmtpyTitle Literal

(CFormDataLoginStore::SaveDialogL): Pass the new literal to DialogConfirm method

  • BrowserView/src/HttpLoaderEventToUiListener.cpp:Add KEmtpyTitle Literal

(CHttpLoaderEventToUiListener::AboutToLoadPage): Pass the new literal to DialogConfirm method
(CHttpLoaderEventToUiListener::GetUserAuthenticationDataL): Pass the new literal to DialogConfirm method

  • ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
7:06 AM Changeset in webkit [25091] by spadma
  • 3 edits in S60/trunk/WebKit

asong, reviewed by sachin

DESC: [S60]: Title area displayed in Security Confirmation querries even though there is no title TSWID: ELTA-75H9ZB
​http://bugs.webkit.org/show_bug.cgi?id=14870

  • BrowserView/src/FormDataLoginStore.cpp: Add KEmtpyTitle Literal

(CFormDataLoginStore::SaveDialogL): Pass the new literal to DialogConfirm method

  • BrowserView/src/HttpLoaderEventToUiListener.cpp: Add KEmtpyTitle Literal

(CHttpLoaderEventToUiListener::AboutToLoadPage): Pass the new literal to DialogConfirm me
(CHttpLoaderEventToUiListener::GetUserAuthenticationDataL): Pass the new literal to DialogConfirm me

  • ChangeLog: Using _L(" ") as an argument to DialogConfirm was incorrect. _L is deprecated and _LIT should be used instead. _L does not contain length information necessary to determine whether or not the descriptor passed in as a title is empty or not.
12:48 AM Changeset in webkit [25090] by bdash
  • 28 edits
    2 deletes in trunk

Roll out r25082 and the associated tests in r25083 as it introduced crashes in the SVG layout tests.

Aug 14, 2007:

7:50 PM Changeset in webkit [25089] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by Adam.

  • Updated Skipped list to reflect recent fixes.
  • platform/win/Skipped:
7:04 PM Changeset in webkit [25088] by sfalken
  • 5 edits
    1 add in trunk

<rdar://problem/5411482> Windows user agent language always returns "en"

Reviewed by Oliver.

6:23 PM Changeset in webkit [25087] by weinig
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff and Oliver.

Add test for <rdar://problem/5267870>
Mangleme: Reproducible assertion failure in -[WebCoreFrameBridge installInFrame:]

  • http/tests/misc/embedCrasher-expected.txt: Added.
  • http/tests/misc/embedCrasher.html: Added.

WebCore:

Reviewed by Geoff and Oliver.

Fix for <rdar://problem/5267870>
Mangleme: Reproducible assertion failure in -[WebCoreFrameBridge installInFrame:]

  • Change embed/plugin code path to detach the frame on willRemove instead of detach. This matches what frame and iframe do.

Test: http/tests/misc/embedCrasher.html

  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::willRemove):
  • html/HTMLPlugInElement.h:
6:17 PM Changeset in webkit [25086] by adele
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

  • editing/selection/user-select-text-inside-user-select-ignore-expected.txt: Added.
  • editing/selection/user-select-text-inside-user-select-ignore.html: Added.
  • fast/css/computed-style-expected.txt: Updated now that we've eliminated the auto value.
  • fast/css/computed-style-without-renderer-expected.txt: ditto.

WebCore:

Reviewed by Maciej.

Fix for <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

This change makes -webkit-user-select an inherited css property. For "user-select: none" we were already
acting like it was an inheritable property, where we let user-select:text on the children override its parent's user-select:none.
By making user-select really inherited (instead of inherited for some values), we eliminate the need for crawling up the tree to see
if an ancestor has user-select ignore set.

  • page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): Now that user-select is inherited, you don't need to walk up the render tree looking for ancestors with user-select:ignore set.
  • css/CSSStyleSelector.cpp: Eliminate SELECT_AUTO. (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • rendering/RenderStyle.h: (WebCore::): Eliminate SELECT_AUTO. Make userSelect inherited. (WebCore::RenderStyle::userSelect): (WebCore::RenderStyle::setUserSelect): (WebCore::RenderStyle::initialUserSelect):
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): (WebCore::RenderStyle::diff):
6:07 PM Changeset in webkit [25085] by andrew
  • 15 edits in trunk

JavaScriptCore:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

  • API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
  • kjs/number_object.cpp: (integer_part_noexp): (char_sequence):
  • kjs/ustring.cpp: (KJS::UString::UTF8String):

WebCore:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::saveState):
  • platform/KURL.cpp: (WebCore::KURL::KURL): (WebCore::KURL::init): (WebCore::KURL::decode_string): (WebCore::KURL::parse): (WebCore::KURL::encode_string):
  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL):
  • platform/mac/KURLMac.mm: (WebCore::KURL::KURL):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis):

win:

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

  • WebView.cpp: (getCompositionString):
5:23 PM Changeset in webkit [25084] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin, Hyatt.

  • fix <rdar://problem/5407795> -apple-line-clamp should never display less than one line
  • rendering/RenderFlexibleBox.cpp:(WebCore::RenderFlexibleBox::layoutVerticalBox): Use max to make sure it never computes a minimum of less than one line.
4:46 PM Changeset in webkit [25083] by bdakin
  • 1 edit
    2 adds in trunk/LayoutTests

Test for new support of empty style sheets.

  • fast/css/emptyStyleTag-expected.txt: Added.
  • fast/css/emptyStyleTag.html: Added.
4:30 PM Changeset in webkit [25082] by bdakin
  • 27 edits in trunk/WebCore

Reviewed by Hyatt.

Refactor of change for <rdar://problem/5404899> REGRESSION: Mail
crash in WebCore::FontFallbackList::fontDataAt() after dragging
image into text multiple times

The original fix that I made last night prevents the pending style
sheet count from being incremented until the element is in the
document. This fix prevents the style sheet from loading at all
until it is in the document.

Here is the fix.

  • dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): Call process. (WebCore::StyleElement::removedFromDocument): This can be reverted to its original state before my patch last night. (WebCore::StyleElement::process): childrenChanged is now called process. Return early if your not in the document. (WebCore::StyleElement::createSheet): Revert change from last night. The inDocument check is now in caller childrenChanged.
  • dom/StyleElement.h: insertedIntoDocument() must now accept an element in addition to a document.

This is an optimization to prevent calling updateStyleSelector()
too frequently.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement): (WebCore::HTMLStyleElement::finishedParsing): (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::childrenChanged): (WebCore::HTMLStyleElement::sheetLoaded):
  • html/HTMLStyleElement.h:
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement): (WebCore::SVGStyleElement::finishedParsing): (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::childrenChanged): (WebCore::SVGStyleElement::sheetLoaded):
  • ksvg2/svg/SVGStyleElement.h: (WebCore::SVGStyleElement::setCreatedByParser):

This is a name change. Document::stylesheetLoaded()
is now Document::removePendingSheet()

  • dom/Document.cpp: (WebCore::Document::removePendingSheet):
  • dom/Document.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::sheetLoaded):
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet):

This is another name change. closeRenderer() is now
finishedParsing()

  • dom/Node.h: (WebCore::Node::finishedParsing):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::finishedParsing):
  • html/HTMLAppletElement.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLFormControlElementWithState::finishedParsing):
  • html/HTMLGenericFormElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::finishedParsing):
  • html/HTMLObjectElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::popOneBlockCommon):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::finishedParsing):
  • html/HTMLScriptElement.h: (WebCore::HTMLStyleElement::setCreatedByParser):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::finishedParsing):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::finishedParsing):
  • ksvg2/svg/SVGElement.h:
4:08 PM Changeset in webkit [25081] by beidson
  • 13 edits
    2 adds in trunk

WebCore:

Reviewed by Darin, John, Maciej, Oliver, and Tim

<rdar://problem/5394708> - Crash on launch with corrupt icon database

The main part of the fix is to not disable SQLite's default level of protection - to leave the sync options at their normal,
mostly safe levels.

But in case lightning strikes at the exact right moment and someone ends up with a corrupt database, add some support code to
detect that condition and recover from it.

This is mainly accomplished by exposing the "PRAGMA integrity_check;" facilities of sqlite through IconDatabase SPI as well as
running that integrity check if a journal file is detected at launch (a strong indication that the last quit was not clean).
There's also a method exposed to allow clients to tell the icon database "I suspect something bad happened, please check integrity"

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::checkIntegrityBeforeOpening): Allow clients to suggest an integrity check (WebCore::IconDatabase::open): Add a check to see if the journal file for the database exists. If it does, run the integrity check. Also run the check if a client has suggested it to be necessary. If the integrity-check fails, we sadly have to destroy the database and recreate from scratch. Also - quite importantly - do not adjust the default sync preferences for the SQLDatabase. They were an optimization that might have been valid at one time but no longer affects any benchmarks we care about. (WebCore::IconDatabase::checkIntegrity): Perform the SQLite integrity_check pragma
  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::checkIntegrity): Keep IconDatabaseNone users building (WebCore::IconDatabase::checkIntegrityBeforeOpening): Ditto
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::open): Make a copy of the path string so we don't accidentally mutate anyone else's string on ::close()
  • platform/FileSystem.h: Added. Begin a long-needed platform file system abstraction
  • platform/mac/FileSystemMac.mm: Added. (WebCore::fileExists): Check if a file exists (WebCore::deleteFile): Delete a file
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::fileExists): (WebCore::deleteFile):
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::fileExists): (WebCore::deleteFile):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::fileExists): (WebCore::deleteFile):
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Darin, John, Maciej, Oliver, and Tim

<rdar://problem/5394708> - Crash on launch with corrupt icon database

Expose some new SPI to help recover from this case should it happen again

  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Use the new _databaseDirectory to determine where to open the database on disk (+[WebIconDatabase _checkIntegrityBeforeOpening]): Tell the icon database to check integrity when it opens (-[WebIconDatabase _databaseDirectory]): Moved the database-directory-determining logic here as it's now used in two places
  • Misc/WebIconDatabasePrivate.h: Added _checkIntegrityBeforeOpening SPI for clients to give hints about when the integrity check should run
4:00 PM Changeset in webkit [25080] by honeycutt
  • 2 edits in trunk/WebCore

2007-08-14 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Steve.

Build fix for Windows.

  • html/HTMLFormElement.cpp:
3:37 PM Changeset in webkit [25079] by staikos
  • 2 edits in trunk/WebCore

One-line obvious fix for context menus: don't connect the signal once for each
action, only once for the menu.

3:19 PM Changeset in webkit [25078] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

  • fix <rdar://problem/5410570> Global initializer introduced by use of std::numeric_limits in r24919
  • kjs/ustring.cpp: (KJS::overflowIndicator): Turned into a function. (KJS::maxUChars): Ditto. (KJS::allocChars): Use the functions. (KJS::reallocChars): Ditto. (KJS::UString::expandedSize): Ditto.
3:10 PM Changeset in webkit [25077] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Kevin Mccullough.


Removed special case that didn't belong. (It would allow a global
initializer to sneak into production builds, which would cause a
system-wide performance regression on Mac OS X.)

  • Scripts/check-for-global-initializers:
3:05 PM Changeset in webkit [25076] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Tim.


<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • editing/deleting/5408255.html: Added.
  • editing/deleting/5408255-expected.checksum: Added.
  • editing/deleting/5408255-expected.png: Added.
  • editing/deleting/5408255-expected.txt: Added.

WebCore:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Use -webkit-user-select:ignore for the deletion UI.

WebKitTools:

Reviewed by Tim.


<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

  • DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES only for elements with the class needsDeletionUI.
2:24 PM Changeset in webkit [25075] by aroben
  • 3 edits in trunk/WebKit/win

Store user defaults in a non-mutable CFDictionaryRef

Also renamed WebPreferences' static members:

m_standardPreferences -> s_standardPreferences
m_standardUserDefaults -> s_defaultSettings

Reviewed by Darin and John.

  • WebPreferences.cpp: (WebPreferences::getInstanceForIdentifier): (WebPreferences::initializeUserDefaults): Construct the dictionary as a local CFMutableDictionaryRef, then assign it to the non-mutable static member. (WebPreferences::valueForKey): (WebPreferences::removeDefaultsIfNeeded): (WebPreferences::standardPreferences):
  • WebPreferences.h:
2:24 PM Changeset in webkit [25074] by aroben
  • 4 edits in trunk/WebKit/win

Fix <rdar://problem/5214504> No way to change WebPreferences defaults (all preferences get written to disk)

We now only write to disk values that have been explicitly set, and
never write any default values.

This is not enough, however, as anyone who has used WebKit prior to
this change will have the default values sitting in their preferences
plist on disk. To remedy this, we perform a one-time removal of any
key-value pairs that match a pair in the defaults dictionary.

Reviewed by Steve, John, Ada, and Darin.

  • WebPreferenceKeysPrivate.h: Added new key to ensure we only remove the defaults once.
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Renamed from initialize, and made sure we only set up the defaults dictionary once. Now that the defaults dictionary is never modified after creation, we don't need to check whether the keys are already present. (WebPreferences::setStringValue): Don't modify the defaults dictionary. (WebPreferences::setIntegerValue): Ditto. (WebPreferences::setBoolValue): Ditto. (WebPreferences::save): Write out the user's preferences, not the defaults. (WebPreferences::load):
    • Removed gotos and early declarations now that we're using RetainPtr everywhere.
    • Initialize m_privatePrefs with an empty dictionary if we didn't read in a plist.
    • Call migrateDefaultSettingsFromSafari3Beta after loading.

(WebPreferences::migrateDefaultSettingsFromSafari3Beta): Added.
(WebPreferences::removeValuesMatchingDefaultSettings): Added.
(WebPreferences::initWithIdentifier): Don't initialize m_privatePrefs
-- load() does this now.

  • WebPreferences.h: Updated/added declarations.
2:24 PM Changeset in webkit [25073] by aroben
  • 3 edits in trunk/WebKit/win

Use RetainPtr to store WebPreferences::m_privatePrefs

Reviewed by Darin.

  • WebPreferences.cpp: (WebPreferences::setStringValue): (WebPreferences::setIntegerValue): (WebPreferences::setBoolValue): (WebPreferences::initWithIdentifier):
  • WebPreferences.h:
1:20 PM Changeset in webkit [25072] by adele
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14746
<rdar://problem/5401041> REGRESSION: Form state not saved for forms that submit via HTTPS even if they do not contain a password field

  • http/tests/navigation/resources/restore-form-state-https-1.html: Added.
  • http/tests/navigation/restore-form-state-https-expected.txt: Added.
  • http/tests/navigation/restore-form-state-https.html: Added.
12:18 PM Changeset in webkit [25071] by antti
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Add test for <rdar://problem/5143183>
Air Mail postmark shows up wrong in Firefox due to use of CSS background-position-x/y


Also update a few tests to expect background-position instead of background-position-x/y

  • fast/css/background-position-serialize-expected.txt: Added.
  • fast/css/background-position-serialize.html: Added.
  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/remove-shorthand-expected.txt:

WebCore:

Reviewed by Darin.


Fix <rdar://problem/5143183>
Air Mail postmark shows up wrong in Firefox due to use of CSS background-position-x/y


Safari was using non-standard background-position-x/y properties when serializing style, both normal
and computed. As a result Safari generated CSS would not render correctly in Firefox.


Use standard background-position property instead.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::cssText):
11:07 AM Changeset in webkit [25070] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

  • Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
10:36 AM Changeset in webkit [25069] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Brady and Dr. Harrison.

Fix typo. 'whitespace' property is spelled 'white-space'.

  • page/inspector/inspector.css:

Aug 13, 2007:

10:41 PM Changeset in webkit [25068] by bdakin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5404899> REGRESSION: Mail crash in
WebCore::FontFallbackList::fontDataAt() after dragging image into
text multiple times

We were crashing because style information was not up-to-date. This
patch fixes the problem in two ways:

Style information was not up to date at the time of the crash
because the document thought there was still a pending style sheet.
The pending style sheet counter was incremented when a call to
cloneNode from Mail cloned a style node with an imported style
sheet. Because Mail disables the cache, the style sheet did not
load immediately for the cloned node, and we do not check again to
see if it has loaded in time to decrement the pending style sheet
counter before the crash point. The fix here is only to increment
the pending style sheet counter for elements that are already in
the document.

  • dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): If we have a CSS style sheet that is currently loading, increment the pending style sheet counter. This should keep the counter accurate in the case where a style node is cloned and then immediately inserted into the document. (WebCore::StyleElement::removedFromDocument): If we have a CSS style sheet that is currently loading, decrement the pending style sheet count. This is required to keep the correct balance, given the change above. (WebCore::StyleElement::createSheet): Only addPendingSheet() and checkLoaded() if we are in the document.

Here is Darin's original fix. It seems worth keeping this fix too.
Font style information should not cause a crash if there are still
pending style sheets. This is good belt-and-suspenders in case
there is another way to run into this bug with a wacky timing
issue.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): Update the font.
10:39 PM Changeset in webkit [25067] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14635
rdar://problem/5340188
Uploading file with non-ASCII character in path fails

File upload cannot be tested in DumpRenderTree.

  • html/HTMLFormElement.cpp: (WebCore::pathGetFilename): A cross-platform helper that extracts a file name from a path. (WebCore::HTMLFormElement::formData): Use the above helper instead of code that doesn't work on Windows.
10:24 PM Changeset in webkit [25066] by ap
  • 3 edits
    2 adds in trunk

​http://bugs.webkit.org/show_bug.cgi?id=14951
REGRESSION: page interpreted as UTF-8 because of stray <?xml> after <head>

Test: fast/encoding/misplaced-xml-declaration.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Only honor XML declaration at the very beginning of the file.
7:04 PM Changeset in webkit [25065] by oliver
  • 2 edits in trunk/WebCore

rs=sam

Correct accidentally modified code.

  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):
6:52 PM Changeset in webkit [25064] by adele
  • 5 edits in trunk/WebCore

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14746
<rdar://problem/5401041> REGRESSION: Form state not saved for forms that submit via HTTPS even if they do not contain a password field

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Restore our old behavior that will save form state for secure forms. This will also match Firefox behavior.
  • dom/Document.cpp: Removed secureFormAdded(), secureFormRemoved(), hasSecureForm() which are no longer used.
  • dom/Document.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::attach): (WebCore::HTMLFormElement::parseMappedAttribute):
6:44 PM Changeset in webkit [25063] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/5386183> REGRESSION (9A504-9A508): Underline of inline hole is too thin
on Japanese DotMac page


Hack the line metrics for the Hiragino font families so that they always allow space for
the marked text underline.


  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):
5:19 PM Changeset in webkit [25062] by weinig
  • 3 edits in trunk/LayoutTests

Reviewed by Kevin McCullough.

Another attempt at getting these to pass reliably.

  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html:
5:13 PM Changeset in webkit [25061] by hyatt
  • 2 edits in trunk/WebCore

Reviewed by aroben


<rdar://problem/5400446> messed up content on calendar.yahoo.com and my.yahoo.com

Fix some more bad assumptions about <html> being the first child of the document now that we
properly support HTML5's model (where a comment node preceding <html> will in fact be its sibling).

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::createHead):
3:41 PM Changeset in webkit [25060] by weinig
  • 5 edits in trunk/LayoutTests

Reviewed by Geoff.

Ensure that these tests don't fail intermittently.

  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-opened-frame.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html:
2:24 PM Changeset in webkit [25059] by sfalken
  • 1 copy in tags/Safari-523.1b

New tag.

2:24 PM Changeset in webkit [25058] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

12:14 PM Changeset in webkit [25057] by justing
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


<rdar://problem/5333725> -webkit-user-select: none makes selection difficult

  • editing/selection/5333725-expected.checksum: Added.
  • editing/selection/5333725-expected.png: Added.
  • editing/selection/5333725-expected.txt: Added.
  • editing/selection/5333725.html: Added.


Added a workaround for a bug where -webkit-user-select:none
has no effect on the body if placed on the html element:

  • editing/selection/select-all-user-select-none.html:

WebCore:

Reviewed by Darin.


<rdar://problem/5333725> -webkit-user-select: none makes selection difficult


Let users create selections if they mouse down in a -webkit-user-select:none
region, just (continue to) disallow selection endpoints in those regions, and
don't paint those regions as selected if they are fully enclosed by a selection.
For example, in xxyyyxx where x is -webkit-user-select:none, a user can mouse down
between the first two xs and drag across yyy to the second two xs to create a
selection xxyyyxx.


  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Allow selectAll inside a root that has -webkit-user-select:none, because it may contain content that is selectable (VisiblePosition and Selection creation will keep Selection endpoints out of -webkit-user-select:none regions).
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): Use canMouseDownStartSelect instead of the ambiguously named shouldSelect(). (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::EventHandler::updateSelectionForMouseDrag): Use canMouseDragExtendSelect. (WebCore::EventHandler::selectCursor): Paint an ibeam in -webkit-user-select:none regions, because you can click in those regions to create a selection. (WebCore::EventHandler::canMouseDownStartSelect): Now fires the selectStart event, and returns true in -webkit-user-select: none regions. (WebCore::EventHandler::canMouseDragExtendSelect): This is identical to canMouseDownStartSelect because of 12823, even though it seems strange that we would fire the selectStart event here.
  • page/EventHandler.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): Only -webkit-user-select:ignore regions will prevent selection creation.
  • rendering/RenderObject.h:
12:02 PM Changeset in webkit [25056] by andersca
  • 5 edits in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5360748>
REGRESSION (r21002-r21003): Flash widget sniffer doesn't work (affects iWeb)


Update test case to handle the case where the node list is accessed after
the document has finished loading.


  • fast/dom/NodeList/invalidate-node-lists-when-parsing-expected.txt:
  • fast/dom/NodeList/invalidate-node-lists-when-parsing.html:

WebCore:

Reviewed by Maciej.

<rdar://problem/5360748>
REGRESSION (r21002-r21003): Flash widget sniffer doesn't work (affects iWeb)

Don't check whether the document is being parsed or not, because the node list
could be accessed after the document has finished parsing.


  • dom/Node.cpp: (WebCore::Node::registerNodeList):
11:02 AM Changeset in webkit [25055] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Use the cygwin specific Apache config file under cygwin.

  • Scripts/run-webkit-httpd:
5:06 AM Changeset in webkit [25054] by lars
  • 2 edits in trunk/WebCore

no need to update regions that are not visible on the webpage.

Aug 12, 2007:

10:37 PM Changeset in webkit [25053] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-007/WebKit

Tag for WebKit for Security Update 2007-007 (WebKit-419.3).

10:37 PM Changeset in webkit [25052] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-007/WebCore

Tag for WebCore for Security Update 2007-007 (WebCore-418.23).

10:37 PM Changeset in webkit [25051] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-007/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2007-007 (unchanged from 10.4.10).

10:37 PM Changeset in webkit [25050] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-007/JavaScriptCore

Tag for JavaScriptCore for Security Update 2007-007 (JavaScriptCore-418.6.1).

10:36 PM Changeset in webkit [25049] by bdash
  • 1 add in releases/Apple/Tiger/Security Update 2007-007

New release tag.

10:36 PM Changeset in webkit [25048] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-006/WebKit

Tag for WebKit for Security Update 2007-006 (WebKit-419.2.1).

10:35 PM Changeset in webkit [25047] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-006/WebCore

Tag for WebCore for Security Update 2007-006 (WebCore-418.22.2).

10:35 PM Changeset in webkit [25046] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-006/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2007-006 (unchanged from 10.4.10).

10:35 PM Changeset in webkit [25045] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-006/JavaScriptCore

Tag for JavaScriptCore for Security Update 2007-006 (unchanged from 10.4.10).

10:35 PM Changeset in webkit [25044] by bdash
  • 1 add in releases/Apple/Tiger/Security Update 2007-006

New release tag.

10:34 PM Changeset in webkit [25043] by bdash
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.10/WebKit

Tag for WebKit for Mac OS X Update 10.4.10 (WebKit-419.2).

10:34 PM Changeset in webkit [25042] by bdash
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.10/WebCore

Tag for WebCore for Mac OS X Update 10.4.10 (WebCore-418.22).

10:34 PM Changeset in webkit [25041] by bdash
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.10/JavaScriptGlue

Tag for JavaScriptGlue for Mac OS X Update 10.4.10 (unchanged from 10.4.9).

10:33 PM Changeset in webkit [25040] by bdash
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.10/JavaScriptCore

Tag for JavaScriptCore for Mac OS X Update 10.4.10 (JavaScriptCore-418.5).

10:33 PM Changeset in webkit [25039] by bdash
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.10

New release tag.

10:33 PM Changeset in webkit [25038] by bdash
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.9/WebKit

Tag for WebKit for Mac OS X Update 10.4.9 (WebKit-419).

10:32 PM Changeset in webkit [25037] by bdash
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.9/WebCore

Tag for WebCore for Mac OS X Update 10.4.9 (unchanged from 10.4.8).

10:32 PM Changeset in webkit [25036] by bdash
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.9/JavaScriptGlue

Tag for JavaScriptGlue for Mac OS X Update 10.4.9 (unchanged from 10.4.8).

10:32 PM Changeset in webkit [25035] by bdash
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.9/JavaScriptCore

Tag for JavaScriptCore for Mac OS X Update 10.4.9 (unchanged from 10.4.8).

10:32 PM Changeset in webkit [25034] by bdash
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.9

New release tag.

10:31 PM Changeset in webkit [25033] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-002/WebKit

Tag for WebKit for Security Update 2007-002 (WebKit-418.9.1).

10:31 PM Changeset in webkit [25032] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-002/WebCore

Tag for WebCore for Security Update 2007-002 (unchanged from 10.4.8).

10:31 PM Changeset in webkit [25031] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-002/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2007-002 (unchanged from 10.4.8).

10:31 PM Changeset in webkit [25030] by bdash
  • 1 copy in releases/Apple/Tiger/Security Update 2007-002/JavaScriptCore

Tag for JavaScriptCore for Security Update 2007-002 (unchanged from 10.4.8).

10:30 PM Changeset in webkit [25029] by bdash
  • 1 add in releases/Apple/Tiger/Security Update 2007-002

New release tag.

8:25 PM Changeset in webkit [25028] by mjs
  • 4 edits
    28 adds in trunk

LayoutTests:

Reviewed by Darin and Sam.


  • test cases for <rdar://problem/5395213> cross-domain access to individual components of location object should be denied.
  • http/tests/security/cross-frame-access-location-expected.txt: This test's results changed, there are more debug messages due to access being legitimately denied.


The remainder are new tests and support:

  • http/tests/security/resources/xss-DENIED-assign-location-hash-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-host-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-host-failure.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-hostname-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-hostname-failure.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-nonstandardProperty-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-pathname-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-pathname-failure.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-protocol-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-protocol-failure.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-reload-attacker.html: Added.
  • http/tests/security/resources/xss-DENIED-assign-location-search-attacker.html: Added.
  • http/tests/security/xss-DENIED-assign-location-hash-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-hash.html: Added.
  • http/tests/security/xss-DENIED-assign-location-host-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-host.html: Added.
  • http/tests/security/xss-DENIED-assign-location-hostname-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-hostname.html: Added.
  • http/tests/security/xss-DENIED-assign-location-nonstandardProperty-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-nonstandardProperty.html: Added.
  • http/tests/security/xss-DENIED-assign-location-pathname-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-pathname.html: Added.
  • http/tests/security/xss-DENIED-assign-location-protocol-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-protocol.html: Added.
  • http/tests/security/xss-DENIED-assign-location-reload-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-reload.html: Added.
  • http/tests/security/xss-DENIED-assign-location-search-expected.txt: Added.
  • http/tests/security/xss-DENIED-assign-location-search.html: Added.

WebCore:

Reviewed by Darin and Sam.


<rdar://problem/5395213> cross-domain access to individual components of location object should be denied.

  • bindings/js/kjs_window.cpp: (KJS::Location::put): Add the appropriate cross-domain access checks.
8:06 PM Changeset in webkit [25027] by darin
  • 4 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fix <rdar://problem/5403724> REGRESSION: text inputs are not scrolled to make inline input visible (14912)
  • editing/Editor.h: Made setIgnoreMarkedTextSelectionChange no longer inline. It now has a side effect of revealing the selection when you set it to false. Added private revealSelectionAfterEditingOperation helper.
  • editing/Editor.cpp: (WebCore::Editor::deleteRange): Calls revealSelectionAfterEditingOperation instead of calling m_frame->revealSelection directly. (WebCore::Editor::replaceSelectionWithFragment): Ditto. (WebCore::Editor::insertOrderedList): Ditto. (WebCore::Editor::insertUnorderedList): Ditto. (WebCore::Editor::increaseSelectionListLevel): Ditto. (WebCore::Editor::increaseSelectionListLevelOrdered): Ditto. (WebCore::Editor::increaseSelectionListLevelUnordered): Ditto. (WebCore::Editor::decreaseSelectionListLevel): Ditto. (WebCore::Editor::insertLineBreak): Ditto. (WebCore::Editor::insertParagraphSeparator): Ditto. (WebCore::Editor::replaceMarkedText): Ditto. (WebCore::Editor::revealSelectionAfterEditingOperation): Added. Calls revealSelection, unless we are in the ignoreMarkedTextSelectionChange state. If we are in that state, we're in the middle of a composite editing operation and we shouldn't try to scroll to reveal the selection until the operation is done. (WebCore::Editor::setIgnoreMarkedTextSelectionChange): Made no longer inline. If changing the state from true to false, then calls revealSelectionAfterEditingOperation.
  • WebCore.exp: Add new entry point for no-longer-inline setter function.
7:42 PM Changeset in webkit [25026] by darin
  • 11 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

Test: fast/js/regexp-non-capturing-groups.html

  • kjs/string_object.cpp: (KJS::replace): Add missing code to handle undefined backreferences; before we'd get the empty string instead of a JavaScript "undefined" value. (KJS::StringProtoFunc::callAsFunction): Implemented backreference support for split.
  • pcre/pcre_exec.c: (match): Made backreferences to undefined groups match the empty string instead of always failing. Only in JAVASCRIPT mode.
  • tests/mozilla/expected.html: Add a new expected test success, since this fixed one test result.

LayoutTests:

Reviewed by Maciej.

  • fast/js/regexp-non-capturing-groups-expected.txt: Added.
  • fast/js/regexp-non-capturing-groups.html: Added.
  • fast/js/resources/regexp-non-capturing-groups.js: Added.
  • fast/js/resources/js-test-pre.js: Updated to add a special case for array results, since there are some array results in the test. Also cut down on the verbosity of failures when the type of the actual result is the same as the type of the expected result. And get rid of the special case function just for NaN.
  • fast/js/regexp-unicode-overflow.html: Let the make-js-test-wrappers script regenerate this file (it removed one of the trailing newlines).
  • fast/js/kde/encode_decode_uri-expected.txt: This test now passes. I'm not sure why it was failing before.
  • fast/js/char-at-expected.txt: Removed all the periods at the end of NaN test PASS messages; they are now consistent with all the other tests.
  • fast/js/date-parse-comments-test-expected.txt: Ditto.
  • fast/js/date-parse-test-expected.txt: Ditto.
7:41 PM Changeset in webkit [25025] by ggaren
  • 8 edits in trunk/WebCore

Reviewed by Maciej Stachowiak, Dave Hyatt.


Changed the dead resource LRU-SP algorithm to measure an object's
total size, not just its encoded size. This will allow us to make
better decisions about what data to evict when the cache is small. For
example, the PLT can now run with a 16MB cache without fully evicting
any resources.


(Previously, we had assumed that decoded size would be an OK estimate
of encoded size, but that is not true of GIF, whose decoded size can be
orders of magnitude greater than its encoded size.)


Subtly, destroying a resource's decoded data now increases its recency
by moving it to the head of a smaller LRU list. This is slightly odd,
but, since all resources get the same treatment, it shouldn't hurt
the eviction algorithm.

  • history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow): Make sure that a dead resource eviction doesn't happen until we've released all of our dead pages. Otherwise, the cache will make terrible decisions about what to evict because all of our dead resources will seem live.
  • loader/Cache.cpp: (WebCore::Cache::Cache): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): Removed call to removeFromLiveDecodedResourcesList because this happens automatically now as a part of the process of changing the resource's decoded size. (WebCore::Cache::lruListFor): * The key change. * Compute the appropriate LRU list based on total size, not encoded size. (WebCore::Cache::dumpLRULists): Added debug logging function to help visualize the cache.
  • loader/Cache.h: (WebCore::Cache::setDeadResourcePruneEnabled): (WebCore::Cache::deadResourcePruneEnabled):
  • loader/CachedImage.cpp: Moved decoded size tracking code from here up into the base class. Currently, only CachedImage has a use for that functionality, but other subclasses might need it in the future, and the base class is already responsible for similar code related to encoded size tracking. (WebCore::CachedImage::decodedSizeChanged):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::setDecodedSize): Move us in the LRU-SP list just like setEncodedSize does, since decoded size counts now, too. (WebCore::CachedResource::setEncodedSize): Changed slightly to match the style of setDecodedSize.
  • loader/CachedResource.h: (WebCore::CachedResource::decodedSize):
12:20 PM Changeset in webkit [25024] by ap
  • 2 edits in trunk/WebKit

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=4648
Shockwave unable to load GZip'd text resources when server sends Content-Length header

  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream startStreamWithResponse:]): Don't trust -[NSURLResponse expectedContentLength] if Content-Encoding is not identity.
4:31 AM Changeset in webkit [25023] by aroben
  • 2 edits in trunk/WebKitTools

Generate results for new tests in a more logical location

New platform-specific tests always have their results generated right
next to the test. New cross-platform tests will have their results
generated a) in the cross-platform directory, if they are text-only,
or b) in the least-specific platform directory, if they are render
tree dumps.

Reviewed by Lars.

  • Scripts/run-webkit-tests:
4:31 AM Changeset in webkit [25022] by aroben
  • 2 edits in trunk/WebKitTools

Print the actual directory where new results are generated.

Before, we were printing an unpredictable, context-specific substring
of the directory.

Reviewed by Lars.

  • Scripts/run-webkit-tests:
4:31 AM Changeset in webkit [25021] by aroben
  • 2 edits in trunk/WebKitTools

Factor some common code into a stripExtension() subroutine.

Reviewed by Lars.

  • Scripts/run-webkit-tests: Also removed some debugging output.
3:08 AM Changeset in webkit [25020] by antti
  • 1 edit in trunk/LayoutTests/ChangeLog

Correct wrong URL in ChangeLog entry

3:05 AM Changeset in webkit [25019] by antti
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.


Add test for ​http://bugs.webkit.org/attachment.cgi?id=15818&action=edit which
Mitz fixed in r24973.


I had a fix for <rdar://problem/5267021>
REGRESSION: Loading Slashdot Firehose is 9X slower on Safari 3.0 than Safari 2.0
which turned out to be a dublicate.


At least we can use the layout test I did.

  • http/tests/local/style-access-before-stylesheet-loaded-expected.txt: Added.
  • http/tests/local/style-access-before-stylesheet-loaded.html: Added.
2:18 AM Changeset in webkit [25018] by aroben
  • 2 edits in trunk/WebKit/win

Fix <rdar://problem/5278790> Hole for find-on-page match in subframe isn't clipped by frame bounds

Reviewed by Maciej.

  • WebView.cpp: (WebView::rectsForTextMatches): Ported fix from r23586.
2:18 AM Changeset in webkit [25017] by aroben
  • 2 edits in trunk/WebKit/win

Prevent an ASSERT on launch by initializing AtomicString in WebKitGraphics

Reviewed by Maciej.

  • WebKitGraphics.cpp: (makeFont):

Aug 11, 2007:

1:55 PM Changeset in webkit [25016] by pewtermoose
  • 1 delete in trunk/LayoutTests/mac

Forgot to remove this directory

1:37 PM Changeset in webkit [25015] by pewtermoose
  • 3 edits
    3 moves
    2 adds in trunk

LayoutTests:

Reviewed over and over and over by Adam Roben.

Bug 14740: Hierarchical layout tests and platform organization
​http://bugs.webkit.org/show_bug.cgi?id=14740

Add support for platform-specific layout tests and results.
New platform structure is as follows:

  • platform: Added.
  • platform/mac: Added.
  • mac/leopard/ -> platform/mac-leopard
  • win/ -> platform/win
  • qt/ -> platform/qt

WebKitTools:

Reviewed over and over and over by Adam Roben.

Bug 14740: Hierarchical layout tests and platform organization
​http://bugs.webkit.org/show_bug.cgi?id=14740

Add support for platform-specific layout tests and results.

  • Scripts/run-webkit-tests:
12:40 PM Changeset in webkit [25014] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

Refactored svn-create-path to use a hash-of-hashes data structure to keep
track of changed files. In the top level hash, keys are paths to files and
values are 'fileData' hashes with the following keys and values:

  • isBinary: boolean value (set to true for non-text files like images, etc.)
  • isTestFile: boolean value (set to true if file exists within a known test directory)
  • modificationType: string equal to one of 'addition', 'additionWithHistory', 'modification' or 'deletion'
  • path: string equal to the path to the file (this may seem redundant, but it is required to use the second-level 'fileData' hash independent of the top-level hash)
  • sourceFile: [optional] string equal to the path of the original file that was copied or moved
  • sourceRevision: [optional] string equal to the revision of the original file that was copied or moved
  • Scripts/svn-create-patch: Moved call to GetOptions() to its own statement that saves the return value in $result, then checks it before printing help. Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash and eliminated two for() loops. (binarycmp): Added. Used with sort() to order non-binary files before binary files. (findBaseUrl): Added. Extracted from findSourceFileAndRevision(). (findMimeType): Added optional second argument that takes a revision number. (generateDiff): Updated to take one fileData argument instead of three ($file, $modificationType, $isBinary). (generateFileList): Updated to take one hash ref argument (%diffFiles) instead of three (%sourceFiles, %testFiles, %binaryFiles). Populates %diffFiles using paths for keys and fileData hashes for values. (manufacturePatchForAdditionWithHistory): Updated to take one fileData argument. (pathcmp): Updated to take two fileData arguments instead of two strings. (testfilecmp): Added. Used with sort() to order non-test files before test files.
11:27 AM Changeset in webkit [25013] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
11:13 AM Changeset in webkit [25012] by zecke
  • 2 edits in trunk/WebCore

2007-08-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Anders.

Implement passing events to a subframe. The code is copied from
the windows port and passSubframeEventToSubframe was removed as it
is not called and it is not avilable in the windows port as well.

  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe):
11:01 AM Changeset in webkit [25011] by darin
  • 15 edits
    34 adds in trunk

LayoutTests:

2007-08-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/table/100-percent-cell-width-expected.checksum: Added.
  • fast/table/100-percent-cell-width-expected.png: Added.
  • fast/table/100-percent-cell-width-expected.txt: Added.
  • fast/table/100-percent-cell-width.html: Added.
  • fast/table/percent-widths-stretch-expected.checksum: Added.
  • fast/table/percent-widths-stretch-expected.png: Added.
  • fast/table/percent-widths-stretch-expected.txt: Added.
  • fast/table/percent-widths-stretch.html: Added.
  • fast/text/whitespace/026-expected.checksum:
  • fast/text/whitespace/026-expected.png:
  • fast/text/whitespace/026-expected.txt:
  • tables/mozilla/bugs/bug35662-expected.checksum:
  • tables/mozilla/bugs/bug35662-expected.png:
  • tables/mozilla/bugs/bug35662-expected.txt:
  • tables/mozilla/bugs/bug5799-expected.checksum:
  • tables/mozilla/bugs/bug5799-expected.png:
  • tables/mozilla/bugs/bug5799-expected.txt:
  • tables/mozilla/core/col_span-expected.checksum:
  • tables/mozilla/core/col_span-expected.png:
  • tables/mozilla/core/col_span-expected.txt:

2007-08-11 Darin Adler <Darin Adler>

  • added a bunch of missing layout test results
  • editing/style/font-family-with-space-expected.checksum: Added.
  • editing/style/font-family-with-space-expected.png: Added.
  • fast/dom/frame-loading-via-document-write-expected.checksum: Added.
  • fast/dom/frame-loading-via-document-write-expected.png: Added.
  • fast/encoding/xmacroman-encoding-test-expected.checksum: Added.
  • fast/encoding/xmacroman-encoding-test-expected.png: Added.
  • fast/frames/frame-navigation-expected.checksum: Added.
  • fast/frames/frame-navigation-expected.png: Added.
  • fast/frames/frame-set-whitespace-attributes-expected.checksum: Added.
  • fast/frames/frame-set-whitespace-attributes-expected.png: Added.
  • fast/frames/inline-object-inside-frameset-expected.checksum: Added.
  • fast/frames/inline-object-inside-frameset-expected.png: Added.
  • fast/html/keygen-expected.checksum: Added.
  • fast/html/keygen-expected.png: Added.
  • fast/images/pdf-as-image-landscape-expected.checksum: Added.
  • fast/images/pdf-as-image-landscape-expected.png: Added.
  • fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
  • fast/inline-block/14498-positionForCoordinates-expected.png: Added.

WebCore:

2007-08-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Tests: fast/table/100-percent-cell-width.html

fast/table/percent-widths-stretch.html

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcPrefWidths): Changed the value used instead of 0% to avoid division by zero from 1% to less than 0.01%. Removed code that added 0.5px to non-percent widths when calculating the scaling factor. The latter change is covered by the percent-widths-stretch test, where the new results match both WinIE 7 and Firefox 3.
10:18 AM Changeset in webkit [25010] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Antti.

  • test for <rdar://problem/5266535> REGRESSION: <img> inside <map> no longer allowed in strict mode (breaks chemicalelements.com)
  • fast/parser/strict-img-in-map-expected.txt: Added.
  • fast/parser/strict-img-in-map.html: Added.

WebCore:

Reviewed by Antti.

  • fix <rdar://problem/5266535> REGRESSION: <img> inside <map> no longer allowed in strict mode (breaks chemicalelements.com)

Test: fast/parser/strict-img-in-map.html

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::checkDTD): Removed FIXME saying this code is strange, since this code matches the HTML 4 specification almost exactly. Made <img> elements allowed even in strict mode and added small comments to clarify what comes from the DTD and what is non-standard.
6:53 AM Changeset in webkit [25009] by zecke
  • 2 edits in trunk/WebCore

2007-08-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Lars.

GdkEventKey::string is not supposed to be used. The length
of this string is zero for non ascii charachters. Use the
gdk_unicode_to_keyval to convert the keyval to a UChar and construct
a String. This change makes it possible to input non ascii
charachters.

  • platform/gdk/KeyEventGdk.cpp: (WebCore::keyIdentifierForGdkKeyCode): (WebCore::singleCharacterString): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
4:52 AM Changeset in webkit [25008] by andrew
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mark Rowe.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=14645
getPropertyValue should be case insensitive


Test for getPropertyValue, setProperty, removeProperty being case-insensitive

  • fast/css/css-properties-case-insensitive-expected.txt: Added.
  • fast/css/css-properties-case-insensitive.html: Added.

WebCore:

Reviewed by Mark Rowe.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=14645
getPropertyValue should be case insensitive


When we get the propertyID for a given string we convert to lowercase.


This also applies to setProperty, removeProperty and others.


  • css/CSSStyleDeclaration.cpp: (WebCore::propertyID):
Note: See TracTimeline for information about the timeline view.