⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 12, 2008:

10:32 PM Changeset in webkit [30190] by timothy@apple.com
  • 1 edit in trunk/WebCore/platform/sql/SQLiteDatabase.cpp

Comment out the ASSERT to make the layout tests pass. Filed <rdar://problem/5739818> to track the issue.

10:04 PM Changeset in webkit [30189] by timothy@apple.com
  • 7 edits in trunk/WebCore

Reviewed by Brady Eidson.

<rdar://problem/5652560> Can't delete database if the website that
uses it has been opened in this session

Close the Database on the database thread before deleting the file.
Tested and works on Windows and Mac.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::close): Assert we are on the opening thread.
  • storage/Database.cpp: (WebCore::Database::markAsDeletedAndClose): Unschedule any pending Database tasks, and start and imediate DatabaseCloseTask. (WebCore::Database::close): Close the SQLDatabase.
  • storage/Database.h: Renamed markAsDeleted to markAsDeletedAndClose.
  • storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::DatabaseCloseTask): New task. (WebCore::DatabaseCloseTask::doPerformTask): Call close on the Database. (WebCore::DatabaseCloseTask::debugTaskName): Return "DatabaseCloseTask".
  • storage/DatabaseTask.h: Add DatabaseCloseTask.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteDatabaseFile): Call the renamed markAsDeletedAndClose.
9:12 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
8:22 PM Changeset in webkit [30188] by oliver@apple.com
  • 3 edits in trunk/WebCore

Endeavour to fix qt and gtk builds

7:07 PM Changeset in webkit [30187] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Clean up auto-version.sh a bit

It now does quite a bit less file I/O and many fewer fork/exec pairs.
It's also quite a bit easier to read.

Reviewed by Steve.

  • win/tools/scripts/auto-version.sh:
6:53 PM Changeset in webkit [30186] by sfalken@apple.com
  • 2 edits
    2 adds in trunk/WebKit/win

Use a precompiled header to build WebKit.


Reviewed by Adam.

  • WebKit.vcproj/WebKit.vcproj:
  • WebKitPrefix.cpp: Added.
  • WebKitPrefix.h: Added.
6:11 PM Changeset in webkit [30185] by oliver@apple.com
  • 6 edits in trunk/WebCore

Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Remove ifdef's from canvas paint code

Reviewed by Eric S.

By making GraphicsContext aware of the crossplatform ImageBuffer
type we can migrate the ifdef-ified paint code in HTMLCanvasElement
into platform implementations of GraphicsContext.

5:10 PM Changeset in webkit [30184] by beidson@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Darin Adler

Fix for <rdar://problem/5737692> - Database API needs to support SuccessCallback

Layout tests will come shortly with a mess of DRT changes

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): Standardize on "empty string" instead of null string as different paths of constructing a SecurityOrigin were causing different hashes for the "same" SecurityOrigin
  • storage/Database.cpp: (WebCore::Database::changeVersion): Pass in the successCallback (WebCore::Database::transaction): Ditto
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::debugStepName): (WebCore::SQLTransaction::performNextStep): Update ASSERTs for the new valid steps (WebCore::SQLTransaction::performPendingCallback): Ditto (WebCore::SQLTransaction::postflightAndCommit): Schedule the success callback if it exists - otherwise skip straight to cleanupAfterSuccessCallback() (WebCore::SQLTransaction::deliverSuccessCallback): Deliver success callback on the main thread, then schedule cleanupAfterSuccessCallback() (WebCore::SQLTransaction::cleanupAfterSuccessCallback): Cleanup and end the transaction (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
  • storage/SQLTransaction.h:
4:18 PM Changeset in webkit [30183] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Versioning script change.

  • win/tools/scripts/auto-version.sh:
4:16 PM Changeset in webkit [30182] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Changes to support merged MIDL output.


All COM interfaces are now generated to WebKit.h.


Reviewed by Sam, Ada.

  • bindings/scripts/CodeGeneratorCOM.pm:
4:16 PM Changeset in webkit [30181] by sfalken@apple.com
  • 19 edits in trunk/WebKitTools

Changes to support merged MIDL output.

All COM interfaces are now generated to WebKit.h.

Reviewed by Sam, Ada.

  • Drosera/win/BaseDelegate.h:
  • Drosera/win/DebuggerClient.cpp:
  • Drosera/win/DebuggerDocumentPlatform.cpp:
  • Drosera/win/Drosera.cpp:
  • Drosera/win/ServerConnection.cpp:
  • Drosera/win/ServerConnection.h:
  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/EditingDelegate.h:
  • DumpRenderTree/win/EventSender.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.h:
  • DumpRenderTree/win/GCControllerWin.cpp:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/win/PolicyDelegate.h:
  • DumpRenderTree/win/ResourceLoadDelegate.h:
  • DumpRenderTree/win/UIDelegate.cpp:
  • DumpRenderTree/win/UIDelegate.h:
  • DumpRenderTree/win/WorkQueueItemWin.cpp:
4:16 PM Changeset in webkit [30180] by sfalken@apple.com
  • 122 edits in trunk/WebKit/win

Changes to support merged MIDL output.

All COM interfaces are now generated to WebKit.h.

Reviewed by Sam, Ada.

  • DOMCSSClasses.h:
  • DOMCoreClasses.h:
  • DOMEventsClasses.h:
  • DOMHTMLClasses.h:
  • DefaultDownloadDelegate.h:
  • DefaultPolicyDelegate.cpp:
  • DefaultPolicyDelegate.h:
  • GEN_DOMObject.h:
  • Interfaces/DOMCSS.idl:
  • Interfaces/DOMCore.idl:
  • Interfaces/DOMEvents.idl:
  • Interfaces/DOMExtensions.idl:
  • Interfaces/DOMHTML.idl:
  • Interfaces/DOMPrivate.idl:
  • Interfaces/DOMRange.idl:
  • Interfaces/DOMWindow.idl:
  • Interfaces/IGEN_DOMObject.idl:
  • Interfaces/IWebArchive.idl:
  • Interfaces/IWebBackForwardList.idl:
  • Interfaces/IWebBackForwardListPrivate.idl:
  • Interfaces/IWebCache.idl:
  • Interfaces/IWebDataSource.idl:
  • Interfaces/IWebDatabaseManager.idl:
  • Interfaces/IWebDocument.idl:
  • Interfaces/IWebDownload.idl:
  • Interfaces/IWebEditingDelegate.idl:
  • Interfaces/IWebError.idl:
  • Interfaces/IWebErrorPrivate.idl:
  • Interfaces/IWebFormDelegate.idl:
  • Interfaces/IWebFrame.idl:
  • Interfaces/IWebFrameLoadDelegate.idl:
  • Interfaces/IWebFrameLoadDelegatePrivate.idl:
  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/IWebFrameView.idl:
  • Interfaces/IWebHTMLRepresentation.idl:
  • Interfaces/IWebHTTPURLResponse.idl:
  • Interfaces/IWebHistory.idl:
  • Interfaces/IWebHistoryItem.idl:
  • Interfaces/IWebHistoryItemPrivate.idl:
  • Interfaces/IWebIconDatabase.idl:
  • Interfaces/IWebInspector.idl:
  • Interfaces/IWebJavaScriptCollector.idl:
  • Interfaces/IWebKitStatistics.idl:
  • Interfaces/IWebMutableURLRequest.idl:
  • Interfaces/IWebMutableURLRequestPrivate.idl:
  • Interfaces/IWebNotification.idl:
  • Interfaces/IWebNotificationCenter.idl:
  • Interfaces/IWebNotificationObserver.idl:
  • Interfaces/IWebPolicyDelegate.idl:
  • Interfaces/IWebPreferences.idl:
  • Interfaces/IWebPreferencesPrivate.idl:
  • Interfaces/IWebResource.idl:
  • Interfaces/IWebResourceLoadDelegate.idl:
  • Interfaces/IWebResourceLoadDelegatePrivate.idl:
  • Interfaces/IWebScriptCallFrame.idl:
  • Interfaces/IWebScriptDebugListener.idl:
  • Interfaces/IWebScriptDebugServer.idl:
  • Interfaces/IWebScriptObject.idl:
  • Interfaces/IWebScriptScope.idl:
  • Interfaces/IWebScrollBarDelegatePrivate.idl:
  • Interfaces/IWebScrollBarPrivate.idl:
  • Interfaces/IWebSecurityOrigin.idl:
  • Interfaces/IWebTextRenderer.idl:
  • Interfaces/IWebUIDelegate.idl:
  • Interfaces/IWebUIDelegatePrivate.idl:
  • Interfaces/IWebURLAuthenticationChallenge.idl:
  • Interfaces/IWebURLRequest.idl:
  • Interfaces/IWebURLResponse.idl:
  • Interfaces/IWebURLResponsePrivate.idl:
  • Interfaces/IWebUndoManager.idl:
  • Interfaces/IWebUndoTarget.idl:
  • Interfaces/IWebView.idl:
  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebActionPropertyBag.cpp:
  • WebBackForwardList.h:
  • WebCache.h:
  • WebDataSource.cpp:
  • WebDataSource.h:
  • WebDatabaseManager.h:
  • WebDownload.h:
  • WebEditorClient.cpp:
  • WebEditorClient.h:
  • WebError.h:
  • WebFrame.cpp:
  • WebFrame.h:
  • WebFramePolicyListener.h:
  • WebHTMLRepresentation.cpp:
  • WebHTMLRepresentation.h:
  • WebHistory.cpp:
  • WebHistory.h:
  • WebHistoryItem.h:
  • WebIconDatabase.h:
  • WebInspector.h:
  • WebJavaScriptCollector.h:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKitDLL.cpp:
  • WebKitStatistics.h:
  • WebMutableURLRequest.cpp:
  • WebMutableURLRequest.h:
  • WebNotification.h:
  • WebNotificationCenter.h:
  • WebPreferences.h:
  • WebResource.h:
  • WebScriptCallFrame.h:
  • WebScriptDebugServer.cpp:
  • WebScriptDebugServer.h:
  • WebScriptDebugger.cpp:
  • WebScriptDebugger.h:
  • WebScriptObject.h:
  • WebScrollBar.h:
  • WebSecurityOrigin.h:
  • WebTextRenderer.h:
  • WebURLAuthenticationChallenge.h:
  • WebURLAuthenticationChallengeSender.h:
  • WebURLCredential.h:
  • WebURLProtectionSpace.h:
  • WebURLResponse.h:
  • WebView.cpp:
  • WebView.h:
3:54 PM Changeset in webkit [30179] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Revised the system fallback font lookup logic to use MLang font linking
again. To avoid reintroducing bug 16548 and <rdar://problem/5280188>,
for CJK characters, try linking based on a single code page at a time,
starting with the user's default code page (if it is one of the CJK
code pages) followed by the other CJK code pages in a prescribed order
that matches what Firefox does.

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::getCJKCodePageMasks): Added. Returns the search order for CJK code pages, with the user's default code page first. (WebCore::currentFontContainsCharacter): Factored out of getFontDataForCharacters(). (WebCore::createMLangFont): Ditto. (WebCore::FontCache::getFontDataForCharacters):
3:34 PM Changeset in webkit [30178] by andersca@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Adam.

Implement imageTitle.


  • WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):
1:29 PM Changeset in webkit [30177] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Brady Eidson.

<rdar://problem/5659216> REGRESSION: PLT 0.3% slower due to r28868 (caching ClassNodeList and NamedNodeList)

  • Tweak the statements in isASCIISpace to account for the statistical distribution of usage in the PLT.

.4% speedup on my machine. Stephanie's machine shows this as .3% speedup.

  • wtf/ASCIICType.h: (WTF::isASCIISpace):
1:17 PM Changeset in webkit [30176] by mitz@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Rubber-stamped by Adam Roben.

  • make fast/css/css3-nth-child pass
  • fast/css/css3-nth-child.html: Removed spaces that were making the :nth-child selector fail to parse because of <rdar://problem/5733761>.
  • platform/mac-leopard/fast/css/css3-nth-child-expected.checksum: Added.
  • platform/mac-leopard/fast/css/css3-nth-child-expected.png: Added.
1:04 PM Changeset in webkit [30175] by alp@webkit.org
  • 5 edits in trunk

2008-02-12 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Alp Toker.

Add -DMAEMO_CHANGES when the hildon CONFIG option is specified
Add hildon-1 to PKGCONFIG when hildon CONFIG option is specified

12:13 PM Changeset in webkit [30174] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

  • <rdar://problem/5738175> Remove workaround for <rdar://problem/5539388> from post-Tiger builds
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow):
12:11 PM Changeset in webkit [30173] by beidson@apple.com
  • 2 edits in trunk/WebCore

Release build fix

  • storage/DatabaseTask.cpp:
11:37 AM Changeset in webkit [30172] by ap@webkit.org
  • 13 edits
    3 adds in trunk/WebCore

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=17177
<rdar://problem/5729619> Storage tasks are getting lost

<rdar://problem/5729445> REGRESSION: Cannot schedule more than one transaction at a time

<rdar://problem/5729446> Major thread safety issue in Database code

  • platform/MessageQueue.h: Added a thread-safe queue abstraction.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added MessageQueue.h.
  • dom/Document.cpp: (WebCore::Document::~Document): Fixed a race condition resulting in a hanging reference.
  • storage/Database.idl: Fixed parameter declarations to actually match implementation (which is custom, so it got out of sync).
  • storage/DatabaseTask.h: (WebCore::DatabaseTask::database): (WebCore::DatabaseTransactionTask::transaction): Changed tasks to hold more information internally. Added helpers for better debug logging.
  • storage/DatabaseTask.cpp: (WebCore::DatabaseTask::DatabaseTask): (WebCore::DatabaseTask::performTask): (WebCore::DatabaseOpenTask::DatabaseOpenTask): (WebCore::DatabaseOpenTask::doPerformTask): (WebCore::DatabaseOpenTask::debugTaskName): (WebCore::DatabaseTransactionTask::DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::~DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::doPerformTask): (WebCore::DatabaseTransactionTask::debugTaskName): (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): (WebCore::DatabaseTableNamesTask::doPerformTask): (WebCore::DatabaseTableNamesTask::debugTaskName): Implementation for the above.

(WebCore::DatabaseTask::lockForSynchronousScheduling):
(WebCore::DatabaseTask::waitForSynchronousCompletion):
Fixed a potential race condition: if the task completed before we entered a wait, we'd never
wake up. There was an assertion guarding against this, but no actual guarantee that I could see.

  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::requestTermination): (WebCore::DatabaseThread::databaseThread): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask): (WebCore::DatabaseThread::unscheduleDatabaseTasks):
  • storage/DatabaseThread.h: Changed to use MessageQueue.
  • storage/Database.cpp: (WebCore::guidMutex): (WebCore::guidToVersionMap): (WebCore::guidToDatabaseMap): (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::openAndVerifyVersion): (WebCore::guidForOriginAndName): (WebCore::Database::changeVersion): (WebCore::Database::transaction): (WebCore::Database::scheduleTransaction): (WebCore::Database::scheduleTransactionStep): (WebCore::Database::scheduleTransactionCallback): (WebCore::Database::version): (WebCore::Database::deliverPendingCallback): (WebCore::Database::tableNames):
  • storage/Database.h: Changed m_transactionQueue to a MessageQueue. Got rid of callback tracking - these can take care of themselves. Got rid of a DatabaseThread member, as the Document can be asked for it. Moved private static members and helpers out of the header. Lost CurrentThreadSetter debug helper on the way. We may need to re-add something like that later.
  • storage/SQLTransaction.h:
  • storage/SQLTransaction.cpp: Added a lot of debug logging. (WebCore::SQLTransaction::scheduleToRunStatements): Removed "m_currentStatement = 0" assignment, as it created a race condition. Everything seems to work better without it, although a real fix would be to get rid of this variable - it's evil shared data that isn't even protected in any way.
  • manual-tests/database-threading-stress-test-2.html: Added.
  • manual-tests/database-threading-stress-test.html: Added.
11:29 AM Changeset in webkit [30171] by Adam Roben
  • 3 edits
    3 adds in trunk

Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows

WebCore:

Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows

<​http://bugs.webkit.org/show_bug.cgi?id=17328>
<rdar://5737946>

Reviewed by Mitz.

Test: fast/loader/local-css-allowed-in-strict-mode.html

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Add a case for .css files.

LayoutTests:

Add a test for Bug 17328: REGRESSION (r30147): Inspector is unstyled
on Windows

<​http://bugs.webkit.org/show_bug.cgi?id=17328>
<rdar://5737946>

Reviewed by Mitz.

  • fast/loader/local-css-allowed-in-strict-mode-expected.txt: Added.
  • fast/loader/local-css-allowed-in-strict-mode.html: Added.
  • fast/loader/resources/stylesheet.css: Added.
11:17 AM Changeset in webkit [30170] by andersca@apple.com
  • 2 edits in trunk/WebCore

Build fix.


  • loader/ImageDocument.cpp:
10:53 AM Changeset in webkit [30169] by andersca@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Fix tyop.

10:51 AM Changeset in webkit [30168] by andersca@apple.com
  • 15 edits
    2 deletes in trunk

WebCore:

Reviewed by Mitz.

Make the code that sets the image title cross platform.

  • WebCore.xcodeproj/project.pbxproj: Remove ImageDocumentMac.


  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):
  • loader/mac/ImageDocumentMac.h: Removed.
  • loader/mac/ImageDocumentMac.mm: Removed.


  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreViewFactory.h: Move imageTitleForFilename:size from the bridge to the view factory.


  • platform/LocalizedStrings.h: Add imageTitle.


  • platform/mac/LocalizedStringsMac.mm: (WebCore::imageTitle): Have imageTitle call the view factory.


  • platform/qt/Localizations.cpp: (WebCore::imageTitle):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::imageTitle):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::imageTitle): Add stubs.

WebKit/mac:

Reviewed by Mitz.

  • WebCoreSupport/WebFrameBridge.mm:
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory imageTitleForFilename:size:]): Move implementatino from WebFrameBridge to WebViewFactory.

WebKit/win:

Reviewed by Mitz.

  • WebCoreLocalizedStrings.cpp: (WebCore::imageTitle): Add stub.
5:23 AM Changeset in webkit [30167] by Nikolas Zimmermann
  • 1 edit
    31 adds in trunk/LayoutTests

Not reviewed, adding missing layout test results (that have been r+ already, but not commited)

1:40 AM Changeset in webkit [30166] by oliver@apple.com
  • 2 edits in trunk/WebCore

more Qt fixes

1:30 AM Changeset in webkit [30165] by oliver@apple.com
  • 2 edits in trunk/WebCore

Yet another attempt to fix Qt

1:21 AM Changeset in webkit [30164] by oliver@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix qt build

1:14 AM Changeset in webkit [30163] by oliver@apple.com
  • 4 edits in trunk/WebCore

Make canvas use an ImageBuffer for its backing store

Reviewed by Alp Toker.

In order to make the canvas implementation less platform dependent
(and thus reduce the current quagmire of ifdefs) we now use an
ImageBuffer to provide the backing buffer, an immediate consequence
of this is to remove multiple ifdefs in the construction of the
buffer. This patch allows us to further reduce the platform
dependencies in later patches.

Feb 11, 2008:

10:02 PM Changeset in webkit [30162] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/css/last-child-style-sharing.html

  • css/CSSGrammar.y: Changed to call setUsesSiblingRules(true) for all CSS3 selectors that require it.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/css/last-child-style-sharing.html: Added.
  • platform/mac/fast/css/last-child-style-sharing-expected.checksum: Added.
  • platform/mac/fast/css/last-child-style-sharing-expected.png: Added.
  • platform/mac/fast/css/last-child-style-sharing-expected.txt: Added.
7:02 PM Changeset in webkit [30161] by timothy@apple.com
  • 2 edits
    7 deletes in tags/Safari-5525.8/LayoutTests

Merge the LayoutTests part of r30052.

7:01 PM Changeset in webkit [30160] by timothy@apple.com
  • 3 edits in tags/Safari-5525.8/WebCore

Merge the WebCore part of r30052.

5:31 PM Changeset in webkit [30159] by timothy@apple.com
  • 1 copy in tags/Safari-5525.8

New tag.

5:24 PM Changeset in webkit [30158] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

Reviewed by Anders Carlsson.

Fixes for:
<rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
<rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

  • Expose the native Object.prototype.toString implementation so that it can be used for cross-domain toString calling.
4:26 PM Changeset in webkit [30157] by weinig@apple.com
  • 21 edits
    1 move
    16 adds
    1 delete in trunk

WebCore:

Reviewed by Darin Adler.

Make the cross-domain security model more closely match Firefox by always returning the
native built-in functions when accessing functions cross-domain.

Fixes for:
<rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
<rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

Tests: fast/dom/Window/window-custom-prototype-crash.html

fast/dom/Window/window-function-frame-getter-precedence.html
http/tests/security/cross-frame-access-get-override.html
http/tests/security/cross-frame-access-location-get-override.html
http/tests/security/cross-frame-access-location-get.html
http/tests/security/cross-frame-access-location-put.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • Return the native-built in version of an cross-domain allowed function (eg. window.focus) whether or not it has been overridden, instead of undefined.
  • When doing findEntry lookup, use the the tables directly (JSDOMWindowPrototype::info.propHashTable) instead of calling the virtual classInfo() method to avoid the unnecessary overhead.
  • Allow access to the native toString function cross-domain. It always returns "[object Window]".
  • Use the new nonCachingStaticFunctionGetter when return allowed functions cross-frame so that the function an overridden function is not inadvertantly returned from the PropertyMap.\
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customGetOwnPropertySlot):
  • Implement the same model as described above for the History object, always returning the native built-in function cross-domain.
  • Allow access to the native toString function cross-domain.
  • Clean up the code to make it clear that the custom functionality is only there for cross-domain access.
  • bindings/js/JSLocation.cpp: (WebCore::JSLocation::getOwnPropertySlot):
  • Match the generated classes by moving all the custom logic into a separate customGetOwnPropertySlot function. This will help moving to a generated class in the future. (WebCore::JSLocation::customGetOwnPropertySlot):
  • Implement the same model as described above for the Location object, always returning the native built-in function cross-domain.
  • Clean up the code to make it clear that the custom functionality is only there for cross-domain access. (WebCore::JSLocation::put): (WebCore::JSLocation::deleteProperty): (WebCore::JSLocation::getPropertyNames):
  • bindings/js/JSLocation.h:
  • Clean up to match the rest of the file a little better.
  • bindings/js/kjs_binding.cpp: (WebCore::allowsAccessFromFrame): (WebCore::printErrorMessageForFrame): (WebCore::nonCachingStaticFunctionGetter): (WebCore::objectToStringFunctionGetter):
  • bindings/js/kjs_binding.h:
  • Put common functionality related to cross-domain access here to serve as a central shared point. This includes moving and augmenting the allowsAccessFromFrame method that was in both JSHistoryCustom.cpp and JSLocation.cpp.
  • bindings/js/kjs_dom.cpp: (WebCore::checkNodeSecurity):
  • Use the new allowsAccessFromFrame method.
  • bindings/js/kjs_window.cpp: (KJS::Window::childFrameGetter): Cleanup. (KJS::Window::namedItemGetter): Cleanup. (KJS::Window::getOwnPropertySlot):
  • Do the prototype lookup early to match Firefox in having function lookup have a higher precedence than the index or shortcut name getters.
  • Cleanup function to make it more understandable and slightly more efficient. (KJS::Window::allowsAccessFrom):
  • Add a new variant of this method that takes a reference to a String, which, on failure, will contain the error message to print out. The caller can then pass this to printErrorMessage. This allows for code to check allowsAccessFrom and act on the result without printing out the error message. For convenience, a version with out the String parameter has been left which prints out the message automatically. (KJS::Window::printErrorMessage):
  • bindings/js/kjs_window.h:

LayoutTests:

Reviewed by Darin Adler.

Tests for:
<rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
<rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

  • fast/dom/Window/resources/WindowProperties.js: Added.
  • fast/dom/Window/window-custom-prototype-crash-expected.txt: Added.
  • fast/dom/Window/window-custom-prototype-crash.html: Added.
  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Added.
  • fast/dom/Window/window-function-frame-getter-precedence.html: Added.
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-custom.html:
  • http/tests/security/cross-frame-access-get-override-expected.txt: Added.
  • http/tests/security/cross-frame-access-get-override.html: Added.
  • http/tests/security/cross-frame-access-history-get-override-expected.txt:
  • http/tests/security/cross-frame-access-history-get-override.html:
  • http/tests/security/cross-frame-access-history-put-expected.txt:
  • http/tests/security/cross-frame-access-history-put.html:
  • http/tests/security/cross-frame-access-location-expected.txt: Removed.
  • http/tests/security/cross-frame-access-location-get-expected.txt: Added.
  • http/tests/security/cross-frame-access-location-get-override-expected.txt: Added.
  • http/tests/security/cross-frame-access-location-get-override.html: Added.
  • http/tests/security/cross-frame-access-location-get.html: Copied from http/tests/security/cross-frame-access-location.html.
  • http/tests/security/cross-frame-access-location-put-expected.txt: Added.
  • http/tests/security/cross-frame-access-location-put.html: Added.
  • http/tests/security/cross-frame-access-location.html: Removed.
  • http/tests/security/resources/cross-frame-iframe-for-get-override-test.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-get-test.html:
  • http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
  • http/tests/security/resources/cross-frame-iframe-for-location-get-override-test.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-location-get-test.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-location-put-test.html: Added.
4:16 PM Changeset in webkit [30156] by Darin Adler
  • 8 edits in trunk

WebCore:

Reviewed by Mitz.

  • fix <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Added an Xcode-specific quirk.

  • WebCore.base.exp: Added export for new Settings function.
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Here's the crazy quirk. If you try to change the visibilty on a node with the class name tab_content, instead it will use display:none.
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_needsXcodeVisibilityQuirk. Also initialize m_fontRenderingMode! This seems like it was a bug before, but we probably were getting lucky and always getting 0 on Windows, which is the only place the setting matters. (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Added.
  • page/Settings.h: (WebCore::Settings::needsXcodeVisibilityQuirk): Added.

WebKit/mac:

Reviewed by Mitz.

  • fix <rdar://problem/5726016> REGRESSION: Xcode News window renders incorrectly due to visibility fix

Added an Xcode-specific quirk.

  • Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after" part of the check.
  • WebView/WebView.mm: (-[WebView _needsXcodeVisibilityQuirk]): Added. (-[WebView _preferencesChangedNotification:]): Added a call to setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.
3:38 PM Changeset in webkit [30155] by alp@webkit.org
  • 2 edits in trunk/PlanetWebKit

2008-02-11 Pierre-Luc Beaudoin <​pierre-luc.beaudoin@collabora.co.uk>

Reviewed by Alp Toker.

Add my blog's WebKit category, English only posts.

  • config.ini:
2:54 PM Changeset in webkit [30154] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Brady Eidson.

<rdar://problem/5733069> Many m_quotaMap uses do not hold the m_quotaMapGuard

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::hasEntryForOrigin): Hold m_quotaMapGuard when using m_quotaMap. (WebCore::DatabaseTracker::origins): Ditto. (WebCore::DatabaseTracker::setQuota): Ditto. (WebCore::DatabaseTracker::deleteAllDatabases): Call origins() and itterate over the origins to call deleteOrigin(). (WebCore::DatabaseTracker::deleteOrigin): Hold m_quotaMapGuard when using m_quotaMap.
1:19 PM Changeset in webkit [30153] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

Fix for bug 17286, crash accessing a null RenderStyle. Add a simple null check.

Reviewed by aroben

Added fast/css/empty-generated-content.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
1:04 PM Changeset in webkit [30152] by rwlbuis@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by David Kilzer.

​http://bugs.webkit.org/show_bug.cgi?id=17201
Bug 17201: Use RefPtr in CSSParser::parseFont() to get rid of goto silliness

Gets rid of goto usage in parseFont.

12:26 PM Changeset in webkit [30151] by hyatt@apple.com
  • 1 edit in trunk/WebCore/html/HTMLMediaElement.cpp

Back out accidental checkin to HTMLMediaElement.cpp.

12:22 PM Changeset in webkit [30150] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/forms

Add layout test for bug 16798.

12:21 PM Changeset in webkit [30149] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/forms/button-submit.html

Add layout test for bug 16798.

12:18 PM Changeset in webkit [30148] by hyatt@apple.com
  • 2 adds in trunk/LayoutTests/http/tests/misc
12:17 PM Changeset in webkit [30147] by hyatt@apple.com
  • 15 edits in trunk/WebCore

Fix for bug 17298, Acid3 text should be black and not red. Make sure stylesheets with the wrong MIME type
are not accepted in strict mode.

Reviewed by darin

Added http/tests/misc/css-reject-in-strict-mode.html

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet):
  • css/CSSImportRule.h:
  • dom/Document.cpp: (WebCore::Document::setCSSStyleSheet):
  • dom/Document.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::setCSSStyleSheet):
  • dom/ProcessingInstruction.h:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet):
  • html/HTMLLinkElement.h:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::ref): (WebCore::CachedCSSStyleSheet::checkNotify): (WebCore::CachedCSSStyleSheet::canUseSheet):
  • loader/CachedCSSStyleSheet.h: (WebCore::CachedCSSStyleSheet::sheetText):
  • loader/CachedResourceClient.h: (WebCore::CachedResourceClient::setCSSStyleSheet):
  • loader/mac/UserStyleSheetLoader.cpp: (UserStyleSheetLoader::setCSSStyleSheet):
  • loader/mac/UserStyleSheetLoader.h:
11:58 AM Changeset in webkit [30146] by Adam Roben
  • 3 edits in trunk/WebCore

Fix Bug 14316: Inspector's Console truncates long strings

<​http://bugs.webkit.org/show_bug.cgi?id=14316>
<rdar://5357695>

We no longer call Object.describe to format all the output of commands
enetered into the Console. The ConsolePanel object now has a set of
formatting functions that append a formatted representation of the
passed-in object to the passed-in container node.

Reviewed by Sam.

  • page/inspector/ConsolePanel.js: (WebInspector.ConsolePanel._onEnterPressed): Updated for rename of _outputToNode to _format. (WebInspector.ConsolePanel._format): Renamed from _outputToNode. Use Object.type to get the type of the object, then call the appropriate formatting function. (WebInspector.ConsolePanel._formatvalue): Added. (WebInspector.ConsolePanel._formatstring): Added. This function contains the actual fix for the bug, since it doesn't truncate the string no matter how long it is. (WebInspector.ConsolePanel._formatregexp): Added. (WebInspector.ConsolePanel._formatarray): Added. This is a bit more functional than Object.describe for arrays, since it recursively formats each item in the array. One advantage of this is that Nodes in arrays will be linkified instead of just turning into "[Object HTMLBodyElement]" or similar. (WebInspector.ConsolePanel._formatnode): Added. (WebInspector.ConsolePanel._formatobject): Added. (WebInspector.ConsolePanel.
  • page/inspector/utilities.js: (Object.type): Added. Code was pulled out of Object.describe and reorganized slightly. (Object.describe): Call Object.type. There should be no change in behavior of this function.
10:09 AM Changeset in webkit [30145] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-11 Alp Toker <​alp@atoker.com>

Wx build fix for breakage introduced in r30142. Spotted by Darin.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):
9:44 AM Changeset in webkit [30144] by Adam Roben
  • 2 edits in trunk/PlanetWebKit

Add Brent Fulgham's blog

Rubberstamped by Alp.

  • config.ini:
9:38 AM Changeset in webkit [30143] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed and tweaked by Darin

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Turn off XBMImageDecoder for PLATFORM(WIN) configuration.
  • rendering/RenderThemeWin.cpp: (WebCore::prepareForDrawing): Added IntRect parameter. (WebCore::doneDrawing): Ditto. (WebCore::RenderThemeWin::paintButton): Ditto. (WebCore::RenderThemeWin::paintTextField): Ditto. (WebCore::RenderThemeWin::paintMenuListButton): Ditto. (WebCore::RenderThemeWin::systemFont): Added.
8:56 AM Changeset in webkit [30142] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-11 Alp Toker <​alp@atoker.com>

Reviewed by Alexey.

Acid3 data URL parsing fix for the GTK+ port.

Avoid WebCore's base64Decode() when possible since it's not a
general-purpose Base64 decoder and fails on newlines.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):
7:33 AM Changeset in webkit [30141] by Darin Adler
  • 2 edits in trunk/WebCore
  • another Qt build fix
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu): Added explicit RefCounted constructor.
6:37 AM Nightly Builds edited by ryanfelder@yahoo.com
(diff)
5:21 AM QtWebKitTodo edited by zecke2@selfish.org
Printing was implemented by simon (diff)
5:20 AM QtWebKitTodo edited by zecke2@selfish.org
works here (tm), also popping the window properly up is working (diff)
5:19 AM QtWebKitTodo edited by zecke2@selfish.org
Ben fixed that a while ago (diff)
5:18 AM QtWebKitTodo edited by zecke2@selfish.org
We have something that can be used by Assistant, we want something … (diff)
5:17 AM QtWebKitTodo edited by zecke2@selfish.org
We have the first bits of support for InputMethods (diff)
5:16 AM QtWebKitTodo edited by zecke2@selfish.org
We have this paint signal now (diff)

Feb 10, 2008:

11:40 PM Changeset in webkit [30140] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Rubber stamped by Eric.

  • kjs/ExecState.h: (KJS::ExecState::takeException): Added.
11:38 PM Changeset in webkit [30139] by Darin Adler
  • 2 edits in trunk/WebCore
  • another Qt build fix (wish the Qt bot wouldn't stop on the first error)
  • platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::FileChooser): Added explicit RefCounted constructor.
11:03 PM Changeset in webkit [30138] by Darin Adler
  • 2 edits in trunk/WebCore
  • another Qt fix
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::Icon): Added explicit RefCounted constructor.
10:09 PM Changeset in webkit [30137] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-10 Alp Toker <​alp@atoker.com>

Another Win build fix for r30133 breakage.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::PluginPackage):
9:50 PM Changeset in webkit [30136] by alp@webkit.org
  • 5 edits in trunk/WebCore

2008-02-10 Alp Toker <​alp@atoker.com>

Build fix GTK+ and prospective build fix for Win breakage introduced
in r30133.

  • platform/Cursor.h: (WebCore::SharedCursor::SharedCursor):
  • platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::Icon):
  • platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::FileChooser):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu):
8:17 PM Changeset in webkit [30135] by Darin Adler
  • 7 edits in trunk/WebCore
  • try to fix Win, Qt, GTK, and WX builds
  • platform/Cursor.h: (WebCore::SharedCursor::SharedCursor): Added explicit RefCounted constructor.
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::Icon): Ditto.
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::FileChooser): Ditto.
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Ditto.
  • platform/wx/TemporaryLinkStubs.cpp: (FileChooser::FileChooser): Ditto. (PopupMenu::PopupMenu): Ditto. (Icon::Icon): Ditto.
  • plugins/PluginStream.cpp: (WebCore::PluginStream::PluginStream): Ditto.
7:41 PM Changeset in webkit [30134] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

Reviewed by Sam Weinig and Anders Carlsson.

  • change a test to simply use 'font-family' instead of unnecessary @font-face hackery
  • fast/text/atsui-spacing-features.html:
  • platform/mac/fast/text/atsui-spacing-features-expected.checksum:
  • platform/mac/fast/text/atsui-spacing-features-expected.png:
  • platform/mac/fast/text/atsui-spacing-features-expected.txt:
6:03 PM Changeset in webkit [30133] by Darin Adler
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Eric.

  • wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Remove default of 0.

WebKit/wx:

Reviewed by Eric.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::FrameLoaderClientWx): Set the count to 0 explicitly (one stray client I missed in my last pass).
4:45 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
4:37 PM BuildingCairoOnWindows created by bfulgham@macports.org
3:17 PM Changeset in webkit [30132] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.

  • fix a memory leak
  • DumpRenderTree/cg/ImageDiffCG.cpp: (getDifferenceBitmap): Use a static CFMutableData instead of allocating and leaking the buffer each time.
3:08 PM Changeset in webkit [30131] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/webarchive/archive-empty-frame-dom-expected.txt

Update test results for iframe fix.

2:43 PM WikiStart edited by bfulgham@macports.org
(diff)
2:33 PM Changeset in webkit [30130] by hyatt@apple.com
  • 3 edits in trunk/WebCore

Fix for bug 17082, cssRules should be live.

Reviewed by olliej

Added fast/css/live-cssrules.html

  • css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList): (WebCore::CSSRuleList::length): (WebCore::CSSRuleList::item): (WebCore::CSSRuleList::deleteRule): (WebCore::CSSRuleList::insertRule):
  • css/CSSRuleList.h:
2:31 PM Changeset in webkit [30129] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/css

Add layout test for bug 17082.

2:31 PM Changeset in webkit [30128] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/css/live-cssrules.html

Add layout test for bug 17082.

2:30 PM Changeset in webkit [30127] by hyatt@apple.com
  • 4 edits in trunk/WebCore

Fix for bug 17253. <iframe> contents need to be reflected into the DOM as a single text node.

Reviewed by olliej

fast/frames/iframe-text-contents.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseTag):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::State::inIFrame): (WebCore::HTMLTokenizer::State::setInIFrame): (WebCore::HTMLTokenizer::State::inAnySpecial): (WebCore::HTMLTokenizer::State::needsSpecialWriteHandling): (WebCore::HTMLTokenizer::State::):
2:29 PM Changeset in webkit [30126] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/frames

Add layout tests for 17253.

2:29 PM Changeset in webkit [30125] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/frames/iframe-text-contents.html

Add layout tests for 17253.

1:28 PM Changeset in webkit [30124] by Darin Adler
  • 4 edits
    1 copy in trunk/LayoutTests
  • fix a couple of directories that were using our JavaScript template/wrapper system incorrectly
  • fast/dom/SelectorAPI/resources/TEMPLATE.html: Fixed relative paths.
  • fast/events/event-instanceof.html: Regenerating this file revealed that the path to the stylesheet was wrong. Fixed by running the make-js-test-wrappers script. Didn't affect the text-only results, but the test looked wrong in the browser.
  • fast/events/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
  • traversal/resources/TEMPLATE.html: Fixed relative paths.
12:13 PM Changeset in webkit [30123] by Darin Adler
  • 6 edits in trunk

WebCore:

Reviewed and tweaked by Darin.


DOMRange.surroundContents throws wrong exception (Acid3 bug)
​http://bugs.webkit.org/show_bug.cgi?id=16749


Throw BAD_BOUNDARYPOINTS_ERR if attempting to split a non-text node that
has offsets in characters.

  • dom/Range.cpp: (WebCore::Range::surroundContents):

LayoutTests:

Reviewed and tweaked a bit by Darin.


DOMRange.surroundContents throws wrong exception (Acid3 bug)
​http://bugs.webkit.org/show_bug.cgi?id=16749


Throw BAD_BOUNDARYPOINTS_ERR if attempting to split a non-text node that
has offsets in characters

  • fast/dom/Range/range-exceptions-expected.txt: Added.
  • fast/dom/Range/resources/range-exceptions.js: Added.
11:27 AM Changeset in webkit [30122] by Darin Adler
  • 102 edits in trunk

JavaScriptCore:

Reviewed by Eric.

  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass):
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::RootObject):

WebCore:

Reviewed by Eric.

  • bindings/js/JSSVGPODTypeWrapper.h: (WebCore::JSSVGPODTypeWrapper::JSSVGPODTypeWrapper):
  • css/CSSFontFace.h: (WebCore::CSSFontFace::CSSFontFace):
  • css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList):
  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
  • css/Counter.h: (WebCore::Counter::Counter):
  • css/Pair.h: (WebCore::Pair::Pair):
  • css/Rect.h: (WebCore::Rect::Rect):
  • css/StyleBase.h: (WebCore::StyleBase::StyleBase):
  • css/StyleSheetList.cpp: (WebCore::StyleSheetList::StyleSheetList):
  • dom/Attr.cpp: (WebCore::Attr::Attr):
  • dom/Attr.h:
  • dom/Attribute.h: (WebCore::Attribute::Attribute):
  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):
  • dom/DOMImplementation.h: (WebCore::DOMImplementation::DOMImplementation):
  • dom/Event.cpp: (WebCore::Event::Event):
  • dom/EventListener.h: (WebCore::EventListener::EventListener):
  • dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::insertAttribute):
  • dom/NamedNodeMap.h: (WebCore::NamedNodeMap::NamedNodeMap):
  • dom/NodeFilter.h: (WebCore::NodeFilter::NodeFilter):
  • dom/NodeFilterCondition.h: (WebCore::NodeFilterCondition::NodeFilterCondition):
  • dom/NodeList.h: (WebCore::NodeList::NodeList):
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): (WebCore::QualifiedName::ref):
  • dom/Range.cpp: (WebCore::Range::Range):
  • dom/RegisteredEventListener.cpp: (WebCore::RegisteredEventListener::RegisteredEventListener):
  • dom/StyledElement.h:
  • dom/Traversal.cpp: (WebCore::Traversal::Traversal):
  • editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand):
  • history/BackForwardList.cpp: (WebCore::BackForwardList::BackForwardList):
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient):
  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection):
  • html/MediaError.h: (WebCore::MediaError::MediaError):
  • html/TimeRanges.cpp: (TimeRanges::TimeRanges):
  • html/TimeRanges.h: (WebCore::TimeRanges::TimeRanges):
  • html/VoidCallback.h: (WebCore::VoidCallback::VoidCallback):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/FormState.cpp: (WebCore::FormState::FormState):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader):
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder):
  • loader/icon/IconRecord.cpp: (WebCore::IconRecord::IconRecord):
  • page/BarInfo.cpp: (WebCore::BarInfo::BarInfo):
  • page/Console.cpp: (WebCore::Console::Console):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::DOMSelection):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow):
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/History.cpp: (WebCore::History::History):
  • page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
  • page/Plugin.h: (WebCore::Plugin::Plugin):
  • page/Screen.cpp: (WebCore::Screen::Screen):
  • platform/ArrayImpl.cpp: (WebCore::ArrayImpl::ArrayPrivate::ArrayPrivate):
  • platform/DeprecatedValueListImpl.cpp: (WebCore::DeprecatedValueListImpl::Private::Private):
  • platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer):
  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList):
  • platform/graphics/FontFamily.cpp: (WebCore::FontFamily::FontFamily):
  • platform/graphics/FontFamily.h: (WebCore::FontFamily::FontFamily):
  • platform/graphics/FontSelector.h: (WebCore::FontSelector::FontSelector): (WebCore::FontSelector::~FontSelector):
  • platform/graphics/GlyphPageTreeNode.h: (WebCore::GlyphPage::GlyphPage):
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::Icon):
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu):
  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::SharedBuffer):
  • platform/network/FormData.cpp: (WebCore::FormData::FormData):
  • platform/network/FormData.h: (WebCore::FormData::FormData):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle):
  • platform/text/CString.h: (WebCore::CStringBuffer::CStringBuffer):
  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::Private):
  • rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData): (WebCore::StyleBoxData::StyleBoxData): (WebCore::StyleVisualData::StyleVisualData): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleMarqueeData::StyleMarqueeData): (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleTransformData::StyleTransformData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleInheritedData::StyleInheritedData):
  • rendering/RenderStyle.h: (WebCore::TransformOperation::TransformOperation): (WebCore::CursorList::CursorList):
  • rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGCharOnPath::SVGCharOnPath):
  • rendering/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle):
  • rendering/SVGRenderStyle.h: (WebCore::SVGRenderStyle::SVGRenderStyle):
  • rendering/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleTextData::StyleTextData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
  • storage/SQLResultSetRowList.h: (WebCore::SQLResultSetRowList::SQLResultSetRowList):
  • svg/SVGAngle.cpp: (WebCore::SVGAngle::SVGAngle):
  • svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate):
  • svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::SVGElementInstanceList):
  • svg/SVGList.h: (WebCore::SVGList::SVGList): (WebCore::SVGPODListItem::SVGPODListItem):
  • svg/SVGPathSeg.h: (WebCore::SVGPathSeg::SVGPathSeg):
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
  • svg/SVGRenderingIntent.h: (WebCore::SVGRenderingIntent::SVGRenderingIntent):
  • svg/SVGUnitTypes.h: (WebCore::SVGUnitTypes::SVGUnitTypes):
  • svg/graphics/SVGPaintServerGradient.h: (WebCore::SVGPaintServerGradient::SharedStopCache::SharedStopCache):
  • svg/graphics/SVGResource.cpp: (WebCore::SVGResource::SVGResource):
  • xml/DOMParser.h: (WebCore::DOMParser::DOMParser):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest):
  • xml/XMLSerializer.h: (WebCore::XMLSerializer::XMLSerializer):
  • xml/XPathEvaluator.h: (WebCore::XPathEvaluator::XPathEvaluator):
  • xml/XPathExpression.h: (WebCore::XPathExpression::XPathExpression):
  • xml/XPathNSResolver.h: (WebCore::XPathNSResolver::XPathNSResolver):
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
  • xml/XPathValue.h: (WebCore::XPath::ValueData::ValueData):
  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::XSLTProcessor):
11:02 AM Changeset in webkit [30121] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Don't call select() for CURL when there are no valid file descriptors.
​http://bugs.webkit.org/show_bug.cgi?id=17178

10:57 AM Changeset in webkit [30120] by Darin Adler
  • 2 edits in trunk/WebKit/mac
  • WebView/WebView.mm: (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Fix wrong variable name. Doh!

Feb 9, 2008:

11:00 PM Changeset in webkit [30119] by Darin Adler
  • 2 edits in trunk/WebKit/mac

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5725996> crash every time you open the Xcode documentation window
  • WebView/WebView.mm: (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the garbage collector's Objective C++ support by not initializing a static to an object that needs to be marked when running under GC.
10:40 PM S60Webkit edited by kennykaiyinyu@gmail.com
(diff)
10:08 PM S60Webkit edited by kennykaiyinyu@gmail.com
(diff)
10:05 PM S60Webkit edited by kennykaiyinyu@gmail.com
(diff)
9:56 PM S60ConfigureComputer edited by kennykaiyinyu@gmail.com
(diff)
9:49 PM S60ConfigureComputer edited by kennykaiyinyu@gmail.com
(diff)
9:48 PM S60ConfigureComputer edited by kennykaiyinyu@gmail.com
(diff)
9:48 PM S60ConfigureComputer edited by kennykaiyinyu@gmail.com
(diff)
9:43 PM S60IDE edited by kennykaiyinyu@gmail.com
(diff)
8:52 PM Changeset in webkit [30118] by alp@webkit.org
  • 2 edits in trunk/PlanetWebKit

2008-02-09 Alp Toker <​alp@atoker.com>

Only syndicate Jan's WebKit posts, not his entire blog.

  • config.ini:
4:16 PM Changeset in webkit [30117] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • dom/Element.cpp: (WebCore::Element::recalcStyle): Removed unneeded null checks. styleForElement() can never return null.
3:47 PM Changeset in webkit [30116] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Fix for bug 17254, nth-* selectors do not work with negative coefficients.

Reviewed by Mitz.

fast/css/negative-nth-child.html

  • css/CSSStyleSelector.cpp: (WebCore::parseNth):

LayoutTests:

Added test for bug 17254.

Reviewed by Mitz.

  • fast/css/negative-nth-child.html: Added.
2:56 PM Changeset in webkit [30115] by hyatt@apple.com
  • 1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

The comedy continues. Bungled the rename from Eric's review when doing the backout of CSSStyleSelector's accidental fix for 17254.

2:54 PM Changeset in webkit [30114] by hyatt@apple.com
  • 4 edits in trunk/WebCore/rendering

Followup to 17203. Missed a directory.

2:51 PM Changeset in webkit [30113] by hyatt@apple.com
  • 1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

Back out accidental change to CSSStyleSelector.cpp.

2:49 PM Changeset in webkit [30112] by hyatt@apple.com
  • 70 edits in trunk/WebCore

Fix for bug 17203, high CPU usage loading HTML5 spec. This patch significantly improves the performance
of CSS3 selectors.

(1) Split the notion of being affected by positional rules into "forward" and "backward." The "forward"
selectors do not need to re-resolve during parsing, since children are appended on the end. Only the
"backward" selectors like last-child or nth-last-child have to re-resolve when a close tag is encountered.

(2) Extend childrenChanged to specify whether the children were changed by the parser or not. This allows
Element::childrenChanged to know when the parser is adding children so that it can ignore those adds when
possible.

(3) Make sure all Elements now know whether or not their children are currently parsing. Backwards selectors
like last-child will always return false when children are still being parsed. When an Element finishes
parsing its children, finishParsingChildren() gets called and will make sure the children re-resolve properly.

(4) Added a beginParsingChildren method and renamed finishParsing to finishedParsingChildren.

(5) Eliminated one-off hacks that did the same thing in HTMLObjectElement and HTMLAppletElement.

(6) Patched many incorrect implementations of finishedParsingChildren that did not properly call into their
base class (mostly new SVG elements that got added for SVG fonts around the time this became a requirement).

Reviewed by Eric

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector):
  • dom/Attr.cpp: (WebCore::Attr::childrenChanged):
  • dom/Attr.h:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChild):
  • dom/Document.cpp: (WebCore::Document::childrenChanged):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::Element): (WebCore::Element::recalcStyle): (WebCore::checkFirstChildRules): (WebCore::checkLastChildRules): (WebCore::checkEmptyRules): (WebCore::checkStyleRules): (WebCore::Element::childrenChanged): (WebCore::Element::finishParsingChildren):
  • dom/Element.h: (WebCore::Element::finishedParsingChildren): (WebCore::Element::beginParsingChildren):
  • dom/Node.cpp:
  • dom/Node.h: (WebCore::Node::finishParsingChildren): (WebCore::Node::beginParsingChildren): (WebCore::Node::childrenChanged):
  • dom/StyledElement.cpp: (WebCore::StyledElement::StyledElement):
  • dom/StyledElement.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::endElementNs): (WebCore::):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::HTMLAppletElement): (WebCore::HTMLAppletElement::finishParsingChildren):
  • html/HTMLAppletElement.h:
  • html/HTMLElementFactory.cpp: (WebCore::objectConstructor):
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLFormControlElementWithState::finishParsingChildren):
  • html/HTMLGenericFormElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::finishParsingChildren): (WebCore::HTMLObjectElement::childrenChanged):
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::childrenChanged):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged):
  • html/HTMLOptionElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popOneBlockCommon):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::childrenChanged): (WebCore::HTMLScriptElement::finishParsingChildren):
  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::childrenChanged):
  • html/HTMLSelectElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::finishParsingChildren): (WebCore::HTMLStyleElement::childrenChanged):
  • html/HTMLStyleElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::childrenChanged):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::childrenChanged):
  • html/HTMLTitleElement.h:
    • rendering/RenderApplet.cpp:

(WebCore::RenderApplet::createWidgetIfNecessary):

  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::childrenAffectedByForwardPositionalRules): (WebCore::RenderStyle::setChildrenAffectedByForwardPositionalRules): (WebCore::RenderStyle::childrenAffectedByBackwardPositionalRules): (WebCore::RenderStyle::setChildrenAffectedByBackwardPositionalRules):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::finishParsingChildren):
  • svg/SVGAnimationElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::childrenChanged):
  • svg/SVGClipPathElement.h:
  • svg/SVGDefinitionSrcElement.cpp: (WebCore::SVGDefinitionSrcElement::childrenChanged):
  • svg/SVGDefinitionSrcElement.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::finishParsingChildren):
  • svg/SVGElement.h:
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::childrenChanged):
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::childrenChanged):
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::childrenChanged):
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::childrenChanged):
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::childrenChanged):
  • svg/SVGGElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::childrenChanged):
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::childrenChanged):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::childrenChanged):
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::childrenChanged):
  • svg/SVGPatternElement.h:
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::finishParsingChildren): (WebCore::SVGStyleElement::childrenChanged):
  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::childrenChanged):
  • svg/SVGStyledElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::childrenChanged):
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::childrenChanged):
  • svg/SVGUseElement.h:
2:38 PM Changeset in webkit [30111] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-02-09 Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

Unreviewed build fix

Somehow the removal of adjustSliderThumbSize(RenderObject*) sneaked
into the patch.

  • platform/qt/RenderThemeQt.h:
2:16 PM Changeset in webkit [30110] by zecke@webkit.org
  • 5 edits in trunk/WebCore

2008-02-09 Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

Reviewed by Adele.

paintResizeControl is dead, remove the code. This painting
is done by the RenderLayer.

  • platform/qt/RenderThemeQt.cpp:
  • platform/qt/RenderThemeQt.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:
10:09 AM Changeset in webkit [30109] by Darin Adler
  • 6 edits in trunk/JavaScriptCore

Reviewed by Mitz.

We'll want to do this to every RefCounted class, one at a time.

  • kjs/nodes.h: (KJS::RegExpNode::RegExpNode): Use RegExp::create instead of new RegExp.
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Marked inline, set initial ref count to 1. (KJS::RegExp::create): Added. Calls new RegExp then adopts the initial ref.
  • kjs/regexp.h: Reformatted. Made the constructors private. Added static create functions that return objects already wrapped in PassRefPtr.
  • kjs/regexp_object.cpp: (KJS::regExpProtoFuncCompile): Use RegExp::create instead of new RegExp. (KJS::RegExpObjectImp::construct): Ditto.
  • kjs/string_object.cpp: (KJS::stringProtoFuncMatch): Ditto. (KJS::stringProtoFuncSearch): Ditto.
2:45 AM ApplicationsGtk edited by alp@atoker.com
Add the Vala language binding (diff)
12:13 AM Changeset in webkit [30108] by kevino@webkit.org
  • 3 edits in trunk/WebCore

MSVC7 fixes.
​http://bugs.webkit.org/show_bug.cgi?id=17211

Feb 8, 2008:

10:47 PM Changeset in webkit [30107] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2008-02-08 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

Bug 17226: Fix Windows (Cairo) build of image-decoders
​http://bugs.webkit.org/show_bug.cgi?id=17226

  • platform/image-decoders/gif/GIFImageDecoder.cpp:
  • platform/image-decoders/png/PNGImageDecoder.cpp:
9:44 PM Changeset in webkit [30106] by alp@webkit.org
  • 2 edits in trunk

2008-02-08 Alp Toker <​alp@atoker.com>

Rubber-stamped by Maciej.

Bump autoconf CAIRO_REQUIRED_VERSION up to 1.4.

  • configure.ac:
9:17 PM Changeset in webkit [30105] by oliver@apple.com
  • 6 edits in trunk

<rdar://problem/5731773> REGRESSION (r28973): Extraneous parentheses in function.toString()
​https://bugs.webkit.org/show_bug.cgi?id=17214

Reviewed by Maciej

Make a subclass of CommaNode to provide the correct precedence for each expression in
a variable declaration list.

8:15 PM Changeset in webkit [30104] by timothy@apple.com
  • 8 edits in trunk/WebCore

Reviewed by Brady Eidson.

<rdar://problem/5640896> Removing database then trying
to recreate it causes trouble

Added open Database support to DatabaseTracker. So any Database that
is deleted will be marked as deleted and will fail to open any transaction
or execute any new SQL queries.

  • storage/Database.cpp: (WebCore::Database::Database): Call DatabaseTracker::addOpenDatabase. (WebCore::Database::~Database): Call DatabaseTracker::removeOpenDatabase. (WebCore::Database::markAsDeleted): Set the m_deleted flag. (WebCore::Database::version): Return a null String if m_deleted is true.
  • storage/Database.h: (WebCore::Database::deleted): Return m_deleted.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::addOpenDatabase): Add the Database to a map of origins and names. (WebCore::DatabaseTracker::removeOpenDatabase): Remove the Database from the map. (WebCore::DatabaseTracker::deleteDatabaseFile): Call markAsDeleted on all the open Databases matching the origin/name.
  • storage/DatabaseTracker.h:
  • storage/SQLStatement.cpp: (WebCore::SQLStatement::setDatabaseDeletedError): Set the error about the user deleting the database.
  • storage/SQLStatement.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL): If the Database is deleted, call setDatabaseDeletedError. (WebCore::SQLTransaction::openTransactionAndPreflight): Set the error about the user deleting the database if the Database was marked as deleted.
5:13 PM Changeset in webkit [30103] by Darin Adler
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Oliver.

Test: fast/js/continue-break-multiple-labels.html

  • kjs/nodes.h: (KJS::StatementNode::pushLabel): Made this virtual. (KJS::LabelNode::pushLabel): Forward pushLabel calls to the statement inside.

LayoutTests:

  • fast/js/continue-break-multiple-labels-expected.txt: Added.
  • fast/js/continue-break-multiple-labels.html: Added.
5:06 PM Changeset in webkit [30102] by Darin Adler
  • 7 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Eric.

Test: fast/js/constructor-attributes.html

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Remove unwanted attributes from "constructor".
  • kjs/function_object.cpp: (KJS::FunctionObjectImp::construct): Ditto.
  • kjs/nodes.cpp: (KJS::FuncDeclNode::makeFunction): Ditto. (KJS::FuncExprNode::evaluate): Ditto.

WebCore:

Reviewed by Eric.

Test: fast/js/constructor-attributes.html

  • bindings/scripts/CodeGeneratorJS.pm: Remove unwanted attributes from "constructor".

LayoutTests:

Reviewed by Eric.

  • fast/js/constructor-attributes-expected.txt: Added.
  • fast/js/constructor-attributes.html: Added.
  • fast/js/resources/constructor-attributes.js: Added.
4:07 PM Changeset in webkit [30101] by andersca@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Mitz.

<rdar://problem/5650446>
​http://bugs.webkit.org/show_bug.cgi?id=16102
Crash in FrameLoader::stopLoadingSubframes() on IMDB page

Store the child frame in a RefPtr to prevent it from being deleted when the
frame tree changes while calling stopAllLoaders().


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoadingSubframes):

LayoutTests:

Reviewed by Mitz.

<rdar://problem/5650446>
​http://bugs.webkit.org/show_bug.cgi?id=16102
Crash in FrameLoader::stopLoadingSubframes() on IMDB page

  • http/tests/navigation/changing-frame-hierarchy-in-onload-expected.txt: Added.
  • http/tests/navigation/changing-frame-hierarchy-in-onload.html: Added.
3:35 PM Changeset in webkit [30100] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx port build fix.

3:06 PM Changeset in webkit [30099] by alp@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog entry tweak: crasher affects debug, not release builds

3:04 PM Changeset in webkit [30098] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-08 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

Avoid null-dereference crasher noticed in the GTK+ port and also
affecting the Win release build.

Covered by existing tests.

  • dom/Document.cpp: (WebCore::Document::userStyleSheet):
2:44 PM Changeset in webkit [30097] by andersca@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5724188>
REGRESSION: PLT 0.7% slower due to 29926 (change Text::createWithLengthLimit to take a UChar pointer)


Revert r29926 which caused the regression.


  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
  • dom/Text.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
12:05 PM Changeset in webkit [30096] by weinig@apple.com
  • 4 edits
    1 copy
    4 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5732491>
​http://bugs.webkit.org/show_bug.cgi?id=17213
The querySelectorAll method on an element node does not search only the element's descendants

Test: fast/dom/SelectorAPI/elementRoot.html

  • dom/Node.cpp: (WebCore::Node::querySelector): Make sure to stay within the root node when traversing the tree.
  • dom/SelectorNodeList.cpp: (WebCore::SelectorNodeList::SelectorNodeList): ditto.

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5732491>
​http://bugs.webkit.org/show_bug.cgi?id=17213
The querySelectorAll method on an element node does not search only the element's descendants

  • fast/dom/SelectorAPI/elementRoot-expected.txt: Added.
  • fast/dom/SelectorAPI/elementRoot.html: Added.
  • fast/dom/SelectorAPI/resources: Added.
  • fast/dom/SelectorAPI/resources/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
  • fast/dom/SelectorAPI/resources/elementRoot.js: Added.
11:23 AM Changeset in webkit [30095] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for bug 16798, button should default to type=submit.

Reviewed by darin

  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::type): (WebCore::HTMLButtonElement::parseMappedAttribute):
8:51 AM Changeset in webkit [30094] by Adam Roben
  • 2 edits in trunk/WebKitSite
  • perf/slickspeed/config.ini: Fixed version number.
8:47 AM Changeset in webkit [30093] by Adam Roben
  • 2 edits
    1 move in trunk/WebKitSite

Update jQuery to v1.2.3

Rubberstamped by Mitz.

  • perf/slickspeed/config.ini:
  • perf/slickspeed/frameworks/jquery-1.2.3.js: Renamed from WebKitSite/perf/slickspeed/frameworks/jquery-1.2.1.js.
8:24 AM Changeset in webkit [30092] by Adam Roben
  • 6 edits in trunk/WebCore

2008-02-08 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Jon Honeycutt.

Redefine some platform-specific types as cross-platform types
Add pathGetFileName method to get the filename from a path string
Add unloadModule method to unload a loadable module from the process
Implement new methods for GTK+ and Windows
Implement missing homeDirectoryPath method for GTK+
Add stub methods for new and missing methods for Wx and Qt

  • platform/FileSystem.h:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/qt/FileSystemQt.cpp:
  • platform/win/FileSystemWin.cpp:
  • platform/wx/FileSystemWx.cpp:
8:08 AM Changeset in webkit [30091] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix after r30088

  • bindings/scripts/CodeGeneratorCOM.pm: Touch this to force the COM bindings to rebuild.
2:41 AM Changeset in webkit [30090] by alp@webkit.org
  • 5 edits in trunk

2008-02-08 Pierre-Luc Beaudoin <​pierre-luc.beaudoin@collabora.co.uk>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17009
[Gtk] Webkit strips accents from some dead-key combinations

KeyEvents have to go through the gtk input method.

2:35 AM Changeset in webkit [30089] by Darin Adler
  • 31 edits
    2 copies
    27 adds in trunk

WebCore:

Reviewed by Eric.

Test: traversal/exception-forwarding.html

This turned into a near-rewrite of NodeIterator and TreeWalker.

  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::takeException): Added. (WebCore::JSNodeFilterCondition::acceptNode): Added an out parameter to return a JavaScript exception.
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::acceptNode): Wrote a custom binding for this that raises a JavaScript exception if the out parameter is set.
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::nextNode): Wrote a custom binding for this that raises a JavaScript exception if the out parameter is set. (WebCore::JSNodeIterator::previousNode): Ditto.
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::parentNode): Wrote a custom binding for this that raises a JavaScript exception if the out parameter is set. (WebCore::JSTreeWalker::firstChild): Ditto. (WebCore::JSTreeWalker::lastChild): Ditto. (WebCore::JSTreeWalker::nextSibling): Ditto. (WebCore::JSTreeWalker::previousSibling): Ditto. (WebCore::JSTreeWalker::previousNode): Ditto. (WebCore::JSTreeWalker::nextNode): Ditto.
  • bindings/objc/DOM.mm: (WebCore::ObjCNodeFilterCondition::acceptNode): Updated to include new exception out parameter. (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Use RefPtr to make object lifetimes clearer. (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Added include of NodeFilter.h for JSDocument.cpp.
  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::createNodeIterator): Changed to use PassRefPtr. (WebCore::Document::createTreeWalker): Ditto.
  • dom/NodeFilter.h:
  • dom/NodeFilter.cpp: (WebCore::NodeFilter::NodeFilter): Changed to use PassRefPtr. (WebCore::NodeFilter::acceptNode): Added an out parameter to return a JavaScript exception.
  • dom/NodeFilter.idl: Custom binding for acceptNode.
  • dom/NodeFilterCondition.h:
  • dom/NodeFilterCondition.cpp: (WebCore::NodeFilterCondition::acceptNode): Added an out parameter to return a JavaScript exception.
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::NodeIterator): Changed to use PassRefPtr more. Eliminated m_doc, using the root node instead, and unnecessary check for null -- rootNode must be non-null and all nodes have a non-null document. (WebCore::NodeIterator::~NodeIterator): Changed to get document from root. (WebCore::NodeIterator::nextNode): Rewrote to use a RefPtr since the acceptNode function could do anything, including removing the last reference to the current node. Also folded findNextNode into this function since it's the only one that needs to call it. (WebCore::NodeIterator::previousNode): Same thing, but the other direction. (WebCore::NodeIterator::detach): Changed to use the root node as the indication that we're detached rather than a separate boolean. (WebCore::NodeIterator::notifyBeforeNodeRemoval): Removed some unnneeded checks. Removed incorrect use of findNextNode/findPreviousNode -- those functions call acceptNode and the DOM standard is quite clear that these functions do not take that into account, allowing the current node to become one that's not accepted.
  • dom/NodeIterator.h: Changed constructor to use PassRefPtr more. Changed nextNode and previousNode to have an out parameter with a JavaScript exception. Removed helper functions setReferenceNode, setPointerBeforeReferenceNode, detached, setDetached, document, findNextNode, and findPreviousNode. All were unnecessary. Removed data member m_doc which was just rootNode()->document().
  • dom/NodeIterator.idl: Custom binding for nextNode and previousNode.
  • dom/Traversal.cpp: (WebCore::Traversal::Traversal): Use PassRefPtr more. (WebCore::Traversal::acceptNode): Added out parameter for JavaScript exception. Also rearranged the function a little bit for clarity.
  • dom/Traversal.h: Changed acceptNode to have an out parameter with a JavaScript exception and made it protected, since it's only for use by the derived classes.
  • dom/TreeWalker.cpp: (WebCore::TreeWalker::TreeWalker): Updated to use PassRefPtr. (WebCore::TreeWalker::setCurrentNode): Updated to use PassRefPtr and deleted the overloaded version since it's not needed. (WebCore::TreeWalker::parentNode): Rewrote to propagate the exception and also to implement rules about when to check things like whether we're in the tree. The previous fix where we called isDescendantOf was not entirely correct, because the specification allows you to walk outside the tree if you get there somehow. What it doesn't allow is walking outside the tree from inside. The new implementation handles this correctly. (WebCore::TreeWalker::firstChild): Ditto. (WebCore::TreeWalker::lastChild): Ditto. (WebCore::TreeWalker::previousSibling): Ditto. (WebCore::TreeWalker::nextSibling): Ditto. (WebCore::TreeWalker::previousNode): Ditto. Because of the need to check the acceptNode function on parents, this can't use traversePreviousNode (more's the pity, because it's a bit complicated). (WebCore::TreeWalker::nextNode): Ditto.
  • dom/TreeWalker.h: Changed constructor and setCurrentNode to use PassRefPtr more. Changed the navigation functions to have an out parameter with a JavaScript exception. Removed helper functions setCurrentNode and ancestorRejected.
  • dom/TreeWalker.idl: Custom binding for navigation functions.

LayoutTests:

Reviewed by Eric.

  • grabbed NodeIterator and TreeWalker tests from Hixie's site and KHTML
  • traversal/exception-forwarding-expected.txt: Added.
  • traversal/exception-forwarding.html: Added.
  • traversal/resources: Added.
  • traversal/resources/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
  • traversal/resources/exception-forwarding.js: Added.
  • traversal/node-iterator-001-expected.txt: Updated to reflect correct results. The old results reflected a bug in our NodeIterator.
  • traversal/node-iterator-001.html: Ditto.
  • traversal/node-iterator-006.html: Changed test so there's no whitespace node after the <span> elements inside the test root element (a <div>). The old test results were incorrect; the new NodeIterator implementation correctly returned the whitespace node for this test.
  • traversal/node-iterator-006a.html: Copied from traversal/node-iterator-006.html. Preserve the original test, which now has a strange result. But the result is correct, so it's worth keeping around.
  • traversal/node-iterator-006a-expected.txt: Added.
  • fast/dom/TreeWalker/TreeWalker-currentNode-expected.txt: Regenerated.
  • fast/dom/TreeWalker/resources/TreeWalker-currentNode.js: Updated test to expect results that match the DOM specification.
  • traversal/hixie-node-iterator/001-expected.txt: Added.
  • traversal/hixie-node-iterator/001.xml: Added.
  • traversal/hixie-node-iterator/002-expected.txt: Added.
  • traversal/hixie-node-iterator/002.xml: Added.
  • traversal/hixie-node-iterator/003-expected.txt: Added.
  • traversal/hixie-node-iterator/003.xml: Added.
  • traversal/hixie-node-iterator/004-expected.txt: Added.
  • traversal/hixie-node-iterator/004.xml: Added.
  • traversal/hixie-node-iterator/005-expected.txt: Added.
  • traversal/hixie-node-iterator/005.xml: Added.
  • traversal/hixie-node-iterator/006-expected.txt: Added.
  • traversal/hixie-node-iterator/006.xml: Added.
  • traversal/hixie-node-iterator/007-expected.txt: Added.
  • traversal/hixie-node-iterator/007.xml: Added.
  • traversal/hixie-node-iterator/008-expected.txt: Added.
  • traversal/hixie-node-iterator/008.xml: Added.
  • traversal/hixie-node-iterator/009-expected.txt: Added.
  • traversal/hixie-node-iterator/009.xml: Added.
  • traversal/hixie-node-iterator/010-expected.txt: Added.
  • traversal/hixie-node-iterator/010.xml: Added.
  • traversal/hixie-node-iterator/origin.txt: Added.
  • traversal/tree-walker-filter-1-expected.txt: Added.
  • traversal/tree-walker-filter-1.html: Added.
1:04 AM Changeset in webkit [30088] by eric@webkit.org
  • 18 edits
    12 adds in trunk

Reviewed by darin.

Add support for Text.wholeText and Text.replaceWholeText
​http://bugs.webkit.org/show_bug.cgi?id=17125

Test EntityReferences to make sure they're always treated as read-only
In doing so I discovered a bug in document.adoptNode(readonlyNode) (and fixed it)

  • dom/Document.cpp: (WebCore::Document::adoptNode): throw NO_MODIFICATION_ALLOWED_ERR when passed a readonly node
  • dom/Node.cpp:
  • dom/Node.cpp: (WebCore::Node::textContent):
  • dom/Text.cpp: (WebCore::earliestLogicallyAdjacentTextNode): (WebCore::latestLogicallyAdjacentTextNode): (WebCore::Text::wholeText): (WebCore::Text::replaceWholeText):
  • dom/Text.h:
  • dom/Text.idl:

Feb 7, 2008:

11:18 PM Changeset in webkit [30087] by oliver@apple.com
  • 5 edits in trunk

Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Tim Hatcher.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=17191
HTML5: Client-side database queries should return values of type number
Test: storage/sql-data-types.html

Make the DB queries return a value as a number if it was inserted
as a number to the database.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnValue): new member function to return SQLValues

  • platform/sql/SQLiteStatement.h:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute): use getColumnValue instead of getColumnText

10:36 PM Changeset in webkit [30086] by adachan@apple.com
  • 7 edits
    1 add in trunk/WebKit/win

<rdar://problem/5292433> certificate authentication support broken in Safari 3.0
Added mechanism to communicate client certificate info back to CFNetwork.

Reviewed by Adam.

  • Interfaces/IWebError.idl: Added new WebURLErrorClientCertificateRequired error.
  • Interfaces/IWebMutableURLRequestPrivate.idl: Added. Added method to set client certificate info on the request.
  • WebKit.vcproj/Interfaces.vcproj: Added new idl.
  • WebKit.vcproj/WebKit.vcproj: Link crypt32.lib
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::QueryInterface): Implements IWebMutableURLRequestPrivate. (deallocCertContext): Free certificate context. (copyCert): Duplicate the certificate context and returns it in a CFDataRef. (WebMutableURLRequest::setClientCertificate):
  • WebMutableURLRequest.h:
10:33 PM Changeset in webkit [30085] by adachan@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/5292433> certificate authentication support broken in Safari 3.0
Added mechanism to communicate client certificate info back to CFNetwork.

Reviewed by Adam.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::clientCerts): Keep a mapping of hosts to client certificates. (WebCore::makeFinalRequest): If we have a client certificate for the host, pass it to CFNetwork by setting it in the SSL properties. (WebCore::ResourceHandle::setClientCertificate): Map client certificate to the host.
10:29 PM Changeset in webkit [30084] by adachan@apple.com
  • 4 edits in trunk/WebKitLibraries

Added 4 new methods:
wkSetClientCertificateInSSLProperties,
wkCanAccessCFURLRequestHTTPBodyParts,
wkCFURLRequestCopyHTTPRequestBodyParts,
wkCFURLRequestSetHTTPRequestBodyParts

Rubber-stamped by Steve.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
10:01 PM Changeset in webkit [30083] by dsmith@webkit.org
  • 2 edits in trunk/WebKitSite

Rubber stamped by weinig and bdash.
Update prototype.js to 1.6.0.2 to be a bit less unfair in comparative benchmarking.

  • perf/slickspeed/frameworks/prototype.js:
3:54 PM Changeset in webkit [30082] by Adam Roben
  • 2 edits in trunk/WebCore

Qt build fix

  • platform/SharedBuffer.cpp: Removed a stub implementation of createWithContentsOfFile, now that each platform has its own stub.
3:34 PM Changeset in webkit [30081] by Adam Roben
  • 2 edits in trunk/WebCore

Fix Bug 17138: REGRESSION: Node highlight not updated properly

<​http://bugs.webkit.org/show_bug.cgi?id=17138>
<rdar://problem/5719869>

Reviewed by Darin.

No test possible.

  • page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Update the overlayRect after scrolling to make sure that we translate the context by the correct amount.
3:29 PM Changeset in webkit [30080] by Adam Roben
  • 3 edits in trunk/WebCore

Qt and GTK+ build fixes

  • platform/gtk/FileSystemGtk.cpp: Added a missing #include.
  • platform/qt/FileSystemQt.cpp: Ditto.
3:19 PM Changeset in webkit [30079] by Adam Roben
  • 4 edits
    2 adds in trunk/WebCore

Some cleanup of Mac-only user stylesheet code

I moved UserStyleSheetLoader out of Frame.cpp into its own files, and
moved some Mac-only Frame methods to FrameMac.mm.

Reviewed by Darin.

  • WebCore.xcodeproj/project.pbxproj: Added new files to project.
  • loader/mac/UserStyleSheetLoader.cpp: Added. (UserStyleSheetLoader::UserStyleSheetLoader): (UserStyleSheetLoader::~UserStyleSheetLoader):
  • loader/mac/UserStyleSheetLoader.h: Added.
  • page/Frame.cpp: Removed setUserStyleSheet[Location]
  • page/mac/FrameMac.mm: (WebCore::Frame::setUserStyleSheetLocation): Moved here from Frame.cpp. (WebCore::Frame::setUserStyleSheet): Ditto.
3:19 PM Changeset in webkit [30078] by Adam Roben
  • 23 edits in trunk/WebCore

Fix <rdar://5555260> GMail never loads when a user stylesheet is specified

The fix in r29841 did not guarantee that the user stylesheet would not
still be loading by the time GMail called document.write, and so was
not a complete fix.

This change reworks the user stylesheet loading mechanism on non-Mac
platforms to load the stylesheet synchronously from disk, and then
keeps it in memory. This obsoletes the issue of what our behavior
should be before the user stylesheet has loaded and what should happen
when it finishes loading, as the user stylesheet will always be
available when the Document first asks for it. Note, however, that
this removes the ability to specify a non-file: URL for the user
stylesheet. This change was not made for the Mac platform because it's
possible that WebKit clients are relying on non-file: URLs for user
stylesheets. It would also be nice to move back to an asynchronous
loading model someday, but that is not currently possible since we
don't have an asynchronous loading mechanism that is not tied to a
particular Frame.

The responsibility of loading and storing the user stylesheet has
moved from Frame to Page, since the user stylesheet URL is set on the
Page-level Settings object.

Reviewed by Darin.

  • dom/Document.cpp: (WebCore::Document::Document): Changed to call userStyleSheet(). (WebCore::Document::setUserStyleSheet): Made Mac-only. (WebCore::Document::userStyleSheet): Changed to call up to Page on non-Mac platforms. (WebCore::Document::recalcStyleSelector): Changed to call userStyleSheet().
  • dom/Document.h:
    • Made setUserStyleSheet and the m_usersheet member Mac-only
    • Changed userStyleSheet to return a String instance instead of a String reference, since we now might return a new null String.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Made the call to Frame::setUserStyleSheetLocation Mac-only.
  • page/Frame.cpp: Made UserStyleSheetLoader and related code Mac-only. (WebCore::Frame::~Frame): Ditto. (WebCore::Frame::reapplyStyles): Made the call to setUserStyleSheet[Location] Mac-only. On non-Mac platforms the Document will pick up the new stylesheet in Document::reapplyStyles. (WebCore::FramePrivate::FramePrivate): Made m_userStyleSheetLoader Mac-only.
  • page/Frame.h: Made setUserStyleSheet[Location] Mac-only.
  • page/FramePrivate.h: Made m_userStyleSheetLoader Mac-only.
  • page/Page.cpp: (WebCore::Page::Page): Initialize new members. (WebCore::Page::userStyleSheetLocationChanged): Added. Does nothing on Mac. On non-Mac, resets all members relating to the user stylesheet so we'll know to load it again the next time it's asked for. (WebCore::Page::userStyleSheet): Added. Loads the user stylesheet if the user stylesheet location has changed since the last time we loaded it, or if the file has been modified since we last loaded it, then returns the contents of the user stylesheet as a String.
  • page/Page.h: Added new methods/members.
  • page/Settings.cpp: (WebCore::Settings::setUserStyleSheetLocation): Changed to call Page::userStyleSheetLocationChanged.
  • page/Settings.h: Changed userStyleSheetLocation to return the KURL by reference instead of making a copy.
  • platform/FileSystem.h: Added declaration for getFileModificationTime.
  • platform/KURL.h: Added declaration for fileSystemPath method.
  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::fileSystemPath): Added.
  • platform/posix/FileSystemPOSIX.cpp: (WebCore::getFileModificationTime): Added.
  • platform/qt/KURLQt.cpp: (WebCore::KURL::fileSystemPath): Stubbed out.
  • platform/win/FileSystemWin.cpp: (WebCore::getFileModificationTime): Added.
  • platform/qt/FileSystemQt.cpp: Stubbed out getFileModificationTime.
  • platform/gtk/FileSystemGtk.cpp: Ditto.
  • platform/wx/FileSystemWx.cpp: Ditto.
  • platform/qt/TemporaryLinkStubs.cpp: Stubbed out SharedBuffer::createWithContentsOfFile.
  • platform/gtk/TemporaryLinkStubs.cpp: Ditto, along with KURL::fileSystemPath.
  • platform/wx/TemporaryLinkStubs.cpp: Ditto.
3:18 PM Changeset in webkit [30077] by Adam Roben
  • 2 edits in trunk/WebCore

Clean up FileSystemWin.cpp

This cleanup also makes us call _wstat64 instead of _wstat32i64. The
only difference between these two functions is that _wstat64 gives
64-bit time values, while _wstat32i64 only gives 32-bit time values.

Reviewed by Darin.

All tests pass.

  • platform/win/FileSystemWin.cpp: (WebCore::statFile): New static helper that wraps _wstat64. (WebCore::fileSize): Changed to call statFile. (WebCore::fileExists): Ditto.
3:18 PM Changeset in webkit [30076] by Adam Roben
  • 12 edits in trunk/WebCore

Rename fileSize to getFileSize

Rubberstamped by Darin.

  • platform/FileSystem.h:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):
  • platform/posix/FileSystemPOSIX.cpp:
  • platform/qt/FileSystemQt.cpp:
  • platform/win/FileSystemWin.cpp:
  • platform/wx/FileSystemWx.cpp:
  • storage/Database.cpp: (WebCore::Database::databaseSize):
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::usageForDatabase):
  • storage/OriginUsageRecord.cpp: (WebCore::OriginUsageRecord::diskUsage):
3:17 PM Changeset in webkit [30075] by Adam Roben
  • 2 edits in trunk/WebCore

Make KURL::isLocalFile treat the URL's protocol case-insensitively

Reviewed by Darin.

  • platform/KURL.cpp: (WebCore::KURL::isLocalFile): Use equalIgnoringCase instead of ==.
2:35 PM Changeset in webkit [30074] by mrowe@apple.com
  • 1 copy in branches/Safari-3-1-branch

New branch.

2:10 PM Changeset in webkit [30073] by eric@webkit.org
  • 2 edits in trunk/SunSpider

Reviewed by Sam.

  • sunspider: add an error message when ./tests/LIST is not found
1:32 PM Changeset in webkit [30072] by dsmith@webkit.org
  • 2 edits in trunk/WebKitSite

Rubber stamped by Mark Rowe
Fix a duplicate selector in the test.

  • perf/slickspeed/selectors.list:
1:19 PM Changeset in webkit [30071] by dsmith@webkit.org
  • 2 edits in trunk/WebKitSite

Reviewed by Adam Roben.
Added :nth-child and :last-child to the list of selectors to test.

  • perf/slickspeed/selectors.list:
12:26 PM wxWebKit edited by kevino@theolliviers.com
(diff)
12:22 PM wxWebKit created by kevino@theolliviers.com
12:20 PM WikiStart edited by kevino@theolliviers.com
add wx port to wiki (diff)
12:14 PM Changeset in webkit [30070] by hyatt@apple.com
  • 2 adds in trunk/LayoutTests
12:13 PM Changeset in webkit [30069] by hyatt@apple.com
  • 9 edits in trunk/WebCore

Fix for bug 6248, implement the nth-* CSS3 selectors. Patch based on original KHTML work from Allan Jensen
and improved upon by Nick Shanks.

Reviewed by Eric

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::lex):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::parseNth): (WebCore::matchNth): (WebCore::CSSStyleSelector::checkOneSelector):
  • css/tokenizer.flex:
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::childIndex): (WebCore::RenderStyle::setChildIndex):
11:08 AM Changeset in webkit [30068] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix error in bisect-builds when responding "broken" for the first build

Reviewed by Dave Kilzer.

  • Scripts/bisect-builds: Only try to test the build if the nightly info for the current index has not been deleted.
9:01 AM Changeset in webkit [30067] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5729411> REGRESSION (r29834): Float contained in relative-positioned block is painted twice

Test: fast/block/float/relative-painted-twice.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverhangingFloats): Added another case where the child should not take over painting the float: when they do not have the same enclosing layer. In that case, the float is already being painted by one of its closer ancestors.

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/5729411> REGRESSION (r29834): Float contained in relative-positioned block is painted twice
  • fast/block/float/relative-painted-twice.html: Added.
  • platform/mac-leopard/fast/block/float/relative-painted-twice-expected.checksum: Added.
  • platform/mac-leopard/fast/block/float/relative-painted-twice-expected.png: Added.
  • platform/mac/fast/block/float/relative-painted-twice-expected.txt: Added.
8:59 AM Changeset in webkit [30066] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: platform/mac/fast/text/family-for-font-matched-by-name.html

  • platform/mac/WebFontCache.mm: (+[WebFontCache internalFontWithFamily:traits:size:]): Changed to use the family of the font whose name matches the desired family if there is no exact family match.

LayoutTests:

Reviewed by Darin Adler.

  • platform/mac/fast/text/family-for-font-matched-by-name-expected.checksum: Added.
  • platform/mac/fast/text/family-for-font-matched-by-name-expected.png: Added.
  • platform/mac/fast/text/family-for-font-matched-by-name-expected.txt: Added.
  • platform/mac/fast/text/family-for-font-matched-by-name.html: Added.
7:06 AM Changeset in webkit [30065] by Beth Dakin
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/5697882> Traffic or Street View button on
Google Maps is sometimes not positioned correctly (17000)

On the Mac, timers fire in the order that they are registered.
Geoff and I discovered that this is not necessarily true on
Windows, and that turned out to be the cause of this intermittent
layout problem at Google Maps. This patch adds a new member
variable to Timer to remember the timer's insertion point into the
heap. Now when comparing timers, if two timers were registered at
the same time, their insertion orders are compared to determine
which should fire first. This code actually never runs on Debug
builds on the Mac; the system clock on the Mac is accurate enough
that it knows that the two timers were not registered at *exactly*
the same time. This is not the case on Windows. In theory, if we
sped up Javascript enough on the Mac, this code would run and would
prevent misrenderings such as the one found on Google Maps.

  • platform/Timer.cpp: (WebCore::operator<): (WebCore::TimerBase::setNextFireTime):
  • platform/Timer.h:

LayoutTests:

Test written by Geoff, reviewed by me.

Test for <rdar://problem/5697882> Traffic or Street View button on
Google Maps is sometimes not positioned correctly (17000)

  • fast/dom/simultaneouslyRegsiteredTimerFireOrder-expected.txt: Added.
  • fast/dom/simultaneouslyRegsiteredTimerFireOrder.html: Added.
5:59 AM Changeset in webkit [30064] by ggaren@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Alexey Proskuryakov.

Fixed two minor typos in the --root option, to get it working.

  • Scripts/run-sunspider:
    1. Actually assign the function argument to our local variable.
    2. Actually set the $root variable, so we don't try to build later.
2:08 AM Changeset in webkit [30063] by Nikolas Zimmermann
  • 2 edits
    2109 moves
    2086 adds in trunk/LayoutTests

Rubber stamped by Eric.

Move existing SVG baseline from platform/mac/ to platform/mac-tiger/ (I generated all of them using Tiger).
Regenerated new SVG baseline in platform/mac-leopard. platform/mac/svg is doesn't contain any test results anymore.

In a later step it should be investigated, which layout test results can be shared between Leopard & Tiger.
Those results should be moved to platform/mac/svg then.

Feb 6, 2008:

11:17 PM Changeset in webkit [30062] by justin.garcia@apple.com
  • 11 edits in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5195056> Huge plain text pastes are slow


This was fixed in r27369 and then r29367 and r29667 caused performance to
regress.

  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Only updateLayout() for high level commands. (WebCore::EditCommand::unapply): Ditto. (WebCore::EditCommand::reapply): Ditto.
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Added a note about shouldChangeSelection calls that shouldn't be made, a bug I filed as <rdar://problem/5729315>. (WebCore::Editor::unappliedEditing): Ditto. (WebCore::Editor::reappliedEditing): Ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Don't try to test the selection base and extent with the expensive isCandidate operation if the node that will be removed is in a fragment, since such a removal is guaranteed to have no effect on a selection. This is to speed up the paste operation, which does many removes from a fragment.

LayoutTests:

Reviewed by Darin Adler.


<rdar://problem/5195056> Huge plain text pastes are slow


The changes made for this fix exposed several more cases of:
<rdar://problem/5729315> Some shouldChangeSelectedDOMRange contain Ranges for selections that are no longer valid

  • platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/mac/editing/selection/replace-selection-1-expected.txt:
10:16 PM Changeset in webkit [30061] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Landing updated (improved) results for this test. The results changed in r30013,
but this wasn't immediately noticed because of the test being on Leopard skipped list.

Interestingly, js-test-pre.js has a workaround for the issue fixed in this revision in
its debug() function, but not in description(). Keeping the workaround for now to let tests
keep running in shipping Safari/WebKit.

  • svg/css/glyph-orientation-rounding-test-expected.txt:
8:12 PM Changeset in webkit [30060] by kevino@webkit.org
  • 4 edits in trunk/WebCore

Switch from directly handling wx scroll wheel events to handling the PlatformWheelEvent instead to give JS, etc. a chance to handle it.
​http://bugs.webkit.org/show_bug.cgi?id=17179

8:00 PM Changeset in webkit [30059] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-02-06 Mark Rowe <​mrowe@apple.com>

Fix Windows builds.

  • WebCore.vcproj/WebCore.vcproj: Unbreak the XML of the project file.
6:40 PM Changeset in webkit [30058] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Mac build fix. Track rename that happened in r30056.

6:00 PM Changeset in webkit [30057] by oliver@apple.com
  • 4 edits in trunk/LayoutTests

Fix expected output for layout tests to match tiger expected (and so work on the build bots)

RS=Stephanie

5:52 PM Changeset in webkit [30056] by mrowe@apple.com
  • 11 edits
    7 copies
    1 move
    6 adds in trunk/WebCore

2008-02-06 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16979
Conditionalize CoreGraphics vs Cairo support in Windows port.

5:36 PM Changeset in webkit [30055] by andersca@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Change httpBodyFromStream to take the request instead of the stream.


  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::httpBodyFromRequest):
  • platform/network/cf/FormDataStreamCFNet.h:
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
5:24 PM Changeset in webkit [30054] by kmccullough@apple.com
  • 1 edit
    2 adds in trunk/WebCore

Reviewed by Darin.

  • Added manual tests for <rdar://problem/5556374> REGRESSION: cross-domain error when one URL uses an explicit port number and another doesn't
  • manual-tests/Default-port-frame.html: Added.
  • manual-tests/resources/Default-port-frame-contents.html: Added.
2:23 PM Changeset in webkit [30053] by oliver@apple.com
  • 2 edits in trunk/WebCore

Update build flags to fix windows build

2:03 PM Changeset in webkit [30052] by kmccullough@apple.com
  • 5 edits
    7 deletes in trunk

WebCore:

Rubberstamped by Darin.

<rdar://problem/5727708> REGRESSION (r29952): Can't send message from Yahoo Mail beta

  • Reverted the change that caused the regression.
  • dom/Document.cpp: (WebCore::Document::createElement): (WebCore::Document::createElementNS): (WebCore::Document::getElementById): (WebCore::Document::parseQualifiedName): (WebCore::Document::createAttributeNS):
  • dom/Document.idl:

LayoutTests:

Rubberstamped by Darin.

<rdar://problem/5727708> REGRESSION (r29952): Can't send message from Yahoo Mail beta

  • Reverted the change that caused the regression.
  • dom/xhtml/level3/core/documentsetstricterrorchecking02-expected.txt:
  • fast/dom/Document/createAttributeNS-namespace-err-expected.txt: Removed.
  • fast/dom/Document/createAttributeNS-namespace-err.html: Removed.
  • fast/dom/Document/createElementNS-namespace-err-expected.txt: Removed.
  • fast/dom/Document/createElementNS-namespace-err.html: Removed.
  • fast/dom/Document/resources/TEMPLATE.html: Removed.
  • fast/dom/Document/resources/createAttributeNS-namespace-err.js: Removed.
  • fast/dom/Document/resources/createElementNS-namespace-err.js: Removed.
1:46 PM Changeset in webkit [30051] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


Added an ASSERT to catch refCount underflow, since it caused a leak in
my last check-in.

  • wtf/RefCounted.h: (WTF::RefCounted::deref):
1:24 PM Changeset in webkit [30050] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Oliver Hunt.


Fixed <rdar://problem/5728081> REGRESSION: Many leaks on buildbot

The problem was refCount underflow in NamedAttrMap.


Neither our regression tests nor the stress test have yet discovered
another instance of this problem.

  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::addAttribute): Changed to use PassRefPtr, for fast and correct refCount management. Also, change a rediculously slow malloc to a slightly less rediculously slow realloc.
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::insertAttribute): Changed to use PassRefPtr, for fast and correct refCount management.
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): Use a RefPtr, to guarantee that the object starts with a refCount of 1.
1:21 PM Changeset in webkit [30049] by mrowe@apple.com
  • 1 edit in trunk/WebCore/page/InspectorController.cpp

Fix typo in comment added in r30047.

12:19 PM Changeset in webkit [30048] by timothy@apple.com
  • 1 edit
    1180 adds in trunk

Dump of bugs.webkit.org's Bugzilla instance.

11:29 AM Changeset in webkit [30047] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5723293> NULL-deref crash in PropertyMap::put opening web inspector with View Source window as target
  • page/InspectorController.cpp: (WebCore::canPassNodeToJavaScript): Added. Returns false if the node is in a document with JavaScript disabled. (WebCore::InspectorController::inspect): Check canPassNodeToJavaScript and do nothing if it returns false.
11:27 AM Changeset in webkit [30046] by hyatt@apple.com
  • 1 delete in trunk/LayoutTests/dom/xhtml/level2/html/object06.xhtml

Remove bad layout test.:

11:26 AM Changeset in webkit [30045] by hyatt@apple.com
  • 1 delete in trunk/LayoutTests/dom/html/level2/html/object06.html

Remove bad layout test.:

11:26 AM Changeset in webkit [30044] by hyatt@apple.com
  • 4 edits in trunk/WebCore

Fix for bug 16799, object elements should return absolute URLs from .data.

Reviewed by Mark Rowe

  • dom/Document.cpp: (WebCore::Document::completeURL):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::href):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::data):
10:17 AM Changeset in webkit [30043] by Antti Koivisto
  • 3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5726340>
<video autoplay controls> left in unplayable state if navigated away, then back to, before video finished loading


When moving document in and out from the page cache:

  • Cancel incomplete load by deleting the media player. This guarantees everything is in consistent state.
  • Restart the load if it was aborted in the middle.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::willSaveToCache): (WebCore::HTMLMediaElement::didRestoreFromCache):
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::player):
9:53 AM Changeset in webkit [30042] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

PLT speedup related to <rdar://problem/5659272> REGRESSION: PLT .4%
slower due to r28884 (global variable symbol table optimization)


Tweaked RefCounted::deref() to be a little more efficient.

1% - 1.5% speedup on my machine. .7% speedup on Stephanie's machine.


  • wtf/RefCounted.h: (WTF::RefCounted::deref): Don't modify m_refCount if we're just going to delete the object anyway. Also, use a simple == test, which might be faster than <= on some hardware.
9:40 AM Changeset in webkit [30041] by Darin Adler
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Sam.

Test results match Gecko with very few obscure exceptions that seem to be
bugs in Gecko.

Test: fast/js/array-functions-non-arrays.html

  • kjs/array_object.cpp: (KJS::arrayProtoFuncConcat): Removed DontEnum and DontDelete from the call to set length. (KJS::arrayProtoFuncPop): Ditto. Also added missing call to deleteProperty, which is not needed for real arrays, but is needed for non-arrays. (KJS::arrayProtoFuncPush): Ditto. (KJS::arrayProtoFuncShift): Ditto. (KJS::arrayProtoFuncSlice): Ditto. (KJS::arrayProtoFuncSort): Removed incorrect call to set length when the array has no elements. (KJS::arrayProtoFuncSplice): Removed DontEnum and DontDelete from the call to set length. (KJS::arrayProtoFuncUnShift): Ditto. Also added a check for 0 arguments to make behavior match the specification in that case.
  • kjs/nodes.cpp: (KJS::ArrayNode::evaluate): Removed DontEnum and DontDelete from the call to set length.

LayoutTests:

Reviewed by Sam.

  • fast/js/array-functions-non-arrays-expected.txt: Added.
  • fast/js/array-functions-non-arrays.html: Added.
  • fast/js/resources/array-functions-non-arrays.js: Added.
9:33 AM Changeset in webkit [30040] by Darin Adler
  • 17 edits in trunk

JavaScriptCore:

Reviewed by Sam.

  • replace calls to put to set up properties with calls to putDirect, to prepare for a future change where put won't take attributes any more, and for a slight performance boost
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): Use putDirect instead of put.
  • kjs/CommonIdentifiers.h: Removed lastIndex.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Use putDirect instead of put.
  • kjs/array_object.cpp: (KJS::arrayProtoFuncConcat): Took out extra call to get length (unused). (KJS::ArrayObjectImp::ArrayObjectImp): Use putDirect instead of put.
  • kjs/error_object.cpp: (KJS::ErrorPrototype::ErrorPrototype): Use putDirect instead of put.
  • kjs/function.cpp: (KJS::Arguments::Arguments): Use putDirect instead of put. (KJS::PrototypeFunction::PrototypeFunction): Use putDirect instead of put.
  • kjs/function_object.cpp: (KJS::FunctionObjectImp::construct): Use putDirect instead of put.
  • kjs/nodes.cpp: (KJS::FuncDeclNode::makeFunction): Use putDirect instead of put. (KJS::FuncExprNode::evaluate): Use putDirect instead of put.
  • kjs/regexp_object.cpp: (KJS::regExpProtoFuncCompile): Use setLastIndex instead of put(lastIndex). (KJS::RegExpImp::match): Get and set lastIndex by using m_lastIndex instead of calling get and put.
  • kjs/regexp_object.h: (KJS::RegExpImp::setLastIndex): Added.
  • kjs/string_object.cpp: (KJS::stringProtoFuncMatch): Use setLastIndex instead of put(lastIndex).

WebCore:

Reviewed by Sam.

  • replace calls to put to set up properties with calls to putDirect, to prepare for a future change where put won't take attributes any more, and for a slight performance boost
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): Use putDirect instead of put.
  • bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetPrototype::self): Ditto.
  • bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): Ditto.
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item): Ditto.
8:01 AM Changeset in webkit [30039] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/css/transition-color-unspecified.html

  • page/AnimationController.cpp: (WebCore::ImplicitAnimation::animate): Changed to use the value of the 'color' property in the source or destination style as the source or destination value of properties whose inital value is defined to be the computed value of 'color'.

LayoutTests:

Reviewed by Darin Adler.

  • fast/css/transition-color-unspecified.html: Added.
  • platform/mac/fast/css/transition-color-unspecified-expected.checksum: Added.
  • platform/mac/fast/css/transition-color-unspecified-expected.png: Added.
  • platform/mac/fast/css/transition-color-unspecified-expected.txt: Added.
7:46 AM Changeset in webkit [30038] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • svg/svgtags.in:

Feb 5, 2008:

11:08 PM Changeset in webkit [30037] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix -- touch generate-bindings to trigger regeneration of bindings

10:18 PM Changeset in webkit [30036] by mitz@apple.com
  • 224 edits in trunk/LayoutTests/platform/mac/svg/custom

Added the svn:mime-type property to PNGs that did not have it.

10:01 PM Changeset in webkit [30035] by oliver@apple.com
  • 66 edits in trunk

RS=Eric.

Re-enable foreignObject by default as it is needed for a number of
non-fO related SVG tests and none of the old known crashes occur
anymore.

8:36 PM Changeset in webkit [30034] by weinig@apple.com
  • 7 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Anders Carlsson.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=8080
NodeList (and other DOM lists) items are not enumeratable using for..in

WebCore:

Reviewed by Anders Carlsson.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=8080
NodeList (and other DOM lists) items are not enumeratable using for..in

  • Match Firefox when enumerating DOM interfaces with indexGetters (support for the array bracket, nodeList[0], notation) by including all the items in the list before the attributes and methods of the interface.

Test: fast/dom/domListEnumeration.html

  • ForwardingHeaders/kjs/PropertyNameArray.h: Added.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetPropertyNames): Use the new custom method model.
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customGetPropertyNames): ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Instead of just adding a declaration of getProperyNames and implementing the method in the Custom.cpp, move to a the model used by generated getOwnPropertySlot() and put() where the custom code is written in a separate customGetPropertyNames which returns a bool indicating whether to call up to the base class. This enables adding the list indexes to the PropertyNameArray for interfaces with indexGetters automatically.

LayoutTests:

Reviewed by Anders Carlsson.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=8080
NodeList (and other DOM lists) items are not enumeratable using for..in

  • fast/dom/domListEnumeration-expected.txt: Added.
  • fast/dom/domListEnumeration.html: Added.
  • fast/dom/resources/domListEnumeration.js: Added.
6:13 PM Changeset in webkit [30033] by Nikolas Zimmermann
  • 1 edit
    10 adds in trunk/LayoutTests

Reviewed by Oliver.
Add new dynamic update tests, for SVGClipPathElement.

5:29 PM Changeset in webkit [30032] by weinig@apple.com
  • 9 edits
    3 adds in trunk

WebCore:

Reviewed by Darin Adler.

Fix for <rdar://problem/5726604>
dom-checker: deleting properties of the window object cross-domain should not be allowed

Fix flaw found while testing with dom-checker testing tool (​http://code.google.com/p/dom-checker/).

Test: http/tests/security/cross-frame-access-delete.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::deleteProperty): Override deleteProperty to not delete cross-domain.
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::deleteProperty): ditto.
  • bindings/js/JSLocation.cpp: (WebCore::JSLocation::deleteProperty): ditto.
  • bindings/js/JSLocation.h:
  • bindings/scripts/CodeGeneratorJS.pm: Add deleteProperty declaration when CustomDeleteProperty is used.
  • page/DOMWindow.idl: Add CustomDeleteProperty extended attribute.
  • page/History.idl: ditto.

LayoutTests:

Reviewed by Darin Adler.

Test for <rdar://problem/5726604>
dom-checker: deleting properties of the window object cross-domain should not be allowed

  • http/tests/security/cross-frame-access-delete-expected.txt: Added.
  • http/tests/security/cross-frame-access-delete.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-delete-test.html: Added.
5:24 PM Changeset in webkit [30031] by mrowe@apple.com
  • 4 edits in trunk/WebKit/gtk

2008-02-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Fix warnings seen on the Gtk port by declaring variables and using constants of the correct types.

  • webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_contains_item):
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebview.cpp:
5:16 PM Changeset in webkit [30030] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Build fix. Don't override intermediate directory.

  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
4:57 PM Changeset in webkit [30029] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-05 Alp Toker <​alp@atoker.com>

Rubber-stamped by Mark Rowe.

Fix a "missing sentinel in function call" warning by using NULL
instead of 0.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::caretBlinkFrequency):
3:09 PM Changeset in webkit [30028] by Nikolas Zimmermann
  • 5 edits
    30 adds in trunk

Reviewed by Oliver.
Fix dynamic updates of <circle> element's properties.

Added tests: svg/dynamic-updates/SVGCircleElement*

2:31 PM Changeset in webkit [30027] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Wx build fix. Add WebCore/plugins to the include path.

2:28 PM Changeset in webkit [30026] by zecke@webkit.org
  • 3 edits in trunk/WebKitTools

Build fix for Windows. willCloseFrame is a pure virtual and we are
forced to have an implementation.

This partially reverts r30014.

2:24 PM Changeset in webkit [30025] by mrowe@apple.com
  • 4 edits in tags/Safari-5525.7.2

Versioning.

2:23 PM Changeset in webkit [30024] by mrowe@apple.com
  • 4 edits in trunk/WebCore

2008-02-05 Mark Rowe <​mrowe@apple.com>

Mac build fix. Update the Xcode project to follow a moved file,
and track a rename in two files that were missed earlier.

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canProvideDocumentSource]):
  • platform/mac/PlugInInfoStoreMac.mm: (WebCore::PluginInfoStore::pluginNameForMIMEType):
2:22 PM Changeset in webkit [30023] by mrowe@apple.com
  • 2 edits in tags/Safari-5525.7.2/WebKit/mac

Merge r30020.

1:57 PM Changeset in webkit [30022] by Nikolas Zimmermann
  • 1 edit in trunk/WebCore/ChangeLog

Forgot to mention bug

1:56 PM Changeset in webkit [30021] by Nikolas Zimmermann
  • 6 edits
    25 adds in trunk

Reviewed by Holger.

Fix dynamic SVG DOM updates of <a> element's href property.

This commit also introduces a new SVG Tests framework: LayoutTests/svg/dynamic-updates
Its purpose is to provide dynamic updating tests for each SVG class & property, aka.
one test per property per class. As a first pass it's sufficient to add testcases for all
SVG*Element classes, and their properties - and only common-used base-class properties.

For SVGAElement - for example - it makes most sense to test scripting its parent
SVGURIReference object ('href' property) and its own property 'target'.

Adding tests to see - for example - if SVGAElement reacts on changes on ie. its parent
SVGExternalResourcesRequired interface, should really be done in a second pass.

All tests within the new framework are supposed to be created using make-js-tests-wrappers.

1:54 PM Changeset in webkit [30020] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Unreviewed build fix. Add missing #import.

1:53 PM Changeset in webkit [30019] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.7.2

New tag.

1:53 PM Changeset in webkit [30018] by mrowe@apple.com
  • 1 delete in tags/Safari-5525.72

Remove bogus tag.

1:52 PM Changeset in webkit [30017] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.72

New tag.

1:51 PM Changeset in webkit [30016] by justin.garcia@apple.com
  • 4 edits
    6 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

<rdar://problem/5685601> webkit-block-placeholder class on placeholders seems unnecessary (12317)

  • editing/CompositeEditCommand.cpp: (WebCore::createBlockPlaceholderElement): The khtml-block-placeholder class was needed when the editing code actively looked for <br>s of that type in order to handle them specially. That is no longer the case.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Fixed a bug where an extra block would be inserted when hitting return inside an editable root held open by a placeholder <br> or '\n'. Added test cases for the bug and for the special case code that was incorrectly triggered to cause the bug.

LayoutTests:

Reviewed by Alexey Proskuryakov.


<rdar://problem/5685601> webkit-block-placeholder class on placeholders seems unnecessary (12317)

  • editing/inserting/5685601-1-expected.txt: Added.
  • editing/inserting/5685601-1.html: Added.
  • editing/inserting/5685601-2-expected.txt: Added.
  • editing/inserting/5685601-2.html: Added.
  • editing/inserting/5685601-3-expected.txt: Added.
  • editing/inserting/5685601-3.html: Added.
1:46 PM Changeset in webkit [30015] by mrowe@apple.com
  • 20 edits
    6 moves in trunk

2008-02-05 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Anders Carlsson.

Part one of ​http://bugs.webkit.org/show_bug.cgi?id=16924.
Shared PluginDatabase, PluginInfoStore and PluginPackage implementations.

Remove the Win suffix on several plugin-related classes that will
soon be refactored to be more portable.

12:47 PM Changeset in webkit [30014] by zecke@webkit.org
  • 14 edits in trunk

WebKitTools/
2008-02-05 Holger Freyther <​zecke@selfish.org>

Reviewed by Darin.

In ​http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
depends on the order the tests are executed.

Propose to remove willCloseFrame and didlCearWindowObject output from the
FrameLoadDelegate and update the test results. The output of didClearWindowObject
is not interesting for any of the current tests and we have other ways to find
out if a frame was closed or not.

  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didClearWindowObject):
  • DumpRenderTree/win/FrameLoadDelegate.h:

LayoutTest:
2008-02-05 Holger Freyther <​zecke@selfish.org>

Reviewed by Darin.

In ​http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
depends on the order the tests are executed.

Propose to remove willCloseFrame and didlCearWindowObject output from the
FrameLoadDelegate and update the test results. The output of didClearWindowObject
is not interesting for any of the current tests and we have other ways to find
out if a frame was closed or not.

  • http/tests/loading/bad-scheme-subframe-expected.txt:
  • http/tests/loading/bad-server-subframe-expected.txt:
  • http/tests/loading/basic-expected.txt:
  • http/tests/loading/empty-subframe-expected.txt:
  • http/tests/loading/gmail-assert-on-load-expected.txt:
  • http/tests/loading/onload-vs-immediate-refresh-expected.txt:
  • http/tests/loading/slow-parsing-subframe-expected.txt:
  • platform/mac/http/tests/loading/simple-subframe-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
11:52 AM Changeset in webkit [30013] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=17158
Setting innerHTML in a detached XHTML element doesn't use the right namespace

Test: fast/dom/innerHTML-detached-element.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Take parent element namespace into account.
11:45 AM Changeset in webkit [30012] by mrowe@apple.com
  • 4 edits in tags/Safari-5525.7.1

Versioning.

11:44 AM Changeset in webkit [30011] by mrowe@apple.com
  • 8 edits in tags/Safari-5525.7.1

Merge r30003.

11:41 AM Changeset in webkit [30010] by mrowe@apple.com
  • 2 edits in tags/Safari-5525.7.1/WebKit/mac

Merge r29869.

11:32 AM Changeset in webkit [30009] by Antti Koivisto
  • 7 edits
    6 adds in trunk

WebCore:

Reviewed by Geoff.


Fix <rdar://problem/5698200>
eBay photo uploading hangs and causes slow script warning to pop up


In a case like this


var f = window.parent.parentFunction;
document.domain = document.domain; this makes window.parent inaccessible
f();


Firefox allows parentFunction to access parents properties. Match this behavior.


In a domain security check against the dynamic global object fails for the specific reason that one of
the frames has written to the document.domain property and another has not (but they match otherwise),
then recheck against the lexical global object.

Test: http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW.html

http/tests/security/cross-frame-access-callback-explicit-domain-DENY.html

  • bindings/js/kjs_window.cpp: (KJS::Window::allowsAccessFrom): (KJS::Window::printErrorMessage):
  • bindings/js/kjs_window.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldAllowNavigation):
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
  • platform/SecurityOrigin.h: (WebCore::SecurityOrigin::):

LayoutTests:

Reviewed by Geoff.


Test for <rdar://problem/5698200>
eBay photo uploading hangs and causes slow script warning to pop up

  • http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW-expected.txt: Added.
  • http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW.html: Added.
  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt: Added.
  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY.html: Added.
  • http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-ALLOW.html: Added.
  • http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-DENY.html: Added.
11:24 AM Changeset in webkit [30008] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.7.1

New tag.

11:18 AM Changeset in webkit [30007] by Adam Roben
  • 3 edits in trunk/WebCore

Remove an unused member from Document

Reviewed by Mitz.

  • dom/Document.cpp: (WebCore::Document::recalcStyleSelector): There's no need to take m_printSheet into account anymore as it's never anything but the null string.
  • dom/Document.h: Removed m_printSheet and methods relating to it.
10:36 AM Changeset in webkit [30006] by Darin Adler
  • 2 edits in trunk/WebKit/win

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15248
<rdar://problem/5497032> Can not enter accented characters using alt-numeric keypad (take two)

  • WebView.cpp: (WebViewWndProc): KeyUp messages need to be translated, too.
9:31 AM Changeset in webkit [30005] by mitz@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • WebCore part of <rdar://problem/5724303> Should implement writing direction shortcuts
  • WebCore.base.exp: Added Editor::setBaseWritingDirection() and Frame::baseWritingDirectionForSelectionStart().
  • page/mac/WebCoreFrameBridge.h: Removed -baseWritingDirectionForSelectionStart.
  • page/mac/WebCoreFrameBridge.mm: Ditto.

WebKit/mac:

Reviewed by Darin Adler.

  • WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts

The key bindings are Command-Control-left arrow and
Command-Control-right arrow. To match AppKit, the bindings are enabled
only when certain user defaults are set.

  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call Frame::baseWritingDirectionForSelectionStart() and Editor::setBaseWritingDirection() directly. (-[WebHTMLView changeBaseWritingDirection:]): Ditto. (writingDirectionKeyBindingsEnabled): Added. (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper method. (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added. (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
  • WebView/WebView.mm:
9:01 AM Changeset in webkit [30004] by mrowe@apple.com
  • 6 edits in trunk/WebKitSite

Update WordPress to 2.3.3 which includes security fixes.

7:52 AM Changeset in webkit [30003] by mrowe@apple.com
  • 8 edits in trunk

Update versioning to support the mysterious future.

Reviewed by Oliver Hunt.

  • Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.
2:42 AM Changeset in webkit [30002] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the wxWidget Mac build by avoiding using ICU functions that were added after ICU 3.2.

  • editing/SmartReplaceICU.cpp:

(WebCore::addAllCodePoints): Implement a replacement for uset_addAllCodePoints.
(WebCore::getSmartSet): Use addAllCodePoints instead of uset_addAllCodePoints.

1:56 AM Applications using WebKit edited by ap@webkit.org
Added Microsoft products. (diff)
1:34 AM Changeset in webkit [30001] by ap@webkit.org
  • 9 edits
    10 deletes in trunk

Pretend that r29998 never happened.

12:20 AM Changeset in webkit [30000] by mrowe@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

30,000!

12:19 AM Changeset in webkit [29999] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Workaround for ​http://bugs.webkit.org/show_bug.cgi?id=16842
Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things

Reviewed by Oliver Hunt.

Don't install the signal handler unless we are running the pixel tests.
It is currently only used to restore the color profile, but by catching
signals we can trigger a deadlock in DRT while running leak tests.
The deadlock is tracked by ​http://bugs.webkit.org/show_bug.cgi?id=16842,
and a more complete fix will need to be developed to address this for
pixel tests as well.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):

12:16 AM Changeset in webkit [29998] by mrowe@apple.com
  • 9 edits
    10 adds in trunk

2008-02-04 Matt Perry <​mpComplete@gmail.com>

Reviewed by Darin Adler.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14959
No back forward entry added for pages created in javascript

A new HistoryItem is created for calls to Document::open. Calls to
Document::write save the written data to a SharedBuffer that is also
stored on the HistoryItem. When the user navigates back to a
HistoryItem that has a valid buffer, that data is used for the page
content.

Tests: http/tests/navigation/document-open-adds-history-item.html

http/tests/navigation/document-open-delayed-adds-history-item.html
http/tests/navigation/document-open-new-window-adds-history-item.html
http/tests/navigation/document-open-replace-no-history-item.html

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open):
  • dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::write): (WebCore::Document::clear):
  • dom/Document.h:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::substituteData): (WebCore::HistoryItem::setSubstituteData):
  • history/HistoryItem.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::load): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:

2008-02-04 Matt Perry <​mpComplete@gmail.com>

Reviewed by Darin Adler.

Test cases for fix to ​http://bugs.webkit.org/show_bug.cgi?id=14959
No back forward entry added for pages created in javascript.

  • http/tests/navigation/document-open-adds-history-item-expected.txt: Added.
  • http/tests/navigation/document-open-adds-history-item.html: Added.
  • http/tests/navigation/document-open-delayed-adds-history-item-expected.txt: Added.
  • http/tests/navigation/document-open-delayed-adds-history-item.html: Added.
  • http/tests/navigation/document-open-new-window-adds-history-item-expected.txt: Added.
  • http/tests/navigation/document-open-new-window-adds-history-item.html: Added.
  • http/tests/navigation/document-open-replace-no-history-item-expected.txt: Added.
  • http/tests/navigation/document-open-replace-no-history-item.html: Added.

Feb 4, 2008:

11:58 PM Changeset in webkit [29997] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Fix for Bug 16889: REGRESSION (r29425): Canvas-based graphing calculator fails to run

Bug 17015: REGRESSION (r29414-29428): www.fox.com "shows" menu fails to render
Bug 17164: REGRESSION: JavaScript pop-up menu appears at wrong location when hovering image at ​http://news.chinatimes.com/

Reviewed by Oliver Hunt

<​http://bugs.webkit.org/show_bug.cgi?id=16889>
<rdar://problem/5696255>

<​http://bugs.webkit.org/show_bug.cgi?id=17015>

<​http://bugs.webkit.org/show_bug.cgi?id=17164>
<rdar://problem/5720947>

The ActivationImp tear-off (r29425) introduced a problem with ReadModify
nodes that first resolve a slot, call valueForReadModifyNode(), and then
store a value in the previously resolved slot. Since valueForReadModifyNode()
may cause a tear-off, the slot needs to be resolved again, but this was
not happening with the existing code.

11:28 PM Changeset in webkit [29996] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Gtk qmake build fix. Fix perl's complaint about an odd number of elements in anonymous hash.

10:55 PM Changeset in webkit [29995] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Gtk build fix. wchar_t is only convertible to UChar on Windows.

10:54 PM Changeset in webkit [29994] by alp@webkit.org
  • 4 edits in trunk

Fix for r29993. Should have been icon-database, not icondatabase:

2008-02-04 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp Toker and Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16618
[GTK] build-webkit and run-webkit-tests autootools support

Add support for the autotools build to the WebKit build and test
scripts.

10:27 PM Changeset in webkit [29993] by mrowe@apple.com
  • 7 edits in trunk

2008-02-04 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16618
[GTK] build-webkit and run-webkit-tests autootools support

  • configure.ac: make the option name of icon database consistent with the rest of webkit (from -icon-database to icondatabase)

2008-02-04 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16618
[GTK] build-webkit and run-webkit-tests autootools support

  • Scripts/build-webkit: added --database and --icondatabase options
  • Scripts/run-launcher:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
10:18 PM Changeset in webkit [29992] by oliver@apple.com
  • 6 edits in trunk

Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT

Reviewed by Steve F.

iImplement required DRT functionality to allow majority of Drag and Drop testcases to work.
Issues include:

  • Uses Sleep() to implement leapForward reliably.
  • 3 DND tests still fail for reasons that i have not yet determined
  • Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain
9:51 PM Changeset in webkit [29991] by mrowe@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-02-04 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Geoff Garen.

Remove some unneccesary UNUSED_PARAMs. Clarify ownership rule of return value of JSObjectCopyPropertyNames.

  • API/JSNode.c: (JSNode_appendChild): (JSNode_removeChild): (JSNode_replaceChild): (JSNode_getNodeType): (JSNode_getFirstChild):
  • API/JSNodeList.c: (JSNodeList_length):
  • API/JSObjectRef.h:
9:47 PM Changeset in webkit [29990] by mrowe@apple.com
  • 5 edits
    1 add in trunk/WebCore

2008-02-04 Tony Chang <​idealisms@gmail.com>

Reviewed by Darin Adler.

Port the CoreFoundation version of WebCore::isCharacterSmartReplaceExempt
for other platforms by using ICU directly.

  • GNUmakefile.am: Add SmartReplaceICU.cpp.
  • WebCore.pro: Ditto.
  • WebCoreSources.bkl: Ditto.
  • editing/SmartReplace.cpp: Don't use this empty implementation when ICU is available.
  • editing/SmartReplaceICU.cpp: (getSmartSet): (WebCore::isCharacterSmartReplaceExempt):
9:32 PM Changeset in webkit [29989] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

2008-02-04 Robert Sesek <​rsesek@bluestatic.org>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=17042
forms without action attributes submit to the <base> href instead of the originating page

Test: fast/forms/missing-action.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Submit to origin if there is no action

2008-02-04 Robert Sesek <​rsesek@bluestatic.org>

Reviewed by Darin Adler.

Test for Fix ​http://bugs.webkit.org/show_bug.cgi?id=17042
forms without action attributes submit to the <base> href instead of the originating page

  • fast/forms/missing-action-expected.txt: Added.
  • fast/forms/missing-action.html: Added.
9:18 PM Changeset in webkit [29988] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Gtk build fix. Use std::numeric_limits in place of ULLONG_MAX as some Linux machines do not have ULLONG_MAX.

OriginUsageRecord::unknownDiskUsage becomes a static function to avoid the global initialiser which would otherwise be generated.

Reviewed by Tim Hatcher.

7:34 PM Changeset in webkit [29987] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speculative Gtk build fix.

7:25 PM Changeset in webkit [29986] by mrowe@apple.com
  • 6 edits in trunk

Fix ​http://bugs.webkit.org/show_bug.cgi?id=17175 (Bug 17175: Use of C++ compiler flags in CFLAGS).

Reviewed by Alp Toker and Mark Rowe.

Add global_cxxflags definition for inclusion in CXXFLAGS variables.
Only use -fno-rtti and $(SYMBOL_VISIBILITY_INLINES) with global_cxxflags as gcc complains they aren't valid for C.

5:41 PM Changeset in webkit [29985] by alp@webkit.org
  • 16 edits in trunk/WebKit/gtk

2008-02-04 Christian Dywan <​christian@imendio.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17065
[GTK] Use a consistent coding style

5:33 PM Changeset in webkit [29984] by beidson@apple.com
  • 5 edits in trunk/WebCore

Attempt to fix build of all non-Mac platforms

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
4:55 PM Changeset in webkit [29983] by beidson@apple.com
  • 8 edits
    4 adds in trunk/WebCore

Reviewed by Darin

Fix for <rdar://problem/5628468> - Quotas need to be implemented per-origin, and not per-database

To accomplish this, we need to track the sizes of all databases in an origin to constantly keep an up to date
count of the origin's total disk usage. I've introduced the OriginQuotaManager and OriginUsageRecord classes
to accomplish this.

Whenever a transaction is known to mutate the size of a database (tracked by the DatabaseAuthorizer), it marks
that database as unknown in the OriginQuotaManager. When a transaction later comes along to ask the
OriginQuotaManager the usage for that origin, it stat's all of the unknown databases in the origin and returns
the result.

Since the OriginQuotaManager is interesting from both the main thread and a DatabaseThread, all accessors it
provides require it to be locked first. ASSERTs help guarantee this is always the case.

Layout test will involve adding functionality to DRT on multiple platforms and will be coming up shortly

  • WebCore.xcodeproj/project.pbxproj:
  • platform/SecurityOrigin.h: Changed to be ThreadSafeShared instead of RefCounted
  • storage/Database.cpp: (WebCore::Database::databaseSize): Return the current filesize of this database on disk (WebCore::Database::maximumSize): Added - calculates maximum size of this database based on quota and usage
  • storage/Database.h: Add databaseSize() accessor, and get rid of unused declared methods that *were* going to be the solution for this bug.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManager): Accessor to the OriginQuotaManager which is lazily created (WebCore::DatabaseTracker::canEstablishDatabase): Fetch the usage for this database slightly earlier, which will ensure that the OriginQuotaManager is primed to track this origin (WebCore::DatabaseTracker::fullPathForDatabase): Ditto (WebCore::DatabaseTracker::populateOrigins): Create the OriginQuotaManager here. (WebCore::DatabaseTracker::usageForOrigin): Use the OriginQuotaManager instead of looping through each database in the origin (WebCore::DatabaseTracker::deleteOrigin): Remove this origin from the OriginQuotaManager as it is no longer interesting (WebCore::DatabaseTracker::deleteDatabase): Remove this database from the OriginQuotaManager as it is no longer interesting
  • storage/DatabaseTracker.h:
  • storage/OriginQuotaManager.cpp: Added. (WebCore::OriginQuotaManager::OriginQuotaManager): (WebCore::OriginQuotaManager::lock): (WebCore::OriginQuotaManager::unlock): (WebCore::OriginQuotaManager::trackOrigin): Add an origin to be tracked. Useful for when the very first database in a new origin is still in the process of being created (WebCore::OriginQuotaManager::tracksOrigin): (WebCore::OriginQuotaManager::addDatabase): (WebCore::OriginQuotaManager::removeDatabase): (WebCore::OriginQuotaManager::removeOrigin): Removes all records in a certain origin from being tracked (WebCore::OriginQuotaManager::markDatabase): Mark a specific database as having an unknown size - called when the DatabaseAuthorizer in a SQLTransaction knows the file size might change. (WebCore::OriginQuotaManager::diskUsage): Returns the disk usage for the given origin
  • storage/OriginQuotaManager.h: Added.
  • storage/OriginUsageRecord.cpp: Added. (WebCore::OriginUsageRecord::OriginUsageRecord): (WebCore::OriginUsageRecord::addDatabase): Adds an entry for the database in this origin's record (WebCore::OriginUsageRecord::removeDatabase): Removes that entry (WebCore::OriginUsageRecord::markDatabase): Marks the database as of unknown size (WebCore::OriginUsageRecord::diskUsage): Returns the cached disk usage value, or recalculates it if any databases are marked
  • storage/OriginUsageRecord.h: Added.
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): Use Database::maximumSize() instead of attributing the entire quota to each database. (WebCore::SQLTransaction::runStatements): Use Database::maximumSize() instead of attributing the entire quota to each database. (WebCore::SQLTransaction::runCurrentStatement): Mark this databases's size as unknown in the OriginQuotaManager if this statement will change the size of the database
  • storage/SQLTransaction.h:
4:36 PM Changeset in webkit [29982] by harrison@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5607381> CrashTracer: [REGRESSION] 1748 crashes in Safari at com.apple.WebCore: WebCore::Image::width const + 24

Use an empty image when the local image file could not be loaded.

No test case because it would require forcing tiff load failure.


  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI): Do not present the deletion UI in the (odd) event that the delete button could not be loaded.


  • platform/graphics/mac/ImageMac.mm: (WebCore::Image::loadPlatformResource): Return an empty image instead of 0 if the load fails.
3:24 PM Changeset in webkit [29981] by Darin Adler
  • 2 edits in trunk/WebCore
  • dom/Document.cpp: (WebCore::Document::completeURL): Fixed misleading comment.
2:53 PM Changeset in webkit [29980] by timothy@apple.com
  • 1 edit
    1 add in trunk/WebKitLibraries

<rdar://problem/5722735> Merge fix for SQLITE_FULL error
is given even if the max_page_count is increased (2920)

  • libWebCoreSQLite3.a:
2:15 PM Changeset in webkit [29979] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-02-04 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Blacklist Silverlight versions older than min required, not newer.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::isPluginBlacklisted):
2:14 PM Changeset in webkit [29978] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/css

Add layout test for selector parsing changes.

2:14 PM Changeset in webkit [29977] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/css/simple-selector-chain-parsing.html

Add layout test for selector parsing changes.

2:12 PM Changeset in webkit [29976] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for bug 16751, misparsing of html*.test in CSS.

Reviewed by darin

Added fast/css/simple-selector-chain-parsing.html

  • css/CSSGrammar.y:
1:38 PM Changeset in webkit [29975] by Darin Adler
  • 2 edits in trunk/WebCore

Suggested by Geoff and Maciej.

  • bindings/js/JSCustomSQLTransactionCallback.cpp: Reworded a misleading comment to be correct.
1:32 PM Changeset in webkit [29974] by jhoneycutt@apple.com
  • 3 edits in trunk/WebCore

2008-02-04 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Steve, Anders.

<rdar://problem/5211187> QuickTime and Flash plug-ins draw outside of
content area when inside an iframe or div with overflow when playing a
movie and scrolling the iframe/div area

Clip the update region to the zero rect when scrolling. Don't do this
for Java, because it results in repaint problems.

  • plugins/PluginQuirkSet.h: Added the DontClipToZeroRectWhenScrolling quirk (WebCore::):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Readded the old behavior of clipping to the zero rect when updating the window during a scroll. Added plug-in quirk to ignore this behavior for Java. Swapped order of the SetWindowRgn() and MoveWindow() calls to prevent Java from painting outside of its container during a scroll. (WebCore::PluginViewWin::determineQuirks): If this is Java, add the DontClipToZeroRectWhenScrolling quirk.
12:57 PM Changeset in webkit [29973] by timothy@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/5722972> Leopard needs to statically link SQLite

  • Configurations/Base.xcconfig: Always have a header search path for WebCoreSQLite3.
  • Configurations/DebugRelease.xcconfig: Ditto.
  • Configurations/WebCore.xcconfig: Always link against WebCoreSQLite3.
12:29 PM Changeset in webkit [29972] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added one more failure.
12:24 PM Changeset in webkit [29971] by Adam Roben
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

Fixed a typo

12:23 PM Changeset in webkit [29970] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some new failures.
12:17 PM Changeset in webkit [29969] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • bindings/scripts/CodeGeneratorCOM.pm: Touched to force a rebuild of the COM bindings.
11:04 AM Changeset in webkit [29968] by harrison@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5715481> REGRESSION (r26499): JavaScript document.lastModified is not supported

Re-add attribute inadvertantly lost by r26499.

Test: fast/js/lastModified.html: Added.

  • dom/Document.idl: Add lastModified.

LayoutTests:

Reviewed by Tim Hatcher.

Test for <rdar://problem/5715481> REGRESSION (r26499): JavaScript document.lastModified is not supported

  • fast/js/lastModified-expected.txt: Added.
  • fast/js/lastModified.html: Added.
  • fast/js/resources/lastModified.js: Added.
10:41 AM Changeset in webkit [29967] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Fix wrongly auto-merged change log.

10:40 AM Changeset in webkit [29966] by Darin Adler
  • 3 edits in trunk/WebCore

Fix the search field if the inpsected Document has overridden
Document.evaluate or Document.querySelectorAll

Reviewed by Darin.

  • manual-tests/inspector-document-methods-override.html: Added.
  • page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): Reworded a comment to force WebCore.vcproj to build.
  • page/inspector/inspector.js: Call Document.prototype.{evaluate,querySelectorAll}.call instead of calling the functions directly on the inspected Document. This ensures we are calling the version of these functions we intended to.
10:37 AM Changeset in webkit [29965] by Adam Roben
  • 3 edits
    1 add in trunk/WebCore

Fix the search field if the inpsected Document has overridden Document.evaluate or Document.querySelectorAll

Reviewed by Darin.

  • manual-tests/inspector-document-methods-override.html: Added.
  • page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): Reworded a comment to force WebCore.vcproj to build.
  • page/inspector/inspector.js: Call Document.prototype.{evaluate,querySelectorAll}.call instead of calling the functions directly on the inspected Document. This ensures we are calling the version of these functions we intended to.
10:26 AM ApplicationsGtk edited by alp@atoker.com
Add another app: Clutter (diff)
9:31 AM ApplicationsGtk edited by alp@atoker.com
List a few more apps (diff)
9:25 AM Changeset in webkit [29964] by Darin Adler
  • 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • possible fix for <rdar://problem/5714030> Crash in Database::deliverAllPendingCallbacks() reloading a page quickly

I don't fully understand the cause of the crash, but I think this might
be a helpful change.

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::commit): If the commit fails, don't leave this transaction and database both marked as "still in progress". As far as I can tell this does no good, and also seems to do harm. (WebCore::SQLiteTransaction::rollback): Ditto.
  • storage/Database.cpp: (WebCore::Database::performTransactionStep): Add some assertions to detect databases stuck in the "transaction in progress" state.
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): Ditto. (WebCore::SQLTransaction::postflightAndCommit): Ditto. (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto.
9:23 AM Changeset in webkit [29963] by Darin Adler
  • 19 edits
    1 copy
    5 adds in trunk

WebCore:

Reviewed by Geoff.

  • fix <rdar://problem/5715692> REGRESSION (r28570): JavaScript window.scrollTo() calls no longer accept 'undefined' values

By default, we should accept non-numeric parameters and non-integral numbers for
parameters that expect integers, without throwing exceptions.

While creating the test for this, I ran into a couple minor bugs with the
functions involved, and this patch fixes those too.

Test: fast/dom/non-numeric-values-numeric-parameters.html

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::add): Added. This function has unusual behavior when passed non-integral values for its second parameter, so it needs to be written by hand. I think that [Custom] is better here than inventing a new keyword.
  • bindings/scripts/CodeGeneratorJS.pm: Changed default for "long" and "unsigned long" to ignore errors rather than failing due to type differences. Also changed a couple functions to use hashes.
  • css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::removeRule): Remove overload of removeRule without a second parameters. While we do allow this from JavaScript, it's not a true optional parameter, but rather just a case of "you can omit parameters and they are treated as undefined" combined with "undefined turns into 0 when passed to a function that takes an integer".
  • css/CSSStyleSheet.idl: Removed [Optional] on the index parameter for removeRule. This is not truly an optional parameter.
  • dom/ProgressEvent.cpp: (WebCore::ProgressEvent::initProgressEvent): Updated this function to match other DOM event init functions -- important to do nothing if this is called on the an already-dispatched event and we need to respect the bubble and cancelable arguments. Also removed initProgressEventNS. We don't support namespaced events, and if we add support, it should be across all event classes, not just ProgressEvent.
  • dom/ProgressEvent.h: Removed initProgressEventNS.
  • dom/ProgressEvent.idl: Ditto.
  • dom/Range.cpp: (WebCore::Range::createContextualFragment): Added a check for 0. This can happen if the passed-in start container is a node that's not an HTML element and also does not have a parent.
  • html/HTMLOptionsCollection.idl: Added the [Custom] attribute to add, since the rules for processing its parameters are unusual.
  • page/DOMSelection.cpp: Removed the version of setPosition that has only one parameter. The offset is not really optional.
  • page/DOMSelection.h: Ditto.
  • page/DOMSelection.idl: Removed the [Optional] keyword for the second parameter of setPosition. It's not a true optional parameter (see discussion of removeRule above).
  • page/DOMWindow.cpp: (WebCore::DOMWindow::adjustWindowRect): Simplified logic for constraining the X and Y coordinates, in a way that makes them work even when the window coordinates are infinite. Also strengthened the assertion.

WebKitTools:

Reviewed by Geoff.

  • Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast and svg subdirectories. Added some more exceptions for the benefit of the fast/dom subdirectory.

LayoutTests:

Reviewed by Geoff.

  • test for <rdar://problem/5715692> REGRESSION (r28570): JavaScript window.scrollTo() calls no longer accept 'undefined' values
  • fast/dom/non-numeric-values-numeric-parameters-expected.txt: Added.
  • fast/dom/non-numeric-values-numeric-parameters.html: Added.
  • fast/dom/resources/TEMPLATE.html: Copied from fast/dom/Element/resources/TEMPLATE.html.
  • fast/dom/resources/non-numeric-values-numeric-parameters.js: Added.
  • editing/selection/extend-expected.txt: Updated.
  • editing/selection/extend.html: Removed test that extend throws if passed only one parameter. There's no reason for us to be strict about this -- we generally treat missing parameters the same as if "undefined" had been passed with few exceptions.
8:13 AM Changeset in webkit [29962] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows Apple-only build fix

  • DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include directory.
5:34 AM QtWebKitTodo edited by Simon Hausmann
(diff)
3:00 AM Changeset in webkit [29961] by alp@webkit.org
  • 71 edits in trunk

2008-02-04 Alp Toker <​alp@atoker.com>

Rubber-stamped by Mark Rowe.

Remove all trailing whitespace in the GTK+ port and related
components.

Feb 3, 2008:

10:34 PM Changeset in webkit [29960] by mitz@apple.com
  • 6 edits in trunk/LayoutTests/fast/canvas

Set some PNGs' svn:mime-type property to image/png

10:27 PM UsingGitWithWebKit edited by eric@webkit.org
(diff)
10:25 PM Changeset in webkit [29959] by oliver@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Add an additional test for Canvas.transform with non-invertible matrix.

RS=Eric

  • fast/canvas/canvas-transform-non-invertible-expected.checksum: Added.
  • fast/canvas/canvas-transform-non-invertible-expected.png: Added.
  • fast/canvas/canvas-transform-non-invertible-expected.txt: Added.
  • fast/canvas/canvas-transform-non-invertible.html: Added.
10:20 PM Changeset in webkit [29958] by alp@webkit.org
  • 9 edits in trunk

2008-02-03 Christian Dywan <​christian@imendio.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17046
[GTK] Context menu fixes and customisation suport

Provide standard GTK+ context menu items where appropriate.

7:41 PM Changeset in webkit [29957] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Typo fix. Don't use the provisionalDocumentLoader() after the whole page has already been loaded.
​http://bugs.webkit.org/show_bug.cgi?id=17157

6:35 PM Changeset in webkit [29956] by oliver@apple.com
  • 5 edits
    20 adds in trunk

Bug 17169: Support transform on Canvas

Reviewed by Maciej.

Nice and simple patch as the cross-platform code to apply
a transform was already there.

Tests: fast/canvas/canvas-transform-identity.html

fast/canvas/canvas-transform-infinity.html
fast/canvas/canvas-transform-multiply.html
fast/canvas/canvas-transform-nan.html
fast/canvas/canvas-transform-skewed.html

4:14 PM Changeset in webkit [29955] by Nikolas Zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

Rubber stamped by Eric.
Add missing layout test results.

4:11 PM Changeset in webkit [29954] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Oliver.

Fix mistake in SVGImageElement, breaking "Dock" example of carto.net
It was comparing against the wrong attribute names in svgAttributeChanged().

Added testcase: svg/custom/js-update-image.svg

3:55 PM Changeset in webkit [29953] by eric@webkit.org
  • 7 edits
    6 adds in trunk

Reviewed by darin.

Acid3 expects textNode.localName === null
​http://bugs.webkit.org/show_bug.cgi?id=17060

Test: fast/dom/Node/initial-values.html

  • dom/Comment.cpp: remove localName implementation
  • dom/Comment.h:
  • dom/Node.cpp: return nullAtom instead of emptyAtom
  • dom/Text.cpp: remove localName implementation
  • dom/Text.h:
3:46 PM Changeset in webkit [29952] by eric@webkit.org
  • 5 edits
    7 adds in trunk

Reviewed by darin.

Make createElementNS and createAttributeNS follow the (vague) DOM Core 2 spec
by throwing exceptions for more types of invalid qualified names.
​http://bugs.webkit.org/show_bug.cgi?id=16833

Tests: fast/dom/Document/createAttributeNS-namespace-err.html

fast/dom/Document/createElementNS-namespace-err.html

  • dom/Document.cpp: (WebCore::Document::createElement): (WebCore::hasNamespaceError): (WebCore::Document::createElementNS): (WebCore::Document::createAttributeNS):
  • dom/Document.idl:
3:18 PM Changeset in webkit [29951] by Nikolas Zimmermann
  • 129 edits in trunk/WebCore

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=15394

Dramatically improve dynamic update performance in DOM / SVG DOM.

The notifyAttributeChange() sledgehammer is gone now. It was implemented on quite a lot of
SVG*Element classes and blindly reacted on any property change caused by DOM / SVG DOM
by rebuilding style/renderer etc. without actually checking what changed. SVG used a hack
for years that attributeChanged() called notifyAttributeChange() - which results in poor
scripting performance and/or dynamic creation/modification of elements using SVG DOM.

2:17 PM Changeset in webkit [29950] by kevino@webkit.org
  • 6 edits in trunk

Build fix for last wx commit (a couple things were not committed). Also fix some style issues.

1:35 PM Changeset in webkit [29949] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Clean up overlooked coding guideline issues from last commit.

1:10 PM Changeset in webkit [29948] by kevino@webkit.org
  • 4 edits in trunk/WebCore

Widget needs to subclass wxWindow, not wxScrolledWindow for wx port, to fix several scrolling-related issues.
​http://bugs.webkit.org/show_bug.cgi?id=17165

8:38 AM Changeset in webkit [29947] by Darin Adler
  • 1 edit
    10 copies
    3 deletes in trunk/LayoutTests
  • updated some more only-child and only-of-type tests to expect success (failures seen on buildbot)

The tests were now succeeding, but the results and placement reflected failure.
I'm not sure why we have such a tiny set of tests in the css3 directory.
The expected results are updated as well as moved.

  • css3/css3-modsel-36.html: Copied from css3/expected_failures/css3-modsel-36.html.
  • css3/css3-modsel-37.html: Copied from css3/expected_failures/css3-modsel-37.html.
  • platform/mac/css3/css3-modsel-36-expected.checksum: Copied from platform/mac/css3/expected_failures/css3-modsel-36-expected.checksum.
  • platform/mac/css3/css3-modsel-36-expected.png: Copied from platform/mac/css3/expected_failures/css3-modsel-36-expected.png.
  • platform/mac/css3/css3-modsel-36-expected.txt: Copied from platform/mac/css3/expected_failures/css3-modsel-36-expected.txt.
  • platform/mac/css3/css3-modsel-37-expected.checksum: Copied from platform/mac/css3/expected_failures/css3-modsel-37-expected.checksum.
  • platform/mac/css3/css3-modsel-37-expected.png: Copied from platform/mac/css3/expected_failures/css3-modsel-37-expected.png.
  • platform/mac/css3/css3-modsel-37-expected.txt: Copied from platform/mac/css3/expected_failures/css3-modsel-37-expected.txt.
  • platform/qt/css3/css3-modsel-36-expected.txt: Copied from platform/qt/css3/expected_failures/css3-modsel-36-expected.txt.
  • platform/qt/css3/css3-modsel-37-expected.txt: Copied from platform/qt/css3/expected_failures/css3-modsel-37-expected.txt.
  • css3/expected_failures: Removed.
  • platform/mac/css3/expected_failures: Removed.
  • platform/qt/css3/expected_failures: Removed.
3:11 AM QtWebKitContrib edited by Simon Hausmann
(diff)

Feb 2, 2008:

11:01 PM Changeset in webkit [29946] by dsmith@webkit.org
  • 3 edits in trunk/WebKitSite

Reviewed by Oliver.


Update the selector benchmark/test now that WebKit supports :only-child and :last-child;
Unfortunately, the javascript libraries don't appear to implement :*-of-type correctly, so that one remains disabled for now.

  • perf/slickspeed/header.html: Typo fix, and updated the note to clarify that WebKit is no longer the only implementation causing us to leave some selectors disabled.
  • perf/slickspeed/selectors.list: Added the new selectors
6:29 PM Changeset in webkit [29945] by hyatt@apple.com
  • 2 adds in trunk/LayoutTests/fast/css

Add the test files. Oops.

6:28 PM Changeset in webkit [29944] by hyatt@apple.com
  • 5 edits
    6 adds in trunk

WebCore:

Fix for bug 5468, support CSS3 :only-child and :only-of-type selectors.

Reviewed by olliej

Added fast/css/only-child-pseudo-class.html, fast/css/only-of-type-pseudo-class.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):

LayoutTests:

Add test for bug 5468, supporting :only-child and :only-of-type in CSS3.

Reviewed by olliej

  • platform/mac/fast/css/only-child-pseudo-class-expected.checksum: Added.
  • platform/mac/fast/css/only-child-pseudo-class-expected.png: Added.
  • platform/mac/fast/css/only-child-pseudo-class-expected.txt: Added.
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.checksum: Added.
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.png: Added.
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.txt: Added.
4:20 PM Changeset in webkit [29943] by ggaren@apple.com
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Geoff Garen.

PLT speedup related to <rdar://problem/5659272> REGRESSION: PLT .4%
slower due to r28884 (global variable symbol table optimization)

Geoff's theory is that the slowdown was due to copying hash tables when
putting things into the back/forward cache. If that's true, then this
should fix the problem.


(According to Geoff's measurements, in a PLT that exaggerates the
importance of symbol table saving during cached page creation, this
patch is a ~3X speedup in cached page creation, and a 9% speedup overall.)

  • kjs/JSVariableObject.cpp: (KJS::JSVariableObject::saveLocalStorage): Updated for changes to SavedProperty, which has been revised to avoid initializing each SavedProperty twice when building the array. Store the property names too, so we don't have to store the symbol table separately. Do this by iterating the symbol table instead of the local storage vector. (KJS::JSVariableObject::restoreLocalStorage): Ditto. Restore the symbol table as well as the local storage vector.
  • kjs/JSVariableObject.h: Removed save/restoreSymbolTable and do that work inside save/restoreLocalStorage instead. Made restoreLocalStorage a non-const member function that takes a const reference to a SavedProperties object.
  • kjs/LocalStorage.h: Changed attributes to be unsigned instead of int to match other declarations of attributes elsewhere.
  • kjs/property_map.cpp: (KJS::SavedProperties::SavedProperties): Updated for data member name change. (KJS::PropertyMap::save): Updated for data member name change and to use the new inline init function instead of setting the fields directly. This allows us to skip initializing the SavedProperty objects when first allocating the array, and just do it when we're actually setting up the individual elements. (KJS::PropertyMap::restore): Updated for SavedProperty changes.
  • kjs/property_map.h: Changed SavedProperty from a struct to a class. Set it up so it does not get initialized at construction time to avoid initializing twice when creating an array of SavedProperty. Removed the m_ prefixes from the members of the SavedProperties struct. Generally we use m_ for class members and not struct.

WebCore:

Reviewed by Geoff Garen.

PLT speedup related to <rdar://problem/5659272> REGRESSION: PLT .4%
slower due to r28884 (global variable symbol table optimization)

  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): Removed saveSymbolTable call. (WebCore::CachedPage::restore): Removed restoreSymbolTable call. (WebCore::CachedPage::clear): Removed clear of m_windowSymbolTable.
  • history/CachedPage.h: Removed m_windowSymbolTable, since save/restoreLocalStorage now takes care of the symbol table. Also removed many unnecessary includes.
3:18 PM Changeset in webkit [29942] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by eseidel.

Add an include for for <objidl.h> which isn't included
by default with WIN32_LEAN_AND_MEAN.

  • platform/graphics/FontCache.h:
3:13 PM Changeset in webkit [29941] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by darin. Landed by eseidel.

Add #define guards for WIN32_LEAN_AND_MEAN and _CRT_RAND_S.

  • kjs/config.h:
  • wtf/FastMalloc.cpp:
  • wtf/TCSpinLock.h:
12:02 PM Changeset in webkit [29940] by kevino@webkit.org
  • 8 edits in trunk/WebCore

wxFont is reference counted and meant to be used as as a value object; when using wxFont*, ref-counting was not happening properly and the font object would be destroyed while still in use. Also, fix memory leak in wx's FrameData::clear() method.

11:19 AM Changeset in webkit [29939] by Darin Adler
  • 1 edit
    10 moves in trunk/LayoutTests
  • updated some more last-child and last-of-type tests to expect success (failures seen on buildbot)

The tests were now succeeding, but the results and placement reflected failure.
I'm not sure why we have such a tiny set of tests in the css3 directory.
The expected results are updated as well as moved.

  • css3/css3-modsel-33.html: Copied from css3/expected_failures/css3-modsel-33.html.
  • css3/css3-modsel-35.html: Copied from css3/expected_failures/css3-modsel-35.html.
  • css3/expected_failures/css3-modsel-33.html: Removed.
  • css3/expected_failures/css3-modsel-35.html: Removed.
  • platform/mac/css3/css3-modsel-33-expected.checksum: Copied from platform/mac/css3/expected_failures/css3-modsel-33-expected.checksum.
  • platform/mac/css3/css3-modsel-33-expected.png: Copied from platform/mac/css3/expected_failures/css3-modsel-33-expected.png.
  • platform/mac/css3/css3-modsel-33-expected.txt: Copied from platform/mac/css3/expected_failures/css3-modsel-33-expected.txt.
  • platform/mac/css3/css3-modsel-35-expected.checksum: Copied from platform/mac/css3/expected_failures/css3-modsel-35-expected.checksum.
  • platform/mac/css3/css3-modsel-35-expected.png: Copied from platform/mac/css3/expected_failures/css3-modsel-35-expected.png.
  • platform/mac/css3/css3-modsel-35-expected.txt: Copied from platform/mac/css3/expected_failures/css3-modsel-35-expected.txt.
  • platform/mac/css3/expected_failures/css3-modsel-33-expected.checksum: Removed.
  • platform/mac/css3/expected_failures/css3-modsel-33-expected.png: Removed.
  • platform/mac/css3/expected_failures/css3-modsel-33-expected.txt: Removed.
  • platform/mac/css3/expected_failures/css3-modsel-35-expected.checksum: Removed.
  • platform/mac/css3/expected_failures/css3-modsel-35-expected.png: Removed.
  • platform/mac/css3/expected_failures/css3-modsel-35-expected.txt: Removed.
  • platform/qt/css3/css3-modsel-33-expected.txt: Copied from platform/qt/css3/expected_failures/css3-modsel-33-expected.txt.
  • platform/qt/css3/css3-modsel-35-expected.txt: Copied from platform/qt/css3/expected_failures/css3-modsel-35-expected.txt.
  • platform/qt/css3/expected_failures/css3-modsel-33-expected.txt: Removed.
  • platform/qt/css3/expected_failures/css3-modsel-35-expected.txt: Removed.
8:57 AM Changeset in webkit [29938] by mrowe@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

Add WordPress plugin to give more control over blog comment settings.

8:52 AM Changeset in webkit [29937] by kevino@webkit.org
  • 6 edits in trunk

Don't use callback-based timers on Windows, they eat crashes and put the application in an undefined state (and since the crash was eaten, it's impossible to determine the original cause). This is a version of r28500 for the wx port.

Reviewed by Adam Roben.

8:45 AM Changeset in webkit [29936] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Qt build fix. Fix typo.

8:31 AM Changeset in webkit [29935] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Blind Qt build fix. Add Template.h include.

8:10 AM Changeset in webkit [29934] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix - add missing include file.

2:46 AM Changeset in webkit [29933] by hyatt@apple.com
  • 6 edits
    8 adds in trunk

WebCore:

Fix for bug 4812. Support last-child and last-of-type CSS3 selectors. Brings Acid3 score up to 68/100.

Reviewed by olliej

Added fast/css/last-child-pseudo-class.html, fast/css/last-of-type-pseudo-class.html

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):

LayoutTests:

Fix for bug 4812. Support last-child and last-of-type (and make sure they are properly dynamic).

Reviewed by olliej

  • fast/css/last-child-pseudo-class.html: Added.
  • fast/css/last-of-type-pseudo-class.html: Added.
  • platform/mac/fast/css/last-child-pseudo-class-expected.checksum: Added.
  • platform/mac/fast/css/last-child-pseudo-class-expected.png: Added.
  • platform/mac/fast/css/last-child-pseudo-class-expected.txt: Added.
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.checksum: Added.
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.png: Added.
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.txt: Added.
2:06 AM Changeset in webkit [29932] by hyatt@apple.com
  • 7 edits
    12 adds in trunk

WebCore:

Make :first-child and :first-of-type properly dynamic when the DOM changes. Brings the Acid3 score up
to 66/100.

Reviewed by olliej

Added fast/css/first-child-pseudo-class.html, fast/css/first-of-type-pseudo-class.html, fast/css/empty-body-test.html

  • css/CSSGrammar.y:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
  • dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::Element::childrenChanged):
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::childrenAffectedByFirstChildRules): (WebCore::RenderStyle::setChildrenAffectedByFirstChildRules): (WebCore::RenderStyle::childrenAffectedByLastChildRules): (WebCore::RenderStyle::setChildrenAffectedByLastChildRules): (WebCore::RenderStyle::childrenAffectedByPositionalRules): (WebCore::RenderStyle::setChildrenAffectedByPositionalRules): (WebCore::RenderStyle::firstChildState): (WebCore::RenderStyle::setFirstChildState): (WebCore::RenderStyle::lastChildState): (WebCore::RenderStyle::setLastChildState):

LayoutTests:

Added tests for dynamic :first-child support (Acid3).

Reviewed by olliej

  • fast/css/empty-body-test.html: Added.
  • fast/css/first-child-pseudo-class.html: Added.
  • fast/css/first-of-type-pseudo-class.html: Added.
  • platform/mac/fast/css/empty-body-test-expected.checksum: Added.
  • platform/mac/fast/css/empty-body-test-expected.png: Added.
  • platform/mac/fast/css/empty-body-test-expected.txt: Added.
  • platform/mac/fast/css/first-child-pseudo-class-expected.checksum: Added.
  • platform/mac/fast/css/first-child-pseudo-class-expected.png: Added.
  • platform/mac/fast/css/first-child-pseudo-class-expected.txt: Added.
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.checksum: Added.
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.png: Added.
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.txt: Added.
1:37 AM Changeset in webkit [29931] by mitz@apple.com
  • 2 edits
    1 copy in trunk/LayoutTests
  • added Tiger-only results for a test
  • platform/mac-leopard/fast/text/cg-fallback-bolding-expected.txt: Copied from LayoutTests/platform/mac/fast/text/cg-fallback-bolding-expected.txt.
  • platform/mac/fast/text/cg-fallback-bolding-expected.txt:
12:25 AM Changeset in webkit [29930] by mitz@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Oliver Hunt.

  • fix <rdar://problem/5720637> Missing characters in right-to-left complex text where different fonts are used in the same run
  • platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::advance): Fixed an off-by-1 error in the start offset of sub-runs of RTL runs. Changed to update m_currentCharacter to the first character of the sub-run before calling itemizeShapeAndPlace. In RTL runs, m_currentCharacter decreases as sub-runs are processed from left to right. (WebCore::UniscribeController::itemizeShapeAndPlace): Removed the updating of m_currentCharacter because advance() does it now.

LayoutTests:

Reviewed by Oliver Hunt.

  • changed a test to use the same fonts on Windows as on Mac OS X
  • fast/text/atsui-spacing-features.html: Changed to use Lucida Grande for Hebrew.
  • platform/win/Skipped: Re-categorized the above test. It is still failing on Windows, but due to a different bug.

Feb 1, 2008:

4:19 PM Changeset in webkit [29929] by beidson@apple.com
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Darin's rubberstamp

Move the SecurityOriginHash out into a separate header as it will soon be used in different places

  • WebCore.xcodeproj/project.pbxproj:
  • platform/SecurityOriginHash.h: Added. (WebCore::SecurityOriginHash::hash): (WebCore::SecurityOriginHash::equal): (WebCore::SecurityOriginTraits::deletedValue): (WebCore::SecurityOriginTraits::emptyValue):
  • storage/DatabaseTracker.cpp:
4:02 PM Changeset in webkit [29928] by mitz@apple.com
  • 7 edits
    1 move
    5 adds in trunk/LayoutTests

Reviewed by Dave Hyatt.

  • address the remaining tests listed under <rdar://problem/5075790> Layout tests that depend on certain fonts don't match Mac results
  • fast/text/cg-fallback-bolding.html: Changed to use Ahem instead of Geneva.
  • fast/text/international/bidi-fallback-font-weight.html: Made Mac-only.
  • platform/mac/fast/text/cg-fallback-bolding-expected.checksum: Updated.
  • platform/mac/fast/text/cg-fallback-bolding-expected.png: Updated
  • platform/mac/fast/text/cg-fallback-bolding-expected.txt: Updated.
  • platform/mac/fast/text/international/bidi-fallback-font-weight.html: Copied from LayoutTests/fast/text/international/bidi-fallback-font-weight.html.
  • platform/win/Skipped: Removed passing tests and categorized remaining failures.
  • platform/win/svg/W3C-SVG-1.1: Added.
  • platform/win/svg/W3C-SVG-1.1/resources: Added.
  • platform/win/svg/W3C-SVG-1.1/resources/Mac-compatible-font-fallback.css: Added.
  • platform/win/svg/W3C-SVG-1.1/resources/run-webkit-tests-epilogue.html: Added.
  • platform/win/svg/W3C-SVG-1.1/resources/run-webkit-tests-prologue.html: Added.
  • svg/text/text-tselect-02-f.svg: Added @font-face rule to use Lucida Grande for Hebrew.
2:18 PM Changeset in webkit [29927] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Tim.

  • fixed mistake in the JSLock fix that caused an assertion every time
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): Added JSLock. (WebCore::unprotectOnMainThread): Ditto.
1:51 PM Changeset in webkit [29926] by andersca@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Antti and Darin.

Change Text::createWithLengthLimit to take a UChar pointer instead of a string. This
lets us avoid making a copy of the buffer in TextDocument.cpp.


  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
  • dom/Text.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
1:35 PM Changeset in webkit [29925] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadsBlocked): Fix grammar and word typo.
1:33 PM Changeset in webkit [29924] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • fix <rdar://problem/4527931> showModalDialog calls from onload functions fail (Aspect)

No automated regression test because showModalDialog doesn't work in DumpRenderTree.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::CallbackGuard::CallbackGuard): Added. (WebCore::CallbackGuard::~CallbackGuard): Added. (WebCore::ResourceHandle::supportsBufferedData): Simplified to take advantage of how static initialization works in C++. (WebCore::ResourceHandle::loadsBlocked): Always return false on Leopard. The problem in NSURLConnection that created the need to block loads is fixed in Leoaprd. This is the bug fix. (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Use CallbackGuard instead of directly incrementing the count; allows us to omit the code entirely on Leopard. (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto. (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto. Fixes a problem where this could leave inNSURLConnectionCallback set permanently in one of the code paths; this would break showModalDialog from that point on. This problem doesn't affect Safari.
12:30 PM Changeset in webkit [29923] by Darin Adler
  • 2 edits in trunk/WebCore
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadsBlocked): Roll out accidentally checked in file.
12:28 PM Changeset in webkit [29922] by Darin Adler
  • 19 edits in trunk

WebCore:

Reviewed by Geoff and Brady.

  • fix <rdar://problem/5680469> Each database worker thread takes a JSLock, which slows down all JavaScript execution until the thread terminates
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): Explicitly gcProtect, since we aren't using ProtectedPtr any more. (WebCore::unprotectOnMainThread): Added. (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback): Use unprotectOnMainThread rather than doing a gcUnprotect here.
  • bindings/js/JSCustomSQLTransactionCallback.h: Changed m_callback from a ProtectedPtr to a plain old JSObject*; we gcProtect by hand now.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::notifyPendingLoadDecisionsOnMainThread): Renamed. Changed to takea a void* with the icon database pointer. (WebCore::IconDatabase::notifyPendingLoadDecisions): Renamed. (WebCore::IconDatabase::performURLImport): Updated name, and pass the icon database pointer in.
  • loader/icon/IconDatabase.h: Renamed and added void* parameter.
  • platform/Threading.h: Changed callOnMainThread to take a function with a single parameter rather than a function with no parameters. Added a typedef.
  • platform/gtk/ThreadingGtk.cpp: (WebCore::callFunctionOnMainThread): Changed to use a structure with both a function pointer and a context pointer, and delete it after calling. (WebCore::callOnMainThread): Changed to create the structure with both the function and context pointer.
  • platform/mac/Threading.mm: (-[WebCoreFunctionWrapper initWithFunction:context:]): Added context. (-[WebCoreFunctionWrapper invoke]): Updated to do both function and context. Renamed from _call. (WebCore::callOnMainThread): Updated to take both function and context.
  • platform/qt/ThreadingQt.cpp: (WebCore::PerformFunctionEvent::PerformFunctionEvent): Added context. (WebCore::PerformFunctionEvent::invoke): Added. Calls function with context pointer. (WebCore::MainThreadInvoker::event): Changed to call invoke. (WebCore::callOnMainThread): Updated to take both function and context.
  • platform/win/ThreadingWin.cpp: Added FunctionWithContext. (WebCore::callFunctionsOnMainThread): Changed to pass call function with context. (WebCore::callOnMainThread): Updated to queue both function and context.
  • platform/wx/ThreadingWx.cpp: (WebCore::callOnMainThread): Updated to take both function and context.
  • storage/Database.cpp: (WebCore::Database::scheduleTransactionCallback): Pass 0 for context. (WebCore::Database::deliverAllPendingCallbacks): Changed to take ignored context pointer.
  • storage/Database.h: Added void* parameter to deliverAllPendingCallbacks.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::scheduleForNotification): Pass 0 for context. (WebCore::DatabaseTracker::notifyDatabasesChanged): Changed to take ignored context pointer.
  • storage/DatabaseTracker.h: Added void* parameter to notifyDatabasesChanged.

WebKit/win:

  • fix <rdar://problem/5680469> Each database worker thread takes a JSLock, which slows down all JavaScript execution until the thread terminates
  • WebIconDatabase.cpp: (WebIconDatabase::scheduleNotificationDelivery): Updated for new callOnMainThread. (WebIconDatabase::deliverNotifications): Ditto.
  • WebIconDatabase.h: Ditto.
11:42 AM Changeset in webkit [29921] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-02-01 Jon Honeycutt <​jhoneycutt@apple.com>

Rubber-stamped by Ollie.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Fix two function pointers
11:39 AM Changeset in webkit [29920] by mitz@apple.com
  • 3 edits
    2 moves
    2 adds
    3 deletes in trunk/LayoutTests

Reviewed by Alexey Proskuryakov.

  • change fast/xsl/xslt-text to dump as text
  • fast/xsl/resources/xslt-text.xml: Copied from LayoutTests/fast/xsl/xslt-text.xml.
  • fast/xsl/resources/xslt-text.xsl: Copied from LayoutTests/fast/xsl/xslt-text.xsl.
  • fast/xsl/xslt-processor.html:
  • fast/xsl/xslt-text-expected.txt: Added.
  • fast/xsl/xslt-text.html: Added.
  • fast/xsl/xslt-text.xml: Removed.
  • fast/xsl/xslt-text.xsl: Removed.
  • platform/mac/fast/xsl/xslt-text-expected.checksum: Removed.
  • platform/mac/fast/xsl/xslt-text-expected.png: Removed.
  • platform/mac/fast/xsl/xslt-text-expected.txt: Removed.
  • platform/win/Skipped:
11:35 AM Changeset in webkit [29919] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan, Oliver Hunt.

Fixed <rdar://problem/5688039> REGRESSION (r29428): Weather widget
fails to load due to reliance on "var location" quirk


Added a Dashboard quirk.

  • bindings/js/kjs_window.cpp: (KJS::Window::put): In DB backwards compatibility mode, make assignment to window.location in top-level windows shadow the DOM location API instead of performing a navigation. This makes a reasonable amount of sense, because widgets can't navigate their top-level frames, anyway.
11:21 AM Changeset in webkit [29918] by hyatt@apple.com
  • 13 edits
    4 adds in trunk

WebCore:

Fix for bug 11387, CSS3 :empty selector is not dynamic.

Add support for dynamically updating elements whose style is affected by :empty when the child count changes.

Reviewed by olliej, mitzpettel

fast/css/empty-pseudo-class.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::checkOneSelector):
  • dom/Element.cpp: (WebCore::Element::childrenChanged):
  • dom/Element.h:
  • rendering/RenderStyle.h: (WebCore::RenderStyle::affectedByEmpty): (WebCore::RenderStyle::emptyState): (WebCore::RenderStyle::setEmptyState):

LayoutTests:

Add a new layout test for dynamic :empty selectors.

Reviewed by olliej

  • fast/css/empty-pseudo-class.html: Added.
  • platform/mac/fast/css/empty-pseudo-class-expected.checksum: Added.
  • platform/mac/fast/css/empty-pseudo-class-expected.png: Added.
  • platform/mac/fast/css/empty-pseudo-class-expected.txt: Added.
10:38 AM Changeset in webkit [29917] by sfalken@apple.com
  • 1 edit in trunk/WebKitLibraries/ChangeLog

Fix typo.

10:36 AM Changeset in webkit [29916] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

<rdar://problem/5717523> Don't set DEP opt-in flag (data execution prevention) since it is incompaible with the video plugin used on CNN.com


Rubber-stamped by John Honeycutt.

  • win/tools/vsprops/common.vsprops:
10:06 AM Changeset in webkit [29915] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

fast/text/international/thai-line-breaks.html results do not change.

  • rendering/break_lines.cpp: (WebCore::nextBreakablePosition): Changed to use Carbon only on Tiger.
9:45 AM Changeset in webkit [29914] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

2008-02-01 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Darin.

Update npfunctions.h to export the proper function signatures for UNIX and add
the appropriate #if around the Windows versions

  • plugins/npfunctions.h:
6:32 AM UsingWine edited by davidf@sjsoft.com
fixed link to nightly builds (diff)
5:20 AM UsingWine edited by davidf@sjsoft.com
rearranged scripts into separate ones per program (diff)
4:57 AM UsingWine created by davidf@sjsoft.com
added notes on running Safari with custom webkit under wine
1:35 AM Changeset in webkit [29913] by eric@webkit.org
  • 12 edits
    3 adds in trunk

Reviewed by Oliver.

Add getSVGDocument to frame and iframe.

Test: svg/custom/frame-getSVGDocument.html

  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::getSVGDocument):
  • html/HTMLFrameOwnerElement.h:
  • html/HTMLIFrameElement.idl:
  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
1:14 AM Changeset in webkit [29912] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

1:13 AM Changeset in webkit [29911] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.7

New tag.

12:00 AM Changeset in webkit [29910] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by darin.

Beat CSSParser with the RefPtr stick. Hopefully squashing any leaks in the process.
(Deploy RefPtr and PassRefPtr throughout CSSParser)
​http://bugs.webkit.org/show_bug.cgi?id=17108

No functional changes, thus no tests.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::addBackgroundValue): (WebCore::CSSParser::parseBackgroundShorthand): (WebCore::CSSParser::addTransitionValue): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseBackgroundPosition): (WebCore::CSSParser::parseBackgroundProperty): (WebCore::CSSParser::parseTransitionProperty): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::ShadowParseContext::ShadowParseContext): (WebCore::CSSParser::parseShadow): (WebCore::BorderImageParseContext::BorderImageParseContext): (WebCore::BorderImageParseContext::commitBorderImage):
  • css/CSSParser.h:
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):

Jan 31, 2008:

11:01 PM Changeset in webkit [29909] by alp@webkit.org
  • 4 edits
    1 move in trunk

2008-01-31 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Fix the pkg-config file to follow GTK+ package naming and versioning
conventions.

Remove unneeded dependency listings.

10:08 PM Changeset in webkit [29908] by oliver@apple.com
  • 2 edits in trunk/WebCore

Add platform/Locker.h to vcproj

RS=Brady

  • WebCore.vcproj/WebCore.vcproj:
8:31 PM Changeset in webkit [29907] by beidson@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • WebCore.xcodeproj/project.pbxproj: Header -> WebKit
8:02 PM Changeset in webkit [29906] by beidson@apple.com
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Maciej

Abstracted the concept of a "Locker" as upcoming work will rely on it.

  • platform/Locker.h: Added. Template class to "lock()" and "unlock()" some arbitrary object (WebCore::Locker::Locker): Lock the object (WebCore::Locker::~Locker): Unlock it
  • platform/Threading.h: class MutexLocker is now typedef Locker<Mutex>
  • WebCore.xcodeproj/project.pbxproj:
5:53 PM Changeset in webkit [29905] by kmccullough@apple.com
  • 15 edits
    10 deletes in trunk

WebCore:

<rdar://problem/5716912> REGRESSION (r29816): Can't navigate back to
Gmail Inbox from Gmail Compose page
Rolling out the change that caused the regression.

  • WebCore.base.exp:
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open):
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument):
  • dom/Document.cpp: (WebCore::Document::recalcStyle): (WebCore::Document::open): (WebCore::Document::write): (WebCore::Document::clear):
  • dom/Document.h:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • history/HistoryItem.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::load): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::tokenizerProcessedData): (WebCore::FrameLoader::post): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
  • platform/text/CharacterNames.h:
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseXML):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):

LayoutTests:

<rdar://problem/5716912> REGRESSION (r29816): Can't navigate back to
Gmail Inbox from Gmail Compose page
Rolling out the change that caused the regression.

  • http/tests/navigation/document-open-adds-history-item-expected.txt: Removed.
  • http/tests/navigation/document-open-adds-history-item.html: Removed.
  • http/tests/navigation/document-open-delayed-adds-history-item-expected.txt: Removed.
  • http/tests/navigation/document-open-delayed-adds-history-item.html: Removed.
  • http/tests/navigation/document-open-new-window-adds-history-item-expected.txt: Removed.
  • http/tests/navigation/document-open-new-window-adds-history-item.html: Removed.
  • http/tests/navigation/document-open-replace-no-history-item-expected.txt: Removed.
  • http/tests/navigation/document-open-replace-no-history-item.html: Removed.
  • http/tests/navigation/resources/document-open-page-2.html: Removed.
  • http/tests/navigation/resources/document-open.js: Removed.
5:03 PM Changeset in webkit [29904] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • re-categorize three skipped tests
  • platform/win/Skipped:
5:01 PM Changeset in webkit [29903] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix <rdar://5713172> Focus lost from Gmail message body after toggling
tabs

This regressed in r29583. Prior to r29583, the code path that resulted
in calling focusController->setFocusedFrame(0) was never getting hit.
r29583 changed the code to adhere to the comment above the code and
actually call setFocusedFrame(0) when losing focus to another part of
the window. It turns out this is wrong behavior (and not what
WebKit/mac does). The only time we should clear the focused frame is
when we tab out of the WebView, and that's already taken care of by
FocusController::advanceFocus. The code to clear the focused frame in
WebView was written before FocusController::advanceFocus, so it was
correct at one point but no longer is.

We now never call setFocusedFrame(0) when the WebView receives a
WM_KILLFOCUS message. Instead we just call setFocused(false) on the
focused frame so that blur events will be sent. This matches what
WebKit/mac does.

Reviewed by Darin and Adele.

  • WebView.cpp: (WebViewWndProc): Also reworded a couple of comments to make them clearer.
4:50 PM Changeset in webkit [29902] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 14960: Cannot copy text in Web Inspector Network panel
​http://bugs.webkit.org/show_bug.cgi?id=14960

  • page/inspector/inspector.css:
4:48 PM Changeset in webkit [29901] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 14514: Add full URL view on mouseOver in the network page
​http://bugs.webkit.org/show_bug.cgi?id=14514
<rdar://problem/5712841>

  • page/inspector/inspector.js:
4:35 PM Changeset in webkit [29900] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

Reviewed by Geoffrey Garen.

  • change the font used in fast/text/monospace-width-cache.html again to a font that contains the U+2500 character in Tiger too
  • fast/text/monospace-width-cache.html:
  • platform/mac/fast/text/monospace-width-cache-expected.checksum:
  • platform/mac/fast/text/monospace-width-cache-expected.png:
  • platform/mac/fast/text/monospace-width-cache-expected.txt:
4:00 PM Changeset in webkit [29899] by alp@webkit.org
  • 4 edits in trunk

Fix r29898 ChangeLog entries: rubber-stamped, not reviewed

3:51 PM Changeset in webkit [29898] by alp@webkit.org
  • 13 edits
    18 copies
    1 move in trunk

2008-01-31 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=17006
[GTK] Header path should be webkit/webkit.h

Move the GTK+ API sources as needed and update the build systems.

3:09 PM Changeset in webkit [29897] by weinig@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen.

No need to get the prototype just to compare compare property names.

  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customGetOwnPropertySlot):
1:37 PM Changeset in webkit [29896] by weinig@apple.com
  • 6 edits in trunk

WebCore:

Fix non-mac builds.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
1:06 PM Changeset in webkit [29895] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/lists
1:04 PM Changeset in webkit [29894] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/tables/mozilla/bugs
1:03 PM Changeset in webkit [29893] by hyatt@apple.com
  • 4 adds in trunk/LayoutTests
1:03 PM Changeset in webkit [29892] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for bug 17101.

List items need to ignore the line box shrinking quirk, since IE and Firefox both do.

Reviewed by Eric

fast/lists/list-item-line-height.html

  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox):
12:11 PM Changeset in webkit [29891] by mitz@apple.com
  • 26 edits in trunk/LayoutTests

Reviewed by Adam Roben.

  • change several tests that use Mac-only fonts to use fonts that are available on both Windows and Mac OS X
  • fast/text/monospace-width-cache.html:
  • platform/mac/fast/text/monospace-width-cache-expected.checksum:
  • platform/mac/fast/text/monospace-width-cache-expected.png:
  • platform/mac/fast/text/monospace-width-cache-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug10633-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug10633-expected.png:
  • platform/mac/tables/mozilla/bugs/bug10633-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug113424-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug113424-expected.png:
  • platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug23151-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug23151-expected.png:
  • platform/mac/tables/mozilla/bugs/bug23151-expected.txt:
  • platform/mac/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/mac/tables/mozilla/core/bloomberg-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug11331-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug11331-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug11331-expected.txt:
  • platform/win/Skipped:
  • tables/mozilla/bugs/bug10633.html:
  • tables/mozilla/bugs/bug113424.html:
  • tables/mozilla/bugs/bug23151.html:
  • tables/mozilla/core/bloomberg.html:
  • tables/mozilla_expected_failures/bugs/bug11331.html:
11:52 AM Changeset in webkit [29890] by weinig@apple.com
  • 15 edits
    2 moves
    8 adds in trunk

WebCore:

Reviewed by Darin Adler.

Fix for <rdar://problem/5708993> Mutability of the History object

  • Don't allow cross-domain get access to any of the history objects properties except the back(), forward() and go() methods.
  • Don't allow cross-domain put access to any of the history objects properties.
  • Don't allow cross-domain enumeration of the History or Location objects.

Tests: http/tests/security/cross-frame-access-history-get-override.html

http/tests/security/cross-frame-access-history-get.html
http/tests/security/cross-frame-access-history-put.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp: Remove unnessary KJS::'s (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut): (WebCore::JSDOMWindow::getPropertyNames): Moved implementation from KJS::Window now that the declaration is autogenerated using the new CustomGetPropertyNames. (WebCore::JSDOMWindow::postMessage):
  • bindings/js/JSHistoryCustom.cpp: Added. (WebCore::allowsAccessFromFrame): (WebCore::JSHistory::customGetOwnPropertySlot): Only allow getting the declared functions back(), forward() and go() from cross-domain. Deny all other gets. (WebCore::JSHistory::customPut): Don't allow putting cross-domain. (WebCore::JSHistory::getPropertyNames): Don't allow enumeration cross-domain.
  • bindings/js/JSLocation.cpp: (WebCore::allowsAccessFromFrame): (WebCore::JSLocation::getPropertyNames): Don't allow enumeration cross-domain.
  • bindings/js/JSLocation.h:
  • bindings/js/kjs_window.cpp:
  • bindings/js/kjs_window.h:
  • bindings/scripts/CodeGeneratorJS.pm: Add support for new CustomGetPropertNames extended attribute and changed the logic of CustomPutFunction to create an overrided put() function even if no read-write properties exist.
  • page/DOMWindow.idl: Added CustomGetPropertNames
  • page/History.idl: Added CustomGetPropertNames

LayoutTests:

Reviewed by Darin Adler.

Tests for <rdar://problem/5708993> Mutability of the History object

  • http/tests/security/cross-frame-access-enumeration-expected.txt:
  • http/tests/security/cross-frame-access-enumeration.html:
  • http/tests/security/cross-frame-access-history-expected.txt: Removed.
  • http/tests/security/cross-frame-access-history-get-expected.txt: Renamed from LayoutTests/http/tests/security/cross-frame-access-history-expected.txt.
  • http/tests/security/cross-frame-access-history-get-override-expected.txt: Added.
  • http/tests/security/cross-frame-access-history-get-override.html: Added.
  • http/tests/security/cross-frame-access-history-get.html: Renamed from LayoutTests/http/tests/security/cross-frame-access-history.html.
  • http/tests/security/cross-frame-access-history-put-expected.txt: Added.
  • http/tests/security/cross-frame-access-history-put.html: Added.
  • http/tests/security/cross-frame-access-history.html: Removed.
  • http/tests/security/resources/cross-frame-access.js:
  • http/tests/security/resources/cross-frame-iframe-for-enumeration-test.html:
  • http/tests/security/resources/cross-frame-iframe-for-history-get-override-test.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-history-get-test.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-history-put-test.html: Added.
11:01 AM Changeset in webkit [29889] by justin.garcia@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Darin Adler.


<rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail

  • page/mac/WebCoreFrameBridge.h: Re-exposed smartInsertForString:, it's used by a WebKit method used by Mail.

WebKit/mac:

Reviewed by Darin Adler.


<rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail

  • WebView/WebHTMLView.mm: (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought this back, it's used by Mail. (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is also used by Mail. Moved to WebPrivate.
  • WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't accidently remove them in the future.
10:50 AM Changeset in webkit [29888] by Adam Roben
  • 3 edits in trunk/WebCore

Add line box drawing code to InspectorController::drawNodeHighlight

This makes drawNodeHighlight a complete replacement for the painting
code in WebKit/mac/WebNodeHighlightView.mm, and also brings line box
rects to Windows for the first time.

Reviewed by Darin.

  • dom/Node.h: Changed isSVGElement to always exist, but to only be virtual when ENABLE(SVG) is true. This way you can always call node->isSVGElement() without checking ENABLE(SVG).
  • page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Ported line box rect code from the Mac implementation in WebNodeHighlightView.mm.
10:47 AM Changeset in webkit [29887] by Adam Roben
  • 7 edits in trunk

Let WebCore take care of the highlight drawing entirely

WebCore:

Put more knowledge about the node highlight in WebCore

InspectorController now calculates the overlay rect and node rect when
drawing the node highlight instead of having them be passed in.
InspectorController now holds onto the highlighted node so that it can
determine these rects.

Once all platforms are calling down to drawNodeHighlight instead of
drawing the highlight themselves, we can change
InspectorClient::highlight(Node*) to something like
InspectorClient::updateAndShowHighlight().

This also fixes Bug 14264: Node highlight makes it impossible to
scroll the page
<​http://bugs.webkit.org/show_bug.cgi?id=14264>
<rdar://5712788>

Reviewed by Darin.

  • page/InspectorController.cpp: (WebCore::InspectorController::highlight): Store the node for use in drawNodeHighlight. (WebCore::InspectorController::drawNodeHighlight): Changed to be a const instance method. Now calculates the overlay rect and node rect instead of having them passed in.
  • page/InspectorController.h:

WebKit/win:

Let WebCore take care of the highlight drawing entirely

Reviewed by Darin.

  • WebInspectorClient.cpp: (WebInspectorClient::highlight): We now just show our highlight window and let WebCore figure out what/where to paint. Once all ports follow suit the Node* parameter to this method should be removed entirely, and the name should probably change to updateAndShowHighlight or something similar.
  • WebNodeHighlight.cpp: Renamed m_webView to m_inspectedWebViewWindow. (WebNodeHighlight::WebNodeHighlight): Now takes a WebView* parameter. (WebNodeHighlight::show): Renamed from highlight(). Now gets the WebView's HWND. Updated for member rename/removal. (WebNodeHighlight::updateWindow): Updated for member rename and for InspectorController changes.
  • WebNodeHighlight.h: Added m_inspectedWebView member, removed m_rect member, renamed highlight(Node*) -> show().
10:44 AM Changeset in webkit [29886] by Adam Roben
  • 5 edits in trunk

Move node highlight drawing code to WebCore

WebCore:

Add node highlight drawing code to InspectorController

The code came from WebKit/win/WebNodeHighlight.cpp. It's not quite as
complete as the Mac implementation (in particular, it doesn't handle
line-box rects), but it's a start.

Reviewed by Darin.

  • page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Added.
  • page/InspectorController.h:

WebKit/win:

Move node highlight drawing code to WebCore

Reviewed by Darin.

  • WebNodeHighlight.cpp: (WebNodeHighlight::updateWindow): Call into WebCore to do the node highlight drawing.
10:34 AM Changeset in webkit [29885] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/block/float/intruding-painted-twice.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Pass 'false' for the new makeChildPaintOtherFloats parameter to addOverhangingFloats() because at this point we are only taking away floats from the child. (WebCore::RenderBlock::layoutBlockChildren): Pass 'true' for the new makeChildPaintOtherFloats parameter to addOverhangingFloats() iff the child was not laid out again. Only in that case, it may have overhanging floats that it does not paint because they used to be overhanging from the parent, but now they are not. (WebCore::RenderBlock::addOverhangingFloats): Refined the conditions for making the child paint the float: require that the float be a descendant of the child (the other case is when it intrudes into the child from another sibling) and that it does not have a layer (in which case it paints itself). In addition, do the check only if the caller passed 'true' for the makeChildPaintOtherFloats parameter.
  • rendering/RenderBlock.h:

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/block/float/intruding-painted-twice.html: Added.
  • platform/mac-leopard/fast/block/float/intruding-painted-twice-expected.checksum: Added.
  • platform/mac-leopard/fast/block/float/intruding-painted-twice-expected.png: Added.
  • platform/mac/fast/block/float/intruding-painted-twice-expected.txt: Added.

Jan 30, 2008:

9:39 PM Changeset in webkit [29884] by mitz@apple.com
  • 9 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • change the interpretation of unicode-range values in "from-to" form to include the "to" character.

Test: fast/css/font-face-unicode-range.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceUnicodeRange):
  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::overlayRange):
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
  • platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::fontDataForCharacter): (WebCore::SegmentedFontData::containsCharacters):

LayoutTests:

Reviewed by Sam Weinig.

  • add a test for the unicode-range @font-face property
  • update @font-face rules in existing tests after changing unicode-range values in "from-to" form to include the "to" character
  • fast/css/font-face-unicode-range.html: Added.
  • fast/css/rtl-ordering.html:
  • fast/text/international/resources/Mac-compatible-font-fallback.css:
  • platform/mac-leopard/fast/css/font-face-unicode-range-expected.checksum: Added.
  • platform/mac-leopard/fast/css/font-face-unicode-range-expected.png: Added.
  • platform/mac/fast/css/font-face-unicode-range-expected.txt: Added.
  • platform/win/css2.1/resources/Mac-compatible-font-fallback.css:
9:36 PM Changeset in webkit [29883] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • prune references to custom fonts' SimpleFontData from the glyph page tree when they are destroyed
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::pruneTable):
6:45 PM Changeset in webkit [29882] by justin.garcia@apple.com
  • 1 add
    1 delete in trunk/LayoutTests/editing/style

This test started failed with my last checkin. The new results are *correct* but I don't know why my changes would have fixed the test, so I want to investigate a bit before I check in new results.

5:45 PM Changeset in webkit [29881] by timothy@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

New fix for <rdar://problem/5688428> Reproducible assertion failure
in SQLTransaction::performNextStep() (16876)

Fixes a deadlock that was happening for all Database use. All
storage layout tests pass.

  • storage/Database.cpp: (WebCore::CurrentThreadSetter::CurrentThreadSetter): New helper class to set the current thread and zero it on destruction. (WebCore::CurrentThreadSetter::~CurrentThreadSetter): Set threadIdentifierStorage to 0. (WebCore::Database::Database): Set m_transactionStepThread to 0. (WebCore::Database::performTransactionStep): Set m_transactionStepThread to currentThread(). (WebCore::Database::scheduleTransactionCallback): Assert m_transactionStepThread is currentThread().
  • storage/Database.h: Add m_transactionStepThread for debug builds to track which thread performTransactionStep() was called on.
5:23 PM Changeset in webkit [29880] by Stephanie Lewis
  • 2 edits in trunk/WebKitTools

2008-01-30 Stephanie <Stephanie Lewis>

Reviewed by Geoff.

Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth. This should make it easier for the buildbots to track new leaks.

  • Scripts/run-webkit-tests:
4:55 PM Changeset in webkit [29879] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

ASSERTION FAILED: JSLock::lockCount() > 0 when opening the
Web Inspector on a page with a Database.

Fix the ASSERT by taking a JSLock before calling toJS().

  • page/InspectorController.cpp: (WebCore::InspectorController::addDatabaseScriptResource):
4:43 PM Changeset in webkit [29878] by Beth Dakin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5598609> CrashTracer: [USER] 626 crashes in
Safari at com.apple.WebCore: WebCore::FrameView::needsFullRepaint
const + 6

The real problem here is tracked by rdar://5598072, which is that
frames can lose sync between their view and their document when a
non-HTML view is loaded (such as bookmarks view or a PDF). That can
cause this crash if the layout timer fires before things have fixed
themselves. This fix turns an ASSERT in FrameView::layout() into an
early return to cause graceful failure until the root of the
problem is addressed.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
4:16 PM Changeset in webkit [29877] by justin.garcia@apple.com
  • 3 edits
    8 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5700414> REGRESSION (Adama-ToT): Selecting "Header 1" style in Leopard Server wiki inserts newline

  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): If the selected paragraph was empty, we may still need to call moveParagrah to remove the line break that holds that paragraph open because the new block of the requested type needs to to replace it.

LayoutTests:

Reviewed by Darin Adler.


<rdar://problem/5700414> REGRESSION (Adama-ToT): Selecting "Header 1" style in Leopard Server wiki inserts newline

  • editing/execCommand/5700414-1.html: Added.
  • editing/execCommand/5700414-2.html: Added.
  • platform/mac/editing/execCommand/5700414-1-expected.checksum: Added.
  • platform/mac/editing/execCommand/5700414-1-expected.png: Added.
  • platform/mac/editing/execCommand/5700414-1-expected.txt: Added.
  • platform/mac/editing/execCommand/5700414-2-expected.checksum: Added.
  • platform/mac/editing/execCommand/5700414-2-expected.png: Added.
  • platform/mac/editing/execCommand/5700414-2-expected.txt: Added.
2:26 PM Changeset in webkit [29876] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5688428> Reproducible assertion failure in SQLTransaction::performNextStep() (16876)

Revised fix to use the globalCallbackMutex() mutex and hold the mutex
for the entire function scope.

  • storage/Database.cpp: (WebCore::Database::performTransactionStep):
2:06 PM Changeset in webkit [29875] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Make ResourceTreeElement inherit the prototype of TreeElement.

  • page/inspector/Resource.js:
2:01 PM Changeset in webkit [29874] by jess@apple.com
  • 2 edits in trunk/WebKitSite

Reviewed by Tim Hatcher.

  • coding/coding-style.html: Adding a note about avoiding explicit nil/NO initialization of Objective-C instance variables.
1:56 PM Changeset in webkit [29873] by weinig@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Don't include SecurityOrigin.h in Document.h so that we can avoid massive
recompilation when changing the SecurityOrigin.

  • dom/Document.cpp: (WebCore::Document::setSecurityOrigin):
  • dom/Document.h:
12:38 PM Changeset in webkit [29872] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher and Brady.

<rdar://problem/5688428> Reproducible assertion failure in SQLTransaction::performNextStep() (16876)

  • storage/Database.cpp: (WebCore::Database::performTransactionStep): Do not perform the next transaction if a global callback is already scheduled.
11:40 AM Changeset in webkit [29871] by jhoneycutt@apple.com
  • 4 edits in trunk/WebCore

2008-01-30 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5669317> Crash closing pop up window with Real Player
content

Some RealPlayer versions hang on unload. To prevent this hang, don't
unload versions since the last known unloadable version.
<rdar://problem/5713147> tracks revisiting this when the bug in
RealPlayer is fixed and we can again unload the plug-in.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::compareFileVersion): Compare the plug-in's file version to the passed file version, returning -1, 0, or 1 if the plug-in's version is less than, equal to, or greater than the version passed. (WebCore::PluginPackageWin::isPluginBlacklisted): Use compareFileVersion()
  • plugins/win/PluginPackageWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks): If the plug-in version is newer than the last-known unloadable version, add the DontUnloadPlugin quirk
9:55 AM Changeset in webkit [29870] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

One more debug (external) fix.

  • DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal and Debug configurations.
4:14 AM Changeset in webkit [29869] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Move off deprecated NSTableView methods.

Reviewed by Oliver Hunt.

  • WebView/WebHTMLView.mm:

(-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
(-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
(-[WebTextCompleteController filterKeyDown:]): Ditto.

Jan 29, 2008:

9:26 PM Changeset in webkit [29868] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Look for headers relative to NEXT_ROOT so that build-root picks up the WebCoreSQLite version of sqlite3.h rather than the older system version.

Reviewed by Tim Hatcher.

9:10 PM Changeset in webkit [29867] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Dave Hyatt.

  • try to make this test more robust on slower machines
  • fast/css/font-face-remote.html:
8:32 PM Changeset in webkit [29866] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • loader/CachedFont.cpp: (WebCore::CachedFont::CachedFont):
8:03 PM Changeset in webkit [29865] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Add the correct directory to the header search paths in Production builds. Reviewed by Brady Eidson.

7:50 PM Changeset in webkit [29864] by mitz@apple.com
  • 6 edits
    5 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/css/font-face-remote.html

Added an isSVGFont method to CachedFont and use it to decide how to
process the font data. Currently whether the data is SVG is determined
based on the format property in the @font-face rule, but in the future
the MIME type or other metadata may be used when the format is
unspecified.

  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData): Changed to parse the data as SVG only if the CachedFont is an SVG font.
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Mark the CachedFont as an SVG font based on format.
  • loader/CachedFont.cpp: (WebCore::CachedFont::CachedFont): Initialize m_isSVGFont to false. (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::ensureSVGFontData): (WebCore::CachedFont::getSVGFontById):
  • loader/CachedFont.h: (WebCore::CachedFont::isSVGFont): Added. (WebCore::CachedFont::setSVGFont): Added.

LayoutTests:

Reviewed by Dave Hyatt.

This is the first @font-face test that actually tests loading font data
from a URL.

  • fast/css/font-face-remote.html: Added.
  • fast/css/resources/Ahem.ttf: Added.
  • platform/mac/fast/css/font-face-remote-expected.checksum: Added.
  • platform/mac/fast/css/font-face-remote-expected.png: Added.
  • platform/mac/fast/css/font-face-remote-expected.txt: Added.
7:43 PM Changeset in webkit [29863] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix a crash when opening the Inspector

Reviewed by Anders.

  • WebInspectorClient.cpp: (WebInspectorClient::createPage): Call WebPreferences::initWithIdentifier so our custom WebPreferences will have all its members initialized.
6:45 PM Changeset in webkit [29862] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix Bug 16786: "Display images when page opens" preference affects Inspector

<​http://bugs.webkit.org/show_bug.cgi?id=16786>
<rdar://5712914>

Reviewed by Anders and Darin.

  • WebInspectorClient.cpp: (WebInspectorClient::createPage): Create our own custom WebPreferences so that we won't be affected by global preference changes. This matches what Mac does.
6:38 PM Changeset in webkit [29861] by Antti Koivisto
  • 3 edits in trunk/WebCore

Some comment cleanup.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::load): (QTMovieWin::disableUnsupportedTracks):
6:00 PM Changeset in webkit [29860] by adele@apple.com
  • 1 edit
    108 deletes in trunk/LayoutTests

Reviewed by Oliver.

Remove pixel results for text-only tests that I mistakingly added.

  • platform/mac/media/audio-constructor-expected.checksum: Removed.
  • platform/mac/media/audio-constructor-expected.png: Removed.
  • platform/mac/media/audio-constructor-src-expected.checksum: Removed.
  • platform/mac/media/audio-constructor-src-expected.png: Removed.
  • platform/mac/media/broken-video-expected.checksum: Removed.
  • platform/mac/media/broken-video-expected.png: Removed.
  • platform/mac/media/constructors-expected.checksum: Removed.
  • platform/mac/media/constructors-expected.png: Removed.
  • platform/mac/media/fallback-expected.checksum: Removed.
  • platform/mac/media/fallback-expected.png: Removed.
  • platform/mac/media/progress-event-expected.checksum: Removed.
  • platform/mac/media/progress-event-expected.png: Removed.
  • platform/mac/media/remove-from-document-expected.checksum: Removed.
  • platform/mac/media/remove-from-document-expected.png: Removed.
  • platform/mac/media/unsupported-rtsp-expected.checksum: Removed.
  • platform/mac/media/unsupported-rtsp-expected.png: Removed.
  • platform/mac/media/unsupported-tracks-expected.checksum: Removed.
  • platform/mac/media/unsupported-tracks-expected.png: Removed.
  • platform/mac/media/video-append-source-expected.checksum: Removed.
  • platform/mac/media/video-append-source-expected.png: Removed.
  • platform/mac/media/video-autoplay-expected.checksum: Removed.
  • platform/mac/media/video-autoplay-expected.png: Removed.
  • platform/mac/media/video-buffered-expected.checksum: Removed.
  • platform/mac/media/video-buffered-expected.png: Removed.
  • platform/mac/media/video-controls-expected.checksum: Removed.
  • platform/mac/media/video-controls-expected.png: Removed.
  • platform/mac/media/video-currentTime-expected.checksum: Removed.
  • platform/mac/media/video-currentTime-expected.png: Removed.
  • platform/mac/media/video-currentTime-set-expected.checksum: Removed.
  • platform/mac/media/video-currentTime-set-expected.png: Removed.
  • platform/mac/media/video-currentTime-set2-expected.checksum: Removed.
  • platform/mac/media/video-currentTime-set2-expected.png: Removed.
  • platform/mac/media/video-dom-autoplay-expected.checksum: Removed.
  • platform/mac/media/video-dom-autoplay-expected.png: Removed.
  • platform/mac/media/video-dom-end-expected.checksum: Removed.
  • platform/mac/media/video-dom-end-expected.png: Removed.
  • platform/mac/media/video-dom-loopcount-expected.checksum: Removed.
  • platform/mac/media/video-dom-loopcount-expected.png: Removed.
  • platform/mac/media/video-dom-loopend-expected.checksum: Removed.
  • platform/mac/media/video-dom-loopend-expected.png: Removed.
  • platform/mac/media/video-dom-loopstart-expected.checksum: Removed.
  • platform/mac/media/video-dom-loopstart-expected.png: Removed.
  • platform/mac/media/video-dom-src-expected.checksum: Removed.
  • platform/mac/media/video-dom-src-expected.png: Removed.
  • platform/mac/media/video-dom-start-expected.checksum: Removed.
  • platform/mac/media/video-dom-start-expected.png: Removed.
  • platform/mac/media/video-end-expected.checksum: Removed.
  • platform/mac/media/video-end-expected.png: Removed.
  • platform/mac/media/video-error-abort-expected.checksum: Removed.
  • platform/mac/media/video-error-abort-expected.png: Removed.
  • platform/mac/media/video-error-does-not-exist-expected.checksum: Removed.
  • platform/mac/media/video-error-does-not-exist-expected.png: Removed.
  • platform/mac/media/video-load-networkState-expected.checksum: Removed.
  • platform/mac/media/video-load-networkState-expected.png: Removed.
  • platform/mac/media/video-load-readyState-expected.checksum: Removed.
  • platform/mac/media/video-load-readyState-expected.png: Removed.
  • platform/mac/media/video-loopcount-expected.checksum: Removed.
  • platform/mac/media/video-loopcount-expected.png: Removed.
  • platform/mac/media/video-loopend-expected.checksum: Removed.
  • platform/mac/media/video-loopend-expected.png: Removed.
  • platform/mac/media/video-loopstart-expected.checksum: Removed.
  • platform/mac/media/video-loopstart-expected.png: Removed.
  • platform/mac/media/video-muted-expected.checksum: Removed.
  • platform/mac/media/video-muted-expected.png: Removed.
  • platform/mac/media/video-no-autoplay-expected.checksum: Removed.
  • platform/mac/media/video-no-autoplay-expected.png: Removed.
  • platform/mac/media/video-pause-empty-events-expected.checksum: Removed.
  • platform/mac/media/video-pause-empty-events-expected.png: Removed.
  • platform/mac/media/video-play-empty-events-expected.checksum: Removed.
  • platform/mac/media/video-play-empty-events-expected.png: Removed.
  • platform/mac/media/video-play-pause-events-expected.checksum: Removed.
  • platform/mac/media/video-play-pause-events-expected.png: Removed.
  • platform/mac/media/video-play-pause-exception-expected.checksum: Removed.
  • platform/mac/media/video-play-pause-exception-expected.png: Removed.
  • platform/mac/media/video-poster-expected.checksum: Removed.
  • platform/mac/media/video-poster-expected.png: Removed.
  • platform/mac/media/video-seek-past-end-paused-expected.checksum: Removed.
  • platform/mac/media/video-seek-past-end-paused-expected.png: Removed.
  • platform/mac/media/video-seek-past-end-playing-expected.checksum: Removed.
  • platform/mac/media/video-seek-past-end-playing-expected.png: Removed.
  • platform/mac/media/video-seekable-expected.checksum: Removed.
  • platform/mac/media/video-seekable-expected.png: Removed.
  • platform/mac/media/video-seeking-expected.checksum: Removed.
  • platform/mac/media/video-seeking-expected.png: Removed.
  • platform/mac/media/video-size-expected.checksum: Removed.
  • platform/mac/media/video-size-expected.png: Removed.
  • platform/mac/media/video-source-expected.checksum: Removed.
  • platform/mac/media/video-source-expected.png: Removed.
  • platform/mac/media/video-source-media-expected.checksum: Removed.
  • platform/mac/media/video-source-media-expected.png: Removed.
  • platform/mac/media/video-source-type-expected.checksum: Removed.
  • platform/mac/media/video-source-type-expected.png: Removed.
  • platform/mac/media/video-src-change-expected.checksum: Removed.
  • platform/mac/media/video-src-change-expected.png: Removed.
  • platform/mac/media/video-src-expected.checksum: Removed.
  • platform/mac/media/video-src-expected.png: Removed.
  • platform/mac/media/video-src-remove-expected.checksum: Removed.
  • platform/mac/media/video-src-remove-expected.png: Removed.
  • platform/mac/media/video-src-set-expected.checksum: Removed.
  • platform/mac/media/video-src-set-expected.png: Removed.
  • platform/mac/media/video-src-source-expected.checksum: Removed.
  • platform/mac/media/video-src-source-expected.png: Removed.
  • platform/mac/media/video-start-expected.checksum: Removed.
  • platform/mac/media/video-start-expected.png: Removed.
  • platform/mac/media/video-volume-expected.checksum: Removed.
  • platform/mac/media/video-volume-expected.png: Removed.
  • platform/mac/media/video-width-height-expected.checksum: Removed.
  • platform/mac/media/video-width-height-expected.png: Removed.
5:40 PM Changeset in webkit [29859] by adele@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Antti.

Fix for <rdar://5683527> media/{audio,videocontrols-rendering.html failing


  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::isControlStyled): Don't treat all media controls as styled. This causes builds with an old version of SafariTheme to have different metrics for these controls.

LayoutTests:

Reviewed by Antti.

Removing test from Skipped list for <rdar://5683527> media/{audio,videocontrols-rendering.html failing


  • platform/win/Skipped:
4:52 PM Changeset in webkit [29858] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • re-add a couple of tests that are still failing back to the list
  • platform/win/Skipped:
4:28 PM Changeset in webkit [29857] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • make Font instances cache their primary font
  • WebCore.base.exp:
  • platform/graphics/Font.cpp: (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::cachePrimaryFont): (WebCore::Font::update):
  • platform/graphics/Font.h: (WebCore::Font::primaryFont):
4:18 PM Changeset in webkit [29856] by ggaren@apple.com
  • 25 edits
    2 adds in trunk

WebKitTools:

Reviewed by Sam Weinig. Sam Weinig.


Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
fails when run after fast/dom/Window/window-property-shadowing.html (16902)

Modified our policy delegates not to output window.name. Since a
previous test may have explicitly set window.name, we can't rely on its
implicit value in test results.

  • DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
  • DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::decidePolicyForNavigationAction):

LayoutTests:

Reviewed by Sam Weinig. Sam Weinig.


Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
fails when run after fast/dom/Window/window-property-shadowing.html (16902)

These layout tests demonstrate the expected behavior of window.name,
including the fact that one test can change the window.name value seen
by another test:

  • fast/dom/Window/window-property-shadowing-name-expected.txt: Added.
  • fast/dom/Window/window-property-shadowing-name.html: Added.
  • fast/dom/Window/window-property-clearing-expected.txt:
  • fast/dom/Window/window-property-clearing.html:


Modified these expected results not to depend on window.name. Since a
previous test may have explicitly set window.name, we can't rely on its
implicit value:

  • fast/encoding/mailto-always-utf-8-expected.txt:
  • fast/forms/mailto/advanced-get-expected.txt:
  • fast/forms/mailto/advanced-put-expected.txt:
  • fast/forms/mailto/get-multiple-items-expected.txt:
  • fast/forms/mailto/get-multiple-items-text-plain-expected.txt:
  • fast/forms/mailto/get-multiple-items-x-www-form-urlencoded-expected.txt:
  • fast/forms/mailto/get-non-ascii-always-utf-8-expected.txt:
  • fast/forms/mailto/get-non-ascii-expected.txt:
  • fast/forms/mailto/get-non-ascii-text-plain-expected.txt:
  • fast/forms/mailto/get-non-ascii-text-plain-latin-1-expected.txt:
  • fast/forms/mailto/get-overwrite-query-expected.txt:
  • fast/forms/mailto/post-append-query-expected.txt:
  • fast/forms/mailto/post-multiple-items-expected.txt:
  • fast/forms/mailto/post-multiple-items-multipart-form-data-expected.txt:
  • fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
  • fast/forms/mailto/post-multiple-items-x-www-form-urlencoded-expected.txt:
  • fast/forms/mailto/post-text-plain-expected.txt:
  • fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
  • http/tests/security/feed-urls-from-remote-expected.txt:
4:16 PM Changeset in webkit [29855] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Leopard build fix
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
4:13 PM Changeset in webkit [29854] by mrowe@apple.com
  • 8 edits
    4 adds in trunk

<rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).

Reviewed by Tim Hatcher.

3:03 PM Changeset in webkit [29853] by mitz@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Adam Roben and Oliver Hunt.

  • fix <rdar://problem/5713131> REGRESSION (r29246): Many SVG font tests are failing
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): Use double instead of float for consistent rounding behavior between Mac OS X and Windows.

LayoutTests:

Reviewed by Adam Roben and Oliver Hunt.

  • remove skipped tests after fixing <rdar://problem/5713131> REGRESSION (r29246): Many SVG font tests are failing
  • platform/win/Skipped:
3:03 PM Changeset in webkit [29852] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Refactor ChangeLog path code

Reviewed by Adam.

  • Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract duplicate code in another foreach() loop.
2:33 PM Changeset in webkit [29851] by Adam Roben
  • 5 edits in trunk

Fix <rdar://5713302> Web Inspector on Windows is not using the localized strings

WebCore:

Fix <rdar://5713302> Web Inspector on Windows is not using the
localized strings

Reviewed by Steve.

  • WebCore.vcproj/WebCore.vcproj: Copy InspectorLocalizedStrings.js to $WebKitOutputDir.
  • page/InspectorController.cpp: Touch this to force the project to build.

WebKit/win:

Fix <rdar://5713302> Web Inspector on Windows is not using the
localized strings

Reviewed by Steve.

  • WebInspectorClient.cpp: (getWebKitBundle): Added. (WebInspectorClient::createPage): Call getWebKitBundle. (WebInspectorClient::localizedStringsURL): Implemented.
2:22 PM Changeset in webkit [29850] by eric@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Nikolas.

Acid3 after double-attach
​http://bugs.webkit.org/show_bug.cgi?id=17058

I believe SVGTextPathElement::buildPendingResource() was entirely
bogus, removing it did not cause any tests to fail.

Test: svg/custom/textPath-assert.svg

  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::insertedIntoDocument): remove buildPendingResource()
  • svg/SVGTextPathElement.h:
1:35 PM Changeset in webkit [29849] by Adam Roben
  • 2 edits in trunk/WebCore

Fix Bug 16234: Inspector should support searching for elements by CSS selectors

<​http://bugs.webkit.org/show_bugs.cgi?id=16234>
<rdar://5712862>

Reviewed by Tim.

  • page/inspector/inspector.js: Use Document.querySelectorAll to search for elements by CSS selector. Also store a custom property on nodes being added to the search results to avoid showing the same node more than once.
12:20 PM Changeset in webkit [29848] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added new failures.
11:55 AM Changeset in webkit [29847] by Adam Roben
  • 2 edits in trunk/WebCore

Fix <rdar://5711136> Full-screen Flash on 1up.com is unresponsive

Reviewed by Anders and Darin.

No test possible.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::wndProc): Set/release capture on mouse down/up, like Firefox does.
9:18 AM Changeset in webkit [29846] by ap@webkit.org
  • 6 edits in trunk

Reviewed by Darin.

<rdar://problem/5710692> All storage tests fail/crash

WebKit:

  • WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Clients that do not implement database quota callbacks should have no database support - but not crash.

WebKitTools:

  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an arbitrary quota of 5 megabytes.

(-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
(-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
Removed unused (I think) code.


  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported. (UIDelegate::webViewPainted): A stub implementation. (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
  • DumpRenderTree/win/UIDelegate.h:
3:47 AM Changeset in webkit [29845] by ap@webkit.org
  • 2 edits in trunk/WebKitLibraries

Debug (external) build fix.

Removed _DEBUG preprocessor definition, which indicates that debug libraries are used (while they aren't).
This preprocessor definition is automatically set by Visual Studio as needed anyway.

  • win/tools/vsprops/debug.vsprops:

Jan 28, 2008:

9:32 PM Changeset in webkit [29844] by mitz@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • make isSVGFont non-virtual
  • platform/graphics/FontData.h:
  • platform/graphics/SegmentedFontData.cpp:
  • platform/graphics/SegmentedFontData.h:
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::isSVGFont):
6:05 PM Changeset in webkit [29843] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • fix <rdar://problem/5700824> Chunky scrolling + scrolling artifacts @ netflix.com/Notebook
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::valueChanged): Send the scroll event before updating the window, thus giving event handlers a chance to update layout for the new scroll position, eliminating the jitter.
6:03 PM Changeset in webkit [29842] by eric@webkit.org
  • 2 edits
    1 copy
    4 adds in trunk/JavaScriptGlue

Reviewed by darin.


Add icu headers to JSG in preparation for depending on ::UChar.

  • Configurations/Base.xcconfig:
  • ForwardingHeaders/wtf/unicode: Added.
  • ForwardingHeaders/wtf/unicode/Unicode.h: Added.
  • ForwardingHeaders/wtf/unicode/icu: Added.
  • ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Added.
  • icu: Copied from ../JavaScriptCore/icu.
5:55 PM Changeset in webkit [29841] by Adam Roben
  • 2 edits in trunk/WebCore

Fix <rdar://5555260> Gmail doesn't load when a user stylesheet is specified

Reviewed by Darin.

A null value exception was being thrown in Gmail's JS code because a
call to document.write failed. document.write failed because
Document::close had not yet been called. Document::close was not
called because the Document was considered to not be "complete" in
FrameLoader::checkComplete because the user stylesheet was in the
process of loading. The user stylesheet was loading because it had
previously been evicted from the cache and was loading fresh from
disk. It had been evicted from the cache because the calculation of
the expiration date was incorrectly casting/overflowing in
ResourceResponseCFNet.cpp.

We now calculate the expiration date in a way that does not cause us
to overflow a time_t, and we correctly clamp the value to the range of
a time_t. I also made the fix for the last modified date, though that
was not causing any bug I am aware of.

In the long-term it seems like whether or not Document::close is
called should not be dependent upon whether the user stylesheet has
finished loading or not.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::toTimeT): Added. Converts from CFAbsoluteTime to time_t and clamps to the range of time_t. (WebCore::ResourceResponse::doUpdateResourceResponse): Call toTimeT.
4:41 PM Changeset in webkit [29840] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann.

  • fix leaks introduced in r29838
  • svg/SVGFont.cpp: (WebCore::floatWidthMissingGlyphCallback): (WebCore::drawTextMissingGlyphCallback):
3:37 PM Changeset in webkit [29839] by Nikolas Zimmermann
  • 23 edits
    5 adds in trunk

Reviewed by Eric, Dan & Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=16980

Support external SVG Fonts, by reusing the custom font handling logic.
This enables us - as first engine - to render HTML pages using SVG Fonts.

Fixes fonts-elem-03-b.svg / fonts-elem-04-b.svg / fonts-elem-07-b.svg
Add new testcase svg-fonts-in-html.html.

2:47 PM Changeset in webkit [29838] by mitz@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Adam Roben.

  • fix svg/W3C-SVG-1.1/fonts-glyph-04-t.svg failure on Windows

The results differed between Mac OS X and Windows because the code was
using a 0-size font, which Mac OS X changes to 12pt.

  • svg/SVGFont.cpp: (WebCore::floatWidthMissingGlyphCallback): Use the font description of the primary font to initialize the fallback font. (WebCore::drawTextMissingGlyphCallback): Ditto.

LayoutTests:

Reviewed by Adam Roben.

  • updated results for a test that was failing on Windows
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
1:30 PM Changeset in webkit [29837] by eric@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann.

Use class instead of struct to appease MSVC.

  • history/HistoryItem.h:
  • loader/FrameLoaderClient.h:
  • page/InspectorController.h:
  • platform/network/ResourceRequestBase.h:
  • platform/network/mac/ResourceRequest.h:
12:50 PM Changeset in webkit [29836] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

Rubber-stamped by Darin Adler.

  • Fix whitespace in nodes.h/cpp and nodes2string.cpp.

(NOTE: Specific changed functions elided for space and clarity)

  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp:
12:04 PM Changeset in webkit [29835] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

<rdar://problem/5667017> storage/execute-sql-args.html failing -- openDatabase returning null on buildbot

  • platform/win/Skipped: Removed a passing test.
9:40 AM Changeset in webkit [29834] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/dynamic/float-no-longer-overhanging.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverhangingFloats): If a child's float turns out not to be overhanging at this time, ensure that the child paints it.

LayoutTests:

Reviewed by Darin Adler.

  • fast/dynamic/float-no-longer-overhanging.html: Added.
  • platform/mac/fast/dynamic/float-no-longer-overhanging-expected.checksum: Added.
  • platform/mac/fast/dynamic/float-no-longer-overhanging-expected.png: Added.
  • platform/mac/fast/dynamic/float-no-longer-overhanging-expected.txt: Added.
3:19 AM Changeset in webkit [29833] by oliver@apple.com
  • 2 edits in trunk/WebCore

More wx fixes

2:43 AM Changeset in webkit [29832] by oliver@apple.com
  • 3 edits in trunk

And another Wx build fix

2:34 AM Changeset in webkit [29831] by oliver@apple.com
  • 3 edits in trunk/LayoutTests

Due to a difference between the collision bounds for paths
in different versions of CG these tests need modiifed to
pass on tiger and leopard.

RS=Mark

1:23 AM Changeset in webkit [29830] by oliver@apple.com
  • 2 edits in trunk/WebCore

Yet another Wx build fix

12:31 AM Changeset in webkit [29829] by oliver@apple.com
  • 2 edits in trunk/WebCore

Wx build fix

12:18 AM Changeset in webkit [29828] by oliver@apple.com
  • 2 edits in trunk/WebCore

Gtk build fix

Jan 27, 2008:

11:04 PM Changeset in webkit [29827] by oliver@apple.com
  • 11 edits
    3 adds in trunk

Bug 16629: <canvas> does not support isPointInPath()

Reviewed by Sam Weinig.

Relatively trivial change to implement pointInPath and add
it to the bindings. Most of this patch is the addition of
GraphicsContext::getCTM() by pulling the various platform
implementations from CanvasRenderingContext2D::willDraw

Test: fast/canvas/pointInPath.html

9:02 PM Changeset in webkit [29826] by ap@webkit.org
  • 6 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=17014
REGRESSION: EUC-CN code A3A0 is mapped to U+E5E5 instead of U+3000

Test: fast/encoding/char-decoding.html

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode): Added a workaround that we used to have in Mac code.
  • platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode): Corrected a comment.
4:14 PM Changeset in webkit [29825] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=17025
nodes.h/cpp has been rolling around in the mud - lets hose it down

  • Rename member variables to use the m_ prefix.

(NOTE: Specific changed functions elided for space and clarity)

  • kjs/grammar.y:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp:
4:04 PM Changeset in webkit [29824] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-01-27 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17029
Use of deprecated class function but declares GTK_DISABLE_DEPRECATED

Sync gtkdrawing.h (1.51) and gtk2drawing.c (1.71) from Mozilla
upstream.

Adapt RenderThemeGtk.cpp to track minor changes.

3:24 PM Changeset in webkit [29823] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-01-27 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

GTK+ DRT build fix for breakage introduced in r29822.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setPersistentUserStyleSheetLocation): (LayoutTestController::clearPersistentUserStyleSheet):
12:00 PM Changeset in webkit [29822] by mitz@apple.com
  • 12 edits
    5 adds in trunk

WebKitTools:

Reviewed by Darin Adler.

  • add support for directory prologues and epilogues to run-webkit-tests
  • allow setting a persistent user style sheet in DumpRenderTree
  • activate the WebKit Layout Tests font in Windows DumpRenderTree
  • DumpRenderTree/LayoutTestController.cpp: (clearPersistentUserStyleSheetCallback): Added. (setPersistentUserStyleSheetLocationCallback): Added. (LayoutTestController::staticFunctions): Added. clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (setPersistentUserStyleSheetLocation): Added. (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet to the set of things this function resets. Now it either disables the user style sheet or sets it to the persistent user style sheet and enables it.
  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setPersistentUserStyleSheetLocation): Added. (LayoutTestController::clearPersistentUserStyleSheet): Added.
  • DumpRenderTree/win/DumpRenderTree.cpp: (setPersistentUserStyleSheetLocation): Added. (initialize): Added the WebKit Layout Tests font to the set of fonts to install. (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setPersistentUserStyleSheetLocation): Added. (LayoutTestController::clearPersistentUserStyleSheet): Added.
  • Scripts/run-webkit-tests: Changed to look for, and if found process in DumpRenderTree, files named run-webkit-tests-prologue.html and run-webkit-tests-epilogue.html in the resources subdirectory of any test directory and platform test results directory. The prologues are processed before the first test from the directory (and its subdirectories) is run, and the epilogues are processed after the last test from the directory is run. Platform-specific prologues and epilogues are processed in order of specificity.

LayoutTests:

Reviewed by Darin Adler.

  • make some CSS2.1 tests pass on Windows by using @font-face to force font fallback to match Mac OS X.
  • platform/win/Skipped:
  • platform/win/css2.1: Added.
  • platform/win/css2.1/resources: Added.
  • platform/win/css2.1/resources/Mac-compatible-font-fallback.css: Added.
  • platform/win/css2.1/resources/run-webkit-tests-epilogue.html: Added.
  • platform/win/css2.1/resources/run-webkit-tests-prologue.html: Added.
11:49 AM Changeset in webkit [29821] by alp@webkit.org
  • 11 edits
    4 adds in trunk

2008-01-27 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=14811
[gtk] [request] add a webkit_gtk_page_go_to_history_item function

2:17 AM Changeset in webkit [29820] by Darin Adler
  • 2 edits in trunk/LayoutTests
  • http/tests/security/cross-frame-access-put-expected.txt: Updated again. Not sure why, but I generated a different result the first time I tried. I suspect this test gives different results depending on what other tests are run with it.
1:55 AM Changeset in webkit [29819] by Darin Adler
  • 4 edits in trunk/LayoutTests
  • updated some test results I missed that were affected by my fix for bug 16498
  • fast/dom/xmlhttprequest-get-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • plugins/inner-html-display-none-expected.txt:
1:38 AM Changeset in webkit [29818] by Darin Adler
  • 11 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

  • fix <rdar://problem/5657450> REGRESSION: const is broken

Test: fast/js/const.html

SunSpider said this was 0.3% slower. And I saw some Shark samples in
JSGlobalObject::put -- not a lot but a few. We may be able to regain the
speed, but for now we will take that small hit for correctness sake.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::put): Pass the checkReadOnly flag in to symbolTablePut instead of passing attributes.
  • kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTablePut): Removed the code to set attributes here, since we only set attributes when creating a property. Added the code to check read-only here, since we need that to implement const!
  • kjs/function.cpp: (KJS::ActivationImp::put): Pass the checkReadOnly flag in to symbolTablePut instead of passing attributes.
  • kjs/nodes.cpp: (KJS::isConstant): Added. (KJS::PostIncResolveNode::optimizeVariableAccess): Create a PostIncConstNode if optimizing for a local variable and the variable is constant. (KJS::PostDecResolveNode::optimizeVariableAccess): Ditto. But PostDecConstNode. (KJS::PreIncResolveNode::optimizeVariableAccess): Ditto. But PreIncConstNode. (KJS::PreDecResolveNode::optimizeVariableAccess): Ditto. But PreDecConstNode. (KJS::PreIncConstNode::evaluate): Return the value + 1. (KJS::PreDecConstNode::evaluate): Return the value - 1. (KJS::PostIncConstNode::evaluate): Return the value converted to a number. (KJS::PostDecConstNode::evaluate): Ditto. (KJS::ReadModifyResolveNode::optimizeVariableAccess): Create a ReadModifyConstNode if optimizing for a local variable and the variable is constant. (KJS::AssignResolveNode::optimizeVariableAccess): Ditto. But AssignConstNode. (KJS::ScopeNode::optimizeVariableAccess): Pass the local storage to the node optimizeVariableAccess functions, since that's where we need to look to figure out if a variable is constant. (KJS::FunctionBodyNode::processDeclarations): Moved the call to optimizeVariableAccess until after localStorage is set up. (KJS::ProgramNode::processDeclarations): Ditto.
  • kjs/nodes.h: Fixed the IsConstant and HasInitializer values. They are used as flag masks, so a value of 0 will not work for IsConstant. Changed the first parameter to optimizeVariableAccess to be a const reference to a symbol table and added a const reference to local storage. Added classes for const versions of local variable access: PostIncConstNode, PostDecConstNode, PreIncConstNode, PreDecConstNode, ReadModifyConstNode, and AssignConstNode.
  • kjs/object.cpp: (KJS::JSObject::put): Tweaked comments a bit, and changed the checkReadOnly expression to match the form used at the two other call sites.

LayoutTests:

Reviewed by Oliver.

  • tests for <rdar://problem/5657450> REGRESSION: const is broken
  • fast/js/const-expected.txt: Updated with results that express success rather than failure, and to include the many new tests I added.
  • fast/js/kde/const-expected.txt: Ditto.
  • fast/js/resources/const.js: Added many new tests, covering the various cases of const in globals, function locals, the slow case inside eval, the different node types, and the values of the expressions.
12:54 AM Changeset in webkit [29817] by Darin Adler
  • 17 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

Test: fast/js/function-names.html

  • kjs/array_object.cpp: (KJS::ArrayObjectImp::ArrayObjectImp): Use the class name as the constructor's function name.
  • kjs/bool_object.cpp: (KJS::BooleanObjectImp::BooleanObjectImp): Ditto.
  • kjs/date_object.cpp: (KJS::DateObjectImp::DateObjectImp): Ditto.
  • kjs/error_object.cpp: (KJS::ErrorPrototype::ErrorPrototype): Make the error object be an Error. (KJS::ErrorObjectImp::ErrorObjectImp): Use the class name as the constructor's function name. (KJS::NativeErrorPrototype::NativeErrorPrototype): Take const UString&. (KJS::NativeErrorImp::NativeErrorImp): Use the prototype's name as the constructor's function name.
  • kjs/error_object.h: Change ErrorPrototype to inherit from ErrorInstance. Change the NativeErrorImp constructor to take a NativeErrorPrototype pointer for its prototype.
  • kjs/function.h: Removed unneeded constructor for internal functions without names. We want to avoid those!
  • kjs/function_object.cpp: (KJS::functionProtoFuncToString): Removed code that writes out just [function] for functions that have no names. There's no reason to do that. (KJS::FunctionObjectImp::FunctionObjectImp): Use the class name as the constructor's function name.
  • kjs/internal.cpp: Removed the unused constructor.
  • kjs/number_object.cpp: (KJS::fractionalPartToString): Marked static for internal linkage. (KJS::exponentialPartToString): Ditto. (KJS::numberProtoFuncToPrecision): Removed an unneeded else. (KJS::NumberObjectImp::NumberObjectImp): Use the class name as the constructor's function name. (KJS::NumberObjectImp::getValueProperty): Tweaked formatting.
  • kjs/object_object.cpp: (KJS::ObjectObjectImp::ObjectObjectImp): Use "Object" for the function name.
  • kjs/regexp_object.cpp: (KJS::RegExpObjectImp::RegExpObjectImp): Use "RegExp" for the function name.
  • kjs/string_object.cpp: (KJS::StringObjectImp::StringObjectImp): Use the class name as the constructor's function name.

LayoutTests:

Reviewed by Oliver.

  • fast/js/function-names-expected.txt: Updated for new tests.
  • fast/js/kde/resources/function.js: Updated test to expect the format that Gecko uses for native code, which we now match character for character.
  • fast/js/resources/function-names.js: Added tests for the names of all the constructors.
12:48 AM Changeset in webkit [29816] by Darin Adler
  • 15 edits
    10 adds in trunk

WebCore:

Reviewed and tweaked quite a bit by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14959
No back forward entry added for pages created in javascript

A new HistoryItem is created for calls to Document::open. Calls to
Document::write save the written data to a SharedBuffer that is also
stored on the HistoryItem. When the user navigates back to a
HistoryItem that has a valid buffer, that data is used for the page
content.

Tests: http/tests/navigation/document-open-adds-history-item.html

http/tests/navigation/document-open-delayed-adds-history-item.html
http/tests/navigation/document-open-new-window-adds-history-item.html
http/tests/navigation/document-open-replace-no-history-item.html

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): Pass a MIME type of either "text/html" or "text/plain" and a boolean for "replace" in rather than always setting replace to true and the MIME type to "text/html".
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument): Pass in MIME type and replace boolean explicitly, since we don't want to rely on Document::open()'s default.
  • dom/Document.cpp: (WebCore::Document::open): Correctly determine the "replace" boolean. Pass along the MIME type, replace boolean, and shared buffer to the frame loader's didExplicitOpen function. (WebCore::Document::write): Pass MIME type and replace boolean explicitly to the open function so we don't do treat it as replace if you write without an open. Store text written by the script so it can be used later for history. (WebCore::Document::clear): Drop the text written byt he script.
  • dom/Document.h: Added MIME type and replace boolean parameters for open. Had to keep the old version for the sake of DOM bindings. Added the shared buffer used for text written by script.
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): Copy m_substituteData. (WebCore::HistoryItem::substituteData): Added. (WebCore::HistoryItem::setSubstituteData): Added.
  • history/HistoryItem.h: Added m_substituteData, getter, and setter.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen): Added code to create or update the history item, including attaching the shared buffer that will contain all the data written by script. (WebCore::FrameLoader::load): Added a SubstituteData parameter, passed through when creating the document loader. (WebCore::FrameLoader::reloadAllowingStaleData): Create the document loader with the substitute data from the current history item. (WebCore::FrameLoader::reload): Ditto. (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): If the current history item has substitute data, then consider the URL from the substitute data rather than the one in the history item itself. (WebCore::FrameLoader::loadItem): Pass in the history item's substitute data.
  • loader/FrameLoader.h: Added parameters to load and didExplicitOpen.
  • platform/text/CharacterNames.h: Added byteOrderMark, and also added it under its other official name, zeroWidthNoBreakSpace.
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString): Pass in MIME type and replace boolean explicitly, since we don't want to rely on Document::open()'s default.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Ditto.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Ditto.

LayoutTests:

Reviewed by Darin.

Test cases for fix to ​http://bugs.webkit.org/show_bug.cgi?id=14959
No back forward entry added for pages created in javascript.

  • http/tests/navigation/document-open-adds-history-item-expected.txt: Added.
  • http/tests/navigation/document-open-adds-history-item.html: Added.
  • http/tests/navigation/document-open-delayed-adds-history-item-expected.txt: Added.
  • http/tests/navigation/document-open-delayed-adds-history-item.html: Added.
  • http/tests/navigation/document-open-new-window-adds-history-item-expected.txt: Added.
  • http/tests/navigation/document-open-new-window-adds-history-item.html: Added.
  • http/tests/navigation/document-open-replace-no-history-item-expected.txt: Added.
  • http/tests/navigation/document-open-replace-no-history-item.html: Added.

Jan 26, 2008:

8:21 PM Changeset in webkit [29815] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

Test: fast/js/function-toString-parentheses.html

The problem here was that a NumberNode with a negative number in it had the wrong
precedence. It's not a primary expression, it's a unary operator with a primary
expression after it.

Once the precedence of NumberNode was fixed, the cases from bug 17020 were also
fixed without trying to treat bracket nodes like dot nodes. That wasn't needed.
The reason we handle numbers before dot nodes specially is that the dot is a
legal character in a number. The same is not true of a bracket. Eventually we
could get smarter, and only add the parentheses when there is actual ambiguity.
There is none if the string form of the number already has a dot in it, or if
it's a number with a alphabetic name like infinity or NAN.

  • kjs/nodes.h: Renamed back from ObjectAccess to DotExpr. (KJS::NumberNode::precedence): Return PrecUnary for negative numbers, since they serialize as a unary operator, not a primary expression.
  • kjs/nodes2string.cpp: (KJS::SourceStream::operator<<): Clear m_numberNeedsParens if this adds parens; one set is enough. (KJS::bracketNodeStreamTo): Remove unneeded special flag here. Normal operator precedence suffices. (KJS::NewExprNode::streamTo): Ditto.

LayoutTests:

Reviewed by Oliver.

  • fast/js/function-toString-parentheses-expected.txt: Updated.
  • fast/js/resources/function-toString-parentheses.js: More test cases.
8:10 PM Changeset in webkit [29814] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix leaks seen after loading <​http://www.funnyordie.com/videos/d70b5a11cb>.

Reviewed by Darin Adler.

  • Misc/WebNSDataExtras.m:

(-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
to the new CFString so that they will be freed when no longer needed.

6:16 PM Changeset in webkit [29813] by oliver@apple.com
  • 5 edits in trunk

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17020
Function.toString does not parenthesise numbers for the bracket accessor

Reviewed by Maciej and Darin.

It turns out that logic was there for all of the dot accessor nodes to make numbers be
parenthesised properly, so it was a trivial extension to extend that to the bracket nodes.
I renamed the enum type to reflect the fact that it is now used for both dot and bracket
accessors.

4:40 PM Changeset in webkit [29812] by oliver@apple.com
  • 5 edits in trunk

Fix Bug 17018: Incorrect code generated from Function.toString for get/setters in object literals

Reviewed by Darin.

Don't quote getter and setter names during output, as that is simply wrong.

4:17 PM Changeset in webkit [29811] by ddkilzer@apple.com
  • 4 edits
    1 delete in trunk/WebKit

WebKit:

<rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit

Reviewed by Darin.

  • WebKit.xcodeproj/project.pbxproj: Removed WebDashboardRegion.h.

WebKit/mac:

<rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit

Reviewed by Darin.

  • WebCoreSupport/WebDashboardRegion.h: Removed.
  • WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
10:55 AM Changeset in webkit [29810] by Darin Adler
  • 10 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

  • JavaScriptCore.exp: Export the GlobalExecState constructor instead of the global flavor of the ExecState constructor. It'd probably be cleaner to not export either one, but JSGlobalObject inlines the code that constructs the ExecState. If we changed that, we could remove this export.
  • JavaScriptCore.xcodeproj/project.pbxproj: Re-sorted a few things and put the new source files into the kjs group rather than at the top level.
  • kjs/ExecState.cpp: (KJS::ExecState::ExecState): Marked inline and updated for data member name changes. This is now only for use for the derived classes. Also removed code that sets the unused m_savedExec data member for the global case. That data member is only used for the other two types. (KJS::ExecState::~ExecState): Marked inline and removed all the code. The derived class destructors now inclde the appropriate code. (KJS::ExecState::lexicalGlobalObject): Removed unneeded special case for an empty scope chain. The bottom function already returns 0 for that case, so the general case code handles it fine. Also changed to use data members directly rather than calling functions. (KJS::GlobalExecState::GlobalExecState): Added. Calls through to the base class constructor. (KJS::GlobalExecState::~GlobalExecState): Added. (KJS::InterpreterExecState::InterpreterExecState): Added. Moved code to manipulate activeExecStates here since we don't want to have to check for the special case of globalExec. (KJS::InterpreterExecState::~InterpreterExecState): Added. (KJS::EvalExecState::EvalExecState): Added. (KJS::EvalExecState::~EvalExecState): Added. (KJS::FunctionExecState::FunctionExecState): Added. (KJS::FunctionExecState::~FunctionExecState): Added.
  • kjs/ExecState.h: Tweaked the header, includes, and declarations a bit. Made ExecState inherit from Noncopyable. Reformatted some comments and made them a bit more brief. Rearranged declarations a little bit and removed unused savedExec function. Changed seenLabels function to return a reference rather than a pointer. Made constructors and destructor protected, and also did the same with all data members. Renamed m_thisVal to m_thisValue and ls to m_labelStack. Added three new derived classes for each of the types of ExecState. The primary goal here was to remove a branch from the code in the destructor, but it's also clearer than overloading the arguments to the ExecState constructor.
  • kjs/JSGlobalObject.cpp: (KJS::getCurrentTime): Fixed formatting. (KJS::JSGlobalObject::pushActivation): Removed parentheses that don't make the expression clearer -- other similar sites didn't have these parentheses, even the one a couple lines earlier that sets stackEntry. (KJS::JSGlobalObject::tearOffActivation): Got rid of unneeded static_cast (I think I mentioned this during patch review) and used an early exit so that the entire contents of the function aren't nested inside an if statement. Also removed the check of codeType, instead checking Activation for 0. For now, I kept the codeType check, but inside an assertion.
  • kjs/JSGlobalObject.h: Changed type of globalExec to GlobalExecState.
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Changed type to FunctionExecState. (KJS::GlobalFuncImp::callAsFunction): Changed type to EvalExecState.
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate): Changed type to GlobalExecState.
  • kjs/nodes.cpp: (KJS::ContinueNode::execute): Changed code since seenLabels() returns a reference now instead of a pointer. (KJS::BreakNode::execute): Ditto. (KJS::LabelNode::execute): Ditto.
10:27 AM Changeset in webkit [29809] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

Cleanup node2string a little.

  • Remove some unnecessary branching.
  • Factor out bracket and dot streaming into static inline functions.
  • kjs/nodes.h:
  • kjs/nodes2string.cpp: (KJS::bracketNodeStreamTo): (KJS::dotNodeStreamTo): (KJS::FunctionCallBracketNode::streamTo): (KJS::FunctionCallDotNode::streamTo): (KJS::PostIncBracketNode::streamTo): (KJS::PostDecBracketNode::streamTo): (KJS::PostIncDotNode::streamTo): (KJS::PostDecDotNode::streamTo): (KJS::DeleteBracketNode::streamTo): (KJS::DeleteDotNode::streamTo): (KJS::PreIncBracketNode::streamTo): (KJS::PreDecBracketNode::streamTo): (KJS::PreIncDotNode::streamTo): (KJS::PreDecDotNode::streamTo): (KJS::ReadModifyBracketNode::streamTo): (KJS::AssignBracketNode::streamTo): (KJS::ReadModifyDotNode::streamTo): (KJS::AssignDotNode::streamTo): (KJS::WhileNode::streamTo):
9:58 AM Changeset in webkit [29808] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/5707607> REGRESSION: I hear a beep when selecting Alt-enter in address or search fields


Reviewed by Oliver.

  • WebView.cpp: (WebView::keyDown): Allow alt-return to be marked as handled by WebKit.
4:32 AM Changeset in webkit [29807] by mrowe@apple.com
  • 2 edits in trunk

Fix ​http://bugs.webkit.org/show_bug.cgi?id=17007 ([GTK] autogen.sh attempts to use "libtoolize" on the Mac).

Reviewed by Alp Toker.

libtoolize is installed as glibtoolize on Mac OS X to avoid naming conflicts
with other system commands. Check for the presence of glibtoolize if libtoolize
cannot be found.

  • autogen.sh:
2:01 AM Changeset in webkit [29806] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix ​http://bugs.webkit.org/show_bug.cgi?id=17001 (Build error with Gtk port on Mac OS X).

Reviewed by Darin Adler.

If both XP_MACOSX and XP_UNIX are defined then X11.h and Carbon.h will both be included.
These provide conflicting definitions for a type named 'Cursor'. As XP_UNIX is set by
the build system when targeting X11, it doesn't make sense for XP_MACOSX to also be set
in this instance.

  • bindings/npapi.h: Don't define XP_MACOSX if XP_UNIX is defined.
1:42 AM Changeset in webkit [29805] by eric@webkit.org
  • 23 edits in trunk/WebCore

Reviewed by Sam and Darin.

Fire a warning shot in DeprecatedChar's direction.

Remove DeprecatedChar::isSpace() usage, in preparation for removing DeprecatedChar
Remove a needless String -> DeprecatedString -> String conversion for <script> tags

  • css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
  • css/SVGCSSParser.cpp:
  • dom/Position.cpp: (WebCore::Position::leadingWhitespacePosition): (WebCore::Position::trailingWhitespacePosition):
  • editing/TextIterator.cpp: (WebCore::WordAwareIterator::advance):
  • html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.h:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/TextResourceDecoder.cpp:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::getData):
  • platform/network/HTTPParsers.cpp: (WebCore::extractMIMETypeFromMediaType):
  • platform/text/PlatformString.h:
  • platform/text/StringImpl.cpp: (WebCore::parseLength): (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace): (WebCore::StringImpl::toInt): (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64):
  • platform/text/StringImpl.h: (WebCore::isSpaceOrNewline):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine):
  • svg/SVGFontFaceElement.cpp: (WebCore::mapAttributeToCSSProperty):
  • svg/SVGLength.cpp:
  • svg/SVGStyledElement.cpp: (WebCore::mapAttributeToCSSProperty):
  • xml/XPathParser.cpp:
1:01 AM Changeset in webkit [29804] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

Test: fast/js/toString-for-var-decl.html

  • kjs/nodes.h: Added PlaceholderTrueNode so we can put nodes into for loops without injecting the word "true" into them (nice, but not the bug fix). Fixed ForNode constructor so expr1WasVarDecl is set only when there is an expression, since it's common for the actual variable declaration to be moved by the parser.
  • kjs/nodes2string.cpp: (KJS::PlaceholderTrueNode::streamTo): Added. Empty.

LayoutTests:

Reviewed by Oliver.

  • fast/js/resources/toString-for-var-decl.js: Streamlined the test a bit, with more of the execution within shouldBe so that exceptions are caught for us. Added a new test case reflecting the just-fixed bug.
  • fast/js/toString-for-var-decl-expected.txt: Updated.

Jan 25, 2008:

11:58 PM Changeset in webkit [29803] by oliver@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix typo in changelog

11:54 PM Changeset in webkit [29802] by oliver@apple.com
  • 6 edits in trunk

Fix for bug 17012: REGRESSION: JSC can't round trip an object literal

Reviewed by Maciej.

Add logic to ensure that object literals and function expressions get
parenthesis when necessary.

5:16 PM Changeset in webkit [29801] by Stephanie Lewis
  • 1 edit in trunk/WebCore/ChangeLog

fix changelog

5:09 PM Changeset in webkit [29800] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-01-25 U-SLEWIS-WIN\Stephanie <Stephanie Lewis>

Reviewed by Tim.

expand workaround for <rdar://5695848> to include js files so that the
web inspector can work

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
5:03 PM Changeset in webkit [29799] by Antti Koivisto
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Adele.


(this is for r29798, my commit failed to include the log)


Windows fix to match r29773
If the media is playing and the load stalls the playback wont restart by seeking backwards.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):
3:41 PM Changeset in webkit [29798] by Antti Koivisto
  • 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp

Reviewed by Adele.


Windows fix to match r29773
If the media is playing and the load stalls the playback wont restart by seeking backwards.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):
3:40 PM Changeset in webkit [29797] by Darin Adler
  • 12 edits
    2 adds in trunk

WebCore:

Reviewed by Anders.

  • fix <rdar://problem/5691072> ASSERTION FAILED: isPrepared() when executing an empty statement

For empty statements, SQLite returns 0 for the statement. We have to cope with that.

Test: storage/empty-statement.html

  • platform/sql/SQLiteStatement.cpp: (WebCore::sqlite3_prepare16_v2): Added overload so we don't need an #if inside the prepare function. (WebCore::SQLiteStatement::SQLiteStatement): Initialize the m_isPrepared boolean. Removed the code to add a null character to the end of the string; instead we will use charactersWithNullTermination. (WebCore::SQLiteStatement::prepare): Set m_isPrepared based on the error value returned. Use the error value from sqlite3_prepare16_v2, not from lastError(). (WebCore::SQLiteStatement::step): Assert that the statement is prepared rather than checking it at runtime. However, in the case where this is called with m_statement of 0, return success rather than an error. That's needed for empty statements. (WebCore::SQLiteStatement::finalize): Use early return idiom for clarity. When there is no statement, return SQLITE_OK instead of calling lastError(). (WebCore::SQLiteStatement::reset): Use early return idiom for clarity. When there is no statement, return SQLITE_OK rather than SQLITE_ERROR, but assert the statement is prepared. (WebCore::SQLiteStatement::executeCommand): Adjust the code that does a prepare so that it will work for empty statements. Do we really need to allow calling this without prepare? It would be simpler to just be able to assert that it's prepared. (WebCore::SQLiteStatement::returnsAtLeastOneResult): Ditto. (WebCore::SQLiteStatement::bindBlob): Added some assertions. Return SQLITE_ERROR if this is called with m_statement of 0 (should not be possible without assertions firing first). Return the actual error code rather than lastError(). (WebCore::SQLiteStatement::bindText): Ditto. Also simplified the special case for empty strings, since it requires any non-null pointer, not a pointer to a global zero character. (WebCore::SQLiteStatement::bindInt64): Ditto. (WebCore::SQLiteStatement::bindDouble): Ditto. (WebCore::SQLiteStatement::bindNull): Ditto. (WebCore::SQLiteStatement::bindValue): Moved default case out of the switch to take advantage of the gcc compiler warning for unhandled enum values in a switch. (WebCore::SQLiteStatement::bindParameterCount): Added assertion and code to handle the empty statement case. (WebCore::SQLiteStatement::columnCount): Added assertion and changed the code to use the early-return idiom. (WebCore::SQLiteStatement::getColumnName): Removed getColumnName16 -- we always use 16-bit characters and have no reason to ever use the 8-bit function. Added assertions about the passed-in column number. It's a little strange that this function checks the column number for too-large column numbers, but not for negative ones. I didn't change that for now. (WebCore::SQLiteStatement::getColumnText): Ditto. (WebCore::SQLiteStatement::getColumnDouble): Ditto. (WebCore::SQLiteStatement::getColumnInt): Ditto. (WebCore::SQLiteStatement::getColumnInt64): Ditto. (WebCore::SQLiteStatement::getColumnBlobAsVector): Ditto. (WebCore::SQLiteStatement::getColumnBlob): Tightened up function a bit, including use of the early-return idiom and replacing the multiple "size = 0" with a single one at the start of the function. (WebCore::SQLiteStatement::returnTextResults): Added a failure case when the prepare call doesn't work. Cleared the vector earlier to make the failure code simpler. Moved the declaration of the result boolean down lower to make it clearer what it's for. Changed use of lastError() to call on the database, to make it clearer that there's no per-statement last error kept around. It'd be even better to not use lastError() here. (WebCore::SQLiteStatement::returnIntResults): Ditto. (WebCore::SQLiteStatement::returnInt64Results): Ditto. (WebCore::SQLiteStatement::returnDoubleResults): Ditto.
(WebCore::SQLiteStatement::isExpired): Changed to use
rather than ?: because I think

it's slightly easier to read that way.

  • platform/sql/SQLiteStatement.h: Removed unneeded includes and forward declarations. Also removed unnneeded functions isPrepared, getColumnName16, getColumnText16, returnTextResults16, lastError, and lastErrorMsg. Changed prepareAndStep so that it checks the result of prepare before callling step. Added a debug-only m_isPrepared boolean.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::checkIntegrity): Remove 16 suffix from text-related function names. (WebCore::IconDatabase::performURLImport): Ditto. (WebCore::IconDatabase::pruneUnretainedIcons): Ditto.
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::clearAllTables): Ditto.
  • storage/Database.cpp: (WebCore::retrieveTextResultFromDatabase): Ditto. (WebCore::Database::performGetTableNames): Ditto.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Ditto. (WebCore::DatabaseTracker::populateOrigins): Ditto. (WebCore::DatabaseTracker::databaseNamesForOrigin): Ditto. (WebCore::DatabaseTracker::addDatabase): Ditto.
  • storage/SQLStatement.cpp: (WebCore::SQLStatement::execute): Ditto.
  • platform/sql/SQLiteDatabase.h: Removed unneeded includes.
  • storage/SQLResultSet.h: Ditto.
  • storage/SQLResultSetRowList.h: Ditto.

LayoutTests:

Reviewed by Anders.

  • test for <rdar://problem/5691072> ASSERTION FAILED: isPrepared() when executing an empty statement
  • storage/empty-statement-expected.txt: Added.
  • storage/empty-statement.html: Added.
3:07 PM Changeset in webkit [29796] by Antti Koivisto
  • 7 edits in trunk/LayoutTests

Reviewed by Darin.


Fix <rdar://problem/5674282>
Some media tests fail on Windows


  • fix the script to exit cleanly
  • slightly increase the amount of data to hand out before stalling, apparently QT on Windows needs more to start playback
2:28 PM Changeset in webkit [29795] by adele@apple.com
  • 89 edits
    4 adds in trunk

WebCore:

Reviewed by Sam.

Fix for <rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

  • css/html4.css: Add horizontal padding to the media slider.
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): Replace use of absoluteBoundingBox() with width() and height() (WebCore::RenderSlider::positionForOffset): ditto. Also, use the trackSize() for the maximum offset. (WebCore::RenderSlider::layout): Use contentWidth() and contentHeight() to take padding into account. (WebCore::RenderSlider::trackSize): ditto.

LayoutTests:

Reviewed by Sam.

Adding new test and updated results for:
<rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

  • fast/forms/slider-padding.html: Added.
  • platform/mac/fast/forms/slider-padding-expected.checksum: Added.
  • platform/mac/fast/forms/slider-padding-expected.png: Added.
  • platform/mac/fast/forms/slider-padding-expected.txt: Added.
  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/broken-video-expected.checksum:
  • platform/mac/media/broken-video-expected.png:
  • platform/mac/media/progress-event-expected.checksum:
  • platform/mac/media/progress-event-expected.png:
  • platform/mac/media/unsupported-rtsp-expected.checksum:
  • platform/mac/media/unsupported-rtsp-expected.png:
  • platform/mac/media/unsupported-tracks-expected.checksum:
  • platform/mac/media/unsupported-tracks-expected.png:
  • platform/mac/media/video-append-source-expected.checksum:
  • platform/mac/media/video-append-source-expected.png:
  • platform/mac/media/video-autoplay-expected.checksum:
  • platform/mac/media/video-autoplay-expected.png:
  • platform/mac/media/video-buffered-expected.checksum:
  • platform/mac/media/video-buffered-expected.png:
  • platform/mac/media/video-controls-expected.checksum:
  • platform/mac/media/video-controls-expected.png:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-currentTime-set2-expected.checksum:
  • platform/mac/media/video-currentTime-set2-expected.png:
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-dom-autoplay-expected.checksum:
  • platform/mac/media/video-dom-autoplay-expected.png:
  • platform/mac/media/video-dom-src-expected.checksum:
  • platform/mac/media/video-dom-src-expected.png:
  • platform/mac/media/video-dom-start-expected.checksum:
  • platform/mac/media/video-dom-start-expected.png:
  • platform/mac/media/video-error-abort-expected.checksum:
  • platform/mac/media/video-error-abort-expected.png:
  • platform/mac/media/video-error-does-not-exist-expected.checksum:
  • platform/mac/media/video-error-does-not-exist-expected.png:
  • platform/mac/media/video-load-networkState-expected.checksum:
  • platform/mac/media/video-load-networkState-expected.png:
  • platform/mac/media/video-load-readyState-expected.checksum:
  • platform/mac/media/video-load-readyState-expected.png:
  • platform/mac/media/video-muted-expected.checksum:
  • platform/mac/media/video-muted-expected.png:
  • platform/mac/media/video-no-autoplay-expected.checksum:
  • platform/mac/media/video-no-autoplay-expected.png:
  • platform/mac/media/video-pause-empty-events-expected.checksum:
  • platform/mac/media/video-pause-empty-events-expected.png:
  • platform/mac/media/video-play-empty-events-expected.checksum:
  • platform/mac/media/video-play-empty-events-expected.png:
  • platform/mac/media/video-play-pause-events-expected.checksum:
  • platform/mac/media/video-play-pause-events-expected.png:
  • platform/mac/media/video-play-pause-exception-expected.checksum:
  • platform/mac/media/video-play-pause-exception-expected.png:
  • platform/mac/media/video-seek-past-end-paused-expected.checksum:
  • platform/mac/media/video-seek-past-end-paused-expected.png:
  • platform/mac/media/video-seek-past-end-playing-expected.checksum:
  • platform/mac/media/video-seek-past-end-playing-expected.png:
  • platform/mac/media/video-seekable-expected.checksum:
  • platform/mac/media/video-seekable-expected.png:
  • platform/mac/media/video-seeking-expected.checksum:
  • platform/mac/media/video-seeking-expected.png:
  • platform/mac/media/video-size-expected.checksum:
  • platform/mac/media/video-size-expected.png:
  • platform/mac/media/video-source-expected.checksum:
  • platform/mac/media/video-source-expected.png:
  • platform/mac/media/video-source-media-expected.checksum:
  • platform/mac/media/video-source-media-expected.png:
  • platform/mac/media/video-source-type-expected.checksum:
  • platform/mac/media/video-source-type-expected.png:
  • platform/mac/media/video-src-change-expected.checksum:
  • platform/mac/media/video-src-change-expected.png:
  • platform/mac/media/video-src-expected.checksum:
  • platform/mac/media/video-src-expected.png:
  • platform/mac/media/video-src-remove-expected.checksum:
  • platform/mac/media/video-src-remove-expected.png:
  • platform/mac/media/video-src-set-expected.checksum:
  • platform/mac/media/video-src-set-expected.png:
  • platform/mac/media/video-src-source-expected.checksum:
  • platform/mac/media/video-src-source-expected.png:
  • platform/mac/media/video-start-expected.checksum:
  • platform/mac/media/video-start-expected.png:
  • platform/mac/media/video-volume-expected.checksum:
  • platform/mac/media/video-volume-expected.png:
  • platform/mac/media/video-width-height-expected.checksum:
  • platform/mac/media/video-width-height-expected.png:
1:38 PM Changeset in webkit [29794] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

<rdar://problem/5674277>
Test media/video-display-toggle.html crashes on Windows


Appears to be some problem in DRT when test ends with layout pending.
Fixed by forcing layout, this improves test coverage too.

  • media/video-display-toggle.html:
  • platform/win/Skipped:
10:31 AM Changeset in webkit [29793] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-25 Ori Bernstein <​ori@eigenstate.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16795
WebKitGtk crashes when there is no focused Frame

Add a null check. focusedFrame() isn't used directly anywhere else so
this is the only case that needs to be fixed.

  • WebView/webkitwebview.cpp:
7:01 AM Changeset in webkit [29792] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

<rdar://problem/5706788> http/tests/security/cross-frame-access-port-explicit-domain.html fails on Windows

  • platform/win/Skipped:
6:42 AM Changeset in webkit [29791] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/xmlhttprequest/readystatechange.html fails on buildbot.

  • platform/win/Skipped:
3:45 AM Changeset in webkit [29790] by ap@webkit.org
  • 3 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

<rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment (matching Mac DRT).
  • DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
1:14 AM S60IDE edited by mgroeber@gmx.net
Adding info about missing variant.cfg update (diff)

Jan 24, 2008:

5:50 PM Changeset in webkit [29789] by sfalken@apple.com
  • 3 edits in tags/Safari-5525.6.1/WebKit/win

Merged r29785

5:49 PM Changeset in webkit [29788] by sfalken@apple.com
  • 2 edits in tags/Safari-5525.6.1/JavaScriptCore

Merged r29784

5:46 PM Changeset in webkit [29787] by sfalken@apple.com
  • 2 edits in tags/Safari-5525.6.1/JavaScriptCore

Merged r29783

5:16 PM Changeset in webkit [29786] by sfalken@apple.com
  • 1 copy in tags/Safari-5525.6.1

New tag.

5:13 PM Changeset in webkit [29785] by sfalken@apple.com
  • 3 edits in trunk/WebKit/win

Build fix

  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.submit.sln:
5:08 PM Changeset in webkit [29784] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

5:07 PM Changeset in webkit [29783] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

4:51 PM Changeset in webkit [29782] by weinig@apple.com
  • 6 edits in trunk

WebKitTools:

Reviewed by Ada Chan.

Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo

  • Adds simplified UndoManager to windows DRT to allow testing the undo/redo code paths in WebCore and WebKit. This is a temporary solution to an issue that should eventually be solved by having a shared UndoManager in WebKit.
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
  • DumpRenderTree/win/UIDelegate.cpp: (DRTUndoObject::DRTUndoObject): (DRTUndoObject::invoke): (DRTUndoStack::~DRTUndoStack): (DRTUndoStack::isEmpty): (DRTUndoStack::clear): (DRTUndoStack::push): (DRTUndoStack::pop): (DRTUndoManager::canRedo): (DRTUndoManager::canUndo): (DRTUndoManager::DRTUndoManager): (DRTUndoManager::removeAllActions): (DRTUndoManager::registerUndoWithTarget): (DRTUndoManager::redo): (DRTUndoManager::undo): (UIDelegate::UIDelegate): (UIDelegate::resetUndoManager): (UIDelegate::registerUndoWithTarget): (UIDelegate::removeAllActionsWithTarget): (UIDelegate::setActionTitle): (UIDelegate::undo): (UIDelegate::redo): (UIDelegate::canUndo): (UIDelegate::canRedo):
  • DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Reviewed by Ada Chan.

<rdar://5131975> DumpRenderTree doesn't support undo/redo

  • platform/win/Skipped: With undo/redo support enabled, we can now remove the undo tests from the Skipped list.
3:50 PM Changeset in webkit [29781] by Adam Roben
  • 6 edits in trunk/WebCore

Better fix for Bug 16996

Rubberstamped by Mitz.

  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureCustomFontData): Don't call createFontCustomPlatformData if m_data is null.
  • platform/graphics/gtk/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Added an assertion.
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
  • platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
3:13 PM Changeset in webkit [29780] by Adam Roben
  • 3 edits
    2 adds in trunk

Fix Bug 16996: Crash in createFontCustomPlatformData when loading 0-byte font via @font-face

WebCore:

Fix Bug 16996: Crash in createFontCustomPlatformData when loading
0-byte font via @font-face

<​http://bugs.webkit.org/show_bug.cgi?id=16996>

Reviewed by Hyatt.

Test: fast/loader/font-face-empty.html

  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Null-check the buffer parameter.

LayoutTests:

Test for Bug 16996: Crash in createFontCustomPlatformData when loading
0-byte font via @font-face

<​http://bugs.webkit.org/show_bug.cgi?id=16996>

Reviewed by Hyatt.

  • fast/loader/font-face-empty-expected.txt: Added.
  • fast/loader/font-face-empty.html: Added.
2:02 PM Changeset in webkit [29779] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/editing/selection/end-of-document-expected.txt

Update results for an editing test that changed from Acid3 fix.

1:53 PM Changeset in webkit [29778] by jhoneycutt@apple.com
  • 6 edits
    1 add in trunk/WebCore

2008-01-24 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5588807> Crash in Flash when destroying plug-in (found
using yahoo beta mail)

Flash can dereference NULL in the call to NPP_URLNotify if a request
made with NPN_PostURLNotify fails before NPP_NewStream is called.

Work around this by creating a quirk, PluginQuirkFlashURLNotifyBug, and
checking for this quirk before calling NPP_URLNotify for any request
made with NPN_PostURLNotify. If the quirk is present, call NPP_NewStream
and NPP_DestroyStream before calling NPP_URLNotify.

  • WebCore.vcproj/WebCore.vcproj:
  • plugins/PluginQuirkSet.h: Added. Moved quirks out of PluginViewWin so PluginViewWin and PluginStream could share it. Created a class, PluginQuirkSet, to store plug-in quirks (WebCore::): (WebCore::PluginQuirkSet::PluginQuirkSet): (WebCore::PluginQuirkSet::add): (WebCore::PluginQuirkSet::contains):
  • plugins/PluginStream.cpp: (WebCore::PluginStream::PluginStream): Copy the PluginQuirkSet for this plug-in (WebCore::PluginStream::destroyStream): Check for the FlashURLNotifyBug quirk
  • plugins/PluginStream.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Pass the quirks when creating the PluginStream (WebCore::PluginViewWin::didReceiveResponse): Same (WebCore::PluginViewWin::wndProc): Use add / contains instead of bit ops (WebCore::PluginViewWin::userAgent): Same (WebCore::PluginViewWin::invalidateRect): Same (WebCore::PluginViewWin::~PluginViewWin): Same (WebCore::PluginViewWin::determineQuirks): Same (WebCore::PluginViewWin::setParameters): Same (WebCore::PluginViewWin::PluginViewWin): Same (WebCore::PluginViewWin::init): Same (WebCore::PluginViewWin::setCallingPlugin): Same
  • plugins/win/PluginViewWin.h:
1:52 PM Changeset in webkit [29777] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/parser

Add test results for Acid3 buckets parsing issue.

1:51 PM Changeset in webkit [29776] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/parser/style-script-head-test.html

Add test of Acid3 buckets parsing issue.

1:49 PM Changeset in webkit [29775] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​http://bugs.webkit.org/show_bug.cgi?id=16982

Make sure to make <head> the current block if it is created before a <body> already exists.

Reviewed by Dan

  • html/HTMLParser.cpp: (WebCore::HTMLParser::createHead):
11:40 AM Changeset in webkit [29774] by ap@webkit.org
  • 4 edits
    2 deletes in trunk

​http://bugs.webkit.org/show_bug.cgi?id=16993
<rdar://problem/5704331> REGRESSION: Loading page leads to many unexpected redirections

Rolled out r29590, which was not a correct fix for <rdar://problem/5692566>.

10:24 AM Changeset in webkit [29773] by Antti Koivisto
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Adam.


If the media is playing and the load stalls the playback wont restart by seeking backwards.


We should be in CAN_PLAY state if the current time is less than the maximum loaded time. Rate
tricks were for streaming case and are not necessary now since that is now disabled.


Windows patch coming separately.

Test: http/tests/media/video-play-stall-seek.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):

LayoutTests:

Reviewed by Adam.


Test that playback can be resumed by seeking backwards after a stall.

  • http/tests/media/video-play-stall-seek-expected.txt: Added.
  • http/tests/media/video-play-stall-seek.html: Added.
  • platform/win/Skipped:
10:18 AM Changeset in webkit [29772] by Antti Koivisto
  • 11 edits in trunk/WebCore

Reviewed by Adam.

Fix <rdar://problem/5684815>
After navigating back to the page that contains a <audio> that has been muted, the audio is still heard


  • get rid of the separate muted state in MediaPlayer, maintain the state in the cross platform code only
  • remove volumeChanged() callbacks from HTMLMediaElement and OS X MediaPlayer, they were not used for anything
  • rename updateMediaPlayer -> updatePlayState which tells more about what it actually does
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::setVolume): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): (WebCore::HTMLMediaElement::updateVolume): (WebCore::HTMLMediaElement::updatePlayState): (WebCore::HTMLMediaElement::setPausedInternal):
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/win/QTMovieWin.cpp:
  • platform/graphics/win/QTMovieWin.h:
9:38 AM Changeset in webkit [29771] by Adam Roben
  • 2 edits in trunk/WebKit/win

Build fix

  • WebView.cpp: Added a comma.
9:27 AM Changeset in webkit [29770] by Adam Roben
  • 2 edits in trunk/WebKitTools

Allow directories containing ChangeLogs to be passed to resolve-ChangeLogs

Reviewed by David Kilzer.

  • Scripts/resolve-ChangeLogs: (sub findChangeLog): Return a ChangeLog contained within the specified directory if one exists.
8:36 AM Changeset in webkit [29769] by ap@webkit.org
  • 2 edits in trunk/WebKit/win

Reviewed by Adam Roben.

<rdar://problem/5702734> REGRESSION(r28936/r15890): Shift+del does not work in win Safari

  • WebView.cpp: Fixed keyDownEntries to list this shortcut (and related ones, for consistency).
6:52 AM Changeset in webkit [29768] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Fix "QObject::startTimer: QTimer can only be used with threads started with QThread"
  • The JSC GCController gets automatically destructed on application exit, it will stop its timer and we try to schedule the next timer. Now the GCController can get destructed after our QApplication is gone. This will trigger the above warning, we can avoid this by checking if our qApp is still around.
6:27 AM Changeset in webkit [29767] by Simon Hausmann
  • 2 edits in trunk/WebCore

Morten Johan Sørvig <​msorvig@trolltech.com>

Qt/Mac: Make sure the scrollbars does not overlap the grow box.

When showing only one scrollbar we need to move it so it doesn't overlap the
grow box. This is similar to the code in QAbstractScrollArea.

6:24 AM Changeset in webkit [29766] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

David Boddie <​dboddie@trolltech.com>

Documentation tidying.

6:23 AM Changeset in webkit [29765] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Jarek Kobus <​jkobus@trolltech.com>

Text for translations were used wrongly as comments

6:18 AM Changeset in webkit [29764] by Simon Hausmann
  • 3 edits
    2 adds in trunk

Michael Goddard <​michael.goddard@trolltech.com>

​http://bugs.webkit.org/show_bug.cgi?id=16888

Fix for CSS crash in -webkit-border-image.
Reviewed by Darin.

While parsing -webkit-border-image, store
the border widths as naked pointers rather
than as OwnPtrs, since they point to the
middle of an array.

Test: fast/css/border-image-crash.html

6:13 AM Changeset in webkit [29763] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • We have a KURL->QUrl conversion on KURL itself, make use of it.
  • This conversion is supposed to be loss-free
6:08 AM Changeset in webkit [29762] by Simon Hausmann
  • 3 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Attempt to fix showing of popup again after a popup has been shown but the user did not select any item (e.g. clicked outside of the popup)
  • Keep track of the popup status using the virtuals showPopup and hidePopup and do not go into recursion when hiding a popup.
6:01 AM Changeset in webkit [29761] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Assert the presence of the PopupMenuClient
5:56 AM Changeset in webkit [29760] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Fix QDateTime to JS Date conversion.
Several conversion errors (some UTC related, some month
offset related) and the conversion distance for Date
to DateTime conversion weights were fixed (it should never
be better to convert a JS Number into a Date rather than
an int).

5:51 AM Changeset in webkit [29759] by Simon Hausmann
  • 6 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Add support for calling QObjects.
Add support for invokeDefaultMethod (via a call to
a specific slot), and also allow using it as a
constructor, like QtScript.

5:44 AM Changeset in webkit [29758] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Code style cleanups.
Add spaces before/after braces in inline function.

5:41 AM Changeset in webkit [29757] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Code style cleanups.
Remove spaces and unneeded declared parameter names.

5:37 AM Changeset in webkit [29756] by Simon Hausmann
  • 4 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Clear stale RuntimeObjectImps.
Since other objects can have refs to the QtInstance,
we can't rely on the QtInstance being deleted when the
RuntimeObjectImp is invalidate or deleted. This
could result in a stale JSObject being returned for
a valid Instance.

Jan 23, 2008:

11:44 PM Changeset in webkit [29755] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

11:42 PM Changeset in webkit [29754] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.6

New tag.

4:47 PM Changeset in webkit [29753] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5702947> WebCore: CGContextDrawPDFDocument will be deprecated

Reviewed by Darin.

No test cases added since there is no change in behavior.

  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::draw): Replace CGContextDrawPDFDocument() with calls to CG methods that perform the equivalent work.
3:08 PM Changeset in webkit [29752] by Antti Koivisto
  • 4 edits in trunk/WebCore

Reviewed by Hyatt, Adele.

Timers for media controls keep running when the page is in the page cache.


Stop timers in RenderMedia and get rid of the controls tree when the page goes to the cache.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::willSaveToCache): (WebCore::HTMLMediaElement::didRestoreFromCache):
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::inPageCache):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
2:26 PM Changeset in webkit [29751] by Antti Koivisto
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Video that had already played to the end would start playing (from beginning) on back/forward navigation.


Use setPausedInternal() instead of pause(). This avoid generating pause/play events and matches specification text.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache):
2:20 PM Changeset in webkit [29750] by ap@webkit.org
  • 5 edits
    6 adds in trunk

Reviewed by Darin.

<rdar://problem/4200075> Missing support for accented chars in mailto forms

With some combinations of form parameters, this was resulting in regressed behavior.

Tests: fast/forms/mailto/get-non-ascii-text-plain-latin-1.html

fast/forms/mailto/post-text-plain-with-accept-charset.html
fast/forms/mailto/post-text-plain.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Ignore accept-charset for mailto forms, which are always encoded as UTF-8. (WebCore::HTMLFormElement::isMailtoForm): Added. (WebCore::HTMLFormElement::dataEncoding): Added (factored out from formData). (WebCore::HTMLFormElement::submit): When round-tripping in text/plain case, use utf-8 encoding.
  • html/HTMLFormElement.h: Added a isMailtoForm() function. It may be a bit unfortunate that its result is calculated repeatedly, but this doesn't seem to be anywhere near hot code.
2:04 PM Changeset in webkit [29749] by sfalken@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Alice Liu.

<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): If value == text() and m_innerText is empty, then value and text() are "". In that case both DOM mutations are no-ops and there is no reason to clear the Undo stack.

WebKit/win:

<rdar://problem/5698732> Copyright strings should include 2008


Reviewed by Sam.

  • WebKit.vcproj/WebKit.rc:

WebKitTools:

<rdar://problem/5698732> Copyright strings should include 2008

Reviewed by Sam.

  • Drosera/win/Drosera.vcproj/Drosera.rc:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
1:51 PM Changeset in webkit [29748] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Alice Liu.

<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): If value == text() and m_innerText is empty, then value and text() are "". In that case both DOM mutations are no-ops and there is no reason to clear the Undo stack.

LayoutTests:

Reviewed by Alice Liu.


<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

  • editing/undo/5658727-expected.txt: Added.
  • editing/undo/5658727.html: Added.
1:08 PM Changeset in webkit [29747] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix <rdar://5698502> Inspector window reverts to default position/size unexpectedly

Reviewed by Hyatt.

  • WebInspectorClient.cpp: (defaultWindowRect): Added. (WebInspectorClient::createPage):
    • Use defaultWindowRect() to set the initial size/position of the Inspector window.
    • Pass the Inspector window's client rect to IWebView::initWithFrame so that the WebView will be initially sized to fill the window.

(WebInspectorClient::showWindow): Don't move/resize the window back to
the defaults every time this method is called.

1:07 PM Changeset in webkit [29746] by Adam Roben
  • 3 edits
    2 adds in trunk

Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

WebKit/win:

Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

Test: fast/events/contextmenu-scrolled-page-with-frame.html

Reviewed by Dan.

  • WebView.cpp: (WebView::handleContextMenuEvent): Translate the mouse coordinates into document coordinates before performing the hit-test. This is what EventHandler does internally.

LayoutTests:

Add a test for <rdar://5700620> REGRESSION (r28190): "Open frame in
new tab" instead of "Open link in new tab" @ digg.com

Reviewed by Dan.

  • fast/events/contextmenu-scrolled-page-with-frame-expected.txt: Added.
  • fast/events/contextmenu-scrolled-page-with-frame.html: Added.
11:43 AM Changeset in webkit [29745] by sfalken@apple.com
  • 9 edits in trunk

WebCore:

<rdar://problem/5699509> Allow file upload dialog to be localized.

Reviewed by Darin.

  • platform/LocalizedStrings.h:
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser):

WebKit:

Update localization exceptions.


Reviewed by Darin.

  • English.lproj/Localizable.strings:
  • StringsNotToBeLocalized.txt:

WebKit/win:

<rdar://problem/5699509> Allow file upload dialog to be localized.


Reviewed by Darin.

  • English.lproj/Localizable.strings: Updated.
  • WebCoreLocalizedStrings.cpp: (WebCore::uploadFileText): Added. (WebCore::allFilesText): Added.
9:49 AM Changeset in webkit [29744] by dsmith@webkit.org
  • 1 edit
    19 adds in trunk/WebKitSite

Reviewed by Darin.


Added a modified version of the MooTools SlickSpeed Selector Test/Benchmark to show off querySelectorAll. MIT licensed.

  • perf/slickspeed: Added.
  • perf/slickspeed/config.ini: Added.
  • perf/slickspeed/footer.html: Added.
  • perf/slickspeed/frameworks: Added.
  • perf/slickspeed/frameworks/DomQuery.js: Added.
  • perf/slickspeed/frameworks/dummy.js: Added.
  • perf/slickspeed/frameworks/jquery-1.2.1.js: Added.
  • perf/slickspeed/frameworks/prototype.js: Added.
  • perf/slickspeed/header.html: Added.
  • perf/slickspeed/index.php: Added.
  • perf/slickspeed/instructions.txt: Added.
  • perf/slickspeed/logo.png: Added.
  • perf/slickspeed/selectors.list: Added.
  • perf/slickspeed/style.css: Added.
  • perf/slickspeed/system: Added.
  • perf/slickspeed/system/index.php: Added.
  • perf/slickspeed/system/slickspeed.js: Added.
  • perf/slickspeed/system/template.php: Added.
  • perf/slickspeed/template.html: Added.
9:38 AM Changeset in webkit [29743] by Adam Roben
  • 2 edits in trunk/WebCore

Fix behavior of type-to-select in <select> menus

In r27825 we started posting both a WM_KEYDOWN and WM_CHAR message
whenever a key was pressed in the dropdown menu. However, since posted
messages go through TranslateMessage, the WM_KEYDOWN was generating
another WM_CHAR message, so two WM_CHAR messages in a row would reach
the WebView. This caused the searching to happen twice for each key,
so typing "dog" would search for "ddoogg".

Reviewed by Darin.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc): Repost the WM_KEYDOWN message to the WebView. This is will generate a WM_CHAR message which will trigger the type-to-select behavior. This is very similar to our behavior prior to r27825, except that we're now calling PostMessage instead of SendMessage.
8:18 AM Changeset in webkit [29742] by mitz@apple.com
  • 4 edits in trunk/LayoutTests
  • platform/mac/fast/frames/viewsource-attribute-expected.checksum:
  • platform/mac/fast/frames/viewsource-attribute-expected.png:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
7:55 AM Changeset in webkit [29741] by alp@webkit.org
  • 8 edits in trunk

2008-01-23 Alp Toker <​alp@atoker.com>

Rubber-stamped by Mark Rowe.

Remove whitespace after -I in automake include lists.

3:16 AM Changeset in webkit [29740] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Fix leaking of sub frames (WebCore::Frame). We keep one reference too many. This was found while working on the page-cache, other ports are not affected.
  • Rubber stamped by Simon
3:14 AM Changeset in webkit [29739] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Load images incrementally. This will show warnings on the console and we want to fix them for Qt4.4. If that happens we have to remove the comment from the enum inside the ImageDecoderQt.cpp
  • Rubber stamped by Simon
3:11 AM Changeset in webkit [29738] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Rohan McGovern <​rohan.mcgovern@trolltech.com>

Fix Qtopia compilation with QT_NO_TOOLTIP

3:11 AM Changeset in webkit [29737] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Geir Vattekar <​gvatteka@trolltech.com>

Doc: Replaced \code with snippets in the docs

3:10 AM Changeset in webkit [29736] by Simon Hausmann
  • 2 edits in trunk/WebCore

Lars Knoll <​lars@trolltech.com>

Fix rendering of the Scrollbar as well as mouse handling for some styles.

The QStyle expects that that painter is set up to clip to the scrollbar bounds
and some of the styles seem to paint somewhat outside of these bounds. Clipping to
the scrollbar bounds before drawing removes some artifacts.

Also set m_opt.rect.topLeft to (0/0) in the mouse handlers. Fixes some issues with
the oxygen style.

1:55 AM Changeset in webkit [29735] by Simon Hausmann
  • 3 edits in trunk/WebCore

Michael Brasser <​michael.brasser@trolltech.com>

Rendering fixes for Qtopia.

Make the focus ring work with line breaks (until we have QPainterPath::simplify) and
call QStyle with better arguments when painting themed elements.

1:55 AM Changeset in webkit [29734] by Simon Hausmann
  • 3 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • FormData::flatten does not include to be uploaded files. Create our own QIODevice for the QNetworkAccessManager and feed the complete content of the FormData* to the (HTTP) backend.
  • Try to optimize the ::readData implementation to fill the buffer as best as possible
1:55 AM Changeset in webkit [29733] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Coding-Style fixes
1:48 AM Changeset in webkit [29732] by Simon Hausmann
  • 2 edits in trunk/WebCore

Michael Brasser <​michael.brasser@trolltech.com>

use PopupClient's font for popup menu. Otherwise, in Qtopia, the popup's font is much bigger (QApplication::font()?) and the text doesn't fit.

1:44 AM Changeset in webkit [29731] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Benjamin Meyer <​bmeyer@trolltech.com>

Tweak key presses even to match commonly expected behavior

  • space key == page down
  • page down moved down not a page, but slightly less then a page so you don't loose your spot when reading.
  • Use font height rather then a hard coded "10" for left, right, up, down
  • Ctrl-Up moves to the top of the page
  • Ctrl-Down move to the bottom of the page
  • Backspace == GoBack
  • Shift-Backspace == GoForward
1:43 AM Changeset in webkit [29730] by Simon Hausmann
  • 7 edits in trunk

Implemented FrameLoaderClient::startDownload() and FrameLoaderClient::download().

Added two signals to QWebPage to handle downloading of links and handling of
unsupported content.

1:39 AM Changeset in webkit [29729] by Simon Hausmann
  • 12 edits in trunk

Michael Goddard <​michael.goddard@trolltech.com>

Reworked the JavaScriptCore Qt bindings:

  • Add initial support for string and variant arrays, as well as sub QObjects in the JS bindings.
  • Don't expose fields marked as not scriptable by moc.
  • Add support for dynamic properties and accessing named QObject children of an object (like QtScript and older IE DOM style JS).
  • Add support for custom toString methods.
  • Fine tune some bindings to be closer to QtScript. Make void functions return undefined, and empty/ null QStrings return a zero length string.
  • Create framework for allowing more direct method calls. Since RuntimeMethod doesn't allow us to add additional methods/properties to a function, add these classes. Start prototyping object.signal.connect(...).
  • Add signal support to the Qt bindings. Allow connecting to signals (object.signal.connect(slot)), disconnecting, and emitting signals. Currently chooses the first signal that matches the name, so this will need improvement.
  • Add property names, and resolve signals closer to use. Enumerating properties now returns some of the Qt properties and signals. Slots and methods aren't quite present. Also, resolve signal connections etc. closer to the time of use, so we can do more dynamic resolution based on argument type etc. Still picks the first one with the same name, at the moment.
  • Make signature comparison code consistent. Use the same code for checking meta signatures in the method and fallback getters, and avoid a QByteArray construction when we can.
  • Fix minor memory leak, and handle pointers better. Delete the private object in the dtors, and use RefPtrs for holding Instances etc.
  • Handle method lookup better. Allow invocation time method lookup based on the arguments, which is closer to QtScript behaviour. Also, cache the method lists and delete them in the QtClass dtor (stops a memory leak).
  • Improve JS to Qt data type conversions. Add some support for Date & RegExp JS objects, and provide some metrics on the quality of the conversion.
  • A couple of fixes for autotest failures. Better support for converting lists, read/write only QMetaProperty support, modified slot search order...)
  • Update JS DRT controller for Qt JS binding changes. There were two functions that needed some changes so that the layout tests would work, so this makes a few tests pass again.
  • Bump the timeout for layout tests up to 11s. At least some tests have an internal timeout of 10 seconds, so make the waitUntilDone approach wait at least 11s. fast/dom/open-and-close-by-DOM.html is one of these - now the failure message is more accurate.

Jan 22, 2008:

8:01 PM Changeset in webkit [29728] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adele Peterson.

The regression test for this is fast/css/css2-system-color.html which
is currently disabled.

  • rendering/RenderThemeMac.mm: (WebCore::menuBackgroundColor): Added. Uses HIThemeDrawMenuBackground to draw the menu item background into a bitmap graphics context and returns the color of the pixel at (0, 0). (WebCore::RenderThemeMac::systemColor): Changed to call menuBackgroundColor for the CSS2 menu color.
4:29 PM Changeset in webkit [29727] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • turn full repainting back on for <canvas> until we get incremental repaint working properly

Ollie and I came up with a plan for testing this, but for now we should
just fall back on the "repaint everything" behavior we have always had.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::willDraw): Just call repaint.
3:16 PM Changeset in webkit [29726] by andersca@apple.com
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Darin and Adam.

<rdar://problem/5688975>
div element on microsoft site has wrong left offset.


Return true even if NPN_GetProperty returns null or undefined. This matches Firefox
(and is what the Silverlight plug-in expects).


  • bindings/NP_jsobject.cpp: (_NPN_GetProperty):

WebKitTools:

Reviewed by Darin and Adam.

<rdar://problem/5688975>
div element on microsoft site has wrong left offset.


Add new method for testing the return vale of NPN_GetProperty.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):

LayoutTests:

Reviewed by Darin and Adam.

<rdar://problem/5688975>
div element on microsoft site has wrong left offset.


Add test.


  • plugins/netscape-get-property-return-value-expected.txt: Added.
  • plugins/netscape-get-property-return-value.html: Added.
1:23 PM Changeset in webkit [29725] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-22 Alp Toker <​alp@atoker.com>

GTK+/qmake build fix.

  • WebCore.pro:
12:46 PM Changeset in webkit [29724] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Adam Roben.

<rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail

  • DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
12:45 PM Changeset in webkit [29723] by alp@webkit.org
  • 9 edits
    2 adds
    2 deletes in trunk

2008-01-22 Christian Dywan <​christian@imendio.com>

Reviewed by Alp Toker.

[GTK] API: WebKitWebSettings is not usable
​http://bugs.webkit.org/show_bug.cgi?id=16219

Implement WebKitWebSettings.

11:33 AM Changeset in webkit [29722] by Adam Roben
  • 6 edits
    9 adds in trunk

Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

WebCore:

Add HTMLFrameOwnerElement::scrollingMode

This new virtual method is overridden by HTMLFrameElementBase to
provide the scrolling mode set on the frame or iframe element. Object
elements always have scrolling=auto, so there's no need to override
this method for HTMLPlugInElement.

Reviewed by Hyatt.

  • html/HTMLFrameElementBase.h: Declare scrollingMode as virtual.
  • html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::scrollingMode): Added.

WebKit/win:

Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

Now that we have multiple FrameViews per Frame on Windows, we need to
make sure each FrameView gets its scrolling mode set correctly. On Mac
this works because WebFrameView holds the scrolling mode and a single
WebFrameView is shared by many FrameViews. On Windows, we have no such
shared object, so we just ask the Frame's owner element for the
scrolling mode.

Tests: fast/frames/frame-scrolling-attribute.html

fast/frames/iframe-scrolling-attribute.html

Reviewed by Hyatt.

  • WebFrame.cpp: (WebFrame::transitionToCommittedForNewPage): Set the scrolling mode on the FrameView based on the scrolling mode of the Frame's owner element.

LayoutTests:

Tests for <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

Reviewed by Hyatt.

  • fast/frames/frame-scrolling-attribute.html: Added.
  • fast/frames/iframe-scrolling-attribute.html: Added.
  • platform/mac/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
  • platform/mac/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/mac/fast/frames/frame-scrolling-attribute-expected.txt: Added.
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.png: Added.
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt: Added.
9:36 AM Changeset in webkit [29721] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5698481> REGRESSION: Web Inspector source view gutter double divider and no padding

Now that cellpadding cascades properly on <td>s, we need to make the view source padding rules in the user
agent sheet have !important in order to override author settings.

Reviewed by Tim

  • css/view-source.css:
8:09 AM Changeset in webkit [29720] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Reviewed by Alp.
Allow to use SVGPaintServerSolid without RenderObject/RenderStyle. Used later to draw SVG Fonts in HTML.

6:57 AM Changeset in webkit [29719] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Alp.

Initialize missing variables, m_lineGap / m_lineSpacing.
Only noticeable when trying to render HTML text using SVG Fonts (which is not possible with trunk, but with my local version).

5:53 AM Changeset in webkit [29718] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-01-22 Alp Toker <​alp@atoker.com>

Reviewed by Nikolas.

Fix Cairo SVG fonts following changes in r29700.

Set the font description's details as needed in FontPlatformData and
eliminate GraphicsContext::setPlatformFont() since it was redundant
and assumed all fonts were Cairo fonts.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
3:10 AM Changeset in webkit [29717] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

<rdar://problem/5699344> Reproducible crash when navigating back to a page using SVG fonts

Test: svg/custom/font-platformDestroy-crash.svg

2:03 AM Changeset in webkit [29716] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Lars Knoll <​lars@trolltech.com>

setup a family for cursive and fantasy fonts as well.

2:03 AM Changeset in webkit [29715] by Simon Hausmann
  • 2 edits in trunk/WebCore

Lars Knoll <​lars@trolltech.com>

cleanup the CookieJarQt implementation and implement cookiesEnabled.

2:03 AM Changeset in webkit [29714] by Simon Hausmann
  • 2 edits in trunk

Simon Hausmann <Simon Hausmann>

Don't compile the ICO plugin when building against Qt >= 4.4

2:03 AM Changeset in webkit [29713] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Benjamin Meyer <​bmeyer@trolltech.com>

Implement ChromeClientQt::setToolTip
Implement ChromeClientQt::mouseDidMoveOverElement

12:38 AM Changeset in webkit [29712] by Simon Hausmann
  • 19 edits
    1 add in trunk

Lars Knoll <​lars@trolltech.com>

Ported the font implementation to use the new QFont features of Qt 4.4.

Jan 21, 2008:

10:48 PM Changeset in webkit [29711] by eric@webkit.org
  • 4 edits in trunk

Reviewed by Nikolas & Oliver.

Tested by svg/custom/svg-features.html

  • dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): use ENABLE(SVG_*) conditionals (WebCore::isSVG11Feature): use ENABLE(SVG_*) conditionals
10:18 PM Changeset in webkit [29710] by ggaren@apple.com
  • 12 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)


(and a bunch of other crashes)


Plus, a .7% SunSpider speedup to boot.


Replaced the buggy currentExec and savedExec mechanisms with an
explicit ExecState stack.

  • kjs/collector.cpp: (KJS::Collector::collect): Explicitly mark the ExecState stack.

(KJS::Collector::reportOutOfMemoryToAllExecStates): Slight change in
behavior: We no longer throw an exception in any global ExecStates,
since global ExecStates are more like pseudo-ExecStates, and aren't
used for script execution. (It's unclear what would happen if you left
an exception waiting around in a global ExecState, but it probably
wouldn't be good.)

WebCore:

Reviewed by Maciej Stachowiak.

Adapted WebCore to the fix for ​http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy): No convenient way to make this assertion anymore. (It wasn't firing for anyone, anyway, so it's no big loss.)
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): Use the ExecState stack, instead of currentExec. (-[WebScriptObject setException:]): ditto. Also, a slight change in behavior: If no ExecStates are active, we no longer throw an exception in the global ExecState. The JavaScriptCore ChangeLog explains why. This also matches the behavior of +throwException.

LayoutTests:

Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)

  • fast/js/exec-state-marking-expected.txt: Added.
  • fast/js/exec-state-marking.html: Added.
4:52 PM Changeset in webkit [29709] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Try to fix Qt build, after the rmdir() fixes.

4:49 PM Changeset in webkit [29708] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Another Wx build fix.

4:30 PM Changeset in webkit [29707] by Darin Adler
  • 2 edits in trunk/WebCore
  • try to fix Qt build
  • platform/qt/FileSystemQt.cpp: (WebCore::deleteEmptyDirectory): QDir::root().rmdir() instead of QDir::rmdir().
4:05 PM Changeset in webkit [29706] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Not reviewed. Yet another win/gtk build fix.

3:43 PM Changeset in webkit [29705] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Another build fix for Gtk/Linux & Wx/Mac.

3:26 PM Changeset in webkit [29704] by Nikolas Zimmermann
  • 4 edits in trunk/WebCore

Not reviewed. Build fix for Qt/Gtk & Wx.

3:16 PM Changeset in webkit [29703] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Not reviewed. Build fix for ports that don't build SVG: wx.

3:12 PM Changeset in webkit [29702] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. (First) Build fix for Qt/Gtk.

3:06 PM Changeset in webkit [29701] by alp@webkit.org
  • 7 edits in trunk

2008-01-21 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16955
Get errors when cross-compile webkit-gtk

2:56 PM Changeset in webkit [29700] by Nikolas Zimmermann
  • 86 edits
    6 adds
    2 deletes in trunk

Reviewed by Eric. Older parts reviewed by Dan.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=16880 (SVGCSSFontFace should die, instead integrate within the FontCache.)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=16784 (In-document fonts work only as the first child to font-face-src)

Proper integration of SVG Fonts within the existing custom font concept, removing the need for a custom SVGCSSFontFace.
Integrate within the CSSFontFaceSource logic for caching support, as well as the framework for external SVG Fonts.

Proper handling of missing glyphs, using <missing-glyph> element. If that is not specified in a font, fallback to non-SVG font rendering.

2:43 PM Changeset in webkit [29699] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-21 Alp Toker <​alp@atoker.com>

GTK+ build fix for breakage introduced in r29698.

  • WebCoreSupport/ChromeClientGtk.h:
2:23 PM Changeset in webkit [29698] by Darin Adler
  • 53 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
  • remove the default database quota setting
  • simplify the quota-related client calls by merging the one for a new database with the one for an existing database, adding a feature where you can get details about a database being created using the same functions that work on the other databases, and removing the parameters and return values, instead having clients use a function to set the quota
  • fix unsafe multi-thread access to the database tracker's quota map
  • fix bug in deleteAllDatabases where it would iterate a HashMap while modifying it

The tracker database is now only created when we set the quota for a database origin.
Thus asking for info about databases won't cause anything to be written to disk.

  • WebCore.base.exp: Updated.
  • bindings/js/GCController.cpp: Added an #if to get rid of an unused function warning.
  • page/Chrome.cpp: Removed database-related functions. There's no problem having the code deal directly with the client.
  • page/Chrome.h: Ditto. Also made Chrome inherit from Noncopyable.
  • page/ChromeClient.h: Replaced the two quota-related functions with a single one. The details about the state of databases in the origin are now available by asking for database details. There's also no need to pass the security origin, since it's easy to get that from the frame's document.
  • page/Settings.cpp: Removed the default quota setting.
  • page/Settings.h: Ditto.
  • platform/FileSystem.h: Added deleteEmptyDirectory.
  • platform/gtk/FileSystemGtk.cpp: (WebCore::deleteEmptyDirectory): Added.
  • platform/posix/FileSystemPOSIX.cpp: (WebCore::deleteEmptyDirectory): Added.
  • platform/qt/FileSystemQt.cpp: (WebCore::deleteEmptyDirectory): Added.
  • platform/win/FileSystemWin.cpp: (WebCore::deleteEmptyDirectory): Added.
  • platform/wx/FileSystemWx.cpp: (WebCore::deleteEmptyDirectory): Added placeholder.
  • storage/DatabaseDetails.h: Removed the isValid() function since its name is confusing -- we removed our other isValid() functions. For the few callers that need this, it's fine to just check name().isEmpty(). Made the member functions all const.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Removed m_defaultQuota initialization. Added m_proposedDatabase and m_thread. (WebCore::DatabaseTracker::setDatabaseDirectoryPath): Got rid of code that would open the tracker database here. This might slightly speed up launch time, since we won't do the I/O until we have to, and before we were actually creating an SQL database in this code that's run when we go to the first webpage. (WebCore::DatabaseTracker::trackerDatabasePath): Added. (WebCore::DatabaseTracker::openTrackerDatabase): Added a boolean parameter telling this function whether to create the database. Made this function safe to call if the database is already open. Also made the function fail quietly if the path has not been set yet. (WebCore::DatabaseTracker::canEstablishDatabase): Got rid of the call to the establishEntryForOrigin function. The origin is now put in the tracker database when the quota is set to a non-zero value. When judging if there's enough space for the new database, require at least one byte even if estimatedSize is 0, and check for overflow. Also added code here to populate the origins map, which guarantees it will be ready when the database uses it on another thread later. Also changed this to call the new ChromeClient function. (WebCore::DatabaseTracker::hasEntryForDatabase): Added code to open the tracker database, since that's no longer done by setDatabaseDirectoryPath. (WebCore::DatabaseTracker::originPath): Added. (WebCore::DatabaseTracker::fullPathForDatabase): Added code so that this will return a null string for the proposed database if called from within the ChromeClient function. Also switched from empty string to null string for the error cases. (WebCore::DatabaseTracker::populateOrigins): Added code to open the tracker database. (WebCore::DatabaseTracker::databaseNamesForOrigin): Ditto. (WebCore::DatabaseTracker::detailsForNameAndOrigin): Ditto. Also added code that will return the details of the proposed database if called from within the ChromeClient function. This is how the client can learn of the display name and the estimated size of the new database. (WebCore::DatabaseTracker::setDatabaseDetails): Added code to open the tracker database. (WebCore::DatabaseTracker::quotaForOrigin): Made this code OK to call on a non-main thread by using m_quotaMapGuard to guard access to the map. Other code runs on the main thread only, and only functions that write to the map use the lock. (WebCore::DatabaseTracker::setQuota): Changed this function so it can insert the initial quota as well as updating an existing quota. Added locking since this function modifies the quota map. Added code to open the tracker database. Added an early exit if the quota is already correct, which is guarantees that if you set a quota to 0 it won't trigger creation of a tracker database. (WebCore::DatabaseTracker::addDatabase): Added code to open the tracker database. (WebCore::DatabaseTracker::deleteAllDatabases): Made a copy of the quota map before iterating it to find all the origins. This fixes a problem with the old code where it would modify the map while iterating it, which gives assertions in debug builds and unpredictable results. (WebCore::DatabaseTracker::deleteOrigin): Replaced deleteDatabasesWithOrigin with this function. Added code to open the tracker database if needed. Added code to delete the origin from the tracker database, and to close the tracker database and delete files and directories as needed if we are deleting the final origin. (WebCore::DatabaseTracker::deleteDatabase): Added code to open the tracker database if needed.
  • storage/DatabaseTracker.h: Renamed databasePath to databaseDirectoryPath for clarity, including the data member, and the getter and setter functions. Replaced deleteDatabasesWithOrigin with deleteOrigin. Removed the functions dealing with default origin quota. There is no default any more; origins start with no quota and the client must set a quota. Added trackerDatabasePath and originPath helper functions. Added a boolean parameter to openTrackerDatabase to tell it whether to create the database or not. Removed the establishEntryForOrigin function. Renamed m_originQuotaMap to just m_quotaMap, and added m_quotaMapGuard. Added a QuotaMap typedef. Added m_proposedDatabase, which holds the origin and details for the current proposed database during the client callback function that must decide whether to grant quota. Added a m_thread data member for debugging use to assert if functions that can only be called on a single thread are misused.
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Changed to call the new exceededDatabaseQuota function instead of the old one.
  • svg/graphics/SVGImageEmptyClients.h: Updated for the change to ChromeClient.

WebKit/gtk:

Reviewed by John Sullivan.

  • updated for changes to database functions
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota):
  • WebCoreSupport/ChromeClientGtk.h:
  • WebView/webkitprivate.cpp: (webkit_init):

WebKit/mac:

Reviewed by John Sullivan.

  • fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
  • add a missing export of WebDatabaseExpectedSizeKey
  • implement deleteOrigin: and remove deleteDatabasesWithOrigin:
  • Storage/WebDatabaseManager.mm: (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null name instead of calling isValid(). (-[WebDatabaseManager deleteOrigin:]): Implemented. (WebKitInitializeDatabasesIfNecessary): Updated for name change.
  • Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
  • WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions we had before with a single one.
  • WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
  • WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
  • WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and setDefaultDatabaseQuota:.
  • WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate methods we had before with a single one.
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Removed the code to set the default database origin quota in WebCore::Settings based on WebPreferences.
  • WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual types of parameters that the database UI delegate methods had before.

WebKit/qt:

Reviewed by John Sullivan.

  • updated for changes to ChromeClient database functions
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::exceededDatabaseQuota):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Reviewed by John Sullivan.

  • fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
  • fix incorrect value for WebDatabaseDisplayNameKey in header


  • Interfaces/IWebDatabaseManager.idl: Renamed detailsForDatabaseWithOrigin to detailsForDatabase. Replaced deleteDatabasesWithOrigin with deleteOrigin. Renamed deleteDatabaseWithOrigin to deleteDatabase. Fixed incorrect value for WebDatabaseDisplayNameKey.
  • Interfaces/IWebPreferencesPrivate.idl: Removed defaultDatabaseQuota and setDefaultDatabaseQuota.
  • Interfaces/IWebUIDelegatePrivate.idl: Replaced the two database quota functions with a single one.
  • WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Replaced the two database quota functions with a single one.
  • WebChromeClient.h: Ditto.
  • WebDatabaseManager.cpp: (WebDatabaseManager::detailsForDatabase): Changed to check for a name of null to detect a nonexistent database rather than using isValid. (WebDatabaseManager::deleteOrigin): Updated for name change (actually a semantic change too, but both have the same name). (WebDatabaseManager::deleteDatabase): Updated for name change. (WebKitSetWebDatabasesPathIfNecessary): Ditto.
  • WebDatabaseManager.h: Updated for name changes.
  • WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Removed the default for WebKitDefaultDatabaseQuotaKey.
  • WebPreferences.h: Removed defaultDatabaseQuota and setDefaultDatabaseQuota.
  • WebView.cpp: (WebView::notifyPreferencesChanged): Removed the code to set the default database origin quota in WebCore::Settings based on IWebPreferencesPrivate.

WebKit/wx:

Reviewed by John Sullivan.

  • updated for changes to ChromeClient database functions
  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::exceededDatabaseQuota):
  • WebKitSupport/ChromeClientWx.h:
1:52 PM Changeset in webkit [29697] by Nikolas Zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

Rubber stamped by Oliver.
Add missing layout test results.

1:19 PM Changeset in webkit [29696] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16935

Fix a bug in layers where the positioned ancestor was being computed incorrectly (the root should not
automatically be included).

Reviewed by olliej

Added fast/layers/positioned-inside-root-with-margins.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor):

LayoutTests:

​http://bugs.webkit.org/show_bug.cgi?id=16935

Reviewed by olliej

  • fast/layers/positioned-inside-root-with-margins.html: Added.
  • platform/mac/fast/layers/positioned-inside-root-with-margins-expected.checksum: Added.
  • platform/mac/fast/layers/positioned-inside-root-with-margins-expected.png: Added.
  • platform/mac/fast/layers/positioned-inside-root-with-margins-expected.txt: Added.
11:00 AM Changeset in webkit [29695] by adele@apple.com
  • 2 edits in trunk/LayoutTests

Adding media/{audio,video}-controls-rendering.html back to the skipped list, since they're still failing on some machines.

  • platform/win/Skipped:
8:59 AM Changeset in webkit [29694] by Darin Adler
  • 2 edits in trunk/WebKitTools

Reviewed by Mitz and Adam.

  • Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the sorting speed by doing all sort criteria in a single pass instead of three sorts.
3:37 AM QtWebKitContrib edited by Simon Hausmann
(diff)
3:06 AM Changeset in webkit [29693] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Benjamin Meyer <​bmeyer@trolltech.com>

Change QWebHistoryInterface::addHistoryEntry() from const to non-const

3:06 AM Changeset in webkit [29692] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Adam Treat <​treat@kde.org>

  • Don't leak the d-pointer in QWebSettings.
2:47 AM Changeset in webkit [29691] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Update the WebKit version number from WebKit/win/WebKit.vcproj/VERSION.

This has the fortunate side-effect that gmail sends us sensible HTML/JS again :)

2:41 AM Changeset in webkit [29690] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix KURL to QUrl conversion.

Stick to the encoded version of the URL and in addition to KURL we encode the
characters mentioned in section 2.4.3 of RFC 2396 as QUrl requires these, too.

This fixes fast/css/import-rule-regression-11590.html,
fast/css/import-style-update.html, svg/hixie/processing-model/003.xml and
svg/hixie/processing-model/004.xml.

2:40 AM Changeset in webkit [29689] by Simon Hausmann
  • 10 edits in trunk

Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.

  • Fix GraphicsContext::drawFocusRing to also draw single focus rects.
  • Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events and make the return value depend on whether we successfully determined a focusable node or not.
  • Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly if we could not handle the focus chain ourselves.
  • Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
  • Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only used to control the situation of stepping out of the focus chain inside the page.
  • Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain. The layout tests expect this to be disabled but for the user it seems sensible to have it on by default, hence the default in qwebsettings.cpp
2:40 AM Changeset in webkit [29688] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix access key support and fast/forms/legend-access-key.html

SVN revision 26664 changed the default access key for the non-mac build to Alt
while this test relies on Ctrl.

2:39 AM Changeset in webkit [29687] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix error reporting when parsing X(HT)ML fragments.

We use the regular XMLTokenizer write()/.../end() sequence to parse those
fragments, but we should not report any parsing errors inline inside the
content. Instead we should just return the error and the DOM layer will take
care of throwing an exception.

This fixes fast/innerHTML/innerHTML-changing-document-properties.xhtml

1:10 AM Changeset in webkit [29686] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Freyther <​holger.freyther@trolltech.com>

Fix some issues with redirections.

  • Ensure that we deliver the response to the ResourceHandleClient only once by setting m_responseSent back to false only before calling start() for the redirection
  • Added 307 as another HTTP status code that causes a redirection after POST to become get, just like in MainResourceLoader::isPostOrRedirectAfterPost
  • Also set the HTTP method on the ResourceRequest to GET before passing it to willSendRequest.
  • willSendRequest's newRequest argument is actually an in/out argument and could be modified in theory, so set m_request accordingly after the call.
1:09 AM Changeset in webkit [29685] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Freyther <​holger.freyther@trolltech.com>

Fixed WebCore::cookies() to return all cookies, not only the first one.

Fixes login into mail.yahoo.com.

1:01 AM Changeset in webkit [29684] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Try to make the test less timing dependent to fix occasional test bot failures.

  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
12:36 AM Mobile edited by mrowe@apple.com
(diff)

Jan 20, 2008:

11:07 PM Changeset in webkit [29683] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-20 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Attach the widget's style to its window and set the background to the
base background to avoid black flicker when repainting. This is
similar to what GtkTextView does.

  • WebView/webkitwebview.cpp:
9:34 PM Changeset in webkit [29682] by mrowe@apple.com
  • 4 edits in trunk/WebKit

Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer interested in supporting Safari 2 with TOT WebKit.

Reviewed by Dan Bernstein.

  • WebKit.xcodeproj/project.pbxproj: Don't define REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as it is no longer used.
  • mac/WebView/WebView.mm:

(+[WebView initialize]):

8:30 PM Changeset in webkit [29681] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16816 , rdar://problem/5682985

Reviewed by Mitz

Correctly trigger willPerformDragDestinationAction when a drop causes a
load to occur. The logic that originally did this was lost during the
great drag migration of '07.

8:04 PM Changeset in webkit [29680] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • update Tiger-specific results for r29667
  • platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
6:01 PM Changeset in webkit [29679] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Assertion failure in FrameView::scheduleRelayout (!m_frame->document()
!m_frame->document()->inPageCache()) when going back from a page with a focused popup
  • dom/Document.cpp: (WebCore::Document::setFocusedNode): Bail out if the document is in the page cache. Documents in the back/forward cache are "frozen" and should not change state.
3:18 PM Changeset in webkit [29678] by weinig@apple.com
  • 3 edits
    10 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16775

We now use frame()->loader()->url() for postMessage, preventing a
malicious sender from overwriting the uri property (using a <base> tag,
for example). Also, use frame->loader()->url().host() instead of
instead of document()->SecurityOrigin()->domain() to reflect a recent
clarification in the HTML5 spec.

Tests: http/tests/security/postMessage/domain-affected-by-document-domain.html

http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html
http/tests/security/postMessage/javascript-page-still-sends-domain.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):

LayoutTests:

Reviewed by Sam Weinig.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=16775

  • http/tests/security/postMessage: Added.
  • http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag-expected.txt: Added.
  • http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html: Added.
  • http/tests/security/postMessage/domain-unaffected-by-document-domain-expected.txt: Added.
  • http/tests/security/postMessage/domain-unaffected-by-document-domain.html: Added.
  • http/tests/security/postMessage/javascript-page-still-sends-domain-expected.txt: Added.
  • http/tests/security/postMessage/javascript-page-still-sends-domain.html: Added.
  • http/tests/security/postMessage/resources: Added.
  • http/tests/security/postMessage/resources/javascript-post-message-sender.html: Added.
  • http/tests/security/postMessage/resources/post-message-listener.html: Added.
1:22 PM Changeset in webkit [29677] by Antti Koivisto
  • 5 edits in trunk

WebCore:

Reviewed by Adele.

Fix <rdar://problem/5695451>
Middle part of the media timeline missing on Windows if load failed

Add some null checking to avoid getting garbage results from the functions.

  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::duration): (QTMovieWin::currentTime): (QTMovieWin::setCurrentTime): (QTMovieWin::maxTimeLoaded):

LayoutTests:

Reviewed by Adele.

Update test so it checks the state of time related properties after the failure.

  • media/video-error-does-not-exist-expected.txt:
  • media/video-error-does-not-exist.html:

Jan 19, 2008:

8:53 PM Changeset in webkit [29676] by alp@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix 'Reviewed by' typo in ChangeLog

8:49 PM Changeset in webkit [29675] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-19 Alp Toker <​alp@atoker.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16944
Use of GST_PLUGIN_DEFINE_STATIC results in a module-level constructor

​http://bugzilla.gnome.org/show_bug.cgi?id=510547
Epiphany/Webkit fails to start due to initializing threads twice

Don't call GST_PLUGIN_DEFINE_STATIC() as it performs g_thread_init()
in the global initializer, breaking subsequent calls to
g_thread_init() in applications.

  • platform/graphics/gtk/VideoSinkGStreamer.cpp:
8:25 PM WikiStart edited by webkit@mattlilek.com
Remove spam (diff)
10:51 AM Changeset in webkit [29674] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Allow the --http flag to run-webkit-tests to override
the default behaviour of disabling HTTP tests for Qt,
Gtk and Wx.

Reviewed by Alp Toker.

  • Scripts/run-webkit-tests:
10:34 AM Changeset in webkit [29673] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-19 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Remove any fragment part from the URL to be requested just before
passing it to curl, otherwise curl sends it as part of the HTTP/local
file request, causing page loads to fail.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
10:27 AM Changeset in webkit [29672] by mrowe@apple.com
  • 272 edits in trunk

Set svn:eol-style=native on .idl and .c files that were missed in r29663.

10:10 AM Changeset in webkit [29671] by mrowe@apple.com
  • 9 edits in trunk/WebKit/win

2008-01-19 Mark Rowe <​mrowe@apple.com>

Fix inconsistent line endings and set svn:eol-style=native
on IDL files that did not have it set.

  • Interfaces/IGEN_DOMObject.idl:
7:46 AM Changeset in webkit [29670] by alp@webkit.org
  • 4 edits in trunk

2008-01-19 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

Add svg foreign object and svg experimental to the GTK+/autotools
build system.

5:58 AM Changeset in webkit [29669] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-19 Christian Dywan <​christian@imendio.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16882
[GTK] ChromeClientGtk is incompete

Implement these functions.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::scaleFactor): (WebKit::ChromeClient::focus): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::takeFocus): (WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel):
2:43 AM Changeset in webkit [29668] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<rdar://problem/5695344> check-for-global-initializers script never checks any object files

Reviewed by Darin.

We now touch a check-for-global-initializers.timestamp file in
the TARGET_TEMP_DIR directory to determine when new object files
have been compiled and thus need to be checked. If the timestamp
file doesn't exist, all object files will be checked.

Previously the modification time of the "executable" (the
framework binary, e.g., WebKit.framework/WebKit) was used, but
since this was the last file modified at the end of the compile
phase, no object files would ever get checked!

Also added JSCustomSQLTransactionCallback.o to the list of files
since it has static initializers in Debug builds of WebCore.

  • Scripts/check-for-global-initializers:
2:12 AM Changeset in webkit [29667] by mitz@apple.com
  • 21 edits
    5 adds in trunk

WebCore:

Reviewed by Maciej Stachowiak.

  • fix <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116

Test: editing/selection/inconsistent-in-removeChildNode.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): If the selection base or extent are not visible any more, adjust the selection.

LayoutTests:

Reviewed by Maciej Stachowiak.

  • test and updated results for <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
  • editing/selection/inconsistent-in-removeChildNode.html: Added.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
  • platform/mac-leopard/editing/selection: Added.
  • platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.checksum: Added.
  • platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.png: Added.
  • platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
  • platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-011-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/execCommand/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt: Added.
  • platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/mac/editing/selection/replace-selection-1-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-expected.txt:
  • platform/mac/editing/style/remove-underline-in-bold-expected.txt:
  • platform/mac/editing/style/unbold-in-bold-expected.txt:
1:43 AM Changeset in webkit [29666] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix for --svg-foreign-object path

Reviewed by Eric Seidel

Jan 18, 2008:

11:49 PM Changeset in webkit [29665] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-18 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16910
[GTK] REGRESSION: keyboard cursor doesn't blink

​http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] REGRESSION: tab focusing doesn't work

  • WebView/webkitwebview.cpp: (webkit_web_view_focus_in_event): Added. Set the active frame. (webkit_web_view_class_init):
10:01 PM Changeset in webkit [29664] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-01-18 Stephanie <Stephanie Lewis>

Reviewed by Oliver.

Workaround for rdar:5695848. Set mime_type for local files based on file extension.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
9:49 PM Changeset in webkit [29663] by Darin Adler
  • 1327 edits in trunk

set eol-style to native on tons of files to head off future mixed-line-ending problems

5:44 PM Changeset in webkit [29662] by adele@apple.com
  • 2 edits
    1 delete in trunk/LayoutTests

Reviewed by Oliver.

Fix for <rdar://5683527> media/{audio,videocontrols-rendering.html failing


Remove platform specific results from media directory, since they should match the mac. Also, remove these tests from the skipped list.


  • platform/win/Skipped:
  • platform/win/media: Removed.
5:30 PM Changeset in webkit [29661] by adele@apple.com
  • 9 edits in trunk/LayoutTests

Updating these results again. I accidently checked in the other results with some local changes.

  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-seek-past-end-playing-expected.checksum:
  • platform/mac/media/video-seek-past-end-playing-expected.png:
5:11 PM Changeset in webkit [29660] by kmccullough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • Build fix.
  • kjs/ustring.h:
4:58 PM Changeset in webkit [29659] by Beth Dakin
  • 3 edits in trunk/LayoutTests

Rubber stamped by Darin.

These are updated test results after ​http://bugs.webkit.org/
show_bug.cgi?id=15765 ASSERTION FAILED: m_frame->page() in
FrameLoader::tokenizerProcessedData using the new GMail interface
was checked in. This is a TEMPORARY fix until ​http://
bugs.webkit.org/show_bug.cgi?id=16853 really addresses this
problem.

  • http/tests/loading/gmail-assert-on-load-expected.txt:
  • http/tests/loading/onload-vs-immediate-refresh-expected.txt:
4:55 PM Changeset in webkit [29658] by kmccullough@apple.com
  • 2 edits in trunk/LayoutTests

Rubber stamped by Geoff.

  • <rdar://5667267> editing/selection/5131716-1.html is failing The problem is when the fonts are not present, but they should be available now. This may have failed for other reasons in the past that are now fixed.
  • platform/win/Skipped:
4:24 PM Changeset in webkit [29657] by adachan@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/5682340> REGRESSION (r28188): Context menu appears at wrong place when clicking in iframe whose parent is scrolled (16827)
Calling absolutePosition() in EventHandler::hitTestResultAtPoint() is extremely inefficient and passing in
true as fixed before was wrong. Use HitTestResult::localPoint() instead, and take into account border and padding widths.

Reviewed by Hyatt and Darin.

  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::operator=):
4:09 PM Changeset in webkit [29656] by adele@apple.com
  • 1 edit
    108 adds in trunk/LayoutTests

Reviewed by Antti.

Adding pixel results for media tests.

  • platform/mac/media/audio-constructor-expected.checksum: Added.
  • platform/mac/media/audio-constructor-expected.png: Added.
  • platform/mac/media/audio-constructor-src-expected.checksum: Added.
  • platform/mac/media/audio-constructor-src-expected.png: Added.
  • platform/mac/media/broken-video-expected.checksum: Added.
  • platform/mac/media/broken-video-expected.png: Added.
  • platform/mac/media/constructors-expected.checksum: Added.
  • platform/mac/media/constructors-expected.png: Added.
  • platform/mac/media/fallback-expected.checksum: Added.
  • platform/mac/media/fallback-expected.png: Added.
  • platform/mac/media/progress-event-expected.checksum: Added.
  • platform/mac/media/progress-event-expected.png: Added.
  • platform/mac/media/remove-from-document-expected.checksum: Added.
  • platform/mac/media/remove-from-document-expected.png: Added.
  • platform/mac/media/unsupported-rtsp-expected.checksum: Added.
  • platform/mac/media/unsupported-rtsp-expected.png: Added.
  • platform/mac/media/unsupported-tracks-expected.checksum: Added.
  • platform/mac/media/unsupported-tracks-expected.png: Added.
  • platform/mac/media/video-append-source-expected.checksum: Added.
  • platform/mac/media/video-append-source-expected.png: Added.
  • platform/mac/media/video-autoplay-expected.checksum: Added.
  • platform/mac/media/video-autoplay-expected.png: Added.
  • platform/mac/media/video-buffered-expected.checksum: Added.
  • platform/mac/media/video-buffered-expected.png: Added.
  • platform/mac/media/video-controls-expected.checksum: Added.
  • platform/mac/media/video-controls-expected.png: Added.
  • platform/mac/media/video-currentTime-expected.checksum: Added.
  • platform/mac/media/video-currentTime-expected.png: Added.
  • platform/mac/media/video-currentTime-set-expected.checksum: Added.
  • platform/mac/media/video-currentTime-set-expected.png: Added.
  • platform/mac/media/video-currentTime-set2-expected.checksum: Added.
  • platform/mac/media/video-currentTime-set2-expected.png: Added.
  • platform/mac/media/video-dom-autoplay-expected.checksum: Added.
  • platform/mac/media/video-dom-autoplay-expected.png: Added.
  • platform/mac/media/video-dom-end-expected.checksum: Added.
  • platform/mac/media/video-dom-end-expected.png: Added.
  • platform/mac/media/video-dom-loopcount-expected.checksum: Added.
  • platform/mac/media/video-dom-loopcount-expected.png: Added.
  • platform/mac/media/video-dom-loopend-expected.checksum: Added.
  • platform/mac/media/video-dom-loopend-expected.png: Added.
  • platform/mac/media/video-dom-loopstart-expected.checksum: Added.
  • platform/mac/media/video-dom-loopstart-expected.png: Added.
  • platform/mac/media/video-dom-src-expected.checksum: Added.
  • platform/mac/media/video-dom-src-expected.png: Added.
  • platform/mac/media/video-dom-start-expected.checksum: Added.
  • platform/mac/media/video-dom-start-expected.png: Added.
  • platform/mac/media/video-end-expected.checksum: Added.
  • platform/mac/media/video-end-expected.png: Added.
  • platform/mac/media/video-error-abort-expected.checksum: Added.
  • platform/mac/media/video-error-abort-expected.png: Added.
  • platform/mac/media/video-error-does-not-exist-expected.checksum: Added.
  • platform/mac/media/video-error-does-not-exist-expected.png: Added.
  • platform/mac/media/video-load-networkState-expected.checksum: Added.
  • platform/mac/media/video-load-networkState-expected.png: Added.
  • platform/mac/media/video-load-readyState-expected.checksum: Added.
  • platform/mac/media/video-load-readyState-expected.png: Added.
  • platform/mac/media/video-loopcount-expected.checksum: Added.
  • platform/mac/media/video-loopcount-expected.png: Added.
  • platform/mac/media/video-loopend-expected.checksum: Added.
  • platform/mac/media/video-loopend-expected.png: Added.
  • platform/mac/media/video-loopstart-expected.checksum: Added.
  • platform/mac/media/video-loopstart-expected.png: Added.
  • platform/mac/media/video-muted-expected.checksum: Added.
  • platform/mac/media/video-muted-expected.png: Added.
  • platform/mac/media/video-no-autoplay-expected.checksum: Added.
  • platform/mac/media/video-no-autoplay-expected.png: Added.
  • platform/mac/media/video-pause-empty-events-expected.checksum: Added.
  • platform/mac/media/video-pause-empty-events-expected.png: Added.
  • platform/mac/media/video-play-empty-events-expected.checksum: Added.
  • platform/mac/media/video-play-empty-events-expected.png: Added.
  • platform/mac/media/video-play-pause-events-expected.checksum: Added.
  • platform/mac/media/video-play-pause-events-expected.png: Added.
  • platform/mac/media/video-play-pause-exception-expected.checksum: Added.
  • platform/mac/media/video-play-pause-exception-expected.png: Added.
  • platform/mac/media/video-poster-expected.checksum: Added.
  • platform/mac/media/video-poster-expected.png: Added.
  • platform/mac/media/video-seek-past-end-paused-expected.checksum: Added.
  • platform/mac/media/video-seek-past-end-paused-expected.png: Added.
  • platform/mac/media/video-seek-past-end-playing-expected.checksum: Added.
  • platform/mac/media/video-seek-past-end-playing-expected.png: Added.
  • platform/mac/media/video-seekable-expected.checksum: Added.
  • platform/mac/media/video-seekable-expected.png: Added.
  • platform/mac/media/video-seeking-expected.checksum: Added.
  • platform/mac/media/video-seeking-expected.png: Added.
  • platform/mac/media/video-size-expected.checksum: Added.
  • platform/mac/media/video-size-expected.png: Added.
  • platform/mac/media/video-source-expected.checksum: Added.
  • platform/mac/media/video-source-expected.png: Added.
  • platform/mac/media/video-source-media-expected.checksum: Added.
  • platform/mac/media/video-source-media-expected.png: Added.
  • platform/mac/media/video-source-type-expected.checksum: Added.
  • platform/mac/media/video-source-type-expected.png: Added.
  • platform/mac/media/video-src-change-expected.checksum: Added.
  • platform/mac/media/video-src-change-expected.png: Added.
  • platform/mac/media/video-src-expected.checksum: Added.
  • platform/mac/media/video-src-expected.png: Added.
  • platform/mac/media/video-src-remove-expected.checksum: Added.
  • platform/mac/media/video-src-remove-expected.png: Added.
  • platform/mac/media/video-src-set-expected.checksum: Added.
  • platform/mac/media/video-src-set-expected.png: Added.
  • platform/mac/media/video-src-source-expected.checksum: Added.
  • platform/mac/media/video-src-source-expected.png: Added.
  • platform/mac/media/video-start-expected.checksum: Added.
  • platform/mac/media/video-start-expected.png: Added.
  • platform/mac/media/video-volume-expected.checksum: Added.
  • platform/mac/media/video-volume-expected.png: Added.
  • platform/mac/media/video-width-height-expected.checksum: Added.
  • platform/mac/media/video-width-height-expected.png: Added.
4:04 PM Changeset in webkit [29655] by Beth Dakin
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Darin, landed by Beth.

The call to HTMLTokenizer::write might result in a call to ::end which will invoke
HTMLParser::finished() or Document::finishedParsing(). HTMLParser::finished() will eventually
call Document::finishedParsing. The Document will delete the calling HTMLTokenizer and from the deleted
tokenizer we will call into FrameLoader::tokenizerProcessedData.
-) FrameLoader::tokenizerProcessedData calls FrameLoader::checkCompleted which gets called from the Document::finishedParsing

(FrameLoader::finishedParsing).

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::timerFired):

LayoutTests:

Reviewed by Darin, landed by Beth.

-test for ​http://bugs.webkit.org/show_bug.cgi?id=15765
Gmail hitting an assert in FrameLoader::tokenizerProcessedData

  • http/tests/loading/gmail-assert-on-load-expected.txt: Added.
  • http/tests/loading/gmail-assert-on-load.html: Added.
  • http/tests/loading/resources/gmail-assert-on-load-frame.html: Added.
4:01 PM Changeset in webkit [29654] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Beth Dakin.

Fix for <rdar://problem/5683524> http/tests/security/cross-frame-access-get.html is failing

  • Guard against possible timing related failures using polling.
  • http/tests/security/:
  • http/tests/security/resources/cross-frame-iframe-for-get-test.html:
4:00 PM Changeset in webkit [29653] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore
  • Build fix.
  • kjs/ustring.cpp:
  • kjs/ustring.h: (KJS::UString::cost):
3:33 PM Changeset in webkit [29652] by weinig@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Remove incorrect addition of ChangeLog as changed in the ChangeLog.

3:20 PM Changeset in webkit [29651] by hyatt@apple.com
  • 29 edits in trunk/LayoutTests

Update inline results after previous checkins. New results match Firefox more closely.

  • platform/mac/fast/inline/001-expected.checksum:
  • platform/mac/fast/inline/001-expected.png:
  • platform/mac/fast/inline/002-expected.checksum:
  • platform/mac/fast/inline/002-expected.png:
  • platform/mac/fast/inline/br-text-decoration-expected.checksum:
  • platform/mac/fast/inline/br-text-decoration-expected.png:
  • platform/mac/fast/inline/continuation-outlines-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-expected.png:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.checksum:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.checksum:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/mac/fast/inline/outline-continuations-expected.checksum:
  • platform/mac/fast/inline/outline-continuations-expected.png:
  • platform/mac/fast/inline/positionedLifetime-expected.checksum:
  • platform/mac/fast/inline/positionedLifetime-expected.png:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png:
3:10 PM Changeset in webkit [29650] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Don't apply the border/margin/padding check to root line boxes, since their renderers
are blocks.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically):
2:59 PM Changeset in webkit [29649] by hyatt@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

Not reviewed: rolling out a previous patch.


Fixed <rdar://problem/5695439> Crash during GCController destructor on
quitting browser

Used svn merge to roll out r29603 because it introduced some crashes
on quit.


GC relies on static hash tables, so it's not safe to GC from a static
destructor, which might run after the static hash tables' destructors.

  • bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectNow):
  • bindings/js/GCController.h:

LayoutTests:

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15665

Reviewed by Beth

  • fast/inline/inline-padding-disables-text-quirk.html: Added.
  • platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.checksum: Added.
  • platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.png: Added.
  • platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.txt: Added.
2:50 PM Changeset in webkit [29648] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Not reviewed: rolling out a previous patch.


Fixed <rdar://problem/5695439> Crash during GCController destructor on
quitting browser

Used svn merge to roll out r29603 because it introduced some crashes
on quit.


GC relies on static hash tables, so it's not safe to GC from a static
destructor, which might run after the static hash tables' destructors.

  • bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectNow):
  • bindings/js/GCController.h:
1:56 PM Changeset in webkit [29647] by hyatt@apple.com
  • 51 edits
    2 adds in trunk

WebCore:

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14975

Computed size of padding is incorrect because we default padding to auto. This is a made-up value that
was only used to implement cellpadding on tables. We needed this made-up value in order to tell that
padding wasn't set so that we could then apply cellpadding.


This patch rewrites cellpadding to be like other browsers. Instead of being a setting on the table
renderer that applies to all cells (even ones that were not <td>s), cellpadding is now mapped into the
style of <td>s. With this change it effectively becomes a content model feature and not a rendering
feature.

For example, a <td> will pick up cellpadding even when it is not a cell and/or the enclosing <table> is
not a table. Anonymous cells and CSS-display-type cells will now never pick up cellpadding. This behavior
is all consistent with other browsers.

Reviewed by Antti

Added fast/css/padding-no-renderer.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::styleForElement):
  • css/CSSStyleSelector.h:
  • dom/StyledElement.cpp:
  • dom/StyledElement.h: (WebCore::StyledElement::canHaveAdditionalAttributeStyleDecls): (WebCore::StyledElement::additionalAttributeStyleDecls):
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
  • html/HTMLTableCellElement.h: (WebCore::HTMLTableCellElement::canHaveAdditionalAttributeStyleDecls):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
  • html/HTMLTableColElement.h: (WebCore::HTMLTableColElement::canHaveAdditionalAttributeStyleDecls):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::additionalAttributeStyleDecls): (WebCore::HTMLTableElement::addSharedCellDecls): (WebCore::HTMLTableElement::addSharedCellBordersDecl): (WebCore::HTMLTableElement::addSharedCellPaddingDecl): (WebCore::HTMLTableElement::addSharedGroupDecls): (WebCore::HTMLTableElement::attach):
  • html/HTMLTableElement.h: (WebCore::HTMLTableElement::canHaveAdditionalAttributeStyleDecls):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
  • html/HTMLTableSectionElement.h: (WebCore::HTMLTableSectionElement::canHaveAdditionalAttributeStyleDecls):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight):
  • rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::initialPadding):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable):
  • rendering/RenderTable.h:

LayoutTests:

Updated results for ​http://bugs.webkit.org/show_bug.cgi?id=14975

Reviewed by Antti

  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/padding-no-renderer-expected.txt: Added.
  • fast/css/padding-no-renderer.html: Added.
  • platform/mac/fast/css/acid2-expected.checksum:
  • platform/mac/fast/css/acid2-expected.png:
  • platform/mac/fast/css/acid2-expected.txt:
  • platform/mac/fast/css/acid2-pixel-expected.checksum:
  • platform/mac/fast/css/acid2-pixel-expected.png:
  • platform/mac/fast/css/acid2-pixel-expected.txt:
  • platform/mac/fast/frames/viewsource-attribute-expected.checksum:
  • platform/mac/fast/frames/viewsource-attribute-expected.png:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
  • platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.checksum:
  • platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.png:
  • platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
  • platform/mac/fast/table/add-before-anonymous-child-expected.checksum:
  • platform/mac/fast/table/add-before-anonymous-child-expected.png:
  • platform/mac/fast/table/add-before-anonymous-child-expected.txt:
  • platform/mac/fast/table/cell-absolute-child-expected.checksum:
  • platform/mac/fast/table/cell-absolute-child-expected.png:
  • platform/mac/fast/table/cell-absolute-child-expected.txt:
  • platform/mac/fast/table/frame-and-rules-expected.checksum:
  • platform/mac/fast/table/frame-and-rules-expected.png:
  • platform/mac/fast/table/frame-and-rules-expected.txt:
  • platform/mac/http/tests/misc/acid2-expected.checksum:
  • platform/mac/http/tests/misc/acid2-expected.png:
  • platform/mac/http/tests/misc/acid2-expected.txt:
  • platform/mac/http/tests/misc/acid2-pixel-expected.checksum:
  • platform/mac/http/tests/misc/acid2-pixel-expected.png:
  • platform/mac/http/tests/misc/acid2-pixel-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30985-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug30985-expected.png:
  • platform/mac/tables/mozilla/bugs/bug30985-expected.txt:
1:52 PM Changeset in webkit [29646] by mitz@apple.com
  • 4 edits
    9 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5615307> Repro crash in WebKit!WebCore::RenderContainer::destroyLeftoverChildren

Test: fast/table/insert-row-before-form.html

  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): Changed to ensure that the object a new cell is inserted before is a child of the row, and added an assertion that that object is either a cell or a form.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Changed to ensure that the object a new row is inserted before is a child of the table section, and added an assertion that that object is either a table row or a form.

LayoutTests:

Reviewed by Dave Hyatt.

  • tests for <rdar://problem/5615307> Repro crash in WebKit!WebCore::RenderContainer::destroyLeftoverChildren
  • fast/table/insert-cell-before-form.html: Added.
  • fast/table/insert-row-before-form.html: Added.
  • platform/mac-leopard/fast/table: Added.
  • platform/mac-leopard/fast/table/insert-cell-before-form-expected.checksum: Added.
  • platform/mac-leopard/fast/table/insert-cell-before-form-expected.png: Added.
  • platform/mac-leopard/fast/table/insert-row-before-form-expected.checksum: Added.
  • platform/mac-leopard/fast/table/insert-row-before-form-expected.png: Added.
  • platform/mac/fast/table/insert-cell-before-form-expected.txt: Added.
  • platform/mac/fast/table/insert-row-before-form-expected.txt: Added.
1:50 PM Changeset in webkit [29645] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed date.

1:35 PM Changeset in webkit [29644] by Beth Dakin
  • 2 edits
    3 deletes in trunk/LayoutTests

Checked in new results for another test affected by disabling SVG
foreign object.

  • platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Removed.
  • platform/mac/svg/custom/stroke-width-click-expected.checksum: Removed.
  • platform/mac/svg/custom/stroke-width-click-expected.png: Removed.
  • svg/custom/stroke-width-click-expected.txt:
1:33 PM Changeset in webkit [29643] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Brady Eidson.

Fixed <rdar://problem/5622424> World Leak dialog when closing a page
that has a Database


The problem was that each transaction and SQL statement would hold on
to its callback indefinitely. By design, callbacks often establish
reference cycles to temporarily protect their execution environments.
To break the cycle, we need to explicitly release each callback as soon
as it is no longer needed.

  • storage/SQLStatement.cpp: (WebCore::SQLStatement::performCallback): Release our callback objects after performing our callback.
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit): Release our callback objects after the transaction has terminated. (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): ditto.
1:20 PM Changeset in webkit [29642] by ddkilzer@apple.com
  • 1 edit in trunk/JavaScriptCore/kjs/ustring.h

Fix typo in comment.

1:12 PM Changeset in webkit [29641] by sfalken@apple.com
  • 1 delete in tags/Safari-525.5b

Delete unneeded tag.

1:10 PM Changeset in webkit [29640] by sfalken@apple.com
  • 1 copy in tags/Safari-525.5b

New tag.

1:05 PM Changeset in webkit [29639] by kmccullough@apple.com
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

  • Correctly report cost of appended strings to trigger GC.
  • kjs/ustring.cpp: (KJS::): (KJS::UString::Rep::create): (KJS::UString::UString): Don't create unnecssary objects. (KJS::UString::cost): Report cost if necessary but also keep track of reported cost.
  • kjs/ustring.h:

LayoutTests:

Reviewed by Geoff.

  • Correctly report cost of appended strings to trigger GC.
  • fast/js/garbage-collect-after-string-appends-expected.txt: Added.
  • fast/js/garbage-collect-after-string-appends.html: Added.
  • fast/js/resources/garbage-collect-after-string-appends.js: Added.
12:58 PM Changeset in webkit [29638] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Antti.

Fix for <rdar://problem/5679490> media controls fade in and out too jerkily and too slowly

  • rendering/RenderMedia.cpp: Shorten the duration for the fade in/out animation.
12:54 PM Changeset in webkit [29637] by Adam Roben
  • 2 edits in trunk/WebKitTools

Build fix

  • Scripts/build-webkit:
12:16 PM Changeset in webkit [29636] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

12:16 PM Changeset in webkit [29635] by mrowe@apple.com
  • 4 edits in tags/Safari-5525.5

Merge r29600.

12:11 PM Changeset in webkit [29634] by mrowe@apple.com
  • 2 edits in tags/Safari-5525.5/WebKitTools

Merge r29580.

12:06 PM Changeset in webkit [29633] by Beth Dakin
  • 15 edits
    61 adds in trunk

WebCore:

Reviewed by Oliver.

Disables SVG foreign object for <rdar://problem/5686989> turn off
SVG foreignobject because it does not repaint/dirty correctly

  • DerivedSources.make:
  • WebCore.SVG.ForeignObject.exp: Added.
  • WebCore.SVG.exp:
  • bindings/js/JSSVGElementWrapperFactory.cpp: (WebCore::createJSSVGWrapper):
  • rendering/RenderForeignObject.cpp:
  • rendering/RenderForeignObject.h:
  • svg/SVGForeignObjectElement.cpp:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGForeignObjectElement.idl:
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement):
  • svg/SVGUseElement.cpp: (WebCore::isDisallowedElement):
  • svg/svgtags.in:

WebKitTools:

Reviewed by Oliver.

Update build-webkit to account for foreign-object being disabled by
default.

  • Scripts/build-webkit:

LayoutTests:

Reviewed by Oliver.

Changed test results from disabling SVG foreign object for <rdar://
problem/5686989> turn off SVG foreignobject because it does not
repaint/dirty correctly

  • platform/mac/svg/custom/baseval-animval-equality-expected.checksum: Replaced.
  • platform/mac/svg/custom/baseval-animval-equality-expected.png: Replaced.
  • platform/mac/svg/custom/baseval-animval-equality-expected.txt: Replaced.
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum: Replaced.
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png: Replaced.
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt: Replaced.
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.checksum: Replaced.
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.png: Replaced.
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.txt: Replaced.
  • platform/mac/svg/custom/fill-SVGPaint-interface-expected.checksum: Replaced.
  • platform/mac/svg/custom/fill-SVGPaint-interface-expected.png: Replaced.
  • platform/mac/svg/custom/fill-SVGPaint-interface-expected.txt: Replaced.
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum: Replaced.
  • platform/mac/svg/custom/foreign-object-skew-expected.png: Replaced.
  • platform/mac/svg/custom/foreign-object-skew-expected.txt: Replaced.
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.checksum: Replaced.
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.png: Replaced.
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt: Replaced.
  • platform/mac/svg/custom/getPresentationAttribute-expected.checksum: Replaced.
  • platform/mac/svg/custom/getPresentationAttribute-expected.png: Replaced.
  • platform/mac/svg/custom/getPresentationAttribute-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Replaced.
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.checksum: Replaced.
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.png: Replaced.
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt: Replaced.
  • platform/mac/svg/hixie/mixed/006-expected.checksum: Replaced.
  • platform/mac/svg/hixie/mixed/006-expected.png: Replaced.
  • platform/mac/svg/hixie/mixed/006-expected.txt: Replaced.
  • platform/mac/svg/hixie/mixed/007-expected.checksum: Replaced.
  • platform/mac/svg/hixie/mixed/007-expected.png: Replaced.
  • platform/mac/svg/hixie/mixed/007-expected.txt: Replaced.
  • platform/mac/svg/hixie/mixed/008-expected.checksum: Replaced.
  • platform/mac/svg/hixie/mixed/008-expected.png: Replaced.
  • platform/mac/svg/hixie/mixed/008-expected.txt: Replaced.
  • platform/mac/svg/hixie/mixed/009-expected.checksum: Replaced.
  • platform/mac/svg/hixie/mixed/009-expected.png: Replaced.
  • platform/mac/svg/hixie/mixed/009-expected.txt: Replaced.
  • platform/mac/svg/hixie/mixed/011-expected.checksum: Replaced.
  • platform/mac/svg/hixie/mixed/011-expected.png: Replaced.
  • platform/mac/svg/hixie/mixed/011-expected.txt: Replaced.
12:05 PM Changeset in webkit [29632] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.5

New tag.

11:58 AM Changeset in webkit [29631] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-01-18 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Adam Roben.

Fix mixed line endings in FileSystemWin.cpp and set svn:eol-style to native
to try and keep them consistent in the future.

  • platform/win/FileSystemWin.cpp: (WebCore::fileSize): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::pathByAppendingComponent): (WebCore::fileSystemRepresentation): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath): (WebCore::bundleName): (WebCore::storageDirectory): (WebCore::cachedStorageDirectory):
11:51 AM Changeset in webkit [29630] by Antti Koivisto
  • 3 edits in trunk/WebCore

Reviewed by Adam.

Fix unreachable code warning in RenderVideo on Windows.


Make switch cases explicit.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::isWidthSpecified): (WebCore::RenderImage::isHeightSpecified):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::isWidthSpecified): (WebCore::RenderVideo::isHeightSpecified):
11:49 AM Changeset in webkit [29629] by timothy@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Adam Roben.

<rdar://problem/5693558> REGRESSION (r29581): no form field focus
rings and inactive text selection after loading a page
Bug 16910: [GTK] REGRESSION: keyboard cursor doesn't blink
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance

  • page/FocusController.cpp: (WebCore::FocusController::setActive): Use focusedOrMainFrame() instead of focusedFrame() to call selectionController()->pageActivationChanged() for cases when the focusedFrame() has not been set yet.

WebKit/mac:

Reviewed by Adam Roben.

<rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
and inactive text selection after loading a page
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance

The problem was other frames were changing the FocusController's active
status to false after the first responder frame set it to true. The last
frame to call _updateActiveState would win.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive() if the first responder is the current WebHTMLView or the WebFrameView. (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
10:47 AM Changeset in webkit [29628] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Database origin tracking is broken.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::populateOrigins): Move reading from statement back into the loop (broken in r29386).
10:44 AM Changeset in webkit [29627] by Adam Roben
  • 15 edits in trunk

Fix <rdar://5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing

WebKit/mac:

Rename _updateActiveState to _updateFocusedAndActiveState

Also renamed any related methods/members similarly.

Reviewed by Adele.

  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]): (-[WebHTMLView close]): (_updateFocusedAndActiveStateTimerCallback): (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]): (-[WebHTMLView windowDidBecomeKey:]): (-[WebHTMLView windowDidResignKey:]): (-[WebHTMLView becomeFirstResponder]): (-[WebHTMLView resignFirstResponder]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:

WebKit/win:

Fix <rdar://5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing

Restored the previous behavior of IWebViewPrivate::updateActiveState,
which DRT depends on, and renamed it to
IWebViewPrivate::updateFocusedAndActiveState to be clearer about its
side-effects.

Reviewed by Adele.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebViewWndProc): Removed some FIXMEs that we no longer want to fix because the current design is better. (WebView::updateActiveState): This is now just a method of WebView, not any of its public interfaces. (WebView::updateFocusedAndActiveState): Performs the tasks that the old IWebViewPrivate::updateActiveState performed.
  • WebView.h:

WebKitTools:

Updated for method renames

Reviewed by Adele.

  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMainFrameIsFirstResponder): (LayoutTestController::setWindowIsKey):
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webViewFocus:]):
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didCommitLoadForFrame):

LayoutTests:

Reviewed by Adele.

  • platform/win/Skipped: Removed a fixed test, and a test that passes for me locally.
6:21 AM Changeset in webkit [29626] by ap@webkit.org
  • 5 edits in trunk

Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
between DRT and TestNetscapePlugin.

3:57 AM Changeset in webkit [29625] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Coding style fixes and added a comment about the order of includes in the PCH.

3:30 AM Changeset in webkit [29624] by Simon Hausmann
  • 3 edits
    1 add in trunk

Marius Storm-Olsen <​marius@trolltech.com>

Add use of precompiled header, when building inside Qt.

Compiling WebKit was taking forever; 17 minutes on my machine for _one_ build! Adding the PCH at least brings it down to 12 minutes for one build, for me.

2:55 AM Changeset in webkit [29623] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix fast/forms/button-state-restore.html

Similar to the fix for fast/forms/form-post-urlencoded.html transform POST
requests to data urls into GET.

2:55 AM Changeset in webkit [29622] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix LayoutTests/fast/cookies/local-file-can-set-cookies.html

In WebCore::cookies() don't return the full raw form but only the name=value
part. This fixes the getter part of the above test. The above test also
requires a parsing fix in Qt 4.4's QNetworkCookie to fully pass.

2:55 AM Changeset in webkit [29621] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

Fix fast/dom/Window/window-resize.html

In DRT connect the page's geometryChangeRequest signal to a slot that
sets the geometry of the view widget.

2:54 AM Changeset in webkit [29620] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Fix return type conversions from Qt slots to JS values.

This also fixes fast/dom/open-and-close-by-DOM.html, which called
layoutTestController.windowCount().

When constructing the QVariant that holds the return type we cannot
use the QVarian(Type) constuctor as that will create a null variant.
We have to use the QVariant(Type, void *) constructor instead, just
like in QMetaObject::read() for example.

2:54 AM Changeset in webkit [29619] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix svg/custom/path-getTotalLength.svg

Path::apply creates a PathElement and its points array on the stack,
to fill it in from the QPainterPath data and then use the platform
independent path applier functions to calculate properties such as
the length. For converting a QPainterPath::CurveToElement we need
three points in the path element. However we allocated only two
on the stack and as a result we got memory corruption and the
failing test.

2:54 AM Changeset in webkit [29618] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix LayoutTests/fast/dom/document-attribute-js-null.html

Don't crash when trying to get/set cookies without a frameloader.

2:54 AM Changeset in webkit [29617] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix fast/dom/xmlhttprequest-get.xhtml

For local file requests remove the content length and the last-modified
headers in the response.

2:53 AM Changeset in webkit [29616] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix fast/forms/form-post-urlencoded.html.

Post requests on files don't really make sense, but for
fast/forms/form-post-urlencoded.html we still need to retrieve the file,
which means we map it to a Get instead.

2:37 AM Changeset in webkit [29615] by Simon Hausmann
  • 2 edits in trunk/WebCore

Simon Hausmann <Simon Hausmann>

Make QNetworkReplyHandler::abort() more robust against multiple invocations.

During DRT runs I see cancel() being called on the same handle multiple times. Guard
against this a bit better by setting m_reply to 0 after we called abort() on it.

2:37 AM Changeset in webkit [29614] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Ask the WebCore::IconDatabase only if our URL is not empty. Otherwise we will see a crash in a HashSet.
  • It is crashing there because the StringImpl of an empty String is 0.
  • We avoid this crash by checking for isEmpty() in WebKit as there is no use to ask the iconDatabase for an empty string. We will fallback to the defaultIcon.
2:37 AM Changeset in webkit [29613] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • httpBody() can return 0 and other ports (cf/mac) check for this condition
  • Looking at the cf/mac implementation we might need to call setHTTPBody somewhere as well.
1:46 AM Changeset in webkit [29612] by Simon Hausmann
  • 2 edits in trunk/WebCore

Prasanth Ullattil <​prasanth.ullattil@trolltech.com>

Fix compilation in Win64(3): Due to the size of size_t cast the return value explicitly to double() to make sure the right Value() constructor is called.

1:45 AM Changeset in webkit [29611] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Prasanth Ullattil <​prasanth.ullattil@trolltech.com>

Fix compilation on Win64(2): Implemented currentThreadStackBase on X86-64 on Windows

1:45 AM Changeset in webkit [29610] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Prasanth Ullattil <​prasanth.ullattil@trolltech.com>

Fix compilation on Win64(1): Define WTF_PLATFORM_X86_64 correctly on Win64.

1:37 AM Changeset in webkit [29609] by Simon Hausmann
  • 3 edits in trunk/WebCore
  • Remove our windowClipRect reimplementation and instead have our own Widget::invalidate implementation that is invalidating IntRect(0, 0, width(), height()) without trying to clip it (in contrast to Widget::invalidateRect)
1:36 AM Changeset in webkit [29608] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Change the coordinate transformation in the PlatformMouseEvent handlers
  • We want to convert from coordinates of the containing window to our local position on the scrollbar.
1:36 AM Changeset in webkit [29607] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Make the qDebug more usable. Do not have an additional newline and print the untranslated coordinates as well.
1:36 AM Changeset in webkit [29606] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Dead code, remove it
1:36 AM Changeset in webkit [29605] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Coding-Style fixes.
1:35 AM Changeset in webkit [29604] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Coding-Style fix

Jan 17, 2008:

8:05 PM Changeset in webkit [29603] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed: lots of WebCore leaks reported when quitting Safari


If we're quitting with a GC still scheduled, do the GC before quitting.
That way, WebCore's leak counters won't count objects that were
scheduled for GC.

  • bindings/js/GCController.cpp: (WebCore::GCController::~GCController): (WebCore::GCController::garbageCollectNow):
  • bindings/js/GCController.h:
7:29 PM Changeset in webkit [29602] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-17 Alp Toker <​alp@atoker.com>

Reviewed by Oliver Hunt.

gdk_screen_get_font_options() returns NULL if no default options are
set so we always have to NULL check to avoid crashes later on since
Cairo doesn't accept NULL font options.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
5:58 PM Changeset in webkit [29601] by Antti Koivisto
  • 6 edits in trunk

Reviewed by Adele.

Windows fix for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports


  • Disable unsupported QuickTime tracks types.
  • Disallow streaming protocols (for now).
5:14 PM Changeset in webkit [29600] by sfalken@apple.com
  • 4 edits in trunk

WebKit/win:

Build fix.

  • WebKit.vcproj/WebKit.make:

WebKitTools:

Build fix.

  • Drosera/DroseraWin.make:
5:14 PM Changeset in webkit [29599] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

2008-01-17 Stephanie <Stephanie Lewis>

RS=Adam


Move some new failing tests to the skipped list

  • platform/win/Skipped:
4:34 PM Changeset in webkit [29598] by sfalken@apple.com
  • 2 edits in trunk/WebKitSite

Added Vista crash logging information.


Reviewed by Adam.

  • quality/crashlogs.html:
4:21 PM Changeset in webkit [29597] by oliver@apple.com
  • 5 edits in trunk/WebCore

Support smart copy and paste during drag and drop

Reviewed by Alice

In order for the drag and drop tests in Windows DRT to pass
we need to support smart cut and paste operations during
drag and drop on windows.

There is no layout test as drag and drop is still unsupported
on windows. Once supported smart drag/drop is tested by existing
tests

4:10 PM Changeset in webkit [29596] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin


  • fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
  • WebView/WebFrameView.mm: (-[WebFrameView initWithCoder:]): override to bump the global WebFrameView count
3:58 PM Changeset in webkit [29595] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Fixed a bug number.
1:33 PM Changeset in webkit [29594] by oliver@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/5692940> Crash when attempting to get text properties in SVG with no renderer

Reviewed by Anders

We use the element renderer to calculate the text element bounds,
however there was no check against the possibility of the text dimension
properties being requested on a element with no renderer (eg. unattached,
display: none).

1:05 PM Changeset in webkit [29593] by andersca@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5636742>
CrashTracer: [USER] 1302 crashes in Safari at com.apple.WebCore: WTF::Vector<char, 0ul>::reserveCapacity + 78


When loading full-frame plug-ins, disable buffering data for the main resource loader. Otherwise, this can cause us
to crash when loading large files such as movies in the browser. We already do this for embedded plug-ins.


  • WebCore.base.exp:
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::mainResourceLoader): New accessor method.


  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Disable buffering for the main resource loader.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::setShouldBufferData):
  • loader/ResourceLoader.h: Have this free the buffer when disabling buffering.
12:45 PM Changeset in webkit [29592] by Antti Koivisto
  • 2 edits in trunk/JavaScriptCore

Fix Windows build.

  • kjs/regexp_object.cpp: (KJS::regExpProtoFuncToString):
12:39 PM Changeset in webkit [29591] by Adam Roben
  • 3 edits in trunk/WebCore

More Qt/GTK+ build fixing.

  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
12:06 PM Changeset in webkit [29590] by ap@webkit.org
  • 5 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16902
<rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html fails when run after
fast/dom/Window/window-property-shadowing.html

Test: fast/dom/Window/window-property-shadowing_.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Clear the frame name, too.
11:50 AM Changeset in webkit [29589] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16908
run-webkit-tests complains about missing FindSafari.exe

  • Scripts/webkitdirs.pm: Append _debug as appropriate.
11:27 AM Changeset in webkit [29588] by weinig@apple.com
  • 17 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16901
Convert remaining JS function objects to use the new PrototypeFunction class

  • Moves Boolean, Function, RegExp, Number, Object and Global functions to their own static function implementations so that they can be used with the PrototypeFunction class. SunSpider says this is 1.003x as fast.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset):
  • kjs/array_object.h:
  • kjs/bool_object.cpp: (KJS::BooleanInstance::BooleanInstance): (KJS::BooleanPrototype::BooleanPrototype): (KJS::booleanProtoFuncToString): (KJS::booleanProtoFuncValueOf): (KJS::BooleanObjectImp::BooleanObjectImp): (KJS::BooleanObjectImp::implementsConstruct): (KJS::BooleanObjectImp::construct): (KJS::BooleanObjectImp::callAsFunction):
  • kjs/bool_object.h: (KJS::BooleanInstance::classInfo):
  • kjs/error_object.cpp: (KJS::ErrorPrototype::ErrorPrototype): (KJS::errorProtoFuncToString):
  • kjs/error_object.h:
  • kjs/function.cpp: (KJS::globalFuncEval): (KJS::globalFuncParseInt): (KJS::globalFuncParseFloat): (KJS::globalFuncIsNaN): (KJS::globalFuncIsFinite): (KJS::globalFuncDecodeURI): (KJS::globalFuncDecodeURIComponent): (KJS::globalFuncEncodeURI): (KJS::globalFuncEncodeURIComponent): (KJS::globalFuncEscape): (KJS::globalFuncUnEscape): (KJS::globalFuncKJSPrint): (KJS::PrototypeFunction::PrototypeFunction):
  • kjs/function.h:
  • kjs/function_object.cpp: (KJS::FunctionPrototype::FunctionPrototype): (KJS::functionProtoFuncToString): (KJS::functionProtoFuncApply): (KJS::functionProtoFuncCall):
  • kjs/function_object.h:
  • kjs/number_object.cpp: (KJS::NumberPrototype::NumberPrototype): (KJS::numberProtoFuncToString): (KJS::numberProtoFuncToLocaleString): (KJS::numberProtoFuncValueOf): (KJS::numberProtoFuncToFixed): (KJS::numberProtoFuncToExponential): (KJS::numberProtoFuncToPrecision):
  • kjs/number_object.h: (KJS::NumberInstance::classInfo): (KJS::NumberObjectImp::classInfo): (KJS::NumberObjectImp::):
  • kjs/object_object.cpp: (KJS::ObjectPrototype::ObjectPrototype): (KJS::objectProtoFuncValueOf): (KJS::objectProtoFuncHasOwnProperty): (KJS::objectProtoFuncIsPrototypeOf): (KJS::objectProtoFuncDefineGetter): (KJS::objectProtoFuncDefineSetter): (KJS::objectProtoFuncLookupGetter): (KJS::objectProtoFuncLookupSetter): (KJS::objectProtoFuncPropertyIsEnumerable): (KJS::objectProtoFuncToLocaleString): (KJS::objectProtoFuncToString):
  • kjs/object_object.h:
  • kjs/regexp_object.cpp: (KJS::RegExpPrototype::RegExpPrototype): (KJS::regExpProtoFuncTest): (KJS::regExpProtoFuncExec): (KJS::regExpProtoFuncCompile): (KJS::regExpProtoFuncToString):
  • kjs/regexp_object.h:
11:23 AM Changeset in webkit [29587] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Name the test for a recent bug fix.

11:06 AM Changeset in webkit [29586] by Adam Roben
  • 3 edits in trunk/WebCore

Qt/GTK+ build fix.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive):
10:55 AM Changeset in webkit [29585] by mitz@apple.com
  • 22 edits
    2 adds in trunk/LayoutTests

Reviewed by Dave Hyatt.

  • make more test pass on Windows by using @font-face to force font fallback to match Mac OS X.
  • editing/deleting/5144139-2.html:
  • fast/encoding/invalid-UTF-8.html:
  • fast/events/updateLayoutForHitTest.html:
  • fast/forms/select-visual-hebrew.html:
  • fast/forms/select-writing-direction-natural.html:
  • fast/forms/visual-hebrew-text-field.html:
  • fast/text/in-rendered-text-rtl.html:
  • fast/text/international/bidi-L2-run-reordering.html:
  • fast/text/international/bidi-LDB-2-CSS.html:
  • fast/text/international/bidi-LDB-2-HTML.html:
  • fast/text/international/bidi-LDB-2-formatting-characters.html:
  • fast/text/international/bidi-european-terminators.html:
  • fast/text/international/bidi-ignored-for-first-child-inline.html:
  • fast/text/international/bidi-innertext.html:
  • fast/text/international/bidi-listbox-atsui.html:
  • fast/text/international/bidi-listbox.html:
  • fast/text/international/bidi-menulist.html:
  • fast/text/international/bidi-override.html:
  • fast/text/international/resources: Added.
  • fast/text/international/resources/Mac-compatible-font-fallback.css: Added.
  • fast/text/international/rtl-caret.html:
  • platform/mac/editing/deleting/5144139-2-expected.txt:
  • platform/win/Skipped:
9:46 AM Changeset in webkit [29584] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added another failure.
9:46 AM Changeset in webkit [29583] by Adam Roben
  • 4 edits in trunk/WebKit/win

Trigger activation changes at the right time by listening for WM_NCACTIVATE

This is the final part of <rdar://5006915> Inactive look for Aqua
controls

WebView now listens to messages sent to its top-level parent window.
When the top-level parent receives a WM_NCACTIVATE message, WebView
recalculates whether it is contained within the current active window.

Reviewed by Darin.

  • Interfaces/IWebViewPrivate.idl: (IWebViewPrivate::windowAncestryDidChange): Added. WebKit clients should call this when they change the parent window chain of a WebView.
  • WebView.cpp: (WebView::WebView): Initialize new member. (findTopLevelParent): Added. (WebViewWndProc):
    • Separated activation handling from focus handling, now that activation handling is taken care of by updateActiveState exclusively.
    • Compare top-level parents in our WM_KILLFOCUS handler so that we really know if focus is staying inside our top-level window.
    • Update our active state on WM_WINDOWPOSCHANGED.
    • Added a WM_TIMER handler.

(WebView::initWithFrame): Call windowAncestryDidChange after setting
up our HWND as a child of the host window.
(WebView::windowReceivedMessage): Added. Update our active state when
our top-level parent receives a WM_NCACTIVATE message.
(WebView::updateActiveStateSoon): Added.
(WebView::setHostWindow): Call windowAncestryDidChange after changing
the host window.
(WebView::updateActiveState): We are active if our top-level parent is
the same as the top-level parent of the active window.
(WebView::windowAncestryDidChange): Added. Recalculates our top-level
parent and registers as a listener for the new top-level parent's
messages.

  • WebView.h: Made WebView and WindowMessageListener so that it can utilize WindowMessageBroadcaster to listen to its top-level parent's messages.
9:45 AM Changeset in webkit [29582] by Adam Roben
  • 16 edits in trunk

Update scroll bars/form controls when FocusController::isActive changes

WebCore:

Update scroll bars/form controls when FocusController::isActive changes

Part of <rdar://5006915> Inactive look for Aqua controls

Reviewed by Darin.

All tests pass.

  • page/FocusController.cpp: (WebCore::FocusController::setActive): Update control tints when the active state changes.
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): On Windows, we have to ask ScrollView to paint so that the outermost scroll bars will paint. On Mac, the outermost scroll bars are taken care of by NSScroller.
  • platform/PopupMenu.h: Updated for ScrollBarClient changes.
  • platform/ScrollBar.h: Added a new ScrollBarClient method.
  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint): Invalidate when updating control tints so that we can paint with the new tint later. (WebCore::PlatformScrollbar::paintButton): Pass the active state down to SafariTheme. (WebCore::PlatformScrollbar::paintTrack): Ditto. (WebCore::PlatformScrollbar::paintThumb): Ditto.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::isActive): Added. (WebCore::ScrollView::paint): Pass paint calls on down if we're updating control tints so the scroll bars can invalidate.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::isActive): Added.
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isActive): Added.
  • rendering/RenderListBox.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isActive): Added.
  • rendering/RenderTheme.h:
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::determineState): Pass the active state down to SafariTheme.

WebKit/win:

Updated for ScrollBarClient changes

Reviewed by Darin.

  • WebScrollBar.h: (WebScrollBar::isActive): Added.
9:44 AM Changeset in webkit [29581] by Adam Roben
  • 23 edits in trunk

Move focused/active state from Frame to SelectionController/FocusController

WebCore:

Move focused/active state from Frame to SelectionController/FocusController

This is the first part of <rdar://5006915> Inactive look for Aqua
controls.

The following methods were moved/renamed:

  • Frame::setIsActive -> FocusController::setActive
  • Frame::isActive -> SelectionController::isActiveAndFocused
  • Frame::setWindowHasFocus -> SelectionController::setFocused

Active state is now correctly a Page-level concept.

The Mac parts of this patch were written by Darin.

Reviewed by Darin.

All tests pass.

  • WebCore.base.exp: Updated for method renames.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Initialize new member. (WebCore::SelectionController::focusedOrActiveStateChanged): New private method. Most of this code came from Frame::setIsActive. (WebCore::SelectionController::pageActivationChanged): Added. (WebCore::SelectionController::setFocused): Added. Replaces Frame::setWindowHasFocus. (WebCore::SelectionController::isFocusedAndActive): Added. Replaces Frame::isActive.
  • editing/SelectionController.h:
  • page/FocusController.cpp: (WebCore::FocusController::FocusController): Initialize new member. (WebCore::FocusController::setFocusedFrame): Changed to just call SelectionController::setFocused, since active state has doesn't change when the focused frame changes. (WebCore::FocusController::setActive): Added. Replaces Frame::setIsActive.
  • page/FocusController.h: (WebCore::FocusController::isActive): Added.
  • page/Frame.cpp: (WebCore::Frame::setDocument): Updated for method renames. (WebCore::Frame::setFocusedNodeIfNeeded): Ditto. (WebCore::Frame::updateSecureKeyboardEntryIfActive): Ditto. (WebCore::FramePrivate::FramePrivate): Removed initialization of removed members.
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/mac/WebCoreFrameBridge.h: Removed -selectionColor.
  • page/mac/WebCoreFrameBridge.mm: Ditto.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Updated for method renames. (WebCore::RenderListBox::paintItemBackground): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): Ditto. (WebCore::RenderObject::selectionForegroundColor): Ditto.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::capsLockStateMayHaveChanged): Ditto.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Ditto.

WebKit/mac:

Updated for renames/removal of WebCore methods.

Reviewed by Darin.

  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerSelectionColor]): Changed to ask isFocusedAndActive directly, instead of going through the frame bridge.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Updated for method renames.

WebKit/win:

Updated for changes to WebCore methods

Focus and active state are now handled (somewhat) separately. Future
patches will further separate these concepts.

Reviewed by Darin.

  • WebView.cpp: (WebViewWndProc): Updated for method renames. (WebView::updateActiveState): Only change the active state here. Focus is handled inside WM_SETFOCUS and WM_KILLFOCUS message handlers.

WebKit/wx:

Updated for WebCore method renames.

Reviewed by Darin.

  • WebView.cpp: (wxWebView::OnSetFocus): (wxWebView::OnKillFocus): (wxWebView::OnActivate):
8:52 AM Mobile edited by dacarson@gmail.com
(diff)
8:37 AM Mobile edited by dacarson@gmail.com
(diff)
8:20 AM Changeset in webkit [29580] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Re-add DEBUG_WEBKIT_HAS_SUFFIX.


Rubber-stamped by Jon Honeycutt.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
8:06 AM Mobile edited by dacarson@gmail.com
(diff)
8:03 AM Mobile edited by dacarson@gmail.com
(diff)
7:54 AM Changeset in webkit [29579] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Make the nice 'safari' feature work on our port. When viewing a single image, clicking on the image will zoom it.
  • It seems like our platform can only determine the size of the image once it is completely loaded. Call m_doc->imageChanged on the last chunk of data as well.
7:53 AM Changeset in webkit [29578] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Minor documentation fixes

7:51 AM Changeset in webkit [29577] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix form elements not focusing correctly after the qt widget lost its focus.

When receiving a focus out event notify the focus controller. Otherwise its
m_focusedFrame variable remains unchanged and setFocusedFrame on a focusIn
event shortcuts and doesn't call setActive(true).

7:44 AM Changeset in webkit [29576] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

Lots of updates to the documentation.

6:06 AM Changeset in webkit [29575] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

Added a urlChanged signals to QWebFrame and QWebView.

6:05 AM Changeset in webkit [29574] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fixed docs and sanity checks in QWebSettings::setIconDatabaseEnabled

6:04 AM Changeset in webkit [29573] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Added QWebView::createWindow() which is forwarded from QWebPage::createWindow() for convenience.

6:03 AM Changeset in webkit [29572] by Simon Hausmann
  • 2 edits in trunk/WebCore

Set the library version of QtWebKit to the Qt version.

6:03 AM Changeset in webkit [29571] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

add a 0 pointer check.

Fixes a crash in the demo web browser.

5:03 AM Changeset in webkit [29570] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix QWebFrame::title().

For the titleChanged() signal we use the documentloader's title. For the property we have to use the same
instead of Document::title() as the latter is not trimmed and not suited for a window caption.

5:01 AM Changeset in webkit [29569] by Simon Hausmann
  • 2 edits in trunk/WebCore

Re-enable gzip compression as accepted encoding, now that the bug is fixed in Qt 4.4's network module.

4:07 AM Changeset in webkit [29568] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-01-17 Simon Hausmann <Simon Hausmann>

Another Windows build fix, setCookies accidentially had a const
Document pointer.

3:48 AM Changeset in webkit [29567] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-01-17 Simon Hausmann <Simon Hausmann>

MSVC Windows build fix. Forward declaring Document in CookieJar.h
seems not enough for MSVC.

3:37 AM Changeset in webkit [29566] by Simon Hausmann
  • 12 edits in trunk

​http://bugs.webkit.org/show_bug.cgi?id=16589

Add a document parameter to WebCore::cookies, setCookies and cookiesEnabled.

2:45 AM Changeset in webkit [29565] by Simon Hausmann
  • 2 edits in trunk/WebCore

Windows build fix.

2:04 AM Changeset in webkit [29564] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix linking on MinGW and at least one MSVC platform by having gmtimeQt in the correct namespace.

2:01 AM Changeset in webkit [29563] by Simon Hausmann
  • 2 edits in trunk/WebCore

Don't link QtWebKit against libQtXml when building against Qt 4.4.

This is not necessary anymore since QXmlStream has been moved into QtCore.

1:49 AM Changeset in webkit [29562] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Follow QWidget::keyPressEvent advice and call parents.

Without this, Back does not work in Qtopia, for example.

1:49 AM Changeset in webkit [29561] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix compilation on arm

1:48 AM Changeset in webkit [29560] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix compilation against Qt 4.3 after the recent KURL <> QUrl conversion fixes.

1:48 AM Changeset in webkit [29559] by Simon Hausmann
  • 9 edits in trunk

Fix compilation against Qt 4.4 without files that are specific for the Qt 4.3 build.

Signed-off-by: Holger

1:46 AM Changeset in webkit [29558] by Simon Hausmann
  • 3 edits in trunk/WebCore

Fixes compilation with MinGW.

Neither localtime_r nor localtime_s are available on MingW, so instead of
calling back to the thread-unsafe localtime use QDateTime instead.

Signed-off-by: Simon Hausmann <Simon Hausmann>

1:44 AM Changeset in webkit [29557] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Fixes compilation with QT_NO_DRAGANDDROP

1:16 AM Changeset in webkit [29556] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix compilation

1:04 AM Changeset in webkit [29555] by mitz@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix determinePitch for segmented fonts

Covered by and existing test.

  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::determinePitch): If the primary font is segmented, treat as fixed pitch only if it has only one segment and that segment is fixed-pitch.

LayoutTests:

Reviewed by Dave Hyatt.

  • update results for fixing determinePitch for segmented fonts
  • platform/mac/fast/css/font-face-implicit-local-font-expected.txt:
12:27 AM Changeset in webkit [29554] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Add preprocessor define accidently dropped in my unification,
and required by some builds. Fixes an issue that caused both
debug and release DLLs to be loaded.


Rubber-stamped by Jon Honeycutt.

  • win/tools/vsprops/debug_internal.vsprops:

Jan 16, 2008:

10:20 PM Changeset in webkit [29553] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16611

Make sure vertical-align length values are offset from their parents rather than being absolute to the
line.

Reviewed by olliej

Added fast/css/vertical-align-lengths.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getVerticalPosition):

LayoutTests:

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16611

Reviewed by olliej

  • ChangeLog:
  • fast/css/vertical-align-lengths.html: Added.
  • platform/mac/fast/css/vertical-align-lengths-expected.checksum: Added.
  • platform/mac/fast/css/vertical-align-lengths-expected.png: Added.
  • platform/mac/fast/css/vertical-align-lengths-expected.txt: Added.
10:13 PM Changeset in webkit [29552] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix for @font-face rules with unicode-range: always use a local font where not explicitly overlaid.

Test: fast/css/font-face-implicit-local-font.html

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Changed to insert an implicit @font-face rule with the local font the matches the family and description before any explicit @font-face rules that overlay specific ranges of the same font.
  • css/CSSSegmentedFontFace.h: (WebCore::CSSSegmentedFontFace::numRanges): Addded.

LayoutTests:

Reviewed by Dave Hyatt.

  • add test for @font-face rules with unicode-range: always use a local font where not explicitly overlaid.
  • fast/css/font-face-implicit-local-font.html: Added.
  • platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.checksum: Added.
  • platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.png: Added.
  • platform/mac/fast/css/font-face-implicit-local-font-expected.txt: Added.
6:53 PM Changeset in webkit [29551] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/5097419> Cursor flickers when over window resizer


Reviewed by Sam.

  • WebView.cpp: (WebViewWndProc): Don't set the resize cursor when over the non-border resize area.
6:27 PM Changeset in webkit [29550] by alp@webkit.org
  • 7 edits in trunk

2008-01-16 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16218
[GTK] API: Should this entry point be called go_back rather than go_backward?

Obsolete 'backward' terminology in API in favour of 'back'. Introduce
step-based back/forward functions.

Document more functions.

5:11 PM Changeset in webkit [29549] by Antti Koivisto
  • 2 edits in trunk/WebCore

Fix Tiger build.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
4:45 PM Changeset in webkit [29548] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Add tests for unsupported types to Windows skip list for now.

  • platform/win/Skipped:
4:34 PM Changeset in webkit [29547] by Antti Koivisto
  • 4 edits
    8 adds in trunk

WebCore:

Reviewed by Adele.


OS X fix for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports


  • Disable unsupported QuickTime tracks types.
  • Disallow streaming protocols (for now).
  • Set QTMovie QTMoviePreventExternalURLLinksAttribute and QTSecurityPolicyNoCrossSiteAttribute to limit QuickTime's access to external resources.


Windows patch coming up.

Tests: media/broken-video.html

media/unsupported-rtsp.html
media/unsupported-tracks.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):

LayoutTests:

Reviewed by Adele.


Tests for <rdar://problem/5605682>
Disallow streaming protocols for media elements
and <rdar://problem/5668711>
Limit the container and codec types that the <video> tag supports


  • test that rtsp: protocol is disabled (for now).
  • test that QuickTime files with unsupported track types are handled correctly
  • test that broken video file produces an error
  • media/broken-video-expected.txt: Added.
  • media/broken-video.html: Added.
  • media/content/garbage.mp4: Added.
  • media/content/unsupported_track.mov: Added.
  • media/unsupported-rtsp-expected.txt: Added.
  • media/unsupported-rtsp.html: Added.
  • media/unsupported-tracks-expected.txt: Added.
  • media/unsupported-tracks.html: Added.
4:15 PM Changeset in webkit [29546] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-01-16 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16897
Add shared plugins directory to INCLUDE path

Add the plugins directory to INCLUDEPATH

  • GNUmakefile.am:
  • WebCore.pro:
3:59 PM Changeset in webkit [29545] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Use recommended security-related compiler settings.


Reviewed by Adam.

  • win/tools/vsprops/common.vsprops:
3:54 PM Changeset in webkit [29544] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig.


Added a debug counter for SQL transactions. This helped me debug an SQL
leak.

  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::): (WebCore::JSCustomSQLTransactionCallbackCounter::~JSCustomSQLTransactionCallbackCounter): (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
  • bindings/js/JSCustomSQLTransactionCallback.h:
  • bindings/js/kjs_window.cpp: Removed a silly comment.
3:36 PM Changeset in webkit [29543] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Adam and Dan


  • cleaned up some existing logging
  • WebView/WebHTMLView.mm: (-[WebHTMLView setNeedsDisplay:]): add method name to log, use "YES" and "NO" instead of (int)flag (-[WebHTMLView setNeedsLayout:]): ditto (-[WebHTMLView setNeedsToApplyStyles:]): ditto
3:16 PM Changeset in webkit [29542] by mjs@apple.com
  • 4 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej & Darin.

Fixes Bug 16868: Gmail crash

and Bug 16871: Crash when loading apple.com/startpage

<​http://bugs.webkit.org/show_bug.cgi?id=16868>
<rdar://problem/5686108>

<​http://bugs.webkit.org/show_bug.cgi?id=16871>
<rdar://problem/5686670>

Adds ActivationImp tear-off for cross-window eval() and fixes an
existing garbage collection issue exposed by the ActivationImp tear-off
patch (r29425) that can occur when an ExecState's m_callingExec is
different than its m_savedExec.

  • kjs/ExecState.cpp: (KJS::ExecState::mark):
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):

LayoutTests:

Reviewed by Maciej.

Added a test that checks whether ActivationImp tear-off occurs before
a cross-window eval(). Relevant to

Bug 16868: Gmail crash

<​http://bugs.webkit.org/show_bug.cgi?id=16868>
<rdar://problem/5686108>

  • fast/js/window-eval-tearoff-expected.txt: Added.
  • fast/js/window-eval-tearoff.html: Added.
2:31 PM Changeset in webkit [29541] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Oliver.

Clean up MathObjectImp, it needed a little scrubbing.

  • kjs/math_object.cpp: (KJS::MathObjectImp::MathObjectImp): (KJS::MathObjectImp::getOwnPropertySlot): (KJS::MathObjectImp::getValueProperty): (KJS::mathProtoFuncACos): (KJS::mathProtoFuncASin): (KJS::mathProtoFuncATan): (KJS::mathProtoFuncATan2): (KJS::mathProtoFuncCos): (KJS::mathProtoFuncExp): (KJS::mathProtoFuncLog): (KJS::mathProtoFuncSin): (KJS::mathProtoFuncSqrt): (KJS::mathProtoFuncTan):
  • kjs/math_object.h: (KJS::MathObjectImp::classInfo): (KJS::MathObjectImp::):
2:13 PM Changeset in webkit [29540] by hyatt@apple.com
  • 5 edits in trunk/LayoutTests

Update layout tests after fix for <rdar://problem/5681647>.

  • platform/mac/tables/mozilla/bugs/bug101674-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2973-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt:
1:56 PM Changeset in webkit [29539] by hyatt@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14846, cell padding can't be changed dynamically.

Reviewed by Eric Seidel

Added fast/table/dynamic-cellpadding.html

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::setCellPadding):
  • rendering/RenderTable.h:

LayoutTests:

Reviewed by Eric Seidel

​http://bugs.webkit.org/show_bug.cgi?id=14846

  • fast/table/dynamic-cellpadding.html: Added.
  • platform/mac/fast/table/dynamic-cellpadding-expected.checksum: Added.
  • platform/mac/fast/table/dynamic-cellpadding-expected.png: Added.
  • platform/mac/fast/table/dynamic-cellpadding-expected.txt: Added.
1:53 PM Changeset in webkit [29538] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen.

Rename Lexer variable bol to atLineStart.

  • kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::setCode): (KJS::Lexer::nextLine): (KJS::Lexer::lex):
  • kjs/lexer.h:
1:50 PM Changeset in webkit [29537] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen and Anders Carlsson.

Remove uses of KJS_PURE_ECMA as we don't ever build with it defined,
and we have many features that are not included in the ECMA spec.

  • kjs/lexer.cpp: (KJS::Lexer::Lexer): (KJS::Lexer::setCode): (KJS::Lexer::nextLine): (KJS::Lexer::lex):
  • kjs/lexer.h:
  • kjs/string_object.cpp:
  • kjs/string_object.h:
1:27 PM Changeset in webkit [29536] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5681647> Item pages on ​http://www.stendmarsofa.com/ hang Safari

This regression was caused by an attempt to implement a WinIE quirk in RenderBlock::calcInlinePrefWidths.
The original patch introduced pathological O(n2) behavior into this function even when the quirk didn't need
to apply. In addition the quirk was only partially implemented (the full quirk did not care what was adjacent
to images and also needed bidi.cpp patched, since the quirk applies both when computing pref widths and when
laying out).

This new patch rewrites the quirk to be complete. The original test case attached to the bug that tested a variety
of image/text combinations now fully matches WinIE.

Reviewed by Beth

Added fast/table/unbreakable-images-quirk.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
1:24 PM Changeset in webkit [29535] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/bidi.cpp

I don't know what happened here. It did not commit with my checkin.

1:22 PM Changeset in webkit [29534] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build fix after r29488

  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Build into a subdirectory of $WebKitOutputDir\bin to match where DRT expects to find the plugin.
1:20 PM Changeset in webkit [29533] by hyatt@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Beth.

<rdar://problem/5681647> Item pages on ​http://www.stendmarsofa.com/ hang Safari

  • fast/table/unbreakable-images-quirk.html: Added.
  • platform/mac/fast/table/unbreakable-images-quirk-expected.checksum: Added.
  • platform/mac/fast/table/unbreakable-images-quirk-expected.png: Added.
  • platform/mac/fast/table/unbreakable-images-quirk-expected.txt: Added.
1:13 PM Changeset in webkit [29532] by jhoneycutt@apple.com
  • 5 edits in trunk/WebCore

2008-01-16 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Jon Honeycutt

Move isPluginBlacklisted to PluginPackageWin.cpp, to avoid
a circular dependency on PluginDatabaseWin
Remove the getFileVersion method, and just check the versions directly
in isPluginBlacklisted, as it was the only caller

​http://bugs.webkit.org/show_bug.cgi?id=16884

  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/win/PluginDatabaseWin.h:
  • plugins/win/PluginPackageWin.cpp:
  • plugins/win/PluginPackageWin.h:
9:14 AM Changeset in webkit [29531] by mitz@apple.com
  • 1 edit
    1 copy
    4 adds in trunk/LayoutTests

Reviewed by Adam Roben.

  • copied Windows expected results for svg/hixie/viewbox/preserveAspectRatio/001.xml from Tiger
  • platform/win/svg: Added.
  • platform/win/svg/hixie: Added.
  • platform/win/svg/hixie/viewbox: Added.
  • platform/win/svg/hixie/viewbox/preserveAspectRatio: Added.
  • platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.
4:07 AM Changeset in webkit [29530] by alp@webkit.org
  • 1 edit in trunk

​http://bugs.webkit.org/show_bug.cgi?id=16732
Update svn:ignore properties for autotools build

Reviewed by Alp Toker.

Ignore files placed in the source tree by the autotools build (these
files are generated even during an out-of-tree build).

2:34 AM Changeset in webkit [29529] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Removed a whole bunch of notImplemented() warnings.

I don't want to hide the real warnings in lots of things that
I am by now pretty certain we won't need.

Signed-off-by: Simon Hausmann <​simon.hausmann@trolltech.com>

2:18 AM Changeset in webkit [29528] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Set the cursor on the containingWindow() instead of the nativeWidget()
  • This should be safe even with plugins as the cursor is set on the mouse events.

Signed-Off-By: Lars

2:18 AM Changeset in webkit [29527] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix crash when bringing up the context menu on maps.google.com.

If the website provides its own context menu then we don't have a ContextMenu pointer.

2:18 AM Changeset in webkit [29526] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Don't crash when receiving all sorts of events on a default constructed QWebView without a page.

2:18 AM Changeset in webkit [29525] by Simon Hausmann
  • 2 edits in trunk/WebCore

Improve the sqlite3 dependency when building WebKit inside Qt.

Build sqlite3 into QtWebKit if a system sqlite3 development package
can't be found.

Signed-off-by: Lars

2:17 AM Changeset in webkit [29524] by Simon Hausmann
  • 2 edits in trunk/WebCore

Implement GraphicsContext::clipOut and fix transparency layers.

Transparency layers where broken in two ways: It always used the
complete device rect as the size of the layer pixmap and the pixmaps
where not correctly initialized to transparent.

This fixes the worst drawing errors in the Inspector and makes drawing it
10 times faster.

2:17 AM Changeset in webkit [29523] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Made the url property read-write.

2:17 AM Changeset in webkit [29522] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Don't crash when showing a default initialized QWebView that has no page/frame yet.

2:17 AM Changeset in webkit [29521] by Simon Hausmann
  • 2 edits in trunk/WebCore

Trivially implement the themed search field by mapping it to a text field

Also add a bunch of notImplemented warnings for other places where we don't
have an implementatin in RenderTheme.

2:02 AM ApplicationsGtk edited by alp@atoker.com
Add another feed reader (diff)
1:57 AM BuildingGtk edited by alp@atoker.com
Link to the archived GTK+/qmake build instructions (diff)
1:56 AM Changeset in webkit [29520] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Change hoveringOverLink implementation to have less issues.

  • Currently we only compare a pointer. In the worst case we could delete the Element we have pointed to and a new one gets the same address. But even if that doesn't happen the WebCore::Element is mutable and JavaScript could change the URL, Title or Content. So we have to compare all these three attributes.
  • This does not seem to be a performance impact.
1:55 AM Changeset in webkit [29519] by Simon Hausmann
  • 2 edits in trunk/WebCore
  • Follow the EventHandlerWin.cpp and always return true in the handlers.
  • Match the windows implementation more closely as well.
  • This is fixing "selection" bugs with the Web Inspector
1:55 AM Changeset in webkit [29518] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt
  • Move the hoverElement from QWebFrame to QWebPage. As it is only used there.
1:54 AM Changeset in webkit [29517] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

EventHandler changes/fixes in QWebPage:

-mouse{Press,Move,Release}Event:

Send the event always to the mainFrame of the QWebPage.

-contextMenuEvent, key{Press,Release}Event:

Send the event to the focused frame.

This is following the Windows port and fixes a issue with the
Web Inspector where we were sending the events to a wrong frame.

It is guaranteed that the mainFrame will always have an eventHandler
and frameView set. There is no need to check for this in QWebPage.

1:52 AM Changeset in webkit [29516] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt
  • Add core and kit functions to QWebFramePrivate to convert from QWebFrame to WebCore::Frame and vice versa.
1:38 AM Changeset in webkit [29515] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix crashes in the new networking code.

When the ResourceLoader cancels the handle we have to make sure not to access
the resource handle afterwards again.

1:38 AM Changeset in webkit [29514] by Simon Hausmann
  • 11 edits
    1 add in trunk

add conversion methods from and to QUrl to KURL.

Use them in the places I found at the moment. Fixes a bug
where form data was encoded twice.
Also fix QWebSettings to take a QUrl for the user style sheet
location.

Signed-off-by: Simon

1:37 AM Changeset in webkit [29513] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt
  • Make the InspectorClientView inherit from QWebView instead of QWidget. This way paintEvent, mouse{Press,Release}Event and other events get forwarded to the QWebPage/WebInspector automatically.
12:18 AM Changeset in webkit [29512] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Build fix.

  • win/tools/vsprops/release.vsprops:
12:02 AM Changeset in webkit [29511] by Darin Adler
  • 3 edits in trunk/WebCore

Rubber-stamped by Maciej Stachowiak and Oliver Hunt.

  • fix <rdar://problem/5689748> REGRESSION: Cannot redirect to protocols handled by external applications

Put navigation policy delegate calls back for redirects.
Just rolled out the change where I took them out.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::willSendRequest):
  • loader/MainResourceLoader.h:

Jan 15, 2008:

11:41 PM WikiStart edited by regsitesph@yahoo.com
(diff)
10:54 PM Changeset in webkit [29510] by adele@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam.

Remove unused variable for old media control background drawing code.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::~RenderThemeMac):
10:46 PM Changeset in webkit [29509] by weinig@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix typos in ChangeLog

10:43 PM Changeset in webkit [29508] by weinig@apple.com
  • 35 edits in trunk

JavaScriptCore:

Reviewed by Geoffrey Garen.

Fix <rdar://problem/5595552> r27608 introduced a 20% increase in JS binary size, 4% increase in WebCore binary size

  • This changes the way JS functions that use Lookup tables are handled. Instead using one class per function, which allowed specialization of the virtual callAsFunction method, we now use on class, PrototypeFunction, which takes a pointer to a static function to use as the implementation. This significantly decreases the binary size of JavaScriptCore (about 145k on an Intel only build) while still keeping some of the speedup r27608 garnered (SunSpider says this is 1.005x as slow, which should leave some wiggle room from the original 1% speedup) and keeps the functions implementations in separate functions to help with optimizations.
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/array_object.cpp: (KJS::arrayProtoFuncToString): (KJS::arrayProtoFuncToLocaleString): (KJS::arrayProtoFuncJoin): (KJS::arrayProtoFuncConcat): (KJS::arrayProtoFuncPop): (KJS::arrayProtoFuncPush): (KJS::arrayProtoFuncReverse): (KJS::arrayProtoFuncShift): (KJS::arrayProtoFuncSlice): (KJS::arrayProtoFuncSort): (KJS::arrayProtoFuncSplice): (KJS::arrayProtoFuncUnShift): (KJS::arrayProtoFuncFilter): (KJS::arrayProtoFuncMap): (KJS::arrayProtoFuncEvery): (KJS::arrayProtoFuncForEach): (KJS::arrayProtoFuncSome): (KJS::arrayProtoFuncIndexOf): (KJS::arrayProtoFuncLastIndexOf):
  • kjs/array_object.h:
  • kjs/date_object.cpp: (KJS::DatePrototype::getOwnPropertySlot): (KJS::dateProtoFuncToString): (KJS::dateProtoFuncToUTCString): (KJS::dateProtoFuncToDateString): (KJS::dateProtoFuncToTimeString): (KJS::dateProtoFuncToLocaleString): (KJS::dateProtoFuncToLocaleDateString): (KJS::dateProtoFuncToLocaleTimeString): (KJS::dateProtoFuncValueOf): (KJS::dateProtoFuncGetTime): (KJS::dateProtoFuncGetFullYear): (KJS::dateProtoFuncGetUTCFullYear): (KJS::dateProtoFuncToGMTString): (KJS::dateProtoFuncGetMonth): (KJS::dateProtoFuncGetUTCMonth): (KJS::dateProtoFuncGetDate): (KJS::dateProtoFuncGetUTCDate): (KJS::dateProtoFuncGetDay): (KJS::dateProtoFuncGetUTCDay): (KJS::dateProtoFuncGetHours): (KJS::dateProtoFuncGetUTCHours): (KJS::dateProtoFuncGetMinutes): (KJS::dateProtoFuncGetUTCMinutes): (KJS::dateProtoFuncGetSeconds): (KJS::dateProtoFuncGetUTCSeconds): (KJS::dateProtoFuncGetMilliSeconds): (KJS::dateProtoFuncGetUTCMilliseconds): (KJS::dateProtoFuncGetTimezoneOffset): (KJS::dateProtoFuncSetTime): (KJS::dateProtoFuncSetMilliSeconds): (KJS::dateProtoFuncSetUTCMilliseconds): (KJS::dateProtoFuncSetSeconds): (KJS::dateProtoFuncSetUTCSeconds): (KJS::dateProtoFuncSetMinutes): (KJS::dateProtoFuncSetUTCMinutes): (KJS::dateProtoFuncSetHours): (KJS::dateProtoFuncSetUTCHours): (KJS::dateProtoFuncSetDate): (KJS::dateProtoFuncSetUTCDate): (KJS::dateProtoFuncSetMonth): (KJS::dateProtoFuncSetUTCMonth): (KJS::dateProtoFuncSetFullYear): (KJS::dateProtoFuncSetUTCFullYear): (KJS::dateProtoFuncSetYear): (KJS::dateProtoFuncGetYear):
  • kjs/date_object.h:
  • kjs/function.cpp: (KJS::PrototypeFunction::PrototypeFunction): (KJS::PrototypeFunction::callAsFunction):
  • kjs/function.h:
  • kjs/lookup.h: (KJS::HashEntry::): (KJS::staticFunctionGetter):
  • kjs/math_object.cpp: (KJS::mathProtoFuncAbs): (KJS::mathProtoFuncACos): (KJS::mathProtoFuncASin): (KJS::mathProtoFuncATan): (KJS::mathProtoFuncATan2): (KJS::mathProtoFuncCeil): (KJS::mathProtoFuncCos): (KJS::mathProtoFuncExp): (KJS::mathProtoFuncFloor): (KJS::mathProtoFuncLog): (KJS::mathProtoFuncMax): (KJS::mathProtoFuncMin): (KJS::mathProtoFuncPow): (KJS::mathProtoFuncRandom): (KJS::mathProtoFuncRound): (KJS::mathProtoFuncSin): (KJS::mathProtoFuncSqrt): (KJS::mathProtoFuncTan):
  • kjs/math_object.h:
  • kjs/string_object.cpp: (KJS::stringProtoFuncToString): (KJS::stringProtoFuncValueOf): (KJS::stringProtoFuncCharAt): (KJS::stringProtoFuncCharCodeAt): (KJS::stringProtoFuncConcat): (KJS::stringProtoFuncIndexOf): (KJS::stringProtoFuncLastIndexOf): (KJS::stringProtoFuncMatch): (KJS::stringProtoFuncSearch): (KJS::stringProtoFuncReplace): (KJS::stringProtoFuncSlice): (KJS::stringProtoFuncSplit): (KJS::stringProtoFuncSubstr): (KJS::stringProtoFuncSubstring): (KJS::stringProtoFuncToLowerCase): (KJS::stringProtoFuncToUpperCase): (KJS::stringProtoFuncToLocaleLowerCase): (KJS::stringProtoFuncToLocaleUpperCase): (KJS::stringProtoFuncLocaleCompare): (KJS::stringProtoFuncBig): (KJS::stringProtoFuncSmall): (KJS::stringProtoFuncBlink): (KJS::stringProtoFuncBold): (KJS::stringProtoFuncFixed): (KJS::stringProtoFuncItalics): (KJS::stringProtoFuncStrike): (KJS::stringProtoFuncSub): (KJS::stringProtoFuncSup): (KJS::stringProtoFuncFontcolor): (KJS::stringProtoFuncFontsize): (KJS::stringProtoFuncAnchor): (KJS::stringProtoFuncLink):
  • kjs/string_object.h:

WebCore:

Reviewed by Geoffrey Garen.

Fix <rdar://problem/5595552> r27608 introduced a 20% increase in JS binary size, 4% increase in WebCore binary size

  • Update JS Function implementations to use a static function based method. This decreases the binary size of an Intel only build by 1013.5K.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/JSEventTargetBase.cpp: (WebCore::jsEventTargetAddEventListener): (WebCore::jsEventTargetRemoveEventListener): (WebCore::jsEventTargetDispatchEvent): (WebCore::retrieveEventTargetAndCorrespondingNode):
  • bindings/js/JSEventTargetBase.h:
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::jsHTMLInputElementBaseFunctionSetSelectionRange): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
  • bindings/js/JSHTMLInputElementBase.h:
  • bindings/js/JSLocation.cpp: (WebCore::JSLocation::getOwnPropertySlot): (WebCore::jsLocationProtoFuncReplace): (WebCore::jsLocationProtoFuncReload): (WebCore::jsLocationProtoFuncAssign): (WebCore::jsLocationProtoFuncToString):
  • bindings/js/JSLocation.h:
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::jsXMLHttpRequestPrototypeFunctionAbort): (KJS::jsXMLHttpRequestPrototypeFunctionGetAllResponseHeaders): (KJS::jsXMLHttpRequestPrototypeFunctionGetResponseHeader): (KJS::jsXMLHttpRequestPrototypeFunctionOpen): (KJS::jsXMLHttpRequestPrototypeFunctionSend): (KJS::jsXMLHttpRequestPrototypeFunctionSetRequestHeader): (KJS::jsXMLHttpRequestPrototypeFunctionOverrideMIMEType): (KJS::jsXMLHttpRequestPrototypeFunctionAddEventListener): (KJS::jsXMLHttpRequestPrototypeFunctionRemoveEventListener): (KJS::jsXMLHttpRequestPrototypeFunctionDispatchEvent):
  • bindings/js/JSXMLHttpRequest.h:
  • bindings/js/JSXSLTProcessor.cpp: (KJS::jsXSLTProcessorPrototypeFunctionImportStylesheet): (KJS::jsXSLTProcessorPrototypeFunctionTransformToFragment): (KJS::jsXSLTProcessorPrototypeFunctionTransformToDocument): (KJS::jsXSLTProcessorPrototypeFunctionSetParameter): (KJS::jsXSLTProcessorPrototypeFunctionGetParameter): (KJS::jsXSLTProcessorPrototypeFunctionRemoveParameter): (KJS::jsXSLTProcessorPrototypeFunctionClearParameters): (KJS::jsXSLTProcessorPrototypeFunctionReset):
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_events.cpp: (WebCore::jsClipboardPrototypeFunctionClearData): (WebCore::jsClipboardPrototypeFunctionGetData): (WebCore::jsClipboardPrototypeFunctionSetData): (WebCore::jsClipboardPrototypeFunctionSetDragImage):
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_navigator.cpp: (KJS::pluginsFunctionRefresh): (KJS::navigatorProtoFuncJavaEnabled):
  • bindings/js/kjs_navigator.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): (KJS::windowProtoFuncAToB): (KJS::windowProtoFuncBToA): (KJS::windowProtoFuncOpen): (KJS::windowProtoFuncSetTimeout): (KJS::windowProtoFuncClearTimeout): (KJS::windowProtoFuncSetInterval): (KJS::windowProtoFuncAddEventListener): (KJS::windowProtoFuncRemoveEventListener): (KJS::windowProtoFuncShowModalDialog): (KJS::windowProtoFuncNotImplemented):
  • bindings/js/kjs_window.h:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
10:30 PM Changeset in webkit [29507] by adele@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan.

Fix for <rdar://problem/5682492> With the <video> element, the audio is heard when forwarding or rewinding a movie while it's playing

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Instead of pausing the media when you stop seeking on mouse up, pause the video when you first start seeking on mouse down.
9:23 PM Changeset in webkit [29506] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.


Some tweaks to our headerdoc, suggested by David Gatwood on the docs
team.

  • API/JSBase.h:
  • API/JSObjectRef.h:
  • API/JSStringRef.h:
  • API/JSValueRef.h:
7:32 PM Changeset in webkit [29505] by alp@webkit.org
  • 8 edits in trunk

.:

Rubber-stamped by Anders.

Make the HTTP backend configurable in the GTK+ port. curl is currently
the only option.

  • GNUmakefile.am:
  • WebKit.pri:
  • configure.ac:

JavaScriptCore:

Rubber-stamped by Anders.

Make the HTTP backend configurable in the GTK+ port. curl is currently
the only option.

  • wtf/Platform.h: Don't hard-code WTF_USE_CURL for GTK

WebCore:

Rubber-stamped by Anders.

Make the HTTP backend configurable in the GTK+ port. curl is currently
the only option.

  • GNUmakefile.am:
5:53 PM Changeset in webkit [29504] by adele@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • rendering/RenderThemeSafari.cpp: Removing MediaBackgroundAppearance.
5:22 PM Changeset in webkit [29503] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Beth Dakin.

Remove unneeded variable.

  • kjs/string_object.cpp: (KJS::StringProtoFuncSubstr::callAsFunction):
5:16 PM Changeset in webkit [29502] by weinig@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5671040>
REGRESSION: 6% HTML iBench regression from r28722 (getElementsByClassName)

On my most consistent tests, this brings the HTML iBench from 1.46 -> 1.41,
which does not completely make up reported regression, but I was not able to
reproduce those findings either.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::checkOneSelector):
  • dom/ClassNames.cpp: (WebCore::ClassNames::parseClassAttribute):
  • dom/ClassNames.h: (WebCore::ClassNames::contains): (WebCore::ClassNames::operator[]):
5:12 PM Changeset in webkit [29501] by adele@apple.com
  • 2 edits in trunk/WebCore

Build fix. This time for real.

  • rendering/RenderThemeSafari.cpp:
4:53 PM Changeset in webkit [29500] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • updated Tiger results for <rdar://problem/5666926>
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
4:46 PM Changeset in webkit [29499] by adele@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • rendering/RenderThemeSafari.cpp:
4:43 PM Changeset in webkit [29498] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/5663888> Cannot type into a JavaScript prompt created from a timer


Allow nested timers from javascript prompts to allow for WebView-based edit fields.


Reviewed by Darin.

  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptPrompt):
4:37 PM Changeset in webkit [29497] by mitz@apple.com
  • 8 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5666926> svg/custom/use-css-no-effect-on-shadow-tree.svg is failing
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::getCTM): Changed the arguments' type from float to double in order to make the values passed to scale() and translate() on Mac OS X and on Windows the same.
  • svg/SVGPreserveAspectRatio.h:

LayoutTests:

Reviewed by Darin Adler.

  • updated results for <rdar://problem/5666926> svg/custom/use-css-no-effect-on-shadow-tree.svg is failing
  • platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
  • platform/mac/svg/hixie/links/001-expected.txt:
  • platform/win/Skipped:
2:50 PM Changeset in webkit [29496] by ggaren@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Andre Boule.

Fixed <rdar://problem/5667627> [WebCache empty] implementation should
not disable/enable the cache


Toggle the cache model instead -- toggling disable/enable just causes
the cache to forget about resources, not reclaim their memory.

  • Misc/WebCache.mm: (+[WebCache empty]):
  • WebView/WebView.mm:
  • WebView/WebViewInternal.h:
2:14 PM Changeset in webkit [29495] by ggaren@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Sam Weinig.


Fixed the waitUntilDone watchdog timer -- the old code never added the
timer to the run loop, so it didn't do anything.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setWaitToDump):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setWaitToDump):
1:47 PM Changeset in webkit [29494] by alp@webkit.org
  • 3 edits in trunk

2008-01-15 Alp Toker <​alp@atoker.com>

GTK+/autotools build fix for GCC < 4. Use the -fvisibility compiler
flags only when they're available.

Additionally, use -fvisibility-inlines-hidden in both debug and
release builds when available to match the Mac build.

  • GNUmakefile.am:
  • configure.ac:
1:10 PM Changeset in webkit [29493] by ap@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

<rdar://problem/5342813> REGRESSION: Safari encodes mailto URLs incorrectly

Test: fast/encoding/mailto-always-utf-8.html

  • platform/KURL.cpp: (WebCore::encodeRelativeString): Always use UTF-8 for mailto URLs.
12:37 PM Changeset in webkit [29492] by adele@apple.com
  • 31 edits
    2 adds in trunk

WebCore:

Reviewed by Adam and Antti.

WebCore part of fix for <rdar://problem/5619062> Add load progress indicator to video controls

  • WebCore.base.exp: Removed symbol for wkGetMediaControlBackgroundImageData. Added symbol for wkDrawMediaSliderTrack.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Removed case for MediaBackgroundAppearance.
  • css/html4.css: Removed -webkit-appearance: media-background rule for the media panel element. Removed unnecessary margin for slider.
  • rendering/RenderStyle.h: (WebCore::): Removed MediaBackgroundAppearance.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): Call updateMediaPlayer more frequently so the load progress control gets updated appropriately.
  • platform/mac/WebCoreSystemInterface.h: Removed wkGetMediaControlBackgroundImageData. Added wkDrawMediaSliderTrack.
  • platform/mac/WebCoreSystemInterface.mm: ditto.
  • rendering/RenderTheme.h: Removed paintMediaBackground. Added paintMediaSliderTrack.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Call paintMediaSliderTrack for elements with MediaSliderAppearance.
  • rendering/RenderThemeMac.h: Removed paintMediaBackground. Added paintMediaSliderTrack.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): Added different sizes for the media slider thumb. (WebCore::RenderThemeMac::paintMediaSliderTrack): Added. Calls wkDrawMediaSliderTrack with the percentage the media has loaded.
  • rendering/RenderThemeSafari.cpp: ditto. (WebCore::RenderThemeSafari::adjustSliderThumbSize): (WebCore::RenderThemeSafari::paintMediaSliderTrack):
  • rendering/RenderThemeSafari.h:

WebKit/mac:

Reviewed by Adam and Antti.

WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Removed initialization for GetMediaControlBackgroundImageData. Added initialization for DrawMediaSliderTrack.

WebKitLibraries:

Reviewed by Adam and Antti.

Updated libraries for <rdar://problem/5619062> Add load progress indicator to video controls

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
  • win/include/SafariTheme: Added.
  • win/include/SafariTheme/SafariThemeConstants.h: Added. Placeholder empty header until we release an updated WebKitSupportLibrary.

LayoutTests:

Reviewed by Adam and Antti.

Updated tests for <rdar://problem/5619062> Add load progress indicator to video controls

  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
11:06 AM Changeset in webkit [29491] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

11:04 AM Changeset in webkit [29490] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.3

New tag.

7:39 AM BuildingQtOnLinux edited by joachim.tesch@gmail.com
Fixed libxslt1-dev Ubuntu package name (diff)
1:27 AM Changeset in webkit [29489] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Some logging channels weren't initialized from user defaults.

  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary): Initialize LogPlatformLeaks, LogStorageAPI, LogMedia, LogPlugin.
12:50 AM Changeset in webkit [29488] by sfalken@apple.com
  • 23 edits in trunk

JavaScriptCore:

Use shared vsprops for most vcproj properties.


Reviewed by Darin.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add missing Debug_Internal config.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Add missing Debug_Internal config.
  • JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

WebCore:

Use shared vsprops for most vcproj properties.


Reviewed by Darin.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::initializeQuickTime): Fix compiler warning.

WebKit/win:

Use shared vsprops for most vcproj properties.


Reviewed by Darin.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj: Add missing Debug_Internal config.

WebKitLibraries:

Use shared vsprops for most vcproj properties.


Reviewed by Darin.

  • win/tools/vsprops/common.vsprops:
  • win/tools/vsprops/debug.vsprops:
  • win/tools/vsprops/debug_internal.vsprops:
  • win/tools/vsprops/release.vsprops:

WebKitTools:

Use shared vsprops for most vcproj properties.


Reviewed by Darin.

  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • FindSafari/FindSafari.vcproj:

Jan 14, 2008:

9:43 PM Changeset in webkit [29487] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by mjs.

Remove a couple more uses of DeprecatedString

No functional changes, thus no test case.

  • dom/Document.cpp: (WebCore::Document::write): (WebCore::Document::writeln): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h:
9:41 PM Changeset in webkit [29486] by alp@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2008-01-14 Pierre-Luc Beaudoin <​pierre-luc.beaudoin@collabora.co.uk>

Reviewed by Alp Toker.

Build fix: missing symbols when compiling WebKit/Gtk+ with --enable-svg-filters
​http://bugs.webkit.org/show_bug.cgi?id=16874

  • GNUmakefile.am:
  • svg/graphics/cairo/SVGResourceFilterCairo.cpp: Added. (WebCore::SVGResourceFilter::createPlatformData): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
7:59 PM Changeset in webkit [29485] by Stephanie Lewis
  • 2 edits in trunk/WebKitTools

2008-01-14 Stephanie <Stephanie Lewis>

revert accidental character.

7:52 PM Changeset in webkit [29484] by Stephanie Lewis
  • 4 edits in trunk

2008-01-14 Stephanie <Stephanie Lewis>

RS=Oliver

add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>

  • Scripts/run-webkit-tests:

add svg/css/glyph-orientation-rounding-test.xhtml to skip list. See <rdar://problem/5686552>

  • platform/mac-leopard/Skipped:
5:31 PM Changeset in webkit [29483] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by hyatt & eseidel.

This patch fixes an issue with addLineBoxRects not correctly calculating the
rects due to an off-by-one error in using box->end(). We were assuming that
end() gives the index past the last character, when in fact it gives the
index _of_ the last character.

Eric Seidel and I could not find a way to test this via DRT. This method is
only used by WebKit or Safari for displaying selection rects AFAICT.

  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
5:03 PM Changeset in webkit [29482] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • fix crash seen in layout tests
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::attach): Remove incorrect cast to HTMLElement* for parentNode(). The parent is either an HTMLElement or a Document, not necessarily an HTMLElement.
2:51 PM Changeset in webkit [29481] by Darin Adler
  • 14 edits
    1 add in trunk/WebCore

Reviewed by Sam.

  • fix mistakes Sam noticed in my re-speed-up patch
  • dom/Element.cpp: (WebCore::Element::virtualHasTagName): Moved out of header file. No reason to make this inline.
  • dom/Element.h: Moved virtualHasTagName out of header file.
  • dom/Node.cpp: (WebCore::Node::virtualHasTagName): Moved out of header file. No reason to make this inline.
  • dom/Node.h: Removed incorrect "virtual" on hasTagName and moved virtualHasTagName out of header file.
  • platform/text/StringBuffer.h: Added. Has just the new StringBuffer class.
  • platform/text/StringImpl.h: Removed StringBuffer class.
  • loader/DocumentLoader.cpp: Added StringBuffer.h include.
  • platform/text/String.cpp: Ditto.
  • platform/text/StringImpl.cpp: Ditto.
  • platform/text/TextCodecLatin1.cpp: Ditto.
  • platform/text/TextCodecUTF16.cpp: Ditto.
  • platform/text/TextCodecUserDefined.cpp: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Added StringBuffer.h.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
2:35 PM Changeset in webkit [29480] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Queue up another rename.
1:05 PM Changeset in webkit [29479] by hyatt@apple.com
  • 2 edits
    3 moves in trunk/WebCore

Clean up VS project file after graphics files moved.

12:13 PM Changeset in webkit [29478] by ggaren@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Sam Weinig.


Some cleanup to my last patch.

Removed one unused setter declaration and one unused setter definition.


Renamed DoNotCheckDomainSecurityOnRead to DoNotCheckDomainSecurityOnGet
because "get" is all over the IDL files, and "read" is not.

  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.h: (WebCore::DOMWindow::defaultstatus):
  • page/DOMWindow.idl:
11:26 AM Changeset in webkit [29477] by mitz@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Alice Liu.

  • remove reference to nonexistent file
  • WebCore.vcproj/WebCore.vcproj: Removed reference to SVGFont.h.
11:25 AM Changeset in webkit [29476] by ddkilzer@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix date; restore '<'.

11:11 AM Changeset in webkit [29475] by Adam Roben
  • 2 edits in trunk/JavaScriptCore
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added some headers that were missing from the vcproj so their contents will be included in Find in Files.
11:02 AM Changeset in webkit [29474] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Fix Bug 16871: Crash when loading apple.com/startpage

<​http://bugs.webkit.org/show_bug.cgi?id=16871>
<rdar://problem/5686670>

Patch written by Darin, reviewed by me.

  • kjs/ExecState.cpp: (KJS::ExecState::mark): Call ActivationImp::markChildren if our m_activation is on the stack. This is what ScopeChain::mark also does, but apparently in some cases it's possible for an ExecState's ActivationImp to not be in any ScopeChain.
10:38 AM Changeset in webkit [29473] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools
10:28 AM Changeset in webkit [29472] by kmccullough@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Oliver.

-<rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop
trying to view techreport.com comments

  • We need to set values in the map, because if they are already in the map they will not be reset when we use add().
  • kjs/array_instance.cpp: (KJS::ArrayInstance::put):

LayoutTests:

Reviewed by Oliver.

  • <rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop trying to view techreport.com comments
  • Any resetting of a value in an array of sufficient size, would cause the second value to be lost.
  • fast/js/array-reset-large-index-expected.txt: Added.
  • fast/js/array-reset-large-index.html: Added.
  • fast/js/resources/array-reset-large-index.js: Added.
10:24 AM Changeset in webkit [29471] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools
9:51 AM Changeset in webkit [29470] by Darin Adler
  • 40 edits in trunk

JavaScriptCore:

Reviewed by Adam.

  • re-speed-up the page load test (my StringImpl change slowed it down)
  • wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Allow derived classes to start with a reference count other than 0. Eventually everyone will want to start with a 1. This is a staged change. For now, there's a default of 0, and you can specify 1. Later, there will be no default and everyone will have to specify. And then later, there will be a default of 1. Eventually, we can take away even the option of starting with 0!
  • wtf/Vector.h: (WTF::Vector::Vector): Sped up creation of non-empty vectors by removing the overhead of first constructing something empty and then calling resize. (WTF::Vector::clear): Sped up the common case of calling clear on an empty vector by adding a check for that case. (WTF::Vector::releaseBuffer): Marked this function inline and removed a branch in the case of vectors with no inline capacity (normal vectors) by leaving out the code to copy the inline buffer in that case.

WebCore:

Reviewed by Adam.

  • re-speed-up the page load test (my StringImpl change slowed it down) <rdar://problem/5677241> 1.5% PLT regression from r29098

To reverse the slowdown I caused by changing StringImpl, I tightened it up,
and also did a little optimization in the HTML tokenizer and in other clients
of Vector.

  • WebCore.base.exp: Removed export of a now-inline function.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseTransitionProperty): Removed use of DeprecatedString to get property ID. This could be sped up even more by writing a fast path to use a local Vector<char> rather than allocating a string. (WebCore::convertASCIIToFloat): Added. Allows numeric conversion without allocating a string object to hold the number. (WebCore::CSSParser::lex): Changed to call convertASCIIToFloat instead of DeprecatedString::toFloat.
  • dom/Element.h: (WebCore::Element::hasTagName): Made this non-virtual and inline if you have an Element*. It's still virtual if you have a Node*. (WebCore::Element::virtualHasTagName): Virtual version that makes the Node* case work.
  • dom/Node.h: (WebCore::Node::hasTagName): Made this non-virtual and inline so that Element can override it with an inline. This is the same technique we use for firstChild and lastChild. (WebCore::Node::virtualHasTagName): This is the private virtual that Element overrides.
  • dom/Text.cpp: (WebCore::Text::splitText): Clean up by using a RefPtr here instead of a PassRefPtr.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): Use the new advancePastNonNewline(), which is more efficient in cases where we know the character is not a newline and hence we don't have to update the line number. (WebCore::HTMLTokenizer::parseComment): Ditto. (WebCore::HTMLTokenizer::parseServer): Ditto. (WebCore::HTMLTokenizer::parseProcessingInstruction): Ditto. (WebCore::HTMLTokenizer::parseText): Ditto. (WebCore::HTMLTokenizer::parseEntity): Ditto. (WebCore::HTMLTokenizer::parseTag): Ditto. Also streamline the QuotedValue case so there's one less branch taken for non-punctuation characters since this code path is *so* hot. (WebCore::HTMLTokenizer::write): More of the same.
  • loader/Cache.cpp: (WebCore::Cache::lruListFor): Use Vector::grow instead of resize.
  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): Use StringBuffer instead of Vector<UChar>.
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForCSSCharset): Use Vector::grow instead of resize. (WebCore::TextResourceDecoder::checkForHeadCharset): Ditto. (WebCore::TextResourceDecoder::decode): Use Vector::grow and shrink instead of resize. (WebCore::TextResourceDecoder::flush): Use Vector::shrink instead of resize.
  • platform/KURL.cpp: (WebCore::KURL::decode_string): Use Vector::grow instead of resize.
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::clear): Use Vector::shrink instead of resize.
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::cacheFrame): Use Vector::grow instead of resize.
  • platform/network/FormData.cpp: (WebCore::FormData::appendData): Use Vector::grow instead of resize. (WebCore::FormData::flatten): Ditto.
  • platform/text/AtomicString.cpp: (WebCore::CStringTranslator::translate): Use a new StringImpl constructor made just for use by AtomicString. Avoids setting fields twice, and also preserves reference count behavior (which I changed for the other constructors, since they're entirely private and used only inside the class). (WebCore::UCharBufferTranslator::translate): Ditto.
  • platform/text/Base64.cpp: (WebCore::base64Encode): Use Vector::grow instead of resize. (WebCore::base64Decode): Use Vector::grow and shrink instead of resize.
  • platform/text/PlatformString.h: (WebCore::String::adopt): Added an overload for the new StringBuffer class. Also made both versions inline.
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::advancePastNewline): Added. One less branch for case where the character is known to be a newline. (WebCore::SegmentedString::advancePastNonNewline): Added. Less code for case where the character is known not to be a newline.
  • platform/text/String.cpp: (WebCore::String::append): Use StringBuffer instead of Vector<UChar>. (WebCore::String::insert): Ditto. (WebCore::String::truncate): Ditto. (WebCore::String::remove): Ditto. (WebCore::String::format): Use Vector::grow instead of resize.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Changed constructors to start with a refCount of 1 instead of 0, and made them all inline. Eliminates the WithOneRef constructor since they all behave this way now. The only exceptions are the constructors for AtomicString, which retain the old behavior. (WebCore::StringImpl::empty): Simplified, since we no longer need to use the special WithOneRef constructor. (WebCore::StringImpl::toCoordsArray): Use StringBuffer instead of Vector<UChar>. (WebCore::StringImpl::lower): Ditto. (WebCore::StringImpl::upper): Ditto. (WebCore::StringImpl::secure): Ditto. (WebCore::StringImpl::foldCase): Ditto. (WebCore::StringImpl::simplifyWhiteSpace): Ditto. Also change to use Vector::shrink instead of resize (since half of the function uses Vector<UChar>). (WebCore::StringImpl::capitalize): Use StringBuffer instead of Vector<UChar>. (WebCore::StringImpl::replace): Ditto. (WebCore::StringImpl::ascii): Streamlined a bit. (WebCore::StringImpl::createStrippingNullCharacters): Use StringBuffer insetad of Vector<UChar>. Took out checks for null characters and 0 length that aren't needed. Coded the check for null characters in a slightly more efficient way. Since this is so hot, didn't call adopt at all, putting the code right in here, including the call to the StringImpl constructor and adoptRef (for the fast case). (WebCore::StringImpl::adopt): Added a version for the new StringBuffer class. Removed the attempt to resize the buffer at the time we adopt based on measuring actual use and realizing that it's just a character here or there and not worth a call to fastRealloc. Changed to use adoptRef since the constructor now starts with a refCount of 1. (WebCore::StringImpl::create): Changed to use adoptRef since the constructor now starts with a refCount of 1. (WebCore::StringImpl::createWithTerminatingNullCharacter): Ditto. (WebCore::StringImpl::copy): Ditto. Also made non-inline since the constructor itself is now inline.
  • platform/text/StringImpl.h: Added a StringBuffer class that's useful for putting characters into a buffer before creating an immutable string. Not good at resizing the way Vector<UChar> is, so only useful for things that rarely need to be resized. Added a new AdoptBuffer constructor and empty constructor, but made all constructors private so they can be inlined and only used inside the StringImpl class. Added two new constructors for AtomicString. Made copy() no longer inline. Changed the type of the [] operator to unsigned instead of int and added an assertion. Made the hash functions inline.
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::encode): Use Vector::grow instead of resize.
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode): Use StringBuffer instead of Vector<UChar>. (WebCore::encodeComplexWindowsLatin1): Use Vector::grow instead of resize.
  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Use StringBuffer instead of Vector<UChar>.
  • platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode): Use StringBuffer instead of Vector<UChar>. (WebCore::encodeComplexUserDefined): Use Vector::grow instead of resize.
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode): Use Vector::grow instead of resize.
  • platform/text/TextStream.cpp: (WebCore::TextStream::operator<<): Use Vector::grow instead of resize.
  • platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::encode): Use Vector::grow instead of resize.
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::insertSpanCell): Use Vector::grow instead of resize.
  • rendering/RenderFrameSet.h: (WebCore::FrameEdgeInfo::FrameEdgeInfo): Allocate vectors with the correct initial size instead of calling resize on them after allocating empty.
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): Use Vector::grow instead of resize.
  • rendering/RenderStyle.cpp: Removed CursorList::operator==.
  • rendering/RenderStyle.h: (WebCore::CursorList::operator==): Implemented using the Vector ==. (WebCore::CursorList::operator!=): Ditto.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::splitColumn): Use Vector::grow instead of resize. (WebCore::RenderTable::appendColumn): Ditto.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): Use Vector::grow instead of resize.
  • rendering/bidi.cpp: (WebCore::addMidpoint): Use Vector::grow instead of resize.
  • xml/XPathNodeSet.h: (WebCore::XPath::NodeSet::clear): Use Vector::shrink instead of resize.
9:47 AM Changeset in webkit [29469] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: More ignore list tweaking.
9:45 AM Changeset in webkit [29468] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Add another leak to the ignore list.
9:03 AM Changeset in webkit [29467] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Fixed a typo pointed out by Alexey.
8:44 AM Changeset in webkit [29466] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some intermittent failures.
8:35 AM Changeset in webkit [29465] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Put back a failing test.
7:39 AM Changeset in webkit [29464] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

  • try to fix failure in fast/dom/Window/window-onFocus.html seen on the build bots
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
7:36 AM Changeset in webkit [29463] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Re-added two tests that weren't failing for me, but fail on the buildbot.

  • platform/win/Skipped:
7:20 AM Changeset in webkit [29462] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Added fast/frames/frame-name-reset.html, which crashes, and sometimes freezes buildbot.

  • platform/win/Skipped:
6:15 AM Changeset in webkit [29461] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Removed some more tests, moved one to a better place.

  • platform/win/Skipped:
4:33 AM Changeset in webkit [29460] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a test that doesn't fail for me - let's see what the bot thinks.

  • platform/win/Skipped: Removed http/tests/xmlhttprequest/XMLHttpRequestException.html.
1:12 AM Changeset in webkit [29459] by ap@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by David Kilzer.

​http://bugs.webkit.org/show_bug.cgi?id=16787
array.splice() with 1 element not working

Test: fast/js/array-splice.html

  • kjs/array_object.cpp: (KJS::ArrayProtoFuncSplice::callAsFunction): Implement this Mozilla extension, and fix some other edge cases.

Jan 13, 2008:

10:05 PM Changeset in webkit [29458] by sfalken@apple.com
  • 19 edits
    1 move
    4 adds
    23 deletes in trunk

JavaScriptCore:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Reviewed by Adam Roben.

WebCore:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • WebCore.vcproj/PRODUCTVERSION: Removed.
  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/VERSION: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/auto-version.sh: Removed.
  • WebCore.vcproj/debug.vsprops: Removed.
  • WebCore.vcproj/debug_internal.vsprops: Removed.
  • WebCore.vcproj/release.vsprops: Removed.

WebKit/win:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/PRODUCTVERSION: Removed.
  • WebKit.vcproj/VERSION: Removed.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKit.vcproj/auto-version.sh: Removed.
  • WebKit.vcproj/debug.vsprops: Removed.
  • WebKit.vcproj/debug_internal.vsprops: Removed.
  • WebKit.vcproj/release.vsprops: Removed.

WebKitLibraries:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Moved auto-version.sh, VERSION, PRODUCTVERSION to tools.

Reviewed by Adam Roben.

  • win/tools/WinTools.make:
  • win/tools/scripts: Added.
  • win/tools/scripts/PRODUCTVERSION: Added.
  • win/tools/scripts/VERSION: Added.
  • win/tools/scripts/auto-version.sh: Copied from WebCore/WebCore.vcproj/auto-version.sh.
  • win/tools/vsprops/debug.vsprops:
  • win/tools/vsprops/debug_internal.vsprops: Added.
  • win/tools/vsprops/release.vsprops:

WebKitTools:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
  • Drosera/win/Drosera.vcproj/VERSION: Removed.
  • Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
  • Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
  • Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
  • Drosera/win/Drosera.vcproj/release.vsprops: Removed.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/debug.vsprops: Removed.
  • DumpRenderTree/win/debug_internal.vsprops: Removed.
  • DumpRenderTree/win/release.vsprops: Removed.
8:40 PM Changeset in webkit [29457] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy): Removed the call to RenderLayer::destroy() from here, because ~RenderLayer() calls RenderObject() methods.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Added the call to RenderLayer::destroy() here.
5:35 PM Changeset in webkit [29456] by eric@webkit.org
  • 3 edits
    6 adds in trunk

Reviewed by darin.

Range.insertNode does not update endContainer endIndex correctly
in the case where it had to split a text node.
​http://bugs.webkit.org/show_bug.cgi?id=16765

Darin pointed out during review that we still don't handle the dynamic
range case (where the dom tree changes not using range methods)
Thus this code will get ripped out when we add that. The test cases
are still valid and useful however, so I'm landing this as-is.

Tests: fast/dom/Range/range-insertNode-separate-endContainer.html

fast/dom/Range/range-insertNode-splittext.html

  • dom/Range.cpp: (WebCore::Range::insertNode): handle the splitText case correctly.
11:54 AM Changeset in webkit [29455] by Darin Adler
  • 2 edits
    3 adds in trunk/WebKitTools

Reviewed by Maciej.

  • Scripts/gdb-drosera: Added.
  • Scripts/run-drosera: Added.
  • Scripts/run-drosera-nightly.cmd: Added.
  • Scripts/webkitdirs.pm: Added runDrosera function.
11:47 AM Changeset in webkit [29454] by Darin Adler
  • 5 edits in trunk/JavaScriptCore

Contributions and review by Adriaan de Groot,
Simon Hausmann, Eric Seidel, and Darin Adler.

  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Use the WIN_OS code path for SOLARIS too, presumably because Solaris also lacks the tm_gtoff and tm_zone fields. (KJS::GregorianDateTime::operator tm): Ditto.
  • kjs/collector.cpp: (KJS::currentThreadStackBase): Use thr_stksegment on Solaris.
  • wtf/MathExtras.h: (isfinite): Implement for Solaris. (isinf): Ditto. (signbit): Ditto. But this one is wrong, so I added a FIXME.
  • wtf/Platform.h: Define PLATFORM(SOLARIS) when "sun" or "sun" is defined.
11:34 AM Changeset in webkit [29453] by kevino@webkit.org
  • 8 edits in trunk/WebKit/wx

wxWebKit API changes in preparation for DRT implementation.

Reviewed by Darin Adler.

11:19 AM Changeset in webkit [29452] by Darin Adler
  • 10 edits in trunk/WebCore

Reviewed by Eric.

  • dom/Document.cpp: (WebCore::Document::setDomain): Removed unneeded call to copy. (WebCore::Document::parseQualifiedName): Removed unneeded call to copy, and unneeded length argument to substring, which stops at the end of the string if you don't specify a length. (WebCore::Document::createAttributeNS): Replaced code that was calling copy with more-efficient code using the substring function.
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor): Removed unneeded call to copy.
  • editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Removed unneeded copy and also initialized text instead of assigning to it. (WebCore::InsertIntoTextNodeCommand::doApply): Removed redundant assertions. (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Removed unneeded call to copy. This one was particularly bad since we just turned around and copied it again!
  • editing/markup.cpp: (WebCore::stringValueForRange): Removed unneeded call to copy.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::performOpenInitialization): Changed logging code to not get the path from the database object. This was the only reason the database had to keep its path around.
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open): Use a local variable instead of a data member to convert the string to a null-terminated one. (WebCore::SQLiteDatabase::close): Removed the code to clear out m_path.
  • platform/sql/SQLiteDatabase.h: Removed the m_path data member and the path functio member. Also tweaked formatting and comments a bit. Removed the unused escapeSQLString function.
  • platform/text/String.cpp: (WebCore::operator+): Removed uneeded calls to copy.
9:24 AM Changeset in webkit [29451] by mitz@apple.com
  • 2 edits in trunk/WebKitTools
  • fix breakage due to last-minute change
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Declare the loop variable.
9:15 AM Changeset in webkit [29450] by mitz@apple.com
  • 8 edits in trunk

WebKitTools:

Reviewed by Adam Roben.

  • fix <rdar://problem/5132009> Windows DRT does not support multiple windows
  • DumpRenderTree/win/DumpRenderTree.cpp: (DumpRenderTreeWndProc): (initialize): (dumpBackForwardList): (dumpBackForwardListForAllWindows): (dump): (resetWebViewToConsistentStateBeforeTesting): Factored out of runTest(). (runTest): (allWindows): Added. Returns a vector of all open windows. (windowToWebViewMap): Added. Returns a map from open windows to their WebViews. (createWebViewAndOffscreenWindow): Factored out of main() to be reusable for creating extra windows. (main):
  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::windowCount): Implemented.
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::createWebViewWithRequest): Implemented. (UIDelegate::webViewClose): Implemented.
  • DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Reviewed by Adam Roben.

  • enable tests affected by <rdar://problem/5132009> Windows DRT does not support multiple windows
  • platform/win/Skipped:
5:20 AM Changeset in webkit [29449] by oliver@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix QT build

5:09 AM Changeset in webkit [29448] by oliver@apple.com
  • 3 edits in trunk/WebCore

Avoid repainting the entire canvas element when possible.

Reviewed by Mark Rowe.

We now only register the dirty regions of a canvas for repainting, rather
than the entire element (though repaint coalescing may choose to combine
these regions). This doesn't cause a measurable regression in the worst
case (clearing the canvas repeatedly), but is a moderate-large win if only
a minor update has occurred. If there is any CSS scaling applied to the
canvas almost any update short of clearing the entire element is substantially
faster.

3:08 AM Changeset in webkit [29447] by mrowe@apple.com
  • 13 edits in trunk

2008-01-13 Michael Goddard <​michael.goddard@trolltech.com>

Reviewed by Anders Carlsson.

Add binding language type to Instance.
Allows runtime determination of the type of an
Instance, to allow safe casting. Doesn't actually
add any safe casting yet, though.

Add a helper function to get an Instance from a JSObject*.
Given an object and the expected binding language, see if
the JSObject actually wraps an Instance of the given type
and return it. Otherwise return 0.

Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.

Remove copy ctor/assignment operator for QtInstance.
Instance itself is Noncopyable, so QtInstance doesn't
need to have these.

Add caching for QtInstance and associated RuntimeObjectImps.
Push any dealings with QtLanguage bindings into QtInstance,
and cache them there, rather than in the Instance layer. Add
a QtRuntimeObjectImp to help with caching.

  • JavaScriptCore.exp:
  • bindings/c/c_instance.h:
  • bindings/jni/jni_instance.h:
  • bindings/objc/objc_instance.h:
  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::~QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::invalidate): (KJS::Bindings::QtRuntimeObjectImp::removeFromCache): (KJS::Bindings::QtInstance::QtInstance): (KJS::Bindings::QtInstance::~QtInstance): (KJS::Bindings::QtInstance::getQtInstance): (KJS::Bindings::QtInstance::getRuntimeObject):
  • bindings/qt/qt_instance.h: (KJS::Bindings::QtInstance::getBindingLanguage):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject): (KJS::Bindings::Instance::getInstance):
  • bindings/runtime.h:
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::getInternalInstance):

2008-01-13 Michael Goddard <​michael.goddard@trolltech.com>

Reviewed by Anders Carlsson.

Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.

  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject):
2:20 AM BuildingGtk edited by lethalman88@gmail.com
Gentoo overlay for WebKit (diff)
12:51 AM Changeset in webkit [29446] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Change test to match the results landed in r29424. The test changes were
omitted in that check-in.

  • editing/pasteboard/paste-RTFD.html:
Note: See TracTimeline for information about the timeline view.