Timeline
May 22, 2009:
- 11:25 PM Changeset in webkit [44082] by
-
- 2 edits in trunk/WebCore
2009-05-22 Dirk Schulze <krit@webkit.org>
Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- 11:00 PM Changeset in webkit [44081] by
-
- 2 edits in trunk/WebCore
2009-05-22 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Added the use of tileRect() for a correct drawing of
border-images.
Testcases for border-image are in fast/borders like
border-image-01.html and will be activated for cairo, once
gtk supports pixel tests.
https://bugs.webkit.org/show_bug.cgi?id=19652
[CAIRO] wrong drawing of border-image
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- 10:47 PM Changeset in webkit [44080] by
-
- 3 edits in trunk/JavaScriptCore
Part two of an attempted Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 10:47 PM Changeset in webkit [44079] by
-
- 2 edits in trunk/WebCore
Ask the Scrollbar for the orientation.
https://bugs.webkit.org/show_bug.cgi?id=25684
Use Scrollbar::orientation to figure out the
direction of scrolling.
- 10:13 PM Changeset in webkit [44078] by
-
- 3 edits in trunk/JavaScriptCore
Part one of an attempted Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 9:51 PM Changeset in webkit [44077] by
-
- 2 edits in trunk/WebKit/gtk
Improve network request docs
- 6:48 PM Changeset in webkit [44076] by
-
- 30 edits in trunk/JavaScriptCore
2009-05-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
op_method_check
Optimize method calls, by caching specific function values within the Structure.
The new opcode is used almost like an x86 opcode prefix byte to optimize op_get_by_id,
where the property access is being used to read a function to be passed to op-call (i.e.
'foo.bar();'). This patch modifies the Structure class such that when a property is
put to an object for the first time we will check if the value is a function. If it is,
we will cache the function value on the Structure. A Structure in such a state guarantees
that not only does a property with the given identifier exist on the object, but also that
its value is unchanged. Upon any further attempt to put a property with the same identifier
(but a different value) to the object, it will transition back to a normal Structure (where
it will guarantee the presence but not the value of the property).
op_method_check makes use of the new information made available by the Structure, by
augmenting the functionality of op_get_by_id. Upon generating a FunctionCallDotNode a
check will be emitted prior to the property access reading the function value, and the JIT
will generate an extra (initially unlinked but patchable) set of checks prior to the regular
JIT code for get_by_id. The new code will do inline structure and prototype structure check
(unlike a regular get_by_id, which can only handle 'self' accesses inline), and then performs
an immediate load of the function value, rather than using memory accesses to load the value
from the obejct's property storage array. If the method check fails it will revert, or if
the access is polymorphic, the op_get_by_id will continue to operate - and optimize itself -
just as any other regular op_get_by_id would.
~2.5% on v8-tests, due to a ~9% progression on richards.
- API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
- API/JSObjectRef.cpp: (JSObjectMakeConstructor):
- JavaScriptCore.exp:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::differenceBetween):
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::moveWithPatch):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/CodeBlock.h: (JSC::getMethodCallLinkInfoReturnLocation): (JSC::CodeBlock::getMethodCallLinkInfo): (JSC::CodeBlock::addMethodCallLinkInfos): (JSC::CodeBlock::methodCallLinkInfo):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitMethodCheck):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile):
- jit/JIT.h: (JSC::MethodCallCompilationInfo::MethodCallCompilationInfo):
- jit/JITOpcodes.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::patchMethodCallProto):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_get_by_id_method_check): (JSC::JITStubs::cti_op_get_by_id_method_check_second):
- jit/JITStubs.h:
- jsc.cpp: (GlobalObject::GlobalObject):
- parser/Nodes.cpp: (JSC::FunctionCallDotNode::emitBytecode):
- runtime/Arguments.cpp: (JSC::Arguments::put):
- runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
- runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
- runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
- runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor): (JSC::constructError):
- runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
- runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
- runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
- runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
- runtime/JSActivation.cpp: (JSC::JSActivation::put): (JSC::JSActivation::putWithAttributes):
- runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
- runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::mark):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::methodCallDummy):
- runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::putWithAttributes): (JSC::JSObject::deleteProperty): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::getPropertyAttributes): (JSC::JSObject::getPropertySpecificFunction): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition):
- runtime/JSObject.h: (JSC::getJSFunction): (JSC::JSObject::getDirectLocation): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectWithoutTransition):
- runtime/LiteralParser.cpp: (JSC::LiteralParser::parseObject):
- runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h: (JSC::lookupPut):
- runtime/MathObject.cpp: (JSC::MathObject::MathObject):
- runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): (JSC::NativeErrorConstructor::construct):
- runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
- runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
- runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
- runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry):
- runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
- runtime/PutPropertySlot.h: (JSC::PutPropertySlot::): (JSC::PutPropertySlot::PutPropertySlot): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::setDespecifyFunctionProperty): (JSC::PutPropertySlot::isCacheable): (JSC::PutPropertySlot::cachedOffset):
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
- runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
- runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::changeFunctionTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::get): (JSC::Structure::despecifyFunction): (JSC::Structure::put): (JSC::Structure::remove):
- runtime/Structure.h: (JSC::Structure::get): (JSC::Structure::specificFunction):
- runtime/StructureTransitionTable.h: (JSC::StructureTransitionTableHashTraits::emptyValue):
- wtf/Platform.h:
- 6:34 PM Changeset in webkit [44075] by
-
- 3 edits2 adds in trunk
WebCore:
2009-05-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6916082> Incorrect handling of % as CSS value.
Test: fast/css/percent-character-as-value.html
- css/CSSGrammar.y: Make a stray % character reliably cause CSS parsing to succeed, but the CSS value to be ignored because of incorrect type. A type of 0 has this effect.
LayoutTests:
2009-05-22 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6916082> Incorrect handling of % as CSS value.
- fast/css/percent-character-as-value-expected.txt: Added.
- fast/css/percent-character-as-value.html: Added.
- 6:01 PM Changeset in webkit [44074] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add bugs.webkit.org URL for r44046
- 5:59 PM Changeset in webkit [44073] by
-
- 5 edits in trunk
WebCore:
2009-05-22 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25971
Correct a handful of build errors in the Windows Cairo variant
due to missing VIDEO support.
- WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for the Cairo-based Windows target.
- rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls for non-VIDEO builds.
WebKit/win:
2009-05-22 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25971
Correct some build errors for Windows Cairo variant.
- WebKit.vcproj/WebKit.vcproj: Remove WTF.lib link commands as the new JavaScriptCore.dll supplies this now.
- 5:54 PM Changeset in webkit [44072] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 5:53 PM Changeset in webkit [44071] by
-
- 1 copy in tags/Safari-6530.12
New tag.
- 5:48 PM Changeset in webkit [44070] by
-
- 2 edits in trunk/WebCore
One <limits> is enough
- html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
- 3:58 PM Changeset in webkit [44069] by
-
- 2 edits in trunk/WebKit/mac
2009-05-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- Fix <rdar://problem/6913765> REGRESSION (r42331-r42334): Extra scroll bars appearing on Welcome panels of iLife '09 apps
- WebView/WebView.mm: (needsUnwantedScrollBarWorkaround): Added. Checks if this is a panel where scroll bars are unwanted. For safety, limited to only Apple applications. (-[WebView viewDidMoveToWindow]): If the workaround is needed, disallow scrolling the main frame. This prevents scroll bars from appearing.
- 2:57 PM Changeset in webkit [44068] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix non-SSE enabled builds.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_add): Don't early return here, we still need to call the JIT stub. (JSC::JIT::emitSlow_op_sub): Ditto.
- 2:54 PM Changeset in webkit [44067] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Here's a thought: let's not take a jit stub call just to multiply by 1,
bokay?
imul doesn't set the zero flag, so to test for a zero result, we need
an explicit instruction. (Luckily, it does set the overflow flag, so
we can still use that.)
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitMul32InPlace):
- 2:30 PM Changeset in webkit [44066] by
-
- 2 edits in trunk/WebCore
2009-05-22 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
plug-in
Reviewed by Steve Falkenburg.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::determineQuirks): Look for the VLC plug-in's new name.
- 2:15 PM Changeset in webkit [44065] by
-
- 3 edits in trunk/WebCore
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Remove redudant member from Chromium's ResourceRequest. We already
have this data in the cross-platform ResourceRequestBase. Also, rename
ChromiumBridge parameter to be consistant with the new name for this
piece of data.
- platform/chromium/ChromiumBridge.h:
- platform/network/chromium/ResourceRequest.h:
- 2:14 PM Changeset in webkit [44064] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey "Premature Commit" Garen.
Add back constant integer cases for op_add.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32Constant):
- jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateDouble): (JSC::JIT::isOperandConstantImmediateDouble):
- 2:11 PM Changeset in webkit [44063] by
-
- 5 edits2 adds in trunk
Modify projects to use CFLite when not building the Apple Windows port.
- 2:07 PM Changeset in webkit [44062] by
-
- 7 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added fast double cases for op_jnless and op_jnlesseq.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::JumpList::jumps): New accesor, used by addSlowCase.
- assembler/X86Assembler.h: (JSC::X86Assembler::ucomisd_rm): New method for comparing register to memory.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emit_op_div): Modified emitBinaryDoubleOp to accept comparison/jump operations in addition to operations with explicit result registers.
- jit/JITInlineMethods.h: (JSC::JIT::addSlowCase): Added an "addSlowCase" for JumpLists, so clients can track multiple jumps to the same slow case condition together.
- 1:48 PM Changeset in webkit [44061] by
-
- 3 edits in trunk/LayoutTests
2009-05-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- Made the global-function-resolve test independent of hashing order by using a fixed set of properties. This also removes the need for us to update this test every time we add something to the window object or the js-test-pre.js family of scripts.
- fast/js/global-function-resolve-expected.txt: Updated.
- fast/js/resources/global-function-resolve.js: Use a fixed array instead of using all property names from the global object; also made other small changes that don't have an effect on the substance of the test.
- 1:35 PM Changeset in webkit [44060] by
-
- 6 edits in trunk
Reviewed by Kevin Ollivier.
Triple-click support for wx port. Also, switch to allocating GraphicsContext
on the stack in OnPaint since we only need it within that function.
https://bugs.webkit.org/show_bug.cgi?id=25962
- 1:32 PM Changeset in webkit [44059] by
-
- 1 edit in trunk/WebCore/ChangeLog
Date fix on ChangeLog.
- 1:31 PM Changeset in webkit [44058] by
-
- 1 edit2 deletes in trunk/LayoutTests
Reviewed by Darin Adler.
- remove a test that was supposed to test the text/* change to MIME types from r43979, since the change was rolled out, and the test seems to be ineffective anyway, since it was passing on Mac after rolling out the change.
- http/tests/mime/accept-all-text-types-expected.txt: Removed.
- http/tests/mime/accept-all-text-types.html: Removed.
- 1:11 PM Changeset in webkit [44057] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Only account for overhang for multi-character strings.
https://bugs.webkit.org/show_bug.cgi?id=25961
- 1:03 PM Changeset in webkit [44056] by
-
- 3 edits in trunk/WebCore
wx build fix. Switch to CURL cookies so we can benefit from API updates.
- 12:41 PM Changeset in webkit [44055] by
-
- 1 edit in trunk/ChangeLog
Fixing changelog message
- 12:40 PM Changeset in webkit [44054] by
-
- 2 edits in trunk
2009-05-22 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Gustavo Noronha.
Make Gtk build not bail out if gtk-doc-tools is not installed.
Warning message dumped instead.
- autogen.sh:
- 12:07 PM Changeset in webkit [44053] by
-
- 3 edits in trunk
2009-05-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Add big warnings about the glib unicode backend being slow and
incomplete, since it is a work in progress.
- autotools/webkit.m4:
- configure.ac:
- 12:06 PM Changeset in webkit [44052] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=24818
[GTK] http auth dialog pops up twice after a cancelled atempt
Workaround libsoup bug
http://bugzilla.gnome.org/show_bug.cgi?id=583462, which made
libsoup emit the 'authenticate' signal more often than it was
expected.
We'll be able to remove this when we depend on libsoup > 2.26.2.
- webkit/webkitsoupauthdialog.c: (session_authenticate):
- 11:39 AM Changeset in webkit [44051] by
-
- 8 edits in trunk/WebCore
2009-05-22 Peter Kasting <pkasting@google.com>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25709 part one
Indent contents of namespaces in header files, to comply with the
style guide. No functional change.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::bytes): (WebCore::RGBA32Buffer::rect): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::status): (WebCore::RGBA32Buffer::duration): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setRect): (WebCore::RGBA32Buffer::ensureHeight): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDuration): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setRGBA): (WebCore::ImageDecoder::m_failed): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::ImageDecoder::setData): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::frameCount): (WebCore::ImageDecoder::repetitionCount): (WebCore::ImageDecoder::supportsAlpha): (WebCore::ImageDecoder::failed): (WebCore::ImageDecoder::setFailed): (WebCore::ImageDecoder::clearFrameBufferCache):
- platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::filenameExtension):
- platform/image-decoders/gif/GIFImageDecoder.h: (WebCore::GIFImageDecoder::filenameExtension): (WebCore::GIFImageDecoder::frameDurationAtIndex): (WebCore::GIFImageDecoder::):
- platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::filenameExtension):
- platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::filenameExtension): (WebCore::JPEGImageDecoder::supportsAlpha): (WebCore::JPEGImageDecoder::reader): (WebCore::JPEGImageDecoder::setSize):
- platform/image-decoders/png/PNGImageDecoder.h: (WebCore::PNGImageDecoder::filenameExtension): (WebCore::PNGImageDecoder::reader): (WebCore::PNGImageDecoder::decodingFailed):
- platform/image-decoders/xbm/XBMImageDecoder.h: (WebCore::XBMImageDecoder::filenameExtension):
- 11:06 AM Changeset in webkit [44050] by
-
- 14 edits4 adds in trunk
WebCore
2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib
Minor changes that allow building a hybrid version of WebKit
that has WTF Unicode backend based on GLib functions while
text codecs and TextBreakIterator remain based on ICU.
Fixed some includes that were assuming a WTF ICU backend and
introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
macro.
- platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): (WebCore::ThreadGlobalData::~ThreadGlobalData):
- platform/ThreadGlobalData.h:
- platform/text/TextBoundariesICU.cpp:
- platform/text/TextCodecICU.h:
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib
Original patch by Jürg Billeter and Naiem Shaik.
Implementing WTF Unicode functionality based on GLib.
- GNUmakefile.am:
- wtf/unicode/Unicode.h:
- wtf/unicode/glib: Added.
- wtf/unicode/glib/UnicodeGLib.cpp: Added. (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::direction): (WTF::Unicode::umemcasecmp):
- wtf/unicode/glib/UnicodeGLib.h: Added. (WTF::Unicode::): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::isArabicChar): (WTF::Unicode::isFormatChar): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::mirroredChar): (WTF::Unicode::category): (WTF::Unicode::isLower): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType):
- wtf/unicode/glib/UnicodeMacrosFromICU.h: Added.
- 9:59 AM Changeset in webkit [44049] by
-
- 1 edit in trunk/WebKit/win/WebMutableURLRequest.cpp
Unreviewed build fix.
- 9:45 AM Changeset in webkit [44048] by
-
- 16 edits in trunk
WebCore:
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Remove the policyBaseURL parameter from setCookie. This parameter is
redundant with the document parameter.
- WebCore.base.exp:
- WebCore.order:
- dom/Document.cpp: (WebCore::Document::setCookie):
- platform/CookieJar.h:
- platform/mac/CookieJar.mm: (WebCore::setCookies):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::firstPartyForCookies): (WebCore::ResourceRequestBase::setFirstPartyForCookies):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies):
- platform/network/curl/CookieJarCurl.cpp: (WebCore::setCookies):
- platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::setCookies):
- platform/network/win/CookieJarWin.cpp: (WebCore::setCookies):
- platform/qt/CookieJarQt.cpp: (WebCore::setCookies):
WebKit/mac:
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Remove the policyBaseURL parameter from setCookie. This parameter is
redudant with the document parameter.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::setCookies):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setVariable:forURL:value:length:]):
- 9:44 AM Changeset in webkit [44047] by
-
- 14 edits in trunk/WebCore
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Rename policyBaseURL and mainDocumentURL to firstPartyForCookies. The
previous names were confusing and inaccurate.
- WebCore.order:
- dom/Document.cpp: (WebCore::Document::setCookie):
- dom/Document.h: (WebCore::Document::firstPartyForCookies): (WebCore::Document::setFirstPartyForCookies):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::updateFirstPartyForCookies): (WebCore::FrameLoader::setFirstPartyForCookies): (WebCore::FrameLoader::open): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously):
- loader/FrameLoader.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest):
- platform/CookieJar.h:
- platform/mac/CookieJar.mm: (WebCore::setCookies):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): (WebCore::ResourceRequestBase::firstPartyForCookies): (WebCore::ResourceRequestBase::setFirstPartyForCookies): (WebCore::equalIgnoringHeaderFields):
- platform/network/ResourceRequestBase.h:
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies):
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):
- 9:08 AM Changeset in webkit [44046] by
-
- 2 edits in trunk/WebCore
Fix the call to editingCancelled to be this._editingCancelled, since
editingCancelled doesn't exist and throws an exception.
Reviewed by Timothy Hatcher.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
- 8:33 AM Changeset in webkit [44045] by
-
- 2 edits in trunk/WebKitTools
2009-05-22 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Simon Hausmann.
Fixed --makeargs usage in Qt build.
- 8:00 AM Changeset in webkit [44044] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25928
Several errors detected by cppcheck
Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
should take a look at other reports.
- css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there are billions of those.
- 7:26 AM Changeset in webkit [44043] by
-
- 2 edits in trunk/WebKitTools
2009-05-22 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Correcting error message on missing WEBKIT_TESTFONTS
environment varible in Qt-port.
- 7:26 AM Changeset in webkit [44042] by
-
- 2 edits in trunk/LayoutTests
2009-05-22 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Skip tests depending on platform dependent results.
- 6:24 AM Changeset in webkit [44041] by
-
- 7 edits in trunk
2009-05-22 Shinichiro Hamaji <hamaji@google.com>
Reviewed by Oliver Hunt.
Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::strokeRect):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
- 6:12 AM Changeset in webkit [44040] by
-
- 3 edits1 add in trunk/WebKit/qt
2009-05-21 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Additional test for resource load (CSS file) for QWebFrame.
- tests/qwebframe/qwebframe.qrc:
- tests/qwebframe/style.css: Added.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:03 AM QtWebKitContrib edited by
- (diff)
- 2:10 AM QtWebKitContrib edited by
- (diff)
- 1:37 AM Changeset in webkit [44039] by
-
- 3 edits in trunk/WebCore
2009-05-22 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Revert the whole thing, since we can't figure out a way to make it
work in all platforms.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
- 1:36 AM Changeset in webkit [44038] by
-
- 3 edits in trunk/WebKit/qt
2009-05-22 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt build fix.
Provide dummy implementation of pure virtual EditorClient method.
- 1:20 AM Changeset in webkit [44037] by
-
- 2 edits in trunk/WebCore
2009-05-22 Xan Lopez <xlopez@igalia.com>
Try to fix Windows build.
Apparently it can't tell if '1.0f' is float or double, so cast to
float.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- 1:11 AM Changeset in webkit [44036] by
-
- 3 edits in trunk/WebCore
2009-05-22 Xan Lopez <xlopez@igalia.com>
Try to fix breakage from the previous patch.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
- 12:28 AM Changeset in webkit [44035] by
-
- 3 edits in trunk/WebCore
2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=25805
In debug build, mingw win32 build has problems with powf
Change C-style calls to powf and sqrtf to C++-style calls to
overloaded pow and sqrt. This solves also a problem with mingw
compiler during the debug build.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
May 21, 2009:
- 11:20 PM Changeset in webkit [44034] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-21 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Add MacroAssemblerCodeRef.h to file list.
- GNUmakefile.am:
- 9:44 PM Changeset in webkit [44033] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r44031.
- 9:44 PM Changeset in webkit [44032] by
-
- 1 edit in branches/WWDC-2009-branch/WebCore/page/DragController.cpp
Build fix.
- 8:57 PM Changeset in webkit [44031] by
-
- 2 edits in trunk/WebCore
2009-05-21 Stephanie Lewis <Stephanie Lewis>
Reviewed by Mark Rowe.
<rdar://problem/6913680> Update image caching options.
Disable extra ImageIO cache because we already handle caching decoded image data.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::imageSourceOptions):
- 7:34 PM Changeset in webkit [44030] by
-
- 17 edits1 add in trunk/JavaScriptCore
2009-05-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Addition of MacroAssemblerCodeRef.h rubber stamped by Geoff Garen.
Refactor JIT code-handle objects. The representation of generated code is currently
a bit of a mess. We have a class JITCode which wraps the pointer to a block of
generated code, but this object does not reference the executable pool meaning that
external events (the pool being derefed) could make the pointer become invalid.
To overcome this both the JIT and Yarr implement further (and similar) objects to
wrap the code pointer with a RefPtr to the pool. To add to the mire, as well as the
CodeBlock containing a handle onto the code the FunctionBodyNode also contains a
copy of the code pointer which is used almost (but not entirely) uniquely to access
the JIT code for a function.
Rationalization of all this:
- Add a new type 'MacroAssembler::CodeRef' as a handle for a block of JIT generated code.
- Change the JIT & Yarr to internally handle code using CodeRefs.
- Move the CodeRef (formerly anow defunct JITCodeRef) from CodeBlock to its owner node.
- Remove the (now) redundant code pointer from FunctionBodyNode.
While tidying this up I've made the PatchBuffer return code in new allocations using a CodeRef,
and have enforced an interface that the PatchBuffer will always be used, and 'finalizeCode()' or
'finalizeCodeAddendum()' will always be called exactly once on the PatchBuffer to complete code generation.
This gives us a potentially useful hook ('PatchBuffer::performFinalization()') at the end of generation,
which may have a number of uses. It may be helpful should we wish to switch our generation
model to allow RW/RX exclusive memory, and it may be useful on non-cache-coherent platforms to
give us an oportunity to cache flush as necessary.
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::CodeRef::CodeRef): (JSC::AbstractMacroAssembler::CodeRef::trampolineAt): (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive): (JSC::AbstractMacroAssembler::PatchBuffer::patch): (JSC::AbstractMacroAssembler::PatchBuffer::complete): (JSC::AbstractMacroAssembler::PatchBuffer::finalize): (JSC::AbstractMacroAssembler::PatchBuffer::entry):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::setJITCode):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex): (JSC::CodeBlock::executablePool):
- interpreter/CallFrameClosure.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall):
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::linkCall):
- jit/JIT.h:
- jit/JITCode.h: (JSC::JITCode::JITCode): (JSC::JITCode::operator bool): (JSC::JITCode::addressForCall): (JSC::JITCode::offsetOf): (JSC::JITCode::execute): (JSC::JITCode::size): (JSC::JITCode::executablePool): (JSC::JITCode::HostFunction):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall):
- parser/Nodes.cpp: (JSC::ProgramNode::generateJITCode): (JSC::EvalNode::generateJITCode): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::createNativeThunk): (JSC::FunctionBodyNode::generateJITCode):
- parser/Nodes.h: (JSC::ScopeNode::generatedJITCode): (JSC::ScopeNode::getExecutablePool): (JSC::ScopeNode::setJITCode): (JSC::ProgramNode::jitCode): (JSC::EvalNode::jitCode): (JSC::FunctionBodyNode::jitCode):
- runtime/RegExp.cpp: (JSC::RegExp::match):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile): (JSC::Yarr::jitCompileRegex): (JSC::Yarr::executeRegex):
- yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::pcreFallback): (JSC::Yarr::RegexCodeBlock::setFallback): (JSC::Yarr::RegexCodeBlock::operator bool): (JSC::Yarr::RegexCodeBlock::set): (JSC::Yarr::RegexCodeBlock::execute):
- 6:55 PM Changeset in webkit [44029] by
-
- 5 edits1 add in trunk/WebCore
2009-05-21 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
Bug 25903: Create a default UI theme for media controls in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=25903
Implement a default UI for chromium. Add a style sheet for Chromium
media controls with good defaults and implemented basic draw functions
for play/pause & mute buttons.
- css/mediaControlsChromium.css: Added.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export our custom media controls style sheet. (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint buttons respecting chromium media controls color scheme. (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic specific to play/pause button. (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint specific to mute button.
- rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export our custom media controls style sheet. (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint buttons respecting chromium media controls color scheme. (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic specific to play/pause button. (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific to mute button. (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate header changes.
- rendering/RenderThemeChromiumWin.h:
- 6:48 PM Changeset in webkit [44028] by
-
- 4 adds in branches/WWDC-2009-branch/LayoutTests/http/tests
Merge r44027.
- 6:46 PM Changeset in webkit [44027] by
-
- 4 adds in trunk/LayoutTests/http/tests
Checked in layout tests I accidentally left out of my last check-in.
- 6:39 PM Changeset in webkit [44026] by
-
- 4 edits3 adds in branches/WWDC-2009-branch
Merge r44016.
- 6:39 PM Changeset in webkit [44025] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r44011.
- 6:39 PM Changeset in webkit [44024] by
-
- 3 edits in branches/WWDC-2009-branch
Merge r44010.
- 6:38 PM Changeset in webkit [44023] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r43993.
- 6:38 PM Changeset in webkit [44022] by
-
- 2 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r43976.
- 6:38 PM Changeset in webkit [44021] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43970.
- 6:35 PM Changeset in webkit [44020] by
-
- 3 edits in trunk/WebKitTools
2009-05-21 Eric Seidel <eric@webkit.org>
Rubber-stamped by Antti Koivisto.
Make it possible to write js-only http tests by exposing a /js-test-resources alias.
https://bugs.webkit.org/show_bug.cgi?id=25915
Second attempt at landing, now using -c instead of -C to make sure
that mod_alias is loaded on Apache 1.x instances before using Alias.
- Scripts/run-webkit-httpd:
- Scripts/run-webkit-tests:
- 6:33 PM Changeset in webkit [44019] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
2009-05-21 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Implement op_negate inline fast cases.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::neg32):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::negl_m): (JSC::X86Assembler::xorpd_rr):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emitSlow_op_negate):
- 6:10 PM Changeset in webkit [44018] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
When stripping the query from a file:// URL, do not leave a trailing question mark.
https://bugs.webkit.org/show_bug.cgi?id=25940
- 5:57 PM Changeset in webkit [44017] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Notify ImageObserver::didDraw to help the cache purge alive resources.
- 5:28 PM Changeset in webkit [44016] by
-
- 4 edits3 adds in trunk
<rdar://problem/6910264> REGRESSION: Cached DOM global object property access fails in browser (25921)
<https://bugs.webkit.org/show_bug.cgi?id=25921>
Reviewed by Maciej Stachowiak.
When caching properties on the global object we need to ensure that we're
not attempting to cache through a shell object.
- 5:15 PM Changeset in webkit [44015] by
-
- 2 edits in trunk/WebCore
2009-05-21 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
Flesh out font fallback for Chromium's Skia port.
getLastResortFallbackFont should fall back on well-known fonts.
https://bugs.webkit.org/show_bug.cgi?id=25860
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getLastResortFallbackFont): try known font names.
- 5:09 PM Changeset in webkit [44014] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- 4:36 PM Changeset in webkit [44013] by
-
- 1 edit1 delete in branches/WWDC-2009-branch/LayoutTests
Merge r43891.
- 4:36 PM Changeset in webkit [44012] by
-
- 2 edits1 add1 delete in branches/WWDC-2009-branch
Merge r43880.
- 4:32 PM Changeset in webkit [44011] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
- speculative fix for <rdar://problem/6890716> crash at FontCache::purgeInactiveFontData + 199
- platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Deleting a SimpleFontData can cause releaseFontData() to be called, which modifies gInactiveFontData. Therefore, avoid deleting SimpleFontData instances while iterating over gInactiveFontData and delete them afterwards.
- 4:26 PM Changeset in webkit [44010] by
-
- 3 edits in trunk
WebCore:
2009-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
Incorrect URL returned to the DOM while the user drags a file
- page/DragController.cpp: (WebCore::DragController::dragExited): (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL, since that only looks at the text of the document's URL. Do base our decision on the securityOrigin(), which knows more about the document's actual origin.
LayoutTests:
2009-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Tests for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
Incorrect URL returned to the DOM while the user drags a file
- http/tests/local/drag-over-remote-content-expected.txt: Added.
- http/tests/local/drag-over-remote-content.html: Added.
- http/tests/security/drag-over-remote-content-iframe-expected.txt: Added.
- http/tests/security/drag-over-remote-content-iframe.html: Added.
- 4:23 PM Changeset in webkit [44009] by
-
- 1 edit in trunk/WebCore/ChangeLog
Correct change log
- 4:23 PM Changeset in webkit [44008] by
-
- 3 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43973.
- 4:23 PM Changeset in webkit [44007] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43969.
- 4:22 PM Changeset in webkit [44006] by
-
- 12 edits2 adds in branches/WWDC-2009-branch
Merge r43964.
- 4:22 PM Changeset in webkit [44005] by
-
- 6 edits in branches/WWDC-2009-branch
Merge r43951.
- 4:22 PM Changeset in webkit [44004] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r43942.
- 4:22 PM Changeset in webkit [44003] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43937.
- 4:22 PM Changeset in webkit [44002] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43931.
- 4:22 PM Changeset in webkit [44001] by
-
- 3 edits in branches/WWDC-2009-branch/WebCore
Merge r43949.
- 4:22 PM Changeset in webkit [44000] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Mark Rowe.
- fix https://bugs.webkit.org/show_bug.cgi?id=25947 Assertion failure in FrameLoader::transitionToCommitted on launch in Safari with r43985
Rolled out r43985.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
- 4:22 PM Changeset in webkit [43999] by
-
- 13 edits2 adds in branches/WWDC-2009-branch
Merge r43929.
- 4:22 PM Changeset in webkit [43998] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43912.
- 4:22 PM Changeset in webkit [43997] by
-
- 4 edits in branches/WWDC-2009-branch/WebCore
Merge r43878.
- 4:22 PM Changeset in webkit [43996] by
-
- 3 edits2 adds in branches/WWDC-2009-branch
Merge r43876.
- 4:22 PM Changeset in webkit [43995] by
-
- 5 edits in branches/WWDC-2009-branch
Merge r43869.
- 4:21 PM Changeset in webkit [43994] by
-
- 3 edits in branches/WWDC-2009-branch/WebCore
Merge r43866.
- 4:00 PM Changeset in webkit [43993] by
-
- 2 edits in trunk/WebCore
2009-05-21 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson and Mark Rowe.
Fix for <rdar://problem/6901522>
REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari
If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
the MIME type to be text/html.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
- 3:56 PM Changeset in webkit [43992] by
-
- 2 edits in trunk/WebCore
Blind windows fix after last commit.
- 3:42 PM Changeset in webkit [43991] by
-
- 2 edits in trunk/LayoutTests
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Fixing test to actually use the correct names for the frames.
- http/tests/mime/accept-all-text-types.html:
- 3:29 PM Changeset in webkit [43990] by
-
- 4 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Use an environment variable to control which logs are on and off.
Also, make a generic function for translating channel name to its log.
https://bugs.webkit.org/show_bug.cgi?id=25936
- 3:15 PM Changeset in webkit [43989] by
-
- 2 edits in trunk/LayoutTests
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disable 2 more tests that sometimes fail.
- platform/gtk/Skipped:
- 3:12 PM Changeset in webkit [43988] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-21 Cameron Zwarich <zwarich@apple.com>
Reviewed by Mark Rowe.
Bug 25945: Add support for MADV_FREE to TCMalloc
<https://bugs.webkit.org/show_bug.cgi?id=25945>
<rdar://problem/6910754>
Add support for MADV_FREE to TCMalloc_SystemRelease for platforms that
don't also support MADV_FREE_REUSE. The code is identical to the MADV_DONTNEED
case except for the advice passed to madvise(), so combining the two cases
makes the most sense.
- wtf/Platform.h: Only define HAVE_MADV_FREE when not building on Tiger or Leopard, because while it is defined on these platforms it actually does nothing.
- wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): use MADV_FREE if it is available; otherwise use MADV_DONTNEED.
- 3:07 PM Changeset in webkit [43987] by
-
- 3 edits in trunk/WebKit/wx
wx build fix after method added to EditorClient.
- 2:54 PM Changeset in webkit [43986] by
-
- 1 edit1 add in trunk/LayoutTests
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Adding file I forgot to add to last commit.
- http/tests/mime/resources/accept-all-text-types.cgi: Added.
- 2:47 PM Changeset in webkit [43985] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Darin Adler.
Test that WebKit accepts any text/* type.
- http/tests/mime/accept-all-text-types-expected.txt: Added.
- http/tests/mime/accept-all-text-types.html: Added.
- 2:36 PM Changeset in webkit [43984] by
-
- 2 edits in trunk/WebKit/mac
2009-05-21 Darin Fisher <darin@chromium.org>
Fix-up coding style.
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::getAutoCorrectSuggestionForMisspelledWord):
- 2:36 PM Changeset in webkit [43983] by
-
- 2 edits in trunk/WebKit/win
2009-05-21 Darin Fisher <darin@chromium.org>
Fix-up coding style.
- WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::getAutoCorrectSuggestionForMisspelledWord):
- 2:35 PM Changeset in webkit [43982] by
-
- 3 edits in trunk/WebKit/gtk
2009-05-21 Darin Fisher <darin@chromium.org>
Fix build bustage.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::getAutoCorrectSuggestionForMisspelledWord): Add stub for method.
- WebCoreSupport/EditorClientGtk.h:
- 2:19 PM Changeset in webkit [43981] by
-
- 2 edits in trunk/WebCore
2009-05-21 David Levin <levin@chromium.org>
Reviewed by Darin Fisher.
Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
https://bugs.webkit.org/show_bug.cgi?id=25946
A very simple implementation to keep it working. A bug has been filed in the chromium db
(http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
complete.
- platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
- 2:02 PM Changeset in webkit [43980] by
-
- 11 edits in trunk
2009-05-20 Siddhartha Chattopadhyaya <sidchat@google.com>
Reviewed by Justin Garcia.
Add automatic spell correction support in WebKit
- editing/Editor.cpp: (WebCore::findFirstMisspellingInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsInRange): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markMisspellingsAndBadGrammar):
- editing/Editor.h:
- loader/EmptyClients.h: (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
- page/EditorClient.h:
- 1:57 PM Changeset in webkit [43979] by
-
- 2 edits in trunk/WebCore
2009-05-21 Christian Dywan <christian@twotoasts.de>
Reviewed by Darin Adler.
Text files which have sub MIME types are treated as not displayable
http://bugs.webkit.org/show_bug.cgi?id=24903
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any MIME type beginning with "text/" as supported and remove all "text/" types from the list.
- 1:54 PM Changeset in webkit [43978] by
-
- 4 edits in trunk
LayoutTests
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Disable failing HTTP tests now that we are enabling HTTP on the
bot.
- platform/gtk/Skipped:
WebKitTools
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Default to running HTTP tests for GTK+.
- Scripts/run-webkit-tests:
- 1:30 PM Changeset in webkit [43977] by
-
- 3 edits in trunk/WebKitTools
2009-05-21 Darin Adler <Darin Adler>
Rolled the httpd changes out, since many machines (including the bots)
have an older version of Apache that does not support the Alias command.
Or maybe it's something else, but the bots are failing.
- Scripts/run-webkit-httpd: Rolled back.
- Scripts/run-webkit-tests: Ditto.
- 12:57 PM Changeset in webkit [43976] by
-
- 2 edits in trunk/JavaScriptCore
Fix <https://bugs.webkit.org/show_bug.cgi?id=25917> / <rdar://problem/6910066>.
Bug 25917: REGRESSION (r43559?): Javascript debugger crashes when pausing page
Reviewed by Oliver Hunt.
The debugger currently retrieves the arguments object from an activation rather than pulling
it from a call frame. This is unreliable to due to the recent optimization to lazily create
the arguments object. In the long-term it should stop doing that (<rdar://problem/6911886>),
but for now we force eager creation of the arguments object when debugging.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- 12:25 PM Changeset in webkit [43975] by
-
- 3 edits in trunk/WebKitTools
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Geoffrey Garen.
Make it possible to write js-only http tests by exposing a /js-test-resources alias.
https://bugs.webkit.org/show_bug.cgi?id=25915
- Scripts/run-webkit-httpd:
- Scripts/run-webkit-tests:
- 11:51 AM Changeset in webkit [43974] by
-
- 2 edits in trunk/WebCore
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=25890
Implement Network logging channel on Mac
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setDefersLoading): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Added logging for async requests (as these are most interesting).
- 11:19 AM Changeset in webkit [43973] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
<rdar://problem/6907542> REGRESSION (r43143): Hang in RenderLineBoxList::dirtyLinesFromChangedChild
when clicking link to load Flash animation (http://www.roambi.com)
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection): Don't call -[NSApplication updateWindows] here, WebHTMLView can take care of this.
- WebView/WebHTMLView.mm: (-[WebHTMLView inputContext]): Use a precomputed boolean stored in WebHTMLViewPrivate, as calling isTextInput() is not always safe. (-[WebHTMLView textStorage]): Ditto. (-[WebHTMLView _updateSelectionForInputManager]): Update _private->exposeInputContext when selection changes, and let AppKit update its cache if necessary.
- 11:17 AM Changeset in webkit [43972] by
-
- 5 edits in trunk/WebCore
2009-05-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by David Kilzer.
<rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit
Add a static table to map from some common file extensions to their MIME types so it
is possible to detect support even when the platform mapping is incomplete. Use the
table to lookup types not found by UTI on the OSX, and when looking for a media engine
with a generic or missing type.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap. (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified MIME type in the static mapping table if the platform specific getMIMETypeForExtension doesn't find a match.
- platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension to MIME type if UTI fails.
- 9:36 AM Changeset in webkit [43971] by
-
- 3 edits in trunk/WebKitTools
2009-05-21 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Gustavo Noronha.
Added --makeargs flag to the build script.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 9:29 AM Changeset in webkit [43970] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
<rdar://problem/5579292> REGRESSION (2-3): "Default default" encoding for Korean changed
from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
- WebView/WebPreferences.mm:
(+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Update the existing fix
for the changed result of CFStringConvertEncodingToIANACharSetName().
- 9:03 AM Changeset in webkit [43969] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
<rdar://problem/6883758> REGRESSION (r43143): First character typed with input method does
not go into inline hole (seen with Chinese & Kotoeri on top Chinese website www.baidu.com)
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection): Call -[NSApplication updateWindows] to make AppKit re-fetch the input context when selection changes. Since we use SelectionController to check whether the view is editable, it is important not to re-fetch the context too early, e.g. from a focus changed notification.
- 7:05 AM Changeset in webkit [43968] by
-
- 4 edits in trunk/WebCore
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
Clean up DragController
https://bugs.webkit.org/show_bug.cgi?id=25926
I renamed m_document to m_documentUnderMouse to better document what it does
I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
long enough.
I also saw copy/paste code involving clearing the selection when moving out of
one document and into another. I moved that code into a function called
mouseMovedIntoDocument.
I also got rid of a couple needless null-checks after confirming via source
inspection they were not ever possible.
In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
It's also not possible to return a document from documentAtPoint that is not
in a frame (as such a document would not be rendered).
No functional changes, thus no tests.
- page/DragController.cpp: (WebCore::DragController::DragController): (WebCore::DragController::dragIsMove): (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::mouseMovedIntoDocument): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::DragController::concludeEditDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::placeDragCaret):
- page/DragController.h: (WebCore::DragController::documentUnderMouse):
- 5:50 AM Changeset in webkit [43967] by
-
- 5 edits in trunk
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename DragController::dragOperation() to sourceDragOperation() for clarity
Remove unused setDragOperation()
There are two times DragOperation is used. The source specifies
what drag operations it supports (in a mask) and the destination
picks a subset of those as DragOperations it supports if a drop were
to occur. I was confused when I first saw this accessor as to which
it meant. It turns out that this is only used when WebKit starts a
drag, and we keep it around so that we can provide this information
to other Mac OS X applications when they ask. I've renamed the method
for clarity so the next person in this code will be less confused.
No functional changes, thus no tests.
- page/DragController.h: (WebCore::DragController::sourceDragOperation):
- 5:34 AM Changeset in webkit [43966] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=19517
<rdar://problem/6007112> DOM modification of textArea causes Access Violation (NULL pointer?)
This no longer happens with ToT, just adding a test.
- fast/parser/head-parsing-19517-expected.txt: Added.
- fast/parser/head-parsing-19517.html: Added.
- 2:30 AM Changeset in webkit [43965] by
-
- 2 edits in trunk/WebKitLibraries
Rubber-stamped by Mark Rowe.
- correct a copyright header accidently reverted in r43964
- WebKitSystemInterface.h:
- 2:16 AM Changeset in webkit [43964] by
-
- 12 edits2 adds in trunk
WebCore:
Reviewed by Anders Carlsson.
- WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
A bug in old versions of Core Graphics causes memory corruption to occur
when clipping under certain conditions. Make the clipping functions
fail silently under those conditions.
Test: fast/block/float/selection-gap-clip-out-tiger-crash.html
- WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that, on Tiger, bails out if wkCGContextIsSafeToClip() returns false. (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip. (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect. (WebCore::GraphicsContext::fillPath): Changed to call the safe variants of CGContextClip, CGContextEOClip and CGContextClipToRect. (WebCore::GraphicsContext::strokePath): Ditto. (WebCore::GraphicsContext::fillRect): Ditto. (WebCore::GraphicsContext::clip): Ditto. (WebCore::GraphicsContext::clipOut): Ditto. (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto. (WebCore::GraphicsContext::clipPath): Ditto. (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto. (WebCore::GraphicsContext::strokeRect): Ditto.
- platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
- platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.
WebKit/mac:
Reviewed by Anders Carlsson.
- WebKit part of <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Added CGContextIsSafeToClip.
WebKitLibraries:
Reviewed by Anders Carlsson.
- WebKitSystemInterface part of <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceTiger.a:
LayoutTests:
Reviewed by Anders Carlsson.
- test for <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
- fast/block/float/selection-gap-clip-out-tiger-crash-expected.txt: Added.
- fast/block/float/selection-gap-clip-out-tiger-crash.html: Added.
- 2:08 AM Changeset in webkit [43963] by
-
- 2 edits in trunk/WebCore
2009-05-21 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
https://bugs.webkit.org/show_bug.cgi?id=25910
WebkitGTK r43960 cannot compile
Do not include local copy of guriescape header, which was
removed. We now use the copy in glib.
- platform/gtk/FileSystemGtk.cpp:
- 1:41 AM Changeset in webkit [43962] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-21 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Bug 25912: Harden NumberPrototype.cpp by removing use of strcpy()
<https://bugs.webkit.org/show_bug.cgi?id=25912>
This causes no change on SunSpider.
- runtime/NumberPrototype.cpp: (JSC::integerPartNoExp): replace strcpy() with memcpy(), ASSERT that the temporary buffer has sufficient space to store the result, and move the explicit null-termination closer to the memcpy() for easier visual inspection of the code. (JSC::fractionalPartToString): replace strcpy() with memcpy(), and ASSERT that the temporary buffer has sufficient space to store the result. There is no explicit null-termination because this is done by the caller. The same is already true for exponentialPartToString(). (JSC::numberProtoFuncToExponential): replace strcpy() with memcpy(), explicitly null-terminate the result, and ASSERT that the temporary buffer has sufficient space to store the result.
- 1:02 AM Changeset in webkit [43961] by
-
- 3 edits in trunk/LayoutTests
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix file-input-files-access which was passing for the wrong reasons.
The log was pushing the drop target off screen and the drops were failing!
- editing/pasteboard/file-input-files-access-expected.txt:
- editing/pasteboard/resources/file-input-files-access.js: (testOrderedDraggingWithDirectory): (runTest):
May 20, 2009:
- 10:52 PM Changeset in webkit [43960] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Cleanup the JSGlobalData when exiting early with the usage statement in jsc.
- jsc.cpp: (printUsageStatement): (parseArguments): (jscmain):
- 10:46 PM Changeset in webkit [43959] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Update the patchOffsetGetByIdSlowCaseCall constant for the
case that OPCODE_SAMPLING is enabled.
- jit/JIT.h:
- 9:06 PM Changeset in webkit [43958] by
-
- 2 edits in trunk/WebCore
2009-05-20 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
It turns out the CurrentContext wasn't currect either because it gave
us the frame for the write() function itself. We actually want the
*calling* context.
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 7:52 PM Changeset in webkit [43957] by
-
- 2 edits in trunk/LayoutTests
2009-05-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Skipping a new test.
- platform/gtk/Skipped:
- 7:45 PM Changeset in webkit [43956] by
-
- 2 edits in trunk/LayoutTests
2009-05-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Skipping test that fails intermitently.
- platform/gtk/Skipped:
- 7:43 PM Changeset in webkit [43955] by
-
- 4 edits1 add in trunk/WebCore
[GTK] Implement Image::loadPlatformResource.
Install the four resources we are using. For the icons
where an icon name is specified by freedeskop.org try to
map the WebCore name to that name and fallback to the
internal icon. For everything else use the internal icon
name. Remove the temporary link stub as this is not
required any more.
- 7:42 PM Changeset in webkit [43954] by
-
- 2 edits in trunk/WebCore
[GTK] Gtk+ wants to have a themable urlIcon too.
- 7:41 PM Changeset in webkit [43953] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-05-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rubber-stamped by Mark Rowe.
Add GTK+-specific results for canvas-composite-alpha. This test
has 'failing' cases that pass on GTK+/cairo.
- platform/gtk/fast/canvas/canvas-composite-alpha-expected.txt: Added.
- 7:28 PM Changeset in webkit [43952] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for inline subtraction of doubles.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlowSub32InPlaceLeft): (JSC::JIT::emitBinaryDoubleOp):
- 7:22 PM Changeset in webkit [43951] by
-
- 6 edits in trunk
2009-05-20 Stephanie Lewis <Stephanie Lewis>
Update the order files. <rdar://problem/6881750> Generate new order files.
- JavaScriptCore.order:
- WebCore.order:
- WebKit.order:
- 7:19 PM Changeset in webkit [43950] by
-
- 9 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Added support for inline division.
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::divsd_rr): (JSC::X86Assembler::divsd_mr):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitBinaryOp):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div): (JSC::JIT::emitSlow_op_div):
- 7:14 PM Changeset in webkit [43949] by
-
- 3 edits in trunk/WebCore
Fix some assertion failures in plug-in tests on the Windows debug build bot.
Reviewed by Gavin Barraclough.
- plugins/PluginStream.cpp:
(WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.
- plugins/PluginView.cpp:
(WebCore::scriptStringIfJavaScriptURL): Ditto.
- 6:31 PM Changeset in webkit [43948] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for inline addition of doubles.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32InPlace): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
- 5:16 PM Changeset in webkit [43947] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Factored inline double operations into a helper function, so that we
can reuse this code for other math operations.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame):
- 4:58 PM Changeset in webkit [43946] by
-
- 4 edits in trunk
WebCore:
2009-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
More protocolInHTTPFamily() cleanup.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
WebKit/win:
2009-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
More protocolInHTTPFamily() cleanup.
- WebHistory.cpp: (WebHistory::visitedURL):
- 4:57 PM Changeset in webkit [43945] by
-
- 5 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for inline multiplication of doubles.
- assembler/X86Assembler.h: (JSC::X86Assembler::cvtsi2sd_mr): New function, useful for loading an int32 into a double register.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): Filled out these cases for double arithmetic.
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::addressFor): New function, useful for addressing a JSValue's full 64bits as a double.
- 4:57 PM Changeset in webkit [43944] by
-
- 3 edits in trunk/WebKitSite
Prevent search engines from getting creative in their descriptions of webkit.org content.
Rubber-stamped by Eric Seidel.
- blog/wp-content/themes/webkit/header.php:
- header.inc:
- 4:37 PM Changeset in webkit [43943] by
-
- 2 edits in trunk/WebCore
2009-05-21 Christian Dywan <christian@twotoasts.de>
Reviewed by Jan Alonzo.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl): Always use Glib Base64 decoding.
- 4:36 PM Changeset in webkit [43942] by
-
- 2 edits in trunk/WebCore
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for <rdar://problem/6905475>
Office 2008: Entourage: Crash when you switch to "My Day" view
The host function callback callObjCFallbackObject was not annotated
with JSC_HOST_CALL which meant that when it was called by the JIT, which
expects the JSC_HOST_CALL calling convention, the arguments are not in the
expected places.
- bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL annotation on callObjCFallbackObject.
- 4:32 PM Changeset in webkit [43941] by
-
- 2 edits in trunk/WebCore
2009-05-20 David Levin <levin@chromium.org>
Not Reviewed, build fix.
Need to disable this assert while the chormium code is fixed for it.
- platform/KURLGoogle.cpp: (WebCore::KURL::protocolIs):
- 4:13 PM Changeset in webkit [43940] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Added bugs.webkit.org URL
- 4:09 PM Changeset in webkit [43939] by
-
- 2 edits3 adds in trunk/LayoutTests
Test for <rdar://problem/5666078> Cookie parsing terminates at the first semicolon, ignoring quotes (16699)
Reviewed by Brady Eidson.
- http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
- http/tests/cookies/double-quoted-value-with-semi-colon.html: Added.
- http/tests/cookies/resources/double-quoted-value-with-semi-colon.js: Added.
- platform/mac-tiger/Skipped: Added double-quoted-value-with-semi-colon.html since CFNetwork on Tiger stops parsing cookie values when it sees a semi-colon, even inside double quotes.
- 4:01 PM Changeset in webkit [43938] by
-
- 2 edits in trunk/WebCore
2009-05-20 David Levin <levin@chromium.org>
Not Reviewed, build fix.
Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
http://trac.webkit.org/changeset/43929. Fix assert placement.
- platform/KURLGoogle.cpp: (WebCore::KURL::protocolIs): (WebCore::protocolIs):
- 3:35 PM Changeset in webkit [43937] by
-
- 2 edits in trunk/WebKit/mac
2009-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6905336> REGRESSION: "Clear History" does not save empty history to disk
- History/WebHistory.mm: (-[WebHistoryPrivate data]): If there are no entries, return an empty NSData instead of nil.
- 3:26 PM Changeset in webkit [43936] by
-
- 2 edits in trunk/WebCore
2009-05-20 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov.
Upstream V8 bindings for V8DomWindow.
https://bugs.webkit.org/show_bug.cgi?id=25869
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp. (WebCore::isAscii): Moved from v8_custom.cpp. (WebCore::convertBase64): Moved from v8_custom.cpp. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp. (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp. (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
- 3:18 PM Changeset in webkit [43935] by
-
- 2 edits in trunk/WebCore
2009-05-21 Christian Dywan <christian@twotoasts.de>
Rubberstamped by Gustavo Noronha.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.
- 3:04 PM Changeset in webkit [43934] by
-
- 2 edits2 deletes in trunk/WebCore
2009-05-20 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
- GNUmakefile.am:
- platform/gtk/guriescape.c:
- platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and g_uri_unescape_string now that we require Glib 2.16.
- 1:55 PM Changeset in webkit [43933] by
-
- 2 edits in trunk/WebCore
2009-05-20 David Levin <levin@chromium.org>
Not Reviewed, build fix.
Change KURLGoogle.cpp to mirror changes done in
http://trac.webkit.org/changeset/43929.
- platform/KURLGoogle.cpp: (WebCore::protocolIsJavaScript): (WebCore::protocolIs):
- 12:53 PM Changeset in webkit [43932] by
-
- 5 edits in trunk/WebCore
2009-05-20 Brady Eidson <beidson@apple.com>
Rubberstamped by Sam Weinig
At all call sites that check if a KURL has either the http or https protocol,
use the KURL::protocolInHTTPFamily() accessor, instead.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::open):
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
- loader/loader.cpp: (WebCore::Loader::load):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
- 12:39 PM Changeset in webkit [43931] by
-
- 2 edits in trunk/WebKit/mac
2009-05-20 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Kevin Decker.
WebKit side of <rdar://problem/6895072>
Pass the localization as a launch property.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
- 12:36 PM Changeset in webkit [43930] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog typo
- 12:31 PM Changeset in webkit [43929] by
-
- 13 edits2 adds in trunk
WebCore:
2009-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
"javascript://" be detected as invalid hierarchical URLs. When a KURL is marked as
invalid, you can no longer ask it a question such as "is your protocol javascript?"
Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
navigated to them.
URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth
being a high profile example) and actually represent valid javascript.
Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
as it functions on a String which doesn't have to pass KURLs parsing rules.
Test: fast/loader/javascript-url-hierarchical-execution.html
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Ditto. (WebCore::createWindow): Ditto. (WebCore::JSDOMWindow::open): Ditto.
- bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Ditto.
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Ditto.
- bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
- bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): Ditto. (WebCore::JSLocation::reload): Ditto.
- editing/markup.cpp: (WebCore::appendQuotedURLAttributeValue): Ditto.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Ditto. (WebCore::FrameLoader::submitForm): Ditto. (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.
- platform/KURL.cpp: (WebCore::KURL::init): Use protocolIsJavaScript(). (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.
Such checks should go through protocolIsJavaScript() instead.
(WebCore::encodeRelativeString): Use protocolIsJavaScript().
(WebCore::protocolIsJavaScript):
- platform/KURL.h:
LayoutTests:
2009-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
- fast/loader/javascript-url-hierarchical-execution-expected.txt: Added.
- fast/loader/javascript-url-hierarchical-execution.html: Added.
- 12:30 PM Changeset in webkit [43928] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 12:29 PM Changeset in webkit [43927] by
-
- 1 copy in tags/Safari-6530.11
New tag.
- 12:27 PM Changeset in webkit [43926] by
-
- 4 edits in trunk
Versioning.
- 12:21 PM Changeset in webkit [43925] by
-
- 2 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r43886.
- 12:21 PM Changeset in webkit [43924] by
-
- 3 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r43885.
- 10:35 AM Changeset in webkit [43923] by
-
- 6 edits2 adds in trunk
[plugins] PluginPackage*.cpp for Gtk+/Qt misassigned hasproperty and hasmethod
https://bugs.webkit.org/show_bug.cgi?id=24510
PluginPackageGtk.cpp and PluginPackageQt.cpp assigned _NPN_HasMethod
to hasproperty and _NPN_HasProperty to hashmethod. This commit is fixing
it. It is also adding test code to PluginObject.cpp and it will invoke
this code from a new test.
- 10:31 AM Changeset in webkit [43922] by
-
- 6 edits in trunk/WebCore
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Timothy Hatcher.
Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
and only exist on RenderText.
- dom/Range.cpp: (WebCore::Range::textRects):
- inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead of absoluteQuadsForRange since no range is being specifiec.
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderText.h:
- 10:05 AM Changeset in webkit [43921] by
-
- 2 edits in trunk/WebKit/mac
- fix the build after r43918
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::setCursor):
- 9:59 AM Changeset in webkit [43920] by
-
- 4 edits in trunk/WebCore
2009-05-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Implement AtkObject::focus-event and
AtkObject::state-changed:focused signal emission.
Adds a new handleFocusedUIElementChangedWithRenderers, only in the
GTK port, called at the same point than
handleFocusedUIElementChanged but with two parameters, the old and
the newly focused RenderObjects. We need this, since the ATK
signals require us to pass the objects involved in the focus
change as arguments.
- accessibility/AXObjectCache.h:
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- 9:23 AM Changeset in webkit [43919] by
-
- 4 edits3 adds in trunk/WebKit/qt
2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann and Holger Freyther.
[Qt] Add renderHints property to QWebView.
- Api/qwebview.cpp: (QWebViewPrivate::QWebViewPrivate): (QWebView::renderHints): (QWebView::setRenderHints): (QWebView::setRenderHint): (QWebView::paintEvent):
- Api/qwebview.h:
- tests/qwebview/qwebview.pro: Added.
- tests/qwebview/tst_qwebview.cpp: Added. (tst_QWebView::tst_QWebView): (tst_QWebView::~tst_QWebView): (tst_QWebView::init): (tst_QWebView::cleanup): (tst_QWebView::renderHints):
- tests/tests.pro:
- 9:04 AM Changeset in webkit [43918] by
-
- 15 edits in trunk
[architecture] Make ChromeClient a interface again
https://bugs.webkit.org/show_bug.cgi?id=25834
With recent additions to ChromeClient.h empty defaults were
added. This is bad for porters as these changes go unnoticed
and at runtime no notImplemented warning is logged and grepping
for notImplemented will not show anything. Change this Client
to be like the other Clients again and always have pure virtuals
(but for stuff inside #ifdef PLATFORM(MAC)).
Update the various WebKit/* implementations to compile again.
- 8:34 AM Changeset in webkit [43917] by
-
- 2 edits in trunk/WebKit/qt
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Fix a plugin bug in the WebKit code, similar to the one in WebCore.
The problem is when a non visible QtPluginWidget would show it self
in a sibling frame. The problem was due to our clipping. In Qt,
if setMask is set with an empty QRegion, no clipping will
be performed, so in that case we hide the PluginContainer
- 8:34 AM Changeset in webkit [43916] by
-
- 2 edits2 adds in trunk/WebCore
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Fix a bug where a non visible plugin would show it self in a
sibling frame. The problem was due to our clipping. In Qt,
if setMask is set with an empty QRegion, no clipping will
be performed, so in that case we hide the PluginContainer
Added manual test.
- 8:32 AM Changeset in webkit [43915] by
-
- 2 edits in trunk/WebCore
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Do not call the parent implementation (Widget::) in show() and hide()
of the PluginViewQt, as it always changes the visible state of the
platformWidget (equal to the platformPluginWidget in the Qt port),
thus ignoring the isParentVisible() test.
- 8:26 AM Changeset in webkit [43914] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Replace WREC with YARR + YARR_JIT for the Qt port. This is only
used when compiled with JIT support for now, so it is a drop-in
replacement for the WREC usage. Still including the wrec headers
as they are being referred from RegExp.h, though the contents of
that header it protected by "#if ENABLE(WREC)".
- 8:08 AM Changeset in webkit [43913] by
-
- 5 edits in trunk/WebCore
2009-05-20 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23452
Change the implementation of HTMLNoScriptElement to avoid the pain of
adding virtual function for XHTMLMP support
Includes changes suggested by Simon Fraser.
- 8:06 AM Changeset in webkit [43912] by
-
- 2 edits in trunk/WebKit/mac
2009-05-20 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
<rdar://problem/4023899> Shift-Tab skips key views in toolbar in Safari, although Tab
iterates through them properly
- WebView/WebView.mm: (-[WebView previousValidKeyView]): Work around a bug in -[NSView previousValidKeyView].
- 8:00 AM Changeset in webkit [43911] by
-
- 2 edits in trunk/WebCore
CURL backend build fix. Make sure URL is always set.
- 7:54 AM Changeset in webkit [43910] by
-
- 2 edits in trunk/WebCore
2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by George Staikos.
Fix Qt WebKit build break in Mac OS.
- platform/FileSystem.h:
- 7:51 AM Changeset in webkit [43909] by
-
- 2 edits in trunk/WebCore
2009-05-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Eric Seidel.
Enable code that was commented out waiting for a way to get a
GdkPixbuf from an image, effectively enabling copying images to
the clipboard.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
- 7:33 AM Changeset in webkit [43908] by
-
- 2 edits in trunk/WebCore
2009-05-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25414
[GTK] ROLE_PANEL should not be used for paragraphs and list items.
Implement Atk list item role for list items.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 7:33 AM Changeset in webkit [43907] by
-
- 2 edits in trunk/WebCore
2009-05-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25414
[GTK] ROLE_PANEL should not be used for paragraphs and list items.
Implement Atk paragraph role for paragraph elements.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 5:42 AM Changeset in webkit [43906] by
-
- 2 edits in trunk
2009-05-20 Eric Seidel <eric@webkit.org>
Fix bug URL in ChangeLogs in r43903.
https://bugs.webkit.org/show_bug.cgi?id=25742
- 5:37 AM Changeset in webkit [43905] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2009-05-20 Eric Seidel <eric@webkit.org>
No review, build fix only.
Add files I missed in r43903.
Takeshi's patch was right, I just failed to add the files when landing.
- platform/mac/fast/forms/search-styled-expected.checksum: Added.
- platform/mac/fast/forms/search-styled-expected.png: Added.
- 5:37 AM Changeset in webkit [43904] by
-
- 2 adds in trunk/LayoutTests/platform/mac/fast/forms
Add files I missed in r43903
- 5:33 AM Changeset in webkit [43903] by
-
- 6 edits in trunk
2009-05-20 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Eric Seidel.
Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
https://bugs.webkit.org/show_bug.cgi?id=24539
Fix RenderThemeChromiumWin::paintTextFieldInternal().
We shouldn't paint the content area of text fields when o->style() has
background image or transparent background color. paintTextFieldInternal() is
used for painting inner area of HTML option elements by Chromium.
When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
the background image rendered by RenderBoxModelObject. So, we should set
fillContentArea = false in such case.
Besides, when background-color:transparent is specified for CSS property,
o->style().backgroundColor returns black color with alpha channel == 0. But
since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
recognize alpha channel, it fills the rect with black. I made workaround to set
fillContentArea = false when alpha channel == 0 to avoid this.
And more, I'd like to fallback the color passed to ChromiumBridge to white when
o->style()->backgroundColor() is invalid.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
- 5:26 AM Changeset in webkit [43902] by
-
- 3 edits2 adds in trunk
2009-05-20 Shinichiro Hamaji <hamaji@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25417
Map CompositeCopy to Skia's kSrc_Mode composite operation.
Test: fast/canvas/canvas-composite-alpha.html
- platform/graphics/skia/SkiaUtils.cpp: (WebCore::):
- 4:38 AM Changeset in webkit [43901] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Eric Seidel.
Fix GTK debug build.
The function dumpDisjunction, compiled with debug enabled, uses
printf, which needs stdio.h to be included.
- yarr/RegexInterpreter.cpp:
- 4:30 AM Changeset in webkit [43900] by
-
- 2 edits in trunk/WebCore
2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Xan Lopez.
Remove misplaced extern "C"
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
- 4:16 AM Changeset in webkit [43899] by
-
- 2 edits in trunk/WebCore
2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] Expose password field with role of PASSWORD_TEXT
https://bugs.webkit.org/show_bug.cgi?id=25682
Check if input type is a password field and return
ATK_ROLE_PASSWORD_TEXT if it is.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
- 3:09 AM Changeset in webkit [43898] by
-
- 2 edits in trunk/WebCore
2009-05-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by George Staikos.
BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
<https://bugs.webkit.org/show_bug.cgi?id=25845>
- WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4
- 3:08 AM Changeset in webkit [43897] by
-
- 3 edits1 delete in trunk/LayoutTests
2009-05-20 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Remove dragging subtest from 43890 which used ? char
? is a reserved char on Windows. After removing both the ü and now the ? this
subtest is now useless, so I'm removing it entirely.
- editing/pasteboard/file-input-files-access-expected.txt:
- editing/pasteboard/resources/File With Spaces! For Dragging?.gif: Removed.
- editing/pasteboard/resources/file-input-files-access.js: (runTest):
- 2:58 AM Changeset in webkit [43896] by
-
- 7 edits in trunk
2009-05-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by George Staikos.
BUG 25843: [Qt] Remove qt-port build flag
<https://bugs.webkit.org/show_bug.cgi?id=25843>
- bridge/testbindings.pro:
- JavaScriptCore.pro:
- DumpRenderTree/qt/DumpRenderTree.pro:
- Scripts/webkitdirs.pm:
- 2:49 AM Changeset in webkit [43895] by
-
- 3 edits1 move in trunk/LayoutTests
2009-05-20 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Fix windows and tiger builds after r43890
Commit r43890 caused:
svn: Can't convert string from 'UTF-8' to native encoding:
svn: LayoutTests/editing/pasteboard/resources/File With Spaces! For Dra?\204?\136gging?.gif
On both the windows and tiger buildbots. According to:
http://svnbook.red-bean.com/en/1.2/svn.advanced.l10n.html
this is intentional behavior, and due to the fact that the default
LC_CTYPE for Tiger and Windows makes Subversion think the filesystems
do not support utf8.
The fix would be to execute:
export LC_CTYPE=en_US.UTF-8
On all affected machines. But since that's not going to happen,
I'm removing the utf8 chars from this filename.
This makes the drag-drop test weaker, but I see no other option.
- editing/pasteboard/resources/File With Spaces! For Dragging?.gif: Renamed from "LayoutTests/editing/pasteboard/resources/File With Spaces! For Dra\314\210gging?.gif".
- editing/pasteboard/resources/file-input-files-access.js: (moveMouseToCenterOfElement): use the unused argument (runTest): fix to use the ansii name
- 2:02 AM Changeset in webkit [43894] by
-
- 2 edits in trunk/WebCore
2009-05-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by George Staikos.
[Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
and WORKERS under the appropriate build section
- WebCore.pro:
- 1:40 AM Changeset in webkit [43893] by
-
- 2 edits in trunk/WebCore
2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Unreviewed Qt build fix, after r43892.
- platform/graphics/qt/ImageQt.cpp: included ImageObservser.h
- 1:22 AM Changeset in webkit [43892] by
-
- 2 edits in trunk/WebCore
2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=25856
[Qt] notify an image has been drawn, to help Cache purge alive decoded data.
- 12:32 AM Changeset in webkit [43891] by
-
- 1 edit1 delete in trunk/LayoutTests
2009-05-20 Darin Adler <Darin Adler>
Removed stray file left after some check-ins earlier today.
- fast/tokenizer/preload-scanner-entities.html-disabled: Removed.
- 12:32 AM Changeset in webkit [43890] by
-
- 11 edits8 adds4 deletes in trunk
2009-05-18 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
Remove layoutTestController.addFileToPasteboardOnDrag and add eventSender.beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=25852
This allows us to now test multi-file file drags in DumpRenderTree per:
https://bugs.webkit.org/show_bug.cgi?id=25862
I removed the existing tests using addFileToPasteboardOnDrag()
and replaced them with a new test (editing/pasteboard/file-input-files-access)
which covers several more drag-drop cases.
I added a DumpRenderTreeFileDraggingSource class to avoid
the hack of if (!draggingSource) in [DumpRenderTreeDraggingInfo draggingSourceOperationMask]
New Test: editing/pasteboard/file-input-files-access.html
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/DumpRenderTreeFileDraggingSource.h: Added.
- DumpRenderTree/DumpRenderTreeFileDraggingSource.m: Added. (-[DumpRenderTreeFileDraggingSource draggingSourceOperationMaskForLocal:]):
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::staticValues): removed addFileToPasteboardOnDrag support (LayoutTestController::staticFunctions): removed addFileToPasteboardOnDrag support
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest): ASSERT that draggingInfo has been cleared
- DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): Sorted selectors. (+[EventSendingController webScriptNameForSelector:]): Sorted selectors. (-[EventSendingController beginDragWithFiles:]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController keyDown:withModifiers:]): (-[EventSendingController fireKeyboardEventsToElement:]): removed spurious { }
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]): removed addFileToPasteboardOnDrag support
- 12:24 AM Changeset in webkit [43889] by
-
- 7 edits in trunk/WebCore
2009-05-20 David Levin <levin@chromium.org>
Reviewed by NOBODY, layout tests fix.
https://bugs.webkit.org/show_bug.cgi?id=23727
This reverts commit r43888.
Once that change was checked in many of the fast/flexbox0*.html
tests (and others) started failing.
- WebCore.pro:
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::updateMarqueePosition): (WebCore::RenderMarquee::timerFired):
May 19, 2009:
- 9:32 PM Changeset in webkit [43888] by
-
- 7 edits in trunk/WebCore
2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by George Staikos.
Add WCSS marquee extension support to Webkit
refer to the specification: WAP-239-WCSS-20011026-a.pdf
Since WCSS is the companion of XHTML Mobile Profile (XHTML MP),
this change depends on https://bugs.webkit.org/show_bug.cgi?id=23452
- 8:49 PM Changeset in webkit [43887] by
-
- 5 edits5 adds in trunk/LayoutTests
2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by George Staikos.
Add tests for WCSS marquee extension support
https://bugs.webkit.org/show_bug.cgi?id=23727
- 8:31 PM Changeset in webkit [43886] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-19 Geoffrey Garen <ggaren@apple.com>
Windows build fix.
- interpreter/RegisterFile.cpp: (JSC::RegisterFile::releaseExcessCapacity): Copy-paste typo.
- 8:25 PM Changeset in webkit [43885] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed <rdar://problem/6885680> CrashTracer: [USER] 1 crash in Install
Mac OS X at <unknown binary> • 0x9274241c
(Original patch by Joe Sokol and Ronnie Misra.)
SunSpider says 1.004x faster.
- interpreter/RegisterFile.cpp: (JSC::RegisterFile::releaseExcessCapacity): Instead of doing complicated math that sometimes used to overflow, just release the full range of the register file.
- interpreter/RegisterFile.h: (JSC::isPageAligned): (JSC::RegisterFile::RegisterFile): Added ASSERTs to verify that it's safe to release the full range of the register file.
(JSC::RegisterFile::shrink): No need to releaseExcessCapacity() if the
new end is not smaller than the old end. (Also, doing so used to cause
numeric overflow, unmapping basically the whole process from memory.)
- 8:02 PM Changeset in webkit [43884] by
-
- 2 edits in trunk/BugsSite
2009-05-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
Make PrettyPatch understand quoted filenames in git diffs.
https://bugs.webkit.org/show_bug.cgi?id=25881
- PrettyPatch/PrettyPatch.rb:
- 7:33 PM Changeset in webkit [43883] by
-
- 5 edits in branches/nitro-extreme/JavaScriptCore
2009-05-19 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement and enable optimized calls.
- jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): Add ENABLE(JIT_OPTIMIZE_CALL) guards around the the optimize call only trampolines (virtualCallPreLink and virtualCallLink). Update the trampolines to account for the new JSValue representation. (JSC::JIT::unlinkCall): Use NULL instead of JSValue noValue.
- jit/JITCall.cpp: (JSC::JIT::compileOpCall): Update to account for the new JSValue representation (JSC::JIT::compileOpCallSlowCase): Ditto.
- jit/JITStubs.h: Remove incorrect !ENABLE(JIT_OPTIMIZE_CALL) guard.
- wtf/Platform.h: Enable ENABLE_JIT_OPTIMIZE_CALL.
- 7:02 PM Changeset in webkit [43882] by
-
- 5 edits in trunk/WebCore
2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by George Staikos.
Add XHTMLMP support to Webkit
Update the configure files for building XHTMLMP-enabled WebKit on different platform
https://bugs.webkit.org/show_bug.cgi?id=23452
- 6:18 PM Changeset in webkit [43881] by
-
- 3 edits in trunk/JavaScriptCore
<rdar://problem/6888393> REGRESSION: Start Debugging JavaScript crashes browser (nightly builds only?)
<https://bugs.webkit.org/show_bug.cgi?id=25717>
RS=Mark Rowe.
Remove JSC_FAST_CALL as it wasn't gaining us anything, and was
resulting in weird bugs in the nightly builds.
- 5:44 PM Changeset in webkit [43880] by
-
- 2 edits1 add1 delete in trunk
WebCore:
2009-05-19 Antti Koivisto <Antti Koivisto>
I can't figure out how to make this not timing dependent, making it manual test instead.
- manual-tests/preload-scanner-entities.html: Added.
LayoutTests:
2009-05-19 Antti Koivisto <Antti Koivisto>
I can't figure out how to make this not timing dependent, making it manual test instead.
- fast/tokenizer/preload-scanner-entities-expected.txt: Removed.
- fast/tokenizer/preload-scanner-entities.html: Removed.
- 5:43 PM Changeset in webkit [43879] by
-
- 1 edit1 move in trunk/LayoutTests
2009-05-19 Darin Adler <Darin Adler>
Renamed test failing on many buildbots to disable it.
Antti can move it back once he gets it working more consistently.
- fast/tokenizer/preload-scanner-entities.html: Removed.
- fast/tokenizer/preload-scanner-entities.html-disabled: Copied from fast/tokenizer/preload-scanner-entities.html.
- 4:41 PM Changeset in webkit [43878] by
-
- 4 edits in trunk/WebCore
2009-05-19 Brady Eidson <beidson@apple.com>
Reviewed by Antti Koivisto.
<rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.
This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
in QuickLooks (rdar://problem/6619630).
We need to respect the DocumentLoader's request cache policy when deciding the cache policy
for subresources, but the check (originally removed in r39304 and added back in in the same
place in r41424) needs to be tweaked and relocated a bit.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy(). Move checking the DocumentLoader's request to a more appropriate place. Add code to handle the recently added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code cleaner in the future.
- loader/FrameLoader.h:
- loader/DocLoader.cpp: (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().
- 3:31 PM Changeset in webkit [43877] by
-
- 5 edits2 adds in trunk
Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
https://bugs.webkit.org/show_bug.cgi?id=25872
- 2:57 PM Changeset in webkit [43876] by
-
- 3 edits2 adds in trunk
WebCore:
2009-05-19 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler).
<rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
Push characters back in correct order when entity parsing fails after 3 characters.
Test: fast/tokenizer/preload-scanner-entities.html
- html/PreloadScanner.cpp: (WebCore::PreloadScanner::consumeEntity):
LayoutTests:
2009-05-19 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
<rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)
- fast/tokenizer/preload-scanner-entities-expected.txt: Added.
- fast/tokenizer/preload-scanner-entities.html: Added.
- 2:53 PM Changeset in webkit [43875] by
-
- 12 edits in branches/nitro-extreme/JavaScriptCore
2009-05-19 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement and enable optimized property access.
- assembler/AbstractMacroAssembler.h: Fix comment.
- jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): Remove array length trampoline and implement the string length trampoline.
- jit/JIT.h: Add new constants for patch offsets.
- jit/JITInlineMethods.h: Remove FIELD_OFFSET which is now in StdLibExtras.h.
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubCall.h: (JSC::JITStubCall::addArgument): Add version of addArgument that takes two registers for the tag and payload.
- jit/JITStubs.cpp: (JSC::JITStubs::JITStubs): Remove array length trampoline pointer. (JSC::JITStubs::cti_op_get_by_id_self_fail):
- jit/JITStubs.h:
- runtime/JSObject.h: (JSC::JSObject::JSObject): Move m_inheritorID below the property storage to align it to a 16 byte boundary.
- wtf/Platform.h: Enable ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
- wtf/StdLibExtras.h: Move FIELD_OFFSET here.
- 2:13 PM Changeset in webkit [43874] by
-
- 2 edits in trunk/WebCore
2009-05-19 Paul Godavari <paul@chromium.org>
Reviewed by Dimitri Glazkov.
Fix a crash in Mac Chromium when displaying an HTML select element
with no items.
https://bugs.webkit.org/show_bug.cgi?id=25874
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showExternal):
- 1:54 PM Changeset in webkit [43873] by
-
- 3 edits in trunk/WebKitTools
wxMSW build fixes for DRT.
- 1:53 PM Changeset in webkit [43872] by
-
- 1 edit in trunk/WebCore/ChangeLog
Restore mistaken deletion of an entry in ChangeLog
- 1:51 PM Changeset in webkit [43871] by
-
- 2 edits in trunk/WebCore
2009-05-19 Nate Chapin <japhet@google.com>
Reviewed by Darin Fisher.
Upstream V8 bindings for CanvasRenderingContext2D.
https://bugs.webkit.org/show_bug.cgi?id=25858
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.
- 1:46 PM Changeset in webkit [43870] by
-
- 2 edits in trunk/WebCore
2009-05-19 Jessie Berlin <jberlin@apple.com>
Reviewed by Mark Rowe.
Windows Build Fix.
- WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.
- 12:18 PM Changeset in webkit [43869] by
-
- 5 edits in trunk
Add a new private API method that will dispatch pending loads that have been scheduled because of recent DOM additions or style changes.
<rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not loaded because willSendRequest doesn't happen immediately
WebCore:
2009-05-19 Timothy Hatcher <timothy@apple.com>
<rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
loaded because willSendRequest doesn't happen immediately
Reviewed by Antti Koivisto.
- WebCore.base.exp: Export Loader::servePendingRequests().
WebKit/mac:
2009-05-19 Timothy Hatcher <timothy@apple.com>
Add a new private API method that will dispatch pending loads that have been scheduled
because of recent DOM additions or style changes.
<rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
loaded because willSendRequest doesn't happen immediately
Reviewed by Antti Koivisto.
- WebView/WebView.mm: (-[WebView _dispatchPendingLoadRequests]): Call Loader::servePendingRequests().
- WebView/WebViewPrivate.h: Added _dispatchPendingLoadRequests.
- 12:08 PM Changeset in webkit [43868] by
-
- 2 edits in trunk/WebCore
2009-05-19 David Levin <levin@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 25859: Need to upstream ScriptController.* for v8.
https://bugs.webkit.org/show_bug.cgi?id=25859
Fixing the header file (which I accidentally made identical to the cpp file).
- bindings/v8/ScriptController.h:
- 11:54 AM Changeset in webkit [43867] by
-
- 1 edit in trunk/WebCore/ChangeLog
Adding a Radar URL.
- 11:14 AM Changeset in webkit [43866] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler and Brady Eidson.
REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls
The problem was that Document::removeAllEventListeners() was called for a wrong document
when a CachedFrame was destroyed.
Cannot be tested automatically, because DRT doesn't have a b/f cache.
- dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an unrelated window even if document's m_frame pointer is stale.
- history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.
- 10:53 AM Changeset in webkit [43865] by
-
- 5 edits6 adds in trunk/LayoutTests
2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by George Staikos.
Add the XHTML MP tests but put them in skipped since they are not active
by default on any platforms.
https://bugs.webkit.org/show_bug.cgi?id=23452
- 9:58 AM Changeset in webkit [43864] by
-
- 16 edits2 adds in trunk/WebCore
2009-05-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
- inspector/ConsoleMessage.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspect): (WebCore::InspectorController::focusNode): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::setAttachedWindow): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::addScriptProfile): (WebCore::InspectorController::toggleRecordButton): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::failedToParseSource): (WebCore::InspectorController::didPause): (WebCore::InspectorController::didContinue):
- inspector/InspectorController.h:
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
- inspector/InspectorDOMStorageResource.h:
- inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
- inspector/InspectorDatabaseResource.h:
- inspector/InspectorFrontend.cpp: Added. (WebCore::callSimpleFunction): (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::~InspectorFrontend): (WebCore::InspectorFrontend::newJSONObject): (WebCore::InspectorFrontend::addMessageToConsole): (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared): (WebCore::InspectorFrontend::showPanel): (WebCore::InspectorFrontend::populateInterface): (WebCore::InspectorFrontend::reset): (WebCore::InspectorFrontend::debuggerWasEnabled): (WebCore::InspectorFrontend::debuggerWasDisabled): (WebCore::InspectorFrontend::profilerWasEnabled): (WebCore::InspectorFrontend::profilerWasDisabled): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfile): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::resumedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::addDOMStorage):
- inspector/InspectorFrontend.h: Added.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::releaseScriptObject):
- inspector/InspectorResource.h:
- 9:50 AM Changeset in webkit [43863] by
-
- 9 moves in branches/old
Clean up some old, unused branches.
- 9:47 AM Changeset in webkit [43862] by
-
- 1 copy in branches/WWDC-2009-branch
New branch.
- 9:45 AM Changeset in webkit [43861] by
-
- 10 edits1 copy1 add in trunk/WebCore
2009-05-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
- inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
- inspector/InspectorResource.cpp: (WebCore::populateHeadersObject): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
- inspector/JSONObject.cpp: Added. (WebCore::JSONObject::JSONObject): (WebCore::JSONObject::set): (WebCore::JSONObject::scriptObject): (WebCore::JSONObject::createNew):
- inspector/JSONObject.h: Added.
- 9:36 AM Changeset in webkit [43860] by
-
- 1 edit in trunk/WebCore/ChangeLog
Correct two changelog entries to show the bug report
- 9:08 AM Changeset in webkit [43859] by
-
- 11 edits in trunk/WebCore
2009-05-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
- inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported):
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource): (WebCore::InspectorDOMStorageResource::bind): (WebCore::InspectorDOMStorageResource::unbind):
- inspector/InspectorDOMStorageResource.h:
- inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind): (WebCore::InspectorDatabaseResource::unbind):
- inspector/InspectorDatabaseResource.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::populateHeadersObject): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::releaseScriptObject):
- inspector/InspectorResource.h:
- inspector/front-end/Console.js: (WebInspector.ConsoleMessage):
- inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.updateResource): (WebInspector.removeResource): (WebInspector.addDatabase): (WebInspector.addDOMStorage): (WebInspector.reset): (WebInspector.addMessageToConsole):
- 8:11 AM Changeset in webkit [43858] by
-
- 4 edits in trunk/WebCore
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Ariya Hidayat.
The Qt port has code that disables scrolling optimizations
when the root contains native windows, such as windowed plugins.
This code broke when detaching iframes containing windowed
plugins.
Each ScrollView now knows how many native windows it and its
children contain, and when it is detached, that number is
substracted from its old parents.
- 4:45 AM Changeset in webkit [43857] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-19 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Do not try to free enchant broker and dictionary if they do not
exist, those functions aren't NULL-safe.
- webkit/webkitwebsettings.cpp: (free_spell_checking_language):
- 1:01 AM Changeset in webkit [43856] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by Gavin Barraclough.
- speed up string comparison, especially for short strings
~1% on SunSpider
- JavaScriptCore.exp:
- runtime/UString.cpp:
- runtime/UString.h: (JSC::operator==): Inline UString's operator==, since it is called from hot places in the runtime. Also, specialize 2-char strings in a similar way to 1-char, since we're taking the hit of a switch anyway.
May 18, 2009:
- 11:06 PM Changeset in webkit [43855] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Gavin Barraclough.
- for polymorphic prototype lookups, increase the number of slots from 4 to 8
~4% faster on v8 raytrace benchmark
- bytecode/Instruction.h:
- 10:39 PM Changeset in webkit [43854] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
- tighten up the code for the load_varargs stub
~1-2% on v8-raytrace
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_load_varargs): Hoist some loop invariants that the compiler didn't feel like hoisting for us. Remove unneeded exception check.
- 10:17 PM Changeset in webkit [43853] by
-
- 2 edits in trunk/LayoutTests
Added cookie test to Skipped list for Windows
See Bug 25861. <https://bugs.webkit.org/show_bug.cgi?id=25861>
- platform/win/Skipped: Added http/tests/cookies/simple-cookies-expired.html.
- 10:02 PM Changeset in webkit [43852] by
-
- 2 edits in trunk/WebCore
Tiger build fix for r43850
- platform/mac/ClipboardMac.mm: Added typedef for NSUinteger when building on Tiger.
- 9:52 PM Changeset in webkit [43851] by
-
- 4 edits18 adds in trunk
Bug 24569: Add some cookies tests
LayoutTests:
Reviewed and tweaked by David Kilzer.
This modification adds a cookie framework to check setting cookies.
It is a simple modification over the js test framework. It uses some XHRs and custom server-side script
to set / get / clear cookies.
It also adds some very basic tests to check that everything works.
- http/tests/cookies: Added.
- http/tests/cookies/multiple-cookies-expected.txt: Added.
- http/tests/cookies/multiple-cookies.html: Added.
- http/tests/cookies/resources: Added.
- http/tests/cookies/resources/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
- http/tests/cookies/resources/clearCookies.cgi: Added.
- http/tests/cookies/resources/cookies-test-post.js: Copied from LayoutTests/fast/js/resources/js-test-post.js.
- http/tests/cookies/resources/cookies-test-pre.js: Copied from LayoutTests/fast/js/resources/js-test-pre.js. (setCookies): Internal method to set a cookie (multiple cookies are not supported). (testCookies): Internal method to check if the cookie were set.
(clearAllCookies): Used to clear all pre-existing cookies for this domain.
(clearCookies): Used to clear the cookies set with cookiesShouldBe.
(cookiesShouldBe): Used to set a cookie and check the "Cookie" header sent. It is inspired from shouldBe from the js test framework.
- http/tests/cookies/resources/cookies-test-style.css: Copied from LayoutTests/fast/js/resources/js-test-style.css.
- http/tests/cookies/resources/getCookies.cgi: Added.
- http/tests/cookies/resources/multiple-cookies.js: Added.
- http/tests/cookies/resources/setCookies.cgi: Added.
- http/tests/cookies/resources/simple-cookies-expired.js: Added.
- http/tests/cookies/resources/simple-cookies-max-age.js: Added.
- http/tests/cookies/simple-cookies-expired-expected.txt: Added.
- http/tests/cookies/simple-cookies-expired.html: Added.
- http/tests/cookies/simple-cookies-max-age-expected.txt: Added.
- http/tests/cookies/simple-cookies-max-age.html: Added.
- platform/mac-tiger/Skipped: Added http/tests/cookies/simple-cookies-max-age.html since CFNetwork on Tiger doesn't support expiring cookies with Max-Age=0.
WebKitTools:
Patch by David Kilzer.
- Scripts/make-js-test-wrappers: Added regex to skip cookies-test-(post|pre).js files.
- 9:17 PM Changeset in webkit [43850] by
-
- 2 edits in trunk/WebCore
2009-05-17 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
ClipboardMac cleanup
https://bugs.webkit.org/show_bug.cgi?id=25847
I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.
No functional changes, so no tests.
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::clearData): (WebCore::absoluteURLsFromPasteboardFilenames): Broke out logic for filenames into its own function to make the caller more readable. (WebCore::absoluteURLsFromPasteboard): Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray so that we can use -[NSArray componentsJoinedByString] in the caller (which is cleaner than the manual "\n" addition before). This also access to the full list of file urls for future callers. (WebCore::ClipboardMac::getData): unsigned count = (type == "URL") ? 1 : [fileList count]; is now an explicit check for "URL", before it was a check for != "text/uri-list" which was much more confusing in my opinion. text/uri-list and URL are the only two types which map to NSURLPboardType in cocoaTypeFromMIMEType(). (WebCore::ClipboardMac::types): I removed an extra if (!types) check, right before [types count]. In Obj-C messaging nil will return 0 (size of a pointer), so it's safe to message nil here and expect it to return 0.
- 8:40 PM Changeset in webkit [43849] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff Garen.
- Improve code generation for access to prototype properties
~0.4% speedup on SunSpider.
Based on a suggestion from Geoff Garen.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- 8:23 PM Changeset in webkit [43848] by
-
- 4 edits in trunk/WebKit
WebKit/mac:
2009-05-18 Sam Weinig <sam@webkit.org>
<rdar://problem/6899044> Can't see Apple ad on nytimes.com unless I spoof the user agent
Add user agent hack for pointroll.com.
Reviewed by Steve Falkenburg.
- WebView/WebView.mm: (-[WebView WebCore::_userAgentForURL:WebCore::]):
WebKit/win:
2009-05-18 Steve Falkenburg <sfalken@apple.com>
<rdar://problem/6899044> Can't see Apple ad on nytimes.com unless I spoof the user agent
Add user agent hack for pointroll.com.
Reviewed by Sam Weinig.
- WebView.cpp:
- 5:42 PM Changeset in webkit [43847] by
-
- 1 edit2 adds in trunk/WebCore
2009-05-18 David Levin <levin@chromium.org>
Reviewed by Darin Fisher.
Bug 25859: Need to upstream ScriptController.* for v8.
https://bugs.webkit.org/show_bug.cgi?id=25859
- bindings/v8/ScriptController.cpp: Added.
- bindings/v8/ScriptController.h: Added.
- 5:27 PM Changeset in webkit [43846] by
-
- 5 edits in trunk
2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Gavin Barraclough.
Enable YARR, and disable WREC for GTK+.
- configure.ac:
- 5:10 PM Changeset in webkit [43845] by
-
- 4 edits in trunk/WebCore
2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by George Staikos.
Change ScriptElement to support XHTMLMP in a better way
- 5:00 PM Changeset in webkit [43844] by
-
- 4 edits in trunk
wx build fix. Use python-config to get Python linking info on Unix OSes.
- 4:51 PM Changeset in webkit [43843] by
-
- 2 edits in trunk/WebCore
wx build fix, finish up changes after the accessibility dir split.
- 4:48 PM Changeset in webkit [43842] by
-
- 16 edits2 adds in trunk/WebCore
2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by George Staikos (and others).
Add XHTMLMP support to Webkit
XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
functionality. Most of the functionalities have already been implemented by Webkit.
The changes include:
1) Adding <noscript> support
2) Document conformance validation
3) User Agent conformance validation
- 3:35 PM Changeset in webkit [43841] by
-
- 2 edits in trunk/WebCore
Fix the build.
- WebCore.xcodeproj/project.pbxproj:
- 1:40 PM Changeset in webkit [43840] by
-
- 2 edits in trunk/WebCore
2009-05-18 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Rubber-stamped by Gustavo Noronha.
Fixed build for the Qt port by adding the WebCore/accessibility
directory to the includepath.
- WebCore.pro:
- 1:22 PM Changeset in webkit [43839] by
-
- 17 edits in trunk/JavaScriptCore
2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Add -no-install and -no-fast-install to programs and tests that we
don't install. Also remove -O2 since this is already handled at
configure time.
- GNUmakefile.am:
- 1:12 PM Changeset in webkit [43838] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (speculative build fix).
- JavaScriptCore.xcodeproj/project.pbxproj:
- 12:46 PM Changeset in webkit [43837] by
-
- 16 edits in trunk/JavaScriptCore
2009-05-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Refactor JIT code-handle objects. The representation of generated code is currently
a bit of a mess. We have a class JITCode which wraps the pointer to a block of
generated code, but this object does not reference the executable pool meaning that
external events (the pool being derefed) could make the pointer become invalid.
To overcome this both the JIT and Yarr implement further (and similar) objects to
wrap the code pointer with a RefPtr to the pool. To add to the mire, as well as the
CodeBlock containing a handle onto the code the FunctionBodyNode also contains a
copy of the code pointer which is used almost (but not entirely) uniquely to access
the JIT code for a function.
Rationalization of all this:
- Add a new type 'MacroAssembler::CodeRef' as a handle for a block of JIT generated code.
- Change the JIT & Yarr to internally handle code using CodeRefs.
- Move the CodeRef (formerly anow defunct JITCodeRef) from CodeBlock to its owner node.
- Remove the (now) redundant code pointer from FunctionBodyNode.
While tidying this up I've made the PatchBuffer return code in new allocations using a CodeRef,
and have enforced an interface that the PatchBuffer will always be used, and 'finalizeCode()' or
'finalizeCodeAddendum()' will always be called exactly once on the PatchBuffer to complete code generation.
This gives us a potentially useful hook ('PatchBuffer::performFinalization()') at the end of generation,
which may have a number of uses. It may be helpful should we wish to switch our generation
model to allow RW/RX exclusive memory, and it may be useful on non-cache-coherent platforms to
give us an oportunity to cache flush as necessary.
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::CodeRef::CodeRef): (JSC::AbstractMacroAssembler::CodeRef::trampolineAt): (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive): (JSC::AbstractMacroAssembler::PatchBuffer::patch): (JSC::AbstractMacroAssembler::PatchBuffer::complete): (JSC::AbstractMacroAssembler::PatchBuffer::finalize): (JSC::AbstractMacroAssembler::PatchBuffer::entry):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::setJITCode):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex): (JSC::CodeBlock::executablePool):
- interpreter/CallFrameClosure.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall):
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::linkCall):
- jit/JIT.h:
- jit/JITCode.h: (JSC::JITCode::JITCode): (JSC::JITCode::operator bool): (JSC::JITCode::addressForCall): (JSC::JITCode::offsetOf): (JSC::JITCode::execute): (JSC::JITCode::size): (JSC::JITCode::executablePool): (JSC::JITCode::HostFunction):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall):
- parser/Nodes.cpp: (JSC::ProgramNode::generateJITCode): (JSC::EvalNode::generateJITCode): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::createNativeThunk): (JSC::FunctionBodyNode::generateJITCode):
- parser/Nodes.h: (JSC::ScopeNode::generatedJITCode): (JSC::ScopeNode::getExecutablePool): (JSC::ScopeNode::setJITCode): (JSC::ProgramNode::jitCode): (JSC::EvalNode::jitCode): (JSC::FunctionBodyNode::jitCode):
- runtime/RegExp.cpp: (JSC::RegExp::match):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile): (JSC::Yarr::jitCompileRegex): (JSC::Yarr::executeRegex):
- yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::pcreFallback): (JSC::Yarr::RegexCodeBlock::setFallback): (JSC::Yarr::RegexCodeBlock::operator bool): (JSC::Yarr::RegexCodeBlock::set): (JSC::Yarr::RegexCodeBlock::execute):
- 12:11 PM Changeset in webkit [43836] by
-
- 2 edits in trunk/WebKitTools
wx build fix, initialize variable that doesn't get set on Windows.
- 12:10 PM Changeset in webkit [43835] by
-
- 2 edits in trunk/WebCore
Bug 25776: accessibility should have its own folder in WebCore project
https://bugs.webkit.org/show_bug.cgi?id=25776
Speculative fix for windows build failure.
- 11:59 AM Changeset in webkit [43834] by
-
- 8 edits2 adds in trunk
Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon
Reviewed by Darin Adler.
WebCore:
Test: http/tests/misc/favicon-as-image.html
- inspector/front-end/inspector.js: Added image/vnd.microsoft.icon to WebInspector.MIMETypes.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): Added image/vnd.microsoft.icon to list of supported image and image resource MIME types.
LayoutTests:
Updated existing favicon-as-image.html test to display a third
image having MIME type image/vnd.microsoft.icon.
- http/tests/misc/favicon-as-image.html: Updated.
- http/tests/misc/resources/.htaccess: Added.
- http/tests/misc/resources/favicon-vnd-ms.ico: Copied from LayoutTests/fast/images/resources/favicon.ico.
- platform/mac/http/tests/misc/favicon-as-image-expected.checksum: Updated.
- platform/mac/http/tests/misc/favicon-as-image-expected.png: Updated.
- platform/mac/http/tests/misc/favicon-as-image-expected.txt: Updated.
- 11:48 AM Changeset in webkit [43833] by
-
- 6 edits46 moves7 adds in trunk/WebCore
Bug 25776: accessibility should have its own folder in WebCore project
https://bugs.webkit.org/show_bug.cgi?id=25776
- 10:26 AM Changeset in webkit [43832] by
-
- 2 edits in trunk/WebCore
2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25854
[GTK] Should tell servers we only support identity as content encoding
Let servers know we only support identity as content
encoding. We will implement this in libsoup.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
- 8:30 AM Changeset in webkit [43831] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
CAPTCHA failure.
The problem was that after loading and displaying a CAPTCHA image, it was loaded from
the server again due to preloading. So, the server expected the last loaded (invisible)
CAPTCHA text to be typed and posted back.
I don't know how to make tests for preloading.
- loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason to preload after loading for real - and if cache policy is CachePolicyReload, that actually results in another load from network layer.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy() to lie, but I don't know how to re-do r41425 properly. Added a FIXME.
- 7:13 AM Changeset in webkit [43830] by
-
- 2 edits in trunk/WebCore
2009-05-18 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
Done together with Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>.
[Qt] Reuse FontPlatformData for the same FontDescription.
This effectively prevents growing heap usage for loading every web page.
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::qHash): Necessary for FontPlatformDataCache. (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if it exists, otherwise create a new one and insert it in the cache.
- 5:11 AM Changeset in webkit [43829] by
-
- 2 edits in trunk/WebKit/qt
2009-05-18 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
Makes QtLauncher to accept multiple urls in command line and opens these in separate windows.
- QtLauncher/main.cpp: (MainWindow::newWindow): (main):
- 4:33 AM Changeset in webkit [43828] by
-
- 2 edits in trunk/WebCore
2009-05-18 Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Fix the leak in FontFallbackList::fontDataAt() function.
When creating a new instance of SimpleFontData, put it in the font list
so that it can deleted later on.
- platform/graphics/qt/FontFallbackListQt.cpp: (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt):
- 4:30 AM Changeset in webkit [43827] by
-
- 2 edits in trunk
2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Add support for running unit tests. Also run the tests whenever
the 'check' target runs.
- GNUmakefile.am:
- 4:30 AM Changeset in webkit [43826] by
-
- 4 edits in trunk
2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Style fixes
- GNUmakefile.am:
- WebCore/GNUmakefile.am
- 4:30 AM Changeset in webkit [43825] by
-
- 6 edits in trunk
2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Add -no-install and -no-fast-install to programs and tests that we
don't install. Also remove -O2 since this is already handled at
configure time.
- GNUmakefile.am:
- JavaScriptCore/GNUmakefile.am:
- WebKitTools/GNUmakefile.am:
- 4:30 AM Changeset in webkit [43824] by
-
- 4 edits in trunk
2009-05-17 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Add JavaScriptCore/ to JSC include path only since it's not
required when building WebCore.
- GNUmakefile.am:
2009-05-17 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Refactor library cflags
- GNUmakefile.am:
- 4:11 AM Changeset in webkit [43823] by
-
- 2 edits in trunk/LayoutTests
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
Skip new tests from r43822 on Gtk
https://bugs.webkit.org/show_bug.cgi?id=25780
- platform/gtk/Skipped:
- 3:55 AM Changeset in webkit [43822] by
-
- 1 edit6 adds in trunk/LayoutTests
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Oliver Hunt.
Add missing files from r43821
https://bugs.webkit.org/show_bug.cgi?id=25780
- editing/pasteboard/get-data-text-plain-drop-expected.txt: Added.
- editing/pasteboard/get-data-text-plain-drop.html: Added.
- editing/pasteboard/get-data-text-plain-paste-expected.txt: Added.
- editing/pasteboard/get-data-text-plain-paste.html: Added.
- editing/pasteboard/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
- editing/pasteboard/resources/get-data-text-plain-paste.js: Added. (handlePaste):
- 3:29 AM Changeset in webkit [43821] by
-
- 5 edits in trunk
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
- Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.
- 3:11 AM Changeset in webkit [43820] by
-
- 2 edits in trunk/WebKitTools
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
- Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.
May 17, 2009:
- 10:24 PM Changeset in webkit [43819] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-17 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove unneeded ExecState parameter from the number JSValue constructors.
- runtime/JSValue.h: (JSC::jsNumber): (JSC::jsNaN): (JSC::JSValue::JSValue):
- 6:20 PM Changeset in webkit [43818] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore.make:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 5:31 PM Changeset in webkit [43817] by
-
- 90 edits1 move in trunk/LayoutTests
Reviewed by David Kilzer.
- move fast/repaint/repaint.js into the resources subdirectory
- fast/repaint/repaint.js: Removed.
- fast/repaint/resources/repaint.js: Copied from fast/repaint/repaint.js.
- (89 tests changed to load the script from the new location)
- 1:11 PM Changeset in webkit [43816] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix for WML: constr->const
- 1:06 PM Changeset in webkit [43815] by
-
- 2 edits1 add in trunk/WebCore
2009-05-17 Darin Adler <Darin Adler>
Fix done by Simon Fraser (reviewed by me).
<rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
transitions has bad layout and overlapping garbled text when printing
- manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.
- page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.
- 12:12 PM Changeset in webkit [43814] by
-
- 2 edits1 add in trunk/WebCore
2009-05-17 Darin Adler <Darin Adler>
Reviewed by Simon Fraser.
<rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and also a type check on the selected index to avoid a bad cast to HTMLOptionElement.
- manual-tests/select-option-in-onload.html: Added.
- 11:34 AM Changeset in webkit [43813] by
-
- 2 edits in trunk/WebCore
2009-05-17 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Rename local variables for readability.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder):
- 10:50 AM Changeset in webkit [43812] by
-
- 2 edits in trunk/LayoutTests
2009-05-17 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Disable another media test that seems to be failing at least intermittently.
- 10:47 AM Changeset in webkit [43811] by
-
- 4 edits in trunk/WebCore
2009-05-17 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Bug 25840: fix some warnings seen on the GTK bot
https://bugs.webkit.org/show_bug.cgi?id=25840
- platform/ScrollView.cpp: (WebCore::ScrollView::platformScrollbarModes): Initialize results here. This is really just to quiet warnings. I think this code is unreachable. Someone could put ASSERT_NOT_REACHED() in here too at some point.
- plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Use proper printf format for int here, %d, not %lu. This could cause a real problem when compiled 64-bit, so it's good to fix.
- rendering/RenderTextControl.cpp: (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is really just to quiet the warning, but still seems like a good idea.
- 9:50 AM Changeset in webkit [43810] by
-
- 3 edits in trunk/WebCore
2009-05-17 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 25769: Fix accessibility warnings on GTK
https://bugs.webkit.org/show_bug.cgi?id=25769
- page/AccessibilityTable.cpp: (WebCore::AccessibilityTable::columnCount): Get rid of excess const. (WebCore::AccessibilityTable::rowCount): Ditto.
- page/AccessibilityTable.h: Ditto.
- 9:47 AM Changeset in webkit [43809] by
-
- 3 edits2 adds in trunk
WebCore:
2009-05-17 Kai Brüning <kai@granus.net>
Reviewed by Darin Adler.
bug 25822: DOM normalize does not remove empty text node between element nodes
https://bugs.webkit.org/show_bug.cgi?id=25822
Test: fast/dom/Node/normalize.html
- dom/Node.cpp: (WebCore::Node::normalize): Changed to remove any empty text nodes.
LayoutTests:
2009-05-17 Kai Brüning <kai@granus.net>
Reviewed by Darin Adler.
Test case for bug 25822: DOM normalize does not remove empty text node between element nodes
https://bugs.webkit.org/show_bug.cgi?id=25822
The test case strives to test the whole functionality of Node's normalize().
- fast/dom/Node/normalize-expected.txt: Added.
- fast/dom/Node/normalize.html: Added.
May 16, 2009:
- 8:44 PM Changeset in webkit [43808] by
-
- 4 edits in trunk/WebCore
2009-05-16 Dave Moore <davemoore@google.com>
Reviewed by Darin Adler.
Allow Strings to be created with one malloc node with no copying
https://bugs.webkit.org/show_bug.cgi?id=25779
Add new methods to String and StringImpl, refactoring existing
methods in StringImpl to use new createUninitialized() method.
- platform/text/PlatformString.h: (WebCore::String::createUninitialized):
- platform/text/StringImpl.cpp: (WebCore::StringImpl::createUninitialized): (WebCore::StringImpl::create):
- platform/text/StringImpl.h:
- 8:38 PM Changeset in webkit [43807] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
dramatically improve animated GIF decoding performance
Reviewed by Darin Adler.
Recent versions of ImageIO discard previously decoded image frames if the client
application no longer holds references to them, so there's no need to throw away
the decoder unless we're explicitly asked to destroy all of the frames.
This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
from over 90% to below 3%.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::clear):
- 2:51 PM Changeset in webkit [43806] by
-
- 4 edits in trunk/WebKit
WebKit:
2009-05-16 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig and Dan Bernstein.
Fix <rdar://problem/6889644>.
- English.lproj/Localizable.strings:
WebKit/mac:
2009-05-16 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig and Dan Bernstein.
Fix <rdar://problem/6889644>
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
- 1:21 PM Changeset in webkit [43805] by
-
- 9 edits in trunk/LayoutTests/platform/mac
Set the svn:mime-type property of recently-added PNG files to image/png
- 1:06 PM Changeset in webkit [43804] by
-
- 2 edits in trunk/WebKit/mac
- revert an accidental change from r43802.
- WebInspector/WebInspector.mm:
- 12:58 PM Changeset in webkit [43803] by
-
- 2 edits in trunk/WebKit/mac
2009-05-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6895347> Mouse wheeling in the QuickTime plug-in (incorrectly) scrolls the page
Fix logic. The plug-in returns true if it handled the event.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):
- 12:56 PM Changeset in webkit [43802] by
-
- 7 edits2 adds in trunk
WebCore:
Reviewed by Alexey Proskuryakov.
- fix <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget
Test: platform/mac/editing/pasteboard/text-precomposed.html
Ensure that "text/plain" data retrieved from the clipboard is always
precomposed. This makes Clipboard::getData() and
Pasteboard::documentFragment() consistent with Pasteboard::plainText()
and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::getData):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment):
WebKit/mac:
Reviewed by Alexey Proskuryakov.
- fix <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget
- WebView/WebHTMLView.mm: (-[WebHTMLView _plainTextFromPasteboard:]): Return precomposed text. This is consistent with -_documentFragmentFromPasteboard:forType:inContext:subresources:.
LayoutTests:
Reviewed by Alexey Proskuryakov.
- test for <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget
- platform/mac/editing/pasteboard/text-precomposed-expected.txt: Added.
- platform/mac/editing/pasteboard/text-precomposed.html: Added.
- 2:11 AM Changeset in webkit [43801] by
-
- 4 edits in trunk
[GTK] Merge r41819 into Gtk to log through the JS console
https://bugs.webkit.org/show_bug.cgi?id=25787
Copy over the log routine from the OSX TestNetscapePlugin to
the copy of Gtk.
- 2:10 AM Changeset in webkit [43800] by
-
- 4 edits in trunk
[GTK] Merge r39877 into Gtk+ to pass plugins/npruntime.html
WebKitTools:
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Jan Michael Alonzo.
Forward port r39877 from main.c of OSX to TestNetscapePlugin
of Gtk.
- DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance):
LayoutTests:
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Jan Michael Alonzo.
Enable plugins/npruntime.html
- platform/gtk/Skipped:
- 12:56 AM Changeset in webkit [43799] by
-
- 2 edits in trunk/WebCore
Build fix.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForFamily): Declare valueForFamily as static.
May 15, 2009:
- 11:57 PM Changeset in webkit [43798] by
-
- 5 edits in trunk/LayoutTests
2009-05-15 Darin Adler <Darin Adler>
Fix some failures from recent changes.
- platform/gtk/Skipped: Added recently-added test to the "no expected results" section.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
- svg/css/getComputedStyle-basic-expected.txt: Ditto.
- 11:06 PM Changeset in webkit [43797] by
-
- 7 edits2 adds in trunk
WebCore:
2009-05-15 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
only the generic font, if any generic font is in the family list
Test: fast/css/getComputedStyle/computed-style-font-family.html
- css/CSSComputedStyleDeclaration.cpp: Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak. (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers. (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family property as specified in the CSS standard. Fixed clip to return "auto" when there is no clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties internal linkage since there was no reason for them to have external linkage.
LayoutTests:
2009-05-15 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
only the generic font, if any generic font is in the family list
- fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
- fast/css/getComputedStyle/computed-style-font-family.html: Added.
- fast/css/getComputedStyle/computed-style.html: Updated array of properties to dump that are not visible when iterating the computed style object. Removed pointless unused array of unimplemented properties.
- fast/css/getComputedStyle/computed-style-without-renderer.html: Ditto.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
- 7:17 PM Changeset in webkit [43796] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-15 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
Plug memory leak.
- webkit/webkitwebsettings.cpp: (free_spell_checking_language): (webkit_web_settings_finalize): (webkit_web_settings_set_property):
- 6:06 PM Changeset in webkit [43795] by
-
- 5 edits2 adds in trunk
WebCore:
2009-05-15 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Append instead of throwing when insertItemBefore gets an out-of-bound
index.
Test: svg/dom/svglist-insertItemBefore-appends.html
- svg/SVGList.h: (WebCore::SVGList::insertItemBefore):
LayoutTests:
2009-05-15 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Test that insertBeforeItem behaves properly for out of bounds indices.
- svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
- svg/dom/svglist-exception-on-out-bounds-error.html:
- svg/dom/svglist-insertItemBefore-appends-expected.txt: Added.
- svg/dom/svglist-insertItemBefore-appends.html: Added.
- 5:33 PM Changeset in webkit [43794] by
-
- 2 edits in trunk/WebKitTools
wx build fix. Don't parse args using getopt since it isn't available on Windows.
- 5:31 PM Changeset in webkit [43793] by
-
- 3 edits4 adds in trunk
2009-05-15 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.
Test: fast/backgrounds/background-clip-text.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- 5:06 PM Changeset in webkit [43792] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard arrows, I can't navigate caret between To Do items in a Note message
Test: editing/selection/move-by-line-004.html
- editing/visible_units.cpp: (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper function. (WebCore::previousLinePosition): When advancing to the next candidate node, stop when leaving the closest ancestor of the original node that is not an inline. The code, incorrectly, was trying to exit the closest ancestor of that type which was editable, and therefore missing other blocks in the same editable root. (WebCore::nextLinePosition): Ditto.
LayoutTests:
Reviewed by Sam Weinig.
- test for <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard arrows, I can't navigate caret between To Do items in a Note message
- editing/selection/move-by-line-004-expected.txt: Added.
- editing/selection/move-by-line-004.html: Added.
- 4:50 PM Changeset in webkit [43791] by
-
- 5 edits in trunk
2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Jan Alonzo.
Converting filename to uri by concatenating strings is broken
on Windows. So, don't do it for that platform.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):
2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Jan Alonzo.
Converting filename to uri by concatenating strings is broken
on Windows. Use proper glib conversion functions.
- webkit/webkitwebview.cpp: (webkit_web_view_open):
- tests/testdownload.c: (test_webkit_download_create):
- 4:49 PM Changeset in webkit [43790] by
-
- 3 edits in trunk/WebKit/mac
2009-05-15 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Fix <rdar://problem/6875398>.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): If we failed to instantiate the plug-in, call cleanup() so that any streams created by the plug-in from its NPP_New callback are destroyed.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: Make cleanup() public.
- 3:40 PM Changeset in webkit [43789] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Looking like MSVC doesn't like static variables in inline methods?
Make the state of the SSE2 check a static variable on the class
MacroAssemblerX86Common as a speculative build fix for Windows.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::convertInt32ToDouble): (JSC::MacroAssemblerX86Common::branchDouble): (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32): (JSC::MacroAssemblerX86Common::isSSE2Present): (JSC::MacroAssemblerX86Common::):
- jit/JIT.cpp:
- 3:28 PM Changeset in webkit [43788] by
-
- 2 edits in trunk/LayoutTests
2009-05-15 Gustavo Noronha Silva <Gustavo Noronha Silva>
Disable new tests.
- platform/gtk/Skipped:
- 3:27 PM Changeset in webkit [43787] by
-
- 3 edits2 adds in trunk/WebCore
2009-05-15 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov.
Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
https://bugs.webkit.org/show_bug.cgi?id=25739
- bindings/v8/V8Collection.cpp: Added. (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
- bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
- bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER): Moved from v8_custom.cpp. (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
- 3:22 PM Changeset in webkit [43786] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6649936> Add *.exp export files to WebCore Xcode project
Reviewed by Darin Adler and Timothy Hatcher.
- WebCore.xcodeproj/project.pbxproj: Added Exports group, moved WebCore.base.exp into the group, and added 10 other *.exp files in WebCore.
- 3:15 PM Changeset in webkit [43785] by
-
- 2 edits in trunk/JavaScriptCore
Add some assembler headers to JavaScriptCore.vcproj
This is just a convenience for Windows developers.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 3:03 PM Changeset in webkit [43784] by
-
- 2 edits in trunk/WebCore
2009-05-15 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=25826
Change type to only have custom getter in JCS.
- html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.
- 2:54 PM Changeset in webkit [43783] by
-
- 5 edits in trunk/WebCore
2009-05-15 Antti Koivisto <Antti Koivisto>
Reviewed by Dave Kilzer.
Add a settings entry to en/disable web font support
https://bugs.webkit.org/show_bug.cgi?id=25239
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
- 2:28 PM Changeset in webkit [43782] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-15 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implemented fast path for op_put_by_val when putting to arrays.
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val):
- 2:11 PM Changeset in webkit [43781] by
-
- 10 edits in trunk/JavaScriptCore
2009-05-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add FP support to the MacroAssembler, port JITArithmetic over to make use of this. Also add
API to determine whether FP support is available 'MacroAssembler::supportsFloatingPoint()',
FP is presently only supported on SSE2 platforms, not x87. On platforms where a suitable
hardware FPU is not available 'supportsFloatingPoint()' may simply return false, and all
other methods ASSERT_NOT_REACHED().
- assembler/AbstractMacroAssembler.h:
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::MacroAssemblerX86): (JSC::MacroAssemblerX86::branch32): (JSC::MacroAssemblerX86::branchPtrWithPatch): (JSC::MacroAssemblerX86::supportsFloatingPoint):
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::): (JSC::MacroAssemblerX86Common::loadDouble): (JSC::MacroAssemblerX86Common::storeDouble): (JSC::MacroAssemblerX86Common::addDouble): (JSC::MacroAssemblerX86Common::subDouble): (JSC::MacroAssemblerX86Common::mulDouble): (JSC::MacroAssemblerX86Common::convertInt32ToDouble): (JSC::MacroAssemblerX86Common::branchDouble): (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32): (JSC::MacroAssemblerX86Common::branch32): (JSC::MacroAssemblerX86Common::branch16): (JSC::MacroAssemblerX86Common::branchTest32): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32): (JSC::MacroAssemblerX86Common::set32): (JSC::MacroAssemblerX86Common::setTest32): (JSC::MacroAssemblerX86Common::x86Condition): (JSC::MacroAssemblerX86Common::isSSE2Present):
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::movePtrToDouble): (JSC::MacroAssemblerX86_64::moveDoubleToPtr): (JSC::MacroAssemblerX86_64::setPtr): (JSC::MacroAssemblerX86_64::branchPtr): (JSC::MacroAssemblerX86_64::branchTestPtr): (JSC::MacroAssemblerX86_64::branchAddPtr): (JSC::MacroAssemblerX86_64::branchSubPtr): (JSC::MacroAssemblerX86_64::supportsFloatingPoint):
- assembler/X86Assembler.h:
- jit/JIT.cpp: (JSC::JIT::JIT):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::emit_op_add): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
- 1:43 PM Changeset in webkit [43780] by
-
- 3 edits in trunk/WebCore
2009-05-15 Sam Weinig <sam@webkit.org>
Reviewed by Steve Falkenburg.
Remove dead youtube site specific hack that was commented out.
- bindings/js/JSNavigatorCustom.cpp:
- page/Navigator.idl:
- 1:09 PM Changeset in webkit [43779] by
-
- 3 edits in trunk/WebCore
2009-05-15 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25826
<rdar://problem/6884742>
REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)
Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>
- bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::needsGmailQuirk): (WebCore::JSHTMLInputElement::type):
- html/HTMLInputElement.idl:
- 12:40 PM Changeset in webkit [43778] by
-
- 2 edits in trunk/WebCore
2009-05-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25810
Upstream V8 DOM Wrapper map declarations.
No behavior change, so no tests.
- bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::WeakReferenceMap): Added. (WebCore::WeakReferenceMap::~WeakReferenceMap): Added. (WebCore::WeakReferenceMap::get): Added. (WebCore::WeakReferenceMap::set): Added. (WebCore::WeakReferenceMap::forget): Added. (WebCore::WeakReferenceMap::contains): Added. (WebCore::WeakReferenceMap::impl): Added. (WebCore::DOMWrapperMap::DOMWrapperMap): Added.
- 12:10 PM Changeset in webkit [43777] by
-
- 5 edits in trunk/WebCore
2009-05-13 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Rename GraphicsLayer::graphicsContextsFlipped() to
GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.
Clean up code around the GraphicsLayer "contents" layer that makes use of this
flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
which can then always do the flipping if necessary.
Only affects ACCELERATED_COMPOSITING builds.
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::):
- platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::contentsLayer):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayer::compositingCoordinatesOrientation): (WebCore::GraphicsLayerCA::setBackgroundColor): (WebCore::GraphicsLayerCA::clearBackgroundColor): (WebCore::GraphicsLayerCA::setContentsToImage): (WebCore::GraphicsLayerCA::clearContents): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::setContentsLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- 12:00 PM Changeset in webkit [43776] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-15 Geoffrey Garen <ggaren@apple.com> (Mostly by Sam)
Reviewed by Sam Weinig.
Implemented fast path for op_get_by_val when accessing array.
- jit/JIT.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val):
- 11:17 AM Changeset in webkit [43775] by
-
- 2 edits in trunk/WebCore
Avoid calling setNeedsStyleRecalc() when we are
putting an animated page in the cache. This avoids
the assert and subsequent problems with a dirty
page going into the cache.
- 11:13 AM Changeset in webkit [43774] by
-
- 8 edits in trunk
2009-05-15 Francisco Tolmasky <francisco@280north.com>
BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
<https://bugs.webkit.org/show_bug.cgi?id=25467>
Reviewed by Adam Roben.
- JavaScriptCore.exp: Added calculatedFunctionName
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Added calculatedFunctionName
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added calculatedFunctionName
- debugger/DebuggerCallFrame.cpp: Added calculatedFunctionName to match existing one in ProfileNode. (JSC::DebuggerCallFrame::calculatedFunctionName):
- debugger/DebuggerCallFrame.h: Added calculatedFunctionName to match existing one in ProfileNode.
WebCore:
- inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
inspector/front-end/CallStackSidebarPane.js: Remove " anonymous function" since it is handled internally just like in profiles (WebInspector.CallStackSidebarPane.prototype.update):
- 10:59 AM Changeset in webkit [43773] by
-
- 2 edits in trunk/WebKit/mac
2009-05-15 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
<rdar://problem/6889823> hash table iterator used after hash table modified in
ProxyInstance::fieldNamed() when viewing movie trailer
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodsNamed): Move add call after the waitForReply call. Anders says that by the time we return someone else might have done the same add for us. (WebKit::ProxyInstance::fieldNamed): Ditto.
- 10:41 AM Changeset in webkit [43772] by
-
- 12 edits in trunk/WebKit/mac
2009-05-15 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6892055>
Replace WKN_GetLocation with WKN_ResolveURL (WKN_GetLocation was confusing and did not take the base URL into account)
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCResolveURL): New MIG callback.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resolveURL): Use FrameLoader::complete URL here.
- Plugins/Hosted/WebKitPluginClient.defs: Add new MIG definition.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
- Plugins/WebNetscapeContainerCheckPrivate.h:
- Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs):
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView resolveURL:forTarget:]):
- Plugins/npapi.mm: (WKN_ResolveURL):
- 10:27 AM Changeset in webkit [43771] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
- fix <rdar://problem/6892052> WebTextIterator should not “emit characters between all visible positions”
- WebView/WebTextIterator.mm: (-[WebTextIterator initWithRange:]): Changed to construct a TextIterator with emitCharactersBetweenAllVisiblePositions set to false.
- 9:45 AM Changeset in webkit [43770] by
-
- 3 edits in trunk/WebCore
Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Check strings with isEmpty(), not relying on any implicit conversions.
- 9:06 AM Changeset in webkit [43769] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler, Brady Eidson and Eric Carlson.
<rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
username and password (Lightwave 9.6 for Mac from Newtek site)
CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
for other protocols (including FTP) should be included as part of the URL.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): (WebCore::WebCoreSynchronousLoader::load):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Put credentials in URL for non-HTTP requests.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP headers to be received, so they cannot work with other protocols.
- 8:33 AM Changeset in webkit [43768] by
-
- 2 edits in trunk/BugsSite
2009-05-15 Simon Fraser <Simon Fraser>
Carrying forwards Darin Adler's rubber stamp
Make the comment field wider too.
- skins/custom/global.css:
- 8:16 AM Changeset in webkit [43767] by
-
- 3 edits in trunk/BugsSite
2009-05-14 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Make the URL, Summary and Keyword fields wider to mitigate the
effects of https://bugs.webkit.org/show_bug.cgi?id=25566 and make
things generally better.
- skins/custom/global.css:
- template/en/custom/bug/edit.html.tmpl:
- 5:43 AM Changeset in webkit [43766] by
-
- 2 edits in trunk
2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Jan Alonzo.
Use AC_CANONICAL_HOST instead of AC_CANONICAL_SYSTEM, since
the JIT compiler is not a cross-compiler
- configure.ac:
- 4:53 AM Changeset in webkit [43765] by
-
- 2 edits in trunk/WebKit/mac
Look for libWebKitSystemInterface.a in a more reasonable location.
Reviewed by Dave Kilzer.
- Configurations/DebugRelease.xcconfig:
- 4:47 AM Changeset in webkit [43764] by
-
- 3 edits in trunk/WebCore
2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Holger Freyther.
[Qt] In the image decoder, remove the raw image data represented as QImage
once the image is converted to QPixmap and inserted in the pixmap cache.
This effectively reduces the heap usage when running on graphics system
other than raster (i.e the case where QImage != QPixmap).
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
- platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.
- 4:46 AM Changeset in webkit [43763] by
-
- 3 edits in trunk/WebCore
2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Holger Freyther.
[Qt] Refactor alpha channel detection the image decoder.
Sets the boolean flag as soon as the image is being read.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel. (WebCore::ImageDecoderQt::setData): Set the flag when appropriate. (WebCore::ImageDecoderQt::supportsAlpha): Simplified. (WebCore::ImageDecoderQt::reset): Resetted the flag.
- platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.
- 1:34 AM Changeset in webkit [43762] by
-
- 3 edits in trunk/LayoutTests
Mark Rowe says skipping tests doesn't need review. :)
Add new tests from r43759 to windows and tiger skipped lists until bug 25816 can be resolved.
https://bugs.webkit.org/show_bug.cgi?id=25816
Original bug: http://bugs.webkit.org/show_bug.cgi?id=25464
- platform/win/Skipped:
- platform/mac-tiger/Skipped:
- 1:08 AM Changeset in webkit [43761] by
-
- 16 edits in trunk/WebCore
2009-05-15 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Finish support for disabling the JavaScript Debugger and Profiler
at compile time in WebCore
https://bugs.webkit.org/show_bug.cgi?id=24917
- bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
- bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
- inspector/JavaScriptCallFrame.cpp: Ditto.
- inspector/JavaScriptCallFrame.h: Ditto.
- inspector/JavaScriptCallFrame.idl: Ditto.
- inspector/JavaScriptDebugListener.h: Ditto.
- inspector/JavaScriptDebugServer.cpp: Ditto.
- inspector/JavaScriptDebugServer.h: Ditto.
- inspector/JavaScriptProfile.cpp: Ditto.
- inspector/JavaScriptProfile.h: Ditto.
- inspector/JavaScriptProfileNode.cpp: Ditto.
- inspector/JavaScriptProfileNode.h: Ditto.
- page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
- page/Console.h: Ditto.
- page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)
- 12:55 AM Changeset in webkit [43760] by
-
- 6 edits in trunk
2009-05-15 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[GTK] Implement layoutTestController.waitForPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=25036
Connect to 'navigation-policy-decision-requested' and handle
waitForPolicy in the callback.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (invalidateAnyPreviousWaitToDumpWatchdog): (webViewNavigationPolicyDecisionRequested): (main):
- DumpRenderTree/gtk/DumpRenderTreeGtk.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::notifyDone): (LayoutTestController::waitForPolicyDelegate):
- 12:49 AM Changeset in webkit [43759] by
-
- 3 edits8 adds in trunk
2009-05-15 Jungshik Shin <jshin@chromium.org>
Reviewed by Dimitri Glazkov
Improve the font fallback for characters belonging to 'common' scripts
in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
marks in North Indian scripts) and currency signs (e.g. Thai Baht)
rendered correctly in Chromium on Win.
Tests: fast/text/international/danda-space.html
fast/text/international/thai-baht-space.html
- platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::FontMap::getScriptBasedOnUnicodeBlock): (WebCore::FontMap::getScript): (WebCore::getFallbackFamily):
- 12:06 AM Changeset in webkit [43758] by
-
- 2 edits in trunk/WebCore
2009-05-15 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25731
[Qt] Cleanup - move files exclusive to XPATH and XSLT under the
appropriate build section
- WebCore.pro:
- 12:02 AM Changeset in webkit [43757] by
-
- 1 edit in trunk/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp
Partial revert of 43604. Turns out we need some V8 magic for this to work right.
- 12:02 AM Changeset in webkit [43756] by
-
- 2 edits in trunk/WebCore
2009-05-14 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel and Darin Fisher.
Fix a font-related leak in Chromium's Skia backend found by Valgrind.
https://bugs.webkit.org/show_bug.cgi?id=25760
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters): Use caches instead of "new" on every call.
May 14, 2009:
- 10:38 PM Changeset in webkit [43755] by
-
- 2 edits in trunk/WebCore
2009-05-14 Rahul Kuchhal <kuchhal@chromium.org>
Reviewed by Eric Seidel.
Initialize m_spreadMethod in the second constructor too. Not sure if
a test case can be written, so no test case.
https://bugs.webkit.org/show_bug.cgi?id=25814
- platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient):
- 10:19 PM Changeset in webkit [43754] by
-
- 4 edits1 delete in trunk/LayoutTests
No review, rollout only.
Roll out r43753 as it caused a test to fail
Turns out more than one test was using the modified JS file.
- editing/pasteboard/paste-blockquote-before-blockquote-expected.txt:
- editing/pasteboard/paste-blockquote-before-blockquote.html:
- editing/pasteboard/resources/TEMPLATE.html: Removed.
- editing/pasteboard/resources/paste-blockquote-before-blockquote.js: (copyAndPasteNode):
- 9:34 PM Changeset in webkit [43753] by
-
- 4 edits1 add in trunk/LayoutTests
2009-05-14 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25716
Convert a test located in the resources directory into being a regular js test,
so we can add add more tests there and run make-js-test-wrappers without clobbering this one.
- editing/pasteboard/paste-blockquote-before-blockquote-expected.txt:
- editing/pasteboard/paste-blockquote-before-blockquote.html:
- editing/pasteboard/resources/TEMPLATE.html: Added.
- editing/pasteboard/resources/paste-blockquote-before-blockquote.js: (createLine): (copyAndPasteNode):
- 8:54 PM Changeset in webkit [43752] by
-
- 3 edits in trunk/WebCore
2009-05-14 Simon Fraser <Simon Fraser>
No review.
Fix Windows build after renaming MediaControlElements to MediaControlElementType.
- rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
- rendering/RenderMediaControls.h:
- 8:44 PM Changeset in webkit [43751] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-14 Gavin Barraclough <barraclough@apple.com>
Build fix, not reviewed.
Quick fixes for JIT builds with OPTIMIZE flags disabled.
- jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compilePutByIdHotPath):
- 8:33 PM Changeset in webkit [43750] by
-
- 90 edits in tags/Safari-6530.10.1/JavaScriptCore
Merge r43749.
- 8:29 PM Changeset in webkit [43749] by
-
- 3 edits in trunk/JavaScriptCore
Back out incorrect Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore.make:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 8:16 PM Changeset in webkit [43748] by
-
- 1 copy in tags/Safari-6530.10.1
New tag.
- 8:10 PM Changeset in webkit [43747] by
-
- 3 edits in trunk/WebCore
2009-05-14 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
<rdar://problem/6739671> Movie controller’s play button does not change into a pause
button
Fix a controls repaint issue when the playing state of a video changes by
educating the MediaControlInputElements about the state they are currently
displaying, and making them repaint when that state changes. This applies
to the play/pause and mute/unmute buttons, which both have two states.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Pass in and initialize the MediaControlElementType.
(WebCore::MediaControlInputElement::update):
Update the display type too
(WebCore::MediaControlInputElement::setDisplayType):
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlMuteButtonElement::updateDisplayType):
Choose muted vs. unmuted display.
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlPlayButtonElement::updateDisplayType):
Choose play vs. paused display.
- rendering/MediaControlElements.h: Renamed the MediaControlElements enum to MediaControlElementType. (WebCore::MediaControlInputElement::updateDisplayType): Add a MediaControlElementType member variable with a setter to allow the element to know what type it is displaying.
- 8:02 PM Changeset in webkit [43746] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a failure in fast/js/math-transforms.html caused by failing to
preserve -0 in multiplication.
- assembler/X86Assembler.h: (JSC::X86Assembler::jz):
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitMul32Constant): (JSC::JIT::emitMul32InPlace): Check both for overflow and for zero when doing multiplication. Use a slow case to get these right.
- 7:07 PM Changeset in webkit [43745] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a bug in the varargs calling convention.
- jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): Move the argument count into regT1, since that's where ctiVirtualCall expects it to be.
- 5:51 PM Changeset in webkit [43744] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a small bug in instanceof's looping code.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): NULL means the object has no prototype, so only loop when *not* equal to NULL.
- 5:38 PM Changeset in webkit [43743] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a small bug in instanceof's result writing code.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): Make sure to fill out the payload bits in all cases.
- 5:09 PM Changeset in webkit [43742] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Removed an invalid assertion in cti_op_urshift which
depended on a fast path for op_urshift which has
never existed.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_urshift):
- 5:04 PM Changeset in webkit [43741] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed loop_if_true, which had the same reversed test that jtrue had.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_true):
- 4:56 PM Changeset in webkit [43740] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
In op_neq, we apparently want to check that one value
does *not* equal another. Go figure.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_neq):
- 4:14 PM Changeset in webkit [43739] by
-
- 5 edits8 adds in trunk
2009-05-14 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
Add support for aspect-ratio and orientation
media queries.
Tests: fast/media/mq-aspect-ratio.html
fast/media/mq-orientation.html
- css/MediaFeatureNames.h:
- css/MediaQueryEvaluator.cpp: (WebCore::orientationMediaFeatureEval): (WebCore::aspect_ratioMediaFeatureEval): (WebCore::min_aspect_ratioMediaFeatureEval): (WebCore::max_aspect_ratioMediaFeatureEval):
- css/MediaQueryExp.h: (WebCore::MediaQueryExp::isViewportDependent):
- 4:04 PM Changeset in webkit [43738] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
The slow case of op_mod should call op_mod's jit stub,
not op_mul. That would be dumb.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_mod):
- 4:04 PM Changeset in webkit [43737] by
-
- 4 edits9 copies in trunk
WebCore:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
- Resubmitting previous patch, correctly this time.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode):
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
LayoutTests:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
- Resubmitting previous patch, correctly this time.
- editing/execCommand/outdent-blockquote-test1.html: Copied from editing/execCommand/outdent-blockquote-test1.html.
- editing/execCommand/outdent-blockquote-test2.html: Copied from editing/execCommand/outdent-blockquote-test2.html.
- editing/execCommand/outdent-blockquote-test3.html: Copied from editing/execCommand/outdent-blockquote-test3.html.
- editing/execCommand/outdent-blockquote-test4.html: Copied from editing/execCommand/outdent-blockquote-test4.html.
- platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt.
- platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt.
- platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt.
- platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt.
- platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt.
- 4:03 PM Changeset in webkit [43736] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed problems when using 'arguments' due to a half-initialized register.
- interpreter/CallFrame.h: (JSC::ExecState::setCalleeArguments): (JSC::ExecState::init): Require a full JSValue when setting up the 'arguments' virtual register, since this register is accessible from JIT code and bytecode, and needs to be a true JSValue.
- interpreter/CallFrameClosure.h: (JSC::CallFrameClosure::resetCallFrame): ditto
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): ditto
- interpreter/Register.h: Removed the constructor that allowed assignment of a JSArguments* to a register. That is not safe. See above.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_create_arguments): (JSC::JITStubs::cti_op_create_arguments_no_params): ditto
- 3:18 PM Changeset in webkit [43735] by
-
- 4 edits in trunk
Versioning.
- 3:17 PM Changeset in webkit [43734] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
We really want to go to the slow case in op_jfalse and
op_jtrue if the value is *not* boolean.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
- 3:08 PM Changeset in webkit [43733] by
-
- 3 edits in tags/Safari-6530.10/JavaScriptCore
Merge r43711.
- 2:56 PM Changeset in webkit [43732] by
-
- 5 edits9 deletes in trunk
WebCore:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
- Rolling out to fix a bug and the build
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode):
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
LayoutTests:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
- Rolled out for bug and build fix.
- editing/execCommand/outdent-blockquote-test1.html: Removed.
- editing/execCommand/outdent-blockquote-test2.html: Removed.
- editing/execCommand/outdent-blockquote-test3.html: Removed.
- editing/execCommand/outdent-blockquote-test4.html: Removed.
- platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Removed.
- platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Removed.
- platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Removed.
- platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Removed.
- platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Removed.
- 2:40 PM Changeset in webkit [43731] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Flipped the condition when emitting a an op_loop_if_less or op_loop_if_lesseq
if the first operand is a constant.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq):
- 2:28 PM Changeset in webkit [43730] by
-
- 1 copy in tags/Safari-6530.10
New tag.
- 2:28 PM Changeset in webkit [43729] by
-
- 4 edits9 adds in trunk
WebCore:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6510362> In some situations message content is messed up
when indentation is decreased
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively here served to do nothing because this function will return if the second argument is the parent of the first. Not only does this now work as intended, but is necessary for the rest of this fix.
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we are the last node in a <blockquote>, and can therefore remove the <blockquote> we need the endOfEnclosingBlock to extend to the end of the <blockquote> not just the next block, which could be a <div>, for example.
- Also If a <blockquote> is removed, but it's the child of another <blockquote> then its children are now children of the top <blockquote>. In this case we want to split the parent <blockquote> because the next paragraph assumes that it is the first node in its <blockquote> and if that is not true, various bugs arise.
LayoutTests:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6510362> In some situations message content is messed up
when indentation is decreased
- These tests are the various combinations of <blockquote>s that revealed bugs in our old logic.
- editing/execCommand/outdent-blockquote-test1.html: Added.
- editing/execCommand/outdent-blockquote-test2.html: Added.
- editing/execCommand/outdent-blockquote-test3.html: Added.
- editing/execCommand/outdent-blockquote-test4.html: Added.
- platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
- platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
- platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
- platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
- platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Added.
- 1:50 PM Changeset in webkit [43728] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Added missing return in op_jnless and op_jnlesseq.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq):
- 1:47 PM Changeset in webkit [43727] by
-
- 2 edits in trunk/WebKit/mac
2009-05-14 David Hyatt <hyatt@apple.com>
Reviewed by Tim Hatcher.
Fix for <rdar://problem/6886217> REGRESSION (S4 beta-ToT): Adium chat window contents no longer resize.
Technically this is a bug in Adium. It appears that Adium has subclassed the WebView and implemented
viewDidMoveToWindow in its subclass improperly. It doesn't call up to the base class WebView like it
should and so our boundsChanged notification never gets added.
Reduce the dependence on viewDidMoveToWindow by moving the registration of observers into
viewWillMoveToWindow instead.
- WebView/WebView.mm: (-[WebView addSizeObserversForWindow:]): (-[WebView removeWindowObservers]): (-[WebView addWindowObserversForWindow:]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]): (-[WebView viewDidMoveToSuperview]):
- 1:42 PM Changeset in webkit [43726] by
-
- 2 edits in trunk/WebCore
2009-05-14 Brady Eidson <beidson@apple.com>
Build fix.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::setDefaultMIMEType):
- 1:34 PM Changeset in webkit [43725] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Load constants into the the register file as a temorary measure to
aid bring up. This allows us to use to treat constants like any
other virtual register.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
- 1:09 PM Changeset in webkit [43724] by
-
- 2 edits in trunk/WebCore
2009-05-14 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben.
Fix http/tests/xmlhttprequest/cache-override.html on Windows
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data. (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed. (WebCore::WebCoreSynchronousLoader::load): Ditto.
- 12:55 PM Changeset in webkit [43723] by
-
- 2 edits in trunk/WebCore
2009-05-14 Paul Godavari <paul@chromium.org>
Reviewed by Dimitri Glazkov.
Bug: Mac Chromium popup menus are not positioned correctly
on scrolled pages:
https://bugs.webkit.org/show_bug.cgi?id=25772
Fix Mac Chromium popup menu placement by taking into
account any scrolling in the current window. This mirrors
the positioning done in PopupContainer::show(), which is
used on Chromium Windows and linux.
Also fixed indenting for this method.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showExternal):
- 12:55 PM Changeset in webkit [43722] by
-
- 1 edit1 add in trunk/WebCore
2009-05-14 Drew Wilson <atwilson@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25774
Upstream V8MessagePortCustom.cpp from the chromium repository.
- bindings/v8/custom/V8MessagePortCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- 12:54 PM Changeset in webkit [43721] by
-
- 6 edits in trunk
WebKit/mac:
2009-05-14 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Allow the local cache directory to be set using a defaults key.
- Misc/WebKitNSStringExtras.h:
- Misc/WebKitNSStringExtras.m: (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
- WebKit.exp:
WebKitTools:
2009-05-14 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Make paths where data is saved be scoped to the ~ directory,
so that one can run independent instances by setting CFFIXED_USER_HOME.
- DumpRenderTree/mac/DumpRenderTree.mm: (libraryPath): (setDefaultsToConsistentValuesForTesting): (dumpFrameAsPDF):
- 12:21 PM Changeset in webkit [43720] by
-
- 3 edits4 adds in trunk
2009-05-14 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
StyleGeneratedImage::imageSize() needs to take zooming into account for
fixed-size images (i.e. canvas) so that canvas-as-image-background
renders correctly with zooming.
Test: fast/canvas/canvas-bg-zoom.html
- rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::imageSize):
- 12:09 PM Changeset in webkit [43719] by
-
- 3 edits4 adds in trunk
Reviewed by Darin Adler.
Patch originally by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25796
<rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().
Test: http/tests/security/credentials-in-referer.html
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in SubresourceLoader::create() anyway.
- 12:07 PM Changeset in webkit [43718] by
-
- 2 edits in trunk/LayoutTests
2009-05-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disabling tests that are failing intermittently.
- platform/gtk/Skipped:
- 12:01 PM Changeset in webkit [43717] by
-
- 6 edits in trunk
Bug 25797: Pages with image maps are not properly read with Voiceover
https://bugs.webkit.org/show_bug.cgi?id=25797
- 11:56 AM Changeset in webkit [43716] by
-
- 6 edits in trunk
WebCore:
2009-05-14 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790
Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::shouldContentSniff):
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType): (WebCore::didReceiveResponse):
LayoutTests:
2009-05-14 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790
- platform/win/Skipped: Renable these tests.
- 10:51 AM Changeset in webkit [43715] by
-
- 8 edits2 adds in trunk
2009-05-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25791
Bug 25791: HTMLMediaElement: implement 'startTime' attribute
Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only
value that only the media engine can know, so we just need to add the attribute
to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so
the engine can make it available.
Test: media/media-startTime.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::startTime): New.
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::startTime): New.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::startTime): New.
2009-05-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25791
Bug 25791: HTMLMediaElement: implement 'startTime' attribute
Add test for 'startTime' attribute.
- media/media-startTime-expected.txt: Added.
- media/media-startTime.html: Added.
- 10:44 AM Changeset in webkit [43714] by
-
- 2 edits in trunk/WebKit/qt
2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Ariya Hidayat.
Add a comment to QWebView::iconChanged(), mentioning that you will
need to set the icon database path for icons to be loaded, and thus
receive the signal.
- Api/qwebview.cpp:
- 10:35 AM Changeset in webkit [43713] by
-
- 2 edits1 add in trunk/LayoutTests
2009-05-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
Move iframe content to a file because Chromium has
AllowLocalLoadsForLocalOnly enabled. This prevents the parent
frame from modifying the iframe content if it is a data: URL.
- fast/frames/content-opacity-2.html:
- fast/frames/resources/empty-body.html: Added.
- 10:34 AM Changeset in webkit [43712] by
-
- 2 edits in trunk/LayoutTests
Add a failing text control metrics test to the Windows Skipped file
See Bug 25794: fast/replaced/table-percent-height-text-controls fails
on Windows
<https://bugs.webkit.org/show_bug.cgi?id=25794>
- platform/win/Skipped: Added fast/replaced/table-percent-height-text-controls.html.
- 10:29 AM Changeset in webkit [43711] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore.make:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 10:27 AM Changeset in webkit [43710] by
-
- 2 edits in trunk/WebCore
2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Ariya Hidayat.
Only create a QWidget wrapper for the plugin in the case it is not
in the Qt window mapper, and thus receiving events from the Qt
event system. Native Qt based plugins running in process, will
already be in the window mapper, and thus creating a wrapper,
stops them from getting events from Qt, as they are redirected
to the wrapper.
- 9:45 AM Changeset in webkit [43709] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25784
Leaks seen on HTTP tests
We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for disabling content sniffing, matching the normal code path. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user and m_pass before overwriting. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
- 9:39 AM Changeset in webkit [43708] by
-
- 2 edits in trunk/WebKit/mac
2009-05-14 Darin Adler <Darin Adler>
Reviewed by Adam Roben.
<rdar://problem/6879999> Automator actions that use WebKit on a background thread fail when run outside of Automator
- WebView/WebView.mm: (clientNeedsWebViewInitThreadWorkaround): Added. Contains new broader rule. (needsWebViewInitThreadWorkaround): Changed to call clientNeedsWebViewInitThreadWorkaround.
- 9:14 AM Changeset in webkit [43707] by
-
- 2 edits in trunk/WebCore
2009-05-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25418
Remove new lines from event handler wrapper to make line numbers
in the wrapped script conside with the lines in the original script.
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
- 9:11 AM Changeset in webkit [43706] by
-
- 2 edits in trunk/LayoutTests
Add a timing-out test to the Windows Skipped file
See Bug 25792: fast/encoding/percent-escaping.html times out on
Windows
<https://bugs.webkit.org/show_bug.cgi?id=25792>
- platform/win/Skipped: Added fast/encoding/percent-escaping.html.
- 9:11 AM Changeset in webkit [43705] by
-
- 2 edits in trunk/WebCore
2009-05-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Alexey Proskuryakov.
Remove a JSC-specific include that is already added by including
ScriptController.
No change in behavior, so no tests.
- dom/Document.cpp: Removed JSDOMBinding include.
- 9:05 AM Changeset in webkit [43704] by
-
- 3 edits in trunk/WebCore
Reviewed by Brady Eidson.
<rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
Hopefully, a final stroke. When updating ResourceRequest from a platform request, a wrong
CFString function was used, so a user-friendly name was stored in encoding fallback array.
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest):
- 8:59 AM Changeset in webkit [43703] by
-
- 2 edits in trunk/LayoutTests
Add new Hebrew-using tests to the Windows Skipped file
See Bug 23925: Tests that use Hebrew text fail on Windows because
Lucida Grande is not used for Hebrew
<https://bugs.webkit.org/show_bug.cgi?id=23925>
- platform/win/Skipped: Added tests added in r43664.
- 8:23 AM Changeset in webkit [43702] by
-
- 2 edits in trunk/LayoutTests
Skip XHR tests that crash in Windows Debug builds
See:
Bug 25790: REGRESSION (r43518): Multiple XHR tests asserting in
createCFURLResponseWithDefaultMIMEType on Windows
<https://bugs.webkit.org/show_bug.cgi?id=25790>
Bug 25344: Some http tests crash in Debug Windows builds due to an
assertion in CFNetwork when releasing a CFURLConnection
<https://bugs.webkit.org/show_bug.cgi?id=25344>
- platform/win/Skipped: Added crashing XHR tests.
- 8:19 AM Changeset in webkit [43701] by
-
- 2 edits in trunk/WebKit/qt
2009-05-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Ariya Hidayat.
Fix setHtml test case by adding <head> tag to the expected result. This tag is automatically added by WebKit.
- tests/qwebframe/tst_qwebframe.cpp:
- 8:04 AM Changeset in webkit [43700] by
-
- 3 edits in trunk/JavaScriptCore
Windows jsc build fix
r43648 modified jsc.vcproj's post-build event not to try to copy files
that aren't present. Then r43661 mistakenly un-did that modification.
This patch restores the modification from r43648, but puts the code in
jscCommon.vsprops (where it should have been added in r43648).
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Restored empty VCPostBuildEventTool tags.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Modified the post-build event command line to match the one in jsc.vcproj from r43648.
- 7:49 AM Changeset in webkit [43699] by
-
- 29 edits in trunk/WebCore
2009-05-14 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
Add more ENABLE_DATABASE guards.
https://bugs.webkit.org/show_bug.cgi?id=25616
See also https://bugs.webkit.org/show_bug.cgi?id=24776 (original set of guards)
- bindings/js/JSSQLResultSetRowListCustom.cpp:
- bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
- bindings/v8/custom/V8CustomSQLStatementCallback.h:
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
- bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
- bindings/v8/custom/V8CustomSQLTransactionCallback.h:
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
- bindings/v8/custom/V8DatabaseCustom.cpp:
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
- storage/Database.cpp:
- storage/DatabaseDetails.h:
- storage/OriginUsageRecord.cpp:
- storage/OriginUsageRecord.h:
- storage/SQLError.h:
- storage/SQLError.idl:
- storage/SQLResultSet.cpp:
- storage/SQLResultSet.h:
- storage/SQLResultSet.idl:
- storage/SQLResultSetRowList.cpp:
- storage/SQLResultSetRowList.h:
- storage/SQLResultSetRowList.idl:
- storage/SQLStatementCallback.h:
- storage/SQLStatementErrorCallback.h:
- storage/SQLTransactionCallback.h:
- storage/SQLTransactionErrorCallback.h:
- 7:23 AM Changeset in webkit [43698] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-14 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Make sure pthread_self() is declared before it gets called in Collector.cpp
- runtime/Collector.cpp: Include pthread.h in most Unix-like platforms (not just for OPENBSD)
- 7:22 AM Changeset in webkit [43697] by
-
- 2 edits in trunk/WebCore
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin Adler.
Gtk was the last platform to not unregister plugins when
the plugin is stopped. Catch up with r43550.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::stop):
- 7:17 AM Changeset in webkit [43696] by
-
- 2 edits in trunk/WebKit/qt
2009-05-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Ariya Hidayat.
Add a test case for the signal urlChanged().
- tests/qwebframe/tst_qwebframe.cpp:
- 7:10 AM Changeset in webkit [43695] by
-
- 2 edits in trunk/WebCore
Make WebCore.vcproj's pre-build event work again
- WebCore.vcproj/WebCore.vcproj: Removed empty override of the pre-build event that was accidentally left in when the pre-build event was moved to WebCoreCommon.vsprops.
- 6:29 AM Changeset in webkit [43694] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove old render tree dumps for http tests that are now text-only
Beth made the tests text-only in r43677 but forgot to remove these
Windows-specific render tree dumps.
Rubber-stamped by Dave Hyatt.
- platform/win/http/tests/navigation/anchor-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/anchor-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/anchor-subframeload-expected.txt: Removed.
- platform/win/http/tests/navigation/javascriptlink-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/javascriptlink-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/javascriptlink-subframeload-expected.txt: Removed.
- platform/win/http/tests/navigation/metaredirect-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/metaredirect-frames-expected.txt: Removed.
- platform/win/http/tests/navigation/metaredirect-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/metaredirect-subframeload-expected.txt: Removed.
- platform/win/http/tests/navigation/post-goback2-expected.txt: Removed.
- platform/win/http/tests/navigation/postredirect-goback2-expected.txt: Removed.
- platform/win/http/tests/navigation/redirect302-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/redirect302-frames-expected.txt: Removed.
- platform/win/http/tests/navigation/redirect302-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/redirect302-subframeload-expected.txt: Removed.
- platform/win/http/tests/navigation/relativeanchor-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/relativeanchor-frames-expected.txt: Removed.
- platform/win/http/tests/navigation/relativeanchor-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/slowmetaredirect-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/slowtimerredirect-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-frames-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-frames-loadsame-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-loadsame-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-reload-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-subframeload-expected.txt: Removed.
- platform/win/http/tests/navigation/timerredirect-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/timerredirect-frames-expected.txt: Removed.
- platform/win/http/tests/navigation/timerredirect-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/timerredirect-subframeload-expected.txt: Removed.
- 4:50 AM Changeset in webkit [43693] by
-
- 3 edits1 add in trunk
WebCore:
2009-05-14 Darin Adler <Darin Adler>
- manual-tests/right-click-crash.html: Added.
WebKit/mac:
2009-05-14 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
Bug 24049: Second right-click crashes safari when alert invoked
https://bugs.webkit.org/show_bug.cgi?id=24049
rdar://problem/6878977
- WebView/WebHTMLView.mm: (-[WebHTMLView rightMouseUp:]): Added a retain/autorelease of the event. (-[WebHTMLView menuForEvent:]): Ditto. Also cleaned up the logic here and eliminated some use of pointers that might be invalid after calling through to WebCore. (-[WebHTMLView scrollWheel:]): Ditto. (-[WebHTMLView acceptsFirstMouse:]): Ditto. (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Ditto. (-[WebHTMLView mouseDown:]): Ditto. (-[WebHTMLView mouseDragged:]): Ditto. (-[WebHTMLView mouseUp:]): Ditto. (-[WebHTMLView keyDown:]): Ditto. (-[WebHTMLView keyUp:]): Ditto. (-[WebHTMLView flagsChanged:]): Ditto. (-[WebHTMLView performKeyEquivalent:]): Ditto.
- 4:14 AM Changeset in webkit [43692] by
-
- 4 edits in trunk/JavaScriptCore
Fix <https://bugs.webkit.org/show_bug.cgi?id=25785>. Bug 25785: Segfault in mark when using JSObjectMakeConstructor
Reviewed by Oliver Hunt.
- API/JSObjectRef.cpp:
(JSObjectMakeConstructor): OpaqueJSClass::prototype can return 0. We need to use the default object prototype when it does.
- API/tests/testapi.c:
(main): Add a test case.
- runtime/JSObject.h:
(JSC::JSObject::putDirect): Add a clearer assertion for a null value. The assertion on the next line does catch this,
but the cause of the failure is not clear from the assertion itself.
- 4:14 AM Changeset in webkit [43691] by
-
- 8 edits in trunk
<rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2
Rubber-stamped by Darin Adler.
The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.
- 3:55 AM Changeset in webkit [43690] by
-
- 2 edits in trunk/LayoutTests
2009-05-14 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Added new tests to the skipped list.
- 1:58 AM Changeset in webkit [43689] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Checking register file bounds should be a ptr comparison (m_end is a Register*).
Also, the compare should be unsigned, pointers don'ts go negative.
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- 1:21 AM Changeset in webkit [43688] by
-
- 7 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented op_strict_eq. Original patch by Snowy, by way of Sam and Gavin.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::set8): Added set8, since it's slightly faster than set32, and the new value representation usually doesn't need set32.
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadTag): (JSC::JIT::emitLoadPayload): Added helper functions for dealing with constants. Eventually, we should write special cases for all constants, but these are helpful in the short term.
- jit/JITOpcodes.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlow_op_stricteq): (JSC::JIT::emitSlow_op_nstricteq): teh opcodez.
- runtime/JSValue.h: (JSC::JSValue::): (JSC::JSValue::isDouble): Added a LowestTag for clarity.
May 13, 2009:
- 11:25 PM Changeset in webkit [43687] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed some bugs in host function calls.
testapi now passes!
- jit/JIT.cpp: Changed some registers around to avoid overwriting edx:eax, which is how JSValues are now returned. Also changed the code that passes thisValue to pass the full 64bits of the value. Also added an #error compiler directive to other platform builds, since the JSValue return signature probably won't return in edx:eax on those platforms, and we'll have to investigate a solution.
- 10:44 PM Changeset in webkit [43686] by
-
- 3 edits in trunk/LayoutTests
2009-05-13 Simon Fraser <Simon Fraser>
No review.
Fix pixel result after test was changed in r43664.
- platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
- platform/mac/fast/css/text-overflow-ellipsis-expected.png:
- 10:12 PM Changeset in webkit [43685] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed parameters from functions that are intended never to use their
parameters.
- jit/JITPropertyAccess.cpp: (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emitSlow_op_put_by_val):
- 9:39 PM Changeset in webkit [43684] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Ported op_instance_of from TOT. It's basically the same, but some register
stuff changed to memory stuff.
- jit/JITInlineMethods.h: (JSC::JIT::emitPutJITStubArgFromVirtualRegister): (JSC::JIT::emitStore): Changed to use helper functions.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof): Ported from TOT.
- 9:00 PM Changeset in webkit [43683] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Added a comment to explain an exception-handling subtelty that we found
hard to remember when reviewing my last patch.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
- 8:52 PM Changeset in webkit [43682] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented try/catch.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw): Updated to use JITStackFrame abstraction. (JSC::JIT::emit_op_catch): Filled out.
- 7:38 PM Changeset in webkit [43681] by
-
- 2 edits in trunk/WebCore
2009-05-13 Anders Carlsson <andersca@apple.com>
Fix build.
- WebCore.NPAPI.exp:
- 7:21 PM Changeset in webkit [43680] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implemented op_loop_if_true, op_jfalse, op_jtrue, op_jeq_null and op_jneq_null
- jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_instanceof): Moved from below to be next to its fast brother.
(JSC::JIT::emit_op_loop_if_true): Similar to the old version
in that it tries to do the integer case first and reduce the
number of jumps you might need to take.
(JSC::JIT::emitSlow_op_loop_if_true):
(JSC::JIT::emit_op_jfalse): Very similar to op_loop_if_true, only
the inverse and without a timeout check.
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue): Very similar to op_loop_if_true except
without the timeout check.
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null): Very similar to the implementation
of op_eq, except it takes jumps instead of copying the condition
to a dst.
(JSC::JIT::emit_op_jneq_null): Ditto but for op_neq.
- 7:06 PM Changeset in webkit [43679] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented op_call_varargs.
- jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargsSetupArgs): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::emit_op_call): (JSC::JIT::emit_op_call_eval): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emit_op_call_varargs): (JSC::JIT::emit_op_construct):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jneq_ptr):
- 6:44 PM Changeset in webkit [43678] by
-
- 5 edits in trunk/WebCore
Reviewed by Oliver Hunt.
Fix invalid memory write seen in HTMLCanvasElement by Valgrind
https://bugs.webkit.org/show_bug.cgi?id=25759
I can't think of any way to catch this with a layout test, so no test.
- css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasDestroyed):
- css/CSSCanvasValue.h:
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
- html/HTMLCanvasElement.h:
- 6:14 PM Changeset in webkit [43677] by
-
- 33 edits32 adds96 deletes in trunk/LayoutTests
2009-05-13 Beth Dakin <Beth Dakin>
Rubber-stamped by Oliver Hunt.
Change a bunch of http tests to dumpAsText(). They are currently
failing on the Windown Build Bot because of textarea metrics
changes, and we have decided that these tests are most valuable as
text test anyway.
- http/tests/navigation/anchor-basic-expected.txt: Added.
- http/tests/navigation/anchor-basic.html:
- http/tests/navigation/anchor-goback-expected.txt: Added.
- http/tests/navigation/anchor-goback.html:
- http/tests/navigation/anchor-subframeload-expected.txt: Added.
- http/tests/navigation/anchor-subframeload.html:
- http/tests/navigation/javascriptlink-basic-expected.txt: Added.
- http/tests/navigation/javascriptlink-basic.html:
- http/tests/navigation/javascriptlink-goback-expected.txt: Added.
- http/tests/navigation/javascriptlink-goback.html:
- http/tests/navigation/javascriptlink-subframeload-expected.txt: Added.
- http/tests/navigation/javascriptlink-subframeload.html:
- http/tests/navigation/metaredirect-basic-expected.txt: Added.
- http/tests/navigation/metaredirect-basic.html:
- http/tests/navigation/metaredirect-frames-expected.txt: Added.
- http/tests/navigation/metaredirect-frames.html:
- http/tests/navigation/metaredirect-goback-expected.txt: Added.
- http/tests/navigation/metaredirect-goback.html:
- http/tests/navigation/metaredirect-subframeload-expected.txt: Added.
- http/tests/navigation/metaredirect-subframeload.html:
- http/tests/navigation/post-goback2-expected.txt: Added.
- http/tests/navigation/post-goback2.html:
- http/tests/navigation/postredirect-goback2-expected.txt: Added.
- http/tests/navigation/postredirect-goback2.html:
- http/tests/navigation/redirect302-basic-expected.txt: Added.
- http/tests/navigation/redirect302-basic.html:
- http/tests/navigation/redirect302-frames-expected.txt: Added.
- http/tests/navigation/redirect302-frames.html:
- http/tests/navigation/redirect302-goback-expected.txt: Added.
- http/tests/navigation/redirect302-goback.html:
- http/tests/navigation/redirect302-subframeload-expected.txt: Added.
- http/tests/navigation/redirect302-subframeload.html:
- http/tests/navigation/relativeanchor-basic-expected.txt: Added.
- http/tests/navigation/relativeanchor-basic.html:
- http/tests/navigation/relativeanchor-frames-expected.txt: Added.
- http/tests/navigation/relativeanchor-frames.html:
- http/tests/navigation/relativeanchor-goback-expected.txt: Added.
- http/tests/navigation/relativeanchor-goback.html:
- http/tests/navigation/slowmetaredirect-basic-expected.txt: Added.
- http/tests/navigation/slowmetaredirect-basic.html:
- http/tests/navigation/slowtimerredirect-basic-expected.txt: Added.
- http/tests/navigation/slowtimerredirect-basic.html:
- http/tests/navigation/success200-basic-expected.txt: Added.
- http/tests/navigation/success200-basic.html:
- http/tests/navigation/success200-frames-expected.txt: Added.
- http/tests/navigation/success200-frames-loadsame-expected.txt: Added.
- http/tests/navigation/success200-frames-loadsame.html:
- http/tests/navigation/success200-frames.html:
- http/tests/navigation/success200-goback-expected.txt: Added.
- http/tests/navigation/success200-goback.html:
- http/tests/navigation/success200-loadsame-expected.txt: Added.
- http/tests/navigation/success200-loadsame.html:
- http/tests/navigation/success200-reload-expected.txt: Added.
- http/tests/navigation/success200-reload.html:
- http/tests/navigation/success200-subframeload-expected.txt: Added.
- http/tests/navigation/success200-subframeload.html:
- http/tests/navigation/timerredirect-basic-expected.txt: Added.
- http/tests/navigation/timerredirect-basic.html:
- http/tests/navigation/timerredirect-frames-expected.txt: Added.
- http/tests/navigation/timerredirect-frames.html:
- http/tests/navigation/timerredirect-goback-expected.txt: Added.
- http/tests/navigation/timerredirect-goback.html:
- http/tests/navigation/timerredirect-subframeload-expected.txt: Added.
- http/tests/navigation/timerredirect-subframeload.html:
- platform/mac/http/tests/navigation/anchor-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/anchor-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/anchor-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/anchor-goback-expected.checksum: Removed.
- platform/mac/http/tests/navigation/anchor-goback-expected.png: Removed.
- platform/mac/http/tests/navigation/anchor-goback-expected.txt: Removed.
- platform/mac/http/tests/navigation/anchor-subframeload-expected.checksum: Removed.
- platform/mac/http/tests/navigation/anchor-subframeload-expected.png: Removed.
- platform/mac/http/tests/navigation/anchor-subframeload-expected.txt: Removed.
- platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/javascriptlink-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum: Removed.
- platform/mac/http/tests/navigation/javascriptlink-goback-expected.png: Removed.
- platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt: Removed.
- platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum: Removed.
- platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png: Removed.
- platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt: Removed.
- platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/metaredirect-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/metaredirect-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum: Removed.
- platform/mac/http/tests/navigation/metaredirect-frames-expected.png: Removed.
- platform/mac/http/tests/navigation/metaredirect-frames-expected.txt: Removed.
- platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum: Removed.
- platform/mac/http/tests/navigation/metaredirect-goback-expected.png: Removed.
- platform/mac/http/tests/navigation/metaredirect-goback-expected.txt: Removed.
- platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum: Removed.
- platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png: Removed.
- platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt: Removed.
- platform/mac/http/tests/navigation/post-goback2-expected.checksum: Removed.
- platform/mac/http/tests/navigation/post-goback2-expected.png: Removed.
- platform/mac/http/tests/navigation/post-goback2-expected.txt: Removed.
- platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum: Removed.
- platform/mac/http/tests/navigation/postredirect-goback2-expected.png: Removed.
- platform/mac/http/tests/navigation/postredirect-goback2-expected.txt: Removed.
- platform/mac/http/tests/navigation/redirect302-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/redirect302-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/redirect302-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/redirect302-frames-expected.checksum: Removed.
- platform/mac/http/tests/navigation/redirect302-frames-expected.png: Removed.
- platform/mac/http/tests/navigation/redirect302-frames-expected.txt: Removed.
- platform/mac/http/tests/navigation/redirect302-goback-expected.checksum: Removed.
- platform/mac/http/tests/navigation/redirect302-goback-expected.png: Removed.
- platform/mac/http/tests/navigation/redirect302-goback-expected.txt: Removed.
- platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum: Removed.
- platform/mac/http/tests/navigation/redirect302-subframeload-expected.png: Removed.
- platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt: Removed.
- platform/mac/http/tests/navigation/relativeanchor-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/relativeanchor-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/relativeanchor-frames-expected.checksum: Removed.
- platform/mac/http/tests/navigation/relativeanchor-frames-expected.png: Removed.
- platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt: Removed.
- platform/mac/http/tests/navigation/relativeanchor-goback-expected.checksum: Removed.
- platform/mac/http/tests/navigation/relativeanchor-goback-expected.png: Removed.
- platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt: Removed.
- platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/success200-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/success200-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/success200-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/success200-frames-expected.checksum: Removed.
- platform/mac/http/tests/navigation/success200-frames-expected.png: Removed.
- platform/mac/http/tests/navigation/success200-frames-expected.txt: Removed.
- platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum: Removed.
- platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png: Removed.
- platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt: Removed.
- platform/mac/http/tests/navigation/success200-goback-expected.checksum: Removed.
- platform/mac/http/tests/navigation/success200-goback-expected.png: Removed.
- platform/mac/http/tests/navigation/success200-goback-expected.txt: Removed.
- platform/mac/http/tests/navigation/success200-loadsame-expected.checksum: Removed.
- platform/mac/http/tests/navigation/success200-loadsame-expected.png: Removed.
- platform/mac/http/tests/navigation/success200-loadsame-expected.txt: Removed.
- platform/mac/http/tests/navigation/success200-reload-expected.checksum: Removed.
- platform/mac/http/tests/navigation/success200-reload-expected.png: Removed.
- platform/mac/http/tests/navigation/success200-reload-expected.txt: Removed.
- platform/mac/http/tests/navigation/success200-subframeload-expected.checksum: Removed.
- platform/mac/http/tests/navigation/success200-subframeload-expected.png: Removed.
- platform/mac/http/tests/navigation/success200-subframeload-expected.txt: Removed.
- platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/timerredirect-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/timerredirect-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum: Removed.
- platform/mac/http/tests/navigation/timerredirect-frames-expected.png: Removed.
- platform/mac/http/tests/navigation/timerredirect-frames-expected.txt: Removed.
- platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum: Removed.
- platform/mac/http/tests/navigation/timerredirect-goback-expected.png: Removed.
- platform/mac/http/tests/navigation/timerredirect-goback-expected.txt: Removed.
- platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum: Removed.
- platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png: Removed.
- platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt: Removed.
- 6:10 PM Changeset in webkit [43676] by
-
- 12 edits in trunk/WebKit/mac
2009-05-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WebKit side of <rdar://problem/6884476>.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetLocation): Forward this to the plug-in instance proxy.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getLocation): Ask the plug-in view for the location.
- Plugins/Hosted/WebKitPluginClient.defs: Add MIG definition.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView locationStringForTarget:]): Return the URL for a given frame.
- Plugins/WebNetscapeContainerCheckPrivate.h: Bump version. Add new declaration to the vtable.
- Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs): Add new declaration to the vtable.
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView locationForTarget:]): Call the base class method.
- Plugins/npapi.mm: (WKN_GetLocation): Forward this to the plug-in view.
- 6:02 PM Changeset in webkit [43675] by
-
- 3 edits in trunk/WebKit/mac
2009-05-13 Douglas R. Davidson <ddavidso@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6871587> Smart Copy/Paste setting should persist as continuous
spell checking setting does
- WebView/WebPreferenceKeysPrivate.h: Added WebSmartInsertDeleteEnabled.
- WebView/WebView.mm: (-[WebViewPrivate init]): Initialize based on WebSmartInsertDeleteEnabled default. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Removed code that initialized here. (-[WebView setSmartInsertDeleteEnabled:]): Set default here was with continuous spell checking setting.
- 5:50 PM Changeset in webkit [43674] by
-
- 1 edit in branches/nitro-extreme/JavaScriptCore/ChangeLog
ChangeLog reverse-o
- 5:49 PM Changeset in webkit [43673] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Implemented op_not. (Gavin did most of the work!)
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_not): (JSC::JIT::emitSlow_op_not):
- 5:44 PM Changeset in webkit [43672] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Anders Carlsson.
- fix <rdar://problem/5483015> Replies in Mail are drawn first without the user style sheet and then redrawn with the style sheet
Test: platform/mac/fast/loader/user-stylesheet-fast-path.html
- page/mac/FrameMac.mm: (WebCore::Frame::setUserStyleSheetLocation): For data URLs with base64-encoded UTF-8 data, just decode the style sheet here an apply it synchronously instead of invoking an asynchronous loader.
LayoutTests:
Reviewed by Anders Carlsson.
- test for <rdar://problem/5483015> Replies in Mail are drawn first without the user style sheet and then redrawn with the style sheet
- platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt: Added.
- platform/mac/fast/loader/user-stylesheet-fast-path.html: Added.
- 5:11 PM Changeset in webkit [43671] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Implemented op_not. (Gavin did most of the work!)
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_not): (JSC::JIT::emitSlow_op_not):
- 4:50 PM Changeset in webkit [43670] by
-
- 2 edits in trunk/WebCore
Bug 25755: Implement ARIA grid role
https://bugs.webkit.org/show_bug.cgi?id=25755
Fix windows build bustage
- 4:44 PM Changeset in webkit [43669] by
-
- 24 edits9 adds in trunk
Bug 25755: Implement ARIA grid role
https://bugs.webkit.org/show_bug.cgi?id=25755
- 4:22 PM Changeset in webkit [43668] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented op_global_resolve.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): Added back accidentally removed early returns.
(JSC::JIT::emit_op_resolve_global):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_resolve_global): Pretty similar to the old code, but we need two reads and a TimesEight step in order to account for the 64bit value size.
- jit/JITStubs.h: (JSC::): Slightly tweaked this code to specialize for a JSGlobalObject*, to avoid having to pass an irrelevant tag pointer to the stub.
- 4:08 PM Changeset in webkit [43667] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Fix <rdar://problem/6882919> REGRESSION: page at Metroauto site crashes in cti_op_loop_if_less (25730)
op_loop_if_less (imm < op) was loading op into regT1, but in the slow path spills regT0.
This leads to bad happen.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emitSlow_op_loop_if_less):
- 3:44 PM Changeset in webkit [43666] by
-
- 1 edit1 move in trunk/WebCore
2009-05-13 David Levin <levin@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 25763: Need to move v8 custom binding to the custom directory.
https://bugs.webkit.org/show_bug.cgi?id=25763
No test due to no change in behavior.
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Renamed from WebCore/bindings/v8/V8CanvasPixelArrayCustom.cpp.
- 3:39 PM Changeset in webkit [43665] by
-
- 2 edits in trunk/WebCore
2009-05-13 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov.
Fix LayoutTests/fast/dom/Element/attr-param-typechecking.html crashing with V8.
https://bugs.webkit.org/show_bug.cgi?id=25758
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): return the result of throwError() if it is called.
- 3:30 PM Changeset in webkit [43664] by
-
- 14 edits8 adds in trunk
WebCore:
2009-05-13 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dave Hyatt.
Fix a number of bugs relating to RTL and text-overflow:ellipsis.
Also refactor the relevant code to make it a little clearer.
This CL fixes 3 fundamental issues:
- Corrects behavior if the truncated InlineTextBox's directionality is different from the overall flow direction - bug 25135.
- Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
- Full truncation on InlineBoxes in RTL flow - bug 24186
- Add tests for the above + reorder/cleanup tests for easier interpretation of outcome.
The code for placing ellipsis has been refactored to use
left/right notation rather than a single variable whose meaning
could differ based on flow directionality.
To support differing inline directionality vs flow directionality,
different variables are now used in InlineTextBox::placeEllipsisBox to
track the two.
The drawing mode for underlines in standards mode now correctly handles
RTL truncation and relevant test where added.
https://bugs.webkit.org/show_bug.cgi?id=24186
https://bugs.webkit.org/show_bug.cgi?id=25135
https://bugs.webkit.org/show_bug.cgi?id=24206
Tests: fast/css/text-overflow-ellipsis-bidi.html
fast/css/text-overflow-ellipsis-strict.html
- rendering/InlineBox.cpp: (WebCore::InlineBox::placeEllipsisBox):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): (WebCore::InlineFlowBox::placeEllipsisBox):
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::paint):
- rendering/InlineTextBox.h:
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::placeEllipsisBox):
- rendering/RootInlineBox.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow):
LayoutTests:
2009-05-13 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dave Hyatt.
Fix a number of bugs relating to RTL and text-overflow:ellipsis.
Also refactor the relevant code to make it a little clearer.
This CL fixes 3 fundamental issues:
- Corrects behavior if the truncated InlineTextBox's directionality is different from the overall flow direction - bug 25135.
- Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
- Full truncation on InlineBoxes in RTL flow - bug 24186
- Add tests for the above + reorder/cleanup tests for easier interpretation of outcome.
The code for placing ellipsis has been refactored to use
left/right notation rather than a single variable whose meaning
could differ based on flow directionality.
To support differing inline directionality vs flow directionality,
different variables are now used in InlineTextBox::placeEllipsisBox to
track the two.
The drawing mode for underlines in standards mode now correctly handles
RTL truncation and relevant test where added.
https://bugs.webkit.org/show_bug.cgi?id=24186
https://bugs.webkit.org/show_bug.cgi?id=25135
https://bugs.webkit.org/show_bug.cgi?id=24206
- fast/css/text-overflow-ellipsis-bidi.html: Added.
- fast/css/text-overflow-ellipsis-strict.html: Added.
- fast/css/text-overflow-ellipsis.html:
- platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added.
- platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
- platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added.
- platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
- platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
- platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt: Added.
- 3:09 PM Changeset in webkit [43663] by
-
- 23 edits in trunk
2009-05-13 Dmitry Titov <dimich@chromium.org>
Rubber-stamped by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=25746
Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- bytecode/SamplingTool.cpp: (JSC::SamplingThread::start): (JSC::SamplingThread::stop):
- bytecode/SamplingTool.h:
- wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::::ref): (WTF::::deref):
- wtf/Threading.h:
- wtf/ThreadingNone.cpp:
- wtf/ThreadingPthreads.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::pthreadHandleForIdentifier): (WTF::clearPthreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread):
- wtf/ThreadingWin.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::storeThreadHandleByIdentifier): (WTF::threadHandleForIdentifier): (WTF::clearThreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread):
- wtf/gtk/ThreadingGtk.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::identifierByGthreadHandle): (WTF::establishIdentifierForThread): (WTF::threadForIdentifier): (WTF::clearThreadForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
- wtf/qt/ThreadingQt.cpp: (WTF::threadMapMutex): (WTF::threadMap): (WTF::identifierByQthreadHandle): (WTF::establishIdentifierForThread): (WTF::clearThreadForIdentifier): (WTF::threadForIdentifier): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
WebCore:
2009-05-13 Dmitry Titov <dimich@chromium.org>
Rubber-stamped by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=25746
Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::matchFunc): (WebCore::openFunc): (WebCore::createStringParser): (WebCore::createMemoryParser):
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::close):
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::databaseThread):
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::localStorageThread): (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync): (WebCore::LocalStorageThread::terminate):
- workers/WorkerThread.cpp: (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start):
WebKit/win:
2009-05-13 Dmitry Titov <dimich@chromium.org>
Rubber-stamped by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=25746
Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
- WebKit.vcproj/WebKit.def:
- WebKit.vcproj/WebKit_debug.def:
- 2:55 PM Changeset in webkit [43662] by
-
- 3 edits4 adds in trunk
WebCore:
2009-05-13 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
Fix for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus
Make sure to do rounded clipping for overflow and controls relative to the border box and not to the overflow/control clip rect
(which is typically clipped to the padding or content box). Doing so was causing rounded clips to be incorrectly applied to padding and
content.
Added fast/overflow/border-radius-clipping.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
LayoutTests:
2009-05-13 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
Add layout test for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus.
- fast/overflow/border-radius-clipping.html: Added.
- platform/mac/fast/overflow/border-radius-clipping-expected.checksum: Added.
- platform/mac/fast/overflow/border-radius-clipping-expected.png: Added.
- platform/mac/fast/overflow/border-radius-clipping-expected.txt: Added.
- 2:53 PM Changeset in webkit [43661] by
-
- 52 edits in trunk
2009-05-13 Darin Adler <Darin Adler>
Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).
WebCore:
2009-05-13 Darin Adler <Darin Adler>
Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).
WebKit/mac:
2009-05-13 Darin Adler <Darin Adler>
Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).
- 2:25 PM Changeset in webkit [43660] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implemented op_to_jsnumber.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emitSlow_op_to_jsnumber):
- 2:12 PM Changeset in webkit [43659] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.7
Tagging 1.1.7.
- 2:08 PM Changeset in webkit [43658] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt
uploading new results. when I added this test, i committed outdated results.
- 1:56 PM Changeset in webkit [43657] by
-
- 5 edits4 adds in trunk
WebCore:
2009-05-13 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin and Darin Adler.
Fix for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.
Make sure that renderers are marked for layout if a style change causes them to switch from having a self-painting layer
to a non-self-painting layer (and vice versa).
Move misplaced layer repainting code that was in RenderBox up into RenderBoxModelObject so that inlines with layers
repaint properly on opacity changes, etc.
Added fast/repaint/opacity-change-on-overflow-float.html.
- rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleWillChange): (WebCore::RenderBoxModelObject::styleDidChange):
- rendering/RenderBoxModelObject.h:
LayoutTests:
2009-05-13 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin and Darin Adler.
Add a repaint test for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.
- fast/repaint/opacity-change-on-overflow-float.html: Added.
- platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.checksum: Added.
- platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.png: Added.
- platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added.
- 1:49 PM Changeset in webkit [43656] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implemented op_convert_this.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_convert_this): (JSC::JIT::emitSlow_op_convert_this):
- 1:46 PM Changeset in webkit [43655] by
-
- 2 edits in trunk/LayoutTests
2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disable new tests. We are not going to be adding more new test
results for now, for we want to better sort out things such as
fixed DPI, and easily reproducible font configuration.
- platform/gtk/Skipped:
- 1:38 PM Changeset in webkit [43654] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-13 Darin Adler <Darin Adler>
Tiger build fix.
- parser/Grammar.y: Add back empty code blocks, needed by older versions of bison on certain rules.
- 1:31 PM Changeset in webkit [43653] by
-
- 8 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Got basic JS function and constructor calls working.
- jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITCall.cpp: (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallVarargsSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emitSlow_op_construct_verify): (JSC::JIT::emitSlow_op_call): (JSC::JIT::emitSlow_op_call_eval): (JSC::JIT::emitSlow_op_call_varargs): (JSC::JIT::emitSlow_op_construct): (JSC::JIT::compileOpCall): Filled out these cases, with call_eval #if'd out.
- jit/JITInlineMethods.h: (JSC::JIT::emitPutJITStubArgFromVirtualRegister): (JSC::JIT::emitLoad): Restored some legacy "*CTIArg*" functions, since I wanted to avoid the complexity of revamping the API here while trying to bring it up. Eventually, we should re-remove all of these functions.
(JSC::JIT::recordJumpTarget): Removed unnecessary macro cruft. You will
not silence me, Sam Weinig! The world will know that you are a crufty,
crufty, crufty programmer!!!
- jit/JITOpcodes.cpp:
- jit/JITStubs.cpp: (JSC::):
- jit/JITStubs.h: Changed up some offsets in the JITStackFrame class, since and off-by-one error was causing stack misalignment.
- 12:40 PM Changeset in webkit [43652] by
-
- 2 edits in trunk/WebCore
2009-05-13 Dimitri Glazkov <Dimitri Glazkov>
Not reviewed, build fix.
Move an include, needed by Debugger under the corresponding guard.
- inspector/InspectorController.cpp: Moved parser/SourceCode under JAVASCRIPT_DEBUGGER
guard.
- 12:38 PM Changeset in webkit [43651] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement op_eq_null and op_neq_null.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::set8): (JSC::MacroAssemblerX86Common::setTest8):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_stricteq): (JSC::JIT::emitSlow_op_stricteq): (JSC::JIT::emit_op_nstricteq): (JSC::JIT::emitSlow_op_nstricteq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
- jsc.cpp:
- 12:15 PM Changeset in webkit [43650] by
-
- 3 edits3 adds in trunk
WebCore:
2009-05-13 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
https://bugs.webkit.org/show_bug.cgi?id=25394
Test: http/tests/xmlhttprequest/frame-unload-abort-crash.html
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Add another check to subresource loader to avoid doing any loads in frames when the loaders are being stopped.
LayoutTests:
2009-05-13 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
https://bugs.webkit.org/show_bug.cgi?id=25394
Request a subresource load for an IMG after 'unload' and before the next
page load completes to expose the crash.
- http/tests/xmlhttprequest/frame-unload-abort-crash-expected.txt: Added.
- http/tests/xmlhttprequest/frame-unload-abort-crash.html: Added.
- http/tests/xmlhttprequest/resources/xmlhttprequest-in-unload.html: Added.
- 12:13 PM Changeset in webkit [43649] by
-
- 2 edits in trunk/WebCore
2009-05-13 Stephan Haller <nomad@froevel.de>
Reviewed by Gustavo Noronha.
Wrong handling of file upload if no file selected
https://bugs.webkit.org/show_bug.cgi?id=25649
Fixed returned path if path is empty
- WebCore/platform/gtk/FileSystemGtk.cpp:
- 12:08 PM Changeset in webkit [43648] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- 11:42 AM Changeset in webkit [43647] by
-
- 10 edits in trunk/JavaScriptCore
Windows build fixes after r43642
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Updated.
- debugger/Debugger.cpp:
- runtime/ArrayConstructor.cpp:
- runtime/JSArray.cpp:
- runtime/RegExp.cpp:
- runtime/RegExpConstructor.cpp:
- runtime/RegExpPrototype.cpp:
- runtime/StringPrototype.cpp: Added missing #includes.
- 11:33 AM Changeset in webkit [43646] by
-
- 5 edits8 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white when loading
Tests: fast/frames/content-opacity-1.html
fast/frames/content-opacity-2.html
- page/FrameView.cpp: (WebCore::FrameView::reset): Reset m_contentIsOpaque to false. (WebCore::FrameView::useSlowRepaints): Use slow repaints if the content is not known to be opaque. (WebCore::FrameView::setContentIsOpaque): Added. Sets m_contentIsOpaque and enables or disables fast repaints accordingly.
- page/FrameView.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Removed the document()->haveStylesheetsLoaded() condition in determining whether the root is opaque. This is what was causing the bug, as iframes were considered to be opaque, and thus painted an opaque white background, whenever they were pending a style sheet load. Changed to call FrameView::setContentIsOpaqe() instead of setUseSlowRepaints(), which allows the frame to go back to fast repaints if the content becomes opaque. Corrected the check for background color opacity: any alpha value other than 255--not just zero--is not opaque.
LayoutTests:
Reviewed by Dave Hyatt.
- tests for <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white when loading
- fast/frames/content-opacity-1.html: Added.
- fast/frames/content-opacity-2.html: Added.
- platform/mac/fast/frames/content-opacity-1-expected.checksum: Added.
- platform/mac/fast/frames/content-opacity-1-expected.png: Added.
- platform/mac/fast/frames/content-opacity-1-expected.txt: Added.
- platform/mac/fast/frames/content-opacity-2-expected.checksum: Added.
- platform/mac/fast/frames/content-opacity-2-expected.png: Added.
- platform/mac/fast/frames/content-opacity-2-expected.txt: Added.
- 11:30 AM Changeset in webkit [43645] by
-
- 2 edits in trunk/WebCore
2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Sam Weinig.
[Qt] Fix "lighther" composition mode.
QPainter::CompositionMode_Plus is the right match.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
- 11:19 AM Changeset in webkit [43644] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not handle KeyEvents with Ctrl or Alt modifiers that we
otherwise know nothing about. Otherwise shortcuts defined in the
WebView will never be executed.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::handleEditingKeyboardEvent):
- 11:15 AM Changeset in webkit [43643] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Darn, Cameron caught it but I forgot to fix it.
- 11:14 AM Changeset in webkit [43642] by
-
- 43 edits in trunk
2009-05-13 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
Bug 25674: syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674
Step 3: Add some actual arena allocation. About 1% SunSpider speedup.
- JavaScriptCore.exp: Updated.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Updated since VarStack contains const Identifier* now. (JSC::BytecodeGenerator::emitPushNewScope): Updated to take a const Identifier&.
- bytecompiler/BytecodeGenerator.h: Ditto
- bytecompiler/SegmentedVector.h: Added isEmpty.
- debugger/Debugger.cpp: (JSC::Debugger::recompileAllJSFunctions): Moved this function here from WebCore so WebCore doesn't need the details of FunctionBodyNode.
- debugger/Debugger.h: Ditto.
- interpreter/Interpreter.cpp: (JSC::Interpreter::execute): Updated since VarStack contains const Identifier* now.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_vm_lazyLinkCall): Call isHostFunction on the body rather than on the function object, since we can't easily have inlined access to the FunctionBodyNode in JSFunction.h since WebCore needs access to that header. (JSC::JITStubs::cti_op_construct_JSConstruct): Ditto.
- profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier): Ditto.
- parser/Grammar.y: Use JSGlobalData* to pass the global data pointer around whenever possible instead of using void*. Changed SET_EXCEPTION_LOCATION from a macro to an inline function. Marked the structure-creating functions inline. Changed the VarStack to use identifier pointers instead of actual identifiers. This takes advantage of the fact that all identifier pointers come from the arena and avoids referenc count churn. Changed Identifier* to const Identifier* to make sure we don't modify any by accident. Used identifiers for regular expression strings too, using the new scanRegExp that has out parameters instead of the old one that relied on side effects in the Lexer. Move the creation of numeric identifiers out of this file and into the PropertyNode constructor.
- parser/Lexer.cpp: (JSC::Lexer::setCode): Pass in ParserArena, used for identifiers. (JSC::Lexer::makeIdentifier): Changed return type to const Identifier* and changed to call ParserArena. (JSC::Lexer::scanRegExp): Added out arguments that are const Identifier* as well as a prefix character argument so we can handle the /= case without a string append. (JSC::Lexer::skipRegExp): Added. Skips a regular expression without allocating Identifier objects. (JSC::Lexer::clear): Removed the code to manage m_identifiers, m_pattern, and m_flags, and added code to set m_arena to 0.
- parser/Lexer.h: Updated for changes above.
- parser/NodeConstructors.h: (JSC::ParserArenaFreeable::operator new): Added. Calls allocateFreeable on the arena. (JSC::ParserArenaDeletable::operator new): Changed to call the allocateDeletable function on the arena instead of deleteWithArena. (JSC::RegExpNode::RegExpNode): Changed arguments to Identifier instead of UString since these come from the parser which makes identifiers. (JSC::PropertyNode::PropertyNode): Added new constructor that makes numeric identifiers. Some day we might want to optimize this for integers so it doesn't create a string for each one. (JSC::ContinueNode::ContinueNode): Initialize m_ident to nullIdentifier since it's now a const Identifier& so it can't be left uninitialized. (JSC::BreakNode::BreakNode): Ditto. (JSC::CaseClauseNode::CaseClauseNode): Updated to use SourceElements* to keep track of the statements rather than a separate statement vector. (JSC::BlockNode::BlockNode): Ditto. (JSC::ForInNode::ForInNode): Initialize m_ident to nullIdentifier.
- parser/Nodes.cpp: Moved the comment explaining emitBytecode in here. It seemed strangely out of place in the header. (JSC::ThrowableExpressionData::emitThrowError): Added an overload for UString as well as Identifier. (JSC::SourceElements::singleStatement): Added. (JSC::SourceElements::lastStatement): Added. (JSC::RegExpNode::emitBytecode): Updated since the pattern and flags are now Identifier instead of UString. Also changed the throwError code to use the substitution mechanism instead of doing a string append. (JSC::SourceElements::emitBytecode): Added. Replaces the old statementListEmitCode function, since we now keep the SourceElements objects around. (JSC::BlockNode::lastStatement): Added. (JSC::BlockNode::emitBytecode): Changed to use emitBytecode instead of statementListEmitCode. (JSC::CaseClauseNode::emitBytecode): Added. (JSC::CaseBlockNode::emitBytecodeForBlock): Changed to use emitBytecode instead of statementListEmitCode. (JSC::ScopeNodeData::ScopeNodeData): Changed to store the SourceElements* instead of using releaseContentsIntoVector. (JSC::ScopeNode::emitStatementsBytecode): Added. (JSC::ScopeNode::singleStatement): Added. (JSC::ProgramNode::emitBytecode): Call emitStatementsBytecode instead of statementListEmitCode. (JSC::EvalNode::emitBytecode): Ditto. (JSC::EvalNode::generateBytecode): Removed code to clear the children vector. This optimization is no longer possible since everything is in a single arena. (JSC::FunctionBodyNode::emitBytecode): Call emitStatementsBytecode insetad of statementListEmitCode and check for the return node using the new functions.
- parser/Nodes.h: Changed VarStack to store const Identifier* instead of Identifier and rely on the arena to control lifetime. Added a new ParserArenaFreeable class. Made ParserArenaDeletable inherit from FastAllocBase instead of having its own operator new. Base the Node class on ParserArenaFreeable. Changed the various Node classes to use const Identifier& instead of Identifier to avoid the need to call their destructors and allow them to function as "freeable" in the arena. Removed extraneous JSC_FAST_CALL on definitions of inline functions. Changed ElementNode, PropertyNode, ArgumentsNode, ParameterNode, CaseClauseNode, ClauseListNode, and CaseBlockNode to use ParserArenaFreeable as a base class since they do not descend from Node. Eliminated the StatementVector type and instead have various classes use SourceElements* instead of StatementVector. This prevents those classes from having th use ParserArenaDeletable to make sure the vector destructor is called.
- parser/Parser.cpp: (JSC::Parser::parse): Pass the arena to the lexer.
- parser/Parser.h: Added an include of ParserArena.h, which is no longer included by Nodes.h.
- parser/ParserArena.cpp: (JSC::ParserArena::ParserArena): Added. Initializes the new members, m_freeableMemory, m_freeablePoolEnd, and m_identifiers. (JSC::ParserArena::freeablePool): Added. Computes the pool pointer, since we store only the current pointer and the end of pool pointer. (JSC::ParserArena::deallocateObjects): Added. Contains the common memory-deallocation logic used by both the destructor and the reset function. (JSC::ParserArena::~ParserArena): Changed to call deallocateObjects. (JSC::ParserArena::reset): Ditto. Also added code to zero out the new structures, and switched to use clear() instead of shrink(0) since we don't really reuse arenas. (JSC::ParserArena::makeNumericIdentifier): Added. (JSC::ParserArena::allocateFreeablePool): Added. Used when the pool is empty. (JSC::ParserArena::isEmpty): Added. No longer inline, which is fine since this is used only for assertions at the moment.
- parser/ParserArena.h: Added an actual arena of "freeable" objects, ones that don't need destructors to be called. Also added the segmented vector of identifiers that used to be in the Lexer.
- runtime/FunctionConstructor.cpp: (JSC::extractFunctionBody): Use singleStatement function rather than getting at a StatementVector.
- runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): Call isHostFunction on the body rather than the function object.
- runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): Moved the structure version of this in here from the header. It's not hot enough that it needs to be inlined. (JSC::JSFunction::isHostFunction): Moved this in here from the header. It's now a helper to be used only within the class. (JSC::JSFunction::setBody): Moved this in here. It's not hot enough that it needs to be inlined, and we want to be able to compile the header without the definition of FunctionBodyNode.
- runtime/JSFunction.h: Eliminated the include of "Nodes.h". This was exposing too much JavaScriptCore dependency to WebCore. Because of this change and some changes made to WebCore, we could now export a lot fewer headers from JavaScriptCore, but I have not done that yet in this check-in. Made a couple functions non-inline. Removes some isHostFunction() assertions.
- wtf/FastAllocBase.h: Added the conventional using statements we use in WTF so we can use identifiers from the WTF namespace without explicit namespace qualification or namespace directive. This is the usual WTF style, although it's unconventional in the C++ world. We use the namespace primarily for link-time disambiguation, not compile-time.
- wtf/FastMalloc.cpp: Fixed an incorrect comment.
WebCore:
2009-05-13 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
Bug 25674: syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674
- bindings/js/JSDOMBinding.h: Removed include of JSFunction.h. We don't want the entire DOM binding to depend on that file.
- bindings/js/JSAudioConstructor.cpp: Added include of Error.h. Before we inherited this automatically because JDDOMBinding.h included JSFunction.h, but that was excessive.
- bindings/js/JSDOMWindowCustom.cpp: Ditto.
- bindings/js/JSHTMLInputElementCustom.cpp: Ditto.
- bindings/js/JSImageConstructor.cpp: Ditto.
- bindings/js/JSLazyEventListener.cpp: Ditto, but for JSFunction.h.
- bindings/js/JSMessageChannelConstructor.cpp: Ditto.
- bindings/js/JSOptionConstructor.cpp: Ditto.
- bindings/js/JSWorkerConstructor.cpp: Ditto.
- bindings/js/JSXMLHttpRequestConstructor.cpp: Ditto.
- bridge/jni/jni_jsobject.mm: Ditto, but for SourceCode.h.
- inspector/InspectorController.cpp: Ditto.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Moved mose of this function into the base class in JavaScriptCore, so the details of compilation don't have to be exposed.
WebKit/mac:
2009-05-13 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
Bug 25674: syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: Updated includes. New ones needed due to reducing includes of JSDOMBinding.h.
- WebView/WebScriptDebugger.mm: Ditto.
- 11:05 AM Changeset in webkit [43641] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Forgot to add ChangeLog.
- 11:03 AM Changeset in webkit [43640] by
-
- 1 edit in trunk/JavaScriptCore/GNUmakefile.am
2009-05-13 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix: add JITStubCall.h to files list.
- GNUmakefile.am:
- 11:02 AM Changeset in webkit [43639] by
-
- 17 edits in trunk
WebCore:
2009-05-13 Douglas R. Davidson <ddavidso@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6879145>
Generate a contextual menu item allowing autocorrections to
easily be changed back. Refrain from re-correcting items
that have already been autocorrected once.
- dom/DocumentMarker.h:
- editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
- editing/Editor.h:
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
- page/mac/WebCoreViewFactory.h:
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.h:
- platform/mac/LocalizedStringsMac.mm: (WebCore::contextMenuItemTagChangeBack):
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::replacedString):
- rendering/HitTestResult.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
- rendering/InlineTextBox.h:
WebKit/mac:
2009-05-13 Douglas R. Davidson <ddavidso@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6879145>
Generate a contextual menu item allowing autocorrections to
easily be changed back. Refrain from re-correcting items
that have already been autocorrected once.
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagChangeBack:]):
- WebView/WebUIDelegatePrivate.h:
- 10:56 AM Changeset in webkit [43638] by
-
- 2 edits in trunk/WebKit/qt
2009-05-13 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Ariya Hidayat.
Move emitting the signal QWebFrame::urlChanged to FrameLoaderClientQt::dispatchDidCommitLoad().
This is to ensure that urlChanged() is emitted even if the frame has no title.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
- 10:13 AM Changeset in webkit [43637] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>
Unreviewed build fix, as suggested by Yael Aharon <yael.aharon@nokia.com>.
- wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): renamed IsValid to isValid.
- 9:35 AM Changeset in webkit [43636] by
-
- 2 edits in trunk/WebKitTools
Fix resolve-ChangeLogs when used with Subversion
Reviewed by Darin Adler.
Fixes the following issue when run on a Subversion repository:
$ ./WebKitTools/Scripts/resolve-ChangeLogs
ERROR: --continue may only be used with a git repository
- Scripts/resolve-ChangeLogs: Check for the boolean value of $gitRebaseContinue, not whether it's defined, when validating command-line switches.
- 9:21 AM Changeset in webkit [43635] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Add information about the SVG index bounds check committed in
r43590.
- NEWS:
- 9:19 AM Changeset in webkit [43634] by
-
- 2 edits in trunk/WebCore
[GTK] Fix Gtk+/X11 build on OSX
Including the CoreFoundation header here and X11 headers
later will result in different definitions for Boolean. The
CoreFoundation include does not seem to be necessary here
and my mac build was successfull without it. I will remove
it for now. If the build bots disagree this will be replaced
by a #if PLATFORM(CF).
- 9:19 AM Changeset in webkit [43633] by
-
- 2 edits in trunk/WebCore
[GTK] Move the #ifdef around for a buildfix for Gtk+ on OSX
When building Gtk+ on OSX we ended up declaring
setNPWindowIfNeeded twice. Fix that by moving
the #if PLATFORM(GTK) up and using elif instead of
else.
- 9:15 AM Changeset in webkit [43632] by
-
- 1 edit in trunk/WebKit/gtk/NEWS
Small typo fix superseed -> supersede
- 9:08 AM Changeset in webkit [43631] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25749
Add a test for non-same origin appcache manifest URL
- http/tests/appcache/different-origin-manifest-expected.txt: Added.
- http/tests/appcache/different-origin-manifest.html: Added.
- 9:08 AM Changeset in webkit [43630] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Note changes since 1.1.6.
- NEWS:
- 8:25 AM Changeset in webkit [43629] by
-
- 3 edits in trunk/WebKit/gtk
2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Updated control file, and main file for the 1.1.7
release.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 7:54 AM Changeset in webkit [43628] by
-
- 2 edits in trunk
2009-05-13 Xan Lopez <xlopez@igalia.com>
Unreviewed: bump versions in preparation for 1.1.7 release.
- configure.ac:
- 7:49 AM Changeset in webkit [43627] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-05-13 Luca Ferretti <elle.uca@libero.it>
Rubber-stamped by Xan Lopez.
New Italian translation.
- it.po: Added.
- 7:22 AM Changeset in webkit [43626] by
-
- 2 edits in trunk/JavaScriptCore
Revert "2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>"
This reverts commit Revert r43562 - [Gtk] WTF_USE_JSC is already defined in
WebCore/config.h.
- wtf/Platform.h:
- 7:20 AM Changeset in webkit [43625] by
-
- 2 edits in trunk/WebKit/qt
2009-05-13 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Rubberstamped by Ariya Hidayat.
Fix coding style: Add {} to contents of if, containing a for loop.
- 7:04 AM Changeset in webkit [43624] by
-
- 8 edits in trunk
WebCore:
2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25685
[GTK] Middle click paste form the pasteboard
The kit wants to paste from at least two different
clipboards. By introducing getCurrentTarget to the
PasteboardHelper interface we can make this decision
in the kit.
Use the new method in PasteboardGtk to get the right
GdkClipboard for the paste operation.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::documentFragment): (WebCore::Pasteboard::plainText):
- platform/gtk/PasteboardHelper.h:
WebKit/gtk:
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25685
[GTK] Middle click paste form the pasteboard
For paste from middle button (button==2) we want to use
the GDK_PRIMARY_SELECTION. Implement the new getCurrentTarget
method in PasteboardHelperGtk by asking the WebView which
clipboard to use.
- WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getCurrentTarget):
- WebCoreSupport/PasteboardHelperGtk.h:
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): (webkit_web_view_use_primary_for_paste):
- 6:49 AM Changeset in webkit [43623] by
-
- 2 edits in trunk
2009-05-13 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Revert commit r43563, since it breaks WebKitGTK+ when compiled
with gcc 4.4.
- GNUmakefile.am:
- 6:34 AM Changeset in webkit [43622] by
-
- 3 edits in trunk/WebCore
2009-05-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6438177> QTMoviePreferredTransformAttribute only supported on SnowLeopard
<rdar://problem/6872468> QTMovieOpenForPlaybackAttribute only supported on SnowLeopard
QTMoviePreferredTransformAttribute and QTMovieOpenForPlaybackAttribute are not supported
on Tiger or Leopard.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Remove invalid ASSERT.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Only request QTMoviePreferredTransformAttribute when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD. (WebCore::MediaPlayerPrivate::cacheMovieScale): Only ask for QTMovieOpenForPlaybackAttribute when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD,
- 5:12 AM Changeset in webkit [43621] by
-
- 3 edits in trunk/WebKit/qt
2009-05-12 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Ariya Hidayat.
Fixed a possible crash @styleProperty when there is no embedded/external CSS set.
- Api/qwebelement.cpp: (QWebElement::styleProperty):
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
- 5:07 AM Changeset in webkit [43620] by
-
- 3 edits3 adds in trunk/WebKit/qt
2009-05-12 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Ariya Hidayat.
Added external CSS test cases to QWebElement::styleProperty() method.
Also some ::styleProperty() tests cleanup.
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
- 2:10 AM Changeset in webkit [43619] by
-
- 14 edits in trunk/JavaScriptCore
2009-05-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add SamplingCounter tool to provide a simple mechanism for counting events in JSC
(enabled using ENABLE(SAMPLING_COUNTERS)). To count events within a single function
use the class 'SamplingCounter', where the counter may be incremented from multiple
functions 'GlobalSamplingCounter' may be convenient; all other counters (stack or
heap allocated, rather than statically declared) should use the DeletableSamplingCounter.
Further description of these classes is provided alongside their definition in
SamplingTool.h.
Counters may be incremented from c++ by calling the 'count()' method on the counter,
or may be incremented by JIT code by using the 'emitCount()' method within the JIT.
This patch also fixes CODEBLOCK_SAMPLING, which was missing a null pointer check.
- JavaScriptCore.exp:
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::addWithCarry32): (JSC::MacroAssemblerX86::and32): (JSC::MacroAssemblerX86::or32):
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::and32): (JSC::MacroAssemblerX86Common::or32):
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::and32): (JSC::MacroAssemblerX86_64::or32): (JSC::MacroAssemblerX86_64::addPtr):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::adcl_im): (JSC::X86Assembler::addq_im): (JSC::X86Assembler::andl_im): (JSC::X86Assembler::orl_im):
- bytecode/SamplingTool.cpp: (JSC::AbstractSamplingCounter::dump):
- bytecode/SamplingTool.h: (JSC::AbstractSamplingCounter::count): (JSC::GlobalSamplingCounter::name): (JSC::SamplingCounter::SamplingCounter):
- jit/JIT.h:
- jit/JITCall.cpp: (JSC::):
- jit/JITInlineMethods.h: (JSC::JIT::setSamplingFlag): (JSC::JIT::clearSamplingFlag): (JSC::JIT::emitCount):
- jsc.cpp: (runWithScripts):
- parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode):
- wtf/Platform.h:
- 12:11 AM Changeset in webkit [43618] by
-
- 3 edits in tags/Safari-6530.9.3/JavaScriptCore
Merged r43616.
- 12:06 AM Changeset in webkit [43617] by
-
- 1 copy in tags/Safari-6530.9.3
New tag.
- 12:05 AM Changeset in webkit [43616] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore.make:
May 12, 2009:
- 11:00 PM Changeset in webkit [43615] by
-
- 3 edits in tags/Safari-6530.9.2/SunSpider
Merge r43607.
- 10:58 PM Changeset in webkit [43614] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement op_new_error.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_error):
- jit/JITStubCall.h: (JSC::JITStubCall::addArgument): Add a version of addArgument that takes a constant JSValue.
- 10:58 PM Changeset in webkit [43613] by
-
- 3 edits in tags/Safari-6530.9.2/JavaScriptCore
Merged r43611.
- 10:47 PM Changeset in webkit [43612] by
-
- 1 copy in tags/Safari-6530.9.2
New tag.
- 10:46 PM Changeset in webkit [43611] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore.make:
- 10:35 PM Changeset in webkit [43610] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove now unused emitGetVariableObjectRegister and emitPutVariableObjectRegister.
- jit/JIT.cpp:
- jit/JIT.h:
- 10:32 PM Changeset in webkit [43609] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement op_to_primitive and op_next_pname.
- jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_construct_verify): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emitSlow_op_to_primitive): (JSC::JIT::emitSlow_op_loop_if_true): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_next_pname):
- 9:46 PM Changeset in webkit [43608] by
-
- 3 edits4 adds in trunk
2009-05-12 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel.
Bug 25738: Skia: CSS border style not cleared for SVG object
https://bugs.webkit.org/show_bug.cgi?id=25738
If no dashing is set, this change reverts to solid stroke
(previously the code bailed and left the old setting, whatever it was)
Test case listed in above bug entry.
(Additional complications due to each platform rendering dotted lines differently -
c.f. https://bugs.webkit.org/show_bug.cgi?id=25737)
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setLineDash):
- 9:36 PM Changeset in webkit [43607] by
-
- 2 edits in trunk/SunSpider
Build fix.
- SunSpider.make:
- 8:53 PM Changeset in webkit [43606] by
-
- 5 edits in trunk
<rdar://problem/6881457> Crash occurs at JSC::Interpreter::execute() when loading http://www.sears.com
Reviewed by Gavin Barraclough
We created the arguments objects before an op_push_scope but not
before op_push_new_scope, this meant a null arguments object could
be resolved inside catch blocks.
- 8:38 PM Changeset in webkit [43605] by
-
- 9 edits3 adds in trunk
2009-05-11 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Bug 21903: Adds DOM bindings for the placeholder property of the
HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=21903
Test: fast/forms/placeholder-dom-property.html
- dom/InputElement.cpp: (WebCore::InputElement::updatePlaceholderVisibility):
- dom/InputElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::placeholder): (WebCore::HTMLInputElement::setPlaceholder):
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement):
- wml/WMLInputElement.h: (WebCore::WMLInputElement::placeholder): (WebCore::WMLInputElement::setPlaceholder):
- 8:13 PM Changeset in webkit [43604] by
-
- 3 edits6 adds in trunk
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
WebCore:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Test that we use the lexical global object in document.open,
document.write, and document.writeln.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
- http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
- 7:39 PM Changeset in webkit [43603] by
-
- 4 edits in trunk/JavaScriptCore
<rdar://problem/6879881> Crash occurs at JSC::JSActivation::mark() when loading http://www.monster.com; http://www.cnet.com
<https://bugs.webkit.org/show_bug.cgi?id=25736> Crash loading www.google.dk/ig (and other igoogle's as well)
Reviewed by Gavin Barraclough.
Following on from the lazy arguments creation patch, it's now
possible for an activation to to have a null register in the callframe
so we can't just blindly mark the local registers in an activation,
and must null check first instead.
- 6:38 PM Changeset in webkit [43602] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add op_get_global_var, op_put_global_var, emit_op_get_scoped_var, emit_op_put_scoped_var and
op_unexpected_load.
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::tagFor): (JSC::JIT::payloadFor): (JSC::JIT::emitLoad): (JSC::JIT::emitStore): (JSC::JIT::emitLoadReturnValue):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_unexpected_load):
- 5:31 PM Changeset in webkit [43601] by
-
- 2 edits in trunk/WebKitTools
Bug 21418: resolve-ChangeLogs should have a --continue option which does git rebase --continue
Reviewed by Darin Adler.
Scripts/resolve-ChangeLogs: Added -ccontinue switch that runs "git rebase --continue" before exiting the script.
(hasGitUnmergedFiles): Added. Returns true if there are
unmerged files in the git repository.
- 5:31 PM Changeset in webkit [43600] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-12 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Geoff Garen.
WTF_USE_CTI_REPATCH_PIC is no longer used, remove.
- jit/JIT.h:
- jit/JITStubCall.h:
- 5:27 PM Changeset in webkit [43599] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Maciej Stachowiak.
We've run into some problems where changing the size of the class JIT leads to
performance fluctuations. Try forcing alignment in an attempt to stabalize this.
- jit/JIT.h:
- 5:20 PM Changeset in webkit [43598] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added overflow handling to op_sub.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlowSub32InPlaceLeft):
- 5:06 PM Changeset in webkit [43597] by
-
- 2 edits in trunk/LayoutTests
2009-05-12 Simon Fraser <Simon Fraser>
No review.
media/video-size-intrinsic-scale.html fails on Tiger, so add it to the skipped
list.
- platform/mac-tiger/Skipped:
- 4:52 PM Changeset in webkit [43596] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove a function call by folding op_get_by_id and op_put_by_id into
their respective compile functions.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id):
- 4:30 PM Changeset in webkit [43595] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Make JITStubCall work in 64bit by making the stack index
step dependent on the size of void*.
- jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument):
- 4:28 PM Changeset in webkit [43594] by
-
- 2 edits in trunk/WebKit/mac
2009-05-12 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Fix <rdar://problem/6878105>.
When instantiating the QT plug-in under Dashboard, force "kiosk mode".
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
- 4:16 PM Changeset in webkit [43593] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement simple version of property access opcodes
which just call a stub functions.
- jit/JITOpcodes.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath):
- jit/JITStubCall.h: (JSC::JITStubCall::addArgument):
- jsc.cpp:
- 4:14 PM Changeset in webkit [43592] by
-
- 21 edits16 copies3 adds2 deletes in trunk/LayoutTests
2009-05-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
<rdar://problem/6497461> Many media layout tests failing on SnowLeopard.
Turn media tests back on for SnowLeopard, and generate new pixel results. Put override
results in platform/mac-leopard when necessary.
media/video-size-intrinsic-scale.html fails and is still skipped: <rdar://problem/6877291>
- platform/mac-leopard/media/audio-controls-rendering-expected.checksum: Added.
- platform/mac-leopard/media/audio-controls-rendering-expected.png: Added.
- platform/mac-leopard/media/video-aspect-ratio-expected.checksum: Added.
- platform/mac-leopard/media/video-aspect-ratio-expected.png: Added.
- platform/mac-leopard/media/video-controls-rendering-expected.checksum: Added.
- platform/mac-leopard/media/video-controls-rendering-expected.png: Added.
- platform/mac-leopard/media/video-display-toggle-expected.checksum: Added.
- platform/mac-leopard/media/video-display-toggle-expected.png: Added.
- platform/mac-leopard/media/video-empty-source-expected.checksum: Added.
- platform/mac-leopard/media/video-empty-source-expected.png: Added.
- platform/mac-leopard/media/video-layer-crash-expected.checksum: Added.
- platform/mac-leopard/media/video-layer-crash-expected.png: Added.
- platform/mac-leopard/media/video-transformed-expected.checksum: Added.
- platform/mac-leopard/media/video-transformed-expected.png: Added.
- platform/mac-leopard/media/video-zoom-controls-expected.checksum: Added.
- platform/mac-leopard/media/video-zoom-controls-expected.png: Added.
- platform/mac-leopard/media/video-zoom-expected.checksum: Added.
- platform/mac-leopard/media/video-zoom-expected.png: Added.
- platform/mac-snowleopard/Skipped:
- platform/mac/Skipped:
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/video-aspect-ratio-expected.checksum:
- platform/mac/media/video-aspect-ratio-expected.png:
- platform/mac/media/video-controls-rendering-expected.checksum:
- platform/mac/media/video-controls-rendering-expected.png:
- platform/mac/media/video-controls-visible-audio-only-expected.checksum: Removed.
- platform/mac/media/video-controls-visible-audio-only-expected.png: Removed.
- platform/mac/media/video-display-toggle-expected.checksum:
- platform/mac/media/video-display-toggle-expected.png:
- platform/mac/media/video-empty-source-expected.checksum:
- platform/mac/media/video-empty-source-expected.png:
- platform/mac/media/video-layer-crash-expected.checksum:
- platform/mac/media/video-layer-crash-expected.png:
- platform/mac/media/video-transformed-expected.checksum:
- platform/mac/media/video-transformed-expected.png:
- platform/mac/media/video-zoom-controls-expected.checksum:
- platform/mac/media/video-zoom-controls-expected.png:
- platform/mac/media/video-zoom-expected.checksum:
- platform/mac/media/video-zoom-expected.png:
- 4:02 PM Changeset in webkit [43591] by
-
- 2 edits in trunk/JavaScriptCore
wx build fix. Add ParserArena.cpp to the build.
- 3:23 PM Changeset in webkit [43590] by
-
- 3 edits2 adds in trunk
<rdar://problem/6702386> Incorrect bound check in SVGList::insertItemBefore
Reviewed by Darin Adler.
SVGList::insertItemBefore would not perform a bounds check on the
index it was provided, potentially leading to a buffer overflow.
- 3:18 PM Changeset in webkit [43589] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added work-around for XCode debugging echo problem.
- jsc.cpp: (runInteractive):
- 3:17 PM Changeset in webkit [43588] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added overflow handling to op_add.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32InPlace):
- 2:54 PM Changeset in webkit [43587] by
-
- 2 edits in trunk/WebCore
2009-05-12 Paul Godavari <paul@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 25708: Cannot choose menu items in popups with many entries in Chromium
https://bugs.webkit.org/show_bug.cgi?id=25708
This change sets the window size for popups on Mac to include all items
in the menu. This is required for hit testing on Mac, where we use native
controls to manage the popups and don't want to artificially limit the
valid hit testing region to a limited scroll window.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
- 2:07 PM Changeset in webkit [43586] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add slow cases for op_jnless or emit_op_jnlesseq.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq):
- 2:03 PM Changeset in webkit [43585] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add implementations for op_jnless, emit_op_jnlesseq, op_loop_if_less and op_loop_if_lesseq.
No slow cases for op_jnless or emit_op_jnlesseq yet.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emitSlow_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emitSlow_op_loop_if_lesseq):
- 1:36 PM Changeset in webkit [43584] by
-
- 4 edits in trunk/WebCore
2009-05-12 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Fixes to build with latest skia: SkTypeface::Create() is now
SkTypeface::CreateFromName(); computeBounds() has been reworked
as getBounds(). The changes are placed behind an #ifdef for now,
so that we can roll back the skia version in Chromium if necessary
without having to roll back this change.
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/graphics/skia/PathSkia.cpp: (WebCore::Path::boundingRect): (WebCore::boundingBoxForCurrentStroke):
- platform/graphics/skia/SkiaUtils.cpp: (WebCore::SkPathContainsPoint):
- 1:27 PM Changeset in webkit [43583] by
-
- 2 edits in trunk/JavaScriptCore
Unsigned underflow on 64bit cannot be treated as a negative number
Reviewed by Geoff Garen
This code included some placeswhere we deliberately create negative offsets
from unsigned values, on 32bit this is "safe", but in 64bit builds much
badness occurs. Solution is to use signed types as nature intended.
- 1:22 PM Changeset in webkit [43582] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Turn the RECORD_JUMP_TARGET macro into an inline function.
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::recordJumpTarget):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_jmp_scopes):
- 1:21 PM Changeset in webkit [43581] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Add MacroAssemblerX86Common::set8 to fix the build.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::set8):
- 1:16 PM Changeset in webkit [43580] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
- declare a forgotten method
- DOM/WebDOMOperationsPrivate.h: Declare -[DOMNode markupString] in the WebDOMNodeOperationsPendingPublic category.
- 1:15 PM Changeset in webkit [43579] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added overflow recovery for pre_inc and pre_dec.
Turned some short-circuit code into early returns, as is the WebKit style.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emitSlow_op_pre_dec):
- 1:08 PM Changeset in webkit [43578] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement op_jmp, op_loop, op_eq and op_neq.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_loop): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
- 12:57 PM Changeset in webkit [43577] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement the slow cases for arithmetic opcodes.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emitSlow_op_bitand): (JSC::JIT::emitSlow_op_bitor): (JSC::JIT::emitSlow_op_bitxor): (JSC::JIT::emitSlow_op_bitnot): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitSlow_op_mod): (JSC::JIT::emit_op_mod):
- 12:34 PM Changeset in webkit [43576] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement op_bitnot.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::not32):
- assembler/X86Assembler.h: (JSC::X86Assembler::notl_m):
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitnot):
- 12:26 PM Changeset in webkit [43575] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add arithmetic opcode implementations from the old nitro-extreme branch.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emit_op_lshift): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emitBitAnd32InPlace): (JSC::JIT::emit_op_bitor): (JSC::JIT::emitSlow_op_bitor): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emitBitOr32InPlace): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emitSlow_op_bitxor): (JSC::JIT::emitBitXor32Constant): (JSC::JIT::emitBitXor32InPlace): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emitSlow_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitAdd32InPlace): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emitSub32InPlaceLeft): (JSC::JIT::emitSub32InPlaceRight): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitMul32Constant): (JSC::JIT::emitMul32InPlace): (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
- jit/JITOpcodes.cpp:
- 11:44 AM Changeset in webkit [43574] by
-
- 2 edits in trunk/WebCore
2009-05-12 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25732
Update V8ElementCustom.cpp to match the current API of V8Proxy.
(WebCore::ACCESSOR_SETTER): Change retrieveActiveFrame() to retrieveFrameForEnteredContext().
- 11:26 AM Changeset in webkit [43573] by
-
- 4 edits2 adds in branches/nitro-extreme/JavaScriptCore
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Removed JIT_OPTIMIZE_ARITHMETIC setting, since it was all about 32bit
value representations.
Added JSAPIValueWrapper to the repository.
- jit/JIT.h:
- jit/JITArithmetic.cpp:
- runtime/JSAPIValueWrapper.cpp: Added. (JSC::JSAPIValueWrapper::toPrimitive): (JSC::JSAPIValueWrapper::getPrimitiveNumber): (JSC::JSAPIValueWrapper::toBoolean): (JSC::JSAPIValueWrapper::toNumber): (JSC::JSAPIValueWrapper::toString): (JSC::JSAPIValueWrapper::toObject):
- runtime/JSAPIValueWrapper.h: Added. (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::isAPIValueWrapper): (JSC::JSAPIValueWrapper::JSAPIValueWrapper): (JSC::jsAPIValueWrapper):
- wtf/Platform.h:
- 11:13 AM Changeset in webkit [43572] by
-
- 2 edits in trunk/WebKit/qt
2009-05-12 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Ariya Hidayat.
Many methods were not considering the case of the element not having
siblings or children when inserting nodes, and thus broke in some
situations. This patch fixes that.
- 11:02 AM Changeset in webkit [43571] by
-
- 4 edits in trunk/WebKit/qt
2009-05-08 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Ariya Hidayat.
Make is possible to mark a style property as important while setting
it. Also support the normal CSS property syntax "!important", while
accepting spaces between the ! and the important keyword.
- 10:56 AM Changeset in webkit [43570] by
-
- 4 edits in trunk/WebKit/qt
2009-05-08 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Ariya Hidayat.
Working with Antonio Gomes.
Add support for finding the style property actually applied to the element.
- 10:16 AM Changeset in webkit [43569] by
-
- 2 edits in trunk/WebKit/win
Build fix for Windows nightlies.
Change link order to work around CFNetwork bug.
- WebKit.vcproj/WebKit.vcproj:
- 9:21 AM Changeset in webkit [43568] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25694
HTMLParser::createHead() ASSERT: Creating an element, calling document.open() and writing
to the document NULL ptr
Test: fast/parser/implicit-head-in-fragment-crash.html
- html/HTMLParser.cpp: (WebCore::HTMLParser::bodyCreateErrorCheck): Do not try to implicitly create <head> when parsing a fragment.
- 8:58 AM Changeset in webkit [43567] by
-
- 1 edit1 add in trunk/LayoutTests
2009-05-12 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Dimitri Glazkov.
Added Qt-specific expected result for toDataURL test, since Qt
does not support saving pixmaps to GIF.
- platform/qt/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
- 8:54 AM Changeset in webkit [43566] by
-
- 2 edits in trunk/WebCore
2009-05-12 Soren Gjesse <sgjesse@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25687
Missing check for valid function in V8 bindings for toString function for event listeners.
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getWrappedListenerFunction): Added empty handle checks.
- 5:42 AM Changeset in webkit [43565] by
-
- 2 edits1 add in trunk/LayoutTests
2009-05-12 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
Added Qt-specific expected result for Canvas getImageData's test.
Since Qt is internally using premultiplied ARGB32 for doing
alpha-blending painting, reading the color back will not
necessarily give the same exact color.
- platform/qt/Skipped: Excluded canvas-getImageData.
- platform/qt/fast/canvas/canvas-getImageData-expected.txt: Added.
- 5:06 AM Changeset in webkit [43564] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Add glib-2.0 to the list of required package.
- webkit.pc.in:
- 5:06 AM Changeset in webkit [43563] by
-
- 2 edits in trunk
2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Refactor use of CFLAGS, CXXFLAGS, LIBADD and LDFLAGS.
- GNUmakefile.am:
- 5:05 AM Changeset in webkit [43562] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Define WTF_USE_JSC for the Gtk port.
- wtf/Platform.h:
- 3:35 AM Changeset in webkit [43561] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
- allow all of strictEqual to be inlined into cti_op_stricteq once again
We had this optimization once but accidentally lost it at some point.
- runtime/Operations.h: (JSC::JSValue::strictEqualSlowCaseInline): (JSC::JSValue::strictEqual):
- 2:18 AM Changeset in webkit [43560] by
-
- 8 edits in trunk
2009-05-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
instanceof should throw if the constructor being tested does not implement
'HasInstance" (i.e. is a function). Instead we were returning false.
- interpreter/Interpreter.cpp: (JSC::isInvalidParamForIn): (JSC::isInvalidParamForInstanceOf): (JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_instanceof):
- tests/mozilla/ecma_2/instanceof/instanceof-003.js:
Fix broken test case.
- tests/mozilla/ecma_2/instanceof/regress-7635.js:
Remove broken test case (was an exact duplicate of a test in instanceof-003.js).
LayoutTests:
2009-05-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Test was checked in with one test case disabled since it exposed an existing bug;
enable it now.
- fast/js/instance-of-immediates-expected.txt:
- fast/js/resources/instance-of-immediates.js:
- 1:58 AM Changeset in webkit [43559] by
-
- 11 edits in trunk/JavaScriptCore
Improve function call forwarding performance
Reviewed by Gavin Barraclough
Make creation of the Arguments object occur lazily, so it
is not necessarily created for every function that references
it. Then add logic to Function.apply to allow it to avoid
allocating the Arguments object at all. Helps a lot with
the function forwarding/binding logic in jQuery, Prototype,
and numerous other JS libraries.
- 1:58 AM Changeset in webkit [43558] by
-
- 17 edits in branches/nitro-extreme/JavaScriptCore
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Turned on the JIT and got it building and running the most trivial of
programs.
All configurable optimizations are turned off, and a few opcodes are ad
hoc #if'd out.
So far, I've only merged op_mov and op_end, but some stub-reliant
opcodes work as-is from TOT.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock):
- bytecode/CodeBlock.h:
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_lshift): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitSlow_op_bitand): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec): (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_mul): (JSC::JIT::emit_op_sub): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlow_op_mul):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateInt): (JSC::JIT::isOperandConstantImmediateInt): (JSC::JIT::emitInitRegister): (JSC::JIT::addSlowCase): (JSC::JIT::addJump): (JSC::JIT::emitJumpSlowToHot): (JSC::JIT::tagFor): (JSC::JIT::payloadFor): (JSC::JIT::emitLoad): (JSC::JIT::emitLoadReturnValue): (JSC::JIT::emitStore): (JSC::JIT::emitStoreReturnValue):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_mov): (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_loop): (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_tear_off_activation): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_loop_if_true): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_unexpected_load): (JSC::JIT::emit_op_eq): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_neq): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emit_op_bitor): (JSC::JIT::emit_op_throw): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_push_scope): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_push_new_scope): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_switch_imm): (JSC::JIT::emit_op_switch_char): (JSC::JIT::emit_op_switch_string): (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_construct_verify): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emitSlow_op_loop_if_less): (JSC::JIT::emitSlow_op_loop_if_lesseq): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emitSlow_op_not): (JSC::JIT::emitSlow_op_instanceof):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath):
- jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): (JSC::JITStubCall::): (JSC::CallEvalJITStub::CallEvalJITStub):
- jit/JITStubs.cpp: (JSC::): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_switch_imm):
- jit/JITStubs.h:
- runtime/JSArray.cpp: (JSC::JSArray::JSArray):
- runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction):
- runtime/JSValue.h: (JSC::JSValue::payload):
- wtf/Platform.h:
May 11, 2009:
- 11:45 PM Changeset in webkit [43557] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-07 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add some new MacroAssembler and assembler functions that will be needed shortly.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::add32): (JSC::MacroAssemblerX86Common::and32): (JSC::MacroAssemblerX86Common::mul32): (JSC::MacroAssemblerX86Common::neg32): (JSC::MacroAssemblerX86Common::or32): (JSC::MacroAssemblerX86Common::sub32): (JSC::MacroAssemblerX86Common::xor32): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::addl_rm): (JSC::X86Assembler::andl_mr): (JSC::X86Assembler::andl_rm): (JSC::X86Assembler::andl_im): (JSC::X86Assembler::negl_r): (JSC::X86Assembler::notl_r): (JSC::X86Assembler::orl_rm): (JSC::X86Assembler::orl_im): (JSC::X86Assembler::subl_rm): (JSC::X86Assembler::xorl_mr): (JSC::X86Assembler::xorl_rm): (JSC::X86Assembler::xorl_im): (JSC::X86Assembler::imull_mr):
- 11:41 PM Changeset in webkit [43556] by
-
- 5 edits in branches/nitro-extreme/JavaScriptCore
2009-05-11 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Remove the NumberHeap.
- JavaScriptCore.exp:
- runtime/Collector.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::recordExtraCost): (JSC::Heap::heapAllocate): (JSC::Heap::markConservatively): (JSC::Heap::sweep): (JSC::Heap::collect): (JSC::Heap::objectCount): (JSC::Heap::statistics): (JSC::typeName): (JSC::Heap::isBusy):
- runtime/Collector.h: (JSC::Heap::globalData):
- runtime/JSCell.h:
- 11:35 PM Changeset in webkit [43555] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Update my ChangeLog entry to make Mark Rowe happy. Mark Rowe - who is supposed to be on vacation. Mark Rowe - who probably didn't even get to watch House tonight. Oh, I see - that's why he's grumpy.
- 11:33 PM Changeset in webkit [43554] by
-
- 38 edits1 copy3 deletes in branches/nitro-extreme
2009-05-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Land initial commit of new number representation for 32 bit platforms,
with JIT disabled.
- API/APICast.h: (toJS): (toRef):
- API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): (JSC::::toNumber): (JSC::::toString):
- API/tests/testapi.c: (EvilExceptionObject_convertToType):
- AllInOneFile.cpp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp: (JSC::valueToSourceString):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitUnexpectedLoad): (JSC::keyForImmediateSwitch):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::privateExecute):
- parser/Nodes.cpp: (JSC::ArrayNode::emitBytecode): (JSC::processClauseList):
- runtime/ArgList.h:
- runtime/Collector.h: (JSC::sizeof):
- runtime/DateMath.cpp:
- runtime/ExceptionHelpers.h:
- runtime/InitializeThreading.cpp:
- runtime/JSArray.cpp: (JSC::JSArray::JSArray):
- runtime/JSCell.cpp:
- runtime/JSCell.h: (JSC::JSCell::isAPIValueWrapper): (JSC::JSValue::isString): (JSC::JSValue::isGetterSetter): (JSC::JSValue::isObject): (JSC::JSValue::getString): (JSC::JSValue::getObject): (JSC::JSValue::getCallData): (JSC::JSValue::getConstructData): (JSC::JSValue::getUInt32): (JSC::JSValue::marked): (JSC::JSValue::toPrimitive): (JSC::JSValue::getPrimitiveNumber): (JSC::JSValue::toBoolean): (JSC::JSValue::toNumber): (JSC::JSValue::toString): (JSC::JSValue::needsThisConversion): (JSC::JSValue::toThisString): (JSC::JSValue::getJSNumber): (JSC::JSValue::toObject): (JSC::JSValue::toThisObject):
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.h: (JSC::Structure::prototypeForLookup):
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
- runtime/JSImmediate.h:
- runtime/JSNumberCell.cpp: Removed.
- runtime/JSNumberCell.h: Removed.
- runtime/JSObject.h: (JSC::JSValue::get): (JSC::JSValue::put):
- runtime/JSString.h: (JSC::JSValue::toThisJSString):
- runtime/JSValue.cpp: (JSC::JSValue::toInteger): (JSC::JSValue::toIntegerPreserveNaN): (JSC::JSValue::toObjectSlowCase): (JSC::JSValue::toThisObjectSlowCase): (JSC::JSValue::synthesizeObject): (JSC::JSValue::synthesizePrototype): (JSC::JSValue::description): (JSC::nonInlineNaN):
- runtime/JSValue.h: (JSC::JSValue::): (JSC::EncodedJSValueHashTraits::emptyValue): (JSC::jsNaN): (JSC::operator==): (JSC::operator!=): (JSC::toInt32): (JSC::toUInt32): (JSC::JSValue::encode): (JSC::JSValue::decode): (JSC::JSValue::JSValue): (JSC::JSValue::operator bool): (JSC::JSValue::operator==): (JSC::JSValue::operator!=): (JSC::JSValue::isUndefined): (JSC::JSValue::isNull): (JSC::JSValue::isUndefinedOrNull): (JSC::JSValue::isCell): (JSC::JSValue::isInt32): (JSC::JSValue::isUInt32): (JSC::JSValue::isDouble): (JSC::JSValue::isTrue): (JSC::JSValue::isFalse): (JSC::JSValue::tag): (JSC::JSValue::asInt32): (JSC::JSValue::asUInt32): (JSC::JSValue::asDouble): (JSC::JSValue::asCell): (JSC::JSValue::isNumber): (JSC::JSValue::isBoolean): (JSC::JSValue::getBoolean): (JSC::JSValue::uncheckedGetNumber): (JSC::JSValue::toJSNumber): (JSC::JSValue::getNumber): (JSC::JSValue::toInt32): (JSC::JSValue::toUInt32):
- runtime/Operations.h: (JSC::JSValue::equal): (JSC::JSValue::equalSlowCaseInline): (JSC::JSValue::strictEqual): (JSC::JSValue::strictEqualSlowCaseInline): (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAdd):
- runtime/PropertySlot.h:
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncIndexOf):
- wtf/Platform.h:
WebCore:
2009-05-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Make WebCore compile with the new JS number representation.
- ForwardingHeaders/runtime/JSAPIValueWrapper.h: Added.
- ForwardingHeaders/runtime/JSNumberCell.h: Removed.
- bindings/js/ScriptEventListener.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/c/c_instance.cpp:
- 11:21 PM Changeset in webkit [43553] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Enable use of SamplingFlags directly from JIT code.
- bytecode/SamplingTool.h:
- jit/JIT.h: (JSC::JIT::sampleCodeBlock): (JSC::JIT::sampleInstruction):
- jit/JITInlineMethods.h: (JSC::JIT::setSamplingFlag): (JSC::JIT::clearSamplingFlag):
- 10:49 PM Changeset in webkit [43552] by
-
- 1 edit3 copies1 add in trunk/LayoutTests
2009-05-11 Brady Eidson <beidson@apple.com>
Add a third copy of this test to make Tiger bots happy.
- platform/mac-tiger/fast/images: Added.
- platform/mac-tiger/fast/images/favicon-as-image-expected.checksum: Copied from platform/mac/fast/images/favicon-as-image-expected.checksum.
- platform/mac-tiger/fast/images/favicon-as-image-expected.png: Copied from platform/mac/fast/images/favicon-as-image-expected.png.
- platform/mac-tiger/fast/images/favicon-as-image-expected.txt: Copied from platform/mac/fast/images/favicon-as-image-expected.txt.
- 10:31 PM Changeset in webkit [43551] by
-
- 6 edits3 adds in trunk
2009-05-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Cameron Zwarich.
Implement JIT generation for instanceof for non-objects (always returns false).
Also fixes the sequencing of the prototype and value isObject checks, to no match the spec.
0.5% progression on v8 tests overall, due to 3.5% on early-boyer.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- runtime/JSObject.cpp: (JSC::JSObject::hasInstance):
- runtime/TypeInfo.h: (JSC::TypeInfo::TypeInfo):
LayoutTests:
2009-05-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add a layout test for instanceof.
- fast/js/instance-of-immediates-expected.txt: Added.
- fast/js/instance-of-immediates.html: Added.
- fast/js/resources/instance-of-immediates.js: Added. (testInstanceOf): (): (testSet):
- 10:07 PM Changeset in webkit [43550] by
-
- 2 edits in trunk/WebCore
2009-05-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Holger Freyther.
Change Qt port to match the mac and windows ports, and unregister plugins when plugins are stopped.
Not doing that can cause assersion failure.
https://bugs.webkit.org/show_bug.cgi?id=25702
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::stop):
- 10:02 PM Changeset in webkit [43549] by
-
- 2 edits in trunk/WebCore
2009-05-11 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
Bug 25714: [Qt] Decouple HTML5 Database support from the
SQLite/generic database support in the Qt port
- WebCore.pro:
- 9:37 PM Changeset in webkit [43548] by
-
- 1 copy in branches/nitro-extreme
Create a new nitro-extreme branch
- 9:35 PM Changeset in webkit [43547] by
-
- 1 move in branches/nitro-extreme-old
Move asside nitro-extreme branch
- 9:34 PM Changeset in webkit [43546] by
-
- 1 delete in branches/nitro-extreme-rebase-1
Remove branch created in error
- 9:32 PM Changeset in webkit [43545] by
-
- 1 copy in branches/nitro-extreme-rebase-1
Create new branch for rebasing
- 9:28 PM Changeset in webkit [43544] by
-
- 44 edits in trunk/LayoutTests
Updated the svn:mime-type property of recently-updated PNG files to image/png
- 9:20 PM Changeset in webkit [43543] by
-
- 6 edits in trunk/JavaScriptCore
2009-05-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more JIT refactoring.
Rearranged code to more clearly indicate what's conditionally compiled
and why. Now, all shared code is at the top of our JIT files, and all
#if'd code is at the bottom. #if'd code is delineated by large comments.
Moved functions that relate to the JIT but don't explicitly do codegen
into JIT.cpp. Refactored SSE2 check to store its result as a data member
in the JIT.
- jit/JIT.cpp: (JSC::isSSE2Present): (JSC::JIT::JIT): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
- jit/JIT.h: (JSC::JIT::isSSE2Present):
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCallVarargsSlowCase):
- 9:18 PM Changeset in webkit [43542] by
-
- 3 edits5 copies4 adds in trunk/LayoutTests
2009-05-11 Brady Eidson <beidson@apple.com>
Reviewed by David Kilzer.
<rdar://problem/6876226> - Cleanup the fast/images/favicon situation a bit.
First off, copy fast/images/favicon-as-image.html over to http/tests/misc so it covers the original test case on all Mac platforms.
Second, add Leopard-specific results for the original test.
Then, remove it from the Leopard skipped list.
Finally, add it to the SnowLeopard skipped list (<rdar://problem/6877633> covers re-enabling it when we're no longer blocked).
- http/tests/misc/favicon-as-image.html: Copied from fast/images/favicon-as-image.html.
- http/tests/misc/resources/favicon.ico: Copied from fast/images/resources/favicon.ico.
- platform/mac/http/tests/misc/favicon-as-image-expected.checksum: Added.
- platform/mac/http/tests/misc/favicon-as-image-expected.png: Added.
- platform/mac/http/tests/misc/favicon-as-image-expected.txt: Added.
- platform/mac-leopard/fast/images: Added.
- platform/mac-leopard/fast/images/favicon-as-image-expected.checksum: Copied from platform/mac/fast/images/favicon-as-image-expected.checksum.
- platform/mac-leopard/fast/images/favicon-as-image-expected.png: Copied from platform/mac/fast/images/favicon-as-image-expected.png.
- platform/mac-leopard/fast/images/favicon-as-image-expected.txt: Copied from platform/mac/fast/images/favicon-as-image-expected.txt.
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- 8:25 PM Changeset in webkit [43541] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Build fix. Build JITOpcodes.cpp to resolve linking errors
- 7:31 PM Changeset in webkit [43540] by
-
- 2 edits in trunk/LayoutTests
[GTK] Disable layouttest that requires an AccessibilityController
DRT/GTK+ lacks an AccessibilityController do not run the
accessibility/onclick-handlers.thtml test.
- platform/gtk/Skipped:
- 6:52 PM Changeset in webkit [43539] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-11 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
More re-factoring of JIT code generation. Use a macro to
forward the main switch-statement cases to the helper functions.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- 6:50 PM Changeset in webkit [43538] by
-
- 3 edits2 adds in trunk
Bug 25713: AX: Control Elements not identified in HTML content
https://bugs.webkit.org/show_bug.cgi?id=25713
- 6:40 PM Changeset in webkit [43537] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-11 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
More re-factoring of JIT code generation to move opcode generation
to helper functions outside the main switch-statement and gave those
helper functions standardized names. This patch covers the remaining
slow cases.
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITOpcodes.cpp:
- 6:33 PM Changeset in webkit [43536] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-11 Geoffrey Garen <ggaren@apple.com>
Build fix.
- GNUmakefile.am: Added JITOpcodes.cpp and JITStubCall.h to the project.
- 6:30 PM Changeset in webkit [43535] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-11 Geoffrey Garen <ggaren@apple.com>
Build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added JITOpcodes.cpp and JITStubCall.h to the project.
- 6:26 PM Changeset in webkit [43534] by
-
- 9 edits1 copy in trunk/JavaScriptCore
2009-05-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Some JIT refactoring.
Moved JITStubCall* into its own header.
Modified JITStubCall to ASSERT that its return value is handled correctly.
Also, replaced function template with explicit instantiations to resolve
some confusion.
Replaced all uses of emit{Get,Put}CTIArgument with explicit peeks, pokes,
and calls to killLastResultRegister().
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITArithmetic.cpp:
- jit/JITCall.cpp:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
- jit/JITPropertyAccess.cpp:
- jit/JITStubCall.h: Copied from jit/JIT.h. (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): (JSC::JITStubCall::):
- 6:25 PM Changeset in webkit [43533] by
-
- 4 edits in trunk
WebCore:
2009-05-11 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6276843> REGRESSION: TextIterator generates
an extra newline for ranges that start outside of body
- editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Check startPos for null, not just currPos.
LayoutTests:
2009-05-11 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6276843> REGRESSION: TextIterator generates
an extra newline for ranges that start outside of body
- editing/text-iterator/basic-iteration-expected.txt: Expect success, not failure.
- 6:09 PM Changeset in webkit [43532] by
-
- 2 edits in trunk/WebCore
Bug 25700: Regression:WebKit:cmd-left and cmd-right use to go to the beginning and end of a line in Mail
https://bugs.webkit.org/show_bug.cgi?id=25700
- 6:06 PM Changeset in webkit [43531] by
-
- 6 edits1 copy in trunk/JavaScriptCore
2009-05-11 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Start re-factoring JIT code generation to move op_code generation
to helper functions outside the main switch-statement and gave those
helper functions standardized names. This patch only covers the main
pass and all the arithmetic opcodes in the slow path.
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp:
- jit/JITOpcodes.cpp: Copied from jit/JIT.cpp.
- jit/JITPropertyAccess.cpp:
- 5:48 PM Changeset in webkit [43530] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-11 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25697
[GTK] Warnings building WebKit/gtk/tests/testwebframe.c
- tests/testwebframe.c: (test_webkit_web_frame_create_destroy): Declare webView as a GtkWidget* to fix pointer type incompatibility warnings.
- 5:28 PM Changeset in webkit [43529] by
-
- 2 edits2 adds in trunk/LayoutTests
2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Enable the new passing test, and skip two new failing tests.
- platform/gtk/Skipped:
- platform/gtk/fast/css/compare-content-style-expected.txt: Added.
- 5:14 PM Changeset in webkit [43528] by
-
- 54 edits in trunk/WebCore
Bug 25087: Test for ENABLE_FOO macros consistently in IDL files
Reviewed by Timothy Hatcher.
Change tests for ENABLE macros to check for both existence and
value:
Negative: #if !defined(ENABLE_FOO) !ENABLE_FOO - Positive: #if defined(ENABLE_FOO) && ENABLE_FOO
- css/CSSCharsetRule.idl:
- css/CSSPrimitiveValue.idl:
- css/RGBColor.idl:
- dom/Attr.idl:
- dom/DOMCoreException.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventException.idl:
- dom/KeyboardEvent.idl:
- dom/MessagePort.idl:
- dom/MouseEvent.idl:
- dom/Node.idl:
- dom/ProcessingInstruction.idl:
- dom/Range.idl:
- dom/RangeException.idl:
- dom/WheelEvent.idl:
- html/CanvasPixelArray.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLAppletElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLBaseFontElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLLinkElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptionElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.idl:
- html/HTMLStyleElement.idl:
- html/ImageData.idl:
- inspector/InspectorController.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/Console.idl:
- page/Coordinates.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/Geoposition.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- svg/SVGElementInstance.idl:
- svg/SVGException.idl:
- workers/WorkerContext.idl:
- xml/XMLHttpRequestException.idl:
- xml/XPathException.idl:
- 5:03 PM Changeset in webkit [43527] by
-
- 2 edits in trunk
Added missing bug titles and URLs.
- 5:01 PM Changeset in webkit [43526] by
-
- 11 edits in trunk
WebCore:
2009-05-11 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
class/struct mix-up in forward declarations
- inspector/InspectorResource.h:
- loader/CachedFont.h:
- loader/appcache/ApplicationCache.h:
- rendering/RenderBlock.h:
- rendering/RootInlineBox.h:
- rendering/SVGInlineTextBox.h:
- svg/SVGGlyphElement.h:
- svg/SVGHKernElement.h:
WebKit/qt:
2009-05-11 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
class/struct mix-up in forward declarations
- Api/qwebpage.h:
- 4:57 PM Changeset in webkit [43525] by
-
- 93 edits in tags/Safari-6530.9.1/JavaScriptCore
Merge r43520.
- 4:57 PM Changeset in webkit [43524] by
-
- 2 edits2 copies in tags/Safari-6530.9.1/SunSpider
Merge r43519.
- 4:54 PM Changeset in webkit [43523] by
-
- 2 edits in trunk/WebCore
2009-05-11 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
The Symbian tools can't compile and link this without this include.
It's not clear why this is different from other toolsets or why it affects
only this header file, but adding the include for now.
- editing/RemoveCSSPropertyCommand.h: Added include of CSSMutableStyleDeclaration.h.
- 4:35 PM Changeset in webkit [43522] by
-
- 5 edits3 adds in trunk
WebCore:
2009-05-11 Alice Liu <alice.liu@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=25701
REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook
Test: fast/forms/search-styled.html
- css/themeWin.css: Remove the overriding of -webkit-appearance for searchfields. This will cause background images to not be honored when styling searchfields
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSearchFieldStyle):
- rendering/RenderThemeWin.h: Re-instate final adjustments to searchfield styling that were removed in r42020
LayoutTests:
2009-05-11 Alice Liu <alice.liu@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=25701
REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook
- fast/forms/search-styled.html: Added.
- platform/mac/fast/forms/search-styled-expected.txt: Added.
- platform/win/fast/forms/search-styled-expected.txt: Added.
- 4:33 PM Changeset in webkit [43521] by
-
- 1 copy in tags/Safari-6530.9.1
New tag.
- 4:02 PM Changeset in webkit [43520] by
-
- 7 edits in trunk/JavaScriptCore
Re-add experimental PGO configs.
Reviewed by Adam Roben.
- JavaScriptCore.vcproj/JavaScriptCore.make:
- JavaScriptCore.vcproj/JavaScriptCore.sln:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- 3:54 PM Changeset in webkit [43519] by
-
- 1 edit2 adds in trunk/SunSpider
Include SunSpider tests in production builds.
Reviewed by Adam Roben.
- SunSpider.make: Added.
- xcopy.excludes: Added.
- 3:00 PM Changeset in webkit [43518] by
-
- 2 edits in trunk/WebCore
2009-05-11 Brady Eidson <beidson@apple.com>
Fix Windows build
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType):
- 3:00 PM Changeset in webkit [43517] by
-
- 2 edits in trunk/WebCore
2009-05-11 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25626
Update V8ElementCustom.cpp to match the current API of Node.
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::ACCESSOR_SETTER): Changed a couple of method names to match current names. (WebCore::ACCESSOR_GETTER): Changed a method name to match current name.
- 2:49 PM Changeset in webkit [43516] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-11 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey "1" Garen.
Rip out the !USE(CTI_REPATCH_PIC) code. It was untested and unused.
- jit/JIT.h: (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compileCTIMachineTrampolines):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID):
- 2:49 PM Changeset in webkit [43515] by
-
- 2 edits in trunk/WebCore
2009-05-11 Brady Eidson <beidson@apple.com>
Fix Windows build
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType): (WebCore::WebCoreSynchronousLoader::load):
- 2:36 PM Changeset in webkit [43514] by
-
- 2 edits in trunk/WebCore
2009-05-11 Brady Eidson <beidson@apple.com>
Fix Windows build
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType):
- 2:35 PM Changeset in webkit [43513] by
-
- 2 edits in trunk/WebCore
2009-05-11 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov.
V8CustomBinding.cpp is missing a header file
- bindings/v8/custom/V8CustomBinding.cpp: Added #include "V8Proxy.h".
- 2:30 PM Changeset in webkit [43512] by
-
- 4 edits in trunk/WebCore
2009-05-11 Aaron Boodman <aa@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25634
Change V8Proxy::retrieveActiveFrame() call sites to V8Proxy::retrieveFrameForEnteredContext().
Also, change instances of ScriptController::retrieveActiveFrame() to
V8::retrieveFrameForEnteredContext() for consistency.
See http://codereview.chromium.org/113085 for the corresponding Chromium change.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetLocation):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- 2:06 PM Changeset in webkit [43511] by
-
- 10 edits in trunk
WebCore:
2009-05-11 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/5972751> Local image files (BMP, ico) can be misidentified as HTML.
First part of the fix - Disable content sniffing for file resources which never should've been happening anyways.
Second part of the fix - If the networking layer doesn't give us back a MIME type default to "application/octet-stream".
- platform/MIMETypeRegistry.cpp: (WebCore::defaultMIMEType): "application/octet-stream"
- platform/MIMETypeRegistry.h:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): If content sniffing is true, double check with "shouldContentSniffRequest()" which might override it to false. (WebCore::ResourceHandle::shouldContentSniffURL): Return false for file:// urls, true for everything else.
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType): Create a copy of the CFURLRequest with the default MIME type instead of null. (WebCore::didReceiveResponse): If the MIME type for the response is null, create a copy with the default MIME type. (WebCore::WebCoreSynchronousLoader::load): Use shouldContentSniffRequest() to make synchronous loads have the same sniffing policy as asynchronous loads. Also, correct a null MIME type by creating a copy with the default type.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): Use shouldContentSniffRequest() to make synchronous loads have the same sniffing policy as asynchronous loads. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Set up the [NSURLResponse MIMEType] swizzling if it hasn't been set up yet. (_web_NSURLResponse_MIMEType): Either return the actual MIME type of the response, or the default MIME type if it's nil.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): Remove the workaround added in r29370 as it will now be covered by the new mechanism.
LayoutTests:
2009-05-11 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
- platform/mac-leopard/Skipped: Skip fast/images/favicon-as-image.html until we can come up with a better solution to its new failure.
- 1:37 PM Changeset in webkit [43510] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-11 Dmitry Titov <dimich@chromium.org>
GTK build fix - the deprecated waitForThreadCompletion is not needed on GTK.
- wtf/ThreadingPthreads.cpp: added #ifdef PLATFORM(DARWIN) around waitForThreadCompletion().
- 1:34 PM Changeset in webkit [43509] by
-
- 3 edits in trunk/WebCore
Fix typo "APPLICATION_CAHE_DYNAMIC_ENTRIES" to "APPLICATION_CACHE_DYNAMIC_ENTRIES"
This was added in r39816 to disable dynamic entries. They are
still disabled after fixing the typo since this feature define
is never set anywhere.
- bindings/js/JSDOMApplicationCacheCustom.cpp:
- loader/appcache/DOMApplicationCache.idl:
- 1:28 PM Changeset in webkit [43508] by
-
- 2 edits in trunk/JavaScriptCore
Build fix for newer versions of GCC
- wtf/ThreadingPthreads.cpp: Added a declaration of waitForThreadCompletion before its definition to silence a warning.
- 12:49 PM Changeset in webkit [43507] by
-
- 23 edits in trunk
2009-05-11 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov and Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
- wtf/Threading.h: (WTF::ThreadIdentifier::ThreadIdentifier): (WTF::ThreadIdentifier::isValid): (WTF::ThreadIdentifier::invalidate): (WTF::ThreadIdentifier::platformId): ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and methods that are used across the code on thread ids: construction, comparisons, check for 'valid' state etc. '0' is used as invalid id, which happens to just work with all platform-specific thread id implementations.
All the following files repeatedly reflect the new ThreadIdentifier for each platform.
We remove ThreadMap and threadMapMutex from all of them, remove the functions that
populated/searched/cleared the map and add platform-specific comparison operators
for ThreadIdentifier.
There are specific temporary workarounds for Safari 4 beta on OSX and Win32 since the
public build uses WTF threading functions with old type of ThreadingIdentifier.
The next time Safari 4 is rebuilt, it will 'automatically' pick up the new type and new
functions so the deprecated ones can be removed.
- wtf/gtk/ThreadingGtk.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
- wtf/ThreadingNone.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=):
- wtf/ThreadingPthreads.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread): (WTF::waitForThreadCompletion): This is a workaround for Safari 4 beta on Mac. Safari 4 is linked against old definition of ThreadIdentifier so it treats it as uint32_t. This 'old' variant of waitForThreadCompletion takes uint32_t and has the old decorated name, so Safari can load it from JavaScriptCore library. The other functions (CurrentThread() etc) happen to match their previous decorated names and, while they return pthread_t now, it is a pointer which round-trips through a uint32_t. This function will be removed as soon as Safari 4 will release next public build.
- wtf/qt/ThreadingQt.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
- wtf/ThreadingWin.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): All the platforms (except Windows) used a sequential counter as a thread ID and mapped it into platform ID. Windows was using native thread id and mapped it into thread handle. Since we can always obtain a thread handle by thread id, createThread now closes the handle. (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle, it means the thread already exited. (WTF::detachThread): (WTF::currentThread): (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now). (WTF::waitForThreadCompletionDeprecated): same. (WTF::currentThreadDeprecated): same. (WTF::createThreadDeprecated): same.
- bytecode/SamplingTool.h:
- bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
- JavaScriptCore.exp: export lists - updated decorated names of the WTF threading functions since they now take a different type as a parameter.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.
WebCore:
2009-05-11 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov and Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
Most of the change is in WTF.
Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
is now a class rather then an integer.
Also, there is no need to initialize threadID in constructors to 0 now.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id, since now ThreadIdentifier needs construction and we avoid having global initializers. (WebCore::matchFunc): use the new accessor function. (WebCore::openFunc): ditto. (WebCore::createStringParser): ditto. (WebCore::createMemoryParser): ditto.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::close):
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync): (WebCore::LocalStorageThread::terminate):
- workers/WorkerThread.cpp: (WebCore::WorkerThread::start): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start):
WebKit/win:
2009-05-11 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov and Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
Most of the change is in WTF and WebCore.
- WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones. Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones can be removed.
- WebKit.vcproj/WebKit_debug.def: same.
- 11:54 AM Changeset in webkit [43506] by
-
- 4 edits3 adds in trunk
2009-05-11 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 25560: REGRESSION (r34821): "string value".proto gets the wrong object.
https://bugs.webkit.org/show_bug.cgi?id=25560
rdar://problem/6861069
I missed this case back a year ago when I sped up handling
of JavaScript wrappers. Easy to fix.
- runtime/JSObject.h: (JSC::JSValue::get): Return the prototype itself if the property name is proto.
- runtime/JSString.cpp: (JSC::JSString::getOwnPropertySlot): Ditto.
LayoutTests:
2009-05-11 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 25560: REGRESSION (r34821): "string value".proto gets the wrong object.
https://bugs.webkit.org/show_bug.cgi?id=25560
rdar://problem/6861069
- fast/js/prototypes-expected.txt: Added.
- fast/js/prototypes.html: Added.
- fast/js/resources/prototypes.js: Added.
- 11:37 AM S60Reindeer edited by
- BUG REPORT? (diff)
- 11:05 AM Changeset in webkit [43505] by
-
- 4 edits in trunk/JavaScriptCore
Rename emitGetFromCallFrameHeader to emitGetFromCallFrameHeaderPtr
Reviewed by Maciej Stachowiak
- 10:41 AM Changeset in webkit [43504] by
-
- 80 edits in branches/nitro-extreme/JavaScriptCore
2009-05-11 Sam Weinig <sam@webkit.org>
Roll out improperly merged strcat code.
- 10:28 AM Changeset in webkit [43503] by
-
- 3 edits1 delete in trunk/WebCore
2009-05-11 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Remove unused header that declared one function which was never defined anywhere.
- WebCore.vcproj/WebCore.vcproj:
- platform/network/cf/ResourceResponseCFNet.cpp: Change to include ResourceResponse.h (which really means platform/network/cf/ResourceResponse.h)
- platform/network/cf/ResourceResponseCFNet.h: Removed.
- 10:24 AM Changeset in webkit [43502] by
-
- 57 edits1 delete in branches/nitro-extreme/JavaScriptCore
2009-05-11 Sam Weinig <sam@webkit.org>
Roll out improperly merged native function thunk code.
- 10:06 AM Changeset in webkit [43501] by
-
- 2 edits in trunk/LayoutTests
Added webarchive/test-link-rel-icon.html to gtk Skipped list
- platform/gtk/Skipped: Added webarchive/test-link-rel-icon.html.
- 10:00 AM Changeset in webkit [43500] by
-
- 2 edits in trunk/WebCore
2009-05-11 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=25213
Fix assert during Inspector destruction.
- inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): Moved closing
inspector above removing InspectorController object to fix JS errors,
added clearing inspector page ptr.
- 9:44 AM Changeset in webkit [43499] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
Bug 23331: LayoutTests/webarchive/test-link-rel-icon.html fails in different ways on buildbots
Reviewed by Brady Eidson.
- webarchive/test-link-rel-icon-expected.webarchive: Updated results after removing workaround in the test.
- webarchive/test-link-rel-icon.html: Copied from webarchive/test-link-rel-icon.html-disabled. Removed workaround for Bug 21026 / <rdar://problem/6240826>.
- webarchive/test-link-rel-icon.html-disabled: Removed.
- 9:41 AM EFLWebKit edited by
- (diff)
- 9:41 AM EFLWebKit edited by
- (diff)
- 9:41 AM EFLWebKit created by
- 9:35 AM WikiStart edited by
- (diff)
- 9:22 AM Changeset in webkit [43498] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Build fix, build ParserArena.cpp
- 9:22 AM Changeset in webkit [43497] by
-
- 4 edits in trunk
WebCore
2009-05-11 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] Make sure that public APIs are properly exported on all Qt platforms
https://bugs.webkit.org/show_bug.cgi?id=25601
- WebCore.pro: Define QT_MAKEDLL for all non-static builds, not just for win
WebKitTools
2009-05-11 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] Make sure that public APIs are properly exported on all Qt platforms
https://bugs.webkit.org/show_bug.cgi?id=25601
- Scripts/webkitdirs.pm: Remove QT_SHARED define from Qt builds, define QT_MAKEDLL in WebCore.pro instead
- 9:22 AM Changeset in webkit [43496] by
-
- 4 edits in trunk/WebKit/qt
2009-05-11 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
Fix Qt build when ENABLE_DATABASE is turned off
- Api/qwebdatabase.cpp: (QWebDatabase::displayName): (QWebDatabase::expectedSize): (QWebDatabase::size): (QWebDatabase::fileName): (QWebDatabase::removeDatabase):
- Api/qwebdatabase_p.h:
- Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::allOrigins): (QWebSecurityOrigin::databases):
- 9:22 AM Changeset in webkit [43495] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-11 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
Symbian compilers cannot resolve WTF::PassRefPtr<JSC::Profile>
unless Profile.h is included.
- profiler/ProfileGenerator.h:
- 9:21 AM Changeset in webkit [43494] by
-
- 5 edits in trunk
JavaScriptCore
2009-05-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Holger Freyther.
- JavaScriptCore.pri: coding style modified
- jsc.pro: duplicated values removed from INCLUDEPATH, DEFINES
WebCore
2009-05-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Holger Freyther.
- WebCore.pro: duplicated values removed from INCLUDEPATH
- 9:21 AM Changeset in webkit [43493] by
-
- 3 edits in trunk/WebCore
2009-05-11 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Build fix Symbian; clean Up WebKit/Qt if ENABLE_NETSCAPE_PLUGIN_API=0
https://bugs.webkit.org/show_bug.cgi?id=24688
- WebCore.pro: Use platform independent plugin stubs if ENABLE_NETSCAPE_PLUGIN_API=0
- platform/qt/TemporaryLinkStubs.cpp: Remove stub functions for plugins
- 9:10 AM Changeset in webkit [43492] by
-
- 2 edits in trunk/LayoutTests
2009-05-11 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Fix failure seen on most of the buildbots.
- fast/forms/text-control-intrinsic-widths-expected.txt: Rolled back to the version before Hyatt's recent intrinsic margin check-in. According to Dan, that should not have had any effect on this test, so these results reflect some other sort of difference on Hyatt's computer.
- 8:17 AM Changeset in webkit [43491] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by NOBODY (build fix).
Also add ParserArena, in addition to AllInOne, for release builds,
since adding it to AllInOne breaks Mac.
- GNUmakefile.am:
- 7:55 AM Changeset in webkit [43490] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix. Adding ParserArena to the autotools build.
- GNUmakefile.am:
- 7:50 AM Changeset in webkit [43489] by
-
- 3 edits in trunk/JavaScriptCore
More Windows build fixes after r43479
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Export ParserArena::reset.
- 7:36 AM Changeset in webkit [43488] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fixes after r43479
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added ParserArena to the project.
- parser/NodeConstructors.h: Added a missing include. (JSC::ParserArenaDeletable::operator new): Marked these as inline.
- 6:57 AM Changeset in webkit [43487] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-05-11 Anton Shestakov <engored@ya.ru>
Rubber-stamped by Gustavo Noronha.
New Russian translation.
- ru.po: Added.
- 3:55 AM Changeset in webkit [43486] by
-
- 5 edits in trunk/JavaScriptCore
Revert "2009-05-11 Jan Michael Alonzo <jmalonzo@webkit.org>"
This reverts commit r43485 as it fails the mac bots.
- 3:34 AM Changeset in webkit [43485] by
-
- 5 edits in trunk/JavaScriptCore
2009-05-11 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by NOBODY (BuildFix).
Add ParserArena to AllInOneFile as well as gtk, qt and wx build
scripts.
- AllInOneFile.cpp:
- GNUmakefile.am:
- JavaScriptCore.pri:
- JavaScriptCoreSources.bkl:
- 12:06 AM Changeset in webkit [43484] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added unary slow cases.
Fixed a macro-related bug that cased unary postfix ops always to be
noops in codegen.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
May 10, 2009:
- 11:37 PM Changeset in webkit [43483] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-10 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add op_codes that have Stub only implementations.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- 11:22 PM Changeset in webkit [43482] by
-
- 5 edits in branches/nitro-extreme/JavaScriptCore
2009-05-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed some bugs in slow case generation and implemented our first two
slow cases: op_convert_this and op_add.
- jit/JIT.cpp: (JSC::JIT::emitLoad): (JSC::JIT::emitLoadReturnValue): (JSC::JIT::emitStore): (JSC::JIT::emitStoreReturnValue): (JSC::JIT::privateCompileMainPass): Renamed *VirtualRegister => *. Added emitLoadReturnValue for loading the return value of a stub function into a virtual register.
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile): Added slow cases for op_convert_this and
op_add. Restored slow case generation hook.
- jit/JIT.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): Removed two-return value JITStub call, since it's unused. Fixed a typo in return type tracking that caused an assertion failure.
- jit/JITStubs.cpp: (JSC::):
- jit/JITStubs.h: Fixed an error in JITStackFrame layout on 32bit: the reserved space is the size of a pointer, not the size of a JSValue.
- 11:06 PM Changeset in webkit [43481] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff Garen.
- fixed REGRESSION(r43432): Many JavaScriptCore tests crash in 64-bit https://bugs.webkit.org/show_bug.cgi?id=25680
Accound for the 64-bit instruction prefix when rewriting mov to lea on 64-bit.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace):
- 9:49 PM Changeset in webkit [43480] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-10 Geoffrey Garen <ggaren@apple.com>
Removed some code that was removed from TOT.
- jit/JIT.h:
- 9:30 PM Changeset in webkit [43479] by
-
- 13 edits2 adds in trunk/JavaScriptCore
2009-05-10 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
Bug 25674: syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674
Part two: Remove reference counting from most nodes.
- JavaScriptCore.exp: Updated.
- JavaScriptCore.xcodeproj/project.pbxproj: Added ParserArena.h and .cpp.
- parser/Grammar.y: Replaced uses of ParserRefCountedData with uses of ParserArenaData. Took out now-nonfunctional code that tries to manually release declaration list. Changed the new calls that create FuncDeclNode and FuncExprNode so that they use the proper version of operator new for the reference-counted idiom, not the deletion idiom.
- parser/NodeConstructors.h: (JSC::ParserArenaDeletable::operator new): Added. (JSC::ParserArenaRefCounted::ParserArenaRefCounted): Added. (JSC::Node::Node): Removed ParserRefCounted initializer. (JSC::ElementNode::ElementNode): Ditto. (JSC::PropertyNode::PropertyNode): Ditto. (JSC::ArgumentsNode::ArgumentsNode): Ditto. (JSC::SourceElements::SourceElements): Ditto. (JSC::ParameterNode::ParameterNode): Ditto. (JSC::FuncExprNode::FuncExprNode): Added ParserArenaRefCounted initializer. (JSC::FuncDeclNode::FuncDeclNode): Ditto. (JSC::CaseClauseNode::CaseClauseNode): Removed ParserRefCounted initializer. (JSC::ClauseListNode::ClauseListNode): Ditto. (JSC::CaseBlockNode::CaseBlockNode): Ditto.
- parser/NodeInfo.h: Replaced uses of ParserRefCountedData with uses of ParserArenaData.
- parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode): Added ParserArenaRefCounted initializer. (JSC::ProgramNode::create): Use the proper version of operator new for the reference-counted idiom, not the deletion idiom. Use the arena contains function instead of the vecctor find function. (JSC::EvalNode::create): Use the proper version of operator new for the reference-counted idiom, not the deletion idiom. Use the arena reset function instead of the vector shrink function. (JSC::FunctionBodyNode::createNativeThunk): Use the proper version of operator new for the reference-counted idiom, not the deletion idiom. (JSC::FunctionBodyNode::create): More of the same.
- parser/Nodes.h: Added ParserArenaDeletable and ParserArenaRefCounted to replace ParserRefCounted. Fixed inheritance so only the classes that need reference counting inherit from ParserArenaRefCounted.
- parser/Parser.cpp: (JSC::Parser::parse): Set m_sourceElements to 0 since it now starts uninitialized. Just set it to 0 again in the failure case, since it's now just a raw pointer, not an owning one. (JSC::Parser::reparseInPlace): Removed now-unneeded get() function. (JSC::Parser::didFinishParsing): Replaced uses of ParserRefCountedData with uses of ParserArenaData.
- parser/Parser.h: Less RefPtr, more arena.
- parser/ParserArena.cpp: Added.
- parser/ParserArena.h: Added.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::~JSGlobalData): Removed arena-related code, since it's now in the Parser. (JSC::JSGlobalData::createLeaked): Removed unneeded #ifndef. (JSC::JSGlobalData::createNativeThunk): Tweaked #if a bit.
- runtime/JSGlobalData.h: Removed parserArena, which is now in Parser.
- wtf/RefCounted.h: Added deletionHasBegun function, for use in assertions to catch deletion not done by the deref function.
- 5:48 PM Changeset in webkit [43478] by
-
- 3 edits in trunk/JavaScriptCore
Part 2: Try to fix the Windows build by adding a symbol which is really just a re-mangling of a changed method signature
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 5:43 PM Changeset in webkit [43477] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix a crash when deactivating a document that had adopted a <form> element
Test: fast/dom/HTMLFormElement/document-deactivation-callback-crash.html
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Corrected the logic here: <form> elements should be registered for document activation callbacks if and only if autocomplete is off.
LayoutTests:
Reviewed by Darin Adler.
- test for a crash when deactivating a document that had adopted a <form> element
- fast/dom/HTMLFormElement/document-deactivation-callback-crash-expected.txt: Added.
- fast/dom/HTMLFormElement/document-deactivation-callback-crash.html: Added.
- 5:36 PM Changeset in webkit [43476] by
-
- 3 edits in trunk/JavaScriptCore
Try to fix the Windows build by removing an unknown symbol
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 5:27 PM Changeset in webkit [43475] by
-
- 2 edits in trunk/JavaScriptCore
Touch Nodes.cpp to try to fix Windows build
- parser/Nodes.cpp: Removed whitespace.
- 5:03 PM Changeset in webkit [43474] by
-
- 1 edit2 adds in trunk/LayoutTests
Test for Bug 23741: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer
Rubber-stamped by Geoff Garen.
Original test by Simon Fraser.
- fast/css/compare-content-style.html: Added.
- platform/mac/fast/css/compare-content-style-expected.txt: Added.
- 4:33 PM Changeset in webkit [43473] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-10 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Be a little more consistent with how we arrange parameters for functions
that operate on virtual registers.
- jit/JIT.cpp: (JSC::JIT::emitStoreConstant): (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- 3:46 PM Changeset in webkit [43472] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-10 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
Quick fix for failures seen on buildbot. Maciej plans a better fix later.
- wtf/dtoa.cpp: Change the hardcoded number of 32-bit words in a BigInt from 32 to 64. Parsing "1e500", for example, requires more than 32 words.
- 3:32 PM Changeset in webkit [43471] by
-
- 13 edits in trunk/JavaScriptCore
2009-05-10 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25674: syntax tree nodes should use arena allocation
Part one: Change lifetimes so we won't have to use reference
counting so much, but don't eliminate the reference counts
entirely yet.
- JavaScriptCore.exp: Updated.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Update for use of raw pointers instead of RefPtr. (JSC::BytecodeGenerator::emitCall): Ditto. (JSC::BytecodeGenerator::emitConstruct): Ditto.
- parser/Grammar.y: Update node creating code to use new (JSGlobalData*) instead of the plain new. At the moment this is just a hook for future arena allocation; it's inline and JSGlobalData* is not used.
- parser/NodeConstructors.h: Updated for name change of parserObjects to parserArena. Also added explicit initialization for raw pointers that used to be RefPtr. Also removed some uses of get() that aren't needed now that the pointers are raw pointers. Also eliminated m_parameter from FuncExprNode and FuncDeclNode. Also changed node-creating code to use new (JSGlobalData*) as above.
- parser/Nodes.cpp: Eliminated NodeReleaser and all use of it. (JSC::ParserRefCounted::ParserRefCounted): Updated for name change of parserObjects to parserArena. (JSC::SourceElements::append): Use raw pointers. (JSC::ArrayNode::emitBytecode): Ditto. (JSC::ArrayNode::isSimpleArray): Ditto. (JSC::ArrayNode::toArgumentList): Ditto. (JSC::ObjectLiteralNode::emitBytecode): Ditto. (JSC::PropertyListNode::emitBytecode): Ditto. (JSC::BracketAccessorNode::emitBytecode): Ditto. (JSC::DotAccessorNode::emitBytecode): Ditto. (JSC::ArgumentListNode::emitBytecode): Ditto. (JSC::NewExprNode::emitBytecode): Ditto. (JSC::EvalFunctionCallNode::emitBytecode): Ditto. (JSC::FunctionCallValueNode::emitBytecode): Ditto. (JSC::FunctionCallResolveNode::emitBytecode): Ditto. (JSC::FunctionCallBracketNode::emitBytecode): Ditto. (JSC::FunctionCallDotNode::emitBytecode): Ditto. (JSC::CallFunctionCallDotNode::emitBytecode): Ditto. (JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto. (JSC::PostfixBracketNode::emitBytecode): Ditto. (JSC::PostfixDotNode::emitBytecode): Ditto. (JSC::DeleteBracketNode::emitBytecode): Ditto. (JSC::DeleteDotNode::emitBytecode): Ditto. (JSC::DeleteValueNode::emitBytecode): Ditto. (JSC::VoidNode::emitBytecode): Ditto. (JSC::TypeOfValueNode::emitBytecode): Ditto. (JSC::PrefixBracketNode::emitBytecode): Ditto. (JSC::PrefixDotNode::emitBytecode): Ditto. (JSC::UnaryOpNode::emitBytecode): Ditto. (JSC::BinaryOpNode::emitStrcat): Ditto. (JSC::BinaryOpNode::emitBytecode): Ditto. (JSC::EqualNode::emitBytecode): Ditto. (JSC::StrictEqualNode::emitBytecode): Ditto. (JSC::ReverseBinaryOpNode::emitBytecode): Ditto. (JSC::ThrowableBinaryOpNode::emitBytecode): Ditto. (JSC::InstanceOfNode::emitBytecode): Ditto. (JSC::LogicalOpNode::emitBytecode): Ditto. (JSC::ConditionalNode::emitBytecode): Ditto. (JSC::ReadModifyResolveNode::emitBytecode): Ditto. (JSC::AssignResolveNode::emitBytecode): Ditto. (JSC::AssignDotNode::emitBytecode): Ditto. (JSC::ReadModifyDotNode::emitBytecode): Ditto. (JSC::AssignBracketNode::emitBytecode): Ditto. (JSC::ReadModifyBracketNode::emitBytecode): Ditto. (JSC::CommaNode::emitBytecode): Ditto. (JSC::ConstDeclNode::emitCodeSingle): Ditto. (JSC::ConstDeclNode::emitBytecode): Ditto. (JSC::ConstStatementNode::emitBytecode): Ditto. (JSC::statementListEmitCode): Ditto. (JSC::BlockNode::emitBytecode): Ditto. (JSC::ExprStatementNode::emitBytecode): Ditto. (JSC::VarStatementNode::emitBytecode): Ditto. (JSC::IfNode::emitBytecode): Ditto. (JSC::IfElseNode::emitBytecode): Ditto. (JSC::DoWhileNode::emitBytecode): Ditto. (JSC::WhileNode::emitBytecode): Ditto. (JSC::ForNode::emitBytecode): Ditto. (JSC::ForInNode::emitBytecode): Ditto. (JSC::ReturnNode::emitBytecode): Ditto. (JSC::WithNode::emitBytecode): Ditto. (JSC::CaseBlockNode::tryOptimizedSwitch): Ditto. (JSC::CaseBlockNode::emitBytecodeForBlock): Ditto. (JSC::SwitchNode::emitBytecode): Ditto. (JSC::LabelNode::emitBytecode): Ditto. (JSC::ThrowNode::emitBytecode): Ditto. (JSC::TryNode::emitBytecode): Ditto. (JSC::ScopeNodeData::ScopeNodeData): Use swap to transfer ownership of the arena, varStack and functionStack. (JSC::ScopeNode::ScopeNode): Pass in the arena when creating the ScopeNodeData. (JSC::ProgramNode::ProgramNode): Made this inline since it's used in only one place. (JSC::ProgramNode::create): Changed this to return a PassRefPtr since we plan to have the scope nodes be outside the arena, so they will need some kind of ownership transfer (maybe auto_ptr instead of PassRefPtr in the future, though). Remove the node from the newly-created arena to avoid a circular reference. Later we'll keep the node out of the arena by using a different operator new, but for now it's the ParserRefCounted constructor that puts the node into the arena, and there's no way to bypass that. (JSC::EvalNode::EvalNode): Ditto. (JSC::EvalNode::create): Ditto. (JSC::FunctionBodyNode::FunctionBodyNode): Ditto. (JSC::FunctionBodyNode::createNativeThunk): Moved the code that reseets the arena here instead of the caller. (JSC::FunctionBodyNode::create): Same change as the other create functions above. (JSC::FunctionBodyNode::emitBytecode): Use raw pointers.
- parser/Nodes.h: Removed NodeReleaser. Changed FunctionStack to use raw pointers. Removed the releaseNodes function. Added an override of operator new that takes a JSGlobalData* to prepare for future arena use. Use raw pointers instead of RefPtr everywhere possible.
- parser/Parser.cpp: (JSC::Parser::reparseInPlace): Pass the arena in.
- parser/Parser.h: (JSC::Parser::parse): Updated for name change of parserObjects to parserArena. (JSC::Parser::reparse): Ditto.
- runtime/FunctionConstructor.cpp: (JSC::extractFunctionBody): Ditto.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::~JSGlobalData): Ditto. (JSC::JSGlobalData::createNativeThunk): Moved arena manipulation into the FunctionBodyNode::createNativeThunk function.
- runtime/JSGlobalData.h: Tweaked formatting and renamed parserObjects to parserArena.
- wtf/NotFound.h: Added the usual "using WTF" to this header to match the rest of WTF.
- 2:28 PM Changeset in webkit [43470] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-10 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix typo. op_loop should not be using the fact that it and op_end are the
same length.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- 2:00 PM Changeset in webkit [43469] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-10 Sam Weinig <sam@webkit.org>
Build fix.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- parser/Nodes.h:
- runtime/Operations.h: (JSC::concatenateStrings):
- 1:53 PM Changeset in webkit [43468] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-10 Sam Weinig <sam@webkit.org>
Fix typo in a comment.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- 1:45 PM Changeset in webkit [43467] by
-
- 13 edits in branches/nitro-extreme/JavaScriptCore
2009-05-10 Sam Weinig <sam@webkit.org>
Merge string concatenation from r43331.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitStrcat): (JSC::BytecodeGenerator::emitToPrimitive):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_strcat):
- parser/Nodes.cpp: (JSC::BinaryOpNode::emitStrcat): (JSC::BinaryOpNode::emitBytecode):
- parser/Nodes.h: (JSC::ExpressionNode::): (JSC::DeleteBracketNode::):
- parser/ResultType.h: (JSC::ResultType::definitelyIsString): (JSC::ResultType::forAdd):
- runtime/Operations.h: (JSC::concatenateStrings):
- runtime/UString.cpp: (JSC::UString::appendNumeric):
- runtime/UString.h: (JSC::UString::Rep::createEmptyBuffer): (JSC::UString::BaseString::BaseString):
- 1:32 PM Changeset in webkit [43466] by
-
- 40 edits in branches/nitro-extreme
2009-05-10 Sam Weinig <sam@webkit.org>
Merge more native function thunk code from r43372
- API/JSCallbackFunction.h:
- API/JSCallbackObject.h:
- interpreter/CallFrame.h: (JSC::ExecState::argumentCount):
- jsc.cpp: (functionPrint): (functionDebug): (functionGC): (functionVersion): (functionRun): (functionLoad): (functionSetSamplingFlags): (functionClearSamplingFlags): (functionReadline): (functionQuit):
- runtime/ArrayConstructor.cpp: (JSC::callArrayConstructor):
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): (JSC::arrayProtoFuncToLocaleString): (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncReverse): (JSC::arrayProtoFuncShift): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncReduce): (JSC::arrayProtoFuncReduceRight): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
- runtime/BooleanConstructor.cpp: (JSC::callBooleanConstructor):
- runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncToString): (JSC::booleanProtoFuncValueOf):
- runtime/CallData.h:
- runtime/DateConstructor.cpp: (JSC::callDate): (JSC::dateParse): (JSC::dateNow): (JSC::dateUTC):
- runtime/DatePrototype.cpp: (JSC::dateProtoFuncToString): (JSC::dateProtoFuncToUTCString): (JSC::dateProtoFuncToDateString): (JSC::dateProtoFuncToTimeString): (JSC::dateProtoFuncToLocaleString): (JSC::dateProtoFuncToLocaleDateString): (JSC::dateProtoFuncToLocaleTimeString): (JSC::dateProtoFuncGetTime): (JSC::dateProtoFuncGetFullYear): (JSC::dateProtoFuncGetUTCFullYear): (JSC::dateProtoFuncToGMTString): (JSC::dateProtoFuncGetMonth): (JSC::dateProtoFuncGetUTCMonth): (JSC::dateProtoFuncGetDate): (JSC::dateProtoFuncGetUTCDate): (JSC::dateProtoFuncGetDay): (JSC::dateProtoFuncGetUTCDay): (JSC::dateProtoFuncGetHours): (JSC::dateProtoFuncGetUTCHours): (JSC::dateProtoFuncGetMinutes): (JSC::dateProtoFuncGetUTCMinutes): (JSC::dateProtoFuncGetSeconds): (JSC::dateProtoFuncGetUTCSeconds): (JSC::dateProtoFuncGetMilliSeconds): (JSC::dateProtoFuncGetUTCMilliseconds): (JSC::dateProtoFuncGetTimezoneOffset): (JSC::dateProtoFuncSetTime): (JSC::dateProtoFuncSetMilliSeconds): (JSC::dateProtoFuncSetUTCMilliseconds): (JSC::dateProtoFuncSetSeconds): (JSC::dateProtoFuncSetUTCSeconds): (JSC::dateProtoFuncSetMinutes): (JSC::dateProtoFuncSetUTCMinutes): (JSC::dateProtoFuncSetHours): (JSC::dateProtoFuncSetUTCHours): (JSC::dateProtoFuncSetDate): (JSC::dateProtoFuncSetUTCDate): (JSC::dateProtoFuncSetMonth): (JSC::dateProtoFuncSetUTCMonth): (JSC::dateProtoFuncSetFullYear): (JSC::dateProtoFuncSetUTCFullYear): (JSC::dateProtoFuncSetYear): (JSC::dateProtoFuncGetYear):
- runtime/ErrorConstructor.cpp: (JSC::callErrorConstructor):
- runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString):
- runtime/FunctionConstructor.cpp: (JSC::callFunctionConstructor):
- runtime/FunctionPrototype.cpp: (JSC::callFunctionPrototype): (JSC::functionProtoFuncToString): (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
- runtime/JSFunction.h: (JSC::JSFunction::nativeFunction): (JSC::JSFunction::setScopeChain):
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncDecodeURI): (JSC::globalFuncDecodeURIComponent): (JSC::globalFuncEncodeURI): (JSC::globalFuncEncodeURIComponent): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
- runtime/JSGlobalObjectFunctions.h:
- runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRandom): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
- runtime/NativeErrorConstructor.cpp: (JSC::callNativeErrorConstructor):
- runtime/NumberConstructor.cpp: (JSC::callNumberConstructor):
- runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToLocaleString): (JSC::numberProtoFuncValueOf): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
- runtime/ObjectConstructor.cpp: (JSC::callObjectConstructor):
- runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncValueOf): (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable): (JSC::objectProtoFuncToLocaleString): (JSC::objectProtoFuncToString):
- runtime/ObjectPrototype.h:
- runtime/RegExpConstructor.cpp: (JSC::callRegExpConstructor):
- runtime/RegExpObject.cpp: (JSC::callRegExpObject):
- runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncTest): (JSC::regExpProtoFuncExec): (JSC::regExpProtoFuncCompile): (JSC::regExpProtoFuncToString):
- runtime/StringConstructor.cpp: (JSC::stringFromCharCode): (JSC::callStringConstructor):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncToString): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncToLowerCase): (JSC::stringProtoFuncToUpperCase): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncBig): (JSC::stringProtoFuncSmall): (JSC::stringProtoFuncBlink): (JSC::stringProtoFuncBold): (JSC::stringProtoFuncFixed): (JSC::stringProtoFuncItalics): (JSC::stringProtoFuncStrike): (JSC::stringProtoFuncSub): (JSC::stringProtoFuncSup): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):
- wtf/Platform.h:
WebCore:
2009-05-10 Sam Weinig <sam@webkit.org>
Merge more native function thunk code from r43372
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::callHTMLCollection):
- bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList):
- bindings/js/JSPluginElementFunctions.cpp: (WebCore::callPlugin):
- bindings/js/JSQuarantinedObjectWrapper.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/runtime_method.cpp: (JSC::callRuntimeMethod):
- bridge/runtime_object.cpp: (JSC::callRuntimeObject):
- 1:21 PM Changeset in webkit [43465] by
-
- 39 edits3 adds in branches/nitro-extreme
2009-05-10 Sam Weinig <sam@webkit.org>
Merge native function thunk code from r43220.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::call):
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::addPtr):
- assembler/X86Assembler.h: (JSC::X86Assembler::leaq_mr): (JSC::X86Assembler::call_m):
- interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall):
- jit/JIT.cpp: (JSC::JIT::linkCall):
- jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
- jit/JITCall.cpp: (JSC::JIT::linkCall): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
- jit/JITCode.h: (JSC::JITCode::operator bool):
- jit/JITInlineMethods.h: (JSC::JIT::emitGetFromCallFrameHeader): (JSC::JIT::emitGetFromCallFrameHeader32):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_JSFunction): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall): (JSC::JITStubs::cti_op_construct_JSConstruct):
- jit/JITStubs.h: (JSC::JITStubs::ctiNativeCallThunk):
- jsc.cpp: (GlobalObject::GlobalObject):
- parser/Nodes.cpp: (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::createNativeThunk): (JSC::FunctionBodyNode::generateJITCode):
- parser/Nodes.h: (JSC::FunctionBodyNode::): (JSC::FunctionBodyNode::generatedJITCode): (JSC::FunctionBodyNode::jitCode):
- profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier):
- runtime/ArgList.h:
- runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):
- runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
- runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
- runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
- runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::addFunctionProperties): (JSC::functionProtoFuncToString):
- runtime/FunctionPrototype.h:
- runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::~JSFunction): (JSC::JSFunction::mark): (JSC::JSFunction::getCallData): (JSC::JSFunction::call): (JSC::JSFunction::argumentsGetter): (JSC::JSFunction::callerGetter): (JSC::JSFunction::lengthGetter): (JSC::JSFunction::getOwnPropertySlot): (JSC::JSFunction::put): (JSC::JSFunction::deleteProperty): (JSC::JSFunction::getConstructData): (JSC::JSFunction::construct):
- runtime/JSFunction.h: (JSC::JSFunction::JSFunction): (JSC::JSFunction::setScope): (JSC::JSFunction::scope): (JSC::JSFunction::isHostFunction): (JSC::JSFunction::scopeChain): (JSC::JSFunction::clearScopeChain): (JSC::JSFunction::setScopeChain): (JSC::JSFunction::nativeFunction): (JSC::JSFunction::setNativeFunction):
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData): (JSC::JSGlobalData::createNativeThunk):
- runtime/JSGlobalData.h: (JSC::JSGlobalData::nativeFunctionThunk):
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
- runtime/JSGlobalObject.h:
- runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h:
- runtime/NativeFunctionWrapper.h: Added.
- runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
- runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype):
- runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
- runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
WebCore:
2009-05-10 Sam Weinig <sam@webkit.org>
Merge native function thunk code from r43220.
- ForwardingHeaders/jit: Added.
- ForwardingHeaders/jit/JITCode.h: Added.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
- 12:02 PM Changeset in webkit [43464] by
-
- 7 edits in branches/nitro-extreme/JavaScriptCore
2009-05-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Got JITStubs more or less working, and implemented emitTimeoutCheck(),
our first JITStub call.
Modified the magic constants in our trampolines to match the new layout
of JITStackFrame.
Added JITStubs back into the project / build.
Merged some stuff from JIT.h / JIT.cpp on trunk, with tweaks for the branch.
Brought the stubs up to par with the interpreter / new value representation.
Commented out a bunch of stub code that we haven't fully merged from TOT
yet (strcat, host function call changes). (Sam will merge and re-enable these
today.)
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JIT.cpp: (JSC::JIT::emitTimeoutCheck): (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline): (JSC::JIT::privateCompileMainPass):
- jit/JIT.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): (JSC::JITStubCall::): (JSC::CallEvalJITStub::CallEvalJITStub):
- jit/JITStubs.cpp: (JSC::JITStubs::JITStubs): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_call_JSFunction): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall): (JSC::JITStubs::cti_op_construct_JSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_strcat): (JSC::JITStubs::cti_op_switch_imm):
- jit/JITStubs.h: (JSC::JITStubs::ctiVirtualCall):
- runtime/JSValue.h: (JSC::JSValue::payload):
- 11:49 AM Changeset in webkit [43463] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=25670
Remove no longer valid chunk of code from dtoa.
- wtf/dtoa.cpp: (WTF::dtoa): Removed invalid code.
- 10:53 AM Changeset in webkit [43462] by
-
- 3 edits in trunk/WebCore
Reviewed by Dan Bernstein.
<rdar://problem/6867598> REGRESSION (r42483): Have to enter credentials twice when trying
to view protected MobileMe video
Add a temporary workaround.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Added an m_useSiteSpecificQuirks boolean (Mac-only). A Frame pointer is only available when starting a request, so we need to store this data for later use.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Initialize m_useSiteSpecificQuirks. (WebCore::ResourceHandle::receivedCredential): Use per-session credentials with gallery.me.com.
- 10:32 AM Changeset in webkit [43461] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoff Garen.
"Class const *" is the same as "const Class*", use the latter syntax consistently.
See <http://www.parashift.com/c++-faq-lite/const-correctness.html#faq-18.9>.
- pcre/pcre_compile.cpp: (calculateCompiledPatternLength):
- runtime/JSObject.h: (JSC::JSObject::offsetForLocation): (JSC::JSObject::locationForOffset):
- 10:01 AM Changeset in webkit [43460] by
-
- 9 edits1 move in trunk
Reviewed by Dan Bernstein.
<rdar://problem/6870383> Have to enter credentials twice when downloading from a protected page
Use credentials from WebCore storage when downloading.
- 9:57 AM Changeset in webkit [43459] by
-
- 4 edits in trunk/WebCore
Reviewed by Dan Bernstein.
Match newer XMLHttpRequest draft and make withCredential setter raise an exception when
called at a wrong time.
No test, because we are waiting for a newer version of system frameworks to test the attribute.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setWithCredentials):
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequest.idl: Raise INVALID_STATE_ERR if the state is not OPENED, or if the send() flag is true.
- 9:26 AM Changeset in webkit [43458] by
-
- 5 edits4 adds in trunk
WebCore:
Reviewed by Dave Kilzer.
- fix https://bugs.webkit.org/show_bug.cgi?id=25602 REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn on ToT
Test: fast/layers/self-painting-outline.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Paint the layer's own outline only if it is a self-painting layer.
LayoutTests:
Reviewed by Dave Kilzer.
- new test and correct results for https://bugs.webkit.org/show_bug.cgi?id=25602 REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn on ToT
- fast/layers/self-painting-outline.html: Added.
- platform/mac/fast/overflow/overflow-focus-ring-expected.checksum: Updated.
- platform/mac/fast/overflow/overflow-focus-ring-expected.png: Updated.
- platform/mac/fast/layers/self-painting-outline-expected.checksum: Added.
- platform/mac/fast/layers/self-painting-outline-expected.png: Added.
- platform/mac/fast/layers/self-painting-outline-expected.txt: Added.
- 4:32 AM Changeset in webkit [43457] by
-
- 5 edits in trunk/JavaScriptCore
2009-05-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Alexey Proskuryakov.
- speedup dtoa/strtod
Added a bunch of inlining, and replaced malloc with stack allocation.
0.5% SunSpider speedup (7% on string-tagcloud).
- runtime/NumberPrototype.cpp: (JSC::integerPartNoExp): (JSC::numberProtoFuncToExponential):
- runtime/UString.cpp: (JSC::concatenate): (JSC::UString::from):
- wtf/dtoa.cpp: (WTF::BigInt::BigInt): (WTF::BigInt::operator=): (WTF::Balloc): (WTF::Bfree): (WTF::multadd): (WTF::s2b): (WTF::i2b): (WTF::mult): (WTF::pow5mult): (WTF::lshift): (WTF::cmp): (WTF::diff): (WTF::b2d): (WTF::d2b): (WTF::ratio): (WTF::strtod): (WTF::quorem): (WTF::freedtoa): (WTF::dtoa):
- wtf/dtoa.h:
May 9, 2009:
- 10:54 PM Changeset in webkit [43456] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Optimized a few more cases to use memory operands instead of loading
into registers.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- 10:38 PM Changeset in webkit [43455] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Build fix.
- jit/JIT.h:
- jit/JITCode.h:
- 10:36 PM Changeset in webkit [43454] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more opcode action.
Added a set8 and deployed it.
Optimized op_bitnot to do a bitnot directly in memory if possible.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::not32): (JSC::MacroAssemblerX86Common::set8):
- assembler/X86Assembler.h: (JSC::X86Assembler::notl_m):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- 10:21 PM Changeset in webkit [43453] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Sam Weinig <sam@webkit.org>
Rubber-stamped by Geoffrey Garen.
Merge over the new JITStubs implementation from ToT.
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 10:14 PM Changeset in webkit [43452] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Don't test for a slow case if the operand of an arithmetic op is
known to be an integer constant.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32): (JSC::JIT::emitSub32): (JSC::JIT::emitMul32): (JSC::JIT::emitMod32): (JSC::JIT::emitBitAnd32): (JSC::JIT::emitBitOr32): (JSC::JIT::emitBitXor32): (JSC::JIT::emitLeftShift32): (JSC::JIT::emitRightShift32):
- 10:04 PM Changeset in webkit [43451] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Geoffrey Garen and Mark Rowe.
- fix https://bugs.webkit.org/show_bug.cgi?id=25666 Assertion failure in Node::setDocument() (willMoveToNewOwnerDocumentWasCalled) when adopting a <form> element
Test: fast/dom/HTMLFormElement/adopt-assertion.html
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Overrides of this method are required to call the base class implementation. Do it. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
LayoutTests:
Reviewed by Geoffrey Garen and Mark Rowe.
- test for https://bugs.webkit.org/show_bug.cgi?id=25666 Assertion failure in Node::setDocument() (willMoveToNewOwnerDocumentWasCalled) when adopting a <form> element
- fast/dom/HTMLFormElement/adopt-assertion-expected.txt: Added.
- fast/dom/HTMLFormElement/adopt-assertion.html: Added.
- 10:01 PM Changeset in webkit [43450] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed accidental reversal of opcodes part 2.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::neg32):
- 9:27 PM Changeset in webkit [43449] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed accidental reversal of opcodes.
- assembler/X86Assembler.h: (JSC::X86Assembler::negl_r): (JSC::X86Assembler::notl_r):
- 9:23 PM Changeset in webkit [43448] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
- jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32): Restored accidentally snipped out code from my last patch.
- 7:52 PM Changeset in webkit [43447] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Miscellaneous work on our existing opcodes.
Removed unnecessary load into register from mul32.
Fixed a bug where mod32 calculated the quotient instead of the remainder.
Fixed the debug build.
Added optimized cases for subtraction.
Established consistent naming of emitOp32[Details], removing cases of
emitOp[Details]32.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitSub32): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emitSub32InPlaceLeft): (JSC::JIT::emitSub32InPlaceRight): (JSC::JIT::emitMul32): (JSC::JIT::emitMul32Constant): (JSC::JIT::emitMul32InPlace): (JSC::JIT::emitMod32): (JSC::JIT::emitBitAnd32): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emitBitOr32): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emitBitXor32): (JSC::JIT::emitBitXor32Constant):
- 7:44 PM Changeset in webkit [43446] by
-
- 3 edits in trunk/LayoutTests
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Added a test for a math edge case I just came across.
- fast/js/postfix-syntax-expected.txt:
- fast/js/resources/postfix-syntax.js:
- 7:28 PM Changeset in webkit [43445] by
-
- 2 edits in trunk
2009-05-09 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
WebKit-r43163 won't build for gtk-directfb
https://bugs.webkit.org/show_bug.cgi?id=25538
Move the ENCHANT check out of the with_target conditional since it
applies to all targets
- configure.ac:
- 7:10 PM Changeset in webkit [43444] by
-
- 4 edits in trunk
2009-05-09 Mike Hommey <glandium@debian.org>
Reviewed by Geoffrey Garen. Landed by Jan Alonzo.
Enable JIT on x86-64 gtk+
https://bugs.webkit.org/show_bug.cgi?id=24724
- configure.ac:
2009-05-09 Mike Hommey <glandium@debian.org>
Reviewed by Geoffrey Garen. Landed by Jan Alonzo.
Enable JIT on x86-64 gtk+
https://bugs.webkit.org/show_bug.cgi?id=24724
- GNUmakefile.am:
- 6:13 PM Changeset in webkit [43443] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Cleaned up postfix ++/-- operators. 23% speedup in postfix operations.
The old code did an increment/decrement, and then stored to dst and srcDst,
dst getting the original value and srcDst getting the incremented value.
In order to pull that off, it needed to move a copy of the original
value to a second register, and do things in a generally inefficient
order. Instead, you can just store to dst before you do the increment.
Also fixed the build.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- 3:41 PM Changeset in webkit [43442] by
-
- 5 edits in trunk
Reviewed by Maciej Stachowiak.
WebCore::DocumentLoader::mainReceivedError now asserts if error.isNull(), so
make sure wx does not create empty ResourceError() objects.
https://bugs.webkit.org/show_bug.cgi?id=24927
- 3:05 PM Changeset in webkit [43441] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Removed the last non-call-related manually managed JIT stub call.
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArithSlow_op_rshift): Fully use the JITStubCall abstraction, instead of emitPutJITStubArg.
- 9:01 AM Changeset in webkit [43440] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-09 Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25653
PLATFORM(X86_64) inherits ia64
ia64 is defined by gcc in an IA64 arch and has completely
nothing in common with X86-64 exept both are from Intel and have
an 64bit address space. That's it. Since code seems to expect x86
here, ia64 has to go.
- wtf/Platform.h:
- 8:44 AM Changeset in webkit [43439] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-09 Gustavo Noronha Silva <Gustavo Noronha Silva>
Suggested by Geoffrey Garen.
Assume SSE2 is present on X86-64 and on MAC X86-32. This fixes a
build breakage on non-Mac X86-64 when JIT is enabled.
- jit/JITArithmetic.cpp:
- 8:14 AM Changeset in webkit [43438] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Sam Weinig <sam@webkit.org>
Cleanup. Switch uses of known int immediate access from using low
level u.asBits.payload to using asInt32().
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITArithmetic.cpp: (JSC::JIT::emitAddConstant32): (JSC::JIT::emitSub32): (JSC::JIT::emitMulConstant32): (JSC::JIT::emitMod32): (JSC::JIT::emitBitAndConstant32): (JSC::JIT::emitBitOrConstant32): (JSC::JIT::emitBitXorConstant32): (JSC::JIT::emitLeftShift32): (JSC::JIT::emitRightShift32):
- 7:38 AM Changeset in webkit [43437] by
-
- 4 edits in trunk
Build fix, adding missing files to make dist.
- 2:26 AM Changeset in webkit [43436] by
-
- 22 edits in trunk/LayoutTests
Correct the results from the previous patch
- 2:19 AM Changeset in webkit [43435] by
-
- 22 edits in trunk/LayoutTests
Update Windows-specific layout test results for textarea intrinsic
margins following r43355
- 1:54 AM Changeset in webkit [43434] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Windows build fix.
- assembler/X86Assembler.h: (JSC::X86Assembler::patchLoadToLEA):
- 1:49 AM Changeset in webkit [43433] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Windows build fix.
- assembler/X86Assembler.h: (JSC::X86Assembler::patchLoadToLEA):
- 1:35 AM Changeset in webkit [43432] by
-
- 12 edits in trunk/JavaScriptCore
2009-05-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Gavin Barraclough.
Original patch by John McCall. Updated by Cameron Zwarich. Further refined by me.
- Assorted speedups to property access
~.3%-1% speedup on SunSpider
1) When we know from the structure ID that an object is using inline storage, plant direct
loads and stores against it; no need to indirect through storage pointer.
2) Also because of the above, union the property storage pointer with the first inline property
slot and add an extra inline property slot.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationInstruction::CodeLocationInstruction): (JSC::AbstractMacroAssembler::CodeLocationInstruction::patchLoadToLEA): (JSC::::CodeLocationCommon::instructionAtOffset):
- assembler/MacroAssembler.h: (JSC::MacroAssembler::storePtr):
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::store32):
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::storePtr):
- assembler/X86Assembler.h: (JSC::X86Assembler::movq_EAXm): (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::patchLoadToLEA):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::removeDirect):
- runtime/JSObject.h: (JSC::JSObject::propertyStorage): (JSC::JSObject::getDirect): (JSC::JSObject::getOffset): (JSC::JSObject::offsetForLocation): (JSC::JSObject::locationForOffset): (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::isUsingInlineStorage): (JSC::JSObject::): (JSC::JSObject::JSObject): (JSC::JSObject::~JSObject): (JSC::Structure::isUsingInlineStorage): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::allocatePropertyStorageInline):
- runtime/Structure.h:
- 1:24 AM Changeset in webkit [43431] by
-
- 5 edits in trunk/JavaScriptCore
2009-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Changed all our JIT stubs so that they return a maximum of 1 JS value or
two non-JS pointers, and do all other value returning through out
parameters, in preparation for 64bit JS values on a 32bit system.
Stubs that used to return two JSValues now return one JSValue and take
and out parameter specifying where in the register array the second
value should go.
SunSpider reports no change.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArithSlow_op_post_inc): (JSC::JIT::compileFastArithSlow_op_post_dec):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_arityCheck): (JSC::JITStubs::cti_op_resolve_func): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_resolve_with_base): (JSC::JITStubs::cti_op_post_dec):
- jit/JITStubs.h: (JSC::):
- 12:02 AM Changeset in webkit [43430] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-09 Sam Weinig <sam@webkit.org>
Implement op_mod.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitMod32):
May 8, 2009:
- 11:12 PM Changeset in webkit [43429] by
-
- 2 edits in trunk/LayoutTests
2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
Skip failing render tree test that was added in r43420.
- platform/gtk/Skipped:
- 10:25 PM Changeset in webkit [43428] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed <rdar://problem/6634956> CrashTracer: [REGRESSION] >400 crashes
in Safari at com.apple.JavaScriptCore • JSC::BytecodeGenerator::emitComplexJumpScopes + 468
https://bugs.webkit.org/show_bug.cgi?id=25658
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitComplexJumpScopes): Guard the whole loop with a bounds check. The old loop logic would decrement and read topScope without a bounds check, which could cause crashes on page boundaries.
- 7:17 PM Changeset in webkit [43427] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by NOBODY (BuildFix).
Gtk fix: add LiteralParser to the build script per r43424.
Add LiteralParser to the Qt and Wx build scripts too.
- GNUmakefile.am:
- JavaScriptCore.pri:
- JavaScriptCoreSources.bkl:
- 7:05 PM Changeset in webkit [43426] by
-
- 4 edits in trunk/LayoutTests
Rubber-stamped by George Staikos.
Update WML <input> layout test result, as input field metrics have changed recently.
- 6:34 PM Changeset in webkit [43425] by
-
- 2 edits in trunk/WebKit/mac
Not reviewed. Fix clean builds, forgot to land name() -> formControlName() rename patch in WebKit. Only landed the WebCore side.
- 6:01 PM Changeset in webkit [43424] by
-
- 5 edits2 adds in trunk/JavaScriptCore
Add a limited literal parser for eval to handle object and array literals fired at eval
Reviewed by Gavin Barraclough and Darin Adler.
This is a simplified parser and lexer that we can throw at strings passed to eval
in case a site is using eval to parse JSON (eg. json2.js). The lexer is intentionally
limited (in effect it's whitelisting a limited "common" subset of the JSON grammar)
as this decreases the likelihood of us wating time attempting to parse any significant
amount of non-JSON content.
- 5:51 PM Changeset in webkit [43423] by
-
- 2 edits in trunk/WebCore
2009-05-08 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Reduce the inline capacity of CSSParserValueList's m_values
vector to reduce the size of CSSParserValueList from 544 to 160 bytes in 64-bit.
- css/CSSParserValues.h:
- 5:29 PM Changeset in webkit [43422] by
-
- 2 edits in trunk/WebCore
Not reviewed. Used sort-Xcode-project-file to sort the XCode project file - it hasn't been done for a while.
- 5:19 PM Changeset in webkit [43421] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-08 Sam Weinig <sam@webkit.org>
Implement constant operand cases for op_sub, op_lshift and op_rshift.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSub32): (JSC::JIT::emitLeftShift32): (JSC::JIT::emitRightShift32):
- 4:49 PM Changeset in webkit [43420] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6864786> REGRESSION: Crash below ApplyStyleCommand::applyInlineStyleToRange when reviewing a patch in Bugzilla
Test: editing/style/apply-through-end-of-document.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null check for the case of a range extending through the end of the document, in which pastEndNode is 0.
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6864786> REGRESSION: Crash below ApplyStyleCommand::applyInlineStyleToRange when reviewing a patch in Bugzilla
- editing/style/apply-through-end-of-document-expected.txt: Added.
- editing/style/apply-through-end-of-document.html: Added.
- 4:40 PM Changeset in webkit [43419] by
-
- 2 edits in trunk/WebCore
2009-05-08 Douglas R. Davidson <ddavidso@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/6857446> REGRESSION (Safari 3-4): Contraction base
marked as misspelled even though contraction is a word
Make sure spelling underline does not persist on words like
<doesn't>.
- editing/TypingCommand.cpp: (WebCore::TypingCommand::typingAddedToOpenCommand):
- 3:53 PM Changeset in webkit [43418] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Make sure the path's refdata isn't deleted before we're done with the object.
https://bugs.webkit.org/show_bug.cgi?id=25652
- 3:49 PM Changeset in webkit [43417] by
-
- 2 edits in trunk/WebCore
Fix memory leak for wxMac.
- 2:47 PM Changeset in webkit [43416] by
-
- 2 edits in trunk/WebKit/mac
2009-05-08 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
- Fix <rdar://problem/6866712>.
Instead of just caching whether a plug-in object _has_ a field or method, also add an entry to the cache
if it _doesn't_ have a certain field or method. This way we have to make fewer calls to the plug-in host.
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodsNamed): (WebKit::ProxyInstance::fieldNamed):
- 2:37 PM Changeset in webkit [43415] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Make the scan program call g_thread_init(NULL) in addition to
g_type_init(), so that it actually works.
- docs/GNUmakefile.am:
- 2:37 PM Changeset in webkit [43414] by
-
- 3 edits in trunk
2009-05-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Ship the gtk-doc.make file, so as to not depend on gtkdoc-tools.
- GNUmakefile.am:
- autogen.sh:
- 2:35 PM Changeset in webkit [43413] by
-
- 2 edits in trunk/WebCore
2009-05-08 Beth Dakin <Beth Dakin>
Reviewed by Dan Bernstein.
<rdar://problem/6857446> REGRESSION (r37591): Cannot print or
preview from maps.yandex.ru
We need to fall into the stretchesToViewHeight() quirk when we are
printing and we are the root and the root has percentage height OR
when we are the body and the root has percentage height. Otherwise
we have a height of 0 and can run into painting troubles.
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
- 2:12 PM Changeset in webkit [43412] by
-
- 6 edits in trunk
WebCore:
2009-05-08 Douglas Davidson <ddavidso@apple.com>
Reviewed by Darin Adler.
Fixes for <rdar://problem/6852771>.
Prevent text checking replacement immediately after an apostrophe
and automatic link addition except immediately after typing.
- editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
WebKit/mac:
2009-05-08 Douglas R. Davidson <ddavidso@apple.com>
Reviewed by Darin Adler.
Fixes for <rdar://problem/6852771>.
Disable text checking menu items if view is not editable.
- WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView smartInsertDeleteEnabled]): (-[WebHTMLView setSmartInsertDeleteEnabled:]): (-[WebHTMLView toggleSmartInsertDelete:]):
- WebView/WebHTMLViewInternal.h:
- 2:12 PM Changeset in webkit [43411] by
-
- 4 edits in trunk
Versioning.
- 2:03 PM HackingGtk edited by
- Gtk+ uses libsoup backend instead of curl (diff)
- 1:53 PM Changeset in webkit [43410] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-08 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Restored a Mozilla JS test I accidentally gutted.
- tests/mozilla/ecma/Array/15.4.4.2.js: (getTestCases): (test):
- 1:51 PM Changeset in webkit [43409] by
-
- 9 edits in trunk/JavaScriptCore
2009-05-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
More abstraction for JITStub calls from JITed code.
Added a JITStubCall class that automatically handles things like assigning
arguments to different stack slots and storing return values. Deployed
the class in about a billion places. A bunch more places remain to be
fixed up, but this is a good stopping point for now.
- jit/JIT.cpp: (JSC::JIT::emitTimeoutCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile):
- jit/JIT.h: (JSC::JIT::JSRInfo::JSRInfo): (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): (JSC::JITStubCall::): (JSC::CallEvalJITStub::CallEvalJITStub):
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArithSlow_op_lshift): (JSC::JIT::compileFastArithSlow_op_rshift): (JSC::JIT::compileFastArithSlow_op_jnless): (JSC::JIT::compileFastArithSlow_op_bitand): (JSC::JIT::compileFastArithSlow_op_mod): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArithSlow_op_post_inc): (JSC::JIT::compileFastArithSlow_op_post_dec): (JSC::JIT::compileFastArithSlow_op_pre_inc): (JSC::JIT::compileFastArithSlow_op_pre_dec): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::compileFastArithSlow_op_add): (JSC::JIT::compileFastArithSlow_op_mul):
- jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_resolve_func): (JSC::JITStubs::cti_op_resolve_with_base):
- 1:44 PM Changeset in webkit [43408] by
-
- 2 edits in trunk/LayoutTests
2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disable more new tests that are failing.
- platform/gtk/Skipped:
- 1:40 PM Changeset in webkit [43407] by
-
- 2 edits in tags/Safari-6530.9/WebCore
Merge r43394.
- 1:20 PM Changeset in webkit [43406] by
-
- 1 copy in tags/Safari-6530.9
New tag.
- 12:19 PM QtWebKitTodo edited by
- (diff)
- 12:13 PM Changeset in webkit [43405] by
-
- 3 edits in trunk/LayoutTests
2009-05-08 Eric Carlson <eric.carlson@apple.com>
No review, update tests results missed in r43403.
- fast/dom/Window/window-properties-expected.txt:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 12:08 PM Changeset in webkit [43404] by
-
- 1 edit5 adds in trunk/LayoutTests
2009-05-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
GTK+ test results for two new tests.
- platform/gtk/fast/layers/remove-only-this-layer-update-expected.txt: Added.
- platform/gtk/fast/repaint/selection-clear-expected.txt: Added.
- 11:54 AM HackingGtk edited by
- (diff)
- 11:37 AM Changeset in webkit [43403] by
-
- 15 edits2 adds in trunk
2009-05-08 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25627
Bug 25627: HTMLMediaElement: some errors should fire on <source> elements
Update for HTML5 spec change to fire 'error' events on <source> element
when there is a failure while processing/loading a <source>.
Test: media/video-source-error.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enqueueEvent): Remove white-space. (WebCore::HTMLMediaElement::loadInternal): Call cancelPendingEventsAndCallbacks instead of just calling m_pendingEvents.clear() as we now also need to cancel pending errors on all <source> element. (WebCore::HTMLMediaElement::selectMediaResource): Call isSafeToLoadURL() here instead of in loadResource() as we need to report errors differently depending on the type of failure. Use KURL instead of String. (WebCore::HTMLMediaElement::loadNextSourceChild): nextSourceChild -> selectNextSourceChild. Fail silently when there are no more <source> canditates because that is what spec mandates. Keep url as KURL instead of converting to String. (WebCore::HTMLMediaElement::loadResource): ASSERT that the URL is safe to load as we now assume the safety check now done before this function. Takes KURL instead of String. (WebCore::HTMLMediaElement::isSafeToLoadURL): New, checks to see if a url is safe to load, logs failure if not. (WebCore::HTMLMediaElement::noneSupported): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED (WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks): New, clear all events pending on the media and all source elements. (WebCore::HTMLMediaElement::setNetworkState): Fire an error on the source element when the the failure happened while processing one. Only call nonSupported() when the failure happened while processing media element 'src' attribute. (WebCore::HTMLMediaElement::havePotentialSourceChild): nextSourceChild -> selectNextSourceChild. Deal with selectNextSourceChild returning a KURL instead of a String. (WebCore::HTMLMediaElement::selectNextSourceChild): Renamed from nextSourceChild, add optional param to control whether or not errors are fired on a source element when it will not be used. Check safety of url here instead of waiting until loadResource(). Return a KURL instead of a String. (WebCore::HTMLMediaElement::initialURL): nextSourceChild -> selectNextSourceChild. Keep url as a KURL instead of a String.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::):
- html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::HTMLSourceElement): Initialize timer related variables. (WebCore::HTMLSourceElement::scheduleErrorEvent): New, start one-shot timer to fire an error event ASAP. (WebCore::HTMLSourceElement::cancelPendingErrorEvent): New, cancel pending error event. (WebCore::HTMLSourceElement::errorEventTimerFired): New, fire error event if it has not been cancelled.
- html/HTMLSourceElement.h:
- html/MediaError.h: (WebCore::MediaError::): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED
- html/MediaError.idl: Ditto
2009-05-08 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25627
Bug 25627: HTMLMediaElement: some errors should fire on <source> elements
Update tests for MEDIA_ERR_NONE_SUPPORTED change to MEDIA_ERR_SRC_NOT_SUPPORTED.
Add video-source-error.html to test errors fired on <source> elements .
- media/media-constants-expected.txt:
- media/media-constants.html:
- media/unsupported-rtsp.html:
- media/video-error-does-not-exist.html:
- media/video-source-error.html: Added.
- media/video-src-change.html:
- media/video-src-invalid-remove.html:
- media/video-src-plus-source.html:
- 8:56 AM Changeset in webkit [43402] by
-
- 2 edits in trunk/LayoutTests
2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disable new test that is failing.
- platform/gtk/Skipped:
- 8:08 AM Changeset in webkit [43401] by
-
- 10 edits in trunk/JavaScriptCore
2009-05-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Add a new opcode jnlesseq, and optimize its compilation in the JIT using
techniques similar to what were used to optimize jnless in r43363.
This gives a 0.7% speedup on SunSpider, particularly on the tests 3d-cube,
control-flow-recursive, date-format-xparb, and string-base64.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): Add support for dumping op_jnlesseq.
- bytecode/Opcode.h: Add op_jnlesseq to the list of opcodes.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfFalse): Add a peephole optimization for op_jnlesseq when emitting lesseq followed by a jump.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Add case for op_jnlesseq.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): Add case for op_jnlesseq. (JSC::JIT::privateCompileSlowCases): Add case for op_jnlesseq.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_jnlesseq): Added. (JSC::JIT::compileFastArithSlow_op_jnlesseq): Added.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_jlesseq): Added.
- jit/JITStubs.h:
- 6:42 AM Changeset in webkit [43400] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Maciej Stachowiak.
- fix <rdar://problem/6859955> Undoing typed text after selecting all leaves non-text areas highlighted
Test: fast/repaint/selection-clear.html
When RenderView::clearSelection() is called from
SelectionController::nodeWillBeRemoved(), selected renderers may already
be marked for layout, which means that they can no longer compute
their selection repaint info. Instead, an empty IntRect (or GapRects) is
returned, leading to incomplete repaint.
The fix is not to rely on individual renderers when clearing the
selection, but instead, cache the bounding rectangle of the selected
blocks' GapRects when setting the selection, and invalidate that
entire rectangle when clearing it.
- rendering/RenderView.cpp: (WebCore::RenderView::setSelection): Added a parameter saying whether the repainting of selected blocks should include both previously-selected areas and newly-selected areas or only newly-selected areas. The default is both. Also compute m_cachedSelectionBounds to be the bounding rectangle of the new selection's BlockSelectionInfos' GapRects. (WebCore::RenderView::clearSelection): Repaint m_cachedSelectionBounds, and tell setSelection() that it should not paint areas that were in the old selection's BlockSelectionInfos' GapRects.
- rendering/RenderView.h: (WebCore::RenderView::):
LayoutTests:
Reviewed by Maciej Stachowiak.
- test for <rdar://problem/6859955> Undoing typed text after selecting all leaves non-text areas highlighted
- fast/repaint/selection-clear.html: Added.
- platform/mac/fast/repaint/selection-clear-expected.checksum: Added.
- platform/mac/fast/repaint/selection-clear-expected.png: Added.
- platform/mac/fast/repaint/selection-clear-expected.txt: Added.
- 6:19 AM Changeset in webkit [43399] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- fix test failures on 64-bit
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArithSlow_op_jnless): Avoid accidentaly treating an immediate int as an immediate float in the 64-bit value representation.
- 5:58 AM Changeset in webkit [43398] by
-
- 7 edits in trunk
Reviewed by Maciej Stachowiak.
<rdar://problem/6868773> NPN_GetAuthenticationInfo does not work with non-permanent credentials
WebCore:
- WebCore.base.exp:
- platform/network/mac/AuthenticationMac.h: (WebCore::WebCoreCredentialStorage::set): (WebCore::WebCoreCredentialStorage::get):
- platform/network/mac/AuthenticationMac.mm:
- platform/network/mac/ResourceHandleMac.mm: Moved WebCoreCredentialStorage to AuthenticationMac, so that it could be used from WebKit.
WebKit:
- Plugins/WebBaseNetscapePluginView.mm: (WebKit::getAuthenticationInfo): Ask WebCore for credentials first (but also ask NSURLCredentialStorage, because WebCore won't know about permanent credentials).
- 4:30 AM Changeset in webkit [43397] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-08 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Oliver Hunt.
Removing an empty constructor and an uncalled, empty function seems to be a
pretty solid 1% regeression on my machine, so I'm going to put them back.
Um. Yeah, this this pretty pointles and makes no sense at all. I officially
lose the will to live in 3... 2...
- bytecode/SamplingTool.cpp: (JSC::SamplingTool::notifyOfScope):
- bytecode/SamplingTool.h: (JSC::SamplingTool::~SamplingTool):
- 3:23 AM Changeset in webkit [43396] by
-
- 2 edits in trunk/WebCore
2009-05-08 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix the Qt build, add missing JSC_HOST_CALL macros to the runtime
call methods.
- 3:18 AM Changeset in webkit [43395] by
-
- 5 edits in trunk/JavaScriptCore
2009-05-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver "I see lots of ifdefs" Hunt.
Fix (kinda) for sampling tool breakage. The codeblock sampling tool has become
b0rked due to recent changes in native function calling. The initialization of
a ScopeNode appears to now occur before the sampling tool (or possibly the
interpreter has been brought into existence, wihich leads to crashyness).
This patch doesn't fix the problem. The crash occurs when tracking a Scope, but
we shouldn't need to track scopes when we're just sampling opcodes, not
codeblocks. Not retaining Scopes when just opcode sampling will reduce sampling
overhead reducing any instrumentation skew, which is a good thing. As a side
benefit this patch also gets the opcode sampling going again, albeit in a bit of
a lame way. Will come back later with a proper fix from codeblock sampling.
- JavaScriptCore.exp:
- bytecode/SamplingTool.cpp: (JSC::compareLineCountInfoSampling): (JSC::SamplingTool::dump):
- bytecode/SamplingTool.h: (JSC::SamplingTool::SamplingTool):
- parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode):
- 1:20 AM Changeset in webkit [43394] by
-
- 2 edits in trunk/WebCore
2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Mark Rowe.
Add missing strings to localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=25635
Add the strings "Delete", "Key", "Refresh" and "Value".
- English.lproj/localizedStrings.js:
- 12:58 AM Changeset in webkit [43393] by
-
- 3 edits in trunk/WebCore
2009-05-08 Robert Hogan <robert@roberthogan.net>
Reviewed, tweaked and landed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=24992
[Qt] crash at http://browserspy.dk/browser.php
This cannot be easily tested in DRT, because it relies on interaction with QApplication,
but the added assertions guard against re-introducing this issue.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): Don't make client calls while the frame is being constructed, because the intermediate state without a document is something we don't want to expose.
- page/Frame.cpp: (WebCore::Frame::setJSStatusBarText): Assert that the frame has a document, which is an approximation of it being in a consistent state for client calls. (WebCore::Frame::setJSDefaultStatusBarText): Ditto.
May 7, 2009:
- 11:47 PM Changeset in webkit [43392] by
-
- 23 edits in trunk
Fix <https://bugs.webkit.org/show_bug.cgi?id=25640>.
Bug 25640: Crash on quit in r43384 nightly build on Leopard w/ Safari 4 beta installed
Rubber-stamped by Oliver Hunt.
Roll out r43366 as it removed symbols that Safari 4 Beta uses.
- 11:37 PM Changeset in webkit [43391] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-07 Sam Weinig <sam@webkit.org>
- Remove some incorrect code (subtraction is not commutative)
- Implement basic rightshift.
- Add FIXMEs for where we need to add more codegen to complete the opcode.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitSub32): (JSC::JIT::emitLeftShift32): (JSC::JIT::emitRightShift32):
- 11:18 PM Changeset in webkit [43390] by
-
- 4 edits in trunk
WebCore:
2009-05-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Unify scrolling code via adjustments and keys. Use the WebCore
defined constants, since that's what people are most used to at
this point.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
WebKit/gtk:
2009-05-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Unify scrolling code via adjustments and keys. Use the WebCore
defined constants, since that's what people are most used to at
this point.
- ChangeLog:
- webkit/webkitwebview.cpp: (webkit_web_view_real_move_cursor):
- 10:58 PM Changeset in webkit [43389] by
-
- 13 edits in trunk
WebCore:
2009-05-07 David Levin <levin@chromium.org>
Reviewed by NOBODY.
Suggested by Oliver Hunt.
Rolling back http://trac.webkit.org/changeset/43385
because we have to use mac artwork for the underline on OSX.
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/mac/GraphicsContextMac.mm: (WebCore::createPatternColor): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
- platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::setCGStrokeColor): (WebCore::spellingPatternColor): (WebCore::grammarPatternColor): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
LayoutTests:
2009-05-07 David Levin <levin@chromium.org>
Reviewed by NOBODY.
Suggested by Oliver Hunt.
Rolling back http://trac.webkit.org/changeset/43385
because we have to use mac artwork for the underline on OSX.
- platform/mac/editing/spelling/inline_spelling_markers-expected.checksum:
- platform/mac/editing/spelling/inline_spelling_markers-expected.png:
- platform/mac/editing/spelling/spellcheck-attribute-expected.checksum:
- platform/mac/editing/spelling/spellcheck-attribute-expected.png:
- platform/mac/editing/spelling/spelling-expected.checksum:
- platform/mac/editing/spelling/spelling-expected.png:
- platform/mac/editing/spelling/spelling-linebreak-expected.checksum:
- platform/mac/editing/spelling/spelling-linebreak-expected.png:
- 10:53 PM Changeset in webkit [43388] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-07 Sam Weinig <sam@webkit.org>
Add op_jnless, op_loop_if_less, and op_loop_if_lesseq.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): Remove breakpoint();
- 10:27 PM Changeset in webkit [43387] by
-
- 10 edits in branches/nitro-extreme/JavaScriptCore
2009-05-07 Sam Weinig <sam@webkit.org>
Initial checkin for JIT support for new number representation. Not all opcodes
are supported yet but JavaScriptCore compiles.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::unlinkCallers):
- jit/JIT.cpp: (JSC::JIT::getConstantOperand): (JSC::JIT::isOperandConstantImmediateInt): (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::addSlowCase): (JSC::JIT::addJump): (JSC::JIT::emitJumpSlowToHot): (JSC::JIT::tagFor): (JSC::JIT::payloadFor): (JSC::JIT::emitStoreConstant): (JSC::JIT::emitLoadVirtualRegister): (JSC::JIT::emitStoreVirtualRegister): (JSC::JIT::emitSetReturnValue): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32): (JSC::JIT::emitAddConstant32): (JSC::JIT::emitAdd32InPlace): (JSC::JIT::emitSub32): (JSC::JIT::emitSubConstant32): (JSC::JIT::emitSub32InPlace): (JSC::JIT::emitMul32): (JSC::JIT::emitMulConstant32): (JSC::JIT::emitMul32InPlace): (JSC::JIT::emitBitAnd32): (JSC::JIT::emitBitAndConstant32): (JSC::JIT::emitBitAnd32InPlace): (JSC::JIT::emitBitOr32): (JSC::JIT::emitBitOrConstant32): (JSC::JIT::emitBitOr32InPlace): (JSC::JIT::emitBitXor32): (JSC::JIT::emitBitXorConstant32): (JSC::JIT::emitBitXor32InPlace):
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- runtime/JSValue.h:
- wtf/Platform.h:
- 10:20 PM Changeset in webkit [43386] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-07 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add some new MacroAssembler and assembler functions that will be needed shortly.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::add32): (JSC::MacroAssemblerX86Common::and32): (JSC::MacroAssemblerX86Common::mul32): (JSC::MacroAssemblerX86Common::neg32): (JSC::MacroAssemblerX86Common::or32): (JSC::MacroAssemblerX86Common::sub32): (JSC::MacroAssemblerX86Common::xor32): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::addl_rm): (JSC::X86Assembler::andl_mr): (JSC::X86Assembler::andl_rm): (JSC::X86Assembler::andl_im): (JSC::X86Assembler::negl_r): (JSC::X86Assembler::notl_r): (JSC::X86Assembler::orl_rm): (JSC::X86Assembler::orl_im): (JSC::X86Assembler::subl_rm): (JSC::X86Assembler::xorl_mr): (JSC::X86Assembler::xorl_rm): (JSC::X86Assembler::xorl_im): (JSC::X86Assembler::imull_mr):
- 10:13 PM Changeset in webkit [43385] by
-
- 13 edits in trunk
WebCore:
2009-05-07 John Grabowski <jrg@chromium.org>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=25573
Unify use of CG-common routine for drawLineForMisspellingOrBadGrammar.
Cleanup for WebKit, but required for Chromium happiness.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::spellingPatternColor): (WebCore::grammarPatternColor): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
- platform/graphics/mac/GraphicsContextMac.mm:
- platform/graphics/win/GraphicsContextCGWin.cpp:
LayoutTests:
2009-05-07 John Grabowski <jrg@chromium.org>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=25573
Rebaseline of spelling tests for Mac. Tests pass even without this
change but checksums don't match. Non-Mac does not need a new baseline.
- platform/mac/editing/spelling/inline_spelling_markers-expected.checksum:
- platform/mac/editing/spelling/inline_spelling_markers-expected.png:
- platform/mac/editing/spelling/spellcheck-attribute-expected.checksum:
- platform/mac/editing/spelling/spellcheck-attribute-expected.png:
- platform/mac/editing/spelling/spelling-expected.checksum:
- platform/mac/editing/spelling/spelling-expected.png:
- platform/mac/editing/spelling/spelling-linebreak-expected.checksum:
- platform/mac/editing/spelling/spelling-linebreak-expected.png:
- 8:04 PM Changeset in webkit [43384] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-07 Gustavo Noronha Silva <Gustavo Noronha Silva>
Suggested by Oliver Hunt.
Also check for Linux for the special-cased calling convention.
- jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
- wtf/Platform.h:
- 7:42 PM BuildingGtk edited by
- (diff)
- 6:58 PM Changeset in webkit [43383] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by Maciej Stachowiak.
Previously, when appending to an existing string and growing the underlying buffer,
we would actually allocate 110% of the required size in order to give us some space
to expand into. Now we treat strings differently based on their size:
Small Strings (up to 4 pages):
Expand the allocation size to 112.5% of the amount requested. This is largely sicking
to our previous policy, however 112.5% is cheaper to calculate.
Medium Strings (up to 128 pages):
For pages covering multiple pages over-allocation is less of a concern - any unused
space will not be paged in if it is not used, so this is purely a VM overhead. For
these strings allocate 2x the requested size.
Large Strings (to infinity and beyond!):
Revert to our 112.5% policy - probably best to limit the amount of unused VM we allow
any individual string be responsible for.
Additionally, round small allocations up to a multiple of 16 bytes, and medium and
large allocations up to a multiple of page size.
~1.5% progression on Sunspider, due to 5% improvement on tagcloud & 15% on validate.
- runtime/UString.cpp: (JSC::expandedSize):
- 6:42 PM Changeset in webkit [43382] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed a minor sequencing error introduced by recent Parser speedups.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::createNativeThunk): Missed a spot in my last patch.
- 6:31 PM Changeset in webkit [43381] by
-
- 4 edits2 adds in trunk
WebCore:
2009-05-07 Darin Adler <Darin Adler>
Reviewed by Simon Fraser.
Bug 25575: Registered mutation event listener crashes HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=25575
Test: fast/media/video-controls-with-mutation-event-handler.html
- rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Don't call setAttribute.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::createTimeline): Call setAttribute here.
LayoutTests:
2009-05-07 Darin Adler <Darin Adler>
Reviewed by Simon Fraser.
Bug 25575: Registered mutation event listener crashes HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=25575
- fast/media/video-controls-with-mutation-event-handler-expected.txt: Added.
- fast/media/video-controls-with-mutation-event-handler.html: Added.
- 6:23 PM Changeset in webkit [43380] by
-
- 3 edits in trunk/WebCore
2009-05-07 Simon Fraser <Simon Fraser>
Rubber Stamped by Dave Hyatt
Shuffle the data members to minimize padding.
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection):
- rendering/RenderTableSection.h:
- 6:23 PM Changeset in webkit [43379] by
-
- 3 edits in trunk/WebCore
2009-05-07 Simon Fraser <Simon Fraser>
Rubber Stamped by Dave Hyatt
Shuffle the data members to make Events 8 bytes smaller in 64-bit.
- dom/Event.cpp: (WebCore::Event::Event):
- dom/Event.h:
- 5:16 PM Changeset in webkit [43378] by
-
- 6 edits4 adds in trunk
WebCore:
2009-05-07 Eric Seidel <eric@webkit.org>
Reviewed by Beth Dakin.
Fix regression caused by r41469, add test case to prevent it from
happening again.
https://bugs.webkit.org/show_bug.cgi?id=25252
hasLayer() was true during removeOnlyThisLayer()/
updateLayerPositions()
which caused updateLayerPosition()'s walk up the render tree to
include offsets from the layer we were about to remove.
I'm not 100% convinced that this wasn't a bug in
updateLayerPosition() or in RenderBoxModelObject::styleDidChange,
because the layer in question is not the containing block for the
block which gets laid out wrong. But this restores the previous
behavior and adds a test. So the next time someone is in here re-
factoring, they will at least know if they break something.
Test: fast/layers/remove-only-this-layer-update.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::destroyLayer):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::removeOnlyThisLayer):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
LayoutTests:
2009-05-07 Eric Seidel <eric@webkit.org>
Reviewed by Beth Dakin.
Fix regression caused by r41469, add test case to prevent it from
happening again.
https://bugs.webkit.org/show_bug.cgi?id=25252
- fast/layers/remove-only-this-layer-update.html: Added.
- platform/mac/fast/layers/remove-only-this-layer-update-expected.checksum: Added.
- platform/mac/fast/layers/remove-only-this-layer-update-expected.png: Added.
- platform/mac/fast/layers/remove-only-this-layer-update-expected.txt: Added.
- 5:02 PM Changeset in webkit [43377] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-07 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
- wtf/Platform.h: Reverted an accidental (and performance-catastrophic) change.
- 5:01 PM Changeset in webkit [43376] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed a minor sequencing error introduced by recent Parser speedups.
- parser/Parser.cpp: (JSC::Parser::reparseInPlace): Missed a spot in my last patch.
- 4:51 PM Changeset in webkit [43375] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed a minor sequencing error introduced by recent Parser speedups.
- parser/Parser.cpp: (JSC::Parser::parse):
- parser/Parser.h: (JSC::Parser::parse): (JSC::Parser::reparse): Shrink the parsedObjects vector after allocating the root node, to avoid leaving a stray node in the vector, since that's a slight memory leak, and it causes problems during JSGlobalData teardown.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::~JSGlobalData): ASSERT that we're not being torn down while we think we're still parsing, since that would cause lots of bad memory references during our destruction.
- 4:33 PM Changeset in webkit [43374] by
-
- 5 edits in trunk/JavaScriptCore
2009-05-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Replaced two more macros with references to the JITStackFrame structure.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
- jit/JITStubs.cpp: (JSC::):
- jit/JITStubs.h:
- 4:11 PM Changeset in webkit [43373] by
-
- 2 edits in trunk/WebCore
2009-05-07 Dmitry Titov <dimich@chromium.org>
Attempt to fix GTK build.
- platform/graphics/GlyphPageTreeNode.h: add #include <string.h> to ensure memcpy and memset are defined.
- 3:52 PM Changeset in webkit [43372] by
-
- 46 edits in trunk
Improve native call performance
Reviewed by Gavin Barraclough.
Fix the windows build by adding calling convention declarations everywhere,
chose fastcall as that seemed most sensible given we were having to declare
the convention explicitly. In addition switched to fastcall on mac in the
deluded belief that documented fastcall behavior on windows would match
actual its actual behavior.
- 3:26 PM Changeset in webkit [43371] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-07 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Rolled out a portion of r43352 because it broke 64bit.
- jit/JITStubs.h:
- 3:25 PM Changeset in webkit [43370] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-07 Dmitry Titov <dimich@chromium.org>
Attempt to fix Win build.
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArithSlow_op_jnless):
- 3:21 PM Changeset in webkit [43369] by
-
- 2 edits in trunk/JavaScriptCore
Build fix for functions reaturning ThreadIdentifier.
- 3:07 PM Changeset in webkit [43368] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by John Honeycutt.
- enable optimization case im the last patch that I accidentally had disabled.
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArithSlow_op_jnless):
- 2:43 PM Changeset in webkit [43367] by
-
- 50 edits4 deletes in trunk/WebCore
Reviewed by Dave Hyatt.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=25617
Fix memory/performance regression because of too much form control related abstraction just for WMLs sake.
Remove FormControlElement and FormControlElementWithState base classes, as the overhead is too high for the
gain. HTML has no benefit of that kind of abstraction, so we're going to move the functionality to Element directly.
The functions now living in FormControlElement(WithState) lived in Node/Element/HTMLFormControlElement before.
This patches moves all of them in a central place in Element.h, as virtual functions with an inline default implementation.
To avoid confusion like isEnabled() living on Node, before the creation of the FormControlElement abstraction layer, all
methods are renamed to clarify where they belong to. (Detailed list in ChangeLog)
- 2:24 PM Changeset in webkit [43366] by
-
- 23 edits in trunk
2009-05-07 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov and Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
- wtf/Threading.h: (WTF::ThreadIdentifier::ThreadIdentifier): (WTF::ThreadIdentifier::isValid): (WTF::ThreadIdentifier::invalidate): (WTF::ThreadIdentifier::platformId): ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and methods that are used across the code on thread ids: construction, comparisons, check for 'valid' state etc. '0' is used as invalid id, which happens to just work with all platform-specific thread id implementations.
All the following files repeatedly reflect the new ThreadIdentifier for each platform.
We remove ThreadMap and threadMapMutex from all of them, remove the functions that
populated/searched/cleared the map and add platform-specific comparison operators
for ThreadIdentifier.
- wtf/gtk/ThreadingGtk.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
- wtf/ThreadingNone.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=):
- wtf/ThreadingPthreads.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread):
- wtf/qt/ThreadingQt.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
- wtf/ThreadingWin.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): All the platforms (except Windows) used a sequential counter as a thread ID and mapped it into platform ID. Windows was using native thread id and mapped it into thread handle. Since we can always obtain a thread handle by thread id, createThread now closes the handle. (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle, it means the thread already exited. (WTF::detachThread): (WTF::currentThread): (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now). (WTF::waitForThreadCompletionDeprecated): same. (WTF::currentThreadDeprecated): same. (WTF::createThreadDeprecated): same.
- bytecode/SamplingTool.h:
- bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
- JavaScriptCore.exp: export lists - updated the WTF threading functions decorated names since they now take a different type as a parameter.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.
WebCore:
2009-05-07 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov and Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
Most of the change is in WTF.
Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
is now a class rather then an integer.
Also, there is no need to initialize threadID in constructors to 0 now.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id, since now ThreadIdentifier needs construction and we avoid having global initializers. (WebCore::matchFunc): use the new accessor function. (WebCore::openFunc): ditto. (WebCore::createStringParser): ditto. (WebCore::createMemoryParser): ditto.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::close):
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync): (WebCore::LocalStorageThread::terminate):
- workers/WorkerThread.cpp: (WebCore::WorkerThread::start): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start):
WebKit/win:
2009-05-07 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov and Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
Most of the change is in WTF and WebCore.
- WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones. Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones can be removed.
- WebKit.vcproj/WebKit_debug.def: same.
- 2:21 PM Changeset in webkit [43365] by
-
- 2 edits in trunk/WebCore
2009-05-07 Simon Fraser <Simon Fraser>
Rubber Stamped by Dave Hyatt
Shuffle the data members to minimize padding.
- dom/ClassNames.h:
- 2:10 PM Changeset in webkit [43364] by
-
- 5 edits in trunk/WebCore
2009-05-07 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
<rdar://problem/6864062> Shrink GlyphPage from 4112 to 2576 bytes in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=25605
Shrink GlyphPage by splitting the array of GlyphData, which has lots
of padding, into separate Glyph and SimpleFontData* arrays.
- platform/graphics/Font.h: glyphDataForCharacter has to return a GlyphData by value now.
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Return GlyphData by value.
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Better encapsulation of GlyphPage, using the new methods.
- platform/graphics/Font.h:
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
- platform/graphics/GlyphPageTreeNode.h: (WebCore::GlyphData::GlyphData): (WebCore::GlyphPage::indexForCharacter): (WebCore::GlyphPage::glyphDataForCharacter): (WebCore::GlyphPage::glyphDataForIndex): (WebCore::GlyphPage::glyphAt): (WebCore::GlyphPage::fontDataForCharacter): (WebCore::GlyphPage::setGlyphDataForCharacter): (WebCore::GlyphPage::setGlyphDataForIndex): (WebCore::GlyphPage::copyFrom): (WebCore::GlyphPage::clear):
- 1:42 PM Changeset in webkit [43363] by
-
- 5 edits in trunk/JavaScriptCore
2009-05-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
- optimize various cases of branch-fused less
1% speedup on SunSpider overall
13% speedup on math-cordic
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): op_loop_if_less: Optimize case of constant as first operand, just as case of constant as second operand. op_jnless: Factored out into compileFastArith_op_jnless. (JSC::JIT::privateCompileSlowCases): op_jnless: Factored out into compileFastArithSlow_op_jnless.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_jnless): Factored out from main compile loop.
- Generate inline code for comparison of constant immediate int as first operand to another immediate int, as for loop_if_less
(JSC::JIT::compileFastArithSlow_op_jnless):
- Generate inline code for comparing two floating point numbers.
- Generate code for both cases of comparing a floating point number to a constant immediate int.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): Fix dumping of op_jnless (tangentially related bugfix).
- 1:22 PM Changeset in webkit [43362] by
-
- 5 edits in trunk/JavaScriptCore
2009-05-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added the return address of a stub function to the JITStackFrame abstraction.
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITStubs.cpp: (JSC::): (JSC::StackHack::StackHack): (JSC::StackHack::~StackHack): (JSC::returnToThrowTrampoline): (JSC::JITStubs::cti_op_convert_this): (JSC::JITStubs::cti_op_end): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_timeout_check): (JSC::JITStubs::cti_register_file_check): (JSC::JITStubs::cti_op_loop_if_less): (JSC::JITStubs::cti_op_loop_if_lesseq): (JSC::JITStubs::cti_op_new_object): (JSC::JITStubs::cti_op_put_by_id_generic): (JSC::JITStubs::cti_op_get_by_id_generic): (JSC::JITStubs::cti_op_put_by_id): (JSC::JITStubs::cti_op_put_by_id_second): (JSC::JITStubs::cti_op_put_by_id_fail): (JSC::JITStubs::cti_op_get_by_id): (JSC::JITStubs::cti_op_get_by_id_second): (JSC::JITStubs::cti_op_get_by_id_self_fail): (JSC::JITStubs::cti_op_get_by_id_proto_list): (JSC::JITStubs::cti_op_get_by_id_proto_list_full): (JSC::JITStubs::cti_op_get_by_id_proto_fail): (JSC::JITStubs::cti_op_get_by_id_array_fail): (JSC::JITStubs::cti_op_get_by_id_string_fail): (JSC::JITStubs::cti_op_instanceof): (JSC::JITStubs::cti_op_del_by_id): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_new_func): (JSC::JITStubs::cti_op_call_JSFunction): (JSC::JITStubs::cti_op_call_arityCheck): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall): (JSC::JITStubs::cti_op_push_activation): (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_create_arguments): (JSC::JITStubs::cti_op_create_arguments_no_params): (JSC::JITStubs::cti_op_tear_off_activation): (JSC::JITStubs::cti_op_tear_off_arguments): (JSC::JITStubs::cti_op_profile_will_call): (JSC::JITStubs::cti_op_profile_did_call): (JSC::JITStubs::cti_op_ret_scopeChain): (JSC::JITStubs::cti_op_new_array): (JSC::JITStubs::cti_op_resolve): (JSC::JITStubs::cti_op_construct_JSConstruct): (JSC::JITStubs::cti_op_construct_NotJSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_resolve_func): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_lesseq): (JSC::JITStubs::cti_op_loop_if_true): (JSC::JITStubs::cti_op_load_varargs): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_resolve_base): (JSC::JITStubs::cti_op_resolve_skip): (JSC::JITStubs::cti_op_resolve_global): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_jless): (JSC::JITStubs::cti_op_not): (JSC::JITStubs::cti_op_jtrue): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_resolve_with_base): (JSC::JITStubs::cti_op_new_func_exp): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_less): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_new_regexp): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_op_throw): (JSC::JITStubs::cti_op_get_pnames): (JSC::JITStubs::cti_op_next_pname): (JSC::JITStubs::cti_op_push_scope): (JSC::JITStubs::cti_op_pop_scope): (JSC::JITStubs::cti_op_typeof): (JSC::JITStubs::cti_op_is_undefined): (JSC::JITStubs::cti_op_is_boolean): (JSC::JITStubs::cti_op_is_number): (JSC::JITStubs::cti_op_is_string): (JSC::JITStubs::cti_op_is_object): (JSC::JITStubs::cti_op_is_function): (JSC::JITStubs::cti_op_stricteq): (JSC::JITStubs::cti_op_to_primitive): (JSC::JITStubs::cti_op_strcat): (JSC::JITStubs::cti_op_nstricteq): (JSC::JITStubs::cti_op_to_jsnumber): (JSC::JITStubs::cti_op_in): (JSC::JITStubs::cti_op_push_new_scope): (JSC::JITStubs::cti_op_jmp_scopes): (JSC::JITStubs::cti_op_put_by_index): (JSC::JITStubs::cti_op_switch_imm): (JSC::JITStubs::cti_op_switch_char): (JSC::JITStubs::cti_op_switch_string): (JSC::JITStubs::cti_op_del_by_val): (JSC::JITStubs::cti_op_put_getter): (JSC::JITStubs::cti_op_put_setter): (JSC::JITStubs::cti_op_new_error): (JSC::JITStubs::cti_op_debug): (JSC::JITStubs::cti_vm_throw):
- jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
- 1:17 PM Changeset in webkit [43361] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-07 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
- parser/Lexer.cpp: (JSC::Lexer::lex): Fix missing braces. This would make us always take the slower case for string parsing and Visual Studio correctly noticed unreachable code.
- 1:16 PM Changeset in webkit [43360] by
-
- 2 edits2 adds in trunk/WebCore
2009-05-07 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25625
Implement Image/Option constructors in V8 bindings.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): Removed old JS-based code.
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Added.
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Added.
- 1:06 PM Changeset in webkit [43359] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-07 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClient::dispatchDidCommitLoad): Add missing call to notifyStatus in the committed case and a missing property notify.
- 1:03 PM Changeset in webkit [43358] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-07 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25589: goto instead of state machine in lexer
https://bugs.webkit.org/show_bug.cgi?id=25589
SunSpider is 0.8% faster.
- parser/Lexer.cpp: (JSC::Lexer::currentCharacter): Added. (JSC::Lexer::currentOffset): Changed to call currentCharacter for clarity. (JSC::Lexer::setCode): Removed code to set now-obsolete m_skipLineEnd. (JSC::Lexer::shiftLineTerminator): Added. Handles line numbers and the two-character line terminators. (JSC::Lexer::makeIdentifier): Changed to take characters and length rather than a vector, since we now make these directly out of the source buffer when possible. (JSC::Lexer::lastTokenWasRestrKeyword): Added. (JSC::isNonASCIIIdentStart): Broke out the non-inline part. (JSC::isIdentStart): Moved here. (JSC::isNonASCIIIdentPart): Broke out the non-inline part. (JSC::isIdentPart): Moved here. (JSC::singleEscape): Moved here, and removed some unneeded cases. (JSC::Lexer::record8): Moved here. (JSC::Lexer::record16): Moved here. (JSC::Lexer::lex): Rewrote this whole function to use goto and not use a state machine. Got rid of most of the local variables. Also rolled the matchPunctuator function in here. (JSC::Lexer::scanRegExp): Changed to use the new version of isLineTerminator. Clear m_buffer16 after using it instead of before.
- parser/Lexer.h: Removed State enum, setDone function, nextLine function, lookupKeywordFunction, one of the isLineTerminator functions, m_done data member, m_skipLineEnd data member, and m_state data member. Added shiftLineTerminator function, currentCharacter function, and changed the arguments to the makeIdentifier function. Removed one branch from the isLineTerminator function.
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): Streamlined the case where we don't replace anything.
- 12:36 PM Changeset in webkit [43357] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-05-07 Brady Eidson <beidson@apple.com>
I hate myself for doing this, but need to fix that ChangeLog entry.
- ChangeLog:
- 12:29 PM Changeset in webkit [43356] by
-
- 3 edits in trunk/WebCore
2009-05-07 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
- html/HTMLParser.cpp: Use the correct style of BUILD_ON_* for WebCore.
- html/HTMLParser.h: Ditto
- 12:13 PM Changeset in webkit [43355] by
-
- 203 edits in trunk
WebCore:
2009-05-07 David Hyatt <hyatt@apple.com>
Restore intrinsic margins to all form controls on Mac and Windows. Some of this regressed in 43007
when textareas were given explicit margins. Some of it had already regressed earlier whenever intrinsic
margins were turned off in themeWin.css.
Reviewed by Beth Dakin.
- css/html4.css:
- css/themeWin.css:
LayoutTests:
2009-05-07 David Hyatt <hyatt@apple.com>
Restore intrinsic margins to all form controls on Mac and Windows.
Reviewed by Beth Dakin.
- fast/forms/text-control-intrinsic-widths-expected.txt:
- fast/replaced/table-percent-height-text-controls-expected.txt:
- platform/mac/editing/inserting/4960120-1-expected.checksum:
- platform/mac/editing/inserting/4960120-1-expected.png:
- platform/mac/editing/inserting/4960120-1-expected.txt:
- platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
- platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
- platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
- platform/mac/editing/pasteboard/pasting-tabs-expected.checksum:
- platform/mac/editing/pasteboard/pasting-tabs-expected.png:
- platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
- platform/mac/fast/css/resize-corner-tracking-expected.checksum:
- platform/mac/fast/css/resize-corner-tracking-expected.png:
- platform/mac/fast/css/resize-corner-tracking-expected.txt:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/mac/fast/dynamic/008-expected.checksum:
- platform/mac/fast/dynamic/008-expected.png:
- platform/mac/fast/dynamic/008-expected.txt:
- platform/mac/fast/forms/001-expected.checksum:
- platform/mac/fast/forms/001-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.checksum:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.checksum:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
- platform/mac/fast/forms/menulist-clip-expected.checksum:
- platform/mac/fast/forms/menulist-clip-expected.png:
- platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
- platform/mac/fast/forms/menulist-narrow-width-expected.png:
- platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
- platform/mac/fast/forms/menulist-option-wrap-expected.png:
- platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
- platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
- platform/mac/fast/forms/negativeLineHeight-expected.checksum:
- platform/mac/fast/forms/negativeLineHeight-expected.png:
- platform/mac/fast/forms/negativeLineHeight-expected.txt:
- platform/mac/fast/forms/select-baseline-expected.checksum:
- platform/mac/fast/forms/select-baseline-expected.png:
- platform/mac/fast/forms/select-style-expected.checksum:
- platform/mac/fast/forms/select-style-expected.png:
- platform/mac/fast/forms/textAreaLineHeight-expected.checksum:
- platform/mac/fast/forms/textAreaLineHeight-expected.png:
- platform/mac/fast/forms/textAreaLineHeight-expected.txt:
- platform/mac/fast/forms/textarea-align-expected.checksum:
- platform/mac/fast/forms/textarea-align-expected.png:
- platform/mac/fast/forms/textarea-align-expected.txt:
- platform/mac/fast/forms/textarea-rows-cols-expected.checksum:
- platform/mac/fast/forms/textarea-rows-cols-expected.png:
- platform/mac/fast/forms/textarea-rows-cols-expected.txt:
- platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
- platform/mac/fast/forms/textarea-scroll-height-expected.png:
- platform/mac/fast/forms/textarea-scroll-height-expected.txt:
- platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
- platform/mac/fast/forms/textarea-scrollbar-expected.png:
- platform/mac/fast/forms/textarea-scrollbar-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.checksum:
- platform/mac/fast/forms/textarea-scrolled-type-expected.png:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.checksum:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
- platform/mac/fast/forms/textarea-width-expected.checksum:
- platform/mac/fast/forms/textarea-width-expected.png:
- platform/mac/fast/forms/textarea-width-expected.txt:
- platform/mac/fast/overflow/overflow-focus-ring-expected.checksum:
- platform/mac/fast/overflow/overflow-focus-ring-expected.png:
- platform/mac/fast/overflow/overflow-x-y-expected.checksum:
- platform/mac/fast/overflow/overflow-x-y-expected.png:
- platform/mac/fast/overflow/overflow-x-y-expected.txt:
- platform/mac/fast/parser/comment-in-textarea-expected.checksum:
- platform/mac/fast/parser/comment-in-textarea-expected.png:
- platform/mac/fast/parser/comment-in-textarea-expected.txt:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
- platform/mac/fast/parser/open-comment-in-textarea-expected.checksum:
- platform/mac/fast/parser/open-comment-in-textarea-expected.png:
- platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
- platform/mac/fast/replaced/selection-rect-transform-expected.png:
- platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
- platform/mac/fast/replaced/width100percent-textarea-expected.png:
- platform/mac/fast/replaced/width100percent-textarea-expected.txt:
- platform/mac/fast/table/003-expected.checksum:
- platform/mac/fast/table/003-expected.png:
- platform/mac/fast/table/003-expected.txt:
- platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum:
- platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
- platform/mac/http/tests/navigation/anchor-basic-expected.txt:
- platform/mac/http/tests/navigation/anchor-frames-expected.checksum:
- platform/mac/http/tests/navigation/anchor-frames-expected.png:
- platform/mac/http/tests/navigation/anchor-frames-expected.txt:
- platform/mac/http/tests/navigation/anchor-goback-expected.checksum:
- platform/mac/http/tests/navigation/anchor-goback-expected.png:
- platform/mac/http/tests/navigation/anchor-goback-expected.txt:
- platform/mac/http/tests/navigation/anchor-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/anchor-subframeload-expected.png:
- platform/mac/http/tests/navigation/anchor-subframeload-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum:
- platform/mac/http/tests/navigation/javascriptlink-basic-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.checksum:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum:
- platform/mac/http/tests/navigation/javascriptlink-goback-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt:
- platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum:
- platform/mac/http/tests/navigation/metaredirect-basic-expected.png:
- platform/mac/http/tests/navigation/metaredirect-basic-expected.txt:
- platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum:
- platform/mac/http/tests/navigation/metaredirect-frames-expected.png:
- platform/mac/http/tests/navigation/metaredirect-frames-expected.txt:
- platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum:
- platform/mac/http/tests/navigation/metaredirect-goback-expected.png:
- platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
- platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png:
- platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt:
- platform/mac/http/tests/navigation/post-goback2-expected.checksum:
- platform/mac/http/tests/navigation/post-goback2-expected.png:
- platform/mac/http/tests/navigation/post-goback2-expected.txt:
- platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum:
- platform/mac/http/tests/navigation/postredirect-goback2-expected.png:
- platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
- platform/mac/http/tests/navigation/redirect302-basic-expected.checksum:
- platform/mac/http/tests/navigation/redirect302-basic-expected.png:
- platform/mac/http/tests/navigation/redirect302-basic-expected.txt:
- platform/mac/http/tests/navigation/redirect302-frames-expected.checksum:
- platform/mac/http/tests/navigation/redirect302-frames-expected.png:
- platform/mac/http/tests/navigation/redirect302-frames-expected.txt:
- platform/mac/http/tests/navigation/redirect302-goback-expected.checksum:
- platform/mac/http/tests/navigation/redirect302-goback-expected.png:
- platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
- platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/redirect302-subframeload-expected.png:
- platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt:
- platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt:
- platform/mac/http/tests/navigation/relativeanchor-frames-expected.checksum:
- platform/mac/http/tests/navigation/relativeanchor-frames-expected.png:
- platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt:
- platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt:
- platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum:
- platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png:
- platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt:
- platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum:
- platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png:
- platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt:
- platform/mac/http/tests/navigation/success200-basic-expected.checksum:
- platform/mac/http/tests/navigation/success200-basic-expected.png:
- platform/mac/http/tests/navigation/success200-basic-expected.txt:
- platform/mac/http/tests/navigation/success200-frames-expected.checksum:
- platform/mac/http/tests/navigation/success200-frames-expected.png:
- platform/mac/http/tests/navigation/success200-frames-expected.txt:
- platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum:
- platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png:
- platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt:
- platform/mac/http/tests/navigation/success200-goback-expected.checksum:
- platform/mac/http/tests/navigation/success200-goback-expected.png:
- platform/mac/http/tests/navigation/success200-goback-expected.txt:
- platform/mac/http/tests/navigation/success200-loadsame-expected.checksum:
- platform/mac/http/tests/navigation/success200-loadsame-expected.png:
- platform/mac/http/tests/navigation/success200-loadsame-expected.txt:
- platform/mac/http/tests/navigation/success200-reload-expected.checksum:
- platform/mac/http/tests/navigation/success200-reload-expected.png:
- platform/mac/http/tests/navigation/success200-reload-expected.txt:
- platform/mac/http/tests/navigation/success200-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/success200-subframeload-expected.png:
- platform/mac/http/tests/navigation/success200-subframeload-expected.txt:
- platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum:
- platform/mac/http/tests/navigation/timerredirect-basic-expected.png:
- platform/mac/http/tests/navigation/timerredirect-basic-expected.txt:
- platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum:
- platform/mac/http/tests/navigation/timerredirect-frames-expected.png:
- platform/mac/http/tests/navigation/timerredirect-frames-expected.txt:
- platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum:
- platform/mac/http/tests/navigation/timerredirect-goback-expected.png:
- platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:
- platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum:
- platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png:
- platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt:
- platform/mac/tables/mozilla/bugs/bug194024-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug194024-expected.png:
- platform/mac/tables/mozilla/bugs/bug194024-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30559-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug30559-expected.png:
- platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
- 12:09 PM Changeset in webkit [43354] by
-
- 5 edits in trunk
wx build fixes for Python extension and DRT.
- 12:03 PM Changeset in webkit [43353] by
-
- 4 edits in trunk/WebCore
2009-05-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler and Alexey Proskuryakov.
<rdar://problem/6863795> Exception occurs in Mail when attempting to create signatures due to <head> element creation
- dom/Document.cpp: (WebCore::Document::implicitClose): Check shouldCreateImplicitHead() before creating it.
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Check shouldCreateImplicitHead() before creating it. (WebCore::HTMLParser::bodyCreateErrorCheck): Ditto. (WebCore::shouldCreateImplicitHead): For Tiger/Leopard when running under Mail, the implicit <head> shouldn't be created.
- html/HTMLParser.h: (WebCore::shouldCreateImplicitHead): Inline implementation for non-Tiger/Leopard platforms
- 11:45 AM Changeset in webkit [43352] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Removed a few more special constants, and replaced them with uses of
the JITStackFrame struct.
Removed one of the two possible definitions of VoidPtrPair. The Mac
definition was more elegant, but SunSpider doesn't think it's any
faster, and it's net less elegant to have two ways of doing things.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile):
- jit/JITStubs.h: (JSC::):
- 11:44 AM Changeset in webkit [43351] by
-
- 2 edits in trunk/WebKitTools
Remove manifest fixup from r42729 to fix clean builds.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- 11:35 AM Changeset in webkit [43350] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fixed Radar #
- 10:48 AM Changeset in webkit [43349] by
-
- 3 edits in trunk/WebKitLibraries
2009-05-07 Simon Fraser <Simon Fraser>
Source changes reviewed by Darin Adler
<rdar://problem/6864091> Endcap of media controls slider is fuzzy
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 10:45 AM Changeset in webkit [43348] by
-
- 2 edits in trunk/WebCore
2009-05-07 Antony Sargent <asargent@chromium.org>
Reviewed by Darin Fisher.
Fix a memory leak in V8EventListenerList::remove.
No new functionality so no new tests.
- bindings/v8/V8EventListenerList.cpp: (WebCore::V8EventListenerList::remove):
- 9:41 AM Changeset in webkit [43347] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-07 Darin Adler <Darin Adler>
- runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): Tweak formatting.
- 9:17 AM Changeset in webkit [43346] by
-
- 2 edits in trunk/WebCore
2009-05-07 Darin Fisher <darin@chromium.org>
Fix Chromium build bustage.
- bindings/v8/custom/V8HTMLFormElementCustom.cpp: Add missing HTMLCollection.h include.
- 9:01 AM Changeset in webkit [43345] by
-
- 5 edits2 adds in trunk
Bug 25598: AX: if a radio button has a label and a title, the label is not exposed
https://bugs.webkit.org/show_bug.cgi?id=25598
- 8:57 AM Changeset in webkit [43344] by
-
- 2 edits in trunk/WebCore
2009-05-07 Darin Fisher <darin@chromium.org>
Fix Chromium build bustage.
- bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): ":" should be "::"
- 6:59 AM Changeset in webkit [43343] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-07 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix the build thread stack base determination build on Symbian,
by moving the code block before PLATFORM(UNIX), which is also
enabled on Symbian builds.
- 5:36 AM Changeset in webkit [43342] by
-
- 2 edits in trunk/WebCore
2009-05-07 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25610
[GTK] text.caretOffset is reportedly always 0
Use the right function to get the caret offset in an
element. selectionStart() would only work for text
controls (there's even an ASSERT when calculating the selected
text range). Instead just get the selection and get the offset of
the start position.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 3:05 AM Changeset in webkit [43341] by
-
- 3 edits in trunk/JavaScriptCore
Fix crash due to incorrectly using an invalid scopechain
Reviewed by Gavin Barraclough.
stringProtoFuncReplace was checking for an exception on a CachedCall
by asking for the cached callframes exception. Unfortunately this
could crash in certain circumstances as CachedCall does not guarantee
a valid callframe following a call. Even more unfortunately the check
was entirely unnecessary as there is only a single exception slot per
global data, so it was already checked via the initial exec->hadException()
check.
To make bugs like this more obvious, i've added a debug only destructor
to ScopeChainNode that 0's all of its fields. This exposed a crash in
the standard javascriptcore tests.
- 1:58 AM Changeset in webkit [43340] by
-
- 2 edits in trunk/WebCore
2009-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix support for antialiased CSS border-radius
WebKit implements border-radius by drawing a double-size border,
and then letting the clip constrain the border to the right width
and position. This requires support for antialiased clipping, as
well as painting, to get a nice smooth border.
Qt only does antialiased clipping if the anti-alias flag is set
at the time of clipping, so we have to enable this in the method
addInnerRoundedRectClip(), as well as when we draw the border.
Currently the raster-engine is the only Qt paint engine to support
anti-aliased clipping, but the OpenGL and Mac paint engines could
potentially support this in the future.
- 1:27 AM Changeset in webkit [43339] by
-
- 6 edits in trunk/JavaScriptCore
2009-05-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (OOPS!).
Enable op_strcat across += assignments. This patch allows the lhs of a read/modify node
to be included within the concatenation operation, and also modifies the implementation
of the concatenation to attempt to reuse and cat onto the leftmost string, rather than
always allocating a new empty output string to copy into (as was previously the behaviour).
~0.5% progression, due to a 3%-3.5% progression on the string tests (particularly validate).
- parser/Nodes.cpp: (JSC::BinaryOpNode::emitStrcat): (JSC::emitReadModifyAssignment): (JSC::ReadModifyResolveNode::emitBytecode): (JSC::ReadModifyDotNode::emitBytecode): (JSC::ReadModifyBracketNode::emitBytecode):
- parser/Nodes.h:
- runtime/Operations.h: (JSC::concatenateStrings):
- runtime/UString.cpp: (JSC::UString::reserveCapacity):
- runtime/UString.h:
- 12:46 AM Changeset in webkit [43338] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-07 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Oliver Hunt.
Fix the build on Windows without JIT: interpreter/RegisterFile.h needs
roundUpAllocationSize, which is protected by #if ENABLED(ASSEMBLER).
Moved the #ifdef down and always offer the function.
- 12:42 AM Changeset in webkit [43337] by
-
- 2 edits1 add in trunk/WebCore
2009-05-07 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Render empty optgroup elements.
Currently, optgroup elements which are empty are not rendered. The
HTML specification gives no guidance on this situation.
However, the test for being empty is that they have no children, thus
this will not render:
<optgroup label="test"></optgroup>
while this /will/ render (because of the text node child):
<optgroup label="test"> </optgroup>
This patch will cause both cases to render which matches IE's and
Firefox's behaviour.
The difference only appears when opening the select element and does
not appear in the render tree. Thus, a manual layout-test is required.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcListItems):
- manual-tests/optgroup-empty-and-nested.html: Added.
- 12:38 AM Changeset in webkit [43336] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Maciej Stachowiak.
Update Contributing instructions after feedback from Julie Parent.
https://bugs.webkit.org/show_bug.cgi?id=25611
- coding/contributing.html: Add a few more comments on ChangeLogs
May 6, 2009:
- 11:48 PM Changeset in webkit [43335] by
-
- 2 edits in trunk/WebCore
2009-05-06 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
Bug 25608: Unused m_frame in ChromiumClipboard.
https://bugs.webkit.org/show_bug.cgi?id=25608
- platform/chromium/ClipboardChromium.h:
No tests added as this is only removing dead code, no functional changes.
- 11:36 PM Changeset in webkit [43334] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin "++" Barraclough.
Added some abstraction around the JIT stub calling convention by creating
a struct to represent the persistent stack frame JIT code shares with
JIT stubs.
SunSpider reports no change.
- jit/JIT.h:
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_convert_this): (JSC::JITStubs::cti_op_end): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_timeout_check): (JSC::JITStubs::cti_register_file_check): (JSC::JITStubs::cti_op_loop_if_less): (JSC::JITStubs::cti_op_loop_if_lesseq): (JSC::JITStubs::cti_op_new_object): (JSC::JITStubs::cti_op_put_by_id_generic): (JSC::JITStubs::cti_op_get_by_id_generic): (JSC::JITStubs::cti_op_put_by_id): (JSC::JITStubs::cti_op_put_by_id_second): (JSC::JITStubs::cti_op_put_by_id_fail): (JSC::JITStubs::cti_op_get_by_id): (JSC::JITStubs::cti_op_get_by_id_second): (JSC::JITStubs::cti_op_get_by_id_self_fail): (JSC::JITStubs::cti_op_get_by_id_proto_list): (JSC::JITStubs::cti_op_get_by_id_proto_list_full): (JSC::JITStubs::cti_op_get_by_id_proto_fail): (JSC::JITStubs::cti_op_get_by_id_array_fail): (JSC::JITStubs::cti_op_get_by_id_string_fail): (JSC::JITStubs::cti_op_instanceof): (JSC::JITStubs::cti_op_del_by_id): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_new_func): (JSC::JITStubs::cti_op_call_JSFunction): (JSC::JITStubs::cti_op_call_arityCheck): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall): (JSC::JITStubs::cti_op_push_activation): (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_create_arguments): (JSC::JITStubs::cti_op_create_arguments_no_params): (JSC::JITStubs::cti_op_tear_off_activation): (JSC::JITStubs::cti_op_tear_off_arguments): (JSC::JITStubs::cti_op_profile_will_call): (JSC::JITStubs::cti_op_profile_did_call): (JSC::JITStubs::cti_op_ret_scopeChain): (JSC::JITStubs::cti_op_new_array): (JSC::JITStubs::cti_op_resolve): (JSC::JITStubs::cti_op_construct_JSConstruct): (JSC::JITStubs::cti_op_construct_NotJSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_resolve_func): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_lesseq): (JSC::JITStubs::cti_op_loop_if_true): (JSC::JITStubs::cti_op_load_varargs): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_resolve_base): (JSC::JITStubs::cti_op_resolve_skip): (JSC::JITStubs::cti_op_resolve_global): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_jless): (JSC::JITStubs::cti_op_not): (JSC::JITStubs::cti_op_jtrue): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_resolve_with_base): (JSC::JITStubs::cti_op_new_func_exp): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_less): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_new_regexp): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_op_throw): (JSC::JITStubs::cti_op_get_pnames): (JSC::JITStubs::cti_op_next_pname): (JSC::JITStubs::cti_op_push_scope): (JSC::JITStubs::cti_op_pop_scope): (JSC::JITStubs::cti_op_typeof): (JSC::JITStubs::cti_op_is_undefined): (JSC::JITStubs::cti_op_is_boolean): (JSC::JITStubs::cti_op_is_number): (JSC::JITStubs::cti_op_is_string): (JSC::JITStubs::cti_op_is_object): (JSC::JITStubs::cti_op_is_function): (JSC::JITStubs::cti_op_stricteq): (JSC::JITStubs::cti_op_to_primitive): (JSC::JITStubs::cti_op_strcat): (JSC::JITStubs::cti_op_nstricteq): (JSC::JITStubs::cti_op_to_jsnumber): (JSC::JITStubs::cti_op_in): (JSC::JITStubs::cti_op_push_new_scope): (JSC::JITStubs::cti_op_jmp_scopes): (JSC::JITStubs::cti_op_put_by_index): (JSC::JITStubs::cti_op_switch_imm): (JSC::JITStubs::cti_op_switch_char): (JSC::JITStubs::cti_op_switch_string): (JSC::JITStubs::cti_op_del_by_val): (JSC::JITStubs::cti_op_put_getter): (JSC::JITStubs::cti_op_put_setter): (JSC::JITStubs::cti_op_new_error): (JSC::JITStubs::cti_op_debug): (JSC::JITStubs::cti_vm_throw):
- jit/JITStubs.h: (JSC::):
- 8:38 PM Changeset in webkit [43333] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Simon Fraser and Justin Garcia.
- fix another part of <rdar://problem/6703873> Triple-click quoted line and type Return creates an extra quoted blank line
Test: editing/inserting/6703873-2.html
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Corrected the logic for determining the first node that should go into the new blockquote given the split position: if it is at the end of a container, use the next node after the container. Otherwise, use the child at the position's offset.
LayoutTests:
Reviewed by Simon Fraser and Justin Garcia.
- test for another part of <rdar://problem/6703873> Triple-click quoted line and type Return creates an extra quoted blank line
- editing/inserting/6703873-2-expected.txt: Added.
- editing/inserting/6703873-2.html: Added.
- 6:23 PM Changeset in webkit [43332] by
-
- 2 edits in trunk/WebCore
2009-05-06 Simon Fraser <Simon Fraser>
Rubber-stampted by Eric Seidel
Add braces to clarify logic flow in RenderObject::adjustStyleDifference.
Only affects ACCELERATED_COMPOSITING builds.
- rendering/RenderObject.cpp: (WebCore::RenderObject::adjustStyleDifference):
- 5:06 PM Changeset in webkit [43331] by
-
- 15 edits in trunk/JavaScriptCore
2009-05-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Maciej Stachowiak & Darin Adler.
Improve string concatenation (as coded in JS as a sequence of adds).
Detect patterns corresponding to string concatenation, and change the bytecode
generation to emit a new op_strcat instruction. By handling the full set of
additions within a single function we do not need allocate JSString wrappers
for intermediate results, and we can calculate the size of the output string
prior to allocating storage, in order to prevent reallocation of the buffer.
1.5%-2% progression on Sunspider, largely due to a 30% progression on date-format-xparb.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
Add new opcodes.
- bytecode/Opcode.h:
Add new opcodes.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitStrcat): (JSC::BytecodeGenerator::emitToPrimitive):
Add generation of new opcodes.
- bytecompiler/BytecodeGenerator.h:
Add generation of new opcodes.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
Add implmentation of new opcodes.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
Add implmentation of new opcodes.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_to_primitive): (JSC::JITStubs::cti_op_strcat):
Add implmentation of new opcodes.
- jit/JITStubs.h:
Add implmentation of new opcodes.
- parser/Nodes.cpp: (JSC::BinaryOpNode::emitStrcat): (JSC::BinaryOpNode::emitBytecode): (JSC::ReadModifyResolveNode::emitBytecode):
Add generation of new opcodes.
- parser/Nodes.h: (JSC::ExpressionNode::): (JSC::AddNode::):
Add methods to allow identification of add nodes.
- parser/ResultType.h: (JSC::ResultType::definitelyIsString): (JSC::ResultType::forAdd):
Fix error in detection of adds that will produce string results.
- runtime/Operations.h: (JSC::concatenateStrings):
Add implmentation of new opcodes.
- runtime/UString.cpp: (JSC::UString::appendNumeric):
Add methods to append numbers to an existing string.
- runtime/UString.h: (JSC::UString::Rep::createEmptyBuffer): (JSC::UString::BaseString::BaseString):
Add support for creating an empty string with a non-zero capacity available in the BaseString.
- 4:56 PM Changeset in webkit [43330] by
-
- 7 edits in trunk
wx build fix, fixes for wx trunk builds.
- 3:55 PM Changeset in webkit [43329] by
-
- 2 edits in trunk/WebCore
2009-05-06 Albert J. Wong <ajwong@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25597
Fix API drift compile errors that occurred while this was ifdef-ed out.
The two big issues were that RenderObject::element() became
RenderObject::node() and some of the wk* drawing functions had
an extra theme parameter added to the argument list.
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
- 3:00 PM Changeset in webkit [43328] by
-
- 3 edits in trunk/WebCore
2009-05-06 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25385
Upstream changes to V8 bindings for supporting nested workers.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object): (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER WorkerOnmessage): (WebCore::CALLBACK_FUNC_DECL WorkerAddEventListener):
- 3:00 PM Changeset in webkit [43327] by
-
- 2 edits in trunk/WebCore
2009-05-06 Dave Moore <davemoore@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25513
The V8 bindings convert every javascript property to its associated css style
name. It then calls functions that convert that name to an id. This makes
getting or setting css styles on elements slow.
The patch fixes this by caching the results of the transformation, mapping a
javascript property name to its css property id. It then calls the already
public webkit methods that take the id in place of the string property names.
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
- 3:00 PM Changeset in webkit [43326] by
-
- 2 edits in trunk/WebCore
2009-05-06 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25591
Upstream V8HTMLFormElement from the Chromium repository.
- bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER HTMLFormElement): Upstreamed from Chromium repository (WebCore::NAMED_PROPERTY_GETTER HTMLFormElement): Changed empty element return case to return notHandledByInterceptor(); (WebCore::CALLBACK_FUNC_DECL HTMLFormElementSubmit): Upstreamed from Chromium repository
- 2:59 PM Changeset in webkit [43325] by
-
- 1 edit1 add in trunk/WebCore
2009-05-06 Albert J. Wong <ajwong@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25595
Upstream V8CanvasPixelArrayCustom from chromium port tree.
- bindings/v8/V8CanvasPixelArrayCustom.cpp: Added.
- 2:31 PM Changeset in webkit [43324] by
-
- 3 edits in trunk/WebCore
2009-05-06 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
<rdar://problem/6862550> Reduce size of RenderText in 64-bit
Rearrange data members of RenderText so that an int comes
first, to minimize padding.
- rendering/RenderText.cpp: (WebCore::RenderText::RenderText):
- rendering/RenderText.h:
- 2:21 PM Changeset in webkit [43323] by
-
- 3 edits in trunk/WebCore
2009-05-06 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
<rdar://problem/6862823> Reduce size of RenderStyle in 64-bit
Rearrange data members of RenderStyle to minimize padding
when building for 64-bit.
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle):
- rendering/style/RenderStyle.h: (WebCore::):
- 2:07 PM Changeset in webkit [43322] by
-
- 2 edits in trunk/WebCore
2009-05-06 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Fixes Chromium build bustage caused by r43317 (making
RefCountedBase::m_refCount private)
- page/chromium/AccessibilityObjectWrapper.h: (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):
- 12:57 PM Changeset in webkit [43321] by
-
- 2 edits in trunk/WebCore
2009-05-06 Hin-Chung Lam <hclam@chromium.org>
Reviewed by Darin Fisher.
Refactor for MediaPlayerPrivate for Chromium port. Remove
the implementation of MediaPlayerPrivateInferface from it.
- 12:46 PM Changeset in webkit [43320] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-05-06 Daniel Nylander <po@danielnylander.se>
Rubber-stamped by Gustavo Noronha.
Swedish translation for WebKitGTK+.
- sv.po: Added.
- 12:38 PM Changeset in webkit [43319] by
-
- 5 edits in trunk/WebKit/gtk
2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=24786
WebKitDownload sometimes suggests peculiar filenames
When a download is requested by an ongoing request, use the already
provided response to set the suggested filename for the WebKitDownload
object, if available.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::download):
- webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_get_suggested_filename): (_WebKitDownloadPrivate::webkit_download_set_suggested_filename):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp:
- 12:23 PM Changeset in webkit [43318] by
-
- 4 edits in trunk
WebKit/win:
2009-05-06 Steve Falkenburg <sfalken@apple.com>
Change default value of WebKitPaintNativeControls to true.
Reviewed by Adam Roben.
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
WebKitTools:
2009-05-06 Steve Falkenburg <sfalken@apple.com>
Explicitly set WebKitPaintNativeControls to false to allow Windows results to match Mac.
Reviewed by Adam Roben.
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- 12:15 PM Changeset in webkit [43317] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-06 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Made RefCounted::m_refCount private.
- runtime/Structure.h: Removed addressOfCount.
- wtf/RefCounted.h: Made m_refCount private. Added addressOfCount.
- 11:57 AM Changeset in webkit [43316] by
-
- 3 edits in trunk/WebCore
2009-05-06 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt, Dan Bernstein
<rdar://problem/6860197> Reduce the size of FontFallbackList in 64-bit
Re-order the data members of FontFallbackList to save 8 bytes when building 64-bit.
- platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList):
- platform/graphics/FontFallbackList.h:
- 11:47 AM Changeset in webkit [43315] by
-
- 2 edits in trunk/WebCore
2009-05-06 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler, Dan Bernstein
<rdar://problem/6860068> Reduce size of InlineBox in 64-bit
Re-order the data members of InlineBox to save 8 bytes when building 64-bit.
- rendering/InlineBox.h: (WebCore::InlineBox::InlineBox):
- 11:28 AM Changeset in webkit [43314] by
-
- 1 edit1 add in trunk/WebCore
2009-05-06 David Levin <levin@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25588
Adding the custom v8 bindings Document.location.
- bindings/v8/custom/V8DocumentLocationCustom.cpp: Added.
- 11:17 AM Changeset in webkit [43313] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-06 Darin Adler <Darin Adler>
Fixed assertion seen a lot!
- parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Removed now-bogus assertion.
- 10:50 AM Changeset in webkit [43312] by
-
- 2 edits in trunk/WebCore
2009-05-06 Kevin McCullough <kmccullough@apple.com>
-Clarified a comment
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- 10:10 AM Changeset in webkit [43311] by
-
- 9 edits1 copy in trunk/JavaScriptCore
2009-05-06 Darin Adler <Darin Adler>
Working with Sam Weinig.
Redo parse tree constructor optimization without breaking the Windows
build the way I did yesterday. The previous try broke the build by adding
an include of Lexer.h and all its dependencies that had to work outside
the JavaScriptCore project.
- GNUmakefile.am: Added NodeConstructors.h.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Removed byteocde directory -- we no longer are trying to include Lexer.h outside JavaScriptCore.
- JavaScriptCore.xcodeproj/project.pbxproj: Change SegmentedVector.h and Lexer.h back to internal files. Added NodeConstructors.h.
- parser/Grammar.y: Added include of NodeConstructors.h. Changed use of ConstDeclNode to use public functions.
- parser/NodeConstructors.h: Copied from parser/Nodes.h. Just contains the inlined constructors now.
- parser/Nodes.cpp: Added include of NodeConstructors.h. Moved node constructors into the header. (JSC::FunctionBodyNode::FunctionBodyNode): Removed m_refCount initialization.
- parser/Nodes.h: Removed all the constructor definitions, and also removed the JSC_FAST_CALL from them since these are all inlined, so the calling convention is irrelevant. Made more things private. Used a data member for operator opcodes instead of a virtual function. Removed the special FunctionBodyNode::ref/deref functions since the default functions are now just as fast.
- runtime/FunctionConstructor.cpp: (JSC::extractFunctionBody): Fixed types here so we don't typecast until after we do type checking.
- 8:44 AM Changeset in webkit [43310] by
-
- 21 edits in trunk/WebCore
Not reviewed. Fix WML enabled builds by including "MappedAttribute.h" in several places.
- 8:24 AM Changeset in webkit [43309] by
-
- 2 edits in trunk/LayoutTests
2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disable more new tests.
- platform/gtk/Skipped:
- 7:25 AM Changeset in webkit [43308] by
-
- 2 edits in trunk/WebCore
2009-05-06 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25526
[Gtk] Additional support is needed for caret browsing
Emit AtkText::text-selection-changed when the selection changes
and the current selection is of Range (ie, the start and end
positions are different) type. This seems to match what Gecko
does.
- editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- 7:24 AM Changeset in webkit [43307] by
-
- 3 edits2 adds in trunk/WebCore
2009-05-05 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25526
[Gtk] Additional support is needed for caret browsing
Emit AtkText::text-caret-moved when selection changes.
- GNUmakefile.am:
- editing/SelectionController.h:
- editing/gtk/SelectionController.cpp: Added. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- 7:04 AM Changeset in webkit [43306] by
-
- 3 edits in trunk/WebCore
2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Gustavo Noronha.
Use mozilla cursors for the previously not implemented
cursors. The manual-tests/cursor.html is looking complete
now.
- platform/gtk/CursorGtk.cpp: (WebCore::cellCursor): (WebCore::noDropCursor): (WebCore::progressCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
- platform/gtk/CursorGtk.h:
- 7:03 AM Changeset in webkit [43305] by
-
- 2 edits in trunk/WebCore
2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
Properly indent the header file.
- platform/gtk/CursorGtk.h:
- 7:03 AM Changeset in webkit [43304] by
-
- 2 edits in trunk/WebCore
2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Gustavo Noronha.
Use the mozilla copyright header. Use MPL1.1/GPL2.0
and LGPL2.1 as the license compared to LGPL2.0.
- platform/gtk/CursorGtk.h:
- 7:03 AM Changeset in webkit [43303] by
-
- 3 edits in trunk/WebCore
2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Gustavo Noronha.
Move PluginView::invalidateRegion from the
TemporaryLinkStubs to PluginViewGtk.cpp and implement
it with a call to Widget::invalidate() just like
mac is doing. Optimisations would have to be window
system specific.
- platform/gtk/TemporaryLinkStubs.cpp:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::invalidateRegion):
- 6:56 AM Changeset in webkit [43302] by
-
- 14 edits in trunk/WebKit/gtk
2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
GTK+ API implementation files have bogus extern "C" entries
https://bugs.webkit.org/show_bug.cgi?id=24322
Remove bogus extern "C" from the source files.
- webkit/webkitdownload.cpp: (DownloadClient::cannotShowURL):
- webkit/webkiterror.cpp: (webkit_plugin_error_quark):
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_get_uri):
- webkit/webkitprivate.cpp: (webkit_init):
- webkit/webkitversion.cpp: (webkit_micro_version):
- webkit/webkitwebbackforwardlist.cpp:
- webkit/webkitwebframe.cpp: (webkit_web_frame_get_load_status):
- webkit/webkitwebhistoryitem.cpp:
- webkit/webkitwebinspector.cpp: (webkit_web_inspector_set_inspector_client):
- webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_modifier_state):
- webkit/webkitwebpolicydecision.cpp: (webkit_web_policy_decision_cancel):
- webkit/webkitwebsettings.cpp: (webkit_web_settings_get_spell_languages):
- webkit/webkitwebview.cpp:
- webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_equal):
- 6:24 AM Changeset in webkit [43301] by
-
- 2 edits in trunk/LayoutTests
2009-05-06 Eric Seidel <eric@webkit.org>
No review, just fixing my previous broken commit.
Commit correct results for event-function-toString.html
- fast/events/event-function-toString-expected.txt:
- 6:20 AM Changeset in webkit [43300] by
-
- 2 edits in trunk/LayoutTests
2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Fixing typo in my last commit.
- platform/gtk/Skipped:
- 6:12 AM Changeset in webkit [43299] by
-
- 2 edits in trunk/LayoutTests
2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disabling failing new tests that do not represent regressions.
- platform/gtk/Skipped:
- 6:12 AM Changeset in webkit [43298] by
-
- 2 edits in trunk/WebCore
2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Fix the Qt build on Windows.
- 6:11 AM Changeset in webkit [43297] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Fix the Qt build on Windows.
- 6:11 AM Changeset in webkit [43296] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Enable the JIT for the Qt build on Windows.
- 5:24 AM Changeset in webkit [43295] by
-
- 4 edits in trunk
2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
Misc fixes to InspectorClientGtk.
- GNUmakefile.am: Add localizedStrings.js to webinspector_DATA. This prevents copious amounts "Localized string not found" errors in the console
2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
Misc fixes to InspectorClientGtk.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::createPage): use g_filename_to_uri to get the URI and use web_view_load_uri instead of the deprecated web_view_open method for loading the URI. (WebKit::InspectorClient::localizedStringsURL): implement.
- 3:40 AM QtWebKitJournal edited by
- (diff)
- 3:39 AM QtWebKitTodo edited by
- (diff)
- 3:32 AM Applications using WebKit edited by
- adding Air Browser (diff)
- 3:26 AM Changeset in webkit [43294] by
-
- 3 edits in trunk/WebKit/qt
2009-05-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Improve behaviour of the QWebElement enclose* functions, to work
similar to the jQuery wrap functions. We now enclose the contents
of the element in the child of the deepest descendant element
within the structure of the enclose element structure given.
- 3:23 AM Changeset in webkit [43293] by
-
- 2 edits in trunk/WebKit/qt
2009-05-06 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
After commit rev @43215, setHtml() without a <head> tag,
automatically adds it, so update our test case to respect this.
- 2:34 AM Changeset in webkit [43292] by
-
- 4 edits in trunk
2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Tweak JavaScriptCore.pri for being able to override the generated sources dir for the
generated_files target.
WebCore:
2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Tweak WebCore.pro for being able to override the generated sources dir for the
generated_files target.
- 2:12 AM Changeset in webkit [43291] by
-
- 2 edits in trunk/WebCore
2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Fix the Qt/Windows build, use iface instead of interface to avoid conflict
with VS2005 headers.
- 1:53 AM Changeset in webkit [43290] by
-
- 2 edits in trunk/WebCore
2009-05-06 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Simon Hausmann.
We need to include StringExtras.h on Windows CE to access the strdup function.
- 1:25 AM Changeset in webkit [43289] by
-
- 5 edits3 adds in trunk
2009-05-06 Soren Gjesse <sgjesse@chromium.org>
Reviewed by Eric Seidel.
Changed the toString behaviour for non document dom node event handlers in the V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25544
In the V8 bindings non document dom node event handlers are wrapped in a number of with blocks and uses an inner
function. This causes the default toString on such a handler to return all this wrapper code. As some web sites
use the source of an event handler to create new functions this wrapper code causes compatibility problems.
Create a specific toString function for these handlers which will return a function source compatible with the
source returned by the JSC bindings and other browsers.
Test: fast/events/event-function-toString.html
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListenerToString): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create):
- 1:20 AM Changeset in webkit [43288] by
-
- 11 edits in trunk
Build QtWebKit as a framework on Mac
This implies both debug and release build by default, unless
one of the --debug or --release config options are passed to
the build-webkit script.
Frameworks can be disabled by passing CONFIG+=webkit_no_framework
to the build-webkit script.
To be able to build both debug and release targets in parallel
we have to use separate output directories for the generated
sources, which is not optimal, but required to avoid race conditions.
An optimization would be to only require this spit-up on Mac.
- 1:20 AM Changeset in webkit [43287] by
-
- 4 edits in trunk
[Qt] Use $$GENERATED_SOURCES_DIR as output when running bison
A couple of the generators left the bison output file in the source
tree, and then moved it into $$GENERATED_SOURCES_DIR, which did not
work well when building release and debug configurations in parallel.
- 1:02 AM Changeset in webkit [43286] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Justin Garcia.
- fix an assertion failure in RemoveNodeCommand() when deleting a <br> between a block and a mail blockquote
Test: editing/deleting/removeNodeCommand-assert.html
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Pass the start block to prune() instead of passing m_upstreamStart.node(), because the latter may have been removed already.
LayoutTests:
Reviewed by Justin Garcia.
- test for an assertion failure in RemoveNodeCommand() when deleting a <br> between a block and a mail blockquote
- editing/deleting/removeNodeCommand-assert-expected.txt: Added.
- editing/deleting/removeNodeCommand-assert.html: Added.
- 12:27 AM Changeset in webkit [43285] by
-
- 3 edits in trunk/WebKit/qt
2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt build fix.
Dont' use ENABLE() in Qt API headers, as they are not available when building
against the API.
May 5, 2009:
- 11:40 PM Changeset in webkit [43284] by
-
- 3 edits2 deletes in trunk
2009-05-05 Eric Seidel <eric@webkit.org>
No review, roll out only.
Roll out r23072 since it broke layout tests
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- 11:00 PM Changeset in webkit [43283] by
-
- 66 edits in trunk
2009-05-05 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel.
Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
https://bugs.webkit.org/show_bug.cgi?id=24776
No functional changes, thus no tests.
- bindings/js/JSCustomSQLStatementCallback.cpp:
- bindings/js/JSCustomSQLStatementCallback.h:
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- bindings/js/JSCustomSQLStatementErrorCallback.h:
- bindings/js/JSCustomSQLTransactionCallback.cpp:
- bindings/js/JSCustomSQLTransactionCallback.h:
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- bindings/js/JSCustomSQLTransactionErrorCallback.h:
- bindings/js/JSDatabaseCustom.cpp:
- bindings/js/JSSQLTransactionCustom.cpp:
- loader/EmptyClients.h:
- page/ChromeClient.h:
- storage/ChangeVersionWrapper.cpp:
- storage/ChangeVersionWrapper.h:
- storage/Database.cpp: (WebCore::Database::databaseInfoTableName):
- storage/Database.h:
- storage/Database.idl:
- storage/DatabaseTask.cpp:
- storage/DatabaseTask.h:
- storage/DatabaseThread.cpp:
- storage/DatabaseThread.h:
- storage/DatabaseTracker.cpp:
- storage/DatabaseTracker.h:
- storage/DatabaseTrackerClient.h:
- storage/OriginQuotaManager.cpp:
- storage/OriginQuotaManager.h:
- storage/SQLStatement.cpp:
- storage/SQLStatement.h:
- storage/SQLTransaction.cpp:
- storage/SQLTransaction.h:
- storage/SQLTransaction.idl:
- 10:49 PM Changeset in webkit [43282] by
-
- 2 edits in trunk/WebCore
2009-05-05 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Eric Seidel.
Add some documentation to InlineBox::x(),y().
https://bugs.webkit.org/show_bug.cgi?id=25378
- rendering/InlineBox.h:
- 10:47 PM Changeset in webkit [43281] by
-
- 2 edits in trunk/WebCore
2009-05-05 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0
https://bugs.webkit.org/show_bug.cgi?id=24693
- WebCore.pro:
- 10:46 PM Changeset in webkit [43280] by
-
- 3 edits2 adds in trunk
2009-05-05 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
Reviewed by Eric Seidel.
Anonymous blocks should not be exposed in accessibility tree.
Part of https://bugs.webkit.org/show_bug.cgi?id=23072
Tests: accessibility/ignore-anonymous-block.html
platform/win/accessibility/document-role.html
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):Return true for Anonymous blocks. Matching Firefox 2.0.0.14
- 10:37 PM Changeset in webkit [43279] by
-
- 5 edits2 adds in trunk
2009-05-05 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov.
For euc-kr and other 8bit Korean encodings
(similar to euc-kr/windows-949), make document.charset return
EUC-KR instead of windows-949. The latter is not recognized by
Korean web servers.
Add domName method to TextEncoding to deal with cases where
our internal encoding name does not match what's widely recognized
by web servers. Currently, the only case is 'windows-949' (internal
name) vs 'EUC-KR'.
Test: fast/encoding/euckr-name.html
- dom/Document.cpp: (WebCore::Document::encoding): Call TextEncoding.domName() instead of TextEncoding.name().
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::domName): For the canonical name 'windows-949', return 'EUC-KR'. Otherwise, just return the canonical name.
- platform/text/TextEncoding.h:
- 10:30 PM Changeset in webkit [43278] by
-
- 3 edits3 adds in trunk
2009-05-05 Adam Langley <agl@google.com>
Reviewed by Darin Adler.
Rendering fix for <select> elements.
https://bugs.webkit.org/show_bug.cgi?id=25558
When switching a <select> element from display:none to default
display, we would fail to invalidate the parent's pref widths in some
situations:
When attaching the element, RenderMenuList::updateOptionsWidth would
call setNeedsLayoutAndPrefWidthsRecalc before the parent pointer was
set. This would mark the pref widths as dirty, but not for any parent
objects.
When RenderObjectChildList::appendChildNode later calls
setNeedsLayoutAndPrefWidthsRecalc again, with a valid parent pointer,
nothing would be done because the pref widths were already dirty for.
the RenderMenuList.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
- 10:23 PM Changeset in webkit [43277] by
-
- 4 edits in trunk/WebCore
2009-05-05 Antony Sargent <asargent@chromium.org>
Reviewed by Dimitri Glazkov.
Switch V8EventListenerList to use HashTable<T>.
https://bugs.webkit.org/show_bug.cgi?id=25496
This avoids some tricky issues with event listener removal in the
current implementation and has slightly better performance.
No new functionality so no new tests.
- bindings/v8/V8EventListenerList.cpp: Added V8EventListenerListIterator.
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::size):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
- 9:50 PM Changeset in webkit [43276] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-05 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Simplified a bit of codegen.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- 9:47 PM Changeset in webkit [43275] by
-
- 3 edits in trunk/WebCore
2009-05-05 Darin Fisher <darin@chromium.org>
Fixing build bustage.
Add some missing includes to fix the Chromium build.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- 9:25 PM Changeset in webkit [43274] by
-
- 7 edits2 adds in trunk
2009-05-05 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
history.{back,forward,go} should always be dispatched asynchronously,
even when the history navigation would just result in scrolling the
page. This matches the behavior of other browsers like IE and FF.
Test: fast/history/back-forward-is-asynchronous.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation):
- 8:20 PM Changeset in webkit [43273] by
-
- 6 edits in trunk/JavaScriptCore
2009-05-05 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Moved all the JIT stub related code into one place.
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITCode.h:
- jit/JITStubs.cpp: (JSC::):
- jit/JITStubs.h:
- 8:15 PM Changeset in webkit [43272] by
-
- 2 edits in trunk/LayoutTests
Skip newly-added SVG tests that fail on Windows
See Bug 25583: New SVG regression tests added in r43269 fail on
Windows
<https://bugs.webkit.org/show_bug.cgi?id=25583>
Rubber-stamped in advance by Eric Seidel.
- platform/win/Skipped: Added the two new SVG tests.
- 7:20 PM Changeset in webkit [43271] by
-
- 3 edits in trunk/WebKit/win
Add a call to notify the UI delegate when the WebView gets invalidated
Reviewed by Steve Falkenburg.
- Interfaces/IWebUIDelegatePrivate.idl: Added webViewDidInvalidate.
- WebView.cpp: (WebView::addToDirtyRegion): Call webViewDidInvalidate.
- 6:22 PM Changeset in webkit [43270] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-05 Sam Weinig <sam@webkit.org>
Try to fix Windows build.
Move Node constructor to the .cpp file.
- parser/Nodes.cpp:
- parser/Nodes.h:
- 6:20 PM Changeset in webkit [43269] by
-
- 7 edits8 adds in trunk
Reviewed by Simon Fraser.
Add an ASSERT(useTransforms) to mapLocalToContainer implementations in SVG.
https://bugs.webkit.org/show_bug.cgi?id=25532
https://bugs.webkit.org/show_bug.cgi?id=25568
Adding this ASSERT exposed a bug in SVGPaintServerPattern::setup
which was causing transformed SVG text when filled/stroked with a
pattern using patternUnits=objectBoundingBox to draw incorrectly.
I fixed the incorrect drawing (by removing the broken code) and added
two test cases to test the fix:
- svg/transforms/text-with-pattern-inside-transformed-html.xhtml
- svg/transforms/text-with-pattern-with-svg-transform.svg
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
- 5:56 PM Changeset in webkit [43268] by
-
- 2 edits in trunk/WebKitTools
2009-05-05 Darin Adler <Darin Adler>
Try to fix Mac build.
- DumpRenderTree/AccessibilityUIElement.cpp: (elementAtPointCallback): Initialize x and y.
- 5:54 PM Changeset in webkit [43267] by
-
- 5 edits2 adds in trunk
WebCore:
2009-05-05 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Sam Weinig.
Support HTML5 text control input types: email, number, tel, url
Test: fast/html/text-field-input-types.html
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isTextField]): Call HTMLInputElement::isTextField directly.
- html/HTMLInputElement.cpp: Use the new types where appropriate. (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::type): (WebCore::HTMLInputElement::saveState): (WebCore::HTMLInputElement::restoreState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler):
- html/HTMLInputElement.h: Ditto. (WebCore::HTMLInputElement::): (WebCore::HTMLInputElement::isTextField):
LayoutTests:
2009-05-05 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Sam Weinig.
Support HTML5 text control input types: email, number, tel, url
- fast/html/text-field-input-types-expected.txt: Added.
- fast/html/text-field-input-types.html: Added.
- 5:54 PM Changeset in webkit [43266] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-05 Darin Adler <Darin Adler>
Try to fix Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added bytecompiler to the list of directories where the headers get copied.
- 5:51 PM Changeset in webkit [43265] by
-
- 10 edits in trunk
Reviewed by Kevin Ollivier.
Full Keyboard shortcut support.
Implement wxBrowser Cut/Copy/Paste menu items.
https://bugs.webkit.org/show_bug.cgi?id=24797
- 5:39 PM Changeset in webkit [43264] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-05 Darin Adler <Darin Adler>
Try to fix Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Try to fix Mac build.
- JavaScriptCore.xcodeproj/project.pbxproj: Made SegmentedVector.h private.
- 5:19 PM Changeset in webkit [43263] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-05 Darin Adler <Darin Adler>
Try to fix Mac build.
- JavaScriptCore.xcodeproj/project.pbxproj: Made Lexer.h private.
- 4:22 PM Changeset in webkit [43262] by
-
- 1 edit in trunk/LayoutTests/platform/win/Skipped
I didn't realize that the video-zoom-controls.html test will only succeed when run with Safari 4 shell. So disabling again
- 4:16 PM Changeset in webkit [43261] by
-
- 2 edits in trunk/WebCore
wx build fix for Windows, add missing include.
https://bugs.webkit.org/show_bug.cgi?id=24798
- 4:11 PM Changeset in webkit [43260] by
-
- 5 edits in trunk
Reviewed by Kevin Ollivier.
Have wxWebkit make use of gcc(4 and greater) hidden visibility feature
https://bugs.webkit.org/show_bug.cgi?id=24345
- 4:09 PM Changeset in webkit [43259] by
-
- 8 edits in trunk/JavaScriptCore
2009-05-05 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25569: make ParserRefCounted use conventional reference counting
https://bugs.webkit.org/show_bug.cgi?id=25569
SunSpider speedup of about 1.6%.
- JavaScriptCore.exp: Updated.
- parser/Nodes.cpp: (JSC::NodeReleaser::releaseAllNodes): ALWAYS_INLINE. (JSC::NodeReleaser::adopt): Ditto. (JSC::ParserRefCounted::ParserRefCounted): Removed most of the code. Add the object to a Vector<RefPtr> that gets cleared after parsing. (JSC::ParserRefCounted::~ParserRefCounted): Removed most of the code.
- parser/Nodes.h: Made ParserRefCounted inherit from RefCounted and made inline versions of the constructor and destructor. Made the Node constructor inline.
- parser/Parser.cpp: (JSC::Parser::parse): Call globalData->parserObjects.shrink(0) after parsing, where it used to call ParserRefCounted::deleteNewObjects.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Eliminated code to manage the newParserObjects and parserObjectExtraRefCounts. (JSC::JSGlobalData::~JSGlobalData): Ditto.
- runtime/JSGlobalData.h: Replaced the HashSet and HashCountedSet with a Vector.
- wtf/PassRefPtr.h: (WTF::PassRefPtr::~PassRefPtr): The most common thing to do with a PassRefPtr in hot code is to pass it and then destroy it once it's set to zero. Help the optimizer by telling it that's true.
- 4:04 PM Changeset in webkit [43258] by
-
- 16 edits2 adds in trunk
Bug 25574: AXImageMap children links don't respond properly to accessibilityHitTest:
https://bugs.webkit.org/show_bug.cgi?id=25574
- 3:34 PM Changeset in webkit [43257] by
-
- 2 edits in trunk/WebKitTools
2009-05-06 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
http://bugs.webkit.org/show_bug.cgi?id=17066
[GTK] Improve frameloader signals
Update GtkLauncher to use the new load-status and progress properties
instead of the previous loading signals.
- GtkLauncher/main.c: (update_title): (notify_load_status_cb): (notify_progress_cb): (create_browser): (create_window):
- 3:34 PM Changeset in webkit [43256] by
-
- 7 edits in trunk/WebKit/gtk
2009-05-06 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
http://bugs.webkit.org/show_bug.cgi?id=17066
[GTK] Improve frameloader signals
Implement load-status and progress properties on the view, as well as
load-status on the frame. This supersedes the different load signals
load-progress-changed, load-committed, load-done, load-started and
load-finished which are not only misnamed but broken by design.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyStatus): (WebKit::FrameLoaderClient::postProgressStartedNotification): (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad):
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp:
- webkit/webkitwebframe.h:
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h:
- 3:32 PM Changeset in webkit [43255] by
-
- 3 edits5 adds in trunk
WebCore:
2009-05-05 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6552129> Select a quote line and paste elsewhere, you
get that line and an extra quoted blank line
<rdar://problem/6609308> Triple-click a quoted header line, copy, paste
onto an empty line makes an extra quoted line
- When pasting a blockquote with a newline, make sure we put the newline outside of the blockquote so that it is not quoted.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
LayoutTests:
2009-05-05 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6552129> Select a quote line and paste elsewhere, you
get that line and an extra quoted blank line
<rdar://problem/6609308> Triple-click a quoted header line, copy, paste
onto an empty line makes an extra quoted line
- Testing different scenarios where we paste quoted text into a non-quoted area and we do not want a trailing newline to be quoted.
- editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Added.
- editing/pasteboard/paste-blockquote-before-blockquote.html: Added.
- editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Added.
- editing/pasteboard/paste-double-nested-blockquote-before-blockquote.html: Added.
- editing/pasteboard/resources/paste-blockquote-before-blockquote.js: Added. (copyAndPasteNode):
- 3:04 PM Changeset in webkit [43254] by
-
- 1 edit in trunk/LayoutTests/platform/win/Skipped
Reenabled media test after fixing <rdar://problem/6825079>
- 3:00 PM Changeset in webkit [43253] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-05 Xan Lopez <xlopez@igalia.com> and Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Oliver Hunt.
Disable the NativeFunctionWrapper for all non-Mac ports for now,
as it is also crashing on Linux/x86.
- runtime/NativeFunctionWrapper.h:
- 2:41 PM Changeset in webkit [43252] by
-
- 2 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
STATE_CHANGED event is now named LOAD
https://bugs.webkit.org/show_bug.cgi?id=25549
- 2:37 PM Changeset in webkit [43251] by
-
- 5 edits in branches/nitro-extreme/JavaScriptCore
2009-05-05 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Remove the NumberHeap.
- JavaScriptCore.exp:
- runtime/Collector.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::recordExtraCost): (JSC::Heap::heapAllocate): (JSC::Heap::markConservatively): (JSC::Heap::sweep): (JSC::Heap::collect): (JSC::Heap::objectCount): (JSC::Heap::statistics): (JSC::typeName): (JSC::Heap::isBusy):
- runtime/Collector.h: (JSC::Heap::globalData):
- runtime/JSCell.h:
- 1:16 PM Changeset in webkit [43250] by
-
- 3 edits in trunk/WebCore
2009-05-05 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
Call moz_gtk_shutdown on RenderThemeGtk destruction.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::~RenderThemeGtk):
- platform/gtk/RenderThemeGtk.h:
- 12:57 PM Changeset in webkit [43249] by
-
- 2 edits in trunk/WebCore
2009-05-05 Darin Adler <Darin Adler>
Reviewed by Steve Falkenburg.
<rdar://problem/6858340> REGRESSION: can't drag local HTML files into Safari because CFURLCreateWithFileSystemPath inserts "localhost"
- platform/win/ClipboardUtilitiesWin.cpp: (WebCore::urlFromPath): Remove localhost.
- 12:19 PM Changeset in webkit [43248] by
-
- 2 edits in trunk/WebCore
2009-05-05 Peter Kasting <pkasting@google.com>
Reviewed by Brady Eidson.
Safety-check m_documentLoader before dereferencing. While it seems
unlikely this could fail (as Safari 3 shipped without this),
technically almost any call can change or reset m_documentLoader.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData):
- 12:05 PM Changeset in webkit [43247] by
-
- 3 edits in trunk/JavaScriptCore
Fix build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 11:16 AM Changeset in webkit [43246] by
-
- 2 edits in trunk/WebCore
- Tiger build fix
- css/CSSComputedStyleDeclaration.cpp: (WebCore::toCSSIdentifier):
- 10:47 AM Changeset in webkit [43245] by
-
- 2 edits in trunk
Add Bugzilla links
- 10:46 AM Changeset in webkit [43244] by
-
- 2 edits in trunk/WebCore
2009-05-05 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25303
No need to ref the internal buffer inside the Skia ImageDecoder.
- platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::bitmap): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setRGBA):
- 10:33 AM Changeset in webkit [43243] by
-
- 20 edits in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5760774> Replying to a Mail message that contains fixed width text can change the size of the text
Covered by existing tests: editing/pasteboard/5027857.html
editing/pasteboard/paste-pre-002.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword): Added. If the font-size is keyword-based, returns the keyword value instead of the pixel size. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): If font-family is a generic family, return the generic family instead of the the internal string -webkit-[serif|sans-serif|cursive|fantasy |monospace]. (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): For the font-size property, prefer a keyword value over a pixel size.
- css/CSSComputedStyleDeclaration.h:
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::currentlyHasStyle): For the font-size property, call getFontSizeCSSValuePreferringKeyword().
- platform/graphics/FontDescription.h: (WebCore::FontDescription::keywordSize): Changed the return type to unsigned. (WebCore::FontDescription::setKeywordSize): Changed the parameter type to unsigned. (WebCore::FontDescription::m_keywordSize): Changed the type of this 4-bit field to unsigned, because it takes values as high as 8.
LayoutTests:
Reviewed by Darin Adler.
- updated results for <rdar://problem/5760774> Replying to a Mail message that contains fixed width text can change the size of the text
- editing/execCommand/19089-expected.txt:
- editing/execCommand/5770834-1-expected.txt:
- platform/mac/editing/deleting/delete-br-011-expected.txt:
- platform/mac/editing/deleting/delete-select-all-001-expected.txt:
- platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
- platform/mac/editing/pasteboard/5027857-expected.checksum:
- platform/mac/editing/pasteboard/5027857-expected.png:
- platform/mac/editing/pasteboard/5027857-expected.txt:
- platform/mac/editing/pasteboard/paste-pre-002-expected.checksum:
- platform/mac/editing/pasteboard/paste-pre-002-expected.png:
- platform/mac/editing/pasteboard/paste-pre-002-expected.txt:
- platform/mac/editing/style/block-style-004-expected.txt:
- platform/mac/editing/style/block-style-005-expected.txt:
- platform/mac/editing/style/block-style-006-expected.txt:
- 9:41 AM Changeset in webkit [43242] by
-
- 4 edits in trunk
Fix http/tests/misc/DOMContentLoaded-event.html
Reviewed by Maciej Stachowiak
The native call performance improvement removed a few places where we
unintentionally performed a toThisObject conversion. This patch updates
the bindings codegen to not rely on this bug.
- 9:39 AM Changeset in webkit [43241] by
-
- 2 edits in trunk/WebCore
[GTK] Implement WebCore::directoryName
- 9:21 AM Changeset in webkit [43240] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-05 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
Fix memory leaks.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
- 8:58 AM Changeset in webkit [43239] by
-
- 2 edits in trunk/WebKitTools
Don't use pdevenv when building with VC++ Express
Fixes Bug 25308: REGRESSION (r42182): Build fails after following
build instructions on webkit.org fail when using VC++ Express
<https://bugs.webkit.org/show_bug.cgi?id=25308>
Reviewed by Eric Seidel.
- Scripts/webkitdirs.pm: (setupCygwinEnv): When Visual Studio is installed, set $vcBuildPath to point to pdevenv. When VC++ Express is installed, set $vcBuildPath to point to VC++ Express, as before. (buildVisualStudioProject): Use $vcBuildPath to build instead of hard-coding pdevenv.
- 8:49 AM Changeset in webkit [43238] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Adam Roben.
Add test case to cover V8 crasher (which JSC does not share).
https://bugs.webkit.org/show_bug.cgi?id=25550
- svg/custom/polyline-points-crash-expected.txt: Added.
- svg/custom/polyline-points-crash.html: Added.
- 8:41 AM Changeset in webkit [43237] by
-
- 4 edits2 adds in trunk
Reviewed by Adam Roben.
Fix mappedAttributes() access without NULL check
https://bugs.webkit.org/show_bug.cgi?id=25553
SVGStyledElement::getPresentationAttribute was using mappedAttributes()
without checking for NULL.
HTMLInputElement::setInputType also doesn't NULL check, but I was not
able to get it to crash with a test case so I just added an ASSERT.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute):
- 8:36 AM QtWebKitJournal edited by
- (diff)
- 8:23 AM QtWebKitTodo edited by
- (diff)
- 8:20 AM Changeset in webkit [43236] by
-
- 3 edits3 adds in trunk/WebKit/qt
2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Various improvements to the class documentation, including a simple snippet for QWebElement.
- 6:50 AM Changeset in webkit [43235] by
-
- 3 edits in trunk/JavaScriptCore
Make windows work again
- 6:48 AM Changeset in webkit [43234] by
-
- 1 edit6 adds in trunk/LayoutTests
Reviewed by Maciej Stachowiak.
Add a testcase using SVG in HTML with CSS transforms
https://bugs.webkit.org/show_bug.cgi?id=23112
We currently fail the <text> section of this test but pass the path and image sections.
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum: Added.
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt: Added.
- svg/transforms/animated-path-inside-transformed-html.xhtml: Added.
- 6:45 AM Changeset in webkit [43233] by
-
- 2 edits in trunk/WebCore
[GTK] Implement WebCore::imageTitle
- 6:25 AM Changeset in webkit [43232] by
-
- 2 edits in trunk/JavaScriptCore
Windows debug build fix
- 5:44 AM Changeset in webkit [43231] by
-
- 2 edits in trunk/JavaScriptCore
Hopefully the last of the build fixes
- 5:31 AM Changeset in webkit [43230] by
-
- 3 edits in trunk/JavaScriptCore
Fix build failure caused by other build fix
- 5:28 AM Changeset in webkit [43229] by
-
- 3 edits in trunk/JavaScriptCore
Yet more windows build fixes.
- 5:22 AM Changeset in webkit [43228] by
-
- 2 edits in trunk/JavaScriptCore
More windows build fixes.
- 5:16 AM Changeset in webkit [43227] by
-
- 3 edits in trunk/JavaScriptCore
More build fixes
- 5:11 AM Changeset in webkit [43226] by
-
- 6 edits in trunk/JavaScriptCore
Buildfix: Now include JSFunction.h basically everywhere we include PrototypeFunction.h
- 5:05 AM Changeset in webkit [43225] by
-
- 3 edits in trunk/JavaScriptCore
Build fixes
- 5:02 AM Changeset in webkit [43224] by
-
- 2 edits in trunk/JavaScriptCore
More build fixes
- 4:58 AM Changeset in webkit [43223] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- 4:52 AM Changeset in webkit [43222] by
-
- 7 edits in trunk/JavaScriptCore
Windows build fix
- 4:42 AM Changeset in webkit [43221] by
-
- 1 edit1 add in trunk/JavaScriptCore
Add missing file
- 4:34 AM Changeset in webkit [43220] by
-
- 39 edits2 adds in trunk
Bug 25559: Improve native function call performance
<https://bugs.webkit.org/show_bug.cgi?id=25559>
Reviewed by Gavin Barraclough
In order to cache calls to native functions we now make the standard
prototype functions use a small assembly thunk that converts the JS
calling convention into the native calling convention. As this is
only beneficial in the JIT we use the NativeFunctionWrapper typedef
to alternate between PrototypeFunction and JSFunction to keep the
code sane. This change from PrototypeFunction to NativeFunctionWrapper
is the bulk of this patch.
- 3:23 AM Changeset in webkit [43219] by
-
- 5 edits in trunk
2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Make convertValueToQVariant more robust against null JSValues.
Don't require the caller to do the null check.
- 2:10 AM Changeset in webkit [43218] by
-
- 3 edits in trunk/WebCore
No review, just a revert.
Roll out http://trac.webkit.org/changeset/43213 as it caused 4 tests to crash.
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
- 1:59 AM Changeset in webkit [43217] by
-
- 2 edits in trunk/WebKitTools
2009-05-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Mention --qt as an option in the build-webkit help
- 1:58 AM Changeset in webkit [43216] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
For convenience, let the sampling flags tool clear multiple flags at once.
- jsc.cpp: (GlobalObject::GlobalObject): (functionSetSamplingFlags): (functionClearSamplingFlags):
- 1:52 AM Changeset in webkit [43215] by
-
- 391 edits2 adds in trunk
Reviewed by Dave Hyatt.
<rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com
The problem was caused by missing <head> element - we used to create it when moving a
misplaced <style> element, but we now handle those in place. Other browsers always create
a <head> element.
There is no guarantee that a <head> element always exists - first, it can be removed with
removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
for manually created ones (e.g. ImageDocument).
Test: fast/parser/head-element-for-yahoo-player.html
WebKit:
- dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank. A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this code is removed completely.
- html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script> elements as children of <html>. This isn't directly related to this bug, but it was easier to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet. Create a <head> it a <body> is created implicitly to contain some other element. (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is explicitly present in source. (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.
LayoutTests:
- fast/parser/head-element-for-yahoo-player-expected.txt: Added.
- fast/parser/head-element-for-yahoo-player.html: Added. Test the regression case (a misplaced <style> that used to create <head> implicitly).
- editing/selection/select-all-005.html: Use a new index when selecting the body.
- fast/dom/Document/document-write-doctype-expected.txt:
- fast/dom/Document/resources/document-write-doctype.js: Removed checks for "Gecko quirk" of implicitly adding HEAD - that not a quirk, but standard behavior per HTML5.
- editing/execCommand/create-list-1-expected.txt:
- platform/mac/editing/deleting/4845371-expected.txt:
- platform/mac/editing/deleting/4866671-expected.txt:
- platform/mac/editing/deleting/4875189-expected.txt:
- platform/mac/editing/deleting/5026848-1-expected.txt:
- platform/mac/editing/deleting/5026848-2-expected.txt:
- platform/mac/editing/deleting/5026848-3-expected.txt:
- platform/mac/editing/deleting/5032066-expected.txt:
- platform/mac/editing/deleting/5091898-expected.txt:
- platform/mac/editing/deleting/5099303-expected.txt:
- platform/mac/editing/deleting/5115601-expected.txt:
- platform/mac/editing/deleting/5126166-expected.txt:
- platform/mac/editing/deleting/5156801-2-expected.txt:
- platform/mac/editing/deleting/5168598-expected.txt:
- platform/mac/editing/deleting/5272440-expected.txt:
- platform/mac/editing/deleting/5300379-expected.txt:
- platform/mac/editing/deleting/5390681-expected.txt:
- platform/mac/editing/deleting/5408255-expected.txt:
- platform/mac/editing/deleting/5433862-2-expected.txt:
- platform/mac/editing/deleting/5483370-expected.txt:
- platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
- platform/mac/editing/deleting/delete-block-table-expected.txt:
- platform/mac/editing/deleting/delete-hr-expected.txt:
- platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.txt:
- platform/mac/editing/deleting/delete-to-select-table-expected.txt:
- platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
- platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/mac/editing/deleting/merge-no-br-expected.txt:
- platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
- platform/mac/editing/execCommand/4641880-1-expected.txt:
- platform/mac/editing/execCommand/4641880-2-expected.txt:
- platform/mac/editing/execCommand/4747450-expected.txt:
- platform/mac/editing/execCommand/4786404-1-expected.txt:
- platform/mac/editing/execCommand/4786404-2-expected.txt:
- platform/mac/editing/execCommand/4916402-expected.txt:
- platform/mac/editing/execCommand/4916541-expected.txt:
- platform/mac/editing/execCommand/4916583-expected.txt:
- platform/mac/editing/execCommand/4920488-expected.txt:
- platform/mac/editing/execCommand/4920742-1-expected.txt:
- platform/mac/editing/execCommand/4924441-expected.txt:
- platform/mac/editing/execCommand/5049671-expected.txt:
- platform/mac/editing/execCommand/5080333-1-expected.txt:
- platform/mac/editing/execCommand/5080333-2-expected.txt:
- platform/mac/editing/execCommand/5119244-expected.txt:
- platform/mac/editing/execCommand/5120591-expected.txt:
- platform/mac/editing/execCommand/5136770-expected.txt:
- platform/mac/editing/execCommand/5142012-1-expected.txt:
- platform/mac/editing/execCommand/5142012-2-expected.txt:
- platform/mac/editing/execCommand/5142012-3-expected.txt:
- platform/mac/editing/execCommand/5144139-1-expected.txt:
- platform/mac/editing/execCommand/5164796-expected.txt:
- platform/mac/editing/execCommand/5207369-expected.txt:
- platform/mac/editing/execCommand/5210032-expected.txt:
- platform/mac/editing/execCommand/5432254-1-expected.txt:
- platform/mac/editing/execCommand/5432254-2-expected.txt:
- platform/mac/editing/execCommand/5481523-expected.txt:
- platform/mac/editing/execCommand/5482524-expected.txt:
- platform/mac/editing/execCommand/5569741-expected.txt:
- platform/mac/editing/execCommand/5573879-expected.txt:
- platform/mac/editing/execCommand/5700414-1-expected.txt:
- platform/mac/editing/execCommand/5700414-2-expected.txt:
- platform/mac/editing/execCommand/insert-list-empty-div-expected.txt:
- platform/mac/editing/input/5576619-expected.txt:
- platform/mac/editing/inserting/12882-expected.txt:
- platform/mac/editing/inserting/4840662-expected.txt:
- platform/mac/editing/inserting/4875189-1-expected.txt:
- platform/mac/editing/inserting/4875189-2-expected.txt:
- platform/mac/editing/inserting/4959067-expected.txt:
- platform/mac/editing/inserting/4960120-1-expected.txt:
- platform/mac/editing/inserting/4960120-2-expected.txt:
- platform/mac/editing/inserting/5002441-expected.txt:
- platform/mac/editing/inserting/5058163-2-expected.txt:
- platform/mac/editing/inserting/5156401-2-expected.txt:
- platform/mac/editing/inserting/5549929-2-expected.txt:
- platform/mac/editing/inserting/5549929-3-expected.txt:
- platform/mac/editing/inserting/5607069-2-expected.txt:
- platform/mac/editing/inserting/5607069-3-expected.txt:
- platform/mac/editing/inserting/editable-html-element-expected.txt:
- platform/mac/editing/inserting/editable-inline-element-expected.txt:
- platform/mac/editing/inserting/edited-whitespace-1-expected.txt:
- platform/mac/editing/inserting/editing-empty-divs-expected.txt:
- platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
- platform/mac/editing/pasteboard/4806874-expected.txt:
- platform/mac/editing/pasteboard/4861080-expected.txt:
- platform/mac/editing/pasteboard/4944770-1-expected.txt:
- platform/mac/editing/pasteboard/4944770-2-expected.txt:
- platform/mac/editing/pasteboard/4947130-expected.txt:
- platform/mac/editing/pasteboard/4989774-expected.txt:
- platform/mac/editing/pasteboard/5027857-expected.txt:
- platform/mac/editing/pasteboard/5032095-expected.txt:
- platform/mac/editing/pasteboard/5065605-expected.txt:
- platform/mac/editing/pasteboard/5071074-2-expected.txt:
- platform/mac/editing/pasteboard/5071074-expected.txt:
- platform/mac/editing/pasteboard/5075944-2-expected.txt:
- platform/mac/editing/pasteboard/5075944-3-expected.txt:
- platform/mac/editing/pasteboard/5075944-expected.txt:
- platform/mac/editing/pasteboard/5134759-expected.txt:
- platform/mac/editing/pasteboard/5156401-1-expected.txt:
- platform/mac/editing/pasteboard/5247341-expected.txt:
- platform/mac/editing/pasteboard/5387578-expected.txt:
- platform/mac/editing/pasteboard/5478250-expected.txt:
- platform/mac/editing/pasteboard/5483567-expected.txt:
- platform/mac/editing/pasteboard/5601583-1-expected.txt:
- platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
- platform/mac/editing/pasteboard/input-field-1-expected.txt:
- platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
- platform/mac/editing/pasteboard/merge-start-blockquote-expected.txt:
- platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt:
- platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt:
- platform/mac/editing/pasteboard/select-element-1-expected.txt:
- platform/mac/editing/selection/13804-expected.txt:
- platform/mac/editing/selection/14971-expected.txt:
- platform/mac/editing/selection/4397952-expected.txt:
- platform/mac/editing/selection/4818145-expected.txt:
- platform/mac/editing/selection/4866671-expected.txt:
- platform/mac/editing/selection/4889598-expected.txt:
- platform/mac/editing/selection/4895428-1-expected.txt:
- platform/mac/editing/selection/4895428-2-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4895428-4-expected.txt:
- platform/mac/editing/selection/4932260-1-expected.txt:
- platform/mac/editing/selection/4932260-2-expected.txt:
- platform/mac/editing/selection/4932260-3-expected.txt:
- platform/mac/editing/selection/4947387-expected.txt:
- platform/mac/editing/selection/4960116-expected.txt:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/4983858-expected.txt:
- platform/mac/editing/selection/5007143-2-expected.txt:
- platform/mac/editing/selection/5007143-expected.txt:
- platform/mac/editing/selection/5057506-2-expected.txt:
- platform/mac/editing/selection/5057506-expected.txt:
- platform/mac/editing/selection/5076323-1-expected.txt:
- platform/mac/editing/selection/5076323-2-expected.txt:
- platform/mac/editing/selection/5076323-3-expected.txt:
- platform/mac/editing/selection/5081257-1-expected.txt:
- platform/mac/editing/selection/5081257-2-expected.txt:
- platform/mac/editing/selection/5099303-expected.txt:
- platform/mac/editing/selection/5109817-expected.txt:
- platform/mac/editing/selection/5136696-expected.txt:
- platform/mac/editing/selection/5195166-1-expected.txt:
- platform/mac/editing/selection/5195166-2-expected.txt:
- platform/mac/editing/selection/5234383-1-expected.txt:
- platform/mac/editing/selection/5234383-2-expected.txt:
- platform/mac/editing/selection/5240265-expected.txt:
- platform/mac/editing/selection/5333725-expected.txt:
- platform/mac/editing/selection/5354455-1-expected.txt:
- platform/mac/editing/selection/addRange-expected.txt:
- platform/mac/editing/selection/caret-before-select-expected.txt:
- platform/mac/editing/selection/contains-boundaries-expected.txt:
- platform/mac/editing/selection/drag-select-1-expected.txt:
- platform/mac/editing/selection/editable-html-element-expected.txt:
- platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt:
- platform/mac/editing/selection/inline-closest-leaf-child-expected.txt:
- platform/mac/editing/selection/mixed-editability-6-expected.txt:
- platform/mac/editing/selection/mixed-editability-7-expected.txt:
- platform/mac/editing/selection/move-by-sentence-linebreak-expected.txt:
- platform/mac/editing/selection/select-all-005-expected.txt:
- platform/mac/editing/selection/table-caret-1-expected.txt:
- platform/mac/editing/selection/table-caret-2-expected.txt:
- platform/mac/editing/selection/table-caret-3-expected.txt:
- platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
- platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
- platform/mac/editing/style/4916887-expected.txt:
- platform/mac/editing/style/5017613-1-expected.txt:
- platform/mac/editing/style/5017613-2-expected.txt:
- platform/mac/editing/style/5046875-1-expected.txt:
- platform/mac/editing/style/5046875-2-expected.txt:
- platform/mac/editing/style/5065910-expected.txt:
- platform/mac/editing/style/5084241-expected.txt:
- platform/mac/editing/style/5091898-expected.txt:
- platform/mac/editing/style/5228141-expected.txt:
- platform/mac/editing/style/5279521-expected.txt:
- platform/mac/editing/style/font-family-with-space-expected.txt:
- platform/mac/editing/style/fontsize-1-expected.txt:
- platform/mac/editing/style/highlight-expected.txt:
- platform/mac/editing/style/non-inheritable-styles-expected.txt:
- platform/mac/editing/undo/5378473-expected.txt:
- platform/mac/fast/block/float/relative-painted-twice-expected.txt:
- platform/mac/fast/dom/delete-contents-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/events/label-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-click-outside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/inline/25277-2-expected.txt:
- platform/mac/fast/inline/25277-expected.txt:
- platform/mac/fast/lists/drag-into-marker-expected.txt:
- platform/mac/fast/overflow/overflow-focus-ring-expected.txt:
- platform/mac/fast/repaint/4776765-expected.txt:
- platform/mac/fast/repaint/selection-after-delete-expected.txt:
- platform/mac/fast/repaint/selection-after-remove-expected.txt:
- platform/qt/editing/deleting/4845371-expected.txt:
- platform/qt/editing/deleting/4866671-expected.txt:
- platform/qt/editing/deleting/4875189-expected.txt:
- platform/qt/editing/deleting/5026848-1-expected.txt:
- platform/qt/editing/deleting/5026848-2-expected.txt:
- platform/qt/editing/deleting/5026848-3-expected.txt:
- platform/qt/editing/deleting/5032066-expected.txt:
- platform/qt/editing/deleting/5091898-expected.txt:
- platform/qt/editing/deleting/5099303-expected.txt:
- platform/qt/editing/deleting/5115601-expected.txt:
- platform/qt/editing/deleting/5126166-expected.txt:
- platform/qt/editing/deleting/5144139-2-expected.txt:
- platform/qt/editing/deleting/5156801-2-expected.txt:
- platform/qt/editing/deleting/5168598-expected.txt:
- platform/qt/editing/deleting/5272440-expected.txt:
- platform/qt/editing/deleting/5300379-expected.txt:
- platform/qt/editing/deleting/5390681-expected.txt:
- platform/qt/editing/deleting/5408255-expected.txt:
- platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
- platform/qt/editing/deleting/delete-block-table-expected.txt:
- platform/qt/editing/deleting/delete-hr-expected.txt:
- platform/qt/editing/deleting/delete-link-1-expected.txt:
- platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.txt:
- platform/qt/editing/deleting/delete-to-select-table-expected.txt:
- platform/qt/editing/deleting/deletionUI-single-instance-expected.txt:
- platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/qt/editing/deleting/merge-no-br-expected.txt:
- platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
- platform/qt/editing/execCommand/4641880-1-expected.txt:
- platform/qt/editing/execCommand/4641880-2-expected.txt:
- platform/qt/editing/execCommand/4747450-expected.txt:
- platform/qt/editing/execCommand/4786404-1-expected.txt:
- platform/qt/editing/execCommand/4786404-2-expected.txt:
- platform/qt/editing/execCommand/4916402-expected.txt:
- platform/qt/editing/execCommand/4916541-expected.txt:
- platform/qt/editing/execCommand/4916583-expected.txt:
- platform/qt/editing/execCommand/4920488-expected.txt:
- platform/qt/editing/execCommand/4920742-1-expected.txt:
- platform/qt/editing/execCommand/4924441-expected.txt:
- platform/qt/editing/execCommand/5049671-expected.txt:
- platform/qt/editing/execCommand/5062376-expected.txt:
- platform/qt/editing/execCommand/5080333-1-expected.txt:
- platform/qt/editing/execCommand/5080333-2-expected.txt:
- platform/qt/editing/execCommand/5119244-expected.txt:
- platform/qt/editing/execCommand/5120591-expected.txt:
- platform/qt/editing/execCommand/5136770-expected.txt:
- platform/qt/editing/execCommand/5142012-1-expected.txt:
- platform/qt/editing/execCommand/5142012-2-expected.txt:
- platform/qt/editing/execCommand/5142012-3-expected.txt:
- platform/qt/editing/execCommand/5144139-1-expected.txt:
- platform/qt/editing/execCommand/5164796-expected.txt:
- platform/qt/editing/execCommand/5207369-expected.txt:
- platform/qt/editing/execCommand/5210032-expected.txt:
- platform/qt/editing/execCommand/5432254-1-expected.txt:
- platform/qt/editing/execCommand/5432254-2-expected.txt:
- platform/qt/editing/execCommand/insert-list-empty-div-expected.txt:
- platform/qt/editing/inserting/12882-expected.txt:
- platform/qt/editing/inserting/4840662-expected.txt:
- platform/qt/editing/inserting/4875189-1-expected.txt:
- platform/qt/editing/inserting/4875189-2-expected.txt:
- platform/qt/editing/inserting/4959067-expected.txt:
- platform/qt/editing/inserting/4960120-1-expected.txt:
- platform/qt/editing/inserting/4960120-2-expected.txt:
- platform/qt/editing/inserting/5002441-expected.txt:
- platform/qt/editing/inserting/5058163-2-expected.txt:
- platform/qt/editing/inserting/5156401-2-expected.txt:
- platform/qt/editing/inserting/editable-html-element-expected.txt:
- platform/qt/editing/inserting/editable-inline-element-expected.txt:
- platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
- platform/qt/editing/inserting/editing-empty-divs-expected.txt:
- platform/qt/editing/inserting/insert-before-link-1-expected.txt:
- platform/qt/editing/pasteboard/4806874-expected.txt:
- platform/qt/editing/pasteboard/4840662-expected.txt:
- platform/qt/editing/pasteboard/4944770-1-expected.txt:
- platform/qt/editing/pasteboard/4989774-expected.txt:
- platform/qt/editing/pasteboard/5027857-expected.txt:
- platform/qt/editing/pasteboard/5032095-expected.txt:
- platform/qt/editing/pasteboard/5065605-expected.txt:
- platform/qt/editing/pasteboard/5071074-2-expected.txt:
- platform/qt/editing/pasteboard/5071074-expected.txt:
- platform/qt/editing/pasteboard/5075944-2-expected.txt:
- platform/qt/editing/pasteboard/5075944-3-expected.txt:
- platform/qt/editing/pasteboard/5075944-expected.txt:
- platform/qt/editing/pasteboard/5134759-expected.txt:
- platform/qt/editing/pasteboard/5156401-1-expected.txt:
- platform/qt/editing/pasteboard/5245519-expected.txt:
- platform/qt/editing/pasteboard/5247341-expected.txt:
- platform/qt/editing/pasteboard/5387578-expected.txt:
- platform/qt/editing/pasteboard/5478250-expected.txt:
- platform/qt/editing/pasteboard/5483567-expected.txt:
- platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
- platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
- platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
- platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
- platform/qt/editing/selection/13804-expected.txt:
- platform/qt/editing/selection/4397952-expected.txt:
- platform/qt/editing/selection/4818145-expected.txt:
- platform/qt/editing/selection/4866671-expected.txt:
- platform/qt/editing/selection/4889598-expected.txt:
- platform/qt/editing/selection/4895428-2-expected.txt:
- platform/qt/editing/selection/4895428-3-expected.txt:
- platform/qt/editing/selection/4932260-1-expected.txt:
- platform/qt/editing/selection/4932260-2-expected.txt:
- platform/qt/editing/selection/4932260-3-expected.txt:
- platform/qt/editing/selection/4960116-expected.txt:
- platform/qt/editing/selection/4983858-expected.txt:
- platform/qt/editing/selection/5007143-2-expected.txt:
- platform/qt/editing/selection/5007143-expected.txt:
- platform/qt/editing/selection/5076323-1-expected.txt:
- platform/qt/editing/selection/5076323-2-expected.txt:
- platform/qt/editing/selection/5076323-3-expected.txt:
- platform/qt/editing/selection/5081257-1-expected.txt:
- platform/qt/editing/selection/5081257-2-expected.txt:
- platform/qt/editing/selection/5099303-expected.txt:
- platform/qt/editing/selection/5136696-expected.txt:
- platform/qt/editing/selection/5195166-1-expected.txt:
- platform/qt/editing/selection/5195166-2-expected.txt:
- platform/qt/editing/selection/5234383-1-expected.txt:
- platform/qt/editing/selection/5234383-2-expected.txt:
- platform/qt/editing/selection/5240265-expected.txt:
- platform/qt/editing/selection/addRange-expected.txt:
- platform/qt/editing/selection/caret-before-select-expected.txt:
- platform/qt/editing/selection/editable-html-element-expected.txt:
- platform/qt/editing/selection/mixed-editability-6-expected.txt:
- platform/qt/editing/selection/mixed-editability-7-expected.txt:
- platform/qt/editing/selection/move-by-sentence-linebreak-expected.txt:
- platform/qt/editing/selection/select-all-005-expected.txt:
- platform/qt/editing/selection/table-caret-1-expected.txt:
- platform/qt/editing/selection/table-caret-2-expected.txt:
- platform/qt/editing/selection/table-caret-3-expected.txt:
- platform/qt/editing/style/4916887-expected.txt:
- platform/qt/editing/style/5017613-1-expected.txt:
- platform/qt/editing/style/5017613-2-expected.txt:
- platform/qt/editing/style/5046875-1-expected.txt:
- platform/qt/editing/style/5046875-2-expected.txt:
- platform/qt/editing/style/5065910-expected.txt:
- platform/qt/editing/style/5084241-expected.txt:
- platform/qt/editing/style/5228141-expected.txt:
- platform/qt/editing/style/5279521-expected.txt:
- platform/qt/editing/style/font-family-with-space-expected.txt:
- platform/qt/editing/style/fontsize-1-expected.txt:
- platform/qt/editing/style/highlight-expected.txt:
- platform/qt/editing/style/non-inheritable-styles-expected.txt:
- platform/qt/editing/undo/5378473-expected.txt:
- platform/qt/fast/dom/delete-contents-expected.txt:
- platform/qt/fast/events/label-focus-expected.txt:
- platform/qt/fast/forms/input-appearance-focus-expected.txt:
- platform/qt/fast/forms/input-maxlength-2-expected.txt:
- platform/qt/fast/forms/input-text-click-inside-expected.txt:
- platform/qt/fast/forms/input-text-option-delete-expected.txt:
- platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt:
- platform/qt/fast/forms/textfield-overflow-expected.txt:
- platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
- platform/qt/fast/repaint/4776765-expected.txt:
- platform/qt/fast/repaint/selection-after-delete-expected.txt:
- platform/qt/fast/repaint/selection-after-remove-expected.txt:
- platform/win/editing/deleting/5168598-expected.txt:
- platform/win/editing/inserting/4960120-1-expected.txt:
- platform/win/editing/inserting/5607069-2-expected.txt:
- platform/win/editing/inserting/5607069-3-expected.txt:
- platform/win/editing/inserting/typing-tab-designmode-forms-expected.txt:
- platform/win/editing/pasteboard/4806874-expected.txt:
- platform/win/editing/selection/4895428-3-expected.txt:
- platform/win/editing/selection/5136696-expected.txt:
- platform/win/editing/selection/drag-select-1-expected.txt:
- platform/win/fast/events/context-no-deselect-expected.txt:
- platform/win/fast/events/label-focus-expected.txt:
- platform/win/fast/forms/input-appearance-focus-expected.txt:
- platform/win/fast/forms/input-text-click-inside-expected.txt:
- platform/win/fast/forms/input-text-click-outside-expected.txt:
- platform/win/fast/forms/input-text-double-click-expected.txt:
- platform/win/fast/forms/input-text-drag-down-expected.txt:
- platform/win/fast/forms/input-text-option-delete-expected.txt:
- platform/win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/win/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/win/fast/forms/textfield-drag-into-disabled-expected.txt:
- platform/win/fast/forms/textfield-overflow-expected.txt: Updated BODY element index in test output (for some tests, it increased because of the implicitly added <head>, and for others, it decreased because mispositoned <script> is being moved into <head>).
- webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
- webarchive/archive-empty-frame-dom-expected.webarchive: Updated to include the implicitly added <head> elements.
- 1:24 AM Changeset in webkit [43214] by
-
- 2 edits in trunk/WebCore
2009-05-04 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
As Qtish implementation of MIMETypeRegistry::getMIMETypeForExtension()
returns the application/octet-stream mimetype when it can't associate
extension with any mimetype, it can happen that the application/octet-stream
mimetype will hit the list of supported image formats. For instance,
it is possible when QImageReader or QImageWriter support an extension
that is not in the extensions map.
Make sure that this mimetype is not treated as displayable image type.
- 1:15 AM Changeset in webkit [43213] by
-
- 3 edits in trunk/WebCore
Reviewed by Simon Fraser.
ASSERT(useTransforms) in SVG mapLocalToContainer implementations
https://bugs.webkit.org/show_bug.cgi?id=25532
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
- 1:15 AM Changeset in webkit [43212] by
-
- 3 edits in trunk/WebCore
Reviewed by Simon Fraser.
Remove m_absoluteBounds hack from RenderSVGText
https://bugs.webkit.org/show_bug.cgi?id=25532
No functional changes (SVGs inside CSS transformed HTML should theoretically repaint better)
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
- rendering/RenderSVGText.h:
- 1:15 AM Changeset in webkit [43211] by
-
- 15 edits in trunk
Reviewed by Simon Fraser.
Remove the vestigial calculateLocalTransform()
https://bugs.webkit.org/show_bug.cgi?id=25532
RenderSVGContainer is now the only render which needs this
function, but it no longer returns the unused bool.
calculateLocalTransform() previously was called by the DOM before
transform updates were part of layout().
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
- rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::localTransform):
- rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp:
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::calculateLocalTransform):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
- rendering/RenderSVGText.h:
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/RenderSVGTransformableContainer.h:
- 1:14 AM Changeset in webkit [43210] by
-
- 7 edits in trunk/WebCore
Reviewed by Simon Fraser.
Move more code into SVGRenderBase
https://bugs.webkit.org/show_bug.cgi?id=25532
clippedOverflowRectForRepaint, computeRectForRepaint and mapLocalToContainer
are now all shared via SVGRenderBase.
RenderForeignObject should also be sharing this code, but I've left it
alone for now, as changing that would likely cause test changes.
No test changes. It's possible that transformed <svg:image> elements will
now show up with better metrics in the inspector.
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::clippedOverflowRectForRepaint): (WebCore::RenderSVGImage::computeRectForRepaint): (WebCore::RenderSVGImage::mapLocalToContainer):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint): (WebCore::RenderSVGModelObject::computeRectForRepaint): (WebCore::RenderSVGModelObject::mapLocalToContainer):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint): (WebCore::RenderSVGText::computeRectForRepaint): (WebCore::RenderSVGText::mapLocalToContainer):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::clippedOverflowRectForRepaint): (WebCore::SVGRenderBase::computeRectForRepaint): (WebCore::SVGRenderBase::mapLocalToContainer):
- rendering/SVGRenderSupport.h:
- 1:14 AM Changeset in webkit [43209] by
-
- 11 edits in trunk/WebCore
Reviewed by Simon Fraser.
Add SVGRenderBase to share logic between SVG renderers
https://bugs.webkit.org/show_bug.cgi?id=25532
I've added an SVGRenderBase base class which is shared by
all of the SVG renders now. This patch is just moving code
there are no functional changes in this patch.
Currently I've left these functions in SVGRenderSupport.h
In a later patch I will rename SVGRenderSupport.* to SVGRenderBase.*
clampImageBufferSizeToViewport now takes a FrameView* which makes some code easier to read.
- rendering/RenderSVGBlock.h:
- rendering/RenderSVGImage.h:
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGRoot.h:
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::clampImageBufferSizeToViewport): (WebCore::SVGRenderBase::computeContainerBoundingBox): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
- rendering/SVGRenderSupport.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback): (WebCore::SVGRootInlineBox::paint):
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask):
- 12:51 AM Changeset in webkit [43208] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-05 Sam Weinig <sam@webkit.org>
Fix build.
- runtime/JSValue.h: (JSC::JSValue::): s/#PLATFORM/#if PLATFORM/
- 12:18 AM Changeset in webkit [43207] by
-
- 18 edits in trunk/WebCore
2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed SVG build fix.
Include MappedAttribute.h after r43187.
May 4, 2009:
- 11:01 PM Changeset in webkit [43206] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-04 Sam Weinig <sam@webkit.org>
Make CallFrame dumping more useful by dumping a description and
all 64 bits of registers.
- interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters):
- runtime/JSValue.cpp: (JSC::JSValue::description):
- runtime/JSValue.h:
- 10:37 PM Changeset in webkit [43205] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-04 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Gavin.
- inline Vector::resize for a ~1.5% speedup on string-tagcloud
- wtf/Vector.h: (WTF::Vector::resize): Inline
- 9:46 PM Changeset in webkit [43204] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
PPC fix.
- runtime/JSValue.h: (JSC::JSValue::): endian little hate i.
- 9:45 PM Changeset in webkit [43203] by
-
- 2 edits in trunk/LayoutTests
2009-05-04 Holger Hans Peter Freyther <zecke@selfish.org>
Disabling accessibility/canvas.html due the lack of a
an AccessibilityController implementation in DRT.
- platform/gtk/Skipped:
- 9:06 PM Changeset in webkit [43202] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-04 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix regression in fast/js/exception-sequencing-binops.html caused by
evaluating the arguments passed to fmod in the wrong order.
All LayoutTests now pass.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- 6:47 PM Changeset in webkit [43201] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed some number bugs. 3x speedup, since this patch restores all our
int-based optimizations.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Make sure negate of 0 yields -0.
- runtime/JSValue.cpp: (JSC::JSValue::description): Fixed some typos in debug logging code. (Missing "else" before "if".)
- runtime/JSValue.h: (JSC::JSValue::JSValue): Convert doubles to int if possible, as we do on trunk.
- 6:18 PM Changeset in webkit [43200] by
-
- 3 edits in trunk/WebCore
2009-05-04 Brady Eidson <beidson@apple.com>
Reviewed by Sam 'The Belly' Weinig
<rdar://problem/6828894> - Facebook photo uploader applet broken on Leopard only
In r41568 we started adding a default codebase attribute to <applet> tags if they didn't specify one
themselves. Leopard's Java plug-in mishandles this case and fails to load code for the applet.
The spirit of r41568 can be maintained by removing the "default codebase" piece and only performing
the canLoad() check if a codebase was actually set on the applet tag.
- html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Don't create a default codebase attribute.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createJavaAppletWidget): Only perform the canLoad() check if the codebase was set.
- 6:04 PM Changeset in webkit [43199] by
-
- 9 edits1 add1 delete in branches/nitro-extreme
2009-05-04 Sam Weinig <sam@webkit.org>
Make WebCore compile with the new JS number representation.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSAPIValueWrapper.h:
- runtime/JSString.h:
WebCore:
2009-05-04 Sam Weinig <sam@webkit.org>
Make WebCore compile with the new JS number representation.
- ForwardingHeaders/runtime/JSAPIValueWrapper.h: Added.
- ForwardingHeaders/runtime/JSNumberCell.h: Removed.
- bindings/js/ScriptEventListener.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/c/c_instance.cpp:
- 6:00 PM Changeset in webkit [43198] by
-
- 3 edits in trunk/WebCore
Windows build fix
- html/HTMLCollection.h:
- html/HTMLFormElement.h: Declare CollectionCache as a struct, not a class, to match its definition.
- 5:39 PM Changeset in webkit [43197] by
-
- 3 edits2 adds in trunk
Bug 25557: REGRESSION: Canvas elements are ignored instead of being exposed as AXImage
https://bugs.webkit.org/show_bug.cgi?id=25557
- 5:25 PM Changeset in webkit [43196] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-05-04 Brady Eidson <beidson@apple.com>
Fix an ancient Changelog entry where Sam Weinig flat out lied and confused my exploration of a bug.
- ChangeLog
- 5:20 PM Changeset in webkit [43195] by
-
- 3 edits2 adds in trunk
2009-05-04 Kai Brüning <kai@granus.net>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24883
24883: Bad success test in parseXMLDocumentFragment in XMLTokenizerLibxml2.cpp
Fixed test whether all the chunk has been processed to correctly count utf8 bytes.
Test: fast/innerHTML/innerHTML-nbsp.xhtml
- dom/XMLTokenizerLibxml2.cpp: (WebCore::parseXMLDocumentFragment):
- 3:37 PM Changeset in webkit [43194] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-04 Sam Weinig <sam@webkit.org>
Re-enable Yarr! It still works.
- wtf/Platform.h:
- 3:29 PM Changeset in webkit [43193] by
-
- 33 edits2 moves in branches/nitro-extreme/JavaScriptCore
2009-05-04 Sam Weinig <sam@webkit.org>
Land initial commit of new number representation for 32 bit platforms.
- 1:11 PM Changeset in webkit [43192] by
-
- 2 edits in trunk/LayoutTests
2009-05-04 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Disable a test that's timing out.
- 1:08 PM Changeset in webkit [43191] by
-
- 2 edits in trunk/WebKit/win
2009-05-04 Darin Adler <Darin Adler>
First try at fixing the Windows build.
- DOMHTMLClasses.cpp: Added include of HTMLCollection.h.
- 12:38 PM Changeset in webkit [43190] by
-
- 2 edits2 deletes in trunk/LayoutTests
2009-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disabling new tests, as they are failing because of font
configuration mismatch between my machine and the bot.
- platform/gtk/Skipped:
- platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Removed.
- platform/gtk/svg/text/foreignObject-repaint-expected.txt: Removed.
- 12:13 PM Changeset in webkit [43189] by
-
- 2 edits in trunk/WebKit/mac
2009-05-04 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Fix <rdar://problem/6797644>.
Make sure to send a reply even when an instance proxy can't be found.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke): (WKPCInvokeDefault): (WKPCGetProperty): (WKPCHasProperty): (WKPCHasMethod): (WKPCEnumerate):
- 11:12 AM Changeset in webkit [43188] by
-
- 3 edits6 adds in trunk
LayoutTests:
2009-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Alexey Proskuryakov.
Add results for two new tests, for the GTK+ port.
- platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Added.
- platform/gtk/svg/text/foreignObject-repaint-expected.txt: Added.
WebKitTools:
2009-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Alexey Proskuryakov.
Enable spell-checking in DumpRenderTree.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- 11:00 AM Changeset in webkit [43187] by
-
- 137 edits3 copies in trunk
WebCore:
2009-05-04 Darin Adler <Darin Adler>
Reviewed by Eric Seidel.
Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
and NamedMappedAttrMap.h include of MappedAttribute.h
https://bugs.webkit.org/show_bug.cgi?id=24924
Make compiles faster, and debugging info smaller.
- GNUmakefile.am: Added new source files.
- WebCore.pro: Ditto.
- WebCore.scons: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): Updated for new collection type names.
- dom/Document.cpp: (WebCore::Document::createAttribute): Added. No longer inline. (WebCore::Document::images): Updated for new collection type names. (WebCore::Document::applets): Ditto. (WebCore::Document::embeds): Ditto. (WebCore::Document::plugins): Ditto. (WebCore::Document::objects): Ditto. (WebCore::Document::scripts): Ditto. (WebCore::Document::links): Ditto. (WebCore::Document::forms): Ditto. (WebCore::Document::anchors): Ditto. (WebCore::Document::all): Ditto. (WebCore::Document::windowNamedItems): Ditto. (WebCore::Document::documentNamedItems): Ditto. (WebCore::Document::nameCollectionInfo): Ditto.
- dom/Document.h: Changed around includes and forward declarations. Updated for changes to collection types.
- dom/NamedMappedAttrMap.h: Removed include of MappedAttribute.h.
- html/CollectionCache.cpp: Copied from WebCore/html/HTMLCollection.cpp. Contains the class that used to be HTMLCollection::CollectionInfo.
- html/CollectionCache.h: Copied from WebCore/html/HTMLCollection.h. Ditto.
- html/CollectionType.h: Copied from WebCore/html/HTMLCollection.h. Has the enum that used to be HTMLCollection::Type.
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): Update for collection type change. (WebCore::HTMLCollection::create): Ditto. (WebCore::HTMLCollection::resetCollectionInfo): Ditto. (WebCore::HTMLCollection::itemAfter): Ditto.
- html/HTMLCollection.h: Ditto.
- html/HTMLElement.cpp: (WebCore::HTMLElement::children): Updated for new collection type names.
- html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Ditto. (WebCore::HTMLFormCollection::HTMLFormCollection): Ditto.
- html/HTMLFormCollection.h: Ditto.
- html/HTMLFormElement.h: Ditto.
- html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::areas): Ditto.
- html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
- html/HTMLNameCollection.h: (WebCore::HTMLNameCollection::create): Ditto.
- html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::collectionInfo): Ditto.
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::tBodies):Ditto.
- html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::cells):Ditto.
- html/HTMLTableRowsCollection.cpp: (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Ditto.
- html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows): Ditto.
- bindings/js/JSDOMWindowBase.cpp: Added newly-needed includes.
- bindings/js/JSHTMLFrameSetElementCustom.cpp: Ditto.
- css/CSSStyleSelector.cpp: Ditto.
- dom/Element.cpp: Ditto.
- dom/InputElement.cpp: Ditto.
- dom/NamedAttrMap.cpp: Ditto.
- dom/NamedMappedAttrMap.cpp: Ditto.
- dom/Node.cpp: Ditto.
- dom/StyledElement.cpp: Ditto.
- dom/StyledElement.h: Ditto.
- editing/ApplyStyleCommand.cpp: Ditto.
- editing/DeleteSelectionCommand.cpp: Ditto.
- editing/Editor.cpp: Ditto.
- editing/EditorCommand.cpp: Ditto.
- editing/InsertParagraphSeparatorCommand.cpp: Ditto.
- editing/ReplaceSelectionCommand.cpp: Ditto.
- editing/markup.cpp: Ditto.
- html/CanvasRenderingContext2D.cpp: Ditto.
- html/HTMLAnchorElement.cpp: Ditto.
- html/HTMLAppletElement.cpp: Ditto.
- html/HTMLAreaElement.cpp: Ditto.
- html/HTMLBRElement.cpp: Ditto.
- html/HTMLBaseElement.cpp: Ditto.
- html/HTMLBodyElement.cpp: Ditto.
- html/HTMLButtonElement.cpp: Ditto.
- html/HTMLCanvasElement.cpp: Ditto.
- html/HTMLDivElement.cpp: Ditto.
- html/HTMLEmbedElement.cpp: Ditto.
- html/HTMLFontElement.cpp: Ditto.
- html/HTMLFormControlElement.cpp: Ditto.
- html/HTMLFormElement.cpp: Ditto.
- html/HTMLFrameElement.cpp: Ditto.
- html/HTMLFrameElementBase.cpp: Ditto.
- html/HTMLFrameSetElement.cpp: Ditto.
- html/HTMLHRElement.cpp: Ditto.
- html/HTMLIFrameElement.cpp: Ditto.
- html/HTMLImageElement.cpp: Ditto.
- html/HTMLInputElement.cpp: Ditto.
- html/HTMLIsIndexElement.cpp: Ditto.
- html/HTMLKeygenElement.cpp: Ditto.
- html/HTMLLIElement.cpp: Ditto.
- html/HTMLLinkElement.cpp: Ditto.
- html/HTMLMarqueeElement.cpp: Ditto.
- html/HTMLMetaElement.cpp: Ditto.
- html/HTMLOListElement.cpp: Ditto.
- html/HTMLObjectElement.cpp: Ditto.
- html/HTMLOptionElement.cpp: Ditto.
- html/HTMLParagraphElement.cpp: Ditto.
- html/HTMLParamElement.cpp: Ditto.
- html/HTMLPlugInElement.cpp: Ditto.
- html/HTMLPreElement.cpp: Ditto.
- html/HTMLScriptElement.cpp: Ditto.
- html/HTMLSelectElement.cpp: Ditto.
- html/HTMLStyleElement.cpp: Ditto.
- html/HTMLTableCaptionElement.cpp: Ditto.
- html/HTMLTableCellElement.cpp: Ditto.
- html/HTMLTableColElement.cpp: Ditto.
- html/HTMLTablePartElement.cpp: Ditto.
- html/HTMLTextAreaElement.cpp: Ditto.
- html/HTMLTokenizer.cpp: Ditto.
- html/HTMLUListElement.cpp: Ditto.
- html/HTMLVideoElement.cpp: Ditto.
- html/HTMLViewSourceDocument.cpp: Ditto.
- loader/ImageDocument.cpp: Ditto.
- page/Frame.cpp: Ditto.
- rendering/RenderTreeAsText.cpp: Ditto.
- svg/SVGAElement.cpp: Ditto.
- svg/SVGAnimateMotionElement.cpp: Ditto.
- svg/SVGAnimateTransformElement.cpp: Ditto.
- svg/SVGAnimationElement.cpp: Ditto.
- svg/SVGCircleElement.cpp: Ditto.
- svg/SVGClipPathElement.cpp: Ditto.
- svg/SVGCursorElement.cpp: Ditto.
- svg/SVGElement.cpp: Ditto.
- svg/SVGEllipseElement.cpp: Ditto.
- svg/SVGExternalResourcesRequired.cpp: Ditto.
- svg/SVGFitToViewBox.cpp: Ditto.
- svg/SVGFontFaceElement.cpp: Ditto.
- svg/SVGFontFaceUriElement.cpp: Ditto.
- svg/SVGForeignObjectElement.cpp: Ditto.
- svg/SVGGlyphElement.cpp: Ditto.
- svg/SVGGradientElement.cpp: Ditto.
- svg/SVGImageElement.cpp: Ditto.
- svg/SVGLangSpace.cpp: Ditto.
- svg/SVGLineElement.cpp: Ditto.
- svg/SVGLinearGradientElement.cpp: Ditto.
- svg/SVGMarkerElement.cpp: Ditto.
- svg/SVGMaskElement.cpp: Ditto.
- svg/SVGPathElement.cpp: Ditto.
- svg/SVGPatternElement.cpp: Ditto.
- svg/SVGPolyElement.cpp: Ditto.
- svg/SVGRadialGradientElement.cpp: Ditto.
- svg/SVGRectElement.cpp: Ditto.
- svg/SVGSVGElement.cpp: Ditto.
- svg/SVGScriptElement.cpp: Ditto.
- svg/SVGStopElement.cpp: Ditto.
- svg/SVGStyleElement.cpp: Ditto.
- svg/SVGStyledElement.cpp: Ditto.
- svg/SVGStyledTransformableElement.cpp: Ditto.
- svg/SVGTests.cpp: Ditto.
- svg/SVGTextContentElement.cpp: Ditto.
- svg/SVGTextElement.cpp: Ditto.
- svg/SVGTextPathElement.cpp: Ditto.
- svg/SVGTextPositioningElement.cpp: Ditto.
- svg/SVGURIReference.cpp: Ditto.
- svg/SVGUseElement.cpp: Ditto.
- svg/SVGViewElement.cpp: Ditto.
- svg/animation/SVGSMILElement.cpp: Ditto.
- xml/XPathStep.cpp: Ditto.
WebKit/mac:
2009-05-04 Darin Adler <Darin Adler>
Reviewed by Eric Seidel.
Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
and NamedMappedAttrMap.h include of MappedAttribute.h
https://bugs.webkit.org/show_bug.cgi?id=24924
- WebView/WebFrame.mm: Added include of CSSMutableStyleDeclaration.h and ScriptValue.h.
- 10:57 AM Changeset in webkit [43186] by
-
- 8 edits7 adds in trunk
Initial DRT implementation for wx.
- 10:50 AM Changeset in webkit [43185] by
-
- 2 edits in trunk/WebCore
2009-05-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods.
https://bugs.webkit.org/show_bug.cgi?id=25520
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 10:02 AM Changeset in webkit [43184] by
-
- 3 edits in trunk/LayoutTests
2009-05-04 Darin Adler <Darin Adler>
Reviewed by Adam Roben.
- media/video-size-intrinsic-scale-expected.txt: Changed to match test.
- media/video-size-intrinsic-scale.html: Removed doubled "Movie" word.
- 9:20 AM Changeset in webkit [43183] by
-
- 2 edits in trunk/WebCore
2009-05-04 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6839881> With "Mail Contents of This Page" in Safari images don't appear in the Tiger Mail compose window
DocumentLoader::subresource() is the implementation for the WebKit API [WebDataSource subresourceForURL:] and has
particularly sticky behavior.
If the DocumentLoader represents a WebArchive, this method should return ArchiveResources from that archive. However, we
prefer CachedResources over ArchiveResources because they might represent fresher data than what was originally loaded
from the WebArchive.
In some instances, CachedResources are created and associated with the DocumentLoader but not immediately run through the
loading delegate machinery. This was always a possibility, but the Preload Scanner made this significantly more likely.
When this happens and someone asks the WebDataSource for a subresource, it would prefer the CachedResource over an
ArchiveResource it has even if the CachedResource hasn't been loaded yet. The CachedResource has nil data, so no
WebResource is returned, and the client thinks the subresource doesn't exist even though it does.
This broke Tiger Mail and probably various other WebKit applications but has a fairly straightforward fix.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): If there is a CachedResource but it hasn't been loaded yet, fallback to the ArchiveResource.
- 8:56 AM Changeset in webkit [43182] by
-
- 6 edits1 add in trunk
2009-05-04 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25545
Bug 25545: HTMLMediaElement: display anamorphic video correctly
Tell QuickTime to use clean aperture mode so movies with non-square pixels are sized
and displayed correctly.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Ask QuickTime to use clean aperture mode.
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::load): Ditto. Add ASSERT to ensure that static movie property array isn't filled beyond capacity.
2009-05-04 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25545
Bug 25545: HTMLMediaElement: display anamorphic video correctly
Added 720x576i PAL anamorphic movie, extended video-size-intrinsic-scale
test to check that it is sized correctly.
- media/content/720x576i-anamorphic.mov: Added.
- media/video-size-intrinsic-scale-expected.txt:
- media/video-size-intrinsic-scale.html:
- 8:38 AM Changeset in webkit [43181] by
-
- 2 edits in trunk/WebCore
Fix <https://bugs.webkit.org/show_bug.cgi?id=25332>.
Bug 25332: Plug-in inserted in to DOM of PluginDocument fails to load
Reviewed by Darin Adler.
Only the first plug-in in a PluginDocument can use the main resource data. For all
subsequent plug-ins, such as the plug-in that ClickToFlash inserts when swapping itself
out for the real Flash plug-in, we need to load the resource data in the same manner
as for other embedded plug-ins.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadPlugin):
- 8:25 AM Changeset in webkit [43180] by
-
- 2 edits in trunk/WebCore
2009-05-04 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Ariya Hidayat.
Update the qrc file for the Web Inspector in the Qt build
with missing files.
- 12:17 AM Changeset in webkit [43179] by
-
- 7 edits in trunk/WebCore
Reviewed by George Staikos.
Move absoluteRects and absoluteQuads into RenderSVGInline and remove absoluteTransform() usage
https://bugs.webkit.org/show_bug.cgi?id=25532
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::absoluteRects): (WebCore::RenderSVGInline::absoluteQuads):
- rendering/RenderSVGInline.h:
- rendering/RenderSVGTSpan.cpp:
- rendering/RenderSVGTSpan.h:
- rendering/RenderSVGTextPath.cpp:
- rendering/RenderSVGTextPath.h:
- 12:17 AM Changeset in webkit [43178] by
-
- 2 edits in trunk/WebCore
Reviewed by George Staikos.
Move RenderSVGText off of localToAbsolute()
https://bugs.webkit.org/show_bug.cgi?id=25532
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads):
- 12:16 AM Changeset in webkit [43177] by
-
- 11 edits in trunk
Reviewed by George Staikos.
Remove broken absoluteTransform() code from RenderSVGInlineText
https://bugs.webkit.org/show_bug.cgi?id=25532
This improved SVG text focus rings.
This also improved SVG.getScreenCTM() results.
SVGSVGElement::getScreenCTM was passing "true" for the second argument in
localToAbsolute, which is "fixed" it meant to pass "true" for the
third argument (useTransforms). That change alone caused no layout test changes, however
before I fixed this, it was hitting ASSERT(!fixed) in RenderSVGRoot::mapLocalToContainer
mapLocalToContainer implementations really should be shared,
but I'll do that in a later patch.
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::styleDidChange): (WebCore::RenderSVGInlineText::absoluteQuads): (WebCore::RenderSVGInlineText::computeRepaintRectForRange): (WebCore::RenderSVGInlineText::computeRepaintQuadForRange):
- rendering/RenderSVGInlineText.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer):
- rendering/RenderSVGText.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM):
- 12:15 AM Changeset in webkit [43176] by
-
- 3 edits in trunk/WebCore
Reviewed by George Staikos.
Remove dead code from RenderPath
https://bugs.webkit.org/show_bug.cgi?id=25532
- rendering/RenderPath.cpp:
- rendering/RenderPath.h:
- 12:15 AM Changeset in webkit [43175] by
-
- 5 edits in trunk/WebCore
Reviewed by George Staikos.
Share layout code between RenderSVGViewportContainer and RenderSVGContainer
https://bugs.webkit.org/show_bug.cgi?id=25532
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::calcViewport):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip):
- rendering/RenderSVGViewportContainer.h:
- 12:15 AM Changeset in webkit [43174] by
-
- 4 edits in trunk/WebCore
Reviewed by George Staikos.
Remove redundant disableLayoutState() calls
https://bugs.webkit.org/show_bug.cgi?id=25532
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout):
- 12:14 AM Changeset in webkit [43173] by
-
- 2 edits4 adds in trunk
Reviewed by George Staikos.
Simplify RenderForeignObject::paint and fix a repaint bug.
Paint now calls applyTransformToPaintInfo which correctly transforms the damage rect.
https://bugs.webkit.org/show_bug.cgi?id=16939
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
May 3, 2009:
- 11:46 PM Changeset in webkit [43172] by
-
- 2 edits in tags/Safari-6530.8.2/JavaScriptCore
Merged r43169.
- 11:39 PM Changeset in webkit [43171] by
-
- 1 edit2 adds in trunk/LayoutTests
No review, just adding missing results.
Add Win results for editing/spelling/spellcheck-attribute
Pixel results are still missing, but I have no easy way
to add them, and the bots aren't generating them currently.
- platform/win/editing/spelling/spellcheck-attribute-expected.txt: Added.
- 11:37 PM Changeset in webkit [43170] by
-
- 1 copy in tags/Safari-6530.8.2
New tag.
- 11:36 PM Changeset in webkit [43169] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
- 11:05 PM Changeset in webkit [43168] by
-
- 4 edits4 adds in trunk
2009-05-03 Hironori Bono <hbono@chromium.org>
Reviewed by Eric Seidel.
Test: editing/spelling/spellcheck-attribute.html
Bug 14552: Add a way to disable spell checking for specific element
https://bugs.webkit.org/show_bug.cgi?id=14552
For compatibility with Firefox, this code ascends the DOM tree when an element does
not have its "spellcheck" attribute.
- editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): Retrieve the value of the "spellcheck" attribute of an element before calling a spell checker or a grammar checker.
- html/HTMLAttributeNames.in: Add a "spellcheck" attribute.
- 7:00 PM Changeset in webkit [43167] by
-
- 2 edits in trunk/LayoutTests
2009-05-03 Gustavo Noronha Silva <Gustavo Noronha Silva>
Three more failing tests caused by the disabling of the others.
- platform/gtk/Skipped:
- 6:38 PM Changeset in webkit [43166] by
-
- 2 edits in trunk/LayoutTests
2009-05-03 Gustavo Noronha Silva <Gustavo Noronha Silva>
Disable more tests that fail on the bot, and those which fail when
we disable some. Hopefully this finishes our massage to the
skipped list and we can go back to working on fixing tests now.
- platform/gtk/Skipped:
- 5:42 PM Changeset in webkit [43165] by
-
- 4 edits in trunk/JavaScriptCore
Fix the 64-bit build.
- API/APICast.h:
(toJS):
(toRef):
- runtime/JSNumberCell.cpp:
(JSC::jsAPIMangledNumber):
- runtime/JSNumberCell.h:
- 4:25 PM Changeset in webkit [43164] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Sam Weinig.
Dump more metrics from svgsvgelement-ctm test.
(And break up the first SVG into two SVGs for easier reading of the metrics)
- svg/custom/svgsvgelement-ctm-expected.txt:
- svg/custom/svgsvgelement-ctm.xhtml:
- 2:57 PM QtWebKitJournal edited by
- (diff)
- 2:54 PM QtWebKitTodo edited by
- (diff)
- 2:44 PM Changeset in webkit [43163] by
-
- 2 edits in trunk/LayoutTests
2009-05-03 Gustavo Noronha Silva <Gustavo Noronha Silva>
Some tests are still failing on the bot, despite working
locally. Disabling for now.
- platform/gtk/Skipped:
- 2:41 PM Changeset in webkit [43162] by
-
- 1 copy in branches/nitro-extreme
New branch
- 2:32 PM Changeset in webkit [43161] by
-
- 2 edits in trunk/LayoutTests
2009-05-03 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Enable more tests that succeed and style up the list a bit.
- platform/gtk/Skipped:
- 2:02 PM Changeset in webkit [43160] by
-
- 18 edits in trunk
2009-05-02 Sam Weinig <sam@webkit.org>
Roll JSC API number marshaling back in one last time (I hope).
WebCore:
2009-05-03 Sam Weinig <sam@webkit.org>
Roll JSC API number marshaling back in one last time (I hope).
- 1:59 PM Changeset in webkit [43159] by
-
- 2 edits in trunk/WebKitTools
2009-05-03 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Don't pass an exception parameter if we don't care about the value.
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
- 12:56 PM Changeset in webkit [43158] by
-
- 18 edits in trunk
2009-05-03 Sam Weinig <sam@webkit.org>
Roll JSC API number marshaling back out. It still breaks windows.
WebCore:
2009-05-03 Sam Weinig <sam@webkit.org>
Roll JSC API number marshaling back out. It still breaks windows.
- 12:27 PM Changeset in webkit [43157] by
-
- 18 edits in trunk
2009-05-02 Sam Weinig <sam@webkit.org>
Roll JSC API number marshaling back in.
WebCore:
2009-05-02 Sam Weinig <sam@webkit.org>
Roll JSC API number marshaling back in.
- 9:49 AM Changeset in webkit [43156] by
-
- 9 edits in trunk/JavaScriptCore
2009-05-02 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
Bug 25519: streamline lexer by handling BOMs differently
https://bugs.webkit.org/show_bug.cgi?id=25519
Roughly 1% faster SunSpider.
- parser/Grammar.y: Tweak formatting a bit.
- parser/Lexer.cpp: (JSC::Lexer::Lexer): Remove unnnecessary initialization of data members that are set up by setCode. (JSC::Lexer::currentOffset): Added. Used where the old code would look at m_currentOffset. (JSC::Lexer::shift1): Replaces the old shift function. No longer does anything to handle BOM characters. (JSC::Lexer::shift2): Ditto. (JSC::Lexer::shift3): Ditto. (JSC::Lexer::shift4): Ditto. (JSC::Lexer::setCode): Updated for name change from yylineno to m_line. Removed now-unused m_eatNextIdentifier, m_stackToken, and m_restrKeyword. Replaced m_skipLF and m_skipCR with m_skipLineEnd. Replaced the old m_length with m_codeEnd and m_currentOffset with m_codeStart. Added code to scan for a BOM character and call copyCodeWithoutBOMs() if we find any. (JSC::Lexer::copyCodeWithoutBOMs): Added. (JSC::Lexer::nextLine): Updated for name change from yylineno to m_line. (JSC::Lexer::makeIdentifier): Moved up higher in the file. (JSC::Lexer::matchPunctuator): Moved up higher in the file and changed to use a switch statement instead of just if statements. (JSC::Lexer::isLineTerminator): Moved up higher in the file and changed to have fewer branches. (JSC::Lexer::lastTokenWasRestrKeyword): Added. This replaces the old m_restrKeyword boolean. (JSC::Lexer::isIdentStart): Moved up higher in the file. Changed to use fewer branches in the ASCII but not identifier case. (JSC::Lexer::isIdentPart): Ditto. (JSC::Lexer::singleEscape): Moved up higher in the file. (JSC::Lexer::convertOctal): Moved up higher in the file. (JSC::Lexer::convertHex): Moved up higher in the file. Changed to use toASCIIHexValue instead of rolling our own here. (JSC::Lexer::convertUnicode): Ditto. (JSC::Lexer::record8): Moved up higher in the file. (JSC::Lexer::record16): Moved up higher in the file. (JSC::Lexer::lex): Changed type of stringType to int. Replaced m_skipLF and m_skipCR with m_skipLineEnd, which requires fewer branches in the main lexer loop. Use currentOffset instead of m_currentOffset. Removed unneeded m_stackToken. Use isASCIIDigit instead of isDecimalDigit. Split out the two cases for InIdentifierOrKeyword and InIdentifier. Added special case tight loops for identifiers and other simple states. Removed a branch from the code that sets m_atLineStart to false using goto. Streamlined the number-handling code so we don't check for the same types twice for non-numeric cases and don't add a null to m_buffer8 when it's not being used. Removed m_eatNextIdentifier, which wasn't working anyway, and m_restrKeyword, which is redundant with m_lastToken. Set the m_delimited flag without using a branch. (JSC::Lexer::scanRegExp): Tweaked style a bit. (JSC::Lexer::clear): Clear m_codeWithoutBOMs so we don't use memory after parsing. Clear out UString objects in the more conventional way. (JSC::Lexer::sourceCode): Made this no-longer inline since it has more work to do in the case where we stripped BOMs.
- parser/Lexer.h: Renamed yylineno to m_lineNumber. Removed convertHex function, which is the same as toASCIIHexValue. Removed isHexDigit function, which is the same as isASCIIHedDigit. Replaced shift with four separate shift functions. Removed isWhiteSpace function that passes m_current, instead just passing m_current explicitly. Removed isOctalDigit, which is the same as isASCIIOctalDigit. Eliminated unused arguments from matchPunctuator. Added copyCoodeWithoutBOMs and currentOffset. Moved the makeIdentifier function out of the header. Added lastTokenWasRestrKeyword function. Added new constants for m_skipLineEnd. Removed unused yycolumn, m_restrKeyword, m_skipLF, m_skipCR, m_eatNextIdentifier, m_stackToken, m_position, m_length, m_currentOffset, m_nextOffset1, m_nextOffset2, m_nextOffset3. Added m_skipLineEnd, m_codeStart, m_codeEnd, and m_codeWithoutBOMs.
- parser/SourceProvider.h: Added hasBOMs function. In the future this can be used to tell the lexer about strings known not to have BOMs.
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncUnescape): Changed to use isASCIIHexDigit.
- wtf/ASCIICType.h: Added using statements to match the design of the other WTF headers.
May 2, 2009:
- 9:17 PM Changeset in webkit [43155] by
-
- 2 edits in trunk/JavaScriptCore
Fix windows build (when doing a clean build)
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 9:09 PM Changeset in webkit [43154] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- another fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
Test: editing/deleting/type-delete-after-quote-2.html
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize m_startsAtEmptyLine. (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): When the selection starts at an empty line, do not prevent the merging of blocks. This is what allows the text after the line break to be merged into the block containing the line break. Also set m_startsAtEmptyLine to true. (WebCore::DeleteSelectionCommand::mergeParagraphs): If m_startsAtEmptyLine is true, create a placeholder BR to serve as the merge destination.
- editing/DeleteSelectionCommand.h:
LayoutTests:
Reviewed by Darin Adler.
- another test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
- editing/deleting/type-delete-after-quote-2-expected.txt: Added.
- editing/deleting/type-delete-after-quote-2.html: Added.
- 6:58 PM Changeset in webkit [43153] by
-
- 44 edits in trunk
2009-05-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Simplified null-ish JSValues.
Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().
Replaced almost all uses of jsImpossibleValue() with uses of JSValue().
Its one remaining use is for construction of hash table deleted values.
For that specific task, I made a new, private constructor with a special
tag. Removed jsImpossibleValue().
Removed "JSValue()" initialiazers, since default construction happens...
by default.
- API/JSCallbackObjectFunctions.h: (JSC::::call):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
- bytecompiler/BytecodeGenerator.h:
- debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
- debugger/DebuggerCallFrame.h: (JSC::DebuggerCallFrame::DebuggerCallFrame):
- interpreter/CallFrame.h: (JSC::ExecState::clearException):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveLastCaller):
- interpreter/Register.h: (JSC::Register::Register):
- jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_vm_throw):
- profiler/Profiler.cpp: (JSC::Profiler::willExecute): (JSC::Profiler::didExecute):
- runtime/ArrayPrototype.cpp: (JSC::getProperty):
- runtime/Completion.cpp: (JSC::evaluate):
- runtime/Completion.h: (JSC::Completion::Completion):
- runtime/GetterSetter.cpp: (JSC::GetterSetter::getPrimitiveNumber):
- runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::sort): (JSC::JSArray::compactForSorting):
- runtime/JSCell.cpp: (JSC::JSCell::getJSNumber):
- runtime/JSCell.h: (JSC::JSValue::getJSNumber):
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- runtime/JSImmediate.h: (JSC::JSImmediate::fromNumberOutsideIntegerRange): (JSC::JSImmediate::from):
- runtime/JSNumberCell.cpp: (JSC::jsNumberCell):
- runtime/JSObject.cpp: (JSC::callDefaultValueFunction):
- runtime/JSObject.h: (JSC::JSObject::getDirect):
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::toPrimitive):
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next):
- runtime/JSValue.h: (JSC::JSValue::): (JSC::JSValueHashTraits::constructDeletedValue): (JSC::JSValueHashTraits::isDeletedValue): (JSC::JSValue::JSValue):
- runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject):
- runtime/Operations.h: (JSC::resolveBase):
- runtime/PropertySlot.h: (JSC::PropertySlot::clearBase): (JSC::PropertySlot::clearValue):
WebCore:
2009-05-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Simplified null-ish JSValues.
Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().
Removed "JSValue()" initialiazers, since default construction happens...
by default.
- bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
- bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::hasNoValue):
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
- bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
- bridge/jni/jni_runtime.cpp: (JavaField::dispatchValueFromInstance): (JavaField::dispatchSetValueToInstance):
- bridge/runtime.h: (JSC::Bindings::Instance::invokeConstruct):
WebKit/mac:
2009-05-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Simplified null-ish JSValues.
Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().
Removed "JSValue()" initialiazers, since default construction happens...
by default.
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]):
- 4:43 PM Changeset in webkit [43152] by
-
- 5 edits in trunk/WebCore
2009-05-02 Antti Koivisto <Antti Koivisto>
Reviewed by Dan Bernstein.
<rdar://problem/6631735> Crash in WebCore::CSSStyleSelector::applyProperty(int, WebCore::CSSValue*) (RenderStyle.h:454)
Avoid re-entering style selector from load delegates by not issuing resource loads synchronously during attach().
- dom/ContainerNode.cpp: (WebCore::ContainerNode::suspendPostAttachCallbacks): (WebCore::ContainerNode::resumePostAttachCallbacks): (WebCore::ContainerNode::attach):
- dom/Element.cpp: (WebCore::Element::attach):
- loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::servePendingRequests): (WebCore::Loader::suspendPendingRequests): (WebCore::Loader::resumePendingRequests): (WebCore::Loader::Host::servePendingRequests):
- loader/loader.h: (WebCore::Loader::isSuspendingPendingRequests):
- 2:59 PM Changeset in webkit [43151] by
-
- 2 edits in trunk/WebKitTools
2009-05-02 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Another cut at getting tests passing on Windows again.
- DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didStartProvisionalLoadForFrame): Tweak formatting. (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto. (FrameLoadDelegate::didCommitLoadForFrame): Ditto. (FrameLoadDelegate::didFinishLoadForFrame): Ditto. (FrameLoadDelegate::didFailLoadWithError): Added missing logging.
- 2:38 PM Changeset in webkit [43150] by
-
- 2 edits in trunk/WebKitTools
2009-05-02 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Try to get tests passing on Windows again.
- DumpRenderTree/win/DumpRenderTree.cpp: (shouldLogFrameLoadDelegates): Allow either "/" or "\" as a path separator. Also require separator before as well as after path name.
- 2:14 PM Changeset in webkit [43149] by
-
- 3 edits2 copies1 add in trunk
WebCore:
2009-05-02 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 25352: REGRESSION(r42322): style isn't applied at bmwusa.com
https://bugs.webkit.org/show_bug.cgi?id=25352
rdar://problem/6823239
Test: http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html
- platform/network/HTTPParsers.cpp: (WebCore::extractMIMETypeFromMediaType): Allow comma as a separator.
LayoutTests:
2009-05-02 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 25352: REGRESSION(r42322): style isn't applied at bmwusa.com
https://bugs.webkit.org/show_bug.cgi?id=25352
rdar://problem/6823239
- http/tests/mime/resources/style-with-text-css-and-invalid-type.php: Copied from LayoutTests/http/tests/mime/resources/style-with-charset.php and adapted.
- http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type-expected.txt: Added.
- http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html: Copied from LayoutTests/http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type.html and adapted.
- 12:58 PM Changeset in webkit [43148] by
-
- 8 edits3 adds in trunk
WebCore:
2009-05-02 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
Bug 25491: WebFrame leak when a subframe removes itself
https://bugs.webkit.org/show_bug.cgi?id=25491
rdar://problem/6833859
Test: fast/loading/subframe-removes-itself.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): When isStopping is true, treat load as complete, even if isLoadingInAPISense is still returning true.
LayoutTests:
2009-05-02 Darin Adler <Darin Adler>
Reviewed by Brady Eidson (except for the non-fast/loading test fixes).
Bug 25491: WebFrame leak when a subframe removes itself
https://bugs.webkit.org/show_bug.cgi?id=25491
rdar://problem/6833859
- fast/loading: Added.
- fast/loading/resources: Added.
- fast/loading/resources/subframe-that-removes-itself.html: Added.
- fast/loading/subframe-removes-itself-expected.txt: Added.
- fast/loading/subframe-removes-itself.html: Added.
- fast/frames/location-put-after-removal-expected.txt: Updated. For some reason, fixing the loader sequence results in output that has one more blank line.
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html: Updated tests so they don't terminate when the partial load of the subframe completes, but rather wait until the subsequent load of about:blank occurs.
- platform/gtk/Skipped: Skip loading tests.
- 12:50 PM Changeset in webkit [43147] by
-
- 2 edits in trunk/LayoutTests
2009-05-02 Gustavo Noronha Silva <Gustavo Noronha Silva>
Skip test that sometimes fails in GTK+.
- platform/gtk/Skipped:
- 12:39 PM Changeset in webkit [43146] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-02 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25466
WebKitGtk+ 1.1.6 prints weird error messages in Liferea
Use strlen instead of g_utf8_strlen when calculating the size of
the data that is being given to webkit_web_frame_load_string to be
loaded, so that we don't miss any of the content.
- webkit/webkitwebframe.cpp:
- 5:47 AM Changeset in webkit [43145] by
-
- 2 edits in trunk/LayoutTests
2009-05-02 Gustavo Noronha Silva <Gustavo Noronha Silva>
Skip new test that does not represent a regression.
- platform/gtk/Skipped:
- 4:33 AM Changeset in webkit [43144] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-02 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- speed up the lexer in various ways
~2% command-line SunSpider speedup
- parser/Lexer.cpp: (JSC::Lexer::setCode): Moved below shift() so it can inline. (JSC::Lexer::scanRegExp): Use resize(0) instead of clear() on Vectors, since the intent here is not to free the underlying buffer. (JSC::Lexer::lex): ditto; also, change the loop logic a bit for the main lexing loop to avoid branching on !m_done twice per iteration. Now we only check it once. (JSC::Lexer::shift): Make this ALWAYS_INLINE and tag an unusual branch as UNLIKELY
- parser/Lexer.h: (JSC::Lexer::makeIdentifier): force to be ALWAYS_INLINE
- wtf/Vector.h: (WTF::::append): force to be ALWAYS_INLINE (may have helped in ways other than parsing but it wasn't getting inlined in a hot code path in the lexer)
- 2:06 AM Changeset in webkit [43143] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Dan Bernstein.
<rdar://problem/6741615> REGRESSION (r38629): Shortcut "Flag/Junk" in MobileMe does not work
when Kotoeri is used.
- WebView/WebHTMLView.mm: (-[WebHTMLView inputContext]): Return a nil input context when focus is not in editable content.
- 12:00 AM Changeset in webkit [43142] by
-
- 2 edits in tags/Safari-6530.8.1/JavaScriptCore
Merged r43140.
May 1, 2009:
- 11:52 PM Changeset in webkit [43141] by
-
- 1 copy in tags/Safari-6530.8.1
New tag.
- 11:45 PM Changeset in webkit [43140] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore.make:
- 10:56 PM Changeset in webkit [43139] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-01 Sam Weinig <sam@webkit.org>
Fix 64bit build.
- runtime/JSNumberCell.h: (JSC::JSValue::JSValue):
- runtime/JSValue.h: (JSC::jsNumber):
- 9:52 PM Changeset in webkit [43138] by
-
- 18 edits in trunk
2009-05-01 Sam Weinig <sam@webkit.org>
Roll out JavaScriptCore API number marshaling.
- API/APICast.h: (toJS): (toRef):
- API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax):
- API/JSCallbackConstructor.cpp: (JSC::constructJSCallback):
- API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
- API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot): (JSC::::put): (JSC::::deleteProperty): (JSC::::construct): (JSC::::hasInstance): (JSC::::call): (JSC::::toNumber): (JSC::::toString): (JSC::::staticValueGetter): (JSC::::callbackGetter):
- API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeArray): (JSObjectMakeDate): (JSObjectMakeError): (JSObjectMakeRegExp): (JSObjectGetPrototype): (JSObjectSetPrototype): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex): (JSObjectDeleteProperty): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
- API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueIsEqual): (JSValueIsStrictEqual): (JSValueIsInstanceOfConstructor): (JSValueMakeUndefined): (JSValueMakeNull): (JSValueMakeBoolean): (JSValueMakeNumber): (JSValueMakeString): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject): (JSValueProtect): (JSValueUnprotect):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- runtime/JSNumberCell.cpp:
- runtime/JSNumberCell.h:
- runtime/JSValue.h:
WebCore:
2009-05-01 Sam Weinig <sam@webkit.org>
Roll out JavaScriptCore API number marshaling.
- bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isEqual):
- inspector/JavaScriptProfile.cpp: (WebCore::getHeadCallback):
- inspector/JavaScriptProfileNode.cpp: (WebCore::getChildren): (WebCore::getParent): (WebCore::getHead):
- 8:12 PM Changeset in webkit [43137] by
-
- 2 edits in trunk/WebCore
2009-05-01 Sam Weinig <sam@webkit.org>
Fix build.
- workers/WorkerContext.idl:
- 7:33 PM Changeset in webkit [43136] by
-
- 6 edits in trunk/WebCore
2009-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Cleanup workers code a bit.
- bindings/js/JSWorkerContextBase.cpp: (WebCore::toJS):
- bindings/js/JSWorkerContextBase.h:
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::customGetOwnPropertySlot):
- workers/WorkerContext.h: (WebCore::WorkerContext::toWorkerContext): (WebCore::WorkerContext::self): (WebCore::WorkerContext::setOnmessage): (WebCore::WorkerContext::onmessage):
- workers/WorkerContext.idl:
- 7:31 PM Changeset in webkit [43135] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-01 Sam Weinig <sam@webkit.org>
Fix windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 7:19 PM Changeset in webkit [43134] by
-
- 2 edits in trunk/WebCore
2009-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
A little clean up.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createJavaAppletWidget):
- 7:17 PM Changeset in webkit [43133] by
-
- 4 edits in trunk/WebCore
2009-05-01 Sam Weinig <sam@webkit.org>
Fix the build.
- bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isEqual):
- inspector/JavaScriptProfile.cpp: (WebCore::getHeadCallback):
- inspector/JavaScriptProfileNode.cpp: (WebCore::getChildren): (WebCore::getParent): (WebCore::getHead):
- 7:16 PM Changeset in webkit [43132] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-01 Sam Weinig <sam@webkit.org>
Fix the build.
- JavaScriptCore.exp:
- 5:48 PM Changeset in webkit [43131] by
-
- 4 edits in trunk/JavaScriptCore
2009-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey "Too Far!" Garen.
Move JS number construction into JSValue.
- runtime/JSImmediate.h:
- runtime/JSNumberCell.h: (JSC::JSValue::JSValue):
- runtime/JSValue.h: (JSC::jsNumber):
- 5:25 PM Changeset in webkit [43130] by
-
- 11 edits in trunk/JavaScriptCore
2009-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Geoff "The Minneapolis" Garen.
Add mechanism to vend heap allocated JS numbers to JavaScriptCore API clients with a
representation that is independent of the number representation in the VM.
- Numbers leaving the interpreter are converted to a tagged JSNumberCell.
- The numbers coming into the interpreter (asserted to be the tagged JSNumberCell) are converted back to the VM's internal number representation.
- API/APICast.h: (toJS): (toRef):
- API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax):
- API/JSCallbackConstructor.cpp: (JSC::constructJSCallback):
- API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
- API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot): (JSC::::put): (JSC::::deleteProperty): (JSC::::construct): (JSC::::hasInstance): (JSC::::call): (JSC::::toNumber): (JSC::::toString): (JSC::::staticValueGetter): (JSC::::callbackGetter):
- API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeArray): (JSObjectMakeDate): (JSObjectMakeError): (JSObjectMakeRegExp): (JSObjectGetPrototype): (JSObjectSetPrototype): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex): (JSObjectDeleteProperty): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
- API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueIsEqual): (JSValueIsStrictEqual): (JSValueIsInstanceOfConstructor): (JSValueMakeUndefined): (JSValueMakeNull): (JSValueMakeBoolean): (JSValueMakeNumber): (JSValueMakeString): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject): (JSValueProtect): (JSValueUnprotect):
- runtime/JSNumberCell.cpp: (JSC::jsAPIMangledNumber):
- runtime/JSNumberCell.h: (JSC::JSNumberCell::isAPIMangledNumber): (JSC::JSNumberCell::): (JSC::JSNumberCell::JSNumberCell): (JSC::JSValue::isAPIMangledNumber):
- runtime/JSValue.h:
- 5:12 PM Changeset in webkit [43129] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Windows build fix take 6.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 5:07 PM Changeset in webkit [43128] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Windows build fix take 5.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 4:59 PM Changeset in webkit [43127] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Windows build fix take 4.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 4:57 PM Changeset in webkit [43126] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Windows build fix take 3.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 4:55 PM Changeset in webkit [43125] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Windows build fix take 2.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 4:42 PM Changeset in webkit [43124] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Windows build fix take 1.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 4:03 PM Changeset in webkit [43123] by
-
- 2 edits in trunk/WebCore
2009-05-01 Brady Eidson <beidson@apple.com>
Reviewed by Oliver Hunt and Sam "Jon 'The Belly' Honeycutt" Weinig
Fix <rdar://problem/6848867> Addition of DOCTYPE node breaks Tiger Mail
- bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument firstChild]): Add a Tiger Mail version of this method that skips DOCTYPE nodes.
- 3:43 PM Changeset in webkit [43122] by
-
- 325 edits in trunk
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Rubber Stamped by Sam Weinig.
Renamed JSValuePtr => JSValue.
- API/APICast.h: (toJS): (toRef):
- API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
- API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
- API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
- API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
- API/JSCallbackObjectFunctions.h: (JSC::::asCallbackObject): (JSC::::put): (JSC::::hasInstance): (JSC::::call): (JSC::::staticValueGetter): (JSC::::staticFunctionGetter): (JSC::::callbackGetter):
- API/JSContextRef.cpp:
- API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrototype): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex):
- API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueIsEqual): (JSValueIsStrictEqual): (JSValueIsInstanceOfConstructor): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject): (JSValueProtect): (JSValueUnprotect):
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp: (JSC::valueToSourceString): (JSC::constantName): (JSC::CodeBlock::dump):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getConstant): (JSC::CodeBlock::addUnexpectedConstant): (JSC::CodeBlock::unexpectedConstant):
- bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::get):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addConstant): (JSC::BytecodeGenerator::addUnexpectedConstant): (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitGetScopedVar): (JSC::BytecodeGenerator::emitPutScopedVar): (JSC::BytecodeGenerator::emitNewError): (JSC::keyForImmediateSwitch):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue): (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
- debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
- debugger/Debugger.h:
- debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::put): (JSC::DebuggerActivation::putWithAttributes): (JSC::DebuggerActivation::lookupGetter): (JSC::DebuggerActivation::lookupSetter):
- debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
- debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
- debugger/DebuggerCallFrame.h: (JSC::DebuggerCallFrame::DebuggerCallFrame): (JSC::DebuggerCallFrame::exception):
- interpreter/CachedCall.h: (JSC::CachedCall::CachedCall): (JSC::CachedCall::call): (JSC::CachedCall::setThis): (JSC::CachedCall::setArgument):
- interpreter/CallFrame.cpp: (JSC::CallFrame::thisValue): (JSC::CallFrame::dumpCaller):
- interpreter/CallFrame.h: (JSC::ExecState::setException): (JSC::ExecState::exception): (JSC::ExecState::exceptionSlot):
- interpreter/CallFrameClosure.h: (JSC::CallFrameClosure::setArgument):
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::isNotObject): (JSC::Interpreter::callEval): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments): (JSC::Interpreter::retrieveCaller): (JSC::Interpreter::retrieveLastCaller):
- interpreter/Interpreter.h:
- interpreter/Register.h: (JSC::Register::): (JSC::Register::Register): (JSC::Register::jsValue):
- jit/JIT.cpp: (JSC::): (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_mod):
- jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
- jit/JITCode.h: (JSC::): (JSC::JITCode::execute):
- jit/JITInlineMethods.h: (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::getConstantOperand): (JSC::JIT::emitPutJITStubArgFromVirtualRegister): (JSC::JIT::emitInitRegister):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID): (JSC::JITStubs::cti_op_convert_this): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_op_loop_if_less): (JSC::JITStubs::cti_op_loop_if_lesseq): (JSC::JITStubs::cti_op_get_by_id_generic): (JSC::JITStubs::cti_op_get_by_id): (JSC::JITStubs::cti_op_get_by_id_second): (JSC::JITStubs::cti_op_get_by_id_self_fail): (JSC::JITStubs::cti_op_get_by_id_proto_list): (JSC::JITStubs::cti_op_get_by_id_proto_list_full): (JSC::JITStubs::cti_op_get_by_id_proto_fail): (JSC::JITStubs::cti_op_get_by_id_array_fail): (JSC::JITStubs::cti_op_get_by_id_string_fail): (JSC::JITStubs::cti_op_instanceof): (JSC::JITStubs::cti_op_del_by_id): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_resolve): (JSC::JITStubs::cti_op_construct_NotJSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_resolve_func): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_lesseq): (JSC::JITStubs::cti_op_loop_if_true): (JSC::JITStubs::cti_op_load_varargs): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_resolve_base): (JSC::JITStubs::cti_op_resolve_skip): (JSC::JITStubs::cti_op_resolve_global): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_jless): (JSC::JITStubs::cti_op_not): (JSC::JITStubs::cti_op_jtrue): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_resolve_with_base): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_less): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_op_throw): (JSC::JITStubs::cti_op_next_pname): (JSC::JITStubs::cti_op_typeof): (JSC::JITStubs::cti_op_is_undefined): (JSC::JITStubs::cti_op_is_boolean): (JSC::JITStubs::cti_op_is_number): (JSC::JITStubs::cti_op_is_string): (JSC::JITStubs::cti_op_is_object): (JSC::JITStubs::cti_op_is_function): (JSC::JITStubs::cti_op_stricteq): (JSC::JITStubs::cti_op_nstricteq): (JSC::JITStubs::cti_op_to_jsnumber): (JSC::JITStubs::cti_op_in): (JSC::JITStubs::cti_op_switch_imm): (JSC::JITStubs::cti_op_switch_char): (JSC::JITStubs::cti_op_switch_string): (JSC::JITStubs::cti_op_del_by_val): (JSC::JITStubs::cti_op_new_error): (JSC::JITStubs::cti_vm_throw):
- jit/JITStubs.h:
- jsc.cpp: (functionPrint): (functionDebug): (functionGC): (functionVersion): (functionRun): (functionLoad): (functionSetSamplingFlag): (functionClearSamplingFlag): (functionReadline): (functionQuit):
- parser/Nodes.cpp: (JSC::processClauseList):
- profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart):
- profiler/Profiler.cpp: (JSC::Profiler::willExecute): (JSC::Profiler::didExecute): (JSC::Profiler::createCallIdentifier):
- profiler/Profiler.h:
- runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::slowAppend):
- runtime/ArgList.h: (JSC::MarkedArgumentBuffer::at): (JSC::MarkedArgumentBuffer::append): (JSC::ArgList::ArgList): (JSC::ArgList::at):
- runtime/Arguments.cpp: (JSC::Arguments::put):
- runtime/Arguments.h: (JSC::Arguments::createStructure): (JSC::asArguments):
- runtime/ArrayConstructor.cpp: (JSC::callArrayConstructor):
- runtime/ArrayPrototype.cpp: (JSC::getProperty): (JSC::putProperty): (JSC::arrayProtoFuncToString): (JSC::arrayProtoFuncToLocaleString): (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncReverse): (JSC::arrayProtoFuncShift): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncReduce): (JSC::arrayProtoFuncReduceRight): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
- runtime/BooleanConstructor.cpp: (JSC::callBooleanConstructor): (JSC::constructBooleanFromImmediateBoolean):
- runtime/BooleanConstructor.h:
- runtime/BooleanObject.h: (JSC::asBooleanObject):
- runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncToString): (JSC::booleanProtoFuncValueOf):
- runtime/CallData.cpp: (JSC::call):
- runtime/CallData.h:
- runtime/Collector.cpp: (JSC::Heap::protect): (JSC::Heap::unprotect): (JSC::Heap::heap):
- runtime/Collector.h:
- runtime/Completion.cpp: (JSC::evaluate):
- runtime/Completion.h: (JSC::Completion::Completion): (JSC::Completion::value): (JSC::Completion::setValue):
- runtime/ConstructData.cpp: (JSC::construct):
- runtime/ConstructData.h:
- runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::callDate): (JSC::dateParse): (JSC::dateNow): (JSC::dateUTC):
- runtime/DateInstance.h: (JSC::asDateInstance):
- runtime/DatePrototype.cpp: (JSC::dateProtoFuncToString): (JSC::dateProtoFuncToUTCString): (JSC::dateProtoFuncToDateString): (JSC::dateProtoFuncToTimeString): (JSC::dateProtoFuncToLocaleString): (JSC::dateProtoFuncToLocaleDateString): (JSC::dateProtoFuncToLocaleTimeString): (JSC::dateProtoFuncGetTime): (JSC::dateProtoFuncGetFullYear): (JSC::dateProtoFuncGetUTCFullYear): (JSC::dateProtoFuncToGMTString): (JSC::dateProtoFuncGetMonth): (JSC::dateProtoFuncGetUTCMonth): (JSC::dateProtoFuncGetDate): (JSC::dateProtoFuncGetUTCDate): (JSC::dateProtoFuncGetDay): (JSC::dateProtoFuncGetUTCDay): (JSC::dateProtoFuncGetHours): (JSC::dateProtoFuncGetUTCHours): (JSC::dateProtoFuncGetMinutes): (JSC::dateProtoFuncGetUTCMinutes): (JSC::dateProtoFuncGetSeconds): (JSC::dateProtoFuncGetUTCSeconds): (JSC::dateProtoFuncGetMilliSeconds): (JSC::dateProtoFuncGetUTCMilliseconds): (JSC::dateProtoFuncGetTimezoneOffset): (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetMilliSeconds): (JSC::dateProtoFuncSetUTCMilliseconds): (JSC::dateProtoFuncSetSeconds): (JSC::dateProtoFuncSetUTCSeconds): (JSC::dateProtoFuncSetMinutes): (JSC::dateProtoFuncSetUTCMinutes): (JSC::dateProtoFuncSetHours): (JSC::dateProtoFuncSetUTCHours): (JSC::dateProtoFuncSetDate): (JSC::dateProtoFuncSetUTCDate): (JSC::dateProtoFuncSetMonth): (JSC::dateProtoFuncSetUTCMonth): (JSC::dateProtoFuncSetFullYear): (JSC::dateProtoFuncSetUTCFullYear): (JSC::dateProtoFuncSetYear): (JSC::dateProtoFuncGetYear):
- runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
- runtime/ErrorConstructor.cpp: (JSC::callErrorConstructor):
- runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString):
- runtime/ExceptionHelpers.cpp: (JSC::createInterruptedExecutionException): (JSC::createError): (JSC::createStackOverflowError): (JSC::createUndefinedVariableError): (JSC::createErrorMessage): (JSC::createInvalidParamError): (JSC::createNotAConstructorError): (JSC::createNotAFunctionError):
- runtime/ExceptionHelpers.h:
- runtime/FunctionConstructor.cpp: (JSC::callFunctionConstructor):
- runtime/FunctionPrototype.cpp: (JSC::callFunctionPrototype): (JSC::functionProtoFuncToString): (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
- runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
- runtime/GetterSetter.cpp: (JSC::GetterSetter::toPrimitive): (JSC::GetterSetter::getPrimitiveNumber):
- runtime/GetterSetter.h: (JSC::asGetterSetter):
- runtime/InternalFunction.cpp: (JSC::InternalFunction::displayName):
- runtime/InternalFunction.h: (JSC::InternalFunction::createStructure): (JSC::asInternalFunction):
- runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot): (JSC::JSActivation::put): (JSC::JSActivation::putWithAttributes): (JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h: (JSC::JSActivation::createStructure): (JSC::asActivation):
- runtime/JSArray.cpp: (JSC::storageSize): (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::mark): (JSC::compareNumbersForQSort): (JSC::JSArray::sortNumeric): (JSC::JSArray::sort): (JSC::JSArray::compactForSorting): (JSC::JSArray::checkConsistency): (JSC::constructArray):
- runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::createStructure): (JSC::asArray): (JSC::isJSArray):
- runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure): (JSC::JSByteArray::put):
- runtime/JSByteArray.h: (JSC::JSByteArray::getIndex): (JSC::JSByteArray::setIndex): (JSC::asByteArray): (JSC::isJSByteArray):
- runtime/JSCell.cpp: (JSC::JSCell::put): (JSC::JSCell::getJSNumber):
- runtime/JSCell.h: (JSC::asCell): (JSC::JSValue::asCell): (JSC::JSValue::isString): (JSC::JSValue::isGetterSetter): (JSC::JSValue::isObject): (JSC::JSValue::getString): (JSC::JSValue::getObject): (JSC::JSValue::getCallData): (JSC::JSValue::getConstructData): (JSC::JSValue::getUInt32): (JSC::JSValue::getTruncatedInt32): (JSC::JSValue::getTruncatedUInt32): (JSC::JSValue::mark): (JSC::JSValue::marked): (JSC::JSValue::toPrimitive): (JSC::JSValue::getPrimitiveNumber): (JSC::JSValue::toBoolean): (JSC::JSValue::toNumber): (JSC::JSValue::toString): (JSC::JSValue::toObject): (JSC::JSValue::toThisObject): (JSC::JSValue::needsThisConversion): (JSC::JSValue::toThisString): (JSC::JSValue::getJSNumber):
- runtime/JSFunction.cpp: (JSC::JSFunction::call): (JSC::JSFunction::argumentsGetter): (JSC::JSFunction::callerGetter): (JSC::JSFunction::lengthGetter): (JSC::JSFunction::getOwnPropertySlot): (JSC::JSFunction::put): (JSC::JSFunction::construct):
- runtime/JSFunction.h: (JSC::JSFunction::createStructure): (JSC::asFunction):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::put): (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::createStructure): (JSC::JSGlobalObject::GlobalPropertyInfo::GlobalPropertyInfo): (JSC::asGlobalObject): (JSC::Structure::prototypeForLookup): (JSC::Structure::prototypeChain): (JSC::Structure::isValid):
- runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::decode): (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncDecodeURI): (JSC::globalFuncDecodeURIComponent): (JSC::globalFuncEncodeURI): (JSC::globalFuncEncodeURIComponent): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
- runtime/JSGlobalObjectFunctions.h:
- runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): (JSC::JSImmediate::toObject): (JSC::JSImmediate::prototype): (JSC::JSImmediate::toString):
- runtime/JSImmediate.h: (JSC::JSImmediate::isImmediate): (JSC::JSImmediate::isNumber): (JSC::JSImmediate::isIntegerNumber): (JSC::JSImmediate::isDoubleNumber): (JSC::JSImmediate::isPositiveIntegerNumber): (JSC::JSImmediate::isBoolean): (JSC::JSImmediate::isUndefinedOrNull): (JSC::JSImmediate::isEitherImmediate): (JSC::JSImmediate::areBothImmediate): (JSC::JSImmediate::areBothImmediateIntegerNumbers): (JSC::JSImmediate::makeValue): (JSC::JSImmediate::makeInt): (JSC::JSImmediate::makeDouble): (JSC::JSImmediate::makeBool): (JSC::JSImmediate::makeUndefined): (JSC::JSImmediate::makeNull): (JSC::JSImmediate::doubleValue): (JSC::JSImmediate::intValue): (JSC::JSImmediate::uintValue): (JSC::JSImmediate::boolValue): (JSC::JSImmediate::rawValue): (JSC::JSImmediate::trueImmediate): (JSC::JSImmediate::falseImmediate): (JSC::JSImmediate::undefinedImmediate): (JSC::JSImmediate::nullImmediate): (JSC::JSImmediate::zeroImmediate): (JSC::JSImmediate::oneImmediate): (JSC::JSImmediate::impossibleValue): (JSC::JSImmediate::toBoolean): (JSC::JSImmediate::getTruncatedUInt32): (JSC::JSImmediate::fromNumberOutsideIntegerRange): (JSC::JSImmediate::from): (JSC::JSImmediate::getTruncatedInt32): (JSC::JSImmediate::toDouble): (JSC::JSImmediate::getUInt32): (JSC::JSValue::JSValue): (JSC::JSValue::isUndefinedOrNull): (JSC::JSValue::isBoolean): (JSC::JSValue::getBoolean): (JSC::JSValue::toInt32): (JSC::JSValue::toUInt32): (JSC::JSValue::isCell): (JSC::JSValue::isInt32Fast): (JSC::JSValue::getInt32Fast): (JSC::JSValue::isUInt32Fast): (JSC::JSValue::getUInt32Fast): (JSC::JSValue::makeInt32Fast): (JSC::JSValue::areBothInt32Fast): (JSC::JSFastMath::canDoFastBitwiseOperations): (JSC::JSFastMath::equal): (JSC::JSFastMath::notEqual): (JSC::JSFastMath::andImmediateNumbers): (JSC::JSFastMath::xorImmediateNumbers): (JSC::JSFastMath::orImmediateNumbers): (JSC::JSFastMath::canDoFastRshift): (JSC::JSFastMath::canDoFastUrshift): (JSC::JSFastMath::rightShiftImmediateNumbers): (JSC::JSFastMath::canDoFastAdditiveOperations): (JSC::JSFastMath::addImmediateNumbers): (JSC::JSFastMath::subImmediateNumbers): (JSC::JSFastMath::incImmediateNumber): (JSC::JSFastMath::decImmediateNumber):
- runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::toPrimitive): (JSC::JSNotAnObject::getPrimitiveNumber): (JSC::JSNotAnObject::put):
- runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
- runtime/JSNumberCell.cpp: (JSC::JSNumberCell::toPrimitive): (JSC::JSNumberCell::getPrimitiveNumber): (JSC::JSNumberCell::getJSNumber): (JSC::jsNumberCell):
- runtime/JSNumberCell.h: (JSC::JSNumberCell::createStructure): (JSC::isNumberCell): (JSC::asNumberCell): (JSC::jsNumber): (JSC::JSValue::isDoubleNumber): (JSC::JSValue::getDoubleNumber): (JSC::JSValue::isNumber): (JSC::JSValue::uncheckedGetNumber): (JSC::jsNaN): (JSC::JSValue::toJSNumber): (JSC::JSValue::getNumber): (JSC::JSValue::numberToInt32): (JSC::JSValue::numberToUInt32):
- runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::put): (JSC::JSObject::putWithAttributes): (JSC::callDefaultValueFunction): (JSC::JSObject::getPrimitiveNumber): (JSC::JSObject::defaultValue): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::lookupGetter): (JSC::JSObject::lookupSetter): (JSC::JSObject::hasInstance): (JSC::JSObject::toNumber): (JSC::JSObject::toString): (JSC::JSObject::fillGetterPropertySlot):
- runtime/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::offsetForLocation): (JSC::JSObject::locationForOffset): (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::createStructure): (JSC::asObject): (JSC::JSObject::prototype): (JSC::JSObject::setPrototype): (JSC::JSValue::isObject): (JSC::JSObject::inlineGetOwnPropertySlot): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::getPropertySlot): (JSC::JSObject::get): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::toPrimitive): (JSC::JSValue::get): (JSC::JSValue::put): (JSC::JSObject::allocatePropertyStorageInline):
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::toPrimitive): (JSC::JSPropertyNameIterator::getPrimitiveNumber):
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::next):
- runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::put): (JSC::JSStaticScopeObject::putWithAttributes):
- runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::JSStaticScopeObject): (JSC::JSStaticScopeObject::createStructure):
- runtime/JSString.cpp: (JSC::JSString::toPrimitive): (JSC::JSString::getPrimitiveNumber): (JSC::JSString::getOwnPropertySlot):
- runtime/JSString.h: (JSC::JSString::createStructure): (JSC::asString): (JSC::isJSString): (JSC::JSValue::toThisJSString):
- runtime/JSValue.cpp: (JSC::JSValue::toInteger): (JSC::JSValue::toIntegerPreserveNaN):
- runtime/JSValue.h: (JSC::JSValue::makeImmediate): (JSC::JSValue::asValue): (JSC::noValue): (JSC::jsImpossibleValue): (JSC::jsNull): (JSC::jsUndefined): (JSC::jsBoolean): (JSC::operator==): (JSC::operator!=): (JSC::JSValue::encode): (JSC::JSValue::decode): (JSC::JSValue::JSValue): (JSC::JSValue::operator bool): (JSC::JSValue::operator==): (JSC::JSValue::operator!=): (JSC::JSValue::isUndefined): (JSC::JSValue::isNull):
- runtime/JSVariableObject.h: (JSC::JSVariableObject::symbolTablePut): (JSC::JSVariableObject::symbolTablePutWithAttributes):
- runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
- runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h: (JSC::lookupPut):
- runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRandom): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
- runtime/MathObject.h: (JSC::MathObject::createStructure):
- runtime/NativeErrorConstructor.cpp: (JSC::callNativeErrorConstructor):
- runtime/NumberConstructor.cpp: (JSC::numberConstructorNaNValue): (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue): (JSC::callNumberConstructor):
- runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
- runtime/NumberObject.cpp: (JSC::NumberObject::getJSNumber): (JSC::constructNumber):
- runtime/NumberObject.h:
- runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToLocaleString): (JSC::numberProtoFuncValueOf): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
- runtime/ObjectConstructor.cpp: (JSC::constructObject): (JSC::callObjectConstructor):
- runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncValueOf): (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable): (JSC::objectProtoFuncToLocaleString): (JSC::objectProtoFuncToString):
- runtime/ObjectPrototype.h:
- runtime/Operations.cpp: (JSC::JSValue::equalSlowCase): (JSC::JSValue::strictEqualSlowCase): (JSC::throwOutOfMemoryError): (JSC::jsAddSlowCase): (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::jsIsFunctionType):
- runtime/Operations.h: (JSC::JSValue::equal): (JSC::JSValue::equalSlowCaseInline): (JSC::JSValue::strictEqual): (JSC::JSValue::strictEqualSlowCaseInline): (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAdd): (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::resolveBase):
- runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
- runtime/PropertySlot.h: (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::getValue): (JSC::PropertySlot::putValue): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setCustom): (JSC::PropertySlot::setCustomIndex): (JSC::PropertySlot::slotBase): (JSC::PropertySlot::setBase): (JSC::PropertySlot::):
- runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect): (JSC::ProtectedPtr::operator JSValue): (JSC::ProtectedJSValue::ProtectedJSValue): (JSC::ProtectedJSValue::get): (JSC::ProtectedJSValue::operator JSValue): (JSC::ProtectedJSValue::operator->): (JSC::ProtectedJSValue::~ProtectedJSValue): (JSC::ProtectedJSValue::operator=): (JSC::operator==): (JSC::operator!=):
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::getBackref): (JSC::RegExpConstructor::getLastParen): (JSC::RegExpConstructor::getLeftContext): (JSC::RegExpConstructor::getRightContext): (JSC::regExpConstructorDollar1): (JSC::regExpConstructorDollar2): (JSC::regExpConstructorDollar3): (JSC::regExpConstructorDollar4): (JSC::regExpConstructorDollar5): (JSC::regExpConstructorDollar6): (JSC::regExpConstructorDollar7): (JSC::regExpConstructorDollar8): (JSC::regExpConstructorDollar9): (JSC::regExpConstructorInput): (JSC::regExpConstructorMultiline): (JSC::regExpConstructorLastMatch): (JSC::regExpConstructorLastParen): (JSC::regExpConstructorLeftContext): (JSC::regExpConstructorRightContext): (JSC::RegExpConstructor::put): (JSC::setRegExpConstructorInput): (JSC::setRegExpConstructorMultiline): (JSC::constructRegExp): (JSC::callRegExpConstructor):
- runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure): (JSC::asRegExpConstructor):
- runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::put):
- runtime/RegExpObject.cpp: (JSC::regExpObjectGlobal): (JSC::regExpObjectIgnoreCase): (JSC::regExpObjectMultiline): (JSC::regExpObjectSource): (JSC::regExpObjectLastIndex): (JSC::RegExpObject::put): (JSC::setRegExpObjectLastIndex): (JSC::RegExpObject::test): (JSC::RegExpObject::exec): (JSC::callRegExpObject):
- runtime/RegExpObject.h: (JSC::RegExpObject::createStructure): (JSC::asRegExpObject):
- runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncTest): (JSC::regExpProtoFuncExec): (JSC::regExpProtoFuncCompile): (JSC::regExpProtoFuncToString):
- runtime/StringConstructor.cpp: (JSC::stringFromCharCodeSlowCase): (JSC::stringFromCharCode): (JSC::callStringConstructor):
- runtime/StringObject.cpp: (JSC::StringObject::put):
- runtime/StringObject.h: (JSC::StringObject::createStructure): (JSC::asStringObject):
- runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncToString): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncToLowerCase): (JSC::stringProtoFuncToUpperCase): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncBig): (JSC::stringProtoFuncSmall): (JSC::stringProtoFuncBlink): (JSC::stringProtoFuncBold): (JSC::stringProtoFuncFixed): (JSC::stringProtoFuncItalics): (JSC::stringProtoFuncStrike): (JSC::stringProtoFuncSub): (JSC::stringProtoFuncSup): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::changePrototypeTransition):
- runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::setPrototypeWithoutTransition): (JSC::Structure::storedPrototype):
JavaScriptGlue:
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Rubber Stamped by Sam Weinig.
Renamed JSValuePtr => JSValue.
- JSObject.cpp: (nativeCallFunction):
- JSUtils.cpp: (KJSValueToJSObject): (JSObjectKJSValue): (KJSValueToCFTypeInternal): (KJSValueToCFType):
- JSUtils.h:
- JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction):
- JSValueWrapper.h:
- UserObjectImp.cpp: (UserObjectImp::callAsFunction): (UserObjectImp::userObjectGetter): (UserObjectImp::getOwnPropertySlot): (UserObjectImp::put): (UserObjectImp::toPrimitive):
- UserObjectImp.h: (UserObjectImp::createStructure):
WebCore:
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Rubber Stamped by Sam Weinig.
Renamed JSValuePtr => JSValue.
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
- bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter): (WebCore::JSCSSStyleDeclaration::customPut):
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toJS): (WebCore::toHTMLCanvasStyle): (WebCore::JSCanvasRenderingContext2D::strokeStyle): (WebCore::JSCanvasRenderingContext2D::setStrokeStyle): (WebCore::JSCanvasRenderingContext2D::fillStyle): (WebCore::JSCanvasRenderingContext2D::setFillStyle): (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow): (WebCore::JSCanvasRenderingContext2D::createPattern): (WebCore::JSCanvasRenderingContext2D::putImageData): (WebCore::JSCanvasRenderingContext2D::fillText): (WebCore::JSCanvasRenderingContext2D::strokeText):
- bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::types): (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profiles):
- bindings/js/JSCoordinatesCustom.cpp: (WebCore::JSCoordinates::altitude): (WebCore::JSCoordinates::altitudeAccuracy): (WebCore::JSCoordinates::heading): (WebCore::JSCoordinates::speed):
- bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
- bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
- bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent): (WebCore::toVoidCallback):
- bindings/js/JSCustomVoidCallback.h:
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSCustomXPathNSResolver.h:
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem): (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMBinding.cpp: (WebCore::jsStringOrNull): (WebCore::jsOwnedStringOrNull): (WebCore::jsStringOrUndefined): (WebCore::jsStringOrFalse): (WebCore::valueToStringWithNullCheck): (WebCore::valueToStringWithUndefinedOrNullCheck): (WebCore::reportException): (WebCore::reportCurrentException): (WebCore::setDOMException): (WebCore::objectToStringFunctionGetter):
- bindings/js/JSDOMBinding.h: (WebCore::getDOMObjectWrapper): (WebCore::getDOMNodeWrapper): (WebCore::toJS):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMStringListCustom.cpp: (WebCore::JSDOMStringList::getByIndex): (WebCore::JSDOMStringList::item):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::childFrameGetter): (WebCore::JSDOMWindowBase::indexGetter): (WebCore::JSDOMWindowBase::namedItemGetter): (WebCore::JSDOMWindowBase::getOwnPropertySlot): (WebCore::JSDOMWindowBase::put): (WebCore::JSDOMWindowBase::setReturnValueSlot): (WebCore::toJS): (WebCore::toJSDOMWindow):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::lookupGetter): (WebCore::JSDOMWindow::lookupSetter): (WebCore::JSDOMWindow::history): (WebCore::JSDOMWindow::location): (WebCore::JSDOMWindow::setLocation): (WebCore::JSDOMWindow::crypto): (WebCore::JSDOMWindow::event): (WebCore::JSDOMWindow::image): (WebCore::JSDOMWindow::option): (WebCore::JSDOMWindow::audio): (WebCore::JSDOMWindow::webKitPoint): (WebCore::JSDOMWindow::webKitCSSMatrix): (WebCore::JSDOMWindow::xmlHttpRequest): (WebCore::JSDOMWindow::xsltProcessor): (WebCore::JSDOMWindow::messageChannel): (WebCore::JSDOMWindow::worker): (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog): (WebCore::JSDOMWindow::postMessage): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): (WebCore::toDOMWindow):
- bindings/js/JSDOMWindowCustom.h: (WebCore::nonCachingStaticFunctionGetter): (WebCore::JSDOMWindow::customPut):
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::put): (WebCore::JSDOMWindowShell::putWithAttributes): (WebCore::JSDOMWindowShell::lookupGetter): (WebCore::JSDOMWindowShell::lookupSetter): (WebCore::toJS):
- bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
- bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::JSDocument::setLocation): (WebCore::toJS):
- bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNode): (WebCore::JSElement::setAttributeNS): (WebCore::JSElement::setAttributeNodeNS): (WebCore::toJSNewlyCreated):
- bindings/js/JSEventCustom.cpp: (WebCore::JSEvent::clipboardData): (WebCore::toJS):
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget):
- bindings/js/JSEventTarget.h:
- bindings/js/JSEventTargetBase.h:
- bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionOptions): (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
- bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::createStructure):
- bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::customPut): (WebCore::JSHTMLAppletElement::nameGetter):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem): (WebCore::toJS):
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all): (WebCore::JSHTMLDocument::setAll): (WebCore::JSHTMLDocument::open): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln):
- bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::customPut): (WebCore::JSHTMLEmbedElement::nameGetter):
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter): (WebCore::JSHTMLFormElement::submit):
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::JSHTMLFrameElement::setSrc): (WebCore::JSHTMLFrameElement::setLocation):
- bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc):
- bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::selectionStart): (WebCore::JSHTMLInputElement::setSelectionStart): (WebCore::JSHTMLInputElement::selectionEnd): (WebCore::JSHTMLInputElement::setSelectionEnd): (WebCore::JSHTMLInputElement::setSelectionRange):
- bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::customPut): (WebCore::JSHTMLObjectElement::nameGetter):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::length): (WebCore::JSHTMLOptionsCollection::setLength): (WebCore::JSHTMLOptionsCollection::indexSetter): (WebCore::JSHTMLOptionsCollection::add): (WebCore::JSHTMLOptionsCollection::remove):
- bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): (WebCore::selectIndexSetter): (WebCore::JSHTMLSelectElement::indexSetter):
- bindings/js/JSHTMLSelectElementCustom.h:
- bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter): (WebCore::JSHistory::customPut):
- bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
- bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
- bindings/js/JSInspectedObjectWrapper.h: (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
- bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::JSInspectorCallbackWrapper::wrap): (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
- bindings/js/JSInspectorCallbackWrapper.h: (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
- bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::highlightDOMNode): (WebCore::JSInspectorController::addResourceSourceToFrame): (WebCore::JSInspectorController::addSourceToFrame): (WebCore::JSInspectorController::getResourceDocumentNode): (WebCore::JSInspectorController::search): (WebCore::JSInspectorController::databaseTableNames): (WebCore::JSInspectorController::inspectedWindow): (WebCore::JSInspectorController::setting): (WebCore::JSInspectorController::setSetting): (WebCore::JSInspectorController::wrapCallback): (WebCore::JSInspectorController::currentCallFrame): (WebCore::JSInspectorController::profiles):
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate): (WebCore::JSJavaScriptCallFrame::thisObject): (WebCore::JSJavaScriptCallFrame::type): (WebCore::JSJavaScriptCallFrame::scopeChain):
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
- bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter): (WebCore::JSLocation::customPut): (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): (WebCore::JSLocationPrototype::customPut):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSMimeTypeArrayCustom.cpp: (WebCore::JSMimeTypeArray::nameGetter):
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::nameGetter):
- bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::lengthGetter): (WebCore::JSNamedNodesCollection::indexGetter):
- bindings/js/JSNamedNodesCollection.h: (WebCore::JSNamedNodesCollection::createStructure):
- bindings/js/JSNavigatorCustom.cpp: (WebCore::needsYouTubeQuirk): (WebCore::JSNavigator::appVersion):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild): (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener): (WebCore::createWrapper): (WebCore::toJSNewlyCreated): (WebCore::toJS):
- bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::JSNodeFilterCondition): (WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSNodeFilterCondition.h: (WebCore::JSNodeFilterCondition::create):
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::acceptNode): (WebCore::toNodeFilter):
- bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::nextNode): (WebCore::JSNodeIterator::previousNode):
- bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList): (WebCore::JSNodeList::nameGetter):
- bindings/js/JSPluginArrayCustom.cpp: (WebCore::JSPluginArray::nameGetter):
- bindings/js/JSPluginCustom.cpp: (WebCore::JSPlugin::nameGetter):
- bindings/js/JSPluginElementFunctions.cpp: (WebCore::runtimeObjectGetter): (WebCore::runtimeObjectPropertyGetter): (WebCore::runtimeObjectCustomPut): (WebCore::callPlugin):
- bindings/js/JSPluginElementFunctions.h:
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::asWrapper): (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter): (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState): (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot): (WebCore::JSQuarantinedObjectWrapper::put): (WebCore::JSQuarantinedObjectWrapper::construct): (WebCore::JSQuarantinedObjectWrapper::hasInstance): (WebCore::JSQuarantinedObjectWrapper::call):
- bindings/js/JSQuarantinedObjectWrapper.h: (WebCore::JSQuarantinedObjectWrapper::createStructure):
- bindings/js/JSRGBColor.cpp: (WebCore::getJSRGBColor): (jsRGBColorRed): (jsRGBColorGreen): (jsRGBColorBlue):
- bindings/js/JSRGBColor.h: (WebCore::JSRGBColor::createStructure):
- bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
- bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener): (WebCore::toJS):
- bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::convertToSpecifiedUnits):
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::rotateFromVector):
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
- bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::JSSVGPathSegList::clear): (WebCore::JSSVGPathSegList::initialize): (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem): (WebCore::JSSVGPathSegList::appendItem):
- bindings/js/JSSVGPointListCustom.cpp: (WebCore::finishGetter): (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult): (WebCore::JSSVGPointList::clear): (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
- bindings/js/JSSVGTransformListCustom.cpp: (WebCore::finishGetter): (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult): (WebCore::JSSVGTransformList::clear): (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::nameGetter): (WebCore::JSStorage::deleteProperty): (WebCore::JSStorage::customPut):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
- bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetList::nameGetter):
- bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::parentNode): (WebCore::JSTreeWalker::firstChild): (WebCore::JSTreeWalker::lastChild): (WebCore::JSTreeWalker::nextSibling): (WebCore::JSTreeWalker::previousSibling): (WebCore::JSTreeWalker::previousNode): (WebCore::JSTreeWalker::nextNode):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::self): (WebCore::JSWorkerContext::setSelf): (WebCore::JSWorkerContext::xmlHttpRequest): (WebCore::JSWorkerContext::importScripts): (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener): (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener): (WebCore::JSXMLHttpRequest::responseText):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument): (WebCore::JSXSLTProcessor::setParameter): (WebCore::JSXSLTProcessor::getParameter): (WebCore::JSXSLTProcessor::removeParameter):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create): (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScheduledAction.h:
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::initialize):
- bindings/js/ScriptCallStack.h:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::jsObjectForPluginElement):
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): (WebCore::ScriptFunctionCall::call): (WebCore::ScriptFunctionCall::construct):
- bindings/js/ScriptFunctionCall.h:
- bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::get):
- bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::jsValue):
- bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject webScriptValueAtIndex:]): (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bindings/objc/WebScriptObjectPrivate.h:
- bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_HasMethod): (_NPN_Construct):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod): (JSC::Bindings::CInstance::invokeDefaultMethod): (JSC::Bindings::CInstance::invokeConstruct): (JSC::Bindings::CInstance::defaultValue): (JSC::Bindings::CInstance::stringValue): (JSC::Bindings::CInstance::numberValue): (JSC::Bindings::CInstance::booleanValue): (JSC::Bindings::CInstance::valueOf):
- bridge/c/c_instance.h:
- bridge/c/c_runtime.cpp: (JSC::Bindings::CField::valueFromInstance): (JSC::Bindings::CField::setValueToInstance):
- bridge/c/c_runtime.h:
- bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant): (JSC::Bindings::convertNPVariantToValue):
- bridge/c/c_utility.h:
- bridge/jni/jni_instance.cpp: (JavaInstance::stringValue): (JavaInstance::numberValue): (JavaInstance::booleanValue): (JavaInstance::invokeMethod): (JavaInstance::defaultValue): (JavaInstance::valueOf):
- bridge/jni/jni_instance.h:
- bridge/jni/jni_jsobject.h:
- bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::getSlot): (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
- bridge/jni/jni_objc.mm: (JSC::Bindings::dispatchJNICall):
- bridge/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray): (JavaField::dispatchValueFromInstance): (JavaField::valueFromInstance): (JavaField::dispatchSetValueToInstance): (JavaField::setValueToInstance): (JavaArray::setValueAt): (JavaArray::valueAt):
- bridge/jni/jni_runtime.h:
- bridge/jni/jni_utility.cpp: (JSC::Bindings::convertArrayInstanceToJavaArray): (JSC::Bindings::convertValueToJValue):
- bridge/jni/jni_utility.h:
- bridge/objc/WebScriptObject.h:
- bridge/objc/objc_class.h:
- bridge/objc/objc_class.mm: (JSC::Bindings::ObjcClass::fallbackObject):
- bridge/objc/objc_instance.h:
- bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField): (ObjcInstance::defaultValue): (ObjcInstance::stringValue): (ObjcInstance::numberValue): (ObjcInstance::booleanValue): (ObjcInstance::valueOf):
- bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
- bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcField::valueFromInstance): (JSC::Bindings::convertValueToObjcObject): (JSC::Bindings::ObjcField::setValueToInstance): (JSC::Bindings::ObjcArray::setValueAt): (JSC::Bindings::ObjcArray::valueAt): (JSC::Bindings::ObjcFallbackObjectImp::put): (JSC::Bindings::callObjCFallbackObject): (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
- bridge/objc/objc_utility.h:
- bridge/objc/objc_utility.mm: (JSC::Bindings::convertValueToObjcValue): (JSC::Bindings::convertNSStringToString): (JSC::Bindings::convertObjcValueToValue):
- bridge/runtime.h: (JSC::Bindings::Class::fallbackObject): (JSC::Bindings::Instance::setValueOfUndefinedField): (JSC::Bindings::Instance::invokeDefaultMethod): (JSC::Bindings::Instance::invokeConstruct): (JSC::Bindings::Instance::put):
- bridge/runtime_array.cpp: (JSC::RuntimeArray::lengthGetter): (JSC::RuntimeArray::indexGetter): (JSC::RuntimeArray::put):
- bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::lengthGetter): (JSC::callRuntimeMethod):
- bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::fallbackObjectGetter): (JSC::RuntimeObjectImp::fieldGetter): (JSC::RuntimeObjectImp::methodGetter): (JSC::RuntimeObjectImp::put): (JSC::RuntimeObjectImp::defaultValue): (JSC::callRuntimeObject): (JSC::callRuntimeConstructor):
- bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructure):
- inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::evaluate):
- inspector/JavaScriptCallFrame.h:
- inspector/JavaScriptProfile.cpp: (WebCore::toJS):
- inspector/JavaScriptProfile.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::toJS):
- inspector/JavaScriptProfileNode.h:
WebKit/mac:
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Rubber Stamped by Sam Weinig.
Renamed JSValuePtr => JSValue.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::addValueToArray): (WebKit::NetscapePluginInstanceProxy::marshalValue): (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): (WebKit::NetscapePluginInstanceProxy::demarshalValue): (WebKit::NetscapePluginInstanceProxy::demarshalValues):
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyField::valueFromInstance): (WebKit::ProxyField::setValueToInstance): (WebKit::ProxyInstance::invoke): (WebKit::ProxyInstance::invokeMethod): (WebKit::ProxyInstance::invokeDefaultMethod): (WebKit::ProxyInstance::invokeConstruct): (WebKit::ProxyInstance::defaultValue): (WebKit::ProxyInstance::stringValue): (WebKit::ProxyInstance::numberValue): (WebKit::ProxyInstance::booleanValue): (WebKit::ProxyInstance::valueOf): (WebKit::ProxyInstance::fieldValue): (WebKit::ProxyInstance::setFieldValue):
- WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _convertValueToObjcValue:]): (-[WebScriptCallFrame exception]): (-[WebScriptCallFrame evaluateWebScript:]):
- WebView/WebView.mm: (aeDescFromJSValue): (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
WebKit/qt:
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Rubber Stamped by Sam Weinig.
Renamed JSValuePtr => JSValue.
- Api/qwebelement.cpp: (setupScriptContext): (setupScriptObject): (QWebElement::evaluateScript): (QWebElement::functions): (QWebElement::scriptableProperty): (QWebElement::setScriptableProperty): (QWebElement::scriptableProperties):
WebKit/win:
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Rubber Stamped by Sam Weinig.
Renamed JSValuePtr => JSValue.
- WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
WebKit/wx:
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Rubber Stamped by Sam Weinig.
Renamed JSValuePtr => JSValue.
- WebFrame.cpp: (wxWebFrame::RunScript):
- 2:20 PM Changeset in webkit [43121] by
-
- 8 edits in trunk/JavaScriptCore
2009-05-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam "That doesn't look like what I thought it looks like" Weinig.
Beefed up the JSValuePtr class and removed some non-JSValuePtr dependencies
on JSImmediate, in prepapration for making JSImmediate an implementation
detail of JSValuePtr.
SunSpider reports no change.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_mod):
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt): Updated for interface changes.
- runtime/JSImmediate.h: (JSC::JSValuePtr::JSValuePtr):
- runtime/JSValue.h: (JSC::JSValuePtr::): (JSC::jsImpossibleValue): (JSC::jsNull): (JSC::jsUndefined): (JSC::jsBoolean): (JSC::JSValuePtr::encode): (JSC::JSValuePtr::decode): (JSC::JSValuePtr::JSValuePtr): (JSC::JSValuePtr::operator bool): (JSC::JSValuePtr::operator==): (JSC::JSValuePtr::operator!=): (JSC::JSValuePtr::isUndefined): (JSC::JSValuePtr::isNull): Changed jsImpossibleValue(), jsNull(), jsUndefined(), and jsBoolean() to operate in terms of JSValuePtr instead of JSImmediate.
- wtf/StdLibExtras.h: (WTF::bitwise_cast): Fixed up for clarity.
- 2:18 PM Changeset in webkit [43120] by
-
- 2 edits in trunk/WebCore
2009-05-01 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25485
Only use visitedURL in Qt. This is a follow-up change to http://trac.webkit.org/changeset/43052,
which broke Chromium build.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState): Moved guards around to
provide separate code paths for Qt and non-Qt ports. Also restored original
order of execution.
- 2:04 PM Changeset in webkit [43119] by
-
- 2 edits in trunk/WebCore
2009-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6839222>
CrashTracer: Lots of crashes in Safari in hash table remove function inside DocumentLoader::removeSubresourceLoader
After calling m_client->didFail(), check if the subresource loader has reached its terminal state. If that's the case,
return early to avoid calling removeSubresourceLoader on a null document loader. I don't think this is allowed to happen
which is why I've added the ASSERT.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didCancel):
- 1:15 PM Changeset in webkit [43118] by
-
- 2 edits in trunk/WebCore
Disallow the deletion UI for elements that have any overflow clipping.
Also disallow the UI for the body element it isn't practical to delete,
and the deletion UI would be clipped.
<rdar://problem/6840161> Deletion UI can be clipped by some
elements (with overflow: hidden)
Reviewed by Darin Adler.
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- 1:15 PM Changeset in webkit [43117] by
-
- 2 edits in trunk/WebCore
Decrease the minimum height for deleteable elements to 16px, and increase the
minimum width to 48px. This allows deleting shorter items like navigation bars.
<rdar://problem/6840735> Deletion UI does not show up for short
elements (22px or less)
Reviewed by Adele Peterson.
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- 1:14 PM Changeset in webkit [43116] by
-
- 2 edits in trunk/WebCore
Clean up the comments and logic in the code for picking a
deleteable element for the deletion UI.
Reviewed by Adele Peterson.
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- 12:17 PM Changeset in webkit [43115] by
-
- 3 edits2 adds in trunk
WebCore:
2009-05-01 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele Peterson and Darin Adler.
<rdar://problem/4815598> Stuck in double spacing mode after pasting a
paragraph with padding/margin (or table mode !)
A lot of the issues in this bug were resolved on Mail's side by using
WebKit to convert to plain text. This is the final issue, that floating
style stays on copied nodes causing them to float when they are pasted
which is not what the user intended.
- editing/markup.cpp: (WebCore::removeExteriorStyles): (WebCore::): (WebCore::appendStartMarkup): (WebCore::getStartMarkup): (WebCore::createMarkup):
LayoutTests:
2009-04-30 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele Peterson and Darin Adler.
<rdar://problem/4815598> Stuck in double spacing mode after pasting a
paragraph with padding/margin (or table mode !)
A lot of the issues in this bug were resolved on Mail's side by using
WebKit to convert to plain text. This is the final issue, that floating
style stays on copied nodes causing them to float when they are pasted
which is not what the user intended.
- editing/pasteboard/copy-paste-float-expected.txt: Added.
- editing/pasteboard/copy-paste-float.html: Added.
- 9:38 AM Changeset in webkit [43114] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-01 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, bulid fix.
Fix mis-applied patch.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
- 8:24 AM Changeset in webkit [43113] by
-
- 22 edits in trunk
WebCore:
2009-05-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
This is the only resource-related information that is available in InspectorController
and is missing in the FrameLoaderClient.
- WebCore.xcodeproj/project.pbxproj: Made ScriptSource private.
- dom/Document.cpp: Made a call to a client along with the call to the InspectorController. (WebCore::Document::resourceRetrievedByXMLHttpRequest):
- loader/EmptyClients.h: Added stub implementation. (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
- loader/FrameLoader.cpp: Call initiating dispatches. (WebCore::FrameLoader::resourceRetrievedByXMLHttpRequest):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
WebKit/gtk:
2009-05-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2009-05-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
WebKit/qt:
2009-05-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidLoadResourceByXMLHttpRequest):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
2009-05-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
- WebCoreSupport/WebFrameLoaderClient.h:
WebKit/wx:
2009-05-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidLoadResourceByXMLHttpRequest):
- WebKitSupport/FrameLoaderClientWx.h:
- 4:29 AM Changeset in webkit [43112] by
-
- 2 edits in trunk/LayoutTests
2009-05-01 Jan Michael Alonzo <jmalonzo@webkit.org>
Skip the following failing tests:
fast/replaced/table-percent-height-text-controls.html
media/video-document-types.html
- platform/gtk/Skipped:
Apr 30, 2009:
- 9:15 PM Changeset in webkit [43111] by
-
- 2 edits in trunk/WebCore
2009-04-30 Beth Dakin <Beth Dakin>
Reviewed by Oliver Hunt.
Fix for <rdar://problem/6841106> REGRESSION: Crash drag selecting
To Do's in a Mail note (excessive recursion in mouse drag tracking)
Oliver's recent change to dragging seems to have revealed a long-
time bug in passSubframeEventToSubframe where we did not set
m_sendingEventToSubview to true before calling
handleMouseMoveEvent() in the NSMouseMoved case. This patch fixes
that and adds ASSERTions around all of the places where
m_sendingEventToSubview is set to true and then false to make sure
we are not trampling its state.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::eventLoopHandleMouseUp): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget):
- 9:10 PM Changeset in webkit [43110] by
-
- 3 edits3 adds in trunk
2009-04-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug fix for rdar:/68455379. If a case-insensitive regex contains
a character class containing a range with an upper bound of \uFFFF
the parser will infinite-loop whist adding other-case characters
for characters in the range that do have another case.
- yarr/RegexCompiler.cpp: (JSC::Yarr::CharacterClassConstructor::putRange):
LayoutTests:
2009-04-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Add layout test for rdar:/68455379.
- fast/js/regexp-range-bound-ffff-expected.txt: Added.
- fast/js/regexp-range-bound-ffff.html: Added.
- fast/js/resources/regexp-range-bound-ffff.js: Added.
- 8:55 PM Changeset in webkit [43109] by
-
- 5 edits3 adds in trunk
2009-04-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
MediaDocument falls back to plug-in unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=25504
<rdar://problem/6844702>
Don't allow harmless media types to cause a MediaDocument to fall
back to PluginDocument.
Test: media/video-document-types.html
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks): add timecode, timecode 64, odsm, and sdsm to allowed track types.
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::disableUnsupportedTracks): Ditto.
2009-04-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
MediaDocument falls back to plug-in unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=25504
<rdar://problem/6844702>
Test case for MediaDocument with previously unsupported track
types. Disabled on Windows for now until https://bugs.webkit.org/show_bug.cgi?id=25220
has been fixed.
- media/content/counting.mp4: Added.
- media/video-document-types-expected.txt: Added.
- media/video-document-types.html: Added.
- platform/win/Skipped:
- 8:48 PM Changeset in webkit [43108] by
-
- 5 edits in trunk
wx build fix, define ENABLE_JAVASCRIPT_DEBUGGER and remove JSCore dynamic library references.
- 6:57 PM Changeset in webkit [43107] by
-
- 4 edits3 deletes in trunk
Roll out r43106 as it introduced four regression test failures.
- 5:06 PM Changeset in webkit [43106] by
-
- 4 edits5 adds in trunk
WebCore:
2009-04-30 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
Bug 25491: WebFrame leak when a subframe removes itself
https://bugs.webkit.org/show_bug.cgi?id=25491
rdar://problem/6833859
Test: fast/loading/subframe-removes-itself.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): When isStopping is true, treat load as complete, even if isLoadingInAPISense is still returning true.
LayoutTests:
2009-04-30 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
Bug 25491: WebFrame leak when a subframe removes itself
https://bugs.webkit.org/show_bug.cgi?id=25491
rdar://problem/6833859
- fast/loading: Added.
- fast/loading/resources: Added.
- fast/loading/resources/subframe-that-removes-itself.html: Added.
- fast/loading/subframe-removes-itself-expected.txt: Added.
- fast/loading/subframe-removes-itself.html: Added.
- platform/gtk/Skipped: Skip loading tests.
- 4:55 PM Changeset in webkit [43105] by
-
- 3 edits in trunk/JavaScriptCore
2009-04-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
OPCODE_SAMPLING without CODEBLOCK_SAMPLING is currently broken,
since SamplingTool::Sample::isNull() checks the m_codeBlock
member (which is always null without CODEBLOCK_SAMPLING).
Restructure the checks so make this work again.
- bytecode/SamplingTool.cpp: (JSC::SamplingTool::doRun):
- bytecode/SamplingTool.h: (JSC::SamplingTool::Sample::isNull):
- 4:36 PM Changeset in webkit [43104] by
-
- 4 edits in trunk/JavaScriptCore
2009-04-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Gavin Barraclough.
- Concatenate final three strings in simple replace case at one go
~0.2% SunSpider speedup
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): Use new replaceRange helper instead of taking substrings and concatenating three strings.
- runtime/UString.cpp: (JSC::UString::replaceRange): New helper function.
- runtime/UString.h:
- 3:58 PM Changeset in webkit [43103] by
-
- 10 edits in trunk/JavaScriptCore
2009-04-30 Geoffrey Garen <ggaren@apple.com>
Rubber Stamped by Gavin Barraclough.
Changed JSValueEncodedAsPtr* => EncodedJSValuePtr to support a non-pointer
encoding for JSValuePtrs.
- API/APICast.h: (toJS):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue): (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
- interpreter/Register.h: (JSC::Register::):
- jit/JIT.cpp: (JSC::):
- jit/JIT.h:
- jit/JITCode.h: (JSC::):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_op_get_by_id_generic): (JSC::JITStubs::cti_op_get_by_id): (JSC::JITStubs::cti_op_get_by_id_second): (JSC::JITStubs::cti_op_get_by_id_self_fail): (JSC::JITStubs::cti_op_get_by_id_proto_list): (JSC::JITStubs::cti_op_get_by_id_proto_list_full): (JSC::JITStubs::cti_op_get_by_id_proto_fail): (JSC::JITStubs::cti_op_get_by_id_array_fail): (JSC::JITStubs::cti_op_get_by_id_string_fail): (JSC::JITStubs::cti_op_instanceof): (JSC::JITStubs::cti_op_del_by_id): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_resolve): (JSC::JITStubs::cti_op_construct_NotJSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_lesseq): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_resolve_base): (JSC::JITStubs::cti_op_resolve_skip): (JSC::JITStubs::cti_op_resolve_global): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_not): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_less): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_op_throw): (JSC::JITStubs::cti_op_next_pname): (JSC::JITStubs::cti_op_typeof): (JSC::JITStubs::cti_op_is_undefined): (JSC::JITStubs::cti_op_is_boolean): (JSC::JITStubs::cti_op_is_number): (JSC::JITStubs::cti_op_is_string): (JSC::JITStubs::cti_op_is_object): (JSC::JITStubs::cti_op_is_function): (JSC::JITStubs::cti_op_stricteq): (JSC::JITStubs::cti_op_nstricteq): (JSC::JITStubs::cti_op_to_jsnumber): (JSC::JITStubs::cti_op_in): (JSC::JITStubs::cti_op_del_by_val): (JSC::JITStubs::cti_vm_throw):
- jit/JITStubs.h:
- runtime/JSValue.h: (JSC::JSValuePtr::encode): (JSC::JSValuePtr::decode):
- 3:37 PM Changeset in webkit [43102] by
-
- 2 edits in trunk/WebCore
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add CHROMIUM guard to unfork Document.cpp
- dom/Document.cpp: (WebCore::Document::setFocusedNode): Added guard.
- 3:27 PM Changeset in webkit [43101] by
-
- 3 edits in trunk/WebCore
Use OwnPtr<HTMLParserQuirks> for m_parserQuirks
Reviewed by Geoff Garen.
- html/HTMLParser.cpp: (WebCore::HTMLParser::~HTMLParser): Removed unneeded code.
- html/HTMLParser.h: Made m_parserQuirks an OwnPtr.
- 2:51 PM Changeset in webkit [43100] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver "Abandon Ship!" Hunt.
Fix a leak in Yarr.
All Disjunctions should be recorded in RegexPattern::m_disjunctions,
so that they can be freed at the end of compilation - copyDisjunction
is failing to do so.
- yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::copyDisjunction):
- 2:45 PM Changeset in webkit [43099] by
-
- 6 edits3 adds2 deletes in trunk/LayoutTests
2009-04-30 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
Fix tests that depend on Mac-specific metrics now that text controls
are sized according to font metrics (r43007).
- fast/forms/textarea-appearance-wrap-expected.txt:
- fast/forms/textarea-appearance-wrap.html: This test only really cares that a line-wrap character is submitted with forms that have the appropriate wrap value and not with other forms. So checking that the submit contents have a line-wrap character, instead of looking for it in a specific place, is sufficient. This gets around that we wrap in a different place in some cases on Mac and Windows.
- fast/forms/textarea-hard-linewrap-expected.txt: Removed.
- fast/forms/textarea-hard-linewrap.html: Removed. This test is redundant with fast/forms/textarea-appearance-wrap.html.
- fast/replaced/table-percent-height-expected.txt:
- fast/replaced/table-percent-height-text-controls-expected.txt: Added.
- fast/replaced/table-percent-height-text-controls.html: Added.
- fast/replaced/table-percent-height.html: Pulled out the cases in table-percent-height.html that had text controls and moved them into their own test. The new test doesn't assert specific metrics, it just spits them out. This allows us to have different expected results for Windows and Mac without having "FAIL" messages in the expected results. It's not perfect, but it seems better than any alternatives I could come up with. We do still print "FAIL" if the results don't match any platform.
- platform/win/Skipped:
- platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
- 2:39 PM Changeset in webkit [43098] by
-
- 2 edits in tags/Safari-6530.8/WebCore
Merge r43040.
- 2:38 PM Changeset in webkit [43097] by
-
- 7 edits in tags/Safari-6530.8
Merge r43039.
- 2:38 PM Changeset in webkit [43096] by
-
- 3 edits in trunk/JavaScriptCore
Add function to CallFrame for dumping the current JS caller
Reviewed by Gavin Barraclough.
Added debug only method CallFrame::dumpCaller() that provide the call location
of the deepest currently executing JS function.
- 2:36 PM Changeset in webkit [43095] by
-
- 3 edits in tags/Safari-6530.8/WebCore
Merge r43026.
- 2:34 PM Changeset in webkit [43094] by
-
- 2 edits in tags/Safari-6530.8/WebCore
Merge r42945.
- 2:28 PM Changeset in webkit [43093] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed ChangeLog entry, added comments.
- 2:26 PM Changeset in webkit [43092] by
-
- 16 edits1 add in trunk
Provide a mechanism to create a quirks delegate for HTMLParser
Reviewed by David Hyatt.
WebCore:
No tests since there is no change in behavior.
HTMLParserQuirks.h defines an abstract base class that may be
extended as needed. The ChromeClient::createHTMLParserQuirks()
factory method should be used to return an HTMLParserQuirks
subclassed object when needed.
- WebCore.xcodeproj/project.pbxproj: Added HTMLParserQuirks.h.
- html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): Initialize m_parserQuirks using ChromeClient::createHTMLParserQuirks(). (WebCore::HTMLParser::~HTMLParser): Delete m_parserQuirks if set. (WebCore::HTMLParser::reset): Call HTMLParserQuirks::reset() if m_parserQuirks is set. (WebCore::HTMLParser::insertNode): Call HTMLParserQuirks::shouldInsertNode() if m_parserQuirks is set, and return early if it returns false. (WebCore::HTMLParser::popBlock): Call HTMLParserQuirks::shouldPopBlock() if m_parserQuirks is set, and return early if it returns false.
- html/HTMLParser.h: Added m_parserQuirks.
- html/HTMLParserQuirks.h: Added. (WebCore::HTMLParserQuirks::HTMLParserQuirks): (WebCore::HTMLParserQuirks::~HTMLParserQuirks):
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::createHTMLParserQuirks): Added.
- page/ChromeClient.h: (WebCore::ChromeClient::createHTMLParserQuirks): Added.
WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::createHTMLParserQuirks): Added. The default implementation of this factory method returns 0.
WebKit/mac:
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Added. The default implementation of this factory method returns 0.
WebKit/qt:
- WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::createHTMLParserQuirks): Added. The default implementation of this factory method returns 0.
WebKit/win:
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Added. The default implementation of this factory method returns 0.
WebKit/wx:
- WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::createHTMLParserQuirks): Added. The default implementation of this factory method returns 0.
- 2:20 PM Changeset in webkit [43091] by
-
- 3 edits in trunk/WebCore
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25492
Add JSC guards around node wrapper cache calls. These are not used by V8.
- dom/Document.cpp: (WebCore::Document::~Document): Added JSC guard.
- dom/Node.cpp: (WebCore::Node::setDocument): Ditto and removed JSDOMBinding include.
- 2:18 PM Changeset in webkit [43090] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff Garen.
- make BaseStrings have themselves as a base, instead of nothing, to remove common branches
~0.7% SunSpider speedup
- runtime/UString.h: (JSC::UString::Rep::Rep): For the constructor without a base, set self as base instead of null. (JSC::UString::Rep::baseString): Just read m_baseString - no more branching.
- 2:11 PM Changeset in webkit [43089] by
-
- 4 edits in trunk
Versioning.
- 2:11 PM Changeset in webkit [43088] by
-
- 2 edits in trunk/WebCore
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25493
Remove debugger/profiler custom method stubs, catching V8 bindings up to
http://trac.webkit.org/changeset/43072.
- bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed method stubs.
- 2:02 PM Changeset in webkit [43087] by
-
- 3 edits in trunk/JavaScriptCore
2009-04-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Two quick improvements to SamplingFlags mechanism.
SamplingFlags::ScopedFlag class to provide support for automagically
clearing a flag as it goes out of scope, and add a little more detail
to the output generated by the tool.
- bytecode/SamplingTool.cpp: (JSC::SamplingFlags::stop):
- bytecode/SamplingTool.h: (JSC::SamplingFlags::ScopedFlag::ScopedFlag): (JSC::SamplingFlags::ScopedFlag::~ScopedFlag):
- 1:59 PM Changeset in webkit [43086] by
-
- 1 copy in tags/Safari-6530.8
New tag.
- 1:50 PM Changeset in webkit [43085] by
-
- 3 edits2 adds in trunk
2009-04-30 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
<rdar://problem/6839338> VoiceOver does not take into account transforms when drawing outlines
Use transform-aware quad methods when computing the boundingBoxRect for
an AccessibilityRenderObject. The code follows RenderObject::absoluteBoundingBoxRect().
Test: accessibility/transformed-element.html
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::boundingBoxRect):
- 1:47 PM Changeset in webkit [43084] by
-
- 5 edits in trunk/JavaScriptCore
Restore build event steps that were truncated in r43082
Rubber-stamped by Steve Falkenburg.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Re-copied the command lines for the build events from the pre-r43082 .vcproj files.
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Removed an unnecessary attribute.
- 1:38 PM Changeset in webkit [43083] by
-
- 2 edits in trunk
2009-04-30 Jan Michael Alonzo <jmalonzo@webkit.org>
Unreviewed build GTK build fix
- configure.ac: typo fix - javascript_debugger should be enable_javascript_debugger
- 1:24 PM Changeset in webkit [43082] by
-
- 5 edits4 adds in trunk/JavaScriptCore
Move settings from .vcproj files to .vsprops files within the JavaScriptCore directory
Moving the settings to a .vsprops file means that we will only have to
change a single setting to affect all configurations, instead of one
setting per configuration.
Reviewed by Steve Falkenburg.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Moved settings from these files to the new .vsprops files. Note that testapi.vcproj had a lot of overrides of default settings that were the same as the defaults, which I've removed.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added.
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added.
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added.
- 1:18 PM Changeset in webkit [43081] by
-
- 3 edits in trunk/WebCore
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, Chromium build fix.
Catch up to ScriptObject changes from http://trac.webkit.org/changeset/42512.
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::get): Renamed from getObject. (WebCore::ScriptGlobalObject::remove): Added.
- bindings/v8/ScriptObject.h: Ditto.
- 1:02 PM Changeset in webkit [43080] by
-
- 2 edits in trunk/WebCore
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
- WebCore.pro: Fix copy-paste error.
- 12:55 PM Changeset in webkit [43079] by
-
- 3 edits in trunk/WebCore
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
- GNUmakefile.am: Add ENABLE_JAVASCRIPT_DEBUGGER definitions.
- WebCore.pro: Ditto.
- 12:49 PM Changeset in webkit [43078] by
-
- 2 edits in trunk/WebKit/qt
2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
Unreviewed build fix after r43072.
- Api/qwebframe.cpp: (qt_drt_setJavaScriptProfilingEnabled): Enclose with JAVASCRIPT_DEBUGGER.
- 12:49 PM Changeset in webkit [43077] by
-
- 3 edits in trunk/WebKit/qt
2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
Unreviewed build fix after r43063.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):
- WebCoreSupport/ChromeClientQt.h:
- 12:48 PM Changeset in webkit [43076] by
-
- 4 edits1 copy5 adds in trunk/LayoutTests
2009-04-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Add a first text iterator test. We'll add more later.
This test includes some known expected failures. At some point we'll fix those.
- editing/text-iterator: Added.
- editing/text-iterator/basic-iteration-expected.txt: Added.
- editing/text-iterator/basic-iteration.html: Added.
- editing/text-iterator/resources: Added.
- editing/text-iterator/resources/TEMPLATE.html: Copied from editing/selection/resources/TEMPLATE.html.
- editing/text-iterator/resources/basic-iteration.js: Added.
- platform/gtk/Skipped: Skip editing/text-iterator since only Mac DumpRenderTree has this at the moment.
- platform/qt/Skipped: Ditto.
- platform/win/Skipped: Ditto.
- 12:40 PM Changeset in webkit [43075] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler.
Change Position to pre-compute the AnchorType and store it.
Also store a "legacy editing mode" bit on the Position.
https://bugs.webkit.org/show_bug.cgi?id=24763
The old Postion(node, offset) constructor creates legacy positions
but there are new constructors to create explicitly anchored positions
which the next patch will use.
Once we fix all the "position-fixup" functions (like rangeCompliantEquivalent) to
only affect legacy positions, we will be able to distinguish
between [table, 1] and [table, after] in the code correctly!
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- dom/Position.cpp: (WebCore::Position::Position): (WebCore::Position::moveToPosition): (WebCore::Position::moveToOffset): (WebCore::Position::anchorTypeForLegacyEditingPosition): (WebCore::Position::element):
- dom/Position.h: (WebCore::Position::): (WebCore::Position::Position): (WebCore::Position::anchorType): (WebCore::Position::deprecatedEditingOffset):
- 12:02 PM Changeset in webkit [43074] by
-
- 2 edits in trunk
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
- configure.ac: Add autoconfig options, missed in the first commit.
- 11:57 AM Changeset in webkit [43073] by
-
- 5 edits2 adds in trunk
WebCore:
2009-04-30 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix bug where the WorkerLocation and WorkerNavigator wrappers would be
collected even if the WorkerContext is still alive.
Test: fast/workers/worker-context-gc.html
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::completeURL): (WebCore::WorkerContext::location):
- workers/WorkerContext.h: (WebCore::WorkerContext::optionalNavigator): (WebCore::WorkerContext::optionalLocation):
LayoutTests:
2009-04-30 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
Test for bug where the WorkerLocation and WorkerNavigator wrappers would be
collected even if the WorkerContext is still alive.
- fast/workers/worker-context-gc-expected.txt: Added.
- fast/workers/worker-context-gc.html: Added.
- 11:28 AM Changeset in webkit [43072] by
-
- 16 edits in trunk
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
- Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER define.
WebCore:
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
- Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER.
- WebCore.vcproj/build-generated-files.sh: Ditto.
- bindings/js/JSConsoleCustom.cpp: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
- bindings/js/JSDOMWindowBase.cpp: Ditto.
- bindings/js/JSInspectorControllerCustom.cpp: Ditto.
- inspector/InspectorController.cpp: Moved profiler/debugger methods under
ENABLE(JAVASCRIPT_DEBUGGER) flag.
- inspector/InspectorController.h: Ditto.
- inspector/InspectorController.idl: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
- page/Console.cpp: Replaced USE(JSC) with ENABLE(JAVASCRIPT_DEBUGGER) guard.
WebKit/mac:
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
- Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER define.
WebKitTools:
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
- Scripts/build-webkit: Added ENABLE_JAVASCRIPT_DEBUGGER define.
- 11:28 AM Changeset in webkit [43071] by
-
- 2 edits in tags/Safari-6530.7.2/WebCore
Merge r43040.
- 11:27 AM Changeset in webkit [43070] by
-
- 3 edits in tags/Safari-6530.7.2/WebCore
Merge r43026.
- 11:09 AM Changeset in webkit [43069] by
-
- 4 edits in tags/Safari-6530.7.2
Versioning.
- 11:02 AM Changeset in webkit [43068] by
-
- 1 copy in tags/Safari-6530.7.2
New tag.
- 10:57 AM Changeset in webkit [43067] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Anders Carlson.
<rdar://problem/6823049>
Fix an issue where some plug-ins would cause the application icon to constantly bounce
up and down in the Dock.
- Plugins/Hosted/NetscapePluginHostProxy.h: Change m_placeholderWindow ivar to be a subclass of NSWindow, WebPlaceholderModalWindow.
- Plugins/Hosted/NetscapePluginHostProxy.mm: Added WebPlaceholderModalWindow NSWindow subclass. (-[WebPlaceholderModalWindow _wantsUserAttention]): Prevent NSApp from calling requestUserAttention: when the window is shown modally, even if the app is inactive. (WebKit::NetscapePluginHostProxy::beginModal): NSWindow -> WebPlaceholderModalWindow.
- 10:27 AM Changeset in webkit [43066] by
-
- 2 edits in trunk/WebCore
2009-04-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=25275
This patch snuck in a re-definition of a local.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): Removed re-definition.
- 10:16 AM Changeset in webkit [43065] by
-
- 2 edits in trunk/WebCore
2009-04-30 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix a leak introduced yesterday. Don't allocate a ScheduledAction
if the toString()ing throws an exception.
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create):
- 9:55 AM Changeset in webkit [43064] by
-
- 4 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25379
<rdar://problem/6809460> REGRESSION (r41772): Selecting a bank in American Express Pay Bill fails
Test: fast/forms/multiple-selected-options-innerHTML.html
This problem was caused by an inconsistency at when Node::instertedIntoTree() is called.
For normal HTML parsing, it is called immediately after an element is inserted, but for
innerHTML, it is only called after the whole subtree is inserted into a document.
It may make sense to harmonize these cases one day, but for now, I only made the minimal
changes necessary to fix the bug.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::insertedIntoTree):
- html/HTMLSelectElement.h: Recalculate list items when a SELECT element is inserted. OPTION elements cannot decide which one to keep selected themselves, because their logic assumes normal parsing, with insertedIntoTree() called after each element is inserted.
- 9:41 AM Changeset in webkit [43063] by
-
- 16 edits in trunk
WebCore:
2009-04-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25342
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
Chromium async/out-of-process version of WebInspector is currently not based on
InspectorController. The reason was that we did not want to interfere with
the unforking effort, yet wanted to experiment. So we came up with these
agents concept that basically mimic InspectorController, but separating 'agent'
nature from the 'transport'. Now that InspectorController is unforked, I am
planning to bring these concepts into the WebKit land and use what we have in
Chromium as a proof of concept / experimental playground.
- loader/EmptyClients.h: added MessageSource and MessageLevel parameters. (WebCore::EmptyChromeClient::addMessageToConsole): ditto
- page/ChromeClient.h: ditto
- page/Console.cpp: Used new method signature. (WebCore::Console::addMessage): ditto
WebKit/gtk:
2009-04-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25342
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::addMessageToConsole):
- WebCoreSupport/ChromeClientGtk.h:
WebKit/mac:
2009-04-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25342
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole):
WebKit/win:
2009-04-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25342
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::addMessageToConsole):
- WebCoreSupport/WebChromeClient.h:
WebKit/wx:
2009-04-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25342
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::addMessageToConsole):
- WebKitSupport/ChromeClientWx.h:
- 9:36 AM Changeset in webkit [43062] by
-
- 9 edits in trunk
WebCore:
Reviewed by Simon Fraser.
- fix https://bugs.webkit.org/show_bug.cgi?id=25476 <rdar://problem/6841919> REGRESSION (r42987): Welcome to Safari 4 animation is jittery
Reverted r42987.
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
LayoutTests:
Reviewed by Simon Fraser.
- updated results for https://bugs.webkit.org/show_bug.cgi?id=25476 <rdar://problem/6841919> REGRESSION (r42987): Welcome to Safari 4 animation is jittery
- platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/mac/svg/custom/focus-ring-expected.checksum:
- platform/mac/svg/custom/focus-ring-expected.png:
- platform/mac/svg/custom/image-small-width-height-expected.checksum:
- platform/mac/svg/custom/image-small-width-height-expected.png:
- 9:20 AM Changeset in webkit [43061] by
-
- 8 edits2 adds in trunk
WebCore:
2009-04-30 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak
<rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
https://bugs.webkit.org/show_bug.cgi?id=21193
Some websites use for attributes in script elements to specify events that the script
should be run for. One example is greekembassy.org which has the following in their <head>:
<script for=window event=onresize>
location.reload(false);
</script>
Since we don't support the full for attribute syntax, we would just blissfully ignore the
condition and execute the code unconditionally. This caused breakage on multiple real-world
sites besides greekembassy.org.
https://bugs.webkit.org/show_bug.cgi?id=16915 and <rdar://problem/4471751> track adding full
support for the for attribute in scripts. In the meantime it's best to not execute them
unconditionally.
Test: fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::shouldExecuteAsJavaScript): After all other checks have passed, only return true if there is no for attribute in the script element.
- dom/ScriptElement.h:
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::forAttributeValue): Return the attribute value, if any.
- html/HTMLScriptElement.h:
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::forAttributeValue): Return an empty string (like the other attribute getters do for SVGScriptElement)
- svg/SVGScriptElement.h:
LayoutTests:
2009-04-30 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak
Test for <rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
https://bugs.webkit.org/show_bug.cgi?id=21193
- fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt: Added.
- fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html: Added.
- 8:56 AM Changeset in webkit [43060] by
-
- 2 edits in trunk/LayoutTests
2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Skip one more video test that sometimes fails.
- platform/gtk/Skipped:
- 8:43 AM Changeset in webkit [43059] by
-
- 2 edits in trunk/LayoutTests
Add a sometimes-timing-out test to the Windows skipped file
See Bug 25483: http/tests/navigation/redirect-cycle.html sometimes
times out on Windows
<https://bugs.webkit.org/show_bug.cgi?id=25483>
- platform/win/Skipped: Added http/tests/navigation/redirect-cycle.html.
- 8:01 AM Changeset in webkit [43058] by
-
- 4 edits in trunk/WebKit/qt
2009-04-30 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Implement encloseContentsWith and rename wrap to encloseWith.
Also in encloseWith, make sure that you cannot enclose with
non-enclosable elements.
- 7:56 AM Changeset in webkit [43057] by
-
- 2 edits in trunk/LayoutTests
2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Skip two more tests that I had accidentaly generated results for,
locally.
- platform/gtk/Skipped:
- 7:06 AM Changeset in webkit [43056] by
-
- 2 edits in trunk/LayoutTests
2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Also disable new tests, and tests that are using stderr.
- platform/gtk/Skipped:
- 6:12 AM Changeset in webkit [43055] by
-
- 2 edits in trunk/LayoutTests
2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disabling more video tests that seem to come and go.
- platform/gtk/Skipped:
- 5:06 AM Changeset in webkit [43054] by
-
- 2 edits in trunk/LayoutTests
2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Hopefully last try making the bot green.
- platform/gtk/Skipped:
- 4:09 AM Changeset in webkit [43053] by
-
- 2 edits in trunk/LayoutTests
2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Exclude canvas-putImageData.html from the skipped list since
Canvas's putImageData is implemented in r41355 already.
- platform/qt/Skipped: Removed canvas-putImageData.html.
- 3:26 AM Changeset in webkit [43052] by
-
- 8 edits3 adds in trunk
2009-04-30 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin Adler.
The Qt API exposes a global history patch CSSStyleSelector to make API consumers work again
The QtWebKit port made the mistake of exposing a global history. This broke
with the addition of PageGroup and LinkHash. This needs to be repaired
for Qt4.5.
Add a function to LinkHash.cpp that is resolving a URL. Use this
function from within CSSStyleSelector to forward the url to the
QWebHistoryInterface API.
It is sad that there is a path within visitedLinkHash which is now
doing a memcpy, it is sad to add a PLATFORM(QT) define to CSSStyleSelector
and using QtWebKit types within WebCore is a layering violation as well.
PageGroup::setShouldTrackVisitedLinks is currently not enabled. For
Qt4.6 a second version of the QWebHistoryInterface is going to be
added which will fix things up.
- 3:08 AM Changeset in webkit [43051] by
-
- 3 edits in trunk/WebCore
Fix the Qt build.
- 3:04 AM Changeset in webkit [43050] by
-
- 2 edits in trunk/WebKit/qt
2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
Unreviewed build fix, after r43035.
Temporarily use Position::deprecatedEditingOffset().
- Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
- 3:00 AM Changeset in webkit [43049] by
-
- 2 edits in trunk/WebCore
2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
Unreview build fix after r43037.
Use MarkedArgumentBuffer instead of ArgList.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute):
- 2:15 AM Changeset in webkit [43048] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Alexey Proskuryakov.
- speed up string concatenation by reorganizing some simple cases
0.7% SunSpider speedup
- runtime/UString.cpp: (JSC::concatenate): Put fast case for appending a single character before the empty string special cases; streamline code a bit to delay computing values that are not needed in the fast path.
- 12:52 AM Changeset in webkit [43047] by
-
- 6 edits in trunk/JavaScriptCore
2009-04-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Maciej Stachowiak.
Add SamplingFlags mechanism.
This mechanism allows fine-grained JSC and JavaScript program aware
performance measurement. The mechanism provides a set of 32 flags,
numbered #1..#32. Flag #16 is initially set, and all other flags
are cleared. Flags may be set and cleared from within
Enable by setting ENABLE_SAMPLING_FLAGS to 1 in wtf/Platform.h.
Disabled by default, no performance impact. Flags may be modified
by calling SamplingFlags::setFlag() and SamplingFlags::clearFlag()
from within JSC implementation, or by calling setSamplingFlag() and
clearSamplingFlag() from JavaScript.
The flags are sampled with a frequency of 10000Hz, and the highest
set flag in recorded, allowing multiple events to be measured (with
the highest flag number representing the highest priority).
Disabled by default; no performance impact.
- JavaScriptCore.exp:
- bytecode/SamplingTool.cpp: (JSC::SamplingFlags::sample): (JSC::SamplingFlags::start): (JSC::SamplingFlags::stop): (JSC::SamplingThread::threadStartFunc): (JSC::SamplingThread::start): (JSC::SamplingThread::stop): (JSC::ScopeSampleRecord::sample): (JSC::SamplingTool::doRun): (JSC::SamplingTool::sample): (JSC::SamplingTool::start): (JSC::SamplingTool::stop):
- bytecode/SamplingTool.h: (JSC::SamplingFlags::setFlag): (JSC::SamplingFlags::clearFlag): (JSC::SamplingTool::SamplingTool):
- jsc.cpp: (GlobalObject::GlobalObject): (functionSetSamplingFlag): (functionClearSamplingFlag): (runWithScripts):
- wtf/Platform.h:
Apr 29, 2009:
- 11:47 PM Changeset in webkit [43046] by
-
- 6 edits2 adds in trunk
WebCore:
2009-04-29 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25440
setTimeout should stringify non-string/non-function first arguments
Test: fast/dom/Window/setTimeout-string-argument.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create):
- bindings/js/ScheduledAction.h:
LayoutTests:
2009-04-29 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Test for https://bugs.webkit.org/show_bug.cgi?id=25440
setTimeout should stringify non-string/non-function first arguments
- fast/dom/Window/setTimeout-string-argument-expected.txt: Added.
- fast/dom/Window/setTimeout-string-argument.html: Added.
- 8:38 PM Changeset in webkit [43045] by
-
- 3 edits in trunk/WebKit/mac
More build fixing after r43037.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):
- 8:03 PM Changeset in webkit [43044] by
-
- 13 edits2 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- WebCore part of <rdar://problem/6609509> Select All and then Delete should put Mail editing back into the same state as a new message
Test: editing/deleting/in-visibly-empty-root.html
- WebCore.base.exp: Exported VisibleSelection::isAll(bool).
- editing/SelectionController.h: (WebCore::SelectionController::isAll): Added. Calls through to VisibleSelection.
- editing/TypingCommand.cpp: (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children of the root editable element the selection is in, other than a placeholder. Returns true iff it did anything. (WebCore::TypingCommand::deleteKeyPressed): When there is only a single visible position in the root editable element, but it has children other than a placeholder, remove those children.
- editing/TypingCommand.h:
- editing/VisiblePosition.h: Added a StayInEditableContent enum and a FIXME.
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): Added. Returns whether the selection encompasses all visible positions, either in the document or in the editable root.
- editing/VisibleSelection.h:
WebKit/mac:
Reviewed by Simon Fraser.
- WebKit part of <rdar://problem/6609509> Select All and then Delete should put Mail editing back into the same state as a new message
- WebView/WebView.mm: (-[WebView _selectionIsCaret]): Added. (-[WebView _selectionIsAll]): Added. Returns whether the selection encompasses the entire document.
- WebView/WebViewPrivate.h:
LayoutTests:
Reviewed by Simon Fraser.
- test and updated results for <rdar://problem/6609509> Select All and then Delete should put Mail editing back into the same state as a new message
- editing/deleting/in-visibly-empty-root-expected.txt: Added.
- editing/deleting/in-visibly-empty-root.html: Added.
- platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
- 7:19 PM Changeset in webkit [43043] by
-
- 3 edits in trunk/JavaScriptCore
2009-04-29 Sam Weinig <sam@webkit.org>
Another attempt to fix the windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 7:12 PM Changeset in webkit [43042] by
-
- 2 edits in trunk/WebCore
2009-04-29 Sam Weinig <sam@webkit.org>
Fix style nit.
- editing/visible_units.cpp: (WebCore::getLeafBoxesInLogicalOrder):
- 7:10 PM Changeset in webkit [43041] by
-
- 3 edits in trunk/JavaScriptCore
2009-04-29 Sam Weinig <sam@webkit.org>
Try and fix the windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 7:02 PM Changeset in webkit [43040] by
-
- 2 edits in trunk/WebCore
2009-04-29 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
For now just drop the deferred layout on the floor, since it causes an infinite hang in mail. Even
trying to schedule a relayout for later leaves you in a state where you hit the needsLayout painting
assertions.
Basically what Mail is doing is crazy, and we can't support it other than to just drop the last layout
and not do it (which is basically what was happening before).
- page/FrameView.cpp: (WebCore::FrameView::setContentsSize): (WebCore::FrameView::needsLayout):
- 6:35 PM Changeset in webkit [43039] by
-
- 7 edits in trunk
WebCore:
2009-04-29 Douglas Davidson <ddavidso@apple.com>
Reviewed by Justin Garcia.
<rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly
Updates to the text checking code to enable text checking even if spellchecking is turned off
and fix an off-by-one error in selection handling.
- editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar):
- editing/Editor.h:
- editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping):
WebKit/mac:
2009-04-29 Douglas Davidson <ddavidso@apple.com>
Reviewed by Justin Garcia.
<rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly
- WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView orderFrontSubstitutionsPanel:]):
- WebView/WebView.mm: (-[WebView validateUserInterfaceItemWithoutDelegate:]):
- 6:34 PM Changeset in webkit [43038] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-29 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver "Peg-Leg" Hunt.
Coallesce input checking and reduce futzing with the index position
between alternatives and iterations of the main loop of a regex,
when run in YARR.
Consider the following regex: /foo|bar/
Prior to this patch, this will be implemented something like this pseudo-code description:
loop:
check_for_available_input(3) this increments the index by 3, for the first alterantive.
if (available) { test "foo" }
decrement_index(3)
check_for_available_input(3) this increments the index by 3, for the second alterantive.
if (available) { test "bar" }
decrement_index(3)
check_for_available_input(1) can we loop again?
if (available) { goto loop }
With these changes it will look more like this:
check_for_available_input(3) this increments the index by 3, for the first alterantive.
if (!available) { goto fail }
loop:
test "foo"
test "bar"
check_for_available_input(1) can we loop again?
if (available) { goto loop }
fail:
This gives about a 5% gain on v8-regex, no change on Sunspider.
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracksTo): (JSC::Yarr::RegexGenerator::generateDisjunction):
- 6:21 PM Changeset in webkit [43037] by
-
- 46 edits in trunk
Clean up ArgList to be a trivial type
Reviewed by Gavin Barraclough
Separate out old ArgList logic to handle buffering and marking arguments
into a distinct MarkedArgumentBuffer type. ArgList becomes a trivial
struct of a pointer and length.
- 6:16 PM Changeset in webkit [43036] by
-
- 2 edits in trunk/WebCore
No review, build fix only.
Fix m_offset uses added while I wasn't looking.
- editing/visible_units.cpp: (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
- 6:09 PM Changeset in webkit [43035] by
-
- 31 edits in trunk
Reviewed by Darin Adler.
Make m_offset private and change all callers to use deprecatedEditingOffset().
https://bugs.webkit.org/show_bug.cgi?id=25472
Per Darin's suggestion, this was just a simple search replace
of .m_offset with .deprecatedEditingOffset().
There was one change in InsertParagraphSeparatorCommand::doApply to use
Position::moveToOffset(0) instead of .m_offset = 0;
- dom/Position.cpp: (WebCore::Position::rendersInDifferentPosition): (WebCore::Position::leadingWhitespacePosition):
- dom/Position.h: (WebCore::Position::deprecatedEditingOffset): (WebCore::Position::moveToOffset): (WebCore::operator==):
- dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator):
- dom/Range.cpp: (WebCore::Range::create): (WebCore::Range::compareBoundaryPoints):
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyleToRange): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::nodeFullySelected): (WebCore::ApplyStyleCommand::nodeFullyUnselected): (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): (WebCore::ApplyStyleCommand::joinChildTextNodes):
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::positionOutsideTabSpan): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): (WebCore::CompositeEditCommand::deleteInsignificantText): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
- editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): (WebCore::updatePositionForTextRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace):
- editing/Editor.cpp: (WebCore::Editor::setComposition): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::getCompositionSelection):
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): (WebCore::InsertTextCommand::input): (WebCore::InsertTextCommand::insertTab):
- editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
- editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::debugPosition): (WebCore::makeRange): (WebCore::setStart): (WebCore::setEnd):
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange): (WebCore::makeSearchRange): (WebCore::VisibleSelection::debugPosition): (WebCore::VisibleSelection::showTreeForThis):
- editing/htmlediting.cpp: (WebCore::comparePositions): (WebCore::rangeCompliantEquivalent):
- editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endPositionForLine): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
- page/AccessibilityObject.cpp: (WebCore::updateAXLineStartForVisiblePosition):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
- page/DOMSelection.cpp: (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::extentOffset):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
- page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
- page/mac/AccessibilityObjectWrapper.mm: (textMarkerForVisiblePosition): (visiblePositionForTextMarker):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::indexForVisiblePosition):
- rendering/RenderTreeAsText.cpp: (WebCore::writeSelection):
- 6:07 PM Changeset in webkit [43034] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
Reviewed by Oliver Hunt.
Re-write image-clipped-hit.svg to be dumpAsText() (and clean up the code to be less insane)
- platform/mac/svg/custom/image-clipped-hit-expected.checksum: Removed.
- platform/mac/svg/custom/image-clipped-hit-expected.png: Removed.
- platform/mac/svg/custom/image-clipped-hit-expected.txt: Removed.
- platform/qt/svg/custom/image-clipped-hit-expected.txt: Removed.
- svg/custom/image-clipped-hit.svg:
- 5:51 PM Changeset in webkit [43033] by
-
- 2 edits in trunk/LayoutTests
2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Second try at making the bot green.
- platform/gtk/Skipped:
- 5:48 PM Changeset in webkit [43032] by
-
- 7 edits2 adds in trunk
WebCore:
2009-04-29 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix https://bugs.webkit.org/show_bug.cgi?id=24168
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
Test: editing/selection/home-end.html
- editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary (WebCore::SelectionController::modifyExtendingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
- editing/visible_units.cpp: (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order. (WebCore::getLogicalStartBoxAndNode): Added. (WebCore::getLogicalEndBoxAndNode): Added. (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine. (WebCore::logicalStartOfLine): Added. Similar to startOfLine. (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine. (WebCore::inSameLogicalLine): Added. (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
- editing/visible_units.h:
LayoutTests:
2009-04-29 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix https://bugs.webkit.org/show_bug.cgi?id=24168
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
- editing/selection/extend-selection-expected.txt: Added result for extend in lineBoundary.
- editing/selection/extend-selection.html: Added test cases and script for extend in lineBoundary.
- editing/selection/home-end-expected.txt: Added.
- editing/selection/home-end.html: Added.
- 5:24 PM Changeset in webkit [43031] by
-
- 5 edits in trunk/LayoutTests
2009-04-29 Ojan Vafai <ojan@chromium.org>
Reviewed by NOBODY (OOPS!).
Fix this test to only use a setTimeout in IE.
It doesn't need a timeout in WebKit and the
timeout requires using waitUntilDone/notifyDone,
which doesn't play nicely with JS tests.
- fast/forms/resources/textarea-metrics.js: (assertTextareaMetrics):
- fast/forms/textarea-metrics-expected.txt:
- platform/win/fast/forms/textarea-metrics-expected.txt:
- platform/win/Skipped:
- 4:52 PM Changeset in webkit [43030] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
Put this file in the right place to fix the bot failure.
- platform/mac-tiger/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/platform/mac-tiger/text-control-intrinsic-widths-expected.txt.
- 4:50 PM Changeset in webkit [43029] by
-
- 2 edits in trunk/LayoutTests
2009-04-29 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
Skip fast/forms/textarea-metrics.html. It's printing the TEST PASSED
before the test is finished. There's a race with any JS tests that
use setTimeout. Fortunately, this test doesn't need the setTimeout,
so it's easy to fix.
- platform/win/Skipped:
- 4:34 PM Changeset in webkit [43028] by
-
- 7 edits2 deletes in trunk
2009-04-29 Eric Seidel <eric@webkit.org>
No review, rolling out a patch.
New tests failed because I removed the tabs from them
when landing (since we avoid tabs in WebKit files).
I couldn't tell if the new results were correct with
spaces or not.
- editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): (WebCore::SelectionController::modifyMovingForward): (WebCore::SelectionController::modifyExtendingBackward): (WebCore::SelectionController::modifyMovingBackward):
- editing/visible_units.cpp:
- editing/visible_units.h:
- 4:27 PM Changeset in webkit [43027] by
-
- 7 edits2 deletes in trunk
2009-04-29 Eric Seidel <eric@webkit.org>
No review, rolling out a patch.
Revert 43020 as it caused accessibility/lists.html to fail
and no one is around to tell me if it's a progression or not.
- page/AccessibilityObject.h: (WebCore::):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::roleValue): (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
- page/mac/AccessibilityObjectWrapper.mm: (RoleEntry::):
- 4:21 PM Changeset in webkit [43026] by
-
- 3 edits in trunk/WebCore
2009-04-29 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6828164>, Mail hits the !root->needsLayout() assert because it re-marks the FrameView for layout
when the FrameView is resized. This bug was exposed by the elimination of the separate WebKit layout
flag on Mac.
FrameView now defers setNeedsLayouts during size changes. Once all of the size changes are finished (including re-entrant ones
from WebDynamicScrollbarsView and ScrollView::updateScrollbars) we then do a layout if necessary.
- page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::setContentsSize): (WebCore::FrameView::layout): (WebCore::FrameView::needsLayout): (WebCore::FrameView::setNeedsLayout):
- page/FrameView.h:
- 4:20 PM Changeset in webkit [43025] by
-
- 2 edits in trunk/WebKit/mac
2009-04-29 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Fix a bug in the bounds checking for setNeedsLayout dirtying when a WebView's size changes. The superview
of the WebView was being incorrectly checked instead of the WebView itself.
- WebView/WebView.mm: (-[WebView _boundsChanged]):
- 4:09 PM Changeset in webkit [43024] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix ChangeLog description.
- 4:04 PM Changeset in webkit [43023] by
-
- 1 edit1 add in trunk/LayoutTests
2009-04-29 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
Add expected results for failing tests.
- platform/win/fast/forms/textarea-metrics-expected.txt: Issue with running JS tests that use setTimeout. See https://bugs.webkit.org/show_bug.cgi?id=25469
- 3:48 PM Changeset in webkit [43022] by
-
- 3 edits in trunk/WebCore
2009-04-29 Antony Sargent <asargent@chromium.org>
Reviewed by Dimitri Glazkov and Eric Seidel.
Use AtomicString to speed up window and document interceptors.
https://bugs.webkit.org/show_bug.cgi?id=25275
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_DELETER): (WebCore::NAMED_PROPERTY_GETTER):
- 3:28 PM Changeset in webkit [43021] by
-
- 2 edits in trunk/WebKitTools
Update build.webkit.org configuration for the addition of the new GTK buildbot.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:22 PM Changeset in webkit [43020] by
-
- 7 edits2 adds in trunk
2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
Reviewed by Jon Honeycutt.
Add a new accessibility role for list items. Part of
http://bugs.webkit.org/show_id.cgi?id=20013
- win/AccessibleBase.cpp: (MSAARole): Return ROLE_SYSTEM_LISTITEM for list item role.
- 3:16 PM Changeset in webkit [43019] by
-
- 7 edits2 adds in trunk
2009-04-29 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix https://bugs.webkit.org/show_bug.cgi?id=24168
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
Test: editing/selection/home-end.html
- editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary (WebCore::SelectionController::modifyExtendingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
- editing/visible_units.cpp: (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order. (WebCore::getLogicalStartBoxAndNode): Added. (WebCore::getLogicalEndBoxAndNode): Added. (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine. (WebCore::logicalStartOfLine): Added. Similar to startOfLine. (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine. (WebCore::inSameLogicalLine): Added. (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
- editing/visible_units.h:
- 3:14 PM Changeset in webkit [43018] by
-
- 4 edits3 adds in trunk
2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=23583
Populate role attribute for document objects correctly
on Windows platform.
- AccessibleDocument.cpp: (AccessibleDocument::role): Return ROLE_SYSTEM_DOCUMENT for document objects on windows. (Matching Firefox).
- AccessibleDocument.h: Add the role function prototype in header file.
- 3:11 PM Changeset in webkit [43017] by
-
- 2 edits in trunk/WebKitTools
Ignore the --use-remote-links-to-tests option for GTK as it leads to
perl errors being spewed at the end of run-webkit-tests.
- Scripts/run-webkit-tests:
- 2:54 PM Changeset in webkit [43016] by
-
- 2 edits in trunk/WebKitTools
Implement test-result-archive for GTK.
- BuildSlaveSupport/test-result-archive:
- 2:38 PM Changeset in webkit [43015] by
-
- 4 edits4 adds in trunk/WebKit/qt
2009-03-27 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Simon Hausmann.
Update the page actions when a finishing loading even if the frame is
not the top frame such as when browsing inside of a website with frames.
https://bugs.webkit.org/show_bug.cgi?id=24890
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
- tests/qwebpage/frametest/frame_a.html: Added.
- tests/qwebpage/frametest/index.html: Added.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::backActionUpdate):
- 2:31 PM Changeset in webkit [43014] by
-
- 6 edits in trunk
2009-04-29 Mike Belshe <mike@belshe.com>
Reviewed by Eric Seidel.
Update location while page is loading.
https://bugs.webkit.org/show_bug.cgi?id=21597
Tested by:
- fast/dom/location-new-window-no-crash
- fast/dom/Window/window-open-pending-url
- page/Location.cpp:
- 2:28 PM Changeset in webkit [43013] by
-
- 2 edits in trunk/LayoutTests
2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Mark Rowe.
Disable failing tests to make the bot green for its new debut, so
that we can more easily track regressions.
- platform/gtk/Skipped:
- 2:25 PM Changeset in webkit [43012] by
-
- 1 edit3 adds in trunk/WebCore
2009-04-29 Feng Qian <feng@chromium.org>
Reviewed by Darin Adler.
Add Android port files to WebCore/platform.
https://bugs.webkit.org/show_bug.cgi?id=23296
- platform/android: Added.
- platform/android/ClipboardAndroid.cpp: Added.
- platform/android/ClipboardAndroid.h: Added.
- 2:23 PM Changeset in webkit [43011] by
-
- 1 edit4 adds in trunk/WebCore
2009-04-29 Feng Qian <feng@chromium.org>
Reviewed by Darin Adler.
Add Android-specific files to the WebCore/page directory.
https://bugs.webkit.org/show_bug.cgi?id=23295
- page/android: Added.
- page/android/DragControllerAndroid.cpp: Added.
- page/android/EventHandlerAndroid.cpp: Added.
- page/android/InspectorControllerAndroid.cpp: Added.
- 2:00 PM Changeset in webkit [43010] by
-
- 7 edits2 adds in trunk/WebCore
2009-04-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Extract PageGroupLoadDeferrer from Chrome.cpp
- GNUmakefile.am: added PageGroupLoadDeferrer
- WebCore.pro: ditto
- WebCore.scons: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- WebCoreSources.bkl: ditto
- page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
- page/PageGroupLoadDeferrer.cpp: Added. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- page/PageGroupLoadDeferrer.h: Added.
- 1:55 PM Changeset in webkit [43009] by
-
- 8 edits in trunk/WebKit/mac
Reviewed by Anders Carlson.
Allow WKN_CheckIfAllowedToLoadURL() to take an optional void* context parameter.
- Plugins/WebNetscapeContainerCheckContextInfo.h:
- Plugins/WebNetscapeContainerCheckContextInfo.mm: (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): (-[WebNetscapeContainerCheckContextInfo callback]): (-[WebNetscapeContainerCheckContextInfo context]):
- Plugins/WebNetscapeContainerCheckPrivate.h:
- Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs):
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
- Plugins/npapi.mm: (WKN_CheckIfAllowedToLoadURL):
- 1:43 PM Changeset in webkit [43008] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-29 Laszlo Gombos <Laszlo Gombos>
Reviewed by Sam Weinig.
Fix Qt build when ENABLE_JIT is explicitly set to 1
to overrule defaults.
- JavaScriptCore.pri:
- 1:31 PM Changeset in webkit [43007] by
-
- 558 edits1 copy191 adds in trunk
Reviewed by Dan Bernstein.
Make textarea and text input metrics more closely match IEs.
This involves:
-set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
-set textarea width to cols*avgCharWidth
-Make default CSS match IEs
-Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
Those values for textarea and inputs were derived by doing a ton of manual
testing of IE's width values for various textareas and fonts. On Windows we match
IE exactly except for a couple fonts of the ~12 tested.
To get the average and max character width of a font, we do the following
for each platform:
-Win: TextMetrics expose avgCharWidth and maxCharWidth
-SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
-Linux: avgCharWidth = width of an '0', fallback on m_xHeight
maxCharWidth = max of avgCharWidth and m_ascent
-Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
If either one is non-positive, then calculate the value using the Linux approach.
Tests: fast/forms/text-control-intrinsic-widths.html
fast/forms/textarea-metrics.html
svg/custom/svg-fonts-in-text-controls.html
- css/html4.css:
- css/themeWin.css:
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):
- platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::maxCharWidth): (WebCore::SimpleFontData::avgCharWidth):
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
- platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- 1:25 PM Changeset in webkit [43006] by
-
- 5 edits in trunk
Crash in profiler due to incorrect assuming displayName would be a string.
Reviewed by Steve Falkenburg
Fixed by adding a type guard.
- 1:23 PM Changeset in webkit [43005] by
-
- 2 edits in trunk/WebCore
2009-04-29 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
- bindings/objc/DOMCSS.mm: (kitClass): Added CSS_INITIAL to the switch statement, and changed to use the WebCore type and not the binding type.
- 1:21 PM Changeset in webkit [43004] by
-
- 2 edits in trunk/WebCore
2009-04-29 John Abd-El-Malek <jam@google.com>
Reviewed by Dimitri Glazkov.
Reverted my previous change to add resetChromiumPluginCache().
https://bugs.webkit.org/show_bug.cgi?id=25318
- plugins/chromium/PluginDataChromium.cpp:
- 1:21 PM Changeset in webkit [43003] by
-
- 2 edits in trunk/WebCore
2009-04-29 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail
Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>
Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Remove the preload referenced check.
- 1:14 PM Changeset in webkit [43002] by
-
- 3 edits in trunk/WebCore
2009-04-29 Alpha Lam <hclam@chromium.org>
Reviewed by Dimitri Glazkov.
Provide style sheet for UI controls of media elements for Chromium port.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):
- 1:12 PM Changeset in webkit [43001] by
-
- 3 edits1 add in trunk/WebCore
2009-04-29 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Adler.
Expose sudden termination to Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=25457
- platform/SuddenTermination.h:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/SuddenTerminationChromium.cpp: Added. (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
- 1:00 PM Changeset in webkit [43000] by
-
- 2 edits in trunk/WebCore
2009-04-29 Sam Weinig <sam@webkit.org>
Reviewed by Dimitri Glazkov.
Remove unused EventListeners.
- page/DOMWindow.idl:
- 11:38 AM Changeset in webkit [42999] by
-
- 2 edits in trunk/WebKit/mac
2009-04-29 David Hyatt <hyatt@apple.com>
Reviewed by John Sullivan.
Fix for <rdar://problem/6835573>, Find Banner turns invisible when WebView is resized. Make sure
not to resize the interior views of a WebView in response to its bounds changing when not using
viewless WebKit. Auto-resizing rules were already in place to handle size adjustments for us.
Just mark as needing layout and do nothing else.
This does mean viewless WebKit is broken with the Find Banner, and that will likely require a
Safari change (using a new API that will enable clients to define the edges of the content area as offsets
from the sides of the WebView).
- WebView/WebView.mm: (-[WebView _boundsChanged]):
- 10:41 AM Changeset in webkit [42998] by
-
- 2 edits in trunk/LayoutTests
2009-04-29 Eric Carlson <eric.carlson@apple.com>
Disable media/video-zoom-controls.html on Windows for now.
- platform/win/Skipped: add media/video-zoom-controls.html.
- 10:38 AM Changeset in webkit [42997] by
-
- 2 edits in trunk/WebCore
Reveal current execution line once SourceFrame content is loaded.
Reviewed by Timothy Hatcher.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- 10:27 AM Changeset in webkit [42996] by
-
- 4 edits in trunk
WebCore:
2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Fraser.
[Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
the default values of canvas attributes.
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBufferData::ImageBufferData):
LayoutTests:
2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Fraser.
Updated expected results after Qt's GraphicsContext fixes.
- platform/qt/fast/canvas/set-colors-expected.txt:
- 7:56 AM QtWebKitTodo edited by
- (diff)
- 6:55 AM Changeset in webkit [42995] by
-
- 4 edits in trunk/WebKit/qt
2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
Implement QWebElement::evaluateScript.
- Api/qwebelement.cpp: (setupScriptContext): (QWebElement::evaluateScript):
- Api/qwebelement.h:
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::evaluateScript):
- 6:46 AM Changeset in webkit [42994] by
-
- 7 edits in trunk/WebKit/qt
2009-04-29 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Replaced QWebElementCollection with QList<QWebElement>.
- 3:20 AM QtWebKitTodo edited by
- (diff)
- 3:09 AM QtWebKitTodo edited by
- (diff)
Apr 28, 2009:
- 11:49 PM QtWebKitContrib edited by
- (diff)
- 11:38 PM Changeset in webkit [42993] by
-
- 2 edits in trunk/WebCore
Fix the Qt build
- 11:31 PM Changeset in webkit [42992] by
-
- 2 edits in trunk/LayoutTests
Fix the test for <https://bugs.webkit.org/show_bug.cgi?id=25420> - I broke it when
experimenting with other aspects of the issue, so it didn't check what it should have checked.
- http/tests/xmlhttprequest/detaching-frame-2.html:
- 11:19 PM Changeset in webkit [42991] by
-
- 2 edits in trunk/JavaScriptGlue
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Missed one.
- UserObjectImp.cpp: (UserObjectImp::callAsFunction):
- 11:08 PM Changeset in webkit [42990] by
-
- 2 edits in trunk/WebCore
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Missed one.
- bindings/scripts/CodeGeneratorJS.pm:
- 11:07 PM Changeset in webkit [42989] by
-
- 88 edits in trunk
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Removed scaffolding supporting dynamically converting between 32bit and
64bit value representations.
- API/JSCallbackConstructor.cpp: (JSC::constructJSCallback):
- API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
- API/JSCallbackObjectFunctions.h: (JSC::::construct): (JSC::::call):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getConstant):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitEqualityOp):
- interpreter/CallFrame.cpp: (JSC::CallFrame::thisValue):
- interpreter/Interpreter.cpp: (JSC::Interpreter::callEval): (JSC::Interpreter::throwException): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
- interpreter/Register.h: (JSC::Register::): (JSC::Register::Register): (JSC::Register::jsValue): (JSC::Register::marked): (JSC::Register::mark): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::arguments): (JSC::Register::callFrame): (JSC::Register::codeBlock): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain): (JSC::Register::vPC):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_load_varargs): (JSC::JITStubs::cti_op_call_eval):
- jsc.cpp: (functionPrint): (functionDebug): (functionRun): (functionLoad):
- runtime/ArgList.h: (JSC::ArgList::at):
- runtime/Arguments.cpp: (JSC::Arguments::copyToRegisters): (JSC::Arguments::fillArgList): (JSC::Arguments::getOwnPropertySlot):
- runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncReduce): (JSC::arrayProtoFuncReduceRight): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
- runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
- runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::dateParse): (JSC::dateUTC):
- runtime/DatePrototype.cpp: (JSC::formatLocaleDate): (JSC::fillStructuresUsingTimeArgs): (JSC::fillStructuresUsingDateArgs): (JSC::dateProtoFuncSetTime): (JSC::dateProtoFuncSetYear):
- runtime/ErrorConstructor.cpp: (JSC::constructError):
- runtime/FunctionConstructor.cpp: (JSC::constructFunction):
- runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
- runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::constructArray):
- runtime/JSArray.h:
- runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::decode): (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
- runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
- runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::construct):
- runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor): (JSC::callNumberConstructor):
- runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
- runtime/ObjectConstructor.cpp: (JSC::constructObject):
- runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable):
- runtime/PropertySlot.h: (JSC::PropertySlot::getValue):
- runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
- runtime/RegExpObject.cpp: (JSC::RegExpObject::match):
- runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
- runtime/StringConstructor.cpp: (JSC::stringFromCharCodeSlowCase): (JSC::stringFromCharCode): (JSC::constructWithStringConstructor): (JSC::callStringConstructor):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):
WebCore:
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Removed scaffolding supporting dynamically converting between 32bit and
64bit value representations.
- bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow): (WebCore::JSCanvasRenderingContext2D::createPattern): (WebCore::JSCanvasRenderingContext2D::putImageData): (WebCore::JSCanvasRenderingContext2D::fillText): (WebCore::JSCanvasRenderingContext2D::strokeText):
- bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem): (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMStringListCustom.cpp: (WebCore::JSDOMStringList::item):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog): (WebCore::JSDOMWindow::postMessage): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
- bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNode): (WebCore::JSElement::setAttributeNS): (WebCore::JSElement::setAttributeNodeNS):
- bindings/js/JSGeolocationCustom.cpp: (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite):
- bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::setSelectionRange):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::add):
- bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove):
- bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
- bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::highlightDOMNode): (WebCore::JSInspectorController::addResourceSourceToFrame): (WebCore::JSInspectorController::addSourceToFrame): (WebCore::JSInspectorController::getResourceDocumentNode): (WebCore::JSInspectorController::search): (WebCore::JSInspectorController::databaseTableNames): (WebCore::JSInspectorController::setting): (WebCore::JSInspectorController::setSetting): (WebCore::JSInspectorController::wrapCallback):
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild): (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::acceptNode):
- bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList):
- bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::construct): (WebCore::JSQuarantinedObjectWrapper::call):
- bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
- bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::convertToSpecifiedUnits):
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::rotateFromVector):
- bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::JSSVGPathSegList::initialize): (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem): (WebCore::JSSVGPathSegList::appendItem):
- bindings/js/JSSVGPointListCustom.cpp: (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
- bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
- bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix):
- bindings/js/JSWebKitPointConstructor.cpp: (WebCore::constructWebKitPoint):
- bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::importScripts): (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener): (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument): (WebCore::JSXSLTProcessor::setParameter): (WebCore::JSXSLTProcessor::getParameter): (WebCore::JSXSLTProcessor::removeParameter):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create): (WebCore::ScheduledAction::ScheduledAction):
- bindings/js/ScheduledAction.h:
- bindings/js/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame):
- bindings/js/ScriptCallFrame.h:
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::initialize):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod): (JSC::Bindings::CInstance::invokeDefaultMethod): (JSC::Bindings::CInstance::invokeConstruct):
- bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
- bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod):
WebKit/mac:
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Removed scaffolding supporting dynamically converting between 32bit and
64bit value representations.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::marshalValues):
- 10:56 PM Changeset in webkit [42988] by
-
- 2 edits in trunk/JavaScriptCore
A little more hardening for UString
Reviewed by Maciej Stachowiak.
Revised fix for <rdar://problem/5861045> in r42644.
- runtime/UString.cpp: (JSC::newCapacityWithOverflowCheck): Added. (JSC::concatenate): Used newCapacityWithOverflowCheck(). (JSC::UString::append): Ditto.
- 10:52 PM Changeset in webkit [42987] by
-
- 9 edits in trunk
2009-04-28 David Carson <dacarson@apple.com>
Reviewed by David Hyatt.
Restore alignment to device pixel boundaries.
https://bugs.webkit.org/show_bug.cgi?id=25458
Adjust the adjusted destination rect to be device pixel aligned.
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
2009-04-28 David Carson <dacarson@apple.com>
Reviewed by David Kilzer.
Restore alignment to device pixel boundaries.
https://bugs.webkit.org/show_bug.cgi?id=25458
Updated test results with progressions.
- platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Yin-yang image shifted slightly to pixel boundaries.
- platform/mac/svg/custom/focus-ring-expected.checksum:
- platform/mac/svg/custom/focus-ring-expected.png: Focus rings drawn around rotated "focus text" and checkered images shifted slightly to pixel boundaries.
- platform/mac/svg/custom/image-small-width-height-expected.checksum:
- platform/mac/svg/custom/image-small-width-height-expected.png: Checkered images shifted slightly to pixel boundaries.
- 10:49 PM Changeset in webkit [42986] by
-
- 1 edit10 adds in trunk/LayoutTests
Added missing pixel test results.
- platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.checksum: Added.
- platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.png: Added.
- platform/mac/fast/table/cell-coalescing-expected.checksum: Added.
- platform/mac/fast/table/cell-coalescing-expected.png: Added.
- platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.checksum: Added.
- platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
- platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.checksum: Added.
- platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.png: Added.
- platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.checksum: Added.
- platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.png: Added.
- 10:39 PM Changeset in webkit [42985] by
-
- 5 edits in trunk/WebCore
2009-04-28 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Move unimplemented captureEvents and releaseEvents from JSDOMWindow
to DOMWindow.
- bindings/js/JSDOMWindowCustom.cpp:
- page/DOMWindow.cpp: (WebCore::DOMWindow::captureEvents): (WebCore::DOMWindow::releaseEvents):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 10:30 PM Changeset in webkit [42984] by
-
- 2 edits in trunk
Correcting ChangeLogs - Sam talked to me about the patch, but it was Darin who reviewed it!
- 10:25 PM Changeset in webkit [42983] by
-
- 9 edits3 adds in trunk
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=25420
<rdar://problem/6829570> REGRESSION: XMLHttpRequest allows loading from another origin
Test: http/tests/xmlhttprequest/detaching-frame-2.html
This was caused by faulty DOMWindow::document(), which could return a new document from
the window's frame after navigation.
- bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindowBase::allowsAccessFromPrivate): Removed an obsolete check that allowed access when document was null. Contrary to what a comment said, that can happen for a window that is no longer in frame, not to one whose document is not constructed yet.
- bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Bail out if context was not found. This currently happens due to a shortcoming in DOMWindow::document() - when it is fixed, the XMLHttpRequest object in included regression test will be constructed successfully, but won't be sent, because its context will be frameless.
- page/DOMWindow.cpp: (WebCore::DOMWindow::document): Check that the window in frame hasn't been replaced yet. Added FIXME comments about how this may be better fixed in the future.
- bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::document): (WebCore::constructAudio):
- bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::document): (WebCore::constructImage):
- bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::construct):
- bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::document): (WebCore::constructHTMLOptionElement): Make matching changes to other constructors that hold a reference to global object.
- 9:54 PM Changeset in webkit [42982] by
-
- 2 edits in trunk/JavaScriptCore
Bring back r42969, this time with correct codegen
Reviewed by Gavin Barraclough.
Add logic to the codegen for right shift to avoid jumping to a helper function
when shifting a small floating point value.
- 9:22 PM Changeset in webkit [42981] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.6
Tagging 1.1.6.
- 9:02 PM Changeset in webkit [42980] by
-
- 6 edits in trunk
wxMSW build fix. Switch JSCore build back to static.
- 8:03 PM Changeset in webkit [42979] by
-
- 2 edits in trunk/WebKitTools
2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by David Kilzer.
Make sure "--pixel --add-platform-exceptions" produces platform
specific pixel test results.
- Scripts/run-webkit-tests: Support "--pixel --add-platform-exceptions"
- 6:24 PM Changeset in webkit [42978] by
-
- 2 edits in trunk/JavaScriptCore
Roll out r42969, due to hangs in build bot.
- 6:00 PM Changeset in webkit [42977] by
-
- 1 edit5 adds in trunk/LayoutTests
Reviewed by Simon Fraser.
Add a couple table hit tests
https://bugs.webkit.org/show_bug.cgi?id=21892
- svg/hittest/svg-inside-display-table-expected.txt: Added.
- svg/hittest/svg-inside-display-table.xhtml: Added.
- svg/hittest/svg-inside-table-expected.txt: Added.
- svg/hittest/svg-inside-table.xhtml: Added.
- 5:38 PM Changeset in webkit [42976] by
-
- 3 edits in trunk/JavaScriptCore
Improve performance of string indexing
Reviewed by Geoff Garen
Add a cti_get_by_val_string function to specialise indexing into a string object.
This gives us a slight performance win on a number of string tests.
- 5:29 PM Changeset in webkit [42975] by
-
- 3 edits in trunk
2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6834830>
Make sure we cover the two possible values reported by event.total that are playback engine
specific.
- media/progress-event-total-expected.txt: Match the new test.
- media/progress-event-total.html: Test the two values.
- 5:17 PM Changeset in webkit [42974] by
-
- 7 edits in trunk/WebCore
Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
collects the individual rects, making sure to only include RenderText.
<rdar://problem/6810061>
Reviewed by Sam Weinig.
- bindings/objc/DOM.mm: (-[DOMNode textRects]): Added. Make a Range and call textRects. (-[DOMNode lineBoxRects]): Call textRects method. (-[DOMRange textRects]): Call Range::textRects. (-[DOMRange lineBoxRects]): Call textRects method.
- bindings/objc/DOMPrivate.h: Add the new methods and a comment about lineBoxRects being deprecated.
- dom/Range.cpp: (WebCore::Range::boundingBox): Call textRects (renamed from addLineBoxRects). (WebCore::Range::textRects): Renamed from addLineBoxRects. Iterate over the nodes instead of the RenderObjects to correctly account for offsets. Also only call absoluteRectsForRange on RenderText.
- dom/Range.h: Renamed addLineBoxRects to textRects.
- page/Frame.cpp: (WebCore::Frame::selectionTextRects): Call textRects (renamed from addLineBoxRects).
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRectsForRange): Remove if conditions that made this function very specific for the lineBoxRects API. These functions are still used by the InspectorController, and this change improves what the Inspector shows. (WebCore::RenderObject::absoluteQuadsForRange): Ditto.
- 5:11 PM Changeset in webkit [42973] by
-
- 26 edits in trunk/WebCore
Remove the topLevel boolean argument from absolute{Rects,Quads}.
This argument was default to true and no one ever passed false.
Reviewed by Sam Weinig.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects): (WebCore::RenderBlock::absoluteQuads):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::absoluteQuads):
- rendering/RenderInline.h:
- rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::absoluteQuads):
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteRects): (WebCore::RenderSVGHiddenContainer::absoluteQuads):
- rendering/RenderSVGHiddenContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::absoluteRects): (WebCore::RenderSVGImage::absoluteQuads):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::absoluteRects): (WebCore::RenderSVGInlineText::absoluteQuads):
- rendering/RenderSVGInlineText.h:
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects): (WebCore::RenderSVGModelObject::absoluteQuads):
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects): (WebCore::RenderSVGTSpan::absoluteQuads):
- rendering/RenderSVGTSpan.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads):
- rendering/RenderSVGText.h:
- rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::absoluteQuads):
- rendering/RenderSVGTextPath.h:
- rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
- rendering/RenderText.h:
- rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects): (WebCore::RenderView::absoluteQuads):
- rendering/RenderView.h:
- 4:50 PM Changeset in webkit [42972] by
-
- 5 edits2 adds in trunk/WebCore
2009-04-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6794691> Media documents and <video controls> never show controls on Windows
RenderThemeWin doesn't implement the media element controller rendering methods, so media
controls stopped rendering when we switched from RenderThemeSafari. Rather than having copies
of the code in both places, the logic is in a new class that is called from both.
- WebCore.vcproj/WebCore.vcproj: Add RenderMediaControls.cpp.
- rendering/RenderMediaControls.cpp: Added. (WebCore::determineState): Translate renderer state to ThemeControlState. (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Adjust slider thumb. (WebCore::parentMediaElement): Return the HTMLMediaElement parent of a controller element. (WebCore::RenderMediaControls::paintMediaControlsPart): Paint a media controller part.
- rendering/RenderMediaControls.h: Added.
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderTrack): Remove the MediaSliderPart case, it is never called for the media slider. (WebCore::RenderThemeSafari::adjustSliderThumbSize): Call RenderMediaControls function. (WebCore::RenderThemeSafari::paintMediaFullscreenButton): Ditto. (WebCore::RenderThemeSafari::paintMediaMuteButton): Ditto. (WebCore::RenderThemeSafari::paintMediaPlayButton): Ditto. (WebCore::RenderThemeSafari::paintMediaSeekBackButton): Ditto. (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): Ditto. (WebCore::RenderThemeSafari::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeSafari::paintMediaSliderThumb): Ditto.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSliderThumbSize): Ditto. (WebCore::RenderThemeWin::paintMediaFullscreenButton): Ditto. (WebCore::RenderThemeWin::paintMediaMuteButton): Ditto. (WebCore::RenderThemeWin::paintMediaPlayButton): Ditto. (WebCore::RenderThemeWin::paintMediaSeekBackButton): Ditto. (WebCore::RenderThemeWin::paintMediaSeekForwardButton): Ditto. (WebCore::RenderThemeWin::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeWin::paintMediaSliderThumb): Ditto.
- rendering/RenderThemeWin.h:
- 4:12 PM Changeset in webkit [42971] by
-
- 2 edits in trunk/WebCore
2009-04-28 Beth Dakin <Beth Dakin>
Reviewed by Sam Weinig.
Fix for <rdar://problem/6419515> REGRESSION (r31037): Positioned
images with % height are collapsed when printing
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight): Make sure we don't ignore printing here!
- 3:36 PM Changeset in webkit [42970] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: fix distcheck build, add (even more) missing files to list.
- GNUmakefile.am:
- 3:22 PM Changeset in webkit [42969] by
-
- 2 edits in trunk/JavaScriptCore
Improve performance of right shifts of large or otherwise floating point values.
Reviewed by Geoff Garen.
Add logic to the codegen for right shift to avoid jumping to a helper function
when shifting a small floating point value.
- 3:17 PM Changeset in webkit [42968] by
-
- 4 edits4 adds in trunk
WebCore:
2009-04-28 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
Test: editing/deleting/type-delete-after-quote.html
When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
since it is unclear to most users that such a selection actually ends at the start of the next paragraph. However, when a user hits delete
with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it. We can tell that
we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection. So we can tell
that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior
from deleting a range they selected.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):
LayoutTests:
2009-04-28 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
- editing/deleting/type-delete-after-quote.html: Added.
- platform/mac/editing/deleting/delete-4038408-fix-expected.txt: This expected result change reflects a change in how the editing is done, but the document structure remains the same, and there are no visible changes to the result.
- platform/mac/editing/deleting/type-delete-after-quote-expected.checksum: Added.
- platform/mac/editing/deleting/type-delete-after-quote-expected.png: Added.
- platform/mac/editing/deleting/type-delete-after-quote-expected.txt: Added.
- 3:15 PM Changeset in webkit [42967] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: fix distcheck build, add (more) missing files to list.
- GNUmakefile.am:
- 3:12 PM Changeset in webkit [42966] by
-
- 1 edit4 adds in trunk/LayoutTests
Reviewed by Simon Fraser.
Add text gradient test to cover
https://bugs.webkit.org/show_bug.cgi?id=25403
- platform/mac/svg/text/text-gradient-positioning-expected.checksum: Added.
- platform/mac/svg/text/text-gradient-positioning-expected.png: Added.
- platform/mac/svg/text/text-gradient-positioning-expected.txt: Added.
- svg/text/text-gradient-positioning.svg: Added.
- 3:09 PM Changeset in webkit [42965] by
-
- 8 edits in trunk/WebKit/mac
2009-04-28 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker and Darin Adler.
Fix <rdar://problem/6836132>.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCCheckIfAllowedToLoadURL): Call the instance proxy.
(WKPCCancelCheckIfAllowedToLoadURL):
Ditto.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Initialize the check ID counter.
(WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURL):
Create a WebPluginContainerCheck, add it to the map, and start it.
(WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):
Remove the check from the map.
(WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult):
Call the WKPH MIG callback.
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Call the instance proxy.
(-[WebHostedNetscapePluginView _containerCheckResult:contextInfo:]):
Ditto.
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs: Add MIG declarations.
- 2:59 PM Changeset in webkit [42964] by
-
- 1 edit4 adds in trunk/LayoutTests
Reviewed by David Hyatt.
Add text repaint test to cover
https://bugs.webkit.org/show_bug.cgi?id=16188
- platform/mac/svg/text/text-repaint-rects-expected.checksum: Added.
- platform/mac/svg/text/text-repaint-rects-expected.png: Added.
- platform/mac/svg/text/text-repaint-rects-expected.txt: Added.
- svg/text/text-repaint-rects.xhtml: Added.
- 2:38 PM Changeset in webkit [42963] by
-
- 4 edits in trunk
WebCore:
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: fix distcheck build, add missing header to file list.
- GNUmakefile.am:
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: fix distcheck build, add missing header to file list.
- GNUmakefile.am:
- 2:27 PM Changeset in webkit [42962] by
-
- 3 edits in trunk/WebKit/gtk
2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Update gtk-doc control and base sgml files for 1.1.6.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 1:59 PM Changeset in webkit [42961] by
-
- 19 edits in trunk
Reviewed by Sam Weinig.
Fix foreignObject transform order
https://bugs.webkit.org/show_bug.cgi?id=25433
Transforms were being applied in the wrong order.
When mapping from local to parent, first apply the viewport transform
then map from the viewport box to the parent box.
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::localToParentTransform):
- 1:56 PM Changeset in webkit [42960] by
-
- 20 edits in trunk/WebCore
Reviewed by Simon Fraser.
Simplify nodeAtPoint for SVG
https://bugs.webkit.org/show_bug.cgi?id=25432
Added a new nodeAtFloatPoint method which takes a FloatPoint
instead of the *super confusing* x/y tx/ty pairs that HTML uses.
Mostly this is just lots of minus-lines as the new code is *much* simpler.
I made all the SVG renderers use the new nodeAtFloatPoint and ASSERT_NOT_REACHED
for the nodeAtPoint HTML/CSS int x/y version.
Eventually the rest of CSS/HTML render objects will follow suit
and move to nodeAtFloatPoint (possibly renamed back to nodeAtPoint), but changing them
over was well outside the scope of this change.
SVG hit testing is not actually floating point precise yet, since its still
passed in an integer x/y. Certain transform hit-test edge cases are likely fixed
by moving to FloatPoint here, but I didn't try to find one.
This should not cause functional changes for common-case hit testing, thus
no tests changed, nor should new tests be needed.
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes): (WebCore::RenderForeignObject::paint): (WebCore::RenderForeignObject::computeRectForRepaint): (WebCore::RenderForeignObject::localToParentTransform): (WebCore::RenderForeignObject::layout): (WebCore::RenderForeignObject::nodeAtFloatPoint):
- rendering/RenderForeignObject.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::nodeAtFloatPoint):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtFloatPoint):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtFloatPoint):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::pointIsInsideViewportClip):
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::nodeAtFloatPoint):
- rendering/RenderSVGHiddenContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::nodeAtFloatPoint):
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::localToParentTransform): (WebCore::RenderSVGImage::localTransform):
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::nodeAtFloatPoint):
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtFloatPoint):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint):
- rendering/RenderSVGText.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip):
- rendering/RenderSVGViewportContainer.h:
- 1:42 PM Changeset in webkit [42959] by
-
- 2 edits in trunk/WebCore
2009-04-28 Eric Carlson <eric.carlson@apple.com>
- fix the Tiger build
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::cacheMovieScale):
- 1:30 PM Changeset in webkit [42958] by
-
- 8 edits in trunk/WebCore
2009-04-28 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Consolidate ScheduleAction creation into ScheduledAction::create.
Autogenerate JSWorkerContext.clearTimeout and clearInterval.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create): (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
- workers/WorkerContext.cpp: (WebCore::DOMWindow::setTimeout): (WebCore::DOMWindow::clearTimeout): (WebCore::DOMWindow::setInterval): (WebCore::DOMWindow::clearInterval):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
- 1:22 PM Changeset in webkit [42957] by
-
- 3 edits1 add in trunk/WebKitTools
Fix link warnings building TestNetscapePlugin on Windows due to mismatched
DLL name vs. LIBRARY directive name.
Reviewed by Jon Honeycutt.
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def: Added.
- 1:21 PM Changeset in webkit [42956] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Updated with news for the 1.1.6 release.
- NEWS:
- 1:14 PM Changeset in webkit [42955] by
-
- 7 edits10 adds in trunk
WebCore:
2009-04-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed
When moving Nodes between documents we weren't properly updating style declarations. Certain operations, such
as creating webarchives, would tickle this bug.
Tests: webarchive/adopt-attribute-styled-body-webarchive.html
webarchive/adopt-attribute-styled-node-webarchive.html
webarchive/adopt-inline-styled-node-webarchive.html
- dom/Node.cpp: Add a debug-only mechanism to insure that anyone who overrides (did/will)MoveToNewOwnerDocument calls their parent-class implementation after they've done their own work. (WebCore::setWillMoveToNewOwnerDocumentWasCalled): (WebCore::setDidMoveToNewOwnerDocumentWasCalled): (WebCore::Node::setDocument): (WebCore::Node::willMoveToNewOwnerDocument): (WebCore::Node::didMoveToNewOwnerDocument):
- dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged): Add a comment explaining why we don't need to walk the nameAttrMap to update style declarations. (WebCore::StyledElement::didMoveToNewOwnerDocument): Update the parent pointer for the inline style declaration.
- dom/StyledElement.h:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument): Update the parent pointer for the link declaration.
- html/HTMLBodyElement.h:
LayoutTests:
2009-04-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed
- webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive: Added.
- webarchive/adopt-attribute-styled-body-webarchive.html: Added.
- webarchive/resources/adopt-attribute-styled-body-iframe.html: Added.
- webarchive/resources/adopt-attribute-styled-body-second-window.html: Added.
- webarchive/adopt-attribute-styled-node-webarchive-expected.webarchive: Added.
- webarchive/adopt-attribute-styled-node-webarchive.html: Added.
- webarchive/resources/adopt-attribute-styled-node-second-window.html: Added.
- webarchive/adopt-inline-styled-node-webarchive-expected.webarchive: Added.
- webarchive/adopt-inline-styled-node-webarchive.html: Added.
- webarchive/resources/adopt-inline-styled-node-second-window.html: Added.
- 1:12 PM Changeset in webkit [42954] by
-
- 2 edits in tags/Safari-6530.7.1/WebCore
Merge r42945.
- 12:48 PM Changeset in webkit [42953] by
-
- 3 edits in trunk/WebKitTools
Fix warnings about PRODUCTION and ARCHIVE_BUILD on Windows builds
of ImageDiff and DumpRenderTree.
Rubber stamped by Adam Roben.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- 12:46 PM Changeset in webkit [42952] by
-
- 2 edits in trunk/WebCore
2009-04-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6834876> Don't use BlockExceptions macros until QTKit supports
QTMoviePreferredTransformAttribute
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::cacheMovieScale): use @try and @catch instead of BEGIN_BLOCK_OBJC_EXCEPTIONS and END_BLOCK_OBJC_EXCEPTIONS for builds of QTKit that throw an exception on QTMovieCurrentSizeAttribute but don't support QTMoviePreferredTransformAttribute
- 12:43 PM Changeset in webkit [42951] by
-
- 2 edits in trunk/WebCore
2009-04-28 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
- rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Streamline code path to avoid a bit of reference count churn and remove a strange unneeeded PassRefPtr typecast. Also added a comment. (WebCore::RenderText::setTextInternal): Ditto.
- 12:37 PM Changeset in webkit [42950] by
-
- 21 edits in trunk
Reviewed by Simon Fraser.
Simplify how SVG containers paint
https://bugs.webkit.org/show_bug.cgi?id=25431
Moved filterBoundingBox() from RenderSVGModelObject to SVGRenderSupport to share with other classes.
Gave RenderSVGText a modern clippedOverflowRectForRepaint and computeRectForRepaint.
RenderSVGText now applies transforms at paint() time instead of during chunk draw time
this should be much more efficient.
Fixed the order in which RenderSVGViewportContainer applied
transforms and clips. We now clip to the viewport first and apply
all transforms at once. Also since the viewport logic is now only
inside RenderSVGViewportContainer (instead of inside RenderSVGContainer)
we always know we have a viewport. We now use only viewportSize instead of
viewport() since RenderSVGViewportContainers can't have x/y offsets.
We now correctly transform the PaintInfo::rect (damage rect) when applying transforms.
This allowed us to apply the transform during text paint() instead of at chunk paint
time. Previously we had to apply the transform during chunk paint time because
RenderBlock (superclass of RenderSVGBlock) would check intersection with the damageRect
before telling any of the inlines to draw. Now that we adjust the damage rect correctly
we pass the intersection check correctly! (This probably fixed some <text> redraw bugs
but since I still have a bunch of those to fix, I've not tried to write additional tests
to cover these potential fixes yet.)
SVGRootInlineBox no longer needs to deal with transforms at chunk paint time, yay!
- rendering/RenderPath.cpp: (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::applyViewportClip):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): (WebCore::RenderSVGImage::clippedOverflowRectForRepaint): (WebCore::RenderSVGImage::computeRectForRepaint):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGModelObject.cpp:
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::viewportSize): (WebCore::RenderSVGRoot::calcViewport): (WebCore::RenderSVGRoot::localToBorderBoxTransform): (WebCore::RenderSVGRoot::parentOriginToBorderBox): (WebCore::RenderSVGRoot::borderOriginToContentBox): (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform): (WebCore::RenderSVGRoot::computeRectForRepaint): (WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint): (WebCore::RenderSVGText::computeRectForRepaint): (WebCore::RenderSVGText::paint): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::localToParentTransform): (WebCore::RenderSVGText::localTransform):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip):
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGRenderSupport.cpp: (WebCore::filterBoundingBoxForRenderer): (WebCore::applyTransformToPaintInfo):
- rendering/SVGRenderSupport.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback): (WebCore::SVGRootInlineBox::paint):
- 12:37 PM Changeset in webkit [42949] by
-
- 3 edits2 adds in trunk
Bug 25453: AX: fall back to PLACEHOLDER attr if form element is not labeled
https://bugs.webkit.org/show_bug.cgi?id=25453
- 12:33 PM Changeset in webkit [42948] by
-
- 4 edits in tags/Safari-6530.7.1
Versioning.
- 12:16 PM Changeset in webkit [42947] by
-
- 1 copy in tags/Safari-6530.7.1
New tag.
- 12:14 PM Changeset in webkit [42946] by
-
- 9 edits2 adds in trunk
Bug 25452: AX: Don't create addition space AXStaticText element for every bold or link tag
https://bugs.webkit.org/show_bug.cgi?id=25452
- 11:57 AM Changeset in webkit [42945] by
-
- 2 edits in trunk/WebCore
Work around <rdar://problem/6833240> by relying on static initialization to zero the entire struct.
This removes the need for us to explicitly initialize all of the members, which have a tendency
to change in meaning and number between versions of libxml2.
Reviewed by Sam Weinig.
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::):
(WebCore::sharedXHTMLEntity):
(WebCore::getXHTMLEntity):
- 11:56 AM Changeset in webkit [42944] by
-
- 2 edits in trunk/WebKitLibraries
Fix extraneous warning about AnalyzeWithLargeStack not being defined in Windows builds.
Indirected definition through a UserMacro.
Reviewed by Mark Rowe.
- win/tools/vsprops/common.vsprops:
- 11:52 AM Changeset in webkit [42943] by
-
- 2 edits in trunk/WebCore
Fix linker warning by specifying /NODEFAULTLIB:LIBCMT for QTMovieWin.
Reviewed by Mark Rowe.
- WebCore.vcproj/QTMovieWin.vcproj:
- 11:32 AM Changeset in webkit [42942] by
-
- 3 edits2 adds in trunk
Bug 25449: AX: Respect the alt tag of ARIA button as AXDescription
https://bugs.webkit.org/show_bug.cgi?id=25449
- 11:29 AM Changeset in webkit [42941] by
-
- 2 edits in trunk/WebKitLibraries
Fix extraneous warning about PRODUCTION not being defined in Windows builds.
Indirected definition for PRODUCTION through a UserMacro.
Reviewed by Mark Rowe.
- win/tools/vsprops/common.vsprops:
- 11:16 AM Changeset in webkit [42940] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
- formatting cleanup
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight): Corrected indentation and added braces around a multi-line "else" clause.
- 11:05 AM Changeset in webkit [42939] by
-
- 4 edits in trunk
2009-04-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben
<rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=25094
Display movies saved with a non-identity matrix at the correct size.
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::QTMovieWinPrivate): Initialize m_widthScaleFactor and m_heightScaleFactor. (QTMovieWinPrivate::cacheMovieScale): New, calculate difference between initial size and natural size so naturalSize() accounts for non-identity movie matrix. (QTMovieWinPrivate::task):Call cacheMovieScale when load state reaches kMovieLoadStateLoaded for the first time. kMovieLoadState -> QTMovieLoadState. (QTMovieWinPrivate::drawingComplete): kMovieLoadState -> QTMovieLoadState. (QTMovieWinPrivate::createGWorld): Don't bother creating gworld until load state reaches kMovieLoadStateLoaded because we do not try to draw it before that point. (QTMovieWinPrivate::setSize): Do not change movie box before reaching kMovieLoadStateLoaded because we need to get the movie's initial size in cacheMovieScale. (QTMovieWin::getNaturalSize): Multiply width and height by initial scale.
2009-04-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben
<rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=25094
- platform/win/Skipped: Re-enable video-size-intrinsic-scale.html.
- 10:43 AM Changeset in webkit [42938] by
-
- 7 edits in trunk/WebCore
2009-04-28 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Move timer code from JSDOMWindow to DOMWindow. clearTimeout and
clearInterval can now be autogenerated.
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createScheduledAction): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
- page/DOMWindow.cpp: (WebCore::DOMWindow::setTimeout): (WebCore::DOMWindow::clearTimeout): (WebCore::DOMWindow::setInterval): (WebCore::DOMWindow::clearInterval):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 10:06 AM Changeset in webkit [42937] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Small optimization, don't get the widget's handle twice in one method.
https://bugs.webkit.org/show_bug.cgi?id=25446
- 9:46 AM Changeset in webkit [42936] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by John Sullivan.
- fix <rdar://problem/6786360> Make PDF an insertable pasteboard type
- WebCoreSupport/WebPasteboardHelper.mm: (WebPasteboardHelper::insertablePasteboardTypes):
- WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): (+[WebHTMLView _insertablePasteboardTypes]): (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
- 9:32 AM QtWebKitJournal edited by
- (diff)
- 9:31 AM Changeset in webkit [42935] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
ScrollView copy and paste typo fix.
https://bugs.webkit.org/show_bug.cgi?id=25445
- 9:29 AM QtWebKitTodo edited by
- (diff)
- 9:28 AM QtWebKitJournal edited by
- (diff)
- 9:27 AM Changeset in webkit [42934] by
-
- 6 edits in trunk/WebKit/qt
2009-04-28 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
QWebElement API changes after another round of API review:
- Fix argument names of findAll/findFirst
- Split up toXml into innerXml and outerXml
- Removed confusing toggleClass overload
- Fixed casing of namespaceUri to follow QXmlStreamReader
- Removed tagName from firstChild/nextSibling/etc.
- Renamed append/prepend/insertAfter/insertBefore to [append|prepend][Inside|Outside]
- Renamed wrapWith() back to wrap()
- Made clone() const
- Renamed remove() to takeFromDocument(), added removeFromDocument()
- Renamed clear() to removeChildren()
- Renamed scriptsFunctions/callScriptFunction to functions()/callFunction()
- Renamed scriptProperty to scriptableProperty
- 9:25 AM QtWebKitTodo edited by
- (diff)
- 9:09 AM Changeset in webkit [42933] by
-
- 2 edits in trunk
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: bump versions in preparation for 1.1.6 release.
- configure.ac:
- 9:06 AM Changeset in webkit [42932] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Leave a bit of space from the previous page when advacing a whole
page. This matches the behavior of our scrollbar scrolling code
and is just nicer in general.
- webkit/webkitwebview.cpp:
- 8:55 AM Changeset in webkit [42931] by
-
- 5 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Add a function for resetting the zoom factor to 1.0.
https://bugs.webkit.org/show_bug.cgi?id=25447
- 7:01 AM Changeset in webkit [42930] by
-
- 2 edits in trunk/WebCore
2009-04-28 John Sullivan <sullivan@apple.com>
<rdar://problem/6820221> REGRESSION: 2-byte character names of images are displayed as %-encoded ASCII
Reviewed by Adam Roben
- loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): decode the filename before processing it as part of the image name that's passed to the client
- 6:51 AM Changeset in webkit [42929] by
-
- 5 edits in trunk/WebKit/qt
2009-04-28 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix some qdoc warnings.
- 6:36 AM QtWebKitTodo edited by
- (diff)
- 6:35 AM QtWebKitTodo edited by
- (diff)
- 2:59 AM Changeset in webkit [42928] by
-
- 2 edits in trunk/WebCore
2009-04-28 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
- fix initialization order to match declaration order to fix release build
- page/Settings.cpp: (WebCore::Settings::Settings):
- 1:55 AM Changeset in webkit [42927] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: committed a few bits by mistake, remove them.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::handleEditingKeyboardEvent):
- 1:45 AM Changeset in webkit [42926] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=16135
[GTK] Support caret browsing
Refactor keyboard event handling to work properly under caret
browsing mode. Most of the code comes from the Windows port.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::): (WebKit::interpretKeyEvent): (WebKit::handleEditingKeyboardEvent): (WebKit::EditorClient::handleKeyboardEvent):
- 1:44 AM Changeset in webkit [42925] by
-
- 3 edits in trunk/WebKit/gtk
2009-04-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=16135
[GTK] Support caret browsing
Based on a patch by Alp Toker.
Add enable-caret-browsing setting to WebKitWebView.
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
- webkit/webkitwebview.cpp:
- 1:44 AM Changeset in webkit [42924] by
-
- 7 edits in trunk/WebCore
2009-04-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Justin Garcia.
https://bugs.webkit.org/show_bug.cgi?id=16135
[GTK] Support caret browsing
Based on a patch by Alp Toker.
Implement basic support for caret browsing, active only when the
corresponding setting is enabled.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
- page/FocusController.cpp: (WebCore::FocusController::advanceFocus): (WebCore::clearSelectionIfNeeded): (WebCore::FocusController::setFocusedNode):
- page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::respondToChangedSelection):
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
- 1:08 AM Changeset in webkit [42923] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-28 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Maciej "Henry Morgan" Stachowiak.
Enable YARR.
(Again.)
- wtf/Platform.h:
- 12:10 AM Changeset in webkit [42922] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-27 Gavin Barraclough <barraclough@apple.com>
Reviewed by Maciej Stachowiak.
Tweak a loop condition to keep GCC happy,
some GCCs seem to be having issues with this. :-/
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::breakTarget):
- wtf/Platform.h:
Apr 27, 2009:
- 11:05 PM Changeset in webkit [42921] by
-
- 1 edit1 move in trunk/LayoutTests
2009-04-27 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Disable test intermittent failing test.
- svg/custom/filter-source-alpha.svg: Removed.
- svg/custom/filter-source-alpha.svg-disabled: Copied from svg/custom/filter-source-alpha.svg.
- 10:14 PM Changeset in webkit [42920] by
-
- 3 edits5 adds in trunk/LayoutTests
2009-04-27 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser
Fix video-played.html layout test.
We implement playForMillisecs() which makes sure the video
will have been playing for a minimum time.
Note, this does not ensure a strict synchronization between the time
asked and the media playback. But given that media playback is the
slow part we just need to compensate for the delay involved by playback.
(And not the other way around.)
Moreover, we split the test in 3 in order to be more gentle which
slower machines that may tend to timeout more easily on those tests.
- media/video-played-collapse-expected.txt: Added.
- media/video-played-collapse.html: Added.
- media/video-played-expected.txt:
- media/video-played-reset-expected.txt: Added.
- media/video-played-reset.html: Added.
- media/video-played.html:
- Split tests in multiple files.
- Makes sure we always play as much as requested by using playForMillisecs();
- media/video-played.js: Added. (testRanges): (nextTest): (pause): (canplay): (willCreateNewRange): (startPlayingInNewRange): (startPlaying): (secToMilli): (milliToSecs): (playForMillisecs.callPauseIfTimeIsReached): (playForMillisecs): (videoPlayedMain):
- 8:39 PM Changeset in webkit [42919] by
-
- 2 edits in trunk/WebCore
2009-04-27 Eric Roman <eroman@chromium.org>
Reviewed by Darin Fisher.
Fix a compile breakage.
<https://bugs.webkit.org/show_bug.cgi?id=25384>
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 6:01 PM Changeset in webkit [42918] by
-
- 3 edits in trunk/WebCore
2009-04-27 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6822344> Use of QTMovieCurrentSizeAttribute generates exception and will crash
QTMovieCurrentSizeAttribute generates an exception with some versions of QTKit, so calculate a
multiplier to scale from natural size to current size when a movie is opened and use that to
return the correct value from the naturalSize() method.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_scaleFactor. (WebCore::MediaPlayerPrivate::naturalSize): Return naturalSize transformed by initial scale. (WebCore::MediaPlayerPrivate::cacheMovieScale): New, calculate difference between initial size and natural size so naturalSize() accounts for non-identity movie matrix. (WebCore::MediaPlayerPrivate::updateStates): Call cacheMovieScale when load state reaches QTMovieLoadStateLoaded for the first time.
- 5:54 PM Changeset in webkit [42917] by
-
- 3 edits4 adds in trunk
WebCore:
2009-04-27 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Fix for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work
The problem here is that we had a self-painting layer nested inside
a non-self-painting layer. We ended up ignoring the self-painting
layer both during painting and hit-testing. This patch corrects
that.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
LayoutTests:
2009-04-27 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Test for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work
- fast/css/nested-layers-with-hover.html: Added.
- platform/mac/fast/css/nested-layers-with-hover-expected.checksum: Added.
- platform/mac/fast/css/nested-layers-with-hover-expected.png: Added.
- platform/mac/fast/css/nested-layers-with-hover-expected.txt: Added.
- 5:23 PM Changeset in webkit [42916] by
-
- 2 edits in trunk/WebCore
If it has been set to allow any HTTPS certificates for this host, set
kCFStreamSSLAllowsExpiredCertificates to true to allow expired
certificate, and set kCFStreamSSLValidatesCertificateChain false to skip
certificate chain validation. (<rdar://problem/6382059>)
Reviewed by John Sullivan.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest):
- 5:12 PM Changeset in webkit [42915] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-04-23 Simon Fraser <Simon Fraser>
Add pixel test for zoomed video with controls, with and without a transform.
- media/video-zoom-controls.html: Added.
- platform/mac/media/video-zoom-controls-expected.checksum: Added.
- platform/mac/media/video-zoom-controls-expected.png: Added.
- platform/mac/media/video-zoom-controls-expected.txt: Added.
- 5:08 PM Changeset in webkit [42914] by
-
- 4 edits in trunk
2009-04-27 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson
<rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well
Fix a 'size changed' notification thrash that caused standalone video elements
to continually resize after full page zooming, by using the movie's natual size (which is independent
of zooming), rather than its current size (which is not).
Note that this regresses <https://bugs.webkit.org/show_bug.cgi?id=25029>, so we have to
disable the media/video-size-intrinsic-scale.html test. However, we have to stop using
QTMovieCurrentSizeAttribute anyway; this will be addressed, and the test re-enabled via
<rdar://problem/6822344>.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::naturalSize):
- 4:58 PM Changeset in webkit [42913] by
-
- 3 edits in trunk/WebCore
2009-04-27 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
<rdar://problem/6642221> REGRESSION: With the Movie widget, movie trailer fails to
load if movie had been previously viewed
Fix the Dashboard quirk for display:none plug-ins by moving the code from HTMLObjectElement
to HTMLEmebedElement. It has to be in HTMLEmbedElement because the content we care about uses <embed>.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
- 4:33 PM Changeset in webkit [42912] by
-
- 14 edits in trunk/WebCore
2009-04-27 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Move more window event related code into DOMWindow.
- dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setWindowAttributeEventListener): (WebCore::Document::dispatchWindowEvent): (WebCore::Document::dispatchLoadEvent):
- dom/Document.h:
- dom/Element.cpp:
- dom/Element.h:
- dom/Node.cpp:
- dom/Node.h:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): (WebCore::DOMWindow::postMessageTimerFired): (WebCore::DOMWindow::dispatchEvent): (WebCore::DOMWindow::dispatchEventWithDocumentAsTarget): (WebCore::DOMWindow::dispatchLoadEvent): (WebCore::DOMWindow::dispatchUnloadEvent): (WebCore::DOMWindow::dispatchBeforeUnloadEvent):
- page/DOMWindow.h:
- page/Frame.cpp: (WebCore::Frame::shouldClose):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
- 4:14 PM Changeset in webkit [42911] by
-
- 25 edits in trunk
WebCore:
2009-04-27 Douglas R. Davidson <ddavidso@apple.com>
Implement the editing mechanisms and add context menu items for
<rdar://problem/6724106> WebViews need to implement text checking
Reviewed by Justin Garcia.
- editing/Editor.cpp:
- editing/Editor.h:
- editing/TypingCommand.cpp:
- loader/EmptyClients.h:
- page/ContextMenuController.cpp:
- page/EditorClient.h:
- page/mac/WebCoreViewFactory.h:
- platform/ContextMenu.cpp:
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.h:
- platform/mac/LocalizedStringsMac.mm:
WebKit:
2009-04-27 Douglas R. Davidson <ddavidso@apple.com>
Add localizable strings for
<rdar://problem/6724106> WebViews need to implement text checking
Reviewed by Justin Garcia.
- English.lproj/Localizable.strings:
WebKit/mac:
2009-04-27 Douglas R. Davidson <ddavidso@apple.com>
Add the various switches and context menu items needed for
<rdar://problem/6724106> WebViews need to implement text checking
and adopt updatePanels in place of old SPI _updateGrammar.
Reviewed by Justin Garcia.
- WebCoreSupport/WebContextMenuClient.mm: (fixMenusReceivedFromOldClients):
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::uppercaseWord): (WebEditorClient::lowercaseWord): (WebEditorClient::capitalizeWord): (WebEditorClient::showSubstitutionsPanel): (WebEditorClient::substitutionsPanelIsShowing): (WebEditorClient::toggleSmartInsertDelete): (WebEditorClient::isAutomaticQuoteSubstitutionEnabled): (WebEditorClient::toggleAutomaticQuoteSubstitution): (WebEditorClient::isAutomaticLinkDetectionEnabled): (WebEditorClient::toggleAutomaticLinkDetection): (WebEditorClient::isAutomaticDashSubstitutionEnabled): (WebEditorClient::toggleAutomaticDashSubstitution): (WebEditorClient::isAutomaticTextReplacementEnabled): (WebEditorClient::toggleAutomaticTextReplacement): (WebEditorClient::isAutomaticSpellingCorrectionEnabled): (WebEditorClient::toggleAutomaticSpellingCorrection): (WebEditorClient::checkTextOfParagraph):
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagShowColors]): (-[WebViewFactory contextMenuItemTagCorrectSpellingAutomatically]): (-[WebViewFactory contextMenuItemTagSubstitutionsMenu]): (-[WebViewFactory contextMenuItemTagShowSubstitutions:]): (-[WebViewFactory contextMenuItemTagSmartCopyPaste]): (-[WebViewFactory contextMenuItemTagSmartQuotes]): (-[WebViewFactory contextMenuItemTagSmartDashes]): (-[WebViewFactory contextMenuItemTagSmartLinks]): (-[WebViewFactory contextMenuItemTagTextReplacement]): (-[WebViewFactory contextMenuItemTagTransformationsMenu]): (-[WebViewFactory contextMenuItemTagMakeUpperCase]): (-[WebViewFactory contextMenuItemTagMakeLowerCase]): (-[WebViewFactory contextMenuItemTagCapitalize]):
- WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView isAutomaticQuoteSubstitutionEnabled]): (-[WebHTMLView setAutomaticQuoteSubstitutionEnabled:]): (-[WebHTMLView toggleAutomaticQuoteSubstitution:]): (-[WebHTMLView isAutomaticLinkDetectionEnabled]): (-[WebHTMLView setAutomaticLinkDetectionEnabled:]): (-[WebHTMLView toggleAutomaticLinkDetection:]): (-[WebHTMLView isAutomaticDashSubstitutionEnabled]): (-[WebHTMLView setAutomaticDashSubstitutionEnabled:]): (-[WebHTMLView toggleAutomaticDashSubstitution:]): (-[WebHTMLView isAutomaticTextReplacementEnabled]): (-[WebHTMLView setAutomaticTextReplacementEnabled:]): (-[WebHTMLView toggleAutomaticTextReplacement:]): (-[WebHTMLView isAutomaticSpellingCorrectionEnabled]): (-[WebHTMLView setAutomaticSpellingCorrectionEnabled:]): (-[WebHTMLView toggleAutomaticSpellingCorrection:]):
- WebView/WebHTMLViewInternal.h:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebUIDelegatePrivate.h:
- WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView validateUserInterfaceItemWithoutDelegate:]): (-[WebView setGrammarCheckingEnabled:]): (-[WebView isAutomaticQuoteSubstitutionEnabled]): (-[WebView isAutomaticLinkDetectionEnabled]): (-[WebView isAutomaticDashSubstitutionEnabled]): (-[WebView isAutomaticTextReplacementEnabled]): (-[WebView isAutomaticSpellingCorrectionEnabled]): (-[WebView setAutomaticQuoteSubstitutionEnabled:]): (-[WebView toggleAutomaticQuoteSubstitution:]): (-[WebView setAutomaticLinkDetectionEnabled:]): (-[WebView toggleAutomaticLinkDetection:]): (-[WebView setAutomaticDashSubstitutionEnabled:]): (-[WebView toggleAutomaticDashSubstitution:]): (-[WebView setAutomaticTextReplacementEnabled:]): (-[WebView toggleAutomaticTextReplacement:]): (-[WebView setAutomaticSpellingCorrectionEnabled:]): (-[WebView toggleAutomaticSpellingCorrection:]):
- WebView/WebViewPrivate.h:
- 4:12 PM Changeset in webkit [42910] by
-
- 2 edits in trunk/WebCore
2009-04-27 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix for <rdar://problem/6772944> REGRESSION (r42223): PLT 2% slower, i-Bench 3% slower
Be slightly less eager in collecting after page close/navigation by increasing
the time before collection from 0 seconds to .5 seconds.
3% speedup on the PLT.
- bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectSoon):
- 4:06 PM Changeset in webkit [42909] by
-
- 10 edits2 adds in trunk
Consolidate runtime application checks for Apple Mail and Safari
Reviewed by Mark Rowe and Darin Adler.
WebCore:
- WebCore.base.exp: Added exports.
- WebCore.xcodeproj/project.pbxproj: Added RuntimeApplicationChecks.{h|mm} source files to the project.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks): Removed local checkedSafari and isSafari variables and switched to use applicationIsSafari().
- platform/mac/RuntimeApplicationChecks.h: Added.
- platform/mac/RuntimeApplicationChecks.mm: Added. (WebCore::applicationIsAppleMail): Runtime application check for Apple Mail. (WebCore::applicationIsSafari): Runtime application check for Safari.
WebKit:
- WebCoreSupport/WebContextMenuClient.mm: (isAppleMail): Removed. (fixMenusToSendToOldClients): Switched to use applicationIsAppleMail().
- WebView/WebFrame.mm: (-[WebFrame reload]): Switched to use applicationIsSafari().
- WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): Ditto.
- WebView/WebResource.mm: (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]): Switched to use applicationIsAppleMail().
- WebView/WebView.mm: (runningLeopardMail): Ditto. (runningTigerMail): Ditto. (-[WebView _needsKeyboardEventDisambiguationQuirks]): Switched to use applicationIsSafari().
- 3:34 PM Changeset in webkit [42908] by
-
- 2 edits in trunk/WebCore
Bug 25374: AX: No AXValue change sent when text is auto-inserted
https://bugs.webkit.org/show_bug.cgi?id=25374
Updated to fix regression test failures
- 2:56 PM Changeset in webkit [42907] by
-
- 2 edits in trunk/WebCore
2009-04-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Based on a patch by Alp Toker.
Cover more WebCore role -> ATK role conversions.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 2:40 PM Changeset in webkit [42906] by
-
- 2 edits in trunk/WebCore
2009-04-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Do not call ATK setters in the getters, just return the
value. Among other things calling the setter will emit the notify
signal, which is wrong.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 2:33 PM Changeset in webkit [42905] by
-
- 2 edits in trunk/WebCore
2009-04-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Based on a patch by Alp Toker.
Implement AtkImage interface.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 2:25 PM Changeset in webkit [42904] by
-
- 2 edits in trunk/WebCore
2009-04-27 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed debug build fix.
- platform/gtk/gtk2drawing.c: (moz_gtk_toggle_paint):
- 1:12 PM Changeset in webkit [42903] by
-
- 3 edits in trunk/WebCore
2009-04-27 Dimitri Glazkov <Dimitri Glazkov>
Build fix.
https://bugs.webkit.org/show_bug.cgi?id=25382
Remove direct reference to CallFrame.h include to pacify Win build.
- bindings/js/JSDOMBinding.h: Removed ScriptState.h include.
- bindings/js/ScriptState.h: Replaced CallFrame.h with JSDOMBinding.h
- 12:49 PM Changeset in webkit [42902] by
-
- 2 edits in trunk/WebCore
Bug 25374: AX: No AXValue change sent when text is auto-inserted
https://bugs.webkit.org/show_bug.cgi?id=25374
- 12:46 PM Changeset in webkit [42901] by
-
- 10 edits in trunk/WebCore
2009-04-27 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25382
Move scriptStateFromNode to ScriptState.
- bindings/js/JSDOMBinding.cpp: Moved scriptStateFromNode to ScriptState.
- bindings/js/JSDOMBinding.h: Ditto.
- bindings/js/ScriptState.cpp: (WebCore::scriptStateFromNode): Added.
- bindings/js/ScriptState.h: Ditto.
- bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromNode): Added.
- bindings/v8/ScriptState.h: Ditto.
- dom/NodeFilter.h: Removed JSDOMBinding header include.
- dom/NodeIterator.h: Ditto.
- dom/TreeWalker.h: Ditto.
- 12:44 PM Changeset in webkit [42900] by
-
- 4 edits in trunk
Bug 25428: 5 crashes in DumpRenderTree at com.apple.WebCore • -[AccessibilityObjectWrapper accessibilityAttributeValue:] + 830
https://bugs.webkit.org/show_bug.cgi?id=25428
- 12:33 PM Changeset in webkit [42899] by
-
- 2 edits in trunk/WebKitExamplePlugins
2009-04-27 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Update the example plug-in for new changes to the Cocoa event model.
- NetscapeCocoaPlugin/main.m: (handleDraw): (handleMouseEvent): (NPP_HandleEvent):
- 11:54 AM Changeset in webkit [42898] by
-
- 2 edits in trunk/WebKit/mac
Fix the Tiger build.
- Plugins/WebNetscapePluginView.mm: The base class of WebNetscapePluginView.mm, WebBaseNetscapePluginView, already implemented the two methods below. But the Tiger compiler didn't know that. (-[WebNetscapePluginView webView]): (-[WebNetscapePluginView webFrame]):
- 10:50 AM Changeset in webkit [42897] by
-
- 10 edits2 adds in trunk/WebKit
Reviewed by Anders Carlsson.
<rdar://problem/6352982>
- Plugins/WebBaseNetscapePluginView.mm: Removed checkIfAllowedToLoadURL:frame:callbackFunc, cancelCheckIfAllowedToLoadURL, and _webPluginContainerCancelCheckIfAllowedToLoadRequest from the base class. These methods now exist in the subclass WebNetscapePluginView.
Added WebNetscapeContainerCheckContextInfo, which is used as a "contextInfo" object in
-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]
- Plugins/WebNetscapeContainerCheckContextInfo.h: Added.
- Plugins/WebNetscapeContainerCheckContextInfo.mm: Added. (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:]): Added desiginated initializer. (-[WebNetscapeContainerCheckContextInfo checkRequestID]): Added. Returns the checkRequestID. (-[WebNetscapeContainerCheckContextInfo callback]): Added. Returns the callback.
- Plugins/WebNetscapePluginView.h: Added two new ivars: _containerChecksInProgress and _currentContainerCheckRequestID.
- Plugins/WebNetscapePluginView.mm: #import both WebPluginContainerCheck.h and WebNetscapeContainerCheckContextInfo.h
(-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]): Added. This is the implementation of WKN_CheckIfAllowedToLoadURL.
Here, we increment the request ID and start the container check.
(-[WebNetscapePluginView _containerCheckResult:contextInfo:]): Added. This is a callback method for WebPluginContainerCheck.
It's where we actually call into the plug-in and provide the allow-or-deny result.
(-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Added. This is the implementation of WKN_CancelCheckIfAllowedToLoadURL.
Here we lookup the check, cancel it, and remove it from _containerChecksInProgress.
(-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Added. WebPluginContainerCheck automatically calls
this method after invoking our _containerCheckResult: selector. It works this way because calling -[WebPluginContainerCheck cancel] allows
it to do it's teardown process.
(-[WebNetscapePluginView fini]): Release _containerChecksInProgress ivar.
- Plugins/WebPluginContainerCheck.h: Removed initWithRequest: method from header; no client was using this method directly.
- Plugins/WebPluginContainerCheck.mm: (+[WebPluginContainerCheck checkWithRequest:target:resultObject:selector:controller:contextInfo:]): Added optional contextInfo parameter. (-[WebPluginContainerCheck _continueWithPolicy:]): If there's a contextInfo object, pass it as a parameter to resultSelector. (-[WebPluginContainerCheck cancel]): Release _contextInfo ivar. (-[WebPluginContainerCheck contextInfo]): Added new method. Returns the contextInfo object, if one so exists.
- Plugins/WebPluginController.mm: (-[WebPluginController _webPluginContainerCheckIfAllowedToLoadRequest:inFrame:resultObject:selector:]): Pass nil for contextInfo. WebKit-style plug-ins do not need additional context information.
- 9:57 AM Changeset in webkit [42896] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25399
<rdar://problem/6633943> REGRESSION: Many crashes reported accessing Lexis/Nexis database,
beneath WebCore::Cache::evict
The crash happened because a cached resource handle was removed from a document's cached
resources map twice recursively, so a destructor was called for a value in a deleted bucket.
The first call was from Cache::evict, and when destroying CachedResourceHandle destroyed
CachedResource, DocLoader::removeCachedResource() was called again, with HashMap being in
an inconsistent state.
I couldn't fully reconstruct the loading sequence to make a test.
- loader/Cache.cpp: (WebCore::Cache::revalidateResource): Assert that the resource being revalidated is in cache (it makes no sense to revalidate one that isn't). (WebCore::Cache::evict): Don't remove the resource from document's map. Removing a resource from the cache in no way implies that documents no longer use the old version. This fixes the crash, and also fixes many cases of resource content being unavailable in Web Inspector.
- loader/CachedResource.h: (WebCore::CachedResource::setInCache): When bringing a revalidated resource back to cache, reset m_isBeingRevalidated to maintain the invariant of resources being revalidated never being in cache. This fixes another assertion I saw on LexisNexis search: in rare cases, switchClientsToRevalidatedResource() results in the same resource being requested again, but we were only enforcing CachedResource invariants after calling this function. (WebCore::CachedResource::unregisterHandle): Assert that the counter doesn't underflow.
- loader/DocLoader.cpp: (WebCore::DocLoader::removeCachedResource): Assert that the passed resource is removed, not some other resource that happens to have the same URL (this used to fail on LexisNexis search before this patch).
- loader/ImageDocument.cpp: (WebCore::ImageTokenizer::write): Replaced ASSERT_NOT_REACHED with notImplemented(). This method can be legally called via document.write(), and should work. LexisNexis takes this code path, but apparently has a fallback for Safari, so it doesn't affect site functionality.
- loader/CachedResource.cpp: (WebCore::CachedResource::clearResourceToRevalidate): Don't assert that m_resourceToRevalidate is being revalidated - this may no longer be true, because we now reset this member in CachedResource::setInCache().
- 9:24 AM Changeset in webkit [42895] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam Weinig.
- make BidiContext a RefCounted class, starting with a refcount of 1, and share the root BidiContexts.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawBidiText): Use BidiContext::create().
- platform/text/BidiContext.cpp: (WebCore::BidiContext::create): Added. For the four "root" contexts, returns a reference to a shared static BidiContext.
- platform/text/BidiContext.h: (WebCore::BidiContext::BidiContext):
- platform/text/BidiResolver.h: (WebCore::::commitExplicitEmbedding): Use BidiContext::create().
- rendering/bidi.cpp: (WebCore::RenderBlock::determineStartPosition): Ditto.
- 8:23 AM Changeset in webkit [42894] by
-
- 3 edits in trunk/WebCore
2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Gustavo Noronha.
Build fix for r42893: change GDK_exclaim to GDK_exclam
- platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 8:08 AM Changeset in webkit [42893] by
-
- 3 edits in trunk/WebCore
2009-04-27 Fumitoshi Ukai <ukai@google.com>
Reviewed by Xan Lopez.
Fix wrong key code conversion.
Missing conversion for GDK_exlaim ('!').
Parens are opposite: GDK_parenleft is open paren '('
and GDK_parenright is close paren ')'.
https://bugs.webkit.org/show_bug.cgi?id=25367
- platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 8:08 AM Changeset in webkit [42892] by
-
- 3 edits in trunk/WebCore
2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] gtkdrawing update
https://bugs.webkit.org/show_bug.cgi?id=25408
Update to the 25 Apr 2009 version of gtk2drawing.c and
gtkdrawing.h from Mozilla (http://hg.mozilla.org/mozilla-central)
- platform/gtk/gtk2drawing.c: (setup_widget_prototype): (moz_gtk_get_combo_box_entry_arrow): (ensure_toolbar_widget): (ensure_tree_header_cell_widget): (moz_gtk_init): (moz_gtk_button_get_inner_border): (moz_gtk_toggle_paint): (moz_gtk_caret_paint): (moz_gtk_entry_paint): (moz_gtk_tree_header_cell_paint): (moz_gtk_combo_box_paint): (moz_gtk_toolbar_separator_paint): (moz_gtk_menu_separator_paint): (moz_gtk_get_widget_border): (moz_gtk_get_tab_scroll_arrow_size): (moz_gtk_get_toolbar_separator_width): (moz_gtk_get_menu_separator_height): (moz_gtk_widget_paint): (moz_gtk_shutdown):
- platform/gtk/gtkdrawing.h:
- 8:08 AM Changeset in webkit [42891] by
-
- 2 edits in trunk/WebKitTools
2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] Make layout tests / jsc tests usable without build-webkit
https://bugs.webkit.org/show_bug.cgi?id=21784
This requires WEBKITOUTPUTDIR to be set to the build directory.
Set the location of the product dir to the location pointed to by
WEBKITOUTPUTDIR.
- Scripts/webkitdirs.pm:
- 7:54 AM Changeset in webkit [42890] by
-
- 2 edits in trunk/WebKitTools
2009-04-27 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Adam Roben.
Use libsoup's facilities to resolve relative URLs, instead, since
it is a more robust method.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::queueLoad):
- 7:53 AM Changeset in webkit [42889] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-27 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25409
[GTK] incorrectly fallsback on cancellation
Check whether we should fallback also on didFailLoad, so that we
don't get error pages showing up in parts of the content of some
sites because of, for instance, location changes.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
- 7:53 AM Changeset in webkit [42888] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-27 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25409
[GTK] incorrectly fallsback on cancellation
Correctly handle cancellation and frame loading interruption
caused by policy change. This also fixes
fast/frames/location-change.html.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::shouldFallBack):
- 6:55 AM Changeset in webkit [42887] by
-
- 2 edits in trunk/WebCore
2009-04-27 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Widget painting should follow the layout direction (LTR, RTL)
of the element style, not the application layout direction.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::applyTheme):
- 6:27 AM Changeset in webkit [42886] by
-
- 3 edits in trunk/JavaScriptCore
Windows Debug build fix
Not sure why the buildbots weren't affected by this problem.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Let VS re-order the file list, and added JavaScriptCore[_debug].def to the project. This was not necessary for the fix, but made making the fix easier.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Removed a function that no longer exists.
Apr 26, 2009:
- 10:58 PM Changeset in webkit [42885] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
Plug memory leak.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
- 10:17 PM Changeset in webkit [42884] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Weinig Sam.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25416
"Cached prototype accesses unsafely hoist property storage load above structure checks."
Do not hoist the load of the pointer to the property storage array.
No performance impact.
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList):
- 9:32 PM Changeset in webkit [42883] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey "Gaffe or energy?" Garen.
Randomize address requested by ExecutableAllocatorFixedVMPool.
- jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- 5:03 PM Changeset in webkit [42882] by
-
- 10 edits3 adds in trunk
WebCore:
2009-04-26 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25412
The Window object should be an EventTarget
Test: fast/dom/Window/dispatchEvent.html
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): Add DOMWindow case. (WebCore::toEventTarget): Ditto.
- dom/EventTarget.cpp: (WebCore::EventTarget::toDOMWindow): Added.
- dom/EventTarget.h:
- page/DOMWindow.cpp: (WebCore::DOMWindow::scriptExecutionContext): Added. Returns the document. (WebCore::DOMWindow::dispatchEvent): Added.
- page/DOMWindow.h: (WebCore::DOMWindow::toDOMWindow): (WebCore::DOMWindow::refEventTarget): (WebCore::DOMWindow::derefEventTarget):
- page/DOMWindow.idl:
LayoutTests:
2009-04-26 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Tests for https://bugs.webkit.org/show_bug.cgi?id=25412
The Window object should be an EventTarget
- fast/dom/Window/dispatchEvent-expected.txt: Added.
- fast/dom/Window/dispatchEvent.html: Added.
- fast/dom/Window/resources/dispatchEvent.js: Added.
- fast/dom/Window/window-properties-expected.txt
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 2:09 PM Changeset in webkit [42881] by
-
- 2 edits2 deletes in trunk
2009-04-26 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel.
Remove scons-based build system.
- JavaScriptCore.scons: Removed.
WebCore:
2009-04-26 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel.
Remove scons-based build system.
- WebCore.scons: Removed.
- 11:11 AM Changeset in webkit [42880] by
-
- 2 edits in trunk/WebKitTools
2009-04-26 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
Resolve relative URLs when queueing loads. This fixes
post-goback-same-url.html timing out.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::queueLoad):
- 10:23 AM Changeset in webkit [42879] by
-
- 5 edits in trunk/WebKit/gtk
2009-04-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25391
G_SIGNAL_ACTION flag in WebKitWebView signals
Most of the signals in WebKitGTK+ have the G_SIGNAL_ACTION flag,
but I don't think this makes sense. The flag is meant for those
signals that can be emitted by the user to trigger some action in
the view, as if it were a normal API, which is not the case for
most of them.
- webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_class_init):
- webkit/webkitwebframe.cpp:
- webkit/webkitwebinspector.cpp: (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
- webkit/webkitwebview.cpp:
- 10:11 AM Changeset in webkit [42878] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-26 Xan Lopez <xlopez@igalia.com>
Unreviewed, actually apply the right patch.
- webkit/webkitwebview.cpp: (webkit_web_view_move_cursor):
- 10:05 AM Changeset in webkit [42877] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Pass a variable to hold the return value of the 'move-cursor'
signal, otherwise a crash can happen.
- webkit/webkitwebview.cpp: (webkit_web_view_move_cursor):
- 7:25 AM Changeset in webkit [42876] by
-
- 2 edits in trunk/WebCore
2009-04-26 Darin Adler <Darin Adler>
Suggested by Darin Fisher.
Improve the fix for bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
https://bugs.webkit.org/show_bug.cgi?id=25355
rdar://problem/6823543
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Allow shouldScroll to be true even if m_currentHistoryItem is 0. Not sure if when this case can really arise in practice, but it's good to match the original logic more closely.
- 12:02 AM QtWebKitTodo edited by
- (diff)
- 12:01 AM Changeset in webkit [42875] by
-
- 2 edits in trunk/WebCore
2009-04-25 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
A width or height of zero for the destination or source rect of an
image causes a not invertible pattern matrix.
This crahes newer versions of Cairo and give some graphic gliches in
Canvas.
With this patch we check if there is something to draw and return if not.
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
Apr 25, 2009:
- 9:35 PM Changeset in webkit [42874] by
-
- 2 edits in trunk/LayoutTests
2009-04-25 Gustavo Noronha Silva <Gustavo Noronha Silva>
Go back to disabling accessibility tests as a whole, since we have
no real way of checking them, and no accessibilityController
implementation.
- platform/gtk/Skipped:
- 9:25 PM Changeset in webkit [42873] by
-
- 2 edits in trunk/LayoutTests
2009-04-25 Gustavo Noronha Silva <Gustavo Noronha Silva>
Disable tests that need eventSender, not yet implemented in our
DumpRenderTree.
- platform/gtk/Skipped:
- 9:11 PM Changeset in webkit [42872] by
-
- 6 edits2 adds in trunk
2009-04-24 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix point mapping and hit testing through transforms and perspective
with ENABLE_3D_RENDERING. Previously the code did the more efficient
move(), rather than getTransformFromContainer(), when the object had
no transform. However, this skipped the application of perspective
when the immediate child of the perspective element had no transform
itself.
Test: transforms/3d/point-mapping/3d-point-mapping-3.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::createLocalTransformState): Call shouldUseTransformFromContainer() to determine if we need to go through the more expensive getTransformFromContainer() code path.
- rendering/RenderObject.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::shouldUseTransformFromContainer): New method that indicates whether we need use getTransformFromContainer() when mapping points through renderers, and hit testing.
- 4:30 PM Changeset in webkit [42871] by
-
- 2 edits in trunk/WebKit/mac
2009-04-25 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Some *obvious* style cleanup in my last patch.
- History/WebBackForwardList.mm: (bumperCarBackForwardHackNeeded):
- 4:24 PM Changeset in webkit [42870] by
-
- 3 edits in trunk/WebKit/mac
2009-04-25 Brady Eidson <beidson@apple.com>
Reviewed by Oliver Hunt
<rdar://problem/6817607> BumperCar 2.2 crashes going back (invalid WebHistoryItem)
BumperCar was holding a pointer to a WebHistoryItem they never retain, then later
tried to go to it. In some cases it would be dealloc'ed first.
When WebHistoryItems were pure Objective-C they probably got away with this more often.
With the WebCore/Obj-C mixed WebHistoryItems it's more likely to crash.
- History/WebBackForwardList.mm: (bumperCarBackForwardHackNeeded): (-[WebBackForwardList backListWithLimit:]): If this is BumperCar, hang on to the NSArray of WebHistoryItems until the next time this method is called. (-[WebBackForwardList forwardListWithLimit:]): Ditto.
- Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_BUMPERCAR_BACK_FORWARD_QUIRK.
- 12:00 PM Changeset in webkit [42869] by
-
- 3 edits4 adds in trunk
WebCore:
2009-04-25 Adele Peterson <adele@apple.com>
Reviewed by Oliver Hunt.
Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
https://bugs.webkit.org/show_bug.cgi?id=25396
Test: editing/deleting/delete-br-013.html
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Only preserve an empty paragraph's style when moving paragraphs around if the selection is still in an empty paragraph after the move occurs. This was causing the empty paragraph's style to overwrite the previous paragraph's style during a delete of an empty paragraph.
LayoutTests:
2009-04-25 Adele Peterson <adele@apple.com>
Reviewed by Oliver Hunt.
Test for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
https://bugs.webkit.org/show_bug.cgi?id=25396
- editing/deleting/delete-br-013.html: Added.
- platform/mac/editing/deleting/delete-br-013-expected.checksum: Added.
- platform/mac/editing/deleting/delete-br-013-expected.png: Added.
- platform/mac/editing/deleting/delete-br-013-expected.txt: Added.
- 10:48 AM Changeset in webkit [42868] by
-
- 8 edits in trunk/WebCore
2009-04-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6808171> REGRESSION (3-4): Standalone media documents don't
properly display non-linear media
If a media engine claims it can support the MIME type, WebCore now creates a <video>
element for document mode media files instead of an <embed> element. Because WebCore's
QuickTime backed media players do not support every kind of media the QuickTime plug-in
supports, and because it is not always possible to tell what type of media is in a file
without opening and parsing it, some types of media that used to be displayed properly
by a plug-in are no longer supported properly. To fix this, if the media engine
sees that it can not completely support a media file it now informs the media
document, which replaces the <video> element with an <embed>.
r42301 landed support for OSX. This patch modifies those changes slighly and adds support
for Windows.
- loader/MediaDocument.cpp: (WebCore::MediaDocument::MediaDocument): Initialize m_replaceMediaElementTimer. (WebCore::MediaDocument::mediaElementSawUnsupportedTracks): Don't replace the <video> element immediately. (WebCore::MediaDocument::replaceMediaElementTimerFired): Renamed from replaceVideoWithEmbed. Set body margin-width and margin-height to 0 as that is what a PluginDocument uses.
- loader/MediaDocument.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::loadStateChanged): Don't do anything if m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::rateChanged): Ditto. (WebCore::MediaPlayerPrivate::timeChanged): Ditto. (WebCore::MediaPlayerPrivate::didEnd): Ditto. (WebCore::MediaPlayerPrivate::repaint): Ditto. (WebCore::MediaPlayerPrivate::paint): Ditto. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): Set m_hasUnsupportedTracks before callback.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_totalTrackCount and m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::updateStates): Call sawUnsupportedTracks if the movie has unsupported media type(s) or if it fails completely. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): New, disable the movie object and tell the media player client we won't play this movie correctly. (WebCore::MediaPlayerPrivate::didEnd): Don't do anything if m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::setSize): Ditto. (WebCore::MediaPlayerPrivate::setVisible): Ditto. (WebCore::MediaPlayerPrivate::paint): Ditto. (WebCore::MediaPlayerPrivate::movieEnded): Ditto. (WebCore::MediaPlayerPrivate::movieLoadStateChanged): Ditto. (WebCore::MediaPlayerPrivate::movieTimeChanged): Ditto. (WebCore::MediaPlayerPrivate::movieNewImageAvailable): Ditto.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::task): Stop the task timer if we were disabled during the load state change callback. (QTMovieWinPrivate::drawingComplete): Don't do anything if disabled. (QTMovieWin::QTMovieWin): Initialize m_disabled. (QTMovieWin::disableUnsupportedTracks): Return total number of tracks. (QTMovieWin::setDisabled): New, set m_disabled flag.
- platform/graphics/win/QTMovieWin.h:
- 7:02 AM Changeset in webkit [42867] by
-
- 5 edits in trunk/WebKit/gtk
2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=24786
WebKitDownload sometimes suggests peculiar filenames
Refactor the emission of the download-requested signal so that we
have less code duplication.
- WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::downloadURL):
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::startDownload):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp:
- 2:19 AM Changeset in webkit [42866] by
-
- 6 edits2 adds in trunk
2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] Error reporting
https://bugs.webkit.org/show_bug.cgi?id=18344
Fix the SOUP resource handle to report SOUP_HTTP_ERROR for Soup
errors and G_IO_ERROR for gio errors.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback): (WebCore::ResourceHandle::startHttp): (WebCore::ResourceHandle::start): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback): (WebCore::ResourceHandle::startGio):
2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] Error reporting
https://bugs.webkit.org/show_bug.cgi?id=18344
Update FrameLoad errors to use WebKitErrors.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::cancelledError): (WebKit::FrameLoaderClient::blockedError): (WebKit::FrameLoaderClient::cannotShowURLError): (WebKit::FrameLoaderClient::interruptForPolicyChangeError): (WebKit::FrameLoaderClient::cannotShowMIMETypeError): (WebKit::FrameLoaderClient::fileDoesNotExistError): (WebKit::FrameLoaderClient::pluginWillHandleLoadError): (WebKit::FrameLoaderClient::shouldFallBack):
- webkit/webkiterror.h: Added.
- webkit/webkiterror.cpp: Added.
2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] Error reporting
https://bugs.webkit.org/show_bug.cgi?id=18344
Add webkiterror to the build.
- GNUmakefile.am:
- 2:19 AM Changeset in webkit [42865] by
-
- 4 edits2 adds in trunk
2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] Error reporting
https://bugs.webkit.org/show_bug.cgi?id=18344
Add the default error page for installation.
- GNUmakefile.am:
2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
Display a default error page for load errors.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
- resources/error.html: Added.
- 2:19 AM Changeset in webkit [42864] by
-
- 5 edits in trunk/WebKit/gtk
2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] Error reporting
https://bugs.webkit.org/show_bug.cgi?id=18344
Add a WebKitWebFrame API to load alternate content for unreachable URLs.
Also add a new signal "load-error" for handling load errors.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification): (WebKit::FrameLoaderClient::dispatchDidFailLoading): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad):
- webkit/webkitwebframe.cpp:
- webkit/webkitwebframe.h:
- webkit/webkitwebview.cpp:
- 2:04 AM Changeset in webkit [42863] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- 1:44 AM Changeset in webkit [42862] by
-
- 3 edits in trunk/JavaScriptCore
2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Oliver Hunt.
Gtk build fix - check if we have MADV_FREE before using it.
- interpreter/RegisterFile.cpp: (JSC::RegisterFile::releaseExcessCapacity):
- wtf/Platform.h:
Apr 24, 2009:
- 9:03 PM Changeset in webkit [42861] by
-
- 2 edits in trunk/WebCore
2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Mark Rowe.
Only set the new URL once for the request. Doing it a second time
after the call to willSendRequest was causing crashes when
redirected requests got cancelled.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
- 8:44 PM Changeset in webkit [42860] by
-
- 8 edits in trunk
wx build fix. Switching JSCore from a static lib to a dynamic lib to match the Apple build and fix symbol exports.
- 8:19 PM Changeset in webkit [42859] by
-
- 2 edits in trunk/WebCore
wx build fix. Adding ScriptEventListener.cpp.
- 5:27 PM Changeset in webkit [42858] by
-
- 2 edits1 move in trunk/JavaScriptCore
2009-04-24 Laszlo Gombos <Laszlo Gombos>
Rubber-stamped by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=25337
Move ThreadingQt.cpp under the qt directory.
- JavaScriptCore.pri:
- wtf/ThreadingQt.cpp: Removed.
- wtf/qt/ThreadingQt.cpp: Copied from JavaScriptCore/wtf/ThreadingQt.cpp.
- 5:18 PM Changeset in webkit [42857] by
-
- 2 edits1 move in trunk/JavaScriptCore
2009-04-24 Laszlo Gombos <Laszlo Gombos>
Rubber-stamped by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=25338
Move ThreadingGtk.cpp under the gtk directory.
- GNUmakefile.am:
- wtf/ThreadingGtk.cpp: Removed.
- wtf/gtk/ThreadingGtk.cpp: Copied from JavaScriptCore/wtf/ThreadingGtk.cpp.
- 5:05 PM Changeset in webkit [42856] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-24 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Gustavo Noronha.
Fix braces to comply with style guidelines.
- WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getClipboard): (WebKit::PasteboardHelperGtk::getCopyTargetList): (WebKit::PasteboardHelperGtk::getPasteTargetList):
- 5:05 PM Changeset in webkit [42855] by
-
- 6 edits in trunk
2009-04-24 Sergio García-Cuevas <sergio_gcg@telefonica.net>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=17267
[GTK] Primary selection/clipboard support
Copy the link location to the primary selection as well as the
clipboard selection when using the "copy link selection" context
menu entry.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeURL):
- platform/gtk/PasteboardHelper.h:
2009-04-24 Sergio García-Cuevas <sergio_gcg@telefonica.net>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=17267
[GTK] Primary selection/clipboard support
Add a method for getting the primary selection.
- WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getPrimary):
- WebCoreSupport/PasteboardHelperGtk.h:
- 4:54 PM Changeset in webkit [42854] by
-
- 7 edits in trunk
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=25383
Changing SVG size via JS does not update CSS width/height
Add an ugly hack to fix CSS width/height updates from JS.
We can't easily call setAttribute when width/height changes
as that would cause infinite recursion (as we'd try to set
the animation storage from the attributes)
For now, when we get notification that JS changed width/height
we copy what parseMappedAttribute does and update the CSS values as well.
A better fix for this would be:
https://bugs.webkit.org/show_bug.cgi?id=25383
- svg/SVGSVGElement.cpp: (WebCore::updateCSSForAttribute): (WebCore::SVGSVGElement::svgAttributeChanged):
- 4:51 PM Changeset in webkit [42853] by
-
- 6 edits in trunk/JavaScriptCore
2009-04-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam "Wesley" Weinig.
Improve performance to YARR interpreter.
(From about 3x slower than PCRE on regex-dna to about 30% slower).
- yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::checkCharacter): (JSC::Yarr::Interpreter::checkCasedCharacter): (JSC::Yarr::Interpreter::backtrackPatternCharacter): (JSC::Yarr::Interpreter::backtrackPatternCasedCharacter): (JSC::Yarr::Interpreter::matchParentheticalAssertionBegin): (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd): (JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin): (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd): (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::Interpreter::interpret): (JSC::Yarr::ByteCompiler::atomPatternCharacter): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin): (JSC::Yarr::ByteCompiler::closeAlternative): (JSC::Yarr::ByteCompiler::closeBodyAlternative): (JSC::Yarr::ByteCompiler::atomParenthesesEnd): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::regexEnd): (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction): (JSC::Yarr::ByteCompiler::alterantiveDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
- yarr/RegexInterpreter.h: (JSC::Yarr::ByteTerm::): (JSC::Yarr::ByteTerm::ByteTerm): (JSC::Yarr::ByteTerm::BodyAlternativeBegin): (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction): (JSC::Yarr::ByteTerm::BodyAlternativeEnd): (JSC::Yarr::ByteTerm::AlternativeBegin): (JSC::Yarr::ByteTerm::AlternativeDisjunction): (JSC::Yarr::ByteTerm::AlternativeEnd): (JSC::Yarr::ByteTerm::SubpatternBegin): (JSC::Yarr::ByteTerm::SubpatternEnd):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
- yarr/RegexPattern.h:
- 4:41 PM Changeset in webkit [42852] by
-
- 2 edits in trunk/WebCore
2009-04-24 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan Bernstein.
We should not show the deletion UI for blockquotes in mail but they do
show now that we only check for one visible border.
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- 4:28 PM Changeset in webkit [42851] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-24 Rob Raguet-Schofield <ragfield@gmail.com>
Rubber-stamped by Mark Rowe.
- wtf/CurrentTime.h: Fix a typo in a comment.
- 4:05 PM Changeset in webkit [42850] by
-
- 2 edits in trunk/WebCore
- address Hyatt's review comments on the last patch
- rendering/RenderLayer.cpp: (WebCore::performOverlapTests): (WebCore::RenderLayer::paintLayer):
- 4:00 PM Changeset in webkit [42849] by
-
- 10 edits1 add in trunk/WebCore
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=5909 <rdar://problem/5863349> overlapping element leaves trail when scrolling iframe
- WebCore.xcodeproj/project.pbxproj: Added OverlapTestRequestClient.h.
- page/FrameView.cpp: (WebCore::FrameView::reset): Initialize m_isOverlapped. (WebCore::FrameView::useSlowRepaints): Also check m_isOverlapped. (WebCore::FrameView::removeSlowRepaintObject): Use useSlowRepaints() so overlapping is taken into account. (WebCore::FrameView::setIsOverlapped): Added. Sets m_isOverlapped and enables or disables copy-on-scroll accordingly.
- page/FrameView.h: Added setIsOverlapped() and m_isOverlapped.
- rendering/OverlapTestRequestClient.h: Added. During foreground painting, an OverlapTestRequestClient can make a request to test if any subsequently- painted layers overlap a rect. The test result is delivered to the requestClient via setOverlapTestResult(). (WebCore::OverlapTestRequestClient::~OverlapTestRequestClient):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): Pass an OverlapTestRequestMap to paintLayer(). When done painting, inform any remaining requestClients that they are not overlapped.
(WebCore::RenderLayer::paintLayer): Take an OverlapTestRequestMap and
pass it down to child and reflection layers. Inform requestClients if this
layer overlaps their requested rects.
- rendering/RenderLayer.h:
- rendering/RenderObject.h: (WebCore::RenderObject::PaintInfo::PaintInfo): Added an OverlapTestRequestMap member.
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): For now, pass a 0 OverlapTestRequestMap to paintLayer().
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): For FrameViews, request an overlap test with the frame. (WebCore::RenderWidget::setOverlapTestResult): Call FrameView::setIsOverlapped() with the result of the overlap test.
- rendering/RenderWidget.h: Made RenderWidget an OverlapTestRequestClient.
- 3:52 PM Changeset in webkit [42848] by
-
- 3 edits in trunk/LayoutTests
2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser
Fixed a race condition on the first 'played' attribute test start.
Previously we were starting nearly right away to play, and probably
before receiving the 'canplay' event. Now we ensure we'll wait for
that 'canplay' event before attempting to play.
- media/video-played-expected.txt: Updated
- media/video-played.html:
- 3:45 PM Changeset in webkit [42847] by
-
- 2 edits in trunk/LayoutTests
2009-04-24 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Eric Seidel.
Updated test to turn the buildbot green after Eric's last check-in.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
- 3:30 PM Changeset in webkit [42846] by
-
- 22 edits2 deletes in trunk/WebCore
2009-04-24 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser, Dan Bernstein.
Speed up the PLT by devirtualizing the height() function on InlineBox. virtualizing it in order to make the height() computation dynamic caused
a ~0.5% slowdown. This patch does the following to get the speed back:
(a) Devirtualizes isText and forces inline box creators to set the bit as needed. This actually resulted in simplified code, since ListMarkerBox could
then be removed.
(b) Reduces the height() call count. In some cases the code was repeatedly calling height(), which used to be fine when the function was just an inline
member variable access. The call sites have been patched to cut down on extra height() calls now that it is more expensive.
(c) Devirtualize height() except on SVG boxes. For all non-SVG, the height() function on InlineBox handles the computation. For SVG boxes, a new bit has
been set on InlineBoxes (isSVG()) that indicates that the virtual svgBoxHeight() function should be called to retrieve the height instead.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- rendering/InlineBox.cpp: (WebCore::InlineBox::height):
- rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isSVG): (WebCore::InlineBox::setIsSVG): (WebCore::InlineBox::isText): (WebCore::InlineBox::setIsText): (WebCore::InlineBox::svgBoxHeight):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.cpp:
- rendering/InlineTextBox.h:
- rendering/ListMarkerBox.cpp: Removed.
- rendering/ListMarkerBox.h: Removed.
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::createInlineBox):
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createFlowBox):
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::createTextBox):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootBox):
- rendering/RenderText.cpp: (WebCore::RenderText::createInlineTextBox):
- rendering/RootInlineBox.cpp:
- rendering/RootInlineBox.h:
- rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::svgBoxHeight):
- rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::svgBoxHeight):
- rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::svgBoxHeight):
- 3:25 PM Changeset in webkit [42845] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam Roben.
Add PrettyPatch support to run-webkit-tests
- Scripts/run-webkit-tests:
- 3:09 PM Changeset in webkit [42844] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
- 3:00 PM Changeset in webkit [42843] by
-
- 24 edits4 adds in trunk/WebCore
2009-04-24 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25370
Introduce ScriptEventListener to refactor away direct references to
JSLazyEventListener in WebCore code.
- GNUmakefile.am: Added ScriptEventListener to project.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
- bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers
to ScriptEventListener.
- bindings/js/JSLazyEventListener.h: Ditto.
- bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
- bindings/js/ScriptEventListener.cpp: Added.
- bindings/js/ScriptEventListener.h: Added.
- bindings/v8/ScriptEventListener.cpp: Added.
- bindings/v8/ScriptEventListener.h: Added.
- dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
- html/HTMLBodyElement.cpp: Ditto.
- html/HTMLButtonElement.cpp: Ditto.
- html/HTMLElement.cpp: Ditto.
- html/HTMLFormElement.cpp: Ditto.
- html/HTMLFrameElementBase.cpp: Ditto.
- html/HTMLFrameSetElement.cpp: Ditto.
- html/HTMLImageElement.cpp: Ditto.
- html/HTMLInputElement.cpp: Ditto.
- html/HTMLObjectElement.cpp: Ditto.
- html/HTMLScriptElement.cpp: Ditto.
- html/HTMLSelectElement.cpp: Ditto.
- html/HTMLTextAreaElement.cpp: Ditto.
- svg/SVGElement.cpp: Ditto.
- svg/SVGSVGElement.cpp: Ditto.
- 2:53 PM Changeset in webkit [42842] by
-
- 3 edits in trunk/JavaScriptCore
<rdar://problem/6050421> JavaScript register file should remap to release physical pages accumulated during deep recursion
Reviewed by Geoff Garen
We now track the maximum extent of the RegisterFile, and when we reach the final
return from JS (so the stack portion of the registerfile becomes empty) we see
if that extent is greater than maxExcessCapacity. If it is we use madvise or
VirtualFree to release the physical pages that were backing the excess.
- 2:52 PM Changeset in webkit [42841] by
-
- 2 edits in trunk/WebCore
2009-04-24 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
https://bugs.webkit.org/show_bug.cgi?id=25355
rdar://problem/6823543
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Added a null check.
- 2:34 PM Changeset in webkit [42840] by
-
- 44 edits in trunk
Reviewed by Simon Fraser.
Fix RenderSVGImage to dump with full bounds and style information.
https://bugs.webkit.org/show_bug.cgi?id=25377
No functional changes, we're just now including more info in render tree dumps.
- rendering/RenderObject.h: (WebCore::RenderObject::isSVGImage):
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::isSVGImage):
- rendering/RenderTreeAsText.cpp: (WebCore::write):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::write):
- rendering/SVGRenderTreeAsText.h:
- 2:30 PM Changeset in webkit [42839] by
-
- 2 edits in trunk/WebKit/mac
2009-04-24 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Fix <rdar://problem/6761635>.
Make sure to keep an extra reference to the instance proxy in case the plug-in host crashes while
we're waiting for a reply.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy):
- 2:18 PM Changeset in webkit [42838] by
-
- 7 edits in trunk/WebCore
2009-04-24 David Levin <levin@chromium.org>
Reviewed by NOBODY (chromium build fix).
Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::invokeEventHandler):
- bindings/v8/V8AbstractEventListener.h:
- bindings/v8/V8EventListenerList.cpp: (WebCore::V8EventListenerList::add): (WebCore::V8EventListenerList::remove): (WebCore::V8EventListenerList::clear):
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::virtualisAttribute):
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
- bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): (WebCore::V8EventListener::virtualisAttribute):
- 2:16 PM Changeset in webkit [42837] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-24 Johan Bilien <jobi@via.ecp.fr>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25373
Popup menu has the wrong size when popped up near the edge
of the screen
- webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event): Let GTK place the popup menu instead of trying to do better and failing
- 1:48 PM Changeset in webkit [42836] by
-
- 19 edits in trunk/LayoutTests
2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser
<rdar://problem/6805928> Re-export layout test MPEG-4 file to remove unusual edit
Use better mp4 test file for media tests. The original mp4 file had an unusual
edit (non-zero start time) which is not supported by all media engines. The new
movie should also give more useful pixel test results.
- media/content/test.mp4: Update the movie.
- media/progress-event-total-expected.txt: Update test results to match movie duration and content changes.
- media/progress-event-total.html: Ditto.
- media/video-currentTime-set-expected.txt: Ditto.
- media/video-loop-expected.txt: Ditto.
- platform/mac/media/video-aspect-ratio-expected.checksum: Ditto.
- platform/mac/media/video-aspect-ratio-expected.png: Ditto.
- platform/mac/media/video-controls-rendering-expected.checksum: Ditto.
- platform/mac/media/video-controls-rendering-expected.png: Ditto.
- platform/mac/media/video-display-toggle-expected.checksum: Ditto.
- platform/mac/media/video-display-toggle-expected.png: Ditto.
- platform/mac/media/video-empty-source-expected.checksum: Ditto.
- platform/mac/media/video-layer-crash-expected.checksum: Ditto.
- platform/mac/media/video-layer-crash-expected.png: Ditto.
- platform/mac/media/video-transformed-expected.checksum: Ditto.
- platform/mac/media/video-transformed-expected.png: Ditto.
- platform/mac/media/video-zoom-expected.checksum: Ditto.
- platform/mac/media/video-zoom-expected.png: Ditto.
- 1:08 PM Changeset in webkit [42835] by
-
- 2 edits in trunk/WebKitTools
Fix nightly for Windows x64 users.
Installed browser location is written to a slightly different registry key in that case.
- FindSafari/FindSafari.cpp: (getInstalledWebKitDirectory):
- 12:13 PM Changeset in webkit [42834] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-04-24 Kevin McCullough <kmccullough@apple.com>
When I moved the files I forgot to update the location of the image!
- platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
- platform/mac/editing/deleting/deletionUI-differing-background.html: Added.
- 11:43 AM Changeset in webkit [42833] by
-
- 2 edits in trunk/WebCore
2009-04-24 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25343
Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset
ignores blur.
- WebCore\platform\graphics\skia\GraphicsContextSkia.cpp (WebCore::GraphicsContext::setPlatformShadow): Add check against blur before clearing looper.
- 11:41 AM Changeset in webkit [42832] by
-
- 1 edit3 deletes in trunk/LayoutTests
2009-04-24 Kevin McCullough <kmccullough@apple.com>
- Build fix. Removed this test until I can figure out why it's failing.
- platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
- platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
- platform/mac/editing/deleting/deletionUI-differing-background.html: Removed.
- 11:40 AM Changeset in webkit [42831] by
-
- 3 edits2 adds in trunk
WebCore:
2009-04-24 Eric Roman <eroman@chromium.org>
Reviewed by Darin Adler.
Initialize TextIterator::m_textLength to 0.
This assures that TextIterator::length() will return 0 for cases when TextIterator's constructor returns early (because there is nothing to iterate over in the range).
Test: editing/selection/doubleclick-whitespace-img-crash.html
- editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator):
LayoutTests:
2009-04-24 Eric Roman <eroman@chromium.org>
Reviewed by Darin Adler.
Add a test for <https://bugs.webkit.org/show_bug.cgi?id=25335>.
To pass, this test must not access invalid memory when run (won't necessarily manifest as a crash for failures).
- editing/selection/doubleclick-whitespace-img-crash-expected.txt: Added.
- editing/selection/doubleclick-whitespace-img-crash.html: Added.
- 11:38 AM Changeset in webkit [42830] by
-
- 3 edits in trunk/WebKitLibraries
2009-04-24 Simon Fraser <Simon Fraser>
Source changes reviewed by Darin Adler
Update WebKitSystemInterface for Mac with fixes for video controller drawing.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 11:36 AM Changeset in webkit [42829] by
-
- 1 edit1 add in trunk/WebCore
2009-04-24 Fumitoshi Ukai <ukai@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25329
Add indexed access method in v8 binding of ClientRectList.
- bindings/v8/custom/V8ClientRectListCustom.cpp: Added.
- 11:32 AM Changeset in webkit [42828] by
-
- 4 edits3 adds in trunk
WebCore:
2009-04-24 Fumitoshi Ukai <ukai@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25257
Use null for unspecified event listener attributes of XMLHttpRequest
and XMLHttpRequestUpload in v8 binding.
cf. http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
An event handler attribute, unless otherwise specified, can either
have the value null or be set to a Function object.
Initially, an event handler attribute must be set to null.
Test: fast/xmlhttprequest/xmlhttprequest-default-attributes.html
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER): Changed to use v8::Null().
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_GETTER): Ditto.
LayoutTests:
2009-04-24 Fumitoshi Ukai <ukai@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25257
Verify XMLHttpRequest has correct attribute value by default.
- fast/xmlhttprequest/resources/xmlhttprequest-default-attributes.js: Added.
- fast/xmlhttprequest/xmlhttprequest-default-attributes-expected.txt: Added.
- fast/xmlhttprequest/xmlhttprequest-default-attributes.html: Added.
- 11:02 AM Changeset in webkit [42827] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-24 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Gustavo Noronha.
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Reword the description of the enable-spell-checking property and correct the mentioning of the default language used.
- 10:42 AM Changeset in webkit [42826] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-04-24 Kevin McCullough <kmccullough@apple.com>
Speculative fix for leopard build-bot until I have a fix on leopard.
- platform/mac-leopard/editing: Added.
- platform/mac-leopard/editing/deleting: Added.
- platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Added.
- 9:38 AM Changeset in webkit [42825] by
-
- 2 edits in trunk/WebCore
2009-04-24 Darin Adler <Darin Adler>
Reviewed by Adam Roben.
<rdar://problem/6663836> CrashTracer: crashes in Safari at com.apple.WebCore • WebCore::reportException + 1513
- bindings/js/JSDOMBinding.cpp: (WebCore::reportException): Added a null check.
- 9:13 AM Changeset in webkit [42824] by
-
- 2 edits in trunk/WebKit/mac
2009-04-24 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
Currently working on a bug where a WebHistoryItem was being used after being dealloc'ed.
I added this assertion to help catch the case as soon as it happens instead of random
issues downstream. Figured it's worth checking in by itself.
- History/WebHistoryItem.mm: (core): ASSERT that the WebCore::HistoryItem inside this WebHistoryItem is supposed to have this WebHistoryItem as a wrapper.
- 9:10 AM Changeset in webkit [42823] by
-
- 4 edits4 adds in trunk
2009-04-24 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Add support for transtions and animations of background-position, -webkit-background-size,
-webkit-mask-position and -webkit-mask-size.
Tests: transitions/background-transitions.html
transitions/mask-transitions.html
- page/animation/AnimationBase.cpp: (WebCore::blendFunc): Add a blend func for LengthSize.
(WebCore::ensurePropertyMap):
Add wrappers for the new properties.
(WebCore::addShorthandProperties):
Add a shorthand property for CSSPropertyBackgroundPosition to map to
CSSPropertyBackgroundPositionX and CSSPropertyBackgroundPositionY,
add CSSPropertyWebkitMask for CSSPropertyWebkitMaskPosition, and add
CSSPropertyWebkitMaskPosition for CSSPropertyWebkitMaskPositionX and
CSSPropertyWebkitMaskPositionY.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBackgroundXPosition): (WebCore::InheritedFlags::setBackgroundYPosition): (WebCore::InheritedFlags::setBackgroundSize): (WebCore::InheritedFlags::setMaskXPosition): (WebCore::InheritedFlags::setMaskYPosition): (WebCore::InheritedFlags::setMaskSize): Add setters for the properties that can be animated now.
- 8:55 AM Changeset in webkit [42822] by
-
- 7 edits in trunk/LayoutTests
2009-04-24 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Updating these pixel results to the generated results on Leopard.
- platform/mac/editing/inserting/5510537-expected.checksum:
- platform/mac/editing/inserting/5510537-expected.png:
- platform/mac/editing/inserting/6703873-expected.checksum:
- platform/mac/editing/inserting/6703873-expected.png:
- platform/mac/editing/selection/select-all-iframe-expected.checksum:
- platform/mac/editing/selection/select-all-iframe-expected.png:
- 8:39 AM Changeset in webkit [42821] by
-
- 7 edits4 adds in trunk
WebCore:
2009-04-24 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup
Test: editing/pasteboard/paste-blockquote-after-blockquote.html
When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
But we should only merge here if the selection start was inside a mail blockquote. This prevents against removing a
blockquote from newly pasted quoted content that was pasted into an unquoted position. If that unquoted position happens
to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs. (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
- editing/ReplaceSelectionCommand.h:
LayoutTests:
2009-04-24 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Test for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup
- editing/pasteboard/paste-blockquote-after-blockquote.html: Added.
- platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Added.
- platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
- platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
- 6:16 AM Changeset in webkit [42820] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking
Implement EditorClient::ignoreWordInSpellDocument,
EditorClient::learnWord and EditorClient::getGuessesForWord. This
enables the corresponding user actions.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::ignoreWordInSpellDocument): (WebKit::EditorClient::learnWord): (WebKit::EditorClient::getGuessesForWord):
- 6:16 AM Changeset in webkit [42819] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking
Implement EditorClient::checkSpellingOfString; enabling spell checking
to actually happen, this is the basis for other spelling functions.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
- 6:16 AM Changeset in webkit [42818] by
-
- 6 edits in trunk
2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking
Add enchant support for spell-checking-languages property to work
properly.
- GNUmakefile.am:
- configure.ac:
WebKit/gtk
2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking
Add spell-checking-languages property to WebKitWebSettings.
- webkit/webkitprivate.h:
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_init): (_WebKitWebSettingsPrivate::webkit_web_settings_finalize): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy): (_WebKitWebSettingsPrivate::webkit_web_settings_get_spell_languages):
- 6:16 AM Changeset in webkit [42817] by
-
- 3 edits in trunk/WebKit/gtk
2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking
Add enable-spell-checking property to WebKitWebSettings and implement
EditorClient::isContinuousSpellCheckingEnabled and
EditorClient::toggleContinuousSpellChecking to allow the UI to
enable check as you type spell checking.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isContinuousSpellCheckingEnabled): (WebKit::EditorClient::toggleContinuousSpellChecking):
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
- 4:12 AM Changeset in webkit [42816] by
-
- 1 edit1 add in trunk/LayoutTests
2009-04-24 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
Added Qt-specific expected result for color conversion.
This is to compensate the lack of color profile in Qt to do
color conversion, hence CMYK 0,0,0,1 always give pure black (#000)
instead of very dark black.
- platform/qt/fast/canvas/set-colors-expected.txt: Added.
- 4:08 AM Changeset in webkit [42815] by
-
- 2 edits in trunk/WebKit/qt
2009-04-24 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Ariya Hidayat.
Fix qdoc warning about link to QAction::isEnabled.
- 3:30 AM Changeset in webkit [42814] by
-
- 5 edits13 adds in trunk
2009-04-24 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Added support for generating API docs in the Qt build using "make docs"
Added code snippets and overview from the Qt sources references in the API docs.
- 1:24 AM QtWebKitJournal edited by
- (diff)
Apr 23, 2009:
- 11:38 PM Changeset in webkit [42813] by
-
- 5 edits in trunk/LayoutTests
2009-04-23 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Updating test to make it easier to see the blockquote in the results.
- editing/pasteboard/paste-blockquote-into-blockquote-3.html:
- platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
- platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
- platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:
- 11:03 PM Changeset in webkit [42812] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Move deletionUI-helpers.js in to the correct location so that the
tests that use it can find it.
- platform/mac/editing/deleting/resources/deletionUI-helpers.js: Renamed from LayoutTests/editing/deleting/resources/deletionUI-helpers.js.
- 10:12 PM Changeset in webkit [42811] by
-
- 2 edits in trunk/JavaScriptCore
With great sadness and a heavy heart I switch us back from YARR to WREC in
order to restore greenness to the world once more.
- wtf/Platform.h:
- 10:04 PM Changeset in webkit [42810] by
-
- 3 edits in trunk/JavaScriptCore
More Windows build fixage.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 9:16 PM Changeset in webkit [42809] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix the Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove a symbol that no longer exists.
- 8:47 PM Changeset in webkit [42808] by
-
- 25 edits3 adds2 deletes in trunk
BUG 24604: WebKit profiler reports incorrect total times
2009-04-23 Francisco Tolmasky <francisco@280north.com>
BUG 24604: WebKit profiler reports incorrect total times
<https://bugs.webkit.org/show_bug.cgi?id=24604>
Reviewed by Timothy Hatcher and Kevin McCullough.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- profiler/CallIdentifier.h: (JSC::CallIdentifier::Hash::hash): (JSC::CallIdentifier::Hash::equal): (JSC::CallIdentifier::hash): (WTF::):
- profiler/HeavyProfile.cpp: Removed.
- profiler/HeavyProfile.h: Removed.
- profiler/Profile.cpp: No more need for TreeProfile/HeavyProfile (JSC::Profile::create):
- profiler/Profile.h:
- profiler/ProfileNode.cpp:
- profiler/ProfileNode.h:
- profiler/TreeProfile.cpp: Removed.
- profiler/TreeProfile.h: Removed.
WebCore:
2009-04-23 Francisco Tolmasky <francisco@280north.com>
BUG 24604: WebKit profiler reports incorrect total times
<https://bugs.webkit.org/show_bug.cgi?id=24604>
Reviewed by Timothy Hatcher and Kevin McCullough.
Made it so that most of the profiler functions now match the behavior of Shark. Most notably, in the
heavy view, child nodes now represent the statistics of the root node. Each root node of heavy view
displays flattened statistics for a particular function that ran during the profile, and each child
of these root nodes represents a callpath that lead to it. Thus, the statistics for each of these child
nodes should show how much of the root nodes values came from it. For example, if you had the following to
stacks take place during the profile:
A ->calls 1 times-> B ->calls 2 times-> C
D ->calls 4 times-> C
The tree for the C root node would look like this:
C -> B -> A
-> D
The number of calls values would look like this:
C (6) -> B (2) -> A(2)
-> D (4)
What this means is that "2 of the total 6 C calls came from B", "2 of the total C calls came from A", and
"4 of the total C calls came from D". Notice that the "A ->calls 2 time->" is completely ignored. This becomes
particularly tricky during recursive calls, because each child note can represent multiple possible paths. This
is the reason that we would get things like 40000% previously with recursion.
This is also the way gprof works, and as close as we can get to Shark's behavior (Shark is not instrumented so it
can't know exactly how many calls came from where, etc).
- English.lproj/localizedStrings.js: Added "Average" for average times in the profile.
- inspector/JavaScriptProfile.cpp: (WebCore::ProfileClass):
- inspector/JavaScriptProfileNode.cpp: (WebCore::getParent): (WebCore::getHead): (WebCore::getCallUID): (WebCore::ProfileNodeClass):
- inspector/front-end/BottomUpProfileDataGridTree.js: Added. (WebInspector.BottomUpProfileDataGridTree): (WebInspector.BottomUpProfileDataGridTree.prototype.focus): (WebInspector.BottomUpProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.insertChild): (WebInspector.DataGrid.prototype.removeChild): (WebInspector.DataGrid.prototype.removeChildren): (WebInspector.DataGridNode.prototype.set hasChildren): (WebInspector.DataGridNode.prototype.get hasChildren):
- inspector/front-end/ProfileDataGridTree.js: Added. (WebInspector.ProfileDataGridNode): (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds): (WebInspector.ProfileDataGridNode.prototype.get data): (WebInspector.ProfileDataGridNode.prototype.createCell): (WebInspector.ProfileDataGridNode.prototype.select): (WebInspector.ProfileDataGridNode.prototype.deselect): (WebInspector.ProfileDataGridNode.prototype.expand): (WebInspector.ProfileDataGridNode.prototype.insertChild): (WebInspector.ProfileDataGridNode.prototype.removeChild): (WebInspector.ProfileDataGridNode.prototype.removeChildren): (WebInspector.ProfileDataGridNode.prototype.findChild): (WebInspector.ProfileDataGridNode.prototype.get averageTime): (WebInspector.ProfileDataGridNode.prototype.get averagePercent): (WebInspector.ProfileDataGridNode.prototype.get selfPercent): (WebInspector.ProfileDataGridNode.prototype.get totalPercent): (WebInspector.ProfileDataGridNode.prototype._save): (WebInspector.ProfileDataGridNode.prototype._restore): (WebInspector.ProfileDataGridNode.prototype._merge): (WebInspector.ProfileDataGridTree): (WebInspector.ProfileDataGridTree.prototype.get expanded): (WebInspector.ProfileDataGridTree.prototype.appendChild): (WebInspector.ProfileDataGridTree.prototype.insertChild): (WebInspector.ProfileDataGridTree.prototype.removeChildren): (WebInspector.ProfileDataGridTree.prototype.findChild.WebInspector.ProfileDataGridNode.prototype.findChild.sort.WebInspector.ProfileDataGridNode.prototype.sort._save): (WebInspector.ProfileDataGridTree.propertyComparator.comparator): (WebInspector.ProfileDataGridTree.propertyComparator.else.comparator): (WebInspector.ProfileDataGridTree.propertyComparator):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView): (WebInspector.ProfileView.prototype.set profile): (WebInspector.ProfileView.prototype.get bottomUpProfileDataGridTree): (WebInspector.ProfileView.prototype.get topDownProfileDataGridTree): (WebInspector.ProfileView.prototype.get currentTree): (WebInspector.ProfileView.prototype.set currentTree): (WebInspector.ProfileView.prototype.get topDownTree): (WebInspector.ProfileView.prototype.get bottomUpTree): (WebInspector.ProfileView.prototype.refresh): (WebInspector.ProfileView.prototype.refreshVisibleData): (WebInspector.ProfileView.prototype.refreshShowAsPercents): (WebInspector.ProfileView.prototype.performSearch.matchesQuery): (WebInspector.ProfileView.prototype.performSearch): (WebInspector.ProfileView.prototype._changeView): (WebInspector.ProfileView.prototype._focusClicked): (WebInspector.ProfileView.prototype._excludeClicked): (WebInspector.ProfileView.prototype._resetClicked): (WebInspector.ProfileView.prototype._sortProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.showProfile): (WebInspector.ProfilesPanel.prototype.showView): (WebInspector.ProfilesPanel.prototype.searchMatchFound):
- inspector/front-end/TopDownProfileDataGridTree.js: Added. (WebInspector.TopDownProfileDataGridNode): (WebInspector.TopDownProfileDataGridNode.prototype._populate): (WebInspector.TopDownProfileDataGridNode.prototype._exclude): (WebInspector.TopDownProfileDataGridTree): (WebInspector.TopDownProfileDataGridTree.prototype.focus): (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
LayoutTests:
2009-04-23 Francisco Tolmasky <francisco@280north.com>
BUG 24604: WebKit profiler reports incorrect total times
<https://bugs.webkit.org/show_bug.cgi?id=24604>
Reviewed by Timothy Hatcher and Kevin McCullough.
Changed profile.treeProfile to just profile, since these aren't generated in C++ anymore.
Removed heavy-view test since heavy-view isn't an actual tree that is generated in C++ land anymore,
but rather just a different display of the normal treeProfile in the JS data grid.
- fast/profiler/heavy-view-expected.txt: Removed.
- fast/profiler/heavy-view.html: Removed.
- fast/profiler/resources/profiler-test-JS-resources.js: profiles[i].treeProfile -> profiles[i].treeProfile (printProfilesDataWithoutTime):
- 6:50 PM Changeset in webkit [42807] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
Use static functions (and a couple templates)
to further reduce the amount of copy/paste code in SVGRenderTreeAsText
No test changes, only code cleanup.
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeNameValuePair): (WebCore::writeNameAndQuotedValue): (WebCore::writeIfNotEmpty): (WebCore::writeIfNotDefault): (WebCore::writeStyle): (WebCore::writePositionAndStyle): (WebCore::operator<<):
- 6:42 PM Changeset in webkit [42806] by
-
- 1 edit3 moves in trunk/LayoutTests
2009-04-23 Kevin McCullough <kmccullough@apple.com>
- Windows build fix. Mac only tests go in platform/mac
- editing/deleting/deletionUI-borders.html: Removed.
- editing/deleting/deletionUI-differing-background.html: Removed.
- editing/deleting/deletionUI-minimum-size.html: Removed.
- platform/mac/editing/deleting/deletionUI-borders.html: Copied from editing/deleting/deletionUI-borders.html.
- platform/mac/editing/deleting/deletionUI-differing-background.html: Copied from editing/deleting/deletionUI-differing-background.html.
- platform/mac/editing/deleting/deletionUI-minimum-size.html: Copied from editing/deleting/deletionUI-minimum-size.html.
- 6:09 PM Changeset in webkit [42805] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-23 Gavin Barraclough <barraclough@apple.com>
Not Reviewed.
Speculative Windows build fix II.
- yarr/RegexInterpreter.cpp:
- 5:53 PM Changeset in webkit [42804] by
-
- 3 edits in trunk/JavaScriptCore
2009-04-23 Gavin Barraclough <barraclough@apple.com>
Not Reviewed.
Speculative Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- runtime/RegExp.cpp:
- 5:50 PM Changeset in webkit [42803] by
-
- 4 edits in trunk/WebCore
Reviewed by Simon Fraser.
SVGRenderTreeAsText cleanup/code sharing.
No test changes, only code cleanup.
- rendering/RenderText.cpp: (WebCore::RenderText::firstRunOrigin):
- rendering/RenderText.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStandardPrefix): (WebCore::writeChildren): (WebCore::write): (WebCore::writeRenderResources):
- 5:39 PM Changeset in webkit [42802] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-23 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by salty sea dogs Sam & Geoff.
Enable YARR_JIT by default (where supported), replacing WREC.
- wtf/Platform.h:
- 5:37 PM Changeset in webkit [42801] by
-
- 1 edit2 deletes in trunk/LayoutTests
2009-04-23 Darin Adler <Darin Adler>
Removed some stray files that Geoff missed when rolling out changes.
- svg/custom/resources/svg-fonts-in-text-controls.js: Removed.
- svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
- 5:32 PM Changeset in webkit [42800] by
-
- 8 edits in trunk
2009-04-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff "Dread Pirate Roberts" Garen.
Various small fixes to YARR JIT, in preparation for enabling it by default.
- Correctly index into the callframe when storing restart addresses for nested alternatives.
- Allow backtracking back into matched alternatives of parentheses.
- Fix callframe offset calculation for parenthetical assertions.
- When a set of parenthese are quantified with a fixed and variable portion, and the variable portion is quantified once, this should not reset the pattern match on failure to match (the last match from the firxed portion should be preserved).
- Up the pattern size limit to match PCRE's new limit.
- Unlclosed parentheses should be reported with the message "missing )".
- wtf/Platform.h:
- yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::quantifyAtom): (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::ByteCompiler::emitDisjunction):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::loadFromFrameAndJump): (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction): (JSC::Yarr::RegexGenerator::generateParentheticalAssertion): (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::executeRegex):
- yarr/RegexParser.h: (JSC::Yarr::Parser::): (JSC::Yarr::Parser::parseTokens): (JSC::Yarr::Parser::parse):
- yarr/RegexPattern.h: (JSC::Yarr::PatternTerm::): (JSC::Yarr::PatternTerm::PatternTerm):
LayoutTests:
2009-04-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff "Dread Pirate Roberts" Garen.
This test tries to force itself into PCRE; modify the
test so that as well as dodging WREC it can also avoid
YARR!
- fast/js/resources/regexp-overflow-too-big.js:
- 5:25 PM Changeset in webkit [42799] by
-
- 5 edits in trunk
WebCore:
2009-04-23 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler.
WebCore part of fix for <rdar://problem/6333461> REGRESSION
(r36864-r36869): Dragging stocks widget scrollbar drags the whole
widget
- platform/Scrollbar.h: (WebCore::Scrollbar::isScrollbar):
- platform/Widget.h: (WebCore::Widget::isScrollbar):
WebKit/mac:
2009-04-23 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler.
Fix for <rdar://problem/6333461> REGRESSION (r36864-r36869):
Dragging stocks widget scrollbar drags the whole widget
Look for our new WebCore scrollbars in the WebHTMLView and add
proper Dashboard regions for them.
- WebView/WebView.mm: (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): (-[WebView _addScrollerDashboardRegions:from:]):
- 4:59 PM Changeset in webkit [42798] by
-
- 3 edits8 adds in trunk
WebCore:
2009-04-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adam Roben.
<rdar://problem/6808109> "Deletion UI" is not available for many
portions of HTML content
This patch makes the deletion UI show up in some new situations:
1) If a block's background color is different from its parent's
2) If a block has a background image.
3) If a block has a single visible border.
However the block must now not only be at least a minimum width and
height, but also exceed a minimum area. In practice this has led to
much better element selection.
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
LayoutTests:
2009-04-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adam Roben.
<rdar://problem/6808109> "Deletion UI" is not available for many
portions of HTML content
This patch makes the deletion UI show up in some new situations:
1) If a block's background color is different from its parent's
2) If a block has a background image.
3) If a block has a single visible border.
However the block must now not only be at least a minimum width and
height, but also exceed a minimum area. In practice this has led to
much better element selection.
- editing/deleting/deletionUI-borders.html: Added.
- editing/deleting/deletionUI-differing-background.html: Added.
- editing/deleting/deletionUI-minimum-size.html: Added.
- editing/deleting/resources: Added.
- editing/deleting/resources/deletionUI-helpers.js: Added. (debug): (determineDeletionUIExistence):
- platform/mac/editing/deleting/deletionUI-borders-expected.txt: Added.
- platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
- platform/mac/editing/deleting/deletionUI-minimum-size-expected.txt: Added.
- 4:53 PM Changeset in webkit [42797] by
-
- 2 edits in trunk/WebCore
wx build fix. Adding XMLTokenizer.cpp to the build.
- 4:32 PM Changeset in webkit [42796] by
-
- 2 edits in trunk/WebKit/mac
2009-04-23 John Sullivan <sullivan@apple.com>
fixed <rdar://problem/6822479> Assertion failure after Reset Safari in new history-writing code
Reviewed by Oliver Hunt
- History/WebHistory.mm: (-[WebHistoryPrivate data]): Return nil immediately if there are no entries; this matches a recent Windows-platform fix.
- 4:14 PM Changeset in webkit [42795] by
-
- 2 edits in tags/Safari-6530.7/JavaScriptCore
Temporarily work around <rdar://problem/6812854> by forcing our 2GB allocation up in to high memory.
Rubber-stamped by Geoff Garen.
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- 3:46 PM Changeset in webkit [42794] by
-
- 2 edits in trunk/WebCore
2009-04-23 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6788905> REGRESSION (41928?): hang in Position::upstream
https://bugs.webkit.org/show_bug.cgi?id=25312
I was unable to reproduce the problem, but I'm pretty sure this will fix it.
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): Since VisiblePosition doesn't ensure the offset is good, we shouldn't pass max int as an offset.
- 3:38 PM Changeset in webkit [42793] by
-
- 4 edits in trunk
Versioning.
- 3:38 PM Changeset in webkit [42792] by
-
- 1 copy in tags/Safari-6530.7
New tag.
- 3:33 PM Changeset in webkit [42791] by
-
- 5 edits2 adds in trunk
WebCore:
2009-04-23 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25313
Missing scroll bars in GMail.
Test: fast/overflow/overflow-y-scroll.html
- platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars): Added check for the ScrollbarAlwaysOn scroll mode.
LayoutTests:
2009-04-23 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25313
Missing scroll bars in GMail.
- fast/overflow/overflow-y-scroll-expected.txt: Added.
- fast/overflow/overflow-y-scroll.html: Added.
WebKit/mac:
2009-04-23 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25313
Missing scroll bars in GMail.
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Added check for the ScrollbarAlwaysOn
scroll mode.
- 3:17 PM Changeset in webkit [42790] by
-
- 2 edits in trunk/WebKit/mac
Fix the Tiger build
- 3:03 PM Changeset in webkit [42789] by
-
- 3 edits in trunk/WebKit/mac
2009-04-23 Anders Carlsson <andersca@apple.com>
Reviewed by Geoffrey Garen.
Fix <rdar://problem/6821992>
Add a new m_inDestroy member variable. Set it to true when in destroy, and have all NPRuntime functions return false
when m_inDestroy is true.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::removeProperty): (WebKit::NetscapePluginInstanceProxy::hasProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::enumerate):
- 2:22 PM Changeset in webkit [42788] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by Justin Garcia.
- fix <rdar://problem/6081309> Mail crash when pressing down arrow in some messages in WebCore::canHaveChildrenForEditing
Test: editing/selection/extend-by-line-anonymous-content-crash.html
- editing/visible_units.cpp: (WebCore::previousLinePosition): Null-check node. If p is not an editable position, then closestLeafChildForXPos() may have returned a non-editable box, and in particular one belonging to anonymous content. If node is 0, fall back on RenderObject::positionForPoint, which finds the closest position in non-anonymous content. (WebCore::nextLinePosition): Ditto.
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): Fixed a typo.
LayoutTests:
Reviewed by Justin Garcia.
- test for <rdar://problem/6081309> Mail crash when pressing down arrow in some messages in WebCore::canHaveChildrenForEditing
- editing/selection/extend-by-line-anonymous-content-crash-expected.txt: Added.
- editing/selection/extend-by-line-anonymous-content-crash.html: Added.
- 1:49 PM Changeset in webkit [42787] by
-
- 3 edits in trunk/WebKit/mac
2009-04-23 David Hyatt <hyatt@apple.com>
Reviewed by Maciej.
Fix for <rdar://problem/6789879> REGRESSION (42464): Hitting assertion when loading message in Mail + TOT WebKit
Make the Mac platform the same as all the other platforms. Instead of (incorrectly) marking a FrameView for layout
when its underlying document view changes, just mark the outermost frame view for layout when the WebView's size changes.
- WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView addSuperviewObservers]):
- WebView/WebView.mm: (-[WebView _boundsChanged]): (-[WebView removeSizeObservers]): (-[WebView addSizeObservers]):
- 1:08 PM Changeset in webkit [42786] by
-
- 6 edits in trunk/WebKit/mac
Reviewed by Tim Hatcher.
Second part of the fix for <rdar://problem/6352982>
- Plugins/WebBaseNetscapePluginView.h: Make this class conform to WebPluginContainerCheckController
- Plugins/WebBaseNetscapePluginView.mm: Likewise. (-[WebBaseNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Added skeleton method.
- Plugins/WebPluginContainerCheck.h: Added protocol for <WebPluginContainerCheckController>
- Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck initWithRequest:target:resultObject:selector:controller:]):
- Plugins/WebPluginController.h: Make this class conform to WebPluginContainerCheckController
- 12:58 PM Changeset in webkit [42785] by
-
- 3 edits2 adds in trunk
Reviewed by Adele Peterson.
<rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail
Test: http/tests/history/back-to-post.php
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Apply a new cache policy if it changed after the platform request was first created. While at it, also made sure to update timeout.
- 12:02 PM Changeset in webkit [42784] by
-
- 2 edits in trunk/WebKit/gtk/po
2009-04-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
- pt_BR.po: translation update.
- 11:45 AM Changeset in webkit [42783] by
-
- 2 edits in trunk/WebCore
2009-04-23 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
When creating a new drawable object, collect system's
information about the best depth it can provide and use it
in a new colormap that the new drawable requires.
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::BitmapImage::getGdkPixbuf):
- 11:06 AM Changeset in webkit [42782] by
-
- 8 edits2 adds in trunk/WebKit
Reviewed by Anders Carlsson.
First part of <rdar://problem/6352982>
- Plugins/WebBaseNetscapePluginView.h: Imported #WebNetscapeContainerCheckPrivate.h; Added two new method: checkIfAllowedToLoadURL:url:frame:callbackFunc: and cancelCheckIfAllowedToLoadURL:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]): Added skeleton method, does nothing interesting yet. (-[WebBaseNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Likewise.
- Plugins/WebNetscapeContainerCheckPrivate.h: Added.
- Plugins/WebNetscapeContainerCheckPrivate.mm: Added. (browserContainerCheckFuncs): Added.
- Plugins/WebNetscapePluginView.h: Imported #WebNetscapeContainerCheckPrivate.h;
- Plugins/WebNetscapePluginView.mm: Imported #WebNetscapeContainerCheckPrivate.h; added WKN_CheckIfAllowedToLoadURL and WKN_CancelCheckIfAllowedToLoadURL functions. (-[WebNetscapePluginView getVariable:value:]): Return vtable for container check functions.
- Plugins/npapi.mm: (WKN_CheckIfAllowedToLoadURL): Added new private function. (WKN_CancelCheckIfAllowedToLoadURL): Ditto.
- 9:42 AM Changeset in webkit [42781] by
-
- 2 edits in trunk/LayoutTests
Skip a newly-added test that fails on Windows
See Bug 25344: http/tests/misc/redirect-to-external-url.html fails on
Windows
<https://bugs.webkit.org/show_bug.cgi?id=25344>
Reviewed by Brady Eidson.
- platform/win/Skipped: Added http/tests/misc/redirect-to-external-url.html.
- 8:39 AM Changeset in webkit [42780] by
-
- 4 edits in trunk/WebCore
2009-04-23 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15654
GdkPixbuf support for ImageCairo
Add support for converting a Cairo surface to a GdkPixbuf.
- platform/graphics/BitmapImage.h:
- platform/graphics/Image.h: (WebCore::Image::getGdkPixbuf):
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::BitmapImage::getGdkPixbuf):
- 8:07 AM Changeset in webkit [42779] by
-
- 1 edit in trunk/WebKit/qt/Api/qwebelement.cpp
Fix Qt build warning
- 7:55 AM Changeset in webkit [42778] by
-
- 3 edits in trunk/WebCore
2009-04-23 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Make windowed plugins (on X11, Qt) behave nicer with wheel scrolling.
Basically, what we want is to send wheel events to the plugin *only*
when it has focus, or else send it to the parent frame.
This is a work around, and basically what we do, is to steal the
wheel events from the plugin, modify the window ID, and put the
event back into the Qt event loop.
- plugins/qt/PluginContainerQt.cpp: (PluginClientWrapper::PluginClientWrapper): (PluginClientWrapper::~PluginClientWrapper): (PluginClientWrapper::x11Event): (PluginContainerQt::PluginContainerQt): (PluginContainerQt::~PluginContainerQt): (PluginContainerQt::on_clientClosed): (PluginContainerQt::on_clientIsEmbedded): (PluginContainerQt::redirectWheelEventsToParent): (PluginContainerQt::x11Event): (PluginContainerQt::focusInEvent):
- plugins/qt/PluginContainerQt.h:
- 6:53 AM Changeset in webkit [42777] by
-
- 4 edits in trunk/WebKit/qt
2009-04-23 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Ariya Hidayat.
[Qt] Added QWebElement::computedStyleProperty method.
- Api/qwebelement.cpp: (QWebElement::computedStyleProperty):
- Api/qwebelement.h:
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::computedStyle):
- 5:46 AM QtWebKitTodo edited by
- (diff)
- 5:36 AM QtWebKitJournal edited by
- (diff)
- 4:30 AM Changeset in webkit [42776] by
-
- 3 edits in trunk/WebKit/qt
2009-04-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Ariya Hidayat.
[Qt] Rename QWebElement arguments from html to markup
- 12:25 AM Changeset in webkit [42775] by
-
- 2 edits in trunk/WebKitTools
Fix the Windows DRT build.
- DumpRenderTree/win/PolicyDelegate.h:
- 12:10 AM Changeset in webkit [42774] by
-
- 2 edits in trunk/WebKitTools
2009-04-23 Brady Eidson <beidson@apple.com>
Fix Windows DRT build.
- DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::unableToImplementPolicyWithError):
- 12:09 AM Changeset in webkit [42773] by
-
- 2 edits in trunk/LayoutTests
2009-04-23 Brady Eidson <beidson@apple.com>
Update my just-landed layout test to agree with Tiger's CFNetwork
- http/tests/misc/resources/redirect-to-external-url.php:
Apr 22, 2009:
- 11:42 PM Changeset in webkit [42772] by
-
- 7 edits8 adds in trunk
WebCore:
2009-04-22 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak
<rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.
For most loads, we were consulting the navigation policy delegate twice. Once from FrameLoader before
the load started and once from MainResourceLoader in its willSendRequest callback.
In the past we tried removing MainResourceLoader's call altogether. This caused a regression where urls
that redirect to a url handled by an external application would no longer work in Safari. It probably
also broke other WebKit apps in subtle ways.
Changing MainResourceLoader to make the check only on redirects fixes both bugs. We now only call the
policy delegate once for most standard loads, but we do correctly call it a second time for redirects.
Tests: http/tests/misc/policy-delegate-called-twice.html
http/tests/misc/redirect-to-external-url.html
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Call the navigation policy delegate only for redirects.
WebKitTools:
2009-04-22 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak
Add additional support for test:
<rdar://problem/5689748> - Cannot redirect to protocols handled by external applications.
- DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]): Dump formatted information when a policy cannot be implemented.
- DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
- DumpRenderTree/win/PolicyDelegate.h:
LayoutTests:
2009-04-22 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak
With the fix for:
<rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.
And also to make sure we never rebreak:
<rdar://problem/5689748> - Cannot redirect to protocols handled by external applications.
- http/tests/misc/redirect-to-external-url-expected.txt: Added.
- http/tests/misc/redirect-to-external-url.html: Added.
- http/tests/misc/resources/redirect-to-external-url-iframe.html: Added.
- http/tests/misc/resources/redirect-to-external-url.php: Added.
- http/tests/misc/policy-delegate-called-twice-expected.txt: Added.
- http/tests/misc/policy-delegate-called-twice.html: Added.
- http/tests/misc/resources/iframe-policy-1.html: Added.
- http/tests/misc/resources/iframe-policy-2.html: Added.
- 9:06 PM Changeset in webkit [42771] by
-
- 2 edits in trunk/JavaScriptCore
Add the m_ prefix on FixedVMPoolAllocator's member variables, and fix typos in a few comments.
Rubber-stamped by Gavin Barraclough.
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::addToFreeList):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
- 9:06 PM Changeset in webkit [42770] by
-
- 2 edits in trunk/JavaScriptCore
Add some assertions to FixedVMPoolAllocator to guard against cases where we
attempt to free memory that didn't originate from the pool, or we attempt to
hand out a bogus address from alloc.
Rubber-stamped by Gavin Barraclough.
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
- 7:41 PM Changeset in webkit [42769] by
-
- 2 edits in trunk/WebCore
2009-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix for <rdar://problem/6800695>
Add a hack to only allow navigating (via a link from a http page)
to feed: urls (same for feeds: and feedsearch:) that map to http:
or https: via their nested protocol. This includes both feed://example.com
and feed:http://example.com.
- loader/FrameLoader.cpp: (WebCore::isFeedWithNestedProtocolInHTTPFamily): (WebCore::FrameLoader::loadFrameRequest):
- 7:34 PM Changeset in webkit [42768] by
-
- 7 edits in trunk/WebCore
2009-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Autogenerate the XMLHttpRequest constructor getter/setter for the
WorkerContext and remove the now no longer needed JSWorkerContextBase.lut.h
file.
- DerivedSources.make: Remove JSWorkerContextBase.lut.h
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSWorkerContextBase.cpp:
- bindings/js/JSWorkerContextBase.h: Remove code to support hand written code for XMLHttpRequest constructor lookup and shadowing.
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::customGetOwnPropertySlot): Remove JSC prefixes. (WebCore::JSWorkerContext::xmlHttpRequest): Added. Custom implementation of cached constructor lookup.
- workers/WorkerContext.idl: Make the XMLHttpRequestConstructor accessor not V8 specific.
- 6:43 PM Changeset in webkit [42767] by
-
- 6 edits in trunk
WebKitLibraries:
Update WebKitSystemInterface with new method that maps CFNetwork error code to localized description.
Reviewed by Darin Adler.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
WebKit/win:
<rdar://problem/5115298> Don't get error msg when download is interrupted and cannot resume due to server unavailability
If we fail to get an error description back from CFNetwork, try to get the localized description
based on the error code.
Reviewed by Darin Adler.
- WebError.cpp: (WebError::localizedDescription):
- 6:07 PM Changeset in webkit [42766] by
-
- 2 edits in trunk/WebCore
2009-04-22 Darin Adler <Darin Adler>
- page/Navigator.idl: Touch this file to fix build since Geolocation configuration was recently turned off.
- 6:02 PM Changeset in webkit [42765] by
-
- 2 edits in trunk/LayoutTests
Include updated results
- 5:59 PM Changeset in webkit [42764] by
-
- 2 edits in trunk/LayoutTests
Modify test to only record the important mouse events
Reviewed by Geoff Garen.
- 5:54 PM Changeset in webkit [42763] by
-
- 3 edits6 adds in trunk
WebCore:
2009-04-22 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25322
Can't delete empty paragraph after a block image
Empty paragraph removal would have been handled by mergeParagraphs, but we stopped short
because of some code that avoided problems that would arise from Positions that would go
bad during deletion.
We have several checks that prevent us from using bad Positions, this one in particular
was added to avoid bad Positions that result from text removal. So, I removed the check
and started correctly updating m_downstreamEnd during text removal so that it doesn't go
bad. m_upstreamStart doesn't need to be updated during text removal, since only text
after it will ever be removed.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::deleteTextFromNode): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::mergeParagraphs):
LayoutTests:
2009-04-22 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25322
Can't delete empty paragraph after a block image
- editing/deleting/25322-1-expected.txt: Added.
- editing/deleting/25322-1.html: Added.
- editing/deleting/25322-2-expected.txt: Added.
- editing/deleting/25322-2.html: Added.
- editing/deleting/25322-3-expected.txt: Added.
- editing/deleting/25322-3.html: Added.
- 5:49 PM Changeset in webkit [42762] by
-
- 2 edits in trunk/LayoutTests
2009-04-22 Darin Adler <Darin Adler>
- platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Fixed one case Eric seems to have missed earlier today of RenderImage -> RenderSVGImage.
- 5:37 PM Changeset in webkit [42761] by
-
- 7 edits in trunk
<rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves
Reviewed by Darin Adler.
Make mouseUp target the correct frame when the original
mousedown made the drag non-capturing.
- 5:29 PM Changeset in webkit [42760] by
-
- 5 edits3 adds in trunk
<rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves
Reviewed by Darin Adler.
This is the first step of allowing drag events to match the behaviour
of mouse move events when the default action of the initial mouse down
is prevented. Remaining issue is that the final mouse up event still
targets the original root frame.
Test: fast/events/mouse-drag-from-frame-to-other-frame.html
- 5:01 PM Changeset in webkit [42759] by
-
- 2 edits in trunk/WebCore
2009-04-22 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson
<rdar://problem/6702882> QT movie's video fails to be displayed after switching between tabs
<rdar://problem/6754957> Resizing Web browser window and hitting play will cause video blocks and artifacting
When in a media document, MediaPlayerPrivateQTKit uses a QTMovieView which may get
layer backing under some circumstances. However, drawing the view via
displayRectIgnoringOpacity:inContext: bypasses any layer setup that AppKit normally performs.
So when in the media document, we draw via displayRectIgnoringOpacity:.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):
- 4:56 PM Changeset in webkit [42758] by
-
- 3 edits in trunk/LayoutTests
Update test results after Blackbeard's change in r42752 to disable geolocation.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/navigator-detached-no-crash-expected.txt:
- 3:59 PM Changeset in webkit [42757] by
-
- 2 edits2 adds in trunk
2009-04-22 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Add tests for media 'played' attribute (missed in r42619).
- media/video-played-expected.txt: Added.
- media/video-played.html: Added.
- 3:51 PM Changeset in webkit [42756] by
-
- 2 edits in trunk/WebKit/mac
2009-04-22 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
Fix <rdar://problem/6792694>
When we're trying to instantiate a plug-in and the plug-in host has died, we need to invalidate the
instance so that it doesn't stick around and do bad things.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin):
- 2:52 PM Changeset in webkit [42755] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-22 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam "Blackbeard" Weinig.
Although pirates do spell the word 'generate' as 'genertate',
webkit developers do not. Fixerate.
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateAssertionBOL): (JSC::Yarr::RegexGenerator::generateAssertionEOL): (JSC::Yarr::RegexGenerator::generateAssertionWordBoundary): (JSC::Yarr::RegexGenerator::generatePatternCharacterSingle): (JSC::Yarr::RegexGenerator::generatePatternCharacterPair): (JSC::Yarr::RegexGenerator::generatePatternCharacterFixed): (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassSingle): (JSC::Yarr::RegexGenerator::generateCharacterClassFixed): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassNonGreedy): (JSC::Yarr::RegexGenerator::generateTerm):
- 2:44 PM Changeset in webkit [42754] by
-
- 4 edits in trunk/JavaScriptCore
2009-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam "Blackbeard" Weinig.
Improvements to YARR JIT. This patch expands support in three key areas:
- Add (temporary) support for falling back to PCRE for expressions not supported.
- Add support for x86_64 and Windows.
- Add support for singly quantified parentheses (? and ??), alternatives within parentheses, and parenthetical assertions.
- runtime/RegExp.cpp: (JSC::RegExp::match):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::storeToFrame): (JSC::Yarr::RegexGenerator::storeToFrameWithPatch): (JSC::Yarr::RegexGenerator::loadFromFrameAndJump): (JSC::Yarr::RegexGenerator::AlternativeBacktrackRecord::AlternativeBacktrackRecord): (JSC::Yarr::RegexGenerator::TermGenerationState::resetAlternative): (JSC::Yarr::RegexGenerator::TermGenerationState::resetTerm): (JSC::Yarr::RegexGenerator::TermGenerationState::jumpToBacktrack): (JSC::Yarr::RegexGenerator::TermGenerationState::plantJumpToBacktrackIfExists): (JSC::Yarr::RegexGenerator::TermGenerationState::addBacktrackJump): (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracks): (JSC::Yarr::RegexGenerator::TermGenerationState::propagateBacktrackingFrom): (JSC::Yarr::RegexGenerator::genertateAssertionBOL): (JSC::Yarr::RegexGenerator::genertateAssertionEOL): (JSC::Yarr::RegexGenerator::matchAssertionWordchar): (JSC::Yarr::RegexGenerator::genertateAssertionWordBoundary): (JSC::Yarr::RegexGenerator::genertatePatternCharacterSingle): (JSC::Yarr::RegexGenerator::genertatePatternCharacterPair): (JSC::Yarr::RegexGenerator::genertatePatternCharacterFixed): (JSC::Yarr::RegexGenerator::genertatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::genertatePatternCharacterNonGreedy): (JSC::Yarr::RegexGenerator::genertateCharacterClassSingle): (JSC::Yarr::RegexGenerator::genertateCharacterClassFixed): (JSC::Yarr::RegexGenerator::genertateCharacterClassGreedy): (JSC::Yarr::RegexGenerator::genertateCharacterClassNonGreedy): (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction): (JSC::Yarr::RegexGenerator::generateParenthesesSingle): (JSC::Yarr::RegexGenerator::generateParentheticalAssertion): (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::RegexGenerator::generateDisjunction): (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn): (JSC::Yarr::RegexGenerator::RegexGenerator): (JSC::Yarr::RegexGenerator::generate): (JSC::Yarr::RegexGenerator::compile): (JSC::Yarr::RegexGenerator::generationFailed): (JSC::Yarr::jitCompileRegex): (JSC::Yarr::executeRegex):
- yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
- 2:24 PM Changeset in webkit [42753] by
-
- 2 edits in trunk/WebCore
Fix a crash in Mail when forwarding a specific HTML email.
Caused by the fix for <rdar://problem/6512520> (r42096).
Unable to create a test case that works outside of Mail.
<rdar://problem/6796069>
Reviewed by Ada Chan.
- editing/markup.cpp: (WebCore::createMarkup): Null check pastEnd before trying to call Range::compareBoundaryPoints.
- 1:44 PM QtWebKitJournal edited by
- (diff)
- 12:09 PM Changeset in webkit [42752] by
-
- 8 edits in trunk
2009-04-22 Sam Weinig <sam@webkit.org>
Rubber-stamped by Darin Adler.
Fix for <rdar://problem/6816957>
Turn off Geolocation by default
- Configurations/FeatureDefines.xcconfig:
WebCore:
2009-04-22 Sam Weinig <sam@webkit.org>
Rubber-stamped by Darin Adler.
Fix for <rdar://problem/6816957>
Turn off Geolocation by default
- Configurations/FeatureDefines.xcconfig:
WebKit/mac:
2009-04-22 Sam Weinig <sam@webkit.org>
Rubber-stamped by Darin Adler.
Fix for <rdar://problem/6816957>
Turn off Geolocation by default
- Configurations/FeatureDefines.xcconfig:
WebKitTools:
2009-04-22 Sam Weinig <sam@webkit.org>
Rubber-stamped by Darin Adler.
Fix for <rdar://problem/6816957>
Turn off Geolocation by default
- Scripts/build-webkit:
- 11:03 AM Changeset in webkit [42751] by
-
- 43 edits in trunk
Rubber-stamped by David Hyatt.
Change RenderSVGImage to dump as RenderSVGImage instead of RenderImage
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::renderName):
- 8:48 AM Changeset in webkit [42750] by
-
- 2 edits in trunk/WebCore
Fix a crash on Gmail when they remove a "before unload" event listener when
it was never added to the pending map in the first place.
<rdar://problem/6814144>
Reviewed by Darin Adler.
- page/DOMWindow.cpp: (WebCore::allowsPendingBeforeUnloadListeners): Renamed from shouldAddPendingBeforeUnloadListener. (WebCore::DOMWindow::addEventListener): Call allowsPendingBeforeUnloadListeners now. (WebCore::DOMWindow::removeEventListener): Call allowsPendingBeforeUnloadListeners before removing the before unload listener. (WebCore::DOMWindow::clearAttributeEventListener): Ditto.
- 6:39 AM Changeset in webkit [42749] by
-
- 4 edits in trunk/WebCore
2009-04-22 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Ariya Hidayat.
Made windowed plugins move/resize synchronized with the painting, so
that windowed plugins are not moved before the rest of the parent
frame during scrolling.
- plugins/qt/PluginContainerQt.cpp: (PluginContainerQt::PluginContainerQt): (PluginContainerQt::requestGeometry): (PluginContainerQt::adjustGeometry):
- plugins/qt/PluginContainerQt.h:
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint):
- 5:34 AM Changeset in webkit [42748] by
-
- 6 edits2 adds in trunk/WebCore
2009-04-22 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Fix various bugs in the X11 Qt plugin focus handling.
Notify the focus controller on activation/deactivation of the plugin and
set focus on the plugin's element when it receives the window system
focus.
- 5:08 AM Changeset in webkit [42747] by
-
- 2 edits in trunk/WebCore
2009-04-22 Tamas Szirbucz <szirbucz.tamas@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=25023
Delete reply in QNetworkReplyHandler::abort() to avoid leak.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::abort):
- 3:44 AM QtWebKitJournal edited by
- (diff)
- 1:52 AM Changeset in webkit [42746] by
-
- 12 edits in trunk
2009-04-21 Jon Honeycutt <jhoneycutt@apple.com>
Allow the UI delegate to control cursor-setting.
Reviewed by Ada Chan.
WebCore/:
- page/Chrome.cpp: (WebCore::Chrome::setCursor): Pass the call to the client.
- page/Chrome.h:
- page/ChromeClient.h: (WebCore::ChromeClient::setCursor): Stubbed; returns false.
- platform/Cursor.h: Define PlatformCursorHandle for each platform.
- platform/win/WidgetWin.cpp: Reordered some includes. Added an include of Page.h. (WebCore::Widget::setCursor): Fixed a typo in the comment about ignoreNextSetCursor. Get the Page, and call its Chrome's setCursor() method with the passed cursor. Fall back to SetCursor() if the Page is not available.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handleMouseEvent): Remove an unused variable. Cleaned up some whitespace.
WebKit/win/:
- Interfaces/IWebUIDelegatePrivate.idl: Added a function to the IWebUIDelegatePrivate5 interface.
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::setCursor): Try to call the UI delegate's webViewSetCursor() method. If it fails, fall back to calling SetCursor() with the passed cursor.
- WebCoreSupport/WebChromeClient.h:
- WebView.cpp: (WebViewWndProc): Call the Chrome's setCursor() method with the last set cursor.
- 12:22 AM Changeset in webkit [42745] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
