Timeline
Jun 22, 2009:
- 10:53 PM Changeset in webkit [44975] by
-
- 5 edits in trunk/LayoutTests
2009-06-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Alexey Proskuryakov.
Skip layout tests for DST if the test runs not in PST/PDT.
- fast/js/date-DST-time-cusps-expected.txt:
- fast/js/date-big-setdate-expected.txt:
- fast/js/resources/date-DST-time-cusps.js:
- fast/js/resources/date-big-setdate.js:
- 10:44 PM Changeset in webkit [44974] by
-
- 6 edits in trunk
Bug 26640: JSON.stringify needs to special case Boolean objects
<https://bugs.webkit.org/show_bug.cgi?id=26640>
Reviewed by Alexey Proskuryakov.
Add special case handling of the Boolean object so we match current
ES5 errata.
- 9:53 PM Changeset in webkit [44973] by
-
- 2 edits in trunk/WebCore
2009-06-22 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
<rdar://problem/6991146> Scrollbars in hardware layers don't change to the
inactive look in background windows
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Don't short-circuit the "painting" pass that is used to udpate control tints.
- 9:36 PM Changeset in webkit [44972] by
-
- 3 edits1 add in trunk/WebCore
2009-06-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=26567
Upstream V8 bindings code generator. With this change, also added interface ancestor
traversal to IDL parser, which is necessary for V8 bindings. The traversal is used
to determine whether an interface is a Node to facilitate proper casting and storage
in V8DOMMap.
- bindings/scripts/CodeGenerator.pm: Added parent traversal sub, needed
by V8 bindings.
- bindings/scripts/CodeGeneratorV8.pm: Added.
- bindings/scripts/IDLParser.pm: Modified to allow limited parsing for
parent traversal cases.
- 8:37 PM Changeset in webkit [44971] by
-
- 8 edits in branches/nitro-extreme/JavaScriptCore
2009-06-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove 'arguments' field from Register union. Having JSCell derived types in the union is
dangerous since it opens the possibility for the field to be written as a raw pointer but
then read as a JSValue. This will lead to statle data being read for the tag, which may
be dangerous. Having removed Arguments* types form Register, all arguments objects must
always explicitly be stored in the register file as JSValues.
- interpreter/CallFrame.h: (JSC::ExecState::optionalCalleeArguments):
- interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
- interpreter/Register.h: (JSC::Register::):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_tear_off_arguments):
- runtime/Arguments.h: (JSC::JSActivation::copyRegisters):
- runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h:
- 8:07 PM Changeset in webkit [44970] by
-
- 2 edits in trunk/WebKitTools
Roll out r44967 as that build slave hates freedom.
- 8:05 PM Changeset in webkit [44969] by
-
- 8 edits in trunk
WebCore:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.
- dom/Node.h:
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::onblur): (WebCore::HTMLFrameSetElement::setOnblur): (WebCore::HTMLFrameSetElement::onerror): (WebCore::HTMLFrameSetElement::setOnerror): (WebCore::HTMLFrameSetElement::onfocus): (WebCore::HTMLFrameSetElement::setOnfocus): (WebCore::HTMLFrameSetElement::onload): (WebCore::HTMLFrameSetElement::setOnload): (WebCore::HTMLFrameSetElement::onbeforeunload): (WebCore::HTMLFrameSetElement::setOnbeforeunload): (WebCore::HTMLFrameSetElement::onmessage): (WebCore::HTMLFrameSetElement::setOnmessage): (WebCore::HTMLFrameSetElement::onoffline): (WebCore::HTMLFrameSetElement::setOnoffline): (WebCore::HTMLFrameSetElement::ononline): (WebCore::HTMLFrameSetElement::setOnonline): (WebCore::HTMLFrameSetElement::onresize): (WebCore::HTMLFrameSetElement::setOnresize): (WebCore::HTMLFrameSetElement::onstorage): (WebCore::HTMLFrameSetElement::setOnstorage): (WebCore::HTMLFrameSetElement::onunload): (WebCore::HTMLFrameSetElement::setOnunload):
- html/HTMLFrameSetElement.h:
- html/HTMLFrameSetElement.idl:
LayoutTests:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.
- fast/dom/event-attribute-availability-expected.txt:
- fast/dom/resources/event-attribute-availability.js:
- 6:27 PM Changeset in webkit [44968] by
-
- 5 edits in trunk
Bug 26591: Support revivers in JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26591>
Reviewed by Darin Adler.
Add reviver support to JSON.parse. This completes the JSON object.
- 6:27 PM Changeset in webkit [44967] by
-
- 2 edits in trunk/WebKitTools
Update build.webkit.org config for new machine.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 6:04 PM Changeset in webkit [44966] by
-
- 6 edits in trunk/WebCore
2009-06-22 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425
- bindings/scripts/CodeGeneratorJS.pm: Added handling for ReflectURL.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- dom/Element.cpp: (WebCore::Element::getURLAttribute): Added. For use implementing getters for ReflectURL.
- dom/Element.h: Added getURLAttribute.
- html/HTMLImageElement.idl: Use Reflect and ReflectURL.
- 5:41 PM Changeset in webkit [44965] by
-
- 2 edits in trunk/WebCore
2009-06-22 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 26626: Make WorkerContextExecutionProxy::toV8Object handle exception
objects.
https://bugs.webkit.org/show_bug.cgi?id=26626
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):
- 4:24 PM Changeset in webkit [44964] by
-
- 10 edits2 adds in trunk/WebCore
2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add RenderDataGrid to the build. Give it some basic default styling (that more or less matches a listbox). It has a default size
of 300x150.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/html4.css:
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::createRenderer):
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- rendering/RenderDataGrid.cpp: Added. (WebCore::RenderDataGrid::RenderDataGrid): (WebCore::RenderDataGrid::~RenderDataGrid): (WebCore::RenderDataGrid::calcPrefWidths): (WebCore::RenderDataGrid::paintObject): (WebCore::RenderDataGrid::valueChanged): (WebCore::RenderDataGrid::invalidateScrollbarRect): (WebCore::RenderDataGrid::isActive):
- rendering/RenderDataGrid.h: Added. (WebCore::RenderDataGrid::renderName): (WebCore::RenderDataGrid::canHaveChildren): (WebCore::RenderDataGrid::scrollbarCornerPresent):
- 4:01 PM Changeset in webkit [44963] by
-
- 2 edits in trunk/WebKitTools
Remove errant line of code mistakenly checked in.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
- 4:00 PM Changeset in webkit [44962] by
-
- 2 edits in trunk/WebKitTools
Pass correct value to setShouldPaintNativeControls.
Rubber stamped by Mark Rowe.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
- 3:45 PM Changeset in webkit [44961] by
-
- 7 edits2 adds in trunk
2009-06-22 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=26430
<rdar://problem/6944442> Elements jump around when they become composited (WWDC checkers demo)
<rdar://problem/6989006> Lots of time spent in RenderLayerCompositor::calculateCompositedBounds()
during window resize when using hardware layers
Fix an ordering dependency which caused the compositing position of a layer
to be affected by some later sibling, which affected the compositing ancestor's
composited bounds.
The fix is to only update the compositing positions of layers in some subtree
when updateAfterLayout() has been called on all the layers in that subtree,
from the ancestor down.
Also cache the composited bounds of a RenderLayerBacking, now that we can
guarantee that those bounds are accurate.
Test: compositing/sibling-positioning.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::hitTestLayer):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateAfterLayout): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): (WebCore::RenderLayerBacking::paintContents): (WebCore::RenderLayerBacking::compositedBounds): (WebCore::RenderLayerBacking::setCompositedBounds):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::updateLayerCompositingState): (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry):
- rendering/RenderLayerCompositor.h:
- 3:41 PM Moving to Git edited by
- Add link to evmar's doc (diff)
- 3:31 PM Moving to Git edited by
- Discussion of patch review branches (diff)
- 2:59 PM Changeset in webkit [44960] by
-
- 5 edits in branches/nitro-extreme
Merged r43552:43558 into nitro-extreme branch.
- 2:58 PM Changeset in webkit [44959] by
-
- 15 edits2 copies in trunk/WebCore
2009-06-22 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
First step in https://bugs.webkit.org/show_bug.cgi?id=25376
Add StorageSyncManager.cpp/h
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
In preparation for combining SessionStorage and LocalStorage into a
single StorageManager, move the syncing bits out of LocalStorage and
into its own class.
The next step is to combine LocalStorageArea and SessionStorageArea
into one. Then SessionStorage and LocalStorage can be combined.
Note that combining them will cut down on code paths that must be
proxied, eliminate virtual dispatch, and allow Chromium to (eventually)
write historical sessionStorage to disk when memory is getting tight.
Also remove a couple bits of cruft including code for quotas which is
unnecessary (since a meta-data db is unnecessary since you can just
count bytes as you read the local storage databases into memory).
- storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::storageArea): (WebCore::LocalStorage::close):
- storage/LocalStorage.h:
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::syncTimerFired): (WebCore::LocalStorageArea::performImport):
- storage/LocalStorageArea.h: (WebCore::LocalStorageArea::create):
- storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::performTask):
- storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): (WebCore::LocalStorageTask::createImport):
- storage/LocalStorageThread.cpp:
- storage/LocalStorageThread.h:
- storage/SessionStorage.h:
- storage/StorageSyncManager.cpp: Copied from WebCore/storage/LocalStorage.cpp. (WebCore::StorageSyncManager::create): (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::fullDatabaseFilename): (WebCore::StorageSyncManager::close): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
- storage/StorageSyncManager.h: Copied from WebCore/storage/LocalStorage.h. (WebCore::):
- 2:47 PM Changeset in webkit [44958] by
-
- 2 edits in branches/nitro-extreme
Merged r43550:43552 into nitro-extreme branch - fix error in merging changelogs.
- 2:43 PM Changeset in webkit [44957] by
-
- 5 edits7 copies in branches/nitro-extreme
Merged r43550:43552 into nitro-extreme branch.
- 2:38 PM Changeset in webkit [44956] by
-
- 3 edits in trunk/WebCore
2009-06-22 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26622
Add ChromiumDataObject::copy()
- platform/chromium/ChromiumDataObject.cpp:
- platform/chromium/ChromiumDataObject.h:
- 2:31 PM Changeset in webkit [44955] by
-
- 2 edits in trunk/WebKit/mac
Add Mail on Tiger and Leopard to the list of applications that need the WebView init thread workaround.
<rdar://problem/6929524> Console shows WebKit Threading Violations from Mail
Reviewed by Anders Carlsson.
- WebView/WebView.mm: (clientNeedsWebViewInitThreadWorkaround): Return true for com.apple.Mail.
- 2:30 PM Moving to Git edited by
- (diff)
- 2:25 PM Changeset in webkit [44954] by
-
- 2 edits1 add in trunk/WebCore
Add a silhouette image for the enable view of the Resource panel.
Reviewed by Kevin McCullough.
- inspector/front-end/Images/resourcesSilhouette.png: Added.
- inspector/front-end/inspector.css:
- 2:02 PM Changeset in webkit [44953] by
-
- 2 edits1 add in trunk/WebCore
2009-06-22 Kyle Prete <kylep@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26552
Add V8 JS bindings for Audio Constructor.
- bindings/v8/custom/V8CustomBinding.h: Added a callback declaration for audio ctor to macro.
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Added the whole file.
- 1:14 PM Changeset in webkit [44952] by
-
- 2 edits in trunk/WebCore
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26600
StringImpl::copy() no longer copies empty string correctly
- platform/text/StringImpl.cpp: (WebCore::StringImpl::ustring): Changed method calling syntax to look less like calling a static method. (WebCore::StringImpl::copy): Reverted part of r41917 that caused the problem.
- 12:51 PM Changeset in webkit [44951] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
- speculative fix for <rdar://problem/6889082> Crash at -[WebHTMLView(WebPrivate) _updateMouseoverWithEvent:]
The crash seems to happen because lastHitView points to a deleted
object. Since -close calls -_clearLastHitViewIfSelf, I speculate that
lastHitView has been set to an already-closed view.
- WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): Return nil if the view is closed.
- 12:34 PM Changeset in webkit [44950] by
-
- 3 edits in trunk/LayoutTests
2009-06-22 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix layout tests to account for removal of DOMStringList, which was done
in http://trac.webkit.org/changeset/44943.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- 12:20 PM Changeset in webkit [44949] by
-
- 3 edits in branches/nitro-extreme/WebCore
Merged r43544:43550 into nitro-extreme branch.
- 11:54 AM Changeset in webkit [44948] by
-
- 2 edits1 add in trunk/WebCore
2009-06-22 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel
Not auto-testable since it involves sending a keyboard event to
the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).
This patch is one part of the fix for issue "keyboard selection in
Hebrew select element does not work in Windows". The other part of the
fix is in chromium's webkit/glue layer.
https://bugs.webkit.org/show_bug.cgi?id=25899
- manual-tests/keyboard_select_non_english.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent): Added. Check whether the event is a character type event. "Char" in Windows or "KeyDown" in Mac is character type event. (WebCore::PopupListBox::typeAheadFind): Since m_lastCharTime is used to indicate whether user types multiple characters continuely as a search prefix or not, it should be only assigned when the event is character type event.
- 11:51 AM Changeset in webkit [44947] by
-
- 5 edits in trunk/WebCore
2009-06-22 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6115819> Notify of profile start in console
Put a message in the console that announces that a profile has started,
similar to how a console message announces that a profile has finished.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): Use renamed function. (WebCore::InspectorController::addProfileFinishedMessageToConsole): Renamed. (WebCore::InspectorController::addStartProfilingMessageToConsole): New function that logs the message about the profile starting. (WebCore::InspectorController::startUserInitiatedProfiling): Ditto
- inspector/InspectorController.h:
- inspector/front-end/ProfilesPanel.js: Print the "run" of the profile's title if there are multiple profiles, and take into account the fact that titles are displayed twice as much now. (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
- page/Console.cpp: (WebCore::Console::profile): Call new function.
- 11:47 AM Changeset in webkit [44946] by
-
- 17 edits3 adds in trunk/WebCore
2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add IDL interface for datagrid cell elements. Add a few more properties to the datagrid itself that
correspond to ones you find on <select> elements.
Add an expanded property to row elements.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLAttributeNames.in:
- html/HTMLDataGridCellElement.cpp: Added. (WebCore::HTMLDataGridCellElement::HTMLDataGridCellElement): (WebCore::HTMLDataGridCellElement::label): (WebCore::HTMLDataGridCellElement::setLabel): (WebCore::HTMLDataGridCellElement::focused): (WebCore::HTMLDataGridCellElement::setFocused): (WebCore::HTMLDataGridCellElement::checked): (WebCore::HTMLDataGridCellElement::setChecked): (WebCore::HTMLDataGridCellElement::indeterminate): (WebCore::HTMLDataGridCellElement::setIndeterminate): (WebCore::HTMLDataGridCellElement::progress): (WebCore::HTMLDataGridCellElement::setProgress):
- html/HTMLDataGridCellElement.h: Added. (WebCore::HTMLDataGridCellElement::endTagRequirement): (WebCore::HTMLDataGridCellElement::tagPriority):
- html/HTMLDataGridCellElement.idl: Added.
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::autofocus): (WebCore::HTMLDataGridElement::setAutofocus): (WebCore::HTMLDataGridElement::disabled): (WebCore::HTMLDataGridElement::setDisabled): (WebCore::HTMLDataGridElement::size): (WebCore::HTMLDataGridElement::setSize):
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- html/HTMLDataGridRowElement.cpp: (WebCore::HTMLDataGridRowElement::checkDTD): (WebCore::HTMLDataGridRowElement::expanded): (WebCore::HTMLDataGridRowElement::setExpanded):
- html/HTMLDataGridRowElement.h:
- html/HTMLDataGridRowElement.idl:
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
- 11:32 AM Changeset in webkit [44945] by
-
- 2 edits in trunk/WebKitTools
Fix last DumpRenderTree change to correctly set preferences flag without crashing.
Reviewed by Mark Rowe.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
- 11:32 AM Changeset in webkit [44944] by
-
- 13 edits in trunk
WebCore:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.
- Removes erroneous inclusion of the onresize and onunload event handler attributes in Element and Document.
- dom/Document.cpp: (WebCore::Document::getWindowAttributeEventListener):
- dom/Document.h:
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.cpp:
- dom/Node.h: onblur, onerror, onfocus, and onload all need to be declared virtual, since their behavior for HTMLBodyElement differs from the base implementation.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::onblur): (WebCore::HTMLBodyElement::setOnblur): (WebCore::HTMLBodyElement::onerror): (WebCore::HTMLBodyElement::setOnerror): (WebCore::HTMLBodyElement::onfocus): (WebCore::HTMLBodyElement::setOnfocus): (WebCore::HTMLBodyElement::onload): (WebCore::HTMLBodyElement::setOnload): (WebCore::HTMLBodyElement::onbeforeunload): (WebCore::HTMLBodyElement::setOnbeforeunload): (WebCore::HTMLBodyElement::onmessage): (WebCore::HTMLBodyElement::setOnmessage): (WebCore::HTMLBodyElement::onoffline): (WebCore::HTMLBodyElement::setOnoffline): (WebCore::HTMLBodyElement::ononline): (WebCore::HTMLBodyElement::setOnonline): (WebCore::HTMLBodyElement::onresize): (WebCore::HTMLBodyElement::setOnresize): (WebCore::HTMLBodyElement::onstorage): (WebCore::HTMLBodyElement::setOnstorage): (WebCore::HTMLBodyElement::onunload): (WebCore::HTMLBodyElement::setOnunload):
- html/HTMLBodyElement.h:
- html/HTMLBodyElement.idl:
LayoutTests:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.
- fast/dom/event-attribute-availability-expected.txt:
- fast/dom/resources/event-attribute-availability.js:
- 11:22 AM Changeset in webkit [44943] by
-
- 24 edits7 deletes in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26601
Remove disabled code for appcache dynamic entries
This also removes code for DOM 3 Core DOMStringList, which we don't use for anything else yet.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDOMStringListCustom.cpp: Removed.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMStringListCustom.cpp: Removed.
- dom/DOMStringList.cpp: Removed.
- dom/DOMStringList.h: Removed.
- dom/DOMStringList.idl: Removed.
- dom/StaticStringList.cpp: Removed.
- dom/StaticStringList.h: Removed.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
- loader/appcache/ApplicationCache.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
- loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::dumpType):
- loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeUpdatedType):
- loader/appcache/DOMApplicationCache.cpp:
- loader/appcache/DOMApplicationCache.h:
- loader/appcache/DOMApplicationCache.idl:
- page/DOMWindow.idl:
- 10:56 AM Changeset in webkit [44942] by
-
- 3 edits in trunk/WebCore
Windows build fix.
- DerivedSources.cpp:
- html/HTMLElementsAllInOne.cpp:
- 10:33 AM Changeset in webkit [44941] by
-
- 4 edits in trunk
Reviewed by John Sullivan.
<rdar://problem/6956606> REGRESSION (S4Beta -> Final): After the password is input,
Japanese can't be input.
WebKit uses a per-frame input context for most editable fields, and application's global
context for password fields, manually controlling secure input state and the list of available
input methods.
We were setting TSMDocument property to disable non-Roman input methods after focus changed
to a password field, but before selection was updated. This resulted in the property being
applied to a wrong TSMDocument in some cases, because TSMGetActiveDocument() uses input
context cached by +[NSApplication updateWindows], we change context based on selection,
not on focus.
- page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Since there is only one context that we use for password fields - the global one - there is no need to get the active one.
- 10:20 AM Changeset in webkit [44940] by
-
- 8 edits3 adds in trunk
WebCore:
2009-06-22 David Levin <levin@chromium.org>
Reviewed by David Hyatt and Eric Seidel.
REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326
Test: scrollbars/scrollbar-crash-on-refresh.html
- dom/Document.cpp: (WebCore::Document::detach): Gives the FrameView a change to do any necessary cleanup on Document::detach() which is where the renderArena gets detroyed.
- page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars): Gets rid of any custom scrollbars (if the docment supplied them).
- page/FrameView.h:
- platform/Scrollbar.h: (WebCore::Scrollbar::isCustomScrollbar):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Removed the check for document()->frame(). If frame() is 0 in this code, then the call to animation() is also incorrect (since it does document()->frame()->animation()).
- rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::isCustomScrollbar):
LayoutTests:
2009-06-22 David Levin <levin@chromium.org>
Reviewed by David Hyatt and Eric Seidel.
REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326
Test that refreshing an iframe with custom scrollbars works without crashing.
- scrollbars/resources/page-with-custom-scrollbars.html: Added.
- scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
- scrollbars/scrollbar-crash-on-refresh.html: Added.
- 9:50 AM Changeset in webkit [44939] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Dave Hyatt.
- fix <rdar://problem/6990938> REGRESSION (r42787): After showing and hiding the Find banner, the WebHTMLView's height is not restored
- WebView/WebFrameView.mm: (-[WebFrameView setFrameSize:]): Mark the FrameView for layout when the WebFrameView's size changes.
- WebView/WebView.mm: (-[WebView setFrameSize:]): Left the resize logic here, but only for the single view model.
- 9:42 AM Changeset in webkit [44938] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- fix https://bugs.webkit.org/show_bug.cgi?id=23606 <rdar://problem/6537777> CSS gradient not repainted when image load completes
Test: fast/repaint/background-generated.html
- rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers): Return true if the layer does not specify a size and the image uses the container size.
LayoutTests:
Reviewed by Simon Fraser.
- test for https://bugs.webkit.org/show_bug.cgi?id=23606 <rdar://problem/6537777> CSS gradient not repainted when image load completes
- fast/repaint/background-generated.html: Added.
- platform/mac/fast/repaint/background-generated-expected.checksum: Added.
- platform/mac/fast/repaint/background-generated-expected.png: Added.
- platform/mac/fast/repaint/background-generated-expected.txt: Added.
- 9:34 AM Changeset in webkit [44937] by
-
- 15 edits3 adds in trunk/WebCore
2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add IDL for HTMLDataGridRowElement.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLAttributeNames.in:
- html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::primary): (WebCore::HTMLDataGridColElement::setPrimary):
- html/HTMLDataGridColElement.h:
- html/HTMLDataGridColElement.idl:
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::checkDTD): (WebCore::HTMLDataGridElement::multiple): (WebCore::HTMLDataGridElement::setMultiple):
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- html/HTMLDataGridRowElement.cpp: Added. (WebCore::HTMLDataGridRowElement::HTMLDataGridRowElement): (WebCore::HTMLDataGridRowElement::selected): (WebCore::HTMLDataGridRowElement::setSelected): (WebCore::HTMLDataGridRowElement::focused): (WebCore::HTMLDataGridRowElement::setFocused):
- html/HTMLDataGridRowElement.h: Added. (WebCore::HTMLDataGridRowElement::tagPriority):
- html/HTMLDataGridRowElement.idl: Added.
- html/HTMLTagNames.in:
- 9:32 AM Changeset in webkit [44936] by
-
- 2 edits in trunk/LayoutTests
2009-06-22 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Skip two new tests.
- 8:44 AM Changeset in webkit [44935] by
-
- 2 edits in trunk/LayoutTests
2009-06-22 Darin Adler <Darin Adler>
- fast/js/JSON-stringify-expected.txt: Update results.
- 6:22 AM Changeset in webkit [44934] by
-
- 3 edits1 add in trunk/WebCore
2009-06-19 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Holger Freyther.
Fix a crash in case that the QNetworkReply::readReady signal is
"stuck" in deferred mode due to JavaScript alert, and in the meantime,
QNetworkreply::finished signal is received and processed before
QNetworkReply::readReady is processed.
- manual-tests/qt/unload-alert.html: Added.
- platform/network/qt/QNetworkReplyHandler.cpp:
- platform/network/qt/QNetworkReplyHandler.h:
- 4:55 AM Changeset in webkit [44933] by
-
- 2 edits in trunk/WebCore
2009-06-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Fix the Qt build.
- WebCore.pro:
- 12:33 AM Changeset in webkit [44932] by
-
- 2 edits in trunk/WebKitTools
Set up global native controls flag before creating the first WebView.
Reviewed by Darin Adler.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
Jun 21, 2009:
- 11:35 PM Changeset in webkit [44931] by
-
- 6 edits in trunk
Bug 26592: Support standard toJSON functions
<https://bugs.webkit.org/show_bug.cgi?id=26592>
Reviewed by Darin Adler
Add support for the standard Date.toJSON function.
- 11:17 PM Changeset in webkit [44930] by
-
- 4 edits in trunk/WebCore
2009-06-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425
- bindings/scripts/CodeGeneratorJS.pm: Tweaked mechanism for includes to be a bit more consistent and to make SVGElement.h be included in the header rather than in every implementation file that includes the header. Added code to use getAttribute and setAttribute directly when the [Reflect] extended attribute is used.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- html/HTMLElement.idl: Used [Reflect] for all the attributes in this class that reflect content attributes. Restricting this to one class for now to keep the patch small and start out slowly.
- 10:08 PM Changeset in webkit [44929] by
-
- 3 edits3 adds in trunk
Bug 26594: JSC needs to support Date.toISOString
<https://bugs.webkit.org/show_bug.cgi?id=26594>
Reviewed by Sam Weinig
Add support for Date.toISOString.
- 9:59 PM Changeset in webkit [44928] by
-
- 7 edits3 adds in trunk
WebCore:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.
Test: fast/dom/event-attribute-availability.html
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.cpp:
- dom/Node.h:
- dom/Node.idl:
LayoutTests:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Test for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.
- fast/dom/event-attribute-availability-expected.txt: Added.
- fast/dom/event-attribute-availability.html: Added.
- fast/dom/resources/event-attribute-availability.js: Added.
- 6:39 PM Changeset in webkit [44927] by
-
- 4 edits3 adds in trunk
WebCore:
2009-06-21 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fix to enable XSSAuditor on child windows.
Test: http/tests/security/xssAuditor/link-opens-new-window.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
- page/XSSAuditor.h: Removed method setXSSAuditorEnabled, and field m_isEnabled. Moved implementation of isEnabled to XSSAuditor.cpp and changed implementation to query Settings.
LayoutTests:
2009-06-21 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests that XSSAuditor (if enabled) prevents script execution in child window.
- http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
- http/tests/security/xssAuditor/link-opens-new-window.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Added.
- 5:23 PM Changeset in webkit [44926] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
- make repaint tests more reliable when run in Safari
- fast/repaint/resources/repaint.js: (runRepaintTest): Increased the timeout from 0 to 100, to ensure that painting occurs once before repaintTest() is called.
- 5:03 PM Changeset in webkit [44925] by
-
- 2 edits in trunk/WebKitTools
Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).
Reviewed by Sam Weinig.
- WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(userAgentStringForSparkle):
(initializeSparkle):
- 4:32 PM Changeset in webkit [44924] by
-
- 2 edits in trunk/JavaScriptCore
Fix build by removing dead code.
- 4:02 PM Changeset in webkit [44923] by
-
- 7 edits3 adds in trunk
Bug 26587: Support JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26587>
Reviewed by Darin Adler and Cameron Zwarich.
Extend the LiteralParser to support the full strict JSON
grammar, fix a few places where the grammar was incorrectly
lenient. Doesn't yet support the JSON.parse reviver function
but that does not block the JSON.parse functionality itself.
- 3:46 PM Changeset in webkit [44922] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (speculative build fix for windows).
Simply removed some whitespace form this file to make windows build wtf and
hopefully copy the new MessageQueque.h so that WebCore picks it up.
- wtf/Assertions.cpp:
- 3:16 PM Changeset in webkit [44921] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY.
Speculative windows build fix (idea by Mark Rowe).
- WebCore.vcproj/WebCore.vcproj:
- 3:03 PM Changeset in webkit [44920] by
-
- 2 edits2 adds in trunk/WebKitTools
Add a hook to the WebKit launcher application to allow a link on the nightly build start page to
trigger an update via the built-in software update mechanism.
Reviewed by Sam Weinig.
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
- WebKitLauncher/WebKitLauncherURLProtocol.m: Added.
(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
(+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol stopLoading]):
(-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
determine whether the x-webkit-launcher is available and working.
(-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
(-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.
- 3:02 PM Changeset in webkit [44919] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (Speculative gtk build fix).
- GNUmakefile.am:
- 2:56 PM Changeset in webkit [44918] by
-
- 3 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY.
Speculative tiger build fix and a windows build fix.
More fixes may still be in order.
- WebCore.vcproj/WebCoreCommon.vsprops:
- dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
- 2:46 PM Changeset in webkit [44917] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (Speculative tiger build fix).
- dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::~MessagePortQueue):
- 2:32 PM Changeset in webkit [44916] by
-
- 9 edits2 adds in trunk
WebCore:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Added optimized GC for MessagePorts when the entangled port is run by the same thread.
Fixed bug in isProxyFor() that was not properly throwing an exception when trying to clone the entangled port.
- bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Now marks remotely entangled ports as in-use, in addition to those with pending activity.
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): Now checks if the entangled port is local (run by same thread) and if so mark()s it.
- dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): Removes cloned ports from the ScriptExecutionContext - this allows cloned ports to be GC'd as otherwise they look like remotely entangled ports. (WebCore::MessagePort::start): (WebCore::MessagePort::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread
- dom/MessagePort.h:
- dom/MessagePortProxyWrapper.h:
- dom/default/MessagePortProxy.cpp: (WebCore::MessagePortProxyWrapper::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread (WebCore::MessagePortProxy::hasPendingActivity): Changed definition of hasPendingActivity() to be stricter - only returns true if there are pending messages. (WebCore::MessagePortProxy::locallyEntangledPort):
- dom/default/MessagePortProxy.h:
LayoutTests:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
New tests for MessagePort GC cases that weren't previously covered.
- fast/events/message-channel-gc-4-expected.txt: Added. Test for case where both MessagePorts are in-transit (cloned) when a GC occurs.
- fast/events/message-channel-gc-4.html-disabled: Added.
- 2:32 PM Changeset in webkit [44915] by
-
- 23 edits1 move7 adds2 deletes in trunk
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Added support for multi-threaded MessagePorts.
- wtf/MessageQueue.h: (WTF::::appendAndCheckEmpty):
Added API to test whether the queue was empty before adding an element.
WebCore:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Removed obsolete MessagePort.startConversation(), active and onclose APIs.
Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
entirely into the platform-dependent proxy.
Created a thread-safe default PlatformMessagePortChannel implementation.
Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
cross-thread MessagePorts work.
- GNUMakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added MessagePortChannel/PlatformMessagePortChannel files.
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
Changed ports to not mark their entangled pair as reachable, per the spec.
- bindings/v8/custom/V8MessagePortCustom.cpp:
- dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):
Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.
- dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): (WebCore::MessagePort::messageAvailable): (WebCore::MessagePort::start): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::setOnmessage): (WebCore::MessagePort::hasPendingActivity):
Changed these APIs to delegate to new PlatformMessagePortChannel APIs.
- dom/MessagePort.h:
Renamed isQueueOpen() to started().
- dom/MessagePort.idl:
Removed startConversation and onclose.
- dom/MessagePortProxy.h: Removed.
- dom/MessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::EventData::create): (WebCore::MessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::~MessagePortChannel):
- dom/MessagePortChannel.h: Added. (WebCore::MessagePortChannel::EventData::message): (WebCore::MessagePortChannel::EventData::channel):
Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::create):
- dom/ScriptExecutionContext.cpp: (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):
Renamed isQueueOpen() to started().
- dom/default/PlatformMessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::createChannel): (WebCore::PlatformMessagePortChannel::entangleIfOpen): (WebCore::PlatformMessagePortChannel::disentangle): (WebCore::PlatformMessagePortChannel::setRemotePort): (WebCore::PlatformMessagePortChannel::remotePort): (WebCore::PlatformMessagePortChannel::entangledChannel): (WebCore::PlatformMessagePortChannel::setEntangledChannel): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::isConnectedTo): (WebCore::PlatformMessagePortChannel::close): (WebCore::PlatformMessagePortChannel::closeInternal): (WebCore::PlatformMessagePortChannel::hasPendingActivity):
- dom/default/PlatformMessagePortChannel.h: Added. (WebCore::PlatformMessagePortChannel::MessagePortQueue::create): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
- page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer):
Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):
LayoutTests:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Updated MessageChannel/MessagePorts tests to reflect latest spec (close event has been removed).
Added more tests of port cloning.
- fast/events/message-channel-gc-2-expected.txt:
- fast/events/message-channel-gc-2.html-disabled:
- fast/events/message-channel-gc-3-expected.txt:
- fast/events/message-channel-gc-3.html-disabled:
- fast/events/message-channel-gc-expected.txt:
- fast/events/message-channel-gc.html-disabled:
- fast/events/message-port-clone-expected.txt: Added.
- fast/events/message-port-clone.html-disabled: Added.
- fast/events/message-port-expected.txt:
- fast/events/message-port-no-wrapper-expected.txt: Added.
- fast/events/message-port-onclose-expected.txt: Removed.
- fast/events/message-port-onclose.html-disabled: Removed.
- fast/events/message-port.html-disabled:
- 1:56 PM Changeset in webkit [44914] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=15383 <rdar://problem/5682745> resize: vertical does not restrict to vertical resize
Test: fast/css/resize-single-axis.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Ignore movement along the non-resizing axis.
LayoutTests:
Reviewed by Sam Weinig.
- test for https://bugs.webkit.org/show_bug.cgi?id=15383 <rdar://problem/5682745> resize: vertical does not restrict to vertical resize
- fast/css/resize-single-axis-expected.txt: Added.
- fast/css/resize-single-axis.html: Added.
- 1:47 PM Changeset in webkit [44913] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel
Fix for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox
Test: fast/events/event-trace.html
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched to it. We previously used the document because DOMWindow was not yet an EventTarget.
LayoutTests:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel.
Test for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox
- fast/events/event-trace-expected.txt: Added.
- fast/events/event-trace.html: Added.
- 1:16 PM Changeset in webkit [44912] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=9694 resize value not compared
Test: fast/css/resize-value-compared.html
- rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::operator==): Compare the resize member.
LayoutTests:
Reviewed by Sam Weinig.
- test for https://bugs.webkit.org/show_bug.cgi?id=9694 resize value not compared
- fast/css/resize-value-compared-expected.txt: Added.
- fast/css/resize-value-compared.html: Added.
- 12:19 AM Changeset in webkit [44911] by
-
- 2 edits in trunk/LayoutTests
2009-06-21 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Skip one more test.
Jun 20, 2009:
- 11:19 PM Changeset in webkit [44910] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Skip some new tests.
- 11:15 PM Changeset in webkit [44909] by
-
- 2 edits in trunk/WebKit/win
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6964221> Need more processing of pluginspage.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
- 10:42 PM Changeset in webkit [44908] by
-
- 3 edits3 adds in trunk
WebCore:
2009-06-19 Alice Liu <alice.liu@apple.com>
Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>
Reviewed by Maciej Stachowiak.
Can't test this bug with an automated layout test since it requires b/f caching
- manual-tests/animated-gif-bfcache-crash.html: Added.
- manual-tests/resources/containsAnimatedGif.html: Added.
Adding checks for hostWindow() since there is no guarantee that the Page is alive
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::wheelEvent):
LayoutTests:
2009-06-19 Alice Liu <alice.liu@apple.com>
Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>
Reviewed by Maciej Stachowiak.
Adding resource used in WebCore/manual-tests/animated-gif-bfcache-crash.html
- http/tests/misc/resources/animated-gif-with-offsets.gif: Added.
- 7:43 PM Changeset in webkit [44907] by
-
- 2 edits in trunk/WebKit/win
Roll out the Windows portion of r44905 as it broke the build.
- 7:05 PM Changeset in webkit [44906] by
-
- 6 edits in trunk
WebCore:
2009-06-20 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26554
Shadowing of top and parent
- page/DOMWindow.idl:
LayoutTests:
2009-06-20 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Test writing to parent and top.
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/security/cross-frame-access-put.html:
- http/tests/security/resources/cross-frame-iframe-for-put-test.html:
- 4:07 PM Changeset in webkit [44905] by
-
- 4 edits in trunk/WebKit
WebKit/mac:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6964221> Need more processing of pluginspage.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
WebKit/win:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6964221> Need more processing of pluginspage.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
- 2:57 PM Changeset in webkit [44904] by
-
- 6 edits in trunk
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Implement DRT XSS auditor support
https://bugs.webkit.org/show_bug.cgi?id=26571
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
- 2:56 PM Changeset in webkit [44903] by
-
- 3 edits in trunk/WebKit/gtk
2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
webkit_web_back_forward_list_add_item() should add a ref for the history item
https://bugs.webkit.org/show_bug.cgi?id=26517
Add a ref to the WebHistoryItem when it's added to the back
forward list through webkit_web_back_forward_list_add_item.
This keeps the history item alive and prevents pywebkitgtk from
crashing
- tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_add_item):
- 2:54 PM Changeset in webkit [44902] by
-
- 3 edits2 adds in trunk
Fix <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none
Reviewed by Dan Bernstein.
We allow selections to begin within an element that has -webkit-user-select: none set,
unless the element is draggable as dragging should take priority over starting a selection.
Test: editing/selection/user-drag-element-and-user-select-none.html
- dom/Node.cpp:
(WebCore::Node::canStartSelection):
Test for <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none
- editing/selection/user-drag-element-and-user-select-none-expected.txt: Added.
- editing/selection/user-drag-element-and-user-select-none.html: Added.
- 1:34 PM Changeset in webkit [44901] by
-
- 5 edits in trunk
WebCore:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329
- editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement): When entering a text control, start at the top of the shadow tree (by calling shadowTreeRootNode). Also remove assumption that innerTextElement will never be 0 since RenderTextControl doesn't really guarantee this.
LayoutTests:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329
- editing/selection/find-in-text-control-expected.txt: Updated to expect finding text in <input type="text"> and <input type="search">, but not in <input type="password">.
- editing/selection/find-in-text-control.html: Added tests for <input> elements as well as <textarea> elements. Also tweaked result output format to accomodate multiple text nodes.
- 11:06 AM Changeset in webkit [44900] by
-
- 2 edits in trunk/JavaScriptCore
Fix namespace comment in SegmentedVector.h
- wtf/SegmentedVector.h: Updated namespace comment to reflect new namespace after r44897.
- 6:27 AM Changeset in webkit [44899] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
Reviewed by Oliver Hunt.
An Iterator added for SegmentedVector. Currently
only the pre ++ operator is supported.
- wtf/SegmentedVector.h: (WTF::SegmentedVectorIterator::~SegmentedVectorIterator): (WTF::SegmentedVectorIterator::operator*): (WTF::SegmentedVectorIterator::operator->): (WTF::SegmentedVectorIterator::operator++): (WTF::SegmentedVectorIterator::operator==): (WTF::SegmentedVectorIterator::operator!=): (WTF::SegmentedVectorIterator::operator=): (WTF::SegmentedVectorIterator::SegmentedVectorIterator): (WTF::SegmentedVector::alloc): (WTF::SegmentedVector::begin): (WTF::SegmentedVector::end):
- 6:20 AM Changeset in webkit [44898] by
-
- 3 edits1 add in trunk
2009-06-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
Initial test case for loading statuses.
- tests/testloading.c: Added. (load_finished_cb): (status_changed_cb): (test_loading_status): (main):
- 6:14 AM Changeset in webkit [44897] by
-
- 8 edits1 move in trunk/JavaScriptCore
2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
Reviewed by Oliver Hunt.
Move SegmentedVector to /wtf subdirectory
and change "namespace JSC" to "namespace WTF"
Additional build file updates by David Kilzer.
- GNUmakefile.am: Updated path to SegmentedVector.h.
- JavaScriptCore.order: Updated SegmentedVector namespace from JSC to WTF in mangled C++ method name.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to bytecompiler\SegmentedVector.h.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to wtf\SegmentedVector.h.
- JavaScriptCore.xcodeproj/project.pbxproj: Moved SegmentedVector.h definition from bytecompiler subdirectory to wtf subdirectory.
- bytecompiler/BytecodeGenerator.h: Updated #include path to
- SegmentedVector.h and prepended WTF
- namespace to its use.
- parser/Lexer.h: Ditto.
- wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h. (WTF::SegmentedVector::SegmentedVector): (WTF::SegmentedVector::~SegmentedVector): (WTF::SegmentedVector::size): (WTF::SegmentedVector::at): (WTF::SegmentedVector::operator[]): (WTF::SegmentedVector::last): (WTF::SegmentedVector::append): (WTF::SegmentedVector::removeLast): (WTF::SegmentedVector::grow): (WTF::SegmentedVector::clear): (WTF::SegmentedVector::deleteAllSegments): (WTF::SegmentedVector::segmentExistsFor): (WTF::SegmentedVector::segmentFor): (WTF::SegmentedVector::subscriptFor): (WTF::SegmentedVector::ensureSegmentsFor): (WTF::SegmentedVector::ensureSegment):
- 5:34 AM Changeset in webkit [44896] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Jan Alonzo.
Fix the ordering in which the new load status goes into the enum
to avoid ABI breakage.
- webkit/webkitwebframe.h:
- 2:48 AM Changeset in webkit [44895] by
-
- 2 edits in trunk/WebCore
2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by NOBODY.
Speculative Qt build fix - add HTMLDataGridColElement to the build script.
- WebCore.pro:
- 2:20 AM Changeset in webkit [44894] by
-
- 3 edits in trunk/WebCore
2009-06-19 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove a memcpy by retrieving the already existing copy of a string
instead of making a new one.
- bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::source):
- bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::source):
- 1:11 AM Changeset in webkit [44893] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Xan Lopez <xlopez@igalia.com>
Skip new accessibility test, we still lack and accessibilityController.
- platform/gtk/Skipped:
- 1:00 AM Changeset in webkit [44892] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Xan Lopez <xlopez@igalia.com>
We don't seem to support these new HTTP tests either, skip them.
- platform/gtk/Skipped:
- 12:53 AM Changeset in webkit [44891] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Xan Lopez <xlopez@igalia.com>
Skip test that requires eventSender.
- platform/gtk/Skipped:
Jun 19, 2009:
- 11:21 PM Changeset in webkit [44890] by
-
- 2 edits in trunk/WebKit/win
2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26494
Bug 26494: RenderTheme::themeForPage reads from Settings before it has
been initialized by WebKit
Get the shouldPaintNativeControls preference and update the settings
before initializing the page, as the page depends on it after the
themeForPage change.
- WebView.cpp: (WebView::initWithFrame):
- 6:29 PM Changeset in webkit [44889] by
-
- 9 edits in trunk/JavaScriptCore
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h).
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::checkStructure):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_get_by_val):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- 6:29 PM Changeset in webkit [44888] by
-
- 2 edits in trunk/WebKitTools
2009-06-19 Darin Adler <Darin Adler>
- Scripts/do-webcore-rename: More renaming ideas.
- 6:19 PM Changeset in webkit [44887] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
- jit/JIT.h:
- jit/JITInlineMethods.h:
- 6:07 PM Changeset in webkit [44886] by
-
- 12 edits in trunk/JavaScriptCore
2009-06-19 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Reorganize ARM architecture specific macros.
Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7).
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
- assembler/ARMv7Assembler.h:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- wtf/Platform.h:
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
- 5:52 PM Changeset in webkit [44885] by
-
- 1 edit in trunk/WebKit/win/ChangeLog
Fixed the changelog, copied the same thing into both on accident.
- 5:49 PM Changeset in webkit [44884] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Fix armv7 JIT build issues.
Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types),
and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros.
- Replace offsetofs with FIELD_OFFSETs (safe on C++ objects).
- Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor.
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- 5:35 PM Changeset in webkit [44883] by
-
- 7 edits1 add in trunk
2009-06-19 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7
The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.
Unable to add tests to simulate touch behavior/gestures.
- platform/PlatformWheelEvent.h:
- platform/win/WheelEventWin.cpp:
2009-06-19 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7
The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.
Unable to add tests to simulate touch behavior/gestures.
- platform/PlatformWheelEvent.h:
- platform/win/WheelEventWin.cpp:
- 5:27 PM Changeset in webkit [44882] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2009-06-19 Ryosuke Niwa <rniwa@google.com>
Reviewed by Maciej Stachowiak.
This fixs the bug 26361. The original test case did not invoke the event that
triggered the actual test. This patch adds code to invoke this event, and also
converts it from a pixel test to a dumpAsText test.
- 4:54 PM Changeset in webkit [44881] by
-
- 2 edits in trunk/WebCore
Fixed a build error, which only shows up in the i386 compile
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
- 4:35 PM Changeset in webkit [44880] by
-
- 2 edits in trunk/WebCore
2009-06-19 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
<rdar://problem/6988385> REGRESSION: In full page video player, movie's
video track becomes detached from its controller.
When in the media document, the MediaPlayer should not report that it
is capable of hardware acceleration, because it renders via a QTMovieView
which is already accelerated.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
- 4:14 PM Changeset in webkit [44879] by
-
- 2 edits in trunk/WebCore
Adding XSSAuditor.cpp to the wx build.
- 3:43 PM Changeset in webkit [44878] by
-
- 2 edits in trunk/WebCore
If I am doing a Matrix hardware animation and any matrix is singular, I revert to software.
This is not really testable, since we can't see what the hardware animation is doing.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
- 3:32 PM Changeset in webkit [44877] by
-
- 5 edits in trunk/WebCore
2009-06-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
An additional fix for Bug 26532: Native functions do not correctly unlink
from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> | <rdar://problem/6625385>
Use "NativeFunctionWrapper" instead of "PrototypeFunction" in cross-frame
accessors, so the type of object you get to wrap a function is the same,
regardless of whether the access to the function is cross-frame.
This is faster and more idiomatic than what we had before. It also would
have avoided Bug 26532 because it would have prevented a conflicting
PrototypeFunction from being allocated to wrap postMessage, where a
NativeFunctionWrapper had been allocated previously.
- bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter):
- bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
- bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
- 3:23 PM Changeset in webkit [44876] by
-
- 2 edits in trunk/WebCore
2009-06-19 Simon Fraser <Simon Fraser>
Reviewed by John Sullivan
<rdar://problem/6953673> Crash in RenderLayerCompositor::setCompositingParent
Fix a crash that could occur in complex content due to timing issues
when doing a partial layer tree rebuild which is required when painting;
setCompositingParent() could be called with a parent which has not been made
compositing yet.
- 3:16 PM Changeset in webkit [44875] by
-
- 2 edits in trunk/WebCore
2009-06-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Build fix. Adding missing HTMLDataGrid* files to the build.
- GNUmakefile.am:
- 2:49 PM Changeset in webkit [44874] by
-
- 7 edits in trunk/WebCore
2009-06-19 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460 part three
Make BMPImageReader a standalone class that is used by ICOImageDecoder
and BMPImageDecoder to decode individual BMPs within a file. These
decoders now inherit directly from ImageDecoder.
This also makes these decoders decode on-demand in isSizeAvailable() and
frameBufferAtIndex(), like the other decoders, instead of when setData()
is called, like before. This should provide a speedup on pages
containing BMPs that aren't immediately onscreen.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::setData): (WebCore::BMPImageDecoder::isSizeAvailable): (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decodeWithCheckForDataEnded): (WebCore::BMPImageDecoder::decode): (WebCore::BMPImageDecoder::processFileHeader):
- platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
- platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader): (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::readInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData): (WebCore::BMPImageReader::setFailed):
- platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::setBuffer): (WebCore::BMPImageReader::setData): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::pastEndOfImage): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::setRGBA):
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): (WebCore::ICOImageDecoder::decode): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::readDirectoryEntry): (WebCore::ICOImageDecoder::processImageType):
- platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
- 2:31 PM Changeset in webkit [44873] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 Adam Treat <adam.treat@torchmobile.com>
Blind attempt at build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 2:09 PM Changeset in webkit [44872] by
-
- 1 add in trunk/WebCore/html/HTMLDataGridElement.cpp
Add missed file.
- 2:07 PM Changeset in webkit [44871] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Inherits CallIdentifier struct from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/profiler/CallIdentifier.h:86.
- wtf/HashCountedSet.h:
- 1:57 PM Changeset in webkit [44870] by
-
- 6 edits6 adds in trunk
2009-06-19 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=26540
Currently the SunSpider test driver lacks an option to run a test suite that
will test JavaScriptCore parsing performance only. This patch adds just such
a test suite and option to SunSpider as well as the jsc test shell. I've included
three large javascript source files found in the wild: jquery, mootools and prototype.
Combined with the concatenation of all three, these form a new testsuite to measure
and test pure JavaScriptCore parsing performance.
- 1:38 PM Changeset in webkit [44869] by
-
- 6 edits in trunk/WebCore
2009-06-19 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Fix the Chromium canary bot. Turns out ScriptSourceCode doesn't have
the same API in V8 and JSC.
- WebCore/bindings/js/ScriptController.cpp:
- WebCore/bindings/js/ScriptSourceCode.h:
- WebCore/bindings/v8/ScriptController.cpp:
- WebCore/page/XSSAuditor.cpp:
- WebCore/page/XSSAuditor.h:
- 1:30 PM Changeset in webkit [44868] by
-
- 3 edits1 add in trunk
009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits HashCountedSet class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.
- wtf/HashCountedSet.h:
- 1:17 PM Changeset in webkit [44867] by
-
- 16 edits3 adds in trunk
WebCore:
2009-06-19 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Implement the IDL interface for HTMLDataGridColElement.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLAttributeNames.in:
- html/HTMLDataGridColElement.cpp: Added. (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::label): (WebCore::HTMLDataGridColElement::setLabel): (WebCore::HTMLDataGridColElement::type): (WebCore::HTMLDataGridColElement::setType): (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection): (WebCore::HTMLDataGridColElement::selected): (WebCore::HTMLDataGridColElement::setSelected):
- html/HTMLDataGridColElement.h: Added. (WebCore::HTMLDataGridColElement::endTagRequirement): (WebCore::HTMLDataGridColElement::tagPriority):
- html/HTMLDataGridColElement.idl: Added.
- html/HTMLDataGridElement.h:
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
- page/DOMWindow.idl:
LayoutTests:
2009-06-19 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Implement the IDL interface for HTMLDataGridColELement.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- 1:09 PM Changeset in webkit [44866] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26558
Declare these symbols extern for WINCE as they are provided by libce.
- runtime/DateConstructor.cpp:
- runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
- 12:54 PM Changeset in webkit [44865] by
-
- 2 edits in trunk/WebCore
2009-06-19 Chris Evans <scarybeasts@gmail.com>
Reviewed by Eric Seidel.
There is no new test because this cannot be tested deterministically.
I've not been able to cause a crash at all in the test framework, but
I have verified that this is happening in the wild and that the patch
fixes the likely cause in the debugger.
- loader/TextResourceDecoder.cpp: careful not to iterate off the end of our input buffer looking for the end of the comment.
- 12:37 PM Changeset in webkit [44864] by
-
- 4 edits in trunk
Versioning.
- 12:35 PM Changeset in webkit [44863] by
-
- 1 copy in tags/Safari-6531
New tag.
- 11:48 AM Changeset in webkit [44862] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/6988973> ScopeChain leak in interpreter builds
Reviewed by Maciej Stachowiak
Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
path.
- 11:25 AM Changeset in webkit [44861] by
-
- 3 edits in trunk/WebCore
2009-06-19 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Fix external-script-URL-location.html and
write-external-script-open.html LayoutTests.
implicitOpen is called from several places. We need to setXSSAuditor
each time, so I moved the call inside implicitOpen.
- dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::implicitOpen):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin):
- 11:22 AM Changeset in webkit [44860] by
-
- 2 edits in trunk/WebCore
2009-06-19 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin.
Use WebCore::multipleFileUploadText() in Chromium to fix a problem
that Chromium shows only the first filename even if a user selects
multiple files for <input type=file multiple>.
<https://bugs.webkit.org/show_bug.cgi?id=26502>
- platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth):
- 11:14 AM Changeset in webkit [44859] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
Test: editing/selection/move-by-line-005.html
The root cause of this bug was searchAheadForBetterMatch() continuing
past the first rendered text object after the given object. While we
want to skip non-rendered text and empty containers, when we encounter
rendered text object, we must return a text box for that object.
- dom/Position.cpp: (WebCore::searchAheadForBetterMatch):
LayoutTests:
Reviewed by Dave Hyatt.
- text for <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
- editing/selection/move-by-line-005-expected.txt: Added.
- editing/selection/move-by-line-005.html: Added.
- 10:46 AM Changeset in webkit [44858] by
-
- 2 edits1 add in trunk/WebCore
2009-06-18 Jungshik Shin <jshin@chromium.org>
Reviewed by David Levin
Chromium Linux port does not handle non-BMP characters properly.
It's fixed with a 'UTF-16 iterator macro' to extract Unicode
codepoints out of a UTF-16 input string.
A manual test is added for non-BMP character rendering,
which we can use until a small freely-distributable font
covering non-BMP is added to the Webkit source tree.
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
- manual-tests/non-bmp.html: Added.
- 10:01 AM Changeset in webkit [44857] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-19 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26543
Windows CE uses 'GetLastError' instead of 'errno.'
- interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
- 9:52 AM Changeset in webkit [44856] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Anders Carlsson.
- update test results after r44806
- platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
- 8:47 AM Changeset in webkit [44855] by
-
- 3 edits in trunk/WebCore
2009-06-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
V8 Bindings: return proper state from the script stack.
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
- 8:34 AM Changeset in webkit [44854] by
-
- 2 edits in trunk/WebCore
2009-06-19 Jessie Berlin <jberlin@apple.com>
Reviewed by Simon Fraser.
Windows build fix.
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- 7:28 AM Changeset in webkit [44853] by
-
- 3 edits in trunk/WebCore
2009-06-19 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
Build fix after 44825.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::isSizeAvailable):
- platform/graphics/qt/ImageDecoderQt.h:
- 5:18 AM Changeset in webkit [44852] by
-
- 2 edits in trunk/WebKit/qt
2009-06-19 Daniel Teske <qt-info@nokia.com>
Reviewed by Simon Hausmann.
Remove warnings for QString() constructions from const char *
By explicitly wrapping it with QLatin1String() / QLatin1Char()
- 2:58 AM Changeset in webkit [44851] by
-
- 2 edits in trunk/WebKitTools
2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Tor Arne Vestbø.
Only pass --makeargs along if an argument is given.
- 2:23 AM Changeset in webkit [44850] by
-
- 6 edits in trunk
2009-06-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Oliver Hunt.
Bug 26426: Canvas: rotation of 'no-repeat' pattern is weird
<https://bugs.webkit.org/show_bug.cgi?id=26426>
Use 1<<23-1 as steps of no-repeat patterns instead of 100000000.0f.
The original number cannot be represented by mantissa of float
(23bit) so that it caused some error.
Test: fast/canvas/image-object-in-canvas.html:
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- 2:06 AM Changeset in webkit [44849] by
-
- 1 edit in trunk/WebCore/bindings/v8/ScriptController.cpp
Fix copy/paste error.
- 1:57 AM Changeset in webkit [44848] by
-
- 4 edits in trunk/WebCore
2009-06-19 abarth <abarth@webkit.org>
Unreviewed attempt to fix the Chromium build.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
- bindings/v8/ScriptController.h: (WebCore::ScriptController::xssAuditor):
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- 1:29 AM Changeset in webkit [44847] by
-
- 3 edits in trunk/WebKitTools
2009-06-19 Adam Barth <abarth@webkit.org>
Unreviewed attempt to fix Windows build.
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled):
- 1:12 AM Changeset in webkit [44846] by
-
- 35 edits7 adds in trunk
WebCore:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added an experimental reflective XSS filter. The filter is disabled by
default.
Test: http/tests/security/xssAuditor/script-tag.html
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
- bindings/js/ScriptController.h: (WebCore::ScriptController::xssAuditor):
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- dom/Tokenizer.h: (WebCore::Tokenizer::xssAuditor): (WebCore::Tokenizer::setXSSAuditor): (WebCore::Tokenizer::Tokenizer):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::requestObject):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setXSSAuditorEnabled):
- page/Settings.h: (WebCore::Settings::xssAuditorEnabled):
- page/XSSAuditor.cpp: Added. (WebCore::isControlCharacter): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::~XSSAuditor): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h: Added. (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::setXSSAuditorEnabled):
WebKit/mac:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added preference to enable the XSSAuditor.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isXSSAuditorEnabled]): (-[WebPreferences setXSSAuditorEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
WebKit/win:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added preference to enable the XSSAuditor.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isXSSAuditorEnabled): (WebPreferences::setXSSAuditorEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
WebKitTools:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add support for testing the XSSAuditor.
- DumpRenderTree/LayoutTestController.cpp: (setXSSAuditorEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setXSSAuditorEnabled):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setPopupBlockingEnabled):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setXSSAuditorEnabled):
LayoutTests:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added a basic test for the XSSAuditor.
- http/tests/security/xssAuditor/resources/echo-intertag.php: Added.
- http/tests/security/xssAuditor/script-tag-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag.html: Added.
- 12:59 AM Changeset in webkit [44845] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 David Levin <levin@chromium.org>
Reviewed by NOBODY (Windows build fix).
Add export for Windows corresponding to OSX export done in r44844.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 12:10 AM Changeset in webkit [44844] by
-
- 11 edits in trunk/JavaScriptCore
Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>
Reviewed by Gavin "Viceroy of Venezuela" Barraclough.
We need to make sure that each native function instance correctly unlinks any references to it
when it is collected. Allowing this to happen required a few changes:
- Every native function needs a codeblock to track the link information
- To have this codeblock, every function now also needs its own functionbodynode so we no longer get to have a single shared instance.
- Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode
Jun 18, 2009:
- 10:39 PM Changeset in webkit [44843] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
- wtf/DateMath.cpp: (WTF::calculateUTCOffset):
- 10:06 PM Changeset in webkit [44842] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Timezone calculation incorrect in Venezuela.
https://bugs.webkit.org/show_bug.cgi?id=26531
<rdar://problem/6646169> Time is incorrectly reported to JavaScript in both Safari 3 and Firefox 3
The problem is that we're calculating the timezone relative to 01/01/2000,
but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007.
According to the spec, section 15.9.1.9 states "the time since the beginning
of the year", presumably meaning the *current* year. Change the calculation
to be based on whatever the current year is, rather than a canned date.
No performance impact.
- wtf/DateMath.cpp: (WTF::calculateUTCOffset):
- 10:06 PM Changeset in webkit [44841] by
-
- 3 edits4 adds in trunk
2009-06-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
feOffset and objectBoundingBox
https://bugs.webkit.org/show_bug.cgi?id=26441
If we use objectBoundingBox for primitiveUnits, the fractions given
to dx or dy of feOffset must be multiplied with the referenced objects
objectBoundingBox size.
Test: svg/filters/feOffset.svg
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
Test for feOffset with the primitiveUnits objectBoundingBox
and userSpaceOnUse.
- platform/mac/svg/filters/feOffset-expected.checksum: Added.
- platform/mac/svg/filters/feOffset-expected.png: Added.
- platform/mac/svg/filters/feOffset-expected.txt: Added.
- svg/filters/feOffset.svg: Added.
- 10:00 PM Changeset in webkit [44840] by
-
- 6 edits8 adds in trunk
2009-06-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
feTile implementation missing
https://bugs.webkit.org/show_bug.cgi?id=26419
Implementation of feTile, a pattern effect for SVG filters. It was
necessary to modify FilterEffect since source inputs need a secial
logic and we have to identify if an effect is a source input.
Tests: svg/batik/filters/feTile.svg
svg/filters/feTile.svg
- platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isSourceInput):
- platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput):
- platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput):
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
Reviewed by Oliver Hunt.
Added a test of batik and a own one to check behavior of the
new feTile effect in SVG.
- platform/mac/svg/batik/filters/feTile-expected.checksum: Added.
- platform/mac/svg/batik/filters/feTile-expected.png: Added.
- platform/mac/svg/batik/filters/feTile-expected.txt: Added.
- platform/mac/svg/filters/feTile-expected.checksum: Added.
- platform/mac/svg/filters/feTile-expected.png: Added.
- platform/mac/svg/filters/feTile-expected.txt: Added.
- svg/batik/filters/feTile.svg: Added.
- svg/filters/feTile.svg: Added.
- 9:44 PM Changeset in webkit [44839] by
-
- 4 edits4 adds in trunk
2009-06-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
feMerge implementation
https://bugs.webkit.org/show_bug.cgi?id=26480
Added feMerge to the SVG Filter system.
Test: svg/filters/feMerge.svg
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::uniteChildEffectSubregions): (WebCore::FEMerge::apply):
- svg/graphics/filters/SVGFEMerge.h:
Check the feMerge implementation.
- platform/mac/svg/filters/feMerge-expected.checksum: Added.
- platform/mac/svg/filters/feMerge-expected.png: Added.
- platform/mac/svg/filters/feMerge-expected.txt: Added.
- svg/filters/feMerge.svg: Added.
- 7:32 PM Changeset in webkit [44838] by
-
- 4 edits in trunk/JavaScriptCore
2009-06-18 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Mark Rowe (originally reviewed by Sam Weinig).
(Reintroducing patch added in r44492, and reverted in r44796.)
Change the implementation of op_throw so the stub function always modifies its
return address - if it doesn't find a 'catch' it will switch to a trampoline
to force a return from JIT execution. This saves memory, by avoiding the need
for a unique return for every op_throw.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
JITStubs::cti_op_throw now always changes its return address,
remove return code generated after the stub call (this is now
handled by ctiOpThrowNotCaught).
- jit/JITStubs.cpp: (JSC::):
Add ctiOpThrowNotCaught definitions.
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
Change cti_op_throw to always change its return address.
- jit/JITStubs.h:
Add ctiOpThrowNotCaught declaration.
- 6:51 PM Changeset in webkit [44837] by
-
- 2 edits in trunk/WebCore
Speculative Windows build fix.
- page/win/FrameCGWin.cpp: Add missing #include.
- 6:21 PM Changeset in webkit [44836] by
-
- 8 edits in trunk
WebCore:
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Dave Levin.
https://bugs.webkit.org/show_bug.cgi?id=26425
Final refactorings, picking up a few places where BitmapInfo
could be used.
- page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
- platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
WebKit/win:
2009-06-18 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Dave Levin.
Remove some boilerplate using the BitmapInfo struct.
https://bugs.webkit.org/show_bug.cgi?id=26425
- WebFrame.cpp: (WebFrame::spoolPages):
- WebIconDatabase.cpp: (createDIB):
- WebKit.vcproj/WebKit.sln:
- WebNodeHighlight.cpp: (WebNodeHighlight::update):
- WebView.cpp: (WebView::ensureBackingStore):
- 6:20 PM Changeset in webkit [44835] by
-
- 4 edits2 adds in trunk
Bug 26522: In DOM mode, VoiceOver reads some mouseover text on web sites strangely
https://bugs.webkit.org/show_bug.cgi?id=26522
- 6:18 PM Changeset in webkit [44834] by
-
- 2 edits in trunk/WebCore
wx build fix after recent RenderTheme changes.
- 6:14 PM Changeset in webkit [44833] by
-
- 7 edits in trunk/WebCore
2009-06-18 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460 part two
Attempt to minimize diff of following functional change by first landing
non-functional change to:
- Make readUintX() public and static (since they will need to be once BMPImageReader is included in *ImageDecoder via composition rather than inheritance). Add wrappers in each class so callers can be simpler. In the next patch, these wrappers will be beefed up slightly and the callers will get even simpler.
- Change direct setting of m_failed to use setFailed(), since in the next patch much of this code won't even have direct access to m_failed
- Add a helper function in ICOImageDecoder to determine the image type instead of simply doing it inline
- Rewrap lines that used to be <=80 cols and slipped over it during the original landing of these decoders
- Other misc. changes, e.g. adding constructor definitions, reordering functions, changing RGBA32Buffer& to RGBA32Buffer*, etc. that have no functional effect but minimize the subsequent diff for readability
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::processFileHeader):
- platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
- platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::getInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData):
- platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16Helper): (WebCore::BMPImageReader::readUint32Helper): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::getComponent): (WebCore::BMPImageReader::setI): (WebCore::BMPImageReader::setRGBA): (WebCore::BMPImageReader::fillRGBA):
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::decodeImage): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::isBetterEntry): (WebCore::ICOImageDecoder::processImageType):
- platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
- 3:52 PM Changeset in webkit [44832] by
-
- 2 edits in trunk/WebCore
2009-06-18 Peter Kasting <pkasting@google.com>
Fix build bustage.
- platform/image-decoders/gif/GIFImageDecoder.h:
- 3:34 PM Changeset in webkit [44831] by
-
- 11 edits in trunk
2009-06-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit
- Exposed functions now needed by WebCore.
- JavaScriptCore.exp:
WebCore:
2009-06-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit
Convert intptr_t to Strings so that we don't loose bits in the
conversion to JS. Previously they were being put into 32bit ints.
- inspector/InspectorController.cpp: Convert the String back to an intptr_t. (WebCore::InspectorController::addBreakpoint): (WebCore::InspectorController::removeBreakpoint):
- inspector/InspectorController.h:
- inspector/InspectorController.idl: Use strings in JS to avoid 32bit truncation.
- inspector/InspectorFrontend.cpp: Make the intptr_t into a String. (WebCore::InspectorFrontend::parsedScriptSource):
- platform/text/PlatformString.h: Implemented the necessary conversion functions to be able to convert to and from an intptr_t.
- platform/text/String.cpp: Ditto. (WebCore::String::toIntPtrStrict): (WebCore::String::toIntPtr): (WebCore::charactersToIntPtrStrict): (WebCore::charactersToIntPtr):
- platform/text/StringImpl.cpp: Ditto. (WebCore::StringImpl::toIntPtrStrict): (WebCore::StringImpl::toIntPtr):
- platform/text/StringImpl.h: Ditto.
- 3:15 PM Changeset in webkit [44830] by
-
- 3 edits2 adds8 deletes in trunk/LayoutTests
2009-06-18 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.
- editing/execCommand/insertHTML-expected.txt: Added.
- editing/execCommand/insertHTML.html:
- editing/execCommand/switch-list-type-expected.txt: Added.
- editing/execCommand/switch-list-type.html:
- platform/mac/editing/execCommand/insertHTML-expected.checksum: Removed.
- platform/mac/editing/execCommand/insertHTML-expected.png: Removed.
- platform/mac/editing/execCommand/insertHTML-expected.txt: Removed.
- platform/mac/editing/execCommand/switch-list-type-expected.checksum: Removed.
- platform/mac/editing/execCommand/switch-list-type-expected.png: Removed.
- platform/mac/editing/execCommand/switch-list-type-expected.txt: Removed.
- platform/qt/editing/execCommand/insertHTML-expected.txt: Removed.
- platform/qt/editing/execCommand/switch-list-type-expected.txt: Removed.
- 3:04 PM Changeset in webkit [44829] by
-
- 3 edits in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
Final cleanups in this refactoring:
(1) Move WindowsBitmap implementation from CG-specific file to
the platform-common GraphicsContextWin.cpp, since it is
equally useful on both platforms.
(2) Revise the TransformationMatrix logic as suggested by
Adam Roben in his review comments to Part #2 of this
refactoring.
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap): (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- 2:44 PM Changeset in webkit [44828] by
-
- 3 edits in trunk/WebKit/mac
2009-06-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/6926859>
NPN_ConvertPoint doesn't give the right value when converting to/from NPCoordinateSpaceFlippedScreen
When inverting Y, use the height of the first screen instead of the screen the window is on.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::windowFrameChanged): (WebKit::NetscapePluginInstanceProxy::mouseEvent):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
- 2:39 PM Changeset in webkit [44827] by
-
- 3 edits in trunk/WebKit/gtk
2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez and Christian Dywan.
Add a new load status to report that the first visually non-empty
layout has been done.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
- webkit/webkitwebframe.h:
- 2:39 PM Changeset in webkit [44826] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Fix parameters of navigation-policy-decision-requested callback,
to be correct in number and type
- tests/testhttpbackend.c: (navigation_policy_decision_requested_cb):
- 2:29 PM Changeset in webkit [44825] by
-
- 12 edits in trunk/WebCore
2009-06-18 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460 part one
Make isSizeAvailable non-const, since it's not logically const (it
triggers lazy decoding), and simplify all the implementations (without
changing behavior; just make less verbose). Remove some other
inappropriate consts, which enables the removal of all the mutable
declarations in the decoders.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::setSize): Make public to avoid needing a friend declaration in the JPEG decoder, and because the ICO/BMP decoders will soon need this.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::isSizeAvailable): (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::decode):
- platform/image-decoders/gif/GIFImageDecoder.h:
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::isSizeAvailable):
- platform/image-decoders/ico/ICOImageDecoder.h:
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::isSizeAvailable): (WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::isSizeAvailable): (WebCore::PNGImageDecoder::decode):
- platform/image-decoders/png/PNGImageDecoder.h:
- platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::isSizeAvailable): (WebCore::XBMImageDecoder::frameBufferAtIndex): (WebCore::XBMImageDecoder::decode):
- platform/image-decoders/xbm/XBMImageDecoder.h: Rename decodeXBM() to decode() for consistency with the JPEG/PNG decoders, and in the future the ICO/BMP decoders.
- 2:25 PM Changeset in webkit [44824] by
-
- 4 edits3 adds12 deletes in trunk/LayoutTests
2009-06-18 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.
- editing/execCommand/5207369-expected.txt: Added.
- editing/execCommand/5207369.html:
- editing/execCommand/5210032-expected.txt: Added.
- editing/execCommand/5210032.html:
- editing/execCommand/5432254-1-expected.txt: Added.
- editing/execCommand/5432254-1.html:
- platform/mac/editing/execCommand/5207369-expected.checksum: Removed.
- platform/mac/editing/execCommand/5207369-expected.png: Removed.
- platform/mac/editing/execCommand/5207369-expected.txt: Removed.
- platform/mac/editing/execCommand/5210032-expected.checksum: Removed.
- platform/mac/editing/execCommand/5210032-expected.png: Removed.
- platform/mac/editing/execCommand/5210032-expected.txt: Removed.
- platform/mac/editing/execCommand/5432254-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/5432254-1-expected.png: Removed.
- platform/mac/editing/execCommand/5432254-1-expected.txt: Removed.
- platform/qt/editing/execCommand/5207369-expected.txt: Removed.
- platform/qt/editing/execCommand/5210032-expected.txt: Removed.
- platform/qt/editing/execCommand/5432254-1-expected.txt: Removed.
- 2:21 PM Changeset in webkit [44823] by
-
- 4 edits3 adds12 deletes in trunk/LayoutTests
Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.
- editing/execCommand/5142012-3-expected.txt: Added.
- editing/execCommand/5142012-3.html:
- editing/execCommand/5144139-1-expected.txt: Added.
- editing/execCommand/5144139-1.html:
- editing/execCommand/5164796-expected.txt: Added.
- editing/execCommand/5164796.html:
- platform/mac/editing/execCommand/5142012-3-expected.checksum: Removed.
- platform/mac/editing/execCommand/5142012-3-expected.png: Removed.
- platform/mac/editing/execCommand/5142012-3-expected.txt: Removed.
- platform/mac/editing/execCommand/5144139-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/5144139-1-expected.png: Removed.
- platform/mac/editing/execCommand/5144139-1-expected.txt: Removed.
- platform/mac/editing/execCommand/5164796-expected.checksum: Removed.
- platform/mac/editing/execCommand/5164796-expected.png: Removed.
- platform/mac/editing/execCommand/5164796-expected.txt: Removed.
- platform/qt/editing/execCommand/5142012-3-expected.txt: Removed.
- platform/qt/editing/execCommand/5144139-1-expected.txt: Removed.
- platform/qt/editing/execCommand/5164796-expected.txt: Removed.
- 2:13 PM Changeset in webkit [44822] by
-
- 4 edits3 adds12 deletes in trunk/LayoutTests
Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests.
This
fixes the bug 26336 partially.
- editing/execCommand/4916583-expected.txt: Added.
- editing/execCommand/4916583.html:
- editing/execCommand/5119244-expected.txt: Added.
- editing/execCommand/5119244.html:
- editing/execCommand/5120591-expected.txt: Added.
- editing/execCommand/5120591.html:
- platform/mac/editing/execCommand/4916583-expected.checksum: Removed.
- platform/mac/editing/execCommand/4916583-expected.png: Removed.
- platform/mac/editing/execCommand/4916583-expected.txt: Removed.
- platform/mac/editing/execCommand/5119244-expected.checksum: Removed.
- platform/mac/editing/execCommand/5119244-expected.png: Removed.
- platform/mac/editing/execCommand/5119244-expected.txt: Removed.
- platform/mac/editing/execCommand/5120591-expected.checksum: Removed.
- platform/mac/editing/execCommand/5120591-expected.png: Removed.
- platform/mac/editing/execCommand/5120591-expected.txt: Removed.
- platform/qt/editing/execCommand/4916583-expected.txt: Removed.
- platform/qt/editing/execCommand/5119244-expected.txt: Removed.
- platform/qt/editing/execCommand/5120591-expected.txt: Removed.
- 1:47 PM Changeset in webkit [44821] by
-
- 6 edits in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
Move some common functions out of platform files and into
the common implementation.
https://bugs.webkit.org/show_bug.cgi?id=26425.
Add a new platform context method (flush) so that the
getWindowsContext method can be consolidated into the common
GraphicsContextWin.cpp file.
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::flush):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::flush):
- platform/graphics/win/GraphicsContextCGWin.cpp: Remove getWindowContext method.
- platform/graphics/win/GraphicsContextCairoWin.cpp: Remove getWindowContext method and fillWithClearColor methods.
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::fillWithClearColor): Moved from *CairoWin.cpp (WebCore::GraphicsContext::getWindowsContext): Moved from *CairoWin.cpp
- 1:44 PM Changeset in webkit [44820] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-18 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::loadDone): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static function loadDone to emit "load-done" and update the status and update the relevent places. We missed some status notifications before.
- 1:30 PM Changeset in webkit [44819] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Be consistent in always using the term URI instead of URL in the
documentation of WebKitWebView signals.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- 1:28 PM Changeset in webkit [44818] by
-
- 2 edits in trunk/WebCore
2009-06-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Oliver Hunt.
Remove code that I accidentally committed in r44811.
- editing/markup.cpp: (WebCore::createMarkup):
- 1:25 PM Changeset in webkit [44817] by
-
- 3 edits2 adds in trunk
2009-06-18 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/6983207> Non-layer content is not re-rendered when transition
starts sometimes (with hardware acceleration).
When deciding which RenderLayers should be composited, when a layer goes into
compositing mode we repaint the old location. However, we did that before
we'd looked at all the factors that may force a layer to composite, so missed
some cases. Fix by doing the repaint once we really know whether it's going
to composite.
Test: compositing/repaint/become-overlay-composited-layer.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 12:58 PM Changeset in webkit [44816] by
-
- 2 edits8 adds in trunk/LayoutTests
Reviewed by Maciej Stachowiak and Dave Levin.
https://bugs.webkit.org/show_bug.cgi?id=26510
Add tests for authentication behavior with cross-origin XMLHttpRequest
- http/tests/xmlhttprequest/cross-origin-authorization-expected.txt: Added.
- http/tests/xmlhttprequest/cross-origin-authorization.html: Added.
- http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
- http/tests/xmlhttprequest/cross-origin-no-authorization.html: Added.
- http/tests/xmlhttprequest/resources/cross-origin-authorization.php: Added.
- http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added.
- http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php: Added.
- http/tests/xmlhttprequest/resources/cross-origin-preset-authorization-frame.html: Added.
- platform/mac-tiger/Skipped:
- 12:21 PM Changeset in webkit [44815] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
2009-06-18 Darin Adler <Darin Adler>
Rubber stamped by Mark Rowe.
- DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression tests. The close method can be called on a window that's already closed so we can't assert here.
- 12:19 PM Changeset in webkit [44814] by
-
- 3 edits in trunk/WebCore
2009-06-18 Simon Fraser <Simon Fraser>
Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined, and
the Tiger build where QTMovieLayer does not exist.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering): (WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
- 12:18 PM Changeset in webkit [44813] by
-
- 12 edits in trunk
2009-06-17 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429
For marking I decided not to use gcProtect, because this is inside the engine
so it's easy enough to just do marking. And that darned gcProtect does locking!
Oliver tried to convince me to used MarkedArgumentBuffer, but the constructor
for that class says "FIXME: Remove all clients of this API, then remove this API."
- runtime/Collector.cpp: (JSC::Heap::collect): Add a call to JSONObject::markStringifiers.
- runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers): Added emptyIdentifier.
- runtime/CommonIdentifiers.h: Ditto.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Initialize firstStringifierToMark to 0.
- runtime/JSGlobalData.h: Added firstStringifierToMark.
- runtime/JSONObject.cpp: Cut down the includes to the needed ones only. (JSC::unwrapNumberOrString): Added. Helper for unwrapping number and string objects to get their number and string values. (JSC::ReplacerPropertyName::ReplacerPropertyName): Added. The class is used to wrap an identifier or integer so we don't have to do any work unless we actually call a replacer. (JSC::ReplacerPropertyName::value): Added. (JSC::gap): Added. Helper function for the Stringifier constructor. (JSC::PropertyNameForFunctionCall::PropertyNameForFunctionCall): Added. The class is used to wrap an identifier or integer so we don't have to allocate a number or string until we actually call toJSON or a replacer. (JSC::PropertyNameForFunctionCall::asJSValue): Added. (JSC::Stringifier::Stringifier): Updated and moved out of the class definition. Added code to hook this into a singly linked list for marking. (JSC::Stringifier::~Stringifier): Remove from the singly linked list. (JSC::Stringifier::mark): Mark all the objects in the holder stacks. (JSC::Stringifier::stringify): Updated. (JSC::Stringifier::appendQuotedString): Tweaked and streamlined a bit. (JSC::Stringifier::toJSON): Renamed from toJSONValue. (JSC::Stringifier::appendStringifiedValue): Renamed from stringify. Added code to use the m_holderStack to do non-recursive stringify of objects and arrays. This code also uses the timeout checker since in pathological cases it could be slow even without calling into the JavaScript virtual machine. (JSC::Stringifier::willIndent): Added. (JSC::Stringifier::indent): Added. (JSC::Stringifier::unindent): Added. (JSC::Stringifier::startNewLine): Added. (JSC::Stringifier::Holder::Holder): Added. (JSC::Stringifier::Holder::appendNextProperty): Added. This is the function that handles the format of arrays and objects. (JSC::JSONObject::getOwnPropertySlot): Moved this down to the bottom of the file so the JSONObject class is not interleaved with the Stringifier class. (JSC::JSONObject::markStringifiers): Added. Calls mark. (JSC::JSONProtoFuncStringify): Streamlined the code here. The code to compute the gap string is now a separate function.
- runtime/JSONObject.h: Made everything private. Added markStringifiers.
LayoutTests:
2009-06-17 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429
- fast/js/JSON-stringify-expected.txt: Updated.
- fast/js/resources/JSON-stringify.js: Changed the infinite object and infinite array tests to instead just test something a fixed number of levels deep. Otherwise we end up with an infinite loop in the test, which would lead to the slow-script dialog in the production web browser. Also raised the number from 512 to 2048 since there's no fixed limit any more.
- 12:14 PM EFLWebKit edited by
- (diff)
- 12:06 PM Changeset in webkit [44812] by
-
- 2 edits in trunk/WebCore
2009-06-18 Simon Fraser <Simon Fraser>
Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
- 11:58 AM Changeset in webkit [44811] by
-
- 6 edits3 adds in trunk
2009-06-17 Erik Arvidsson <arv@chromium.org>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=15189
Adds the HTML5 input event support for textarea.
Also, moves the oninput attribute parse handling to HTMLElement so that
it can be set on any HTML element so that bubbling events can be handled
using HTML attribute handlers.
Test: fast/forms/textarea-input-event.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
- 11:53 AM Changeset in webkit [44810] by
-
- 6 edits in trunk/WebCore
2009-06-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
Share code between filterEffects
https://bugs.webkit.org/show_bug.cgi?id=26479
Share more code of filter effects. The imageBuffer creation can move to
FilterEffect ant every effect asks for the GraphicsContext. Move the
drawingRect calculation to FilterEffect.
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingRect): (WebCore::FilterEffect::getEffectContext):
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
- 11:52 AM Changeset in webkit [44809] by
-
- 14 edits in trunk/WebCore
2009-06-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Support hardware-accelerationed rendering of video elements.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): (WebCore::HTMLMediaElement::mediaPlayerRepaint): Just move these methods to group the render-related methods together.
(WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
Call out method to ask the RenderLayerCompositor if presentation of this video
can be acclerated. It might say no, if, for example, the video has a reflection.
(WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
Fetch the GraphicsLayer from the RenderVideo that will host the movie layer.
- html/HTMLMediaElement.h: Reordered the rendering-related methods, and added two methods related to video acceleration.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::acceleratedRenderingStateChanged): Called by the rendering system when it determines that the video must go into, or fall off of the hardware-accelerated path.
(WebCore::MediaPlayer::supportsAcceleratedRendering):
Method to say whether the media engine supports accelerated rendering.
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): (WebCore::MediaPlayerClient::mediaPlayerSizeChanged): Moved.
(WebCore::MediaPlayerClient::mediaPlayerRenderingCanBeAccelerated):
(WebCore::MediaPlayerClient::mediaPlayerGraphicsLayer):
New methods to ask the client if the rendering system can support accelerated
rendering, and to get a GraphicsLayer to plug the movie layer into.
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateInterface::acceleratedRenderingStateChanged): Forwarding methods from MediaPlayer.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: Some new methods related to using a QTMovieLayer, and to simplify the rendering mode logic.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): Methods to create and destroy the QTMovieLayer.
(WebCore::MediaPlayerPrivate::currentRenderingMode):
(WebCore::MediaPlayerPrivate::preferredRenderingMode):
Methods to clarify the code that decides which of the 3 rendering modes to use.
(WebCore::MediaPlayerPrivate::setUpVideoRendering):
Changed to use the new rendering mode methods.
(WebCore::MediaPlayerPrivate::tearDownVideoRendering):
Destroy the layer if we have one.
(WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
Small utility method.
(WebCore::MediaPlayerPrivate::updateStates):
Move the call to setUpVideoRendering() to before we send out the state notifications,
so that we will have created the rendering objects already.
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
Return true if we have QTMovieLayer.
(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
We've been told that we went into or out of accelerated mode; maybe reset
the renderer, and set the layer if we have to.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged): We may need to udpate compositing layers if the video went into accelerated mode.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseDirectCompositing): Add smarts to deal with video, which allows us to avoid extra backing store.
(WebCore::RenderLayerBacking::contentsBox):
Use the videoBox to use the content layer for video layers.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): Poke the RenderVideo if the state changed.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Handle an edge case when the video element itself is a stacking context
because of opacity or transform.
(WebCore::RenderLayerCompositor::canAccelerateVideoRendering):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
Allow video to throw us into compositing mode if the media engine supports it.
- rendering/RenderLayerCompositor.h: New methods related to video.
- rendering/RenderVideo.h:
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer): Call rendererContentChanged() to give the compositor a change to throw the video into compositing mode.
(WebCore::RenderVideo::supportsAcceleratedRendering):
(WebCore::RenderVideo::acceleratedRenderingStateChanged):
(WebCore::RenderVideo::videoGraphicsLayer):
Methods to allow the MediaPlayer to do rendering-related stuff via the media element.
- 11:40 AM Changeset in webkit [44808] by
-
- 4 edits4 adds in trunk
Reviewed by Niko.
https://bugs.webkit.org/show_bug.cgi?id=26385
Root SVG element is not checked on requiredFeatures, requiredExtension like other elements
Also do the isValid check for outer <svg>.
Test: svg/custom/outer-svg-unknown-feature.svg
- 11:08 AM Changeset in webkit [44807] by
-
- 2 edits in trunk/LayoutTests
2009-06-18 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
New expected results after making <video> elements get RenderLayers.
- platform/mac/fast/replaced/border-radius-clip-expected.txt:
- 10:54 AM Changeset in webkit [44806] by
-
- 6 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text
Test: fast/forms/search-vertical-alignment.html
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): Vertically center the
the search field's inner block.
LayoutTests:
Reviewed by Darin Adler.
- test and updated result for <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text
- fast/forms/search-vertical-alignment.html: Added.
- platform/mac/fast/forms/search-vertical-alignment-expected.checksum: Added.
- platform/mac/fast/forms/search-vertical-alignment-expected.png: Added.
- platform/mac/fast/forms/search-vertical-alignment-expected.txt: Added.
- platform/mac/fast/forms/search-zoomed-expected.checksum:
- platform/mac/fast/forms/search-zoomed-expected.png:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- 9:30 AM EFLWebKit edited by
- (diff)
- 9:28 AM EFLWebKit edited by
- (diff)
- 8:08 AM Changeset in webkit [44805] by
-
- 2 edits in trunk/WebCore
2009-06-18 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
Fix compilation with Symbian WINSCW compiler, which produced
multiple definitions of the CSSPrimitiveValue conversion operators.
It turns out that they are defined inline but not declared inline.
Adding the inline keyword to the declaration fixes the build.
- 7:45 AM Changeset in webkit [44804] by
-
- 2 edits in trunk/WebKit/qt
2009-06-18 Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed by Simon Hausmann.
Fixed MinGW compilation.
- 7:41 AM Changeset in webkit [44803] by
-
- 4 edits in trunk
2009-06-18 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausman.
Clarify in docs how to compile with debug information.
- 7:40 AM EFLWebKit edited by
- (diff)
- 6:42 AM Changeset in webkit [44802] by
-
- 2 edits in trunk/WebCore
2009-06-18 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] When writing an URL to the clipboard, save the corresponding title
in the mime data as well.
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL):
- 6:40 AM Changeset in webkit [44801] by
-
- 2 edits in trunk/WebCore
2009-06-18 Jakub Wieczorek <faw217@gmail.com>
[Qt] Fix build. Add HTMLDataGridElement.
- WebCore.pro:
- 3:25 AM Changeset in webkit [44800] by
-
- 2 edits in trunk/WebCore
2009-06-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix.
Add HTMLDataGridElement header and IDL to the build script.
- GNUmakefile.am:
- 12:55 AM Changeset in webkit [44799] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-18 Chris Evans <scarybeasts@gmail.com>
Reviewed by Adam Barth.
Fix 8-digit long hex entities. Fixes bug 26454
https://bugs.webkit.org/show_bug.cgi?id=26454
Test: fast/parser/eightdigithexentity.html
- html/HTMLTokenizer.cpp: fix off-by-ones.
LayoutTests:
2009-06-18 Chris Evans <scarybeasts@gmail.com>
Reviewed by Adam Barth.
Added test for bug 26454 (broken 8-digit hex entities).
https://bugs.webkit.org/show_bug.cgi?id=26454
- fast/parser/eightdigithexentity-expected.txt: Added.
- fast/parser/eightdigithexentity.html: Added.
- 12:08 AM Changeset in webkit [44798] by
-
- 2 edits in trunk/WebCore
2009-06-18 David Levin <levin@chromium.org>
Fix chromium linux build.
Fixes a mistake that happened during the complicated merge for
landing r44775, r44776, r44777.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::create):
Jun 17, 2009:
- 11:40 PM Changeset in webkit [44797] by
-
- 3 edits in trunk/JavaScriptCore
<rdar://problem/6974140> REGRESSION(r43849): Crash in cti_op_call_NotJSFunction when getting directions on maps.google.com
Reviewed by Gavin Barraclough
Roll out r43849 as it appears that we cannot rely on the address of
an objects property storage being constant even if the structure is
unchanged.
- 10:50 PM Changeset in webkit [44796] by
-
- 4 edits in trunk/JavaScriptCore
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Mark Rowe.
Fully revert r44492 & r44748 while we fix a bug they cause on internal builds <rdar://problem/6955963>.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
- jit/JITStubs.cpp: (JSC::): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- 7:37 PM Changeset in webkit [44795] by
-
- 5 edits in trunk
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6947426> sunspider math-cordic.js exhibits different intermediate results running 32-bit vs. 64-bit
On 64-bit, NaN-encoded values must be detagged before they can be used in rshift.
No performance impact.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift):
LayoutTests:
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe.
Add tests to check shifts by non-constant amounts.
- fast/js/kde/operators-expected.txt:
- fast/js/kde/resources/operators.js:
- 6:49 PM Changeset in webkit [44794] by
-
- 12 edits in trunk
2009-06-17 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
First step to making video rendering be hardware-accelerated:
make <video> elements get self-painting RenderLayers, and add
an isVideo() virtual method to RenderObject.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): (WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
- rendering/RenderObject.h: (WebCore::RenderObject::isVideo):
- rendering/RenderVideo.h: (WebCore::RenderVideo::requiresLayer): (WebCore::RenderVideo::isVideo):
- 6:22 PM Changeset in webkit [44793] by
-
- 6 edits1 add in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Refactor a few common routines in the various Windows ports
and reduce some duplicated code.
(1) Create TransformationMatrix XFORM casting operator, and
switch various XFORM structure uses to utilize it.
(2) Push concatCTM call to GraphicsContextWin now that the
TransformationMatrix can directly create XFORM (rather
than converting to CGAffineTransform/cairo_matrix_t first.)
- WebCore.vcproj/WebCore.vcproj: Add new BitmapInfo structure.
- platform/graphics/transforms/TransformationMatrix.h:
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/GraphicsContextCairoWin.cpp:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/win/TransformationMatrixWin.cpp: Added. (WebCore::TransformationMatrix::operator XFORM): New operator
- 6:05 PM Changeset in webkit [44792] by
-
- 12 edits6 copies1 add in trunk/LayoutTests
2009-06-17 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Update results after enabling 3d rendering on SnowLeopard.
- platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.checksum.
- platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.png.
- platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.txt.
- platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.checksum.
- platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.png.
- platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.txt. Copy the old "mac" results to "mac-leopard" since 3d-rendering is disabled there.
- platform/mac/fast/media/mq-transform-02-expected.checksum:
- platform/mac/fast/media/mq-transform-02-expected.png:
- platform/mac/fast/media/mq-transform-02-expected.txt:
- platform/mac/fast/media/mq-transform-03-expected.checksum:
- platform/mac/fast/media/mq-transform-03-expected.png:
- platform/mac/fast/media/mq-transform-03-expected.txt: New "mac" results for 3d rendering enabled.
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Update the results now that these tests are active.
- 5:41 PM Changeset in webkit [44791] by
-
- 20 edits in trunk
WebKit/win:
2009-06-17 Steve Falkenburg <sfalken@apple.com>
Consolidate WebKit COM interfaces.
Moved IID from the highest numbered COM interface to the first interface and combined all methods.
Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces.
Reviewed by Adam Roben.
- Interfaces/IWebFrameLoadDelegate.idl:
- Interfaces/IWebFrameLoadDelegatePrivate.idl:
- Interfaces/IWebResourceLoadDelegatePrivate.idl:
- Interfaces/IWebUIDelegate.idl:
- Interfaces/IWebUIDelegatePrivate.idl:
- Interfaces/WebKit.idl:
- WebCoreSupport/WebChromeClient.cpp:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebContextMenuClient.cpp:
- WebCoreSupport/WebFrameLoaderClient.cpp:
- WebCoreSupport/WebInspectorDelegate.h:
- WebFrame.cpp:
- WebView.cpp:
WebKitTools:
2009-06-17 Steve Falkenburg <sfalken@apple.com>
Updated for consolidated WebKit COM interfaces.
Reviewed by Adam Roben.
- DumpRenderTree/win/FrameLoadDelegate.cpp:
- DumpRenderTree/win/FrameLoadDelegate.h:
- DumpRenderTree/win/UIDelegate.cpp:
- DumpRenderTree/win/UIDelegate.h:
- WinLauncher/WinLauncher.h:
- 5:37 PM Changeset in webkit [44790] by
-
- 2 edits in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Non-CG Windows build fix after @r44758.
- rendering/RenderThemeWin.cpp: (WebCore::RenderTheme::themeForPage):
- 5:32 PM Changeset in webkit [44789] by
-
- 8 edits2 adds in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Refactor a few common routines in the various Windows ports
and reduce some duplicated code.
https://bugs.webkit.org/show_bug.cgi?id=26425.
Refactor use of BITMAPINFO for the new BitmapInfo structure.
- WebCore.vcproj/WebCore.vcproj:
- platform/win/BitmapInfo.cpp: Added. (WebCore::bitmapInfoForSize): (WebCore::BitmapInfo::create): (WebCore::BitmapInfo::createBottomUp):
- platform/win/BitmapInfo.h: Added.
- platform/graphics/win/GraphicsContextCairoWin.cpp:
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/TransformationMatrixWin.cpp: Added. (WebCore::TransformationMatrix::operator XFORM): New operator
- platform/win/DragImageCGWin.cpp: (WebCore::allocImage):
- platform/win/DragImageCairoWin.cpp: (WebCore::allocImage):
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
- 5:28 PM Changeset in webkit [44788] by
-
- 4 copies1 add in releases/Apple/Safari 4.0.1
Create Safari 4.0.1 release tag, consisting of version 5530.18 of WebCore and WebKit. JavaScriptCore and JavaScriptGlue remain unchanged.
- 5:21 PM Changeset in webkit [44787] by
-
- 4 copies1 add in releases/Apple/Safari 4.0
Create Safari 4.0 release tag, consisting of version x530.17 of each project.
- 3:37 PM Changeset in webkit [44786] by
-
- 3 edits in trunk/WebCore
Remove unnecessary 6th parameter from SOFT_LINK_OPTIONAL
Reviewed by Mark Rowe.
- platform/graphics/win/ColorSafari.cpp: Removed the 6th parameter and an unnecessary parameter name.
- platform/win/SoftLinking.h: Removed the unused 6th parameter.
- 3:10 PM Changeset in webkit [44785] by
-
- 3 edits in trunk/WebCore
Make Settings::shouldPaintNativeControls default to true
This matches the default up in WebKit (that was changed in r43318).
Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style
form controls
<https://bugs.webkit.org/show_bug.cgi?id=26493>
Reviewed by Darin Adler and Dave Hyatt.
No test possible since DRT always uses Mac-style form controls.
- page/Settings.cpp: Changed the initial value of gShouldPaintNativeControls to true.
- rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Added a FIXME about the design flaw here involving querying Settings before it's been initialized.
- 2:42 PM WebKit Team edited by
- (diff)
- 2:26 PM Changeset in webkit [44784] by
-
- 1 edit in trunk/LayoutTests/fast/js/global-constructors-expected.txt
Update layout test results for addition of datagrid element.
- 2:24 PM Changeset in webkit [44783] by
-
- 2 edits in trunk/WebCore
2009-06-17 David Levin <levin@chromium.org>
Fix chromium Windows build.
A mistake that happened during the complicated merge for
landing r44775, r44776, r44777.
- rendering/RenderThemeChromiumWin.h: (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
- 2:17 PM EFLWebKit edited by
- (diff)
- 2:16 PM Changeset in webkit [44782] by
-
- 2 edits in trunk/WebCore
2009-06-17 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6981193> Crash in MediaControlInputElement::attachToParent
- rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::attachToParent): NULL check element renderer or parent renderer. (WebCore::MediaControlInputElement::attachToParent): Ditto.
- 2:03 PM EFLWebKit edited by
- (diff)
- 2:02 PM EFLWebKit edited by
- (diff)
- 1:51 PM EFLWebKit edited by
- (diff)
- 1:46 PM EFLWebKit edited by
- (diff)
- 1:45 PM EFLWebKit edited by
- (diff)
- 1:31 PM EFLWebKit edited by
- (diff)
- 1:11 PM Changeset in webkit [44781] by
-
- 2 edits in trunk/WebKitSite
2009-06-17 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
- security/index.html: Fix some typos.
- 1:05 PM Changeset in webkit [44780] by
-
- 3 edits in trunk/WebCore
2009-06-17 David Hyatt <hyatt@apple.com>
Fix Windows build. There's no HTMLDataGridElement.cpp file yet.
- html/HTMLElementsAllInOne.cpp:
- 12:56 PM Changeset in webkit [44779] by
-
- 2 edits1 move in trunk/WebKitSite
2009-06-17 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Move security policy to security/index.html so that
webkit.org/security/ works.
- nav.inc:
- security/index.html: Copied from security/security-policy.html.
- security/security-policy.html: Removed.
- 12:33 PM Changeset in webkit [44778] by
-
- 15 edits2 adds in trunk
WebCore:
2009-06-17 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben and Anders Carlsson.
Stub out the HTMLDataGridElement.
- DerivedSources.make:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
- editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
- html/HTMLDataGridElement.h: Added. (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::tagPriority):
- html/HTMLDataGridElement.idl: Added.
- html/HTMLElement.cpp: (WebCore::inlineTagList):
- html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
- html/HTMLTagNames.in:
LayoutTests:
2009-06-17 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Update window properties layout test for HTMLDataGridElement addition.
- fast/dom/Window/window-properties-expected.txt:
- 12:31 PM Changeset in webkit [44777] by
-
- 2 edits in trunk/WebCore
2009-06-17 David Levin <levin@chromium.org>
Reviewed by NOBODY (chromium build fix).
Fix typo in previous changes.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
- 12:18 PM Changeset in webkit [44776] by
-
- 7 edits in trunk/WebCore
2009-06-17 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26148
Remove common code from RenderThemeChromiumWin that is shared with
RenderThemeChromiumSkia.
Also move supportsControlTints to RenderThemeChromiumLinux since it
is linux specific.
There are no tests changed because this just removes functions with
duplicate implementations between the base and derived classes.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::supportsControlTints):
- rendering/RenderThemeChromiumLinux.h:
- rendering/RenderThemeChromiumSkia.cpp:
- rendering/RenderThemeChromiumSkia.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::getNonClientMetrics): (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::systemFont): (WebCore::RenderThemeChromiumWin::paintCheckbox): (WebCore::RenderThemeChromiumWin::paintRadio): (WebCore::RenderThemeChromiumWin::paintSliderThumb): (WebCore::RenderThemeChromiumWin::caretBlinkIntervalInternal):
- rendering/RenderThemeChromiumWin.h:
- 12:18 PM Changeset in webkit [44775] by
-
- 5 edits in trunk/WebCore
2009-06-17 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26148
Move RenderThemeChromiumSkia into its own file. This is purely a code move.
- rendering/RenderThemeChromiumLinux.cpp:
- rendering/RenderThemeChromiumLinux.h:
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::): (WebCore::setSizeIfAuto): (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumSkia::defaultGUIFont): (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet): (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet): (WebCore::RenderThemeChromiumSkia::supportsHover): (WebCore::RenderThemeChromiumSkia::supportsFocusRing): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor): (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): (WebCore::RenderThemeChromiumSkia::systemFont): (WebCore::RenderThemeChromiumSkia::minimumMenuListSize): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::RenderThemeChromiumSkia::setRadioSize): (WebCore::brightenColor): (WebCore::paintButtonLike): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal): (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
- rendering/RenderThemeChromiumSkia.h: (WebCore::RenderThemeChromiumSkia::supportsControlTints):
- 12:17 PM Changeset in webkit [44774] by
-
- 3 edits in trunk/WebCore
2009-06-17 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26148
Extract RenderThemeChromiumSkia out of RenderThemeChromiumLinux. This
is mostly a code shuffle. The non-suffle changes are:
1) Creation of a caretBlinkIntervalInternal.
2) Moving of some inline functions into the implementation files.
3) Changing of defaultGUIFont into a static class constant from a
static function. Also the type is changed to String.
4) Changing of defaultFontSize into a static class constant from a
static variable in the file scope.
5) The static supportsFocus function was collapsed into
supportsFocusRing.
6) Split the extraDefaultStyleSheet into Skia and Linux versions.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont): (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet): (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet): (WebCore::RenderThemeChromiumSkia::supportsHover): (WebCore::RenderThemeChromiumSkia::supportsFocusRing): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor): (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): (WebCore::RenderThemeChromiumSkia::systemFont): (WebCore::RenderThemeChromiumSkia::minimumMenuListSize): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::RenderThemeChromiumSkia::setRadioSize): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal): (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::systemColor): (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
- rendering/RenderThemeChromiumLinux.h:
- 12:07 PM Changeset in webkit [44773] by
-
- 2 edits3 adds in trunk/WebKitSite
2009-06-13 Sam Weinig <sam@webkit.org>
Reviewed by Timothy Hatcher.
Add WebKit Security Policy and member list of the WebKit Security Group.
- nav.inc:
- security: Added.
- security/security-group-members.html: Added.
- security/security-policy.html: Added.
- 12:02 PM Changeset in webkit [44772] by
-
- 3 edits in trunk/WebCore
Add a SOFT_LINK_OPTIONAL macro
This macro is useful when soft-linking functions that are present in
only some versions of a particular library (e.g., APIs added in
Windows Vista that aren't available on Windows XP).
Reviewed by Ada Chan.
- platform/graphics/win/ColorSafari.cpp: (WebCore::focusRingColor): Use the SoftLinking.h macros instead of doing the soft-link ourselves. Also removed an unused call to focusRingColor.isValid().
- platform/win/SoftLinking.h: Added SOFT_LINK_OPTIONAL.
- 11:25 AM Changeset in webkit [44771] by
-
- 2 edits in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Gustavo Noronha Silva.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26470.
The use of zero-width or zero-height rectangles in generating
gradients caused Windows Cairo to crash, and webkitgtk to
produce invalid images.
- 11:22 AM Changeset in webkit [44770] by
-
- 2 edits in trunk/WebCore
2009-06-17 Ojan Vafai <ojan@chromium.org>
Reviewed by NOBODY (OOPS!).
If loading a font fails because of the sandbox, we ask the browser process to
try to load it by calling ensureFontLoaded. If it still fails after
ensureFontLoaded, we hit a ASSERT_NOT_REACHED.
This case happens once in a while during browser shutdown. The browser will
queue a message to the renderer to shutdown, and will then stop answering sync
messages from the renderer. If the renderer is still loading a page during this
time, it might try to call the browser process to ask to load a font. The
browser process will ignore the request, and the font will fail to load, even
after the second try.
This is unfortunate, but there is no real risk here, since the renderer will be
going away as soon as it processes another message.
This can't be layout tested as it depends on the sandbox.
- platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter):
- 11:21 AM Changeset in webkit [44769] by
-
- 3 edits in trunk/WebCore
2009-06-17 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=26482
<rdar://problem/6978590> When setting playback rate to 0, the audio element stops
playing (doesn't resume later)
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setRate): Always set the rate, even when "paused".
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setRate): Ditto.
- 10:13 AM Changeset in webkit [44768] by
-
- 2 edits in trunk/WebCore
Add all the generated JS*.cpp files back to WebCore.vcproj
They are not compiled by the vcproj directly. Instead they are
compiled as part of DerivedSources.cpp. Having them listed in the
vcproj makes them be included in Project Find, etc.
Rubber-stamped in advance by Steve Falkenburg.
- WebCore.vcproj/WebCore.vcproj:
- 10:01 AM Changeset in webkit [44767] by
-
- 2 edits in trunk/WebCore
2009-06-17 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
Don't fire redundant 'change' events for a file upload form.
https://bugs.webkit.org/show_bug.cgi?id=26471
- platform/FileChooser.cpp: (WebCore::FileChooser::chooseFiles): Suppress change event if the existing selected files and the incoming selected files are equal. (WebCore::FileChooser::chooseIcon): Returns 0 if there is no selected files.
- 9:45 AM Changeset in webkit [44766] by
-
- 4 edits in trunk
2009-06-17 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
- 9:39 AM Changeset in webkit [44765] by
-
- 15 edits in trunk
2009-06-17 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
- 8:54 AM Changeset in webkit [44764] by
-
- 3 edits in trunk/LayoutTests
Fix Skipped file format after r44519
- platform/qt/Skipped:
- platform/win/Skipped: Removed bogus ": Added."s in these files.
- 8:42 AM Changeset in webkit [44763] by
-
- 5 edits in trunk/WebCore
Speculative Mac build fix
- page/Page.h: Forward-declare RenderTheme instead of including RenderTheme.h so that we don't need to make RenderTheme.h a private header for WebKit's benefit.
- editing/SelectionController.cpp:
- rendering/InlineTextBox.cpp:
- rendering/RenderObject.cpp: Added #includes of RenderTheme.h.
- 8:32 AM Changeset in webkit [44762] by
-
- 2 edits in trunk/WebCore
Speculative Mac build fix
- rendering/RenderThemeMac.mm: (WebCore::RenderTheme::create): Added.
- 8:26 AM Changeset in webkit [44761] by
-
- 2 edits in trunk/WebCore
Speculative Mac build fix
- rendering/RenderThemeMac.mm: (WebCore::RenderTheme::themeForPage): Remove the name of an unused parameter.
- 8:14 AM Changeset in webkit [44760] by
-
- 2 edits in trunk/WebCore
Speculative Mac build fix
- page/Page.cpp: (WebCore::Page::Page): Change the initializer order to match the declaration order.
- 7:52 AM Changeset in webkit [44759] by
-
- 3 edits in trunk/WebCore
2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Follow up to bug https://bugs.webkit.org/show_bug.cgi?id=26278
Patch that make WebCore have a RenderTheme per page
Make the Qt implementation of RenderTheme create a theme per page,
and use the QStyle associated with the view of each page, in order
to make the QWidget setStyle() method work as advertised.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::qStyle): (WebCore::findFrameLineWidth): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::adjustRepaintRect): (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::setButtonPadding): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::setPopupPadding):
- platform/qt/RenderThemeQt.h:
- 7:52 AM Changeset in webkit [44758] by
-
- 39 edits in trunk
2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Dave Hyatt and Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=26278
Patch that make WebCore have a RenderTheme per page
Create a different RenderTheme per page, so that RenderTheme has
access to page specific theming. This is needed for the Qt port, as Qt
supports setting the theme (style) per widget.
This change was suggested and discussed with Dave Hyatt.
More detailed:
1) Create a theme per page or one global one, depending on the needs
of the platform.
2) Add an accesser to the theme from RenderObject.
3) Change all uses of the theming to access the theme through
RenderObject, using the global default theme as fallback, when the
document of RenderObject has no page.
When we don't have access to a RenderObject, use the default theme.
4) Modify all RenderTheme platform implementations to work with the
above changes, still creating only one global theme.
- 2:11 AM Changeset in webkit [44757] by
-
- 8 edits in trunk
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com
Remove PropertySlot::putValue - PropertySlots should only be used for getting,
not putting. Rename JSGlobalObject::getOwnPropertySlot to hasOwnPropertyForWrite,
which is what it really was being used to ask, and remove some other getOwnPropertySlot
& getOwnPropertySlotForWrite methods, which were unused and likely to lead to confusion.
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::hasOwnPropertyForWrite):
- runtime/JSObject.h:
- runtime/JSStaticScopeObject.cpp:
- runtime/JSStaticScopeObject.h:
- runtime/PropertySlot.h:
WebCore:
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com
JSDOMWindowCustom was using PropertySlot::putValue, however this interface
appears to be fundaementally incorrect - PropertySlots are only used to get
values, all puts use PutPropertySlot. However PutPropertySlot cannot be
used in the fashion desired here - it only reports the caching type of a
write that has been performed.
(This caused a bug where the put should have triggered a transition, and
failed to do so.)
Removing the faulty case from the optimization leads to a ~0.5% progression
on in-browser SunSpider (presumably the very first case was not being hit
often, and the simplification here is beneficial).
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::put):
- 1:48 AM Changeset in webkit [44756] by
-
- 2 edits in trunk/WebKit/qt
2009-06-17 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausmann.
QWebPage: Don't call supportsSsl()
This stops QWebPage from loading the OpenSSL libs,
certificates etc. when they are not needed for the non-HTTPS case.
Loading the SSL libraries can be a very slow operation.
- 12:41 AM Changeset in webkit [44755] by
-
- 8 edits3 deletes in trunk
WebCore:
2009-06-17 David Levin <levin@chromium.org>
Reviewed by NOBODY, layout tests fix.
https://bugs.webkit.org/show_bug.cgi?id=26326
This reverts commit r44751.
Once that change was checked scrollbars/scrollbar-orientation.html started
crashing on Windows.
- dom/Document.cpp: (WebCore::Document::detach):
- page/FrameView.cpp:
- page/FrameView.h:
- platform/Scrollbar.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
- rendering/RenderScrollbar.h:
LayoutTests:
2009-06-17 David Levin <levin@chromium.org>
Reviewed by NOBODY, layout tests fix.
https://bugs.webkit.org/show_bug.cgi?id=26326
This reverts commit r44751.
Once that change was checked scrollbars/scrollbar-orientation.html started
crashing on Windows.
- scrollbars/resources/page-with-custom-scrollbars.html: Removed.
- scrollbars/scrollbar-crash-on-refresh-expected.txt: Removed.
- scrollbars/scrollbar-crash-on-refresh.html: Removed.
Jun 16, 2009:
- 11:13 PM Changeset in webkit [44754] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
In ImageSource::setData, delete the old m_encoder before replacing it with a new one.
https://bugs.webkit.org/show_bug.cgi?id=26458
- 10:19 PM Changeset in webkit [44753] by
-
- 2 edits in trunk/WebKit/mac
2009-06-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
<rdar://problem/6976766> Control-click on pages with accelerated compositing
content does not work.
Part deux. #ifdef the use of _private->layerHostingView with
USE(ACCELERATED_COMPOSITING)
- WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]):
- 10:12 PM Changeset in webkit [44752] by
-
- 2 edits in trunk/WebKit/mac
2009-06-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
<rdar://problem/6976766> Control-click on pages with accelerated compositing
content does not work.
Remove the WebLayerHostingView subclass of NSView, with its attempts to
forward events to the WebHTMLView, and just fix -[WebHTMLView hitTest:]
to ignore the layerHostingView.
- WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): (-[WebHTMLView attachRootLayer:]):
- 9:56 PM Changeset in webkit [44751] by
-
- 8 edits3 adds in trunk
WebCore:
2009-06-16 David Levin <levin@chromium.org>
Reviewed by David Hyatt.
REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326
Test: scrollbars/scrollbar-crash-on-refresh.html
- dom/Document.cpp: (WebCore::Document::detach): Gives the FrameView a change to do any necessary cleanup on Document::detach() which is where the renderArena gets detroyed.
- page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars): Gets rid of any custom scrollbars (if the docment supplied them).
- page/FrameView.h:
- platform/Scrollbar.h: (WebCore::Scrollbar::isCustomScrollbar):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Removed the check for document()->frame(). If frame() is 0 in this code, then the call to animation() is also incorrect (since it does document()->frame()->animation()).
- rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::isCustomScrollbar):
LayoutTests:
2009-06-16 David Levin <levin@chromium.org>
Reviewed by David Hyatt.
REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326
Test that refreshing an iframe with custom scrollbars works without crashing.
- scrollbars/resources/page-with-custom-scrollbars.html: Added.
- scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
- scrollbars/scrollbar-crash-on-refresh.html: Added.
- 7:35 PM Changeset in webkit [44750] by
-
- 2 edits in trunk/WebCore
2009-06-16 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adele Peterson.
Fix of <rdar://6967547> Ctrl-C copies null value erasing text in clipboard in Safari.
This patch kept the way events were firing as they were before, and Windows events are
consistent with Mac.
- editing/Editor.cpp: (WebCore::Editor::tryDHTMLCopy): Added check for canCopy() before clearing PasteBoard (WebCore::Editor::tryDHTMLCut): Added check for canCut() before clearing PasteBoard
- 5:38 PM Changeset in webkit [44749] by
-
- 14 edits in trunk/WebCore
2009-06-16 Antti Koivisto <Antti Koivisto>
Reviewed by Brady Eidson.
<rdar://problem/6660037> CrashTracer: [USER] 46 crashes in Safari at com.apple.WebCore • WebCore::CachedCSSStyleSheet::addClient + 53
When revalidating a resource, calling addClient() on one client might cause another to get removed.
- made CachedResource::addClient() non-virtual and added virtual didAddClient()
- in CachedResource::switchClientsToRevalidatedResource() add all clients to the client set of the revalidated resource first
- check if the client is still in the set before invoking didAddClient() for it
No test case, I didn't manage to construct one. You need some combination of 304 revalidation, stylesheets that
reference each other via @imports and reloading.
- WebCore.base.exp:
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::didAddClient):
- loader/CachedCSSStyleSheet.h:
- loader/CachedFont.cpp: (WebCore::CachedFont::didAddClient):
- loader/CachedFont.h:
- loader/CachedImage.cpp: (WebCore::CachedImage::didAddClient):
- loader/CachedImage.h:
- loader/CachedResource.cpp: (WebCore::CachedResource::addClient): (WebCore::CachedResource::addClientToSet): (WebCore::CachedResource::switchClientsToRevalidatedResource):
- loader/CachedResource.h:
- loader/CachedScript.cpp: (WebCore::CachedScript::didAddClient):
- loader/CachedScript.h:
- loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::didAddClient):
- loader/CachedXSLStyleSheet.h:
- 4:35 PM Changeset in webkit [44748] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver hunt.
Temporarily partially disable r44492, since this is causing some problems on internal builds.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
- jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- 3:39 PM Changeset in webkit [44747] by
-
- 533 edits in branches/WWDC-2009-branch/LayoutTests
2009-06-16 Beth Dakin <Beth Dakin>
Rubber-stamped by Mark Rowe.
The rest of the text metric layout test changes for the branch.
- fast/forms/text-control-intrinsic-widths-expected.txt:
- fast/forms/textarea-metrics-expected.txt:
- fast/replaced/table-percent-height-text-controls-expected.txt:
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum:
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.png:
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum:
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png:
- platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt:
- platform/mac-leopard/media/audio-controls-rendering-expected.checksum:
- platform/mac-leopard/media/audio-controls-rendering-expected.png:
- platform/mac-leopard/media/video-aspect-ratio-expected.checksum:
- platform/mac-leopard/media/video-aspect-ratio-expected.png:
- platform/mac-leopard/media/video-controls-rendering-expected.checksum:
- platform/mac-leopard/media/video-controls-rendering-expected.png:
- platform/mac-leopard/media/video-display-toggle-expected.checksum:
- platform/mac-leopard/media/video-display-toggle-expected.png:
- platform/mac-leopard/media/video-empty-source-expected.png:
- platform/mac-leopard/media/video-layer-crash-expected.checksum:
- platform/mac-leopard/media/video-layer-crash-expected.png:
- platform/mac-leopard/media/video-transformed-expected.checksum:
- platform/mac-leopard/media/video-transformed-expected.png:
- platform/mac-leopard/media/video-zoom-controls-expected.checksum:
- platform/mac-leopard/media/video-zoom-controls-expected.png:
- platform/mac-leopard/media/video-zoom-expected.checksum:
- platform/mac-leopard/media/video-zoom-expected.png:
- platform/mac/animations/animation-drt-api-expected.png:
- platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum:
- platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.png:
- platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum:
- platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.png:
- platform/mac/fast/backgrounds/background-clip-text-expected.checksum:
- platform/mac/fast/backgrounds/background-clip-text-expected.png:
- platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-background-3-expected.png:
- platform/mac/fast/block/margin-collapse/103-expected.checksum:
- platform/mac/fast/block/margin-collapse/103-expected.png:
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/block/positioning/047-expected.checksum:
- platform/mac/fast/block/positioning/047-expected.png:
- platform/mac/fast/borders/border-image-rotate-transform-expected.checksum:
- platform/mac/fast/borders/border-image-rotate-transform-expected.png:
- platform/mac/fast/css-generated-content/hit-test-generated-content-expected.png:
- platform/mac/fast/css/line-height-expected.checksum:
- platform/mac/fast/css/line-height-expected.png:
- platform/mac/fast/css/line-height-expected.txt:
- platform/mac/fast/css/line-height-font-order-expected.checksum:
- platform/mac/fast/css/line-height-font-order-expected.png:
- platform/mac/fast/css/resize-corner-tracking-expected.checksum:
- platform/mac/fast/css/resize-corner-tracking-expected.png:
- platform/mac/fast/css/resize-corner-tracking-expected.txt:
- platform/mac/fast/css/resize-corner-tracking-transformed-expected.png:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/mac/fast/dom/isindex-002-expected.checksum:
- platform/mac/fast/dom/isindex-002-expected.png:
- platform/mac/fast/dom/isindex-002-expected.txt:
- platform/mac/fast/dynamic/008-expected.checksum:
- platform/mac/fast/dynamic/008-expected.png:
- platform/mac/fast/dynamic/008-expected.txt:
- platform/mac/fast/events/autoscroll-expected.checksum:
- platform/mac/fast/events/autoscroll-expected.png:
- platform/mac/fast/events/autoscroll-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.checksum:
- platform/mac/fast/events/context-no-deselect-expected.png:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/events/label-focus-expected.checksum:
- platform/mac/fast/events/label-focus-expected.png:
- platform/mac/fast/events/label-focus-expected.txt:
- platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum:
- platform/mac/fast/events/standalone-image-drag-to-editable-expected.png:
- platform/mac/fast/forms/001-expected.checksum:
- platform/mac/fast/forms/001-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.checksum:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.checksum:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/control-restrict-line-height-expected.checksum:
- platform/mac/fast/forms/control-restrict-line-height-expected.png:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/encoding-test-expected.checksum:
- platform/mac/fast/forms/encoding-test-expected.png:
- platform/mac/fast/forms/encoding-test-expected.txt:
- platform/mac/fast/forms/fieldset-align-expected.checksum:
- platform/mac/fast/forms/fieldset-align-expected.png:
- platform/mac/fast/forms/fieldset-align-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.checksum:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/input-align-expected.checksum:
- platform/mac/fast/forms/input-align-expected.png:
- platform/mac/fast/forms/input-align-expected.txt:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.checksum:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.checksum:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-disabled-expected.checksum:
- platform/mac/fast/forms/input-appearance-disabled-expected.png:
- platform/mac/fast/forms/input-appearance-disabled-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.checksum:
- platform/mac/fast/forms/input-appearance-focus-expected.png:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.checksum:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.checksum:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.checksum:
- platform/mac/fast/forms/input-appearance-readonly-expected.png:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.checksum:
- platform/mac/fast/forms/input-appearance-selection-expected.png:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-visibility-expected.checksum:
- platform/mac/fast/forms/input-appearance-visibility-expected.png:
- platform/mac/fast/forms/input-appearance-visibility-expected.txt:
- platform/mac/fast/forms/input-appearance-width-expected.checksum:
- platform/mac/fast/forms/input-appearance-width-expected.png:
- platform/mac/fast/forms/input-appearance-width-expected.txt:
- platform/mac/fast/forms/input-baseline-expected.checksum:
- platform/mac/fast/forms/input-baseline-expected.png:
- platform/mac/fast/forms/input-baseline-expected.txt:
- platform/mac/fast/forms/input-disabled-color-expected.checksum:
- platform/mac/fast/forms/input-disabled-color-expected.png:
- platform/mac/fast/forms/input-disabled-color-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.checksum:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-paste-undo-expected.checksum:
- platform/mac/fast/forms/input-paste-undo-expected.png:
- platform/mac/fast/forms/input-paste-undo-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-readonly-dimmed-expected.checksum:
- platform/mac/fast/forms/input-readonly-dimmed-expected.png:
- platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
- platform/mac/fast/forms/input-readonly-empty-expected.checksum:
- platform/mac/fast/forms/input-readonly-empty-expected.png:
- platform/mac/fast/forms/input-readonly-empty-expected.txt:
- platform/mac/fast/forms/input-spaces-expected.checksum:
- platform/mac/fast/forms/input-spaces-expected.png:
- platform/mac/fast/forms/input-spaces-expected.txt:
- platform/mac/fast/forms/input-table-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.checksum:
- platform/mac/fast/forms/input-text-click-inside-expected.png:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-click-outside-expected.checksum:
- platform/mac/fast/forms/input-text-click-outside-expected.png:
- platform/mac/fast/forms/input-text-click-outside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.checksum:
- platform/mac/fast/forms/input-text-double-click-expected.png:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.checksum:
- platform/mac/fast/forms/input-text-drag-down-expected.png:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.checksum:
- platform/mac/fast/forms/input-text-option-delete-expected.png:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.checksum:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.png:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/input-text-word-wrap-expected.checksum:
- platform/mac/fast/forms/input-text-word-wrap-expected.png:
- platform/mac/fast/forms/input-text-word-wrap-expected.txt:
- platform/mac/fast/forms/input-type-change2-expected.checksum:
- platform/mac/fast/forms/input-type-change2-expected.png:
- platform/mac/fast/forms/input-type-change2-expected.txt:
- platform/mac/fast/forms/input-type-text-min-width-expected.checksum:
- platform/mac/fast/forms/input-type-text-min-width-expected.png:
- platform/mac/fast/forms/input-type-text-min-width-expected.txt:
- platform/mac/fast/forms/input-value-expected.checksum:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/forms/input-width-expected.checksum:
- platform/mac/fast/forms/input-width-expected.png:
- platform/mac/fast/forms/input-width-expected.txt:
- platform/mac/fast/forms/isindex-placeholder-expected.checksum:
- platform/mac/fast/forms/isindex-placeholder-expected.png:
- platform/mac/fast/forms/isindex-placeholder-expected.txt:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
- platform/mac/fast/forms/menulist-clip-expected.checksum:
- platform/mac/fast/forms/menulist-clip-expected.png:
- platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
- platform/mac/fast/forms/menulist-narrow-width-expected.png:
- platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
- platform/mac/fast/forms/menulist-option-wrap-expected.png:
- platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
- platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
- platform/mac/fast/forms/negativeLineHeight-expected.checksum:
- platform/mac/fast/forms/negativeLineHeight-expected.png:
- platform/mac/fast/forms/negativeLineHeight-expected.txt:
- platform/mac/fast/forms/password-placeholder-expected.checksum:
- platform/mac/fast/forms/password-placeholder-expected.png:
- platform/mac/fast/forms/password-placeholder-expected.txt:
- platform/mac/fast/forms/password-placeholder-text-security-expected.checksum:
- platform/mac/fast/forms/password-placeholder-text-security-expected.png:
- platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
- platform/mac/fast/forms/placeholder-set-attribute-expected.png:
- platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
- platform/mac/fast/forms/placeholder-set-value-expected.checksum:
- platform/mac/fast/forms/placeholder-set-value-expected.png:
- platform/mac/fast/forms/placeholder-set-value-expected.txt:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.checksum:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.png:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.png:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/mac/fast/forms/search-placeholder-value-changed-expected.checksum:
- platform/mac/fast/forms/search-placeholder-value-changed-expected.png:
- platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.checksum:
- platform/mac/fast/forms/search-rtl-expected.png:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-styled-expected.txt:
- platform/mac/fast/forms/search-transformed-expected.checksum:
- platform/mac/fast/forms/search-transformed-expected.png:
- platform/mac/fast/forms/search-transformed-expected.txt:
- platform/mac/fast/forms/search-zoomed-expected.checksum:
- platform/mac/fast/forms/search-zoomed-expected.png:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- platform/mac/fast/forms/searchfield-heights-expected.checksum:
- platform/mac/fast/forms/searchfield-heights-expected.png:
- platform/mac/fast/forms/searchfield-heights-expected.txt:
- platform/mac/fast/forms/select-baseline-expected.checksum:
- platform/mac/fast/forms/select-baseline-expected.png:
- platform/mac/fast/forms/select-style-expected.checksum:
- platform/mac/fast/forms/select-style-expected.png:
- platform/mac/fast/forms/tabbing-input-iframe-expected.checksum:
- platform/mac/fast/forms/tabbing-input-iframe-expected.png:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/textAreaLineHeight-expected.checksum:
- platform/mac/fast/forms/textAreaLineHeight-expected.png:
- platform/mac/fast/forms/textAreaLineHeight-expected.txt:
- platform/mac/fast/forms/textarea-align-expected.checksum:
- platform/mac/fast/forms/textarea-align-expected.png:
- platform/mac/fast/forms/textarea-align-expected.txt:
- platform/mac/fast/forms/textarea-rows-cols-expected.checksum:
- platform/mac/fast/forms/textarea-rows-cols-expected.png:
- platform/mac/fast/forms/textarea-rows-cols-expected.txt:
- platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
- platform/mac/fast/forms/textarea-scroll-height-expected.png:
- platform/mac/fast/forms/textarea-scroll-height-expected.txt:
- platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
- platform/mac/fast/forms/textarea-scrollbar-expected.png:
- platform/mac/fast/forms/textarea-scrollbar-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.checksum:
- platform/mac/fast/forms/textarea-scrolled-type-expected.png:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.checksum:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
- platform/mac/fast/forms/textarea-width-expected.checksum:
- platform/mac/fast/forms/textarea-width-expected.png:
- platform/mac/fast/forms/textarea-width-expected.txt:
- platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum:
- platform/mac/fast/forms/textfield-drag-into-disabled-expected.png:
- platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
- platform/mac/fast/forms/textfield-outline-expected.checksum:
- platform/mac/fast/forms/textfield-outline-expected.png:
- platform/mac/fast/forms/textfield-outline-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.checksum:
- platform/mac/fast/forms/textfield-overflow-expected.png:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/mac/fast/frames/content-opacity-1-expected.checksum:
- platform/mac/fast/frames/content-opacity-1-expected.png:
- platform/mac/fast/frames/content-opacity-2-expected.checksum:
- platform/mac/fast/frames/content-opacity-2-expected.png:
- platform/mac/fast/inline/long-wrapped-line-expected.checksum:
- platform/mac/fast/inline/long-wrapped-line-expected.png:
- platform/mac/fast/invalid/residual-style-expected.txt:
- platform/mac/fast/layers/normal-flow-hit-test-expected.png:
- platform/mac/fast/layers/opacity-transforms-expected.png:
- platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
- platform/mac/fast/lists/dynamic-marker-crash-expected.png:
- platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
- platform/mac/fast/overflow/overflow-x-y-expected.checksum:
- platform/mac/fast/overflow/overflow-x-y-expected.png:
- platform/mac/fast/overflow/overflow-x-y-expected.txt:
- platform/mac/fast/parser/comment-in-textarea-expected.checksum:
- platform/mac/fast/parser/comment-in-textarea-expected.png:
- platform/mac/fast/parser/comment-in-textarea-expected.txt:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
- platform/mac/fast/parser/open-comment-in-textarea-expected.checksum:
- platform/mac/fast/parser/open-comment-in-textarea-expected.png:
- platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
- platform/mac/fast/reflections/reflection-masks-expected.png:
- platform/mac/fast/reflections/reflection-overflow-hidden-expected.png:
- platform/mac/fast/repaint/4776765-expected.png:
- platform/mac/fast/repaint/change-transform-expected.png:
- platform/mac/fast/repaint/delete-into-nested-block-expected.png:
- platform/mac/fast/repaint/fixed-expected.checksum:
- platform/mac/fast/repaint/fixed-expected.png:
- platform/mac/fast/repaint/outline-child-repaint-expected.png:
- platform/mac/fast/repaint/outline-repaint-glitch-expected.png:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/repaint/search-field-cancel-expected.checksum:
- platform/mac/fast/repaint/search-field-cancel-expected.png:
- platform/mac/fast/repaint/search-field-cancel-expected.txt:
- platform/mac/fast/repaint/selected-replaced-expected.png:
- platform/mac/fast/repaint/subtree-root-skipped-expected.checksum:
- platform/mac/fast/repaint/subtree-root-skipped-expected.png:
- platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
- platform/mac/fast/repaint/table-outer-border-expected.checksum:
- platform/mac/fast/repaint/table-outer-border-expected.png:
- platform/mac/fast/repaint/transform-absolute-child-expected.png:
- platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/mac/fast/repaint/transform-relative-position-expected.png:
- platform/mac/fast/repaint/transform-repaint-descendants-expected.png:
- platform/mac/fast/replaced/replaced-breaking-expected.checksum:
- platform/mac/fast/replaced/replaced-breaking-expected.png:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.checksum:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/mac/fast/replaced/width100percent-searchfield-expected.checksum:
- platform/mac/fast/replaced/width100percent-searchfield-expected.png:
- platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
- platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
- platform/mac/fast/replaced/width100percent-textarea-expected.png:
- platform/mac/fast/replaced/width100percent-textarea-expected.txt:
- platform/mac/fast/replaced/width100percent-textfield-expected.checksum:
- platform/mac/fast/replaced/width100percent-textfield-expected.png:
- platform/mac/fast/replaced/width100percent-textfield-expected.txt:
- platform/mac/fast/runin/generated-expected.checksum:
- platform/mac/fast/runin/generated-expected.png:
- platform/mac/fast/table/003-expected.checksum:
- platform/mac/fast/table/003-expected.png:
- platform/mac/fast/table/003-expected.txt:
- platform/mac/fast/table/colspanMinWidth-expected.checksum:
- platform/mac/fast/table/colspanMinWidth-expected.png:
- platform/mac/fast/table/colspanMinWidth-expected.txt:
- platform/mac/fast/table/spanOverlapRepaint-expected.checksum:
- platform/mac/fast/table/spanOverlapRepaint-expected.png:
- platform/mac/fast/table/spanOverlapRepaint-expected.txt:
- platform/mac/fast/table/text-field-baseline-expected.checksum:
- platform/mac/fast/table/text-field-baseline-expected.png:
- platform/mac/fast/table/text-field-baseline-expected.txt:
- platform/mac/fast/table/vertical-align-baseline-expected.checksum:
- platform/mac/fast/table/vertical-align-baseline-expected.png:
- platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum:
- platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
- platform/mac/fast/text/textIteratorNilRenderer-expected.checksum:
- platform/mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac/fast/transforms/transform-on-inline-expected.png:
- platform/mac/fast/transforms/transform-table-row-expected.png:
- platform/mac/fast/transforms/transformed-caret-expected.png:
- platform/mac/fast/transforms/transformed-document-element-expected.png:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.checksum:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.png:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac/fonts/serif-expected.checksum:
- platform/mac/fonts/serif-expected.png:
- platform/mac/http/tests/navigation/anchor-frames-expected.checksum:
- platform/mac/http/tests/navigation/anchor-frames-expected.png:
- platform/mac/http/tests/navigation/anchor-frames-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.checksum:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
- platform/mac/svg/batik/masking/maskRegions-expected.checksum:
- platform/mac/svg/batik/masking/maskRegions-expected.png:
- platform/mac/svg/batik/paints/patternRegions-expected.checksum:
- platform/mac/svg/batik/paints/patternRegions-expected.png:
- platform/mac/svg/batik/text/textEffect3-expected.checksum:
- platform/mac/svg/batik/text/textEffect3-expected.png:
- platform/mac/svg/batik/text/textOnPath-expected.checksum:
- platform/mac/svg/batik/text/textOnPath-expected.png:
- platform/mac/svg/batik/text/verticalText-expected.checksum:
- platform/mac/svg/batik/text/verticalText-expected.png:
- platform/mac/svg/batik/text/verticalTextOnPath-expected.checksum:
- platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
- platform/mac/svg/carto.net/window-expected.checksum:
- platform/mac/svg/carto.net/window-expected.png:
- platform/mac/svg/custom/circular-marker-reference-2-expected.checksum:
- platform/mac/svg/custom/circular-marker-reference-2-expected.png:
- platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
- platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
- platform/mac/svg/custom/gradient-rotated-bbox-expected.checksum:
- platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
- platform/mac/svg/custom/gradient-stop-corner-cases-expected.checksum:
- platform/mac/svg/custom/gradient-stop-corner-cases-expected.png:
- platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
- platform/mac/svg/custom/gradient-stroke-width-expected.png:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/mac/svg/custom/js-late-marker-and-object-creation-expected.checksum:
- platform/mac/svg/custom/js-late-marker-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-marker-creation-expected.checksum:
- platform/mac/svg/custom/js-late-marker-creation-expected.png:
- platform/mac/svg/custom/linking-a-03-b-all-expected.checksum:
- platform/mac/svg/custom/linking-a-03-b-all-expected.png:
- platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum:
- platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/mac/svg/custom/marker-changes-expected.checksum:
- platform/mac/svg/custom/marker-changes-expected.png:
- platform/mac/svg/custom/marker-child-changes-expected.checksum:
- platform/mac/svg/custom/marker-child-changes-expected.png:
- platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
- platform/mac/svg/custom/marker-viewBox-changes-expected.png:
- platform/mac/svg/custom/non-circular-marker-reference-expected.checksum:
- platform/mac/svg/custom/non-circular-marker-reference-expected.png:
- platform/mac/svg/custom/path-bad-data-expected.checksum:
- platform/mac/svg/custom/path-bad-data-expected.png:
- platform/mac/svg/custom/pattern-rotate-expected.checksum:
- platform/mac/svg/custom/pattern-rotate-expected.png:
- platform/mac/svg/custom/pointer-events-path-expected.checksum:
- platform/mac/svg/custom/pointer-events-path-expected.png:
- platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
- platform/mac/svg/custom/svg-fonts-in-html-expected.png:
- platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.checksum:
- platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
- platform/mac/svg/custom/use-elementInstance-event-target-expected.checksum:
- platform/mac/svg/custom/use-elementInstance-event-target-expected.png:
- platform/mac/svg/hixie/mixed/003-expected.checksum:
- platform/mac/svg/hixie/mixed/003-expected.png:
- platform/mac/svg/hixie/mixed/003-expected.txt:
- platform/mac/svg/text/text-fonts-01-t-expected.checksum:
- platform/mac/svg/text/text-fonts-01-t-expected.png:
- platform/mac/svg/text/text-path-01-b-expected.checksum:
- platform/mac/svg/text/text-path-01-b-expected.png:
- platform/mac/svg/text/text-text-05-t-expected.png:
- platform/mac/svg/text/text-text-07-t-expected.checksum:
- platform/mac/svg/text/text-text-07-t-expected.png:
- platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12384-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug12384-expected.png:
- platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18359-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
- platform/mac/tables/mozilla/bugs/bug194024-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug194024-expected.png:
- platform/mac/tables/mozilla/bugs/bug194024-expected.txt:
- platform/mac/tables/mozilla/bugs/bug24200-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug24200-expected.png:
- platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug28928-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug28928-expected.png:
- platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30559-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug30559-expected.png:
- platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30692-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug30692-expected.png:
- platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4382-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug4382-expected.png:
- platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51037-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug51037-expected.png:
- platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
- platform/mac/tables/mozilla/bugs/bug55545-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug55545-expected.png:
- platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
- platform/mac/tables/mozilla/bugs/bug59354-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug59354-expected.png:
- platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7342-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug7342-expected.png:
- platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug96334-expected.png:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug99948-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug99948-expected.png:
- platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
- platform/mac/tables/mozilla/dom/tableDom-expected.checksum:
- platform/mac/tables/mozilla/dom/tableDom-expected.png:
- platform/mac/tables/mozilla/dom/tableDom-expected.txt:
- platform/mac/tables/mozilla/other/move_row-expected.checksum:
- platform/mac/tables/mozilla/other/move_row-expected.png:
- platform/mac/tables/mozilla/other/move_row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/mac/transitions/transition-drt-api-expected.png:
- svg/custom/svg-fonts-in-text-controls-expected.txt:
- 3:37 PM Changeset in webkit [44746] by
-
- 2 edits in trunk/WebCore
2009-06-16 Simon Fraser <Simon Fraser>
No Review
Fix code inside an #ifdef that draws the video framerate.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):
- 3:28 PM Changeset in webkit [44745] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-16 Sam Weinig <sam@webkit.org>
Fix windows build.
- jit/JIT.cpp: (JSC::JIT::JIT):
- 3:28 PM Changeset in webkit [44744] by
-
- 3 edits in trunk/WebCore
2009-06-16 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 26456: Hook up V8 bindings for Worker's importScripts functionality.
https://bugs.webkit.org/show_bug.cgi?id=26456
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerCustom.cpp: Fixed missing exception code handling in Worker constructor for V8 bindings. (WebCore::CALLBACK_FUNC_DECL):
- 3:20 PM Changeset in webkit [44743] by
-
- 4 edits in trunk/JavaScriptCore
2009-06-16 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Initialize m_bytecodeIndex to -1 in JIT, and correctly initialize
it for each type of stub using the return address to find the correct
offset.
- jit/JIT.cpp: (JSC::JIT::JIT):
- jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compileCTIMachineTrampolines): (JSC::JIT::compilePatchGetArrayLength):
- jit/JITStubCall.h: (JSC::JITStubCall::call):
- 3:19 PM Changeset in webkit [44742] by
-
- 1 edit35 adds in trunk/WebKitSite/specs/CSSVisualEffects
Added spec directories from http://dev.w3.org/cvsweb/csswg/
which is where they will live. We will edit them here and
then push them to the W3C cvs server.
- 3:09 PM Changeset in webkit [44741] by
-
- 2 edits12 deletes in trunk/WebKitSite/specs/CSSVisualEffects
Removed all the specs because they are stale
index.html: Redirected to point at w3c site
- 2:55 PM Changeset in webkit [44740] by
-
- 3 edits in trunk/WebCore
2009-06-16 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Maciej Stachowiak.
Update of https://bugs.webkit.org/show_bug.cgi?id=26353.
Provide an assignment operator to avoid improper reference
counts on the Cairo font objects. This brings the Windows
Cairo port in line with the GTK+ port.
- 2:35 PM Changeset in webkit [44739] by
-
- 2 edits in trunk/WebKit/win
2009-06-16 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Switch Control+Mousewheel Zooming definitions to match other browsers on Windows.
Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in.
https://bugs.webkit.org/show_bug.cgi?id=25875.
<rdar://problem/6903976>
- WebView.cpp: (WebView::mouseWheel):
- 2:08 PM Changeset in webkit [44738] by
-
- 6 edits in trunk/WebCore
2009-06-16 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Fix for <rdar://problem/6890126> Theme code should fetch the MediaControlElementType from
the MediaControlInputElement, rather than computing it again
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::percentLoaded): New, utility function for controller implementation.
- html/HTMLMediaElement.h:
- rendering/MediaControlElements.h: (WebCore::MediaControlInputElement::displayType): New, return m_displayType.
- rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart): Stop using MediaPlayer object, get button state from the button itself and get movie state from HTMLMediaElement.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaMuteButton): Get state from button instead of MediaPlayer. (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
- 2:00 PM Changeset in webkit [44737] by
-
- 12 edits in trunk/WebCore
2009-06-16 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Bug 26450: Rename values of enum RedirectOriginCheck to make them
clearer.
https://bugs.webkit.org/show_bug.cgi?id=26450
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create): (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::willSendRequest):
- loader/DocumentThreadableLoader.h:
- loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::create): (WebCore::ThreadableLoader::loadResourceSynchronously):
- loader/ThreadableLoader.h:
- workers/Worker.cpp: (WebCore::Worker::Worker):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
- loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
- loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create):
- workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously):
- workers/WorkerScriptLoader.h: (WebCore::WorkerContext::importScripts):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):
- 1:36 PM Changeset in webkit [44736] by
-
- 84 edits in branches/WWDC-2009-branch/LayoutTests
2009-06-15 Beth Dakin <Beth Dakin>
Rubber-stamped by Geoff Garen.
Updating tests on the branch from when we backed out the text
control metrics change. This only covers the editing directory.
- platform/mac/editing/deleting/5168598-expected.checksum:
- platform/mac/editing/deleting/5168598-expected.png:
- platform/mac/editing/deleting/5168598-expected.txt:
- platform/mac/editing/deleting/delete-to-select-table-expected.checksum:
- platform/mac/editing/deleting/delete-to-select-table-expected.png:
- platform/mac/editing/deleting/type-delete-after-quote-expected.checksum:
- platform/mac/editing/deleting/type-delete-after-quote-expected.png:
- platform/mac/editing/inserting/4960120-1-expected.checksum:
- platform/mac/editing/inserting/4960120-1-expected.png:
- platform/mac/editing/inserting/4960120-1-expected.txt:
- platform/mac/editing/inserting/5418891-expected.checksum:
- platform/mac/editing/inserting/5418891-expected.png:
- platform/mac/editing/inserting/5607069-2-expected.checksum:
- platform/mac/editing/inserting/5607069-2-expected.png:
- platform/mac/editing/inserting/5607069-2-expected.txt:
- platform/mac/editing/inserting/5607069-3-expected.checksum:
- platform/mac/editing/inserting/5607069-3-expected.png:
- platform/mac/editing/inserting/5607069-3-expected.txt:
- platform/mac/editing/inserting/before-after-input-element-expected.checksum:
- platform/mac/editing/inserting/before-after-input-element-expected.png:
- platform/mac/editing/inserting/before-after-input-element-expected.txt:
- platform/mac/editing/inserting/typing-tab-designmode-forms-expected.checksum:
- platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png:
- platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
- platform/mac/editing/pasteboard/4806874-expected.checksum:
- platform/mac/editing/pasteboard/4806874-expected.png:
- platform/mac/editing/pasteboard/4806874-expected.txt:
- platform/mac/editing/pasteboard/5387578-expected.checksum:
- platform/mac/editing/pasteboard/5387578-expected.png:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.checksum:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/input-field-1-expected.checksum:
- platform/mac/editing/pasteboard/input-field-1-expected.png:
- platform/mac/editing/pasteboard/input-field-1-expected.txt:
- platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
- platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
- platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
- platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
- platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
- platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
- platform/mac/editing/pasteboard/pasting-tabs-expected.checksum:
- platform/mac/editing/pasteboard/pasting-tabs-expected.png:
- platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
- platform/mac/editing/selection/3690703-2-expected.checksum:
- platform/mac/editing/selection/3690703-2-expected.png:
- platform/mac/editing/selection/3690703-2-expected.txt:
- platform/mac/editing/selection/3690703-expected.checksum:
- platform/mac/editing/selection/3690703-expected.png:
- platform/mac/editing/selection/3690703-expected.txt:
- platform/mac/editing/selection/3690719-expected.checksum:
- platform/mac/editing/selection/3690719-expected.png:
- platform/mac/editing/selection/3690719-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.checksum:
- platform/mac/editing/selection/4895428-3-expected.png:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.checksum:
- platform/mac/editing/selection/4975120-expected.png:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/5136696-expected.checksum:
- platform/mac/editing/selection/5136696-expected.png:
- platform/mac/editing/selection/5136696-expected.txt:
- platform/mac/editing/selection/5213963-expected.checksum:
- platform/mac/editing/selection/5213963-expected.png:
- platform/mac/editing/selection/5213963-expected.txt:
- platform/mac/editing/selection/caret-rtl-2-expected.checksum:
- platform/mac/editing/selection/caret-rtl-2-expected.png:
- platform/mac/editing/selection/drag-select-1-expected.checksum:
- platform/mac/editing/selection/drag-select-1-expected.png:
- platform/mac/editing/selection/drag-select-1-expected.txt:
- platform/mac/editing/selection/drag-text-delay-expected.checksum:
- platform/mac/editing/selection/drag-text-delay-expected.png:
- platform/mac/editing/selection/drag-text-delay-expected.txt:
- platform/mac/editing/selection/extend-by-word-002-expected.checksum:
- platform/mac/editing/selection/extend-by-word-002-expected.png:
- platform/mac/editing/selection/select-all-002-expected.checksum:
- platform/mac/editing/selection/select-all-002-expected.png:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/mac/editing/spelling/spellcheck-attribute-expected.checksum:
- platform/mac/editing/spelling/spellcheck-attribute-expected.png:
- platform/mac/editing/spelling/spellcheck-attribute-expected.txt:
- 1:31 PM Changeset in webkit [44735] by
-
- 2 edits in trunk/WebCore
2009-06-16 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
Fix a UMR in WebCore::BitStack by initializing new memory to 0.
https://bugs.webkit.org/show_bug.cgi?id=26449
No new tests, covered by purify.
- editing/TextIterator.cpp: (WebCore::BitStack::push):
- 1:27 PM Changeset in webkit [44734] by
-
- 2 edits in trunk/WebCore
009-06-16 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Xan Lopez.
Fixes https://bugs.webkit.org/show_bug.cgi?id=26453.
Null Cairo contextwill crash Windows Cairo build.
Test: fast/multicol/columns-shorthand-parsing.html
- 12:27 PM Changeset in webkit [44733] by
-
- 3 edits in trunk/WebCore
2009-06-16 Peter Kasting <pkasting@google.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26447
Fix animated GIF breakage in Cairo/wx ports.
- platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::operator=):
- platform/image-decoders/wx/ImageDecoderWx.cpp: (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::operator=):
- 12:26 PM Changeset in webkit [44732] by
-
- 4 edits in trunk/WebKitLibraries
2009-06-16 Simon Fraser <Simon Fraser>
Rubber-stamped by Anders Carlsson.
Update WebKitSystemInterface for <rdar://problem/6937882>.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 11:51 AM Changeset in webkit [44731] by
-
- 2 edits in trunk/LayoutTests
2009-06-16 Xan Lopez <xlopez@igalia.com>
Disable another new test.
- platform/gtk/Skipped:
- 11:36 AM Changeset in webkit [44730] by
-
- 2 edits in trunk/WebCore
2009-06-16 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by John Sullivan
<rdar://problem/6937882>
Tweak "time remaining" and "time elapsed" fields in the overlay video controller.
- css/mediaControlsQT.css:
- 11:36 AM Changeset in webkit [44729] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not use g_assert_cmpint to test for NULL pointer, just
g_assert.
- tests/testnetworkrequest.c: (test_network_request_create_destroy):
- 11:27 AM Changeset in webkit [44728] by
-
- 2 edits in trunk/LayoutTests
2009-06-16 Xan Lopez <xlopez@igalia.com>
editing/deleting/4875189.html was changed from pixel to
dumpAsText, so remove it from Skipped list.
- platform/gtk/Skipped:
- 11:19 AM Changeset in webkit [44727] by
-
- 2 edits in trunk/WebKitTools
2009-06-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Make the commit-log-editor match the ambient line endings in commit
messages.
- Scripts/commit-log-editor:
- 11:12 AM Changeset in webkit [44726] by
-
- 9 edits2 moves4 adds in trunk
WebCore:
2009-06-16 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth and David Levin.
Bug 26146: Change to use ThreadableLoader to load the worker script
in order to check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146
Test: http/tests/workers/worker-redirect.html
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
- workers/Worker.h:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
- workers/WorkerImportScriptsClient.cpp: Removed.
- workers/WorkerImportScriptsClient.h: Removed.
- workers/WorkerScriptLoader.cpp: Renamed from workers/WorkerImportScriptsClient.cpp. This to make it more generic so worker script loading could use it. (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::didFinishLoading): (WebCore::WorkerScriptLoader::didFail): (WebCore::WorkerScriptLoader::didFailRedirectCheck): (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation): (WebCore::WorkerScriptLoader::notifyFinished):
- workers/WorkerScriptLoader.h: Renamed from workers/WorkerImportScriptsClient.h. This to make it more generic so worker script loading could use it.
- workers/WorkerScriptLoaderClient.h: Added.
LayoutTests:
2009-06-16 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth and David Levin.
Bug 26146: Change to use ThreadableLoader to load the worker script
in order to check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146
Add a layout test to cover the scenario that the worker script is
loaded from different redirect origin.
- http/tests/workers/resources/worker-redirect-target.js: Added.
- http/tests/workers/worker-redirect-expected.txt: Added.
- http/tests/workers/worker-redirect.html: Added.
- 10:59 AM Changeset in webkit [44725] by
-
- 2 edits in trunk/LayoutTests
2009-06-16 Xan Lopez <xlopez@igalia.com>
Fix typo in test name.
- platform/gtk/Skipped:
- 10:48 AM Changeset in webkit [44724] by
-
- 2 edits in trunk/LayoutTests
2009-06-16 Xan Lopez <xlopez@igalia.com>
Disable new tests.
- platform/gtk/Skipped:
- 10:10 AM BuildingOnWindows edited by
- (diff)
- 10:10 AM BuildingOnWindows edited by
- (diff)
- 9:59 AM BuildingOnWindows edited by
- Add instructions for rebasing libphp4 on Vista (diff)
- 9:44 AM Changeset in webkit [44723] by
-
- 4 edits in trunk
009-06-16 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Darin Adler.
Use consistent GUID comparison functions.
https://bugs.webkit.org/show_bug.cgi?id=26427
- 7:09 AM Changeset in webkit [44722] by
-
- 2 edits in trunk/WebCore
2009-06-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix compiler warning.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_class_init):
- 7:09 AM Changeset in webkit [44721] by
-
- 2 edits in trunk/WebCore
2009-06-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Remove dummy AtkStreamableContent implementation.
It's completely empty, we'll add it back (and conditionally
instead of unconditionally) when it does something.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (GetAtkInterfaceTypeFromWAIType): (getInterfaceMaskFromObject):
- 6:32 AM Changeset in webkit [44720] by
-
- 2 edits in trunk/WebKitTools
2009-06-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update GtkLauncher to recent API changes in the progress property,
which now goes from 0.0 to 1.0.
- GtkLauncher/main.c:
- 1:40 AM Changeset in webkit [44719] by
-
- 4 edits in trunk/WebKit/qt
2009-06-16 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
Doc: Fixed QWebPage::forwardUnsupportedContent documentation and added
more information about Web plugins.
- 1:40 AM Changeset in webkit [44718] by
-
- 2 edits in trunk/WebKit/qt
2009-06-16 Morten Engvoldsen <morten.engvoldsen@nokia.com>
Reviewed by Ariya Hidayat.
Clearifying QWebFrame docs
Adding docs to toHtml() and toPlainText()
- 1:10 AM Changeset in webkit [44717] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Fix ChangeLog typo.
- 1:06 AM Changeset in webkit [44716] by
-
- 2 edits in trunk/WebKitTools
2009-06-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Alder.
Teach prepare-ChangeLog to match the line ends that are already present
in ChangeLog files. This helps folks whose use cygwin perl with CR LF
line endings on Windows.
Also, teach prepare-ChangeLog to normalize backslashes in paths. This
helps folks who use Windows SVN prepare correct ChangeLogs.
- Scripts/prepare-ChangeLog:
- 12:35 AM Changeset in webkit [44715] by
-
- 5 edits5 copies in trunk
Roll over some ChangeLog files.
- 12:35 AM Changeset in webkit [44714] by
-
- 1 edit1 add in trunk/WebKitTools
Add a script to automate the rolling over of ChangeLog files when they grow too large.
Reviewed by Oliver Hunt.
- Scripts/roll-over-ChangeLogs: Added.
Jun 15, 2009:
- 11:52 PM Changeset in webkit [44713] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Sam Weinig.
Rename PatchBuffer to LinkBuffer. Previously our terminology has been a little
mixed up, but we have decided to fix on refering to the process that takes place
at the end of code generation as 'linking', and on any modifications that take
place later (and once the code has potentially already been executed) as 'patching'.
However, the term 'PatchBuffer' is already in use, and needs to be repurposed.
To try to minimize confusion, we're going to switch the terminology over in stages,
so for now we'll refer to later modifications as 'repatching'. This means that the
new 'PatchBuffer' has been introduced with the name 'RepatchBuffer' instead.
This patch renames the old 'PatchBuffer' to 'LinkBuffer'. We'll leave ToT in this
state for a week or so to try to avoid to much overlap of the meaning of the term
'PatchBuffer', then will come back and rename 'RepatchBuffer'.
- assembler/ARMv7Assembler.h:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::LinkBuffer::LinkBuffer): (JSC::AbstractMacroAssembler::LinkBuffer::~LinkBuffer):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile):
- 11:17 PM Changeset in webkit [44712] by
-
- 7 edits in trunk
WebCore:
2009-06-15 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): When inserting a newline after the blockquote, we don't want to apply the original style after the insertion.
LayoutTests:
2009-06-15 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Updating test for:
<rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros
This test case covered inserting a newline after a blockquote, but outside of the blockquote. I added some
text insertion to verify that the newline doesn't get any old styles copied from the blockquote.
- editing/pasteboard/5368833.html:
- platform/mac/editing/pasteboard/5368833-expected.checksum:
- platform/mac/editing/pasteboard/5368833-expected.png:
- platform/mac/editing/pasteboard/5368833-expected.txt:
- 10:35 PM Changeset in webkit [44711] by
-
- 11 edits1 copy in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Having moved most of their functionality into the RepatchBuffer class,
we can simplify the CodeLocation* classes.
The CodeLocation* classes are currently a tangle of templatey and friendly
badness, burried in the middle of AbstractMacroAssembler. Having moved
the ability to repatch out into RepatchBufer they are now do-nothing wrappers
on CodePtr (MacroAssemblerCodePtr), that only exist to provide type-safety.
Simplify the code, and move them off into their own header.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::PatchBuffer::patch):
- assembler/CodeLocation.h: Copied from assembler/AbstractMacroAssembler.h. (JSC::CodeLocationCommon::CodeLocationCommon): (JSC::CodeLocationInstruction::CodeLocationInstruction): (JSC::CodeLocationLabel::CodeLocationLabel): (JSC::CodeLocationJump::CodeLocationJump): (JSC::CodeLocationCall::CodeLocationCall): (JSC::CodeLocationNearCall::CodeLocationNearCall): (JSC::CodeLocationDataLabel32::CodeLocationDataLabel32): (JSC::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr): (JSC::CodeLocationCommon::instructionAtOffset): (JSC::CodeLocationCommon::labelAtOffset): (JSC::CodeLocationCommon::jumpAtOffset): (JSC::CodeLocationCommon::callAtOffset): (JSC::CodeLocationCommon::nearCallAtOffset): (JSC::CodeLocationCommon::dataLabelPtrAtOffset): (JSC::CodeLocationCommon::dataLabel32AtOffset):
- assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::operator!):
- bytecode/CodeBlock.h: (JSC::getStructureStubInfoReturnLocation): (JSC::getCallLinkInfoReturnLocation): (JSC::getMethodCallLinkInfoReturnLocation):
- bytecode/Instruction.h:
- bytecode/JumpTable.h: (JSC::StringJumpTable::ctiForValue): (JSC::SimpleJumpTable::ctiForValue):
- bytecode/StructureStubInfo.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitCatch):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
- 10:03 PM Changeset in webkit [44710] by
-
- 2 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove outdated comment.
- bindings/js/JSDOMWindowBase.h:
- 9:58 PM Changeset in webkit [44709] by
-
- 6 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Bring CustomGetPropertyNames more inline with the other
extended attributes prefixed with Custom, by making it
require a complete implementation.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyNames):
- bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getPropertyNames):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getPropertyNames):
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getPropertyNames):
- bindings/scripts/CodeGeneratorJS.pm:
- 9:04 PM Changeset in webkit [44708] by
-
- 2 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove commented out ondataunavailable attribute event listener which
has now been removed from HTML 5.
- page/DOMWindow.idl:
- 9:02 PM Changeset in webkit [44707] by
-
- 6 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Move entire custom implementation of getOwnPropertySlot and put
for JSDOMWindow into JSDOMWindowCustom, eliminating the bit in
JSDOMWindowBase.
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter): (WebCore::childFrameGetter): (WebCore::indexGetter): (WebCore::namedItemGetter): (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::put): (WebCore::JSDOMWindow::getPropertyAttributes):
- bindings/js/JSDOMWindowCustom.h:
- page/DOMWindow.idl:
- 9:00 PM Changeset in webkit [44706] by
-
- 2 edits in trunk/WebCore
2009-06-15 Jeremy Orlow (jorlow@chromium.org)
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26356
Define the functions in V8CustomBindings.h. "Forgot" this in my
earlier patch since it wasn't fully upstreamed when I wrote the
patch.
- bindings/v8/custom/V8CustomBinding.h:
- 8:01 PM Changeset in webkit [44705] by
-
- 11 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Having introduced the RepatchBuffer, ProcessorReturnAddress is now a do-nothing
wrapper around ReturnAddressPtr. Remove it. In tugging on this piece of string
it made sense to roll out the use of ReturnAddressPtr a little further into
JITStubs (which had always been the intention).
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline):
- assembler/MacroAssemblerCodeRef.h: (JSC::ReturnAddressPtr::ReturnAddressPtr):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getStubInfo): (JSC::CodeBlock::getCallLinkInfo): (JSC::CodeBlock::getMethodCallLinkInfo): (JSC::CodeBlock::getBytecodeIndex):
- interpreter/Interpreter.cpp: (JSC::bytecodeOffsetForPC):
- jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress):
- jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compilePatchGetArrayLength):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::StackHack::StackHack): (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::): (JSC::JITStackFrame::returnAddressSlot):
- runtime/JSGlobalData.h:
- 7:13 PM Changeset in webkit [44704] by
-
- 2 edits in trunk/WebKit/qt
2009-06-15 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Adam Treat.
Support the back/forward/stop/refresh multimedia keys and accept the
event when handling backspace and shift backspace as we should.
- Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent):
- 6:36 PM Changeset in webkit [44703] by
-
- 2 edits in trunk/WebCore
2009-06-15 Andre Boule <aboule@apple.com>
Reviewed by Cameron Zwarich and Dan Bernstein.
- fix <rdar://problem/6967975> crash with NSString drawAtPoint
No test possible because this crash can only occur if the client uses
WebKit text drawing without ever using WebCore text, and DumpRenderTree
cannot do either.
- platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Null-check
gFontPlatformDataCache.
- 6:27 PM Changeset in webkit [44702] by
-
- 11 edits in trunk
2009-06-15 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
<rdar://problem/6974857>
Define ENABLE_3D_RENDERING and WTF_USE_ACCELERATED_COMPOSITING when building on 10.6.
Move the ENABLE_3D_RENDERING switch from config.h and WebKitPrefix.h to wtf/Platform.h
- 6:12 PM Changeset in webkit [44701] by
-
- 6 edits in trunk/WebCore
2009-06-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Make WebInspector's console evaluation/completion asynchronous.
This way of evaluation allows serializing calls between
InspectorController and its frontend.
- inspector/front-end/Console.js: (WebInspector.Console.prototype.completions): (WebInspector.Console.prototype._reportCompletions): (WebInspector.Console.prototype._evalInInspectedWindow): (WebInspector.Console.prototype._enterKeyPressed.printResult): (WebInspector.Console.prototype._enterKeyPressed):
- inspector/front-end/DatabaseQueryView.js:
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady):
- 5:26 PM Changeset in webkit [44700] by
-
- 4 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Move repatching methods into a set of methods on a class. This will allow us to
coallesce memory reprotection calls. Really, we want this class to be called
PatchBuffer, we want the class PatchBuffer to be called LinkBuffer, we want both
to be memblers of MacroAssembler rather then AbstractMacroAssembler, we don't
want the CodeLocationFoo types anymore (they are now only really there to provide
type safety, and that is completely undermined by the way we use offsets). Then
the link & patch buffers should delegate the actual patching calls to the
architecture-specific layer of the MacroAssembler. Landing all these changes as a
sequence of patches.
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::RepatchBuffer::RepatchBuffer): (JSC::AbstractMacroAssembler::RepatchBuffer::relink): (JSC::AbstractMacroAssembler::RepatchBuffer::repatch): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::repatchLoadPtrToLEA):
- jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- 4:19 PM Web Inspector edited by
- (diff)
- 4:19 PM Web Inspector edited by
- (diff)
- 4:16 PM Changeset in webkit [44699] by
-
- 2 edits in trunk/WebKit/mac
2009-06-15 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6967569>
CrashTracer: 15 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostManager::didCreateWindow + 85
Make sure to remove the entry from the plug-in host map so we won't end up with an entry that has a null value.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
- 4:10 PM Changeset in webkit [44698] by
-
- 2 edits in trunk/WebCore
2009-06-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
Reverted previous change as the old behavior was correct for heavy view.
- inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
- 3:39 PM Changeset in webkit [44697] by
-
- 2 edits in trunk/WebCore
2009-06-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/6968125> Profiler 'Call' count is incorrect in Heavy
view (26418)
- Removed code that copied call and time data from it's ancestor.
- inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
- 3:21 PM Changeset in webkit [44696] by
-
- 5 edits2 adds in trunk
Reviewed by Simon Fraser <Simon Fraser>.
Added logic to updateTransitions similar to that in updateKeyframeAnimations
which detects and removes stale transitions.
Test: transitions/cancel-transition.html
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation):
- page/animation/ImplicitAnimation.h: (WebCore::ImplicitAnimation::active): (WebCore::ImplicitAnimation::setActive):
- 2:18 PM Changeset in webkit [44695] by
-
- 11 edits in trunk
WebCore:
Reviewed by Tim Hatcher.
- allow the source code font in the Web Inspector to be customized
- css/view-source.css: Use the default monospace font family and size
for source code.
- inspector/front-end/inspector.css: Use the default monospace font
family and size for console I/O.
WebKit/mac:
Reviewed by Tim Hatcher.
- make the source code font in the Web Inspector match Mac defaults
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Set the default monospace font to 11px Menlo, except on Leopard and Tiger where it is 10px Monaco.
WebKit/win:
Reviewed by Tim Hatcher.
- use a nice source code font in the Web Inspector
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage): Set the default monospace font to
13px Courier New, which is the default source code font in Visual
Studio.
LayoutTests:
Reviewed by Tim Hatcher.
- updated results after changing source view to use the default monospace font family and size
- platform/mac/fast/frames/viewsource-attribute-expected.checksum:
- platform/mac/fast/frames/viewsource-attribute-expected.png:
- platform/mac/fast/frames/viewsource-attribute-expected.txt:
- 1:25 PM Changeset in webkit [44694] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=26377
[GTK] Confusion about range of 'progress' property
Range for the progress property is 0.0 .. 1.0, don't multiply it
by 100 to make it a percentage.
- webkit/webkitwebview.cpp: (webkit_web_view_get_progress):
- 1:17 PM Changeset in webkit [44693] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Hunt & Oliver Garen.
We are currently generating two copies of the slow path for op_call for no reason. Stop that.
Originally op_call used two slow paths since the first set up the pointer to the CallLinkInfo
for use when linking. However this is now looked up using the return address (as we do for
property accesses) so the two paths are now identical.
No performance impact, reduces memory footprint.
- bytecode/CodeBlock.h:
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::linkCall):
- jit/JIT.h:
- jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
- jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- 11:39 AM Changeset in webkit [44692] by
-
- 4 edits in trunk/WebKit/qt
2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Adam Treat
https://bugs.webkit.org/show_bug.cgi?id=26351
Remove bool QWebHitTestResult::isScrollBar() const and make sure a null QWebHitTestResult is returned instead.
- 11:39 AM Changeset in webkit [44691] by
-
- 1 edit16 adds in trunk/WebKitExamplePlugins
2009-06-15 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Add Core Animation movie plug-in example.
- NetscapeCoreAnimationMoviePlugin: Added.
- NetscapeCoreAnimationMoviePlugin/English.lproj: Added.
- NetscapeCoreAnimationMoviePlugin/English.lproj/InfoPlist.strings: Added.
- NetscapeCoreAnimationMoviePlugin/Info.plist: Added.
- NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.h: Added.
- NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.m: Added. (createImageNamed): (-[MovieControllerLayer init]): (-[MovieControllerLayer dealloc]): (-[MovieControllerLayer _playPauseButtonRect]): (-[MovieControllerLayer _sliderRect]): (-[MovieControllerLayer _sliderThumbRect]): (-[MovieControllerLayer _innerSliderRect]): (-[MovieControllerLayer _drawPlayPauseButtonInContext:]): (-[MovieControllerLayer _drawSliderInContext:]): (-[MovieControllerLayer drawInContext:]): (-[MovieControllerLayer _currentTime]): (-[MovieControllerLayer _duration]): (-[MovieControllerLayer _isPlaying]): (-[MovieControllerLayer _updateTime:]): (-[MovieControllerLayer _rateDidChange:]): (-[MovieControllerLayer _timeDidChange:]): (-[MovieControllerLayer actionForKey:]): (-[MovieControllerLayer setMovie:]): (-[MovieControllerLayer _setNewTimeForThumbCenterX:]): (-[MovieControllerLayer handleMouseDown:]): (-[MovieControllerLayer handleMouseUp:]): (-[MovieControllerLayer handleMouseDragged:]):
- NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Added.
- NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj: Added.
- NetscapeCoreAnimationMoviePlugin/Pause.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/Play.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/SliderTrackCenter.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/SliderTrackLeft.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/SliderTrackRight.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/Thumb.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/main.m: Added. (NP_Initialize): (NP_GetEntryPoints): (NP_Shutdown): (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream): (NPP_WriteReady): (NPP_Write): (NPP_StreamAsFile): (NPP_Print): (handleMouseDown): (togglePlayPause): (handleMouseUp): (handleMouseDragged): (handleMouseEntered): (handleMouseExited): (handleKeyDown): (handleScrollEvent): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
- NetscapeCoreAnimationMoviePlugin/test.html: Added.
- 11:14 AM Changeset in webkit [44690] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.10
Tagging 1.1.10.
- 8:40 AM Changeset in webkit [44689] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Add new symbols list for 1.1.10 release.
- docs/webkitgtk-docs.sgml:
- 8:39 AM Changeset in webkit [44688] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Fix Since tags for the new uri and message properties.
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
- 8:38 AM Changeset in webkit [44687] by
-
- 2 edits in trunk/WebCore
2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by and done with Tor Arne Vestbø.
Fix initialization of uninitialized members in FontFallbackListQt, leading
to random crashes when rendering text.
- 8:30 AM Changeset in webkit [44686] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Adding new documented API to the generated
documentation.
- docs/webkitgtk-sections.txt:
- 7:38 AM Changeset in webkit [44685] by
-
- 2 edits in trunk/WebKit/qt
2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Adam Treat.
Fix the logic for disabling the fixed layout feature, when an invalid
QSize is set.
- 7:31 AM Changeset in webkit [44684] by
-
- 4 edits in trunk
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Version bump in preparation for 1.1.10 release.
- configure.ac:
WebKit/gtk:
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update NEWS for 1.1.10 release.
- NEWS:
- 7:17 AM Changeset in webkit [44683] by
-
- 2 edits in trunk/WebCore
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25895
[Gtk] Segfault when deleting the last/only character in an entry if a11y is enabled
Use computeOffsetInContainerNode instead of the inline
offsetInContainerNode to return the caret offset, since the former
can handle all types of anchoring. Otherwise we'll hit an ASSERT
in some situations in debug builds, and crash.
- editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- 4:53 AM Changeset in webkit [44682] by
-
- 12 edits2 moves in trunk/WebCore
2009-06-15 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix build break
Rename JSONObject to InspectorJSONObject
- 1:39 AM Changeset in webkit [44681] by
-
- 7 edits in trunk
2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Mark Rowe.
Reviewed by Simon Hausmann.
Reviewed by Xan Lopez.
Refactor handling of options in the build-webkit script
Options are now defined in one place, and then reused when creating
the usage help text, the arguments to GetOptions(), and when passing
the options on to the underlying port-dependent build systems.
This allows the Qt port to read the defaults for the options from the
pro file (dynamically), and to pass the options on to qmake at build.
- 12:37 AM Changeset in webkit [44680] by
-
- 2 edits in trunk/WebKitTools
Fix <https://bugs.webkit.org/show_bug.cgi?id=26312>.
Bug 26312: Multiple copies of Safari opened with WebKit nightly and Safari 3.2.3
Reviewed by Cameron Zwarich.
Skip the trampoline detection for versions of Safari < 4.0 as they don't play these
tricks, and having WebKitNightlyEnabler assume that we were in the trampoline was
preventing our LaunchServices trickery from being run. This led to fresh copies of
WebKit.app being launched when a URL or file was opened from an external application
rather than the existing instance being reused.
- WebKitLauncher/WebKitNightlyEnabler.m:
(insideSafari4OnTigerTrampoline):
(enableWebKitNightlyBehaviour):
- 12:02 AM Changeset in webkit [44679] by
-
- 1 edit in trunk/WebCore/platform/graphics/qt/FontFallbackListQt.cpp
Fix Qt build break after r44672
Jun 14, 2009:
- 11:11 PM Changeset in webkit [44678] by
-
- 4 edits5 adds in trunk/WebCore
Bug 26399: REGRESSION: java applet accessibility broken
https://bugs.webkit.org/show_bug.cgi?id=26399
- 9:46 PM Changeset in webkit [44677] by
-
- 20 edits in trunk/WebCore
2009-06-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Rename the CustomGetOwnPropertySlot and CustomPutFunction extended attributes
to DelegatingGetOwnPropertySlot and DelegatingPutFunction to more clearly describe
their functionality (customGetOwnPropertySlot and customPut member functions have
been renamed getOwnPropertySlotDelegate and putDelegate). CustomGetOwnPropertySlot
and CustomPutFunction have been repurposed to mean a complete custom implementation
of the function which is inline with other extended attributes prefixed with Custom.
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::putDelegate):
- bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::getOwnPropertySlotDelegate): (WebCore::JSDOMWindow::putDelegate):
- bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLAppletElement::putDelegate):
- bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLEmbedElement::putDelegate):
- bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLObjectElement::putDelegate):
- bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getOwnPropertySlotDelegate): (WebCore::JSHistory::putDelegate):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getOwnPropertySlotDelegate): (WebCore::JSLocation::putDelegate): (WebCore::JSLocationPrototype::putDelegate):
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::putDelegate):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
- bindings/scripts/CodeGeneratorJS.pm:
- css/CSSStyleDeclaration.idl:
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLObjectElement.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- storage/Storage.idl:
- workers/WorkerContext.idl:
- 9:36 PM Changeset in webkit [44676] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=26395 <rdar://problem/6971333> REGRESSION (r40813-r40884): No caret after going back/forward to page with focused text field
No test, since the back/forward cache is disabled in DumpRenderTree
- loader/FrameLoader.cpp: (WebCore::FrameLoader::open): Added a call to CachedPage::restore(), which was removed in r40870.
- 8:07 PM Changeset in webkit [44675] by
-
- 2 edits in trunk/WebCore
2009-06-14 Darin Adler <Darin Adler>
- editing/TextIterator.cpp: (WebCore::BitStack::push): Use named constant instead of hardcoded numbers. (WebCore::BitStack::top): Ditto.
- 7:39 PM Changeset in webkit [44674] by
-
- 9 edits2 adds in trunk
WebCore:
2009-06-14 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>
Test: fast/text/find-hidden-text.html
- editing/TextIterator.cpp: (WebCore::BitStack::BitStack): Added. (WebCore::BitStack::push): Added. (WebCore::BitStack::pop): Added. (WebCore::BitStack::top): Added. (WebCore::BitStack::size): Added. (WebCore::parentOrShadowParent): Added. Helper function for walking up the parent node chain, crossing shadow tree boundaries. (WebCore::depthCrossingShadowBoundaries): Added for use in assertions. Counts the depth of a node using the parentOrShadowParent function. (WebCore::fullyClipsContents): Added. Returns true for an element that fully clips its contents, currently defined as a box that has zero width or height and hides overflow. We can add other cases here later. (WebCore::ignoresContainerClip): Added. Returns true for an element that ignores its container clip, currently defined as an element with absolute or fixed positioning. (WebCore::pushFullyClippedState): Added. Pushes a bit on the stack indicating if the node in question fully clips its contents. (WebCore::setUpFullyClippedStack): Added. Pushes a bit for each ancestor of a node. Used when creating an iterator. (WebCore::TextIterator::TextIterator): Removed code to initialize m_inShadowContent. Call setUpFullyClippedStack. (WebCore::TextIterator::advance): Use parentOrShadowParent. Call pop when moving up to a parent node, and also one extra time when moving to a sibling node. Call pushFullyClippedState when moving to a child node, or when moving to a sibling node after the aforementioned call to pop. (WebCore::TextIterator::handleTextNode): Return early if the node is fully clipped. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Call setUpFullyClippedStack. (WebCore::SimplifiedBackwardsTextIterator::advance): Same changes as TextIterator::advance above.
- editing/TextIterator.h: Added BitStack class and added m_fullyClippedStack to both TextIterator and SimplifiedBackwardsTextIterator. Removed unneeded m_inShadowContent.
LayoutTests:
2009-06-14 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>
- fast/text/find-hidden-text-expected.txt: Added.
- fast/text/find-hidden-text.html: Added.
- fast/block/float/crash-replaced-display-block-expected.txt: Removed a space.
- fast/dom/Range/acid3-surround-contents-expected.txt: Removed a blank line.
- fast/dom/object-embed-plugin-scripting-expected.txt: Removed four spaces.
- fast/parser/badentity-expected.txt: Removed a blank line.
- http/tests/security/local-video-poster-from-remote-expected.txt: Removed a blank line.
- 4:52 PM Changeset in webkit [44673] by
-
- 3 edits in trunk/WebCore
2009-06-14 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Back out Simon's fix and replace it with a better one that doesn't needlessly destroy RenderObjects.
Use NoInherit rather than Detach for child index changes, and don't worry about other pseudo-class state
changes, since they were handled already with setNeedsStyleRecalcs on the affected objects themselves.
- dom/Element.cpp: (WebCore::Element::recalcStyle):
- dom/Node.cpp: (WebCore::Node::diff):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setChildIndex):
- 2:57 PM Changeset in webkit [44672] by
-
- 7 edits in trunk/WebCore
2009-06-14 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Move all of the mutable member variables from Font into the refcounted FontFallbackList. This makes
copying of Fonts more efficient and also effectively makes all of the mutations of a Font object happen
inside the FontFallbackList.
- WebCore.base.exp:
- platform/graphics/Font.cpp: (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::primaryFont): (WebCore::Font::update):
- platform/graphics/Font.h: (WebCore::Font::setWordSpacing): (WebCore::Font::setLetterSpacing):
- platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::determinePitch):
- platform/graphics/FontFallbackList.h: (WebCore::FontFallbackList::primarySimpleFontData): (WebCore::FontFallbackList::primaryFontData):
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
- 2:27 PM Changeset in webkit [44671] by
-
- 6 edits4 adds in trunk
2009-06-14 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix an issue noted on quirksmode.com where dynamically adding siblings does not
update :nth-child style correctly.
Test: fast/css/nth-child-dynamic.html
- dom/Node.h: Change diff() to take const RenderStyle*
- dom/Node.cpp: (WebCore::Node::diff): When comparing styles to decide whether to detach and reattach, we need to look at whether the pseudoclass-related data in the style changed (since RenderStyle::diff doesn't check this).
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getCachedPseudoStyle): (WebCore::RenderStyle::inheritedNotEqual): Make these methods const.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::styleType): (WebCore::InheritedFlags::pseudoClassStateEquivalent): Make methods const. Add new method that compares the pseudoclass-related members.
- 12:03 AM Changeset in webkit [44670] by
-
- 7 edits2 adds in trunk/SunSpider
Update V8 benchmark to version 4.
Reviewed by Cameron Zwarich.
- tests/LIST-V8:
- tests/v8-crypto.js:
- tests/v8-deltablue.js:
- tests/v8-earley-boyer.js:
- tests/v8-raytrace.js:
- tests/v8-regexp.js: Added.
- tests/v8-richards.js:
- tests/v8-splay.js: Added.
Jun 13, 2009:
- 11:44 PM Changeset in webkit [44669] by
-
- 5 edits2 adds in trunk/WebCore
2009-06-13 Peter Kasting <pkasting@google.com>
Reviewed by Kevin Ollivier.
https://bugs.webkit.org/show_bug.cgi?id=25709 part eleven
Write a wx implementation so the wx port can compile. For now this is
mostly a copy of the Cairo port, but in the future it can be changed to
use a wxBitmap as the storage type everywhere (just as Cairo can
probably be changed).
Also ASSERT for any other ports who call getAddr() (I don't think there
are any, and besides, they probably won't link, but this doesn't hurt).
Also fixes a dumb Cairo build bustage typo introduced in part ten.
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::createFrameAtIndex):
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::setStatus):
- platform/image-decoders/wx: Added.
- platform/image-decoders/wx/ImageDecoderWx.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height):
- webcore-wx.bkl:
- 10:06 PM Changeset in webkit [44668] by
-
- 2 edits in trunk/WebKit/mac
2009-06-09 Justin Garcia <justin.garcia@apple.com>
Reviewed by Eric Seidel. Landed by Adam Barth.
REGRESSION: Copying from TextEdit/OmniGraffle and pasting into editable
region loses images
Prefer RTFD (RTF with inline images) over RTF. In
http://trac.webkit.org/changeset/19745 I accidently reversed their
order.
- WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
- 9:53 PM Changeset in webkit [44667] by
-
- 5 edits in trunk/WebCore
2009-06-13 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov. Landed by Adam Barth.
Some minor code cleanup for chromium/skia port. Removed #ifdef's
around skia API changes, since the new version seems solid and we
don't need to go back. Added some comments to
TransparencyWin.h, as requested by Brett in
https://bugs.webkit.org/show_bug.cgi?id=24584.
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/TransparencyWin.h:
- platform/graphics/skia/PathSkia.cpp: (WebCore::Path::boundingRect): (WebCore::boundingBoxForCurrentStroke):
- platform/graphics/skia/SkiaUtils.cpp: (WebCore::SkPathContainsPoint):
- 9:29 PM Changeset in webkit [44666] by
-
- 1 edit in trunk/WebCore/page/SecurityOrigin.cpp
Build fix: Another missing header. Arg.
- 9:24 PM Changeset in webkit [44665] by
-
- 1 edit in trunk/WebCore/page/SecurityOrigin.cpp
Build fix: add missing header.
- 9:14 PM Changeset in webkit [44664] by
-
- 12 edits in trunk
WebCore:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from
FrameLoader to SecurityOrigin.
- WebCore.base.exp:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest): (WebCore::FrameLoader::canLoad):
- loader/FrameLoader.h:
- page/SecurityOrigin.cpp: (WebCore::localSchemes): (WebCore::noAccessSchemes): (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::isLocal): (WebCore::SecurityOrigin::registerURLSchemeAsLocal): (WebCore::SecurityOrigin::shouldTreatURLAsLocal): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsLocal): (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
- page/SecurityOrigin.h:
WebKit/mac:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin
- WebView/WebView.mm: (+[WebView registerURLSchemeAsLocal:]):
WebKit/qt:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.
- Api/qwebpage.cpp: (QWebPage::acceptNavigationRequest):
WebKit/win:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.
- WebView.cpp: (WebView::registerURLSchemeAsLocal):
- 8:47 PM Changeset in webkit [44663] by
-
- 3 edits in trunk/WebCore
2009-06-13 Ben Murdoch <benm@google.com>
Reviewed by David Kilzer. Landed by Adam Barth.
This patch changes the way PageGroups create their localStorage
objects. Rather than creating a local storage object for the page group
when a page is added to the group, the local storage object is now
created lazily when the local storage object is requested by the
DOMWindow.
- page/PageGroup.cpp: (WebCore::PageGroup::closeLocalStorage): Before attempting to close a local storage object for a page group, ensure one has been created. (WebCore::PageGroup::addPage): Do not automatically try to create a local storage object when a page is added to the group. (WebCore::PageGroup::localStorage): Create a local storage object if one does not exist and return it.
- page/PageGroup.h: Add private hasLocalStorage method to PageGroup.
- 8:44 PM Changeset in webkit [44662] by
-
- 23 edits in trunk/WebCore
2009-06-13 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel. Landed by Adam Barth.
Add ENABLE(DOM_STORAGE) guards to the dom storage source files.
- storage/LocalStorage.cpp: Add ENABLE(DOM_STORAGE) guards to the file.
- storage/LocalStorage.h: Ditto
- storage/LocalStorageArea.cpp: Ditto
- storage/LocalStorageArea.h: Ditto
- storage/LocalStorageTask.cpp: Ditto
- storage/LocalStorageTask.h: Ditto
- storage/LocalStorageThread.cpp: Ditto
- storage/LocalStorageThread.h: Ditto
- storage/SessionStorage.cpp: Ditto
- storage/SessionStorage.h: Ditto
- storage/SessionStorageArea.cpp: Ditto
- storage/SessionStorageArea.h: Ditto
- storage/Storage.cpp: Ditto
- storage/Storage.h: Ditto
- storage/StorageArea.cpp: Ditto
- storage/StorageArea.h: Ditto
- storage/StorageEvent.cpp: Ditto
- storage/StorageEvent.h: Ditto
- storage/StorageMap.cpp: Ditto
- storage/StorageMap.h: Ditto
- storage/StorageEvent.idl: Add Conditional=DOM_STORAGE attribute.
- storage/Storage.idl: Ditto
- 6:00 PM Changeset in webkit [44661] by
-
- 3 edits1 add1 delete in trunk/WebCore
2009-06-13 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part ten
Make Skia use the root directory ImageDecoder.h and factor out most
Skia-specific bits into skia/ImageDecoderSkia.cpp. Also fix a pair of
style violations in ImageDecoderCairo.cpp. This is the last patch for
this bug, everything beyond this is an enhancement rather than
unforking.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::setStatus):
- platform/image-decoders/skia/ImageDecoder.h: Removed.
- platform/image-decoders/skia/ImageDecoderSkia.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height):
- 4:11 PM Changeset in webkit [44660] by
-
- 2 edits in trunk/WebKitTools
2009-06-13 Sam Weinig <sam@webkit.org>
Rubber-stamped by Mark "Snowy" Rowe.
Update iExploder/htdocs/cssproperties.in by running update-iexploder-cssproperties.
- iExploder/htdocs/cssproperties.in:
- 2:35 PM Changeset in webkit [44659] by
-
- 2 edits2 adds in trunk/WebCore
2009-06-13 Victor Wang <victorw@chromium.org>
Reviewed by Eric Seidel. Landed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=26333
Alert during a dragenter event handler will crash the renderer
This crash is casued by calling NULL pointer m_documentUnderMouse in
DragController::tryDocumentDrag()
tryDHTMLDrag fires dragenter event. The event listener that listens
to this event may create a nested message loop (open a modal dialog),
which could process dragleave event and reset m_documentUnderMouse in
dragExited.
Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
do not continue if the pointer has been set to NULL.
Test: DRT does not show alerts so add a manual test:
manual-tests/drag-enter-alert.html
- manual-tests/drag-enter-alert.html: Added.
- manual-tests/resources/drag-image.png: Added.
- page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
- 2:27 PM Changeset in webkit [44658] by
-
- 2 edits2 adds in trunk/WebCore
2009-06-13 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov. Landed by Adam Barth.
Moved V8 Bindings for V8CustomXPathNSResolver to svn.webkit.org.
- bindings/v8/custom/V8CustomXPathNSResolver.cpp: Added. (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): Moved from src.chromium.org. (WebCore::V8CustomXPathNSResolver::~V8CustomXPathNSResolver): Moved from src.chromium.org. (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI): Moved from src.chromium.org.
- bindings/v8/custom/V8CustomXPathNSResolver.h: Added.
- bindings/v8/custom/V8DocumentCustom.cpp: Updated includes. (WebCore::CALLBACK_FUNC_DECL): Updated class name.
- 2:23 PM Changeset in webkit [44657] by
-
- 1 edit1 delete in trunk/WebKitTools
2009-06-13 John Abd-El-Malek <jam@chromium.org>
Reviewed by Eric Seidel. Landed by Adam Barth.
Removed dead file.
https://bugs.webkit.org/show_bug.cgi?id=26308
- DumpRenderTree/win/TestNetscapePlugin/main.c: Removed.
- 2:19 PM Changeset in webkit [44656] by
-
- 6 edits in trunk/WebCore
2009-06-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Mark Rowe. Landed by Adam Barth.
Remove obsolete declarations for old Symbian port
https://bugs.webkit.org/show_bug.cgi?id=26339
- platform/graphics/FloatPoint.h: Remove declarations for native SYMBIAN adaptation.
- platform/graphics/FloatRect.h: Ditto.
- platform/graphics/IntPoint.h: Ditto.
- platform/graphics/IntRect.h: Ditto.
- platform/graphics/IntSize.h: Ditto.
- 12:54 PM Changeset in webkit [44655] by
-
- 33 edits10 adds in trunk
2009-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
Added subRegion calculation to SVG filter. Every filter effect is
clipped to the filter region (according to the spec). This makes
ImageBuffers for filter effects smaller and we just need to take
care about big filter regions.
SVGFEImage needed a correction, to avoid an ASSERT. The two filter
effects feOffset and feFlood help to test the new subRegion code.
Tests: svg/filters/subRegion-one-effect.svg
svg/filters/subRegion-two-effects.svg
Added tests for the new subRgion-code on SVG filters.
- platform/mac/svg/filters: Added.
- platform/mac/svg/filters/subRegion-one-effect-expected.checksum: Added.
- platform/mac/svg/filters/subRegion-one-effect-expected.png: Added.
- platform/mac/svg/filters/subRegion-one-effect-expected.txt: Added.
- platform/mac/svg/filters/subRegion-two-effects-expected.checksum: Added.
- platform/mac/svg/filters/subRegion-two-effects-expected.png: Added.
- platform/mac/svg/filters/subRegion-two-effects-expected.txt: Added.
- svg/filters: Added.
- svg/filters/subRegion-one-effect.svg: Added.
- svg/filters/subRegion-two-effects.svg: Added.
- 12:36 PM Changeset in webkit [44654] by
-
- 3 edits in trunk/WebCore
2009-06-13 Peter Kasting <pkasting@google.com>
Bustage: Fix broken GIFs on Cairo due to subtle typo. Fix a warning.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes):
- platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::processBitmasks):
- 12:10 PM Changeset in webkit [44653] by
-
- 3 edits in trunk/WebCore
2009-06-13 Peter Kasting <pkasting@google.com>
GTK bustage fix. "inline" is handled differently by different compilers.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
- 11:55 AM Changeset in webkit [44652] by
-
- 4 edits2 adds in trunk/WebCore
2009-06-13 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part nine
Factor Cairo-specific implementation out of ImageDecoder.h into
ImageDecoderCairo.cpp. Add some comments to functions declared
in ImageDecoder.h.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- platform/image-decoders/ImageDecoder.h:
- platform/image-decoders/cairo: Added.
- platform/image-decoders/cairo/ImageDecoderCairo.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
- 10:52 AM Changeset in webkit [44651] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-12 Dave Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Add a new class to Threading in wtf called ReadWriteLock that handles single writer/multiple reader locking.
Provide a pthreads-only implementation of the lock for now, as this class is only going to be used
on Snow Leopard at first.
- wtf/Threading.h: (WTF::ReadWriteLock::impl):
- wtf/ThreadingPthreads.cpp: (WTF::ReadWriteLock::ReadWriteLock): (WTF::ReadWriteLock::~ReadWriteLock): (WTF::ReadWriteLock::readLock): (WTF::ReadWriteLock::tryReadLock): (WTF::ReadWriteLock::writeLock): (WTF::ReadWriteLock::tryWriteLock): (WTF::ReadWriteLock::unlock):
- 10:20 AM Changeset in webkit [44650] by
-
- 4 edits in trunk/WebCore
2009-06-13 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Cleanup of the new MidpointState class. Turn it into a struct instead. Fix a mistaken
assertion removal and some unintentional whitespace changes.
- platform/text/BidiResolver.h: (WebCore::MidpointState::reset):
- rendering/RenderBlock.h:
- rendering/bidi.cpp: (WebCore::BidiRun::operator delete): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::RenderBlock::findNextLineBreak):
Jun 12, 2009:
- 11:04 PM Changeset in webkit [44649] by
-
- 4 edits in trunk/WebCore
2009-06-12 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Remove the global variables in bidi.cpp. Make a new struct, MidpointState, that holds all of the
midpoint information. Add the remaining global variables as arguments passed down through functions
as needed.
- platform/text/BidiResolver.h: (WebCore::MidpointState::MidpointState): (WebCore::MidpointState::reset): (WebCore::BidiResolver::midpointState):
- rendering/RenderBlock.h:
- rendering/bidi.cpp: (WebCore::BidiRun::operator delete): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::skipNonBreakingSpace): (WebCore::shouldCollapseWhiteSpace): (WebCore::requiresLineBox): (WebCore::RenderBlock::generatesLineBoxesForInlineChild): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject): (WebCore::RenderBlock::findNextLineBreak):
- 10:03 PM Changeset in webkit [44648] by
-
- 2 edits in trunk/WebCore
Build fix for Qt. After recent ImageDeocder.h changes.
I want the original change to be backed out as the whole
Skia merging is going in the wrong direction. The discussion
will happen in the bugtracker.
- 9:15 PM WebDevelopers edited by
- (diff)
- 7:41 PM Changeset in webkit [44647] by
-
- 4 edits in trunk
2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] Enable more http/tests/navigation tests
- platform/gtk/Skipped:
[Gtk] use strlen instead of g_utf8_strlen so we can enable more tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpHistoryItem):
- 7:31 PM Changeset in webkit [44646] by
-
- 2 edits in trunk/WebCore
2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix: include cstdio so we can use sscanf
Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
Suggested by Brent Fulgham
- platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::decodeDatum):
- 6:23 PM Changeset in webkit [44645] by
-
- 2 edits in trunk/WebCore
2009-06-12 Peter Kasting <pkasting@google.com>
Yet another Skia bustage fix.
- platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::setSize): Avoid symbol name clash. The better fix is to take an IntSize(); I'll do that later.
- 6:18 PM Changeset in webkit [44644] by
-
- 4 edits in trunk/JavaScriptCore
Make LiteralParser non-recursive
Reviewed by Geoff Garen.
Convert LiteralParser from using a simple recursive descent parser
to a hand rolled PDA. Relatively simple conversion, but required
modifications to MarkedArgumentBuffer to make it more suitable as
a generic marked vector. I'll refactor and rename MarkedArgumentBuffer
in future as there are many other cases where it will be useful to
have such a class.
- 5:56 PM Changeset in webkit [44643] by
-
- 3 edits in trunk/WebCore
2009-06-12 Peter Kasting <pkasting@google.com>
Fix remaining Cairo build bustage from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes. Use
Vector<char> in place of std::string.
- platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::setData): (WebCore::XBMImageDecoder::decodeHeader): (WebCore::XBMImageDecoder::decodeDatum):
- platform/image-decoders/xbm/XBMImageDecoder.h:
- 5:47 PM Changeset in webkit [44642] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-12 David Levin <levin@chromium.org>
Reviewed by NOBODY (build fix for windows).
Adjust the exports for JSC on Windows like what was done for OSX in
the previous commit.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 5:41 PM Changeset in webkit [44641] by
-
- 6 edits in trunk
2009-06-12 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26360
The methods changed are not used by JSC, so there is no JS perf impact. However,
there is a potential DOM perf impact, so I re-ran several of the tests that
I ran previously and ensured that the perf stay the same which caused me to
adjust the minLengthToShare.
- JavaScriptCore.exp:
- runtime/UString.cpp: (JSC::UString::Rep::sharedBuffer):
Determines if the buffer being shared is big enough before doing so.
Previously, BaseString::sharedBuffer was called but it would only know
the length of the base string (BaseString::len) which may not be the same
as the string being shared (Rep::len).
(JSC::UString::BaseString::sharedBuffer):
This is now only be used by Rep::sharedBuffer. which does the length check.
- runtime/UString.h:
WebCore:
2009-06-12 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26347
Change the call to use the method UString::Rep::sharedBuffer due
to changes in UString.
No noticable change in behavior, so no test.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::create):
- 5:11 PM Changeset in webkit [44640] by
-
- 3 edits2 adds in trunk
2009-06-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Fix crash when a renderer for an anonymous node is composited
by null-checking renderer()->node().
Test: compositing/generated-content.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::rendererHasBackground): (WebCore::RenderLayerBacking::rendererBackgroundColor): (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): (WebCore::RenderLayerBacking::paintIntoLayer):
- 5:04 PM Changeset in webkit [44639] by
-
- 3 edits in trunk/WebCore
2009-06-12 Peter Kasting <pkasting@google.com>
Fix Chromium and some of Cairo build bustage, fallout from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes.
- WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
- platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.
- 4:39 PM Changeset in webkit [44638] by
-
- 4 edits1 copy4 moves3 adds in trunk/WebKitSite
2009-06-12 Brady Eidson <beidson@apple.com>
Reviewed by Oliver Hunt
Add a page indexing the various demo applications we have posted.
- demos/index.html: Added.
- nav.inc: Add a link to the demos page on the side bar
- css/main.css: Add a style for date stamps based on the blog.
- demos/calendar/index.html: Added to redirect to Calendar.html. I'm not moving Calendar.html to index.html as the Calendar.html url has already been published and we should keep it working.
Move the drosera test code to /misc, as it is no longer a meaningful demo:
- demos/drosera: Removed.
- demos/drosera/demo.js: Removed.
- demos/drosera/drosera.png: Removed.
- demos/drosera/index.html: Removed.
- misc/drosera: Copied from demos/drosera.
Move the sticky notes example into /demos:
- demos/sticky-notes: Added.
- demos/sticky-notes/StickyNotes.manifest: Copied from misc/DatabaseExample.manifest.
- demos/sticky-notes/deleteButton.png: Copied from misc/deleteButton.png.
- demos/sticky-notes/deleteButtonPressed.png: Copied from misc/deleteButtonPressed.png.
- demos/sticky-notes/index.html: Copied from misc/DatabaseExample.html.
- misc/DatabaseExample.html: Changed to redirect to demos/sticky-notes/index.html. I'm not removing it altogether as the misc/DatabaseExample.html url has already been published and we should keep it working.
- misc/DatabaseExample.manifest: Removed.
- misc/deleteButton.png: Removed.
- misc/deleteButtonPressed.png: Removed.
- 4:38 PM Changeset in webkit [44637] by
-
- 3 edits in trunk/WebCore
2009-06-12 Simon Fraser <Simon Fraser>
Fix build when ACCELERATED_COMPOSITING is defined.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::attachRootGraphicsLayer): (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization): (WebCore::EmptyChromeClient::scheduleViewUpdate): Add stubs for the compositing-related ChromeClient methods.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which matches what is used to size the WebHTMLView.
- 4:20 PM Changeset in webkit [44636] by
-
- 1 edit1 add in trunk/WebCore
2009-06-12 jorlow <jorlow@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26356
http://crbug.com/14006
Create custom bindings for v8. The rest of these files are still
forked (so the review is happening on the chromium review site).
These bindings have been tested on a hacked up Chromium instance
(also running --single-process) and Android.
- bindings/v8/custom/V8StorageCustom.cpp: Added.
- 4:20 PM Changeset in webkit [44635] by
-
- 3 edits in trunk/WebCore
2009-06-12 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26359
[v8] Add XMLHttpRequest to WorkerContextExecutionProxy.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same.
- bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment.
- 3:55 PM Changeset in webkit [44634] by
-
- 7 edits8 moves8 deletes in trunk/WebCore
2009-06-12 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part eight
Replace placeholder Cairo BMP, ICO, XBM decoders with real ones. Remove
all the decoders from skia/ since they are now just mirrors of the Cairo
ones.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon. Enable XBM decoding on Windows.
- platform/graphics/skia/ImageSourceSkia.cpp:
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.cpp.
- platform/image-decoders/bmp/BMPImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.h.
- platform/image-decoders/bmp/BMPImageReader.cpp: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.cpp.
- platform/image-decoders/bmp/BMPImageReader.h: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.h.
- platform/image-decoders/ico/ICOImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.cpp.
- platform/image-decoders/ico/ICOImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.h.
- platform/image-decoders/skia/BMPImageDecoder.cpp: Removed.
- platform/image-decoders/skia/BMPImageDecoder.h: Removed.
- platform/image-decoders/skia/BMPImageReader.cpp: Removed.
- platform/image-decoders/skia/BMPImageReader.h: Removed.
- platform/image-decoders/skia/GIFImageDecoder.cpp: Removed.
- platform/image-decoders/skia/GIFImageDecoder.h: Removed.
- platform/image-decoders/skia/GIFImageReader.cpp: Removed.
- platform/image-decoders/skia/GIFImageReader.h: Removed.
- platform/image-decoders/skia/ICOImageDecoder.cpp: Removed.
- platform/image-decoders/skia/ICOImageDecoder.h: Removed.
- platform/image-decoders/skia/JPEGImageDecoder.cpp: Removed.
- platform/image-decoders/skia/JPEGImageDecoder.h: Removed.
- platform/image-decoders/skia/PNGImageDecoder.cpp: Removed.
- platform/image-decoders/skia/PNGImageDecoder.h: Removed.
- platform/image-decoders/skia/XBMImageDecoder.cpp: Removed.
- platform/image-decoders/skia/XBMImageDecoder.h: Removed.
- platform/image-decoders/xbm/XBMImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.cpp.
- platform/image-decoders/xbm/XBMImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.h.
- 3:41 PM Changeset in webkit [44633] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26191
Remove xmath include in MathExtras.h, because it is not needed and also
breaks VS2008 builds with TR1 turned on.
- wtf/MathExtras.h: Removed xmath include.
- 3:24 PM Changeset in webkit [44632] by
-
- 4 edits in trunk
2009-06-12 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25599
[GTK] Enable more tests
Implement dumping of status callback.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewStatusBarTextChanged): (main):
- 3:17 PM Web Inspector edited by
- Changes to be more current. (diff)
- 3:06 PM Changeset in webkit [44631] by
-
- 8 edits in trunk/WebCore
2009-06-11 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
Update Skia's ImageDecoder.h with a few changes designed to reduce the
delta between specific implementations of ImageDecoder.h. Update
Cairo's ImageDecoder.h to sync up with the API changes in the Skia
version in the last two chage sets. Update Cairo's PNG/JPEG/GIF
decoders to use the APIs as well. All the Cairo image decoder changes
are direct copies of the Skia versions except ImageDecoder.h, which is
modified in the necessary ways for the differences between Cairo and
Skia.
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
- platform/image-decoders/ImageDecoder.h: Sync up with Skia version. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::copyRowNTimes): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setRGBA): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version. (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version. (WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version. (WebCore::PNGImageDecoder::rowAvailable):
- platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version. Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::copyRowNTimes): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setRGBA): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.
- 2:36 PM Changeset in webkit [44630] by
-
- 2 edits in trunk/WebCore
2009-06-12 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build correction.
Revert accidental configuration checkin. Was not meant to
be part of the last changeset.
- config.h:
- 2:34 PM Changeset in webkit [44629] by
-
- 2 edits in trunk/WebCore
(Accidentally missed a couple email addresses in the last patch)
- 2:25 PM Changeset in webkit [44628] by
-
- 9 edits in trunk/WebCore
2009-06-12 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26353
Corrects handling of Cairo fonts that were getting out of
sync due to default copy construction. Also refactors
some incorrect platform font destruction code that belongs
in the font object's destructor.
- platform/graphics/win/FontPlatformData.h:
- platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::~FontPlatformData):
- platform/graphics/win/FontPlatformDataCairoWin.cpp: (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::~FontPlatformData):
- platform/graphics/win/FontPlatformDataWin.cpp:
- platform/graphics/win/SimpleFontDataCGWin.cpp:
- platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/win/SimpleFontDataWin.cpp:
- 2:19 PM Changeset in webkit [44627] by
-
- 8 edits in trunk
2009-06-12 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
- ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.
WebCore:
2009-06-12 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
- ChangeLog-2007-10-14: Update my email address.
- ChangeLog-2008-08-10: Update my email address.
WebKit/mac:
2009-06-12 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
- ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.
WebKit/win:
2009-06-12 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
- ChangeLog: Update my email address.
- 1:00 PM QtWebKitTodo edited by
- (diff)
- 11:02 AM Changeset in webkit [44626] by
-
- 1 edit2 adds in trunk/WebCore
2009-06-12 Nate Chapin <japhet@google.com>
Reviewed by David Levin.
Upstream V8Helpers.
- bindings/v8/V8Helpers.cpp: Added. (wrapNPObject): Moved from v8_helpers.cpp. (toV8Context): Moved from v8_helpers.cpp. (toV8Proxy): Moved from v8_helpers.cpp.
- bindings/v8/V8Helpers.h: Added.
- 9:15 AM Changeset in webkit [44625] by
-
- 2 edits in trunk/JavaScriptCore
wx build fix. Adding JSONObject.cpp to the build.
- 8:55 AM Changeset in webkit [44624] by
-
- 4 edits in trunk/WebCore
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 44622)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,23 @@
+2009-06-12 Jessie Berlin <jberlin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24792
+ rdar://problem/6933055
+
+ Changes the radius in which cursor movement around the 4 arrow icon
+ while pan-scrolling does not cause scrolling from around 10 pixels to
+ 15 pixels, similar to what is found in IE and Firefox.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::setPanScrollCursor):
+ Factor out the no-pan-scroll radius.
+ * platform/ScrollView.h:
+ Create a constant for the no-pan-scroll radius.
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::panScrollFromPoint):
+ Factor out the no-pan-scroll radius.
+
2009-06-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Index: WebCore/page/EventHandler.cpp
===================================================================
--- WebCore/page/EventHandler.cpp (revision 44622)
+++ WebCore/page/EventHandler.cpp (working copy)
@@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()
At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
So we don't want to change the cursor over this area
- const int noScrollRadius = 9;
- bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
- bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
- bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
- bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);
+ bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
+ bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
+ bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
+ bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);
if (north) {
if (east)
Index: WebCore/platform/ScrollView.h
===================================================================
--- WebCore/platform/ScrollView.h (revision 44622)
+++ WebCore/platform/ScrollView.h (working copy)
@@ -214,7 +214,8 @@ public:
virtual void hide();
virtual void setParentVisible(bool);
- Pan scrolling methods.
+ Pan scrolling.
+ static const int noPanScrollRadius = 15;
void addPanScrollIcon(const IntPoint&);
void removePanScrollIcon();
Index: WebCore/rendering/RenderLayer.cpp
===================================================================
--- WebCore/rendering/RenderLayer.cpp (revision 44622)
+++ WebCore/rendering/RenderLayer.cpp (working copy)
@@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con
const int shortDistanceLimit = 100; We delimit a 200 pixels long square enclosing the original point
const int speedReducer = 2; Within this square we divide the scrolling speed by 2
- const int iconRadius = 10;
Frame* frame = renderer()->document()->frame();
if (!frame)
return;
@@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con
int xDelta = currentMousePosition.x() - sourcePoint.x();
int yDelta = currentMousePosition.y() - sourcePoint.y();
- if (abs(xDelta) < iconRadius) at the center we let the space for the icon
+ if (abs(xDelta) < ScrollView::noPanScrollRadius) at the center we let the space for the icon
xDelta = 0;
- if (abs(yDelta) < iconRadius)
+ if (abs(yDelta) < ScrollView::noPanScrollRadius)
yDelta = 0;
Let's attenuate the speed for the short distances
- 7:44 AM Changeset in webkit [44623] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-12 Laszlo Gombos <Laszlo Gombos>
Reviewed by Jan Michael Alonzo.
[Qt] Fix build break
https://bugs.webkit.org/show_bug.cgi?id=26340
- JavaScriptCore.pri: Add JSONObject.cpp to LUT files.
Jun 11, 2009:
- 11:46 PM Changeset in webkit [44622] by
-
- 2 edits in trunk/WebCore
2009-06-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections
Only use the VisibleSelection object if it actually belongs to the
object we are using.
This is pretty hacky-ish, but I can't seem to find a direct API to
get the VisibleSelection for a given object, only the global one.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (selectionBelongsToObject): (webkit_accessible_text_get_n_selections): (webkit_accessible_text_get_selection):
- 5:58 PM Changeset in webkit [44621] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2009-06-11 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=2628i
Converted LayoutTests\editing\deleting\4875189.html from a pixel test t
dumpAsText test
since it only checks whether the result contains exactly two paragraphs
or not.
- editing/deleting/4875189-expected.txt: Added.
- editing/deleting/4875189.html:
- platform/mac/editing/deleting/4875189-expected.checksum: Removed.
- platform/mac/editing/deleting/4875189-expected.png: Removed.
- platform/mac/editing/deleting/4875189-expected.txt: Removed.
- platform/qt/editing/deleting/4875189-expected.txt: Removed.
- 4:47 PM Changeset in webkit [44620] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-11 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
Add a test to perform an actual download.
- tests/testdownload.c: (navigation_policy_decision_requested_cb): (notify_status_cb): (download_requested_cb): (test_webkit_download_perform): (main):
- 3:38 PM Changeset in webkit [44619] by
-
- 5 edits in trunk/WebKit/gtk
2009-06-11 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
Fix crash when downloading, caused by assuming SoupMessage would
be there. This change factors the logic required to create a
ResourceRequest from a WebKitNetworkRequest into a core()
function, like we have for some other classes.
- webkit/webkitdownload.cpp: (webkit_download_start):
- webkit/webkitprivate.cpp: (WebKit::core):
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_load_request):
- 3:17 PM Changeset in webkit [44618] by
-
- 1 edit12 adds in trunk/LayoutTests
2009-06-11 Eric Seidel <eric@webkit.org>
Rubber stamped by Dave Levin.
Add missing pixel results
- platform/mac/editing/style/apply-through-end-of-document-expected.checksum: Added.
- platform/mac/editing/style/apply-through-end-of-document-expected.png: Added.
- platform/mac/fast/canvas/canvas-empty-image-pattern-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
- platform/mac/fast/canvas/canvas-empty-image-pattern-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
- platform/mac/fast/css/compare-content-style-expected.checksum: Added.
- platform/mac/fast/css/compare-content-style-expected.png: Added.
- platform/mac/fast/dynamic/anchor-lock-expected.checksum: Added.
- platform/mac/fast/dynamic/anchor-lock-expected.png: Added.
- platform/mac/fast/transforms/bounding-rect-zoom-expected.checksum: Added.
- platform/mac/fast/transforms/bounding-rect-zoom-expected.png: Added.
- platform/mac/webarchive/test-link-rel-icon-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
- platform/mac/webarchive/test-link-rel-icon-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
- 2:20 PM Changeset in webkit [44617] by
-
- 4 edits in trunk/WebCore
Speculative fix
- 1:05 PM Changeset in webkit [44616] by
-
- 1 copy in tags/Safari-6530.18
New tag.
- 1:05 PM Changeset in webkit [44615] by
-
- 1 delete in branches/Safari-6530.18
Hrm, this isn't where I should live.
- 1:03 PM Changeset in webkit [44614] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 1:02 PM Changeset in webkit [44613] by
-
- 1 copy in branches/Safari-6530.18
New tag.
- 12:59 PM Changeset in webkit [44612] by
-
- 13 edits in branches/WWDC-2009-branch
Merge r44591.
- 12:58 PM Changeset in webkit [44611] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 11:47 AM Changeset in webkit [44610] by
-
- 5 edits in trunk
Lower stringify recursion limit to deal with small windows stack.
- 11:20 AM Changeset in webkit [44609] by
-
- 2 edits in trunk/WebKitTools
2009-06-11 John Abd-El-Malek <jam@chromium.org>
Reviewed by Steve Falkenburg.
Revert 42565 as it leads to DumpRenderTree crashing on startup because
Windows can't find CFURLCacheCopySharedURLCache in CoreNetwork.dll.
- DumpRenderTree/win/DumpRenderTree.cpp:
- 11:15 AM Changeset in webkit [44608] by
-
- 8 edits4 adds in trunk
2009-06-11 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=25512
Handle texts after unfinished special tags (i.e., script, style, textarea,
title, xmp, and iframe) as the text node under the tags in view-source mode.
Before this change, all texts in unfinished special tags cannot be seen even in view-source mode.
- 10:57 AM Changeset in webkit [44607] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-11 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
Fix compilation warnings
<https://bugs.webkit.org/show_bug.cgi?id=26015>
- wtf/ThreadingNone.cpp: (WTF::ThreadCondition::wait): Fix compilation warning. (WTF::ThreadCondition::timedWait): Ditto.
- 10:39 AM Changeset in webkit [44606] by
-
- 2 edits in trunk
2009-06-11 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] Fix release build detection
https://bugs.webkit.org/show_bug.cgi?id=26267
- WebKit.pri:
- 10:28 AM Changeset in webkit [44605] by
-
- 2 edits in trunk/WebCore
2009-06-11 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] build break in ImageDecoderQt.cpp.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::reset): (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::isSizeAvailable):
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::setSize):
- 9:34 AM Changeset in webkit [44604] by
-
- 3 edits in trunk/WebKitSite
2009-06-10 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
Fixes https://bugs.webkit.org/show_bug.cgi?id=26309.
Update a few items in the testing language to:
(1) Reflect results are now generated with Leopard (not Tiger)
(2) Explain how to generate pixel-level layout tests.
- 6:57 AM Changeset in webkit [44603] by
-
- 1 edit7 deletes in trunk/WebCore
2009-06-11 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Ariya Hidayat.
Removed obsolete and unmaintained files from the old Symbian port.
- 4:59 AM QtWebKitTodo edited by
- (diff)
- 4:58 AM QtWebKitTodo edited by
- (diff)
Jun 10, 2009:
- 10:31 PM Changeset in webkit [44602] by
-
- 2 edits in trunk/LayoutTests
2009-06-10 Brent Fulgham <bfulgham@gmail.com>
Unreviewed build fix.
Reverted change to skip file, as Windows build is
still failing.
- platform/win/Skipped:
- 9:59 PM Changeset in webkit [44601] by
-
- 2 edits4 adds in trunk/LayoutTests
2009-06-05 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
Re-enable the video-zoom-controls test on Windows.
- platform/win/Skipped:
- platform/win/media: Added.
- platform/win/media/video-zoom-controls-expected.checksum: Added.
- platform/win/media/video-zoom-controls-expected.png: Added.
- platform/win/media/video-zoom-controls-expected.txt: Added.
- 9:44 PM Changeset in webkit [44600] by
-
- 2 edits in trunk/WebKitTools
2009-06-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Jan Alonzo.
[gtk] Change DumpRenderTree to use a GtkScrolledWindow instead of GtkFixed
Change the code to use GtkScrolledWindow and resize the GtkScrolledWindow
to pass more tests. Make sure the content is bigger than a thumbnail.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): (main):
- 8:14 PM Changeset in webkit [44599] by
-
- 2 edits in trunk/LayoutTests
2009-06-10 Gustavo Noronha Silva <Gustavo Noronha Silva>
Disabling new tests, and tests that use features of DRT we don't
currently implement.
- platform/gtk/Skipped:
- 7:48 PM Changeset in webkit [44598] by
-
- 6 edits1 add in trunk
2009-06-10 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
Add unit tests for our WebKitNetworkRequest object.
- GNUmakefile.am:
WebKit/gtk
2009-06-10 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
Make WebKitNetworkRequest a proper GObject, making URI and
SoupMessage properties. Also adding unit tests for creation and
destruction.
- tests/testnetworkrequest.c: Added. (test_network_request_create_destroy): (test_network_request_properties): (main):
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_get_property): (webkit_network_request_set_property): (webkit_network_request_class_init): (webkit_network_request_init): (webkit_network_request_constructor): (webkit_network_request_new_with_core_request): (webkit_network_request_new): (webkit_network_request_set_uri): (webkit_network_request_get_uri):
- webkit/webkitnetworkrequest.h:
- 5:31 PM Changeset in webkit [44597] by
-
- 11 edits in trunk/WebCore
2009-06-10 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part six
Miscellaneous tiny changes. The important bits here are the ANSI C++
compliance fix in skia/ImageDecoders.h (needed to compile this file on
non-MSVC) and some behavioral fixes for the XBM decoder that Chromium
unit tests partly exposed. Other changes are mostly cosmetic.
- platform/image-decoders/ImageDecoder.h: Make some variables private again. This will break QTWebKit but those guys have agreed to wait on my finishing the ImageDecoder changes.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
- platform/image-decoders/skia/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): Make more in line with other decoders' comments and structure, use a ref to decrease verbosity. (WebCore::BMPImageReader::processRLEData): Use a ref to decrease verbosity. (WebCore::BMPImageReader::processNonRLEData): Use a ref to decrease verbosity.
- platform/image-decoders/skia/GIFImageDecoder.cpp: Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
- platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes): Fix ANSI violation that MSVC let me compile (!).
- platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
- platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
- platform/image-decoders/skia/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::frameBufferAtIndex): Return 0 for non-zero indexes, don't try to decode unnecessarily after failure or when the size couldn't be computed, make more in line with other decoders' comments and structure, call RGBA32Buffer::setRect() appropriately.
- 5:16 PM Changeset in webkit [44596] by
-
- 1 edit1 move2 adds1 delete in trunk/LayoutTests
2009-06-10 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build correction.
Clean up some stupid test mistakes, add pixel-level Mac tests
for the new zero-radius gradient test.
- 4:22 PM Changeset in webkit [44595] by
-
- 1 edit2 adds in trunk/LayoutTests
Build correction for @r44574 (missing expected results).
See https://bugs.webkit.org/show_bug.cgi?id=26059.
- 3:47 PM Changeset in webkit [44594] by
-
- 2 edits in trunk/WebKitTools
2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- 3:40 PM BuildingQtOnLinux edited by
- (diff)
- 3:37 PM BuildingQtOnLinux edited by
- (diff)
- 3:37 PM BuildingQtOnLinux edited by
- (diff)
- 2:54 PM Changeset in webkit [44593] by
-
- 3 edits2 adds in trunk
Fix collapsing empty shadow nodes in textareas.
- 1:55 PM Changeset in webkit [44592] by
-
- 2 edits in trunk/WebCore
2009-06-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections
Implement atk_text_get_n_selections.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_n_selections):
- 1:37 PM Changeset in webkit [44591] by
-
- 13 edits in trunk
WebCore:
Reviewed by Anders Carlsson.
- fix <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a Google map in iPhoto Places, it drags a map tile instead
Calling stopLoadRequest() from notifyFinished() removed the
ScriptElementData from the CachedScript's client set, which could make
it eligible for purging. The fix is to call removeClient() only after
executing the script, which protects it from being purged while it is
in the document's queue of scripts to execute soon.
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::execute): Call removeClient() here. (WebCore::ScriptElementData::notifyFinished): Instead of calling stopLoadRequest(), which calls removeClient(), just reset m_cachedScript.
WebKitTools:
Reviewed by Adele Peterson.
- add a LayoutTestController method for temporarily changing the WebKit cache model
- DumpRenderTree/LayoutTestController.cpp: (setCacheModelCallback): Added. Calls LayoutTestController::setCacheModel() with the first argument as an integer. (LayoutTestController::staticFunctions): Added setCacheModel.
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCacheModel):
- DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Reset the cache model to WebCacheModelDocumentBrowser.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setCacheModel): Added. Calls -[WebPreferences setCacheModel:].
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCacheModel):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setCacheModel):
LayoutTests:
Reviewed by Adele Peterson.
- updated test to cover <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a Google map in iPhoto Places, it drags a map tile instead
- fast/dom/HTMLScriptElement/nested-execution.html:
- fast/dom/HTMLScriptElement/resources/nested-execution.js:
- 1:36 PM Changeset in webkit [44590] by
-
- 2 edits in trunk/WebCore
2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Mark Rowe and Eric Seidel.
Update WebInspector localizedStrings.js with new resource tracking strings
https://bugs.webkit.org/show_bug.cgi?id=26247
- English.lproj/localizedStrings.js:
- 12:43 PM Changeset in webkit [44589] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.9
Tagging 1.1.9.
- 12:22 PM Changeset in webkit [44588] by
-
- 1 edit2 adds in trunk/WebCore
2009-06-10 Feng Qian <feng@chromium.org>
Reviewed by Eric Seidel.
Add Android specific files.
https://bugs.webkit.org/show_bug.cgi?id=26280
- 12:21 PM Changeset in webkit [44587] by
-
- 1 edit1 add in trunk/WebCore
2009-06-10 Feng Qian <feng@chromium.org>
Reviewed by Eric Seidel.
Add Android specific file to WebCore/platform/android (part 9).
https://bugs.webkit.org/show_bug.cgi?id=26266
- 12:19 PM Changeset in webkit [44586] by
-
- 1 edit2 adds in trunk/WebCore
2009-06-10 Feng Qian <feng@chromium.org>
Reviewed by Eric Seidel.
Add Android platform specific files.
https://bugs.webkit/org/show_bug.cgi?id=26265 (part 8).
- 12:18 PM Changeset in webkit [44585] by
-
- 1 edit2 adds in trunk/WebCore
2009-06-10 Feng Qian <feng@chromium.org>
Reviewed by Eric Seidel.
Add Android port files to WebCore/platform. (part 6).
https://bugs.webkit.org/show_bug.cgi?id=26264
- 12:11 PM Changeset in webkit [44584] by
-
- 1 edit3 adds in trunk/WebCore
2009-06-10 Feng Qian <feng@chromium.org>
Reviewed by Eric Seidel.
Add Android port files to WebCore/platform (part 7).
https://bugs.webkit.org/show_bug.cgi?id=23296
- 12:09 PM Changeset in webkit [44583] by
-
- 1 edit2 adds in trunk/WebCore
2009-06-10 Feng Qian <feng@chromium.org>
Reviewed by Eric Seidel.
Add Android port files to WebCore/platform (part 5).
https://bugs.webkit.org/show_bug.cgi?id=23296
- 12:06 PM Changeset in webkit [44582] by
-
- 1 edit2 adds in trunk/WebCore
2009-06-10 Feng Qian <feng@chromium.org>
Reviewed by Eric Seidel.
Add Android port files to WebCore/platform (part 4).
https://bugs.webkit.org/show_bug.cgi?id=23296
- 12:05 PM Changeset in webkit [44581] by
-
- 1 edit2 adds in trunk/WebCore
2009-06-10 Feng Qian <feng@chromium.org>
Reviewed by Eric Seidel.
Add Android port files to WebCore/platform (part 3).
https://bugs.webkit.org/show_bug.cgi?id=23296
- 12:01 PM Changeset in webkit [44580] by
-
- 1 edit3 adds in trunk/WebCore
009-06-10 Feng Qian <feng@chromium.org>
Reviewed by Eric Seidel.
Add Android port files to WebCore/platform (part 2).
https://bugs.webkit.org/show_bug.cgi?id=23296
- 11:46 AM Changeset in webkit [44579] by
-
- 6 edits1 copy in trunk/WebCore
2009-06-10 Nate Chapin <japhet@google.com>
Reviewed by David Levin.
Finish moving V8Custom from src.chromium.org to svn.webkit.org.
- bindings/v8/custom/V8CustomBinding.cpp: Finished upstreaming. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::V8Custom::GetTargetFrame): Moved from v8_custom.cpp. (WebCore::V8Custom::DowncastSVGPathSeg): Moved from v8_custom.cpp.
- bindings/v8/custom/V8CustomBinding.h: Finished upstreaming.
- bindings/v8/custom/V8DatabaseCustom.cpp: Updated includes.
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Updated includes.
- bindings/v8/custom/V8SQLTransactionCustom.cpp: Updated includes.
- bindings/v8/custom/V8WebKitPointConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
- 11:21 AM Changeset in webkit [44578] by
-
- 3 edits2 adds in trunk
2009-06-05 Takeshi Yoshino <tyoshino@google.com>
Reviewed by NOBODY (OOPS!).
https://bugs.webkit.org/show_bug.cgi?id=26214
Bug 26214: RenderTextControl: Remove ASSERT for checking that visiblePositionForIndex()'s return is not null.
- 11:18 AM Changeset in webkit [44577] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
News for 1.1.9.
- NEWS:
- 11:16 AM Changeset in webkit [44576] by
-
- 2 edits in trunk/WebCore
2009-06-04 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26197
Bug 26197: Incorrect variable initialization in PlatformContextSkia.cpp
- 11:04 AM Changeset in webkit [44575] by
-
- 3 edits2 adds in trunk
2009-06-10 Dean McNamee <deanm@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26061
Make sure filling a canvas pattern with an empty image doesn't crash.
- 10:57 AM Changeset in webkit [44574] by
-
- 4 edits1 add in trunk
Correct Bug #26059.
https://bugs.webkit.org/show_bug.cgi?id=26059.
- 10:46 AM Changeset in webkit [44573] by
-
- 5 edits in trunk/WebCore
2009-06-10 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part five
Rewrite users of ImageDecoder.h to use "safe" API calls, Skia side.
This tweaks the RGBA32Buffer interfaces to be implementable by Cairo as
well and modifies Skia's usage of those interfaces accordingly. Once a
similar change lands on the Cairo side, the Skia and Cairo decoders
should be identical except for the implementation of RGBA32Buffer.
- platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() function.
- platform/image-decoders/skia/BMPImageReader.cpp: (WebCore::BMPImageReader::processNonRLEData): Use new RGBA32Buffer::zeroFill() function.
- platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow): Rewrite to use RGBA32Buffer::setRGBA(x, y, ...) calls as well as other RGBA32Buffer interface calls instead of knowing the underlying types inside the buffer; also try and add clarity.
- platform/image-decoders/skia/ImageDecoder.h: Removed bitmap(), width(), and height(). (WebCore::RGBA32Buffer::zeroFill): Added. (WebCore::RGBA32Buffer::copyBitmapData): Avoid using bitmap(), which is going away. (WebCore::RGBA32Buffer::copyRowNTimes): Added. (WebCore::RGBA32Buffer::setSize): Use new zeroFill() function. (WebCore::RGBA32Buffer::asNewNativeImage): Added. (WebCore::RGBA32Buffer::setRGBA): Condensed two versions into one that takes coordinates instead of a raw pointer.
- 10:36 AM Changeset in webkit [44572] by
-
- 2 edits in trunk
2009-06-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Version bump in preparation for 1.1.9 release.
- configure.ac:
- 10:27 AM Changeset in webkit [44571] by
-
- 2 edits in trunk/WebCore
2009-06-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25671
[GTK] Implement support for set_caret_offset
Make an implementation that actually works.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_set_caret_offset):
- 10:26 AM Changeset in webkit [44570] by
-
- 3 edits in trunk/WebKit/gtk
2009-06-09 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_clear_main_frame_name):
- 10:25 AM Changeset in webkit [44569] by
-
- 2 edits in trunk/WebCore
2009-06-10 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Make sure all member variables are initialized so that the default
assignment operator and copy constructors do not read uninitialized
memory.
- platform/network/ResourceResponseBase.cpp:
- 10:18 AM Changeset in webkit [44568] by
-
- 3 edits in trunk/WebCore
2009-06-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Update main resource meta-data when resource tracking is disabled.
- inspector/InspectorController.cpp: (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- 10:17 AM Changeset in webkit [44567] by
-
- 2 edits in trunk/WebCore
2009-06-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections
Implement atk_text_get_selection.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_selection):
- 10:03 AM Changeset in webkit [44566] by
-
- 2 edits in trunk/WebCore
2009-06-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not check if our parent class has the finalize method, it's
guaranteed to be there.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_finalize):
- 9:25 AM Changeset in webkit [44565] by
-
- 2 edits in trunk/WebCore
2009-06-10 Brent Fulgham <bfulgham@webkit.org>
Build correct for Windows Cairo targets.
- WebCore.vcproj/WebCore.vcproj: Disable warning 4611 (interaction between '_setjmp' and C++ object destruction is non-portable) for the two Cairo targets. This used to be disabled in a #pragma, but recent refactoring removed these lines.
- 9:20 AM Changeset in webkit [44564] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-10 Brent Fulgham <bfulgham@webkit.org>
Build fix for Windows target.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Correct missing </File> tag after @r44550 that prevents the project from being loaded in the Visual Studio IDE.
- 9:06 AM QtWebKitTodo edited by
- (diff)
- 8:37 AM Changeset in webkit [44563] by
-
- 4 edits in trunk/WebCore
2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Fix the build of PluginView on Qt with 64-bit where we disable plugins
at compile time.
Use the FooNone.cpp files at compile-time.
- 8:32 AM Changeset in webkit [44562] by
-
- 2 edits in trunk/WebCore
2009-06-10 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build.
ImageDecoderQt needs m_size and m_sizeAvailable to be protected.
- 8:21 AM Changeset in webkit [44561] by
-
- 2 edits in trunk/WebCore
2009-06-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Use absolute path for install_name on Mac
- 7:48 AM Changeset in webkit [44560] by
-
- 3 edits in trunk/WebKit/qt
2009-06-10 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Ariya Hidayat.
Documented ResolveRule and StylePriority enum values as well as their use in
QWebElement::styleProperty and QWebElement::setStyleProperty methods.
Based on the work of Simon Hausmann.
- Api/qwebelement.cpp: (QWebElement::styleProperty): (QWebElement::setStyleProperty):
- Api/qwebelement.h:
- 6:10 AM Changeset in webkit [44559] by
-
- 2 edits in trunk/WebCore
2009-06-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Reduce duplicated code to access the text of a AtkText
object. doAXStringForRange calls text() internally, so we are
doing exactly the same after the change.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getGailTextUtilForAtk): (getPangoLayoutForAtk):
- 6:10 AM Changeset in webkit [44558] by
-
- 2 edits in trunk/WebCore
2009-06-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Pass a PangoLayout to the GailTextUtil function calls.
It's needed for LINE boundary calls to work correctly.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (updateLayout): (getPangoLayoutForAtk): (webkit_accessible_text_get_text_after_offset): (webkit_accessible_text_get_text_at_offset):
- 6:10 AM Changeset in webkit [44557] by
-
- 7 edits in trunk
2009-06-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Add new dependency on the Gail utils library, needed for our a11y
implementation.
- GNUmakefile.am:
- configure.ac:
WebCore:
2009-06-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Use GailUtilText instead of my crappy partial reimplementation of
it. This should add support for LINE boundaries too, although it's
mostly untested for now.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getGailTextUtilForAtk): (webkit_accessible_text_get_text_after_offset): (webkit_accessible_text_get_text_at_offset):
WebKit/gtk:
2009-06-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Update test for new implementation (it fixes two bugs and adds
actual implementations for LINE boundaries).
- tests/testatk.c: (test_webkit_atk_get_text_at_offset):
- 3:41 AM Changeset in webkit [44556] by
-
- 2 edits in trunk/WebCore
2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix: include <stdio.h> as it is required in jpeglib.h
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
Jun 9, 2009:
- 11:18 PM Changeset in webkit [44555] by
-
- 2 edits in trunk/WebKitTools
Have sunspider-compare-results use the system version of the jsc
command line binary as there's no good reason to rebuild from source
to simply compare results.
Reviewed by Sam Weinig.
- Scripts/sunspider-compare-results:
- 11:18 PM Changeset in webkit [44554] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-09 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Mark Rowe.
Tidy up a couple of comments.
- assembler/ARMv7Assembler.h:
Fix date in copyright, neaten up a couple of comments.
- assembler/MacroAssemblerARMv7.h:
Fix date in copyright.
- 7:23 PM Changeset in webkit [44553] by
-
- 11 edits in trunk/WebCore
2009-06-09 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part four
Most of the remaining Cairo changes needed before merging Skia/Cairo
image decoders. Most of these involve plumbing more error detection and
handling (or, in some cases, merely the capability to detect errors, as
e.g. Skia detects and handles image allocation failure while Cairo
currently doesn't). There is also some general cleanup and
simplification; RGBA32Buffer::m_height and all associated functions have
been removed (set but never used) and some places now rely on superclass
implementations.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::RGBA32Buffer): Remove m_height, ensureHeight() and associated stuff (WebCore::RGBA32Buffer::copyBitmapData): Add API function so refcounted backing stores (like Skia uses) can be used with GIFs (WebCore::RGBA32Buffer::setSize): Zero-fill image to avoid garbage (WebCore::RGBA32Buffer::height): Remove (WebCore::RGBA32Buffer::ensureHeight): Remove (WebCore::ImageDecoder::ImageDecoder): Keep member initialization in order, force subclasses to go through size() instead of accessing m_size directly (WebCore::ImageDecoder::isSizeAvailable): Check that decoding hasn't failed (WebCore::ImageDecoder::size): Check that decoding hasn't failed (WebCore::ImageDecoder::setSize): Protect against integer overflow (WebCore::ImageDecoder::isOverSize): Protect against integer overflow
- platform/image-decoders/gif/GIFImageDecoder.cpp: Remove prepEmptyFrameBuffer() (WebCore::GIFImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling (WebCore::GIFImageDecoder::sizeNowAvailable): Add return values for better failure handling, rely on superclass setSize() for overflow protection (WebCore::GIFImageDecoder::initFrameBuffer): Add return values for better failure handling, remove prepEmptyFrameBuffer(), use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), use RGBA32Buffer::copyBitmapData() so backing store can be refcounted internally (Cairo won't be, Skia is), rely on superclass size() for better failure handling (WebCore::GIFImageDecoder::haveDecodedRow): Fix style violation, remove RGBA32Buffer::ensureHeight() (WebCore::GIFImageDecoder::frameComplete): Remove RGBA32Buffer::ensureHeight()
- platform/image-decoders/gif/GIFImageDecoder.h: Remove prepEmptyFrameBuffer(), add return values for better failure handling
- platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::do_lzw): Protect against array overflow, add comments (GIFImageReader::read): Protect against array overflow, be more tolerant of bad data, better failure handling
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove MSVC-specific warning disable (bfulgham will move into build files) (WebCore::JPEGImageReader::decode): Better failure handling (WebCore::JPEGImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling (WebCore::JPEGImageDecoder::outputScanlines): Use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), rely on superclass size() for better failure handling, remove RGBA32Buffer::ensureHeight()
- platform/image-decoders/jpeg/JPEGImageDecoder.h: Rely on superclass setSize() for overflow protection
- platform/image-decoders/png/PNGImageDecoder.cpp: Remove MSVC-specific warning disable (bfulgham will move into build files) (WebCore::PNGImageDecoder::PNGImageDecoder): Don't allocate a slot in the framebuffer cache until it's needed (WebCore::PNGImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling (WebCore::PNGImageDecoder::frameBufferAtIndex): Don't allocate a slot in the framebuffer cache until it's needed (WebCore::PNGImageDecoder::decode): Don't allocate a slot in the framebuffer cache until it's needed (WebCore::PNGImageDecoder::decodingFailed): Fix style violation (WebCore::PNGImageDecoder::headerAvailable): Rely on superclass isSizeAvailable() and setSize() for overflow protection and better failure handling (WebCore::PNGImageDecoder::rowAvailable): Don't allocate a slot in the framebuffer cache until it's needed, use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), remove RGBA32Buffer::ensureHeight() (WebCore::PNGImageDecoder::pngComplete): Don't allocate a slot in the framebuffer cache until it's needed
- 5:44 PM Changeset in webkit [44552] by
-
- 5 edits in trunk
wx build fix, adding JSCore/assembler to the list of include dirs, and adding editing/ReplaceNodeSpanCommand.cpp to the build.
- 5:39 PM Changeset in webkit [44551] by
-
- 2 edits in trunk/LayoutTests
2009-06-09 Brent Fulgham <bfulgham@webkit.org>
No review, build fix only.
Correct DOS line-endings in expected file.
https://bugs.webkit.org/show_bug.cgi?id=26187.
- fast/canvas/canvas-lineWidth-expected.txt:
- 5:37 PM Changeset in webkit [44550] by
-
- 12 edits6 adds in trunk
Bug 26249: Support JSON.stringify
<https://bugs.webkit.org/show_bug.cgi?id=26249>
Reviewed by Sam Weinig.
Implement JSON.stringify. This patch handles all the semantics of the ES5
JSON.stringify function, including replacer functions and arrays and both
string and numeric gap arguments.
Currently uses a clamped recursive algorithm basically identical to the spec
description but with a few minor tweaks for performance and corrected semantics
discussed in the es-discuss mailing list.
- 5:20 PM Changeset in webkit [44549] by
-
- 3 edits in trunk/WebCore
2009-06-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
When checking if the loader is the main resource loader make sure that the loader's frame is the main frame.
- inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::isMainResourceLoader):
- inspector/InspectorController.h:
- 5:18 PM Changeset in webkit [44548] by
-
- 1 edit1 add in trunk/LayoutTests
2009-06-09 Brent Fulgham <bfulgham@webkit.org>
No review, build fix only.
Added missing expected results from
https://bugs.webkit.org/show_bug.cgi?id=26187.
- fast/canvas/canvas-lineWidth-expected.txt: Added.
- 3:47 PM Changeset in webkit [44547] by
-
- 2 edits in trunk/BugsSite
2009-06-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
Add support for displaying added png files in PrettyPatch diffs
https://bugs.webkit.org/show_bug.cgi?id=26210
Currently this is SVN only (git-send-bugzilla patches exclude binary data)
and only works for PNG files but could easily be made to work for other images as needed.
- PrettyPatch/PrettyPatch.rb:
- 3:43 PM Changeset in webkit [44546] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-09 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
Test: media/controls-css-overload.html
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls): Prevent NULL dereference in case containers gets hidden.
LayoutTests:
2009-06-09 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
Test case on internal -webkit-media overload.
- media/controls-css-overload-expected.txt: Added.
- media/controls-css-overload.html: Added.
- 3:00 PM Changeset in webkit [44545] by
-
- 8 edits in trunk/WebCore
2009-06-08 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part three
Various minor cleanups to the Skia files. Mostly non-functional, except
for two specific changes:
- JPEGs and PNGs were always marked as transparent; now they are only marked as transparent when they actually are. I doubt this has much of an effect but in theory it could be used to optimize their display.
- Instead of arbitrarily disallowing images over 32 * 1024 * 1024 px2, only disallow images which are so large they will cause overflow in other parts of the code. This should fix the testcase on http://code.google.com/p/chromium/issues/detail?id=3643.
- platform/image-decoders/skia/BMPImageReader.h: (WebCore::BMPImageReader::setRGBA): Use simpler non-static setRGBA() form
- platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Remove unneeded code, use more readable setRGBA() form (WebCore::GIFImageDecoder::haveDecodedRow): Fix style violation
- platform/image-decoders/skia/GIFImageDecoder.h: Remove unneeded code
- platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::setSize): setSize() should just setStatus() when it fails since all callers were doing it (WebCore::ImageDecoder::isOverSize): Ease "oversized" image constraints to allow any image that won't overflow
- platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove unneeded code, mark JPEGs as non-transparent
- platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::decodingFailed): Fix style violation (WebCore::PNGImageDecoder::rowAvailable): Mark un-decoded PNGs as non-transparent (this will get reset later as needed)
- platform/image-decoders/skia/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::frameBufferAtIndex): Remove unneeded code
- 2:11 PM Changeset in webkit [44544] by
-
- 2 edits in trunk/WebCore
2009-06-09 Darin Fisher <darin@chromium.org>
Fix Chromium build bustage.
CachedResource.cpp no longer compiles if USE(JSC) is not defined. The
problem is that this file is using a macro from StdLibExtras.h without
including that file. It just happenes to get that file via a JSC
specific include.
- loader/CachedResource.cpp:
- 1:47 PM Changeset in webkit [44543] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2009-06-09 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
Changing editing/deleting/4866671.html to use a dumpAsText test instead of a pixel test
so as to remove the platform dependency.
- editing/deleting/4866671.html:
- 1:39 PM Changeset in webkit [44542] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-09 Dean McNamee <deanm@chromium.org>
Reviewed by Oliver Hunt.
Make sure the graphics backends are in sync with the canvas lineWidth state.
https://bugs.webkit.org/show_bug.cgi?id=26187
Test: fast/canvas/canvas-line-width.html
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
LayoutTests:
2009-06-09 Dean McNamee <deanm@chromium.org>
Reviewed by Oliver Hunt.
Make sure the graphics backends are in sync with the canvas lineWidth state.
https://bugs.webkit.org/show_bug.cgi?id=26187
- fast/canvas/canvas-lineWidth.html: Added.
- fast/canvas/canvas-lineWidth.js: Added. (compareRows):
- 1:34 PM QtWebKitTodo edited by
- (diff)
- 1:03 PM Changeset in webkit [44541] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-09 Michael Nordman <Michael Nordman>
Reviewed by Eric Seidel.
Proactively cancel pending requests at DocLoader dtor time,
otherwise crashes can occur.
https://bugs.webkit.org/show_bug.cgi?id=26230
http://code.google.com/p/chromium/issues/detail?id=12161
Test: fast/frames/javascript-url-as-framesrc-crash.html
- loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader):
LayoutTests:
2009-06-09 Michael Nordman <Michael Nordman>
Reviewed by Eric Seidel.
Proactively cancel pending requests at DocLoader dtor time,
otherwise crashes can occur.
https://bugs.webkit.org/show_bug.cgi?id=26230
http://code.google.com/p/chromium/issues/detail?id=12161
- fast/frames/javascript-url-as-framesrc-crash-expected.txt: Added.
- fast/frames/javascript-url-as-framesrc-crash.html: Added.
- 12:34 PM Changeset in webkit [44540] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-09 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Fix ASSERT seen in shadow tree testing
https://bugs.webkit.org/show_bug.cgi?id=25092
Test: svg/custom/use-mutation-event-crash.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::instanceForShadowTreeElement):
LayoutTests:
2009-06-09 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Fix ASSERT seen in shadow tree testing
https://bugs.webkit.org/show_bug.cgi?id=25092
- svg/custom/use-mutation-event-crash.svg: Added.
- 11:27 AM Changeset in webkit [44539] by
-
- 8 edits in trunk/WebCore
2009-06-09 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
Fixes https://bugs.webkit.org/show_bug.cgi?id=22891
Scrolling in Windows Cairo Broken if no background color set.
- platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::fill): Use the GraphicsContext save and restore methods (rather than the Cairo-only functions) so that the Windows device context is kept in sync.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext): Add new constructor call to sync Windows HDC with Cairo surface.
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::syncContext): Provide declaration for Windows HDC sync method (and stub for non-Windows Cairo implementations).
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): Use GraphicsContext save and restore methods (rather than the Cairo-only functions) so that the Windows device context is kept in sync.
- platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::CairoContextWithHDC): New method to create a valid Cairo context for a given HDC. (WebCore::GraphicsContext::GraphicsContext): Modify constructor to use new CairoContextWithHDC call. (WebCore::GraphicsContext::getWindowsContext): Revise to match behavior of CG implementation. (WebCore::GraphicsContext::releaseWindowsContext): Revise to match behavior of CG implementation. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Get rid of incorrect new HDC, and use object's HDC member for dealing with concatCTM operations. (WebCore::GraphicsContextPlatformPrivate::syncContext): New method to sync Windows HDC with Cairo context.
- platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::getHBITMAPOfSize): Revise implementation to match CG behavior.
- 11:24 AM Changeset in webkit [44538] by
-
- 12 edits in trunk
WebCore:
2009-06-09 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Bug 26196: Fix the problem that worker's importScripts fails if the
script URL is redirected from different origin.
https://bugs.webkit.org/show_bug.cgi?id=26196
Test: http/tests/workers/worker-importScripts.html
The fix is to pass an additional enum parameter to the loader in
order to tell it to perform the redirect origin check or not.
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create): (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::willSendRequest):
- loader/DocumentThreadableLoader.h:
- loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::create): (WebCore::ThreadableLoader::loadResourceSynchronously):
- loader/ThreadableLoader.h: (WebCore::):
- loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
- loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):
LayoutTests:
2009-06-09 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Bug 26196: Fix the problem that worker's importScripts fails if the
script URL is redirected from different origin.
https://bugs.webkit.org/show_bug.cgi?id=26196
Add a test case in the importScripts layout test to cover the scenario
that the import script URL can come from different redirect origin.
- http/tests/workers/resources/worker-importScripts.js:
- http/tests/workers/worker-importScripts-expected.txt:
- 10:09 AM Changeset in webkit [44537] by
-
- 5 edits4 adds in trunk
WebCore:
2009-06-09 Anand K. Mistry <amistry@google.com>
Reviewed by Dimitri Glazkov.
Paint bitmaps with the alpha channel in Skia.
https://bugs.webkit.org/show_bug.cgi?id=26037
Test: fast/canvas/drawImage-with-globalAlpha.html
- platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::getAlpha):
- platform/graphics/skia/PlatformContextSkia.h:
LayoutTests:
2009-06-09 Anand K. Mistry <amistry@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26037
Test the globalAlpha property of canvas contexts.
- fast/canvas/drawImage-with-globalAlpha.html: Added.
- platform/mac/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
- platform/mac/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
- platform/mac/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
- 10:05 AM QtWebKitTodo edited by
- (diff)
- 8:35 AM Changeset in webkit [44536] by
-
- 7 edits in trunk
WebCore
2009-06-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26104
[GTK] Make NetworkRequest a proper GObject and expose SoupMessage
Refactor how SoupMessage is handled, so that our ResourceRequest
object doesn't have to store it as a member, which complicates
managing ResourceRequest's lifetime.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
- platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
WebKit/gtk
2009-06-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26104
[GTK] Make NetworkRequest a proper GObject and expose SoupMessage
Refactor how SoupMessage is handled, so that our ResourceRequest
object doesn't have to store it as a member, which complicates
managing ResourceRequest's lifetime.
- tests/testhttpbackend.c: (navigation_policy_decision_requested_cb): (test_soup_message_lifetime):
- webkit/webkitnetworkrequest.cpp: (WTF::SoupMessage): (webkit_network_request_new_with_core_request):
- 7:31 AM Changeset in webkit [44535] by
-
- 1 edit in trunk/WebKit/qt/ChangeLog
Correct the reviewer in the previous commit.
- 7:29 AM Changeset in webkit [44534] by
-
- 2 edits in trunk/WebKit/qt
2009-06-09 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Fix qdoc warning, function parameter string must be referred.
- Api/qwebview.cpp:
- 6:42 AM QtWebKitTodo edited by
- (diff)
- 6:42 AM QtWebKitTodo edited by
- (diff)
- 6:19 AM QtWebKitTodo edited by
- (diff)
- 5:54 AM QtWebKitTodo edited by
- (diff)
- 5:54 AM Changeset in webkit [44533] by
-
- 3 edits in trunk/WebKit/qt
2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Renamed QWebSettings::AllowUniversalAccessFromFileUrls to
LocalContentCanAccessRemoteUrls, as discussed in the API review.
- 3:53 AM QtWebKitTodo edited by
- (diff)
- 3:51 AM Changeset in webkit [44532] by
-
- 9 edits in trunk
LayoutTests:
2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Adjusted Qt fixed layout testcase to LayoutController API change.
WebKit/qt:
2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Merged useFixedLayout property with fixedLayoutSize and
renamed the latter to fixedContentsSize.
WebKitTools:
2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Removed setUseFixedLayout and renamed setFixedLayoutSize to
setFixedContentsSize.
- 3:51 AM QtWebKitTodo edited by
- (diff)
- 3:51 AM Changeset in webkit [44531] by
-
- 5 edits in trunk/WebKit/qt
2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Renamed QWebHitTestResult::linkTarget to linkElement() and made it return
a QWebElement. The link target itself is always the target DOM attribute.
- 2:10 AM QtWebKitTodo edited by
- (diff)
- 2:00 AM Changeset in webkit [44530] by
-
- 2 edits in trunk/WebKitTools
2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build, add missing function declaration.
- 1:50 AM Changeset in webkit [44529] by
-
- 2 edits in trunk/WebCore
2009-06-09 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build, the time functions moved into the WTF namespace.
- 1:34 AM QtWebKitTodo edited by
- (diff)
- 1:31 AM Changeset in webkit [44528] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Enable JIT_OPTIMIZE_CALL & JIT_OPTIMIZE_METHOD_CALLS on ARMv7 platforms.
These optimizations function correctly with no further changes.
- wtf/Platform.h:
Change to enable JIT_OPTIMIZE_CALL & JIT_OPTIMIZE_METHOD_CALLS.
- 1:20 AM Changeset in webkit [44527] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-09 Gavin Barraclough <barraclough@apple.com>
Not Reviewed, build fix.
- assembler/MacroAssemblerARMv7.h:
- 1:14 AM Changeset in webkit [44526] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Enable JIT_OPTIMIZE_ARITHMETIC on ARMv7 platforms.
Temporarily split support for 'branchTruncateDoubleToInt32' onto its own switch
('supportsFloatingPointTruncate'). See comment in MacroAssemblerARMv7, we need
to work out wherther we are going to be able to support the current interface on
all platforms, or whether this should be refactored.
- assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPoint):
Add implementation of supportsFloatingPointTruncate (returns true).
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
Add implementation of supportsFloatingPointTruncate (returns false).
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::addDouble):
(JSC::MacroAssemblerARMv7::subDouble):
(JSC::MacroAssemblerARMv7::mulDouble):
(JSC::MacroAssemblerARMv7::convertInt32ToDouble):
(JSC::MacroAssemblerARMv7::branchDouble):
Implement FP code genertion operations.
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
Add implementation of supportsFloatingPointTruncate (returns true).
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
Add implementation of supportsFloatingPointTruncate (returns true).
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift):
Changed to call supportsFloatingPointTruncate().
(JSC::JIT::emitSlow_op_rshift):
Changed to call supportsFloatingPointTruncate().
- wtf/Platform.h:
Change to enable JIT_OPTIMIZE_ARITHMETIC.
- 12:46 AM Changeset in webkit [44525] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe & Geoff Garen.
Enable JIT_OPTIMIZE_PROPERTY_ACCESS on ARMv7 platforms.
Firm up interface for planting load intructions that will be repatched by
repatchLoadPtrToLEA(). This method should now no longer be applied to just
any loadPtr instruction.
- assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::loadPtrWithPatchToLEA):
Implement loadPtrWithPatchToLEA interface (plants a load with a fixed width address).
(JSC::MacroAssemblerARMv7::move):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::moveWithPatch):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
Switch to use common method 'moveFixedWidthEncoding()' to perform fixed width (often patchable) loads.
(JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):
Move an immediate to a register, always plants movT3/movt instruction pair.
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::loadPtrWithPatchToLEA):
Implement loadPtrWithPatchToLEA interface (just a regular 32-bit load on x86).
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::loadPtrWithPatchToLEA):
Implement loadPtrWithPatchToLEA interface (just a regular 64-bit load on x86_64).
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id):
- wtf/Platform.h:
Change to enable JIT_OPTIMIZE_PROPERTY_ACCESS.
- 12:33 AM Changeset in webkit [44524] by
-
- 2 edits in trunk/WebKitTools
Fix <https://bugs.webkit.org/show_bug.cgi?id=24642>.
Bug 24642: REGRESSION: Nightly builds sometimes erroneously display a message about failing to launch successfully
Safari 4 on Tiger plays some shenanigans during launch that can confuse the nightly launcher application
in to running its initialization code too soon.
- WebKitLauncher/WebKitNightlyEnabler.m:
(insideSafariOnTigerTrampoline): Detect these shenanigans.
(enableWebKitNightlyBehaviour): Delay initialization when needed.
Jun 8, 2009:
- 11:52 PM Changeset in webkit [44523] by
-
- 8 edits in trunk/JavaScriptCore
2009-06-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Enable JS language JIT for ARM thumb2 platforms. Add ARMv7 specific
asm & constants, add appropriate configuration switches to Platform.h.
Landing this disabled until jump linking is completed (see YARR jit patch).
- assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32):
Fix: should load pointer with ImmPtr not Imm32.
(JSC::MacroAssemblerARMv7::store32):
Fix: should load pointer with ImmPtr not Imm32.
(JSC::MacroAssemblerARMv7::move):
Fix: When moving an Imm32 that is actually a pointer, should call movT3()
not mov(), to ensure code generation is repeatable (for exception handling).
- jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
Disable JIT_OPTIMIZE_NATIVE_CALL specific code generation if the optimization is not enabled.
- jit/JIT.h:
Add ARMv7 specific values of constants & register names.
- jit/JITInlineMethods.h: (JSC::JIT::preverveReturnAddressAfterCall): (JSC::JIT::restoreReturnAddressBeforeReturn): (JSC::JIT::restoreArgumentReferenceForTrampoline):
Implement for ARMv7 (move value to/from lr).
- jit/JITStubs.cpp:
Add JIT entry/thow trampolines, add macro to add thunk wrapper around stub routines.
- jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
Add ARMv7 stack frame object.
- wtf/Platform.h:
Add changes necessary to allow JIT to build on this platform, disabled.
- 11:24 PM Changeset in webkit [44522] by
-
- 12 edits6 deletes in trunk
Revert r44521 as it causes regressions on windows for some reason.
- 11:02 PM Changeset in webkit [44521] by
-
- 12 edits6 adds in trunk
Bug 26249: Support JSON.stringify
<https://bugs.webkit.org/show_bug.cgi?id=26249>
Reviewed by Sam Weinig.
Implement JSON.stringify. This patch handles all the semantics of the ES5
JSON.stringify function, including replacer functions and arrays and both
string and numeric gap arguments.
Currently uses a clamped recursive algorithm basically identical to the spec
description but with a few minor tweaks for performance and corrected semantics
discussed in the es-discuss mailing list.
- 10:27 PM Changeset in webkit [44520] by
-
- 3 edits6 moves in trunk/WebKit
WebKit:
Rubber-stamped by Mark Rowe.
- updated the project after giving Objective-C++ the .mm extension
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
Rubber-stamped by Mark Rowe.
- gave Objective-C++ files the .mm extension
- Carbon/HIWebView.m: Removed.
- Carbon/HIWebView.mm: Copied from WebKit/mac/Carbon/HIWebView.m.
- Misc/WebKitNSStringExtras.m: Removed.
- Misc/WebKitNSStringExtras.mm: Copied from WebKit/mac/Misc/WebKitNSStringExtras.m.
- Misc/WebStringTruncator.m: Removed.
- Misc/WebStringTruncator.mm: Copied from WebKit/mac/Misc/WebStringTruncator.m.
- WebInspector/WebNodeHighlight.m: Removed.
- WebInspector/WebNodeHighlight.mm: Copied from WebKit/mac/WebInspector/WebNodeHighlight.m.
- WebInspector/WebNodeHighlightView.m: Removed.
- WebInspector/WebNodeHighlightView.mm: Copied from WebKit/mac/WebInspector/WebNodeHighlightView.m.
- WebView/WebDynamicScrollBarsView.m: Removed.
- WebView/WebDynamicScrollBarsView.mm: Copied from WebKit/mac/WebView/WebDynamicScrollBarsView.m.
- 10:11 PM Changeset in webkit [44519] by
-
- 15 edits4 adds in trunk
WebCore:
2009-06-08 Brady Eidson <beidson@apple.com>
Reviewed by Antti Koivisto
<rdar://problem/6727495> Repro crash in WebCore::Loader::Host::servePendingRequests() and dupes.
Test: http/tests/loading/deleted-host-in-resource-load-delegate-callback.html
Loader::Host objects were manually managed via new/delete.
There's a variety of circumstances where a Host might've been deleted while it was still in the middle
of a resource load delegate callback.
Changing them to be RefCounted then adding protectors in the callbacks makes this possibility disappear.
At the same time, remove ProcessingResource which was an earlier fix for this same problem that wasn't
fully implemented.
- loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::load): (WebCore::Loader::servePendingRequests): (WebCore::Loader::resumePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): (WebCore::Loader::Host::didReceiveResponse): (WebCore::Loader::Host::didReceiveData):
- loader/loader.h: (WebCore::Loader::Host::create):
WebKitTools:
2009-06-08 Brady Eidson <beidson@apple.com>
Reviewed by Antti Koivisto
Add dispatchPendingLoadRequests() to test fix for <rdar://problem/6727495>
- DumpRenderTree/LayoutTestController.cpp: (dispatchPendingLoadRequestsCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::dispatchPendingLoadRequests): Implement using [WebView _dispatchPendingLoadRequests] SPI
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::dispatchPendingLoadRequests): Need implementations.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::dispatchPendingLoadRequests): Ditto.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::dispatchPendingLoadRequests): Ditto.
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::dispatchPendingLoadRequests): Ditto.
LayoutTests:
2009-06-08 Brady Eidson <beidson@apple.com>
Reviewed by Antti Koivisto
<rdar://problem/6727495> Repro crash in WebCore::Loader::Host::servePendingRequests() and dupes.
Note this "Loader::Host deleted while still in use" could come up in a variety of ways but this layout
test only covers the single most reproducible way we know that *could* be tested by DRT.
- http/tests/loading/deleted-host-in-resource-load-delegate-callback-expected.txt: Added.
- http/tests/loading/deleted-host-in-resource-load-delegate-callback.html: Added.
- http/tests/loading/resources/snow-shoes-vs-pie-copy.png: Added.
- http/tests/loading/resources/snow-shoes-vs-pie.png: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 9:48 PM Changeset in webkit [44518] by
-
- 2 edits in trunk/JavaScriptCore
Speculative GTK build fix.
- wtf/DateMath.cpp:
- 9:20 PM Changeset in webkit [44517] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe.
Previous patch caused a regression.
Restructure so no new (empty, inline) function calls are added on x86.
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::makeWritable): (JSC::ExecutableAllocator::makeExecutable): (JSC::ExecutableAllocator::reprotectRegion): (JSC::ExecutableAllocator::cacheFlush):
- 8:56 PM Changeset in webkit [44516] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-08 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, GTK build fix (thanks, bdash).
- GNUmakefile.am: Moved DateMath with all other wtf kin.
- 8:01 PM Changeset in webkit [44515] by
-
- 13 edits1 copy in trunk/WebCore
2009-06-08 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26126
Refactor methods of WorkerMessagingProxy used to talk to main-thread loader into new interface.
Split a couple of methods used to schedule cross-thread tasks between worker thread and loader thread
implemented on WorkerMessagingProxy into a separate interface so the loading can be implemented in
Chromium's workers.
No changes in functionality so no tests added.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj: Added WorkerLoaderProxy.h to the bulid.
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): WorkerThread::workerObjectProxy() now returns & instead of *
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): same.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): same. (WebCore::WorkerContext::reportException): same. (WebCore::WorkerContext::addMessage): same. (WebCore::WorkerContext::postMessage): same.
- loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy): (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation): Use WorkerLoaderProxy instead of WorkerMessagingProxy for the MainThreadBridge. Mostly rename.
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
In addition to using WorkerLoaderProxy instead of WorkerMessagingProxy, the check for
AskedToTerminate is removed. It seems to be an optimization for a very small number of cases
when worker termination is requested a very short time before the request to load something
(XHR or importScript) was dispatched on the main thread.
- loader/WorkerThreadableLoader.h: Now keeps a pointer to WorkerLoaderProxy rather then to a WorkerMessagingProxy. This allows to implement WorkerThreadableLoader for Chromium.
- workers/WorkerLoaderProxy.h: Added. (WebCore::WorkerLoaderProxy::~WorkerLoaderProxy):
- workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext): (WebCore::WorkerMessagingProxy::postTaskToLoader): Added ASSERT since this needs to be implemented for nested workers.
- workers/WorkerMessagingProxy.h: Derived from WorkerLoaderProxy, the methods for posting tasks cross-thread are now virtual. Removed unused postTaskToWorkerContext() method.
- workers/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread):
- workers/WorkerThread.h: (WebCore::WorkerThread::workerLoaderProxy):
- workers/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
- workers/WorkerThread.h: (WebCore::WorkerThread::workerLoaderProxy): (WebCore::WorkerThread::workerObjectProxy): WorkerThread gets a new member of type WorkerLoaderProxy&, and accessor. Also, existing WorkerObjectProxy* member is now WorkerObjectProxy& because it can't be null.
- 6:40 PM Changeset in webkit [44514] by
-
- 8 edits2 adds in trunk/JavaScriptCore
2009-06-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Add (incomplete) support to YARR for running with the jit enabled
on Arm thumb2 platforms. Adds new Assembler/MacroAssembler classes,
along with cache flushing support, tweaks to MacroAssemblerCodePtr
to support decorated thumb code pointers, and new enter/exit code
to YARR jit for the platform.
Support for this platform is still under development - the assembler
currrently only supports planting and linking jumps with a 16Mb range.
As such, initially commiting in a disabled state.
- JavaScriptCore.xcodeproj/project.pbxproj:
Add new assembler files.
- assembler/ARMv7Assembler.h: Added.
Add new Assembler.
- assembler/AbstractMacroAssembler.h:
Tweaks to ensure sizes of pointer values planted in JIT code do not change.
- assembler/MacroAssembler.h:
On ARMv7 platforms use MacroAssemblerARMv7.
- assembler/MacroAssemblerARMv7.h: Added.
Add new MacroAssembler.
- assembler/MacroAssemblerCodeRef.h: (JSC::FunctionPtr::FunctionPtr):
Add better ASSERT.
(JSC::ReturnAddressPtr::ReturnAddressPtr):
Add better ASSERT.
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
On ARMv7, MacroAssemblerCodePtr's mush be 'decorated' with a low bit set,
to indicate to the processor that the code is thumb code, not traditional
32-bit ARM.
(JSC::MacroAssemblerCodePtr::dataLocation):
On ARMv7, decoration must be removed.
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::makeWritable):
Reformatted, no change.
(JSC::ExecutableAllocator::makeExecutable):
When marking code executable also cache flush it, where necessary.
(JSC::ExecutableAllocator::MakeWritable::MakeWritable):
Only use the null implementation of this class if both !ASSEMBLER_WX_EXCLUSIVE
and running on x86(_64) - on other platforms we may also need ensure that
makeExecutable is called at the end to flush caches.
(JSC::ExecutableAllocator::reprotectRegion):
Reformatted, no change.
(JSC::ExecutableAllocator::cacheFlush):
Cache flush a region of memory, or platforms where this is necessary.
- wtf/Platform.h:
Add changes necessary to allow YARR jit to build on this platform, disabled.
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
Add support to these methods for ARMv7.
- 5:37 PM WebKit Team edited by
- (diff)
- 4:59 PM Changeset in webkit [44513] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-08 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, fix my previous fix.
- runtime/DateInstance.cpp: (JSC::DateInstance::msToGregorianDateTime): Use WTF namespace qualifier to
disambiguate func signatures.
- 4:52 PM Changeset in webkit [44512] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-08 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, another Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 4:48 PM Changeset in webkit [44511] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix the Tiger build.
- wtf/Platform.h: Only test the value of the macro once we know it is defined.
- 4:16 PM Changeset in webkit [44510] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-08 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, projectile-fixing Windows build.
- runtime/DateConversion.cpp: Added StringExtras include.
- wtf/DateMath.cpp: Replaced math with algorithm include (looking for std::min def for Windows).
- 4:01 PM Changeset in webkit [44509] by
-
- 5 edits in trunk/JavaScriptCore
2009-06-08 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, Windows build fix.
- runtime/DateConstructor.cpp: Changed to use WTF namespace.
- runtime/DateConversion.cpp: Added UString include.
- runtime/DateInstance.cpp: Changed to use WTF namespace.
- wtf/DateMath.cpp: Added math include.
- 3:37 PM Changeset in webkit [44508] by
-
- 20 edits2 copies3 moves in trunk
2009-06-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26238
Move most of runtime/DateMath functions to wtf/DateMath, and split off conversion-related
helpers to DateConversion.
- AllInOneFile.cpp: Changed DateMath->DateConversion.
- GNUmakefile.am: Ditto and added DateMath.
- JavaScriptCore.exp: Ditto.
- JavaScriptCore.pri: Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Added DateMath.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- JavaScriptCoreSources.bkl: Ditto.
- pcre/pcre_exec.cpp: Changed to use DateMath.
- profiler/ProfileNode.cpp: (JSC::getCount): Changed to use DateConversion.
- runtime/DateConstructor.cpp: Ditto.
- runtime/DateConversion.cpp: Copied from JavaScriptCore/runtime/DateMath.cpp. (JSC::parseDate): Refactored to use null-terminated characters as input.
- runtime/DateConversion.h: Copied from JavaScriptCore/runtime/DateMath.h.
- runtime/DateInstance.cpp: Changed to use wtf/DateMath.
- runtime/DateInstance.h: Ditto.
- runtime/DateMath.cpp: Removed.
- runtime/DateMath.h: Removed.
- runtime/DatePrototype.cpp: Ditto.
- runtime/InitializeThreading.cpp: Ditto.
- wtf/DateMath.cpp: Copied from JavaScriptCore/runtime/DateMath.cpp.
- wtf/DateMath.h: Copied from JavaScriptCore/runtime/DateMath.h.
WebCore:
2009-06-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26238
Add parseDate helper to HTTPParsers, which uses WTF::parseDateFromNullTerminatedCharacters.
- ForwardingHeaders/runtime/DateMath.h: Removed.
- ForwardingHeaders/wtf/DateMath.h: Copied from WebCore/ForwardingHeaders/runtime/DateMath.h.
- platform/network/HTTPParsers.cpp: (WebCore::parseDate): Added.
- platform/network/HTTPParsers.h:
- platform/network/ResourceResponseBase.cpp: (WebCore::parseDateValueInHeader): Changed to use the new helper.
- 2:43 PM Changeset in webkit [44507] by
-
- 2 edits in tags/Safari-6530.17.1/JavaScriptCore
Merge r44506.
- 2:38 PM Changeset in webkit [44506] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- 2:18 PM Changeset in webkit [44505] by
-
- 1 copy in tags/Safari-6530.17.1
New tag.
- 1:47 PM Changeset in webkit [44504] by
-
- 9 edits in trunk/JavaScriptCore
2009-06-07 David Kilzer <ddkilzer@apple.com>
Make JavaScriptCore compile for iPhone and iPhone Simulator
Reviewed by Gavin Barraclough.
- Configurations/Base.xcconfig: Split GCC_ENABLE_OBJC_GC on $(REAL_PLATFORM_NAME). Added $(ARCHS_UNIVERSAL_IPHONE_OS) to VALID_ARCHS. Added REAL_PLATFORM_NAME_iphoneos, REAL_PLATFORM_NAME_iphonesimulator, HAVE_DTRACE_iphoneos and HAVE_DTRACE_iphonesimulator variables.
- Configurations/DebugRelase.xcconfig: Split ARCHS definition on $(REAL_PLATFORM_NAME).
- Configurations/JavaScriptCore.xcconfig: Added EXPORTED_SYMBOLS_FILE_armv6 and EXPORTED_SYMBOLS_FILE_armv7 variables. Split OTHER_LDFLAGS into OTHER_LDFLAGS_BASE and OTHER_LDFLAGS_$(REAL_PLATFORM_NAME) since CoreServices.framework is only linked to on Mac OS X.
- JavaScriptCore.xcodeproj/project.pbxproj: Removed references to CoreServices.framework since it's linked using OTHER_LDFLAGS in JavaScriptCore.xcconfig.
- profiler/ProfilerServer.mm: Added #import for iPhone Simulator. (-[ProfilerServer init]): Conditionalize use of NSDistributedNotificationCenter to non-iPhone or iPhone Simulator.
- wtf/FastMalloc.cpp: (WTF::TCMallocStats::): Build fix for iPhone and iPhone Simulator.
- wtf/Platform.h: Defined PLATFORM(IPHONE) and PLATFORM(IPHONE_SIMULATOR).
- wtf/ThreadingPthreads.cpp: (WTF::setThreadNameInternal): Build fix for iPhone and iPhone Simulator.
- 10:52 AM Changeset in webkit [44503] by
-
- 5 edits1 add in trunk/WebCore
2009-06-08 Adam Langley <agl@google.com>
Reviewed by Eric Siedel.
Chromium Linux ignored the background color on <select>s. Rather
than encode magic colours, we start with a base color (specified
via CSS) and derive the other colors from it. Thus, setting the
CSS background-color now correctly changes the colour of the
control.
This should not change the appearence controls without
background-colors. However, <select>s with a background-color
will now renderer correctly, which may require rebaselining
pixel tests in the Chromium tree.
https://bugs.webkit.org/show_bug.cgi?id=26030
http://code.google.com/p/chromium/issues/detail?id=12596
- platform/graphics/Color.cpp: (WebCore::Color::getHSL): new member
- platform/graphics/Color.h:
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::systemColor): (WebCore::brightenColor): (WebCore::paintButtonLike):
- 10:19 AM Changeset in webkit [44502] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-08 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26240
[GTK] Try again button loses query strings
Only trigger reload, when try again is clicked, this way we do not
lose the query strings, like we did when also triggering a form
submission.
- resources/error.html:
- 9:24 AM Changeset in webkit [44501] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed the name in the ChangeLog
- 9:23 AM Changeset in webkit [44500] by
-
- 2 edits2 adds in trunk/WebCore
2009-06-08 victorw <victorw@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26087
Bug 26087: Removing element in JS crashes Chrome tab if it fired the change event
Fix tab crash caused by destroying the popup list that fired the change event on abandon.
If a popup list is abandoned (press a key to jump to an item
and then use tab or mouse to get away from the select box),
the current code fires a change event in PopupListBox::updateFromElemt().
The JS that listens to this event may destroy the object and cause the
rest of popup list code crashes.
The updateFromElement() is called before abandon() and this causes
the selected index to be discarded after updateFromElement(). From
the code comments, this appears to be the reason why valueChanged is
called in updateFromElement.
Fix the issue by removing the valueChanged call in updateFromElement,
saving the selected index that we should accept on abandon and pass
it to the valueChange in abandon().
A manual test has been added.
- manual-tests/chromium: Added.
- manual-tests/chromium/onchange-reload-popup.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::PopupListBox): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::updateFromElement):
- 8:53 AM Changeset in webkit [44499] by
-
- 2 edits in trunk/WebCore
2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Disable a few warnings on Windows
- 8:53 AM QtWebKitTodo edited by
- (diff)
- 8:51 AM Changeset in webkit [44498] by
-
- 6 edits in trunk/WebKit/qt
2009-06-08 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Renamed QWebElement::enclosingBlock to enclosingBlockElement
and changed the return type to QWebElement, as discussed in
the API review. This API is more generic and through
QWebElement's geometry() it is possible to retrieve the
same information.
- 8:38 AM Changeset in webkit [44497] by
-
- 2 edits in trunk/WebCore
2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Don't enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH on Windows
This define was brought in after refactoring some code from
PluginPackage(Qt|Gtk).cpp into the shared PluginPackage.cpp.
- 8:23 AM QtWebKitTodo edited by
- (diff)
- 8:14 AM QtWebKitTodo edited by
- (diff)
- 8:13 AM QtWebKitTodo edited by
- (diff)
- 8:10 AM QtWebKitTodo edited by
- (diff)
- 7:35 AM Changeset in webkit [44496] by
-
- 6 edits in trunk
2009-06-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Use $QMAKE_PATH_SEP instead of hardcoded / to fix Windows build
- 7:35 AM QtWebKitTodo edited by
- (diff)
- 7:17 AM QtWebKitTodo edited by
- (diff)
- 6:25 AM QtWebKitTodo edited by
- (diff)
- 5:56 AM QtWebKitTodo edited by
- (diff)
- 5:05 AM Changeset in webkit [44495] by
-
- 4 edits in trunk/WebCore
2009-06-08 Laszlo Gombos <Laszlo Gombos>
Reviewed by Ariya Hidayat.
[Qt] Build fix when NETSCAPE_PLUGIN_API support is turned off
https://bugs.webkit.org/show_bug.cgi?id=26244
- WebCore.pro: Define PLUGIN_PACKAGE_SIMPLE_HASH only if NETSCAPE_PLUGIN_API is turned on
- plugins/PluginPackage.cpp: Guard initializeBrowserFuncs()
- plugins/PluginViewNone.cpp: Match guards with PluginView.h
Jun 7, 2009:
- 11:38 PM Changeset in webkit [44494] by
-
- 5 edits in trunk
Revert "2009-06-05 WANG Lu <coolwanglu@gmail.com>"
Revert commit r44479 as we need to workout first what the best option is for adding
optional features like this.
- 9:28 PM Changeset in webkit [44493] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-07 Gavin Barraclough <barraclough@apple.com>
RS by Sam Weinig.
Remove bonus bogus \n from last commit.
- jit/JITStubs.cpp: (JSC::):
- 9:23 PM Changeset in webkit [44492] by
-
- 4 edits in trunk/JavaScriptCore
2009-06-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Change the implementation of op_throw so the stub function always modifies its
return address - if it doesn't find a 'catch' it will switch to a trampoline
to force a return from JIT execution. This saves memory, by avoiding the need
for a unique return for every op_throw.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
JITStubs::cti_op_throw now always changes its return address,
remove return code generated after the stub call (this is now
handled by ctiOpThrowNotCaught).
- jit/JITStubs.cpp: (JSC::):
Add ctiOpThrowNotCaught definitions.
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
Change cti_op_throw to always change its return address.
- jit/JITStubs.h:
Add ctiOpThrowNotCaught declaration.
- 7:19 PM Changeset in webkit [44491] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- fix <rdar://problem/6931661> -[WebView _selectionIsAll] returns YES when the selection is inside a text field.
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): Return false if the selection is in a shadow tree.
- 1:25 PM Changeset in webkit [44490] by
-
- 2 edits in trunk/WebCore
2009-06-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=26106
[GTK] Crashes when you keep a combo open during a page transition, then close it
Hide the combo popup and disconnect from its signals during
PopupMenu destruction to handle this exceptional case with no
crash.
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::menuUnmapped):
- 1:55 AM Changeset in webkit [44489] by
-
- 2 edits in trunk/WebKitTools
Delete the AccessibilityController that we allocated in -init.
Rubber-stamped by Cameron Zwarich.
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate dealloc]):
Jun 6, 2009:
- 10:45 PM Changeset in webkit [44488] by
-
- 2 edits in trunk/WebKitTools
Factor out the code to check whether a library contains a given symbol in to a helper function.
Reviewed by Dan Bernstein.
- Scripts/webkitdirs.pm:
- 10:25 PM Changeset in webkit [44487] by
-
- 8 edits in trunk
Detect when XHTML MP and WCSS are disabled and skip their associated regression tests.
Reviewed by Sam Weinig.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
Remove XHTML MP and WCSS tests from the skipped lists as run-webkit-tests
now treats them like our other optional features and will skip them automatically
when the feature is not compiled in.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 8:09 PM Changeset in webkit [44486] by
-
- 2 edits in trunk/LayoutTests
Unskip two more tests that now pass.
- platform/mac-snowleopard/Skipped:
- 6:38 PM Changeset in webkit [44485] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-06 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26175
[GTK] Download progress notification should be throttled, for the benefit of download managers
Throttle notifications for the 'progress' property of the Download
object, and update documentation to note the fact that this is
being done, and how to get all notifications if you really care
about them.
- webkit/webkitdownload.cpp: (webkit_download_class_init): (webkit_download_received_data):
- 6:10 PM Changeset in webkit [44484] by
-
- 2 edits in trunk/LayoutTests
Unskip some tests now that they pass.
- platform/mac-snowleopard/Skipped:
- 6:10 PM Changeset in webkit [44483] by
-
- 4 edits in trunk
<rdar://problem/6778101> Four SSL-related test failures
Reviewed by Brady Eidson.
With newer versions of CFNetwork we receive a NSURLErrorServerCertificateUntrusted error
code rather than the more specific NSURLErrorServerCertificateHasUnknownRoot that DumpRenderTree
was looking for. Update DumpRenderTree to accommodate the different error code.
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
- platform/mac-snowleopard/Skipped: Unskip the tests.
- 5:20 PM Changeset in webkit [44482] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-06 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6930540>
REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle
Test: fast/css/font-family-builtins.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::identifierForFamily): Fix typo. Fantasy family should be -webkit-fantasy not, -webkit-serif.
LayoutTests:
2009-06-06 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Test for <rdar://problem/6930540>
REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle
- fast/css/font-family-builtins-expected.txt: Added.
- fast/css/font-family-builtins.html: Added.
- 3:17 PM Changeset in webkit [44481] by
-
- 13 edits in trunk
WebCore:
2009-06-06 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Fix for <rdar://problem/6936235>
Need to support StorageEvent.storageArea to meet the Web Storage spec
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::dispatchStorageEvent): Pass the localStorage for the frame being dispatched to.
- storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::dispatchStorageEvent): Ditto, only for sessionStorage.
- storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
- storage/StorageEvent.h: (WebCore::StorageEvent::create): (WebCore::StorageEvent::storageArea):
- storage/StorageEvent.idl: Add storageArea member.
LayoutTests:
2009-06-06 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Update tests for <rdar://problem/6936235>
Need to support StorageEvent.storageArea to meet the Web Storage spec
Test StorageEvent.uri, StorageEvent.source and StorageEvent.storageArea.
- storage/domstorage/localstorage/iframe-events-expected.txt:
- storage/domstorage/localstorage/iframe-events.html:
- storage/domstorage/localstorage/resources/iframe-events-second.html:
- storage/domstorage/sessionstorage/iframe-events-expected.txt:
- storage/domstorage/sessionstorage/iframe-events.html:
- storage/domstorage/sessionstorage/resources/iframe-events-second.html:
- 9:53 AM Changeset in webkit [44480] by
-
- 11 edits in trunk
Reviewed by Anders Carlsson.
Force initialization of the WML variable state, right after the dynamically created WML elements have been added to the tree.
Note that "regular WML" doesn't support JavaScript at all, in a normal WML document WMLDocument::finishedParsing() takes care of that.
Jun 5, 2009:
- 9:49 PM Changeset in webkit [44479] by
-
- 5 edits in trunk
2009-06-05 WANG Lu <coolwanglu@gmail.com>
Reviewed by Jan Alonzo.
[Gtk] WebKit GTK with libsoup won't recognize proxies
https://bugs.webkit.org/show_bug.cgi?id=25263
Added --with-libsoup-gnome (default=no) to enable GNOME-specific
features of libsoup, an important one of which is the proxy-resolver
feature.
- configure.ac:
2009-06-05 WANG Lu <coolwanglu@gmail.com>
Reviewed by Jan Alonzo.
[Gtk] WebKit GTK with libsoup won't recognize proxies
https://bugs.webkit.org/show_bug.cgi?id=25263
If libsoup-gnome is enabled, proper parameters are added when creating
a new soup session, in order to enable GNOME-specific features of
libsoup.
- GNUmakefile.am:
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::createSoupSession):
- 7:54 PM Changeset in webkit [44478] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Rudder stamped by Sam Weinig.
Add missing ASSERT.
- assembler/X86Assembler.h: (JSC::X86Assembler::getRelocatedAddress):
- 7:39 PM Changeset in webkit [44477] by
-
- 5 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Switch storePtrWithPatch to take the initial immediate value as an argument.
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::storePtrWithPatch):
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::storePtrWithPatch):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jsr):
- 5:08 PM Changeset in webkit [44476] by
-
- 5 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove patchLength..tByIdExternalLoadPrefix magic numbers from JIT.h.
These aren't really suitable values to be tracking within common code
of the JIT, since they are not (and realistically cannot) be checked
by ASSERTs, as the other repatch offsets are. Move this functionality
(skipping the REX prefix when patching load instructions to LEAs on
x86-64) into the X86Assembler.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadPtrToLEA):
- assembler/X86Assembler.h: (JSC::X86Assembler::repatchLoadPtrToLEA):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace):
- 4:24 PM Changeset in webkit [44475] by
-
- 3 edits in trunk/WebCore
2009-06-05 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add ononline and onoffline attributes for the <body> element.
- html/HTMLAttributeNames.in: Added ononlineAttr and onofflineAttr.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Map ononlineAttr and onofflineAttr to window event listeners.
- 1:22 PM Changeset in webkit [44474] by
-
- 2 edits in trunk/WebKit/mac
2009-06-05 David Hyatt <hyatt@apple.com>
Reviewed by Mark Rowe.
Update a WebView's active state when it moves to a different window.
- WebView/WebView.mm: (-[WebView viewDidMoveToWindow]):
- 10:43 AM Changeset in webkit [44473] by
-
- 2 edits in trunk/WebKitSite
2009-06-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.com>
Bug 26188: Clarify some of the cases in the coding style guide
Reviewed and tweaked by David Kilzer.
Changed the coding style document to clarify some cases of ambiguity.
- coding/coding-style.html:
- 9:02 AM Changeset in webkit [44472] by
-
- 9 edits in trunk
2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add missing includes of config.h
- 7:53 AM Changeset in webkit [44471] by
-
- 2 edits in trunk/WebCore
2009-06-05 Fumitoshi Ukai <ukai@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26215
Try to fix the Chromium build.
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs): (WebCore::fillNonBMPGlyphs):
- 7:53 AM QtWebKitTodo edited by
- (diff)
- 7:43 AM Changeset in webkit [44470] by
-
- 4 edits in trunk
2009-06-05 Shinichiro Hamaji <hamaji@chromium.org>
Bug 26160: Compile fails in MacOSX when GNU fileutils are installed
Reviewed by Alexey Proskuryakov.
Use /bin/ln instead of ln for cases where this command is used with -h option.
As this option is not supported by GNU fileutils, this change helps users
who have GNU fileutils in their PATH.
- JavaScriptCore.xcodeproj/project.pbxproj:
WebCore:
2009-06-05 Shinichiro Hamaji <hamaji@chromium.org>
Bug 26160: Compile fails in MacOSX when GNU fileutils are installed
Reviewed by Alexey Proskuryakov.
Use /bin/ln instead of ln for cases where this command is used with -h option.
As this option is not supported by GNU fileutils, this change helps users
who have GNU fileutils in their PATH.
- WebCore.xcodeproj/project.pbxproj:
- 7:10 AM Changeset in webkit [44469] by
-
- 1 edit in trunk/WebKit/qt/Api/qwebsettings.cpp
Fix the Qt build after r44413
- 7:00 AM Changeset in webkit [44468] by
-
- 9 edits2 adds in trunk
2009-06-03 Ben Murdoch <benm@google.com>
<https://bugs.webkit.org/show_bug.cgi?id=25710> HTML5 Database stops executing transactions if the URL hash changes while a transaction is open and an XHR is in progress.
Reviewed by Alexey Proskuryakov.
Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading
https://bugs.webkit.org/show_bug.cgi?id=25710
Test: storage/hash-change-with-xhr.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopAllLoaders):
- loader/FrameLoader.h:
- loader/FrameLoaderTypes.h: (WebCore::):
- page/Page.cpp: (WebCore::Page::goToItem):
- WebCore.base.exp:
- 5:12 AM Changeset in webkit [44467] by
-
- 2 edits in trunk/WebCore
2009-06-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Make sure the correct config.h is included when shadow-building
- 5:05 AM Changeset in webkit [44466] by
-
- 2 edits in trunk/WebKitTools
2009-06-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Fix Perl warning when calling chdir with an empty/undefined path
This happened when the included makespec was in the same directory as
the parent makespec, so the relative path between the two was empty.
- 5:03 AM Changeset in webkit [44465] by
-
- 3 edits in trunk/WebCore
2009-06-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Fix Qt build after r44452
- 4:27 AM Changeset in webkit [44464] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add missing changelog for r44462
- 4:24 AM Changeset in webkit [44463] by
-
- 1 edit in trunk/WebCore/WebCore.pro
Fix the Qt build (missing symbols)
- 4:24 AM Changeset in webkit [44462] by
-
- 3 edits1 delete in trunk/WebCore
[Qt] Remove some dead code (MenuEventProxy)
- 3:58 AM Changeset in webkit [44461] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Remove DoubleNotEqual floating point comparison condition for now -
it is not used, and it is unclear the semantics are correct (I think
this comparison would actually give you not-equal-or-unordered, which
might be what is wanted... we can revisit this interface & get it
right when required).
Also, fix asserts in branchArith32 ops. All adds & subs can check
for Signed, multiply only sets OF so can only check for overflow.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32):
- 3:46 AM Changeset in webkit [44460] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Minor tidy up in JITStubs.
- jit/JITStubs.cpp: (JSC::StackHack::StackHack):
- jit/JITStubs.h:
- 3:15 AM Changeset in webkit [44459] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-05 Koen Kooi <koen@dominion.thruhere.net>
Reviewed by Xan Lopez.
Build fix for glib unicode backend.
- wtf/unicode/glib/UnicodeMacrosFromICU.h:
- 2:31 AM Changeset in webkit [44458] by
-
- 2 edits in trunk/WebCore
2009-06-05 Xan Lopez <xlopez@igalia.com>
More build fixes.
- platform/graphics/gtk/GlyphPageTreeNodePango.cpp: (WebCore::GlyphPage::fill):
- 2:19 AM Changeset in webkit [44457] by
-
- 5 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
3 tiny cleanups:
- assembler/MacroAssemblerX86.h:
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::storePtrWithPatch):
store*() methods should take an ImplicitAddress, rather than an Address.
- assembler/X86Assembler.h:
Make patchPointer private.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_ret):
Remove empty line at end of function.
- 2:16 AM Changeset in webkit [44456] by
-
- 4 edits in trunk/WebCore
2009-06-05 Xan Lopez <xlopez@igalia.com>
Fix the GTK+ build.
- GNUmakefile.am:
- platform/graphics/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
- 12:55 AM Changeset in webkit [44455] by
-
- 13 edits in trunk/JavaScriptCore
2009-06-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Encapsulate many uses of void* in the assembler & jit with types that provide
more semantic information. The new types are:
- MacroAssemblerCodePtr - this wraps a pointer into JIT generated code.
- FunctionPtr - this wraps a pointer to a C/C++ function in JSC.
- ReturnAddressPtr - this wraps a return address resulting from a 'call' instruction.
Wrapping these types allows for stronger type-checking than is possible with everything
represented a void*. For example, it is now enforced by the type system that near
calls can only be linked to JIT code and not to C functions in JSC (this was previously
required, but could not be enforced on the interface).
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon): (JSC::AbstractMacroAssembler::CodeLocationCommon::dataLocation): (JSC::AbstractMacroAssembler::CodeLocationCommon::executableAddress): (JSC::AbstractMacroAssembler::CodeLocationCommon::reset): (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadToLEA): (JSC::AbstractMacroAssembler::CodeLocationInstruction::CodeLocationInstruction): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler): (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR): (JSC::AbstractMacroAssembler::CodeLocationLabel::operator!): (JSC::AbstractMacroAssembler::CodeLocationLabel::reset): (JSC::AbstractMacroAssembler::CodeLocationLabel::CodeLocationLabel): (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination): (JSC::AbstractMacroAssembler::CodeLocationJump::relink): (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump): (JSC::AbstractMacroAssembler::CodeLocationCall::relink): (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::relink): (JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall): (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch): (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32): (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch): (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToTrampoline): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::addressForLookup): (JSC::AbstractMacroAssembler::trampolineAt): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization): (JSC::::CodeLocationCommon::instructionAtOffset): (JSC::::CodeLocationCommon::labelAtOffset): (JSC::::CodeLocationCommon::jumpAtOffset): (JSC::::CodeLocationCommon::callAtOffset): (JSC::::CodeLocationCommon::nearCallAtOffset): (JSC::::CodeLocationCommon::dataLabelPtrAtOffset): (JSC::::CodeLocationCommon::dataLabel32AtOffset):
- assembler/MacroAssemblerCodeRef.h: (JSC::FunctionPtr::FunctionPtr): (JSC::FunctionPtr::value): (JSC::FunctionPtr::executableAddress): (JSC::ReturnAddressPtr::ReturnAddressPtr): (JSC::ReturnAddressPtr::value): (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr): (JSC::MacroAssemblerCodePtr::executableAddress): (JSC::MacroAssemblerCodePtr::dataLocation): (JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
- assembler/X86Assembler.h: (JSC::X86Assembler::patchPointerForCall):
- jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
- jit/JITCall.cpp: (JSC::JIT::compileOpCall):
- jit/JITCode.h: (JSC::JITCode::operator !): (JSC::JITCode::addressForCall): (JSC::JITCode::offsetOf): (JSC::JITCode::execute): (JSC::JITCode::size): (JSC::JITCode::HostFunction):
- jit/JITInlineMethods.h: (JSC::JIT::emitNakedCall):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::JITThunks::ctiArrayLengthTrampoline): (JSC::JITThunks::ctiStringLengthTrampoline): (JSC::JITThunks::ctiVirtualCallPreLink): (JSC::JITThunks::ctiVirtualCallLink): (JSC::JITThunks::ctiVirtualCall): (JSC::JITThunks::ctiNativeCallThunk):
- yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::operator!): (JSC::Yarr::RegexCodeBlock::execute):
- 12:51 AM Changeset in webkit [44454] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-05 Antti Koivisto <Antti Koivisto>
Try to unbreak Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 12:36 AM Changeset in webkit [44453] by
-
- 5 edits in trunk/WebCore
2009-06-05 Antti Koivisto <Antti Koivisto>
Try to fix Windows (and possibly other platforms) build.
Restore ResourceResponseBase::lastModifiedDate() and setLastModifiedDate() removed in previous commit.
for now since PluginStream used on some platforms expects them and calculations differ from plain
Last-modified header value.
Also include <wtf/MathExtras.h> to get isfinite().
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate):
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
Jun 4, 2009:
- 11:24 PM Changeset in webkit [44452] by
-
- 13 edits8 adds in trunk
2009-06-03 Antti Koivisto <Antti Koivisto>
Reviewed by Dave Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=13128
Safari not obeying cache header
Export JSC::parseDate()
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
WebCore:
2009-06-03 Antti Koivisto <Antti Koivisto>
Reviewed by Dave Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=13128
Safari not obeying cache header
Implement RFC 2616 cache expiration calculations in WebKit instead of
relying on the networking layer.
- ForwardingHeaders/runtime/DateMath.h: Added.
- WebCore.base.exp:
- loader/Cache.cpp: (WebCore::Cache::revalidationSucceeded):
- loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::isExpired): (WebCore::CachedResource::currentAge): (WebCore::CachedResource::freshnessLifetime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::updateResponseAfterRevalidation): (WebCore::CachedResource::mustRevalidate):
- loader/CachedResource.h:
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::cacheControlContainsNoCache): (WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate): (WebCore::ResourceResponseBase::cacheControlMaxAge): (WebCore::parseDateValueInHeader): (WebCore::ResourceResponseBase::date): (WebCore::ResourceResponseBase::age): (WebCore::ResourceResponseBase::expires): (WebCore::ResourceResponseBase::lastModified): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::compare):
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
LayoutTests:
2009-06-03 Antti Koivisto <Antti Koivisto>
Reviewed by Dave Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=13128
Safari not obeying cache header
Test subresource caching and expiration.
- http/tests/cache: Added.
- http/tests/cache/resources: Added.
- http/tests/cache/resources/cache-simulator.cgi: Added.
- http/tests/cache/resources/subresource-test.js: Added. (frame1.onload): (frame2.onload): (loadTestFrame.scr.onload): (nextTest): (testComplete): (runTests):
- http/tests/cache/resources/test-frame.html: Added.
- http/tests/cache/subresource-expiration-expected.txt: Added.
- http/tests/cache/subresource-expiration.html: Added.
- 10:29 PM Changeset in webkit [44451] by
-
- 14 edits1 copy1 move in trunk/WebKit
WebKit:
2009-06-04 Sam Weinig <sam@webkit.org>
Reviewed by Alice Liu.
Move WebView internal data into WebViewData.h/mm.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-06-04 Sam Weinig <sam@webkit.org>
Reviewed by Alice Liu.
Move WebView internal data into WebViewData.h/mm.
- WebView/WebDelegateImplementationCaching.mm:
- WebView/WebView.mm:
- WebView/WebViewData.h: Copied from mac/WebView/WebViewInternal.h.
- WebView/WebViewData.mm: Copied from mac/WebView/WebViewInternal.mm.
- WebView/WebViewInternal.h:
- WebView/WebViewInternal.mm: Removed.
- 8:45 PM Changeset in webkit [44450] by
-
- 2 edits in trunk/WebCore
2009-06-04 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel.
Bug 26201: Remove superfluous 'if' statements in RenderTable::addChild
https://bugs.webkit.org/show_bug.cgi?id=26201
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): remove superfluous 'if' statements
- 8:31 PM Changeset in webkit [44449] by
-
- 2 edits in trunk/WebCore
2009-06-04 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel.
Bug 26202: add macros for primitive values to simplify CSSStyleSelector::applyProperty
https://bugs.webkit.org/show_bug.cgi?id=26202
- css/CSSStyleSelector.cpp: add HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE[_WITH_VALUE] macros (WebCore::CSSStyleSelector::applyProperty): use new macros
- 8:30 PM Changeset in webkit [44448] by
-
- 3 edits in trunk/WebCore
2009-06-04 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel
Bug 26203: Move parsing of 'attr(X)' values to own method
https://bugs.webkit.org/show_bug.cgi?id=26203
- css/CSSParser.cpp: (WebCore::CSSParser::parseAttr): new method (WebCore::CSSParser::parseContent): use new parseAttr method
- css/CSSParser.h: (WebCore::CSSParser::parseAttr): new method
- 8:25 PM Changeset in webkit [44447] by
-
- 2 edits in trunk/WebCore
2009-06-04 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel.
Bug 26205: RenderTableSection::addChild : correct comment
https://bugs.webkit.org/show_bug.cgi?id=26205
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): correct comment
- 8:22 PM Changeset in webkit [44446] by
-
- 3 edits in trunk/WebCore
2009-06-04 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel.
Bug 26204: RenderBlock : simplify handleSpecialChild, comment correction
https://bugs.webkit.org/show_bug.cgi?id=26204
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleSpecialChild): simplify usage (WebCore::RenderBlock::handlePositionedChild): simplify usage (WebCore::RenderBlock::handleFloatingChild): simplify usage (WebCore::RenderBlock::handleRunInChild): simplify usage (WebCore::RenderBlock::layoutBlock): correct comment (WebCore::RenderBlock::layoutBlockChildren): simplify loop, change call to handleSpecialChild
- rendering/RenderBlock.h: (WebCore::RenderBlock::handleSpecialChild): change signature (WebCore::RenderBlock::handlePositionedChild): change signature (WebCore::RenderBlock::handleFloatingChild): change signature (WebCore::RenderBlock::handleRunInChild): change signature
- 6:27 PM Changeset in webkit [44445] by
-
- 7 edits in trunk
Bug in property caching of getters and setters.
Reviewed by Gavin Barraclough
Make sure that the transition logic accounts for getters and setters.
If we don't we end up screwing up the transition tables so that some
transitions will start incorrectly believing that they need to check
for getters and setters.
- 5:58 PM Changeset in webkit [44444] by
-
- 2 edits in trunk/WebCore
- retry to fix the Tiger build
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::initFontData):
- 5:36 PM Changeset in webkit [44443] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Minor tweak to PatchBuffer, change it so it no longer holds a CodeRef, and instead
holds a separate code pointer and executable pool. Since it now always holds its
own copy of the code size, and to simplify the construction sequence, it's neater
this way.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::finalizeCode): (JSC::AbstractMacroAssembler::PatchBuffer::code): (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization):
- 5:36 PM Changeset in webkit [44442] by
-
- 2 edits in trunk/WebCore
- try to fix the Tiger build
- platform/graphics/SimpleFontData.h:
- 5:26 PM Changeset in webkit [44441] by
-
- 2 edits in trunk/WebCore
- try to fix the Leopard and Tiger builds
- platform/graphics/SimpleFontData.h:
- 5:24 PM Changeset in webkit [44440] by
-
- 2 edits in trunk/WebCore
- try to fix the Windows build
- platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shapeAndPlaceItem):
- 5:11 PM Changeset in webkit [44439] by
-
- 21 edits in trunk/WebCore
Reviewed by Sam Weinig.
- make SimpleFontData's data members private
- rename SimpleFontData's m_font member to m_platformData
- platform/graphics/Font.h: (WebCore::Font::spaceWidth):
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
- platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::platformData): (WebCore::SimpleFontData::spaceWidth): (WebCore::SimpleFontData::adjustedSpaceWidth): (WebCore::SimpleFontData::syntheticBoldOffset): (WebCore::SimpleFontData::spaceGlyph): (WebCore::SimpleFontData::getNSFont): (WebCore::SimpleFontData::getQtFont): (WebCore::SimpleFontData::getWxFont):
- platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance):
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/gtk/FontGtk.cpp: (WebCore::setPangoAttributes):
- platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::setFont):
- platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::setFont):
- platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::adjustGlyphsAndAdvances):
- platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
- platform/graphics/mac/FontMacATSUI.mm: (WebCore::initializeATSUStyle): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize):
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::initFontData): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::checkShapesArabic): (WebCore::SimpleFontData::getCTFont):
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit):
- platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
- platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::setFont):
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::widthForGDIGlyph): (WebCore::SimpleFontData::scriptFontProperties):
- platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
- 4:01 PM Changeset in webkit [44438] by
-
- 2 edits1 add in trunk/WebCore
2009-06-04 Paul Godavari <paul@chromium.org>
Reviewed by Eric Seidel.
Initialize the width of PopupMenuListBox properly for Mac Chromium.
Added a test that works only with this patch applied. The test is
a manual one, since the hit testing infrastructure in the layout
tests sends keyboard and mouse events to the main window and not
the cocoa control that implements the popup up, which means we can't
select items from the popup up.
- manual-tests/select-narrow-width.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::showExternal):
- 3:52 PM Changeset in webkit [44437] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Remove 'JIT_STUB_ARGUMENT_STACK' this is unused and untested.
This just leaves JIT_STUB_ARGUMENT_REGISTER and JIT_STUB_ARGUMENT_VA_LIST.
Since JIT_STUB_ARGUMENT_REGISTER is the sensible configuration on most platforms,
remove this define and make this the default behaviour.
Platforms must now define JIT_STUB_ARGUMENT_VA_LIST to get crazy va_list voodoo,
if they so desire.
(Refactoring of #ifdefs only, no functional change, no performance impact.)
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline):
- jit/JITStubs.cpp: (JSC::):
- jit/JITStubs.h:
- wtf/Platform.h:
- 3:34 PM Changeset in webkit [44436] by
-
- 2 edits in trunk/WebCore
2009-06-04 Brent Fulgham <bfulgham@webkit.org>
Unreviewed Windows build correction.
- WebCore.vcproj/WebCore.vcproj: Add missing 'ReplaceNodeWithSpanCommand.cpp' and 'ReplaceNodeWithSpanCommand.h'
- 3:17 PM Changeset in webkit [44435] by
-
- 10 edits5 adds in trunk
2009-02-03 Eric Seidel <eric@webkit.org>
Reviewed by Justin Garcia.
Make sure execCommand("bold") on <b style="text-decoration: underline">test</b>
only removes the bold and not the underline.
https://bugs.webkit.org/show_bug.cgi?id=23496
Test: editing/execCommand/convert-style-elements-to-spans.html
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleDeclaration.h: (WebCore::CSSStyleDeclaration::isEmpty):
- dom/NamedAttrMap.h: (WebCore::NamedAttrMap::isEmpty):
- editing/ApplyStyleCommand.cpp: (WebCore::isUnstyledStyleSpan): (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes): (WebCore::ApplyStyleCommand::removeCSSStyle): (WebCore::ApplyStyleCommand::applyTextDecorationStyle): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/ApplyStyleCommand.h:
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceNodeWithSpanPreservingChildrenAndAttributes):
- editing/CompositeEditCommand.h:
- editing/RemoveNodePreservingChildrenCommand.cpp: (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
- editing/ReplaceNodeWithSpanCommand.cpp: Added. (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand): (WebCore::swapInNodePreservingAttributesAndChildren): (WebCore::ReplaceNodeWithSpanCommand::doApply): (WebCore::ReplaceNodeWithSpanCommand::doUnapply):
- editing/ReplaceNodeWithSpanCommand.h: Added. (WebCore::ReplaceNodeWithSpanCommand::create):
- 2:51 PM Changeset in webkit [44434] by
-
- 2 edits in trunk/WebCore
2009-06-04 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build fix for Windows Cairo target.
Add missing post-build command to copy history/cf contents
to output directory.
- WebCore.vcproj/WebCore.vcproj: Update Debug_Cairo and Release_Cairo target post-build steps with copy commands.
- 2:51 PM Changeset in webkit [44433] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-04 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam Weinig.
- jit/JITArithmetic.cpp:
Remove some redundant typedefs, unused since arithmetic was added to the MacroAssembler interface.
- 2:31 PM Changeset in webkit [44432] by
-
- 2 edits in trunk/WebCore
2009-06-04 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6854695> Movie controller thumb fails to scale with full page zoom
Account for zoom level when drawing media controller thumb on Windows.
- rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
- 2:00 PM Changeset in webkit [44431] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 1:59 PM Changeset in webkit [44430] by
-
- 1 copy in tags/Safari-6530.17
New tag.
- 1:55 PM Changeset in webkit [44429] by
-
- 10 edits in trunk
WebCore:
2009-06-04 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Move DOM window focus/blur out of SelectionController and into FocusController. Make sure it
fires on the focused frame when the page activation state changes also. This is covered by an existing
layout test (albeit badly). I have modified the test to be correct.
- editing/SelectionController.cpp: (WebCore::SelectionController::setFocused):
- page/FocusController.cpp: (WebCore::FocusController::setFocusedFrame): (WebCore::FocusController::setActive):
WebKit/mac:
2009-06-04 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Remove _updateFocusedStateForFrame, since it's actually not even necessary now that I made
setFocusedFrame get called explicitly from become/ResignFirstResponder. setFocusedFrame does
the work of focusing the selection already.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): (-[WebHTMLView resignFirstResponder]):
- WebView/WebView.mm:
- WebView/WebViewInternal.h:
LayoutTests:
2009-06-04 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Fix the Window focus test to not resign first responder, since that actually made the test
incorrect. An unfocused WebHTMLView's DOM window should not receive focus/blur events when the activation
changes.
Now the test just checks that a first responder WebHTMLView will actually fire focus/blur on the DOM window
as the window gains/loses key.
- fast/dom/Window/window-onFocus.html:
- 1:47 PM Changeset in webkit [44428] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 1:47 PM Changeset in webkit [44427] by
-
- 2 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r44286.
- 1:44 PM Changeset in webkit [44426] by
-
- 1 edit2 adds in trunk/WebCore
2009-06-04 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26148
Adding in empty files to stage the extract of RenderThemeChromiumSkia
from RenderThemeChromiumLinux and RenderThemeChromiumWindows.
- rendering/RenderThemeChromiumSkia.cpp: Added.
- rendering/RenderThemeChromiumSkia.h: Added.
- 1:39 PM Changeset in webkit [44425] by
-
- 3 edits in trunk/WebKitTools
2009-06-04 Darin Adler <Darin Adler>
Reviewed by Tim Hatcher.
Fix crashes due to unbalanced start/stop observer calls.
- DumpRenderTree/mac/DumpRenderTreeWindow.h: Added observingWebView.
- DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow startObservingWebView]): Call stopObservingWebView in case we're already observing some other WebView. Set observingWebView. (-[DumpRenderTreeWindow stopObservingWebView]): Do nothing if observingWebView is already NO. Clear observingWebView.
- 1:07 PM Changeset in webkit [44424] by
-
- 5 edits in trunk/WebCore
2009-06-04 Andrei Popescu <andreip@google.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=25562
Potential crash after ApplicationCacheStorage::storeNewestCache() fails
Fix the crash by checking the return value of cacheStorage().storeNewestCache(this)
in WebCore::ApplicationCacheGroup::checkIfLoadIsComplete. If storeNewestCache failed,
we run the cache failure steps:
- Fire the error events to all pending master entries, as well any other cache hosts currently associated with a cache in this group.
- Disassociate the pending master entries from the failed new cache.
- Reinstate the old "newest cache", if there was one.
We also introduce two other changes:
- a mechanism to rollback storageID changes to the in-memory resource objects when the storing of an ApplicationCache object fails.
- defer removing the pending master entries from the list of pending master entries until the entire load is complete. This matches the HTML 5 spec better. To track if the load is complete we now introduce a counter for those pending master entries that haven't yet finshed downloading.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): initializes the new counter to 0 (WebCore::ApplicationCacheGroup::selectCache): increments the counter when a new pending master entry is added. (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): decrements the counter instead of removing the pending master entry. (WebCore::ApplicationCacheGroup::failedLoadingMainResource): decrements the counter instead of removing the pending master entry. (WebCore::ApplicationCacheGroup::setNewestCache): removes an assertion that no longer holds true. In particular, the newest cache is not necessarily new anymore. We can set an old cache as the new cache. This can happen if we failed to store a newly downloaded cache to the database and we are now reinstating the former newest cache. (WebCore::ApplicationCacheGroup::manifestNotFound): resets the counter to 0. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): check if the loading is complete based on the counter instead of the list of pending master entries. Empty the list of master entries if the load is complete.
- loader/appcache/ApplicationCacheGroup.h: add the new counter.
- loader/appcache/ApplicationCacheStorage.cpp: introduce the journaling mechanism for in-memory resource objects. (WebCore::ResourceStorageIDJournal::~ResourceStorageIDJournal): (WebCore::ResourceStorageIDJournal::add): (WebCore::ResourceStorageIDJournal::commit): (WebCore::ResourceStorageIDJournal::Record::Record): (WebCore::ResourceStorageIDJournal::Record::restore): (WebCore::ApplicationCacheStorage::store): log the changes to the in-memory resource objects. (WebCore::ApplicationCacheStorage::storeNewestCache): create the journal object.
- loader/appcache/ApplicationCacheStorage.h: modify the signature of bool store(ApplicationCache*) to add a pointer to the logger object used to trace the changes to the storageID of the resource objects.
- 12:29 PM Changeset in webkit [44423] by
-
- 2 edits in trunk/WebCore
2009-06-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26154
Allow underscores in the hostnames we parse out of databaseIdentifiers.
This code is used for HTML 5 database support.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
- 11:44 AM Changeset in webkit [44422] by
-
- 2 edits1 add in trunk/WebCore
2009-06-04 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Darin Adler.
Bug 26084: Multiple missing images in webkit-mask-image prevent rendering
https://bugs.webkit.org/show_bug.cgi?id=26084
When painting multiple images, make sure that at least one image is valid before pushing a transparency layer.
Added a manual test.
- manual-tests/mask-composite-missing-images.html: Added.
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages):
- 11:40 AM Changeset in webkit [44421] by
-
- 2 edits in trunk/WebKit/mac
- build fix
- WebView/WebViewInternal.mm:
- 11:34 AM Changeset in webkit [44420] by
-
- 2 edits in trunk/WebCore
2009-06-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26180
Add a fast path for SecurityOrigin::equal. If "other == this" (where
other is the other security origin), then we really don't need to do
all the other (expensive) comparisons. We know it's equal.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::equal):
- 11:03 AM Changeset in webkit [44419] by
-
- 3 edits in trunk/LayoutTests
2009-06-05 Dmitry Titov <dimich@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26192
Fix the expected results for editing/execCommand/list-wrapping-image-crash.html
- editing/execCommand/list-wrapping-image-crash-expected.txt:
- editing/execCommand/list-wrapping-image-crash.html:
- 10:44 AM Changeset in webkit [44418] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-04 Brent Fulgham <bfulgham@webkit.org>
Build fix due to header include problem.
- interpreter/Interpreter.h: Remove wtf from includes so that compile can find the headers in expected places.
- 10:30 AM Changeset in webkit [44417] by
-
- 4 edits in trunk/JavaScriptCore
2009-06-04 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
HashTable class (JavaScriptCore/wtf/HashTable.h) doesn't instantiated by 'new', so
inheritance was removed. HashTable struct has been instantiated by operator new in
JSGlobalData.cpp:106.
HashTable couldn't inherited from FastAllocBase since struct with inheritance is
no longer POD, so HashTable struct has been instantiated by fastNew, destroyed by
fastDelete.
- interpreter/Interpreter.h:
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData):
- wtf/HashTable.h:
- 9:16 AM Changeset in webkit [44416] by
-
- 16 edits in trunk
WebCore:
2009-06-03 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Improvements in how selection behaves with focus/activation and a reversion back to using isActive
in the scrollbar theme code to remove a Chromium ifdef.
- editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Make the controller set its focused state correctly upon initial creation.
(WebCore::SelectionController::setSelection):
Make selection willing to shift the focus node if the selection is focused even if the
selection is not active. Whether or not the Page is active is irrelevant to focus changes.
(WebCore::SelectionController::setFocused):
- editing/SelectionController.h: (WebCore::SelectionController::isFocused): Add a new isFocused() method so that code can check if the Selection is focused without caring about the active state.
- page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Allow focus shifts even when the selection is not active.
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Revert Dan's change to directly talk to AppKit for checking active state. Now that the WebCore isActive method works, ditch the Chromium-specific #ifdef and go back to the original code.
WebKit/mac:
2009-06-03 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Reworking of focus and active state updating for WebHTMLViews so that it actually works instead of reporting wrong answers.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): WebHTMLViews become first responders before they are able to reach their Frames/Pages. This happens because the NSClipView becomes first responder when the WebHTMLView gets destroyed, and then we transfer the responder state back to the new WebHTMLView when it is first connected. Once we have transitioned to a new page and have the Frame/Page available, go ahead and explicitly focus the frame in WebCore and update our focused state. This change allows us to remove the updateFocusedActive timer and the code from viewDidMoveToWindow.
- WebView/WebHTMLView.mm: (-[WebHTMLView close]): (-[WebHTMLView addWindowObservers]): (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]): (-[WebHTMLView _removeWindowObservers]): Remove all the updateFocusedActiveState timer code, since it no longer exists.
(-[WebHTMLView windowDidBecomeKey:]):
(-[WebHTMLView windowDidResignKey:]):
Active state updating is no longer done by WebHTMLViews. It is handled by the WebView instead.
(-[WebHTMLView becomeFirstResponder]):
(-[WebHTMLView resignFirstResponder]):
Reworking of WebHTMLView's code for gaining/losing responder status. No longer update active state here, since the active state
can never change just because of responder changes. Make sure that the focused frame gets updated properly (and most importantly
actually cleared when a WebHTMLView resigns responder status).
- WebView/WebHTMLViewInternal.h:
- WebView/WebHTMLViewPrivate.h: State updating for focused and active states has been made independent.
- WebView/WebView.mm: (-[WebView _updateActiveState]): WebView now handles updating of active state in _updateActiveState. It is now purely based off whether the window is key and nothing else.
(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
Start listening for the window becoming/losing key even in the usesDocumentViews case.
(-[WebView _updateFocusedStateForFrame:]):
Focused state updating is split into its own method now and called when WebHTMLViews gain and lose responder status.
(-[WebView _windowDidBecomeKey:]):
(-[WebView _windowDidResignKey:]):
Make sure to call _updateActiveState as the window gains/loses key.
(-[WebView _windowWillOrderOnScreen:]):
Run this code now that WebHTMLView no longer does it.
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h: Updating for the split of focused and active state updating into separate methods.
WebKitTools:
2009-06-03 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMainFrameIsFirstResponder): Remove explicit calls to _updateFocusedActiveState when the view is made first responder. Focused state already properly updates when views become first responders, so these calls are unnecessary.
(LayoutTestController::setWindowIsKey):
Explicitly call _updateActiveState when our window becomes key, since we're just faking it
and the notification won't be sent.
- 9:04 AM Changeset in webkit [44415] by
-
- 3 edits2 adds in trunk
2009-06-04 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Darin Adler.
Test: media/before-load-member-access.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::played): Ensure that if m_playedTimeRanges, is not initialized we return a valid range, and don't attempt to use it.
2009-06-04 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Darin Adler.
- media/before-load-member-access-expected.txt: Added.
- media/before-load-member-access.html: Test access for property accessed before loading occurs. That tests for 26081 crasher specifically.
- 8:11 AM Changeset in webkit [44414] by
-
- 1 edit1 add in trunk/LayoutTests
2009-06-04 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Added Qt-specific expected result for Canvas pointInPath's test.
Qt's QPainterPath::contains(point) returns false if the point is
exactly along one of the edges (except the origin). Until we
find a workaround for this, compensate it in the expected result.
- platform/qt/fast/canvas/pointInPath-expected.txt: Added.
- 5:44 AM Changeset in webkit [44413] by
-
- 5 edits in trunk
2009-06-03 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Add API to make it possible to clear all memory caches used by
QtWebKit.
- Api/qwebsettings.cpp: (QWebSettings::clearMemoryCaches):
- Api/qwebsettings.h:
2009-06-03 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Implement a way to invalidate the FontCache used by the Qt port.
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::invalidate):
- 4:00 AM Changeset in webkit [44412] by
-
- 8 edits in trunk/JavaScriptCore
2009-06-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Wrap the code that plants pushes/pops planted by JIT in explanatorily named
methods; move property storage reallocation into a standard stub function.
~No performance impact (possible <1% progression on x86-64, likely just noise).
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
Wrap calls to push/pop.
- jit/JIT.h:
Declare the new wrapper methods.
- jit/JITInlineMethods.h: (JSC::JIT::preverveReturnAddressAfterCall): (JSC::JIT::restoreReturnAddressBeforeReturn):
Define the new wrapper methods.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_ret):
Wrap calls to push/pop.
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
Move property storage reallocation into a standard stub function.
- jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::JITStubs::):
- 1:58 AM Changeset in webkit [44411] by
-
- 4 edits in trunk
2009-06-04 Laszlo Gombos <Laszlo Gombos>
Reviewed by Ariya Hidayat.
[Qt] Single-threaded QtWebKit configuration
Turn off Database, DOM storage, icon database and Web Workers support
when ENABLE_SINGLE_THREADED is turned on.
Set SQLITE_THREADSAFE to false to turn off SQLite mutexes
when ENABLE_SINGLE_THREADED is turned on.
- WebCore.pro:
- 1:22 AM Changeset in webkit [44410] by
-
- 2 edits in trunk/WebKit/mac
Speculative Tiger build fix.
Jun 3, 2009:
- 8:32 PM Changeset in webkit [44409] by
-
- 5 edits2 copies in trunk/WebKit
WebKit:
2009-06-03 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Added WebDelegateImplementationCaching.h/mm
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-06-03 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Move delegate implementation caching logic into its own files.
- WebView/WebDelegateImplementationCaching.h: Copied from mac/WebView/WebViewInternal.h.
- WebView/WebDelegateImplementationCaching.mm: Copied from mac/WebView/WebView.mm. (WebViewGetResourceLoadDelegateImplementations): (WebViewGetFrameLoadDelegateImplementations): (WebViewGetScriptDebugDelegateImplementations):
- WebView/WebView.mm:
- WebView/WebViewInternal.h:
- 8:30 PM Changeset in webkit [44408] by
-
- 4 edits in trunk/WebCore
Reviewed by Sam Weinig.
- add some assertions that Font methods are used on the main thread
- platform/graphics/Font.cpp: (WebCore::Font::setShouldUseSmoothing):
- platform/graphics/Font.h: (WebCore::Font::primaryFont):
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
- 7:39 PM Changeset in webkit [44407] by
-
- 5 edits1 add in trunk/WebKit
WebKit:
2009-06-03 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add WebViewInternal.mm.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-06-03 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Move WebViewPrivate structure to WebViewInternal.h/mm.
- WebView/WebView.mm:
- WebView/WebViewInternal.h:
- WebView/WebViewInternal.mm: Added. (+[WebViewPrivate initialize]): (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebViewPrivate finalize]):
- 6:13 PM Changeset in webkit [44406] by
-
- 2 edits in trunk/WebKit/mac
2009-06-03 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Small cleanup in WebView.
- Move global data initialization to WebView's initialization method.
- Move _clearViewUpdateRunLoopObserver from WebViewPrivate to WebView (FileInternal)
- WebView/WebView.mm: (-[WebViewPrivate init]): Remove global initializers. (-[WebViewPrivate dealloc]): Cleanup whitespace. (-[WebViewPrivate finalize]): Ditto. (-[WebView _close]): Call [self _clearViewUpdateRunLoopObserver] instead of [_private _clearViewUpdateRunLoopObserver] (+[WebView initialize]): Move global initializers here. (-[WebView _clearViewUpdateRunLoopObserver]): Moved from WebViewPrivate. (viewUpdateRunLoopObserverCallBack): Call [self _clearViewUpdateRunLoopObserver] instead of [_private _clearViewUpdateRunLoopObserver]
- 5:11 PM Changeset in webkit [44405] by
-
- 2 edits in trunk/WebCore
- Windows build fix
Rolled out apparently-accidental changes to config.h from r44398. These
were not part of the patch as reviewed.
- config.h:
- 5:07 PM Changeset in webkit [44404] by
-
- 3 edits in trunk/WebCore
2009-06-03 Dmitry Titov <dimich@chromium.org>
Not reviewed, Chromium build fix.
https://bugs.webkit.org/show_bug.cgi?id=26177
Reverting 'private' to 'protected' on 2 classes.
Chromium glue layer (not yet in Webkit tree) relies on ability to derive
Chromium-specific platform classes and access the data members.
See bug for more details.
- platform/PlatformMouseEvent.h:
- platform/PlatformWheelEvent.h:
- 4:37 PM Changeset in webkit [44403] by
-
- 3 edits1 add in trunk/WebCore
Reviewed by Simon Fraser <simonfr@apple.com>.
This corrects an error when destroying an animation
or transition where endAnimation was never getting
called and therefore the hardware animation was never
getting removed.
This includes a manual-test since it's really impossible
to make a meaningful automatic test for an animation
bug like this.
This has no effect unless accelerated compositing is
enabled.
- 4:12 PM Changeset in webkit [44402] by
-
- 2 edits in trunk/WebKit/wx
wx build fix, remove no longer needed function call.
- 4:08 PM Changeset in webkit [44401] by
-
- 3 edits in trunk/WebCore
2009-06-03 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Make the scrollbar thumb size twice the width for Chromium Linux. This
matches Firefox on Linux.
This will need layout test pixel results to be rebaselined in the
Chromium tree.
http://code.google.com/p/chromium/issues/detail?id=12602
https://bugs.webkit.org/show_bug.cgi?id=26176
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
- platform/chromium/ScrollbarThemeChromiumLinux.h:
- 3:46 PM Changeset in webkit [44400] by
-
- 5 edits1 copy1 add in trunk/WebCore
2009-06-03 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Change Chromium scrollbar theme code to use different classes on
Windows and Linux rather than suppling symbols. The ScrollbarTheme
class is already using virtual dispatch, so there's no reason not to.
This should not affect any layout tests.
- platform/chromium/ScrollbarThemeChromium.cpp:
- platform/chromium/ScrollbarThemeChromium.h:
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
- platform/chromium/ScrollbarThemeChromiumLinux.h: Added.
- platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit): (WebCore::ScrollbarThemeChromiumWin::shouldSnapBackToDragOrigin): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::getThemeState): (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState): (WebCore::ScrollbarThemeChromiumWin::getClassicThemeState): (WebCore::ScrollbarThemeChromiumWin::buttonSize):
- platform/chromium/ScrollbarThemeChromiumWin.h: Added.
- 3:45 PM Changeset in webkit [44399] by
-
- 2 edits in trunk/WebKit/win
2009-06-03 Brent Fulgham <bfulgham@webkit.org>
Build fix for Windows Cairo.
- WebKit.vcproj/WebKit.vcproj: Remove unneeded giflib.lib link command.
- 3:32 PM Changeset in webkit [44398] by
-
- 10 edits in trunk/WebCore
2009-06-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Enabling debugger requires that Scripts panel is already attached to the
render tree. The reason is that recompile events result in script sources
being added into the source frames. Prior to the global options introduced,
debugger was enabled from the Scripts panel, so that it was guaranteed to
exist. The InspectorController::enableDebugger API calls with no inspector
frontend showing were failing though.
- WebCore.base.exp:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::enableDebugger):
- inspector/InspectorController.h:
- inspector/InspectorController.idl:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::attachDebuggerWhenShown):
- inspector/InspectorFrontend.h:
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
- inspector/front-end/inspector.js: (WebInspector.attachDebuggerWhenShown):
- 3:31 PM Changeset in webkit [44397] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
2009-06-03 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add back known this value optimization by abstracting
slow case if not JSCell jumps.
- jit/JIT.h:
- jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCallVarargsSlowCase): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::emitJumpSlowCaseIfNotJSCell): (JSC::JIT::linkSlowCaseIfNotJSCell):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id):
- 3:10 PM Changeset in webkit [44396] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
- fix a regression from the previous patch
- platform/graphics/Font.cpp: Initialize shouldUseFontSmoothing to true.
- 3:03 PM Changeset in webkit [44395] by
-
- 13 edits2 deletes in trunk
WebCore:
Reviewed by Anders Carlsson.
- eliminate WebCoreTextRenderer
- WebCore.base.exp: Updated.
- WebCore.xcodeproj/project.pbxproj: Removed WebCoreTextRenderer.{h,mm}
and promoted WebFontCache.h to private.
- platform/graphics/Font.cpp: (WebCore::Font::setShouldUseSmoothing): Added this static setter for
a new file-static boolean.
(WebCore::Font::shouldUseSmoothing): Added this static getter.
- platform/graphics/Font.h: Decleared setShouldUseSmoothing() and
shouldUseSmoothing().
- platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs): Use Font::shouldUseSmoothing() instead of WebCoreShouldUseFontSmoothing().
- platform/graphics/mac/WebLayer.mm: Removed unneeded #import.
- platform/mac/WebCoreTextRenderer.h: Removed.
- platform/mac/WebCoreTextRenderer.mm: Removed.
WebKit:
Reviewed by Anders Carlsson.
- WebKit project part of eliminating WebCoreTextRenderer
- WebKit.xcodeproj/project.pbxproj: Changed WebKitNSStringExtras.m to
compile as Objective-C++.
WebKit/mac:
Reviewed by Anders Carlsson.
- WebKit part of eliminating WebCoreTextRenderer
- Misc/WebKitNSStringExtras.m: (webkit_CGCeiling): Added. (-[NSString _web_drawAtPoint:font:textColor:]): Replaced the malloc()ed
string buffer with a Vector. Moved code from
WebCoreDrawTextAtPoint() to here.
(-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]):
(-[NSString _web_widthWithFont:]): Replaced the malloc()ed string buffer
with a Vector. Moved code from WebCoreTextFloatWidth() to here.
- WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]): Replaced call to
WebCoreFindFont() with use of
+[WebFontCache fontWithFamily:traits:weight:size:].
- WebView/WebView.mm: (+[WebView _setAlwaysUsesComplexTextCodePath:]): Changed to call
Font::setCodePath() directly.
(+[WebView _setShouldUseFontSmoothing:]): Changed to call
Font::setShouldUseSmoothing().
(+[WebView _shouldUseFontSmoothing]): Changed to call
Font::shouldUseSmoothing().
- 2:11 PM Changeset in webkit [44394] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 2:09 PM Changeset in webkit [44393] by
-
- 1 copy in tags/Safari-6530.15
New tag.
- 2:05 PM Changeset in webkit [44392] by
-
- 2 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r44356.
- 1:32 PM Changeset in webkit [44391] by
-
- 2 edits in trunk/WebCore
2009-06-03 David Levin <levin@chromium.org>
Reviewed by Dimitri Glazkov.
v8's ScriptController::evaluate should protect the Frame like the jsc version.
https://bugs.webkit.org/show_bug.cgi?id=26172
This change is simply copying protections done for Frame in the method
WebCore::ScriptController::evaluate in the file js/ScriptController.cpp.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- 1:17 PM Changeset in webkit [44390] by
-
- 3 edits in trunk/WebKit/mac
Rubber-stamped by Mark Rowe.
- remove a private method that was used only by Safari 3.0.
- WebView/WebView.mm: Removed +_minimumRequiredSafariBuildNumber.
- WebView/WebViewPrivate.h: Ditto.
- 11:24 AM Changeset in webkit [44389] by
-
- 3 edits in trunk/WebCore
Reviewed by John Sullivan.
- fix <rdar://problem/6841120> Use CTFontManager notifications instead of ATS notifications
- platform/graphics/FontCache.h: Made it an error to destroy a FontCache instance.
- platform/graphics/mac/FontCacheMac.mm: (WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Added this notification callback for the kCTFontManagerRegisteredFontsChangedNotification, which calls invalidate(). (WebCore::FontCache::platformInit): Register for kCTFontManagerRegisteredFontsChangedNotification.
- 11:10 AM Changeset in webkit [44388] by
-
- 2 edits in trunk/WebKit/mac
- build fix
- WebView/WebHTMLView.mm:
- 10:07 AM Changeset in webkit [44387] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Use CGContextShowGlyphsWithAdvances to get more accurate text rendering on Mac.
https://bugs.webkit.org/show_bug.cgi?id=26161
- 9:43 AM Changeset in webkit [44386] by
-
- 2 edits in trunk/WebCore
2009-06-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Reorder ResourcesPanel components initialization to unfreeze resource list scroller.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):
- 9:41 AM Changeset in webkit [44385] by
-
- 3 edits in trunk/WebCore
2009-06-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
- Fix for crash (preceded by assertion) in InspectorController::didCommitLoad when reloading or navigating with the Inspector open.
- Fix for Inspector's Elements panel being empty when Inspector first appears.
https://bugs.webkit.org/show_bug.cgi?id=26134
https://bugs.webkit.org/show_bug.cgi?id=26135
- inspector/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded):
- inspector/InspectorController.h:
- 9:35 AM Changeset in webkit [44384] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
- build fix
- WebView/WebHTMLView.mm:
- WebView/WebView.mm:
- 8:29 AM Changeset in webkit [44383] by
-
- 2 edits in trunk/WebCore
Windows build fix after r44379
- svg/graphics/SVGImage.cpp: Move EmptyClients.h back down below the other #includes to fix a compiler warning on Windows.
- 7:22 AM Changeset in webkit [44382] by
-
- 2 edits in trunk/WebCore
2009-06-02 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Add workaround for crash in Linux Flash Player when hosted by
another toolkit than GTK+. Bug fixed at the Flash Player bugzilla,
issue (FP-2140).
- 7:21 AM Changeset in webkit [44381] by
-
- 5 edits1 add in trunk/WebCore
2009-06-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Refactor the Qt plugin code to use NPP_SetWindow correctly,
to make resizing of plugins work.
Attention was paid to make sure that the windowed plugins scroll
synchronized with the page view. A manual test has been added.
- 12:33 AM Changeset in webkit [44380] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
Fix appcache/fallback.html test broken by network simulator changes made for a preloading test.
- http/tests/resources/network-simulator.php: Tell PHP that a variable is global.
Jun 2, 2009:
- 10:37 PM Changeset in webkit [44379] by
-
- 41 edits in trunk
WebCore:
2009-06-02 Darin Adler <Darin Adler>
Reviewed by David Hyatt.
Bug 26112: viewless WebKit -- make events work
https://bugs.webkit.org/show_bug.cgi?id=26112
The main fix here is to make mouse and wheel event coordinates in the coordinate
system of the top level NSView rather than the NSWindow when in the viewless mode.
This is the design Hyatt chose, but the event part of it wasn't done yet.
Also fix FrameView to do normal reference counting instead of a strange model with
an explicit deref near creation time.
- WebCore.base.exp: Updated.
- page/EventHandler.cpp: (WebCore::EventHandler::eventLoopHandleMouseUp): Moved this function into the file to reduce conditionals in the header. (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.
- page/EventHandler.h: Reduced includes. Fixed formatting of Objective-C types. Made currentNSEvent a static member function. Added sendContextMenuEvent and eventMayStartDrag functions that takes NSEvent * so the conversion to PlatformMouseEvent can be done here rather than in WebKit. Reduced #if by making eventLoopHandleMouseUp and eventLoopHandleMouseDragged unconditional.
- page/Frame.cpp: (WebCore::Frame::setView): Made this take a PassRefPtr since it takes ownership. (WebCore::Frame::createView): Changed to use RefPtr and FrameView::create and remove the explicit deref.
- page/Frame.h: Changed setView to take a PassRefPtr.
- page/FrameTree.cpp: Added newly-needed include.
- page/FrameView.cpp: (WebCore::FrameView::FrameView): Got rid of one of the two constructors, and removed the initialization of m_refCount and call to show from the reamining one. (WebCore::FrameView::create): Added two create functions that do what the two constructors did before, except that they return a PassRefPtr to make sure the reference counting is handled correctly. (WebCore::FrameView::~FrameView): Removed assertion from when FrameView implemented its own reference counting.
- page/FrameView.h: Inherit from RefCounted for reference counting. Made the constructor private and added create functions. Got rid of the hand-implemented reference counting in this class.
- page/mac/EventHandlerMac.mm: (WebCore::currentNSEventSlot): Renamed currentEvent to currentNSEventSlot to make it more clear how it relates to currentNSEvent. (WebCore::EventHandler::currentNSEvent): Updated. (WebCore::CurrentEventScope::CurrentEventScope): Added. Use to set/reset the current event in a foolproof way. (WebCore::CurrentEventScope::~CurrentEventScope): Ditto. (WebCore::EventHandler::wheelEvent): Use CurrentEventScope. Pass the platform window in when constructing the PlatformWheelEvent. (WebCore::EventHandler::keyEvent): Use CurrentEventScope. (WebCore::lastEventIsMouseUp): Use currentNSEvent. (WebCore::EventHandler::passMouseDownEventToWidget): Ditto. (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto. (WebCore::EventHandler::eventLoopHandleMouseUp): Ditto. (WebCore::EventHandler::passSubframeEventToSubframe): Use currentPlatformMouseEvent to get a mouse event that has the appropriate platform window passed to create it. (WebCore::EventHandler::passWheelEventToWidget): Ditto. (WebCore::EventHandler::mouseDown): Ditto. (WebCore::EventHandler::mouseDragged): Ditto. (WebCore::EventHandler::mouseUp): Ditto. (WebCore::EventHandler::mouseMoved): Ditto. (WebCore::EventHandler::currentPlatformMouseEvent): Added. Passes the platform window that's now needed to create a PlatformMouseEvent. (WebCore::EventHandler::sendContextMenuEvent): Added. (WebCore::EventHandler::eventMayStartDrag): Added.
- platform/HostWindow.h: Removed unneeded includes and constructor definition.
- platform/PlatformMouseEvent.h: Sorted things in alphabetical order. Changed Mac constructor to take a windowView as well as the event. This is needed in viewless mode, since the "window" is actually an NSView, so the event has to know which view to compute the coordinates with. Made the same change to pointForEvent.
- platform/PlatformWheelEvent.h: Ditto.
- platform/mac/PlatformMouseEventMac.mm: (WebCore::pointForEvent): Convert point from window coordinates to view coordinates if a windowView is passed in. This is used in viewless mode. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Ditto.
- platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Ditto.
- platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromContainingWindow): Fixed case where there is no platform widget and no parent. Before it would yield unpredictable results because of dispatching to a nil object and returning a structure. Now it returns the point without changing coordinates at all, which is what we need for this case in viewless mode.
- rendering/RenderApplet.cpp: Removed unneeded includes. (WebCore::RenderApplet::intrinsicSize): Use widget function. (WebCore::RenderApplet::createWidgetIfNecessary): Ditto.
- rendering/RenderApplet.h: Make more things private. Get rid of unneeded explicit destructor.
- rendering/RenderFrame.cpp: Removed unneeded includes. (WebCore::RenderFrame::edgeInfo): Updated to use node function so header doesn't have to define element function. (WebCore::RenderFrame::viewCleared): Ditto. Also changed to use widget function.
- rendering/RenderFrame.h: Removed unneeded includes. Made some things private. Got rid of element function.
- rendering/RenderPart.cpp: Removed unneeded includes. (WebCore::RenderPart::~RenderPart): Changed to use clearWidget function. (WebCore::RenderPart::setWidget): Changed to use widget function. (WebCore::RenderPart::deleteWidget): Changed to use passed-in widget. This is now only called by the clearWidget function.
- rendering/RenderPart.h: Removed unneeded forward declarations. Made more functions private. Updated deleteWidget to take widget argument.
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::~RenderPartObject): use frameView function instead of getting at m_view directly. (WebCore::RenderPartObject::updateWidget): Ditto. (WebCore::RenderPartObject::layout): Ditto. Same for widget and m_widget. (WebCore::RenderPartObject::viewCleared): Ditto.
- rendering/RenderPartObject.h: Made some functions private.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::RenderWidget): Initialize m_frameView with construction syntax instead of assignment. (WebCore::RenderWidget::destroy): Updated for name change of m_view to m_frameView. (WebCore::RenderWidget::~RenderWidget): Use clearWidget to delete the widget. (WebCore::RenderWidget::setWidget): Use clearWidget. (WebCore::RenderWidget::paint): Updated for name change of m_view to m_frameView. (WebCore::RenderWidget::deleteWidget): Changed to use passed-in widget.
- rendering/RenderWidget.h: Made many functions protected, others private and made all data members private.
- svg/animation/SMILTime.h: Removed unhelpful max and min functions. These just do what std::max and std::min will already do automatically for this type, so they are not helpful.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::SVGImage): Removed unneeded initial values for types that initialize to zero without anything explicit. (WebCore::SVGImage::~SVGImage): Update since m_frame and m_frameView are no longer stored. (WebCore::SVGImage::setContainerSize): Ditto. (WebCore::SVGImage::usesContainerSize): Ditto. (WebCore::SVGImage::size): Ditto. (WebCore::SVGImage::hasRelativeWidth): Ditto. (WebCore::SVGImage::hasRelativeHeight): Ditto. (WebCore::SVGImage::draw): Ditto. (WebCore::SVGImage::nativeImageForCurrentFrame): Ditto. (WebCore::SVGImage::dataChanged): Ditto.
- svg/graphics/SVGImage.h: Removed unneeded includes and unneeded data members m_document, m_frame, m_frameView, and m_minSize.
WebKit/mac:
2009-06-02 Darin Adler <Darin Adler>
Reviewed by David Hyatt.
Bug 26112: viewless WebKit -- make events work
https://bugs.webkit.org/show_bug.cgi?id=26112
One change here is to make the -[WebFrame frameView] function assert if ever called
in viewless mode, and fix many callers that would trip that assertion.
A major change is to put some methods and data in WebView that are currently in
WebHTMLView, used only in viewless mode. A next step will be to use the WebView
methods whenever possible, even when not in the viewless mode.
Also fix FrameView to do normal reference counting instead of a strange model with
an explicit deref near creation time.
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scrollRectIntoView): Add code to start in the appropriate place when dealing with viewless mode. This gets triggered when visiting the Google home page. (WebChromeClient::setToolTip): Changed to call WebView instead of WebHTMLView. (WebChromeClient::print): Changed to use a new selector that doesn't require a WebFrameView if present. Also don't even try to use the old selector in viewless mode.
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection): Changed to call WebView instead of WebHTMLView.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Added more code paths for viewless mode to skip things we can't do in that mode, with appropriate FIXME. Use Frame::create and RefPtr and eliminate the strange reference counting of FrameView.
- WebView/WebDataSource.mm: (-[WebDataSource _receivedData:]): Added a _usesDocumentViews guard around code that's specific to document views.
- WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Added a _usesDocumentViews guard around code that's specific to document views. (-[WebFrame _hasSelection]): Added an implementation for viewless mode. (-[WebFrame _clearSelection]): Assert we're not in viewless mode; it doesn't really make sense to clear the selection in only one frame in viewless mode. Later we can decide what to do. (-[WebFrame _dragSourceMovedTo:]): Assert we're not in viewless mode; the dragging code for viewless mode shouldn't have to involve the WebFrame object at all. (-[WebFrame _dragSourceEndedAt:operation:]): Ditto. (-[WebFrame frameView]): Assert we're not in viewless mode. This assertion fires often, but it's a great pointer to code that needs to be changed.
- WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): Tweaked a comment. (-[WebHTMLView _updateMouseoverWithEvent:]): Fixed a bug where the fake event for moving the mouse out of the old view ended up overwriting the event for moving the mouse within the new view. (-[WebHTMLView mouseDown:]): Got rid of explicit conversion of event to PlatformMouseEvent in call to sendContextMenuEvent; that's no longer possible without passing another argument, and it's now handled in EventHandler.
- WebView/WebTextCompletionController.h: Copied from WebKit/mac/WebView/WebHTMLView.mm. Removed everything except for the WebTextCompletionController class.
- WebView/WebTextCompletionController.mm: Copied from WebKit/mac/WebView/WebHTMLView.mm. Ditto.
- WebView/WebUIDelegatePrivate.h: Added webView:printFrame: method.
- WebView/WebView.mm: Moved includes and fields in from WebHTMLView. (-[WebView _usesDocumentViews]): Updated for name change from useDocumentViews to usesDocumentViews. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Ditto. (-[WebView drawSingleRect:]): Ditto. (-[WebView isFlipped]): Ditto. (-[WebView setFrameSize:]): Ditto. Also changed to use _mainCoreFrame method. (-[WebView _viewWillDrawInternal]): Ditto. (-[WebView viewWillDraw]): Ditto. (-[WebView drawRect:]): Ditto. (-[WebView _close]): Added code to nil out the lastMouseoverView global. (-[WebView _dashboardRegions]): Use _mainCoreFrame. (-[WebView setProhibitsMainFrameScrolling:]): Ditto. (-[WebView _setInViewSourceMode:]): Ditto. (-[WebView _inViewSourceMode]): Ditto. (-[WebView _attachScriptDebuggerToAllFrames]): Ditto. (-[WebView _detachScriptDebuggerFromAllFrames]): Ditto. (-[WebView textIteratorForRect:]): Ditto. (-[WebView _executeCoreCommandByName:value:]): Ditto. (-[WebView addWindowObserversForWindow:]): Ditto. (-[WebView removeWindowObservers]): Ditto. (-[WebView _updateFocusedAndActiveState]): Ditto. (-[WebView _updateFocusedAndActiveStateForFrame:]): Turned into a class method. Added code to handle the viewless case without calling frameView. (-[WebView _windowDidBecomeKey:]): Updated for name change from useDocumentViews to usesDocumentViews. (-[WebView _windowDidResignKey:]): Ditto. (-[WebView _windowWillOrderOnScreen:]): Ditto. (-[WebView mainFrame]): Tweaked. (-[WebView selectedFrame]): Added a conditional to avoid trying to get at the frame view in viewless case. (-[WebView _setZoomMultiplier:isTextOnly:]): Use _mainCoreFrame. (-[WebView setCustomTextEncodingName:]): Ditto. (-[WebView windowScriptObject]): Ditto. (-[WebView setHostWindow:]): Ditto. Also put some code that's needed only for document views inside _private->usesDocumentViews. (-[WebView _hitTest:dragTypes:]): Tweaked. (-[WebView acceptsFirstResponder]): Added case for viewless mode along with a FIXME, since it's not complete. (-[WebView becomeFirstResponder]): Ditto. (-[WebView _webcore_effectiveFirstResponder]): Put the body of this inside a usesDocumentView check, because we don't need the first responder forwarding in viewless mode. (-[WebView setNextKeyView:]): Ditto. (-[WebView mouseDown:]): Added. Copied from WebHTMLView. FIXME in here suggests that we make WebHTMLView share this one soon, which I think is practical. (-[WebView mouseUp:]): Ditto. (-[WebView setHoverFeedbackSuspended:]): Added a code path for viewless mode. (-[WebView shouldClose]): Use _mainCoreFrame. (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto. (-[WebView setEditable:]): Ditto. (-[WebView _frameViewAtWindowPoint:]): Added an assertion that we're not in viewless mode since this method makes no sense in that mode. (-[WebView _setMouseDownEvent:]): Added. Copied from WebHTMLView. I plan to eliminate the one in WebHTMLView soon. (-[WebView _cancelUpdateMouseoverTimer]): Ditto. (-[WebView _stopAutoscrollTimer]): Ditto. (+[WebView _updateMouseoverWithEvent:]): Ditto. (-[WebView _updateMouseoverWithFakeEvent]): Ditto. (-[WebView _setToolTip:]): Added. Calls through to the WebHTMLView version. (-[WebView _selectionChanged]): Ditto. (-[WebView _mainCoreFrame]): Added. (-[WebView _needsOneShotDrawingSynchronization]): Moved into the WebInternal category. (-[WebView _setNeedsOneShotDrawingSynchronization:]): Ditto. (-[WebView _startedAcceleratedCompositingForFrame:]): Ditto. (-[WebView _stoppedAcceleratedCompositingForFrame:]): Ditto. (viewUpdateRunLoopObserverCallBack): Ditto. (-[WebView _scheduleViewUpdate]): Ditto.
- WebView/WebViewInternal.h: Made most of the file not compile at all when included from non-C++ source files, elminating some excess declarations and typedefs. Moved more methods into the real internal category. Added new methods _setMouseDownEvent, _cancelUpdateMouseoverTimer, _stopAutoscrollTimer, _updateMouseoverWithFakeEvent, _selectionChanged, and _setToolTip:.
WebKit/wx:
2009-06-02 Darin Adler <Darin Adler>
Reviewed by David Hyatt.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::transitionToCommittedForNewPage): Use FrameView::create and RefPtr instead of the old "crazy" reference counting.
- 8:15 PM Changeset in webkit [44378] by
-
- 4 edits in trunk/WebCore
2009-06-02 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
The previous code was assuming that we'll be painting buttons on the scrollbar
which isn't true on Linux. To reproduce, resize a page with scrollbars until
they are less than two widths high.
This will need pixel test baselines to be updated in the Chromium tree.
- platform/chromium/ScrollbarThemeChromium.cpp: move this function...
- platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromium::trackRect): ... to here
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::trackRect): add an alternative which doesn't remove the track when the scrollbar is less than two widths high.
- 7:57 PM Changeset in webkit [44377] by
-
- 2 edits in trunk/WebKitTools
2009-06-02 Jessie Berlin <jberlin@apple.com>
Reviewed by Mark Rowe.
Add "replace" behavior so that it shows the addition part of the
replacement of the file first, and then shows the changes.
Future: Add in showing the removal part of the replacement.
- Scripts/svn-create-patch:
- 7:01 PM Changeset in webkit [44376] by
-
- 8 edits in trunk
Remove workaround that was added to address <rdar://problem/5488678> as it no longer affects our Tiger builds.
Reviewed by Anders Carlsson.
- Configurations/Base.xcconfig:
- 5:19 PM Changeset in webkit [44375] by
-
- 3 edits2 adds in trunk
2009-06-02 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
Insert*List on an stand-alone image in a content editable region ASSERTS
ASSERTION FAILED: isStartOfParagraph(startOfParagraphToMove)
https://bugs.webkit.org/show_bug.cgi?id=19066
Attempt to fix this by noticing that we inserted the list inside
the selection which includes the image, and re-adjust the selection
to not include the list before trying to move the image into
the list item.
Test: editing/execCommand/list-wrapping-image-crash.html
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
- 4:09 PM Changeset in webkit [44374] by
-
- 3 edits in trunk/WebCore
2009-06-02 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Rename PositionIterator members in hope of futher clarity
https://bugs.webkit.org/show_bug.cgi?id=24854
Rename m_parent to m_anchorNode (since although it's always the parent
of the previous m_child member, it is not always the parent of the effective position)
Rename m_child to m_nodeAfterPositionInAnchor to make clear that it's the node
directly following the position. This member is often NULL, but is always
a child of m_parent, now m_anchorNode if set.
Rename m_offset to m_offsetInAnchor (since it's interpreted relative to m_anchorNode)
- dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): (WebCore::PositionIterator::increment): (WebCore::PositionIterator::decrement): (WebCore::PositionIterator::atStart): (WebCore::PositionIterator::atEnd): (WebCore::PositionIterator::atStartOfNode): (WebCore::PositionIterator::atEndOfNode): (WebCore::PositionIterator::isCandidate):
- dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator): (WebCore::PositionIterator::node): (WebCore::PositionIterator::offsetInLeafNode):
- 3:08 PM Changeset in webkit [44373] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix the incorrect bug link in WebCore/ChangeLog for r44366.
- 2:46 PM Changeset in webkit [44372] by
-
- 2 edits in trunk/LayoutTests
Land correct results for a test I just added (forgot to regenerate them after adding new
test cases).
- fast/xpath/py-dom-xpath/expressions-expected.txt:
- 2:43 PM Changeset in webkit [44371] by
-
- 4 edits in trunk/WebCore
Revert r44276.
- 2:42 PM Changeset in webkit [44370] by
-
- 1 edit4 moves in trunk/LayoutTests
Moved CSSMatrix tests into LayoutTests/transforms so both 2D and 3D versions get tested in all cases, as per discussion with Maciej
- 2:33 PM Changeset in webkit [44369] by
-
- 5 edits in trunk
2009-06-02 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 17167: Failures in fast/dom/Node/initial-values.html
This partly solve a compatibility issue with other browsers. It will also
make us more consistent while handling XHTML element.
The issue is that when we create an XHTML element inside an HTML document
(as it is the case when calling createElementNS), we default to the HTML
behaviour in nodeName. As we cannot test if an HTMLElement is an XHTML
element, our fix is to check whether it has a prefix and then default
to XML behaviour for nodeName.
- html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): Add a prefix check before returning the uppercase tagName (HTML behaviour).
- 2:31 PM Changeset in webkit [44368] by
-
- 3 edits in trunk/WebCore
2009-06-02 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
Add a compareBoundaryPoints which takes RangeBoundaryPoints
https://bugs.webkit.org/show_bug.cgi?id=25500
I noticed the need for this function when removing compareBoundaryPoints(Position, Position)
This patch is almost entirely minus lines.
No functional changes, thus no tests.
- dom/Range.cpp: (WebCore::Range::setStart): (WebCore::Range::setEnd): (WebCore::Range::compareBoundaryPoints): (WebCore::Range::boundaryPointsValid):
- dom/Range.h:
- 2:31 PM Changeset in webkit [44367] by
-
- 11 edits in trunk/WebCore
2009-06-02 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056
https://bugs.webkit.org/show_bug.cgi?id=25500
Darin indicated the Range should deal only with primitive DOM node/offset
pairs, and that Position (which is a more robust editing construct) should have
its own comparison functions and that Range.h should not mention Position at all.
Turns out that Position already has a comparePositions() function (which knows
how to additionally handled positions in shadow trees). So I've just changed
all callers of compareBoundaryPoints(Position, Position) to use the existing
comparePositions() function. I've also added a comparePositions which takes
VisiblePositions for convenience.
- dom/Range.cpp:
- dom/Range.h:
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::updateStartEnd): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyle): (WebCore::ApplyStyleCommand::applyInlineStyleToRange): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::nodeFullySelected): (WebCore::ApplyStyleCommand::nodeFullyUnselected):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::CompositeEditCommand::moveParagraphs):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::mergeParagraphs):
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved):
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange):
- editing/htmlediting.cpp: (WebCore::comparePositions):
- editing/htmlediting.h:
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
- 2:09 PM Changeset in webkit [44366] by
-
- 4 edits in trunk/WebCore
2009-06-02 Albert J. Wong <ajwong@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25595
Upstream v8_utility.h functions into V8Utilities.h. This patch has
some transitional code to make upstreaming easier. This code will
be deleted in a few days.
- bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::construct): NewInstance -> newInstance.
- bindings/v8/V8Utilities.h: (WebCore::AllowAllocation::AllowAllocation): Function added. (WebCore::AllowAllocation::~AllowAllocation): Function added. (WebCore::SafeAllocation::NewInstance): Function added.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): NewInstance -> newInstance. (WebCore::WorkerContextExecutionProxy::toV8): NewInstance -> newInstance.
- 1:59 PM Changeset in webkit [44365] by
-
- 4 edits in trunk/WebKitLibraries
2009-06-02 Anders Carlsson <andersca@apple.com>
Rubber-stamped by Mark Rowe.
Update WebKitSystemInterface.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 1:25 PM Changeset in webkit [44364] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
- fix <rdar://problem/6940747> Search field’s focus ring is outset
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSearchFieldStyle): Set the focused search field outline offset to -2.
- 12:01 PM Changeset in webkit [44363] by
-
- 4 edits in trunk/WebKitTools
2009-06-02 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Update WinLauncher for WebKitCreateInstance.
https://bugs.webkit.org/show_bug.cgi?id=26136
- WinLauncher/WinLauncher.cpp: Revise implementation to use WebKitCreateInstance (rather than CoCreateInstance).
- WinLauncher/WinLauncher.h: Modify include path for WebKit.h to match DumpRenderTree style.
- WinLauncher/WinLauncher.vcproj: Remove unnecessary WebKit.tlb and EmbeddedIDL flags from build.
- 11:10 AM Changeset in webkit [44362] by
-
- 2 edits in trunk/WebCore
2009-06-02 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
Add list of unimplemented event handlers to DOMWindow.
- page/DOMWindow.idl:
- 10:59 AM Changeset in webkit [44361] by
-
- 11 edits17 adds in trunk
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=26133
Adapt and import py-dom-xpath tests
Tests: fast/xpath/py-dom-xpath/abbreviations.html
fast/xpath/py-dom-xpath/axes.html
fast/xpath/py-dom-xpath/data.html
fast/xpath/py-dom-xpath/expressions.html
fast/xpath/py-dom-xpath/functions.html
fast/xpath/py-dom-xpath/nodetests.html
fast/xpath/py-dom-xpath/paths.html
fast/xpath/py-dom-xpath/predicates.html
Fix bugs found with this test suite:
- name and local-name were incorrect for processing instructions (XPath expanded-name doesn't match DOM exactly);
- name, local-name and namespace functions should crash on attribute nodes;
- attemps to make node sets from other types were not detected as errors.
No performance impact.
- xml/XPathExpressionNode.h: Track type conversion errors that happen during evaluation. An error won't stop evaluation, but an exception will be raised afterwards. We could also detect conversion errors at compile time, but not if we're going to support XPath variables (which is unnecessary for XPathEvaluator, but will be necessary if we decide to make our own XSLT one day).
- xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Check whether a type conversion exception occurred during evaluation, and raise an excpetion if it did.
- xml/XPathFunctions.cpp: (WebCore::XPath::expandedNameLocalPart): (WebCore::XPath::expandedName): XPath name(), local-name() and namespace-uri() functions are defined in terms of expanded-name, which doesn't match anything available via DOM exactly. Calculate the expanded name properly. (WebCore::XPath::FunNamespaceURI::evaluate): This function could crash if used with an attribute node, because it released what was possibly the only reference to attribute node before using it. Changed the function to avoid such situation. (WebCore::XPath::FunLocalName::evaluate): Ditto. Also, used the new expandedNameLocalPart() to work properly with processing instruction nodes. (WebCore::XPath::FunName::evaluate): Ditto (using expandedName()). (WebCore::XPath::FunCount::evaluate): Signal an error if the argument is not a node-set (by using toNodeSet unconditionally, which will raise an error, and return an empty set).
- xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Signal an error if the expression evaluation result is not a node-set.
- xml/XPathPath.h: (WebCore::XPath::Filter::resultType): A Filter's result is actually always a node-set (this is not so for FilterExpr production in the spec, but is for us, because we don't naively map BNF productions to classes).
- xml/XPathPredicate.cpp: (WebCore::XPath::Union::evaluate): Signal an error if either side is not a node-set.
- xml/XPathStep.cpp: Removed an unnecesary include.
- xml/XPathValue.cpp: (WebCore::XPath::Value::toNodeSet): Signal an error if conversion fails. (WebCore::XPath::Value::modifiableNodeSet): Ditto. (WebCore::XPath::Value::toNumber): Don't allow inputs that don't match XPath Number production (in particular, those using exponential notation).
- 10:33 AM Changeset in webkit [44360] by
-
- 6 edits in trunk
WebCore:
2009-06-01 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow
Added oncontextmenu, oninput, and onmessage event handlers to
the DOMWindow. Aditionally, the onloadstart, onprogress, onstalled,
and onsuspend event handlers were implemented but not added to
DOMWindow.idl.
- page/DOMWindow.cpp: (WebCore::DOMWindow::oninput): (WebCore::DOMWindow::setOninput): (WebCore::DOMWindow::onmessage): (WebCore::DOMWindow::setOnmessage): (WebCore::DOMWindow::oncontextmenu): (WebCore::DOMWindow::setOncontextmenu):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
2009-06-01 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow
Added oncontextmenu, oninput, and onmessage event handlers to
the DOMWindow. Aditionally, the onloadstart, onprogress, onstalled,
and onsuspend event handlers were implemented but not added to
DOMWindow.idl.
- fast/dom/Window/window-properties-expected.txt:
- 9:57 AM Changeset in webkit [44359] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-02 Xan Lopez <xlopez@igalia.com>
Reviewed by Sam Weinig.
Use C-style comments in Platform.h so it can be included from C
files.
- wtf/Platform.h:
- 7:54 AM Changeset in webkit [44358] by
-
- 2 edits in trunk/WebKitTools
2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Adam Roben.
[Qt] Fix Perl warning about uninitialized value (passedConfiguration())
- 6:54 AM Changeset in webkit [44357] by
-
- 4 edits in trunk
2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Use File::Spec->tmpdir instead of hardcoded paths for tempfile() dir
This fixes the Windows-build if the user does not have a /tmp directory.
- 2:34 AM Changeset in webkit [44356] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-02 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver ">>" Hunt.
emitSlow_op_rshift is linking the wrong number of slow cases, if !supportsFloatingPoint().
Fixerate, and refactor/comment the code a little to make it clearer what is going on.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift):
- 2:17 AM Changeset in webkit [44355] by
-
- 3 edits2 deletes in trunk
Revert 44354. Test does not pass.
- 1:37 AM Changeset in webkit [44354] by
-
- 3 edits3 adds in trunk
WebCore:
2009-06-02 Grace Kloba <klobag@gmail.com>
Reviewed by Darin Adler. Landed by Adam Barth.
As HTMLKeygenElement is derived from HTMLSelectElement, HTMLOptionElement::ownerSelectElement() needs to check both selectTag and keygenTag.
Test: fast/dom/HTMLKeygenElement/keygen-option-select.html
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement):
LayoutTests:
2009-06-02 Grace Kloba <klobag@gmail.com>
Reviewed by Darin Adler. Landed by Adam Barth.
As HTMLKeygenElement is derived from HTMLSelectElement, HTMLOptionElement::ownerSelectElement() needs to check both selectTag and keygenTag. Added layout test to make sure set selected on option will affect keygen element.
- fast/dom/HTMLKeygenElement: Added.
- fast/dom/HTMLKeygenElement/keygen-option-select-expected.txt: Added.
- fast/dom/HTMLKeygenElement/keygen-option-select.html: Added.
- 1:32 AM Changeset in webkit [44353] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add link to bug.
- 1:30 AM Changeset in webkit [44352] by
-
- 8 edits2 deletes in trunk
Revert 44351.
- 12:56 AM Changeset in webkit [44351] by
-
- 8 edits2 adds in trunk
WebCore:
2009-06-01 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler. Landed by Adam Barth.
Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading.
Test: storage/hash-change-with-xhr.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopAllLoaders):
- loader/FrameLoader.h:
- loader/FrameLoaderTypes.h: (WebCore::):
- page/Page.cpp: (WebCore::Page::goToItem):
LayoutTests:
2009-06-02 Ben Murdoch <benm@google.com>
Reviewed by Darin Alder. Landed by Adam Barth.
Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading.
- storage/hash-change-with-xhr-expected.txt: Added.
- storage/hash-change-with-xhr.html: Added.
- 12:26 AM Changeset in webkit [44350] by
-
- 2 edits3 adds in trunk/LayoutTests
2009-06-02 Johnny Ding <johnnyding.webkit@gmail.com>
Reviewed by Alexey Proskuryakov. Landed by Adam Barth.
Add a test case for multiple requests for same sub-resource due to preload.
- http/tests/loading/preload-img-test-expected.txt: Added.
- http/tests/loading/preload-img-test.html: Added.
- http/tests/loading/resources/preload-test.jpg: Added.
- http/tests/resources/network-simulator.php:
- 12:00 AM Changeset in webkit [44349] by
-
- 2 edits in trunk/WebKitTools
2009-06-01 Yongjun Zhang <yongjun.zhang@nokia.com>>
Reviewed by Holger Freyther. Landed by Adam Barth.
[Qt] EventSender.keyDown doesn't support Arrow Up and Down keys.
Add Down and Up key support.
- DumpRenderTree/qt/jsobjects.cpp: (EventSender::keyDown):
Jun 1, 2009:
- 11:40 PM Changeset in webkit [44348] by
-
- 2 edits in trunk/WebCore
2009-06-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler. Landed by Adam Barth.
Remove a redundant checkEncodedString call when constructing a
KURL object from a string.
- platform/KURL.cpp: (WebCore::KURL::KURL):
- 10:59 PM Changeset in webkit [44347] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY - speculative windows build fix (errm, for the other patch!).
- jit/JITStubs.cpp: (JSC::):
- 10:54 PM Changeset in webkit [44346] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY - speculative windows build fix.
- assembler/AbstractMacroAssembler.h: (JSC::::CodeLocationCall::CodeLocationCall): (JSC::::CodeLocationNearCall::CodeLocationNearCall):
- 10:46 PM Changeset in webkit [44345] by
-
- 5 edits in branches/nitro-extreme
2009-06-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed some of the regression in crypto-aes.js. (8.5% speedup in
crypto-aes.js.)
SunSpider reports no change overall.
Division was producing double results, which took the slow path through
array access code.
Strangely, all my attempts at versions of this patch that modified array
access code to accept ints encoded as doubles along the fast or slow paths
were regressions. So I did this instead.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_div): When dividing an int by an int, go ahead and try to turn the result into an int. Don't just do int division, though, because testing shows it to be slower than SSE double division, and the corner cases are pretty complicated / lengthy on top of that. Also, don't try to canonicalize division of known tiny numerators into ints, since that's a waste of time.
LayoutTests:
2009-06-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added test cases for some division edge cases I broke.
- fast/js/arithmetic-expected.txt:
- fast/js/resources/arithmetic.js: Also modified this test to avoid constant folding.
- 10:36 PM Changeset in webkit [44344] by
-
- 8 edits in trunk/JavaScriptCore
2009-06-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by Olliej Hunt.
Change JITStub functions from being static members on the JITStub class to be
global extern "C" functions, and switch their the function signature declaration
in the definition of the functions to be C-macro generated. This makes it easier
to work with the stub functions from assembler code (since the names no longer
require mangling), and by delaring the functions with a macro we can look at
also auto-generating asm thunks to wrap the JITStub functions to perform the
work currently in 'restoreArgumentReference' (as a memory saving).
Making this change also forces us to be a bit more realistic about what is private
on the Register and CallFrame objects. Presently most everything on these classes
is private, and the classes have plenty of friends. We could befriend all the
global functions to perpetuate the delusion of encapsulation, but using friends is
a bit of a sledgehammer solution here - since friends can poke around with all of
the class's privates, and since all the major classes taht operate on Regsiters are
currently friends, right there is currently in practice very little protection at
all. Better to start removing friend delclarations, and exposing just the parts
that need to be exposed.
- interpreter/CallFrame.h: (JSC::ExecState::returnPC): (JSC::ExecState::setCallerFrame): (JSC::ExecState::returnValueRegister): (JSC::ExecState::setArgumentCount): (JSC::ExecState::setCallee): (JSC::ExecState::setCodeBlock):
- interpreter/Interpreter.h:
- interpreter/Register.h: (JSC::Register::Register): (JSC::Register::i):
- jit/JITStubs.cpp: (JSC::): (JSC::JITThunks::JITThunks): (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::JITStubs::):
- runtime/JSFunction.h: (JSC::JSFunction::nativeFunction): (JSC::JSFunction::classInfo):
- runtime/JSGlobalData.h:
- 9:40 PM Changeset in webkit [44343] by
-
- 2 edits in trunk/JavaScriptCore
Tidy up the literal parser.
Reviewed by Gavin Barraclogh.
Make the number lexing in the LiteralParser exactly match the JSON spec, which
makes us cover more cases, but also more strict. Also made string lexing only
allow double-quoted strings.
- 8:03 PM Changeset in webkit [44342] by
-
- 2 edits in trunk/WebCore
2009-06-01 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Reposition platform guard, improperly placed by http://trac.webkit.org/changeset/44340
Bad Dimitri.
- platform/KeyboardCodes.h: Repositioned the guard to avoid nested
WebCore namespace declarations.
- 6:20 PM Changeset in webkit [44341] by
-
- 10 edits in trunk/JavaScriptCore
2009-06-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam "WX" Weinig.
Allow the JIT to operate without relying on use of RWX memory, on platforms where this is supported.
This patch adds a switch to Platform.h (ENABLE_ASSEMBLER_WX_EXCLUSIVE) which enables this mode of operation.
When this flag is set, all executable memory will be allocated RX, and switched to RW only whilst being
modified. Upon completion of code generation the protection is switched back to RX to allow execution.
Further optimization will be required before it is desirable to enable this mode of operation by default;
enabling this presently incurs a 5%-10% regression.
(Submitting disabled - no performance impact).
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadToLEA): (JSC::AbstractMacroAssembler::CodeLocationLabel::fromFunctionPointer): (JSC::AbstractMacroAssembler::CodeLocationJump::relink): (JSC::AbstractMacroAssembler::CodeLocationCall::relink): (JSC::AbstractMacroAssembler::CodeLocationNearCall::relink): (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch): (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToTrampoline): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkNearCallerToFunction): (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::patch): (JSC::AbstractMacroAssembler::PatchBuffer::performFinalization): (JSC::::CodeLocationCommon::nearCallAtOffset): (JSC::::CodeLocationCall::CodeLocationCall): (JSC::::CodeLocationNearCall::CodeLocationNearCall):
- assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::executableCopy):
- assembler/X86Assembler.h: (JSC::CAN_SIGN_EXTEND_U32_64): (JSC::X86Assembler::linkJump): (JSC::X86Assembler::linkCall): (JSC::X86Assembler::patchPointer): (JSC::X86Assembler::relinkJump): (JSC::X86Assembler::relinkCall): (JSC::X86Assembler::repatchInt32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::repatchLoadToLEA): (JSC::X86Assembler::patchInt32): (JSC::X86Assembler::patchRel32):
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::): (JSC::ExecutableAllocator::makeWritable): (JSC::ExecutableAllocator::makeExecutable):
- jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
- jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutablePool::systemAlloc): (JSC::ExecutablePool::systemRelease): (JSC::ExecutableAllocator::reprotectRegion):
- jit/ExecutableAllocatorWin.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace):
- wtf/Platform.h:
- 4:48 PM Changeset in webkit [44340] by
-
- 2 edits1 delete in trunk/WebCore
2009-06-01 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
- platform/KeyboardCodes.h: Integrated contents of platform/chromium/KeyboardCodes.h
with a stern FIXME.
- platform/chromium/KeyboardCodes.h: Removed.
- 4:38 PM Changeset in webkit [44339] by
-
- 3 edits in trunk/WebKitTools
svn-create-patch displays confusing "Broken pipe" errors from Subversion
when files have been renamed in local working copy. This was happening
because we invoke 'svn info' to determine the URL that the file was copied
from, but we were closing the pipe to the subprocess before SVN had finished
writing its output.
Reviewed by Sam Weinig.
- Scripts/prepare-ChangeLog: Consume all 'svn info' output before closing the file handle.
- Scripts/svn-create-patch: Ditto.
- 4:09 PM Changeset in webkit [44338] by
-
- 3 edits in trunk/WebCore
Reviewed by Eric Seidel.
Fix assertion error in --filters enabled debug builds.
Instead of using RefPtr<AtomicStringImpl> as keys for the hash maps in SVGFilterBuilder, just use AtomicString objects.
- 3:20 PM Changeset in webkit [44337] by
-
- 10 edits in trunk/WebCore
Reviewed by Eric Seidel.
Fix --filters enabled build on Mac.
Remove unnecessary 'boundingBox' parameter from finishRenderSVGContent() method.
Kill several warnings, to make build pass.
- 3:19 PM Changeset in webkit [44336] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-29 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits Interpreter class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSGlobalData.cpp.
- interpreter/Interpreter.h:
- 2:52 PM Changeset in webkit [44335] by
-
- 1 edit in trunk/WebCore/ChangeLog
ChangeLog spelling, meaning fixes.
- 2:50 PM Changeset in webkit [44334] by
-
- 2 edits in trunk/WebCore
2009-06-01 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Dave Hyatt.
Fix Chromium build by adding an #ifdef.
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Added an #ifdef.
- 2:37 PM Changeset in webkit [44333] by
-
- 3 edits in trunk/WebKit/qt
2009-06-01 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Rubber-stamped by Gustavo Noronha.
Before guessing the url trim the string to remove whitespace added to the start/end by the user.
- Api/qwebview.cpp: (QWebView::guessUrlFromString):
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::guessUrlFromString_data):
- 2:28 PM Changeset in webkit [44332] by
-
- 5 edits8 deletes in trunk/WebCore
2009-06-01 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Remove last pieces of the old SVG filte system. They are not
usable with our current filter system. The new filter effects
will replace the functionality step by step.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- svg/graphics/cairo: Removed.
- svg/graphics/cairo/SVGResourceFilterCairo.cpp: Removed.
- svg/graphics/cg: Removed.
- svg/graphics/cg/SVGResourceFilterCg.cpp: Removed.
- svg/graphics/cg/SVGResourceFilterCg.mm: Removed.
- svg/graphics/filters/SVGFilterEffect.cpp: Removed.
- svg/graphics/filters/SVGFilterEffect.h: Removed.
- svg/graphics/filters/cg: Removed.
- svg/graphics/filters/cg/SVGFEHelpersCg.h: Removed.
- svg/graphics/filters/cg/SVGFEHelpersCg.mm: Removed.
- svg/graphics/filters/cg/SVGFilterEffectCg.mm: Removed.
- svg/graphics/filters/cg/WKArithmeticFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKArithmeticFilter.h: Removed.
- svg/graphics/filters/cg/WKArithmeticFilter.m: Removed.
- svg/graphics/filters/cg/WKComponentMergeFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKComponentMergeFilter.h: Removed.
- svg/graphics/filters/cg/WKComponentMergeFilter.m: Removed.
- svg/graphics/filters/cg/WKDiffuseLightingFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKDiffuseLightingFilter.h: Removed.
- svg/graphics/filters/cg/WKDiffuseLightingFilter.m: Removed.
- svg/graphics/filters/cg/WKDiscreteTransferFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKDiscreteTransferFilter.h: Removed.
- svg/graphics/filters/cg/WKDiscreteTransferFilter.m: Removed.
- svg/graphics/filters/cg/WKDisplacementMapFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKDisplacementMapFilter.h: Removed.
- svg/graphics/filters/cg/WKDisplacementMapFilter.m: Removed.
- svg/graphics/filters/cg/WKDistantLightFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKDistantLightFilter.h: Removed.
- svg/graphics/filters/cg/WKDistantLightFilter.m: Removed.
- svg/graphics/filters/cg/WKGammaTransferFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKGammaTransferFilter.h: Removed.
- svg/graphics/filters/cg/WKGammaTransferFilter.m: Removed.
- svg/graphics/filters/cg/WKIdentityTransferFilter.h: Removed.
- svg/graphics/filters/cg/WKIdentityTransferFilter.m: Removed.
- svg/graphics/filters/cg/WKLinearTransferFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKLinearTransferFilter.h: Removed.
- svg/graphics/filters/cg/WKLinearTransferFilter.m: Removed.
- svg/graphics/filters/cg/WKNormalMapFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKNormalMapFilter.h: Removed.
- svg/graphics/filters/cg/WKNormalMapFilter.m: Removed.
- svg/graphics/filters/cg/WKPointLightFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKPointLightFilter.h: Removed.
- svg/graphics/filters/cg/WKPointLightFilter.m: Removed.
- svg/graphics/filters/cg/WKSpecularLightingFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKSpecularLightingFilter.h: Removed.
- svg/graphics/filters/cg/WKSpecularLightingFilter.m: Removed.
- svg/graphics/filters/cg/WKSpotLightFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKSpotLightFilter.h: Removed.
- svg/graphics/filters/cg/WKSpotLightFilter.m: Removed.
- svg/graphics/filters/cg/WKTableTransferFilter.cikernel: Removed.
- svg/graphics/filters/cg/WKTableTransferFilter.h: Removed.
- svg/graphics/filters/cg/WKTableTransferFilter.m: Removed.
- svg/graphics/mac: Removed.
- svg/graphics/mac/SVGResourceFilterPlatformDataMac.h: Removed.
- svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm: Removed.
- svg/graphics/qt: Removed.
- svg/graphics/qt/SVGResourceFilterQt.cpp: Removed.
- svg/graphics/skia: Removed.
- svg/graphics/skia/SVGResourceFilterSkia.cpp: Removed.
- 2:05 PM Changeset in webkit [44331] by
-
- 2 edits in trunk/WebKit/qt
2009-06-01 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Rubber-stamped by Gustavo Noronha.
Use QLatin1Char() to compile when QT_NO_CAST_FROM_ASCII and QT_NO_CAST_TO_ASCII is defined
- Api/qwebview.cpp: (QWebView::guessUrlFromString):
- 1:06 PM Changeset in webkit [44330] by
-
- 2 edits in trunk/WebKit/qt
2009-06-01 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Rubber-stamped by Gustavo Noronha.
Cleanup autotest file
- use proper includes
- remove useless constructor and destructor
- add missing newline at the end of the file
- tests/qwebview/tst_qwebview.cpp:
- 1:01 PM Changeset in webkit [44329] by
-
- 2 edits in trunk/WebKit/qt
2009-06-01 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Rubber-stamped by Gustavo Noronha.
Add a missing space between two words in the documentation.
- Api/qwebview.cpp:
- 12:56 PM Changeset in webkit [44328] by
-
- 2 edits in trunk/WebCore
2009-06-01 Dmitry Titov <dimich@chromium.org>
Fix the previous checkin (ttp://trac.webkit.org/changeset/44327).
This adds a comment suggested during review.
- platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::~ThreadGlobalData): Add comment clarifying the change.
- 12:44 PM Changeset in webkit [44327] by
-
- 3 edits in trunk/WebCore
2009-06-01 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25973
Avoid calling CurrentThread() in thread-specific destructors in OSX Chromium.
Pthreads invoke thread-specific destructors after WTF::detachThread() is called and ThreadIdentifier
for the thread removed from the WTF thread map. Calling CurrentThread() in such destructor causes
the ThreadIdentifier to be re-created and inserted into the map again. Since Pthreads on OSX reuse
the pthread_t between threads, the next created thread will have the same pthread_t and cause an assert
in establishIdentifierForPthreadHandle() since the id is already in the map.
The behavior is covered by existing test LayoutTests/fast/workers/worker-terminate.html, which currently fails
on OSX Chromium and will stop failing after this change.
- platform/ThreadGlobalData.h:
- platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::~ThreadGlobalData): Store the result of "isMainThread()" in a member variable during construction of thread-specific data to avoid calling IsMainThread() in destructor, since the latter calls CurrentThread() in OSX Chromium.
- 12:18 PM Changeset in webkit [44326] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-01 David Levin <levin@chromium.org>
Reviewed by NOBODY (windows build fix).
Add exports for windows (corresponding to the JavaScriptCore.exp modification
in the previous change).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 11:41 AM Changeset in webkit [44325] by
-
- 9 edits in trunk
2009-06-01 David Levin <levin@chromium.org>
Reviewed by Darin Alder and Maciej Stachowiak.
Bug 26057: StringImpl should share buffers with UString.
https://bugs.webkit.org/show_bug.cgi?id=26057
- JavaScriptCore.exp:
- runtime/UString.cpp: (JSC::UString::Rep::create): (JSC::UString::BaseString::sharedBuffer): Only do the sharing when the buffer exceeds a certain size. The size was tuned by running various dom benchmarks with numbers ranging from 20 to 800 and finding a place that seemed to do the best overall.
- runtime/UString.h:
WebCore:
2009-06-01 David Levin <levin@chromium.org>
Reviewed by Darin Alder and Maciej Stachowiak.
Bug 26057: StringImpl should share buffers with UString.
https://bugs.webkit.org/show_bug.cgi?id=26057
This change results in the following performance improvements:
On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/001.html
the time went from 78ms to 40ms for append (other times remained constant).
On http://www.hixie.ch/tests/adhoc/perf/dom/artificial/core/002.html,
the time went from 3900ms to 2600ms.
For http://dromaeo.com/?dom, the time for DomModification improved by ~6%.
Other tests in dom seemed to be faster across several runs but within the
margin of error (except DOM Attributes which was slightly ~1.5% worse).
Existing tests cover this code and there is no new functionality
that is exposed to test.
- platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
- platform/text/String.cpp: (WebCore::String::String): (WebCore::String::operator UString):
- platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::~StringImpl): (WebCore::StringImpl::create): Consumes a shared buffer. (WebCore::StringImpl::ustring): Shares the StringImpl's buffer with the UString. (WebCore::StringImpl::sharedBuffer): Exposes the buffer that may be shared.
- platform/text/StringImpl.h: (WebCore::StringImpl::hasTerminatingNullCharacter): (WebCore::StringImpl::inTable): (WebCore::StringImpl::setInTable): Converted the bools to be inside of PtrAndFlags to avoid growing StringImpl in size.
- 10:35 AM WebKit Team edited by
- (diff)
- 10:16 AM Changeset in webkit [44324] by
-
- 3 edits in trunk/WebKit/win
2009-06-01 Brent Fulgham <bfulgham@webkit.org>
Build fix for Cairo Windows target. Windows link definition
files were out of sync with the Apple Windows link files.
- WebKit.vcproj/WebKit_Cairo.def:
- WebKit.vcproj/WebKit_Cairo_debug.def:
- 9:53 AM Changeset in webkit [44323] by
-
- 3 edits in trunk/WebCore
2009-06-01 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
V8 bindings follow-up to to DOMWindow-related cleanup:
http://trac.webkit.org/changeset/44215
- bindings/v8/ScriptController.cpp: Removed disconnectFrame(), relocated
its body to destructor.
- bindings/v8/ScriptController.h: Removed disconnectFrame() decl.
- 9:16 AM Changeset in webkit [44322] by
-
- 14 edits1 add in trunk/WebCore
2009-05-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
- Add panel enabler to the resources panel.
- Add session / always options into the panel enabler.
- Make enabled status for three panels sticky (globally).
- Persist enabled status using InspectorController::Settings
- Make InspectorController produce no network-related overhead when resources panel is not enabled.
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger):
- inspector/InspectorController.h: (WebCore::InspectorController::Setting::Setting): (WebCore::InspectorController::resourceTrackingEnabled):
- inspector/InspectorController.idl:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::resourceTrackingWasEnabled): (WebCore::InspectorFrontend::resourceTrackingWasDisabled):
- inspector/InspectorFrontend.h:
- inspector/front-end/PanelEnablerView.js: (WebInspector.PanelEnablerView.enableOption): (WebInspector.PanelEnablerView): (WebInspector.PanelEnablerView.prototype._windowResized): (WebInspector.PanelEnablerView.prototype.alwaysWasChosen):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.get statusBarItems): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateSidebarWidth): (WebInspector.ResourcesPanel.prototype._enableResourceTracking): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.resourceTrackingWasEnabled): (WebInspector.resourceTrackingWasDisabled):
- 3:14 AM Changeset in webkit [44321] by
-
- 1 edit4 deletes in trunk/LayoutTests
Revert 44320. The test didn't pass on Windows.
- 2:05 AM Changeset in webkit [44320] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-06-01 Jungshik Shin <jshin@chromium.org>
Reviewed by Maciej Stachowiak. Landed by Adam Barth.
Add an additional test for bug 23786 (mistreatment of CR/LF
as zero-width characters in Chromium port). Tests using Bidi text were
added when the fix was checked in. Without the patch, Chromium used
to fail the same way with LTR complex scripts as well. (that is,
CR and LF were treated as zero-width space). To prevent a potential
regression in the future, a new test with Hindi (a LTR complex script)
is added.
- fast/text/international/hindi-whitespace.html: Added.
- platform/mac/fast/text/international/hindi-whitespace-expected.checksum: Added.
- platform/mac/fast/text/international/hindi-whitespace-expected.png: Added.
- platform/mac/fast/text/international/hindi-whitespace-expected.txt: Added.
- 2:00 AM Changeset in webkit [44319] by
-
- 7 edits6 adds in trunk
WebCore:
2009-06-01 Drew Wilson <atwilson@google.com>
Reviewed by Darin Adler. Landed (and tweaked) by Adam Barth.
Added WorkerContext.close()
Test: fast/workers/worker-close.html
- workers/WorkerContext.cpp: (WebCore::WorkerContext::close):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
- workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
LayoutTests:
2009-06-01 Drew Wilson <atwilson@google.com>
Reviewed by Darin Adler. Landed by Adam Barth.
Added WorkerContext.close()
- fast/workers/worker-close-expected.txt: Added.
- fast/workers/worker-close.html: Added.
- fast/workers/resources/worker-close.js: Added.
- http/tests/xmlhttprequest/workers/close.html: Added.
- 1:30 AM Changeset in webkit [44318] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/dynamic/anchor-lock-expected.txt
Add missing expected result.
- 1:27 AM Changeset in webkit [44317] by
-
- 9 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=12471
XPathResult not invalidated for documents retrieved via XMLHttpRequest
Test: fast/xpath/detached-subtree-invalidate-iterator.html and existing tests in dom/svg/level3/xpath.
Use DOM tree version instead of DOMSubtreeModified events to invalidate, which is more
reliable and much faster.
- xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate):
- xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult): (WebCore::XPathResult::~XPathResult): (WebCore::XPathResult::invalidIteratorState): (WebCore::XPathResult::iterateNext):
- xml/XPathResult.h: (WebCore::XPathResult::create):
- 1:18 AM Changeset in webkit [44316] by
-
- 2 edits in trunk/WebKit/mac
2009-06-01 Darin Adler <Darin Adler>
- WebView/WebTextCompletionController.mm: Fix Tiger build by adding import of WebTypesInternal.h.
- 1:11 AM Changeset in webkit [44315] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-01 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Adler. Landed by Adam Barth.
Test: fast/transforms/bounding-rect-zoom.html
Make getClientRects and getBoundingClientRect account for ther zoom
factor.
- dom/Element.cpp: (WebCore::adjustFloatPointForAbsoluteZoom): (WebCore::adjustFloatQuadForAbsoluteZoom): (WebCore::adjustIntRectForAbsoluteZoom): (WebCore::Element::getClientRects): (WebCore::Element::getBoundingClientRect):
LayoutTests:
2009-06-01 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Adler. Landed by Adam Barth.
Test: fast/transforms/bounding-rect-zoom.html
Make getClientRects and getBoundingClientRect account for ther zoom
factor.
- fast/transforms/bounding-rect-zoom.html: Added.
- platform/mac/fast/transforms/bounding-rect-zoom-expected.txt: Added.
- 1:07 AM Changeset in webkit [44314] by
-
- 1 add in trunk/LayoutTests/platform/mac/fast/dynamic/anchor-lock-expected.txt
Add bogus expected result to trick the bot into showing me the real expected results (as suggested by bdash).
- 12:46 AM Changeset in webkit [44313] by
-
- 4 edits2 copies in trunk/WebKit
WebKit:
2009-06-01 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
Bug 26113: break WebTextCompletionController out into its own source file
https://bugs.webkit.org/show_bug.cgi?id=26113
- WebKit.xcodeproj/project.pbxproj: Add WebTextCompletionController.h/mm.
WebKit/mac:
2009-06-01 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
Bug 26113: break WebTextCompletionController out into its own source file
https://bugs.webkit.org/show_bug.cgi?id=26113
- WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): Updated for new name. (-[WebHTMLViewPrivate clear]): Ditto. (-[WebHTMLView _frameOrBoundsChanged]): Ditto. (-[WebHTMLView menuForEvent:]): Ditto. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView windowWillClose:]): Ditto. (-[WebHTMLView mouseDown:]): Ditto. (-[WebHTMLView resignFirstResponder]): Ditto. (-[WebHTMLView keyDown:]): Ditto. (-[WebHTMLView complete:]): Ditto. Also pass WebView to init method. (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Ditto.
- WebView/WebTextCompletionController.h: Copied from mac/WebView/WebHTMLView.mm.
- WebView/WebTextCompletionController.mm: Copied from mac/WebView/WebHTMLView.mm. Changed initializer to pass in a spearate WebView and WebHTMLView, to smooth the way for handling viewless mode properly in the future.
- 12:43 AM Changeset in webkit [44312] by
-
- 2 edits in trunk/WebCore
2009-06-01 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov. Landed by Adam Barth.
Fix an infinite loop when using the keyboard in Chromium select
popups.
Not testable since it involves sending a keyboard event to
the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).
- platform/chromium/PopupMenuChromium.cpp:
- 12:34 AM Changeset in webkit [44311] by
-
- 5 edits2 adds in trunk
WebCore:
2009-06-01 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov. Landed by Adam Barth.
If a url with an anchor is being loaded, ensure that the anchor remains locked in view until the page
has finished loading compeltely or the user has manually scrolled. Refreshing an anchor url after
scrolling to a new location on the page will still result in jumping to the new location.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Set anchor lock after navigating to anchor. (WebCore::FrameLoader::completed): Release anchor lock.
- page/FrameView.cpp: (WebCore::FrameView::FrameView): Ensure anchor lock starts unset. (WebCore::FrameView::reset): Ensure anchor lock starts unset. (WebCore::FrameView::layout): If anchor lock is set, force a gotoAnchor() after layout. (WebCore::FrameView::scrollRectIntoViewRecursively): Release anchor lock if a programmatic scroll begins. (WebCore::FrameView::setWasScrolledByUser): Release anchor lock if user manually scrolls. (WebCore::FrameView::setScrollPosition): Release anchor lock if a programmatic scroll begins.
- page/FrameView.h: (WebCore::FrameView::lockedToAnchor): Added. (WebCore::FrameView::setLockedToAnchor): Added.
LayoutTests:
2009-06-01 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov. Landed by Adam Barth.
Ensure an anchor remains locked in view as images (without height already specified) load around it.
- fast/dynamic/anchor-lock.html: Added.
- fast/dynamic/resources/largeblank.png: Added.
May 31, 2009:
- 11:06 PM Changeset in webkit [44310] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-31 Gavin Barraclough <barraclough@apple.com>
Reviewed by Olliej "you just need to change NativeFunctionWrapper.h" Hunt.
Add ENABLE_JIT_OPTIMIZE_NATIVE_CALL switch to allow JIT to operate without native call optimizations.
- runtime/NativeFunctionWrapper.h:
- wtf/Platform.h:
- 10:36 PM Changeset in webkit [44309] by
-
- 8 edits2 adds2 deletes in trunk/WebCore
2009-05-31 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
A short clean-up. FilterBuilder is SVG specific. Move it
to svg/graphics/filters and rename it to SVGFilterBuilder.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- svg/FilterBuilder.cpp: Removed.
- svg/FilterBuilder.h: Removed.
- svg/SVGFilterElement.cpp:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter):
- svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::builder):
- svg/graphics/filters/SVGFilterBuilder.cpp: Added. (WebCore::SVGFilterBuilder::SVGFilterBuilder): (WebCore::SVGFilterBuilder::add): (WebCore::SVGFilterBuilder::getEffectById): (WebCore::SVGFilterBuilder::clearEffects):
- svg/graphics/filters/SVGFilterBuilder.h: Added. (WebCore::SVGFilterBuilder::lastEffect):
- 10:35 PM Changeset in webkit [44308] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix a typo in ChangeLog.
- 10:23 PM Changeset in webkit [44307] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13233
Need to implement an optimizing XPath evaluator
Avoid sorting results of hierarchical paths that are natuarlly sorted. On a flat data structure
with 128K nodes and a simple XPath expression, this changes evaluation time from 1.5 minutes
to 33 ms.
- xml/XPathNodeSet.h: Keep track of whether subtrees rooted at nodes in set are disjoint, which is useful for optimization. (WebCore::XPath::NodeSet::NodeSet): Removed, it was identical to compiler generated one. (WebCore::XPath::NodeSet::operator=): Ditto. (WebCore::XPath::NodeSet::swap): Ditto. (WebCore::XPath::NodeSet::isSorted): Single element sets are always sorted, even if sort() was never called. (WebCore::XPath::NodeSet::markSubtreesDisjoint): Just like being sorted, the new flag is maintained by callers. (WebCore::XPath::NodeSet::subtreesAreDisjoint): A single element set only has one subtree. Currently, the only way for a set to gain this flag is to be produced from a single element set with a hierarchical location path.
- xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Use the new flag to avoid maintaining a set of unique nodes, and to avoid sorting the result.
- 9:18 PM Changeset in webkit [44306] by
-
- 14 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13233
Need to implement an optimizing XPath evaluator
This patch adds some infrastructure and simple optimizations. Namely,
- we now avoid building a full NodeSet just to evaluate a predicate in some cases;
- "/descendant-or-self::node()/child::" is optimized to iterate the tree once when possible;
WebCore:
- xml/XPathExpressionNode.cpp: (WebCore::XPath::Expression::Expression):
- xml/XPathExpressionNode.h: (WebCore::XPath::Expression::addSubExpression): (WebCore::XPath::Expression::isContextNodeSensitive): (WebCore::XPath::Expression::isContextPositionSensitive): (WebCore::XPath::Expression::isContextSizeSensitive): (WebCore::XPath::Expression::setIsContextNodeSensitive): (WebCore::XPath::Expression::setIsContextPositionSensitive): (WebCore::XPath::Expression::setIsContextSizeSensitive): XPath expression now knows its result type, and whether evaluation depends on context.
- xml/XPathFunctions.cpp: (WebCore::XPath::FunLast::resultType): (WebCore::XPath::FunLast::FunLast): (WebCore::XPath::FunPosition::resultType): (WebCore::XPath::FunPosition::FunPosition): (WebCore::XPath::FunCount::resultType): (WebCore::XPath::FunId::resultType): (WebCore::XPath::FunLocalName::resultType): (WebCore::XPath::FunLocalName::FunLocalName): (WebCore::XPath::FunNamespaceURI::resultType): (WebCore::XPath::FunNamespaceURI::FunNamespaceURI): (WebCore::XPath::FunName::resultType): (WebCore::XPath::FunName::FunName): (WebCore::XPath::FunString::resultType): (WebCore::XPath::FunString::FunString): (WebCore::XPath::FunConcat::resultType): (WebCore::XPath::FunStartsWith::resultType): (WebCore::XPath::FunContains::resultType): (WebCore::XPath::FunSubstringBefore::resultType): (WebCore::XPath::FunSubstringAfter::resultType): (WebCore::XPath::FunSubstring::resultType): (WebCore::XPath::FunStringLength::resultType): (WebCore::XPath::FunStringLength::FunStringLength): (WebCore::XPath::FunNormalizeSpace::resultType): (WebCore::XPath::FunNormalizeSpace::FunNormalizeSpace): (WebCore::XPath::FunTranslate::resultType): (WebCore::XPath::FunBoolean::resultType): (WebCore::XPath::FunNot::resultType): (WebCore::XPath::FunTrue::resultType): (WebCore::XPath::FunFalse::resultType): (WebCore::XPath::FunLang::resultType): (WebCore::XPath::FunLang::FunLang): (WebCore::XPath::FunNumber::resultType): (WebCore::XPath::FunNumber::FunNumber): (WebCore::XPath::FunSum::resultType): (WebCore::XPath::FunFloor::resultType): (WebCore::XPath::FunCeiling::resultType): (WebCore::XPath::FunRound::resultType): (WebCore::XPath::Function::setArguments): Set optimization details for the expression. Normally, a function does not introduce context node set dependency, but some use context node as default argument, or otherwise use the context.
- xml/XPathFunctions.h: Tweaked style.
- xml/XPathPath.cpp: (WebCore::XPath::Filter::Filter): A filter is as context node set sensitive as its expression is. (WebCore::XPath::LocationPath::LocationPath): A location path can only be context node sensitive, and only if the path relative. (WebCore::XPath::LocationPath::appendStep): Invoke compile-time Step optimizations. (WebCore::XPath::LocationPath::insertFirstStep): Ditto. (WebCore::XPath::Path::Path): A path is as context node set sensitive as its filter is.
- xml/XPathPath.h: (WebCore::XPath::Filter::resultType): Result type of a filter is the same as of its expression (useful filters return NodeSets, of course). (WebCore::XPath::LocationPath::setAbsolute): An absolute location path if context node set insensitive. (WebCore::XPath::LocationPath::resultType): A path's result is always a node set. (WebCore::XPath::Path::resultType): Ditto.
- xml/XPathPredicate.h: (WebCore::XPath::Number::resultType): Return a proper result type. (WebCore::XPath::StringExpression::resultType): Ditto. (WebCore::XPath::Negative::resultType): Ditto. (WebCore::XPath::NumericOp::resultType): Ditto. (WebCore::XPath::EqTestOp::resultType): Ditto. (WebCore::XPath::LogicalOp::resultType): Ditto. (WebCore::XPath::Union::resultType): Ditto. (WebCore::XPath::Predicate::isContextPositionSensitive): A predicate can be context position sensitive even if its expression is not, because e.g. [5] is a shortcut for [position()=5]. (WebCore::XPath::Predicate::isContextSizeSensitive): This matches expression result.
- xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::Kind): Removed unused ElementNodeTest, which was previously borrowed from XPath 2.0 to express some optimizations. (WebCore::XPath::Step::NodeTest::mergedPredicates): To avoid building a huge node set and filtering it with predicates, we now try to apply predicates while enumerating an axis. (WebCore::XPath::Step::nodeTest): Expose m_nodeTest.
- xml/XPathStep.cpp: (WebCore::XPath::Step::~Step): The step owns NodeTest merged predicates, so it is still possible to copy NodeTests. (WebCore::XPath::Step::optimize): Merge predicates into NodeTest if possible. (WebCore::XPath::optimizeStepPair): Optimize some expressions containing "". (WebCore::XPath::Step::predicatesAreContextListInsensitive): The above optimization is only possible if there are no context sensitive predicates for "". (WebCore::XPath::Step::evaluate): Track context position for the first merged predicate. (WebCore::XPath::nodeMatchesBasicTest): Check whether the node matches node test, ignoring merged predicates. (WebCore::XPath::nodeMatches): Additionally check merged predicates, and update position. (WebCore::XPath::Step::nodesInAxis): Check merged predicates in optimized attribute code path.
- xml/XPathVariableReference.h: (WebCore::XPath::VariableReference::resultType): Variable references are not used with XPathEvaluator, so we'll only need them if we decide to reimplement XSLT. The type of variable reference is not known at compile time.
LayoutTests:
- fast/xpath/attribute-node-predicate-expected.txt: Added.
- fast/xpath/attribute-node-predicate.html: Added. Test that predicates on attribute nodes are applied correctly (which I had wrong for a while when working on this patch).
- fast/xpath/position-expected.txt:
- fast/xpath/position.html: Added an example from XPath spec.
- 8:59 PM Changeset in webkit [44305] by
-
- 1 edit3 adds in trunk/LayoutTests
Add Windows results for fast/forms/isindex-placeholder.html
- 8:55 PM Changeset in webkit [44304] by
-
- 2 edits in trunk/WebKitTools
2009-05-31 Sam Weinig <sam@webkit.org>
Implement LayoutTestController::clearAllDatabases()
on Windows.
- 8:05 PM Changeset in webkit [44303] by
-
- 4 edits1 delete in trunk/WebCore
2009-05-31 Sam Weinig <sam@webkit.org>
Rubber-stamped by Dan Bernstein.
Remove unused JSEventTargetBase.h
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventTargetBase.h: Removed.
- 7:56 PM Changeset in webkit [44302] by
-
- 6 edits in trunk
WebCore:
2009-05-31 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow
Add missing oncanplay, oncanplaythrough, ondurationchange, onemptied,
onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying,
onratechange, onseeked, onseeking, ontimeupdate, onvolumechange,
onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag,
ondragend, ondragenter, ondragleave, ondragover, ondragstart and
ondrop event handlers to the DOMWindow.
- page/DOMWindow.cpp: (WebCore::DOMWindow::ondrag): (WebCore::DOMWindow::setOndrag): (WebCore::DOMWindow::ondragend): (WebCore::DOMWindow::setOndragend): (WebCore::DOMWindow::ondragenter): (WebCore::DOMWindow::setOndragenter): (WebCore::DOMWindow::ondragleave): (WebCore::DOMWindow::setOndragleave): (WebCore::DOMWindow::ondragover): (WebCore::DOMWindow::setOndragover): (WebCore::DOMWindow::ondragstart): (WebCore::DOMWindow::setOndragstart): (WebCore::DOMWindow::ondrop): (WebCore::DOMWindow::setOndrop): (WebCore::DOMWindow::oncanplay): (WebCore::DOMWindow::setOncanplay): (WebCore::DOMWindow::oncanplaythrough): (WebCore::DOMWindow::setOncanplaythrough): (WebCore::DOMWindow::ondurationchange): (WebCore::DOMWindow::setOndurationchange): (WebCore::DOMWindow::onemptied): (WebCore::DOMWindow::setOnemptied): (WebCore::DOMWindow::onended): (WebCore::DOMWindow::setOnended): (WebCore::DOMWindow::onloadeddata): (WebCore::DOMWindow::setOnloadeddata): (WebCore::DOMWindow::onloadedmetadata): (WebCore::DOMWindow::setOnloadedmetadata): (WebCore::DOMWindow::onpause): (WebCore::DOMWindow::setOnpause): (WebCore::DOMWindow::onplay): (WebCore::DOMWindow::setOnplay): (WebCore::DOMWindow::onplaying): (WebCore::DOMWindow::setOnplaying): (WebCore::DOMWindow::onratechange): (WebCore::DOMWindow::setOnratechange): (WebCore::DOMWindow::onseeked): (WebCore::DOMWindow::setOnseeked): (WebCore::DOMWindow::onseeking): (WebCore::DOMWindow::setOnseeking): (WebCore::DOMWindow::ontimeupdate): (WebCore::DOMWindow::setOntimeupdate): (WebCore::DOMWindow::onvolumechange): (WebCore::DOMWindow::setOnvolumechange): (WebCore::DOMWindow::onwaiting): (WebCore::DOMWindow::setOnwaiting): (WebCore::DOMWindow::onloadstart): (WebCore::DOMWindow::setOnloadstart): (WebCore::DOMWindow::onprogress): (WebCore::DOMWindow::setOnprogress): (WebCore::DOMWindow::onstalled): (WebCore::DOMWindow::setOnstalled): (WebCore::DOMWindow::onsuspend): (WebCore::DOMWindow::setOnsuspend):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
2009-05-31 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow
Add missing oncanplay, oncanplaythrough, ondurationchange, onemptied,
onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying,
onratechange, onseeked, onseeking, ontimeupdate, onvolumechange,
onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag,
ondragend, ondragenter, ondragleave, ondragover, ondragstart and
ondrop event handlers to the DOMWindow.
- fast/dom/Window/window-properties-expected.txt:
- 5:20 PM Changeset in webkit [44301] by
-
- 8 edits in trunk
WebCore:
2009-05-31 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow
Add missing onstorage event handler to the DOMWindow.
- page/DOMWindow.cpp: (WebCore::DOMWindow::onstorage): (WebCore::DOMWindow::setOnstorage):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
2009-05-31 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow
Add missing onstorage event handler to the DOMWindow.
- fast/dom/Window/window-properties-expected.txt:
- storage/domstorage/window-attributes-exist-expected.txt:
- storage/domstorage/window-attributes-exist.html:
- 4:47 PM Changeset in webkit [44300] by
-
- 1 edit1 delete in trunk/LayoutTests
2009-05-31 Sam Weinig <sam@webkit.org>
Rubber-stamped by Mark Rowe.
Remove duplicate file. The version of window-properties-expected.txt in the
platform/mac-leopard was identical to the one in the normal spot.
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt: Removed.
- 4:12 PM Changeset in webkit [44299] by
-
- 41 edits in trunk/WebCore
2009-05-31 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
Make use of the new filter system in WebCore for SVG. Deleted Mac bindings
and replace it by a platform independent code. Calculation of subRegions
is missing but needed for a first filter effect.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/Filter.h: (WebCore::Filter::~Filter): (WebCore::Filter::setSourceImage):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent):
- svg/FilterBuilder.h: (WebCore::FilterBuilder::lastEffect):
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::build):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::build):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement): (WebCore::SVGFEComponentTransferElement::build):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement): (WebCore::SVGFECompositeElement::build):
- svg/SVGFECompositeElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (WebCore::SVGFEDisplacementMapElement::build):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::build):
- svg/SVGFEFloodElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (WebCore::SVGFEGaussianBlurElement::build):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement): (WebCore::SVGFEImageElement::notifyFinished): (WebCore::SVGFEImageElement::build):
- svg/SVGFEImageElement.h:
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::SVGFEMergeElement): (WebCore::SVGFEMergeElement::build):
- svg/SVGFEMergeElement.h:
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement): (WebCore::SVGFEOffsetElement::build):
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement): (WebCore::SVGFESpecularLightingElement::build):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement): (WebCore::SVGFETileElement::build):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement): (WebCore::SVGFETurbulenceElement::build):
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::canvasResource):
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::contextElement):
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::addFilterEffect): (WebCore::SVGResourceFilter::filterBBoxForItemBBox): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::externalRepresentation):
- svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::filterBoundingBox): (WebCore::SVGResourceFilter::setFilterBoundingBox): (WebCore::SVGResourceFilter::itemBoundingBox): (WebCore::SVGResourceFilter::setItemBoundingBox): (WebCore::SVGResourceFilter::builder):
- 3:24 PM Changeset in webkit [44298] by
-
- 8 edits in trunk
WebCore:
2009-05-30 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
Update online/offline events to match the current spec.
- Also adds window.ononline and window.onoffline event handler properties.
- page/DOMWindow.cpp: (WebCore::DOMWindow::onoffline): (WebCore::DOMWindow::setOnoffline): (WebCore::DOMWindow::ononline): (WebCore::DOMWindow::setOnonline):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- page/Page.cpp: (WebCore::networkStateChanged):
LayoutTests:
2009-05-30 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26110
Update online/offline events to match the current spec.
- Also adds window.ononline and window.onoffline event handler properties.
- fast/dom/Window/window-properties-expected.txt:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 11:22 AM Changeset in webkit [44297] by
-
- 6 edits in trunk/WebCore
2009-05-31 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
Adding 'in1' attribute support for <feFlood>, as specified in SVG 1.1.
This change helps creating test cases, once filters are activated.
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::parseMappedAttribute): (WebCore::SVGFEFloodElement::build):
- svg/SVGFEFloodElement.h:
- svg/SVGFEFloodElement.idl:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::FEFlood): (WebCore::FEFlood::create):
- svg/graphics/filters/SVGFEFlood.h:
- 10:34 AM Changeset in webkit [44296] by
-
- 41 edits3 adds2 deletes in trunk/WebCore
2009-05-31 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
Replace all occurrences of SVGResourceFilter by Filter. This is the last
step for a SVG independent filter system. Every other part of WebCore can
use the filter system by creating a new Filter object.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
- platform/graphics/filters/FEComposite.h:
- platform/graphics/filters/Filter.h: Added. (WebCore::Filter::setSourceImage): (WebCore::Filter::sourceImage):
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
- platform/graphics/filters/SourceAlpha.h:
- platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
- platform/graphics/filters/SourceGraphic.h:
- svg/Filter.cpp: Removed.
- svg/Filter.h: Removed.
- svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply):
- svg/graphics/filters/SVGFEConvolveMatrix.h:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::apply):
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
- svg/graphics/filters/SVGFEDisplacementMap.h:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
- svg/graphics/filters/SVGFEFlood.h:
- svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
- svg/graphics/filters/SVGFEGaussianBlur.h:
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
- svg/graphics/filters/SVGFEMorphology.h:
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
- svg/graphics/filters/SVGFEOffset.h:
- svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::apply):
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
- svg/graphics/filters/SVGFETile.h:
- svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::apply):
- svg/graphics/filters/SVGFETurbulence.h:
- svg/graphics/filters/SVGFilter.cpp: Added. (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::calculateEffectSubRegion): (WebCore::SVGFilter::create):
- svg/graphics/filters/SVGFilter.h: Added.
May 30, 2009:
- 8:26 PM Changeset in webkit [44295] by
-
- 2 edits in trunk/WebCore
Build fix for platforms without plugins support.
- 7:32 PM Changeset in webkit [44294] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=25979
Fix regression, local WML files won't load anymore, as the mimetype isn't correctly detected.
Bug filed at <rdar://problem/6917571> to cover this CFNetwork limitation.
- 5:58 PM Changeset in webkit [44293] by
-
- 17 edits in trunk
WebCore:
2009-05-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26091
Make storage events match the current spec.
- Storage event listeners are added to the window.
- Storage events are dispatched to the window.
Updated existing tests.
- dom/Document.cpp: (WebCore::Document::dispatchWindowEvent):
- dom/Document.h:
- dom/Node.cpp:
- dom/Node.h:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::dispatchStorageEvent):
- storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::dispatchStorageEvent):
LayoutTests:
2009-05-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26091
Make storage events match the current spec.
- Storage event listeners are added to the window.
- Storage events are dispatched to the window.
- storage/domstorage/localstorage/iframe-events.html:
- storage/domstorage/localstorage/index-get-and-set.html:
- storage/domstorage/localstorage/resources/iframe-events-second.html:
- storage/domstorage/localstorage/simple-events.html:
- storage/domstorage/sessionstorage/iframe-events.html:
- storage/domstorage/sessionstorage/index-get-and-set.html:
- storage/domstorage/sessionstorage/resources/iframe-events-second.html:
- storage/domstorage/sessionstorage/simple-events.html:
- 4:27 PM Changeset in webkit [44292] by
-
- 7 edits in trunk
WebCore:
2009-05-30 Darin Adler <Darin Adler>
Reviewed by Adele Peterson.
Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element
Test: fast/forms/focus-control-to-page.html
- dom/SelectElement.h: Made destructor protected. Tweaked a bit.
- html/HTMLSelectElement.cpp: Removed unneeded includes. (WebCore::HTMLSelectElement::remove): Removed unneeded range check of the result of optionToListIndex. (WebCore::HTMLSelectElement::parseMappedAttribute): Removed code to set the unused attribute, m_minwidth. (WebCore::HTMLSelectElement::defaultEventHandler): The actual bug fix. Call through to the base class defaultEventHandler if the event hasn't been handled yet.
- html/HTMLSelectElement.h: Removed unneeded includes. Made a lot more functions private. Removed unused minWidth function and m_minwidth data member.
LayoutTests:
2009-05-30 Darin Adler <Darin Adler>
Reviewed by Adele Peterson.
Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element
- fast/forms/focus-control-to-page-expected.txt: Updated.
- fast/forms/focus-control-to-page.html: Added test of <select>, <textarea>, and <input type="password">, and made sure we can tab both in and out of each type.
- 4:20 PM Changeset in webkit [44291] by
-
- 2 edits1 move1 delete in trunk/WebCore
2009-05-30 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
The two KeyboardCodes.h files are basically identical and the
qt one is properly #ifdef-ed for different win32 systems. Share
them between Qt and Gtk implementations.
- GNUmakefile.am:
- platform/KeyboardCodes.h: Copied from WebCore/platform/qt/KeyboardCodes.h.
- platform/gtk/KeyboardCodes.h: Removed.
- platform/qt/KeyboardCodes.h: Removed.
- 3:58 PM Changeset in webkit [44290] by
-
- 2 edits in trunk/WebKit/mac
Add JSLock to -[WebScriptCallFrame scopeChain]
Reviewed by Darin Adler.
In Debug builds of WebKit, Dashcode launching MobileSafari could
cause the ASSERT(JSLock::lockCount() > 0) assertion to fire in
JSC::Heap::heapAllocate() because the JSLock wasn't taken.
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): Take JSLock before calling into JavaScriptCore.
- 3:38 PM Changeset in webkit [44289] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-05-30 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Sam Weinig.
LocalStorage and SessionStorage's implicit setters do not correctly
handle null. The custom JS bindings should convert to strings
unconditionally and not try to handle null specially.
https://bugs.webkit.org/show_bug.cgi?id=25970
- storage/domstorage/localstorage/string-conversion-expected.txt: Added.
- storage/domstorage/localstorage/string-conversion.html: Added.
- storage/domstorage/sessionstorage/string-conversion-expected.txt: Added.
- storage/domstorage/sessionstorage/string-conversion.html: Added.
- 3:38 PM Changeset in webkit [44288] by
-
- 2 edits in trunk/WebCore
2009-05-30 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Sam Weinig.
LocalStorage and SessionStorage's implicit setters do not correctly
handle null. The custom JS bindings should convert to strings
unconditionally and not try to handle null specially.
https://bugs.webkit.org/show_bug.cgi?id=25970
Tests: storage/domstorage/localstorage/string-conversion.html
storage/domstorage/sessionstorage/string-conversion.html
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::customPut):
- 1:35 PM Changeset in webkit [44287] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll bars in key window draw as inactive if the WebView is not active
Test: platform/mac/scrollbars/key-window-not-first-responder.html
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Use the window's key state instead of the WebView's first responder state to switch between active and inactive state.
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll bars in key window draw as inactive if the WebView is not active
- platform/mac/scrollbars/key-window-not-first-responder-expected.checksum: Added.
- platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
- platform/mac/scrollbars/key-window-not-first-responder-expected.txt: Added.
- platform/mac/scrollbars/key-window-not-first-responder.html: Added.
- 1:27 PM Changeset in webkit [44286] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-30 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6935193> REGRESSION (r42734): Celtic Kane JavaScript benchmark does not run:
"Maximum call stack size exceeded"
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): Use the same recursion limit as the other recursion checks. We need a limit of at least 100 to run the benchmark above. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncJoin): Ditto.
- 10:50 AM Changeset in webkit [44285] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- fix https://bugs.webkit.org/show_bug.cgi?id=18445 <rdar://problem/5931174> Assertion failure in CSSGradientValue::image with -webkit-gradient as body's background
Test: fast/backgrounds/body-generated-image-propagated-to-root.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Check if this is the root element painting a background layer propagated from the body, and if it is, use the body's renderer as the client to StyleImage::image().
LayoutTests:
Reviewed by Simon Fraser.
- test for https://bugs.webkit.org/show_bug.cgi?id=18445 <rdar://problem/5931174> Assertion failure in CSSGradientValue::image with -webkit-gradient as body's background
- fast/backgrounds/body-generated-image-propagated-to-root.html: Added.
- platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.checksum: Added.
- platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.png: Added.
- platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
- 9:50 AM Changeset in webkit [44284] by
-
- 2 edits in trunk/WebCore
2009-05-30 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed build fix for AXObjectCache.
For !HAVE(ACCESSIBILITY) postNotification was defined twice. Move
that into the #ifdef.
- accessibility/AXObjectCache.cpp:
May 29, 2009:
- 6:38 PM Changeset in webkit [44283] by
-
- 22 edits6 adds in trunk
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26072
Add support for the last missing WML element: <select>. This patch adds WMLSelectElement, providing
the same functionality HTMLSelectElement has. The WML specific features will follow soon.
Add simple testcase covering <select> element rendering: fast/wml/select.wml
- 3:55 PM Changeset in webkit [44282] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-29 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
Fixed compile warning when comparing the different navigation types
- webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_class_init):
- 3:42 PM Changeset in webkit [44281] by
-
- 2 edits in trunk/WebCore
2009-05-29 David Levin <levin@chromium.org>
Reviewed by NOBODY (build fix for windows).
http://trac.webkit.org/changeset/44279 left in a "Vector<WCHAR> localeNameBuf"
that it was trying to replace. Resulting in this variable being defined twice (and
the second time incorrectly).
- platform/win/Language.cpp: (WebCore::localeInfo):
- 3:02 PM Changeset in webkit [44280] by
-
- 2 edits in trunk/WebCore
2009-05-29 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Darin Alder.
Fix behavior of the Element View of the Web Inspector for double
clicking the element outline tree.
Double clicking the element outline tree should
1) on attribute: enter attribute editing mode
2) on text: enter text editing mode
3) otherwise: change root node to the parent element of double clicked
element.
Now, 3) is broken. For example, clicking <html> clears the element
outline view.
rootDOMNode should be updated to this.representedObject.parentNode, not
this.parent.representedObject which is parent inside the element
outline tree itself.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.ondblclick):
- 3:02 PM Changeset in webkit [44279] by
-
- 9 edits in trunk/WebCore
2009-05-29 David Moore <davemoore@google.com>
Reviewed by Darin Alder.
https://bugs.webkit.org/show_bug.cgi?id=26001
Change many of the uses of String::adopt() to String::createUninitialized().
This allows those strings to use an inlined buffer for their characters.
- dom/StyleElement.cpp: Loop over nodes to precompute length of string and then write the characters into the allocated inline buffer (WebCore::StyleElement::process):
- dom/Text.cpp: Loop over nodes to precompute length of string and then write the characters into the allocated inline buffer (WebCore::Text::wholeText): (WebCore::Text::rendererIsNeeded): (WebCore::Text::createRenderer): (WebCore::Text::createWithLengthLimit): (WebCore::Text::formatForDebugger):
- platform/text/String.cpp: (WebCore::String::append): (WebCore::String::insert): (WebCore::String::truncate): (WebCore::String::remove):
- platform/text/StringBuilder.cpp: (WebCore::StringBuilder::toString):
- platform/text/StringImpl.cpp: (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::replace):
- platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
- platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode):
- platform/win/Language.cpp: (WebCore::localeInfo):
- 3:02 PM Changeset in webkit [44278] by
-
- 3 edits4 adds in trunk
WebCore:
2009-05-29 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Darin Alder.
Bug 25911: Apply href in base elements to anchors shown on the source viewer
https://bugs.webkit.org/show_bug.cgi?id=25911
In rendering HTML sources, parse base elements to apply the base URI to
anchors shown on the source viewer.
This issue was originally reported to the Chromium issue tracker.
http://code.google.com/p/chromium/issues/detail?id=2418
Test: fast/frames/viewsource-link-on-href-value.html
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
LayoutTests:
2009-05-29 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Darin Alder.
Bug 25911: Apply href in base elements to anchors shown on the source viewer
https://bugs.webkit.org/show_bug.cgi?id=25911
In rendering HTML sources, parse base elements to apply the base URI to
anchors shown on the source viewer.
Add tests to verify this change.
This issue was originally reported to the Chromium issue tracker.
http://code.google.com/p/chromium/issues/detail?id=2418
- fast/frames/resources/viewsource-frame-3.html: Added.
- fast/frames/resources/viewsource-frame-4.html: Added.
- fast/frames/viewsource-link-on-href-value-expected.txt: Added.
- fast/frames/viewsource-link-on-href-value.html: Added.
- 3:02 PM Changeset in webkit [44277] by
-
- 3 edits2 adds in trunk
WebCore:
2009-05-29 Rob Buis <rwlbuis@gmail.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=22429
document.styleSheets collection ignores media=presentation
Ensure that stylesheets though <link> show up in document.styleSheets regardless of media attribute.
Test: fast/css/sheet-collection-link.html
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
LayoutTests:
2009-05-29 Rob Buis <rwlbuis@gmail.com>
Reviewed by David Hyatt.
Testcase for:
https://bugs.webkit.org/show_bug.cgi?id=22429
document.styleSheets collection ignores media=presentation
- fast/css/sheet-collection-link.html: Added.
- fast/css/sheet-collection-link-expected.txt: Added.
- 3:02 PM Changeset in webkit [44276] by
-
- 4 edits in trunk/WebCore
2009-05-29 Itai Danan <idanan@chromium.org>
Reviewed by Jon Honeycutt.
Bug 24791: Should have a preference to disable auto scrolling
https://bugs.webkit.org/show_bug.cgi?id=24791
To understand why this is required see the discussion in
issue 24722 (https://bugs.webkit.org/show_bug.cgi?id=24722).
The code review was done in https://bugs.webkit.org/show_bug.cgi?id=21794.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Use autoscroll behavior flag to determine if autoscroll needs to be released on this event. (WebCore::EventHandler::handleMouseReleaseEvent): Use autoscroll behavior flag to determine if autoscroll needs to be released on this event (reverse logic of for Press event).
- page/Settings.cpp: (WebCore::Settings::Settings): Initialize autoscroll behavior setting.
- page/Settings.h: (WebCore::Settings::setUsesStickyPanScroll): Autoscroll behavior setting setter. (WebCore::Settings::usesStickyPanScroll): Autoscroll behavior setting getter.
- 2:58 PM Changeset in webkit [44275] by
-
- 3 edits3 adds in trunk
WebCore:
2009-05-29 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26069
Fix a crash in custom V8 bindings code for XMLHttpRequest.
Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-29 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26069
Test for the above bug.
- fast/xmlhttprequest/resources/xmlhttprequest-open-after-iframe-onload-remove-self-child.html: Added.
- fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self-expected.txt: Added.
- fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html: Added.
- 2:38 PM Changeset in webkit [44274] by
-
- 2 edits in trunk/WebCore
2009-05-29 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
https://bugs.webkit.org/show_bug.cgi?id=26074
The constructor for SQLStatement already does a copy for this string.
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL):
- 1:53 PM Changeset in webkit [44273] by
-
- 2 edits in trunk/WebKit/win
Implement WebFrame::startDownload
Fixes the WebKit side of Bug 25729: Alt-clicking a link doesn't start
a download <https://bugs.webkit.org/show_bug.cgi?id=25729>. Fixing
this all the way will require a change in Safari.
Reviewed by Darin Adler.
- WebFrame.cpp: (WebFrame::startDownload): Call through to WebView::downloadURL.
- 1:51 PM Changeset in webkit [44272] by
-
- 3 edits in trunk/WebCore
2009-05-29 Darin Adler <Darin Adler>
Fix build; the new Cairo code compiled on Windows only.
- platform/graphics/gtk/FontPlatformData.h: Added syntheticBold and syntheticOblique functions as in the Windows version to make it easier to use this cross-platform. Later we can make data members private as in the Windows version.
- platform/graphics/mac/FontPlatformData.h: Ditto.
- 1:48 PM Changeset in webkit [44271] by
-
- 4 edits in trunk/WebKit/win
Move WebContextMenuClient's downloading code to WebView
This will allow other code to trigger downloads using this code, and
matches Mac.
Reviewed by Darin Adler.
- WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::downloadURL): Moved code from here...
- WebView.cpp: (WebView::downloadURL): ...to here. Also tightened up the code a little bit and removed an unnecessary LOG_ERROR.
- WebView.h: Added downloadURL.
- 1:41 PM Changeset in webkit [44270] by
-
- 7 edits in trunk
Roll out r44269
It contained some changes I didn't mean to have landed, and squashed
some distinct patches into a single commit.
- 1:33 PM Changeset in webkit [44269] by
-
- 7 edits in trunk
WebCore:
2009-05-29 Adam Roben <Adam Roben>
Make sure PlatformMouseEvent::modifierFlags contains MK_ALT when the
Alt key is pressed
First part of fixing Bug 25729: Alt-clicking a link doesn't start a
download
<https://bugs.webkit.org/show_bug.cgi?id=25729>
Reviewed by Darin Adler.
No test possible.
- platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Add MK_ALT to the modifier flags when the Alt key is pressed.
WebKit/win:
2009-05-29 Adam Roben <Adam Roben>
Implement WebFrame::startDownload
Fixes Bug 25729: Alt-clicking a link doesn't start a download
<https://bugs.webkit.org/show_bug.cgi?id=25729>
Reviewed by Darin Adler.
- WebFrame.cpp: (WebFrame::startDownload): Call through to WebView::downloadURL.
- 12:53 PM Changeset in webkit [44268] by
-
- 6 edits in trunk/WebCore
2009-05-29 Alexander Macdonald <alexmac@adobe.com>
Reviewed by Darin Adler.
Added support for synthetic bold/oblique font rendering
on platforms that use cairo.
- platform/graphics/SimpleFontData.h:
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
- platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
- platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit):
- 11:49 AM Changeset in webkit [44267] by
-
- 2 edits in trunk/WebKit/win
2009-05-29 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Darin Adler.
Correct Windows Cairo build error caused by @r42767.
http://bugs.webkit.org/show_bug.cgi?id=26082.
- WebError.cpp: (WebError::localizedDescription):
- 11:32 AM Changeset in webkit [44266] by
-
- 13 edits in trunk/WebCore
Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
https://bugs.webkit.org/show_bug.cgi?id=26024
- 9:55 AM Changeset in webkit [44265] by
-
- 2 edits in trunk/WebCore
2009-05-29 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Build fix for Windows Cairo target.
https://bugs.webkit.org/show_bug.cgi?id=25972
Compiler mistakenly selects SMILTime min/max instead of STL version,
resulting in a build error. This change makes the meaning of the
min/max explicit and avoids the problem.
- html/TimeRanges.h: (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
- 8:56 AM Changeset in webkit [44264] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-29 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=26075
[GTK] Refactor key scrolling code
After the scrolling changes in r44177 we can now use the
FrameView::scroll method like the other ports, keeping the magic
constants for the scrolling amounts inside WebCore proper.
- webkit/webkitwebview.cpp: (webkit_web_view_real_move_cursor):
- 7:48 AM Changeset in webkit [44263] by
-
- 12 edits2 adds in trunk
2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
Add a test-case for our HTTP backend, currently checking the
ref-counting of the SoupMessage.
- GNUmakefile.am:
WebCore:
2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
Make SoupMessage a member of ResourceRequest, instead of creating
it in startHttp. Implement updating of ResourceRequest from
SoupMessage, and vice versa.
- GNUmakefile.am:
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::gotHeadersCallback): (WebCore::ResourceHandle::startHttp):
- platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::~ResourceRequest):
- platform/network/soup/ResourceRequestSoup.cpp: Added. (WTF::SoupURI): (WebCore::ResourceRequest::soupMessage): (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):
WebKit/gtk:
2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
Make NetworkRequest carry a reference of the SoupMessage used by
ResourceRequest, and use that to create new ResourceRequests where
needed, so that no information is lost while passing around
NetworkRequest objects.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClient::startDownload):
- webkit/webkitdownload.cpp: (webkit_download_start):
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_finalize): (webkit_network_request_new_with_core_request): (webkit_network_request_new): (webkit_network_request_get_message):
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_load_request):
- 4:10 AM Changeset in webkit [44262] by
-
- 2 edits in trunk/LayoutTests
Fix error in test case i accidentally introduced.
May 28, 2009:
- 5:45 PM Changeset in webkit [44261] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 5:40 PM Changeset in webkit [44260] by
-
- 1 copy in tags/Safari-6530.14
New tag.
- 5:34 PM Changeset in webkit [44259] by
-
- 7 edits4 adds in branches/WWDC-2009-branch
Merge r44218.
- 5:34 PM Changeset in webkit [44258] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r44241.
- 5:34 PM Changeset in webkit [44257] by
-
- 4 edits in branches/WWDC-2009-branch
Merge r44216.
- 4:44 PM Changeset in webkit [44256] by
-
- 2 edits in trunk/WebCore
2009-05-28 Dmitry Titov <dimich@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26068
V8: Remove the remaining b8::Locker usage in worker code.
This completes the fix for https://bugs.webkit.org/show_bug.cgi?id=25944,
since the patches for enabling timers and that bug have "crossed in the queue".
Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- 3:38 PM Changeset in webkit [44255] by
-
- 4 edits in trunk/WebKit/mac
Build fix. Move off a deprecated NSFileManager method.
Rubber-stamped by Dan Bernstein.
- Misc/WebNSFileManagerExtras.h:
- Misc/WebNSFileManagerExtras.m:
(-[NSFileManager destinationOfSymbolicLinkAtPath:error:]): Implement a new-in-Leopard method for Tiger to use.
(-[NSFileManager attributesOfItemAtPath:error:]): Ditto.
- Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage _initWithPath:]): Use the new non-deprecated methods.
- 3:18 PM Changeset in webkit [44254] by
-
- 2 edits in trunk/WebCore
2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Simplify the Accept-Encoding header we are sending out, for it
seems some servers do not enjoy parsing the full, explicit
version.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
- 3:10 PM Changeset in webkit [44253] by
-
- 186 edits in trunk
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Added a new build flag --filters. This replaces the old --svg-filters and enables
other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
Filters are not working yet. This patch is just a preperation. Filters are deactivated by
default.
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- bindings/objc/DOM.mm: (WebCore::createElementClassMap):
- dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): (WebCore::isSVG11Feature):
- page/DOMWindow.idl:
- platform/graphics/filters/FEBlend.cpp:
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.cpp:
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.cpp:
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.cpp:
- platform/graphics/filters/FEComposite.h:
- platform/graphics/filters/FilterEffect.cpp:
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/SourceAlpha.cpp:
- platform/graphics/filters/SourceAlpha.h:
- platform/graphics/filters/SourceGraphic.cpp:
- platform/graphics/filters/SourceGraphic.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
- rendering/RenderSVGModelObject.cpp:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
- svg/Filter.cpp:
- svg/Filter.h:
- svg/FilterBuilder.cpp:
- svg/FilterBuilder.h:
- svg/SVGComponentTransferFunctionElement.cpp:
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGComponentTransferFunctionElement.idl:
- svg/SVGFEBlendElement.cpp:
- svg/SVGFEBlendElement.h:
- svg/SVGFEBlendElement.idl:
- svg/SVGFEColorMatrixElement.cpp:
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEColorMatrixElement.idl:
- svg/SVGFEComponentTransferElement.cpp:
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFEComponentTransferElement.idl:
- svg/SVGFECompositeElement.cpp:
- svg/SVGFECompositeElement.h:
- svg/SVGFECompositeElement.idl:
- svg/SVGFEDiffuseLightingElement.cpp:
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDiffuseLightingElement.idl:
- svg/SVGFEDisplacementMapElement.cpp:
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDisplacementMapElement.idl:
- svg/SVGFEDistantLightElement.cpp:
- svg/SVGFEDistantLightElement.h:
- svg/SVGFEDistantLightElement.idl:
- svg/SVGFEFloodElement.cpp:
- svg/SVGFEFloodElement.h:
- svg/SVGFEFloodElement.idl:
- svg/SVGFEFuncAElement.cpp:
- svg/SVGFEFuncAElement.h:
- svg/SVGFEFuncAElement.idl:
- svg/SVGFEFuncBElement.cpp:
- svg/SVGFEFuncBElement.h:
- svg/SVGFEFuncBElement.idl:
- svg/SVGFEFuncGElement.cpp:
- svg/SVGFEFuncGElement.h:
- svg/SVGFEFuncGElement.idl:
- svg/SVGFEFuncRElement.cpp:
- svg/SVGFEFuncRElement.h:
- svg/SVGFEFuncRElement.idl:
- svg/SVGFEGaussianBlurElement.cpp:
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEImageElement.cpp:
- svg/SVGFEImageElement.h:
- svg/SVGFEImageElement.idl:
- svg/SVGFELightElement.cpp:
- svg/SVGFELightElement.h:
- svg/SVGFEMergeElement.cpp:
- svg/SVGFEMergeElement.h:
- svg/SVGFEMergeElement.idl:
- svg/SVGFEMergeNodeElement.cpp:
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMergeNodeElement.idl:
- svg/SVGFEOffsetElement.cpp:
- svg/SVGFEOffsetElement.h:
- svg/SVGFEOffsetElement.idl:
- svg/SVGFEPointLightElement.cpp:
- svg/SVGFEPointLightElement.h:
- svg/SVGFEPointLightElement.idl:
- svg/SVGFESpecularLightingElement.cpp:
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFESpecularLightingElement.idl:
- svg/SVGFESpotLightElement.cpp:
- svg/SVGFESpotLightElement.h:
- svg/SVGFESpotLightElement.idl:
- svg/SVGFETileElement.cpp:
- svg/SVGFETileElement.h:
- svg/SVGFETileElement.idl:
- svg/SVGFETurbulenceElement.cpp:
- svg/SVGFETurbulenceElement.h:
- svg/SVGFETurbulenceElement.idl:
- svg/SVGFilterElement.cpp:
- svg/SVGFilterElement.h:
- svg/SVGFilterElement.idl:
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/graphics/SVGResourceFilter.cpp:
- svg/graphics/SVGResourceFilter.h:
- svg/graphics/cairo/SVGResourceFilterCairo.cpp:
- svg/graphics/cg/SVGResourceFilterCg.cpp:
- svg/graphics/cg/SVGResourceFilterCg.mm:
- svg/graphics/filters/SVGDistantLightSource.h:
- svg/graphics/filters/SVGFEConvolveMatrix.cpp:
- svg/graphics/filters/SVGFEConvolveMatrix.h:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp:
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFEDisplacementMap.cpp:
- svg/graphics/filters/SVGFEDisplacementMap.h:
- svg/graphics/filters/SVGFEFlood.cpp:
- svg/graphics/filters/SVGFEFlood.h:
- svg/graphics/filters/SVGFEGaussianBlur.cpp:
- svg/graphics/filters/SVGFEGaussianBlur.h:
- svg/graphics/filters/SVGFEImage.cpp:
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFEMerge.cpp:
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFEMorphology.cpp:
- svg/graphics/filters/SVGFEMorphology.h:
- svg/graphics/filters/SVGFEOffset.cpp:
- svg/graphics/filters/SVGFEOffset.h:
- svg/graphics/filters/SVGFESpecularLighting.cpp:
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGFETile.cpp:
- svg/graphics/filters/SVGFETile.h:
- svg/graphics/filters/SVGFETurbulence.cpp:
- svg/graphics/filters/SVGFETurbulence.h:
- svg/graphics/filters/SVGFilterEffect.cpp:
- svg/graphics/filters/SVGFilterEffect.h:
- svg/graphics/filters/SVGLightSource.cpp:
- svg/graphics/filters/SVGLightSource.h:
- svg/graphics/filters/SVGPointLightSource.h:
- svg/graphics/filters/SVGSpotLightSource.h:
- svg/graphics/filters/cg/SVGFEHelpersCg.h:
- svg/graphics/filters/cg/SVGFEHelpersCg.mm:
- svg/graphics/filters/cg/SVGFilterEffectCg.mm:
- svg/graphics/filters/cg/WKArithmeticFilter.h:
- svg/graphics/filters/cg/WKArithmeticFilter.m:
- svg/graphics/filters/cg/WKComponentMergeFilter.h:
- svg/graphics/filters/cg/WKComponentMergeFilter.m:
- svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
- svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
- svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
- svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
- svg/graphics/filters/cg/WKDisplacementMapFilter.h
- svg/graphics/filters/cg/WKDisplacementMapFilter.m:
- svg/graphics/filters/cg/WKDistantLightFilter.h:
- svg/graphics/filters/cg/WKDistantLightFilter.m:
- svg/graphics/filters/cg/WKGammaTransferFilter.h:
- svg/graphics/filters/cg/WKGammaTransferFilter.m:
- svg/graphics/filters/cg/WKIdentityTransferFilter.h:
- svg/graphics/filters/cg/WKIdentityTransferFilter.m:
- svg/graphics/filters/cg/WKLinearTransferFilter.h:
- svg/graphics/filters/cg/WKLinearTransferFilter.m:
- svg/graphics/filters/cg/WKNormalMapFilter.h:
- svg/graphics/filters/cg/WKNormalMapFilter.m:
- svg/graphics/filters/cg/WKPointLightFilter.h:
- svg/graphics/filters/cg/WKPointLightFilter.m:
- svg/graphics/filters/cg/WKSpecularLightingFilter.h:
- svg/graphics/filters/cg/WKSpecularLightingFilter.m:
- svg/graphics/filters/cg/WKSpotLightFilter.h:
- svg/graphics/filters/cg/WKSpotLightFilter.m:
- svg/graphics/filters/cg/WKTableTransferFilter.h:
- svg/graphics/filters/cg/WKTableTransferFilter.m:
- svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
- svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
- svg/graphics/qt/SVGResourceFilterQt.cpp:
- svg/graphics/skia/SVGResourceFilterSkia.cpp:
- svg/svgtags.in:
*WebKit/mac/
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Added new build flag --filters. More details in WebCore/ChangeLog.
- Configurations/FeatureDefines.xcconfig:
*.
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Enable the new build flag --filters for Gtk. More details in WebCore/ChangeLog.
- configure.ac:
*JavaScriptCore/
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Added new build flag --filters for Mac. More details in WebCore/ChangeLog.
- Configurations/FeatureDefines.xcconfig:
*WebKitTools
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Added new build flag --filters. More details in WebCore/ChangeLog.
- Scripts/build-webkit:
- 2:05 PM Changeset in webkit [44252] by
-
- 2 edits in trunk/WebCore
2009-05-28 Brett Wilson <brettw@chromium.org>
Unreviewed, build fix.
Add casts for scale function to make more explicit what is happening
and fix a compiler warning.
- platform/graphics/IntSize.h: (WebCore::IntSize::scale):
- 1:56 PM Changeset in webkit [44251] by
-
- 2 edits in trunk/WebKit
Symlink WebKitPluginHost.app in to place if needed.
Rubber-stamped by Anders Carlsson.
- WebKit.xcodeproj/project.pbxproj:
- 12:37 PM Changeset in webkit [44250] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.8
Tagging 1.1.8.
- 12:27 PM Changeset in webkit [44249] by
-
- 4 edits in trunk/WebCore
2009-05-28 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
are not cleared on navigation it is no longer necessary.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::showModalDialog):
- 11:35 AM Changeset in webkit [44248] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26048
navigation-policy-decision-requested documentation incomplete
Fix documentation for all policy decision request signals, to
mention that an actual decision is expected when you return TRUE,
meaning that you handled the signal.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- 11:33 AM Changeset in webkit [44247] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Mention the implementation of the new AtkText methods.
- NEWS:
- 11:20 AM Changeset in webkit [44246] by
-
- 5 edits1 add in trunk
2009-05-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo and Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Add new test file for ATK.
- GNUmakefile.am:
WebCore:
2009-05-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo and Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Implement atk_text_get_text_{at,after,before}_offset.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
WebKit/gtk:
2009-05-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo and Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
New test file for ATK functionality.
- tests/testatk.c: Added. (bail_out): (test_get_text_function): (test_webkit_atk_get_text_at_offset): (main):
- 11:04 AM Changeset in webkit [44245] by
-
- 5 edits in trunk/WebCore
Rubber-stamped by Darin Adler.
Remove unnecessary destructor from InputElementData/OptionElementData.
- 10:50 AM Changeset in webkit [44244] by
-
- 3 edits in tags/Safari-6530.13.1/WebCore
Merge r44233.
- 10:49 AM Changeset in webkit [44243] by
-
- 9 edits in trunk/WebCore
Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26062
Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.
- 10:48 AM Changeset in webkit [44242] by
-
- 2 edits in trunk
2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Fix webkitgtk_cleanfiles to clean gtk-doc-related files in the
correct directory, so that we pass make distcheck.
- GNUmakefile.am:
- 10:46 AM Changeset in webkit [44241] by
-
- 2 edits in trunk/WebCore
Don't try to use the new combobox parts on Vista in Classic mode
Fixes:
<rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
theme: drop down lists in Preferences get a line/square
<rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
down lists are black with a circle on many sites
Reviewed by Steve Falkenburg.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMenuList): Only use the new combobox parts when we have a theme (i.e., when we're not in Classic mode). When we don't have a theme, fall back to the pre-r42289 code.
- 10:36 AM Changeset in webkit [44240] by
-
- 1 copy in tags/Safari-6530.13.1
New tag.
- 10:35 AM Changeset in webkit [44239] by
-
- 1 delete in tags/Safari-6530.13.1
Delete incorrect tag.
- 10:34 AM Changeset in webkit [44238] by
-
- 1 copy in tags/Safari-6530.13.1
New tag.
- 10:29 AM Changeset in webkit [44237] by
-
- 2 edits in trunk/WebCore
2009-05-27 Peter Kasting <pkasting@google.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=25659
Avoid calling frameCount() unnecessarily (which could lead to extra
GIF decoding).
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
- 9:58 AM Changeset in webkit [44236] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Document changes worth noting for 1.1.8.
- NEWS:
- 9:55 AM Changeset in webkit [44235] by
-
- 16 edits6 adds in trunk
WebCore:
2009-05-28 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
Tests: fast/borders/border-radius-constraints.html
fast/borders/border-radius-split-inline.html
When the sum of the corner radii on a side exceed the length of the side,
reduce the radii according to CSS 3 rules.
Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
the constraints. Use that for painting borders, box-shadow, clipping replaced
elements
- platform/graphics/IntSize.h: (WebCore::IntSize::scale): Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
- platform/graphics/Path.cpp: Make the QUARTER const static.
- rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): Use getBorderRadiiForRect to fetch border radii.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use getBorderRadiiForRect to fetch border radii.
(WebCore::RenderBoxModelObject::paintBorder):
Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
borders for split inlines, which used to apply the radii for each segment,
and no longer does.
(WebCore::RenderBoxModelObject::paintBoxShadow):
Use getBorderRadiiForRect to fetch border radii.
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): Use getBorderRadiiForRect to fetch border radii for clipping.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Use getBorderRadiiForRect to fetch border radii for clipping.
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getBorderRadiiForRect): New bottleneck method to fetch corner radiil given a rect, applying the constraint rules.
LayoutTests:
2009-05-28 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
- fast/borders/border-radius-constraints.html: Added.
- platform/mac/fast/borders/border-radius-constraints-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
- platform/mac/fast/borders/border-radius-constraints-expected.txt: Added.
Test that corner radii are constrained according to CSS3 rules.
- fast/borders/border-radius-huge-assert.html:
- platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
- platform/mac/fast/borders/border-radius-huge-assert-expected.png:
- platform/mac/fast/borders/border-radius-huge-assert-expected.txt:
Now that we constrain border-radius, update the text of the test, and the
expected result.
- fast/borders/border-radius-split-inline.html: Added.
- platform/mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
- platform/mac/fast/borders/border-radius-split-inline-expected.txt: Added.
New test for border-radius on a split inline.
- fast/box-shadow/border-radius-big.html:
- platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
- platform/mac/fast/box-shadow/border-radius-big-expected.png:
- platform/mac/fast/box-shadow/border-radius-big-expected.txt:
Now that we constrain border-radius, update the text of the test, and the
expected result.
- 9:50 AM Changeset in webkit [44234] by
-
- 2 edits in trunk/WebKitTools
2009-05-28 Olivier DOLE <odole@pleyo.com>
Reviewed by Maciej.
Add options to sunspider-compare-results to know which test suite to
compare (see bug #15941).
- Scripts/sunspider-compare-results:
- 9:46 AM Changeset in webkit [44233] by
-
- 3 edits in branches/WWDC-2009-branch/WebCore
Windows build fix after r44178
- 9:23 AM Changeset in webkit [44232] by
-
- 9 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26005
Optimization for XPath * does not preserve context size
Test: fast/xpath/position.html
Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
get a performance progression on my tests.
- xml/XPathPath.h: Removed broken optimizeStepPair().
- xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Style fix. (WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair(). (WebCore::XPath::LocationPath::insertFirstStep): Ditto. (WebCore::XPath::Path::Path): Style fix.
- xml/XPathStep.cpp: (WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper. (WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported (and might never be). (WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
- xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::data): (WebCore::XPath::Step::NodeTest::namespaceURI): Made these data members AtomicString to avoid repeated conversions. This is the biggest performance win here.
- xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
- 9:20 AM Changeset in webkit [44231] by
-
- 2 edits in trunk/WebCore
2009-05-28 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
When creating a linear or radial gradient with a single stop
at offset 1.0, the Skia layer was allocating 3 stops, but only
filling 2, leaving one uninitialized. Only 2 stops are necessary
in this case, at offsets (0.0, 1.0).
Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg
LayoutTests/svg/custom/gradient-stop-corner-cases.svg
LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg
- platform/graphics/skia/GradientSkia.cpp: (WebCore::totalStopsNeeded):
- 9:14 AM Changeset in webkit [44230] by
-
- 8 edits in trunk/WebCore
2009-05-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=26041
Allow adding resource source to WebInspector.SourceFrame asynchronously.
Provide common implementation for InspectorController::addResourceSourceToFrame and
InspectorController::addSourceToFrame methods.
- bindings/js/JSInspectorControllerCustom.cpp:
- bindings/v8/custom/V8InspectorControllerCustom.cpp:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addResourceSourceToFrame):
- inspector/InspectorController.h:
- inspector/InspectorController.idl:
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.highlightLine): (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceFrame.prototype._isContentLoaded):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype._contentLoaded):
- 8:45 AM Changeset in webkit [44229] by
-
- 2 edits in trunk
2009-05-28 Xan Lopez <xlopez@igalia.com>
Bump version numbers in preparation for 1.1.8 release.
- configure.ac:
- 7:52 AM Changeset in webkit [44228] by
-
- 6 edits in trunk/WebKit/gtk
2009-05-27 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes
Modify the management of history items by the BackForward list.
Having the objects add themselves to a hash table with an extra
reference made impossible for the cleanup code in the dispose
method to be ever called in normal conditions, since dispose is
called before getting rid of the last reference, which the objects
were making to themselves. Get rid of this extra reference and
move the responsibility of the cleanup to the BackForward list
itself, which effectively owns the WebKitWebHistoryItems now.
Also, update the tests to reflect this change.
- tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
- tests/testwebhistoryitem.c: (web_history_item_fixture_setup): (web_history_item_fixture_teardown):
- webkit/webkitprivate.h:
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_dispose): (webkit_web_back_forward_list_class_init):
- webkit/webkitwebhistoryitem.cpp: (webkit_history_items): (webkit_history_item_add): (webkit_web_history_item_dispose): (WebKit::kit):
- 7:52 AM Changeset in webkit [44227] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes
Delete the BackForwardList before the Page, otherwise the references
to the WebKitWebHistoryItems will be gone.
- webkit/webkitwebview.cpp: (webkit_web_view_dispose):
- 5:04 AM Changeset in webkit [44226] by
-
- 2 edits in trunk/WebCore
2009-05-28 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
After r44177 we had a problem when increasing the size
of the window the scrollbars stayed and were not hidden.
This was due WebCore giving up on the Scrollbar as it became
unnecessary but the GtkAdjustment remained unchanged.
So from the point of view of the GtkScrolledWindow scrolling
was still necessary and the GtkScrollbar kept being displayed.
Solve the issue by resetting the GtkAdjustment in the
destructor of ScrollbarGtk.
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::~ScrollbarGtk):
- 1:04 AM Changeset in webkit [44225] by
-
- 7 edits2 adds in trunk
WebCore:
2009-05-28 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Clean up window.open()'s use of lexical and dynamic scope.
(Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
for DOMWindow::allowPopUp.)
Test: http/tests/security/frameNavigation/context-for-window-open.html
- bindings/js/JSDOMBinding.cpp: (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::createWindow):
LayoutTests:
2009-05-28 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Test whether lexical or dynamic scope is used for window.open().
- http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
- http/tests/security/frameNavigation/context-for-window-open.html: Added.
- http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
- 12:31 AM Changeset in webkit [44224] by
-
- 886 edits2 deletes in trunk
Revert 44221.
May 27, 2009:
- 11:36 PM Changeset in webkit [44223] by
-
- 1 edit in trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a
Fix MIME type.
- 11:31 PM Changeset in webkit [44222] by
-
- 5 edits1 add in trunk
Update build-webkit to handle a new version of WebKitSystemInterface.
Rubber-stamped by Dan Bernstein.
- Scripts/build-webkit:
Update WebKitSystemInterface.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a: Added.
- libWebKitSystemInterfaceTiger.a:
- 11:25 PM Changeset in webkit [44221] by
-
- 7 edits2 adds in trunk
WebCore:
2009-05-27 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Clean up window.open()'s use of lexical and dynamic scope.
Test: http/tests/security/frameNavigation/context-for-window-open.html
- bindings/js/JSDOMBinding.cpp: (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::createWindow):
LayoutTests:
2009-05-27 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Test whether lexical or dynamic scope is used for window.open().
- http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
- http/tests/security/frameNavigation/context-for-window-open.html: Added.
- http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
- 11:02 PM Changeset in webkit [44220] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=26056
XPath string() function can be very slow
- xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Use an intermediate Vector when appending.
- 10:30 PM Changeset in webkit [44219] by
-
- 2 edits in trunk/WebKitSite
2009-05-27 Maciej Stachowiak <mjs@apple.com>
Not reviewed, demo content.
- Add doctype to Calendar demo.
- demos/calendar/Calendar.html:
- 10:25 PM Changeset in webkit [44218] by
-
- 7 edits4 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix <rdar://problem/6927761> <isindex> placeholder text is unstylable and initially not visible
Test: fast/forms/isindex-placeholder.html
- css/html4.css: Added a default style for <isindex> placeholder text.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call the new protected function updatePlaceholderVisibility().
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::updatePlaceholderVisibility): Added this protected function to allow HTMLIsIndexElement::parseMappedAttribute() to invoke InputElement::updatePlaceholderVisibility().
- html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::parseMappedAttribute): Call updatePlaceholderVisibility() when parsing the placeholder attribute.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerTextStyle): If there is no placeholder pseudo-element style, use the normal style.
LayoutTests:
Reviewed by Sam Weinig.
- test for <rdar://problem/6927761> <isindex> placeholder text is unstylable and initially not visible
- fast/forms/isindex-placeholder.html: Added.
- platform/mac/fast/forms/isindex-placeholder-expected.checksum: Added.
- platform/mac/fast/forms/isindex-placeholder-expected.png: Added.
- platform/mac/fast/forms/isindex-placeholder-expected.txt: Added.
- 10:06 PM Changeset in webkit [44217] by
-
- 7 edits in trunk/WebCore
2009-05-27 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
More cleanup of DOMWindow related functions.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Renamed from JSDOMWindowBase::clear()
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::showModalDialog): Update Comment.
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDOMWindowShell.h: Remove JSDOMWindowShell::clear(). It was unused.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
- 8:36 PM Changeset in webkit [44216] by
-
- 4 edits in trunk
<rdar://problem/6928025> Stack overflow in JSC::stringProtoFuncReplace() running jsFunFuzz
Reviewed by Mark Rowe
Add an additional exception check for stack overflow in String.replace
- 8:17 PM Changeset in webkit [44215] by
-
- 7 edits in trunk/WebCore
2009-05-27 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Miscellaneous cleanup of DOMWindow related functions.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): Fix poorly named variables.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsProfiling): Don't jump through hoops checking for null frames if the build does not support profiling. (WebCore::JSDOMWindowBase::clear): Use setCurrentEvent(0) instead of calling clearHelperObjectProperties(). It is clearer.
- bindings/js/JSDOMWindowBase.h: Removed now unused clearHelperObjectProperties() function, empty disconnectFrame() function, and the empty destructor.
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDOMWindowShell.h: Remove disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which is a no-op.
- page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): Remove calls to JSDOMWindowShell::disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which is a no-op.
- 6:50 PM Changeset in webkit [44214] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 6:49 PM Changeset in webkit [44213] by
-
- 1 copy in tags/Safari-6530.13
New tag.
- 5:28 PM Changeset in webkit [44212] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r44194.
- 5:27 PM Changeset in webkit [44211] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r44189.
- 5:27 PM Changeset in webkit [44210] by
-
- 7 edits in branches/WWDC-2009-branch
Merge r44181.
- 5:27 PM Changeset in webkit [44209] by
-
- 6 edits3 adds in branches/WWDC-2009-branch
Merge r44174.
- 5:27 PM Changeset in webkit [44208] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r44172.
- 5:27 PM Changeset in webkit [44207] by
-
- 11 edits in branches/WWDC-2009-branch
Merge r44170.
- 5:27 PM Changeset in webkit [44206] by
-
- 2 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r44169.
- 5:27 PM Changeset in webkit [44205] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r44164.
- 5:27 PM Changeset in webkit [44204] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r44122.
- 5:13 PM Changeset in webkit [44203] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-27 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
Add comment to clarify why scrolling is done as it is and not with
gdk_window_scroll.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scroll):
- 3:16 PM Changeset in webkit [44202] by
-
- 2 edits in trunk/WebCore
2009-05-27 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=25974
Remove extra qualifiers from the ScheduledAction decl.
- bindings/v8/ScheduledAction.h: Removed extraneous class qualifiers.
- 2:23 PM Changeset in webkit [44201] by
-
- 2 edits in trunk/WebCore
2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed make distcheck fix. One more missing file.
- GNUmakefile.am:
- 2:09 PM Changeset in webkit [44200] by
-
- 2 edits in trunk/WebCore
2009-05-27 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Fixed trunk build on Linux after r44126.
- 1:46 PM Changeset in webkit [44199] by
-
- 2 edits in trunk/WebCore
2009-05-27 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6926046> REGRESSION (r43972): http://www.youtube.com/html5 crashes on open
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Don't look for a media engine based on an empty MIME type.
- 1:04 PM Changeset in webkit [44198] by
-
- 1 edit18 adds in trunk/WebKitSite
2009-05-27 Maciej Stachowiak <mjs@apple.com>
Not reviewed, demo content.
- add Calendar demo.
- demos/calendar: Added.
- demos/calendar/Boom.aiff: Added.
- demos/calendar/Calendar.css: Added.
- demos/calendar/Calendar.html: Added.
- demos/calendar/Calendar.js: Added.
- demos/calendar/Calendar.manifest: Added.
- demos/calendar/CalendarApp.icns: Added.
- demos/calendar/Images: Added.
- demos/calendar/Images/AirPort4.png: Added.
- demos/calendar/Images/AirPortError.png: Added.
- demos/calendar/Images/disclosureTriangleSmallDown.png: Added.
- demos/calendar/Images/disclosureTriangleSmallRight.png: Added.
- demos/calendar/Images/statusbarBackground.png: Added.
- demos/calendar/Images/statusbarResizerVertical.png: Added.
- demos/calendar/LocationImage.js: Added.
- demos/calendar/Utilities.js: Added.
- demos/calendar/favicon.ico: Added.
- demos/calendar/mime.types: Added.
- 12:20 PM Changeset in webkit [44197] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed (make distcheck) build fix; adding missing headers.
- GNUmakefile.am:
- 12:14 PM Changeset in webkit [44196] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-27 Jessie Berlin <jberlin@apple.com>
Reviewed by aroben
Fix the Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 12:03 PM Changeset in webkit [44195] by
-
- 3 edits in trunk/WebCore
2009-05-27 David Levin <levin@chromium.org>
Reviewed by Maciej Stachowiak.
Bug 26029: FrameLoader::canLoad should allow calls with just a security origin
https://bugs.webkit.org/show_bug.cgi?id=26029
No functional changes, so no tests.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canLoad):
- loader/FrameLoader.h:
- 11:01 AM Changeset in webkit [44194] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26009
<rdar://problem/6925656> REGRESSION (r43973): Problems While Working With OpenVanilla
- WebView/WebHTMLView.mm: (-[WebHTMLView _updateSelectionForInputManager]): Don't call updateWindows if the selection is None. This routinely happens during editing, and it doesn't mean that we left an editable area (in which case the selection changes to a non-editable one).
- 10:57 AM Changeset in webkit [44193] by
-
- 2 edits in trunk/WebCore
2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix.
Remove file that does not exist from the build.
- GNUmakefile.am:
- 10:33 AM Changeset in webkit [44192] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
Remove two unneeded protected constructors, these classes have pure-virtual functions, and can't be constructed anyway.
- 10:27 AM Changeset in webkit [44191] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Adding new symbols index for 1.1.8.
- docs/webkitgtk-docs.sgml:
- 10:21 AM Changeset in webkit [44190] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=17725
XPath should be case insensitive for HTML
Test: fast/xpath/node-name-case-sensitivity.html
- xml/XPathStep.cpp: (WebCore::XPath::Step::nodeMatches): Made node name check case insensitive for HTML elements in HTML documents.
- 10:00 AM Changeset in webkit [44189] by
-
- 2 edits in trunk/WebCore
2009-05-27 John Sullivan <sullivan@apple.com>
fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
bookmarks (at least) over Top Sites (at least)
Reviewed by Kevin Decker
- page/DragController.cpp: (WebCore::DragController::dragExited): nil check m_documentUnderMouse and take the "local file" case if it's nil
- 7:02 AM Changeset in webkit [44188] by
-
- 4 edits in trunk
WebCore and JavaScriptCore
2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Gustavo Noronha.
When building on Windows, consider Windows specific files.
- GNUmakefile.am:
- 5:25 AM Changeset in webkit [44187] by
-
- 5 edits in trunk/WebCore
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26031
InputElementData is too heavy, save storing two pointers by passing them
directly to the static helper functions (the only place which needs them).
- 5:23 AM Changeset in webkit [44186] by
-
- 5 edits in trunk/WebCore
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26033
OptionElementData saves an Element pointer, which is unnessary.
Just pass it to the static function calls directly.
- 5:17 AM Changeset in webkit [44185] by
-
- 2 edits in trunk/LayoutTests
2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disabling new tests to make the bot green.
- platform/gtk/Skipped:
- 5:04 AM Changeset in webkit [44184] by
-
- 6 edits in trunk
2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Maciej Stachowiak.
When building with MinGW, don't use the declspec(dl{import,export})
decorations and rely on the linker to use its nifty auto-import feature.
It is extremely hard to get the decorations right with MinGW in general
and impossible in WebKit, where the resulting shared library is linking
together some static libraries.
- JavaScriptCore/config.h
- WebCore/config.h
- DumpRenderTree/config.h:
- 3:21 AM Changeset in webkit [44183] by
-
- 9 edits2 adds in trunk
JavaScripCore:
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
Be able to use GOwnPtr for GHashTable as well. The assumption
is that the hash table has been created with g_hash_table_new_full
and has proper destruction functions.
- wtf/GOwnPtr.cpp: (WTF::GHashTable):
- wtf/GOwnPtr.h:
WebCore:
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
Add a WebCore::Widget that can embed GtkWidget with and
without a GdkWindow. This can be used to embed any GtkWidget.
Some bits are directly copied from the Scrollbar implementation
but can not be easily shared here.
- GNUmakefile.am:
- platform/gtk/GtkPluginWidget.cpp: Added. (WebCore::GtkPluginWidget::GtkPluginWidget): (WebCore::GtkPluginWidget::invalidateRect): (WebCore::GtkPluginWidget::frameRectsChanged): (WebCore::GtkPluginWidget::paint):
- platform/gtk/GtkPluginWidget.h: Added.
WebKit:
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
Add a new signal called "create-plugin-widget" and emit it from
within the FrameLoaderClientGtk::createPlugin method. If a
GtkWidget gets returned it will be embedded as a WebCore::Widget
using the new GtkPluginWidget.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
- webkit/webkitwebview.cpp: (webkit_signal_accumulator_object_handled): (webkit_web_view_class_init):
- webkitmarshal.list:
- 3:21 AM Changeset in webkit [44182] by
-
- 2 edits in trunk/WebCore
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Gustavo Noronha.
Implement Widget::setIsSelected for Gtk+ by searching
for a property of the name "webkit-widget-is-selected" and if
such property exists we are going to set it. We expect
the property to take a boolean.
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setIsSelected):
May 26, 2009:
- 11:53 PM Changeset in webkit [44181] by
-
- 7 edits in trunk
WebCore:
2009-05-26 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Fix for <rdar://problem/6916371>
iWeb 'Announce' button does nothing after publishing to MobileMe
Add ability to force content sniffing for all urls (including file: urls)
- WebCore.base.exp:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::shouldContentSniffURL): (WebCore::ResourceHandle::forceContentSniffing):
- platform/network/ResourceHandle.h:
WebKit/mac:
2009-05-26 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Fix for <rdar://problem/6916371>
iWeb 'Announce' button does nothing after publishing to MobileMe
Add linked-on-or-after check to allow older WebKit apps to use the
old behavior of sniffing everything (including file: urls)
- Misc/WebKitVersionChecks.h:
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
- 11:35 PM Changeset in webkit [44180] by
-
- 5 edits1 add in trunk/WebKit/qt
2009-05-26 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Holger Freyther.
Add an API to generate a QUrl out of a string correcting for errors and missing information.
See the API documentation for more details about the function.
Autotests: included
- Api/qwebview.cpp: (QWebView::guessUrlFromString):
- Api/qwebview.h:
- QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::changeLocation):
- tests/qwebview/.gitignore: Added.
- tests/qwebview/qwebview.pro:
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::initTestCase): (tst_QWebView::cleanupTestCase): (tst_QWebView::init): (tst_QWebView::cleanup): (tst_QWebView::guessUrlFromString_data): (tst_QWebView::guessUrlFromString):
- 11:35 PM Changeset in webkit [44179] by
-
- 2 edits in trunk/WebCore
2009-05-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] Dead-code stripping for unix
- WebCore.pro: Turn on GCC dead-code stripping flags for Unix
- 11:25 PM Changeset in webkit [44178] by
-
- 8 edits in branches/WWDC-2009-branch/WebCore
2009-05-26 Beth Dakin <Beth Dakin>
Rubber-stamped by Dan Bernstein and Darin Adler.
Fix for <rdar://problem/6922919> Revert back to Safari 3 text
control metrics calculations
We're rolling this change out of the branch because we think it
needs more bake time.
- css/html4.css:
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
- platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::lineGap):
- platform/graphics/mac/SimpleFontDataMac.mm:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- 10:25 PM Changeset in webkit [44177] by
-
- 6 edits in trunk/WebCore
[GTK] Send onscroll events for the main FrameView
2009-05-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Dave Hyatt.
[GTK] Send onscroll events for the main FrameView
WebKit/GTK+ is currently not sending any onscroll
events for a frame with external adjustments. This is
due the fact that the value-changed signal of the GtkAdjustment
is handled by WebCore::ScrollView directly and is not going through
the WebCore::Scrollbar -> WebCore::ScrollbarClient ->
WebCore::FrameView::valueChanged -> WebCore::ScrollView::valueChanged
path.
Fix the above problem by wrapping the GtkAdjustment we get
assigned from GTK+ in a ScrollbarGtk that will not have any
visual appearance. Remove code from ScrollView that knows
about adjustments and create a special case for
WebCore::ScrollView::createScrollbar that will create such
a special WebCore::ScrollbarGtk.
- platform/ScrollView.cpp: Remove adjustment code (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h: Remove adjustment code
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformDestroy): (WebCore::ScrollView::createScrollbar): (WebCore::ScrollView::setGtkAdjustments):
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::createScrollbar): Special case. (ScrollbarGtk::ScrollbarGtk): New ctor and work on the adjustment (ScrollbarGtk::~ScrollbarGtk): Disconnect signal (ScrollbarGtk::frameRectsChanged): Do nothing when we lack a platformWidget
- platform/gtk/ScrollbarGtk.h:
- 10:20 PM Changeset in webkit [44176] by
-
- 2 edits in trunk/WebCore
2009-05-26 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Bug 26035: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
<https://bugs.webkit.org/show_bug.cgi?id=26035>
<rdar://problem/6924087>
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameHasAlphaAtIndex): return false if the image is JPEG, there is no image type, or m_decoder is null.
- 9:30 PM Changeset in webkit [44175] by
-
- 2 edits in trunk/WebCore
Fix build breakage of JPEGImageDecoder.cpp by including stdio.h again.
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed build fix for the JPEGImageDecoder.
Revision 44167 removed stdio.h from the included headers and
this will lead to an error that FILE is not known inside the
jpeglib.h Put back the stdio.h include.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- 8:22 PM Changeset in webkit [44174] by
-
- 6 edits3 adds in trunk
<rdar://problem/6924033> REGRESSION: Assertion failure due to forward references
Reviewed by Gavin Barraclough.
Add a pattern type for forward references to ensure that we don't confuse the
quantifier alternatives assertion.
- 7:54 PM Changeset in webkit [44173] by
-
- 2 edits in trunk/WebCore
2009-05-26 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by Maciej Stachowiak.
Fix the crash issue while running layout tests after enabled XHTMLMP
https://bugs.webkit.org/show_bug.cgi?id=26017
- 7:47 PM Changeset in webkit [44172] by
-
- 2 edits in trunk/WebKit/mac
2009-05-26 Stephanie Lewis <Stephanie Lewis>
Reviewed by Ada Chan and Oliver Hunt.
Remove WebView observers in during fast teardown.
<rdar://problem/6922619> REGRESSION (Tiger-only?): After restoring windows from the previous session, a crash occurs while attempting to quit Safari
- WebView/WebView.mm: (-[WebView _closeWithFastTeardown]):
- 7:47 PM Changeset in webkit [44171] by
-
- 6 edits in trunk/JavaScriptCore
2009-05-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Fix for: <rdar://problem/6918095> REGRESSION: jQuery load() issue (25981),
and also an ASSERT failure on http://ihasahotdog.com/.
When overwriting a property on a dictionary with a cached specific value,
clear the cache if new value being written is different.
- JavaScriptCore.exp:
Export the new symbols.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_get_by_id_method_check_second):
Close dictionary prototypes upon caching a method access, as would happen when caching
a regular get_by_id.
- runtime/JSObject.h: (JSC::JSObject::propertyStorage): (JSC::JSObject::locationForOffset):
Make these methods private.
(JSC::JSObject::putDirectInternal):
When overwriting a property on a dictionary with a cached specific value,
clear the cache if new value being written is different.
- runtime/Structure.cpp: (JSC::Structure::despecifyDictionaryFunction):
Reset the specific value field for a given property in a dictionary.
(JSC::Structure::despecifyFunctionTransition):
Rename of 'changeFunctionTransition' (this was already internally refered to as a despecification).
- runtime/Structure.h:
Declare new method.
- 5:45 PM Changeset in webkit [44170] by
-
- 11 edits in trunk
WebCore:
2009-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
Don't use the WKCGContextIsSafeToClip function; it wasn't working correctly. Instead, just disable
the improved selection drawing on Tiger.
- WebCore.Tiger.exp:
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::strokeRect):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillSelectionGaps):
WebKit/mac:
2009-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
Remove WKCGContextIsSafeToClip.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKitLibraries:
2009-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
Remove WKCGContextIsSafeToClip.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceTiger.a:
- 5:33 PM Changeset in webkit [44169] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver "pieces of eight" Hunt.
When reseting RegexPattern class, should fully reset the class, not just bits of it.
In particular, we delete the cached character classes (for wordchars, etc), but do
not reset the set of pointers to the cached classes. In the case of a repeated parse
due to an illegal back-reference we will continue to use the deleted character class.
- yarr/RegexPattern.h: (JSC::Yarr::RegexPattern::reset):
- 5:29 PM Changeset in webkit [44168] by
-
- 3 edits in trunk/SunSpider
2009-05-26 Olivier DOLE <odole@pleyo.com>
Reviewed by Maciej.
Store sunspider test suite results in a specific directory for each
different type of benchmark (sunspider, V8 or ubench).
- sunspider:
- sunspider-compare-results:
- 5:20 PM Changeset in webkit [44167] by
-
- 22 edits in trunk/WebCore
2009-05-26 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part two
Mostly cosmetic changes, mainly to get image decoders for Cairo build to
comply with WebKit style guidelines:
- Fix header guard names
- Fix initializer list wrapping
- Fix class/function "{" wrapping
- Fix wrapping of long boolean expressions
- Fix whitespace around operators
- Eliminate whitespace on otherwise-blank lines
- No {} on single-line conditional arms
- Use 0 instead of NULL
- Don't #include "config.h" in headers
Also a few non-cosmetic changes:
- Remove unneeded #ifdef protecting the contents of these files. The platforms listed don't match who uses these files anymore (even without considering Skia), and platforms which don't use them at all (like CG) aren't harmed by the files, since they don't have equivalently-named classes. It's simpler to just ditch these.
- Convert a use of Vector<>& into SharedBuffer*, since that's how the data is really stored anyway.
- Use size() instead of m_size, for consistency with Skia code, and future-proofing (if a particular decoder wants to specialize this).
- Move an ASSERT that was slightly more aggressive than necessary.
- Change variable names/types for clarity/accuracy and to match Skia.
- Remove unnecessary macro magic to work around a problem which no longer exists in the third-party JPEG headers.
- Stop silencing a portability warning about setjmp (the vcproj/vsprops are the right place for this)
- In Skia code, don't explicitly check |m_failed| before calling isSizeAvailable(), which itself checks |m_failed|.
- platform/image-decoders/ImageDecoder.h: Fix header guards, "{" wrapping. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): Fix initializer list wrapping. (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: Remove unneeded #ifdef.
- platform/image-decoders/bmp/BMPImageDecoder.h: Fix header guards, "{" wrapping.
- platform/image-decoders/gif/GIFImageDecoder.cpp: Remove unneeded #ifdef, fix "{" wrapping. (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): Use an initializer instead of a block-level statement. (WebCore::GIFImageDecoderPrivate::decode): Expect a SharedBuffer. (WebCore::GIFImageDecoderPrivate::getColorMap): (WebCore::GIFImageDecoder::GIFImageDecoder): Fix initializer list wrapping. (WebCore::GIFImageDecoder::frameCount): Add comment. (WebCore::GIFImageDecoder::frameBufferAtIndex): Explicitly cast, fix whitespace around operators. (WebCore::GIFImageDecoder::decode): Pass a SharedBuffer. (WebCore::GIFImageDecoder::initFrameBuffer): Use size() instead of m_size, move ASSERT, fix boolean wrapping, fix indenting. (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): Use size() instead of m_size. (WebCore::GIFImageDecoder::haveDecodedRow): Use size() instead of m_size, eliminate unneeded whitespace, change variable name. (WebCore::GIFImageDecoder::frameComplete): Use size() instead of m_size, no {} on single-line conditional arms, fix boolean wrapping.
- platform/image-decoders/gif/GIFImageDecoder.h: Fix header guards, "{" wrapping.
- platform/image-decoders/gif/GIFImageReader.cpp: Remove unneeded #ifdef. (GIFImageReader::read):
- platform/image-decoders/gif/GIFImageReader.h: Fix header guards, change variable type.
- platform/image-decoders/ico/ICOImageDecoder.cpp: Remove unneeded #ifdef.
- platform/image-decoders/ico/ICOImageDecoder.h: Fix header guards, "{" wrapping.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove unneeded #ifdef, macro magic, silencing of warning. (WebCore::JPEGImageDecoder::outputScanlines): Use size() instead of m_size, change variable name.
- platform/image-decoders/jpeg/JPEGImageDecoder.h: Fix header guards, "{" wrapping.
- platform/image-decoders/png/PNGImageDecoder.cpp: Remove unneeded #ifdef, silencing of warning, change variable type. (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping. (WebCore::PNGImageReader::close): Add comment, zero another member for consistency. (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting. (WebCore::PNGImageDecoder::decodingFailed): Define in .cpp, not .h. (WebCore::PNGImageDecoder::rowAvailable):
- platform/image-decoders/png/PNGImageDecoder.h: Fix header guards, "{" wrapping.
- platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily. (WebCore::GIFImageDecoder::frameBufferAtIndex): Fix whitespace around operators.
- platform/image-decoders/skia/GIFImageReader.h: "unsigned" is sufficient to convey "unsigned int".
- platform/image-decoders/skia/ImageDecoder.h: Remove unnecessary #includes. (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
- platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::JPEGImageReader): Use 0 instead of NULL. (WebCore::JPEGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
- platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping. (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting. (WebCore::PNGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily. (WebCore::rowAvailable):
- platform/image-decoders/skia/XBMImageDecoder.h: Don't #include config.h.
- platform/image-decoders/xbm/XBMImageDecoder.cpp: Remove unneeded #ifdef.
- platform/image-decoders/xbm/XBMImageDecoder.h: Fix header guards, "{" wrapping.
- 5:13 PM Changeset in webkit [44166] by
-
- 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION
Versioning.
- 4:57 PM Changeset in webkit [44165] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed a regression caused by my recent fix for NaN.
- jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): Actually do the comparison in reverse order, like the ChangeLog said we would, bokay?
- 4:57 PM Changeset in webkit [44164] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
- fix <rdar://problem/6922371> REGRESSION (r43973): Can't type first character with an umlaut, circumflex, or accent in Mail or in a wiki
- WebView/WebHTMLView.mm: (isTextInput): Moved here. (isInPasswordField): Moved here. (-[WebHTMLView becomeFirstResponder]): Update the exposeInputContext flag and let NSApplication update the input manager with the new input context if necessary. (-[WebHTMLView _updateSelectionForInputManager]): Changed to use the NSApp global instead of +[NSApplication sharedApplication].
- 4:06 PM Changeset in webkit [44163] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-26 Brent Fulgham <bfulgham@webkit.org>
Build fix to correct r44161.
- wtf/FastAllocBase.h:
- 3:58 PM Changeset in webkit [44162] by
-
- 3 edits in trunk/WebCore
2009-05-26 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25944
Remove the uses of V8 Locker in worker execution code. No additional test is needed.
The normal WebKit layout tests should cover it. However, layout tests that start
multiple workers will fail to pass due to test shell limitation in Chromium. To cover
this, UI tests will be added (http://code.google.com/p/chromium/issues/detail?id=12554).
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initV8IfNeeded): (WebCore::WorkerContextExecutionProxy::evaluate): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper): (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
- 3:25 PM Changeset in webkit [44161] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-26 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherite HashTable from FastAllocBase, because it has been instantiated by
'new' in JavaScriptCore/runtime/JSGlobalData.cpp.
- wtf/HashTable.h:
- wtf/FastAllocBase.h: Remove 'wtf' path from TypeTraits.h to allow use outside of wtf.
- 2:41 PM Changeset in webkit [44160] by
-
- 4 edits in trunk/WebCore
2009-05-26 Dmitry Titov <dimich@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25974
Enable timers in Chromuim workers.
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Added function which can execute a callback using WorkerContext.
- bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction): added url parameter to capture the worker's location.
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval): replaced NotImplemented with code to create ScheduledAction and DOMTimer. Also, removed declarations for clearTimeout/clearInterval callbacks since they are now directly generated from IDL.
- 2:19 PM Changeset in webkit [44159] by
-
- 1 edit2 deletes in trunk/LayoutTests
2009-05-26 Adam Barth <abarth@webkit.org>
Unreviewed change to disable flaky test as requested by Sam Weinig.
- http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Removed.
- http/tests/security/postMessage/origin-follows-lexical-scope.html: Removed.
- 1:43 PM Changeset in webkit [44158] by
-
- 2 edits in trunk/WebKit/mac
Fix the Tiger build.
- Misc/WebNSObjectExtras.mm:
(-[NSInvocation _webkit_invokeAndHandleException:]): Rename the local variable so that
it doesn't conflict with a member variable on Tiger.
- 1:28 PM Changeset in webkit [44157] by
-
- 3 edits in trunk/WebCore
2009-05-26 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=23649
Update V8 bindings to match SQLTransactionErrorCallback change.
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): Changed to return void.
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Ditto.
- 1:05 PM Changeset in webkit [44156] by
-
- 4 edits2 adds2 deletes in trunk/WebCore
2009-05-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move FilterEffect to platform/graphics/filters. First step to get an
SVG independent filter system.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/FilterEffect.cpp: Added. (WebCore::FilterEffect::FilterEffect): (WebCore::FilterEffect::~FilterEffect): (WebCore::FilterEffect::externalRepresentation):
- platform/graphics/filters/FilterEffect.h: Added. (WebCore::FilterEffect::xBoundingBoxMode): (WebCore::FilterEffect::setXBoundingBoxMode): (WebCore::FilterEffect::yBoundingBoxMode): (WebCore::FilterEffect::setYBoundingBoxMode): (WebCore::FilterEffect::widthBoundingBoxMode): (WebCore::FilterEffect::setWidthBoundingBoxMode): (WebCore::FilterEffect::heightBoundingBoxMode): (WebCore::FilterEffect::setHeightBoundingBoxMode): (WebCore::FilterEffect::subRegion): (WebCore::FilterEffect::setSubRegion): (WebCore::FilterEffect::resultImage): (WebCore::FilterEffect::setEffectBuffer):
- svg/FilterEffect.cpp: Removed.
- svg/FilterEffect.h: Removed.
- 12:37 PM Changeset in webkit [44155] by
-
- 7 edits2 adds in trunk
WebCore:
2009-05-26 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=23649
Update SQLTransactionErrorCallback to not return a value per changes in
HTML5 spec.
Test: storage/transaction-error-callback.html
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.h:
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
- storage/SQLTransaction.h:
- storage/SQLTransactionErrorCallback.h:
LayouTests:
2009-05-26 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=23649
Add layout test for various cases of SQLTransactionErrorCallback
invocation.
- storage/transaction-error-callback-expected.txt: Added.
- storage/transaction-error-callback.html: Added.
- 11:29 AM Changeset in webkit [44154] by
-
- 2 edits in trunk/WebKit/mac
2009-05-26 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
<rdar://problem/6921835> REGRESSION (r44115): Crash in Leopard Mail viewing message
Fix case where we autorelease an object on the main thread that we are returning
to another thread when using our _webkit_invokeOnMainThread method.
- Misc/WebNSObjectExtras.mm: (returnTypeIsObject): Added. (-[WebMainThreadInvoker forwardInvocation:]): Autorelease the object on the calling thread, balancing a retain done on the main thread. (-[NSInvocation _webkit_invokeAndHandleException:]): Retain the object on the main thread.
- 11:26 AM Changeset in webkit [44153] by
-
- 2 edits in trunk/WebKit/mac
2009-05-26 David Hyatt <hyatt@apple.com>
Back out the workaround for Mail crashing. Darin is working on the real fix.
- Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker forwardInvocation:]):
- 11:16 AM Changeset in webkit [44152] by
-
- 7 edits8 adds in trunk
WebCore:
2009-05-26 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Detect the case where we can fit without scrollbars when the view shrinks, so that we don't mistakenly
continue to show scrollbars.
Added two tests in fast/dynamic.
- platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):
WebKit/mac:
2009-05-26 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Stop using notifications for boundsChanged, since the notifications are being sent too late.
Since subviews get resized before parents do, the notification comes in telling the WebHTMLView
that its size has changed *before* we've done setNeedsLayout in the WebView size change callback.
Become more like the Windows platform and just do the bounds changed immediately as our size is
being altered by subclassing setFrameSize in WebView.
Also patch WebDynamicScrollbarsView to detect the case where neither axis is really spilling out
past the viewport, so that in shrinking situations we figure out that we don't need scrollbars
any more.
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
- WebView/WebView.mm: (-[WebView _boundsChangedToNewSize:]): (-[WebView setFrameSize:]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]):
LayoutTests:
2009-05-26 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Fix for bug 25969, scrollbars remain after document shrinks. Add a couple of layout tests
written by Dan that show various problems with scrollbars following resizes.
- fast/dynamic/window-resize-scrollbars-test.html: Added.
- fast/dynamic/window-scrollbars-test.html: Added.
- platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.checksum: Added.
- platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
- platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
- platform/mac/fast/dynamic/window-scrollbars-test-expected.checksum: Added.
- platform/mac/fast/dynamic/window-scrollbars-test-expected.png: Added.
- platform/mac/fast/dynamic/window-scrollbars-test-expected.txt: Added.
- 10:49 AM Changeset in webkit [44151] by
-
- 8 edits6 moves in trunk/WebCore
Bug 25801: change AccessibilityAria -> AccessibilityARIA
https://bugs.webkit.org/show_bug.cgi?id=25801
- 9:00 AM Changeset in webkit [44150] by
-
- 2 edits in trunk/WebCore
2009-05-26 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Fix the Skia path to normalize the given source rect when
drawing patterns, so it accepts negative width/height (as CG does).
Fixes Chromium bug http://www.crbug.com/6167.
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- 5:23 AM Changeset in webkit [44149] by
-
- 6 edits in trunk/WebCore
2009-05-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Serialize calls to WebInspector. This is the first step where method
calls are being serialized to arrays (not yet JSON stringified ones) and
are being dispatched on the client. This change also allows client to override
InspectorFrontend, so that the serialized calls can be made on a given object
instead of in-process WebInspector global. This will be the main control flow
when InspectorController is decoupled from the in-process frontend.
- inspector/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::overrideFrontendObject): (WebCore::InspectorController::show): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole): (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared): (WebCore::InspectorFrontend::showPanel): (WebCore::InspectorFrontend::populateInterface): (WebCore::InspectorFrontend::reset): (WebCore::InspectorFrontend::debuggerWasEnabled): (WebCore::InspectorFrontend::debuggerWasDisabled): (WebCore::InspectorFrontend::profilerWasEnabled): (WebCore::InspectorFrontend::profilerWasDisabled): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfile): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::resumedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::addDOMStorage): (WebCore::InspectorFrontend::newFunctionCall): (WebCore::InspectorFrontend::callSimpleFunction):
- inspector/InspectorFrontend.h:
- inspector/front-end/inspector.js: (WebInspector.dispatch):
- 12:30 AM Changeset in webkit [44148] by
-
- 3 edits3 adds in branches/nitro-extreme
2009-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig and Oliver Hunt.
Fixed two edge cases in %:
- Don't do -2147483648 % x as a fast case, since you might do -2147483648 % -1, which will signal a hardware exception due to overflow.
- In the case of a zero remainder, be sure to store negative zero if the dividend was zero.
SunSpider reports no change.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
LayoutTests:
2009-05-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig and Oliver Hunt.
Added test for arithmetic edge cases.
- fast/js/arithmetic-expected.txt: Added.
- fast/js/arithmetic.html: Added.
- fast/js/resources/arithmetic.js: Added.
May 25, 2009:
- 11:20 PM Changeset in webkit [44147] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().
- dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
- dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): Adjust empty namespace before QNameComponentsTranslator black magic, not after.
- 11:03 PM Changeset in webkit [44146] by
-
- 3 edits3 adds in branches/nitro-extreme
2009-05-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Fixed a regression when comparing to NaN.
- jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): For op_jnless and op_jnless_eq, do the comparison in reverse order, and jump if the result is below or below-or-equal. This ensures that we do jump in the case of NaN.
LayoutTests:
2009-05-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Added test for NaN comparisons.
- fast/js/nan-expected.txt: Added.
- fast/js/nan.html: Added.
- fast/js/resources/nan.js: Added. ():
- 9:21 PM Changeset in webkit [44145] by
-
- 8 edits5 adds in trunk
2009-05-25 David Levin <levin@chromium.org>
Reviewed by Maciej Stachowiak and Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=25126
Allow the buffer underlying UString to be shared.
In order to not grow the underlying size of any structure,
there is a union in the Rep string which holds
+ m_sharedBuffer -- a pointer to the shared ref counted buffer
if the class is BaseString and the buffer is being shared OR
+ m_baseString -- the BaseString if the class is only UString::Rep
but not a UString::BaseString
Ideally, m_sharedBuffer would be a RefPtr, but it cannot be because
it is in a union.
No change in sunspider perf.
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/UString.cpp: (JSC::UString::Rep::share): (JSC::UString::Rep::destroy): (JSC::UString::BaseString::sharedBuffer): (JSC::UString::BaseString::setSharedBuffer): (JSC::UString::BaseString::slowIsBufferReadOnly): (JSC::expandCapacity): (JSC::UString::Rep::reserveCapacity): (JSC::UString::expandPreCapacity): (JSC::concatenate): (JSC::UString::append):
- runtime/UString.h: (JSC::UString::Rep::Rep): (JSC::UString::Rep::): (JSC::UString::BaseString::isShared): (JSC::UString::BaseString::isBufferReadOnly): (JSC::UString::Rep::baseString):
- wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::isShared):
- wtf/OwnFastMallocPtr.h: Added. (WTF::OwnFastMallocPtr::OwnFastMallocPtr): (WTF::OwnFastMallocPtr::~OwnFastMallocPtr): (WTF::OwnFastMallocPtr::get): (WTF::OwnFastMallocPtr::release):
JavaScriptGlue:
2009-05-25 David Levin <levin@chromium.org>
Reviewed by Maciej Stachowiak and Oliver Hunt.
Added forwarding headers.
- ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
- ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
WebCore:
2009-05-25 David Levin <levin@chromium.org>
Reviewed by Maciej Stachowiak and Oliver Hunt.
Added forwarding headers.
- ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
- ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
- 9:00 PM Changeset in webkit [44144] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
SunSpider says no change.
Fixed regressions in fast/js/var-declarations-shadowing.html and
fast/js/equality.html, caused by recent == and != optimizations.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): Don't treat "compare to string" as always numeric or string comparison. If the second operand is an object, you need to ToPrimitive it, and start all over again. Also, I wrote out each of the possible cases explicitly, to cut down on redundant branching.
- 5:20 PM Changeset in webkit [44143] by
-
- 2 edits in trunk/JavaScriptCore
Re-add interpreter logic to jit-enabled builds as GCC mysteriously regresses without it
Reviewed by Maciej Stachowiak
- 5:08 PM Changeset in webkit [44142] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-25 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix bug in fast/js/constant-folding.html where we were not negating
-0 properly.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate):
- 4:52 PM Changeset in webkit [44141] by
-
- 15 edits in branches/WWDC-2009-branch
Merge r44136.
- 4:52 PM Changeset in webkit [44140] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r44132.
- 4:52 PM Changeset in webkit [44139] by
-
- 3 edits2 adds in branches/WWDC-2009-branch
Merge r44075.
- 4:52 PM Changeset in webkit [44138] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r44069.
- 4:51 PM Changeset in webkit [44137] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r44066.
- 3:48 PM Changeset in webkit [44136] by
-
- 15 edits in trunk
WebCore:
2009-05-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- WebCore side of <rdar://problem/6914001>.
Add a new m_allowPopupsFromPlugin flag.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
- bindings/js/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):
WebKit/mac:
2009-05-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- WebKit side of <rdar://problem/6914001>.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::didCreateWindow): Iterate over all plug-in hosts. If one is in full-screen mode, make sure to activate the WebKit app instead.
- Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isMenuBarVisible): Add getter.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): Add allowPopups flag.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest): (WebKit::NetscapePluginInstanceProxy::PluginRequest::allowPopups): (WebKit::NetscapePluginInstanceProxy::loadURL): (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): (WebKit::NetscapePluginInstanceProxy::loadRequest): (WebKit::NetscapePluginInstanceProxy::evaluate): Use "allowPopups" instead of "userGesture".
- Plugins/Hosted/WebKitPluginClient.defs: Add allowPopups argument to Evaluate.
- Plugins/Hosted/WebKitPluginHostTypes.h: Use "allowPopups" instead of "userGesture".
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Call didCreateWindow here.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): Ditto.
- 2:33 PM Changeset in webkit [44135] by
-
- 10 edits8 adds in trunk
WebCore:
2009-05-25 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
window.location. The correct use appears to be as follows:
1) Use dynamicGlobalObject to find the user gesture.
2) Use dynamicGlobalObject to complete URLs.
3) Use lexicalGlobalObject to find the referrer.
4) Use lexicalGlobalObject for the frame navigation checks.
5) Use lexicalGlobalObject for the XSS checks.
Tests: http/tests/security/frameNavigation/context-for-location-assign.html
http/tests/security/frameNavigation/context-for-location-href.html
http/tests/security/frameNavigation/context-for-location.html
- bindings/js/JSDOMBinding.cpp: (WebCore::shouldAllowNavigation): (WebCore::toLexicalFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
- bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): (WebCore::JSLocationPrototype::customPut):
- bindings/v8/V8Utilities.cpp: (WebCore::processingUserGesture): (WebCore::shouldAllowNavigation): (WebCore::completeURL): (WebCore::navigateIfAllowed):
- bindings/v8/V8Utilities.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetLocation):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-25 Adam Barth <abarth@webkit.og>
Reviewed by Sam Weinig.
Test our use of dynamicGlobalObject and lexicalGlobalObject for
window.location.
- http/tests/security/frameNavigation/context-for-location-assign-expected.txt: Added.
- http/tests/security/frameNavigation/context-for-location-assign.html: Added.
- http/tests/security/frameNavigation/context-for-location-expected.txt: Added.
- http/tests/security/frameNavigation/context-for-location-href-expected.txt: Added.
- http/tests/security/frameNavigation/context-for-location-href.html: Added.
- http/tests/security/frameNavigation/context-for-location.html: Added.
- http/tests/security/frameNavigation/resources/middle-frame-for-location.html: Added.
- http/tests/security/frameNavigation/resources/target-for-location.html: Added.
- 2:11 PM Changeset in webkit [44134] by
-
- 2 edits in trunk/LayoutTests/http/tests/security/postMessage
Unreviewed attempt to fix flaky origin-follows-lexical-scope test. (Test only fails on buildbot.)
- 12:33 PM Changeset in webkit [44133] by
-
- 4 edits1 add in trunk/LayoutTests
2009-05-25 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Try to make test less flaky.
- http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt:
- http/tests/security/postMessage/origin-follows-lexical-scope.html:
- http/tests/security/postMessage/resources/middle-frame-for-lexical.html:
- http/tests/security/postMessage/resources/post-message-listener-with-ready.html: Added.
- 11:48 AM Changeset in webkit [44132] by
-
- 2 edits in trunk/WebKit/mac
2009-05-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- Fix <rdar://problem/6915849>.
Release the placeholder window after -[NSApplication runModalForWindow] returns.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::beginModal): (WebKit::NetscapePluginHostProxy::endModal):
- 8:41 AM Changeset in webkit [44131] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Maciej Stachowiak.
The functions written in assembly need to have a leading
underscore on Windows too.
- jit/JITStubs.cpp:
- 8:41 AM Changeset in webkit [44130] by
-
- 3 edits in trunk/WebCore
2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Maciej Stachowiak.
With Windows compilers older then MSVC 2005, the functions
gmtime_s and localtime_s don't exist. The gmtime and localtime are
on Windows always thread safe. So use them in the cases where
gmtime_s and localtime_s are not present.
- loader/FTPDirectoryDocument.cpp:
- loader/FTPDirectoryParser.cpp:
- 5:55 AM Changeset in webkit [44129] by
-
- 2 edits in trunk/WebCore
2009-05-25 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
Follow up on r44120. PluginPackageMac.cpp is used
by Qt on Mac and contained a copy of the m_browserFunc
assignments and ::equal, ::hash and ::compareFileVersion.
Change it to use the ones from PluginPackage.cpp as well.
- 5:39 AM Changeset in webkit [44128] by
-
- 3 edits in trunk/WebCore
2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Support conditionals in the tag factories, by placing
feature #ifdefs around the individual factory functions
and the registration.
Made the Audio and Video elements conditional in the tag factories
- 4:45 AM Changeset in webkit [44127] by
-
- 2 edits in trunk/WebCore
2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Gtk build when video is disabled.
- 4:35 AM Changeset in webkit [44126] by
-
- 2 edits in trunk/WebCore
2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build when video is disabled.
- WebCore.pro: Always generate the IDL files for the media elements. They contain proper ENABLE(VIDEO) #ifdefs.
- 1:36 AM Changeset in webkit [44125] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog typo.
- 1:29 AM Changeset in webkit [44124] by
-
- 4 edits3 adds in trunk
WebCore:
2009-05-25 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
The origin for postMessage should follow lexical scope, not dynamic
scope. Yes, this is a super-obscure conner case.
Test: http/tests/security/postMessage/origin-follows-lexical-scope.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-25 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Test that the origin for postMessage follows the lexical scope.
- http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Added.
- http/tests/security/postMessage/origin-follows-lexical-scope.html: Added.
- http/tests/security/postMessage/resources/middle-frame-for-lexical.html: Added.
May 24, 2009:
- 11:27 PM Changeset in webkit [44123] by
-
- 2 edits in trunk/WebCore
2009-05-24 Darin Fisher <darin@chromium.org>
Reviewed by Mark Rowe.
Fix build bustage related to PassOwnPtr changes.
- platform/graphics/chromium/TransparencyWin.cpp:
- 10:20 PM Changeset in webkit [44122] by
-
- 2 edits in trunk/WebKit/mac
- revert an accidental change from r43964.
- WebView/WebView.mm: (+[WebView _setShouldUseFontSmoothing:]):
- 8:29 PM Changeset in webkit [44121] by
-
- 2 edits in trunk/WebCore
2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej Stachowiak.
Minor cleanup in PluginPackage::hash. Let the compiler
figure out the size of the array. Do not have it in the
definition and specially not the in the call to
StringImpl::hash.
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
- 8:29 PM Changeset in webkit [44120] by
-
- 6 edits in trunk/WebCore
2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej Stachowiak.
Move ::hash, ::equal and ::compareFileVersion from
the duplicated copies in PluginPackageQt.cpp and
PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
this for the PluginPackageWin version. Use the new style
ENABLE() for this feature/policy and enable it in the Gtk+
and Qt buildsystem.
- GNUmakefile.am:
- WebCore.pro:
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash): (WebCore::PluginPackage::equal): (WebCore::PluginPackage::compareFileVersion):
- plugins/gtk/PluginPackageGtk.cpp:
- plugins/qt/PluginPackageQt.cpp:
- 8:28 PM Changeset in webkit [44119] by
-
- 6 edits in trunk/WebCore
2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej Stachowiak.
So far the initialization of the browserfuncs struct
is done in PluginPackageQt, PluginPackageGtk and
PluginPackageWin there is no need for this duplication.
The PluginPackageWin version got copied to PluginPackage
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
- plugins/PluginPackage.h:
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::load):
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
- 3:43 PM Changeset in webkit [44118] by
-
- 5 edits5 adds in trunk/WebCore
2009-05-24 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
Added standard input for filter system.
No testcases were added. Filter system is still off.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/SourceAlpha.cpp: Added. (WebCore::SourceAlpha::create): (WebCore::SourceAlpha::effectName): (WebCore::SourceAlpha::apply): (WebCore::SourceAlpha::dump):
- platform/graphics/filters/SourceAlpha.h: Added. (WebCore::SourceAlpha::SourceAlpha):
- platform/graphics/filters/SourceGraphic.cpp: Added. (WebCore::SourceGraphic::create): (WebCore::SourceGraphic::effectName): (WebCore::SourceGraphic::apply): (WebCore::SourceGraphic::dump):
- platform/graphics/filters/SourceGraphic.h: Added. (WebCore::SourceGraphic::SourceGraphic):
- svg/FilterBuilder.cpp: Added. (WebCore::FilterBuilder::FilterBuilder): (WebCore::FilterBuilder::add): (WebCore::FilterBuilder::getEffectById): (WebCore::FilterBuilder::clearEffects):
- svg/FilterBuilder.h:
- 12:35 PM QtWebKitContrib edited by
- (diff)
- 11:13 AM Changeset in webkit [44117] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-24 Steve Falkenburg <sfalken@apple.com>
Build fix for experimental PGO Windows target.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 11:10 AM Changeset in webkit [44116] by
-
- 3 edits in trunk/WebCore
2009-05-24 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Maciej Stachowiak.
Add support conditionals in the JSC bindings generator code for attributes,
by placing feature #ifdefs around the setters/getters.
Made the audio and video element specific DOM attributes conditional
in the generated code, by moving the #ifdefs from the IDL files into
the generated code. This allows for re-using the same generated code
with or without ENABLE(VIDEO).
- 9:34 AM Changeset in webkit [44115] by
-
- 2 edits in trunk/WebKit/mac
2009-05-24 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein and Tim Hatcher.
<rdar://problem/6913045> New console message spewed by automator CLI after installing JetstreamLeo40B21a
- Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker initWithTarget:]): Tweaked argument name. (-[WebMainThreadInvoker forwardInvocation:]): Removed call to retainArguments. This was unneeded and in the case of a newly created but not yet fully initialized NSView object it caused the abovementioned bug. (-[WebMainThreadInvoker handleException:]): Tweaked argument name. Added assertion. (-[NSInvocation _webkit_invokeAndHandleException:]): Tweaked name of local variable that holds the exception.
- 8:34 AM Changeset in webkit [44114] by
-
- 2 edits in trunk/WebKit
2009-05-24 Darin Adler <Darin Adler>
- StringsNotToBeLocalized.txt: Updated for recent changes. Got rid of most full-file exceptions.
- 12:48 AM Changeset in webkit [44113] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=25987
[GTK] Clarify WebKitWebView::download-requested documentation
Explain a bit why this signal is not emitted by default and offer
a common solution/setup for that issue.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
May 23, 2009:
- 11:38 PM Changeset in webkit [44112] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix for Qt. Change signature to have PassOwnPtr.
- 10:14 PM Changeset in webkit [44111] by
-
- 5 edits7 adds in trunk/WebKitTools
Land the updated version of WebKitLauncher that the nightly builds have been using.
Reviewed by Oliver Hunt.
Changes include:
1) Support for self-updating via Sparkle.
2) Now respects the "Open using Rosetta" preference.
3) Passes environment variables through to the spawned Safari process.
4) Logs a list of extensions that are detected to the system console.
5) Disables extensions that are known to cause crashes too early in the
launch process to be detected by the extension-detection code.
- WebKitLauncher/Configurations/Base.xcconfig: Added.
- WebKitLauncher/Configurations/WebKitLauncher.xcconfig: Added.
- WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig: Added.
- WebKitLauncher/Info.plist:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitNightlyEnabler.h: Added.
- WebKitLauncher/WebKitNightlyEnabler.m:
(myBundleDidLoad):
(myApplicationWillFinishLaunching):
(poseAsWebKitApp):
(webKitLauncherBundle):
(enableWebKitNightlyBehaviour):
- WebKitLauncher/WebKitNightlyEnablerSparkle.h: Added.
- WebKitLauncher/WebKitNightlyEnablerSparkle.m: Added.
(initializeSparkle):
(updatePermissionPromptDescription):
(skipSignatureVerificationInDownloadDidFinish):
(updateAlertPanel):
(updateAlertInitForAlertPanel):
(-[NSAlert webKitHandleButtonPress:]):
(setMethodImplementation):
- WebKitLauncher/main.m:
(displayErrorAndQuit):
(getLastVersionShown):
(saveLastVersionShown):
(getPathForStartPage):
(getCurrentVersion):
(getShowStartPageVersion):
(startPageDisabled):
(addStartPageToArgumentsIfNeeded):
(preferredArchitecture):
(myExecve):
(locateSafariBundle):
(currentMacOSXVersion):
(checkFrameworkPath):
(main):
- 9:21 PM Changeset in webkit [44110] by
-
- 1 edit in trunk/ChangeLog
Fix typo "am" -> "an" in the Changelog of my previous commit
- 9:06 PM Changeset in webkit [44109] by
-
- 2 edits in trunk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Unreviewed build fix. Add gstreamer-video-0.10 libs to
GSTREAMER_LIBS to resolve am undefined reference to gst_video_get_size
- symbol used in MediaPlayerPrivateGstreamer.
- configure.ac:
- 4:28 PM Changeset in webkit [44108] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
- clean up ColorMac a little
- platform/graphics/mac/ColorMac.h: Whitespace change.
- platform/graphics/mac/ColorMac.mm: Removed redundant #import statements and sorted the remaining ones. (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls with a single call and removed redundant casts to int. (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats. In one case, this avoids an intermediate conversion to float before conversion to double on 64-bit. (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls with a single call. (WebCore::focusRingColor): (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
- 3:55 PM Changeset in webkit [44107] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Refactored new slow case codegen for == and !=.
SunSpider reports no change, maybe a tiny speedup.
- jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emitSlow_op_neq): Made a vptr comparison a *Ptr operation, instead of *32, to make it portable to 64bit. Reorganized the string and generic cases to make their control flow a little clearer.
- 3:39 PM Changeset in webkit [44106] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Gustavo Noronha.
Break the switch once private browsing is selected.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property): (webkit_web_settings_get_property):
- 3:35 PM Changeset in webkit [44105] by
-
- 7 edits in trunk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629
Enable storage/ tests for Gtk.
- platform/gtk/Skipped:
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629
Add settings to enable or disable database and localStorage
support and enable them by default. This allows databases to be
shown in the WebInspector as well as allow us to run the storage
layout tests.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629
Enable database and localStorage for running the storage/ tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- 3:22 PM Changeset in webkit [44104] by
-
- 2 edits in trunk/WebCore
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
https://bugs.webkit.org/show_bug.cgi?id=25900
Use ATK_ROLE_TEXT for ListMarkerRole.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
- 3:20 PM Changeset in webkit [44103] by
-
- 2 edits in trunk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Refactor library LIBS. Move third-party libs in libwebkit instead
of libWebCore.
- GNUmakefile.am:
- 3:08 PM Changeset in webkit [44102] by
-
- 2 edits in trunk/WebCore
Reformat WebCore::requiresContextForWordBoundary()
- platform/text/TextBoundaries.h: (WebCore::requiresContextForWordBoundary):
- 2:29 PM Changeset in webkit [44101] by
-
- 2 edits in trunk/WebCore
Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.
- 2:25 PM Changeset in webkit [44100] by
-
- 23 edits2 adds in trunk/WebCore
Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
HTMLSelectElement/WMLSelectElement.
- 10:32 AM Changeset in webkit [44099] by
-
- 3 edits in trunk/WebCore
Fix Gtk/Qt builds for PassOwnPtr
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer> instead of an std::auto_ptr<ImageBuffer> to store the result of ImageBuffer::create() now that it returns a PassOwnPtr<ImageBuffer>.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): Ditto. (WebCore::Path::strokeBoundingRect): Ditto.
- 10:16 AM Changeset in webkit [44098] by
-
- 3 edits in trunk/WebKit/win
Windows build fix for PassOwnPtr
- WebHistory.cpp: (WebHistory::visitedURL): Changed std::auto_ptr<Vector<String> >() to 0.
- WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): Changed type of redirectURLsVector from std::auto_ptr<Vector<String> > to OwnPtr<Vector<String> >.
- 10:06 AM Changeset in webkit [44097] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
2009-05-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Optimized == and != for our new value representation -- especially for strings.
14% speedup on date-format-tofte.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
- jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_eq_strings): (JSC::JITStubs::cti_op_call_eval):
- jit/JITStubs.h: (JSC::):
- runtime/JSValue.h:
- 9:39 AM Changeset in webkit [44096] by
-
- 42 edits in trunk
Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
Reviewed by Oliver Hunt.
WebCore:
No test cases added since there is no change in behavior.
- WebCore.base.exp: Updated export for HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
- dom/Node.cpp: (WebCore::Node::childNodes): Use NodeListsNodeData::create() instead of new NodeListsNodeData. (WebCore::Node::registerDynamicNodeList): Ditto. (WebCore::Node::getElementsByTagNameNS): Ditto. (WebCore::Node::getElementsByName): Ditto. (WebCore::Node::getElementsByClassName): Ditto.
- dom/NodeRareData.h: (WebCore::NodeListsNodeData::create): Added. Implements create() pattern popularized by RefCounted classes. (WebCore::NodeListsNodeData::NodeListsNodeData): Declared private constructor. (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<> instead of an auto_ptr<>.
- history/HistoryItem.cpp: (WebCore::HistoryItem::setRedirectURLs): Ditto.
- history/HistoryItem.h: (WebCore::HistoryItem::setRedirectURLs): Ditto.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use assignment operator now that ImageBuffer::create() returns a PassOwnPtr<>.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
- page/ChromeClient.h: (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of auto_ptr<>. Use OwnPtr<> instead of auto_ptr<> for stack variable.
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- platform/text/TextCodec.h: (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of auto_ptr<>.
- platform/text/TextCodecICU.cpp: (WebCore::newTextCodecICU): Ditto.
- platform/text/TextCodecLatin1.cpp: (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
- platform/text/TextCodecUTF16.cpp: (WebCore::newStreamingTextDecoderUTF16LE): Ditto. (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
- platform/text/TextCodecUserDefined.cpp: (WebCore::newStreamingTextDecoderUserDefined): Ditto.
- platform/text/TextEncodingRegistry.cpp: (WebCore::newTextCodec): Ditto.
- platform/text/TextEncodingRegistry.h: (WebCore::newTextCodec): Ditto.
- platform/text/mac/TextCodecMac.cpp: (WebCore::newTextCodecMac): Ditto.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): Ditto. Return OwnPtr<> instead of auto_ptr<>.
- svg/SVGMaskElement.h: (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<> instead of auto_ptr<>.
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use assignment operator now that ImageBuffer::create() returns a PassOwnPtr<>.
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setTile): Updated to take a PassOwnPtr<> instead of an auto_ptr<>. (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/graphics/SVGPaintServerPattern.h: (WebCore::SVGPaintServerPattern::setTile): Updated to take a PassOwnPtr<> instead of an auto_ptr<>.
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask): Updated to use assignment operator now that SVGMaskElement::drawMaskerContent() returns a PassOwnPtr<>. Use OwnPtr<> instead of auto_ptr<> for stack variable.
WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/mac:
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): Return 0 instead of an empty auto_ptr<>.
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/qt:
- WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/win:
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/wx:
- WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
- 9:39 AM Changeset in webkit [44095] by
-
- 10 edits10 adds in trunk
Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
Reviewed by Oliver Hunt.
- GNUmakefile.am: Added OwnPtrCommon.h and PassOwnPtr.h.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- wtf/OwnPtr.h: (WTF::OwnPtr::OwnPtr): Added constructors that take a PassOwnPtr. Also added a copy constructor declaration that's required when assigning a PassOwnPtr to a stack-based OwnPtr. (WTF::operator=): Added assignment operator methods that take a PassOwnPtr. (WTF::swap): Reformatted. (WTF::operator==): Whitespace changes. (WTF::operator!=): Ditto.
- wtf/OwnPtrCommon.h: Added. (WTF::deleteOwnedPtr):
- wtf/PassOwnPtr.h: Added. (WTF::PassOwnPtr::PassOwnPtr): (WTF::PassOwnPtr::~PassOwnPtr): (WTF::PassOwnPtr::get): (WTF::PassOwnPtr::clear): (WTF::PassOwnPtr::release): (WTF::PassOwnPtr::operator*): (WTF::PassOwnPtr::operator->): (WTF::PassOwnPtr::operator!): (WTF::PassOwnPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):
JavaScriptGlue:
- ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- ForwardingHeaders/wtf/PassOwnPtr.h: Added.
WebCore:
- ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- ForwardingHeaders/wtf/PassOwnPtr.h: Added.
- WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and PassOwnPtr.h.
WebKit/mac:
- ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- ForwardingHeaders/wtf/PassOwnPtr.h: Added.
WebKitTools:
- DumpRenderTree/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- DumpRenderTree/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
- 9:15 AM Changeset in webkit [44094] by
-
- 14 edits in trunk/WebCore
Fix Mac builds by backing out r44093
- bindings/js/JSCustomPositionCallback.cpp:
- bindings/js/JSCustomPositionCallback.h:
- bindings/js/JSCustomPositionErrorCallback.cpp:
- bindings/js/JSCustomPositionErrorCallback.h:
- bindings/js/JSGeolocationCustom.cpp:
- page/Geolocation.cpp:
- page/Geolocation.idl:
- page/Geoposition.cpp:
- page/Geoposition.h:
- page/Geoposition.idl:
- page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::geolocation):
- page/PositionError.idl:
- platform/GeolocationService.cpp: (WebCore::GeolocationService::create):
- 8:28 AM Changeset in webkit [44093] by
-
- 14 edits in trunk/WebCore
2009-05-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Add GEOLOCATION guards around Geolocation API code
https://bugs.webkit.org/show_bug.cgi?id=25756
- bindings/js/JSCustomPositionCallback.cpp:
- bindings/js/JSCustomPositionCallback.h:
- bindings/js/JSCustomPositionErrorCallback.cpp:
- bindings/js/JSCustomPositionErrorCallback.h:
- bindings/js/JSGeolocationCustom.cpp:
- page/Geolocation.cpp:
- page/Geolocation.idl:
- page/Geoposition.cpp:
- page/Geoposition.h:
- page/Geoposition.idl:
- page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::geolocation):
- page/PositionError.idl:
- platform/GeolocationService.cpp:
- 8:21 AM Changeset in webkit [44092] by
-
- 2 edits in trunk/WebKitTools
resolve-ChangeLogs: Add missing newline to status message
- Scripts/resolve-ChangeLogs: Added newline to status message
that is printed when the -ccontinue switch is used but there are unmerged files remaining in the git working directory.
- 8:07 AM Changeset in webkit [44091] by
-
- 4 edits in trunk/WebCore
Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher
In r42377, startUpdateRenderingDispatcher() was renamed to
startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
dropped. This change restores it.
- WebCore.order:
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher): (WebCore::AnimationControllerPrivate::addEventToDispatch): (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch): (WebCore::AnimationControllerPrivate::pauseAnimationAtTime): (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
- page/animation/AnimationControllerPrivate.h:
- 7:03 AM Changeset in webkit [44090] by
-
- 3 edits in trunk/WebKit/qt
2009-05-23 Jakob Truelsen <antialize@gmail.com>
Reviewed by Holger Freyther.
Expose the default text encoding property to Qt.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::setDefaultTextEncoding): (QWebSettings::defaultTextEncoding):
- Api/qwebsettings.h:
- 6:55 AM Changeset in webkit [44089] by
-
- 2 edits in trunk/WebCore
Unreviewed build-fix for Qt. Disable SVG Filters.
SVG Filters can not be built right now and Qt should not have
them enabled anyway as they did not carry out any filtering.
- 4:08 AM Changeset in webkit [44088] by
-
- 5 edits in trunk
Remove interpreter specific logic from the JIT builds
Reviewed by Maciej Stachowiak.
This saves ~100k in JSC release builds.
- 2:06 AM Changeset in webkit [44087] by
-
- 1 edit3 adds in trunk/LayoutTests
Add tests to cover exceptions thrown from non-object results of get_by_id
Reviewed by Maciej Stachowiak
- 1:25 AM Changeset in webkit [44086] by
-
- 2 edits in trunk/WebKitTools
Add an error message to a die statement
- 12:32 AM Changeset in webkit [44085] by
-
- 2 edits in trunk/WebCore
2009-05-23 Dirk Schulze <krit@webkit.org>
Unreviewed build-fix for gtk. Remove source input files
for SVG filter system from the build for the moment and
add them later again.
- GNUmakefile.am:
- 12:22 AM Changeset in webkit [44084] by
-
- 2 edits1 delete in trunk/LayoutTests
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Unreviewed. Skip new tests introduced in r44010. These tests
require an eventSender implementation which the gtk port
currently do not have.
Also remove gtk-specific result for
fast/canvas/canvas-composite-alpha. The non-platform specific
result now works.
- platform/gtk/Skipped:
- platform/gtk/fast/canvas/canvas-composite-alpha-expected.txt: Removed.
- 12:19 AM Changeset in webkit [44083] by
-
- 38 edits in trunk/WebCore
2009-05-23 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
Preparing Filter primitves for the new filter system.
No testcases were added. SVG filters are off by default.
- GNUmakefile.am:
- platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
- platform/graphics/filters/FEComposite.h:
- svg/Filter.h:
- svg/FilterBuilder.h: (WebCore::FilterBuilder::lastFilter):
- svg/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
- svg/FilterEffect.h: (WebCore::FilterEffect::xBoundingBoxMode): (WebCore::FilterEffect::setXBoundingBoxMode): (WebCore::FilterEffect::yBoundingBoxMode): (WebCore::FilterEffect::setYBoundingBoxMode): (WebCore::FilterEffect::widthBoundingBoxMode): (WebCore::FilterEffect::setWidthBoundingBoxMode): (WebCore::FilterEffect::heightBoundingBoxMode): (WebCore::FilterEffect::setHeightBoundingBoxMode): (WebCore::FilterEffect::subRegion): (WebCore::FilterEffect::setSubRegion): (WebCore::FilterEffect::resultImage): (WebCore::FilterEffect::setEffectBuffer):
- svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply):
- svg/graphics/filters/SVGFEConvolveMatrix.h:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::apply):
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
- svg/graphics/filters/SVGFEDisplacementMap.h:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
- svg/graphics/filters/SVGFEFlood.h:
- svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
- svg/graphics/filters/SVGFEGaussianBlur.h:
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
- svg/graphics/filters/SVGFEMorphology.h:
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
- svg/graphics/filters/SVGFEOffset.h:
- svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::apply):
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
- svg/graphics/filters/SVGFETile.h:
- svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::apply):
- svg/graphics/filters/SVGFETurbulence.h:
