Timeline
Jul 23, 2009:
- 11:58 PM Changeset in webkit [46320] by
-
- 17 edits in trunk
2009-07-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make most DOMObjects hold onto a JSDOMGlobalObject*
https://bugs.webkit.org/show_bug.cgi?id=27588
inner.document.constructor is fixed because all properties on the window
object are created with the correct globalObject (instead of the lexical one).
Since all objects now carry a globalObject pointer, when document creates
HTMLDocumentConstructor it now has the right globalObject to use.
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
2009-07-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make most DOMObjects hold onto a JSDOMGlobalObject*
https://bugs.webkit.org/show_bug.cgi?id=27588
This change is almost entirely plumbing. Only one functional
change as part of this all (window.document.constructor has the correct prototype)
Changes are detailed below.
inner.document.constructor is fixed because all properties on the window
object are created with the correct globalObject (instead of the lexical one).
Since all objects now carry a globalObject pointer, when document creates
HTMLDocumentConstructor it now has the right globalObject to use.
Tests:
fast/dom/prototype-inheritance.html
fast/dom/prototype-inheritance-2.html
- bindings/js/DOMObjectWithSVGContext.h: (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
Update the comment and add an ignored globalObject argument.
- bindings/js/JSDOMBinding.h:
Pass a globalObject to all DOMObjects during creation. Currently it's the wrong global object.
Once toJS is passed a globalObject it will be the right one.
(WebCore::createDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
- bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::globalObject): Makes binding generation easier.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): JSHistory is now passed a globalObject, but since it has no custom constructor it doesn't use it. (WebCore::JSDOMWindow::location): JSLocation is now passed a globalObject, but since it has no custom constructor it doesn't use it.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): JSLocation is now passed a globalObject, but since it has no custom constructor it doesn't use it.
- bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
- bindings/js/JSHTMLCollectionCustom.cpp: Re-factoring needed to pass globalObject to JSNamedNodesCollection constructor. (WebCore::getNamedItems): (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
- bindings/js/JSNamedNodesCollection.cpp:
Now passed globalObject. This is tested by inner.document.forms.testForm.
The passed globalObject is still wrong until toJS is fixed.
(WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
- bindings/js/JSNamedNodesCollection.h:
- bindings/js/JSSharedWorkerConstructor.cpp:
Add DOMConstructorObject missed by http://trac.webkit.org/changeset/45938
This class is not compiled by default, so not testable.
(WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor):
- bindings/js/JSSharedWorkerConstructor.h:
- bindings/scripts/CodeGeneratorJS.pm:
Make all bindings objects carry a globalObject pointer using DOMObjectWithGlobalPointer.
SVG bindings which need a context() pointer do not have enough space for globalObject() too.
WorkerContext does not need a globalObject (it is one), so special case it.
Make all .constructor calls use the stored globalObject(). This is what fixes window.document.constructor.
Make all constructors inherit from DOMConstructorObject for consistency. Since the auto-bound constructors
override createStructure anyway, there is no functional change here. Just completing work started in r45938.
- 11:50 PM Changeset in webkit [46319] by
-
- 8 edits in trunk
2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Eric Seidel.
[Gtk] Add implementation of GCController for DRT
https://bugs.webkit.org/show_bug.cgi?id=27636
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): (main):
- DumpRenderTree/gtk/GCControllerGtk.cpp: (GCController::collect): (GCController::collectOnAlternateThread):
Enable tests that are now passing.
- platform/gtk/Skipped:
Add SPI for GCController to use.
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_gc_collect_javascript_objects): (webkit_gc_collect_javascript_objects_on_alternate_thread): (webkit_gc_count_javascript_objects):
- 11:37 PM Changeset in webkit [46318] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-07-23 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Add new test to cover more prototype/constructor inheritance cases
https://bugs.webkit.org/show_bug.cgi?id=27622
This new test tries hard not to duplicate testing done
by other tests and instead test new objects and prototype chains
which will be fixed as soon as toJS is passed through the globalObject.
This test crawls the object tree under the inner window, finding
one of each type of JavaScript object. It depends on all objects having
a valid prototype chain with a unique name (which is not always the case).
The test tries to stress the cases where the objects would be lazily
creating other objects or their prototypes or constructors which would
require these objects to have a back-pointer to the globalObject to be
able to correctly wire up the prototype chains.
- fast/dom/prototype-inheritance-2-expected.txt: Added.
- fast/dom/prototype-inheritance-2.html: Added.
- fast/dom/resources/prototype-inheritance-2.js: Added. (propertiesOnObject): (): (constructorNamesForWindow): (makeCrawlObject): (evalToCrawlObject): (pushPropertyValuesWithUnseenTypes): (crawl):
- 11:03 PM Changeset in webkit [46317] by
-
- 2 edits in trunk/LayoutTests
2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Skip transitions/change-values-during-transition.html which
pass/fails intermittently
- platform/gtk/Skipped:
- 10:49 PM Changeset in webkit [46316] by
-
- 2 edits in trunk/LayoutTests
2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Skip tests that require expected outputs. Also skip failing tests,
with bugs raised against the failures.
- platform/gtk/Skipped:
- 10:26 PM Changeset in webkit [46315] by
-
- 2 edits in trunk/LayoutTests
Skip two new tests for GTK that use eventSender.
- platform/gtk/Skipped:
- 10:10 PM Changeset in webkit [46314] by
-
- 39 edits in trunk/LayoutTests
Fix layout tests that incorrectly attempt to detect whether they're running inside DumpRenderTree using "if (layoutTestController)".
Rubber-stamped by Brady Eidson.
- editing/execCommand/25256.html:
- editing/execCommand/25320.html:
- fast/canvas/arc-crash.html:
- fast/css/emptyStyleTag.html:
- fast/events/js-keyboard-event-creation.html:
- fast/events/scrollbar-double-click.html:
- fast/forms/select-no-name.html:
- fast/history/window-open.html:
- platform/mac/fast/events/objc-event-api.html:
- platform/mac/fast/events/objc-keyboard-event-creation.html:
- scrollbars/scrollbar-miss-mousemove-disabled.html:
- scrollbars/scrollbar-miss-mousemove.html:
- storage/domstorage/localstorage/clear.html:
- storage/domstorage/localstorage/delete-removal.html:
- storage/domstorage/localstorage/enumerate-storage.html:
- storage/domstorage/localstorage/index-get-and-set.html:
- storage/domstorage/localstorage/onstorage-attribute-markup.html:
- storage/domstorage/localstorage/onstorage-attribute-setattribute.html:
- storage/domstorage/localstorage/private-browsing-affects-storage.html:
- storage/domstorage/localstorage/resources/window-open-second.html:
- storage/domstorage/localstorage/simple-events.html:
- storage/domstorage/localstorage/simple-usage.html:
- storage/domstorage/localstorage/string-conversion.html:
- storage/domstorage/localstorage/window-open.html:
- storage/domstorage/sessionstorage/clear.html:
- storage/domstorage/sessionstorage/delete-removal.html:
- storage/domstorage/sessionstorage/enumerate-storage.html:
- storage/domstorage/sessionstorage/index-get-and-set.html:
- storage/domstorage/sessionstorage/onstorage-attribute-markup.html:
- storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html:
- storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
- storage/domstorage/sessionstorage/resources/window-open-second.html:
- storage/domstorage/sessionstorage/simple-events.html:
- storage/domstorage/sessionstorage/simple-usage.html:
- storage/domstorage/sessionstorage/string-conversion.html:
- storage/domstorage/sessionstorage/window-open.html:
- storage/domstorage/window-attributes-exist.html:
- svg/custom/stop-crash.svg:
- 9:59 PM Changeset in webkit [46313] by
-
- 2 edits in trunk/LayoutTests
And now with some valid JavaScript syntax!
- http/tests/misc/redirect-to-about-blank.html:
- 9:51 PM Changeset in webkit [46312] by
-
- 2 edits in trunk/LayoutTests
Remove unnecessary check for eventSender in an attempt to please the GTK build bot.
- fast/css/getComputedStyle/getComputedStyle-text-overflow.html:
- 9:35 PM Changeset in webkit [46311] by
-
- 2 edits in trunk/WebKitTools
Update build.webkit.org config for new machine.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 9:32 PM Changeset in webkit [46310] by
-
- 2 edits in trunk/LayoutTests
Add a workaround for <rdar://problem/6925892> to the test that it affects.
Reviewed by Brady Eidson.
- http/tests/misc/redirect-to-about-blank.html:
- 8:56 PM Changeset in webkit [46309] by
-
- 2 edits in trunk/WebKitTools
2009-07-23 Brady Eidson <beidson@apple.com>
Remove accidentally checked in code.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (waitUntilDoneWatchdogFired): (LayoutTestController::setWaitToDump):
- 8:00 PM Changeset in webkit [46308] by
-
- 14 edits3 adds in trunk
WebCore:
2009-07-23 Brady Eidson <beidson@apple.com>
Reviewed by Geoff Garen.
WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595
Test: http/tests/misc/will-send-request-returns-null-on-redirect.html
- inspector/InspectorController.cpp: (WebCore::InspectorController::removeResource): Null-check the request URL.
- platform/network/cf/ResourceHandleCFNet.cpp: Ditto, and return null instead of creating an empty one. (WebCore::willSendRequest):
WebKit/win:
2009-07-23 Brady Eidson <beidson@apple.com>
Reviewed by Geoff Garen.
WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchWillSendRequest):
WebKitTools:
2009-07-23 Brady Eidson <beidson@apple.com>
Reviewed by Geoff Garen.
WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595
Add the ability to tell the LayoutTestController to return a null request for willSendRequest
redirect callbacks.
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setWillSendRequestReturnsNullOnRedirectCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::willSendRequestReturnsNullOnRedirect): (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
- DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest):
LayoutTests:
2009-07-23 Brady Eidson <beidson@apple.com>
Reviewed by Geoff Garen.
WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595
- http/tests/misc/resources/redirect-to-http-url.php: Added.
- http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
- http/tests/misc/will-send-request-returns-null-on-redirect.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 7:54 PM Changeset in webkit [46307] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>
Fix layout tests, no review.
Actually add the video-layer tests results for leopard, that were
forgotten in r46302. Also add test results for windows.
- platform/mac-leopard/fast/layers/video-layer-expected.png: Added.
- platform/mac-leopard/fast/layers/video-layer-expected.txt: Added.
- platform/win/fast/layers/video-layer-expected.txt: Added.
- 7:38 PM Changeset in webkit [46306] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 7:38 PM Changeset in webkit [46305] by
-
- 1 copy in tags/Safari-6531.8
New tag.
- 7:14 PM Changeset in webkit [46304] by
-
- 2 edits in trunk/WebKitTools
Fix DumpRenderTree to not fail an assertion on launch on a new machine.
Reviewed Oliver Hunt.
- DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting): Disable the XSS auditor. It being enabled
breaks all of the JavaScript tests within testStringByEvaluatingJavaScriptFromString,
which causes us to exit due to an assertion failure. It's not clear why the XSS auditor
decides to interfere with these tests.
- 6:40 PM Changeset in webkit [46303] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r46246.
- 5:55 PM Changeset in webkit [46302] by
-
- 4 edits1 copy1 add in trunk/LayoutTests
2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Following changes on the video controls, video-layer tests results need to
be updated in order to fix the layout tests.
- platform/mac-leopard/fast/layers/video-layer-expected.checksum: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.checksum.
- platform/mac-leopard/fast/layers/video-layer-expected.png: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.png.
- platform/mac-leopard/fast/layers/video-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.txt.
- platform/mac/fast/layers/video-layer-expected.checksum: Removed.
- platform/mac/fast/layers/video-layer-expected.png: Removed.
- platform/mac/fast/layers/video-layer-expected.txt: Updated.
- 5:35 PM Changeset in webkit [46301] by
-
- 2 edits in trunk/WebCore
Bug 27633 - AXLoadComplete can be fired off to frequently
https://bugs.webkit.org/show_bug.cgi?id=27633
- 5:11 PM Changeset in webkit [46300] by
-
- 2 edits in trunk/WebKit/mac
2009-07-23 Darin Adler <Darin Adler>
- WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Landed a comment I forgot last time.
- 5:09 PM Changeset in webkit [46299] by
-
- 3 edits1 copy1 move in trunk/LayoutTests
Update layout test results for three tests related to text fields as their metrics
have changed slightly since the results were last updated.
Rubber-stamped by Dan Bernstein.
- platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Copied from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
- platform/mac/fast/forms/input-text-maxlength-expected.txt:
- platform/mac/fast/forms/input-text-paste-maxlength-expected.txt:
- platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
- 5:09 PM Changeset in webkit [46298] by
-
- 5 edits in trunk
WebCore:
2009-07-23 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
URL appears in back/forward button menu instead of title for items with custom representation
https://bugs.webkit.org/show_bug.cgi?id=27586
rdar://problem/5060337
- WebCore.base.exp: Exported DocumentLoader::setTitle for use by Mac WebKit.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didChangeTitle): Tightened code to check if the document loader is the correct one; previously this would never happen because we'd commit the load before any title changes could be registered, but now we can encounter a case where we get a title during a provisional load.
WebKit/mac:
2009-07-23 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
URL appears in back/forward button menu instead of title for items with custom representation
https://bugs.webkit.org/show_bug.cgi?id=27586
rdar://problem/5060337
The problem is that DocumentLoader expects to store a title, but for custom representations
it is never passed to the document loader.
- WebView/WebDataSource.mm: (-[WebDataSource _makeRepresentation]): Added a call to DocumentLoader::setTitle. Works as long as the title does not change during the document's lifetime, which is good enough for the simple cases in Safari.
- 4:44 PM Changeset in webkit [46297] by
-
- 2 edits in trunk/WebKitTools
Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows
in hopes of fixing some layout test failures seen on the build bot.
Reviewed by Oliver Hunt.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
- 4:08 PM Changeset in webkit [46296] by
-
- 1 edit2 copies in trunk/LayoutTests
Windows appears to match the Leopard results for the CSS 2.1 counter tests that were failing.
- platform/win/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt.
- platform/win/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt.
- 4:00 PM Changeset in webkit [46295] by
-
- 17 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
[CSS3 Backgrounds and Borders] Add support for inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=27582
Test: fast/box-shadow/inset.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): Set the ShadowValue’s shadow style to 'inset'
as needed.
- css/CSSParser.cpp: (WebCore::ShadowParseContext::ShadowParseContext): Added style and allowStyle
members. Initialize the allowStyle member.
(WebCore::ShadowParseContext::commitValue): Pass the style value to the
ShadowValue constructor. Reset allowStyle.
(WebCore::ShadowParseContext::commitLength): Update allowStyle.
(WebCore::ShadowParseContext::commitColor): Ditto.
(WebCore::ShadowParseContext::commitStyle): Added. Sets the style member and
updates the state.
(WebCore::CSSParser::parseShadow): Parse the 'inset' keyword.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Get the style value from the
shadow value and pass it to the ShadowData constructor.
- css/ShadowValue.cpp: (WebCore::ShadowValue::ShadowValue): Added style. (WebCore::ShadowValue::cssText): Added style.
- css/ShadowValue.h: (WebCore::ShadowValue::create): Added style.
- page/animation/AnimationBase.cpp: (WebCore::blendFunc): Added a blend function for shadow styles. When blending
between normal and inset shadows, all intermediate values map to normal.
(WebCore::PropertyWrapperShadow::blend): Added normal style to the default
shadow.
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxShadow): Added a shadow style parameter,
which is passed through to RenderBoxModelObject::paintBoxShadow().
(WebCore::InlineFlowBox::paintBoxDecorations): Paint inset shadows on top of
the background.
- rendering/InlineFlowBox.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Paint inset shadows on top of the
background.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Added a shadow style
parameter, and code to paint inset shadows.
- rendering/RenderBoxModelObject.h:
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): Paint inset shadows on top of
the background.
- rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): Ditto.
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations): Ditto.
- rendering/style/ShadowData.h: Added a ShadowStyle enum. (WebCore::ShadowData::ShadowData): Add and initialize a style member.
LayoutTests:
Reviewed by Dave Hyatt.
[CSS3 Backgrounds and Borders] Add support for inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=27582
- fast/box-shadow/inset.html: Added.
- platform/mac/fast/box-shadow/inset-expected.checksum: Added.
- platform/mac/fast/box-shadow/inset-expected.png: Added.
- platform/mac/fast/box-shadow/inset-expected.txt: Added.
- 3:53 PM Changeset in webkit [46294] by
-
- 3 edits in trunk/WebKitTools
2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Treat.
Fix false positives for switch statement indentation check in cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27615
Makes one-line case statements (e.g. "case foo: bar();") work.
Also a few general improvements to the robustness and readability of
the check, and more test cases.
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 3:52 PM Changeset in webkit [46293] by
-
- 2 edits in trunk/WebCore
2009-07-23 Simon Fraser <Simon Fraser>
Fix the build with UNUSED_PARAM(frame) for when ENABLE(3D_RENDERING) is not defined.
- css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
- 3:49 PM Changeset in webkit [46292] by
-
- 3 edits in trunk/WebKitTools
2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Treat.
Add check for line-breaking rule #3 to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27610
"An else if statement should be written as an if statement when
the prior if concludes with a return statement."
Implemented by a multi-line (kind of back-tracking) algorithm.
Comes with loads of unit tests. Fixes the check for label indentation
to be not so overzealous, as it didn't allow for completely unindented
goto labels (at the very start of a line).
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 3:37 PM Changeset in webkit [46291] by
-
- 2 edits in trunk/WebCore
2009-07-23 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson.
3d-transforms media query needs to look check that accelerated compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=27621
When evaluating a media query with '-webkit-transform-3d', we need to check the
runtime switch that toggles accererated compositing, and therefore 3D.
No test because we can't disable the pref dynamically in DRT.
- css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
- 3:31 PM Changeset in webkit [46290] by
-
- 3 edits1 copy2 moves in trunk/LayoutTests
Update layout test results for two international text tests that are failing due to font differences.
Rubber-stamped by Dan Bernstein.
- platform/mac-leopard/fast/text/international/thai-baht-space-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.checksum.
- platform/mac-leopard/fast/text/international/thai-baht-space-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.png.
- platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.txt.
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
- platform/mac/fast/text/international/thai-baht-space-expected.txt:
- 3:13 PM Changeset in webkit [46289] by
-
- 3 edits2 copies in trunk/LayoutTests
Update layout test results for two CSS 2.1 counter tests that are failing due to font differences.
Rubber-stamped by Dan Bernstein.
- platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.txt.
- platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.txt.
- platform/mac/css2.1/t1202-counter-04-b-expected.txt:
- platform/mac/css2.1/t1202-counters-04-b-expected.txt:
- 3:03 PM Changeset in webkit [46288] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>
Layout test fix so no review.
Add audio-controls-rendering layout test results for windows and leopard.
- platform/mac-leopard/media/audio-controls-rendering-expected.txt: Added.
- platform/win/media/audio-controls-rendering-expected.txt: Added.
- 2:40 PM Changeset in webkit [46287] by
-
- 10 edits in trunk/LayoutTests
Update layout test results for the addition of a new computed style property in r46285.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 2:17 PM Changeset in webkit [46286] by
-
- 6 edits3 adds in trunk
WebCore:
2009-07-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215
This patch adds support for u, s, and strike to implicitlyStyledElementShouldBeRemovedWhenApplyingStyle so that
WebKit can remove those presentational tags when necessary.
It also modifies StyleChange::init not to add "text-decoration: none". Not only is this style meaningless
(does not override inherited styles) but it was also causing WebKit to generate extra spans with this style.
- css/CSSValueList.cpp: (WebCore::CSSValueList::hasValue): True if the property contains the specified value
- css/CSSValueList.h: Updated prototype
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): No longer adds "text-decoration: none" (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): Supports text-decoration-related elements
LayoutTests:
2009-07-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215
This patch rebaselines toggle-styles.html because WebKit now passes three tests it used to fail.
toggle-style-2.html is added to test cases in which multiple styles are specified with tags.
We still fail some tests because WebKit doesn't properly support non-CSS mode but they are visually correct.
- editing/execCommand/resources/toggle-style-2.js: Added. (testSingleToggle): (testDoubleToggle):
- editing/execCommand/toggle-style-2-expected.txt: Added.
- editing/execCommand/toggle-style-2.html: Added.
- editing/execCommand/toggle-styles-expected.txt: Passes all the tests
- 2:03 PM Changeset in webkit [46285] by
-
- 3 edits2 adds in trunk
2009-07-23 Jessie Berlin <jberlin@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=27554
Expose the value of text-overflow in getComputedStyle.
Reviewed by Dan Bernstein.
Test: fast/css/getComputedStyle/getComputedStyle-text-overflow.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::): Add text-overflow to the list of computedProperties. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return the value of the text-overflow property.
- fast/css/getComputedStyle/getComputedStyle-text-overflow-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-text-overflow.html: Added.
- 1:48 PM Changeset in webkit [46284] by
-
- 2 edits in trunk/WebCore
2009-07-23 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
[S60 QtWebKit] Don't put some intermediate generated files into the final mmp project
file for linking. This is a temporary workaround for qmake bug in Symbian port, should
be reverted after qmake is fixed.
- WebCore.pro:
- 1:37 PM Changeset in webkit [46283] by
-
- 2 edits in trunk/WebCore
2009-07-23 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
[V8] Fix an assert in running workers in Chrome.
https://bugs.webkit.org/show_bug.cgi?id=27620
The fix is to change V8DOMMap::removeAllDOMObjectsInCurrentThreadHelper
to do not call removeObjectsFromWrapperMap for certain types of DOM
objects that exist only in main thread.
- bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
- 12:24 PM Changeset in webkit [46282] by
-
- 3 edits in trunk/LayoutTests
2009-07-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by David Hyatt.
Rebaseline for http://trac.webkit.org/changeset/46274
(The changeset rebaselined the expected results for mac but not for windows)
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 12:06 PM Changeset in webkit [46281] by
-
- 11 edits5 adds in trunk
WebCore:
2009-07-23 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27572
Implement support for background-attachment:local.
Added new test fast/overflow/overflow-with-local-attachment.html.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: (WebCore::CSSParser::parseFillProperty):
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFillAttachment):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapFillAttachment):
- css/CSSValueKeywords.in:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/style/FillLayer.h: (WebCore::FillLayer::attachment): (WebCore::FillLayer::setAttachment): (WebCore::FillLayer::hasFixedImage): (WebCore::FillLayer::initialFillAttachment):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::backgroundAttachment): (WebCore::InheritedFlags::maskAttachment):
- rendering/style/RenderStyleConstants.h: (WebCore::):
LayoutTests:
2009-07-23 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27572
Implement support for background-attachment:local.
Added new test fast/overflow/overflow-with-local-attachment.html.
- fast/overflow/overflow-with-local-background-attachment.html: Added.
- platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum: Added.
- platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
- platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.
- 11:55 AM Changeset in webkit [46280] by
-
- 8 edits in trunk/WebCore
2009-07-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
copyInheritableProperties and removeComputedInheritablePropertiesFrom should be deprecated
https://bugs.webkit.org/show_bug.cgi?id=27325
This patch deprecates copyInheritableProperties because it has been used for two different purposes:
- Calculating the typing style.
- Moving HTML subtrees and seeking to remove redundant styles. These tasks should be broken out into two separate functions. New code should not use this function.
It deletes removeComputedInheritablePropertiesFrom because it hasn't been used anywhere.
There is no test since the patch does not change any behavior.
- css/CSSComputedStyleDeclaration.cpp: removeComputedInheritablePropertiesFrom has been removed (WebCore::CSSComputedStyleDeclaration::deprecatedCopyInheritableProperties): has been renamed from copyInheritableProperties
- css/CSSComputedStyleDeclaration.h: ditto
- editing/DeleteSelectionCommand.cpp: ditto (WebCore::removeEnclosingAnchorStyle): ditto (WebCore::DeleteSelectionCommand::saveTypingStyleState): ditto
- editing/EditCommand.cpp: ditto (WebCore::EditCommand::styleAtPosition): ditto
- editing/RemoveFormatCommand.cpp: ditto (WebCore::RemoveFormatCommand::doApply): ditto
- editing/ReplaceSelectionCommand.cpp: ditto (WebCore::handleStyleSpansBeforeInsertion): ditto (WebCore::ReplaceSelectionCommand::handleStyleSpans): ditto
- editing/markup.cpp: ditto (WebCore::removeEnclosingMailBlockquoteStyle): ditto (WebCore::removeDefaultStyles): ditto (WebCore::createMarkup): ditto
- 11:42 AM Changeset in webkit [46279] by
-
- 7 edits in trunk
WebCore:
2009-07-22 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589
- rendering/MediaControlElements.cpp: (WebCore::MediaControlTimeDisplayElement::setVisible): Make sure we don't forget to remember the visibility if there is no renderer.
LayoutTests:
2009-07-22 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589
- platform/mac-snowleopard/Skipped: Enables back audio-controls-rendering.
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- 11:29 AM Changeset in webkit [46278] by
-
- 1 edit18 adds in trunk/LayoutTests
2009-07-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Adam Treat.
Added expected results for tests that we pass.
- platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
- platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
- platform/qt/fast/box-shadow/transform-fringing-expected.txt: Added.
- platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
- platform/qt/fast/css/attribute-selector-dynamic-expected.txt: Added.
- platform/qt/fast/css/nth-child-dynamic-expected.txt: Added.
- platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
- platform/qt/fast/dynamic/anchor-lock-expected.txt: Added.
- platform/qt/fast/frames/frameset-style-recalc-expected.txt: Added.
- platform/qt/fast/frames/iframe-text-contents-expected.txt: Added, equal to mac.
- platform/qt/fast/frames/viewsource-on-image-file-expected.txt: Added.
- platform/qt/fast/repaint/background-generated-expected.txt: Added, equal to mac.
- platform/qt/fast/repaint/background-misaligned-expected.txt: Added, equal to mac.
- platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Added, equal to mac.
- platform/qt/fast/text/international/hindi-whitespace-expected.txt: Added.
- platform/qt/fast/transforms/bounding-rect-zoom-expected.txt: Added.
- 11:21 AM Changeset in webkit [46277] by
-
- 2 edits in trunk/JavaScriptCore
wx build fix, adding missing header.
- 11:10 AM Changeset in webkit [46276] by
-
- 3 edits in trunk/WebCore
2009-07-23 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=27598 Clean up the
AccessibilityObject class
Mostly this is just moving empty stubs into the header rather than
muddying the cpp file with them. A few functions were made pure
virtual.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isARIAControl): (WebCore::AccessibilityObject::clickPoint): (WebCore::AccessibilityObject::documentFrameView): (WebCore::AccessibilityObject::actionVerb):
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::intValue): (WebCore::AccessibilityObject::layoutCount): (WebCore::AccessibilityObject::doAccessibilityHitTest): (WebCore::AccessibilityObject::focusedUIElement): (WebCore::AccessibilityObject::firstChild): (WebCore::AccessibilityObject::lastChild): (WebCore::AccessibilityObject::previousSibling): (WebCore::AccessibilityObject::nextSibling): (WebCore::AccessibilityObject::parentObjectIfExists): (WebCore::AccessibilityObject::observableObject): (WebCore::AccessibilityObject::linkedUIElements): (WebCore::AccessibilityObject::titleUIElement): (WebCore::AccessibilityObject::ariaRoleAttribute): (WebCore::AccessibilityObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityObject::ariaRoleHasPresentationalChildren): (WebCore::AccessibilityObject::roleValue): (WebCore::AccessibilityObject::ariaAccessiblityName): (WebCore::AccessibilityObject::ariaLabeledByAttribute): (WebCore::AccessibilityObject::ariaDescribedByAttribute): (WebCore::AccessibilityObject::accessibilityDescription): (WebCore::AccessibilityObject::ariaSelectedTextDOMRange): (WebCore::AccessibilityObject::axObjectCache): (WebCore::AccessibilityObject::axObjectID): (WebCore::AccessibilityObject::setAXObjectID): (WebCore::AccessibilityObject::anchorElement): (WebCore::AccessibilityObject::actionElement): (WebCore::AccessibilityObject::boundingBoxRect): (WebCore::AccessibilityObject::selectedTextRange): (WebCore::AccessibilityObject::selectionStart): (WebCore::AccessibilityObject::selectionEnd): (WebCore::AccessibilityObject::url): (WebCore::AccessibilityObject::selection): (WebCore::AccessibilityObject::stringValue): (WebCore::AccessibilityObject::title): (WebCore::AccessibilityObject::helpText): (WebCore::AccessibilityObject::textUnderElement): (WebCore::AccessibilityObject::text): (WebCore::AccessibilityObject::textLength): (WebCore::AccessibilityObject::selectedText): (WebCore::AccessibilityObject::accessKey): (WebCore::AccessibilityObject::widget): (WebCore::AccessibilityObject::widgetForAttachmentView): (WebCore::AccessibilityObject::setFocused): (WebCore::AccessibilityObject::setSelectedText): (WebCore::AccessibilityObject::setSelectedTextRange): (WebCore::AccessibilityObject::setValue): (WebCore::AccessibilityObject::setSelected): (WebCore::AccessibilityObject::makeRangeVisible): (WebCore::AccessibilityObject::childrenChanged): (WebCore::AccessibilityObject::addChildren): (WebCore::AccessibilityObject::hasChildren): (WebCore::AccessibilityObject::selectedChildren): (WebCore::AccessibilityObject::visibleChildren): (WebCore::AccessibilityObject::visiblePositionRange): (WebCore::AccessibilityObject::visiblePositionRangeForLine): (WebCore::AccessibilityObject::boundsForVisiblePositionRange): (WebCore::AccessibilityObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityObject::visiblePositionForPoint): (WebCore::AccessibilityObject::nextVisiblePosition): (WebCore::AccessibilityObject::previousVisiblePosition): (WebCore::AccessibilityObject::visiblePositionForIndex): (WebCore::AccessibilityObject::indexForVisiblePosition): (WebCore::AccessibilityObject::index): (WebCore::AccessibilityObject::doAXRangeForLine): (WebCore::AccessibilityObject::doAXRangeForIndex): (WebCore::AccessibilityObject::doAXStringForRange): (WebCore::AccessibilityObject::doAXBoundsForRange): (WebCore::AccessibilityObject::updateBackingStore):
- 11:05 AM Changeset in webkit [46275] by
-
- 4 edits in trunk/WebCore
Fix of <rdar://4877658> Dragging from the area between the horizontal/vertical scrollbars when status bar is showing starts a selection and autoscroll.
- 10:20 AM Changeset in webkit [46274] by
-
- 10 edits in trunk
WebCore:
2009-07-23 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27581
Drop the prefix from the box-shadow property.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::ShadowParseContext::commitLength): (WebCore::cssPropertyID):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
LayoutTests:
2009-07-23 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27581
Drop the prefix from the box-shadow property.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 9:55 AM Changeset in webkit [46273] by
-
- 4 edits4 adds in trunk
WebCore:
2009-07-22 Viet-Trung Luu <viettrungluu@gmail.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=27289
When a mouse click occurs on a scrollbar without a preceding mouse move
onto it, the release isn't handled correctly (since
EventHandler::m_lastScrollbarUnderMouse isn't set on mouse down, but
only on mouse move). (Side comment: That scrollbar-handling code
in EventHandler is ugly. It should be fixed properly.)
Tests: scrollbars/scrollbar-miss-mousemove.html
scrollbars/scrollbar-miss-mousemove-disabled.html
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::updateLastScrollbarUnderMouse):
- page/EventHandler.h:
LayoutTests:
2009-07-22 Viet-Trung Luu <viettrungluu@gmail.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=27289
Tests that mouse clicks/releases are handled properly on scrollbars
even when there is no mouse move onto the scrollbar (two cases: enabled
and disabled controls).
- scrollbars/scrollbar-miss-mousemove-disabled-expected.txt: Added.
- scrollbars/scrollbar-miss-mousemove-disabled.html: Added.
- scrollbars/scrollbar-miss-mousemove-expected.txt: Added.
- scrollbars/scrollbar-miss-mousemove.html: Added.
- 9:52 AM Changeset in webkit [46272] by
-
- 2 edits in trunk/WebCore
2009-07-23 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by David Levin.
Update WebCore/page/BarInfo.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27606
- page/BarInfo.cpp: (WebCore::BarInfo::visible):
- 9:52 AM Changeset in webkit [46271] by
-
- 2 edits in trunk/WebCore
2009-07-23 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by David Levin.
Update WebCore/page/Console.cpp to conform to WebKit
Style Guidelines as identified by cpplint.py.
https://bugs.webkit.org/show_bug.cgi?id=27606
- page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): (WebCore::Console::profile): (WebCore::Console::time):
- 9:32 AM Changeset in webkit [46270] by
-
- 2 edits in trunk/WebKitTools
2009-07-23 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by Adam Treat.
Improve git workflow by populating commit messages with ChangeLog entries.
https://bugs.webkit.org/show_bug.cgi?id=27605
add --[no-]write option to optionally output new ChangeLog entries to
stdout instead of modifying ChangeLog files
fix Torch Mobile copyright
- Scripts/prepare-ChangeLog:
- 9:13 AM Changeset in webkit [46269] by
-
- 3 edits in trunk/WebKitTools
2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Treat.
Enable cpplint for .c files.
https://bugs.webkit.org/show_bug.cgi?id=27604
Also make sure that the check for NULL does not apply to .c files.
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 8:51 AM Changeset in webkit [46268] by
-
- 1 edit3 adds in trunk/JavaScriptCore
2009-07-22 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
Add wince specific memory files into wtf/wince
https://bugs.webkit.org/show_bug.cgi?id=27550
- wtf/wince/FastMallocWince.h: Added.
- wtf/wince/MemoryManager.cpp: Added.
- wtf/wince/MemoryManager.h: Added.
- 7:31 AM Changeset in webkit [46267] by
-
- 3 edits in trunk/WebKit/qt
2009-07-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Add simple proxy support for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=27495
Picks up proxy settings from the http_proxy environment
variable.
- QtLauncher/QtLauncher.pro: Add QtNetwork dependency for all platforms.
- QtLauncher/main.cpp: (MainWindow::MainWindow):
- 7:28 AM Changeset in webkit [46266] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-23 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Fix for missing mmap features in Symbian
https://bugs.webkit.org/show_bug.cgi?id=24540
Fix, conditionally for PLATFORM(SYMBIAN), as an alternative
to missing support for the MAP_ANON property flag in mmap.
It utilizes Symbian specific memory allocation features.
- runtime/Collector.cpp
- 6:34 AM Changeset in webkit [46265] by
-
- 6 edits in trunk
WebCore:
2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Fix crashes with the QObject bindings after garbage collection.
There is one QtInstance per wrapped QObject, and that QtInstance keeps
references to cached JSObjects for slots. When those objects get
deleted due to GC, then they becoming dangling pointers.
When a cached member dies, it is now removed from the QtInstance's
cache.
As we cannot track the lifetime of the children, we have to remove
them from QtInstance alltogether. They are not cached and were
only used for mark(), but we _want_ them to be subject to gc.
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::~QtInstance): Minor coding style cleanup, use qDeleteAll(). (JSC::Bindings::QtInstance::removeCachedMethod): New function, to clean m_methods and m_defaultMethod. (JSC::Bindings::QtInstance::mark): Avoid marking already marked objects. (JSC::Bindings::QtField::valueFromInstance): Don't save children for marking.
- bridge/qt/qt_instance.h: Declare removeCachedMethod.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod): Call removeCachedMethod with this on the instance.
WebKit/qt:
2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Added a testcase to verify that cached methods in the QOBject bindings
remain alife even after garbage collection.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):
- 3:24 AM Changeset in webkit [46264] by
-
- 2 edits in trunk/WebKit/qt
2009-07-23 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
Fixing two issues related to QtLauncher
- MainWindow objects are not always freed after close
- JavaScript window.close() sometimes crashes
- QtLauncher/main.cpp: (MainWindow::MainWindow): (main):
- 3:20 AM Changeset in webkit [46263] by
-
- 3 edits in trunk/LayoutTests
2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Rebaseline the Qt results for computed-style.html and
computed-style-without-rendered.html after r46240, similar to r46252.
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 2:57 AM Changeset in webkit [46262] by
-
- 5 edits in trunk/LayoutTests
2009-07-23 David Levin <levin@chromium.org>
Rubber-stamped by Oliver Hunt.
Improve keyboard navigation of Select elements.
Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
on non-Mac platforms.
https://bugs.webkit.org/show_bug.cgi?id=22784
One more round of speculative fixes:
- Really fix the general and win expected results. (They were missing a return.)
- Disable the test for gtk (and remove the attempted workaround for that platform).
- fast/forms/select-popup-pagekeys-expected.txt:
- fast/forms/select-popup-pagekeys.html:
- platform/gtk/Skipped:
- platform/win/fast/forms/select-popup-pagekeys-expected.txt:
- 2:09 AM Changeset in webkit [46261] by
-
- 3 edits1 copy in trunk/LayoutTests
2009-07-23 David Levin <levin@chromium.org>
Rubber-stamped by Oliver Hunt.
3 (speculative) fixes for the new layout test: select-popup-pagekeys
- Help Windows to pass by adding platform results.
- Fix the general expected results.
- Fix select-popup-pagekeys on gtk which doesn't seem to implement eventSender.
- fast/forms/select-popup-pagekeys-expected.txt:
- fast/forms/select-popup-pagekeys.html:
- platform/win/fast/forms/select-popup-pagekeys-expected.txt: Added.
- 1:01 AM Changeset in webkit [46260] by
-
- 2 edits in trunk/WebCore
2009-07-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27599
'const unsigned' in return value
Remove const modifier from unsigned return value, as it does not
make sense.
- dom/ErrorEvent.h:
- 12:52 AM Changeset in webkit [46259] by
-
- 3 edits3 adds in trunk
2009-07-22 Jens Alfke <snej@chromium.org>
Reviewed by David Levin.
Bug 22784: Improve keyboard navigation of Select elements.
Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
on non-Mac platforms.
https://bugs.webkit.org/show_bug.cgi?id=22784
http://code.google.com/p/chromium/issues/detail?id=4576
WebCore:
New test: LayoutTests/fast/forms/select-popup-pagekeys.html
- dom/SelectElement.cpp: (WebCore::nextValidIndex): New utility fn for traversing items of a select's list. (WebCore::SelectElement::menuListDefaultEventHandler): Added code to handle Home/End and PageUp/PageDn when ARROW_KEYS_POP_MENU is false.
LayoutTests:
- LayoutTests/fast/forms/select-popup-pagekeys.html: Added.
- LayoutTests/fast/forms/select-popup-pagekeys-expected.txt: Added
- LayoutTests/platform/mac/fast/forms/select-popup-pagekeys-expected.txt: Added.
- 12:36 AM Changeset in webkit [46258] by
-
- 3 edits in trunk/WebCore
2009-07-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
Fix a couple of compiler warnings.
- platform/graphics/cairo/ImageBufferCairo.cpp: (copySurface):
- platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::containsCharacters):
- 12:19 AM Changeset in webkit [46257] by
-
- 4 edits in trunk
WebCore:
2009-07-22 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by David Levin.
Enable HTML5 Datagrid defines for the Qt build.
- WebCore.pro:
LayoutTests:
2009-07-22 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by David Levin.
Unskip HTML 5 Datagrid tests for the Qt DRT, as they pass.
- platform/qt/Skipped:
- 12:00 AM Changeset in webkit [46256] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
Fix compiler warning.
- tests/testwebsettings.c: (test_webkit_web_settings_user_agent):
Jul 22, 2009:
- 11:45 PM WebDevelopers edited by
- Removed outdated links to Safari version matrix, and FAQ. (diff)
- 11:32 PM Changeset in webkit [46255] by
-
- 2 edits in trunk/WebCore
2009-07-22 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[V8] Make Node wrappers go fast
https://bugs.webkit.org/show_bug.cgi?id=27597
Profiles indicate we're spending a lot of time asking whether we're on
the main thread when looking up DOM wrappers for Nodes, but there isn't
much point in doing that work because Nodes only exist on the main
thread. I've also added an assert to keep us honest in this regard.
- bindings/v8/V8DOMMap.cpp: (WebCore::): (WebCore::getDOMNodeMap): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getCurrentMainThread):
- 10:39 PM Changeset in webkit [46254] by
-
- 1 edit6 adds in trunk/WebKitTools
Checkpoint new Windows nightly launcher.
Reviewed by Mark Rowe.
- WebKitLauncherWin: Added.
- WebKitLauncherWin/Resource.h: Added.
- WebKitLauncherWin/WebKitLauncherWin.cpp: Added. (getStringValue): Retrieve a string registry value. (applePathFromRegistry): Get an Apple-related path out of the registry. (copyEnvironmentVariable): Copy an environment variable. (safariInstallDir): Helper function to get the install directory for Safari. (safariBrowserExe): Helper function to get the full path of the Safari executable. (_tWinMain): Locate Safari and launch it after setting up an environment variable.
- WebKitLauncherWin/WebKitLauncherWin.h: Added.
- WebKitLauncherWin/WebKitLauncherWin.rc: Added.
- WebKitLauncherWin/WebKitLauncherWin.vcproj: Added.
- WebKitLauncherWin/webkit.ico: Added.
- 7:52 PM Changeset in webkit [46253] by
-
- 2 edits in trunk/WebCore
2009-07-22 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove unneeded virtual destructor from ScriptSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=27563
- bindings/js/ScriptSourceProvider.h:
- 7:29 PM Changeset in webkit [46252] by
-
- 3 edits in trunk/LayoutTests
2009-07-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
REGRESSION (r46240): /fast/css/getComputedStyle/computed-style & computed-style-without-renderer needs rebaseline for Windows
https://bugs.webkit.org/show_bug.cgi?id=27591
Rebaselines the tests.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 7:01 PM Changeset in webkit [46251] by
-
- 7 edits8 adds in trunk
WebCore:
2009-07-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476
executeStrikethrough and executeUnderline were toggling between "line-through" / "underline" and "none".
This patch adds executeToggleStyleInList that toggles a style in CSSValueList instead of toggling the entire value.
It modifies CSSComputedStyleDeclaration to return CSSValueList instead of CSSPrimitiveValue for text decorations,
and adds removeAll member function to CSSValueList.
Tests: editing/execCommand/toggle-text-decorations.html
fast/css/getComputedStyle/getComputedStyle-text-decoration.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::renderTextDecorationFlagsToCSSValue): Creates a CSSValueList (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Returns a CSSValueList instead of CSSValue
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Text decorations are space separated instead of comma separated
- css/CSSValueList.cpp: (WebCore::CSSValueList::removeAll): Removes all values that match the specified value
- css/CSSValueList.h:
- editing/EditorCommand.cpp: (WebCore::applyCommandToFrame): Apply style to a frame using specified command (WebCore::executeApplyStyle): Uses applyCommandToFrame (WebCore::executeToggleStyleInList): Uses applyCommandToFrame (WebCore::executeToggleStyle): Toggles a style in CSSValueList (WebCore::executeStrikethrough): Uses executeToggleStyleInList (WebCore::executeUnderline): Uses executeToggleStyleInList
LayoutTests:
2009-07-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476
toggle-text-decorations checks whether we can toggle text decorations with multiple styles properly.
e.g. execCommand("underline") should modify "text-decoration: underline overline" to "text-decoration: overline"
getComputedStyle-text-decorations checks whether the CSS value of text decoration and its computed style are
both space-separated CSSValueList instead of CSSPrimitiveValue or comma-separated CSSValueList.
- editing/execCommand/resources/toggle-text-decorations.js: Added. (testSingleToggle):
- editing/execCommand/toggle-text-decorations-expected.txt: Added.
- editing/execCommand/toggle-text-decorations.html: Added.
- fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-text-decoration.html: Added.
- fast/css/getComputedStyle/resources: Added.
- fast/css/getComputedStyle/resources/TEMPLATE.html: Added.
- fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Added. (expect):
- 4:27 PM Changeset in webkit [46250] by
-
- 4 edits9 adds in trunk
2009-07-22 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27174
And
https://bugs.webkit.org/show_bug.cgi?id=26938
Tests prevention of attacks transformed by PHP Magic Quotes/PHP addslashes().
- http/tests/security/xssAuditor/resources/echo-intertag-addslashes.pl: Added.
- http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-addslashes-backslash.html: Added.
- http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html: Added.
- http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-addslashes-null-char.html: Added.
- http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html: Added.
2009-07-22 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27174
And
https://bugs.webkit.org/show_bug.cgi?id=26938
Code cleanup. Implements support for detecting attacks transformed by
PHP Magic Quotes/PHP addslashes().
Tests: http/tests/security/xssAuditor/script-tag-addslashes-backslash.html
http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html
http/tests/security/xssAuditor/script-tag-addslashes-null-char.html
http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html
- page/XSSAuditor.cpp: (WebCore::isInvalidCharacter): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::normalize): Decodes HTML entities, removes backslashes, and removes control characters that could otherwise cause a discrepancy between the source code of a script and the outgoing HTTP parameters. (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::decodeHTMLEntities): (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h:
- 3:48 PM Changeset in webkit [46249] by
-
- 1 edit1 move in trunk/WebKitTools
2009-07-22 David Levin <levin@chromium.org>
Reviewed by Adam Treat.
run-webkit-lint should be named check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=27568
This name better reflects the fact that it is about checking the style of files.
- Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint.
- 3:31 PM Changeset in webkit [46248] by
-
- 3 edits in trunk/WebKitTools
2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Treat.
Fix false positives in namespace indentation checks.
https://bugs.webkit.org/show_bug.cgi?id=27567
The regular expression detecting goto labels (in order
to skip those) was too permissive, which caused other
code like "Foo::Bar()" to be treated as a label too,
thereby not stopping the processing loop as expected.
Now comes with a stricter regexp, and more demanding
test cases to check for these issues.
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 3:17 PM Changeset in webkit [46247] by
-
- 15 edits in trunk/JavaScriptCore
2009-07-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
With ENABLE(ASSEMBLER_WX_EXCLUSIVE), only change permissions once per repatch event.
( https://bugs.webkit.org/show_bug.cgi?id=27564 )
Currently we change permissions forwards and backwards for each instruction modified,
instead we should only change permissions once per complete repatching event.
2.5% progression running with ENABLE(ASSEMBLER_WX_EXCLUSIVE) enabled,
which recoups 1/3 of the penalty of running with this mode enabled.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::linkBranch):
- Replace usage of MakeWritable with cacheFlush.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::patchPointerInternal):
(JSC::ARMAssembler::repatchLoadPtrToLEA):
- Replace usage of MakeWritable with cacheFlush.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::relinkJump):
(JSC::ARMv7Assembler::relinkCall):
(JSC::ARMv7Assembler::repatchInt32):
(JSC::ARMv7Assembler::repatchPointer):
(JSC::ARMv7Assembler::repatchLoadPtrToLEA):
(JSC::ARMv7Assembler::setInt32):
- Replace usage of MakeWritable with cacheFlush.
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::performFinalization):
- Make explicit call to cacheFlush.
- assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
- Make size always available.
- assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::~RepatchBuffer):
- Add calls to MakeWritable & makeExecutable.
- assembler/X86Assembler.h:
(JSC::X86Assembler::relinkJump):
(JSC::X86Assembler::relinkCall):
(JSC::X86Assembler::repatchInt32):
(JSC::X86Assembler::repatchPointer):
(JSC::X86Assembler::repatchLoadPtrToLEA):
- Remove usage of MakeWritable.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::getJITCode):
- Provide access to CodeBlock's JITCode.
- jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::makeExecutable):
(JSC::ExecutableAllocator::cacheFlush):
- Remove MakeWritable, make cacheFlush public.
- jit/JIT.cpp:
(JSC::ctiPatchNearCallByReturnAddress):
(JSC::ctiPatchCallByReturnAddress):
(JSC::JIT::privateCompile):
(JSC::JIT::unlinkCall):
(JSC::JIT::linkCall):
- Add CodeBlock argument to RepatchBuffer.
- jit/JIT.h:
- Pass CodeBlock argument for use by RepatchBuffer.
- jit/JITCode.h:
(JSC::JITCode::start):
(JSC::JITCode::size):
- Provide access to code start & size.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchMethodCallProto):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- Add CodeBlock argument to RepatchBuffer.
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
- Pass CodeBlock argument for use by RepatchBuffer.
- 3:12 PM Changeset in webkit [46246] by
-
- 2 edits in trunk/WebCore
Null deref in JSObject::mark due to null xhr wrapper
https://bugs.webkit.org/show_bug.cgi?id=27565
Reviewed by Adele Peterson.
Make event target binding for appcache and xhr behave in the same way as
it does for all other events.
No test as I couldn't make a testcase which was remotely reliable.
- 3:10 PM Changeset in webkit [46245] by
-
- 4 edits in trunk
2009-07-22 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Darin Adler.
VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
https://bugs.webkit.org/show_bug.cgi?id=26375
WebKit/win:
Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
with hex escape sequences.
VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
treated as an error and stopped build).
WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
represented in the current code page (932). Save the file in Unicode format to prevent data loss
A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
localized string generation process.
- WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):
WebKitTools:
Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now,
the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals
in the macros before writing out them into the file to update.
By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian
strings in the Localizable.strings file.
Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide
users to update-webkit-localizable-strings.
- Scripts/extract-localizable-strings:
- 3:09 PM Changeset in webkit [46244] by
-
- 2 edits in trunk/WebKitTools
2009-07-22 Shinichiro Hamaji <hamaji@google.com>
Reviewed by David Levin.
Tiny typo fixes for cpplint.py
https://bugs.webkit.org/show_bug.cgi?id=27530
- Scripts/modules/cpplint.py:
- 3:09 PM Changeset in webkit [46243] by
-
- 2 edits in trunk/WebKitTools
2009-07-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
run-webkit-lint checks code which are not changed
https://bugs.webkit.org/show_bug.cgi?id=27529
Add check if the line is newly added.
- Scripts/run-webkit-lint:
- 3:09 PM Changeset in webkit [46242] by
-
- 4 edits in trunk/WebKitTools
2009-07-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
run-webkit-lint should have --git-commit option
https://bugs.webkit.org/show_bug.cgi?id=27528
- Scripts/modules/cpplint.py:
- Scripts/run-webkit-lint:
- 3:09 PM Changeset in webkit [46241] by
-
- 2 edits in trunk/WebCore
2009-07-22 Mads Ager <ager@chromium.org>
Reviewed by David Levin.
Inform V8 of the amount of WebCore string memory it is keeping alive.
https://bugs.webkit.org/show_bug.cgi?id=27537
V8 uses external strings that are backed by WebCore strings. Since
the external strings themselves are small, V8 has no way of
knowing how much memory it is actually holding on to. With this
change, we inform V8 of the amount of WebCore string data it is
holding on to with external strings.
- bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource):
- 2:59 PM Changeset in webkit [46240] by
-
- 15 edits12 adds in trunk
WebCore:
2009-07-22 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
https://bugs.webkit.org/show_bug.cgi?id=27562
Add the finalized versions of background-clip and background-origin. Remove background-clip from
the background shorthand and have it be auto-set based off background-origin's value.
Three new tests added in fast/backgrounds/size
- css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseFillProperty):
- css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
LayoutTests:
2009-07-22 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
https://bugs.webkit.org/show_bug.cgi?id=27562
Add some new layout tests that drop the prefix from the background properties and use origin
in a shorthand. Update shorthand results and computed style results to account for new properties.
- fast/backgrounds/size/backgroundSize20.html: Added.
- fast/backgrounds/size/backgroundSize21.html: Added.
- fast/backgrounds/size/backgroundSize22.html: Added.
- fast/css/background-position-serialize-expected.txt:
- fast/css/remove-shorthand-expected.txt:
- platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
- platform/mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
- platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Added.
- platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
- platform/mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
- platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Added.
- platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
- platform/mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
- platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Added.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/inspector/style-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 2:47 PM Changeset in webkit [46239] by
-
- 16 edits3 adds in trunk
WebCore:
2009-07-22 Jens Alfke <snej@chromium.org>
Reviewed by Darin Fisher.
Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730
Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.
- WebCore.gypi: Added new source files.
- bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
- bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
- bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates. (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
- bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::V8DataGridDataSource): (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
- bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::create): (WebCore::V8DataGridDataSource::isJSDataGridDataSource): (WebCore::V8DataGridDataSource::jsDataSource): (WebCore::asV8DataGridDataSource):
- bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
- bindings/v8/V8Index.h: Conditionalize datagrid stuff.
- bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
- bindings/v8/custom/V8DataGridColumnListCustom.cpp: Added.
- bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
LayoutTests:
2009-07-22 Jens Alfke <snej@chromium.org>
Reviewed by Darin Fisher.
Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730
Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
- fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
- fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
- 1:46 PM Changeset in webkit [46238] by
-
- 3 edits in trunk/WebCore
2009-07-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
pushDownTextDecorationStyleAroundNode needs clean up
https://bugs.webkit.org/show_bug.cgi?id=27556
Cleaned up. pushDownTextDecorationStyleAroundNode traverses tree vertically from highestAncestor to targetNode
While traversing, it will apply the specified style to all nodes but targetNode.
i.e. the style is applies to all ancestor nodes and their siblings of targetNode.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Cleaned up and added comments
- editing/ApplyStyleCommand.h: Updated prototype
- 1:35 PM Changeset in webkit [46237] by
-
- 4 edits in trunk/WebCore
2009-07-22 Peter Kasting <pkasting@google.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any type of line endings in WebCore/css/*CSSPropertyNames.in.
- DerivedSources.make:
- css/makeprop.pl:
- css/makevalues.pl:
- 1:32 PM Changeset in webkit [46236] by
-
- 4 edits in trunk/WebKitTools
2009-07-22 Peter Kasting <pkasting@google.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=27323
Factor svn-create-patch's "determineSvnRoot()" into a function in
VCSUtils.pm so commit-log-editor can use it too.
- Scripts/VCSUtils.pm: Add determineSVNRoot().
- Scripts/commit-log-editor: Use determineSVNRoot() instead of old code (which didn't work as well).
- Scripts/svn-create-patch: Remove determineSvnRoot() (moved).
- 1:18 PM Changeset in webkit [46235] by
-
- 3 edits in trunk/WebKitTools
Revert bugfix for 27557 as this is invalid according to Darin Adler
who states that include order sorting should be case-sensitive.
- 1:06 PM Changeset in webkit [46234] by
-
- 3 edits in trunk/LayoutTests
2009-07-22 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
expand prototype-inheritance test to cover constructors
https://bugs.webkit.org/show_bug.cgi?id=27547
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/resources/prototype-inheritance.js:
- 1:05 PM Changeset in webkit [46233] by
-
- 3 edits in trunk/WebKitTools
2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Treat.
Case-insensitive comparison of include file order for cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27557
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 1:00 PM Changeset in webkit [46232] by
-
- 5 edits1 add in branches/nitro-extreme/WebCore
2009-07-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some trivial differences between the branch and r45633, to
facilitate the merge.
- bindings/js/ScriptEventListener.cpp:
- bridge/c/c_instance.cpp:
- inspector/front-end/Images/resourcesSilhouette.png: Added.
- rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::paintObject):
- rendering/RenderDataGrid.h:
- 12:51 PM Changeset in webkit [46231] by
-
- 3 edits in trunk/WebKitTools
2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Treat.
Fix cpplint generating false positives for
"primary" includes in headers.
https://bugs.webkit.org/show_bug.cgi?id=27553
Doing so by only flagging includes in header files
as primary when the include filename exactly matches
the header filename.
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 12:24 PM Changeset in webkit [46230] by
-
- 3 edits in trunk/WebKitTools
2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Treat.
cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544
Fix false positives for instances when cpplint would
normally classify multiple includes as primary: After
the first primary include, classify subsequent ones as
"other" includes even if they look like primary ones.
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 11:55 AM Changeset in webkit [46229] by
-
- 2 edits in trunk/WebCore
2009-07-22 Paul Godavari <paul@chromium.org>
Reviewed by Darin Fisher.
Chromium has a build break after removal of JSRGBColor bindings
https://bugs.webkit.org/show_bug.cgi?id=27548
Fix a build break in Chromium V8 after the JSRGBColor bindings change:
https://bugs.webkit.org/show_bug.cgi?id=27242
- bindings/scripts/CodeGeneratorV8.pm:
- 11:46 AM Changeset in webkit [46228] by
-
- 2 edits in trunk/WebKitTools
2009-07-22 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Pass XAUTHORITY environment variable to $dumpTool as well.
- Scripts/run-webkit-tests:
- 10:02 AM Changeset in webkit [46227] by
-
- 2 edits in trunk/WebKit/mac
2009-07-20 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
REGRESSION (r39185): Safari adds ".jpeg" extension to images that already have ".JPG" extension
https://bugs.webkit.org/show_bug.cgi?id=27472
- WebView/WebHTMLView.mm: (matchesExtensionOrEquivalent): Changed category method into a C function. Made it require the leading dot when checking for the extension and do it in a non-case-sensitive way. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Changed to call the function.
- 9:56 AM Changeset in webkit [46226] by
-
- 3 edits in trunk/WebCore
2009-07-22 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
Chromium Linux: add static functions to FontPlatformData which allow
for setting the global font rendering preferences.
https://bugs.webkit.org/show_bug.cgi?id=27513
http://code.google.com/p/chromium/issues/detail?id=12179
This should not affect any layout tests.
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setHinting): (WebCore::FontPlatformData::setAntiAlias): (WebCore::FontPlatformData::setSubpixelGlyphs): (WebCore::FontPlatformData::setupPaint):
- platform/graphics/chromium/FontPlatformDataLinux.h:
- 8:20 AM Changeset in webkit [46225] by
-
- 3 edits in trunk/WebKitTools
2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by Adam Treat.
Add check for correct wtf includes to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27524
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 8:15 AM Changeset in webkit [46224] by
-
- 3 edits in trunk/WebKitTools
2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by David Levin.
Add checks for multi-line boolean operator placement.
https://bugs.webkit.org/show_bug.cgi?id=27496
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 7:13 AM Changeset in webkit [46223] by
-
- 2 edits in trunk/WebKitSite
2009-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Adam Treat.
Mention the new webkit-help and webkit-jobs mailinglist. Change
the description of webkit-dev to be more strict.
- contact.html:
- 6:34 AM Changeset in webkit [46222] by
-
- 2 edits in trunk/WebCore
2009-07-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Move Inspector panels creation into a function to make possible introducing
custom panels.
- inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.loaded):
- 6:33 AM Changeset in webkit [46221] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Remove unused variables.
- webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event):
- 6:30 AM Changeset in webkit [46220] by
-
- 3 edits in trunk/WebCore
2009-07-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Print console command message upon evaluate
selection request; Handle errors in evaluation request
properly.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
- 6:04 AM Changeset in webkit [46219] by
-
- 2 edits in trunk/WebKitSite
2009-07-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Adam Treat.
Coding style - Clarify some cases with spacing
https://bugs.webkit.org/show_bug.cgi?id=27499
Add explicit rule about no space before comma or semicolon.
- coding/coding-style.html:
- 12:47 AM WebKit Team edited by
- (diff)
- 12:46 AM WebKit Team edited by
- (diff)
- 12:17 AM Changeset in webkit [46218] by
-
- 2 edits in trunk/WebCore
2009-07-22 Xan Lopez <xlopez@igalia.com>
Attempt to fix the GTK+ build.
- GNUmakefile.am:
Jul 21, 2009:
- 11:54 PM Changeset in webkit [46217] by
-
- 2 edits in trunk/WebCore
2009-07-21 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build.
- WebCore.pro: Add RGBColor.cpp to the build, remove JSRGBColor.
- 11:19 PM Changeset in webkit [46216] by
-
- 9 edits1 add in trunk/WebCore
2009-07-21 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fixes an issue that can cause a crash or unexpected behavior when calling
WebCore::ScriptSourceCode::source on a cached script.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/CachedScriptSourceProvider.h: Modified to inherit from WebCore::ScriptSourceCode. (WebCore::CachedScriptSourceProvider::source): (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
- bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): Separated out source provider and rewrote to use WebCore::ScriptSourceProvider. (WebCore::ScriptSourceCode::source):
- bindings/js/ScriptSourceProvider.h: Added. (WebCore::ScriptSourceProvider::ScriptSourceProvider): (WebCore::ScriptSourceProvider::~ScriptSourceProvider):
- bindings/js/StringSourceProvider.h: Modified to inherit from WebCore::ScriptSourceCode. (WebCore::StringSourceProvider::StringSourceProvider):
- 10:31 PM Changeset in webkit [46215] by
-
- 2 edits in trunk/WebCore
2009-07-21 Sam Weinig <sam@webkit.org>
Another attempt to fix the Windows build.
- WebCore.vcproj/WebCore.vcproj:
- 10:19 PM Changeset in webkit [46214] by
-
- 2 edits in trunk/WebCore
2009-07-21 Sam Weinig <sam@webkit.org>
Attempt to fix the Windows build.
- DerivedSources.cpp:
- 10:17 PM Changeset in webkit [46213] by
-
- 2 edits in trunk/WebCore
2009-07-21 Sam Weinig <sam@webkit.org>
Attempt to fix the GTK build
- GNUmakefile.am:
- 10:04 PM Changeset in webkit [46212] by
-
- 4 edits1 delete in trunk/WebCore
2009-07-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Autogenerate Objective-C binding implementation for RGBColor.
No functionality change.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMRGBColor.mm: Removed.
- bindings/scripts/CodeGeneratorObjC.pm: Add logic to convert from WebCore::Color to NSColor*.
- css/RGBColor.idl:
- 9:27 PM Changeset in webkit [46211] by
-
- 28 edits2 deletes in trunk
WebCore:
2009-07-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=27242
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor
Move the JSC and Objective-C bindings onto using the RGBColor object instead
of just an unsigned int. The JSC bindings are now completely autogenerated for
this class. (Also removes the last lut from WebCore).
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSRGBColor.cpp: Removed.
- bindings/js/JSRGBColor.h: Removed.
- bindings/objc/DOM.mm: (-[DOMRGBColor _color]):
- bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (-[DOMRGBColor color]):
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getRGBColorValue):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getRGBA32Value):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
- css/RGBColor.cpp: (WebCore::RGBColor::alpha):
- css/RGBColor.h: (WebCore::RGBColor::color): (WebCore::RGBColor::RGBColor):
- css/RGBColor.idl:
- page/DOMWindow.idl:
- svg/SVGColor.cpp: (WebCore::SVGColor::rgbColor):
- svg/SVGColor.h:
LayoutTests:
2009-07-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Changes for https://bugs.webkit.org/show_bug.cgi?id=27242
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/dom-constructors-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/wrapper-classes-expected.txt:
- fast/js/global-constructors-expected.txt:
- 9:03 PM Changeset in webkit [46210] by
-
- 5 edits3 adds in trunk
2009-07-21 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Cache not only the structure of the method, but the
structure of its prototype as well.
https://bugs.webkit.org/show_bug.cgi?id=27077
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock):
- bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::MethodCallLinkInfo):
- jit/JITPropertyAccess.cpp: (JSC::JIT::patchMethodCallProto):
LayoutTests:
2009-07-21 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough, RS olliej fix to make the test pass.
Check whether a crash happens after the string
prototype is overwritten twice. The JIT'ed code
may crash if one of its already cached method
called again. Note: This test is not necessary
crash on all systems, because they use different
memory allocators!
https://bugs.webkit.org/show_bug.cgi?id=27077
- fast/js/method-check-expected.txt: Added.
- fast/js/method-check.html: Added.
- fast/js/resources/method-check.js: Added. (func2): (func.String.prototype.a): (func.String.prototype.b): (func):
- 8:24 PM Changeset in webkit [46209] by
-
- 7 edits in trunk/JavaScriptCore
2009-07-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Move call linking / repatching down from AbstractMacroAssembler into MacroAssemblerARCH classes.
( https://bugs.webkit.org/show_bug.cgi?id=27527 )
This allows the implementation to be defined per architecture. Specifically this addresses the
fact that x86-64 MacroAssembler implements far calls as a load to register, followed by a call
to register. Patching the call actually requires the pointer load to be patched, rather than
the call to be patched. This is implementation detail specific to MacroAssemblerX86_64, and as
such is best handled there.
- assembler/AbstractMacroAssembler.h:
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::linkCall): (JSC::MacroAssemblerARM::repatchCall):
- assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::linkCall): (JSC::MacroAssemblerARMv7::repatchCall):
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::linkCall): (JSC::MacroAssemblerX86::repatchCall):
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::linkCall): (JSC::MacroAssemblerX86_64::repatchCall):
- 7:42 PM Changeset in webkit [46208] by
-
- 2 edits in trunk/LayoutTests
Correct relative path in the test after moving it.
- platform/mac/fast/loader/non-html-load-event.html:
- 7:39 PM Changeset in webkit [46207] by
-
- 2 edits2 moves in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
Move fast/loader/non-html-load-event.html under platform/mac because
non-HTML views exist only on Mac.
- fast/loader/non-html-load-event-expected.txt: Removed.
- fast/loader/non-html-load-event.html: Removed.
- platform/mac/fast/loader/non-html-load-event-expected.txt: Copied from LayoutTests/fast/loader/non-html-load-event-expected.txt.
- platform/mac/fast/loader/non-html-load-event.html: Copied from LayoutTests/fast/loader/non-html-load-event.html.
- platform/qt/Skipped:
- 7:08 PM Changeset in webkit [46206] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 7:07 PM Changeset in webkit [46205] by
-
- 1 copy in tags/Safari-6531.7
New tag.
- 6:39 PM Changeset in webkit [46204] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-21 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
Every wtf file includes other wtf files with <> style includes
except this one. Fix the exception.
- wtf/ByteArray.h:
- 5:43 PM Changeset in webkit [46203] by
-
- 2 edits in trunk/WebCore
2009-07-21 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Implement AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27515
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::dispatchScriptErrorEvent):
- 5:37 PM Changeset in webkit [46202] by
-
- 10 edits2 adds in trunk/JavaScriptCore
2009-07-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
( https://bugs.webkit.org/show_bug.cgi?id=27485 )
This change is the first step in a process to move code that should be in
the architecture-specific MacroAssembler classes up out of Assmbler and
AbstractMacroAssembler.
- JavaScriptCore.xcodeproj/project.pbxproj:
- added new files
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::linkPointer):
- rename patchPointer to bring it in line with the current link/repatch naming scheme
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):
(JSC::ARMv7Assembler::relinkCall):
(JSC::ARMv7Assembler::repatchInt32):
(JSC::ARMv7Assembler::repatchPointer):
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::setPointer):
- rename patchPointer to bring it in line with the current link/repatch naming scheme
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::linkJump):
(JSC::AbstractMacroAssembler::linkCall):
(JSC::AbstractMacroAssembler::linkPointer):
(JSC::AbstractMacroAssembler::getLinkerAddress):
(JSC::AbstractMacroAssembler::getLinkerCallReturnOffset):
(JSC::AbstractMacroAssembler::repatchJump):
(JSC::AbstractMacroAssembler::repatchCall):
(JSC::AbstractMacroAssembler::repatchNearCall):
(JSC::AbstractMacroAssembler::repatchInt32):
(JSC::AbstractMacroAssembler::repatchPointer):
(JSC::AbstractMacroAssembler::repatchLoadPtrToLEA):
- remove the LinkBuffer/RepatchBuffer classes, but leave a set of (private, friended) methods to interface to the Assembler
- assembler/LinkBuffer.h: Added.
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::~LinkBuffer):
(JSC::LinkBuffer::link):
(JSC::LinkBuffer::patch):
(JSC::LinkBuffer::locationOf):
(JSC::LinkBuffer::locationOfNearCall):
(JSC::LinkBuffer::returnAddressOffset):
(JSC::LinkBuffer::finalizeCode):
(JSC::LinkBuffer::finalizeCodeAddendum):
(JSC::LinkBuffer::code):
(JSC::LinkBuffer::performFinalization):
- new file containing the LinkBuffer class, previously a member of AbstractMacroAssembler
- assembler/RepatchBuffer.h: Added.
(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::relink):
(JSC::RepatchBuffer::repatch):
(JSC::RepatchBuffer::repatchLoadPtrToLEA):
(JSC::RepatchBuffer::relinkCallerToTrampoline):
(JSC::RepatchBuffer::relinkCallerToFunction):
(JSC::RepatchBuffer::relinkNearCallerToTrampoline):
- new file containing the RepatchBuffer class, previously a member of AbstractMacroAssembler
- assembler/X86Assembler.h:
(JSC::X86Assembler::linkJump):
(JSC::X86Assembler::linkCall):
(JSC::X86Assembler::linkPointerForCall):
(JSC::X86Assembler::linkPointer):
(JSC::X86Assembler::relinkJump):
(JSC::X86Assembler::relinkCall):
(JSC::X86Assembler::repatchInt32):
(JSC::X86Assembler::repatchPointer):
(JSC::X86Assembler::setPointer):
(JSC::X86Assembler::setInt32):
(JSC::X86Assembler::setRel32):
- rename patchPointer to bring it in line with the current link/repatch naming scheme
- jit/JIT.cpp:
(JSC::ctiPatchNearCallByReturnAddress):
(JSC::ctiPatchCallByReturnAddress):
- include new headers
- remove MacroAssembler:: specification from RepatchBuffer usage
- jit/JITPropertyAccess.cpp:
- yarr/RegexJIT.cpp:
- include new headers
- 5:08 PM Changeset in webkit [46201] by
-
- 7 edits1 add in trunk/WebCore
2009-07-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move m_context out of generator into a superclass
https://bugs.webkit.org/show_bug.cgi?id=27521
Mostly this is removing code from CodeGeneratorJS
and instead using a DOMObjectWithSVGContext superclass in JSDOMBinding.h.
DOMObjectWithSVGContext.h is its own file so that WebKit doesn't need to
know about SVGElement.h (WebKit includes JSDOMBinding.h for some reason).
I also removed context pointer from SVGZoomEvent since it was never used.
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMObjectWithSVGContext.h: Added. (WebCore::DOMObjectWithSVGContext::context): (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/scripts/CodeGeneratorJS.pm:
- 4:08 PM Changeset in webkit [46200] by
-
- 2 edits in trunk/WebCore
2009-07-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION (r46142): editing/execCommand/19087.html & editing/execCommand/19653-1.html fail in Windows build
https://bugs.webkit.org/show_bug.cgi?id=27480
Because m_anchorType : 2 is treated as a signed integer by cl.exe, anchorType() wasn't returning the correct value.
We made m_anchorType unsigned so that anchorType() returns the correct value.
- dom/Position.h: (WebCore::Position::anchorType): statically cast to AnchorType
- 3:57 PM Changeset in webkit [46199] by
-
- 3 edits in trunk/WebCore
2009-07-21 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
[V8] Add V8 bindings for onerror in WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27518
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
- 3:54 PM Changeset in webkit [46198] by
-
- 3 edits in trunk/WebCore
2009-07-21 Jian Li <jianli@chromium.org>
Fix the incorrect patch being landed for bug 27516 that has already been reviewed.
https://bugs.webkit.org/show_bug.cgi?id=27516
- workers/WorkerContext.h: (WebCore::WorkerContext::setOnerror): (WebCore::WorkerContext::onerror):
- workers/WorkerContext.idl:
- 3:44 PM Changeset in webkit [46197] by
-
- 4 edits in trunk/WebCore
2009-07-21 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Add onerror to WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27516
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark):
- workers/WorkerContext.h: (WebCore::WorkerContext::setOnerror): (WebCore::WorkerContext::onerror):
- workers/WorkerContext.idl:
- 3:42 PM Changeset in webkit [46196] by
-
- 1 edit8 adds in trunk/WebCore
2009-07-21 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27509
Add font-related files for the WinCE port.
Written by Yong Li <yong.li@torchmobile.com>
- platform/graphics/wince/FontCacheWince.cpp: Added.
- platform/graphics/wince/FontCustomPlatformData.cpp: Added.
- platform/graphics/wince/FontCustomPlatformData.h: Added.
- platform/graphics/wince/FontPlatformData.cpp: Added.
- platform/graphics/wince/FontPlatformData.h: Added.
- platform/graphics/wince/FontWince.cpp: Added.
- platform/graphics/wince/GlyphPageTreeNodeWince.cpp: Added.
- platform/graphics/wince/SimpleFontDataWince.cpp: Added.
- 2:11 PM Changeset in webkit [46195] by
-
- 2 edits in trunk/WebCore
Fix the Windows build, and update the comment on top now that wx uses WebCorePrefix.h too.
- 1:55 PM Changeset in webkit [46194] by
-
- 2 edits in trunk/WebCore
WebCorePrefix.h build fixes for non-Mac and wx / CURL builds.
- 1:52 PM Changeset in webkit [46193] by
-
- 2 edits in trunk/WebKit/wx
wx build fix. Missing header added.
- 1:45 PM Changeset in webkit [46192] by
-
- 2 edits in trunk/WebKitTools
2009-07-21 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Levin.
We can't match implementation file and primary header exactly
since we have so many files in WebKit where the port suffix
is appended to the filename.
Example: FooQt.cpp and the primary header is Foo.h.
- Scripts/modules/cpplint.py:
- 1:35 PM Changeset in webkit [46191] by
-
- 16 edits in trunk/WebCore
2009-07-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
All DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=27478
This is just moving code.
I've added two new classes: DOMObjectWithGlobalPointer and DOMConstructorWithDocument.
DOMObjectWithGlobalPointer is a new baseclass for DOMConstructorObject.
(It's a baseclass because eventually all DOMObjects will have a global pointer, but
I'll be moving them onto DOMObjectWithGlobalPointer in stages.)
DOMConstructorWithDocument is a new baseclass for the 3 constructor objects
which require a backpointer to the Document to function. I made this a subclass of
DOMConstructorObject to make clear that most constructors can hold no-such assumptions
about having a back-pointer to the Document (since many constructors can be used from Workers).
- bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
- bindings/js/JSAudioConstructor.h:
- bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::globalObject): (WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext): (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer): (WebCore::DOMObjectWithGlobalPointer::mark): (WebCore::DOMConstructorObject::DOMConstructorObject): (WebCore::DOMConstructorWithDocument::document): (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
- bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
- bindings/js/JSImageConstructor.h:
- bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
- bindings/js/JSMessageChannelConstructor.h:
- bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
- bindings/js/JSOptionConstructor.h:
- bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
- bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
- bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
- bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- bindings/js/JSXMLHttpRequestConstructor.h:
- bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
- 1:15 PM Changeset in webkit [46190] by
-
- 2 edits in branches/safari-4-branch/WebCore
Revert r46128.
- 1:06 PM Changeset in webkit [46189] by
-
- 3 edits in trunk/WebKitTools
2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by David Levin.
Add checks for switch statement indentation to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27508
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 12:43 PM Changeset in webkit [46188] by
-
- 3 edits in trunk/WebKitTools
2009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Adam Treat.
Feature request: cpplint should check for braces - rule 2
https://bugs.webkit.org/show_bug.cgi?id=27497
Add the requested feature: Make sure { is on the same line
as the foreach "keyword".
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 12:18 PM Changeset in webkit [46187] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-21 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>
Reviewed by David Levin.
Fixed #undef typo.
https://bugs.webkit.org/show_bug.cgi?id=27506
- bytecode/Opcode.h:
- 12:18 PM Changeset in webkit [46186] by
-
- 2 edits in trunk/WebCore
2009-07-21 James Hawkins <jhawkins@google.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=27453
Initialize isInt when creating a CSSParserValue for a function.
No change in behavior, so no tests.
- css/CSSFunctionValue.cpp: (WebCore::CSSFunctionValue::parserValue):
- 12:18 PM Changeset in webkit [46185] by
-
- 2 edits in trunk/WebCore
2009-07-20 Jens Alfke <snej@google.com>
Reviewed by David Levin.
Bug 27448: [Chromium] On Mac, arrow keys should cause Select to pop up its menu.
Mac build of Chromium doesn't follow Mac HI guidelines to pop up the menu when
an arrow key is pressed.
https://bugs.webkit.org/show_bug.cgi?id=27448
No new tests; affects only control response to user input.
- dom/SelectElement.cpp: Changed definition of ARROW_KEYS_POP_MENU to make it true in Mac Chromium, so it will behave compatibly with Mac HI guidelines on pop-up menus. It's not possible to have PLATFORM(MAC) be true in the Mac build of Chromium.
- 12:18 PM Changeset in webkit [46184] by
-
- 2 edits in trunk/WebCore
2009-07-21 Paul Godavari <paul@chromium.org>
Reviewed by Eric Seidel.
[Chromium] popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275
Crash reports from users indicate a crash can occur when PopupListBox::isSelectableItem
is passed an index of less than 0 (which is possible under certain circumstances). This
change prevents such a value from causing a crash by enforcing valid index values passed
by all callers of isSelectableItem. isSelectableItem is now a private method of
PopupListBox, as there are no external callers.
Also cleaned up a small amount of code for style and grammar errors.
No automatic test is provided since we cannot send events to the child window used by
the popup menu.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::selectPreviousRow):
- 12:00 PM Changeset in webkit [46183] by
-
- 2 edits in trunk/WebCore
wx build fix. Don't include winsock2.h on wx, it conflicts with wx's inclusion of winsock.
- 11:21 AM Changeset in webkit [46182] by
-
- 3 edits in trunk/WebKitTools
2009-07-20 Jakob Petsovits <jakob.petsovits@torchmobile.com>
Reviewed by David Levin.
Add checks for namespace indentation to cpplint.
https://bugs.webkit.org/show_bug.cgi?id=27461
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 11:16 AM Changeset in webkit [46181] by
-
- 3 edits in trunk/WebKitTools
2009-07-20 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Levin.
Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462
Add a new check to cpplint to flag cases where the include section of a file
does not match the mandated include order and style of the Webkit coding style
guidelines.
Add associated tests.
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 11:13 AM Changeset in webkit [46180] by
-
- 13 edits2 deletes in trunk
These changes were causing build failures and assertion failures on
Windows.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSArray.cpp:
- runtime/StringPrototype.cpp:
- runtime/UString.cpp:
- runtime/UString.h:
- wtf/FastMalloc.cpp:
- wtf/FastMalloc.h:
- wtf/Platform.h:
- wtf/PossiblyNull.h: Removed.
WebCore:
- ForwardingHeaders/wtf/PossiblyNull.h: Removed.
- platform/graphics/cg/ImageBufferCG.cpp:
- 10:34 AM Changeset in webkit [46179] by
-
- 12 edits3 adds in trunk/WebCore
2009-07-21 Jian Li <jianli@chromium.org>
Reviewed by Eric Seidel.
Implement ErrorEvent API.
https://bugs.webkit.org/show_bug.cgi?id=27387
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- dom/ErrorEvent.cpp: Added.
- dom/ErrorEvent.h: Added.
- dom/ErrorEvent.idl: Added.
- dom/Event.cpp: (WebCore::Event::isErrorEvent):
- dom/Event.h:
- 10:14 AM Changeset in webkit [46178] by
-
- 2 edits in trunk/WebCore
2009-07-21 Priit Laes <plaes@plaes.org>
Reviewed by Gustavo Noronha.
[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word
https://bugs.webkit.org/show_bug.cgi?id=24602
Remove workaround required for <=libsoup-2.26.1
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
- 10:09 AM Changeset in webkit [46177] by
-
- 2 edits in trunk/WebCore
2009-07-21 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397
Make a copy of the context handle before making it weak. We don't want
to make the original handle weak because we want it to survive for the
length of the V8IsolatedWorld::evaluate method.
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
- 9:50 AM Changeset in webkit [46176] by
-
- 2 edits in trunk/WebCore
2009-07-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add ability to evaluate selection while on break point.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceFrame.prototype._documentKeyDown):
- 9:42 AM Changeset in webkit [46175] by
-
- 2 edits in trunk/WebCore
2009-07-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Special case ConsolePanel opening since
it is a 'fast view'.
- inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
- 8:13 AM Changeset in webkit [46174] by
-
- 3 edits in trunk/WebKit/wx
wx build fix. Adding isSpeaking() to ContextMenuClientWx.
- 6:40 AM Changeset in webkit [46173] by
-
- 5 edits in trunk/WebKit/qt
2009-07-21 Volker Hilsheimer <volker.hilsheimer@nokia.com>
Reviewed by Simon Hausmann.
Various improvements to the API documentation.
- Updated link to W3c Database spec
- Formatting fixes, cleanups
- Add missing \since 4.6 tags to QWebPage::frameAt
- Extend QWebDatabase and QWebSecurityOrigin docs.
- Api/qwebdatabase.cpp:
- Api/qwebpage.cpp:
- Api/qwebsecurityorigin.cpp:
- Api/qwebview.cpp:
- 6:10 AM Changeset in webkit [46172] by
-
- 2 edits in trunk/WebKit/qt
2009-07-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Remove preliminary-tag from QWebElement
- Api/qwebelement.cpp:
- 5:42 AM Changeset in webkit [46171] by
-
- 2 edits in trunk/LayoutTests
2009-07-21 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Skip fast/loader/non-html-load-event.html for the Qt DRT as it requires
support for loading PDF documents.
- platform/qt/Skipped:
- 5:02 AM Changeset in webkit [46170] by
-
- 66 edits in trunk
WebCore:
2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Eric Seidel.
Fix Qt code to follow the WebKit Coding Style.
- platform/graphics/qt/FontQt.cpp: (WebCore::qstring): (WebCore::fixSpacing):
- platform/graphics/qt/FontQt43.cpp: (WebCore::generateComponents): (WebCore::Font::offsetForPositionForComplexText): (WebCore::cursorToX):
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtFillRule): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getWindowsContext):
- platform/graphics/qt/IconQt.cpp: (WebCore::Icon::paint):
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::ReadContext::read): (WebCore::ImageDecoderQt::ReadContext::readImageLines): (WebCore::ImageDecoderQt::setData):
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
- platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameDurationAtIndex): (WebCore::ImageSource::frameHasAlphaAtIndex): (WebCore::ImageSource::frameIsCompleteAtIndex):
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::create): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::updateStates):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo): (WebCore::Path::isEmpty):
- platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::TransformationMatrix::operator QTransform):
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::setDragImage): (WebCore::getCachedImage): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
- platform/qt/ClipboardQt.h:
- platform/qt/ContextMenuItemQt.cpp: (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title):
- platform/qt/CursorQt.cpp: (WebCore::westPanningCursor): (WebCore::notAllowedCursor):
- platform/qt/DragDataQt.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::asPlainText): (WebCore::DragData::asFragment):
- platform/qt/DragImageQt.cpp: (WebCore::createDragImageIconForCachedImage):
- platform/qt/FileSystemQt.cpp: (WebCore::getFileSize): (WebCore::unloadModule):
- platform/qt/Localizations.cpp: (WebCore::contextMenuItemTagShowSpellingPanel):
- platform/qt/MIMETypeRegistryQt.cpp: (WebCore::):
- platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::plainText):
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- platform/qt/PlatformMouseEventQt.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::fallbackStyle): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::applyTheme): (WebCore::WorldMatrixTransformer::WorldMatrixTransformer): (WebCore::RenderThemeQt::paintMediaBackground): (WebCore::RenderThemeQt::paintMediaFullscreenButton):
- platform/qt/RenderThemeQt.h:
- platform/qt/ScreenQt.cpp: (WebCore::screenRect): (WebCore::usableScreenRect):
- platform/qt/ScrollbarQt.cpp: (WebCore::Scrollbar::contextMenu):
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::scPart): (WebCore::scrollbarPart):
- platform/qt/ScrollbarThemeQt.h:
- platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
- platform/qt/TemporaryLinkStubs.cpp: (PluginDatabase::defaultPluginDirectories): (PluginDatabase::getPluginPathsInDirectories): (PluginDatabase::isPreferredPluginDirectory): (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): (WebCore::userIdleTime): (WebCore::prefetchDNS):
- platform/text/qt/StringQt.cpp: (WebCore::String::String):
- platform/text/qt/TextBoundaries.cpp:
- platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::TextBreakIterator::following): (WebCore::TextBreakIterator::preceding): (WebCore::WordBreakIteratorQt::first): (WebCore::WordBreakIteratorQt::next): (WebCore::WordBreakIteratorQt::previous): (WebCore::CharBreakIteratorQt::first): (WebCore::CharBreakIteratorQt::next): (WebCore::CharBreakIteratorQt::previous): (WebCore::characterBreakIterator):
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::userAgentStatic): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::init):
WebKit/qt:
2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Eric Seidel.
Fix Qt code to follow the WebKit Coding Style.
- Api/qcookiejar.cpp: (QCookieJar::setCookieJar): (QCookieJar::cookieJar):
- Api/qcookiejar.h:
- Api/qwebdatabase.cpp: (QWebDatabase::QWebDatabase): (QWebDatabase::removeDatabase):
- Api/qwebdatabase.h:
- Api/qwebdatabase_p.h:
- Api/qwebelement.h:
- Api/qwebframe.cpp: (QWebFrame::title): (QWebFrame::print):
- Api/qwebframe.h:
- Api/qwebframe_p.h:
- Api/qwebhistory.cpp: (QWebHistory::clear):
- Api/qwebhistory.h:
- Api/qwebhistory_p.h:
- Api/qwebhistoryinterface.cpp: (gCleanupInterface): (QWebHistoryInterface::setDefaultInterface): (QWebHistoryInterface::defaultInterface): (QWebHistoryInterface::QWebHistoryInterface):
- Api/qwebhistoryinterface.h:
- Api/qwebnetworkinterface.cpp: (QWebNetworkManager::started): (QWebNetworkManager::finished): (QWebNetworkInterfacePrivate::parseDataUrl): (QWebNetworkInterface::addJob): (WebCoreHttp::onResponseHeaderReceived): (WebCoreHttp::onReadyRead):
- Api/qwebnetworkinterface.h:
- Api/qwebnetworkinterface_p.h:
- Api/qwebpage.cpp: (QWebPagePrivate::editorCommandForWebActions): (QWebPagePrivate::createContextMenu): (QWebPagePrivate::focusInEvent): (QWebPage::fixedContentsSize): (QWebPage::setContentEditable): (QWebPage::swallowContextMenuEvent): (QWebPage::findText):
- Api/qwebpage.h:
- Api/qwebpage_p.h:
- Api/qwebpluginfactory.h:
- Api/qwebsecurityorigin.h:
- Api/qwebsecurityorigin_p.h:
- Api/qwebsettings.cpp: (QWebSettingsPrivate::QWebSettingsPrivate): (QWebSettingsPrivate::apply): (QWebSettings::globalSettings): (QWebSettings::QWebSettings): (QWebSettings::fontSize): (QWebSettings::setUserStyleSheetUrl): (QWebSettings::setDefaultTextEncoding): (QWebSettings::setIconDatabasePath): (QWebSettings::iconDatabasePath): (QWebSettings::iconForUrl): (QWebSettings::setWebGraphic): (QWebSettings::setFontFamily): (QWebSettings::fontFamily): (QWebSettings::testAttribute): (qt_websettings_setLocalStorageDatabasePath):
- Api/qwebsettings.h:
- Api/qwebview.cpp: (QWebView::setPage): (QWebView::event):
- Api/qwebview.h:
- 4:05 AM Changeset in webkit [46169] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-21 Priit Laes <plaes@plaes.org>
Reviewed by Holger Freyther.
[GTK+] Missing accelerator in authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=25509
Add accelerator to checkbox text.
- WebKit/gtk/webkit/webkitsoupauthdialog.c: (show_auth_dialog):
- 3:51 AM Changeset in webkit [46168] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-21 Priit Laes <plaes@plaes.org>
Reviewed by Holger Freyther.
[GTK] http auth dialog pops up twice after a cancelled atempt
https://bugs.webkit.org/show_bug.cgi?id=24818
Remove workaround required for libsoup versions <=2.26.2 as we depend
on 2.27.4 now.
- webkit/webkitsoupauthdialog.c: (session_authenticate):
- 3:41 AM Changeset in webkit [46167] by
-
- 1 edit4 adds in trunk/WebCore
2009-07-21 Maxime Simon <Maxime Simon>
Reviewed by David Levin.
Added a first bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26988
- platform/haiku/ClipboardHaiku.cpp: Added. (WebCore::ClipboardHaiku::ClipboardHaiku): (WebCore::ClipboardHaiku::clearData): (WebCore::ClipboardHaiku::clearAllData): (WebCore::ClipboardHaiku::getData): (WebCore::ClipboardHaiku::setData): (WebCore::ClipboardHaiku::types): (WebCore::ClipboardHaiku::files): (WebCore::ClipboardHaiku::dragLocation): (WebCore::ClipboardHaiku::dragImage): (WebCore::ClipboardHaiku::setDragImage): (WebCore::ClipboardHaiku::dragImageElement): (WebCore::ClipboardHaiku::setDragImageElement): (WebCore::ClipboardHaiku::createDragImage): (WebCore::ClipboardHaiku::declareAndWriteDragImage): (WebCore::ClipboardHaiku::writeURL): (WebCore::ClipboardHaiku::writeRange): (WebCore::ClipboardHaiku::hasData):
- platform/haiku/ClipboardHaiku.h: Added. (WebCore::ClipboardHaiku::create): (WebCore::ClipboardHaiku::~ClipboardHaiku):
- platform/haiku/CookieJarHaiku.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- platform/haiku/CursorHaiku.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::pointerCursor): (WebCore::moveCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
- 3:35 AM Changeset in webkit [46166] by
-
- 2 edits1 add in trunk/WebKitTools
2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291
Add run-webkit-lint script, which lints recent changes in local
repository. Also, modified cpplint.py so that we don't need to
specify verbose level for process_file().
- Scripts/modules/cpplint.py:
- Scripts/run-webkit-lint: Added.
- 3:12 AM Changeset in webkit [46165] by
-
- 2 edits in trunk/WebCore
2009-07-21 Albert Astals Cid <aacid@kde.org>
Reviewed by Tor Arne Vestbø.
Change #error line not to have a ' (single quote)
- DerivedSources.cpp:
- 3:12 AM Changeset in webkit [46164] by
-
- 3 edits in trunk/WebKitTools
2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
diff_parser should accept lines without trailing \n
https://bugs.webkit.org/show_bug.cgi?id=27483
Normalize the input lines by removing a trailing newline.
Also, add a case for unittest for newly added files.
- Scripts/modules/diff_parser.py:
- Scripts/modules/diff_parser_unittest.py:
- 3:12 AM Changeset in webkit [46163] by
-
- 2 edits in trunk/WebKitTools
2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
cpplint.py's process_file() should accept customized error function
https://bugs.webkit.org/show_bug.cgi?id=27487
- Scripts/modules/cpplint.py:
- 2:53 AM Changeset in webkit [46162] by
-
- 3 edits in trunk/WebKitTools
2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
cpplint.py should have an interface to get global error count
https://bugs.webkit.org/show_bug.cgi?id=27486
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 2:53 AM Changeset in webkit [46161] by
-
- 3 edits in trunk/WebKitTools
2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
cpplint's parse_argument should not exit even if no files are specified
https://bugs.webkit.org/show_bug.cgi?id=27489
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 2:53 AM Changeset in webkit [46160] by
-
- 2 edits in trunk/WebKitTools
2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
diff_parser: s/add_deleted_line/add_old_line/g
https://bugs.webkit.org/show_bug.cgi?id=27484
- Scripts/modules/diff_parser.py:
- 2:53 AM Changeset in webkit [46159] by
-
- 17 edits in trunk
.:
2009-07-21 Roland Steiner <rolandsteiner@google.com>
Reviewed by David Levin.
Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324
- configure.ac: Added flag ENABLE_RUBY.
2009-07-21 Roland Steiner <rolandsteiner@google.com>
Reviewed by David Levin.
Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324
- Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.
WebCore:
2009-07-21 Roland Steiner <rolandsteiner@google.com>
Reviewed by David Levin.
Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324
Added flag ENABLE_RUBY:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/build-generated-files.sh:
WebKit/mac:
2009-07-21 Roland Steiner <rolandsteiner@google.com>
Reviewed by David Levin.
Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324
- Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.
WebKit/win:
2009-07-21 Roland Steiner <rolandsteiner@google.com>
Reviewed by David Levin.
Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324
- WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY.
WebKitTools:
2009-07-21 Roland Steiner <rolandsteiner@google.com>
Reviewed by David Levin.
Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324
- Scripts/build-webkit: Added flag ENABLE_RUBY.
- 2:53 AM Changeset in webkit [46158] by
-
- 2 edits in trunk/WebCore
2009-07-21 James Hawkins <jhawkins@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=27467
Return an empty path in PlatformContextSkia::currentPathInLocalCoordinates
if matrix.invert() fails. This prevents the use of an uninitialized
value in inverseMatrix.
No new tests added. Run
LayoutTests/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
under valgrind and notice there are no errors.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::currentPathInLocalCoordinates):
- 2:53 AM Changeset in webkit [46157] by
-
- 3 edits in trunk/WebCore
2009-07-21 Stephen White <senorblanco@chromium.org>
Reviewed by Eric Seidel.
Fix dotted and dashed borders on Chromium/skia. This follows
the logic in the Cg path, so results are much closer to Safari now
(some tests won't be exactly the same due to font layout differences).
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLine):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
Jul 20, 2009:
- 11:41 PM Changeset in webkit [46156] by
-
- 2 edits in trunk/WebKitTools
Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>.
Bug 27482: svn-apply cannot apply patch generated by Windows SVN
Reviewed by David D. Kilzer.
A regexp in svn-apply was treating everything prior to a \n as part of the
file name. The native Windows SVN client uses \r\n for line endings which
meant that the \r was being included in the file name. This defeated the
special-case logic for ChangeLogs to apply them with an increased fuzz factor,
meaning that the ChangeLog portions of such patches would fail to apply.
Also updated two other regexps that look like they would hit similar problems
with line-endings so that they will correctly handle patches from Windows SVN.
- Scripts/svn-apply:
- 9:35 PM Changeset in webkit [46155] by
-
- 3 edits in trunk/JavaScriptCore
Build fix attempt #2
- 9:22 PM Changeset in webkit [46154] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix attempt #1
- 9:02 PM Changeset in webkit [46153] by
-
- 11 edits2 adds in trunk
Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469
Reviewed Gavin Barraclough
Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.
- 8:33 PM Changeset in webkit [46152] by
-
- 2 edits3 adds in trunk/WebKit/qt
[Qt] Add test for loading webpages...
Performance test for loading webpages...
- 8:32 PM Changeset in webkit [46151] by
-
- 2 edits4 adds in trunk/WebKit/qt
[Qt] Add a test case for drawing a simple viewrect to a QPixmap
- 8:30 PM Changeset in webkit [46150] by
-
- 3 edits3 adds in trunk
2009-07-20 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Guard access to installedMediaEngines()[0].
https://bugs.webkit.org/show_bug.cgi?id=27479
http://code.google.com/p/chromium/issues/detail?id=16541
Else where in the file, installedMediaEngines is always checked for
being empty because access. This patch adds a case which missed that
check.
This triggered a crash in Chromium:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load):
- 8:27 PM Changeset in webkit [46149] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Gavin Barraclough <barraclough@apple.com>
RS Oliver Hunt.
Add ARM assembler files to xcodeproj, for convenience editing.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 8:06 PM Changeset in webkit [46148] by
-
- 2 edits in trunk/WebCore
2009-07-20 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Allow search entries to render with a CSS border if the RenderTheme
doesn't paint them.
https://bugs.webkit.org/show_bug.cgi?id=27466
http://code.google.com/p/chromium/issues/detail?id=16958
<input type="search"> is very much like a text entry except that,
currently, if the RenderTheme doesn't deal with it, nothing is
rendered. With this patch, the default CSS border is rendered if the
RenderTheme requests it.
This will affect many layout tests, but only for Chromium Linux and
those results are not currently in the WebKit tree.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintBorderOnly):
- 7:58 PM Changeset in webkit [46147] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Jessie Berlin <jberlin@apple.com>
Fix an incorrect assertion in Vector::remove.
Reviewed by David Levin.
- wtf/Vector.h: (WTF::::remove): Assert that the position at which to start removing elements + the length (the number of elements to remove) is less than or equal to the size of the entire Vector.
- 7:54 PM Changeset in webkit [46146] by
-
- 2 edits in trunk/LayoutTests
Correct expected results from r46136, which accidentally included the
DumpRenderTree header and trailer
- fast/loader/non-html-load-event-expected.txt:
- 7:19 PM Changeset in webkit [46145] by
-
- 14 edits in trunk/WebCore
2009-07-17 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Switch to faster methods to access internal fields.
https://bugs.webkit.org/show_bug.cgi?id=27372
Minor refactoring.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::setDOMWrapper):
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::removeElement):
- bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 7:15 PM Changeset in webkit [46144] by
-
- 4 edits1 add in trunk/WebCore
2009-07-20 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium Linux: cache Harfbuzz faces.
Previously, we recreated the Harfbuzz face for each script-run. With
this patch, we keep the Harfbuzz face in the FontPlatformData (created
as needed) and so they will persist for the duration of the
FontPlatformData.
Shouldn't affect any layout tests. Results in a significant win on the
intl2 page cycler time.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::setupFontForScriptRun):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::RefCountedHarfbuzzFace::~RefCountedHarfbuzzFace): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::harfbuzzFace):
- platform/graphics/chromium/FontPlatformDataLinux.h: (WebCore::FontPlatformData::RefCountedHarfbuzzFace::create): (WebCore::FontPlatformData::RefCountedHarfbuzzFace::face): (WebCore::FontPlatformData::RefCountedHarfbuzzFace::RefCountedHarfbuzzFace):
- platform/graphics/chromium/HarfbuzzSkia.h: Added.
- 6:31 PM Changeset in webkit [46143] by
-
- 2 edits in trunk/WebCore
2009-07-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Simon Fraser.
REGRESSION (r46142): Need to remove showTreeThisForThis
https://bugs.webkit.org/show_bug.cgi?id=27475
Removes showTreeThisForThis
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::appendParagraphIntoNode):
- 5:55 PM Changeset in webkit [46142] by
-
- 16 edits8 adds in trunk
WebCore:
2009-07-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Refactoring of indentRegion to fix bugs 26816 and 25317
https://bugs.webkit.org/show_bug.cgi?id=26816
https://bugs.webkit.org/show_bug.cgi?id=25317
https://bugs.webkit.org/show_bug.cgi?id=23995 (partially)
This patch implements appendParagraphIntoNode, a simpler specialized version of moveParagraph
and replaces all calls inside indentRegion. The following is the new behavior of indentRegion.
- We try to indent as many wrapping nodes as possible. e.g. when indenting "hello" in <div>hello</div>, we try to indent div as well.
- We do not delete any wrapping elements With moveParagraph, we used to remove all wrapping nodes, and replaced with a blockquote. This was causing https://bugs.webkit.org/show_bug.cgi?id=23995 for indentation. With appendParagraphIntoNode, we can preserve all wrapping nodes.
- We only split the tree until the closest block node instead of until the root editable node. This behavioral change fixes the bug 25317.
- When multiple paragraphs are indented, we indent the highest common ancestor within the selection. e.g. when a list is a child node of a div, and the entire div is intended,
we enclose the div by a single blockquote.
Note that new behavior is more consistent with that of Internet Explorer and Firefox.
To demonstrate this, the following tests are added.
Tests: editing/execCommand/indent-div-inside-list.html
editing/execCommand/indent-nested-blockquotes.html
editing/execCommand/indent-nested-div.html
editing/execCommand/indent-second-paragraph-in-blockquote.html
- editing/IndentOutdentCommand.cpp: prepareBlockquoteLevelForInsertion is removed (WebCore::IndentOutdentCommand::tryIndentingAsListItem): uses appendParagraphIntoNode now (WebCore::IndentOutdentCommand::indentIntoBlockquote): uses appendParagraphIntoNode now (WebCore::IndentOutdentCommand::appendParagraphIntoNode): removes a paragraph and appends it to a new node (WebCore::IndentOutdentCommand::removeUnnecessaryLineBreakAt): removes a break element at the specified position (WebCore::IndentOutdentCommand::indentRegion): exhibits the described behavior
- editing/IndentOutdentCommand.h: updated prototype
- editing/execCommand/19653-1-expected.txt: rebaselined (no longer removes wrapping div)
- editing/execCommand/indent-div-inside-list-expected.txt: Added.
- editing/execCommand/indent-div-inside-list.html: Added.
- editing/execCommand/indent-nested-blockquotes-expected.txt: Added.
- editing/execCommand/indent-nested-blockquotes.html: Added.
- editing/execCommand/indent-nested-div-expected.txt: Added.
- editing/execCommand/indent-nested-div.html: Added.
- editing/execCommand/indent-nested-lists-2-expected.txt: rebaselined (selection corrected)
- editing/execCommand/indent-nested-lists-3-expected.txt: rebaselined (selection corrected)
- editing/execCommand/indent-nested-lists-4-expected.txt: rebaselined (selection corrected)
- editing/execCommand/indent-nested-lists-5-expected.txt: rebaselined (selection corrected)
- editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Added.
- editing/execCommand/indent-second-paragraph-in-blockquote.html: Added.
- platform/mac/editing/execCommand/4641880-2-expected.txt: rebaselined
- platform/mac/editing/execCommand/4916541-expected.txt: rebaselined (no longer removes wrapping span)
- platform/mac/editing/execCommand/5138441-expected.txt: rebaselined
- platform/mac/editing/execCommand/5481523-expected.txt: rebaselined
- platform/mac/editing/execCommand/indent-selection-expected.txt: rebaselined
- 4:59 PM Changeset in webkit [46141] by
-
- 2 edits in trunk/WebCore
Try to fix release builds after r46136
- dom/Element.cpp:
- 4:59 PM Changeset in webkit [46140] by
-
- 6 edits2 deletes in trunk
WebCore:
2009-07-17 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380
Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.
- css/mediaControlsQT.css:
LayoutTests:
2009-07-17 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380
Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.checksum: Removed.
- platform/mac/media/controls-styling-expected.png: Removed.
- platform/mac/media/controls-styling-expected.txt:
- platform/mac/media/video-zoom-controls-expected.txt:
- 4:56 PM Changeset in webkit [46139] by
-
- 19 edits in trunk
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
WebCore:
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/WebCoreGenerated.vcproj:
WebKit/win:
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/InterfacesGenerated.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
WebKitTools:
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- 4:35 PM Changeset in webkit [46138] by
-
- 3 edits in trunk/LayoutTests
2009-07-20 Eric Seidel <eric@webkit.org>
Reviewed by Sam Weinig.
Fix failures seen on the bots
https://bugs.webkit.org/show_bug.cgi?id=27463
Ignore more global variables added by DumpRenderTree.
Some platforms don't add all of the DRT controllers,
thus causing this test to fail for those platforms.
Also fix !value to value === null to handle not
skip the cases where value == 0.
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/resources/prototype-inheritance.js:
- 4:15 PM Changeset in webkit [46137] by
-
- 1 edit in trunk/LayoutTests/transitions/extra-transition.html
Fixed a transition LayoutTest which fails on slower machines
- 4:08 PM Changeset in webkit [46136] by
-
- 11 edits4 adds in trunk
WebCore:
Reviewed by Anders Carlsson.
When loading a custom view into a frame, the old document is still
around
<rdar://problem/5145841>
Safari fires onload before PDF is loaded into the browser
<rdar://problem/6618869>
Test: fast/loader/non-html-load-event.html
- GNUmakefile.am: Added PlaceholderDocument.{cpp,h}
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- WebCoreSources.bkl: Ditto.
- dom/Document.h: (WebCore::Document::setStyleSelector): Added this protected accessor for
PlaceholderDocument to use.
- dom/Element.cpp: (WebCore::Element::clientWidth): Check whether the document has a
renderer.
(WebCore::Element::clientHeight): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a PlaceholderDocument for frames
that do not use an HTML view. Do not nullify the content size in
that case.
(WebCore::FrameLoader::transitionToCommitted): For frames that do not
use an HTML view, call receivedFirstData(), which sets up the
frame with a new PlaceHolderDocument.
- loader/PlaceholderDocument.cpp: Added. (WebCore::PlaceholderDocument::attach): Sets up the style selector but
does not create a RenderView.
- loader/PlaceholderDocument.h: Added. (WebCore::PlaceholderDocument::create): (WebCore::PlaceholderDocument::PlaceholderDocument):
LayoutTests:
Reviewed by Anders Carlsson.
Safari fires onload before PDF is loaded into the browser
<rdar://problem/6618869>
- fast/loader/non-html-load-event-expected.txt: Added.
- fast/loader/non-html-load-event.html: Added.
- 3:45 PM Changeset in webkit [46135] by
-
- 5 edits in trunk/WebCore
Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398
This makes two changes, and only for Leopard.
First, whenever opacity is changed on a layer I propagate the
change into the content layer and all the children if the layer
on which opacity is set is a transform layer (preserve3D is true).
The opacity set is the accumulated opacity from this layer
and all its direct ancestor transform layers. Second, I turn off all
hardware opacity animation.
- 3:16 PM Changeset in webkit [46134] by
-
- 2 edits in trunk/WebKitTools
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27323
Use shorter, more correct code for determining the current directory,
which works better with symbolic links on some systems. Also switch
from checking repository root to checking UUID, to match scm.py.
- Scripts/svn-create-patch:
- 2:46 PM Changeset in webkit [46133] by
-
- 2 edits in trunk/WebKitTools
Work around <rdar://problem/7075373> by ensuring that the URL is absolute before handing it off to CoreText.
Rubber-stamped by Dan Bernstein.
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFonts):
- 2:38 PM Changeset in webkit [46132] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-07-20 Geoffrey Garen <ggaren@apple.com>
Fixed a post-review typo in r46066 that caused tons of test failures.
SunSpider reports no change.
- runtime/JSArray.cpp: (JSC::JSArray::JSArray): Initialize the full vector capacity, to avoid uninitialized members at the end.
- 1:55 PM Changeset in webkit [46131] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-07-20 Geoffrey Garen <ggaren@apple.com>
Windows WebKit build fix: Added some missing exports.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 1:41 PM Changeset in webkit [46130] by
-
- 2 edits in trunk/WebKitTools
2009-07-20 David Levin <levin@chromium.org>
Reviewed by Adam Treat.
Enable filename completion for run-webkit-test (added "-o default").
- Scripts/webkit-tools-completion.sh:
- 1:08 PM Changeset in webkit [46129] by
-
- 1 edit2 adds in trunk/WebCore
2009-07-20 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=27349
Add GraphicsContext implementation for the WinCE port.
Written by Yong Li <yong.li@torchmobile.com> and George Staikos <george.staikos@torchmobile.com>
with trivial style fixes by Adam Treat <adam.treat@torchmobile.com>
- platform/graphics/wince/GraphicsContextWince.cpp: Added.
- 1:06 PM Changeset in webkit [46128] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r46058.
- 12:37 PM Changeset in webkit [46127] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r46039.
- 10:56 AM Changeset in webkit [46126] by
-
- 3 edits4 adds in trunk/WebCore
2009-07-20 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Adding the Win SQLite VFS implementation for Chromium, and stubs
for the Mac and Linux VFSs.
- WebCore.gypi:
- platform/chromium/ChromiumBridge.h:
- platform/sql/chromium/SQLiteFileSystemChromium.cpp: Added.
- platform/sql/chromium/SQLiteFileSystemChromiumLinux.cpp: Added.
- platform/sql/chromium/SQLiteFileSystemChromiumMac.cpp: Added.
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Added.
- 6:47 AM Changeset in webkit [46125] by
-
- 2 edits in trunk/WebCore
2009-07-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=27097
[Gtk] Segfault when examining an object of ROLE_TABLE via at-spi
Check that an object is a RenderObject before trying to access its
renderer and related node.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 6:36 AM Changeset in webkit [46124] by
-
- 5 edits in trunk/WebCore
2009-07-20 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265
Reimplemented Qt's FontCache in a way that follows the shared one.
Now we can release its elements when those became inactive.
FontFallbackList had been changed to be able to hold WebCore fonts in its list and to be able to release a FontData what is in the cache.
No change in behavior, so no tests.
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue): (WebCore::FontPlatformDataCacheKey::): Key type for the cache of FontPlatformData objects. It can be constructed from a FontPlatformData or from a FontDescription. The keys have to be consistent with FontPlatformData::FontPlatformData(const FontDescription&) - if we create the same FontPlatformData from two FontDescription then we have to create the same key from them, and vica versa. (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::FontPlatformDataCacheKey::hash): (WebCore::FontPlatformDataCacheKey::computeHash): (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize): (WebCore::FontPlatformDataCacheKeyHash::hash): (WebCore::FontPlatformDataCacheKeyHash::equal): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue): (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue): (WebCore::FontCache::getCachedFontPlatformData): Get a FontDescription and returns a FontPlatformData. (WebCore::FontCache::getCachedFontData): Get a FontPlatformData and returns a SimpleFontData. (WebCore::FontCache::releaseFontData): Get a SimpleFontData and releases it from the cache. Also releases the appropriate FontPlatformData. (WebCore::FontCache::purgeInactiveFontData): Frees inactive elements. (WebCore::FontCache::invalidate): Frees all inactive elements (call purgeInactiveFontData with default argument)
- platform/graphics/qt/FontFallbackListQt.cpp: (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt):
- platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::family): Getter. It is needed for FontPlatformDataCacheKey. (WebCore::FontPlatformData::bold): Ditto. (WebCore::FontPlatformData::italic): Ditto. (WebCore::FontPlatformData::smallCaps): Ditto. (WebCore::FontPlatformData::pixelSize): Ditto.
- platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): Set m_bold.
- 4:01 AM Changeset in webkit [46123] by
-
- 3 edits in trunk/WebKit/gtk
2009-07-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
[GTK] Widget size negotiation
https://bugs.webkit.org/show_bug.cgi?id=17154
Implement proper size request for the WebView widget.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::contentsSizeChanged):
- webkit/webkitwebview.cpp: (webkit_web_view_size_request): (webkit_web_view_class_init):
- 3:09 AM Changeset in webkit [46122] by
-
- 2 edits in trunk/WebKitTools
2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
No review, just adding Gavin Barraclough as reviewer.
- Scripts/modules/bugzilla.py:
- 3:04 AM Changeset in webkit [46121] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Allow custom memory allocation control in NewThreadContext
https://bugs.webkit.org/show_bug.cgi?id=27338
Inherits NewThreadContext struct from FastAllocBase because it
has been instantiated by 'new' JavaScriptCore/wtf/Threading.cpp:76.
- wtf/Threading.cpp:
- 3:04 AM Changeset in webkit [46120] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Allow custom memory allocation control in JavaScriptCore's JSClassRef.h
https://bugs.webkit.org/show_bug.cgi?id=27340
Inherit StaticValueEntry and StaticFunctionEntry struct from FastAllocBase because these
have been instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:153
and in JavaScriptCore/API/JSClassRef.cpp:166.
- API/JSClassRef.h:
- 3:03 AM Changeset in webkit [46119] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control in JavaScriptCore's RegexPattern.h
https://bugs.webkit.org/show_bug.cgi?id=27343
Inherits RegexPattern.h's structs (which have been instantiated by operator new) from FastAllocBase:
CharacterClass (new call: JavaScriptCore/yarr/RegexCompiler.cpp:144)
PatternAlternative (new call: JavaScriptCore/yarr/RegexPattern.h:221)
PatternDisjunction (new call: JavaScriptCore/yarr/RegexCompiler.cpp:446)
- yarr/RegexPattern.h:
- 3:03 AM Changeset in webkit [46118] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's MatchFrame struct
https://bugs.webkit.org/show_bug.cgi?id=27344
Inherits MatchFrame struct from FastAllocBase because it has
been instantiated by 'new' JavaScriptCore/pcre/pcre_exec.cpp:359.
- pcre/pcre_exec.cpp:
- 3:02 AM Changeset in webkit [46117] by
-
- 2 edits in trunk/WebCore
2009-07-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=26716
[Gtk] Each XMLHttpRequest leaks memory.
Free the SoupURI we create to check the URI. Fix suggested by John
Kjellberg.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
- 2:52 AM Changeset in webkit [46116] by
-
- 4 edits in trunk
.:
2009-07-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] Add an option for QtLauncher to build without QtUiTools dependency
https://bugs.webkit.org/show_bug.cgi?id=27438
Based on Norbert Leser's work.
- WebKit.pri: Symbian does not have UiTools
WebKit/qt:
2009-07-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] Add an option for QtLauncher to build without QtUiTools dependency
https://bugs.webkit.org/show_bug.cgi?id=27438
Based on Norbert Leser's work.
- QtLauncher/main.cpp: (WebPage::createPlugin):
- 2:50 AM Changeset in webkit [46115] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
Remove some outdated S60 platform specific code
https://bugs.webkit.org/show_bug.cgi?id=27423
- wtf/Platform.h:
- 2:49 AM Changeset in webkit [46114] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
Qt build fix with MSVC and MinGW.
- jsc.pro: Make sure jsc is a console application, and turn off exceptions and stl support to fix the build.
- 2:46 AM Changeset in webkit [46113] by
-
- 3 edits in trunk/WebKitTools
2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by David Levin.
Add support for Qt's foreach to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27386
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 2:41 AM Changeset in webkit [46112] by
-
- 2 edits in trunk/WebCore
2009-07-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] On Symbian link against system sqlite3
https://bugs.webkit.org/show_bug.cgi?id=27368
Add an option to force linking against system sqlite3
by adding system-sqlite to the CONFIG variable.
The Symbian specific part of this patch is contributed by
Norbert Leser.
- WebCore.pro:
- 2:32 AM Changeset in webkit [46111] by
-
- 3 edits in trunk/WebCore
2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by and done with Tor Arne Vestbø.
Fix fast/css/pseudo-required-optional-*.html in the Qt build
after r46062.
These tests triggered a bug in RenderThemeQt where we did not fall back
to the unstyled painting of text areas and input fields when they have
a styled background.
Our re-implementation of isControlStyled incorrectly only checked the
border for determining whether to style or not. The base-implementation
performs the same check, but also includes the background. Removing
our implementation fixes the appearance.
- platform/qt/RenderThemeQt.cpp: Removed isControlStyled reimplementation.
- platform/qt/RenderThemeQt.h: Ditto.
- 1:31 AM Changeset in webkit [46110] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not use C++-style comments in preprocessor directives.
GCC does not like this in some configurations, using C-style
comments is safer.
- wtf/Platform.h:
- 1:31 AM Changeset in webkit [46109] by
-
- 2 edits in trunk/WebCore
2009-07-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Change the glib version check to check for the first unstable
release with g_mapped_file_unref. Otherwise this would be useless
until 2.22 is released, a few months from now.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
- 12:51 AM Changeset in webkit [46108] by
-
- 2 edits in trunk/WebCore
2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Add missing (sorted) header files to the HEADERS variable in the qmake
.pro file for improved completion in IDEs.
- WebCore.pro:
- 12:24 AM Changeset in webkit [46107] by
-
- 2 edits in trunk/LayoutTests
2009-07-19 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Xan Lopez.
Skip new fast/dom/prototype-inheritance.html test in the Qt DRT
due to missing features/properties in the window object.
- platform/qt/Skipped:
Jul 19, 2009:
- 8:56 PM Changeset in webkit [46106] by
-
- 3 edits2 adds in trunk/WebCore
2009-07-19 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421
No behavior change.
- WebCore.gypi:
- bindings/v8/V8ConsoleMessage.cpp: Added. (WebCore::V8ConsoleMessage::V8ConsoleMessage): (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::dispatchLater): (WebCore::V8ConsoleMessage::processDelayed): (WebCore::V8ConsoleMessage::handler):
- bindings/v8/V8ConsoleMessage.h: Added. (WebCore::V8ConsoleMessage::Scope::Scope): (WebCore::V8ConsoleMessage::Scope::~Scope):
- bindings/v8/V8Proxy.cpp: (WebCore::logInfo): (WebCore::reportUnsafeAccessTo): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::processConsoleMessages):
- 11:50 AM Changeset in webkit [46105] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Barth.
Remove unused member variable.
- svg/SVGPolyElement.h:
- 11:16 AM Changeset in webkit [46104] by
-
- 3 edits2 adds in trunk
2009-07-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
HTMLAudioElement: constructor should set "autobuffer" attribute
https://bugs.webkit.org/show_bug.cgi?id=27422
Test: media/audio-constructor-autobuffer.html
- bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
Set 'autobuffer' attribute.
2009-07-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
HTMLAudioElement: constructor should set "autobuffer" attribute
https://bugs.webkit.org/show_bug.cgi?id=27422
- media/audio-constructor-autobuffer-expected.txt: Added.
- media/audio-constructor-autobuffer.html: Added.
- 2:47 AM Changeset in webkit [46103] by
-
- 2 edits in trunk/WebCore
2009-07-19 Thierry Bastian <thierry.bastian@nokia.com>
Reviewed by Simon Hausmann.
Fix the Qt build with mingw.
- WebCore.pro: Don't use MSVC commandline options to disable warnings with mingw.
- 12:39 AM Changeset in webkit [46102] by
-
- 14 edits in trunk/WebCore
2009-07-19 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[V8] Phase 2: Remove event listener methods from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27415
No behavior change.
- bindings/v8/V8ObjectEventListener.cpp: (WebCore::weakObjectEventListenerCallback): (WebCore::V8ObjectEventListener::~V8ObjectEventListener):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::disconnectEventListeners):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::eventListeners): (WebCore::V8Proxy::objectListeners):
- bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::getEventListener):
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::~V8EventListener):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::getEventListener):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener):
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
Jul 18, 2009:
- 4:13 PM Changeset in webkit [46101] by
-
- 2 edits in trunk/WebCore
2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=27230
Use g_mapped_file_unref for GLIB version 2.22 onwards.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
- 4:03 PM Changeset in webkit [46100] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-07-18 Jorge Gonzalez <aloriel@gmail.com>
Rubber-stamped by Jan Alonzo.
es translation
https://bugs.webkit.org/show_bug.cgi?id=26319
- es.po: Added.
- 4:00 PM Changeset in webkit [46099] by
-
- 4 edits in trunk/LayoutTests/fast
Remove some stray executable flags.
- 3:59 PM Changeset in webkit [46098] by
-
- 2 edits in trunk
Added Radar URLs
- 3:58 PM Changeset in webkit [46097] by
-
- 18 edits4 adds in trunk
WebCore:
Reviewed by Anders Carlsson.
Add spread radius support to -webkit-box-shadow
https://bugs.webkit.org/show_bug.cgi?id=27417
Test: fast/box-shadow/spread.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): Added a property ID parameter and used it to
include the spread length for box-shadow but not for text-shadow.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Pass the property ID to valueForShadow().
- css/CSSParser.cpp: (WebCore::ShadowParseContext::ShadowParseContext): Added property,
spread, and allowSpread members. Added a property ID parameter to
the constructor. Initialize the property and allowSpread members.
(WebCore::ShadowParseContext::allowLength): Added allowSpread.
(WebCore::ShadowParseContext::commitValue): Pass the spread value to
the ShadowValue constructor. Reset allowSpread.
(WebCore::ShadowParseContext::commitLength): Allow spread after blur
for the box-shadow property.
(WebCore::ShadowParseContext::commitColor): Reset allowSpread.
(WebCore::CSSParser::parseShadow): Pass the property ID to
ShadowParseContext().
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Get the spread value from
the shadow value and pass it to the ShadowData constructor.
- css/ShadowValue.cpp: (WebCore::ShadowValue::ShadowValue): Added spread. (WebCore::ShadowValue::cssText): Added spread.
- css/ShadowValue.h: (WebCore::ShadowValue::create): Added spread.
- page/animation/AnimationBase.cpp: (WebCore::blendFunc): Blend the spread value. (WebCore::PropertyWrapperShadow::blend): Added 0 spread to the default
shadow.
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Account for spread in
the visual overflow calculations.
(WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
(WebCore::InlineFlowBox::paint): Ditto.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): Ditto. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlock::overflowRect): Ditto. (WebCore::RenderBlock::layoutBlock): Ditto.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Inflate the shadow-
casting rect by the shadow spread value. Adjust border radii if
necessary.
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Account for spread in the
visual overflow calculations.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Ditto.
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Account for spread. (WebCore::RenderObject::adjustRectForOutlineAndShadow): Ditto.
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): Assert that text shadows do not
have spread.
- rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData): Added spread. (WebCore::ShadowData::operator==): Compare spread.
- rendering/style/ShadowData.h: (WebCore::ShadowData::ShadowData): Added spread.
LayoutTests:
Reviewed by Anders Carlsson.
Test box-shadow spread radius
https://bugs.webkit.org/show_bug.cgi?id=27417
- fast/box-shadow/spread.html: Added.
- platform/mac/fast/box-shadow/spread-expected.checksum: Added.
- platform/mac/fast/box-shadow/spread-expected.png: Added.
- platform/mac/fast/box-shadow/spread-expected.txt: Added.
- 3:53 PM Changeset in webkit [46096] by
-
- 4 edits in trunk
2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>
https://bugs.webkit.org/show_bug.cgi?id=27145
[Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615
Reviewed by Gustavo Noronha.
- platform/gtk/Skipped:
Normalize file URLs.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpHistoryItem):
- 11:50 AM Changeset in webkit [46095] by
-
- 3 edits in trunk/WebKitTools
2009-07-17 Peter Kasting <pkasting@google.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=27323
Further improve non-Cygwin SVN support.
- Scripts/prepare-ChangeLog: Harmless change to be consistent with other places that consume whitespace at the end of svn output.
- Scripts/resolve-ChangeLogs: Add support for SVN 1.6. Slightly optimize svn info parsing based on technique in svn-create-patch. Normalize paths and consume whitespace in the same way as prepare-ChangeLog, for Windows systems with a non-Cygwin SVN. Force diff and patch to run in binary mode so that they won't "intelligently" screw up line endings.
- 10:48 AM Changeset in webkit [46094] by
-
- 2 edits in trunk/WebCore
2009-07-18 Adam Barth <abarth@webkit.org>
Reviewed by Jan Alonzo.
Minor FrameLoader.cpp cleanup
https://bugs.webkit.org/show_bug.cgi?id=27406
No behavior change.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):
- 10:47 AM Changeset in webkit [46093] by
-
- 2 edits in trunk/WebKitTools
2009-07-18 Simon Fraser <Simon Fraser>
Fix Tiger DRT build.
- DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow):
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
- 9:59 AM Changeset in webkit [46092] by
-
- 2 edits in trunk/WebKitTools
2009-07-17 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
DRT doesn't reliably snapshot composited layers
https://bugs.webkit.org/show_bug.cgi?id=27399
If we're doing an "onscreen" pixel capture, it means that we're snapshotting a view
with composited content. In that case we need to force the view to display so that
the composited layers are rendered to the screen.
- DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
- 8:02 AM Changeset in webkit [46091] by
-
- 6 edits in trunk/WebCore
2009-07-18 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
[V8] Move event listener methods from V8Proxy to V8EventListenerList
https://bugs.webkit.org/show_bug.cgi?id=27408
Move some event listener code out of V8Proxy and into the event
listener list.
I'd like to remove these methods from V8Proxy entirely and just expose
getters for the lists themselves, but I'll do that in a follow up
patch.
- bindings/v8/V8EventListenerList.cpp: (WebCore::V8EventListenerList::findWrapper):
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper):
- bindings/v8/V8ObjectEventListener.cpp:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::findV8EventListener): (WebCore::V8Proxy::findOrCreateV8EventListener): (WebCore::V8Proxy::removeV8EventListener): (WebCore::V8Proxy::findObjectEventListener): (WebCore::V8Proxy::findOrCreateObjectEventListener): (WebCore::V8Proxy::removeObjectEventListener):
- bindings/v8/V8Proxy.h:
- 1:45 AM Changeset in webkit [46090] by
-
- 2 edits in trunk/LayoutTests
2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>
[Gtk] Skip tests that require new expected results, eventSender
and editing callbacks DRT support. Unreviewed.
- platform/gtk/Skipped:
- 1:37 AM Changeset in webkit [46089] by
-
- 2 edits in trunk/WebCore
Revert 46088.
- 1:31 AM Changeset in webkit [46088] by
-
- 2 edits in trunk/WebCore
2009-07-18 Adam Barth <abarth@webkit.org>
Reviewed by Jan Alonzo.
Minor FrameLoader.cpp cleanup
https://bugs.webkit.org/show_bug.cgi?id=27406
No behavior change.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):
- 12:44 AM Changeset in webkit [46087] by
-
- 16 edits2 deletes in trunk
WebCore:
2009-07-18 Jeremy Orlow <jorlow@chromium.org>
Rubber stamped by Adam Barth.
Revert https://bugs.webkit.org/show_bug.cgi?id=27383
https://bugs.webkit.org/show_bug.cgi?id=27407
Revert Jens' patch. I believe he forgot to include a file.
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/V8DataGridDataSource.cpp: Removed.
- bindings/v8/V8DataGridDataSource.h: Removed.
- bindings/v8/V8GCController.h:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
LayoutTests:
2009-07-18 Jeremy Orlow <jorlow@chromium.org>
Rubber stamped by Adam Barth.
Revert https://bugs.webkit.org/show_bug.cgi?id=27383
https://bugs.webkit.org/show_bug.cgi?id=27407
Revert Jens' patch. I believe he forgot to include a file.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
- fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
- fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
Jul 17, 2009:
- 11:13 PM Changeset in webkit [46086] by
-
- 3 edits4 adds in trunk
2009-07-17 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests that HTML entities that contain an invalid entity, such as an
unknown named entity, are properly handled.
- http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick-ampersand.html: Added.
- http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-ampersand.html: Added.
2009-07-17 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fixes an issue when decoding HTML entities with an unknown named entity that
caused null-characters to be inserted into the decoded result.
Test: http/tests/security/xssAuditor/link-onclick-ampersand.html
http/tests/security/xssAuditor/javascript-link-ampersand.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeHTMLEntities): Added check to conditional so that non-zero entity values are not inserted during decoding process.
- 10:42 PM Changeset in webkit [46085] by
-
- 2 edits in trunk/WebKitSite
2009-07-17 Simon Fraser <Simon Fraser>
Fix the font to match the rest of the blog site.
- blog-files/3d-transforms/image-flip.html:
- 10:38 PM Changeset in webkit [46084] by
-
- 1 edit1 add in trunk/WebKitSite
2009-07-17 Simon Fraser <Simon Fraser>
Move the image flip effect into an iframe to avoid the long
blog page tripping a bug on Leopard.
- blog-files/3d-transforms/image-flip.html: Added.
- 10:32 PM Changeset in webkit [46083] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-07-17 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27403
Add test case for https://bugs.webkit.org/show_bug.cgi?id=27394:
properties on a window object should be accessible after the frame
of the window object has navigated to another site.
- fast/dom/Window/window-access-after-navigation-expected.txt: Added.
- fast/dom/Window/window-access-after-navigation.html: Added.
- 8:29 PM Changeset in webkit [46082] by
-
- 2 edits in trunk/WebKitTools
2009-07-17 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
bugzilla-tool does not understand nested SVN repos
https://bugs.webkit.org/show_bug.cgi?id=27404
Determine the root of the working copy by looking at SVN's UUIDs.
- Scripts/modules/scm.py:
- 8:12 PM Changeset in webkit [46081] by
-
- 2 edits1 add in trunk/WebCore
2009-07-17 Jan Michael Alonzo <jmalonzo@webkit.org>
<http://webkit.org/b/18363> [GTK] Combo boxes cannot be opened pressing space
Reviewed by Holger Freyther.
Add Gtk to platforms that want to open the menulist using the
spacebar.
- dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
- 7:57 PM Changeset in webkit [46080] by
-
- 4 edits in trunk/WebCore
2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25523
[GTK] The text displayed by push buttons is not exposed to assistive technologies
Add new public method text() to RenderButton and use it from
AccessibilityRenderObject::stringValue().
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue):
- rendering/RenderButton.cpp: (WebCore::RenderButton::text):
- rendering/RenderButton.h:
- 7:14 PM Changeset in webkit [46079] by
-
- 2 edits in trunk/WebCore
2009-07-17 Anton Muhin <antonm@chromium.org>
Reviewed by Dimitri Glazkov.
Restore proxy retrieval
https://bugs.webkit.org/show_bug.cgi?id=27369
No new tests are needed.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- 7:08 PM Changeset in webkit [46078] by
-
- 2 edits in trunk/WebCore
2009-07-17 Yael Aharon <yael.aharon@nokia.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27351
Added platform "Symbian" to WEBCORE_NAVIGATOR_PLATFORM
Use uname to find the correct platform for Linux.
- page/NavigatorBase.cpp:
- 6:42 PM Changeset in webkit [46077] by
-
- 16 edits2 adds in trunk
WebCore:
2009-07-17 Jens Alfke <snej@chromium.org>
Reviewed by Dimitri Glazkov.
Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730
Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.
- WebCore.gypi: Added new source files.
- bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
- bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
- bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates. (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
- bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::V8DataGridDataSource): (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
- bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource) (WebCore::V8DataGridDataSource::create): (WebCore::V8DataGridDataSource::isJSDataGridDataSource): (WebCore::V8DataGridDataSource::jsDataSource): (WebCore::asV8DataGridDataSource):
- bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
- bindings/v8/V8Index.h: Conditionalize datagrid stuff.
- bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
- bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
LayoutTests:
2009-07-17 Jens Alfke <snej@chromium.org>
Reviewed by Dimitri Glazkov.
Hook up V8 bindings for DataGrid elements.
https://bugs.webkit.org/show_bug.cgi?id=27383
http://code.google.com/p/chromium/issues/detail?id=16730
Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
to handle exceptions, check appropriate JS prototypes, and
test column-list's item() method as well as array-indexing.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
- fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
- fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
- 6:36 PM Changeset in webkit [46076] by
-
- 2 edits in trunk/WebKitTools
2009-07-17 David Levin <levin@chromium.org>
Reviewed by Mark Rowe.
webkit-tools-completion.sh has two typos and sorting issues.
https://bugs.webkit.org/show_bug.cgi?id=27401
- Scripts/webkit-tools-completion.sh: Fix two typos "--dif" and "-clean". Also, sort all lists including items in the case statement and flags for the commands.
- 6:26 PM Changeset in webkit [46075] by
-
- 13 edits in trunk/WebCore
2009-07-17 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
StorageArea should only contain methods we intend to proxy.
https://bugs.webkit.org/show_bug.cgi?id=27181
Right now, StorageAreaSync takes in a StorageArea* and calls methods
like importItem. Really, StorageAreaSync should be operating directly
on StorageAreaImpl* and those methods should be removed from StorageArea
since StorageAreaSync should never be attached to anything other than a
StorageAreaImpl.
This was pointed out in the review for
https://bugs.webkit.org/show_bug.cgi?id=27072
Also clean up StorageNamespaceImpl to operate directly on
StorageAreaImpl. Also, get rid of the factory for StorageArea
since nothing should ever create a StorageArea directly.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/StorageArea.cpp: Removed.
- storage/StorageArea.h: (WebCore::StorageArea::~StorageArea):
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::copy):
- storage/StorageAreaImpl.h:
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
- storage/StorageAreaSync.h:
- storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea):
- storage/StorageNamespaceImpl.h:
- 6:22 PM Changeset in webkit [46074] by
-
- 2 edits in trunk/WebCore
2009-07-17 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Add v8 implementation for DOM Storage ScriptObjectQuarantine.
https://bugs.webkit.org/show_bug.cgi?id=27327
Wrap the storage object with a generic object as is done elsewhere in
the file (but continue to hit a NOTIMPLEMENTED if DOM_STORAGE is not
enabled.
- bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- 5:12 PM Changeset in webkit [46073] by
-
- 2 edits in trunk/WebCore
2009-07-17 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=27394
Fix access to global object wrappers after navigation of their
frame in the V8 bindings. This fixes selenium test failures.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::updateDocument):
- 4:54 PM Changeset in webkit [46072] by
-
- 2 edits in trunk/WebCore
Fix the 32-bit build by removing implicit float <-> double conversions.
- inspector/InspectorController.cpp:
(WebCore::constrainedAttachedWindowHeight):
- 4:27 PM Changeset in webkit [46071] by
-
- 7 edits in trunk
2009-07-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272
Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight
to set window sizes and redraw the inspector and the inspected web view, and used stored preferences
in InspectorController.cpp to remember user's preferred height.
- WebCoreSupport/WebInspectorClient.cpp:
2009-07-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272
Moved preference setting for attached inspector height and inspector height calculation from
WebInspectorClient.mm into InspectorController.cpp, to make this code cross-platform and enable
Windows resizing of attached inspector.
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
2009-07-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272
Removed size calculation code from [WebInspectorWindowController setInitialAttachedHeight] into
InspectorController.cpp to make it cross platform, and use InspectorController to store the
user's preferred size for an attached window, instead of NSUserDefaults.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController setAttachedWindowHeight:]):
- 4:25 PM Changeset in webkit [46070] by
-
- 2 edits in trunk/WebCore
Another attempt at fixing the build after r46063
- WebCore.xcodeproj/project.pbxproj: Made ExceptionCode.h a private
header, because it is now included from htmlediting.h, which is
a private header.
- 4:22 PM Changeset in webkit [46069] by
-
- 3 edits2 adds in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27396
Moving cursor in Thai text sometimes jumps over two characters
Test: editing/text-iterator/thai-cursor-movement.html
- platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added a special case for five Thai characters, matching ICU/CLDR changes.
- 4:13 PM Changeset in webkit [46068] by
-
- 19 edits3 adds in trunk
2009-07-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Some constructor objects exposed on Window have the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27276
- fast/dom/prototype-inheritance-expected.txt: Added.
- fast/dom/prototype-inheritance.html: Added.
- fast/dom/resources/prototype-inheritance.js: Added.
2009-07-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Some constructor objects exposed on Window have the wrong prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27276
Several Constructor classes were already being passed a global object
during construction, but they were ignoring it for prototype lookup.
I've fixed those to use the passed global object instead.
Most of these Constructor classes should just be auto-generated, but I
refrained from changing them over to auto-gen in this patch.
Fixed CodeGeneratorJS to pass a global object to getDOMConstructor when
available, otherwise default to deprecatedGlobalObjectForPrototype(exec)
to match existing behavior.
Test: fast/dom/prototype-inheritance.html
- bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): use the existing globalObject pointer for prototype lookup
- bindings/js/JSDOMBinding.h: (WebCore::deprecatedGlobalObjectForPrototype): Make it easy to detect where the wrong global object is being used. (WebCore::deprecatedGetDOMStructure):
- bindings/js/JSDOMGlobalObject.h: remove error-prone getDOMConstructor, require passing JSDOMGlobalObject*
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webKitPoint): pass "this" for the global object. (WebCore::JSDOMWindow::webKitCSSMatrix): pass "this" for the global object. (WebCore::JSDOMWindow::xsltProcessor): pass "this" for the global object. (WebCore::JSDOMWindow::worker): pass "this" for the global object.
- bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor): use the existing globalObject pointer for prototype lookup
- bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): use the existing globalObject pointer for prototype lookup
- bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor): use the existing globalObject pointer for prototype lookup
- bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor): add new globalObject parameter and use it
- bindings/js/JSWebKitCSSMatrixConstructor.h:
- bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor): add new globalObject parameter and use it
- bindings/js/JSWebKitPointConstructor.h:
- bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor): add new globalObject parameter and use it
- bindings/js/JSWorkerConstructor.h:
- bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): use the existing globalObject pointer for prototype lookup -- XMLHttpRequest constructor was also missing a length. Added one.
- bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
- bindings/js/JSXSLTProcessorConstructor.h:
- bindings/scripts/CodeGeneratorJS.pm:
- 4:11 PM Changeset in webkit [46067] by
-
- 2 edits in trunk/WebCore
Build fix
- editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- 4:04 PM WebKit Team edited by
- (diff)
- 4:03 PM Changeset in webkit [46066] by
-
- 14 edits in branches/nitro-extreme/JavaScriptCore
2009-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Get the branch working on windows.
https://bugs.webkit.org/show_bug.cgi?id=27391
SunSpider says 0.3% faster.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Updated MSVC export lists to fix linker errors.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added / removed new / old project files.
- jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): Used #pragma pack to tell MSVC that these structures represent actual memory layout, and should not be automatically aligned. Changed the return value load to load a 64bit quantity into the canonical registers.
- jit/JIT.h: Moved OBJECT_OFFSETOF definition to StdLibExtras.h because it's needed by more than just the JIT, and it supplements a standard library macro (offsetof).
- jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): Fixed an incorrectly signed cast to resolve an MSVC warning.
- jit/JITStubs.h: Used #pragma pack to tell MSVC that these structures represent actual memory layout, and should not be automatically aligned.
- runtime/JSArray.cpp: (JSC::JSArray::JSArray): Replaced memset_pattern8 with a for loop, since memset_pattern8 is not portable. (I verified that this version of the loop gives the best performance / generated code in GCC.)
- runtime/JSObject.h: (JSC::JSObject::JSObject): Removed accidental usage of FIELD_OFFSET -- OBJECT_OFFSETOF is our new macro name. (FIELD_OFFSET conflicts with a definition in winnt.h.)
- runtime/JSValue.cpp: Added some headers needed by non-all-in-one builds.
- runtime/JSValue.h: (JSC::JSValue::): Made the tag signed, to match MSVC's signed enum values. (GCC doesn't seem to care one way or the other.)
- wtf/MainThread.cpp: Moved the StdLibExtras.h #include -- I did this a while ago to resolve a conflict with winnt.h. I can't remember if it's truly still needed, but what the heck.
- wtf/StdLibExtras.h: Moved OBJECT_OFFSETOF definition here.
- 4:02 PM Changeset in webkit [46065] by
-
- 2 edits in trunk/WebCore
2009-07-17 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix for symbol lookup error.
Move AbstractWorker from SHARED_WORKERS to WORKERS as Worker derives from it now
Changed in http://trac.webkit.org/changeset/46048
- GNUmakefile.am:
- 4:01 PM Changeset in webkit [46064] by
-
- 3 edits in trunk/WebKitTools
2009-07-17 Peter Kasting <pkasting@google.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=27323
Tweak some regexes for correctness.
- Scripts/prepare-ChangeLog: Allow 1-character filenames (my previous change here didn't quite get things right).
- Scripts/update-webkit: Detect conflicting ChangeLogs correctly by not including any trailing whitespace in the name "ChangeLog", and by normalizing paths before calling basename() to avoid confusing it. (normalizePath() copied from prepare-ChangeLog.)
- 3:58 PM Changeset in webkit [46063] by
-
- 5 edits in trunk/WebCore
2009-07-17 Ryosuke Niwa <ryosuke.niwa@gmail.com>
Reviewed by Eric Seidel.
htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038
In order to fix the bug 26816, we need several utility functions be added to htmlediting.cpp
No tests because functions haven't been used anywhere yet.
- dom/Range.cpp: (WebCore::Range::create): (WebCore::Range::comparePoint): added const qualifier (WebCore::Range::compareNode): added const qualifier
- dom/Range.h:
- editing/htmlediting.cpp: (WebCore::unsplittableElementForPosition): find the enclosing unsplittable element (editing root & table cell) (WebCore::positionBeforeNode): added ASSERT(node) (WebCore::positionAfterNode): added ASSERT(node) (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode): (WebCore::createRange): create a range object from two visible positions (WebCore::extendRangeToWrappingNodes): extend range to include nodes that starts and ends at the boundaries (WebCore::canMergeLists): typo (WebCore::indexForVisiblePosition): added const qualifier (WebCore::isVisiblyAdjacent): typo (WebCore::isNodeVisiblyContainedWithin): determine if a node is inside a range or within the visible boundaries of the range
- editing/htmlediting.h:
- 3:53 PM WebKit Team edited by
- (diff)
- 3:37 PM Changeset in webkit [46062] by
-
- 18 edits34 adds in trunk
LayoutTests:
2009-07-17 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25551
Test suite for the required attribute, the valueMissing flag and new
:required and :optional CSS pseudoclasses.
Part of the HTML5 sec. Forms.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required
- fast/css/pseudo-required-optional-001-expected.txt: Added.
- fast/css/pseudo-required-optional-001.html: Added.
- fast/css/pseudo-required-optional-002-expected.txt: Added.
- fast/css/pseudo-required-optional-002.html: Added.
- fast/css/pseudo-required-optional-003-expected.txt: Added.
- fast/css/pseudo-required-optional-003.html: Added.
- fast/css/pseudo-required-optional-004-expected.txt: Added.
- fast/css/pseudo-required-optional-004.html: Added.
- fast/css/pseudo-required-optional-005-expected.txt: Added.
- fast/css/pseudo-required-optional-005.html: Added.
- fast/css/pseudo-required-optional-006-expected.txt: Added.
- fast/css/pseudo-required-optional-006.html: Added.
- fast/forms/ValidityState-valueMissing-001-expected.txt: Added.
- fast/forms/ValidityState-valueMissing-001.html: Added.
- fast/forms/ValidityState-valueMissing-002-expected.txt: Added.
- fast/forms/ValidityState-valueMissing-002.html: Added.
- fast/forms/ValidityState-valueMissing-003-expected.txt: Added.
- fast/forms/ValidityState-valueMissing-003.html: Added.
- fast/forms/ValidityState-valueMissing-004-expected.txt: Added.
- fast/forms/ValidityState-valueMissing-004.html: Added.
- fast/forms/ValidityState-valueMissing-005-expected.txt: Added.
- fast/forms/ValidityState-valueMissing-005.html: Added.
- fast/forms/ValidityState-valueMissing-006-expected.txt: Added.
- fast/forms/ValidityState-valueMissing-006.html: Added.
- fast/forms/ValidityState-valueMissing-007-expected.txt: Added.
- fast/forms/ValidityState-valueMissing-007.html: Added.
- fast/forms/ValidityState-valueMissing-008-expected.txt: Added.
- fast/forms/ValidityState-valueMissing-008.html: Added.
- fast/forms/ValidityState-valueMissing-009-expected.txt: Added.
- fast/forms/ValidityState-valueMissing-009.html: Added.
- fast/forms/required-attribute-001-expected.txt: Added.
- fast/forms/required-attribute-001.html: Added.
- fast/forms/required-attribute-002-expected.txt: Added.
- fast/forms/required-attribute-002.html: Added.
WebCore:
2009-07-17 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25551
Added support for the "required" attribute, the valueMissing flag
to the ValidityState object and :required/:optional CSS pseudoclasses.
Part of HTML5 sec. Forms specs.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required
Tests: fast/css/pseudo-required-optional-001.html
fast/css/pseudo-required-optional-002.html
fast/css/pseudo-required-optional-003.html
fast/css/pseudo-required-optional-004.html
fast/css/pseudo-required-optional-005.html
fast/css/pseudo-required-optional-006.html
fast/forms/ValidityState-valueMissing-001.html
fast/forms/ValidityState-valueMissing-002.html
fast/forms/ValidityState-valueMissing-003.html
fast/forms/ValidityState-valueMissing-004.html
fast/forms/ValidityState-valueMissing-005.html
fast/forms/ValidityState-valueMissing-006.html
fast/forms/ValidityState-valueMissing-007.html
fast/forms/ValidityState-valueMissing-008.html
fast/forms/ValidityState-valueMissing-009.html
fast/forms/required-attribute-001.html
fast/forms/required-attribute-002.html
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): pseudoRequired/pseudoOptional
- css/CSSSelector.h: (WebCore::CSSSelector::): ditto
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto
- dom/Element.h: (WebCore::Element::isOptionalFormControl): check for optional controls (WebCore::Element::isRequiredFormControl): check for required controls
- html/HTMLAttributeNames.in: required attribute
- html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::isOptionalFormControl): ditto
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::required): requiredAttr getter (WebCore::HTMLFormControlElement::setRequired): requiredAttr setter
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::valueMissing): method definition
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): validation code (WebCore::HTMLInputElement::isRequiredFormControl): ditto
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::isOptionalFormControl): ditto
- html/HTMLInputElement.idl: required DOM attribute
- html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl): ditto
- html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::valueMissing): validation code (WebCore::HTMLTextAreaElement::isOptionalFormControl): ditto (WebCore::HTMLTextAreaElement::isRequiredFormControl): ditto
- html/HTMLTextAreaElement.idl: required DOM attribute
- html/ValidityState.cpp:
- html/ValidityState.h: (WebCore::ValidityState::valueMissing): validation flag
- 3:30 PM Changeset in webkit [46061] by
-
- 3 edits in trunk/WebCore
2009-07-17 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=27390 CSS custom
cursor hotspots should work in quirks mode
- and corresponding <rdar://problem/6554340>
Enable hotspots in quirks mode.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
Update this manual test to reflect the fact that hotspots are now
expected to work in quirks mode.
- manual-tests/css3-cursor-fallback-quirks.html:
- 3:11 PM WikiStart edited by
- Added link to IdlAttributes wiki page. (diff)
- 3:09 PM IdlAttributes edited by
- (diff)
- 3:02 PM Changeset in webkit [46060] by
-
- 19 edits in trunk
2009-07-17 Peter Kasting <pkasting@google.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
WebCore:
2009-07-17 Peter Kasting <pkasting@google.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/WebCoreGenerated.vcproj:
WebKit/win:
2009-07-17 Peter Kasting <pkasting@google.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/InterfacesGenerated.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
WebKitTools:
2009-07-17 Peter Kasting <pkasting@google.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- 3:01 PM WebKit Team edited by
- (diff)
- 2:56 PM Changeset in webkit [46059] by
-
- 9 edits3 adds in trunk/JavaScriptCore
2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add YARR support for generic ARM platforms (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=24986
Add generic ARM port for MacroAssembler. It supports the whole
MacroAssembler functionality except floating point.
The class JmpSrc is extended with a flag which enables to patch
the jump destination offset during execution. This feature is
required for generic ARM port.
Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <loki@inf.u-szeged.hu>
- JavaScriptCore.pri:
- assembler/ARMAssembler.cpp: Added. (JSC::ARMAssembler::getLdrImmAddress): (JSC::ARMAssembler::linkBranch): (JSC::ARMAssembler::patchConstantPoolLoad): (JSC::ARMAssembler::getOp2): (JSC::ARMAssembler::genInt): (JSC::ARMAssembler::getImm): (JSC::ARMAssembler::moveImm): (JSC::ARMAssembler::dataTransfer32): (JSC::ARMAssembler::baseIndexTransfer32): (JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h: Added. (JSC::ARM::): (JSC::ARMAssembler::ARMAssembler): (JSC::ARMAssembler::): (JSC::ARMAssembler::JmpSrc::JmpSrc): (JSC::ARMAssembler::JmpSrc::enableLatePatch): (JSC::ARMAssembler::JmpDst::JmpDst): (JSC::ARMAssembler::JmpDst::isUsed): (JSC::ARMAssembler::JmpDst::used): (JSC::ARMAssembler::emitInst): (JSC::ARMAssembler::and_r): (JSC::ARMAssembler::ands_r): (JSC::ARMAssembler::eor_r): (JSC::ARMAssembler::eors_r): (JSC::ARMAssembler::sub_r): (JSC::ARMAssembler::subs_r): (JSC::ARMAssembler::rsb_r): (JSC::ARMAssembler::rsbs_r): (JSC::ARMAssembler::add_r): (JSC::ARMAssembler::adds_r): (JSC::ARMAssembler::adc_r): (JSC::ARMAssembler::adcs_r): (JSC::ARMAssembler::sbc_r): (JSC::ARMAssembler::sbcs_r): (JSC::ARMAssembler::rsc_r): (JSC::ARMAssembler::rscs_r): (JSC::ARMAssembler::tst_r): (JSC::ARMAssembler::teq_r): (JSC::ARMAssembler::cmp_r): (JSC::ARMAssembler::orr_r): (JSC::ARMAssembler::orrs_r): (JSC::ARMAssembler::mov_r): (JSC::ARMAssembler::movs_r): (JSC::ARMAssembler::bic_r): (JSC::ARMAssembler::bics_r): (JSC::ARMAssembler::mvn_r): (JSC::ARMAssembler::mvns_r): (JSC::ARMAssembler::mul_r): (JSC::ARMAssembler::muls_r): (JSC::ARMAssembler::mull_r): (JSC::ARMAssembler::ldr_imm): (JSC::ARMAssembler::ldr_un_imm): (JSC::ARMAssembler::dtr_u): (JSC::ARMAssembler::dtr_ur): (JSC::ARMAssembler::dtr_d): (JSC::ARMAssembler::dtr_dr): (JSC::ARMAssembler::ldrh_r): (JSC::ARMAssembler::ldrh_d): (JSC::ARMAssembler::ldrh_u): (JSC::ARMAssembler::strh_r): (JSC::ARMAssembler::push_r): (JSC::ARMAssembler::pop_r): (JSC::ARMAssembler::poke_r): (JSC::ARMAssembler::peek_r): (JSC::ARMAssembler::clz_r): (JSC::ARMAssembler::bkpt): (JSC::ARMAssembler::lsl): (JSC::ARMAssembler::lsr): (JSC::ARMAssembler::asr): (JSC::ARMAssembler::lsl_r): (JSC::ARMAssembler::lsr_r): (JSC::ARMAssembler::asr_r): (JSC::ARMAssembler::size): (JSC::ARMAssembler::ensureSpace): (JSC::ARMAssembler::label): (JSC::ARMAssembler::align): (JSC::ARMAssembler::jmp): (JSC::ARMAssembler::patchPointerInternal): (JSC::ARMAssembler::patchConstantPoolLoad): (JSC::ARMAssembler::patchPointer): (JSC::ARMAssembler::repatchInt32): (JSC::ARMAssembler::repatchPointer): (JSC::ARMAssembler::repatchLoadPtrToLEA): (JSC::ARMAssembler::linkJump): (JSC::ARMAssembler::relinkJump): (JSC::ARMAssembler::linkCall): (JSC::ARMAssembler::relinkCall): (JSC::ARMAssembler::getRelocatedAddress): (JSC::ARMAssembler::getDifferenceBetweenLabels): (JSC::ARMAssembler::getCallReturnOffset): (JSC::ARMAssembler::getOp2Byte): (JSC::ARMAssembler::placeConstantPoolBarrier): (JSC::ARMAssembler::RM): (JSC::ARMAssembler::RS): (JSC::ARMAssembler::RD): (JSC::ARMAssembler::RN): (JSC::ARMAssembler::getConditionalField):
- assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::JmpSrc::enableLatePatch):
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Call::enableLatePatch): (JSC::AbstractMacroAssembler::Jump::enableLatePatch):
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerARM.h: Added. (JSC::MacroAssemblerARM::): (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::and32): (JSC::MacroAssemblerARM::lshift32): (JSC::MacroAssemblerARM::mul32): (JSC::MacroAssemblerARM::not32): (JSC::MacroAssemblerARM::or32): (JSC::MacroAssemblerARM::rshift32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::xor32): (JSC::MacroAssemblerARM::load32): (JSC::MacroAssemblerARM::load32WithAddressOffsetPatch): (JSC::MacroAssemblerARM::loadPtrWithPatchToLEA): (JSC::MacroAssemblerARM::load16): (JSC::MacroAssemblerARM::store32WithAddressOffsetPatch): (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::pop): (JSC::MacroAssemblerARM::push): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::swap): (JSC::MacroAssemblerARM::signExtend32ToPtr): (JSC::MacroAssemblerARM::zeroExtend32ToPtr): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::branch16): (JSC::MacroAssemblerARM::branchTest32): (JSC::MacroAssemblerARM::jump): (JSC::MacroAssemblerARM::branchAdd32): (JSC::MacroAssemblerARM::mull32): (JSC::MacroAssemblerARM::branchMul32): (JSC::MacroAssemblerARM::branchSub32): (JSC::MacroAssemblerARM::breakpoint): (JSC::MacroAssemblerARM::nearCall): (JSC::MacroAssemblerARM::call): (JSC::MacroAssemblerARM::ret): (JSC::MacroAssemblerARM::set32): (JSC::MacroAssemblerARM::setTest32): (JSC::MacroAssemblerARM::tailRecursiveCall): (JSC::MacroAssemblerARM::makeTailRecursiveCall): (JSC::MacroAssemblerARM::moveWithPatch): (JSC::MacroAssemblerARM::branchPtrWithPatch): (JSC::MacroAssemblerARM::storePtrWithPatch): (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::supportsFloatingPointTruncate): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::storeDouble): (JSC::MacroAssemblerARM::addDouble): (JSC::MacroAssemblerARM::subDouble): (JSC::MacroAssemblerARM::mulDouble): (JSC::MacroAssemblerARM::convertInt32ToDouble): (JSC::MacroAssemblerARM::branchDouble): (JSC::MacroAssemblerARM::branchTruncateDoubleToInt32): (JSC::MacroAssemblerARM::ARMCondition): (JSC::MacroAssemblerARM::prepareCall): (JSC::MacroAssemblerARM::call32):
- assembler/X86Assembler.h: (JSC::X86Assembler::JmpSrc::enableLatePatch):
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- wtf/Platform.h:
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
- 2:51 PM WebKit Team edited by
- (diff)
- 2:29 PM Changeset in webkit [46058] by
-
- 2 edits in trunk/WebCore
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=27384
Random crashes in appcache/update-cache.html test
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): Reorder code to avoid using a handle after canceling it.
- 2:28 PM WebKit Team edited by
- (diff)
- 2:17 PM Changeset in webkit [46057] by
-
- 3 edits1 add in trunk/JavaScriptCore
2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Extend AssemblerBuffer with constant pool handling mechanism.
https://bugs.webkit.org/show_bug.cgi?id=24986
Add a platform independed constant pool framework.
This pool can store 32 or 64 bits values which is enough to hold
any integer, pointer or double constant.
- assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::putIntUnchecked): (JSC::AssemblerBuffer::putInt64Unchecked): (JSC::AssemblerBuffer::append): (JSC::AssemblerBuffer::grow):
- assembler/AssemblerBufferWithConstantPool.h: Added. (JSC::):
- 2:17 PM Changeset in webkit [46056] by
-
- 2 edits in trunk/WebCore
Revert "2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>"
This reverts commit http://trac.webkit.org/changeset/46038 as it breaks two
accessibility/ tests in the mac builds.
- 2:16 PM Changeset in webkit [46055] by
-
- 1 edit1 add in trunk/WebKitTools
2009-07-17 David Levin <levin@chromium.org>
Reviewed by Adam Treat.
WebKit should have a bash completion script to aid with common commands.
https://bugs.webkit.org/show_bug.cgi?id=27374
- Scripts/webkit-tools-completion.sh: The script which enables option completion for several WebKit command line scripts.
- 1:17 PM IdlAttributes created by
- 1:17 PM Changeset in webkit [46054] by
-
- 2 edits in trunk/WebKitTools
2009-07-17 Peter Kasting <pkasting@google.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=27323
Avoid error spew on Macs, and fix a few other tiny details.
- Scripts/svn-create-patch:
- 1:13 PM Changeset in webkit [46053] by
-
- 3 edits in trunk/WebKitTools
2009-07-17 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Dave Levin.
https://bugs.webkit.org/show_bug.cgi?id=27377
This makes cpplint complain about this for instance:
if (true)
{
int foo;
}
Add the appropriate unit tests.
- Scripts/modules/cpplint.py:
- Scripts/modules/cpplint_unittest.py:
- 1:08 PM Changeset in webkit [46052] by
-
- 2 edits in trunk/WebKitTools
2009-07-17 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Dave Levin.
https://bugs.webkit.org/show_bug.cgi?id=27377
Don't filter whitespace at the end of the line. This is not
explicitly a rule of webkit coding style, but there is no reason
not to warn of this common style problem.
Don't filter whitespace newline. Now, cpplint will complain
about the following situation:
if (true) {
doSomething();
doSomethingAgain();
}
else
doSomething();
Which is a webkit coding style rule violation.
- Scripts/modules/cpplint.py:
- 1:05 PM Changeset in webkit [46051] by
-
- 2 edits in trunk/WebKitTools
2009-07-17 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Dave Levin.
https://bugs.webkit.org/show_bug.cgi?id=27377
Move this comment to where it belongs.
- Scripts/modules/cpplint_unittest.py:
- 12:37 PM Changeset in webkit [46050] by
-
- 2 edits in trunk/WebKitTools
2009-07-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Correct crash in WinLauncher due to improper mixing of BSTR
and TCHAR types.
https://bugs.webkit.org/show_bug.cgi?id=27381
- WinLauncher/WinLauncher.cpp: (loadURL): Perform SysReAllocString to update the BSTR with the contents of the TCHAR string.
- 12:27 PM Changeset in webkit [46049] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Build fix for non-Darwin.
Add a guard for inclusion of RetainPtr.h which includes CoreFoundation.h
https://bugs.webkit.org/show_bug.cgi?id=27382
- wtf/unicode/icu/CollatorICU.cpp:
- 12:11 PM Changeset in webkit [46048] by
-
- 19 edits in trunk
WebCore:
2009-07-17 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948
Changed Worker to derive from AbstractWorker, which involved moving
AbstractWorker files from being wrapped by ENABLE_SHARED_WORKERS to
ENABLE_WORKERS.
Removed obsolete functionality from the JS/V8 bindings that is now
inherited from AbstractWorker.
- WebCore.pro: Moved AbstractWorker files out of SHARED_WORKERS section and into WORKERS.
- bindings/js/JSAbstractWorkerCustom.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
- bindings/js/JSWorkerCustom.cpp: Removed obsolete event listener code (now in base class) (WebCore::JSWorker::mark): No longer need to explicitly mark event listeners (handled by base class).
- bindings/v8/V8Index.h: Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
- bindings/v8/custom/V8AbstractWorkerCustom.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
- bindings/v8/custom/V8CustomBinding.h: Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
- bindings/v8/custom/V8WorkerCustom.cpp: Removed obsolete event listener code that now lives in the base class. (WebCore::V8WorkerConstructor): Cleaned up legacy style nits.
- workers/AbstractWorker.cpp: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
- workers/AbstractWorker.h: Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
- workers/Worker.cpp: Removed event listener code (now in base class). (WebCore::Worker::Worker): Now derives from AbstractWorker. (WebCore::Worker::notifyFinished): Calls dispatchLoadErrorEvent on base class.
- workers/Worker.h: Removed APIs that now live in the base class.
- workers/Worker.idl: Now derives from AbstractWorker. Removed APIs that live in the base class, and added a GenerateToJS flag.
LayoutTests:
2009-07-17 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948
Added checks to make sure that Workers are properly constructed and Worker attributes
are visible on the resulting object.
- fast/workers/worker-constructor-expected.txt:
- fast/workers/worker-constructor.html: Added explicit check for correct construction/postMessage visibility.
- 12:11 PM Changeset in webkit [46047] by
-
- 3 edits in trunk/WebKitTools
2009-07-17 David Levin <levin@chromium.org>
Reviewed by Adam Treat.
cpplint should flag usages of NULL.
https://bugs.webkit.org/show_bug.cgi?id=27341
- Scripts/modules/cpplint.py: Add the check for NULL test and call it. Make the collapse_strings method public.
- Scripts/modules/cpplint_unittest.py: Add several tests to verify
the check for NULL behavior. Adjust existing tests due to the
new NULL check:
- Several had NULL removed (or were just removed completely).
- Two tests now do an assert that allows the caller to check that a particular error is one of several that was returned.
- 12:11 PM Changeset in webkit [46046] by
-
- 1 edit2 adds in trunk/WebKitTools
2009-07-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
Add a parser of patches for linter.
https://bugs.webkit.org/show_bug.cgi?id=27363
Adds a simple parser for unified diff format.
- Scripts/modules/diff_parser.py: Added.
- Scripts/modules/diff_parser_unittest.py: Added.
- 11:41 AM Changeset in webkit [46045] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 11:36 AM Changeset in webkit [46044] by
-
- 4 edits4 adds in trunk
WebCore:
2009-07-17 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27379
Absolutely-positioned elements with a scrollbar wrap prematurely. Make sure to include
the vertical scrollbar width for overflow:scroll elements.
Added fast/css/positioned-overflow-scroll.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcPrefWidths):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcPrefWidths):
LayoutTests:
2009-07-17 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27379
Absolutely-positioned elements with a scrollbar wrap prematurely. Make sure to include
the vertical scrollbar width for overflow:scroll elements.
- fast/css/positioned-overflow-scroll.html: Added.
- platform/mac/fast/css/positioned-overflow-scroll-expected.checksum: Added.
- platform/mac/fast/css/positioned-overflow-scroll-expected.png: Added.
- platform/mac/fast/css/positioned-overflow-scroll-expected.txt: Added.
- 11:32 AM Changeset in webkit [46043] by
-
- 1 copy in tags/Safari-6531.6
New tag.
- 11:21 AM Changeset in webkit [46042] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by John Sullivan.
Get user default collation order via a CFLocale API when available.
- wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):
- 11:01 AM Changeset in webkit [46041] by
-
- 2 edits in trunk/WebCore
2009-07-17 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Need a DOM_STORAGE guard in DerivedSroucesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=27375
In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp
and StorageEvent.cpp. Unfortunately, until later this afternoon,
DOM_STORAGE is not turned on by default in Chromium, and so these two
files are never generated. This breaks the compile.
There are no other instances of guards in the file, which puzzles me...
but I think adding guards is the right way to go about this.
- bindings/v8/DerivedSourcesAllInOne.cpp: Added the guard.
- 11:00 AM Changeset in webkit [46040] by
-
- 8 edits in trunk/WebKit/qt
2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Adam Treat.
Coding style fixes.
- Api/qcookiejar.cpp: (QCookieJarPrivate::QCookieJarPrivate): (qHash): (QCookieJar::cookieJar):
- Api/qwebelement.cpp: (QWebElement::functions): (QWebElement::scriptableProperties):
- Api/qwebframe.cpp: (QWebFrame::metaData): (QWebFrame::scrollBarValue): (QWebFrame::scroll): (QWebFrame::scrollPosition): (QWebFrame::print):
- Api/qwebnetworkinterface.cpp: (decodePercentEncoding): (QWebNetworkRequestPrivate::init): (QWebNetworkRequestPrivate::setURL): (QWebNetworkRequest::QWebNetworkRequest): (QWebNetworkRequest::operator=): (QWebNetworkRequest::setUrl): (QWebNetworkRequest::setHttpHeader): (QWebNetworkRequest::httpHeaderField): (QWebNetworkRequest::setHttpHeaderField): (QWebNetworkRequest::setPostData): (QWebNetworkJob::setResponse): (QWebNetworkJob::frame): (QWebNetworkManager::add): (QWebNetworkManager::cancel): (QWebNetworkManager::started): (QWebNetworkManager::data): (QWebNetworkManager::finished): (QWebNetworkManager::addHttpJob): (QWebNetworkManager::cancelHttpJob): (QWebNetworkManager::httpConnectionClosed): (QWebNetworkInterfacePrivate::sendFileData): (QWebNetworkInterfacePrivate::parseDataUrl): (QWebNetworkManager::doWork): (QWebNetworkInterface::setDefaultInterface): (QWebNetworkInterface::defaultInterface): (QWebNetworkInterface::QWebNetworkInterface): (QWebNetworkInterface::addJob): (QWebNetworkInterface::cancelJob): (WebCoreHttp::WebCoreHttp): (WebCoreHttp::request): (WebCoreHttp::scheduleNextRequest): (WebCoreHttp::getConnection): (WebCoreHttp::onResponseHeaderReceived): (WebCoreHttp::onReadyRead): (WebCoreHttp::onRequestFinished): (WebCoreHttp::onAuthenticationRequired): (WebCoreHttp::onProxyAuthenticationRequired):
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::mouseReleaseEvent): (QWebPagePrivate::inputMethodEvent): (QWebPagePrivate::shortcutOverrideEvent): (QWebPage::inputMethodQuery): (QWebPage::javaScriptPrompt): (QWebPage::updatePositionDependentActions): (QWebPage::userAgentForUrl): (QWebPagePrivate::_q_onLoadProgressChanged): (QWebPage::totalBytes): (QWebPage::bytesReceived):
- Api/qwebsettings.cpp: (QWebSettings::iconForUrl): (QWebSettings::setObjectCacheCapacities):
- Api/qwebview.cpp: (QWebView::paintEvent): (QWebView::changeEvent):
- 10:53 AM Changeset in webkit [46039] by
-
- 2 edits in trunk/WebCore
2009-07-17 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Let WebCore always enforce the connection-per-host limit itself.
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
- 9:48 AM Changeset in webkit [46038] by
-
- 2 edits in trunk/WebCore
2009-07-17 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25524
[Gtk] Expose the title attribute to assistive technologies
Expose 'alt' attribute from images as accessible name.
Expose the 'title' core HTML attribute as accessible description.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::accessibilityDescription):
- 9:41 AM Changeset in webkit [46037] by
-
- 2 edits in trunk/WebCore
Some transitions don't work correctly on Leopard
https://bugs.webkit.org/show_bug.cgi?id=27356
We only have code to do component animation using valueFunction.
So on Leopard we always need to do matrix animation in hardware.
This fix ensures that.
This is currently not testable because it appears only in the
hardware animation and we can't yet do pixel tests while
hardware animating.
- 8:56 AM Changeset in webkit [46036] by
-
- 2 edits in trunk/WebKitTools
[GTK+] Make TestNescpaePlugin loadable in mozilla
https://bugs.webkit.org/show_bug.cgi?id=27345
Currently the NPNetscapeFuncs of WebKit contains two more
entries than the gecko version. This means comparing the
aMozillaVTable->size with the size of NPNetscpaeFuncs will
fail and the plugin will not be loaded.
For testing it is nice to be able to load the plugin into
gecko and currently we are not using the two extra methods.
Remove the test to be able to use the plugin in gecko.
- 7:48 AM Changeset in webkit [46035] by
-
- 2 edits in trunk/WebCore
2009-07-17 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by NOBODY (OOPS!).
[GTK+] Crash in screenAvailable due a null Widget*
JSDOMWindow::open called screenAvailableRect(0). The other
Screen methods can be called with a null widget as well, fix the
crashing test by checking for null.
In screenRect and screenAvailableRect it is not tried to use
a default screen as the existing implementation didn't try either
in case of not having a toplevel widget.
LayoutTests/fast/frames/crash-removed-iframe.html caused a crash.
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): New method to get a visual or return zero. (WebCore::screenDepth): Use getVisual. (WebCore::screenDepthPerComponent): Use getVisual. (WebCore::screenIsMonochrome): Use screenDepth which will do the null checking (WebCore::screenRect): Check for !widget. (WebCore::screenAvailableRect): Check for !widget.
- 7:44 AM Changeset in webkit [46034] by
-
- 2 edits in trunk/LayoutTests
2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Remove tests from Qt Skipped list that are actually working.
https://bugs.webkit.org/show_bug.cgi?id=27316
- platform/qt/Skipped:
- 7:09 AM Changeset in webkit [46033] by
-
- 2 edits in trunk/WebKitTools
2009-07-17 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Simon Hausmann.
Something about having a single TAB in a style checking tool like this
is equivalent to nails on a chalk board to me...
- Scripts/modules/cpplint.py:
- 6:56 AM Changeset in webkit [46032] by
-
- 4 edits in trunk
2009-07-17 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358
- JavaScriptCore.pri:
WebCore:
2009-07-17 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358
- WebCore.pro:
- 6:34 AM Changeset in webkit [46031] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix a small typo in the changelog
- 6:32 AM Changeset in webkit [46030] by
-
- 7 edits in trunk
WebCore:
2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Make it possible to set the plugin directories from the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::installedPlugins): Now optionally takes a populate argument, so we can avoid loading system plugins from the DRT and thus avoid their strerr errors that can make tests fail. (WebCore::PluginDatabase::clear): Make is possible to clear the database. Called from setPluginDirectories.
- plugins/PluginDatabase.h: (WebCore::PluginDatabase::setPluginDirectories): Make public
WebKit/qt:
2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Overwrite the plugin directories for the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215
- Api/qwebpage.cpp: (qt_drt_overwritePluginDirectories): Only set the plugin directories to the ones in the QTWEBKIT_PLUGIN_PATH environment variable.
WebKitTools:
2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Overwrite the plugin directories for the DRT.
Part of https://bugs.webkit.org/show_bug.cgi?id=27215
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- 5:43 AM Changeset in webkit [46029] by
-
- 2 edits in trunk/WebCore
2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
PluginViewMac: Stop the plugin when loading fails
Also, prevent event propagation when in the stopped state
- plugins/mac/PluginViewMac.cpp:
- 5:40 AM Changeset in webkit [46028] by
-
- 4 edits in trunk/WebCore
2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
PluginViewMac: Allow query and set of drawing and event models
We now support querying and setting of the drawing and event model,
but we still only support the CoreGraphics drawing model, and the
Carbon event model.
If unsupported drawing or event models are detected we show the
missing-plugin icon.
- plugins/PluginView.cpp:
- plugins/PluginView.h:
- plugins/mac/PluginViewMac.cpp:
- 5:17 AM Changeset in webkit [46027] by
-
- 2 edits in trunk/WebCore
2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Initialize two PluginView members using memset
m_npWindow is used on all platforms, not just for XP_UNIX,
so always initialize it. m_npCgContext on the other hand
is only used for XP_MACOSX.
- plugins/PluginView.cpp:
- 4:46 AM Changeset in webkit [46026] by
-
- 6 edits in trunk/WebCore
2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Add more debug logging in PluginView
- plugins/PluginView.cpp: Add debug for setValue
- plugins/gtk/PluginViewGtk.cpp: Add debug for getValue
- plugins/mac/PluginViewMac.cpp: Add debug for getValue and more
- plugins/qt/PluginViewQt.cpp: Add debug for getValue
- plugins/win/PluginViewWin.cpp: Add debug for getValue
- 4:00 AM Changeset in webkit [46025] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-17 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by David Levin.
Build fix on platforms don't have MMAP.
https://bugs.webkit.org/show_bug.cgi?id=27365
- interpreter/RegisterFile.h: Including stdio.h irrespectively of HAVE(MMAP)
- 3:52 AM Changeset in webkit [46024] by
-
- 2 edits in trunk/WebCore
2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Holger Freyther.
Use same license in PluginDebug.cpp as in the original PluginDebug.h
- plugins/PluginDebug.cpp: Use license from PluginDebug.h
- 3:35 AM Changeset in webkit [46023] by
-
- 7 edits1 add in trunk/WebCore
2009-07-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Add more debugging functionality for the WebCore NPAPI layer
- GNUmakefile.am: Add PluginDebug.cpp
- WebCore.gypi: Add PluginDebug.cpp
- WebCore.pro: Add PluginDebug.cpp
- WebCore.vcproj/WebCore.vcproj: Add PluginDebug.cpp
- WebCoreSources.bkl: Add PluginDebug.cpp
- plugins/PluginDebug.h: Move errorStrings to PluginDebug.cpp
- plugins/PluginDebug.cpp: New file
- 12:42 AM Changeset in webkit [46022] by
-
- 3 edits in trunk/WebCore
2009-07-17 Jeremy Orlow <jorlow@chromium.org>
Reviewed by David Levin.
Fix Chromium build with DOM_STORAGE enabled.
https://bugs.webkit.org/show_bug.cgi?id=27360
2 minor changes as noted below:
- bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .cpp files.
- storage/StorageAreaImpl.cpp: #include "DOMWindow.h"
- 12:42 AM Changeset in webkit [46021] by
-
- 15 edits in trunk
2009-07-16 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
https://bugs.webkit.org/show_bug.cgi?id=27206
.:
Add --enable-web-sockets in configure.ac
- configure.ac:
Add ENABLE_WEB_SOCKETS
- Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS
WebCore:
Add ENABLE_WEB_SOCKETS
- Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS
- GNUmakefile.am: add ENABLE_WEB_SOCKETS
- WebCore.vcproj/WebCoreCommon.vsprops: add ENABLE_WEB_SOCKETS
- WebCore.vcproj/build-generated-files.sh: add ENABLE_WEB_SOCKETS
WebKit/mac:
Add ENABLE_WEB_SOCKETS
- Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS
WebKit/win:
Add ENABLE_WEB_SOCKETS
- WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS
WebKitTools:
Add --web-sockets flag.
- Scripts/build-webkit: add --web-sockets flag.
Jul 16, 2009:
- 11:41 PM Changeset in webkit [46020] by
-
- 1 edit5 adds in trunk/WebCore
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Oliver Hunt.
Added a third bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26952
Adding five files, EventLoopHaiku.cpp, FileChooserHaiku.cpp,
FileSystemHaiku.cpp, KeyboardCodes.h and MIMETypeRegistryHaiku.cpp
- platform/haiku/EventLoopHaiku.cpp: Added. (WebCore::EventLoop::cycle):
- platform/haiku/FileChooserHaiku.cpp: Added. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::basenameForWidth):
- platform/haiku/FileSystemHaiku.cpp: Added. (WebCore::fileSystemRepresentation): (WebCore::homeDirectoryPath): (WebCore::openTemporaryFile): (WebCore::closeFile): (WebCore::writeToFile): (WebCore::unloadModule): (WebCore::listDirectory):
- platform/haiku/KeyboardCodes.h: Added.
- platform/haiku/MIMETypeRegistryHaiku.cpp: Added. (WebCore::): (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- 11:41 PM Changeset in webkit [46019] by
-
- 1 edit5 adds in trunk/WebCore
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Oliver Hunt.
Added a second bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26952
Adding four files, ContextMenuHaiku.cpp, ContextMenuItemHaiku.cpp,
DragDataHaiku.cpp and DragImageHaiku.cpp
- platform/haiku/ContextMenuHaiku.cpp: Added. (WebCore::ContextMenuReceiver::ContextMenuReceiver): (WebCore::ContextMenuReceiver::HandleMessage): (WebCore::ContextMenuReceiver::Result): (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::platformDescription): (WebCore::ContextMenu::setPlatformDescription):
- platform/haiku/ContextMenuItemHaiku.cpp: Added. (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (ContextMenuItem::enabled):
- platform/haiku/DragDataHaiku.cpp: Added. (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment):
- platform/haiku/DragImageHaiku.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
- 11:30 PM Changeset in webkit [46018] by
-
- 1 edit2 adds in trunk/JavaScriptCore
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added Haiku-specific files for JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=26620
- wtf/haiku/MainThreadHaiku.cpp: Added. (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):
- 11:28 PM Changeset in webkit [46017] by
-
- 11 edits in trunk/WebCore
2009-07-16 Stephen White <senorblanco@chromium.org>
Reviewed by Darin Fisher and Brett Wilson.
Refactor Skia implementation of gradients and patterns.
The following layout tests were breaking on Chromium/Linux:
LayoutTests/svg/custom/js-late-gradient-creation.svg (bad baseline PNG)
LayoutTests/svg/custom/js-late-gradient-and-object.creation.svg
LayoutTests/svg/custom/js-late-pattern-creation.svg (bad baseline PNG)
LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg
I could've fixed these the easy way, by copying the same 5
lines of code we use everywhere we need patterns or gradients, but
I decided to fix it the hard way: by refactoring the code so that
PlatformContextSkia::setupPaintForFilling() and
PlatformContextSkia::setupPaintForStroking() do the right thing,
and also handle gradients and patterns.
This required pushing the gradients and patterns set in
(generic) GraphicsContext::setFillPattern() and friends down into
PlatformContextSkia. For this, I followed the setPlatformXXX()
pattern used elsewhere in GraphicsContext, and stubbed them out on
the other platforms with #if !PLATFORM(SKIA). This also required
pushing changes to the gradientSpaceTransform from the Gradient into
GradientSkia.
Since it's a Skia context, I decided to cache the values as
SkShaders. There were existing m_pattern and m_gradient SkShaders,
but they were unused, and whose use was ambiguous, so I
replaced them with one SkShader each for filling and stroking.
- platform/graphics/Gradient.cpp: (WebCore::Gradient::setGradientSpaceTransform): (WebCore::Gradient::setPlatformGradientSpaceTransform):
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient): (WebCore::GraphicsContext::setPlatformFillGradient): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokeGradient): (WebCore::GraphicsContext::setPlatformStrokePattern):
- platform/graphics/GraphicsContext.h:
- platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::setPlatformGradientSpaceTransform):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformFillGradient): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokeGradient): (WebCore::GraphicsContext::setPlatformStrokePattern): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::State::~State): (PlatformContextSkia::drawRect): (PlatformContextSkia::setupPaintCommon): (PlatformContextSkia::setupPaintForFilling): (PlatformContextSkia::setupPaintForStroking): (PlatformContextSkia::setFillColor): (PlatformContextSkia::setStrokeColor): (PlatformContextSkia::setStrokeShader): (PlatformContextSkia::setFillShader):
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/skia/SkiaFontWin.cpp: (WebCore::skiaDrawText): (WebCore::paintSkiaText):
- svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::teardown):
- 11:03 PM Changeset in webkit [46016] by
-
- 1 edit2 adds in trunk/WebKit
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added InspectorClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952
Adding two files, InspectorClientHaiku.h and InspectorClientHaiku.cpp
- haiku/WebCoreSupport/InspectorClientHaiku.cpp: Added. (WebCore::InspectorClientHaiku::inspectorDestroyed): (WebCore::InspectorClientHaiku::createPage): (WebCore::InspectorClientHaiku::localizedStringsURL): (WebCore::InspectorClientHaiku::hiddenPanels): (WebCore::InspectorClientHaiku::showWindow): (WebCore::InspectorClientHaiku::closeWindow): (WebCore::InspectorClientHaiku::attachWindow): (WebCore::InspectorClientHaiku::detachWindow): (WebCore::InspectorClientHaiku::setAttachedWindowHeight): (WebCore::InspectorClientHaiku::highlight): (WebCore::InspectorClientHaiku::hideHighlight): (WebCore::InspectorClientHaiku::inspectedURLChanged): (WebCore::InspectorClientHaiku::populateSetting): (WebCore::InspectorClientHaiku::storeSetting): (WebCore::InspectorClientHaiku::removeSetting):
- haiku/WebCoreSupport/InspectorClientHaiku.h: Added.
- 11:02 PM Changeset in webkit [46015] by
-
- 1 edit2 adds in trunk/WebKit
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Oliver Hunt.
Added EditorClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952
Adding two files, EditorClientHaiku.h and EditorClientHaiku.cpp
- haiku/WebCoreSupport/EditorClientHaiku.cpp: Added. (WebCore::EditorClientHaiku::EditorClientHaiku): (WebCore::EditorClientHaiku::setPage): (WebCore::EditorClientHaiku::pageDestroyed): (WebCore::EditorClientHaiku::shouldDeleteRange): (WebCore::EditorClientHaiku::shouldShowDeleteInterface): (WebCore::EditorClientHaiku::smartInsertDeleteEnabled): (WebCore::EditorClientHaiku::isSelectTrailingWhitespaceEnabled): (WebCore::EditorClientHaiku::isContinuousSpellCheckingEnabled): (WebCore::EditorClientHaiku::toggleContinuousSpellChecking): (WebCore::EditorClientHaiku::isGrammarCheckingEnabled): (WebCore::EditorClientHaiku::toggleGrammarChecking): (WebCore::EditorClientHaiku::spellCheckerDocumentTag): (WebCore::EditorClientHaiku::isEditable): (WebCore::EditorClientHaiku::shouldBeginEditing): (WebCore::EditorClientHaiku::shouldEndEditing): (WebCore::EditorClientHaiku::shouldInsertNode): (WebCore::EditorClientHaiku::shouldInsertText): (WebCore::EditorClientHaiku::shouldChangeSelectedRange): (WebCore::EditorClientHaiku::shouldApplyStyle): (WebCore::EditorClientHaiku::shouldMoveRangeAfterDelete): (WebCore::EditorClientHaiku::didBeginEditing): (WebCore::EditorClientHaiku::respondToChangedContents): (WebCore::EditorClientHaiku::respondToChangedSelection): (WebCore::EditorClientHaiku::didEndEditing): (WebCore::EditorClientHaiku::didWriteSelectionToPasteboard): (WebCore::EditorClientHaiku::didSetSelectionTypesForPasteboard): (WebCore::EditorClientHaiku::registerCommandForUndo): (WebCore::EditorClientHaiku::registerCommandForRedo): (WebCore::EditorClientHaiku::clearUndoRedoOperations): (WebCore::EditorClientHaiku::canUndo): (WebCore::EditorClientHaiku::canRedo): (WebCore::EditorClientHaiku::undo): (WebCore::EditorClientHaiku::redo): (WebCore::EditorClientHaiku::handleKeyboardEvent): (WebCore::EditorClientHaiku::handleInputMethodKeydown): (WebCore::EditorClientHaiku::textFieldDidBeginEditing): (WebCore::EditorClientHaiku::textFieldDidEndEditing): (WebCore::EditorClientHaiku::textDidChangeInTextField): (WebCore::EditorClientHaiku::doTextFieldCommandFromEvent): (WebCore::EditorClientHaiku::textWillBeDeletedInTextField): (WebCore::EditorClientHaiku::textDidChangeInTextArea): (WebCore::EditorClientHaiku::ignoreWordInSpellDocument): (WebCore::EditorClientHaiku::learnWord): (WebCore::EditorClientHaiku::checkSpellingOfString): (WebCore::EditorClientHaiku::getAutoCorrectSuggestionForMisspelledWord): (WebCore::EditorClientHaiku::checkGrammarOfString): (WebCore::EditorClientHaiku::updateSpellingUIWithGrammarString): (WebCore::EditorClientHaiku::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientHaiku::showSpellingUI): (WebCore::EditorClientHaiku::spellingUIIsShowing): (WebCore::EditorClientHaiku::getGuessesForWord): (WebCore::EditorClientHaiku::setInputMethodState): (WebCore::EditorClientHaiku::isEditing):
- haiku/WebCoreSupport/EditorClientHaiku.h: Added.
- 11:02 PM Changeset in webkit [46014] by
-
- 1 edit2 adds in trunk/WebKit
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added DragClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952
Adding two files, DragClientHaiku.h and DragClientHaiku.cpp
- haiku/WebCoreSupport/DragClientHaiku.cpp: Added. (WebCore::DragClientHaiku::actionMaskForDrag): (WebCore::DragClientHaiku::willPerformDragDestinationAction): (WebCore::DragClientHaiku::dragControllerDestroyed): (WebCore::DragClientHaiku::dragSourceActionMaskForPoint): (WebCore::DragClientHaiku::willPerformDragSourceAction): (WebCore::DragClientHaiku::startDrag): (WebCore::DragClientHaiku::createDragImageForLink):
- haiku/WebCoreSupport/DragClientHaiku.h: Added.
- 11:02 PM Changeset in webkit [46013] by
-
- 1 edit4 adds in trunk/WebKit
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Oliver Hunt.
Added ContextMenuClient for Haiku WebCore support.
https://bugs.webkit.org/show_bug.cgi?id=26952
Adding two files, ContextMenuClientHaiku.h
and ContextMenuClientHaiku.cpp
- haiku/WebCoreSupport/ContextMenuClientHaiku.cpp: Added. (WebCore::ContextMenuClientHaiku::contextMenuDestroyed): (WebCore::ContextMenuClientHaiku::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientHaiku::contextMenuItemSelected): (WebCore::ContextMenuClientHaiku::downloadURL): (WebCore::ContextMenuClientHaiku::lookUpInDictionary): (WebCore::ContextMenuClientHaiku::speak): (WebCore::ContextMenuClientHaiku::isSpeaking): (WebCore::ContextMenuClientHaiku::stopSpeaking): (WebCore::ContextMenuClientHaiku::searchWithGoogle):
- haiku/WebCoreSupport/ContextMenuClientHaiku.h: Added.
- 10:47 PM Changeset in webkit [46012] by
-
- 1 edit2 adds in trunk/WebCore
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Oliver Hunt.
Added Haiku-specific files for WebCore/platform/image-decoders/.
https://bugs.webkit.org/show_bug.cgi?id=26949
Adding a new file, ImageDecoderHaiku.cpp.
- platform/image-decoders/haiku/ImageDecoderHaiku.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height):
- 10:47 PM Changeset in webkit [46011] by
-
- 1 edit4 adds in trunk/WebCore
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added Haiku-specific files for WebCore/page/.
https://bugs.webkit.org/show_bug.cgi?id=26949
Adding three new files, DragControllerHaiku.cpp, EventHandlerHaiku.cpp
and FrameHaiku.cpp
- page/haiku/DragControllerHaiku.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize): (WebCore::DragController::cleanupAfterSystemDrag):
- page/haiku/EventHandlerHaiku.cpp: Added. (WebCore::isKeyboardOptionTab): (WebCore::EventHandler::invertSenseOfTabsToLinks): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::accessKeyModifiers):
- page/haiku/FrameHaiku.cpp: Added. (WebCore::Frame::dragImageForSelection):
- 10:46 PM Changeset in webkit [46010] by
-
- 1 edit2 adds in trunk/WebCore
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added Haiku-specific files for WebCore/editing/.
https://bugs.webkit.org/show_bug.cgi?id=26949
Adding one new file, EditorHaiku.cpp
- editing/haiku/EditorHaiku.cpp: Added. (WebCore::Editor::newGeneralClipboard):
- 10:46 PM Changeset in webkit [46009] by
-
- 1 edit1 add in trunk/WebCore
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added Haiku-specific files for WebCore/bindings/js/.
https://bugs.webkit.org/show_bug.cgi?id=26949
Adding a new file, ScriptControllerHaiku.cpp
- bindings/js/ScriptControllerHaiku.cpp: Added. (WebCore::ScriptController::createScriptInstanceForWidget):
- 10:46 PM Changeset in webkit [46008] by
-
- 1 edit3 adds in trunk/WebCore
2009-07-16 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added Haiku-specific files for WebCore/platform/text/.
https://bugs.webkit.org/show_bug.cgi?id=26949
Adding two new files, StringHaiku.cpp
and TextBreakIteratorInternalICUHaiku.cpp
- platform/text/haiku/StringHaiku.cpp: Added. (WebCore::String::String): (WebCore::String::operator BString):
- platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp: Added. (WebCore::currentTextBreakLocaleID):
- 10:29 PM Changeset in webkit [46007] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-16 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Jan Alonzo.
[GTK+] Update the focus handling code.
Change focus-in to always call setActive(true), call
FocusController::setFocusedFrame when no focused frame exists
other SelectionController::setActive. This is matching Windows
and Qt.
On focus-out call FocusController::setActive(false) and
SelectionController::setFocued(false). This is matching Windows
and Qt as well.
- webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event):
- 9:36 PM Changeset in webkit [46006] by
-
- 6 edits2 adds in trunk
2009-07-16 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel and Adam Barth.
A test for for non-multipart file upload form submission.
This test is disabled for non-Mac platforms because of beginDragWithFiles().
<https://bugs.webkit.org/show_bug.cgi?id=26505>
- fast/forms/get-file-upload-expected.txt: Added.
- fast/forms/get-file-upload.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2009-07-16 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Sends the basename of a selected file for non-multipart form submission.
<https://bugs.webkit.org/show_bug.cgi?id=26505>
Test: fast/forms/get-file-upload.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData):
- 9:23 PM Changeset in webkit [46005] by
-
- 4 edits2 adds in trunk/WebCore
2009-07-16 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[V8] Centralize hidden property names
https://bugs.webkit.org/show_bug.cgi?id=27359
No behavior change. Just moving these names to a central location.
I'll move the rest of our hidden property names as I sweep though the
bindings.
- WebCore.gypi:
- bindings/v8/V8HiddenPropertyName.cpp: Added. (WebCore::V8HiddenPropertyName::objectPrototype): (WebCore::V8HiddenPropertyName::isolatedWorld):
- bindings/v8/V8HiddenPropertyName.h: Added.
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld): (WebCore::V8IsolatedWorld::getEntered):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::getHiddenObjectPrototype): (WebCore::V8Proxy::installHiddenObjectPrototype):
- 8:24 PM Changeset in webkit [46004] by
-
- 4 edits in trunk/JavaScriptCore
2009-07-16 Gavin Barraclough <barraclough@apple.com>
RS by Oliver Hunt.
Revert r45969, this fix does not appear to be valid.
https://bugs.webkit.org/show_bug.cgi?id=27077
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::unlinkCallers):
- jit/JIT.cpp:
- jit/JIT.h:
- 7:55 PM Changeset in webkit [46003] by
-
- 3 edits in trunk/WebKitTools
2009-07-16 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Dave Levin.
cpplint should check for one line control clauses that are surrounded
by braces
https://bugs.webkit.org/show_bug.cgi?id=27354
- Scripts/modules/cpplint.py: Added the new lint check.
- Scripts/modules/cpplint_unittest.py: Add tests for the new lint check and fix the other tests as they were not passing this new lint check.
- 5:47 PM Changeset in webkit [46002] by
-
- 8 edits4 adds in trunk
WebCore:
Reviewed by Simon Fraser.
REGRESSION (r41238) Repainted portion of a scaled image does not line up with full image
https://bugs.webkit.org/show_bug.cgi?id=26747
rdar://problem/7009243
Test: fast/repaint/background-misaligned.html
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled): Moved a variable definition closer to where it is used.
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): In the subimage code path, compute a pixel-aligned source rect, because the subiamge is always pixel-aligned in source space, and adjust the destination rect to preserve the source -> destination mapping. Clip to the (original) destination rect to prevent bleeding out.
LayoutTests:
Reviewed by Simon Fraser.
REGRESSION (r41238) Repainted portion of a scaled image does not line up with full image
https://bugs.webkit.org/show_bug.cgi?id=26747
rdar://problem/7009243
- fast/repaint/background-misaligned.html: Added.
- platform/mac/fast/backgrounds/size/backgroundSize15-expected.checksum:
- platform/mac/fast/backgrounds/size/backgroundSize15-expected.png:
- platform/mac/fast/borders/border-image-rotate-transform-expected.checksum:
- platform/mac/fast/borders/border-image-rotate-transform-expected.png:
- platform/mac/fast/repaint/background-misaligned-expected.checksum: Added.
- platform/mac/fast/repaint/background-misaligned-expected.png: Added.
- platform/mac/fast/repaint/background-misaligned-expected.txt: Added.
- 5:41 PM Changeset in webkit [46001] by
-
- 4 edits in trunk/WebCore
2009-07-16 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Add a sessionStorageEnabled setting to the settings class.
https://bugs.webkit.org/show_bug.cgi?id=27318
Allow LocalStorage to be enabled without enabling SessionStorage at
runtime. There is a settings class setting for localStorage, but not
for sessionStorage. We want to be able to test one of these features
without necessarily enabling the other.
SessionStorage defaults to true so as to not change behavior and
because there really aren't any security concerns around SessionStorage
(unlike LocalsStorage). The flag is needed in Chromium only because
we want to enable the compile time flag in the default build, but don't
want it on by default until it's been thoroughly tested.
- page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): Check the new flag (WebCore::DOMWindow::localStorage): A bit of cleanup
- page/Settings.cpp: (WebCore::Settings::Settings): Default the flag to true (WebCore::Settings::setSessionStorageEnabled): Add the new flag
- page/Settings.h: (WebCore::Settings::sessionStorageEnabled): Get the new flag
- 5:35 PM Changeset in webkit [46000] by
-
- 5 edits in trunk/WebKit
../gtk:
2009-07-16 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
This is the 2nd part of fixing "RTL: tooltip does not get its directionlity from its element's."
https://bugs.webkit.org/show_bug.cgi?id=24187
Add one extra parameter to the callee of HitTestResult::title() due to the signature change.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement): Add direction as a parameter to the callee of HitTestResult::title().
../qt:
2009-07-16 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
This is the 2nd part of fixing "RTL: tooltip does not get its directionlity from its element's."
https://bugs.webkit.org/show_bug.cgi?id=24187
Add one extra parameter to the callee of HitTestResult::title() due to the signature change.
- Api/qwebframe.cpp: (QWebHitTestResultPrivate::QWebHitTestResultPrivate): Add direction as a parameter to the callee of HitTestResult::title().
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement): Add direction as a parameter to the callee of HitTestResult::title().
- 5:16 PM Changeset in webkit [45999] by
-
- 3 edits2 deletes in trunk
WebCore:
2009-07-16 Adam Barth <abarth@webkit.org>
Unreviewed.
Revert 45987. Tests did not pass on Windows.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData):
LayoutTests:
2009-07-16 Adam Barth <abarth@webkit.org>
Unreviewed.
Revert 45987. Tests did not pass on Windows.
- fast/forms/get-file-upload-expected.txt: Removed.
- fast/forms/get-file-upload.html: Removed.
- 4:38 PM Changeset in webkit [45998] by
-
- 2 edits in trunk/WebKitTools
2009-07-16 Peter Kasting <pkasting@google.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=27323
Improve support for WebKit checkouts hosted inside other checkouts
(possible for some ports, e.g. Chromium).
- Scripts/svn-create-patch: Determine SVN root by looking for Repository Root string and aborting when it's missing or different than what we've already seen.
- 4:29 PM Changeset in webkit [45997] by
-
- 4 edits in trunk/WebCore
2009-07-16 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Added SHARED_WORKER flag to Windows build files, as well as associated .ccp/.h files.
Added missing V8 bindings to the AllInOne file
- WebCore.vcproj/WebCore.vcproj: Added missing files to build.
- bindings/v8/DerivedSourcesAllInOne.cpp: Added missing V8 bindings (V8AbstractWorker.cpp and V8SharedWorker.cpp)
- DerivedSources.cpp Added missing JS bindings (JSAbstractWorker.cpp and JSSharedWorker.cpp)
- 4:29 PM Changeset in webkit [45996] by
-
- 2 edits in trunk/WebCore
2009-07-16 John Abd-El-Malek <jam@chromium.org>
Reviewed by David Levin.
Add a getter in MessagePortChannel for the PlatformMessagePortChannel.
- dom/MessagePortChannel.h: (WebCore::MessagePortChannel::channel):
- 4:28 PM Changeset in webkit [45995] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-16 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Allow custom memory allocation control in ExceptionInfo and RareData struct
https://bugs.webkit.org/show_bug.cgi?id=27336
Inherits ExceptionInfo and RareData struct from FastAllocBase because these
have been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.cpp:1289 and
in JavaScriptCore/bytecode/CodeBlock.h:453.
- Remove unnecessary WTF
- namespace from CodeBlock inheritance.
- bytecode/CodeBlock.h:
- 4:25 PM Changeset in webkit [45994] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Fix accidentally blowing away a ChangeLog entry, plus a spurious comment
that no longer applied to the patch version I checked in.
- 3:55 PM Changeset in webkit [45993] by
-
- 15 edits in trunk
2009-07-16 Peter Kasting <pkasting@google.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=27323
Improve support for non-Cygwin SVNs on Windows, as well as WebKit
checkouts hosted inside other checkouts.
- Scripts/commit-log-editor: Modify regex so that trailing whitespace (e.g. \r) isn't included in filenames.
- Scripts/prepare-ChangeLog: Fix a case of adding "\n" to the ChangeLog without normalizing. Normalize file paths early instead of late so all stages of the script work. Modify regexes so that trailing whitespace (e.g. \r) isn't included in filenames.
- Scripts/svn-create-patch: Use a regex instead of chomp so we cut off line endings even if they don't match Perl's.
- 3:50 PM Changeset in webkit [45992] by
-
- 3 edits in trunk/WebKit/qt
2009-07-16 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Adam Treat.
Add new action to qwebpage to reload without cache.
- Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateNavigationActions): (QWebPage::triggerAction):
- Api/qwebpage.h:
- 3:43 PM Changeset in webkit [45991] by
-
- 25 edits in trunk
2009-07-16 Xiaomei Ji <xji@chromium.org>
Reviewed by Darin Adler.
Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187
Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.
WARNING: NO TEST CASES ADDED OR CHANGED
- WebCore.base.exp: Replace 2 names due to signature change.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::setToolTip): Add direction as 2nd parameter.
- page/Chrome.cpp: (WebCore::Chrome::setToolTip): Calculate tooltip direction as well and pass it to client to take care when display tooltip.
- page/ChromeClient.h: Add direction as 2nd parameter to pure virtual function setToolTip().
- page/chromium/ChromeClientChromium.h: (WebCore::ChromeClientChromium::setToolTip): Add setToolTip() temprarily to make chromium compile after pick up this webkit patch.
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Besides getting the spelling tooltip, get its directionality as well. (WebCore::HitTestResult::title): Besides getting the title, get its directionality as well.
- rendering/HitTestResult.h: Add 2 more methods.
2009-07-16 Xiaomei Ji <xji@chromium.org>
Reviewed by Darin Adler.
Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187
Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
- WebCoreSupport/ChromeClientGtk.h: Add directionality as 2nd parameter to setToolTip().
2009-07-16 Xiaomei Ji <xji@chromium.org>
Reviewed by Darin Adler.
Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187
Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.
- Misc/WebElementDictionary.mm: (-[WebElementDictionary _spellingToolTip]): Change spellingToolTip caller due to signature change. (-[WebElementDictionary _title]): Change title caller due to signature change.
- WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip().
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
2009-07-16 Xiaomei Ji <xji@chromium.org>
Reviewed by Darin Adler.
Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187
Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
- WebCoreSupport/ChromeClientQt.h: Add directionality as 2nd parameter to setToolTip().
2009-07-16 Xiaomei Ji <xji@chromium.org>
Reviewed by Darin Adler.
Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187
Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
- WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip().
- WebElementPropertyBag.cpp: (WebElementPropertyBag::Read): Change call of spellingToolTip() and title() due to signature change.
2009-07-16 Xiaomei Ji <xji@chromium.org>
Reviewed by Darin Adler.
Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187
Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
- WebKitSupport/ChromeClientWx.h: Add directionality as 2nd parameter to setToolTip().
- 3:36 PM Changeset in webkit [45990] by
-
- 2 edits in trunk/JavaScriptCore
Rubber-stamped by Geoff Garen.
Fix FeatureDefines.xcconfig to not be out of sync with the rest of the world.
- Configurations/FeatureDefines.xcconfig:
- 3:23 PM Changeset in webkit [45989] by
-
- 3 edits3 adds in trunk
2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Oliver Hunt.
[CAIRO] pattern of a canvas-element changes after modifications on canvas-element
https://bugs.webkit.org/show_bug.cgi?id=20578
Copy pixel image in ImageBuffer::image() just like CG and Skia glue.
- fast/canvas/canvas-pattern-modify-expected.txt: Added.
- fast/canvas/canvas-pattern-modify.html: Added.
- fast/canvas/canvas-pattern-modify.js: Added. (dataToArray): (getPixel): (pixelShouldBe): (createCanvasImage):
2009-07-16 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Oliver Hunt.
[CAIRO] pattern of a canvas-element changes after modifications on canvas-element
https://bugs.webkit.org/show_bug.cgi?id=20578
Copy pixel image in ImageBuffer::image() just like CG and Skia glue.
Test: fast/canvas/canvas-pattern-modify.html
- platform/graphics/cairo/ImageBufferCairo.cpp: (copySurface): (WebCore::ImageBuffer::image):
- 3:15 PM Changeset in webkit [45988] by
-
- 3 edits4 adds in trunk
WebCore:
2009-07-16 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
https://bugs.webkit.org/show_bug.cgi?id=27353
Images mispositioned because of bug in percentage-based relative positioning.
Added fast/css/nested-floating-relative-position-percentages.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX):
LayoutTests:
2009-07-16 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
https://bugs.webkit.org/show_bug.cgi?id=27353
Images mispositioned because of bug in percentage-based relative positioning.
- fast/css/nested-floating-relative-position-percentages.html: Added.
- platform/mac/fast/css/nested-floating-relative-position-percentages-expected.checksum: Added.
- platform/mac/fast/css/nested-floating-relative-position-percentages-expected.png: Added.
- platform/mac/fast/css/nested-floating-relative-position-percentages-expected.txt: Added.
- 3:02 PM Changeset in webkit [45987] by
-
- 3 edits2 adds in trunk
2009-07-16 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
A test for for non-multipart file upload form submission.
<https://bugs.webkit.org/show_bug.cgi?id=26505>
- fast/forms/get-file-upload-expected.txt: Added.
- fast/forms/get-file-upload.html: Added.
2009-07-16 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Sends the basename of a selected file for non-multipart form submission.
<https://bugs.webkit.org/show_bug.cgi?id=26505>
Test: fast/forms/get-file-upload.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData):
- 2:52 PM Changeset in webkit [45986] by
-
- 3 edits in trunk/WebCore
2009-07-16 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Video size sometimes jumps just after the video starts loading
https://bugs.webkit.org/show_bug.cgi?id=27352
Ensure that the media player is at or after the 'HaveMetadata' state so that
the instrinsic size is known before we create the layer for video. This avoids
a flash caused by computing the video rect using the default intrinsic size, and then
re-computing it when that size changes.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isReadyForRendering): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
- 2:17 PM Changeset in webkit [45985] by
-
- 2 edits in trunk/WebKitTools
2009-07-16 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Darin Adler.
WebKitTools/Scripts/svn-create-patch is broken
https://bugs.webkit.org/show_bug.cgi?id=27328
- Scripts/svn-create-patch: one line fix for unusual perl behavior
- 1:57 PM Changeset in webkit [45984] by
-
- 2 edits in trunk/LayoutTests/http/tests/security/isolatedWorld
Unreviewed typo fix in two tests.
- 1:26 PM Changeset in webkit [45983] by
-
- 5 edits31 adds in trunk/LayoutTests
2009-07-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Add tests for isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27331
These tests are currently disabled on JSC ports.
- http/tests/security/isolatedWorld/all-window-properties-expected.txt: Added.
- http/tests/security/isolatedWorld/all-window-properties.html: Added.
- http/tests/security/isolatedWorld/all-window-prototypes-expected.txt: Added.
- http/tests/security/isolatedWorld/all-window-prototypes.html: Added.
- http/tests/security/isolatedWorld/body-properties-expected.txt: Added.
- http/tests/security/isolatedWorld/body-properties.html: Added.
- http/tests/security/isolatedWorld/body-prototype-expected.txt: Added.
- http/tests/security/isolatedWorld/body-prototype.html: Added.
- http/tests/security/isolatedWorld/document-properties-expected.txt: Added.
- http/tests/security/isolatedWorld/document-properties.html: Added.
- http/tests/security/isolatedWorld/document-prototype-expected.txt: Added.
- http/tests/security/isolatedWorld/document-prototype.html: Added.
- http/tests/security/isolatedWorld/global-variables-expected.txt: Added.
- http/tests/security/isolatedWorld/global-variables.html: Added.
- http/tests/security/isolatedWorld/image-properties-expected.txt: Added.
- http/tests/security/isolatedWorld/image-properties.html: Added.
- http/tests/security/isolatedWorld/image-prototype-expected.txt: Added.
- http/tests/security/isolatedWorld/image-prototype.html: Added.
- http/tests/security/isolatedWorld/location-properties-expected.txt: Added.
- http/tests/security/isolatedWorld/location-properties.html: Added.
- http/tests/security/isolatedWorld/location-prototype-expected.txt: Added.
- http/tests/security/isolatedWorld/location-prototype.html: Added.
- http/tests/security/isolatedWorld/number-prototype-expected.txt: Added.
- http/tests/security/isolatedWorld/number-prototype.html: Added.
- http/tests/security/isolatedWorld/object-prototype-expected.txt: Added.
- http/tests/security/isolatedWorld/object-prototype.html: Added.
- http/tests/security/isolatedWorld/string-prototype-expected.txt: Added.
- http/tests/security/isolatedWorld/string-prototype.html: Added.
- http/tests/security/isolatedWorld/window-properties-expected.txt: Added.
- http/tests/security/isolatedWorld/window-properties.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:01 PM Changeset in webkit [45982] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r45979.
- 12:23 PM Changeset in webkit [45981] by
-
- 3 edits in trunk/WebKitTools
2009-07-16 David Levin <levin@chromium.org>
Reviewed by David Kilzer.
cpplint should check for equality comparisons to 0/true/false
https://bugs.webkit.org/show_bug.cgi?id=27333
- Scripts/modules/cpplint.py: Added the new lint check.
- Scripts/modules/cpplint_unittest.py: Add tests for the new lint check and fix a regex that in another unit test that caused it to fail when you have a directory with a number in it (like WebKit-2)
- 11:36 AM Changeset in webkit [45980] by
-
- 1 edit7 adds in trunk/WebKitSite
2009-07-16 Simon Fraser <Simon Fraser>
New demo files for an up-coming blog post.
- blog-files/3d-transforms/mighty-cubes.png: Added.
- blog-files/3d-transforms/morphing-cubes.html: Added.
- blog-files/3d-transforms/perspective-by-example.html: Added.
- blog-files/3d-transforms/poster-circle.html: Added.
- blog-files/3d-transforms/poster-circle.png: Added.
- blog-files/3d-transforms/transform-style.html: Added.
- 11:35 AM Changeset in webkit [45979] by
-
- 2 edits in trunk/WebCore
2009-07-16 Brady Eidson <beidson@apple.com>
Reviewed by Antti Koivisto.
Patch by Brady Eidson and Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=26496
<rdar://problem/7065391> Microsoft Outlook Web Access fails because XHR stream connection blocks script loading/revalidation
After refreshing a page and when all CachedResources on that page are in validation mode, they got an exemption
from the connection-per-host limit. Removing that exemption makes the test case load smoothly after reloads.
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): Remove the resourceIsCacheValidator exemption to the connection-per-host limit.
- 10:26 AM Changeset in webkit [45978] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/27241> bugzilla-tool post-commits silently fails with bad args
Reviewed by Eric Seidel.
- Scripts/bugzilla-tool: (PostCommitsAsPatchesToBug.execute): Added more error checking when consuming arguments.
- 10:21 AM Changeset in webkit [45977] by
-
- 2 edits in trunk/WebCore
2009-07-16 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] V8IsolatedWorld::evaluate needs to call didCreateIsolatedScriptContext
https://bugs.webkit.org/show_bug.cgi?id=27335
evaluateInNewContext makes this delegate call. evaluateInNewWorld
needs to make the same call. This does not appear to be testable with
our current technology.
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::evaluate):
- 10:19 AM Changeset in webkit [45976] by
-
- 2 edits in trunk/WebKitTools
TOOL FIX: scm.py: CommitMessage.message is ambiguous
Fixes this error when running bugzilla-tool apply-patches
--local-commit:
File "bugzilla-tool", line 188, in apply_patches
scm.commit_locally_with_message(commit_message.message() or patchname)
TypeError: 'list' object is not callable
- 9:43 AM Changeset in webkit [45975] by
-
- 2 edits in trunk
2009-07-16 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Enable GNU compiler extensions to the ARM compiler
for all Qt ports using RVCT
https://bugs.webkit.org/show_bug.cgi?id=27348
- WebKit.pri:
- 8:43 AM Changeset in webkit [45974] by
-
- 2 edits in trunk/WebCore
2009-07-15 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Fix a typo: application/atom=xml -> application/atom+xml.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
- 8:10 AM Changeset in webkit [45973] by
-
- 6 edits in trunk
WebCore:
2009-07-16 Dean McNamee <deanm@chromium.org>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=27292
Improve handling of <canvas> path operations on an empty path.
Implement Skia's Path::hasCurrentPoint().
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::lineTo): (WebCore::CanvasRenderingContext2D::quadraticCurveTo): (WebCore::CanvasRenderingContext2D::bezierCurveTo):
- platform/graphics/skia/PathSkia.cpp: (WebCore::Path::hasCurrentPoint):
LayoutTests:
2009-07-16 Dean McNamee <deanm@chromium.org>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=27292
Improve handling of <canvas> path operations on an empty path.
Implement Skia's Path::hasCurrentPoint().
- fast/canvas/canvas-modify-emptyPath-expected.txt:
- fast/canvas/resources/canvas-modify-emptyPath.js:
- 7:13 AM Changeset in webkit [45972] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-16 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27320
_countof is only included in CE6; for CE5 we need to define it ourself
- wtf/Platform.h:
- 6:43 AM Changeset in webkit [45971] by
-
- 2 edits in trunk/WebKitTools
TOOL FIX: bugzilla-tool: import CommitMessage class
- Scripts/bugzilla-tool: After r45940, the CommitMessage class needs to be imported for commit_message_for_this_commit().
- 6:15 AM Changeset in webkit [45970] by
-
- 2 edits in trunk/LayoutTests
2009-07-16 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Adam Treat.
Skip two tests for the Qt DRT to keep the results green.
fast/js/instanceof-operator.html because it requires XSLT support.
editing/selection/extend-selection-after-double-click.html needs
investigation for the Qt port after r45945
- platform/qt/Skipped:
- 4:16 AM Changeset in webkit [45969] by
-
- 4 edits in trunk/JavaScriptCore
2009-07-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Workers + garbage collector: weird crashes
https://bugs.webkit.org/show_bug.cgi?id=27077
We need to unlink cached method call sites when a function is destroyed.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::unlinkCallers):
- jit/JIT.cpp: (JSC::JIT::unlinkMethodCall):
- jit/JIT.h:
- 1:17 AM Changeset in webkit [45968] by
-
- 2 edits in trunk/WebKitTools
2009-07-16 David Levin <levin@chromium.org>
Reviewed by Maciej Stachowiak.
prepare-ChangeLog should display the --bug option in its help text.
https://bugs.webkit.org/show_bug.cgi?id=27334
- Scripts/prepare-ChangeLog: Added the help text.
Jul 15, 2009:
- 11:10 PM Changeset in webkit [45967] by
-
- 2 edits in trunk/LayoutTests
2009-07-15 David Levin <levin@chromium.org>
Rubber-stamped by Oliver Hunt.
Setting white-space and word-wrap via CSS in textarea doesn't override the wrap attribute
https://bugs.webkit.org/show_bug.cgi?id=26254
Change the expected Windows result (similar to the mac result change).
- platform/win/fast/forms/basic-textareas-expected.txt:
- 10:32 PM Changeset in webkit [45966] by
-
- 9 edits in trunk
2009-07-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Setting white-space and word-wrap via CSS in textarea doesn't override the wrap attribute
https://bugs.webkit.org/show_bug.cgi?id=26254
WebCore:
Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.
This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.
Committer note: Earlier I reverted this change because I did it incorrectly
by leaving out css/html.css. In the patch, the filename was the old name
css/html4.css and that led to my error.
- css/html.css:
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
LayoutTests:
Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.
This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.
- fast/forms/basic-textareas.html:
- platform/mac/fast/forms/basic-textareas-expected.checksum:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- 10:03 PM Changeset in webkit [45965] by
-
- 2 edits in trunk/WebCore
2009-07-15 James Hawkins <jhawkins@google.com>
Reviewed by Adam Barth.
[V8] Remove a local variable that is shadowing a function parameter.
https://bugs.webkit.org/show_bug.cgi?id=27309
No test required as this modification does not change the current behavior.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- 7:28 PM Changeset in webkit [45964] by
-
- 3 edits2 deletes in trunk/WebCore
2009-07-15 Adam Langley <agl@google.com>
No review: reverting previous change.
Revert r45959:
2009-07-15 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Adding the Win SQLite VFS implementation for Chromium.
The Chromium side of this patch was landed in 20839, but broke the build. It
was reverted in r20840. Thus, I'm reverting this side of the patch too.
- WebCore.gypi:
- platform/chromium/ChromiumBridge.h:
- platform/sql/chromium/SQLiteFileSystemChromium.cpp: Removed.
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Removed.
- 5:14 PM Changeset in webkit [45963] by
-
- 8 edits in trunk
WebCore:
2009-07-15 David Levin <levin@chromium.org>
Layout test fix, reverting previous change.
Reverting r45962 as it caused several layout test failures.
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
LayoutTests:
2009-07-15 David Levin <levin@chromium.org>
Layout test fix, reverting previous change.
Reverting r45962 as it caused several layout test failures.
- fast/forms/basic-textareas.html:
- platform/mac/fast/forms/basic-textareas-expected.checksum:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- 4:46 PM Changeset in webkit [45962] by
-
- 8 edits in trunk
2009-06-08 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Setting white-space and word-wrap via CSS in textarea doesn't override the wrap attribute
https://bugs.webkit.org/show_bug.cgi?id=26254
WebCore:
Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.
This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.
- css/html4.css:
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
LayoutTests:
Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.
This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.
- fast/forms/basic-textareas.html:
- platform/mac/fast/forms/basic-textareas-expected.checksum:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- 4:35 PM Changeset in webkit [45961] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:34 PM Changeset in webkit [45960] by
-
- 1 copy in tags/Safari-6531.5
New tag.
- 4:18 PM Changeset in webkit [45959] by
-
- 3 edits3 adds in trunk/WebCore
2009-07-15 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Adding the Win SQLite VFS implementation for Chromium.
- 4:15 PM Changeset in webkit [45958] by
-
- 13 edits in trunk
WebCore:
2009-07-15 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Bug 25151 - workers that fail to load scripts not firing error event.
https://bugs.webkit.org/show_bug.cgi?id=25151
This fixes the problem that an error event is not fired when the worker
script fails to load. Some reasons this may occur are an invalid URL for
the worker script or a cross-origin redirect.
We also moves the code to complete the URL and check its origin from
Worker constructor to WorkerScriptLoader loading functions in order to
move the exception throwing logic out of the scope of Worker constructor.
Due to this change, we also remove the output ExceptionCode parameter
in the worker constructor. Corresponding JS/V8 binding codes have been
updated to reflect this change.
- bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
- workers/Worker.h: (WebCore::Worker::create):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
- workers/WorkerScriptLoader.cpp: (WebCore::toCrossOriginRedirectPolicy): (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::notifyLoadErrorTask): (WebCore::WorkerScriptLoader::createResourceRequest): (WebCore::WorkerScriptLoader::didFail): (WebCore::WorkerScriptLoader::didFailRedirectCheck): (WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation): (WebCore::WorkerScriptLoader::notifyError):
- workers/WorkerScriptLoader.h: (WebCore::): (WebCore::WorkerScriptLoader::url):
LayoutTests:
2009-07-15 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Bug 25151 - workers that fail to load scripts not firing error event.
https://bugs.webkit.org/show_bug.cgi?id=25151
Updates layout test cases for bug 25151.
- fast/workers/worker-constructor-expected.txt:
- fast/workers/worker-constructor.html:
- http/tests/workers/worker-redirect-expected.txt:
- http/tests/workers/worker-redirect.html:
- 4:11 PM Changeset in webkit [45957] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:11 PM Changeset in webkit [45956] by
-
- 5 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
text-shadow is not drawn for text with transparent colour
https://bugs.webkit.org/show_bug.cgi?id=21374
Test: fast/text/shadow-translucent-fill.html
- rendering/InlineTextBox.cpp: (WebCore::paintTextWithShadows): If the text fill color is not opaque, paint all shadows separately from the text, by casting them from clipped-out opaque text.
LayoutTests:
Reviewed by Dave Hyatt.
text-shadow is not drawn for text with transparent colour
https://bugs.webkit.org/show_bug.cgi?id=21374
- fast/text/shadow-translucent-fill.html: Added.
- platform/mac/fast/css/shadow-multiple-expected.checksum:
- platform/mac/fast/css/shadow-multiple-expected.png:
- platform/mac/fast/text/shadow-translucent-fill-expected.checksum: Added.
- platform/mac/fast/text/shadow-translucent-fill-expected.png: Added.
- platform/mac/fast/text/shadow-translucent-fill-expected.txt: Added.
- 4:02 PM Changeset in webkit [45955] by
-
- 2 edits in trunk/WebCore
2009-07-15 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build.
- html/HTMLAreaElement.cpp:
- 3:56 PM Changeset in webkit [45954] by
-
- 18 edits in trunk/WebCore
2009-07-15 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180
DOM Storage had several unnecessary (and probably unintended)
dependencies. This patch replaces many includes of header files with
forward declaration of classes, making some destructors explicit, and
taking some factories out of the header files.
This will allow things like StorageAreaSync to take a StorageAreaImpl*
(as it should) rather than a StorageArea* which previously weren't
possible because the dependencies were such a tangled mess.
- storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::~LocalStorageTask):
- storage/LocalStorageTask.h:
- storage/Storage.cpp: (WebCore::Storage::~Storage):
- storage/Storage.h:
- storage/StorageArea.cpp:
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp:
- storage/StorageAreaImpl.h:
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::~StorageAreaSync):
- storage/StorageAreaSync.h:
- storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
- storage/StorageEvent.h:
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp:
- storage/StorageNamespaceImpl.h:
- storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::~StorageSyncManager):
- storage/StorageSyncManager.h:
- 3:33 PM Changeset in webkit [45953] by
-
- 3 edits2 adds in trunk
Incorrect animation when trying to duplicate effect of transform-origin
The bug is that matrix animation is being used when animating
a list of transform functions that match in the from and to states.
This sometimes works. But because of the way CA does matrix animation
function lists like the one shown in the testcase animate incorrectly.
This fixes the bug by always doing component animation
as long as the function lists match. This allows CA
to animate the components and then recompose the result
into the correct matrix.
- 3:29 PM Changeset in webkit [45952] by
-
- 2 edits in trunk/WebCore
2009-07-15 Albert J. Wong <ajwong@chromium.org>
Reviewed by David Levin.
Upstream the V8NPObject and NPV8Object build changes for WebCore.gypi.
Add upstreamed V8 bindings files into WebCore.gypi so they can be seen
downstream
https://bugs.webkit.org/show_bug.cgi?id=27274
Changes the build file for chromium. Test built the chromium tree
to verify.
- WebCore.gypi:
- 3:24 PM Changeset in webkit [45951] by
-
- 2 edits in trunk/WebCore
I like it when the code compiles.
- WebCore.base.exp:
- 3:07 PM Changeset in webkit [45950] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge 45949.
- 3:02 PM Changeset in webkit [45949] by
-
- 3 edits in trunk/JavaScriptCore
2009-07-15 Steve Falkenburg <sfalken@apple.com>
Windows Build fix.
Visual Studio reset our intermediate directory on us.
This sets it back.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/testapi/testapi.vcproj:
- 2:56 PM Changeset in webkit [45948] by
-
- 16 edits in branches/safari-4-branch
Merge r45892.
- 2:50 PM Changeset in webkit [45947] by
-
- 40 edits in trunk
WebCore:
2009-07-15 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Renamed parseURL to deprecatedParseURL.
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Renamed.
- bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Renamed.
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Renamed.
- bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Renamed.
- bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]): Renamed.
- bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Renamed.
- bindings/v8/custom/V8CustomBinding.cpp: (WebCore::allowSettingFrameSrcToJavascriptUrl): Renamed.
- css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Renamed.
- css/CSSHelper.h: Renamed and updated comment.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Renamed. (WebCore::HTMLAnchorElement::parseMappedAttribute): Renamed.
- html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::parseMappedAttribute): Renamed.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Renamed.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Renamed.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::parseMappedAttribute): Renamed.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Renamed.
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Renamed.
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::sourceURI): Renamed.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): Renamed.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): Renamed.
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): Renamed.
- html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute): Renamed.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Renamed.
- html/PreloadScanner.cpp: (WebCore::PreloadScanner::processAttribute): Renamed. (WebCore::PreloadScanner::emitCSSRule): Renamed.
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage): Renamed.
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage): Renamed.
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage): Renamed.
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage): Renamed.
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Renamed. (WebCore::HitTestResult::absoluteMediaURL): Renamed. (WebCore::HitTestResult::absoluteLinkURL): Renamed.
- svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): Renamed.
- svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI): Renamed.
- wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler): Renamed.
- wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Renamed.
WebKit/mac:
2009-07-15 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Renamed parseURL to deprecatedParseURL.
- DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]): Renamed.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Renamed.
WebKit/win:
2009-07-15 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Renamed parseURL to deprecatedParseURL.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Renamed.
WebKitTools:
2009-07-15 Darin Adler <Darin Adler>
- Scripts/do-webcore-rename: Check in the version used to rename parseURL to deprecatedParseURL.
- 2:44 PM Changeset in webkit [45946] by
-
- 6 edits2 adds in trunk
WebCore:
2009-07-15 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
CSSHelper.h's parseURL is a function that no one should ever call
Part 1: Eliminate callers in the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=26599
Test: fast/css/uri-token-parsing.html
- css/CSSHelper.h: Added a comment explaining why nobody should ever call this function. A FIXME suggests a next step, which would be to rename it deprecatedParseURL.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Removed unneeded call to parseURL; CSSParser::text already takes care of parsing the URI token syntax, and the parseURL function does no good. (WebCore::CSSParser::parseContent): Ditto. (WebCore::CSSParser::parseFillImage): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseBorderImage): Ditto. (WebCore::isCSSWhitespace): Added. Helper function that makes the text function easier to read. (WebCore::CSSParser::text): Tweak logic so that leading and trailing whitespace are both trimmed before removing the quote marks. Changed to use the isCSSWhitespace, isASCIIHexDigit, and toASCIIHexValue functions for clarity.
- css/CSSParser.h: Removed stray "public:" in this header.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::substring): Optimized the case where the substring covers the entire string, so we just share the StringImpl instead of making a new one. This case came up in earlier versions of the CSS parser changes above. (WebCore::StringImpl::substringCopy): Streamlined the logic here and made it not call substring any more. Before, this was relying on the substring function always making a copy of any non-empty substring.
LayoutTests:
2009-07-15 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
CSSHelper.h's parseURL is a function that no one should ever call
Part 1: Eliminate callers in the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=26599
- fast/css/uri-token-parsing-expected.txt: Added.
- fast/css/uri-token-parsing.html: Added. Tests URI token parsing cases, many of which were handled wrong before due to stripping quotes and URL() twice.
- 2:35 PM Changeset in webkit [45945] by
-
- 3 edits1 copy1 add in trunk
WebCore:
2009-07-15 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
After double-clicking a word, using Shift-arrow to select behaves unpredictably
https://bugs.webkit.org/show_bug.cgi?id=27177
rdar://problem/7034324
Test: editing/selection/extend-selection-after-double-click.html
The bug was due to the m_lastChangeWasHorizontalExtension flag, which was not
being cleared in many cases where it should have been.
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Set m_lastChangeWasHorizontalExtension to false. This catches all sorts of cases that don't flow through the modify function. Before, the flag would reflect the last call to the modify function, which was not necessarily the last selection change. (WebCore::SelectionController::willBeModified): Rearrange function for clarity. Remove code that sets m_lastChangeWasHorizontalExtension; that is now handled elsewhere. (WebCore::SelectionController::modify): Call setLastChangeWasHorizontalExtension after setSelection when setting up a trial selection controller, since setSelection now clears that flag. Also changed both trial selection controller cases to set the flag, although it's not strictly necessary in both cases. Added code to set m_lastChangeWasHorizontalExtension when extending the selection, which used to be handled in willBeModified. Now we need to do it after the selection change.
LayoutTests:
2009-07-15 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
After double-clicking a word, using Shift-arrow to select behaves unpredictably
https://bugs.webkit.org/show_bug.cgi?id=27177
rdar://problem/7034324
- editing/selection/extend-selection-after-double-click-expected.txt: Added.
- editing/selection/extend-selection-after-double-click.html: Copied from LayoutTests/editing/selection/word-granularity.html. Then turned it into a new test.
- 2:16 PM Changeset in webkit [45944] by
-
- 2 edits in trunk/WebCore
2009-07-15 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Need to update DOM Storage files in GYPI file.
https://bugs.webkit.org/show_bug.cgi?id=27317
Need to update DOM Storage files in the GYPI file. They're pretty out
of date and we're on the path towards enabling them for everyone!
- WebCore.gypi:
- 1:55 PM Changeset in webkit [45943] by
-
- 5 edits in trunk
2009-07-15 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26794
Make Yacc-generated parsers to use fastMalloc/fastFree.
Define YYMALLOC and YYFREE to fastMalloc and fastFree
respectively.
- parser/Grammar.y:
WebCore:
2009-07-15 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26794
Make Yacc-generated parsers to use fastMalloc/fastFree.
Define YYMALLOC and YYFREE to fastMalloc and fastFree
respectively.
- css/CSSGrammar.y:
- xml/XPathGrammar.y:
- 1:49 PM Changeset in webkit [45942] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Jan Alonzo.
Fix enable-xss-auditor property documentation, and default value
to match the fact that it is now enabled by default.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- 1:43 PM Changeset in webkit [45941] by
-
- 11 edits in trunk
WebCore:
2009-07-15 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=27193
Don't run in to anonymous blocks. No other browsers do this, and our implementation of run-in
is effectively broken as a result.
No new tests. Changed fast/runin/001.html and fast/runin/generated.html to match new behavior.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
LayoutTests:
2009-07-15 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=27193
Don't let run-ins run in to anonymous blocks.
- fast/runin/001.html:
- fast/runin/generated.html:
- platform/mac/fast/runin/001-expected.checksum:
- platform/mac/fast/runin/001-expected.png:
- platform/mac/fast/runin/001-expected.txt:
- platform/mac/fast/runin/generated-expected.checksum:
- platform/mac/fast/runin/generated-expected.png:
- platform/mac/fast/runin/generated-expected.txt:
- 1:15 PM Changeset in webkit [45940] by
-
- 3 edits in trunk/WebKitTools
2009-07-10 David Kilzer <ddkilzer@apple.com>
bugzilla-tool: create CommitMessage class
Reviewed by Eric Seidel.
Create a CommitMessage class to encapsulate related code.
- Scripts/bugzilla-tool: (bug_id_from_commit_message): Moved to CommitMessage.parse_bug_id(). (commit_message_for_this_commit): Return a CommitMessage. (ApplyPatchesFromBug.apply_patches): Use CommitMessage.message(). (LandPatchesFromBugs.build_and_commit): Ditto. (CommitMessageForCurrentDiff.execute): Ditto. (PostCommitsAsPatchesToBug.execute): Switched from Git.commit_message_for_commit() to Git.commit_message_for_local_commit(). Switched from bug_id_from_commit_message() to CommitMessage.parse_bug_id().
- Scripts/modules/scm.py: (first_non_empty_line_after_index): Added. (CommitMessage.init): Added. (CommitMessage.body): Added. (CommitMessage.description): Added. (CommitMessage.message): Added. (CommitMessage.parse_bug_id): Added. Moved from bug_id_from_commit_message() in bugzilla-tool. (Git.commit_message_for_local_commit): Renamed from commit_message_for_commit(). Return a CommitMessage.
- 1:11 PM Changeset in webkit [45939] by
-
- 2 edits in trunk/WebKitTools
2009-07-15 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by David Kilzer.
bugzilla-tool/svn-apply can't handle patches made from a non-root directory
https://bugs.webkit.org/show_bug.cgi?id=26999
- Scripts/svn-create-patch:
- 1:08 PM Changeset in webkit [45938] by
-
- 21 edits4 adds in trunk
WebCore:
2009-07-15 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Test: fast/js/instanceof-operator.html
Fix for: Bug 25205 - XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205
In addition to for XMLHttpRequest, this also fixes for:
- Audio
- Image
- MessageChannel
- Option
- WebKitCSSMatrix
- WebKitPoint
- Worker
- XSLTProcessor
- bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
- bindings/js/JSAudioConstructor.h:
- bindings/js/JSDOMBinding.h: (WebCore::DOMConstructorObject::createStructure): (WebCore::DOMConstructorObject::DOMConstructorObject):
- bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
- bindings/js/JSImageConstructor.h:
- bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
- bindings/js/JSMessageChannelConstructor.h:
- bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
- bindings/js/JSOptionConstructor.h:
- bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
- bindings/js/JSWebKitCSSMatrixConstructor.h:
- bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
- bindings/js/JSWebKitPointConstructor.h:
- bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
- bindings/js/JSWorkerConstructor.h:
- bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
- bindings/js/JSXMLHttpRequestConstructor.h:
- bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
- bindings/js/JSXSLTProcessorConstructor.h:
LayoutTests:
2009-07-15 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Fix for: Bug 25205 - XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205
In addition to for XMLHttpRequest, this also fixes for:
- Audio
- Image
- MessageChannel
- Option
- WebKitCSSMatrix
- WebKitPoint
- Worker
- XSLTProcessor
- fast/js/instanceof-operator-expected.txt: Added.
- fast/js/instanceof-operator.html: Added.
- fast/js/resources/instanceof-operator-dummy-worker.js: Added.
- fast/js/resources/instanceof-operator.js: Added.
- 12:51 PM Changeset in webkit [45937] by
-
- 5 edits4 adds in trunk
WebCore:
2009-07-15 Kai Bruning <kai@granus.net>
Reviewed by Dave Hyatt.
CSS21 attribute selectors not dynamic for xml.
https://bugs.webkit.org/show_bug.cgi?id=25072
Moved the relevant test in StyledElement::attributeChanged()
to a new function Element::recalcStyleIfNeededAfterAttributeChanged()
so it can be called from both StyledElement::attributeChanged()
and Element::attributeChanged().
Refactored Element::attributeChanged() into
Element::updateAfterAttributeChanged() and
Element::recalcStyleIfNeededAfterAttributeChanged(), which are called
separately from StyledElement::attributeChanged().
Test: fast/css/attribute-selector-dynamic.xml
- dom/Element.cpp: (WebCore::Element::attributeChanged): (WebCore::Element::updateAfterAttributeChanged): (WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):
- dom/Element.h:
- dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):
LayoutTests:
2009-07-15 Kai Bruning <kai@granus.net>
Reviewed by Dave Hyatt.
CSS21 attribute selectors not dynamic for xml.
https://bugs.webkit.org/show_bug.cgi?id=25072
Test that CSS21 attribute selectors take effect when the attribute is
dynamically changed in an xml dom.
- fast/css/attribute-selector-dynamic.xml: Added.
- platform/mac/fast/css/attribute-selector-dynamic-expected.checksum: Added.
- platform/mac/fast/css/attribute-selector-dynamic-expected.png: Added.
- platform/mac/fast/css/attribute-selector-dynamic-expected.txt: Added.
- 12:27 PM Changeset in webkit [45936] by
-
- 2 edits in trunk/WebCore
2009-07-15 Alpha Lam <hclam@chromium.org>
Reviewed by David Levin.
[V8] Layout test failures for drawImage in Canvas
https://bugs.webkit.org/show_bug.cgi?id=27311
Fixing several canvas layout tests failures due to a
missing return statement in CanvasRenderingContext2DDrawImage() which
was accidentally removed in r45929.
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
- 12:16 PM Changeset in webkit [45935] by
-
- 2 edits in trunk/WebCore
2009-07-15 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
If the httpMethod() of the request passed to SubresourceLoader::create is not
supported by the client we must expect to call didFail() while m_loader is still null.
- loader/DocumentThreadableLoader.cpp: (DocumentThreadableLoader::didFail):Changed.
- 11:34 AM Changeset in webkit [45934] by
-
- 2 edits in trunk/WebKitSite
2009-07-15 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Sam Weinig.
Side bar linking to "DOM Interfaces" returns 404
https://bugs.webkit.org/show_bug.cgi?id=24000
- nav.inc:
- 11:28 AM Changeset in webkit [45933] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-15 Darin Adler <Darin Adler>
Fix a build for a particular Apple configuration.
- wtf/FastAllocBase.h: Change include to use "" style for including another wtf header. This is the style we use for including other public headers in the same directory.
- 11:25 AM Changeset in webkit [45932] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add bug link to changelog entry.
- 11:23 AM Changeset in webkit [45931] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-15 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=27303
Implement createThreadInternal for WinCE.
Contains changes by George Staikos <george.staikos@torchmobile.com> and Joe Mason <joe.mason@torchmobile.com>
- wtf/ThreadingWin.cpp: (WTF::createThreadInternal):
- 11:22 AM Changeset in webkit [45930] by
-
- 6 edits in trunk/WebCore
Fix the Mac build.
- WebCore.base.exp:
- css/MediaQueryEvaluator.cpp:
- rendering/SVGRenderTreeAsText.cpp:
- rendering/style/SVGRenderStyle.cpp:
- svg/graphics/SVGPaintServer.cpp:
- 11:21 AM Changeset in webkit [45929] by
-
- 2 edits in trunk/WebCore
2009-07-15 Alpha Lam <hclam@chromium.org>
Reviewed by Dimitri Glazkov.
Changed CanvasRenderingContext2DDrawImage() to accept HTMLVideoElement
as a parameter of drawImage() for HTMLCanvasElement.
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
- 11:14 AM Changeset in webkit [45928] by
-
- 7 edits in trunk/WebCore
2009-07-15 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Fix isolated world constructors
https://bugs.webkit.org/show_bug.cgi?id=27287
Don't enter V8Proxy::m_context before creating DOM constructors.
Instead, use getWrapperContext to get the right context.
After this patch, all my tests pass. I'll enable the feature
downstream and land the tests.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::lookupDOMWrapper):
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::evaluate):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createWrapperFromCache): (WebCore::V8Proxy::isContextInitialized): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::installDOMWindow): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::getHiddenObjectPrototype): (WebCore::V8Proxy::installHiddenObjectPrototype):
- bindings/v8/V8Proxy.h:
- 11:12 AM Changeset in webkit [45927] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-15 Joe Mason <joe.mason@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27298
Platform defines for WINCE.
Contains changes by Yong Li <yong.li@torchmobile.com>,
George Staikos <george.staikos@torchmobile.com> and Joe Mason <joe.mason@torchmobile.com>
- wtf/Platform.h:
- 11:07 AM Changeset in webkit [45926] by
-
- 2 edits in trunk/WebCore
2009-07-15 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Darin Adler.
useless null-check statement in visible_units.cpp@logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=27154
Simple fix.
- editing/visible_units.cpp: (WebCore::logicalStartOfLine): Doubled honorEditableBoundaryAtOrAfter() call removed.
- 10:44 AM Changeset in webkit [45925] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
Attempted Mac Build Fix.
- 10:34 AM Changeset in webkit [45924] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-15 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=27306
Use RegisterClass instead of RegisterClassEx on WinCE.
- wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):
- 10:32 AM Changeset in webkit [45923] by
-
- 12 edits in trunk
WebCore:
2009-07-15 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27304
WebKit should provide usage and eligibility information about the page cache.
- WebCore.base.exp:
- history/CachedFrame.cpp: (WebCore::CachedFrame::childFrameCount):
- history/CachedFrame.h:
- history/PageCache.cpp: (WebCore::PageCache::frameCount): (WebCore::PageCache::autoreleasedPageCount):
- history/PageCache.h: (WebCore::PageCache::pageCount):
WebKit/mac:
2009-07-15 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27304
WebKit should provide usage and eligibility information about the page cache.
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm: (+[WebCoreStatistics numberCachedPages]): (+[WebCoreStatistics numberCachedFrames]): (+[WebCoreStatistics numberAutoreleasedPages]):
- WebKit.exp:
- WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): Returns a dictionary with all the data about why the frame is not cacheable. If the frame *is* cacheable, the dictionary is empty.
- WebView/WebFramePrivate.h:
- 10:31 AM Changeset in webkit [45922] by
-
- 2 edits in trunk/WebCore
2009-07-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
Chromium's canvas forgets its context after fillText again
https://bugs.webkit.org/show_bug.cgi?id=27293
No new tests because the test for this was already added in
https://bugs.webkit.org/show_bug.cgi?id=26436
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite):
- 10:20 AM Changeset in webkit [45921] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-15 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27301
Use OutputDebugStringW on WinCE since OutputDebugStringA is not supported
Originally written by Yong Li <yong.li@torchmobile.com> and refactored by
Joe Mason <joe.mason@torchmobile.com>
- wtf/Assertions.cpp: vprintf_stderr_common
- 10:07 AM Changeset in webkit [45920] by
-
- 1 edit2 moves in trunk/WebKitTools
2009-07-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
Move cpplint.py to module directory
https://bugs.webkit.org/show_bug.cgi?id=27302
- Scripts/modules/cpplint.py: Renamed from WebKitTools/Scripts/cpplint.py.
- Scripts/modules/cpplint_unittest.py: Renamed from WebKitTools/Scripts/cpplint_unittest.py.
- 10:02 AM Changeset in webkit [45919] by
-
- 19 edits10 adds in trunk
WebCore:
2009-07-14 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Implement the new 'rem' unit from CSS3.
Added some rem-* tests in fast/css.
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::validUnit): (WebCore::unitFromString): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::lex):
- css/CSSParserValues.cpp: (WebCore::CSSParserValue::createCSSValue):
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthInt): (WebCore::CSSPrimitiveValue::computeLengthIntForLength): (WebCore::CSSPrimitiveValue::computeLengthShort): (WebCore::CSSPrimitiveValue::computeLengthFloat): (WebCore::CSSPrimitiveValue::computeLengthDouble): (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::isUnitTypeLength):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition): (WebCore::CSSStyleSelector::createTransformOperations):
- css/CSSStyleSelector.h:
- css/MediaQueryEvaluator.cpp: (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval):
- css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::setMatrixValue):
- css/tokenizer.flex:
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h: (WebCore::Document::usesRemUnits): (WebCore::Document::setUsesRemUnits):
- dom/Element.cpp: (WebCore::Element::recalcStyle):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
- rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::cssPrimitiveToLength):
- svg/graphics/SVGPaintServer.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::dashArrayFromRenderingStyle):
- svg/graphics/SVGPaintServer.h:
LayoutTests:
2009-07-14 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Add layout tests for the new CSS3 'rem' unit type.
- fast/css/rem-dynamic-scaling.html: Added.
- fast/css/rem-units-on-root.html: Added.
- fast/css/remove-shorthand-expected.checksum: Added.
- fast/css/remove-shorthand-expected.png: Added.
- platform/mac/fast/css/rem-dynamic-scaling-expected.checksum: Added.
- platform/mac/fast/css/rem-dynamic-scaling-expected.png: Added.
- platform/mac/fast/css/rem-dynamic-scaling-expected.txt: Added.
- platform/mac/fast/css/rem-units-on-root-expected.checksum: Added.
- platform/mac/fast/css/rem-units-on-root-expected.png: Added.
- platform/mac/fast/css/rem-units-on-root-expected.txt: Added.
- 9:58 AM Changeset in webkit [45918] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-15 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27020
msToGregorianDateTime should set utcOffset to 0 when outputIsUTC is false
- wtf/DateMath.cpp: (WTF::gregorianDateTimeToMS):
- 9:56 AM Changeset in webkit [45917] by
-
- 2 edits in trunk/LayoutTests
2009-07-15 Brian Weinstein <bweinstein@apple.com>
Rubberstamped by Mark Rowe.
Add one more test to Windows Skipped List to hopefully get it to stay green.
- platform/win/Skipped:
- 9:27 AM Changeset in webkit [45916] by
-
- 2 edits in trunk/WebCore
2009-07-15 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Remove extraneous qualifier, accidentally added in http://trac.webkit.org/changeset/45884.
- bindings/v8/V8DOMWrapper.h: Removed extraneous qualifier.
- 9:17 AM Changeset in webkit [45915] by
-
- 5 edits in trunk/WebCore
2009-07-15 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[V8] Update bindings for ValiditeState patch.
https://bugs.webkit.org/show_bug.cgi?id=19562
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 8:49 AM Changeset in webkit [45914] by
-
- 5 edits in trunk
2009-07-15 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Cleanup - Remove obsolete code from the make system
https://bugs.webkit.org/show_bug.cgi?id=27299
- JavaScriptCore.pro:
- jsc.pro:
WebCore:
2009-07-15 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Cleanup - Remove obsolete code from the make system
https://bugs.webkit.org/show_bug.cgi?id=27299
- WebCore.pro:
- 8:41 AM Changeset in webkit [45913] by
-
- 2 edits in trunk/WebKit/qt
2009-07-15 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
When the user clicks a link with a target attribute, the newly created window should be visible.
Make new windows created in Qtlauncher visible.
- QtLauncher/main.cpp: (WebPage::createWindow):
- 8:33 AM Changeset in webkit [45912] by
-
- 2 edits in trunk/WebCore
2009-07-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Fix the build without media elements.
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): Add #if ENABLE(VIDEO) markers around the body of the method.
- 8:18 AM Changeset in webkit [45911] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-07 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Alternate bool operator for codewarrior compiler (WINSCW).
Compiler (latest b482) reports error for UnspecifiedBoolType construct:
"illegal explicit conversion from 'WTF::OwnArrayPtr<JSC::Register>' to 'bool'"
Same fix as in r38391.
- JavaScriptCore/wtf/OwnArrayPtr.h:
- 8:14 AM Changeset in webkit [45910] by
-
- 2 edits in trunk
2009-07-15 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Fix the Qt/Mac build by disabling TestNetscapePlugin
We should fix and enable this once we run DRT for Qt/Mac
- WebKit.pro:
- 8:14 AM Changeset in webkit [45909] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-15 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
Qualify include path with wtf to fix compilation
on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=27055
- interpreter/Interpreter.h:
- 7:18 AM Changeset in webkit [45908] by
-
- 4 edits in trunk/JavaScriptCore
2009-07-15 Laszlo Gombos <Laszlo Gombos>
Reviewed by Dave Kilzer.
Turn off non-portable date manipulations for SYMBIAN
https://bugs.webkit.org/show_bug.cgi?id=27064
Introduce HAVE(TM_GMTOFF), HAVE(TM_ZONE) and HAVE(TIMEGM) guards
and place the rules for controlling the guards in Platform.h.
Turn off these newly introduced guards for SYMBIAN.
- wtf/DateMath.cpp: (WTF::calculateUTCOffset):
- wtf/DateMath.h: (WTF::GregorianDateTime::GregorianDateTime): (WTF::GregorianDateTime::operator tm):
- wtf/Platform.h:
- 7:04 AM Changeset in webkit [45907] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-15 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Undef ASSERT on Symbian, to avoid excessive warnings
https://bugs.webkit.org/show_bug.cgi?id=27052
- wtf/Assertions.h:
- 5:51 AM Changeset in webkit [45906] by
-
- 2 edits in trunk/WebKitTools
2009-07-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Adam Treat.
Re-implement QWebPage::shouldInterruptJavaScript to disable
js interruption and avoid showing a messagebox during Qt DRT
runs when script execution takes a bit longer.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::shouldInterruptJavaScript): Return false in re-implemented slot.
- 5:49 AM Changeset in webkit [45905] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-07-15 Aron Xu <aronmalache@163.com>
Rubber-stamped by Jan Alonzo.
Simplified Chinese translation
https://bugs.webkit.org/show_bug.cgi?id=27252
- zh_CN.po: Added.
- 5:16 AM Changeset in webkit [45904] by
-
- 2 edits in trunk/JavaScriptCore
REGRESSION: fast/js/postfix-syntax.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27294
Reviewed by Simon Hausmann.
When postfix operators operating on locals assign to the same local
the order of operations has to be to store the incremented value, then
store the unmodified number. Rather than implementing this subtle
semantic in the interpreter I've just made the logic explicit in the
bytecode generator, so x=x++ effectively becomes x=ToNumber(x) (for a
local var x).
- 2:59 AM Changeset in webkit [45903] by
-
- 2 edits in trunk/JavaScriptCore
REGRESSION(43559): fast/js/kde/arguments-scope.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27259
Reviewed by Simon Hausmann
The interpreter was incorrectly basing its need to create the arguments object
based on the presence of the callframe's argument reference rather than the local
arguments reference. Based on this it then overrode the local variable reference.
- 2:32 AM Changeset in webkit [45902] by
-
- 1 edit in trunk/WebKit/gtk/po/ChangeLog
Fix ChangeLog attribution to Bruce Cowan
- 2:29 AM Changeset in webkit [45901] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-07-15 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Jan Alonzo.
[Gtk] en_GB translation
https://bugs.webkit.org/show_bug.cgi?id=27244
- en_GB.po: Added.
- 2:12 AM Changeset in webkit [45900] by
-
- 2 edits in trunk/WebKitTools
2009-07-15 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Jan Alonzo.
Fix the DumpRenderTree GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=27290
Set USE_SYSTEM_MALLOC macro for the DumpRenderTree build to
disable using TCmalloc in DumpRenderTree.
- GNUmakefile.am:
- 1:10 AM Changeset in webkit [45899] by
-
- 3 edits in trunk/WebCore
2009-07-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Move storeLastActivePanel out of the
ifdef ENABLE_JAVASCRIPT_DEBUGGER section in IDL;
Add default panel for the first opening of the
WebInspector.
- inspector/InspectorController.cpp: (InspectorController::setWindowVisible):
- inspector/InspectorController.idl:
Jul 14, 2009:
- 11:44 PM Changeset in webkit [45898] by
-
- 2 edits in trunk/LayoutTests
2009-07-14 Brian Weinstein <bweinstein@apple.com>
Rubberstamped by Mark Rowe.
Add tests to Windows Skip list to get it back in green.
- platform/win/Skipped:
- 11:00 PM Changeset in webkit [45897] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- JavaScriptCore.vcproj/testapi/testapi.vcproj:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
- 10:58 PM Changeset in webkit [45896] by
-
- 2 edits in trunk/WebCore
2009-07-14 Darin Adler <Darin Adler>
Try to fix Windows build.
- bindings/scripts/CodeGeneratorCOM.pm: Add Reflect and ReflectURL support.
- 10:40 PM Changeset in webkit [45895] by
-
- 38 edits in trunk
Clear stray executable bits that have crept in over time.
- 10:40 PM Changeset in webkit [45894] by
-
- 3 edits in trunk/WebCore
2009-07-14 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Oliver Hunt.
HTMLMediaElement::supportsFullscreen() should return false
https://bugs.webkit.org/show_bug.cgi?id=27284
(Reverting a part of 45875)
HTMLVideoElement::supportsFullscreen() will properly do the
job, and check if the backend supports fullscreen.
HTMLVideoElement is the only subclass to support fullscreen
(conditionnaly). HTMLAudioElement fullscreen is not supported
and is a different kind of fullscreen, if it comes to be wanted.
No test can be done currently given that none of the media
backends support fullscreen.
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::supportsFullscreen):
- 10:26 PM Changeset in webkit [45893] by
-
- 26 edits in trunk/WebCore
2009-07-14 Darin Adler <Darin Adler>
Reviewed by Dimitri Glazkov.
Next step in making DOM attribute getter/setters consistently use AtomicString
https://bugs.webkit.org/show_bug.cgi?id=25425
This covers eight DOM classes, and for each one of the classes:
- Changes the IDL to use the Reflect syntax for all simple cases.
- Removes unused functions in the classes, mainly newly unused ones that were used for reflection before.
- Removes unneeded explicitly defined destructors.
- Explicitly declares destructors as virtual.
- Removes unneeded includes.
- Makes members protected or private rather than public where possible.
- Renames "doc" to "document".
- Tweaks formatting to match our latest style in a few places.
- Improves some FIXME comments.
Over time we'll want to do this for all HTML DOM classes.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement):
- html/HTMLAnchorElement.h: (WebCore::HTMLAnchorElement::endTagRequirement): (WebCore::HTMLAnchorElement::tagPriority):
- html/HTMLAnchorElement.idl:
- html/HTMLAppletElement.cpp:
- html/HTMLAppletElement.h:
- html/HTMLAppletElement.idl:
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
- html/HTMLAreaElement.h: (WebCore::HTMLAreaElement::endTagRequirement): (WebCore::HTMLAreaElement::tagPriority):
- html/HTMLAreaElement.idl:
- html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::parseMappedAttribute):
- html/HTMLBRElement.h:
- html/HTMLBRElement.idl:
- html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::HTMLBaseElement): (WebCore::HTMLBaseElement::removedFromDocument): (WebCore::HTMLBaseElement::process):
- html/HTMLBaseElement.h:
- html/HTMLBaseElement.idl:
- html/HTMLBaseFontElement.cpp: (WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
- html/HTMLBaseFontElement.h: (WebCore::HTMLBaseFontElement::endTagRequirement): (WebCore::HTMLBaseFontElement::tagPriority):
- html/HTMLBaseFontElement.idl:
- html/HTMLBlockquoteElement.cpp: (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
- html/HTMLBlockquoteElement.h: (WebCore::HTMLBlockquoteElement::tagPriority):
- html/HTMLBlockquoteElement.idl:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::HTMLBodyElement): (WebCore::HTMLBodyElement::addSubresourceAttributeURLs):
- html/HTMLBodyElement.h: (WebCore::HTMLBodyElement::endTagRequirement): (WebCore::HTMLBodyElement::tagPriority):
- html/HTMLBodyElement.idl: Made changes as described above.
- loader/FrameLoader.cpp: Removed unneeded include of HTMLAnchorElement.h.
- 10:22 PM Changeset in webkit [45892] by
-
- 15 edits in trunk
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- JavaScriptCore.vcproj/testapi/testapi.vcproj:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
WebCore:
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/build-generated-files.sh:
WebKit/win:
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
- WebKit.vcproj/WebKit.vcproj:
WebKitTools:
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- 10:13 PM Changeset in webkit [45891] by
-
- 113 edits in trunk
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225
Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).
- bytecode/SamplingTool.h:
- bytecompiler/RegisterID.h:
- interpreter/CachedCall.h:
- interpreter/RegisterFile.h:
- parser/Lexer.h:
- parser/Parser.h:
- runtime/ArgList.h:
- runtime/BatchedTransitionOptimizer.h:
- runtime/Collector.h:
- runtime/CommonIdentifiers.h:
- runtime/JSCell.h:
- runtime/JSGlobalObject.h:
- runtime/JSLock.h:
- runtime/JSONObject.cpp:
- runtime/SmallStrings.cpp:
- runtime/SmallStrings.h:
- wtf/CrossThreadRefCounted.h:
- wtf/GOwnPtr.h:
- wtf/Locker.h:
- wtf/MessageQueue.h:
- wtf/OwnArrayPtr.h:
- wtf/OwnFastMallocPtr.h:
- wtf/OwnPtr.h:
- wtf/RefCounted.h:
- wtf/ThreadSpecific.h:
- wtf/Threading.h:
- wtf/Vector.h:
- wtf/unicode/Collator.h:
WebCore:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225
Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).
- bindings/js/GCController.h:
- bindings/js/WorkerScriptController.h:
- bindings/v8/V8DOMMap.cpp: (WebCore::):
- bridge/runtime.h:
- css/CSSSelector.h:
- css/CSSSelectorList.h:
- css/CSSStyleSelector.h:
- dom/ClassNames.h:
- dom/MessagePortChannel.h:
- dom/XMLTokenizerLibxml2.cpp:
- dom/XMLTokenizerScope.h:
- editing/ReplaceSelectionCommand.cpp:
- editing/SelectionController.h:
- editing/TextIterator.cpp:
- history/PageCache.h:
- html/CanvasRenderingContext2D.h:
- html/HTMLParser.h:
- html/HTMLParserQuirks.h:
- html/PreloadScanner.h:
- loader/Cache.h:
- loader/CrossOriginPreflightResultCache.h:
- loader/FrameLoader.h:
- loader/ProgressTracker.h:
- loader/ThreadableLoader.h:
- loader/appcache/ApplicationCacheGroup.h:
- loader/archive/ArchiveResourceCollection.h:
- loader/icon/IconDatabase.h:
- loader/icon/IconLoader.h:
- loader/icon/PageURLRecord.h:
- loader/loader.h:
- page/ContextMenuController.h:
- page/EventHandler.h:
- page/FrameTree.h:
- page/Page.h:
- page/PageGroup.h:
- page/PageGroupLoadDeferrer.h:
- page/mac/EventHandlerMac.mm:
- platform/AutodrainedPool.h:
- platform/ContextMenu.h:
- platform/EventLoop.h:
- platform/HostWindow.h:
- platform/Pasteboard.h:
- platform/PurgeableBuffer.h:
- platform/RunLoopTimer.h:
- platform/ThreadGlobalData.h:
- platform/ThreadTimers.h:
- platform/Timer.h:
- platform/TreeShared.h:
- platform/graphics/FontData.h:
- platform/graphics/GlyphWidthMap.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageSource.h:
- platform/graphics/MediaPlayer.h:
- platform/graphics/skia/GraphicsContextPlatformPrivate.h:
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/win/QTMovieWin.cpp:
- platform/mac/LocalCurrentGraphicsContext.h:
- platform/network/FormDataBuilder.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/soup/ResourceHandleSoup.cpp:
- platform/text/StringBuffer.h:
- platform/text/TextCodec.h:
- platform/win/WindowMessageBroadcaster.h:
- rendering/CounterNode.h:
- rendering/LayoutState.h:
- rendering/RenderFrameSet.h:
- rendering/RenderView.h:
- rendering/TransformState.h:
- svg/SVGAnimatedProperty.h:
- svg/SynchronizableTypeWrapper.h:
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
- xml/XPathExpressionNode.h:
- xml/XPathParser.h:
- xml/XPathPredicate.h:
- xml/XPathStep.h:
WebKit/gtk:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225
Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).
- webkit/webkitdownload.cpp:
WebKit/win:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225
Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).
- COMEnumVariant.h:
- WebDatabaseManager.cpp:
- WebInspector.h:
- WebLocalizableStrings.cpp:
- 10:04 PM Changeset in webkit [45890] by
-
- 3 edits2 adds in trunk
2009-07-14 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
Fails to save document state when navigating away from a page with a
reference fragment.
https://bugs.webkit.org/show_bug.cgi?id=27281
Test: fast/history/saves-state-after-fragment-nav.html
- history/HistoryItem.cpp: (WebCore::HistoryItem::isCurrentDocument): Use equalIgnoringRef to compare URLs.
- 8:43 PM Changeset in webkit [45889] by
-
- 5 edits in trunk/WebCore
2009-07-14 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Sam Weinig.
Inspector: Remove Unintended Global Variables
https://bugs.webkit.org/show_bug.cgi?id=27203
- inspector/front-end/Console.js: (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
- inspector/front-end/inspector.js: (WebInspector.animateStyle):
- 7:03 PM Changeset in webkit [45888] by
-
- 19 edits5 adds in trunk
WebCore:
2009-07-14 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=19562
Added build stuff and stub for the ValidityState class, part of HTML5
section Forms:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate
Test: fast/forms/ValidityState-001.html
- DerivedSources.cpp: Inclusion of ValidityState files
- DerivedSources.make: ditto
- GNUmakefile.am: ditto
- WebCore.gypi: ditto
- WebCore.pro: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- WebCoreSources.bkl: ditto
- html/HTMLButtonElement.idl: validity attribute
- html/HTMLFieldSetElement.idl: ditto
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::validity): ValidityState getter
- html/HTMLFormControlElement.h: ditto
- html/HTMLInputElement.idl: validity attribute
- html/HTMLSelectElement.idl: ditto
- html/HTMLTextAreaElement.idl: ditto
- html/ValidityState.cpp: Added. (WebCore::ValidityState::ValidityState): (WebCore::ValidityState::valid): validation flag
- html/ValidityState.h: Added. (WebCore::ValidityState::create): validation flag (WebCore::ValidityState::control): ditto (WebCore::ValidityState::valueMissing): ditto (WebCore::ValidityState::typeMismatch): ditto (WebCore::ValidityState::patternMismatch): ditto (WebCore::ValidityState::tooLong): ditto (WebCore::ValidityState::rangeUnderflow): ditto (WebCore::ValidityState::rangeOverflow): ditto (WebCore::ValidityState::stepMismatch): ditto (WebCore::ValidityState::customError): ditto
- html/ValidityState.idl: Added.
LayoutTests:
2009-07-14 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=19562
Minimal test case for ValidityState; more tests are going to be added
along with specific validation routines.
- fast/dom/domListEnumeration-expected.txt: increased expected value of 1 to match the new "validity" attribute
- fast/dom/resources/domListEnumeration.js: ditto
- fast/forms/ValidityState-001-expected.txt: Added.
- fast/forms/ValidityState-001.html: Added.
- 6:11 PM Changeset in webkit [45887] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change ParserArenaRefCounted's superclass to RefCountedCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=27249
ParserArenaDeletable customizes operator new, to avoid double inheritance
ParserArenaDeletable's superclass has been changed to RefCountedCustomAllocated.
- parser/Nodes.h:
- 6:02 PM Changeset in webkit [45886] by
-
- 6 edits2 adds in trunk
WebCore:
2009-07-14 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316
The bug was caused by the code checking whether the blockquote is created by WebKit or not.
We simply remove this code to be consistent with Firefox and Internet Explorer.
Also, enclosingBlockFlow == enclosingNode in outdentParagraph isn't a sufficient condition to insert
the placeholder before the enclosingNode because there could be contents before the current paragraph.
Instead, we should split the enclosingNode (which is a blockquote) at the starting position of outdentation.
It turned out that this solves the bug 25315 also: https://bugs.webkit.org/show_bug.cgi?id=25315
Test: editing/execCommand/outdent-regular-blockquote.html
- editing/IndentOutdentCommand.cpp: (WebCore::isIndentBlockquote): no longer checks whether a blockquote is created by WebKit or not. (WebCore::IndentOutdentCommand::outdentParagraph): takes care of the case enclosingBlockFlow == enclosingNode
LayoutTests:
2009-07-14 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25315
https://bugs.webkit.org/show_bug.cgi?id=25316
The expected result for /editing/execCommand/outdent-selection-expected.html
was rebaselined since the original expected result was wrong (Bug 25315).
Namely, "ipsum" moved to the same paragraph as "more Lorem!"
("ipsum" was in the blockblock immediately below "more Lorem!")
and "Dolor" was moved above the list items "Foo", "Bar", and "Baz".
- editing/execCommand/outdent-regular-blockquote-expected.txt: Added.
- editing/execCommand/outdent-regular-blockquote.html: Added.
- platform/mac/editing/execCommand/outdent-selection-expected.checksum:
- platform/mac/editing/execCommand/outdent-selection-expected.png:
- platform/mac/editing/execCommand/outdent-selection-expected.txt:
- 5:47 PM Changeset in webkit [45885] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Add RefCountedCustomAllocated to RefCounted.h
https://bugs.webkit.org/show_bug.cgi?id=27232
Some class which are inherited from RefCounted customize
operator new, but RefCounted is inherited from Noncopyable
which will be inherited from FastAllocBase. To avoid
conflicts Noncopyable inheriting was moved down to RefCounted
and to avoid double inheritance this class has been added.
- wtf/RefCounted.h: (WTF::RefCountedCustomAllocated::deref): (WTF::RefCountedCustomAllocated::~RefCountedCustomAllocated):
- 5:10 PM Changeset in webkit [45884] by
-
- 3 edits in trunk/WebCore
2009-07-14 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Fix isolated world wrappers for Node prototypes
https://bugs.webkit.org/show_bug.cgi?id=27277
This change does two things:
1) We bypass the wrapper cache in the isolated world. This is because
the wrapper template cache has prototypes that lead to the main
world. We can add a template cache for the isolated world if
performance warrants.
2) We introduce a smarter way to grab the wrapper context for a frame
that is aware that proxy <-> context do not stand in one-to-one
correspondence. This generalizes our solution for the node wrapper
case to prototypes.
The net result is that Node wrappers get the right prototypes. As
before, tests to follow.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::getWrapperContext):
- bindings/v8/V8DOMWrapper.h:
- 5:05 PM Changeset in webkit [45883] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Add NoncopyableCustomAllocated to Noncopyable.h.
https://bugs.webkit.org/show_bug.cgi?id=27228
Some classes which inherited from Noncopyable overrides operator new
since Noncopyable'll be inherited from FastAllocBase, Noncopyable.h
needs to be extended with this new class to support the overriding.
- wtf/Noncopyable.h: (WTFNoncopyable::NoncopyableCustomAllocated::NoncopyableCustomAllocated): (WTFNoncopyable::NoncopyableCustomAllocated::~NoncopyableCustomAllocated):
- 4:36 PM Changeset in webkit [45882] by
-
- 3 edits in trunk/WebCore
2009-07-14 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Fix isolated world wrappers for Nodes
https://bugs.webkit.org/show_bug.cgi?id=27271
Previously, we keepy a pointer to the DOMMap on V8Proxy, but this
caused us to miss the branch in V8DOMMap.cpp for isolated worlds.
I have tests, but I can't land them until I get this feature under
control.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNodeToV8Object):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::V8Proxy):
- 4:16 PM Changeset in webkit [45881] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's IdentifierTable class
https://bugs.webkit.org/show_bug.cgi?id=27260
Inherits IdentifierTable class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Identifier.cpp:70.
- runtime/Identifier.cpp:
- 4:09 PM Changeset in webkit [45880] by
-
- 3 edits in trunk/WebCore
2009-07-14 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Fix isolated world crash on getting window.location
https://bugs.webkit.org/show_bug.cgi?id=27268
I have a test for this locally, but it requires a compile-time hack to
run. Once I get the feature's stability under control, we can turn the
feature on and add the tests.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenWindowReference):
- bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::context):
- 4:02 PM Changeset in webkit [45879] by
-
- 2 edits in trunk/WebCore
2009-07-14 Brent Fulgham <bfulgham@webkit.org>
Correct failing tests after r45875. The original patch did not
test the m_player member for null, causing crashes. This will
happen fairly frequently in real use. Was this original patch
ever tested?
https://bugs.webkit.org/show_bug.cgi?id=27246
Test via existing media tests.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::supportsFullscreen): Check for null pointer. (WebCore::HTMLMediaElement::supportsSave): Check for null pointer.
- 3:50 PM Changeset in webkit [45878] by
-
- 3 edits in trunk/WebCore
2009-07-14 Avi Drissman <avi@chromium.org>
Reviewed by Darin Fisher.
Explicitly mark the HTML generated for the Mac as being UTF-8 encoded.
The Windows clipboard format is explicitly documented as being UTF-8,
and all Linux apps assume UTF-8. On the Mac, though, unless otherwise
indicated, Windows-1252 is assumed, which is wrong.
No new tests.
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection):
- 3:43 PM Changeset in webkit [45877] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's Profiler class
https://bugs.webkit.org/show_bug.cgi?id=27253
Inherits Profiler class from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/profiler/Profiler.cpp:56.
- profiler/Profiler.h:
- 3:35 PM Changeset in webkit [45876] by
-
- 3 edits2 adds in trunk/WebCore
2009-07-14 Albert J. Wong <ajwong@chromium.org>
Reviewed by Dimitri Glazkov.
Upstream V8NPObject.h and V8NPObject.cpp.
https://bugs.webkit.org/show_bug.cgi?id=27103
This just upstreams the files from the chromium code base. Only
minor changes to formatting and similar were done, so no testing
is required because nothing really changed. Code verified to compile.
- 3:20 PM Changeset in webkit [45875] by
-
- 8 edits in trunk/WebCore
2009-07-14 Albert J. Wong <ajwong@chromium.org>
Reviewed by Darin Adler.
Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
https://bugs.webkit.org/show_bug.cgi?id=27246
Added an implementation of supportsSave() into HTMLMediaElement
that delegates to MediaPlayerPrivateImpl so that the media engine
is able to signal whether or not a media source supports saving.
Also added a function to HitTestResult that allows for retrieval
of the currentSrc associated with the "hit" media element.
These functions are just pipeing with no visible UI change so there
are no related layout test changes.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::supportsFullscreen): (WebCore::HTMLMediaElement::supportsSave):
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::supportsSave):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsFullscreen): (WebCore::MediaPlayerPrivateInterface::supportsSave):
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::altDisplayString): (WebCore::HitTestResult::absoluteMediaURL):
- rendering/HitTestResult.h:
- 3:00 PM Changeset in webkit [45874] by
-
- 2 edits in trunk/WebCore
2009-07-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Implement Reflect and ReflectURL attribute support.
https://bugs.webkit.org/show_bug.cgi?id=27273
- bindings/scripts/CodeGeneratorV8.pm: Added support for Reflect and ReflectURL attributes.
- 2:28 PM Changeset in webkit [45873] by
-
- 8 edits in trunk/WebCore
2009-07-14 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27266
Add hasCurrentPoint() to WebCore::Path.
This fixes Skia-based Chromium regression caused by the fix for
https://bugs.webkit.org/show_bug.cgi?id=27187.
For Skia, the new method always returns 'true', pending actual implementation.
This means Chromium still will differ from Gecko behavior, but at least its Canvas
will not be completely broken.
Existing Canvas Layout Tests should pass in Chromium after this change.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::lineTo): insteand of Path::isEmpty() test for hasCurrentPoint(). (WebCore::CanvasRenderingContext2D::quadraticCurveTo): ditto. (WebCore::CanvasRenderingContext2D::bezierCurveTo): ditto.
- platform/graphics/Path.h:
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::hasCurrentPoint):
- platform/graphics/cg/PathCG.cpp: (WebCore::Path::isEmpty): (WebCore::Path::hasCurrentPoint):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::hasCurrentPoint):
- platform/graphics/skia/PathSkia.cpp: (WebCore::Path::hasCurrentPoint):
- platform/graphics/wx/PathWx.cpp: (WebCore::Path::hasCurrentPoint): All these files add a Path::hasCurrentPoint() for various platforms.
- 2:15 PM Changeset in webkit [45872] by
-
- 2 edits2 adds in trunk/WebCore
2009-07-14 Nate Chapin <Nate Chapin>
Reviewed by Sam Weinig.
Upstream RGBColor from src.chromium.org.
- 2:05 PM Changeset in webkit [45871] by
-
- 4 edits in trunk/WebCore
2009-07-10 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
[V8] Rename the didCreate/DestroyScriptContext calls to make it
clear that that those refer to the frame's contxt. Add another
similar call for when creating contexts via evaluateInNewContext.
https://bugs.webkit.org/show_bug.cgi?id=27104
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::initContextIfNeeded):
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame): (WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame): (WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
- loader/FrameLoaderClient.h:
- 1:45 PM Changeset in webkit [45870] by
-
- 3 edits in branches/safari-4-branch/WebKit/mac
Merge r45834.
- 1:45 PM Changeset in webkit [45869] by
-
- 3 edits9 adds in branches/safari-4-branch
Merge r45850.
- 1:45 PM Changeset in webkit [45868] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r45836.
- 1:45 PM Changeset in webkit [45867] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r45832.
- 1:39 PM Changeset in webkit [45866] by
-
- 18 edits in trunk/WebCore
2009-07-14 Brent Fulgham <bfulgham@webkit.org>
Revert http://trac.webkit.org/changeset/45864 after
breaking of Windows build.
- storage/LocalStorageTask.cpp:
- storage/LocalStorageTask.h:
- storage/Storage.cpp:
- storage/Storage.h:
- storage/StorageArea.cpp:
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp:
- storage/StorageAreaImpl.h:
- storage/StorageAreaSync.cpp:
- storage/StorageAreaSync.h:
- storage/StorageEvent.cpp:
- storage/StorageEvent.h: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp:
- storage/StorageNamespaceImpl.h:
- storage/StorageSyncManager.cpp:
- storage/StorageSyncManager.h:
- 1:21 PM Changeset in webkit [45865] by
-
- 3 edits2 adds in trunk/JavaScriptCore
2009-07-06 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
Authors: George Staikos <george.staikos@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>, Makoto Matsumoto <matumoto@math.keio.ac.jp>, Takuji Nishimura
https://bugs.webkit.org/show_bug.cgi?id=27030
Implement custom RNG for WinCE using Mersenne Twister
- wtf/RandomNumber.cpp: (WTF::randomNumber):
- wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
- wtf/wince/mt19937ar.c: Added. (init_genrand): (init_by_array): (genrand_int32): (genrand_int31): (genrand_real1): (genrand_real2): (genrand_real3): (genrand_res53):
- 12:36 PM Changeset in webkit [45864] by
-
- 18 edits in trunk/WebCore
2009-07-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180
DOM Storage had several unnecessary (and probably unintended)
dependencies. This patch replaces many includes of header files with
forward declaration of classes, making some destructors explicit, and
taking some factories out of the header files.
This will allow things like StorageAreaSync to take a StorageAreaImpl*
(as it should) rather than a StorageArea* which previously weren't
possible because the dependencies were such a tangled mess.
- storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::~LocalStorageTask):
- storage/LocalStorageTask.h:
- storage/Storage.cpp: (WebCore::Storage::~Storage):
- storage/Storage.h:
- storage/StorageArea.cpp:
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp:
- storage/StorageAreaImpl.h:
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::~StorageAreaSync):
- storage/StorageAreaSync.h:
- storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
- storage/StorageEvent.h:
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp:
- storage/StorageNamespaceImpl.h:
- storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::~StorageSyncManager):
- storage/StorageSyncManager.h:
- 10:54 AM Changeset in webkit [45863] by
-
- 3 edits in trunk/WebCore
2009-07-14 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Hyatt.
Check to make sure the view is attached to a frame() in the visibleContentsResized()
method as it can be triggered before the view is attached by Frame::createView(...)
setting various values such as setScrollBarModes(...) for example. An ASSERT is
triggered when a view is layout before being attached to a frame().
- page/FrameView.cpp: (WebCore::FrameView::visibleContentsResized):
- page/FrameView.h:
- 9:56 AM Changeset in webkit [45862] by
-
- 2 edits in trunk/WebKit/qt
2009-07-14 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Zack Rusin.
The default constructed values for QSize and WebCore::IntSize are different. The former
produces an invalid size whereas the latter produces a size of zero. This was causing
a layout to be triggered when constructing a view and an assert to be hit. This patch fixes
the crash by taking care not to cause an unnecessary layout triggered by ScrollView::setFixedL
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
- 9:29 AM Changeset in webkit [45861] by
-
- 5 edits in trunk/WebCore
2009-07-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: show last opened panel when invoking inspector.
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::specialPanelForJSName):
- inspector/InspectorController.h: (WebCore::InspectorController::Setting::Setting):
- inspector/InspectorController.idl:
- inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.loaded):
- 9:25 AM Changeset in webkit [45860] by
-
- 2 edits in trunk/WebCore
2009-07-14 Anton Muhin <antonm@chromium.org>
Reviewed by Dimitri Glazkov.
Speed up access to NodeList length.
https://bugs.webkit.org/show_bug.cgi?id=27264
That's a minimal alternation of the code.
- bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): 1) use AtomicString for comparison, 2) use v8::Integer::New instead of v8::Number::New.
- 9:16 AM Changeset in webkit [45859] by
-
- 10 edits in trunk/WebCore
2009-07-14 Anton Muhin <antonm@chromium.org>
Reviewed by Dimitri Glazkov.
Do not do unnecessary conversions from v8::Handle<v8::Value> to
v8::Handle<v8::Object> and accompanying changes.
https://bugs.webkit.org/show_bug.cgi?id=26953
Three things:
1) do not cast from v8::Value to v8::Object if unnecessary---casts are cheap,
but are not free (they check for emptiness of handle);
2) inline conversion from wrapper to node;
3) simplify case to an ASSERT.
This is just a refactoring, so no new tests are needed.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::convertToSVGPODTypeImpl):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::convertDOMWrapperToNative): (WebCore::V8Proxy::convertToNativeObject): (WebCore::V8Proxy::convertToNativeEvent):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toCanvasStyle): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8CustomBinding.cpp: (WebCore::V8Custom::GetTargetFrame):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 9:06 AM Changeset in webkit [45858] by
-
- 4 edits1 copy1 add in trunk
WebCore:
2009-07-14 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Straight quotes should match fancy quotes in in-page search
https://bugs.webkit.org/show_bug.cgi?id=27217
Tests: fast/text/find-quotes.html
- editing/TextIterator.cpp: (WebCore::foldQuoteMark): Added. (WebCore::foldQuoteMarks): Added. (WebCore::SearchBuffer::SearchBuffer): Call foldQuoteMarks on the target string. (WebCore::SearchBuffer::append): Call foldQuoteMarks on characters as they are added to the search buffer.
- platform/text/CharacterNames.h: Added more quotation mark character names. Sorted character names with the sort tool.
LayoutTests:
2009-07-14 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Straight quotes should match fancy quotes in in-page search
https://bugs.webkit.org/show_bug.cgi?id=27217
- fast/text/find-quotes-expected.txt: Added.
- fast/text/find-quotes.html: Copied from LayoutTests/fast/text/find-case-folding.html.
- 8:42 AM Changeset in webkit [45857] by
-
- 1 edit2 adds in trunk/WebKitTools
2009-07-14 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884
Modifies cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/)
based on WebKit's style guide.
- Scripts/cpplint.py: Added.
- Scripts/cpplint_unittest.py: Added.
- 6:04 AM Changeset in webkit [45856] by
-
- 2 edits in trunk/WebKitTools
2009-07-14 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] DumpRenderTree no longer builds with Qt4.4
https://bugs.webkit.org/show_bug.cgi?id=27257
Flag Qt 4.5 dependency to allow building with Qt 4.4.
- DumpRenderTree/qt/main.cpp: (main):
Jul 13, 2009:
- 11:06 PM BuildingCairoOnWindows edited by
- (diff)
- 11:05 PM BuildingCairoOnWindows edited by
- Remove instruction to include GIFLIB, as this is no longer necessary. (diff)
- 11:04 PM BuildingCairoOnWindows edited by
- Removed instructions to edit config.h, as this is no longer necessary! (diff)
- 10:35 PM Changeset in webkit [45855] by
-
- 3 edits in trunk/WebCore
2009-07-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: handle debugger shortcuts while on source frame or on
script file selector.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- 9:00 PM Changeset in webkit [45854] by
-
- 3 edits in trunk/WebCore
2009-07-13 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Use standard HashCountedSet instead of a hand rolled one
in HTMLDocument.
- html/HTMLDocument.cpp: (WebCore::addItemToMap): (WebCore::removeItemFromMap):
- html/HTMLDocument.h:
- 8:32 PM WebKit Team edited by
- added indt folks (diff)
- 7:44 PM Changeset in webkit [45853] by
-
- 2 edits in trunk/LayoutTests
2009-07-13 Brady Eidson <beidson@apple.com>
Fix Leopard regression I just introduced.
- platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- 7:01 PM Changeset in webkit [45852] by
-
- 4 edits3 copies1 add in trunk/LayoutTests
2009-07-13 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe.
Add SnowLeopard specific results for differing MIME types that are (mostly) progressions.
- platform/mac-leopard/platform/mac/fast/loader: Added.
- platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
- platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.
- platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac/fast/loader/file-url-mimetypes-expected.txt.
- platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:
- platform/mac/fast/loader/file-url-mimetypes-expected.txt:
- 6:04 PM Changeset in webkit [45851] by
-
- 12 edits5 adds in trunk
WebCore:
2009-07-13 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler and Maciej Stachowiak.
Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262
This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
to the CSS properties -webkit-user-drag and -webkit-user-select respectively.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute
Test: fast/html/draggable.html
- css/html.css:
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::draggable):
- html/HTMLAnchorElement.h:
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp: (WebCore::HTMLElement::draggable): (WebCore::HTMLElement::setDraggable):
- html/HTMLElement.h:
- html/HTMLElement.idl:
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::draggable):
- html/HTMLImageElement.h:
LayoutTests:
2009-07-13 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler and Maciej Stachowiak.
Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262
This adds support for the HTML5 draggable attribute and its DOM binding. It maps the draggable property
to the CSS properties -webkit-user-drag and -webkit-user-select respectively.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-draggable-attribute
- fast/html/draggable-expected.txt: Added.
- fast/html/draggable.html: Added.
- fast/html/resources: Added.
- fast/html/resources/images: Added.
- fast/html/resources/images/lime.png: Added.
- fast/dom/resources/domListEnumeration.js: Updated.
- fast/dom/domListEnumeration-expected.txt: Updated.
- 5:47 PM Changeset in webkit [45850] by
-
- 3 edits9 adds in trunk
2009-07-13 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Image rendered as layer contents looks different from image rendered via CG.
<rdar://problem/7048830>
Fix a visible color profile difference between between images rendered via Core Graphics
and those rendered via a compositing layer, by assigning the GenericRGB profile to
untagged images (which come through as having the DeviceRGB profile) when they are set
as layer contents.
Test: compositing/color-matching/image-color-matching.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
- 5:20 PM Changeset in webkit [45849] by
-
- 2 edits in trunk/WebCore
2009-07-13 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=27220
Assertion failure in createSearcher() (usearch_open() status is U_USING_DEFAULT_WARNING)
- editing/TextIterator.cpp: (WebCore::createSearcher): Add U_USING_DEFAULT_WARNING as a possible status code in the assertion. Affects only the assertion.
- 5:07 PM Changeset in webkit [45848] by
-
- 6 edits4 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26925
<rdar://problem/7027850> URL Fragment Breaks Application Cache Loads
Test: http/tests/appcache/main-resource-hash.html
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::resourceForURL): (WebCore::ApplicationCache::resourceForRequest):
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest): (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::addEntry): Remove URL fragment at appcache code borders.
- loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::create):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup): (WebCore::ApplicationCacheStorage::cacheGroupForURL): (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Assert that there is no URL fragment in URL at key points in appcache code.
- 5:02 PM Changeset in webkit [45847] by
-
- 3 edits1 copy1 add in trunk
WebCore:
2009-07-13 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27166
rdar://problem/7015857
Find for strings composed entirely of spaces doesn't work
Test: fast/text/find-spaces.html
- editing/TextIterator.cpp: (WebCore::findPlainText): Removed unneeded special case. The empty string case already works correctly.
LayoutTests:
2009-07-13 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27166
rdar://problem/7015857
Find for strings composed entirely of spaces doesn't work
- fast/text/find-spaces-expected.txt: Added.
- fast/text/find-spaces.html: Copied from LayoutTests/fast/text/find-case-folding.html.
- 4:42 PM Changeset in webkit [45846] by
-
- 3 edits in trunk/WebKit/win
2009-07-13 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Refactor WebFrame::spoolPages for easier sharing with Windows Cairo.
https://bugs.webkit.org/show_bug.cgi?id=27240.
- WebFrame.cpp: (WebFrame::printHeader): New shared method to print the header. (WebFrame::printFooter): New shared method to print the footer. (WebFrame::spoolPage): New conditionally-compiled method to print a page. (WebFrame::spoolPages): Revised to call the platform-specific spoolPage for each page.
- WebFrame.h: Add new method prototypes.
- 4:23 PM Changeset in webkit [45845] by
-
- 2 edits in trunk/WebCore
2009-07-13 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Remove NPPVpluginPrivateModeBool, it was removed from the spec.
- bridge/npapi.h:
- 4:08 PM Changeset in webkit [45844] by
-
- 2 edits in trunk/WebCore
2009-07-13 Feng Qian <feng@chromium.org>
Reviewed by Dimitri Glazkov.
Make V8DOMMap.h compiling with gcc option -Werror=non=virtual-dtor.
- bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::WeakReferenceMap): (WebCore::WeakReferenceMap::~WeakReferenceMap):
- 4:03 PM Changeset in webkit [45843] by
-
- 2 edits in trunk/WebCore
2009-07-13 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
Remove an accidental add of bidi.(cpp|h) to WebCore.gypi.
- WebCore.gypi: Removed bidi.cpp and bidi.h
- 3:46 PM Changeset in webkit [45842] by
-
- 2 edits in trunk/WebCore
2009-07-13 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
Update WebCore.gyp in preparation to hooking it up.
- WebCore.gypi: Added files that were mid-stream while switching over.
- 3:41 PM Changeset in webkit [45841] by
-
- 1 edit1 add in trunk/LayoutTests
Add Leopard-specific results for fast/text/international/khmer-selection.html.
- platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/khmer-selection-expected.txt.
- 3:08 PM Changeset in webkit [45840] by
-
- 2 edits in trunk/WebCore
2009-07-13 Dmitry Titov <dimich@chromium.org>
Not reviewed, another small fix for Chromium build.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- 3:00 PM Changeset in webkit [45839] by
-
- 4 edits in trunk/WebCore
2009-07-13 Dmitry Titov <dimich@chromium.org>
Not reviewed, fix Chromium build bustage.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- bindings/v8/V8Proxy.cpp: (WebCore::JavaScriptConsoleMessage::addToPage):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::handleConsoleMessage):
- 1:45 PM Changeset in webkit [45838] by
-
- 1 edit1 add in trunk/LayoutTests
Add a missing layout test result to improve the quality of life of the Mac buildbots.
- platform/mac/fast/text/international/khmer-selection-expected.txt: Added.
- 1:32 PM Changeset in webkit [45837] by
-
- 2 edits in trunk/WebKit/mac
2009-07-13 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein, Adam Roben.
"Unrecognized selector" console log when the Safari 4 Welcome page navigates to Top Sites.
<rdar://problem/6994893
attachRootGraphicsLayer() should not assume that the frameView's documentView
is a WebHTMLView.
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::attachRootGraphicsLayer):
- 1:16 PM Changeset in webkit [45836] by
-
- 3 edits2 adds in trunk
WebCore:
2009-07-13 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=27234
<rdar://problem/7054356>
Add null page check in HTMLDocument::hasFocus.
Test: fast/dom/HTMLDocument/hasFocus-frameless-crash.html
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::hasFocus): Add page null check. (WebCore::HTMLDocument::createTokenizer): Cleanup page null check.
LayoutTests:
2009-07-13 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Test for https://bugs.webkit.org/show_bug.cgi?id=27234
<rdar://problem/7054356>
- fast/dom/HTMLDocument/hasFocus-frameless-crash-expected.txt: Added.
- fast/dom/HTMLDocument/hasFocus-frameless-crash.html: Added.
- 1:13 PM Changeset in webkit [45835] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Disable continuous spell checking in the inspector
https://bugs.webkit.org/show_bug.cgi?id=27131
- inspector/front-end/inspector.html: Added spellcheck="false" to the
main-panels and console-prompt containers.
- 12:38 PM Changeset in webkit [45834] by
-
- 3 edits in trunk/WebKit/mac
2009-07-13 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Kevin Decker.
<rdar://problem/7053687> Core Animation plug-ins continue to grow larger and larger when opening new tabs (32 bit-only)
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView setLayer:]): Add a FIXME.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setLayer:]): Make sure to set the size of the layer before changing the autoresizing mask so it won't grow everytime it's inserted into the layer tree.
- 12:14 PM Changeset in webkit [45833] by
-
- 3 edits1 add in trunk
2009-07-13 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium Linux: fix assertion when rendering google.com.kh
Some shapers (i.e. Khmer) will produce cluster logs which report that
/no/ code points contributed to certain glyphs. Because of this, we
take any code point which contributed to the glyph in question, or any
subsequent glyph. If we run off the end, then we take the last code
point.
Added LayoutTests/fast/text/international/khmar-selection.html
- platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::offsetForPositionForComplexText):
- 12:05 PM Changeset in webkit [45832] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
spellcheck="false" is ignored
<rdar://problem/7054177>
- editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): Moved code to check the
spellcheck attribute from here...
(WebCore::Editor::spellCheckingEnabledInFocusedNode): ...to here.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Bail out
if spell chcking is disabled by the spellcheck attribute.
- editing/Editor.h:
- 11:34 AM Changeset in webkit [45831] by
-
- 9 edits1 add in trunk
WebCore:
2009-07-13 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087
- WebCore.vcproj/WebCore.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo builds.
- config.h: Check for presence of WIN_CAIRO and select appropriate configuration. Defaults to standard Apple build.
WebKit/win:
2009-07-13 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087
- WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo targets.
WebKitLibraries:
2009-07-13 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087
- win/tools/vsprops/WinCairo.vsprops: Added. Defines the new WIN_CAIRO flag used to drive non-Apple Windows build.
WebKitTools:
2009-07-13 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087
- DumpRenderTree/config.h: Check for presence of WIN_CAIRO and select appropriate configuration. Defaults to standard Apple build.
- DumpRenderTree/win/DumpRenderTree.vcproj: Add new WinCairo.vsprops to Debug_Cairo and Release_Cairo targets.
- 11:15 AM Changeset in webkit [45830] by
-
- 17 edits1 move5 deletes in trunk
WebCore:
2009-07-13 Peter Kasting <pkasting@google.com>
https://bugs.webkit.org/show_bug.cgi?id=19562
Back out previous patch for this bug (too many problems).
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLButtonElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFormControlElement.cpp:
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::form):
- html/HTMLInputElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTextAreaElement.idl:
- html/ValidityState.cpp: Removed.
- html/ValidityState.h: Removed.
- html/ValidityState.idl: Removed.
LayoutTests:
2009-07-13 Peter Kasting <pkasting@google.com>
https://bugs.webkit.org/show_bug.cgi?id=19562
Back out previous patch for this bug (too many problems).
This also re-enables fast/dom/domListEnumeration.html.
- fast/dom/domListEnumeration.html: Copied from LayoutTests/fast/dom/domListEnumeration.html-disabled.
- fast/dom/domListEnumeration.html-disabled: Removed.
- fast/forms/ValidityState-001-expected.txt: Removed.
- fast/forms/ValidityState-001.html: Removed.
- 11:11 AM Changeset in webkit [45829] by
-
- 2 edits in trunk/WebCore
2009-07-13 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Add HTMLAllCollection to WebCore.gypi.
- 10:08 AM Changeset in webkit [45828] by
-
- 2 edits in trunk/WebKit/mac
2009-07-13 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Simon Fraser.
Correct these delegate methods' declarations by adding parameter names.
- WebView/WebUIDelegatePrivate.h:
- 9:44 AM Changeset in webkit [45827] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Late NEWS file for 1.1.11.
- NEWS:
- 9:40 AM Changeset in webkit [45826] by
-
- 3 edits2 adds in trunk
WebCore:
2009-07-13 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[V8] Add a missing check for constructor call in WebKitCSSMatrixConstructor.
https://bugs.webkit.org/show_bug.cgi?id=27218
Test: fast/css/matrix-as-function-crash.html
- bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Added a check for constructor call.
LayoutTests:
2009-07-13 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
Make sure that calling WebKitCSSMatrix as function does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=27218
- fast/css/matrix-as-function-crash-expected.txt: Added.
- fast/css/matrix-as-function-crash.html: Added.
- 8:53 AM Changeset in webkit [45825] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.11
Tagging 1.1.11.
- 8:29 AM Changeset in webkit [45824] by
-
- 3 edits in trunk/WebKit/gtk
2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Changes to the doc control files for 1.1.11.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 8:23 AM Changeset in webkit [45823] by
-
- 2 edits in trunk
2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix. Require the correct libsoup version now that
it's released.
- configure.ac:
- 7:55 AM Changeset in webkit [45822] by
-
- 2 adds in trunk/WebKitTools/DumpRenderTree/qt/TestNetscapePlugin
Added .pro file missing from r45813
- 7:54 AM Changeset in webkit [45821] by
-
- 2 edits in trunk
2009-07-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Tor Arne Vestbø.
[Qt] Build fix for QtWebKit on Win
https://bugs.webkit.org/show_bug.cgi?id=27205
- WebKit.pri: Include the major version number in the QtWebKit library file for Win.
- 7:32 AM Changeset in webkit [45820] by
-
- 2 edits in trunk/WebKit/qt
2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Fix qdoc warnings for QWebPage::shouldInterruptJavaScript() and mention
how to re-implement it.
- Api/qwebpage.cpp:
- 7:20 AM Changeset in webkit [45819] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Holger Freyther.
Fix unit test to use the correct assumption that the SoupMessage
will be NULL when WebKitNetworkRequest is created from an URI.
- tests/testnetworkrequest.c: (test_network_request_create_destroy):
- 6:58 AM WebKit Team edited by
- (diff)
- 6:15 AM Changeset in webkit [45818] by
-
- 2 edits in trunk/LayoutTests
2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Ariya Hidayat.
Unskip three more fast/js tests that pass with the Qt DRT.
- platform/qt/Skipped:
- 6:04 AM Changeset in webkit [45817] by
-
- 3 edits1 delete in trunk
WebKitTools:
2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Always run the Qt DRT with the raster graphicssystem on X11, for
increased stability in the image based tests, in particular canvas.
- DumpRenderTree/qt/main.cpp: (main):
LayoutTests:
2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Removed Qt DRT specific result for canvas-getImageData as we pass this
test with the raster graphicssystem.
- platform/qt/fast/canvas/canvas-getImageData-expected.txt: Removed.
- 5:29 AM Changeset in webkit [45816] by
-
- 4 edits in trunk
Unreviewed make dist build fix.
- 5:27 AM Changeset in webkit [45815] by
-
- 2 edits in trunk/WebCore
2009-07-13 Cédric Luthi <cedric.luthi@gmail.com>
Reviewed by Tor Arne Vestbø.
Fix NPWindow clip rect in PluginViewMac
The rect should be in window-coordinates. This bug can be observed
with Flash 10 here: http://www.permadi.com/tutorial/cursorTracker/
- plugins/mac/PluginViewMac.cpp:
- 3:55 AM Changeset in webkit [45814] by
-
- 2 edits in trunk/WebKit/qt
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Fix crash with plugins when the plugin stream is cancelled.
Similar to r26667 handle the case where didReceiveResponse on the
plugin view results in failure to set up the stream and
setMainDocumentError being called instead. This will set the
m_pluginView back to 0 and we need check for it before calling
didReceiveData.
This was triggered by consecutive execution of
LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
followed by LayoutTests/scrollbars/scrollbar-crash-on-refresh.html
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::committedLoad):
- 3:55 AM Changeset in webkit [45813] by
-
- 7 edits in trunk
.:
2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Add the test netscape plugin for the Qt DRT to the build.
- WebKit.pro:
WebKitTools:
2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Fix test netscape plugin usage with the Qt DRT.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): Enable plugins in the settings.
- Scripts/run-webkit-tests: Set the QT_WEBKIT_PLUGIN path to the correct build directory to make Qt DRT find the test netscape plugin.
LayoutTests:
2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Enable a bunch of plugin layout tests for the Qt DRT.
- platform/qt/Skipped:
- 3:53 AM Changeset in webkit [45812] by
-
- 2 edits in trunk/WebKitTools
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Make sure to disable the fixed contents size when resetting the page/view
state between test runs, to avoid side-effects.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): Call setFixedContentsSize() with an invalid QSize to disable the fixed layout.
- 3:52 AM Changeset in webkit [45811] by
-
- 4 edits in trunk
WebKitTools:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
When creating new windows, don't forget to connect the new
page's main frame. This ensures that for example the layoutTestController
is also available there.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::createWindow):
LayoutTests:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Removed two more storage tests from the Qt DRT skip list that relied on
layoutTestController to be accessible in newly opened windows.
- platform/qt/Skipped:
- 3:50 AM Changeset in webkit [45810] by
-
- 5 edits in trunk
WebKitTools:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Added support for LayoutTestController.setPrivateBrowsingEnabled.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled):
- DumpRenderTree/qt/jsobjects.h:
LayoutTests:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Removed three tests from the Qt DRT Skip list that rely on
LayoutTestController.setPrivateBrowsingEnabled and pass now.
- platform/qt/Skipped:
- 3:49 AM Changeset in webkit [45809] by
-
- 11 edits in trunk
WebKit/qt:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Added QWebDatabase::removeAllDatabases, as a way to delete all
databases from the offline storage path.
Used by the Qt DRT.
- Api/qwebdatabase.cpp: (QWebDatabase::removeAllDatabases):
- Api/qwebdatabase.h:
WebKitTools:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Added support for database callbacks, storage quota setting,
and clearing of all databases.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::dumpDatabaseQuota):
- DumpRenderTree/qt/DumpRenderTree.h:
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setDatabaseQuota): (LayoutTestController::clearAllDatabases):
- DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpDatabaseCallbacks): (LayoutTestController::dumpDatabaseCallbacks):
- DumpRenderTree/qt/main.cpp: (main):
LayoutTests:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Enable a bunch of more storage layout tests for the Qt DRT, now that
they pass.
- platform/qt/Skipped:
- 3:48 AM Changeset in webkit [45808] by
-
- 4 edits in trunk
WebKitTools:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Setup the path in the Qt DRT for HTML 5 Databases, to enable some of
the storage layout tests.
- DumpRenderTree/qt/main.cpp: (main):
LayoutTests:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Enable some storage layout tests in the Qt DRT, as the pass now.
- platform/qt/Skipped:
- 3:46 AM Changeset in webkit [45807] by
-
- 2 edits in trunk/WebCore
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Fix Qt implementation of WebCore::directoryName to return the absolute
directory name instead of the base file name.
- platform/qt/FileSystemQt.cpp: (WebCore::directoryName):
- 3:45 AM Changeset in webkit [45806] by
-
- 8 edits in trunk
WebKit/qt:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Added loadStarted() and loadFinished() signals to QWebFrame,
to allow load tracking of individual frames, as opposed to
QWebPage's loadStarted/loadFinished signals that are emitted
whenever _any_ child frame loads/finishes.
- Api/qwebframe.cpp: Document new signals.
- Api/qwebframe.h: Add new signals.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): Connect new signals.
WebKitTools:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Make the test output more robust by dumping only when the main
frame finishes loading, instead of when _any_ frame finishes.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Connect to the main frame's loadFinished() signal instead of the page's one.
LayoutTests:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Removed 20 more frame tests from the Qt skip list as they pass now
after making sure we only dump after the main frame's loadFinished
signal.
- platform/qt/Skipped:
- 3:40 AM Changeset in webkit [45805] by
-
- 9 edits in trunk
WebKit/qt:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Add hooks for the GCController JavaScript interface needed by the
Qt DRT.
Fixed sort order of includes in qwebframe.cpp.
- Api/qwebframe.cpp: (qt_drt_javaScriptObjectsCount): (qt_drt_garbageCollector_collect): (qt_drt_garbageCollector_collectOnAlternateThread):
WebKitTools:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Implement the GCController DRT interface in the Qt DRT.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine.
- DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController.
- DumpRenderTree/qt/jsobjects.cpp: Implement GCController. (GCController::GCController): (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
- DumpRenderTree/qt/jsobjects.h: Declare GCController.
LayoutTests:
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Remove fast/frames/removal-before-attach-crash.html and
fast/dom/StyleSheet/ownerNode-lifetime-2.html from the Qt DRT skip
list, as they pass now with support for the GCController.
- platform/qt/Skipped:
- 3:34 AM Changeset in webkit [45804] by
-
- 2 edits in trunk/WebCore
2009-07-13 Simon Hausmann <Simon Hausmann>
Reviewed by Ariya Hidayat.
Fix WebCore::Path::isEmpty() for the Qt port to return true
if there is no element in the path.
QPainterPath::isEmpty() returns also true if there is one single
MoveTo element inside, which makes sense but doesn't patch Webcore's
is-empty definition.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::isEmpty): Use elementCount() == 0.
- 3:22 AM Changeset in webkit [45803] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-07-13 Reinout van Schouwen <reinouts@gnome.org>
<https://bugs.webkit.org/show_bug.cgi?id=26980> [Gtk] Updated Dutch translation
Rubber-stamped by Jan Alonzo.
- nl.po: Added.
- 3:11 AM Changeset in webkit [45802] by
-
- 4 edits in trunk
2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>
<https://bugs.webkit.org/show_bug.cgi?id=27171> [Gtk]
REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html
Reviewed by Gustavo Noronha.
Unskip fast/events/frame-programmatic-focus.html
- platform/gtk/Skipped:
focus-in and focus-out events only get triggered when there's user
interaction, hence setFocused(bool) never gets called when
focusEvent is triggered when running the layout tests. The
solution seems to be to implement grab-focus too so we can call
setFocused(bool) when a widget has focus.
- webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event): (webkit_web_view_class_init):
- 2:57 AM Changeset in webkit [45801] by
-
- 12 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT
Reviewed by Gustavo Noronha and Xan Lopez.
Unskip tests that now pass due to support for JS windows in Gtk DRT.
- platform/gtk/Skipped:
Add API to support opening and closing of JavaScript windows automatically.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
- webkit/webkitprivate.h:
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_real_close_web_view): (webkit_web_view_class_init): (webkit_web_view_update_settings): (webkit_web_view_settings_notify): (webkit_web_view_set_group_name):
- webkit/webkitwebview.h:
Support running of tests that open and close JS windows automatically.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpFramesAsText): (dumpBackForwardListForAllWebViews): (resetWebViewToConsistentStateBeforeTesting): (dump): (runTest): (webViewClose): (createWebView): (webViewCreate): (main):
- DumpRenderTree/gtk/DumpRenderTreeGtk.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::windowCount): (LayoutTestController::setPopupBlockingEnabled):
- 2:47 AM Changeset in webkit [45800] by
-
- 3 edits in trunk/LayoutTests
2009-07-13 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Oliver Hunt.
Tweak mouseout-dead-subframe.html to be more robust.
The test calls notifyDone() and then dumpAsText(). The latter call has no effect
as notifyDone() performs the dump, but it passes in the mac DRT because the mime-type
of the .html file is detected as text/plain and therefore the text is dumped instead
of the render tree.
Changed the testcase to call dumpAsText() first and then notifyDone(), to make it
pass without relying on the mime type detection.
That also makes the test pass in the Qt DRT.
- fast/events/mouseout-dead-subframe.html: Swapped notifyDone() and dumpAsText() calls to call the former before the latter.
- platform/qt/Skipped: Removed skipped test.
- 2:36 AM Changeset in webkit [45799] by
-
- 2 edits in trunk/WebKitTools
2009-07-13 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Maciej Stachowiak.
prepare-ChangeLog should decode HTML entities in short description
https://bugs.webkit.org/show_bug.cgi?id=27122
Decode the short description by adding a function which decodes HTML
entities. It can decode &, <, >, ", and ' . They may be sufficient
as the description seems to be encoded by xml_quote in
http://mxr.mozilla.org/bugzilla/source/Bugzilla/Util.pm
- Scripts/prepare-ChangeLog:
- 2:31 AM Changeset in webkit [45798] by
-
- 2 edits in trunk/WebCore
2009-07-13 Albert J. Wong <ajwong@chromium.org>
Reviewed by Dimitri Glazkov.
Upstream fixes to NPV8Object.cpp that make ~30 layout tests pass.
https://bugs.webkit.org/show_bug.cgi?id=27127
There were a number of bugs introduced during the last upstreaming
effort that broke around 30 layout tests. This fixes those bugs.
It also has compile fixes to match the recent cutting apart of
V8Proxy.
- bindings/v8/NPV8Object.cpp: (freeV8NPObject): (npCreateV8ScriptObject): (NPN_Invoke): (NPN_InvokeDefault): (NPN_EvaluateHelper): (NPN_SetException): (NPN_Construct):
- 2:31 AM Changeset in webkit [45797] by
-
- 2 edits in trunk/WebCore
2009-07-13 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
Fix memory leak in the V8 binding layer.
https://bugs.webkit.org/show_bug.cgi?id=27163
Reinitializing the context is not necessary when clearing the proxy for navigation
and it will lead us to hold on to an empty context for each frame.
Test for empty context instead of empty global object handle when
updating the document for a context.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::updateDocument):
- 2:31 AM Changeset in webkit [45796] by
-
- 2 edits in trunk/WebCore
2009-07-13 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Correct the logic to determine if a V8 callback returns a value.
https://bugs.webkit.org/show_bug.cgi?id=27155
- bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
- Don't crash if result.IsEmpty().
- 1:58 AM Changeset in webkit [45795] by
-
- 25 edits16 adds in trunk
2009-07-13 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932
.:
Added ENABLE(SHARED_WORKERS) flag.
- configure.ac:
Added ENABLE(SHARED_WORKERS) flag (off by default).
- Configurations/FeatureDefines.xcconfig:
WebCore:
Initial IDL definition and bindings for SharedWorkers.
- Configurations/FeatureDefines.xcconfig: Added new files for SharedWorker support.
- DerivedSources.make: Added new files for SharedWorker support.
- GNUmakefile.am: Added new files for SharedWorker support.
- WebCore.gypi: Added new files for SharedWorker support.
- WebCore.pro: Added new files for SharedWorker support.
- WebCore.xcodeproj/project.pbxproj: Added new files for SharedWorker support.
- bindings/js/JSAbstractWorkerCustom.cpp: Added. (WebCore::JSAbstractWorker::mark): Custom mark handler that marks the event listeners. (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener): (WebCore::JSAbstractWorker::toJS): Custom toJS handler which differentiates between various subclasses.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::sharedWorker): SharedWorker constructor (only enabled when SHARED_WORKERS is enabled).
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget): Added support for converting to/from SharedWorkers.
- bindings/js/JSSharedWorkerConstructor.cpp: Added. (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor): (WebCore::constructSharedWorker): (WebCore::JSSharedWorkerConstructor::getConstructData):
- bindings/js/JSSharedWorkerConstructor.h: Added. (WebCore::JSSharedWorkerConstructor::classInfo):
- bindings/js/JSSharedWorkerCustom.cpp: Added. (WebCore::JSSharedWorker::mark): Custom mark function that marks the internal MessagePort.
- bindings/v8/DOMObjectsInclude.h: Updated to include new header files.
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8AbstractWorkerCustom.cpp: Added. (WebCore::getEventListener): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): V8 handlers for add/removeEventListener().
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8SharedWorkerCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): Custom constructor for SharedWorker.
- dom/EventTarget.cpp: (WebCore::EventTarget::toSharedWorker):
- dom/EventTarget.h:
- page/DOMWindow.idl:
- workers/AbstractWorker.cpp: Added. (WebCore::AbstractWorker::AbstractWorker): Common base class for SharedWorker and (soon) Worker. The functions below were copied from Worker.cpp. This is the first step in refactoring Worker to derive from AbstractWorker to enable code sharing. (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::addEventListener): (WebCore::AbstractWorker::removeEventListener): (WebCore::AbstractWorker::dispatchEvent): (WebCore::AbstractWorker::dispatchLoadErrorEvent): (WebCore::AbstractWorker::dispatchScriptErrorEvent):
- workers/AbstractWorker.h: Added. Definitions of functionality shared by Worker.h and SharedWorker.h. In a future patch, Worker will derive from AbstractWorker. (WebCore::AbstractWorker::scriptExecutionContext): (WebCore::AbstractWorker::setOnerror): (WebCore::AbstractWorker::onerror): (WebCore::AbstractWorker::eventListeners): (WebCore::AbstractWorker::refEventTarget): (WebCore::AbstractWorker::derefEventTarget):
- workers/AbstractWorker.idl: Added.
- workers/SharedWorker.cpp: Added. (WebCore::SharedWorker::SharedWorker): (WebCore::SharedWorker::~SharedWorker):
- workers/SharedWorker.h: Added. (WebCore::SharedWorker::create): (WebCore::SharedWorker::port): (WebCore::SharedWorker::toSharedWorker):
- workers/SharedWorker.idl: Added.
WebKit/mac:
Added ENABLE(SHARED_WORKERS) flag (disabled by default).
- Configurations/FeatureDefines.xcconfig:
WebKitTools:
Added support for --shared-workers (turned off by default)
- Scripts/build-webkit:
LayoutTests:
Unit tests for new SharedWorker APIs (disabled by default).
- fast/workers/shared-worker-constructor-expected.txt: Added.
- fast/workers/shared-worker-constructor.html-disabled: Added.
- fast/workers/shared-worker-event-listener-expected.txt: Added.
- fast/workers/shared-worker-event-listener.html-disabled: Added.
- 1:32 AM Changeset in webkit [45794] by
-
- 2 edits in trunk/WebCore
2009-07-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Cleanup - Remove prf install target
https://bugs.webkit.org/show_bug.cgi?id=27191
qtwebkit.prf has been removed; this cleans up the related
install target as well.
- WebCore.pro: Remove prf install target
- 1:30 AM Changeset in webkit [45793] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-07 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Maciej Stachoviak.
Removed superfluous parenthesis around single expression.
Compilers on Symbian platform fail to properly parse and compile.
- JavaScriptCore/wtf/Platform.h:
- 1:24 AM Changeset in webkit [45792] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-13 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Maciej Stachoviak.
Renamed Translator to HashTranslator
Codewarrior compiler (WINSCW) latest b482 cannot resolve typename
mismatch between template declaration and definition
(HashTranslator / Translator)
- wtf/HashSet.h:
- 1:20 AM Changeset in webkit [45791] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-13 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Eric Seidel.
Ambiguity in LabelScope initialization
Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve
type of "0" unambiguously. Set expression explicitly to
PassRefPtr<Label>::PassRefPtr()
- bytecompiler/BytecodeGenerator.cpp
Jul 12, 2009:
- 11:12 PM Changeset in webkit [45790] by
-
- 10 edits in trunk/WebKit
WebKit/gtk:
2009-07-12 Brent Fulgham <bfulgham@gmail.com>
Speculative build fix after http://trac.webkit.org/changeset/45786.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::addMessageToConsole):
- WebCoreSupport/ChromeClientGtk.h:
WebKit/qt:
2009-07-12 Brent Fulgham <bfulgham@gmail.com>
Speculative build fix after http://trac.webkit.org/changeset/45786.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):
- WebCoreSupport/ChromeClientQt.h:
WebKit/wx:
2009-07-12 Brent Fulgham <bfulgham@gmail.com>
Speculative build fix after http://trac.webkit.org/changeset/45786.
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::addMessageToConsole):
- WebKitSupport/ChromeClientWx.h:
- 11:02 PM Changeset in webkit [45789] by
-
- 2 edits in trunk/WebKit/win
2009-07-12 Brent Fulgham <bfulgham@gmail.com>
Speculative Windows build fix after http://trac.webkit.org/changeset/45786.
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::addMessageToConsole):
- 10:38 PM Changeset in webkit [45788] by
-
- 1 edit in trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-script-src.pl
Fix executable bit. We should fix bugzilla-tool to understand executable bits.
- 10:36 PM Changeset in webkit [45787] by
-
- 6 edits7 adds in trunk
2009-07-12 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Facebook Chat is broken due to XSS auditor
https://bugs.webkit.org/show_bug.cgi?id=27179
Instead of just using the script's URL as to detect an XSS attack, we
now use a bit of context before the URL. In particular, we use the
bytes from the beginning of the attribute name to the end of the
attribute value. In virtually all injection attacks, the attacker
would need to supply the attribute name as well as the attribute value.
However, in the Facebook false positive, the attribute name is not
present in the URL.
Tests: http/tests/security/xssAuditor/script-tag-src-redirect-safe.html
http/tests/security/xssAuditor/script-tag-with-source-double-quote.html
http/tests/security/xssAuditor/script-tag-with-source-no-quote.html
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
- html/HTMLTokenizer.h:
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
- page/XSSAuditor.h:
2009-07-12 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Facebook Chat is broken due to XSS auditor
https://bugs.webkit.org/show_bug.cgi?id=27179
Add some more test coverage to our handling of script tags with src
attributes. Also, ensure that we don't raise the alarm when a URL
parameter is injected directly into the attribute value.
- http/tests/security/xssAuditor/resources/echo-script-src.pl: Added.
- http/tests/security/xssAuditor/script-tag-src-redirect-safe-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/base-href-safe-expected.txt.
- http/tests/security/xssAuditor/script-tag-src-redirect-safe.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
- http/tests/security/xssAuditor/script-tag-with-source-double-quote.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt: Copied from LayoutTests/http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt.
- http/tests/security/xssAuditor/script-tag-with-source-no-quote.html: Added.
- 10:08 PM Changeset in webkit [45786] by
-
- 36 edits in trunk
WebCore:
2009-07-12 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Refactor ConsoleMessage to add MessageType attribute.
https://bugs.webkit.org/show_bug.cgi?id=20625
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::printErrorMessage):
- dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
- dom/Document.h:
- dom/ScriptExecutionContext.h:
- html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::count):
- inspector/InspectorController.h:
- inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): (WebInspector.ConsoleMessage): Added type property. (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual): (WebInspector.ConsoleCommandResult): (WebInspector.ConsoleGroup.prototype.addMessage): (WebInspector.ConsoleGroup.prototype._titleClicked):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._addTip): (WebInspector.Resource.prototype._checkWarning):
- inspector/front-end/inspector.css: Changed ".console-group-title-level" to ".console-group-title"
- inspector/front-end/inspector.js: (WebInspector.addMessageToConsole):
- loader/DocLoader.cpp: (WebCore::DocLoader::printAccessDeniedMessage):
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::addMessageToConsole):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::reportLocalLoadFailed): (WebCore::FrameLoader::shouldAllowNavigation):
- page/ChromeClient.h:
- page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): (WebCore::Console::addMessage): (WebCore::Console::error): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::timeEnd): (WebCore::Console::warn):
- page/Console.h: Added MessageType enum. (WebCore::):
- page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired):
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
- wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
- workers/GenericWorkerTask.h: Added GenericWorkerTask8 for the extra argument. (WebCore::GenericWorkerTask8::create): (WebCore::GenericWorkerTask8::GenericWorkerTask8): (WebCore::GenericWorkerTask8::performTask): (WebCore::createCallbackTask):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::importScripts):
- workers/WorkerContext.h:
- workers/WorkerMessagingProxy.cpp: (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
- workers/WorkerMessagingProxy.h:
- workers/WorkerObjectProxy.h:
- xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): (WebCore::XMLHttpRequest::didFinishLoading):
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::parseErrorFunc):
WebKit/mac:
2009-07-12 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Refactor ConsoleMessage to add MessageType attribute.
https://bugs.webkit.org/show_bug.cgi?id=20625
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole):
- 9:07 PM Changeset in webkit [45785] by
-
- 7 edits1 add in trunk/WebCore
2009-07-12 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- dom/HTMLAllCollection.idl: Added.
- 8:55 PM Changeset in webkit [45784] by
-
- 2 edits in trunk/WebCore
2009-07-12 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Maciej Stachowiak.
Inspector: Duplicate Computation in Autocompletion
https://bugs.webkit.org/show_bug.cgi?id=26778
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):
- 6:43 PM Changeset in webkit [45783] by
-
- 2 edits2 adds in trunk/LayoutTests
2009-07-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27197
QuickTime supports data: urls, add a layout test.
- media/audio-data-url-expected.txt: Added.
- media/audio-data-url.html: Added.
New test.
- platform/gtk/Skipped:
Skip the new test.
- 5:54 PM Changeset in webkit [45782] by
-
- 10 edits1 move1 delete in trunk
WebCore:
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=27196
Rename bidi.cpp to RenderBlockLineLayout.cpp and remove bidi.h
- GNUmakefile.am: Updated.
- WebCore.gypi: Updated.
- WebCore.pro: Updated.
- WebCore.vcproj/WebCore.vcproj: Updated.
- WebCore.xcodeproj/project.pbxproj: Updated.
- WebCoreSources.bkl: Updated.
- rendering/RenderBlock.h: Removed unnecessary forward declaration and
updated comments.
- rendering/RenderBlockLineLayout.cpp: Copied from WebCore/rendering/bidi.cpp.
Removed unnecessary #include statements.
(WebCore::BidiRun::BidiRun): Moved here from bidi.h.
(WebCore::RenderBlock::layoutInlineChildren): Removed outdated comment.
- rendering/bidi.cpp: Removed.
- rendering/bidi.h: Removed.
WebKitTools:
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=27196
Update check-for-global-initializers for the renaming for bidi.cpp to
RenderBlockLineLayout.cpp
- Scripts/check-for-global-initializers:
- 4:48 PM Changeset in webkit [45781] by
-
- 2 edits in trunk/WebCore
Windows build fix
- 4:41 PM Changeset in webkit [45780] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam Weinig.
- Image cleanup
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): Use the data() accessor instead of the m_data member. (WebCore::BitmapImage::dataChanged): Ditto.
- platform/graphics/Image.h: Re-ordered #includes and class declarations. Removed the drawPatternCallback() declaration. Made member variables private.
- platform/graphics/cg/ImageCG.cpp: (WebCore::drawPatternCallback): Changed this from a member function to a static function.
- platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): Use the data() accessor instead of the m_data member.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Ditto.
- 2:49 PM Changeset in webkit [45779] by
-
- 7 edits in branches/safari-4-branch
Merge r45758.
- 2:49 PM Changeset in webkit [45778] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r45755.
- 2:49 PM Changeset in webkit [45777] by
-
- 3 edits in branches/safari-4-branch/WebKit/mac
Merge r45745.
- 2:49 PM Changeset in webkit [45776] by
-
- 18 edits in branches/safari-4-branch
Merge r45744.
- 2:49 PM Changeset in webkit [45775] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge r45736.
- 2:49 PM Changeset in webkit [45774] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge r45735.
- 2:48 PM Changeset in webkit [45773] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r45734.
- 2:48 PM Changeset in webkit [45772] by
-
- 7 edits in branches/safari-4-branch
Merge r45733.
- 2:48 PM Changeset in webkit [45771] by
-
- 5 edits in branches/safari-4-branch/WebCore
Merge r45732.
- 2:48 PM Changeset in webkit [45770] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r45728.
- 2:48 PM Changeset in webkit [45769] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r45721.
- 2:48 PM Changeset in webkit [45768] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r45715.
- 2:48 PM Changeset in webkit [45767] by
-
- 5 edits2 adds in branches/safari-4-branch
Merge r45710.
- 2:48 PM Changeset in webkit [45766] by
-
- 169 edits in branches/safari-4-branch
2009-07-10 Beth Dakin <Beth Dakin>
<rdar://problem/7045243> Roll text metrics change out
- css/html.css:
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
- platform/graphics/SimpleFontData.h:
- platform/graphics/mac/SimpleFontDataMac.mm:
- platform/graphics/win/SimpleFontDataCGWin.cpp:
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- 2:47 PM Changeset in webkit [45765] by
-
- 29 edits in branches/safari-4-branch
<rdar://problem/7047403> Disable channel messaging
- 2:47 PM Changeset in webkit [45764] by
-
- 14 edits in branches/safari-4-branch
<rdar://problem/7048551> Disable datagrid
- 2:46 PM Changeset in webkit [45763] by
-
- 3 edits3 adds in trunk
2009-07-12 Daniel Bates <dbates@intudata.com>
Reviewed by Darin Adler.
Fixes insufficient check in XSSAuditor::canSetBaseElementURL that caused
XSSAuditor to incorrectly block HTML Base elements whose base path coincided
with the URL of the page.
Test: http/tests/security/xssAuditor/base-href-safe3.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL): Changed conditional to only call XSSAuditor::findInRequest() if the host in the page URL disagrees with the host in the base element URL.
2009-07-12 Daniel Bates <dbates@intudata.com>
Reviewed by Darin Adler.
Tests that XSSAuditor does not block HTML Base elements whose path has the
same host as the page.
- http/tests/security/xssAuditor/base-href-safe3-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-safe3.html: Added.
- http/tests/security/xssAuditor/resources/base-href/base-href-safe3.html: Added.
- 1:27 PM Changeset in webkit [45762] by
-
- 9 edits in trunk/WebCore
2009-07-12 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Text searching with ICU should take the user's default locale into account
https://bugs.webkit.org/show_bug.cgi?id=27184
rdar://problem/6812121
No simple way to test this since it's dependent on user locale.
After this, the user's default locale is used only on Mac.
- editing/TextIterator.cpp: (WebCore::createSearcher): Pass result of the currentSearchLocaleID function as the locale.
- platform/text/TextBreakIteratorInternalICU.h: Added declaration of currentSearchLocaleID function.
- platform/text/android/TextBreakIteratorInternalICU.cpp: (WebCore::currentSearchLocaleID): Added. Returns the empty string.
- platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: (WebCore::currentSearchLocaleID): Ditto.
- platform/text/gtk/TextBreakIteratorInternalICUGtk.cpp: (WebCore::currentSearchLocaleID): Ditto.
- platform/text/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::textBreakLocalePreference): Added. Returns the value of the AppleTextBreakLocale preference. (WebCore::topLanguagePreference): Added. Returns the value of the first item in the AppleLanguages preference. (WebCore::canonicalLanguageIdentifier): Added. Cover for the CFLocaleCreateCanonicalLanguageIdentifierFromString function. (WebCore::getLocale): Added. Transfers the locale from a CFStringRef into a buffer. (WebCore::getSearchLocale): Added. Calls topLanguagePreference, canonicalLanguageIdentifier, and getLocale. (WebCore::currentSearchLocaleID): Added. Calls getSearchLocale once. (WebCore::getTextBreakLocale): Changed to call textBreakLocalePreference, topLanguagePreference, canonicalLanguageIdentifier, and getLocale.
- platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentSearchLocaleID): Added. Returns the empty string.
- platform/wx/TemporaryLinkStubs.cpp: (WebCore::currentSearchLocaleID): Ditto.
- 11:42 AM Changeset in webkit [45761] by
-
- 2 edits in trunk
2009-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump version in preparation for 1.1.11 release.
- configure.ac:
- 10:25 AM Changeset in webkit [45760] by
-
- 2 edits in trunk/WebCore
2009-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Create a PangoLayout that properly represents the visual
appearance of the text in the web page so that the line boundary
modes of getText{At,Before,After}Offset work correctly.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (UTF16ToUTF8): (g_substr): (convertUniCharToUTF8): (getPangoLayoutForAtk):
Jul 11, 2009:
- 10:17 PM Changeset in webkit [45759] by
-
- 3 edits3 adds in trunk
Bug 27187 - Match Gecko behaviour for canvas path mutation APIs on an empty path
<https://bugs.webkit.org/show_bug.cgi?id=27187>
Reviewed by Simon Fraser
Simple API change, check for the empty path and add appropriate point if necessary.
Test: fast/canvas/canvas-modify-emptyPath.html
- 7:15 PM Changeset in webkit [45758] by
-
- 7 edits in trunk
2009-07-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
HTMLMediaElement.canPlayType "maybe" and "probably" reversed
https://bugs.webkit.org/show_bug.cgi?id=27186
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):
Return "probably" if type has codecs parameter.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsType):
Ditto.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::supportsType):
Ditto.
2009-07-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
HTMLMediaElement.canPlayType "maybe" and "probably" reversed
https://bugs.webkit.org/show_bug.cgi?id=27186
- media/video-can-play-type-expected.txt:
- media/video-can-play-type.html:
- 1:26 PM Changeset in webkit [45757] by
-
- 5 edits in trunk
Versioning.
- 1:24 PM Changeset in webkit [45756] by
-
- 1 copy in branches/safari-4-branch
New branch.
- 12:21 PM Changeset in webkit [45755] by
-
- 2 edits in trunk/WebCore
2009-07-11 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe.
A worker-thread inspired follow-up for:
https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
REGRESSION: XHR stream connection blocks iFrame loading and resource downloading
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): Don't perform the XHR compensation when the XHR is running on a worker thread. Accessing the global Cache data structures from a non-main thread is not currently supported.
- 11:44 AM Changeset in webkit [45754] by
-
- 10 edits6 moves35 adds in trunk
2009-07-11 Simon Fraser <Simon Fraser>
Enable support for accelerated compositing and 3d transforms on Leopard.
<https://bugs.webkit.org/show_bug.cgi?id=20166>
<rdar://problem/6120614>
Reviewed by Oliver Hunt.
- 3:18 AM Changeset in webkit [45753] by
-
- 3 edits in trunk/WebCore
2009-07-11 Simon Hausmann <Simon Hausmann>
Fix the Qt build after r45724.
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp):
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
Jul 10, 2009:
- 11:46 PM Changeset in webkit [45752] by
-
- 4 edits16 adds in trunk
WebCore:
2009-07-10 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Implements support for HTML entities, so XSSAuditor can protect against attacks
encoded with HTML entities.
Tests: http/tests/security/xssAuditor/inline-event-HTML-entities.html
http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html
http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html
http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html
http/tests/security/xssAuditor/javascript-link-HTML-entities.html
http/tests/security/xssAuditor/link-onclick-entities.html
http/tests/security/xssAuditor/script-tag-entities.html
http/tests/security/xssAuditor/script-tag-with-source-entities.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::decodeURL): Modified to call WebCore::XSSAuditor::decodeHTMLEntities to decode HTML entities. (WebCore::XSSAuditor::decodeHTMLEntities): Added method to decode HTML entities. (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h:
LayoutTests:
2009-07-10 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests protection against HTML entities encoded attacks.
- http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt: Added.
- http/tests/security/xssAuditor/inline-event-HTML-entities.html: Added.
- http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html: Added.
- http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html: Added.
- http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html: Added.
- http/tests/security/xssAuditor/javascript-link-HTML-entities.html: Added.
- http/tests/security/xssAuditor/link-onclick-entities-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick-entities.html: Added.
- http/tests/security/xssAuditor/script-tag-entities-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-entities.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-entities.html: Added.
- 11:25 PM Changeset in webkit [45751] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/27173> svn-apply: Fix typo in git command used to find deleted files
Reviewed by Eric Seidel.
- Scripts/svn-apply: (scmWillDeleteFile): Changed 'head' to 'HEAD'.
- 11:16 PM Changeset in webkit [45750] by
-
- 11 edits in trunk
Bug 27007: Build fixes when ICONDATABASE is disabled
Reviewed by Sam Weinig.
WebCore:
- WebCore.xcodeproj/project.pbxproj: Added IconDatabaseNone.cpp to the project.
- loader/icon/IconDatabase.cpp: Added #if ENABLE(ICONDATABASE)/#endif macro guard.
- loader/icon/IconDatabase.h: Removed three public methods from #if ENABLE(ICONDATABASE)/#endif macro so that they may be stubbed out in IconDatabaseNone.cpp.
- loader/icon/IconDatabaseNone.cpp: Added #if !ENABLE(ICONDATABASE)/#endif macro guard. (WebCore::IconDatabase::importIconURLForPageURL): Added. (WebCore::IconDatabase::importIconDataForIconURL): Added. (WebCore::IconDatabase::shouldStopThreadActivity): Added.
WebKit/mac:
- Misc/WebIconDatabase.mm: (defaultClient): Return 0 if ICONDATABASE is disabled.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon): Commented out the body of the method if ICONDATABASE is disabled. (WebFrameLoaderClient::registerForIconNotification): Ditto.
- WebCoreSupport/WebIconDatabaseClient.mm: Added #if ENABLE(ICONDATABASE)/#endif guard to source.
- WebView/WebView.mm: (-[WebView setFrameLoadDelegate:]): Wrapped code that starts the icon database machinery in #if ENABLE(ICONDATABASE)/#endif. (-[WebView _registerForIconNotification:]): Wrapped method in #if ENABLE(ICONDATABASE)/#endif guard. (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Ditto.
- WebView/WebViewInternal.h: Wrapped methods in #if ENABLE(ICONDATABASE)/#endif guard. (-[WebView _registerForIconNotification:]): (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
- 11:02 PM Changeset in webkit [45749] by
-
- 6 edits7 copies in trunk
WebCore:
2009-07-10 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fixes issue where JavaScript URLs that contain null- and non-null control characters can
bypass XSSAuditor.
Tests: http/tests/security/xssAuditor/javascript-link-control-char.html
http/tests/security/xssAuditor/javascript-link-null-char.html
http/tests/security/xssAuditor/javascript-link.html
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Separated out logic for JavaScript URLs from inline scripts. For JavaScript URLs, calls XSSAuditor::canEvaluateJavaScriptURL.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Made similar changes to evaluate() as in bindings/js/ScriptController.cpp.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Separated out logic for JavaScript URLs into its own method.
- page/XSSAuditor.h:
LayoutTests:
2009-07-10 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests prevention of JavaScript URLs that contain null- and non-null control characters.
- http/tests/security/xssAuditor/javascript-link-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-control-char.html: Added.
- http/tests/security/xssAuditor/javascript-link-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-null-char.html: Added.
- http/tests/security/xssAuditor/javascript-link.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Added.
- 10:50 PM Changeset in webkit [45748] by
-
- 2 edits in trunk/LayoutTests
2009-07-10 Jan Michael Alonzo <jmalonzo@webkit.org>
Skip tests in the Gtk port that
- are dependent on eventSender
- require platform-specific results
- regressed (with links to the regression bug report)
- failing (due to missing/incomplete implementation)
- platform/gtk/Skipped:
- 10:36 PM Changeset in webkit [45747] by
-
- 141 edits in trunk/WebCore
2009-07-10 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Kilzer.
WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884
Fix bunch of style issues by autofix of cpplint.
This patch is created to demonstrate the autofix of cpplint.py.
No new testcases because it's a style fix
- css/CSSParser.cpp: (WebCore::CSSParser::parseMediaQuery): (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseValue): (WebCore::skipCommaInDashboardRegion): (WebCore::CSSParser::parseDashboardRegions): (WebCore::ShadowParseContext::commitValue): (WebCore::ShadowParseContext::commitLength): (WebCore::ShadowParseContext::commitColor): (WebCore::BorderImageParseContext::commitNumber): (WebCore::BorderImageParseContext::commitWidth): (WebCore::BorderImageParseContext::commitRule): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::lex): (WebCore::CSSParser::text):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/MediaList.cpp: (WebCore::MediaList::deleteMedium):
- css/MediaQuery.h:
- css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
- css/MediaQueryEvaluator.h:
- css/MediaQueryExp.h: (WebCore::MediaQueryExp::operator==):
- css/WebKitCSSMatrix.h:
- dom/Comment.h:
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- dom/Document.h: (WebCore::Document::setHasDashboardRegions):
- dom/DocumentFragment.cpp: (WebCore::DocumentFragment::nodeName):
- dom/DocumentFragment.h:
- dom/DynamicNodeList.h:
- dom/EditingText.h:
- dom/Element.cpp: (WebCore::Element::dispatchAttrAdditionEvent):
- dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::item):
- dom/Node.cpp: (WebCore::Node::nodeValue): (WebCore::Node::nodeIndex):
- dom/NodeRareData.h: (WebCore::NodeListsNodeData::create):
- dom/Notation.h:
- dom/ProcessingInstruction.h:
- dom/Range.cpp: (WebCore::Range::processContents):
- dom/StyledElement.cpp: (WebCore::toHex):
- dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::): (WebCore::OffsetBuffer::readOutBytes): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::attributesStartElementNsHandler):
- dom/XMLTokenizerQt.cpp: (WebCore::attributesStartElementNsHandler): (WebCore::XMLTokenizer::parseStartElement):
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
- editing/Editor.cpp: (WebCore::Editor::pasteAsPlainText):
- editing/SelectionController.cpp: (WebCore::SelectionController::directionOfEnclosingBlock):
- editing/SmartReplaceICU.cpp: (WebCore::addAllCodePoints):
- history/HistoryItem.cpp: (WebCore::HistoryItem::icon): (WebCore::HistoryItem::adoptVisitCounts):
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyFillColor):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::isLiveLink):
- html/HTMLAppletElement.h:
- html/HTMLAudioElement.h:
- html/HTMLBRElement.h:
- html/HTMLBaseElement.h:
- html/HTMLBaseFontElement.h:
- html/HTMLDListElement.h:
- html/HTMLDirectoryElement.h:
- html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::reset):
- html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::parseMappedAttribute):
- html/HTMLHeadElement.h:
- html/HTMLHtmlElement.h:
- html/HTMLImageElement.h: (WebCore::HTMLImageElement::setLoadManually):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
- html/HTMLIsIndexElement.h:
- html/HTMLMarqueeElement.cpp:
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::):
- html/HTMLMenuElement.h:
- html/HTMLMetaElement.h:
- html/HTMLModElement.h:
- html/HTMLOListElement.h:
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged):
- html/HTMLParamElement.h:
- html/HTMLQuoteElement.h:
- html/HTMLStyleElement.h:
- html/HTMLTableCaptionElement.h:
- html/HTMLTableCellElement.h:
- html/HTMLTableColElement.h:
- html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::deleteRow):
- html/HTMLTitleElement.h:
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseNonHTMLText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write):
- html/HTMLUListElement.h:
- html/HTMLVideoElement.h:
- html/TimeRanges.h: (WebCore::TimeRanges::Range::Range):
- inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::newInspectorJSONObject):
- page/Console.cpp: (WebCore::Console::addMessage):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::defaultKeyboardEventHandler):
- page/Frame.cpp: (WebCore::Frame::jsDefaultStatusBarText):
- page/android/DragControllerAndroid.cpp: (WebCore::DragController::dragOperation):
- page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::eventActivatedView):
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- page/gtk/DragControllerGtk.cpp: (WebCore::DragController::dragOperation):
- page/qt/DragControllerQt.cpp:
- page/win/DragControllerWin.cpp: (WebCore::DragController::isCopyKeyDown):
- page/win/FrameWin.h:
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventOffsetToThumb):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setVerticalAlignLength): (WebCore::InheritedFlags::setUnicodeBidi): (WebCore::InheritedFlags::setCursor):
- rendering/style/RenderStyleConstants.h: (WebCore::):
- rendering/style/SVGRenderStyleDefs.h:
- rendering/style/StyleInheritedData.h: (WebCore::StyleInheritedData::operator!=):
- storage/DatabaseTask.h:
- svg/GradientAttributes.h:
- svg/LinearGradientAttributes.h:
- svg/PatternAttributes.h:
- svg/RadialGradientAttributes.h:
- svg/SVGAnimatedPathData.h:
- svg/SVGAnimatedPoints.h:
- svg/SVGAnimationElement.h:
- svg/SVGClipPathElement.h:
- svg/SVGElementInstance.h:
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
- svg/SVGFEDistantLightElement.h:
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
- svg/SVGFEFloodElement.h:
- svg/SVGFEFuncAElement.h:
- svg/SVGFEFuncBElement.h:
- svg/SVGFEFuncGElement.h:
- svg/SVGFEFuncRElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
- svg/SVGFEPointLightElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
- svg/SVGFESpotLightElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::parseMappedAttribute):
- svg/SVGList.h:
- svg/SVGListTraits.h: (WebCore::):
- svg/SVGMPathElement.h:
- svg/SVGMetadataElement.h:
- svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc):
- svg/SVGPathElement.h:
- svg/SVGPathSegClosePath.h:
- svg/SVGSVGElement.h:
- svg/SVGSetElement.h:
- svg/SVGSwitchElement.h:
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::parseMappedAttribute):
- svg/SVGTextPathElement.h:
- svg/SVGTitleElement.h:
- svg/SVGTransformable.cpp: (WebCore::):
- svg/SVGViewSpec.cpp: (WebCore::):
- svg/animation/SMILTime.cpp: (WebCore::operator+): (WebCore::operator-): (WebCore::operator*):
- svg/animation/SVGSMILElement.h:
- svg/graphics/SVGResource.cpp: (WebCore::clientMap):
- wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::value):
- wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::value):
- workers/WorkerRunLoop.cpp:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection):
- xml/XPathPath.h:
- 10:22 PM Changeset in webkit [45746] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/27167> bugzilla-tool: hide help for unsupported commands
Reviewed by Eric Seidel.
When bugzilla-tool -hhelp is invoked in an svn working directory, don't print help for commands that are only supported
on git working directories.
- Scripts/bugzilla-tool: (Command.init): Added requires_local_commits argument with a default of False. Set self.requires_local_commits attribute. (PostCommitsAsPatchesToBug.execute): Removed SCM.supports_local_commits() check since this is now handled by BugzillaTool.main(). (PostCommitsAsPatchesToBug.init): Added requires_local_commits=True argument to Command.init(). (BugzillaTool.commands_usage): Don't print help for commands if they require local commits and the current SCM doesn't support them. (BugzillaTool.main): If command_object requires local commits and the current SCM doesn't, exit with an error message.
- 9:20 PM Changeset in webkit [45745] by
-
- 3 edits in trunk/WebKit/mac
2009-07-10 Simon Fraser <Simon Fraser>
Reviewed by John Sullivan.
Flashing as hardware layers are created and destroyed in some content
<rdar://problem/7032246>
There's a window of time between the end of one runloop cycle, after CA layers changes
have been committed, and the window display at the start of the next cycle when
CA may push updates to the screen before AppKit has drawn the view contents. If
we know that we need to do drawing synchronization (which we do when content moves
between a layer and the view), then we need to call -disableScreenUpdatesUntilFlush
from the existing runloop observer that is set up when layers need repainting to
ensure that layer updates don't reach the screen before view-based painting does.
- WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]): Tweak the comments
- WebView/WebView.mm: (viewUpdateRunLoopObserverCallBack): (-[WebView _scheduleViewUpdate]): Add a big comment to explain the timing of things. Call -disableScreenUpdatesUntilFlush when the view _needsOneShotDrawingSynchronization.
- 9:02 PM Changeset in webkit [45744] by
-
- 18 edits in trunk
2009-07-10 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7049066>.
Update SnowLeopard media controller layout.
- css/mediaControlsQT.css:
Update for new layout.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieLoadType):
Added to replace isStreaming.
- html/HTMLMediaElement.h:
Declare movieLoadType, remove isStreaming.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlStatusDisplayElement::update):
Use movieLoadType instead of isStreaming.
(WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):
MediaControlElement is the base class, not HTMLInputElement.
(WebCore::MediaControlStatusDisplayElement::rendererIsNeeded):
Ditto.
(WebCore::MediaControlRewindButtonElement::rendererIsNeeded):
Don't display rewind button for live streams.
(WebCore::MediaControlReturnToRealtimeButtonElement::rendererIsNeeded):
MediaControlInputElement is the base class, not HTMLInputElement.
- rendering/MediaControlElements.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::getMediaUIPartStateFlags):
New, return wkDrawMediaUIPart flags.
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
Use getMediaUIPartStateFlags.
2009-07-10 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Update WebKitSystemInterface for <rdar://problem/7049066>.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
2009-07-10 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7049066>.
Update media tests for new SnowLeopard controller layout.
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.txt:
- platform/mac/media/video-empty-source-expected.txt:
- platform/mac/media/video-zoom-controls-expected.txt:
- 7:02 PM Changeset in webkit [45743] by
-
- 6 edits7 deletes in trunk
Reverted 45741. Tests failed.
- 6:39 PM Changeset in webkit [45742] by
-
- 1 edit1 move in trunk/LayoutTests
2009-07-10 Peter Kasting <pkasting@google.com>
https://bugs.webkit.org/show_bug.cgi?id=19562
Disable a failing layout test caused by the patch for this bug until
I have time to determine that the obvious fix is correct.
- fast/dom/domListEnumeration.html: Removed.
- fast/dom/domListEnumeration.html-disabled: Copied from LayoutTests/fast/dom/domListEnumeration.html.
- 6:31 PM Changeset in webkit [45741] by
-
- 6 edits7 adds in trunk
2009-07-10 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fixes issue where JavaScript URLs that contain null- and non-null control characters can
bypass XSSAuditor.
Tests: http/tests/security/xssAuditor/javascript-link-control-char.html
http/tests/security/xssAuditor/javascript-link-null-char.html
http/tests/security/xssAuditor/javascript-link.html
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Separated out logic for JavaScript URLs from inline scripts. For JavaScript URLs, calls XSSAuditor::canEvaluateJavaScriptURL.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Made similar changes to evaluate() as in bindings/js/ScriptController.cpp.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Separated out logic for JavaScript URLs into its own method.
- page/XSSAuditor.h:
2009-07-10 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests prevention of JavaScript URLs that contain null- and non-null control characters.
- http/tests/security/xssAuditor/javascript-link-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-control-char.html: Added.
- http/tests/security/xssAuditor/javascript-link-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-null-char.html: Added.
- http/tests/security/xssAuditor/javascript-link.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Added.
- 6:21 PM Changeset in webkit [45740] by
-
- 4 edits in trunk/WebKit
WebKit/mac:
2009-07-10 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig with the power of Grayskull.
Enable XSSAuditor by default.
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
WebKit/win:
2009-07-10 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig with the power of Grayskull.
Enable XSSAuditor by default.
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
- 5:57 PM Changeset in webkit [45739] by
-
- 17 edits5 adds in trunk
WebCore:
2009-07-10 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=19562
Added build stuff and stub for the ValidityState class, part of HTML5
section Forms:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate
Test: fast/forms/ValidityState-001.html
- DerivedSources.cpp: Fix aimed to include ValidityState files
- DerivedSources.make: ditto
- GNUmakefile.am: ditto
- WebCore.gypi: ditto
- WebCore.pro: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- WebCoreSources.bkl: ditto
- html/HTMLButtonElement.idl: "validity" attribute
- html/HTMLFieldSetElement.idl: ditto
- html/HTMLFormControlElement.cpp: object getter (WebCore::HTMLFormControlElement::validity):
- html/HTMLFormControlElement.h: ditto
- html/HTMLInputElement.idl: "validity" attribute
- html/HTMLSelectElement.idl: ditto
- html/HTMLTextAreaElement.idl: ditto
- html/ValidityState.cpp: Added. (WebCore::ValidityState::ValidityState): (WebCore::ValidityState::valid): validation flag
- html/ValidityState.h: Added. (WebCore::ValidityState::create): creation routine (WebCore::ValidityState::control): ValidityState's parent getter (WebCore::ValidityState::valueMissing): validation flag (WebCore::ValidityState::typeMismatch): ditto (WebCore::ValidityState::patternMismatch): ditto (WebCore::ValidityState::tooLong): ditto (WebCore::ValidityState::rangeUnderflow): ditto (WebCore::ValidityState::rangeOverflow): ditto (WebCore::ValidityState::stepMismatch): ditto (WebCore::ValidityState::customError): ditto
- html/ValidityState.idl: Added.
LayoutTests:
2009-07-10 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=19562
Minimal test case for ValidityState; more tests are going to be added
along with specific validation routines.
- fast/forms/ValidityState-001-expected.txt: Added.
- fast/forms/ValidityState-001.html: Added.
- 4:55 PM Changeset in webkit [45738] by
-
- 4 edits in trunk
Versioning.
- 4:54 PM Changeset in webkit [45737] by
-
- 1 copy in tags/Safari-6531.4
New tag.
- 4:21 PM Changeset in webkit [45736] by
-
- 3 edits in trunk/JavaScriptCore
Second part of the "make Windows happier" dance.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 4:15 PM Changeset in webkit [45735] by
-
- 3 edits in trunk/JavaScriptCore
Try and make the Windows build happy.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 4:01 PM Changeset in webkit [45734] by
-
- 2 edits in trunk/WebCore
2009-07-10 Brady Eidson <beidson@apple.com>
Style cleanup over my last patch.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::~XMLHttpRequest):
- 4:00 PM Changeset in webkit [45733] by
-
- 7 edits in trunk
2009-07-10 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoffrey Garen.
- debugger/Debugger.h: Made this function virtual for use in WebCore's WebInspector.
WebCore:
2009-07-10 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoffrey Garen.
- inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::dynamicGlobalObject):
- inspector/JavaScriptCallFrame.h: New helper method, used below.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::detach): In the special case where we detach from a window currently executing JavaScript, manually tear down our representation of the JavaScript call stack, since we won't get any more callbacks from JavaScriptCore to automatically tear it down. It's too bad that WebCore is responsible for this kind of tracking -- in the future, it would be nice if more of the breakpoint handling was inside of JavaScriptCore.
- 3:57 PM Changeset in webkit [45732] by
-
- 5 edits in trunk/WebCore
2009-07-10 Brady Eidson <beidson@apple.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=26496 and <rdar://problem/7046520>
REGRESSION: XHR stream connection blocks iFrame loading and resource downloading
With this test we ended up going over the maximum-connections-per-host limit that CFNetwork expected.
When that happened, the first request that was over the limit ended up in a bizarre state where it
wasn't fully serviced until after the long running XHR was complete.
Loader and Loader::Host work together to try to not exceed the max-connection limit but non-cache
resources - such as XHR - could still end up causing this limit to be exceeded.
This fix adds a workaround specifically for XHR while we hash out a more thorough solution that will
handle this at the resource handle level.
- loader/loader.cpp: (WebCore::Loader::nonCacheRequestInFlight): (WebCore::Loader::nonCacheRequestComplete): (WebCore::Loader::Host::Host): (WebCore::Loader::Host::nonCacheRequestInFlight): (WebCore::Loader::Host::nonCacheRequestComplete): (WebCore::Loader::Host::servePendingRequests): Take nonCacheRequestsInFlight into account.
- loader/loader.h: (WebCore::Loader::Host::processingResource): Take nonCacheRequestsInFlight into account.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::loadRequestAsynchronously): Bump the nonCacheRequestInFlight count. (WebCore::XMLHttpRequest::didFail): Decrement that count if the Loader was notified. (WebCore::XMLHttpRequest::didFinishLoading): Ditto.
- 3:09 PM Changeset in webkit [45731] by
-
- 5 edits in trunk/WebKit/qt
2009-07-10 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Holger Freyther.
Fix a bug where webkit hangs when executing infinite JavaScript loop.
- Api/qwebpage.cpp:
- Api/qwebpage.h:
- WebCoreSupport/ChromeClientQt.cpp:
- tests/qwebpage/tst_qwebpage.cpp:
- 2:53 PM Changeset in webkit [45730] by
-
- 4 edits in trunk
2009-07-10 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790
ParserArenaDeletable overrides new, but it does not override delete.
ParserArenaDeletable must be freed by fastFree
because it is allocated by fastMalloc.
- parser/NodeConstructors.h: (JSC::ParserArenaDeletable::operator delete):
- parser/Nodes.h:
- 2:31 PM Changeset in webkit [45729] by
-
- 2 edits in trunk/WebCore
2009-07-10 Antti Koivisto <Antti Koivisto>
Try to unbreak non-Mac build.
- page/ChromeClient.h: (WebCore::ChromeClient::formDidFocus): (WebCore::ChromeClient::formDidBlur):
- 2:28 PM Changeset in webkit [45728] by
-
- 2 edits in trunk/WebCore
2009-07-10 Beth Dakin <Beth Dakin>
Reviewed by Anders Carlsson.
The rest of the fix for <rdar://problem/7038831> REGRESSION (TOT):
In Mail, a crash occurs at WebCore::Widget::afterMouseDown() after
clicking To Do's close box
Make the Widget* in passMouseDownEventToWidget() a RefPtr.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget):
- 2:19 PM Changeset in webkit [45727] by
-
- 2 edits in trunk/LayoutTests
2009-07-10 Simon Hausmann <Simon Hausmann>
No Review, just re-ordering Qt DRT skip list.
Moved skipped crash tests to the crash section.
- platform/qt/Skipped:
- 2:10 PM Changeset in webkit [45726] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/27117> bugzilla-tool: use Mac OS X keychain for authentication
Reviewed by Eric Seidel.
Try reading credentials from git config first, then keychain if
running on Mac OS X, else prompt at the command-line.
- Scripts/modules/bugzilla.py: Added "import platform". (credentials_from_git): Added. (credentials_from_keychain): Added. (is_mac_os_x): Added. (read_credentials): Added. (Bugzilla.init): Moved instance attribute bug_server to a static attribute named bug-server_url. (Bugzilla.bug_server_host): Added. Extracted host name from bug_server_url. (Bugzilla.bug_server_regex): Updated to be created using bug_server_host. (Bugzilla.bug_server_url): Renamed from bug_server. (Bugzilla.bug_url_for_bug_id): Updated for renaming of bug_server to bug_server_url. (Bugzilla.attachment_url_for_id): Ditto. (Bugzilla.fetch_bug_ids_from_commit_queue): Ditto. (Bugzilla.authenticate): Ditto. Updated to use read_credentials(). (Bugzilla.add_patch_to_bug): Ditto.
- 2:02 PM Changeset in webkit [45725] by
-
- 4 edits1 add in trunk/WebKitTools
<http://webkit.org/b/27115> bugzilla-tool: extract duplicate logging methods into a module
Reviewed by Adam Roben.
- Scripts/bugzilla-tool: Removed error() and log() methods and added import of new logging module.
- Scripts/modules/bugzilla.py: Ditto. Removed "import sys".
- Scripts/modules/scm.py: Ditto.
- Scripts/modules/logging.py: Added. (log): Added. (error): Added. Prefix error messages with "ERROR: ".
- 1:53 PM Changeset in webkit [45724] by
-
- 8 edits in trunk/WebCore
2009-07-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
rename getDOMStructure calls w/o JSGlobalObject* to deprecatedGetDOMStructure
https://bugs.webkit.org/show_bug.cgi?id=27157
This is the first step to fixing
https://bugs.webkit.org/show_bug.cgi?id=27088
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.h: (WebCore::deprecatedGetDOMStructure): (WebCore::createDOMObjectWrapper): (WebCore::createDOMNodeWrapper):
- bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
- bindings/js/JSRGBColor.cpp: (WebCore::JSRGBColor::JSRGBColor):
- bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
- bridge/runtime_array.cpp: (JSC::RuntimeArray::RuntimeArray):
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod):
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::RuntimeObjectImp):
- 1:32 PM Changeset in webkit [45723] by
-
- 9 edits in trunk
WebCore:
2009-07-10 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Antti Koivisto.
Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153
Call the appropriate new ChromeClient methods for focus and blur.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFocusEvent): (WebCore::HTMLFormControlElement::dispatchBlurEvent):
- html/HTMLFormControlElement.h:
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::formDidFocus): (WebCore::EmptyChromeClient::formDidBlur):
- page/ChromeClient.h:
WebKit/mac:
2009-07-10 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Antti Koivisto.
Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153
Call the appropriate private delegate methods from the ChromeClient.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::formStateDidChange): (WebChromeClient::formDidFocus): (WebChromeClient::formDidBlur):
- WebView/WebUIDelegatePrivate.h:
- 1:26 PM Changeset in webkit [45722] by
-
- 3 edits in trunk/LayoutTests
2009-07-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Changing the test string from a platform-dependent file:/// to a more
generic http://.
- fast/dom/anchor-toString-expected.txt:
- fast/dom/anchor-toString.html:
- 1:25 PM Changeset in webkit [45721] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7048741> REGRESSION: Error about missing SwMenuX.dll opening pages with Shockwave
Use altered search path while loading plug-ins. This modifies the DLL search order
to look in the directory containing the plug-in even if a call to SetDllDirectory
was previously made. Use of SetDllDirectory removes the current directory from the search path,
breaking the previous strategy for locating any dependent DLLs of the plug-in.
Reviewed by Jon Honeycutt.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Use LoadLibraryEx with LOAD_WITH_ALTERED_SEARCH_PATH
- 1:15 PM Changeset in webkit [45720] by
-
- 2 edits in trunk/LayoutTests
2009-07-10 Simon Hausmann <Simon Hausmann>
No Review, just skipping a new test for Qt DRT.
Skip fast/forms/slider-delete-while-dragging-thumb.html due to missing eventSender
bits & pieces.
- platform/qt/Skipped:
- 12:19 PM Changeset in webkit [45719] by
-
- 16 edits in trunk
Sort all our Xcode projects
Accomplished using sort-Xcode-project-file.
Requested by Dave Kilzer.
- JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptGlue:
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
- WebCore.xcodeproj/project.pbxproj:
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKitExamplePlugins:
- NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
- NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj:
- NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj:
WebKitTools:
- DrawTest/DrawTest.xcodeproj/project.pbxproj:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- 12:18 PM Changeset in webkit [45718] by
-
- 2 edits in trunk/WebKitTools
Print prepare-ChangeLog's reminders to STDERR so they don't end up in the diff output
Fixes REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines
into the diff
<https://bugs.webkit.org/show_bug.cgi?id=27150>
Reviewed by Maciej Stachowiak.
- Scripts/prepare-ChangeLog:
- 12:18 PM Changeset in webkit [45717] by
-
- 2 edits in trunk/WebKitTools
Use case-insensitive comparisons when sorting Xcode project files
This matches the sorting used in Xcode's files list.
Fixes Bug 27079: sort-Xcode-project-file should sort
case-insensitively, to match Xcode's files list
<https://bugs.webkit.org/show_bug.cgi?id=27079>
Reviewed by Dave Kilzer.
- Scripts/sort-Xcode-project-file: (sortChildrenByFileName): (sortFilesByFileName): Lowercase the strings before comparing them so that the comparison will be case-insensitive.
- 12:10 PM Changeset in webkit [45716] by
-
- 2 edits in trunk/WebCore
2009-07-10 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
Chromium Linux: use disabled images for disabled widgets.
Previously, checkboxes and radio controls rendered the same even if disabled.
The Chromium side of this change is r20224.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::paintRadio):
- 11:54 AM Changeset in webkit [45715] by
-
- 3 edits in trunk/WebCore
2009-07-10 Simon Fraser <Simon Fraser>
Reviewed by John Sullivan.
Fix crash when changing the zoom level in http://iphone.akamai.com/
<rdar://problem/7029077>
RenderLayerBacking's paintIntoLayer() method called updateLayerListsIfNeeded(),
which could potentially destroy that compositing layer, causing a crash.
Prevent this from happening by not doing a compositing update from paintIntoLayer().
The existing updateLayerListsIfNeeded() was renamed to updateCompositingAndLayerListsIfNeeded(),
and still does the compositing update. The new updateLayerListsIfNeeded() does not touch
compositing layers, and is still called from paintIntoLayer().
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateLayerListsIfNeeded): (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
- rendering/RenderLayer.h:
- 11:46 AM Changeset in webkit [45714] by
-
- 11 edits in trunk/WebCore
2009-07-10 Drew Wilson <atwilson@google.com>
Reviewed by Darin Adler.
Need to remove UsesManualToJSImplementation() in favor of CustomToJS.
https://bugs.webkit.org/show_bug.cgi?id=27010
Added support for CustomToJS IDL attribute to replace the hard-coded class list in UsesManualToJSImplementation().
This is just a cleanup of existing functionality, so existing LayoutTests adequately cover this patch.
- bindings/scripts/CodeGeneratorJS.pm: Removed UsesManualToJSImplementation(), added support for CustomToJS attribute.
- css/CSSRule.idl:
- css/CSSValue.idl:
- css/StyleSheet.idl:
- dom/Document.idl:
- dom/Event.idl:
- dom/Node.idl:
- html/ImageData.idl:
- svg/SVGElementInstance.idl:
- svg/SVGPathSeg.idl: Added CustomToJS attribute to all the above IDL files.
- 10:45 AM Changeset in webkit [45713] by
-
- 2 edits in trunk/WebCore
- fix the build by reverting the ill-advised r45711
- page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):
- 10:41 AM Changeset in webkit [45712] by
-
- 4 edits in trunk
2009-07-09 Brian Weinstein <bweinstein@apple.com>
Reviewed by Tim Hatcher.
Updated WebInspectorClient to use Web Inspector Preferences to remember whether or not it should be
docked or a free window instead of NSUserDefaults it used to have.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):
2009-07-09 Brian Weinstein <bweinstein@apple.com>
Reviewed by Tim Hatcher.
Updated WebCore.base.exp to add some needed functions.
- WebCore.base.exp:
- 9:56 AM Changeset in webkit [45711] by
-
- 2 edits in trunk/WebCore
- address a review comment from Simon Fraser which I forgot to include in the last check-in
- page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor): Pass true to getRect() for maximum transform friendliness!
- 9:54 AM Changeset in webkit [45710] by
-
- 5 edits2 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- fix https://bugs.webkit.org/show_bug.cgi?id=27137 <rdar://problem/7043124> REGRESSION (r44311): Reproducible crash due to infinite recursion into FrameLoader::gotoAnchor() -> FrameView::layout()
Test: fast/loader/goto-anchor-infinite-layout.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Moved the code to update layout, find the renderer to scroll to, and scroll from here to methods on FrameView, and replaced it with a call to FrameView::maintainScrollPositionAtAnchor(). (WebCore::FrameLoader::completed): Call maintainScrollPositionAtAnchor() instead of setLockedToAnchor().
- page/FrameView.cpp: (WebCore::FrameView::FrameView): Removed initialization of m_lockedToAnchor. (WebCore::FrameView::reset): Reset m_maintainScrollPositionAnchor instead of m_lockedToAnchor. (WebCore::FrameView::layout): Removed the code related to scrolling to the anchor from here, because scrolling can trigger events which invalidate the layout, and as such, belongs with the post-layout tasks. (WebCore::FrameView::maintainScrollPositionAtAnchor): Added. When called with a node scrolls the view to the top of that node and maintains it scrolled to the top of the node during subsequent layouts, until this function is called with 0 or other things trigger scrolling. (WebCore::FrameView::scrollRectIntoViewRecursively): Reset m_maintainScrollPositionAnchor. (WebCore::FrameView::setScrollPosition): Ditto. (WebCore::FrameView::scrollToAnchor): Added. Scrolls to the top of m_maintainScrollPositionAnchor, if it is set. (WebCore::FrameView::performPostLayoutTasks): Call scrollToAnchor(). (WebCore::FrameView::setWasScrolledByUser): Reset m_maintainScrollPositionAnchor.
- page/FrameView.h: Removed lockedToAnchor(), setLockedToAnchor(), and m_lockedToAnchor. Added maintainScrollPositionAtAnchor() and m_maintainScrollPositionAnchor.
LayoutTests:
Reviewed by Simon Fraser.
- test for https://bugs.webkit.org/show_bug.cgi?id=27137 <rdar://problem/7043124> REGRESSION (r44311): Reproducible crash due to infinite recursion into FrameLoader::gotoAnchor() -> FrameView::layout()
- fast/loader/goto-anchor-infinite-layout-expected.txt: Added.
- fast/loader/goto-anchor-infinite-layout.html: Added.
- 8:39 AM Changeset in webkit [45709] by
-
- 2 edits2 deletes in trunk/LayoutTests
2009-07-09 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Re-enabled dom/xhtml/level2/html/HTMLBaseElement0{1,2} for the Qt DRT,
as there's now a cross-platform result and it passes.
- platform/qt/Skipped:
- platform/qt/dom/xhtml/level2/html/HTMLBaseElement01-expected.txt: Removed.
- platform/qt/dom/xhtml/level2/html/HTMLBaseElement02-expected.txt: Removed.
- 8:30 AM Changeset in webkit [45708] by
-
- 7 edits in trunk
WebKit/qt:
2009-07-10 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Fix crash when in frame tree of a new frame before the new frame
has been installed in the frame tree, similar to r35088.
After calling Frame::init() the frame it may have been removed from the
frame tree again through JavaScript. Detect this by checking the page()
afterwards.
To make this check safe the Frame::init() code was moved into
QWebFrameData's constructor, where a RefPtr holds a reference to the frame.
After the check back in FrameLoaderClientQt we would hold the single
reference left and after release() the frame, its frame loader, its
client as well as the QWebFrame should have disappeared then.
- Api/qwebframe.cpp: (QWebFramePrivate::init): Only call Frame::init here, the rest is done in QWebFrameData's constructor. (QWebFrame::QWebFrame):
- Api/qwebframe_p.h: Adjust declaration. (QWebFrameData::QWebFrameData): Create the Frame here.
- Api/qwebpage.cpp: (QWebPagePrivate::createMainFrame): Adjust and simplify to new QWebFrame constructor.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame): Adjust to new QWebFrame construction using QWebFrameData and add the check like in r35088.
LayoutTests:
2009-07-08 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Remove fast/loader/frame-creation-removal.html from the skip list, it
passes now.
- platform/qt/Skipped:
- 6:25 AM Changeset in webkit [45707] by
-
- 2 edits in trunk/WebCore
2009-07-04 Sriram Yadavalli <sriram.yadavalli@nokia.com>
Reviewed by Simon Hausmann.
QtWebKit fails in loading www.nytimes.com in Windows/Linux
QNetworkReplyHandler is ignoring content associated with 401 error.
This causes the XHR response handling to fail.
Simon: Added also ProxyAuthenticationRequiredError, to handle the same
case when going through proxies, as suggested by Prasanth.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
- 5:47 AM Changeset in webkit [45706] by
-
- 6 edits in trunk
WebKitTools:
2009-07-08 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Fix side-effects in the Qt DRT with tests using application fonts.
Detect if a test used application fonts and re-initialize the fontconfig
application fontset accordingly.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): call initializeFonts and remove all application fonts after running a testcase. (WebCore::DumpRenderTree::initializeFonts): Moved fontconfig initialization code here from main.
- DumpRenderTree/qt/DumpRenderTree.h: Declare initializeFonts.
- DumpRenderTree/qt/main.cpp: (main): Moved fontconfig initialization code to DRT::initializeFonts.
LayoutTests:
2009-07-08 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Remove various tests from the Qt skip list that previously failed
due to DRT side-effects.
- platform/qt/Skipped:
- 4:33 AM Changeset in webkit [45705] by
-
- 2 edits in trunk/WebKitTools
2009-07-10 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
[QT] [ARM] Add pkg-config entry for FontConfig on DRT.pro
https://bugs.webkit.org/show_bug.cgi?id=26990
Missing pkg-config entry for FontConfig in DRT.pro causes some compilers to
not link fine against FontConfig bits.
- DumpRenderTree/qt/DumpRenderTree.pro:
- 4:20 AM Changeset in webkit [45704] by
-
- 2 edits in trunk/WebCore
2009-07-10 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Enable HTML 5 Messaging to fix message channel Qt DRT failures in
fast/events.
- WebCore.pro:
- 4:15 AM Changeset in webkit [45703] by
-
- 2 edits in trunk
2009-07-07 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Exclude DumpRenderTree.pro from symbian build
- WebKit.pro:
Jul 9, 2009:
- 10:26 PM Changeset in webkit [45702] by
-
- 6 edits in trunk/WebCore
2009-07-09 Roland Steiner <rolandsteiner@google.com>
Reviewed by Maciej Stachowiak.
added InlineBox::isLeaf()
firstLeafChild()/lastLeafChild() not virtual and not callable on InlineBox anymore.
firstLeafChild()/lastLeafChild() will no longer return a node outside of the given subtree.
Removed firstLeafChildAfterBox()/lastLeafChildBeforeBox()
Removed potentially quadratic behavior if all nodes before/after a given box are empty InlineFlowBoxes
Currently, these methods are called on RootInlineBox objects only, so above changes should not have
any observable effect (only the removal of the square performance behavior could apply,
but the conditions for that are probably of a rather theoretical nature).
- rendering/InlineBox.cpp: (WebCore::InlineBox::nextLeafChild): (WebCore::InlineBox::prevLeafChild):
- rendering/InlineBox.h: (WebCore::InlineBox::isLeaf):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::firstLeafChild): (WebCore::InlineFlowBox::lastLeafChild):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::firstChild): (WebCore::InlineFlowBox::lastChild): (WebCore::InlineFlowBox::isLeaf):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::closestLeafChildForXPos):
- 10:12 PM Changeset in webkit [45701] by
-
- 3 edits in trunk/WebCore
2009-07-09 Roland Steiner <rolandsteiner@google.com>
Reviewed by Maciej Stachowiak.
Added InlineBox::baselinePosition() and lineHeight() methods
(adapted remaining code accordingly to use those methods)
No change in functionality.
- rendering/InlineBox.h: (WebCore::InlineBox::baselinePosition): (WebCore::InlineBox::lineHeight):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically):
- 10:10 PM Changeset in webkit [45700] by
-
- 2 edits in trunk/JavaScriptCore
2009-07-09 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Windows build fix for the last change.
- wtf/dtoa.cpp: Forgot to include Vector.h
- 10:01 PM Changeset in webkit [45699] by
-
- 5 edits in trunk
Bug 27142 - canPlayType() should return empty string for unsupported content
<https://bugs.webkit.org/show_bug.cgi?id=27142>
Reviewed by Maciej Stachowiak
Return "" instead of "no" for unsupport media types.
- 9:42 PM Changeset in webkit [45698] by
-
- 8 edits3 adds in trunk
WebCore:
2009-07-09 Roland Steiner <rolandsteiner@google.com>
Reviewed by Maciej Stachowiak.
Implement the part of HTML5 spec that deals with parsing of <rp> and <rt> tags
in that their end tags are optional if followed by <rp>/<rt>.
Also specify a new accessibility role "annotation" for <rp> and <rt>.
Affected code parts are not enclosed in #IF ENABLE(RUBY), since the parsing
is not affected by whether ruby is rendered properly or not (in fact, it may
be more profound without ruby layouting, since the contents of <rp> are not hidden).
Test: fast/ruby/parse-rp.html
- accessibility/AccessibilityObject.h: (WebCore::):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::roleValue):
- html/HTMLElement.cpp: (WebCore::HTMLElement::endTagRequirement): (WebCore::HTMLElement::tagPriority): (WebCore::inlineTagList):
- html/HTMLParser.cpp: (WebCore::HTMLParser::rpCreateErrorCheck): (WebCore::HTMLParser::rtCreateErrorCheck): (WebCore::HTMLParser::getNode):
- html/HTMLParser.h:
- html/HTMLTagNames.in:
LayoutTests:
2009-07-09 Roland Steiner <rolandsteiner@google.com>
Reviewed by Maciej Stachowiak.
Test proper parsing of HTML5 <rp> and <rt> tags.
Both tags are optional if followed by another <rp>/<rt> tag.
- fast/ruby: Added.
- fast/ruby/parse-rp-expected.txt: Added.
- fast/ruby/parse-rp.html: Added.
- 9:29 PM Changeset in webkit [45697] by
-
- 5 edits in trunk/WebCore
2009-07-09 Dmitry Titov <dimich@chromium.org>
Not reviewed, fix for previous commit.
The change http://trac.webkit.org/changeset/45695 did not correctly
enabled GTL and QT build flags. This caused layout tests failure.
This is speculative fix for those failures.
- GNUmakefile.am: added ENABLE_CHANNEL_MESSAGING flag.
- WebCore.pro: ditto.
- page/DOMWindow.idl: touched to cause recompile.
- workers/WorkerContext.idl: ditto.
- 8:45 PM Changeset in webkit [45696] by
-
- 3 edits7 adds in trunk
2009-07-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
REGRESSION: crash in edge cases of floating point parsing.
https://bugs.webkit.org/show_bug.cgi?id=27110
<rdar://problem/7044458>
Tests: fast/css/number-parsing-crash.html
fast/css/number-parsing-crash.html
fast/js/number-parsing-crash.html
- wtf/dtoa.cpp: (WTF::BigInt::BigInt): Converted this to more a proper class, using a Vector with inline capacity
(WTF::lshift): Rearranged logic somewhat nontrivially to deal with the new way of sizing BigInts.
Added an assertion to verify that invariants are maintained.
All other functions are adapted fairly mechanically to the above changes.
(WTF::BigInt::clear):
(WTF::BigInt::size):
(WTF::BigInt::resize):
(WTF::BigInt::words):
(WTF::BigInt::append):
(WTF::multadd):
(WTF::s2b):
(WTF::i2b):
(WTF::mult):
(WTF::cmp):
(WTF::diff):
(WTF::b2d):
(WTF::d2b):
(WTF::ratio):
(WTF::strtod):
(WTF::quorem):
(WTF::dtoa):
2009-07-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
REGRESSION: crash in edge cases of floating point parsing.
<rdar://problem/7044458>
https://bugs.webkit.org/show_bug.cgi?id=27110
Test cases for both JavaScript and CSS use of dtoa.
- fast/css/number-parsing-crash-2-expected.txt: Added.
- fast/css/number-parsing-crash-2.html: Added.
- fast/css/number-parsing-crash-expected.txt: Added.
- fast/css/number-parsing-crash.html: Added.
- fast/js/number-parsing-crash-expected.txt: Added.
- fast/js/number-parsing-crash.html: Added.
- fast/js/resources/number-parsing-crash.js: Added.
- 8:20 PM Changeset in webkit [45695] by
-
- 22 edits16 moves in trunk
2009-07-09 Drew Wilson <atwilson@google.com>
Reviewed by Alexey Proskuryakov.
Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.
- configure.ac: enable CHANNEL_MESSAGING.
2009-07-09 Drew Wilson <atwilson@google.com>
Reviewed by Alexey Proskuryakov.
Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.
- Configurations/FeatureDefines.xcconfig:
WebCore:
2009-07-09 Drew Wilson <atwilson@google.com>
Reviewed by Alexey Proskuryakov.
Turned on CHANNEL_MESSAGING by default because the MessageChannel API
is now implemented for Web Workers and is reasonably stable.
Tests: fast/events/message-channel-gc-2.html
fast/events/message-channel-gc-3.html
fast/events/message-channel-gc-4.html
fast/events/message-channel-gc.html
fast/events/message-channel-listener-circular-ownership.html
fast/events/message-port-clone.html
fast/events/message-port-constructor-for-deleted-document.html
fast/events/message-port-deleted-document.html
fast/events/message-port-deleted-frame.html
fast/events/message-port-inactive-document.html
fast/events/message-port-no-wrapper.html
fast/events/message-port.html
fast/workers/worker-cloneport.html
fast/workers/worker-messageport-gc.html
fast/workers/worker-messageport.html
- Configurations/FeatureDefines.xcconfig: Turned on ENABLE_CHANNEL_MESSAGING.
- WebCore/WebCore.vcproj/WebCoreCommon.vsprops: ditto.
- WebCore/WebCore.vcproj/build-generated-files.sh: ditto.
- WebCore/page/DOMWindow.idl: touch the file to cause re-generation of headers.
- WebCore/workers/WorkerContext.idl: ditto.
WebKit/mac:
2009-07-09 Drew Wilson <atwilson@google.com>
Reviewed by Alexey Proskuryakov.
Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.
- Configurations/FeatureDefines.xcconfig:
WebKit/win:
2009-07-09 Drew Wilson <atwilson@google.com>
Reviewed by Alexey Proskuryakov.
Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.
- WebKit.vcproj/WebKit.vcproj:
WebKitTools:
2009-07-09 Drew Wilson <atwilson@google.com>
Reviewed by Alexey Proskuryakov.
Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.
- Scripts/build-webkit:
LayoutTests:
2009-07-09 Drew Wilson <atwilson@google.com>
Reviewed by Alexey Proskuryakov.
Turned on CHANNEL_MESSAGING by default, re-enabled the various tests, and updated expected results.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/constructors-cached-navigate-expected.txt:
- fast/events/message-channel-gc-2.html: Renamed from LayoutTests/fast/events/message-channel-gc-2.html-disabled.
- fast/events/message-channel-gc-3.html: Renamed from LayoutTests/fast/events/message-channel-gc-3.html-disabled.
- fast/events/message-channel-gc-4.html: Renamed from LayoutTests/fast/events/message-channel-gc-4.html-disabled.
- fast/events/message-channel-gc.html: Renamed from LayoutTests/fast/events/message-channel-gc.html-disabled.
- fast/events/message-channel-listener-circular-ownership.html: Renamed from LayoutTests/fast/events/message-channel-listener-circular-ownership.html-disabled.
- fast/events/message-port-clone.html: Renamed from LayoutTests/fast/events/message-port-clone.html-disabled.
- fast/events/message-port-constructor-for-deleted-document.html: Renamed from LayoutTests/fast/events/message-port-constructor-for-deleted-document.html-disabled.
- fast/events/message-port-deleted-document.html: Renamed from LayoutTests/fast/events/message-port-deleted-document.html-disabled.
- fast/events/message-port-deleted-frame.html: Renamed from LayoutTests/fast/events/message-port-deleted-frame.html-disabled.
- fast/events/message-port-inactive-document.html: Renamed from LayoutTests/fast/events/message-port-inactive-document.html-disabled.
- fast/events/message-port-no-wrapper.html: Renamed from LayoutTests/fast/events/message-port-no-wrapper.html-disabled.
- fast/events/message-port.html: Renamed from LayoutTests/fast/events/message-port.html-disabled.
- fast/js/global-constructors-expected.txt:
- fast/workers/worker-cloneport.html: Renamed from LayoutTests/fast/workers/worker-cloneport.html-disabled.
- fast/workers/worker-messageport-gc.html: Renamed from LayoutTests/fast/workers/worker-messageport-gc.html-disabled.
- fast/workers/worker-messageport.html: Renamed from LayoutTests/fast/workers/worker-messageport.html-disabled.
- http/tests/security/MessagePort/event-listener-context.html: Renamed from LayoutTests/http/tests/security/MessagePort/event-listener-context.html-disabled
- 8:01 PM Changeset in webkit [45694] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
- 7:44 PM Changeset in webkit [45693] by
-
- 2 edits in trunk/JavaScriptCore
Bug 27016 - Interpreter crashes due to invalid array indexes
<https://bugs.webkit.org/show_bug.cgi?id=27016>
Reviewed by Darin Adler.
Unsigned vs signed conversions results in incorrect behaviour in
64bit interpreter builds.
- 7:15 PM Changeset in webkit [45692] by
-
- 2 edits in trunk/WebCore
2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>
A more robust fix for <rdar://problem/6930280> Reproducible crash at
USA Today photo gallery
Reviewed by Steve Falkenburg.
- plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired): Protect the PluginView from destruction before calling its window proc.
- 7:15 PM Changeset in webkit [45691] by
-
- 2 edits in trunk/WebCore
2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
Reviewed by Darin Adler.
- plugins/PluginView.cpp: (WebCore::PluginView::bindingInstance): Protect the PluginView from destruction before calling NPN_GetValue. If the renderer for the PluginView was destroyed during the call, and the PluginView's ref count is now 1, return null.
- 7:15 PM Changeset in webkit [45690] by
-
- 2 edits in trunk/WebCore
2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>
Speculative fix for <rdar://problem/6991251> WER #13: Crash in
WebKit!WebCore::PluginView::performRequest+203 (1311461169)
Reviewed by Darin Adler.
- plugins/PluginView.cpp: (WebCore::PluginView::performRequest): Protect the PluginView from destruction before performing a load. Removed some trailing whitespace.
- 6:49 PM Changeset in webkit [45689] by
-
- 2 edits in trunk/WebKit/win
2009-07-09 Brian Weinstein <bweinstein@apple.com>
Reviewed by Alice Liu.
Fix of <rdar://5712929> Add preferences key to remember if the Inspector was docked (14271)
https://bugs.webkit.org/show_bug.cgi?id=27140
Added a preference key to remember whether the user prefers the inspector detached or attached.
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindow): Pass both parameters into setWindowVisible (WebInspectorClient::closeWindow): Ditto (WebInspectorClient::attachWindow): Set preference to attached windows here (WebInspectorClient::detachWindow): Set preference to detached windows here (WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached (WebInspectorClient::onClose): Pass both parameters into setWindowVisible
- 6:19 PM Changeset in webkit [45688] by
-
- 2 edits in trunk/WebKit/mac
2009-07-09 Darin Adler <Darin Adler>
Reviewed by Adele Peterson and Dan Bernstein.
<rdar://problem/7024972> Cannot set font to Helvetica Neue Light in Mail compose window
No regression test because this only affects the font panel.
- WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]): Fix code that detects whether the font would survive a round trip by using the weight corresponding to "bold" or "normal" rather than the actual weight number.
- 6:04 PM Changeset in webkit [45687] by
-
- 8 edits1 copy2 deletes in trunk
WebCore:
2009-07-09 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Full page zoom breaks remaining and elapsed time display in the <video> controller.
https://bugs.webkit.org/show_bug.cgi?id=27123
We are changing the size of the time remaining and time elapsed field, to
automatically hide them, when the controller is too short.
Because we toggle the size between 0 and the previous value of the
controller, we miss any width change that may occur during full page zoom,
and we fail to restore a correct width.
This change fixes that problem by using a cloned style on which we
set the width to 0, and restoring the previous style when going back to
the normal width.
We take care about properly using the cloned style or the pseudo style,
by overriding styleForElement().
- rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::styleForElement): (WebCore::MediaControlElement::attach): (WebCore::MediaControlElement::updateStyle): (WebCore::MediaControlInputElement::styleForElement): (WebCore::MediaControlInputElement::attach): (WebCore::MediaControlInputElement::updateStyle): (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement): (WebCore::MediaControlTimeDisplayElement::styleForElement): (WebCore::MediaControlTimeDisplayElement::setVisible):
- rendering/MediaControlElements.h:
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::shouldShowTimeDisplayControls): Make sure we take in account the zoom level when deciding if we should hide the ellapsed and remaining time.
LayoutTests:
2009-07-09 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Full page zoom breaks remaining and elapsed time display in the <video> controller.
https://bugs.webkit.org/show_bug.cgi?id=27123
- media/video-zoom-controls.html: Remove duplicated code.
- platform/mac-leopard/media/video-zoom-controls-expected.txt: Copied from LayoutTests/platform/mac/media/video-zoom-controls-expected.txt.
- platform/mac-snowleopard/Skipped:
- platform/mac/media/video-zoom-controls-expected.checksum: Removed. The test is not reliable for pixel test.
- platform/mac/media/video-zoom-controls-expected.png: Removed.
- platform/mac/media/video-zoom-controls-expected.txt: Updated
- 6:00 PM Changeset in webkit [45686] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/27114> bugzilla-tool: Parse short bug URL from commit log messages
Reviewed by Adam Roben.
- Scripts/bugzilla-tool: (bug_id_from_commit_message): Check for the short bug URL before checking for the longer bugs.webkit.org URL.
- 5:55 PM Changeset in webkit [45685] by
-
- 3 edits in trunk/WebCore
2009-07-09 Michael Nordman <Michael Nordman>
Reviewed by Darin Adler.
Fix chromium build bustage due to Widget being a RefCounted class.
https://bugs.webkit.org/show_bug.cgi?id=27139
- platform/chromium/PopupMenuChromium.cpp:
- platform/chromium/PopupMenuChromium.h:
- 5:41 PM Changeset in webkit [45684] by
-
- 4 edits2 adds in trunk
Bug 27130 - Need to implement ARIA role="toolbar"
https://bugs.webkit.org/show_bug.cgi?id=27130
- 4:26 PM Changeset in webkit [45683] by
-
- 2 edits2 adds in trunk
2009-07-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[Chromium] Upstream JavaScriptCore.gypi, the project file for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=27135
- JavaScriptCore.gypi: Added.
WebCore:
2009-07-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[Chromium] Upstream WebCore.gypi, the project file for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=27135
- WebCore.gypi: Added.
- 4:03 PM Changeset in webkit [45682] by
-
- 2 edits in trunk/WebCore
2009-07-09 Jon Honeycutt <jhoneycutt@apple.com>
Build fix.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
- 3:54 PM Changeset in webkit [45681] by
-
- 7 edits in trunk/WebKit/win
Reviewed by Oliver Hunt.
<rdar://problem/6921671> Visit count shouldn't be incremented by redirects.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Do not increase visit count if there is a redirect source. As a result, only pages that were explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking a link) will be counted.
- Interfaces/IWebHistoryItemPrivate.idl:
- WebHistory.cpp: (WebHistory::visitedURL):
- WebHistory.h:
- WebHistoryItem.cpp: (WebHistoryItem::visitedWithTitle):
- WebHistoryItem.h: Marshal this new argument all the way down to WebCore.
- 3:33 PM Changeset in webkit [45680] by
-
- 4 edits in trunk/WebCore
2009-07-09 Simon Fraser <Simon Fraser>
Build fix for SnowLeopard.
Avoid using the contentsTransform methods if not on Leopard, because
we don't need to call them.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateContentsTransform):
- platform/graphics/mac/WebLayer.mm: (-[WebLayer setNeedsDisplayInRect:]):
- platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]):
- 3:26 PM Changeset in webkit [45679] by
-
- 37 edits in trunk
WebCore:
2009-07-09 Beth Dakin and Jon Honeycutt <Beth Dakin>
Reviewed by Dave Hyatt.
Make Widget RefCounted to fix or make fixable:
<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createPlugin): Changed to return PassRefPtr (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::loadPlugin): Make the widget variable a RefPtr. Use .get() when passing it to RenderPart::setWidget(). (WebCore::FrameLoader::createJavaAppletWidget): Make the widget variable a RefPtr.
- loader/FrameLoader.h: Changed the return type of createJavaAppletWidget().
- loader/FrameLoaderClient.h: Change the return types of createPlugin() and createJavaAppletWidget().
- page/Frame.cpp: (WebCore::Frame::createView): No need to call .get() since setWidget() takes a RefPtr.
- page/FrameView.cpp: (WebCore::FrameView::layoutIfNeededRecursive): children() now returns a HashSet of RefPtrs.
- page/FrameView.h: Remove inheritance from RefCounted; we pick this up from ScrollView through Widget.
- platform/ScrollView.cpp: (WebCore::ScrollView::addChild): addChild() now takes a PassRefPtr and m_children now keeps a HashSet of RefPtrs.
- platform/ScrollView.h: ScrollView constructor is now protected. (WebCore::ScrollView::children): m_children is now a HashSet of RefPtrs.
- platform/Scrollbar.h: Remove inheritance from RefCounted; we pick this up from ScrollView through Widget.
- platform/Widget.h: Inherit from RefCounted. Cleaned up some whitespace. Make m_widget a RefPtr.
- plugins/PluginView.cpp: (WebCore::PluginView::create): Adopt the PluginView when returning it.
- plugins/PluginView.h: Changed create() to return a PassRefPtr.
- rendering/RenderApplet.cpp: Receive result in a RefPtr when calling createJavaAppletWidget().
- rendering/RenderPart.cpp: (WebCore::RenderPart::setWidget): setWidget() now takes a PassRefPtr. Also removed the manual ref of FrameViews. This is handled by having m_widget be a RefPtr. Removed deleteWidget().
- rendering/RenderPart.h: Removed override of deleteWidget().
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::setWidget): (WebCore::RenderWidget::paint): (WebCore::RenderWidget::setOverlapTestResult): (WebCore::RenderWidget::updateWidgetPosition): Use .get(). (WebCore::RenderWidget::clearWidget): Don't call deleteWidget(). It was removed.
- rendering/RenderWidget.h: Removed deleteWidget(). Made m_widget a RefPtr. (WebCore::RenderWidget::widget): Use .get().
WebKit/gtk:
2009-07-09 Beth Dakin and Jon Honeycutt <Beth Dakin>
Reviewed by Dave Hyatt.
Make Widget RefCounted to fix:
<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin): (WebKit::FrameLoaderClient::createJavaAppletWidget):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2009-07-09 Beth Dakin and Jon Honeycutt <Beth Dakin>
Reviewed by Dave Hyatt.
Make Widget RefCounted to fix:
<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
WebKit/qt:
2009-07-09 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Make Widget RefCounted to fix:
<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin): (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
2009-07-09 Beth Dakin and Jon Honeycutt <Beth Dakin>
Reviewed by Dave Hyatt.
Make Widget RefCounted to fix:
<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp: (WebFrame::createJavaAppletWidget):
- WebFrame.h:
WebKit/wx:
2009-07-09 Beth Dakin and Jon Honeycutt <Beth Dakin>
Reviewed by Dave Hyatt.
Make Widget RefCounted to fix:
<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::createPlugin): (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
- WebKitSupport/FrameLoaderClientWx.h:
- 3:17 PM Changeset in webkit [45678] by
-
- 25 edits in trunk/WebKit
WebKit/mac:
2009-07-09 Sam Weinig <sam@webkit.org>
Reviewed by Steve Falkenburg.
Roll out r43848. The quirk is no longer necessary.
- WebView/WebView.mm: (-[WebView WebCore::_userAgentForURL:WebCore::]):
WebKit/win:
2009-07-09 Sam Weinig <sam@webkit.org>
Reviewed by Steve Falkenburg.
Roll out r43848. The quirk is no longer necessary.
- WebView.cpp: (WebView::userAgentForKURL):
- 3:11 PM Changeset in webkit [45677] by
-
- 3 edits2 adds in trunk
Bug 27129 - AX: possible assertion for a non-native image in accessibility
https://bugs.webkit.org/show_bug.cgi?id=27129
- 2:57 PM Changeset in webkit [45676] by
-
- 8 edits in trunk/WebCore
2009-07-09 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Improve the appearance of text in compositing layers when -[CALayer geometryFlipped]
is not available.
<rdar://problem/6120614>
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsOrientation): (WebCore::GraphicsLayer::contentsOrientation):
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): Add a m_contentsOrientation member and getter/setter to control whether the contents of this layer have a transform applied to them before display.
- platform/graphics/mac/GraphicsLayerCA.h: New method to return the default contents orientation.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::flipTransform): Convenience method to return a transform with a Y flip.
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setSize):
After the size changes we have to update the contentsTransform.
(WebCore::GraphicsLayerCA::setGeometryOrientation):
(WebCore::GraphicsLayerCA::geometryOrientation):
If -setGeometryFlipped: is not available, use a children transform.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Tiled layers have issues with flipped contentsTransform, so just use
top-down drawing for them. Call updateContentsTransform() to set the
new contents transform after swapping layers.
(WebCore::GraphicsLayerCA::defaultContentsOrientation):
Use bottom-up when -geometryFlipped is not available, otherwise top-down.
(WebCore::GraphicsLayerCA::updateContentsTransform):
Set the layer contents transform based on contentsOrientation().
(WebCore::GraphicsLayerCA::setContentsLayer):
We have to manually flip contents layers if we're not using -geometryFlipped.
- platform/graphics/mac/WebLayer.h:
- platform/graphics/mac/WebLayer.mm: Do early return if layerContents is nil. Flip the CTM if the layer has bottom-up coordinates, so that CG sees a CTM with no flip. Do the CGContextRestoreGState() after drawing the debug indicator.
(-[WebLayer setNeedsDisplayInRect:]):
- platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]): Need to map the dirty rect through the contentsTransform.
- 2:53 PM Changeset in webkit [45675] by
-
- 10 edits in trunk
Reviewed by Geoff Garen.
<rdar://problem/6921671> Visit counter shouldn't be incremented by redirects.
Can't test this functionality with layout tests.
WebCore:
- WebCore.base.exp:
- history/HistoryItem.cpp: (WebCore::HistoryItem::recordVisitAtTime): (WebCore::HistoryItem::visited):
- history/HistoryItem.h: Only increase visit count if explicitly told to. Now, some visits change last access time, but do not increase visit count.
WebKit:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Do not increase visit count if there is a redirect source. As a result, only pages that were explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking a link) will be counted.
- History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
- History/WebHistoryInternal.h:
- History/WebHistoryItem.mm: (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
- History/WebHistoryItemInternal.h: Marshal this new argument all the way down to WebCore.
- 2:47 PM Changeset in webkit [45674] by
-
- 2 edits in trunk/WebCore
2009-07-09 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7046098> MediaControllerThemeQT requires QuickTime 7.6.3
Require QuickTime 7.6.3 or higher to enable the new media controller UI.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
- 1:57 PM Changeset in webkit [45673] by
-
- 2 edits in trunk/WebCore
2009-07-09 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Remove incorrect comment.
- page/MouseEventWithHitTestResults.h:
- 1:49 PM Changeset in webkit [45672] by
-
- 1 edit in tags/Safari-6531.3/WebKitLibraries/win/tools/scripts/PRODUCTVERSION
Versioning.
- 1:42 PM Changeset in webkit [45671] by
-
- 4 edits in trunk
Versioning.
- 1:40 PM Changeset in webkit [45670] by
-
- 1 copy in tags/Safari-6531.3
New tag.
- 1:00 PM Changeset in webkit [45669] by
-
- 3 edits in trunk/JavaScriptCore
2009-07-09 Joe Mason <joe.mason@torchmobile.com>
Reviewed by George Staikos.
Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>
https://bugs.webkit.org/show_bug.cgi?id=27031
Add an override for deleteOwnedPtr(HDC) on Windows
- wtf/OwnPtrCommon.h:
- wtf/OwnPtrWin.cpp: (WTF::deleteOwnedPtr):
- 12:20 PM Changeset in webkit [45668] by
-
- 2 edits in trunk/WebKitSite
JavaScript section of http://webkit.org is excessively out of date.
Reviewed by Geoff Garen.
This removes old todo entries (like adding an API, which we've had since Leopard),
and adds an additional todo for a webkit-less Objective-C API.
- 12:11 PM Changeset in webkit [45667] by
-
- 3 edits in trunk/JavaScriptCore
2009-07-09 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Guard singal.h dependency with HAVE(SIGNAL_H) to enable building jsc
on SYMBIAN.
Based on Norbert Leser's work.
- jsc.cpp: (printUsageStatement): (parseArguments):
- wtf/Platform.h:
- 11:18 AM Changeset in webkit [45666] by
-
- 2 edits in trunk/WebCore
2009-07-09 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
Update the V8 bindings codegenerator to use the RGBColor::create
method to handle refcounts for RGBColor objects correctly.
- bindings/scripts/CodeGeneratorV8.pm: Use RGBColor::create to create RGBColor objects.
- 10:41 AM Changeset in webkit [45665] by
-
- 2 edits in trunk/WebCore
2009-07-09 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Crash in RenderMedia::styleDidChange.
<rdar://problem/7044313> CrashTracer: quicklook crashed generating thumbnail for page with
media element (RenderMedia::styleDidChange + 115)
Speculative fix for crash in styleDidChange. Null check controller elements before tell
them to update style.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange):
- 10:37 AM Changeset in webkit [45664] by
-
- 3 edits2 adds in trunk/WebCore
2009-07-09 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Move V8DOMWrapper to its own file
https://bugs.webkit.org/show_bug.cgi?id=27121
- bindings/v8/V8DOMWrapper.cpp: Added. (WebCore::GetToStringName): (WebCore::ConstructorToString): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::domObjectHasJSWrapper): (WebCore::V8DOMWrapper::setJSWrapperForDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForDOMNode): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::domWrapperType): (WebCore::V8DOMWrapper::convertToNativeObjectImpl): (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::lookupDOMWrapper): (WebCore::V8DOMWrapper::convertDOMWrapperToNodeHelper): (WebCore::V8DOMWrapper::wrapNativeNodeFilter): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::setDOMWrapper): (WebCore::V8DOMWrapper::maybeDOMWrapper): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::isWrapperOfType): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object):
- bindings/v8/V8DOMWrapper.h: Added. (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::wrapCPointer): (WebCore::V8DOMWrapper::extractCPointer): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent): (WebCore::V8DOMWrapper::extractCPointerImpl): (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- 10:20 AM Changeset in webkit [45663] by
-
- 2 edits in trunk/WebCore
2009-07-09 David Hyatt <hyatt@apple.com>
Reviewed by Adele Peterson.
Crash in setFocusedFrame.
<rdar://7032869> Crashing in setFocusedFrame on blogger.com.
Speculative fix for crasher in setFocusedFrame. Make sure to ref both frames and fire
the events only after the local member has been updated.
- page/FocusController.cpp: (WebCore::FocusController::setFocusedFrame):
- 10:05 AM Changeset in webkit [45662] by
-
- 8 edits8 adds in trunk
2009-07-09 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Possible crashes when mouse clicks not dispatched because range input destroyed while
thumb is being dragged (e.g. scrub to end of movie)
<rdar://problem/7037494>
https://bugs.webkit.org/show_bug.cgi?id=27101
Some shadow nodes "capture" all mouse events from mouseDown to mouseUp so they continue to
get mouse events even when the mouse is moved outside of the node. This is done by putting
EventHandler into a mode where it sends all mouse events to the node regardless of the
actual mouse position. The mode is set on mouseDown and cleared on mouseUp but if the
node is deleted while in this mode, the mouseUp is never sent and EventHandler continues
to try to send events to the deleted node. This sometimes results in a crash, and sometimes
in a page that doesn't respond to click events.
Tests: fast/forms/search-delete-while-cancel-button-clicked.html
fast/forms/slider-delete-while-dragging-thumb.html
media/audio-delete-while-slider-thumb-clicked.html
media/audio-delete-while-step-button-clicked.html
- rendering/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::detach):
New, call setCapturingMouseEventsNode if capturing mouse events.
- rendering/MediaControlElements.h:
Declare detach().
- rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::detach):
New, call setCapturingMouseEventsNode if capturing mouse events.
- rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::detach):
New, call setCapturingMouseEventsNode if capturing mouse events.
- rendering/TextControlInnerElements.h:
Declare detach().
2009-07-09 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Possible crashes when mouse clicks not dispatched because range input destroyed while
thumb is being dragged (e.g. scrub to end of movie)
<rdar://problem/7037494>
https://bugs.webkit.org/show_bug.cgi?id=27101
Tests deleting a control while capturing mouse events.
- fast/forms/search-delete-while-cancel-button-clicked-expected.txt: Added.
- fast/forms/search-delete-while-cancel-button-clicked.html: Added.
- fast/forms/slider-delete-while-dragging-thumb-expected.txt: Added.
- fast/forms/slider-delete-while-dragging-thumb.html: Added.
- media/audio-delete-while-slider-thumb-clicked-expected.txt: Added.
- media/audio-delete-while-slider-thumb-clicked.html: Added.
- media/audio-delete-while-step-button-clicked-expected.txt: Added.
- media/audio-delete-while-step-button-clicked.html: Added.
- platform/mac-snowleopard/Skipped:
Skip the new media controller tests until <rdar://problem/6502936> is fixed.
- 8:50 AM Changeset in webkit [45661] by
-
- 2 edits in trunk/WebCore
2009-07-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dimitri Glazkov.
Enter the Frame's context before creating new objects in setContextDebugId.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
- 1:58 AM Changeset in webkit [45660] by
-
- 2 edits in trunk/WebCore
2009-07-09 Simon Hausmann <Simon Hausmann>
Fix the Qt build.
- WebCore.pro: Add new storage impl files to the build.
- 12:11 AM Changeset in webkit [45659] by
-
- 72 edits in trunk/WebCore
2009-07-08 Adam Barth <abarth@webkit.org>
Rubber stamped by Eric Seidel.
[V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=27107
This patch is just renaming. Code motion will occur next.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
- bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::getReceiverObject):
- bindings/v8/V8Collection.cpp: (WebCore::toOptionsCollectionSetter):
- bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::getNamedPropertyOfCollection): (WebCore::nodeCollectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::nodeCollectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter):
- bindings/v8/V8DOMMap.cpp: (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::removeObjectsFromWrapperMap):
- bindings/v8/V8GCController.cpp: (WebCore::enumerateDOMObjectMap): (WebCore::DOMObjectVisitor::visitDOMWrapper): (WebCore::GCPrologueVisitor::visitDOMWrapper): (WebCore::GCEpilogueVisitor::visitDOMWrapper):
- bindings/v8/V8Helpers.cpp: (WebCore::wrapNPObject):
- bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode):
- bindings/v8/V8Proxy.cpp: (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::domObjectHasJSWrapper): (WebCore::V8DOMWrapper::setJSWrapperForDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): (WebCore::V8DOMWrapper::setJSWrapperForDOMNode): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::getConstructor): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8Proxy::retrieveWindow): (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::installDOMWindow): (WebCore::setDOMExceptionHelper): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::domWrapperType): (WebCore::V8DOMWrapper::convertToNativeObjectImpl): (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl): (WebCore::V8DOMWrapper::lookupDOMWrapper): (WebCore::V8DOMWrapper::convertDOMWrapperToNodeHelper): (WebCore::V8DOMWrapper::wrapNativeNodeFilter): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::setDOMWrapper): (WebCore::V8DOMWrapper::maybeDOMWrapper): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::isWrapperOfType): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8Proxy::bindJsObjectToWindow):
- bindings/v8/V8Proxy.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::wrapCPointer): (WebCore::V8DOMWrapper::extractCPointer): (WebCore::V8DOMWrapper::convertDOMWrapperToNode): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertToNativeObject): (WebCore::V8DOMWrapper::convertToNativeEvent): (WebCore::V8DOMWrapper::extractCPointerImpl): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8Proxy::constructDOMObject): (WebCore::toV8):
- bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGPODTypeUtil::toSVGPODType):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::GetConstructor): (WebCore::WorkerContextExecutionProxy::ToV8Object): (WebCore::WorkerContextExecutionProxy::EventToV8Object): (WebCore::WorkerContextExecutionProxy::toV8):
- bindings/v8/custom/V8AttrCustom.cpp: (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER):
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8): (WebCore::toCanvasStyle): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8ClientRectListCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER):
- bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8CustomBinding.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK): (WebCore::V8Custom::GetTargetFrame):
- bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::V8Custom::ClearTimeoutImpl): (WebCore::NAMED_ACCESS_CHECK): (WebCore::INDEXED_ACCESS_CHECK):
- bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
- bindings/v8/custom/V8EventCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER):
- bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::removeElement):
- bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_ACCESS_CHECK): (WebCore::NAMED_ACCESS_CHECK):
- bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8NavigatorCustom.cpp: (WebCore::ACCESSOR_GETTER):
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Custom::v8StorageNamedPropertyEnumerator): (WebCore::storageGetter): (WebCore::storageSetter): (WebCore::storageDeleter):
- bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::SetTimeoutOrInterval): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
Jul 8, 2009:
- 9:12 PM Changeset in webkit [45658] by
-
- 6 edits in trunk
WebCore:
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure we can click outside the slider thumb and start dragging.
https://bugs.webkit.org/show_bug.cgi?id=26229
Previously we were assuming that if the thumb hasn't been clicked, we
wouldn't issue any value change upon dragging.
We need to handle the two different cases:
- Clicked in the thumb, we need to make sure the cursor is always pointing the same slider thumb point.
- Clicked outside, the cursor should always be pointing to the center of the thumb.
For simplicity, we don't remember the original point of the mouse down,
but an offset between that point and the thumb.
- rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::SliderThumbElement): (WebCore::SliderThumbElement::defaultEventHandler): (WebCore::RenderSlider::mouseEventOffsetToThumb): Utility function.
- rendering/RenderSlider.h:
LayoutTests:
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure we can click outside the slider thumb and start dragging.
https://bugs.webkit.org/show_bug.cgi?id=26229
Along with the events chain, test that the slider value are correct,
and that clicking outside the slider and dragging works as expected.
- fast/forms/slider-mouse-events-expected.txt:
- fast/forms/slider-mouse-events.html:
- 9:09 PM Changeset in webkit [45657] by
-
- 3 edits in trunk/JavaScriptGlue
2009-07-08 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein
- fix <rdar://problem/6971484> REGRESSION (r30534): "Scrolling Credits" effect does not scroll on iMovie 7.1.4 on Tiger
In <http://trac.webkit.org/changeset/30534>, the prototype of
JSObject::put() which UserObjectImp had been overriding changed, but
UserObjectImp wasn't updated, so its override was no longer getting
called after that.
- UserObjectImp.cpp: (UserObjectImp::put): Match the current prototype of JSObject::put(). The PutPropertySlot argument is unused.
- UserObjectImp.h: Ditto.
- 6:29 PM Changeset in webkit [45656] by
-
- 1 edit in trunk/WebKitLibraries/win/tools/scripts/PRODUCTVERSION
Versioning.
- 6:25 PM Changeset in webkit [45655] by
-
- 9 edits1 copy in trunk
WebCore:
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=27100
<rdar://problem/7042621>
Don't display "loading" in the <video> controller when
there is no src specified.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlStatusDisplayElement::update): The only way to find out if we have an element is currentSrc(). networkState() will always report LOADING according to the spec.
LayoutTests:
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Reenable media/video-empty-source.html. Test the controls
look when there is no src specified in a <video> element.
- platform/mac-leopard/media/video-empty-source-expected.checksum:
- platform/mac-leopard/media/video-empty-source-expected.png:
- platform/mac-leopard/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/mac/media/video-empty-source-expected.txt.
- platform/mac-snowleopard/Skipped:
- platform/mac/media/video-empty-source-expected.checksum:
- platform/mac/media/video-empty-source-expected.png:
- platform/mac/media/video-empty-source-expected.txt:
- 6:25 PM Changeset in webkit [45654] by
-
- 4 edits in trunk/WebKitTools
Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and actually work
Reviewed by Eric Seidel.
Removed the required BUGID argument from the "post-commits"
command and replaced it with a -bbug-id switch or parsing the commit log message for the bug URL. Fixed a bug in the
"post-commits" that would ignore the COMMITISH used and post a
patch of local changes against HEAD. Added --no-commit switch
to disable using the bulk of the ChangeLog entry as the comment
for the new patch.
- Scripts/bugzilla-tool: (bug_id_from_commit_message): Added. Returns a bug id from the commit log message, thus enforcing the need for a bug URL in the message. (PostCommitsAsPatchesToBug.init): Updated help description to match new behavior of pulling bug ids from commit log
messages instead of from the command line. Added -bbug-id switch and --no-comment switch.
(PostCommitsAsPatchesToBug.execute): Updated to use
bug_id_from_commit_message() to pull bug ids from commit log
messages. Also switched from SCM.create_patch() to use
SCM.create_patch_from_local_commit() to fix a bug where local
repository changes were posted as a patch instead of the
specific COMMITISH. Fall back to -bbug-id if no URL is found in the commit log message. Don't specify a comment for the
patch if --no-comment is used. Set cherry_pick argument to True
for Git.commit_ids_from_range_arguments() since we don't want
implicit commit range behavior for this command.
- Scripts/modules/bugzilla.py: Import datetime module. (timestamp): Added. Returns a timestamp in the form of "YYYYMMDDhhmmss". (Bugzilla.bug_server_regex): Added static attribute. (Bugzilla.add_patch_to_bug): Construct a more meaningful patch file name using the bug_id and timestamp().
- Scripts/modules/scm.py: (SCM.create_patch_from_local_commit): Added. (Git.create_patch_from_local_commit): Added. Runs "git diff" to return a patch for the given commit_id.
- 6:15 PM Changeset in webkit [45653] by
-
- 3 edits in trunk/LayoutTests
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Rubber-stamped by Simon Fraser.
Fix the media/controls-after-reload.html and media/controls-styling.html
on windows. (Needed a line at end of file)
- platform/win/media/controls-after-reload-expected.txt:
- platform/win/media/controls-styling-expected.txt:
- 5:15 PM Changeset in webkit [45652] by
-
- 3 edits2 adds in trunk/WebCore
2009-07-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] Move V8GCController functions to their own file
https://bugs.webkit.org/show_bug.cgi?id=27102
- bindings/v8/V8GCController.cpp: Added.
- bindings/v8/V8GCController.h: Added.
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- 4:55 PM Changeset in webkit [45651] by
-
- 10 edits4 copies in trunk/WebCore
2009-07-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Split StorageArea and StorageNamespace into an interface and implementation.
https://bugs.webkit.org/show_bug.cgi?id=27072
I need to split StorageNamespace and StorageArea into an interface and
implementation. In a later patch, I'll implement a proxy interface
that'll run inside the Chromium renderer process.
Additionally, fix the alphabetical ordering of files I recently added
in the project files.
This is a continuation of other refactoring work:
https://bugs.webkit.org/show_bug.cgi?id=25376
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/StorageArea.cpp: (WebCore::StorageArea::create):
- storage/StorageArea.h: (WebCore::StorageArea::~StorageArea):
- storage/StorageAreaImpl.cpp: Copied from WebCore/storage/StorageArea.cpp. (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy): (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear): (WebCore::StorageAreaImpl::contains): (WebCore::StorageAreaImpl::importItem): (WebCore::StorageAreaImpl::securityOrigin): (WebCore::StorageAreaImpl::close): (WebCore::StorageAreaImpl::blockUntilImportComplete): (WebCore::StorageAreaImpl::dispatchStorageEvent):
- storage/StorageAreaImpl.h: Copied from WebCore/storage/StorageArea.h.
- storage/StorageAreaSync.h:
- storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace):
- storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
- storage/StorageNamespaceImpl.cpp: Copied from WebCore/storage/StorageNamespace.cpp. (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea): (WebCore::StorageNamespaceImpl::close):
- storage/StorageNamespaceImpl.h: Copied from WebCore/storage/StorageNamespace.h.
- 4:26 PM Changeset in webkit [45650] by
-
- 108 edits35 copies1 delete in branches/nitro-extreme
Merged r45600:45633 into nitro-extreme branch.
- 4:06 PM Changeset in webkit [45649] by
-
- 1 edit in trunk/WebCore/bindings/v8/V8Proxy.cpp
Unreviewed fix for Chromium link errors.
- 3:59 PM Changeset in webkit [45648] by
-
- 1 edit in trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-head-base-href.pl
Unreviewed change: Mark echo-head-base-href.pl executable to try to make tree green.
- 3:58 PM Changeset in webkit [45647] by
-
- 2 edits in trunk/WebKitTools
2009-07-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Make prepare-ChangeLog less shouty
https://bugs.webkit.org/show_bug.cgi?id=27098
- Scripts/prepare-ChangeLog:
- 3:48 PM Changeset in webkit [45646] by
-
- 12 edits in trunk/WebCore
2009-07-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] Move garbage collector related functions from V8Proxy to V8GCController
https://bugs.webkit.org/show_bug.cgi?id=26967
This patch just moves the functions around in V8Proxy. We'll actually
move them to a separate file in another patch.
- bindings/v8/NPV8Object.cpp: (freeV8NPObject):
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::~ScheduledAction):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::gcProtectJSWrapper): (WebCore::ScriptController::gcUnprotectJSWrapper):
- bindings/v8/ScriptInstance.cpp: (WebCore::V8ScriptInstance::clear): (WebCore::V8ScriptInstance::set):
- bindings/v8/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::operator=): (WebCore::ScriptValue::clear):
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::disposeListenerObject):
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::~V8LazyEventListener): (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
- bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::V8NodeFilterCondition): (WebCore::V8NodeFilterCondition::~V8NodeFilterCondition):
- bindings/v8/V8Proxy.cpp: (WebCore::V8GCController::registerGlobalHandle): (WebCore::V8GCController::unregisterGlobalHandle): (WebCore::V8GCController::gcProtect): (WebCore::V8GCController::gcUnprotect): (WebCore::V8Proxy::destroyGlobal): (WebCore::V8Proxy::updateDocumentWrapper): (WebCore::V8Proxy::clearDocumentWrapper): (WebCore::V8Proxy::disposeContextHandles): (WebCore::V8Proxy::initContextIfNeeded):
- bindings/v8/V8Proxy.h: (WebCore::): (WebCore::GlobalHandleInfo::GlobalHandleInfo):
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
- 3:42 PM Changeset in webkit [45645] by
-
- 2 edits in trunk/LayoutTests
2009-07-08 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Holger Freyther a while ago.
Add two more tests to the Qt skip list due to missing DRT
features.
- platform/qt/Skipped:
- 3:36 PM Changeset in webkit [45644] by
-
- 11 edits4 deletes in trunk/WebCore
Reverting r45643 due to build bustage.
- 3:27 PM Changeset in webkit [45643] by
-
- 11 edits4 copies in trunk/WebCore
2009-07-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Split StorageArea and StorageNamespace into an interface and implementation.
https://bugs.webkit.org/show_bug.cgi?id=27072
I need to split StorageNamespace and StorageArea into an interface and
implementation. In a later patch, I'll implement a proxy interface
that'll run inside the Chromium renderer process.
Additionally, fix the alphabetical ordering of files I recently added
in the project files.
This is a continuation of other refactoring work:
https://bugs.webkit.org/show_bug.cgi?id=25376
- WebCore.xcodeproj/project.pbxproj:
- storage/StorageArea.cpp: (WebCore::StorageArea::create): (WebCore::StorageArea::~StorageArea):
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp: Copied from WebCore/storage/StorageArea.cpp. (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::copy): (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear): (WebCore::StorageAreaImpl::contains): (WebCore::StorageAreaImpl::importItem): (WebCore::StorageAreaImpl::securityOrigin): (WebCore::StorageAreaImpl::close): (WebCore::StorageAreaImpl::blockUntilImportComplete): (WebCore::StorageAreaImpl::dispatchStorageEvent):
- storage/StorageAreaImpl.h: Copied from WebCore/storage/StorageArea.h.
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
- storage/StorageAreaSync.h:
- storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespace::~StorageNamespace):
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp: Copied from WebCore/storage/StorageNamespace.cpp. (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea): (WebCore::StorageNamespaceImpl::close):
- storage/StorageNamespaceImpl.h: Copied from WebCore/storage/StorageNamespace.h.
- 3:13 PM Changeset in webkit [45642] by
-
- 6 edits18 adds in trunk
2009-07-08 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Prevents injection of HTML Base tag.
Tests: http/tests/security/xssAuditor/base-href-control-char.html
http/tests/security/xssAuditor/base-href-null-char.html
http/tests/security/xssAuditor/base-href-safe.html
http/tests/security/xssAuditor/base-href-safe2.html
http/tests/security/xssAuditor/base-href-scheme-relative.html
http/tests/security/xssAuditor/base-href.html
- html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::parseMappedAttribute): (WebCore::HTMLBaseElement::process): Modified to call XSSAuditor::canSetBaseElementURL to determine if it is safe to use base element URL.
- html/HTMLBaseElement.h: Added field m_hrefAttrValue to store unparsed base element URL.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL):
- page/XSSAuditor.h:
2009-07-08 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests prevention of injected HTML Base tag.
- http/tests/security/xssAuditor/base-href-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-control-char.html: Added.
- http/tests/security/xssAuditor/base-href-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-null-char.html: Added.
- http/tests/security/xssAuditor/base-href-safe-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-safe.html: Added.
- http/tests/security/xssAuditor/base-href-safe2-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-safe2.html: Added.
- http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-scheme-relative.html: Added.
- http/tests/security/xssAuditor/base-href.html: Added.
- http/tests/security/xssAuditor/resources/base-href: Added.
- http/tests/security/xssAuditor/resources/base-href/base-href-safe2.html: Added.
- http/tests/security/xssAuditor/resources/base-href/really-safe-script.js: Added.
- http/tests/security/xssAuditor/resources/base-href/safe-script.js: Added.
- http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Added.
- http/tests/security/xssAuditor/resources/safe-script.js: Added.
- 2:51 PM Changeset in webkit [45641] by
-
- 1 edit4 adds in trunk/WebCore
2009-07-08 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Upstream V8 npruntime bindings.
- 2:35 PM Changeset in webkit [45640] by
-
- 2 edits in trunk/WebCore
2009-07-08 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Darin Fisher.
Extending the PlatformFileHandle definition from PLATFORM(WIN) to
PLATFORM(WIN_OS)
- platform/FileSystem.h:
- 2:27 PM Changeset in webkit [45639] by
-
- 4 edits28 adds in trunk
2009-07-08 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Resolves issue when HTTP parameters contain null- and non-null-control- characters.
Tests: http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html
http/tests/security/xssAuditor/embed-tag-control-char.html
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/embed-tag.html
http/tests/security/xssAuditor/link-onclick-control-char.html
http/tests/security/xssAuditor/link-onclick-null-char.html
http/tests/security/xssAuditor/object-embed-tag-control-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag.html
http/tests/security/xssAuditor/object-tag.html
http/tests/security/xssAuditor/script-tag-post-control-char.html
http/tests/security/xssAuditor/script-tag-post-null-char.html
http/tests/security/xssAuditor/script-tag-with-source-control-char.html
http/tests/security/xssAuditor/script-tag-with-source-null-char.html
- page/XSSAuditor.cpp: (WebCore::isNonNullControlCharacter): Called by XSSAuditor::decodeURL. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): Added parameters matchNullCharacters, and matchNonNullControlCharacters. (WebCore::XSSAuditor::findInRequest): Added parameters matchNullCharacters, and matchNonNullControlCharacters.
- page/XSSAuditor.h:
2009-07-08 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests that HTTP parameters that contain null- and non-null-control characters are
properly handled by XSSAuditor.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html: Added.
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-control-char.html: Added.
- http/tests/security/xssAuditor/embed-tag-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-null-char.html: Added.
- http/tests/security/xssAuditor/embed-tag.html: Added.
- http/tests/security/xssAuditor/link-onclick-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick-control-char.html: Added.
- http/tests/security/xssAuditor/link-onclick-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick-null-char.html: Added.
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/object-embed-tag-control-char.html: Added.
- http/tests/security/xssAuditor/object-embed-tag-expected.txt: Added.
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/object-embed-tag-null-char.html: Added.
- http/tests/security/xssAuditor/object-embed-tag.html: Added.
- http/tests/security/xssAuditor/object-tag-expected.txt: Added.
- http/tests/security/xssAuditor/object-tag.html: Added.
- http/tests/security/xssAuditor/resources/execGetURL.swf: Added.
- http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-post-control-char.html: Added.
- http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-post-null-char.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-control-char.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-null-char.html: Added.
- 2:22 PM Changeset in webkit [45638] by
-
- 2 edits in trunk/WebKitTools
Bug 27083: bugzilla.py: Clean up bug_server use
Reviewed by Darin Adler.
- Scripts/modules/bugzilla.py: (Bugzilla.fetch_bug_ids_from_commit_queue): Use bug_server instead of hard-coding the URL. (Bugzilla.authenticate): Remove extra '/' before URL path. (Bugzilla.add_patch_to_bug): Ditto.
- 2:19 PM Changeset in webkit [45637] by
-
- 1 edit1 add in trunk/WebCore
2009-07-08 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Dimitri Glazkov.
Add DerivesSourcesAllInOne.cpp to help with release windows compilation.
https://bugs.webkit.org/show_bug.cgi?id=27093
This is specific for v8, no change in behavior.
- bindings/v8/DerivedSourcesAllInOne.cpp: Added.
- 2:14 PM Changeset in webkit [45636] by
-
- 3 edits in trunk/WebCore
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by NOBODY (OOPS!).
Make sure the Media controller doesn't fade in for no reason.
This is happening because a update() call to the controller
panel may reset the opacity to 1.0, given that it reloads the
style.
We also add a different fade in and fade out time to soften
the fade out effect.
No test case because this depends on how the movie is loaded.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): (WebCore::RenderMedia::updateControls): (WebCore::RenderMedia::updateControlVisibility): Simplify , and make sure we stop the timer if there is no animation to do. (WebCore::RenderMedia::opacityAnimationTimerFired):
- rendering/RenderMedia.h:
- 2:05 PM Changeset in webkit [45635] by
-
- 2 edits in trunk/WebCore
Bug 27081: Wrap RunLoopTimerCF.cpp in PLATFORM(MAC) && HAVE(RUNLOOP_TIMER)
Reviewed by Timothy Hatcher.
- platform/cf/RunLoopTimerCF.cpp: This code is only used on Mac OS X when HAVE(RUNLOOP_TIMER) is enabled, so wrap the code in that macro as well.
- 1:56 PM Changeset in webkit [45634] by
-
- 8 edits in trunk
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
WebCore:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
for clarity.
- WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::isProcessingUserGesture):
- loader/FrameLoader.h:
WebKit/mac:
2009-07-08 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add -[WebView _isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084
Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
so that WebView code can determine if a user gesture is in progress.
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
- WebView/WebViewPrivate.h:
- 1:34 PM Changeset in webkit [45633] by
-
- 6 edits in trunk/WebCore
Reviewed (an earlier version) by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=27090
Remove lockBackForwardList argument from HTMLFormElement::submit()
No change in behavior, so no tests.
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
- html/HTMLFormElement.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::scheduleFormSubmission):
- loader/FrameLoader.h: Don't pass lockBackForwardList around when it's known to be false.
- 1:32 PM Changeset in webkit [45632] by
-
- 2 edits in trunk/WebCore
2009-07-08 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Adam Barth.
Fix V8 idl codegen to use unique constant names
<https://bugs.webkit.org/show_bug.cgi?id=27089>
Embed the interface name in the global constant names so coagulating all
the .cc files into one compile unit works with V8 bindings.
Nothing added; Still compiles and pass tests.
- bindings/scripts/CodeGeneratorV8.pm:
- 11:56 AM Changeset in webkit [45631] by
-
- 2 edits in trunk/WebKitTools
2009-07-08 Brent Fulgham <bfulgham@webkit.org>
Build fix for Windows Cairo.
Cairo build was incorrectly #including the PixelDumpSupportCG.h
instead of PixelDumpSupportCairo.h
- DumpRenderTree/win/PixelDumpSupportWin.cpp: Correct #include
- 11:01 AM Changeset in webkit [45630] by
-
- 3 edits in trunk/WebCore
2009-07-08 Brent Fulgham <bfulgham@webkit.org>
Build fix: Add missing #includes for Windows (cURL) build.
The <winsock2.h> and <windows.h> headers were not being
included in Windows cURL builds.
- platform/network/ResourceHandleInternal.h:
- platform/network/curl/ResourceHandleManager.h:
- 10:50 AM Changeset in webkit [45629] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Add special test results for media/controls-after-reload.html
and media/controls-styling.html on Windows.
- platform/win/media/controls-after-reload-expected.txt: Added.
- platform/win/media/controls-styling-expected.txt: Added.
- 10:20 AM Changeset in webkit [45628] by
-
- 2 edits in trunk/LayoutTests
2009-07-08 Pierre d'Herbemont <pdherbemont@apple.com>
Fix the Leopard test result for media/controls-after-reload.txt.
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- 9:42 AM Changeset in webkit [45627] by
-
- 2 edits in trunk/WebKitTools
2009-07-08 David Faure <faure@kde.org>
Reviewed by Ariya Hidayat.
Small documentation improvement for build-webkit --help
- Scripts/build-webkit: mention --debug option
- 9:38 AM Changeset in webkit [45626] by
-
- 2 edits in trunk/WebKit/qt
2009-07-08 Pradeepto Bhattacharya <pradeepto@kde.org>
Reviewed by Ariya Hidayat.
Build fix.
- WebCoreSupport/FrameLoaderClientQt.h: Removed the slot slotCallPolicyFunction().
- 7:44 AM Changeset in webkit [45625] by
-
- 3 edits in trunk/WebKit/qt
2009-07-08 Simon Hausmann <Simon Hausmann>
Reviewed by Tor Arne Vestbø.
Fix DRT instability issues with fast/loader/submit-form-while-parsing-2.html
When the form is submitted we call the policy function in the frame
loader delayed with a queued connection. That queued connection
sometimes interferes with the javascript timeout set in the testcase.
Eliminate the entire delayed policy function mechanism and instead always
call back directly, like in the other ports. In most other places we called
the slot directly anyway.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Remove m_policyFunction. (WebCore::FrameLoaderClientQt::callPolicyFunction): Call the policy function directly instead of emitting the queued signal. (WebCore::FrameLoaderClientQt::cancelPolicyCheck): Call callPolicyFunction directly. (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): Ditto. (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): Ditto.
- WebCoreSupport/FrameLoaderClientQt.h: Remove m_policyFunction as well as the associated signal.
- 7:24 AM BuildingQtOnLinux edited by
- mention --debug argument for build-webkit, rather useful for developers (diff)
- 6:55 AM Changeset in webkit [45624] by
-
- 30 edits in trunk/WebCore
2009-07-08 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Kilzer.
WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884
Fix bunch of style issues in WebCore/rendering.
This patch is created to demonstrate cpplint.py.
No testcase because it's just a style fixes.
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::layout):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeEllipsisBox):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker):
- rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
- rendering/MediaControlElements.h:
- rendering/RenderArena.cpp:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::startDelayUpdateScrollInfo): (WebCore::RenderBlock::finishDelayUpdateScrollInfo): (WebCore::RenderBlock::updateScrollInfoAfterLayout): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine): (WebCore::RenderBlock::floatBottom): (WebCore::RenderBlock::leftBottom): (WebCore::RenderBlock::rightBottom):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidthUsing):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::layoutLegend):
- rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): (WebCore::FlexBoxIterator::reset): (WebCore::FlexBoxIterator::first): (WebCore::FlexBoxIterator::next): (WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderFrameSet.cpp: (WebCore::borderStartEdgeColor):
- rendering/RenderFrameSet.h:
- rendering/RenderImage.cpp:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::panScroll):
- rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::updateMarqueeStyle):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
- rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): (WebCore::RenderObject::localCaretRect):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
- rendering/RenderSlider.h:
- rendering/RenderTable.cpp: (WebCore::RenderTable::outerBorderBottom):
- rendering/RenderTableCol.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::itemIsSeparator):
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::supportsHover):
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::supportsFocusRing):
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::addStackContent):
- rendering/SVGCharacterLayoutInfo.h:
- rendering/TextControlInnerElements.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine):
- 6:33 AM Changeset in webkit [45623] by
-
- 2 edits in trunk/LayoutTests
2009-07-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Remove non-existing tests from the Qt skipped list.
- platform/qt/Skipped:
- 6:33 AM Changeset in webkit [45622] by
-
- 2 edits in trunk/WebKitTools
2009-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Correct git url of the Qt test-fonts.
- DumpRenderTree/qt/main.cpp: (main):
Jul 7, 2009:
- 11:46 PM Changeset in webkit [45621] by
-
- 2190 edits69 copies214 adds411 deletes in branches/nitro-extreme
Merged r45243:45600 into nitro-extreme branch.
- 10:38 PM Changeset in webkit [45620] by
-
- 5 edits in trunk/WebCore
Reduce complexity of lifetime management in DynamicNodeList caches
<https://bugs.webkit.org/show_bug.cgi?id=27068>
Reviewed by Maciej Stachowiak
Switch the Cache object used by DynamicNodeList into a normal
refcounted object rather than having a weird flag controlled
refcounting system, where positive refcount did not automatically
imply the cache object would actually still be live.
- 10:33 PM Changeset in webkit [45619] by
-
- 25 edits in trunk/LayoutTests/platform
Set the svn:mime-type property of recently-added PNG files to image/png.
- 10:26 PM Changeset in webkit [45618] by
-
- 4 edits8 adds in trunk
2009-07-07 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
-webkit-perspective should be a Length
https://bugs.webkit.org/show_bug.cgi?id=27066
-webkit-perspective should not take a magic valueless number, but should
be a normal Length value which responds to zooming. Treat valueless numbers
as pixels for backward compatibility.
Test: transforms/3d/general/perspective-units.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- 7:26 PM Changeset in webkit [45617] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Dave Hyatt.
Missed a call to FocusController::setFocused(true) when handling WM_SETFOCUS in WebView.
https://bugs.webkit.org/show_bug.cgi?id=27057
- WebView.cpp: (WebViewWndProc):
- 6:55 PM Changeset in webkit [45616] by
-
- 2 edits in trunk/WebKitTools
2009-07-07 Brady Eidson <beidson@apple.com>
Tiger build fix, work around missing NSString API.
- DumpRenderTree/mac/DumpRenderTree.mm: (dumpHistoryItem):
- 6:41 PM Changeset in webkit [45615] by
-
- 5 edits in trunk
WebKitTools:
2009-07-07 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27049 - In dumpBackForwardList() mode, DRT should normalize file urls.
Make the dump of a history item agnostic to the layout of filesystem on the testing machine.
- DumpRenderTree/mac/DumpRenderTree.mm: (dumpHistoryItem):
- DumpRenderTree/win/DumpRenderTree.cpp: (dumpHistoryItem):
LayoutTests:
2009-07-07 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27049 - In dumpBackForwardList() mode, DRT should normalize file urls.
- fast/loader/subframe-navigate-during-main-frame-load-expected.txt: Make the results agnostic to the layout of filesystem on the testing machine.
- 6:19 PM Changeset in webkit [45614] by
-
- 5 edits3 adds in trunk
WebCore:
2009-07-07 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
We need to make sure that when we reattach, we also reattach
the children in every MediaControlElement. Else we may end up
having no remaining or elapsed time.
We have to handle that, because we are using a special shadow
tree in the DOM, and that we are ourselves handling
attaching/detaching the renderer.
The strategy here is to try to implement ::attach(), and try
to reuse as much code as we can from the super class, including
children attachement.
Test: media/controls-after-reload.html
- rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::styleForElement): Code factoring. (WebCore::MediaControlElement::rendererIsNeeded): Code factoring. (WebCore::MediaControlElement::attach): Implement attach and call super class so that children are also attached. (WebCore::MediaControlElement::updateStyle): Use attach() (WebCore::MediaControlInputElement::styleForElement): Code factoring. (WebCore::MediaControlInputElement::rendererIsNeeded): Code factoring. (WebCore::MediaControlInputElement::attach): See above. (WebCore::MediaControlInputElement::updateStyle): Use attach()
- rendering/MediaControlElements.h:
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls): Directly run attach() on the m_panel, which is a root node for our shadow tree.
LayoutTests:
2009-07-07 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure nothing changing the src and reloading doesn't
change the look of the controller.
- media/controls-after-reload.html: Added.
- platform/mac-leopard/media/controls-after-reload-expected.txt: Added.
- platform/mac/media/controls-after-reload-expected.txt: Added.
- 5:19 PM Changeset in webkit [45613] by
-
- 5 edits4 adds in trunk
2009-07-07 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Repaint issue after layer drops out of composited mode.
<https://bugs.webkit.org/show_bug.cgi?id=27022>
RenderLayers cache repaint rects in the form of m_repaintRect and m_outlineBox,
and expect these to stay valid from one style change to the next. These rects
are relative to the repaint container, so if a layer stops being composited,
we need to recompute them.
Test: compositing/repaint/layer-repaint-rects.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::computeRepaintRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):
- 4:45 PM Changeset in webkit [45612] by
-
- 8 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt and Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=26963 <rdar://problem/7030998> Reproducible crash at FontCache::getFontData() when a custom font is used in a pseudo-style
Test: fast/css/pseudo-cache-stale.html
- dom/Element.cpp: (WebCore::Element::pseudoStyleCacheIsInvalid): Added. Given the old style and the new style, goes over cached pseudo-styles in the old style and re-resolves the same style types off the new style. If any of the new pseudo-styles is different from the currently cached corresponding style, returns true. Otherwise, returns false. (WebCore::Element::recalcStyle): Validate the pseudo-style cache before deciding to keep the existing style.
- dom/Element.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::uncachedFirstLineStyle): Added this version that returns an uncached first-line style based off the given style. (WebCore::RenderObject::getUncachedPseudoStyle): Added the 'ownStyle' parameter.
- rendering/RenderObject.h:
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getPseudoStyleCache): Added. Returns the cached pseudo-styles in the passed-in vector.
- rendering/style/RenderStyle.h:
LayoutTests:
Reviewed by Dave Hyatt and Darin Adler.
- test for https://bugs.webkit.org/show_bug.cgi?id=26963 <rdar://problem/7030998> Reproducible crash at FontCache::getFontData() when a custom font is used in a pseudo-style
- fast/css/pseudo-cache-stale.html: Added.
- platform/mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
- platform/mac/fast/css/pseudo-cache-stale-expected.png: Added.
- platform/mac/fast/css/pseudo-cache-stale-expected.txt: Added.
- 4:44 PM Changeset in webkit [45611] by
-
- 1 edit1 move1 add in trunk/LayoutTests
2009-07-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Fisher.
revise test expectations for bug 26088
http://bugs.webkit.org/show_bug.cgi?id=26088
generate pixel expectations, move location of generic expected file
for the crash test.
- fast/text/text-large-negative-letter-spacing-with-opacity-expected.txt: Copied from platform/mac/fast/text/text-large-negative-letter-spacing-with-opacity-expected.txt.
- platform/mac/fast/text/text-large-negative-letter-spacing-with-opacity-expected.txt: Removed.
- platform/mac/fast/text/text-letter-spacing-expected.checksum: Added.
- platform/mac/fast/text/text-letter-spacing-expected.png: Added.
- 3:04 PM Changeset in webkit [45610] by
-
- 1 edit1 add in trunk/LayoutTests
2009-07-07 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Add a specific leopard result for controls-styling.html, given that it doesn't
use the new controller look.
- platform/mac-leopard/media/controls-styling-expected.txt: Added.
- 2:52 PM Changeset in webkit [45609] by
-
- 15 edits in trunk
2009-07-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Stop loading constants into the register file.
Instead, use high register values (highest bit bar the sign bit set) to indicate
constants in the instruction stream, and when we encounter such a value load it
directly from the CodeBlock.
Since constants are no longer copied into the register file, this patch renders
the 'unexpected constant' mechanism redundant, and removes it.
2% improvement, thanks to Sam Weinig.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::mark): (JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h: (JSC::CodeBlock::isTemporaryRegisterIndex): (JSC::CodeBlock::constantRegister): (JSC::CodeBlock::isConstantRegisterIndex): (JSC::CodeBlock::getConstant): (JSC::ExecState::r):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::preserveLastVar): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::addConstantValue): (JSC::BytecodeGenerator::emitEqualityOp): (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitNewError):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNode):
- interpreter/CallFrame.h: (JSC::ExecState::noCaller): (JSC::ExecState::hasHostCallFrameFlag): (JSC::ExecState::addHostCallFrameFlag): (JSC::ExecState::removeHostCallFrameFlag):
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::throwException): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
- parser/Nodes.cpp: (JSC::DeleteResolveNode::emitBytecode): (JSC::DeleteValueNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode):
- runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
- wtf/Platform.h:
LayoutTests:
2009-07-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
fast/js/global-recursion-on-full-stack.html is a little finicky.
The test recurses down the JS stack to find the bottom (catching this with an exception),
then tries to call a host function (document.write), switch writes new '<script>' code,
and expects this code to be run, then expects this code to try to call 'f();' again,
which it expects to fail, and it expects to catch that exception. However it is possible
that one of the earlier stages (the call to document.write, entering the interpreter to
run the new global code) will fail, depending on exactly how much stack space was free at
the point the last call to f() failed.
Tweak the test to make it work.
- fast/js/global-recursion-on-full-stack.html:
- 2:36 PM Changeset in webkit [45608] by
-
- 5 edits8 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- fix https://bugs.webkit.org/show_bug.cgi?id=27042 <rdar://problem/7010981> Incomplete painting of newly created floats
Tests: fast/repaint/float-in-new-block-with-layout-delta.html
fast/repaint/float-new-in-block.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): If the child has never been laid out before, paint its overhanging floats in addition to itself.
- rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect): Added and initialized a boolean everHadLayout member.
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Paint floats that have never been laid out before and did not move from (0, 0).
LayoutTests:
Reviewed by Simon Fraser.
- tests for https://bugs.webkit.org/show_bug.cgi?id=27042 <rdar://problem/7010981> Incomplete painting of newly created floats
- fast/repaint/float-in-new-block-with-layout-delta.html: Added.
- fast/repaint/float-new-in-block.html: Added.
- platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum: Added.
- platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
- platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Added.
- platform/mac/fast/repaint/float-new-in-block-expected.checksum: Added.
- platform/mac/fast/repaint/float-new-in-block-expected.png: Added.
- platform/mac/fast/repaint/float-new-in-block-expected.txt: Added.
- 2:27 PM Changeset in webkit [45607] by
-
- 5 edits in trunk/WebKit/mac
2009-07-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- Fix <rdar://problem/6544693>.
For Flash, don't cache which methods or fields in an object are missing, since they can
be added at any time.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
- Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::shouldCacheMissingPropertiesAndMethods):
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodsNamed): (WebKit::ProxyInstance::fieldNamed):
- 2:19 PM Changeset in webkit [45606] by
-
- 6 edits3 adds in trunk
WebCore:
2009-07-07 Brady Eidson <beidson@apple.com>
Contributions from both Darin Adler and Brady Eidson.
Reviewed by Darin Adler.
<rdar://problem/7024039> REGRESSION (r42158): Back-forward navigation does not work correctly on nytimes.com
In r42158 we lost some exclusions to making back/forward items for subframe navigations when a main frame
navigation was still in progress.
This patch makes things even better than it used to be by:
- Locking back/forward history at the time the navigation is scheduled, not after the load has committed.
- Locking back/forward history if *any* ancestor frame is still loading instead of just the main frame.
Test: fast/loader/subframe-navigate-during-main-frame-load.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Move out the history locking logic into a standalone function so it can be used from multiple sites. (WebCore::mustLockBackForwardList): Returns true if any ancestor frame is still loading. (WebCore::FrameLoader::scheduleLocationChange): Respect mustLockBackForwardList() in addition to the passed in lockBackForwardList flag. (WebCore::FrameLoader::scheduleFormSubmission): Ditto.
LayoutTests:
2009-07-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7024039> REGRESSION (r42158): Back-forward navigation does not work correctly on nytimes.com
- fast/loader/resources/subframe-navigate-during-main-frame-load2.html: Added.
- fast/loader/subframe-navigate-during-main-frame-load-expected.txt: Added.
- fast/loader/subframe-navigate-during-main-frame-load.html: Added.
- http/tests/navigation/javascriptlink-subframeload-expected.txt: Updated results to reflect the progression!
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt: Ditto!
- http/tests/misc/redirect-to-about-blank.html: Add missing semi-colons.
- 2:15 PM Changeset in webkit [45605] by
-
- 1 edit1 add in trunk/WebCore
2009-07-07 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Upstream DOMObjectsInclude.h from src.chromium.org.
- bindings/v8/DOMObjectsInclude.h: Added.
- 1:16 PM Changeset in webkit [45604] by
-
- 1 edit in trunk/WebKitLibraries/win/tools/scripts/PRODUCTVERSION
Versioning.k
- 1:02 PM Changeset in webkit [45603] by
-
- 17 edits1 copy in trunk/WebCore
2009-07-07 Nate Chapin <Nate Chapin>
Reviewed by David Levin.
- 12:05 PM Changeset in webkit [45602] by
-
- 2 edits in trunk/WebCore
Bug 26995 - AX: Some webpages do not send AXLoadComplete
https://bugs.webkit.org/show_bug.cgi?id=26995
- 11:02 AM Changeset in webkit [45601] by
-
- 4 edits4 adds in trunk
WebCore:
2009-07-06 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure that the CSS properties letter-spacing, word-spacing,
line-height, text-transform, text-indent, text-shadow,
text-decoration and color do not affect the media element controls,
that display text.
Controls that display text are only present in when the theme
MediaControllerThemeQT is being used.
Test: media/controls-styling.html
- css/mediaControlsQT.css:
- rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::updateStyle): Special case for text-decoration. text-decoration can't be overriden from CSS, because text-decoration is additive for historical reasons.
LayoutTests:
2009-07-06 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure overriding properties won't affect the media controller.
- media/controls-styling.html: Added.
- 10:54 AM Changeset in webkit [45600] by
-
- 2 edits in trunk/JavaScriptCore
Bug 27025: Crashes and regression test failures related to regexps in 64-bit
Fix <https://bugs.webkit.org/show_bug.cgi?id=27025> / <rdar://problem/7033448>.
Reviewed by Darin Adler.
For x86_64 RegexGenerator uses rbx, a callee-save register, as a scratch register but
neglects to save and restore it. The change in handling of the output vector in r45545
altered code generation so that the RegExp::match was now storing important data in rbx,
which caused crashes and bogus results when it was clobbered.
- yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter): Save rbx.
(JSC::Yarr::RegexGenerator::generateReturn): Restore rbx.
- 10:30 AM Changeset in webkit [45599] by
-
- 2 edits in trunk/WebCore
2009-07-07 Albert Wong <ajwong@chromium.org>
Not reviewed, Chromium build fix.
Add in missing header + fix syntax issue that crept into last patch.
https://bugs.webkit.org/show_bug.cgi?id=27027
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
- 10:15 AM Changeset in webkit [45598] by
-
- 9 edits in trunk/WebCore
2009-07-07 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Make use of geometry information to decide which layers become composited.
<rdar://problem/7011947>
<https://bugs.webkit.org/show_bug.cgi?id=27021>
In addition to looking at painting order, also, optionally, take layer
overlap into account when deciding which RenderLayers need to be composited.
No testcase because DRT doesn't dump which layers are composited.
- page/FrameView.h:
- page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): Removed the unused CompositingUpdate parameter, and just do an early return when there is no view.
- rendering/RenderLayer.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged): (WebCore::RenderLayer::dirtyZOrderLists): (WebCore::RenderLayer::dirtyNormalFlowList): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::mustOverlapCompositedLayers): (WebCore::RenderLayer::setMustOverlapCompositedLayers): Change "overlay" to "overlap" for consistency with the use of "overlap" elsewhere.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout): compositingLayersNeedUpdate() renamed to compositingLayersNeedRebuild().
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
Tell the compositor that we started an accelerated animation or transition.
- rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::compositingLayersNeedRebuild): Renamed, since it's explicitly about changes in hierarchy now.
(WebCore::RenderLayerCompositor::setCompositingConsultsOverlap):
(WebCore::RenderLayerCompositor::compositingConsultsOverlap):
New getter and setter for whether compositing should take overlap into account.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): Add m_compositingConsultsOverlap, re-order some member variables.
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingEnabledFlag):
Whitespace cleanup and method rename.
(WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild):
Method and variable renaming.
(WebCore::RenderLayerCompositor::updateCompositingLayers):
Now we have to run through the layer hierarchy every time if looking
at overlap, because changes in layout can now alter compositing behavior.
We minimize work by tracking whether we actually need to change the layer
hierarchy via needLayerRebuild.
(WebCore::RenderLayerCompositor::updateBacking):
3D transforms turn off overlap mode.
(WebCore::RenderLayerCompositor::layerWasAdded):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
Method rename.
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::overlapsCompositedLayers):
Utility methods to add a layer to the overlapMap (computing the absolute
bounding box only if we haven't already done so), and testing the map
entries.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
If a layer would composite only because it comes after other compositing
layers in the painting order, then consult the overlap map to determine whether
it overlaps, and thus actually needs to composite.
Add layers to the map when they must be composited.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
Only do re-parenting work if the updateHierarchy flag is set.
(WebCore::RenderLayerCompositor::didStartAcceleratedAnimation):
When we start an accelerated transition or animation, we stop looking at
overlap because we can no longer guarantee correct front-to-back ordering while the
accelerated animation is running.
(WebCore::RenderLayerCompositor::needsToBeComposited):
Method renames.
- rendering/RenderView.cpp: (WebCore::RenderView::setMaximalOutlineSize): Add comment indicating that this could be optimized.
- 9:52 AM Changeset in webkit [45597] by
-
- 4 edits35 adds in trunk/BugsSite
Updated BugsSite with local changes on server
The new files were created by checksetup.pl during the upgrade
to Bugzilla 3.2.3. The rest are self-explanatory.
- data: Added "bugzilla-update.xml" to svn:ignore.
- data/attachments: Added "groups.*" to svn:ignore.
- data/params: Updated for a few changed parameters.
- lib/.htaccess: Added.
- skins/contrib/Dusk/IE-fixes.css: Added.
- skins/contrib/Dusk/admin.css: Added.
- skins/contrib/Dusk/create_attachment.css: Added.
- skins/contrib/Dusk/dependency-tree.css: Added.
- skins/contrib/Dusk/duplicates.css: Added.
- skins/contrib/Dusk/editusers.css: Added.
- skins/contrib/Dusk/help.css: Added.
- skins/contrib/Dusk/index.css: Added.
- skins/contrib/Dusk/panel.css: Added.
- skins/contrib/Dusk/params.css: Added.
- skins/contrib/Dusk/release-notes.css: Added.
- skins/contrib/Dusk/show_bug.css: Added.
- skins/contrib/Dusk/show_multiple.css: Added.
- skins/contrib/Dusk/summarize-time.css: Added.
- skins/contrib/Dusk/voting.css: Added.
- skins/contrib/Dusk/yui: Added.
- skins/contrib/Dusk/yui/calendar.css: Added.
- skins/custom/IE-fixes.css: Added.
- skins/custom/admin.css: Added.
- skins/custom/buglist.css: Added.
- skins/custom/create_attachment.css: Added.
- skins/custom/dependency-tree.css: Added.
- skins/custom/duplicates.css: Added.
- skins/custom/editusers.css: Added.
- skins/custom/help.css: Added.
- skins/custom/panel.css: Added.
- skins/custom/params.css: Added.
- skins/custom/release-notes.css: Added.
- skins/custom/show_bug.css: Added.
- skins/custom/show_multiple.css: Added.
- skins/custom/summarize-time.css: Added.
- skins/custom/voting.css: Added.
- skins/custom/yui: Added.
- skins/custom/yui/calendar.css: Added.
- 9:16 AM Changeset in webkit [45596] by
-
- 3 edits in trunk/WebCore
2009-07-07 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Fisher.
Speed up creation of V8 wrappers for DOM nodes.
This patch doesn't require new tests as it a set of refactorings
to speed up wrapper creation.
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- 8:51 AM Changeset in webkit [45595] by
-
- 5 edits in trunk
2009-07-07 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] textarea height property works only if other property are defined
https://bugs.webkit.org/show_bug.cgi?id=18984
Let WebCore handle textarea's metrics instead of readjusting it RenderthemeGtk.
Test: fast/forms/textarea-metrics.html
- platform/gtk/RenderThemeGtk.cpp:
- platform/gtk/RenderThemeGtk.h:
- LayoutTests/platform/gtk/Skipped:
- 7:29 AM Changeset in webkit [45594] by
-
- 6 edits3 adds in trunk
2009-07-07 Ben Murdoch <benm@google.com>
Reviewed by Antti Koivisto.
HTML5 Database becomes locked if a transaction is in progress when the page is refreshed.
https://bugs.webkit.org/show_bug.cgi?id=25711
Tests fix for https://bugs.webkit.org/show_bug.cgi?id=25711, where
web storage databases could become locked until the browser is
shut down if the page is refreshed whilst a transaction is in
progress.
- storage/database-lock-after-reload-expected.txt: Added.
- storage/database-lock-after-reload.html: Added.
- storage/resources/database-lock-after-reload-2.html: Added.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25711 where web
storage databases could become locked until the browser is shut
down if the page is refreshed whilst a transaction is in progress.
Test: storage/database-lock-after-reload.html
- storage/Database.cpp: (WebCore::Database::Database): (WebCore::Database::close): add code to inform the database thread we've closed the database. (WebCore::Database::performOpenAndVerify): add code to inform the database thread we've opened a database.
- storage/Database.h: (WebCore::Database::opened): return true iff the underlying sqlite database has been opened but not closed.
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread): Before the database thread terminates, close any databases that ran transactions in this thread. (WebCore::DatabaseThread::recordDatabaseOpen): Records a database that executed a transaction in this thread. (WebCore::DatabaseThread::recordDatabaseClosed): Removes a database from the set of open databases.
- storage/DatabaseThread.h: (WebCore::DatabaseThread::getThreadID): return the thread id for the database thread.
- 7:04 AM Changeset in webkit [45593] by
-
- 6 edits in trunk
WebKit/qt:
2009-07-07 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Add Qt DRT hook for clearing the frame name.
- Api/qwebframe.cpp: (qt_drt_clearFrameName):
WebKitTools:
2009-07-07 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Clear the main frame's name between loading pages, like in r36652. This
reduces the side-effects between test cases.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
LayoutTests:
2009-07-07 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Removed subframe-self-close.html from the Qt skip list.
- platform/qt/Skipped:
- 5:52 AM Changeset in webkit [45592] by
-
- 2 edits1 add in trunk/WebCore
2009-07-07 Jiahua Huang <jhuangjiahua@gmail.com>
Reviewed by Jan Alonzo.
[Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791
Fix problem with UTF-16 clipboard pasted.
- manual-tests/gtk/paste-richtext-from-firefox.html: Added.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::documentFragment):
- 5:35 AM Changeset in webkit [45591] by
-
- 2 edits in trunk/WebCore
2009-07-07 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Change 'Continue debug' shortcut from F5 to F8 for consistency with Firebug.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
- 3:48 AM Changeset in webkit [45590] by
-
- 2 edits in trunk/LayoutTests
2009-07-07 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Added all current failing Qt DRT tests to the skip list, for a fresh start.
- platform/qt/Skipped:
- 3:27 AM Changeset in webkit [45589] by
-
- 2 edits in trunk/WebKitTools
2009-07-06 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Fix various layout tests with Qt's DRT.
Remember to set the focus on the web page before
loading.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
- 3:25 AM Changeset in webkit [45588] by
-
- 3 edits in trunk/WebKitTools
2009-07-07 Simon Hausmann <Simon Hausmann>
Reviewed by Tor Arne Vestbø and Holger Freyther.
Fix timeout timer handling in Qt DRT.
Use QBasicTimer instead of startTimer/killTimer, to fix the
problem that starting the timeout timer did not stop a
previously started timer, causing multiple emissions of timeout.
The timerEvent() implementation now also checks the timer id, to
protect against double timeouts.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): (LayoutTestController::timerEvent):
- DumpRenderTree/qt/jsobjects.h:
Jul 6, 2009:
- 11:42 PM Changeset in webkit [45587] by
-
- 5 edits in branches/nitro-extreme
2009-07-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig (?).
Fixed an assertion seen during the stress test.
Don't assume that, if op1 is constant, op2 is not, and vice versa. Sadly,
not all constants get folded.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq):
LayoutTests:
2009-07-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig (?).
Test for an assertion seen during the stress test.
- fast/js/arithmetic-expected.txt:
- fast/js/resources/arithmetic.js:
- 10:34 PM Changeset in webkit [45586] by
-
- 16 edits in branches/nitro-extreme
2009-07-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Stop loading constants into the register file.
Instead, use high register values (highest bit bar the sign bit set) to indicate
constants in the instruction stream, and when we encounter such a value load it
directly from the CodeBlock.
Since constants are no longer copied into the register file, this patch renders
the 'unexpected constant' mechanism redundant, and removes it.
2% improvement, thanks to Sam Weinig.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::mark): (JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h: (JSC::CodeBlock::isTemporaryRegisterIndex): (JSC::CodeBlock::constantRegister): (JSC::CodeBlock::isConstantRegisterIndex): (JSC::CodeBlock::getConstant): (JSC::ExecState::r):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::preserveLastVar): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::addConstantValue): (JSC::BytecodeGenerator::emitEqualityOp): (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitNewError):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNode):
- interpreter/CallFrame.h: (JSC::ExecState::noCaller): (JSC::ExecState::hasHostCallFrameFlag): (JSC::ExecState::addHostCallFrameFlag): (JSC::ExecState::removeHostCallFrameFlag):
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::throwException): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
- parser/Nodes.cpp: (JSC::DeleteResolveNode::emitBytecode): (JSC::DeleteValueNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode):
- runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
- wtf/Platform.h:
LayoutTests:
2009-07-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
fast/js/global-recursion-on-full-stack.html is a little finicky.
The test recurses down the JS stack to find the bottom (catching this with an exception),
then tries to call a host function (document.write), switch writes new '<script>' code,
and expects this code to be run, then expects this code to try to call 'f();' again,
which it expects to fail, and it expects to catch that exception. However it is possible
that one of the earlier stages (the call to document.write, entering the interpreter to
run the new global code) will fail, depending on exactly how much stack space was free at
the point the last call to f() failed.
Tweak the test to make it work.
- fast/js/global-recursion-on-full-stack.html:
- 8:40 PM Changeset in webkit [45585] by
-
- 3 edits in trunk/WebCore
2009-07-06 Albert J. Wong <ajwong@chromium.org>
Reviewed by Maciej Stachowiak.
Update RenderThemeChromiumMac for wkDrawMediaUIPart and wkDrawMediaSlider API
change.
Fix compile RenderThemeChromiumMac.mm due to API changes from r45572
https://bugs.webkit.org/show_bug.cgi?id=27018
This is mainly an API change update to fix the chromium compile. It
also has a small fix of a typo in RenderThemeMac.mm.
Compilation against the head of chromium trunk passed. Since this is
a compile fix, that should be sufficient.
- rendering/RenderThemeChromiumMac.mm: (WebCore::): (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
- rendering/RenderThemeMac.mm: (WebCore::):
- 7:49 PM Changeset in webkit [45584] by
-
- 2 edits in trunk/WebKit/mac
Bug 27006: Build fix when MAC_JAVA_BRIDGE is disabled
Reviewed by Darin Adler.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createJavaAppletWidget): Wrap contents of the method in #if ENABLE(MAC_JAVA_BRIDGE)/#endif and return 0 when this feature is disabled.
- 7:44 PM Changeset in webkit [45583] by
-
- 3 edits in trunk/WebKit/mac
Bug 27005: Build fixes when NETSCAPE_PLUGIN_API is disabled
Reviewed by Geoff Garen.
- Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): Wrap call to ScriptController::cleanupScriptObjectsForPlugin() in #if ENABLE(NETSCAPE_PLUGIN_API)/#endif macro. (-[WebPluginController destroyAllPlugins]): Ditto.
- Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): Wrap WebBaseNetscapePluginView class checks in #if ENABLE(NETSCAPE_PLUGIN_API)/#endif macro. (-[WebPluginDatabase destroyAllPluginInstanceViews]): Ditto.
- 7:39 PM Changeset in webkit [45582] by
-
- 4 edits in trunk/WebKit/mac
BUILD FIX: Use ENABLE(NETSCAPE_PLUGIN_API) instead of USE(PLUGIN_HOST_PROCESS)
In r45579, #if/#endif macros for USE(PLUGIN_HOST_PROCESS) were
used, but ENABLE(NETSCAPE_PLUGIN_API) should have been used
instead.
- Plugins/WebNetscapeContainerCheckContextInfo.h:
- Plugins/WebNetscapeContainerCheckContextInfo.mm:
- Plugins/WebNetscapeContainerCheckPrivate.mm:
- 7:18 PM Changeset in webkit [45581] by
-
- 2 edits in trunk/WebKit/mac
Bug 27004: Build fix for ENABLE(PLUGIN_PROXY_FOR_VIDEO) after r42618
Reviewed by Geoff Garen.
- Plugins/WebPluginController.mm: (mediaProxyClient): Use core() method to convert from DOMElement to WebCore::Element.
- 7:18 PM Changeset in webkit [45580] by
-
- 3 edits in trunk/WebKitTools
2009-07-06 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
bugzilla-tool fails to close bugs with bugzilla 3.0
https://bugs.webkit.org/show_bug.cgi?id=27008
Update bugzilla.py to match changes in the bug page "changeform"
Update scm.py to add bug_ids to attachments to make error reporting nicer.
- Scripts/modules/bugzilla.py:
- Scripts/modules/scm.py:
- 7:14 PM Changeset in webkit [45579] by
-
- 4 edits in trunk/WebKit/mac
Bug 27003: Build fix when USE(PLUGIN_HOST_PROCESS) is disabled
Reviewed by Geoff Garen.
- Plugins/WebNetscapeContainerCheckContextInfo.h: Added #if USE(PLUGIN_HOST_PROCESS)/#endif guards.
- Plugins/WebNetscapeContainerCheckContextInfo.mm: Ditto.
- Plugins/WebNetscapeContainerCheckPrivate.mm: Ditto.
- 6:01 PM Changeset in webkit [45578] by
-
- 2 edits in trunk/WebCore
Bug 27002: Build fix when DASHBOARD_SUPPORT is disabled with -Wunused-parameter
Reviewed by Geoff Garen.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::prepareGradientForDashboard): Mark gradient as an unused parameter when DASHBOARD_SUPPORT is disabled.
- 5:59 PM Changeset in webkit [45577] by
-
- 2 edits in trunk/WebCore
Bug 27001: Fix improper use of PassRefPtr<Node> to RefPtr<Node>
Reviewed by Geoff Garen.
PassRefPtr<> should only be used for arguments to functions that
take ownership of the object, or as return values from functions
that relinquish ownership of the object.
- editing/Editor.cpp: (WebCore::Editor::increaseSelectionListLevelOrdered): Changed stack-allocated PassRefPtr<Node> to RefPtr<Node> and call release() on returned object. (WebCore::Editor::increaseSelectionListLevelUnordered): Ditto.
- 5:44 PM Changeset in webkit [45576] by
-
- 4 edits in trunk
2009-07-06 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7035474> Make new media controller UI default on SnowLeopard
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
New media controller UI is enabled by default on SnowLeopard.
2009-07-06 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7035474> Make new media controller UI default on SnowLeopard
Disable media tests that depend on controller size/position on SnowLeopard until
<rdar://problem/6502936> Update run-webkit-tests to deal with new media controller look
has been fixed
- platform/mac-snowleopard/Skipped:
- 4:54 PM Changeset in webkit [45575] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-07-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Include op_convert_this in result caching.
No change on SunSpider or v8.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_convert_this):
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::): Made the op_convert_this JIT stub return an EncodedJSValue, so to maintain the result caching contract that { tag, payload } can be found in { regT1, regT0 }.
- 4:18 PM Changeset in webkit [45574] by
-
- 17 edits1 delete in trunk/WebCore
2009-07-06 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Roll out r45559 to fix Chromium canary.
- 3:59 PM Changeset in webkit [45573] by
-
- 10 edits in branches/nitro-extreme/JavaScriptCore
2009-07-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented result chaining.
1% faster on SunSpider. 4%-5% faster on v8.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::move):
- assembler/X86Assembler.h: (JSC::X86Assembler::movl_rr): Added an optimization to eliminate no-op mov instructions, to simplify chaining.
- jit/JIT.cpp: (JSC::JIT::JIT):
- jit/JIT.h: Added data members and helper functions for recording chained results. We record both a mapping from virtual to machine register and the opcode for which the mapping is valid, to help ensure that the mapping isn't used after the mapped register has been stomped by other instructions.
- jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCallVarargsSlowCase): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): Chain function call results.
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadTag): (JSC::JIT::emitLoadPayload): (JSC::JIT::emitLoad): (JSC::JIT::emitLoad2): (JSC::JIT::isLabeled): (JSC::JIT::map): (JSC::JIT::unmap): (JSC::JIT::isMapped): (JSC::JIT::getMappedPayload): (JSC::JIT::getMappedTag): Use helper functions when loading virtual registers into machine registers, in case the loads can be eliminated by chaining.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_mov): (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): Chain results from these opcodes.
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call): Load the profiler into regT2 to
avoid stomping a chained result.
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_get_by_id): Chain results from these opcodes.
- jit/JITStubCall.h: (JSC::JITStubCall::addArgument): Always use { regT1, regT0 }, to facilitate chaining.
(JSC::JITStubCall::call): Unmap all mapped registers, since our callee
stub might stomp them.
- 3:56 PM Changeset in webkit [45572] by
-
- 13 edits in trunk
2009-07-06 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/7008093> Media controller can’t be used to scrub when movie is
narrow — track is too narrow
Do not show media controller time display elements when the a movie is too narrow.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
The 'state' parameter to wkDrawMediaUIPart is now an unsigned bitfield.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
Give current time and time remaining controls a common base class.
(WebCore::MediaControlTimeDisplayElement::setVisible):
New method, hide and show the element.
- rendering/MediaControlElements.h:
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia):
Initialize m_previousVisible.
(WebCore::RenderMedia::layout):
Show/hide the time display elements as the movie width changes.
(WebCore::RenderMedia::createCurrentTimeDisplay):
(WebCore::RenderMedia::createTimeRemainingDisplay):
Base class is now MediaControlTimeDisplayElement, not MediaControlElement.
(WebCore::RenderMedia::shouldShowTimeDisplayControls):
New, decide if time display elements should be visible or not.
- rendering/RenderMedia.h:
- rendering/RenderThemeMac.mm: (WebCore::): (WebCore::RenderThemeMac::paintMediaFullscreenButton): (WebCore::RenderThemeMac::paintMediaMuteButton): (WebCore::RenderThemeMac::paintMediaPlayButton): (WebCore::RenderThemeMac::paintMediaSeekBackButton): (WebCore::RenderThemeMac::paintMediaSeekForwardButton): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaSliderThumb): (WebCore::RenderThemeMac::paintMediaRewindButton): (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton): (WebCore::RenderThemeMac::paintMediaControlsBackground): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):
The 'state' parameter to wkDrawMediaUIPart is now an unsigned bitfield.
2009-07-06 Eric Carlson <eric.carlson@apple.com>
Update WebKitSystemInterface for <rdar://problem/7008093>.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 3:46 PM Changeset in webkit [45571] by
-
- 3 edits in trunk/WebCore
Bug 27000: Minor clean up to runtime_root.{cpp|h}
Reviewed by Geoff Garen.
- bridge/runtime_root.cpp: Added blank line between license and the first #include statement.
- bridge/runtime_root.h: Added comment to #endif.
- 3:42 PM Changeset in webkit [45570] by
-
- 9 edits in trunk/WebCore
2009-07-06 Roland Steiner <rolandsteiner@google.com>
Reviewed by Maciej Stachowiak.
generalize the special height treatment for SVG (to be re-used for ruby):
renamed InlineBox::m_isSVG to m_hasVirtualHeight
renamed InlineBox::isSVG() to hasVirtualHeight()
renamed InlineBox::setIsSVG() to setHasVirtualHeight()
- rendering/InlineBox.cpp: (WebCore::InlineBox::height):
- rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isText): (WebCore::InlineBox::setIsText): (WebCore::InlineBox::isSVGRootInlineBox): (WebCore::InlineBox::hasVirtualHeight): (WebCore::InlineBox::setHasVirtualHeight): (WebCore::InlineBox::virtualHeight):
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createFlowBox):
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::createTextBox):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootBox):
- rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::virtualHeight):
- rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::virtualHeight):
- rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::virtualHeight):
- 3:11 PM Changeset in webkit [45569] by
-
- 14 edits in trunk/WebCore
2009-07-06 Alice Liu <alice.liu@apple.com>
Reviewed by Darin Adler.
REGRESSION(r45285): focus rings are black on windows safari
https://bugs.webkit.org/show_bug.cgi?id=26821
<rdar://problem/7018252>
Add a mechanism for setting a custom focus ring color, and relocate the
determination of focus ring color to base class RenderTheme.
No new tests. Already-existing tests run in pixel mode would have caught this regression
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Move the responsibility of determining focus color to base class RenderTheme.
- rendering/RenderTheme.cpp: (WebCore::customFocusRingColor): Added static local. (WebCore::RenderTheme::setCustomFocusRingColor): Added (WebCore::RenderTheme::focusRingColor): Use custom color over platform color.
- rendering/RenderTheme.h: (WebCore::RenderTheme::platformFocusRingColor): default implementation, black color
- rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Circumstances that lead to returning the RenderThemeWin are the same under which we want to use the focus ring color from SafariTheme. (WebCore::RenderThemeSafari::platformFocusRingColor): Renamed from focusRingColor
- rendering/RenderThemeSafari.h:
Renaming focusRingColor to platformFocusRingColor in these files:
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::platformFocusRingColor):
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::platformFocusRingColor):
- rendering/RenderThemeChromiumSkia.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformFocusRingColor):
Cleanup leftover from removal of WebCore::Color in r45285 in these files:
- WebCore.order:
- platform/graphics/Color.h:
- 2:53 PM Changeset in webkit [45568] by
-
- 5 edits4 adds in trunk
2009-07-06 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Hyatt.
Bug 15135: REGRESSION (r19843-r19850): Changing a flexbox's
contents makes its container scroll to the top
https://bugs.webkit.org/show_bug.cgi?id=15135
Delay updateing scroll bar of descendants of flexbox until their
positions are determined. In this way we can prevent descendants
of flexible boxes from changing positions of their scrollbars
using tentative positions.
- fast/flexbox/repaint-scrollbar-expected.txt: Added.
- fast/flexbox/repaint-scrollbar.html: Added.
- fast/flexbox/resources/repaint-scrollbar.js: Added.
2009-07-06 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Hyatt.
Bug 15135: REGRESSION (r19843-r19850): Changing a flexbox's
contents makes its container scroll to the top
https://bugs.webkit.org/show_bug.cgi?id=15135
Delay updateing scroll bar of descendants of flexbox until their
positions are determined. In this way we can prevent descendants
of flexible boxes from changing positions of their scrollbars
using tentative positions.
Test: fast/flexbox/repaint-scrollbar.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::startDelayUpdateScrollInfo): (WebCore::RenderBlock::finishDelayUpdateScrollInfo): (WebCore::RenderBlock::updateScrollInfoAfterLayout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
- rendering/RenderBlock.h:
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
- 2:33 PM Changeset in webkit [45567] by
-
- 3 edits2 adds in trunk
2009-07-06 Hironori Bono <hbono@chromium.org>
Reviewed by Maciej Stachowiak.
Make unconfirmed IME text affect textarea's value.
This matches input and contentEditable elements as well
IE and Firefox.
This fixes https://bugs.webkit.org/show_bug.cgi?id=25061.
Input elements would go down this code path because it
would always get a null compositionNode from frame->editor().
Special casing compositionNodes is wrong because we explicitly
want unconfirmed IME input in the textarea's value (assuming we
want to match IE and Firefox here).
This change is originally created by Ojan Vafai <ojan@chromium.org> and
I just changed its manual tests with an automated test on his behalf.
- platform/mac/editing/input/text-control-ime-input-expected.txt: Added.
- platform/mac/editing/input/text-control-ime-input.html: Added.
2009-07-06 Hironori Bono <hbono@chromium.org>
Reviewed by Maciej Stachowiak.
Make unconfirmed IME text affect textarea's value.
This matches input and contentEditable elements as well
IE and Firefox.
This fixes https://bugs.webkit.org/show_bug.cgi?id=25061.
Input elements would go down this code path because it
would always get a null compositionNode from frame->editor().
Special casing compositionNodes is wrong because we explicitly
want unconfirmed IME input in the textarea's value (assuming we
want to match IE and Firefox here).
This change is originally created by Ojan Vafai <ojan@chromium.org> and
I just changed its manual tests with an automated test on his behalf.
Test: platform/mac/editing/input/text-control-ime-input.html
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::text): (WebCore::RenderTextControl::textWithHardLineBreaks):
- 2:13 PM Changeset in webkit [45566] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler and Mark Rowe.
Decommitted spans are added to the list of normal spans rather than
the returned spans in TCMalloc_PageHeap::Delete().
https://bugs.webkit.org/show_bug.cgi?id=26998
In TCMalloc_PageHeap::Delete(), the deleted span can be decommitted in
the process of merging with neighboring spans that are also decommitted.
The merged span needs to be placed in the list of returned spans (spans
whose memory has been returned to the system). Right now it's always added
to the list of the normal spans which can theoretically cause thrashing.
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::Delete):
- 1:59 PM Changeset in webkit [45565] by
-
- 9 edits in trunk
WebCore:
2009-07-06 Anders Carlsson <andersca@apple.com>
Reviewed by Adele Peterson.
Add the ability for wheel events to latch to a node.
- WebCore.base.exp:
- page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::clear): (WebCore::EventHandler::handleWheelEvent):
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::wheelEvent):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
WebKit/mac:
2009-07-06 Anders Carlsson <andersca@apple.com>
Reviewed by Adele Peterson.
Initialize wkIsLatchingWheelEvent.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- 1:55 PM Changeset in webkit [45564] by
-
- 2 edits in trunk/WebCore
2009-07-06 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Fix a bunch of layout test crahses in Chromium caused by a bad usage of DEFINE_STATIC_LOCAL.
- bindings/v8/V8Binding.cpp: (WebCore::v8ValueToWebCoreString): Use a regular static declaration instead of DEFINE_STATIC_LOCAL.
- 1:48 PM Changeset in webkit [45563] by
-
- 5 edits in trunk/WebKitLibraries
2009-07-06 Anders Carlsson <andersca@apple.com>
Update WebKitSystemInterface.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 1:47 PM Changeset in webkit [45562] by
-
- 3 edits in trunk/WebCore
2009-07-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: suggest global properties based on async evaluation.
Before this change, empty string was evaluated to the global object
(or scope chain object) synchronously. This is now fixed and global
object is evaluated using the same control flow.
- inspector/front-end/Console.js: (WebInspector.Console.prototype.completions): (WebInspector.Console.prototype._evalInInspectedWindow):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._variablesInScope):
- 1:37 PM Changeset in webkit [45561] by
-
- 5 edits2 adds in trunk
WebCore:
2009-07-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
Fix crash when indenting in an empty table cell.
https://bugs.webkit.org/show_bug.cgi?id=26872
The crash is that we would call splitTreeToNode where the node
and the nodeToSplitTo were the same node.
Test: editing/execCommand/indent-empty-table-cell.html
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode): Added an assert in that node and nodeToSplitTo are different nodes to make this assumption explicit.
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::isAtUnsplittableElement): (WebCore::IndentOutdentCommand::indentRegion):
- editing/IndentOutdentCommand.h:
LayoutTests:
2009-07-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
Fix crash when indenting in an empty table cell.
https://bugs.webkit.org/show_bug.cgi?id=26872
The crash is that we would call splitTreeToNode where the node
and the nodeToSplitTo were the same node.
- editing/execCommand/indent-empty-table-cell-expected.txt: Added.
- editing/execCommand/indent-empty-table-cell.html: Added.
- 11:10 AM Changeset in webkit [45560] by
-
- 2 edits in trunk/WebKitSite/specs/CSSVisualEffects/css3-2d-transforms
added pseudocode form decomposition method
- 10:38 AM Changeset in webkit [45559] by
-
- 17 edits1 add in trunk/WebCore
2009-07-06 Nate Chapin <Nate Chapin>
Reviewed by David Levin.
Upstream V8Binding and update some function names.
- 7:37 AM Changeset in webkit [45558] by
-
- 5 edits in trunk
WebCore
2009-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Jan Alonzo.
Use soup's content sniffing
https://bugs.webkit.org/show_bug.cgi?id=26982
Drop our hackish content sniffing code, and use the new libsoup
feature to do that job for us.
Testing this is in a cross-platform way is not obvious or possible
while we are using platform-specific code for sniffing.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::contentSniffedCallback): (WebCore::gotChunkCallback): (WebCore::ResourceHandle::startHttp):
WebKit/gtk
2009-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Jan Alonzo.
Use soup's content sniffing
https://bugs.webkit.org/show_bug.cgi?id=26982
Add the new Content Sniffing feature provided by libsoup.
- webkit/webkitprivate.cpp: (webkit_init):
Jul 5, 2009:
- 10:22 PM Changeset in webkit [45557] by
-
- 2 edits in trunk/WebCore
2009-07-05 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Darin Adler.
REGRESSION (r40499): fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342
Re-added code removed by commit r40499.
Without this, both Qt and Mac were crashing while running the test.
Note that this does not entirely fix the bug. It fixes the WebCore
crash, but the test no longer seems to work due to loader changes.
So this patch does not reenable the test. The test probably has to
be rewritten.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::removedFromDocument): Re-added code to set the CSS target of the document to 0.
- 6:46 PM Changeset in webkit [45556] by
-
- 6 edits3 adds in trunk
2009-07-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
When one transition finishes slightly before another the longer
one will fire a second time. This is because the second
ImplicitAnmation object is culled too early, before its final
RenderStyle is in place. This is done by cleanupFinishedAnimations()
so I got rid of that method completely and now cleanup each
transition or animation at the point where I am setting the final
style, or when I detect that the transition or animation has been
terminated early (which happens when you remove it from the style).
Test: transitions/extra-transition.html
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate):
- page/animation/CompositeAnimation.h:
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent): Avoid a divide by zero if m_animation->duration() is zero, which can happen if the duration is changed to zero while the animation is running.
- 12:39 PM Changeset in webkit [45555] by
-
- 6 edits3 deletes in trunk
2009-07-05 Simon Fraser <Simon Fraser>
Revert the previous commit because it broke the
animations/transition-and-animation-1.html
testcase.
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent):
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
- page/animation/CompositeAnimation.h:
- 12:18 PM Changeset in webkit [45554] by
-
- 6 edits4 adds in trunk
2009-07-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
When one transition finishes slightly before another the longer
one will fire a second time. This is because the second
ImplicitAnmation object is culled too early, before its final
RenderStyle is in place. This is done by cleanupFinishedAnimations()
so I got rid of that method completely and now cleanup each
transition or animation at the point where I am setting the final
style, or when I detect that the transition or animation has been
terminated early (which happens when you remove it from the style).
Test: transitions/extra-transition.html
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate):
- page/animation/CompositeAnimation.h:
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent): Avoid a divide by zero if m_animation->duration() is zero, which can happen if the duration is changed to zero while the animation is running.
- 8:45 AM Changeset in webkit [45553] by
-
- 6 edits in trunk
2009-07-05 Lars Knoll <lars.knoll@nokia.com>
Reviewed by Maciej Stachowiak.
Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.
The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.
Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.
Based on idea by Norbert Leser.
- runtime/Lookup.h: Define JSC_CONST_HASHTABLE as const for !WINSCW.
- create_hash_table: Use JSC_CONST_HASHTABLE for hashtables.
- runtime/JSGlobalData.cpp: Import various global hashtables via the macro.
WebCore:
2009-07-05 Lars Knoll <lars.knoll@nokia.com>
Reviewed by Maciej Stachowiak.
Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.
The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.
Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.
Based on idea by Norbert Leser.
- bindings/scripts/CodeGeneratorJS.pm: Use JSC_CONST_HASHTABLE for hash tables define in the bindings.
- 7:53 AM Changeset in webkit [45552] by
-
- 7 edits in trunk/WebKit/gtk
2009-07-05 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
Always initialize WebCore.
It is possible that WebKitWebSettings and other classes get
constructed before the WebKitWebView. In this case WebCore is
not yet properly initialized. Add webkit_init to every class
that can be constructed by API users.
- webkit/webkitdownload.cpp: (webkit_download_class_init):
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_class_init):
- webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_class_init):
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_class_init):
- 7:33 AM Changeset in webkit [45551] by
-
- 3 edits in trunk/WebKit/qt
2009-07-05 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
Fix two qdoc warnings.
Added missing \property for QWebFrame::hasFocus and added \a
tag for pos of QWebPage::frameAt.
- Api/qwebframe.cpp:
- Api/qwebpage.cpp:
- 6:06 AM Changeset in webkit [45550] by
-
- 3 edits4 adds in trunk
Reviewed by Maciej Stachowiak.
Bug 26897 - Dynamic SVG images do not display correctly
https://bugs.webkit.org/show_bug.cgi?id=26897
Use repaint() to fix a rendering problem with a SVG image embedded in xhtml.
Test: svg/custom/createImageElement2.xhtml
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):
- 3:43 AM Changeset in webkit [45549] by
-
- 2 edits in trunk/WebCore
2009-07-05 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26960
[Gtk] caret offset not updated when selecting text
Report the caret offset from the end of the selection so it works
correctly for multi-char selections too (ie, anything that is not
the zero width caret).
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
- 12:28 AM Changeset in webkit [45548] by
-
- 2 edits in trunk/WebCore
Fix Qt link error by adding two new localized strings
In r45474 two new strings got added to LocalizedStrings.h add
the definition of them to Qt.
- 12:27 AM Changeset in webkit [45547] by
-
- 2 edits in trunk/WebKit/qt
2009-07-04 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
Use the recently introduced FocusController::setFocused
Use the recently introduced FocusController::setFocused
in the Qt platform. The SelectionController will be updated
from within the FocusController now.
- Api/qwebpage.cpp: (QWebPagePrivate::focusInEvent): (QWebPagePrivate::focusOutEvent):
Jul 4, 2009:
- 10:53 AM Changeset in webkit [45546] by
-
- 2 edits in trunk/JavaScriptCore
- debug build fix
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::getLastParen):
- 7:21 AM Changeset in webkit [45545] by
-
- 5 edits in trunk/JavaScriptCore
2009-07-03 Yong Li <yong.li@torchmobile.com>
Reviewed by Maciej Stachowiak (and revised slightly)
RegExp::match to be optimized
https://bugs.webkit.org/show_bug.cgi?id=26957
Allow regexp matching to use Vectors with inline capacity instead of
allocating a new ovector buffer every time.
~5% speedup on SunSpider string-unpack-code test, 0.3% on SunSpider overall.
- runtime/RegExp.cpp: (JSC::RegExp::match):
- runtime/RegExp.h:
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructorPrivate::RegExpConstructorPrivate): (JSC::RegExpConstructorPrivate::lastOvector): (JSC::RegExpConstructorPrivate::tempOvector): (JSC::RegExpConstructorPrivate::changeLastOvector): (JSC::RegExpConstructor::performMatch): (JSC::RegExpMatchesArray::RegExpMatchesArray): (JSC::RegExpMatchesArray::fillArrayInstance): (JSC::RegExpConstructor::getBackref): (JSC::RegExpConstructor::getLastParen): (JSC::RegExpConstructor::getLeftContext): (JSC::RegExpConstructor::getRightContext):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncSplit):
- 7:20 AM Changeset in webkit [45544] by
-
- 2 edits in trunk/WebKitTools
2009-07-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
bugzilla-tool forgot how to obsolete patches
https://bugs.webkit.org/show_bug.cgi?id=26951
- Scripts/modules/bugzilla.py:
Jul 3, 2009:
- 9:50 PM Changeset in webkit [45543] by
-
- 1 edit in trunk/WebCore/ChangeLog
Added Radar link I left out by accident the first time.
- 9:48 PM Changeset in webkit [45542] by
-
- 2 edits in trunk/WebCore
2009-07-03 Darin Adler <Darin Adler>
Reviewed by Adele Peterson.
REGRESSION (r44670-r44680): Typing is suprisingly slow in password field on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=26959
The code to handle iteration boundaries was malfunctioning when the boundary was
at the edge of a shadow tree. This happens all the time with <input> elements.
It's not immediately obvious how to make a regression test for this since the
symptom was a performance problem, not incorrect behavior. I'll add a test if I
figure out a way to make one.
- editing/TextIterator.cpp: (WebCore::parentCrossingShadowBoundaries): Renamed from parentOrShadowParent. (WebCore::depthCrossingShadowBoundaries): Updated for name change. (WebCore::nextInPreOrderCrossingShadowBoundaries): Added. (WebCore::previousInPostOrderCrossingShadowBoundaries): Added. (WebCore::setUpFullyClippedStack): Updated for name change. (WebCore::TextIterator::TextIterator): Updated for name change. Use nextInPreOrderCrossingShadowBoundaries instead of Range::pastLastNode to fix the bug. (WebCore::TextIterator::advance): Updated for name change. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Tweaked formatting. (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto. Changed code that initializes m_pastStartNode to use previousInPostOrderCrossingShadowBoundaries. (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Tweaked formatting. (WebCore::SimplifiedBackwardsTextIterator::exitNode): Ditto.
- 8:56 PM Changeset in webkit [45541] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Simon Fraser.
- fix <rdar://problem/6964278> REGRESSION (r42118): Scrolling redraw problem in FileMaker Pro
- WebView/WebHTMLView.mm: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Perform layout if needed, even on Mac OS X versions that have -viewWillDraw. This prevents attempts to draw without layout in case -viewWillDraw was not called due to NSView issues or the client did something during the display operation that re-invalidated the layout.
- 8:27 PM Changeset in webkit [45540] by
-
- 1 edit1 add in trunk/BugsSite
Bug 26958: Change edit link to review link in request messages
Reviewed by Dan Bernstein.
- template/en/custom/request/email.txt.tmpl: Copied from BugsSite/template/en/default/request/email.txt.tmpl. Changed link from "action=edit" to "action=review".
- 6:09 PM Changeset in webkit [45539] by
-
- 2 edits in trunk/LayoutTests
Not reviewed. Forgot to land ontimer-inline-event.html results within my last WML commit.
- 5:19 PM Changeset in webkit [45538] by
-
- 2 edits in trunk/BugsSite
Bug 26950: Make the summary and alias fields support click-to-edit
<https://bugs.webkit.org/show_bug.cgi?id=26950>
Reviewed by Maciej Stachowiak.
Original patch by Maciej Stachowiak.
- js/field.js: (hideEditableField): Updated to add click event listeners to the alias and short description elements to make them easier to edit. Renamed field_id parameter to field2_id (short description id) and added a field1_id parameter (alias id). (showEditableField): If a third parameter is passed in the ContainerInputArray parameter, use it to find the element to focus. Otherwise, fall back to the original behavior of focusing the first input field. (hideAliasAndSummary): Changed to pass the id for the alias element to hideEditableField().
- 1:54 PM Changeset in webkit [45537] by
-
- 2 edits in trunk/WebCore
2009-07-03 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Background audio stops playing when JS GC runs
https://bugs.webkit.org/show_bug.cgi?id=26956
Ensure we keep the Audio object around while it is playing, so that it
doesn't get collected.
Not testable because there's no way to know whether the audio keeps
playing without holding a reference to it.
- bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM):
- 12:34 PM Changeset in webkit [45536] by
-
- 2 edits in trunk/WebKitSite
2009-07-03 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Adam and Collin's affiliation is incorrect
https://bugs.webkit.org/show_bug.cgi?id=26954
This change corrects their affiliation.
- security/security-group-members.html:
- 7:08 AM Changeset in webkit [45535] by
-
- 2 edits in trunk/WebCore
2009-07-02 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26814
[Gtk] Caret-moved events are not issued for the correct offset
when text is selected forward
Report the caret offset from the end of the selection, otherwise
we'll report the same offset when moving the caret while
modififying the selection (eg, with Shift + Right).
- editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- 7:08 AM Changeset in webkit [45534] by
-
- 2 edits in trunk/WebCore
2009-07-02 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26815
[Gtk] text-selection-changed events are not issued for the correct
object when the selection spans multiple objects
Get the focused node from the end of the selection, not the start,
so we can detect when we cross object boundaries.
- editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- 3:47 AM Changeset in webkit [45533] by
-
- 2 edits in trunk/LayoutTests
2009-07-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Fisher.
Increase delay in worker-terminate layout test to make it more reliable.
https://bugs.webkit.org/show_bug.cgi?id=26917
This test used time delay to see of terminated worker does not return
messages (terminated). In some test conditions, the current delay (500ms)
is too short and test fails. Move setting the delay to the end of initialization
and increase it 2x to make test more reliable.
- fast/workers/worker-terminate.html:
- 3:24 AM Changeset in webkit [45532] by
-
- 2 edits in trunk/LayoutTests
2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>
Skip tests that require expected results that Gtk doesn't have.
- platform/gtk/Skipped:
- 2:57 AM Changeset in webkit [45531] by
-
- 11 edits1 add in trunk
2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez and Gustavo Noronha.
Set user-agent from application
https://bugs.webkit.org/show_bug.cgi?id=17375
Add 'user-agent' setter/getter API to WebSettings.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::FrameLoaderClient::userAgent):
- WebCoreSupport/FrameLoaderClientGtk.h:
- webkit/webkitprivate.h:
- webkit/webkitversion.h.in:
- webkit/webkitwebsettings.cpp: (webkit_get_user_agent): (webkit_web_settings_class_init): (webkit_web_settings_finalize): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy): (webkit_web_settings_get_user_agent):
- webkit/webkitwebsettings.h:
- webkit/webkitwebview.cpp: (webkit_web_view_dispose):
Define UA version macros to be used by the UA string.
Add new WebSettings unit test for the User-Agent string API.
- GNUmakefile.am:
- configure.ac:
Jul 2, 2009:
- 10:21 PM Changeset in webkit [45530] by
-
- 1 edit in trunk/WebCore/ChangeLog
Edit WebCore/ChangeLog last entry to fix a spelling typo.
Pointed out by Mark Rowe.
- 10:12 PM Changeset in webkit [45529] by
-
- 3 edits in trunk/WebCore
2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Fix the media controls hit tests. They may loose click events.
Test cases already covered in the video-controls-zoomed tests.
Don't trust wkHitTestMediaUIPart for the tests. We are accurate enough.
- rendering/RenderThemeMac.h: Remove hitTestMediaControlPart.
- rendering/RenderThemeMac.mm: Remove hitTestMediaControlPart.
- 8:34 PM Changeset in webkit [45528] by
-
- 2 edits in trunk/BugsSite/data
Ignore data/template cache directory and update data/params.
- 8:15 PM Changeset in webkit [45527] by
-
- 2 edits in trunk/WebKitTools
2009-07-02 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build fix (Cairo this time) for DumpRenderTree.
Put Cairo code back in, but use original include order
for the CG stuff to avoid compile issues.
- DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
- 7:14 PM Changeset in webkit [45526] by
-
- 1 edit1 add in trunk/BugsSite
Config file for contrib/recode.pl when upgrading bugs.webkit.org
Current as of midday on Wednesday, July 1, 2009.
- contrib/recode-overrides.txt: Added.
- 7:14 PM Changeset in webkit [45525] by
-
- 2 edits in trunk/BugsSite
Workaround for WebKit Bug 9630 when running contrib/recode.pl
A number of WebKit nightly builds included Bug 9630 which caused
non-breaking space characters (0xA0) to be submitted within the
content of textarea elements.
- contrib/recode.pl: To work around these 0xA0 characters, try an encoding of cp1252 and use it if it works.
- 7:14 PM Changeset in webkit [45524] by
-
- 2 edits in trunk/BugsSite
Don't print "Failed to guess" warning if an override is available
- contrib/recode.pl: Check that %overrides does NOT contain a key matching the current digest before printing out the warning about a failed charset guess.
- 7:14 PM Changeset in webkit [45523] by
-
- 2 edits in trunk/BugsSite
Added --[no-]truncate switch to contrib/recode.pl
- contrib/recode.pl: Added --[no-]truncate switch to make debugging of failed charset guessing easier. Often times the illegal character was truncated in the output.
- 7:14 PM Changeset in webkit [45522] by
-
- 75 edits in trunk/BugsSite
Changed Perl scripts to use #!/usr/bin/env perl
perl -pi -e 's@#\!/usr/bin/perl@#\!/usr/bin/env perl@' *.cgi *.pl */*.pl
- 7:14 PM Changeset in webkit [45521] by
-
- 2 edits1 delete in trunk/BugsSite
Replace Bugzilla favicon with webkit.org favicon
- favicon.ico: Removed.
- images/favicon.ico: Replaced. Copied from favicon.ico.
- 7:14 PM Changeset in webkit [45520] by
-
- 408 edits11 copies25 moves75 adds41 deletes in trunk/BugsSite
Merged BugsSite to Bugzilla-3.2.3
Updated to the latest-and-greatest stable version.
- 7:13 PM Changeset in webkit [45519] by
-
- 344 edits153 adds340 deletes in trunk/BugsSite
Merged BugsSite to Bugzilla-3.0.3
Nothing to see here. Move along.
- 6:38 PM Changeset in webkit [45518] by
-
- 4 edits in trunk/WebCore
2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Make sure we support full page zoom in video controls.
This is tracked by a the video-controls-zoom test case.
- css/mediaControlsQT.css: Make sure we don't have any inherited margin.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::updateStyle): Propagate the style to the innertext.
- rendering/RenderThemeMac.mm: Adjust the painting rect. (WebCore::getUnzoomedRectAndAdjustCurrentContext): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):
- 6:29 PM Changeset in webkit [45517] by
-
- 10 edits in trunk/WebCore
2009-07-02 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel.
RenderBlock and RenderInline have confusingly named object creation methods:
RenderBlock::createRootBox/createRootInlineBox
RenderInline::createFlowBox/createInlineFlowBox
where the 2nd method in both cases just calls the first and then appends the created object.
I therefore renamed those methods to something IMHO more informative:
createRootBox() -> createRootInlineBox()
createRootInlineBox() -> createAndAppendRootInlineBox();
createFlowBox() -> createInlineFlowBox();
createInlineFlowBox() -> createAndAppendInlineFlowBox();
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::createRootInlineBox): (WebCore::RenderBlock::createAndAppendRootInlineBox):
- rendering/RenderBlock.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::createInlineFlowBox): (WebCore::RenderInline::createAndAppendInlineFlowBox):
- rendering/RenderInline.h:
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineFlowBox):
- rendering/RenderSVGInline.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootInlineBox):
- rendering/RenderSVGText.h:
- rendering/bidi.cpp: (WebCore::createInlineBoxForRenderer):
- 6:23 PM Changeset in webkit [45516] by
-
- 3 edits in trunk/WebCore
2009-07-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Fix typo in the resource panel enabler caption.
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):
- 6:06 PM Changeset in webkit [45515] by
-
- 4 edits1 add in trunk
2009-07-02 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Roben.
[Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699
- manual-tests/drag-escape.html: Added.
- page/EventHandler.cpp: (WebCore::EventHandler::dragSourceEndedAt):
2009-07-02 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Roben.
[Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699
- WebDropSource.cpp: (WebDropSource::QueryContinueDrag):
- 5:55 PM Changeset in webkit [45514] by
-
- 2 edits in trunk/WebKitTools
2009-07-02 Eric Seidel <eric@webkit.org>
Correct blatant typo (missing []), no review.
- Scripts/modules/scm.py:
- 5:54 PM Changeset in webkit [45513] by
-
- 1 edit1 add in trunk/LayoutTests
2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
Added the test result of r45511 for platform/mac.
- platform/mac/media/controls-strict-expected.txt: Added.
- 5:37 PM Changeset in webkit [45512] by
-
- 2 edits in trunk/WebKitTools
2009-07-02 Brent Fulgham <bfulgham@webkit.org>
Windows build fix, no review.
Reverting PixelDumpSupportWin.cpp change to avoid strange
error on the build-bot.
- DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
- 5:18 PM Changeset in webkit [45511] by
-
- 2 edits in trunk/WebCore
2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
Fix the Gtk build after r45474. The localized strings should
have been added there.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):
- 5:07 PM Changeset in webkit [45510] by
-
- 3 edits2 adds in trunk
WebCore:
2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Media controller is rendered badly at http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html
We fix two things:
- We use px instead of em, because px is used everywhere else and because 0.09em hit the font size limit.
- We use -webkit-box instead of inline-block because in strict mode inline-block has a different behavior.
Test: media/controls-strict.html
- css/mediaControlsQT.css:
LayoutTests:
2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Media controller is rendered badly at http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html
Test that the controller renders correctly in strict mode as well.
- media/controls-strict.html: Added.
- platform/mac/media/controls-strict-mode-expected.txt: Added.
- 5:03 PM Changeset in webkit [45509] by
-
- 2 edits in trunk/WebKitTools
2009-07-02 Brent Fulgham <bfulgham@webkit.org>
Build fix, no review.
- DumpRenderTree/config.h:
- 4:55 PM Changeset in webkit [45508] by
-
- 2 edits in trunk/WebKit/win
<rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670)
<https://bugs.webkit.org/show_bug.cgi?id=26670>
Reviewed by Anders Carlsson
Make windows loader client match mac behaviour more closely.
- 4:53 PM Changeset in webkit [45507] by
-
- 3 edits in trunk/WebKitTools
2009-07-02 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
bugzilla-tool needs to handle login failure
https://bugs.webkit.org/show_bug.cgi?id=26913
We now exit(1) on login failure.
- Scripts/modules/bugzilla.py:
- 4:53 PM Changeset in webkit [45506] by
-
- 2 edits in trunk/WebCore
2009-07-02 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
TextIterator should use hasOverflowClip when checking for overflow instead of looking at the style.
https://bugs.webkit.org/show_bug.cgi?id=26942
- editing/TextIterator.cpp: (WebCore::fullyClipsContents):
- 4:49 PM Changeset in webkit [45505] by
-
- 9 edits4 adds in trunk
WebKit/win:
2009-06-30 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Build DumpRenderTree under Cairo.
https://bugs.webkit.org/show_bug.cgi?id=26457
- WebKit.vcproj/WebKit.sln: Add Cairo targets to the DumpRenderTree build, and use the in the Debug_Cairo and Release_Cairo targets.
WebKitTools:
2009-06-30 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Add build support for a Windows Cairo version of
DumpRenderTree. Share as much logic between the
CG and Cairo builds as possible.
https://bugs.webkit.org/show_bug.cgi?id=26457
- DumpRenderTree/PixelDumpSupport.cpp: Added. (dumpWebViewAsPixelsAndCompareWithExpected): Moved common logic from CG-specific file. (printPNG): Moved common logic from CG-specific file.
- DumpRenderTree/PixelDumpSupport.h: Add declaration for new common printPNG function.
- DumpRenderTree/cairo: Added.
- DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added. Implement cairo-specific logic for dealing with Cairo surfaces. (writeFunction): (printPNG): Cairo-specific PNG handling logic. (computeMD5HashStringForBitmapContext): New Cairo routine using the generic BitmapContext signature. (dumpBitmap): New function containing Cairo-specific portions of the dumping routine.
- DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added. Provide Cairo version of the BitmapContext structure so that dumping routines can work on an abstract type. (BitmapContext::createByAdoptingBitmapAndContext): (BitmapContext::~BitmapContext): (BitmapContext::cairoContext): (BitmapContext::BitmapContext):
- DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG): CG-specific PNG handling logic. (computeMD5HashStringForBitmapContext): Revised to use generic BitmapContext signature. (dumpBitmap): New function containing CG-specific portions of the dumping routine.
- DumpRenderTree/cg/PixelDumpSupportCG.h: Add new signatures.
- DumpRenderTree/win/DumpRenderTree.cpp: Disable CFNetwork logic when building the non-CFNetwork version. (main):
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView): Provide parallel Cairo implementation of CG bitmap/context setup.
- 4:45 PM Changeset in webkit [45504] by
-
- 2 edits in trunk/WebCore
2009-07-02 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Fix for <rdar://problem/5230700>
Remove local .xhtml file workaround
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Work around is no longer necessary.
- 4:36 PM Changeset in webkit [45503] by
-
- 4 edits in trunk
Versioning.
- 4:34 PM Changeset in webkit [45502] by
-
- 8 edits in trunk
WebCore:
2009-07-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Sort, add functions used by WebKit.
- WebCore.base.exp:
WebKit/mac:
2009-07-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6978783>
Software-rendered plug-in does not update correctly when inside a hardware layer
Replace calls to setNeedsDisplay: and setNeedsDisplayInRect: with a call to the new method
invalidatePluginContentRect:. This new method will ask WebCore to do the repainting, taking
transforms into account.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidateRect):
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginHostDied]):
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView preferencesHaveChanged:]): (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView invalidateRect:]): (-[WebNetscapePluginView invalidateRegion:]): (-[WebNetscapePluginView forceRedraw]):
- 4:33 PM Changeset in webkit [45501] by
-
- 1 copy in tags/Safari-6531.2
New tag.
- 4:31 PM Changeset in webkit [45500] by
-
- 6 edits in trunk/LayoutTests
2009-07-02 David Hyatt <hyatt@apple.com>
Reviewed by Mark Rowe.
Land new results from my change to make replaced elements no longer be overflow:hidden by
default. This affected plaintext dumping, which is clearly a bug in and of itself. For now
I am just updating the results and will file a followup bug about the fact that text dumping actually
does something different with overflow on replaced elements (when it clearly should not).
- fast/block/float/crash-replaced-display-block-expected.txt:
- fast/dom/Range/acid3-surround-contents-expected.txt:
- fast/dom/object-embed-plugin-scripting-expected.txt:
- fast/parser/badentity-expected.txt:
- http/tests/security/local-video-poster-from-remote-expected.txt:
- 4:28 PM Changeset in webkit [45499] by
-
- 2 edits in trunk/WebCore
2009-07-02 Brady Eidson <beidson@apple.com>
Rubberstamped by Sam Weinig.
More of <rdar://problem/6969425> Safari 4.0 doesn't recognize text/plain files if their extension is unknown.
- platform/network/mac/WebCoreURLResponse.mm: (webNSURLResponseMIMEType): Give Tiger a chance to query the UTI machinery.
- 4:18 PM Changeset in webkit [45498] by
-
- 3 edits2 adds in trunk/LayoutTests
2009-07-02 Brady Eidson <beidson@apple.com>
Rubberstamped by John Sullivan.
Add Tiger-specific results for these tests.
- platform/mac-tiger/Skipped:
- platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
- platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
- platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-expected.txt:
- 4:01 PM Changeset in webkit [45497] by
-
- 2 edits in trunk/LayoutTests
2009-07-02 Brady Eidson <beidson@apple.com>
Skip the correct test names.
- platform/mac-tiger/Skipped:
- 3:40 PM Changeset in webkit [45496] by
-
- 2 edits in trunk/WebCore
2009-07-02 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium Linux: fix complex text rendering with line break characters.
If the CSS white-space property is inhibiting line breaking, we might
find end-of-line characters rendered via the complex text path. Fonts
don't provide glyphs for these code points so, if we find one, we
simulate the space glyph being interposed in this case. Because the
input is variable-length per code point, we walk the input in step
with the output.
Covered by:
LayoutTests/fast/text/international/bidi-linebreak-002.html
LayoutTests/fast/text/international/bidi-linebreak-003.html
LayoutTests/fast/text/international/hindi-whitespace.html
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::stringToGlyphs):
- 3:25 PM Changeset in webkit [45495] by
-
- 4 edits2 copies2 adds in trunk/LayoutTests
2009-07-02 Brady Eidson <beidson@apple.com>
Rubberstamped by Sam Weinig
Split up file-url-mimetypes.html into 3 tests to avoid any risk of timing out on slower machines.
- platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
- platform/mac/fast/loader/file-url-mimetypes-2.html: Copied from platform/mac/fast/loader/file-url-mimetypes.html.
- platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
- platform/mac/fast/loader/file-url-mimetypes-3.html: Copied from platform/mac/fast/loader/file-url-mimetypes.html.
- platform/mac/fast/loader/file-url-mimetypes-expected.txt:
- platform/mac/fast/loader/file-url-mimetypes.html:
- platform/mac-tiger/Skipped:
- 3:22 PM Changeset in webkit [45494] by
-
- 3 edits in trunk/WebCore
2009-07-02 Victor Wang <victorw@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=26521
Expose file size to chromium.
Implement getFileSize() for Chromium.
- platform/chromium/ChromiumBridge.h:
- platform/chromium/FileSystemChromium.cpp: (WebCore::getFileSize):
- 3:21 PM Changeset in webkit [45493] by
-
- 2 edits in trunk/WebKitTools
2009-07-02 Eric Seidel <eric@webkit.org>
No review, just adding Antti as a reviewer.
- Scripts/modules/bugzilla.py:
- 3:21 PM Changeset in webkit [45492] by
-
- 2 edits in trunk/WebCore
2009-07-02 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
- bindings/v8/V8SVGPODTypeWrapper.h: Lost a space in nested template argument list.
- 3:19 PM Changeset in webkit [45491] by
-
- 2 edits in trunk/WebCore
2009-07-02 Simon Fraser <Simon Fraser>
Build fix: add missing #include.
- platform/mac/ThemeMac.mm:
- 3:17 PM Changeset in webkit [45490] by
-
- 2 edits in trunk/LayoutTests
2009-07-02 Brady Eidson <beidson@apple.com>
Resolve failing Tiger layout test until I can fix it.
- platform/mac-tiger/Skipped:
- 2:56 PM Changeset in webkit [45489] by
-
- 2 edits in trunk/WebCore
2009-07-02 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
<rdar://problem/7028682> ThemeMac::paintRadio() throws Obj-C exceptions when zoomed
Add BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS guards around code
that can possibly throw Objective-C exceptions when drawing Mac form controls.
- platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio): (WebCore::paintButton): (WebCore::ThemeMac::inflateControlPaintRect):
- 2:47 PM Changeset in webkit [45488] by
-
- 2 edits1 add in trunk/WebCore
2009-07-02 Nate Chapin <Nate Chapin>
Reviewed by David Levin.
Upstream V8SVGPODTypeWrapper.
- 2:40 PM Changeset in webkit [45487] by
-
- 10 edits2 adds in trunk/WebCore
2009-07-02 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Adds an abstraction layer between the DB classes and the file
system, which allows us to add our own logic for storing, opening,
deleting, etc. databases.
The patch was tested using the tests in WebCore/storage.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open): Delegating the job of opening DB files to SQLiteFileSystem to allow use of custom VFSs.
- platform/sql/SQLiteFileSystem.cpp: Added.
- platform/sql/SQLiteFileSystem.h: Added.
- platform/win/FileSystemWin.cpp: (WebCore::directoryName): Implemented.
- storage/Database.cpp: (WebCore::Database::databaseSize): The code that returns the size of a DB file moved to SQLiteFileSystem.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Added the ability to register a custom SQLite VFS. (WebCore::DatabaseTracker::trackerDatabasePath): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::openTrackerDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::originPath): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::fullPathForDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::usageForDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::deleteOrigin): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::deleteDatabaseFile): DB file-related operations moved to SQLiteFileSystem.
- storage/OriginUsageRecord.cpp: (WebCore::OriginUsageRecord::diskUsage): DB file-related operations moved to SQLiteFileSystem.
- 1:47 PM Changeset in webkit [45486] by
-
- 4 edits in trunk/WebCore
2009-07-02 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Always clip replaced elements to border radii.
https://bugs.webkit.org/show_bug.cgi?id=26933
Make sure to always clip replaced elements to border radii, even when overflow is visible.
Stop defaulting those elements to overflow:hidden in the UA sheet, since it is now no longer
necessary.
Covered by existing tests (since the UA default changing keeps the behavior exactly the same).
- css/html.css:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
- 1:18 PM Changeset in webkit [45485] by
-
- 5 edits in trunk/WebCore
2009-07-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Simon Fraser.
convertFromScrollbarToContainingView and friends should be in ScrollView
https://bugs.webkit.org/show_bug.cgi?id=26929
This is breaking Chromium's build because PopupMenuChromium inherits
from ScrollView, but these functions are pure virtual in it. I could
put it directly in PopupMenuChromium, but that seems a bit silly since
the functions are fairly generic.
Passes existing layout tests.
- page/FrameView.cpp: Remove the 4 functions Hyatt just added (IntRect WebCore::FrameView::convertFromScrollbarToContainingView): (IntRect WebCore::FrameView::convertFromContainingViewToScrollBar): (IntPoint WebCore::FrameView::convertFromScrollbarToContainingView): (IntPoint WebCore::FrameView::convertFromContainingViewToScrollBar):
- page/FrameView.h: ditto
- platform/ScrollView.cpp: Move the 4 functions from FrameView here (IntRect WebCore::ScrollView::convertFromScrollbarToContainingView): (IntRect WebCore::ScrollView::convertFromContainingViewToScrollBar): (IntPoint WebCore::ScrollView::convertFromScrollbarToContainingView): (IntPoint WebCore::ScrollView::convertFromContainingViewToScrollBar):
- platform/ScrollView.h: ditto
- 11:39 AM Changeset in webkit [45484] by
-
- 4 edits in trunk/WebKit
Fix warnings from update-webkit-localizable-strings
WebKit:
Fix warnings from update-webkit-localizable-strings
Rubber-stamped by Eric Carlson.
- English.lproj/Localizable.strings: Updated.
WebKit/mac:
Fix warnings from update-webkit-localizable-strings
Rubber-stamped by Eric Carlson.
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory mediaElementLoadingStateText]): (-[WebViewFactory mediaElementLiveBroadcastStateText]): Changed the localization comments to match the comments in the Windows version of this file, to avoid warnings about different comments for the same localized string.
- 11:39 AM Changeset in webkit [45483] by
-
- 2 edits in trunk/WebKit
Update StringsNotToBeLocalized.txt for (not so) recent changes
Bug 26926: StringsNotToBeLocalized.txt is out-of-date
<https://bugs.webkit.org/show_bug.cgi?id=26926>
Reviewed by John Sullivan.
- StringsNotToBeLocalized.txt:
- 11:06 AM Changeset in webkit [45482] by
-
- 5 edits4 adds in trunk
2009-07-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Fisher.
Fix https://bugs.webkit.org/show_bug.cgi?id=26088 - TransparencyWin
doesn't handle errors well at all; revise it to fail silently
(drawing nothing), and bulletproof FontChromiumWin to handle the
failure accordingly.
Tests: fast/text/text-large-negative-letter-spacing-with-opacity.html
fast/text/text-letter-spacing.html
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::TransparencyWin): (WebCore::TransparencyWin::setupLayerForNoLayer): (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer): (WebCore::TransparencyWin::setupLayerForWhiteLayer): (WebCore::TransparencyWin::setupTransformForKeepTransform): (WebCore::TransparencyWin::setupTransformForScaleTransform): (WebCore::TransparencyWin::initializeNewContext): (WebCore::TransparencyWin::compositeOpaqueComposite): (WebCore::TransparencyWin::compositeTextComposite): (WebCore::TransparencyWin::makeLayerOpaque):
- platform/graphics/chromium/TransparencyWin.h: (WebCore::TransparencyWin::platformContext):
- 10:51 AM Changeset in webkit [45481] by
-
- 1 edit in trunk/WebCore/platform/ScrollbarClient.h
Fix build bustage caused by wrong include case.
- 10:41 AM Changeset in webkit [45480] by
-
- 4 edits in trunk
2009-07-02 Eric Carlson <eric.carlson@apple.com>
Change #import to #include to fix non-ObjC builds.
- rendering/MediaControlElements.cpp:
2009-07-02 Eric Carlson <eric.carlson@apple.com>
Fix Windows build by including missing localized string methods.
- WebCoreLocalizedStrings.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):
- 10:32 AM Changeset in webkit [45479] by
-
- 2 edits in trunk/WebCore
2009-07-02 Anders Carlsson <andersca@apple.com>
Build fix.
- platform/network/mac/WebCoreURLResponse.mm: (mimeTypeFromUTITree):
- 10:31 AM Changeset in webkit [45478] by
-
- 21 edits4 adds in trunk
WebCore:
2009-07-02 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Fix for bug 22119, clicks in the scrollbars of transformed content don't work. Add new
conversion methods for going across parent/child widget boundaries that can be implemented
by the FrameView and ScrollbarClient to be transform-aware.
Test cases added in platform/mac/fast/forms and platform/mac/fast/overflow.
- WebCore.base.exp:
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
- page/FrameView.cpp: (WebCore::FrameView::convertFromScrollbarToContainingView): (WebCore::FrameView::convertFromContainingViewToScrollbar): (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToRenderer): (WebCore::FrameView::convertToContainingView): (WebCore::FrameView::convertFromContainingView):
- page/FrameView.h:
- platform/ScrollView.h:
- platform/Scrollbar.cpp: (WebCore::Scrollbar::convertToContainingView): (WebCore::Scrollbar::convertFromContainingView):
- platform/Scrollbar.h:
- platform/ScrollbarClient.h: (WebCore::ScrollbarClient::convertFromScrollbarToContainingView): (WebCore::ScrollbarClient::convertFromContainingViewToScrollbar):
- platform/Widget.cpp: (WebCore::Widget::convertFromContainingWindow): (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromRootToContainingWindow): (WebCore::Widget::convertFromContainingWindowToRoot): (WebCore::Widget::convertToContainingView): (WebCore::Widget::convertFromContainingView):
- platform/Widget.h:
- platform/graphics/IntPoint.h: (WebCore::IntPoint::move):
- platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromRootToContainingWindow): (WebCore::Widget::convertFromContainingWindowToRoot):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl):
- rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::convertFromScrollbarToContainingView): (WebCore::RenderDataGrid::convertFromContainingViewToScrollbar):
- rendering/RenderDataGrid.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertFromScrollbarToContainingView): (WebCore::RenderLayer::convertFromContainingViewToScrollbar): (WebCore::RenderLayer::scrollbarOffset): (WebCore::RenderLayer::hitTestOverflowControls):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl): (WebCore::RenderListBox::convertFromScrollbarToContainingView): (WebCore::RenderListBox::convertFromContainingViewToScrollbar):
- rendering/RenderListBox.h:
LayoutTests:
2009-07-02 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Test cases for bug 22119, clicks in scrollbar of transformed element don't work.
- platform/mac/fast/forms/listbox-scrollbar-hit-test-expected.txt: Added.
- platform/mac/fast/forms/listbox-scrollbar-hit-test.html: Added.
- platform/mac/fast/overflow/overflow-scrollbar-hit-test-expected.txt: Added.
- platform/mac/fast/overflow/overflow-scrollbar-hit-test.html: Added.
- 10:19 AM Changeset in webkit [45477] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt and Simon Fraser.
- fix <rdar://problem/6933052> SPOD playing video in a div with a box shadow
Test: fast/box-shadow/transform-fringing.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Clip out the box even if it has an opaque background, but in that case, inset the clip path by 1 pixel, to avoid antialiasing artifacts. Do not inset the clip rect by 1 pixel if the CTM is purely a translation. Move the shadow-casting path away in the non-rounded-rect case (it was already being done in the rounded-rect case), to avoid a black fringe when the CTM is not purely a translation.
LayoutTests:
Reviewed by Dave Hyatt and Simon Fraser.
- test for part of <rdar://problem/6933052> SPOD playing video in a div with a box shadow
- fast/box-shadow/transform-fringing.html: Added.
- platform/mac/fast/box-shadow/transform-fringing-expected.checksum: Added.
- platform/mac/fast/box-shadow/transform-fringing-expected.png: Added.
- platform/mac/fast/box-shadow/transform-fringing-expected.txt: Added.
- 10:00 AM Changeset in webkit [45476] by
-
- 7 edits91 adds in trunk
WebCore:
2009-07-02 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/6969425> Safari 4.0 doesn't recognize text/plain files if their extension is unknown.
Walk the CoreTypes UTI tree for extensions with unknown MIME types, using the first MIME type found.
For many types of text files (such as source code files) this ends up being text/plain.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Tweak the logging output.
- platform/network/mac/WebCoreURLResponse.h:
- platform/network/mac/WebCoreURLResponse.mm: (mimeTypeFromUTITree): (webNSURLResponseMIMEType): Use mimeTypeFromUTITree() to find a UTI-based MIME type for this file's extension. (-[NSURLResponse _webcore_reportedMIMEType]): Return the actual MIME type that CFNetwork gave us.
LayoutTests:
2009-07-02 Brady Eidson <beidson@apple.com>
Rubberstamped by Sam Weinig.
Add more sample files for extensions we should know the MIME types for.
- platform/mac/fast/loader/file-url-mimetypes.html:
- platform/mac/fast/loader/file-url-mimetypes-expected.txt:
- platform/mac/fast/loader/resources/mimeTypeExamples/example-3fr.3fr: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-aaf.aaf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ada.ada: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-adb.adb: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ads.ads: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-app.app: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-applescript.applescript: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-arw.arw: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-as.as: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-aupreset.aupreset: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-c++.c++: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-c.c: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-caf.caf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-cc.cc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-cp.cp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-cpp.cpp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-cr2.cr2: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-cxx.cxx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-defs.defs: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dfont.dfont: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dlyan.dlyan: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dng.dng: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dylib.dylib: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-exp.exp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-exr.exr: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-f.f: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-f77.f77: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-f90.f90: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-f95.f95: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-fff.fff: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-for.for: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-h++.h++: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-h.h: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-hh.hh: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-hp.hp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-hpp.hpp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-hxx.hxx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-icc.icc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-icm.icm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-icns.icns: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jav.jav: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-java.java: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jfx.jfx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-l.l: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-lid.lid: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-lm.lm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-lmm.lmm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-lpp.lpp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-lxx.lxx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-m.m: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-m4a.m4a: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-m4b.m4b: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-m4v.m4v: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mig.mig: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mm.mm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mos.mos: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mrw.mrw: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-nef.nef: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-o.o: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-omf.omf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-orf.orf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pas.pas: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pch++.pch++: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pch.pch: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pef.pef: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pf.pf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pfa.pfa: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pfb.pfb: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-plist.plist: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-r.r: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-raf.raf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-raw.raw: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-s.s: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-scpt.scpt: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-sd2.sd2: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-sf2.sf2: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-srf.srf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-suit.suit: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tbz.tbz: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tbz2.tbz2: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ttc.ttc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ttf.ttf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ul.ul: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ulaw.ulaw: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ulw.ulw: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-war.war: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-y.y: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ym.ym: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ymm.ymm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ypp.ypp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-yxx.yxx: Added.
- 9:33 AM Changeset in webkit [45475] by
-
- 4 edits in trunk/WebKit/mac
2009-07-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Compositing-related preference methods are not public API; should move to WebPreferencesPrivate.h
<rdar://problem/7027363>
Move accelerated-compositing pref to WebPreferencesPrivate.h
- WebView/WebPreferences.h:
- WebView/WebPreferences.mm: (-[WebPreferences acceleratedCompositingEnabled]): (-[WebPreferences setAcceleratedCompositingEnabled:]):
- WebView/WebPreferencesPrivate.h:
- 8:47 AM Changeset in webkit [45474] by
-
- 36 edits in trunk
2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6518119>
Add a rewind button and hide the timeline for live broadcasts when
in MediaUI mode.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Add the new pseudo element.
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Ditto.
- css/CSSSelector.h:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
- css/CSSValueKeywords.in: Ditto.
- css/mediaControls.css: Ditto.
- css/mediaControlsQT.css: Ditto.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::rewind): New. (WebCore::HTMLMediaElement::returnToRealTime): New. (WebCore::HTMLMediaElement::isStreaming): New.
- html/HTMLMediaElement.h:
- page/mac/WebCoreViewFactory.h: Declare mediaElementLoadingStateText and mediaElementLiveBroadcastStateText.
- platform/LocalizedStrings.h: Add localized media state messages.
- platform/ThemeTypes.h: Add the new pseudo element.
- platform/mac/LocalizedStringsMac.mm: (WebCore::mediaElementLoadingStateText): Add localized media state. (WebCore::mediaElementLiveBroadcastStateText): Ditto.
- platform/mac/WebCoreSystemInterface.h: Change BOOL param wkDrawMediaUIPart to an int to support
multiple states.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::MediaControlElement): Deal with new elements. (WebCore::MediaControlElement::attachToParent): Ditto. (WebCore::MediaControlElement::update): Ditto. (WebCore::MediaControlElement::updateStyle): Ditto. (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement): Ditto. (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded): Ditto. (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement): Ditto. (WebCore::MediaControlStatusDisplayElement::update): Ditto. (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Ditto. (WebCore::MediaControlInputElement::MediaControlInputElement): Ditto. (WebCore::MediaControlInputElement::attachToParent): Ditto. (WebCore::MediaControlInputElement::updateStyle): Ditto. (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Ditto. (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::rendererIsNeeded): Ditto. (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto. (WebCore::MediaControlTimelineElement::update): Ditto. (WebCore::MediaControlFullscreenButtonElement::rendererIsNeeded): Ditto.
- rendering/MediaControlElements.h: Ditto.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): Deal with the new elements. (WebCore::RenderMedia::createPanel): Ditto. (WebCore::RenderMedia::createRewindButton): Ditto. (WebCore::RenderMedia::createReturnToRealtimeButton): Ditto. (WebCore::RenderMedia::createStatusDisplay): Ditto. (WebCore::RenderMedia::createTimelineContainer): Ditto. (WebCore::RenderMedia::createCurrentTimeDisplay): Ditto. (WebCore::RenderMedia::createTimeRemainingDisplay): Ditto. (WebCore::RenderMedia::updateControls): Ditto. (WebCore::RenderMedia::forwardEvent): Ditto.
- rendering/RenderMedia.h:
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Deal with the new elements.
- rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaRewindButton): Deal with the new elements. (WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Ditto. (WebCore::RenderTheme::paintMediaControlsBackground): Ditto.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaRewindButton): Deal with the new elements. (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton): Ditto. (WebCore::RenderThemeMac::paintMediaControlsBackground): Ditto.
- rendering/style/RenderStyleConstants.h: Add constants for the new elements.
2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6518119>
Add localized strings for media controller status messages.
- English.lproj/Localizable.strings: Localized text.
2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6518119>
Add localized strings for media controller status.
- WebCoreSupport/WebViewFactory.mm: Add new localized text. (-[WebViewFactory mediaElementLoadingStateText]): (-[WebViewFactory mediaElementLiveBroadcastStateText]):
2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Update WebKitSystemInterface for <rdar://problem/6518119>
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 7:15 AM Changeset in webkit [45473] by
-
- 5 edits in trunk
WebKitTools:
2009-07-02 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Set DRT's default fontsize to 13.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):
LayoutTests:
2009-07-02 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
Updated computed-style-expected.txt and computed-style-without-renderer-expected.txt
files according to the default font size value (13) set in DumpRenderTree/qt/DumpRenderTree.cpp .
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 7:00 AM Changeset in webkit [45472] by
-
- 3 edits in trunk/WebKit/qt
2009-07-02 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Improve documentation of QWebFrame::setFocus and hasFocus()
Added missing Q_PROPERTY for QWebFrame::hasFocus.
- Api/qwebframe.cpp: Clarify the docs.
- Api/qwebframe.h: add Q_PROPERTY(focus).
- 6:47 AM Changeset in webkit [45471] by
-
- 4 edits in trunk/WebKit/qt
2009-07-02 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
Bug 26855: [Qt] New methods for QWebFrame to check and set focus.
Added new public methods QWebFrame::hasFocus() and QWebFrame::setFocus()
Added auto test.
- Api/qwebframe.cpp: (QWebFrame::hasFocus): (QWebFrame::setFocus):
- Api/qwebframe.h:
- tests/qwebframe/tst_qwebframe.cpp:
- 4:50 AM Changeset in webkit [45470] by
-
- 2 edits in trunk/WebKit/gtk
2009-07-02 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
Update the new boolean property in FocusController that keeps
track of whether or not the Page is focused.
- webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event):
Jul 1, 2009:
- 11:54 PM Changeset in webkit [45469] by
-
- 3 edits in trunk/WebKitTools
2009-07-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool fails for SVN users
https://bugs.webkit.org/show_bug.cgi?id=26914
To fix this I moved svn from -F - to using -m
In order for -m to work I had to move us off of shell=True
To move off of shell=True all call sites for run_command
which take args, need to pass their args as an list instead of a string.
In order for the final bug update to work correctly, I had to
abstract the way that we parse out revision numbers from the commit text.
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 11:30 PM Changeset in webkit [45468] by
-
- 3 edits4 adds in trunk
2009-07-01 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<video> fails to show on http://camendesign.com/code/video_for_everybody
<rdar://problem/7026010>
https://bugs.webkit.org/show_bug.cgi?id=26919
Fix an issue introduced in r44961. In that revision we changed to only update
compositing layer geometry when all siblings had been laid out (i.e. we pushed
the updates one level down). However, that left out the root layer, so this
fix ensures that the root layer geometry gets updated at the end.
Test: compositing/geometry/root-layer-update.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
- 11:26 PM Changeset in webkit [45467] by
-
- 5 edits in trunk/WebCore
2009-07-01 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
Small refactoring of MessagePortChannel so that PlatformMessagePortChannel
may be defined at the WebKit layer.
- dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):
- dom/MessagePortChannel.cpp:
- dom/MessagePortChannel.h:
- dom/default/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::createChannel): (WebCore::MessagePortChannel::create): (WebCore::MessagePortChannel::MessagePortChannel): (WebCore::MessagePortChannel::~MessagePortChannel):
- 11:04 PM Changeset in webkit [45466] by
-
- 2 edits in trunk/LayoutTests
2009-07-01 Xan Lopez <xlopez@igalia.com>
Disable accessibility tests until we have the accessibility
controller.
- platform/gtk/Skipped:
- 10:13 PM Changeset in webkit [45465] by
-
- 3 edits6 adds in trunk
2009-07-01 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
<rdar://problem/7026010> <video> fails to show on http://camendesign.com/code/video_for_everybody
First part of fix: when outline width changes, don't to a synchronous
layer update right away, but just set the flag to say that compositing
layers need updating. The synchronous layer update left the layer geometries
out of whack when it happened in the middle of layout (e.g. when inside ::first-letter).
Test: compositing/geometry/outline-change.html
- rendering/RenderView.cpp: (WebCore::RenderView::setMaximalOutlineSize):
- 10:13 PM Changeset in webkit [45464] by
-
- 2 edits in trunk/WebKitTools
2009-07-01 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
prepare-ChangeLog should have a --bug= argument and use it for url autofill
https://bugs.webkit.org/show_bug.cgi?id=26383
prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org
I also added a bit more template text in an effort to get better ChangeLogs
from casual contributers.
- Scripts/prepare-ChangeLog:
- 7:08 PM Changeset in webkit [45463] by
-
- 2 edits in trunk/WebKit/qt
2009-07-01 Robert Hogan <robert@roberthogan.net>
Reviewed by NOBODY.
Fix Qt segfault when javascript disabled.
If clients call addToJavaScriptWindowObject even though JavascriptEnabled is false
webkit will segfault on the assert:
ASSERTION FAILED: _rootObject
(../../../WebCore/bridge/runtime.cpp:52
JSC::Bindings::Instance::Instance(WTF::PassRefPtr<JSC::Bindings::RootObject>))
Fix is to ensure JavaScript is enabled when client calls addToJavaScriptWindowObject.
- Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):
- 7:01 PM Changeset in webkit [45462] by
-
- 2 edits in trunk/WebCore
2009-07-01 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26842
Build fix when ENABLE_DATABASE is off
Move Database.h into ENABLE(DATABASE) guard so toggling ENABLE_DATABASE
off does not break builds.
- bindings/js/ScriptObjectQuarantine.cpp:
- 6:35 PM Changeset in webkit [45461] by
-
- 6 edits4 adds in trunk
WebCore:
2009-07-01 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Modified XSSAuditor::decodeURL to only remove null characters so that
it is consistent with the behavior of HTMLTokenizer and prevents
injected scripts that contain control characters.
Tests: http/tests/security/xssAuditor/script-tag-control-char.html
http/tests/security/xssAuditor/script-tag-null-char.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeURL): Modified to only remove null characters.
- page/XSSAuditor.h: Reverted naming of third argument of method XSSAuditor::decodeURL from allowControlCharacters back to allowNullCharacters.
- platform/network/ResourceResponseBase.cpp: Reverted back to rev #45003. (WebCore::isControlCharacter):
- platform/network/ResourceResponseBase.h: Reverted back to rev #45003.
LayoutTests:
2009-07-01 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests that XSSAuditor prevents injected scripts that contain control characters.
- http/tests/security/xssAuditor/script-tag-control-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-control-char.html: Added.
- http/tests/security/xssAuditor/script-tag-null-char-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-null-char.html: Added.
- 6:03 PM Changeset in webkit [45460] by
-
- 5 edits1 add in trunk/WebCore
2009-07-01 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
- supported keyboard shortcuts compatible with Firebug in Scripts Debugger: F5, Ctrl+/ (win,lin), Command+/ (mac) - continue F10, Ctrl+' (win, lin), Command+' (mac) - step over F11, Ctrl+; (win, lin), Command+; (mac) - step into Shift+F11, Ctrl+Shift+; (win, lin), Command+Shift+; (mac) - step out
- added call stack navigation shortcuts: Ctrl+. - next call frame Ctrl+, - previouse call frame
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.handleKeyEvent): (WebInspector.CallStackSidebarPane.prototype._selectNextCallFrameOnStack): (WebInspector.CallStackSidebarPane.prototype._selectPreviousCallFrameOnStack): (WebInspector.CallStackSidebarPane.prototype._selectedPlacardByIndex): (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
- inspector/front-end/KeyboardShortcut.js: Added. (WebInspector.KeyboardShortcut): (WebInspector.KeyboardShortcut.makeKey): (WebInspector.KeyboardShortcut.makeKeyFromEvent): (WebInspector.KeyboardShortcut.makeKeyFromCodeAndModifiers_):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.handleKeyEvent):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 5:54 PM Changeset in webkit [45459] by
-
- 7 edits in trunk/WebCore
2009-07-01 Daniel Erat <derat@google.com>
Reviewed by David Levin.
Chromium Linux: Move the scrollbar thumb on middle-click.
https://bugs.webkit.org/show_bug.cgi?id=26910
http://code.google.com/p/chromium/issues/detail?id=11976
Tested by building Chrome and checking that the scrollbar moves as expected.
- platform/chromium/ScrollbarThemeChromium.cpp:
- platform/chromium/ScrollbarThemeChromium.h:
- platform/chromium/ScrollbarThemeChromiumLinux.cpp:
- platform/chromium/ScrollbarThemeChromiumLinux.h:
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
- platform/chromium/ScrollbarThemeChromiumWin.h:
- 5:38 PM Changeset in webkit [45458] by
-
- 10 edits in trunk
WebCore:
2009-07-01 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Add a preference/setting to toggle whether content sniffing is enabled for file URLs.
- WebCore.base.exp:
- page/Settings.cpp: (WebCore::Settings::setLocalFileContentSniffingEnabled):
- page/Settings.h: (WebCore::Settings::localFileContentSniffingEnabled):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
WebKit/mac:
2009-07-01 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Add a preference/setting to toggle whether content sniffing is enabled for file URLs.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences localFileContentSniffingEnabled]): (-[WebPreferences setLocalFileContentSniffingEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
- 5:13 PM Changeset in webkit [45457] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-07-01 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Don't reload values in emitBinaryDoubleOp.
SunSpider reports a 0.6% progression.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitBinaryDoubleOp):
- 4:34 PM Changeset in webkit [45456] by
-
- 4 edits2 adds in trunk
Bug 26909: aria-label needs to be supported
https://bugs.webkit.org/show_bug.cgi?id=26909
- 4:31 PM Changeset in webkit [45455] by
-
- 2 edits in trunk/WebKitTools
2009-07-01 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
prepare-ChangeLog should fail when EMAIL_ADDRESS or REAL_NAME are missing:
https://bugs.webkit.org/show_bug.cgi?id=26692
I also made prepare-ChangeLog sanity-check names and email addresses a little.
Names must contain a space, and email addresses must contain '@'
Also "fixed" $email_address to $emailAddress. This script uses mixed variable name styles.
- Scripts/prepare-ChangeLog:
- 4:15 PM Changeset in webkit [45454] by
-
- 6 edits in trunk/WebCore
2009-07-01 David Hyatt <hyatt@apple.com>
Reviewed by Oliver Hunt.
More datagrid columns work. Make sure columns cache both a style for the column header as well
as a style for the column background (behind the cells).
Hook up to CSSStyleSelector methods for obtaining the pseudo styles for columns (stubbed out and
unimplemented).
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pseudoStyleForDataGridColumn): (WebCore::CSSStyleSelector::pseudoStyleForDataGridColumnHeader):
- css/CSSStyleSelector.h:
- html/DataGridColumn.h: (WebCore::DataGridColumn::setColumnList): (WebCore::DataGridColumn::columnStyle): (WebCore::DataGridColumn::setColumnStyle): (WebCore::DataGridColumn::headerStyle): (WebCore::DataGridColumn::setHeaderStyle):
- rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::recalcStyleForColumn): (WebCore::RenderDataGrid::columnStyle): (WebCore::RenderDataGrid::headerStyle): (WebCore::RenderDataGrid::paintColumnHeaders):
- rendering/RenderDataGrid.h:
- 4:12 PM JSC edited by
- (diff)
- 4:06 PM JSC edited by
- Add information about built-in functions. (diff)
- 3:33 PM Changeset in webkit [45453] by
-
- 3 edits in trunk/WebCore
2009-07-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/7009870> After <audio> movie finishes playing, Pause button fails to change
back to Play button
Grab onto the current time when QTKit "ended" notification fires and use it as
duration from that point on as QuickTime sometimes refuses to play all the way to
the time it reports for duration and buffered. HTMLMediaElement assumes that there
more to play in this situation and tries to restart playback, endlessly.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
Rename m_duration to m_reportedDuration. Declare m_cachedDuration.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
Rename m_duration to m_reportedDuration. Initialize m_cachedDuration.
(WebCore::MediaPlayerPrivate::duration):
Return m_cachedDuration once it has been set.
(WebCore::MediaPlayerPrivate::updateStates):
Rename m_duration to m_reportedDuration.
(WebCore::MediaPlayerPrivate::didEnd):
Set m_cachedDuration to currentTime().
- 3:29 PM JSC edited by
- (diff)
- 3:01 PM Changeset in webkit [45452] by
-
- 11 edits2 adds in trunk
Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions
https://bugs.webkit.org/show_bug.cgi?id=26900
- 2:41 PM Changeset in webkit [45451] by
-
- 2 edits in trunk/WebKitTools
Change how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices.
This makes WebKit.app behave as expected when set as the default web browser on a wider
range of OS versions.
Reviewed by Simon Fraser.
- WebKitLauncher/WebKitNightlyEnabler.m:
(poseAsWebKitApp):
(enableWebKitNightlyBehaviour):
- 2:41 PM Changeset in webkit [45450] by
-
- 2 edits in trunk/WebKitTools
Shuffle some code around in preparation for a change to how poseAsWebKitApp works.
Reviewed by Simon Fraser.
- WebKitLauncher/WebKitNightlyEnabler.m:
(systemVersion):
(webKitLauncherBundle):
(insideSafari4OnTigerTrampoline):
- 2:19 PM Changeset in webkit [45449] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-07-01 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Convert op_div to load op1 and op2 up front.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_div):
- 2:06 PM Changeset in webkit [45448] by
-
- 4 edits in trunk/WebCore
2009-07-01 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Remove unused code in SVGTransformList and SVGTransformDistance
<https://bugs.webkit.org/show_bug.cgi?id=26891>
- svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance):
- svg/SVGTransformList.cpp:
- svg/SVGTransformList.h:
- 2:02 PM Changeset in webkit [45447] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-07-01 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Don't emit code in emitBinaryDoubleOp if code is unreachable, observable
via an empty (unlinked) jumplist passed in. This only effects op_jnless
and op_jnlesseq at present.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emitBinaryDoubleOp):
- 1:59 PM Changeset in webkit [45446] by
-
- 10 edits in trunk/WebCore
2009-07-01 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Begin stubbing out functions for layout, painting and style/geometry caching on columns. Not enough
is implemented for this to do much of anything yet, but it should help keep patch sizes down. :)
- html/DataGridColumn.cpp: (WebCore::DataGridColumn::columnChanged):
- html/DataGridColumn.h: (WebCore::DataGridColumn::setId): (WebCore::DataGridColumn::setLabel): (WebCore::DataGridColumn::setType): (WebCore::DataGridColumn::setSortable): (WebCore::DataGridColumn::setSortDirection): (WebCore::DataGridColumn::setColumnList): (WebCore::DataGridColumn::style): (WebCore::DataGridColumn::setStyle): (WebCore::DataGridColumn::rect): (WebCore::DataGridColumn::setRect):
- html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::DataGridColumnList): (WebCore::DataGridColumnList::setDataGridNeedsLayout): (WebCore::DataGridColumnList::add): (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move): (WebCore::DataGridColumnList::clear): (WebCore::DataGridColumnList::primaryColumnChanged):
- html/DataGridColumnList.h: (WebCore::DataGridColumnList::create): (WebCore::DataGridColumnList::dataGrid): (WebCore::DataGridColumnList::clearDataGrid):
- html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::findDataGridAncestor): (WebCore::HTMLDataGridColElement::insertedIntoTree): (WebCore::HTMLDataGridColElement::removedFromTree):
- html/HTMLDataGridColElement.h: (WebCore::HTMLDataGridColElement::dataGrid):
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::~HTMLDataGridElement):
- rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::styleDidChange): (WebCore::RenderDataGrid::recalcStyleForColumns): (WebCore::RenderDataGrid::recalcStyleForColumn): (WebCore::RenderDataGrid::styleForColumn): (WebCore::RenderDataGrid::layout): (WebCore::RenderDataGrid::layoutColumns): (WebCore::RenderDataGrid::paintColumnHeaders): (WebCore::RenderDataGrid::paintColumnHeader):
- rendering/RenderDataGrid.h: (WebCore::RenderDataGrid::renderName): (WebCore::RenderDataGrid::canHaveChildren):
- 1:41 PM JSC created by
- Initial entry to document the utility.
- 1:38 PM Changeset in webkit [45445] by
-
- 2 edits in trunk/WebCore
2009-07-01 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fixes this address by checking whether frame->document()->decoder() is null.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):
- 12:01 PM Changeset in webkit [45444] by
-
- 4 edits12 adds in trunk
2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
Correctly reset history length to '0', not '1'. Old relict from early WML days.
Add some new WML testcases covering the use of history length (by onenterforward event handling)
Tests: wml/onenterforward-event.html
wml/onenterforward-inline-event.html
wml/ontimer-event.html
- wml/WMLPageState.cpp: (WebCore::WMLPageState::reset):
2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
Add new WML testcases covering onenterforward/ontimer support.
- wml/onenterforward-event-expected.txt: Added.
- wml/onenterforward-event.html: Added.
- wml/onenterforward-inline-event-expected.txt: Added.
- wml/onenterforward-inline-event.html: Added.
- wml/ontimer-event-expected.txt: Added.
- wml/ontimer-event.html: Added.
- wml/resources/onenterforward-event.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- wml/resources/onenterforward-event.wml: Added.
- wml/resources/onenterforward-inline-event.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- wml/resources/onenterforward-inline-event.wml: Added.
- wml/resources/ontimer-event.js: Added. (setupTestDocument): (prepareTest): (executeTest):
- wml/resources/ontimer-event.wml: Added.
- wml/resources/ontimer-inline-event.js:
- 11:41 AM Changeset in webkit [45443] by
-
- 4 edits2 adds in trunk
WebCore:
2009-07-01 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Make sure setting attributes on dcol elements properly updates the corresponding DataGridColumn object.
Added new test in fast/dom/HTMLDataGridElement.
- html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::parseMappedAttribute):
- html/HTMLDataGridColElement.h:
LayoutTests:
2009-07-01 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Add layout test for being able to set attributes on dcol elements.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes-expected.txt: Added.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Added.
- 11:19 AM Changeset in webkit [45442] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-07-01 Simon Fraser <Simon Fraser>
Reviewed by Dimitri Glazkov.
Add some missing pixel results for compositing tests.
- platform/mac/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
- platform/mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
- platform/mac/compositing/overflow/overflow-scroll-expected.checksum: Added.
- platform/mac/compositing/overflow/overflow-scroll-expected.png: Added.
- 11:12 AM Changeset in webkit [45441] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-07-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Converted op_mod to put { tag, payload } in { regT1, regT0 }, and
tidied up its constant case.
SunSpider reports a 0.2% regression, but a micro-benchmark of op_mod
shows a 12% speedup, and the SunSpider test that uses op_mod most should
benefit a lot from result caching in the end, since it almost always
performs (expression) % constant.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
- 11:11 AM Drosera edited by
- Add link to Web Inspector page. (diff)
- 9:53 AM Changeset in webkit [45440] by
-
- 9 edits in trunk
WebCore:
2009-07-01 David Hyatt <hyatt@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
even though the field is not actually focused for keyboard input
Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
focused frame and focused node to both be cached and changed programmatically even when the Page itself doesn't
actually happen to have focus at that time.
- WebCore.base.exp:
- page/FocusController.cpp: (WebCore::FocusController::FocusController): (WebCore::FocusController::setFocusedFrame): (WebCore::FocusController::setFocused): (WebCore::FocusController::setActive):
- page/FocusController.h: (WebCore::FocusController::isFocused):
WebKit/mac:
2009-07-01 David Hyatt <hyatt@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
even though the field is not actually focused for keyboard input
Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
have focus.
- WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): (-[WebHTMLView resignFirstResponder]):
WebKit/win:
2009-07-01 David Hyatt <hyatt@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
even though the field is not actually focused for keyboard input
Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
have focus.
- WebView.cpp: (WebViewWndProc):
- 9:47 AM Changeset in webkit [45439] by
-
- 2 edits in trunk/LayoutTests
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26884
WMLTestCase.js relies on timing-dependant hacks, making it difficult to predict results on slower machines.
Fix by rewriting and simplifying the testing procedure, which contained unnecessary quirks working around older WML bugs.
- 9:06 AM Changeset in webkit [45438] by
-
- 4 edits in trunk/WebKitLibraries
2009-07-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Update WebKitSystemInterface for <rdar://problem/7014990>
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 8:44 AM Changeset in webkit [45437] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules
Not reviewed. Ignore *.pyc files to not clutter up 'svn st'.
- 8:10 AM Changeset in webkit [45436] by
-
- 6 edits in trunk/LayoutTests
Reviewed by Holger Freyther.
Apply same cleanup to WML testcases living in http/tests/wml/. Forgot about them in my last commit.
- 8:03 AM Changeset in webkit [45435] by
-
- 7 edits in trunk/LayoutTests
Reviewed by Holger Freyther.
Slightly cleanup some WML testcases:
Use "anchorElement.textContent = '...'" instead of "anchorElement.appendChild(document.createTextNode('...'))"
- 5:55 AM Changeset in webkit [45434] by
-
- 4 edits in trunk
WebCore:
2009-07-01 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Move some API headers from WebCore.pro to headers.pri so that they
get installed when running make install from the build directory.
- WebCore.pro:
WebKit/qt:
2009-07-01 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Move some API headers from WebCore.pro to headers.pri so that they
get installed when running make install from the build directory.
- Api/headers.pri:
- 4:36 AM Changeset in webkit [45433] by
-
- 2 edits in trunk/WebKit/qt
2009-07-01 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Fixed robotized QtLauncher to work when there is no index.html in the user's home.
- QtLauncher/main.cpp: (main):
- 2:40 AM Changeset in webkit [45432] by
-
- 2 edits in trunk/WebCore
2009-07-01 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Ariya Hidayat.
Ran WebKitTools/Scripts/generate-qt-inspector-resource to update the
qrc file with new png files from the web inspector.
- inspector/front-end/WebKit.qrc:
Jun 30, 2009:
- 11:51 PM Changeset in webkit [45431] by
-
- 2 edits in trunk/WebKitTools
2009-06-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26877
[GTK] DRT fixes to pass new plugin test
Silence compiler warnings.
Newer GCC don't like using or returning a static string where a
'char*' is expected. Ideally we'd change the function signatures
to return or take 'const char*' I suppose, but since we can't do
that just cast the strings to 'char*'.
- DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_get_value):
- 11:42 PM Changeset in webkit [45430] by
-
- 2 edits in trunk/WebKitTools
2009-06-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26877
[GTK] DRT fixes to pass new plugin test
Use the common pluginLog function instead of a local copy.
- DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_destroy_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
- 11:41 PM Changeset in webkit [45429] by
-
- 2 edits in trunk/WebKitTools
2009-06-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26877
[GTK] DRT fixes to pass new plugin test
Modify our DRT as done in bug #15457 to log logSrc as src in order
to pass test plugins/netscape-plugin-map-data-to-src.html.
- DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance):
- 11:10 PM Changeset in webkit [45428] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-30 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Converted some more arithmetic ops to put { tag, payload } in
{ regT1, regT0 }.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
- 11:07 PM Changeset in webkit [45427] by
-
- 2 edits in trunk/WebKit/mac
2009-06-30 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/7014389> REGRESSION(4-TOT): Hyperlinks have no tooltips in Mail unless you first click in the message body
Updated these new methods (added as part of the viewless WebKit effort) that call through to WebHTMLView to use _selectedOrMainFrame,
instead of just selectedFrame. When the selection changes, I don't think there is a situation where there's no selected frame, but
it seems better to keep these two uses the same, since if there is a case, this will be more like the old behavior, before there was
a version of _selectionChanged in WebView.
- WebView/WebView.mm: (-[WebView _setToolTip:]): (-[WebView _selectionChanged]):
- 10:58 PM Changeset in webkit [45426] by
-
- 2 edits in trunk/LayoutTests
2009-06-30 Xan Lopez <xlopez@igalia.com>
Disable test using eventSender.
- platform/gtk/Skipped:
- 10:44 PM Changeset in webkit [45425] by
-
- 2 edits in trunk/LayoutTests
2009-06-30 Xan Lopez <xlopez@igalia.com>
Disable new tests until we enable the accessibility controller.
- platform/gtk/Skipped:
- 10:28 PM Changeset in webkit [45424] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Converted some more arithmetic ops to put { tag, payload } in
{ regT1, regT0 }, and added a case for subtract constant.
SunSpider says no change. v8 says 0.3% slower.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSub32Constant): (JSC::JIT::emitSlow_op_sub):
- 10:19 PM Changeset in webkit [45423] by
-
- 2 edits in trunk/WebCore
Land some code that has a hope of compiling.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::imageSourceOptions):
- 9:55 PM Changeset in webkit [45422] by
-
- 5 edits in branches/nitro-extreme/JavaScriptCore
2009-06-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove more uses of addressFor(), load double constants directly from
the constantpool in the CodeBlock, rather than from the register file.
- jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp):
- 9:37 PM Changeset in webkit [45421] by
-
- 2 edits in trunk/WebCore
2009-06-30 Stephanie Lewis <Stephanie Lewis>
Reviewed by Simon Fraser.
Flip back on block caching. Throwing away block data, while
a perceived memory win, is a performance hit in cases where we
are repainting large images (i.e. backgrounds) frequently
(i.e. a flash video playing on top).
<rdar://problem/6933515> REGRESSION(L-SL): Large JPEG images are
decoded on drawing, slowing down painting of sites that frequently
repaint e.g. because of Flash (pandora.com, Starcraft 2)
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::imageSourceOptions):
- 8:50 PM Changeset in webkit [45420] by
-
- 5 edits in branches/nitro-extreme
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a bug in postfix ops, where we would treat x = x++ and x = x--
as a no-op, even if x were not an int, and the ++/-- could have side-effects.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec):
LayoutTests:
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added a test for x=x++ and x=x-- where the ++ / -- have side-effects.
- fast/js/postfix-syntax-expected.txt:
- fast/js/resources/postfix-syntax.js: (o.valueOf):
- 8:24 PM Changeset in webkit [45419] by
-
- 11 edits1 move in trunk/WebCore
2009-06-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
- Rename html4.css to html.css, since we target HTML5 now https://bugs.webkit.org/show_bug.cgi?id=26873
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleSelector.cpp: (WebCore::loadFullDefaultStyle):
- css/html.css: Copied from css/html4.css.
- css/html4.css: Removed.
- css/themeWin.css:
- platform/Theme.h:
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
- rendering/RenderTheme.h:
- 7:53 PM Changeset in webkit [45418] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Fix ChangeLog of r45415
- 7:40 PM Changeset in webkit [45417] by
-
- 1 edit in branches/nitro-extreme/JavaScriptCore/ChangeLog
Fixed a ChangeLog merge fail.
- 7:40 PM Changeset in webkit [45416] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-06-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Start removing cases of addressFor().
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div):
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble): (JSC::JIT::emitStoreDouble):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
- 7:27 PM Changeset in webkit [45415] by
-
- 2 edits in trunk/WebKitTools
2009-06-30 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Jan Alonzo.
[GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation()
https://bugs.webkit.org/show_bug.cgi?id=26835
- GtkLauncher/main.c: (create_toolbar):
- 7:16 PM Changeset in webkit [45414] by
-
- 3 edits in trunk/WebCore
2009-06-30 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642
Define DragImageRef as GdkPixbuf and implement essential
functions which manipulate drag images.
- platform/DragImage.h:
- platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::createDragImageFromImage):
- 7:15 PM Changeset in webkit [45413] by
-
- 2 edits in trunk/WebCore
2009-06-30 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
StorageNamespace.cpp build issue
https://bugs.webkit.org/show_bug.cgi?id=26859
Moved #endif ENABLE(DOM_STORAGE) position
so that the build doesn't fail.
The namespace WebCore was started after the #if ENABLE(DOM_STORAGE)
but closed after the #endif.
- storage/StorageNamespace.cpp:
- 6:01 PM Changeset in webkit [45412] by
-
- 5 edits in branches/nitro-extreme/JavaScriptCore
2009-06-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Start removing cases of addressFor().
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div):
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble): (JSC::JIT::emitStoreDouble):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
- 5:40 PM Changeset in webkit [45411] by
-
- 13 edits in trunk/LayoutTests
2009-06-30 Simon Fraser <Simon Fraser>
Rubber-stamped by Dan Bernstein.
Update compositing pixel results now that DRT dumps them correctly.
- compositing/overflow/overflow-scroll.html: Fixed typo in this testcase.
- platform/mac/compositing/overflow/ancestor-overflow-expected.checksum:
- platform/mac/compositing/overflow/ancestor-overflow-expected.png:
- platform/mac/compositing/overflow/overflow-positioning-expected.checksum:
- platform/mac/compositing/overflow/overflow-positioning-expected.png:
- platform/mac/compositing/overflow/overflow-scroll-expected.txt:
- platform/mac/compositing/overflow/parent-overflow-expected.checksum:
- platform/mac/compositing/overflow/parent-overflow-expected.png:
- platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
- platform/mac/compositing/repaint/content-into-overflow-expected.png:
- platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
- platform/mac/compositing/repaint/overflow-into-content-expected.png:
- 5:40 PM Changeset in webkit [45410] by
-
- 2 edits in trunk/WebKitTools
2009-06-30 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Fix drawing of view background in pixel snapshots when using compositing.
We still need to call -displayIfNeeded to ensure that the NSView drawing
has happened.
- DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
- 4:29 PM Changeset in webkit [45409] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Rolled back in my last patch with regression fixed.
- jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
- 4:09 PM Changeset in webkit [45408] by
-
- 2 edits in trunk/LayoutTests
2009-06-30 Eric Seidel <eric@webkit.org>
No review, reverting r45396. (George Staikos agrees the change was wrong.)
http://trac.webkit.org/changeset/45396
- fast/css/getComputedStyle/computed-style-font-family-expected.txt:
- 4:01 PM Changeset in webkit [45407] by
-
- 3 edits in trunk/WebCore
2009-06-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/7020825> HTMLMediaElement should not assume seeking is only possible in
buffered time ranges
- html/HTMLMediaElement.cpp:
Don't ASSERT if the network state goes to Idle when when the ready state is
HaveEnoughData or higher, it is perfectly legal.
(WebCore::HTMLMediaElement::setReadyState):
Don't clear m_seeking after posting a 'seeking' event.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::seek):
Do nothing when asked to seek to the same time we are already seeking to. Check requested
seek time against maxTimeSeekable, not maxTimeLoaded.
(WebCore::MediaPlayerPrivate::doSeek):
Don't bother stopping a movie that isn't playing. Minor cleanup to make the code more readable.
(WebCore::MediaPlayerPrivate::seekTimerFired):
Check requested seek time against maxTimeSeekable, not maxTimeLoaded.
(WebCore::MediaPlayerPrivate::updateStates):
A streaming movie has as much data as it needs once it reaches "playable", so
set the ready state to HaveFutureData. A movie with metadata doesn't drop back
to "have nothing" when seeking. A streaming movie doesn't use the network when paused.
(WebCore::MediaPlayerPrivate::timeChanged):
It may not be possible to seek to a specific time in a streamed movie but when seeking
in a streaming movie QuickTime sets the time to closest time possible and posts a
timechanged notification, so update m_seekTo so we can detect when the seek completes.
- 3:43 PM Changeset in webkit [45406] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Rolled out my last patch because it was a 2% SunSpider regression.
- jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
- 3:43 PM Changeset in webkit [45405] by
-
- 2 edits in trunk/WebKitTools
2009-06-30 Eric Seidel <eric@webkit.org>
Typo fix only, no review.
Fix typo causing failure during land-diff
- Scripts/bugzilla-tool:
- 3:27 PM Changeset in webkit [45404] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin "Sam Weinig" Barraclough.
Standardized the rest of our opcodes to put { tag, payload } in
{ regT1, regT0 } where possible.
- jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
- 3:06 PM Changeset in webkit [45403] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
Blacklist Yahoo Application State plug-in for versions prior to 1.0.0.6.
Earlier versions cause corruption crashes.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted):
- 2:57 PM Changeset in webkit [45402] by
-
- 9 edits in trunk/WebCore
2009-06-30 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7005207> <video> in canvas broken with ACCEL_COMPOSITING
Fix drawImage of video in CanvasRenderingContext2D when
accelerated compositing is enabled. This is done by
adding a new paint method to HTMLVideoElement that
is only called from canvas, which will create the software
renderer if necessary, but otherwise calls the regular
paint method. Meanwhile, add logic to the software video
renderer so that it can be created without calling repaint
every time it sees a new frame.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::paintCurrentFrameInContext):
- html/HTMLVideoElement.h:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::paintCurrentFrameInContext):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::paintCurrentFrameInContext):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): (WebCore::MediaPlayerPrivate::createQTVideoRenderer): (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering): (WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
- 2:47 PM Changeset in webkit [45401] by
-
- 2 edits in trunk/WebKitTools
2009-06-30 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD,
and thus failed on SnowLeopard.
- DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
- 2:39 PM Changeset in webkit [45400] by
-
- 7 edits in branches/nitro-extreme/JavaScriptCore
2009-06-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen.
Replace calls to store32(tagFor()) and store32(payloadFor())
with emitStoreInt32(), emitStoreBool(), and emitStoreCell().
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emit_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emit_op_bitor): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emitBitXor32Constant): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emit_op_div): (JSC::JIT::emit_op_mod):
- jit/JITCall.cpp: (JSC::JIT::emit_op_load_varargs):
- jit/JITInlineMethods.h: (JSC::JIT::emitStoreInt32): (JSC::JIT::emitStoreCell): (JSC::JIT::emitStoreBool): (JSC::JIT::emitStore):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::compileOpStrictEq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
- jit/JITStubCall.h: (JSC::JITStubCall::call):
- 2:38 PM Changeset in webkit [45399] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove conflict markers from ChangeLog.
- 2:37 PM Changeset in webkit [45398] by
-
- 2 edits in trunk/WebKitTools
2009-06-30 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD,
and thus failed on SnowLeopard.
- DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
- 2:37 PM Changeset in webkit [45397] by
-
- 8 edits2 adds in trunk
WebCore:
<<<<<<< .mine
LayoutTests:
2009-06-30 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
Add layout test for https://bugs.webkit.org/show_bug.cgi?id=26858.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt: Added.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom.html: Added.
- 2:27 PM Changeset in webkit [45396] by
-
- 2 edits in trunk/LayoutTests
2009-06-30 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
Updated LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
according to the default font size value set in WebKit/qt/Api/qwebsettings.cpp (in
this case '14').
- fast/css/getComputedStyle/computed-style-font-family-expected.txt:
- 2:27 PM Changeset in webkit [45395] by
-
- 2 edits in trunk/LayoutTests
2009-06-30 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
Updated LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
to some newly cross-platform CSS properties.
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 2:07 PM Changeset in webkit [45394] by
-
- 3 edits in trunk/WebCore
2009-06-30 Jeremy Orlow (jorlow@chromium.org)
Reviewed by David Levin.
Fix some minor build issues in the v8 bindings.
- bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Custom::v8StorageNamedPropertyEnumerator): (WebCore::storageGetter): (WebCore::storageSetter): (WebCore::storageDeleter):
- storage/StorageArea.cpp:
- 1:16 PM Changeset in webkit [45393] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 1:16 PM Changeset in webkit [45392] by
-
- 1 copy in tags/Safari-6530.19.2
New tag.
- 1:10 PM Changeset in webkit [45391] by
-
- 3 edits in trunk/WebCore
2009-06-30 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium Linux: use different fonts for each script run.
Previously, when rendering complex text, we picked a single font which
could render all the glyphs needed for the run. However, this meant
that sometimes lines were rendered with, for example, [LATIN, THAI,
LATIN] and we could end up with a different font for the Latin parts
than for lines without Thai in them.
With this patch, we pick a font for each script run.
This change is covered by existing layout tests.
- 1:02 PM Changeset in webkit [45390] by
-
- 1 edit in branches/WWDC-2009-branch/WebKit/mac/ChangeLog
Fix up the ChangeLog.
- 1:02 PM Changeset in webkit [45389] by
-
- 2 edits in trunk/LayoutTests
2009-06-30 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
Make media/video-document-types pass again. It broke when the
call to waitUntilDone was accidently made asynchronous in r45378.
- media/video-document-types.html:
- 12:57 PM Changeset in webkit [45388] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r45386.
- 12:53 PM Changeset in webkit [45387] by
-
- 9 edits2 adds in trunk
2009-06-30 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt, Dan Bernstein.
<rdar://problem/6191676> Redraw issues scrolling overflow:scroll div with compositing
There are two parts to this fix. First, if a compositing layer has overflow clipping
or a mask, then the compositing layer does not need to be sized to encompass all
non-composited children.
Second, when scrolling, we have to back up to the compositing ancestor and have
it reposition descendant compositing layers, because overflow doesn't follow
the z-order tree.
Test: compositing/overflow/overflow-scroll.html
- page/FrameView.cpp: (WebCore::FrameView::layout): Pass the UpdateCompositingLayers flag when updating layers after layout, so that we can reposition compositing layers if we're not about to do a layer rebuild.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): Only update compositing layers if the flag is set.
(WebCore::RenderLayer::scrollToOffset):
Do compositing layer updates from the compositing ancestor in one fell swoop.
- rendering/RenderLayer.h: Replace the unused FullUpdate flag with one that allows us to specify whether compositing layers should be updated.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
- rendering/RenderLayerBacking.h: New param that we can pass to updateCompositingDescendantGeometry to control whether the update goes deep.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): We can return earlier if this is not a self-painting layer. If the layer has overflow clip or a mask, then the composited bounds are just the local bounds, excluding descendants.
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
- rendering/RenderLayerCompositor.h: Renamed from updateCompositingChildrenGeometry, and added a flag that allows us to do a deep update.
- 12:52 PM Changeset in webkit [45386] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7006959> 'Save as…’ does not work in Mail
Reviewed by Timothy Hatcher.
- WebView/WebFrameView.mm:
(-[WebFrameView initWithFrame:]): Call _needMailThreadWorkaroundIfCalledOffMainThread rather than
needMailThreadWorkaround, as the latter is intended to be used at the point which a workaround would
be applied and thus contains a main thread check. Since -initWithFrame: is called on the main thread,
this was causing us to not switch from exception-throwing to logging for the thread violation behavior.
- 11:27 AM Changeset in webkit [45385] by
-
- 3 edits2 adds in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=26764
Uncaught NOT_FOUND_ERR: DOMException 8 loading empty text file
Test: fast/parser/empty-text-resource.html
- loader/TextDocument.cpp: (WebCore::TextTokenizer::finish): Create document tree if it hasn't been created yet.
- 11:23 AM Changeset in webkit [45384] by
-
- 7 edits in trunk
2009-06-30 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Renamed scrollbarUnderPoint to scrollbarAtPoint.
- page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent):
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarAtPoint):
- platform/ScrollView.h:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleMouseDownEvent): (WebCore::PopupListBox::handleMouseMoveEvent):
2009-06-30 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Renamed scrollbarUnderPoint to scrollbarAtPoint to follow conventions.
- Api/qwebpage.cpp: (QWebPage::swallowContextMenuEvent):
- 11:05 AM Changeset in webkit [45383] by
-
- 3 edits in trunk/WebCore
<rdar://problem/6960286> CrashTracer: [REGRESSION] 1120 crashes in Safari at com.apple.WebCore • WebCore::JSLazyEventListener::parseCode const + 62
Reviewed by Geoff Garen
<select> elements and other elements the produce popups can keep their popups
live across a page load. If this occurs and the <select> element has an
onchange handler it is possible to get into a state where we try to execute
JS on a page that no longer has an execution context.
- 10:42 AM Changeset in webkit [45382] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized the rest of the property access instructions to put { tag,
payload } in { regT1, regT0 }.
Small v8 speedup, 0.2% SunSpider slowdown.
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::emitLoad): (JSC::JIT::emitLoad2):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::patchPutByIdReplace):
- 10:32 AM Changeset in webkit [45381] by
-
- 17 edits8 adds in trunk
WebCore:
2009-06-30 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Added support for sending MessagePorts to/from Workers via postMessage().
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::messageChannel): Exposes MessageChannel constructor WorkerContext.
- bindings/js/JSWorkerCustom.cpp:
- bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Now correctly handles being instantiated from within a Worker.
- platform/CrossThreadCopier.h: (WebCore::GenericWorkerTaskTraits<PassOwnPtr>): Added support for passing PassOwnPtr as argument to GenericWorkerTask
- workers/GenericWorkerTask.h:
(WebCore::):
- workers/Worker.cpp: (WebCore::Worker::postMessage): Now handles disentangling/entangling MessagePorts sent to/from via postMessage. (WebCore::Worker::dispatchMessage):
- workers/Worker.h:
- workers/Worker.idl: Added an optional MessagePort argument to postMessage()
- workers/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): Workers now report pending activity whenever there are remotely entangled ports. (WebCore::WorkerContext::postMessage): Now handles disentangling/entangling MessagePorts sent to/from via postMessage. (WebCore::WorkerContext::dispatchMessage):
- workers/WorkerContext.h:
- workers/WorkerContext.idl: Added an optional MessagePort argument to postMessage()
- workers/WorkerContextProxy.h:
- workers/WorkerMessagingProxy.cpp: Updated messaging infrastructure to transport an optional MessagePort/MessagePortChannel. (WebCore::MessageWorkerContextTask::create): (WebCore::MessageWorkerContextTask::MessageWorkerContextTask): (WebCore::MessageWorkerContextTask::performTask): (WebCore::MessageWorkerTask::create): (WebCore::MessageWorkerTask::MessageWorkerTask): (WebCore::MessageWorkerTask::performTask): (WebCore::WorkerMessagingProxy::postMessageToWorkerObject): (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
- workers/WorkerMessagingProxy.h: Added additional postMessage() API that accepts a MessagePort
- workers/WorkerObjectProxy.h: Added additional postMessage() API that accepts a MessagePort
LayoutTests:
2009-06-30 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Added tests for sending MessagePorts to/from workers.
- fast/workers/resources/worker-cloneport.js: Added. (onmessage):
- fast/workers/resources/worker-messageport.js: Added. (onmessage): (pingBack):
- fast/workers/worker-cloneport-expected.txt: Added.
- fast/workers/worker-cloneport.html-disabled: Added. Tests for cloning a port while messages are sent from another thread.
- fast/workers/worker-messageport-expected.txt: Added.
- fast/workers/worker-messageport.html-disabled: Added. General tests for sending messages to workers via message ports.
- fast/workers/worker-messageport-gc-expected.txt: Added.
- fast/workers/worker-messageport-gc.html-disabled: Added. Tests to ensure Workers don't shut down when reachable only via MessagePorts.
- 10:07 AM Changeset in webkit [45380] by
-
- 6 edits3 adds in trunk/WebKit/qt
2009-06-30 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Adam Treat.
Bug 26422: [Qt] QWebPagePrivate::frameAt calculates wrong frame
Added a public method QWebPage::frameAt
Removed QWebPagePrivate::frameAt, which calcuated the wrong frame
Modified QWebPage::swallowContextMenuEvent to use the new frameAt method
New test case for frameAt added to tst_qwebpage.cpp
- 9:57 AM Changeset in webkit [45379] by
-
- 2 edits1 add in trunk/WebCore
2009-06-30 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium: Add complex text support on Linux.
This patch adds complex text support on Linux using Harfbuzz. It's not
the fastest code possible: some caching of font tables will certainly
be required. However, it's probably the simplest code that works.
This will require checking in new baselines in the Chromium tree for
those layout tests which now pass.
- 9:30 AM Changeset in webkit [45378] by
-
- 4 edits in trunk
2009-06-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7019799> Slow loading MediaDocument can fall back to plug-in unnecessarily
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):
Always fall back to a plug-in if m_hasUnsupportedTracks is set.
(WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
Set m_hasUnsupportedTracks if we disable a track.
2009-06-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7019799> Slow loading MediaDocument can fall back to plug-in unnecessarily
Don't test iframe immediately, switch over from <video> to <embed> may not have
happend when the document 'load' event fires.
- media/video-document-types.html:
- 9:25 AM Changeset in webkit [45377] by
-
- 2 edits in trunk/WebCore
2009-06-30 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Fix inverted if/else that's causing a layout test in src.chromium.org to fail.
- 8:49 AM Changeset in webkit [45376] by
-
- 8 edits in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6946611> REGRESSION (r30673): Shade10:" D_Snap to Grid" window is clipping
Added an app-specific quirk to revert the behavior of <link> elements
to the way it was before r30673, namely that if the rel attribute
is not "stylesheet" but the type attribute contains "text/css", the
link behaves as a stylesheet link.
- WebCore.base.exp: Exported setTreatsAnyTextCSSLinkAsStylesheet().
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): Check
Settings::treatsAnyTextCSSLinkAsStylesheet() and if true, allow a
style sheet link if the type contains "text/css".
- page/Settings.cpp: (WebCore::Settings::Settings):
Initialize m_treatsAnyTextCSSLinkAsStylesheet.
(WebCore::Settings::setTreatsAnyTextCSSLinkAsStylesheet): Added.
- page/Settings.h: (WebCore::Settings::treatsAnyTextCSSLinkAsStylesheet): Added.
WebKit/mac:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6946611> REGRESSION (r30673): Shade10:" D_Snap to Grid" window is clipping
- Misc/WebKitVersionChecks.h: Added
WEBKIT_FIRST_VERSION_WITHOUT_SHADE10_QUIRK
- WebView/WebView.mm: (-[WebView _needsLinkElementTextCSSQuirk]): Added. Returns YES if the
client app is a version of Shade 10 earlier than 10.6 and it was
linked against a version of WebKit earlier than 531.2.
(-[WebView _preferencesChangedNotification:]): Added a call to
Settings::setTreatsAnyTextCSSLinkAsStylesheet().
- 7:14 AM Changeset in webkit [45375] by
-
- 4 edits in trunk/WebKit/qt
2009-06-30 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Add QWebFrame::baseUrl() function that exposes the base URL of a frame.
Autotests included.
- Api/qwebframe.cpp: (QWebFrame::baseUrl):
- Api/qwebframe.h:
- tests/qwebframe/tst_qwebframe.cpp:
- 7:05 AM Changeset in webkit [45374] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Override operator new/delete with const std::nothrow_t& as the second
argument.
- 6:54 AM QtWebKitContrib edited by
- (diff)
- 6:51 AM QtWebKitContrib edited by
- (diff)
- 5:15 AM Changeset in webkit [45373] by
-
- 2 edits in trunk/WebCore
2009-06-30 Adrien Nader <camaradetux@gmail.com>
Reviewed by Xan Lopez.
Fix typo in GNUMakefile.am: it reads WebCOre instead of WebCore.
- GNUmakefile.am:
- 5:10 AM Changeset in webkit [45372] by
-
- 2 edits in trunk/WebCore
2009-06-30 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Turn on ENABLE_DATAGRID so we can run the layout tests.
- GNUmakefile.am:
- 3:55 AM Changeset in webkit [45371] by
-
- 2 edits in trunk/LayoutTests
2009-06-30 Xan Lopez <xlopez@igalia.com>
Skip new editing tests.
They are failing because we don't have a dumpEditingCallbacks
implementation.
- platform/gtk/Skipped:
- 2:55 AM Changeset in webkit [45370] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-30 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Sam Weinig.
Remove unnecessary references to AssemblerBuffer.
- interpreter/Interpreter.cpp:
- interpreter/Interpreter.h:
- 2:33 AM Changeset in webkit [45369] by
-
- 3 edits1 add in trunk/WebKitTools
2009-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
Include a built copy of BeautifulSoup 3.1.0.1 so that
bugzilla-tool users do not need to install it manually.
https://bugs.webkit.org/show_bug.cgi?id=26833
BeautifulSoup is BSD-licensed (thus WebKit compatible) and available from:
http://www.crummy.com/software/BeautifulSoup
- Scripts/bugzilla-tool: fixed a typo in a log message.
- Scripts/modules/BeautifulSoup.py: Added.
- Scripts/modules/bugzilla.py:
- 2:03 AM Changeset in webkit [45368] by
-
- 3 edits in trunk/WebKitTools
2009-06-30 Eric Seidel <eric@webkit.org>
Reviewed by Simon Hausmann.
Fix our create_patch handling to not
hang when creating large patches.
https://bugs.webkit.org/show_bug.cgi?id=26834
We're now using StringIO to make an in-memory buffer for the patch
instead of piping from the patch command directly to the upload.
The previous hang was caused by calling wait() when the process had already
filed the stdout buffer.
- Scripts/modules/scm.py:
- 12:52 AM Changeset in webkit [45367] by
-
- 2 edits in trunk/WebCore
2009-06-30 Raju Kunnath <raju.kunnath@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Windows release build issue with Qt4.5 due to -GL flag on msvc2005 and msvc2008.
- WebCore.pro: Removed -GL compiler option for win32-msvc2005|win32-msvc2008.
- 12:48 AM Changeset in webkit [45366] by
-
- 2 edits in trunk/WebCore
2009-06-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Initialize member variables in the right order. Fixes compiler
warning.
- platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader):
- 12:24 AM Changeset in webkit [45365] by
-
- 2 edits in trunk/WebCore
2009-06-29 Xan Lopez <xlopez@igalia.com>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26831
Fix compiler warning in WorkerLoaderProxy.h
Forward declaration of a class within a class is not allowed,
since the compiler can't know if the declaration is legal at that
point. This gives the following compiler warning:
../../WebCore/workers/WorkerLoaderProxy.h:40: warning: declaration
"class WebCore::ScriptExecutionContext::Task" does not declare
anything
Include the full ScriptExecutionHeader header instead.
- workers/WorkerLoaderProxy.h:
Jun 29, 2009:
- 11:43 PM Changeset in webkit [45364] by
-
- 3 edits in trunk/WebKit/gtk
2009-06-29 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Fix a couple of compiler warnings.
- webkit/webkitwebnavigationaction.cpp:
- webkit/webkitwebview.cpp: (webkit_web_view_real_move_cursor):
- 10:56 PM Changeset in webkit [45363] by
-
- 2 edits in trunk/WebCore
2009-06-29 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Remove unused function.
- plugins/gtk/PluginPackageGtk.cpp:
- 10:12 PM Changeset in webkit [45362] by
-
- 4 edits in trunk/WebCore
2009-06-29 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Change RenderLayer::updateLayerPositions() to use a bitmask instead of two
boolean arguments. FullUpdate is unused at present, but will be used soon.
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset):
- rendering/RenderLayer.h: (WebCore::RenderLayer::):
- 8:08 PM Changeset in webkit [45361] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Various cleanups.
- Use fpRegT* instead of X86::xmm*.
- Use a switch statement in emitBinaryDoubleOp instead of a bunch of if/elses.
- jit/JITArithmetic.cpp: (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div):
- 5:09 PM Changeset in webkit [45360] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-29 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
Still seeing occasional leaks from UString::sharedBuffer code
https://bugs.webkit.org/show_bug.cgi?id=26420
The problem is that the pointer to the memory allocation isn't visible
by "leaks" due to the lower bits being used as flags. The fix is to
make the pointer visible in memory (in debug only). The downside of
this fix that the memory allocated by sharedBuffer will still look like
a leak in non-debug builds when any flags are set.
- wtf/PtrAndFlags.h: (WTF::PtrAndFlags::set):
- 4:44 PM Changeset in webkit [45359] by
-
- 2 edits in trunk/WebCore
2009-06-29 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Fix one more bad merge in V8Proxy.
- 4:21 PM Changeset in webkit [45358] by
-
- 2 edits in trunk/WebKit/win
2009-06-29 David Hyatt <hyatt@apple.com>
Fix Windows bustage. Missed two configurations for enabling DATAGRID.
- WebKit.vcproj/WebKit.vcproj:
- 3:35 PM Changeset in webkit [45357] by
-
- 6 edits2 deletes in trunk
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove more unused scons support.
- SConstruct: Removed.
WebCore:
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove more unused scons support.
- SConstruct: Removed.
WebKitTools:
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove more unused scons support.
- Scripts/build-jsc:
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 3:33 PM Changeset in webkit [45356] by
-
- 5 edits in trunk
<rdar://problem/7016214> JSON.parse fails to parse valid JSON with most Unicode characters
<https://bugs.webkit.org/show_bug.cgi?id=26802>
Reviewed by Gavin Barraclough.
In the original JSON.parse patch unicode was handled correctly, however in some last
minute "clean up" I oversimplified isSafeStringCharacter. This patch corrects this bug.
- 2:38 PM Changeset in webkit [45355] by
-
- 3 edits in trunk/WebCore
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Fix some incorrect create functions.
- html/DataGridColumn.h: (WebCore::DataGridColumn::create):
- html/DataGridColumnList.h: (WebCore::DataGridColumnList::create):
- 2:32 PM Changeset in webkit [45354] by
-
- 2 edits in trunk/LayoutTests
2009-06-29 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
Updated LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-expected.txt to some newly cross-platform CSS properties.
The file has not been updated for a while.
- 2:31 PM Changeset in webkit [45353] by
-
- 15 edits2 adds in trunk
WebCore:
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Remove initialize method from DataGridDataSource and add
DOMDataGridDataSource.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDataGridDataSource.cpp:
- bindings/js/JSDataGridDataSource.h:
- bindings/js/JSHTMLDataGridElementCustom.cpp: (WebCore::JSHTMLDataGridElement::setDataSource):
- html/DOMDataGridDataSource.cpp: Added. (WebCore::DOMDataGridDataSource::DOMDataGridDataSource): (WebCore::DOMDataGridDataSource::~DOMDataGridDataSource):
- html/DOMDataGridDataSource.h: Added. (WebCore::DOMDataGridDataSource::create): (WebCore::DOMDataGridDataSource::isDOMDataGridDataSource): (WebCore::asDOMDataGridDataSource):
- html/DataGridDataSource.h: (WebCore::DataGridDataSource::isDOMDataGridDataSource): (WebCore::DataGridDataSource::isJSDataGridDataSource):
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::setDataSource): (WebCore::HTMLDataGridElement::dataSource):
- html/HTMLDataGridElement.h:
LayoutTests:
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Update for the change in DataGridDataSource API.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt:
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
- 1:58 PM Changeset in webkit [45352] by
-
- 3 edits in trunk/WebCore
2009-06-29 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Fix a couple of bad merge items from my previous V8Proxy patch.
- 1:42 PM Changeset in webkit [45351] by
-
- 2 edits in trunk/WebKitTools
2009-06-26 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
Rename land-and-update to land-diff and make it awesome.
https://bugs.webkit.org/show_bug.cgi?id=26734
Renamed land-and-update to land-diff
Made the BUGID argument optional.
Added optional support for building and testing before landing.
land-diff [options] [BUGID] Lands the current working directory diff and updates the bug if provided.
Options:
-r REVIEWER, --reviewer=REVIEWER
Update ChangeLogs to say Reviewed by REVIEWER.
--no-close Leave bug open after landing.
--no-build Commit without building first, implies --no-test.
--no-test Commit without running run-webkit-tests.
- Scripts/bugzilla-tool:
- 1:41 PM Changeset in webkit [45350] by
-
- 5 edits in trunk
Fixed crash due to dereference of m_toStyle
- 1:36 PM Changeset in webkit [45349] by
-
- 1 edit in trunk/WebCore/plugins/win/PluginMessageThrottlerWin.cpp
build fix. accidental omission of end paren
- 1:22 PM Changeset in webkit [45348] by
-
- 16 edits in trunk
2009-06-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7014813> Ask media engine if a movie is streamed or downloaded.
- WebCore.base.exp:
Export _wkQTMovieGetType
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::hasSingleSecurityOrigin):
Move to keep with other non-callback functions.
(WebCore::MediaPlayer::movieLoadType):
New, returns the movie type.
- platform/graphics/MediaPlayer.h:
Declare MovieLoadType enum and movieLoadType method.
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::movieLoadType):
Default implementation of movieLoadType
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
Don't base m_isStreaming on protocol, there are other types of streaming movies.
(WebCore::MediaPlayerPrivate::maxTimeBuffered):
Don't assume all streams are unbuffered.
(WebCore::MediaPlayerPrivate::updateStates):
Update m_isStreaming once we have metadata.
(WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
Tracks that are disabled to begin with shouldn't be included in m_enabledTrackCount.
(WebCore::MediaPlayerPrivate::movieLoadType):
New, return movie type.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Add wkQTMovieGetType.
2009-06-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7014813> Ask media engine if a movie is streamed or downloaded.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
Add QTMovieGetType.
2009-06-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Update WebKitSystemInterface for <rdar://problem/7014813>
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 1:15 PM Changeset in webkit [45347] by
-
- 2 edits in trunk/WebCore
2009-06-29 Alice Liu <alice.liu@apple.com>
Fixed <rdar://problem/6930280> Reproducible crash at USA Today photo gallery
Reviewed by Anders Carlsson.
No test added because the crash requires a flash plugin
- plugins/win/PluginMessageThrottlerWin.cpp: Rely on the hWnd of the plugin to tell us whether the PluginView has been deleted during execution of its wndProc. (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
- 1:02 PM Changeset in webkit [45346] by
-
- 3 edits in trunk/WebCore
2009-06-29 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26811
[Chromium] Remove a flag and functions used to enable workers in runtime.
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/WorkerContextExecutionProxy.h:
- 1:00 PM Changeset in webkit [45345] by
-
- 5 edits in trunk/WebCore
2009-06-29 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
<rdar://problem/6976712> Text antialiasing problems when rendering into compositing layers.
Improve the appearance of text in compositing layers by making use of
CA's layer geometry flipping, rather that doing it ourselves with a flip
transform. This allows CG to use font autohinting in the layer text.
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setGeometryOrientation): (WebCore::GraphicsLayer::geometryOrientation): New methods to set whether this layer uses flipped geometry.
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setGeometryOrientation): (WebCore::GraphicsLayerCA::geometryOrientation): Subclass in order to call into CA
(WebCore::GraphicsLayerCA::setContentsLayer):
Now that CA is doing the geometry flipping, we no longer need to flip the content
layers for image and video manually
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Turn on flipping on the root layer.
- 12:52 PM Changeset in webkit [45344] by
-
- 3 edits in trunk/LayoutTests
2009-06-29 David Hyatt <hyatt@apple.com>
Reviewed by Mark Rowe.
Update layout tests for addition of HTMLDataGridCellElement constructor.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- 12:36 PM Changeset in webkit [45343] by
-
- 1 edit4 moves in trunk/LayoutTests
Reviewed by Adam Treat.
Rename go-task-animation.* to ontimer-inline-event.* to reflect what it really tests.
- 12:11 PM Changeset in webkit [45342] by
-
- 9 edits7 adds in trunk
Reviewed by Adam Treat.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26246
Implement most WML specific <select> element features.
Add 'iname' / 'ivalue' support and support variable references.
Add two tests covering most select/variable related functionality.
Needs more tests when adding full 'iname' / 'ivalue' support (used in conjuction with onpick).
Tests: http/tests/wml/post-data-to-server.html
wml/select-element-variables.html
- 11:11 AM Changeset in webkit [45341] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add inline code dealing with doubles for op_jfalse and op_jtrue.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::): (JSC::MacroAssemblerX86Common::zeroDouble):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
- 9:34 AM Changeset in webkit [45340] by
-
- 3 edits in trunk/WebKit/win
2009-06-29 Jessie Berlin <jberlin@apple.com>
Fix the windows build.
Reviewed by Adam Roben.
- WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::isSpeaking):
- WebCoreSupport/WebContextMenuClient.h:
- 9:03 AM Changeset in webkit [45339] by
-
- 2 edits in trunk/WebKit/win
2009-06-29 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Make sure to patch all configurations to have datagrid enabled.
- WebKit.vcproj/WebKit.vcproj:
- 8:52 AM Changeset in webkit [45338] by
-
- 35 edits in trunk
WebCore:
2009-06-29 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Put <datagrid> behind an ifdef.
- Configurations/FeatureDefines.xcconfig:
- bindings/js/JSDataGridColumnListCustom.cpp:
- bindings/js/JSDataGridDataSource.cpp:
- bindings/js/JSDataGridDataSource.h:
- bindings/js/JSHTMLDataGridElementCustom.cpp:
- html/DataGridColumn.cpp:
- html/DataGridColumn.h:
- html/DataGridColumn.idl:
- html/DataGridColumnList.cpp:
- html/DataGridColumnList.h:
- html/DataGridColumnList.idl:
- html/DataGridDataSource.h:
- html/HTMLDataGridCellElement.cpp:
- html/HTMLDataGridCellElement.h:
- html/HTMLDataGridCellElement.idl:
- html/HTMLDataGridColElement.cpp:
- html/HTMLDataGridColElement.h:
- html/HTMLDataGridColElement.idl:
- html/HTMLDataGridElement.cpp:
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- html/HTMLDataGridRowElement.cpp:
- html/HTMLDataGridRowElement.h:
- html/HTMLDataGridRowElement.idl:
- html/HTMLTagNames.in:
- page/DOMWindow.idl:
- rendering/RenderDataGrid.cpp:
- rendering/RenderDataGrid.h:
WebKit/mac:
2009-06-29 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Put datagrid behind an #ifdef.
- Configurations/FeatureDefines.xcconfig:
WebKit/win:
2009-06-29 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Put <datagrid> behind an ifdef.
- WebKit.vcproj/WebKit.vcproj:
- 6:57 AM Changeset in webkit [45337] by
-
- 2 edits in trunk/WebCore
2009-06-29 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat and Adam Roben.
Fix compilation with MINGW. Ported MSVC inline assembly to
GNU inline assembly. Also fixed casting errors where gcc
refused to cast a pointer-to-function to a pointer-to-object,
without an intermediate cast to a non-pointer type.
- 2:17 AM Changeset in webkit [45336] by
-
- 3 edits in trunk/WebKit/qt
2009-06-29 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build, add missing isSpeaking() implementation to
ContextMenuClient.
Jun 28, 2009:
- 10:24 PM Changeset in webkit [45335] by
-
- 3 edits in trunk/WebKit/gtk
2009-06-28 Xan Lopez <xlopez@igalia.com>
Fix the GTK+ build.
- WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::isSpeaking):
- WebCoreSupport/ContextMenuClientGtk.h:
- 9:28 PM Changeset in webkit [45334] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-06-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized op_get_by_id to put { tag, payload } in { regT1, regT0 }.
SunSpider and v8 report maybe 0.2%-0.4% regressions, but the optimization
this enables will win much more than that back.
- jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- 8:06 PM Changeset in webkit [45333] by
-
- 7 edits in trunk
WebCore:
2009-06-26 John Sullivan <sullivan@apple.com>
Added Speech submenu to context menu on Mac when there's a non-editable selection
(it was already present when there's an editable selection).
Also added support for disabling "Stop Speaking" when there is no speaking to stop.
Reviewed by Tim Hatcher.
- loader/EmptyClients.h: (WebCore::EmptyContextMenuClient::isSpeaking): implemented this new virtual function to return false
- page/ContextMenuClient.h: declared this new pure virtual function
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): insert Speech item (after a separator) on Mac when there's selected non-editable text (WebCore::ContextMenu::checkOrEnableIfNeeded): enable Stop Speaking item only if the context menu client returns true for isSpeaking()
WebKit/mac:
2009-06-26 John Sullivan <sullivan@apple.com>
Added support for disabling Stop Speaking when there is no speaking to stop.
Also fixed Stop Speaking so that it works (formerly it would throw an exception, and
selecting it from the menu would perform a web search instead (!)).
Reviewed by Tim Hatcher.
- WebCoreSupport/WebContextMenuClient.h: declare isSpeaking()
- WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::isSpeaking): implement by calling through to NSApplication (WebContextMenuClient::stopSpeaking): fixed implementation by correcting the signature of the NSApplication method
- 7:54 PM Changeset in webkit [45332] by
-
- 5 edits in trunk
WebCore:
Reviewed by Simon Fraser.
- fix https://bugs.webkit.org/show_bug.cgi?id=26783 <rdar://problem/7014543> REGRESSION (r45296): Subfolders not displayed in MobileMe iDisk Web App
Test: added a case to fast/dom/Element/scrollWidth.html
Ensure that scroll{Width, Height} is greater or equal to
client{Width, Height}.
- rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
LayoutTests:
Reviewed by Simon Fraser.
- add a test case for https://bugs.webkit.org/show_bug.cgi?id=26783 <rdar://problem/7014543> REGRESSION (r45296): Subfolders not displayed in MobileMe iDisk Web App
- fast/dom/Element/scrollWidth-expected.txt:
- fast/dom/Element/scrollWidth.html:
- 3:06 PM Changeset in webkit [45331] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 10:25 AM Changeset in webkit [45330] by
-
- 5 edits5 adds in trunk
2009-06-27 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel.
Do not make compositing layers for non-self-painting RenderLayers,
since these exist only to push a clip onto the clipping stack. If such
a layer gets compositied for some other reason, it should not paint.
Also ensure that we update composited layer positions correctly
inside overflow:scroll layers. We can't assume that the contents
are child layers, so we have to go up to the compositing ancestor,
and tell it to update all its child layer positions as we do
after layout.
Tests: compositing/layers-inside-overflow-scroll.html
compositing/self-painting-layers.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::needsToBeComposited):
- 5:40 AM Changeset in webkit [45329] by
-
- 2 edits in trunk/WebKit/qt
2009-06-28 Sriram Yadavalli <sriram.yadavalli@nokia.com>
Reviewed by Eric Seidel.
[Qt] Fix build break for Qt
https://bugs.webkit.org/show_bug.cgi?id=26779
- Api/qwebpage.cpp: (QWebPage::swallowContextMenuEvent):
- 4:58 AM Changeset in webkit [45328] by
-
- 2 edits in trunk/WebKitTools
2009-06-28 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix - include stdarg.h for va_start/va_end.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
- 4:15 AM Changeset in webkit [45327] by
-
- 2 edits in trunk/WebCore
2009-06-28 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Reviewed by Eric Seidel.
PurgeableBuffer #defines leave out functions on gtk MacOSX 10.4 build
https://bugs.webkit.org/show_bug.cgi?id=23057
Define these functions for Gtk as well.
- platform/PurgeableBuffer.h:
- 4:14 AM Changeset in webkit [45326] by
-
- 2 edits in trunk/WebCore
2009-06-28 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Update CodeGeneratorV8.pm to match the new api for V8Proxy.
- bindings/scripts/CodeGeneratorV8.pm: Match the current version of V8Proxy.
- 4:13 AM Changeset in webkit [45325] by
-
- 5 edits in trunk/WebCore
2009-06-28 Nicolas Sylvain <nsylvain@chromium.org>
Reviewed by Dimitri Glazkov.
If loading a font fails because of the sandbox, we ask the browser process to
try to load it by calling ensureFontLoaded. If it still fails after
ensureFontLoaded, we hit a ASSERT_NOT_REACHED.
This case happens once in a while during browser shutdown. The browser will
queue a message to the renderer to shutdown, and will then stop answering sync
messages from the renderer. If the renderer is still loading a page during this
time, it might try to call the browser process to ask to load a font. The
browser process will ignore the request, and the font will fail to load, even
after the second try.
This is unfortunate, but there is no real risk here, since the renderer will be
going away as soon as it processes another message.
This can't be layout tested as it depends on the sandbox.
- platform/graphics/chromium/FontChromiumWin.cpp:
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
- 3:31 AM Changeset in webkit [45324] by
-
- 8 edits2 adds in trunk
2009-06-28 John Abd-El-Malek <jam@chromium.org>
Layout tests to ensure that "src" paramater is added when it's missing
but "data" is present.
- plugins/netscape-plugin-map-data-to-src-expected.txt: Added.
- plugins/netscape-plugin-map-data-to-src.html: Added.
2009-06-28 John Abd-El-Malek <jam@chromium.org>
Reviewed by Eric Seidel.
Test: plugins/netscape-plugin-map-data-to-src.html
Fix problems with Real or WMP plugins not displaying because "data" was set
on the OBJECT tag instead of "src". This is based on what Firefox does, see
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp#3045
- rendering/RenderPartObject.cpp: (WebCore::mapDataParamToSrc): (WebCore::RenderPartObject::updateWidget):
2009-06-28 John Abd-El-Malek <jam@chromium.org>
Modify NPAPI test plugin to verify that "src" paramater is added when
it's missing but "data" is present.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginLog):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_Destroy): (NPP_SetWindow): (handleEventCarbon): (handleEventCocoa):
- DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New):
- 3:19 AM Changeset in webkit [45323] by
-
- 2 edits in trunk/LayoutTests
2009-06-28 Eric Seidel <eric@webkit.org>
No review. Just updating test results Kevin seems to have missed.
Test failure started with:
http://trac.webkit.org/changeset/45287
The new results definitely look better.
- fast/profiler/profile-with-no-title-expected.txt:
- 2:36 AM Changeset in webkit [45322] by
-
- 1 edit2 adds in trunk/WebKit/gtk/po
2009-06-28 Miloš Popović <gpopac@gmail.com>
Rubber-stamped by Jan Alonzo.
New Serbian translation.
- sr.po: Added.
- sr@latin.po: Added.
Jun 27, 2009:
- 11:05 PM Changeset in webkit [45321] by
-
- 2 edits in trunk/WebCore
2009-06-27 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Fix up previous change. When computeCompositingRequirements() determines
that the current layer is composited, it needs to inform its parent
by setting compositingState.m_subtreeIsCompositing() to true. That didn't
always happen after the previous patch. Clarified the logic here.
- rendering/RenderLayerCompositor.cpp: (WebCore::CompositingState::CompositingState): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 10:54 PM Changeset in webkit [45320] by
-
- 2 edits in trunk/WebCore
2009-06-27 Laszlo Gombos <Laszlo Gombos>
Reviewed by Jan Alonzo.
[Qt] Build fix after r45290
https://bugs.webkit.org/show_bug.cgi?id=26769
- WebCore.pro:
- 10:54 PM Changeset in webkit [45319] by
-
- 4 edits in trunk
2009-06-27 Emilio Pozuelo Monfort <pochu27@gmail.com>
Reviewed by Jan Alonzo.
[GTK] Don't use deprecated GTK+ symbols.
https://bugs.webkit.org/show_bug.cgi?id=26583
- plugins/gtk/gtk2xtbin.c: (gtk_xtbin_class_init): (gtk_xtbin_new): (gtk_xtbin_destroy):
- GtkLauncher/main.c: (create_toolbar):
- 9:38 PM Changeset in webkit [45318] by
-
- 2 edits in trunk/WebCore
2009-06-27 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
First part: fix the RenderLayer::hasCompositingDescendant() flag to be set
correctly.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): Do not unconditionally set compositingState.m_subtreeIsCompositing, because that can clobber the value from an earlier sibling. Add some more comments.
Remove a final use of Vector iterators.
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
Move the normalFlowList() processing outside the test for isStackingContext().
- 9:19 PM Changeset in webkit [45317] by
-
- 10 edits in trunk/WebCore
Reviewed by Simon Fraser and Antti Koivisto.
- make paintFillLayerExtended() non-virtual and remove its clipY and clipH parameters
These parameters were computed and passed along to
paintFillLayerExtended in order to vertically constrain the rect fill to
the damage rect, because Qt cannot paint tall rectangles (see
<http://websvn.kde.org/?view=rev&revision=42721>). Since the damage rect
is passed along in the PaintInfo, the extra parameters are redundant,
and the intersection can just take place in paintFillLayerExtended().
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
- rendering/InlineFlowBox.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintMaskImages): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderBoxModelObject.h:
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
- rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): (WebCore::RenderTable::paintMask):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintMask):
- 8:13 PM Changeset in webkit [45316] by
-
- 6 edits22 adds in trunk
WebCore:
2009-06-27 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
Clean up for IndentOutdentCommand::indentRegion, and solved most of problems related to the bug 21712.
https://bugs.webkit.org/show_bug.cgi?id=21712
Added few utility functions to htmlediting.h/cpp
isVisibilyAdjacent checks whether the first position is visibly next to the second position.
i.e. there is no visible node between the first and second positions
canMergeLists checks whether two lists can be merged.
It checks the type of list, the editing boundary, and adjacency of the lists.
Tests: editing/execCommand/indent-nested-lists-1.html
editing/execCommand/indent-nested-lists-2.html
editing/execCommand/indent-nested-lists-3.html
editing/execCommand/indent-nested-lists-4.html
editing/execCommand/indent-nested-lists-5.html
editing/execCommand/indent-nested-lists-6.html
editing/execCommand/indent-nested-lists-7.html
editing/execCommand/outdent-nested-lists-1.html
editing/execCommand/outdent-nested-lists-2.html
editing/execCommand/outdent-nested-lists-3.html
editing/execCommand/outdent-nested-lists-4.html
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): (WebCore::IndentOutdentCommand::tryIndentingAsListItem): (WebCore::IndentOutdentCommand::indentIntoBlockquote): (WebCore::IndentOutdentCommand::indentRegion):
- editing/IndentOutdentCommand.h:
- editing/htmlediting.cpp: (WebCore::enclosingListChild): (WebCore::canMergeLists): (WebCore::isVisibilyAdjacent):
- editing/htmlediting.h:
LayoutTests:
2009-06-27 Ryosuke Niwa <set EMAIL_ADDRESS environment variable>
Reviewed by Eric Seidel.
Clean up for IndentOutdentCommand::indentRegion, and solved most of problems related to the bug 21712.
https://bugs.webkit.org/show_bug.cgi?id=21712
The following test cases are intended for 21712, but included here
since this patch already solved a lot of problems.
- editing/execCommand/indent-nested-lists-1-expected.txt: Added.
- editing/execCommand/indent-nested-lists-1.html: Added.
- editing/execCommand/indent-nested-lists-2-expected.txt: Added.
- editing/execCommand/indent-nested-lists-2.html: Added.
- editing/execCommand/indent-nested-lists-3-expected.txt: Added.
- editing/execCommand/indent-nested-lists-3.html: Added.
- editing/execCommand/indent-nested-lists-4-expected.txt: Added.
- editing/execCommand/indent-nested-lists-4.html: Added.
- editing/execCommand/indent-nested-lists-5-expected.txt: Added.
- editing/execCommand/indent-nested-lists-5.html: Added.
- editing/execCommand/indent-nested-lists-6-expected.txt: Added.
- editing/execCommand/indent-nested-lists-6.html: Added.
- editing/execCommand/indent-nested-lists-7-expected.txt: Added.
- editing/execCommand/indent-nested-lists-7.html: Added.
- editing/execCommand/outdent-nested-lists-1-expected.txt: Added.
- editing/execCommand/outdent-nested-lists-1.html: Added.
- editing/execCommand/outdent-nested-lists-2-expected.txt: Added.
- editing/execCommand/outdent-nested-lists-2.html: Added.
- editing/execCommand/outdent-nested-lists-3-expected.txt: Added.
- editing/execCommand/outdent-nested-lists-3.html: Added.
- editing/execCommand/outdent-nested-lists-4-expected.txt: Added.
- editing/execCommand/outdent-nested-lists-4.html: Added.
- 7:31 PM Changeset in webkit [45315] by
-
- 2 edits in trunk/WebCore
2009-06-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Fix completion when iterating options using Tab.
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):
- 5:32 PM Changeset in webkit [45314] by
-
- 1 edit33 adds in trunk/LayoutTests
2009-06-27 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
More tests for the XSSAuditor.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt: Added.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt: Added.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event.html: Added.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt: Added.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html: Added.
- http/tests/security/xssAuditor/anchor-url-dom-write-location.html: Added.
- http/tests/security/xssAuditor/dom-write-URL-expected.txt: Added.
- http/tests/security/xssAuditor/dom-write-URL.html: Added.
- http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt: Added.
- http/tests/security/xssAuditor/dom-write-innerHTML.html: Added.
- http/tests/security/xssAuditor/dom-write-location-expected.txt: Added.
- http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt: Added.
- http/tests/security/xssAuditor/dom-write-location-inline-event.html: Added.
- http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt: Added.
- http/tests/security/xssAuditor/dom-write-location-javascript-URL.html: Added.
- http/tests/security/xssAuditor/dom-write-location.html: Added.
- http/tests/security/xssAuditor/faux-script1-expected.txt: Added.
- http/tests/security/xssAuditor/faux-script1.html: Added.
- http/tests/security/xssAuditor/faux-script2-expected.txt: Added.
- http/tests/security/xssAuditor/faux-script2.html: Added.
- http/tests/security/xssAuditor/faux-script3-expected.txt: Added.
- http/tests/security/xssAuditor/faux-script3.html: Added.
- http/tests/security/xssAuditor/get-from-iframe-expected.txt: Added.
- http/tests/security/xssAuditor/get-from-iframe.html: Added.
- http/tests/security/xssAuditor/malformed-HTML-expected.txt: Added.
- http/tests/security/xssAuditor/malformed-HTML.html: Added.
- http/tests/security/xssAuditor/post-from-iframe-expected.txt: Added.
- http/tests/security/xssAuditor/post-from-iframe.html: Added.
- http/tests/security/xssAuditor/resources/anchor-url-dom-write-location-click.html: Added.
- http/tests/security/xssAuditor/resources/echo-dom-write-URL.html: Added.
- http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html: Added.
- http/tests/security/xssAuditor/resources/echo-dom-write-location.html: Added.
- http/tests/security/xssAuditor/resources/utilities.js: Added. (sendRequestFromIFrame):
- 2:38 PM Changeset in webkit [45313] by
-
- 3 edits in trunk/WebCore
2009-06-27 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable
Override visibleContentRect to handle GTK+'s case, in which
scrollbars or equivalent decoration are painted by the parent
widget.
- platform/ScrollView.cpp:
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::visibleContentRect):
- 12:36 PM Changeset in webkit [45312] by
-
- 7 edits9 adds in trunk
WebCore:
2009-06-27 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fix addresses false negatives with respect to scheme relative paths, iFrame JavaScript URLs,
and UTF-7 encoded payloads.
Tests: http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html
http/tests/security/xssAuditor/iframe-javascript-url.html
http/tests/security/xssAuditor/script-tag-utf-7-encoded.html
http/tests/security/xssAuditor/script-tag-with-source-relative-scheme.html
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Moved XSSAuditor check to HTMLTokenizer::parseTag. (WebCore::HTMLTokenizer::parseTag):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): Modified to inform XSSAuditor of parent frame so as to compare against iFrame javascript URL.
- page/XSSAuditor.cpp: Removed method XSSAuditor::isControlCharacter. Instead, exposed method isControlCharacter in ResourceResponseBase.cpp. (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::decodeURL): Modified to decode string using specified encoder. (WebCore::XSSAuditor::findInRequest): Generalized to arbitrary frame so as to prevent execution of iFrame javascript URL.
- page/XSSAuditor.h: Added field m_parentFrame.
- platform/network/ResourceResponseBase.cpp: (WebCore::isControlCharacter):
- platform/network/ResourceResponseBase.h:
LayoutTests:
2009-06-27 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests prevention of injected scripts with scheme relative paths, iFrame JavaScript URLs,
and UTF-7 encoding.
- http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Added.
- http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-default-encode.pl: Added.
- http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-relative-scheme.html: Added.
- 1:34 AM Changeset in webkit [45311] by
-
- 4 edits2 adds in trunk
Bug 26771: Canvas is incorrectly tainted when drawing from a video element that uses <source> elements
Reviewed by Maciej Stachowiak.
The drawImage(<video>) logic naively assumes that it just needs
to check the src attribute of the video element when in fact it
needs to look at the url that is being played instead. Failure
to do this means that video provided through source elements
taints the canvas.
Test: media/video-canvas-source.html
- 12:34 AM Changeset in webkit [45310] by
-
- 2 edits in trunk/WebKit/qt
2009-06-27 Simon Hausmann <simon.hausmann@nokia.com>
Build fix for Qt under Windows.
- Api/qwebhistory.h: Use consistent export linkage for the datastream operators.
Jun 26, 2009:
- 11:22 PM Changeset in webkit [45309] by
-
- 3 edits in trunk/WebCore
2009-06-26 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/7011924> Opacity transitions should not trigger hardware compositing mode
Don't go into compositing mode just for opacity transitions, but they will be
hardware accelerated if we're already compositing.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForTransform): (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
- rendering/RenderLayerCompositor.h:
- 10:19 PM Changeset in webkit [45308] by
-
- 2 edits in trunk/LayoutTests
Updating Tiger results for a recently modified test.
- platform/mac-tiger/fast/encoding/idn-security-expected.txt:
- 10:15 PM Changeset in webkit [45307] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/7009684> REGRESSION(r45039): Crashes inside JSEvent::put on PowerPC (26746)
<https://bugs.webkit.org/show_bug.cgi?id=26746>
Reviewed by Dan Bernstein
Fix for r45039 incorrectly uncached a get_by_id by converting it to put_by_id. Clearly this
is less than correct. This patch corrects that error.
- 7:49 PM Changeset in webkit [45306] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
Mac build fix part 2 - add new mangled symbol
- 7:40 PM Changeset in webkit [45305] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
First part of Mac Build Fix - find missing symbol
- 7:23 PM Changeset in webkit [45304] by
-
- 12 edits in trunk
2009-06-26 Brian Weinstein <bweinstein@apple.com>
Reviewed by Simon Fraser.
Changed call of scrollbarUnderMouse to scrollbarUnderPoint to match new API.
- Api/qwebpage.cpp: (QWebPage::swallowContextMenuEvent):
2009-06-26 Brian Weinstein <bweinstein@apple.com>
Reviewed by Simon Fraser.
Added hit testing on scrollbars, so if you start a gesture over a scrollbar,
it isn't counted, and lets the user drag the scrollbar itself instead of a
panning gesture. Also cleaned up code in gesture.
- WebView.cpp: (WebView::gestureNotify): (WebView::gesture):
2009-06-26 Brian Weinstein <bweinstein@apple.com>
Reviewed by Simon Fraser.
Added the ability to do scrollbar hit testing in EventHandler, changed the
signature of a PlatformWheelEvent constructor, and changed scrollbarUnderMouse
to scrollbarUnderPoint, and updated all calls to that function.
- page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent):
- page/EventHandler.h: (WebCore::):
- platform/PlatformWheelEvent.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarUnderPoint):
- platform/ScrollView.h:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleMouseDownEvent): (WebCore::PopupListBox::handleMouseMoveEvent):
- platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- 7:02 PM Changeset in webkit [45303] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Standardized op_call to put { tag, payload } in { regT1, regT0 }.
SunSpider and v8 report no change.
- jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCallVarargsSetupArgs): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- 6:52 PM Changeset in webkit [45302] by
-
- 2 edits in trunk/WebKit/win
2009-06-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Fix a build break due to LocalStorage.h being included in WebKitDLL.cpp
despite it being deleted from the repo by the following patch/commit:
https://bugs.webkit.org/show_bug.cgi?id=26732
http://trac.webkit.org/changeset/45290
- WebKitDLL.cpp:
- 6:49 PM Changeset in webkit [45301] by
-
- 2 edits in trunk/WebKitTools
2009-06-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make SVN work (again?).
- Scripts/modules/scm.py:
- 5:58 PM Changeset in webkit [45300] by
-
- 2 edits in trunk/WebCore
2009-06-26 Simon Fraser <Simon Fraser>
Rubber-stamped by Dave Levin
Rename ioCompState to compositingState to better match WebCore coding style.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- 5:50 PM Changeset in webkit [45299] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
- revert unintentional project changes from r45277
- WebCore.xcodeproj/project.pbxproj:
- 5:44 PM Changeset in webkit [45298] by
-
- 2 edits in trunk/WebCore
Fix the Windows build.
- 5:37 PM Changeset in webkit [45297] by
-
- 3 edits in trunk/WebCore
2009-06-26 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Change to use array indexing rather than Vector enumerators; the former
are preferred style.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::hasNonCompositingContent):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry): (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): (WebCore::RenderLayerCompositor::layerHas3DContent):
- 5:17 PM Changeset in webkit [45296] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
- fix <rdar://problem/6961476> REGRESSION (r42043): scrollWidth reported as 1 px
Test: fast/dom/Element/scrollWidth.html
Changed scrollWidth and scrollHeight to use the same logic for
visible overflow boxes that is used for clipped overflow boxes. In
particular, borders are not included and
{leftmost,rightmost,lowest}Position() are used. This logic matches IE8.
- rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
LayoutTests:
Reviewed by Oliver Hunt.
- fast/dom/Element/scrollWidth-expected.txt: Added.
- fast/dom/Element/scrollWidth.html: Added.
- 5:07 PM Changeset in webkit [45295] by
-
- 10 edits6 adds in trunk
Bug 26725: aria-hidden, aria-disabled, aria-readonly need to be implemented
https://bugs.webkit.org/show_bug.cgi?id=26725
- 5:02 PM Changeset in webkit [45294] by
-
- 1 edit1 move4 adds in trunk/LayoutTests
2009-06-26 Brady Eidson <beidson@apple.com>
OMG.
- platform/mac-tiger/fast/loader/file-url-mimetypes-expected.txt: Removed.
- platform/mac-tiger/platform: Added.
- platform/mac-tiger/platform/mac: Added.
- platform/mac-tiger/platform/mac/fast: Added.
- platform/mac-tiger/platform/mac/fast/loader: Added.
- platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from platform/mac-tiger/fast/loader/file-url-mimetypes-expected.txt.
- 4:09 PM Changeset in webkit [45293] by
-
- 3 edits in trunk/WebCore
2009-06-26 Brett Wilson <brettw@chromium.org>
Reviewed by David Levin.
GIFImageDecoder is broken.
Make the GIFImageDecoder.repetitionCount function const to match the
base class. The mismatched definitions were causing the function to not
get called.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::repetitionCount):
- platform/image-decoders/gif/GIFImageDecoder.h:
- 3:58 PM Changeset in webkit [45292] by
-
- 4 edits in trunk
Additional fix for https://bugs.webkit.org/show_bug.cgi?id=26651
The flag should always default to true to avoid it getting set
to false in a build with accelerated compositing turned off
and then disabling accelerated compositing when subsequently
running a build with it turned on.
- 3:53 PM Changeset in webkit [45291] by
-
- 3 edits in trunk/WebCore
2009-06-26 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Followup for the fix for <rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails
Now that other MIME type correction stuff is in our swizzled method, Tiger needs it too!
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
- platform/network/mac/WebCoreURLResponse.h:
- 3:49 PM Changeset in webkit [45290] by
-
- 17 edits1 move1 add3 deletes in trunk/WebCore
2009-06-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
For the final step of https://bugs.webkit.org/show_bug.cgi?id=25376,
combine LocalStorage and SessionStorage into StorageNamespace. The
synching code (for LocalStorage) has already been removed, so these
classes are now very similar. All they do is essentially contain a
logical grouping of origins that are attached to specific contexts
(be it PageGroups for LocalStorage and Page for SessionStorage).
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- page/Chrome.cpp: (WebCore::Chrome::createWindow):
- page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage):
- page/DOMWindow.h:
- page/Page.cpp: (WebCore::Page::sessionStorage): (WebCore::Page::setSessionStorage):
- page/Page.h:
- page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
- page/PageGroup.h:
- storage/LocalStorage.cpp: Removed.
- storage/LocalStorage.h: Removed.
- storage/LocalStorageTask.cpp:
- storage/LocalStorageThread.cpp:
- storage/SessionStorage.cpp: Removed.
- storage/SessionStorage.h: Removed.
- storage/StorageArea.cpp: (WebCore::StorageArea::create): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::copy): (WebCore::StorageArea::length): (WebCore::StorageArea::key): (WebCore::StorageArea::getItem): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::contains): (WebCore::StorageArea::importItem): (WebCore::StorageArea::close): (WebCore::StorageArea::dispatchStorageEvent):
- storage/StorageArea.h: (WebCore::):
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::scheduleFinalSync):
- storage/StorageNamespace.cpp: Copied from WebCore/storage/LocalStorage.cpp. (WebCore::localStorageNamespaceMap): (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespace::StorageNamespace): (WebCore::StorageNamespace::~StorageNamespace): (WebCore::StorageNamespace::copy): (WebCore::StorageNamespace::storageArea): (WebCore::StorageNamespace::close):
- storage/StorageNamespace.h: Copied from WebCore/storage/LocalStorage.h.
- 3:48 PM Changeset in webkit [45289] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-06-26 Brady Eidson <beidson@apple.com>
Fix Tiger results for the new mime type layout test.
- platform/mac-tiger/fast/loader: Added.
- platform/mac-tiger/fast/loader/file-url-mimetypes-expected.txt: Added.
- 3:22 PM Changeset in webkit [45288] by
-
- 83 edits1 add in trunk/WebCore
2009-06-26 Nate Chapin <Nate Chapin>
Reviewed by David Levin.
Upstream V8Proxy. This involved updating a lot of function and variable names to match WebKit style, hence the large size.
- 3:08 PM Changeset in webkit [45287] by
-
- 4 edits in trunk/WebCore
2009-06-26 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/7011047> Profiler shows the record button 'on' even
though it's finished
I consolidated the creation of the user initiated profile name into
its own function and then called it from console::profile instead of
calling startUserInitiatedProfiling(). This way we don't call
toggleRecordButton() which turns on the record button.
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
- inspector/InspectorController.h:
- page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
- 3:06 PM Changeset in webkit [45286] by
-
- 2 edits in trunk/LayoutTests
2009-06-26 Jessie Berlin <jberlin@apple.com>
Reviewed by Mark Rowe.
Fix the build bots.
- editing/selection/drag-start-event-client-x-y-expected.txt:
- 2:53 PM Changeset in webkit [45285] by
-
- 19 edits1 add3 deletes in trunk/WebCore
Move focusRingColor to RenderTheme
- 2:51 PM Changeset in webkit [45284] by
-
- 2 edits in trunk/WebCore
2009-06-26 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26761
[Chromium] Enable Dedicated Workers in Chromium.
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Remove the check that prevented workers from being created w/o a command-line switch. The flag itself and methods will be removed in a subsequent patch, after corresponding change in Chromium.
- 2:46 PM Changeset in webkit [45283] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-06-26 Brady Eidson <beidson@apple.com>
Step 2 (new Mac results)
- platform/mac/fast/images/favicon-as-image-expected.checksum: Added.
- platform/mac/fast/images/favicon-as-image-expected.png: Added.
- platform/mac/fast/images/favicon-as-image-expected.txt: Added.
- 2:44 PM Changeset in webkit [45282] by
-
- 1 edit3 moves1 add6 deletes in trunk/LayoutTests
2009-06-26 Brady Eidson <beidson@apple.com>
1st step of fixing the layout test I broke on Mac platforms.
- platform/mac-leopard/fast/images/favicon-as-image-expected.checksum: Removed.
- platform/mac-leopard/fast/images/favicon-as-image-expected.png: Removed.
- platform/mac-leopard/fast/images/favicon-as-image-expected.txt: Removed.
- platform/mac-tiger/fast/images/favicon-as-image-expected.checksum: Removed.
- platform/mac-tiger/fast/images/favicon-as-image-expected.png: Removed.
- platform/mac-tiger/fast/images/favicon-as-image-expected.txt: Removed.
- platform/mac/fast/images/favicon-as-image-expected.checksum: Removed.
- platform/mac/fast/images/favicon-as-image-expected.png: Removed.
- platform/mac/fast/images/favicon-as-image-expected.txt: Removed.
- platform/win/fast/images: Added.
- platform/win/fast/images/favicon-as-image-expected.checksum: Copied from platform/mac/fast/images/favicon-as-image-expected.checksum.
- platform/win/fast/images/favicon-as-image-expected.png: Copied from platform/mac/fast/images/favicon-as-image-expected.png.
- platform/win/fast/images/favicon-as-image-expected.txt: Copied from platform/mac/fast/images/favicon-as-image-expected.txt.
- 2:01 PM Moving to Git edited by
- (diff)
- 1:51 PM Changeset in webkit [45281] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-26 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Handle multiplying by zero a little better by
inlining the case that both operands are non-negative
into the slowpath.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::branchOr32):
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
- 1:49 PM Changeset in webkit [45280] by
-
- 2 edits in trunk/WebKit/mac
2009-06-26 Brady Eidson <beidson@apple.com>
Fix SnowLeopard build.
- Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didReceiveResponse):
- 1:40 PM Changeset in webkit [45279] by
-
- 2 edits in trunk/LayoutTests
Land updated results after the test change.
- editing/selection/user-drag-element-and-user-select-none-expected.txt:
- 1:29 PM Changeset in webkit [45278] by
-
- 4 edits2 adds in trunk
2009-06-26 Jessie Berlin <jberlin@apple.com>
Fix: https://bugs.webkit.org/show_bug.cgi?id=26723
Where the m_mouseDown event was never being set on windows, so the
client X and Y coordinates were always being reported as zero in a
dragstart handler.
Reviewed by Mark Rowe.
Test: editing/selection/drag-start-event-client-x-y.html
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set the m_mouseDown event when the mouse press is handled.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::mouseDown): Removed now redundant setting of m_mouseDown.
Layout test for making sure the client X Y coordinates of the event
in a dragstart handler are correct.
- editing/selection/drag-start-event-client-x-y-expected.txt: Added.
- editing/selection/drag-start-event-client-x-y.html: Added.
- 1:13 PM Changeset in webkit [45277] by
-
- 3 edits in trunk/WebCore
2009-06-26 Brady Eidson <beidson@apple.com>
Tiger build fix
- WebCore.xcodeproj/project.pbxproj:
- platform/network/mac/WebCoreURLResponse.mm: (swizzleMIMETypeMethodIfNecessary):
- 12:43 PM Changeset in webkit [45276] by
-
- 2 edits in trunk/LayoutTests
Fix user-drag-element-and-user-select-none.html to not rely on a bug in Mac DRT.
Reviewed by Sam Weinig.
- editing/selection/user-drag-element-and-user-select-none.html:
- 12:38 PM Changeset in webkit [45275] by
-
- 3 edits in trunk/WebCore
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=26681
Problem updating applicationCache when server returns 304
Improve the fix, make the test pass on Tiger.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): Fix another code path to remove the current item from list.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): On Tiger, conditional requests that cannot be cached by network layer cause errors with default cache policy.
- 12:23 PM Changeset in webkit [45274] by
-
- 17 edits269 adds in trunk
WebCore:
2009-06-26 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails
When we disabled content sniffing for file urls we lost knowledge of many file extensions that we
didn't intend to lose. Turns out the CoreTypes UTI database doesn't know about every extension Gatekeeper
knew about.
By comparing CoreTypes' database to Gatekeepers, this patch adds a hardcoded list of file extension to MIME
type mappings that are missing in CoreType's database.
Test: platform/mac/fast/loader/file-url-mimetypes.html
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Move the MIME Type swizzling code to WebCoreURLResponse.
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): _webcore_MIMEType -> MIMEType, as we now have only one place where we do all MIMEType correction.
- platform/network/mac/WebCoreURLResponse.h: Remove _webcore_MIMEType, as it is now folded into the swizzled implementation of MIMEType.
- platform/network/mac/WebCoreURLResponse.mm: (createBinaryExtensionsSet): (createExtensionToMIMETypeMap): (swizzleMIMETypeMethodIfNecessary): (webNSURLResponseMIMEType): If it's a file URL and there's no MIME type, see if the extension exists in the extension -> MIME type map before turning to the default MIME type. Also roll in what was previously implemented in _webcore_MIMEType.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::~SVGImage): Tweak this ASSERT - SVGImages might get destroyed without ever having a client.
WebKit/mac:
2009-06-26 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails
Replace all usage of the now obsolete [NSURLResponse _webcore_MIMEType].
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::didReceiveResponse):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginView:receivedData:]):
- Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
- WebView/WebDataSource.mm: (-[WebDataSource _responseMIMEType]):
- WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:]):
WebKitTools:
2009-06-26 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails
Add a dumpResourceResponseMIMETypes() mode so the ResourceLoadDelegate will dump the mime type from
the NSURLResponse. Needed for the test for this bug fix.
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpResourceResponseMIMETypesCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpResourceResponseMIMETypes): (LayoutTestController::setDumpResourceResponseMIMETypes):
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
LayoutTests:
2009-06-25 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
<rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails
Add a test file for each of file extensions we think WebKit on Mac should know the MIME type for.
- platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
- platform/mac/fast/loader/file-url-mimetypes.html: Added.
- platform/mac/fast/loader/resources: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-3g2.3g2: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-3gp.3gp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-3gp2.3gp2: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-3gpp.3gpp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-Z.Z: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ac3.ac3: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ai.ai: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-aif.aif: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-aifc.aifc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-aiff.aiff: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-asc.asc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-asf.asf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-asx.asx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-au.au: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-avi.avi: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-bcpio.bcpio: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-bin.bin: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-bmp.bmp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-bz.bz: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-bz2.bz2: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-cdf.cdf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-class.class: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-cpgz.cpgz: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-cpio.cpio: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-cpt.cpt: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-crw.crw: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-csh.csh: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-css.css: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dcr.dcr: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dif.dif: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dir.dir: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dll.dll: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dls.dls: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dmg.dmg: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dms.dms: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-doc.doc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-docm.docm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-docx.docx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dotm.dotm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dotx.dotx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dv.dv: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dvi.dvi: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-dxr.dxr: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-efx.efx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-eps.eps: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-etx.etx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-exe.exe: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ez.ez: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-fdf.fdf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-fla.fla: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-fp.fp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-fp2.fp2: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-fp3.fp3: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-fp4.fp4: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-fp5.fp5: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-fp6.fp6: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-fpx.fpx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-gif.gif: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-gtar.gtar: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-gz.gz: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-gzip.gzip: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-hdf.hdf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-hqx.hqx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-htm.htm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-html.html: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ice.ice: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ico.ico: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ics.ics: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ief.ief: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-iges.iges: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-igs.igs: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-iso.iso: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-j2k.j2k: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jar.jar: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-javascript.javascript: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jhtml.jhtml: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jnlp.jnlp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jp2.jp2: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jpe.jpe: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jpeg.jpeg: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jpf.jpf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jpg.jpg: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jpx.jpx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-js.js: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-jscript.jscript: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-kar.kar: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-latex.latex: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-lha.lha: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-lzh.lzh: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-m15.m15: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-m2v.m2v: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-m3u.m3u: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-m4p.m4p: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-m75.m75: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mac.mac: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-man.man: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-me.me: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mesh.mesh: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mid.mid: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-midi.midi: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mif.mif: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mov.mov: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-movie.movie: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mp2.mp2: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mp3.mp3: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mp4.mp4: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mpe.mpe: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mpeg.mpeg: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mpg.mpg: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mpga.mpga: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ms.ms: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-msh.msh: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-mxu.mxu: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-nc.nc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-oda.oda: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-odc.odc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-odf.odf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-odg.odg: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-odi.odi: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-odm.odm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-odp.odp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ods.ods: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-odt.odt: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-otc.otc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-otf.otf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-otg.otg: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-oth.oth: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-oti.oti: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-otp.otp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ots.ots: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ott.ott: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pbm.pbm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pct.pct: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pcx.pcx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pdb.pdb: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pdf.pdf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pgm.pgm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pgn.pgn: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ph3.ph3: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ph4.ph4: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-php.php: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-php3.php3: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-php4.php4: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-phtml.phtml: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pic.pic: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pict.pict: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pl.pl: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pls.pls: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pm.pm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-png.png: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pnm.pnm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pnt.pnt: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pntg.pntg: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-potm.potm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-potx.potx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ppm.ppm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ppsm.ppsm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ppsx.ppsx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ppt.ppt: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pptm.pptm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-pptx.pptx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ps.ps: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-psd.psd: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-py.py: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-qif.qif: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-qt.qt: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-qti.qti: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-qtif.qtif: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-qtz.qtz: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ra.ra: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ram.ram: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ras.ras: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-rb.rb: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-rbw.rbw: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-rgb.rgb: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-rm.rm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-roff.roff: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-rpm.rpm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-rtf.rtf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-rtx.rtx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-sgi.sgi: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-sgm.sgm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-sgml.sgml: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-sh.sh: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-shar.shar: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-shtm.shtm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-shtml.shtml: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-silo.silo: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-sit.sit: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-sitx.sitx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-skd.skd: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-skm.skm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-skp.skp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-skt.skt: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-smf.smf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-smi.smi: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-smil.smil: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-snd.snd: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-so.so: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-spl.spl: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-src.src: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-sv4cpio.sv4cpio: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-sv4crc.sv4crc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-svg.svg: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-svgz.svgz: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-swf.swf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-t.t: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tar.tar: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-targa.targa: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tcl.tcl: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tex.tex: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-texi.texi: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-texinfo.texinfo: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-text.text: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tga.tga: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tgz.tgz: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tif.tif: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tiff.tiff: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-torrent.torrent: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tr.tr: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-tsv.tsv: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-txt.txt: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-ustar.ustar: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-vcard.vcard: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-vcd.vcd: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-vcf.vcf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-vfw.vfw: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-vrml.vrml: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wav.wav: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wave.wave: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wax.wax: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wbmp.wbmp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wbxml.wbxml: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-webarchive.webarchive: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wm.wm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wma.wma: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wmd.wmd: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wml.wml: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wmlc.wmlc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wmls.wmls: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wmlsc.wmlsc: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wmp.wmp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wmv.wmv: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wmx.wmx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wrl.wrl: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-wvx.wvx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xbm.xbm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xdp.xdp: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xfd.xfd: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xfdf.xfdf: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xht.xht: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xhtm.xhtm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xhtml.xhtml: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xls.xls: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xlsb.xlsb: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xlsm.xlsm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xlsx.xlsx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xltm.xltm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xltx.xltx: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xml.xml: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xpm.xpm: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xsl.xsl: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xwd.xwd: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-xyz.xyz: Added.
- platform/mac/fast/loader/resources/mimeTypeExamples/example-zip.zip: Added.
- 11:28 AM Changeset in webkit [45273] by
-
- 8 edits in trunk/WebCore
2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Show the fullscreen button only if the backend has support for it.
No test since this is not reachable via the DOM.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::supportsFullscreen): new
- html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::supportsFullscreen): new
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::supportsFullscreen): new (WebCore::MediaPlayer::supportsFullscreen): new
- platform/graphics/MediaPlayer.h: new
- platform/graphics/MediaPlayerPrivate.h: new (WebCore::MediaPlayerPrivateInterface::supportsFullscreen): new
- rendering/MediaControlElements.cpp: (WebCore::MediaControlFullscreenButtonElement::rendererIsNeeded): new
- rendering/MediaControlElements.h:
- 11:02 AM Changeset in webkit [45272] by
-
- 2 edits in trunk/WebCore
2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7007776> Controller doesn't automatically update counters when file
is playing ( http://www.jazzguitar.be/mp3/Michael%20Lewis%20-%20SSSJ.mp3 )
Update the time display when the movie time changes.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
- 11:00 AM Changeset in webkit [45271] by
-
- 10 edits in trunk
2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
Support hidding a control bar element from the Media element controller.
Update layout tests since the fullscreen button no longer has a renderer.
- rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::update): call updateStyle() so everything is updated properly. (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlInputElement::update): call updateStyle() (WebCore::MediaControlInputElement::updateStyle): create the renderer properly or not depending on what rendererIsNeeded() return.
- rendering/MediaControlElements.h:
- 10:48 AM Changeset in webkit [45270] by
-
- 2 edits in trunk/WebCore
2009-06-26 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6968137> Profiler title numbers increment even after a
reload.
- Now the numbers are reset when the profiles are.
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
- 10:36 AM Changeset in webkit [45269] by
-
- 8 edits in trunk/JavaScriptCore
2009-06-26 Eric Seidel <eric@webkit.org>
No review, only rolling out r45259.
Roll out r45259 after crash appeared on the bots:
plugins/undefined-property-crash.html
ASSERTION FAILED: s <= HeapConstants<heapType>::cellSize
(leopard-intel-debug-tests/build/JavaScriptCore/runtime/Collector.cpp:278
void* JSC::Heap::heapAllocate(size_t) [with JSC::HeapType heapType = PrimaryHeap])
- runtime/DateInstance.cpp:
- runtime/Identifier.cpp:
- runtime/Lookup.h:
- runtime/RegExpConstructor.cpp:
- runtime/RegExpObject.h:
- runtime/ScopeChain.h:
- runtime/UString.h:
- 10:17 AM Changeset in webkit [45268] by
-
- 2 edits in trunk/WebKitTools
Update build-dumprendertree to use buildXCodeProject()
Reviewed by Adam Roben.
- Scripts/build-dumprendertree: Updated to use buildXCodeProject() when building for isAppleMacWebKit(). This provides additional command-line switch parsing for free. Also added --clean and --help switches. Updated copyright.
- 10:07 AM Changeset in webkit [45267] by
-
- 1 edit in trunk/WebCore/page/Settings.cpp
got rid of cruft accidentally left in from my last commit
- 9:53 AM Changeset in webkit [45266] by
-
- 4 edits4 adds in trunk
WebCore:
2009-06-26 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/7000796>
REGRESSION(34681): Breaking up quoted text makes new, unquoted text blue after certain steps; repros with some messages
Test: editing/inserting/break-blockquote-after-delete.html
Keep track of whether the typing style should be preserved after the TypingCommand is applied. When adding onto an open
typing command, keep that flag up to date.
In this case, an InsertParagraphSeparatorInQuotedContent command, which should not preserve typing style,
was following an open Delete command, which does preserve the typing style. So we were applying the original
typing style (from before the delete, so blue text) to the cursor in the unquoted area after breaking up the blockquote.
- editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::typingAddedToOpenCommand): (WebCore::TypingCommand::insertTextRunWithoutNewlines): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::updatePreservesTypingStyle):
- editing/TypingCommand.h: (WebCore::TypingCommand::preservesTypingStyle):
LayoutTests:
2009-06-26 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Test for <rdar://problem/7000796>
REGRESSION(34681): Breaking up quoted text makes new, unquoted text blue after certain steps; repros with some messages
- editing/inserting/break-blockquote-after-delete.html: Added.
- platform/mac/editing/inserting/break-blockquote-after-delete-expected.checksum: Added.
- platform/mac/editing/inserting/break-blockquote-after-delete-expected.png: Added.
- platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
- 9:30 AM Changeset in webkit [45265] by
-
- 8 edits1 add in trunk
2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Add support for saving and loading of QWebHistory to and from a QByteArray.
This includes streaming operators for QWebHistory. for convenience.
New autotests that test QWebHistory and QWebHistoryItem serialization.
- 9:29 AM Changeset in webkit [45264] by
-
- 3 edits in trunk/WebKit/qt
2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix the behaviour of QWebHistory::itemAt to interpret the specified index as absolute index.
Returns an invalid QWebHistoryItem if the index is out of range.
- 9:29 AM Changeset in webkit [45263] by
-
- 2 edits11 adds in trunk/WebKit/qt
2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Added a few autotest to QWebHistory.
- 9:29 AM Changeset in webkit [45262] by
-
- 6 edits in trunk
2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Add support for QDataStream operators to Vector.
WebCore:
2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Add support for QDataStream operators to String and IntPoint.
- 9:27 AM Changeset in webkit [45261] by
-
- 2 edits in trunk/WebCore
2009-06-26 Ben Murdoch <benm@google.com>
Reviewed by Darin Fisher.
Add #if ENABLE(DOM_STORAGE) to the V8 custom bindings for local/session storage.
https://bugs.webkit.org/show_bug.cgi?id=26757
- bindings/v8/custom/V8StorageCustom.cpp
- 9:27 AM Changeset in webkit [45260] by
-
- 2 edits in trunk/WebKit/qt
2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix support for documenting functions prefixed with QWEBKIT_EXPORT
Add QWEBKIT_EXPORT to the list of macros to ignore by qdoc.
- 3:27 AM Changeset in webkit [45259] by
-
- 8 edits in trunk/JavaScriptCore
2009-06-26 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Allow custom memory allocation control for JavaScriptCore/runtime
directory's classes which instantiated by new:
class IdentifierTable
struct RegExpObjectData
class HashEntry
struct DataInstance::Cache
class UString
struct RegExpConstructorPrivate
class ScopeChain
- runtime/DateInstance.cpp:
- runtime/Identifier.cpp:
- runtime/Lookup.h:
- runtime/RegExpConstructor.cpp:
- runtime/RegExpObject.h:
- runtime/ScopeChain.h:
- runtime/UString.h:
- 3:07 AM Changeset in webkit [45258] by
-
- 3 edits in trunk/WebKitTools
2009-06-26 Eric Seidel <eric@webkit.org>
Reviewed by Tor Arne Vestbø.
Remove non-sense --update option to land-patches
and make land-patches update before every patch application.
This makes it slightly less likely that multi-patch landings will fail.
Also updated git diff command to include staged modifications.
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 3:06 AM Changeset in webkit [45257] by
-
- 9 edits2 adds in trunk
2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
Bug 20303: [Qt] Key events are not working in frames.
Add a layout test to test the event is sent to the right sub-frame.
- platform/qt/fast/events/event-sender-keydown-frame-expected.txt: Added.
- platform/qt/fast/events/event-sender-keydown-frame.html: Added.
2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
Test: platform/qt/fast/events/event-sender-keydown-frame.html
Bug 20303: [Qt] Key events are not working in frames.
Merge scrolling handling code in qt and win port, move it to
EventHandler.
- page/EventHandler.cpp: (WebCore::EventHandler::scrollRecursively):
- page/EventHandler.h:
2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
Bug 20303: [Qt] Key events are not working in frames.
Send scrolling events to current focused frame, bubble the event
up to parent frame if it is not handled. Use EventHandler's new
shared scrolling code.
- Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent): (QWebPagePrivate::handleScrolling):
- Api/qwebpage_p.h:
2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
Bug 20303: [Qt] Key events are not working in frames.
Move the scroll handling code to EventHandler so that other
ports can share the functionality.
- WebView.cpp: (WebView::keyDown): (EnumTextMatches::QueryInterface):
- 2:42 AM Changeset in webkit [45256] by
-
- 3 edits4 adds in trunk
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26682
Bug 26682: It should be possible to add image to SVG DOM programmatically (using JavaScript)
Make sure the xlink:href animated property setting syncs the corresponding attribute with the right namespace.
Test: svg/custom/createImageElement.svg
- 2:36 AM Changeset in webkit [45255] by
-
- 5 edits3 adds in trunk
2009-06-26 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Timothy Hatcher.
Bug 26156: In view-source mode, always render the contents using HTMLViewSourceDocument
https://bugs.webkit.org/show_bug.cgi?id=26156
When in view-source mode, render the contents using HTMLViewSourceDocument
regardless it's applicable for any plugin or not.
Chromium tells WebCore to render the contents of specified URL when
view-source: prefix is added to the URL. But currently, DOMImplementation
ignores inViewSourceMode() when the MIME type is indicating that the contents
are neither texts nor HTML family documents.
For example, we can check the contents of asf file without launching media
player. Rendering contents for view-source:-specified input is not what user
expects.
I want to fix this issue by this patch. IMHO, regardless of this Chromium
specific issue, I think we should force use of HTMLViewSourceDocument when
inViewSourceMode() is specified.
- fast/frames/resources/viewsource-fake-image-file.png: Added.
- fast/frames/viewsource-on-image-file.html: Added.
- platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Added.
2009-06-26 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Timothy Hatcher.
Bug 26156: In view-source mode, always render the contents using HTMLViewSourceDocument
https://bugs.webkit.org/show_bug.cgi?id=26156
When in view-source mode, render the contents using HTMLViewSourceDocument
regardless it's applicable for any plugin or not.
Chromium tells WebCore to render the contents of specified URL when
view-source: prefix is added to the URL. But currently, DOMImplementation
ignores inViewSourceMode() when the MIME type is indicating that the contents
are neither texts nor HTML family documents.
For example, we can check the contents of asf file without launching media
player. Rendering contents for view-source:-specified input is not what user
expects.
I want to fix this issue by this patch. IMHO, regardless of this Chromium
specific issue, I think we should force use of HTMLViewSourceDocument when
inViewSourceMode() is specified.
Test: fast/frames/viewsource-on-image-file.html
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
- html/HTMLViewSourceDocument.h:
- 2:25 AM Changeset in webkit [45254] by
-
- 5 edits in trunk
Reviewed by Sam Weinig.
<rdar://problem/6651201> Update lookalike character list.
- Misc/WebNSURLExtras.mm: (isLookalikeCharacter): Added more characters to the list.
- 2:20 AM Changeset in webkit [45253] by
-
- 2 edits7 adds in trunk/LayoutTests
2009-06-26 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel.
Add an additional test for bug 23786 (mistreatment of CR/LF
as zero-width characters in Chromium port). Tests using Bidi text were
added when the fix was checked in. Without the patch, Chromium used
to fail the same way with LTR complex scripts as well. (that is,
CR and LF were treated as zero-width space). To prevent a potential
regression in the future, a new test with Hindi (a LTR complex script)
is added.
The expected results for Mac and Windows are added while this test
is added to Skipped file for gtk. I guess this test just needs
a new test result generated on gtk.
- fast/text/international/hindi-whitespace.html: Added.
- platform/gtk/Skipped:
- platform/mac/fast/text/international/hindi-whitespace-expected.checksum: Added.
- platform/mac/fast/text/international/hindi-whitespace-expected.png: Added.
- platform/mac/fast/text/international/hindi-whitespace-expected.txt: Added.
- platform/win/fast/text/international/hindi-whitespace-expected.checksum: Added.
- platform/win/fast/text/international/hindi-whitespace-expected.png: Added.
- platform/win/fast/text/international/hindi-whitespace-expected.txt: Added.
- 2:12 AM Changeset in webkit [45252] by
-
- 2 edits in trunk/WebCore
2009-06-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25529
[Gtk] Expected states not exposed to assistive technologies
Add support for VISIBLE, EDITABLE and SENSITIVE states.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject):
- 1:40 AM Changeset in webkit [45251] by
-
- 4 edits in trunk/WebCore
2009-06-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
"Pointer to incomplete class type is not allowed" error with RVCT
https://bugs.webkit.org/show_bug.cgi?id=26721
Based on Norbert Leser's work.
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- dom/Node.cpp: (WebCore::Node::dispatchMouseEvent):
- dom/Node.h: Remove the default value for PassRefPtr<Event> args, to eliminate dependency on the Event class definition
- 1:32 AM Changeset in webkit [45250] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Eric Seidel <eric@webkit.org>
Reviewed by Jan Alonzo.
Fix obsolete_attachment to work when passed a comment.
https://bugs.webkit.org/show_bug.cgi?id=26745
- Scripts/modules/bugzilla.py:
- 1:28 AM Changeset in webkit [45249] by
-
- 3 edits in trunk/WebKitTools
2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Mark Rowe.
bugzilla-tool apply-patch throws exception in Linux
https://bugs.webkit.org/show_bug.cgi?id=26738
HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
the scm module.
- Scripts/modules/scm.py:
- 12:58 AM Changeset in webkit [45248] by
-
- 2 edits in trunk/WebCore
2009-06-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Maciej Stachowiak.
[Qt] Build fix after r45183
https://bugs.webkit.org/show_bug.cgi?id=26748
- WebCore.pro:
Jun 25, 2009:
- 9:44 PM Changeset in webkit [45247] by
-
- 4 edits1 add in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26681
<rdar://problem/7003461> Problem updating applicationCache when server returns 304
Test: http/tests/appcache/update-cache.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): We're already done with the resource, don't try to load it again.
- 9:21 PM Changeset in webkit [45246] by
-
- 1 edit in branches/nitro-extreme/JavaScriptCore/ChangeLog
Fix up JavaScriptCore/ChangeLog, messed up slightly in the merge.
- 8:32 PM Changeset in webkit [45245] by
-
- 3 edits2 adds in trunk
2009-06-25 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
<rdar://problem/6990481>
Handle perspective computation on non-layer objects.
Test: transforms/3d/general/perspective-non-layer.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
- 8:03 PM Changeset in webkit [45244] by
-
- 110 edits32 copies22 deletes in branches/nitro-extreme
Merged r45138:45243 into nitro-extreme branch.
- 7:56 PM Changeset in webkit [45243] by
-
- 3 edits2 adds in branches/nitro-extreme
Merged r45137:45138 into nitro-extreme branch.
- 7:53 PM Changeset in webkit [45242] by
-
- 125 edits49 copies in branches/nitro-extreme
Merged r45039:45137 into nitro-extreme branch.
- 7:47 PM Changeset in webkit [45241] by
-
- 7 edits2 copies in branches/nitro-extreme
Merged r45038:45039 into nitro-extreme branch.
- 7:35 PM Changeset in webkit [45240] by
-
- 67 edits26 copies in branches/nitro-extreme
Merged r45000:45038 into nitro-extreme branch.
- 7:32 PM Changeset in webkit [45239] by
-
- 3 edits1 move1 add7 deletes in trunk/LayoutTests
2009-06-25 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.
- editing/execCommand/remove-list-1-expected.txt: Added.
- editing/execCommand/remove-list-1.html:
- editing/execCommand/remove-list-items-expected.txt: Added.
- editing/execCommand/remove-list-items.html:
- platform/mac/editing/execCommand/remove-list-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/remove-list-1-expected.png: Removed.
- platform/mac/editing/execCommand/remove-list-1-expected.txt: Removed.
- platform/mac/editing/execCommand/remove-list-items-expected.checksum: Removed.
- platform/mac/editing/execCommand/remove-list-items-expected.png: Removed.
- platform/mac/editing/execCommand/remove-list-items-expected.txt: Removed.
- platform/qt/editing/execCommand/remove-list-1-expected.txt: Removed.
- platform/qt/editing/execCommand/remove-list-items-expected.txt: Removed.
- 7:31 PM Changeset in webkit [45238] by
-
- 95 edits36 copies1 delete in branches/nitro-extreme
Merged r44960:45000 into nitro-extreme branch.
- 7:20 PM Changeset in webkit [45237] by
-
- 53 edits2 adds in branches/nitro-extreme
Merged r44943:44960 into nitro-extreme branch.
- 7:19 PM Changeset in webkit [45236] by
-
- 2 edits in trunk/LayoutTests
2009-06-25 Simon Fraser <Simon Fraser>
Rubber-stamped by Eric Seidel
Update this test after the video controller changes.
- platform/mac/fast/layers/video-layer-expected.txt:
- 7:13 PM Changeset in webkit [45235] by
-
- 22 edits7 deletes in branches/nitro-extreme/WebCore
Merged r44942:44943 into nitro-extreme branch.
- 7:12 PM Changeset in webkit [45234] by
-
- 2 edits in trunk/LayoutTests
2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Not reviewed. Skip another failing test due to lack of eventSender impl.
- platform/gtk/Skipped:
- 6:42 PM Changeset in webkit [45233] by
-
- 6 adds in branches/nitro-extreme/WebCore/html
Build fixes, mostly files not added.
- 6:38 PM Changeset in webkit [45232] by
-
- 2 edits in trunk/LayoutTests
2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Not reviewed. Skip failing gtk tests due to missing DRT features.
- platform/gtk/Skipped:
- 6:28 PM Changeset in webkit [45231] by
-
- 2 adds in branches/nitro-extreme/WebCore/dom
Build fixes, mostly files not added.
- 6:16 PM Changeset in webkit [45230] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-06-25 Simon Fraser <Simon Fraser>
Rubber-stamped by Dan Bernstein.
Add Windows-specific test results, since Windows does not have
3d transforms enabled.
- platform/win/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.txt.
- platform/win/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.txt.
- 6:08 PM Changeset in webkit [45229] by
-
- 1 edit in branches/nitro-extreme/WebCore/bindings/scripts/CodeGeneratorJS.pm
Build fix
- 6:06 PM Changeset in webkit [45228] by
-
- 9 edits in trunk
2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
Use flex box in the mediaControls.css style, to nicely scale if a button gets
dynamically added or removed.
Media tests results are affected by this changes.
- css/mediaControls.css:
- css/mediaControlsQT.css:
- 6:03 PM Changeset in webkit [45227] by
-
- 4 edits in trunk/WebKitLibraries
2009-06-25 Simon Fraser <Simon Fraser>
Rubber-stamped by Mark Rowe.
<rdar://problem/6999737>
Update the media controller images.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 5:58 PM Changeset in webkit [45226] by
-
- 57 edits19 copies2 adds in branches/nitro-extreme
Merged r44920:44942 into nitro-extreme branch.
- 5:50 PM Changeset in webkit [45225] by
-
- 64 edits17 copies4 deletes in branches/nitro-extreme
Merged r44889:44920 into nitro-extreme branch.
- 5:49 PM Changeset in webkit [45224] by
-
- 4 edits3 adds10 deletes in trunk/LayoutTests
2009-06-25 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.
- editing/execCommand/5432254-2-expected.txt: Added.
- editing/execCommand/5432254-2.html:
- editing/execCommand/5700414-1-expected.txt: Added.
- editing/execCommand/5700414-1.html:
- editing/execCommand/5700414-2-expected.txt: Added.
- editing/execCommand/5700414-2.html:
- platform/mac/editing/execCommand/5432254-2-expected.checksum: Removed.
- platform/mac/editing/execCommand/5432254-2-expected.png: Removed.
- platform/mac/editing/execCommand/5432254-2-expected.txt: Removed.
- platform/mac/editing/execCommand/5700414-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/5700414-1-expected.png: Removed.
- platform/mac/editing/execCommand/5700414-1-expected.txt: Removed.
- platform/mac/editing/execCommand/5700414-2-expected.checksum: Removed.
- platform/mac/editing/execCommand/5700414-2-expected.png: Removed.
- platform/mac/editing/execCommand/5700414-2-expected.txt: Removed.
- platform/qt/editing/execCommand/5432254-2-expected.txt: Removed.
- 5:34 PM Changeset in webkit [45223] by
-
- 8 edits in branches/nitro-extreme/JavaScriptCore
Merged r44888:44889 into nitro-extreme branch.
- 5:28 PM Changeset in webkit [45222] by
-
- 15 edits in branches/nitro-extreme
Merged r44884:44888 into nitro-extreme branch.
- 5:26 PM Changeset in webkit [45221] by
-
- 2 edits in trunk/WebKitSite
2009-06-24 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
- demos/index.html: Fix more typos etc.
- 5:24 PM Changeset in webkit [45220] by
-
- 4 edits in trunk/WebKit/qt
2009-06-25 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Treat.
Add highlight functionality to the QWebPage::findText() method. Introduced is
new HighlightAllOccurrences flag which passed to the function will make it mark
all existing occurrences of specified string in the page.
- Api/qwebpage.cpp: (QWebPage::findText):
- Api/qwebpage.h:
- Api/qwebview.cpp:
- 5:22 PM Changeset in webkit [45219] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-06-25 Duy Nguyen <pclouds@gmail.com>
Rubber-stamped by Jan Alonzo.
Gtk port Vietnamese translation
https://bugs.webkit.org/show_bug.cgi?id=26739
- vi.po: Added.
- 5:22 PM Changeset in webkit [45218] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
Merged r44883:44884 into nitro-extreme branch.
- 5:16 PM Changeset in webkit [45217] by
-
- 103 edits23 copies4 deletes in branches/nitro-extreme
Merged r44844:44883 into nitro-extreme branch.
- 5:07 PM Changeset in webkit [45216] by
-
- 11 edits in branches/nitro-extreme/JavaScriptCore
Merged r44843:44844 into nitro-extreme branch.
- 4:58 PM Changeset in webkit [45215] by
-
- 5 edits in trunk/WebCore
2009-06-25 Albert J. Wong <ajwong@chromium.org>
Reviewed by Darin Fisher.
Move relavent part of setDefaultFontSize from RenderThemeChromiumWin
up into RenderThemeChromiumSkia.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::setDefaultFontSize):
- rendering/RenderThemeChromiumSkia.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::setDefaultFontSize):
- rendering/RenderThemeChromiumWin.h:
- 4:54 PM Changeset in webkit [45214] by
-
- 3 edits in trunk/WebKit/mac
2009-06-25 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6989017>
REGRESSION (SnowLeopard): RealPlayer content replays when opening a new tab or switching back to the RealPlayer tab
If a plug-in fails in NPP_New, we would try to recreate it whenever the preferences for a web view would change.
Fix this by setting a flag when we fail to instantiate the plug-in, so we only try once.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView start]):
- 4:49 PM Changeset in webkit [45213] by
-
- 11 edits16 copies in branches/nitro-extreme
Merged r44838:44843 into nitro-extreme branch.
- 4:45 PM Changeset in webkit [45212] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Optimize x++ to ++x inside for loops.
Sadly, no measurable speedup, but this should help with result chaining.
- parser/Nodes.cpp: (JSC::ForNode::emitBytecode):
- 4:39 PM Changeset in webkit [45211] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
Merged r44837:44838 into nitro-extreme branch.
- 4:36 PM Changeset in webkit [45210] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Mark Rowe.
bugzilla-tool apply-patch throws exception in Linux
https://bugs.webkit.org/show_bug.cgi?id=26738
HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
the scm module.
- Scripts/modules/scm.py:
- 4:24 PM Changeset in webkit [45209] by
-
- 111 edits36 copies44 deletes in branches/nitro-extreme
Merged r44796:44837 into nitro-extreme branch.
- 4:21 PM Changeset in webkit [45208] by
-
- 3 edits in trunk/WebCore
2009-06-25 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Add V8-only methods to FrameLoaderClient that V8 can use to send
out notifications when it creates/destroys a script context.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didCreateScriptContext): (WebCore::EmptyFrameLoaderClient::didDestroyScriptContext):
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::didCreateScriptContext): (WebCore::FrameLoaderClient::didDestroyScriptContext):
- 4:11 PM Changeset in webkit [45207] by
-
- 2 edits in trunk/WebCore
2009-06-25 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
Correct a few typos that snuck in when I was reformatting CodeGeneratorV8.pm
to match WebKit style.
- bindings/scripts/CodeGeneratorV8.pm: Corrected lots of typos.
- 3:42 PM Changeset in webkit [45206] by
-
- 3 edits in branches/nitro-extreme/WebCore
Build fix, revert part of last build fix.
- 3:37 PM Changeset in webkit [45205] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_bitnot): (JSC::JIT::emit_op_post_inc):
- 3:35 PM Changeset in webkit [45204] by
-
- 4 edits in trunk
Some cosmetic fixes I missed in my last checkin
- 3:32 PM Changeset in webkit [45203] by
-
- 2 edits in trunk/WebCore
2009-06-25 Adam Langley <agl@google.com>
TBRed: fix for Chromium tree.
Add missing include for r45199.
r45199 added a reference to throwError without including V8Proxy.h
- bindings/v8/WorkerScriptController.cpp:
- 3:16 PM Changeset in webkit [45202] by
-
- 3 edits9 adds in branches/nitro-extreme
Build fixes, mostly files not added.
- 3:13 PM Changeset in webkit [45201] by
-
- 2 edits in trunk/WebCore
2009-06-25 Adam Langley <agl@google.com>
TBRed: fix for Chromium tree.
Fix V8IsolatedWorld to point to the correct include file.
The deprecated v8_index.h was removed from the Chromium tree in r19291
and upstreamed into WebKit with r45193. However V8IsolatedWorld
slipped in between the cracks and broke the build.
- bindings/v8/V8IsolatedWorld.h: update with new header location.
- 3:09 PM Changeset in webkit [45200] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec):
- 3:03 PM Changeset in webkit [45199] by
-
- 16 edits in trunk
Preference is named "WebKitAcceleratedCompositingEnabled"
and is a boolean value. When false, prevents compositing layers from
being created, which prevents hardware animation from running.
Also forces video to do software rendering. Added a cache for
the flag in RenderLayerCompositing and made it all work
on-the-fly when the flag is changed while a page is loaded.
- 2:54 PM Changeset in webkit [45198] by
-
- 2 edits in trunk/WebCore
2009-06-25 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 26701: Implement the missing code for "FIXME: Need to return an
exception" in WorkerScriptController::evaluate for v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=26701
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
- 2:52 PM Changeset in webkit [45197] by
-
- 3 edits in trunk/WebKitTools
2009-06-25 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Call WebKitTools/Scripts scripts by their absolute paths
https://bugs.webkit.org/show_bug.cgi?id=26704
bugzilla-tool used to use whatever build-webkit was in your path.
That could end up building the wrong copy of WebKit.
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 2:51 PM Changeset in webkit [45196] by
-
- 1 copy in tags/Safari-6530.19.1
New tag.
- 2:44 PM Changeset in webkit [45195] by
-
- 2 edits in branches/WWDC-2009-branch/JavaScriptCore
2009-06-24 Mark Rowe <mrowe@apple.com>
Merge r44117.
2009-05-24 Steve Falkenburg <sfalken@apple.com>
Build fix for experimental PGO Windows target.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 2:42 PM Changeset in webkit [45194] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emitSlow_op_negate):
- jit/JITCall.cpp: (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emitSlow_op_construct_verify):
- 2:39 PM Changeset in webkit [45193] by
-
- 2 edits1 add in trunk/WebCore
2009-06-25 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Upstream V8Index.
- bindings/v8/V8Index.cpp: Added. (WebCore::V8ClassIndex::GetFactory): Moved from src.chromium.org. (WebCore::V8ClassIndex::GetCache): Moved from src.chromium.org.
- bindings/v8/V8Index.h: (WebCore::V8ClassIndex::): Moved from src.chromium.org. (WebCore::V8ClassIndex::ToInt): Moved from src.chromium.org. (WebCore::V8ClassIndex::FromInt): Moved from src.chromium.org.
- 2:26 PM Changeset in webkit [45192] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Dave Levin.
Use unicode() instead of str when reading from bugzilla.
Also add Simon Fraser as a reviewer.
https://bugs.webkit.org/show_bug.cgi?id=26719
- Scripts/modules/bugzilla.py:
- 2:15 PM Changeset in webkit [45191] by
-
- 3 edits in trunk/WebCore
2009-06-25 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
This is hopefully the last step before our renderers can run
cleanly in a chroot.
WebKit needs to be able to ask for the correct font to use in
the case that the current font doesn't include glyphs for
certain code points. Currently we make a fontconfig call in our
WebKit port to handle this.
This patch changes this so that the call is sent our via
ChromiumBridge.
This should not affect any layout tests.
- platform/chromium/ChromiumBridge.h:
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
- 2:02 PM Changeset in webkit [45190] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_true): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
- 1:34 PM Changeset in webkit [45189] by
-
- 1 edit4 adds in trunk/WebCore
2009-06-25 Albert J. Wong <ajwong@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26566
Upstream these files from the chromium v8 code. No tests were
affected because this is essentially a code move.
- bindings/v8/NPV8Object.cpp: Added. (allocV8NPObject): (freeV8NPObject): (listFromVariantArgs): (npIdentifierToV8Identifier): (npCreateV8ScriptObject): (NPN_Invoke): (NPN_InvokeDefault): (NPN_Evaluate): (NPN_EvaluateHelper): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty): (NPN_HasProperty): (NPN_HasMethod): (NPN_SetException): (NPN_Enumerate): (NPN_Construct):
- bindings/v8/NPV8Object.h: Added. (PrivateIdentifier::):
- bindings/v8/V8NPUtils.cpp: Added. (convertV8ObjectToNPVariant): (convertNPVariantToV8Object): (getStringIdentifier):
- bindings/v8/V8NPUtils.h: Added.
- 1:34 PM Changeset in webkit [45188] by
-
- 3 edits3 adds in trunk
WebCore:
2009-06-25 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dimitri Glazkov.
Windows Chromium bug fix: save context of destination canvas in
TransparencyWin::compositeTextComposite() before the function
modifies the context.
Test: fast/canvas/translate-text.html
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite):
LayoutTests:
2009-06-25 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dimitri Glazkov.
Windows Chromium bug fix: save context of destination canvas in
TransparencyWin::compositeTextComposite() before the function
modifies the context.
- fast/canvas/resources/translate-text.js: Added. (description.pixelValueAt): (pixelToString): (pixelShouldBe):
- fast/canvas/translate-text-expected.txt: Added.
- fast/canvas/translate-text.html: Added.
- 1:34 PM Changeset in webkit [45187] by
-
- 2 edits in trunk/LayoutTests
2009-06-25 Takeshi Yoshino <tyoshino@google.com>
Reviewed by David Levin.
Bug 26207: Rebaseline the expected image for fast/forms/select-style.html for Mac.
https://bugs.webkit.org/show_bug.cgi?id=26207
Replace the expected image for fast/forms/select-style-expected.html for
Mac which need to be rebaselined due to r43903
(http://trac.webkit.org/changeset/43903).
- platform/mac/fast/forms/select-style-expected.png:
- 1:34 PM Changeset in webkit [45186] by
-
- 3 edits1 add in trunk/WebCore
2009-06-25 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Show the filename and first line for "(program)" in the Profiler/Debugger
https://bugs.webkit.org/show_bug.cgi?id=25475
Add support to associate a sourceURL with an eval()'d string
via a @sourceURL comment. Currently the sourceURL is only available
in the script debugger, not in the console or profiler, but it's
most needed in the script debugger.
- English.lproj/localizedStrings.js: added new "(program): %s" string
- inspector/front-end/Script.js: (WebInspector.Script): if no sourceURL is available for the Script, search for a comment of the form @ sourceURL=(url) to use as the sourceURL instead.
- manual-tests/inspector/named-evals.html: Added.
- 1:34 PM Changeset in webkit [45185] by
-
- 7 edits2 adds in trunk
WebCore:
2009-06-25 John Gregg <johnnyg@google.com>
Reviewed by Sam Weinig.
Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
https://bugs.webkit.org/show_bug.cgi?id=23721
onchange events fire when a SELECT element has
focus and the selectedIndex is updated by script in some way--either
during another onchange, onkeypress, onfocus, or timer--and then
focus is lost.
Fixed by making a separate method for user-driven selectedIndex
changes, leaving scripts to use one which doesn't cause onchange to
be queued.
Test: fast/forms/select-script-onchange.html
- dom/SelectElement.cpp: check if the pending change is user driven before calling onchange (WebCore::SelectElement::menuListOnChange): (WebCore::SelectElement::setSelectedIndex):
- dom/SelectElement.h: store whether the pending change is user driven (WebCore::SelectElementData::userDrivenChange): (WebCore::SelectElementData::setUserDrivenChange):
- html/HTMLSelectElement.cpp: split into two methods -- script version [non-user-driven] corresponds to IDL defined property name (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::setSelectedIndexByUser):
- html/HTMLSelectElement.h:
- rendering/RenderMenuList.cpp: use ByUser method when coming through the renderer (WebCore::RenderMenuList::valueChanged):
LayoutTests:
2009-06-25 John Gregg <johnnyg@google.com>
Reviewed by Sam Weinig.
Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
https://bugs.webkit.org/show_bug.cgi?id=23721
Check for unnecessary calls to onchange in response to script
actions.
- fast/forms/select-script-onchange-expected.txt: Added.
- fast/forms/select-script-onchange.html: Added.
- 1:10 PM Changeset in webkit [45184] by
-
- 4 edits in tags/Safari-6531.1
Versioning.
- 1:02 PM Changeset in webkit [45183] by
-
- 14 edits4 deletes in trunk/WebCore
2009-06-25 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Combined LocalStorageArea and SessionStorageArea into StorageArea since
(after my other refactorings) there are no longer substantial
differences between the two.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
- storage/LocalStorage.h:
- storage/LocalStorageArea.cpp: Removed.
- storage/LocalStorageArea.h: Removed.
- storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
- storage/SessionStorage.h:
- storage/SessionStorageArea.cpp: Removed.
- storage/SessionStorageArea.h: Removed.
- storage/StorageArea.cpp: (WebCore::StorageArea::createLocalStorage): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::createSessionStorage): (WebCore::StorageArea::copy): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::scheduleFinalSync): (WebCore::StorageArea::blockUntilImportComplete): (WebCore::StorageArea::dispatchStorageEvent):
- storage/StorageArea.h:
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
- storage/StorageAreaSync.h:
- storage/StorageSyncManager.h:
- 12:50 PM Changeset in webkit [45182] by
-
- 4 edits in trunk
Versioning.
- 12:48 PM Changeset in webkit [45181] by
-
- 1 copy in tags/Safari-6531.1
New tag.
- 12:45 PM Changeset in webkit [45180] by
-
- 5 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=26671 <rdar://problem/7001880> Safari 4.0 crashes in WebCore::DOMTimer::fired()
Test: fast/dom/style-sheet-candidate-remove-unrendered-document.html
When a "style sheet candidate" element is removed from a document,
call Document::removeStyleSheetCandidateNode() regardless of whether
the document is rendered. Otherwise, the document's style sheet
candidate set can end up containing stale references.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::removedFromDocument):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::removedFromDocument):
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::removedFromDocument):
LayoutTests:
Reviewed by Darin Adler.
- test for https://bugs.webkit.org/show_bug.cgi?id=26671 <rdar://problem/7001880> Safari 4.0 crashes in WebCore::DOMTimer::fired()
- fast/dom/style-sheet-candidate-remove-unrendered-document-expected.txt: Added.
- fast/dom/style-sheet-candidate-remove-unrendered-document.html: Added.
- 11:53 AM Changeset in webkit [45179] by
-
- 2 edits in trunk/WebCore
2009-06-25 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
Update CodeGeneratorV8.pm to sync up with the changes downstream.
- bindings/scripts/CodeGeneratorV8.pm: Added HTMLFrameSetElement check, FileList as a ref-counted type, and DataGridColumn as typeCanFailConversion.
- 11:14 AM Changeset in webkit [45178] by
-
- 2 edits in trunk
Credit the correct reviewer.
- 10:23 AM Changeset in webkit [45177] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig (sort of, maybe).
Fixed some ASSERTs in http/tests/security.
These ASSERTs were introduced by http://trac.webkit.org/changeset/45057,
but the underlying problem was actually older. http://trac.webkit.org/changeset/45057
just exposed the problem by enabling optimization in more cases.
The ASSERTs fired because we tested PropertySlot::slotBase() for validity,
but slotBase() ASSERTs if it's invalid, so we would ASSERT before
the test could happen. Solution: Remove the ASSERT. Maybe it was valid
once, but it clearly goes against a pattern we've deployed of late.
The underlying problem was that WebCore would re-use a PropertySlot in
the case of a forwarding access, and the second use would not completely
overwrite the first use. Solution: Make sure to overwrite m_offset when
setting a value on a PropertySlot. (Other values already get implicitly
overwritten during reuse.)
- runtime/PropertySlot.h: (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setRegisterSlot): (JSC::PropertySlot::setUndefined): (JSC::PropertySlot::slotBase): (JSC::PropertySlot::clearOffset):
- 9:08 AM ProjectVision edited by
- (diff)
- 9:03 AM QtWebKit edited by
- (diff)
- 9:00 AM QtWebKitContrib edited by
- (diff)
- 8:54 AM QtWebKitGitInstructions edited by
- (diff)
- 8:50 AM Changeset in webkit [45176] by
-
- 2 edits in trunk/WebCore
2009-06-25 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Add FileList.h include to fix Chromium build.
- platform/chromium/ClipboardChromium.cpp: Added FileList.h include.
- 8:48 AM UsingGitWithWebKit edited by
- (diff)
- 8:46 AM UsingGitWithWebKit edited by
- (diff)
- 8:46 AM UsingGitWithWebKit edited by
- (diff)
- 8:37 AM UsingGitWithWebKit edited by
- Make this more explicit. (diff)
- 6:14 AM Changeset in webkit [45175] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT
The WTFReportAssertionFailure function in JSC is not exported when
building QtWebKit in both debug and release on Mac, so DRT fails to
link.
We can revert this patch once the Qt port builds JSC as a separate
library, and we add the proper export macros to Assertions.cpp
- DumpRenderTree/qt/WorkQueue.cpp: (WorkQueue::queue): (WorkQueue::dequeue):
- 6:11 AM Changeset in webkit [45174] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Jan Alonzo.
bugzilla-tool: Add Simon Hausmann as reviewer
- Scripts/modules/bugzilla.py:
- 5:42 AM Changeset in webkit [45173] by
-
- 3 edits in trunk/WebCore
2009-06-25 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Jan Alonzo.
Bug 26489: Web Inspector: Typo in DatabaseQuery Error Message
https://bugs.webkit.org/show_bug.cgi?id=26489
Fixed a Typo in a Web Inspector error message.
- English.lproj/localizedStrings.js:
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryError):
- 4:11 AM Changeset in webkit [45172] by
-
- 2 edits in trunk/WebCore
2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build, add missing StorageAreaSync files to the build.
- WebCore.pro:
- 3:56 AM Changeset in webkit [45171] by
-
- 2 edits in trunk/WebCore
2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by and done with Tor Arne Vestbø.
Fix shortcut keyboard handling with plugins on the Qt/Mac build.
When we receive shortcut events like Ctrl+V then the text in the QKeyEvent is
empty. If we're asked to disambiguate the event into a Char keyboard event,
we try to detect this situation and still set the text, to ensure that the
general event handling sends a key press event after this disambiguation.
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
- 3:05 AM Changeset in webkit [45170] by
-
- 4 edits in trunk/LayoutTests
2009-06-25 Eric Seidel <eric@webkit.org>
No review, just skipping a new test.
Skip new test on platforms missing eventSender.beginDragWithFiles
Test: http/tests/security/clipboard/clipboard-file-access.html
https://bugs.webkit.org/show_bug.cgi?id=25916
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 2:49 AM Changeset in webkit [45169] by
-
- 5 edits in trunk/WebCore
2009-06-25 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Add FileList.h and NotImplemented.h includes in an attempt to fix bots.
- platform/gtk/ClipboardGtk.cpp:
- platform/qt/ClipboardQt.cpp:
- platform/win/ClipboardWin.cpp:
- platform/wx/ClipboardWx.cpp:
- 2:24 AM Changeset in webkit [45168] by
-
- 16 edits8 adds in trunk
2009-06-24 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
- test for <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing
- fast/replaced/image-map-2-expected.txt: Added.
- fast/replaced/image-map-2.html: Added.
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
Expose files in the clipboard in ondrop events
https://bugs.webkit.org/show_bug.cgi?id=25916
Make it possible for applications like gmail to implement
drag and drop of attachments onto email messages.
This patch exposes an event.dataTransfer.files accessor
on the drop event. No information is exposed during dragover.
This follows the HTML 5 drag and drop security model:
http://www.w3.org/TR/html5/editing.html#security-risks-in-the-drag-and-drop-model
The test http/tests/security/clipboard/clipboard-file-access.html
verifies this behavior.
Internet Explorer shows historical documentation of supporting
getData('File') as a way of exposing files on the pasteboard. The current version of their docs:
http://msdn.microsoft.com/en-us/library/ms537658(VS.85).aspx
has removed this reference (as far as I can tell IE never implemented it)
I have a printed copy of that URL from 2008 on my desk describing getData('File') in IE.
IE does not follow the HTML5 clipboard security model and always allows access to the full clipboard, even on dragover.
I choose not to use IE's getData('File') and instead added .files
so that the accessor could have a type, matching WebKit's existing
.files accessor on HTMLInputElement.
Mozilla has equivalent file access:
event.dataTransfer.mozGetDataAt("application/x-moz-file", 0);
which also does not return a typed value.
https://developer.mozilla.org/En/DragDrop/Recommended_Drag_Types#Dragging_Files
This is only implemented for Mac WebKit. All other platforms (including Apple's Win WebKit)
have incomplete Clipboard implementations and will require experts from those platforms
to add this functionality. Right now they all have Clipboard*::files() methods which call notImplemented();
Test: http/tests/security/clipboard/clipboard-file-access.html
- dom/Clipboard.h:
- dom/Clipboard.idl:
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::files):
- platform/chromium/ClipboardChromium.h:
- platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::files):
- platform/gtk/ClipboardGtk.h:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm: (WebCore::absoluteURLsFromPasteboardFilenames): (WebCore::absoluteURLsFromPasteboard): (WebCore::ClipboardMac::files):
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::files):
- platform/qt/ClipboardQt.h:
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files):
- platform/win/ClipboardWin.h:
- platform/wx/ClipboardWx.cpp: (WebCore::ClipboardWx::files):
- platform/wx/ClipboardWx.h:
- 1:51 AM Changeset in webkit [45167] by
-
- 4 edits in branches/nitro-extreme
Merged r44794:44796 into nitro-extreme branch.
- 1:41 AM Changeset in webkit [45166] by
-
- 151 edits2 copies in branches/nitro-extreme
Merged r44747:44794 into nitro-extreme branch.
- 1:27 AM Changeset in webkit [45165] by
-
- 1 edit4 adds in trunk/WebCore
2009-06-25 Eric Seidel <eric@webkit.org>
No review, only completing revert of r45144.
Add back files deleted by r45144.
- storage/LocalStorageArea.cpp: Added. (WebCore::LocalStorageArea::create): (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::itemChanged): (WebCore::LocalStorageArea::itemRemoved): (WebCore::LocalStorageArea::areaCleared): (WebCore::LocalStorageArea::blockUntilImportComplete): (WebCore::LocalStorageArea::dispatchStorageEvent):
- storage/LocalStorageArea.h: Added.
- storage/SessionStorageArea.cpp: Added. (WebCore::SessionStorageArea::copy): (WebCore::SessionStorageArea::SessionStorageArea): (WebCore::SessionStorageArea::itemChanged): (WebCore::SessionStorageArea::itemRemoved): (WebCore::SessionStorageArea::areaCleared): (WebCore::SessionStorageArea::blockUntilImportComplete): (WebCore::SessionStorageArea::dispatchStorageEvent):
- storage/SessionStorageArea.h: Added. (WebCore::SessionStorageArea::create):
- 1:26 AM Changeset in webkit [45164] by
-
- 6 edits in branches/nitro-extreme
Merged r44743:44747 into nitro-extreme branch.
- 1:22 AM Changeset in webkit [45163] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
Merged r44742:44743 into nitro-extreme branch.
- 1:19 AM Changeset in webkit [45162] by
-
- 14 edits in trunk/WebCore
2009-06-25 Eric Seidel <eric@webkit.org>
No review, reverting r45144 only.
Roll out r45144 after 18 test failures appeared on the bots.
https://bugs.webkit.org/show_bug.cgi?id=26698
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
- storage/LocalStorage.h:
- storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
- storage/SessionStorage.h:
- storage/StorageArea.cpp: (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::~StorageArea): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear):
- storage/StorageArea.h:
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
- storage/StorageAreaSync.h:
- storage/StorageSyncManager.h:
- 1:17 AM Changeset in webkit [45161] by
-
- 56 edits47 copies14 deletes in branches/nitro-extreme
Merged r44712:44742 into nitro-extreme branch.
- 1:09 AM Changeset in webkit [45160] by
-
- 4 edits in trunk/WebKitTools
2009-06-24 Eric Seidel <eric@webkit.org>
Reviewed by Dave Levin.
Support local commits during apply-patches
and let land-patches take multiple bug ids.
https://bugs.webkit.org/show_bug.cgi?id=26703
I also restructured parts of land-patches into
class methods and static methods in preparation
for future code sharing with other commands.
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- Scripts/modules/scm.py:
- 1:09 AM Changeset in webkit [45159] by
-
- 18 edits1 copy in branches/nitro-extreme
Merged r44710:44712 into nitro-extreme branch.
- 1:03 AM Changeset in webkit [45158] by
-
- 11 edits in branches/nitro-extreme/WebCore
Merged r44705:44710 into nitro-extreme branch.
- 1:01 AM Changeset in webkit [45157] by
-
- 11 edits in branches/nitro-extreme/JavaScriptCore
Merged r44704:44705 into nitro-extreme branch.
- 12:56 AM Changeset in webkit [45156] by
-
- 2 adds in branches/nitro-extreme/JavaScriptCore/runtime
Build-fix, had failed to add JSONObject.cpp/.h.
- 12:52 AM Changeset in webkit [45155] by
-
- 19 edits in branches/nitro-extreme
Merged r44700:44704 into nitro-extreme branch.
- 12:49 AM Changeset in webkit [45154] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
Merged r44699:44700 into nitro-extreme branch.
- 12:45 AM Changeset in webkit [45153] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Eric Seidel <eric@webkit.org>
Reviewed by Tor Arne Vestbø.
Make svn-apply work with Git too
https://bugs.webkit.org/show_bug.cgi?id=26299
Add an --force option to svn-apply and otherwise make svn-apply
exit non-zero when patch application fails.
https://bugs.webkit.org/show_bug.cgi?id=26300
I did not update svn-unapply, because it makes no sense in a Git world.
You don't roll in and out patch files. You make commits and deal with those.
Git users can just git reset --hard to get the same functionality.
- Scripts/svn-apply:
- 12:42 AM Changeset in webkit [45152] by
-
- 3 edits in trunk/WebKitTools
2009-06-25 Eric Seidel <eric@webkit.org>
Reviewed by Tor Arne Vestbø.
Remove use of os.system to fix reviewers with unicode chars in their names
https://bugs.webkit.org/show_bug.cgi?id=26713
Also change to latin1 encoding of ø to make python happy.
- Scripts/modules/bugzilla.py:
- Scripts/modules/scm.py:
- 12:42 AM Changeset in webkit [45151] by
-
- 17 edits2 copies in branches/nitro-extreme
Merged r44693:44699 into nitro-extreme branch.
- 12:34 AM Changeset in webkit [45150] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
Merged r44692:44693 into nitro-extreme branch.
- 12:22 AM Changeset in webkit [45149] by
-
- 319 edits140 copies39 deletes in branches/nitro-extreme
Merged r44526:44692 into nitro-extreme branch.
- 12:07 AM Changeset in webkit [45148] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
Merged r44525:44526 into nitro-extreme branch.
- 12:06 AM Changeset in webkit [45147] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Eric Seidel <eric@webkit.org>
Reviewed by Tor Arne Vestbø.
Add Adam Roben and Tor Arne Vestbø to the reviewers list.
- Scripts/modules/bugzilla.py:
- 12:00 AM Changeset in webkit [45146] by
-
- 8 edits in branches/nitro-extreme
Merged r44523:44525 into nitro-extreme branch.
Jun 24, 2009:
- 11:56 PM Changeset in webkit [45145] by
-
- 8 edits in branches/nitro-extreme/JavaScriptCore
Merged r44520:44523 into nitro-extreme branch.
- 11:16 PM Changeset in webkit [45144] by
-
- 14 edits4 deletes in trunk/WebCore
2009-06-24 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Combined LocalStorageArea and SessionStorageArea into StorageArea since
(after my other refactorings) there are no longer substantial
differences between the two.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
- storage/LocalStorage.h:
- storage/LocalStorageArea.cpp: Removed.
- storage/LocalStorageArea.h: Removed.
- storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
- storage/SessionStorage.h:
- storage/SessionStorageArea.cpp: Removed.
- storage/SessionStorageArea.h: Removed.
- storage/StorageArea.cpp: (WebCore::StorageArea::createLocalStorage): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::createSessionStorage): (WebCore::StorageArea::copy): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::scheduleFinalSync): (WebCore::StorageArea::blockUntilImportComplete): (WebCore::StorageArea::dispatchStorageEvent):
- storage/StorageArea.h:
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
- storage/StorageAreaSync.h:
- storage/StorageSyncManager.h:
- 10:01 PM Changeset in webkit [45143] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- fix <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing
Test: fast/replaced/image-map-2.html
- rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Do not reset 'inside' to false if the image map failed the hit test.
LayoutTests:
Reviewed by Simon Fraser.
- test for <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing
- fast/replaced/image-map-2-expected.txt: Added.
- fast/replaced/image-map-2.html: Added.
- 8:41 PM Changeset in webkit [45142] by
-
- 34 edits11 copies6 deletes in branches/nitro-extreme
Merged r44514:44520 into nitro-extreme branch.
- 8:34 PM Changeset in webkit [45141] by
-
- 8 edits2 copies in branches/nitro-extreme/JavaScriptCore
Merged r44513:44514 into nitro-extreme branch.
- 8:30 PM Changeset in webkit [45140] by
-
- 53 edits8 copies3 deletes in branches/nitro-extreme
Merged r44492:44513 into nitro-extreme branch.
- 8:18 PM Changeset in webkit [45139] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
Merged r44491:44492 into nitro-extreme branch.
- 8:07 PM Changeset in webkit [45138] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-24 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Make the opcode sampler work once again.
- jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compileCTIMachineTrampolines): (JSC::JIT::compilePatchGetArrayLength):
- jit/JITStubCall.h: (JSC::JITStubCall::call):
- 8:06 PM Changeset in webkit [45137] by
-
- 80 edits4 copies1 delete in branches/nitro-extreme
Merged r44460:44491 into nitro-extreme branch.
- 8:00 PM Changeset in webkit [45136] by
-
- 12 edits in branches/nitro-extreme
Merged r44455:44460 into nitro-extreme branch.
- 7:56 PM Changeset in webkit [45135] by
-
- 13 edits in branches/nitro-extreme/JavaScriptCore
Merged r44454:44455 into nitro-extreme branch.
- 7:38 PM Changeset in webkit [45134] by
-
- 5 edits2 adds in trunk/WebCore
2009-06-22 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Refactor V8DOMMap to support isolated worlds.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluateInNewWorld):
- bindings/v8/ScriptController.h:
- bindings/v8/V8DOMMap.cpp: (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap): (WebCore::DOMDataStore::allStores): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::domData): (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore): (WebCore::StaticDOMDataStore::StaticDOMDataStore): (WebCore::): (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getStore): (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore): (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStoreHandle::DOMDataStoreHandle): (WebCore::DOMDataStoreHandle::~DOMDataStoreHandle): (WebCore::::forget): (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap): (WebCore::DOMData::getCurrent): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::ensureDeref): (WebCore::weakDOMObjectCallback): (WebCore::weakActiveDOMObjectCallback): (WebCore::weakNodeCallback): (WebCore::weakSVGElementInstanceCallback): (WebCore::weakSVGObjectWithContextCallback): (WebCore::DOMData::derefObject): (WebCore::DOMData::derefDelayedObjects): (WebCore::DOMData::derefDelayedObjectsInCurrentThread): (WebCore::DOMData::removeObjectsFromWrapperMap): (WebCore::removeAllDOMObjectsInCurrentThreadHelper): (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread): (WebCore::visitSVGObjectsInCurrentThread):
- bindings/v8/V8DOMMap.h: (WebCore::DOMDataStoreHandle::getStore):
- bindings/v8/V8IsolatedWorld.cpp: Added. (WebCore::getIsolatedWorldKey): (WebCore::contextWeakReferenceCallback): (WebCore::V8IsolatedWorld::evaluate): (WebCore::V8IsolatedWorld::V8IsolatedWorld): (WebCore::V8IsolatedWorld::~V8IsolatedWorld): (WebCore::V8IsolatedWorld::getEntered):
- bindings/v8/V8IsolatedWorld.h: Added. (WebCore::V8IsolatedWorld::getDOMDataStore):
- 7:06 PM Changeset in webkit [45133] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 7:04 PM Changeset in webkit [45132] by
-
- 1 copy in tags/Safari-6530.19
New tag.
- 6:52 PM Changeset in webkit [45131] by
-
- 2 edits in trunk/WebCore
2009-06-24 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Bug 26604: Search doesn't work in Web Inspector Profiler
https://bugs.webkit.org/show_bug.cgi?id=26604
Seems like search was damaged in revision 42808.
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.prototype.refresh): Here and in other functions: nodes we're searching in are profile data grid nodes, so there is no more need for '_dataGridNode' references. (WebInspector.ProfileView.prototype.searchCanceled): (WebInspector.ProfileView.prototype.performSearch.matchesQuery): Fixed accidental semicolon that caused 'matchesQuery' always return true. (WebInspector.ProfileView.prototype.performSearch): To perform search correctly in the case of bottom up tree, we need to populate the tree, because there's no 1-to-1 correspondence between profile nodes and data grid nodes in this case. (WebInspector.ProfileView.prototype._jumpToSearchResult):
- 6:32 PM Changeset in webkit [45130] by
-
- 5 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Extend FastAllocBase.h with 'using WTF::FastAllocBase' to avoid
- unnecessary WTF
- usings.
- Remove existing unnecessary WTF
- usings.
- interpreter/Interpreter.h:
- profiler/CallIdentifier.h:
- runtime/ScopeChain.h:
- wtf/FastAllocBase.h:
- 6:07 PM Changeset in webkit [45129] by
-
- 2 edits in trunk/WebCore
2009-06-24 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
<rdar://problem/6450239&6574516>
Fix flashing issues caused by compositing layers rendering content before
a deferred layout has happened. Because the -viewWillDraw machinery doesn't
work for composited layers, we need to use scheduleViewUpdate() to queue
up a layout via the run loop observer in WebKit, whenever we know we
are going to be painting soon.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::setContentsNeedDisplay): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
- 5:45 PM Changeset in webkit [45128] by
-
- 5 edits1 add in trunk
2009-06-24 David Levin <levin@chromium.org>
Fix all builds.
- bytecode/CodeBlock.h:
- bytecompiler/BytecodeGenerator.h:
- interpreter/Register.h:
WebCore:
2009-06-24 David Levin <levin@chromium.org>
Fix all builds.
- ForwardingHeaders/wtf/FastAllocBase.h: Added.
- 5:42 PM Changeset in webkit [45127] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 5:25 PM Changeset in webkit [45126] by
-
- 64 edits11 copies1 delete in branches/nitro-extreme
Merged r44437:44454 into nitro-extreme branch.
- 5:20 PM Changeset in webkit [45125] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
Merged r44436:44437 into nitro-extreme branch.
- 4:56 PM Changeset in webkit [45124] by
-
- 16 edits2 copies in trunk/WebCore
2009-06-24 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Split the syncing portions of LocalStorageArea into StorageAreaSync.
This name will make more sense in the next patch (in this set) when
LocalStorageArea and SessionStorageArea are merged to become simply
StorageArea. (Thus the synching portion of StorageArea is in
StorageAreaSync.)
This looks like a big patch, but really all it's doing is splitting
code and patching split-related things up.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::create): (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::itemChanged): (WebCore::LocalStorageArea::itemRemoved): (WebCore::LocalStorageArea::areaCleared): (WebCore::LocalStorageArea::blockUntilImportComplete):
- storage/LocalStorageArea.h:
- storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask):
- storage/LocalStorageTask.h: (WebCore::LocalStorageTask::createImport): (WebCore::LocalStorageTask::createSync):
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync):
- storage/LocalStorageThread.h:
- storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::blockUntilImportComplete):
- storage/SessionStorageArea.h:
- storage/StorageArea.h:
- storage/StorageAreaSync.cpp: Copied from WebCore/storage/LocalStorageArea.cpp.
- storage/StorageAreaSync.h: Copied from WebCore/storage/LocalStorageArea.h.
- storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
- storage/StorageSyncManager.h:
- 4:55 PM Changeset in webkit [45123] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherits CodeBlock class from FastAllocBase because it
has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:217.
- bytecode/CodeBlock.h:
- 4:55 PM Changeset in webkit [45122] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherits BytecodeGenerator class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/parser/Nodes.cpp:1892.
- bytecompiler/BytecodeGenerator.h:
- 4:54 PM Changeset in webkit [45121] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherits Register class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSVariableObject.h:149.
- interpreter/Register.h:
- 4:53 PM Changeset in webkit [45120] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits HashMap class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:458.
- wtf/HashMap.h:
- 4:52 PM Changeset in webkit [45119] by
-
- 49 edits11 copies in branches/nitro-extreme
Merged r44412:44436 into nitro-extreme branch.
- 4:33 PM Changeset in webkit [45118] by
-
- 10 edits in branches/nitro-extreme/JavaScriptCore
Merged r44411:44412 into nitro-extreme branch.
- 4:32 PM Changeset in webkit [45117] by
-
- 2 edits in trunk/WebCore
2009-06-24 Adam Treat <adam.treat@torchmobile.com>
Fix Qt build.
- WebCore.pro:
- 4:23 PM Changeset in webkit [45116] by
-
- 5 edits in branches/WWDC-2009-branch/WebCore
Merge r44877.
- 4:23 PM Changeset in webkit [45115] by
-
- 3 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r44845.
- 4:23 PM Changeset in webkit [45114] by
-
- 11 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r44844.
- 4:23 PM Changeset in webkit [45113] by
-
- 2 edits in branches/WWDC-2009-branch/LayoutTests
Merge r44262.
- 4:00 PM Changeset in webkit [45112] by
-
- 2 edits in trunk/WebKitTools
Windows build fix for fallout from
Bug 26668: AX: need a way to retrieve the language for an element
- 3:47 PM Changeset in webkit [45111] by
-
- 3 edits in trunk/WebCore
2009-06-24 David Levin <levin@chromium.org>
Reviewed by David Hyatt.
Bug 26696: Member functions in DataGridColumnList should return pointers instead of PassRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=26696
- html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::itemWithName): (WebCore::DataGridColumnList::add):
- html/DataGridColumnList.h: (WebCore::DataGridColumnList::item): (WebCore::DataGridColumnList::primaryColumn): (WebCore::DataGridColumnList::sortColumn):
- 3:19 PM Changeset in webkit [45110] by
-
- 18 edits in trunk/WebCore
2009-06-24 Sam Weinig <sam@webkit.org>
Reviewed by Dave "Messy" Hyatt.
Little bit of style cleanup.
- html/DataGridColumn.cpp:
- html/DataGridColumn.h:
- html/DataGridColumn.idl:
- html/DataGridColumnList.cpp:
- html/DataGridColumnList.h:
- html/DataGridColumnList.idl:
- html/HTMLDataGridCellElement.cpp:
- html/HTMLDataGridCellElement.h:
- html/HTMLDataGridCellElement.idl:
- html/HTMLDataGridColElement.cpp:
- html/HTMLDataGridColElement.h:
- html/HTMLDataGridColElement.idl:
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- html/HTMLDataGridRowElement.cpp:
- html/HTMLDataGridRowElement.h:
- html/HTMLDataGridRowElement.idl:
- 3:14 PM Changeset in webkit [45109] by
-
- 11 edits2 adds in trunk
Bug 26668: AX: need a way to retrieve the language for an element
https://bugs.webkit.org/show_bug.cgi?id=26668
- 3:12 PM Changeset in webkit [45108] by
-
- 132 edits31 copies6 deletes in branches/nitro-extreme
Merged r44350:44411 into nitro-extreme branch.
- 3:04 PM Changeset in webkit [45107] by
-
- 2 edits in trunk/WebCore
2009-06-24 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6893811> Instead of downloading files linked from Google Earth, file contents displayed in browser window as text.
- platform/network/mac/WebCoreURLResponse.mm: (createBinaryExtensionsSet): Add '.kmz' to the list of known-to-be-binary extensions.
- 3:01 PM Changeset in webkit [45106] by
-
- 6 edits3 adds in trunk
<rdar://problem/6940519> REGRESSION (Safari 4 Public Beta - TOT): google.com/adplanner shows blank page instead of site details in "basic research'
Reviewed by Darin Adler.
The problem was caused by the page returned with a function using a
var declaration list containing around ~3000 variables. The solution
to this is to flatten the comma expression representation and make
codegen comma expressions and initializer lists iterative rather than
recursive.
- 2:53 PM Changeset in webkit [45105] by
-
- 29 edits3 copies in branches/nitro-extreme
Merged r44340:44350 into nitro-extreme branch.
- 2:12 PM Changeset in webkit [45104] by
-
- 1 edit in trunk/WebKit/mac/ChangeLog
Rephrased change log
- 2:10 PM Changeset in webkit [45103] by
-
- 8 edits in trunk/WebCore
2009-06-24 Nicolas Weber <thakis@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26685
Accomodate for backwards-incompatible skia api changes.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setCompositeOperation):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::setupPaintCommon): (PlatformContextSkia::setXfermodeMode): (PlatformContextSkia::applyClipFromImage):
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/skia/SkiaUtils.cpp: (WebCore::): (WebCore::WebCoreCompositeToSkiaComposite):
- platform/graphics/skia/SkiaUtils.h:
- 2:05 PM Changeset in webkit [45102] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
Fix the most recently seen kind of crash seen in
<rdar://problem/5983224>
- WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Null-check the Frame.
- 2:01 PM Changeset in webkit [45101] by
-
- 1286 edits98 copies17 deletes in branches/nitro-extreme
Merged r44170:44340 into nitro-extreme branch.
- 1:51 PM Changeset in webkit [45100] by
-
- 2 edits in trunk/WebCore
2009-06-24 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix. Add files that were added in r45093 and r45096
- GNUmakefile.am:
- 1:36 PM Changeset in webkit [45099] by
-
- 242 edits60 copies9 deletes in branches/nitro-extreme
Merged r44076:44170 into nitro-extreme branch.
- 1:33 PM Changeset in webkit [45098] by
-
- 2 edits in trunk/WebCore
2009-06-24 Brady Eidson <beidson@apple.com>
Fix 64-bit SnowLeopard build.
- html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move):
- 1:15 PM Changeset in webkit [45097] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Enable JIT_OPTIMIZE_METHOD_CALLS on the branch, implementation matches current implemenatation in ToT.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::compileGetByIdSlowCase):
- 1:06 PM Changeset in webkit [45096] by
-
- 1 add in trunk/WebCore/bindings/js/JSDataGridColumnListCustom.cpp
Fix Mac build.
- 12:44 PM Changeset in webkit [45095] by
-
- 3 edits12 adds in trunk
Reviewed by Niko.
https://bugs.webkit.org/show_bug.cgi?id=26392
Bug 26392: In html, modification of xlink:href of an newly inserted svg image does not work.
https://bugs.webkit.org/show_bug.cgi?id=26328
Bug 26328: changing href attribute of svg images dows not work when changing display attribute as well
React to href updates even when there is no renderer, i.e. display=none.
Tests: svg/custom/js-update-image-and-display.svg
svg/custom/js-update-image-and-display2.svg
svg/custom/js-update-image-and-display3.svg
- 12:41 PM Changeset in webkit [45094] by
-
- 2 edits5 adds in trunk/LayoutTests
Add Windows test results for a couple of search field tests
- 12:22 PM Changeset in webkit [45093] by
-
- 16 edits8 adds in trunk
WebCore:
2009-06-24 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add basic back-end column support to datagrid.
Added fast/dom/HTMLDataGridElement/ column tests.
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/DataGridColumn.cpp: Added. (WebCore::DataGridColumn::setPrimary):
- html/DataGridColumn.h: Added. (WebCore::DataGridColumn::create): (WebCore::DataGridColumn::id): (WebCore::DataGridColumn::setId): (WebCore::DataGridColumn::label): (WebCore::DataGridColumn::setLabel): (WebCore::DataGridColumn::type): (WebCore::DataGridColumn::setType): (WebCore::DataGridColumn::sortable): (WebCore::DataGridColumn::setSortable): (WebCore::DataGridColumn::sortDirection): (WebCore::DataGridColumn::setSortDirection): (WebCore::DataGridColumn::primary): (WebCore::DataGridColumn::detachFromColumnList): (WebCore::DataGridColumn::DataGridColumn):
- html/DataGridColumn.idl: Added.
- html/DataGridColumnList.cpp: Added. (WebCore::DataGridColumnList::~DataGridColumnList): (WebCore::DataGridColumnList::itemWithName): (WebCore::DataGridColumnList::add): (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move): (WebCore::DataGridColumnList::clear): (WebCore::DataGridColumnList::primaryColumnChanged):
- html/DataGridColumnList.h: Added. (WebCore::DataGridColumnList::create): (WebCore::DataGridColumnList::length): (WebCore::DataGridColumnList::item): (WebCore::DataGridColumnList::primaryColumn): (WebCore::DataGridColumnList::sortColumn):
- html/DataGridColumnList.idl: Added.
- html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection):
- html/HTMLDataGridColElement.h:
- html/HTMLDataGridColElement.idl:
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement):
- html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::columns):
- html/HTMLDataGridElement.idl:
- rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::paintObject): (WebCore::RenderDataGrid::paintColumnHeaders): (WebCore::RenderDataGrid::rebuildColumns):
- rendering/RenderDataGrid.h: (WebCore::RenderDataGrid::gridElement):
LayoutTests:
2009-06-24 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add test for https://bugs.webkit.org/show_bug.cgi?id=26687.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt: Added.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic.html: Added.
- 12:14 PM Changeset in webkit [45092] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r44951.
- 12:13 PM Changeset in webkit [45091] by
-
- 4 edits in branches/WWDC-2009-branch
Merge r44941.
- 12:13 PM Changeset in webkit [45090] by
-
- 8 edits3 adds in branches/WWDC-2009-branch
Merge r44940.
- 12:13 PM Changeset in webkit [45089] by
-
- 3 edits3 adds in branches/WWDC-2009-branch
Merge r44908.
- 12:13 PM Changeset in webkit [45088] by
-
- 6 edits in branches/WWDC-2009-branch
Merge r44906.
- 10:29 AM Changeset in webkit [45087] by
-
- 3 edits1 add in trunk/WebCore
2009-06-24 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Partially fixes: https://bugs.webkit.org/show_bug.cgi?id=24735
(<rdar://problem/5015942>)
Where on windows it was not possible to set an element as the drag
image using setDragImage on the dataTransfer object.
Does not "fix" the case of dragging a link where the default link image
is still used, even when the -webkit-user-drag is set to "element". This
is the same behavior as is found on OS X.
Added a manual test because it is not possible to check that what is
contained in the image snapshot is indeed the requested element.
- dom/Clipboard.h: (WebCore::Clipboard::dragImageElement): Made getting the raw pointer from the RefPtr a const operation.
- manual-tests/drag-with-div-or-image-as-data-image.html: Added.
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::createDragImage): Get an image of the rendered element and its subtree.
- 9:48 AM Changeset in webkit [45086] by
-
- 2 edits1 add in trunk/WebCore
2009-06-24 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26683
Fix Chromium build bustage: Add custom binding for HTMLDataGridElement.dataSource
This change just adds a stub implementation for now to help fix the build.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Added.
- 8:53 AM Changeset in webkit [45085] by
-
- 2 edits in trunk/WebCore
Build fixes for ENABLE(PLUGIN_PROXY_FOR_VIDEO)
Reviewed by Adam Roben.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::deliverNotification): Removed ExceptionCode parameter from togglePlayState(). (WebCore::HTMLMediaElement::initialURL): Don't convert a KURL object to a String when assigning to a KURL variable.
- 8:44 AM Moving to Git edited by
- (diff)
- 8:00 AM Changeset in webkit [45084] by
-
- 13 edits in trunk/WebCore
Reviewed by Adam Treat.
Save memory by not storing attribute values in member variables, if not absolutely needed.
Also fixes bugs where we're substituting variables too early (noticeable with the upcoming <select> element).
- 7:35 AM Changeset in webkit [45083] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Forgot to initialize m_task member variable. Results in crashes sometimes.
- 7:34 AM Changeset in webkit [45082] by
-
- 1 edit1 add in trunk/WebCore
Not reviewed. Forgot to include within last patch.
- 7:30 AM Changeset in webkit [45081] by
-
- 5 edits in trunk/WebCore
Reviewed by Nikolas Zimmermann.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26474
Adding WML <card> title attribute handling.
- 7:02 AM Changeset in webkit [45080] by
-
- 3 edits in trunk/WebKit/gtk
2009-06-24 Jiahua Huang <jhuangjiahua@gmail.com>
Reviewed by Holger Freyther.
[Gtk] Add Undo/Redo support to WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=26573
Implement EditorClient::undo and other interested funcs.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::registerCommandForUndo): (WebKit::EditorClient::registerCommandForRedo): (WebKit::EditorClient::clearUndoRedoOperations): (WebKit::EditorClient::canUndo): (WebKit::EditorClient::canRedo): (WebKit::EditorClient::undo): (WebKit::EditorClient::redo): (WebKit::EditorClient::EditorClient):
- WebCoreSupport/EditorClientGtk.h:
- 3:00 AM Changeset in webkit [45079] by
-
- 3 edits in trunk/WebCore
2009-06-24 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix the build without ENABLE_VIDEO.
- html/CanvasRenderingContext2D.cpp: Add #if ENABLE guards.
- html/CanvasRenderingContext2D.h: Ditto.
- 2:26 AM Changeset in webkit [45078] by
-
- 1 edit1 move in trunk/LayoutTests
Temporarily disable failing test
- 1:56 AM Changeset in webkit [45077] by
-
- 4 edits in trunk/LayoutTests
2009-06-24 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Add new drag tests to the Skipped lists for non-mac platforms.
Skipped tests:
fast/events/drag-to-navigate.html
fast/events/prevent-drag-to-navigate.html
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:15 AM Changeset in webkit [45076] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherits ScopeChainNode class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/ScopeChain.h:95.
- wtf/RefPtr.h:
- 1:12 AM Changeset in webkit [45075] by
-
- 2 edits1 add in trunk/WebCore
2009-06-24 Siddhartha Chattopadhyay <sidchat@google.com>
Reviewed by Eric Seidel.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26200 which I introduced earlier. I had
the smartReplace set TRUE initially, which was wrong since the purpose of this call is
to just replace the selection, and place the caret at the end of the selection it replaced.
- editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition):
- manual-tests/textarea-caret-position-after-auto-spell-correct.html: Added.
- 1:00 AM Changeset in webkit [45074] by
-
- 2 edits in trunk/WebKit/mac
2009-06-24 Jeff Johnson <opendarwin@lapcatsoftware.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26638 WebKitErrors.m: _initWithPluginErrorCode: does not set localizedDescription
Add localized descriptions for plugin errors.
The localized strings already existed but were unused; now NSLocalizedDescriptionKey is added to the NSError userInfo.
- Misc/WebKitErrors.m: (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):
- 12:54 AM Changeset in webkit [45073] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits Deque class from FastAllocBase because it has been
instantiated by 'new' with DEFINE_STATIC_LOCAL macro in
JavaScriptCore/wtf/MainThread.cpp:62.
- wtf/Deque.h:
- 12:53 AM Changeset in webkit [45072] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits RefPtr class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/StructureChain.cpp:41.
- wtf/RefPtr.h:
- 12:52 AM Changeset in webkit [45071] by
-
- 2 edits in trunk/LayoutTests
Attempting to make test more reliable.
- 12:47 AM Changeset in webkit [45070] by
-
- 2 edits in trunk/WebCore
2009-06-24 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
Don't use an unsigned int for intervalInMS because we sometimes initialize
it with a negative value.
- platform/wx/SharedTimerWx.cpp: (WebCore::setSharedTimerFireTime):
- 12:45 AM Changeset in webkit [45069] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits HashSet class from FastAllocBase, because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.h:116.
- wtf/HashSet.h:
- 12:40 AM Changeset in webkit [45068] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits Vector class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:633.
- wtf/Vector.h:
- 12:34 AM Changeset in webkit [45067] by
-
- 2 edits in trunk/WebKitTools
2009-06-24 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
Spell Maciej's name right and add Brady Eidson.
- Scripts/modules/bugzilla.py:
- 12:26 AM Changeset in webkit [45066] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Maciej Stachoviak.
The BytecodeGenerator objects were instantiated on stack, which takes up ~38kB per instance
(each instance includes copy of JSC::CodeBlock with large SymbolTable, etc.).
Specifically, since there is nested invocation (e.g., GlobalCode --> FunctionCode),
the stack overflows immediately on Symbian hardware (max. 80 kB).
Proposed change allocates generator objects on heap.
Performance impact (if any) should be negligible and change is proposed as general fix,
rather than ifdef'd for SYMBIAN.
- parser/Nodes.cpp: (JSC::ProgramNode::generateBytecode): (JSC::EvalNode::generateBytecode): (JSC::EvalNode::bytecodeForExceptionInfoReparse): (JSC::FunctionBodyNode::generateBytecode): (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
- 12:20 AM Changeset in webkit [45065] by
-
- 2 edits in trunk/WebCore
2009-06-24 Eric Seidel <eric@webkit.org>
No review, build fix only.
The previous checkin had an improper merge. This fixes the build.
- page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
- 12:07 AM Changeset in webkit [45064] by
-
- 4 edits6 adds in trunk
2009-06-05 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=25922
Fix dropEffect = "none" to work as expected.
- fast/events/drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
- fast/events/drag-to-navigate.html: Added.
- fast/events/prevent-drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
- fast/events/prevent-drag-to-navigate.html: Added.
- fast/events/resources/file-for-drag-to-navigate.html: Added.
- fast/events/resources/file-for-prevent-drag-to-navigate.html: Added.
2009-06-05 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=25922
JS setting dropEffect = "none" causes tryDHTMLDrag
to return DragOperationNone. Which is also the value
tryDHTMLDrag previously used to indicate JS did not
want to handle the drag.
Make it possible for the DragController::try* methods
to return a bool to indicate if javascript accepted
or rejected the drag event, separate from the DragOperation.
Tests:
- fast/events/drag-to-navigate.html
- fast/events/prevent-drag-to-navigate.html
- page/DragController.cpp: (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::defaultOperationForDrag): (WebCore::DragController::tryDHTMLDrag):
- page/DragController.h:
Jun 23, 2009:
- 11:40 PM Changeset in webkit [45063] by
-
- 1 edit1 add in trunk/LayoutTests
Add expected results for test i landed earlier
- 11:26 PM Changeset in webkit [45062] by
-
- 3 edits in trunk/WebKitTools
2009-06-23 Eric Seidel <eric@webkit.org>
Reviewed by Dave Levin.
Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run
https://bugs.webkit.org/show_bug.cgi?id=26669
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 11:25 PM Changeset in webkit [45061] by
-
- 29 edits in branches/nitro-extreme/JavaScriptCore
Merged r44075:44076 into nitro-extreme branch. (Adds infrastructure for op_method_check, but does not implement optimization.)
- 11:19 PM Changeset in webkit [45060] by
-
- 15 edits2 adds in trunk
<rdar://problem/6164797> Add Canvas API to allow drawing of <video> frames
<https://bugs.webkit.org/show_bug.cgi?id=25920>
Reviewed by Sam Weinig and Dave Hyatt.
Add support for drawing the contents of the video element to the canvas
in accordance with the current HTML5 draft.
Test: media/video-canvas.html
- 10:55 PM Changeset in webkit [45059] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Bit off a tiny bit more of standardizing opcode behavior to help with result
caching.
SunSpider reports no change, v8 maybe a tiny speedup.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emitSlow_op_to_jsnumber): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emitSlow_op_convert_this):
- 10:37 PM Changeset in webkit [45058] by
-
- 90 edits9 copies2 deletes in branches/nitro-extreme
Merged r44030:44075 into nitro-extreme branch.
- 10:31 PM Changeset in webkit [45057] by
-
- 12 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Bit off a tiny bit more of standardizing opcode behavior to help with result
caching -- including removing my old enemy, op_resolve_function, because
it was non-standard, and removing it felt better than helping it limp along.
SunSpider reports no change, v8 maybe a tiny speedup.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emitSlow_op_to_primitive):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- parser/Nodes.cpp: (JSC::FunctionCallResolveNode::emitBytecode):
- 10:16 PM Changeset in webkit [45056] by
-
- 17 edits1 copy in branches/nitro-extreme/JavaScriptCore
Merged r44029:44030 into nitro-extreme branch.
- 9:56 PM Changeset in webkit [45055] by
-
- 18 edits8 copies in branches/nitro-extreme
Merged r44000:44029 into nitro-extreme branch.
- 9:41 PM Changeset in webkit [45054] by
-
- 192 edits51 copies6 deletes in branches/nitro-extreme
Merged r43853:44000 into nitro-extreme branch.
- 9:33 PM Changeset in webkit [45053] by
-
- 9 edits18 copies in branches/nitro-extreme
Merged r43848:43853 into nitro-extreme branch.
- 9:26 PM Changeset in webkit [45052] by
-
- 203 edits84 copies47 deletes in branches/nitro-extreme
Merged r43781:43848 into nitro-extreme branch.
- 9:19 PM Changeset in webkit [45051] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Bit off a tiny bit of standardizing opcode behavior to help with result
caching.
0.6% SunSpider speedup. 0.3% v8 speedup.
- jit/JITInlineMethods.h: (JSC::JIT::emitLoad): Accomodate a base register that overlaps with payload by loading tag before payload, to avoid stomping base/payload.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_mov): Abide by the standard "tag in regT1, payload in regT0" semantics.
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var): Ditto. Also, removed some irrelevent
loads while I was at it. The global object's "d" pointer never changes
after construction.
- 9:16 PM Changeset in webkit [45050] by
-
- 10 edits in branches/nitro-extreme/JavaScriptCore
Merged r43780:43781 into nitro-extreme branch.
- 8:13 PM Changeset in webkit [45049] by
-
- 72 edits8 copies in branches/nitro-extreme
Merged r43750:43780 into nitro-extreme branch.
- 8:11 PM Changeset in webkit [45048] by
-
- 3 edits2 adds in branches/WWDC-2009-branch
Merge r44799.
- 8:11 PM Changeset in webkit [45047] by
-
- 14 edits in branches/WWDC-2009-branch/WebCore
Merge r44749.
- 8:11 PM Changeset in webkit [45046] by
-
- 15 edits4 adds in branches/WWDC-2009-branch
Merge r44519.
- 8:11 PM Changeset in webkit [45045] by
-
- 13 edits in branches/WWDC-2009-branch/WebCore
Merge r44266.
- 8:11 PM Changeset in webkit [45044] by
-
- 2 edits in branches/WWDC-2009-branch/LayoutTests/http/tests/security/postMessage
Merge r44134.
- 8:11 PM Changeset in webkit [45043] by
-
- 4 edits1 add in branches/WWDC-2009-branch/LayoutTests
Merge r44133.
- 8:11 PM Changeset in webkit [45042] by
-
- 1 edit in branches/WWDC-2009-branch/WebCore/ChangeLog
Merge r44125.
- 8:11 PM Changeset in webkit [45041] by
-
- 4 edits3 adds in branches/WWDC-2009-branch
Merge r44124.
- 7:59 PM Changeset in webkit [45040] by
-
- 167 edits73 copies97 deletes in branches/nitro-extreme
Merged r43666:43750 into nitro-extreme branch.
- 7:47 PM Changeset in webkit [45039] by
-
- 7 edits2 adds in trunk
<rdar://problem/6992806> REGRESSION: Enumeration can skip new properties in cases of prototypes that have more than 64 (26593)
<https://bugs.webkit.org/show_bug.cgi?id=26593>
Reviewed by Gavin Barraclough.
Add tests to ensure we correctly invalidate caching that depends on structure chains
that include dictionaries.
- 7:45 PM WikiStart edited by
- (diff)
- 7:41 PM Changeset in webkit [45038] by
-
- 3 edits in trunk/WebCore
2009-06-23 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium: Fix crash with inherited font-size in <option>
https://bugs.webkit.org/show_bug.cgi?id=26656
http://code.google.com/p/chromium/issues/detail?id=14853
In r42597 (https://bugs.webkit.org/show_bug.cgi?id=25244), I changed
the <select> handing for Chromium to fix a rendering bug. However,
although the font-size is correctly ignored, getRowHeight wasn't
updated and so was calculating the height of the rows in an
inconsistent manner. This can lead to a crash.
- manual-tests/optgroup-empty-and-nested.html: adding test case for crash
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::getRowHeight):
- 7:38 PM WikiStart edited by
- Add maxthon's port. (diff)
- 7:37 PM Changeset in webkit [45037] by
-
- 85 edits13 copies1 delete in branches/nitro-extreme
Merged r43660:43666 into nitro-extreme branch.
- 7:18 PM Changeset in webkit [45036] by
-
- 27 edits15 copies in branches/nitro-extreme
Merged r43642:43660 into nitro-extreme branch.
- 7:13 PM Changeset in webkit [45035] by
-
- 43 edits in branches/nitro-extreme
Merged r43641:43642 into nitro-extreme branch.
- 7:08 PM Changeset in webkit [45034] by
-
- 47 edits6 copies in branches/nitro-extreme
Merged r43619:43641 into nitro-extreme branch.
- 7:02 PM Changeset in webkit [45033] by
-
- 14 edits in branches/nitro-extreme/JavaScriptCore
Merged r43618:43619 into nitro-extreme branch.
- 6:50 PM Changeset in webkit [45032] by
-
- 2 edits in trunk/WebKitTools
2009-06-23 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Mark Rowe.
Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists
https://bugs.webkit.org/show_bug.cgi?id=26537
Let determineBaseProductDir subroutine remove
~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from
respecting global settings such as a custom build products directory
(<rdar://problem/5585899>).
- Scripts/webkitdirs.pm:
- 6:49 PM Changeset in webkit [45031] by
-
- 2 edits in trunk/WebCore
2009-06-23 Brady Eidson <beidson@apple.com>
Patch by Antti Koivisto.
Reviewed by Brady Eidson.
<rdar://problem/6988010> Failed resources not reloaded when built against Tiger SDK
A latent bug that cache revalidation uncovered. When a CachedResource failed to load,
it should always be revalidated upon reload.
- loader/CachedResource.cpp: (WebCore::CachedResource::canUseCacheValidator): (WebCore::CachedResource::mustRevalidate):
- 6:45 PM Changeset in webkit [45030] by
-
- 25 edits13 copies in branches/nitro-extreme
Merged r43598:43618 into nitro-extreme branch.
- 6:40 PM Changeset in webkit [45029] by
-
- 32 edits21 copies2 deletes in branches/nitro-extreme
Merged r43583:43598 into nitro-extreme branch.
- 6:36 PM Changeset in webkit [45028] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
Merged r43582:43583 into nitro-extreme branch.
- 6:33 PM Changeset in webkit [45027] by
-
- 2 edits in trunk/LayoutTests
2009-06-23 Ojan Vafai <ojan@chromium.org>
Reviewed by Mark Rowe.
Resets the results for a test that was missed in
http://trac.webkit.org/changeset/45016.
- editing/execCommand/5142012-3-expected.txt:
- 6:31 PM Changeset in webkit [45026] by
-
- 3 edits in trunk/WebKitTools
2009-06-23 Eric Seidel <eric@webkit.org>
Reviewed by Dave Levin.
Make SCM.run_command smarter, and make all previous
os.system and subprocess.popen use SCM.run_command instead.
https://bugs.webkit.org/show_bug.cgi?id=26666
This makes it easier to handle errors in a standard way throughout all the code.
Since this new code raises by default when the exit_code != 0,
we should prevent future problems of bugzilla-tool continuing after
a git or svn command failed.
- Scripts/modules/scm.py:
- 6:29 PM Changeset in webkit [45025] by
-
- 21 edits4 copies in branches/nitro-extreme
Merged r43560:43582 into nitro-extreme branch.
- 6:14 PM Changeset in webkit [45024] by
-
- 8 edits in branches/nitro-extreme
Merged r43559:43560 into nitro-extreme branch.
- 6:00 PM Changeset in webkit [45023] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 5:57 PM Changeset in webkit [45022] by
-
- 1 edit in branches/WWDC-2009-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION
Versioning.
- 5:44 PM Changeset in webkit [45021] by
-
- 2 edits in trunk/WebKit/mac
2009-06-23 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6950660> REGRESSION: iSale 5.5.3 crashes after I click a template to load
Due to some subtle WebKit changes - presumably some delegate callback behavior - a latent bug in
iSale was uncovered where they aren't properly retaining their FrameLoadDelegate, and we ended up
calling back to a dealloc'ed object.
- WebView/WebView.mm: (-[WebView _needsAdobeFrameReloadingQuirk]): Use more intelligent C++-style initialization. (-[WebView _needsKeyboardEventDisambiguationQuirks]): Ditto. (-[WebView _needsFrameLoadDelegateRetainQuirk]): YES for iSale versions under 5.6 (-[WebView dealloc]): Release the delegate if the quirk is in effect. (-[WebView setFrameLoadDelegate:]): Retain the new delegate if the quirk is in effect.
- 5:41 PM Changeset in webkit [45020] by
-
- 11 edits in branches/nitro-extreme/JavaScriptCore
Merged r43558:43559 into nitro-extreme branch.
- 5:40 PM Changeset in webkit [45019] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/6634228> Crash in [NSScroller mouseDown:] beneath EventHandler::passMouseDownEventToWidget()
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): Surround the -mouseDown: call with calls to Widget::beforeMouseDown() and Widget::afterMouseDown(), which prevent the widget's view hierarchy from being removed from its parent view while the scroller is tracking the mouse.
- 5:39 PM Changeset in webkit [45018] by
-
- 10 edits7 adds in trunk
WebCore:
2009-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26516
Add initial implementation of DataGridDataSource
- Initial implementation only supports the initialize callback function.
Test: fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html
- WebCore.xcodeproj/project.pbxproj:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDataGridDataSource.cpp: Added. (WebCore::JSDataGridDataSource::JSDataGridDataSource): (WebCore::JSDataGridDataSource::~JSDataGridDataSource): (WebCore::JSDataGridDataSource::initialize):
- bindings/js/JSDataGridDataSource.h: Added. (WebCore::JSDataGridDataSource::create): (WebCore::JSDataGridDataSource::isJSDataGridDataSource): (WebCore::JSDataGridDataSource::jsDataSource): (WebCore::asJSDataGridDataSource):
- bindings/js/JSHTMLDataGridElementCustom.cpp: Added. (WebCore::JSHTMLDataGridElement::listener): (WebCore::JSHTMLDataGridElement::setListener):
- html/DataGridDataSource.h: Added. (WebCore::DataGridDataSource::~DataGridDataSource): (WebCore::DataGridDataSource::isJSDataGridDataSource):
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::setDataSource): (WebCore::HTMLDataGridElement::initializationTimerFired):
- html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::dataSource):
- html/HTMLDataGridElement.idl:
LayoutTests:
2009-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Test for https://bugs.webkit.org/show_bug.cgi?id=26516
Add initial implementation of DataGridDataSource
- fast/dom/HTMLDataGridElement: Added.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt: Added.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html: Added.
- 5:09 PM Changeset in webkit [45017] by
-
- 8 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove 'arguments' field from Register union (again).
This time do so without breaking tests (radical, I know).
- interpreter/CallFrame.h: (JSC::ExecState::optionalCalleeArguments): (JSC::ExecState::setArgumentCount): (JSC::ExecState::init):
- interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
- interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::): (JSC::Register::Register): (JSC::Register::i):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_tear_off_arguments):
- runtime/Arguments.h: (JSC::JSActivation::copyRegisters): (JSC::Register::arguments):
- runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h:
- 4:56 PM Changeset in webkit [45016] by
-
- 20 edits2 adds in trunk
WebCore:
2009-06-23 Ryosuke Niwa <rniwa@google.com>
Reviewed by Justin Garcia.
Undo the changeset 21212 to fix the regression bug 14062.
The changeset 21212 attempted to fix rdar://problem/5002441.
The changeset 21212 modified InsertTextCommand::input so as to convert
all spaces in text to non-breaking spaces for rdar://problem/5002441.
However, the bug was originally caused by rebalanceWhitespaceAt
and this workaround introduced a regression bug 14062.
Because rebalanceWhitespaceAt appears to behave correctly now,
the workaround introduced in 21212 is no longer needed.
Test: editing/inserting/space-after-removeformat.html
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
LayoutTests:
2009-06-23 Ryosuke Niwa <rniwa@google.com>
Reviewed by Justin Garcia.
Undo the changeset 21212 to fix the regression bug 14062.
The changeset 21212 attempted to fix rdar://problem/5002441.
The changeset 21212 modified InsertTextCommand::input so as to convert
all spaces in text to non-breaking spaces for rdar://problem/5002441.
However, the bug was originally caused by rebalanceWhitespaceAt
and this workaround introduced a regression bug 14062.
Because rebalanceWhitespaceAt appears to behave correctly now,
the workaround introduced in 21212 is no longer needed.
The following test cases are affected by this change.
This patch removes unappropriate non-breaking spaces ( ) and
inserts normal spaces instead.
- editing/deleting/2610675-1-expected.txt: Replaced.
- editing/deleting/2610675-2-expected.txt: Replaced.
- editing/deleting/2610675-3-expected.txt: Replaced.
- editing/inserting/insert-before-link-1-expected.txt: Replaced.
- editing/inserting/space-after-removeformat-expected.txt: Added.
- editing/inserting/space-after-removeformat.html: Added.
- platform/mac/editing/execCommand/5482023-expected.checksum: Replaced.
- platform/mac/editing/execCommand/5482023-expected.png: Replaced.
- platform/mac/editing/execCommand/5482023-expected.txt: Replaced.
- platform/mac/editing/input/text-input-controller-expected.txt: Replaced.
- platform/mac/editing/inserting/editable-html-element-expected.checksum: Replaced.
- platform/mac/editing/inserting/editable-html-element-expected.png: Replaced.
- platform/mac/editing/inserting/editable-html-element-expected.txt: Replaced.
- platform/mac/editing/pasteboard/4989774-expected.checksum: Replaced.
- platform/mac/editing/pasteboard/4989774-expected.png: Replaced.
- platform/mac/editing/pasteboard/4989774-expected.txt: Replaced.
- platform/mac/editing/selection/4983858-expected.checksum: Replaced.
- platform/mac/editing/selection/4983858-expected.png: Replaced.
- platform/mac/editing/selection/4983858-expected.txt: Replaced.
- 4:42 PM Changeset in webkit [45015] by
-
- 8 edits6 adds in trunk
WebCore:
2009-06-23 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
elements width can't be changed with javascript
This patch both fixes setting the width attribute directly in
JavaScript, and setting the width on the style attribute.
- html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::parseMappedAttribute): If we have a new width, call setNeedsLayoutAndPrefWidthsRecalc()
Call calcPrefWidths() on the table cols.
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
- rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
Call layoutIfNeeded on the table cols.
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
- rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::clippedOverflowRectForRepaint): Use new table() convenience function. (WebCore::RenderTableCol::calcPrefWidths): Just call setPrefWidthsDirty(false) on ourself and our children. (WebCore::RenderTableCol::table):
- rendering/RenderTableCol.h:
LayoutTests:
2009-06-23 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Test for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
elements width can't be changed with javascript
- fast/dom/HTMLTableColElement: Added.
- fast/dom/HTMLTableColElement/resize-table-using-col-width.html: Added.
- platform/mac/fast/dom/HTMLTableColElement: Added.
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
- 4:35 PM Changeset in webkit [45014] by
-
- 8 edits5 adds in trunk
WebCore:
2009-06-23 Ojan Vafai <ojan@chromium.org>
Reviewed by Dan Bernstein.
Add logic to CSSStyleDeclaration::diff to deal with font-sizes that are
keyword values. When diff is called on a CSSStyleDeclaration, we check
the keywordSize to see if font-size matches a keyword value.
This ensures that when we diff a CSSMutableStyleDeclaration returned from
copyInheritableProperties on a CSSComputedStyleDeclaration that we
correctly identify matching font-sizes.
Test: editing/inserting/font-size-clears-from-typing-style.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
- css/CSSComputedStyleDeclaration.h:
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::cssPropertyMatches): (WebCore::CSSStyleDeclaration::diff):
- css/CSSStyleDeclaration.h:
LayoutTests:
2009-06-23 Ojan Vafai <ojan@chromium.org>
Reviewed by Dan Bernstein.
This test hits an edge case where typingStyle would never get cleared.
In addition to making every text insertion go into its own text node,
this caused large performance problems.
- editing/execCommand/5770834-1-expected.txt:
These results match how they were before r43243. It's not clear to me
why changes to font-size are affecting text-align styling though.
- editing/inserting/font-size-clears-from-typing-style-expected.txt: Added.
- editing/inserting/font-size-clears-from-typing-style.html: Added.
- editing/inserting/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
- editing/inserting/resources/font-size-clears-from-typing-style.js: Added.
- platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
- 4:18 PM Changeset in webkit [45013] by
-
- 9 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some result register tracking cruft in preparation for a new
result tracking mechanism.
SunSpider reports no change.
- assembler/AbstractMacroAssembler.h:
- assembler/X86Assembler.h: (JSC::X86Assembler::JmpDst::JmpDst): No need to track jump targets in machine code; we already do this in bytecode.
- jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::emitTimeoutCheck): Make sure to save and restore the result registers, so an opcode with a timeout check can still benefit from result register caching.
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases): Removed calls to killLastResultRegister()
in preparation for something new.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq):
- jit/JITInlineMethods.h: (JSC::JIT::emitGetFromCallFrameHeaderPtr): (JSC::JIT::emitGetFromCallFrameHeader32):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_sret): (JSC::JIT::emit_op_jmp_scopes): ditto
- jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::getArgument): added a mechanism for reloading an argument you passed to a JIT stub, for use in emitTimeoutCheck.
- 4:10 PM Changeset in webkit [45012] by
-
- 2 edits in trunk/WebKitTools
2009-06-23 Joe Mason <joe.mason@torchmobile.com>
Reviewed by Adam Treat.
- Scripts/prepare-ChangeLog: Added --git-index mode to list only the changes which are already staged in the index. Useful to create an entry for what you're about to commit while ignoring unstaged changes.
- 4:06 PM Changeset in webkit [45011] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-23 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26654
Add the proper export define for the JavaScriptCore API when building for WINCE.
- 3:38 PM Changeset in webkit [45010] by
-
- 3 edits in trunk/WebKit/mac
2009-06-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
- Fix <rdar://problem/6965672>
Defer calls to WKPCInvalidateRect, so we don't try to invalidate while waiting for a reply, since
that is too early.
- Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isProcessingRequests):
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::processRequests): (WKPCInvalidateRect):
- 3:25 PM Changeset in webkit [45009] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
add a blank line to pasted Facebook content (under
CompositeEditCommand::positionAvoidingSpecialElementBoundary)
- Just added null checks and I will create a new bug to prevent the bad behavior.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
LayoutTests:
2009-06-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
add a blank line to pasted Facebook content (under
CompositeEditCommand::positionAvoidingSpecialElementBoundary)
- editing/inserting/return-with-object-element-expected.txt: Added.
- editing/inserting/return-with-object-element.html: Added.
- 2:51 PM Changeset in webkit [45008] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove now-useless inplace variants of binary ops.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitand): (JSC::JIT::emit_op_bitor): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emit_op_mul):
- 2:48 PM Changeset in webkit [45007] by
-
- 2 edits in trunk/WebCore
2009-06-23 Simon Fraser <Simon Fraser>
Build fix.
Wrap shouldDoSoftwarePaint() in #if USE(ACCELERATED_COMPOSITING) to avoid warning when
ACCELERATED_COMPOSITING is not defined.
- rendering/RenderLayer.cpp:
- 2:43 PM Changeset in webkit [45006] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Move off memory operands to aid in re-enabling result caching.
- No regression measured.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emit_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emitBitAnd32InPlace): (JSC::JIT::emit_op_bitor): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emitBitOr32InPlace): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emitBitXor32Constant): (JSC::JIT::emitBitXor32InPlace): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitAdd32InPlace): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32Constant): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emitSub32InPlaceLeft): (JSC::JIT::emitSub32InPlaceRight): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emitMul32InPlace): (JSC::JIT::emit_op_div): (JSC::JIT::emit_op_mod):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emit_op_to_jsnumber):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val):
- 2:25 PM Changeset in webkit [45005] by
-
- 6 edits4 adds in trunk
2009-06-23 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Fix reflection painting on elements with compositing layers.
Test: compositing/reflections/reflection-on-composited.html
- rendering/RenderLayer.h: Add a new PaintLayerPaintingReflection flag which is set while painting inside reflections. (WebCore::RenderLayer::setPaintingInsideReflection): Add a setter so that RenderLayerBacking can call it.
- rendering/RenderLayer.cpp: (WebCore::shouldDoSoftwarePaint): Utility to clarify the logic of when a composited layer should do a software paint.
(WebCore::RenderLayer::paintLayer):
Use shouldDoSoftwarePaint() to determine when to software-paint a reflected layer.
Remove transform-related tests from the reflection-painting if test because they appear
to be unnecessary.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): Add the code to paint reflections to the composited layer painting method.
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): Set the PaintLayerPaintingReflection flag.
- 1:26 PM Changeset in webkit [45004] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed some missing and/or misplaced labels in bytecode generation, so
we don't have to work around them in JIT code generation.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpSubroutine):
- parser/Nodes.cpp: (JSC::TryNode::emitBytecode):
- 1:01 PM Changeset in webkit [45003] by
-
- 7 edits in trunk
WebCore:
2009-06-23 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26643
Memory cache should respect Cache-Control: no-store
Make resources with Cache-Control: no-store uncacheable in the memory cache.
They get evicted immediately when all clients are gone and are always
reloaded from the server.
Conforms to RFC2616 14.9.2 and seems also match Firefox behavior.
- loader/CachedResource.cpp: (WebCore::CachedResource::removeClient): (WebCore::CachedResource::canUseCacheValidator): (WebCore::CachedResource::mustRevalidate):
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::cacheControlContainsNoStore):
- platform/network/ResourceResponseBase.h:
LayoutTests:
2009-06-23 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26643
Memory cache should respect Cache-Control: no-store
Update the test to cover no-store.
- http/tests/cache/subresource-expiration-expected.txt:
- http/tests/cache/subresource-expiration.html:
- 12:48 PM Changeset in webkit [45002] by
-
- 2 edits in trunk/WebCore
Windows build fix
- 12:46 PM Changeset in webkit [45001] by
-
- 6 edits in trunk/WebCore
2009-06-23 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
First part of https://bugs.webkit.org/show_bug.cgi?id=26652
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): (WebCore::RenderLayer::paintLayer):
- rendering/RenderLayer.h: (WebCore::RenderLayer::):
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): Replace the 3 boolean params to RenderLayer::paintLayer() with a bit mask for readability.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
- rendering/RenderLayerBacking.h: Remove the unused 'haveTransparency' param to paintIntoLayer().
- 12:12 PM Changeset in webkit [45000] by
-
- 4 edits2 adds in trunk
WebCore:
2009-06-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
after manually quoting blank line then hitting return
If the insertion point is both the begining and ending visible position
then we need to insert at the end instead of the begining, which is what
would normally happen if the insertion point was as the begining.
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
LayoutTests:
2009-06-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
after manually quoting blank line then hitting return
- editing/inserting/insert-br-quoted-007-expected.txt: Added.
- editing/inserting/insert-br-quoted-007.html: Added.
- 12:05 PM Changeset in webkit [44999] by
-
- 13 edits in trunk/WebCore
2009-06-23 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig, and looked over by Eric Carlson.
<rdar://problem/6980466> Media elements should provide option for changing pitch correction
Introduce a new boolean property to HTMLMediaElement called webkitPreservesPitch for script to control this.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Currently the platforms that have a flexible pitch preservation property (Quicktime on Mac and Win) have had it on by default, so continue that default for now. (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::webkitPreservesPitch): (WebCore::HTMLMediaElement::setWebkitPreservesPitch):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setPreservesPitch): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::preservesPitch): (WebCore::MediaPlayer::setPreservesPitch):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPreservesPitch):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createQTMovie): Rework to allow recreation of the movie with almost the exact same attributes as before, with pitch preservation being the difference. (WebCore::MediaPlayerPrivate::setPreservesPitch): Recreate the QTMovie if the flag actually changes. (WebCore::MediaPlayerPrivate::updateStates): Restore current time and rate if this is a recreated movie. (WebCore::MediaPlayerPrivate::timeChanged): Clear the time-to-be-restored, as this callback means it has been effectively overwritten.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::setPreservesPitch):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::QTMovieWinPrivate): (QTMovieWinPrivate::~QTMovieWinPrivate): (QTMovieWinPrivate::task): Restore current time and rate if this is a re-created movie. (QTMovieWin::play): Clear the time-to-be-restored, as this effectively overwrites it. (QTMovieWin::pause): Ditto. (QTMovieWin::setRate): Ditto. (QTMovieWin::setCurrentTime): Ditto. (QTMovieWin::setPreservesPitch): Recreate the Movie if the flag actually changes. (QTMovieWin::load): Rework to allow recreation of the Movie with similar state as the movie before it, but changing the pitch preservation flag.
- platform/graphics/win/QTMovieWin.h:
- 12:04 PM Changeset in webkit [44998] by
-
- 2 edits in trunk/WebCore
2009-06-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6998286> Crash after leaving page with <video>
Don't try to post events after going into the page cache.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::documentWillBecomeInactive): Cancel pending events and stop event timers so we won't try to post events after going into the cache.
- 11:52 AM Changeset in webkit [44997] by
-
- 5 edits in trunk/WebCore
2009-06-23 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Brady Eidson.
Simplify the interaction between LocalStorageArea/SessionStorageArea
and StorageArea by creating a "blockUntilImportComplete()" function
rather than bouncing back and forth between the child and parent
classes in a somewhat unintuitive manner.
This patch also paves the way for LocalStorageArea and
SessionStorageArea being merged into one. It's part of several in a
set which are separating syncing (to disk) code from the rest of the
implementation so that local storage and session storage's code can be
unified.
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::blockUntilImportComplete):
- storage/LocalStorageArea.h:
- storage/StorageArea.cpp: (WebCore::StorageArea::length): (WebCore::StorageArea::key): (WebCore::StorageArea::getItem): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::contains):
- storage/StorageArea.h: (WebCore::StorageArea::blockUntilImportComplete):
- 11:36 AM Changeset in webkit [44996] by
-
- 3 edits in trunk/WebCore
2009-06-23 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
<rdar://problem/6997929> Assertion at WebCore::RenderLayer::updateClipRects with hardware acceleration
The updatingControlTints() painting pass goes through compositing layer boundaries,
so we need to ensure we don't cache clip rects computed with the wrong root by
setting temporaryClipRects to true.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): Remove a printf that I left in by mistake.
- 11:03 AM Changeset in webkit [44995] by
-
- 10 edits in trunk
WebCore:
2009-06-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
WebCore side of <rdar://problem/6946094>.
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::setExternalDataObject):
- platform/win/ClipboardWin.h:
WebKit/win:
2009-06-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
WebKit side of <rdar://problem/6946094>.
- Interfaces/IWebUIDelegate.idl: Add a newPasteboard out parameter to willPerformDragSourceAction.
- WebCoreSupport/WebDragClient.cpp: (WebDragClient::willPerformDragSourceAction): Implement this. If the client returns a new pasteboard, use it for the drag.
- WebCoreSupport/WebInspectorDelegate.h: (WebInspectorDelegate::willPerformDragSourceAction): Add the new parameter.
WebKitTools:
2009-06-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Update for WebKit changes.
- DumpRenderTree/win/UIDelegate.h: (UIDelegate::willPerformDragSourceAction):
- 10:29 AM Changeset in webkit [44994] by
-
- 3 edits in trunk/WebCore
2009-06-23 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
Add setFormContentType and setFormData since it is awkward for Chromium
to use setFormInfoFromRequest to set the underlying members. Also, add
a clearChildren method that Chromium needs. These methods are used as
part of the Chromium code that serializes a HistoryItem for storing in
the browser's session history.
- history/HistoryItem.cpp:
- history/HistoryItem.h:
- 8:45 AM Changeset in webkit [44993] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-23 Joe Mason <joe.mason@torchmobile.com>
Reviewed by Adam Treat.
Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>
https://bugs.webkit.org/show_bug.cgi?id=26611
Implement currentThreadStackBase on WINCE by adding a global,
g_stackBase, which must be set to the address of a local variable
by the caller before calling any WebKit function that invokes JSC.
- 8:44 AM Changeset in webkit [44992] by
-
- 3 edits in trunk/LayoutTests
2009-06-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY, layout tests fix.
'timeupdate' events are, by definition, timing dependent so it isn't
a good idea to log them in layout test results.
- media/event-attributes-expected.txt:
- media/event-attributes.html:
- 7:49 AM Changeset in webkit [44991] by
-
- 11 edits2 adds in trunk
2009-06-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6978938> Need HTML 5 event attributes for media elements
Test: media/event-attributes.html
- html/HTMLAttributeNames.in: Add media event attribute names.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): Handle media event attributes.
2009-06-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6978938> Need HTML 5 event attributes for media elements
- media/event-attributes-expected.txt: Added.
- media/event-attributes.html: Added.
- media/progress-event-total.html: Cleanup, use event handler attributes.
- media/progress-event.html: Ditto.
- media/video-size-intrinsic-scale.html: Remove duplicate 'waitForEvent("ratechange")'
- media/video-source-add-src.html: Ditto.
- media/video-source-error.html: Ditto.
- media/video-timeupdate-during-playback.html: Ditto.
- platform/gtk/Skipped: Skip new test.
- 6:03 AM Changeset in webkit [44990] by
-
- 2 edits in trunk/WebCore
2009-06-23 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
Fix Qt build with Phonon.
The #include <phonon> header no longer exists. And the <Phonon> or
<Phonon/Phonon> headers have never existed (neither for us nor for the
Phonon sources). You have to select each and every header that you do
want now.
- 5:43 AM Changeset in webkit [44989] by
-
- 3 edits in trunk/WebCore
2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Remove duplicated code in Qt & GTK logging initialization
We now share the getChannelFromName() function in Logging.cpp
- platform/gtk/LoggingGtk.cpp:
- platform/qt/LoggingQt.cpp:
- 5:43 AM Changeset in webkit [44988] by
-
- 12 edits in trunk/WebCore
2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Rename the plugin logging channel to plural form 'Plugins'
This matches both the other logging channel names, as well as the
WebKit logging channel used by Safari/Mac for plugins.
- platform/Logging.cpp:
- platform/Logging.h:
- platform/gtk/LoggingGtk.cpp:
- platform/mac/LoggingMac.mm:
- platform/qt/LoggingQt.cpp:
- platform/win/LoggingWin.cpp:
- plugins/PluginDebug.h:
- plugins/gtk/PluginPackageGtk.cpp:
- plugins/mac/PluginPackageMac.cpp:
- plugins/mac/PluginViewMac.cpp:
- plugins/qt/PluginPackageQt.cpp:
- 3:17 AM Changeset in webkit [44987] by
-
- 2 edits in trunk/WebCore
2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Fix NPAPI mouse translation issues on Mac
The WindowRef we pass to the plugin refers to the the top level window,
so the x and y positions have to be relative to this position, but we
have to manually compensate for title bar decorations and other parents
of the QWebView since contentsToWindow() only traverses to the QWebView.
Previously we did this compensation when passing on mouse coordinates to
the plugin, which caused various issues with translations such as not
being able to close the Flash settings dialog, or the hand cursor not
appearing over links.
We now do the compensation as part of the call to NPP_SetWindow, and
then pass mouse coordinates in global context without any compensation,
similar to how both Safari and Mozilla does it.
- 3:11 AM Changeset in webkit [44986] by
-
- 2 edits in trunk/WebCore
2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Resolve absolute path to library install_name manually
Since our target.path is set to the Qt directory (to be able
to do 'make install') the 'absolute_library_soname' option
to QMake did not do the right thing.
We now compute the absolute path manually using DESTDIR.
- WebCore.pro:
- 2:17 AM Changeset in webkit [44985] by
-
- 2 edits25 copies1 delete in trunk/LayoutTests
2009-06-23 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
More tests for the XSSAuditor. (I converted the server side to Perl
after Sam reviewed the patch because the PHP scripts didn't agree with
the Tiger and Windows buildbots.)
- http/tests/security/xssAuditor/img-onerror-tricky-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-tricky.html: Added.
- http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick.html: Added.
- http/tests/security/xssAuditor/property-escape-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag.php: Removed.
- http/tests/security/xssAuditor/resources/echo-intertag.pl: Added.
- http/tests/security/xssAuditor/resources/echo-property.pl: Added.
- http/tests/security/xssAuditor/resources/redir.php: Added.
- http/tests/security/xssAuditor/resources/xss.js: Added.
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-post.html: Added.
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source.html: Added.
- http/tests/security/xssAuditor/script-tag.html:
- 2:14 AM Changeset in webkit [44984] by
-
- 3 edits in trunk/JavaScriptCore
Fix stupid performance problem in the LiteralParser
Reviewed by Alexey Proskuryakov.
The LiteralParser was making a new UString in order to use
toDouble, however UString's toDouble allows a much wider range
of numberic strings than the LiteralParser accepts, and requires
an additional heap allocation or two for the construciton of the
UString. To rectify this we just call WTF::dtoa directly using
a stack allocated buffer to hold the validated numeric literal.
- 2:11 AM Changeset in webkit [44983] by
-
- 2 edits1 copy25 deletes in trunk/LayoutTests
Revert 44981. The buildbots hate me.
- 2:01 AM Changeset in webkit [44982] by
-
- 2 edits in trunk/WebKitTools
2009-06-23 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
- Scripts/modules/scm.py: Fix commit_with_message to return the commit output.
- 1:51 AM Changeset in webkit [44981] by
-
- 2 edits25 adds1 delete in trunk/LayoutTests
2009-06-23 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
More tests for the XSSAuditor. (I converted the server side to Perl
after Sam reviewed the patch because the PHP scripts didn't agree with
the Tiger and Windows buildbots.)
- http/tests/security/xssAuditor/img-onerror-tricky-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-tricky.html: Added.
- http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick.html: Added.
- http/tests/security/xssAuditor/property-escape-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag.php: Removed.
- http/tests/security/xssAuditor/resources/echo-intertag.pl: Added.
- http/tests/security/xssAuditor/resources/echo-property.pl: Added.
- http/tests/security/xssAuditor/resources/redir.php: Added.
- http/tests/security/xssAuditor/resources/xss.js: Added.
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-post.html: Added.
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source.html: Added.
- http/tests/security/xssAuditor/script-tag.html:
- 1:46 AM Changeset in webkit [44980] by
-
- 2 edits in trunk/WebKitTools
2009-06-23 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
- Scripts/modules/scm.py: Fix error seen when commiting r44979.
- 1:40 AM Changeset in webkit [44979] by
-
- 1 edit5 adds in trunk/WebKitTools
2009-06-18 Eric Seidel <eric@webkit.org>
Reviewed by Dave Levin.
WebKit needs a script to interact with bugzilla and automate
parts of the patch posting and commit processes.
https://bugs.webkit.org/show_bug.cgi?id=26283
This is really a first-draft tool.
It's to the point where it's useful to more people than just me now though.
Git support works. SVN support is written, but mostly untested.
This tool requires BeautifulSoup and mechanize python modules to run:
sudo easy_install BeautifulSoup
sudo easy_install mechanize
More important than the tool itself are the Bugzilla, Git and SVN class abstractions
which I hope will allow easy writing of future tools.
The tool currently implements 10 commands, described below.
Helpers for scripting dealing with the commit queue:
bugs-to-commit Bugs in the commit queue
patches-to-commit Patches attached to bugs in the commit queue
Dealing with bugzilla:
reviewed-patches BUGID r+'d patches on a bug
apply-patches BUGID Applies all patches on a bug to the local working directory without committing.
land-and-update BUGID Lands the current working directory diff and updates the bug.
land-patches [options] BUGID Lands all patches on a bug optionally testing them first
obsolete-attachments BUGID Marks all attachments on a bug as obsolete.
commit-message Prints a commit message suitable for the uncommitted changes.
These effectively replace git-send-bugzilla:
post-diff BUGID Attaches the current working directory diff to a bug as a patch file.
post-commits BUGID COMMITISH Attaches a range of local commits to a bug as patch files.
post-diff works for SVN and Git, post-commits only works for SCMs with local-commit support (like Git)
land-* commands in a Git environment only work with simple patches due to svn-apply bugs:
https://bugs.webkit.org/show_bug.cgi?id=26299
https://bugs.webkit.org/show_bug.cgi?id=26300
This script follows python style (similar to how for Obj-C we follow AppKit style)
http://www.python.org/doc/essays/styleguide.html
The Python community has a strong style culture and the WebKit style guide is silent re: Python.
I've filed a bug to update the WebKit style guide to mention python:
https://bugs.webkit.org/show_bug.cgi?id=26524
- Scripts/bugzilla-tool: Added.
- 12:48 AM Changeset in webkit [44978] by
-
- 2 edits22 deletes in trunk/LayoutTests
Revert 44977 because Tiger and Windows don't like the new tests.
- 12:11 AM Changeset in webkit [44977] by
-
- 2 edits22 adds in trunk/LayoutTests
2009-06-23 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
More tests for the XSSAuditor.
- http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick.html: Added.
- http/tests/security/xssAuditor/property-escape-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.php: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post.php: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-utf-7.php: Added.
- http/tests/security/xssAuditor/resources/echo-intertag.php:
- http/tests/security/xssAuditor/resources/echo-property.php: Added.
- http/tests/security/xssAuditor/resources/redir.php: Added.
- http/tests/security/xssAuditor/resources/xss.js: Added.
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-post.html: Added.
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source.html: Added.
- 12:00 AM Changeset in webkit [44976] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
For member function calls, emit "this" directly into the "this" slot
for the function call, instead of moving it there later. This reduces
time spent in op_mov during certain calls, like "a.b.c()".
1%-2% speedup on v8, mostly richards and delta-blue.
- parser/Nodes.cpp: (JSC::FunctionCallDotNode::emitBytecode):
