Timeline
Oct 24, 2009:
- 9:56 PM Changeset in webkit [50039] by
-
- 5 edits in trunk/WebCore
WebInspector: Fixed issue with IME inside console
https://bugs.webkit.org/show_bug.cgi?id=30660
Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-24
Reviewed by Timothy Hatcher.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._promptKeyDown):
- inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype._promptKeyDown):
- inspector/front-end/inspector.js:
(WebInspector.loaded):
(WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):
- inspector/front-end/utilities.js:
(isEnterKey): Added. Check if in IME.
- 9:13 PM Changeset in webkit [50038] by
-
- 3 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30752>.
Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.
Reviewed by Timothy Hatcher.
Have the scope bars select one scope by default, but if the multiple selection key
is pressed, allow for multiple selection.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype._updateFilter):
(WebInspector.ConsoleView.prototype.filter):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):
- 7:44 PM Changeset in webkit [50037] by
-
- 18 edits1 add in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection
Reviewed by Dan Bernstein.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added JSHTMLCollectionFunctions.h
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h
- bindings/js/JSHTMLCollectionFunctions.h: Added.
(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.
- bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h
for toJS on document.all.
- bindings/objc/DOMHTML.mm:
- bindings/objc/DOMUtility.mm:
(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.
- bindings/scripts/CodeGeneratorJS.pm:
- html/HTMLAllCollection.idl:
- html/HTMLCollection.idl:
- html/HTMLOptionsCollection.idl:
LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection
Reviewed by Dan Bernstein.
- fast/dom/wrapper-classes-expected.txt:
- 4:08 PM Changeset in webkit [50036] by
-
- 4 edits in trunk/WebCore
Make the scope bars in the Web Inspector match other scope bars in Mac OS X.
Also cleans up the CSS to use classes instead of ID selectors.
https://bugs.webkit.org/show_bug.cgi?id=28186
Reviewed by Dan Bernstein.
- inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
- inspector/front-end/inspector.css: Lots of changes to make it look right.
- inspector/front-end/inspector.html: Add the scope-bar class.
- 4:08 PM Changeset in webkit [50035] by
-
- 2 edits in trunk/WebCore
Fix selecting Resources in the Web Inspector's Resources panel.
https://bugs.webkit.org/show_bug.cgi?id=30743
Reviewed by Pavel Feldman.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
(WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
isCategoryVisible on the ResourcesPanel.
- 4:08 PM Changeset in webkit [50034] by
-
- 2 edits in trunk/WebCore
Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting
All will deselect the other filters.
https://bugs.webkit.org/show_bug.cgi?id=30744
Reviewed by Pavel Feldman.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.createFilterElement): Better syntax.
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
and the child variable instead of target in the loop. Other clean up.
- 4:08 PM Changeset in webkit [50033] by
-
- 6 edits in trunk/WebCore
Make resizing the Web Inspector's Elements panel sidebar work again.
Also makes Resources panel use the sidebar code in Panel.
https://bugs.webkit.org/show_bug.cgi?id=30742
Reviewed by Pavel Feldman.
- inspector/front-end/Panel.js:
(WebInspector.Panel): Don't create the sidebar with an argument.
(WebInspector.Panel.prototype.show): Call updateSidebarWidth.
(WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
(WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
(WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
(WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
(WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
(WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
(WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel): Call createSidebar.
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
(WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
(WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
(WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
(WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.
- inspector/front-end/StoragePanel.js:
(WebInspector.StoragePanel): Call createSidebar.
(WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel): Call createSidebar.
(WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
- 4:08 PM Changeset in webkit [50032] by
-
- 3 edits in trunk/WebCore
Call updateSelection() in a few places so hovering in the Web Inspector's
Elements panel always has the correct row selection height.
https://bugs.webkit.org/show_bug.cgi?id=30735
Reviewed by Pavel Feldman.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
(WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.
- inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
- 4:02 PM Changeset in webkit [50031] by
-
- 2 edits in trunk/WebCore
2009-10-24 Timothy Hatcher <timothy@apple.com>
Remove the re-root tree feature from the Web Inspector's
Elements panel. This feature wasn't super useful and gets
in the way of double-click to edit.
Reviewed by Pavel Feldman.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.ondblclick):
- 3:40 PM Changeset in webkit [50030] by
-
- 3 edits in trunk/WebCore
2009-10-24 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Implements ReturnsNew hint for V8 bindings generation code.
https://bugs.webkit.org/show_bug.cgi?id=30745
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
- 3:16 PM Changeset in webkit [50029] by
-
- 3 edits1 copy4 adds in trunk
Missing images at 350.org due to wrong URLs
https://bugs.webkit.org/show_bug.cgi?id=30748
Reviewed by Sam Weinig.
WebCore:
Test: fast/dom/HTMLImageElement/parse-src.html
- dom/Element.cpp:
(WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
and SVGImageLoader::sourceURI() do.
LayoutTests:
- fast/dom/HTMLImageElement/parse-src-expected.txt: Added.
- fast/dom/HTMLImageElement/parse-src.html: Added.
- fast/dom/HTMLImageElement/script-tests: Added.
- fast/dom/HTMLImageElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Document/script-tests/TEMPLATE.html.
- fast/dom/HTMLImageElement/script-tests/parse-src.js: Added.
- 1:55 PM Changeset in webkit [50028] by
-
- 2 edits in trunk/WebCore
2009-10-24 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
- WebCore.pro:
- 9:12 AM Changeset in webkit [50027] by
-
- 5 edits1 add in trunk/WebCore
2009-10-24 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[V8] Fix up to accommodate for HTMLAllCollection changes in
http://trac.webkit.org/changeset/49998.
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- 8:28 AM Changeset in webkit [50026] by
-
- 17 edits in trunk
2009-10-24 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30476
Set the stack size to 80 Kb and heap size to the 128kB - 32MB range
to all executables linking against WebKit library.
- WebKit.pri:
2009-10-24 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30476
Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to jsc.exe.
- jsc.pro:
2009-10-24 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30476
Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to all QtWebkit executables.
- QGVLauncher/QGVLauncher.pro:
- QtLauncher/QtLauncher.pro:
- tests/benchmarks/loading/tst_loading.pro:
- tests/benchmarks/painting/tst_painting.pro:
- tests/qgraphicswebview/qgraphicswebview.pro:
- tests/qwebelement/qwebelement.pro:
- tests/qwebframe/qwebframe.pro:
- tests/qwebhistory/qwebhistory.pro:
- tests/qwebhistoryinterface/qwebhistoryinterface.pro:
- tests/qwebpage/qwebpage.pro:
- tests/qwebplugindatabase/qwebplugindatabase.pro:
- tests/qwebview/qwebview.pro:
- 5:56 AM QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 5:48 AM QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 5:23 AM QtBackLog edited by
- (diff)
- 5:21 AM QtBackLog edited by
- (diff)
Oct 23, 2009:
- 11:55 PM QtBackLog edited by
- (diff)
- 11:55 PM QtBackLog edited by
- (diff)
- 11:41 PM QtBackLog edited by
- (diff)
- 9:42 PM QtWebKitPerformanceUtilities edited by
- (diff)
- 9:12 PM Changeset in webkit [50025] by
-
- 4 edits in trunk/WebCore
<rdar://problem/7294131> Assertion failure in AuthenticationMac at
mac(const Credential&) after authenticating to MobileMe Gallery movie
Reviewed by Alexey Proskuryakov.
- platform/network/Credential.cpp:
(WebCore::Credential::Credential): Initialize m_persistence.
(WebCore::Credential::isEmpty): Made this method const.
- platform/network/Credential.h:
- platform/network/mac/AuthenticationMac.mm:
(WebCore::mac): Return nil if the Credential is empty.
- 8:16 PM Changeset in webkit [50024] by
-
- 2 edits in trunk/WebKit/mac
Fix engineering builds in the mysterious future.
- Configurations/DebugRelease.xcconfig:
- 8:06 PM Changeset in webkit [50023] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 8:05 PM Changeset in webkit [50022] by
-
- 1 copy in tags/Safari-6531.21.5
New tag.
- 8:05 PM Changeset in webkit [50021] by
-
- 3 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30617>.
Web Inspector: Resources Scope Bar Should Allow Combinations.
Reviewed by Timothy Hatcher.
Refactor the filtering in ResourcePanel to make it match ConsoleView,
and add a divider between All, and the other choices of Resource types.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.filter):
(WebInspector.ResourcesPanel.prototype._updateFilter):
- inspector/front-end/inspector.css:
- 8:03 PM Changeset in webkit [50020] by
-
- 2 edits in branches/safari-4-branch/WebKit/win
Merge r50019.
- 8:01 PM Changeset in webkit [50019] by
-
- 2 edits in trunk/WebKit/win
Build fix. Include config.h before including other files.
- AccessibleImage.cpp:
- 7:06 PM Changeset in webkit [50018] by
-
- 3 edits3 adds in trunk
2009-10-23 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Added test for bug 27239 (ignore Refresh for view source mode).
https://bugs.webkit.org/show_bug.cgi?id=27239
- http/tests/security/view-source-no-refresh.html: Added
- http/tests/security/view-source-no-refresh-expected.txt: Added
- http/tests/security/resources/view-source-no-refresh.php: Added
2009-10-23 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Ignore the Refresh header if we're in view source mode.
Test: http/tests/security/view-source-no-refresh.html
- loader/FrameLoader.cpp: ignore Refresh in view-source mode.
- 6:10 PM Changeset in webkit [50017] by
-
- 5 edits in trunk/WebCore
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=30734
Remove XMLTokenizer::m_currentNodeIsReferenced
No change in behavior, no tests.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::setCurrentNode):
- dom/XMLTokenizer.h: Don't store a boolean for the current node being the document - we can always check for that.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
- dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::XMLTokenizer): A fragment passed to XMLTokenizer is never null - in fact, the first thing we do is dereference it unconditionally, and then begin checking it for null, as if it could help.
- 6:09 PM Changeset in webkit [50016] by
-
- 3 edits in trunk/WebCore
No review since this is a build fix.
Build fix for the Mac. (Build is only broken when SVG filters are
enabled.)
Labelled these function static.
- platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::identity):
(WebCore::table):
(WebCore::discrete):
(WebCore::linear):
(WebCore::gamma):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::boxBlur):
- 5:40 PM Changeset in webkit [50015] by
-
- 9 edits2 adds in trunk/WebCore
2009-10-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement a Timeline panel.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/Images/timelineIcon.png: Added.
- inspector/front-end/TimelineAgent.js: (WebInspector.addItemToTimeline): (WebInspector.timelineProfilerWasStarted): (WebInspector.timelineProfilerWasStopped):
- inspector/front-end/TimelinePanel.js: Added. (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype.handleKeyEvent): (WebInspector.TimelinePanel.prototype.timelineWasStarted): (WebInspector.TimelinePanel.prototype.timelineWasStopped): (WebInspector.TimelinePanel.prototype.addItemToTimeline): (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline): (WebInspector.TimelinePanel.prototype._toggleTimelineButton): (WebInspector.TimelinePanel.prototype.setMainViewWidth): (WebInspector.TimelinePanel.prototype.getItemTypeName): (WebInspector.TimelineRecordTreeElement): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._createPanels):
- 5:26 PM Changeset in webkit [50014] by
-
- 2 edits in trunk/WebCore
2009-10-23 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Clash Between Search's onkeyup and incremental search events
https://bugs.webkit.org/show_bug.cgi?id=30731
- inspector/front-end/inspector.js: (WebInspector.performSearch): prevent incremental search event from clobbering a forced search
- 5:24 PM Changeset in webkit [50013] by
-
- 11 edits2 adds in trunk/WebCore
2009-10-23 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Removes the need for C++ Timeline types in InspectorTimelineAgent in favor
of ScriptObjects.
https://bugs.webkit.org/show_bug.cgi?id=30707
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/DOMDispatchTimelineItem.cpp: Removed.
- inspector/DOMDispatchTimelineItem.h: Removed.
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentTimelineItem):
- inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineItemEntry::TimelineItemEntry):
- inspector/TimelineItem.cpp: Removed.
- inspector/TimelineItem.h: Removed.
- inspector/TimelineItemFactory.cpp: Added. (WebCore::TimelineItemFactory::createGenericTimelineItem): (WebCore::TimelineItemFactory::createDOMDispatchTimelineItem):
- inspector/TimelineItemFactory.h: Added. (WebCore::): (WebCore::TimelineItemFactory::TimelineItemFactory):
- 5:13 PM Changeset in webkit [50012] by
-
- 10 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=30729
Provide private API to request the global context for a specific world.
Used to initialize parameters on the global object.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-23
Reviewed by Geoff Garen.
WebCore:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::globalObject):
- bindings/js/ScriptController.h:
WebKit/mac:
- WebView/WebFramePrivate.h:
- WebView/WebFrame.mm:
(-[WebFrame contextForWorldID:]):
WebKit/win:
- WebFrame.cpp:
(WebFrame::contextForWorldID):
- WebFrame.h:
- 4:44 PM Changeset in webkit [50011] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:44 PM Changeset in webkit [50010] by
-
- 1 copy in tags/Safari-6531.21.4
New tag.
- 4:40 PM Changeset in webkit [50009] by
-
- 4 edits4 adds in branches/safari-4-branch
Merge r50004.
- 4:40 PM Changeset in webkit [50008] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r47534.
- 4:35 PM Changeset in webkit [50007] by
-
- 2 edits in trunk/WebKit/win
Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
<http://webkit.org/b/30732> and <rdar://7332018>.
Reviewed by John Sullivan.
Turns off pan-scrolling on a WebView when it is about to lose focus.
- WebView.cpp:
(WebViewWndProc):
- 3:40 PM Changeset in webkit [50006] by
-
- 9 edits in trunk/WebCore
2009-10-23 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Fixes style problems in Android-specific files.
https://bugs.webkit.org/show_bug.cgi?id=30717
Style changes only, no new tests possible.
- page/android/EventHandlerAndroid.cpp: Modified. (WebCore::EventHandler::passMouseDownEventToWidget): Fixes whitespace in method signature. (WebCore::EventHandler::passSubframeEventToSubframe): Fixes whitespace in method signature. (WebCore::EventHandler::passWheelEventToWidget): Fixes whitespace in method signature. (WebCore::EventHandler::passMouseMoveEventToSubframe): Fixes whitespace in method signature.
- platform/android/ClipboardAndroid.h: Modified. Fixes header include order and indenting.
- platform/android/CursorAndroid.cpp: Modified. (WebCore::grabCursor): Fixes function braces. (WebCore::grabbingCursor): Fixes function braces.
- platform/android/FileChooserAndroid.cpp: Modified. (WebCore::FileChooser::basenameForWidth): Fixes braces on while statement, and updates String::copy to String::threadsafeCopy.
- platform/android/FileSystemAndroid.cpp: Modified. Fixes header include order. (WebCore::unloadModule): Fixes zero test. (WebCore::writeToFile): Fixes if statement structure.
- platform/android/KeyEventAndroid.cpp: Modified. (WebCore::windowsKeyCodeForKeyEvent): Fixes switch statement indenting. (WebCore::keyIdentifierForAndroidKeyCode): Fixes switch statement indenting.
- platform/android/ScreenAndroid.cpp: Modified. Fixes header include order and switch statement indenting.
- platform/android/TemporaryLinkStubs.cpp: Modified. Fixes header include order.
- 3:25 PM Changeset in webkit [50005] by
-
- 4 edits1 add in trunk/LayoutTests
2009-10-23 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Modified the tests results according to the last changes due
to the fixes of the bug (r49985):
https://bugs.webkit.org/show_bug.cgi?id=29697.
- platform/gtk/editing/execCommand/4916541-expected.txt:
- platform/gtk/editing/execCommand/5138441-expected.txt:
- platform/gtk/editing/execCommand/5481523-expected.txt:
- platform/gtk/editing/execCommand/indent-paragraphs-expected.txt: Added.
- 3:16 PM Changeset in webkit [50004] by
-
- 4 edits4 adds in trunk
MSAA: Name for image elements should use alt attribute text
https://bugs.webkit.org/show_bug.cgi?id=30727
<rdar://problem/7328291>
Reviewed by Alice Liu.
WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::createInstance):
If the AccessibilityObject is an image, return an AccessibleImage.
- AccessibleImage.cpp: Added.
(AccessibleImage::AccessibleImage):
Call the base constructor.
(AccessibleImage::name):
If the object is not an AccessibilityRenderObject, return the base's
name(). Look first for an ARIA "labeled-by" attribute, then look for an
alternate text attribute. Fall back to the base's name().
- AccessibleImage.h: Added.
(AccessibleImage::~AccessibleImage):
- WebKit.vcproj/WebKit.vcproj:
Add AccessibleImage to the project.
LayoutTests:
- platform/win/accessibility/img-alt-attribute-expected.txt: Added.
- platform/win/accessibility/img-alt-attribute.html: Added.
- 2:49 PM Changeset in webkit [50003] by
-
- 2 edits in trunk/WebKitTools
2009-10-23 Eric Seidel <eric@webkit.org>
No review, only adding Alice to the list of reviewers.
- Scripts/modules/committers.py:
- 2:45 PM Changeset in webkit [50002] by
-
- 2 edits in trunk/WebCore
Another shot at a fixed build.
- DerivedSources.cpp:
- 2:33 PM Changeset in webkit [50001] by
-
- 2 edits in trunk/WebCore
Another shot at a fixed build.
- html/HTMLOptionsCollection.idl:
- 2:25 PM Changeset in webkit [50000] by
-
- 1 edit in trunk/WebCore/ChangeLog
50,000!
- ChangeLog: Point out revision 50,000.
- 2:25 PM Changeset in webkit [49999] by
-
- 2 edits in trunk/WebKit/win
Try and fix the windows build.
- Interfaces/WebKit.idl:
- 2:12 PM Changeset in webkit [49998] by
-
- 26 edits8 adds3 deletes in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection
Reviewed by Anders Carlsson.
- Make .tags() only work for HTMLAllCollections in JS. .tags() is still available for all HTMLCollection like objects in Objective-C since that is API.
- Auto-generate HTMLAllCollection.
Test: fast/dom/HTMLDocument/document-all.html
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLAllCollection.cpp: Removed.
- bindings/js/JSHTMLAllCollection.h: Removed.
- bindings/js/JSHTMLAllCollectionCustom.cpp: Added.
(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::getCallData):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
- bindings/js/JSHTMLDocumentCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.cpp:
(WebCore::Document::all):
- dom/Document.h:
- dom/HTMLAllCollection.idl: Removed.
- html/HTMLAllCollection.cpp: Added.
(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::~HTMLAllCollection):
- html/HTMLAllCollection.h: Added.
- html/HTMLAllCollection.idl: Added.
- html/HTMLCollection.h:
- html/HTMLCollection.idl:
- html/HTMLDocument.idl:
- page/DOMWindow.idl:
LayoutTests: Update and add test for https://bugs.webkit.org/show_bug.cgi?id=30695
Drop .tags() support from HTMLCollection
Reviewed by Anders Carlsson.
- fast/dom/HTMLDocument/document-all-expected.txt: Added.
- fast/dom/HTMLDocument/document-all.html: Added.
- fast/dom/HTMLDocument/script-tests: Added.
- fast/dom/HTMLDocument/script-tests/document-all.js: Added.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/script-tests/domListEnumeration.js:
- fast/dom/undetectable-document-all-expected.txt:
- fast/js/global-constructors-expected.txt:
- 1:47 PM Changeset in webkit [49997] by
-
- 4 edits in trunk/WebCore
2009-10-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: pull basic sidebar implementation into the Panel.
- inspector/front-end/Panel.js: (WebInspector.Panel): (WebInspector.Panel.prototype.jumpToPreviousSearchResult): (WebInspector.Panel.prototype.handleKeyEvent): (WebInspector.Panel.prototype._createSidebar): (WebInspector.Panel.prototype._startSidebarDragging): (WebInspector.Panel.prototype._sidebarDragging): (WebInspector.Panel.prototype._endSidebarDragging): (WebInspector.Panel.prototype._updateSidebarWidth): (WebInspector.Panel.prototype.setCenterViewWidth):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.setCenterViewWidth):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.setCenterViewWidth):
- 1:43 PM Changeset in webkit [49996] by
-
- 2 edits in trunk/WebCore
2009-10-23 Jens Alfke <snej@chromium.org>
Reviewed by Dimitri Glazkov.
Slight optimizations to object returning and exception handling in generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30599
- bindings/scripts/CodeGeneratorV8.pm: Generate better code
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): Added overload that takes a Ref<>
- bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Remove unnecessary template param to prevent compile error
- 1:35 PM Changeset in webkit [49995] by
-
- 8 edits1 add in trunk
2009-10-23 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
Volume slider always starts at half volume
https://bugs.webkit.org/show_bug.cgi?id=28322
- media/video-volume-slider.html: Added. Pixel test for the volume slider of the media control. This test assumes volume slider is implemented and usable. It moves the mouse over the right bottom corner of a video element to trigger the volume slider. If volume slider is not implemented at all, you'll only see a video element with the first frame.
- platform/gtk/Skipped: The above test requires a volume slider so it's skipped.
- platform/mac/Skipped: ditto.
- platform/win/Skipped: ditto.
2009-10-23 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
Volume slider always starts at half volume
https://bugs.webkit.org/show_bug.cgi?id=28322
Sets the value attribute of volume slider to the volume attribute
of the media element. Also update the value attribute of the
input element for the volume slider when the volume attribute
of the media element is updated.
Test: media/video-volume-slider.html
- rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::update): Set the value attribute of the input element for the volume slider using the current volume of the media element.
- rendering/MediaControlElements.h: Add method definition of update().
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider): Creates a volume slider with value attribute equals to the current volume attribute of the media element.
- 1:26 PM Changeset in webkit [49994] by
-
- 2 edits in trunk/WebCore
2009-10-23 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
Chrome Linux: fix caret positioning in LTR complex languages
The caret is positioned off by one in languages like Thai.
A group of us spent a while trying various approaches to write a test
for this; however, since it is only that the blinking cursor is
displayed incorrectly, we concluded it can not be tested.
(Patch by Hironori Bono.)
- platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::selectionRectForComplexText):
- 1:13 PM Changeset in webkit [49993] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-23 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Add a layout test to assert that media element implementors do not
advance currentTime after being paused.
- media/video-pause-immediately-expected.txt: Added.
- media/video-pause-immediately.html: Added.
- 1:09 PM Changeset in webkit [49992] by
-
- 10 edits in trunk/WebCore
2009-10-23 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
Fix Chromium build after IsoldatedWorld change (r49963).
https://bugs.webkit.org/show_bug.cgi?id=30719
- bindings/ScriptControllerBase.cpp:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInIsolatedWorld):
- bindings/v8/ScriptController.cpp: (WebCore::mainThreadNormalWorld):
- bindings/v8/ScriptController.h: (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell):
- dom/Document.cpp: (WebCore::Document::createWrapperCache):
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- xml/XMLHttpRequest.cpp:
- xml/XMLHttpRequest.h:
- 1:05 PM Changeset in webkit [49991] by
-
- 3 edits in trunk/LayoutTests
2009-10-23 Victor Wang <victorw@chromium.org>
Reviewed by Eric Seidel.
Update the expected pixel result for test svg-as-background-6.html
The old result is incorrect because of the wrong SVG masking offset calculation.
Patch http://trac.webkit.org/changeset/49598 fixed the issue.
The pixel result of this layout test needs to be updated.
- platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
- 12:48 PM Changeset in webkit [49990] by
-
- 7 edits2 adds in trunk
2009-10-23 Xiaomei Ji <xji@chromium.org>
Reviewed by Sam Weinig.
Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
for a zoomed and scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30689.
The real cause is the wrong calculation of event.clientX/Y when
page is zoomed and scolled.
After Sam fixed the event.clientX/Y in r49551, the hit test point
should be recalculated (revert r49490).
- fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-expected.txt: Added.
- fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html: Added.
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
- fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
- fast/dom/elementFromPoint-relative-to-viewport.html:
2009-10-23 Xiaomei Ji <xji@chromium.org>
Reviewed by Sam Weinig.
Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
for a zoomed and scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30689.
The real cause is the wrong calculation of event.clientX/Y when
page is zoomed and scolled.
After Sam fixed the event.clientX/Y in r49551, the hit test point
should be recalculated (revert r49490).
Test: fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html
- dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when page is zoomed and scrolled.
- 12:38 PM Changeset in webkit [49989] by
-
- 5 edits2 adds in trunk/WebCore
Adding a class that allows us to enable/disable features at
runtime. Adding a flag to enable database support.
Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-22
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=30653
- WebCore.gypi:
- bindings/v8/RuntimeEnabledFeatures.cpp: Added.
- bindings/v8/RuntimeEnabledFeatures.h: Added.
(WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::databaseEnabled):
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
- page/DOMWindow.idl:
- 12:30 PM Changeset in webkit [49988] by
-
- 2 edits in trunk/WebCore
2009-10-23 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Inspector injects _inspectorCommandLineAPI into global object when opened
https://bugs.webkit.org/show_bug.cgi?id=30675
- inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): (InjectedScript._evaluateOn): (InjectedScript.addInspectedNode): (InjectedScript._ensureCommandLineAPIInstalled): Moved _inspectorCommandLineAPI from window to console.
- 12:23 PM Changeset in webkit [49987] by
-
- 2 edits in trunk/WebCore
2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Tor Arne Vestbø.
[Qt] don't undef NULL in Symbian emulator
npapi.h way of defining mwerks compiler,intel
and win32 are all true for Symbian emulator.
Changed the definions so that NULL won't be undefined
when compiling for Symbian emulator nor target HW.
- bridge/npapi.h:
- 12:14 PM Changeset in webkit [49986] by
-
- 2 edits in trunk/WebCore
2009-10-23 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Correct linking of sqlite3 for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30569
".lib" will try to include library as static library
causing the library to be searched from wrong directory and if found
will be statically linked instead of the inteded dynamic linking.
- WebCore.pro:
- 12:00 PM Changeset in webkit [49985] by
-
- 21 edits2 adds in trunk
REGRESSION: Copy is copying incorrect background-color
<rdar://problem/7248529>
https://bugs.webkit.org/show_bug.cgi?id=29697
Patch by Enrica Casucci <enrica@apple.com> on 2009-10-23
Reviewed by Adele Peterson.
WebCore:
Test: editing/execCommand/indent-paragraphs.html
This change removes the BackgroundColor from the list
of inheritable CSS properties and changes significantly
the way we perform indentation.
The new implementation of IndentOutdentCommand uses a new method
defined in CompositeEditCommand called moveParagraphWithClones.
This is an improved version of the original moveParagraph that
is aimed at preserving the original markup of the paragraph being
moved.
- editing/ApplyStyleCommand.cpp:
(WebCore::): removed CSSPropertyBackgroundColor from editingStyleProperties.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::CompositeEditCommand): Removed trailing blanks.
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Removed trailing blanks.
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added.
(WebCore::CompositeEditCommand::cleanupAfterDeletion): Added.
(WebCore::CompositeEditCommand::moveParagraphWithClones): Added.
(WebCore::CompositeEditCommand::moveParagraphs): Modified to use cleanupAfterDeletion.
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Removed trailing blanks.
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Removed trailing blanks.
(WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Removed trailing blanks.
- editing/CompositeEditCommand.h: Added three new methods.
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentIntoBlockquote): Changed to use moveParagraphWithClones.
(WebCore::IndentOutdentCommand::indentRegion): Removed comment.
- editing/IndentOutdentCommand.h: Removed prepareBlockquoteLevelForInsertion method.
LayoutTests:
All the following tests have been re-baselined because
the indent command now preserves the original markup.
A new test (indent-paragraph.html) has been added to test
several indent combinations not covered by the existing tests.
- editing/execCommand/19087-expected.txt:
- editing/execCommand/19653-1-expected.txt:
- editing/execCommand/indent-div-inside-list-expected.txt:
- editing/execCommand/indent-nested-blockquotes-expected.txt:
- editing/execCommand/indent-nested-div-expected.txt:
- editing/execCommand/indent-paragraphs.html: Added.
- editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
- editing/execCommand/indent-with-style-expected.txt:
- editing/inserting/5994480-2-expected.txt:
- platform/mac/editing/execCommand/4641880-2-expected.txt:
- platform/mac/editing/execCommand/4916541-expected.txt:
- platform/mac/editing/execCommand/5138441-expected.txt:
- platform/mac/editing/execCommand/5481523-expected.txt:
- platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Added.
- platform/mac/editing/execCommand/indent-selection-expected.txt:
- platform/mac/editing/pasteboard/select-element-1-expected.txt:
- 11:57 AM Changeset in webkit [49984] by
-
- 2 edits in trunk/WebKitTools
2009-10-23 Eric Seidel <eric@webkit.org>
Reviewed by Eric Carlson.
fast/media/mq-transform-02.html failed on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=30700
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Update QuickTime version check.
- 10:34 AM Changeset in webkit [49983] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
Isolated worlds tests now pass, removing then from the Skipped
list.
- platform/win/Skipped:
- 9:45 AM Changeset in webkit [49982] by
-
- 2 edits in trunk/WebKitTools
wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
character measurement APIs that are private on Tiger.
- 9:42 AM Changeset in webkit [49981] by
-
- 3 edits in trunk/WebKit/wx
wx build fix. Update the globalObject calls after changes.
- 9:34 AM Changeset in webkit [49980] by
-
- 1 edit in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css
Changed anchor style to take a class name
- 8:53 AM Changeset in webkit [49979] by
-
- 2 edits in trunk/WebKit/mac
2009-10-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by John Sullivan.
<rdar://problem/7322847>
Pressing space bar key in full screen mode should pause movie but doesn't
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController keyDown:]): New, toggle playback on space key. (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Play button action is now called togglePlaying. (-[WebVideoFullscreenHUDWindowController togglePlaying:]): Rename from playingChanged.
- 7:30 AM Changeset in webkit [49978] by
-
- 1 edit in trunk/WebKit/qt/Api/qwebframe.cpp
Qt build fix
- 7:07 AM Changeset in webkit [49977] by
-
- 2 edits in trunk/JavaScriptCore
Fixes a leak in createThreadInternal on Android.
https://bugs.webkit.org/show_bug.cgi?id=30698
Patch by Steve Block <steveblock@google.com> on 2009-10-23
Reviewed by Dmitry Titov.
- wtf/ThreadingPthreads.cpp: Modified.
(WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.
- 5:45 AM Changeset in webkit [49976] by
-
- 3 edits in trunk/WebCore
Adds missing UnusedParam.h includes, required when INSPECTOR is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=30677
Patch by Steve Block <steveblock@google.com> on 2009-10-23
Reviewed by Eric Seidel.
Build fix, no new tests required.
- page/Console.cpp: Modified. Added UnusedParam.h include.
- workers/WorkerContext.cpp: Modified. Added UnusedParam.h include.
- 5:02 AM Changeset in webkit [49975] by
-
- 2 edits in trunk/WebCore
[Qt] Plugins : Use window's winId() instead of the widget's.
2009-10-23 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
[Qt] Plugins : Use window's winId() instead of the widget's.
As per, https://developer.mozilla.org/en/NPN_GetValue
NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the
plug-in is displayed; returns Window".
The issue was found because NPNVNetscapeWindow winId() ends up creating
a native window resulting in flicker.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::getValue):
- 5:02 AM Changeset in webkit [49974] by
-
- 2 edits in trunk/WebCore
[Qt] Windowless Plugins : Don't use m_clipRect when painting.
2009-10-23 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
[Qt] Windowless Plugins : Don't use m_clipRect when painting.
Though it works, it is not correct to use m_clipRect for painting
in Windowless mode. Instead, the rect paramater that is passed
as a part of PluginView::paint() must be used. This change will
also result in some speedup since previously we used to paint all
the visible parts of a windowless plugin (even if those parts were
not dirty).
Also, fix invalidateRect() to compute the correct width and height.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint): (WebCore::PluginView::invalidateRect):
- 5:02 AM Changeset in webkit [49973] by
-
- 4 edits1 add in trunk/WebCore
Plugins : Use test.swf in the plugins manual tests.
They previously referenced youtube videos which among other things are
cumbersome to use without internet connection. The old youtube link is
just commented out so that testing with youtube can be done with
little effort.
- 4:47 AM Changeset in webkit [49972] by
-
- 3 edits in trunk/LayoutTests
2009-10-23 Xan Lopez <xlopez@igalia.com>
Use the correct Skipped file ...
- platform/gtk/Skipped:
- platform/mac/Skipped:
- 4:43 AM Changeset in webkit [49971] by
-
- 2 edits in trunk/LayoutTests
2009-10-23 Xan Lopez <xlopez@igalia.com>
Skip new tests missing expected results.
- platform/mac/Skipped:
- 1:14 AM Changeset in webkit [49970] by
-
- 2 edits1 add in trunk/WebCore
Fix the Windows Release build by moving Accessibility files
into all-in-one file and excluding them from the build.
Reviewed by Jon Honeycutt.
- WebCore.vcproj/WebCore.vcproj:
- accessibility/AccessibilityAllInOne.cpp: Added.
Oct 22, 2009:
- 11:22 PM Changeset in webkit [49969] by
-
- 16 edits in trunk
Update configurations to support the mysterious future.
Rubber-stamped by Brady Eidson.
- 10:27 PM Changeset in webkit [49968] by
-
- 2 edits in trunk/WebKitTools
Build fix following bug #30696.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
- 10:16 PM Changeset in webkit [49967] by
-
- 23 edits2 deletes in trunk/WebKitSite
Update to WordPress 2.8.5.
- blog:
- 10:06 PM Changeset in webkit [49966] by
-
- 3 edits in trunk/WebKit/qt
Build fix following bug #30696.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (speculative build fix - qt is currently already broken!)
- Api/qwebelement.cpp:
(setupScriptContext):
- Api/qwebframe.cpp:
(QWebFrame::evaluateJavaScript):
- 9:57 PM Changeset in webkit [49965] by
-
- 2 edits in trunk/WebKit/mac
Build fix following bug #30696.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::evaluate):
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::getProperty):
(WebKit::NetscapePluginInstanceProxy::setProperty):
(WebKit::NetscapePluginInstanceProxy::removeProperty):
(WebKit::NetscapePluginInstanceProxy::hasProperty):
(WebKit::NetscapePluginInstanceProxy::hasMethod):
(WebKit::NetscapePluginInstanceProxy::enumerate):
- 9:48 PM Changeset in webkit [49964] by
-
- 3 edits in trunk/WebKit/gtk
Build fix following bug #30696.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by NOBODY (build fix).
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::windowObjectCleared):
- webkit/webkitwebframe.cpp:
(webkit_web_frame_get_global_context):
- 9:33 PM Changeset in webkit [49963] by
-
- 101 edits in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=30696
Add support for IsolatedWorlds to JSC bindings.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
Reviewed by Sam Weinig & Geoff Garen.
An IsolatedWorld is basically a parallel, separate copy of the window shells and DOM wrapper objects for
a given document. To support isolation this patch:
- Adds support to the ScriptController to track multiple window shells, one per world.
- Adds support to Document to support multiple separate wrapper-maps, one per world.
- Replaces the single global DOM wrapper map (on the WebCoreJSClientData) with separate maps, stored on the (new) IsolatedWorld objects.
In addition to supporting separate copies of these objects, two other features are supported:
- It is necessary to track the current world on entry into JSC, so that within callbacks out to WebCore we can determine which world (and as such, set of DOM bindings) we should be operating on.
- EventListeners & Callbacks are run in the world they were registered in. This requires the handler to retain a reference to the world.
No new tests. (Enabled existing isolated world layout tests.)
- WebCore.base.exp:
- bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMBinding.cpp:
(WebCore::removeWrappers):
(WebCore::DOMObjectWrapperMap::get):
(WebCore::DOMObjectWrapperMap::set):
(WebCore::DOMObjectWrapperMap::remove):
(WebCore::DOMObjectWrapperMap::take):
(WebCore::IsolatedWorld::IsolatedWorld):
(WebCore::IsolatedWorld::~IsolatedWorld):
(WebCore::EnterIsolatedWorld::EnterIsolatedWorld):
(WebCore::EnterIsolatedWorld::~EnterIsolatedWorld):
(WebCore::JSGlobalDataWorldIterator::JSGlobalDataWorldIterator):
(WebCore::JSGlobalDataWorldIterator::operator bool):
(WebCore::JSGlobalDataWorldIterator::operator*):
(WebCore::JSGlobalDataWorldIterator::operator->):
(WebCore::JSGlobalDataWorldIterator::operator++):
(WebCore::getCurrentWorld):
(WebCore::getNormalWorld):
(WebCore::commonNormalWorld):
(WebCore::commonCurrentWorld):
(WebCore::DOMObjectHashTableMap::mapFor):
(WebCore::DOMObjectWrapperMap::mapFor):
(WebCore::forgetDOMObject):
(WebCore::getCachedDOMNodeWrapper):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::forgetAllDOMNodesForDocument):
(WebCore::forgetWorldOfDOMNodesForDocument):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markActiveObjectsForContext):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::allowsAccessFromFrame):
(WebCore::printErrorMessageForFrame):
(WebCore::JSC_DebuggerCallFrame_evaluateInWorld):
(WebCore::JSC_callInWorld):
(WebCore::JSC_constructInWorld):
(WebCore::JSC_evaluateInWorld):
- bindings/js/JSDOMBinding.h:
(WebCore::IsolatedWorld::rememberDocument):
(WebCore::IsolatedWorld::forgetDocument):
(WebCore::IsolatedWorld::rememberScriptController):
(WebCore::IsolatedWorld::forgetScriptController):
(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::currentWorld):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):
(WebCore::debuggerWorld):
(WebCore::pluginWorld):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
(WebCore::toJSDOMGlobalObject):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::printErrorMessage):
(WebCore::JSDOMWindowBase::commonJSGlobalData):
(WebCore::toJS):
(WebCore::toJSDOMWindow):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::createWindow):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):
(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::toJS):
(WebCore::toJSDOMWindowShell):
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
- bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
- bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
- bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/JSInspectorBackendCustom.cpp:
(WebCore::JSInspectorBackend::databaseForId):
(WebCore::JSInspectorBackend::inspectedWindow):
(WebCore::JSInspectorBackend::nodeForId):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::parseCode):
- bindings/js/JSLazyEventListener.h:
(WebCore::JSLazyEventListener::create):
- bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::markChildren):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::markChildren):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):
- bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::constructXMLHttpRequest):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::executeFunctionInContext):
(WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction):
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):
- bindings/js/ScriptController.h:
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::globalObject):
(WebCore::ScriptController::forgetWorld):
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
- bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
- bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
- bindings/js/ScriptObjectQuarantine.cpp:
(WebCore::getQuarantinedScriptObject):
- bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):
- bindings/js/ScriptState.h:
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::evaluate):
- bindings/objc/DOMInternal.mm:
(-[WebScriptObject _initializeScriptDOMNodeImp]):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
- dom/Document.cpp:
(WebCore::Document::createWrapperCache):
- dom/Document.h:
(WebCore::Document::wrapperCacheMap):
(WebCore::Document::getWrapperCache):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
- inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchWindowObjectAvailable):
- platform/network/mac/AuthenticationMac.mm:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::dropProtection):
- xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::create):
WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
Reviewed by Sam Weinig & Geoff Garen.
- WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame globalContext]):
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):
- WebView/WebView.mm:
(-[WebView aeDescByEvaluatingJavaScriptFromString:]):
WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by Sam Weinig & Geoff Garen.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
(WebFrame::globalContext):
(WebFrame::windowObjectCleared):
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld):
- WebFrame.h:
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=30696
Enable isolated-worlds tests on mac.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
Reviewed by Sam Weinig & Geoff Garen.
Add private interface for DRT to invoke execution in a given world.
- DumpRenderTree/LayoutTestController.cpp:
(evaluateScriptInIsolatedWorldCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::evaluateScriptInIsolatedWorld):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=30696
Enable isolated-worlds tests on mac.
- Update the results to switch from windows to unix line-endings.
- Update all-window-prototypes.html to allow for properties on the global object with null prototypes (just skip over them).
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-19
Reviewed by Sam Weinig & Geoff Garen.
- http/tests/security/isolatedWorld/all-window-properties-expected.txt:
- http/tests/security/isolatedWorld/all-window-prototypes-expected.txt:
- http/tests/security/isolatedWorld/all-window-prototypes.html:
- http/tests/security/isolatedWorld/body-properties-expected.txt:
- http/tests/security/isolatedWorld/body-prototype-expected.txt:
- http/tests/security/isolatedWorld/document-properties-expected.txt:
- http/tests/security/isolatedWorld/document-prototype-expected.txt:
- http/tests/security/isolatedWorld/global-variables-expected.txt:
- http/tests/security/isolatedWorld/image-properties-expected.txt:
- http/tests/security/isolatedWorld/image-prototype-expected.txt:
- http/tests/security/isolatedWorld/location-properties-expected.txt:
- http/tests/security/isolatedWorld/location-prototype-expected.txt:
- http/tests/security/isolatedWorld/number-prototype-expected.txt:
- http/tests/security/isolatedWorld/object-prototype-expected.txt:
- http/tests/security/isolatedWorld/storage-properties-expected.txt:
- http/tests/security/isolatedWorld/storage-prototype-expected.txt:
- http/tests/security/isolatedWorld/string-prototype-expected.txt:
- http/tests/security/isolatedWorld/window-properties-expected.txt:
- platform/mac/Skipped:
- 9:12 PM Changeset in webkit [49962] by
-
- 2 edits in trunk/WebCore
2009-10-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: EventListenersSidebarPane TODO No Longer Needed
https://bugs.webkit.org/show_bug.cgi?id=30705
- inspector/front-end/EventListenersSidebarPane.js:
- 5:22 PM Changeset in webkit [49961] by
-
- 3 edits in trunk/LayoutTests
Updating expected results - unreviewed.
Updated expected computed style results on Windows after r49959.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 5:00 PM Changeset in webkit [49960] by
-
- 3 edits in trunk/WebCore
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=30506
<rdar://problem/7319845> Resources that the server sent as 304 not modified are not shown
in the inspectors resource pane
I don't know how to make a test for this.
The issue here was that preloaded resources weren't added to DocLoader document resource set,
but Web Inspector asked DocLoader to fetch data from CachedResource. Even when (if) document
parser eventually requested the same resource for real and it got added to resource set, it
was too late - the Inspector wasn't updated.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
- inspector/InspectorResource.h: Fix the issue by trying to fetch corresponding CachedResource harder - also look in global cache. This seems safe, and easier than updating the Inspector on transitions between resource states (revalidate vs. revalidate done and preload vs. non-preload).
- 4:34 PM Changeset in webkit [49959] by
-
- 17 edits36 adds in trunk
WebCore: Fix for <rdar://problem/6942706> ER: Add a CSS property that allows
shadows to work for SVG content
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=30479
Reviewed by Dan Bernstein.
This patch adds a new SVG-specific CSS property called -webkit-
shadow that has the same syntax as -webkit-box-shadow
Add CSSPropertyWebkitShadow to the list of SVG CSS properties, and
make valueForShadow a member function rather than a static function
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSComputedStyleDeclaration.h:
Call valueForShadow for CSSPropertyWebkitShadow
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
Do standard CSS stuff for CSSPropertyWebkitShadow
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/SVGCSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
Set the appropriate shadow on the paint context if we have one.
This seems to be all we have to do to have an SVG-shaped shadow.
- rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
Add shadow to SVGRenderStyle. I added a new macro that I don't like
just because that's the way things are done here right now.
- rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::SVGRenderStyle):
(WebCore::SVGRenderStyle::operator==):
- rendering/style/SVGRenderStyle.h:
- rendering/style/SVGRenderStyleDefs.cpp:
(StyleShadowSVGData::StyleShadowSVGData):
(StyleShadowSVGData::operator==):
- rendering/style/SVGRenderStyleDefs.h:
(WebCore::StyleShadowSVGData::create):
(WebCore::StyleShadowSVGData::copy):
(WebCore::StyleShadowSVGData::operator!=):
LayoutTests: Tests for <rdar://problem/6942706> ER: Add a CSS property that
allows shadows to work for SVG content
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=30479
Reviewed by Dan Bernstein.
New results that include -webkit-shadow:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
New tests and their results.
- platform/mac/svg/css/arrow-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/arrow-with-shadow-expected.png: Added.
- platform/mac/svg/css/arrow-with-shadow-expected.txt: Added.
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.png: Added.
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
- platform/mac/svg/css/clippath-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/clippath-with-shadow-expected.png: Added.
- platform/mac/svg/css/clippath-with-shadow-expected.txt: Added.
- platform/mac/svg/css/group-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/group-with-shadow-expected.png: Added.
- platform/mac/svg/css/group-with-shadow-expected.txt: Added.
- platform/mac/svg/css/mask-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/mask-with-shadow-expected.png: Added.
- platform/mac/svg/css/mask-with-shadow-expected.txt: Added.
- platform/mac/svg/css/path-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/path-with-shadow-expected.png: Added.
- platform/mac/svg/css/path-with-shadow-expected.txt: Added.
- platform/mac/svg/css/stars-with-shadow-expected.checksum: Added.
- platform/mac/svg/css/stars-with-shadow-expected.png: Added.
- platform/mac/svg/css/stars-with-shadow-expected.txt: Added.
- platform/mac/svg/filters/shadow-on-filter-expected.checksum: Added.
- platform/mac/svg/filters/shadow-on-filter-expected.png: Added.
- platform/mac/svg/filters/shadow-on-filter-expected.txt: Added.
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.checksum: Added.
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
- svg/css/arrow-with-shadow.svg: Added.
- svg/css/circle-in-mask-with-shadow.svg: Added.
- svg/css/clippath-with-shadow.svg: Added.
- svg/css/getComputedStyle-basic-expected.txt:
- svg/css/group-with-shadow.svg: Added.
- svg/css/mask-with-shadow.svg: Added.
- svg/css/path-with-shadow.svg: Added.
- svg/css/stars-with-shadow.html: Added.
- svg/filters/shadow-on-filter.svg: Added.
- svg/filters/shadow-on-rect-with-filter.svg: Added.
- 4:07 PM Changeset in webkit [49958] by
-
- 4 edits in trunk/WebCore
2009-10-22 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25530
[Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels
Implements atk_object_ref_relation_set and LABEL_FOR/LABELLED_BY.
Also causes the accessible name for labeled controls to be based on
the label as expected, rather than based on the contents.
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityRenderObject.cpp: (correspondingLabelForControlElement):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkRelationSetFromCoreObject): (webkit_accessible_ref_relation_set): (webkit_accessible_class_init): (webkit_accessible_get_name):
- 2:32 PM Changeset in webkit [49957] by
-
- 4 edits2 adds in trunk
2009-10-22 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Added expected result for clicked-link-is-visited.html.
Removed test case from qt/Skipped as it works now.
- platform/qt/Skipped:
- platform/qt/fast/history: Added.
- platform/qt/fast/history/clicked-link-is-visited-expected.txt: Added.
2009-10-22 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Enable track visited links in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=30574
Test: fast/history/clicked-link-is-visited.html
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- 2:08 PM Changeset in webkit [49956] by
-
- 2 edits in trunk/WebCore
2009-10-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive"
https://bugs.webkit.org/show_bug.cgi?id=30663
Correctly handle focusing/blurring on inner <iframe>'s such as Source Frames.
- inspector/front-end/inspector.js: (WebInspector.windowFocused): fix for inner iframes (WebInspector.windowBlurred): fix for inner iframes (WebInspector.addMainEventListeners): change useCapture to false
- 1:33 PM Changeset in webkit [49955] by
-
- 4 edits in trunk/JavaScriptCore
Fixed ASSERT when opening Safari's Caches window while the Web Inspector
is open.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-22
Reviewed by Alexey Proskuryakov.
- runtime/Collector.cpp:
(JSC::typeName): Added two new types to the type name list in the Collector.
These types have been around for a while, but nobody remembered to consider them here.
- runtime/JSCell.h:
(JSC::JSCell::isPropertyNameIterator):
- runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::isPropertyNameIterator): Give the Collector
a way to tell if a cell is a JSPropertyNameIterator.
- 1:19 PM Changeset in webkit [49954] by
-
- 3 edits in trunk/WebCore
2009-10-22 Jaime Yap <jaimeyap@google.com>
Reviewed by Timothy Hatcher.
Makes a page reload optional when activating resource monitoring in
InspectorController. It leaves the default behavior as performing the reload.
Reload is an optional param so callsites do not have to change.
No new tests added.
- inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):
- inspector/InspectorController.h:
- 1:10 PM Changeset in webkit [49953] by
-
- 2 edits in trunk/WebKit/qt
2009-10-22 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Eric Seidel.
[Qt] Add Print Shortcut to QtLauncher
- QtLauncher/main.cpp: (MainWindow::setupUI):
- 1:06 PM Changeset in webkit [49952] by
-
- 2 edits1 delete in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=30686
Remove debug-specific def file.
Only Debug_All target uses JavaScriptCore_debug.dll naming, and since
that target is only used internally, maintaining two files just to
suppress a single link warning isn't worthwhile.
Reviewed by Jon Honeycutt.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Removed.
- 12:56 PM Changeset in webkit [49951] by
-
- 2 edits in trunk/WebCore
2009-10-22 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Fix memory leak in QNetworkReplyHandler::abort().
In QNetworkReplyHandler::release(), m_reply should no longer point to its parent
after being released.
https://bugs.webkit.org/show_bug.cgi?id=30167
No layout test available as a non-functional fix.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::abort): (WebCore::QNetworkReplyHandler::release):
- 12:15 PM Changeset in webkit [49950] by
-
- 4 edits in trunk/WebCore
2009-10-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fix DOMAgent leak.
- inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
- 11:35 AM Changeset in webkit [49949] by
-
- 19 edits in trunk/WebCore
2009-10-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Rework event listeners to not hold references to frame or V8 context.
Covered by existing layout tests: fast/events/attribute-listener*
- bindings/scripts/CodeGeneratorV8.pm: Added passing ScriptExecutionContext*
to event listener handling code.
- bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep): Changed to use currentContext().
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Reworked to match JSC logic. (WebCore::getEventListenerHandlerBody): Added ScriptExecutionContext* param.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Removed Frame* param
and usage.
(WebCore::V8AbstractEventListener::handleEvent): Chaged to use ScriptExecutionContext*.
(WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::getListenerObject): Ditto. (WebCore::V8AbstractEventListener::prepareListenerObject): Ditto.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Added ScriptExecutionContext* param. (WebCore::V8DOMWrapper::getEventListener): Ditto.
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Ditto.
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper): Removed ContextType* template param,
because it's no longer needed.
- bindings/v8/V8IsolatedWorld.h: (WebCore::V8IsolatedWorld::sharedContext): Renamed from shared_context.
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): Removed Frame* param and usage. (WebCore::V8LazyEventListener::callListenerFunction): Added ScriptExecutionContext* param. (WebCore::V8LazyEventListener::prepareListenerObject): Ditto.
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create): Reordered params to match JSC impl.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): Adjusted formatting to match WebKit style. (WebCore::V8Proxy::evaluateInNewContext): Changed to use m_context directly. (WebCore::V8Proxy::setInjectedScriptContextDebugId): Ditto. (WebCore::V8Proxy::createWrapperFromCacheSlowCase): Ditto. (WebCore::V8Proxy::isContextInitialized): Ditto. (WebCore::V8Proxy::updateDocumentWrapperCache): Ditto. (WebCore::V8Proxy::clearDocumentWrapperCache): Ditto. (WebCore::V8Proxy::disposeContextHandles): Added explicit disposing of m_context. (WebCore::V8Proxy::clearForClose): Changed to use m_context directly. (WebCore::V8Proxy::clearForNavigation): Ditto. (WebCore::V8Proxy::setSecurityToken): Ditto. (WebCore::V8Proxy::updateDocument): Ditto. (WebCore::V8Proxy::initContextIfNeeded): Ditto. (WebCore::V8Proxy::context): Changed to use v8::Local. (WebCore::V8Proxy::mainWorldContext): Changed to use m_context directly. (WebCore::V8Proxy::setContextDebugId): Ditto. (WebCore::toV8Context):
- bindings/v8/V8Proxy.h: Removed shared_context decl, changed to use straight
v8::Persistent for m_context.
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::workerProxy): Added. (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Removed
WorkerContextExecutionProxy* param.
(WebCore::V8WorkerContextEventListener::handleEvent): Started using ScriptExecutionContext*.
(WebCore::V8WorkerContextEventListener::reportError): Ditto.
(WebCore::V8WorkerContextEventListener::callListenerFunction): Ditto.
(WebCore::V8WorkerContextEventListener::getReceiverObject): Ditto.
- bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create): Removed
WorkerContextExecutionProxy* param.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener): Removed ContextType*
template param.
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): Removed Frame* param. (WebCore::V8EventListener::getListenerFunction): Started using ScriptExecutionContext*. (WebCore::V8EventListener::callListenerFunction): Ditto.
- bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): Removed Frame* param.
- 11:10 AM Changeset in webkit [49948] by
-
- 4 edits in trunk/WebKit/mac
2009-10-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein & Simon Fraser.
<rdar://problem/7297717>
https://bugs.webkit.org/show_bug.cgi?id=30323
Play/pause button in full-screen video controller does not reflect current state
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController setMediaElement:WebCore::]): Register for QTMovieRateDidChangeNotification (-[WebVideoFullscreenController rateChanged:]): Call HUD controller when rate changes.
- WebView/WebVideoFullscreenHUDWindowController.h:
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Call updateRate so play button reflects playback state. (-[WebVideoFullscreenHUDWindowController updateRate]): New, set play button state according to movie state. (-[WebVideoFullscreenHUDWindowController playingChanged:]): Only call [self playing] once.
- 10:49 AM Changeset in webkit [49947] by
-
- 5 edits in trunk/WebCore
2009-10-14 Gaurav Shah <gauravsh@google.com>
Reviewed by Darin Fisher.
Replaces temporary link stub for <keygen> tag handler for the Chromium
browser with a call via the Chromium Bridge.
- platform/SSLKeyGenerator.h:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
- platform/chromium/TemporaryLinkStubs.cpp: (WebCore::KURL::fileSystemPath): (WebCore::SharedBuffer::createWithContentsOfFile):
- 10:48 AM Changeset in webkit [49946] by
-
- 3 edits in trunk/WebCore
Fixes Chromium Mac pasteboard handling to flow through the same code paths as other platforms.
Patch by Avi Drissman <avi@chromium.org> on 2009-10-22
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=30591
- platform/chromium/ChromiumBridge.h:
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage):
- 10:33 AM Changeset in webkit [49945] by
-
- 6 edits in trunk/WebCore
2009-10-20 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Make accelerated compositing debug indicators work in release builds
https://bugs.webkit.org/show_bug.cgi?id=30588
Allow some debug indicators, that show which page elements go into compositing layers,
to work in release builds, when the runtime prefs are set.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): (WebCore::GraphicsLayer::setZPosition):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::clearBorderColor): (WebCore::GraphicsLayer::showRepaintCounter): (WebCore::GraphicsLayerCA::GraphicsLayerCA): (WebCore::GraphicsLayerCA::updateMasksToBounds): (WebCore::GraphicsLayerCA::updateLayerDrawsContent): (WebCore::GraphicsLayerCA::setDebugBorder): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::setupContentsLayer):
- platform/graphics/mac/WebLayer.mm:
- 10:30 AM Changeset in webkit [49944] by
-
- 2 edits in trunk/LayoutTests
2009-10-22 Xan Lopez <xlopez@igalia.com>
Skip failing tests that seems to be somewhat tied to the Mac
platform. See https://bugs.webkit.org/show_bug.cgi?id=30680
- platform/gtk/Skipped:
- 9:42 AM Changeset in webkit [49943] by
-
- 2 edits in trunk/WebKit/qt
Code standarlization for QGVLauncher.
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-22
RubberStamped by Tor Arne Vestbø.
1) Made member initilization lists in constructors
to be per line.
2) Made applyProxy method inline as all other methods in
WebPage class.
- QGVLauncher/main.cpp:
(WebPage::WebPage):
(WebPage::applyProxy):
(MainView::MainView):
(MainWindow::MainWindow):
(MainWindow::init):
- 9:34 AM Changeset in webkit [49942] by
-
- 2 edits in trunk/WebKit/qt
Add a Y-Axis rotation to QGVLauncher.
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-22
Reviewed by Tor Arne Vestbø.
It uses the QStateMachine API from Qt 4.6.
- QGVLauncher/main.cpp:
(WebView::WebView):
(WebView::setYRotation):
(WebView::yRotation):
(MainView::flip):
(MainView::animatedYFlip):
(SharedScene::SharedScene):
(SharedScene::webView):
(MainWindow::init):
(MainWindow::animatedYFlip):
(MainWindow::buildUI):
- 8:53 AM Changeset in webkit [49941] by
-
- 2 edits in trunk/LayoutTests
2009-10-22 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Fix video-played.js to use an error timeout based on time rather than function call count.
- media/video-played.js: (nowInSecs): Returns the current time in seconds. (playForMillisecs.callPauseIfTimeIsReached): Change from call counts to using elapsed time. (playForMillisecs): Ditto.
- 8:45 AM Changeset in webkit [49940] by
-
- 3 edits in trunk/WebCore
2009-10-22 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Pavel Feldman.
Inspector should support monitorEvents/un monitorEvents() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19879
- inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): Ignores event listeners generated by monitorEvent
- inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI._logEvent, _allEventTypes, _normalizeEventTypes, monitorEvent, unmonitorEvent.
- 8:28 AM Changeset in webkit [49939] by
-
- 2 edits in trunk/WebCore
2009-10-21 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: windowFocused and windowBlurred Fail to Clear/Mark Inspector as "inactive"
https://bugs.webkit.org/show_bug.cgi?id=30663
- inspector/front-end/inspector.js: (WebInspector.windowFocused): (WebInspector.windowBlurred):
- 8:23 AM Changeset in webkit [49938] by
-
- 2 edits in trunk/WebCore
2009-10-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Error - requestContentType [undefined] is not an object
https://bugs.webkit.org/show_bug.cgi?id=30666
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshFormData):
- 4:52 AM Changeset in webkit [49937] by
-
- 2 edits in trunk/WebCore
2009-10-22 Maxime Simon <Maxime Simon>
Reviewed by Holger Freyther.
[Haiku] Correction of the accented letter width (they were 2 characters long).
https://bugs.webkit.org/show_bug.cgi?id=30629
- platform/graphics/haiku/SimpleFontDataHaiku.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):
- 3:49 AM Changeset in webkit [49936] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-22 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
m_webView should be private attribute of the EditorClientGtk.
https://bugs.webkit.org/show_bug.cgi?id=30664
- WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
- 3:39 AM Changeset in webkit [49935] by
-
- 2 edits in trunk/LayoutTests
2009-10-22 Xan Lopez <xlopez@igalia.com>
libsoup can reconstruct URIs with empty querys now, so unskip
another bunch of tests.
- platform/gtk/Skipped:
- 3:24 AM Changeset in webkit [49934] by
-
- 2 edits in trunk/LayoutTests
2009-10-22 Xan Lopez <xlopez@igalia.com>
Unskip a couple of working tests.
- platform/gtk/Skipped:
- 12:15 AM Changeset in webkit [49933] by
-
- 6 edits in trunk
<rdar://problem/7270320> Screenshots of off-screen plug-ins are blank
<rdar://problem/7270314> After halting a transparent PluginView on
Windows, the transparency is applied twice
Reviewed by Dan Bernstein.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export WTF::deleteOwnedPtr(HDC).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Ditto.
WebCore:
Replace use of Frame::nodeImage() with a function that takes a snapshot
of a PluginView.
Reviewed by Dan Bernstein.
- plugins/PluginView.h:
Made paintWindowedPluginIntoContext() non-const, as it now calls
paintIntoTransformedContext(). Declare paintIntoTransformedContext()
and snapshot() for Windows platforms.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintIntoTransformedContext):
Paints into the passed HDC without applying any coordinate translations.
Code moved from paintWindowedPluginIntoContext() and paint(). Removed
the memset() of windowpos in lieu of assignment.
(WebCore::PluginView::paintWindowedPluginIntoContext):
Code moved to paintIntoTransformedContext().
(WebCore::PluginView::paint):
Ditto.
(WebCore::PluginView::snapshot):
Create a context, and if the plug-in is windowless, translate it so the
plug-in will draw at the correct location. Create a bitmap, and select
it into the context. Paint the plug-in, and create a BitmapImage from
the bitmap.
(WebCore::PluginView::halt):
Use snapshot().
- 12:11 AM Changeset in webkit [49932] by
-
- 2 edits in trunk/WebCore
2009-10-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix calculation of length in WebSocketChannel.cpp
https://bugs.webkit.org/show_bug.cgi?id=30656
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
Oct 21, 2009:
- 11:20 PM Changeset in webkit [49931] by
-
- 3 edits in trunk/WebKitTools
2009-10-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool's "patch failed to download an apply" error should give more information
https://bugs.webkit.org/show_bug.cgi?id=30632
- Scripts/modules/scm.py:
- Use the common run_command method instead of custom POpen code.
- Make run_command know how to take pipes as input.
- Scripts/modules/scm_unittest.py:
- Add new tests to cover change.
- Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
- 9:32 PM Changeset in webkit [49930] by
-
- 2 edits in trunk/WebKitTools
committers
- 4:57 PM Changeset in webkit [49929] by
-
- 2 edits in trunk/WebCore
Adding the ability to enable/disable functions in V8 at runtime.
Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-21
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=30650
- bindings/scripts/CodeGeneratorV8.pm:
- 4:47 PM Changeset in webkit [49928] by
-
- 6 edits11 adds21 deletes in trunk/LayoutTests
Combine local and session storage tests into one and use script-tests properly
https://bugs.webkit.org/show_bug.cgi?id=30640
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-21
Reviewed by Darin Adler.
I was apparently misusing the script-tests stuff. I changed all the tests to
test both local storage and session storage so that we can use the
make-test-script-wrappers stuff as is.
- storage/domstorage/clear-expected.txt: Added.
- storage/domstorage/clear.html: Added.
- storage/domstorage/complex-keys-expected.txt: Added.
- storage/domstorage/complex-keys.html: Added.
- storage/domstorage/complex-values-expected.txt: Added.
- storage/domstorage/complex-values.html: Added.
- storage/domstorage/localstorage/clear-expected.txt: Removed.
- storage/domstorage/localstorage/clear.html: Removed.
- storage/domstorage/localstorage/complex-keys-expected.txt: Removed.
- storage/domstorage/localstorage/complex-keys.html: Removed.
- storage/domstorage/localstorage/complex-values-expected.txt: Removed.
- storage/domstorage/localstorage/complex-values.html: Removed.
- storage/domstorage/localstorage/quota-expected.txt: Removed.
- storage/domstorage/localstorage/quota.html: Removed.
- storage/domstorage/localstorage/remove-item-expected.txt: Removed.
- storage/domstorage/localstorage/remove-item.html: Removed.
- storage/domstorage/quota-expected.txt: Added.
- storage/domstorage/quota.html: Added.
- storage/domstorage/remove-item-expected.txt: Added.
- storage/domstorage/remove-item.html: Added.
- storage/domstorage/script-tests/TEMPLATE.html: Added.
- storage/domstorage/script-tests/clear.js:
(test):
(runTest):
- storage/domstorage/script-tests/complex-keys.js:
(test):
(runTest):
- storage/domstorage/script-tests/complex-values.js:
(test):
(runTest):
- storage/domstorage/script-tests/no-quota.js: Removed.
- storage/domstorage/script-tests/quota.js:
(testQuota):
(testNoQuota):
(runTest):
- storage/domstorage/script-tests/remove-item.js:
(test):
(runTest):
- storage/domstorage/sessionstorage/clear-expected.txt: Removed.
- storage/domstorage/sessionstorage/clear.html: Removed.
- storage/domstorage/sessionstorage/complex-keys-expected.txt: Removed.
- storage/domstorage/sessionstorage/complex-keys.html: Removed.
- storage/domstorage/sessionstorage/complex-values-expected.txt: Removed.
- storage/domstorage/sessionstorage/complex-values.html: Removed.
- storage/domstorage/sessionstorage/no-quota-expected.txt: Removed.
- storage/domstorage/sessionstorage/no-quota.html: Removed.
- storage/domstorage/sessionstorage/remove-item-expected.txt: Removed.
- storage/domstorage/sessionstorage/remove-item.html: Removed.
- 4:39 PM Changeset in webkit [49927] by
-
- 5 edits in trunk/WebKitTools
Reviewed by Kevin Ollivier.
Update the Windows installer builder to work with Vista / Win 7 and with git.
https://bugs.webkit.org/show_bug.cgi?id=30649
- 4:10 PM Changeset in webkit [49926] by
-
- 4 edits in trunk
WebCore: Swedish search (and other languages as well) is broken while fixing Japanese search
https://bugs.webkit.org/show_bug.cgi?id=30646
Patch by Darin Adler <Darin Adler> on 2009-10-21
Rolled Japanese tailoring out that was done to fix
https://bugs.webkit.org/show_bug.cgi?id=30437 earlier.
It was overriding the locale-specific tailoring.
We'll land a fix once we figure out how to add the
Japanese tailoring without removing anything.
- editing/TextIterator.cpp: Rolled out r49924.
LayoutTests: Update since we rolled Japanese tailoring out that was done to fix
https://bugs.webkit.org/show_bug.cgi?id=30437 earlier.
Patch by Darin Adler <Darin Adler> on 2009-10-21
- fast/text/international/japanese-kana-letters-expected.txt: Update
test results to expect failure. We'll land results that expect
success once we re-fix the bug.
- 4:06 PM Changeset in webkit [49925] by
-
- 3 edits in trunk/LayoutTests
2009-10-21 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Update more media layout tests to use findMediaFile().
- media/controls-drag-timebar.html: Switch to using findMediaFile().
- media/video-currentTime-set.html: Remove src attribute and rely on findMediaFile() instead.
- 3:16 PM Changeset in webkit [49924] by
-
- 6 edits3 deletes in trunk
Roll out r49922 because it broke Tiger and SL in strange ways.
- 2:59 PM Changeset in webkit [49923] by
-
- 2 edits in trunk/WebCore
2009-10-21 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium build fix - add missing image to gypi.
- WebCore.gypi:
- 2:51 PM Changeset in webkit [49922] by
-
- 8 edits3 adds in trunk
WebCore: Fixes part of <http://webkit.org/b/30522>.
Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.
Reviewed by Eric Seidel.
Expose the description attribute that is now a member of
ExceptionBase as of r49723, so when a user logs an exception, they
can see the description in the Web Inspector.
Test: fast/dom/dom-exception-description.html
- dom/DOMCoreException.idl:
- dom/EventException.idl:
- dom/RangeException.idl:
- svg/SVGException.idl:
- xml/XMLHttpRequestException.idl:
- xml/XPathException.idl:
LayoutTests: Fixes part of <http://webkit.org/b/30522>.
Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.
Reviewed by Eric Seidel.
Adds a test to check the name and description of some DOM Exceptions.
- fast/dom/dom-exception-description-expected.txt: Added.
- fast/dom/dom-exception-description.html: Added.
- fast/dom/script-tests/dom-exception-description.js: Added.
- 1:47 PM Changeset in webkit [49921] by
-
- 2 edits in trunk/WebKitTools
2009-10-21 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Added conditional code to avoid using
gdk_window_get_root_coords if we do not have a gtk+ release newer
than 2.17.3.
https://bugs.webkit.org/show_bug.cgi?id=30636
- WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
- 1:28 PM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 1:22 PM WebKit Team edited by
- (diff)
- 1:02 PM Changeset in webkit [49920] by
-
- 2 edits in trunk/WebKit/mac
Rubber-stamped by Dan Bernstein.
- WebView/WebDynamicScrollBarsView.h:
Corrected a couple of long-obsolete comments regarding Safari's use of this class.
- 12:53 PM Changeset in webkit [49919] by
-
- 2 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30616>.
REGRESSION (r49036): Web Inspector: Summary graph no longer switching to size summary.
Reviewed by Timothy Hatcher.
Add a check to make sure a function we need to calculate percentages is
defined before we use it.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
- 12:43 PM Changeset in webkit [49918] by
-
- 4 edits in trunk/LayoutTests
2009-10-21 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Removed 5333725.html from Skipped and modified the expected
result of 5232159-expected.txt and fake-drag-expected.txt, this
modifications come from the changes in EventSender (bug 30633 and
bug 30636).
https://bugs.webkit.org/show_bug.cgi?id=30593
- LayoutTests/platform/gtk/Skipped:
- LayoutTests/platform/gtk/editing/selection/5232159-expected.txt:
- LayoutTests/platform/gtk/editing/selection/fake-drag-expected.tx :
- 12:36 PM Changeset in webkit [49917] by
-
- 3 edits in trunk/WebCore
2009-10-21 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
REGRESSION: Clicking on nodes in the console should take you to the element in the DOM
https://bugs.webkit.org/show_bug.cgi?id=27231
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatnode): Turns on ElementsTreeOutline.showInElementsPanelEnabled
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): Added ElementsTreeOutline.showInElementsPanelEnabled (WebInspector.ElementsTreeElement.prototype.onmousedown): Reveals the node in the Elements panel if treeOutline.showInElementsPanelEnabled is true.
- 12:22 PM Changeset in webkit [49916] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=30637
Fix a compiler warning in windows.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-21
Reviewed by Eric Seidel.
- loader/ResourceLoadNotifier.h:
- 12:18 PM Changeset in webkit [49915] by
-
- 3 edits in trunk/WebKitTools
2009-10-21 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Added dummy implementation for keepWebHistory()
https://bugs.webkit.org/show_bug.cgi?id=30592
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::keepWebHistory):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 12:10 PM Changeset in webkit [49914] by
-
- 2 edits in trunk/LayoutTests
2009-10-21 Victor Wang <victorw@chromium.org>
Reviewed by Eric Seidel.
Fix click-focus-anchor layout test to mimic click event.
- fast/events/click-focus-anchor.html:
- 12:03 PM Changeset in webkit [49913] by
-
- 2 edits in trunk/WebKitTools
2009-10-21 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fixed the double click condition, it is not double click if
we move in just in one direction.
https://bugs.webkit.org/show_bug.cgi?id=30636
- WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
- 11:55 AM Changeset in webkit [49912] by
-
- 2 edits in trunk/WebKitTools
2009-10-21 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Initialize the events completly before emitting them.
https://bugs.webkit.org/show_bug.cgi?id=30633
- WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
- 11:32 AM Changeset in webkit [49911] by
-
- 3 edits2 adds in trunk
Fix the crash when a node not in a document receives dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=30611
Reviewed by Darin Adler.
WebCore:
Test: fast/events/dispatch-event-no-document.html
- dom/EventTarget.cpp: Check for scriptExecutionContext() at the moment of dispatchEvent; do nothing if no context.
(WebCore::EventTarget::dispatchEvent):
LayoutTests:
- fast/events/dispatch-event-no-document-expected.txt: Added.
- fast/events/dispatch-event-no-document.html: Added.
- 11:25 AM Changeset in webkit [49910] by
-
- 2 edits in trunk/WebKitTools
wx build fix. Fix for when linking using --as-needed with gcc.
- 11:23 AM Changeset in webkit [49909] by
-
- 2 edits in trunk/WebCore
2009-10-21 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium Linux: disable subpixel text on layers.
https://bugs.webkit.org/show_bug.cgi?id=30635
http://code.google.com/p/chromium/issues/detail?id=25365
With the addition of layers for drawing rounded corners in r49641,
subpixel text on rounded rectangles broke. This is because the layer
only contains a single alpha channel and this is insufficient to
compose subpixel text correctly.
On Windows, a large body of code in TransparencyWin.cpp exists to try
to deal with this. Even then, in some cases, it downgrades to
anti-aliased text. We need a fix for the grevious effects quickly thus
this patch disables subpixel text when rendering into a layer.
This would be covered by existing tests except that subpixel text is
disabled for pixel tests on Chromium Linux.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::isCanvasMultiLayered): (WebCore::adjustTextRenderMode): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
- 11:13 AM Changeset in webkit [49908] by
-
- 2 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Include 'WebFrame.h' declared classes in wxPython bindings.
https://bugs.webkit.org/show_bug.cgi?id=30504
- 11:06 AM Changeset in webkit [49907] by
-
- 5 edits in trunk
wxMac build fixes. Fix issues with linking against wrong versions of sqlite3 and curl on Mac 10.4.
- 9:47 AM Changeset in webkit [49906] by
-
- 4 edits1 copy4 adds in trunk
WebCore: Fixed background-clip parsing regressions introduced in r46240.
Reviewed by Sam Weinig.
Test: fast/css/background-clip-text.html
- css/CSSParser.cpp:
(WebCore::parseBackgroundClip): Added this helper method.
(WebCore::CSSParser::parseFillShorthand): Use parseBackgroundClip() to
reparse the value. The old code called parseFillProperty() again, which
didn’t work, because parseFillProperty() advances the value list.
(WebCore::CSSParser::parseFillProperty): Changed to use
parseBackgroundClip().
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EFillBox): Added a case for
CSSValueWebkitText.
LayoutTests: Added a background-clip parsing test that would have caught some
regressions that were introduced in r46240.
Reviewed by Sam Weinig.
- fast/css/background-clip-text-expected.txt: Added.
- fast/css/background-clip-text.html: Added.
- fast/css/script-tests: Added.
- fast/css/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/backgrounds/repeat/script-tests/TEMPLATE.html.
- fast/css/script-tests/background-clip-text.js: Added.
(test):
- 6:57 AM Changeset in webkit [49905] by
-
- 3 edits in trunk/WebCore
2009-10-21 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Enable creation of custom SidebarTreeElements for different ProfileTypes
ProfileTypes can now create sidebar tree elements of custom types.
https://bugs.webkit.org/show_bug.cgi?id=30520
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.setRecordingProfile): (WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.CPUProfileType.prototype.createView): (WebInspector.CPUProfile.prototype.get head):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType.prototype.buttonClicked): (WebInspector.ProfileType.prototype.viewForProfile): (WebInspector.ProfileType.prototype.createView): (WebInspector.ProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile):
- 6:45 AM Changeset in webkit [49904] by
-
- 4 edits in trunk/WebCore
2009-10-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Selectors in the Styles pane should trigger a search for that selector when clicked
https://bugs.webkit.org/show_bug.cgi?id=17126
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.addNodesToSearchResult): only change focusedDOMNode on a manual search
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype._clickSelector): trigger a search
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditing): correctly start editing attribute value instead of name
- 6:33 AM Changeset in webkit [49903] by
-
- 2 edits in trunk/WebCore
2009-10-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fix DOM Agent leak.
- inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController):
- 6:08 AM Changeset in webkit [49902] by
-
- 1 edit3 adds in trunk/WebCore
2009-10-21 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
Plugins: Create manual tests for testing plugins
Create two test files:
- windowed.html - Test plugin in windowed mode.
- windowless.html - Test plugin in windowless mode.
- manual-tests/plugins/windowed.html: Added.
- manual-tests/plugins/windowless.html: Added.
- 2:10 AM Changeset in webkit [49901] by
-
- 2 edits in trunk/LayoutTests
2009-10-21 Xan Lopez <xlopez@igalia.com>
Skip another failing test.
- platform/gtk/Skipped:
- 12:52 AM Changeset in webkit [49900] by
-
- 2 edits in trunk/LayoutTests
2009-10-21 Xan Lopez <xlopez@igalia.com>
Skip a few more libxml2 related tests.
- platform/gtk/Skipped:
- 12:11 AM Changeset in webkit [49899] by
-
- 3 edits2 adds in trunk
2009-10-21 Satoshi Nakagawa <psychs@limechat.net>
Reviewed by Darin Adler.
Fixed Japanese text search problems.
Treat small kana letters and kana letters as different characters in search.
Do not ignore diacritic marks in search for Japanese texts.
- fast/text/international/japanese-kana-letters-expected.txt: Added.
- fast/text/international/japanese-kana-letters.html: Added.
2009-10-21 Satoshi Nakagawa <psychs@limechat.net>
Reviewed by Darin Adler.
Fixed Japanese text search problems.
Treat small kana letters and kana letters as different characters in search.
Do not ignore diacritic marks in search for Japanese texts.
Test: fast/text/international/japanese-kana-letters.html
- editing/TextIterator.cpp: (WebCore::createCollator): (WebCore::collator): (WebCore::createSearcher):
Oct 20, 2009:
- 9:56 PM Changeset in webkit [49898] by
-
- 3 edits in trunk/WebCore
2009-10-20 Eric Z. Ayers <zundel@google.com>
Reviewed by Timothy Hatcher.
Changes TimelineItems to be created with raw timestamps as opposed
to a time relative to a start of session. Normalized timestamps cause
problems when monitoring a browsing session across multiple page
transitions.
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
- inspector/InspectorTimelineAgent.h:
- 8:37 PM Changeset in webkit [49897] by
-
- 7 edits in trunk/LayoutTests
2009-10-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: simple console tests do not require testing harness.
- inspector/uncaught-dom1-exception-expected.txt:
- inspector/uncaught-dom1-exception.html:
- inspector/uncaught-dom3-exception-expected.txt:
- inspector/uncaught-dom3-exception.html:
- inspector/uncaught-dom8-exception-expected.txt:
- inspector/uncaught-dom8-exception.html:
- 7:31 PM Changeset in webkit [49896] by
-
- 2 edits in trunk/WebCore
Fix leak of WebSocketChannel by adopting the newly-created reference.
Reviewed by Oliver Hunt.
- websockets/WebSocketChannel.h:
(WebCore::WebSocketChannel::create):
- 5:42 PM Changeset in webkit [49895] by
-
- 3 edits2 deletes in trunk
Roll out r49876 as it causes many assertion failures during regression tests on SnowLeopard.
- 5:40 PM Changeset in webkit [49894] by
-
- 6 edits in trunk/WebCore
DOM Storage runtime flag changes
https://bugs.webkit.org/show_bug.cgi?id=30602
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-20
Reviewed by Adam Barth.
Part 1/2. Removing sessionStorageEnabled in next patch after the
Chromium side of the changes lands.
Revert my changes to Settings and instead implement DOM Storage enabling via
the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
This stuff was (intentionally) never exposed to web pages or DRT, so there's no
LayoutTest visible changes and thus no tests.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
- page/DOMWindow.idl:
- storage/Storage.cpp:
(WebCore::Storage::setLocalStorageAvailable):
(WebCore::Storage::localStorageAvailable):
(WebCore::Storage::setSessionStorageAvailable):
(WebCore::Storage::sessionStorageAvailable):
- storage/Storage.h:
- 5:22 PM Changeset in webkit [49893] by
-
- 8 edits in trunk/WebCore
Need to turn off notifications properly at runtime
https://bugs.webkit.org/show_bug.cgi?id=30409
Patch by John Gregg <johnnyg@google.com> on 2009-10-20
Reviewed by David Levin.
This code only affects chromium, and is all behind a compile time
flag current turned off, so no new tests.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
- notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::setIsAvailable):
(WebCore::NotificationCenter::isAvailable):
- notifications/NotificationCenter.h:
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
- 5:08 PM Changeset in webkit [49892] by
-
- 3 edits in trunk/WebCore
2009-10-20 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fixes RefPtr initialization in the V8 implementation of WebCore::ScriptString to use the ::create() idiom and
use adoptRef() properly. I failed to read the RefPtr docs the first time through :(
No new tests, error was caught by valgrind on the Chromium builders.
- bindings/v8/ScriptString.h: (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator=):
- bindings/v8/ScriptStringImpl.h: (WebCore::ScriptStringImpl::create):
- 4:10 PM Changeset in webkit [49891] by
-
- 4 edits in trunk/WebCore
2009-10-20 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: populate child nodes before sorting them.
- inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode. (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses. (WebInspector.ProfileDataGridNode.prototype.get _parent): (WebInspector.ProfileDataGridNode.prototype._populate):
- inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
- 2:56 PM Changeset in webkit [49890] by
-
- 2 edits in trunk/WebCore
Remove redundant String ref/deref calls in generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30579
Patch by Jens Alfke <snej@chromium.org> on 2009-10-20
Reviewed by Eric Seidel.
- bindings/v8/V8Binding.h:
(WebCore::toString): Fix return type of 'toString' to make it truly a no-op
instead of constructing/destructing a String.
- 2:56 PM Changeset in webkit [49889] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: updated variable name.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-20
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
- 2:55 PM Changeset in webkit [49888] by
-
- 2 edits in trunk/JavaScriptCore
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_next_pname): Slightly tweaked this #ifdef to match the
size of a JSValue because m_jsStrings is an array of JSValues.
Reviewed by Mark Rowe.
- 2:49 PM Changeset in webkit [49887] by
-
- 2 edits in trunk/JavaScriptCore
Fixed a 64-bit regression caused by the fix for
https://bugs.webkit.org/show_bug.cgi?id=30570.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-20
Reviewed by Mark Rowe.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_next_pname): Use TimesEight stepping on 64-bit, since
64-bit pointers are eight bytes long.
- 2:39 PM Changeset in webkit [49886] by
-
- 4 edits in trunk/JavaScriptCore
Refactored DateInstance::msToGregorianDateTime so that a DateInstance's
caller doesn't need to supply the DateInstance's own internal value to
the DateInstance.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-20
Reviewed by Sam Weinig.
- runtime/DateInstance.cpp:
(JSC::DateInstance::getGregorianDateTime): Renamed from "msToGregorianDateTime".
- runtime/DateInstance.h:
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Also renamed "utc" to "outputIsUTC", for clarity.
- 2:20 PM Changeset in webkit [49885] by
-
- 2 edits in trunk/WebCore
2009-10-20 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25411
[GTK] ATK accessible ancestry broken
Work around for the problem of bogus additional objects in the ancestry.
We now set the parent when we ref the child, then ask the Atk child if
it knows its parent. This solves the bulk of the cases. For those it
doesn't, fall back to the existing logic.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent): (webkit_accessible_ref_child):
- 1:56 PM Changeset in webkit [49884] by
-
- 2 edits in trunk/WebKit/mac
Rubber-stamped by Mark Rowe.
<rdar://problem/7319749> REGRESSION(r49806): Contextual Menu items missing
https://bugs.webkit.org/show_bug.cgi?id=30568
Revert accidental change from r49806.
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
- 1:50 PM Changeset in webkit [49883] by
-
- 2 edits in trunk/WebCore
Fixes <http://webkit.org/b/30421>.
Web Inpsector: Local Files can show up on Cookies List with Cookies from other Domain.
Reviewed by Alice Liu.
When a page like Google generates an about:blank, it shows up as a local file on
the list of Cookie domains, but has all of the cookies of Google. When we are adding
cookie domains to the inspector, we should only add the domain is the URL of the resource
is in the HTTP protocol family or a file URL.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::didFinishLoading):
- 1:38 PM Changeset in webkit [49882] by
-
- 2 edits3 adds in trunk/WebCore
2009-10-20 Mark Mentovai <mark@chromium.org>
Reviewed by Darin Fisher.
Use a version of libWebKitSystemInterface with global symbols marked
private_extern for Chromium Mac.
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/mac: Added.
- WebCore.gyp/mac/Empty.cpp: Added.
- WebCore.gyp/mac/adjust_visibility.sh: Added.
- 1:12 PM Changeset in webkit [49881] by
-
- 2 edits in trunk/WebCore
2009-10-20 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for WebCore's CSSProperty
https://bugs.webkit.org/show_bug.cgi?id=30564
Inherits CSSProperty class from FastAllocBase because it has been
instantiated by 'new' in WebCore/css/CSSParser.cpp:367.
- css/CSSProperty.h:
- 1:03 PM Changeset in webkit [49880] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Another batch of skipped tests with links to their bugs.
- platform/gtk/Skipped:
- 12:52 PM Changeset in webkit [49879] by
-
- 2 edits in trunk/WebKit/qt
Reviewed By Adam Barth.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Add some actions to the menu for cursor debugging.
GraphicsView based launcher only.
- QGVLauncher/main.cpp:
(MainView::setWaitCursor):
(MainView::resetCursor):
(MainView::flip):
(MainWindow::setWaitCursor):
(MainWindow::resetCursor):
(MainWindow::buildUI):
- 12:08 PM Changeset in webkit [49878] by
-
- 2 edits in trunk/WebCore
2009-10-20 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Hide Chromium's media slider thumb if no source has been loaded.
Covered by existing layout tests, notably:
LayoutTests/media/controls-rendering.html
LayoutTests/media/unsupported-tracks.html
LayoutTests/media/video-src-none.html
- rendering/RenderMediaControlsChromium.cpp: (WebCore::hasSource): Returns true if an HTMLMediaElement has a valid source set. (WebCore::paintMediaMuteButton): Refactored to use hasSource(). (WebCore::paintMediaPlayButton): Ditto. (WebCore::paintMediaSliderThumb): Add call to hasSource() to determine if we should paint the thumb.
- 12:02 PM Changeset in webkit [49877] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Another batch of skipped tests with links to their bugs.
- platform/gtk/Skipped:
- 12:00 PM Changeset in webkit [49876] by
-
- 3 edits2 adds in trunk
2009-10-20 Satoshi Nakagawa <psychs@limechat.net>
Reviewed by Darin Adler.
Fixed Japanese text search problems.
Treat small kana letters and kana letters as different characters in search.
Do not ignore diacritic marks in search for Japanese texts.
- fast/text/international/japanese-kana-letters-expected.txt: Added.
- fast/text/international/japanese-kana-letters.html: Added.
2009-10-20 Satoshi Nakagawa <psychs@limechat.net>
Reviewed by Darin Adler.
Fixed Japanese text search problems.
Treat small kana letters and kana letters as different characters in search.
Do not ignore diacritic marks in search for Japanese texts.
Test: fast/text/international/japanese-kana-letters.html
- editing/TextIterator.cpp: (WebCore::createCollator): (WebCore::collator): (WebCore::createSearcher):
- 11:46 AM Changeset in webkit [49875] by
-
- 1 edit2 adds4 deletes in trunk/LayoutTests
2009-10-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
fast/css/getComputedStyle/marginComputedStyle is missing
https://bugs.webkit.org/show_bug.cgi?id=30566
- fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.
- fast/css/getComputedStyle/marginComputedStyle.html: Added.
- platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.checksum: Removed.
- platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.png: Removed.
- platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Removed.
- platform/qt/fast/css/marginComputedStyle-expected.txt: Removed.
- 11:41 AM Changeset in webkit [49874] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-20 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Geoffrey Garen.
The op_next_pname should use 4 bytes addressing mode in case of JSValue32
https://bugs.webkit.org/show_bug.cgi?id=30570
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_next_pname):
- 11:20 AM Changeset in webkit [49873] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Another batch of skipped tests with links to their bugs.
- platform/gtk/Skipped:
- 11:17 AM Changeset in webkit [49872] by
-
- 2 edits in trunk/WebCore
2009-10-20 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Added getter for FrameLoader:m_suppressOpenerInNewFrame.
This will allow Chromium to more intelligently detect
noreferrer links and therefore open them in a new process.
- loader/FrameLoader.h: (WebCore::FrameLoader::suppressOpenerInNewFrame): Added.
- 10:46 AM Changeset in webkit [49871] by
-
- 2 edits in trunk/WebKitTools
2009-10-20 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Add {ager,antonm,yurys}@chromium.org into committers.py
https://bugs.webkit.org/show_bug.cgi?id=30560
- Scripts/modules/committers.py:
- 10:45 AM Changeset in webkit [49870] by
-
- 4 edits in trunk/WebKit/qt
Remove clipRenderToViewport as agreed upon in
https://bugs.webkit.org/show_bug.cgi?id=29843
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Rubberstamped by Adam Barth.
- Api/qwebframe.cpp:
- Api/qwebframe.h:
- Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
- 10:37 AM Changeset in webkit [49869] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip 3 failing xmlhttprequest tests.
- platform/gtk/Skipped:
- 10:22 AM Changeset in webkit [49868] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip two failing security canvas tests.
- platform/gtk/Skipped:
- 10:10 AM Changeset in webkit [49867] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip failing editing test.
- platform/gtk/Skipped:
- 10:03 AM Changeset in webkit [49866] by
-
- 2 edits in trunk/WebKit/qt
Update the tests to test the new render functionality, and take
into consideration that render() clips to the frame itself as well
as the viewport.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Adam Barth.
QWebFrame::render() now always clips, so the old tests were bogus.
Rendering pure contents (no scrollbars etc) without clipping can now
be accomplished using QWebFrame::documentElement()->render(...)
- Api/qwebframe.cpp:
- Api/qwebframe.h:
- Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
- tests/qwebframe/tst_qwebframe.cpp:
- 10:03 AM Changeset in webkit [49865] by
-
- 2 edits in trunk/WebKit/qt
As we do not support rendering a QWebFrame without it being clipped
the the frame as well as the viewport, we now set the viewport size
to the size of the contents.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Adam Barth.
Rendering pure contents (no scrollbars etc) without clipping can be
acomplished using QWebFrame::documentElement()->render(...)
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::render):
- 9:43 AM Changeset in webkit [49864] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip a bunch of failing DnD tests.
- platform/gtk/Skipped:
- 9:40 AM Changeset in webkit [49863] by
-
- 2 edits in trunk/WebCore
2009-10-20 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore's CSSParserFunction
https://bugs.webkit.org/show_bug.cgi?id=30563
Inherits CSSParserFunction struct from FastAllocBase because it has been
instantiated by 'new' in WebCore/css/CSSParser.cpp:4827.
- css/CSSProperty.h:
- 9:29 AM Changeset in webkit [49862] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip two zoom related tests.
- platform/gtk/Skipped:
- 8:55 AM Changeset in webkit [49861] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip a couple of failing media tests.
- platform/gtk/Skipped:
- 8:47 AM Changeset in webkit [49860] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip failing a11y test while we investigate what's going on.
- platform/gtk/Skipped:
- 8:41 AM Changeset in webkit [49859] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip tests expecting new results.
- platform/gtk/Skipped:
- 8:30 AM Changeset in webkit [49858] by
-
- 2 edits in trunk/WebCore
2009-10-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Watched Expressions Buttons Do Not Match Inspector Styles
https://bugs.webkit.org/show_bug.cgi?id=30554
- inspector/front-end/inspector.css: added style to pane buttons
- 8:29 AM Changeset in webkit [49857] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip media/restore-from-page-cache.html since we are missing some
of the needed API for the test.
- platform/gtk/Skipped:
- 8:06 AM Changeset in webkit [49856] by
-
- 3 edits in trunk/WebCore
=fix for 30559
- 8:00 AM Changeset in webkit [49855] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip another failing test because we don't currently support
changing the locale after gtk_init has been called.
Also, add another test to the list of libxml2 issues.
- platform/gtk/Skipped:
- 7:25 AM Changeset in webkit [49854] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Tor Arne Vestbø.
[Qt] Remove http/tests/xmlhttprequest tests
from skiplist, and add only now failing tests.
- platform/qt/Skipped:
- 7:18 AM Changeset in webkit [49853] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip a bunch of tests failing in the debug bots because WebKit
does not work correctly with very recent versions of libxml2. The
tracker bug for the issue is
https://bugs.webkit.org/show_bug.cgi?id=30508
- platform/gtk/Skipped:
- 7:15 AM Changeset in webkit [49852] by
-
- 2 edits in trunk/WebKitTools
Make the Netscape Test plugin available to the Qt launcher.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Tor Arne Vestbø
- Scripts/run-launcher:
- 7:14 AM Changeset in webkit [49851] by
-
- 2 edits in trunk/WebKit/qt
Add menu item to dump the plugin list to the console,
which can be handy for debugging.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Tor Arne Vestbø.
- QtLauncher/main.cpp:
(MainWindow::dumpPlugins):
(MainWindow::setupUI):
- 7:14 AM Changeset in webkit [49850] by
-
- 4 edits in trunk/WebKit/qt
Introduce new render method on QWebFrame, which supports specifying
which layers to render (scrollbars, contents, pan-icon).
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by Tor Arne Vestbø.
Deprecate render().
- Api/qwebframe.cpp:
(QWebFramePrivate::renderPrivate):
(QWebFrame::render):
- Api/qwebframe.h:
- Api/qwebframe_p.h:
- 5:16 AM Changeset in webkit [49849] by
-
- 2 edits in trunk/LayoutTests
[Qt] Enable previously disabled fast/css tests after r48873 landed which
fixed https://bugs.webkit.org/show_bug.cgi?id=28288
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-20
Reviewed by Ariya Hidayat.
- platform/qt/Skipped:
- 4:18 AM Changeset in webkit [49848] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip failing test, with comment pointing to the bug to track it.
- platform/gtk/Skipped:
- 3:44 AM Changeset in webkit [49847] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip plugins/private-browsing-mode.html, since our plugin
implementation lacks that feature.
- platform/gtk/Skipped:
- 2:54 AM Changeset in webkit [49846] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Infinite loop (leading to crash) when setting cursor in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30549
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-19
Reviewed by Ariya Hidayat.
Patch reimplements QGraphicsItem's itemChange method, and make
CursorChange event to be emitted after cursor has already been
set.
QWidget::setCursor send the event just after it sets the cursor,
then patch makes both behaviors compatible.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::itemChange):
- Api/qgraphicswebview.h:
- 2:42 AM Changeset in webkit [49845] by
-
- 3 edits in trunk/JavaScriptCore
Move OverridesMarkChildren flag from DatePrototype to its parent class
https://bugs.webkit.org/show_bug.cgi?id=30372
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-10-20
Reviewed by Oliver Hunt.
- runtime/DateInstance.h:
(JSC::DateInstance::createStructure):
- runtime/DatePrototype.h:
- 1:52 AM Changeset in webkit [49844] by
-
- 2 edits in trunk/WebCore
Unreviewed buildfix.
[Qt] Add FEGaussianBlur.h and FEGaussianBlur.cpp which were refactored in r49778 to WebCore.pro.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-20
- WebCore.pro:
- 12:36 AM Changeset in webkit [49843] by
-
- 27 edits in trunk
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Set EnabledAtRuntime for WebSocket in DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=29896
Supported by chromium/v8 only.
Add WebSocket::isAvailable()/setIsAvailable(bool) to control v8
bindings.
Remove Settings::experimentalWebSocketsEnabled() and
setExperimentalWebSocketsEnabled(bool).
- WebCore.base.exp:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webSocket):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
- page/DOMWindow.idl:
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
- websockets/WebSocket.cpp: (WebCore::WebSocket::setIsAvailable): (WebCore::WebSocket::isAvailable):
- websockets/WebSocket.h:
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896
WebSocket runtime configuration is supported by chromium/v8 only.
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896
WebSocket runtime configuration is supported by chromium/v8 only.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896
WebSocket runtime configuration is supported by chromium/v8 only.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::experimentalNotificationsEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896
WebSocket runtime configuration is supported by chromium/v8 only.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 12:23 AM Changeset in webkit [49842] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Tor Arne Vestbø.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-20
[Qt] Skip failing tests introduced by disabling Phonon support in Buildbot's Qt version
until a proper solution for the Phonon related craches and timeouts is found.
- platform/qt/Skipped:
Oct 19, 2009:
- 11:56 PM Changeset in webkit [49841] by
-
- 2 edits in trunk/WebCore
REGRESSION: Dromaeo DOM test is 14% slower
https://bugs.webkit.org/show_bug.cgi?id=30273
Reviewed by Sam Weinig.
Whoops, make prototype bindings actually use the StructureFlags.
- 10:01 PM Changeset in webkit [49840] by
-
- 4 edits2 copies in trunk/WebCore
2009-10-19 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Better implementation of WebCore::ScriptString for the V8 bindings.
WebCore::ScriptString is used for XMLHttpRequest's responseText attribute which is
shared with JavaScript. Thus, simply using a WebCore::String and copying the value
is pretty inefficient, especially since responseText is built up with a sequence of
operator+= calls. JSC builds use a JSC::UString to share the buffer when possible,
this patch adopts a similar approach for V8.
No new tests, behavior is unchanged and covered by LayoutTests/http/tests/xmlhttprequest
- WebCore.gypi:
- bindings/v8/ScriptString.h: (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator String): (WebCore::ScriptString::isNull): (WebCore::ScriptString::size): (WebCore::ScriptString::operator=): (WebCore::ScriptString::operator+=): (WebCore::ScriptString::v8StringOrNull):
- bindings/v8/ScriptStringImpl.cpp: Added. (WebCore::ScriptStringImpl::ScriptStringImpl): (WebCore::ScriptStringImpl::~ScriptStringImpl): (WebCore::ScriptStringImpl::toString): (WebCore::ScriptStringImpl::isNull): (WebCore::ScriptStringImpl::size): (WebCore::ScriptStringImpl::append):
- bindings/v8/ScriptStringImpl.h: Added. (WebCore::ScriptStringImpl::ScriptStringImpl): (WebCore::ScriptStringImpl::v8StringHandle):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER):
- 9:46 PM Changeset in webkit [49839] by
-
- 3 edits1 delete in trunk/WebCore
2009-10-19 Adam Barth <abarth@webkit.org>
No review, rolling out r49837.
http://trac.webkit.org/changeset/49837
- page/Settings.cpp: (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::setFantasyFontFamily):
- page/Settings.h: (WebCore::Settings::standardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::fantasyFontFamily):
- platform/text/UScriptCode.h: Removed.
- 9:39 PM Changeset in webkit [49838] by
-
- 2 edits in trunk/WebCore
2009-10-19 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of vasprintf.
https://bugs.webkit.org/show_bug.cgi?id=30473
vasprintf is missing in MSVC. Use COMPILER(MSVC) guards instead of
PLALTFORM(WIN_OS) guards.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
- 9:37 PM Changeset in webkit [49837] by
-
- 3 edits1 add in trunk/WebCore
2009-10-19 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel.
Make generic font family getters/setters accept an additional
argument (script code). It has a default value so that if an embedder
does not have/want a per-script font family setting, call-sites
don't have to be changed.
This is to prepare for fixing bug 10874 (font selection is not
language-dependent) and bug 18085.
There should be no change in layout and no new layout test
is added.
- WebCore.base.exp:
- page/Settings.cpp:
- page/Settings.h:
- platform/text/UScriptCode.h: Added. This is for ports that do not use ICU. the part of ICU's common/unicode/uscript.h that defines script code enum was copied. To keep enums compatible with those in ICU, we don't generate the list out of Scripts.txt of the Unicode Data base or CLDR's data.
- 9:28 PM Changeset in webkit [49836] by
-
- 2 edits in trunk/WebCore
2009-10-19 Evan Stade <estade@chromium.org>
Reviewed by Darin Adler.
Clarify usage of SuddenTermination API. No code change.
- platform/SuddenTermination.h:
- 9:05 PM Changeset in webkit [49835] by
-
- 10 edits in trunk/WebCore
REGRESSION: Dromaeo DOM test is 14% slower
https://bugs.webkit.org/show_bug.cgi?id=30273
Reviewed by Gavin Barraclough.
Make DOM bindings automatically inherit correct structure
flags rather than being needlessly conservative. This is
done by making the bindings generator use the same model
for TypeInfo flags that we now use in JSC.
This gains us about 1% of this regression back.
- 9:01 PM Changeset in webkit [49834] by
-
- 2 edits in trunk/WebKit
2009-10-19 John Gregg <johnnyg@google.com>
Reviewed by Dimitri Glazkov.
set ENABLE_NOTIFICATIONS=1 for Chromium
https://bugs.webkit.org/show_bug.cgi?id=29949
- chromium/features.gypi:
- 8:19 PM Changeset in webkit [49833] by
-
- 3 edits2 adds in trunk
2009-10-19 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
Add a layout test for nested SVG <use> element which has a child.
https://bugs.webkit.org/show_bug.cgi?id=26117
- svg/custom/use-on-use-with-child-expected.txt: Added.
- svg/custom/use-on-use-with-child.svg: Added.
2009-10-19 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
Fixed a bug on nested SVG <use> elements.
https://bugs.webkit.org/show_bug.cgi?id=26117
When a <use> element refer to another <use> element which has
child/children, the instance tree built for this <use> element
is incorrect (more nodes than expected).
Test: svg/dom/use-on-use-with-child.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
- 7:59 PM Changeset in webkit [49832] by
-
- 2 edits in trunk/WebCore
Small changes to fully invalidate and update the JavaScriptCallFrame.
Patch by Oliver Hunt <oliver@apple.com> on 2009-10-19
<rdar://problem/7020755> JSDebugger crashes after reloading from a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=27146
Reviewed by Timothy Hatcher.
- inspector/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::invalidate):
(WebCore::JavaScriptCallFrame::update):
- 7:51 PM Changeset in webkit [49831] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Fix fallout from last change.
https://bugs.webkit.org/show_bug.cgi?id=30550
Update init-events to match reality. I only ran the domstorage layout tests
and thus missed one in fast/events/. This addresses fallout from
https://bugs.webkit.org/show_bug.cgi?id=30536
- fast/events/init-events-expected.txt:
- fast/events/script-tests/init-events.js:
- 6:32 PM Changeset in webkit [49830] by
-
- 17 edits in trunk
2009-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dmitri Titov.
Remove "source" from storage events
https://bugs.webkit.org/show_bug.cgi?id=30536
Remove "source" from storage events per
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
This was removed because it makes it introduces synchronous access that can
cross the event loop boundry (since a storage event can fire from one process
and be handled in another).
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
- storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
- storage/StorageEvent.h: (WebCore::StorageEvent::uri):
- storage/StorageEvent.idl:
- storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):
2009-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dmitri Titov.
Remove "source" from storage events
https://bugs.webkit.org/show_bug.cgi?id=30536
Remove "source" from storage events per
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
- storage/domstorage/localstorage/iframe-events-expected.txt:
- storage/domstorage/localstorage/iframe-events.html:
- storage/domstorage/localstorage/resources/iframe-events-second.html:
- storage/domstorage/localstorage/simple-events-expected.txt:
- storage/domstorage/localstorage/simple-events.html:
- storage/domstorage/sessionstorage/iframe-events-expected.txt:
- storage/domstorage/sessionstorage/iframe-events.html:
- storage/domstorage/sessionstorage/resources/iframe-events-second.html:
- storage/domstorage/sessionstorage/simple-events-expected.txt:
- storage/domstorage/sessionstorage/simple-events.html:
- 6:29 PM Changeset in webkit [49829] by
-
- 5 edits in trunk/WebCore
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove ResourceLoadNotifier::activeDocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=30533
Removing this method from ResourceLoadNotifier better decouples the
notifier from FrameLoader.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::requestFromDelegate):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveResponse):
- loader/ResourceLoadNotifier.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest):
- 6:28 PM Changeset in webkit [49828] by
-
- 5 edits in trunk/WebCore
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move sendRemainingDelegateMessages to ResourceLoadNotifier
https://bugs.webkit.org/show_bug.cgi?id=30531
This method is about notifying folks and doesn't interact with the rest
of FrameLoader.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
- loader/FrameLoader.h:
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
- loader/ResourceLoadNotifier.h:
- 6:19 PM Changeset in webkit [49827] by
-
- 7 edits2 adds in trunk
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Bypass popup blocker using click event
https://bugs.webkit.org/show_bug.cgi?id=21501
Test that a fake event can't get around the popup blocker.
- http/tests/security/popup-blocked-from-fake-event-expected.txt: Added.
- http/tests/security/popup-blocked-from-fake-event.html: Added.
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Bypass popup blocker using click event
https://bugs.webkit.org/show_bug.cgi?id=21501
Keep track of which events were generated by JavaScript and use that
inforation when figuring out if we're processing a user gesture.
Test: http/tests/security/popup-blocked-from-fake-event.html
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGestureEvent):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
- dom/Document.cpp: (WebCore::Document::createEvent):
- dom/Event.cpp: (WebCore::Event::Event):
- dom/Event.h: (WebCore::Event::createdByDOM): (WebCore::Event::setCreatedByDOM):
- 6:09 PM Changeset in webkit [49826] by
-
- 2 edits in trunk/WebCore
Fixing a typo.
Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-19
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30543
- platform/sql/SQLiteDatabase.h:
- 6:05 PM Changeset in webkit [49825] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
Adding myself to committers.py.
- 5:41 PM Changeset in webkit [49824] by
-
- 1 edit1 add in trunk/WebCore
Manual Test for crash caused by JS accessing DOMWindow which is disconnected from the Frame.
https://bugs.webkit.org/show_bug.cgi?id=30544
Reviewed by Darin Adler.
- manual-tests/crash-on-accessing-domwindow-without-frame.html: Added.
- 5:38 PM Changeset in webkit [49823] by
-
- 3 edits in trunk/WebCore
2009-10-19 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Flash at end of opacity/transform transition sometimes
https://bugs.webkit.org/show_bug.cgi?id=30501
When a transition finishes, there window of time between when the animation is
removed, and the final style set on the GraphicsLayer. This caused the layer to revert
to its old appearance for one or two frames. To avoid this, we set the final
transform or opacity at the start of the transition; we know that the animation
will override the final value for as long as its running.
No test because this is a very transient effect that can't be captured
in a test.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::updateLayerOpacity): (WebCore::RenderLayerBacking::updateLayerTransform): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::startTransition):
- rendering/RenderLayerBacking.h:
- 5:12 PM Changeset in webkit [49822] by
-
- 1 edit in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css
Added one more style rule
- 5:03 PM Changeset in webkit [49821] by
-
- 1 add in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css
Moved WebGL blog CSS to a separate file
- 3:59 PM Changeset in webkit [49820] by
-
- 3 edits in trunk/JavaScriptCore
Tightened up some put_by_id_transition code generation.
https://bugs.webkit.org/show_bug.cgi?id=30539
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-19
Reviewed by Oliver Hunt.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition): No need to do object type
checks or read Structures and prototypes from objects: they're all known
constants at compile time.
- 3:44 PM Changeset in webkit [49819] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Jason Yan <tailofthesun@gmail.com>
Reviewed by Eric Seidel.
Fixed issue with LayoutTests/fast/cookies/local-file-can-set-cookies.html
which can fail when the system under test has local file cookies set already.
https://bugs.webkit.org/show_bug.cgi?id=30281
- fast/cookies/local-file-can-set-cookies-expected.txt: Modified. Updated expected results.
- fast/cookies/local-file-can-set-cookies.html: Modified. Check for existing cookie and set non-persistent cookie.
- 3:36 PM Changeset in webkit [49818] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Language tag should include both language and country sub-tags,
case insensitive.
https://bugs.webkit.org/show_bug.cgi?id=30440
- fast/js/navigator-language-expected.txt:
- fast/js/navigator-language.html:
- 3:28 PM Changeset in webkit [49817] by
-
- 2 edits in trunk/WebKitLibraries
2009-10-19 Marshall Culpepper <mculpepper@appcelerator.com>
Reviewed by Eric Seidel.
added cairo include and lib directories to debug_wincairo.vsprops
https://bugs.webkit.org/show_bug.cgi?id=29831
- win/tools/vsprops/debug_wincairo.vsprops:
- 3:10 PM Changeset in webkit [49816] by
-
- 2 edits in trunk/WebKitSite
2009-10-19 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Replace boolean operator indentation example with an if statement.
- coding/coding-style.html: Replace boolean indenting example to use "if"
- 3:00 PM Changeset in webkit [49815] by
-
- 2 edits in trunk/WebCore
2009-10-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add more stop characters into console completions.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
- 3:00 PM Changeset in webkit [49814] by
-
- 2 edits in trunk/WebKit/win
Fix crashes/assertions when calling WebLocalizedString from multiple threads concurrently
Fixes <http://webkit.org/b/30534> WebLocalizedString asserts if called
from multiple threads concurrently
Reviewed by John Sullivan.
- WebLocalizableStrings.cpp:
(mainBundleLocStringsMutex):
(frameworkLocStringsMutex):
Added these new getters.
(findCachedString):
(cacheString):
Lock the relevant mutex before accessing each string map. Otherwise
bad things could happen if two threads end up here at the same time.
- 3:00 PM Changeset in webkit [49813] by
-
- 2 edits in trunk/WebKit/win
Get rid of a few static initializers/exit-time destructors in WebLocalizableStrings
Reviewed by Dan Bernstein.
- WebLocalizableStrings.cpp:
(mainBundleLocStrings):
(frameworkLocStrings):
Added these functions instead of file-scope variables.
(findCachedString):
(cacheString):
Updated to use the new functions.
- 2:41 PM Changeset in webkit [49812] by
-
- 4 edits in trunk/WebKit
2009-10-19 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Update call to FrameLoader::loadFrameRequest() in qt and
FrameLoader::urlSelected() in win.
- 2:39 PM Changeset in webkit [49811] by
-
- 2 edits in trunk/LayoutTests
2009-10-19 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Added the test case for bug #30266 to the Windows skip list because
event.dataTransfer.types does not behave correctly. See bug #30527.
- platform/win/Skipped: Added test case to Windows skipped list.
- 2:31 PM Changeset in webkit [49810] by
-
- 2 edits in trunk/WebCore
2009-10-19 Marshall Culpepper <mculpepper@appcelerator.com>
Reviewed by Adam Roben.
implemented ClipboardWin::files()
https://bugs.webkit.org/show_bug.cgi?id=29666
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files):
- 2:15 PM Changeset in webkit [49809] by
-
- 13 edits11 adds in trunk
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Alexey Proskuryakov.
Add support for link relations in HTMLAnchorElement and implement rel="noreferrer".
- 2:08 PM Changeset in webkit [49808] by
-
- 2 edits in trunk/WebKit/mac
Documentation fix for -[NSObject(WebResourceLoadDelegate) webView:resource:willSendRequest:redirectResponse:fromDataSource:]
Reviewed by Dan Bernstein.
- WebView/WebResourceLoadDelegate.h: Prepended "webView:" to the
@method declaration of
-webView:resource:willSendRequest:redirectResponse:fromDataSource:
which was absent before r3953 and was missed during the great
documentation clean up of r4269.
- 2:01 PM Changeset in webkit [49807] by
-
- 2 edits in trunk/WebKit/mac
Fix build.
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
- 1:30 PM Changeset in webkit [49806] by
-
- 8 edits in trunk/WebKit/mac
Split assertions of conjunctions into separate statements or remove
redundant assertions.
Reviewed by Anders Carlsson.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::deadNameNotificationCallback):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
(-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView halt]):
(-[WebBaseNetscapePluginView resumeFromHalt]):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::checkGrammarOfString):
(WebEditorClient::checkTextOfParagraph):
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _reflectSelection]):
- 1:25 PM Changeset in webkit [49805] by
-
- 2 edits in trunk/LayoutTests
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Geoffrey Garen.
Add plugins/netscape-invoke-failures.html to Snow Leopard skipped list.
- platform/mac-snowleopard/Skipped: Add plugins/netscape-invoke-failures.html.
- 1:25 PM Changeset in webkit [49804] by
-
- 3 edits in trunk/WebCore
Refactor out some of the code in paint() into paintPanScrollIcon()
and paintScrollbars() in preparation of some Qt API changes.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by David Hyatt.
- platform/ScrollView.cpp:
(WebCore::ScrollView::paint):
- platform/ScrollView.h:
- 1:18 PM Changeset in webkit [49803] by
-
- 4 edits in trunk/WebCore
[v8] typeof(HTMLMediaElement) should return undefined if media
engine is not available
https://bugs.webkit.org/show_bug.cgi?id=30343
Patch by Alpha Lam <hclam@chromium.org> on 2009-10-19
Reviewed by Dimitri Glazkov (Dimitri Glazkov).
Check for availability of the media engine to disable
HTMLMediaElement, HTMLAudioElement, HTMLVideoElement, MediaError
in runtime.
Try runs and review in Chromium:
http://codereview.chromium.org/276011
Test: manual-tests/chromium/media-player-not-available.html
The above test can work work in Chromium. Testing procedures:
- Remove all media support libraries in Chromium (e.g. ffmpeg libraries)
- Open Chromium with above test page
- Verify the test results according to the test page
- bindings/v8/custom/V8CustomBinding.h:
Declare enabler methods.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
Report enabled only if media player is available.
- manual-tests/chromium/media-player-not-available.html: Added.
Manual test, following instruction in this test for procedures.
- page/DOMWindow.idl:
Mark HTMLMediaElement, HTMLAudioElement, HTMLVideElement, MediaError
as enabled at runtime.
- 12:59 PM Changeset in webkit [49802] by
-
- 9 edits1 add in trunk/JavaScriptCore
Added a private API for getting a global context from a context, for
clients who want to preserve a context for a later callback.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-19
Reviewed by Sam Weinig.
- API/APICast.h:
(toGlobalRef): Added an ASSERT, since this function is used more often
than before.
- API/JSContextRef.cpp:
- API/JSContextRefPrivate.h: Added. The new API.
- API/tests/testapi.c:
(print_callAsFunction):
(main): Test the new API.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj: Build and export the new API.
- 12:38 PM Changeset in webkit [49801] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-19 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Alexey Proskuryakov.
[Gtk] ApplicationCacheStorage error while compiling WebKit/gtk/webkit/webkitapplicationcache.cpp
https://bugs.webkit.org/show_bug.cgi?id=30358
Guard calls to cacheStorage() with ENABLE(OFFLINE_WEB_APPLICATIONS).
- webkit/webkitapplicationcache.cpp:
- 12:24 PM Changeset in webkit [49800] by
-
- 2 edits in trunk/WebCore
Make the local static panScrollIcon into a Image* instead
of a RefPtr<Image>.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by Adam Roben.
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- 12:19 PM Changeset in webkit [49799] by
-
- 2 edits in trunk/WebCore
Forcefully set antialiasing for Chromium media controls.
Patch by Andrew Scherkus <scherkus@chromium.org> on 2009-10-19
Reviewed by NOBODY (OOPS!).
https://bugs.webkit.org/show_bug.cgi?id=30521
Before it was nondeterministiacally being enabled based on the previous state of GraphicsContext.
Covered by existing layout tests.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaSlider): Added setShouldAntialias(true).
- 12:11 PM Changeset in webkit [49798] by
-
- 11 edits in trunk/WebCore
2009-10-19 Jens Alfke <jens@mooseyard.com>
Reviewed by Darin Adler.
Optimize string upper/lowercasing
https://bugs.webkit.org/show_bug.cgi?id=30261
- Added AtomicString::upper() and lower()
- Further optimized StringImpl::lower()
- Removed StringImpl::isLower()
- Added QualifiedName::localNameUpper(), which is cached, thereby saving thousands of upper() calls and string allocations.
- dom/Element.cpp: (WebCore::Element::setAttribute): Call AtomicString::lower()
- dom/QualifiedName.cpp: (WebCore::QualifiedName::localNameUpper): New method
- dom/QualifiedName.h: Added localNameUpper() method
- dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Call AtomicString::lower()
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::createElement): Call AtomicString::lower()
- html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): Call localNameUpper()
- platform/text/AtomicString.cpp: (WebCore::AtomicString::lower): New method (WebCore::AtomicString::upper): New method
- platform/text/AtomicString.h: Added lower() and upper()
- platform/text/StringImpl.cpp: Removed isLower() (WebCore::StringImpl::lower): Further optimization of initial loop
- platform/text/StringImpl.h: Removed isLower()
- 11:59 AM Changeset in webkit [49797] by
-
- 19 edits1 delete in trunk/LayoutTests
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Update test results and Skipped list after changes in r49791.
Some test results were accidentally committed in r49192. At that time
results were incorrect, but testing still succeeded because of
unimplemented features. After r49791 tests, though generating semantically
equal output to Mac's render trees, started to fail and need to have
generated results updated. This patch does just that.
- platform/gtk/Skipped: Skip a test that does not generate semantically equal render trees.
- platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
- platform/gtk/editing/pasteboard/4076267-2-expected.txt:
- platform/gtk/editing/pasteboard/4076267-3-expected.txt:
- platform/gtk/editing/pasteboard/4076267-expected.txt:
- platform/gtk/editing/pasteboard/paste-table-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-015-expected.txt:
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- platform/gtk/editing/pasteboard/select-element-1-expected.txt: Removed.
- 11:50 AM Changeset in webkit [49796] by
-
- 6 edits2 adds in trunk
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Test that the proper exception is thrown into JS when a plugin
invoke call returns false.
- plugins/netscape-invoke-failure-expected.txt: Added.
- plugins/netscape-invoke-failure.html: Added.
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
If a call to a plugin's invokeMethod, invokeDefault or construct
returns false, throw an exception into JS.
Test: plugins/netscape-invoke-failure.html
- bindings/v8/V8NPObject.cpp: Check return values of invokeMethod, invokeDefault and construct. (npObjectInvokeImpl):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod): Check return value (JSC::Bindings::CInstance::invokeDefaultMethod): Check return value (JSC::Bindings::CInstance::invokeConstruct): Check return value
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Add testFail() to test plugin so we can test our handling of a
plugin invoke call returning false.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail(). (pluginInvoke): (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
- 11:47 AM Changeset in webkit [49795] by
-
- 2 edits in trunk/JavaScriptCore
Tightened up some instanceof code generation.
https://bugs.webkit.org/show_bug.cgi?id=30488
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-17
Reviewed by Oliver Hunt.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof): No need to do object type checks -
cell type checks and ImplementsDefaultHasIntance checks implicitly
supersede object type checks.
- 11:38 AM Changeset in webkit [49794] by
-
- 3 edits4 adds in trunk
WebCore: Fix for chromium/skia canvas arc start/end positions, when the arc is
360 degrees.
https://bugs.webkit.org/show_bug.cgi?id=30449
Reviewed by Adam Barth.
Covered by new test:
LayoutTests/fast/canvas/arc360.html
- platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::addArc):
LayoutTests: New test for 360 degree arc endpoints, and expected results.
http://bugs.webkit.org/show_bug.cgi?id=30449
Reviewed by Adam Barth.
- fast/canvas/arc360.html: Added.
- platform/mac/fast/canvas/arc360-expected.checksum: Added.
- platform/mac/fast/canvas/arc360-expected.png: Added.
- platform/mac/fast/canvas/arc360-expected.txt: Added.
- 11:14 AM Changeset in webkit [49793] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add tests that have never passed on Windows to the Skipped list, and reopen
bugs.
- platform/win/Skipped:
- 10:35 AM Changeset in webkit [49792] by
-
- 2 edits in trunk/WebCore
2009-10-19 Kent Tamura <tkent@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix uninitialized variable reference in Element::removeAttribute().
https://bugs.webkit.org/show_bug.cgi?id=30502
- dom/Element.cpp: (WebCore::Element::removeAttribute):
- 10:25 AM Changeset in webkit [49791] by
-
- 7 edits in trunk
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Enable tests that pass when DOM pasting is allowed.
- platform/gtk/Skipped:
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Add a settings to allow DOM pastes to be performed.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Enable DOM pasting when running layout tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 10:13 AM Changeset in webkit [49790] by
-
- 11 edits in trunk
2009-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=30463
Remove HTML5 media element 'loadend' event
- dom/EventNames.h:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): Remove 'loadend'. (WebCore::HTMLMediaElement::loadInternal): Ditto. (WebCore::HTMLMediaElement::noneSupported): Ditto. (WebCore::HTMLMediaElement::mediaEngineError): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::userCancelledLoad): Ditto.
2009-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=30463
Remove HTML5 media element 'loadend' event
- media/event-attributes-expected.txt:
- media/event-attributes.html: Switch from 'loadend' to 'canplaythrough'.
- media/media-load-event-expected.txt:
- media/media-load-event.html: Ditto.
- media/progress-event-at-least-one-expected.txt:
- media/progress-event-at-least-one.html: Ditto.
- 9:26 AM Changeset in webkit [49789] by
-
- 3 edits in trunk/WebCore
2009-10-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Adam Barth.
[Qt] Remove deletion of outgoing FormData object when reply is finished.
The buffers will be destroyed a bit later, when the QNetworkReply is deleted.
Bug: https://bugs.webkit.org/show_bug.cgi?id=29551
- platform/network/qt/QNetworkReplyHandler.cpp:
- platform/network/qt/QNetworkReplyHandler.h:
- 9:18 AM Changeset in webkit [49788] by
-
- 2 edits in trunk/WebCore
2009-10-19 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Fix hard-to-reproduce crash in HTMLTokenizer by avoiding a rare
fastRealloc edge case.
https://bugs.webkit.org/show_bug.cgi?id=29313
No test, the crash shows up occasionally in crash dumps, we weren't able
to reproduce it locally.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::enlargeScriptBuffer): Added an early exit to
avoid calling fastRealloc with the size of 0.
- 9:08 AM Changeset in webkit [49787] by
-
- 2 edits in trunk/WebCore
2009-10-19 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Use fillRect() instead of drawRect() to fix Chromium media controls rendering.
Chromium Mac layout tests will need to be rebaselined. Existing layout tests for Linux/Win still pass.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): Use fillRect() instead of drawRect().
- 9:00 AM Changeset in webkit [49786] by
-
- 2 edits in trunk/WebCore
2009-10-19 Dmitry Titov <dimich@chromium.org>
Reviewed by Adam Barth.
Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected to a frame.
https://bugs.webkit.org/show_bug.cgi?id=29832
Need to make sure the script caches are reset when frame gets disconnected from still-alive DOMWindow.
This will prevent JS from calling DOMWindow methods that can not be completed w/o the frame.
I am not sure it's possible to test this since the only file that repros the problem need ~10 seconds to cause crash.
- page/Frame.cpp: (WebCore::Frame::~Frame): Right after frame disconnects from DOMWindow, clear WindowShell.
- 8:53 AM Changeset in webkit [49785] by
-
- 5 edits1 add in trunk/WebKit/qt
2009-10-19 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Ariya Hidayat.
Add QWebElement::render API which allows rendering of single
element.
- Api/qwebelement.cpp: (QWebElement::render):
- Api/qwebelement.h:
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::render):
- tests/qwebelement/qwebelement.qrc:
- tests/qwebelement/image.png: Added.
- 8:16 AM Changeset in webkit [49784] by
-
- 2 edits in trunk/WebKit/qt
QWebPage: Doc: setNetworkAccessManager should only be called once.
Patch by Markus Goetz <Markus.Goetz@nokia.com> on 2009-10-19
Reviewed by Ariya Hidayat.
- 8:02 AM Changeset in webkit [49783] by
-
- 2 edits in trunk/WebCore
2009-10-19 Csaba Osztrogonác <Csaba Osztrogonác>
Unreviewed build warning fix.
[Qt] Apply changes to WebCore.pro introduced in r49778
- WebCore.pro: Removed svg/graphics/filters/SVGFEGaussianBlur.h from HEADERS
- 8:01 AM Changeset in webkit [49782] by
-
- 2 edits in trunk/WebKit/qt
Wrong ifdef combination in QGraphicsWebView's event method.
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-19
Reviewed by Tor Arne.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::event):
- 7:42 AM Changeset in webkit [49781] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip failing tests for now and add test-specific information about the cause to the Skipped list.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-19
Reviewed by Tor Arne Vestbø.
- platform/qt/Skipped:
- 7:16 AM Changeset in webkit [49780] by
-
- 2 edits in trunk/WebKit/gtk
Make WebKitHitTestResult actually appear in the index
- 7:00 AM Changeset in webkit [49779] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] Add platform expected file for canvas test.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-19
Reviewed by Tor Arne Vestbø.
- platform/qt/fast/canvas/canvas-empty-image-pattern-expected.txt: Added.
- 5:57 AM Changeset in webkit [49778] by
-
- 7 edits2 moves in trunk/WebCore
2009-10-19 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
Move feGaussianBlur from WebCore/svg to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=30495
This patch moves SVGFRGaussianBlur from svg/graphics/filters
to platform/graphics/filters/FEGaussianBlur. This is needed
for shadow support on Qt and Cairo.
No change in functionality, therfore no new test case needed.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/FEGaussianBlur.cpp: Added.
- platform/graphics/filters/FEGaussianBlur.h: Added.
- svg/SVGFEGaussianBlurElement.h:
- svg/graphics/filters/SVGFEGaussianBlur.cpp: Removed.
- svg/graphics/filters/SVGFEGaussianBlur.h: Removed.
- 5:49 AM Changeset in webkit [49777] by
-
- 1 edit in trunk/WebCore/ChangeLog
Unreviewed.
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-19
Added reviewer name to r49574.
- 5:48 AM Changeset in webkit [49776] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
[Qt] Update outdated metrics for these passing tests.
- platform/qt/css1/font_properties/font-expected.txt:
- platform/qt/fast/xsl/document-function-expected.txt:
- 4:58 AM Changeset in webkit [49775] by
-
- 2 edits in trunk/WebCore
2009-10-19 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30489
[Gtk] The document frame/html container claims to be parentless
Work around for the parentless claim made by the accessible associated
with the embedded WebView. When we identify this condition, get the
widget's parent, and then get the AtkObject from that. Admittedly an ugly
hack, but we'll need it for Yelp and other Gtk+/GNOME applications which
plan to switch over to WebKit.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent):
- 4:51 AM Changeset in webkit [49774] by
-
- 2 edits in trunk/WebCore
2009-10-19 Benjamin Otte <otte@gnome.org>
Reviewed by Jan Alonzo.
Handle duration queries properly
https://bugs.webkit.org/show_bug.cgi?id=29999
Previously duration queries failed to handle unknown duration
and didn't treat the returned duration as an unsigned.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):
- 4:50 AM Changeset in webkit [49773] by
-
- 2 edits in trunk/WebKit/gtk/po
2009-10-19 Daniel Macks <dmacks@netspace.org>
Reviewed by Adam Barth.
Inconsistent handling of gettext domain can cause compile failure
https://bugs.webkit.org/show_bug.cgi?id=30292
- GNUmakefile.am: Use DOMAIN variable instead of hard-coded value
- 4:28 AM Changeset in webkit [49772] by
-
- 2 edits in trunk/WebCore
2009-10-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix build on Windows.
- plugins/win/PluginViewWin.cpp: (windowHandleForPageClient):
- 4:17 AM Changeset in webkit [49771] by
-
- 5 edits2 adds in trunk
Windowed Plugins: Don't crash when client is 0.
Client is 0 when we use QWebPage without a QWebView or QGraphicsWebView.
In addition, setFrameRect()/updatePluginWidget() is called even if the
plugin was not succesfully loaded. updatePluginWidget() updates the
window rect which is, in theory, useful to draw something that indicates
that we didn't load successfully.
So, a status check is added to setNPWindowIfNeeded.
- 3:44 AM Changeset in webkit [49770] by
-
- 7 edits in trunk
2009-10-19 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
[Qt] Windowed Plugins: Fix crash when QWebPage is deleted after QWebView.
Fixes various sources of crashes:
- The PluginContainer is a child of QWebView. When the view gets deleted, the PluginView is not notified about the deletion of PluginContainer.
- QWebView destructor does not set client to 0.
- Sometimes pending paint events are sent after the plugin has died, so add a check in PluginView::setNPWindowIfNeeded.
- plugins/qt/PluginContainerQt.cpp: (PluginContainerQt::~PluginContainerQt):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
2009-10-19 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
[Qt] Windowed Plugins: Fix crash when QWebPage is deleted after QWebView.
Fixes various sources of crashes:
- The PluginContainer is a child of QWebView. When the view gets deleted, the PluginView is not notified about the deletion of PluginContainer.
- QWebView destructor does not set client to 0.
- Sometimes pending paint events are sent after the plugin has died, so add a check in PluginView::setNPWindowIfNeeded.
- Api/qwebview.cpp: (QWebView::~QWebView):
- tests/qwebview/qwebview.pro:
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::reusePage_data): (tst_QWebView::reusePage):
- 12:17 AM Changeset in webkit [49769] by
-
- 7 edits in trunk
2009-10-19 Jakob Truelsen <antialize@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=29042
Allow one to customize the minimal and maximal shrink factors used when printing.
- page/PrintContext.cpp: (WebCore::PrintContext::begin):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setPrintingMinimumShrinkFactor): (WebCore::Settings::setPrintingMaximumShrinkFactor):
- page/Settings.h: (WebCore::Settings::printingMinimumShrinkFactor): (WebCore::Settings::printingMaximumShrinkFactor):
2009-10-19 Jakob Truelsen <antialize@gmail.com>
Reviewed by Adam Barth.
Allow one to costumize the minimal and maximal shrink factors,
Added methods setPrintingMinimumShrinkFactor, printingMinimumShrinkFactor,
setPrintingMaximumShrinkFactor, printingMaximumShrinkFactor to QWebSettings.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings): (QWebSettings::setPrintingMinimumShrinkFactor): (QWebSettings::printingMinimumShrinkFactor): (QWebSettings::setPrintingMaximumShrinkFactor): (QWebSettings::printingMaximumShrinkFactor):
- Api/qwebsettings.h:
- 12:04 AM Changeset in webkit [49768] by
-
- 1 edit in trunk/WebKit/qt/ChangeLog
Fix ChangeLog spelling.
Oct 18, 2009:
- 11:59 PM Changeset in webkit [49767] by
-
- 3 edits10 adds in trunk
2009-10-18 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234
- platform/mac/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
- platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
- platform/mac/editing/selection/script-tests/TEMPLATE.html: Added.
- platform/mac/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
- platform/win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
- platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
- platform/win/editing/selection/script-tests/TEMPLATE.html: Added.
- platform/win/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
2009-10-18 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234
Tests: platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/mac/editing/selection/script-tests/TEMPLATE.html
platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/win/editing/selection/script-tests/TEMPLATE.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):
- 11:51 PM Changeset in webkit [49766] by
-
- 7 edits in trunk
2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Rename fixedContentsSize property to preferredContentsSize as
agreed upon with Siman Hausmann and Matthias Ettrich.
- Api/qwebpage.cpp: (QWebPage::preferredContentsSize): (QWebPage::setPreferredContentsSize):
- Api/qwebpage.h:
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Use the setPreferredContentsSize method instead
of setFixedContentsSize, as the method has been renamed.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setFixedContentsSize):
- 11:50 PM QtBackLog edited by
- (diff)
- 11:46 PM QtBackLog edited by
- Move QtWebKit problems into a table. (diff)
- 11:43 PM Changeset in webkit [49765] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-18 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp.
https://bugs.webkit.org/show_bug.cgi?id=30474
stricmp and strnicmp are deprecated beginning in Visual
C++ 2005. Use _stricmp and _strnicmp instead in StringExtras.h.
- wtf/StringExtras.h: (strncasecmp): (strcasecmp):
- 11:42 PM QtBackLog edited by
- Change Qt items into a table (diff)
- 11:34 PM QtBackLog edited by
- Add completed items to the bottom (diff)
- 8:53 PM Changeset in webkit [49764] by
-
- 2 edits in trunk/WebCore
CURL build fix, use proper header name.
- 7:38 PM Changeset in webkit [49763] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7309062> Crashes in WebCore::DocumentLoader::isStopping below WebKit::NetscapePluginInstanceProxy::loadRequest.
Reviewed by Dan Bernstein.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::loadRequest): Null-check the DocumentLoader before deferencing it.
- 7:09 PM Changeset in webkit [49762] by
-
- 9 edits in trunk
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Properties on Arrays and NodeLists are not logged correctly.
WebCore:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._printArray):
LayoutTests:
- inspector/console-format-expected.txt:
- inspector/console-format.html:
- 6:20 PM Changeset in webkit [49761] by
-
- 2 edits in trunk/WebCore
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: touching WebCore so that it
initiated inspector frontend deployment on Windows.
Web Inspector: frontend files are not deployed in Windows
incremental build.
- inspector/InspectorDOMAgent.cpp:
- 5:20 PM Changeset in webkit [49760] by
-
- 6 edits6 adds in trunk/LayoutTests
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make console tests more granular.
- inspector/console-dir-expected.txt: Added.
- inspector/console-dir.html: Added.
- inspector/console-dirxml-expected.txt: Added.
- inspector/console-dirxml.html: Added.
- inspector/console-format-expected.txt: Added.
- inspector/console-format.html: Added.
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 4:48 PM Changeset in webkit [49759] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:17 PM Changeset in webkit [49758] by
-
- 4 edits in trunk
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Title of dir(["test", "test2"]) should be Array
Test: inspector/console-tests.html
- inspector/front-end/InjectedScript.js:
- 2:15 PM Changeset in webkit [49757] by
-
- 9 edits in trunk
2009-10-18 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
REGRESSION: SVG Mask doesn't work for maskContentUnits="objectBoundingBox"
https://bugs.webkit.org/show_bug.cgi?id=30480
Patch for SVGMaskElement landed in r49598 should correct the location of
the mask image graphics context. It only corrects the location for userSpaceOnUse
mode in maskContentUnits but breaks objectBoundingBoxMode.
The maskDestRect shouldn't be moved. It is not responsible for the correct context
postioin but for the correct position of the mask image.
This patch calculates the context postion independently from the maskDestRect.
It also uses lineareRGB color space for masking on CG now. This is the default
color space for masking operations.
We already have tests for both maskContentUnits modes.
*svg/W3C-SVG-1.1/masking-intro-01-f.svg
*svg/custom/mask-with-default-value.svg
Some tests needed new pixel tests because of the new color space.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
The color space of masking operations in SVG changed to linearSVG.
This needs an update of some masking pixel tests.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac/svg/batik/masking/maskRegions-expected.checksum:
- platform/mac/svg/batik/masking/maskRegions-expected.png:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
- 12:55 PM Changeset in webkit [49756] by
-
- 2 edits in trunk/WebCore
2009-10-18 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Use v8::Integer::NewFromUnsigned when converting unsigneds into V8's numbers.
That is notably faster for small numbers (most common case).
https://bugs.webkit.org/show_bug.cgi?id=30493
- bindings/scripts/CodeGeneratorV8.pm:
- 12:29 PM Changeset in webkit [49755] by
-
- 5 edits5 adds in trunk
2009-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[GTK] Add MathML to the build system
https://bugs.webkit.org/show_bug.cgi?id=30487
Add --enable-mathml to configure.
- configure.ac:
Add MathML sources if MathML support is enabled.
- GNUmakefile.am:
Include layout test baseline for Gtk.
- platform/gtk/mathml/presentation/sub-expected.txt: Added.
- platform/gtk/mathml/presentation/sup-expected.txt: Added.
- platform/gtk/mathml/presentation/tables-expected.txt: Added.
- 11:21 AM Changeset in webkit [49754] by
-
- 2 edits in trunk/WebCore
Non-PCH build fix. Added missing header.
- 10:17 AM Changeset in webkit [49753] by
-
- 7 edits4 adds in trunk
2009-10-18 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Compositing layers not correctly updated after partial layout
https://bugs.webkit.org/show_bug.cgi?id=30425
When a partial layout happened, for example as the result of a postion-change-only
layout, then some compositing layer positions were not correctly updated. To fix
this, updateLayerPositions() now carries along a flag that is set at the rootmost
layer being updated, and used to determine when we hit the first compositing layer
in this update. RenderLayerBacking::updateAfterLayout() makes use of this information
to do a full geometry update on that layer, which is thus the rootmost compositing
layer that is being updated.
Test: compositing/geometry/partial-layout-update.html
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset):
- rendering/RenderLayer.h: (WebCore::RenderLayer::):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
- rendering/RenderLayerBacking.h:
- 10:02 AM Changeset in webkit [49752] by
-
- 6 edits in trunk
Reviewed by Kevin Ollivier.
Add the ability to specify a proxy for wxWebKit.
https://bugs.webkit.org/show_bug.cgi?id=30446
- 9:23 AM Changeset in webkit [49751] by
-
- 2 edits in trunk/WebCore
2009-10-18 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez
https://bugs.webkit.org/show_bug.cgi?id=25901
Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag
Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 9:08 AM Changeset in webkit [49750] by
-
- 4 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Add basic database support to wx API
https://bugs.webkit.org/show_bug.cgi?id=30445
- 9:00 AM Changeset in webkit [49749] by
-
- 2 edits in trunk/LayoutTests
2009-10-18 Eric Carlson <eric.carlson@apple.com>
Skip media/video-empty-source.html until <rdar://problem/6563117> has been fixed.
- platform/mac/Skipped:
- 7:50 AM QtBackLog edited by
- (diff)
- 2:35 AM QtWebKitPlugins edited by
- (diff)
Oct 17, 2009:
- 11:27 PM Changeset in webkit [49748] by
-
- 2 edits in trunk/LayoutTests
2009-10-17 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
Fix inefficient string concatenation.
LayoutTests/fast/css/large-list-of-rules-crash.html contains code that
concatenate strings in an inefficient way. Concatenation of strings should be
done with Array.join method. This patch fixes this issue, and also fixes typos
in the test.
fast/css/large-list-of-rules-crash.html concatenates strings in an inefficient way
https://bugs.webkit.org/show_bug.cgi?id=30436
- fast/css/large-list-of-rules-crash.html:
- 6:46 PM QtBackLog edited by
- (diff)
- 6:41 PM QtBackLog edited by
- (diff)
- 6:22 PM QtBackLog edited by
- (diff)
- 6:15 PM QtBackLog edited by
- (diff)
- 4:07 PM Changeset in webkit [49747] by
-
- 4 edits in trunk
Versioning.
- 4:06 PM Changeset in webkit [49746] by
-
- 1 copy in tags/Safari-532.2
New tag.
- 3:52 PM Changeset in webkit [49745] by
-
- 13 edits2 adds in trunk/WebCore
2009-10-17 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by George Staikos.
Cleanup SVGElement code, preparing for animVal support
https://bugs.webkit.org/show_bug.cgi?id=30466
Add new SynchronizablePropertyController and move the code for SVG property <-> XML attribute synchronization
from SVGElement. This is a further preparation for animVal support, where SynchronizablePropertyController will
be used to control the start/end state of an animated property.
We're currently tracking animated properties that need synchronization, generalize this concept and use
it to track their creation (bound to certain SVG*Element classes) as well as a flag determing the need
of synchronization (no SVG DOM object wrappers, no synchronization needed).
No change in functionality, thus no tests.
- GNUmakefile.am: Add 'SynchronizablePropertyController.cpp/h' to build
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- svg/SVGAllInOne.cpp: Ditto.
- svg/SVGAnimatedProperty.h: Add registerProperty() function (WebCore::::SVGAnimatedProperty): Call registerProperty() function (WebCore::::registerProperty): Add new registerProperty() function, announcing new properties to SynchronizablePropertyController.
- svg/SVGAnimatedTemplate.h: Use propertyController() method, to access the new functions moved from SVGElement. (WebCore::lookupOrCreateWrapper):
- svg/SVGElement.cpp: Adapt to code moving to SynchronizablePropertyController. (WebCore::SVGElement::updateAnimatedSVGAttribute):
- svg/SVGElement.h: Move handling SVG property synchronization to SynchronizablePropertyController. (WebCore::SVGElement::propertyController): Expose reference to SynchronizablePropertyController object.
- svg/SVGViewSpec.cpp: Reorder initialization order of contextElement, leading to possible crashes. (WebCore::SVGViewSpec::SVGViewSpec): (WebCore::SVGViewSpec::viewTarget):
- svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::contextElement):
- svg/SynchronizablePropertyController.cpp: Added. (WebCore::SynchronizablePropertyController::SynchronizablePropertyController): (WebCore::SynchronizablePropertyController::registerProperty): (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): (WebCore::SynchronizablePropertyController::synchronizeProperty): (WebCore::SynchronizablePropertyController::synchronizeAllProperties): (WebCore::SynchronizablePropertyController::startAnimation): (WebCore::SynchronizablePropertyController::stopAnimation):
- svg/SynchronizablePropertyController.h: Added. (WebCore::SynchronizableProperty::SynchronizableProperty): (WebCore::SynchronizableProperty::isHashTableDeletedValue): (WebCore::SynchronizableProperty::operator==): (WebCore::SynchronizablePropertyHash::hash): (WebCore::SynchronizablePropertyHash::equal): (WebCore::SynchronizablePropertyHashTraits::constructDeletedValue): (WebCore::SynchronizablePropertyHashTraits::isDeletedValue):
- 3:38 PM Changeset in webkit [49744] by
-
- 2 edits in trunk/BugsSite
Reviewed by Eric Carlson.
https://bugs.webkit.org/show_bug.cgi?id=30470
Make marking a bug as duplicate easier
- js/field.js: (setResolutionToDuplicate): Focus the edit field, too.
- 1:00 PM Changeset in webkit [49743] by
-
- 2 edits in trunk/WebCore
2009-10-17 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25413
[GTK] Please expose the level of headings
Exposes the heading level as an attribute of the AtkObject.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (addAttributeToSet): (webkit_accessible_get_attributes): (webkit_accessible_class_init):
- 8:54 AM Changeset in webkit [49742] by
-
- 2 edits in trunk/WebCore
2009-10-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
https://bugs.webkit.org/show_bug.cgi?id=30472
Put ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged
in EventHandler.cpp. MSVC fails to compile when DRAG_SUPPORT not enabled.
- page/EventHandler.cpp:
- 8:49 AM Changeset in webkit [49741] by
-
- 3 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Optionally allow the user to zoom text using the mouse wheel.
https://bugs.webkit.org/show_bug.cgi?id=30444
- 8:45 AM Changeset in webkit [49740] by
-
- 2 edits in trunk/WebCore
2009-10-17 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Seidel.
[chromium] Video controls not zoomed / transformed correctly
https://bugs.webkit.org/show_bug.cgi?id=30461
Draw the images in the controls scaled.
No new tests. With this change Chromium will pass the following tests:
LayoutTests/media/video-controls-zoomed.html
LayoutTests/media/video-controls-transformed.html
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaButton): Pass along the target rect directly. (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize): Adjust the thumb slide applied with the scale factor.
- 12:53 AM Changeset in webkit [49739] by
-
- 2 edits in trunk/WebCore
2009-10-17 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
[Gtk] Build fix for WebKitGtk after r49723.
Add bindings/js/JSExceptionBase.* to the build.
- GNUmakefile.am:
- 12:46 AM Changeset in webkit [49738] by
-
- 2 edits in trunk/WebCore
2009-10-17 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Add bindings/js/JSExceptionBase.cpp to the build.
- WebCore.pro:
- 12:32 AM Changeset in webkit [49737] by
-
- 3 edits in trunk/LayoutTests
2009-10-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: reduce inspector console test size - it times out.
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
Oct 16, 2009:
- 11:59 PM Changeset in webkit [49736] by
-
- 2 edits in trunk/BugsSite
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=30470
Make marking a bug as duplicate easier
- js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user click again.
- 11:50 PM WebKit Team edited by
- Added Drag and Drop to my section. (diff)
- 11:29 PM Changeset in webkit [49735] by
-
- 12 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=30456
Fixes for new Debug_All Windows build configuration.
Reviewed by Dan Bernstein.
WebCore:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::findCFNetworkModule): Ask for the correct library instead of guessing.
- platform/win/ScrollbarThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
- rendering/RenderMediaControls.cpp: Use new DEBUG_ALL preprocessor define for library naming.
- rendering/RenderThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
WebKit/win:
- WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming.
WebKitLibraries:
- win/tools/vsprops/debug_all.vsprops:
Define DEBUG_ALL in Debug_All configuration.
Continue to define USE_DEBUG_SAFARI_THEME for open source SafariTheme header usage.
WebKitTools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
- DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
- 10:52 PM Changeset in webkit [49734] by
-
- 98 edits1 add in trunk
Rolled back in r49717 with the build maybe working now?
- 10:15 PM Changeset in webkit [49733] by
-
- 5 edits in trunk/WebKit/mac
Reviewed by Jon Honeycutt.
<rdar://problem/7304575>
- Plugins/WebBaseNetscapePluginView.h: Added new boolean ivar and -hasBeenHalted instance method.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView halt]):Update _hasBeenHalted. (-[WebBaseNetscapePluginView hasBeenHalted]): Added.
- WebView/WebView.mm: (+[WebView _hasPluginForNodeBeenHalted:]): Checks to see if a plug-in node's been halted.
- WebView/WebViewPrivate.h: Added -_hasPluginForNodeBeenHalted method.
- 9:38 PM Changeset in webkit [49732] by
-
- 8 edits in trunk
Add SPI to determine whether a plug-in has ever been halted.
Part of <rdar://problem/7312158>.
Reviewed by Dan Bernstein.
WebCore:
- plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize m_hasBeenHalted.
- plugins/PluginView.h:
(WebCore::PluginView::hasBeenHalted):
Return m_hasBeenHalted.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):
Set m_hasBeenHalted.
WebKit/win:
- Interfaces/IWebViewPrivate.idl:
Add hasPluginForNodeBeenHalted().
- WebView.cpp:
(pluginViewForNode):
Code factored out of isNodeHaltedPlugin().
(WebView::isNodeHaltedPlugin):
Remove STDMETHODCALLTYPE, as it has no use at the definition. Use
pluginViewForNode().
(WebView::restartHaltedPluginForNode):
Ditto.
(WebView::hasPluginForNodeBeenHalted):
Get the PluginView for the given node. Return the result of
PluginView::hasBeenHalted().
- WebView.h:
Declare hasPluginForNodeBeenHalted().
- 9:23 PM Changeset in webkit [49731] by
-
- 2 edits in trunk/LayoutTests
2009-10-16 Simon Fraser <Simon Fraser>
Skip this test:
compositing/animation/animated-composited-inside-hidden.html
because the fix for https://bugs.webkit.org/show_bug.cgi?id=26770 was backed out.
- platform/mac/Skipped:
- 8:54 PM Changeset in webkit [49730] by
-
- 2 edits in trunk/WebKit/qt
[Qt] QGLauncher leaks WebPage object
https://bugs.webkit.org/show_bug.cgi?id=30465
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.
Make 'SharedScene' to own 'WebPage' reference and delete it at its destructor.
- Api/qwebpage.cpp:
(QWebPage::view):
- Api/qwebpage_p.h:
- QGVLauncher/main.cpp:
(SharedScene::SharedScene):
(SharedScene::~SharedScene):
- 8:51 PM Changeset in webkit [49729] by
-
- 3 edits in trunk/WebKit/qt
[Qt] "dangling" pointer to qwebpage's view object can leads QGLauncher to crash
https://bugs.webkit.org/show_bug.cgi?id=30459
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.
Remove all setView(ev->widget()) calls in QWebPage and QGWV event handling methods,
since QWebPageClient would do the trick.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::hoverMoveEvent):
- Api/qwebpage.cpp:
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):
- 8:35 PM Changeset in webkit [49728] by
-
- 4 edits in trunk/LayoutTests
Updated expected results of tests that give CONSOLE messages for
new verbose output.
- fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
- fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
- platform/mac/fast/dynamic/015-expected.txt:
- 8:10 PM Changeset in webkit [49727] by
-
- 3 edits12 adds in trunk
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
@charset rule after the first byte causes the rest of css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265
Apparently we're supposed to tolerate whitespace before the charset
rule so folks can write code like this:
<style>
@charset "utf-8"
...
</style>
I'm told this is one of the top compatability problems in China.
Tests: fast/css/comment-before-charset-external.html
fast/css/comment-before-charset.html
fast/css/many-spaces-before-charset.html
fast/css/space-before-charset-external.html
fast/css/space-before-charset.html
- css/CSSGrammar.y:
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
@charset rule after the first byte causes the rest of css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265
Test that we allow whitespace and comments before the charset rule.
These test results all match Firefox.
- fast/css/comment-before-charset-expected.txt: Added.
- fast/css/comment-before-charset-external-expected.txt: Added.
- fast/css/comment-before-charset-external.html: Added.
- fast/css/comment-before-charset.html: Added.
- fast/css/many-spaces-before-charset-expected.txt: Added.
- fast/css/many-spaces-before-charset.html: Added.
- fast/css/resources/comment-before-charset.css: Added.
- fast/css/resources/space-before-charset.css: Added.
- fast/css/space-before-charset-expected.txt: Added.
- fast/css/space-before-charset-external-expected.txt: Added.
- fast/css/space-before-charset-external.html: Added.
- fast/css/space-before-charset.html: Added.
- 7:31 PM Changeset in webkit [49726] by
-
- 29 edits in trunk
Roll out r49717 as it broke the build.
- 6:23 PM Changeset in webkit [49725] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Remove inspector tests from Windows Skipped list, because they pass locally
and the front-end changes are picked up by the bots.
- platform/win/Skipped:
- 6:20 PM Changeset in webkit [49724] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: apparently we shouldn't export those symbols?
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
- JavaScriptCore.exp:
- 6:18 PM Changeset in webkit [49723] by
-
- 10 edits8 adds in trunk
WebCore: Fixes part of <http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.
Reviewed by Darin Adler.
Add a description field to ExceptionBase, and call it through
reportException which allows the user/developer to get a more detailed
and coherent error explanation through the Web Inspector.
This only applies to exceptions that come from a script on the page when
it is run. DOM Exceptions that come from the code run in the console, or DOM
exceptions that are caught and logged will come in a future patch.
Tests: inspector/uncaught-dom1-exception.html
inspector/uncaught-dom3-exception.html
inspector/uncaught-dom8-exception.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- bindings/js/JSExceptionBase.cpp: Added.
(WebCore::toExceptionBase):
- bindings/js/JSExceptionBase.h: Added.
- dom/ExceptionBase.cpp:
(WebCore::ExceptionBase::ExceptionBase):
- dom/ExceptionBase.h:
(WebCore::ExceptionBase::description):
- dom/ExceptionCode.cpp:
(WebCore::):
(WebCore::getExceptionCodeDescription):
- dom/ExceptionCode.h:
LayoutTests: Fixes part of <http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.
Reviewed by Darin Adler.
Adds tests for output of uncaught exceptions to the Web Inspector
Console. Tests DOM exceptions 1, 3, and 8 (INDEX_SIZE_ERR, NOT_FOUND_ERR, and
HIERARCHY_REQUEST_ERR).
- inspector/uncaught-dom1-exception-expected.txt: Added.
- inspector/uncaught-dom1-exception.html: Added.
- inspector/uncaught-dom3-exception-expected.txt: Added.
- inspector/uncaught-dom3-exception.html: Added.
- inspector/uncaught-dom8-exception-expected.txt: Added.
- inspector/uncaught-dom8-exception.html: Added.
- 6:09 PM Changeset in webkit [49722] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: export some symbols.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
- JavaScriptCore.exp:
- 6:06 PM Changeset in webkit [49721] by
-
- 30 edits in trunk/JavaScriptCore
structure typeinfo flags should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=30468
Reviewed by Gavin Barraclough.
Add StructureFlag constant to the various JSC classes and use
it for the TypeInfo construction. This allows us to simply
accumulate flags by basing each classes StructureInfo on its parents.
- 5:45 PM Changeset in webkit [49720] by
-
- 2 edits in trunk/WebCore
Build fix: forgot to check in this #include.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
- bridge/runtime_root.h:
- 5:40 PM Changeset in webkit [49719] by
-
- 2 edits in trunk/WebKitSite
- coding/RefPtr.html: Minor revision, updating a link and tweaking
wording a bit in few places.
- 5:32 PM Changeset in webkit [49718] by
-
- 1 copy in tags/Safari-6531.21.3
New tag.
- 5:28 PM Changeset in webkit [49717] by
-
- 27 edits in trunk/JavaScriptCore
Fast for-in enumeration: Cache JSPropertyNameIterator; cache JSStrings
in JSPropertyNameIterator; inline more code.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
Reviewed by Oliver Hunt.
1.024x as fast on SunSpider (fasta: 1.43x as fast).
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetPropertyNames):
(JSC::BytecodeGenerator::emitNextPropertyName):
- bytecompiler/BytecodeGenerator.h: Added a few extra operands to
op_get_pnames and op_next_pname so that we can track iteration state
in the register file instead of in the JSPropertyNameIterator. (To be
cacheable, the JSPropertyNameIterator must be stateless.)
- interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".
(JSC::Interpreter::privateExecute): Updated for in-RegisterFile
iteration state tracking.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_pnames): Updated for in-RegisterFile
iteration state tracking.
(JSC::JIT::emit_op_next_pname): Inlined code generation for op_next_pname.
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
(JSC::): Added has_property and to_object stubs. Removed op_next_pname
stub, since has_property is all we need anymore.
- parser/Nodes.cpp:
(JSC::ForInNode::emitBytecode): Updated for in-RegisterFile
iteration state tracking.
- runtime/JSCell.h:
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames): Don't do caching at this layer
anymore, since we don't create a JSPropertyNameIterator at this layer.
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create): Do do caching at this layer.
(JSC::JSPropertyNameIterator::get): Updated for in-RegisterFile
iteration state tracking.
(JSC::JSPropertyNameIterator::markChildren): Mark our JSStrings.
- runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::size):
(JSC::JSPropertyNameIterator::setCachedStructure):
(JSC::JSPropertyNameIterator::cachedStructure):
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
(JSC::JSPropertyNameIterator::cachedPrototypeChain):
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::Structure::setEnumerationCache): Don't store iteration state in
a JSPropertyNameIterator. Do cache a JSPropertyNameIterator in a
Structure.
- runtime/JSValue.h:
(JSC::asCell):
- runtime/MarkStack.h: Make those mischievous #include gods happy.
- runtime/ObjectConstructor.cpp:
- runtime/Operations.h:
(JSC::normalizePrototypeChain): Renamed countPrototypeChainEntriesAndCheckForProxies
to normalizePrototypeChain, since it changes dictionary prototypes to
non-dictionary objects.
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArrayData::PropertyNameArrayData):
(JSC::PropertyNameArray::data):
(JSC::PropertyNameArray::size):
(JSC::PropertyNameArray::begin):
(JSC::PropertyNameArray::end): Simplified some code here to help with
current and future refactoring.
- runtime/Protect.h:
- runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition): No need to clear
the enumeration cache with adding / removing properties without
transition. It is an error to add / remove properties without transition
once an object has been observed, and we can ASSERT to catch that.
- runtime/Structure.h:
(JSC::Structure::enumerationCache): Changed the enumeration cache to
hold a JSPropertyNameIterator.
- runtime/StructureChain.cpp:
- runtime/StructureChain.h:
(JSC::StructureChain::head): Removed StructureChain::isCacheable because
it was wrong-headed in two ways: (1) It gave up when a prototype was a
dictionary, but instead we want un-dictionary heavily accessed
prototypes; (2) It folded a test for hasDefaultGetPropertyNames() into
a generic test for "cacheable-ness", but hasDefaultGetPropertyNames()
is only releavant to for-in caching.
- 5:27 PM Changeset in webkit [49716] by
-
- 5 edits in branches/safari-4-branch/WebCore
Merge r48971.
- 5:27 PM Changeset in webkit [49715] by
-
- 8 edits in branches/safari-4-branch
Merge r48683.
- 5:27 PM Changeset in webkit [49714] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:20 PM Changeset in webkit [49713] by
-
- 3 edits5 adds in trunk
2009-10-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Transform layer gets stuck with the wrong transform after an animation ends
<rdar://problem/7311662>
Work around a CoreAnimation bug which causes an animated transform layer to
end up with a stale transform.
Test: compositing/animation/state-at-end-event-transform-layer.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::bug7311367Workaround): (WebCore::GraphicsLayerCA::removeAnimationFromLayer):
- 5:20 PM Changeset in webkit [49712] by
-
- 2 edits in trunk/WebKit/wx
wxMSW non-precomp headers build fix.
- 5:17 PM Changeset in webkit [49711] by
-
- 4 edits20 adds in trunk
2009-10-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
After running a transition with an end event listener, can't change the transform
https://bugs.webkit.org/show_bug.cgi?id=30454
Fix an issue where, if a document had any listener for webkitTransitionEnd or webkitAnimationEnd,
the animations would not get cleaned up correctly, which broke subsequent changes of transform.
Now, we always clean up the animations right after queuing up the end events.
Tests: animations/state-at-end-event.html
transitions/move-after-transition.html
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::onAnimationEnd):
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::onAnimationEnd):
- 5:11 PM Changeset in webkit [49710] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Anders Carlson.
Small code cleanup
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::halt): Just call -[WebBaseNetscapePluginView halt]. (WebHaltablePlugin::restart): Just call -[WebBaseNetscapePluginView resumeFromHalt] (-[WebBaseNetscapePluginView halt]): (-[WebBaseNetscapePluginView resumeFromHalt]):
- WebView/WebView.mm: (_pluginViewForNode): Added a check if a render is a widget. This prevents a later assertion.
- 5:08 PM Changeset in webkit [49709] by
-
- 2 edits in trunk/WebCore
2009-10-15 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Handle the Enter Key in the Elements Tree Hierarchy
https://bugs.webkit.org/show_bug.cgi?id=30428
TextNode => Edit Text Node
Has Attributes => Edit First Attribute
No Attributes => Start Editing New Attribute
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): handle the "Enter" key (WebInspector.ElementsTreeElement.prototype.set hovered): only add new attribute button on nodes with attributes (WebInspector.ElementsTreeElement.prototype._addNewAttribute): prevent moving backwards where there are no attributes (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): renamed to be clearer (WebInspector.ElementsTreeElement.prototype._startEditing): transition to the appropriate edit state for a tree element
- 5:04 PM Changeset in webkit [49708] by
-
- 4 edits in trunk/WebKitTools
2009-10-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue status bot should list which buildbot is blocking the queue
https://bugs.webkit.org/show_bug.cgi?id=30452
Add new methods and testing.
- Scripts/bugzilla-tool:
- Scripts/modules/buildbot.py:
- Scripts/modules/buildbot_unittest.py:
- 4:57 PM Changeset in webkit [49707] by
-
- 3 edits in trunk/WebKitTools
2009-10-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
run-webkit-tests fails when CWD is not inside a WebKit checkout
https://bugs.webkit.org/show_bug.cgi?id=30451
- Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
- Scripts/modules/scm_unittest.py:
- Remove use of original_path (we don't need to restore the CWD).
- Don't use '.' to find the webkit checkout, use file instead.
- 4:44 PM Changeset in webkit [49706] by
-
- 7 edits in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix header indent style for FrameLoader and friends
https://bugs.webkit.org/show_bug.cgi?id=30430
- loader/FrameLoader.h: (WebCore::FrameLoader::frame): (WebCore::FrameLoader::policyChecker): (WebCore::FrameLoader::history): (WebCore::FrameLoader::notifier): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::policyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::client): (WebCore::FrameLoader::url): (WebCore::FrameLoader::isLoadingFromCachedPage): (WebCore::FrameLoader::committingFirstRealLoad): (WebCore::FrameLoader::committedFirstRealDocumentLoad): (WebCore::FrameLoader::creatingInitialEmptyDocument):
- loader/HistoryController.h: (WebCore::HistoryController::currentItem): (WebCore::HistoryController::provisionalItem):
- loader/PolicyCallback.h: (WebCore::PolicyCallback::request):
- loader/PolicyChecker.h: (WebCore::PolicyChecker::loadType): (WebCore::PolicyChecker::setLoadType): (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy):
- loader/RedirectScheduler.h:
- loader/ResourceLoadNotifier.h:
- 3:31 PM Changeset in webkit [49705] by
-
- 32 edits1 add in trunk
Add a Debug_All configuration to build entire stack as debug.
Change Debug_Internal to:
- stop using _debug suffix for all WebKit/Safari binaries
- not use _debug as a DLL naming suffix
- use non-debug C runtime lib.
Reviewed by Adam Roben.
- JavaScriptCore.vcproj/JavaScriptCore.make: Debug build in makefile should build Debug_All.
- JavaScriptCore.vcproj/JavaScriptCore.sln: Add Debug_All configuration.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add Debug_All configuration.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add Debug_All configuration.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Add Debug_All configuration.
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_All configuration.
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_All configuration.
WebCore:
- WebCore.vcproj/QTMovieWin.vcproj: Add Debug_All configuration.
- WebCore.vcproj/WebCore.make: Debug build in makefile should build Debug_All.
- WebCore.vcproj/WebCore.sln: Add Debug_All configuration.
- WebCore.vcproj/WebCore.submit.sln: Add Debug_All configuration.
- WebCore.vcproj/WebCore.vcproj: Add Debug_All configuration.
- WebCore.vcproj/WebCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
WebKit/win:
- WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all".
- WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All.
- WebKit.vcproj/WebKit.sln: Add Debug_All configuration.
- WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration.
- WebKit.vcproj/WebKit.vcproj:
Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo.
Add Debug_All configuration.
- WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration.
WebKitLibraries:
- win/tools/vsprops/debug_all.vsprops: Added.
Use debug C runtime library in debug_all.
Specify USE_DEBUG_SAFARI_THEME to get "_debug" suffix for debug_all.
- win/tools/vsprops/debug_internal.vsprops:
Don't specify debug C runtime library in debug_internal.
Don't specify _debug suffix for standard debug_internal builds.
WebKitTools:
- DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
- DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
- DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
Add missing debug.vsprops inherited property sheet.
Add Debug_All configuration.
- FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
- WinLauncher/WinLauncher.vcproj:
Removed extraneous definitions inherited from vsprops.
Add Debug_All configuration.
- 3:28 PM Changeset in webkit [49704] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Rolling out r49661 since it makes tests fail on GTK+ and Mac with Xiph plugin
- 3:07 PM Changeset in webkit [49703] by
-
- 3 edits in trunk/WebCore
2009-10-16 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r49693, because it broke Chromium build.
http://trac.webkit.org/changeset/49693
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 3:03 PM Changeset in webkit [49702] by
-
- 5 edits4 adds in trunk
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Updated media resource selection algorithm to reflect latest HTML 5 specification.
- media/video-play-pause-exception-expected.txt:
- media/video-play-pause-exception.html:
- media/video-src-empty-expected.txt: Added.
- media/video-src-empty.html: Added.
- media/video-src-none-expected.txt: Added.
- media/video-src-none.html: Added.
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Updated media resource selection algorithm to reflect latest HTML 5 specification.
Noticable changes:
- Elements with no source should have their network state set to NETWORK_EMPTY as opposed to NETWORK_NO_SOURCE
- Empty string ("") is now considered a valid URL resolving to the current page and will be loaded
Tests: media/video-src-empty.html
media/video-src-none.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): Updated code and comments to match spec.
- 2:33 PM Changeset in webkit [49701] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-16 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Tests that the JavaScript array event.dataTransfer.types can be accessed
within an ondrop handler without causing a crash.
Although this issue has been resolved as of nightly r49550 we should add a
test case so that we can prevent a regression of this issue.
- fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Added.
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html: Added.
- 2:30 PM Changeset in webkit [49700] by
-
- 3 edits3 adds in trunk
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Insecure plug-ins don't trigger mixed content
https://bugs.webkit.org/show_bug.cgi?id=30431
- http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-plugin-in-iframe.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-plugin.html: Added.
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Insecure plug-ins don't trigger mixed content
https://bugs.webkit.org/show_bug.cgi?id=30431
Added the missing check.
Test: http/tests/security/mixedContent/insecure-plugin-in-iframe.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin):
- 2:26 PM Changeset in webkit [49699] by
-
- 4 edits in trunk/WebKit/win
Add SPI to restart a halted plug-in.
Part of <rdar://problem/7273354> Halted plug-ins should restart on
mouseover
https://bugs.webkit.org/show_bug.cgi?id=30151
Reviewed by Kevin Decker.
- Interfaces/IWebViewPrivate.idl:
Add restartHaltedPluginForNode().
- WebView.cpp:
(WebView::restartHaltedPluginForNode):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, call PluginView::restart().
- WebView.h:
Declare restartHaltedPluginForNode().
- 2:21 PM Changeset in webkit [49698] by
-
- 2 edits in trunk/WebCore
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Set autobuffer to true and schedule load in V8 audio element constructor.
Covered by existing tests.
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Set autobuffer to true and schedule load.
- 2:06 PM Changeset in webkit [49697] by
-
- 2 edits in trunk/WebCore
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Remove FIXME in RenderMediaControlsChromium as bug was fixed upstream.
Covered by existing media layout tests.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): Removed round() and FIXME.
- 2:01 PM BuildingOnWindows edited by
- Added note about error PRJ0002 - i.e. cannot find mspdb80.dll (diff)
- 1:57 PM Changeset in webkit [49696] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Anders Carlson.
Last part of:
<rdar://problem/7273354>
- WebView/WebView.mm: (_pluginViewForNode): Added with code extracted from _isNodeHaltedPlugin (+[WebView _isNodeHaltedPlugin:]): Made this a class method. (+[WebView _restartHaltedPluginForNode:]): Added. Restarts a plug-in
- WebView/WebViewPrivate.h: Added +_restartHaltedPluginForNode to header.
- 1:56 PM Changeset in webkit [49695] by
-
- 2 edits in trunk/WebCore
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Fix Chromium media controls to render a disabled play button when the element is unintialized.
Covered by existing layout tests.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaPlayButton): Include check for NETWORK_EMPTY to render disabled play button.
- 1:39 PM Changeset in webkit [49694] by
-
- 40 edits in trunk
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Gavin Barraclough.
Last part -- replace HasDefaultGetPropertyNames with OverridesGetPropertyNames
flag.
- 1:37 PM Changeset in webkit [49693] by
-
- 3 edits in trunk/WebCore
2009-10-16 Steven Knight <sgk@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=30447
Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.
Chrome should still build and test successfully.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 1:28 PM Changeset in webkit [49692] by
-
- 2 edits in trunk/WebCore
2009-10-16 Simon Fraser <Simon Fraser>
Reviewed by Eric Carlson.
Transform transitions that used to be accelerated are no longer so
https://bugs.webkit.org/show_bug.cgi?id=30453
The change in r49633, to not run accelerated animations/transitions on layers that
are not attached, broke accelerated transitions/animations in many cases where they start
as soon as the page loads. This change reverts the code that tests for the GraphicsLayer being
attached.
No test, because it's not possible from a test to know whether a transition is accelerated or not.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition):
- 1:21 PM Changeset in webkit [49691] by
-
- 2 edits in trunk/LayoutTests
2009-10-16 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
LayoutTests/fast/loader/local-JavaScript-from-local.html times out in case of error.
https://bugs.webkit.org/show_bug.cgi?id=30434
- fast/loader/local-JavaScript-from-local.html:
- 11:46 AM Changeset in webkit [49690] by
-
- 3 edits in trunk/WebKitTools
check-webkit-style is wrong about indent checking in namespaces
in header files and a few other things
https://bugs.webkit.org/show_bug.cgi?id=30362
Patch by Carol Szabo <carol.szabo@nokia.com> on 2009-10-16
Reviewed by David Levin.
The few other things include:
+ check-webkit-style does not require spaces around the equal sign
inside 'if' statements and around binary operators that take
numeric literals.
+ check-webkit-style reports false errors for the / operator
when part of a filename in the #include directive.
- Scripts/modules/cpp_style.py:
Improved indentation checking and space checking around
binary operators. While the checks are still not perfect,
they are clearly better than before.
- Scripts/modules/cpp_style_unittest.py:
Added test cases for the newly supported checks and modified old
test cases to match the new guidelines
- 11:33 AM Changeset in webkit [49689] by
-
- 5 edits in trunk/WebKit/mac
Reviewed by Anders.
<rdar://problem/7273354>
- Plugins/WebBaseNetscapePluginView.h: Added _isHalted ivar and three new methods: -halt, -resumeFromHalt, and -isHalted
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::halt): Call -halt instead of -stop. (WebHaltablePlugin::restart):Call -resumeFromHalt instead of -start. (-[WebBaseNetscapePluginView halt]): Added. Stop the plug-in, update _isHalted. (-[WebBaseNetscapePluginView resumeFromHalt]): Added. Start the plug-in, update _isHalted. (-[WebBaseNetscapePluginView isHalted]): Added.
- WebView/WebView.mm: (-[WebView _isNodeHaltedPlugin:]): Added. Queries a DOMNode to determine if it's a halted plug-in.
- WebView/WebViewPrivate.h: Added _isNodeHaltedPlugin.
- 11:23 AM Changeset in webkit [49688] by
-
- 6 edits in trunk
wxMSW build fix, we can't use the simple hash there because the PlatformModuleVersion
structure differs.
- 10:46 AM Changeset in webkit [49687] by
-
- 1 edit1 add in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Unreviewed build fix. Add back MIMETypeRegistryChromium with the right
casing.
- platform/chromium/MIMETypeRegistryChromium.cpp: Added. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::getMIMETypeForPath): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): (WebCore::dummyHashSet): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
- 10:41 AM Changeset in webkit [49686] by
-
- 2 edits1 delete in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
MimeTypeRegistryChromium is mis-casen
https://bugs.webkit.org/show_bug.cgi?id=30441
Change the case of MimeTypeRegistryChromium to match other platforms.
- WebCore.gypi:
- platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
- platform/chromium/MimeTypeRegistryChromium.cpp: Removed.
- 10:35 AM Changeset in webkit [49685] by
-
- 2 edits in trunk/WebCore
2009-10-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Change EmptyPluginHalterClient in SVGImage to be non-static, to
match changes made http://trac.webkit.org/changeset/49385.
https://bugs.webkit.org/show_bug.cgi?id=30403
Run the following layout test sequence:
LayoutTests/svg/W3C-SVG-1.1/struct-image-01-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-03-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-04-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-06-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-08-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-09-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-10-t.svg
LayoutTests/svg/carto.net/scrollbar.svg
LayoutTests/svg/carto.net/selectionlist.svg
selectionlist.svg should not crash.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Made EmptyPluginHalterClient non-static.
- 10:27 AM Changeset in webkit [49684] by
-
- 2 edits in trunk/WebCore
2009-10-16 Victor Wang <victorw@chromium.org>
Reviewed by David Levin.
Add beforeload event support to V8DOMWrapper
LayoutTests/fast/dom/beforeload/frame-before-load.html
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
- 9:41 AM Changeset in webkit [49683] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
MimeTypeRegistryChromium is mis-casen
https://bugs.webkit.org/show_bug.cgi?id=30441
Change the case of MimeTypeRegistryChromium to match other platforms.
- WebCore.gypi:
- platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
- platform/chromium/MimeTypeRegistryChromium.cpp: Removed.
- 9:20 AM Changeset in webkit [49682] by
-
- 2 edits in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Mark Rowe.
Chrome doesn't set Content-Type for file upload when the file extension
is not recognized
https://bugs.webkit.org/show_bug.cgi?id=30433
Apparently, getMIMETypeForPath is supposed to return
application/octet-stream when it doesn't have a better MIME type.
- platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForPath):
- 8:58 AM Changeset in webkit [49681] by
-
- 4 edits in trunk
Pull out r49676 as it caused build breakges on Symbian
- 8:53 AM Changeset in webkit [49680] by
-
- 1 edit5 adds in trunk/LayoutTests
[Qt] Add empty skipped lists for the platform-specific results
Reviewed by Ariya Hidayat.
- platform/qt-linux/Skipped:
- platform/qt-mac/Skipped:
- platform/qt-win/Skipped:
- 8:45 AM Changeset in webkit [49679] by
-
- 3 edits1 add in trunk/JavaScriptCore
2009-10-16 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Implement ExecutableAllocator for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29946
Tested with YARR JIT enabled for Symbian;
This patch does not (yet) enable YARR JIT by default.
- JavaScriptCore.pri:
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorSymbian.cpp: Added. (JSC::ExecutableAllocator::intializePageSize): (JSC::ExecutablePool::systemAlloc): (JSC::ExecutablePool::systemRelease):
- 7:35 AM BuildingQtOnWindows edited by
- (diff)
- 6:26 AM Changeset in webkit [49678] by
-
- 2 edits in trunk/LayoutTests
[Qt] Update outdated platform dependent expected file.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-16
Reviewed by Tor Arne Vestbø.
- platform/qt/editing/execCommand/toggle-compound-styles-expected.txt:
- 6:26 AM Changeset in webkit [49677] by
-
- 1 edit in trunk/WebCore/ChangeLog
Crash fix when loading NPAPI plugins on Qt/Mac
Reviewed by Ariya Hidayat.
There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.
- plugins/mac/PluginPackageMac.cpp:
- 6:18 AM Changeset in webkit [49676] by
-
- 4 edits in trunk
2009-10-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Need a way to inform the application when a Netscape plugin is created or deleted
https://bugs.webkit.org/show_bug.cgi?id=30179
Inform the application when a plugin is created or destroyed, but only if the
application registered for these notifications.
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
2009-10-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Need a way to inform the application when a Netscape plugin is created or deleted
https://bugs.webkit.org/show_bug.cgi?id=30179
Added "c" style static methods for the application to hook up for
receiving notifications when a plugin is created or destroyed.
- Api/qwebpage.cpp:
- 5:47 AM Changeset in webkit [49675] by
-
- 3 edits2 adds in trunk
2009-10-16 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Added test case for testing navigator.language.
https://bugs.webkit.org/show_bug.cgi?id=29653
Different browsers may not return the exact same result.
Some examples here:
Safari 4 WinXP: "en-US"
Safari 4 Mac: "en-us"
Firefox 3 Mac/WinXP: "en-US"
Opera 9.64: "en"
Epiphany 2 GTK: "en"
Chrome 3 WinXP: "en-US"
The test case checks if the first two letters are "en"
when system locale is set to "en_US.iso88591".
- fast/js/navigator-language-expected.txt: Added.
- fast/js/navigator-language.html: Added.
2009-10-16 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Default language translation should be determined by locale settings,
e.g., "en-US".
https://bugs.webkit.org/show_bug.cgi?id=29653
Test: fast/js/navigator-language.html
- platform/qt/Localizations.cpp: (WebCore::defaultLanguage):
- 3:58 AM QtWebKitPlugins edited by
- (diff)
- 3:53 AM NetscapePluginsOnMacNotes created by
- 3:42 AM QtWebKitPlugins edited by
- (diff)
- 3:35 AM Changeset in webkit [49674] by
-
- 2 edits in trunk/WebCore
Crash fix when loading NPAPI plugins on Qt/Mac
Reviewed by Ariya Hidayat.
There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.
- plugins/mac/PluginPackageMac.cpp:
- 1:02 AM QtWebKitPlugins edited by
- (diff)
- 12:53 AM QtWebKitPlugins created by
Oct 15, 2009:
- 11:46 PM Changeset in webkit [49673] by
-
- 2 edits in trunk/WebCore
Fix for Chromium/skia's implementation of canvas's isPointInPath().
https://bugs.webkit.org/show_bug.cgi?id=30402
Reviewed by David Levin.
Covered by LayoutTests/fast/canvas/pointInPath.html.
- platform/graphics/skia/SkiaUtils.cpp:
(WebCore::SkPathContainsPoint):
- 11:42 PM Changeset in webkit [49672] by
-
- 1 edit36 adds in trunk/WebKitTools
2009-10-15 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Levin.
Add mod_pywebsocket to test Web Sockets.
http://code.google.com/p/pywebsocket/
https://bugs.webkit.org/show_bug.cgi?id=27490
- pywebsocket/COPYING: Added.
- pywebsocket/MANIFEST.in: Added.
- pywebsocket/README: Added.
- pywebsocket/example/echo_client.py: Added.
- pywebsocket/example/echo_wsh.py: Added.
- pywebsocket/mod_pywebsocket/init.py: Added.
- pywebsocket/mod_pywebsocket/dispatch.py: Added.
- pywebsocket/mod_pywebsocket/handshake.py: Added.
- pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
- pywebsocket/mod_pywebsocket/msgutil.py: Added.
- pywebsocket/mod_pywebsocket/standalone.py: Added.
- pywebsocket/mod_pywebsocket/util.py: Added.
- pywebsocket/setup.py: Added.
- pywebsocket/test/config.py: Added.
- pywebsocket/test/mock.py: Added.
- pywebsocket/test/run_all.py: Added.
- pywebsocket/test/test_dispatch.py: Added.
- pywebsocket/test/test_handshake.py: Added.
- pywebsocket/test/test_mock.py: Added.
- pywebsocket/test/test_msgutil.py: Added.
- pywebsocket/test/test_util.py: Added.
- pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
- pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
- pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
- 10:32 PM Changeset in webkit [49671] by
-
- 12 edits2 adds in trunk/WebCore
2009-10-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor ResourceLoadNotifier out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30379
These methods have virtually no interaction with the rest of
FrameLoader.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- dom/Document.cpp: (WebCore::Document::resourceRetrievedByXMLHttpRequest):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::ResourceLoadNotifier::ResourceLoadNotifier): (WebCore::ResourceLoadNotifier::activeDocumentLoader): (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::willSendRequest): (WebCore::ResourceLoadNotifier::didReceiveResponse): (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::ResourceLoadNotifier::didFinishLoad): (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge): (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
- loader/FrameLoader.h: (WebCore::FrameLoader::notifier):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError):
- loader/ResourceLoadNotifier.cpp: Added. (WebCore::ResourceLoadNotifier::ResourceLoadNotifier): (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge): (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::willSendRequest): (WebCore::ResourceLoadNotifier::didReceiveResponse): (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::didFinishLoad): (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest): (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): (WebCore::ResourceLoadNotifier::activeDocumentLoader):
- loader/ResourceLoadNotifier.h: Added.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
- 10:19 PM Changeset in webkit [49670] by
-
- 2 edits in trunk/WebCore
2009-10-15 Roland Steiner <rolandsteiner@google.com>
Reviewed by Darin Fisher.
Bug 30427 - Remove unneeded methods in ChromiumDataObject
(https://bugs.webkit.org/show_bug.cgi?id=30427)
Remove no longer needed methods from ChromiumDataObject.
No new tests (no functional change)
- platform/chromium/ChromiumDataObject.h:
- 10:03 PM Changeset in webkit [49669] by
-
- 3 edits in trunk/WebKitTools
2009-10-15 James Robinson <jamesr@google.com>
Reviewed by David Levin.
Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 6:27 PM Changeset in webkit [49668] by
-
- 4 edits18 deletes in trunk
2009-10-15 Daniel Bates <dbates@webkit.org>
No review, rolling out r49644.
http://trac.webkit.org/changeset/49644
We need to think about this change some more. See bug #30418
for more details.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::canSetBaseElementURL): (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h:
2009-10-15 Daniel Bates <dbates@webkit.org>
No review, rolling out r49644.
http://trac.webkit.org/changeset/49644
- http/tests/security/xssAuditor/base-href-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/base-href-comment.html: Removed.
- http/tests/security/xssAuditor/iframe-javascript-url-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/iframe-javascript-url-comment.html: Removed.
- http/tests/security/xssAuditor/img-onerror-HTML-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/img-onerror-HTML-comment.html: Removed.
- http/tests/security/xssAuditor/img-onerror-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/img-onerror-comment.html: Removed.
- http/tests/security/xssAuditor/object-tag-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/object-tag-comment.html: Removed.
- http/tests/security/xssAuditor/resources/echo-before-image.pl: Removed.
- http/tests/security/xssAuditor/resources/echo-head-base-href-comment.pl: Removed.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html: Removed.
- http/tests/security/xssAuditor/script-tag-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-comment.html: Removed.
- http/tests/security/xssAuditor/script-tag-with-source-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-with-source-comment.html: Removed.
- 4:44 PM Changeset in webkit [49667] by
-
- 1 edit2 adds in trunk/LayoutTests
Rubber-stamped by Adele Peterson.
Update Windows expected results after http://trac.webkit.org/changeset/49619.
- platform/win/fast/inline: Added.
- platform/win/fast/inline/dirtyLinesForInline-expected.txt: Added.
- 4:22 PM Changeset in webkit [49666] by
-
- 8 edits in trunk
Add SPI to determine whether a node is a halted plug-in.
Part of <rdar://problem/7273354> Halted plug-ins should restart on
mouseover
https://bugs.webkit.org/show_bug.cgi?id=30151
Reviewed by Darin Adler.
WebCore:
- plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize m_isHalted.
- plugins/PluginView.h:
(WebCore::PluginView::isHalted):
Return m_isHalted.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):
Set m_isHalted to true.
(WebCore::PluginView::restart):
clear m_isHalted.
WebKit/win:
- Interfaces/IWebViewPrivate.idl:
Add isNodehaltedPlugin().
- WebView.cpp:
(WebView::isNodeHaltedPlugin):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, return the result of PluginView::isHalted().
- WebView.h:
Declare isNodeHaltedPlugin().
- 4:17 PM Changeset in webkit [49665] by
-
- 4 edits in trunk
2009-10-15 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] marshal stamp files are not cleaned after a distclean
https://bugs.webkit.org/show_bug.cgi?id=30156
Add stamp-po to CLEANFILES.
- GNUmakefile.am:
2009-10-15 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] marshal stamp files are not cleaned after a distclean
https://bugs.webkit.org/show_bug.cgi?id=30156
Add the stamp files directly to cleanfiles. Also rearrange the
variable declarations so we don't miss any files that need to be
cleaned up during the clean targets.
- GNUmakefile.am:
- 4:00 PM Changeset in webkit [49664] by
-
- 2 edits in trunk/WebKitTools
Fixes <http://webkit.org/b/30411>.
REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
Reviewed by Adam Roben.
Added a check for isChromium() in pdevenv, and pass /useenv if we are not
building Chromium.
- Scripts/pdevenv:
- 2:55 PM Changeset in webkit [49663] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: skip inspector tests on windows until
incremental build catches frontend files.
- platform/win/Skipped:
- 2:54 PM Changeset in webkit [49662] by
-
- 2 edits in trunk/WebCore
2009-10-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Oliver Hunt.
Change JSC::HasNonDefaultMark to OverridesMarkChildren in createStructure function.
- bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethod::createStructure):
- 2:53 PM Changeset in webkit [49661] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Darin Adler.
Fix media layout test file ordering so both branded and unbranded builds of Chromium will pass layout tests.
- media/media-file.js: Fixed file ordering.
- 2:51 PM Changeset in webkit [49660] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 2:50 PM Changeset in webkit [49659] by
-
- 1 copy in tags/Safari-6531.21.1
New tag.
- 2:39 PM Changeset in webkit [49658] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46777.
- 2:37 PM Changeset in webkit [49657] by
-
- 2 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Update the wxPython simple.py sample to match current wxWebKit API.
https://bugs.webkit.org/show_bug.cgi?id=30406
- 2:31 PM Changeset in webkit [49656] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Prevent subsequent tests from failing upon inspector
test timeout.
- inspector/evaluate-in-frontend.js: (onload.setTimeout):
- 2:30 PM Changeset in webkit [49655] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 2:27 PM Changeset in webkit [49654] by
-
- 3 edits1 add in trunk/WebKitTools
Reviewed by Kevin Ollivier.
Add Mac package building scripts for wx.
https://bugs.webkit.org/show_bug.cgi?id=30405
- 2:11 PM Changeset in webkit [49653] by
-
- 2 edits in trunk/WebKit/mac
2009-10-15 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/7306052> Fullscreen max/min volume buttons non-functional
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Set volume buttons target and action. (-[WebVideoFullscreenHUDWindowController decrementVolume:]): New, decrement the volume by 10%. (-[WebVideoFullscreenHUDWindowController incrementVolume:]): New, increment the volume by 10%.
- 2:01 PM Changeset in webkit [49652] by
-
- 2 edits19 adds in trunk/LayoutTests
2009-10-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Eric Seidel.
[Gtk][Layout tests] Generate results for dom tests
https://bugs.webkit.org/show_bug.cgi?id=29893
Add results for dom tests and enable these tests in the Skipped.
- platform/gtk/Skipped:
- platform/gtk/dom/xhtml/level3/core/canonicalform08-expected.txt: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.txt.
- platform/gtk/dom/xhtml/level3/core/canonicalform09-expected.txt: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform09-expected.txt.
- platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodelookupprefix19-expected.txt: Added.
- 1:39 PM Changeset in webkit [49651] by
-
- 7 edits2 adds in trunk
2009-10-15 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=24731
And
rdar://problem/5015961
Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend)
in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is
correctly set.
The WebView and WebDropSource drag-and-drop functions, as called by function
DoDragDrop in its event loop, neither used the drop effect as specified by
event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed.
Instead, these functions defaulted to some hardcoded drop effect and set of
allowed drop effects, respectively.
Tests: fast/events/drag-and-drop.html
- WebCoreSupport/WebDragClient.cpp: (WebDragClient::startDrag):
- WebDropSource.cpp: (WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt into method WebDragClient::startDrag.
- WebDropSource.h:
- WebView.cpp: (WebView::keyStateToDragOperation): Fixes <rdar://problem/5015961>. Determines appropriate drop effect from state of keyboard and allowed effects m_page->dragController()->sourceDragOperation(). (WebView::DragEnter): (WebView::DragOver): (WebView::Drop):
- WebView.h:
2009-10-15 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=24731
And
rdar://problem/5015961
Tests that DHTML drag-and-drop works correctly.
Note, this test fails when effectAllowed == "uninitialized" because
this effect has not been implemented yet (see bug #30291).
- fast/events/drag-and-drop-expected.txt: Added.
- fast/events/drag-and-drop.html: Added.
- 1:34 PM Changeset in webkit [49650] by
-
- 1 edit1 add in trunk/WebCore
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed - build fix.
Web Inspector: add file missing in r49648
- inspector/front-end/TestController.js: Added. (WebInspector.TestController): (WebInspector.TestController.prototype.waitUntilDone): (WebInspector.TestController.prototype.notifyDone): (WebInspector.evaluateForTestInFrontend):
- 12:55 PM Changeset in webkit [49649] by
-
- 45 edits in trunk
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Darin Adler
Part 2 -- Reverse the TypeInfo HasDefaultMark flag to OverridesMarkChildren, etc
- 12:51 PM Changeset in webkit [49648] by
-
- 6 edits in trunk/WebCore
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: introduce test controller with waitUntilDone
on frontend side.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/TestController.js: Added. (WebInspector.TestController): (WebInspector.TestController.prototype.waitUntilDone): (WebInspector.TestController.prototype.notifyDone): (WebInspector.evaluateForTestInFrontend):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
- 12:28 PM Changeset in webkit [49647] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Protect WebSocket calls in case the feature is not compiled in.
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
- 12:28 PM Changeset in webkit [49646] by
-
- 4 edits in trunk/LayoutTests
2009-10-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Rebaseline tests after changes made in r49405.
- platform/gtk/editing/execCommand/4916541-expected.txt: Rebaseline.
- platform/gtk/editing/execCommand/5138441-expected.txt: Ditto.
- platform/gtk/editing/execCommand/5481523-expected.txt: Ditto.
- 12:11 PM Changeset in webkit [49645] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Xan Lopez <xlopez@igalia.com>
Remove obsolete test from Skipped list.
- platform/gtk/Skipped:
- 12:04 PM Changeset in webkit [49644] by
-
- 4 edits18 adds in trunk
2009-10-15 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Fixes an issue in which injecting an inline event handler whose value ends in a single-line
JavaScript comment can bypass the XSSAuditor. Similarly fixes this issue with respect to
the HTML Base element, HTML Object element, inline and external script tags, and
JavaScript multi-line variants of all of these attacks.
Tests: http/tests/security/xssAuditor/base-href-comment.html
http/tests/security/xssAuditor/iframe-javascript-url-comment.html
http/tests/security/xssAuditor/img-onerror-HTML-comment.html
http/tests/security/xssAuditor/img-onerror-comment.html
http/tests/security/xssAuditor/object-tag-comment.html
http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html
http/tests/security/xssAuditor/script-tag-comment.html
http/tests/security/xssAuditor/script-tag-with-source-comment.html
- page/XSSAuditor.cpp: Added constant minAttackLength. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::canSetBaseElementURL): (WebCore::XSSAuditor::findInRequest): Added parameter context. Only looks at up to minAttackLength of script code plus context (if any).
- page/XSSAuditor.h:
2009-10-15 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Tests that inline event handlers whose value ends in a single-line JavaScript
comment cannot bypass the XSSAuditor. Also tests that the XSSAuditor prevents
similar attack vectors with respect to the HTML Base element, HTML Object
element, and external JavaScripts.
- http/tests/security/xssAuditor/base-href-comment-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-comment.html: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-comment-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-comment.html: Added.
- http/tests/security/xssAuditor/img-onerror-HTML-comment-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-HTML-comment.html: Added.
- http/tests/security/xssAuditor/img-onerror-comment-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-comment.html: Added.
- http/tests/security/xssAuditor/object-tag-comment-expected.txt: Added.
- http/tests/security/xssAuditor/object-tag-comment.html: Added.
- http/tests/security/xssAuditor/resources/echo-before-image.pl: Added.
- http/tests/security/xssAuditor/resources/echo-head-base-href-comment.pl: Added.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html: Added.
- http/tests/security/xssAuditor/script-tag-comment-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-comment.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-comment-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-comment.html: Added.
- 11:42 AM Changeset in webkit [49643] by
-
- 5 edits in trunk
WebKit/gtk
2009-10-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Add a settings to enable support for experimental Web Sockets.
Currently this comes in handy in layout tests.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
WebKitTools
2009-10-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Enable Web Sockets support when running layout tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 11:21 AM Changeset in webkit [49642] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Make QGLauncher's WebPage class constructor to get a QObject* as parent (not QWidget*).
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-15
Rubberstamped by Tor Arne.
- QGVLauncher/main.cpp:
(WebPage::WebPage):
- 11:16 AM Changeset in webkit [49641] by
-
- 12 edits in trunk/WebCore
2009-10-08 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Currently, Skia clip paths are 1-bit. This patch makes our path
clipping anti-aliased for non-canvas drawing.
http://code.google.com/p/chromium/issues/detail?id=5927
https://bugs.webkit.org/show_bug.cgi?id=28820
http://www.imperialviolet.org/2009/09/02/anti-aliased-clipping.html
Already covered by layout tests. New baselines will be needed in the
Chromium tree.
(Reland. First landed in r49329, reverted in r49330 due to Windows
build break)
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clip):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipPath):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::clipPathAntiAliased): (PlatformContextSkia::restore): (PlatformContextSkia::applyAntiAliasedClipPaths):
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::canvasClip):
- 10:55 AM Changeset in webkit [49640] by
-
- 1 edit1 add in trunk/LayoutTests
Rubber-stamped by Adele Peterson.
Add click-focus-anchor expected results on Windows, to make up for
the wonky way Windows finds its expected results.
- platform/win/fast/events/click-focus-anchor-expected.txt: Added.
- 10:53 AM Changeset in webkit [49639] by
-
- 2 edits in trunk
2009-10-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Help text fix - Web Sockets default is no, not yes.
- configure.ac:
- 10:42 AM Changeset in webkit [49638] by
-
- 2 edits in trunk/WebKitTools
2009-10-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Need to initialize event.button.button, since in most cases a
button number is not passed as an argument.
- DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): (mouseUpCallback):
- 10:33 AM Changeset in webkit [49637] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-10-15 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Adam Treat.
[Qt] Add expected files for passing http tests.
- platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
- platform/qt/http/tests/uri/css-href-expected.txt: Added.
- 10:32 AM Changeset in webkit [49636] by
-
- 4 edits in trunk
2009-10-15 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode
- WebCore.Video.exp: Export muted and setMute.
2009-10-15 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController setVolume:]): Unmute movie before changing volume.
- 10:26 AM Changeset in webkit [49635] by
-
- 1 edit7 adds in trunk/LayoutTests
2009-10-15 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Adam Treat.
[Qt] Add expected files for passing svg tests.
- platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
- platform/qt/svg/custom/mask-with-default-value-expected.txt: Added.
- platform/qt/svg/filters/feComposite-expected.txt: Added.
- platform/qt/svg/filters/feGaussianBlur-expected.txt: Added.
- platform/qt/svg/filters/feMerge-wrong-input-expected.txt: Added.
- platform/qt/svg/filters/sourceAlpha-expected.txt: Added.
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt: Added.
- 10:14 AM Changeset in webkit [49634] by
-
- 3 edits in trunk/WebKit/qt
[Qt] QGLauncher crashes while closing a window
https://bugs.webkit.org/show_bug.cgi?id=30385
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-15
Reviewed by Tor Arne.
Set page's pageClient reference to '0' at QGWV deletion.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::~QGraphicsWebView):
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(WebPage::WebPage):
(WebPage::aborting):
(tst_QGraphicsWebView::crashOnViewlessWebPages):
- 9:52 AM Changeset in webkit [49633] by
-
- 7 edits3 adds in trunk
2009-10-15 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Transitions fail to run sometimes
https://bugs.webkit.org/show_bug.cgi?id=26770
Fix an issue where we could attempt to start accelerated animations or transitions on
GraphicsLayer that were not rooted (because of visibility:hidden), which would leave
the AnimationController's m_waitingForResponse flag in a state that killed subsequent
software transitions.
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::endAnimationUpdate): (WebCore::AnimationControllerPrivate::receivedStartTimeResponse): (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList): (WebCore::AnimationControllerPrivate::startTimeResponse):
- page/animation/AnimationControllerPrivate.h: Make some methods non-inline for ease of debugging (these are not hot methods). Rename m_waitingForAResponse to m_waitingForResponse.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::hasAncestor): New method to report whether the receiver has the given layer as an ancestor. Used for checking whether a layer is rooted.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition): Don't try to start accelerated animations or transitions on non-rooted GraphicsLayers.
- 9:50 AM Changeset in webkit [49632] by
-
- 5 edits in trunk/WebCore
2009-10-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Refactor ProfilesPanel to support multiple profile types
Data describing different profile types are now stored in distinct objects.
https://bugs.webkit.org/show_bug.cgi?id=30332
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.profileCallback): (WebInspector.CPUProfileView): (WebInspector.CPUProfileView.prototype._sortData): (WebInspector.CPUProfileType): (WebInspector.CPUProfileType.prototype.get buttonTooltip): (WebInspector.CPUProfileType.prototype.get buttonStyle): (WebInspector.CPUProfileType.prototype.buttonClicked): (WebInspector.CPUProfileType.prototype.setRecordingProfile): (WebInspector.CPUProfile): (WebInspector.CPUProfile.prototype.get title): (WebInspector.CPUProfile.prototype.get uid): (WebInspector.CPUProfile.prototype.get head): (WebInspector.CPUProfile.prototype.createView): (WebInspector.CPUProfile.prototype.viewForProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType): (WebInspector.ProfileType.prototype.get buttonTooltip): (WebInspector.ProfileType.prototype.get buttonStyle): (WebInspector.ProfileType.prototype.get buttonCaption): (WebInspector.ProfileType.prototype.get id): (WebInspector.ProfileType.prototype.get name): (WebInspector.ProfileType.prototype.buttonClicked): (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.get statusBarItems.clickHandler): (WebInspector.ProfilesPanel.prototype.get statusBarItems): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.registerProfileType): (WebInspector.ProfilesPanel.prototype._makeKey): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile): (WebInspector.ProfilesPanel.prototype.getProfileType): (WebInspector.ProfilesPanel.prototype.showProfileForURL): (WebInspector.ProfilesPanel.prototype.updateProfileTypeButtons): (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink): (WebInspector.ProfilesPanel.prototype.get searchableViews): (WebInspector.ProfilesPanel.prototype._updateInterface):
- inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.addProfileHeader): (WebInspector.setRecordingProfile): (WebInspector.linkifyStringAsFragment): (WebInspector.showProfileForURL):
- 9:46 AM Changeset in webkit [49631] by
-
- 3 edits in trunk/LayoutTests
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: remove timer-related logs from the previously
submitted test.
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
- 9:21 AM Changeset in webkit [49630] by
-
- 2 edits in trunk/WebKitTools
wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
the OS if none was explicitly set.
- 9:16 AM Changeset in webkit [49629] by
-
- 11 edits in trunk
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Enable inspector layout tests.
WebCore:
- inspector/InspectorController.cpp: (WebCore::InspectorController::evaluateForTestInFrontend):
LayoutTests:
- inspector/elements-panel-structure-expected.txt:
- inspector/elements-panel-structure.html:
- inspector/evaluate-in-frontend.js: (evaluateInWebInspector): (window.didEvaluateForTestInFrontend):
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 8:31 AM Changeset in webkit [49628] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Xan Lopez <xlopez@igalia.com>
Skip new SVG tests without expected results for GTK+.
- platform/gtk/Skipped:
- 7:56 AM Changeset in webkit [49627] by
-
- 3 edits in trunk/WebKit/gtk
2009-10-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
page transition may crash webkit
https://bugs.webkit.org/show_bug.cgi?id=29890
There are actually cases in which a resource may be asked using
webkit_web_view_get_resource after a new load has already been
started, so protect ourselves from crashes in this case.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
- webkit/webkitwebview.cpp: (webkit_web_view_get_resource):
- 7:46 AM Changeset in webkit [49626] by
-
- 2 edits in trunk/WebCore
2009-10-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GStreamer] READY state doesn't mean "enough data"
https://bugs.webkit.org/show_bug.cgi?id=30003
STATE_READY means MediaPlayer::HaveNothing
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::updateStates):
- 7:35 AM Changeset in webkit [49625] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Xan Lopez <xlopez@igalia.com>
Skip a couple of tests that need support for dumpEditingCallbacks.
- platform/gtk/Skipped:
- 7:31 AM Changeset in webkit [49624] by
-
- 2 edits in trunk/WebCore
2009-10-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
implement cancelLoad
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::cancelLoad):
- 7:16 AM Changeset in webkit [49623] by
-
- 2 edits in trunk/WebCore
2009-10-15 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fix race condition, leading to a deadlock
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_render): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_unlock_stop): (webkit_video_sink_stop): (webkit_video_sink_start): (webkit_video_sink_class_init): Fix race condition in unlock/render that would lead to deadlocks.
- 6:25 AM Changeset in webkit [49622] by
-
- 2 edits in trunk/WebCore
2009-10-15 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Check if caps are valid before parsing them
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration): Check if caps are valid before parsing them in ::naturalSize(). This prevents assertions if the natural size should be calculated before the video caps are negotiated.
- 6:09 AM Changeset in webkit [49621] by
-
- 3 edits in trunk/WebCore
2009-10-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=30006
[GStreamer] Unnecessary checks for Messages types in callbacks
refactored gst message callbacks into a single one
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::duration):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 5:58 AM Changeset in webkit [49620] by
-
- 1 edit in trunk/WebCore/plugins/mac/PluginViewMac.cpp
Fix the Qt build on Mac OS X
- 5:49 AM Changeset in webkit [49619] by
-
- 5 edits1 add in trunk
2009-10-15 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Adele Peterson.
Change behavior so that <a> element is always mouse-focusable.
- fast/events/click-focus-anchor-expected.txt:
- fast/events/click-focus-anchor.html:
2009-10-15 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Adele Peterson.
Anchor elements should be mouse focusable regardless isLink flag.
https://bugs.webkit.org/show_bug.cgi?id=26856
- html/HTMLAnchorElement.cpp:
- html/HTMLAnchorElement.h:
- 5:41 AM Changeset in webkit [49618] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Make context menu to work in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30336
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::event):
- 5:32 AM Changeset in webkit [49617] by
-
- 2 edits in trunk/WebCore
Not reviewed. Sort XCode project file.
- 3:44 AM QtWebKitContrib edited by
- (diff)
- 3:41 AM QtWebKitContrib edited by
- (diff)
- 3:40 AM QtWebKitContrib edited by
- (diff)
- 3:35 AM BuildingQtOnLinux edited by
- merging install line into a single one and adding the required … (diff)
- 2:40 AM Changeset in webkit [49616] by
-
- 3 edits4 adds in trunk
2009-10-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dave Hyatt.
Return correct shorthand property name for
background-repeat-x, background-repeat-y, background-position-x,
background-position-y, -webkit-mask-position-x, -webkit-mask-position-y,
-webkit-mask-repeat-x, -webkit-mask-repeat-y.
Test: fast/backgrounds/repeat/background-repeat-shorthand.html
WebCore
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
LayoutTests:
- fast/backgrounds/repeat/background-repeat-shorthand-expected.txt: Added.
- fast/backgrounds/repeat/background-repeat-shorthand.html: Added.
- fast/backgrounds/repeat/resources/background-repeat-shorthand.css: Added.
- fast/backgrounds/repeat/resources/background-repeat-shorthand.js: Added. (getShorthand):
- 2:31 AM Changeset in webkit [49615] by
-
- 14 edits in trunk/WebCore
2009-10-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Migrate profiles to the injected script-based schema.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 2:15 AM Changeset in webkit [49614] by
-
- 2 edits in trunk/WebCore
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Create and update frontend script objects only when
web inspector is visible.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::evaluateForTestInFrontend):
- 1:56 AM Changeset in webkit [49613] by
-
- 3 edits in trunk/WebKitTools
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: enable developers extras within inspector layout tests.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
- 12:35 AM Changeset in webkit [49612] by
-
- 2 edits in trunk/WebKitTools
2009-10-14 José Millán Soto <jmillan@igalia.com>
Reviewed by Jan Alonzo.
GtkLauncher is using a deprecated signal
https://bugs.webkit.org/show_bug.cgi?id=30364
Modified GtkLauncher to use notify::title signal instead of
deprecated title-changed signal
- GtkLauncher/main.c: (notify_title_cb): (create_browser):
- 12:10 AM Changeset in webkit [49611] by
-
- 2 edits in trunk/WebCore
2009-10-15 Joseph Pecoraro <Joseph Pecoraro>
Fix Windows build.
- dom/Document.idl:
Oct 14, 2009:
- 11:41 PM Changeset in webkit [49610] by
-
- 3 edits3 adds in trunk
2009-10-14 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Adam Barth.
[HTML5] Add document.head
https://bugs.webkit.org/show_bug.cgi?id=30232
Test is fast/dom/document-head.html
- dom/Document.idl: added readonly attribute head
- 11:12 PM Changeset in webkit [49609] by
-
- 2 edits in trunk/WebCore
2009-10-14 Matt Mueller <mattm@chromium.org>
Reviewed by Darin Adler.
Check FNonNeg after the unit switch to avoid valgrind uninitialised conditional reference in WebCore::CSSParser::validUnit. See http://crbug.com/20939.
https://bugs.webkit.org/show_bug.cgi?id=30347
https://bugs.webkit.org/show_bug.cgi?id=22772
Covered by running LayoutTests/fast/css/invalid-percentage-property.html under valgrind.
- css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
- 10:15 PM Changeset in webkit [49608] by
-
- 6 edits in trunk/WebCore
2009-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Move scrolling code from FrameLoader to FrameView
https://bugs.webkit.org/show_bug.cgi?id=30370
This code is about controlling the Frame's view, not about loading
stuff into the frame.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::scrollToAnchor):
- page/FrameView.cpp: (WebCore::FrameView::scrollToFragment): (WebCore::FrameView::scrollToAnchor):
- page/FrameView.h:
- 8:24 PM Changeset in webkit [49607] by
-
- 44 edits in trunk
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Geoff Garen.
Part 1. Reverse the HasStandardGetOwnPropertySlot flag.
- 7:39 PM Changeset in webkit [49606] by
-
- 2 edits in trunk/WebKitSite
2009-10-14 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
Document what state the build tree is expected to be in after a patch.
- coding/contributing.html:
- 7:14 PM Changeset in webkit [49605] by
-
- 3 edits4 adds in trunk
2009-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
[XSSAuditor] Add an exception for local files
https://bugs.webkit.org/show_bug.cgi?id=30352
Test that we allow sites to load scripts from their own domain as long
as they don't use query strings.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host.html: Added.
2009-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
[XSSAuditor] Add an exception for local files
https://bugs.webkit.org/show_bug.cgi?id=30352
Reduce XSS auditor false positives by always letting pages load scripts
from their own host. We don't actually know of any false positives
that this prevents, but it seems like a good idea.
One subtly is that we don't add this exception for scripts that have a
query string because (1) URLs with query strings are more apt to
confuse servers and (2) it is much less common to load scripts with a
query string.
Tests: http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html
http/tests/security/xssAuditor/script-tag-with-source-same-host.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
- 5:33 PM Changeset in webkit [49604] by
-
- 2 edits in trunk/WebKit/mac
Unbreak the world.
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::restart):
- 5:14 PM Changeset in webkit [49603] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson and Jon Honeycutt
<rdar://problem/7304295> snapshots of halted plug-ins are missing
- Plugins/WebBaseNetscapePluginView.mm: Move bodies of WebHaltablePlugin virtual functions from WebHaltablePlugin class definition. (WebHaltablePlugin::halt): Provide a substitute image to the RenderWidget for the plug-in view. (WebHaltablePlugin::restart): Clear the substitute image.
- 4:54 PM Changeset in webkit [49602] by
-
- 48 edits in trunk/WebCore
2009-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by George Staikos.
Kill virtual contextElement() method spread all over SVG code
https://bugs.webkit.org/show_bug.cgi?id=30183
Remove virtual contextElement() function from all SVG*Element classes, as all animated properties live in the
SVG*Element classes now instead of the SVGFitToViewBox / SVGURIReference / SVGExternalResourcesRequired
subclasses. This is a first step to working animVal support. More patches will follow that depend on this change.
Remove "This file is part of the KDE project" from several files, change my old mail adress wildfox -> zimmermann,
and remove vim modelines on all files I touched. No change in functionality, thus no new tests.
- svg/SVGAElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGAltGlyphElement.h: Remove virtual contextElement() method.
- svg/SVGAnimatedProperty.h: (WebCore::::synchronize): (WebCore::::startAnimation): (WebCore::::stopAnimation):
- svg/SVGAnimationElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGCircleElement.h: Ditto.
- svg/SVGClipPathElement.h: Ditto.
- svg/SVGCursorElement.h: Ditto.
- svg/SVGDefsElement.h: Ditto.
- svg/SVGEllipseElement.h: Ditto.
- svg/SVGExternalResourcesRequired.h: Remove pure-virtual contextElement() method.
- svg/SVGFEImageElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGFELightElement.h: Remove virtual contextElement() method.
- svg/SVGFEMergeNodeElement.h: Ditto.
- svg/SVGFilterElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGFilterPrimitiveStandardAttributes.h: Remove virtual contextElement() method.
- svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox): Add Document* parameter - we used to fetch the Document pointer from the context element. (WebCore::SVGFitToViewBox::parseMappedAttribute): Ditto.
- svg/SVGFitToViewBox.h: Remove pure-virtual contextElement() method.
- svg/SVGFontElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGForeignObjectElement.h: Ditto.
- svg/SVGGElement.h: Ditto.
- svg/SVGGradientElement.h: Ditto.
- svg/SVGImageElement.h: Ditto.
- svg/SVGLineElement.h: Ditto.
- svg/SVGMPathElement.h: Ditto. Fix license indention.
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGMarkerElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGMaskElement.h: Ditto.
- svg/SVGPathElement.h: Ditto.
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGPatternElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::updateAnimatedSVGAttribute): synchronizeProperty<...>() has been renamed to PropertySynchronizer<...>::synchronize().
- svg/SVGPolyElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGRectElement.h: Ditto.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGSVGElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGScriptElement.h: Ditto.
- svg/SVGSwitchElement.h: Ditto.
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGSymbolElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGTRefElement.h: Remove virtual contextElement() method.
- svg/SVGTextContentElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGTextPathElement.h: Remove virtual contextElement() method.
- svg/SVGUseElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGViewElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::setViewBoxString): Pass document() to SVGFitToViewBox::parseMappedAttribute(). (WebCore::SVGViewSpec::parseViewSpec): Ditto.
- svg/SVGViewSpec.h: Devirtualize contextElement() method, it's the only place where contextElement() remains needed.
- 4:48 PM Changeset in webkit [49601] by
-
- 1 edit1 delete in trunk/LayoutTests
Fix a failure seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994
Patch by Darin Adler <Darin Adler> on 2009-10-14
- platform/win/fast/css/large-number-round-trip-expected.txt: Removed.
- 4:29 PM Changeset in webkit [49600] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:27 PM Changeset in webkit [49599] by
-
- 1 copy in tags/Safari-6531.21
New tag.
- 4:21 PM Changeset in webkit [49598] by
-
- 3 edits4 adds in trunk
2009-10-14 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Masking with wrong offset
https://bugs.webkit.org/show_bug.cgi?id=30325
SVGMaskElement moves the mask image graphics context to the wrong location.
In objectBoundingBoxMode the maskDestRect gets translated. This transformation
is not used in the later calculation. Fix by consistenly calculating the translation
offsets from the final mask destination rect.
Test: svg/custom/mask-with-default-value.svg
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
2009-10-14 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Masking with wrong offset
https://bugs.webkit.org/show_bug.cgi?id=30325
SVGMaskElement moves the mask image graphics context to the wrong location.
In objectBoundingBoxMode the maskDestRect gets translated. This transformation
is not used in the later calculation. Fix by consistenly calculating the translation
offsets from the final mask destination rect.
Test: svg/custom/mask-with-default-value.svg
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- 4:14 PM Changeset in webkit [49597] by
-
- 3 edits in trunk/WebCore
Rubberstamped by Jon Honeycutt.
Export a few more showSubstituteImage() related methods.
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- 4:11 PM Changeset in webkit [49596] by
-
- 1 edit2 deletes in trunk/LayoutTests
Fix failures seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994
Patch by Darin Adler <Darin Adler> on 2009-10-14
Reviewed by Mark Rowe.
Somehow I had the mac/fast/css/opacity-float-expected.txt
removed locally, and Subversion didn't check that in!
- platform/mac/fast/css/opacity-float-expected.txt: Removed.
- platform/win/fast/css/opacity-float-expected.txt: Removed.
- 4:04 PM Changeset in webkit [49595] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:00 PM Changeset in webkit [49594] by
-
- 2 edits in trunk/LayoutTests
Disable plugins/private-browsing-mode.html on Snow Leopard.
Reviewed by Sam Weinig.
- platform/mac-snowleopard/Skipped:
- 3:42 PM Changeset in webkit [49593] by
-
- 4 edits in branches/safari-4-branch/JavaScriptCore
Merge r47620.
- 3:38 PM Changeset in webkit [49592] by
-
- 11 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=30269
Use onload to detect iframe load, rather than setTimeout.
This will give more consistent test results and hopefully faster run times.
Patch by Julie Parent <jparent@chromium.org> on 2009-10-13
Reviewed by Darin Adler.
- editing/execCommand/paste-1.html:
- editing/execCommand/paste-2.html:
- editing/pasteboard/subframe-dragndrop-1.html:
- editing/selection/4776665.html:
- editing/selection/4975120.html:
- editing/selection/5136696.html:
- editing/selection/drag-to-contenteditable-iframe.html:
- platform/mac/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
- platform/qt/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
- platform/win/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
- 2:46 PM Changeset in webkit [49591] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48531.
- 2:46 PM Changeset in webkit [49590] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48529.
- 2:46 PM Changeset in webkit [49589] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r48446.
- 2:46 PM Changeset in webkit [49588] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48396.
- 2:46 PM Changeset in webkit [49587] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r48375.
- 2:46 PM Changeset in webkit [49586] by
-
- 10 edits in branches/safari-4-branch/WebCore
Merge r48370.
- 2:45 PM Changeset in webkit [49585] by
-
- 10 edits in trunk
JavaScriptCore: Additions so fix for https://bugs.webkit.org/show_bug.cgi?id=18994
can build on Windows.
Patch by Darin Adler <Darin Adler> on 2009-10-14
- wtf/MathExtras.h: Added llround and llroundf for Windows.
WebCore: Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.
Patch by Evan Martin <evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=18994
- css/CSSPrimitiveValue.cpp:
(WebCore::appendCSSDouble):
(WebCore::formatWithUnits):
(WebCore::CSSPrimitiveValue::cssText):
LayoutTests: Float formatting changes affect three tests:
- large-number-round-trip now passes
- opacity-float now passes and has more test cases
- compound-2d-transforms output tweaked slightly
Patch by Evan Martin <evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=18994
- fast/css/large-number-round-trip-expected.txt:
- fast/css/opacity-float-expected.txt:
- fast/css/opacity-float.html:
- platform/mac/fast/css/opacity-float-expected.txt: Removed.
- transforms/2d/compound-2d-transforms-expected.txt:
- transforms/2d/compound-2d-transforms.html:
- 2:41 PM Changeset in webkit [49584] by
-
- 2 edits in trunk/WebCore
2009-10-14 Mark Seaborn <mseaborn@google.com>
Reviewed by Darin Adler.
Check error return value in Perl build script
https://bugs.webkit.org/show_bug.cgi?id=30316
- css/makevalues.pl: Die if gperf fails.
- 1:39 PM Changeset in webkit [49583] by
-
- 2 edits in trunk/JavaScriptCore
Roll out r49580 as it is completely wrong and breaks the Mac builds.
- 1:30 PM Changeset in webkit [49582] by
-
- 12 edits4 adds in trunk
2009-10-14 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG wrong filterRegions for userSpaceOnUse and percentage values
https://bugs.webkit.org/show_bug.cgi?id=30330
Some clean-up of the SVG filter calculation code. This clean-up
also fixes the problem with percentage and userSpaceInUse mode.
Test: svg/filters/subRegion-in-userSpace.svg
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
- platform/graphics/filters/FilterEffect.h:
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::buildFilter): (WebCore::SVGFilterElement::canvasResource):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::addFilterEffect): (WebCore::SVGResourceFilter::prepareFilter):
- svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::create):
- svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::calculateEffectSubRegion): (WebCore::SVGFilter::create):
- svg/graphics/filters/SVGFilter.h:
Reviewed by Nikolas Zimmermann.
Check if the percentage of effect values takes user space as reference and
not the FilterRect.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.png: Added.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.txt: Added.
- svg/filters/subRegion-in-userSpace.svg: Added.
- 12:32 PM Changeset in webkit [49581] by
-
- 4 edits in trunk
WebKitTools: Don't set the history delegate on new windows that are opened during a test, as the history delegate:
1 - Disables WebHistory
2 - Doesn't make sense in that context anyway.
Reviewed by Sam Weinig.
- DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):
LayoutTests: Un-skip a test that now passes.
Reviewed by Sam Weinig.
- platform/win/Skipped:
- 12:01 PM Changeset in webkit [49580] by
-
- 2 edits in trunk/JavaScriptCore
Mac build fix, use MIN_REQUIRED rather than MAX_ALLOWED to determine
compilation of code that requires 10.6.
- 11:51 AM Changeset in webkit [49579] by
-
- 3 edits in trunk/WebKitTools
wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
- 11:41 AM Changeset in webkit [49578] by
-
- 2 edits in trunk/WebCore
The last change fixed the problem, removing diagnostic printfs.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 11:34 AM BuildingOnWindows edited by
- Add (non-ideal) workaround for Visual Studio 2005 missing Crypt32.lib error (diff)
- 11:31 AM Changeset in webkit [49577] by
-
- 3 edits in trunk/WebCore
CURL build fix for versions < 7.18.
- 11:30 AM Changeset in webkit [49576] by
-
- 1 edit1 add in trunk/LayoutTests
2009-10-14 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
When I landed r49569 for Victor, I failed to svn add one of the required files.
This should fix the redness on the Windows test bots.
- platform/win/editing/pasteboard/paste-xml-expected.txt: Added.
- 11:18 AM Changeset in webkit [49575] by
-
- 2 edits in trunk/WebCore
One more round of changes to figure out why the webgl
tests are crashing on the build bot. Here I am trying
to see if we can create a software renderer. I am also
printing the found pixel formats.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 10:42 AM Changeset in webkit [49574] by
-
- 8 edits7 adds in trunk/WebCore
Enabling NPAPI plugin support on Qt Webkit for S60 platform
https://bugs.webkit.org/show_bug.cgi?id=29302
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-14
Reviewed by
Also implemented by Mahesh Kulkarni<mahesh.kulkarni@nokia.com>,
Rohini Ananth <rohini.ananth@nokia.com> and help from Norbert Lesr
<norbert.leser@nokia.com>
- 10:34 AM Changeset in webkit [49573] by
-
- 8 edits in trunk/LayoutTests
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: skip inspector tests that were recently added
until harness is fixed in release mode.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 10:29 AM Changeset in webkit [49572] by
-
- 2 edits in trunk/LayoutTests
Skip my two new failures while I'm actively looking at them.
- platform/win/Skipped:
- 10:18 AM Changeset in webkit [49571] by
-
- 2 edits in trunk/WebCore
More changes to figure out why the webgl tests are crashing on the build bot.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 10:11 AM Changeset in webkit [49570] by
-
- 2 edits in trunk/JavaScriptCore
wx build fix. Set ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for plugins while we're still building stubs.
- 10:02 AM Changeset in webkit [49569] by
-
- 2 edits in trunk/LayoutTests
2009-10-14 Victor Wang <victorw@chromium.org>
Reviewed by Darin Adler.
Add paste-xml test back for Win.
The result difference between Mac and Win is due to the
platform dependent implementation. The diff is expected
with current implementation.
See bug for more deails:
- platform/win/Skipped:
- platform/win/editing/pasteboard/paste-xml-expected.txt: Added.
- 9:39 AM Changeset in webkit [49568] by
-
- 1 edit7 adds in trunk/LayoutTests
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add initial layout tests for web inspector.
- inspector/console-tests-expected.txt: Added.
- inspector/console-tests.html: Added.
- inspector/elements-panel-structure-expected.txt: Added.
- inspector/elements-panel-structure.html: Added.
- inspector/evaluate-in-frontend-expected.txt: Added.
- inspector/evaluate-in-frontend.html: Added.
- inspector/evaluate-in-frontend.js: Added.
- 9:26 AM Changeset in webkit [49567] by
-
- 16 edits2 adds in trunk
2009-10-14 Victor Wang <victorw@chromium.org>
Reviewed by David Hyatt.
Round non-integer line height values.
Change webkit to rounding non-integer line height values
instead of truncating them. This fixes a layout test
failure on Windows and matches the calculation in IE and Firefox.
- 9:23 AM Changeset in webkit [49566] by
-
- 2 edits in trunk/WebKit/win
Windows build fix
- WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and
IWebNavigationData from the build (they get #imported via WebKit.idl).
- 9:21 AM Changeset in webkit [49565] by
-
- 9 edits in trunk/WebCore
2009-10-13 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Removes the persistent setting for InspectorTimelineAgent and renames timeline related
interfaces to be more consistent with the JavaScript profiler.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::startTimelineProfiler): (WebCore::InspectorBackend::stopTimelineProfiler): (WebCore::InspectorBackend::timelineProfilerEnabled):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::timelineProfilerEnabled):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::timelineProfilerWasStarted): (WebCore::InspectorFrontend::timelineProfilerWasStopped):
- inspector/InspectorFrontend.h:
- inspector/front-end/TimelineAgent.js: (WebInspector.timelineProfilerWasStarted): (WebInspector.timelineProfilerWasStopped):
- 9:03 AM Changeset in webkit [49564] by
-
- 20 edits6 adds in trunk
WebKit Win API should provide a delegate interface for global history.
https://bugs.webkit.org/show_bug.cgi?id=29905
Reviewed by Sam Weinig.
WebKit/win:
-Add IWebHistoryDelegate for clients to implement.
-Add (I)WebNavigationData for the history delegate's use.
-When it exists, call the history delegate instead of using WebHistory.
- Interfaces/IWebHistoryDelegate.idl: Added.
- Interfaces/IWebHistoryPrivate.idl:
- Interfaces/IWebNavigationData.idl: Added.
- Interfaces/IWebViewPrivate.idl:
- Interfaces/WebKit.idl:
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks):
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory):
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebFrameLoaderClient::setTitle):
- WebView.cpp:
(WebView::close):
(WebView::mainFrameURL):
(WebView::setHistoryDelegate):
(WebView::historyDelegate):
(WebView::addVisitedLinks):
- WebView.h:
- WebHistory.cpp:
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
- WebHistory.h:
- WebNavigationData.cpp: Added.
(WebNavigationData::QueryInterface):
(WebNavigationData::AddRef):
(WebNavigationData::Release):
(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):
(WebNavigationData::createInstance):
(WebNavigationData::url):
(WebNavigationData::title):
(WebNavigationData::originalRequest):
(WebNavigationData::response):
(WebNavigationData::hasSubstituteData):
(WebNavigationData::clientRedirectSource):
- WebNavigationData.h: Added.
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpHistoryDelegateCallbacks):
(LayoutTestController::setDumpHistoryDelegateCallbacks):
- DumpRenderTree/win/DumpRenderTree.cpp:
(shouldLogHistoryDelegates):
(runTest):
(createWebViewAndOffscreenWindow):
(main):
- DumpRenderTree/win/DumpRenderTree.vcproj:
Add the IWebHistoryDelegate to DRT Windows:
- DumpRenderTree/win/HistoryDelegate.cpp: Added.
(wstringFromBSTR):
(HistoryDelegate::HistoryDelegate):
(HistoryDelegate::~HistoryDelegate):
(HistoryDelegate::QueryInterface):
(HistoryDelegate::AddRef):
(HistoryDelegate::Release):
(HistoryDelegate::didNavigateWithNavigationData):
(HistoryDelegate::didPerformClientRedirectFromURL):
(HistoryDelegate::didPerformServerRedirectFromURL):
(HistoryDelegate::updateHistoryTitle):
(HistoryDelegate::populateVisitedLinksForWebView):
- DumpRenderTree/win/HistoryDelegate.h: Added.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::removeAllVisitedLinks):
LayoutTests:
- platform/win/Skipped: Enable globalhistory tests.
- 9:02 AM Changeset in webkit [49563] by
-
- 4 edits in trunk/WebKitTools
2009-10-14 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Implement support for setPOSIXLocale on Qt.
https://bugs.webkit.org/show_bug.cgi?id=30268
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setPOSIXLocale):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 8:48 AM Changeset in webkit [49562] by
-
- 3 edits3 adds in trunk
2009-10-02 Yong Li <yong.li@torchmobile.com>
Reviewed by Adele Peterson.
Fixed crash when loading invalid image data.
Also added a test case that loads an invalid image to make sure
we don't crash in this situation.
https://bugs.webkit.org/show_bug.cgi?id=29980
WebCore:
- rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText):
LayoutTests:
- fast/images/image-invalid-data-expected.txt: Added.
- fast/images/image-invalid-data.html: Added.
- fast/images/resources/invalid.jpg: Added.
- 8:40 AM QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 8:30 AM QtBackLog edited by
- (diff)
- 8:02 AM Changeset in webkit [49561] by
-
- 3 edits2 adds in trunk
WebCore: Fix for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254
Reviewed by Eric Seidel.
Test: fast/canvas/canvas-toDataURL-crash.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL):
LayoutTests: New test for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254
Reviewed by Eric Seidel.
- fast/canvas/canvas-toDataURL-crash-expected.txt: Added.
- fast/canvas/canvas-toDataURL-crash.html: Added.
- 7:54 AM Changeset in webkit [49560] by
-
- 14 edits in trunk/WebCore
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, reverting r49558 since it broke profiler tests.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 7:10 AM Changeset in webkit [49559] by
-
- 3 edits in trunk/WebCore
ImageDecoderQt: Minor tweaks to the decoder
- Only cache the data when we start to use it.
- Start with a repetition count of none for normal images.
- Do not use canRead as this will trigger parsing of the full image
- Cope with a GIF failing to decode the first frame, do not set m_failed to true if decoding the first frame failed
- Inform the QImageReader about the format that was detected
- Always create a ImageDecoderQt when when we have more than four byte.
- 6:32 AM Changeset in webkit [49558] by
-
- 14 edits in trunk/WebCore
2009-10-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Migrate profiles to the injected script-based schema.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 2:14 AM Changeset in webkit [49557] by
-
- 4 edits in trunk/WebCore
2009-10-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Don't collect call frame properties until they're needed for completion.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
- inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): if call frame id is specified and the expression is empty collect frame properties. (InjectedScript.CallFrameProxy.prototype._wrapScopeChain): don't send call frame properties until they're needed.
- inspector/front-end/ScriptsPanel.js:
Oct 13, 2009:
- 10:14 PM Changeset in webkit [49556] by
-
- 2 edits in trunk/WebCore
2009-10-13 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=29106
[Qt] make CachedResourceHandle.h compile in winscw Symbian compiler.
Don't inline constructor CachedResourceHandle<T>(R*) to stop winscw
compiler aggressively resolve inheritance of class R.
The winscw compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.
The change should be reverted when the above bug is fixed in winscw compiler.
- loader/CachedResourceHandle.h: (WebCore::::CachedResourceHandle):
- 9:43 PM Changeset in webkit [49555] by
-
- 8 edits1 copy in trunk
2009-10-13 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r49554, because it broke Win and Chromium builds.
http://trac.webkit.org/changeset/49554
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
- 9:09 PM Changeset in webkit [49554] by
-
- 8 edits1 delete in trunk
2009-10-13 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Float formatting changes affect three tests:
- large-number-round-trip now passes
- opacity-float now passes and has more test cases
- compound-2d-transforms output tweaked slightly
- fast/css/large-number-round-trip-expected.txt:
- fast/css/opacity-float-expected.txt:
- fast/css/opacity-float.html:
- platform/mac/fast/css/opacity-float-expected.txt: Removed.
- transforms/2d/compound-2d-transforms-expected.txt:
- transforms/2d/compound-2d-transforms.html:
2009-10-13 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.
- css/CSSPrimitiveValue.cpp: (WebCore::appendCSSDouble): (WebCore::formatWithUnits): (WebCore::CSSPrimitiveValue::cssText):
- 8:52 PM Changeset in webkit [49553] by
-
- 2 edits in trunk/WebCore
2009-10-13 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
Make grippy lines vertical on horizontal scrollbars in Linux Chrome.
While we're rebaselining scrollbars, fix an off by one in the vertical
scrollbar rendering too.
Tests: this is covered by every pixel test involving scrollbars.
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
- 8:37 PM Changeset in webkit [49552] by
-
- 3 edits in trunk/LayoutTests
2009-10-13 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
[LayoutTests][Gtk] Set a common Gtk theme as default and update the results
https://bugs.webkit.org/show_bug.cgi?id=30223
Update test results to reflect the usage of the default theme.
- platform/gtk/editing/selection/iframe-expected.txt:
- platform/gtk/editing/selection/select-box-expected.txt:
- 8:16 PM Changeset in webkit [49551] by
-
- 3 edits2 adds in trunk
WebCore: Fix issue where clientX and clientY on MouseEvents were wrong when
the page was zoomed and scrolled.
Reviewed by David Hyatt.
Test: fast/events/clientXY-in-zoom-and-scroll.html
- dom/MouseRelatedEvent.cpp:
(WebCore::contentsX): Take page zoom into account.
(WebCore::contentsY): Ditto.
LayoutTests: Test issue where clientX and clientY on MouseEvents were wrong when
the page was zoomed and scrolled.
Reviewed by David Hyatt.
- fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
- fast/events/clientXY-in-zoom-and-scroll.html: Added.
- 7:42 PM Changeset in webkit [49550] by
-
- 2 edits in trunk/WebKit/win
Fix more WebView bustage.
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
- 7:22 PM Changeset in webkit [49549] by
-
- 2 edits in branches/safari-4-branch/WebKit/win
Merge r48770.
- 7:22 PM Changeset in webkit [49548] by
-
- 2 edits in branches/safari-4-branch/WebKit/mac
Merge r48689.
- 7:22 PM Changeset in webkit [49547] by
-
- 2 edits in trunk/WebKit/win
Fix build bustage on Windows.
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
- 7:03 PM Changeset in webkit [49546] by
-
- 2 edits in branches/safari-4-branch/WebKit/win
Merge r48324.
- 7:03 PM Changeset in webkit [49545] by
-
- 10 edits in branches/safari-4-branch
Merge r48308.
- 6:54 PM Changeset in webkit [49544] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, adding myself to reviewers list.
- Scripts/modules/committers.py:
- 6:52 PM Changeset in webkit [49543] by
-
- 2 edits in trunk/WebKitTools
Fix null assignment so root tests work again.
Reviewed by Mark Rowe.
- Scripts/webkitdirs.pm:
- 6:38 PM Changeset in webkit [49542] by
-
- 1 edit in trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
Fix DumpRenderTree to account for API changes in the user script stuff.
- 6:37 PM Changeset in webkit [49541] by
-
- 11 edits in trunk
WebCore: Change the order of arguments on some of the user stylesheet/script functions. Split the removal functions
out into separate ones for scripts and stylesheets.
Reviewed by Adam Roben.
- WebCore.base.exp:
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
- page/PageGroup.h:
(WebCore::PageGroup::userScripts):
(WebCore::PageGroup::userStyleSheets):
WebKit/mac: Change the order of arguments on some methods. Split removal for user stylesheets and script into
separate functions based off the type of object being removed.
Reviewed by Adam Roben.
- WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:worldID:source:url:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:worldID:source:url:whitelist:blacklist:]):
(+[WebView _removeUserScriptFromGroup:worldID:url:]):
(+[WebView _removeUserStyleSheetFromGroup:worldID:url:]):
(+[WebView _removeUserScriptsFromGroup:worldID:]):
(+[WebView _removeUserStyleSheetsFromGroup:worldID:]):
- WebView/WebViewPrivate.h:
WebKit/win: Split removal functions for user scripts and stylehseets based on type.
Reviewed by Adam Roben..
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
- WebView.h:
- 6:16 PM Changeset in webkit [49540] by
-
- 2 edits in trunk/WebCore
Chrome's "Skia" theme paints select controls backwards in RTL.
Patch by Evan Martin <evan@chromium.org> on 2009-10-13
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=30320
Test: fast/text/international/bidi-menulist.html
(The test is about something else, but it includes RTL selects.)
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMenuList): flip the arrow position in RTL case.
- 6:15 PM Changeset in webkit [49539] by
-
- 12 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=30318
ScriptExecutionContext is not anymore needed to create an EventListener - remove old code.
It's a followup to r48884. It removed the need to pass the ScritpExecutionContext
into EventListener constructor but did not remove the code pulling ScriptExecutionContext.
Reviewed by Alexey Proskuryakov.
WebCore:
Tests:
Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.
- fast/events/add-event-without-document-expected.txt: Added.
- fast/events/add-event-without-document.html: Added.
All changes in files below are the same - remove the code that calls
EventTarget::scriptExecutionContext and checks it for NULL.
- bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
- bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::):
- bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
LayoutTests:
Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.
- fast/events/add-event-without-document-expected.txt: Added.
- fast/events/add-event-without-document.html: Added.
- 6:04 PM Changeset in webkit [49538] by
-
- 4 edits in branches/safari-4-branch/JavaScriptCore
Merge r48733.
- 6:04 PM Changeset in webkit [49537] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46725.
- 6:04 PM Changeset in webkit [49536] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46724.
- 6:04 PM Changeset in webkit [49535] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge r46648.
- 6:04 PM Changeset in webkit [49534] by
-
- 4 edits in branches/safari-4-branch/JavaScriptCore
Merge r46511.
- 6:04 PM Changeset in webkit [49533] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46387.
- 5:41 PM Changeset in webkit [49532] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Jon Honeycutt.
Add trailing newline to the Windows Skipped List.
- platform/win/Skipped:
- 5:36 PM Changeset in webkit [49531] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Add bug number to previous ChangeLog entry.
- 5:34 PM Changeset in webkit [49530] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Anders Carlsson.
Add plugins/private-browsing-mode.html to the Windows Skipped
list because the feature is not implemented on Windows.
- platform/win/Skipped:
- 5:33 PM Changeset in webkit [49529] by
-
- 4 edits3 adds in branches/safari-4-branch
Merge r48590.
- 5:24 PM Changeset in webkit [49528] by
-
- 24 edits in branches/safari-4-branch
Merge r46645.
- 4:58 PM Changeset in webkit [49527] by
-
- 2 edits in trunk/WebCore
2009-10-13 Simon Fraser <Simon Fraser>
Temporary debugging changes to figure out why the webgl tests are crashing on the build bot.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 4:39 PM Changeset in webkit [49526] by
-
- 13 edits in trunk
Enable SHARED_WORKERS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=30289
Patch by Drew Wilson <atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by David Levin.
WebCore:
Cleaned up bitrot in SharedWorker V8 bindings.
- WebCore.gypi:
Removed default implementation of SharedWorkerRepository so Chromium can provide its own.
- bindings/v8/DerivedSourcesAllInOne.cpp:
Added V8SharedWorkerContext.cpp.
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getTemplate):
Added case statements for SHAREDWORKER and SHAREDWORKERCONTEXT.
- bindings/v8/V8Index.cpp:
Now includes V8SharedWorkerContext.h to allow supporting SharedWorkers.
- bindings/v8/V8Index.h:
Added definition for SHAREDWORKERCONTEXT wrapper.
- bindings/v8/WorkerContextExecutionProxy.cpp:
Added includes for SharedWorker.h and SharedWorkerContext.h.
- bindings/v8/custom/V8CustomBinding.h:
Reorganized Worker field indexes to be clearer, and fixed mismatch in worker field index.
Also added field indexes for SharedWorkers.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
Added runtime enabler for the SharedWorker constructor.
- bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
Cleaned up bitrot (various APIs have changed since this file was written).
- page/DOMWindow.idl:
Added EnabledAtRuntime flag to window.SharedWorker.
WebKit:
- chromium/features.gypi:
Turned on ENABLE_SHARED_WORKERS by default. This doesn't actually turn on
SharedWorkers yet, as Chromium overrides this flag in its feature_overrides.gypi.
- 4:36 PM Changeset in webkit [49525] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=30345
HTTP tests for credential handling fail on Tiger
We cannot prevent NSURLConnection from doing its credentil handling on Tiger anyway; so
let it do its work without intervention. Once again, we pass explicitly passed credentials
in URL, fixing regressions from Safari 3.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential):
- 4:19 PM Changeset in webkit [49524] by
-
- 2 edits in trunk/WebCore
2009-10-13 Roland Steiner <rolandsteiner@google.com>
Reviewed by Adam Barth.
Bug 28964 - [Chromium] ChromiumDataObject should have getter/setter interface
Reworked and added to the getter/setter interface in ChromiumDataObject:
- added contains...() methods to just query the state
- added containsValid...URL() methods for URL data members
- removed takeFileNames() as this was too type-dependent
- changed return type of fileNames() to Vector<String>
- added interface methods to allow appending to and iteration over file names
No new tests (no functional behavior changed).
- platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::containsMainURL): (WebCore::ChromiumDataObject::containsValidMainURL): (WebCore::ChromiumDataObject::containsMainURLTitle): (WebCore::ChromiumDataObject::containsTextPlain): (WebCore::ChromiumDataObject::containsTextHTML): (WebCore::ChromiumDataObject::containsHTMLBaseURL): (WebCore::ChromiumDataObject::containsValidHTMLBaseURL): (WebCore::ChromiumDataObject::containsContent): (WebCore::ChromiumDataObject::containsContentFileExtension): (WebCore::ChromiumDataObject::containsContentFileName): (WebCore::ChromiumDataObject::setContentFileName): (WebCore::ChromiumDataObject::containsFileNames): (WebCore::ChromiumDataObject::fileNames): (WebCore::ChromiumDataObject::clearFileNames): (WebCore::ChromiumDataObject::countFileNames): (WebCore::ChromiumDataObject::fileNameAt): (WebCore::ChromiumDataObject::setFileNames): (WebCore::ChromiumDataObject::appendToFileNames): (WebCore::ChromiumDataObject::popFileName):
- 4:05 PM Changeset in webkit [49523] by
-
- 7 edits in branches/safari-4-branch
Merge r49111.
- 4:03 PM Changeset in webkit [49522] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r47534.
- 3:57 PM Changeset in webkit [49521] by
-
- 5 edits in branches/safari-4-branch/WebKit/mac
Merge r49133.
- 3:53 PM Changeset in webkit [49520] by
-
- 4 edits4 adds in trunk
2009-10-13 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Visibility:visible inside a compositing layer doesn't make the element visible
https://bugs.webkit.org/show_bug.cgi?id=30339
When deciding if a layer had any renderable content, RenderLayerBacking::paintIntoLayer()
only consulted hasVisibleContent(), which does not take into a account child layers which
may be visible. We also have to consult hasVisibleDescendant() as well.
Test: compositing/compositing-visible-descendant.html
- rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleDescendant):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
- 3:51 PM Changeset in webkit [49519] by
-
- 8 edits4 copies3 adds in trunk/WebKitTools
2009-10-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
This is done in preparation of implementing missing features in DRT.
No functionality changes made yet.
- DumpRenderTree/qt/DumpRenderTree.cpp:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/EventSenderQt.cpp: Added. (EventSender::EventSender): (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::leapForward): (EventSender::keyDown): (EventSender::contextClick): (EventSender::scheduleAsynchronousClick): (EventSender::frameUnderMouse):
- DumpRenderTree/qt/EventSenderQt.h: Added. (EventSender::clearKillRing):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added. (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): (LayoutTestController::windowCount): (LayoutTestController::clearBackForwardList): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript): (LayoutTestController::provisionalLoad): (LayoutTestController::timerEvent): (LayoutTestController::encodeHostName): (LayoutTestController::decodeHostName): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setFixedContentsSize): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::disableImageLoading): (LayoutTestController::dispatchPendingLoadRequests): (LayoutTestController::setDatabaseQuota): (LayoutTestController::clearAllDatabases): (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::waitForPolicyDelegate): (LayoutTestController::overridePreference):
- DumpRenderTree/qt/LayoutTestControllerQt.h: Added. (LayoutTestController::isLoading): (LayoutTestController::setLoading): (LayoutTestController::shouldDumpAsText): (LayoutTestController::shouldDumpBackForwardList): (LayoutTestController::shouldDumpChildrenAsText): (LayoutTestController::shouldDumpDatabaseCallbacks): (LayoutTestController::shouldDumpStatusCallbacks): (LayoutTestController::shouldWaitUntilDone): (LayoutTestController::canOpenWindows): (LayoutTestController::shouldDumpTitleChanges): (LayoutTestController::waitForPolicy): (LayoutTestController::dumpAsText): (LayoutTestController::dumpChildFramesAsText): (LayoutTestController::dumpDatabaseCallbacks): (LayoutTestController::dumpStatusCallbacks): (LayoutTestController::setCanOpenWindows): (LayoutTestController::dumpBackForwardList): (LayoutTestController::setCloseRemainingWindowsWhenComplete): (LayoutTestController::display): (LayoutTestController::dumpTitleChanges): (LayoutTestController::dumpSelectionRect):
- DumpRenderTree/qt/TextInputControllerQt.cpp: Added. (TextInputController::TextInputController): (TextInputController::doCommand):
- DumpRenderTree/qt/TextInputControllerQt.h: Added.
- DumpRenderTree/qt/WorkQueue.cpp:
- DumpRenderTree/qt/WorkQueue.h:
- DumpRenderTree/qt/WorkQueueItem.h:
- DumpRenderTree/qt/WorkQueueItemQt.cpp: Added. (findFrameNamed): (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke):
- DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
- DumpRenderTree/qt/jsobjects.h:
- 3:50 PM Changeset in webkit [49518] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r49433.
- 3:50 PM Changeset in webkit [49517] by
-
- 5 edits in branches/safari-4-branch
Merge r48492.
- 3:37 PM Changeset in webkit [49516] by
-
- 8 edits1 delete in branches/safari-4-branch
Merge r49026.
- 3:17 PM Changeset in webkit [49515] by
-
- 7 edits in trunk
2009-10-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
https://bugs.webkit.org/show_bug.cgi?id=30278
Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
from the make system into common code.
Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH if NETSCAPE_PLUGIN_API
support is not enabled.
Remove notImplemented() from PluginPackageNone.cpp and
PluginDataNone.cpp make them just empty functions.
- GNUmakefile.am:
- WebCore.pro:
- plugins/PluginDataNone.cpp: (WebCore::PluginData::initPlugins): (WebCore::PluginData::refresh):
- plugins/PluginPackageNone.cpp: (WebCore::PluginPackage::determineQuirks): (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::load):
2009-10-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
https://bugs.webkit.org/show_bug.cgi?id=30278
Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
from the make system into common code.
- wtf/Platform.h:
- 3:02 PM Changeset in webkit [49514] by
-
- 2 edits in trunk/WebKitTools
Not reviewed, adding myself to the list of reviewers.
- Scripts/modules/committers.py:
- 3:02 PM Changeset in webkit [49513] by
-
- 3 edits2 adds in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=30150
<rdar://problem/7283540> REGRESSION: Crash when accessing clipboardData.types
Test: editing/pasteboard/crash-accessing-clipboardData-types.html
- platform/mac/ClipboardMac.mm: (WebCore::addHTMLClipboardTypesForCocoaType): The String class doesn't have operator bool, it's operator NSString* that is invoked instead, and it converts null strings to non-null @"".
- 2:59 PM Changeset in webkit [49512] by
-
- 16 edits2 adds in trunk
<rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
Reviewed by Sam Weinig.
WebKit/mac:
Listen for WebPreferences notifications and update the _isPrivateBrowsingEnabled ivar
when the value changes. Also call -[WebBaseNetscapePluginView privateBrowsingModeDidChange] when the
value changes. In process this just calls NPP_SetValue, and OOP it sends a MIG message to the plug-in host.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::privateBrowsingModeDidChange):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
(-[WebHostedNetscapePluginView privateBrowsingModeDidChange]):
- Plugins/Hosted/WebKitPluginHost.defs:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView privateBrowsingModeDidChange]):
(-[WebBaseNetscapePluginView viewDidMoveToWindow]):
(-[WebBaseNetscapePluginView preferencesHaveChanged:]):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView privateBrowsingModeDidChange]):
(-[WebNetscapePluginView getVariable:value:]):
WebKitTools:
Make the private browsing mode testable by the test plug-in.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginGetProperty):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_SetValue):
LayoutTests:
Add test.
- platform/mac-snowleopard/Skipped:
Remove now passing tests that was fixed by https://bugs.webkit.org/show_bug.cgi?id=30295.
- plugins/private-browsing-mode-expected.txt: Added.
- plugins/private-browsing-mode.html: Added.
- 2:54 PM Changeset in webkit [49511] by
-
- 3 edits5 adds in branches/safari-4-branch
Merge r47494.
- 2:44 PM Changeset in webkit [49510] by
-
- 7 edits in trunk/WebCore
window attributes (like localStorage) that are disabled at runtime are still visible
https://bugs.webkit.org/show_bug.cgi?id=30240
Patch by Drew Wilson <atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by Dimitri Glazkov.
Adding codegen/bindings to support runtime disabling of attributes.
No new tests (only supported by chrome currently)
- bindings/scripts/CodeGeneratorV8.pm:
Refactored the guts of GenerateBatchedAttributeData into a separate GenerateSingleBatchedAttribute with a passed-in indentation level to allow generating a single BatchedAttribute struct.
Added support for the EnabledAtRuntime extended attribute, which generates a call to the appropriate XXXXEnabled() API before adding the attribute to the instance.
- bindings/v8/V8Proxy.cpp:
(WebCore::batchConfigureAttributes):
Refactored attribute setting code into a common inline routine.
- bindings/v8/V8Proxy.h:
(WebCore::configureAttribute):
Inline function which configures a single attribute given a BatchedAttribute struct.
- bindings/v8/custom/V8CustomBinding.h:
Added (DECLARE_)ACCESSOR_RUNTIME_ENABLER to allow enabling attributes at runtime.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
Added code to enable window.Audio only if MediaPlayer.isAvailable() == true
- page/DOMWindow.idl:
Added [EnabledAtRuntime] extended attribute to the Audio attribute.
- 2:24 PM Changeset in webkit [49509] by
-
- 5 edits in trunk/JavaScriptCore
2009-10-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
ARM compiler does not understand reinterpret_cast<void*>
https://bugs.webkit.org/show_bug.cgi?id=29034
Change reinterpret_cast<void*> to regular C style (void*) cast
for the ARM RVCT compiler.
- assembler/MacroAssemblerCodeRef.h: (JSC::FunctionPtr::FunctionPtr):
- jit/JITOpcodes.cpp: Cast to FunctionPtr first
instead of directly casting to reinterpret_cast
- jit/JITStubCall.h: Ditto + change the type of m_stub from void* to FunctionPtr. (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::call):
- jit/JITStubs.cpp: Ditto. (JSC::DEFINE_STUB_FUNCTION(EncodedJSValue, op_throw)):
- 1:53 PM Changeset in webkit [49508] by
-
- 4 edits3 adds in trunk
2009-10-13 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27457
Test case for static email validation on type=email input elements as
per HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state
- fast/forms/ValidityState-typeMismatch-email-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-email.html: Added.
- fast/forms/resources/ValidityState-typeMismatch-email.js: Added. ():
2009-10-13 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27457
Added support for static validation on type=email input elements as per
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state
Test: fast/forms/ValidityState-typeMismatch-email.html
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): ValidityState.typeMismatch performs validation on type=email input elements now. (WebCore::ValidityState::isValidEmailAddress): simple validation method
- html/ValidityState.h:
- 1:27 PM Changeset in webkit [49507] by
-
- 5 edits7 adds in trunk
2009-10-13 Dmitry Titov <dimich@chromium.org>
Reviewed by Adam Barth.
Event listeners installed on a window object returned from window.open() don't work
https://bugs.webkit.org/show_bug.cgi?id=28716
- http/tests/security/resources/has-window-events.html: Added.
- http/tests/security/window-events-clear-domain-expected.txt: Added.
- http/tests/security/window-events-clear-domain.html: Added.
- http/tests/security/window-events-clear-port-expected.txt: Added.
- http/tests/security/window-events-clear-port.html: Added.
- http/tests/security/window-events-pass-expected.txt: Added.
- http/tests/security/window-events-pass.html: Added.
2009-10-13 Dmitry Titov <dimich@chromium.org>
Reviewed by Adam Barth.
Event listeners installed on a window object returned from window.open() don't work
https://bugs.webkit.org/show_bug.cgi?id=28716
Tests: http/tests/security/window-events-clear-domain.html
http/tests/security/window-events-clear-port.html
http/tests/security/window-events-pass.html
- dom/Document.cpp: Split code of Document::clear() in a way to avoid removing all window event handlers when implicitOpen is called. It is called in 2 cases - on committing loaded content (no need to clean handlers) and on document.open() (needs to remove handlers).
(WebCore::Document::open): in addition to calling implicitOpen it also removes window
event handlers, to preserve the behavior of document.open().
(WebCore::Document::implicitOpen): includes the part of removed Document::clear() that
does not remove window event handlers.
- dom/Document.h: Removed clear().
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): add check to avoid removing window event handlers if we transition from temporary empty document to a loaded one.
(WebCore::FrameLoader::didOpenURL): Remove closeURL() which was called twice when loading.
(WebCore::FrameLoader::finishedLoadingDocument): add closeURL() to compensate for change above.
- 1:03 PM Changeset in webkit [49506] by
-
- 3 edits in trunk/WebCore
Fix a leak in the inspector by calling didRemoveNode with
an error code when it fails, instead of returning from the
Backend.
Reviewed by Pavel Feldman.
- inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
- inspector/front-end/ElementsTreeOutline.js:
- 12:01 PM Changeset in webkit [49505] by
-
- 8 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30337>.
Web Inspector: Should be able to delete nodes from the Elements Tree.
Reviewed by Timothy Hatcher.
When the delete key is pressed and a element is selected in the tree,
the element should be deleted from the Elements Tree and the DOM.
- inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didRemoveNode):
- inspector/InspectorFrontend.h:
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._updateModifiedNodes):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.handleKeyEvent):
- 10:08 AM Changeset in webkit [49504] by
-
- 2 edits in trunk/WebCore
Fix REGRESSION(49479): Mouseover on resources graph doesn't show timings.
Reviewed by Timothy Hatcher.
Set pointer-events: none on the new overlay so mouseover events are passed
to the resources graph so we can show timings.
- inspector/front-end/inspector.css:
- 10:04 AM Changeset in webkit [49503] by
-
- 2 edits in trunk/WebKitTools
2009-10-13 Pavel Feldman <pfeldman@chromium.org>
No review, just adding self to the list of reviewers.
- Scripts/modules/committers.py:
- 7:27 AM Changeset in webkit [49502] by
-
- 8 edits in trunk
2009-10-13 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.
This is a bug for two reasons:
- Everytime we use winId(), we end up creating a native widget. This causes an unnecessary copy of contents from the backing store to the native widget.
- Neither windowed nor windowless plugins require the winId of the QWebView or QGraphicsView.
Introduce ownerWidget() which returns a QWidget * without creating a native widget
(as opposed to QWidget::find(winId)).
- platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepthPerComponent):
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show):
- platform/qt/QWebPageClient.h:
- plugins/qt/PluginViewQt.cpp: (WebCore::setSharedXEventFields): (WebCore::PluginView::initXEvent): (WebCore::PluginView::getValue): (WebCore::PluginView::platformStart):
2009-10-13 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.
This is a bug for two reasons:
- Everytime we use winId(), we end up creating a native widget. This causes an unnecessary copy of contents from the backing store to the native widget.
- Neither windowed nor windowless plugins require the winId of the QWebView or QGraphicsView.
Introduce ownerWidget() which returns a QWidget * without creating a native widget
(as opposed to QWidget::find(winId)).
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::ownerWidget):
- Api/qwebview.cpp: (QWebViewPrivate::ownerWidget):
- 6:26 AM Changeset in webkit [49501] by
-
- 2 edits in trunk/WebCore
Unreviewed fix for typo in filename
- 5:14 AM Changeset in webkit [49500] by
-
- 1 edit7 deletes in trunk/LayoutTests
2009-10-13 Pavel Feldman <pfeldman@chromium.org>
Layout test fix, reverting previous change.
Reverting r49499 as it caused several layout test failures.
- inspector/console-tests-expected.txt: Removed.
- inspector/console-tests.html: Removed.
- inspector/elements-panel-structure-expected.txt: Removed.
- inspector/elements-panel-structure.html: Removed.
- inspector/evaluate-in-frontend-expected.txt: Removed.
- inspector/evaluate-in-frontend.html: Removed.
- inspector/evaluate-in-frontend.js: Removed.
- 4:53 AM Changeset in webkit [49499] by
-
- 1 edit8 adds in trunk/LayoutTests
2009-10-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add initial layout tests for web inspector.
- inspector/console-tests-expected.txt: Added.
- inspector/console-tests.html: Added.
- inspector/elements-panel-structure-expected.txt: Added.
- inspector/elements-panel-structure.html: Added.
- inspector/evaluate-in-frontend-expected.txt: Added.
- inspector/evaluate-in-frontend.html: Added.
- inspector/evaluate-in-frontend.js: Added.
- 4:35 AM Changeset in webkit [49498] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Add some initial autotests for QWebPage's ErrorPageExtention
https://bugs.webkit.org/show_bug.cgi?id=30296
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
- tests/qwebpage/tst_qwebpage.cpp:
(ErrorPage::ErrorPage):
(ErrorPage::supportsExtension):
(ErrorPage::extension):
(tst_QWebPage::errorPageExtension):
- 3:57 AM Changeset in webkit [49497] by
-
- 3 edits in trunk/WebKit/qt
[Qt] better handle possible edge cases on qwebframe::requestedUrl use
https://bugs.webkit.org/show_bug.cgi?id=30216
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
QWebFrame::requestedUrl can be called at any time during the load
process, including:
- An error handling (whereas an alternate error page for unsuccessful load is being set);
- A ssl error exception call;
- Navigation notifications (titleChanged, urlChanged, progresses, addHistoryEntry, etc);
- Among others.
This patch makes requestedUrl calls to fallback to FrameLoaderClient
m_loadError's failingURL when an error has occurred, unless it is
null/empty.
Also, m_loadError is now being reset at each the main frame starts a
load, in order to avoid previous load errors footprints.
- Api/qwebframe.cpp:
(QWebFrame::requestedUrl):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):
- 1:28 AM Changeset in webkit [49496] by
-
- 2 edits in trunk/WebKitTools
2009-10-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Adam Roben.
Web Inspector: Use proper web view in inspector layout
tests for windows.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
- 1:26 AM Changeset in webkit [49495] by
-
- 3 edits in trunk/WebCore
2009-10-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Alter profile link format to enable multiple profile types
https://bugs.webkit.org/show_bug.cgi?id=30253
The new profile URL includes the profile type along with the
profile title and uid.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.linkifyStringAsFragment):
- 1:19 AM Changeset in webkit [49494] by
-
- 2 edits in trunk/WebCore
2009-10-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Fix same-named profiles grouping in the Profiles panel.
The tree node re-parenting while adding a new group node was broken.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfile):
- 1:16 AM Changeset in webkit [49493] by
-
- 2 edits in trunk/WebCore
2009-10-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Enforce async interaction between inspector controller and frontend.
- inspector/front-end/inspector.js: (WebInspector.dispatch.delayDispatch): (WebInspector.dispatch):
Oct 12, 2009:
- 11:11 PM Changeset in webkit [49492] by
-
- 6 edits in trunk
2009-10-12 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Missing default value for the default text encoding.
https://bugs.webkit.org/show_bug.cgi?id=30311
QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.
Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.
- platform/qt/Skipped:
2009-10-12 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Missing default value for the default text encoding.
https://bugs.webkit.org/show_bug.cgi?id=30311
QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.
Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::defaultTextEncoding):
- 10:38 PM Changeset in webkit [49491] by
-
- 2 edits in trunk/WebKitSite
Change <a name> to id="" to fix styling problems
https://bugs.webkit.org/show_bug.cgi?id=30283
Reviewed by Eric Seidel.
This prevents the headings from being styled like links.
- coding/contributing.html:
- 9:59 PM Changeset in webkit [49490] by
-
- 7 edits in trunk
2009-10-12 Xiaomei Ji <xji@chromium.org>
Reviewed by Sam Weinig.
Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30034
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
- fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
- fast/dom/elementFromPoint-relative-to-viewport.html:
2009-10-12 Xiaomei Ji <xji@chromium.org>
Reviewed by Sam Weinig.
Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30034
- dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled.
- 9:22 PM Changeset in webkit [49489] by
-
- 5 edits in trunk/LayoutTests
2009-10-12 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed. Fix 4 layout test failures by webkit r49488
WebKit r49488 enables window.WebSocket back.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 6:44 PM Changeset in webkit [49488] by
-
- 9 edits6 adds in trunk
WebCore: JavaScript bindings of WebSocket addEventListener/removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
Test: fast/websockets/websocket-event-target.html
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- websockets/WebSocket.idl:
WebKitTools: Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
LayoutTests: Add a test to verify WebSocket's EventTarget methods.
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
- fast/websockets/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/script-tests/TEMPLATE.html.
- fast/websockets/script-tests/websocket-event-target.js: Added.
(openListener):
(messageListener):
(closeListener):
- fast/websockets/websocket-event-target-expected.txt: Added.
- fast/websockets/websocket-event-target.html: Added.
- 5:47 PM Changeset in webkit [49487] by
-
- 5 edits13 deletes in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=29078
<rdar://problem/7288221>
Reviewed by Darin Adler.
WebCore:
Add a mechanism to blacklist certain codecs. Initially, just blacklist UTF-7 as HTML5 encourages.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::pruneBlacklistedCodecs):
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):
LayoutTests:
Test the lack of UTF-7 support. Remove old UTF-7 tests.
- fast/encoding/char-decoding-expected.txt:
- fast/encoding/char-decoding.html:
- http/tests/misc/submit-get-in-utf7-expected.txt: Removed.
- http/tests/misc/submit-get-in-utf7.html: Removed.
- http/tests/misc/submit-post-in-utf7-expected.txt: Removed.
- http/tests/misc/submit-post-in-utf7.html: Removed.
- http/tests/misc/url-in-utf7-expected.txt: Removed.
- http/tests/misc/url-in-utf7.html: Removed.
- http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Removed.
- http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Removed.
- http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7.html: Removed.
- 5:37 PM Changeset in webkit [49486] by
-
- 9 edits2 adds in trunk
Add support for the beforeload event to frames. Complete support of the beforeload event by making sure
its wrapper gets properly constructed (so that the URL field of the event can be accessed). Add support
for the Objective-C wrapper class as well.
Reviewed by Darin Adler.
Added fast/dom/beforeload/frame-before-load.html
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/objc/DOMEvents.mm:
(kitClass):
- dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::isBeforeLoadEvent):
- dom/Event.cpp:
(WebCore::Event::isBeforeLoadEvent):
- dom/Event.h:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
- 5:27 PM Changeset in webkit [49485] by
-
- 5 edits in trunk
2009-10-12 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium Port - Windows
https://bugs.webkit.org/show_bug.cgi?id=29969
- chromium/DEPS: Added gtest dep required by windows and incremented some of the deps revisions.
2009-10-12 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium Port - Windows
https://bugs.webkit.org/show_bug.cgi?id=29969
- Scripts/pdevenv: removed msvc's /useenv for chromium builds
- Scripts/webkitdirs.pm:
- 5:15 PM BuildingQtOnLinux edited by
- added error relating to phonon (diff)
- 4:49 PM Changeset in webkit [49484] by
-
- 4 edits2 adds in trunk
WebCore: Fix <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()
Reviewed by Simon Fraser.
Test: fast/dynamic/position-absolute-to-fixed-crash.html
The crash was caused by stale positioned objects lists following an
object transitioning from being absolutely position to being fixed
positioned.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange): In case of a transition between
absolute and fixed position, mark the parent as having a child needing
layout, so that this object will get inserted into its new container's
positioned objects list.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange): Changed a condition to cover
this transition, so that this object gets removed from its current
container's positioned objects list.
LayoutTests: Test for <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()
Reviewed by Simon Fraser.
- fast/dynamic/position-absolute-to-fixed-crash-expected.txt: Added.
- fast/dynamic/position-absolute-to-fixed-crash.html: Added.
- 4:20 PM Changeset in webkit [49483] by
-
- 5 edits in trunk
2009-10-12 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Add a palette() method that is needed by our RenderTheme.
- platform/qt/QWebPageClient.h:
2009-10-12 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Implement the new palette() methods on the page clients
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::palette):
- Api/qwebview.cpp: (QWebViewPrivate::palette):
- 4:16 PM Changeset in webkit [49482] by
-
- 1 edit in branches/safari-4-branch/WebCore/dom/Element.cpp
Fix release builds.
- 4:05 PM Changeset in webkit [49481] by
-
- 9 edits4 adds in trunk
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Three old test results give back the absolute position instead of the realtive position.
The new test will check the correct behavior of gradients in userSpaceOnUse mode and
values in percentage.
- platform/mac/svg/custom/gradient-attr-update-expected.txt:
- platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Added.
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
- platform/mac/svg/custom/text-gradient-no-content-expected.txt:
- svg/custom/gradient-userSpaceOnUse-with-percentage.svg: Added.
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Gradients can't handle percentage values in userSpaceOnUse mode
https://bugs.webkit.org/show_bug.cgi?id=30286
Fixed *GradientAttributes to take SVGLength instead of double. This casues
the problem, that we can't calculate the correct size of a gradient on
userSpaceOnUse mode with percentage values.
Test: svg/custom/gradient-userSpaceOnUse-with-percentage.svg
- svg/LinearGradientAttributes.h: (WebCore::LinearGradientAttributes::LinearGradientAttributes): (WebCore::LinearGradientAttributes::x1): (WebCore::LinearGradientAttributes::y1): (WebCore::LinearGradientAttributes::x2): (WebCore::LinearGradientAttributes::y2): (WebCore::LinearGradientAttributes::setX1): (WebCore::LinearGradientAttributes::setY1): (WebCore::LinearGradientAttributes::setX2): (WebCore::LinearGradientAttributes::setY2):
- svg/RadialGradientAttributes.h: (WebCore::RadialGradientAttributes::RadialGradientAttributes): (WebCore::RadialGradientAttributes::cx): (WebCore::RadialGradientAttributes::cy): (WebCore::RadialGradientAttributes::r): (WebCore::RadialGradientAttributes::fx): (WebCore::RadialGradientAttributes::fy): (WebCore::RadialGradientAttributes::setCx): (WebCore::RadialGradientAttributes::setCy): (WebCore::RadialGradientAttributes::setR): (WebCore::RadialGradientAttributes::setFx): (WebCore::RadialGradientAttributes::setFy):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient): (WebCore::SVGLinearGradientElement::collectGradientProperties):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient): (WebCore::SVGRadialGradientElement::collectGradientProperties):
- 3:39 PM Changeset in webkit [49480] by
-
- 4 edits in branches/safari-4-branch/WebCore
Merge r49218.
- 3:33 PM Changeset in webkit [49479] by
-
- 3 edits in trunk/WebCore
Fixes <http://webkit.org/b/30315>.
Web Inspector: DOM Content and Load lines in Resources are unclear what they mean.
Reviewed by Timothy Hatcher.
Add tooltip text to the Load event and DOM Content event lines through
a new layer that allows these lines to be on top of the view.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
(WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition):
- inspector/front-end/inspector.css:
- 3:32 PM Changeset in webkit [49478] by
-
- 7 edits in branches/safari-4-branch/WebKit
Merge r48946.
- 3:32 PM Changeset in webkit [49477] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r47883.
- 3:25 PM Changeset in webkit [49476] by
-
- 6 edits in trunk/WebKitTools
jsc scripts cleanup and Qt/GTK fix
https://bugs.webkit.org/show_bug.cgi?id=30288
Patch by Csaba Osztrogonac <Csaba Osztrogonác> on 2009-10-12
Reviewed by Darin Adler.
Duplicated jscPath() moved to webkitdirs.pm.
New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
Configuration added (release/debug) to path for Qt-port on Windows.
- Scripts/run-javascriptcore-tests:
- Scripts/run-jsc:
- Scripts/run-sunspider:
- Scripts/sunspider-compare-results:
- Scripts/webkitdirs.pm:
- 3:25 PM Changeset in webkit [49475] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48787.
- 3:25 PM Changeset in webkit [49474] by
-
- 6 edits in branches/safari-4-branch
Merge r48775.
- 2:30 PM Changeset in webkit [49473] by
-
- 2 edits in trunk/WebCore
2009-10-12 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r49429, because it broke layout tests.
http://trac.webkit.org/changeset/49429
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
- 2:15 PM Changeset in webkit [49472] by
-
- 3 edits4 adds in trunk
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
SVG - crash on feMerge when input not available
https://bugs.webkit.org/show_bug.cgi?id=30297
Make a early return in SVGFEMergeElement if the needed
filter effect doesn't exist.
Test: svg/filters/feMerge-wrong-input.svg
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Eirc Seidel.
feMergeNod has a reference to an effect that doesn't exist. This test will
check if SVGFEMergeElement handles this correctly and stops the filter process.
- svg/filters/feMerge-wrong-input-expected.checksum: Added.
- svg/filters/feMerge-wrong-input-expected.png: Added.
- svg/filters/feMerge-wrong-input-expected.txt: Added.
- svg/filters/feMerge-wrong-input.svg: Added.
- 2:07 PM Changeset in webkit [49471] by
-
- 3 edits18 adds in branches/safari-4-branch
Merge r48572.
- 2:07 PM Changeset in webkit [49470] by
-
- 7 edits2 adds in branches/safari-4-branch
Merge r47801.
- 2:07 PM Changeset in webkit [49469] by
-
- 2 edits1 add in branches/safari-4-branch/WebCore
Merge r47771.
- 2:00 PM Changeset in webkit [49468] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48848.
- 2:00 PM Changeset in webkit [49467] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48547.
- 2:00 PM Changeset in webkit [49466] by
-
- 5 edits4 adds in branches/safari-4-branch
Merge r48546.
- 2:00 PM Changeset in webkit [49465] by
-
- 3 edits8 adds in branches/safari-4-branch
Merge r47900.
- 2:00 PM Changeset in webkit [49464] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r48743.
- 1:49 PM Changeset in webkit [49463] by
-
- 10 edits4 adds in branches/safari-4-branch
Merge r46136.
- 1:49 PM Changeset in webkit [49462] by
-
- 5 edits in branches/safari-4-branch/WebCore
Merge r47509.
- 1:42 PM Changeset in webkit [49461] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
2009-10-12 Csaba Osztrogonac <Csaba Osztrogonác>
Unreviewed. Added myself to committers.py.
- Scripts/modules/committers.py:
- 1:42 PM Changeset in webkit [49460] by
-
- 6 edits24 adds in branches/safari-4-branch
Merge r48647.
- 1:42 PM Changeset in webkit [49459] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r46521.
- 1:38 PM Changeset in webkit [49458] by
-
- 6 edits in branches/safari-4-branch
Merge r47551.
- 1:38 PM Changeset in webkit [49457] by
-
- 2 edits in branches/safari-4-branch/WebKit/mac
Merge r47300.
- 1:34 PM Changeset in webkit [49456] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48957.
- 1:34 PM Changeset in webkit [49455] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48956.
- 1:34 PM Changeset in webkit [49454] by
-
- 7 edits in branches/safari-4-branch
Merge r48953.
- 1:33 PM Changeset in webkit [49453] by
-
- 4 edits4 adds in branches/safari-4-branch
Merge r46548.
- 1:19 PM Changeset in webkit [49452] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48369.
- 1:19 PM Changeset in webkit [49451] by
-
- 2 edits in branches/safari-4-branch/WebKit/mac
Merge r47657.
- 1:19 PM Changeset in webkit [49450] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r46058.
- 1:19 PM Changeset in webkit [49449] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r45945.
- 1:19 PM Changeset in webkit [49448] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48725.
- 1:03 PM WebKit Team edited by
- (diff)
- 1:00 PM Changeset in webkit [49447] by
-
- 19 edits3 adds in trunk
Added automatic flush before compositing
https://bugs.webkit.org/show_bug.cgi?id=30236
This causes image to always render correctly. In writing a testcase
I needed to implement readPixels. This exposed a bug in reading back
values from a CanvasArray subclass, so I fixed that as well. Now when
you wrap a CanvasArray in a JSValue it actually wraps the specific
subclass. To do this I need to add virtual methods to each CanvasArray
subclass to determine the type and a custom toJS method for CanvasArray
to create the proper wrapper.
Test: fast/canvas/webgl/triangle.html
- 12:38 PM Changeset in webkit [49446] by
-
- 2 edits in trunk/LayoutTests
2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Update Fedora httpd.conf settings to closely match the generic httpd.conf
https://bugs.webkit.org/show_bug.cgi?id=30302
Closely match the default httpd.conf for layout tests.
- http/conf/fedora-httpd.conf:
- 11:09 AM Changeset in webkit [49445] by
-
- 2 edits in trunk/WebCore
2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fix 0 sentinel for g_object_set() function call.
- platform/graphics/gtk/DataSourceGStreamer.cpp: (webkit_data_src_uri_set_uri): 0 is passed as 32 bit value on x86-64 in vararg functions, but g_object_set() expects a 64 bit 0. This will cause crashes.
- 11:05 AM Changeset in webkit [49444] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Remove unnecessary self-include.
- webkit/webkitsecurityorigin.h:
- 9:29 AM Changeset in webkit [49443] by
-
- 2 edits in trunk/WebKit/mac
2009-10-12 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Video keeps playing after going fullscreen, then closing window
https://bugs.webkit.org/show_bug.cgi?id=30164
Clear the QTMovie on the QTMovieView when coming out of fullscreen,
to fix issue where the underlying movie keeps playing.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidExitFullscreen]):
- 8:52 AM Changeset in webkit [49442] by
-
- 1 edit8 adds in trunk/LayoutTests
2009-10-12 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
[Qt] Add expected files for new passing fast tests.
- platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
- platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
- platform/qt/fast/css/text-rendering-expected.txt: Added.
- platform/qt/fast/forms/basic-buttons-expected.txt: Added.
- platform/qt/fast/forms/basic-inputs-expected.txt: Added.
- platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
- platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
- platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
- 8:26 AM Changeset in webkit [49441] by
-
- 7 edits3 adds in trunk
2009-10-12 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop in="" from <feFlood>
https://bugs.webkit.org/show_bug.cgi?id=29001
This makes <feFlood in="bogus"> have an effect, too.
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute
Test: svg/dom/feFlood-no-in1.html
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::build):
- svg/SVGFEFloodElement.h:
- svg/SVGFEFloodElement.idl:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::FEFlood): (WebCore::FEFlood::create):
- svg/graphics/filters/SVGFEFlood.h:
LayoutTest:
Drop in="" from <feFlood>
https://bugs.webkit.org/show_bug.cgi?id=29001
This makes <feFlood in="bogus"> have an effect, too.
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute
- svg/dom/feFlood-no-in1-expected.txt: Added.
- svg/dom/feFlood-no-in1.html: Added.
- svg/dom/script-tests/feFlood-no-in1.js: Added.
- 8:05 AM Changeset in webkit [49440] by
-
- 3 edits in trunk/WebKit/qt
2009-10-12 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
QWebPage's createViewlessPlugin autotest crash fix.
It is possible that plugins that are QWidgets or QGraphicsWidgets
are created before a view has been assigned to a QWebPage. The
plug-ins won't be fully functional, as by design, they should
visualise something, but they won't crash and will stay in memory.
An autotest that covers this use-case, is included.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
- tests/qwebpage/tst_qwebpage.cpp: (PluginTrackedPageWidget::PluginTrackedPageWidget): (PluginTrackedPageGraphicsWidget::PluginTrackedPageGraphicsWidget): (PluginTrackedPageGraphicsWidget::createPlugin): (tst_QWebPage::destroyPlugin): (tst_QWebPage::createViewlessPlugin):
- 7:34 AM Changeset in webkit [49439] by
-
- 2 edits in trunk/WebCore
2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Scale video to completely fill the target surface while
keeping the aspect ratio. This fixes displaying of the
YouTube HTML5 sample website.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Scale video to completely fill the target surface, keep the aspect ratio and center it.
- 7:18 AM Changeset in webkit [49438] by
-
- 5 edits in trunk/WebCore
2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fixes double memcpy of all rendered video frames.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (marshal_VOIDMINIOBJECT): (webkit_video_sink_class_init): (webkit_video_sink_new):
- platform/graphics/gtk/VideoSinkGStreamer.h: Directly pass the buffers up to the MediaPlayerPrivate::paint() method instead of rendering them first to an intermediate cairo surface. This should increase performance and peak memory usage.
- 7:15 AM Changeset in webkit [49437] by
-
- 3 edits in trunk/WebKit/gtk
2009-10-12 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
[GTK] Crash when right-clicking misspelled word
https://bugs.webkit.org/show_bug.cgi?id=29772
Make sure the dictionary exist before adding it to the list of
dictionaries.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
- webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property):
- 4:56 AM Changeset in webkit [49436] by
-
- 2 edits in trunk
2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubberstamped by Eric Seidel.
[Gtk] Fix icu CFLAG for Darwin
https://bugs.webkit.org/show_bug.cgi?id=29517
Don't escape the srcdir variable. Also use $host instead of the
os_foo variables.
- autotools/webkit.m4:
- 4:55 AM Changeset in webkit [49435] by
-
- 2 edits in trunk
2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] Use the SQLite3 headers from WebKitLibraries if sqlite3 is undetected
https://bugs.webkit.org/show_bug.cgi?id=29518
- configure.ac:
- 3:14 AM QtBackLog edited by
- Add new items and pointers to them (diff)
Oct 11, 2009:
- 11:50 PM Changeset in webkit [49434] by
-
- 5 edits6 adds in trunk
2009-10-11 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Fixes an issue where JavaScript URLs that are URL-encoded twice can
bypass the XSSAuditor.
JavaScript URLs that are completed by method Document::completeURL have added
URL-encoded characters such that a direct comparison with the URL-decoded
outgoing HTTP parameters is not sufficient. Instead, the URL-decoded outgoing
HTTP parameters must be URL-decoded before comparison.
Tests: http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL): Modified to pass XSSAuditor the URL-decoded source code for the JavaScript URL.
- page/XSSAuditor.cpp: (WebCore::isIllegalURICharacter): Minor syntactical change to the comment. (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): Added parameter decodeURLEscapeSequencesTwice. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::decodeURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
- page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): Ditto.
2009-10-11 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Tests that JavaScript URLs that are twice URL encoded do not bypass the XSSAuditor.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html: Added.
- 9:17 PM Changeset in webkit [49433] by
-
- 3 edits2 adds in trunk
WebKit/mac: <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and video chat
doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30295
Reviewed by Darin Adler.
Test: plugins/setProperty.html
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::setFieldValue): Fixed a typo. The function
should return early if m_instanceProxy is null.
LayoutTests: Test for <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and
video chat doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30295
Reviewed by Darin Adler.
- plugins/setProperty-expected.txt: Added.
- plugins/setProperty.html: Added.
- 8:30 PM Changeset in webkit [49432] by
-
- 7 edits in trunk/WebCore
2009-10-11 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
Fixes a build break in the V8 bindings caused by revision 49420.
https://bugs.webkit.org/show_bug.cgi?id=30294
Revision 49420 introduces an IDL-defined CanvasActiveInfo
type. This causes a build break in the V8 bindings where
CanvasGraphicsContext3D naively refers to CanvasActiveInfo as a
non-ref type.
- WebCore.gypi: Include CanvasActiveInfo.idl in build.
- bindings/scripts/CodeGeneratorV8.pm: CanvasActiveInfo is a ref ptr type.
- bindings/v8/DOMObjectsInclude.h: Include generated CanvasActiveInfo files.
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 8:15 PM Changeset in webkit [49431] by
-
- 2 edits in trunk/WebCore
2009-10-11 Collin Jackson <collinj@webkit.org>
Reviewed by Adam Barth.
Log mixed content warnings to console
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
- 7:53 PM Changeset in webkit [49430] by
-
- 2 edits in trunk/WebKitTools
2009-10-11 Adam Barth <abarth@webkit.org>
Unreviewed. Add Collin to committers.py.
- Scripts/modules/committers.py:
- 7:36 PM QtBackLog edited by
- (diff)
- 3:48 PM Changeset in webkit [49429] by
-
- 2 edits in trunk/WebCore
2009-10-11 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Adam Barth.
[V8] Add a context scope in JS listener destructor. The destructor code uses the cotext. See http://crbug.com/24200.
https://bugs.webkit.org/show_bug.cgi?id=30250
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
- 3:34 PM Changeset in webkit [49428] by
-
- 2 edits in trunk/WebCore
2009-10-11 Lyon Chen <lyon.chen@torchmobile.com>
Reviewed by Alexey Proskuryakov.
Correct the position of #endif sentence inside WebCore::Document::finishedParsing().
This change requires no test case as it fix a compiling error.
- dom/Document.cpp: (WebCore::Document::finishedParsing):
- 3:17 PM Changeset in webkit [49427] by
-
- 3 edits in trunk/WebCore
2009-10-11 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
Sets a 500K stack limit for JavaScript workers in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=29797
Runaway recursion in JavaScript workers crashes the Chromium
worker process on OS X. This is because V8's default stack limit
is 512K on ia32 or 1M on x64, but the worker process runs workers
on a thread with the OS X default stack size--512K. Because there
are already some C++ frames on the stack when V8 establishes its
512K default stack limit, and V8 doesn't precisely enforce the
stack limit, runaway recursion in V8 workers overflows the OS
stack and segfaults, killing the worker process. This is described
in Chromium bug 21653 <http://crbug.com/21653>.
This patch sets the V8 stack limit for worker JavaScript in
Chromium to a more conservative 500K on all platforms. This allows
some "headroom" for the C++ stack in use when the limit is set up,
and some "legroom" for the V8 helper functions which in practice
briefly flout the V8 stack limit.
Test: LayoutTests/fast/workers/use-machine-stack.html
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
- bindings/v8/WorkerContextExecutionProxy.h:
- 2:30 PM Changeset in webkit [49426] by
-
- 2 edits in trunk/JavaScriptCore
Re-enable the JIT.
- 1:01 PM Changeset in webkit [49425] by
-
- 4 edits in trunk
wx build fixes, adding bindings to include/source dirs and fixing wxMac 2.9 compilation.
- 2:46 AM Changeset in webkit [49424] by
-
- 10 edits3 adds in trunk
Allow [Reflect] on SVG elements.
https://bugs.webkit.org/show_bug.cgi?id=28936
Reviewed by Sam Weinig.
Update the JS binding generators to reference SVGNames instead of
HTMLNames, if [Reflect]ing an attribute on an SVG element. Make
SVGElement::id use [Reflect].
Also make [Reflect] on an attribute with a setter exception work in ObjC
bindings.
WebCore:
Test: svg/dom/id-reflect.html
- bindings/scripts/CodeGenerator.pm: Add a function to determine the
appropriate C++ namespace for attribute name constants.
- bindings/scripts/CodeGeneratorObjC.pm: Generate ExceptionCode handling
code for [Reflect] on an attribute with a setter exception.
- bindings/scripts/CodeGeneratorCOM.pm: Generate "SVGNames" instead of
"HTMLNames" when appropriate.
- bindings/scripts/CodeGeneratorJS.pm: Ditto.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- svg/SVGElement.cpp: Remove getter and setter methods for id.
- svg/SVGElement.h: Ditto.
- svg/SVGElement.idl: Add [Reflect] to id.
LayoutTests:
- svg/dom/script-tests/id-reflect.js: Added.
- svg/dom/id-reflect-expected.txt: Added.
- svg/dom/id-reflect.html: Added.
Oct 10, 2009:
- 8:47 PM Changeset in webkit [49423] by
-
- 3 edits3 adds in trunk
Support for String.trim(), String.trimLeft() and String.trimRight() methods
https://bugs.webkit.org/show_bug.cgi?id=26590
Reviewed by Maciej Stachowiak.
Implement trim, trimLeft, and trimRight
- 3:10 PM Changeset in webkit [49422] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r49414): Rebaseline needed for Windows / Gtk Linux
https://bugs.webkit.org/show_bug.cgi?id=30279
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-10
Reviewed by Eric Seidel.
- platform/gtk/editing/style/5228141-expected.txt: Same rebaseline done for Mac in r49414
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: two i tags are merged properly
- 2:46 PM Changeset in webkit [49421] by
-
- 2 edits in trunk/WebCore
Fix paths in xcode.
- 2:16 PM Changeset in webkit [49420] by
-
- 10 edits2 copies8 adds in trunk
Implement getActiveAttrib and getActiveUniform
https://bugs.webkit.org/show_bug.cgi?id=30276
Reviewed by Eric Carlson.
Implements the getActiveAttrib and getActiveUniform APIs.
Rather simple patch, adds CanvasActiveInfo definition and implementation
and adds forwarding to the GraphicsContext3D.
Test: fast/canvas/webgl/getActiveTest.html
- 12:21 PM Changeset in webkit [49419] by
-
- 2 edits in trunk/WebCore
2009-10-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Adding new attributes in Element Panel is
counterintuitive.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
- 9:19 AM Changeset in webkit [49418] by
-
- 4 edits in trunk/WebCore
2009-10-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30275
In addition to fixing the build break with guards
remove notImplemented() from PluginViewNone.cpp and
make them just just be empty functions.
- plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp: (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::getValue): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::invalidateRegion): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::updatePluginWidget):
- 8:56 AM Changeset in webkit [49417] by
-
- 2 edits in trunk/WebCore
2009-10-10 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Add HistoryController.cpp to the build.
- WebCore.pro:
- 6:53 AM Changeset in webkit [49416] by
-
- 2 edits in trunk/WebCore
2009-10-09 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
[Chromium] KURLGoogle's protocolIs barfs on input containing hyphens
https://bugs.webkit.org/show_bug.cgi?id=30262
This is not testable from WebKit since WebKit never uses the member
function form of protocolIs with input that can be controlled from a
web page. It always passes string literals lacking hyphens.
- platform/KURLGoogle.cpp: (WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would transform the input character.
- 3:04 AM BuildingQtOnWindows edited by
- (diff)
- 2:11 AM Changeset in webkit [49415] by
-
- 8 edits2 adds in trunk/WebCore
2009-10-10 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Move HistoryController to its own file
https://bugs.webkit.org/show_bug.cgi?id=30272
Purely mechanical.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/HistoryController.cpp: Added.
- loader/HistoryController.h: Added.
Oct 9, 2009:
- 8:36 PM Changeset in webkit [49414] by
-
- 10 edits3 adds in trunk
ApplyStyleCommand removes presentational tags even when not necessary
https://bugs.webkit.org/show_bug.cgi?id=28091
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-09
Reviewed by Eric Seidel.
WebCore:
This patch updates implicitlyStyledElementShouldBeRemovedWhenApplyingStyle to return true
(triggering removal of tag) only if the style implicitly added by the element is not present in
the new style to apply. It also changes surroundNodeRangeWithElement so that it merges the
surrounding element when possible. applyTextDecorationStyle is modified so that it does not add
style span when the style attribute is empty.
Test: editing/execCommand/toggle-style-3.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::shouldRemoveTextDecorationTag): Returns true if specified text
decoration is not present in the style to apply
(WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): No longer
returns true if the tag is used in new style
(WebCore::ApplyStyleCommand::applyTextDecorationStyle): Does not add style-span when redundant
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Merges the newly created element
with the surrounding identical elements
- editing/ApplyStyleCommand.h:
LayoutTests:
This patch adds test to make sure to preserve presentational tag
(u, s, strike, i, em, sup, sub, b, & strong) when the corresponding style is present in
the final computed style. i.e. avoid removing tag and re-applying the style later
- editing/execCommand/19653-2-expected.txt: Two b elements are merged.
- editing/execCommand/createLink-expected.txt: Two anchor elements are merged.
- editing/execCommand/script-tests/toggle-style-3.js: Added.
(testSingleToggle):
- editing/execCommand/strikethroughSelection-expected.txt: Redundant style spans are no longer added.
- editing/execCommand/toggle-style-3-expected.txt: Added.
- editing/execCommand/toggle-style-3.html: Added.
- editing/execCommand/unlink-expected.txt: Two anchor elements are merged.
- platform/mac/editing/style/5228141-expected.txt: Two b elements are merged.
- platform/mac/editing/style/style-boundary-001-expected.txt: Two b elements are merged.
- 7:27 PM Changeset in webkit [49413] by
-
- 10 edits in trunk
2009-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246
Update API call.
- WebView.cpp: (WebView::loadBackForwardListFromOtherView):
2009-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246
Update API call.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::restoreViewState):
- WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]):
2009-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246
HistoryController is in charge of managing the current / previous /
provisional HistoryItems. The split isn't perfect, but it's a place to
start. I'll move HistoryController into its own file in another patch.
- WebCore.base.exp:
- loader/FrameLoader.cpp: (WebCore::HistoryController::HistoryController): (WebCore::HistoryController::~HistoryController): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::closeURL): (WebCore::FrameLoader::begin): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::setCurrentItem): (WebCore::HistoryController::setProvisionalItem): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::didFirstLayout): (WebCore::HistoryController::updateForFrameLoadCompleted): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::HistoryController::addHistoryItemForFragmentScroll): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::HistoryController::createHistoryItem): (WebCore::FrameLoader::checkDidPerformFirstNavigation): (WebCore::HistoryController::addBackForwardItemClippedAtTarget): (WebCore::HistoryController::createHistoryItemTree): (WebCore::HistoryController::saveScrollPositionAndViewStateToItem): (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::invalidateCurrentItemCachedPage): (WebCore::HistoryController::saveDocumentState): (WebCore::FrameLoader::loadItem): (WebCore::HistoryController::urlsMatchItem): (WebCore::HistoryController::goToItem): (WebCore::HistoryController::recursiveGoToItem): (WebCore::HistoryController::childFramesMatchItem): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForClientRedirect): (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::updateForCommit): (WebCore::HistoryController::updateForAnchorScroll): (WebCore::HistoryController::saveDocumentAndScrollState): (WebCore::HistoryController::setCurrentItemTitle): (WebCore::FrameLoader::didChangeTitle):
- loader/FrameLoader.h: (WebCore::HistoryController::current): (WebCore::HistoryController::provisional): (WebCore::FrameLoader::policyChecker): (WebCore::FrameLoader::history): (WebCore::FrameLoader::creatingInitialEmptyDocument):
- page/Page.cpp: (WebCore::Page::goToItem):
- 5:53 PM Changeset in webkit [49412] by
-
- 2 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore
Try to fix Windows build by adding needed exports.
- 5:46 PM Changeset in webkit [49411] by
-
- 5 edits in trunk
WebKit/mac: <rdar://problem/7290671> Crash after navigating away from a page with subframe containing plug-in
Reviewed by Brady Eidson.
At the time that -stop is called on a WebBaseNetscapePluginView that is contained within a subframe
the WebFrame's data source has been zeroed out. This was causing -[WebBaseNetscapePluginView webFrame]
to return nil during -stop, preventing the plug-in view from unregistering itself from the PluginHalter.
We fix this by having -webFrame retrieve the frame directly rather than retrieving it from the data source.
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView dataSource]): Get the data source from the WebFrame.
(-[WebBaseNetscapePluginView webFrame]): Get the Frame directly from the element's document rather
than taking a windy route through the WebDataSource.
WebKitTools: Enable plug-in halting in DumpRenderTree.
We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:shouldHaltPlugin:]):
- 5:38 PM Changeset in webkit [49410] by
-
- 2 edits in trunk/WebCore
Unreviewed - fixing an obvious typo in my previous check-in.
https://bugs.webkit.org/show_bug.cgi?id=30260
<rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work
Fixes existing tests (which I thought I had run the previous time).
- platform/network/CredentialStorage.cpp: (WebCore::originsWithCredentials): Return the set by reference.
- 5:30 PM Changeset in webkit [49409] by
-
- 10 edits in trunk/JavaScriptCore
Eliminated some legacy bytecode weirdness.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-09
Reviewed by Oliver Hunt.
Use vPC[x] subscripting instead of ++vPC to access instruction operands.
This is simpler, and often more efficient.
To support this, and to remove use of hard-coded offsets in bytecode and
JIT code generation and dumping, calculate jump offsets from the beginning
of an instruction, rather than the middle or end.
Also, use OPCODE_LENGTH instead of hard-coded constants for the sizes of
opcodes.
SunSpider reports no change in JIT mode, and a 1.01x speedup in Interpreter
mode.
- bytecode/CodeBlock.cpp:
(JSC::printConditionalJump):
(JSC::CodeBlock::dump):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC::BytecodeGenerator::emitJumpScopes):
(JSC::BytecodeGenerator::emitNextPropertyName):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitJumpSubroutine):
(JSC::prepareJumpTableForImmediateSwitch):
(JSC::prepareJumpTableForCharacterSwitch):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::endSwitch):
- bytecompiler/Label.h:
(JSC::Label::setLocation):
(JSC::Label::bind):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveBase):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitBinaryDoubleOp):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_loop):
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emitSlow_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
(JSC::JIT::emit_op_loop_if_true):
(JSC::JIT::emitSlow_op_loop_if_true):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_jmp_scopes):
- 4:28 PM Changeset in webkit [49408] by
-
- 3 edits in trunk/WebCore
[v8] Need change to V8WorkerContextEventListener::reportError signature to match the base class.
https://bugs.webkit.org/show_bug.cgi?id=30264
Patch by David Levin <levin@chromium.org> on 2009-10-09
Reviewed by Eric Seidel.
The base class method changed in r48884.
Test: fast/worker/worker-script-error.html
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::reportError):
- bindings/v8/V8WorkerContextEventListener.h:
- 3:45 PM Changeset in webkit [49407] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix bad ChangeLog entry merge in r49019 by the commit queue script.
- 3:29 PM Changeset in webkit [49406] by
-
- 6 edits10 adds in trunk
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=30260
<rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work
Tests: http/tests/xmlhttprequest/logout.html
http/tests/xmlhttprequest/re-login-async.html
http/tests/xmlhttprequest/re-login.html
Fix several issues with existing credential handling code.
- platform/network/CredentialStorage.cpp: (WebCore::pathToDefaultProtectionSpaceMap): Changed the data structure to a simpler one. (WebCore::originsWithCredentials): The reason for two-stage lookup above was that we didn't want to iterate paths for origins that never had credentials associated with them. Changed to use a separate HashSet for this. (WebCore::pathToDefaultProtectionSpaceMap): The concept of default per-path credentials didn't match the spec very well. UAs are supposed to deduce protection space from an URL, and then use whichever credentials are known for this protection space. So, OriginToDefaultBasicCredentialMap is now PathToDefaultProtectionSpaceMap. (WebCore::protectionSpaceMapKeyFromURL): Factored out a helper that extracts a directory URL from a given URL. These directory URLs are what we use as keys in PathToDefaultProtectionSpaceMap. (WebCore::CredentialStorage::set): Updated for above changes. (WebCore::findDefaultProtectionSpaceForURL): Factored out code iterating path length to find a prefix in OriginToDefaultBasicCredentialMap. (WebCore::CredentialStorage::set): Another version of set() can update credentials for a URL default protection space. It does nothing if the given URL doesn't correspond to a known protection space. (WebCore::CredentialStorage::get): Renamed from getDefaultAuthenticationCredential.
- platform/network/CredentialStorage.h: Made the distinction between methods that use a known protection space and those that deduce one from URL more clear.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Update credentials before starting the request for real. This makes the following pattern work: var req = new XMLHttpRequest("GET", "logout.html", "logout", "logout"); wrong credentials req.send(""); req.abort(); Abort() is used here to avoid having UA present an auth dialog after getting a 401 response. Note that one cannot log in using the same method, because there isn't a known protection space for the URL yet in that case, so the added code has no effect. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Use a correct persistence for calling receivedCredential(). This fixes logging in using an async XHR (withut abort(), of course), and matches sync case. (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Renamed getDefaultAuthenticationCredential() to get().
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): (WebCore::WebCoreSynchronousLoader::load): Same changes as in Mac code.
- 3:01 PM Changeset in webkit [49405] by
-
- 14 edits4 adds in trunk
2009-10-09 Enrica Casucci <enrica@apple.com>
Reviewed by Adele Peterson.
Undoing a indent removes text instead of it's formatting.
<rdar://problem/7169206>
https://bugs.webkit.org/show_bug.cgi?id=28722
Added test case for https://bugs.webkit.org/show_bug.cgi?id=23995
- editing/execCommand/19653-1-expected.txt: Re-baselined.
- editing/execCommand/indent-div-inside-list-expected.txt: Re-baselined.
- editing/execCommand/indent-nested-blockquotes-expected.txt: Re-baselined.
- editing/execCommand/indent-nested-div-expected.txt: Re-baselined.
- editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Re-baselined.
- editing/execCommand/indent-with-style-expected.txt: Added.
- editing/execCommand/indent-with-style.html: Added.
- editing/undo/undo-indent-expected.txt: Added.
- editing/undo/undo-indent.html: Added.
- platform/mac/editing/execCommand/4641880-2-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/4916541-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/5138441-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/5481523-expected.txt: Re-baselined.
- platform/mac/editing/execCommand/indent-selection-expected.txt: Re-baselined.
2009-10-09 Enrica Casucci <enrica@apple.com>
Reviewed by Adele Peterson.
Undoing a indent removes text instead of it's formatting.
<rdar://problem/7169206>
https://bugs.webkit.org/show_bug.cgi?id=28722
Restored the behavior prior to http://trac.webkit.org/changeset/46143. This change implemented the
indent command making simple DOM operation, without using moveParagraph which cause undo to be broken.
Added editing/undo/undo-indent.html test.
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Restored. (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Merged changes. (WebCore::IndentOutdentCommand::indentIntoBlockquote): Restored. (WebCore::IndentOutdentCommand::indentRegion): Restored and added call to updateLayout to ensure TextIterator could correctly calculate the position starting from the index.
- editing/IndentOutdentCommand.h: Restored.
- 2:24 PM Changeset in webkit [49404] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-10-09 Rimas Kudelis <rq@akl.lt>
Rubber-stamped by Gustavo Noronha
https://bugs.webkit.org/show_bug.cgi?id=30054
Localization of WebKit GTK into Lithuanian
- lt.po: Added.
- 2:24 PM Changeset in webkit [49403] by
-
- 2 edits in trunk/WebCore
2009-10-09 Jens Alfke <snej@chromium.org>
Reviewed by Darin Adler.
Optimization: Many StringImpl transformations are no-ops and should just return 'this'
https://bugs.webkit.org/show_bug.cgi?id=30186
Optimized StringImpl methods lower(), stripWhiteSpace() and simplifyWhiteSpace() to
detect no-ops and return this instead of creating a new instance.
Empirical testing shows that the majority of calls to these methods are no-ops, making
this worthwhile even if (in the case of lower()) the non-no-op case is slightly slowed.
Upper() is very rarely a no-op, so it wasn't worthwhile to optimize it.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): Just add a comment explaining why this wasn't optimized (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace):
- 1:51 PM Changeset in webkit [49402] by
-
- 6 edits4 adds in trunk
2009-10-09 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG Filter feGaussianBlur implementation is missing
https://bugs.webkit.org/show_bug.cgi?id=28141
This is the implementation of GaussianBlur filter for SVG.
There is already a test for feGaussianBlur
Test: svg/W3C-SVG-1.1/filters-gauss-01-b-w3c.svg
Test: svg/filters/feGaussianBlur.svg
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
- platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isAlphaImage): (WebCore::FilterEffect::setIsAlphaImage):
- platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
- svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::boxBlur): (WebCore::FEGaussianBlur::apply):
Test for feGaussianBlur implementation
- platform/mac/svg/filters/feGaussianBlur-expected.checksum: Added.
- platform/mac/svg/filters/feGaussianBlur-expected.png: Added.
- platform/mac/svg/filters/feGaussianBlur-expected.txt: Added.
- svg/filters/feGaussianBlur.svg: Added.
- 12:37 PM Changeset in webkit [49401] by
-
- 4 edits in trunk/WebCore
2009-10-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] QoS support in the video sink
https://bugs.webkit.org/show_bug.cgi?id=29959
Removed the async buffer queue from the sink. Synchronize the
render method of the sink using a g_timeout_add() combined with a
gcond triggered when the buffer has been rendered.
Also fixed the video sink reference handling in the player, now
that the idle is not there anymore to mess up things.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_init): (webkit_video_sink_timeout_func): (webkit_video_sink_render): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_stop): (webkit_video_sink_class_init):
- 12:13 PM Changeset in webkit [49400] by
-
- 19 edits6 adds in trunk
2009-10-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMorphology filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5863
Adds SVGFEMorphologyElement, for the SVG filter. It also fixes a bug
with the attribute "operator". It was only accessible via "_operator"
on JavaScript.
Test: svg/dom/operatorAttribute.xhtml
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.SVG.Filters.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm: (WebCore::createElementClassMap):
- bindings/objc/DOMSVG.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- page/DOMWindow.idl:
- svg/SVGAllInOne.cpp:
- svg/SVGFECompositeElement.idl:
- svg/SVGFEMorphologyElement.cpp: Added. (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::~SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::parseMappedAttribute): (WebCore::SVGFEMorphologyElement::build):
- svg/SVGFEMorphologyElement.h: Added.
- svg/SVGFEMorphologyElement.idl: Added.
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::operator<<):
- svg/graphics/filters/SVGFEMorphology.h: (WebCore::):
- svg/svgtags.in:
Reviewed by Nikolas Zimmermann.
Attribute "operator" schould only be accessible by "operator", not by "_operator"
- svg/dom/operatorAttribute-expected.txt: Added.
- svg/dom/operatorAttribute.html: Added.
- svg/dom/script-tests/operatorAttribute.js: Added.
- 12:12 PM Changeset in webkit [49399] by
-
- 2 edits in trunk/WebCore
2009-10-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dimitri Glazkov.
Fix Chromium breakage.
- inspector/front-end/inspector.js: (WebInspector.addCookieDomain): check that Storage panel is present before calling its methods.
- 11:14 AM Changeset in webkit [49398] by
-
- 9 edits in trunk/JavaScriptCore
Migrated some code that didn't belong out of Structure.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-09
Reviewed by Sam Weinig.
SunSpider says maybe 1.03x faster.
- runtime/JSCell.h: Nixed Structure::markAggregate, and made marking of
a Structure's prototype the direct responsility of the object using it.
(Giving Structure a mark function was misleading because it implied that
all live structures get marked during GC, when they don't.)
- runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
(JSC::JSGlobalObject::markChildren): Added code to mark prototypes stored
on the global object. Maybe this wasn't necessary, but now we don't have
to wonder.
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getEnumerableNamesFromClassInfoTable):
- runtime/JSObject.h:
(JSC::JSObject::markChildrenDirect):
- runtime/PropertyNameArray.h:
- runtime/Structure.cpp:
- runtime/Structure.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache): Moved property name gathering code
from Structure to JSObject because having a Structure iterate its JSObject
was a layering violation. A JSObject is implemented using a Structure; not
the other way around.
- 10:31 AM Changeset in webkit [49397] by
-
- 7 edits in trunk
2009-10-09 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
Sets Qt::WA_InputMethodEnabled and Qt::ImhHiddenText for password fields in EditorClientQt
setInputMethodState. This change is needed so widgets such as the s60 software
input panel can receive input method events for password fields.
It's up to the Qt platform to determine which widget will receive input method
events when these flags are set.
Also added implementation for setInputMethodEnabled and setInputMethodHint
to QGraphicsWebViewPrivate and QWebViewPrivate. This change removes the direct
dependency on QWebView and uses QWebPageClient.
Added autotest to tst_qwebpage.cpp
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::setInputMethodEnabled): (QGraphicsWebViewPrivate::setInputMethodHint):
- Api/qwebview.cpp: (QWebViewPrivate::setInputMethodEnabled): (QWebViewPrivate::setInputMethodHint):
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
2009-10-09 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Added pure virtual methods setInputMethodEnabled and setInputMethodHint to QWebPageClient
- platform/qt/QWebPageClient.h:
- 10:26 AM Changeset in webkit [49396] by
-
- 1 edit3 moves in trunk/LayoutTests
Requested by Mark Rowe.
Patch by Darin Adler <Darin Adler> on 2009-10-09
Moved DOM test that was in fast/js to fast/dom where it belongs.
- fast/dom/Document/invalid-domain-change-throws-exception-expected.txt:
Copied from fast/js/invalid-domain-change-throws-exception-expected.txt.
- fast/dom/Document/invalid-domain-change-throws-exception.html:
Copied from fast/js/invalid-domain-change-throws-exception.html.
Regenerated with the make-script-test-wrappers.
- fast/dom/Document/script-tests/invalid-domain-change-throws-exception.js:
Copied from fast/js/resources/invalid-domain-change-throws-exception.js.
- fast/js/invalid-domain-change-throws-exception-expected.txt: Removed.
- fast/js/invalid-domain-change-throws-exception.html: Removed.
- fast/js/resources/invalid-domain-change-throws-exception.js: Removed.
- 10:20 AM Changeset in webkit [49395] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog patch reviewer to be accurate.
- 10:03 AM Changeset in webkit [49394] by
-
- 11 edits2 adds in trunk
Implement beforeload for images. ImageLoadEventSender has been refactored into a more generic
ImageEventSender that can be used by both load and beforeload events. If the document has any
beforeload listeners, then the installation of images onto the renderer becomes asynchronous
and will be held up until the beforeload event can fire at a later date.
Reviewed by Adam Roben.
Both beforeload and load events now fire at the end of the tokenizer write() methods, so that
in the typical parsing case we don't have to put off the beforeload/load events until after
a layout or paint might already have happened. This lets beforeload/load not cause extra
layouts and repaints.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::dispatchBeforeLoadEvent):
- dom/Document.cpp:
(WebCore::Document::implicitClose):
(WebCore::Document::addListenerTypeIfNeeded):
- dom/Document.h:
(WebCore::Document::):
- dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::write):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::attach):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach):
- html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::write):
- loader/ImageLoader.cpp:
(WebCore::ImageBeforeLoadEventSender::ImageBeforeLoadEventSender):
(WebCore::ImageLoadEventSender::ImageLoadEventSender):
(WebCore::beforeLoadEventSender):
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::setLoadingImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingEvents):
(WebCore::ImageEventSender::ImageEventSender):
(WebCore::ImageEventSender::dispatchEventSoon):
(WebCore::ImageEventSender::cancelEvent):
(WebCore::ImageEventSender::dispatchPendingEvents):
(WebCore::ImageEventSender::timerFired):
- loader/ImageLoader.h:
(WebCore::ImageLoader::haveFiredBeforeLoadEvent):
- wml/WMLImageElement.cpp:
(WebCore::WMLImageElement::attach):
- 9:36 AM Changeset in webkit [49393] by
-
- 2 edits in trunk/WebCore
2009-10-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
Web Inspector: Wrap Database into ScriptObject in v8 bindings.
No tests due to no Script* test infrastructure.
- bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- 9:35 AM Changeset in webkit [49392] by
-
- 3 edits in trunk/WebKit/mac
Add SPI to specifically enable visited link tracking.
Reviewed by Dan Bernstein.
- History/WebHistory.mm:
(+[WebHistory _setVisitedLinkTrackingEnabled:]):
- History/WebHistoryPrivate.h:
- 7:58 AM Changeset in webkit [49391] by
-
- 2 edits in trunk/WebCore
2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins : Fix crash when using QWebPage without QWebView.
'client' is 0 when we have no view.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
- 7:51 AM Changeset in webkit [49390] by
-
- 3 edits in trunk/LayoutTests/platform/mac
Set the svn:mime-type property of recently-added PNG files to image/png.
- 5:47 AM Changeset in webkit [49389] by
-
- 2 edits in trunk/WebCore
2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Plugins : Add missing setCurrentPlugin(0)
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent):
- 5:32 AM Changeset in webkit [49388] by
-
- 2 edits in trunk/WebCore
2009-10-09 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] beforeload event does not fire on script elements in XML
https://bugs.webkit.org/show_bug.cgi?id=30235
r49194 was lacking a change to XMLTokenizerQt.cpp, equivalent to the one
made in XMLTokenizerLibxml2.cpp.
- dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
- 5:12 AM Changeset in webkit [49387] by
-
- 2 edits in trunk/WebCore
2009-10-09 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore's CSSParserValueList
https://bugs.webkit.org/show_bug.cgi?id=30249
Inherits CSSParserValueList class from FastAllocBase because it has
been instantiated by 'new' in WebCore/css/CSSGrammar.y:1271.
- css/CSSParserValues.h:
- 4:32 AM Changeset in webkit [49386] by
-
- 2 edits in trunk/WebCore
2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins : Create Pixmap only when size changes.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
- 2:36 AM Changeset in webkit [49385] by
-
- 25 edits in trunk
Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking
for the existence of a PluginHalterDelegate.
This fixes a leak of WebPluginHalterClients:
https://bugs.webkit.org/show_bug.cgi?id=30119.
WebCore:
Reviewed by Dan Bernstein.
- WebCore.base.exp:
Removed the export of WebCore::Settings::setPluginHalterEnabled().
- loader/EmptyClients.h:
(WebCore::EmptyPluginHalterClient::enabled):
- page/Page.cpp:
(WebCore::Page::Page):
Remove initialization of m_pluginHalterClient, which was removed. If a
non-null PluginHalterClient was passed, create the PluginHalter, and
set its allowed run time.
- page/Page.h:
Removed pluginHalterEnabledStateChanged() and m_pluginHalterClient.
- page/PluginHalter.cpp:
(WebCore::PluginHalter::didStartPlugin):
Check whether the PluginHalterClient is enabled.
(WebCore::PluginHalter::didStopPlugin):
Ditto.
- page/PluginHalter.h:
Made m_client an OwnPtr.
- page/PluginHalterClient.h:
Added a function to return the enabled state.
- page/Settings.cpp:
(WebCore::Settings::Settings):
Remove initialization of removed member.
- page/Settings.h:
Removed settings for the enabled state of the PluginHalter; we now use
the existence of a WebPluginHalterDelegate to determine whether the
PluginHalter is enabled.
WebKit/mac:
- WebCoreSupport/WebPluginHalterClient.h:
Add declaration for new function.
- WebCoreSupport/WebPluginHalterClient.mm:
(WebPluginHalterClient::enabled):
Check whether the UIDelegate responds to shouldHaltPlugin.
- WebView/WebPreferenceKeysPrivate.h:
Remove the "enabled" preference key.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Remove the initialization of the pref.
- WebView/WebPreferencesPrivate.h:
Remove the getter/setter for this pref.
- WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
Remove propagation of the pref.
WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
Remove the getter and setter.
- WebCoreSupport/WebPluginHalterClient.cpp:
(WebPluginHalterClient::enabled):
Return true if the delegate exists.
- WebCoreSupport/WebPluginHalterClient.h:
Declare implementation of enabled().
- WebPreferenceKeysPrivate.h:
Removed the pref key.
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
Removed initialization of the pref.
- WebPreferences.h:
Removed declaration of the getter/setter.
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Don't propagate the pref.
- 1:59 AM Changeset in webkit [49384] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix the GTK release build.
- GNUmakefile.am: Include Grammar.cpp in release builds now that
AllInOneFile.cpp is gone.
- 12:50 AM Changeset in webkit [49383] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-09 Gabor Loki <loki@inf.u-szeged.hu>
Rubber-stamped by Eric Seidel.
Add ARM JIT support for Gtk port (disabled by default)
https://bugs.webkit.org/show_bug.cgi?id=30228
- GNUmakefile.am:
Oct 8, 2009:
- 11:05 PM Changeset in webkit [49382] by
-
- 2 edits in trunk/WebKitSite
2009-10-08 Alex Milowski <alex@milowski.com>
Reviewed by Darin Adler.
Added a basic description of the layout and rendering project and added links to the blog entries on rendering.
- projects/layout/index.html:
- 10:30 PM Changeset in webkit [49381] by
-
- 4 edits2 adds in branches/safari-4-branch
Merge r48521.
- 10:23 PM Changeset in webkit [49380] by
-
- 2 edits1 add in branches/safari-4-branch/WebCore
Merge r48960.
- 10:21 PM Changeset in webkit [49379] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r46604.
- 10:16 PM Changeset in webkit [49378] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48443.
- 10:14 PM Changeset in webkit [49377] by
-
- 2 edits in branches/safari-4-branch/WebKit/mac
Merge r48394.
- 10:14 PM Changeset in webkit [49376] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r48361.
- 10:13 PM Changeset in webkit [49375] by
-
- 2 edits in branches/safari-4-branch/WebKit/mac
Merge r48360.
- 10:13 PM Changeset in webkit [49374] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48359.
- 10:13 PM Changeset in webkit [49373] by
-
- 3 edits1 add in branches/safari-4-branch/WebCore
Merge r48358.
- 10:08 PM Changeset in webkit [49372] by
-
- 31 edits1 add in trunk
2009-10-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200
Update API call.
- Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
2009-10-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200
Update API call.
- webkit/webkitwebview.cpp: (webkit_web_view_execute_script):
2009-10-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200
Update API call.
- WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
2009-10-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200
Update API call.
- WebFrame.cpp: (wxWebFrame::RunScript):
2009-10-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200
Update API call.
- WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
- WebView/WebView.mm: (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
2009-10-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200
These methods have virtually no interaction with FrameLoader. They
really seem like they ought to belong to ScriptController.
- WebCore.base.exp:
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL): (WebCore::ScriptController::evaluate):
- bindings/js/ScriptController.h:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/v8/ScriptController.h:
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::endElementNs):
- dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::replaceDocument):
- loader/FrameLoader.h:
- plugins/PluginView.cpp: (WebCore::PluginView::performRequest):
- 8:45 PM Changeset in webkit [49371] by
-
- 2 edits in trunk/JavaScriptCore
Tiger build fix: added a few more variable initializations.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncSearch):
- 8:42 PM Changeset in webkit [49370] by
-
- 2 edits in trunk/JavaScriptCore
Qt build fix: added missing #include.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- jsc.cpp:
- 8:39 PM Changeset in webkit [49369] by
-
- 18 edits2 adds in trunk
Ask the History Delegate to populate the visited links hash.
<rdar://problem/7285293> and https://webkit.org/b/29904
Reviewed by Dan Bernstein.
WebKit/mac:
- History/WebHistory.mm:
(+[WebHistory _removeAllVisitedLinks]):
- History/WebHistoryPrivate.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::populateVisitedLinks):
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebDelegateImplementationCaching.mm:
(CallHistoryDelegate):
- WebView/WebHistoryDelegate.h:
- WebView/WebView.mm:
(-[WebView _cacheHistoryDelegateImplementations]):
(-[WebView addVisitedLinks:]):
- WebView/WebViewPrivate.h:
WebKitTools:
Add the ability for LayoutTestController to clear all visited links.
Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(removeAllVisitedLinksCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::removeAllVisitedLinks):
- DumpRenderTree/mac/HistoryDelegate.mm:
(-[HistoryDelegate populateVisitedLinksForWebView:]):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::removeAllVisitedLinks):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::removeAllVisitedLinks):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::removeAllVisitedLinks):
LayoutTests:
- http/tests/globalhistory/history-delegate-basic-visited-links-expected.txt: Added.
- http/tests/globalhistory/history-delegate-basic-visited-links.html: Added.
- 8:37 PM Changeset in webkit [49368] by
-
- 2 edits in trunk/JavaScriptCore
Tiger build fix: initialize variable whose initialization the compiler
can't otherwise figure out.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
- 8:35 PM Changeset in webkit [49367] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix: updated exports.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 8:29 PM Changeset in webkit [49366] by
-
- 2 edits in trunk/JavaScriptCore
Tiger build fix: fixed file name case.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- JavaScriptCore.xcodeproj/project.pbxproj:
- 8:22 PM Changeset in webkit [49365] by
-
- 22 edits in trunk/JavaScriptCore
At long last, I pronounce the death of AllInOneFile.cpp.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
Reviewed by Maciej Stachowiak.
SunSpider reports a 1.01x speedup.
- AllInOneFile.cpp: Removed.
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.xcodeproj/project.pbxproj: Added missing project files
to compilation stages.
- parser/Grammar.y:
- parser/Lexer.cpp:
- parser/Lexer.h:
(JSC::jscyylex):
- runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
- runtime/Collector.h:
- runtime/JSCell.cpp:
(JSC::JSCell::operator new):
- runtime/JSCell.h:
(JSC::JSCell::operator new):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::operator new):
- runtime/JSNumberCell.h:
(JSC::JSNumberCell::operator new):
- runtime/JSString.cpp:
- runtime/JSString.h:
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):
- runtime/RegExpConstructor.cpp:
- runtime/RegExpConstructor.h:
(JSC::RegExpConstructorPrivate::RegExpConstructorPrivate):
(JSC::RegExpConstructorPrivate::lastOvector):
(JSC::RegExpConstructorPrivate::tempOvector):
(JSC::RegExpConstructorPrivate::changeLastOvector):
(JSC::RegExpConstructor::performMatch):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
- yarr/RegexJIT.cpp:
- yarr/RegexJIT.h:
(JSC::Yarr::executeRegex): Inlined a few things that Shark said
were hot, on the presumption that AllInOneFile.cpp used to inline them
automatically.
- 8:13 PM Changeset in webkit [49364] by
-
- 8 edits in branches/safari-4-branch/JavaScriptCore
Merge r48582.
- 8:07 PM Changeset in webkit [49363] by
-
- 4 edits in branches/safari-4-branch/JavaScriptCore
Merge r47605.
- 8:07 PM Changeset in webkit [49362] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge r47604.
- 8:07 PM Changeset in webkit [49361] by
-
- 6 edits in branches/safari-4-branch/JavaScriptCore
Merge r47601.
- 8:07 PM Changeset in webkit [49360] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r47474.
- 7:54 PM Changeset in webkit [49359] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge r48830.
- 7:54 PM Changeset in webkit [49358] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46706.
- 7:54 PM Changeset in webkit [49357] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge r46705.
- 7:54 PM Changeset in webkit [49356] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46704.
- 7:54 PM Changeset in webkit [49355] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46703.
- 7:54 PM Changeset in webkit [49354] by
-
- 5 edits in branches/safari-4-branch/JavaScriptCore
Merge r46702.
- 7:54 PM Changeset in webkit [49353] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46701.
- 7:54 PM Changeset in webkit [49352] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge r46610.
- 7:54 PM Changeset in webkit [49351] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge r46601.
- 7:54 PM Changeset in webkit [49350] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge r46599.
- 7:54 PM Changeset in webkit [49349] by
-
- 63 edits3 adds in branches/safari-4-branch
Merge r46598.
- 7:53 PM Changeset in webkit [49348] by
-
- 5 edits in branches/safari-4-branch/JavaScriptCore
Merge r46438.
- 7:53 PM Changeset in webkit [49347] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46347.
- 7:53 PM Changeset in webkit [49346] by
-
- 13 edits in branches/safari-4-branch/JavaScriptCore
Merge r46247.
- 7:53 PM Changeset in webkit [49345] by
-
- 5 edits3 adds in branches/safari-4-branch
Merge r46210.
- 7:53 PM Changeset in webkit [49344] by
-
- 6 edits in branches/safari-4-branch/JavaScriptCore
Merge r46209.
- 7:53 PM Changeset in webkit [49343] by
-
- 9 edits2 adds in branches/safari-4-branch/JavaScriptCore
Merge r46202.
- 7:53 PM Changeset in webkit [49342] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46187.
- 7:53 PM Changeset in webkit [49341] by
-
- 2 edits1 add in branches/safari-4-branch/JavaScriptCore
Merge r46057.
- 7:53 PM Changeset in webkit [49340] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r45933.
- 7:53 PM Changeset in webkit [49339] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r45918.
- 7:53 PM Changeset in webkit [49338] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r45904.
- 7:53 PM Changeset in webkit [49337] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r45903.
- 7:10 PM Changeset in webkit [49336] by
-
- 4 edits in trunk/WebKitTools
2009-10-08 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Roben.
The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
the OLE drag-and-drop return value like the function it emulates. Currently,
UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
whether the drag-and-drop operation was successful or was cancelled.
This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
return value according to whether the drop operation was successful or not.
- DumpRenderTree/win/EventSender.cpp: (doMouseUp): Added parameter oleDragAndDropReturnValue. (replaySavedEvents): Ditto.
- DumpRenderTree/win/EventSender.h:
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
- 4:49 PM Changeset in webkit [49335] by
-
- 10 edits in trunk/JavaScriptCore
Rolled out 49331 because it still doesn't build on Windows
- 4:43 PM Changeset in webkit [49334] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: added missing #include.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- interpreter/CallFrame.cpp:
- 4:35 PM Changeset in webkit [49333] by
-
- 3 edits1 copy in trunk
Windows build fix: added missing #include.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- runtime/PropertyNameArray.h:
WebCore:
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- ForwardingHeaders/runtime/StructureChain.h: Copied from WebCore/ForwardingHeaders/runtime/PropertyNameArray.h.
- 4:29 PM Changeset in webkit [49332] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: added missing #include.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- runtime/NumberPrototype.cpp:
- 4:24 PM Changeset in webkit [49331] by
-
- 8 edits in trunk/JavaScriptCore
Migrated some code that didn't belong out of Structure.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
Reviewed by Sam Weinig.
SunSpider says maybe 1.03x faster.
- runtime/JSCell.h: Nixed Structure::markAggregate, and made marking of
a Structure's prototype the direct responsility of the object using it.
(Giving Structure a mark function was misleading because it implied that
all live structures get marked during GC, when they don't.)
- runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
(JSC::JSGlobalObject::markChildren): Added code to mark prototypes stored
on the global object. Maybe this wasn't necessary, but now we don't have
to wonder.
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getEnumerableNamesFromClassInfoTable):
- runtime/JSObject.h:
(JSC::JSObject::markChildrenDirect):
- runtime/PropertyNameArray.h:
- runtime/Structure.cpp:
- runtime/Structure.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache): Moved property name gathering code
from Structure to JSObject because having a Structure iterate its JSObject
was a layering violation. A JSObject is implemented using a Structure; not
the other way around.
- 3:45 PM Changeset in webkit [49330] by
-
- 13 edits in trunk/WebCore
Revert 49329: broke Windows Debug (Build)
- 3:31 PM Changeset in webkit [49329] by
-
- 13 edits in trunk/WebCore
2009-10-08 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Currently, Skia clip paths are 1-bit. This patch makes our path
clipping anti-aliased for non-canvas drawing.
http://code.google.com/p/chromium/issues/detail?id=5927
https://bugs.webkit.org/show_bug.cgi?id=28820
http://www.imperialviolet.org/2009/09/02/anti-aliased-clipping.html
Already covered by layout tests. New baselines will be needed in the
Chromium tree.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clip):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipPath):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::clipPathAntiAliased): (PlatformContextSkia::restore): (PlatformContextSkia::applyAntiAliasedClipPaths):
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::canvasClip):
- 3:25 PM Changeset in webkit [49328] by
-
- 9 edits in trunk/JavaScriptCore
Rolled out r49322 and friends because they killed the build
- 3:14 PM Changeset in webkit [49327] by
-
- 2 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30237>.
DOM Content and Load lines aren't shown if a page is loaded when the inspector is up.
Reviewed by Timothy Hatcher.
Make sure to call update script object if we have an InspectorFrontend to
call it on when we get one of the new events.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::mainResourceFiredDOMContentEvent):
(WebCore::InspectorController::mainResourceFiredLoadEvent):
- 3:11 PM Changeset in webkit [49326] by
-
- 2 edits in trunk/WebCore
Build fix: updated for removal of Structure::markAggregate().
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::markChildren):
- 3:08 PM Changeset in webkit [49325] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Removed some conflict markers from the ChangeLog
- 3:08 PM Changeset in webkit [49324] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: Added missing #include.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-08
- runtime/JSGlobalData.h:
- 3:02 PM Changeset in webkit [49323] by
-
- 8 edits in trunk/JavaScriptCore
Take one branch instead of two to test for JSValue().
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-01
Reviewed by Sam Weinig.
1.1% SunSpider speedup.
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_create_arguments):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.
- runtime/JSValue.cpp:
(JSC::JSValue::description): Added support for dumping the new empty value,
and deleted values, in debug builds.
- runtime/JSValue.h:
(JSC::JSValue::JSValue()): Construct JSValue() with the empty value tag.
(JSC::JSValue::JSValue(JSCell*)): Convert null pointer to the empty value
tag, to avoid having two different c++ versions of null / empty.
(JSC::JSValue::operator bool): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.
- 2:42 PM Changeset in webkit [49322] by
-
- 4 edits in trunk/WebCore
Make AtomicString create its StringImpl via create(), not the constructor,
so it gets allocated in a single heap block, saving memory and CPU cycles.
This eliminates two StringImpl constructors, making the remaining ones
unambiguous, so the "AdoptBuffer" parameter is no longer needed.
Added const attribute to UChar* in StringImpl constructor, eliminating the
need for several const_casts in calls to it.
StringImpl also unfriends AtomicString (OMG drama!!!)
https://bugs.webkit.org/show_bug.cgi?id=30141
Patch by Jens Alfke <snej@chromium.org> on 2009-10-08
Reviewed by Darin Adler.
- platform/text/AtomicString.cpp:
(WebCore::CStringTranslator::translate): Call StringImpl::create().
(WebCore::UCharBufferTranslator::translate): Ditto.
(WebCore::HashAndCharactersTranslator::translate): Ditto.
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl): Remove unnecessary AdoptBuffer param.
(WebCore::StringImpl::adopt): Ditto.
(WebCore::StringImpl::createUninitialized): Ditto.
(WebCore::StringImpl::create): Ditto.
(WebCore::StringImpl::crossThreadString): Ditto.
- platform/text/StringImpl.h:
(WebCore::StringImpl::setHash): Used by AtomicString when creating StringImpls.
- 2:27 PM Changeset in webkit [49321] by
-
- 22 edits in trunk/LayoutTests
2009-10-08 Aaron Boodman <aa@chromium.org>
Reviewed by Eric Seidel.
r49278 added support for reusing isolated worlds, and the
corresponding change to Chromium's LayoutTestController changed
to expect two arguments. The first argument is the world that
the script should run in.
This change fixes the tests by updating them all to pass 0
for the world id. The specific world id used for these tests
doesn't really matter because they don't test world interaction.
- http/tests/security/isolatedWorld/all-window-properties.html:
- http/tests/security/isolatedWorld/all-window-prototypes.html:
- http/tests/security/isolatedWorld/body-properties.html:
- http/tests/security/isolatedWorld/body-prototype.html:
- http/tests/security/isolatedWorld/click-event.html:
- http/tests/security/isolatedWorld/document-open.html:
- http/tests/security/isolatedWorld/document-properties.html:
- http/tests/security/isolatedWorld/document-prototype.html:
- http/tests/security/isolatedWorld/global-variables.html:
- http/tests/security/isolatedWorld/image-properties.html:
- http/tests/security/isolatedWorld/image-prototype.html:
- http/tests/security/isolatedWorld/location-properties.html:
- http/tests/security/isolatedWorld/location-prototype.html:
- http/tests/security/isolatedWorld/number-prototype.html:
- http/tests/security/isolatedWorld/object-prototype.html:
- http/tests/security/isolatedWorld/storage-properties.html:
- http/tests/security/isolatedWorld/storage-prototype.html:
- http/tests/security/isolatedWorld/string-prototype.html:
- http/tests/security/isolatedWorld/window-properties.html:
- http/tests/security/isolatedWorld/window-setTimeout-function.html:
- http/tests/security/isolatedWorld/window-setTimeout-string.html:
- 2:24 PM Changeset in webkit [49320] by
-
- 10 edits in trunk
WebCore: Remove the shouldLoadMediaElementURL frame loader client function.
Reviewed by Sam Weinig.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::willLoadMediaElementURL):
WebKit/mac: Remove the shouldLoadMediaElementURL implementation.
Reviewed by Sam Weinig.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebPolicyDelegatePrivate.h:
WebKit/win: Remove the shouldLoadMediaElementURL implementation.
Reviewed by Sam Weinig.
- Interfaces/IWebPolicyDelegatePrivate.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::shouldUsePluginDocument):
- WebCoreSupport/WebFrameLoaderClient.h:
- 2:19 PM Changeset in webkit [49319] by
-
- 2 edits in trunk/WebCore
SVGURIReference Build problem for V8. An additional stale reference to SVGURIReference bindings
which wasn't exposed until a clean build.
https://bugs.webkit.org/show_bug.cgi?id=30217
Patch by John Gregg <johnnyg@google.com> on 2009-10-08
Reviewed by Dimitri Glazkov.
No new tests, just a build fix.
- bindings/v8/V8Index.cpp:
- 2:12 PM Changeset in webkit [49318] by
-
- 2 edits in trunk/WebKitTools
2009-10-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Added support for a parameter setting the button that was
pressed in the mouseDown function.
https://bugs.webkit.org/show_bug.cgi?id=30220
- WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
- 2:12 PM Changeset in webkit [49317] by
-
- 2 edits in trunk/WebCore
2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Sort XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 2:05 PM Changeset in webkit [49316] by
-
- 2 edits in trunk
2009-10-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Added a line to the bottom of the expected result to match
the output of the test.
https://bugs.webkit.org/show_bug.cgi?id=30220
- LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste- expected.txt:
- 1:57 PM Changeset in webkit [49315] by
-
- 3 edits1 add in trunk/WebCore
2009-10-08 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
unselectable resources in resource panel
https://bugs.webkit.org/show_bug.cgi?id=30079
manual test added
Also changed the way DnD for resources in the Resources panel is
handled.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach): (WebInspector.ResourceSidebarTreeElement.prototype.ondragstart):
- manual-tests/inspector/duplicate-resource-urls.html: Added.
- 1:27 PM Changeset in webkit [49314] by
-
- 3 edits in trunk/WebCore
Fixes <http://webkit.org/b/30233>
Local Storage and Cookies show Blank Titles on Local Files.
Reviewed by Timothy Hatcher.
If a local storage or cookies sidebar item has no domain, set the
title to "Local Files", because that is what it represents.
- English.lproj/localizedStrings.js:
- inspector/front-end/StoragePanel.js:
(WebInspector.DOMStorageSidebarTreeElement.prototype.get mainTitle):
(WebInspector.CookieSidebarTreeElement.prototype.get mainTitle):
(WebInspector.CookieSidebarTreeElement.prototype.set mainTitle):
- 1:03 PM Changeset in webkit [49313] by
-
- 2 edits in trunk/WebCore
Fix failing media layout tests. Don't make beforeload block loads of objects that aren't in the
document, since video/audio (and images eventually too) can load when not in the document yet.
Reviewed by Oliver Hunt.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::dispatchBeforeLoadEvent):
- 12:59 PM Changeset in webkit [49312] by
-
- 19 edits in trunk
2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
Move SVGFitToViewBox ANIMATED_* macros in classes that inherit from it
https://bugs.webkit.org/show_bug.cgi?id=30230
This patch also devirtualizes viewBoxToViewTransform(), is it's superflous.
viewBoxToViewTransform() is now a simple static heper function in SVGFitToViewBox.
As a result, the SVGSVGElement::viewBoxToViewTransform() function now resuses the same logic.
As side-effect this patch fixes svg/custom/linking-a-03-b-transform.svg, the return
statement in SVGSVGElement::viewBoxToViewTransform() was clearly wrong.
- 12:03 PM Changeset in webkit [49311] by
-
- 2 edits in trunk/WebCore
Correct a typo that fixes the resizing of columns in Cookie view when you
resize the Inspector window.
Reviewed by Jon Honeycutt.
- inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype.resize):
- 10:43 AM Changeset in webkit [49310] by
-
- 2 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=29811>
Text in Inspector's Styles gear menu is invisible.
Reviewed by Adam Roben.
Adds a style rule for the option text and hr's in the gear menu,
to prevent them from being transparent.
- inspector/front-end/inspector.css:
- 10:34 AM Changeset in webkit [49309] by
-
- 3 edits in trunk/WebCore
Fix build problem with SVGURIReference in V8.
https://bugs.webkit.org/show_bug.cgi?id=30217
Patch by John Gregg <johnnyg@google.com> on 2009-10-08
Reviewed by David Levin.
No new tests, just a build fix.
- WebCore.gypi:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- 10:26 AM Changeset in webkit [49308] by
-
- 2 edits2 adds in trunk
Make beforeload work on <video>/<audio> elements.
Reviewed by Eric Carlson.
Added fast/dom/beforeload/video-before-load.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseMappedAttribute):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::selectNextSourceChild):
- 10:14 AM Changeset in webkit [49307] by
-
- 2 edits in trunk/LayoutTests
2009-10-08 Xan Lopez <xlopez@igalia.com>
Skip another failing test with reference to its bug.
- platform/gtk/Skipped:
- 10:09 AM Changeset in webkit [49306] by
-
- 61 edits in trunk/WebCore
2009-10-08 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
Move SVGExternalResourcesRequired ANIMATED_* macros in classes that inherit from it
https://bugs.webkit.org/show_bug.cgi?id=30218
The long term goal is to kill the need for the virtual contextElement() function in SVG code.
No change in functionality, thus no new tests.
- 9:11 AM Changeset in webkit [49305] by
-
- 7 edits in trunk
Make IWebInspectorPrivate be accessed in a more standard way
Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
accessed in a more standard way
Reviewed by John Sullivan and Tim Hatcher.
WebKit/win:
IWebViewPrivate::inspectorPrivate has been removed. Callers should
instead use IWebViewPrivate::inspector and then use QueryInterface to
get the IWebInspectorPrivate interface. This matches how our other COM
classes work.
- Interfaces/IWebViewPrivate.idl: Removed inspectorPrivate.
- WebInspector.cpp:
(WebInspector::QueryInterface): Support querying to
IWebInspectorPrivate.
- WebView.cpp:
- WebView.h:
Removed inspectorPrivate.
WebKitTools:
Use QueryInterface to get IWebInspectorPrivate
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::evaluateInWebInspector): Get the IWebInspector
by calling IWebViewPrivate::inspector, then use QueryInterface to get
to the IWebInspectorPrivate interface.
- 8:38 AM Changeset in webkit [49304] by
-
- 2 edits in trunk/WebKit/win
Move the new IWebViewPrivate::inspectorPrivate function after all functions that existed when Safari 4.0.3 was released
Fixes <http://webkit.org/b/30085> REGRESSION (r49091): run-safari
crashes in Safari.dll
Reviewed by John Sullivan.
- Interfaces/IWebViewPrivate.idl: Moved inspectorPrivate to the end of
the interface, so it won't modify the vtable that Safari 4.0.3 sees.
- 8:28 AM Changeset in webkit [49303] by
-
- 2 edits in trunk/WebCore
2009-10-08 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
SVG feComposite: operator over mixes up inputs
https://bugs.webkit.org/show_bug.cgi?id=30205
SVG feComposite operator over mixed up the inputs.
The pixel-test svg/filters/feComposite.svg can already test this.
No new test result is needed as long as filters are disabled.
- platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
- 8:15 AM Changeset in webkit [49302] by
-
- 2 edits in trunk/LayoutTests
2009-10-08 Xan Lopez <xlopez@igalia.com>
Skip flakey transition test.
- platform/gtk/Skipped:
- 7:53 AM Changeset in webkit [49301] by
-
- 33 edits in trunk/WebCore
Reviewed by George Staikos.
Move SVGURIReference ANIMATED_* macros in classes that inherit from it
https://bugs.webkit.org/show_bug.cgi?id=30184
The long term goal is to kill the need for the virtual contextElement() function in SVG code.
No change in functionality, thus no new tests.
- 7:44 AM Changeset in webkit [49300] by
-
- 2 edits in trunk/WebCore
2009-10-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Re-add the QApplication::syncX() line for plugin windows removed
by r49169. Also changed the location of the sync just after the
creation instead of just before sending it to the plugin.
https://bugs.webkit.org/show_bug.cgi?id=25053
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::platformStart):
- 7:09 AM Changeset in webkit [49299] by
-
- 9 edits in trunk
Expose origin whitelisting in the WebKit API on Windows
Fixes <http://webkit.org/b/30185>.
Reviewed by Eric Seidel.
WebKit/win:
- Interfaces/IWebViewPrivate.idl: Added whiteListAccessFromOrigin and
resetOriginAccessWhiteLists, to match the Mac SPI.
- WebView.cpp:
(WebView::whiteListAccessFromOrigin):
(WebView::resetOriginAccessWhiteLists):
- WebView.h:
Added. These just call through to SecurityOrigin.
WebKitTools:
Implement DRT support for origin whitelisting
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting): Reset any origin
whitelist, to match Mac DRT.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::whiteListAccessFromOrigin): Call through to
IWebViewPrivate::whiteListAccessFromOrigin.
LayoutTests:
Start running origin whitelist tests on Windows
- platform/win/Skipped:
- 7:09 AM Changeset in webkit [49298] by
-
- 2 edits in trunk/WebCore
2009-10-08 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Inspector: NodeLists Don't Display Well in the Console
https://bugs.webkit.org/show_bug.cgi?id=28061
- inspector/front-end/InjectedScript.js: (Object.type):
- 6:29 AM Changeset in webkit [49297] by
-
- 2 edits in trunk/LayoutTests
2009-10-08 Xan Lopez <xlopez@igalia.com>
Fix typo in skipped test.
- platform/gtk/Skipped:
- 6:25 AM Changeset in webkit [49296] by
-
- 2 edits in trunk/WebCore
2009-10-08 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Windowless plugins: Remove unnecessary XSync for opaque mode.
The reason for the XSync was that the plugin would not know about the
Drawable. It turns out that the real reason behind this is that even
though XCreatePixmap returns a handle, this id is unknown to the server
until we flush the connection.
So, move the XSync to right after we create the Pixmap.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint):
- 6:14 AM Changeset in webkit [49295] by
-
- 2 edits in trunk/LayoutTests
2009-10-08 Xan Lopez <xlopez@igalia.com>
Skip editing/selection/home-end.html, since it seems to be
somewhat broken. See https://bugs.webkit.org/show_bug.cgi?id=30208
for details.
- platform/gtk/Skipped:
- 6:09 AM Changeset in webkit [49294] by
-
- 2 edits in trunk/WebKit/qt
Part of testOptionalJSObjects autotest was marked as "expect to fail".
Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-10-08
Reviewed by Simon Hausmann.
Two places in tst_QWebPage::testOptionalJSObjects were marked as
expected to fail. The problem concern checking if a feature is enabled
or disabled. According to discussion on webkit dev mailing list
a disabled feature should be invisible from java script level, but
there are exceptions from the rule. So we decided to disable the test
for now.
https://bugs.webkit.org/show_bug.cgi?id=29867
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::testOptionalJSObjects):
- 2:18 AM Changeset in webkit [49293] by
-
- 2 edits in trunk/JavaScriptCore
Fix for JIT'ed op_call instructions (evals, constructs, etc.)
when !ENABLE(JIT_OPTIMIZE_CALL) && USE(JSVALUE32_64)
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-10-08
Reviewed by Gavin Barraclough.
https://bugs.webkit.org/show_bug.cgi?id=30201
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
Oct 7, 2009:
- 11:57 PM Changeset in webkit [49292] by
-
- 2 edits in trunk/WebCore
2009-10-07 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Fixes an issue where performing a non DHTML drag-and-drop operation
does not work as expected. For instance, dragging some selected text
to an external application, such as TextEdit.
This issue was a regression that arose from patching bug #30107.
This change is covered by the manual test:
drag-out-of-background-window.html
- page/DragController.cpp: (WebCore::DragController::startDrag): When performing a non-DHTML drag operation then default to drag operations DragOperationGeneric and DragOperationCopy according to similar functionality removed when fixing bug #30107, see: http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebHTMLView.mm?rev=48526#L3430
- 11:29 PM Changeset in webkit [49291] by
-
- 2 edits in trunk/WebCore
2009-10-07 Xan Lopez <xlopez@igalia.com>
Fix more breakage in the GTK+ build.
- GNUmakefile.am:
- 11:17 PM Changeset in webkit [49290] by
-
- 8 edits4 adds2 deletes in trunk/WebCore
2009-10-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move PolicyChecker to it's own file
https://bugs.webkit.org/show_bug.cgi?id=30193
This is just moving code around and re-naming things.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/PolicyCallback.cpp: Added. (WebCore::PolicyCallback::PolicyCallback): (WebCore::PolicyCallback::~PolicyCallback): (WebCore::PolicyCallback::clear): (WebCore::PolicyCallback::set): (WebCore::PolicyCallback::call): (WebCore::PolicyCallback::clearRequest): (WebCore::PolicyCallback::cancel):
- loader/PolicyCallback.h: Added. (WebCore::PolicyCallback::request):
- loader/PolicyCheck.cpp: Removed.
- loader/PolicyCheck.h: Removed.
- 11:13 PM Changeset in webkit [49289] by
-
- 7 edits in trunk/WebCore
2009-10-07 Joel Stanley <joel@jms.id.au>
Reviewed by Mark Rowe.
Include <limits> for std::numeric_limits. Required by gcc-4.4
https://bugs.webkit.org/show_bug.cgi?id=30197
- html/canvas/CanvasByteArray.h:
- html/canvas/CanvasIntArray.h:
- html/canvas/CanvasShortArray.h:
- html/canvas/CanvasUnsignedByteArray.h:
- html/canvas/CanvasUnsignedIntArray.h:
- html/canvas/CanvasUnsignedShortArray.h:
- 11:09 PM Changeset in webkit [49288] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-07 Xan Lopez <xlopez@igalia.com>
Fix the GTK+ build.
- webkit/webkitwebpolicydecision.cpp: (webkit_web_policy_decision_use): (webkit_web_policy_decision_ignore): (webkit_web_policy_decision_download):
- 10:30 PM Changeset in webkit [49287] by
-
- 2 edits in trunk/WebKitSite
Fix for https://bugs.webkit.org/show_bug.cgi?id=30196
Change style guidelines for indentation in header files
Reviewed by Dan Bernstein.
- coding/coding-style.html: Don't indent in a namespace in a header file.
- 9:55 PM QtWebKitPerformanceUtilities edited by
- Update pahs. (diff)
- 9:44 PM Changeset in webkit [49286] by
-
- 2 edits in trunk/WebKit/mac
2009-10-07 Simon Fraser <Simon Fraser>
Re-land 49269-49271 since reverting them did not fix the tests.
- WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
- 9:09 PM Changeset in webkit [49285] by
-
- 2 edits in trunk/WebKit/mac
2009-10-07 Simon Fraser <Simon Fraser>
Revert 49269-49271 to see if it fixes test failures on SnowLeopard that do not
reproduce locally.
- WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
- 8:17 PM Changeset in webkit [49284] by
-
- 18 edits in trunk
2009-10-07 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155
Move the policy callback to the policy object.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::callPolicyFunction):
2009-10-07 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155
Move the policy callback to the policy object.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSubmitForm): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2009-10-07 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155
Move the policy callback to the policy object.
- WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): (WebFrame::receivedPolicyDecision): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction):
2009-10-07 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155
Move the policy callback to the policy object.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchWillSubmitForm): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):
2009-10-07 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155
Move the policy callback to the policy object.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::receivedPolicyDecison):
2009-10-07 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155
Move the policy callback to the policy object.
- WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchWillSubmitForm): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNavigationAction):
2009-10-07 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155
This patch separates PolicyChecker from FrameLoader. Loader policy is
in change of managing the FrameLoaderClient callbacks. Ideally, it
shouldn't know anything about FrameLoader, but I couldn't quite remove
all knowledge (although we might be able to do more later). In a
future patch, I'll move PolicyChecker into a separate file.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::PolicyChecker::handleUnimplementablePolicy): (WebCore::PolicyChecker::cannotShowMIMEType): (WebCore::PolicyChecker::PolicyChecker): (WebCore::PolicyChecker::checkNavigationPolicy): (WebCore::PolicyChecker::checkContentPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::stopAllLoaders): (WebCore::PolicyChecker::cancelCheck): (WebCore::PolicyChecker::stopCheck): (WebCore::PolicyChecker::continueAfterContentPolicy): (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::PolicyChecker::checkNewWindowPolicy): (WebCore::PolicyChecker::continueAfterNewWindowPolicy): (WebCore::PolicyChecker::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
- loader/FrameLoader.h: (WebCore::PolicyChecker::loadType): (WebCore::PolicyChecker::setLoadType): (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy): (WebCore::FrameLoader::policy):
- loader/FrameLoaderClient.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 7:28 PM Changeset in webkit [49283] by
-
- 1 edit1 move1 add in trunk/LayoutTests/http/tests/security/isolatedWorld
Not reviewed. Fix layout test missing results.
- 7:04 PM Changeset in webkit [49282] by
-
- 2 edits in trunk/WebKitSite
Add new Windows build prerequisite: Visual Studio 2005 Service Pack 1 ATL Security Update
Reviewed by Mark Rowe.
- building/tools.html:
- 6:52 PM Changeset in webkit [49281] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix: removed no longer exported symbol.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 6:46 PM Changeset in webkit [49280] by
-
- 24 edits2 copies in trunk
JavaScriptCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.
Removed the optional lock from Heap::protect, Heap::unprotect, and friends,
since WebCore no longer uses it.
- JavaScriptCore.exp:
- runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):
- runtime/Collector.h:
WebCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.
Changed callback objects to use a standard helper object. The helper
object ASSERTs that it is deleted on the main thread, so no lock is
required when unprotecting its members. It also centralizes some previously
duplicated code.
Callback objects that might be deleted on a secondary thread use
callOnMainThread to delete their helper objects on the main thread.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCallbackData.cpp: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.
(WebCore::JSCallbackData::deleteData):
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCallbackData.h: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.
(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackData::~JSCallbackData):
(WebCore::JSCallbackData::callback):
- bindings/js/JSCustomPositionCallback.cpp:
(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):
- bindings/js/JSCustomPositionCallback.h:
- bindings/js/JSCustomPositionErrorCallback.cpp:
(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):
- bindings/js/JSCustomPositionErrorCallback.h:
- bindings/js/JSCustomSQLStatementCallback.cpp:
(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::~JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):
- bindings/js/JSCustomSQLStatementCallback.h:
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::~JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.h:
- bindings/js/JSCustomSQLTransactionCallback.cpp:
(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionCallback.h:
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::~JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.h:
- bindings/js/JSCustomVoidCallback.cpp:
(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::~JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):
- bindings/js/JSCustomVoidCallback.h:
- storage/Database.cpp:
(WebCore::Database::Database):
- 5:41 PM Changeset in webkit [49279] by
-
- 3 edits in trunk/WebCore
2009-10-07 Jens Alfke <snej@chromium.org>
Reviewed by Dave Levin.
Fix StringImpl::m_buffer
https://bugs.webkit.org/show_bug.cgi?id=30189
Fix my previous StringImpl patch to avoid using an indefinite-length array member,
since MSVC doesn't like it. Instead, go back to offsetting by sizeof(StringImpl).
- platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::createUninitialized):
- platform/text/StringImpl.h: (WebCore::StringImpl::bufferIsInternal):
- 5:07 PM Changeset in webkit [49278] by
-
- 12 edits3 adds in trunk
Update isolated worlds under v8 to support world reuse.
https://bugs.webkit.org/show_bug.cgi?id=30145
Patch by Aaron Boodman <aa@chromium.org> on 2009-10-07
Reviewed by Adam Barth.
WebCore:
- bindings/v8/ScriptController.cpp:
Replace evaluateInNewIsolatedWorld() withe evaluateInIsolatedWorld(id).
(WebCore::ScriptController::evaluateInIsolatedWorld):
- bindings/v8/ScriptController.h: Ditto.
- bindings/v8/V8Proxy.cpp: Ditto.
(WebCore::V8Proxy::~V8Proxy): Dittio.
(WebCore::V8Proxy::evaluateInIsolatedWorld): Ditto.
- bindings/v8/V8Proxy.h: Ditto.
- bindings/v8/V8IsolatedWorld.cpp:
Add support for controlling lifetime of a world, rather than relying on GC.
(WebCore::V8IsolatedWorld::contextWeakReferenceCallback): Ditto.
(WebCore::V8IsolatedWorld::V8IsolatedWorld): Ditto.
(WebCore::V8IsolatedWorld::destroy): Ditto.
- bindings/v8/V8IsolatedWorld.h: Ditto.
LayoutTests:
- http/tests/security/isolatedWorld/iframe.html: Added.
- http/tests/security/isolatedWorld/world-reuse-expected.txt: Added.
- http/tests/security/isolatedWorld/world-reuse.html: Added.
- 5:05 PM Changeset in webkit [49277] by
-
- 8 edits2 adds in trunk
Send title changes to the global history delegate.
<rdar://problem/7285293> and https://webkit.org/b/29904
Reviewed by Darin Adler.
WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::setTitle):
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebHistoryDelegate.h:
- WebView/WebView.mm:
(-[WebView _cacheHistoryDelegateImplementations]):
WebKitTools:
- DumpRenderTree/mac/HistoryDelegate.mm:
(-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
LayoutTests:
- http/tests/globalhistory/history-delegate-basic-title-expected.txt: Added.
- http/tests/globalhistory/history-delegate-basic-title.html: Added.
- 4:55 PM Changeset in webkit [49276] by
-
- 1 edit in trunk/WebCore/platform/text/StringImpl.cpp
Well that was wrong, undo-ing previous build fix.
- 4:50 PM Changeset in webkit [49275] by
-
- 1 edit in trunk/WebCore/platform/text/StringImpl.cpp
Hopefully the rest of the Windows build fix.
- 4:33 PM Changeset in webkit [49274] by
-
- 2 edits in trunk/WebCore
Build fix for http://trac.webkit.org/changeset/49272 on Windows
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-07
- platform/text/StringImpl.h:
- 4:20 PM Changeset in webkit [49273] by
-
- 4 edits in trunk/WebKit/mac
Make the setMetadataURL function foolproof by having it remove user info
https://bugs.webkit.org/show_bug.cgi?id=30178
rdar://problem/6544670
Patch by Darin Adler <Darin Adler> on 2009-10-07
Reviewed by John Sullivan.
- Misc/WebNSFileManagerExtras.m:
(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
Call _web_URLByRemovingUserInfo on the passed in URL string after converting
it to a URL, and then convert it back to a string.
- Misc/WebNSURLExtras.h: Added _web_URLByRemovingUserInfo.
- Misc/WebNSURLExtras.mm: Removed unused WebKitURLComponents struct.
(-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Renamed to be
clearer on what this does.
(-[NSURL _webkit_URLByRemovingFragment]): Changed to call new name.
(-[NSURL _webkit_URLByRemovingResourceSpecifier]): Ditto.
(-[NSURL _web_URLByRemovingComponentAndSubsequentCharacter:]): Added.
(-[NSURL _web_URLByRemovingUserInfo]): Added.
- 3:41 PM Changeset in webkit [49272] by
-
- 3 edits in trunk/WebCore
2009-10-07 Jens Alfke <snej@chromium.org>
Reviewed by Darin Adler.
Optimization of StringImpl:
- Remove unnecessary m_bufferIsInternal member (saves 4 bytes). Instead, check whether m_data points to just past the end of the object's members.
- copy() and createWithTerminatingNullCharacter() create the string in a single malloc block instead of 2 (saves ~20 bytes and considerable CPU cycles, increases locality).
- Move m_length next to m_hash to save 4 bytes of padding in 64-bit builds.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Re-ordered members. (WebCore::StringImpl::~StringImpl): Change to is-buffer-internal check. (WebCore::StringImpl::createUninitialized): Use new m_buffer member instead of sizeof()
to ensure chars are copied to correct location.
(WebCore::StringImpl::createWithTerminatingNullCharacter): Make sure copy is created
in a single malloc block.
(WebCore::StringImpl::threadsafeCopy): Make sure copy is created in a single malloc block.
(WebCore::StringImpl::crossThreadString): Make sure copy is created in a single malloc block.
(WebCore::StringImpl::sharedBuffer): Change to is-buffer-internal check.
- platform/text/StringImpl.h: (WebCore::StringImpl::startsWith): Just fixed a confusing param name. (WebCore::StringImpl::bufferIsInternal): Changed member var into accessor method. (WebCore::StringImpl::m_data): Repositioned for optimal member packing in 64-bit. (WebCore::StringImpl::m_buffer): Added to provide an explicit location for where internal buffer goes.
- 3:41 PM Changeset in webkit [49271] by
-
- 2 edits in trunk/WebKit/mac
2009-10-07 Simon Fraser <Simon Fraser>
Make Dan Bernstein happy.
- WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
- 3:38 PM Changeset in webkit [49270] by
-
- 2 edits in trunk/WebKit/mac
2009-10-07 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Avoid Obj-C message dispatch when possible by storing accessed objects
in local variables.
- WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
- 3:29 PM Changeset in webkit [49269] by
-
- 2 edits in trunk/WebKit/mac
2009-10-07 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Animation stalls for a few seconds partway through
https://bugs.webkit.org/show_bug.cgi?id=30182
Make sure that we only call -disableScreenUpdatesUntilFlush when a window
update is actually going to happen, otherwise screen updates are disabled
for too long.
- WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
- 3:26 PM Changeset in webkit [49268] by
-
- 3 edits1 add in trunk
2009-10-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30102
And
<rdar://problem/5015957>
Fixes an issue (in the Windows build) where the cursor does not change to the
not-allowed cursor when the drag-and-drop operation is not allowed.
The allowed effects in WebDragClient::startDrag are hard-coded to be
DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of
allowed drop effects should be determined by the allowed operations of the
drag source.
We cannot test this using DRT because DRT looks at the programmatic drop
cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
That is, there is a discrepancy in the Windows build between the Windows API-based
drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer
to determine the cursor, a manual test is needed.
- WebCoreSupport/WebDragClient.cpp: (draggingSourceOperationMaskToDragCursors): Added method. (WebDragClient::startDrag):
2009-10-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30102
And
<rdar://problem/5015957>
Manual test to confirm that the not-allowed cursor is shown for an
invalid drag-and-drop operation.
We cannot test this using DRT because of a discrepancy between the Windows
API-based drop effect and the WebKit drop effect. See bug #24731 for more
details.
- manual-tests/drag-cursor-notallowed.html: Added.
- 3:22 PM Changeset in webkit [49267] by
-
- 2 edits in trunk/WebKitTools
2009-10-07 Adam Barth <abarth@webkit.org>
Unreviewed. Remove some folks from committers.py who were listed on
the WebKit Team wiki page but who weren't actually listed as commit+.
At some point, we should coorelate this list with the committers
mailing list.
- Scripts/modules/committers.py:
- 3:16 PM Changeset in webkit [49266] by
-
- 2 edits in trunk/WebCore
Fix the build.
- 3:10 PM Changeset in webkit [49265] by
-
- 2 edits in trunk/WebKitTools
2009-10-07 Adam Barth <abarth@webkit.org>
Unreviewed. Import a bunch of committers from the WebKit Team page on
the wiki into committers.py.
- Scripts/modules/committers.py:
- 2:56 PM Changeset in webkit [49264] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-07 Evan Martin <evan@chromium.org>
Reviewed by Adam Roben.
Windows-specific baselines for some new tests.
- platform/win/fast/css/large-number-round-trip-expected.txt: Added.
- platform/win/fast/css/opacity-float-expected.txt: Copied from LayoutTests/fast/css/opacity-float-expected.txt.
- 2:55 PM Changeset in webkit [49263] by
-
- 18 edits in trunk/WebCore
2009-10-07 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Fixes <http://webkit.org/b/30104>.
Inspector should show cookies of sub-resources on the page.
This function implements showing cookies for all sub-resources of a page.
When the page is loaded, it populates the Storage Panel with a list of all
domains that were loaded as part of the full page load (iframes, ads, etc).
When the user selects one of the domains, the inspector calls back into the
controller, and the controller combines all of the cookies from that domain
into a list, and sends that list is sent back to the controller to render.
A domain now needs to be passed into CookieItemsView, and CookieSidebarTreeElement.
As a result of a previous patch, we now have detailed cookie information for
both Windows on CFNetwork and Mac. Additionally, this patch provides deleteCookie
support on Windows.
- bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
- bindings/js/ScriptObject.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getCookies): (WebCore::InspectorBackend::deleteCookie):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::buildArrayForCookies): (WebCore::InspectorController::buildObjectForCookie): (WebCore::InspectorController::deleteCookie):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addCookieDomainForDocument):
- inspector/InspectorFrontend.h:
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
- inspector/front-end/DOMAgent.js: (WebInspector.Cookies.getCookiesAsync):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addCookieDomain): (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect):
- inspector/front-end/inspector.js: (WebInspector.addCookieDomain):
- platform/Cookie.h: (WebCore::CookieHash::hash): (WebCore::CookieHash::equal): (WTF::):
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::deleteCookie):
- 2:50 PM Changeset in webkit [49262] by
-
- 3 edits in trunk/WebCore
2009-10-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add ScriptObject::set(const char*, unsigned).
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
- bindings/v8/ScriptObject.h:
- 2:49 PM LayoutAndRendering edited by
- (diff)
- 2:47 PM Changeset in webkit [49261] by
-
- 2 edits in trunk/WebKitTools
2009-10-07 Adam Barth <abarth@webkit.org>
Unreviewed. Added Aaron Boodman to committers.py.
- Scripts/modules/committers.py:
- 2:46 PM LayoutAndRendering edited by
- (diff)
- 2:46 PM LayoutAndRendering created by
- 2:41 PM WikiStart edited by
- added link to new layout and rendering page (diff)
- 1:51 PM Changeset in webkit [49260] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix for Windows (Cairo).
Provide implementation of new BitmapImage::create that was
added in @r49060.
- platform/graphics/win/ImageCairoWin.cpp:
- 1:25 PM Changeset in webkit [49259] by
-
- 9 edits2 adds in trunk/WebCore
2009-10-07 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Refactor RenderThemeChromiumMac and RenderThemeChromiumSkia to render media controls using GraphicsContext.
Design was based on existing RenderMediaControls.cpp used by RenderThemeSafari/Win.
Covered by existing layout tests as no new functionality was introduced.
- WebCore.gypi: Added RenderMediaControlsChromium.cpp/h.
- css/mediaControlsChromium.css: Tweaked media slider position and border style.
- rendering/MediaControlElements.cpp: (WebCore::toParentMediaElement): Taken from RenderMediaControls. (WebCore::MediaControlElement::rendererIsNeeded): Don't call shouldRenderMediaControlPart() if element has no appearance. (WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
- rendering/RenderMediaControls.cpp: Moved parentMediaElement() to MediaControlElements.
- rendering/RenderMediaControlsChromium.cpp: Added. (WebCore::platformResource): Helper to load and cache media control image resources. (WebCore::mediaSliderThumbImage): Implementation refactored from RenderThemeChromiumMac/Skia. (WebCore::mediaVolumeSliderThumbImage): Ditto. (WebCore::paintMediaButton): Ditto. (WebCore::paintMediaMuteButton): Ditto. (WebCore::paintMediaPlayButton): Ditto. (WebCore::paintMediaSlider): Ditto. (WebCore::paintMediaSliderThumb): Ditto. (WebCore::paintMediaVolumeSlider): Ditto. (WebCore::paintMediaVolumeSliderThumb): Ditto. (WebCore::paintMediaTimelineContainer): Ditto. (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Ditto. (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Same (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
- rendering/RenderMediaControlsChromium.h: Added.
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): Implementation delegated to RenderMediaControlsChromium. (WebCore::RenderThemeChromiumMac::shouldRenderMediaControlPart): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): Ditto. (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): Ditto.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaControlsBackground): Implementation delegated to RenderMediaControlsChromium. (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Ditto. (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): Ditto. (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): Ditto. (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Ditto.
- 1:03 PM Changeset in webkit [49258] by
-
- 3 edits2 adds in trunk
Make plugins work with beforeload.
Reviewed by Adam Roben.
Added fast/dom/beforeload/flash-before-load.html
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
- rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget):
- 12:10 PM Changeset in webkit [49257] by
-
- 6 edits in trunk/WebKitSite/blog-files/webgl/resources
resized thumbnails
- 11:32 AM Changeset in webkit [49256] by
-
- 2 edits in trunk/WebKit/win
https://bugs.webkit.org/show_bug.cgi?id=30176
<rdar://problem/7281553> Extra information in UA causes problems with gmail
Reviewed by Darin Adler.
- WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space.
- 11:20 AM Changeset in webkit [49255] by
-
- 6 adds in trunk/WebKitSite/blog-files/webgl/resources
added thumbnail images for demos
- 11:10 AM Changeset in webkit [49254] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-07 Evan Martin <evan@chromium.org>
Reviewed by Simon Fraser.
Add a currently-failing test exhibiting the problem in
https://bugs.webkit.org/show_bug.cgi?id=20674:
When converting very large or small numbers back to strings, exponential
notation is used, so a value like 90010000px is returned from
getComputedStyle() as 9.001e+07px.
9.001e+07px does not parse, so such a value cannot be round-tripped.
This is a particular problem with tranformation matrices, which can often
contain very large or small numbers.
(Test written by Simon Fraser; I've just made it a committable patch.)
- fast/css/large-number-round-trip-expected.txt: Added.
- fast/css/large-number-round-trip.html: Added.
- 10:47 AM Changeset in webkit [49253] by
-
- 8 edits3 adds in trunk
2009-10-07 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
Layout test for verifying that LC_NUMERIC setting doesn't affect
the way CSS properties are stringified.
https://bugs.webkit.org/show_bug.cgi?id=18994
- fast/css/opacity-float-expected.txt: Added.
- fast/css/opacity-float.html: Added.
2009-10-07 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
Add API to LayoutTestController for re/setting the system locale.
https://bugs.webkit.org/show_bug.cgi?id=18994
- DumpRenderTree/LayoutTestController.cpp: (setLocaleCallback): (LayoutTestController::staticFunctions): (LayoutTestController::setLocale):
- DumpRenderTree/LayoutTestController.h:
- 10:25 AM Changeset in webkit [49252] by
-
- 2 edits in trunk/WebCore
2009-10-07 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Protect JS listener object from GC while clearing a property on it.
See http://crbug.com/23780.
https://bugs.webkit.org/show_bug.cgi?id=30137
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
- 10:09 AM Changeset in webkit [49251] by
-
- 2 edits in trunk/WebCore
2009-10-07 Zoltan Horvath <zoltan@webkit.org>
Rubber-stamped by Eric Seidel.
Allow custom memory allocation control for WebCore's CachedResourceClient class
https://bugs.webkit.org/show_bug.cgi?id=30165
Inherits CachedResourceClient class from FastAllocBase because (its
child class) CSSFontFaceSource has been instantiated by 'new' in WebCore/css/CSSFontFaceSource.h:46.
- loader/CachedResourceClient.h:
- 10:04 AM Changeset in webkit [49250] by
-
- 2 edits in trunk/WebCore
2009-10-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore's IdentifierRep
https://bugs.webkit.org/show_bug.cgi?id=30159
Inherits IdentifierRep class from FastAllocBase because it has been
instantiated by 'new' in WebCore/bridge/IdentifierRep.cpp:61.
- bridge/IdentifierRep.h:
- 10:00 AM Changeset in webkit [49249] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's IdentifierArena
https://bugs.webkit.org/show_bug.cgi?id=30158
Inherits IdentifierArena class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/parser/ParserArena.cpp:36.
- parser/ParserArena.h:
- 9:59 AM Changeset in webkit [49248] by
-
- 5 edits in trunk/WebCore
2009-10-07 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Fetch pointers to C++ DOM window immediately from holder
object (do not search prototype chain for proper JS wrapper).
https://bugs.webkit.org/show_bug.cgi?id=29031
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createNewContext): (WebCore::V8Proxy::installDOMWindow):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_ACCESS_CHECK):
- 9:49 AM Changeset in webkit [49247] by
-
- 4 edits in trunk/JavaScriptCore
Export DateInstance::info in a way that works on Windows
Fixes <http://webkit.org/b/30171>
fast/dom/Window/window-postmessage-clone.html fails on Windows
Reviewed by Anders Carlsson.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Removed the export of DateInstance::info from here.
- runtime/DateInstance.h: Use JS_EXPORTDATA to export
DateInstance::info, which is the required way of exporting data on
Windows.
- 9:23 AM Changeset in webkit [49246] by
-
- 2 edits in trunk/WebKitTools
2009-10-06 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Jan Alonzo.
[Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
https://bugs.webkit.org/show_bug.cgi?id=29689
Build fix by adding -lfontconfig for DumpRenderTree.
- GNUmakefile.am:
- 8:22 AM Changeset in webkit [49245] by
-
- 4 edits in trunk/WebKit/qt
2009-10-07 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Get rid of useless loadFailed signal in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30166
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_doLoadFinished):
- Api/qgraphicswebview.h:
- QGVLauncher/main.cpp: (MainWindow::init): (MainWindow::loadFinished):
- 8:11 AM Changeset in webkit [49244] by
-
- 2 edits in trunk/WebCore
Fix typo in PluginView::load that was causing cross-origin loads to be allowed
This typo was introduced in the build fix in r49213.
Fixes <http://webkit.org/b/30168> REGRESSION (r49213):
http/tests/plugins/local-geturl-from-remote.html is failing on Windows
Reviewed by Sam Weinig.
- plugins/PluginView.cpp:
(WebCore::PluginView::load): Removed a comma operator that was making
a condition always evaluate to true.
- 7:53 AM Changeset in webkit [49243] by
-
- 2 edits in trunk/WebKitTools
2009-10-07 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
- Scripts/run-webkit-tests:
- 7:06 AM Changeset in webkit [49242] by
-
- 2 edits in trunk/WebCore
Do not create valid QColor's for invalid WebCore::Color's.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-07
Reviewed by Simon Hausmann.
- platform/graphics/qt/ColorQt.cpp:
(WebCore::Color::operator QColor):
- 5:44 AM Changeset in webkit [49241] by
-
- 2 edits in trunk/WebKitTools
2009-10-07 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
"delete" in EventSender is the backspace key, not the delete one.
- DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
- 4:46 AM Changeset in webkit [49240] by
-
- 2 edits in trunk/WebKit/qt
2009-10-07 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
Add a simple rotation effect to QGVLauncher
- QGVLauncher/main.cpp: (MainView::animatedFlip): (MainWindow::animatedFlip): (MainWindow::buildUI):
- 3:58 AM Changeset in webkit [49239] by
-
- 2 edits in trunk/WebCore
2009-10-07 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] Symbian SBSv2 .data segment adress fix
https://bugs.webkit.org/show_bug.cgi?id=30157
RO-section in qtwebkit.dll exceeds allocated space in SBSv2. Move RW-section
base address to start from 0x800000 instead of the toolchain default 0x400000
- WebCore.pro:
- 3:45 AM Changeset in webkit [49238] by
-
- 2 edits in trunk/JavaScriptCore
When enabling or disabling the JIT through .qmake.cache, make sure
to also toggle ENABLE_YARR_JIT.
Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-07
Reviewed by Simon Hausmann.
- JavaScriptCore.pri:
- 3:44 AM Changeset in webkit [49237] by
-
- 2 edits in trunk/WebKit/qt
Doc: Document HTML and status as properties.
Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-10-07
Reviewed by Simon Hausmann.
- Api/qgraphicswebview.cpp:
- 3:42 AM Changeset in webkit [49236] by
-
- 3 edits in trunk/WebKit/qt
Fix qdoc warning about disabled renderHints property
on Symbian.
Patch by Martin Smith <msmith@trolltech.com> on 2009-10-07
Reviewed by Simon Hausmann.
- Api/qwebview.cpp:
- Api/qwebview.h:
- 3:36 AM Changeset in webkit [49235] by
-
- 2 edits in trunk/WebKitTools
2009-10-07 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
getChildrenWithRange expects as last parameter the end index, not
the length of the range. Correct this and clarify the variable
names to reflect how the code works.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::getChildAtIndex):
- 2:32 AM Changeset in webkit [49234] by
-
- 18 edits in trunk/WebCore
2009-10-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Migrate database inspection to the injected script-based schema.
- bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::databaseForId):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::databaseForId): (WebCore::InspectorBackend::selectDatabase): (WebCore::InspectorBackend::getDatabaseTableNames): (WebCore::InspectorBackend::reportDidDispatchOnInjectedScript):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::selectDatabase): (WebCore::InspectorController::databaseForId): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::selectDOMStorage): (WebCore::InspectorController::getDOMStorageResourceForId):
- inspector/InspectorController.h:
- inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind):
- inspector/InspectorDatabaseResource.h: (WebCore::InspectorDatabaseResource::database): (WebCore::InspectorDatabaseResource::id):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::didGetDatabaseTableNames): (WebCore::InspectorFrontend::addDOMStorage):
- inspector/InspectorFrontend.h:
- inspector/front-end/Database.js: (WebInspector.Database): (WebInspector.Database.prototype.get id): (WebInspector.Database.prototype.set name): (WebInspector.Database.prototype.set version): (WebInspector.Database.prototype.set domain): (WebInspector.Database.prototype.getTableNames): (WebInspector.Database.prototype.executeSql):
- inspector/front-end/InjectedScript.js: (InjectedScript.dispatch): (InjectedScript.executeSql): (InjectedScript.executeSql.errorCallback): (InjectedScript.executeSql.queryTransaction):
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.selectDatabase): (WebInspector.StoragePanel.prototype.dataGridForResult):
- inspector/front-end/inspector.js: (WebInspector.addDatabase):
- 1:23 AM Changeset in webkit [49233] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-07 Martin Robinson <martin.james.robinson@gmail.com>
[GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html
https://bugs.webkit.org/show_bug.cgi?id=30121
Clear previous preedit or pending composition before storing new ones.
This can happen when a WebView receives a native keydown event without
a matching keyup event or when preventDefault() is called on DOM keydown
events.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::setPendingComposition): (WebKit::setPendingPreedit): (WebKit::clearPendingIMData): (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged):
- 12:42 AM Changeset in webkit [49232] by
-
- 4 edits in trunk/WebKit
2009-10-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: default to an attached inspector window on Windows (as on Mac).
WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]):
WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindowWithoutNotifications):
- 12:40 AM Changeset in webkit [49231] by
-
- 2 edits in trunk/WebCore
2009-10-07 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins: Disable content propagation for QGraphicsView items
We cannot support content propagation for items in QGraphicsView because
the contents of the backing store might be transformed. So turn it off
if we are not painting on QWidget.
Note that this check will not work for a QWebView in a
QGraphicsProxyWidget, but I guess it's fine. Alternative is to do an
even uglier cast: static_cast painter's paintDevice() to QWidget and
check if it is the viewport() of QGraphicsView.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):
- 12:38 AM Changeset in webkit [49230] by
-
- 2 edits in trunk/LayoutTests
2009-10-07 Xan Lopez <xlopez@igalia.com>
Skip two new tests for which we are missing results.
- platform/gtk/Skipped:
- 12:17 AM Changeset in webkit [49229] by
-
- 3 edits in trunk/LayoutTests
Tidy up postMessage testcase
Reviewed by Gavin Barraclough.
- 12:15 AM Changeset in webkit [49228] by
-
- 2 edits in trunk/WebCore
Fix the Qt build by adding the missing files to the build.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-07
- WebCore.pro:
- 12:10 AM Changeset in webkit [49227] by
-
- 3 edits in trunk/WebCore
2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Fix incorrect convertion of double into int while assigning it to
a float.
- platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
- platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
- 12:10 AM Changeset in webkit [49226] by
-
- 3 edits in trunk/WebCore
2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Fix rounding error issues in height calculation in 64 bits.
Already covered by existing tests.
- platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
- platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
Oct 6, 2009:
- 11:20 PM Changeset in webkit [49225] by
-
- 4 edits8 adds in trunk
2009-10-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Dual lines in css2.1 layout tests do not match:
https://bugs.webkit.org/show_bug.cgi?id=23262
Now we can put a counter node as the next sibling of a reset node.
Re-layout the counter content when the count is updated.
Tests: fast/css/counters/t1204-increment-00-c-o.html
fast/css/counters/t1204-increment-01-c-o.html
- rendering/CounterNode.cpp: (WebCore::CounterNode::recount):
- rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter):
2009-10-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Dual lines in css2.1 layout tests do not match:
https://bugs.webkit.org/show_bug.cgi?id=23262
Now we can put a counter node as the next sibling of a reset node.
Re-layout the counter content when the count is updated.
- fast/css/counters/t1204-increment-00-c-o.html: Added.
- fast/css/counters/t1204-increment-01-c-o.html: Added.
- platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Added.
- platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Added.
- platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
- platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Added.
- platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Added.
- platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
- 10:44 PM Changeset in webkit [49224] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-06 Priit Laes <plaes@plaes.org>
Reviewed by Gavin Barraclough.
Linking fails with "relocation R_X86_64_PC32 against symbol
`cti_vm_throw'"
https://bugs.webkit.org/show_bug.cgi?id=28422
- jit/JITStubs.cpp: Mark cti_vm_throw symbol as PLT-indirect symbol, so it doesn't end up in text segment causing relocation errors on amd64 architecture. Introduced new define SYMBOL_STRING_RELOCATION for such symbols.
- 10:15 PM Changeset in webkit [49223] by
-
- 2 edits in trunk/WebCore
2009-10-06 Xan Lopez <xlopez@igalia.com>
Try to fix the GTK+ build.
- GNUmakefile.am:
- 8:56 PM Changeset in webkit [49222] by
-
- 3 edits in trunk/WebCore
2009-10-06 Adam Barth <abarth@webkit.org>
Reviewed by Adam Barth.
Removed unused member variable from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30146
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader):
- loader/FrameLoader.h:
- 8:45 PM Changeset in webkit [49221] by
-
- 2 edits in trunk/WebCore
A few small/trivial tweaks to the last build fix.
Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by NOBODY (build fix).
- bindings/scripts/CodeGeneratorV8.pm:
- 8:16 PM Changeset in webkit [49220] by
-
- 3 edits in trunk/JavaScriptCore
Windows linking fix
- 8:07 PM Changeset in webkit [49219] by
-
- 8 edits1 copy in trunk/WebCore
[Chromium] Need to adjust MessagePort, etc. code for the post clone work done.
https://bugs.webkit.org/show_bug.cgi?id=30147
Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by Dimitri Glazkov.
No change in functionality so no new tests.
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/SerializedScriptValue.h: Added. A very simple implementation of SerializedScriptValue that only works for strings.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- 7:48 PM Changeset in webkit [49218] by
-
- 4 edits in trunk/WebCore
Fix for <rdar://problem/7271202>
Dispatch resource load delegate functions for the media element.
Since we don't get the required callbacks from the media engine,
just fake the parameters to the delegate functions as best as possible.
Reviewed by Brady Eidson.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::isSafeToLoadURL):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::willLoadMediaElementURL):
- loader/FrameLoader.h:
- 7:39 PM Changeset in webkit [49217] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- 7:29 PM Changeset in webkit [49216] by
-
- 3 edits in trunk/WebCore
Build fix
- 7:21 PM Changeset in webkit [49215] by
-
- 3 edits1 add in trunk/WebCore
Build and formatting fix.
- 7:06 PM Changeset in webkit [49214] by
-
- 41 edits4 adds in trunk
It should be possible to post (clone) built-in JS objects to Workers
https://bugs.webkit.org/show_bug.cgi?id=22878
Reviewed by Gavin Barraclough.
Implement object cloning semantics for postMessage. Currently only
a partial implementation of the spec -- cloning of File, FileList,
ImageData, and RegExp were left out as they would have significantly
increased patch size.
Cloning requires multiple tree walks so we use a templated tree
walk function, allowing us to share a single implementation for
serialization, deserialization, and eventual destruction of the
serialized object tree.
Test: fast/dom/Window/window-postmessage-clone.html
- 6:28 PM Changeset in webkit [49213] by
-
- 2 edits in trunk/WebCore
2009-10-06 Adam Barth <abarth@webkit.org>
Unreviewed build fix for Windows.
- plugins/PluginView.cpp: (WebCore::PluginView::load):
- 6:14 PM Changeset in webkit [49212] by
-
- 18 edits in trunk
2009-10-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move FrameLoader::canLoad to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30111
- WebCore.base.exp:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL):
- loader/Cache.cpp: (WebCore::Cache::requestResource):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadFrameRequest): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::createJavaAppletWidget):
- loader/FrameLoader.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canLoad): (WebCore::SecurityOrigin::shouldHideReferrer):
- page/SecurityOrigin.h:
2009-10-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move FrameLoader::canLoad to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30111
- Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadRequest):
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
- WebView/WebFrame.mm: (-[WebFrame _allowsFollowingLink:]):
2009-10-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move FrameLoader::canLoad to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30111
- WebFrame.cpp: (WebFrame::allowsFollowingLink):
- 6:05 PM Changeset in webkit [49211] by
-
- 13 edits in trunk
2009-10-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move setLocalLoadPolicy and friends to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30110
These have more to do with security policies than with loading frames.
- WebCore.base.exp:
- dom/Document.cpp: (WebCore::Document::initSecurityContext):
- loader/Cache.cpp: (WebCore::Cache::requestResource):
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::setLocalLoadPolicy): (WebCore::SecurityOrigin::restrictAccessToLocal): (WebCore::SecurityOrigin::allowSubstituteDataAccessToLocal):
- page/SecurityOrigin.h: (WebCore::SecurityOrigin::):
2009-10-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move setLocalLoadPolicy and friends to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30110
Call the new API.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2009-10-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move setLocalLoadPolicy and friends to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30110
Call the new API.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- 3:48 PM Changeset in webkit [49210] by
-
- 2 edits in trunk/WebCore
2009-10-06 Brian Weinstein <bweinstein@apple.com>
Reviewed by Brady Eidson.
Preparation for <http://webkit.org/b/30104>.
Inspector should show cookies of sub-resources on the page.
Implement getRawCookies for CFNetwork for Windows, so we can see more
than just a key/value pair for Cookies when we are on Windows.
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies):
- 3:26 PM Changeset in webkit [49209] by
-
- 2 edits in trunk/WebKitSite
2009-10-06 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Diagram needs to be linked from the home page
https://bugs.webkit.org/show_bug.cgi?id=30142
http://webkit.org/coding/major-objects.html was never linked from the home
page.
- nav.inc:
- 3:26 PM Changeset in webkit [49208] by
-
- 13 edits5 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with <link> elements and
XML processing instructions.
Reviewed by Adam Roben.
Fix up ProcessingInstruction's setData call so that it actually updates a stylesheet when the
data gets changed.
Move dispatchBeforeLoadedEvent to ContainerNode so all Elements (and ProcessingInstruction) can
access it.
Added fast/dom/beforeload/link-before-load.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::dispatchBeforeLoadEvent):
- dom/ContainerNode.h:
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::setData):
- dom/ScriptElement.cpp:
(WebCore::ScriptElementData::requestScript):
- dom/ScriptElement.h:
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::endElementNs):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::process):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::forAttributeValue):
- html/HTMLScriptElement.h:
- svg/SVGScriptElement.cpp:
- svg/SVGScriptElement.h:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with CSS stylesheets loaded from
<link> elements and XML processing instructions.
Reviewed by Adam Roben.
- fast/dom/beforeload/link-before-load-expected.txt: Added.
- fast/dom/beforeload/link-before-load.html: Added.
- fast/dom/beforeload/pi-before-load-expected.txt: Added.
- fast/dom/beforeload/pi-before-load.xhtml: Added.
- 2:08 PM Changeset in webkit [49207] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
Reviewed by Simon Fraser.
- Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
the fact we have already changed the working directory to the top of the open source tree.
- 1:47 PM Changeset in webkit [49206] by
-
- 8 edits in trunk
2009-10-06 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
accessibility/media-element.html crashes (and has incorrect result)
https://bugs.webkit.org/show_bug.cgi?id=30108
Fix up the accessibilty label for the newly added fullscreen button,
and update the test result accordingly.
- 1:10 PM Changeset in webkit [49205] by
-
- 2 edits in trunk/WebKitTools
Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
rather than my committer email.
Patch by Julie Parent <jparent@chromium.org> on 2009-10-06
- Scripts/modules/committers.py:
- 12:56 PM Changeset in webkit [49204] by
-
- 2 edits in trunk/WebCore
2009-10-06 Kelly Norton <knorton@google.com>
Reviewed by Timothy Hatcher.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30028>
Multiple calls to SetFrontendProxyObject can leave an InspectorTimelineAgent with an invalid
InspectorFrontend.
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): Adds a check for an existing timeline agent.
- 12:14 PM Changeset in webkit [49203] by
-
- 4 edits2 adds in trunk
2009-10-06 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Fixes an issue where the Mac build does return the correct drop effect
with respect to the HTML 5 specification when effectAllowed == "none".
Currently, when effectAllowed == "none" and dropEffect == "copy" or
dropEffect == "move" the resulting drop effect is "copy" and "move",
respectively. However, the HTML 5 specification states that regardless
of the specified dropEffect, when effectAllowed == "none" the resulting
drop effect should be "none".
- WebView/WebHTMLView.mm: (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
2009-10-06 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Tests that drag-and-drop returns dropEffect = "none" when
effectAllowed == "none", regardless of the user-specified
drop effect.
- fast/events/drag-and-drop-none-expected.txt: Added.
- fast/events/drag-and-drop-none.html: Added.
- platform/win/Skipped: This test does not work under Windows. We need the fix for bug #24731.
- 12:13 PM Changeset in webkit [49202] by
-
- 2 edits in trunk/WebCore
Move textRects to the right category in DOM.mm. Include DOMPrivate.h to ensure that the interfaces match.
Reviewed by Dave Kilzer.
- bindings/objc/DOM.mm:
(-[DOMNode textRects]):
- 12:02 PM Changeset in webkit [49201] by
-
- 2 edits in trunk/WebCore
2009-10-06 Benjamin C Meyer <bmeyer@rim.com>
Reviewed by Ariya Hidayat.
Match the behavior of other WebKit browser and have the first url of the drag data be the url passed in declareAndWriteDragImage and set the text of the drag data to be the title argument.
Manual test: Drag the readability js link from http://lab.arc90.com/experiments/readability/
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage):
- 11:55 AM Changeset in webkit [49200] by
-
- 2 edits in trunk/WebKit/qt
2009-10-06 Benjamin C Meyer <bmeyer@rim.com>
Reviewed by Ariya Hidayat.
When the drag data contains an image set it on the QDrag so it will be visible to the user.
- WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::startDrag):
- 11:47 AM Changeset in webkit [49199] by
-
- 8 edits15 adds in trunk
2009-10-06 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
https://bugs.webkit.org/show_bug.cgi?id=29069
- fast/forms/ValidityState-rangeOverflow-number-expected.txt: Added.
- fast/forms/ValidityState-rangeOverflow-number.html: Added.
- fast/forms/ValidityState-rangeOverflow-range-expected.txt: Added.
- fast/forms/ValidityState-rangeOverflow-range.html: Added.
- fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Added.
- fast/forms/ValidityState-rangeUnderflow-number.html: Added.
- fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Added.
- fast/forms/ValidityState-rangeUnderflow-range.html: Added.
- fast/forms/input-minmax-expected.txt: Added.
- fast/forms/input-minmax.html: Added.
- fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Added.
- fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Added.
- fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Added.
- fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Added.
- fast/forms/script-tests/input-minmax.js: Added.
2009-10-06 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
https://bugs.webkit.org/show_bug.cgi?id=29069
HTMLInputElement::max and min are not defined for COM because they
conflict with the standard min() and max() macros.
Tests: fast/forms/ValidityState-rangeOverflow-number.html
fast/forms/ValidityState-rangeOverflow-range.html
fast/forms/ValidityState-rangeUnderflow-number.html
fast/forms/ValidityState-rangeUnderflow-range.html
fast/forms/input-minmax.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): (WebCore::HTMLInputElement::rangeOverflow): (WebCore::HTMLInputElement::rangeMinimum): (WebCore::HTMLInputElement::rangeMaximum):
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl:
- html/ValidityState.cpp: (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow):
- html/ValidityState.h:
- rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::valueFromElement):
- 11:29 AM Changeset in webkit [49198] by
-
- 2 edits in trunk/LayoutTests
2009-10-06 Xan Lopez <xlopez@igalia.com>
Skip new tests for which we are missing expected results.
- platform/gtk/Skipped:
- 11:27 AM Changeset in webkit [49197] by
-
- 2 edits in trunk/WebKitTools
2009-10-06 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Eric Seidel.
[Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
it after each layout test as it should do, making the DRT dump additional output
for all of the subsequent layout tests.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset):
- 11:20 AM Changeset in webkit [49196] by
-
- 8 edits in trunk/WebCore
2009-10-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move m_openedByDOM to Page
https://bugs.webkit.org/show_bug.cgi?id=30109
We only need one instance of m_openedByDOM per page, we should move it
to a page-scoped object. Notice that it's only ever touched for the
main frame.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- page/DOMWindow.cpp: (WebCore::DOMWindow::close):
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::openedByDOM): (WebCore::Page::setOpenedByDOM):
- page/Page.h:
- 10:49 AM Changeset in webkit [49195] by
-
- 2 edits in trunk/WebCore
2009-10-06 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Some functions in GraphicsContext do not work
as expected if the associated painter has no clipping.
https://bugs.webkit.org/show_bug.cgi?id=29691
No new tests are associated with this because DumpRenderTree
always sets clipping on the painter, thus it would never hit
the test case, but fast/box-shadow/basic-shadows.html is a
good example of what happens if the clipping is not set by
the user of QtWebKit.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): Fixed to handle the case that there is no clipping before the call.
- 10:37 AM Changeset in webkit [49194] by
-
- 11 edits8 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=30131, make beforeload fire on script elements.
Reviewed by Adam Roben.
WebCore:
Added tests in fast/dom/beforeload/.
- dom/ScriptElement.cpp:
(WebCore::ScriptElementData::requestScript):
- dom/ScriptElement.h:
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::endElementNs):
- html/HTMLAttributeNames.in:
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseMappedAttribute):
(WebCore::HTMLScriptElement::dispatchBeforeLoadEvent):
- html/HTMLScriptElement.h:
- html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::scriptHandler):
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::dispatchBeforeLoadEvent):
- svg/SVGScriptElement.h:
LayoutTests:
- fast/dom/beforeload: Added.
- fast/dom/beforeload/resources: Added.
- fast/dom/beforeload/script-before-load-dynamic-expected.txt: Added.
- fast/dom/beforeload/script-before-load-dynamic.html: Added.
- fast/dom/beforeload/script-before-load-expected.txt: Added.
- fast/dom/beforeload/script-before-load-xhtml-expected.txt: Added.
- fast/dom/beforeload/script-before-load-xhtml.xhtml: Added.
- fast/dom/beforeload/script-before-load.html: Added.
- 10:24 AM Changeset in webkit [49193] by
-
- 4 edits1 add in trunk
WebCore:
2009-10-06 Xan Lopez <xlopez@igalia.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25526
[Gtk] Additional support is needed for caret browsing
Enable caret movement commands also when caret browsing setting is
enabled.
- editing/EditorCommand.cpp: (WebCore::caretBrowsingEnabled): (WebCore::enabledVisibleSelectionOrCaretBrowsing): (WebCore::enabledInEditableTextOrCaretBrowsing): (WebCore::CommandEntry::):
- manual-tests/gtk/caret-browsing.html: Added.
WebKit/gtk:
2009-10-06 Xan Lopez <xlopez@igalia.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25526
[Gtk] Additional support is needed for caret browsing
Remove special cases for caret browsing, they are now handled in
cross-platform code.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent):
- 10:24 AM Changeset in webkit [49192] by
-
- 2 edits273 adds in trunk/LayoutTests
2009-10-06 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Eric Seidel.
[Gtk][Layout tests] Generate results for editing tests
https://bugs.webkit.org/show_bug.cgi?id=30061
Add results for editing tests and enable these tests in the Skipped.
Also moves some improperly placed tests to the 'failing' section.
- platform/gtk/Skipped:
- platform/gtk/editing/deleting/4922367-expected.txt: Added.
- platform/gtk/editing/deleting/5026848-1-expected.txt: Added.
- platform/gtk/editing/deleting/5026848-2-expected.txt: Added.
- platform/gtk/editing/deleting/5026848-3-expected.txt: Added.
- platform/gtk/editing/deleting/5032066-expected.txt: Added.
- platform/gtk/editing/deleting/5091898-expected.txt: Added.
- platform/gtk/editing/deleting/5099303-expected.txt: Added.
- platform/gtk/editing/deleting/5115601-expected.txt: Added.
- platform/gtk/editing/deleting/5126166-expected.txt: Added.
- platform/gtk/editing/deleting/5156801-2-expected.txt: Added.
- platform/gtk/editing/deleting/5206311-1-expected.txt: Added.
- platform/gtk/editing/deleting/5206311-2-expected.txt: Added.
- platform/gtk/editing/deleting/5272440-expected.txt: Added.
- platform/gtk/editing/deleting/5369009-expected.txt: Added.
- platform/gtk/editing/deleting/5390681-2-expected.txt: Added.
- platform/gtk/editing/deleting/5390681-expected.txt: Added.
- platform/gtk/editing/deleting/5433862-2-expected.txt: Added.
- platform/gtk/editing/deleting/5483370-expected.txt: Added.
- platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt: Added.
- platform/gtk/editing/deleting/delete-3608430-fix-expected.txt: Added.
- platform/gtk/editing/deleting/delete-3608445-fix-expected.txt: Added.
- platform/gtk/editing/deleting/delete-3608462-fix-expected.txt: Added.
- platform/gtk/editing/deleting/delete-3775172-fix-expected.txt: Added.
- platform/gtk/editing/deleting/delete-3800834-fix-expected.txt: Added.
- platform/gtk/editing/deleting/delete-3959464-fix-expected.txt: Added.
- platform/gtk/editing/deleting/delete-and-undo-expected.txt: Added.
- platform/gtk/editing/deleting/delete-block-contents-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-block-contents-002-expected.txt: Added.
- platform/gtk/editing/deleting/delete-block-contents-003-expected.txt: Added.
- platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt: Added.
- platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt: Added.
- platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt: Added.
- platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt: Added.
- platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt: Added.
- platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt: Added.
- platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt: Added.
- platform/gtk/editing/deleting/delete-br-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-br-002-expected.txt: Added.
- platform/gtk/editing/deleting/delete-br-003-expected.txt: Added.
- platform/gtk/editing/deleting/delete-br-004-expected.txt: Added.
- platform/gtk/editing/deleting/delete-br-005-expected.txt: Added.
- platform/gtk/editing/deleting/delete-br-006-expected.txt: Added.
- platform/gtk/editing/deleting/delete-br-007-expected.txt: Added.
- platform/gtk/editing/deleting/delete-br-010-expected.txt: Added.
- platform/gtk/editing/deleting/delete-br-013-expected.txt: Added.
- platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-image-004-expected.txt: Added.
- platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-002-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-005-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-006-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-007-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-008-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-009-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-010-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-011-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-012-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-013-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-014-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt: Added.
- platform/gtk/editing/deleting/delete-listitem-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-listitem-002-expected.txt: Added.
- platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-select-all-002-expected.txt: Added.
- platform/gtk/editing/deleting/delete-tab-002-expected.txt: Added.
- platform/gtk/editing/deleting/delete-tab-004-expected.txt: Added.
- platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
- platform/gtk/editing/deleting/delete-to-select-table-expected.txt: Added.
- platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt: Added.
- platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt: Added.
- platform/gtk/editing/deleting/forward-delete-expected.txt: Added.
- platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt: Added.
- platform/gtk/editing/deleting/move-nodes-001-expected.txt: Added.
- platform/gtk/editing/deleting/type-delete-after-quote-expected.txt: Added.
- platform/gtk/editing/execCommand/4580583-1-expected.txt: Added.
- platform/gtk/editing/execCommand/4580583-2-expected.txt: Added.
- platform/gtk/editing/execCommand/4747450-expected.txt: Added.
- platform/gtk/editing/execCommand/4786404-1-expected.txt: Added.
- platform/gtk/editing/execCommand/4786404-2-expected.txt: Added.
- platform/gtk/editing/execCommand/4916402-expected.txt: Added.
- platform/gtk/editing/execCommand/4916541-expected.txt: Added.
- platform/gtk/editing/execCommand/4920488-expected.txt: Added.
- platform/gtk/editing/execCommand/4920742-1-expected.txt: Added.
- platform/gtk/editing/execCommand/4924441-expected.txt: Added.
- platform/gtk/editing/execCommand/5049671-expected.txt: Added.
- platform/gtk/editing/execCommand/5080333-1-expected.txt: Added.
- platform/gtk/editing/execCommand/5080333-2-expected.txt: Added.
- platform/gtk/editing/execCommand/5136770-expected.txt: Added.
- platform/gtk/editing/execCommand/5138441-expected.txt: Added.
- platform/gtk/editing/execCommand/5142012-1-expected.txt: Added.
- platform/gtk/editing/execCommand/5142012-2-expected.txt: Added.
- platform/gtk/editing/execCommand/5190926-expected.txt: Added.
- platform/gtk/editing/execCommand/5481523-expected.txt: Added.
- platform/gtk/editing/execCommand/5482023-expected.txt: Added.
- platform/gtk/editing/execCommand/5569741-expected.txt: Added.
- platform/gtk/editing/execCommand/5573879-expected.txt: Added.
- platform/gtk/editing/execCommand/insert-list-empty-div-expected.txt: Added.
- platform/gtk/editing/inserting/12882-expected.txt: Added.
- platform/gtk/editing/inserting/4840662-expected.txt: Added.
- platform/gtk/editing/inserting/4875189-1-expected.txt: Added.
- platform/gtk/editing/inserting/4875189-2-expected.txt: Added.
- platform/gtk/editing/inserting/4959067-expected.txt: Added.
- platform/gtk/editing/inserting/4960120-2-expected.txt: Added.
- platform/gtk/editing/inserting/5002441-expected.txt: Added.
- platform/gtk/editing/inserting/5058163-1-expected.txt: Added.
- platform/gtk/editing/inserting/5058163-2-expected.txt: Added.
- platform/gtk/editing/inserting/5156401-2-expected.txt: Added.
- platform/gtk/editing/inserting/5418891-expected.txt: Added.
- platform/gtk/editing/inserting/5510537-expected.txt: Added.
- platform/gtk/editing/inserting/5549929-2-expected.txt: Added.
- platform/gtk/editing/inserting/5549929-3-expected.txt: Added.
- platform/gtk/editing/inserting/6633727-expected.txt: Added.
- platform/gtk/editing/inserting/6703873-expected.txt: Added.
- platform/gtk/editing/inserting/editable-inline-element-expected.txt: Added.
- platform/gtk/editing/inserting/edited-whitespace-1-expected.txt: Added.
- platform/gtk/editing/inserting/insert-3654864-fix-expected.txt: Added.
- platform/gtk/editing/inserting/insert-3659587-fix-expected.txt: Added.
- platform/gtk/editing/inserting/insert-3775316-fix-expected.txt: Added.
- platform/gtk/editing/inserting/insert-3800346-fix-expected.txt: Added.
- platform/gtk/editing/inserting/insert-3851164-fix-expected.txt: Added.
- platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Added.
- platform/gtk/editing/inserting/insert-after-delete-001-expected.txt: Added.
- platform/gtk/editing/inserting/insert-bg-font-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-bg-font-expected.txt.
- platform/gtk/editing/inserting/insert-br-005-expected.txt: Added.
- platform/gtk/editing/inserting/insert-div-001-expected.txt: Added.
- platform/gtk/editing/inserting/insert-div-002-expected.txt: Added.
- platform/gtk/editing/inserting/insert-div-003-expected.txt: Added.
- platform/gtk/editing/inserting/insert-div-004-expected.txt: Added.
- platform/gtk/editing/inserting/insert-div-005-expected.txt: Added.
- platform/gtk/editing/inserting/insert-div-009-expected.txt: Added.
- platform/gtk/editing/inserting/insert-div-024-expected.txt: Added.
- platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt: Added.
- platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt: Added.
- platform/gtk/editing/inserting/redo-expected.txt: Added.
- platform/gtk/editing/inserting/typing-001-expected.txt: Added.
- platform/gtk/editing/inserting/typing-002-expected.txt: Added.
- platform/gtk/editing/inserting/typing-003-expected.txt: Added.
- platform/gtk/editing/inserting/typing-around-br-001-expected.txt: Added.
- platform/gtk/editing/inserting/typing-around-image-001-expected.txt: Added.
- platform/gtk/editing/pasteboard/4076267-2-expected.txt: Added.
- platform/gtk/editing/pasteboard/4076267-3-expected.txt: Added.
- platform/gtk/editing/pasteboard/4076267-expected.txt: Added.
- platform/gtk/editing/pasteboard/5032095-expected.txt: Added.
- platform/gtk/editing/pasteboard/5071074-2-expected.txt: Added.
- platform/gtk/editing/pasteboard/5075944-3-expected.txt: Added.
- platform/gtk/editing/pasteboard/5089327-expected.txt: Added.
- platform/gtk/editing/pasteboard/5134759-expected.txt: Added.
- platform/gtk/editing/pasteboard/5156401-1-expected.txt: Added.
- platform/gtk/editing/pasteboard/5387578-expected.txt: Added.
- platform/gtk/editing/pasteboard/5483567-expected.txt: Added.
- platform/gtk/editing/pasteboard/7955-expected.txt: Added.
- platform/gtk/editing/pasteboard/cut-text-001-expected.txt: Added.
- platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-table-001-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-004-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-007-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-008-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-009-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-010-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-text-015-expected.txt: Added.
- platform/gtk/editing/pasteboard/paste-xml-expected.txt: Added.
- platform/gtk/editing/pasteboard/select-element-1-expected.txt: Added.
- platform/gtk/editing/selection/13804-expected.txt: Added.
- platform/gtk/editing/selection/14971-expected.txt: Added.
- platform/gtk/editing/selection/4818145-expected.txt: Added.
- platform/gtk/editing/selection/4866671-expected.txt: Added.
- platform/gtk/editing/selection/4889598-expected.txt: Added.
- platform/gtk/editing/selection/4895428-2-expected.txt: Added.
- platform/gtk/editing/selection/4960116-expected.txt: Added.
- platform/gtk/editing/selection/4960137-expected.txt: Added.
- platform/gtk/editing/selection/4983858-expected.txt: Added.
- platform/gtk/editing/selection/5007143-2-expected.txt: Added.
- platform/gtk/editing/selection/5007143-expected.txt: Added.
- platform/gtk/editing/selection/5057506-2-expected.txt: Added.
- platform/gtk/editing/selection/5057506-expected.txt: Added.
- platform/gtk/editing/selection/5076323-1-expected.txt: Added.
- platform/gtk/editing/selection/5076323-2-expected.txt: Added.
- platform/gtk/editing/selection/5076323-3-expected.txt: Added.
- platform/gtk/editing/selection/5081257-1-expected.txt: Added.
- platform/gtk/editing/selection/5081257-2-expected.txt: Added.
- platform/gtk/editing/selection/5099303-expected.txt: Added.
- platform/gtk/editing/selection/5109817-expected.txt: Added.
- platform/gtk/editing/selection/5131716-1-expected.txt: Added.
- platform/gtk/editing/selection/5131716-2-expected.txt: Added.
- platform/gtk/editing/selection/5131716-3-expected.txt: Added.
- platform/gtk/editing/selection/5131716-4-expected.txt: Added.
- platform/gtk/editing/selection/5232159-expected.txt: Added.
- platform/gtk/editing/selection/5234383-1-expected.txt: Added.
- platform/gtk/editing/selection/5234383-2-expected.txt: Added.
- platform/gtk/editing/selection/5333725-expected.txt: Added.
- platform/gtk/editing/selection/5354455-1-expected.txt: Added.
- platform/gtk/editing/selection/5354455-2-expected.txt: Added.
- platform/gtk/editing/selection/addRange-expected.txt: Added.
- platform/gtk/editing/selection/drag-in-iframe-expected.txt: Added.
- platform/gtk/editing/selection/extend-by-character-002-expected.txt: Added.
- platform/gtk/editing/selection/extend-by-character-003-expected.txt: Added.
- platform/gtk/editing/selection/extend-by-character-004-expected.txt: Added.
- platform/gtk/editing/selection/extend-by-character-005-expected.txt: Added.
- platform/gtk/editing/selection/fake-drag-expected.txt: Added.
- platform/gtk/editing/selection/iframe-expected.txt: Added.
- platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt: Added.
- platform/gtk/editing/selection/inline-table-expected.txt: Added.
- platform/gtk/editing/selection/mixed-editability-6-expected.txt: Added.
- platform/gtk/editing/selection/mixed-editability-7-expected.txt: Added.
- platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt: Added.
- platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt: Added.
- platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt: Added.
- platform/gtk/editing/selection/move-by-character-001-expected.txt: Added.
- platform/gtk/editing/selection/move-by-character-002-expected.txt: Added.
- platform/gtk/editing/selection/move-by-character-003-expected.txt: Added.
- platform/gtk/editing/selection/move-by-character-004-expected.txt: Added.
- platform/gtk/editing/selection/move-by-character-005-expected.txt: Added.
- platform/gtk/editing/selection/move-by-sentence-001-expected.txt: Added.
- platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt: Added.
- platform/gtk/editing/selection/move-past-trailing-space-expected.txt: Added.
- platform/gtk/editing/selection/select-box-expected.txt: Added.
- platform/gtk/editing/selection/selectNode-expected.txt: Added.
- platform/gtk/editing/selection/selectNodeContents-expected.txt: Added.
- platform/gtk/editing/selection/wrapped-line-caret-1-expected.txt: Added.
- platform/gtk/editing/selection/wrapped-line-caret-2-expected.txt: Added.
- platform/gtk/editing/spelling/spelling-expected.txt: Added.
- platform/gtk/editing/spelling/spelling-linebreak-expected.txt: Added.
- platform/gtk/editing/style/4916887-expected.txt: Added.
- platform/gtk/editing/style/5017613-1-expected.txt: Added.
- platform/gtk/editing/style/5017613-2-expected.txt: Added.
- platform/gtk/editing/style/5046875-1-expected.txt: Added.
- platform/gtk/editing/style/5046875-2-expected.txt: Added.
- platform/gtk/editing/style/5084241-expected.txt: Added.
- platform/gtk/editing/style/5228141-expected.txt: Added.
- platform/gtk/editing/style/5279521-expected.txt: Added.
- platform/gtk/editing/style/block-style-003-expected.txt: Added.
- platform/gtk/editing/style/fontsize-1-expected.txt: Added.
- platform/gtk/editing/style/highlight-expected.txt: Added.
- platform/gtk/editing/style/relative-font-size-change-001-expected.txt: Added.
- platform/gtk/editing/style/style-3681552-fix-001-expected.txt: Added.
- platform/gtk/editing/style/style-3681552-fix-002-expected.txt: Added.
- platform/gtk/editing/style/style-3690704-fix-expected.txt: Added.
- platform/gtk/editing/style/typing-style-001-expected.txt: Added.
- platform/gtk/editing/style/typing-style-002-expected.txt: Added.
- platform/gtk/editing/style/typing-style-003-expected.txt: Added.
- platform/gtk/editing/style/unbold-in-bold-expected.txt: Added.
- platform/gtk/editing/undo/4063751-expected.txt: Added.
- platform/gtk/editing/undo/5378473-expected.txt: Added.
- platform/gtk/editing/undo/redo-typing-001-expected.txt: Added.
- platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt: Added.
- platform/gtk/editing/undo/undo-combined-delete-expected.txt: Added.
- platform/gtk/editing/undo/undo-delete-boundary-expected.txt: Added.
- platform/gtk/editing/undo/undo-delete-expected.txt: Added.
- platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt: Added.
- platform/gtk/editing/undo/undo-forward-delete-expected.txt: Added.
- platform/gtk/editing/undo/undo-misspellings-expected.txt: Added.
- 10:15 AM Changeset in webkit [49191] by
-
- 7 edits in trunk
2009-10-06 Anton Muhin <antonm@chromium>
Reviewed by Dimitri Glazkov.
Non standard, but popular exetension allows automagically
turn a function into a namespace resolver. Support that in
Chromium as well.
This adds new layout tests.
https://bugs.webkit.org/show_bug.cgi?id=30128
- fast/xpath/xpath-namespaces-expected.txt:
- fast/xpath/xpath-namespaces.html:
2009-10-06 Anton Muhin <antonm@chromium>
Reviewed by Dimitri Glazkov.
Non standard, but popular exetension allows automagically
turn a function into a namespace resolver. Support that in
Chromium as well.
Adjust CodeGeneratorV8 to treat XPathNSResolver in a special way.
https://bugs.webkit.org/show_bug.cgi?id=30128
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::getXPathNSResolver):
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 9:48 AM HighLevelOverview edited by
- -typos, "to"->"from", grammar (diff)
- 8:48 AM Changeset in webkit [49190] by
-
- 10 edits in trunk
2009-10-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: close inspector client view on
InspectorController::close API call.
In order to run batch web inspector layout tests (and not affect
subsequent tests) we should close inspector client's view upon
InspectorController::close API call.
WebCore:
- inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::close):
WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::createPage):
WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::createPage):
WebKit/qt:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::createPage):
WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage):
- 8:34 AM Changeset in webkit [49189] by
-
- 6 edits in trunk
2009-10-06 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
fast/dom/assign-to-window-status.html test, which is passing as a result.
- platform/qt/Skipped:
2009-10-06 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
fast/dom/assign-to-window-status.html test, which is passing as a result.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::statusBarMessage):
- DumpRenderTree/qt/DumpRenderTree.h:
- DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpStatusCallbacks): (LayoutTestController::dumpStatusCallbacks):
- 8:27 AM Changeset in webkit [49188] by
-
- 2 edits in trunk/WebKit/qt
2009-10-06 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] don't enable input methods on Symbian by default.
https://bugs.webkit.org/show_bug.cgi?id=30117
If input methods are enabled Symbian FEP will be launched on every
pointer event making webpage navigation impossible with QWebView.
- Api/qwebview.cpp: (QWebView::QWebView):
- 8:06 AM Changeset in webkit [49187] by
-
- 2 edits in trunk/WebCore
Fix the Qt/Windows build by stubbing out the still image
support for halted plugins for the Qt build.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-06
Reviewed by Tor Arne Vestbø.
Bugzilla entry https://bugs.webkit.org/show_bug.cgi?id=30130
tracks removing this by implementing Frame::nodeImage().
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):
- 7:15 AM Changeset in webkit [49186] by
-
- 5 edits in trunk/WebCore
[Qt] Change QImageReader usage in ImageDecoderQt
https://bugs.webkit.org/show_bug.cgi?id=27538
Replace the ReadContext with another appoach to
reading the image. Attempt to only read meta information
like the image size and number of frames (for animations)
first and then when the page is getting drawn decode
the image with the QImageReader.
This is a huge benefit on pages with many images and saves
~2GB of memory on the szeged image test page.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ImageDecoderQt):
(WebCore::ImageDecoderQt::~ImageDecoderQt):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::isSizeAvailable):
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::repetitionCount):
(WebCore::ImageDecoderQt::filenameExtension):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::clearFrameBufferCache):
(WebCore::ImageDecoderQt::internalDecodeSize):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::forceLoadEverything):
(WebCore::ImageDecoderQt::failRead):
- platform/graphics/qt/ImageDecoderQt.h:
- 7:14 AM Changeset in webkit [49185] by
-
- 7 edits2 adds1 delete in trunk/WebCore
[Qt] Make use of RGBA32Buffer in ImageDecoderQt
https://bugs.webkit.org/show_bug.cgi?id=27538
Use the RGBA32Buffer instead of the internal ImageData
to be able to use support of the base class, optionally
support WebCore decoders for Qt and most importantly
separate metadata and image data for better cache control.
Remove ImageSourceQt as everything is now shared with
the normal ImageSource.
Change the ownership of the NativeImagePtr/QPixmap in
ImageQt.cpp to delete the m_frame to be subject to cache
control.
- WebCore.pro:
- platform/graphics/ImageSource.cpp:
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ReadContext::ReadContext):
(WebCore::ImageDecoderQt::ReadContext::read):
(WebCore::ImageDecoderQt::ReadContext::readImageLines):
(WebCore::ImageDecoderQt::ImageDecoderQt):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::clearFrameBufferCache):
- platform/graphics/qt/ImageDecoderQt.h:
- platform/graphics/qt/ImageSourceQt.cpp: Removed.
- platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::decodedImage):
(WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/qt/RGBA32BufferQt.cpp: Added.
(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::setDecodedImage):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::zeroFill):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::asNewNativeImage):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::setStatus):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):
- 6:54 AM Changeset in webkit [49184] by
-
- 2 edits in trunk/LayoutTests
2009-10-06 Xan Lopez <xlopez@igalia.com>
Skip another failing test.
- platform/gtk/Skipped:
- 6:46 AM Changeset in webkit [49183] by
-
- 3 edits in trunk/WebCore
[Qt] ImageDecoderQt avoid QString creation.
https://bugs.webkit.org/show_bug.cgi?id=27538
Avoid going from CString to QString to String
and go directly from CString to String. Also
avoid going to lower case to avoid an extra
memory allocation.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoder::create):
(WebCore::ImageDecoderQt::ImageDecoderQt):
- platform/graphics/qt/ImageDecoderQt.h:
- 6:46 AM Changeset in webkit [49182] by
-
- 3 edits in trunk/WebCore
[Qt] Cleanup the ImageDecoder of Qt.
https://bugs.webkit.org/show_bug.cgi?id=27538
Remove the various enums for partial load. The fact is
that this image decoder will decode everything that is
in the file at once. Make it look like it behaves to
ease fixing this core problem.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ImageData::ImageData):
(WebCore::ImageDecoderQt::ReadContext::ReadContext):
(WebCore::ImageDecoderQt::ReadContext::read):
(WebCore::ImageDecoderQt::ReadContext::readImageLines):
(WebCore::ImageDecoderQt::hasFirstImageHeader):
(WebCore::ImageDecoderQt::setData):
- platform/graphics/qt/ImageDecoderQt.h:
- 6:46 AM Changeset in webkit [49181] by
-
- 3 edits in trunk/WebCore
[Qt] Reimplement instead of overload frameCount in ImageDecoderQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=27538
Reimplement frameCount instead of overloading it.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameCount):
- platform/graphics/qt/ImageDecoderQt.h:
- 6:46 AM Changeset in webkit [49180] by
-
- 3 edits in trunk/WebCore
[Qt] QImageReader does not support progressive reading
https://bugs.webkit.org/show_bug.cgi?id=27538
Change the ImageDecoderQt::setData to store the encoded
data in ImageDecoder.
Only call ReadContext when the whole Resource has been
loaded to avoid needless calls to reset and the
ReadContext as progressive loading is not supported.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
- platform/graphics/qt/ImageDecoderQt.h:
- 6:46 AM Changeset in webkit [49179] by
-
- 2 edits in trunk/WebCore
[Qt] Remove dead code from ImageDecoderQt.
https://bugs.webkit.org/show_bug.cgi?id=27538
Remove unused variables and debugging code. The debug
code has never been used and does not provide anything
useful.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ReadContext::read):
(WebCore::ImageDecoderQt::ReadContext::readImageLines):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::isSizeAvailable):
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::repetitionCount):
(WebCore::ImageDecoderQt::filenameExtension):
(WebCore::ImageDecoderQt::imageAtIndex):
- 6:46 AM Changeset in webkit [49178] by
-
- 2 edits in trunk/WebKit/qt
QtLauncher: print the number of loaded urls
When using the -r mode print the number of URLs loaded so far. This
is extremly useful when opening the same URL over and over again and
one wants to see the progress.
- 6:38 AM Changeset in webkit [49177] by
-
- 2 edits in trunk/LayoutTests
2009-10-06 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Update the Skipped list.
Remove some tests that are passing now, mostly due to the recent DRT fixes.
- platform/qt/Skipped:
- 5:50 AM Changeset in webkit [49176] by
-
- 2 edits in trunk/WebCore
2009-10-06 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] segfault when calling gst_video_format_parse_caps in the video sink
https://bugs.webkit.org/show_bug.cgi?id=30120
Fix use of gst_video_format_parse_caps()
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
- 5:34 AM Changeset in webkit [49175] by
-
- 2 edits in trunk/WebCore
[Qt] Update mediaControls CSS
Reviewed by Simon Hausmann.
- 5:29 AM Changeset in webkit [49174] by
-
- 6 edits in trunk/WebCore
2009-10-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Get rid of Preferences.ignoreWhitespace.
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype._childNodeCountUpdated):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.update): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.onpopulate): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren):
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
- inspector/front-end/inspector.js:
- inspector/front-end/utilities.js: (Node.prototype.rangeOfWord): (traverseNextNode): (traversePreviousNode): (onlyTextChild):
- 5:03 AM Changeset in webkit [49173] by
-
- 2 edits in trunk/WebCore
2009-10-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not call nodeTitleInfo twice +
followup fixes for r49101.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement):
- 4:57 AM Changeset in webkit [49172] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-06 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
ASSERT executing the webhistory unittest in a debug build
https://bugs.webkit.org/show_bug.cgi?id=28947
We have to call g_object_new first to initialize webkit threading
before creating the KURL.
- WebKit/gtk/webkit/webkitwebhistoryitem.cpp:
- 4:53 AM Changeset in webkit [49171] by
-
- 2 edits in trunk/WebCore
[Qt] Windowless plugins: Enable painting on printer.
Patch by Girish Ramakrishnan <Girish Ramakrishnan> on 2009-10-06
Reviewed by Simon Hausmann.
The print preview dialog crashed because the depth of the drawable
changed owing to a bug in Qt - if you draw onto a 32-bit pixmap,
and set a 24-bit pixmap as source, it will convert the source to
32-bit.
1210fa5b2d65895ad2be1f9ca7cae586e3b29dc1 is the bug fix in Qt.
https://bugs.webkit.org/show_bug.cgi?id=20081
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::paint):
- 4:52 AM Changeset in webkit [49170] by
-
- 2 edits in trunk/WebCore
[Qt] Windowless plugins: Make painting and events work when page is zoomed.
Patch by Girish Ramakrishnan <Girish Ramakrishnan> on 2009-10-06
Reviewed by Simon Hausmann.
The element gets resized when zoomed. So, we have to make sure that we resize
the drawable and do a setwindow call. Multiple calls to setwindow do not
crash plugin in windowless mode (unlike in windowed mode).
For mouse events we have to convert the pos to post-zoom position.
https://bugs.webkit.org/show_bug.cgi?id=20081
- plugins/qt/PluginViewQt.cpp:
(WebCore::setXButtonEventSpecificFields):
(WebCore::setXMotionEventSpecificFields):
(WebCore::setXCrossingEventSpecificFields):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
- 4:52 AM Changeset in webkit [49169] by
-
- 6 edits in trunk/WebCore
[Qt] Windowless plugins: Add PluginQuirkRequiresDefaultScreenDepth quirk for Flash.
Patch by Girish Ramakrishnan <Girish Ramakrishnan> on 2009-10-06
Reviewed by Simon Hausmann.
Flash does not use the visual provided by us to draw into the drawable.
It instead uses the system default visual (as returned by XDefaultVisual).
This means that if the screen default visual is 24-bit, Flash won't be
able to draw on 32-bit drawable created by us. This is a bug in Flash
and for the moment, the above quirk is only set for Flash.
Our strategy to create the drawable:
- Create a 32-bit drawable if the default screen depth is 32 or the
quirk is not set (i.e not flash)
- If we didn't create a 32-bit drawable (maybe the Display has no such
visual), we create a drawable with default screen depth.
As a result of the above changes, content propagation behavior changes as:
- Content propagation is possible only if the drawable we create and
Qt's backing store are of the same depth.
- If we created a 32-bit drawable, there is no need for content
propagation (Qt will take care of it).
https://bugs.webkit.org/show_bug.cgi?id=20081
- plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):
- plugins/PluginQuirkSet.h:
(WebCore::):
- plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::getVisualAndColormap):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
- 4:49 AM Changeset in webkit [49168] by
-
- 24 edits in trunk/WebKit/gtk
2009-10-06 José Millán Soto <fid@gpul.org>
Reviewed by Xan Lopez.
Header files of WebKitGTK do not comply with WebKit coding style (Patch attached)
https://bugs.webkit.org/show_bug.cgi?id=30076
Solves various issues in header files.
- WebCoreSupport/DocumentLoaderGtk.h: Added "headed guards"
- webkit/webkitdefines.h:
- webkit/webkitdownload.h:
- webkit/webkiterror.h:
- webkit/webkithittestresult.h:
- webkit/webkitnetworkrequest.h:
- webkit/webkitnetworkresponse.h:
- webkit/webkitprivate.h:
- webkit/webkitsecurityorigin.h:
- webkit/webkitsoupauthdialog.h:
- webkit/webkitversion.h.in:
- webkit/webkitwebbackforwardlist.h:
- webkit/webkitwebdatabase.h:
- webkit/webkitwebdatasource.h:
- webkit/webkitwebframe.h:
- webkit/webkitwebhistoryitem.h:
- webkit/webkitwebinspector.h:
- webkit/webkitwebnavigationaction.h:
- webkit/webkitwebpolicydecision.h:
- webkit/webkitwebresource.h:
- webkit/webkitwebsettings.h:
- webkit/webkitwebview.h:
- webkit/webkitwebwindowfeatures.h:
- 4:42 AM Changeset in webkit [49167] by
-
- 3 edits in trunk/WebKitTools
2009-10-06 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
ignores the argument indicating which mouse button to trigger.
https://bugs.webkit.org/show_bug.cgi?id=30048
This affects the fast/events/mouse-click-events.html layout test.
- DumpRenderTree/qt/jsobjects.cpp: (EventSender::mouseDown): (EventSender::mouseUp):
- DumpRenderTree/qt/jsobjects.h:
- 4:35 AM Changeset in webkit [49166] by
-
- 2 edits in trunk/WebKitTools
2009-10-06 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Fix the EventSender::keyDown() implementation
https://bugs.webkit.org/show_bug.cgi?id=30043
It should post both a key press event and a key release event,
just like other ports do.
- DumpRenderTree/qt/jsobjects.cpp: (EventSender::keyDown):
- 4:27 AM Changeset in webkit [49165] by
-
- 2 edits in trunk/WebCore
2009-10-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Ariya Hidayat.
Qt build fix.
https://bugs.webkit.org/show_bug.cgi?id=29362.
In Qt 4.5, a new function QPainter::fillRect(QRect, QColor) is
introduced to avoid the expensive construction of QBrush.
By casting WebCore::Color to QColor, we can compile on Qt 4.4
and use optimization for solid color fill in Qt 4.5.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::drawBorderlessRectShadow):
- 4:08 AM Changeset in webkit [49164] by
-
- 6 edits in trunk/WebCore
Allow the platform media player to know the <video> poster URL.
Add MediaPlayerPrivate::prepareToPlay() to support media engines
that do not buffer video data automatically. This method allows
such media engines to start the buffering just before starting
playback.
https://bugs.webkit.org/show_bug.cgi?id=29133
Patch by Andrei Popescu <andreip@google.com> on 2009-10-05
Reviewed by Eric Carlson.
All platforms that currently implement <video> return false
in MediaPlayerPrivate::canLoadPoster() and do nothing in
MediaPlayerPrivate::prepareToPlay() their behavior is
unchanged. The current set of media test should then be
sufficient to guarantee that this patch does not break anything.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
After the MediaPlayer is created, inform it what the poster URL is.
(WebCore::HTMLMediaElement::updatePlayState):
Add another case where prepareToPlay is called for the platforms
that do not buffer video content automatically.
(WebCore::HTMLMediaElement::couldPlayIfEnoughData)
Same as potentiallyPlaying, except that we don't check for
the readyState being at least HAVE_FUTURE_DATA.
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::canLoadPoster):
Empty implementation for the NullMediaPlayerPrivate.
(WebCore::NullMediaPlayerPrivate::setPoster):
Empty implementation for the NullMediaPlayerPrivate.
(WebCore::MediaPlayer::canLoadPoster):
Proxy to the m_private.
(WebCore::MediaPlayer::setPoster):
Proxy to m_private.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::canLoadPoster):
(WebCore::MediaPlayerPrivateInterface::setPoster):
Add new methods that allow the platform player to receive the poster URL.
(WebCore::MediaPlayerPrivateInterface::prepareToPlay):
Notifies the media engine that playback should start. The media engine
should start preparing (e.g. by initializing the player and starting to buffer)
and call back when the state is changed to HAVE_FUTURE_DATA.
- 3:45 AM Changeset in webkit [49163] by
-
- 2 edits in trunk/LayoutTests
2009-10-06 Dirk Schulze <krit@webkit.org>
Previous SourceAlpha test were made with an filters enabled build.
This is the result of a filters disabled build (default).
- platform/mac/svg/filters/sourceAlpha-expected.txt:
- 1:11 AM Changeset in webkit [49162] by
-
- 3 edits in trunk/WebKit/win
Speculative build fix for windows (due to r49160).
Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by NOBODY (windows build fix).
- WebDownloadCFNet.cpp:
(WebDownload::initToResumeWithBundle):
- WebIconDatabase.cpp:
(WebIconDatabase::dispatchDidAddIconForPageURL):
- 1:08 AM Changeset in webkit [49161] by
-
- 2 edits in trunk/LayoutTests
2009-10-06 Xan Lopez <xlopez@igalia.com>
Update the skipped list to recent changes in tests.
- platform/gtk/Skipped:
- 12:45 AM Changeset in webkit [49160] by
-
- 36 edits in trunk
StringImpl needs a method to get an instance for another thread which doesn't copy the underlying buffer.
https://bugs.webkit.org/show_bug.cgi?id=30095
Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by Oliver Hunt.
- wtf/CrossThreadRefCounted.h:
Removed an unused function and assert improvement.
(WTF::CrossThreadRefCounted::isOwnedByCurrentThread): Moved out common code from asserts.
(WTF::CrossThreadRefCounted::ref): Changed assert to use the common method.
(WTF::CrossThreadRefCounted::deref): Changed assert to use the common method.
(WTF::CrossThreadRefCounted::crossThreadCopy): Since this includes a potentially
non-threadsafe operation, add an assert that the class is owned by the current thread.
WebCore:
All String::copy methods were changed to call either threadsafeCopy or crossThreadString. The method
call was made threadsafeCopy unless I could show that threadsafety wasn't needed.
No visible change in functionality so no new tests.
- dom/MessagePortChannel.cpp:
(WebCore::MessagePortChannel::EventData::EventData):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::open):
(WebCore::IconDatabase::iconForPageURL):
(WebCore::IconDatabase::iconURLForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::defaultDatabaseFilename):
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin): Since this is used by SecurityOrigin::threadsafeCopy,
it makes threadsafe calls.
(WebCore::SecurityOrigin::threadsafeCopy): The only place that called this
needed a threadsafe method.
- page/SecurityOrigin.h:
- platform/CrossThreadCopier.cpp:
(WebCore::::copy):
- platform/KURL.cpp:
(WebCore::KURL::copy):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
- platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::copy):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::copyData):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::copyData):
- platform/sql/SQLValue.cpp:
(WebCore::SQLValue::SQLValue):
(WebCore::SQLValue::string):
- platform/sql/SQLValue.h:
(WebCore::SQLValue::SQLValue):
All constructors now initialize the m_number which is a double. Failure to
do so can result in unexpected crashes when it is copied in the copy constructor.
See http://blogs.msdn.com/oldnewthing/archive/2008/07/02/8679191.aspx, I was that colleague.
- platform/text/PlatformString.h:
- platform/text/String.cpp:
(WebCore::String::threadsafeCopy):
(WebCore::String::crossThreadString):
- platform/text/StringImpl.cpp:
Removed StringImpl::substringCopy which was no longer being used anywhere.
(WebCore::StringImpl::threadsafeCopy): Changed the name to indicate that
it is threadsafe.
(WebCore::StringImpl::crossThreadString): The way to get strings for
another thread which is not threadsafe. This shares the underlying buffer
with both strings and gives them a way to do threadsafe refcounting for it.
- platform/text/StringImpl.h:
- storage/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::ChangeVersionWrapper):
- storage/Database.cpp:
(WebCore::updateGuidVersionMap):
(WebCore::Database::Database):
(WebCore::Database::getVersionFromDatabase):
(WebCore::Database::setVersionInDatabase):
(WebCore::Database::version):
(WebCore::Database::setExpectedVersion):
(WebCore::Database::securityOriginCopy):
(WebCore::Database::stringIdentifier):
- storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
- storage/OriginQuotaManager.cpp:
(WebCore::OriginQuotaManager::addDatabase):
- storage/SQLError.h:
(WebCore::SQLError::message):
(WebCore::SQLError::SQLError):
- storage/SQLStatement.cpp:
(WebCore::SQLStatement::SQLStatement):
- storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::syncTimerFired):
- storage/StorageMap.cpp:
(WebCore::StorageMap::importItem):
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
- storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::StorageSyncManager):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::url): Do the copy of the url in a way that is threadsafe.
(WebCore::SharedWorkerProxy::name):
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::DefaultSharedWorkerRepository::getProxy): Do the copy of the url in a way that is threadsafe.
- workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::SharedWorkerThread):
- workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerContextTask::MessageWorkerContextTask):
(WebCore::MessageWorkerTask::MessageWorkerTask):
(WebCore::WorkerExceptionTask::WorkerExceptionTask):
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::Task::Task):
(WebCore::WorkerRunLoop::postTaskForMode):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
- 12:35 AM Changeset in webkit [49159] by
-
- 4 edits in trunk/WebCore
[Qt] Windowless plugins: Use X Pixmap instead of QPixmap.
Patch by Girish Ramakrishnan <Girish Ramakrishnan> on 2009-10-06
Reviewed by Simon Hausmann.
This has the following advantages:
- Allows more sharing of code between gtk and Qt ports in the future
- QPixmap creates 24-bit by default. We have to later 'upgrade' it to 32-bit.
- QPixmap may sometime change depth behind our back! This will require us to
update the plugin about the new visual and colormap.
- We cannot ensure that QPixmap is backed by a X Drawable. For example, with
-graphicssystem raster, QPixmap uses the raster (image) backend.
https://bugs.webkit.org/show_bug.cgi?id=20081
- plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::platformDestroy):
- 12:31 AM Changeset in webkit [49158] by
-
- 4 edits in trunk/WebCore
[Qt] Add support for windowless NPAPI plugins
Patch by Girish Ramakrishnan <Girish Ramakrishnan> on 2009-10-06
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=20081
- plugins/PluginView.cpp:
(WebCore::PluginView::setFrameRect):
(WebCore::PluginView::handleEvent):
(WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::dispatchNPEvent):
(WebCore::setSharedXEventFields):
(WebCore::PluginView::initXEvent):
(WebCore::setXKeyEventSpecificFields):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::inputEventState):
(WebCore::setXButtonEventSpecificFields):
(WebCore::setXMotionEventSpecificFields):
(WebCore::setXCrossingEventSpecificFields):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::handleFocusInEvent):
(WebCore::PluginView::handleFocusOutEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::getValueStatic):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::forceRedraw):
(WebCore::getPluginDisplay):
(WebCore::PluginView::platformStart):
- 12:02 AM Changeset in webkit [49157] by
-
- 3 edits2 copies1 add in trunk/LayoutTests
2009-10-05 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Convert DOM Storage's "remove-item" test into the new format.
https://bugs.webkit.org/show_bug.cgi?id=30099
Convert DOM Storage's "remove-item" test into the new format and add it for
session storage. Make it a (tiny bit) more robust as well.
- storage/domstorage/localstorage/remove-item-expected.txt:
- storage/domstorage/localstorage/remove-item.html:
- storage/domstorage/script-tests/remove-item.js: Added. (runTest):
- storage/domstorage/sessionstorage/remove-item-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/remove-item-expected.txt.
- storage/domstorage/sessionstorage/remove-item.html: Copied from LayoutTests/storage/domstorage/localstorage/remove-item.html.
- 12:01 AM Changeset in webkit [49156] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-10-05 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Add a test to verify session storage does not have a quota
https://bugs.webkit.org/show_bug.cgi?id=30093
- storage/domstorage/script-tests/no-quota.js: Added. (runTest):
- storage/domstorage/sessionstorage/no-quota-expected.txt: Added.
- storage/domstorage/sessionstorage/no-quota.html: Added.
Oct 5, 2009:
- 11:58 PM Changeset in webkit [49155] by
-
- 3 edits2 copies1 add in trunk/LayoutTests
2009-10-05 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Convert DOM Storage's "complex-values" test into the new format.
https://bugs.webkit.org/show_bug.cgi?id=30097
Convert DOM Storage's "complex-values" test into the new format and add it for
session storage. This also increases the coverage of these tests a bit.
- storage/domstorage/localstorage/complex-values-expected.txt:
- storage/domstorage/localstorage/complex-values.html:
- storage/domstorage/script-tests/complex-values.js: Added. (handleStorageEvent): (testKeyValue): (runTest):
- storage/domstorage/sessionstorage/complex-values-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/complex-values-expected.txt.
- storage/domstorage/sessionstorage/complex-values.html: Copied from LayoutTests/storage/domstorage/localstorage/complex-values.html.
- 11:56 PM Changeset in webkit [49154] by
-
- 3 edits3 adds in trunk/LayoutTests
2009-10-05 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Convert DOM Storage's "complex-keys" test into the new format
https://bugs.webkit.org/show_bug.cgi?id=30089
Convert DOM Storage's "complex-keys" test into the new format and add it for
session storage. This test should be a bit more thorough than the old
version as well.
- storage/domstorage/localstorage/complex-keys-expected.txt:
- storage/domstorage/localstorage/complex-keys.html:
- storage/domstorage/script-tests/complex-keys.js: Added. (runTest):
- storage/domstorage/sessionstorage/complex-keys-expected.txt: Added.
- storage/domstorage/sessionstorage/complex-keys.html: Added.
- 10:58 PM Changeset in webkit [49153] by
-
- 4 edits4 adds in trunk
2009-10-05 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Filters do not support source images besides "sourceGraphic"
https://bugs.webkit.org/show_bug.cgi?id=6022
Add support for SourceAlpha to SVG filters.
Test: svg/filters/sourceAlpha.svg
- platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::calculateEffectRect): (WebCore::SourceAlpha::apply):
- platform/graphics/filters/SourceAlpha.h:
Test for SVG's SourceAlpha support for Filters.
- platform/mac/svg/filters/sourceAlpha-expected.checksum: Added.
- platform/mac/svg/filters/sourceAlpha-expected.png: Added.
- platform/mac/svg/filters/sourceAlpha-expected.txt: Added.
- svg/filters/sourceAlpha.svg: Added.
- 10:39 PM WebKit Team edited by
- (diff)
- 10:13 PM Changeset in webkit [49152] by
-
- 2 edits in trunk/WebKit/mac
Rubber-stamped by Mark Rowe.
Moved a WebPluginHalterClient out of the WebCore namesapce.
- WebCoreSupport/WebPluginHalterClient.h:
- 10:07 PM Changeset in webkit [49151] by
-
- 4 edits in trunk
wx libjpeg link fix and JSC build fix.
- 9:58 PM Changeset in webkit [49150] by
-
- 21 edits4 adds in trunk/LayoutTests
2009-10-05 Simon Fraser <Simon Fraser>
Updated results for media tests after controller change to add the fullscreen button.
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.checksum: Added.
- platform/mac/media/controls-after-reload-expected.png: Added.
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.checksum:
- platform/mac/media/controls-styling-expected.png:
- platform/mac/media/controls-styling-expected.txt:
- platform/mac/media/video-aspect-ratio-expected.checksum:
- platform/mac/media/video-aspect-ratio-expected.png:
- platform/mac/media/video-empty-source-expected.checksum:
- platform/mac/media/video-empty-source-expected.png:
- platform/mac/media/video-empty-source-expected.txt:
- platform/mac/media/video-no-audio-expected.checksum:
- platform/mac/media/video-no-audio-expected.png:
- platform/mac/media/video-no-audio-expected.txt:
- platform/mac/media/video-transformed-expected.checksum:
- platform/mac/media/video-transformed-expected.png:
- platform/mac/media/video-zoom-controls-expected.checksum: Added.
- platform/mac/media/video-zoom-controls-expected.png: Added.
- platform/mac/media/video-zoom-controls-expected.txt:
- platform/mac/media/video-zoom-expected.checksum:
- platform/mac/media/video-zoom-expected.png:
- 9:58 PM Changeset in webkit [49149] by
-
- 8 edits2 adds in trunk/WebKit
Reviewed by Dan Bernstein.
Added new PluginHalter client, delegate and few more WebPreferences keys.
- WebView/WebPreferenceKeysPrivate.h: Added two new keys.
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): Initialize newly added key. (-[WebPreferences pluginAllowedRunTime]): Added. (-[WebPreferences setPluginAllowedRunTime:]): Added.
- WebView/WebPreferencesPrivate.h: Added above two methods.
- WebView/WebUIDelegatePrivate.h: Added shouldHaltPlugin delegate.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Setup a new WebPluginHalterClient. (-[WebView _preferencesChangedNotification:]): Update WebCore settings accordingly.
- WebCoreSupport/WebPluginHalterClient.h: Added.
- WebCoreSupport/WebPluginHalterClient.mm: Added. (WebPluginHalterClient::WebPluginHalterClient): (WebPluginHalterClient::shouldHaltPlugin): Added, invoke the delegate.
- 9:55 PM Changeset in webkit [49148] by
-
- 4 edits in trunk/WebCore
2009-10-05 John Abd-El-Malek <jam@chromium.org>
Reviewed by Adam Barth.
Fix reliablity bot crash in DateExtension.
https://bugs.webkit.org/show_bug.cgi?id=30033
There were a few problems using the weak persistent pointers because no one else had a
handle to them. The new approach stores them as a hidden value on the Date constructor.
- bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep): (WebCore::DateExtension::GetNativeFunction): (WebCore::DateExtension::Setup): (WebCore::DateExtension::OnSleepDetected):
- bindings/v8/DateExtension.h:
- bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::sleepFunction):
- bindings/v8/V8HiddenPropertyName.h:
- 9:40 PM Changeset in webkit [49147] by
-
- 2 edits in trunk/WebKit/mac
2009-10-05 Simon Fraser <Simon Fraser>
More build fixes for Tiger.
- WebView/WebVideoFullscreenController.mm:
- 9:17 PM Changeset in webkit [49146] by
-
- 3 edits in trunk/WebKit/mac
2009-10-05 Simon Fraser <Simon Fraser>
More build fixes for Tiger.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenWindow animationDidEnd:]):
- WebView/WebWindowAnimation.m:
- 9:17 PM Changeset in webkit [49145] by
-
- 2 edits in trunk/WebCore
Crash when trying to load a null stylesheet for a site specific hack.
https://bugs.webkit.org/show_bug.cgi?id=30105
Reviewed by Dan Bernstein.
Created a testcase and tested in browser. DRT doesn't test
site specific hacks.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
- 9:12 PM Changeset in webkit [49144] by
-
- 2 edits in trunk/WebCore
2009-10-05 James Robinson <jamesr@google.com>
Reviewed by Darin Adler.
Fix forward declaration (struct vs class mismatch)
- loader/RedirectScheduler.h:
- 8:58 PM Changeset in webkit [49143] by
-
- 3 edits in trunk/WebKit/mac
2009-10-05 Simon Fraser <Simon Fraser>
More build fixes for Tiger.
- WebView/WebVideoFullscreenController.mm:
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): (-[WebVideoFullscreenHUDWindowController fadeWindowIn]): (-[WebVideoFullscreenHUDWindowController fadeWindowOut]): (-[WebVideoFullscreenHUDWindowController closeWindow]):
- 6:53 PM Changeset in webkit [49142] by
-
- 2 edits in trunk/WebCore
Unreviewed, last Chromium build fix corresponding to revision 49113.
Add include for BeforeLoadEvent to DOMObjectsInclude.h.
Patch by Julie Parent <jparent@chromium.org> on 2009-10-05
- bindings/v8/DOMObjectsInclude.h:
- 6:47 PM Changeset in webkit [49141] by
-
- 2 edits in trunk/WebKit
2009-10-05 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
One of the dependencies' SVN url was missing a @ before the revision number.
- chromium/DEPS:
- 6:21 PM Changeset in webkit [49140] by
-
- 3 edits in trunk/WebKit/mac
2009-10-05 Simon Fraser <Simon Fraser>
Build fixes for Tiger.
- WebView/WebVideoFullscreenHUDWindowController.h:
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): (-[WebVideoFullscreenHUDWindowController dealloc]): (-[WebVideoFullscreenHUDWindowController closeWindow]): (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
- 6:05 PM Changeset in webkit [49139] by
-
- 2 edits in trunk/WebKit/mac
2009-10-05 Simon Fraser <Simon Fraser>
Build fix. If you call Node::hasTagName(), you also have to include Element.h.
- WebCoreSupport/WebChromeClient.mm:
- 5:43 PM Changeset in webkit [49138] by
-
- 2 edits in trunk/WebCore
2009-10-05 Simon Fraser <Simon Fraser>
Fix Windows build.
- html/HTMLMediaElement.cpp:
- 5:40 PM Changeset in webkit [49137] by
-
- 2 edits in trunk/WebCore
2009-10-05 Simon Fraser <Simon Fraser>
Fix the build: MediaControllerThemeQT was renamed to MediaControllerThemeQuickTime.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
- 5:24 PM Changeset in webkit [49136] by
-
- 31 edits7 adds in trunk
2009-10-05 Pierre d'Herbemont <pdherbemont@webkit.org>
Reviewed by Simon Fraser
Support fullscreen in MediaPlayer (Mac)
https://bugs.webkit.org/show_bug.cgi?id=26742
Add a fullscreen button to the <video> controller if the media engine,
and the theme have support for fullscreen, and can show appropriate controls.
Clicking the button calls through the ChromeClient to the WebVideoFullscreenController
in WebKit to do a nice animation to fullscreen, with a custom controller.
- 5:21 PM Changeset in webkit [49135] by
-
- 2 edits in trunk/WebCore
Export a few more methods from Settings.h
Rubberstamped by Jon Honeycutt.
- WebCore.base.exp:
- 5:03 PM Changeset in webkit [49134] by
-
- 2 edits in trunk/WebCore
1-char fix for obviously reverse condition.
https://bugs.webkit.org/show_bug.cgi?id=30100
No test since the only difference is a timing of GC.
Reviewed by Darin Adler.
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::clear): Revert condition. Almost a typo.
- 5:00 PM Changeset in webkit [49133] by
-
- 5 edits in trunk/WebKit/mac
WebKit side of <rdar://problem/7179166>
Reviewed by Kevin Decker.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
Add an m_pluginIsWaitingForDraw member variable.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.
(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.
(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.
- Plugins/Hosted/WebKitPluginHost.defs:
Add PHPluginInstanceDidDraw.
- 4:57 PM Changeset in webkit [49132] by
-
- 2 edits in trunk/WebCore
2009-09-30 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Update platform-specific #ifdefs in GraphicsContext3D.h for the
Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=29936
- platform/graphics/GraphicsContext3D.h: Changed #if PLATFORM(SKIA) to #if PLATFORM(CHROMIUM).
- 4:37 PM Changeset in webkit [49131] by
-
- 3 edits4 adds in trunk
REGRESSION (r47440): Inserting text in the middle of content in a scrolled textfield results in painting bugs
<rdar://problem/7269108>
https://bugs.webkit.org/show_bug.cgi?id=29982
Reviewed by Darin Adler.
WebCore:
Test: fast/repaint/line-in-scrolled-clipped-block.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): Use the unclipped overflow rect
(including layout overflow) for the repaint rect calculation.
LayoutTests:
- fast/repaint/line-in-scrolled-clipped-block.html: Added.
- platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum: Added.
- platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
- platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
- 4:34 PM Changeset in webkit [49130] by
-
- 4 edits in trunk/WebCore
2009-10-05 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Chromium wants to turn off SharedWorkers at runtime
https://bugs.webkit.org/show_bug.cgi?id=29757
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::sharedWorker): Now returns jsUndefined if isAvailable() returns false, to allow SharedWorkers to be disabled at runtime.
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerRepository::isAvailable): Made SharedWorkers available by default.
- workers/SharedWorkerRepository.h: Added definition for SharedWorkerRepository::isAvailable().
- 4:26 PM Changeset in webkit [49129] by
-
- 4 edits4 adds in trunk
2009-10-05 Hironori Bono <hbono@chromium.org>
Reviewed by Eric Seidel.
A super quick fix for Bug 28710.
This change just resets the style sent to addStyleMarkup() to avoid an assertion error
and creates an empty style when computedStyleAtPosition is 0 to avoid a crash.
(This change is nothing but a better-than-crash change.)
- editing/selection/select-crash-001-expected.txt: Added.
- editing/selection/select-crash-001.html: Added.
- editing/selection/select-crash-002-expected.txt: Added.
- editing/selection/select-crash-002.html: Added.
2009-10-05 Hironori Bono <hbono@chromium.org>
Reviewed by Eric Seidel.
A super quick fix for Bug 28710.
This change just resets the style sent to addStyleMarkup() to avoid an assertion error
and creates an empty style when computedStyleAtPosition is 0 to avoid a crash.
(This change is nothing but a better-than-crash change.)
Tests: editing/selection/select-crash-001.html
editing/selection/select-crash-002.html
- editing/ApplyStyleCommand.cpp: (WebCore::editingStyleAtPosition): Resets the style sent to addStyleMarkup() if it is not valid.
- editing/markup.cpp: (WebCore::createMarkup): Creates an empty style if computedStyleAtPosition is 0.
- 4:18 PM Changeset in webkit [49128] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-05 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Remove precompiled header from JavaScriptCore compilation to
prevent qmake warning during autonomous compilation.
https://bugs.webkit.org/show_bug.cgi?id=30069
- JavaScriptCore.pro:
- 4:10 PM Changeset in webkit [49127] by
-
- 2 edits in trunk/LayoutTests
2009-10-05 Julie Parent <jparent@chromium.org>
Reviewed by Darin Adler.
Make LayoutTests/editing/selection/hit-test-anonymous.html resistant to
GDI/CG differences, by increasing the font size so the slight
difference in fonts doesn't result in a different character clicked.
https://bugs.webkit.org/show_bug.cgi?id=29985
- editing/selection/hit-test-anonymous.html:
- 4:10 PM Changeset in webkit [49126] by
-
- 2 edits in trunk/WebCore
Silence duplicate errors logged for missing getComputedStyle
implementations. Improves the error message as well.
Reviewed by Mark Rowe.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::logUnimplementedPropertyID):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- 4:03 PM Changeset in webkit [49125] by
-
- 3 edits in trunk/WebCore
Unreviewed, Chromium build fix #3. Add V8BeforeLoadEvent.[cc|h] to derived sources.
Patch by Julie Parent <jparent@chromium.org> on 2009-10-05
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- 4:03 PM Changeset in webkit [49124] by
-
- 2 edits in trunk/WebKit/qt
2009-10-05 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
Add screenshot option to menubar
- QtLauncher/main.cpp: (MainWindow::screenshot): (MainWindow::setupUI):
- 3:49 PM Changeset in webkit [49123] by
-
- 1 edit in trunk/WebKitSite/blog-files/webgl/WebGL+CSS.html
Another change to one of the WebGL blog post demos
- 3:45 PM Changeset in webkit [49122] by
-
- 2 edits in trunk/WebKit/qt
2009-10-05 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
Setting the env QTLAUNCHER_USE_ARGB_VISUALS makes Qt use WA_TranslucentWindow.
- QtLauncher/main.cpp: (MainWindow::MainWindow):
- 3:44 PM Changeset in webkit [49121] by
-
- 7 edits in trunk/WebKitSite/blog-files/webgl
Fixed some tests for WebGL blog post
- 3:41 PM Changeset in webkit [49120] by
-
- 2 edits in trunk/WebCore
Try and fix the GTK build.
- GNUmakefile.am:
- 3:37 PM Changeset in webkit [49119] by
-
- 17 adds in trunk/WebKitSite/blog-files/webgl
Added files for WebGL blog post
- 3:37 PM Changeset in webkit [49118] by
-
- 2 edits in trunk/WebKitTools
2009-10-05 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] EventSender::keyDown() cannot send function-key events.
https://bugs.webkit.org/show_bug.cgi?id=30044
This affects the fast/events/keydown-function-keys.html layout test.
- DumpRenderTree/qt/jsobjects.cpp: (EventSender::keyDown):
- 3:31 PM Changeset in webkit [49117] by
-
- 2 edits in trunk/WebCore
Unreviewed, Chromium build fix #2. Add new BEFORELOADEVENT to V8ClassIndex.
Patch by Julie Parent <jparent@chromium.org> on 2009-10-05
- bindings/v8/V8Index.h:
- 3:07 PM Changeset in webkit [49116] by
-
- 2 edits in trunk/WebCore
Unreviewed, Chromium build fix. Missing "," after entry for BeforeLoadEvent.idl.
Patch by Julie Parent <jparent@chromium.org> on 2009-10-05
- WebCore.gypi:
- 3:04 PM Changeset in webkit [49115] by
-
- 4 edits in trunk/LayoutTests
Update layout tests to account for the new beforeload event object.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 2:28 PM Changeset in webkit [49114] by
-
- 1 edit in trunk/WebCore/WebCore.pro
Fix Qt bustage.
- 2:16 PM Changeset in webkit [49113] by
-
- 8 edits2 adds in trunk/WebCore
Add a beforeload event that will be fired before subresources load. (It isn't fired yet.) The event
has one field, the URL that is going to be requested. Setting preventDefault will stop the load
from occurring.
Reviewed by Sam Weinig.
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/BeforeLoadEvent.h: Added.
(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::initBeforeLoadEvent):
(WebCore::BeforeLoadEvent::url):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):
- dom/BeforeLoadEvent.idl: Added.
- dom/EventNames.h:
- page/DOMWindow.idl:
- 2:07 PM Changeset in webkit [49112] by
-
- 2 edits in trunk/WebCore
2009-10-05 Priit Laes <plaes@plaes.org>
Reviewed by Gustavo Noronha.
Add Gentoo-specific paths for searching browser plugins.
https://bugs.webkit.org/show_bug.cgi?id=30088
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::defaultPluginDirectories):
- 1:46 PM Changeset in webkit [49111] by
-
- 7 edits in trunk
Add functionality to pause/throttle CSS transitions/animations in a WebView
https://bugs.webkit.org/show_bug.cgi?id=29942
- 1:44 PM Changeset in webkit [49110] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Simon Hausmann.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Remove test that I forgot in earlier commit.
- platform/qt/Skipped:
- 1:23 PM Changeset in webkit [49109] by
-
- 3 edits in trunk/WebKitTools
2009-10-05 Vadim Zeitlin <vadim@wxwidgets.org>
Added --wx-compiler-prefix waf option to allow building wxWebKit with
wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
- wx/build/settings.py:
- wx/build/wxpresets.py:
- 1:06 PM Changeset in webkit [49108] by
-
- 3 edits in trunk/WebCore
Rubberstamped by Anders Carlsson.
- WebCore.base.exp: Update export of HaltablePlugin/PluginHalterClient.
- WebCore.xcodeproj/project.pbxproj: Likewise.
- 12:07 PM Changeset in webkit [49107] by
-
- 8 edits15 deletes in trunk
2009-10-05 Eric Seidel <eric@webkit.org>
No review, rolling out r49104.
http://trac.webkit.org/changeset/49104
- fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
- fast/forms/ValidityState-rangeOverflow-number.html: Removed.
- fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
- fast/forms/ValidityState-rangeOverflow-range.html: Removed.
- fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
- fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
- fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
- fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
- fast/forms/input-minmax-expected.txt: Removed.
- fast/forms/input-minmax.html: Removed.
- fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
- fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
- fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
- fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
- fast/forms/script-tests/input-minmax.js: Removed.
2009-10-05 Eric Seidel <eric@webkit.org>
No review, rolling out r49104.
http://trac.webkit.org/changeset/49104
- html/HTMLInputElement.cpp:
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl:
- html/ValidityState.cpp:
- html/ValidityState.h: (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow):
- rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::valueFromElement):
- 11:57 AM Changeset in webkit [49106] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Sam Weinig.
<rdar://problem/7273363> Plug-ins should use PluginHalter
- Plugins/WebBaseNetscapePluginView.h: Add WebHaltablePlugin forward declare and _haltable ivar.
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::WebHaltablePlugin): Added. (WebHaltablePlugin::halt): New method that stops a plug-in. (WebHaltablePlugin::restart): New method that starts a plug-in. (WebHaltablePlugin::node): Added. Provides the DOMNode corresponding to the plug-in in WebBaseNetscapePluginView. (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): Initialize new _haltable ivar. (-[WebBaseNetscapePluginView start]): Call the page's didStartPlugin() upon starting a plug-in. (-[WebBaseNetscapePluginView stop]): Call the page's didStopPlugin() upon stopping a plug-in.
- 11:23 AM Changeset in webkit [49105] by
-
- 7 edits7 adds in trunk
2009-10-05 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Tests to check if validation-related CSS selectors are applied immediately.
https://bugs.webkit.org/show_bug.cgi?id=28868
- fast/forms/input-live-pseudo-selectors-expected.txt: Added.
- fast/forms/input-live-pseudo-selectors.html: Added.
- fast/forms/resources/input-live-pseudo-selectors.js: Added.
- fast/forms/resources/live-pseudo-selectors.css: Added.
- fast/forms/resources/textarea-live-pseudo-selectors.js: Added.
- fast/forms/textarea-live-pseudo-selectors-expected.txt: Added.
- fast/forms/textarea-live-pseudo-selectors.html: Added.
2009-10-05 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Update style immediately when validation-related values are updated.
https://bugs.webkit.org/show_bug.cgi?id=28868
In order to apply :valid, :invalid, :optional or :required lively,
- call setNeedsStyleRecalc() when properties which can change willValidate state are updated, and
(Parent form element, name, disabled, readonly)
- call updateValidity() when properties which can change validity state are updated. (value, pattern, required)
Tests: fast/forms/input-live-pseudo-selectors.html
fast/forms/textarea-live-pseudo-selectors.html
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::required): (WebCore::HTMLFormControlElement::updateValidity):
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
- 11:14 AM Changeset in webkit [49104] by
-
- 8 edits15 adds in trunk
2009-10-05 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
https://bugs.webkit.org/show_bug.cgi?id=29069
- fast/forms/ValidityState-rangeOverflow-number-expected.txt: Added.
- fast/forms/ValidityState-rangeOverflow-number.html: Added.
- fast/forms/ValidityState-rangeOverflow-range-expected.txt: Added.
- fast/forms/ValidityState-rangeOverflow-range.html: Added.
- fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Added.
- fast/forms/ValidityState-rangeUnderflow-number.html: Added.
- fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Added.
- fast/forms/ValidityState-rangeUnderflow-range.html: Added.
- fast/forms/input-minmax-expected.txt: Added.
- fast/forms/input-minmax.html: Added.
- fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Added.
- fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Added.
- fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Added.
- fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Added.
- fast/forms/script-tests/input-minmax.js: Added.
2009-10-05 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Implement min/max attributes, ValidityState.rangeUnderflow and
ValidityState.rangeOverflow for <input type=number> and <input type=range>
https://bugs.webkit.org/show_bug.cgi?id=29069
Tests: fast/forms/ValidityState-rangeOverflow-number.html
fast/forms/ValidityState-rangeOverflow-range.html
fast/forms/ValidityState-rangeUnderflow-number.html
fast/forms/ValidityState-rangeUnderflow-range.html
fast/forms/input-minmax.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): (WebCore::HTMLInputElement::rangeOverflow): (WebCore::HTMLInputElement::rangeMinimum): (WebCore::HTMLInputElement::rangeMaximum):
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl:
- html/ValidityState.cpp: (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow):
- html/ValidityState.h:
- rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::valueFromElement):
- 11:05 AM Changeset in webkit [49103] by
-
- 13 edits2 adds in trunk
2009-10-05 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Tests for -webkit-appearance:list-button
https://bugs.webkit.org/show_bug.cgi?id=27794
- platform/mac/fast/forms/input-list-button-size-expected.txt: Added.
- platform/mac/fast/forms/input-list-button-size.html: Added.
2009-10-05 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces
- new CSS pseudo selector: "-webkit-input-list-button"
- new CSS apperance type: "list-button"
- new ControlPart value: "ListButtonPart"
for the UI of the list attribute of the input element, and adds
implementation to draw ListButtonPart on Mac.
The code is guarded by ENABLE(DATALIST).
Test: platform/mac/fast/forms/input-list-button-size.html
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h: (WebCore::CSSSelector::):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- css/CSSValueKeywords.in:
- css/html.css:
- html/HTMLInputElement.cpp:
- platform/ThemeTypes.h: (WebCore::):
- platform/mac/ThemeMac.mm: (WebCore::listButtonSizes): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeMac::controlSize): (WebCore::ThemeMac::minimumControlSize): (WebCore::ThemeMac::controlBorder): (WebCore::ThemeMac::paint):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect):
- rendering/style/RenderStyleConstants.h: (WebCore::):
- 11:00 AM Changeset in webkit [49102] by
-
- 2 edits in trunk/WebKit/qt
Rubberstamped by Simon Hausmann.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Add documentation to the ErrorPageExtension.
- Api/qwebpage.cpp:
- 10:39 AM Changeset in webkit [49101] by
-
- 3 edits in trunk/WebCore
2009-10-05 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30065>
nodeTitleInfo should be placed in ElementsTreeOutline.
Move nodeTitleInfo into ElementsTreeOutline.js from utilities.js.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- inspector/front-end/utilities.js:
- 10:36 AM Changeset in webkit [49100] by
-
- 6 edits in trunk
[Qt] Inform the application when a new request is created
https://bugs.webkit.org/show_bug.cgi?id=29975
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.
WebCore:
Emit a signal each time a request is created, with the request and the frame
that created it.
WebKit/qt:
Add a signal to QWebPage, to inform the application when a request is created.
- 10:30 AM Changeset in webkit [49099] by
-
- 2 edits in trunk/WebCore
2009-10-05 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
Add an ASSERT in updateGuidVersionMap.
https://bugs.webkit.org/show_bug.cgi?id=30077
- storage/Database.cpp: (WebCore::updateGuidVersionMap): ASSERT that the guidMutex() is locked.
- 10:15 AM Changeset in webkit [49098] by
-
- 2 edits in trunk/WebCore
2009-10-05 Nate Chapin <Nate Chapin>
Reviewed by Eric Seidel.
Allow V8 to throw an exception in _NPN_SetException without worrying about context
if we don't have enough information to find the correct context.
Part of the fix for Chromium's failure of LayouTests/plugins/netscape-throw-exception.html.
- bindings/v8/NPV8Object.cpp: (_NPN_SetException): Don't suppress the exception if we can't find the relevant context.
- 9:03 AM Changeset in webkit [49097] by
-
- 4 edits in trunk/WebCore
2009-10-01 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Place "Close" button in docked mode on the same side as the window "Close" button in detached mode.
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 8:11 AM Changeset in webkit [49096] by
-
- 3 edits in trunk/WebKit/qt
ErrorPageExtension: Add a pointer to the QWebFrame that had
an error.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Reviewed by Simon Hausmann.
- Api/qwebpage.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
- 8:01 AM Changeset in webkit [49095] by
-
- 2 edits in trunk/WebKit/qt
Do not empty the offline web appcache when clearing
memory caches. That one is not in memory, but stored
in sqlite.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Reviewed by Tor Arne Vestbø.
- Api/qwebsettings.cpp:
(QWebSettings::clearMemoryCaches):
- 7:36 AM Changeset in webkit [49094] by
-
- 2 edits in trunk/LayoutTests
[Qt] Re-enable fast/table/008.html
- 7:08 AM Changeset in webkit [49093] by
-
- 1 edit6 adds in trunk/LayoutTests
[Qt] Add expected files for passing fast/table tests.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-05
Reviewed by Ariya Hidayat.
- platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
- platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
- platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.
- 7:03 AM Changeset in webkit [49092] by
-
- 6 edits in trunk
WebCore: [Qt] Added pure virtual QWebPageClient::pluginParent()
Patch by J-P Nurmi <jpnurmi@gmail.com> on 2009-10-05
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29710
- platform/qt/QWebPageClient.h:
WebKit/qt: Added QGraphicsWidget-plugins support to FrameLoaderClientQt.
Patch by J-P Nurmi <jpnurmi@gmail.com> on 2009-10-05
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29710
- Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::pluginParent):
- Api/qwebview.cpp:
(QWebViewPrivate::pluginParent):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::):
(WebCore::FrameLoaderClientQt::createPlugin):
- 7:03 AM Changeset in webkit [49091] by
-
- 19 edits2 adds in trunk
2009-10-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add testing harness for Web Inspector.
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
- WebInspector/WebInspector.mm: (-evaluateInFrontend:callId:script:):
- WebInspector/WebInspectorPrivate.h: Added.
WebKit/win:
- Interfaces/IWebInspectorPrivate.idl: Added.
- Interfaces/IWebViewPrivate.idl:
- Interfaces/WebKit.idl:
- WebInspector.cpp: (WebInspector::evaluateInFrontend):
- WebInspector.h:
- WebView.cpp: (WebView::inspectorPrivate):
- WebView.h:
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp: (showWebInspectorCallback): (closeWebInspectorCallback): (evaluateInWebInspectorCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
- 6:25 AM Changeset in webkit [49090] by
-
- 2 edits in trunk
2009-10-05 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Disable TCmalloc for Windows port at the present, because MinGW
hasn't got built-in pthread library.
- WebKit.pri:
- 3:57 AM Changeset in webkit [49089] by
-
- 2 edits in trunk/WebCore
2009-10-05 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Tor Arne Vestbø.
[Qt] windowsKeyCodeForKeyEvent() returns a wrong value for the F10 key.
https://bugs.webkit.org/show_bug.cgi?id=30042
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 3:48 AM Changeset in webkit [49088] by
-
- 2 edits in trunk/WebKitTools
Pass arguments to system() as a string instead of array
Reviewed by Ariya Hidayat.
When passed as an array entries with a space fail to translate
to two arguments to the child process, so instead of manually
splitting all the entries in @buildArgs we pass the whole thing
as a string instead.
- Scripts/webkitdirs.pm:
- 2:31 AM Changeset in webkit [49087] by
-
- 4 edits1 copy1 delete in trunk/WebCore
Move mediaControls extras for the Qt port into WebCore/css like other ports
https://bugs.webkit.org/show_bug.cgi?id=30013
Reviewed by Eric Carlson.
- 2:17 AM Changeset in webkit [49086] by
-
- 2 edits in trunk/WebCore
2009-10-05 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed build fix for ENABLE(WEB_SOCKETS) and v8.
V8ObjectEventListener.h has been removed at r48978
- bindings/v8/custom/V8WebSocketCustom.cpp:
- 2:06 AM Changeset in webkit [49085] by
-
- 2 edits in trunk/WebCore
2009-10-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector console stops working while JS in IFRAME is paused.
- inspector/front-end/InjectedScript.js: (InjectedScript._evaluateOn): (InjectedScript.addInspectedNode): (InjectedScript._ensureCommandLineAPIInstalled):
- 1:56 AM Changeset in webkit [49084] by
-
- 13 edits in trunk/WebCore
2009-10-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Introduce inspected object groups for console
and watch evaluation results so that they could be released
explicitly.
- bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::wrapObject):
- bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::wrapObject): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::wrapObject): (WebCore::InspectorController::unwrapObject): (WebCore::InspectorController::releaseWrapperObjectGroup):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
- inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript._evaluateAndWrap): (InjectedScript.evaluateInCallFrame):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSection.prototype.update):
- 1:42 AM Changeset in webkit [49083] by
-
- 4 edits1 move in trunk/WebCore
Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT
https://bugs.webkit.org/show_bug.cgi?id=30013
Reviewed by Eric Carlson.
The QT suffix has been expanded to QuickTime, to not cause confusion
and name-crashes with similar files in the Qt port.
Oct 4, 2009:
- 10:27 PM Changeset in webkit [49082] by
-
- 7 edits1 add in trunk/WebCore
2009-10-04 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30064>
Syntax Highlighting CSS shouldn't be duplicated.
Refactor syntax highlighting CSS into a new file, add it to the
projects, and have SourceFrame.js and inspector.html include the
new CSS file.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspectorSyntaxHighlight.css: Added.
- inspector/front-end/WebKit.qrc:
- 9:16 PM Changeset in webkit [49081] by
-
- 3 edits in trunk/WebCore
2009-10-04 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30062>
Inspector should syntax highlight JS/CSS in elements view.
Add syntax highlighting of CSS and JavaScript tags to the elements panel.
Copied CSS rules from SourceFrame.js to inspector.css, and have the text nodes
in utilities.js call the CSS or JS Syntax highlighters if their parent is a script
or style tag.
- inspector/front-end/inspector.css:
- inspector/front-end/utilities.js:
- 7:52 PM Changeset in webkit [49080] by
-
- 4 edits in trunk
2009-10-04 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel
Enable Web Sockets in chromium build.
https://bugs.webkit.org/show_bug.cgi?id=29917
- WebCore.gyp/WebCore.gyp:
2009-10-04 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel
Enable Web Sockets in chromium build.
https://bugs.webkit.org/show_bug.cgi?id=29917
- chromium/features.gypi:
- 4:43 PM Changeset in webkit [49079] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Cameron Zwarich.
- WebView/WebPreferenceKeysPrivate.h: Added new key.
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): Leave plug-in halting disabled by default. (-[WebPreferences pluginHalterEnabled]): Added. (-[WebPreferences setPluginHalterEnabled:]): Ditto.
- WebView/WebPreferencesPrivate.h: Added above new methods.
- 2:12 PM Changeset in webkit [49078] by
-
- 3 edits in trunk/WebKitTools
2009-10-04 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Levin.
check-webkit-style misses whitespace errors for operators:
<<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, . - Scripts/modules/cpp_style.py: Added the operators mentioned above to the same list as == and !=.
- 1:01 PM Changeset in webkit [49077] by
-
- 5 edits4 adds in trunk
WebCore:
2009-10-01 Xan Lopez <xlopez@igalia.com>
Reviewed by NOBODY (OOPS!).
[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761
Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.
Test: http/tests/navigation/postredirect-reload.html
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
LayoutTests:
2009-10-01 Xan Lopez <xlopez@igalia.com>
Reviewed by NOBODY (OOPS!).
[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761
New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.
- http/tests/navigation/postredirect-reload-expected.txt: Added.
- http/tests/navigation/postredirect-reload.html: Added.
- http/tests/navigation/resources/postresult.pl:
- http/tests/navigation/resources/reloadresult.pl: Added.
- http/tests/navigation/resources/redirect-reload.html: Added.
- http/tests/navigation/resources/success200.html:
- http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
- 11:14 AM Changeset in webkit [49076] by
-
- 6 edits3 deletes in trunk
Revert previous patch, as the newly added test breaks other tests.
- 10:17 AM Changeset in webkit [49075] by
-
- 6 edits3 adds in trunk
WebCore:
2009-10-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761
Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.
Test: http/tests/navigation/postredirect-reload.html
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
LayoutTests:
2009-10-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761
New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.
- http/tests/navigation/postredirect-reload-expected.txt: Added.
- http/tests/navigation/postredirect-reload.html: Added.
- http/tests/navigation/resources/postresult.pl:
- http/tests/navigation/resources/reloadresult.pl: Added.
- http/tests/navigation/resources/success200.html:
- http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
- 10:12 AM Changeset in webkit [49074] by
-
- 4 edits in trunk/WebCore
2009-10-04 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Fixed Function leak in V8LazyEventListener.
(Should fix the remaning leak in
https://bugs.webkit.org/show_bug.cgi?id=29093).
V8LazyEventListeners used to create FunctionTemplates for each
wrapped listener which in turn created Functions that were cached
forever in V8 Context. Now there is at most one such Function per
Context.
https://bugs.webkit.org/show_bug.cgi?id=30060
Added new hidden property name to store toString result:
- bindings/v8/V8HiddenPropertyName.cpp:
- bindings/v8/V8HiddenPropertyName.h:
Switched to static FunctionTemplate:
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListenerToString): (WebCore::V8LazyEventListener::prepareListenerObject):
Oct 3, 2009:
- 8:46 PM Changeset in webkit [49073] by
-
- 2 edits in trunk/WebCore
2009-10-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
CSS Source View Should be Syntax Highlighted
https://bugs.webkit.org/show_bug.cgi?id=14359
Support for WebKit's CSS Variables @variables and var()
- inspector/front-end/SourceFrame.js: (WebInspector.CSSSourceSyntaxHighligher):
- 8:14 PM Changeset in webkit [49072] by
-
- 3 edits in trunk/WebCore
2009-10-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Inspector should remember preferences for docked/undocked etc
https://bugs.webkit.org/show_bug.cgi?id=29089
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleLargerResources): toggle the preference
- inspector/front-end/inspector.js: (WebInspector._loadPreferences): factored out loading preferences (WebInspector.loaded):
- 7:50 PM Changeset in webkit [49071] by
-
- 3 edits in trunk/WebCore
2009-10-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
CSS Source View Should be Syntax Highlighted
https://bugs.webkit.org/show_bug.cgi?id=14359
Trigger the Syntax Highlighter for CSS files.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
Factored out the Syntax Highlighting procedure into a "Class"
Added CSSSourceSyntaxHighlighter and JavaScriptSourceSyntaxHighlighter
(WebInspector.SourceSyntaxHighligher):
(WebInspector.SourceSyntaxHighligher.prototype.createSpan):
(WebInspector.SourceSyntaxHighligher.prototype.process.processChunk):
(WebInspector.SourceSyntaxHighligher.prototype.process):
(WebInspector.CSSSourceSyntaxHighligher): the CSS Highlighter
(WebInspector.JavaScriptSourceSyntaxHighligher): the JS Highlighter
- 5:41 PM Changeset in webkit [49070] by
-
- 2 edits in trunk/WebKit/qt
2009-10-03 Adam Barth <abarth@webkit.org>
Unreview build fix. I wish I had a try server...
- Api/qwebpage.cpp: (QWebPagePrivate::updateAction):
- 5:36 PM Changeset in webkit [49069] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-03 Adam Barth <abarth@webkit.org>
More build fixing.
- webkit/webkitwebview.cpp: (webkit_web_view_go_back_or_forward): (webkit_web_view_can_go_back_or_forward):
- 5:26 PM Changeset in webkit [49068] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-03 Adam Barth <abarth@webkit.org>
Unreviewed build fix.
- webkit/webkitwebview.cpp: (webkit_web_view_go_back_or_forward):
- 5:17 PM Changeset in webkit [49067] by
-
- 12 edits in trunk
2009-10-03 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Factor back-forward list methods out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30037
This change moves these back-forward related methods from FrameLoader
to Page. It's possible we should move these methods into some kind of
"page controller" object, but we can figure that out in a future patch.
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::timerFired):
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
- page/DOMWindow.cpp: (WebCore::DOMWindow::close):
- page/History.cpp: (WebCore::History::length):
- page/Page.cpp: (WebCore::Page::canGoBackOrForward): (WebCore::Page::goBackOrForward): (WebCore::Page::getHistoryLength):
- page/Page.h:
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
2009-10-03 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Factor PageController out of FrameLoader and Page
https://bugs.webkit.org/show_bug.cgi?id=30037
- webkit/webkitwebview.cpp: (webkit_web_view_can_go_back_or_forward):
- 1:50 PM Changeset in webkit [49066] by
-
- 2 edits in trunk/LayoutTests
2009-10-03 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Remove 5 tests from the Skipped list that pass after the addition
of layoutTestController.overridePreference().
- platform/qt/Skipped:
- 10:01 AM Changeset in webkit [49065] by
-
- 7 edits in trunk/JavaScriptCore
Removed the concept of a "fast access cutoff" in arrays, because it
punished some patterns of array access too much, and made things too
complex for inlining in some cases.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-02
Reviewed by Sam Weinig.
1.3% speedup on SunSpider.
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
(JSC::): Check m_vectorLength instead of m_fastAccessCutoff when
getting / putting from / to an array. Inline putting past the end of
the array.
- runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):
- runtime/JSArray.h:
(JSC::JSArray::canGetIndex):
(JSC::JSArray::canSetIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::markChildrenDirect): Removed m_fastAccessCutoff, and
replaced with checks for JSValue() to detect reads and writes from / to
uninitialized parts of the array.
- 3:27 AM Changeset in webkit [49064] by
-
- 11 edits in trunk/WebCore
2009-10-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: prepare InspectorController for being used from layout tests.
This change adds evaluateForTestInFrontend method with the callback that
allows evaluating arbitrary code in the frontend context.
- WebCore.Inspector.exp:
- WebCore.order:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::evaluateForTestInFrontend): (WebCore::InspectorController::didEvaluateForTestInFrontend):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::evaluateForTestInFrontend):
- inspector/InspectorFrontend.h:
- inspector/front-end/inspector.js: (WebInspector.evaluateForTestInFrontend):
Oct 2, 2009:
- 11:31 PM Changeset in webkit [49063] by
-
- 2 edits in trunk/WebCore
2009-10-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Node search mode is not getting reset on element selection.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
- 10:24 PM Changeset in webkit [49062] by
-
- 2 edits in trunk/WebCore
2009-10-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30036>
Should be able to resize Cookie Columns.
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.update.callback): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.resize):
- 10:10 PM Changeset in webkit [49061] by
-
- 2 edits in trunk/WebKitLibraries
Windows build fix.
Re-apply lost changes to auto-version.sh.
- win/tools/scripts/auto-version.sh:
- 7:51 PM Changeset in webkit [49060] by
-
- 12 edits in trunk/WebCore
Make WebCore::PluginView participate in plug-in halting.
Reviewed by Sam Weinig.
WebCore:
Have plug-ins opt in to automatic halting.
Reviewed by NOBODY (OOPS!).
- platform/graphics/BitmapImage.h:
Declare a create() function that takes an HBITMAP.
- platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::create):
Use GetObject() to fill out a DIBSECTION structure for the given
HBITMAP. Call CGBitmapContextCreate() to create a CG context from the
bits of the bitmap. Create a CG image from the context, and pass this
when creating a new BitmapImage.
- plugins/PluginView.cpp:
(WebCore::PluginView::start):
If we successfully started, tell our parent frame's Page.
(WebCore::PluginView::stop):
Tell our parent frame's Page that we stopped.
(WebCore::PluginView::node):
- plugins/PluginView.h:
Inherit from HaltablePlugin.
(WebCore::PluginView::setPlatformPluginWidget):
On platforms where the platform plug-in widget is the WebCore::Widget's
platform widget, have setPlatformPluginWidget() call
setPlatformWidget().
- plugins/PluginViewNone.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.
- plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::platformDestroy):
After destroying the window, set the platform plug-in widget to 0 to
ensure that Widget isn't holding a stale handle.
(WebCore::PluginView::halt):
Have our element's RenderWidget display a screenshot of the plug-in,
then stop the plug-in and destroy it.
(WebCore::PluginView::restart):
Clear the RenderWidget's substitute image, then start the plug-in.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::showSubstituteImage):
Set m_substituteImage to the passed image, and repaint.
(WebCore::RenderWidget::paint):
If we have a substitute image, paint that instead of allowing the
widget to paint itself.
- rendering/RenderWidget.h:
Declare showSubstituteImage(). Added a member to store the substitute
image.
- 7:10 PM Changeset in webkit [49059] by
-
- 8 edits2 adds in trunk/WebCore
2009-10-02 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move PolicyCheck out of FrameLoader.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=30035
Purely code motion (and adding a destructor).
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/PolicyCheck.cpp:
- loader/PolicyCheck.h:
- 6:47 PM Changeset in webkit [49058] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Patch by Julie Parent <jparent@chromium.org> on 2009-10-02
Adding myself and Ojan Vafai as committers, because we are committers.
- Scripts/modules/committers.py:
- 5:47 PM Changeset in webkit [49057] by
-
- 5 edits in trunk/WebKit/mac
Roll out r49044 as it breaks many tests.
- 4:35 PM Changeset in webkit [49056] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-02 Jonni Rainisto <jonni.rainisto@nokia.com>
Reviewed by Darin Adler.
Math.random() gives too low values on Win32 when _CRT_RAND_S is not defined
https://bugs.webkit.org/show_bug.cgi?id=29956
- wtf/RandomNumber.cpp: (WTF::randomNumber): Added PLATFORM(WIN_OS) to handle 15bit rand()
- 4:27 PM Changeset in webkit [49055] by
-
- 3 edits in trunk/LayoutTests
2009-10-02 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
Update pixel test image for fast/table/vertical-align-baseline.html.
Expected render tree dump for this test was modified in r40146
<http://trac.webkit.org/changeset/40146>, but the image was not updated with it.
- platform/mac/fast/table/vertical-align-baseline-expected.checksum:
- platform/mac/fast/table/vertical-align-baseline-expected.png:
- 4:20 PM Changeset in webkit [49054] by
-
- 2 edits in trunk/WebCore
2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Add NPNVToolkit value quirk in plugins for nspluginwrapper.
Plugin error message was:
ERROR: failed to initialize brower-side RPC events listener
https://bugs.webkit.org/show_bug.cgi?id=25053
(WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
(WebCore::PluginPackage::load):
- 4:12 PM Changeset in webkit [49053] by
-
- 2 edits in trunk/WebCore
2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] X sync our XEmbed container window creation before sending the
xid to plugins.
https://bugs.webkit.org/show_bug.cgi?id=25053
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
- 4:02 PM Changeset in webkit [49052] by
-
- 4 edits4 adds in trunk
2009-10-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Setting zero size on a container of a video element doesn't hide the controller
https://bugs.webkit.org/show_bug.cgi?id=30031
Fix a logic error in enclosingCompositingLayer() when mixing normal flow and
positioned layers. This resulted in enclosingCompositingLayer() giving back a different
answer to the logic used to actually parent compositing layers, so layer positions
and layer hierarchy would be out of agreement.
Test: compositing/geometry/clipped-video-controller.html
- rendering/RenderLayer.cpp: (WebCore::compositingContainer): (WebCore::RenderLayer::enclosingCompositingLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::setCompositingParent):
- 3:49 PM Changeset in webkit [49051] by
-
- 7 edits in trunk/WebCore
2009-10-02 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
- Move the following methods of HTMLInputElement and HTMLTextAreaElement to HTMLTextFormControlElement.
setSelectionStart()
setSelectionEnd()
select()
setSelectionRange()
selectionStart()
selectionEnd()
selection()
- Introduce cachedSelectionStart() and cachedSelectionEnd().
- Unify HTMLInputElement::isTextFieldWithRenderer() and HTMLTextAreaElement::rendererAfterUpdateLayout() into textRendererAfterUpdateLayout().
- Unify a part of parseMappedAttribute() of HTMLInputElement and HTMLTextAreaElement.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::textRendererAfterUpdateLayout): (WebCore::HTMLTextFormControlElement::setSelectionStart): (WebCore::HTMLTextFormControlElement::setSelectionEnd): (WebCore::HTMLTextFormControlElement::select): (WebCore::HTMLTextFormControlElement::setSelectionRange): (WebCore::HTMLTextFormControlElement::selectionStart): (WebCore::HTMLTextFormControlElement::selectionEnd): (WebCore::HTMLTextFormControlElement::selection): (WebCore::HTMLTextFormControlElement::parseMappedAttribute):
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::cachedSelectionStart): (WebCore::HTMLInputElement::cachedSelectionEnd):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cachedSelectionStart): (WebCore::HTMLTextAreaElement::cachedSelectionEnd):
- 3:40 PM Changeset in webkit [49050] by
-
- 14 edits in trunk/WebCore
2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Disconnect event listeners on navigation.
Fixes http://crbug.com/23597.
https://bugs.webkit.org/show_bug.cgi?id=30027
Added V8ListenerGuard that is shared by listeners and proxy. On
navigation proxy sets a flag in the guard turning off listeners.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener):
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8ListenerGuard::create): (WebCore::V8ListenerGuard::isDisconnected): (WebCore::V8ListenerGuard::disconnectListeners): (WebCore::V8ListenerGuard::V8ListenerGuard): (WebCore::V8AbstractEventListener::disconnected):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener):
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper):
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::disconnectFrame): (WebCore::V8Proxy::disconnectEventListeners): (WebCore::V8Proxy::clearForNavigation):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::listenerGuard):
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
- bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
- bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create):
- 3:33 PM Changeset in webkit [49049] by
-
- 2 edits in trunk/WebCore
2009-10-02 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Fix WebGL build after CustomGetter constructor changes
https://bugs.webkit.org/show_bug.cgi?id=30020
- page/DOMWindow.idl: Changed CustomGetter to JSCCustomGetter for CanvasArray constructors.
- 3:23 PM Changeset in webkit [49048] by
-
- 2 edits in trunk/WebCore
2009-10-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Web Inspector: text in a "Request Payload" section disappears on selection
https://bugs.webkit.org/show_bug.cgi?id=29967
No new tests.
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestPayload):
- 3:15 PM Changeset in webkit [49047] by
-
- 3 edits2 adds in trunk
2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
Test that having infinite recursion in XMLHttpRequest event handler does not crash.
https://bugs.webkit.org/show_bug.cgi?id=29974
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html: Added.
2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Recursion guard for V8Proxy::callFunction.
Fixes http://crbug.com/23278.
https://bugs.webkit.org/show_bug.cgi?id=29974
Test: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
- 2:59 PM Changeset in webkit [49046] by
-
- 2 edits in trunk/WebCore
Clean up the QNetworkReplyHandler to only apply HTTP headers
for protocols in the HTTP family.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 2:55 PM Changeset in webkit [49045] by
-
- 2 edits1 delete in trunk/LayoutTests
2009-10-02 Victor Wang <victorw@chromium.org>
Reviewed by Adam Barth.
Patch http://trac.webkit.org/changeset/35290 adds win support for
JPEG and GIF for toDataURL encoding canvases and the test was
rewritten to not output the encoded image data, it should pass
on Win now.
- platform/win/Skipped:
- platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt: Removed.
- 2:53 PM Changeset in webkit [49044] by
-
- 5 edits in trunk/WebKit/mac
WebKit side of <rdar://problem/7179166>
Reviewed by Kevin Decker and Dan Bernstein.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
Add an m_pluginIsWaitingForDraw member variable.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.
(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.
(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.
- Plugins/Hosted/WebKitPluginHost.defs:
Add PHPluginInstanceDidDraw.
- 2:49 PM Changeset in webkit [49043] by
-
- 3 edits in trunk/WebCore
2009-10-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Jon Honeycutt.
Fix test breakages by adding null checks, and putting inspector code in
ENABLE(INSPECTOR).
- dom/Document.cpp: (WebCore::Document::finishedParsing):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
- 2:39 PM Changeset in webkit [49042] by
-
- 2 edits in trunk/WebCore
Move error check into sendResponseIfNeeded() as suggested
by Eric Seidel. Also, remove some dead code.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 2:34 PM Changeset in webkit [49041] by
-
- 3 edits2 adds in trunk
WebCore: Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
<rdar://problem/7148712>
https://bugs.webkit.org/show_bug.cgi?id=28992
Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.
Test: editing/selection/replace-selection-crash.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Handle properly the case of
the destination position matching the end of the paragraph to move.
LayoutTests: Added test case.
<rdar://problem/7148712> Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
https://bugs.webkit.org/show_bug.cgi?id=28992
Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.
- editing/selection/replace-selection-crash-expected.txt: Added.
- editing/selection/replace-selection-crash.html: Added.
- 2:15 PM Changeset in webkit [49040] by
-
- 13 edits3 adds in trunk
2009-10-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Implement per-storage-area quotas for LocalStorage
https://bugs.webkit.org/show_bug.cgi?id=29991
I put 90% of the code in StorageMap since the decision to allow an update is
closely tied to quota tracking. The quota is set via a page's Settings class.
Like with the local storage path and whether it's enabled, it's assumed that
all pages in the same group will have the same settings. The setting defaults
to 5mb which is what the spec suggests, but it can easily be changed to
anything else--including StorageMap::noQuota. Any values in LocalStorage are
grandfathered in regarudless of quota, so importItem only tracks (and will
never block) imports.
I believe this change is a good transition to more complex quota management.
For example, if we wanted to track quotas in the SQLite DB, then we'd just add
a function to the StorageMap that sets the quota. This would be fine since all
use of LocalStorage is blocked on the import completing, so you'd never hit a
quota error in the mean time. Also, if embedders wanted to ask the user
whether to expand the quota whenever it's hit (before deciding whether or not
to raise an exception), a callback via the chrome client should be fairly easy.
That said, I think it's best to add these features in steps rather than one
huge patch. (Both of these are on my TODO list, btw.)
Included is a layout test that verifies the behavior. It assumes the default
quota is 5mb (since that's what Settings defaults to).
Test: storage/domstorage/localstorage/quota.html
- page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLocalStorageQuota):
- page/Settings.h: (WebCore::Settings::localStorageQuota):
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::clear):
- storage/StorageAreaImpl.h:
- storage/StorageMap.cpp: (WebCore::StorageMap::create): (WebCore::StorageMap::StorageMap): (WebCore::StorageMap::copy): (WebCore::StorageMap::setItem): (WebCore::StorageMap::removeItem): (WebCore::StorageMap::importItem):
- storage/StorageMap.h: (WebCore::StorageMap::quota):
- storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace):
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea):
- storage/StorageNamespaceImpl.h:
2009-10-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Implement per-storage-area quotas for LocalStorage
https://bugs.webkit.org/show_bug.cgi?id=29991
I put 90% of the code in StorageMap since the decision to allow an update is
closely tied to quota tracking. The quota is set via a page's Settings class.
Like with the local storage path and whether it's enabled, it's assumed that
all pages in the same group will have the same settings. The setting defaults
to 5mb which is what the spec suggests, but it can easily be changed to
anything else--including StorageMap::noQuota. Any values in LocalStorage are
grandfathered in regarudless of quota, so importItem only tracks (and will
never block) imports.
I believe this change is a good transition to more complex quota management.
For example, if we wanted to track quotas in the SQLite DB, then we'd just add
a function to the StorageMap that sets the quota. This would be fine since all
use of LocalStorage is blocked on the import completing, so you'd never hit a
quota error in the mean time. Also, if embedders wanted to ask the user
whether to expand the quota whenever it's hit (before deciding whether or not
to raise an exception), a callback via the chrome client should be fairly easy.
That said, I think it's best to add these features in steps rather than one
huge patch. (Both of these are on my TODO list, btw.)
Included is a layout test that verifies the behavior. It assumes the default
quota is 5mb (since that's what Settings defaults to).
- storage/domstorage/localstorage/quota-expected.txt: Added.
- storage/domstorage/localstorage/quota.html: Added.
- storage/domstorage/script-tests/quota.js: Added. (runTest):
- 1:09 PM Changeset in webkit [49039] by
-
- 2 edits in trunk/WebCore
2009-10-02 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Database Inspector crashes Safari when table has more than 21 columns
https://bugs.webkit.org/show_bug.cgi?id=29924
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult): adjust the minimum column width percentage to be flexible for many columns.
- 1:07 PM Changeset in webkit [49038] by
-
- 1 edit in trunk/WebKit/win/WebView.cpp
Fix Windows bustage.
- 1:07 PM Changeset in webkit [49037] by
-
- 1 edit in trunk/WebKit/win/WebView.cpp
Fix Windows bustage.
- 1:01 PM Changeset in webkit [49036] by
-
- 11 edits in trunk/WebCore
2009-10-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Fixes <http://webkit.org/b/14370>.
Inspector's timeline should record when certain DOM events fired.
This patch adds calls into the Web Inspector when the main frame
fires an load event, and when the document fires its DOMContent
event. Once these values are passed in, they are sent to the Web Inspector
as a timing change, and these are denoted by vertical lines in the resources
panel (blue for DOM Content, red for load event).
- English.lproj/localizedStrings.js: Added tooltip text.
- dom/Document.cpp: (WebCore::Document::finishedParsing): Added an Inspector callback for DOM Content.
- inspector/InspectorController.cpp: (WebCore::InspectorController::mainResourceFiredDOMContentEvent): Tell the main resource it got the event. (WebCore::InspectorController::mainResourceFiredLoadEvent): Ditto.
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): Added new variables. (WebCore::InspectorResource::updateScriptObject): Send new variables to inspector.js. (WebCore::InspectorResource::markDOMContentEventTime): Send a TimingChange event. (WebCore::InspectorResource::markLoadEventTime): Ditto.
- inspector/InspectorResource.h:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.get mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Draw dividers for event timings. (WebInspector.ResourceTimeCalculator.prototype.computePercentageFromEventTime):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Add an Inspector callback for the Load event.
- 1:00 PM Changeset in webkit [49035] by
-
- 1 edit in trunk/WebKit/win/WebView.cpp
Fix Windows bustage.
- 12:57 PM Changeset in webkit [49034] by
-
- 2 edits in trunk/WebKitTools/DumpRenderTree
Update DUmpRenderTree to account for new API.
- 12:42 PM Changeset in webkit [49033] by
-
- 17 edits in trunk
Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.
Reviewed by Adam Roben.
WebCore:
- WebCore.base.exp:
- dom/Document.cpp:
(WebCore::Document::pageGroupUserSheets):
- page/Frame.cpp:
(WebCore::Frame::injectUserScriptsForWorld):
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):
- page/PageGroup.h:
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::matchesPatterns):
- page/UserContentURLPattern.h:
- page/UserScript.h:
(WebCore::UserScript::UserScript):
(WebCore::UserScript::whitelist):
(WebCore::UserScript::blacklist):
- page/UserStyleSheet.h:
(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::whitelist):
(WebCore::UserStyleSheet::blacklist):
WebKit/mac:
- WebView/WebView.mm:
(toStringVector):
(+[WebView _addUserScriptToGroup:source:url:worldID:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:source:url:worldID:whitelist:blacklist:]):
- WebView/WebViewPrivate.h:
WebKit/win:
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
- WebView.h:
- 11:41 AM Changeset in webkit [49032] by
-
- 2 edits1 add in trunk/WebKit
2009-10-02 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Added gyp_webkit that does a subset of the things gyp_chromium does
plus some specialization for an upstream chromium build.
- chromium/DEPS: Points to gyp_webkit instead of gyp_chromium.
- chromium/gyp_webkit: A new python file.
- 11:08 AM Changeset in webkit [49031] by
-
- 2 edits in trunk/WebKitLibraries
2009-10-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
<rdar://problem/7271334>
Rename MediaControllerThemeQT to MediaControllerThemeQuickTime
- WebKitSystemInterface.h: MediaControllerThemeQT -> MediaControllerThemeQuickTime
- 11:06 AM Changeset in webkit [49030] by
-
- 6 edits in trunk/JavaScriptCore
Rolled back in r49004 with the debug 64bit build fixed
- 11:02 AM Changeset in webkit [49029] by
-
- 2 edits in trunk/WebCore
2009-10-02 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Build fix when SVG is not enabled
https://bugs.webkit.org/show_bug.cgi?id=30011
Move TextRenderingMode related functions out from
the ENABLE(SVG) guard.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator TextRenderingMode):
- 10:57 AM Changeset in webkit [49028] by
-
- 2 edits in trunk/WebKitTools
2009-10-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
this will help the patch merging process when TryBots are used.
- Scripts/svn-create-patch:
- 10:49 AM Changeset in webkit [49027] by
-
- 3 edits2 adds in trunk
WebGL crashes with recent CanvasArray change
https://bugs.webkit.org/show_bug.cgi?id=30018
- 10:22 AM Changeset in webkit [49026] by
-
- 8 edits1 delete in trunk
<https://bugs.webkit.org/show_bug.cgi?id=29989>
Safari version number shouldn't be exposed in WebKit code
Reviewed by Mark Rowe.
For a WebKit version of 532.3.4:
Product version is: 5.32.3.4 (was 4.0.3.0)
File version is: 5.32.3.4 (was 4.532.3.4)
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:
WebCore:
- WebCore.vcproj/QTMovieWin.rc:
WebKit/win:
- WebKit.vcproj/WebKit.rc:
WebKitLibraries:
- win/tools/scripts/PRODUCTVERSION: Removed.
- win/tools/scripts/auto-version.sh: Re-worked script to remove references to PRODUCTVERSION.
- 10:19 AM Changeset in webkit [49025] by
-
- 2 edits in trunk/WebCore
Enable two point radial gradients in Chromium/Skia.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=30017
Covered by the following tests:
LayoutTests/svg/W3C-SVG-1.1/pservers-grad-13-b.svg
LayoutTests/fast/backgrounds/svg-as-background-3.html
LayoutTests/fast/gradients/generated-gradients.html
LayoutTests/fast/gradients/simple-gradients.html
- platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::platformGradient):
- 9:14 AM Changeset in webkit [49024] by
-
- 4 edits in trunk/WebKitTools
2009-10-02 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement layoutTestController.overridePreference().
https://bugs.webkit.org/show_bug.cgi?id=29970
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::overridePreference):
- DumpRenderTree/qt/jsobjects.h:
- 8:49 AM Changeset in webkit [49023] by
-
- 5 edits in trunk
2009-10-02 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
Otherwise, it is inconsistent with class declaration of QCursor.
- Api/qgraphicswebview.cpp:
- Api/qwebview.cpp:
2009-10-02 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
Otherwise, it is inconsistent with class declaration of QCursor.
No new tests.
- platform/qt/QWebPageClient.h:
- 8:40 AM Changeset in webkit [49022] by
-
- 2 edits in trunk/JavaScriptCore
Fix the Qt on Mac OS X build.
Rubber-stamped by Simon Hausmann.
- wtf/FastMalloc.cpp:
- 5:05 AM QtBackLog edited by
- (diff)
- 5:04 AM QtBackLog edited by
- (diff)
- 4:32 AM Changeset in webkit [49021] by
-
- 2 edits in trunk/WebCore
2009-10-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] missing support for anamorphic PAR video size
https://bugs.webkit.org/show_bug.cgi?id=29717
cleanup of caps handling in the video sink
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_set_caps):
- 4:18 AM Changeset in webkit [49020] by
-
- 34 edits in trunk
.: Disable a few more harmless MSVC warnings.
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.
- WebKit.pri:
WebCore: Fix compiler warnings about unused function arguments.
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.
- bridge/qt/qt_class.h:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
- dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::initializeParserContext):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::getCachedFontPlatformData):
- platform/graphics/qt/FontFallbackListQt.cpp:
(WebCore::FontFallbackList::setPlatformFont):
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setURLForRect):
- platform/graphics/qt/IconQt.cpp:
(WebCore::Icon::createIconForFiles):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameBufferAtIndex):
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::setEndTime):
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::containsCharacters):
- platform/graphics/qt/StillImageQt.h:
(WebCore::StillImage::destroyDecodedData):
- platform/network/qt/DnsPrefetchHelper.h:
(WebCore::DnsPrefetchHelper::lookedUp):
- platform/qt/ContextMenuQt.cpp:
(WebCore::ContextMenu::setPlatformDescription):
- platform/qt/DragDataQt.cpp:
(WebCore::DragData::asURL):
- platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::populate):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::supportsFocusRing):
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMediaSeekBackButton):
(WebCore::RenderThemeQt::paintMediaSeekForwardButton):
- platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::platformAddChild):
- platform/qt/SearchPopupMenuQt.cpp:
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
- platform/qt/TemporaryLinkStubs.cpp:
(WebCore::signedPublicKeyAndChallengeString):
- platform/qt/WidgetQt.cpp:
(WebCore::Widget::paint):
- xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::setParentStyleSheet):
- xml/XSLTProcessorQt.cpp:
(WebCore::XSLTMessageHandler::handleMessage):
(WebCore::XSLTProcessor::transformToString):
WebKit/qt: Fix compiler warnings about unused function arguments.
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.
- Api/qwebframe.cpp:
(QWebFrame::scrollBarMinimum):
- Api/qwebpage.cpp:
(QWebPagePrivate::focusInEvent):
(QWebPagePrivate::focusOutEvent):
(QWebPagePrivate::leaveEvent):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::triggerAction):
(QWebPage::acceptNavigationRequest):
(QWebPage::chooseFile):
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::mouseDidMoveOverElement):
(WebCore::ChromeClientQt::reachedMaxAppCacheSize):
- WebCoreSupport/ContextMenuClientQt.cpp:
(WebCore::ContextMenuClientQt::downloadURL):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
(WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
(WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
(WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientQt::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientQt::createJavaAppletWidget):
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::setAttachedWindowHeight):
(WebCore::InspectorClientQt::highlight):
(WebCore::InspectorClientQt::removeSetting):
- 4:14 AM Changeset in webkit [49019] by
-
- 3 edits in trunk/WebCore
2009-10-02 Ben Murdoch <benm@google.com>
Reviewed by David Kilzer.
Stale database version persists through browser refresh (changeVersion doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=27836
Scale the cairo surface of the video sink depending on the
pixel-aspect-ratio of the video buffer to paint. Also
destruct/re-create the surface when setSize() is called with a new
size.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::setSize): (WebCore::MediaPlayerPrivate::paint):
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
- 3:19 AM Changeset in webkit [49018] by
-
- 4 edits4 adds in trunk
Stale database version persists through browser refresh (changeVersion doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=27836
WebCore:
Reviewed by David Kilzer.
Tests: storage/change-version-handle-reuse.html
storage/change-version.html
- bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL): Implement the V8 binding for database.changeVersion().
(WebCore::createTransaction): Fix a bug that was checking the wrong argument index to save the success callback.
- storage/Database.cpp:
(WebCore::updateGuidVersionMap): Safely update the Guid/version hash map.
(WebCore::Database::~Database): Remove code that removes the database from the guid->database and guid->version maps.
(WebCore::Database::setVersionInDatabase): Add a comment to explain some behaviour.
(WebCore::Database::close): Move the code that updates the maps from the destructor to here.
(WebCore::Database::performOpenAndVerify): Call updateGuidVersionMap instead of setting the hash map directly.
(WebCore::Database::setExpectedVersion): Update the in memory guid->version map when we want to update the database version.
LayoutTests:
Reviewed by David Kilzer.
- storage/change-version-expected.txt: Added.
- storage/change-version-handle-reuse-expected.txt: Added.
- storage/change-version-handle-reuse.html: Added.
- storage/change-version.html: Added.
- 1:34 AM Changeset in webkit [49017] by
-
- 2 edits in trunk/WebCore
Partial WINSCW build fix.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-10-02
Reviewed by Simon Hausmann.
Add parentheses around the function pointer declaration, similar to the
second hunk in r48825.
- loader/CachedResourceHandle.h:
- 1:22 AM Changeset in webkit [49016] by
-
- 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h
Roll out accidential r49015 commit
- 1:21 AM Changeset in webkit [49015] by
-
- 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h
use wtf/unicode/qt4/unicodeQt4.h for RVCT and WINSCW
Relative includes don't work properly with WINSCW
- 1:20 AM Changeset in webkit [49014] by
-
- 2 edits in trunk/WebCore
2009-10-02 Adam Barth <abarth@webkit.org>
Unreviewed attempted build fix by Xcode magic.
- WebCore.xcodeproj/project.pbxproj:
- 1:03 AM Changeset in webkit [49013] by
-
- 1 edit2 adds in trunk/WebCore
2009-10-02 Adam Barth <abarth@webkit.org>
Unreviewed build fix. Actually add the new files.
- loader/RedirectScheduler.cpp: Added. (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
- loader/RedirectScheduler.h: Added.
- 12:57 AM Changeset in webkit [49012] by
-
- 9 edits in trunk/WebCore
2009-10-01 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move RedirectScheduler to its own file
https://bugs.webkit.org/show_bug.cgi?id=29952
This change is purely code motion.
No behavior change.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/RedirectScheduler.cpp: Added. (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
- loader/RedirectScheduler.h: Added.
- 12:41 AM Changeset in webkit [49011] by
-
- 2 edits in trunk/WebCore
2009-10-02 Dave MacLachlan <dmaclach@gmail.com>
Reviewed by David Levin.
Clean up warnings in WebCore/bindings/v8/npruntime.cpp
https://bugs.webkit.org/show_bug.cgi?id=29971
Gets rid of warnings on gcc about using anonymous namespaces
warning: 'StringKeyHashTraits' has a base
'WTF::GenericHashTraits<<unnamed>::StringKey>'
whose type uses the anonymous namespace
and
warning: 'WTF::PairHashTraits<StringKeyHashTraits,
WTF::HashTraits<PrivateIdentifier*> >' has a base
'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
PrivateIdentifier*> >' whose type uses the anonymous namespace
No tests required.
- bindings/v8/npruntime.cpp:
- 12:31 AM Changeset in webkit [49010] by
-
- 2 edits in trunk/JavaScriptCore
Allow enabling and disabling of the JIT through a qmake variable.
Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.
Qt's configure may set this variable through .qmake.cache if a
commandline option is given and/or the compile test for hwcap.h
failed/succeeded.
- JavaScriptCore.pri:
Oct 1, 2009:
- 9:01 PM Changeset in webkit [49009] by
-
- 3 edits in trunk/LayoutTests
2009-10-01 Drew Wilson <atwilson@chromium.org>
Reviewed by David Levin.
Remove clone count from worker-cloneport.html as it's flakey on multi-process ports like Chromium.
https://bugs.webkit.org/show_bug.cgi?id=29698
- fast/workers/worker-cloneport-expected.txt:
- fast/workers/worker-cloneport.html:
- 7:50 PM Changeset in webkit [49008] by
-
- 6 edits in trunk
Fix the Tiger build. Don't unconditionally enable 3D canvas as it is not supported on Tiger.
- 5:58 PM Changeset in webkit [49007] by
-
- 2 edits in trunk
2009-10-01 Laszlo Gombos <Laszlo Gombos>
Unreviewed, build fix.
[Qt] Symbian build break after r48976.
unix is set for Symbian in the Qt build system.
- WebKit.pri:
- 5:25 PM Changeset in webkit [49006] by
-
- 30 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=29906
Turn on compile time switch for WebGL, but have runtime switch default to off
This also fixes LayoutTests which broke with the flag turned on, and
fixes a crash found in the LayoutTests.
- 4:49 PM Changeset in webkit [49005] by
-
- 6 edits in trunk/JavaScriptCore
Roll out r49004 since it broke the debug build.
- 4:32 PM Changeset in webkit [49004] by
-
- 6 edits in trunk/JavaScriptCore
Take one branch instead of two to test for JSValue().
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-01
Reviewed by Sam Weinig.
1.1% SunSpider speedup.
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_create_arguments):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.
- runtime/JSValue.cpp:
(JSC::JSValue::description): Added support for dumping the new empty value,
and deleted values, in debug builds.
- runtime/JSValue.h:
(JSC::JSValue::JSValue()): Construct JSValue() with the empty value tag.
(JSC::JSValue::JSValue(JSCell*)): Convert null pointer to the empty value
tag, to avoid having two different c++ versions of null / empty.
(JSC::JSValue::operator bool): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.
- 4:00 PM Changeset in webkit [49003] by
-
- 14 edits in trunk
WebCore: Fix for <rdar://problem/7264725> Re-add a vendor prefix to box-
shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927
Reviewed by Dan Bernstein.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitValue):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitColor):
(WebCore::cssPropertyID):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- page/animation/AnimationBase.cpp:
(WebCore::ensurePropertyMap):
LayoutTests: Updated test results for <rdar://problem/7264725> Re-add a vendor
prefix to box-shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927
Reviewed by Dan Bernstein.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 3:21 PM Changeset in webkit [49002] by
-
- 2 edits in trunk/WebKit
2009-10-01 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Make it possible to override the list of feature defines when building
downstream.
- chromium/features.gypi:
- 2:56 PM Changeset in webkit [49001] by
-
- 2 edits in trunk/LayoutTests
2009-10-01 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Added fast/inline/relative-positioned-overflow.html to Skipped list because
it hits an asssert in Windows debug builds. Assertion failure is being tracked
by <https://bugs.webkit.org/show_bug.cgi?id=29966>.
- platform/win/Skipped:
- 2:24 PM Changeset in webkit [49000] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
Appeasing the Bot.
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- 2:19 PM Changeset in webkit [48999] by
-
- 3 edits1 add in trunk/LayoutTests
2009-10-01 Brian Weinstein <bweinstein@apple.com>
Reviewed by Beth Dakin.
Update expected Windows results after new CSS Text Kerning changes.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/text-rendering-expected.txt: Added.
- 1:46 PM Changeset in webkit [48998] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-01 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Set the type for the fake event, otherwise the test ASSERTs in
debug builds.
- tests/testhittestresult.c: (load_status_cb):
- 1:44 PM Changeset in webkit [48997] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Simon Hausmann.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Disable HTTP loading tests that fail on the buildbot.
- platform/qt/Skipped:
- 1:27 PM Changeset in webkit [48996] by
-
- 3 edits in trunk/LayoutTests
REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=29344
Reviewed by Eric Seidel.
- fast/workers/resources/dedicated-worker-lifecycle.js:
(runTests):
Allocate objects on the stack to try to force a GC to eliminate flakiness.
- fast/workers/resources/worker-util.js:
(gc):
Added an optional "forceAlloc" parameter which causes a more extensive stack-clobbering algorithm to be run.
(waitUntilThreadCountMatches):
Pass the forceAlloc flag to gc() to try to force unreferenced workers to get GC'd.
- 1:24 PM Changeset in webkit [48995] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Sam Weinig.
At bad merge at some point in the development of my patch must have
put TextRenderMode.h in a weird spot in the xcodeproj. Moving it
back where it belongs!
- WebCore.xcodeproj/project.pbxproj:
- 1:12 PM Changeset in webkit [48994] by
-
- 13 edits in trunk/WebCore
2009-10-01 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove FrameLoader::schedule* APIs
https://bugs.webkit.org/show_bug.cgi?id=29950
Change clients of FrameLoader::schedule* to call redirectScheduler
directly.
No behavior change.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::createWindow): (WebCore::JSDOMWindow::open):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::reload):
- bindings/v8/V8Utilities.cpp: (WebCore::navigateIfAllowed):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::processHttpEquiv):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::receivedFirstData):
- loader/FrameLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
- page/History.cpp: (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
- 1:08 PM Changeset in webkit [48993] by
-
- 2 edits in trunk/WebCore
Just removing a comment I accidentally committed earlier.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes):
- 12:54 PM Changeset in webkit [48992] by
-
- 3 edits in trunk/WebCore
2009-09-30 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Clean up use of const and mutable in StorageMap
https://bugs.webkit.org/show_bug.cgi?id=29933
What's the point of having every single member variable be mutable and nearly
every method be const? Let's clean it up.
- storage/StorageMap.cpp: (WebCore::StorageMap::setIteratorToIndex): (WebCore::StorageMap::key): (WebCore::StorageMap::importItem):
- storage/StorageMap.h:
- 12:32 PM Changeset in webkit [48991] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Simon Hausmann.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable Local tests for Qt.
- platform/qt/Skipped:
- 12:21 PM Changeset in webkit [48990] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Simon Hausmann.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP loading tests for Qt.
- platform/qt/Skipped:
- 12:19 PM Changeset in webkit [48989] by
-
- 29 edits8 adds in trunk
WebCore: Fix for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136
Reviewed by Dave Hyatt.
This patch makes the SVG CSS property text-rendering work with any
HTML, much like it does in Firefox. It accepts four possible input
values: auto, optimizeSpeed, optimizeLegibility, and
geometricPrecision. Right now, in this implementation, here is what
those values correspond to:
auto = optimizeSpeed = what we normally when the value's not set
optimizeLegibility = geometricPrecision = ligatures + kerning
Add new file TextRenderingMode.h to the project files.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
CSS support for the new CSSPropertyTextRendering
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
All the old SVG CSS support for this property can go away. When
it's used in SVG, it will just fall into the normal HTML case.
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/SVGCSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
- css/SVGCSSValueKeywords.in:
FontDescription stores the m_textRendering bit.
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::textRenderingMode):
(WebCore::FontDescription::setTextRenderingMode):
(WebCore::FontDescription::operator==):
We want to fall into the complex text rendering code path if
kerning and ligatures have been enabled with this property.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache):
Now takes a TextRenderingMode as a parameter.
- platform/graphics/SimpleFontData.h:
New header for the enum.
- platform/graphics/TextRenderingMode.h: Added.
(WebCore::):
getCFStringAttributes() now takes a TextRenderingMode as an
attribute.
- platform/graphics/mac/CoreTextController.cpp:
(WebCore::CoreTextController::collectCoreTextRunsForCharacters):
Enable kerning and ligatures whenever the TextRenderingMode is
OptimizeLegibility or GeometricPrecision
- platform/graphics/mac/FontMacATSUI.mm:
(WebCore::disableLigatures):
(WebCore::initializeATSUStyle):
(WebCore::ATSULayoutParameters::initialize):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes):
More SVG CSS stuff that isn't needed anymore since SVG will use the
new HTML CSS implementation.
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::InheritedFlags::operator==):
(WebCore::SVGRenderStyle::setBitDefaults):
- rendering/style/SVGRenderStyleDefs.h:
LayoutTests: Tests for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136
Reviewed by Dave Hyatt.
New tests.
- fast/css/parsing-text-rendering-expected.txt: Added.
- fast/css/parsing-text-rendering.html: Added.
- fast/css/resources/parsing-text-rendering.js: Added.
(test):
- fast/css/text-rendering.html: Added.
- platform/mac/fast/css/text-rendering-expected.checksum: Added.
- platform/mac/fast/css/text-rendering-expected.png: Added.
- platform/mac/fast/css/text-rendering-expected.txt: Added.
New and improved results.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 12:18 PM Changeset in webkit [48988] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-01 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Darin Adler.
Don't inline ~ListRefPtr() to work around winscw compiler forward declaration
bug regarding templated classes.
The compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812
The change will be reverted when the above bug is fixed in winscw compiler.
- wtf/ListRefPtr.h: (WTF::::~ListRefPtr):
- 12:10 PM Changeset in webkit [48987] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Simon Hausmann.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable URI tests for Qt, skip the single test we don't pass.
- platform/qt/Skipped:
- 11:29 AM Changeset in webkit [48986] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-01 Nate Chapin <Nate Chapin>
Reviewed by Darin Adler.
Add baseline pngs for a couple of tests that currently only have checksums.
- platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
- platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
- 11:14 AM Changeset in webkit [48985] by
-
- 4 edits in trunk
Rubberstamped by Simon Hausmann.
WebKitTools:
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt
- Scripts/run-webkit-tests:
LayoutTests:
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt, and skip the subdirs we don't pass yet.
- platform/qt/Skipped:
- 11:08 AM Changeset in webkit [48984] by
-
- 4 edits in trunk
2009-10-01 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Added windows-specific dependencies, updated some revisions and
re-organized file to make revision tracking easier. Also removed
extensions/v8 dependency that is no longer needed upstream.
- chromium/DEPS:
2009-10-01 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
build-webkit --chromium now also works on cygwin.
- Scripts/webkitdirs.pm:
- 10:41 AM Changeset in webkit [48983] by
-
- 2 edits in trunk/WebCore
2009-10-01 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Use isClosure property of scope proxy to decide whether the
scope is a closure.
- inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
- 10:29 AM Changeset in webkit [48982] by
-
- 3 edits2 adds in trunk
2009-10-01 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Odd color transitions on anchors with transition-property: all
https://bugs.webkit.org/show_bug.cgi?id=29911
When transitioning maybe-invalid colors, if the source and destination
color are both invalid, then don't animate.
This fixes an issue where a child element of an element running a color
transition, with -webkit-transition-property:all, would show a color change.
This happened because the "maybe invalid color" logic copied the color style
into -webkit-text-fill-color for both endpoints, causing -webkit-text-fill-color
to animate while the transition ran, and to then to disappear when the transition
finished.
Test: transitions/color-transition-all.html
- page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperMaybeInvalidColor::equals): (WebCore::PropertyWrapperMaybeInvalidColor::blend):
- 10:25 AM Changeset in webkit [48981] by
-
- 3 edits3 adds in trunk
2009-10-01 Victor Wang <victorw@chromium.org>
Reviewed by Oliver Hunt.
Allow dragging a node who has child nodes.
- fast/events/drag-parent-node-expected.txt: Added.
- fast/events/drag-parent-node.html: Added.
- fast/events/resources/bookmark.gif: Added.
2009-10-01 Victor Wang <victorw@chromium.org>
Reviewed by Oliver Hunt.
Allow dragging a node who has child nodes.
Test: fast/events/drag-parent-node.html
- page/EventHandler.cpp: (WebCore::EventHandler::shouldDragAutoNode):
- 10:17 AM Changeset in webkit [48980] by
-
- 2 edits in trunk/WebCore
2009-10-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] media player: better mute support
https://bugs.webkit.org/show_bug.cgi?id=29960
Handle volume and mute state with the two corresponding properties
of playbin2.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setVolume):
- 10:09 AM Changeset in webkit [48979] by
-
- 2 edits in trunk/WebCore
2009-10-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] video sink pad template colorspace is wrong
https://bugs.webkit.org/show_bug.cgi?id=29953
Set sink pad template colorspace depending on byte order.
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
- 10:01 AM Changeset in webkit [48978] by
-
- 37 edits4 deletes in trunk/WebCore
2009-10-01 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Refactored V8 event listeners:
(This change should fix http://crbug.com/21079 and
https://bugs.webkit.org/show_bug.cgi?id=29093.)
o All listeners use weak handles to JS objects to avoid creating
cycles and leaking memory.
o "Object" variants of listeners removed.
o All event accessor callbacks are generated.
o Custom event accessors removed.
o All wrappers have hidden dependencies on their listeners to
prevent listeners from being collected.
o All variats of getEventListener function grouped in V8DOMWrapper.
o Pointers to C++ EventListener wrappers are stored in JS objects
instead of event listener lists.
- WebCore.gypi: Removed "Object" listeners.
- bindings/scripts/CodeGeneratorV8.pm: Now handles event accessors.
- bindings/v8/DOMObjectsInclude.h:
V8AbstractEventListener manages weak JS handle:
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::weakEventListenerCallback): (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::~V8AbstractEventListener): (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::disposeListenerObject): (WebCore::V8AbstractEventListener::setListenerObject):
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::cast): (WebCore::V8AbstractEventListener::isLazy): (WebCore::V8AbstractEventListener::getListenerObject): (WebCore::V8AbstractEventListener::getExistingListenerObject): (WebCore::V8AbstractEventListener::hasExistingListenerObject): (WebCore::V8AbstractEventListener::disconnectFrame): (WebCore::V8AbstractEventListener::disconnected): (WebCore::V8AbstractEventListener::prepareListenerObject): (WebCore::V8AbstractEventListener::lineNumber): (WebCore::V8AbstractEventListener::virtualisAttribute):
Grouped getEventListener functions:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::getEventListener):
- bindings/v8/V8DOMWrapper.h:
Removed most event listener objects bookkeeping:
- bindings/v8/V8EventListenerList.cpp:
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findWrapper): (WebCore::V8EventListenerList::clearWrapper): (WebCore::V8EventListenerList::doFindWrapper): (WebCore::V8EventListenerList::getHiddenProperty): (WebCore::V8EventListenerList::findOrCreateWrapper):
Added hidden properties for storing EventListener wrappers:
- bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::listener): (WebCore::V8HiddenPropertyName::attributeListener):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::callListenerFunction): (WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::isLazy):
- bindings/v8/V8ObjectEventListener.cpp: Removed.
- bindings/v8/V8ObjectEventListener.h: Removed.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::disconnectFrame): (WebCore::V8Proxy::disconnectEventListeners):
- bindings/v8/V8Proxy.h:
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::reportError): (WebCore::V8WorkerContextEventListener::getReceiverObject):
- bindings/v8/V8WorkerContextEventListener.h:
- bindings/v8/V8WorkerContextObjectEventListener.cpp: Removed.
- bindings/v8/V8WorkerContextObjectEventListener.h: Removed.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): (WebCore::V8EventListener::getListenerFunction): (WebCore::V8EventListener::callListenerFunction):
- bindings/v8/custom/V8CustomEventListener.h:
- bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getEventListener): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WebSocketCustom.cpp:
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
- 9:59 AM Changeset in webkit [48977] by
-
- 3 edits in trunk/WebKit/qt
Make Software Input Panel requests work with QGraphicsWebView
_and_ QWebView by sharing the event code in handleSoftwareInputPanel().
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.
- Api/qwebpage.cpp:
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::handleSoftwareInputPanel):
- Api/qwebpage_p.h:
- 9:22 AM Changeset in webkit [48976] by
-
- 8 edits in trunk
2009-10-01 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Allow custom memory allocation control for the whole JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=27029
Since in JavaScriptCore almost every class which has been instantiated by operator new is
inherited from FastAllocBase (bug #20422), we disable customizing global operator new for the Qt-port
when USE_SYSTEM_MALLOC=0.
Add #include <unistd.h> to FastMalloc.cpp because it's used by TCMalloc_PageHeap::scavengerThread().
(It's needed for the functionality of TCmalloc.)
Add TCSystemAlloc.cpp to JavaScriptCore.pri if USE_SYSTEM_MALLOC is disabled.
- JavaScriptCore.pri:
- wtf/FastMalloc.cpp: (WTF::sleep):
- wtf/FastMalloc.h:
2009-10-01 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Don't use TCmalloc in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=27029
Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
- DumpRenderTree/qt/DumpRenderTree.pro:
2009-10-01 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Enable TCmalloc for the Linux, Mac and Windows Qt-port
https://bugs.webkit.org/show_bug.cgi?id=27029
Remove USE_SYSTEM_MALLOC for Linux, Mac and Windows Qt-port from WebKit.pri,
so these Qt-ports will use TCmalloc as other ports.
- WebKit.pri:
- 8:35 AM Changeset in webkit [48975] by
-
- 1 edit2 adds in trunk/LayoutTests
Land expected failure results for two tests on Windows
These failures are covered by <http://webkit.org/b/29963> and
<http://webkit.org/b/29964>.
Rubber-stamped in advance by Eric Carlson.
- platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt:
Added.
- platform/win/fast/forms/basic-inputs-expected.txt: Added.
- 8:28 AM Changeset in webkit [48974] by
-
- 7 edits2 copies2 moves1 add1 delete in trunk
Rename QWebGraphicsItem to QGraphicsWebView
Patch by Alexis Menard <alexis.menard@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.
- 8:26 AM Changeset in webkit [48973] by
-
- 2 edits in trunk/WebCore
2009-10-01 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Read-only transactions do not change file sizes and therefore
should not trigger quota updates.
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::runStatements):
- 7:31 AM Changeset in webkit [48972] by
-
- 4 edits in trunk/WebKit/qt
2009-09-28 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29248
[Qt] [API] Make it possible to have 'invisible' loads
Make QWebFrame's setHtml and setContent methods to not change
session and global history at all.
- Api/qwebframe.cpp: (QWebFrame::setHtml): (QWebFrame::setContent):
- tests/qwebframe/qwebframe.pro:
- tests/qwebframe/tst_qwebframe.cpp:
- 6:18 AM Changeset in webkit [48971] by
-
- 5 edits in trunk/WebCore
Fix list box scrolling by correctly overriding the scroll()
function on RenderBox.
<rdar://problem/7255440> REGRESSION (r48683): Mousewheel scrolling
of listboxes is broken (29756)
Reviewed by Dan Bernstein.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scroll):
- rendering/RenderListBox.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::scroll):
- rendering/RenderTextControlSingleLine.h:
- 6:17 AM Changeset in webkit [48970] by
-
- 2 edits in trunk/WebCore
2009-10-01 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Make a copy of listeners array before dispatching an event in
WebInspector.Object.prototype.dispatchEventToListeners. Otherwise if current
listener removes itself from the array next listener will be skipped.
- inspector/front-end/Object.js: (WebInspector.Object.prototype.dispatchEventToListeners): make a copy of listeners array before dispatching an event
- 6:02 AM Changeset in webkit [48969] by
-
- 2 edits in trunk/LayoutTests
2009-10-01 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Skip fast/table/008.html until a solution for the crash on the buildbot is found.
- platform/qt/Skipped:
- 5:43 AM Changeset in webkit [48968] by
-
- 3 edits in trunk/WebKit/qt
Fixed software input panel support on web input elements.
Patch by Kristian Amlie <kristian.amlie@nokia.com> on 2009-10-01
Reviewed by Simon Hausmann.
Send the RequestSoftwareInputPanel event if the element supports focus
and the element is clicked.
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseReleaseEvent):
- Api/qwebpage_p.h:
- 5:43 AM Changeset in webkit [48967] by
-
- 4 edits in trunk/WebKit/qt
Implementation for QWebPage::inputMethodQuery and QWebPagePrivate::inputMethodEvent
Patch by Joe Ligman <joseph.ligman@nokia.com> on 2009-10-01
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29681
Some additional changes from Kristian Amlie <kristian.amlie@nokia.com>:
- Fixed surrounding text to exclude preedit string
- Avoid emission of microFocusChanged during setComposition()
- Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent):
(QWebPage::inputMethodQuery):
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::respondToChangedSelection):
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods):
- 4:28 AM QtWebKitProfilingSetup edited by
- (diff)
- 3:43 AM Changeset in webkit [48966] by
-
- 5 edits in trunk
2009-10-01 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement eventSender.scheduleAsynchronousClick().
- platform/qt/Skipped:
2009-10-01 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement eventSender.scheduleAsynchronousClick().
- DumpRenderTree/qt/jsobjects.cpp: (EventSender::scheduleAsynchronousClick):
- DumpRenderTree/qt/jsobjects.h:
- 3:35 AM Changeset in webkit [48965] by
-
- 5 edits in trunk
2009-10-01 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
fast/events/open-window-from-another-frame.html from the Skipped list.
- platform/qt/Skipped:
2009-10-01 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
fast/events/open-window-from-another-frame.html from the Skipped list.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::setPopupBlockingEnabled):
- DumpRenderTree/qt/jsobjects.h:
- 2:02 AM Changeset in webkit [48964] by
-
- 8 edits1 add in trunk
2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733
Add new key event test ensuring that IME keypresses are handled.
- GNUmakefile.am:
2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733
Re-enable skipped tests which were previously failing.
- platform/gtk/Skipped:
2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733
Ensure that keyboard events filtered by the GtkIMContext still create
the proper DOM events.
No tests added. Instead previously skipped tests have been enabled.
- platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode): (WebCore::singleCharacterString):
2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733
Ensure that keyboard events filtered by the GtkIMContext still create
the proper DOM events.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::clearPendingIMData): (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged): (WebKit::EditorClient::shouldBeginEditing): (WebKit::EditorClient::shouldEndEditing): (WebKit::interpretEditorCommandKeyEvent): (WebKit::handleCaretBrowsingKeyboardEvent): (WebKit::EditorClient::handleKeyboardEvent): (WebKit::EditorClient::handleInputMethodKeydown):
- tests/testkeyevents.c: Added. (test_info_new): (test_info_destroy): (key_event_fixture_setup): (key_event_fixture_teardown): (key_press_event_cb): (key_release_event_cb): (load_status_cb): (map_event_cb): (test_keypress): (main):
- 1:19 AM Changeset in webkit [48963] by
-
- 7 edits2 adds in trunk
2009-10-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842
Check presence of gstreamer-pbutils-0.10.
- configure.ac:
2009-10-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842
Re-enable media/audio-data-url.html.
- platform/gtk/Skipped:
2009-10-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842
New GStreamer element to handle data: uris. For now only base64
encoded data is supported. Decoded data is handed over to
giostreamsrc.
- GNUmakefile.am:
- platform/graphics/gtk/DataSourceGStreamer.cpp: Added. (_do_init): (webkit_data_src_base_init): (webkit_data_src_class_init): (webkit_data_src_reset): (webkit_data_src_init): (webkit_data_src_finalize): (webkit_data_src_uri_get_type): (webkit_data_src_uri_get_protocols): (webkit_data_src_uri_get_uri): (webkit_data_src_uri_set_uri): (webkit_data_src_uri_handler_init):
- platform/graphics/gtk/DataSourceGStreamer.h: Added.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::mimeTypeCache):
Sep 30, 2009:
- 11:24 PM Changeset in webkit [48962] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Added myself to the list of committers.
- Scripts/modules/committers.py:
- 10:56 PM Changeset in webkit [48961] by
-
- 10 edits7 adds in trunk
2009-09-30 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Reduces false positives in the XSSAuditor by explicitly allowing requests
that do not contain illegal URI characters.
As a side effect of this change, the tests property-inject.html,
property-escape-noquotes.html, and property-escape-noquotes-tab-slash-chars.html
fail because these attacks do not contain any illegal URI characters and
thus are now allowed by the XSSAuditor, where previously they weren't. A future
change may reinstate this functionality.
Tests: http/tests/security/xssAuditor/script-tag-safe2.html
http/tests/security/xssAuditor/script-tag-safe3.html
- page/XSSAuditor.cpp: (WebCore::isIllegalURICharacter): Added method. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::findInRequest): Added parameter allowRequestIfNoIllegalURICharacters.
- page/XSSAuditor.h:
2009-09-30 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Tests that the XSSAuditor allows requests that do not contain illegal URI
characters.
Added a notice regarding the failure of tests property-inject.html,
property-escape-noquotes.html and property-escape-noquotes-tab-slash-chars.html,
and rebased the expected results of these tests.
- http/tests/security/xssAuditor/property-escape-noquotes-expected.txt:
- http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt:
- http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html:
- http/tests/security/xssAuditor/property-escape-noquotes.html:
- http/tests/security/xssAuditor/property-inject-expected.txt:
- http/tests/security/xssAuditor/property-inject.html:
- http/tests/security/xssAuditor/resources/safe-script-noquotes.js: Added.
- http/tests/security/xssAuditor/resources/script-tag-safe2.html: Added.
- http/tests/security/xssAuditor/resources/script-tag-safe3.html: Added.
- http/tests/security/xssAuditor/script-tag-safe2-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-safe2.html: Added.
- http/tests/security/xssAuditor/script-tag-safe3-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-safe3.html: Added.
- 10:52 PM Changeset in webkit [48960] by
-
- 2 edits1 add in trunk/WebCore
reproducible freeze and crash on closing form popup at bosch-home.nl
https://bugs.webkit.org/show_bug.cgi?id=28948
Reviewed by Maciej Stachowiak.
showModalDialog calls getDirect on what is actually a window shell,
so ends up not getting a value (since no value can ever be placed
directly on the shell), which leads to incorrect behaviour.
We use a manual test rather than automatic as it was not
possible to get a modal run loop to work inside DRT.
- 10:49 PM Changeset in webkit [48959] by
-
- 8 edits6 adds in trunk
2009-09-30 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add ValidityState.tooLong support for <input> and <textarea>.
https://bugs.webkit.org/show_bug.cgi?id=27454
- fast/forms/ValidityState-tooLong-input-expected.txt: Added.
- fast/forms/ValidityState-tooLong-input.html: Added.
- fast/forms/ValidityState-tooLong-textarea-expected.txt: Added.
- fast/forms/ValidityState-tooLong-textarea.html: Added.
- fast/forms/script-tests/ValidityState-tooLong-input.js: Added.
- fast/forms/script-tests/ValidityState-tooLong-textarea.js: Added.
2009-09-30 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Adds ValidityState.tooLong support for <input> and <textarea>.
Introduces tooLong() in HTMLFormControlElement and it always returns false.
HTMLInputElement and HTMLTextAreaElement overrides it and checks the text
length and maxLength. tooLong() should work only for `dirty' values.
So, introduces m_isDirty flag for HTMLTextAreaElement, and
!m_data.value().isNull() works as a dirty flag for HTMLInputElement.
Renames parameter names of setMaxLength().
Tests: fast/forms/ValidityState-tooLong-input.html
fast/forms/ValidityState-tooLong-textarea.html
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::tooLong):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::tooLong): (WebCore::HTMLInputElement::setMaxLength):
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): (WebCore::HTMLTextAreaElement::reset): (WebCore::HTMLTextAreaElement::updateValue): (WebCore::HTMLTextAreaElement::setMaxLength): (WebCore::HTMLTextAreaElement::tooLong):
- html/HTMLTextAreaElement.h:
- html/ValidityState.h: (WebCore::ValidityState::tooLong):
- 10:12 PM QtWebKitProfilingSetup edited by
- (diff)
- 10:11 PM QtWebKitProfilingSetup edited by
- (diff)
- 10:06 PM QtWebKitProfilingSetup edited by
- (diff)
- 10:04 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:52 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:42 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:39 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:37 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:30 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:25 PM Changeset in webkit [48958] by
-
- 5 edits in trunk/WebCore
2009-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Factor RedirectScheduler out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=29948
This change introduces a new sub-object of Frame, redirectScheduler.
The redirectScheduler is responsible for scheduling redirects.
This change leaves the code for the redirectScheduler in
FrameLoader.cpp. A future change will move the class into its own
file.
No behavior change (hopefully!).
- loader/FrameLoader.cpp: (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::cancelAndClear): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::isScheduledLocationChangePending): (WebCore::FrameLoader::scheduleHTTPRedirection): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::FrameLoader::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::FrameLoader::scheduleRefresh): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::FrameLoader::scheduleHistoryNavigation): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel): (WebCore::FrameLoader::completed): (WebCore::FrameLoader::open):
- loader/FrameLoader.h: (WebCore::FrameLoader::committedFirstRealDocumentLoad):
- page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::redirectScheduler):
- page/Frame.h:
- 9:22 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:02 PM QtWebKitProfilingSetup created by
- 8:37 PM Changeset in webkit [48957] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
More Windows build fixes for https://bugs.webkit.org/show_bug.cgi?id=29943
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
- 8:18 PM QtBackLog edited by
- (diff)
- 8:17 PM QtWebKitPerformanceWork edited by
- (diff)
- 8:14 PM Changeset in webkit [48956] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
Fix windows build for fix for https://bugs.webkit.org/show_bug.cgi?id=29943
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
- 8:12 PM QtWebKitMirrorGuide edited by
- (diff)
- 7:59 PM Changeset in webkit [48955] by
-
- 11 edits3 adds in trunk/WebCore
2009-09-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[V8] HTMLAudioElement, HTMLImageElement, and HTMLOptionElement are constructable, but they shouldn't be.
Only Audio, Image, and Option should be constructable.
https://bugs.webkit.org/show_bug.cgi?id=29940
Test: fast/dom/dom-constructor.html
- WebCore.gypi: Added new files to project.
- bindings/scripts/CodeGeneratorV8.pm: Modified to generate custom constructors.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed handling of HTMLImageElement, HTMLOptionElement and HTMLAudioElement construction.
- bindings/v8/V8HTMLAudioElementConstructor.h: Added.
- bindings/v8/V8HTMLImageElementConstructor.h: Added.
- bindings/v8/V8HTMLOptionElementConstructor.h: Added.
- bindings/v8/V8Index.cpp: Added new headers.
- bindings/v8/V8Index.h: Added Audio, Image and Option decls.
- bindings/v8/custom/V8CustomBinding.h: Ditto.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): Added custom constructors.
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8HTMLImageElementConstructor::GetTemplate): Added custom template creator.
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::V8HTMLOptionElementConstructor::GetTemplate): Ditto.
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8HTMLImageElementConstructor::GetTemplate): Ditto.
- 6:13 PM Changeset in webkit [48954] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-30 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by George Staikos.
Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
https://bugs.webkit.org/show_bug.cgi?id=29122
Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
when Thumb-2 instruction set is the required target. The
PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
case where the code is common the PLATFORM(ARM) have to be used.
Modified by George Wright <gwright@rim.com> to correctly work
with the RVCT-defined TARGET_ARCH_ARM and TARGET_ARCH_THUMB
compiler macros, as well as adding readability changes.
- wtf/Platform.h:
- 6:09 PM Changeset in webkit [48953] by
-
- 7 edits in trunk
2009-09-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Brady Eidson.
307 redirects should pass along http body and Content-Type header
https://bugs.webkit.org/show_bug.cgi?id=29943
Follow-up fix for:
<rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET
Test: http/tests/loading/resources/redirect-methods-result.php
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Pass along http body and Content-Type header.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): ditto
2009-09-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Brady Eidson.
307 redirects should pass along http body and Content-Type header
https://bugs.webkit.org/show_bug.cgi?id=29943
Follow-up fix for:
<rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET
- http/tests/loading/redirect-methods.html: Updated test to show the http body and content-type header.
- http/tests/loading/redirect-methods-expected.txt:
- http/tests/loading/resources/redirect-methods-result.php:
- 5:40 PM Changeset in webkit [48952] by
-
- 4 edits in trunk/WebCore
Fixed https://bugs.webkit.org/show_bug.cgi?id=29941
REGRESSION (r48882-r48888): Many memory leaks on SnowLeopard leaks bot
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-30
Reviewed by Mark Rowe.
Forgot to implement a destructor for JSDOMWindowBaseData, so it was
leaking its RefPtr data member.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::destroyJSDOMWindowBaseData):
- bindings/js/JSDOMWindowBase.h:
(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData::JSDOMWindowBaseData):
- 5:13 PM Changeset in webkit [48951] by
-
- 2 edits in trunk/WebCore
Make sure the removal of user stylesheets results in all of the WebViews being updated to
reflect the changes.
Reviewed by Tim Hatcher.
- page/PageGroup.cpp:
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):
- 3:30 PM Changeset in webkit [48950] by
-
- 3 edits1 move in trunk/LayoutTests
2009-09-30 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Use a script-tests directory rather than a resources directory for DOM Storage
https://bugs.webkit.org/show_bug.cgi?id=29938
Use a script-tests directory rather than a resources directory for DOM Storage.
This matches up with what's been done elsewhere in the tree.
- storage/domstorage/localstorage/clear.html:
- storage/domstorage/resources: Removed.
- storage/domstorage/resources/clear.js: Removed.
- storage/domstorage/script-tests: Copied from LayoutTests/storage/domstorage/resources.
- storage/domstorage/sessionstorage/clear.html:
- 3:06 PM Changeset in webkit [48949] by
-
- 2 edits in trunk/WebKitTools
2009-09-30 Eric Seidel <eric@webkit.org>
No review, just adding Geoff to the list of reviewers.
- Scripts/modules/committers.py:
- 2:42 PM WikiStart edited by
- Point the coding style guidelines to the offical on the WebKit website. (diff)
- 2:32 PM Changeset in webkit [48948] by
-
- 2 edits in trunk/JavaScriptCore
Devirtualise array toString conversion
Reviewed by Geoff Garen.
Tweak the implementation of Array.prototype.toString to have a fast path
when acting on a true JSArray.
- 2:15 PM Changeset in webkit [48947] by
-
- 4 edits2 adds in trunk
REGRESSION(r47440): drop down menus at americanexpress.com disappear on mouse out
https://bugs.webkit.org/show_bug.cgi?id=29209
Reviewed by Sam Weinig.
WebCore:
Test: fast/inline/relative-positioned-overflow.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeVerticalOverflow): Add self-painting
inlines to overflow to ensure that they are included in hit-testing.
LayoutTests:
- fast/inline/relative-positioned-overflow-expected.txt: Added.
- fast/inline/relative-positioned-overflow.html: Added.
- platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
- 1:56 PM Changeset in webkit [48946] by
-
- 7 edits in trunk/WebKit
Fix for <rdar://problem/7259706>
Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window
Reviewed by Dan Bernstein.
WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _allowsFollowingLink:]):
- WebView/WebFramePrivate.h:
WebKit/win:
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
(WebFrame::allowsFollowingLink):
- WebFrame.h:
- 1:19 PM Changeset in webkit [48945] by
-
- 3 edits1 add in trunk/WebCore
2009-09-30 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
transforms/3d tests are not run in Release builds
https://bugs.webkit.org/show_bug.cgi?id=29827
Make sure we export the WebCoreHas3DRendering symbol in Release builds,
because this symbols is used by run-webkit-tests (via 'nm') to detect whether
WebCore was built with ENABLE_3D_RENDERING turned on.
- DerivedSources.make:
- WebCore.3DRendering.exp: Added.
- WebCore.xcodeproj/project.pbxproj:
- 12:44 PM Changeset in webkit [48944] by
-
- 1 edit2 adds in trunk/WebKitTools
Added the WebKit Layout Tests fonts that are referenced in
LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
Reviewed by Sam Weinig.
- DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
- DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
- 12:38 PM Changeset in webkit [48943] by
-
- 3 edits in trunk/WebKit/qt
Add the failed URL to the ErrorPageExtension, as it is quite
useful for creating error pages.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-30
Reviewed by David Hyatt.
- Api/qwebpage.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
- 12:33 PM Changeset in webkit [48942] by
-
- 2 edits in trunk/WebCore
Build fix for QT. Didn't know WebCore.pro existed.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-30
- WebCore.pro:
- 12:25 PM Changeset in webkit [48941] by
-
- 11 edits in trunk
WebCore: Add a method for removal of user scripts and stylesheets by URL from a specific world.
Reviewed by Adam Roben.
- page/PageGroup.cpp:
(WebCore::PageGroup::removeUserContentURLForWorld):
- page/PageGroup.h:
WebKit/mac: Add the ability to remove user stylesheets and scripts by URL.
Reviewed by Adam Roben.
- WebView/WebView.mm:
(+[WebView _removeUserContentFromGroup:url:worldID:]):
- WebView/WebViewPrivate.h:
WebKit/win: Add the ability to remove user stylesheets and scripts by URL.
Reviewed by Adam Roben.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::removeUserContentWithURLFromGroup):
- WebView.h:
- 12:01 PM Changeset in webkit [48940] by
-
- 2 edits in trunk/WebCore
2009-09-30 Chris Hawk <hawk@chromium.org>
Reviewed by Dimitri Glazkov.
Fix for conditionals in the WebCore gyp file, which contained two separate
'conditions' values for the webcore target. The first entry was ignored,
resulting in some missine defines.
https://bugs.webkit.org/show_bug.cgi?id=29907
- WebCore.gyp/WebCore.gyp:
- 11:52 AM Changeset in webkit [48939] by
-
- 10 edits in trunk/WebCore
2009-09-21 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
DOM Storage needs to be more careful about where "ThreadSafe" objects are destroyed.
https://bugs.webkit.org/show_bug.cgi?id=29265
DOM Storage needs to be more careful about where "ThreadSafe" objects are
destroyed. With the current code, there actually isn't a race condition, but
it sure would be easy for someone to introduce one. A bunch of
ThreadSafeShared objects have RefPtrs to objects that are NOT ThreadSafeShared
objects. If it were possible any of these objects' destructors to be fired off
the main thread, then the you'd have a race condition. The code should be more
clear and self-documenting about how things related to each other.
Since the lifetime of a LocalStorageTask is bounded by the LocalStorageThread
which is bounded by the StorageSyncManager, StorageAreaImpl, and
StorageAreaSync, there's no reason for LocalStorageTask to store anything other
than pointers. By breaking this dependency, we can eliminate the risk.
Note that we _could_ have LocalStorageThread's task queue just store
LocalStorageTask*'s rather than RefPtr<LocalStorageTask>s but then we'd need to
manually take care of deleting. It'd probably also be possible to change
LocalStorageThread around so that it needn't hold onto a reference of itself
and have a more deterministic shutdown, but my initial attempts to do so
failed, and I decided it wasn't worth changing. The queue is killed before
hand, so the thread is 100% impotent before the main thread continues anyway.
The constructors and destructors of StorageSyncManager, StorageAreaImpl, and
StorageAreaSync now have ASSERTs to verify they're running on the main thread.
I'm fairly positive that it'd be impossible to hit these asserts and the fact
that these classes are no longer ThreadSafeShared should make it clear how
they're meant to be used, but I think it's worth it to be extra sure. Of
course, ideally, we'd have such an assert every time a ref is incremented or
decremented.
Behavior should be unchanged and this is just an internal code cleanup, so no
new tests.
- storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask): (WebCore::LocalStorageTask::performTask):
- storage/LocalStorageTask.h: (WebCore::LocalStorageTask::createImport): (WebCore::LocalStorageTask::createSync): (WebCore::LocalStorageTask::createTerminate):
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync):
- storage/LocalStorageThread.h:
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl):
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::~StorageAreaSync):
- storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
- storage/StorageSyncManager.h:
- 11:26 AM Changeset in webkit [48938] by
-
- 2 edits in trunk/JavaScriptCore
Buildfix for platforms using JSVALUE32.
https://bugs.webkit.org/show_bug.cgi?id=29915
Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-30
Reviewed by Geoffrey Garen.
After http://trac.webkit.org/changeset/48905 the build broke in JSVALUE32 case.
Also removed unreachable code.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
- Declaration of "OperandTypes types" moved before first use.
- Typos fixed: dst modified to result, regT2 added.
- Unreachable code removed.
(JSC::JIT::emitSlow_op_add):
- Missing declaration of "OperandTypes types" added.
- 11:17 AM Changeset in webkit [48937] by
-
- 9 edits1 copy in trunk/WebCore
2009-09-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Chromium needs to be able to override the way storage events are delivered
https://bugs.webkit.org/show_bug.cgi?id=29655
Chromium needs to be able to override the way storage events are delivered.
This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
faster (no vtables and extra allocation) and somewhat cleaner (no dependency
injection). This is necessary because Chromium needs to transport events across
a process barrier and then dispatch them without use of a Frame*.
Behavior should not change with this, so no updates to tests.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear):
- storage/StorageAreaImpl.h:
- storage/StorageEventDispatcher.cpp: Copied from WebCore/storage/StorageAreaImpl.cpp. (WebCore::StorageEventDispatcher::dispatch):
- storage/StorageEventDispatcher.h: Added. (Well, technically in the other half of this patch.)
- 11:15 AM Changeset in webkit [48936] by
-
- 4 edits in trunk
Versioning.
- 11:11 AM Changeset in webkit [48935] by
-
- 1 copy in tags/Safari-532.1
New tag.
- 10:52 AM Changeset in webkit [48934] by
-
- 3 edits2 adds in trunk
Need to check NULL frame in EventHandler::updateDragAndDrop.
https://bugs.webkit.org/show_bug.cgi?id=29929
Reviewed by Darin Adler.
WebCore:
Test: http/tests/misc/drag-over-iframe-invalid-source-crash.html
- page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop):
LayoutTests:
Add a new test for the bug.
- http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt: Added.
- http/tests/misc/drag-over-iframe-invalid-source-crash.html: Added.
- 10:33 AM Changeset in webkit [48933] by
-
- 38 edits in trunk/LayoutTests/platform/mac
Set the svn:mime-type property of recently-added PNG files to image/png.
- 10:21 AM Changeset in webkit [48932] by
-
- 6 edits4 adds in trunk
2009-09-29 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
ASSERTION FAILED: !repaintContainer repaintContainer == this Generalize the fix for this bug to account for cases where there may be multiple
containing blocks between the repaint container, and the container of the element
being repainted.
Test: compositing/repaint/opacity-between-absolute2.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): Call offsetFromAncestorContainer() to get the correct offset.
(WebCore::RenderBox::computeRectForRepaint): Ditto
- rendering/RenderInline.cpp: (WebCore::RenderInline::computeRectForRepaint): Ditto.
- rendering/RenderObject.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::offsetFromAncestorContainer): New method that computes an offset from some object in the ancestor container() chain.
- 10:15 AM Changeset in webkit [48931] by
-
- 4 edits in trunk/WebKitTools
2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by David Kilzer.
Make sunspider scripts work on Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=29656
- Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
- Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
- Scripts/webkitdirs.pm: currentPerlPath() added.
- 10:13 AM Changeset in webkit [48930] by
-
- 2 edits in trunk/WebKit
2009-09-30 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
- Keeping up with downstream revisions.
- Turning off v8 snapshot build step.
- chromium/DEPS
- 8:35 AM Changeset in webkit [48929] by
-
- 2 edits in trunk/WebCore
2009-09-30 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Fix TextCodecQt::decode method after r48752 to return a non-null string if the length of the input is 0.
This fixes https://bugs.webkit.org/show_bug.cgi?id=29736.
- platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::decode):
- 7:20 AM Changeset in webkit [48928] by
-
- 2 edits in trunk/JavaScriptCore
Reduce heap size on Symbian from 64MB to 8MB.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-30
Reviewed by Simon Hausmann.
This is not a perfect fix, it requires more fine tuning.
But this makes it possible again to debug in the emulator,
which is more important in order to be able to fix other
run-time issues.
- runtime/Collector.h:
- 5:41 AM QtWebKitMirrorGuide edited by
- (diff)
- 5:33 AM QtWebKitMirrorGuide edited by
- (diff)
- 5:31 AM QtWebKitTodo edited by
- (diff)
- 5:16 AM Changeset in webkit [48927] by
-
- 10 edits in trunk/LayoutTests
[Qt] Update Skipped after #48873 and some expected files, whose
problems are the same (default font size reconciliation
16px/13px), but the previous update didn't contain them.
Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-09-30
Reviewed by Simon Hausmann.
- platform/qt/Skipped:
- platform/qt/css2.1/t040103-ident-04-c-expected.txt:
- platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
- platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
- platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
- platform/qt/css2.1/t1202-counter-05-b-expected.txt:
- platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
- 5:02 AM Changeset in webkit [48926] by
-
- 3 edits1 move in trunk/LayoutTests
2009-09-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
Move message-port-multi.js from resources to script-tests
https://bugs.webkit.org/show_bug.cgi?id=29798
Revert r48823. message-port-multi.js needs custom HTML.
- fast/events/message-port-multi-expected.txt:
- fast/events/message-port-multi.html:
- fast/events/resources/message-port-multi.js: Added. (channel.port2.onmessage):
- fast/events/script-tests/message-port-multi.js: Removed.
- 4:47 AM QtWebKitMirrorGuide edited by
- (diff)
- 3:49 AM Changeset in webkit [48925] by
-
- 18 edits in trunk/LayoutTests
2009-09-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Kilzer.
Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=12140
Fixes for JS files.
- fast/js/date-preserve-milliseconds-expected.txt:
- fast/js/script-tests/array-float-delete.js:
- fast/js/script-tests/array-tostring-ignore-separator.js:
- fast/js/script-tests/date-big-setmonth.js:
- fast/js/script-tests/date-negative-setmonth.js:
- fast/js/script-tests/date-preserve-milliseconds.js:
- fast/js/script-tests/number-tofixed.js:
- fast/js/script-tests/object-extra-comma.js:
- fast/js/script-tests/object-prototype-constructor.js:
- fast/js/script-tests/object-prototype-toLocaleString.js:
- fast/js/script-tests/regexp-lastindex.js:
- fast/js/script-tests/regexp-stack-overflow.js:
- fast/js/script-tests/string-split-ignore-case.js:
- fast/js/script-tests/toString-exception.js:
- fast/js/script-tests/toString-overrides.js:
- fast/js/script-tests/toString-stack-overflow.js:
- fast/js/toString-stack-overflow-expected.txt:
- 1:55 AM Changeset in webkit [48924] by
-
- 39 edits1 add in trunk/LayoutTests
2009-09-30 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Geolocation LayoutTests should use an HTML template.
https://bugs.webkit.org/show_bug.cgi?id=29179
Updates Geolocation LayoutTests to correctly use an HTML template so that
individual HTML files can be generated using make-script-test-wrappers.
This requires a new js-test-post.js which allows for asynchronous tests.
- fast/dom/Geolocation/resources/TEMPLATE.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/resources/js-test-post.js: Added. Allows for asynchronous tests.
- fast/dom/Geolocation/resources/argument-types.js: Modified. Sepcifies synchronous test.
- fast/dom/Geolocation/argument-types.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/resources/callback-exception.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/callback-exception.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/callback-exception-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/enabled.js: Modified. Sepcifies synchronous test.
- fast/dom/Geolocation/enabled.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/resources/error.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/error.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/error-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/permission-denied.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/permission-denied.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/permission-denied-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/permission-denied-stops-watches.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/position-string.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/position-string.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/position-string-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/reentrant-error.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/reentrant-error.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/reentrant-error-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/reentrant-success.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/reentrant-success.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/reentrant-success-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/success.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/success.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/success-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/timeout.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/timeout.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/timeout-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/timeout-zero.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/timeout-zero.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/timeout-zero-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/watch.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/watch.html: Updated to use new js-test-post.js.
- fast/dom/Geolocation/watch-expected.txt: Modified. Adds successfullyParsed.
- 1:38 AM QtWebKitMirrorGuide created by
- 1:13 AM Changeset in webkit [48923] by
-
- 2 edits in trunk/SunSpider
2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Darin Adler.
Platform specific null device replaced with a platform independent.
https://bugs.webkit.org/show_bug.cgi?id=29544
- sunspider: Using File::Spec->devnull() instead of /dev/null and NUL.
- 1:06 AM QtWebKitPerformanceWork edited by
- (diff)
- 12:48 AM Changeset in webkit [48922] by
-
- 2 edits in trunk/JavaScriptCore
Fix CRASH() macro for Symbian build.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-30
Reviewed by Simon Hausmann.
- wtf/Assertions.h: Added missing }
- 12:03 AM QtWebKitPerformanceUtilities edited by
- (diff)
Sep 29, 2009:
- 11:55 PM Changeset in webkit [48921] by
-
- 122 edits in trunk/LayoutTests
2009-09-29 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=12140
Remove opendarwin URLs from href="".
This change doesn't change pixel test results.
- editing/pasteboard/display-block-on-spans.html:
- editing/pasteboard/drop-text-without-selection.html:
- editing/pasteboard/paste-text-019.html:
- editing/selection/6476.html:
- editing/selection/7152-1.html:
- editing/selection/7152-2.html:
- editing/selection/after-line-wrap.html:
- editing/selection/click-start-of-line.html:
- editing/selection/leave-requested-block.html:
- editing/selection/select-from-textfield-outwards.html:
- fast/block/basic/text-indent-rtl.html:
- fast/block/float/nopaint-after-layer-destruction.html:
- fast/block/float/nopaint-after-layer-destruction2.html:
- fast/block/float/table-relayout.html:
- fast/block/float/vertical-move-relayout.html:
- fast/block/positioning/height-change.html:
- fast/block/positioning/relayout-on-position-change.html:
- fast/block/positioning/window-height-change.html:
- fast/css-generated-content/hover-style-change.html: Added property allow-tabs.
- fast/css/error-in-last-decl.html:
- fast/css/ex-after-font-variant.html:
- fast/css/find-next-layer.html:
- fast/css/first-letter-detach.html:
- fast/css/font-shorthand-weight-only.html:
- fast/css/hover-subselector.html:
- fast/css/invalidation-errors-2.html:
- fast/css/invalidation-errors-3.html:
- fast/css/invalidation-errors.html:
- fast/css/resize-corner-tracking.html:
- fast/css/rtl-ordering.html:
- fast/css/universal-hover-quirk.html:
- fast/dom/Element/class-attribute-whitespace.html: Added property allow-tabs.
- fast/dom/HTMLHeadElement/head-link-style-href-check.html:
- fast/dom/HTMLLinkElement/pending-stylesheet-count.html:
- fast/dynamic/layer-hit-test-crash.html:
- fast/dynamic/selection-highlight-adjust.html:
- fast/encoding/resources/%25%u0435 0 %xx%%%ulike.html:
- fast/events/event-sender-mouse-moved.html:
- fast/events/resources/drag-outside-window-frame.html:
- fast/forms/button-cannot-be-nested.html:
- fast/forms/button-generated-content.html:
- fast/forms/button-inner-block-reuse.html:
- fast/forms/button-white-space.html:
- fast/forms/floating-textfield-relayout.html:
- fast/forms/form-hides-table.html:
- fast/forms/visual-hebrew-text-field.html:
- fast/history/clicked-link-is-visited.html:
- fast/history/resources/clicked-link-is-visited-2.html:
- fast/inline-block/overflow-clip.html:
- fast/invalid/missing-address-end-tag.html:
- fast/invalid/missing-dl-end-tag.html:
- fast/invalid/missing-dt-end-tag.html:
- fast/invalid/missing-font-end-tag.html:
- fast/js/exception-linenums-in-html-3.html:
- fast/js/missing-style-end-tag-js.html:
- fast/layers/opacity-outline.html:
- fast/lists/list-style-none-crash.html:
- fast/lists/markers-in-selection.html:
- fast/lists/scrolled-marker-paint.html:
- fast/overflow/image-selection-highlight.html:
- fast/overflow/overflow-rtl-inline-scrollbar.html:
- fast/parser/broken-comments-vs-parsing-mode.html:
- fast/parser/nofoo-tags-inside-paragraph.html:
- fast/parser/remove-block-in-residual-style.html:
- fast/repaint/backgroundSizeRepaint.html:
- fast/repaint/border-repaint-glitch.html:
- fast/repaint/bugzilla-3509.html:
- fast/repaint/bugzilla-5699.html:
- fast/repaint/bugzilla-6278.html:
- fast/repaint/bugzilla-6388.html:
- fast/repaint/bugzilla-6473.html:
- fast/repaint/bugzilla-7235.html:
- fast/repaint/clipped-relative.html:
- fast/repaint/containing-block-position-change.html:
- fast/repaint/flexible-box-overflow-horizontal.html:
- fast/repaint/flexible-box-overflow.html:
- fast/repaint/float-move-during-layout.html:
- fast/repaint/inline-outline-repaint.html:
- fast/repaint/layer-outline-horizontal.html:
- fast/repaint/layer-outline.html:
- fast/repaint/line-overflow.html:
- fast/repaint/outline-repaint-glitch.html:
- fast/repaint/outline-shrinking.html:
- fast/repaint/repaint-resized-overflow.html:
- fast/repaint/static-to-positioned.html:
- fast/repaint/table-cell-move.html:
- fast/repaint/table-extra-bottom-grow.html:
- fast/repaint/text-shadow-horizontal.html:
- fast/repaint/text-shadow.html:
- fast/replaced/applet-rendering-java-disabled.html:
- fast/replaced/image-solid-color-with-alpha.html:
- fast/replaced/inline-box-wrapper-handover.html:
- fast/replaced/pdf-as-image.html:
- fast/table/absolute-table-at-bottom.html:
- fast/table/add-before-anonymous-child.html:
- fast/table/border-collapsing/003.html:
- fast/table/border-collapsing/border-collapsing-head-foot.html:
- fast/table/border-collapsing/rtl-border-collapsing.html:
- fast/table/cell-absolute-child.html:
- fast/table/click-near-anonymous-table.html:
- fast/table/edge-offsets.html:
- fast/table/empty-section-crash.html:
- fast/table/fixed-table-non-cell-in-row.html:
- fast/table/form-with-table-style.html:
- fast/table/row-height-recalc.html:
- fast/table/rtl-cell-display-none-assert.html:
- fast/table/text-field-baseline.html:
- fast/text/atsui-small-caps-punctuation-size.html:
- fast/text/atsui-spacing-features.html:
- fast/text/basic/015.html:
- fast/text/capitalize-empty-generated-string.html:
- fast/text/in-rendered-text-rtl.html:
- fast/text/international/rtl-caret.html:
- fast/text/midword-break-hang.html:
- fast/text/whitespace/pre-wrap-overflow-selection.html:
- fast/text/whitespace/pre-wrap-spaces-after-newline.html:
- fast/tokenizer/missing-style-end-tag-1.html:
- fast/tokenizer/missing-style-end-tag-2.html:
- fast/tokenizer/missing-title-end-tag-1.html:
- fast/tokenizer/missing-title-end-tag-2.html:
- http/tests/misc/iframe404.html:
- 11:38 PM QtWebKitPerformanceUtilities edited by
- (diff)
- 11:36 PM QtWebKitPerformanceWork edited by
- (diff)
- 11:17 PM QtWebKitPerformanceUtilities edited by
- (diff)
- 11:15 PM QtWebKitPerformanceUtilities edited by
- (diff)
- 10:18 PM QtWebKitPerformanceUtilities edited by
- more command line invocation (diff)
- 10:14 PM QtWebKitPerformanceUtilities edited by
- (diff)
- 10:04 PM QtWebKitPerformanceToolBackLog: created by
- 10:02 PM QtWebKitPerformanceWork edited by
- (diff)
- 9:55 PM QtBackLog created by
- 9:48 PM QtWebKitPerformanceUtilities edited by
- (diff)
- 9:46 PM Changeset in webkit [48920] by
-
- 3 edits in trunk/JavaScriptCore
Inlined a few math operations.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
Reviewed by Gavin Barraclough.
~1% SunSpider speedup.
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub): Don't take a stub call when operating on
a constant int and a double.
- 8:40 PM QtWebKitPerformanceUtilities created by
- Create overview of the utilities... stub
- 8:27 PM QtWebKitPerformanceWork created by
- Start QtWebKit performance analysis page.
- 7:46 PM Changeset in webkit [48919] by
-
- 3 edits in trunk/WebCore
Fix a couple of bugs with patterns. Move the setting of the document URL to before the style
selector gets constructed so that pattern match testing gets the correct URL.
Reviewed by Jon Honeycutt.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):
- 7:02 PM Changeset in webkit [48918] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Brady Eidson.
Assertion failure in http/tests/xmlhttprequest/failed-auth.html.
I couldn't find out why this only started to happen now, but it was incorrect to check
persistence of a credential returned by CredentialStorage::get() without checking that it
was non-null. When there is no credential for the protection space in storage, get()
returns a new object, and Credentil constructor doesn't initialize m_persistence.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Moved the assertion after credential null check. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Added the same persistence assertion, matching sync code (and CF one, as well).
- 7:00 PM Changeset in webkit [48917] by
-
- 7 edits in trunk
Rubberstamped by Dan Bernstein.
Fix license and some sorting in new files.
WebKit/mac:
- WebView/WebHistoryDelegate.h:
- WebView/WebNavigationData.h:
- WebView/WebNavigationData.mm:
WebKitTools:
- DumpRenderTree/mac/HistoryDelegate.h:
- DumpRenderTree/mac/HistoryDelegate.mm:
- 6:46 PM Changeset in webkit [48916] by
-
- 3 edits in trunk/WebKitTools
2009-09-29 Yaar Schnitman <yaar@chromium.org>
Reviewed by David Kilzer.
Fixed how error codes are handled.
https://bugs.webkit.org/show_bug.cgi?id=29898
- Scripts/update-webkit:
- Scripts/update-webkit-chromium:
- 6:36 PM Changeset in webkit [48915] by
-
- 3 edits in trunk/WebKitTools
Updated way-out-of-date sorting throughout the dump methods/flags.
Reviewed by John Sullivan.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(dumpAsPDFCallback):
(dumpAsTextCallback):
(dumpFrameLoadCallbacksCallback):
(dumpResourceLoadCallbacksCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpAsText):
(LayoutTestController::setDumpAsText):
(LayoutTestController::dumpFrameLoadCallbacks):
(LayoutTestController::setDumpFrameLoadCallbacks):
(LayoutTestController::dumpSelectionRect):
(LayoutTestController::setDumpSelectionRect):
(LayoutTestController::dumpSourceAsWebArchive):
(LayoutTestController::setDumpSourceAsWebArchive):
(LayoutTestController::dumpStatusCallbacks):
(LayoutTestController::setDumpStatusCallbacks):
(LayoutTestController::dumpTitleChanges):
(LayoutTestController::setDumpTitleChanges):
(LayoutTestController::dumpWillCacheResponse):
(LayoutTestController::setDumpWillCacheResponse):
- 6:35 PM Changeset in webkit [48914] by
-
- 17 edits11 adds in trunk
WebKit Mac API should provide a delegate interface for global history.
<rdar://problem/7042773> and https://webkit.org/b/29904
Reviewed by John Sullivan.
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
- WebView/WebHistoryDelegate.h: Added. New interface for WebKit clients to implement to manage their own global history store.
Object to store all of the bits of data relevant to a page visit:
- WebView/WebNavigationData.h: Added.
- WebView/WebNavigationData.mm: Added.
(-[WebNavigationDataPrivate dealloc]):
(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
(-[WebNavigationData url]):
(-[WebNavigationData title]):
(-[WebNavigationData originalRequest]):
(-[WebNavigationData response]):
(-[WebNavigationData hasSubstituteData]):
(-[WebNavigationData clientRedirectSource]):
(-[WebNavigationData dealloc]):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::updateGlobalHistory): If the delegate exists, don't use the built-in WebHistory.
If the implementation for this method exists, call it.
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Ditto
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebDelegateImplementationCaching.mm:
(WebViewGetHistoryDelegateImplementations):
(CallHistoryDelegate):
- WebView/WebView.mm:
(-[WebView _cacheHistoryDelegateImplementations]):
(-[WebView setHistoryDelegate:]):
(-[WebView historyDelegate]):
- WebView/WebViewData.h:
- WebView/WebViewPrivate.h:
WebKitTools:
Adding the dumping of global history delegate callbacks.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(allocateGlobalControllers):
(shouldLogFrameLoadDelegates):
(shouldLogHistoryDelegates):
(runTest):
Dump history delegate callbacks:
- DumpRenderTree/mac/HistoryDelegate.h: Added.
- DumpRenderTree/mac/HistoryDelegate.mm: Added.
(-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
(-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
(-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
LayoutTests:
- http/tests/globalhistory: Added.
- http/tests/globalhistory/history-delegate-basic-302-redirect-expected.txt: Added.
- http/tests/globalhistory/history-delegate-basic-302-redirect.html: Added.
- http/tests/globalhistory/history-delegate-basic-refresh-redirect-expected.txt: Added.
- http/tests/globalhistory/history-delegate-basic-refresh-redirect.html: Added.
- http/tests/resources/notify-done.html: Added.
- http/tests/resources/redirect.php: Augment to optionally do "Refresh:"-style redirects.
Skip these new tests on all platforms that don't have history delegates (yet):
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 6:07 PM Changeset in webkit [48913] by
-
- 2 edits in trunk/WebCore
2009-09-29 Yong Li <yong.li@torchmobile.com>
Reviewed by Darin Adler.
Add an ASSERT for UTF8Encoding().isValid()
https://bugs.webkit.org/show_bug.cgi?id=29908
- platform/text/TextEncoding.cpp: (WebCore::UTF8Encoding):
- 5:32 PM Changeset in webkit [48912] by
-
- 8 edits2 adds in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=29892
Add support for whitelist patterns to control conditional injection of user scripts and
user stylesheets.
Reviewed by Jon Honeycutt.
No new tests. Not testable until WebKit portion is added in followup patch.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::pageGroupUserSheets):
- page/Frame.cpp:
(WebCore::Frame::injectUserScriptsForWorld):
- page/UserContentURLPattern.cpp: Added.
(WebCore::UserContentURLPattern::matchesPatterns):
(WebCore::UserContentURLPattern::parse):
(WebCore::UserContentURLPattern::matches):
(WebCore::UserContentURLPattern::matchesHost):
(WebCore::MatchTester::MatchTester):
(WebCore::MatchTester::testStringFinished):
(WebCore::MatchTester::patternStringFinished):
(WebCore::MatchTester::eatWildcard):
(WebCore::MatchTester::eatSameChars):
(WebCore::MatchTester::test):
(WebCore::UserContentURLPattern::matchesPath):
- page/UserContentURLPattern.h: Added.
(WebCore::UserContentURLPattern::UserContentURLPattern):
(WebCore::UserContentURLPattern::scheme):
(WebCore::UserContentURLPattern::host):
(WebCore::UserContentURLPattern::path):
(WebCore::UserContentURLPattern::matchSubdomains):
- 4:20 PM Changeset in webkit [48911] by
-
- 1 edit15 adds in trunk/LayoutTests
2009-09-29 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
More tests for the XSSAuditor.
- http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt: Added.
- http/tests/security/xssAuditor/embed-tag-javascript-url.html: Added.
- http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt: Added.
- http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html: Added.
- http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt: Added.
- http/tests/security/xssAuditor/object-tag-javascript-url.html: Added.
- http/tests/security/xssAuditor/property-escape-noquotes-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html: Added.
- http/tests/security/xssAuditor/property-escape-noquotes.html: Added.
- http/tests/security/xssAuditor/property-inject-expected.txt: Added.
- http/tests/security/xssAuditor/property-inject.html: Added.
- http/tests/security/xssAuditor/resources/echo-head.pl: Added.
- http/tests/security/xssAuditor/resources/echo-inner-tag.pl: Added.
- http/tests/security/xssAuditor/resources/echo-property-noquotes.pl: Added.
- 4:10 PM Changeset in webkit [48910] by
-
- 4 edits2 adds in trunk
2009-09-29 Enrica Casucci <enrica@apple.com>
Reviewed by Adele Peterson.
Test case for <rdar://problem/7085453>.
- editing/selection/blockquote-crash-expected.txt: Added.
- editing/selection/blockquote-crash.html: Added.
2009-09-29 Enrica Casucci <enrica@apple.com>
Reviewed by Adele Peterson.
Reproducible crash pressing return inside quoted content
at WebCore::BreakBlockquoteCommand::doApply.
<rdar://problem/7085453>
In some case, like the one provided in the test case, m_downStreamEnd
refers to a node that gets deleted when executing the DeleteSelectionCommand.
We shouldn't use m_downStreamEnd to recalculate the new m_endPosition when
pruning is needed, because it may be point to a node that has been deleted, but
rather rely on removeNode in CompositeEditCommand to update m_endPosition correctly.
Test: editing/selection/blockquote-crash.html
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Added check for invalid position to avoid dereferencing a null node pointer.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Don't reset m_endPosition using the value in m_downStreamEnd when it is necessary to prune the start block.
- 3:58 PM Changeset in webkit [48909] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady Eidson.
Basic authentication credentials are not sent automatically to top resources
https://bugs.webkit.org/show_bug.cgi?id=29901
No new tests - I don't want to pollute root directory of http tests to check for this rather
minor issue.
- platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Changed to always preserve leading slash. (WebCore::CredentialStorage::getDefaultAuthenticationCredential): Made breaking out of the loop more explicit.
- 3:27 PM Changeset in webkit [48908] by
-
- 2 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore
Windows build fix.
- 3:10 PM Changeset in webkit [48907] by
-
- 2 edits in trunk/WebCore
2009-09-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Oliver Hunt.
Web Inspector REGRESSION(r47820-r47822): Profiles aren't
added to the inspector unless the inspector is already open
when the profile completes.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._populateProfiles):
- 3:06 PM Changeset in webkit [48906] by
-
- 2 edits in trunk/WebCore
Rubberstamped by David Hyatt.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Fix to logic of earlier commit 48902.
When merging two if's before committing, I forgot to invert the
bool check.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::ignoreHttpError):
- 2:48 PM Changeset in webkit [48905] by
-
- 14 edits in trunk/JavaScriptCore
Tidy up codeblock sampler
https://bugs.webkit.org/show_bug.cgi?id=29836
Reviewed by Gavin Barraclough.
Some rather simple refactoring of codeblock sampler so that
it's easier for us to use it to find problems in non-jsc
environments
- 2:43 PM Changeset in webkit [48904] by
-
- 5 edits in trunk/WebCore
Unreviewed, build fix.
Fixing Chromium build, following r48884.
https://bugs.webkit.org/show_bug.cgi?id=29894
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
- bindings/v8/V8AbstractEventListener.h:
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
- bindings/v8/V8WorkerContextEventListener.h:
- 2:25 PM Changeset in webkit [48903] by
-
- 12 edits in trunk
2009-09-29 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Update for .maxLength behavior change.
https://bugs.webkit.org/show_bug.cgi?id=29796
- fast/forms/input-maxlength-expected.txt:
- fast/forms/input-maxlength.html:
- fast/forms/script-tests/textarea-maxlength.js:
- fast/forms/textarea-maxlength-expected.txt:
2009-09-29 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Follows HTML5's maxLength change in September 2009.
- Change HTMLTextAreaElement.maxLength type to signed.
- HTMLTextAreaElement.maxLength returns -1 if maxlength= attribute is missing.
- HTMLTextAreaElement.maxLength and HTMLInputElement.maxLength throw INDEX_SIZE_ERR for setting negative values. https://bugs.webkit.org/show_bug.cgi?id=29796
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setMaxLength):
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl:
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent): (WebCore::HTMLTextAreaElement::maxLength): (WebCore::HTMLTextAreaElement::setMaxLength):
- html/HTMLTextAreaElement.h:
- html/HTMLTextAreaElement.idl:
- 2:07 PM Changeset in webkit [48902] by
-
- 2 edits in trunk/WebCore
Don't rely on QNetworkReply::NetworkError codes, but
on HTTP error codes instead.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::ignoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
- 2:07 PM Changeset in webkit [48901] by
-
- 2 edits in trunk/WebCore
Use const references when using Qt's foreach.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 2:07 PM Changeset in webkit [48900] by
-
- 2 edits in trunk/WebCore
Fix handling of QNetworkReply errors.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.
In the QNetworkReplyHandler::finish() a response was sent even when
the reply contained an error. This resulted in a sendResponseIfNeeded()
calling didReceiveResponse on the client, leading to the destruction
of the m_resourceHandle, discontinuing further processing in finish(),
and thus not calling didFail on the client.
Instead it continued as everything went fine, and
FrameLoaderClientQt::dispatchDecidePolicyForMIMEType() changed the
policy to PolicyDownload due to not being able to show the non existing
MIMEType. As the download also obviously fails, it ended up with a
policy change error.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
- 2:01 PM Changeset in webkit [48899] by
-
- 4 edits in trunk/WebKitTools
2009-09-29 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Roben.
Fixes an issue where the drop effect returned by Window Dump Render Tree
was always DROPEFFECT_NONE (since it was hard coded to do so).
This patch corrects this issue by determining the actual drop effect
performed by the corresponding drag-and-drop operation so that we can
return it.
- DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect. (DraggingInfo::DraggingInfo): (DraggingInfo::performedDropEffect): Added method. (DraggingInfo::setPerformedDropEffect): Added method.
- DumpRenderTree/win/EventSender.cpp: (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect. Moved delete draggingInfo to UIDelegate::doDragDrop.
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
- 1:48 PM Changeset in webkit [48898] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29895
The following files are generated by JavaScriptCore's GYP file and should be ignored:
pcre.mk
wtf.scons
wtf.mk
SConstruct
wtf_config.scons
wtf_config.mk
pcre.scons
- JavaScriptCore.gyp: Changed property svn:ignore.
- 1:42 PM Changeset in webkit [48897] by
-
- 2 edits in trunk/WebCore
2009-09-29 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r48894, because review discussion was not complete.
http://trac.webkit.org/changeset/48894
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::begin):
- 1:29 PM Changeset in webkit [48896] by
-
- 3 edits4 adds in trunk
2009-09-29 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Filter feComposite implementation is missing
https://bugs.webkit.org/show_bug.cgi?id=28362
feComposite implementation for SVG.
Test: svg/filters/feComposite.svg
- platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic): (WebCore::FEComposite::apply):
Tests the feComposite implementation for SVG.
- platform/mac/svg/filters/feComposite-expected.checksum: Added.
- platform/mac/svg/filters/feComposite-expected.png: Added.
- platform/mac/svg/filters/feComposite-expected.txt: Added.
- svg/filters/feComposite.svg: Added.
- 1:28 PM Changeset in webkit [48895] by
-
- 2 edits in trunk/JavaScriptCore
Standardized an optimization for adding non-numbers.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
Reviewed by Sam Weinig.
SunSpider says maybe a tiny speedup.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
- 1:05 PM Changeset in webkit [48894] by
-
- 2 edits in trunk/WebCore
2009-09-29 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Starting all read-only transactions with an explicit BEGIN
DEFERRED command instead of BEGIN, since some ports (chromium)
might compile their own SQLite library and set BEGIN to BEGIN
IMMEDIATE by default; which would result in a deadlock in case of
two concurrent read-only transactions on the same DB, and would
unnecessarily delay other potential transactions to the same DB.
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::begin):
- 12:49 PM Changeset in webkit [48893] by
-
- 9 edits in trunk
WebCore:
2009-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): Check page settings for experimental WebGL flag before returning 3D graphics context.
- page/Settings.cpp: (WebCore::Settings::Settings): Initialize new flag to false. (WebCore::Settings::setExperimentalWebGLEnabled):
- page/Settings.h: Set new flag. (WebCore::Settings::experimentalWebGLEnabled): Return new flag.
WebKit/mac:
2009-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Enable experimental WebGL flag when 3D_CANVAS is enabled in the build.
WebKit/win:
2009-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826
- WebView.cpp: (WebView::notifyPreferencesChanged): Enable experimental WebGL flag when 3D_CANVAS is enabled in the build.
- 12:39 PM Changeset in webkit [48892] by
-
- 2 edits1 add in trunk/WebCore
2009-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Chromium needs to be able to override the way storage events are delivered - part 1
https://bugs.webkit.org/show_bug.cgi?id=29889
Chromium needs to be able to override the way storage events are delivered.
This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
faster (no vtables and extra allocation) and somewhat cleaner (no dependency
injection). This is necessary because Chromium needs to transport events across
a process barrier and then dispatch them without use of a Frame*.
This patch should be a no-op for all ports other than Chromium.
- WebCore.gypi:
- storage/StorageEventDispatcher.h: Added.
- 12:15 PM Changeset in webkit [48891] by
-
- 109 edits in trunk/LayoutTests
2009-09-29 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Kilzer.
Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=12140
Change the URLs in dumpAsText tests.
- editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- editing/deleting/delete-all-text-in-text-field-assertion.html:
- fast/dom/Document/doc-open-while-parsing.html:
- fast/dom/Document/document-reopen.html:
- fast/dom/Element/setAttribute-case-insensitivity.html:
- fast/dom/HTMLHeadElement/head-check.html:
- fast/dom/HTMLImageElement/image-without-renderer-width-expected.txt:
- fast/dom/HTMLImageElement/image-without-renderer-width.html:
- fast/dom/HTMLScriptElement/script-load-events-expected.txt:
- fast/dom/HTMLScriptElement/script-load-events.html:
- fast/dom/clone-node-form-elements-with-attr.html:
- fast/dom/document-dir-property-expected.txt:
- fast/dom/document-dir-property.html:
- fast/dom/everything-to-string.html:
- fast/dom/generic-form-element-assert-expected.txt:
- fast/dom/generic-form-element-assert.html:
- fast/dom/inner-text-rtl-expected.txt:
- fast/dom/inner-text-rtl.html:
- fast/dom/navigator-vendorSub.html:
- fast/dom/option-properties-expected.txt:
- fast/dom/option-properties.html:
- fast/dom/replace-child-siblings-expected.txt:
- fast/dom/replace-child-siblings.html:
- fast/dom/replace-first-child.html:
- fast/dom/setAttribute-using-initial-input-value.html:
- fast/dom/space-to-text.html:
- fast/dynamic/hovered-detach-expected.txt:
- fast/dynamic/hovered-detach.html:
- fast/encoding/charset-koi8-u.html:
- fast/encoding/css-charset-dom.html:
- fast/encoding/css-charset-evil.html:
- fast/encoding/css-charset.html:
- fast/encoding/latin1-winlatin.html:
- fast/encoding/mispositioned-meta.html:
- fast/encoding/percent-escaping.html:
- fast/encoding/pseudo-xml-2.html:
- fast/encoding/pseudo-xml-3.html:
- fast/encoding/pseudo-xml-4.html:
- fast/encoding/pseudo-xml.html:
- fast/events/init-event-null-view.html:
- fast/events/mouseover-mouseout.html:
- fast/events/mouseover-mouseout2.html:
- fast/events/onload-webkit-before-webcore.html:
- fast/forms/button-in-forms-collection.html:
- fast/forms/document-write.html:
- fast/forms/domstring-replace-crash-expected.txt:
- fast/forms/domstring-replace-crash.html:
- fast/forms/element-by-name.html:
- fast/forms/empty-get.html:
- fast/forms/form-data-encoding-normalization-overrun.html:
- fast/forms/radio-button-no-change-event.html:
- fast/forms/selected-index-assert-expected.txt:
- fast/forms/selected-index-assert.html:
- fast/forms/textarea-hard-linewrap-empty-expected.txt:
- fast/forms/textarea-hard-linewrap-empty.html:
- fast/forms/textfield-focus-out-expected.txt:
- fast/forms/textfield-focus-out.html:
- fast/frames/empty-frame-document-expected.txt:
- fast/frames/empty-frame-document.html:
- fast/frames/frame-name-reset.html:
- fast/frames/frame-set-same-location.html:
- fast/frames/frame-set-same-src.html:
- fast/frames/frameElement-widthheight.html:
- fast/frames/iframe-name-and-id-expected.txt:
- fast/frames/iframe-name-and-id.html:
- fast/frames/iframe-set-same-location.html:
- fast/frames/iframe-set-same-src.html:
- fast/frames/repaint-display-none-crash-expected.txt:
- fast/frames/repaint-display-none-crash.html:
- fast/js/exception-linenums-in-html-2.html:
- fast/js/missing-title-end-tag-js.html:
- fast/loader/link-no-URL.html:
- fast/loader/url-strip-cr-lf-tab.html:
- fast/overflow/generated-content-crash-expected.txt:
- fast/overflow/generated-content-crash.html:
- fast/parser/number-sign-in-map-name.html:
- fast/parser/remove-current-node-parent.html:
- fast/parser/script-after-frameset-assert.html:
- fast/tokenizer/image-empty-crash-expected.txt:
- fast/tokenizer/image-empty-crash.html:
- fast/tokenizer/nested-cached-scripts-expected.txt:
- fast/tokenizer/nested-cached-scripts.html:
- fast/tokenizer/write-unclosed-script-expected.txt:
- fast/tokenizer/write-unclosed-script.html:
- fast/xsl/transformToFragment-XML-declaration.html:
- http/tests/misc/text-refresh.html:
- http/tests/plugins/npapi-response-headers.html:
- http/tests/uri/utf8-path.html:
- http/tests/xmlhttprequest/cache-override.html:
- http/tests/xmlhttprequest/event-listener-gc-expected.txt:
- http/tests/xmlhttprequest/event-listener-gc.html:
- http/tests/xmlhttprequest/event-target.html:
- http/tests/xmlhttprequest/frame-load-cancelled-abort.html:
- http/tests/xmlhttprequest/interactive-state.html:
- http/tests/xmlhttprequest/methods-async.html:
- http/tests/xmlhttprequest/methods-lower-case.html:
- http/tests/xmlhttprequest/methods.html:
- http/tests/xmlhttprequest/post-content-type.html:
- http/tests/xmlhttprequest/readystatechange.html:
- http/tests/xmlhttprequest/supported-xml-content-types.html:
- http/tests/xmlhttprequest/xhr-onunload.html:
- http/tests/xmlhttprequest/zero-length-response.html:
- platform/mac/fast/events/objc-event-api.html:
- platform/mac/fast/events/objc-keyboard-event-creation.html:
- plugins/get-empty-url.html:
- plugins/geturl-replace-query.html:
- plugins/invoke.html:
- plugins/mouse-events.html:
- 12:01 PM Changeset in webkit [48890] by
-
- 1 edit1 add in trunk/WebCore
Adding file missed in previous commit.
- 11:51 AM Changeset in webkit [48889] by
-
- 2 edits in trunk/WebCore
2009-09-29 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[V8] Correct an issue with XMLHttpRequest attribute event listeners never being cleared.
https://bugs.webkit.org/show_bug.cgi?id=29888
Test: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-abort-readyState-shouldDispatchEvent.html
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): Added isAttribute parameter. (WebCore::ACCESSOR_SETTER): Made all event listener setters create attribute listeners. (WebCore::CALLBACK_FUNC_DECL): Made addEventListener create object listener.
- 11:40 AM Changeset in webkit [48888] by
-
- 3 edits in trunk/WebCore
[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
https://bugs.webkit.org/show_bug.cgi?id=29654
Patch by Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Eric Seidel
Added an additional manual-test for this issue to the existing Gtk
cursor image test.
- 11:39 AM Changeset in webkit [48887] by
-
- 6 edits in trunk/WebCore
Reviewed by Timothy Hatcher.
Build fix - pass a proper ScriptExecutipnContext to getEventListenerHandlerBody()
- bindings/js/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
- bindings/js/ScriptEventListener.h:
- bindings/v8/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
- bindings/v8/ScriptEventListener.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForEventListener):
- 11:37 AM Changeset in webkit [48886] by
-
- 4 edits2 adds in trunk
2009-09-29 Nate Chapin <Nate Chapin>
Reviewed by Eric Seidel.
Ensure that we don't scroll lock to an anchor node after a
user-initiated scroll, even if that scroll doesn't propagate
all the way up to FrameView.
Test: fast/events/node-event-anchor-lock.html
- 11:12 AM Changeset in webkit [48885] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix: export a new symbol.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 11:05 AM Changeset in webkit [48884] by
-
- 35 edits10 adds in trunk
Reviewed by Darin Adler and Sam Weinig.
Onclick not fired for an element copied with cloneContents() or cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=25130
The change here is that JS event listeners don't keep a reference to a global object from
where they were created, and instead take it as a parameter when parsing source code. Also,
the listener creation won't fail just because it happens for an element in a frameless
document.
Thus, moving nodes between documents no longer results in having incorrect registered
lazy event listeners on them.
Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html
fast/events/attribute-listener-cloned-from-frameless-doc-context.html
fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
fast/events/attribute-listener-extracted-from-frameless-doc-context.html
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject. (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner. (WebCore::JSEventListener::markJSFunction): Don't mark the global object. (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext. (WebCore::JSEventListener::reportError): Ditto.
- bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference to JSDOMGlobalObject.
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener creation was split between this function and ScriptEventListener; moved it here, as JS global object can be different now.
- bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL, which can not be determined at parsing time.
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests expect that errors are logged at document parsing time, and because I don't know what other side effects moving it vould have.
- dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext, because JSC needs a global context here.
- bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener):
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSEventSourceCustom.cpp: (WebCore::JSEventSource::addEventListener): (WebCore::JSEventSource::removeEventListener):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/objc/ObjCEventListener.h:
- bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
- inspector/InspectorDOMStorageResource.h:
- loader/ImageDocument.cpp: (WebCore::ImageEventListener::handleEvent):
- svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::handleEvent):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException): Don't pass global object to JSEventListener::create(), which no longer needs it. Note that some of these functions still have an early return for null global object, which can probably be removed in a later patch. Pass ScriptExecutionContext to EventListener methods that now need it.
- bindings/scripts/CodeGeneratorCOM.pm: Don't force EventTarget implementation on Node - it doesn't work yet (it didn't quite work before this patch, too, because it assumed that any object implementing EventTarget COM interface originated from WebCore).
- dom/EventListener.idl: Just like in ObjC, EventListener should be a pure interface in COM bindings.
WebKit/win:
- DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.
- WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.
- 10:54 AM Changeset in webkit [48883] by
-
- 10 edits in trunk
Removed virtual destructor from JSGlobalObjectData to eliminate pointer
fix-ups when accessing JSGlobalObject::d.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
Reviewed by Sam Weinig.
Replaced with an explicit destructor function pointer.
6% speedup on bench-alloc-nonretained.js.
- JavaScriptCore.exp:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::destroyJSGlobalObjectData):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
(JSC::JSGlobalObject::JSGlobalObject):
JavaScriptGlue:
Replaced with an explicit destructor function pointer.
- JSRun.cpp:
(JSGlueGlobalObject::destroyData):
- JSRun.h:
(JSGlueGlobalObject::Data::Data):
WebCore:
Replaced with an explicit destructor function pointer.
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::destroyJSDOMGlobalObjectData):
- bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
- 10:44 AM Changeset in webkit [48882] by
-
- 2 edits in trunk/WebCore
The code for showing error pages when the response was
a 401/403/404, was not actually doing so. This patch
fixes that.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
- 9:43 AM Changeset in webkit [48881] by
-
- 2 edits in trunk/WebKitTools
Remove copying of unnecessary or nonexistent files from the ImageDiff
post-build event.
Reviewed by Adam Roben.
- DumpRenderTree/win/ImageDiff.vcproj:
- 9:19 AM Changeset in webkit [48880] by
-
- 3 edits in trunk/WebKitTools
2009-09-29 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by David Kilzer.
[Qt] Make build-webkit script work on Windows
https://bugs.webkit.org/show_bug.cgi?id=29802
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- Removed unnecessary -p switch for mkdir on Windows.
- Use canonical path, which uses slashes or backslashes depends on platform.
- isWindows() only test for Windows and not for Cyqwin.
- 9:19 AM Changeset in webkit [48879] by
-
- 7 edits in trunk
Reviewed by Brady Eidson.
<rdar://problem/7259965> REGRESSION: http/tests/xmlhttprequest/cross-origin-authorization.html
is failing/crashing intermittently
https://bugs.webkit.org/show_bug.cgi?id=29322
This was caused by CStringBuffer::encodeBase64() returning a buffer that wasn't zero terminated.
The code had other issues as well, so I removed it altogether:
- it claimed to avoid some buffer copies, but it didn't;
- and I don't think that base64 encoding should be part of CString interface.
WebCore:
- platform/network/mac/ResourceHandleMac.mm: (WebCore::encodeBasicAuthorization): Encode username and password using Base64.h directly. (WebCore::ResourceHandle::start): Use encodeBasicAuthorization(). (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Extended logging to synchronous case. (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto. (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto. (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
- platform/network/cf/ResourceHandleCFNet.cpp: Matched Mac changes.
- platform/text/CString.cpp:
- platform/text/CString.h: (WebCore::CStringBuffer::create): (WebCore::CStringBuffer::CStringBuffer): Removed code that was added for Base64 in r48363.
LayoutTests:
- http/tests/xmlhttprequest/cross-origin-authorization.html: While at it, made the test detect more error conditions
- 9:10 AM Changeset in webkit [48878] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by David Kilzer.
[Qt] Assert messages prints visible in Symbian
https://bugs.webkit.org/show_bug.cgi?id=29808
Asserts use vprintf to print the messages to stderr.
In Symbian Open C it is not possible to see stderr so
I routed the messages to stdout instead.
- wtf/Assertions.cpp:
- 8:18 AM Changeset in webkit [48877] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-29 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not set a non-default parent window for child widgets. We are
just doing the same than the default path does, and on top of that
if the widget's window changes (for example, during DnD widgets
are usually unrealized/realized) the child widget will we left
pointing to a dead window.
For examples of crashers caused by this see
https://bugzilla.gnome.org/show_bug.cgi?id=596397 and
https://bugzilla.gnome.org/show_bug.cgi?id=596398
- webkit/webkitwebview.cpp: (webkit_web_view_container_add):
- 8:00 AM Changeset in webkit [48876] by
-
- 2 edits in trunk/WebCore
2009-09-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix typo in Localizations.cpp
- platform/qt/Localizations.cpp: (WebCore::localizedMediaControlElementHelpText):
- 7:45 AM Changeset in webkit [48875] by
-
- 2 edits in trunk/WebCore
Make the XSLT conditional in DOMWindow.idl's xsltProcessor
attribute conditional in the generated files, similar to
r44116.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-29
Reviewed by Tor Arne Vestbø.
- page/DOMWindow.idl:
- 7:40 AM Changeset in webkit [48874] by
-
- 2 edits in trunk/WebKitTools
2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Fix time measurement in build-webkit after refactoring done in r48853.
- Scripts/build-webkit:
- 7:25 AM Changeset in webkit [48873] by
-
- 391 edits in trunk
[Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-29
Reviewed by Tor Arne Vestbø.
Done together with Renata Hodovan <renata.hodovan@stud.u-szeged.hu>
- 7:06 AM Changeset in webkit [48872] by
-
- 2 edits in trunk/WebKit/qt
https://bugs.webkit.org/show_bug.cgi?id=29844
Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
Reviewed by Simon Hausmann.
QWebPage dependency autotest fix.
Fix for database() autotest. All opened databases should be removed at
end of test.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::database):
- 7:06 AM Changeset in webkit [48871] by
-
- 3 edits in trunk/WebKit/qt
Some QWebHistory and QWebPage autotest crash fixes.
Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
Reviewed by Simon Hausmann.
Some checking for m_mainFrame were added. MainFrame should be created
at some point of QWebPage live cicle.
https://bugs.webkit.org/show_bug.cgi?id=29803
- Api/qwebpage.cpp:
(QWebPage::~QWebPage):
(QWebPage::currentFrame):
(QWebPage::history):
(QWebPage::selectedText):
(QWebPage::updatePositionDependentActions):
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::crashTests_LazyInitializationOfMainFrame):
- 6:55 AM Changeset in webkit [48870] by
-
- 7 edits in trunk
WebCore: Use the ResourceError as it is supposed to and handle
not HTTP errors from QNetworkReply.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.
Thanks to Adam Roben for his input.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
WebKit/qt: Implement QWebPage Extension for error pages, incl.
an example on how to use it in QtLauncher.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.
Correct our use of ResourceError.
- Api/qwebpage.h:
(ExtensionOption::):
(ExtensionOption::ErrorPageExtensionReturn::ErrorPageExtensionReturn):
- QtLauncher/main.cpp:
(WebPage::supportsExtension):
(MainWindow::MainWindow):
(MainWindow::selectElements):
(WebPage::extension):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::cancelledError):
(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientQt::fileDoesNotExistError):
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad):
- WebCoreSupport/FrameLoaderClientQt.h:
- 5:20 AM Changeset in webkit [48869] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Darin Adler.
[Qt] Symbian CRASH macro implementation
Added Symbian specific crash macro that
stops to crash line if JIT debugging is used.
Additional differentiation of access violation
(KERN-EXEC 3) and CRASH panic.
- wtf/Assertions.h:
- 4:43 AM Changeset in webkit [48868] by
-
- 2 edits in trunk/LayoutTests
2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Update Skipped list after test refactoring done in r48806.
- platform/qt/Skipped:
- 3:15 AM QtWebKitContrib edited by
- (diff)
- 3:12 AM QtWebKitTodo edited by
- (diff)
- 3:11 AM QtWebKitTodo edited by
- (diff)
- 2:56 AM Changeset in webkit [48867] by
-
- 2 edits in trunk/LayoutTests
2009-09-29 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Unskip the passing tests that make use of eventSender.contextClick().
https://bugs.webkit.org/show_bug.cgi?id=29821
- platform/qt/Skipped:
- 2:53 AM Changeset in webkit [48866] by
-
- 6 edits in trunk/WebCore
2009-09-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Encapsulate JS listeners specifics into ScriptEventListener.
- bindings/js/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
- bindings/js/ScriptEventListener.h:
- bindings/v8/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
- bindings/v8/ScriptEventListener.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForEventListener):
- 2:48 AM Changeset in webkit [48865] by
-
- 2 edits in trunk/WebCore
2009-09-29 Xan Lopez <xlopez@igalia.com>
Unreviewed attempt to fix the build.
- page/Settings.cpp: (WebCore::Settings::Settings):
- 2:48 AM Changeset in webkit [48864] by
-
- 3 edits in trunk/WebKitTools
2009-09-29 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement eventSender.contextClick().
https://bugs.webkit.org/show_bug.cgi?id=29821
- DumpRenderTree/qt/jsobjects.cpp: (EventSender::contextClick):
- DumpRenderTree/qt/jsobjects.h:
- 1:57 AM Changeset in webkit [48863] by
-
- 5 edits in trunk/LayoutTests
2009-09-29 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed. Fix 4 layout test failures by webkit r48861.
http://bugs.webkit.org/show_bug.cgi?id=29840
r48861 introduced experimentalWebSocketsEnabled, and false by default.
When experimentalWebSocketsEnabled is false, window.WebSocket is
undefined, instead of a constructor.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 12:22 AM Changeset in webkit [48862] by
-
- 1 edit in trunk/WebKit/win/WebPreferences.cpp
Fix the build by fixing a typo.
- 12:02 AM Changeset in webkit [48861] by
-
- 21 edits in trunk
2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Add experimentalWebSocketsEnabled in Settings.
https://bugs.webkit.org/show_bug.cgi?id=28941
- WebCore.base.exp:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webSocket):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor):
- bindings/v8/custom/V8WebSocketCustom.cpp:
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setExperimentalWebSocketsEnabled):
- page/Settings.h: (WebCore::Settings::experimentalWebSocketsEnabled):
2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Add experimentalWebSocketsEnabled in WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=28941
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences experimentalWebSocketsEnabled]): (-[WebPreferences setExperimentalWebSocketsEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Add experimentalWebSocketsEnabled in WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=28941
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setExperimentalWebSocketsEnabled): (WebPreferences::experimentalWebSocketsEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged): (core):
2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Add experimentalWebSocketsEnabled in WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=28941
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
Sep 28, 2009:
- 10:51 PM Changeset in webkit [48860] by
-
- 2 edits in trunk/JavaScriptCore
Fix the PowerPC build.
- JavaScriptCore.exp:
- 10:42 PM Changeset in webkit [48859] by
-
- 2 edits2 adds in trunk/WebCore
2009-09-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
Add platform code to support WebSocket for chromium.
https://bugs.webkit.org/show_bug.cgi?id=29171
To build within chromium tree, it requires a patch in bug 29174.
Real implementation will be landed in chromium tree.
- WebCore.gypi:
- platform/network/chromium/SocketStreamError.h: Added. (WebCore::SocketStreamError::SocketStreamError):
- platform/network/chromium/SocketStreamHandle.h: Added. (WebCore::SocketStreamHandle::create):
- 10:16 PM Changeset in webkit [48858] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-29 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Eric Seidel.
[Gtk] Crash when saving a password
https://bugs.webkit.org/show_bug.cgi?id=28070
Disconnect the 'got-headers' callback when we are done with
it. The signal can be emitted more than once if the message is
retransmitted, but each time that happens authData is created
again and a new callback connected, so we have to get rid of the
old one (which will crash because we free authData).
- webkit/webkitsoupauthdialog.c: (save_password_callback):
- 9:57 PM Changeset in webkit [48857] by
-
- 1 edit in tags/Safari-6531.5.1/JavaScriptCore/Configurations/Version.xcconfig
Versioning.
- 9:56 PM Changeset in webkit [48856] by
-
- 2 edits in tags/Safari-6531.5.1/JavaScriptCore
Merge r48854.
- 9:53 PM Changeset in webkit [48855] by
-
- 1 copy in tags/Safari-6531.5.1
New tag.
- 9:51 PM Changeset in webkit [48854] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/7195704> JavaScriptCore fails to mark registers when built for x86_64 using LLVM GCC.
Reviewed by Gavin Barraclough.
- runtime/Collector.cpp:
(JSC::Heap::markCurrentThreadConservatively): Force jmp_buf to use the appropriate alignment for a pointer
to ensure that we correctly interpret the contents of registers during marking.
- 9:01 PM Changeset in webkit [48853] by
-
- 4 edits1 add in trunk/WebKitTools
2009-09-28 Yaar Schnitman <yaar@chromium.org>
Reviewed by David Kilzer.
Integrated chromium port building into webkit tools update-webkit and
build-webkit.
- Scripts/build-webkit: When --chromium is specified, will build the chromium port (currently only Mac is supported).
- Scripts/update-webkit: When --chromium is specified, delegates to update-webkit-chromium.
- Scripts/webkitdirs.pm: Added chromium specific defs.
- Scripts/update-webkit-chromium: Uses gclient and gyp to fetch chromium port's dependencies and update its project files.
- 6:48 PM Changeset in webkit [48852] by
-
- 2 edits in trunk/WebKitTools
2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed.
Add myself to list of committers.
- Scripts/modules/committers.py:
- 6:10 PM Changeset in webkit [48851] by
-
- 2 edits5 adds in trunk/LayoutTests
2009-09-28 Zan Dobersek <zandobersek@gmail.com>
Reviewed by David Kilzer.
[Gtk][Layout tests] Generate results for css3 tests
https://bugs.webkit.org/show_bug.cgi?id=29784
Add results for css3 tests and enable these tests in the Skipped.
- platform/gtk/Skipped:
- platform/gtk/css3/css3-modsel-33-expected.txt: Added.
- platform/gtk/css3/css3-modsel-35-expected.txt: Added.
- platform/gtk/css3/css3-modsel-36-expected.txt: Added.
- platform/gtk/css3/css3-modsel-37-expected.txt: Added.
- 5:47 PM Changeset in webkit [48850] by
-
- 2 edits2 adds in trunk/LayoutTests
2009-09-28 Zan Dobersek <zandobersek@gmail.com>
Reviewed by David Kilzer.
[Gtk][Layout tests] Generate results for transitions tests
https://bugs.webkit.org/show_bug.cgi?id=29786
Add results for transitions tests and enable these tests in the Skipped.
- platform/gtk/Skipped:
- platform/gtk/transitions/transition-drt-api-expected.txt: Added.
- 5:35 PM Changeset in webkit [48849] by
-
- 2 edits3 adds in trunk/LayoutTests
2009-09-28 Zan Dobersek <zandobersek@gmail.com>
Reviewed by David Kilzer.
[Gtk][Layout tests] Generate results for animations tests
https://bugs.webkit.org/show_bug.cgi?id=29783
Add results for animations tests and enable these tests in the Skipped.
- platform/gtk/Skipped:
- platform/gtk/animations/animation-drt-api-expected.txt: Added.
- platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Added.
- 5:28 PM Changeset in webkit [48848] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7157288> Crash in RenderStyle::computedLineHeight()
when Times New Roman is not installed
Reviewed by Sam Weinig.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getLastResortFallbackFont): If Times New Roman is
not available, use the Windows default GUI font.
- 5:27 PM Changeset in webkit [48847] by
-
- 2 edits6 adds in trunk/LayoutTests
2009-09-28 Zan Dobersek <zandobersek@gmail.com>
Reviewed by David Kilzer.
[Gtk][Layout tests] Generate results for transforms tests
https://bugs.webkit.org/show_bug.cgi?id=29785
Add results for transforms tests and enable these tests in the Skipped.
- platform/gtk/Skipped:
- platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
- platform/gtk/transforms/2d/transform-borderbox-expected.txt: Added.
- platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt: Added.
- platform/gtk/transforms/no_transform_hit_testing-expected.txt: Added.
- 4:56 PM Changeset in webkit [48846] by
-
- 4 edits in trunk/WebCore
Do not add platform-specific methods to cross-platform header
FileSystem.h per Darin's feedback for 29109.
https://bugs.webkit.org/show_bug.cgi?id=29830
Reviewed by David Levin.
- platform/FileSystem.h:
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
- platform/chromium/FileSystemChromium.cpp:
- 4:35 PM WebKit Team edited by
- add ukai (diff)
- 4:33 PM Changeset in webkit [48845] by
-
- 3 edits in trunk/WebCore
2009-09-28 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Register Chromium's VFSs with a proper sqlite3_io_methods
finder. This should only affect the POSIX implementation. The
Windows change is included for consistency and in case sqlite
starts using something similar in its Windows VFS in the future.
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
- 4:25 PM Changeset in webkit [48844] by
-
- 2 edits in trunk/LayoutTests
2009-09-28 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Update the Skipped list after adding XSLT support.
https://bugs.webkit.org/show_bug.cgi?id=29817
Remove the tests that are passing now and skip these that are not,
with a reason of failure for each of them.
- platform/qt/Skipped:
- 3:58 PM Changeset in webkit [48843] by
-
- 2 edits in trunk/WebKitSite
2009-09-28 Alex Milowski <alex@milowski.com>
<http://webkit.org/b/29098> Update to MathML project webpage
Reviewed by David Kilzer.
Updated MathML project page and added link to Wiki page.
- projects/mathml/index.html:
- 3:50 PM Changeset in webkit [48842] by
-
- 2 edits in trunk/LayoutTests
2009-09-28 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
11 transforms/3d tests failing on the Leopard Debug bot after r48833
https://bugs.webkit.org/show_bug.cgi?id=29828
Leopard has HW compositing disabled until rdar://problem/7228836 can be fixed.
So skip tests which depend on it being enabled per Simon's request.
- platform/mac-leopard/Skipped:
- 3:25 PM Changeset in webkit [48841] by
-
- 2 edits in trunk/WebCore
2009-09-28 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Change the V8 bindings' handling of window.toString(),
so we return [object DOMWindow] (like JSC), not [object global].
This will fix a couple of Chromium port test failures and enable us to
use the default expectations for a bunch more.
- 3:23 PM Changeset in webkit [48840] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix: added new exports.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 3:16 PM Changeset in webkit [48839] by
-
- 4 edits in trunk
Roll out r48825. It causes build failures by calling an undefined function from within RefPtr.h.
- 3:06 PM Changeset in webkit [48838] by
-
- 2 edits in trunk/WebCore
2009-09-28 Nate Chapin <Nate Chapin>
Rubber stamped by David Levin.
Chromium build fix, add back in #include of V8Proxy.h in V8WebKitPointConstructor.cpp.
- bindings/v8/custom/V8WebKitPointConstructor.cpp: Re-include V8Proxy.h.
- 3:06 PM Changeset in webkit [48837] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix: removed exports that no longer exist.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 2:45 PM Changeset in webkit [48836] by
-
- 104 edits in trunk
NotNullPassRefPtr: smart pointer optimized for passing references that are not null
https://bugs.webkit.org/show_bug.cgi?id=29822
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
Reviewed by Darin Adler.
Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.
2.2% speedup on bench-allocate-nonretained.js.
- API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
- API/JSCallbackConstructor.h:
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::JSCallbackObject):
- JavaScriptCore.exp:
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::addFunctionExpr):
- runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
- runtime/ArrayConstructor.h:
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
- runtime/ArrayPrototype.h:
- runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
- runtime/BooleanConstructor.h:
- runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
- runtime/BooleanObject.h:
- runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
- runtime/BooleanPrototype.h:
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
- runtime/DateConstructor.h:
- runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
- runtime/DateInstance.h:
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
- runtime/DatePrototype.h:
- runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
- runtime/ErrorConstructor.h:
- runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
- runtime/ErrorInstance.h:
- runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
- runtime/ErrorPrototype.h:
- runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
- runtime/FunctionConstructor.h:
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
- runtime/FunctionPrototype.h:
- runtime/GlobalEvalFunction.cpp:
(JSC::GlobalEvalFunction::GlobalEvalFunction):
- runtime/GlobalEvalFunction.h:
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
- runtime/InternalFunction.h:
(JSC::InternalFunction::InternalFunction):
- runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
- runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
- runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
- runtime/JSArray.h:
- runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
- runtime/JSByteArray.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
- runtime/JSFunction.h:
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
- runtime/JSONObject.h:
(JSC::JSONObject::JSONObject):
- runtime/JSObject.h:
(JSC::JSObject::JSObject):
(JSC::JSObject::setStructure):
- runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
- runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::JSWrapperObject):
- runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
- runtime/MathObject.h:
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
- runtime/NativeErrorConstructor.h:
- runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
- runtime/NativeErrorPrototype.h:
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
- runtime/NumberConstructor.h:
- runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
- runtime/NumberObject.h:
- runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
- runtime/NumberPrototype.h:
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
- runtime/ObjectConstructor.h:
- runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
- runtime/ObjectPrototype.h:
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArrayData::setCachedPrototypeChain):
- runtime/PrototypeFunction.cpp:
(JSC::PrototypeFunction::PrototypeFunction):
- runtime/PrototypeFunction.h:
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
- runtime/RegExpConstructor.h:
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
- runtime/RegExpObject.h:
(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
- runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
- runtime/RegExpPrototype.h:
- runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
- runtime/StringConstructor.h:
- runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
- runtime/StringObject.h:
- runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
- runtime/StringPrototype.h:
- wtf/PassRefPtr.h:
(WTF::NotNullPassRefPtr::NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::~NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::get):
(WTF::NotNullPassRefPtr::clear):
(WTF::NotNullPassRefPtr::releaseRef):
(WTF::NotNullPassRefPtr::operator*):
(WTF::NotNullPassRefPtr::operator->):
(WTF::NotNullPassRefPtr::operator!):
(WTF::NotNullPassRefPtr::operator UnspecifiedBoolType):
- wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::operator==):
WebCore:
Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.
- bindings/js/DOMObjectWithSVGContext.h:
(WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
- bindings/js/JSDOMBinding.cpp:
(WebCore::cacheDOMStructure):
- bindings/js/JSDOMBinding.h:
(WebCore::DOMObject::DOMObject):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSHTMLAllCollection.h:
(WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
- bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
- bindings/js/JSInspectedObjectWrapper.h:
- bindings/js/JSInspectorCallbackWrapper.cpp:
(WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
- bindings/js/JSInspectorCallbackWrapper.h:
- bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
- bindings/js/JSQuarantinedObjectWrapper.h:
- bindings/js/JSWorkerContextBase.cpp:
(WebCore::JSWorkerContextBase::JSWorkerContextBase):
- bindings/js/JSWorkerContextBase.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/runtime_object.cpp:
(JSC::RuntimeObjectImp::RuntimeObjectImp):
- bridge/runtime_object.h:
- 2:38 PM Changeset in webkit [48835] by
-
- 1 edit1 add in trunk/LayoutTests
2009-09-28 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Add the expected result for the fast/xsl/document-function test.
https://bugs.webkit.org/show_bug.cgi?id=29817
- platform/qt/fast/xsl/document-function-expected.txt: Added.
- 2:30 PM Changeset in webkit [48834] by
-
- 2 edits in trunk/WebCore
2009-09-28 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Allow V8 to handle x/y parameters in a WebKitPoint constructor.
https://bugs.webkit.org/show_bug.cgi?id=29823
Fixes V8's handling of LayoutTests/fast/dom/Window/webkitConvertPoint.html
- bindings/v8/custom/V8WebKitPointConstructor.cpp: Allow for x/y parameters in constructor.
- 2:22 PM Changeset in webkit [48833] by
-
- 4 edits6 adds in trunk
2009-09-25 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
https://bugs.webkit.org/show_bug.cgi?id=28624
No longer skip media tests now that we're disabling hardware compositing instead.
Add leopard-specific results for 2 tests expected to fail with HW compositing disabled.
- platform/mac-leopard/Skipped:
- platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.checksum.
- platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.png.
- platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.txt.
- platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.checksum.
- platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.png.
- platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.txt.
2009-09-27 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Darin Adler.
run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
https://bugs.webkit.org/show_bug.cgi?id=29771
- Scripts/run-webkit-tests:
- 1:57 PM Changeset in webkit [48832] by
-
- 2 edits in trunk/WebCore
Fix the build by doing something approximating reasonableness in the Xcode project.
- WebCore.xcodeproj/project.pbxproj:
- 1:55 PM Changeset in webkit [48831] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7240911> REGRESSION (r48586): Crash occurs when loading
a PDF
Reviewed by Anders Carlsson.
CGPDFObjectRef is not a CFTypeRef, and cannot be retained or released.
Its lifetime is managed by its container. Just use a Vector to store
CGPDFObjectRefs, relying on the CGPDFDocument to keep them alive.
- WebView/WebPDFDocumentExtras.mm:
(appendValuesInPDFNameSubtreeToVector):
(getAllValuesInPDFNameTree):
(web_PDFDocumentAllScripts):
- 1:42 PM Changeset in webkit [48830] by
-
- 3 edits in trunk/JavaScriptCore
Hard dependency on SSE2 instruction set with JIT
https://bugs.webkit.org/show_bug.cgi?id=29779
Reviewed by Geoff Garen
Add floating point support checks to op_jfalse and op_jtrue, and
fix the logic for the slow case of op_add
- 1:41 PM Changeset in webkit [48829] by
-
- 2 edits in trunk/WebCore
Prospective Tiger build fix.
Patch by Simon Hausmann <Simon Hausmann> on 2009-09-28
- WebCore.xcodeproj/project.pbxproj: Try to use unique IDs for the new files.
- 1:33 PM Changeset in webkit [48828] by
-
- 6 edits in trunk/WebCore
2009-09-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add explicit frontend event for commit load.
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCommitLoad):
- inspector/InspectorFrontend.h:
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
- inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.didCommitLoad):
- 1:30 PM Changeset in webkit [48827] by
-
- 5 edits2 adds in trunk
2009-09-28 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium port - recognize we are being built independently
of chromium and look for dependencies under webkit/chromium rather
than chromium/src.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
2009-09-28 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium port - recognize we are being built independently
of chromium and look for dependencies under webkit/chromium rather
than chromium/src.
- WebCore.gyp/WebCore.gyp: See above. Also removed a few files from the sources list, since they are not supposed to be built here.
2009-09-28 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
- chromium/DEPS: Describes the chromium port's dependencies and is used by gclient to fetch them.
- chromium/webkit.gyp: Currently only builds webcore but in the future will also build the webkit api.
- 1:11 PM Changeset in webkit [48826] by
-
- 17 edits5 adds in trunk
[Qt] Implement XSLT support with QtXmlPatterns.
https://bugs.webkit.org/show_bug.cgi?id=28303
Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.
- wtf/Platform.h: Add a WTF_USE_QXMLQUERY #define.
WebCore:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setTransformSource):
- dom/Document.h:
(WebCore::Document::transformSource):
- dom/TransformSource.h: Added.
(WebCore::TransformSource::platformSource):
- dom/TransformSourceLibxslt.cpp: Added.
(WebCore::TransformSource::TransformSource): Wraps a libxml2 document.
(WebCore::TransformSource::~TransformSource):
- dom/TransformSourceQt.cpp: Added.
(WebCore::TransformSource::TransformSource): Wraps a plain string.
(WebCore::TransformSource::~TransformSource):
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::doEnd):
- dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::doEnd):
(WebCore::XMLTokenizer::parseProcessingInstruction):
- xml/XSLStyleSheet.h:
(WebCore::XSLStyleSheet::sheetString):
- xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::document):
- xml/XSLStyleSheetQt.cpp: Added.
- xml/XSLTProcessor.h:
- xml/XSLTProcessorLibxslt.cpp:
(WebCore::xmlDocPtrFromNode):
- xml/XSLTProcessorQt.cpp: Added.
(WebCore::XSLTMessageHandler::XSLTMessageHandler): A subclass of QAbstractMessageHandler.
(WebCore::XSLTMessageHandler::handleMessage): Forwards all processor messages to the Console.
(WebCore::XSLTProcessor::transformToString): Uses QXmlQuery.
- 1:09 PM Changeset in webkit [48825] by
-
- 4 edits in trunk
2009-09-28 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
Use derefInNotNull() to work around winscw compiler forward declaration bug
regarding templated classes.
The compiler bug is reported at
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.
The change should be reverted when the above bug is fixed in winscw compiler.
Add parenthesis around (RefPtr::*UnspecifiedBoolType) to make winscw compiler
work with the default UnSpecifiedBoolType() operator, which removes the winscw hack.
- wtf/RefPtr.h: (WTF::RefPtr::~RefPtr): (WTF::RefPtr::clear): (WTF::RefPtr::operator UnspecifiedBoolType):
2009-09-28 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
Make JObjectWrapper::ref() and deref() public accessible to derefIfNull().
Will be reverted when the following winscw compiler bug is fixed.
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812
- bridge/jni/jni_instance.h:
- 11:57 AM Changeset in webkit [48824] by
-
- 2 edits in trunk/JavaScriptCore
Remove clear_cache which is an internal function of GCC
https://bugs.webkit.org/show_bug.cgi?id=28886
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-09-28
Reviewed by Simon Hausmann.
Although clear_cache is exported from GCC, this is an internal
function. GCC makes no promises about it.
- jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
- 11:51 AM Changeset in webkit [48823] by
-
- 3 edits1 move in trunk/LayoutTests
2009-09-28 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Move message-port-multi.js from resources to script-tests
https://bugs.webkit.org/show_bug.cgi?id=29798
- fast/events/message-port-multi-expected.txt:
- fast/events/message-port-multi.html:
- fast/events/resources/message-port-multi.js: Removed.
- fast/events/script-tests/message-port-multi.js: Added. (channel.port2.onmessage):
- 11:43 AM Changeset in webkit [48822] by
-
- 7 edits in trunk/WebCore
2009-09-28 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Delegate implementation of rendererIsNeeded() for media control elements to RenderTheme.
Covered by LayoutTests/media/video-no-audio.html
- rendering/MediaControlElements.cpp: Removed subclass implementations of rendererIsNeeded(). (WebCore::MediaControlElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart(). (WebCore::MediaControlInputElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart().
- rendering/MediaControlElements.h:
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::shouldRenderMediaControlPart): New method. Contains logic moved from subclass implementations of rendererIsNeeded().
- rendering/RenderTheme.h:
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Override to always render mute button.
- rendering/RenderThemeChromiumSkia.h:
- 11:13 AM Changeset in webkit [48821] by
-
- 5 edits in trunk/WebCore
[chromium] DragData::asURL should return file URL.
https://bugs.webkit.org/show_bug.cgi?id=29109
Reviewed by David Levin.
Tested by LayoutTests/fast/events/drag-to-navigate.html.
- platform/FileSystem.h:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
- platform/chromium/FileSystemChromium.cpp:
(WebCore::getAbsolutePath):
(WebCore::isDirectory):
(WebCore::filePathToURL):
- 10:57 AM Changeset in webkit [48820] by
-
- 2 edits in trunk/WebCore
2009-09-28 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
[V8] Add a special case to handle index arguments, because we need to be
able to see if they're < 0.
https://bugs.webkit.org/show_bug.cgi?id=29810
Test: LayoutTests/dom/html/level1/core/hc_characterdataindexsizeerrdeletedatacountnegative.html
- bindings/scripts/CodeGeneratorV8.pm: Added special case (matching CodeGeneratorJS.pm) for index arguments.
- 10:55 AM Changeset in webkit [48819] by
-
- 2 edits in trunk/JavaScriptCore
Fix an absolute path to somewhere in Oliver's machine to a relative path
for derived JSONObject.lut.h.
Reviewed by Oliver Hunt.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 9:34 AM Changeset in webkit [48818] by
-
- 2 edits in trunk/WebCore
Extend the MediaWiki/KHTMLFixes.css workaround to cover older MediaWiki versions
https://bugs.webkit.org/show_bug.cgi?id=29792
Reviewed by Darin Adler.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet): If site specific hacks are
enabled, check if the linked style sheet is one of two versions of the
MediaWiki KHTMLFixes.css. If so, remove the offending rule.
- 9:29 AM Changeset in webkit [48817] by
-
- 2 edits in trunk/WebCore
2009-09-28 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Fix an error in type logic in CodeGeneratorV8.pm, where
unsigned ints are accidentally used as signed.
https://bugs.webkit.org/show_bug.cgi?id=29810
Test: LayoutTests/fast/forms/textarea-maxlength.html
- bindings/scripts/CodeGeneratorV8.pm: Made sure "unsigned long" in IDL is properly generates on "unsigned" return value.
- 9:14 AM Changeset in webkit [48816] by
-
- 6 edits4 adds in trunk
2009-09-25 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
ASSERTION FAILED: !repaintContainer repaintContainer == this It's possible for RenderObject::container() to return an object that is higher
in the hierarchy than the repaintContainer that is being used to repaint an
object. For example, this can happen when running an accelerated opacity
transition on an element with a position:absolute parent, and a position:absolute child.
In this case we need to detect when RenderObject::container() will skip over
repaintContainer, and in that case adjust the coords to shift into repaintContainer's space.
Test: compositing/repaint/opacity-between-absolute.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderInline.cpp: (WebCore::RenderInline::computeRectForRepaint):
- rendering/RenderObject.cpp: (WebCore::RenderObject::container):
- rendering/RenderObject.h:
- 8:06 AM Changeset in webkit [48815] by
-
- 6 edits1 move in trunk/WebCore
Rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp.
https://bugs.webkit.org/show_bug.cgi?id=28303
Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.
In preparation for adding XSLT support with QtXmlPatterns to the Qt
port, rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp as we will
have our own implementation which most likely will not share any code
with the current one.
Additionally, fix some coding style issues.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- xml/XSLStyleSheet.cpp: Renamed to XSLStyleSheetLibxslt.cpp.
- xml/XSLStyleSheetLibxslt.cpp: Added.
- 7:45 AM Changeset in webkit [48814] by
-
- 2 edits in trunk/WebCore
Prospective build fix for r48812.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-28
Forgot to remove the inline reset() implementation when reverting the indentation
changes in the file.
- xml/XSLTProcessor.h:
- 7:40 AM Changeset in webkit [48813] by
-
- 2 edits in trunk/WebCore
2009-09-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by nobody (trivial follow up fix), Joseph Pecoraro LGTM-ed.
Web Inspector: Follow up to r48809.
InspectorController.wrapObject should only be called on the inspectable page side.
- inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): (WebInspector.EventListenersSection): (WebInspector.EventListenersSection.prototype.update): (WebInspector.EventListenerBar): (WebInspector.EventListenerBar.prototype.update):
- 7:36 AM Changeset in webkit [48812] by
-
- 7 edits1 copy in trunk/WebCore
Move the libxslt specific part of XSLTProcessor to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=28303
Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.
In preparation for adding XSLT support with QtXmlPatterns to the Qt
port, move the libxslt part of the XSLTProcessor implementation into
another file and leave the part that can be reused and shared.
Additionally, fix some coding style issues.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource): Remove trailing whitespaces.
(WebCore::createFragmentFromSource): Remove trailing whitespaces.
(WebCore::XSLTProcessor::transformToFragment): Remove trailing whitespaces.
(WebCore::XSLTProcessor::reset): Moved out of the class definition.
- xml/XSLTProcessorLibxslt.cpp: Added.
(WebCore::XSLTProcessor::genericErrorFunc): Moved.
(WebCore::XSLTProcessor::parseErrorFunc): Moved.
(WebCore::docLoaderFunc): Moved.
(WebCore::setXSLTLoadCallBack): Moved.
(WebCore::writeToVector): Moved.
(WebCore::saveResultToString): Moved.
(WebCore::xsltParamArrayFromParameterMap): Moved.
(WebCore::freeXsltParamArray): Moved.
(WebCore::xsltStylesheetPointer): Moved.
(WebCore::xmlDocPtrFromNode): Moved.
(WebCore::resultMIMEType): Moved.
(WebCore::XSLTProcessor::transformToString): Moved.
- 7:28 AM Changeset in webkit [48811] by
-
- 1 edit in trunk/WebCore/svg/SVGUseElement.cpp
Minor correction to Copyright notice. Not reviewed.
- 6:35 AM Changeset in webkit [48810] by
-
- 3 edits2 adds in trunk
2009-09-28 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
Fix the crash of SVG that crashes when use a non-exist symbol
https://bugs.webkit.org/show_bug.cgi?id=27693
- svg/custom/use-non-existing-symbol-crash-expected.txt: Added.
- svg/custom/use-non-existing-symbol-crash.svg: Added.
2009-09-28 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
Fix the crash of SVG that crashes when use a non-exist symbol
https://bugs.webkit.org/show_bug.cgi?id=27693
Test: svg/custom/use-non-existing-symbol-crash.svg
- svg/SVGUseElement.cpp: (WebCore::shadowTreeContainsChangedNodes):
- 5:36 AM Changeset in webkit [48809] by
-
- 21 edits3 adds in trunk/WebCore
2009-09-28 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Inspector Should Show Event Listeners/Handlers Registered on each Node
https://bugs.webkit.org/show_bug.cgi?id=17429
Extracted a method from dispatchEvent to get the event ancestor chain
- dom/Node.cpp: (WebCore::Node::eventAncestors): the extracted method (WebCore::Node::dispatchGenericEvent): use eventAncestors
- dom/Node.h:
Asynchronous Flow For the Inspector, Backend -> DOM Agent -> Frontend
The DOMAgent's getEventListenersForNode handles the logic of finding
all the relevant listeners in the event flow.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getEventListenersForNode):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::buildObjectForEventListener): (WebCore::InspectorDOMAgent::buildObjectForNode): added localName
- inspector/InspectorDOMAgent.h: (WebCore::EventListenerInfo::EventListenerInfo):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetEventListenersForNode):
- inspector/InspectorFrontend.h: (WebCore::InspectorFrontend::scriptState):
- inspector/front-end/DOMAgent.js: added localName to WebInspector.DOMNode from payload (WebInspector.EventListeners.getEventListenersForNodeAsync.mycallback): (WebInspector.EventListeners.getEventListenersForNodeAsync):
New Sidebar Pane in the Element's Panel
Includes Gear Menu for filtering the Event Listeners on the
"Selected Node Only" or "All Nodes"
- inspector/front-end/ElementsPanel.js: Handles refreshing the Pane when necessary (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.updateEventListeners):
- inspector/front-end/EventListenersSidebarPane.js: Added. (WebInspector.EventListenersSidebarPane): The 1st level in the Pane (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): (WebInspector.EventListenersSection): The 2nd level in the Pane (WebInspector.EventListenersSection.prototype.update): filters on Preference (WebInspector.EventListenersSection.prototype.addListener): (WebInspector.EventListenerBar): The 3rd level in the Pane (WebInspector.EventListenerBar.prototype._getNodeDisplayName): (WebInspector.EventListenerBar.prototype._getFunctionDisplayName): (WebInspector.EventListenersSidebarPane.prototype._changeSetting): For the Gear Menu
Consolidated "appropriateSelectorForNode"
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/utilities.js:
Miscellaneous Updates
- English.lproj/localizedStrings.js: "Event Listeners", "No Event Listeners", "Selected Node Only", "All Nodes"
- WebCore.gypi: included the new inspector files
- WebCore.vcproj/WebCore.vcproj: included source files that were missing
- inspector/front-end/Images/grayConnectorPoint.png: Added. Thanks to Timothy Hatcher.
- inspector/front-end/Images/whiteConnectorPoint.png: Added. Thanks to Timothy Hatcher.
- inspector/front-end/inspector.js: Preferences for the Gear Menu Event Listeners filter
- inspector/front-end/inspector.css: reused as much as possible
- inspector/front-end/inspector.html: include the new script
- inspector/front-end/WebKit.qrc: included the new inspector files
- 4:16 AM Changeset in webkit [48808] by
-
- 2 edits in trunk/WebKit/qt
Compile fix with namespaced Qt.
Patch by Andre Poenitz <andre.poenitz@trolltech.com> on 2009-09-28
Reviewed by Simon Hausmann.
- Api/qwebinspector_p.h:
- 2:17 AM Changeset in webkit [48807] by
-
- 2 edits in trunk/JavaScriptCore
Add ARM version detection for Windows CE.
Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-28
Reviewed by Simon Hausmann.
- wtf/Platform.h:
Sep 27, 2009:
- 9:49 PM WebKit Team edited by
- (diff)
- 4:59 PM Changeset in webkit [48806] by
-
- 8 edits6 moves6 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29760
Implement CSSOM Range.getClientRects/getBoundingClientRect
Reviewed by Dan Bernstein.
Tests: fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html
fast/dom/Range/getBoundingClientRect.html
fast/dom/Range/getClientRects.html
- dom/Range.cpp:
(WebCore::Range::getClientRects):
(WebCore::Range::getBoundingClientRect):
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoom):
(WebCore::Range::getBorderAndTextQuads):
- dom/Range.h:
- dom/Range.idl:
Implement Range.getClientRects/getBoundingClientRect.
- dom/Element.cpp:
- rendering/RenderObject.h:
(WebCore::adjustForAbsoluteZoom):
(WebCore::adjustIntRectForAbsoluteZoom):
(WebCore::adjustFloatPointForAbsoluteZoom):
(WebCore::adjustFloatQuadForAbsoluteZoom):
Move point/quad adjustment methods from Element.cpp to RenderObject.h
so that Range.cpp can use them as well.
LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=29760
Implement CSSOM Range.getClientRects/getBoundingClientRect
Reviewed by Dan Bernstein.
- fast/dom/Element/getBoundingClientRect-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-expected.txt.
- fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt.
- fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport.html: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html.
- fast/dom/Element/getBoundingClientRect.html: Copied from LayoutTests/fast/dom/getBoundingClientRect.html.
- fast/dom/Element/getClientRects-expected.txt: Copied from LayoutTests/fast/dom/getClientRects-expected.txt.
- fast/dom/Element/getClientRects.html: Copied from LayoutTests/fast/dom/getClientRects.html.
- fast/dom/Range/getBoundingClientRect-expected.txt: Added.
- fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Added.
- fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html: Added.
- fast/dom/Range/getBoundingClientRect.html: Added.
- fast/dom/Range/getClientRects-expected.txt: Added.
- fast/dom/Range/getClientRects.html: Added.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/getBoundingClientRect-expected.txt: Removed.
- fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Removed.
- fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html: Removed.
- fast/dom/getBoundingClientRect.html: Removed.
- fast/dom/getClientRects-expected.txt: Removed.
- fast/dom/getClientRects.html: Removed.
- 2:33 PM Changeset in webkit [48805] by
-
- 4 edits in trunk/WebKit/qt
2009-09-27 Joe Ligman <joseph.ligman@mindspring.com>
Reviewed by Simon Hausmann.
[Qt] Adding API setFocus and hasFocus to QWebElement. This API is needed for
clients that want to check/set the focus node of the document.
https://bugs.webkit.org/show_bug.cgi?id=29682
- Api/qwebelement.cpp: (QWebElement::hasFocus): (QWebElement::setFocus):
- Api/qwebelement.h:
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::hasSetFocus):
- 2:32 PM Changeset in webkit [48804] by
-
- 2 edits in trunk/WebCore
Unreviewed fix for WebInspector with Qt build.
Patch by Simon Hausmann <Simon Hausmann> on 2009-09-27
Simply re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource
- inspector/front-end/WebKit.qrc:
- 12:45 PM Changeset in webkit [48803] by
-
- 2 edits in trunk/WebKitTools
2009-09-27 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Darin Adler.
run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
https://bugs.webkit.org/show_bug.cgi?id=29771
- Scripts/run-webkit-tests:
- 12:17 PM BuildingGtk edited by
- (diff)
- 12:12 PM Changeset in webkit [48802] by
-
- 2 edits in trunk/LayoutTests
2009-09-27 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Remove tests that are passing from the Skipped list after implementing
the waitForPolicyDelegate() function in LayoutTestController.
https://bugs.webkit.org/show_bug.cgi?id=25037
- platform/qt/Skipped:
- 12:05 PM Changeset in webkit [48801] by
-
- 5 edits in trunk/WebKitTools
2009-09-27 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement layoutTestController.waitForPolicyDelegate.
https://bugs.webkit.org/show_bug.cgi?id=25037
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::acceptNavigationRequest):
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::notifyDone): (LayoutTestController::waitForPolicyDelegate):
- DumpRenderTree/qt/jsobjects.h: (LayoutTestController::waitForPolicy):
- 2:44 AM Changeset in webkit [48800] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-09-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by nobody (trivial ChangeLog fix).
Restore WebCore/ChangeLog truncated in r48778.
- 2:19 AM Changeset in webkit [48799] by
-
- 3 edits in trunk/WebCore
2009-09-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: DOM store is being unbound twice, leading to assertion failure.
- inspector/InspectorController.cpp: (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage):
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::unbind):
- 2:14 AM Changeset in webkit [48798] by
-
- 7 edits in trunk/WebCore
2009-09-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not track DOM changes while inspector window is closed.
- inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
- inspector/InspectorDOMAgent.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchWindowObjectAvailable):
- page/android/InspectorControllerAndroid.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
- 12:08 AM Changeset in webkit [48797] by
-
- 4 edits in trunk/WebCore
2009-09-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [REGRESSION] Double Clicking Resources Fails to Open in New Window
- inspector/front-end/InjectedScript.js: (InjectedScript.setStyleText): (InjectedScript.openInInspectedWindow):
- inspector/front-end/InjectedScriptAccess.js:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
Sep 26, 2009:
- 8:15 PM Changeset in webkit [48796] by
-
- 2 edits in trunk
GTK BUILD FIX: add ENABLE_ORIENTATION_EVENTS support to configure.ac
- configure.ac: Added support for ENABLE_ORIENTATION_EVENTS.
- 8:02 PM Changeset in webkit [48795] by
-
- 6 edits in trunk
Part 2 of 2: <http://webkit.org/b/29753> DerivedSources.make broken for non-Mac targets
Reviewed by Darin Adler.
Fix ENABLE_ORIENTATION_EVENTS for non-Mac platforms.
WebCore:
- DerivedSources.make: Moved Platform.h check for ENABLE_ORIENTATION_EVENTS into Mac-only section and added default of ENABLE_ORIENTATION_EVENTS = 0 to non-Mac section. Added ifndef test to make it possible to override both ENABLE_DASHBOARD_SUPPORT and ENABLE_ORIENTATION_EVENTS external to the makefile. Moved addition of ENABLE_ORIENTATION_EVENTS to ADDITIONAL_IDL_DEFINES to common section.
- GNUmakefile.am: Added support for ENABLE_ORIENTATION_EVENTS if it is ever used.
- WebCore.pro: Ditto.
WebKit:
- chromium/features.gypi: Added 'ENABLE_ORIENTATION_EVENTS=0' to disable this feature by default.
- 4:14 PM Changeset in webkit [48794] by
-
- 3 edits in trunk/WebKitTools
<http://webkit.org/b/29764> mark-bug-fixed: add -oopen switch Reviewed by Eric Seidel.
The -oopen switch uses the open(1) command on Mac OS X to open the bug URL in the default web browser. If there are
similar mechanisms on other platforms, they may be added later.
- Scripts/mark-bug-fixed:
(MarkBugFixed.init): Added -oopen switch to list of parse options.
(MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
code into main() and extracted prompting code into
_prompt_user_for_correctness().
(MarkBugFixed._open_bug_in_web_browser): Added.
(MarkBugFixed._prompt_user_for_correctness): Added.
(MarkBugFixed.main): Added logging code from
_determine_bug_id_and_svn_revision(). Added code to call
_open_bug_in_web_browser() if the switch is set. Added code to
call _prompt_user_for_correctness() when needed.
- Scripts/modules/bugzilla.py: (Bugzilla.short_bug_url_for_bug_id): Added.
- 3:57 PM Changeset in webkit [48793] by
-
- 3 edits in trunk/WebKitTools
svn-unapply and svn-apply don't work when used outside multiple svn working directories
<http://webkit.org/b/29744>
<rdar://problem/7252905>
Reviewed by Eric Seidel.
Some users have a workflow where svn-create-patch, svn-apply and
svn-unapply are used outside of multiple svn working
directories. Instead of aborting the scripts in these cases,
print a warning and assume that Subversion is being used.
- Scripts/VCSUtils.pm: (determineVCSRoot): Call warn() instead of die() if both isGit() and isSVN() initially return false. Set $VCSUtils::isSVN to 1 to enforce the assumption about Subversion, then return determineSVNRoot().
- Scripts/svn-apply: Switch to using isGit() and isSVN() from VCSUtils.pm. They both already cache their values and checking here is redundant since determineVCSRoot() is called later.
- 11:56 AM Changeset in webkit [48792] by
-
- 18 edits in trunk/WebCore
2009-09-26 Kent Tamura <tkent@chromium.org>
Reviewed by David Kilzer.
Move placeholder-related code to HTMLTextFormControlElement from
HTMLInputElement, WMLInputElement, InputElement, and
HTMLTextAreaElement.
https://bugs.webkit.org/show_bug.cgi?id=28703
- dom/InputElement.cpp: (WebCore::InputElement::dispatchFocusEvent): (WebCore::InputElement::dispatchBlurEvent): (WebCore::InputElement::setValueFromRenderer):
- dom/InputElement.h:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): (WebCore::HTMLTextFormControlElement::~HTMLTextFormControlElement): (WebCore::HTMLTextFormControlElement::dispatchFocusEvent): (WebCore::HTMLTextFormControlElement::dispatchBlurEvent): (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): (WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
- html/HTMLFormControlElement.h: (WebCore::HTMLTextFormControlElement::handleFocusEvent): (WebCore::HTMLTextFormControlElement::handleBlurEvent):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::handleFocusEvent): (WebCore::HTMLInputElement::handleBlurEvent): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::supportsPlaceholder): (WebCore::HTMLInputElement::isEmptyValue):
- html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::parseMappedAttribute):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): (WebCore::HTMLTextAreaElement::createRenderer):
- html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::supportsPlaceholder): (WebCore::HTMLTextAreaElement::isEmptyValue):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::updateFromElement):
- rendering/RenderTextControlSingleLine.h:
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::createRenderer):
- wml/WMLInputElement.h:
- 10:51 AM Changeset in webkit [48791] by
-
- 3 edits1 add in trunk/WebKitTools
2009-09-26 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
[Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
https://bugs.webkit.org/show_bug.cgi?id=29689
Load test fonts through FontConfig before each test.
This ensures a more proper rendering of the tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): (runTest): (main):
- DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
- GNUmakefile.am:
- 8:00 AM Changeset in webkit [48790] by
-
- 2 edits in trunk/WebCore
2009-09-26 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Alexey Proskuryakov.
Optimize the code so only the text from start to end is scanned.
https://bugs.webkit.org/show_bug.cgi?id=29092
On a platform with webkit+Qt+Symbian, the parsing time for a 600K text
file improved from 400ms to 40ms (10x faster).
- dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
- 6:12 AM Changeset in webkit [48789] by
-
- 2 edits2 adds in trunk/WebCore
2009-09-26 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel.
This Patch fixes [chromium] the drop-down is always left-aligned even
for RTL element.
https://bugs.webkit.org/show_bug.cgi?id=29612
For auto-complete, the items in drop-down should be right-aligned if
the directionality of <input> field is RTL.
For <select><option>, the items in drop-down should be right-aligned
if the directionality of <select> is RTL.
No automatic test is possible. Manual tests are added.
- manual-tests/autofill_alignment.html: Added.
- manual-tests/select_alignment.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow): Adjust the starting x-axis of text to be paint if it should be right-aligned.
- 5:47 AM Changeset in webkit [48788] by
-
- 3 edits1 add in trunk/JavaScriptCore
Add MarkStackSymbian.cpp to build JavascriptCore for Symbian.
Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-09-26
Reviewed by Simon Hausmann.
Re-use Windows shrinkAllocation implementation because Symbian doesn't
support releasing part of memory region.
Use fastMalloc and fastFree to implement allocateStack and releaseStack
for Symbian port.
- JavaScriptCore.pri:
- runtime/MarkStack.h:
(JSC::MarkStack::MarkStackArray::shrinkAllocation):
- runtime/MarkStackSymbian.cpp: Added.
(JSC::MarkStack::initializePagesize):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):
Sep 25, 2009:
- 11:43 PM Changeset in webkit [48787] by
-
- 2 edits in trunk/WebCore
REGRESSION (r48775) FontList.plist written by TOT WebKit causes Safari 4
to crash on launch
https://bugs.webkit.org/show_bug.cgi?id=29759
Reviewed by Sam Weinig.
- platform/graphics/win/FontDatabase.cpp:
(WebCore::writeFontDatabaseToPlist): Reverted to saving the CG font DB
property list at the root of FontList.plist, but with an additional
key for the last value of the Fonts registry key.
(WebCore::populateFontDatabase): Pass the FontList.plist in its entirety
to populatFontDatabaseFromPlist.
- 11:41 PM Changeset in webkit [48786] by
-
- 2 edits in trunk/WebKit/wx
wx build fix. Add EmptyPluginHalterClient when creating Page.
- 11:31 PM Changeset in webkit [48785] by
-
- 2 edits in trunk/WebCore
Build fix. Adding missing header files.
- 9:32 PM Changeset in webkit [48784] by
-
- 2 edits in trunk/WebCore
Part 1 of 2: <http://webkit.org/b/29753> DerivedSources.make broken for non-Mac targets
Reviewed by Darin Adler.
- DerivedSources.make: Move tests for ENABLE_CONTEXT_MENUS, ENABLE_DRAG_SUPPORT and ENABLE_INSPECTOR into Mac-only section.
- 7:35 PM Changeset in webkit [48783] by
-
- 3 edits3 adds in trunk
2009-09-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Load blocks during unload should not affect targeted loads
https://bugs.webkit.org/show_bug.cgi?id=29747
Test that we can follow targeted hyperlinks in an unload handler.
- fast/loader/resources/unload-hyperlink-targeted-subframe.html: Added.
- fast/loader/unload-hyperlink-targeted-expected.txt: Added.
- fast/loader/unload-hyperlink-targeted.html: Added.
2009-09-25 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Load blocks during unload should not affect targeted loads
https://bugs.webkit.org/show_bug.cgi?id=29747
Move the check of the unload state after checking for targeted links.
Test: fast/loader/unload-hyperlink-targeted.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL):
- 7:27 PM Changeset in webkit [48782] by
-
- 7 edits in trunk/JavaScriptCore
2009-09-25 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Fix unaligned data access in YARR_JIT on ARMv5 and below.
https://bugs.webkit.org/show_bug.cgi?id=29695
On ARMv5 and below all data access should be naturally aligned.
In the YARR_JIT there is a case when character pairs are
loaded from the input string, but this data access is not
naturally aligned. This fix introduces load32WithUnalignedHalfWords
and branch32WithUnalignedHalfWords functions which contain
naturally aligned memory loads - half word loads - on ARMv5 and below.
- assembler/MacroAssemblerARM.cpp: (JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::load32WithUnalignedHalfWords): (JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
- assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32WithUnalignedHalfWords): (JSC::MacroAssemblerARMv7::branch32): (JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::load32WithUnalignedHalfWords): (JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
- wtf/Platform.h:
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generatePatternCharacterPair):
- 7:13 PM Changeset in webkit [48781] by
-
- 13 edits5 copies5 adds in trunk
2009-09-25 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[Chromium] Add initial V8 bindings for WebGL
https://bugs.webkit.org/show_bug.cgi?id=29664
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8CanvasArrayBufferCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8CanvasArrayCustom.h: Added. (WebCore::constructCanvasArray):
- bindings/v8/custom/V8CanvasByteArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8CanvasFloatArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8CanvasIntArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8CanvasRenderingContext3DCustom.cpp: Added. (WebCore::jsArrayToFloatArray): (WebCore::jsArrayToIntArray): (WebCore::CALLBACK_FUNC_DECL): (WebCore::): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
- bindings/v8/custom/V8CanvasShortArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8CanvasUnsignedByteArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8CanvasUnsignedIntArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8CanvasUnsignedShortArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- platform/graphics/GraphicsContext3D.h:
- 6:45 PM Changeset in webkit [48780] by
-
- 4 edits in trunk
JavaScriptCore: This is breaking Chromium try bots, so I'm counting this as a build fix.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-25
Add more svn:ignore exceptions. On different platforms, these files are
generated with different case for JavaScriptCore. Also there are some
wtf project files that get built apparently.
- JavaScriptCore.gyp: Changed property svn:ignore.
WebCore: This is breaking Chromium try bots, so I'm counting this as a build fix.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-25
Add more svn:ignore exceptions. On different platforms, these files are
generated with different case for WebCore.
- WebCore.gyp: Changed property svn:ignore.
- 5:57 PM Changeset in webkit [48779] by
-
- 3 edits in trunk/JavaScriptCore
Build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 5:21 PM Changeset in webkit [48778] by
-
- 30 edits10 deletes in trunk
Reverting r48767, as it broke Windows build in a non-trivial way.
- 4:18 PM Changeset in webkit [48777] by
-
- 2 edits in trunk/WebCore
2009-09-24 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
Add a gyp variable to allow building a debug webcore without debug
symbols. This allows for faster compile, link, and gdb times.
No new tests, build config change.
- WebCore.gyp/WebCore.gyp:
- 4:11 PM Changeset in webkit [48776] by
-
- 2 edits in trunk/WebCore
2009-09-25 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Declare RegisteredEventListener as a class instead of a struct.
This fixes a warning in the Chromium build.
- dom/RegisteredEventListener.h:
- 4:07 PM Changeset in webkit [48775] by
-
- 6 edits in trunk
WebCore: WebCore part of
<rdar://problem/7211635> 2 byte characters are displayed as garbaged
<rdar://problem/7212626> garbled/gibberish text (off-by-one)
Reviewed by Jon Honeycutt.
When the Windows Fonts directory contains more than one font file for a
given font name, which of the fonts gets assigned to the name in the
Core Graphics font database was determined arbitrarily and did not
always match the font GDI used for the same font name. The mismatch
caused character-to-glyph mapping to use one font and glyph rendering to
use another.
The fix is to update the Core Graphics font database from the registry
entries (that reflect the name-to-font mapping that GDI uses) after
populating it with the result of scanning the Fonts directory. As a
consequence, the directory needs to be scanned at startup every time the
registry key changes, so the last value of the registry key is kept
in the property list on disk so that it could be compared to the current
value on startup.
- platform/graphics/win/FontDatabase.cpp:
(WebCore::populateFontDatabaseFromPlist): Now takes a property list as
a parameter and avoids round-tripping through XML by calling
wkAddFontsFromPlist() instead of wkAddFontsFromPlistRepresentation().
(WebCore::fontFilenamesFromRegistryKey):
(WebCore::cgFontDBKey):
(WebCore::writeFontDatabaseToPlist): Now takes the CG font DB property
list and a property list with the font filenames from the registry and
writes a dictionary with those property lists as values.
(WebCore::fontFilenamesFromRegistry): Added. Returns an array with the
values in the HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Fonts
registry key.
(WebCore::populateFontDatabase): Changed to read the contents of the
Fonts registry key and compare it with the last-saved value from the
property list, and to call wkAddFontsFromRegistry() after populating the
CG font DB from the file system. Uses wkCreateFontsPlist() instead of
wkCreateFontsPlistRepresentation() to avoid round-tripping through XML.
WebKitLibraries: WebKitSystemInterface changes for
<rdar://problem/7211635> 2 byte characters are displayed as garbaged
<rdar://problem/7212626> garbled/gibberish text (off-by-one)
Reviewed by Adam Roben.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added
wkAddFontsFromPlistRepresentation() and replaced
wkCreateFontsPlistRepresentation() with wkCreateFontsPlist() and
wkAddFontsFromPlistRepresentation() with wkAddFontsFromPlist().
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 3:26 PM Changeset in webkit [48774] by
-
- 18 edits in trunk
JavaScriptCore: Inlined some object creation code, including lexicalGlobalObject access
https://bugs.webkit.org/show_bug.cgi?id=29750
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-25
Reviewed by Darin Adler.
SunSpider says 0.5% faster.
0.8% speedup on bench-alloc-nonretained.js.
2.5% speedup on v8-splay.js.
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
- interpreter/CallFrame.h:
(JSC::ExecState::lexicalGlobalObject):
(JSC::ExecState::globalThisValue):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
- runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
- runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::~ScopeChainNode):
(JSC::ScopeChainNode::push):
(JSC::ScopeChain::ScopeChain):
(JSC::ScopeChain::globalObject): Added a globalObject data member to ScopeChainNode.
Replaced accessor function for globalObject() with data member. Replaced
globalThisObject() accessor with direct access to globalThis, to match.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObject.h: Inlined array and object construction.
WebCore: Inlined some object creation code, including lexicalGlobalObject access
https://bugs.webkit.org/show_bug.cgi?id=29750
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-25
Reviewed by Darin Adler.
- bindings/js/JSInspectorBackendCustom.cpp:
(WebCore::JSInspectorBackend::currentCallFrame):
- inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::hasBreakpoint): Updated for JavaScriptCore
API changes.
- 3:24 PM Changeset in webkit [48773] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=24399
Make @import work in user stylesheets. The first bug was that the URL wasn't being set on the
user sheets themselves, so relative @import URLs couldn't resolve properly. The second bug
was that the loads would be denied. This is fixed by using the requestUserCSSStyleSheet method
instead of the normal request method. In order to know when to do this, CSSStyleSheets now have
a propagated boolean, m_isUserStyleSheet, that lets them know if they are user stylesheets or not.
Reviewed by Anders Carlsson.
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::CSSStyleSheet):
- css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::setIsUserStyleSheet):
(WebCore::CSSStyleSheet::isUserStyleSheet):
- dom/Document.cpp:
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
- 3:02 PM Changeset in webkit [48772] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/29718> mark-bug-fixed: add -uupdate-only switch Reviewed by Eric Seidel.
- Scripts/mark-bug-fixed:
(MarkBugFixed.init): Added -uupdate-only switch to list of parse options.
(MarkBugFixed.main): When -uupdate-only is specified, add a comment to the bug without marking it Resolved/Fixed.
- 3:01 PM Changeset in webkit [48771] by
-
- 3 edits4 adds in trunk
2009-09-25 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Crash with hardware accelerated rotation of a PDF image in a data URL
<rdar://problem/7250378>
PDF images don't return a color space from CGImageGetColorSpace(),
so we need to null-check the return value before use.
Test: compositing/color-matching/pdf-image-match.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
- 2:40 PM Changeset in webkit [48770] by
-
- 2 edits in trunk/WebKit/win
Speed up access to history items by caching date computation.
Patch by Darin Adler <Darin Adler> on 2009-09-25
Reviewed by Steve Falkenburg.
- History/WebHistory.mm:
(getDayBoundaries): Refactored from timeIntervalForBeginningOfDay.
Returns the beginning of the day that the passed time is within and
the beginning of the next day.
(beginningOfDay): Added. Uses getDayBoundaries so it can be fast for
multiple dates within the same day, which is the common case.
(dateKey): Added. Calls beginningOfDay and converts to an integer.
(WebHistory::findKey): Changed to call dateKey instead of
timeIntervalForBeginningOfDay.
- 2:08 PM Changeset in webkit [48769] by
-
- 8 edits1 copy5 adds in trunk
Null-deref when first access to an Attr node is after its Element is destroyed
https://bugs.webkit.org/show_bug.cgi?id=29748
Patch by Darin Adler <Darin Adler> on 2009-09-25
Reviewed by Geoffrey Garen.
WebCore:
Test: fast/dom/Attr/access-after-element-destruction.html
- bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::markChildren): Added. Keeps the ownerElement alive as
long as the Attr is alive.
- bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::markChildren): Added. Keeps the Element alive as
long as the NamedNodeMap is alive.
- dom/Attr.idl: Added CustomMarkFunction attribute.
- dom/NamedAttrMap.cpp:
(WebCore::NamedNodeMap::getAttributeItem): Tweaked formatting.
(WebCore::NamedNodeMap::detachFromElement): Call clearAttributes so we don't
have attributes hanging around that might need an Attr node created; that way
we won't crash with a null-dereference trying to deal with one of them. This
can't happen when working with JavaScript since the Element will be kept
alive due to the change above.
(WebCore::NamedNodeMap::addAttribute): Fix function name in comment.
(WebCore::NamedNodeMap::removeAttribute): Removed unneeded "+ 1" and added
missing braces.
- dom/NamedAttrMap.h: Made the element function public so it can be used by
the JavaScript binding to keep the Element alive.
- dom/NamedNodeMap.idl: Added CustomMarkFunction attribute.
LayoutTests:
- fast/dom/Attr/access-after-element-destruction-expected.txt: Added.
- fast/dom/Attr/access-after-element-destruction.html: Added.
- fast/dom/Attr/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Node/script-tests/TEMPLATE.html.
- fast/dom/Attr/script-tests/access-after-element-destruction.js: Added.
- 2:07 PM Changeset in webkit [48768] by
-
- 2 edits in trunk/WebKitTools
- Scripts/prepare-ChangeLog: Leave files from the script-tests directory
out, just as we do for the resources directory.
Reviewed by Geoffrey Garen.
- 1:44 PM Changeset in webkit [48767] by
-
- 30 edits10 adds in trunk
Reviewed by Darin Adler and Sam Weinig.
Onclick not fired for an element copied with cloneContents() or cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=25130
The change here is that JS event listeners don't keep a reference to a global object from
where they were created, and instead take it as a parameter when parsing source code. Also,
the listener creation won't fail just because it happens for an element in a frameless
document.
Thus, moving nodes between documents no longer results in having incorrect registered
lazy event listeners on them.
Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html
fast/events/attribute-listener-cloned-from-frameless-doc-context.html
fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
fast/events/attribute-listener-extracted-from-frameless-doc-context.html
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject. (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner. (WebCore::JSEventListener::markJSFunction): Don't mark the global object. (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext. (WebCore::JSEventListener::reportError): Ditto.
- bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference to JSDOMGlobalObject.
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener creation was split between this function and ScriptEventListener; moved it here, as JS global object can be different now.
- bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL, which can not be determined at parsing time.
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests expect that errors are logged at document parsing time, and because I don't know what other side effects moving it vould have.
- dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext, because JSC needs a global context here.
- bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener):
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSEventSourceCustom.cpp: (WebCore::JSEventSource::addEventListener): (WebCore::JSEventSource::removeEventListener):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/objc/ObjCEventListener.h:
- bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
- inspector/InspectorDOMStorageResource.h:
- loader/ImageDocument.cpp: (WebCore::ImageEventListener::handleEvent):
- svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::handleEvent):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException): Don't pass global object to JSEventListener::create(), which no longer needs it. Note that some of these functions still have an early return for null global object, which can probably be removed in a later patch. Pass ScriptExecutionContext to EventListener methods that now need it.
- 1:24 PM Changeset in webkit [48766] by
-
- 1 edit1 add in trunk/LayoutTests
Checked in a file that was created by make-script-test-wrappers.
Patch by Darin Adler <Darin Adler> on 2009-09-25
- platform/gtk/editing/pasteboard/middle-click-onpaste.html: Added.
- 1:00 PM Changeset in webkit [48765] by
-
- 2 edits in trunk/WebKitTools
2009-09-25 Adam Barth <abarth@webkit.org>
Unreviewed. Added Tony to committers.py because he's a
committer now.
- Scripts/modules/committers.py:
- 11:55 AM Changeset in webkit [48764] by
-
- 5 edits2 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29740
<rdar://problem/7168738> Gmail: After changing a foreground text color, pressing return doesn't apply background to new line
Patch by Enrica Casucci <enrica@apple.com> on 2009-09-25
Reviewed by Darin Adler, Dan Bernstein, Adele Peterson, and others.
Change the way style is preserved when inserting a new paragraph.
The original code handled insertion at the beginning and at the end of a paragraph as special
cases. The newly created paragraph contained a set of nodes generated starting from the
computed style of the insertion node. This approach has two problems:
- if the insertion node has a non opaque background color and one of the parent element did have
a solid background color the new paragraph did not have the element with the solid color in the tree.
- in some circumstances it generated more markup than the original paragraph had (a span with bold, italic,
background color and some font attribute was being reproduced as span + bold + italic + font as separate tags.
The new approach is to recreate in the new paragraph the same hierarchy of nodes found in the
paragraph where the insertion point is.
Test: editing/inserting/insert-bg-font.html
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock): retrieves the list of all the ancestors
between the insert node and the outer block.
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock): uses the list of ancestors to recreate
in the new paragraph the same element hierarchy present in the starting paragraph.
(WebCore::InsertParagraphSeparatorCommand::doApply): changed the code to handle the general case of insertion
in the middle of the paragraph to use the new methods. Changed the handling of the insertion at the beginning and
at the end of the paragraph to use the new methods instead of applying the calculated style.
- editing/InsertParagraphSeparatorCommand.h: added methods getAncestorsInsideBlock and cloneHierarchyUnderNewBlock.
LayoutTests: Updated the expected results to reflect the changes in the way the new paragraph
is created and added test case for https://bugs.webkit.org/show_bug.cgi?id=29740
<rdar://problem/7168738> Gmail: After changing a foreground text color, pressing return doesn't apply background to new line
Patch by Enrica Casucci <enrica@apple.com> on 2009-09-25
Reviewed by Darin Adler, Dan Bernstein, Adele Peterson, and others.
- editing/inserting/insert-bg-font.html: Added.
- platform/mac/editing/inserting/insert-bg-font-expected.txt: Added.
- platform/mac/editing/pasteboard/5478250-expected.txt:
- 11:36 AM Changeset in webkit [48763] by
-
- 4 edits in trunk/WebCore
2009-09-25 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Content-type parameters not taken into account when building form-data
https://bugs.webkit.org/show_bug.cgi?id=28970
existing manual test case extended with new tests
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshFormData): (WebInspector.ResourceView.prototype._refreshParms):
- manual-tests/inspector/display-form-data.html:
- 11:27 AM Changeset in webkit [48762] by
-
- 5 edits in trunk/WebKitTools
2009-09-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should auto-retry patches which fail to commit due to out of date files
https://bugs.webkit.org/show_bug.cgi?id=28316
- Scripts/bugzilla-tool:
- Handle new CheckoutNeedsUpdate exception.
- Scripts/modules/logging_unittest.py:
- Call the ScriptError constructor correctly (this test had regressed).
- Scripts/modules/scm.py:
- Added the ability to define custom error handlers for run_command and added a commit_error_handler which throws CheckoutNeedsUpdate instead of ScriptError.
- Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
- Scripts/modules/scm_unittest.py:
- Added tests of new error handlers.
- 10:53 AM Changeset in webkit [48761] by
-
- 6 edits4 adds in trunk
2009-09-25 Yuan Song <song.yuan@ericsson.com>
Reviewed by Darin Adler.
Add test "invalid-domain-change-throws-exception.html" to ensure a SECURITY_ERR exception is raised if an attempt is made to change document.domain to an invalid value. In the existing test case "basic-textareas.html", fix the faulty behavior of setting document.domain to invalid value, and replace the data URL to a file URL that points to "basic-textareas-standards.html" in order to make "basic-textareas.html" runnable in a browser.
- fast/forms/basic-textareas.html:
- fast/forms/resources/basic-textareas-standards.html: Added.
- fast/js/invalid-domain-change-throws-exception-expected.txt: Added.
- fast/js/invalid-domain-change-throws-exception.html: Added.
- fast/js/resources/invalid-domain-change-throws-exception.js: Added.
2009-09-25 Yuan Song <song.yuan@ericsson.com>
Reviewed by Darin Adler.
Raise SECURITY_ERR exception if an attempt is made to change document.domain to an invalid value.
Test: fast/js/invalid-domain-change-throws-exception.html
- dom/Document.cpp: (WebCore::Document::setDomain):
- dom/Document.h:
- dom/Document.idl:
- 10:40 AM Changeset in webkit [48760] by
-
- 3 edits in trunk/WebKitTools
2009-09-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should give better feedback when failing a patch
https://bugs.webkit.org/show_bug.cgi?id=29316
- Scripts/bugzilla-tool:
- Update ScriptError uses to the new constructor format.
- Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output so that we can print to both stdout as well as an output buffer for error reporting.
- Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
- Use e.message_with_output() when failing a patch (this is the real fix here). I also removed use of "This patch will require manual commit." as that's not always true.
- Add missing word "bug" from log message.
- Scripts/modules/scm.py:
- Make ScriptError save a bunch more data so that error messages can be nicer.
- Update ScriptError callers.
- 10:31 AM BuildingOnWindows edited by
- Changed title of subsection to reflect fix for linker problems (diff)
- 9:36 AM Changeset in webkit [48759] by
-
- 3 edits2 adds in trunk
2009-09-25 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703
Test a strange error condition after clearing a setInterval
timer. The key point is not to crash on this test.
- fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Added.
- fast/dom/timer-clear-interval-in-handler-and-generate-error.html: Added.
2009-09-25 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703
When setTimeout is called with a string argument in an isolated
world, we now compile the string in the isolated world.
Last time we tried this change, we got a lot of crashes. This
time we're using a fresh local handle as our context to avoid
trouble if the peristent handle gets disposed before we leave
the context.
Test: fast/dom/timer-clear-interval-in-handler-and-generate-error.html
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- 9:30 AM Changeset in webkit [48758] by
-
- 2 edits in trunk/WebKit/qt
2009-09-25 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Make tst_qwebframe work if Qt built without SSL support
https://bugs.webkit.org/show_bug.cgi?id=29735
- tests/qwebframe/tst_qwebframe.cpp: Missing #ifndef blocks added.
- 9:23 AM Changeset in webkit [48757] by
-
- 2 edits in trunk/WebCore
2009-09-25 Paul Godavari <paul@chromium.org>
Reviewed by Darin Fisher.
Fix a regression in Mac Chromium popup menus, where the user's
selection was ignored and the popup became unresponsive.
https://bugs.webkit.org/show_bug.cgi?id=29726
The fix is to notify the popup's client that the popup was hidden,
even if the popup has no parent.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::hidePopup):
- 9:10 AM Changeset in webkit [48756] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-25 Laszlo Gombos <Laszlo Gombos>
Reviewed by Gavin Barraclough.
Add ARM version detection rules for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29715
- wtf/Platform.h:
- 8:47 AM Changeset in webkit [48755] by
-
- 5 edits in trunk/WebCore
2009-09-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Dan Bernstein.
Enable Pasteboard::writePlainText for Chromium and fix code style nits.
https://bugs.webkit.org/show_bug.cgi?id=29734
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writePlainText):
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
- platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writePlainText):
- 8:32 AM Changeset in webkit [48754] by
-
- 4 edits in trunk/WebKit/win
Add SPI to invalidate a WebView's backing store
This is useful in conjunction with
IWebUIDelegatePrivate2::drawBackground. This provides a way for the UI
delegate to force WebView to get its background redrawn.
Fixes <http://webkit.org/b/29737> Need SPI to invalidate a WebView's
backing store
Reviewed by Anders Carlsson.
- Interfaces/IWebViewPrivate.idl: Added invalidateBackingStore.
- WebView.cpp:
(WebView::invalidateBackingStore): If rect is 0, invalidate our whole
client rect. Otherwise invalidate the intersection of rect with our
client rect.
- WebView.h:
- 7:01 AM Changeset in webkit [48753] by
-
- 4 edits in trunk/WebKit/gtk
2009-09-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Pop down the context menu when the page transitions to committed,
to avoid keeping a context menu out of context.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (destroy_menu_cb): (webkit_web_view_forward_context_menu_event):
- 1:54 AM Changeset in webkit [48752] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28876
[Qt] reduce peak memory consumption of text decoding.
Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-09-25
Reviewed by Ariya Hidayat.
Chop large input buffer into small buffers to reduce peak memory
during decoding.
- platform/text/qt/TextCodecQt.cpp:
(WebCore::TextCodecQt::decode):
- 1:53 AM Changeset in webkit [48751] by
-
- 4 edits in trunk/WebKit/qt
[Qt] Update QWebElement API to remove script related methods.
QWebElement::evaluateScript is the only one kept, these are
removed to postpone most of the QtWebKit<->JavaScript API design
after 4.6.
https://bugs.webkit.org/show_bug.cgi?id=29708
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-24
Reviewed by Simon Hausmann.
- Api/qwebelement.cpp:
- Api/qwebelement.h:
Methods removed:
- QWebElement::callFunction
- QWebElement::functions
- QWebElement::scriptableProperty
- QWebElement::setScriptableProperty
- QWebElement::scriptableProperties
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::evaluateScript):
- 1:19 AM Changeset in webkit [48750] by
-
- 4 edits in trunk/WebKit/qt
[Qt] Rename QWebElement::evaluateScript
to QWebElement::evaluateJavaScript.
https://bugs.webkit.org/show_bug.cgi?id=29709
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-25
Reviewed by Simon Hausmann.
- Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript):
- Api/qwebelement.h:
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::evaluateJavaScript):
- 1:18 AM Changeset in webkit [48749] by
-
- 5 edits in trunk/WebKit/qt
[Qt] Update the stypeProperty API of QWebElement.
https://bugs.webkit.org/show_bug.cgi?id=29711
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-25
Reviewed by Simon Hausmann.
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- Merge the stypeProperty and the computedStyleProperty methods
- Remove the default value for the style resolving enum
- Rename ResolveRule to StyleResolveStrategy
(QWebElement::setStyleProperty):
- Remove the priority argument since it is possible to control the behaviour by adding !important or removing in the value.
- Api/qwebelement.h:
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::style):
(tst_QWebElement::computedStyle):
- tests/qwebframe/tst_qwebframe.cpp:
Sep 24, 2009:
- 11:53 PM Changeset in webkit [48748] by
-
- 30 edits7 adds in trunk
Add a mechanism for automatically halting plug-ins.
Reviewed by Oliver Hunt and Alice Liu.
WebCore:
- GNUmakefile.am:
- WebCore.base.exp:
Update export of Page constructor.
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
Add PluginHalter.{h,cpp}, PluginHalterClient.h, and
HaltablePlugin.h.
- WebCore.xcodeproj/project.pbxproj:
Add files to Mac project.
- loader/EmptyClients.h:
Added an empty PluginHalterClient.
(WebCore::EmptyPluginHalterClient::shouldHaltPlugin):
Return false.
- page/PluginHalter.cpp: Added.
(WebCore::PluginHalter::PluginHalter):
(WebCore::PluginHalter::didStartPlugin):
Add the object to the plug-in set. If this is the only item in the set,
set m_oldestStartTime to this object's time, and start the timer.
(WebCore::PluginHalter::didStopPlugin):
Remove the plug-in from the set.
(WebCore::PluginHalter::timerFired):
Find the cut-off time as the current time minus the allowed run time;
plug-ins older than this may be halted. Iterate over the plug-ins. Find
the object with the oldest start time that is too young to be halted;
we'll use its start time to set the timer's next fire time. For all
plug-ins that are candidates to be halted, call the
PluginHalterClient's shouldHaltPlugin(). If this function returns true,
call the plug-in's halt() function. Remove these objects from the set
of tracked plug-ins. Call startTimerIfNecessary() to restart the timer.
(WebCore::PluginHalter::startTimerIfNecessary):
If the timer is set to fire, or the set of tracked plug-ins is empty,
return early. Set the timer to fire after the oldest plug-in has run
for the allowed run time.
- page/PluginHalter.h: Added.
(WebCore::PluginHalter::setPluginAllowedRunTime):
- page/PluginHalterClient.h: Added.
(WebCore::PluginHalterClient::~PluginHalterClient)
- page/Page.cpp:
(WebCore::Page::Page):
Initialize m_pluginHalterClient. Call pluginHalterEnabledStateChanged()
to create the PluginHalter if necessary.
(WebCore::Page::pluginHalterEnabledStateChanged):
If plug-in halting is enabled, create the PluginHalter. If it is
disabled, clear it.
(WebCore::Page::pluginAllowedRunTimeChanged):
If there is a plug-in halter, call its setPluginAllowedRunTime().
(WebCore::Page::didStartPlugin):
If there is a plug-in halter, call its didStartPlugin().
(WebCore::Page::didStopPlugin):
If there is a plug-in halter, call its didStopPlugin().
- page/Page.h:
Add a parameter to the Page constructor for the PluginHalterClient.
Added declarations for didStartPlugin() and didStopPlugin(), which are
called when HaltablePlugins are added to or removed from the page. Adds
pluginAllowedRunTimeChanged() and pluginHalterEnabledStateChanged() to
notify the Page when these settings are changed. Added members to hold
the PluginHalter and the PluginHalterClient.
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setPluginHalterEnabled):
If the enabled state has changed, call the Page's
pluginHalterEnabledStateChanged().
(WebCore::Settings::setPluginAllowedRunTime):
Call the Page's pluginAllowedRunTimeChanged().
- page/Settings.h:
(WebCore::Settings::pluginHalterEnabled):
(WebCore::Settings::pluginAllowedRunTime):
- page/HaltablePlugin.h: Added. Defines an interface for plug-ins that
can be automatically halted.
(WebCore::HaltablePlugin::~HaltablePlugin)
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
Pass a dummy PluginHalterClient.
WebKit/gtk/:
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
Pass 0 for new Page constructor argument.
WebKit/mac/:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
Pass 0 for new Page constructor argument.
WebKit/qt/:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
Pass 0 for new Page constructor argument.
WebKit/win:
- Interfaces/IWebPluginHalterDelegate.idl: Added. Defines an interface
for a delegate that determines whether plug-ins should be halted.
- Interfaces/IWebPreferencesPrivate.idl:
Declare functions to get and set the enabled state of the plug-in
halter and the plug-in allowed run time.
- Interfaces/IWebViewPrivate.idl:
Declare functions to get and set the IWebPluginHalterDelegate.
- Interfaces/WebKit.idl:
- WebCoreSupport/WebPluginHalterClient.cpp: Added.
(WebPluginHalterClient::WebPluginHalterClient):
(WebPluginHalterClient::shouldHaltPlugin):
Get the IWebPluginHalterDelegate for the WebView. Create a WebKit
DOMNode for the WebCore Node. Call the delegate's shouldHaltPlugin().
If the call fails, return false. Otherwise, return the result of the
call.
- WebCoreSupport/WebPluginHalterClient.h: Added.
- WebKit.vcproj/Interfaces.vcproj:
Add IWebPluginHalterDelegate.idl.
- WebKit.vcproj/WebKit.vcproj:
Add WebPluginHalterClient.{h,cpp}.
- WebPreferenceKeysPrivate.h:
Define WebKitPluginHalterEnabledPreferenceKey and
WebKitPluginAllowedRunTimePreferenceKey.
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
Leave plug-in halting disabled by default. Set the default value for
the plug-in allowed run time to the max value of an unsigned int.
(WebPreferences::setPluginHalterEnabled):
(WebPreferences::pluginHalterEnabled):
(WebPreferences::setPluginAllowedRunTime):
(WebPreferences::pluginAllowedRunTime):
- WebPreferences.h:
- WebView.cpp:
(WebView::close):
Clear the IWebPluginHalterDelegate.
(WebView::initWithFrame):
Pass a WebPluginHalterClient when creating the Page.
(WebView::notifyPreferencesChanged):
Set the new settings when the preferences changed notification is
received.
(WebView::setPluginHalterDelegate):
(WebView::pluginHalterDelegate):
- WebView.h:
Declare overrides of setPluginHalterDelegate() and
pluginHalterDelegate(). Added a member to track the
IWebPluginHalterDelegate.
- 11:26 PM Changeset in webkit [48747] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark "Do It!" Rowe.
Some GCC versions don't like C++-style comments in preprocessor
directives, change to C-style to shut them up.
- wtf/Platform.h:
- 8:53 PM Changeset in webkit [48746] by
-
- 3 edits4 adds in trunk
2009-09-24 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
REGRESSION: webkit-transform scale no longer works properly in nightly build
https://bugs.webkit.org/show_bug.cgi?id=29730
When the initial or final state of a scale animation does not specify a transform,
use a default scale of 1, rather than zero.
Test: compositing/transitions/scale-transition-no-start.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::getTransformFunctionValue):
- 7:45 PM Changeset in webkit [48745] by
-
- 21 edits in trunk
WebCore: isEnabled switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930
Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.
Adds a run-time flag in Settings object that controls whether
to expose desktop notifications.
No new test, but test code also modified to set this preference.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitNotifications): check preference before returning notifications object
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setExperimentalNotificationsEnabled):
- page/Settings.h:
(WebCore::Settings::experimentalNotificationsEnabled):
WebKit/mac: isEnabled switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930
Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.
Adds support for the experimentalNotificationsEnabled flag in Settings
through WebPreferencesPrivate.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences experimentalNotificationsEnabled]):
(-[WebPreferences setExperimentalNotificationsEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
WebKit/win: Enable switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930
Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.
Adds support for the experimentalNotificationsEnabled flag in Settings through
WebPreferencesPrivate interface. Also cleans up some issues accessing the
notification delegate through DumpRenderTree.
- Interfaces/IWebPreferencesPrivate.idl:
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::hasNotificationDelegate):
(WebDesktopNotificationsDelegate::notificationDelegate):
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setExperimentalNotificationsEnabled):
(WebPreferences::experimentalNotificationsEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
WebKitTools: Enable switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930
Patch by John Gregg <johnnyg@google.com> on 2009-09-14
Reviewed by Eric Seidel.
Now that desktop notifications are controlled by run-time switch,
set that switch to true for DumpRenderTree.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::QueryInterface):
- 7:40 PM Changeset in webkit [48744] by
-
- 5 edits in trunk/JavaScriptCore
Division is needlessly slow in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=29723
Reviewed by Gavin Barraclough.
Add codegen for op_div on x86-64
- 7:25 PM Changeset in webkit [48743] by
-
- 3 edits2 adds in trunk
WebCore: Fix <rdar://problem/7162000> Crash while trying to
calculate the horizontal position of image
Reviewed by Sam Weinig.
Test: fast/inline-block/relative-positioned-rtl-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Corrected an
isInline() test to isRenderInline(). This is similar to r41259.
LayoutTests: Test for <rdar://problem/7162000> Crash while trying to
calculate the horizontal position of image
Reviewed by Sam Weinig.
- fast/inline-block/relative-positioned-rtl-crash-expected.txt: Added.
- fast/inline-block/relative-positioned-rtl-crash.html: Added.
- 7:16 PM Changeset in webkit [48742] by
-
- 2 edits in trunk/WebCore
Fix expanding profile call stacks being broken after sorting.
https://bugs.webkit.org/show_bug.cgi?id=26423
Patch by Jessie Berlin <jberlin@webkit.org> on 2009-09-24
Reviewed by Timothy Hatcher.
- inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.sort):
Set shouldRefreshChildren to true on collapsed nodes with children so that expanding it
causes the children to be placed in the right positions.
- 6:13 PM Changeset in webkit [48741] by
-
- 4 edits in trunk/WebKitTools
wx build fix. SnowLeopard fixes for Mac dependencies.
- 5:18 PM Changeset in webkit [48740] by
-
- 2 edits in trunk/WebCore
Fixed sudden termination console spew due to too many calls to
enableSuddenTermination.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Reviewed by Stephanie Lewis.
<rdar://problem/7063125> 10A410: Safari logging enableSuddenTermination errors
- page/DOMWindow.cpp:
(WebCore::removeUnloadEventListener):
(WebCore::removeAllUnloadEventListeners):
(WebCore::removeBeforeUnloadEventListener):
(WebCore::removeAllBeforeUnloadEventListeners): Only
enableSuddenTermination if the set of listeners is empty *and* this
window was in the set. Otherwise, a no-op will cause us to enableSuddenTermination.
- 4:44 PM Changeset in webkit [48739] by
-
- 6 edits2 deletes in trunk
2009-09-24 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Alexey Proskuryakov.
WebKit returns "" instead of null when getting
inexistent, forbidden or invalidly named headers.
https://bugs.webkit.org/show_bug.cgi?id=29140
- http/tests/xmlhttprequest/get-dangerous-headers.html: Updated to test for null instead of ""
- http/tests/xmlhttprequest/getResponseHeader-expected.txt:
- http/tests/xmlhttprequest/getResponseHeader.html: Extended to also test for headers that should return null.
- http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html: Removed. getResponseHeader.html now covers this case as well.
2009-09-24 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Alexey Proskuryakov.
WebKit returns "" instead of null when getting
inexistent, forbidden or invalidly named headers.
https://bugs.webkit.org/show_bug.cgi?id=29140
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseHeader): Changed to return null as it should according to the spec.
- 3:34 PM Changeset in webkit [48738] by
-
- 4 edits in trunk
JavaScriptCore: Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29724
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-24
Reviewed by Dimitri Glazkov.
Adding the following files to the svn:ignore list (all in the
JavaScriptCore/JavaScriptCore.gyp directory)
JavaScriptCore.xcodeproj
JavaScriptCore.sln
JavaScriptCore.vcproj
JavaScriptCore_Debug.rules
JavaScriptCore_Release.rules
JavaScriptCore_Release - no tcmalloc.rules
JavaScriptCore_Purify.rules
JavaScriptCore.mk
JavaScriptCore_Debug_rules.mk
JavaScriptCore_Release_rules.mk
JavaScriptCore_Release - no tcmalloc_rules.mk
JavaScriptCore_Purify_rules.mk
JavaScriptCore.scons
JavaScriptCore_main.scons
- JavaScriptCore.gyp: Changed property svn:ignore.
WebCore: Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29724
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-24
Reviewed by Dimitri Glazkov.
Adding the following files to the svn:ignore list (all in the
WebCore/WebCore.gyp directory)
WebCore.xcodeproj
WebCore.sln
WebCore.vcproj
WebCore_Debug.rules
WebCore_Release.rules
WebCore_Release - no tcmalloc.rules
WebCore_Purify.rules
WebCore.mk
WebCore_Debug_rules.mk
WebCore_Release_rules.mk
WebCore_Release - no tcmalloc_rules.mk
WebCore_Purify_rules.mk
WebCore.scons
WebCore_main.scons
- WebCore.gyp: Changed property svn:ignore.
- 3:24 PM Changeset in webkit [48737] by
-
- 2 edits in trunk/WebCore
Unreviewed Mac build fix
- 3:00 PM Changeset in webkit [48736] by
-
- 3 edits in trunk/JavaScriptCore
2009-09-24 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Barth.
Replace platform-dependent code with WTF::currentTime()
https://bugs.webkit.org/show_bug.cgi?id=29148
- jsc.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS):
- runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
- 2:58 PM Changeset in webkit [48735] by
-
- 8 edits3 adds in trunk
Implement correct horizontal scrollbar behavior for GTK+
WebCore
2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Oliver Hunt.
Implement correct horizontal scrollbar behavior for GTK+ also on
styled scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=29348
[Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
Test: platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html
- page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): on GTK+, when using the wheel with the pointer on the horizontal scrollbar, scroll horizontally;
- platform/PlatformWheelEvent.h:
- platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::swapOrientation): allow adding a vertical scroll to the horizontal one;
WebKitTools
2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Oliver Hunt.
Add support for DRT to send mouse wheel events.
https://bugs.webkit.org/show_bug.cgi?id=29348
[Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
- DumpRenderTree/gtk/EventSender.cpp: (mouseWheelToCallback):
LayoutTests
2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Oliver Hunt.
Test for correct wheel scrolling behavior.
https://bugs.webkit.org/show_bug.cgi?id=29348
[Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
- platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html: Added.
- platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll-expected.txt: Added.
- 2:36 PM Changeset in webkit [48734] by
-
- 7 edits in trunk/WebCore
2009-09-24 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Eric Seidel.
StorageNamespace::storageArea() should take in a PassRefPtr<StorageOrigin>
https://bugs.webkit.org/show_bug.cgi?id=29290
Modified StorageNamespace::storageArea() to take in a PassRefPtr<StorageOrigin>
per http://webkit.org/coding/RefPtr.html
No behavior change, so no tests.
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
- storage/StorageNamespaceImpl.h:
- 2:25 PM Changeset in webkit [48733] by
-
- 4 edits in trunk/JavaScriptCore
<rdar://problem/7215058> FastMalloc scavenging thread should be named
Reviewed by Sam Weinig.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavengerThread): Set the thread name.
- wtf/Platform.h: Move the knowledge of whether pthread_setname_np exists to here as HAVE(PTHREAD_SETNAME_NP).
- wtf/ThreadingPthreads.cpp:
(WTF::setThreadNameInternal): Use HAVE(PTHREAD_SETNAME_NP).
- 2:18 PM Changeset in webkit [48732] by
-
- 4 edits in trunk
JavaScriptCore: Renamed clear to removeAll, as suggested by Darin Adler.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Reviewed by Sam Weinig.
- wtf/HashCountedSet.h:
(WTF::::removeAll):
WebCore: Added back enable/disableSuddenTermination() functionality I accidentally
removed in my last patch.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Reviewed by Sam Weinig.
- page/DOMWindow.cpp:
(WebCore::addUnloadEventListener):
(WebCore::removeUnloadEventListener):
(WebCore::removeAllUnloadEventListeners):
(WebCore::addBeforeUnloadEventListener):
(WebCore::removeBeforeUnloadEventListener):
(WebCore::removeAllBeforeUnloadEventListeners):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):
- 2:15 PM Changeset in webkit [48731] by
-
- 3 edits in trunk/JavaScriptCore
Fix FastMalloc to build with assertions enabled.
Reviewed by Gavin Barraclough.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::ReleaseToSpans):
- wtf/TCSpinLock.h:
(TCMalloc_SpinLock::IsHeld):
- 1:40 PM Changeset in webkit [48730] by
-
- 2 edits12 adds in trunk/WebKitTools
2009-09-17 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
commit-queue needs web-based status reporting
https://bugs.webkit.org/show_bug.cgi?id=29307
Add a first-pass web-based status for the commit-queue.
The bot is currently reachable at:
http://webkit-commit-queue.appspot.com/
- CommitQueueStatus/app.yaml: Added.
- Application description file required by App Engine.
- CommitQueueStatus/filters/init.py: Added.
- Required by python to treat 'filters' as a module.
- CommitQueueStatus/filters/webkit_extras.py: Added.
- Support for turning 'bug 123' and 'patch 123' into links. This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
- CommitQueueStatus/index.html: Added.
- CommitQueueStatus/index.yaml: Added.
- Some auto-generated file from app engine.
- CommitQueueStatus/queue_status.py: Added.
- The core logic of this bot. We could eventually split this file out into pieces.
- CommitQueueStatus/stylesheets/main.css: Added.
- Some basic lame-o CSS to make the page look less awful.
- CommitQueueStatus/update_status.html: Added.
- The form that the commit-queue (or a human) can use to update the status.
- Scripts/bugzilla-tool:
- Add some very basic update_status calls.
- Scripts/modules/statusbot.py: Added.
- Knows how to post to the CommitQueueStatus web application.
- 1:32 PM Changeset in webkit [48729] by
-
- 2 edits in trunk/WebCore
Don't pass -F to GCC on non-mac platforms since it is an darwin only.
Reviewed by Steve Falkenburg and Mark Rowe.
- DerivedSources.make:
- 12:42 PM Changeset in webkit [48728] by
-
- 2 edits in trunk/WebCore
Fix windows build.
- dom/Element.idl:
- 12:37 PM Changeset in webkit [48727] by
-
- 2 edits in trunk/JavaScriptCore
Suggested by Darin Adler.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
Removed some unnecessary parameter names.
- wtf/HashCountedSet.h:
- 11:51 AM Changeset in webkit [48726] by
-
- 3 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=29696 ([CHROMIUM] Paths fail to render in SVG with large viewbox)
Revert the relevant parts of r47925, and implement an alternate
fix (localize the coordinate check to GraphicsContext::clipPath()).
See http://crbug.com/21174.
Reviewed by Eric Seidel.
Covered by LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clipPath):
- platform/graphics/skia/PlatformContextSkia.cpp:
(PlatformContextSkia::currentPathInLocalCoordinates):
- 11:18 AM Changeset in webkit [48725] by
-
- 2 edits in trunk/WebCore
Merge changes from Mozilla's FTP directory parser.
<rdar://problem/7227620> and https://bugs.webkit.org/show_bug.cgi?id=29294
Reviewed by Sam Weinig.
FTP layout tests not possible at this time.
https://bugs.webkit.org/show_bug.cgi?id=29719 tracks making them possible.
- loader/FTPDirectoryParser.cpp:
(WebCore::ParsingFailed):
(WebCore::parseOneFTPLine):
- 10:55 AM Changeset in webkit [48724] by
-
- 4 edits in trunk
WebCore
2009-09-24 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] re-enable some media tests
https://bugs.webkit.org/show_bug.cgi?id=29716
make canPlayType() return "probably" if mime-type is known
and codecs string is not empty. If codecs is empty return
"maybe".
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::supportsType):
LayoutTests
2009-09-24 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] re-enable some media tests
https://bugs.webkit.org/show_bug.cgi?id=29716
- platform/gtk/Skipped:
- 10:47 AM Changeset in webkit [48723] by
-
- 29 edits in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29703
Add a function to element to check whether it matches a CSS selector
Reviewed by Dan Bernstein.
Implement Element.webkitMatchesSelector.
- css/CSSSelectorList.cpp:
(WebCore::forEachTagSelector):
(WebCore::forEachSelector):
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
(WebCore::CSSSelectorList::selectorsNeedNamespaceResolution):
- css/CSSSelectorList.h:
Moved code to iterate the CSSSelectorList and determine if any
selectors need namespace resolution from a static function in
Node.cpp to CSSSelectorList so that it can be used by webkitMatchesSelector
as well as querySelector/querySelectorAll.
- dom/Element.cpp:
(WebCore::Element::webkitMatchesSelector):
- dom/Element.h:
- dom/Element.idl:
Implement the new function. Handles exceptional cases identically to
querySelector/querySelectorAll.
- dom/Node.cpp:
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
Moved selectorsNeedNamespaceResolution to CSSSelectorList from here.
LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=29703
Add a function to element to check whether it matches a CSS selector
Reviewed by Dan Bernstein.
Add webkitMatchesSelector to SelectorAPI tests.
- fast/dom/SelectorAPI/caseID-almost-strict-expected.txt:
- fast/dom/SelectorAPI/caseID-almost-strict.html:
- fast/dom/SelectorAPI/caseID-expected.txt:
- fast/dom/SelectorAPI/caseID-strict-expected.txt:
- fast/dom/SelectorAPI/caseID-strict.html:
- fast/dom/SelectorAPI/caseID.html:
- fast/dom/SelectorAPI/caseTag-expected.txt:
- fast/dom/SelectorAPI/caseTag.html:
- fast/dom/SelectorAPI/caseTagX-expected.txt:
- fast/dom/SelectorAPI/caseTagX.xhtml:
- fast/dom/SelectorAPI/detached-element-expected.txt:
- fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
- fast/dom/SelectorAPI/not-supported-namespace-in-selector.html:
- fast/dom/SelectorAPI/script-tests/detached-element.js:
- fast/dom/SelectorAPI/script-tests/undefined-null-stringify.js:
- fast/dom/SelectorAPI/script-tests/viewless-document.js:
- fast/dom/SelectorAPI/undefined-null-stringify-expected.txt:
- fast/dom/SelectorAPI/viewless-document-expected.txt:
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/script-tests/domListEnumeration.js:
- 10:14 AM Changeset in webkit [48722] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/29712> mark-bug-fixed: add -mcomment switch Reviewed by Adam Roben.
- Scripts/mark-bug-fixed:
(MarkBugFixed.init): Added -mcomment switch to list of parse options.
(MarkBugFixed.main): When specified, prepend comment from
-mcomment command-line switch to the bug comment. - 7:15 AM Changeset in webkit [48721] by
-
- 2 edits in trunk/WebKitTools
2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Jan Alonzo.
[GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
https://bugs.webkit.org/show_bug.cgi?id=29693
Show the window, to be able to synthesize events correctly.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): (main):
- 7:11 AM Changeset in webkit [48720] by
-
- 11 edits in trunk/WebCore
2009-09-24 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fixed bindings build after http://trac.webkit.org/changeset/48701
https://bugs.webkit.org/show_bug.cgi?id=29713
Got rid of isWindowEvent in function signatures:
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::getReceiverObject):
- bindings/v8/V8AbstractEventListener.h:
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::callListenerFunction):
- bindings/v8/V8LazyEventListener.h:
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent): (WebCore::V8WorkerContextEventListener::callListenerFunction): (WebCore::V8WorkerContextEventListener::getReceiverObject):
- bindings/v8/V8WorkerContextEventListener.h:
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::callListenerFunction):
- bindings/v8/custom/V8CustomEventListener.h:
Switched to EventTarget methods of adding/removing listeners:
- bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: (WebCore::toEventID): (WebCore::ACCESSOR_SETTER):
- dom/EventTarget.h: Some functions were incorrectly marked as JSC-specific.
- 5:54 AM Changeset in webkit [48719] by
-
- 4 edits in trunk/WebKit/gtk
2009-09-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha and Jan Alonzo.
[GTK] Add WEBKIT_LOAD_ERROR status
https://bugs.webkit.org/show_bug.cgi?id=29644
Add a new load-status enum value, WEBKIT_LOAD_FAILED, emitted when
there's an error during the load process. This is needed if we
want notify::load-status to be able to handle all situations,
since WEBKIT_LOAD_FINISHED is not emitted when there's an error
and we are lacking a notification of the load being stopped.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
- tests/testloading.c: (web_loading_fixture_setup): (load_error_status_changed_cb): (load_error_cb): (test_loading_error): (load_cancelled_cb): (stop_load): (load_cancelled_status_changed_cb): (test_loading_cancelled): (main):
- webkit/webkitwebframe.h:
- 5:00 AM Changeset in webkit [48718] by
-
- 3 edits in trunk/WebCore
2009-09-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Color-code watch expression errors with red.
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.update):
- inspector/front-end/inspector.css:
- 4:57 AM Changeset in webkit [48717] by
-
- 5 edits in trunk/WebCore
2009-09-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fix formatting for messages derived from resource warnings,
couple of drive-by formatting fixes.
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole):
- inspector/front-end/ConsoleView.js:
- inspector/front-end/InjectedScript.js: (InjectedScript._evaluateAndWrap):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
- 4:45 AM Changeset in webkit [48716] by
-
- 5 edits in trunk/WebCore
2009-09-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Implement InspectorController::copyNode(id).
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::copyNode):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.handleCopyEvent):
- 3:55 AM Changeset in webkit [48715] by
-
- 8 edits in trunk
Roll out r48712 as it is incorrect.
Reviewed by NOBODY(rollout)
- 3:52 AM Changeset in webkit [48714] by
-
- 6 edits in trunk
Revert r48697, since it broke key handling notification to GTK+.
- 3:49 AM Changeset in webkit [48713] by
-
- 2 edits in trunk/WebCore
2009-09-24 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] GStreamer MediaPlayer is unable to correctly querry duration
https://bugs.webkit.org/show_bug.cgi?id=24639
check duration returned by gst_element_query_duration() only
when using GStreamer < 0.10.23.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):
- 3:42 AM Changeset in webkit [48712] by
-
- 8 edits in trunk
2009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Eric Seidel.
The indices of RuntimeArray should be enumerated like for a regular array.
https://bugs.webkit.org/show_bug.cgi?id=29005
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc.html:
2009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Eric Seidel.
The indices of RuntimeArray should be enumerated like for a regular array.
https://bugs.webkit.org/show_bug.cgi?id=29005
- bridge/runtime_array.cpp: (JSC::RuntimeArray::getPropertyNames):
- bridge/runtime_array.h:
2009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=29005
The indices of RuntimeArray should be enumerated like for a regular array.
- DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController arrayOfString]):
- 3:12 AM Changeset in webkit [48711] by
-
- 2 edits in trunk/JavaScriptCore
On Windows JSChar is typedef'ed to wchar_t.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-24
Reviewed by Simon Hausmann.
When building with WINSCW for Symbian we need to do the
same typedef.
- API/JSStringRef.h:
- 2:38 AM Changeset in webkit [48710] by
-
- 12 edits in trunk/WebCore
2009-09-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Eric Seidel.
Introduce Pasteboard::writePlaintext(const String&) so that copying
of the inspected elements HTML will be possible in WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=29634
- platform/Pasteboard.h:
- platform/android/TemporaryLinkStubs.cpp: (Pasteboard::writePlainText):
- platform/chromium/ChromiumBridge.h:
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writePlainText):
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writePlainText):
- platform/haiku/PasteboardHaiku.cpp: (WebCore::Pasteboard::writePlainText):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writePlainText):
- platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writePlainText):
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText):
- platform/wince/PasteboardWince.cpp: (WebCore::Pasteboard::writePlainText):
- platform/wx/PasteboardWx.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
- 1:11 AM Changeset in webkit [48709] by
-
- 2 edits in trunk/WebCore
Fix QApp::translate() calls to provide the correct class name without
a trailing comma.
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2009-09-24
Reviewed by Simon Hausmann.
- platform/qt/Localizations.cpp:
(WebCore::localizedMediaTimeDescription):
- 1:11 AM Changeset in webkit [48708] by
-
- 2 edits in trunk/WebKit/qt
qdoc: Added \brief texts to all the since 4.6 functions.
Patch by Martin Smith <msmith@trolltech.com> on 2009-09-24
Reviewed by Simon Hausmann.
- Api/qwebhistory.cpp:
- 12:20 AM Changeset in webkit [48707] by
-
- 5 edits in trunk/WebCore
More build fix: Removed JSSharedWorkerContextCustom.cpp from project
files, since it no longer exists in the repository.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 12:15 AM Changeset in webkit [48706] by
-
- 2 edits in trunk/WebCore
Windows build fix: Declare set/unsetPendingActivity public, so
SharedWorkerScriptLoader can call them.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
- dom/ActiveDOMObject.h:
- 12:12 AM Changeset in webkit [48705] by
-
- 3 edits in trunk/WebCore
Fixed a bit of the Windows build.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-24
- workers/SharedWorker.idl: Declare a custom mark function. (I accidentally
removed this in my last patch.)
- WebCore.xcodeproj/project.pbxproj: Added JSSharedWorkerCustom.cpp back
to the build. (I accidentally removed this in my last patch.)
