Timeline
Mar 28, 2010:
- 9:11 PM Changeset in webkit [56706] by
-
- 2 edits in trunk/WebKit/chromium
Build fix. Removed extraneous includes of KeyboardCodesWin.h and KeyboardCodesPosix.h -
these no longer exist, but they weren't needed even before reshuffling KeyboardCodes headers.
- 8:53 PM Changeset in webkit [56705] by
-
- 10 edits in trunk/WebKit
Build fix. Include WindowsKeyboardCodes.h instead of KeyboardCodes.h.
- 8:41 PM Changeset in webkit [56704] by
-
- 13 edits1 move1 add5 deletes in trunk/WebCore
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=36733
Use a common header for Windows virtual key codes on all platforms
No change in functionality, so no new tests.
- platform/WindowsKeyboardCodes.h: Added. Define VK_* key codes as macros, matching Windows.
- platform/KeyboardCodes.h: Removed.
- platform/android/KeyboardCodes.h: Removed.
- platform/chromium/KeyboardCodesPosix.h: Removed.
- platform/chromium/KeyboardCodesWin.h: Removed.
- platform/haiku/KeyboardCodes.h: Removed.
- platform/wx/KeyboardCodes.h: Removed. Removed platform specific attempts to do the same thing. In fact, platform/KeyboardCodes.h was supposed to be cross-platform, but it didn't have a sufficiently descriptive name, and its name was the same as platform-specific versions, so I chose a new one.
- platform/chromium/KeyboardCodes.h: Copied from WebCore/platform/chromium/KeyboardCodesWin.h. Chromium redefines Windows constants to different names; keeping the header doing that to avoid breaking Chromium code.
- GNUmakefile.am:
- WebCore.gypi: Replaced KeyboardCodes.h with WindowsKeyboardCodes.h.
- WebCore.xcodeproj/project.pbxproj:
- platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForKeyCode): (WebCore::windowsKeyCodeForCharCode): Mac used to hardcode the key codes; changed to use VK_* macros.
- config.h: Removed a hack to include KeyboardCodes.h, it shouldn't be necessary any more.
- platform/android/KeyEventAndroid.cpp:
- platform/brew/PlatformKeyboardEventBrew.cpp:
- platform/efl/PlatformKeyboardEventEfl.cpp:
- platform/gtk/KeyEventGtk.cpp:
- platform/haiku/PlatformKeyboardEventHaiku.cpp:
- platform/qt/PlatformKeyboardEventQt.cpp:
- platform/wx/KeyboardEventWx.cpp: Changed to include WindowsKeyboardCodes.h.
- 3:48 PM Changeset in webkit [56703] by
-
- 2 edits in trunk/LayoutTests
2010-03-28 Gustavo Noronha Silva <Gustavo Noronha Silva>
[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454
Skip tests that need more load notifications than we provide in
our DRT currently.
- platform/gtk/Skipped:
- 3:36 PM Changeset in webkit [56702] by
-
- 2 edits in trunk/LayoutTests
2010-03-28 Gustavo Noronha Silva <Gustavo Noronha Silva>
Skipping new tests.
- platform/gtk/Skipped:
- 3:29 PM Changeset in webkit [56701] by
-
- 2 edits in trunk/WebKitTools
2010-03-28 Gustavo Noronha Silva <Gustavo Noronha Silva>
No review, rolling out r56679.
http://trac.webkit.org/changeset/56679
https://bugs.webkit.org/show_bug.cgi?id=36454
Lots of tests broken.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView):
- 2:41 PM Changeset in webkit [56700] by
-
- 4 edits in trunk
2010-03-28 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Remove the definition of WTF_CHANGES guards from the build system
https://bugs.webkit.org/show_bug.cgi?id=31670
- JavaScriptCore.pro: Remove the definition of WTF_CHANGES as it is already defined in config.h
2010-03-28 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Remove the definition of WTF_CHANGES guards from the build system
https://bugs.webkit.org/show_bug.cgi?id=31670
No new tests as there is no new functionality.
- WebCore.pri: Remove the definition of WTF_CHANGES as it is already defined in config.h
- 1:00 PM QtWebKitJournal edited by
- (diff)
- 12:19 PM Changeset in webkit [56699] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Fixed typo in deprecated_logging_unittest.py, which is masking
sys.stderr while running test-webkitpy.
See also-- https://bugs.webkit.org/show_bug.cgi?id=36725#c3
- Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
- 10:47 AM Changeset in webkit [56698] by
-
- 2 edits in trunk/WebCore
Clean up the Xcode project a bit.
Reviewed by Dan Bernstein.
- WebCore.xcodeproj/project.pbxproj:
- 10:41 AM Changeset in webkit [56697] by
-
- 6 edits in trunk/WebCore
2010-03-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Toggling style properties on/off does not always work.
- inspector/InspectorController.cpp:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::buildArrayForDisabledStyleProperties):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):
- 10:32 AM Changeset in webkit [56696] by
-
- 3 edits in trunk/WebCore
2010-03-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: resource links should navigate to resource panel enabler when resource tracking is off.
- English.lproj/localizedStrings.js:
- inspector/front-end/inspector.js: (WebInspector.documentMouseOver): (WebInspector.documentClick.followLink): (WebInspector.documentClick):
- 9:59 AM Changeset in webkit [56695] by
-
- 2 edits in trunk/LayoutTests
2010-03-28 Dirk Schulze <krit@webkit.org>
Unreviewed test update for Win.
Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714
May mixed up the win bot with the win-chromium bot.
- platform/win/svg/filters/feColorMatrix-values-expected.txt:
- 9:30 AM Changeset in webkit [56694] by
-
- 6 edits in trunk
2010-03-28 Dirk Schulze <krit@webkit.org>
Unreviewed build-fix for chromium linux.
SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
2010-03-28 Dirk Schulze <krit@webkit.org>
Unreviewed test update.
SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185
Marker results update for Qt port.
- platform/qt/svg/custom/marker-opacity-expected.txt:
- platform/qt/svg/custom/marker-referencePoint-expected.txt:
- platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
- 9:01 AM Changeset in webkit [56693] by
-
- 43 edits2 adds2 deletes in trunk
2010-03-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185
This moves SVGResourceMarker to RenderersSVGResourceMarker. This follows other
SVG resources like masker and clipper and makes DRT results more readable and
adds additonal informations.
Some marker specific code also moved out from RenderSVGViewportContainer to
RenderersSVGResourceMarker.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderPath.cpp: (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::destroy):
- rendering/RenderSVGResource.h: (WebCore::):
- rendering/RenderSVGResourceMarker.cpp: Added. (WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker): (WebCore::RenderSVGResourceMarker::~RenderSVGResourceMarker): (WebCore::RenderSVGResourceMarker::layout): (WebCore::RenderSVGResourceMarker::addClient): (WebCore::RenderSVGResourceMarker::invalidateClients): (WebCore::RenderSVGResourceMarker::invalidateClient): (WebCore::RenderSVGResourceMarker::applyViewportClip): (WebCore::RenderSVGResourceMarker::markerBoundaries): (WebCore::RenderSVGResourceMarker::localToParentTransform): (WebCore::RenderSVGResourceMarker::referencePoint): (WebCore::RenderSVGResourceMarker::angle): (WebCore::RenderSVGResourceMarker::markerTransformation): (WebCore::RenderSVGResourceMarker::draw): (WebCore::RenderSVGResourceMarker::markerContentTransformation): (WebCore::RenderSVGResourceMarker::viewportTransform): (WebCore::RenderSVGResourceMarker::calcViewport):
- rendering/RenderSVGResourceMarker.h: Added. (WebCore::RenderSVGResourceMarker::renderName): (WebCore::RenderSVGResourceMarker::applyResource): (WebCore::RenderSVGResourceMarker::resourceBoundingBox): (WebCore::RenderSVGResourceMarker::markerUnits): (WebCore::RenderSVGResourceMarker::resourceType):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport): (WebCore::RenderSVGViewportContainer::viewportTransform):
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGMarkerData.h: (WebCore::SVGMarkerData::SVGMarkerData): (WebCore::SVGMarkerData::marker): (WebCore::SVGMarkerData::updateTypeAndMarker):
- rendering/SVGMarkerLayoutInfo.cpp: (WebCore::processStartAndMidMarkers): (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker):
- rendering/SVGMarkerLayoutInfo.h: (WebCore::MarkerLayout::MarkerLayout): (WebCore::SVGMarkerLayoutInfo::midMarker):
- rendering/SVGRenderSupport.cpp: (WebCore::deregisterFromResources):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeSVGResource):
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::childrenChanged): (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::createRenderer):
- svg/SVGMarkerElement.h: (WebCore::SVGMarkerElement::):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
- svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isFilter):
- svg/graphics/SVGResourceMarker.cpp: Removed.
- svg/graphics/SVGResourceMarker.h: Removed.
2010-03-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185
DRT results changed after moving SVGResourceMarker and need updates.
- platform/mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-marker-creation-expected.txt:
- platform/mac/svg/custom/marker-changes-expected.txt:
- platform/mac/svg/custom/marker-child-changes-expected.txt:
- platform/mac/svg/custom/marker-default-width-height-expected.txt:
- platform/mac/svg/custom/marker-opacity-expected.txt:
- platform/mac/svg/custom/marker-overflow-clip-expected.txt:
- platform/mac/svg/custom/marker-referencePoint-expected.txt:
- platform/mac/svg/custom/marker-strokeWidth-changes-expected.txt:
- platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
- platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
- platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
- 8:23 AM Changeset in webkit [56692] by
-
- 10 edits in trunk/WebKitTools
Renamed check-webkit-style's --debug flag to --verbose to be more
in line with other WebKit scripts. Also renamed the current
--verbose flag to --min-confidence to allow the --debug rename.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=36521
We also renamed the internal "verbose" variables to "confidence" or
"min_confidence," as appropriate, to avoid confusion with the
--verbose flag, and because the new names are more accurate.
- Scripts/check-webkit-style:
- Renamed is_debug to is_verbose.
- Scripts/webkitpy/style/checker.py:
- Renamed _DEFAULT_VERBOSITY to _DEFAULT_CONFIDENCE.
- Renamed "verbosity" parameters to "min_confidence" throughout.
- Renamed configure_logging()'s is_debug parameter to is_verbose.
- Scripts/webkitpy/style/checker_unittest.py:
- Updated the unit tests as necessary.
- Scripts/webkitpy/style/error_handlers.py:
- Updated the call to StyleCheckerConfiguration.write_style_error().
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Updated the unit tests as necessary.
- Scripts/webkitpy/style/optparser.py:
- Updated the usage string with the new flag names.
- Renamed the verbosity parameter to min_confidence throughout.
- Renamed the is_debug parameter to is_verbose throughout.
- Scripts/webkitpy/style/optparser_unittest.py:
- Updated the unit tests as necessary.
- Scripts/webkitpy/style/processors/cpp.py:
- Renamed the verbosity parameter to min_confidence throughout.
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Updated the unit tests as necessary.
- 8:05 AM Changeset in webkit [56691] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Added back a line that accidentally got deleted in r56690.
- Scripts/check-webkit-style:
- 7:51 AM Changeset in webkit [56690] by
-
- 5 edits in trunk/WebKitTools
Add to check-webkit-style support for checking directories.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=35234
- Scripts/check-webkit-style:
- Replaced the call to check_file() with a call to check_paths().
- Scripts/webkitpy/style/checker.py:
- In the StyleChecker class:
- Added a check_paths() method that accepts a list of paths to files and directories.
- Added a _check_directory() method that checks the files in a directory.
- In the StyleChecker class:
- Scripts/webkitpy/style/checker_unittest.py:
- Added a StyleCheckerCheckPathsTest to unit-test the new check_paths() method.
- Scripts/webkitpy/style/optparser.py:
- Updated the usage string.
- 3:43 AM Changeset in webkit [56689] by
-
- 5 edits in trunk/JavaScriptCore
2010-03-28 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add API for reporting additional memory cost of JavaScript objects
https://bugs.webkit.org/show_bug.cgi?id=36650
- qt/api/qscriptengine.cpp: (QScriptEngine::reportAdditionalMemoryCost):
- qt/api/qscriptengine.h:
- qt/api/qscriptengine_p.h: (QScriptEnginePrivate::reportAdditionalMemoryCost):
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::reportAdditionalMemoryCost):
- 3:33 AM Changeset in webkit [56688] by
-
- 2 edits in trunk/WebCore
2010-03-28 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Consolidate Tree Hierarchy Attribute HTML Generation
https://bugs.webkit.org/show_bug.cgi?id=36719
Consolidates the generation of Element Tree Hierarchy attribute code
generation to a single function: _attributeHTML.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._addNewAttribute): convert to use attributeHTML. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.regenerateStyledAttribute): convert to use attributeHTML. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._attributeHTML): a single point for generating the html for attributes.
- 3:33 AM Changeset in webkit [56687] by
-
- 2 edits in trunk/WebCore
2010-03-28 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481
Ensure blacklisting happens by checking it in _startEditingTagName
instead of all the possible entry points.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): don't check blacklist here. (WebInspector.ElementsTreeElement.prototype._startEditingTagName): check blacklist here.
- 3:03 AM Changeset in webkit [56686] by
-
- 6 edits in trunk/JavaScriptCore
2010-03-28 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
QScriptEngine API was enriched by globalObject() method
which give an access to the global object.
[Qt] QScriptEngine doesn't give an access to global object
https://bugs.webkit.org/show_bug.cgi?id=36603
- qt/api/qscriptengine.cpp: (QScriptEngine::globalObject):
- qt/api/qscriptengine.h:
- qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::globalObject):
- qt/api/qscriptengine_p.h:
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::globalObject):
- 2:46 AM Changeset in webkit [56685] by
-
- 2 edits in trunk/WebCore
2010-03-28 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: Timing functions don't work with transitions
https://bugs.webkit.org/show_bug.cgi?id=36589
If the animation value doesn't have timing function set, we need to
use the animation's timing function.
Fixed also a bug in passing the duration to solveCubicBezierFunction.
The duration was divided two times by 1000 and meanwhile casted to int.
It needs to be kept as double and divided by 1000 only once.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::applyTimingFunction): (WebCore::AnimationQt:::AnimationQtBase): (WebCore::AnimationQt::updateCurrentTime):
- 1:49 AM Changeset in webkit [56684] by
-
- 3 edits in trunk/WebCore
2010-03-27 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481
Allow tabbing back and forth between the tag name and element
attributes when editing. Also, fixed a number of minor issues with
editing attributes and tabbing.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingTagName): find the tag name if it wasn't provided. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): fix tabbing issues, enable tab to tag name. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.regenerateStyledAttribute): cleanup styles when tabbing.
- inspector/front-end/inspector.css: do not display <br>s while editing
- 1:49 AM Changeset in webkit [56683] by
-
- 11 edits in trunk/WebCore
2010-03-27 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481
Allow editing an Element's Tag Name by double clicking
on the tag name in the Element's Tree Hierarchy.
The usual asynchronous InspectorBackend, InspectorDOMAgent, InspectorFrontend flow.
- inspector/InspectorBackend.cpp: moved DOM manipulation to InspectorDOMAgent (WebCore::InspectorBackend::removeNode): (WebCore::InspectorBackend::changeTagName):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::changeTagName):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didChangeTagName):
- inspector/InspectorFrontend.h:
- inspector/front-end/DOMAgent.js:
Handle the UI for editing an Element's tag name.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): allow editing from double click. (WebInspector.ElementsTreeElement.prototype._startEditingTagName.keyupListener): update the closing tag (WebInspector.ElementsTreeElement.prototype._startEditingTagName.editingComitted): remove extra listener and commit (WebInspector.ElementsTreeElement.prototype._startEditingTagName.editingCancelled): remove extra listener and cancel (WebInspector.ElementsTreeElement.prototype._startEditingTagName): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.cancel): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.editTagNameCallback): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted): (WebInspector.ElementsTreeElement.prototype._distinctClosingTagElement): get the closing tag for an opening tag (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo): wrap the tagName in span.webkit-html-tag-name
Miscellaneous updates.
- inspector/front-end/treeoutline.js: fixed a typo.
- 12:54 AM Changeset in webkit [56682] by
-
- 7 edits2 adds in trunk/WebKitTools
Changed check-webkit-style to convert paths to paths relative to
the checkout root when invoking check-webkit-style with path
arguments. Also added warning messages where appropriate.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=35498
Converting paths to paths relative to the checkout root ensures
that style checking will behave as expected (since path-specific
rules assume input paths are relative to a source root).
- Scripts/check-webkit-style:
- Added debug logging of whether the current directory was found to be in a WebKit checkout.
- Added the found_checkout parameter to the call to parser.parse().
- Renamed the files variable to paths.
- Added a call to change_directory() prior to checking style.
- Scripts/webkitpy/style/checker.py:
- For StyleChecker.check_file():
- Updated the docstring.
- Added two log messages.
- For StyleChecker.check_file():
- Scripts/webkitpy/style/checker_unittest.py:
- Updated a call to parser.parse() with the found_checkout parameter.
- Scripts/webkitpy/style/main.py: Added.
- Added a new file so the code in this patch could be unit-tested, as opposed to adding new code to check-webkit-style.
- Added the method _rel_path() as a substitute for os.path.relpath(), which is available only in Python 2.6.
- Added the method change_directory(), which contains most of the new functionality in this patch.
- Scripts/webkitpy/style/main_unittest.py: Added.
- Added RelPathTest to test main._rel_path().
- Added ChangeDirectoryTest to test main.change_directory().
- Scripts/webkitpy/style/optparser.py:
- Updated check-webkit-style's usage string.
- For the ArgumentParser.parse() method:
- Added a found_checkout parameter.
- Renamed filenames to paths.
- Added logic so that an error is raised if no paths are passed if found_checkout is False.
- Scripts/webkitpy/style/optparser_unittest.py:
- Updated the ArgumentParser.parse() unit tests to include coverage for the new found_checkout parameter.
- Scripts/webkitpy/style/unittests.py:
- Added an import statement for main_unittest.
- Scripts/webkitpy/style_references.py:
- Renamed SimpleScm to WebKitCheckout.
- Added a detect_checkout() function to allow returning None instead of a WebKitCheckout instance if no checkout is found.
- Renamed checkout_root to root_path.
Mar 27, 2010:
- 11:09 PM Changeset in webkit [56681] by
-
- 7 edits in trunk
2010-03-27 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Eric Seidel.
Removed 5 http/history tests from Skipped file
[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454
- platform/gtk/Skipped:
2010-03-27 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Eric Seidel.
FrameLoader emits onload-event when handling
dispatchDidHandleOnloadEvents
[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents): implemented, now it emits onload-event signal
- webkit/webkitwebview.cpp: added onload-event signal
2010-03-27 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Eric Seidel.
Print didHandleOnloadEventsForFrame in the callback of
onload-event signal comming from frame loader
[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewOnloadEvent): (createWebView): added connection to signal::onload-event and signal callback
- 10:51 PM Changeset in webkit [56680] by
-
- 2 edits in trunk/WebKitTools
2010-03-27 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Eric Seidel.
Print didCommitLoadForFrame in the callback of signal::load-committed
[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadCommitted): (createWebView): added connection to sinal::load-committed and signal callback
- 10:34 PM Changeset in webkit [56679] by
-
- 2 edits in trunk/WebKitTools
2010-03-27 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Eric Seidel.
Print didStartProvisionalLoadForFrame in the callback of
notify::load-status property change notification
[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorCloseWindow): (webInspectorInspectWebView): (createWebView): added connection to notify::load-status and signal callback
- 9:16 PM Changeset in webkit [56678] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-27 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Use WebKitClient to instantiate WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=36669
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize):
- 7:50 PM Changeset in webkit [56677] by
-
- 1 edit8 deletes in trunk/WebKitTools
2010-03-27 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
In webkitpy/, deleted the /unittests.py files since test-webkitpy
now auto-detects all *_unittest.py files.
- Scripts/webkitpy/common/net/irc/unittests.py: Removed.
- Scripts/webkitpy/common/system/unittests.py: Removed.
- Scripts/webkitpy/common/thread/unittests.py: Removed.
- Scripts/webkitpy/common/unittests.py: Removed.
- Scripts/webkitpy/python24/unittests.py: Removed.
- Scripts/webkitpy/style/unittests.py: Removed.
- Scripts/webkitpy/tool/unittests.py: Removed.
- Scripts/webkitpy/unittests.py: Removed.
- 7:32 PM Changeset in webkit [56676] by
-
- 2 edits in trunk/WebCore
2010-03-27 Dmitry Gorbik <socket.h@gmail.com>
Reviewed by Pavel Feldman.
Fix the regression caused by r28078: a global variable
definition masks a local one in an inspector console
https://bugs.webkit.org/show_bug.cgi?id=32442
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 6:56 PM Changeset in webkit [56675] by
-
- 5 edits in trunk/LayoutTests
More updated results for r56673.
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 6:07 PM Changeset in webkit [56674] by
-
- 2 edits in trunk/WebKitTools
2010-03-27 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Eric Seidel.
Add a CR after printing didFinishDocumentLoadForFrame
[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadFinished):
- 5:59 PM Changeset in webkit [56673] by
-
- 12 edits in trunk
WebCore: <rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
https://bugs.webkit.org/show_bug.cgi?id=36700
Reviewed by Darin Adler.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::createColor): Reverted to returning an RGB color value rather than an
identifier for the transparent color.
LayoutTests: Updated results and one test for
<rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
https://bugs.webkit.org/show_bug.cgi?id=36700
Reviewed by Darin Adler.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/invalid-import-rule-insertion.html:
- http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt:
- http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt:
- http/tests/security/cross-origin-css-expected.txt:
- http/tests/security/cross-origin-css-in-xml-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 4:29 PM Changeset in webkit [56672] by
-
- 1 edit1 move in trunk/WebKitTools
Rubber-stamped by Adam Barth.
Fixed the name of a unit test file in webkitpy.
- Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py.
- Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed.
- 3:56 PM Changeset in webkit [56671] by
-
- 2 edits3 adds in trunk/WebKitTools
2010-03-26 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
The test-webkitpy script now automatically detects all unit-test
files in webkitpy/. This lets us eliminate the need to have and
maintain all of the unittests.py files.
- Scripts/test-webkitpy:
- Replaced the "from webkitpy.unittests import *" with a call to webkitpy.test.main.Tester().run_tests().
- Scripts/webkitpy/test/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- Required file for the new webkitpy/test/ directory.
- Scripts/webkitpy/test/main.py: Added.
- Added a Tester class that contains the following methods:
- _find_unittest_files() to detect all the unit-test files.
- _modules_from_paths() to convert the paths to the unit-test files to fully-qualified module names.
- run_tests() which calls the above two methods and then passes the module names to Python's unittest module.
- Added a Tester class that contains the following methods:
- 2:42 PM Changeset in webkit [56670] by
-
- 6 edits in trunk/WebCore
2010-03-26 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Converge Inspector ids to be long, not ints
https://bugs.webkit.org/show_bug.cgi?id=36706
Part 1: Converge on
longfor callIds, nodeIds, and other Ids.
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- 12:51 PM Changeset in webkit [56669] by
-
- 2 edits in trunk/LayoutTests
Fix the newly-added test to not trip over a bug that causes some subsequent tests to fail.
Rubber-stamped by Dan Bernstein.
- fast/dom/script-tests/setPrimitiveValue-exceptions.js:
- 12:31 PM Changeset in webkit [56668] by
-
- 5 edits in trunk
2010-03-27 Robert Hogan <robert@webkit.org>
Reviewed by Simon Fraser.
[Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): Add onSetWindow. (webkit_test_plugin_destroy_instance): Add onSetWindow. (webkit_test_plugin_set_window): Add onSetWindow.
- DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New): Add onSetWindow. (NPP_Destroy): Add onSetWindow. (NPP_SetWindow): Add onSetWindow.
2010-03-27 Robert Hogan <robert@webkit.org>
Unreviewed skip failing test.
[Qt] Skip test added in r56646. Tracked by https://bugs.webkit.org/show_bug.cgi?id=36702
- platform/qt/Skipped: Add plugins/reentrant-update-widget-positions.html
- 12:24 PM Changeset in webkit [56667] by
-
- 2 edits in trunk/WebKit/mac
- Misc/WebNSFileManagerExtras.m:
(-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
Removed stray "!". How did that get in there?
- 12:20 PM Changeset in webkit [56666] by
-
- 3 edits in trunk/WebKit/mac
WebKit NSFileManager methods don't handle broken symlinks correctly.
Part of <rdar://problem/7574046>.
Reviewed by Mark Rowe.
- Misc/WebNSFileManagerExtras.h: Removed unused defines and methods.
- Misc/WebNSFileManagerExtras.m: Removed unused methods.
(fileExists): Added. For use instead of fileExistsAtPath: for cases where we'd like
to treat a broken symlink as a file that does indeed exist.
(-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use fileExists.
- 12:17 PM Changeset in webkit [56665] by
-
- 2 edits1 add in trunk
2010-03-27 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: added missing test resource file.
- inspector/resources/elements-panel-styles.css: Added.
- 11:24 AM Changeset in webkit [56664] by
-
- 7 edits2 adds in trunk
2010-03-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add layout test for styles panel.
Test: inspector/elements-panel-styles.html
- inspector/front-end/inspector.css: (#elements-content): (#elements-sidebar):
- inspector/front-end/inspector.js: (WebInspector.displayNameForURL):
- inspector/front-end/utilities.js: (String.prototype.trimURL):
- 11:21 AM Changeset in webkit [56663] by
-
- 3 edits3 adds in trunk
CSSPrimitiveValue::setFloatValue/setStringValue should throw an exception if passed an incorrect unit type.
<http://webkit.org/b/36680> / <rdar://problem/7801016>
Reviewed by Darin Adler.
WebCore:
Test: fast/dom/setPrimitiveValue-exceptions.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::setFloatValue): Throw an INVALID_ACCESS_ERR if either of our type or the passed-in
type is not a numeric type.
(WebCore::CSSPrimitiveValue::setStringValue): Throw an INVALID_ACCESS_ERR if either of our type or the passed-in
type is not a string type.
LayoutTests:
- fast/dom/script-tests/setPrimitiveValue-exceptions.js: Added.
- fast/dom/setPrimitiveValue-exceptions-expected.txt: Added.
- fast/dom/setPrimitiveValue-exceptions.html: Copied from LayoutTests/fast/dom/event-attribute-availability.html.
- 6:06 AM Changeset in webkit [56662] by
-
- 2 edits in trunk/WebCore
2010-03-27 Robert Hogan <robert@webkit.org>
Reviewed by nobody, fix typo in previous commit.
Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',
when pluginsEnabled is false
Fix parentheses typo in r56661. This happened while rebasing and was not present
in the reviewed patch, so committing unreviewed.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
- 5:46 AM Changeset in webkit [56661] by
-
- 18 edits in trunk
2010-03-26 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',
when pluginsEnabled is false.
The purpose of disabling plugins is to prevent the execution of third-party code
that may be untrustworthy. Qt plugins are implemented by the client rather than
loaded from an external source, so the client should have the opportunity to
consider them separately from other plugins.
Add a function MimeTypeRegistry::isApplicationPluginMIMEType() that WebKit
uses in conjunction with arePluginsEnabled() to determine if it should attempt
to load a plugin. If isApplicationPluginMIMEType() returns true, WebKit will load
the plugin even if arePluginsEnabled() is false.
Currently, only Qt has application-implemented plugins: these use the mimetype
'x-qt-plugin' and 'x-qt-styled-widget'. This patch permits Qt clients'
reimplementation of QWebPage::createPlugin() to decide whether or not
to create a Qt plugin, even when arePluginsEnabled is false.
For all platforms apart from Qt, isApplicationPluginMIMEType() returns false.
Test: plugins/application-plugin-plugins-disabled.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
- platform/MIMETypeRegistry.h:
- platform/brew/MIMETypeRegistryBrew.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/gtk/MIMETypeRegistryGtk.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/haiku/MIMETypeRegistryHaiku.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/mac/MIMETypeRegistryMac.mm: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/qt/MIMETypeRegistryQt.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/wince/MIMETypeRegistryWince.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/wx/MimeTypeRegistryWx.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
2010-03-26 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',
when pluginsEnabled is false.
For all platforms apart from Qt, isApplicationPluginMIMEType() returns false.
- platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
- plugins/application-plugin-plugins-disabled-expected.txt: Added.
- plugins/application-plugin-plugins-disabled.html: Added.
2010-03-26 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',
when pluginsEnabled is false.
Add support for LayoutTestController.WebKitPluginsEnabled
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (copyWebSettingKey):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference):
- 5:36 AM Changeset in webkit [56660] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Skip HTMLProgressElement tests on Windows.
- platform/win/Skipped:
- 2:06 AM Changeset in webkit [56659] by
-
- 2 edits in trunk/WebCore
Fix Acid3 text-shadow rendering regression introduced in r56597.
Reviewed by Mark Rowe.
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs): Revert to using the simple shadow logic for zero-blur shadows,
except for color bitmap fonts.
Mar 26, 2010:
- 10:44 PM Changeset in webkit [56658] by
-
- 10 edits2 copies in trunk/WebKitTools
2010-03-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add some basic IRC commands to sheriffbot
https://bugs.webkit.org/show_bug.cgi?id=36684
Adds support for sheriffbot to respond to a "hi" command and a
"last-green-revision" command. It's lame that we're rebuilding
MultiCommandTool, but as discussed in person we'll intergrate the two
once we see what the requirements are.
- Scripts/webkitpy/tool/bot/irc_command.py: Added.
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- Scripts/webkitpy/tool/bot/sheriffircbot.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/unittests.py:
- 10:42 PM Changeset in webkit [56657] by
-
- 2 edits in trunk/WebKitTools
2010-03-26 Adam Barth <abarth@webkit.org>
Unreviewed. More errors in the IRC module. I have no idea how to test
ircbot.py, which is too bad. Hopefully we've abstracted it away enough
that we don't have to touch it very much after this patch.
- Scripts/webkitpy/common/net/irc/ircbot.py:
- 10:37 PM Changeset in webkit [56656] by
-
- 3 edits1 copy in trunk/WebKitTools
2010-03-26 Adam Barth <abarth@webkit.org>
Unreviewed. Add a missing "_".
- Scripts/webkitpy/common/net/irc/ircproxy.py:
- Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: Added.
- Scripts/webkitpy/common/net/irc/unittests.py:
- 10:08 PM Changeset in webkit [56655] by
-
- 7 edits68 adds in trunk
2010-03-26 Daniel Bates <dbates@rim.com>
Reviewed by Beth Dakin.
As per sections 14.2 (http://www.w3.org/TR/CSS2/colors.html#background)
and 17.5.1 (http://www.w3.org/TR/CSS2/tables.html#table-layers) of the
CSS 2.1 spec., the background-image of a table-row should span the
entire area of the table-row (i.e cover all the <td>'s). Moreover,
fixes background image painting with respect to row-groups, columns
and column-groups (*).
Currently, the background-image of a table row, row-group, and column-group
is inherited by the table cells. This directly contradicts section 14.2.
Instead, the background-image should cover the entire area of the table row,
row-group, column, or column-group, respectively as described in section 17.5.1.
(*) A follow up patch to compute the absolute content box of a column, and
column-group is needed so that background image positioning for these table
elements works. See bug #36104.
Tests: fast/table/table-background.html
fast/table/table-cell-border-draws-on-top-of-col-background.html
fast/table/table-cell-border-draws-on-top-of-col-group-background.html
fast/table/table-cell-border-draws-on-top-of-row-background.html
fast/table/table-cell-border-draws-on-top-of-row-group-background.html
fast/table/table-cell-overrides-row-background.html
fast/table/table-col-background.html
fast/table/table-col-group-background.html
fast/table/table-col-group-col-span-background.html
fast/table/table-col-group-span-background.html
fast/table/table-col-span-background.html
fast/table/table-row-background-left-50px.html
fast/table/table-row-background-right-100percent.html
fast/table/table-row-background-right-50px.html
fast/table/table-row-background.html
fast/table/table-row-group-background-positioned.html
fast/table/table-row-group-background.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Modified to call RenderObject::adjustBackgroundImagePosition.
- rendering/RenderBoxModelObject.h:
- rendering/RenderObject.h: (WebCore::RenderObject::adjustBackgroundImagePosition): Added.
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::adjustBackgroundImagePosition): Added.
- rendering/RenderTableCell.h:
2010-03-26 Daniel Bates <dbates@rim.com>
Reviewed by Beth Dakin.
Tests that background-image support for table, table-cell, table-row,
row-group, table-column and column-group (*) conform to section 17.5.1
of the CSS 2.1 spec.
(*) A follow up patch to compute the absolute content box of a column, and
column-group is needed so that background image positioning for these table
elements works. See bug #36104.
- fast/table/table-background.html: Added.
- fast/table/table-cell-border-draws-on-top-of-col-background.html: Added.
- fast/table/table-cell-border-draws-on-top-of-col-group-background.html: Added.
- fast/table/table-cell-border-draws-on-top-of-row-background.html: Added.
- fast/table/table-cell-border-draws-on-top-of-row-group-background.html: Added.
- fast/table/table-cell-overrides-row-background.html: Added.
- fast/table/table-col-background.html: Added.
- fast/table/table-col-group-background.html: Added.
- fast/table/table-col-group-col-span-background.html: Added.
- fast/table/table-col-group-span-background.html: Added.
- fast/table/table-col-span-background.html: Added.
- fast/table/table-row-background-left-50px.html: Added.
- fast/table/table-row-background-right-100percent.html: Added.
- fast/table/table-row-background-right-50px.html: Added.
- fast/table/table-row-background.html: Added.
- fast/table/table-row-group-background-positioned.html: Added.
- fast/table/table-row-group-background.html: Added.
- platform/mac/fast/table/table-background-expected.checksum: Added.
- platform/mac/fast/table/table-background-expected.png: Added.
- platform/mac/fast/table/table-background-expected.txt: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
- platform/mac/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
- platform/mac/fast/table/table-cell-overrides-row-background-expected.png: Added.
- platform/mac/fast/table/table-cell-overrides-row-background-expected.txt: Added.
- platform/mac/fast/table/table-col-background-expected.checksum: Added.
- platform/mac/fast/table/table-col-background-expected.png: Added.
- platform/mac/fast/table/table-col-background-expected.txt: Added.
- platform/mac/fast/table/table-col-group-background-expected.checksum: Added.
- platform/mac/fast/table/table-col-group-background-expected.png: Added.
- platform/mac/fast/table/table-col-group-background-expected.txt: Added.
- platform/mac/fast/table/table-col-group-col-span-background-expected.checksum: Added.
- platform/mac/fast/table/table-col-group-col-span-background-expected.png: Added.
- platform/mac/fast/table/table-col-group-col-span-background-expected.txt: Added.
- platform/mac/fast/table/table-col-group-span-background-expected.checksum: Added.
- platform/mac/fast/table/table-col-group-span-background-expected.png: Added.
- platform/mac/fast/table/table-col-group-span-background-expected.txt: Added.
- platform/mac/fast/table/table-col-span-background-expected.checksum: Added.
- platform/mac/fast/table/table-col-span-background-expected.png: Added.
- platform/mac/fast/table/table-col-span-background-expected.txt: Added.
- platform/mac/fast/table/table-row-background-expected.checksum: Added.
- platform/mac/fast/table/table-row-background-expected.png: Added.
- platform/mac/fast/table/table-row-background-expected.txt: Added.
- platform/mac/fast/table/table-row-background-left-50px-expected.checksum: Added.
- platform/mac/fast/table/table-row-background-left-50px-expected.png: Added.
- platform/mac/fast/table/table-row-background-left-50px-expected.txt: Added.
- platform/mac/fast/table/table-row-background-right-100percent-expected.checksum: Added.
- platform/mac/fast/table/table-row-background-right-100percent-expected.png: Added.
- platform/mac/fast/table/table-row-background-right-100percent-expected.txt: Added.
- platform/mac/fast/table/table-row-background-right-50px-expected.checksum: Added.
- platform/mac/fast/table/table-row-background-right-50px-expected.png: Added.
- platform/mac/fast/table/table-row-background-right-50px-expected.txt: Added.
- platform/mac/fast/table/table-row-group-background-expected.checksum: Added.
- platform/mac/fast/table/table-row-group-background-expected.png: Added.
- platform/mac/fast/table/table-row-group-background-expected.txt: Added.
- platform/mac/fast/table/table-row-group-background-positioned-expected.checksum: Added.
- platform/mac/fast/table/table-row-group-background-positioned-expected.png: Added.
- platform/mac/fast/table/table-row-group-background-positioned-expected.txt: Added.
- 10:00 PM Changeset in webkit [56654] by
-
- 2 edits in trunk/WebKitTools
2010-03-26 Adam Barth <abarth@webkit.org>
Unreviewed. Fix a the commit queue after my recent change.
- Scripts/webkitpy/tool/bot/queueengine.py:
- 9:31 PM Changeset in webkit [56653] by
-
- 2 edits in trunk/WebCore
2010-03-26 Laszlo Gombos <Laszlo Gombos>
Unreviewed, minor build fix.
[Gtk] Guard defined but not used function
Eliminate the "defined but not used" warning after r52684.
No new tests as there is no new functionality.
- platform/ContextMenu.cpp:
- 7:38 PM Changeset in webkit [56652] by
-
- 2 edits in trunk/WebKitTools
2010-03-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed fix.
Fix the return value for port/base.diff_image (changed from 1/0 to
True/False in bug 34826.
- Scripts/webkitpy/layout_tests/port/base.py:
- 7:15 PM Changeset in webkit [56651] by
-
- 5 edits2 adds in trunk
2010-03-26 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Security: iFrame.src accepts JavaScript URL via nodeValue or textContent
https://bugs.webkit.org/show_bug.cgi?id=36502
Overrode inherited nodeValue and textContent in Attr.idl so they proxy
to value, which performs a security check.
- http/tests/security/xss-DENIED-iframe-src-alias-expected.txt: Added.
- http/tests/security/xss-DENIED-iframe-src-alias.html: Added.
2010-03-26 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Security: iFrame.src accepts JavaScript URL via nodeValue or textContent
https://bugs.webkit.org/show_bug.cgi?id=36502
Overrode inherited nodeValue and textContent in Attr.idl so they proxy
to value, which performs a security check.
Test: http/tests/security/xss-DENIED-iframe-src-alias.html
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::nodeValue): (WebCore::JSAttr::setNodeValue): (WebCore::JSAttr::textContent): (WebCore::JSAttr::setTextContent):
- bindings/v8/custom/V8AttrCustom.cpp: (WebCore::V8Attr::nodeValueAccessorSetter): (WebCore::V8Attr::nodeValueAccessorGetter): (WebCore::V8Attr::textContentAccessorSetter): (WebCore::V8Attr::textContentAccessorGetter):
- dom/Attr.idl:
- 6:20 PM Changeset in webkit [56650] by
-
- 12 edits in trunk/WebCore
2010-03-26 Eric Carlson <eric.carlson@apple.com>
<rdar://problem/7320584>
https://bugs.webkit.org/show_bug.cgi?id=36681
"new Audio()" doesn't work with plug-in backed media engine.
Don't require plug-in backed <video> and <audio> elements to be in the document to play.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_proxyWidget (WebCore::HTMLMediaElement::createRenderer): Set renderer widget if it has already been allocated. (WebCore::HTMLMediaElement::scheduleLoad): Call createMediaPlayerProxy to make sure we have a plug-in proxy. (WebCore::HTMLMediaElement::loadResource): Ditto. (WebCore::HTMLMediaElement::allocateMediaPlayerIfNecessary): Allocate media player. (WebCore::HTMLMediaElement::setMediaPlayerProxy): Call allocateMediaPlayerIfNecessary. (WebCore::HTMLMediaElement::getPluginProxyParams): New, return the url and params vectors. (WebCore::HTMLMediaElement::finishParsingChildren): Call createMediaPlayerProxy. (WebCore::HTMLMediaElement::createMediaPlayerProxy): New, allocate the proxy widget if necessary.
- html/HTMLMediaElement.h:
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createMediaPlayerProxyPlugin): Add declaration.
- loader/FrameLoader.cpp: (WebCore::toPlugInElement): Don't allow an audio or video element to be cast to a plug-in element. (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): New, allocate a media player proxy plug-in.
- loader/FrameLoader.h: Declare loadMediaPlayerProxyPlugin.
- loader/FrameLoaderClient.h: Declare createMediaPlayerProxyPlugin.
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::updateWidget): Call loadMediaPlayerProxyPlugin when passed an audio or video node.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): Get default width and height from defaultSize. (WebCore::RenderVideo::defaultSize): New, return the spec defined default width and height.
- rendering/RenderVideo.h:
- 6:11 PM Changeset in webkit [56649] by
-
- 134 edits2 adds in trunk/LayoutTests
2010-03-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
Update a bunch of incorrect image checksums, and suppress all of the
remaining IMAGE failures in platform/mac/test_expectations.txt.
- platform/mac-leopard/compositing/geometry/root-layer-update-expected.checksum:
- platform/mac-leopard/compositing/overflow/overflow-positioning-expected.checksum:
- platform/mac-leopard/compositing/repaint/become-overlay-composited-layer-expected.checksum:
- platform/mac-leopard/compositing/repaint/layer-repaint-rects-expected.checksum:
- platform/mac-leopard/media/video-zoom-controls-expected.checksum:
- platform/mac/animations/3d/change-transform-in-end-event-expected.checksum:
- platform/mac/animations/3d/state-at-end-event-transform-expected.checksum:
- platform/mac/animations/state-at-end-event-expected.checksum:
- platform/mac/compositing/animation/state-at-end-event-transform-layer-expected.checksum:
- platform/mac/compositing/color-matching/pdf-image-match-expected.checksum:
- platform/mac/compositing/compositing-visible-descendant-expected.checksum:
- platform/mac/compositing/generated-content-expected.checksum:
- platform/mac/compositing/geometry/abs-position-inside-opacity-expected.checksum:
- platform/mac/compositing/geometry/fixed-position-expected.checksum:
- platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum:
- platform/mac/compositing/geometry/outline-change-expected.checksum:
- platform/mac/compositing/geometry/partial-layout-update-expected.checksum:
- platform/mac/compositing/geometry/root-layer-update-expected.checksum:
- platform/mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum:
- platform/mac/compositing/masks/direct-image-mask-expected.checksum:
- platform/mac/compositing/masks/masked-ancestor-expected.checksum:
- platform/mac/compositing/masks/multiple-masks-expected.checksum:
- platform/mac/compositing/masks/simple-composited-mask-expected.checksum:
- platform/mac/compositing/overflow/ancestor-overflow-expected.checksum:
- platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
- platform/mac/compositing/overflow/overflow-positioning-expected.checksum:
- platform/mac/compositing/overflow/parent-overflow-expected.checksum:
- platform/mac/compositing/overflow/scrollbar-painting-expected.checksum:
- platform/mac/compositing/reflections/reflection-in-composited-expected.checksum:
- platform/mac/compositing/reflections/reflection-ordering-expected.checksum:
- platform/mac/compositing/reflections/simple-composited-reflections-expected.checksum:
- platform/mac/compositing/repaint/become-overlay-composited-layer-expected.checksum:
- platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
- platform/mac/compositing/repaint/layer-repaint-expected.checksum:
- platform/mac/compositing/repaint/layer-repaint-rects-expected.checksum:
- platform/mac/compositing/repaint/opacity-between-absolute-expected.checksum:
- platform/mac/compositing/repaint/opacity-between-absolute2-expected.checksum:
- platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
- platform/mac/compositing/sibling-positioning-expected.checksum:
- platform/mac/compositing/transitions/singular-scale-transition-expected.checksum:
- platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum:
- platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum:
- platform/mac/editing/deleting/delete-to-select-table-expected.checksum:
- platform/mac/editing/deleting/type-delete-after-quote-expected.checksum:
- platform/mac/editing/inserting/5418891-expected.checksum:
- platform/mac/editing/selection/4960116-expected.checksum:
- platform/mac/editing/selection/caret-rtl-2-expected.checksum:
- platform/mac/editing/selection/extend-by-word-002-expected.checksum:
- platform/mac/editing/selection/select-all-002-expected.checksum:
- platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum:
- platform/mac/editing/selection/transformed-selection-rects-expected.checksum:
- platform/mac/fast/backgrounds/background-clip-text-expected.checksum:
- platform/mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.checksum:
- platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
- platform/mac/fast/backgrounds/size/backgroundSize15-expected.checksum:
- platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
- platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
- platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-mask-expected.checksum:
- platform/mac/fast/block/float/avoidance-percent-width-compat-expected.checksum:
- platform/mac/fast/block/float/avoidance-percent-width-strict-expected.checksum:
- platform/mac/fast/block/margin-collapse/103-expected.checksum:
- platform/mac/fast/box-shadow/basic-shadows-expected.checksum:
- platform/mac/fast/box-shadow/transform-fringing-expected.checksum:
- platform/mac/fast/css/apple-prefix-expected.checksum:
- platform/mac/fast/css/color-correction-backgrounds-and-text-expected.checksum:
- platform/mac/fast/css/color-correction-expected.checksum:
- platform/mac/fast/css/color-correction-on-background-image-expected.checksum:
- platform/mac/fast/css/color-correction-on-backgrounds-expected.checksum:
- platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum:
- platform/mac/fast/css/color-correction-on-text-expected.checksum:
- platform/mac/fast/css/color-correction-on-text-shadow-expected.checksum:
- platform/mac/fast/css/color-correction-untagged-images-expected.checksum:
- platform/mac/fast/css/namespaces/namespaces-comments-expected.checksum:
- platform/mac/fast/css/namespaces/namespaces-empty-expected.checksum:
- platform/mac/fast/css/namespaces/namespaces-escapes-expected.checksum:
- platform/mac/fast/css/namespaces/namespaces-invalid-at-expected.checksum:
- platform/mac/fast/css/variables/misplaced-import-test-expected.checksum:
- platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
- platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum:
- platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum:
- platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum:
- platform/mac/fast/forms/001-expected.checksum:
- platform/mac/fast/forms/menulist-clip-expected.checksum:
- platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
- platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
- platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
- platform/mac/fast/forms/menulist-style-color-expected.checksum:
- platform/mac/fast/forms/select-baseline-expected.checksum:
- platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
- platform/mac/fast/frames/viewsource-attribute-expected.checksum:
- platform/mac/fast/inline/long-wrapped-line-expected.checksum:
- platform/mac/fast/lists/anonymous-items-expected.checksum:
- platform/mac/fast/lists/markers-in-selection-expected.checksum:
- platform/mac/fast/multicol/client-rects-expected.checksum: Added.
- platform/mac/fast/multicol/float-multicol-expected.checksum:
- platform/mac/fast/overflow/line-clamp-expected.checksum:
- platform/mac/fast/overflow/position-fixed-transform-clipping-expected.checksum:
- platform/mac/fast/reflections/abs-position-in-reflection-expected.checksum:
- platform/mac/fast/reflections/opacity-reflection-transform-expected.checksum:
- platform/mac/fast/repaint/backgroundSizeRepaint-expected.checksum:
- platform/mac/fast/repaint/box-shadow-h-expected.checksum:
- platform/mac/fast/repaint/box-shadow-v-expected.checksum:
- platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum:
- platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum:
- platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum:
- platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum:
- platform/mac/fast/repaint/subtree-layoutstate-transform-expected.checksum:
- platform/mac/fast/repaint/table-outer-border-expected.checksum:
- platform/mac/fast/table/fixed-table-with-percent-inside-percent-table-expected.checksum:
- platform/mac/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.checksum:
- platform/mac/fast/table/fixed-table-with-percent-width-inside-div-expected.checksum:
- platform/mac/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.checksum:
- platform/mac/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.checksum:
- platform/mac/fast/table/fixed-table-with-small-percent-width-expected.checksum:
- platform/mac/fast/text/atsui-partial-selection-expected.checksum:
- platform/mac/fast/text/capitalize-boundaries-expected.checksum:
- platform/mac/fast/text/drawBidiText-expected.checksum:
- platform/mac/fast/text/line-breaking-with-kerning-expected.checksum:
- platform/mac/fast/text/sticky-typesetting-features-expected.checksum:
- platform/mac/fast/transforms/shadows-expected.checksum:
- platform/mac/http/tests/misc/slow-loading-mask-expected.checksum:
- platform/mac/media/video-zoom-controls-expected.checksum:
- platform/mac/plugins/embed-attributes-style-expected.checksum:
- platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug106158-1-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug106158-2-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug34176-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug6674-expected.checksum:
- platform/mac/test_expectations.txt:
- platform/mac/transforms/2d/transform-fixed-container-expected.checksum:
- platform/mac/transitions/move-after-transition-expected.checksum:
- platform/mac/transitions/transition-end-event-rendering-expected.checksum:
- 5:15 PM Changeset in webkit [56648] by
-
- 3 edits1 add in trunk
2010-03-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add a test_expectations.txt file for the mac platform so
new-run-webkit-tests can track IMAGE failures.
- platform/mac/test_expectations.txt: Added.
2010-03-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Change the Mac port of new-run-webkit-tests to look for a
test_expectations.txt file in addition to the Skipped files, so we
can track pixel failures.
- Scripts/webkitpy/layout_tests/port/mac.py:
- 4:38 PM Changeset in webkit [56647] by
-
- 3 edits1 add in trunk/WebKitTools
2010-03-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Implement pixel tests (image diff) properly on the Mac port.
This change introduces a new "ServerPocess" class that can be used
to manage processes that the run-webkit-tests harness forks off and
expects to stay up for longer than a single request/response session.
Both DumpRenderTree and ImageDiff use this style of communication,
although the current code forks off a new ImageDiff for each diff
(We need to restructure other parts of the code to be able to do this
safely in a multi-threaded environment).
Also, now that the ServerProcess abstraction exists, we can probably
clean up and simplify some of the thread management logic in
test_shell_thread as well.
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/server_process.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- 3:23 PM Changeset in webkit [56646] by
-
- 7 edits4 adds in trunk
2010-03-26 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein, Darin Adler.
Re-entrant layout via plug-ins may cause crashes with bad RenderWidgets
https://bugs.webkit.org/show_bug.cgi?id=36675
<rdar://problem/7787617>
Fix two places in the code where RenderWidgets can get destroyed while being iterated over.
This can happen when plug-ins execute script from NPP_SetWindow, and that script makes a change
to the page that destroys a RenderWidget.
Tests: plugins/reentrant-update-widget-positions.html
plugins/update-widgets-crash.html
- page/FrameView.cpp: (WebCore::FrameView::updateWidgets): ref() the RenderEmbeddedObjects that are put into the vector before iterating of them, and deref() them at the end. Rather than checking the m_widgetUpdateSet to see if the RenderWidget is still live, test object->node().
- rendering/RenderView.cpp: (WebCore::RenderView::RenderView): Initialize some data members to make it more obvious in the debugger that the object is not garbage. (WebCore::RenderView::updateWidgetPositions): Use a Vector of RenderWidget* to keep the RenderWidgets alive during iteration, by reffing and dereffing them.
- rendering/RenderWidget.h: (WebCore::RenderWidget::ref): Make this and deref() public.
- 3:16 PM Changeset in webkit [56645] by
-
- 2 edits in trunk/WebKitTools
2010-03-26 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Eric Seidel.
Print didFinishLoadForFrame outcome in DRT
[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadCommitted):
- 3:12 PM Changeset in webkit [56644] by
-
- 4 edits in trunk
WebCore: Partial fix for https://bugs.webkit.org/show_bug.cgi?id=36564
Performance regression for setting content of <text> in SVG
-and corresponding-
<rdar://problem/7693963>
Reviewed by Darin Adler.
toClipPath() is extremely inefficient, so this patch removes the
call to it from RenderSVGResourceClipper::resourceBoundingBox()
which is very hot code in SVG with clip-paths. It is sufficient to
call unite with the objectBoundingBox(), which will return early if
objectBoundingBox() is empty.
- rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::resourceBoundingBox):
LayoutTests: Updated test for https://bugs.webkit.org/show_bug.cgi?id=36564
Performance regression for setting content of <text> in SVG
-and corresponding-
<rdar://problem/7693963>
Reviewed by Darin Adler.
- platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
- 2:51 PM Changeset in webkit [56643] by
-
- 2 edits in trunk/WebKitTools
2010-03-26 Eric Seidel <eric@webkit.org>
Unreviewed test fix.
My change conflicted with one of Adam's causing test-webkitpy to fail.
Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629
- Scripts/webkitpy/common/checkout/api_unittest.py:
- modified_changelogs is now on Checkout instead of scm.
- 2:45 PM Changeset in webkit [56642] by
-
- 7 edits1 copy1 add in trunk/WebKitTools
2010-03-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Refactor IRCBot controller logic to allow for commands
https://bugs.webkit.org/show_bug.cgi?id=36676
We need to move the controller logic into the tool package so it can
know about commands. The changes to queueengine could go in a
different patch, but we're going to need it anyway.
- Scripts/webkitpy/common/config/irc.py: Added.
- Scripts/webkitpy/common/net/irc/ircbot.py:
- Scripts/webkitpy/common/net/irc/ircproxy.py:
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/sheriffircbot.py: Added.
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/mocktool.py:
- 1:44 PM Changeset in webkit [56641] by
-
- 3 edits6 adds in trunk
2010-03-26 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Dave Hyatt.
Generated run-in Content is Mistakenly Getting Deleted
https://bugs.webkit.org/show_bug.cgi?id=36505
<rdar://problem/7767161>
Test: fast/runin/generated2.html
Test: fast/runin/generated3.html
Test: fast/runin/generated4.html
Do not destroy :before/:after generated content with display run-in
when relaying out different nodes. Have their real owners correctly
handle them.
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent): simplified logic (WebCore::RenderObjectChildList::beforeAfterContainer): skip generated run-ins when checking children, check for them in grandchildren
2010-03-26 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Dave Hyatt.
Generated run-in Content is Mistakenly Getting Deleted
https://bugs.webkit.org/show_bug.cgi?id=36505
<rdar://problem/7767161>
Test dynamic update of the inner block, containing the generated
run-in, but not owning it with the :before rule, and owners.
- fast/runin/generated2.html: Added.
- platform/mac/fast/runin/generated2-expected.txt: Added.
Test dynamic update of the outer block, this block owns the
generated run-in, but it is actually contained in a child block.
- fast/runin/generated3.html: Added.
- platform/mac/fast/runin/generated3-expected.txt: Added.
Test dynamic updates affecting generated run-ins both
in relation to and not in relation to list markers.
- fast/runin/generated4.html: Added.
- platform/mac/fast/runin/generated4-expected.txt: Added.
- 1:22 PM Changeset in webkit [56640] by
-
- 5 edits4 moves3 adds in trunk/WebKitTools
2010-03-26 Adam Barth <abarth@webkit.org>
Rubber stamped by Eric Seidel.
Move the threading code into its own module. (It has nothing to do with IRC.)
- Scripts/webkitpy/common/net/irc/ircbot.py:
- Scripts/webkitpy/common/net/irc/ircproxy.py:
- Scripts/webkitpy/common/net/irc/messagepump.py: Removed.
- Scripts/webkitpy/common/net/irc/messagepump_unittest.py: Removed.
- Scripts/webkitpy/common/net/irc/threadedmessagequeue.py: Removed.
- Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: Removed.
- Scripts/webkitpy/common/net/irc/unittests.py:
- Scripts/webkitpy/common/thread: Added.
- Scripts/webkitpy/common/thread/init.py: Added.
- Scripts/webkitpy/common/thread/messagepump.py: Copied from Scripts/webkitpy/common/net/irc/messagepump.py.
- Scripts/webkitpy/common/thread/messagepump_unittest.py: Copied from Scripts/webkitpy/common/net/irc/messagepump_unittest.py.
- Scripts/webkitpy/common/thread/threadedmessagequeue.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue.py.
- Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py.
- Scripts/webkitpy/common/thread/unittests.py: Added.
- Scripts/webkitpy/common/unittests.py:
- 1:19 PM Changeset in webkit [56639] by
-
- 8 edits in trunk
2010-03-25 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
shift+home/end and cmd+shift+left/right don't extend the selection correctly
https://bugs.webkit.org/show_bug.cgi?id=36539
- editing/selection/extend-after-mouse-selection.html:
- editing/selection/extend-selection-expected.txt: Extending forward by lineboundary selects the whole line. Now extending backwards by lineboundary after the whole line is selected is a noop instead of collapsed the selection to the start.
- editing/selection/move-begin-end.html: Just cleaned up this test.
- platform/mac/editing/selection/extend-after-mouse-selection-expected.txt:
2010-03-25 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
shift+home/end and cmd+shift+left/right don't extend the selection correctly
https://bugs.webkit.org/show_bug.cgi?id=36539
- WebCore.base.exp:
- editing/SelectionController.cpp: (WebCore::SelectionController::modify):
- editing/SelectionController.h:
- 12:47 PM Changeset in webkit [56638] by
-
- 3 edits1 add in trunk/WebKitTools
2010-03-26 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629
Finally add some basic unit testing for Checkout.commit_message_for_this_commit
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/api_unittest.py: Added.
- Scripts/webkitpy/common/unittests.py:
- 12:40 PM Changeset in webkit [56637] by
-
- 8 edits4 adds in trunk/WebKit/chromium
2010-03-24 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Implement WebFormControlElement and WebSelectElement. Add
a getFormControlElements method to WebFormElement.
- WebKit.gyp:
- public/WebElement.h:
- public/WebFormControlElement.h: Added.
- public/WebFormElement.h:
- public/WebInputElement.h: (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::assign):
- public/WebSelectElement.h: Added.
- src/WebElement.cpp: (WebKit::WebElement::isFormControlElement):
- src/WebFormControlElement.cpp: Added.
- src/WebFormElement.cpp: (WebKit::WebFormElement::getFormControlElements):
- src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement):
- src/WebSelectElement.cpp: Added.
- 12:30 PM Changeset in webkit [56636] by
-
- 5 edits2 adds in trunk/WebKitTools
User Agent Switcher on QtLauncher https://bugs.webkit.org/show_bug.cgi?id=36451
Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-26
Reviewed by Simon Hausmann.
Make possible to change the QtLauncher user agent via
a predefined list.
- QtLauncher/QtLauncher.pro:
- QtLauncher/QtLauncher.qrc: Added.
- QtLauncher/main.cpp:
(LauncherWindow::showUserAgentDialog):
(LauncherWindow::createChrome):
- QtLauncher/useragentlist.txt: Added.
- QtLauncher/webpage.cpp:
(WebPage::userAgentForUrl):
- QtLauncher/webpage.h:
(WebPage::setUserAgent):
- 11:21 AM QtWebKitBackportingFixes edited by
- (diff)
- 11:14 AM Changeset in webkit [56635] by
-
- 9 edits4 adds in trunk/WebKitTools
2010-03-26 Victor Wang <victorw@chromium.org>
Reviewed by Adam Barth.
Host layout test flakiness dashboard in TestResultServer appengine.
Flakiness dashboard is a tool to monitor layout test status and
help layout test regression diagnostics.
- TestResultServer/handlers/dashboardhandler.py: Added.
- New handler to handle dashboard request
- TestResultServer/handlers/menu.py:
- Add new dashboard links
- TestResultServer/handlers/testfilehandler.py:
- Request routes refactory
- TestResultServer/index.yaml:
- TestResultServer/main.py:
- Add new dashboard request routes and refactor test result file rountes.
- TestResultServer/model/dashboardfile.py: Added.
- Model to access datastore for dashboard files
- TestResultServer/model/testfile.py:
- TestResultServer/stylesheets/dashboardfile.css: Added.
- TestResultServer/templates/dashboardfilelist.html: Added.
- TestResultServer/templates/showfilelist.html:
- 11:06 AM Changeset in webkit [56634] by
-
- 2 edits in trunk/LayoutTests
Add fast/multicol/hit-test-above-or-below.html, this is failing in the same way as Qt, and is being
tracked by the same bug (https://bugs.webkit.org/show_bug.cgi?id=35973).
- platform/win/Skipped:
- 10:38 AM Changeset in webkit [56633] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Nate Chapin.
[chromium] Updated test expectations due to recent failures,
added bugs, etc.
- platform/chromium/test_expectations.txt:
- 10:37 AM FastMalloc Glossary created by
- 10:32 AM Changeset in webkit [56632] by
-
- 5 edits in trunk/WebKitTools
2010-03-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove some evil statics from CommitInfo
https://bugs.webkit.org/show_bug.cgi?id=36637
These methods should really be on checkout. You can tell because they
know about ChangeLogs and take an SCM as an argument. :)
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/checkout/commitinfo.py:
- Scripts/webkitpy/tool/commands/queries.py:
- 10:32 AM WikiStart edited by
- (diff)
- 10:29 AM WikiStart edited by
- (diff)
- 10:04 AM Changeset in webkit [56631] by
-
- 2 edits in trunk/WebCore
2010-03-26 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Laszlo Gombos.
Don't undefine SKIP_STATIC_CONSTRUCTORS_ON_GCC for Symbian HW targets.
https://bugs.webkit.org/show_bug.cgi?id=34081
Defining StringImpl instances as globals will cause a crash on process exit as
StringImpl::Remove expects TLS which was already deleted at time of exiting main and ends up
constructing one exiting thread.
- config.h:
- 9:34 AM Changeset in webkit [56630] by
-
- 8 edits in trunk
2010-03-26 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Send worker resource content to inspector to enable display of web
workers in inspector's resource tab.
https://bugs.webkit.org/show_bug.cgi?id=36658
- inspector/InspectorController.cpp: (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported):
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::type): (WebCore::InspectorResource::setOverrideContent): (WebCore::InspectorResource::sourceString):
- inspector/InspectorResource.h:
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished):
- workers/Worker.cpp: (WebCore::Worker::notifyFinished):
2010-03-26 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Send worker resource content to inspector to enable display of web
workers in inspector's resource tab.
https://bugs.webkit.org/show_bug.cgi?id=36658
- src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished):
- 8:42 AM Changeset in webkit [56629] by
-
- 10 edits in trunk
WebCore: Fix the rendering of HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36206
Reviewed by Antti Koivisto.
Update the rendering and css to conform to
http://www.whatwg.org/specs/web-apps/current-work/complete.html#the-progress-element-0.
Updated the tests and the expected results accordingly.
- css/html.css:
- rendering/RenderProgress.cpp:
- rendering/RenderProgress.h:
LayoutTests: Fix the rendering of HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36206
Add dir=rtl test and update the expected results.
Reviewed by Antti Koivisto.
- fast/dom/HTMLProgressElement/progress-element.html:
- platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
- platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png:
- platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- 8:30 AM Changeset in webkit [56628] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
FontPlatformDataPango.cpp: prototype for
'WebCore::FontPlatformData::FontPlatformData(cairo_font_face_t*, int, bool, bool)'
does not match any in class
https://bugs.webkit.org/show_bug.cgi?id=36496
- platform/graphics/gtk/FontPlatformDataPango.cpp:
(WebCore::FontPlatformData::FontPlatformData): The 'size' parameter
should be a float to match the declaration and the other definitions.
- 8:22 AM Changeset in webkit [56627] by
-
- 2 edits in trunk/WebCore
2010-03-26 Shu Chang <chang.shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Prevent referring d->m_job in the future because calling abort()
deletes the instance itself.
https://bugs.webkit.org/show_bug.cgi?id=36618
Test: http/tests/appcache/fallback.html
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::cancel):
- 7:49 AM QtWebKit edited by
- (diff)
- 7:37 AM Changeset in webkit [56626] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Compile with QT_USE_FAST_OPERATOR_PLUS
Patch by Olivier Goffart <ogoffart@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::populateSetting):
(WebCore::InspectorClientQt::storeSetting):
- 7:35 AM Changeset in webkit [56625] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Doc: Simplified Commercial Editions for Qt 4.7.
Patch by David Boddie <dboddie@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.
- docs/qtwebkit.qdoc:
- 7:26 AM Changeset in webkit [56624] by
-
- 4 edits2 deletes in trunk
2010-03-26 Stephen White <senorblanco@chromium.org>
Unreviewed; build fix.
Rolling out 56620; too many layout test failures.
Covered by fast/css/*.
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
2010-03-26 Stephen White <senorblanco@chromium.org>
Unreviewed; build fix.
Rolling out 56620; too many layout test failures.
- fast/css/cssText-cache-expected.txt: Removed.
- fast/css/cssText-cache.html: Removed.
- 7:05 AM Changeset in webkit [56623] by
-
- 9 edits in trunk
[Qt] Build JavaScriptCore as a static library.
https://bugs.webkit.org/show_bug.cgi?id=36590
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-03-26
Reviewed by Simon Hausmann.
This patch takes what was left of the unused JavaScriptCore.pro
and moved the compilation logic from JavaScriptCore.pri to
JavaScriptCore.pro.
.:
- WebKit.pro:
- JavaScriptCore.pri:
- JavaScriptCore.pro:
- jsc.pro:
- qt/api/QtScript.pro:
WebCore:
- WebCore.pro:
- 6:44 AM Changeset in webkit [56622] by
-
- 2 edits in trunk/WebCore
[Qt] Fix compilation on Windows
Patch by Olivier Goffart <ogoffart@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.
For some reason, the MSVC compiler choose the
operator+(const QString &, const QString &) instead of
operator+(const WebCore::String &, const WebCore::String &)
resulting in errors when QT_USE_FAST_OPERATOR_PLUS is used.
- dom/XMLTokenizerQt.cpp:
(WebCore::handleElementNamespaces):
- 6:28 AM Changeset in webkit [56621] by
-
- 2 edits in trunk/LayoutTests
2010-03-26 Philippe Normand <pnormand@igalia.com>
fast/parser/xml-declaration-missing-ending-mark.html crashed on Gtk bot
https://bugs.webkit.org/show_bug.cgi?id=33027
Skipping test that fails on GTK+ Debug bots.
- platform/gtk/Skipped:
- 6:18 AM Changeset in webkit [56620] by
-
- 4 edits2 adds in trunk
2010-03-24 Stephen White <senorblanco@chromium.org>
Reviewed by Darin Adler.
In order to speed up multiple calls to CSSPrimitiveValue::cssText(),
this CL caches the String result. When m_value is changed, the
cached string is cleared. This gives a good speedup on benchmarks
which do a lot of CSS property gets, such as Peacekeeper.
The processing cost should be negligible, since the strings are
refcounted. The memory cost is an additional 4 bytes per
CSSPrimitiveValue, and the extended lifetime of the computed string
(potentially, the same as the lifetime of the CSSPrimitiveValue).
Covered by fast/css/large-number-round-trip.html, and more.
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
- css/CSSPrimitiveValue.h:
2010-03-25 Stephen White <senorblanco@chromium.org>
Reviewed by Darin Adler.
Added a test for CSSPrimitiveValue::cssText() string cacheing.
- fast/css/cssText-cache-expected.txt: Added.
- fast/css/cssText-cache.html: Added.
- 5:58 AM Changeset in webkit [56619] by
-
- 4 edits in trunk
2010-03-26 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] fast/canvas/drawImage-with-negative-source-destination.html failed
https://bugs.webkit.org/show_bug.cgi?id=35005
Enable fast/canvas/drawImage-with-negative-source-destination.html
- platform/qt/Skipped:
2010-03-26 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] fast/canvas/drawImage-with-negative-source-destination.html failed
https://bugs.webkit.org/show_bug.cgi?id=35005
To support negative width or height at context.drawImage
- platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
- 5:52 AM Changeset in webkit [56618] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Simon Hausmann.
Add an option to QtLauncher to enable/disable a QGLWidget as Viewport
of the QGraphicsView when the launcher is running on graphicsview mode.
[Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport
https://bugs.webkit.org/show_bug.cgi?id=36270
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
(LauncherWindow::toggleQGLWidgetViewport):
(LauncherWindow::createChrome):
- 4:11 AM Changeset in webkit [56617] by
-
- 2 edits in trunk/LayoutTests
2010-03-26 Mads Ager <ager@chromium.org>
Reviewed by Jeremy Orlow.
Tweak Chromium test expectations
https://bugs.webkit.org/show_bug.cgi?id=36651
fast/js/large-expressions.html started failing on Linux in release
mode occassionally. Also fails on other platforms.
- platform/chromium/test_expectations.txt:
- 2:21 AM Changeset in webkit [56616] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, removing websocket/tests/long-invalid-header.html from Chromium test_expectations.txt
- platform/chromium/test_expectations.txt: remove websocket/tests/long-invalid-header.html
- 1:58 AM Changeset in webkit [56615] by
-
- 2 edits in trunk/WebCore
2010-03-08 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GStreamer] soften dependency on libsoup in the http src element
https://bugs.webkit.org/show_bug.cgi?id=35864
Replaced SoupURI calls with KURL and pause/resume internal soup
messages only if the element is compiled for a port depending on
libsoup.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webkit_web_src_init): (webKitWebSrcSetUri): (webKitWebSrcNeedDataMainCb): (webKitWebSrcEnoughDataMainCb):
- 1:45 AM Changeset in webkit [56614] by
-
- 2 edits in trunk/WebKitTools
2010-03-26 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Shinichiro Hamaji.
[Chromium-Win] websocket_server.py failed to start
https://bugs.webkit.org/show_bug.cgi?id=36586
subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
We don't need stdin, so use devnull as stdin.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin
- 1:05 AM Changeset in webkit [56613] by
-
- 4 edits in trunk/WebCore
2010-03-25 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Shot record filter is implemented in Timeline Panel.
https://bugs.webkit.org/show_bug.cgi?id=36606
- English.lproj/localizedStrings.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord.prototype.get _isLongEvent):
- inspector/front-end/inspector.css:
- 12:58 AM Changeset in webkit [56612] by
-
- 1 edit2 adds in trunk/WebKitTools
2010-03-26 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add TestNavigationController and TestWebWorker
https://bugs.webkit.org/show_bug.cgi?id=36520
Add LayoutTestController class, which is going to be used by
DumpRenderTree Chromium port. These files are based on:
- src/webkit/tools/test_shell/layout_test_controller.cc
- src/webkit/tools/test_shell/layout_test_controller.h of Chromium rev.40492.
- DumpRenderTree/chromium/LayoutTestController.cpp: Added.
- DumpRenderTree/chromium/LayoutTestController.h: Added.
- 12:55 AM Changeset in webkit [56611] by
-
- 2 edits in trunk/WebKit/qt
Symbian build fix.
[Qt] Updated the def file with new exports used by QtLauncher.
- symbian/eabi/QtWebKitu.def:
- 12:43 AM Changeset in webkit [56610] by
-
- 3 edits in trunk/WebCore
Rollout r56609. It was accidental commit.
- 12:34 AM Changeset in webkit [56609] by
-
- 3 edits in trunk/WebCore
2009-10-20 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: populate child nodes before sorting them.
- inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode. (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses. (WebInspector.ProfileDataGridNode.prototype.get _parent): (WebInspector.ProfileDataGridNode.prototype._populate):
- inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
- 12:13 AM Changeset in webkit [56608] by
-
- 10 edits in trunk/WebCore
2010-03-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement CSSStyleSelector::pseudoStyleForElement and use it in the InspectorDOMAgent.
This change provides pseudo elements information into the inspector styles sidebar pane.
Changes applied:
- CSSStyleSelector::pseudoStyleRulesForElement implemented. I changed the signature to accept PseudoId instead of a String since it better reflected the needs;
- Accompanied elementStyle checks with m_collectRulesOnly checks;
- Removed pseudoStyleRulesForElement usage from DOMWindow::getMatchedCSSRules. It was anyways returning 0, while I would need to convert String to PseudoId in order to leave the call in place;
- Needed to introduce AFTER_LAST_INTERNAL_PSEUDOID marker const in RenderStyleConstants' PseudoId enum
- InspectorDOMAgent is now iterating over all pseudo ids to get all styles (including internal ones).
- Brushed up front-end code so that proper overriding took place locally within pseudo id categories.
- English.lproj/localizedStrings.js:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- css/CSSStyleSelector.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::buildObjectForAttributeStyles): (WebCore::InspectorDOMAgent::buildArrayForCSSRules): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.callback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.insertInheritedNodeSeparator): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules): (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.StylesSidebarPane.prototype._changeColorFormat): (WebInspector.StylesSidebarPane.prototype.addBlankSection): (WebInspector.StylesSidebarPane.prototype.removeSection):
- inspector/front-end/inspector.css: (.styles-sidebar-separator):
- page/DOMWindow.cpp: (WebCore::DOMWindow::getMatchedCSSRules):
- rendering/style/RenderStyleConstants.h: (WebCore::):
- 12:11 AM Changeset in webkit [56607] by
-
- 7 edits in trunk/WebKitLibraries
Update WebCoreSQLite3 to SQLite v3.6.12.
Rubber-stamped by Dan Bernstein.
- WebCoreSQLite3/sqlite3.h:
- WebCoreSQLite3/sqlite3ext.h:
- libWebCoreSQLite3.a:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
Mar 25, 2010:
- 11:34 PM Changeset in webkit [56606] by
-
- 12 edits1 move2 adds1 delete in trunk
2010-03-25 Charlie Reis <creis@chromium.org>
Reviewed by Adam Barth.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Adds a layout test for bug 27481. Requires calling shouldClose on
the WebView, which is done with a new method on LayoutTestController.
- fast/events/onbeforeunload-focused-iframe-expected.txt: Added.
- fast/events/onbeforeunload-focused-iframe.html: Added.
- fast/events/resources/onbeforeunload-focused-iframe-frame.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
2010-03-25 Charlie Reis <creis@chromium.org>
Reviewed by Adam Barth.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Test: fast/events/onbeforeunload-focused-iframe.html
Replaces initial manual tests with a layout test.
- manual-tests/onbeforeunload-focused-iframe.html: Removed.
- manual-tests/resources/focused-iframe.html: Removed.
2010-03-25 Charlie Reis <creis@chromium.org>
Reviewed by Adam Barth.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Adds a callShouldCloseOnWebView method to LayoutTestController,
to allow automated testing for bug 27481.
- DumpRenderTree/LayoutTestController.cpp: (callShouldCloseOnWebViewCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::callShouldCloseOnWebView):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::callShouldCloseOnWebView):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::callShouldCloseOnWebView):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::callShouldCloseOnWebView):
- 11:23 PM Changeset in webkit [56605] by
-
- 2 edits in trunk/LayoutTests
2010-03-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION: plugins/netscape-construct.html and plugins/mouse-events-fixedpos.html failing on Snow Leopard Bot
https://bugs.webkit.org/show_bug.cgi?id=36462
Adding tests to the Skipped list per Alexey's recommendation
until someone from Apple can update the version of Safari
on the Snow Leopard bot.
- platform/mac-snowleopard/Skipped:
- 11:06 PM Changeset in webkit [56604] by
-
- 3 edits2 adds in trunk
2010-03-25 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Missing lock in call to doneCreatingDatabase
https://bugs.webkit.org/show_bug.cgi?id=36473
Added new test storage/open-database-over-quota.html.
- storage/open-database-over-quota.html: Added.
- storage/open-database-over-quota-expected.txt: Added.
2010-03-25 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Missing lock in call to doneCreatingDatabase
https://bugs.webkit.org/show_bug.cgi?id=36473
Added new test storage/open-database-over-quota.html.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): Added missing lock call.
- 10:48 PM Changeset in webkit [56603] by
-
- 5 edits in trunk
2010-03-25 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] correctly handle move drag operations
https://bugs.webkit.org/show_bug.cgi?id=36484
- platform/chromium/test_expectations.txt:
2010-03-25 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] correctly handle move drag operations
https://bugs.webkit.org/show_bug.cgi?id=36484
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnter): (WebKit::WebViewImpl::dragTargetDragOver): (WebKit::WebViewImpl::dragTargetDragEnterOrOver): Combine common code into a helper method
and properly mask against the drag effect.
(WebKit::WebViewImpl::createUniqueIdentifierForRequest):
- src/WebViewImpl.h:
- 10:42 PM Changeset in webkit [56602] by
-
- 4 edits in trunk/WebKitTools
2010-03-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add webkit-patch lkgr for finding last known good revision
https://bugs.webkit.org/show_bug.cgi?id=36626
This is rather slow for now because the command
has to compute this information from the buildbot.
A better long-term solution would be to have a server
somewhere store a pre-computed LKGR and then any
script (like webkit-patch) could just fetch it.
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/tool/commands/queries.py:
- 10:38 PM Changeset in webkit [56601] by
-
- 10 edits in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move modified_changelogs (and friends) from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36636
These functions know about ChangeLogs, which is forbidden knowledge in
scm.py.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
- Scripts/webkitpy/tool/steps/revertrevision.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
- Scripts/webkitpy/tool/steps/validatereviewer.py:
- 10:32 PM Changeset in webkit [56600] by
-
- 6 edits in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move apply_patch from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36635
SCM shouldn't have any knowledge of WebKit scripts.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/applypatch.py:
- 9:48 PM Changeset in webkit [56599] by
-
- 2 edits in trunk/WebKitTools
2010-03-25 Eric Seidel <eric@webkit.org>
Unreviewed build fix to un-break webkit-patch land.
Test-case coming in follow-up commit.
Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629
- Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage
- 9:40 PM Changeset in webkit [56598] by
-
- 4 edits in trunk
WebCore:
2010-03-25 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
[chromium] REGRESSION: Some LayoutTests fail after r56567
https://bugs.webkit.org/show_bug.cgi?id=36630
Fix boolean logic goofup. This was a last minute code review
change that didn't get tested on Windows before commit.
- editing/SelectionController.cpp: (WebCore::SelectionController::setIsDirectional):
LayoutTests:
2010-03-25 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
[chromium] REGRESSION: Some LayoutTests fail after r56567
https://bugs.webkit.org/show_bug.cgi?id=36630
- platform/chromium/test_expectations.txt:
- 9:35 PM Changeset in webkit [56597] by
-
- 11 edits1 copy5 adds in trunk
<rdar://problem/7728903> Support color bitmap fonts
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/fonts/color-bitmap.html
- platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances): Added. Calls CGContextShowGlyphsWithAdvances()
or CTFontShowGlyphs() depending on whether the font is a color bitmap font.
(WebCore::Font::drawGlyphs): Use showGlyphsWithAdvances(). Don’t include the font’s matrix in
the context’s text matrix when drawing with a color bitmap font, because CTFontShowGlyphs()
factors it in.
- platform/graphics/mac/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData): Added m_isColorBitmapFont member
and initialized it in constructors.
(WebCore::FontPlatformData::isColorBitmapFont): Added this getter.
- platform/graphics/mac/FontPlatformDataMac.mm:
(WebCore::FontPlatformData::FontPlatformData): Initialize m_isColorBitmapFont.
(WebCore::FontPlatformData::operator=): Copy m_isColorBitmapFont.
(WebCore::FontPlatformData::setFont): Set m_isColorBitmapFont.
WebKitTools:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf
and ColorBits-A.png.
- DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
- DumpRenderTree/fonts/ColorBits.ttf: Added.
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFonts): Activate ColorBits.ttf.
LayoutTests:
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/fonts/color-bitmap-expected.checksum: Added.
- platform/mac/fonts/color-bitmap-expected.png: Added.
- platform/mac/fonts/color-bitmap-expected.txt: Added.
- platform/mac/fonts/color-bitmap.html: Added.
- 9:28 PM Changeset in webkit [56596] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, another attempt to unblock Chromium Win test bot.
- platform/chromium/test_expectations.txt:
- 9:23 PM Changeset in webkit [56595] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, removing stale expectation file for Chromium.
The test was updated by http://trac.webkit.org/changeset/56506 to a script test.
- platform/chromium-win/editing/inserting/6633727-expected.txt: Removed.
- 9:13 PM Changeset in webkit [56594] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, temporarily disabling test on Chromium bots.
- platform/chromium/test_expectations.txt:
- 8:04 PM Changeset in webkit [56593] by
-
- 2 edits in trunk/WebKitTools
Remove a printf that was causing commit-log-editor to spew the name of the editor
to the terminal many times during a commit.
- Scripts/commit-log-editor:
- 8:04 PM Changeset in webkit [56592] by
-
- 8 edits in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629
This function requires knowledge of ChangeLogs, but scm shouldn't know
about ChangeLogs.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
- Scripts/webkitpy/tool/steps/commit.py:
- 7:46 PM Changeset in webkit [56591] by
-
- 7 edits20 adds in trunk
2010-03-25 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Implement allow-top-navigation for HTML5 sandbox attribute
https://bugs.webkit.org/show_bug.cgi?id=36549
Test various cases relating to navigating top level frames and the
allow-top-navigation directive. This feature is tricky to test
exhaustively because there are a lot of permutations.
- fast/frames/resources/fail-and-notify-done.html: Added.
- fast/frames/resources/navigate-top-by-constant-name-to-pass.html: Added.
- fast/frames/resources/navigate-top-by-constant-name2-to-pass.html: Added.
- fast/frames/resources/navigate-top-by-name-to-fail.html: Added.
- fast/frames/resources/navigate-top-by-name-to-pass.html: Added.
- fast/frames/resources/navigate-top-to-fail.html: Added.
- fast/frames/resources/navigate-top-to-pass.html: Added.
- fast/frames/resources/pass-and-notify-done.html: Added.
- fast/frames/sandboxed-iframe-navigation-top-by-constant-name-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html: Added.
- fast/frames/sandboxed-iframe-navigation-top-by-constant-name2-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html: Added.
- fast/frames/sandboxed-iframe-navigation-top-by-name-denied-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html: Added.
- fast/frames/sandboxed-iframe-navigation-top-by-name-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-top-by-name.html: Added.
- fast/frames/sandboxed-iframe-navigation-top-denied-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-top-denied.html: Added.
- fast/frames/sandboxed-iframe-navigation-top-expected.txt: Added.
- fast/frames/sandboxed-iframe-navigation-top.html: Added.
2010-03-25 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Implement allow-top-navigation for HTML5 sandbox attribute
https://bugs.webkit.org/show_bug.cgi?id=36549
Tests: fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html
fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html
fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html
fast/frames/sandboxed-iframe-navigation-top-by-name.html
fast/frames/sandboxed-iframe-navigation-top-denied.html
fast/frames/sandboxed-iframe-navigation-top.html
- bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): Moved the security check to FrameLoader because we need to allow window.open navigation to succeed sometimes when the SandboxNavigation bit is set.
- html/HTMLIFrameElement.cpp: (WebCore::parseSandboxAttribute): Added allow-top-navigation to the parser.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): The SandboxNavigation check now occurs after we search for the frame by name. Notice that the named frame navigation case is caught by the generic navigation access check. (WebCore::FrameLoader::shouldAllowNavigation): Update the navigation access check to allow navigating of top unless it's forbidden.
- loader/FrameLoaderTypes.h: Introduce a bit for SandboxedTopNavigation. (WebCore::):
- 7:32 PM Changeset in webkit [56590] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Mark Rowe.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): Re-fetch host proxy in a way that works in a function that doesn't have a pluginID argument for some reason.
- 7:21 PM Changeset in webkit [56589] by
-
- 2 edits in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: webkit-patch land can't land "rubber-stamped" patches
https://bugs.webkit.org/show_bug.cgi?id=36582
Allow a "-" in rubber stamped.
- Scripts/webkitpy/tool/steps/validatereviewer.py:
- 7:12 PM Changeset in webkit [56588] by
-
- 5 edits in trunk
Unreviewed, Chromium build fix.
WebCore:
V8CustomVoidCallback should not check if a return value is a
boolean. It should only convert the value to a boolean.
- bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
LayoutTests:
Update the expectations for statement-error-callback.html for Chromium.
- platform/chromium-mac/storage/statement-error-callback-expected.txt:
- platform/chromium-win/storage/statement-error-callback-expected.txt:
- 6:48 PM Changeset in webkit [56587] by
-
- 4 edits in trunk/WebCore
Revert "2010-03-25 Laszlo Gombos <Laszlo Gombos>"
This reverts commit 2a3b308efc33f4829fe9717d93a4b245d3b25f6d.
- 6:26 PM Changeset in webkit [56586] by
-
- 14 edits in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed. Fix some copyright lines to remove extraneous comma and
python directive.
- Scripts/webkitpy/tool/bot/patchcollection.py:
- Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/comments.py:
- Scripts/webkitpy/tool/grammar.py:
- Scripts/webkitpy/tool/multicommandtool.py:
- Scripts/webkitpy/tool/multicommandtool_unittest.py:
- 6:04 PM Changeset in webkit [56585] by
-
- 4 edits in trunk/WebCore
2010-03-25 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Fix build if NPAPI support is disabled
https://bugs.webkit.org/show_bug.cgi?id=36621
No new tests, this is a build fix.
- plugins/PluginView.cpp: Guard getValueStatic() with NETSCAPE_PLUGIN_API (WebCore::PluginView::getValue):
- plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
- plugins/PluginViewNone.cpp: Guard platformGetValue() and platformGetValueStatic with NETSCAPE_PLUGIN_API; Guard privateBrowsingStateChanged() and setJavaScriptPaused() with PLATFORM(MAC)
- 5:53 PM Changeset in webkit [56584] by
-
- 6 edits in trunk/LayoutTests
Not reviewed, update pixel results for Chromium bots.
The rendering of these tests was changed by http://trac.webkit.org/changeset/56507.
Also updated Chromium's test_expectations.txt.
- platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
- platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
- platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
- platform/chromium-linux/plugins/embed-attributes-style-expected.png:
- platform/chromium/test_expectations.txt: Use BUG_WKXXXX instead of WKXXXX notation to appease validation on the bot.
- 5:46 PM Changeset in webkit [56583] by
-
- 4 edits in trunk/WebKitTools
2010-03-25 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler, Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=36631
Allow the test plugin to run scripts in response to NPP_SetWindow calls
Hook up the ability for the TestNetscapePlugIn to run JavaScript in
response to NPP_SetWindow.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginAllocate):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_Destroy): (NPP_SetWindow):
- 5:26 PM Changeset in webkit [56582] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fixing Chromium test bots.
[chromium] REGRESSION: Some LayoutTests fail after r56567
https://bugs.webkit.org/show_bug.cgi?id=36630
- platform/chromium/test_expectations.txt: Update expectations.
- 5:24 PM Changeset in webkit [56581] by
-
- 3 edits in trunk/WebKit/qt
2010-03-25 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtLauncher crashes on Mac OS and Linux when exiting with QGraphicsView mode enabled
https://bugs.webkit.org/show_bug.cgi?id=35251
Followed the way QWebView registers for the signal QWebPage::destroyed(), to prevent
QGraphicsWebView from referencing QWebPage after it was deleted.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_pageDestroyed): (QGraphicsWebView::setPage):
- Api/qgraphicswebview.h:
- 5:06 PM Changeset in webkit [56580] by
-
- 9 edits in trunk
2010-03-25 Drew Wilson <atwilson@chromium.org>
Reviewed by Nate Chapin.
[v8] Error in getScriptExecutionContext() when worker context is terminating.
https://bugs.webkit.org/show_bug.cgi?id=36565
Removed WorkerScriptExecutionProxy::retrieve() and added WorkerScriptController::controllerForContext(). This allows
callers to differentiate between "the current context is shutting down" vs "the current context is not a worker context".
Test: Existing worker tests suffice.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
- bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
- bindings/v8/WorkerContextExecutionProxy.cpp: Removed WorkerScriptExecutionProxy::retrieve().
- bindings/v8/WorkerContextExecutionProxy.h: Removed WorkerScriptExecutionProxy::retrieve().
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::controllerForContext): Added helper function to get the WorkerScriptController for the current context.
- bindings/v8/WorkerScriptController.h: Added declaration for controllerForContext().
2010-03-25 Drew Wilson <atwilson@chromium.org>
Reviewed by Nate Chapin.
[v8] Error in getScriptExecutionContext() when worker context is terminating
https://bugs.webkit.org/show_bug.cgi?id=36565
Test: Existing worker tests suffice.
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::createWorkerContextProxy): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
- 4:48 PM Changeset in webkit [56579] by
-
- 4 edits1 add in trunk/WebKit/chromium
2010-03-25 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add an ASSERT macro to the Chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36545
- WebKit.gyp: Add WebCommon.cpp
- public/WebCommon.h: Add the Macro.
- public/WebPrivatePtr.h: (WebKit::WebPrivatePtr::~WebPrivatePtr): Verify the pointer is now 0.
- src/WebCommon.cpp: Added. (WebKit::failedAssertion): Calls the WTF assert function and then crashes.
- 4:33 PM Changeset in webkit [56578] by
-
- 3 edits in trunk/LayoutTests
2010-03-25 Gustavo Noronha Silva <Gustavo Noronha Silva>
Needs a "LinuxEditingBehavior", perhaps with a better name
https://bugs.webkit.org/show_bug.cgi?id=36627
Skipping tests that started failing after 56567. We need to figure
out a proper fix, that may involve adding a new editing behavior
for our platform.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 4:30 PM Changeset in webkit [56577] by
-
- 2 edits in trunk/WebKit/qt
2010-03-25 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] QWebFrame::pageChanged() signal is not documented
https://bugs.webkit.org/show_bug.cgi?id=36609
- Api/qwebframe.cpp:
- 4:12 PM Changeset in webkit [56576] by
-
- 2 edits in trunk/WebCore
2010-03-25 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix the package build on Maemo 5
Always embed the stylesheet for the no-listbox rendering. This way it'll be
included in the generated files for the package generation.
- WebCore.pri:
- 4:09 PM Changeset in webkit [56575] by
-
- 2 edits in trunk/WebKitTools
2010-03-25 Laszlo Gombos <Laszlo Gombos>
Unreviewed, build fix.
[Qt] Fix QtLauncher guards.
- QtLauncher/main.cpp: (LauncherWindow::showFPS): (LauncherWindow::updateFPS):
- 3:49 PM Changeset in webkit [56574] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-03-25 Reinout van Schouwen <reinouts@gnome.org>
Reviewed by Gustavo Noronha.
Updated Dutch translation
https://bugs.webkit.org/show_bug.cgi?id=36432
- nl.po:
- 3:38 PM Changeset in webkit [56573] by
-
- 2 edits in trunk/LayoutTests
2010-03-25 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, expectations tweak.
Reorganized and updated comments for media test expectations.
- platform/chromium/test_expectations.txt: Tweaked.
- 3:29 PM Changeset in webkit [56572] by
-
- 8 edits in trunk
WebCore: Changing the V8 and JSC implementations of
SQLStatementErrorCallback to interpret as false all results that
could be converted to a false boolean. Pretty much a revert of
r54981.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=36569
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
- bindings/v8/custom/V8CustomVoidCallback.h:
LayoutTests: Updating the test to conform to the latest spec changes.
Reviewed by Dimitri Glazkov.
- storage/statement-error-callback-expected.txt:
- storage/statement-error-callback.html:
- 3:25 PM Changeset in webkit [56571] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-25 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Remove ASSERT(isMainThread()) which is violated for workers and not necessary at this point.
https://bugs.webkit.org/show_bug.cgi?id=36614
- src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
- 2:58 PM Changeset in webkit [56570] by
-
- 2 edits in trunk/WebCore
Unreviewed, fix Chromium tests.
Recent http://trac.webkit.org/changeset/56489 made all urls in Chromium that
have unspecified port to return invalidPortNumber from KURL::port().
- platform/KURLGoogle.cpp: Return 0 for unspecified ports, mimic WebKit KURL behavior for invalid ports.
(WebCore::KURL::port):
- 2:39 PM Changeset in webkit [56569] by
-
- 3 edits in trunk/WebCore
2010-03-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
This is a follow up of:
https://bugs.webkit.org/show_bug.cgi?id=30055
Bad DOM performance in large SVG files
Just save and restore the GraphicsContext, if we realy modify it.
(Cairo)Path::contains checks if a point is in the boundingBox
as a heuristic. The intention was to make the process faster for
points outside of this rect, but it rather causes the
opposite.
No new test cases added. No change in functionality.
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::contains):
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- 2:33 PM Changeset in webkit [56568] by
-
- 2 edits in trunk/WebCore
2010-03-25 Simon Fraser <Simon Fraser>
Revert r56565 which was based on an incorrect premise.
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):
- 1:21 PM Changeset in webkit [56567] by
-
- 11 edits8 deletes in trunk
2010-03-25 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
mouse-based selections are always directional on Window/Linux
https://bugs.webkit.org/show_bug.cgi?id=25195
The tests are modified to expect different things for Win/Linux vs. Mac.
- editing/selection/5195166-1.html:
- editing/selection/extend-after-mouse-selection.html:
- editing/selection/extend-selection-after-double-click-expected.txt:
- editing/selection/extend-selection-after-double-click.html:
- platform/chromium-linux/editing/selection/5195166-1-expected.checksum: Removed.
- platform/chromium-linux/editing/selection/5195166-1-expected.png: Removed.
- platform/chromium-win/editing/selection/5195166-1-expected.checksum: Removed.
- platform/chromium-win/editing/selection/5195166-1-expected.png: Removed.
- platform/chromium-win/editing/selection/5195166-1-expected.txt: Removed.
- platform/mac/editing/selection/5195166-1-expected.checksum: Removed.
- platform/mac/editing/selection/5195166-1-expected.png: Removed.
- platform/mac/editing/selection/5195166-1-expected.txt:
- platform/qt/editing/selection/5195166-1-expected.txt: Removed.
- platform/win/editing/selection/extend-after-mouse-selection-expected.txt:
2010-03-25 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
mouse-based selections are always directional on Windows/Linux
https://bugs.webkit.org/show_bug.cgi?id=25195
Change m_lastChangeWasHorizontalExtension to m_isDirectional
and make m_isDirectional always be true for Windows/Linux.
- editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::setIsDirectional): (WebCore::SelectionController::willBeModified): When double-clicking, the base/extent will be in the middle of the selection instead of the start/end of it. Changed to maintain that modifications after double-click still move the start/end of the selection, not the base/extent. (WebCore::SelectionController::modify):
- editing/SelectionController.h:
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag):
- 1:20 PM Changeset in webkit [56566] by
-
- 11 edits in trunk/WebKitTools
2010-03-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldEnableDeveloperExtras): (runTest):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
- DumpRenderTree/mac/DumpRenderTree.mm: (shouldEnableDeveloperExtras): (runTest):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::shouldEnableDeveloperExtras): (WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::closeWebInspector): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::setJavaScriptProfilingEnabled):
- DumpRenderTree/win/DumpRenderTree.cpp: (shouldEnableDeveloperExtras): (runTest):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
- 12:57 PM Changeset in webkit [56565] by
-
- 2 edits in trunk/WebCore
2010-03-25 Simon Fraser <Simon Fraser>
Reviewed by Eric Carlson.
Make calls to m_keyframeAnimations.checkConsistency() debug-only
https://bugs.webkit.org/show_bug.cgi?id=36555
Remove lots of calls to m_keyframeAnimations.checkConsistency(); which were left after some earlier
debugging. Leave one in CompositeAnimation::animate() to catch any future issues, which is OK since
these calls are no-ops in release builds.
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):
- 12:07 PM Changeset in webkit [56564] by
-
- 2 edits in trunk/WebKit/mac
2010-03-25 Simon Fraser <Simon Fraser>
Build fix: no review.
Another c_str() -> data().
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate):
- 11:58 AM Changeset in webkit [56563] by
-
- 2 edits in trunk/JavaScriptCore
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
Reviewed by NOBODY (build fix).
- 11:48 AM Changeset in webkit [56562] by
-
- 3 edits6 adds in trunk
2010-03-25 Simon Fraser <Simon Fraser>
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=36557
Animations use the wrong timing-function sometimes
Fix an issue where animations picked the wrong style for their "unanimated" value.
Previously, the "unanimated" style was considered to be the style before the animation
was applied. This caused us to pick up stale values for animation timing functions, for
blending when a property is missing from the first keyframe, and for resuming transitions
once an animation ends.
Instead, we need to use the "current" style, which is the one that causes the animation
to kick off.
Tests: animations/longhand-timing-function.html
animations/transition-and-animation-3.html
animations/unanimated-style.html
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
- 11:37 AM WebKit Team edited by
- Updated link to committers.py. (diff)
- 11:29 AM Changeset in webkit [56561] by
-
- 2 edits in trunk/LayoutTests
Unreviewed expected file fix.
- platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Needless newline removed.
- 11:20 AM Changeset in webkit [56560] by
-
- 16 edits in trunk
Bug 36611 - Cleanup JSC::CString
Rename CString::c_str() -> CString::data(), CString::size() -> CString::length(),
remove UString::getCString() (all uses are wrong, should use UString::UTF8String()).
Reviewed by Geoff Garen.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
- jsc.cpp:
(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):
- profiler/CallIdentifier.h:
(JSC::CallIdentifier::c_str):
- profiler/Profile.cpp:
(JSC::Profile::debugPrintDataSampleStyle):
- profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
- runtime/DateConversion.cpp:
(JSC::parseDate):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::globalFuncJSCPrint):
- runtime/UString.cpp:
(JSC::operator==):
(JSC::UString::toDouble):
- runtime/UString.h:
(JSC::CString::length):
(JSC::CString::data):
WebCore:
- bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
- bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
- bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
- bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::UTF8String):
- 11:03 AM Changeset in webkit [56559] by
-
- 7 edits in trunk/LayoutTests
2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>
Rubber-stamped by Tor Arne Vestbø.
[Qt] Update test results after r56555.
https://bugs.webkit.org/show_bug.cgi?id=36413
- platform/qt/fast/forms/basic-inputs-expected.txt:
- platform/qt/fast/forms/isindex-placeholder-expected.txt:
- platform/qt/fast/forms/text-style-color-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:
- 11:00 AM Changeset in webkit [56558] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Mark Rowe.
Correctness fix after r56493.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): We still need to update our hostProxy reference, even though we didn't use to have instanceProxy. Nothing guarantees that the host proxy won't go away while the open panel is up.
- 10:51 AM Changeset in webkit [56557] by
-
- 2 edits in trunk/LayoutTests
2010-03-25 Antonio Gomes <tonikitoo@webkit.org>
Unreview expectation result fix.
After http://trac.webkit.org/changeset/56547, the test needs new (and proper)
results.
- platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt:
- 10:39 AM Changeset in webkit [56556] by
-
- 2 edits in trunk/WebKitSite
2010-03-25 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Levin.
Asking Questions Page Grammar Fixes
https://bugs.webkit.org/show_bug.cgi?id=36608
- asking_questions.html:
- 10:30 AM Changeset in webkit [56555] by
-
- 6 edits in trunk
2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Eric Seidel.
[Qt] RenderTheme: fix size adjustment for text fields
https://bugs.webkit.org/show_bug.cgi?id=36413
Update test results after RenderTheme changes.
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:
2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Eric Seidel.
[Qt] RenderTheme: fix size adjustment for text fields
https://bugs.webkit.org/show_bug.cgi?id=36413
To match other ports, remove the hardcoded dimensions for text fields so that
the default ones from WebCore can be used.
Properly apply the correct padding to text areas - this fixes their appearance
with the Oxygen style.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
- 10:21 AM Changeset in webkit [56554] by
-
- 4 edits in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Rubber stamped by Eric Seidel.
Tweaks to sheriffbot to improve latency by keeping the working copy up
to date even when there's no build break. Also, officially move
sheriffbot to #webkit.
(Also teach ValidateReviewer to understand rubber stamps.)
- Scripts/webkitpy/common/net/irc/ircbot.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/steps/validatereviewer.py:
- 10:18 AM Changeset in webkit [56553] by
-
- 4 edits in trunk/WebKitTools
Not displaying FPS info on the terminal. On S60 and Maemo the Window title will be used and Status bar will used on desktop.
Reviewed by Simon Hausmann.
Patch by Jesus Palencia <jesus.palencia@openbossa.org>
[Qt] QtLauncher's FPS info should not be displayed on the terminal
https://bugs.webkit.org/show_bug.cgi?id=36244
- QtLauncher/main.cpp:
(LauncherWindow::initializeView):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):
- QtLauncher/webview.cpp:
(WebViewGraphicsBased::setFrameRateMeasurementEnabled):
(WebViewGraphicsBased::updateFrameRate):
- QtLauncher/webview.h:
(WebViewGraphicsBased::frameRateMeasurementEnabled):
- 9:42 AM Changeset in webkit [56552] by
-
- 6 edits in trunk
[Qt] Implement ChromeClient::windowResizerRect()
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=21300
We assume the resize corner to be in the lower right corner of
the window and having the width and height of the scrollbars.
The helper function geometryRelativeToOwnerWidget() in the page
client is used to clip the resize rect to the actual size of the
viewport, not the size of the QGraphicsView.
- 9:31 AM Changeset in webkit [56551] by
-
- 2 edits in trunk/WebKitSite
2010-03-25 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
New Asking Questions Page is not Valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=36605
- asking_questions.html: fixed issues raised by the validator.
- 9:18 AM Changeset in webkit [56550] by
-
- 4 edits in trunk/LayoutTests
[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html
fails after r56394
https://bugs.webkit.org/show_bug.cgi?id=36531
Reviewed by Alexey Proskuryakov.
The test was assuming that we would receive 3 progress events which may not be the case anymore
due to the event throttling added in r56394.
- http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Removed
the counting as it belonged to the original version of the test and instead use the position
to determine when to reset the XHR.
- platform/gtk/Skipped:
- platform/qt/Skipped:
Removed the test from the Skipped lists now that it should pass.
- 9:09 AM Changeset in webkit [56549] by
-
- 2 edits in trunk/WebCore
2010-03-25 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: reloading debug target window with cmd-R from inspector window produces beep.
https://bugs.webkit.org/show_bug.cgi?id=36554
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown): prevent the default behavior, if handled, which would result in a system beep.
- 8:49 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:25 AM Changeset in webkit [56548] by
-
- 7 edits in trunk
2010-03-25 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Forward DatabaseTracker::canEstablishDatabase to chromium layer.
https://bugs.webkit.org/show_bug.cgi?id=36595
- storage/chromium/DatabaseObserver.h:
- storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::canEstablishDatabase):
2010-03-25 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Forward DatabaseTracker::canEstablishDatabase to chromium layer.
https://bugs.webkit.org/show_bug.cgi?id=36595
- public/WebFrameClient.h: (WebKit::WebFrameClient::allowDatabase):
- src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
- src/WebWorkerBase.h: (WebKit::WebWorkerBase::allowDatabase):
- 8:24 AM Changeset in webkit [56547] by
-
- 5 edits in trunk
Added missing frame flattening activation on fast/frames/flattening/frameset-flattening-grid.html; removed unnecessary CONSOLE MESSAGE from the expected file; reset the setFrameSetFlatteningEnabled for each test.
Reviewed by Kenneth Christiansen.
Patch by Diego Gonzalez <diego.gonzalez@openbossa.org>
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings):
LayoutTests:
- fast/frames/flattening/frameset-flattening-grid.html:
- platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt:
- 8:06 AM Changeset in webkit [56546] by
-
- 4 edits in trunk/WebCore
2010-03-25 yael aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Windowed netscape plugins don't work with QGraphicsWebView on Symbian
https://bugs.webkit.org/show_bug.cgi?id=35112
Add a proxy widget when loading a QWidget based plugin in a QGraphicsWebView.
- plugins/symbian/PluginContainerSymbian.cpp: (PluginContainerSymbian::PluginContainerSymbian): (PluginContainerSymbian::focusInEvent):
- plugins/symbian/PluginContainerSymbian.h: (WebCore::PluginContainerSymbian::proxy):
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
- 8:04 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:04 AM Changeset in webkit [56545] by
-
- 3 edits in trunk/WebKitTools
Moved deprecated_logging unit test import statement from
webkitpy/unittests.py to webkitpy/common/system/unittests.py.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36093
This is part of the master bug to reorganize webkitpy.
- Scripts/webkitpy/common/system/unittests.py:
- Scripts/webkitpy/unittests.py:
- 7:46 AM Changeset in webkit [56544] by
-
- 40 edits2 moves in trunk/WebKitTools
Moved webkit_logging.py to common/system/deprecated_logging.py
inside webkitpy.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36093
This is part of the master bug to reorganize webkitpy.
- Scripts/validate-committer-lists:
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/credentials.py:
- Scripts/webkitpy/common/net/irc/ircproxy.py:
- Scripts/webkitpy/common/net/networktransaction.py:
- Scripts/webkitpy/common/net/statusserver.py:
- Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
- Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/openbugs.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/stepsequence.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/multicommandtool.py:
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Scripts/webkitpy/tool/steps/applypatch.py:
- Scripts/webkitpy/tool/steps/build.py:
- Scripts/webkitpy/tool/steps/checkstyle.py:
- Scripts/webkitpy/tool/steps/closebug.py:
- Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
- Scripts/webkitpy/tool/steps/confirmdiff.py:
- Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
- Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
- Scripts/webkitpy/tool/steps/obsoletepatches.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
- Scripts/webkitpy/tool/steps/runtests.py:
- Scripts/webkitpy/tool/steps/update.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
- Scripts/webkitpy/tool/steps/validatereviewer.py:
- Scripts/webkitpy/unittests.py:
- Scripts/webkitpy/webkit_logging.py: Removed.
- Scripts/webkitpy/webkit_logging_unittest.py: Removed.
- 7:31 AM Changeset in webkit [56543] by
-
- 5 edits2 adds in trunk
2010-03-25 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=35714
Computed style on delayed transform animations is incorrect
When fetching computed style while a delayed accelerated animation is in effect,
we would get the value form the first keyframe, rather than getting the current
style.
Fix by checking to see whether we've in the delay phase (with no backwards-fill)
in KeyframeAnimation::getAnimatedStyle().
Test: compositing/animation/computed-style-during-delay.html
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::getAnimatedStyle):
- 7:31 AM Changeset in webkit [56542] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Additional refptr/passrefptr workarounds for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=28054
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12
Reviewed by Tor Arne Vestbø.
- wtf/PassRefPtr.h:
(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):
- wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::::operator):
- 7:27 AM Changeset in webkit [56541] by
-
- 2 edits1 add in trunk/WebKitSite
Add a page on how to ask questions
https://bugs.webkit.org/show_bug.cgi?id=35223
Reviewed by David Levin.
- asking_questions.html: Added.
Add a page on how to ask questions based on Ariya Hidayat's mail: how
to get help effectively
(http://article.gmane.org/gmane.os.opendarwin.webkit.user/145/match=get+help+effectively)
- contact.html: Tweaked the wording to make it more clear what the
mailing list are used for. Also changed the formatting to better
underline the different mailing lists.
- 7:14 AM PythonGuidelines edited by
- Added note on cleaning *.pyc files. (diff)
- 7:13 AM Changeset in webkit [56540] by
-
- 2 edits in trunk/WebKitTools
commit-log-editor can call itself in an infinite loop
https://bugs.webkit.org/show_bug.cgi?id=35291
Reviewed by Kenneth Rohde Christiansen.
if $editor ends up being commit-log-editor, the script will exec itself
in an infinite loop.
To avoid this, we now check that the $editor variable is not
commit-log-editor to avoid this case.
- Scripts/commit-log-editor: Added an isCommitLogEditor method and
reworked the $editor setting to add this check.
- 7:04 AM Changeset in webkit [56539] by
-
- 2 edits in trunk/WebKitTools
2010-03-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Add a Toggle Frame Flattening option to QtLauncher.
It will be enabled by default on Maemo5 and S60 platforms.
[Qt] Add enable/disable Frame Flattening option to QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=36558
- QtLauncher/main.cpp: (LauncherWindow::applyPrefs): (LauncherWindow::toggleFrameFlattening): (LauncherWindow::createChrome):
- 6:45 AM Changeset in webkit [56538] by
-
- 2 edits in trunk/WebCore
2010-03-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Initialize Web Inspector title with inspected page URL when opening Web Inspector.
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontend):
- 6:43 AM Changeset in webkit [56537] by
-
- 2 edits in trunk/WebKit/qt
2010-03-25 Shu Chang <chang.shu@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Added documentation for delete button.
https://bugs.webkit.org/show_bug.cgi?id=31560
- Api/qwebsettings.cpp:
- 6:21 AM Changeset in webkit [56536] by
-
- 2 edits in trunk/WebKit/qt
2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Eric Seidel.
[Qt]Fix compile error with QT_NO_DESKTOPSERVICES
https://bugs.webkit.org/show_bug.cgi?id=36533
- Api/qwebsettings.cpp: (QWebSettings::enablePersistentStorage):
- 6:02 AM Changeset in webkit [56535] by
-
- 2 edits in trunk/WebCore
2010-03-25 Antti Koivisto <koivisto@iki.fi>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=36316
Tiles of selected content do not update if not in viewport
Don't clip repaints to viewport when tiling is enabled.
- page/Frame.cpp: (WebCore::Frame::setView): (WebCore::Frame::setTiledBackingStoreEnabled):
- 5:43 AM Changeset in webkit [56534] by
-
- 4 edits in trunk
2010-03-25 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Eric Seidel.
Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros
on WebKit.pri
[Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros
https://bugs.webkit.org/show_bug.cgi?id=36547
- platform/qt/Skipped:
2010-03-25 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Eric Seidel.
Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros
on WebKit.pri
[Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros
https://bugs.webkit.org/show_bug.cgi?id=36547
- WebCore.pri:
- 5:22 AM Changeset in webkit [56533] by
-
- 2 edits in trunk/WebKit/qt
2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Eric Seidel.
[Qt]Fix compile error with QT_NO_DEBUG_STREAM
https://bugs.webkit.org/show_bug.cgi?id=36533
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::graphicsItemVisibleRect):
- 5:19 AM Changeset in webkit [56532] by
-
- 3 edits in trunk/WebCore
2010-03-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Expect console object wrapping to fail.
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 5:03 AM Changeset in webkit [56531] by
-
- 4 edits in trunk/WebKit/gtk
2010-03-25 Sergio Villar Senín <svillar@igalia.com>
Reviewed by Xan Lopez.
Added new API webkit_web_back_forward_list_clear. This function
clears the back forward list
[GTK] http/history tests are failing
https://bugs.webkit.org/show_bug.cgi?id=36173
- tests/testwebbackforwardlist.c: (test_webkit_web_back_forward_list_clear): (main): added new unit test for the new API
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_clear):
- webkit/webkitwebbackforwardlist.h: new function that clears the back forward list
- 4:44 AM Changeset in webkit [56530] by
-
- 3 edits2 adds in trunk
2010-03-25 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=36371
[Gtk] Elements with a title attribute should not be ignored
- platform/gtk/accessibility/object-with-title.html: Added
- platform/gtk/accessibility/object-with-title-expected.txt: Added
2010-03-25 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=36371
[Gtk] Elements with a title attribute should not be ignored
- accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
- 4:23 AM Changeset in webkit [56529] by
-
- 2 edits in trunk/WebKit/qt
2010-03-25 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Eric Seidel.
Make QWebPage not depend on view() but use the client->ownerWidget()
instead. Also, handle the case where there is not page client.
- Api/qwebpage.cpp: (QWebPagePrivate::createContextMenu): (QWebPagePrivate::keyPressEvent): (QWebPage::javaScriptAlert): (QWebPage::javaScriptConfirm): (QWebPage::javaScriptPrompt): (QWebPage::shouldInterruptJavaScript): (QWebPage::createWindow): (QWebPage::action): (QWebPage::extension): (QWebPage::chooseFile): (QWebPage::userAgentForUrl):
- 4:20 AM Changeset in webkit [56528] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Build fix on MSVC. Reverts r55633 for stdint.h
Reviewed by nobody, build fix.
This file gets included in generated moc files which don't
include the prefix header.
- os-win32/stdint.h:
- 3:43 AM PythonGuidelines edited by
- Added note about *.pyc files (diff)
- 3:40 AM Changeset in webkit [56527] by
-
- 2 edits in trunk/WebCore
2010-03-24 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Adds a missing ENABLE(WORKERS) guards to the V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=36550
Build fix only, no new tests.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- 3:33 AM Changeset in webkit [56526] by
-
- 3 edits in trunk/WebCore
2010-03-25 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Eric Seidel.
Add EFL-specific code to platform/ScrollView.cpp and
platform/Scrollbar.cpp.
http://webkit.org/b/36305
- platform/ScrollView.cpp:
- platform/Scrollbar.cpp:
- 3:30 AM PythonGuidelines edited by
- Added Basics and Code Structure sub-sections (diff)
- 3:12 AM Changeset in webkit [56525] by
-
- 3 edits in trunk/WebCore
2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Eric Seidel.
[Qt]Fix compile error with QT_NO_LIBRARY
https://bugs.webkit.org/show_bug.cgi?id=36533
- platform/FileSystem.h:
- platform/qt/FileSystemQt.cpp: (WebCore::unloadModule):
- 2:46 AM Changeset in webkit [56524] by
-
- 2 edits in trunk/WebKitTools
2010-03-25 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
svn-create-patch prints a warning for large patches
https://bugs.webkit.org/show_bug.cgi?id=32582
svn-create-patch prints a warning message for larger patches than 20k.
- Scripts/svn-create-patch:
- 2:40 AM Changeset in webkit [56523] by
-
- 3 edits in trunk/WebCore
2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Eric Seidel.
[Qt]Fix compile error with QT_NO_ANIMATION
https://bugs.webkit.org/show_bug.cgi?id=36526
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
- platform/graphics/qt/GraphicsLayerQt.h:
- 2:32 AM Changeset in webkit [56522] by
-
- 3 edits2 moves in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed. Renamed early_warning_system.py to earlywarningsystem.py.
https://bugs.webkit.org/show_bug.cgi?id=36093
- Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
- Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/unittests.py:
- 2:30 AM Changeset in webkit [56521] by
-
- 3 edits2 copies1 add in trunk/WebKitTools
In webkitpy, pushed the unit test import statements in
webkitpy/unittests.py into appropriate unittests.py files in the
new root-level packages beneath webkitpy.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36093
This is part of the master bug to reorganize webkitpy.
- Scripts/webkitpy/common/system/unittests.py:
- Scripts/webkitpy/common/unittests.py: Added.
- Scripts/webkitpy/python24/unittests.py: Added.
- Scripts/webkitpy/tool/unittests.py: Added.
- Scripts/webkitpy/unittests.py:
- 2:17 AM Changeset in webkit [56520] by
-
- 3 edits1 move in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed. Move WebKitCheckout into the webkitpy.common.checkout
package.
https://bugs.webkit.org/show_bug.cgi?id=36093
- Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/webkitcheckout.py: Removed.
- 2:11 AM Changeset in webkit [56519] by
-
- 10 edits1 move in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed. Move OutputCapture to webkitpy.common.system.
https://bugs.webkit.org/show_bug.cgi?id=36093
- Scripts/webkitpy/common/net/bugzilla_unittest.py:
- Scripts/webkitpy/common/net/credentials_unittest.py:
- Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
- Scripts/webkitpy/outputcapture.py: Removed.
- Scripts/webkitpy/tool/commands/commandtest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/multicommandtool_unittest.py:
- Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
- 2:05 AM Changeset in webkit [56518] by
-
- 7 edits2 moves in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed. Move user.py to webkitpy.common.system.
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/credentials.py:
- Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
- Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/unittests.py:
- Scripts/webkitpy/user.py: Removed.
- Scripts/webkitpy/user_unittest.py: Removed.
- 2:01 AM Changeset in webkit [56517] by
-
- 19 edits2 moves in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed. Move executive.py to webkitpy.common.system.
https://bugs.webkit.org/show_bug.cgi?id=36093
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Scripts/webkitpy/common/config/ports.py:
- Scripts/webkitpy/common/config/ports_unittest.py:
- Scripts/webkitpy/common/net/credentials.py:
- Scripts/webkitpy/common/net/credentials_unittest.py:
- Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
- Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
- Scripts/webkitpy/executive.py: Removed.
- Scripts/webkitpy/executive_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/early_warning_system.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/stepsequence.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/steps/checkstyle.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- Scripts/webkitpy/unittests.py:
- Scripts/webkitpy/webkit_logging_unittest.py:
- 1:50 AM Changeset in webkit [56516] by
-
- 9 edits2 moves in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed. Move grammary.py into webkitpy.tool.
https://bugs.webkit.org/show_bug.cgi?id=36093
- Scripts/webkitpy/grammar.py: Removed.
- Scripts/webkitpy/grammar_unittest.py: Removed.
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
- Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
- Scripts/webkitpy/tool/multicommandtool.py:
- Scripts/webkitpy/tool/steps/obsoletepatches.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
- Scripts/webkitpy/unittests.py:
- 1:49 AM Changeset in webkit [56515] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-10 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Fix up WebMouseWheelEventBuilder to properly calculate the units
https://bugs.webkit.org/show_bug.cgi?id=35989
- src/WebInputEventConversion.cpp:
- 1:48 AM Changeset in webkit [56514] by
-
- 6 edits1 move in trunk/WebKitTools
In webkitpy, moved init/ to common/system/.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36093
This is part of the master bug to reorganize webkitpy.
- Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
- Scripts/webkitpy/common/system/logutils.py:
- Scripts/webkitpy/common/system/logutils_unittest.py:
- Scripts/webkitpy/init: Removed.
- Scripts/webkitpy/init/init.py: Removed.
- Scripts/webkitpy/init/logtesting.py: Removed.
- Scripts/webkitpy/init/logutils.py: Removed.
- Scripts/webkitpy/init/logutils_unittest.py: Removed.
- Scripts/webkitpy/init/unittests.py: Removed.
- Scripts/webkitpy/python24/versioning_unittest.py:
- Scripts/webkitpy/style_references.py:
- Scripts/webkitpy/unittests.py:
- 1:46 AM Changeset in webkit [56513] by
-
- 2 edits in trunk/WebCore
2010-03-25 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=33697
Have dragOpFromIEOp("move") return DragOperationGeneric | DragOperationMove
because only returning Generic doesn't work for platforms that don't
have a generic operation.
Covered by existing tests (fast/events/drag-and-drop.html).
- dom/Clipboard.cpp: (WebCore::dragOpFromIEOp): (WebCore::Clipboard::destinationOperation): (WebCore::Clipboard::setDestinationOperation):
- 1:42 AM Changeset in webkit [56512] by
-
- 4 edits1 move in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed. Move stepsequence to webkitpy.tool.commands.
https://bugs.webkit.org/show_bug.cgi?id=36093
- Scripts/webkitpy/stepsequence.py: Removed.
- Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.
- 1:38 AM Changeset in webkit [56511] by
-
- 4 edits in trunk
2010-03-25 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
[Qt] websocket/tests/long-invalid-header.html fails
https://bugs.webkit.org/show_bug.cgi?id=36492
- websocket/tests/long-invalid-header-expected.txt: trim console message.
2010-03-25 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
[Qt] websocket/tests/long-invalid-header.html fails
https://bugs.webkit.org/show_bug.cgi?id=36492
trim message at most 128 bytes from the current position.
I believe it's enough data to investigate the error reason and
it makes test not depend on buffered size.
- websockets/WebSocketHandshake.cpp: (WebCore::trimConsoleMessage): (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders):
- 1:34 AM Changeset in webkit [56510] by
-
- 15 edits1 copy8 moves1 add in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed. Create webkitpy.common.checkout as described in
https://bugs.webkit.org/show_bug.cgi?id=36093
- Scripts/webkitpy/changelogs.py: Removed.
- Scripts/webkitpy/changelogs_unittest.py: Removed.
- Scripts/webkitpy/commitinfo.py: Removed.
- Scripts/webkitpy/commitinfo_unittest.py: Removed.
- Scripts/webkitpy/common/checkout: Added.
- Scripts/webkitpy/common/checkout/init.py: Copied from Scripts/webkitpy/common/init.py.
- Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
- Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
- Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
- Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
- Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
- Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
- Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
- Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
- Scripts/webkitpy/common/net/credentials.py:
- Scripts/webkitpy/diff_parser.py: Removed.
- Scripts/webkitpy/diff_parser_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/scm.py: Removed.
- Scripts/webkitpy/scm_unittest.py: Removed.
- Scripts/webkitpy/stepsequence.py:
- Scripts/webkitpy/style_references.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/comments.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
- Scripts/webkitpy/tool/steps/validatereviewer.py:
- Scripts/webkitpy/unittests.py:
- Scripts/webkitpy/webkitcheckout.py:
- 1:02 AM Changeset in webkit [56509] by
-
- 5 edits1 copy2 moves1 add in trunk/WebKitTools
In webkitpy, moved init/versioning.py to python24/.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36093
This is part of the master bug to reorganize webkitpy.
- Scripts/test-webkitpy:
- Scripts/webkit-patch:
- Scripts/webkitpy/init/unittests.py:
- Scripts/webkitpy/init/versioning.py: Removed.
- Scripts/webkitpy/init/versioning_unittest.py: Removed.
- Scripts/webkitpy/python24: Added.
- Scripts/webkitpy/python24/init.py: Copied from WebKitTools/Scripts/webkitpy/tool/init.py.
- Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
- Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
- Scripts/webkitpy/unittests.py:
- 12:52 AM Changeset in webkit [56508] by
-
- 20 edits10 moves2 adds in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed.
Create webkitpy.common.net as described in
https://bugs.webkit.org/show_bug.cgi?id=36093
- Scripts/webkitpy/bugzilla.py: Removed.
- Scripts/webkitpy/bugzilla_unittest.py: Removed.
- Scripts/webkitpy/buildbot.py: Removed.
- Scripts/webkitpy/buildbot_unittest.py: Removed.
- Scripts/webkitpy/commitinfo.py:
- Scripts/webkitpy/common/net: Added.
- Scripts/webkitpy/common/net/init.py: Added.
- Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
- Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
- Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
- Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
- Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
- Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
- Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
- Scripts/webkitpy/common/net/irc/ircbot.py:
- Scripts/webkitpy/common/net/irc/ircproxy.py:
- Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
- Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
- Scripts/webkitpy/common/net/irc/unittests.py:
- Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
- Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
- Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
- Scripts/webkitpy/credentials.py: Removed.
- Scripts/webkitpy/credentials_unittest.py: Removed.
- Scripts/webkitpy/irc: Removed.
- Scripts/webkitpy/irc/init.py: Removed.
- Scripts/webkitpy/irc/ircbot.py: Removed.
- Scripts/webkitpy/irc/ircproxy.py: Removed.
- Scripts/webkitpy/irc/messagepump.py: Removed.
- Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
- Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
- Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
- Scripts/webkitpy/irc/unittests.py: Removed.
- Scripts/webkitpy/networktransaction.py: Removed.
- Scripts/webkitpy/networktransaction_unittest.py: Removed.
- Scripts/webkitpy/scm_unittest.py:
- Scripts/webkitpy/statusserver.py: Removed.
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/queries_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/postdiffforrevert.py:
- Scripts/webkitpy/unittests.py:
- 12:37 AM Changeset in webkit [56507] by
-
- 4 edits in trunk
<rdar://problem/7780798> Missing plug-ins should be represented by text
only, instead of lego block
https://bugs.webkit.org/show_bug.cgi?id=36583
Reviewed by Dan Bernstein.
WebCore:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintReplaced):
Set the font rendering mode and the computed size, so that the text will
draw properly on Windows.
WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
Return 0 if we failed to initialize the plug-in, which causes the new
"missing plug-in" text to draw.
- 12:34 AM Changeset in webkit [56506] by
-
- 2 edits2 adds4 deletes in trunk/LayoutTests
2010-03-25 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Rewrite the layout test editing/inserting/6633727 to use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=31579
- editing/inserting/6633727-expected.txt: Added.
- editing/inserting/6633727.html:
- editing/inserting/script-tests/6633727.js: Added.
- platform/gtk/editing/inserting/6633727-expected.txt: Removed.
- platform/mac/editing/inserting/6633727-expected.checksum: Removed.
- platform/mac/editing/inserting/6633727-expected.png: Removed.
- platform/mac/editing/inserting/6633727-expected.txt: Removed.
- 12:24 AM Changeset in webkit [56505] by
-
- 11 edits in trunk/WebKitTools
In webkitpy, renamed MockBugzillaTool to MockTool.
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/commands/commandtest.py:
- Scripts/webkitpy/tool/commands/queries_unittest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
- 12:18 AM Changeset in webkit [56504] by
-
- 14 edits2 copies4 moves2 adds in trunk/WebKitTools
In Scripts/webkitpy, moved webkitport.py and committers.py into
common/config/ (also creating common/config/).
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36093
This is part of the master bug to reorganize webkitpy.
- Scripts/validate-committer-lists:
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/bugzilla_unittest.py:
- Scripts/webkitpy/changelogs.py:
- Scripts/webkitpy/commitinfo.py:
- Scripts/webkitpy/commitinfo_unittest.py:
- Scripts/webkitpy/committers.py: Removed.
- Scripts/webkitpy/committers_unittest.py: Removed.
- Scripts/webkitpy/common: Added.
- Scripts/webkitpy/common/init.py: Copied from WebKitTools/Scripts/webkitpy/style/init.py.
- Scripts/webkitpy/common/config: Added.
- Scripts/webkitpy/common/config/init.py: Copied from WebKitTools/Scripts/webkitpy/style/init.py.
- Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
- Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
- Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
- Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
- Scripts/webkitpy/mock_bugzillatool.py:
- Scripts/webkitpy/tool/commands/early_warning_system.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Scripts/webkitpy/unittests.py:
- Scripts/webkitpy/webkitport.py: Removed.
- Scripts/webkitpy/webkitport_unittest.py: Removed.
- 12:09 AM Changeset in webkit [56503] by
-
- 10 edits1 move in trunk/WebKitTools
2010-03-25 Adam Barth <abarth@webkit.org>
Unreviewed. Move mock_bugzillatool.py to tool/mocktool.py.
- Scripts/webkitpy/mock_bugzillatool.py: Removed.
- Scripts/webkitpy/tool/commands/commandtest.py:
- Scripts/webkitpy/tool/commands/queries_unittest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
- Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
- 12:07 AM Changeset in webkit [56502] by
-
- 6 edits in trunk
2010-03-24 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
Removing unecessary redraws of LayerSkia contents:
https://bugs.webkit.org/show_bug.cgi?id=36470
Test: No new functionality added, no tests.
- platform/graphics/skia/LayerRendererSkia.cpp: (WebCore::LayerRendererSkia::drawLayerInCanvasRecursive): Debug borders now rendered at composite time rather than update time.
- platform/graphics/skia/LayerSkia.cpp: (WebCore::LayerSkia::updateContents): (WebCore::LayerSkia::drawDebugBorder): Debug border drawing removed from updateContents and split into a separate method that can be called at composite time. (WebCore::LayerSkia::setBounds): Resetting the bounds causes the layer to redraw its contents. (WebCore::LayerSkia::setNeedsDisplay):
- platform/graphics/skia/LayerSkia.h: Added declaration for drawDebugBorders method.
2010-03-24 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
Eliminate unecessary redraws of GraphicsLayer contents when doing accelerated compositing:
https://bugs.webkit.org/show_bug.cgi?id=36470
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): Remove call that forced redrawing the contents of the entire layer hierarchy.
Mar 24, 2010:
- 11:59 PM Changeset in webkit [56501] by
-
- 12 edits3 moves in trunk/WebKitTools
2010-03-24 Adam Barth <abarth@webkit.org>
Unreviewed. Move comments.py and multicommandtool.py to their new
home.
- Scripts/webkitpy/comments.py: Removed.
- Scripts/webkitpy/multicommandtool.py: Removed.
- Scripts/webkitpy/multicommandtool_unittest.py: Removed.
- Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/openbugs.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
- Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
- Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
- Scripts/webkitpy/tool/steps/closepatch.py:
- Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
- Scripts/webkitpy/unittests.py:
- 11:47 PM Changeset in webkit [56500] by
-
- 2 edits in trunk/WebKitTools
2010-03-24 Adam Barth <abarth@webkit.org>
Unreviewed. Fixup one import statement I didn't find because the .pyc
masked the error.
- Scripts/webkitpy/stepsequence.py:
- 11:44 PM Changeset in webkit [56499] by
-
- 4 edits2 moves in trunk/WebKitTools
2010-03-24 Adam Barth <abarth@webkit.org>
Unreviewed. Move queueengine.py to its new home.
- Scripts/webkitpy/queueengine.py: Removed.
- Scripts/webkitpy/queueengine_unittest.py: Removed.
- Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
- Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
- Scripts/webkitpy/tool/commands/early_warning_system.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/unittests.py:
- 11:40 PM Changeset in webkit [56498] by
-
- 3 edits2 moves2 adds in trunk/WebKitTools
2010-03-24 Adam Barth <abarth@webkit.org>
Unreviewed. Move patchcollection.py to its new home.
- Scripts/webkitpy/patchcollection.py: Removed.
- Scripts/webkitpy/patchcollection_unittest.py: Removed.
- Scripts/webkitpy/tool/bot: Added.
- Scripts/webkitpy/tool/bot/init.py: Added.
- Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
- Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/unittests.py:
- 11:27 PM Changeset in webkit [56497] by
-
- 38 edits2 moves in trunk/WebKitTools
In Scripts/webkitpy, moved steps_references.py and the steps
folder into webkitpy/patch.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36093
- Scripts/webkitpy/steps: Removed.
- Scripts/webkitpy/steps/init.py: Removed.
- Scripts/webkitpy/steps/abstractstep.py: Removed.
- Scripts/webkitpy/steps/applypatch.py: Removed.
- Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
- Scripts/webkitpy/steps/build.py: Removed.
- Scripts/webkitpy/steps/checkstyle.py: Removed.
- Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
- Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
- Scripts/webkitpy/steps/closebug.py: Removed.
- Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
- Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
- Scripts/webkitpy/steps/closepatch.py: Removed.
- Scripts/webkitpy/steps/commit.py: Removed.
- Scripts/webkitpy/steps/confirmdiff.py: Removed.
- Scripts/webkitpy/steps/createbug.py: Removed.
- Scripts/webkitpy/steps/editchangelog.py: Removed.
- Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
- Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
- Scripts/webkitpy/steps/metastep.py: Removed.
- Scripts/webkitpy/steps/obsoletepatches.py: Removed.
- Scripts/webkitpy/steps/options.py: Removed.
- Scripts/webkitpy/steps/postdiff.py: Removed.
- Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
- Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
- Scripts/webkitpy/steps/preparechangelog.py: Removed.
- Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
- Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
- Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
- Scripts/webkitpy/steps/revertrevision.py: Removed.
- Scripts/webkitpy/steps/runtests.py: Removed.
- Scripts/webkitpy/steps/steps_unittest.py: Removed.
- Scripts/webkitpy/steps/update.py: Removed.
- Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
- Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
- Scripts/webkitpy/steps/validatereviewer.py: Removed.
- Scripts/webkitpy/steps_references.py: Removed.
- Scripts/webkitpy/stepsequence.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
- Scripts/webkitpy/tool/steps/init.py:
- Scripts/webkitpy/tool/steps/applypatch.py:
- Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
- Scripts/webkitpy/tool/steps/build.py:
- Scripts/webkitpy/tool/steps/checkstyle.py:
- Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
- Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
- Scripts/webkitpy/tool/steps/closebug.py:
- Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
- Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
- Scripts/webkitpy/tool/steps/closepatch.py:
- Scripts/webkitpy/tool/steps/commit.py:
- Scripts/webkitpy/tool/steps/confirmdiff.py:
- Scripts/webkitpy/tool/steps/createbug.py:
- Scripts/webkitpy/tool/steps/editchangelog.py:
- Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
- Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
- Scripts/webkitpy/tool/steps/metastep.py:
- Scripts/webkitpy/tool/steps/obsoletepatches.py:
- Scripts/webkitpy/tool/steps/postdiff.py:
- Scripts/webkitpy/tool/steps/postdiffforcommit.py:
- Scripts/webkitpy/tool/steps/postdiffforrevert.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
- Scripts/webkitpy/tool/steps/promptforbugortitle.py:
- Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
- Scripts/webkitpy/tool/steps/revertrevision.py:
- Scripts/webkitpy/tool/steps/runtests.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Scripts/webkitpy/tool/steps/update.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
- Scripts/webkitpy/tool/steps/validatereviewer.py:
- Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
- Scripts/webkitpy/unittests.py:
- 11:22 PM Changeset in webkit [56496] by
-
- 2 edits in trunk/WebKitTools
2010-03-24 Eric Seidel <eric@webkit.org>
Unreviewed, build fix only.
Abstract LayoutTestResults logic for easier reuse
https://bugs.webkit.org/show_bug.cgi?id=36579
- Scripts/webkitpy/buildbot_unittest.py: Add a missing import.
- 11:15 PM Changeset in webkit [56495] by
-
- 3 edits in trunk/WebKitTools
2010-03-24 Adam Barth <abarth@webkit.org>
Unreviewed. Fix a stray comma to test landing an patch without review.
- Scripts/webkitpy/commitinfo.py:
- 11:10 PM Changeset in webkit [56494] by
-
- 16 edits2 moves in trunk/WebKitTools
In Scripts/webkitpy, moved commands_references.py and the commands
folder into webkitpy/patch.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36483
This is part of master bug 36093 to organize webkitpy.
- Scripts/webkitpy/commands: Removed.
- Scripts/webkitpy/commands/init.py: Removed.
- Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
- Scripts/webkitpy/commands/commandtest.py: Removed.
- Scripts/webkitpy/commands/download.py: Removed.
- Scripts/webkitpy/commands/download_unittest.py: Removed.
- Scripts/webkitpy/commands/early_warning_system.py: Removed.
- Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
- Scripts/webkitpy/commands/openbugs.py: Removed.
- Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
- Scripts/webkitpy/commands/queries.py: Removed.
- Scripts/webkitpy/commands/queries_unittest.py: Removed.
- Scripts/webkitpy/commands/queues.py: Removed.
- Scripts/webkitpy/commands/queues_unittest.py: Removed.
- Scripts/webkitpy/commands/queuestest.py: Removed.
- Scripts/webkitpy/commands/sheriffbot.py: Removed.
- Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
- Scripts/webkitpy/commands/upload.py: Removed.
- Scripts/webkitpy/commands/upload_unittest.py: Removed.
- Scripts/webkitpy/commands_references.py: Removed.
- Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
- Scripts/webkitpy/tool/commands/commandtest.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/early_warning_system.py:
- Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
- Scripts/webkitpy/tool/commands/openbugs_unittest.py:
- Scripts/webkitpy/tool/commands/queries_unittest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/unittests.py:
- 11:07 PM Changeset in webkit [56493] by
-
- 2 edits in trunk/WebKit/mac
Build fix after r56474.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCRunSyncOpenPanel):
- 11:07 PM Changeset in webkit [56492] by
-
- 5 edits in trunk
Revert the portion of r56489 that dealt with port zero as it introduced some test failures.
WebCore:
- platform/KURL.cpp:
(WebCore::KURL::port): Use the "ok" argument to charactersToUIntStrict to determine whether
it was able to successfully parse the string as an unsigned integer, rather than relying on
the fact it returned zero when it failed.
LayoutTests:
- platform/mac/security/block-test-expected.txt:
- security/block-test.html:
- 10:51 PM Changeset in webkit [56491] by
-
- 2 edits1 copy1 move1 delete in trunk/WebKitTools
2010-03-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename webkitpy.patch to webkitpy.tool
https://bugs.webkit.org/show_bug.cgi?id=36580
This is in preparation for the great webkitpy naming cleanup.
- Scripts/webkit-patch:
- Scripts/webkitpy/patch: Removed.
- Scripts/webkitpy/patch/init.py: Removed.
- Scripts/webkitpy/patch/patcher.py: Removed.
- Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
- Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
- Scripts/webkitpy/tool/patcher.py: Removed.
- 10:36 PM Changeset in webkit [56490] by
-
- 2 edits in trunk/WebCore
- platform/text/String.cpp:
(WebCore::putUTF8Triple): Correct capitalization of function name.
(WebCore::String::utf8): Fix C-style casts.
(WebCore::String::fromUTF8): Remove unnecessary newline.
(WebCore::String::fromUTF8WithLatin1Fallback): Use early return.
Reviewed by Sam Weinig.
- 10:26 PM Changeset in webkit [56489] by
-
- 6 edits in trunk
WebKit should treat port numbers outside the valid range as being blacklisted
<http://webkit.org/b/36571> / <rdar://problem/7790908>
Reviewed by Darin Adler.
WebCore:
- platform/KURL.cpp:
(WebCore::KURL::port): Map invalid port numbers to invalidPortNumber.
(WebCore::portAllowed): Add invalidPortNumber to the blacklist.
- platform/KURLGoogle.cpp: invalid port numbers to invalidPortNumber.
(WebCore::KURL::port): Add invalidPortNumber to the blacklist.
Also bring this in to sync with KURL. Having this identical code in two places is stupid.
LayoutTests:
- platform/mac/security/block-test-expected.txt:
- security/block-test.html: Add tests of a few invalid port numbers.
- 10:25 PM Changeset in webkit [56488] by
-
- 4 edits in trunk/WebKitTools
2010-03-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Abstract LayoutTestResults logic for easier reuse
https://bugs.webkit.org/show_bug.cgi?id=36579
- Scripts/webkitpy/buildbot.py:
- Split out logic into new LayoutTestResults class.
- Scripts/webkitpy/buildbot_unittest.py:
- Rename the testing class to match.
- Scripts/webkitpy/commands/queries.py:
- Use the new LayoutTestResults class.
- 10:14 PM Changeset in webkit [56487] by
-
- 4 edits in trunk/WebKitTools
2010-03-24 Eric Seidel <eric@webkit.org>
Reviewed by Eric Seidel.
Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
https://bugs.webkit.org/show_bug.cgi?id=36577
- Scripts/webkitpy/bugzilla.py:
- Move prompt_for_component to User
- Scripts/webkitpy/commands/queries.py:
- Add a missing argument_names declaration.
- Scripts/webkitpy/user.py:
- Add prompt_with_list
- Make staticmethods classmethods for easier mocking
- 9:58 PM Changeset in webkit [56486] by
-
- 3 edits in trunk/LayoutTests
2010-03-24 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=36517
svg/dom/frame-related-api-during-load.html shoud be more self-descriptive.
- svg/dom/frame-related-api-during-load-expected.txt:
- svg/dom/frame-related-api-during-load.html:
- 9:28 PM Changeset in webkit [56485] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Fix bug URL.
- 9:25 PM Changeset in webkit [56484] by
-
- 2 edits in trunk/WebKitTools
<htp://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file
Reviewed by Eric Seidel.
Fixes the following error when committing a file with
"ChangeLog" in the name that isn't a ChangeLog (like
mergeChangeLogs.pl from r56471 and r56472):
$ git commit .
Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
error: There was a problem with the editor 'commit-log-editor'.
Please supply the message using either -m or -F option.
- Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to
the end of the file name when searching for ChangeLog files in a
commit.
- 9:15 PM Changeset in webkit [56483] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged
Reviewed by Eric Seidel.
- Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if
the merge attempt fails.
- 9:15 PM Changeset in webkit [56482] by
-
- 2 edits in trunk/JavaScriptCore
Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.
Reviewed by Sam Weinig.
- JavaScriptCore.exp:
- 9:08 PM Changeset in webkit [56481] by
-
- 13 edits in trunk/LayoutTests
2010-03-24 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson, Eric Seidel and David Levin.
Update a few more media layout tests to choose test clips based on codec support.
- media/audio-constructor-src.html: Switched to use findMediaFile().
- media/audio-play-event-expected.txt: Updated results.
- media/audio-play-event.html: Switched to use findMediaFile().
- media/video-no-audio.html: Ditto.
- media/video-source-add-src.html: Ditto.
- media/video-src-change.html: Closed p tag.
- platform/mac-leopard/media/video-no-audio-expected.checksum: New results due to changing source video.
- platform/mac-leopard/media/video-no-audio-expected.png: Ditto.
- platform/mac-leopard/media/video-no-audio-expected.txt: Ditto.
- platform/mac/media/video-no-audio-expected.checksum: Ditto.
- platform/mac/media/video-no-audio-expected.png: Ditto.
- platform/mac/media/video-no-audio-expected.txt: Ditto.
- 9:07 PM Changeset in webkit [56480] by
-
- 2 edits in trunk/JavaScriptCore
Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.
Reviewed by Sam Weinig.
- JavaScriptCore.exp:
- 8:56 PM Changeset in webkit [56479] by
-
- 2 edits in trunk/WebCore
Add some missing exports.
Reviewed by Mark Rowe.
- WebCore.base.exp:
- 8:45 PM Changeset in webkit [56478] by
-
- 7 edits1 add in trunk/WebKitTools
2010-03-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch or pre-commit hook should validate reviewer lines before committing
https://bugs.webkit.org/show_bug.cgi?id=26927
Validate that patches have valid reivewers listed in their ChangeLogs
before landing. For patches without reviewers can be landed if their
ChangeLogs state that they are unreviewed.
- Scripts/webkitpy/changelogs.py:
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commitinfo.py:
- Scripts/webkitpy/commitinfo_unittest.py:
- Scripts/webkitpy/mock_bugzillatool.py:
- Scripts/webkitpy/steps/init.py:
- Scripts/webkitpy/steps/validatereviewer.py: Added.
- 8:43 PM Changeset in webkit [56477] by
-
- 2 edits in trunk/WebCore
Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.
Reviewed by Sam Weinig.
- platform/text/String.cpp:
(WebCore::String::latin1):
(WebCore::putUTF8triple):
(WebCore::String::utf8):
(WebCore::String::fromUTF8):
- 6:10 PM Changeset in webkit [56476] by
-
- 1 edit in trunk/WebCore/ChangeLog
Restore peace and justice to the universe.
- 6:06 PM Changeset in webkit [56475] by
-
- 5 edits in trunk/WebKitTools
Undefined names reported by pyflakes in python scripts
ttps://bugs.webkit.org/show_bug.cgi?id=36403
Attempt to use names that exist or can exist in the lexical
scope instead of not being available at all.
- Scripts/webkitpy/changelogs.py: Use self._content.
- Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
- Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re
- 5:52 PM Changeset in webkit [56474] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=36563
A plug-in makes Safari crash on http://www.itscodingtime.com/
- Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::port): Assert that the object is still alive. This isn't beautifully systemic, but helped catch a bug, and may help catch more. (WebKit::NetscapePluginHostProxy::clientPort): Ditto. (WebKit::NetscapePluginHostProxy::isProcessingRequests): Changed m_processingRequests to a static. This doesn't change behavior much, but helps avoid writing into deallocated memory.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Changed m_processingRequests to a static. (WebKit::NetscapePluginHostProxy::processRequests): Ditto. Changing m_processingRequests after destroying the object in pluginHostDied() was wrong, but reasonably harmless, as there wasn't much time for some other object to be allocated at this address. (WKPCEvaluate): Refetch host proxy, as it may have been destroyed. (WKPCInvoke): Ditto. (WKPCInvokeDefault): Ditto. (WKPCGetProperty): Ditto. (WKPCSetProperty): Ditto. (WKPCRemoveProperty): Ditto. (WKPCHasProperty): Ditto. (WKPCHasMethod): Ditto. (WKPCEnumerate): Ditto. (WKPCRunSyncOpenPanel): Ditto.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Bail out of the "event loop" if host proxy went away while processing a request.
- 5:02 PM Changeset in webkit [56473] by
-
- 3 edits in trunk/WebKit/qt
2010-03-24 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Add the FrameFlatteningEnabled WebAttribute to QWebSettings.
[Qt] Missing QWebSettings for Frame Flattening
https://bugs.webkit.org/show_bug.cgi?id=36553
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
- Api/qwebsettings.h:
- 4:50 PM Changeset in webkit [56472] by
-
- 3 edits in trunk/WebKitTools
<http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge
Reviewed by Eric Seidel.
When resolve-ChangeLogs fails to merge a patch while running as
a git merge driver, it deletes the original file, which causes
an internal failure and stops git mid-merge:
fatal: Failed to execute internal merge
The fix is to use the --force switch with patch so that it will
always attempt to apply the patch. (The change in
mergeChangeLogs() for the previous commit also fixed this, but
adding --force also prevents any potential user interaction that
patch may want to display.)
- Scripts/VCSUtils.pm:
(mergeChangeLogs): Added --force switch to patch command. Also
changed to use the exit status from the patch command to
determine the return value for this method.
- Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added
test to cover this bug.
- 4:50 PM Changeset in webkit [56471] by
-
- 3 edits1 add in trunk/WebKitTools
<http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package
Reviewed by Eric Seidel.
- Scripts/VCSUtils.pm:
(mergeChangeLogs): Copied from mergeChanges() in
resolve-ChangeLogs and renamed. Added method documentation.
Fixed bug found by new tests where the original file to be
patched was deleted when cleaning up after a traditinal rejected
patch failed to apply.
- Scripts/resolve-ChangeLogs: Switched to using
mergeChangeLogs().
(mergeChanges): Moved to VCSUtils.pm and renamed to
mergeChangeLogs().
- Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added.
- 4:36 PM Changeset in webkit [56470] by
-
- 5 edits in trunk/WebKitTools
2010-03-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add support for qt's unassigned list to webkit-patch assign-to-committer
https://bugs.webkit.org/show_bug.cgi?id=36559
- Scripts/webkitpy/bugzilla.py:
- Move Bugzilla.unassigned_email into Bug and make it a set.
- Scripts/webkitpy/bugzilla_unittest.py:
- Test the new Bug.is_unassigned method
- Scripts/webkitpy/commands/upload.py:
- Use the new Bug.is_unassigned method instead of an explicit ==
- Scripts/webkitpy/mock_bugzillatool.py:
- Bugzilla.unassigned_email no longer needs mocking
- 4:30 PM Changeset in webkit [56469] by
-
- 4 edits in trunk
2010-03-24 Dmitry Titov <dimich@chromium.org>
No review, rolling out r56453.
http://trac.webkit.org/changeset/56453
https://bugs.webkit.org/show_bug.cgi?id=36426
In Chromium port, it broke invalid-image-data-standalone.html
invalid-image-data.html multipart-wait-before-boundary.html
stop-crash.html win-boundary-crash.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):
2010-03-24 Dmitry Titov <dimich@chromium.org>
No review, rolling out r56453.
http://trac.webkit.org/changeset/56453
https://bugs.webkit.org/show_bug.cgi?id=36426
In Chromium port, it broke invalid-image-data-standalone.html
invalid-image-data.html multipart-wait-before-boundary.html
stop-crash.html win-boundary-crash.html
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail):
- 4:21 PM Changeset in webkit [56468] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geoff Garen.
- wtf/FastMalloc.h: Added a using directive for fastMallocSize, like we do for all public WTF symbols. Also sorted the list alphabetically.
- 4:18 PM Changeset in webkit [56467] by
-
- 2 edits in trunk/WebCore
2010-03-24 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Significant scroll speed degradation if Timeline has
an expanded record with significant number of children.
https://bugs.webkit.org/show_bug.cgi?id=36543
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._updateBoundaries): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelinePanel.prototype._filterRecords): (WebInspector.TimelinePanel.prototype._refreshRecords):
- 4:08 PM Changeset in webkit [56466] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-03-24 Yuri Chornoivan <yurchor@ukr.net>
Reviewed by Gustavo Noronha.
Ukrainian translation.
- uk.po: Added.
- 4:02 PM Changeset in webkit [56465] by
-
- 2 edits in trunk/WebCore
2010-03-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Carlson.
[GStreamer] Fails to go to Loaded state because of floating point discrepancies
https://bugs.webkit.org/show_bug.cgi?id=35891
Use the m_fillStatus variable, which is more reliable, instead of
using the calculation, for the completed case.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::fillTimerFired):
- 4:00 PM Changeset in webkit [56464] by
-
- 2 edits in trunk/WebCore
Unreviewed, Chromium test fix.
Recent r56445 added CustomEvent and a test but it didn't work on Chromium bots.
Test crashed due to infinte recursion because the compiler did not have the right definition of toV8(CustomEvent*)
and was substituting toV8(Event*).
Fixing test fast/events/custom-event.html
- bindings/v8/custom/V8EventCustom.cpp:
- 3:45 PM Changeset in webkit [56463] by
-
- 2 edits in trunk/WebCore
2010-03-24 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
Refactoring: HTMLFormControlElement should not have redundant null check
https://bugs.webkit.org/show_bug.cgi?id=36487
No new tests as there is no new functionality.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFocusEvent): (WebCore::HTMLFormControlElement::dispatchBlurEvent):
- 3:22 PM Changeset in webkit [56462] by
-
- 4 edits in trunk
2010-03-24 Eric Uhrhane <ericu@chromium.org>
DOMCoreException needs NoStaticTables modifier
https://bugs.webkit.org/show_bug.cgi?id=36458
No new tests, but this shows up in tests of Database accesses from the
Worker thread that I'll be checking in soon. The symptom is that
DOMCoreException.toString() returns [object DOMException] instead of
something more helpful.
- fast/workers/worker-context-multi-port-expected.txt: Adjusted expectation that was depending on the broken behavior.
2010-03-24 Eric Uhrhane <ericu@chromium.org>
Reviewed by Alexey Proskuryakov.
DOMCoreException needs NoStaticTables modifier
https://bugs.webkit.org/show_bug.cgi?id=36458
No new tests, but this shows up in tests of Database accesses from the
Worker thread that I'll be checking in soon. The symptom is that
DOMCoreException.toString() returns [object DOMException] instead of
something more helpful.
- dom/DOMCoreException.idl: Added NoStaticTables.
- 3:05 PM Changeset in webkit [56461] by
-
- 2 edits in trunk/WebCore
2010-03-24 Drew Wilson <atwilson@chromium.org>
Reviewed by Dmitry Titov.
Failed assertion in V8Proxy::setDOMException() if worker is shutting down.
https://bugs.webkit.org/show_bug.cgi?id=36514
Test: none (existing worker tests suffice)
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException): Updated setDOMException() to check for an empty exception (due to no active context) and avoid throwing in that case.
- 2:37 PM Changeset in webkit [56460] by
-
- 7 edits in trunk
2010-03-23 Evan Martin <evan@chromium.org>
Reviewed by Dmitry Titov.
[chromium] use integral glyph widths
https://bugs.webkit.org/show_bug.cgi?id=36510
Extend a Linux Chromium layout test to also cover slight-hinted text.
- platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html:
2010-03-23 Evan Martin <evan@chromium.org>
Reviewed by Dmitry Titov.
[chromium] use integral glyph widths
https://bugs.webkit.org/show_bug.cgi?id=36510
Despite WebKit (and Skia, to an extent) supporting non-integral
glyph widths, the font code path we hit in Skia only supports
integral glyph positions. This means that we would accumulate
offsets when drawing a sequence up non-integer-width glyphs
which would cause gaps when snapped to the pixel grid when drawing.
- platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformWidthForGlyph): round glyph widths to integers.
- 2:16 PM Changeset in webkit [56459] by
-
- 2 edits in trunk/WebCore
2010-03-24 Dean Jackson <dino@apple.com>
Reviewed by Kevin Decker.
<rdar://problem/7785305>
Fix regression caused by r55576. It turned out that ensuring
CoreAnimation always gets a correct fill parameter caused flashing
as non-filled animations ended (CA briefly showed the initial animation
value before the style system set the final value).
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setupAnimation):
- 2:12 PM Changeset in webkit [56458] by
-
- 2 edits in trunk/WebKit/qt
2010-03-24 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
Auto-uppercase and predictive text need to be disabled for S60 (as for maemo)
https://bugs.webkit.org/show_bug.cgi?id=33176
- WebCoreSupport/EditorClientQt.cpp:
- 2:08 PM Changeset in webkit [56457] by
-
- 5 edits2 adds in trunk/WebKit/chromium
2010-03-24 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium]WebKit side of adding search support to Pepper.
https://bugs.webkit.org/show_bug.cgi?id=36434
- WebKit.gyp:
- public/WebDocument.h:
- public/WebNode.h: (WebKit::WebNode::to): (WebKit::WebNode::toConst):
- public/WebPluginDocument.h: Added. (WebKit::WebPluginDocument::WebPluginDocument): (WebKit::WebPluginDocument::operator=): (WebKit::WebPluginDocument::assign):
- src/WebDocument.cpp: (WebKit::WebDocument::isPluginDocument):
- src/WebPluginDocument.cpp: Added. (WebKit::WebPluginDocument::plugin): (WebKit::WebPluginDocument::WebPluginDocument): (WebKit::WebPluginDocument::operator=): (WebKit::WebPluginDocument::operator PassRefPtr<PluginDocument>):
- 1:55 PM Changeset in webkit [56456] by
-
- 5 edits in trunk
2010-03-24 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
https://bugs.webkit.org/show_bug.cgi?id=36522
For consistency with other QWebSettings attributes.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
- Api/qwebsettings.h:
2010-03-24 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
https://bugs.webkit.org/show_bug.cgi?id=36522
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled): Use the new name.
- 1:50 PM Changeset in webkit [56455] by
-
- 2 edits in trunk/WebKitSite
Rubber-stamped by Anders Carlsson..
Update Security Group Members list.
- security/security-group-members.html:
- 1:38 PM Changeset in webkit [56454] by
-
- 6 edits in trunk
2010-03-24 Hayato Ito <hayato@chromium.org>
Reviewed by NOBODY (Need!).
Refactor computePageRects so that Mac can make use of it.
https://bugs.webkit.org/show_bug.cgi?id=36159
Refactoring only, so no new tests.
- WebCore.base.exp:
- page/PrintContext.cpp: (WebCore::PrintContext::computePageRects): (WebCore::PrintContext::computePageRectsWithPageSize): (WebCore::PrintContext::computePageRectsWithPageSizeInternal): (WebCore::PrintContext::pageNumberForElement): (WebCore::PrintContext::numberOfPages):
- page/PrintContext.h:
2010-03-24 Hayato Ito <hayato@chromium.org>
Reviewed by Shinichiro Hamaji.
Refactor computePageRects so that Mac can make use of it.
https://bugs.webkit.org/show_bug.cgi?id=36159
Refactoring only, so no new tests.
- WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):
- 1:20 PM Changeset in webkit [56453] by
-
- 4 edits in trunk
2010-03-24 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Jeremy Orlow.
Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().
No new tests as there is no new functionality.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Make copy of mimeType string to isolate crash.
2010-03-24 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Jeremy Orlow.
Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().
- src/ResourceHandle.cpp: Track state across ResourceHandle invocations. (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail):
- 1:02 PM Changeset in webkit [56452] by
-
- 4 edits in trunk/WebCore
2010-03-24 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
Use newly introduced SetPrototype method to deal with global objects.
https://bugs.webkit.org/show_bug.cgi?id=36497
No new tests, should be covered by the current test infrastructure.
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::installDOMWindow):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
- 12:23 PM Changeset in webkit [56451] by
-
- 2 edits in trunk/WebCore
Unreviewed, Chromium build fix.
- platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::PopupContainer): Fix order of initializers.
(WebCore::PopupContainer::layout): Remove unused variable.
- 12:05 PM Changeset in webkit [56450] by
-
- 7 edits in trunk
WebCore: Add a way to check if the page client is making use of
a QWidget.
Reviewed by Simon Hausmann.
- platform/qt/QWebPageClient.h:
(QWebPageClient::isQWidgetClient):
WebKit/qt: Calling setView on a QWebPage being shown by a QGraphicsWebView,
would uninstall the page client, resulting in not expected
behaviour.
Reviewed by Simon Hausmann.
- Api/qwebpage.cpp:
(QWebPageWidgetClient::QWebPageWidgetClient):
(QWebPageWidgetClient::isQWidgetClient):
(QWebPageWidgetClient::screenNumber):
(QWebPage::QWebPage):
(QWebPage::setView):
- 11:41 AM Changeset in webkit [56449] by
-
- 10 edits in trunk
2010-03-24 Jay Campan <jcampan@google.com>
Reviewed by Darin Fisher.
Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062
- page/chromium/ChromeClientChromium.h:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupListBox::setMaxHeight): (WebCore::PopupListBox::disconnectClient): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupContainer::layout): (WebCore::PopupContainer::chromeClientChromium): (WebCore::PopupListBox::hidePopup): (WebCore::PopupListBox::layout): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show):
- platform/chromium/PopupMenuChromium.h: (WebCore::PopupItem::): (WebCore::PopupItem::PopupItem): (WebCore::PopupContainerSettings::): (WebCore::PopupContainer::): (WebCore::PopupContainer::listBox): (WebCore::PopupContainer::popupType):
2010-03-24 Jay Campan <jcampan@google.com>
Reviewed by Darin Fisher.
Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062
- public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::popupClosed):
- src/ChromeClientImpl.h:
- src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::hideSelectPopup): (WebKit::WebViewImpl::popupOpened): (WebKit::WebViewImpl::popupClosed): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
- src/WebViewImpl.h:
- 11:11 AM Changeset in webkit [56448] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Audits never complete
https://bugs.webkit.org/show_bug.cgi?id=36544
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
- 10:50 AM Changeset in webkit [56447] by
-
- 8 edits in trunk/WebCore
Need to move items that CanvasRenderingContext2D depends on into CanvasSurface.
https://bugs.webkit.org/show_bug.cgi?id=35453
Reviewed by Oliver Hunt.
Prepartory changes to allow for an OffscreenCanvas which may be used in a worker
or outside of the DOM.
No change in functionality, so new tests.
- dom/CanvasSurface.cpp: Moved functionality that CanvasRenderingContext2D depends on
into this class (and removed dependencies on document/html element).
(WebCore::CanvasSurface::CanvasSurface):
(WebCore::CanvasSurface::~CanvasSurface): Put the desctructor in the cpp file
to avoid needing access to ~ImageBuffer in the header file.
(WebCore::CanvasSurface::setSurfaceSize): Does basic items needed
when the size changes. It is protected to force outside callers to go
through HTMLCanvasElement::setSize.
(WebCore::CanvasSurface::toDataURL): Just moved from HTMLCanvasElement and
made a note about a method to fix for worker usage.
(WebCore::CanvasSurface::willDraw): Made this virtual to allow an overide
which uses the renderbox and tracks a dirtyRect.
(WebCore::CanvasSurface::convertLogicalToDevice): Moved and changed to
rely on a member variable for page scale (to avoid using the document).
(WebCore::CanvasSurface::createImageBuffer):
(WebCore::CanvasSurface::drawingContext): Simple move from HTMLCanvasElement.
(WebCore::CanvasSurface::buffer): Ditto.
(WebCore::CanvasSurface::baseTransform): Ditto.
- dom/CanvasSurface.h:
(WebCore::CanvasSurface::width): Simple move from HTMLCanvasElement.
(WebCore::CanvasSurface::height): Ditto.
(WebCore::CanvasSurface::size): Ditto.
(WebCore::CanvasSurface::setOriginTainted): Ditto.
(WebCore::CanvasSurface::originClean): Ditto.
(WebCore::CanvasSurface::hasCreatedImageBuffer): Ditto (with small name change).
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement): Pass in the scale factor to CanvasSurface
so it doesn't need the document.
(WebCore::HTMLCanvasElement::willDraw): Moved the relevant portion to CanvasSurface.
(WebCore::HTMLCanvasElement::reset): Small changes due to refactoring.
(WebCore::HTMLCanvasElement::paint): Ditto.
- html/HTMLCanvasElement.h:
(WebCore::HTMLCanvasElement::setSize): Ditto.
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): Added assert
to verify that this is only called on the main thread.
- platform/graphics/Image.cpp:
(WebCore::Image::nullImage): Ditto.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::utiFromMIMEType): Ditto.
- 10:21 AM Changeset in webkit [56446] by
-
- 6 edits in trunk
2010-03-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Inspector: XML Tags should not be converted to lowercase
https://bugs.webkit.org/show_bug.cgi?id=28600
LayoutTests:
- inspector/elements-panel-xhtml-structure-expected.txt:
- inspector/elements-panel-xhtml-structure.xhtml:
WebCore:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateBreadcrumb): (WebInspector.ElementsPanel.prototype.decorateNodeLabel):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.nodeNameToCorrectCase): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- 10:15 AM Changeset in webkit [56445] by
-
- 17 edits5 adds in trunk
WebCore: Add support for DOM Level 3 Custom Event
http://www.w3.org/TR/DOM-Level-3-Events
Reviewed by Antti Koivisto.
Test: fast/events/custom-event.html
- DerivedSources.cpp:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- dom/CustomEvent.cpp: Added.
(WebCore::CustomEvent::CustomEvent):
(WebCore::CustomEvent::initCustomEvent):
(WebCore::CustomEvent::isCustomEvent):
- dom/CustomEvent.h: Added.
(WebCore::CustomEvent::create):
(WebCore::CustomEvent::detail):
- dom/Document.cpp:
(WebCore::Document::createEvent):
- dom/Event.cpp:
(WebCore::Event::isCustomEvent):
- dom/Event.h:
LayoutTests: Layout test for DOM Level 3 Custom Event
http://www.w3.org/TR/DOM-Level-3-Events
Reviewed by Antti Koivisto.
- fast/events/custom-event-expected.txt: Added.
- fast/events/custom-event.html: Added.
- 9:56 AM Changeset in webkit [56444] by
-
- 4 edits in trunk/WebCore
2010-03-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Error when highlighting JavaScript with an invalid mime type
https://bugs.webkit.org/show_bug.cgi?id=36530
- inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.Registry):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded): (WebInspector.SourceView.prototype._canonicalMimeType):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter):
- 9:33 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:28 AM QtWebKitRelease20 edited by
- (diff)
- 9:25 AM Changeset in webkit [56443] by
-
- 2 edits in trunk/WebCore
2010-03-24 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium test fix: added a frameCount check to the
debugger function call.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createUtilityContext):
- 8:47 AM Changeset in webkit [56442] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Fix VKEY_F10, VKEY_F11 translation in WebInputEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=36524
- src/WebInputEvent.cpp: (WebKit::staticKeyIdentifiers):
- 8:18 AM Porting Macros plan edited by
- (diff)
- 7:11 AM Changeset in webkit [56441] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann and Gustavo Noronha Silva.
[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html fails after r56394
https://bugs.webkit.org/show_bug.cgi?id=36531
- platform/gtk/Skipped: http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html skipped until fix.
- platform/qt/Skipped: http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html skipped until fix.
- 6:25 AM QtWebKitBugs edited by
- (diff)
- 6:21 AM ImprovingLifeOnWindows edited by
- Removed section about detecting a missing Platform SDK. We now do this … (diff)
- 4:07 AM Changeset in webkit [56440] by
-
- 2 edits in trunk/WebCore
[Qt] Support for QT_LIBINFIX in Symbian builds
Patch by Miikka Heikkinen <miikka.heikkinen@digia.com> on 2010-03-19
Reviewed by Simon Hausmann.
Configuring Qt with -qtlibinfix parameter will enable installing
an alternate version of Qt on devices that already have it on ROM.
This patch provides support for infixed builds of Webkit.
- WebCore.pro:
- 2:36 AM Changeset in webkit [56439] by
-
- 36 edits in trunk
2010-03-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072
r54923 made Icon::createIconForFiles() deprecated. However moving
existing icon loading code to outside of WebCore is not good. So,
we assume:
- ChromeClient::chooseIconForFiles(), renamed from iconForFiles(), is the primary API to load icons.
- Icon::createIconForFiles() is an optional API to help implementing ChromeClient::iconForFiles().
This patch removes a call to Icon::createIconForFiles() from
FileChooser::loadIcon(), and ChromeClient::chooseIconForFiles() of
non-Chromium ports calls Icon::createIconForFiles().
- WebCore.base.exp: Export FileChooser::iconLoaded(), Icon::createIconForFiles(), and Icon::~Icon().
- WebCore.xcodeproj/project.pbxproj: Export Icon.h
- loader/EmptyClient.h: Rename iconForFiles() to chooseIconForFiles().
- page/Chrome.cpp: ditto.
- page/Chrome.h: ditto.
- page/ChromeClient.h: ditto.
- platform/FileChooser.cpp: (WebCore::FileChooser::loadIcon):
- platform/graphics/Icon.h: Remove a comment on createIconForFiles().
- platform/graphics/chromium/IconChromiumLinux.cpp: Remove createIconForFiles().
- platform/graphics/chromium/IconChromiumMac.cpp: ditto.
- platform/graphics/chromium/IconChromiumWin.cpp: ditto.
- rendering/RenderFileUploadControl.cpp: Rename iconForFiles() to chooseIconForFiles().
- rendering/RenderFileUploadControl.h: ditto.
2010-03-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072
- Rename iconForFiles() to chooseIconForFiles().
- Call Icon::createIconForFiles() from chooseIconForFiles().
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles):
- src/ChromeClientImpl.h:
2010-03-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072
- Rename iconForFiles() to chooseIconForFiles().
- Call Icon::createIconForFiles() from chooseIconForFiles().
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ChromeClientGtk.h:
2010-03-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072
- Rename iconForFiles() to chooseIconForFiles().
- Call Icon::createIconForFiles() from chooseIconForFiles().
- WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::chooseIconForFiles):
- WebCoreSupport/ChromeClientHaiku.h:
2010-03-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072
- Rename iconForFiles() to chooseIconForFiles().
- Call Icon::createIconForFiles() from chooseIconForFiles().
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::chooseIconForFiles):
2010-03-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072
- Rename iconForFiles() to chooseIconForFiles().
- Call Icon::createIconForFiles() from chooseIconForFiles().
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::chooseIconForFiles):
- WebCoreSupport/ChromeClientQt.h:
2010-03-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072
- Rename iconForFiles() to chooseIconForFiles().
- Call Icon::createIconForFiles() from chooseIconForFiles().
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::chooseIconForFiles):
- WebCoreSupport/WebChromeClient.h:
2010-03-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072
- Rename iconForFiles() to chooseIconForFiles().
- Call Icon::createIconForFiles() from chooseIconForFiles().
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::chooseIconForFiles):
- WebKitSupport/ChromeClientWx.h:
- 1:43 AM QtWebKitFeaturePlanning edited by
- (diff)
- 1:36 AM QtWebKitFeaturePlanning created by
- 1:35 AM Changeset in webkit [56438] by
-
- 2 edits in trunk/JavaScriptCore
Bug 36519 - JSGlobalContextRelease is unnecessarily slow
Reviewed by Oliver Hunt.
Since [ http://trac.webkit.org/changeset/35917 ], calling
JSGlobalContextRelease always triggers a GC heap collection
(if not a full destroy). As per 35917's changelog "This is
only really necessary when the (JSGlobalObject's) last
reference is released, but there is no way to determine that,
and no harm in collecting slightly more often."
Well, we now know of cases of API clients who are harmed by
the performance penalty of collecting too often, so it's time
to add a way to determine whether a call to JSGlobalContextRelease
is removing the last protect from it's global object. If further
protects are retaining the global object (likely from other
JSGlobalContextRefs), then don't trigger a GC collection.
- API/JSContextRef.cpp:
- runtime/Collector.cpp:
(JSC::Heap::unprotect): return a boolean indicating that the value is now unprotected.
- runtime/Collector.h:
- wtf/HashCountedSet.h:
(WTF::::remove): return a boolean indicating whether the value was removed from the set.
- 12:50 AM Changeset in webkit [56437] by
-
- 6 edits in trunk/WebKitTools
Added to check-webkit-style support for a --debug flag.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=36100
The --debug flag adjusts the logging level to DEBUG and
includes the logger name and level in each log message.
- Scripts/check-webkit-style:
- Changed the code to check for the --debug flag and pass the result to the configure_logging() method.
- Scripts/webkitpy/style/checker.py:
- Added an is_debug parameter to configure_logging().
- Refactored configure_logging() by adding calls to the following two methods: _create_log_handlers() and _create_debug_log_handlers().
- Scripts/webkitpy/style/checker_unittest.py:
- Added unit tests for configure_logging() with is_debug True by splitting the ConfigureLoggingTest class into ConfigureLoggingTest and ConfigureLoggingTestBase, and adding ConfigureLoggingDebugTest.
- Scripts/webkitpy/style/optparser.py:
- Updated the usage string.
- Added an is_debug data attribute to the CommandOptionValues class.
- Added support for the --debug flag to the ArgumentParser.parse() method.
- Also added extra error information to the parse() method in the case of an invalid flag.
- Scripts/webkitpy/style/optparser_unittest.py:
- Updated the unit tests as necessary.
- Also fixed an issue with the CommandOptionValuesTest.test_eq() unit test.
- 12:46 AM Changeset in webkit [56436] by
-
- 2 edits in trunk/JavaScriptCore
Bug 36519 - JSGlobalContextRelease is unnecessarily slow
Reviewed by Oliver Hunt.
Since [ http://trac.webkit.org/changeset/35917 ], calling
JSGlobalContextRelease always triggers a GC heap collection
(if not a full destroy). As per 35917's changelog "This is
only really necessary when the (JSGlobalObject's) last
reference is released, but there is no way to determine that,
and no harm in collecting slightly more often."
Well, we now know of cases of API clients who are harmed by
the performance penalty of collecting too often, so it's time
to add a way to determine whether a call to JSGlobalContextRelease
is removing the last protect from it's global object. If further
protects are retaining the global object (likely from other
JSGlobalContextRefs), then don't trigger a GC collection.
- API/JSContextRef.cpp:
- runtime/Collector.cpp:
(JSC::Heap::unprotect): return a boolean indicating that the value is now unprotected.
- runtime/Collector.h:
- wtf/HashCountedSet.h:
(WTF::::remove): return a boolean indicating whether the value was removed from the set.
- 12:42 AM QtWebKit edited by
- (diff)
- 12:11 AM Changeset in webkit [56435] by
-
- 5 edits in trunk/JavaScriptCore
Bug 36519 - JSGlobalContextRelease is unnecessarily slow
Reviewed by Oliver Hunt.
Since [ http://trac.webkit.org/changeset/35917 ], calling
JSGlobalContextRelease always triggers a GC heap collection
(if not a full destroy). As per 35917's changelog "This is
only really necessary when the (JSGlobalObject's) last
reference is released, but there is no way to determine that,
and no harm in collecting slightly more often."
Well, we now know of cases of API clients who are harmed by
the performance penalty of collecting too often, so it's time
to add a way to determine whether a call to JSGlobalContextRelease
is removing the last protect from it's global object. If further
protects are retaining the global object (likely from other
JSGlobalContextRefs), then don't trigger a GC collection.
- API/JSContextRef.cpp:
- runtime/Collector.cpp:
(JSC::Heap::unprotect): return a boolean indicating that the value is now unprotected.
- runtime/Collector.h:
- wtf/HashCountedSet.h:
(WTF::::remove): return a boolean indicating whether the value was removed from the set.
Mar 23, 2010:
- 10:55 PM Changeset in webkit [56434] by
-
- 1 edit3 adds in trunk/WebKitTools
2010-03-23 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add TestNavigationController and TestWebWorker
https://bugs.webkit.org/show_bug.cgi?id=36489
Add TestNavigationController and TestWebWorker classes, which are
going to be used by DumpRenderTree Chromium port. These files are
based on:
- src/webkit/tools/test_shell/test_navigation_controller.{cc,h}
- src/webkit/tools/test_shell/test_web_worker.h of Chromium rev.40492.
TestNavigationController has non-style changes.
- Change ContentState type: binary string -> WebHistoryItem
- Remove TestShell dependency by introducing NavigationHost interface.
- DumpRenderTree/chromium/TestNavigationController.cpp: Added.
- DumpRenderTree/chromium/TestNavigationController.h: Added.
- DumpRenderTree/chromium/TestWebWorker.h: Added.
- 9:27 PM Changeset in webkit [56433] by
-
- 2 edits in trunk/LayoutTests
Skip plugins/destroy-plugin-from-callback.html, which has been failing on SL bots since it
was added in r56338.
- platform/mac-snowleopard/Skipped:
- 8:17 PM Changeset in webkit [56432] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice): Some versions of GCC emit a warning about the implicit 64- to 32-bit truncation
that takes place here. An explicit cast is sufficient to silence it.
- 5:31 PM Changeset in webkit [56431] by
-
- 2 edits in trunk/WebKit/mac
Reverted accidental change from r56429.
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
- 5:29 PM Changeset in webkit [56430] by
-
- 2 edits in trunk/WebCore
Fixed typos.
- manual-tests/plugin-visible-rect-change.html:
- 5:27 PM Changeset in webkit [56429] by
-
- 12 edits1 add in trunk
WebCore: WebCore part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.
Reviewed by John Sullivan.
- manual-tests/plugin-visible-rect-change.html: Added.
- platform/mac/WidgetMac.mm:
(WebCore::WidgetPrivate::WidgetPrivate): Added previousVisibleRect.
(WebCore::Widget::setFrameRect): If the visible rect changed but the
frame rect did not, send a -visibleRectDidChange message to the view,
if it responds to it.
(WebCore::Widget::releasePlatformWidget): Reset previousVisibleRect.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry): Track changes to the clip rect
imposed by the enclosing layer. Call Widget::setFrameRect when it changes,
even if the frame rect did not.
- rendering/RenderWidget.h:
(WebCore::RenderWidget::windowClipRect): Added this accessor.
WebKit/mac: WebKit part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.
Reviewed by John Sullivan.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView visibleRectDidChange]): Added. Calls
WKSyncSurfaceToView().
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView _windowClipRect]): Changed to use Widget::windowClipRect().
(-[WebBaseNetscapePluginView visibleRectDidChange]): Added. Invokes -renewGState.
WebKitLibraries: WebKitSystemInterface part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.
Reviewed by John Sullivan.
- WebKitSystemInterface.h: Added WKSyncSurfaceToView().
- libWebKitSystemInterfaceSnowLeopard.a: Updated
- 5:06 PM Changeset in webkit [56428] by
-
- 3 edits2 adds in trunk
2010-03-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Assertion ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com
https://bugs.webkit.org/show_bug.cgi?id=34065
Fix another cause of assertions related to the clip rects root. Embeds
with zero size caused the overlap testing to fail, yet we require them to work
for correct compositing, so when the composited bounds is empty, use a 1x1 rect
for overlap testing.
Test: compositing/geometry/empty-embed-rects.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::addToOverlapMap): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 4:31 PM Changeset in webkit [56427] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): Fixed a typo - length doesn't need to be converted with toInteger().
- 4:28 PM Changeset in webkit [56426] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-23 Kenneth Russell <kbr@google.com>
Unreviewed build fix.
Add #include <stdio.h> to fix Chromium Linux build.
- src/WebGraphicsContext3DDefaultImpl.cpp:
- 4:12 PM Changeset in webkit [56425] by
-
- 3 edits3 adds in trunk
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=36511
<rdar://problem/7753498> Safari freezes when using SPUTNIK JavaScript conformance check
Test: fast/js/sputnik-S15.4.4.12_A3_T3.html
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): We were incorrectly computing the start offset, and iterated over (almost) all integers. Note that this can be fixed without using doubles, but the code would be much more complicated, and there is no important reason to stick to integers here.
- 3:57 PM Changeset in webkit [56424] by
-
- 2 edits in trunk/WebKit/qt
2010-03-23 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
QGraphicsWebView crash when calling setView on the QWebPage...
https://bugs.webkit.org/show_bug.cgi?id=36436
Checking for pageClient existance before showing popups.
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show):
- 3:40 PM Changeset in webkit [56423] by
-
- 2 edits in trunk/WebKit/qt
2010-03-23 Anders Bakken <anders.bakken@nokia.com>, Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Check if q->scene() is available before actually using it
on QGraphicsWebViewPrivate.
QGraphicsWebView crash
https://bugs.webkit.org/show_bug.cgi?id=32670
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::screenNumber): (QGraphicsWebViewPrivate::ownerWidget):
- 3:27 PM Changeset in webkit [56422] by
-
- 3 edits2 adds in trunk
[chromium] XMLHttpRequest.send sends 'undefined' string when passed undefined value.
https://bugs.webkit.org/show_bug.cgi?id=36506
Reviewed by Nate Chapin.
WebCore:
Test: http/tests/xmlhttprequest/send-undefined-and-null.html
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::isDocumentType): Unrelated style fix: fixed the casing of the method.
(WebCore::V8XMLHttpRequest::sendCallback): Added check for null/undefined to do the send.
This mirrors what is done in the JSC bindings. Previously, sending 'null' worked because
the last case, which did "toWebCoreStringWithNullCheck", resulted in sending an empty
request body.
LayoutTests:
Added a test to verify that sending either undefined and null both result in an empty request body.
- http/tests/xmlhttprequest/send-undefined-and-null-expected.txt: Added.
- http/tests/xmlhttprequest/send-undefined-and-null.html: Added.
- 3:24 PM Changeset in webkit [56421] by
-
- 5 edits in trunk/WebKitTools
2010-03-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add support for revision -> build lookup in buildbot.py and layout test result parsing
https://bugs.webkit.org/show_bug.cgi?id=36474
- Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code.
- Scripts/webkitpy/buildbot.py:
- Add support for looking up builds by revision number.
- Add support for fetching and parsing results.html files from buildbot.
- build_for_revision has an allow_failed_lookups option to work around the fact that our buildbot's xmlrpc calls return failure on old revision numbers.
- Add parsing support for twisted directory listings.
- Scripts/webkitpy/buildbot_unittest.py:
- Unit test all the new code.
- Scripts/webkitpy/commands/queries.py:
- Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup)
- 3:07 PM Changeset in webkit [56420] by
-
- 3 edits3 adds in trunk
WebCore: Fix hard-to-see crash due to incorrect libxml API usage.
Patch by Chris Evans <cevans@chromium.org> on 2010-03-23
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36000
Test: fast/text/bad-encoding.html
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::doEnd): Avoid operations on a closed context.
LayoutTests: Add test for crash due to calling into libxml in invalid state. Note
that it is unlikely that this will actually crash for you in the test
environment because it is highly intermittent. However, adding test in
order to exercise the code path and prevent related regression.
See https://bugs.webkit.org/show_bug.cgi?id=36000
Patch by Chris Evans <cevans@chromium.org> on 2010-03-23
Reviewed by Darin Adler.
- fast/text/bad-encoding.html: Added.
- fast/text/bad-encoding-expected.txt: Added.
- fast/text/resources/bad-encoding.xml: Added.
- 2:47 PM Changeset in webkit [56419] by
-
- 2 edits in trunk/WebKitTools
2010-03-23 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
Detect if the Windows Platform SDK is missing when building with
Visual C++ Express Edition and inform the user to download it.
- Scripts/webkitdirs.pm:
- 2:38 PM Changeset in webkit [56418] by
-
- 2 edits in trunk/LayoutTests
2010-03-23 Nate Chapin <Nate Chapin>
Unreviewed, Chromium test expectations update.
Mark fast/dom/error-to-string-stack-overflow.html as failing on
all Chromium platforms, and http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
as failing on Windows.
- platform/chromium/test_expectations.txt:
- 2:33 PM Changeset in webkit [56417] by
-
- 3 edits in trunk/WebKitTools
Tell Subversion about more directories that expect to have .pyc files.
- Scripts/webkitpy: Modified property svn:ignore.
- Scripts/webkitpy/irc: Added property svn:ignore.
- 2:24 PM Changeset in webkit [56416] by
-
- 10 edits in trunk
2010-03-23 Nate Chapin <Nate Chapin>
Unreviewed, revert r56376.
This revision introduced a crash in a couple of layout tests
on Chromium Linux.
- page/chromium/ChromeClientChromium.h:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupMenu::show):
- platform/chromium/PopupMenuChromium.h: (WebCore::PopupItem::): (WebCore::PopupItem::PopupItem): (WebCore::PopupContainerSettings::): (WebCore::PopupContainer::listBox):
- 2:15 PM Changeset in webkit [56415] by
-
- 5 edits in trunk/WebKit/chromium
2010-03-23 Sergey Ulanov <sergeyu@chromium.org>
Reviewed by Dmitry Titov.
Changes needed to implement Show/Hide Controls command for <video> in
chrome: (1) added Controls action in WebMediaPlayerAction that toggles
controls for media player, (2) added MediaHasVideo in
WebContextMenuData so that controls can be made toggleable only for
video player but not for audio.
https://bugs.webkit.org/show_bug.cgi?id=36460
- public/WebContextMenuData.h: (WebKit::WebContextMenuData::):
- public/WebMediaPlayerAction.h: (WebKit::WebMediaPlayerAction::):
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::performMediaPlayerAction):
- 1:52 PM Changeset in webkit [56414] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36272, make sure nth-child can work when the portion with "n" is omitted.
Reviewed by Simon Fraser and Darin Adler.
Added fast/css/nth-child-implied-step.html
- css/CSSGrammar.y:
- css/tokenizer.flex:
- 1:51 PM Changeset in webkit [56413] by
-
- 2 edits in trunk/WebKitTools
2010-03-23 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Import the GNU readline interface to modify the behavior
of raw_input so as to provide line editing support. In
particular this will prevent "delete" characters from
appearing in the returned value for function raw_input.
- Scripts/webkitpy/user.py:
- 1:48 PM Changeset in webkit [56412] by
-
- 10 edits in trunk/WebCore
2010-03-23 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Reduce and straighten internal use of DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=36501
- WebCore.xcodeproj/project.pbxproj: Xcode decided to re-sort this file.
- dom/Clipboard.cpp: Removed unneeded include of DOMImplementation.h.
- dom/DOMImplementation.cpp: Removed unneeded createDocument and createHTMLDocument functions. These should be done directly instead of involving the DOMImplementation class.
- dom/DOMImplementation.h: Ditto.
- dom/DocumentType.cpp: Removed unneeded include of DOMImplementation.h.
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer): Don't allocate a DOMImplementation object just to use a class member function.
- loader/CachedFont.cpp: Removed unneeded include of DOMImplementation.h.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Use Document::create to create a new document instead of involving DOMImplementation.
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Ditto. And in the case where we do need to call DOMImplementation to interpret the MIME type, don't allocate a DOMImplementation object just to use a class member function.
- 1:06 PM Changeset in webkit [56411] by
-
- 2 edits in trunk/WebCore
2010-03-23 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Maemo5 theme - all <select> elements should be rendered as menu lists.
https://bugs.webkit.org/show_bug.cgi?id=36367
Enabling NO_LISTBOX_RENDERING in WebCore.pri for Maemo5.
- WebCore.pri:
- 12:39 PM Changeset in webkit [56410] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
When uncaught exception happens reveal Scripts panel only if reporting uncaught exceptions is on.
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
- 12:37 PM Changeset in webkit [56409] by
-
- 1 edit in trunk/WebCore/ChangeLog
Revert accidental ChangeLog commit r56407.
- 12:23 PM Changeset in webkit [56408] by
-
- 3 edits in trunk/WebCore
2010-03-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870
- platform/iphone/KeyEventCodesIPhone.h: Improper comment for #endif.
- platform/iphone/KeyEventIPhone.mm: Fixed headers.
- 12:23 PM Changeset in webkit [56407] by
-
- 1 edit in trunk/WebCore/ChangeLog
Reviewed by Simon Fraser.
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing the missing plug-in indicator. (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::paintReplaced): Ditto.
- rendering/RenderEmbeddedObject.h: Ditto. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto.
- Plugins/WebNetscapePluginView.mm:
- Plugins/WebNullPluginView.h: Removed.
- Plugins/WebNullPluginView.mm: Removed.
- Resources/nullplugin.tiff: Removed.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
- 12:22 PM Changeset in webkit [56406] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: TimelinePanel stays in the recording state after reopening WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=36503
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::detach):
- 11:51 AM Changeset in webkit [56405] by
-
- 2 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36277, make sure nth-child supports the positive unary prefix (+) as well as the negative
one (-).
Reviewed by Jeremy Orlow.
Added fast/css/nth-child-unary-prefix.html
- css/tokenizer.flex:
- 11:49 AM Changeset in webkit [56404] by
-
- 15 edits in trunk/WebCore
2010-03-23 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Dmitry Titov.
Change notification sent to inspector frontend on workers creation / destruction
to be posted asynchronously to avoid JS reenterability problems. Also, renamed
willDestroyWorker to didDestroyWorker to reflect that it gets called later and got
rid of explicit IDs for workers (use addresses instead).
https://bugs.webkit.org/show_bug.cgi?id=36213
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::didDestroyWorker):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorController.cpp: (WebCore::PostWorkerNotificationToFrontendTask::create): (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorController::postWorkerNotificationToFrontend): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::didDestroyWorker):
- inspector/InspectorController.h: (WebCore::InspectorController::):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didDestroyWorker):
- inspector/InspectorFrontend.h:
- inspector/InspectorWorkerResource.h: (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
- inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.terminate):
- inspector/front-end/WorkersSidebarPane.js: (WebInspector.didDestroyWorker):
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker):
- workers/AbstractWorker.h: (WebCore::AbstractWorker::asID):
- workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
- workers/Worker.cpp: (WebCore::Worker::Worker):
- 11:30 AM Changeset in webkit [56403] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-23 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Fix compilation on Itanium in 32-bit mode
https://bugs.webkit.org/show_bug.cgi?id=36494
- wtf/Platform.h: Introduce CPU(IA64_32). Don't define WTF_USE_JSVALUE64 if the CPU is in 32-bit mode.
- 10:53 AM Changeset in webkit [56402] by
-
- 15 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36266, support DOM Level 3 focusin/focusout events. Add support for
IE onfocusin/onfocusout extensions to HTML. The old DOM level 2 names (DOMFocusIn/DOMFocusOut are still supported).
Reviewed by Sam Weinig.
Added fast/events/focusinout.html
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- dom/Event.cpp:
(WebCore::Event::aliasedType):
(WebCore::Event::hasAliasedType):
- dom/Event.h:
- dom/EventNames.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
- dom/EventTarget.h:
- dom/Node.cpp:
(WebCore::Node::dispatchUIEvent):
- html/HTMLAttributeNames.in:
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::parseMappedAttribute):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::parseMappedAttribute):
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseMappedAttribute):
- svg/SVGElement.cpp:
(WebCore::SVGElement::parseMappedAttribute):
- 10:36 AM QtWebKit edited by
- (diff)
- 10:30 AM QtWebKitBackportingFixes edited by
- Moved r56370 to Incoming list (diff)
- 10:10 AM Changeset in webkit [56401] by
-
- 3 edits2 adds in trunk
2010-03-23 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
WebCore::SelectionController::setSelection NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31545
- svg/dom/frame-related-api-during-load-expected.txt: Added.
- svg/dom/frame-related-api-during-load.html: Added.
2010-03-23 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
WebCore::SelectionController::setSelection NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31545
Added missing NULL-check that other APIs have.
Test: svg/dom/frame-related-api-during-load.html
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::deselectAll):
- 10:09 AM Changeset in webkit [56400] by
-
- 3 edits in trunk/JavaScriptCore
Interpreter fix for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)
Reviewed by Mark Rowe.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Only take the fast negate path if
a bit other than bit 31 is set. If none of bits 0-30 are set, then the
value we're negating can only be 0 or -2147483648, and neither can be
negated in int space.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate): Updated the JIT implementation to match
the interpreter, since it's slightly simpler.
- 9:52 AM Changeset in webkit [56399] by
-
- 2 edits in trunk/WebKit/qt
2010-03-23 David Leong <david.leong@nokia.com>
Reviewed by Laszlo Gombos.
Build fix for Symbian Def file.
- symbian/eabi/QtWebKitu.def:
- 9:44 AM QtWebKitBackportingFixes edited by
- added JSC collector memory improvement #34350 (diff)
- 9:34 AM Changeset in webkit [56398] by
-
- 5 edits2 adds in trunk
2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Simon Hausmann.
Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed
https://bugs.webkit.org/show_bug.cgi?id=36444
Enable LayoutTests/fast/canvas/fillrect_gradient.html
- platform/qt/Skipped:
- platform/qt/fast/canvas/fillrect_gradient-expected.checksum: Added.
- platform/qt/fast/canvas/fillrect_gradient-expected.png: Added.
- platform/qt/fast/canvas/fillrect_gradient-expected.txt:
2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Simon Hausmann.
[Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed
https://bugs.webkit.org/show_bug.cgi?id=36444
Handle duplicated or unsorted colorStop at platformDestory
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
- 8:47 AM Changeset in webkit [56397] by
-
- 3 edits in trunk/WebCore
Unreviewed build fix.
Try to make the window buildbot happy.
- xml/XMLHttpRequestProgressEventThrottle.cpp:
- xml/XMLHttpRequestProgressEventThrottle.h: Move initialization of the
static const in the cpp file.
- 8:42 AM Changeset in webkit [56396] by
-
- 2 edits in trunk/WebCore
2010-03-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make gear menu appear on styles panel at all times.
- inspector/front-end/inspector.css:
- 8:39 AM Changeset in webkit [56395] by
-
- 6 edits in trunk/WebCore
2010-03-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: render nodes in inherited style bars as links.
- English.lproj/localizedStrings.js:
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update.else.insertInheritedNodeSeparator): (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._selectNode):
- inspector/front-end/inspector.js:
- 8:33 AM Changeset in webkit [56394] by
-
- 10 edits5 adds in trunk
[XHR] onProgress event needs to be dispatched according to what the specification states
https://bugs.webkit.org/show_bug.cgi?id=18654
Reviewed by Alexey Proskuryakov.
WebCore:
Test: http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added XMLHttpRequestProgressEventThrottle to the build systems.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest): Created the throttle.
(WebCore::XMLHttpRequest::callReadyStateChangeListener): The 'readyState' event are
dispatched using the XMLHttpRequestProgressEventThrottle now. For the DONE state, we
need to flush any pending progress event as we do not want it to be dispatched after
the DONE readyState event.
(WebCore::XMLHttpRequest::createRequest): Made this event use the
XMLHttpRequestProgressEventThrottle for event dispatching.
(WebCore::XMLHttpRequest::abort): Ditto.
(WebCore::XMLHttpRequest::networkError): Ditto.
(WebCore::XMLHttpRequest::abortError): Ditto.
(WebCore::XMLHttpRequest::didReceiveData): Ditto. Also fixed a potential warning.
(WebCore::XMLHttpRequest::suspend):
(WebCore::XMLHttpRequest::resume): Implemented the logic for suspend / resume.
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestProgressEventThrottle.cpp: Added.
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::~XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): Implemented the bulk
of the event throttling here: we use a timer to do so, as long as the timer is active it means
that events are coming faster than the throttling time and we coalesce them.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent): Generic method to dispatch an event.
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): Called when we want to dispatch
any pending events and stopping any further dispatching.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchPausedEvent): Used to dispatch the event
that was queued due to the object being suspended.
(WebCore::XMLHttpRequestProgressEventThrottle::fired): Used to dispatch any coalesced event.
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch): Used to check if we have
an event to dispatch.
(WebCore::XMLHttpRequestProgressEventThrottle::suspend): Marked the object as suspended.
(WebCore::XMLHttpRequestProgressEventThrottle::resume): Dispatched the event that was queued.
- xml/XMLHttpRequestProgressEventThrottle.h: Added.
(WebCore::):
(WebCore::XMLHttpRequestProgressEventThrottle::suspended):
LayoutTests:
Add a test to check that progress events are really throttled.
- http/tests/xmlhttprequest/resources/download-with-delay.php: Added.
- http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html: Added.
- 8:14 AM Changeset in webkit [56393] by
-
- 4 edits2 adds in trunk
2010-03-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Element inspector search funtion: Error dispatching: performSearch.
Test: inspector/elements-panel-search.html
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): (injectedScriptConstructor):
- 7:57 AM Changeset in webkit [56392] by
-
- 2 edits in trunk
2010-03-23 Laszlo Gombos <Laszlo Gombos>
Unreviewed, fix the reviwer for r56391.
- WebCore/ChangeLog
- LayoutTests/ChangeLog
- 7:37 AM Changeset in webkit [56391] by
-
- 6 edits2 adds in trunk
2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] fast/canvas/patternfill-repeat.html failed.
https://bugs.webkit.org/show_bug.cgi?id=34477
Change Pattern to expose the repeatX and repeatY
at GraphicsContextQt to apply repeatX and repeatY
- platform/graphics/Pattern.h: (WebCore::Pattern::repeatX): (WebCore::Pattern::repeatY):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::rotate):
2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] fast/canvas/patternfill-repeat.html failed.
https://bugs.webkit.org/show_bug.cgi?id=34477
Enable LayoutTests/fast/canvas/patternfill-repeat.html.
- platform/qt/Skipped:
- platform/qt/fast/canvas/patternfill-repeat-expected.checksum: Added.
- platform/qt/fast/canvas/patternfill-repeat-expected.png: Added.
- platform/qt/fast/canvas/patternfill-repeat-expected.txt:
- 7:19 AM QtWebKitBugs edited by
- minor (diff)
- 7:05 AM Changeset in webkit [56390] by
-
- 35 edits in trunk
2010-03-23 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Updated test results from removal of use of STIX fonts.
- platform/mac/mathml/presentation/fractions-expected.checksum:
- platform/mac/mathml/presentation/fractions-expected.png:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/mo-expected.checksum:
- platform/mac/mathml/presentation/mo-expected.png:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/over-expected.checksum:
- platform/mac/mathml/presentation/over-expected.png:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/row-expected.checksum:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/sub-expected.checksum:
- platform/mac/mathml/presentation/sub-expected.png:
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.checksum:
- platform/mac/mathml/presentation/subsup-expected.png:
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/sup-expected.checksum:
- platform/mac/mathml/presentation/sup-expected.png:
- platform/mac/mathml/presentation/tables-expected.checksum:
- platform/mac/mathml/presentation/tables-expected.png:
- platform/mac/mathml/presentation/tables-expected.txt:
- platform/mac/mathml/presentation/under-expected.checksum:
- platform/mac/mathml/presentation/under-expected.png:
- platform/mac/mathml/presentation/under-expected.txt:
- platform/mac/mathml/presentation/underover-expected.checksum:
- platform/mac/mathml/presentation/underover-expected.png:
- platform/mac/mathml/presentation/underover-expected.txt:
2010-03-23 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Removed the use of beta STIX fonts.
- css/mathml.css:
- 6:34 AM Changeset in webkit [56389] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] websocket/tests/long-invalid-header.html fails
https://bugs.webkit.org/show_bug.cgi?id=36492
- platform/qt/Skipped: websocket/tests/long-invalid-header.html skipped until fix.
- 6:23 AM Changeset in webkit [56388] by
-
- 2 edits in trunk/LayoutTests
2010-03-23 Gustavo Noronha Silva <Gustavo Noronha Silva>
[GTK] Failing fast/css/zoom-body-scroll.html - sizes are off by one after zooming out
https://bugs.webkit.org/show_bug.cgi?id=36491
Skipping test that fails on 32 bits bots.
- platform/gtk/Skipped:
- 6:23 AM Changeset in webkit [56387] by
-
- 11 edits1 add in trunk
WebCore
2010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
[GTK] Does not build with latest GTK+ development release
https://bugs.webkit.org/show_bug.cgi?id=36398
Fix building with newest GTK+ versions.
- GNUmakefile.am:
- platform/gtk/GtkPluginWidget.cpp: (WebCore::GtkPluginWidget::invalidateRect): (WebCore::GtkPluginWidget::paint):
- platform/gtk/GtkVersioning.h: Added.
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenRect): (WebCore::screenAvailableRect):
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::paint):
- plugins/gtk/gtk2xtbin.c: (gtk_xtbin_set_position): (gtk_xtbin_unrealize):
WebKit/gtk
2010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
[GTK] Does not build with latest GTK+ development release
https://bugs.webkit.org/show_bug.cgi?id=36398
Fix building with newest GTK+ versions.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::contentsSizeChanged):
- webkit/webkitprivate.cpp: (currentToplevelCallback):
- webkit/webkitwebframe.cpp: (webkit_web_frame_print_full): (webkit_web_frame_print):
- webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event): (webkit_web_view_script_dialog):
- 5:52 AM Changeset in webkit [56386] by
-
- 16 edits in trunk
2010-03-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389
No new tests as there is no new functionality.
- WebCore.pri:
- WebCore.pro:
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::willLoadFromCache):
- platform/qt/CookieJarQt.cpp: (WebCore::setCookies): (WebCore::cookies):
- platform/qt/KURLQt.cpp: (WebCore::KURL::operator QUrl):
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner):
- plugins/mac/PluginViewMac.cpp:
2010-03-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389
- Api/qwebelement.cpp: (QWebElement::classes):
- Api/qwebpage.cpp: (QWebPagePrivate::editorActionForKeyEvent): (QWebPage::userAgentForUrl):
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
- tests/tests.pro:
2010-03-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389
- DumpRenderTree/qt/main.cpp: (main):
- QtLauncher/mainwindow.cpp: (MainWindow::MainWindow):
- 4:07 AM Changeset in webkit [56385] by
-
- 8 edits in trunk/WebCore
2010-03-23 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Add checks if setNeedsWillValidateCheck() and
setNeedsValidityCheck() are called correctly.
https://bugs.webkit.org/show_bug.cgi?id=34924
Introduce HTMLFormControlElement::m_willValidate and
m_isValid. They are the caches of willValidate() and
isValidFormControlElement(). setNeedsWillValidateCheck() updates
m_willValidate and setNeedsValidityCheck() updates m_isValid.
willValidate() and isValidFormControlElement() have assertions to
check m_willvalidate or m_isValid has the correct state. If
setNeedsWillValidateCheck() or setNeedsValidityCheck() is needed
to be called and is not called, these assertions fail.
- html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::recalcWillValidate):
- html/HTMLFieldSetElement.h: (WebCore::HTMLFieldSetElement::recalcWillValidate):
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::recalcWillValidate): (WebCore::HTMLFormControlElement::willValidate): (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): (WebCore::HTMLFormControlElement::validationMessage): (WebCore::HTMLFormControlElement::isValidFormControlElement): (WebCore::HTMLFormControlElement::setNeedsValidityCheck):
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::recalcWillValidate):
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setNonDirtyValue):
- 1:18 AM Changeset in webkit [56384] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, remove flaky tag in websocket tests.
flakiness in websocket tests (http://crbug.com/38397) introducted at
Chromium r41818 has been fixed at r42320.
- platform/chromium/test_expectations.txt: remove BUG38397
- 12:07 AM Changeset in webkit [56383] by
-
- 11 edits2 adds in trunk
2010-03-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dave Hyatt.
Web Inspector: display CSS selector source line in the styles sidebar pane.
This change adds a sourceLine field into the CSSStyleRule that is populated
from within the parser. CSSParser is now keeping track of the line numbers
and last selector line number that is being used while creating CSSStyleRules.
Test: inspector/styles-source-lines.html
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::lex): (WebCore::CSSParser::countLines): (WebCore::CSSParser::createStyleRule):
- css/CSSParser.h: (WebCore::CSSParser::updateLastSelectorLine):
- css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule):
- css/CSSStyleRule.h: (WebCore::CSSStyleRule::create): (WebCore::CSSStyleRule::sourceLine):
- css/tokenizer.flex:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForRule):
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration.parseRule):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
Mar 22, 2010:
- 11:48 PM Changeset in webkit [56382] by
-
- 4 edits3 adds in trunk
2010-03-22 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
Qt] Fix arc function in canvas
https://bugs.webkit.org/show_bug.cgi?id=36296
- platform/qt/Skipped:
- platform/qt/fast/canvas/arc360-expected.checksum: Added.
- platform/qt/fast/canvas/arc360-expected.png: Added.
- platform/qt/fast/canvas/arc360-expected.txt: Added.
2010-03-22 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix arc function in canvas
https://bugs.webkit.org/show_bug.cgi?id=36296
Based on HTLM5 spec (4.8.10.1.8 Complex shapes), arc function should draw a line to previous point, not only the arc.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
- 11:30 PM Changeset in webkit [56381] by
-
- 4 edits4 adds in trunk/WebKit/chromium
2010-03-22 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Add GraphicsContext3D abstraction to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36262
Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
GraphicsContext3D implementation to use it. All of the OpenGL calls have
been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
WebGraphicsContext3D implementation. GraphicsContext3D is still
responsible for the transfer of rendered output from the
WebGraphicsContext3D to the HTMLCanvasElement.
The GraphicsContext3DInternal class, which is a data member of
GraphicsContext3D for the Chromium port, remains. It is possible to
eliminate this class and thereby one level of delegation, but this is
being deferred.
The needed entry point for a Chrome implementation of
WebGraphicsContext3D has been added to WebKitClient, but it is not being
called yet by GraphicsContext3D. It will be once this patch lands and
Chromium is rolled forward to support this entry point.
This is a large patch, but the transformation is almost entirely
mechanical and there is no change in functionality. Nearly all of
GraphicsContext3D and GraphicsContext3DInternal has been moved to
WebGraphicsContext3DDefaultImpl. The only area where the splitting of
logic is less than mechanical is GraphicsContext3D::beginPaint() and its
callees.
Ran all WebGL layout tests and demos from Khronos site in Chromium
on Mac and Windows.
- WebKit.gyp:
- public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
- public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D):
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
- src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault):
- src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
- src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
- 11:08 PM Changeset in webkit [56380] by
-
- 3 edits4 adds in trunk
2010-03-19 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36339
This LayoutTest tests for webkit ability to process long invalid headers generated by misbehaving websockets servers.
- websocket/tests/long-invalid-header-expected.txt: Added.
- websocket/tests/long-invalid-header.html: Added.
- websocket/tests/long-invalid-header_wsh.py: Added.
- websocket/tests/script-tests/long-invalid-header.js: Added.
2010-03-19 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36339
Off-by-one memory corruption fix for long invalid websockets upgrade header
Test: websocket/tests/long-invalid-header.html
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
- 10:51 PM Changeset in webkit [56379] by
-
- 2 edits in trunk/LayoutTests
2010-03-22 David Kilzer <ddkilzer@apple.com>
Remove http/tests/cookies/simple-cookies-expired.html from skip list after CFNetwork issue is resolved
<http://webkit.org/b/25861>
<rdar://problem/6901322>
Reviewed by Darin Adler.
- platform/win/Skipped: Removed:
- http/tests/cookies/simple-cookies-expired.html
- 10:32 PM Changeset in webkit [56378] by
-
- 1 edit1 move in trunk/LayoutTests
2010-03-22 Eric Seidel <eric@webkit.org>
Rubber-stamped by Brady Eidson.
fast/loader/cancel-load-during-port-block-timer.html fails on Tiger bot
https://bugs.webkit.org/show_bug.cgi?id=36425
This test bleeds into the next test and causes failures. Unsure of the
cause. Brady suggests we disable it for now (to match the other disabled) api test.
- fast/loader/api-test-go-to-current-back-forward-item.html-disabled: Renamed from LayoutTests/fast/loader/api-test-go-to-current-back-forward-item.html.
- 10:03 PM Changeset in webkit [56377] by
-
- 2 edits in trunk/WebCore
2010-03-22 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed build fix for Chromim Mac at r56376
Fix initializer order of PopupContainer.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer):
- 8:01 PM Changeset in webkit [56376] by
-
- 10 edits in trunk
2010-03-22 Jay Campan <jcampan@google.com>
Reviewed by Darin Fisher.
Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062
- page/chromium/ChromeClientChromium.h:
- platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::~PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupMenu::show):
- platform/chromium/PopupMenuChromium.h: (WebCore::PopupContainer::): (WebCore::PopupContainer::popupType):
2010-03-22 Jay Campan <jcampan@google.com>
Reviewed by Darin Fisher.
Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062
- public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::popupClosed):
- src/ChromeClientImpl.h:
- src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::hideSelectPopup): (WebKit::WebViewImpl::popupOpened): (WebKit::WebViewImpl::popupClosed): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
- src/WebViewImpl.h:
- 7:21 PM Changeset in webkit [56375] by
-
- 4 edits2 adds in trunk
[v8] Crash if the worker is terminated before its initial script is executed.
https://bugs.webkit.org/show_bug.cgi?id=36336
Reviewed by Nate Chapin.
WebCore:
Test: fast/workers/termination-early.html
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Check for 0 context. When terminated, the v8 heap initialization returns 0.
(WebCore::WorkerContextExecutionProxy::evaluate): Don't execute script if initialization failed.
- bindings/v8/WorkerContextExecutionProxy.h:
LayoutTests:
- fast/workers/termination-early-expected.txt: Added.
- fast/workers/termination-early.html: Added.
- 7:11 PM Changeset in webkit [56374] by
-
- 2 edits in trunk/WebCore
2010-03-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Support creation of fake workers before document is loaded by deferring
attaching of fake workers iframe until document is loaded and buffering all
messages addressed to worker.
https://bugs.webkit.org/show_bug.cgi?id=36445
- inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype._buildWorker): (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument): (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):
- 6:31 PM Changeset in webkit [56373] by
-
- 4 edits in trunk/WebKit/qt
2010-03-22 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix qdoc warnings
https://bugs.webkit.org/show_bug.cgi?id=36447
- Api/qgraphicswebview.cpp: Add missing ().
- Api/qwebframe.cpp: Remove reference to non-existent parameter "url".
- Api/qwebsettings.cpp: Document parameter "location".
- 6:13 PM Changeset in webkit [56372] by
-
- 3 edits in trunk/WebKitTools
2010-03-22 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Adam Barth.
Make build_webkit_command() pass MAKEFLAGS environment variable to make.
https://bugs.webkit.org/show_bug.cgi?id=36440
- Scripts/webkitpy/webkitport.py:
- Scripts/webkitpy/webkitport_unittest.py:
- 5:28 PM Changeset in webkit [56371] by
-
- 1 edit1 add in trunk/WebKitSite
(Not reviewed.)
Add another example.
- demos/accessible-ascii-art/butterfly-figure.html: Added.
- 5:28 PM Changeset in webkit [56370] by
-
- 4 edits3 adds in trunk/JavaScriptCore
2010-03-22 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Symbian] More efficient aligned memory allocation for JSC Collector
https://bugs.webkit.org/show_bug.cgi?id=34350
- JavaScriptCore.pri: Added 2 new Symbian source files and HAL linkage
- runtime/Collector.cpp: Reduced port-specific code and added private data member (JSC::Heap::Heap): (JSC::Heap::~Heap): (JSC::Heap::destroy): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr):
- runtime/Collector.h: Added private data member
- wtf/symbian: Added.
- wtf/symbian/BlockAllocatorSymbian.cpp: Added. (WTF::AlignedBlockAllocator::AlignedBlockAllocator): Helper class to allocate aligned blocks more efficiently as required by Collector (WTF::AlignedBlockAllocator::alloc): (WTF::AlignedBlockAllocator::free): (WTF::AlignedBlockAllocator::destroy): (WTF::AlignedBlockAllocator::~AlignedBlockAllocator):
- wtf/symbian/BlockAllocatorSymbian.h: Added.
- 4:51 PM Changeset in webkit [56369] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, skip new failing test.
fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=36467
- platform/gtk/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.
- platform/qt/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.
- 4:43 PM Changeset in webkit [56368] by
-
- 1 edit2 adds in trunk/WebKitSite
(Not reviewed.)
Add example of accessible ASCII art for HTML WG.
- demos/accessible-ascii-art: Added.
- demos/accessible-ascii-art/butterfly.html: Added.
- 4:14 PM Changeset in webkit [56367] by
-
- 5 edits6 adds in trunk/LayoutTests
2010-03-22 Nate Chapin <Nate Chapin>
Unreviewed, Chromium test fixes.
- platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
- platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
- platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
- platform/chromium-linux/plugins/embed-attributes-style-expected.png:
- platform/chromium-mac/svg/filters/feColorMatrix-values-expected.checksum: Added.
- platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Added.
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum: Added.
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt: Added.
- 4:04 PM Changeset in webkit [56366] by
-
- 4 edits in trunk/WebKitTools
2010-03-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Change baseline_path() to point to the upstream locations for the
Chromium ports. Also change the reabselining scripts to use the
correct functions to get the baseline directories, and fix the
script's sys.path to pull in simplejson correctly.
- Scripts/rebaseline-chromium-webkit-tests:
- fix sys.path to pick up simplejson properly
- Scripts/webkitpy/layout_tests/port/chromium.py:
- change baseline_path() to use webkit_baseline_path()
- error out correctly if we can't find the chromium base dir
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- call baseline_path(), not chromium_baseline_path()
- 3:57 PM Changeset in webkit [56365] by
-
- 3 edits2 adds in trunk
2010-03-22 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
HistoryController::replaceState() should modify m_currentItem
instead of the current HistoryItem of the BackForwardList.
Test: fast/loader/stateobjects/replacestate-in-iframe.html
- loader/HistoryController.cpp: (WebCore::HistoryController::replaceState):
- 3:54 PM Changeset in webkit [56364] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Oops, fix spurious angle brackets around name in patch I landed manually
- 3:31 PM Changeset in webkit [56363] by
-
- 5 edits in trunk/WebCore
2010-03-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283> and <rdar://problem/7707318>
Part 3 of 3: Shared code between iphone and mac. The shared code was
refactored to be usable by both platforms without platform specific
typing, meaning no NSEvent versus WebEvent special cases.
Shared code usable by either mac or iphone platforms.
- platform/cocoa/KeyEventCocoa.h:
- platform/cocoa/KeyEventCocoa.mm: (WebCore::keyIdentifierForCharCode): (WebCore::windowsKeyCodeForKeyCode): (WebCore::windowsKeyCodeForCharCode):
Make use of the shared code. Keep anything platform specific in the
original file before calling the shared code.
- platform/iphone/KeyEventIPhone.mm: (WebCore::keyIdentifierForKeyEvent):
- platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent):
- 3:17 PM Rebaseline edited by
- (diff)
- 3:15 PM Rebaseline edited by
- Added title. (diff)
- 3:09 PM Rebaseline edited by
- Clean up rebaseline doc. (diff)
- 3:05 PM Changeset in webkit [56362] by
-
- 8 edits3 deletes in trunk
Reviewed by Simon Fraser.
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing the missing plug-in indicator. (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::paintReplaced): Ditto.
- rendering/RenderEmbeddedObject.h: Ditto. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto.
- Plugins/WebNetscapePluginView.mm:
- Plugins/WebNullPluginView.h: Removed.
- Plugins/WebNullPluginView.mm: Removed.
- Resources/nullplugin.tiff: Removed.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
- 2:56 PM Changeset in webkit [56361] by
-
- 3 edits1 copy2 adds in trunk/WebCore
2010-03-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>
Part 2 of 3: No changes other than moving code around.
Copied KeyEvent function from platform/mac to a platform/cocoa shared directory.
- WebCore.xcodeproj/project.pbxproj: Added cocoa group and new files.
- platform/cocoa/KeyEventCocoa.h: Added.
- platform/cocoa/KeyEventCocoa.mm: Copied from WebCore/platform/mac/KeyEventMac.mm. (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent): Include the shared code.
- platform/mac/KeyEventMac.mm:
- 2:24 PM Changeset in webkit [56360] by
-
- 3 edits3 adds in trunk/WebCore
2010-03-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Part 1 of 3: Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>
- WebCore.xcodeproj/project.pbxproj: Added iphone group and new files.
- platform/iphone: Added.
- platform/iphone/KeyEventCodesIPhone.h: Added.
- platform/iphone/KeyEventIPhone.mm: Added. Ensure PLATFORM(IPHONE)
- platform/mac/KeyEventMac.mm: Ensure PLATFORM(MAC)
- 2:14 PM Changeset in webkit [56359] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Skip editing test that fails
- platform/qt/Skipped:
- 2:08 PM Changeset in webkit [56358] by
-
- 2 edits in trunk/LayoutTests
2010-03-22 Dirk Schulze <krit@webkit.org>
Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714
SVG Test has text in it. This caused a wrong DRT result on Mac.
The other result was created on Windows.
- platform/mac/svg/filters/feColorMatrix-values-expected.txt:
- 1:38 PM Changeset in webkit [56357] by
-
- 2 edits in trunk/WebCore
Attempt to fix the Leopard build.
- rendering/RenderEmbeddedObject.cpp: Add ".f" to contants.
- 1:28 PM Changeset in webkit [56356] by
-
- 1 edit1 add in trunk/LayoutTests
2010-03-22 Dirk Schulze <krit@webkit.org>
Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714
Add missing expected result.
- platform/mac/svg/filters/feColorMatrix-values-expected.txt: Added.
- 1:24 PM QtWebKitBackportingFixes edited by
- (diff)
- 12:46 PM Changeset in webkit [56355] by
-
- 3 edits7 adds in trunk
2010-03-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714
Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.
Tests: svg/filters/feColorMatrix-invalid-value.svg
svg/filters/feColorMatrix-values.svg
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
2010-03-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714
Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.
- platform/win/svg/filters: Added.
- platform/win/svg/filters/feColorMatrix-values-expected.checksum: Added.
- platform/win/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/win/svg/filters/feColorMatrix-values-expected.txt: Added.
- svg/filters/feColorMatrix-invalid-value-expected.txt: Added.
- svg/filters/feColorMatrix-invalid-value.svg: Added.
- svg/filters/feColorMatrix-values.svg: Added.
- 12:37 PM Changeset in webkit [56354] by
-
- 4 edits2 adds in trunk/WebCore
2010-03-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] Use ImageBuffer API to do painting
https://bugs.webkit.org/show_bug.cgi?id=35783
New ImageGStreamer class abstracting the conversion of GStreamer
buffers to cairo surfaces. Using this makes the painting code of
the player more generic.
- GNUmakefile.am:
- platform/graphics/gstreamer/ImageGStreamer.h: Added. (WebCore::ImageGStreamer::image):
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Added. (ImageGStreamer::createImage): (ImageGStreamer::ImageGStreamer): (ImageGStreamer::~ImageGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 12:36 PM Changeset in webkit [56353] by
-
- 2 edits in trunk/WebCore
Fix for <rdar://problem/7766437> With Web Inspector opened, a crash
occurs at Webcore:getMatchedCSSRules() when navigating to a
previous page
Reviewed by Darin Adler.
defaultView() can legitimately by null (as it is in this case), so
it must be null-checked.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyles):
(WebCore::InspectorDOMAgent::getComputedStyle):
(WebCore::InspectorDOMAgent::getMatchedCSSRules):
- 12:30 PM Changeset in webkit [56352] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin): Call setShowsMissingPluginIndicator(true) in cases that fail to generate a widget.
- rendering/RenderEmbeddedObject.cpp: Added new missing plug-in related static constants (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Initialize newly boolean to false. (WebCore::RenderEmbeddedObject::paint): Added. (WebCore::RenderEmbeddedObject::paintReplaced): Added. Draws a subtle rounded rectangle containing the text "Missing Plug-in".
- rendering/RenderEmbeddedObject.h: Added the following two methods below. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
- rendering/RenderWidget.h: Moved paint(PaintInfo&, int, int) from private to protected.
- 11:45 AM Changeset in webkit [56351] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=36455
Make WebKit more resistant against plug-in crashes
No tests, because crashing on build bots isn't good, even if it's only helper processes
that crash.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function needs it after waiting for reply. Some callers used to do this, but not all, and we really shouldn't depend on callers here.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy, because this function doesn't use it after waiting for reply. (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto.
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy null check for another code path.
- 11:44 AM Changeset in webkit [56350] by
-
- 2 edits in trunk/LayoutTests
2010-03-22 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations tweak.
Add fast/dom/error-to-string-stack-overflow.html to expected
failures due to http://trac.webkit.org/changeset/56329.
- platform/chromium/test_expectations.txt:
- 11:40 AM Changeset in webkit [56349] by
-
- 5 edits in trunk
2010-03-22 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Phonon media backend: expose supported MIME types to WebCore
List all skipped media tests individually and unskip two fixed by the patch.
- platform/qt/Skipped:
2010-03-22 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Phonon media backend: expose supported MIME types to WebCore
MediaPlayerPrivate should expose the MIME types that are supported
by the underlying backend in Phonon.
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::supportedTypesCache): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType):
- platform/graphics/qt/MediaPlayerPrivatePhonon.h:
- 11:33 AM Changeset in webkit [56348] by
-
- 6 edits2 adds in trunk
JavaScriptCore: Fixed <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)
Reviewed by Sam Weinig.
Two ways to fix the same bug:
- Check for overflow when negating, since negating the largest negative
int causes overflow.
- Constant-fold even when negating a negative, since, like they say in
high school, "math works."
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchNeg32):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchNeg32): Added a branching version
of the negate operator.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate): Use the branching version of the negate
operator to check for overflow.
(JSC::JIT::emitSlow_op_negate): Link the check for overflow to a slow case.
(We could emit inline code for this, since we know what the result would
be, but that's probably just a waste of generated code.)
- parser/Grammar.y: Constant fold even when negating a negative.
LayoutTests: Added a test for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)
Reviewed by Sam Weinig.
- fast/js/negate-overflow-expected.txt: Added.
- fast/js/negate-overflow.html: Added.
- 11:18 AM Changeset in webkit [56347] by
-
- 3 edits in trunk/WebCore
2010-03-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: AuditRules still use getMatchedCSSRules as a part of the img-related audit.
https://bugs.webkit.org/show_bug.cgi?id=36424
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 11:17 AM Changeset in webkit [56346] by
-
- 3 edits2 adds in trunk
2010-03-22 Darin Fisher <darin@chromium.org>
Reviewed by Nate Chapin.
[chromium] Renderer crashes when navigating to a reference fragment in
a frame that has no current HistoryItem.
Test: fast/loader/crash-replacing-location-before-load.html
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
- 10:51 AM Changeset in webkit [56345] by
-
- 2 edits in trunk/WebCore
2010-03-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
TextBreakIteratorICU.cpp is incompatible with new UBreakIterator type in ICU 4.4
https://bugs.webkit.org/show_bug.cgi?id=36381
- platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Use reinterpret_cast instead of static_cast or relying on conversion to void*. (WebCore::textBreakFirst): Ditto. (WebCore::textBreakLast): Ditto. (WebCore::textBreakNext): Ditto. (WebCore::textBreakPrevious): Ditto. (WebCore::textBreakPreceding): Ditto. (WebCore::textBreakFollowing): Ditto. (WebCore::textBreakCurrent): Ditto. (WebCore::isTextBreak): Ditto. (WebCore::setUpIteratorWithRules): Ditto.
- 10:48 AM Changeset in webkit [56344] by
-
- 8 edits in trunk/WebCore
2010-03-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
Typo in GPL license text
https://bugs.webkit.org/show_bug.cgi?id=36442
Fix typo - "aint with this library" -> "along with this library".
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/IDLParser.pm:
- bindings/scripts/IDLStructure.pm:
- bindings/scripts/generate-bindings.pl:
- 10:42 AM Changeset in webkit [56343] by
-
- 5 edits in trunk
2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373
Instead, keep one instance per RenderTheme around.
- platform/qt/RenderThemeQt.cpp: (WebCore::findFrameLineWidth):
2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373
Add a simple benchmark covering this area.
- tests/benchmarks/painting/tst_painting.cpp: (tst_Painting::textAreas):
- 10:39 AM Changeset in webkit [56342] by
-
- 3 edits in trunk/JavaScriptCore
<http://webkit.org/b/36431> Clean up 'int' use in UString.cpp after r54789
Reviewed by Darin Adler.
- runtime/UString.cpp:
(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
(JSC::UString::find): Changed static_cast<int>() to
static_cast<unsigned>() now that this method returns unsigned.
(JSC::UString::rfind): Ditto.
- runtime/UString.h:
(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
- 10:38 AM Changeset in webkit [56341] by
-
- 3 edits in trunk/WebCore
2010-03-22 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Multiselect Popup - adjusting QtAbstractWebPopup
https://bugs.webkit.org/show_bug.cgi?id=36186
QtAbstractWebPopup must provide new methods to be used by its descendants that
wish to handle <select multiple> elements.
- platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::selectItem): (WebCore::QtAbstractWebPopup::multiple):
- platform/qt/QtAbstractWebPopup.h:
- 10:20 AM Changeset in webkit [56340] by
-
- 4 edits10 adds in trunk
2010-03-22 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Basic tests of mfrac (fractions)
- mathml/presentation/fractions.xhtml: Added.
- mathml/presentation/fractions-vertical-alignment.xhtml: Added
- platform/mac/mathml/presentation/fractions-expected.checksum: Added.
- platform/mac/mathml/presentation/fractions-expected.png: Added.
- platform/mac/mathml/presentation/fractions-expected.txt: Added.
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum: Added.
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
2010-03-22 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added basic support for mfrac (fractions)
Test: mathml/presentation/fractions.xhtml
- WebCore.xcodeproj/project.pbxproj:
- mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/RenderMathMLFraction.cpp: Added. (WebCore::RenderMathMLFraction::RenderMathMLFraction): (WebCore::RenderMathMLFraction::updateFromElement): (WebCore::RenderMathMLFraction::addChild):
- mathml/RenderMathMLFraction.h: Added.
- 9:47 AM Changeset in webkit [56339] by
-
- 4 edits in trunk/WebKit
WebKit: * StringsNotToBeLocalized.txt: Updated for recent changes.
WebKit/win: * WebCoreLocalizedStrings.cpp:
(WebCore::missingPluginText): Fixed localization helper text to match the same
string from Mac WebKit.
- 9:46 AM Rebaseline created by
- Ported rebaseline tool documentation from Chromium wiki
- 9:45 AM Changeset in webkit [56338] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=36400
Add a test for r15750 (Flash crashes after it replaces itself via a document.write())
- plugins/destroy-plugin-from-callback-expected.txt: Added.
- plugins/destroy-plugin-from-callback.html: Added.
- 9:29 AM Changeset in webkit [56337] by
-
- 14 edits in trunk
Reviewed by John Sullivan.
- page/mac/WebCoreViewFactory.h: Added -missingPluginText method
- platform/LocalizedStrings.h: Added missingPluginText()
- platform/gtk/LocalizedStringsGtk.cpp: Likewise.
- platform/mac/LocalizedStringsMac.mm: Same here.
- platform/qt/Localizations.cpp: Ditto.
- English.lproj/Localizable.strings: Added "Missing Plug-in" string.
- src/LocalizedStrings.cpp: (WebCore::missingPluginText): Added
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory missingPluginText]): Added.
- 9:24 AM Changeset in webkit [56336] by
-
- 2 edits in trunk/WebKitTools
2010-03-22 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Refactored the cpu_count() code in executive.py.
- Scripts/webkitpy/executive.py:
- Moved the import of the multiprocessing module to the top of the file rather than importing from within a function.
- 8:24 AM Changeset in webkit [56335] by
-
- 3 edits in trunk/WebKitTools
Revert "2010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>"
This reverts commit d76f355a659be5b3384f9c26bc6ad64f3256c9fb.
Conflicts:
WebKitTools/ChangeLog
- 8:09 AM Changeset in webkit [56334] by
-
- 3 edits in trunk/WebKit/qt
2010-03-22 Yi Shen <shenyi2006@gmail.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=35933
[Qt] [Symbian] Can not backward select (highlight) text using virtual keyboard
Make sure the selection start index is smaller than the selection end index.
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
- 7:37 AM Changeset in webkit [56333] by
-
- 7 edits3 adds in trunk/JavaScriptCore
2010-03-22 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Add support for syntax checking in the QtScript API.
New class was created; the QScriptSyntaxCheckResult which main
responsibility is to provide results of the ECMA Script code
syntax check. The class is not fully functional as the JSC C API
doesn't expose an error column number, but it is a good start point
for a future development.
[Qt] QtScript functionality should be extended by syntax checking.
https://bugs.webkit.org/show_bug.cgi?id=36123
- qt/api/QtScript.pro:
- qt/api/qscriptengine.cpp: (QScriptEngine::checkSyntax):
- qt/api/qscriptengine.h:
- qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
- qt/api/qscriptengine_p.h:
- qt/api/qscriptsyntaxcheckresult.cpp: Added. (QScriptSyntaxCheckResult::QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::~QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::operator=): (QScriptSyntaxCheckResult::state): (QScriptSyntaxCheckResult::errorLineNumber): (QScriptSyntaxCheckResult::errorColumnNumber): (QScriptSyntaxCheckResult::errorMessage):
- qt/api/qscriptsyntaxcheckresult.h: Added.
- qt/api/qscriptsyntaxcheckresult_p.cpp: Added. (QScriptSyntaxCheckResultPrivate::~QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):
- qt/api/qscriptsyntaxcheckresult_p.h: Added. (QScriptSyntaxCheckResultPrivate::get): (QScriptSyntaxCheckResultPrivate::QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::state): (QScriptSyntaxCheckResultPrivate::errorColumnNumber):
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::checkSyntax_data): (tst_QScriptEngine::checkSyntax):
- 6:26 AM Changeset in webkit [56332] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Fix inspected Page crash in destructor when Web Inspector is open.
- src/js/InjectDispatch.js: (inspectedPageDestroyed): Added stub for missing method.
- 5:49 AM Changeset in webkit [56331] by
-
- 2 edits1 copy1 add in trunk/WebKitTools
Created a function for getting a module-specific logging.logger
based on the file value of the module.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35821
This function allows us to get the module-specific logger for
a module without having to hard-code the fully-qualified name
of the module in the module itself. The code can be the same
in every case: "_log = logutils.get_logger(file)".
- Scripts/webkitpy/init/logutils.py: Added.
- Added a module with a get_logger() function to return a module-specific logger based on the module's file variable.
- Scripts/webkitpy/init/logutils_unittest.py: Added.
- Added unit tests for logutils.py.
- Scripts/webkitpy/init/unittests.py:
- Added logutils_unittest to the list of imports.
- 4:43 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:07 AM Changeset in webkit [56330] by
-
- 3 edits in trunk/WebKit/chromium
2010-03-22 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Added methods to WebSecurityOrigin for invoking
SecurityOrigin::canAccess and SecurityOrigin::Create
https://bugs.webkit.org/show_bug.cgi?id=36356
- public/WebSecurityOrigin.h:
- src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::create): (WebKit::WebSecurityOrigin::canAccess):
- 2:46 AM Changeset in webkit [56329] by
-
- 8 edits1 add in trunk
2010-03-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Handle worker exceptions in V8MessageHandler like it's done in regular documents. This way all worker exceptions will be logged in the console not only those which happen in event listeners.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): Removed explicit call to reportException.
- bindings/v8/V8Utilities.cpp: reportException function was removed since it's not used. (WebCore::getScriptExecutionContext):
- bindings/v8/V8Utilities.h:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::v8MessageHandler): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Setup message handler when first worker context is created.
2010-03-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Test that uncaught exception thrown from setTimeout callback in a Worker is reported to the worker object.
- fast/workers/resources/worker-exception-in-timeout-callback.js: Added.
- fast/workers/worker-script-error-expected.txt:
- fast/workers/worker-script-error.html:
- 2:43 AM Changeset in webkit [56328] by
-
- 4 edits in trunk
2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386
- platform/qt/Skipped: unskip the test as it now passes.
2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386
Fix the regression by implementing a null printer for Qt DRT.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::NullPrinter::NullPaintEngine::begin): (WebCore::NullPrinter::NullPaintEngine::end): (WebCore::NullPrinter::NullPaintEngine::type): (WebCore::NullPrinter::NullPaintEngine::drawPixmap): (WebCore::NullPrinter::NullPaintEngine::updateState): (WebCore::NullPrinter::paintEngine): (WebCore::DumpRenderTree::dryRunPrint):
- 2:24 AM Changeset in webkit [56327] by
-
- 2 edits in trunk/WebCore
2010-03-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Simon Hausmann.
Add EFL-specific code to page/EventHandler.cpp.
http://webkit.org/b/36306
- page/EventHandler.cpp:
- 2:06 AM Changeset in webkit [56326] by
-
- 3 edits in trunk/WebCore
2010-03-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Simon Hausmann.
Add EFL-specific code to platform/DragImage.h and
platform/DragData.h.
http://webkit.org/b/36310
- platform/DragImage.h:
- platform/DragData.h:
- 1:45 AM Changeset in webkit [56325] by
-
- 2 edits in trunk/WebCore
2010-03-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Simon Hausmann.
Add EFL-specific code to platform/FileSystem.h.
http://webkit.org/b/36313
- platform/FileSystem.h:
- 1:26 AM Changeset in webkit [56324] by
-
- 2 edits in trunk/WebCore
2010-03-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Simon Hausmann.
Add EFL-specific code to platform/Cursor.h.
http://webkit.org/b/36319
- platform/Cursor.h:
- 1:05 AM Changeset in webkit [56323] by
-
- 2 edits in trunk/WebCore
2010-03-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Simon Hausmann.
Add EFL-specific code to platform/NotImplemented.h.
http://webkit.org/b/36320
- platform/NotImplemented.h:
Mar 21, 2010:
- 4:21 PM Changeset in webkit [56322] by
-
- 3 edits in trunk/WebKit/qt
2010-03-21 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Simon Hausmann.
Fixed updating the VKB display when inputting into QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=36292
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_updateMicroFocus): (QGraphicsWebView::setPage):
- Api/qgraphicswebview.h:
- 3:52 PM Changeset in webkit [56321] by
-
- 2 edits in trunk/WebCore
2010-03-21 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: matrix interpolations in transform-animations don't behave correctly
https://bugs.webkit.org/show_bug.cgi?id=35520
The case where the list of source and target transform operations are
not the same but have the same size needs to be special-cased in
GraphicsLayerQt, as well as the case where the source or target
operation list is empty. The URLs listed here render correctly after
applying the patch.
Tests: https://bug-35520-attachments.webkit.org/attachment.cgi?id=49890
https://bug-35520-attachments.webkit.org/attachment.cgi?id=49889
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::TransformAnimationQt::applyFrame):
- 3:30 PM Changeset in webkit [56320] by
-
- 7 edits1 copy2 adds in trunk/JavaScriptCore
2010-03-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
New class; QScriptProgram.
The class should be used to evaluate the same script multiple times
more efficiently.
[Qt] QtScript should have QScriptProgram class
https://bugs.webkit.org/show_bug.cgi?id=36008
- qt/api/QtScript.pro:
- qt/api/qscriptengine.cpp: (QScriptEngine::evaluate):
- qt/api/qscriptengine.h:
- qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::evaluate):
- qt/api/qscriptengine_p.h: (QScriptEnginePrivate::evaluate):
- qt/api/qscriptprogram.cpp: Added. (QScriptProgram::QScriptProgram): (QScriptProgram::~QScriptProgram): (QScriptProgram::operator=): (QScriptProgram::isNull): (QScriptProgram::sourceCode): (QScriptProgram::fileName): (QScriptProgram::firstLineNumber): (QScriptProgram::operator==): (QScriptProgram::operator!=):
- qt/api/qscriptprogram.h: Added.
- qt/api/qscriptprogram_p.h: Added. (QScriptProgramPrivate::get): (QScriptProgramPrivate::QScriptProgramPrivate): (QScriptProgramPrivate::~QScriptProgramPrivate): (QScriptProgramPrivate::isNull): (QScriptProgramPrivate::sourceCode): (QScriptProgramPrivate::fileName): (QScriptProgramPrivate::firstLineNumber): (QScriptProgramPrivate::operator==): (QScriptProgramPrivate::operator!=): (QScriptProgramPrivate::program): (QScriptProgramPrivate::file): (QScriptProgramPrivate::line):
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::evaluateProgram):
- 3:19 PM Changeset in webkit [56319] by
-
- 5 edits2 adds in trunk
<http://webkit.org/b/14858> <col> width ignored when not tied to a single cell
Patch by Dmitry Gorbik <socket.h@gmail.com> on 2010-03-21
Reviewed by David Kilzer.
Fixed width calculation for cells with span when <col> is defined.
WebCore:
Test: fast/table/col-width-span-expand.html
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleOrColWidth): Added the calculation of cell width
in case of <col> defined and span > 1.
LayoutTests:
- fast/table/col-width-span-expand-expected.txt: Added.
- fast/table/col-width-span-expand.html: Added.
- 1:08 PM Changeset in webkit [56318] by
-
- 3 edits in trunk/JavaScriptCore
Blind attempt #2 to fix the Windows build after r56314
- API/tests/testapi.c: Include JSObjectRefPrivate.h for the new
methods instead of declaring them locally (and non-extern).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Backed out previous change.
- 12:56 PM Changeset in webkit [56317] by
-
- 2 edits in trunk/JavaScriptCore
Blind attempt to fix the Windows build after r56314
Try to fix the following errors on the Windows buildbot:
Linking...
testapi.obj : error LNK2001: unresolved external symbol "bool cdecl JSObjectSetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *,struct OpaqueJSValue const *)" (?JSObjectSetPrivateProperty@@YA_NPBUOpaqueJSContext@@PAUOpaqueJSValue@@PAUOpaqueJSString@@PBU2@@Z)
testapi.obj : error LNK2001: unresolved external symbol "struct OpaqueJSValue const * cdecl JSObjectGetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *)" (?JSObjectGetPrivateProperty@@YAPBUOpaqueJSValue@@PBUOpaqueJSContext@@PAU1@PAUOpaqueJSString@@@Z)
C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\bin\testapi.exe : fatal error LNK1120: 2 unresolved externals
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added
missing symbols to be exported.
- 12:09 PM Changeset in webkit [56316] by
-
- 4 edits in trunk
2010-03-20 Martin Robinson <Martin Robinson>
Reviewed by Xan Lopez
[GTK] eventSender.zoomPageOut() bug?
https://bugs.webkit.org/show_bug.cgi?id=30575
Unskip some tests that were failing because of the bug in DRT.
- platform/gtk/Skipped:
2010-03-20 Martin Robinson <Martin Robinson>
Reviewed by Xan Lopez.
[GTK] eventSender.zoomPageOut() bug?
https://bugs.webkit.org/show_bug.cgi?id=30575
Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.
- DumpRenderTree/gtk/EventSender.cpp: (zoomIn): Added. (zoomOut): Added. (textZoomInCallback): Use zoomIn helper function. (textZoomOutCallback): Use zoomOut helper function. (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor. (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.
- 5:22 AM QtWebKitPlugins edited by
- (diff)
- 1:35 AM Changeset in webkit [56315] by
-
- 2 edits in trunk/JavaScriptCore
Documentation fix for previous patch.
Reviewed by Maciej Stachowiak.
- API/JSObjectRefPrivate.h:
- 12:40 AM Changeset in webkit [56314] by
-
- 6 edits1 add in trunk/JavaScriptCore
2010-03-20 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
JSC needs an API to allow custom objects to have aprivate GC-accessible properties
https://bugs.webkit.org/show_bug.cgi?id=36420
Add new API methods to support "private" properties on custom
objects.
- API/JSCallbackObject.h: (JSC::JSCallbackObjectData::JSCallbackObjectData): (JSC::JSCallbackObjectData::~JSCallbackObjectData): (JSC::JSCallbackObjectData::getPrivateProperty): (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::deletePrivateProperty): (JSC::JSCallbackObjectData::markChildren): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::deletePrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::getPrivateProperty): (JSC::JSCallbackObject::setPrivateProperty): (JSC::JSCallbackObject::deletePrivateProperty): (JSC::JSCallbackObject::markChildren):
- API/JSObjectRef.cpp: (JSObjectGetPrivateProperty): (JSObjectSetPrivateProperty): (JSObjectDeletePrivateProperty):
- API/JSObjectRefPrivate.h: Added.
- API/tests/testapi.c: (main):
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
Mar 20, 2010:
- 7:45 PM Changeset in webkit [56313] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix after recent database API change.
- 5:39 PM Changeset in webkit [56312] by
-
- 4 edits in trunk/WebKitTools
2010-03-20 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Renamed UnitTestLogStream to TestLogStream in webkitpy.
TestLogStream is more concise and more consistent with the name of
the module (logtesting rather than logunittesting) and its main
class (LogTesting rather than LogUnitTesting).
- Scripts/webkitpy/init/logtesting.py:
- Renamings.
- Scripts/webkitpy/style/checker_unittest.py:
- Renamings.
- Scripts/webkitpy/style_references.py:
- Renamings.
- 3:20 PM Changeset in webkit [56311] by
-
- 3 edits in trunk/WebCore
Spatial Navigation: Code simplification in FocusController.cpp and SpatialNavigation.cpp (part I)
https://bugs.webkit.org/show_bug.cgi?id=36168
Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Make use of isNull and document methods introduced in FocusCandidate class by patch in bug 36167.
No functionalty change.
- page/FocusController.cpp:
(WebCore::updateFocusCandidateIfCloser):
- page/SpatialNavigation.cpp:
(WebCore::distanceInDirection):
- 2:00 PM Changeset in webkit [56310] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
2010-03-20 Dirk Pranke <dpranke@chromium.org>
Unreviewed change.
Fix typo in Changelog.
- WebKitTools/ChangeLog:
- 1:05 PM Changeset in webkit [56309] by
-
- 15 edits in trunk
[wx] Build fixes after recent changes.
- 12:21 PM Changeset in webkit [56308] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed, expectations tweak.
Remove expectations for chromium-mac editing/style/apply-through-end-of-document.html as it
now matches platform/mac.
- platform/chromium-mac/editing/style/apply-through-end-of-document-expected.txt: Removed.
- platform/chromium/test_expectations.txt: Adjusted expectations.
- 12:10 PM Changeset in webkit [56307] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, tool fix.
Remove vestiges of downstream directory names to unbreak rebaselining tool.
- Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.
- 10:21 AM Changeset in webkit [56306] by
-
- 2 edits in trunk/WebKitTools
2010-03-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Re-enable the downstream test_expectations overrides file that was
disabled in bug 36396 / r56287.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 10:14 AM Changeset in webkit [56305] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, expectations tweak.
Mark editing/style/apply-through-end-of-document.html as failing
- platform/chromium/test_expectations.txt:
- 9:56 AM Changeset in webkit [56304] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, expectations tweak.
Marked svg/filters/filterRes.svg as failing after
http://trac.webkit.org/changeset/56288/
- platform/chromium/test_expectations.txt: Added expectations for svg/filters/filterRes.svg.
- 9:31 AM Changeset in webkit [56303] by
-
- 4 edits4 deletes in trunk/WebKit/chromium
2010-03-20 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r56294.
http://trac.webkit.org/changeset/56294
https://bugs.webkit.org/show_bug.cgi?id=36262
Broke compile on Chromium canaries.
- WebKit.gyp:
- public/WebGraphicsContext3D.h: Removed.
- public/WebKitClient.h:
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::): (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig): (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext): (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent): (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext): (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext): (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::create): (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection): (WebCore::GraphicsContext3DInternal::VertexAttribPointerState::VertexAttribPointerState): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::createTextureObject): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::flipVertically): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::activeTexture): (WebCore::GraphicsContext3DInternal::bindBuffer): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferDataImpl): (WebCore::GraphicsContext3DInternal::disableVertexAttribArray): (WebCore::GraphicsContext3DInternal::enableVertexAttribArray): (WebCore::GraphicsContext3DInternal::getError): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::vertexAttribPointer): (WebCore::GraphicsContext3DInternal::viewportImpl): (WebCore::GraphicsContext3DInternal::synthesizeGLError): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport):
- src/WebGraphicsContext3D.cpp: Removed.
- src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
- src/WebGraphicsContext3DDefaultImpl.h: Removed.
- 2:07 AM Changeset in webkit [56302] by
-
- 4 edits in trunk/WebKitSite
2010-03-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
WebKit blog should be valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=36410
- blog/wp-content/themes/webkit/comments-popup.php:
- blog/wp-content/themes/webkit/footer.php:
- blog/wp-content/themes/webkit/header.php:
- 2:04 AM Changeset in webkit [56301] by
-
- 3 edits in trunk/WebCore
2010-03-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Assertion failure in media/video-controls-with-mutation-event-handler.html
https://bugs.webkit.org/show_bug.cgi?id=36376
Test: media/video-controls-with-mutation-event-handler.html
Break early (when not attached) in the defaultEventHandler before the
slider is completely set up.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):
- 1:12 AM Changeset in webkit [56300] by
-
- 24 edits in trunk/WebKitSite
2010-03-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Fix a bunch of HTML5 validation errors on various pages.
https://bugs.webkit.org/show_bug.cgi?id=36409
- building/build.html:
- building/checkout.html:
- building/debug.html:
- building/run.html:
- building/tools.html:
- coding/coding-style.html:
- coding/contributing.html:
- coding/major-objects.html:
- css/main.css: (.asciiart):
- demos/index.html:
- header.inc:
- projects/compat/index.html:
- projects/css/index.html:
- projects/documentation/index.html:
- projects/goals.html:
- projects/index.html:
- projects/mathml/index.html:
- quality/bugpriorities.html:
- quality/bugwriting.html:
- quality/crashlogs.html:
- quality/lifecycle.html:
- quality/testing.html:
- quality/testwriting.html:
- 12:24 AM Changeset in webkit [56299] by
-
- 6 edits in trunk/WebKitSite
2010-03-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
webkit.org should use the HTML5 doctype
https://bugs.webkit.org/show_bug.cgi?id=36407
- header.inc:
- misc/drosera/index.html:
- perf/slickspeed/system/index.php:
- perf/slickspeed/system/template.php:
- specs/index.html:
Mar 19, 2010:
- 11:42 PM Changeset in webkit [56298] by
-
- 2 edits in trunk/WebKitSite
2010-03-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
http://webkit.org/ has an HTML5 validation error
https://bugs.webkit.org/show_bug.cgi?id=36406
- nav.inc:
- 10:29 PM Changeset in webkit [56297] by
-
- 3 edits2 adds in trunk
2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
https://bugs.webkit.org/show_bug.cgi?id=34641
- fast/css/first-letter-block-form-controls-crash-expected.txt: Added.
- fast/css/first-letter-block-form-controls-crash.html: Added.
2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
https://bugs.webkit.org/show_bug.cgi?id=34641
Don't dig into buttons and menu lists when finding which element
should be modified by :first-letter pseudo class. Even before
this change, we didn't dig into inline buttons and menu lists as
they are replaced so this issue wasn't found long time.
Test: fast/css/first-letter-block-form-controls-crash.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
- 9:29 PM Changeset in webkit [56296] by
-
- 1 edit1 add in trunk/LayoutTests
Land a test result that should have been added along with the test in r56286.
- transitions/transition-end-event-destroy-iframe-expected.txt: Copied from LayoutTests/transitions/transition-end-event-destroy-renderer-expected.txt.
- 8:55 PM Changeset in webkit [56295] by
-
- 11 edits2 copies2 adds in trunk
2010-03-19 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Change XSSAuditor block syntax
https://bugs.webkit.org/show_bug.cgi?id=34436
Update tests to account for the new blocking syntax. Added test for
disabling the XSS filter.
- http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header.html:
- http/tests/security/xssAuditor/no-protection-script-tag-expected.txt: Added.
- http/tests/security/xssAuditor/no-protection-script-tag.html: Added.
- http/tests/security/xssAuditor/resources/echo-head-base-href.pl:
- http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl:
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
- http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt: Added.
- http/tests/security/xssAuditor/xss-protection-parsing-01.html: Added.
2010-03-19 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Change XSSAuditor block syntax
https://bugs.webkit.org/show_bug.cgi?id=34436
Update our blocking syntax to something more reasonable. Also,
implemented a way for a web site to disable the filter.
Tests: http/tests/security/xssAuditor/no-protection-script-tag.html
http/tests/security/xssAuditor/xss-protection-parsing-01.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::xssProtection): (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h:
- platform/network/HTTPParsers.cpp: (WebCore::skipToken): (WebCore::parseXSSProtectionHeader):
- platform/network/HTTPParsers.h: (WebCore::):
- 8:35 PM Changeset in webkit [56294] by
-
- 4 edits4 adds in trunk/WebKit/chromium
2010-03-19 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Add GraphicsContext3D abstraction to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36262
Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
GraphicsContext3D implementation to use it. All of the OpenGL calls have
been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
WebGraphicsContext3D implementation. GraphicsContext3D is still
responsible for the transfer of rendered output from the
WebGraphicsContext3D to the HTMLCanvasElement.
The GraphicsContext3DInternal class, which is a data member of
GraphicsContext3D for the Chromium port, remains. It is possible to
eliminate this class and thereby one level of delegation, but this is
being deferred.
The needed entry point for a Chrome implementation of
WebGraphicsContext3D has been added to WebKitClient, but it is not being
called yet by GraphicsContext3D. It will be once this patch lands and
Chromium is rolled forward to support this entry point.
This is a large patch, but the transformation is almost entirely
mechanical and there is no change in functionality. Nearly all of
GraphicsContext3D and GraphicsContext3DInternal has been moved to
WebGraphicsContext3DDefaultImpl. The only area where the splitting of
logic is less than mechanical is GraphicsContext3D::beginPaint() and its
callees.
Ran all WebGL layout tests and demos from Khronos site in Chromium.
- WebKit.gyp:
- public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
- public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D):
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
- src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault):
- src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
- src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
- 8:03 PM Changeset in webkit [56293] by
-
- 13 edits in trunk/WebCore
2010-03-19 Eric Uhrhane <ericu@chromium.org>
Reviewed by Dmitry Titov.
Refactor DatabaseTracker.cpp for thread safety
https://bugs.webkit.org/show_bug.cgi?id=34991
This enables calling into DatabaseTracker from multiple context threads,
as will happen once Workers can access the Database. It required a fair
amount of reshuffling of locks. I ended up splitting the public
interface [calls that take locks and call private functions] from the
implementations [calls that assert that locks are already held] in order
to avoid lock conflicts. I also had to make sure we weren't sharing
Strings or SecurityOrigins across threads.
No new tests.
Allow access to database handles from multiple threads IFF SQLite is new enough and the user requests it.
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::disableThreadingChecks):
- platform/sql/SQLiteDatabase.h: (WebCore::SQLiteDatabase::sqlite3Handle): (WebCore::SQLiteDatabase::disableThreadingChecks):
Remove an asynchronous call from Database::close back to the execution thread, so that cleanup can be more deterministic.
- storage/Database.cpp: (WebCore::Database::markAsDeletedAndClose): (WebCore::Database::close):
- storage/Database.h: (WebCore::Database::):
- storage/DatabaseDetails.h: (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::thread):
- storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::doPerformTask):
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):
Any Strings that get stored in DatabaseTracker, and any Strings returned from DatabaseTracker, are now threadsafeCopies.
Public functions now take all needed locks, then generally call only private functions [there are a few exceptions: deletion functions and origins()].
Private functions no longer take locks.
m_quotaMapGuard becomes m_databaseGuard, and now protects m_database, m_quotaMap, m_proposedDatabases, m_databaseDirectoryPath, m_originsBeingDeleted, m_beingCreated, and m_beingDeleted.
m_proposedDatabases replaces m_proposedDatabase, to account for reentrancy.
- storage/DatabaseTracker.h:
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManagerNoLock): (WebCore::DatabaseTracker::originQuotaManager): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::setDatabaseDirectoryPath): (WebCore::DatabaseTracker::databaseDirectoryPath): (WebCore::DatabaseTracker::trackerDatabasePath): (WebCore::DatabaseTracker::openTrackerDatabase): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOriginNoLock): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::hasEntryForDatabase): (WebCore::DatabaseTracker::originPath): (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOriginNoLock): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::setDatabaseDetails): (WebCore::DatabaseTracker::usageForDatabase): (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::usageForOriginNoLock): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOriginNoLock): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile): (WebCore::DatabaseTracker::setClient): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): (WebCore::DatabaseTracker::notifyDatabasesChanged):
These functions keep track of in-progress deletions and creations, so that we can make sure nobody every deletes a database file while a live database is using it.
(WebCore::DatabaseTracker::canCreateDatabase):
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::creatingDatabase):
(WebCore::DatabaseTracker::canDeleteDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::deletingDatabase):
(WebCore::DatabaseTracker::canDeleteOrigin):
(WebCore::DatabaseTracker::deletingOrigin):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::doneDeletingOrigin):
Any SecurityOrigins stored in OriginQuotaManager are now threadsafeCopies of inputs. There's a new tryLock() function in addition to the existing lock().
- storage/OriginQuotaManager.cpp: (WebCore::OriginQuotaManager::tryLock): (WebCore::OriginQuotaManager::trackOrigin):
- storage/OriginQuotaManager.h:
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::databaseIdentifier): Removed DEFINE_STATIC_LOCAL wrapper on a local variable; it appears to have been a small optimization, but it's not thread-safe.
- 7:35 PM Changeset in webkit [56292] by
-
- 6 edits2 adds in trunk/WebCore
2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
Multiselect popups - rendering
https://bugs.webkit.org/show_bug.cgi?id=36006
The objective of this patch is to create a compile time flag that can be used
to force all <select> elements to be rendered as menu lists.
Theme stylesheet mechanism has been used to change the appearance of the elements.
Class QtStyleOptionWebComboBox has been introduced to provide to QStyle objects
the needed information to render <select multiple> comboboxes.
- WebCore.pri:
- WebCore.pro:
- css/themeQtNoListboxes.css: Added. (select[size][multiple]):
- dom/SelectElement.h: (WebCore::SelectElementData::usesMenuList):
- platform/qt/QtStyleOptionWebComboBox.h: Added. (WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox): (WebCore::QtStyleOptionWebComboBox::multiple): (WebCore::QtStyleOptionWebComboBox::checkMultiple):
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton):
- platform/qt/RenderThemeQt.h:
- 6:58 PM Changeset in webkit [56291] by
-
- 25 edits in trunk
2010-03-19 Zhenyao Mo <zmo@google.com>
Reviewed by Oliver Hunt.
Update WebGLArray.slice() to new spec
https://bugs.webkit.org/show_bug.cgi?id-35612
- fast/canvas/webgl/array-unit-tests-expected.txt: Changed tests to reflect the new slice parameters; add new test cases for default inputs for slice.
- fast/canvas/webgl/array-unit-tests.html: Ditto.
- fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt: Changed tests to reflect the new slice parameters.
- fast/canvas/webgl/webgl-array-invalid-ranges.html: Ditto.
2010-03-19 Zhenyao Mo <zmo@google.com>
Reviewed by Oliver Hunt.
Update WebGLArray.slice() to new spec
https://bugs.webkit.org/show_bug.cgi?id-35612
- bindings/js/JSWebGLArrayCustom.cpp: Adding support for default inputs. (WebCore::JSWebGLArray::slice):
- bindings/v8/custom/V8WebGLArrayCustom.cpp: Ditto. (WebCore::V8WebGLArray::sliceCallback):
- html/canvas/WebGLArray.cpp: Map start/end to offset/length. (WebCore::WebGLArray::calculateOffsetAndLength):
- html/canvas/WebGLArray.h: Modified slice parameters.
- html/canvas/WebGLArray.idl: Define custom binding for slice().
- html/canvas/WebGLByteArray.cpp: Modified slice parameters. (WebCore::WebGLByteArray::slice):
- html/canvas/WebGLByteArray.h: Ditto.
- html/canvas/WebGLFloatArray.cpp: Ditto. (WebCore::WebGLFloatArray::slice):
- html/canvas/WebGLFloatArray.h: Ditto.
- html/canvas/WebGLIntArray.cpp: Ditto. (WebCore::WebGLIntArray::slice):
- html/canvas/WebGLIntArray.h: Ditto.
- html/canvas/WebGLShortArray.cpp: Ditto. (WebCore::WebGLShortArray::slice):
- html/canvas/WebGLShortArray.h: Ditto.
- html/canvas/WebGLUnsignedByteArray.cpp: Ditto. (WebCore::WebGLUnsignedByteArray::slice):
- html/canvas/WebGLUnsignedByteArray.h: Ditto.
- html/canvas/WebGLUnsignedIntArray.cpp: Ditto. (WebCore::WebGLUnsignedIntArray::slice):
- html/canvas/WebGLUnsignedIntArray.h: Ditto.
- html/canvas/WebGLUnsignedShortArray.cpp: Ditto. (WebCore::WebGLUnsignedShortArray::slice):
- html/canvas/WebGLUnsignedShortArray.h: Ditto.
- 6:39 PM Changeset in webkit [56290] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-03-19 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Freeze sandbox attributes on creation
https://bugs.webkit.org/show_bug.cgi?id=34184
Test that allow-forms is frozen on document creation.
- fast/frames/resources/sandboxed-iframe-form-dynamic-allowed.html: Added.
- fast/frames/resources/sandboxed-iframe-form-dynamic-disallowed.html: Added.
- fast/frames/sandboxed-iframe-forms-dynamic-expected.txt: Added.
- fast/frames/sandboxed-iframe-forms-dynamic.html: Added.
- 6:20 PM Changeset in webkit [56289] by
-
- 2 edits2 adds in trunk/WebCore
2010-03-19 Yong Li <yong.li@torchmobile.com> and Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Ensure the segments inside SharedBuffer are merged before constructing
a CFData with it.
- manual-tests/WebKitSite.webarchive: Added.
- manual-tests/webarchive-test.html: Added.
- platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::createCFData):
- 5:45 PM Changeset in webkit [56288] by
-
- 4 edits2 adds in trunk
2010-03-19 Justin Schuh <jschuh@chromium.org>
Reviewed by Oliver Hunt.
Security: ReadAV@NULL for negative feMorphology filter radius
https://bugs.webkit.org/show_bug.cgi?id=34566
Prevents building the filter if either radius is negative.
Catches negative radii resulting from conversions.
Test: svg/filters/feMorphology-invalid-radius.svg
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
- 5:41 PM Changeset in webkit [56287] by
-
- 5 edits in trunk/WebKitTools
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Disable the downstream override expectations temporarily to allow
us to test that we've upstreamed everything correctly. Also, stop
looking at the downstream baselines at all (now you will only be
able to update baselines upstream). In theory this should work, but
if we need to we can always add the downstream dirs back in.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- 5:28 PM Changeset in webkit [56286] by
-
- 3 edits2 adds in trunk
Fixed a crash with AnimationController getting deleted out from under itself.
It's possible for the Frame that owns an AnimationController to get deleted
in the EndTransitionEvent (or other animation events) to get deleted in the
event handler. Normally this case is protected against by preventing the Frame
from getting deleted until the end of the runloop. But native uses of the
WebView can subvert this protection. So I added a protector to the
animation event dispatcher to protect it in those cases.
- 5:08 PM Changeset in webkit [56285] by
-
- 4 edits in trunk/WebCore
2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
Multiselect Popup - PopupMenuClient extension
https://bugs.webkit.org/show_bug.cgi?id=36178
PopupMenuClient class is the interface used by combobox popup implementations.
It needs to be extended to handle <select multiple> needs.
A new interface named ListPopupMenuClient that inherits from PopupMenuClient was created.
The use of this new class instead of adding methods to PopupMenuClient avoids changes
in other non related implementations of PopupMenuClient.
RenderMenuList has changed to inherit ListPopupMenuClient instead of PopupMenuClient
and to have the new methods implemented.
- platform/PopupMenuClient.h:
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem): (WebCore::RenderMenuList::multiple):
- rendering/RenderMenuList.h:
- 4:42 PM Changeset in webkit [56284] by
-
- 4 edits2 adds in trunk
2010-03-19 Simon Fraser <Simon Fraser>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=36387
REGRESSION: Can "uncheck" radio buttons by clicking on them
My change in r56174 caused radio buttons and checkboxes to go down the same code path by virtue
of allowsIndeterminate(), but this broke save/restore behavior on radio buttons.
Fix by saving and restoring both the intermediate and checked state for radio buttons
and checkboxes, as well as the "current radio button" state.
Test: fast/forms/radio-checkbox-restore-indeterminate.html
- html/HTMLInputElement.cpp: (WebCore::EventHandlingState::EventHandlingState): New struct to hold state between preDispatchEventHandler() and postDispatchEventHandler(). (WebCore::HTMLInputElement::preDispatchEventHandler): Store intermedate and checked state and the current radio button. (WebCore::HTMLInputElement::postDispatchEventHandler): Restore state as appropriate.
- html/HTMLInputElement.h: Add a comment to clarify how 'intermediate' interacts with 'checked', according to the spec.
- 4:38 PM Changeset in webkit [56283] by
-
- 2 edits in trunk/WebKitTools
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
fix typo in chromium test expectations overrides routine
https://bugs.webkit.org/show_bug.cgi?id=36397
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 4:09 PM Changeset in webkit [56282] by
-
- 2 edits in trunk/LayoutTests
2010-03-19 Darin Fisher <darin@chromium.org>
Temporarily suppress fast/loader/frame-src-change-added-to-history.html
for Tiger to make the bot green.
- platform/mac-tiger/Skipped:
- 4:06 PM Changeset in webkit [56281] by
-
- 1 add in trunk/LayoutTests/platform/chromium/test_expectations.txt
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Unreviewed change.
Add in missing test_expectations.txt file that didn't actually
make it into the commit.
- LayoutTests/platform/chromium/test_expectations.txt
- 4:05 PM Changeset in webkit [56280] by
-
- 3 edits in trunk/WebCore
2010-03-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: caret moves past prompt in javascript console
https://bugs.webkit.org/show_bug.cgi?id=26602
Having noticed any Element children besides a leading <br> (which are empty
text nodes), WebCore editing facility thinks it should delete the <br>,
thus clearing away the text prompt contents.
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.clearAutoComplete): (WebInspector.TextPrompt.prototype._completionsReady):
- inspector/front-end/utilities.js: (Element.prototype.pruneEmptyTextNodes):
- 4:02 PM Changeset in webkit [56279] by
-
- 3 edits in trunk
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Flip the Chromium ports to look first for the test expectations
in LayoutTests/platform/chromium and only afterwards look in the
Chromium repo downstream for overrides.
- WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:
- LayoutTests/platform/chromium/test_expectations.txt
- 3:52 PM Changeset in webkit [56278] by
-
- 1 edit2371 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land remaining chromium-linux LayoutTest baselines
(file list omitted due to length).
- 3:43 PM Changeset in webkit [56277] by
-
- 1 edit1491 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land chromium-linux/fast/{block,css,forms,text} LayoutTest baselines
(file list omitted due to length).
- platform/chromium-linux/fast/block : Added.
- platform/chromium-linux/fast/css : Added.
- platform/chromium-linux/fast/forms : Added.
- platform/chromium-linux/fast/text : Added.
- 3:35 PM Changeset in webkit [56276] by
-
- 1 edit1453 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land chromium-linux/editing LayoutTest baselines
(file list omitted due to length).
- platform/chromium-linux/editing : Added.
- 3:33 PM Changeset in webkit [56275] by
-
- 2 edits in trunk/WebKitTools
2010-03-19 James Hawkins <jhawkins@chromium.org>
Unreviewed.
Add myself to the committers list.
- Scripts/webkitpy/committers.py:
- 3:29 PM Changeset in webkit [56274] by
-
- 1 edit1893 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land chromium-linux/tables LayoutTest baselines
(file list omitted due to length).
- platform/chromium-linux/tables : Added.
- 3:18 PM Changeset in webkit [56273] by
-
- 1 edit1251 adds in trunk/LayoutTests
010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land chromium-linux/svg LayoutTest baselines
(file list omitted due to length).
- platform/chromium-linux/svg : Added.
- 3:09 PM Changeset in webkit [56272] by
-
- 1 edit1244 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land chromium-linux/css* LayoutTest baselines
(file list omitted due to length).
- platform/chromium-linux/css* : Added.
- 3:00 PM Changeset in webkit [56271] by
-
- 1 edit2661 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land remaining chromium-win/* LayoutTest baselines
(file list omitted due to length).
- platform/chromium-win/* : Added.
- 2:50 PM Changeset in webkit [56270] by
-
- 1 edit1811 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land chromium-win/css* LayoutTest baselines
(file list ommitted due to length).
- platform/chromium-win/css* : Added.
- 2:38 PM Changeset in webkit [56269] by
-
- 2 edits in trunk/LayoutTests
[Qt] Back-forward list dumping is incorrect
https://bugs.webkit.org/show_bug.cgi?id=36392
- platform/qt/Skipped: fast/loader/frame-src-change-added-to-history.html skipped until fix.
- 2:34 PM Changeset in webkit [56268] by
-
- 1 edit2436 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land chromium-win/fast/[l-z]* LayoutTest baselines
(file list ommitted due to length).
- platform/chromium-win/fast/[l-z]* : Added.
- 2:24 PM Changeset in webkit [56267] by
-
- 1 edit2380 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land chromium-win/fast/{a,c,d,e,f,g,h,i,j}* LayoutTest baselines
(file list ommitted due to length).
- platform/chromium-win/fast/{a,c,d,e,f,g,h,i,j}* : Added.
- 2:14 PM Changeset in webkit [56266] by
-
- 2 edits in trunk/LayoutTests
2010-03-19 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
r56188 removed lastPosition from the Geolocation code, but the the
geolocation window properties wasn't updated to reflect this. It's
only failing on the GTK+ port, since the other ports have it on
their Skipped list.
- fast/dom/Window/window-properties-geolocation-expected.txt:
- 2:11 PM Changeset in webkit [56265] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386
- platform/qt/Skipped: fast/media/print-restores-previous-mediatype.html skipped until fix.
- 2:04 PM Changeset in webkit [56264] by
-
- 1 edit1216 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land the first part of chromium-win/fast LayoutTest baselines
(file list ommitted due to length).
- platform/chromium-win/fast: Added.
- 2:01 PM Changeset in webkit [56263] by
-
- 3 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Unreviewed.
Fix SheriffBot exception lock when we can't retrieve the first build
from buildbot. (I'll ask Eric to review this change after the fact,
but he's at lunch and I want to get the bot unlocked.)
- Scripts/webkitpy/buildbot.py:
- Scripts/webkitpy/buildbot_unittest.py:
- 1:48 PM QtWebKitJournal edited by
- (diff)
- 1:21 PM Changeset in webkit [56262] by
-
- 6 edits in trunk/WebKitTools
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36380
websocket/tests/frame-lengths.html times out on Tiger bot
https://bugs.webkit.org/show_bug.cgi?id=35041
websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot
Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary -
sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid
timing out than to detect it early.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitUntilDone):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- Scripts/run-webkit-tests:
- 1:20 PM Changeset in webkit [56261] by
-
- 2 edits in trunk/LayoutTests
2010-03-19 Xan Lopez <xlopez@igalia.com>
Unreviewed, land new expected result for test.
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- 1:15 PM Changeset in webkit [56260] by
-
- 4 edits in trunk
2010-03-19 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Buildfix for Qt v4.5.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewOverlay::q):
2010-03-19 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Buildfix for Qt v4.5.
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::applyZoom):
- 1:10 PM Changeset in webkit [56259] by
-
- 1 edit2855 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land the chromium-win/tables LayoutTest baselines (file list
ommitted due to length).
- platform/chromium-win/tables: Added.
- 1:09 PM Changeset in webkit [56258] by
-
- 2 edits in trunk/WebKit/chromium
Unreviewed, build fix.
Rename enqueueStorageEvent to enqueueEvent to match changes in
http://trac.webkit.org/changeset/56249.
- src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::storageEvent): Renamed.
- 1:05 PM Changeset in webkit [56257] by
-
- 4 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Operational tweaks to SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36385
These changes aren't pretty, but they're helpful to make SheriffBot
work operationally. I plan to iterate in these areas, but I wanted to
get this patch landed so I could be running the bot against TOT.
- Scripts/webkitpy/commands/sheriffbot.py:
- Scripts/webkitpy/irc/ircbot.py:
- Scripts/webkitpy/thirdparty/autoinstalled/init.py:
- 1:01 PM Changeset in webkit [56256] by
-
- 3 edits in trunk/WebCore
Windows clean build fix after r56192
- WebCore.vcproj/WebCore.vcproj: Copy headers from
platform/graphics/cg to $WebKitOutputDir as part of the post-build
event so that WebKit can use them. (The only one we currently require
is FontPlatformData.h.)
- platform/graphics/win/FontPlatformDataCGWin.cpp: Touched to force a
build.
- 12:56 PM Changeset in webkit [56255] by
-
- 2149 adds in trunk/LayoutTests/platform/chromium-win
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land the chromium-win/svg LayoutTest baselines (file list
ommitted due to length).
- platform/chromium-win/svg: Added.
- 12:54 PM Changeset in webkit [56254] by
-
- 1 edit1 move in trunk/LayoutTests
Rubberstamped by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=35594
- fast/loader/api-test-new-window-data-load-base-url.html: Removed.
- fast/loader/api-test-new-window-data-load-base-url.html-disabled: Copied from fast/loader/api-test-new-window-data-load-base-url.html.
- 12:41 PM Changeset in webkit [56253] by
-
- 1 edit103 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land the chromium-win-vista LayoutTest baselines (file list
ommitted due to length).
- platform/chromium-win-vista: Added.
- 12:40 PM Changeset in webkit [56252] by
-
- 1 edit141 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land the chromium-win-xp LayoutTest baselines (file list ommitted due to
length).
- platform/chromium-win-xp: Added.
- 12:38 PM Changeset in webkit [56251] by
-
- 1 edit831 adds in trunk/LayoutTests
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Land the chromium-mac LayoutTest baselines (file list ommitted due to
length).
- platform/chromium-mac: Added.
- 11:37 AM Changeset in webkit [56250] by
-
- 2 edits in trunk/WebCore
2010-03-19 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Assertion failure in media/video-controls-with-mutation-event-handler.html
https://bugs.webkit.org/show_bug.cgi?id=36376
Fix crashing test. Underlying the media element's volume slider is a
range input, which sanitizes values before expected on the media control.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):
- 11:25 AM Changeset in webkit [56249] by
-
- 6 edits in trunk/WebCore
3 of the new HTML5 loading events need to be asynchronous.
Reviewed by Darin Adler.
Laying the groundwork for:
https://bugs.webkit.org/show_bug.cgi?id=36201
https://bugs.webkit.org/show_bug.cgi?id=36202
https://bugs.webkit.org/show_bug.cgi?id=36334
https://bugs.webkit.org/show_bug.cgi?id=36335
Document already had an asynchronous event delivery mechanism for storage events, so
we can repurpose that for all async events.
No new tests. (No change in behavior)
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::implicitClose): Use Document::schedule* for the related events.
(WebCore::Document::enqueueEvent): Renamed from enqueueStorageEvent
(WebCore::Document::pendingEventTimerFired): Renamed from "storageEventTimerFired"
(WebCore::Document::statePopped): Use Document::schedulePopstateEvent
(WebCore::Document::enqueuePageshowEvent): All Pageshow events are piped through here.
This will be made asynchronous in a separate patch.
(WebCore::Document::enqueueHashchangeEvent): All Hashchange events are piped through here.
This will be made asynchronous in a separate patch.
(WebCore::Document::enqueuePopstateEvent): All Popstate events are piped through here.
This will be made asynchronous in a separate patch.
- dom/Document.h:
(WebCore::):
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): Use Document::enqueuePageshowEvent
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument): Use Document::enqueueHashchangeEvent
- storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatch): Use Document::enqueueEvent
- 11:23 AM Changeset in webkit [56248] by
-
- 4 edits in trunk/WebKitTools
2010-03-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Help sheriff-bot avoid warning about flaky tests (and add more unit testing)
https://bugs.webkit.org/show_bug.cgi?id=36354
- Scripts/webkitpy/buildbot.py:
- Make Build creation easier to Mock and test
- Scripts/webkitpy/buildbot_unittest.py:
- Test finding green to red transitions and suspect revisions
- Scripts/webkitpy/commands/queries.py:
- Make what-broke note when builders have only failed once.
- 11:19 AM Changeset in webkit [56247] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36337
Log an error when an OOP plug-in sends an unknown object id
Making these LOG_ERROR and not ASSERTs, because I don't want early returns to look
temporary or redundant.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::removeProperty): (WebKit::NetscapePluginInstanceProxy::hasProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::enumerate):
- 11:16 AM Changeset in webkit [56246] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler and Brady Eidson.
First step toward:
https://bugs.webkit.org/show_bug.cgi?id=36328
This is the first step torward eliminating the WebKit WebNullPluginView class. The responsibility for this will soon
be in platform-independent code in WebCore. The plan is to change RenderEmbeddedObject and give it the capability of
drawing the missing plug-in text.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Renamed the renderer parameter to requestEmbeddedObject and made it a RenderEmbeddedObject. (WebCore::FrameLoader::loadPlugin): Likewise.
- loader/FrameLoader.h: Updated loadPlugin() and requestObject() method signatures accordingly.
- 11:01 AM Changeset in webkit [56245] by
-
- 2 edits in trunk/WebKitTools
2010-03-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Fix the rebaselining tool, which was broken by r36324 when I
added the concept of overridding expectations.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- 10:30 AM Changeset in webkit [56244] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-19 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] querying the current history item during a back/forward
navigation should not clobber the scroll offset, etc.
https://bugs.webkit.org/show_bug.cgi?id=36347
We should only allow the current history item to be modified if we are
no longer loading or if the load is a new navigation (i.e., not a
back/forward/reload variant).
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::currentHistoryItem):
- 9:41 AM Changeset in webkit [56243] by
-
- 2 edits in trunk/WebCore
2010-03-19 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Disable TILED_BACKING_STORE if Qt version is earlier than Qt4.6
https://bugs.webkit.org/show_bug.cgi?id=36348
Backing store implementation for QtWebKit requires at least Qt
version 4.6.
No new tests as there is no new functionality.
- WebCore.pri:
- 9:16 AM Changeset in webkit [56242] by
-
- 16 edits2 adds in trunk
2010-03-19 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259
Setting value attribute on an <input type=range> to an out-of-range value fires oninput
https://bugs.webkit.org/show_bug.cgi?id=16990
Part 2 of 2: When setting the range element's value, overflows and underflows
are automatically sanitized to valid values. Moved the general case
sanitization code out of the Renderer into HTMLInputElement::sanitizeValue.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::value): when getting a default value on reset() ensure the defaultValue is provided (WebCore::HTMLInputElement::sanitizeValue): clamp the value within the max/min/step range constraints
- html/StepRange.cpp: (WebCore::StepRange::StepRange): allow const element in the constructor (WebCore::StepRange::clampValue): clamp from a String value
- html/StepRange.h: (WebCore::StepRange::defaultValue): easy calculation of the default value for max/min/step range constraints
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): no longer handle the general case sanitization in the renderer
2010-03-19 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259
Setting value attribute on an <input type=range> to an out-of-range value fires oninput
https://bugs.webkit.org/show_bug.cgi?id=16990
When setting the range element's value, overflows and underflows are
automatically sanitized to valid values. Fixed the behavior and removed
tests that were testing for improper behavior.
- fast/forms/ValidityState-rangeOverflow-expected.txt:
- fast/forms/ValidityState-rangeUnderflow-expected.txt:
- fast/forms/input-stepup-stepdown-expected.txt:
- fast/forms/script-tests/ValidityState-rangeOverflow.js:
- fast/forms/script-tests/ValidityState-rangeUnderflow.js:
- fast/forms/script-tests/input-stepup-stepdown.js:
- fast/forms/script-tests/validationMessage.js:
- fast/forms/validationMessage-expected.txt:
Added test verifying that bug 16990 was fixed as well.
- fast/forms/range-input-dynamic-oninput-expected.txt: Added.
- fast/forms/range-input-dynamic-oninput.html Added.
Improved test because handling of this case changed.
- fast/forms/range-reset-expected.txt:
- fast/forms/range-reset.html:
- 9:16 AM Changeset in webkit [56241] by
-
- 7 edits2 adds in trunk/WebCore
2010-03-19 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259
Part 1 of 2: Refactoring the SliderRange struct out of RenderSlider
into a more appropriate place. Changed the named to StepRange. Changed
from a struct to a class.
Added new files to the build.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Renamed and moved class SliderRange to StepRange.
- html/StepRange.cpp: Added. (WebCore::StepRange::StepRange): (WebCore::StepRange::clampValue): (WebCore::StepRange::valueFromElement): (WebCore::sliderPosition):
- html/StepRange.h: Added. (WebCore::StepRange::proportionFromValue): (WebCore::StepRange::valueFromProportion):
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): updated to use StepRange (WebCore::RenderSlider::setValueForPosition): updated to use StepRange
- 8:34 AM QtWebKitJournal edited by
- (diff)
- 8:33 AM Changeset in webkit [56240] by
-
- 2 edits in trunk/LayoutTests
2010-03-19 Darin Fisher <darin@chromium.org>
Fix expected results for fast/loader/frame-src-change-added-to-history.html
- fast/loader/frame-src-change-added-to-history-expected.txt:
- 8:27 AM Changeset in webkit [56239] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=36366
Repaint loop when painting using scaled CTMs with different translations
Patch by Antti Koivisto <koivisto@iki.fi> on 2010-03-19
Reviewed by Simon Hausmann.
The code in RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality
tests if the scaling has changed from the previous value by comparing the
transformations. The test fails if the scale is the same but the translation
changes. This can lead to infinite repaint loop if the document is painted
in pieces using different translations (for example for tiling).
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
- 8:06 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:03 AM Changeset in webkit [56238] by
-
- 1 edit5 adds in trunk/LayoutTests
2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Need a layout test for finding yensign from documents with Japanese encodings
https://bugs.webkit.org/show_bug.cgi?id=36288
- editing/selection/find-yensign-and-backslash-expected.txt: Added.
- editing/selection/find-yensign-and-backslash.html: Added.
- platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Added.
- platform/qt/editing/selection/find-yensign-and-backslash-expected.txt: Added.
- platform/win/editing/selection/find-yensign-and-backslash-expected.txt: Added.
- 7:10 AM QtWebKitJournal edited by
- (diff)
- 6:35 AM Changeset in webkit [56237] by
-
- 5 edits in trunk/WebCore
2010-03-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: editing shorthands does not always work.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::shorthandValue):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/inspector.css: (.section .properties li.disabled .enabled-button):
- inspector/front-end/inspector.js: (WebInspector.startEditing.editingCommitted):
- 6:10 AM Changeset in webkit [56236] by
-
- 2 edits in trunk/WebCore
[Qt] Don't replace clip when drawing complex text
Reviewed by Simon Hausmann.
- platform/graphics/qt/FontQt.cpp:
- 3:05 AM Changeset in webkit [56235] by
-
- 4 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Misc bug fixes to make the SheriffBot actually work
https://bugs.webkit.org/show_bug.cgi?id=36355
With these changes, I can actually run the sheriff-bot from start to
finish.
- Scripts/webkitpy/irc/ircproxy.py:
- Scripts/webkitpy/patch/patcher.py:
- Scripts/webkitpy/statusserver.py:
- 2:51 AM Changeset in webkit [56234] by
-
- 3 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Unreviewed.
Actually import the sheriff-bot command so we can run it. Also, move
the bot to #webkit-test so it doesn't cause a ruckus while we test it.
- Scripts/webkitpy/patch/patcher.py:
- Scripts/webkitpy/irc/ircbot.py:
- 2:44 AM Changeset in webkit [56233] by
-
- 5 edits1 copy in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Second cut at SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36353
This patch should contain a complete SheriffBot that's capable of
saying reasonable things on IRC. I had to refactor the use of
CommitInfo to make the SheriffBot testable, but I did the minimum
necessary. We should grow webkitcheckout over time to contain the
knowledge of ChangeLogs from scm.
- Scripts/webkitpy/commands/sheriffbot.py:
- Scripts/webkitpy/commands/sheriffbot_unittest.py:
- Scripts/webkitpy/mock_bugzillatool.py:
- Scripts/webkitpy/patch/patcher.py:
- Scripts/webkitpy/webkitcheckout.py: Added.
- 1:44 AM Changeset in webkit [56232] by
-
- 2 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Unreviewed.
Fix Hyatt's IRC nickname.
- Scripts/webkitpy/committers.py:
- 1:42 AM Changeset in webkit [56231] by
-
- 3 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Unreviewed.
Add IRC nicknames for the non-reviewer committers.
- Scripts/webkitpy/committers.py:
- 1:10 AM Changeset in webkit [56230] by
-
- 2 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Unreviewed.
Add IRC nicknames for the non-reviewer committers.
- Scripts/webkitpy/committers.py:
- 12:59 AM Changeset in webkit [56229] by
-
- 2 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Unreviewed.
More reviewer IRC nicknames.
- Scripts/webkitpy/committers.py:
- 12:53 AM Changeset in webkit [56228] by
-
- 2 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Unreviewed.
Add a bunch of IRC nicknames for reviewers.
- Scripts/webkitpy/committers.py:
- 12:47 AM Changeset in webkit [56227] by
-
- 2 edits in trunk/WebKitTools
2010-03-19 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Oliver Hunt.
Added USE_SYSTEM_MALLOC flag to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=21272
Add system-alloc flag to build-webkit. It makes easy to switch
between system allocator and TCmalloc.
- Scripts/build-webkit:
- 12:44 AM Changeset in webkit [56226] by
-
- 2 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix.
Of course, I caused a regression in the file that isn't tested. :(
- Scripts/webkitpy/statusserver.py:
- 12:37 AM Changeset in webkit [56225] by
-
- 3 edits in trunk/WebKitTools
2010-03-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Simplify BuildBot core builder code for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=36350
I simply couldn't see anything through all this Yak-hair.
- Scripts/webkitpy/buildbot.py:
- Scripts/webkitpy/commands/queries.py:
- 12:33 AM Changeset in webkit [56224] by
-
- 3 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
committers.py should know IRC nicknames
https://bugs.webkit.org/show_bug.cgi?id=36349
I'll add the actual nicknames in another patch.
- Scripts/webkitpy/committers.py:
- Scripts/webkitpy/committers_unittest.py:
- 12:31 AM Changeset in webkit [56223] by
-
- 6 edits2 adds in trunk
2010-03-18 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
If a frame is already in the document, then setting its "src" attribute
should add the resultant navigation to history.
This behavior is specified in section 4.8.2 of the HTML5 spec.
Test: fast/loader/frame-src-change-added-to-history.html
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::setLocation):
- html/HTMLFrameElementBase.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame):
- loader/FrameLoader.h:
- 12:20 AM Changeset in webkit [56222] by
-
- 2 edits in trunk/WebKitTools
https://bugs.webkit.org/show_bug.cgi?id=36318
Patch by Anders Bakken <Anders Bakken <agbakken@gmail.com>> on 2010-03-18
Reviewed by Simon Hausmann.
QtLauncher runs as a GuiClient by default in Qt Embedded which will
make it try to connect to an existing GuiServer. This patch makes it
run like a stand-alone app.
- QtLauncher/main.cpp:
(LauncherApplication::LauncherApplication):
- 12:18 AM Changeset in webkit [56221] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Platform specific expected file updated after r56195
- platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
- 12:15 AM Changeset in webkit [56220] by
-
- 3 edits in trunk/WebKitTools
2010-03-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=36345
- Scripts/webkitpy/buildbot.py:
- Scripts/webkitpy/commands/queries.py:
- 12:04 AM Changeset in webkit [56219] by
-
- 2 edits in trunk/WebKitTools
2010-03-19 Adam Barth <abarth@webkit.org>
Reviewed by Adam Barth.
Actually pass the IRC password to the IRC object
https://bugs.webkit.org/show_bug.cgi?id=36346
I wanted to do this before, but both patches were in flight. This
patch finally closes the loop and makes the IRCProxy system complete.
- Scripts/webkitpy/patch/patcher.py:
Mar 18, 2010:
- 11:58 PM Changeset in webkit [56218] by
-
- 2 edits in trunk/WebKitTools
2010-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a StatusServer front end to the SVNRevision table on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=36344
No test because Browser was too hard to mock. :( I couldn't figure
out how to make Mock be a dictionary as well as an object.
- Scripts/webkitpy/statusserver.py:
- 11:46 PM Changeset in webkit [56217] by
-
- 4 edits in trunk/WebKit/gtk
2010-03-18 Philip Chimento <philip.chimento@gmail.com>
Reviewed by Oliver Hunt.
Setting the GObject WebKitWebView property 'window-features' to NULL
causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=36144
- tests/testwebview.c: Add unit test for this bug.
- webkit/webkitwebview.cpp: Don't allow the 'window-features' property to be set to NULL.
- webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_equal): Don't examine the members of either web_window_features argument if either is NULL, just return that they are not equal. Additionally, if they are the same object, return that they are equal.
- 11:46 PM Changeset in webkit [56216] by
-
- 3 edits2 adds in trunk/WebKitTools
2010-03-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split out CommitInfo class and add unit tests
https://bugs.webkit.org/show_bug.cgi?id=36343
Move more logic out of "what-broke" into a shared CommitInfo
class so that it can be used by other commands and unit tested.
- Scripts/webkitpy/commands/queries.py:
- Scripts/webkitpy/commitinfo.py: Added.
- Scripts/webkitpy/commitinfo_unittest.py: Added.
- Scripts/webkitpy/unittests.py:
- 11:29 PM Changeset in webkit [56215] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-18 Tom Callaway <tcallawa@redhat.com>
Reviewed by Darin Adler.
Bug 35429: Fix compile on SPARC64
https://bugs.webkit.org/show_bug.cgi?id=35429
- wtf/Platform.h: Set WTF_USE_JSVALUE64 for SPARC64
- 11:24 PM Changeset in webkit [56214] by
-
- 3 edits2 adds in trunk
WebCore: Fix a minor crash with mismatched array sizes in SVG animation
elements.
Patch by Chris Evans <cevans@chromium.org> on 2010-03-18
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=35606
Test: svg/animations/keypoints-mismatch.svg
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
Globally apply validations relevant to all animation types.
LayoutTests: Add test for minor SVG animation crashers.
See https://bugs.webkit.org/show_bug.cgi?id=35606
Patch by Chris Evans <cevans@chromium.org> on 2010-03-18
Reviewed by Nikolas Zimmermann.
- svg/animations/keypoints-mismatch.svg: Added.
- svg/animations/keypoints-mismatch-expected.txt: Added.
- 11:03 PM Changeset in webkit [56213] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-03-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
add new results for failing win/linux test after http://trac.webkit.org/changeset/56175
https://bugs.webkit.org/show_bug.cgi?id=36329
Missed this test in r56175 since it does a drag on win/linux, but not a mac.
The new results correctly do the smart-drag behavior of doing a smart-delete
on drag regardless of whether the selection granularity is word granularity.
- platform/win/editing/selection/drag-text-delay-expected.checksum: Added.
- platform/win/editing/selection/drag-text-delay-expected.png: Added.
- platform/win/editing/selection/drag-text-delay-expected.txt:
- 10:46 PM Changeset in webkit [56212] by
-
- 10 edits6 adds in trunk
2010-03-18 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Adam Barth.
Implement software composited graphics layers in Chromium using the Skia library.
https://bugs.webkit.org/show_bug.cgi?id=35557
This is an initial step in the implementation. Layer compositing is functioning
but not optimized in any way. Subsesquent check-ins will be necessary to fine tune
it.
Test: No new exposed functionality so no new tests.
- WebCore.gypi: Added new source files to the chromium build
- platform/graphics/GraphicsLayer.h: Added necessary typedef's and forward declarations for Chromium.
- platform/graphics/skia/GraphicsLayerSkia.cpp: Added.
- platform/graphics/skia/GraphicsLayerSkia.h: Added. Declaration and implementation of the platform-specific GraphicsLayer class.
- platform/graphics/skia/LayerRendererSkia.cpp: Added.
- platform/graphics/skia/LayerRendererSkia.h: Added. Declaration and implementation of the Skia-based software compositor.
- platform/graphics/skia/LayerSkia.cpp: Added.
- platform/graphics/skia/LayerSkia.h: Added. Declaration and implementation of a compositable layer that uses a Skia canvas for backing store.
2010-03-18 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Adam Barth.
Adding support for the ACCELERATED_COMPOSITING render path to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=35557
Currently compositing of layers is performed via s/w compositor which relies on Skia. This is an initial check-in
and it's only been tested on Windows. Compiling the code requires seting "use_accelerated_compositing=1"
to GYP_DEFINES. The update of layer contents and compositing is fairly inefficient but this will be fixed in
subsequent check-ins.
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::attachRootGraphicsLayer): (WebKit::ChromeClientImpl::scheduleCompositingLayerSync):
- src/ChromeClientImpl.h: (WebKit::ChromeClientImpl::setNeedsOneShotDrawingSynchronization): Added methods required by the RenderLayerCompositor
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::paintWithContext): (WebKit::WebFrameImpl::paint):
- src/WebFrameImpl.h: Split WebFrameImpl::paint() into two methods to make it possible to call the paint routine with an existing GraphicsContext, which is necessary for painting the root layer into its own backing surface.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::paint): Modified method to handle the accelerated compositing path. Now, when doing accelerated compositing, paint() results in repainting the contents of the root layer and then doing a composite operation. (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setAcceleratedCompositing): (WebKit::WebViewImpl::updateRootLayerContents): (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
- src/WebViewImpl.h: (WebKit::WebViewImpl::isAcceleratedCompositing):
- 10:32 PM Changeset in webkit [56211] by
-
- 5 edits in trunk
2010-03-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix LayoutTests/http/tests/appcache/max-size.html
https://bugs.webkit.org/show_bug.cgi?id=36207
- platform/qt/Skipped:
2010-03-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix LayoutTests/http/tests/appcache/max-size.html
https://bugs.webkit.org/show_bug.cgi?id=36207
Implement setAppCacheMaximumSize() for Qt.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setAppCacheMaximumSize):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 10:13 PM Changeset in webkit [56210] by
-
- 6 edits4 copies1 add in trunk/WebKitTools
2010-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
QueueStatusServer should be able to log broken bots
https://bugs.webkit.org/show_bug.cgi?id=36341
We need to add a new table to the QueueStatusServer to store persistent
information for the SheriffBot. The new table will keep track of which
bots each SVN revision broke.
- QueueStatusServer/handlers/init.py:
- QueueStatusServer/handlers/svnrevision.py: Added.
- QueueStatusServer/handlers/updatebase.py: Added.
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/handlers/updatesvnrevision.py: Added.
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- QueueStatusServer/model/init.py:
- QueueStatusServer/model/svnrevision.py: Added.
- QueueStatusServer/templates/updatesvnrevision.html: Added.
- 10:11 PM Changeset in webkit [56209] by
-
- 15 edits2 adds in trunk
2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Darin Adler.
Add a new test for testing whether the media type is restores
properly after printing a page (changing media type to 'print').
Add expected result and skip the test for platform that do not
implement setMediaType().
- fast/media/print-restores-previous-mediatype-expected.txt: Added.
- fast/media/print-restores-previous-mediatype.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Darin Adler.
Make setPrinting() with printing=false, restore the previous
media type in use.
Test: fast/media/print-restores-previous-mediatype.html
- page/Frame.cpp: (WebCore::Frame::setPrinting):
- page/FrameView.cpp: (WebCore::FrameView::adjustMediaTypeForPrinting):
- page/FrameView.h:
2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Darin Adler.
Make it possible for the Qt DRT to set the media type from
the LayoutTestController.
- Api/qwebframe.cpp: (qt_drt_setMediaType):
2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Darin Adler.
Add a new method to the Qt LayoutTestController for
changing media type and make the DRT support dry-run printing.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::dryRunPrint):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMediaType):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 9:51 PM Changeset in webkit [56208] by
-
- 5 edits in trunk/WebKit/qt
2010-03-18 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] New API scrollRecursively has several problems.
https://bugs.webkit.org/show_bug.cgi?id=35873
Remove scrollRecursively from the Qt 4.7 API
Update the internal API to accept a hit test position
for nested scrolling
- Api/qwebframe.cpp: (webframe_scrollOverflow): (qtwebkit_webframe_scrollRecursively):
- Api/qwebframe.h:
- Api/qwebframe_p.h:
- tests/qwebframe/tst_qwebframe.cpp:
- 8:58 PM Changeset in webkit [56207] by
-
- 5 edits in trunk/LayoutTests
Update test results after r56182. "background-color: rgba(0, 0, 0, 0)" is now reported as "background-color: transparent".
Rubber-stamped by Samuel Weinig.
- fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- 6:33 PM Changeset in webkit [56206] by
-
- 2 edits in trunk/WebCore
<http://webkit.org/b/36338> Remove unused RenderReplaced::adjustOverflowForBoxShadowAndReflect() declaration
Rubber-stamped by Darin Adler.
This declaration should have been removed in r47440.
- rendering/RenderReplaced.h:
(WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Removed.
- 6:05 PM Changeset in webkit [56205] by
-
- 4 edits2 adds in trunk
Dragging a PDF image triggers assertion in DragController::startDrag()
https://bugs.webkit.org/show_bug.cgi?id=36247
Reviewed by Dmitry Titov.
WebCore:
Test: fast/images/drag-pdf-as-image.html
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::filenameExtension):
- platform/graphics/cg/PDFDocumentImage.h:
LayoutTests:
- fast/images/drag-pdf-as-image-expected.txt: Added.
- fast/images/drag-pdf-as-image.html: Added.
- 5:21 PM Changeset in webkit [56204] by
-
- 2 edits in trunk/WebCore
2010-03-18 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Avoid taking a reference to a String owned by a temporary AtomicString.
- css/CSSSelector.cpp: (WebCore::CSSSelector::RareData::parseNth):
- 5:17 PM Changeset in webkit [56203] by
-
- 2 edits in trunk/LayoutTests/fast
Land new expected results.
- 4:23 PM Changeset in webkit [56202] by
-
- 1 edit1 add in trunk/LayoutTests
Add missing file from r56186.
- fast/dynamic/float-remove-above-line-2-expected.txt: Added.
- 4:03 PM Changeset in webkit [56201] by
-
- 6 edits in trunk/WebKit/chromium
Chromium interface change to support Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=35318
Reviewed by Darin Fisher.
- features.gypi:
- public/WebHTTPBody.h:
- public/WebKitClient.h:
(WebKit::WebKitClient::getFileModificationTime):
- src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::getFileModificationTime):
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFile):
(WebKit::WebHTTPBody::appendFileRange):
- 4:00 PM Changeset in webkit [56200] by
-
- 4 edits in trunk/WebCore
Fixed parenting issues with HW layers on Windows
https://bugs.webkit.org/show_bug.cgi?id=32449
- 3:45 PM Changeset in webkit [56199] by
-
- 4 edits in trunk/WebKitTools
2010-03-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Add upstream LayoutTests/platform/chromium* directories to the
baseline search path for new-run-webkit-tests in preparation for
upstreaming all of the Chromium baselines. Note that this does
not actually create the directories themselves, but that's okay.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- 3:42 PM Changeset in webkit [56198] by
-
- 3 edits2 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=36327
Test that a plug-in can override Node methods of its element
- plugins/override-node-method-expected.txt: Added.
- plugins/override-node-method.html: Added.
- 3:42 PM Changeset in webkit [56197] by
-
- 2 edits in trunk/WebCore
Unreviewed, build fix.
[Chromium] Change the order of mac/ and cg/ include dirs to fix compile break
due to http://trac.webkit.org/changeset/56192,
- WebCore.gyp/WebCore.gyp: Changed the order.
- 2:51 PM Changeset in webkit [56196] by
-
- 2 edits in trunk/WebCore
2010-03-18 Simon Fraser <Simon Fraser>
No review.
Fix brace style after r56170.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- 2:39 PM Changeset in webkit [56195] by
-
- 5 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36325
Reviewed by Oliver Hunt.
Add support for stopImmediatePropagation from DOM Level 3 Events.
Added fast/events/stop-immediate-propagation.html.
- dom/Event.cpp:
(WebCore::Event::Event):
- dom/Event.h:
(WebCore::Event::timeStamp):
(WebCore::Event::stopPropagation):
(WebCore::Event::stopImmediatePropagation):
(WebCore::Event::propagationStopped):
(WebCore::Event::immediatePropagationStopped):
- dom/Event.idl:
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
- 2:26 PM Changeset in webkit [56194] by
-
- 2 edits in trunk/WebCore
Unreviewed, build fix.
Return frame accessor back to Geolocation, it's used in GeolocationServiceChromium.
The accessor was removed in http://trac.webkit.org/changeset/56188.
- page/Geolocation.h:
(WebCore::Geolocation::frame): Added back.
- 2:21 PM Changeset in webkit [56193] by
-
- 4 edits1 add in trunk/WebKitTools
2010-03-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Add the concept of an "overrides" file for expectations so that we
can store test_expectations both upstream and downstream for a port
that runs both in webkit.org and in a separate repository (like
Chromium). Also add some unit tests for the expectations module.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: Added.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 2:20 PM Changeset in webkit [56192] by
-
- 5 edits1 move1 add in trunk/WebCore
Help reduce build problems due to font declarations.
https://bugs.webkit.org/show_bug.cgi?id=36190
Reviewed by Adam Roben.
Functions unchanged, no new tests.
- WebCore.vcproj/WebCore.vcproj: Add new file, and show movement of FontPlatformData.h to cg/ directory.
- platform/graphics/cairo/FontPlatformData.h: Merge in WinCairo-specific declarations. Correct constructor declaration to use type float for font size.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::useGDI):
(WebCore::FontPlatformData::fontFace):
(WebCore::FontPlatformData::setSize):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):
- platform/graphics/cairo/FontPlatformDataCairo.cpp:
(WebCore::FontPlatformData::FontPlatformData): Correct
constructor to accept type float for font size.
- platform/graphics/cg/FontPlatformData.h: Copied from WebCore/platform/graphics/win/FontPlatformData.h.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::cgFont):
(WebCore::FontPlatformData::operator==):
- platform/graphics/win/FontPlatformData.h: Removed.
- platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::operator==): Move implementation
here (previously in header) to match other cairo-based ports.
- platform/graphics/win/RefCountedHFONT.h: Added. This was extracted from win/FontPlatformData.h, and is now shared by the cg/FontPlatformData.h and cairo/FontPlatformData.h
(WebCore::RefCountedHFONT::create):
(WebCore::RefCountedHFONT::createDeleted):
(WebCore::RefCountedHFONT::~RefCountedHFONT):
(WebCore::RefCountedHFONT::hfont):
(WebCore::RefCountedHFONT::hash):
(WebCore::RefCountedHFONT::RefCountedHFONT):
- 2:14 PM Changeset in webkit [56191] by
-
- 3 edits2 adds in trunk
2010-03-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=36274
CSS3 :nth-child selector 'odd' keyword case sensitivity test fails
The tests for "odd", "even" etc. for nth-child selectors should be case insensitive.
Test: fast/css/nth-child-odd-case-insensitive.html
- css/CSSSelector.cpp: (WebCore::CSSSelector::RareData::parseNth):
- 2:10 PM Changeset in webkit [56190] by
-
- 2 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36265
Reviewed by Oliver Hunt.
Add support for event.defaultPrevented from DOM level 3.
Added fast/events/defaultprevented.html
- dom/Event.idl:
- 1:51 PM Changeset in webkit [56189] by
-
- 7 edits in trunk/JavaScriptCore
2010-03-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Add API to directly expose JSON parsing
https://bugs.webkit.org/show_bug.cgi?id=34887
Add API to expose JSON parsing directly, and add tests to testapi
- API/JSValueRef.cpp: (JSValueMakeFromJSONString): (JSValueCreateJSONString):
- API/tests/testapi.c: (main):
- JavaScriptCore.exp:
- runtime/JSONObject.cpp: (JSC::JSONStringify):
- runtime/JSONObject.h:
- 1:42 PM Changeset in webkit [56188] by
-
- 5 edits in trunk/WebCore
Remove Geolocation.lastPosition, no longer in the spec.
https://bugs.webkit.org/show_bug.cgi?id=36255
rdar://problem/7746357
Reviewed by Kenneth Rohde Christiansen.
- WebCore.base.exp: Updated since Geolocation's destructor is now non-virtual.
- page/Geolocation.cpp:
(WebCore::Geolocation::lastPosition): Add an assertion; it's only legal to
call this if access to the location is allowed.
- page/Geolocation.h: Removed unneeded includes. Made destructor non-virtual,
although it will still be virtual if any of the base classes have a virtual
destructor. Made lastPosition, isAllowed, and isDenied functions private.
Removed unused suspend, resume, setShouldClearCache, shouldClearCache,
and frame functions.
- page/Geolocation.idl: Removed lastPosition read-only attribute. No longer in
the Geolocation specification.
- 1:37 PM Changeset in webkit [56187] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36275
Reviewed by Simon Fraser.
Make sure :not does not allow pseudo-elements inside it. (Hooray for another pointless
restriction on :not.)
Added fast/css/invalid-not-with-pseudo-element.html
- css/CSSGrammar.y:
- css/CSSSelector.h:
(WebCore::CSSSelector::matchesPseudoElement):
- 1:33 PM Changeset in webkit [56186] by
-
- 6 edits1 copy in trunk
WebCore: <rdar://problem/7761400> Rework the fix for
https://bugs.webkit.org/show_bug.cgi?id=18722
Reviewed by Darin Adler.
Test: fast/dynamic/float-remove-above-line-2.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject): Treat 0- and less-than-0-height floats
as having a height of 1 so that they intersect with the line they originate on.
(WebCore::RenderBlock::clearFloats): Use numeric_limits.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Removed the intersection checks here,
so that a float is always included in the float list of the line it originates on, even
if it does not intersect that line. This ensures that every float is accounted for, which
is necessary during incremental layout when adding floats from clean lines.
LayoutTests: Additional test for <rdar://problem/7761400>
Reviewed by Darin Adler.
- fast/dynamic/float-remove-above-line-2.html: Copied from LayoutTests/fast/dynamic/float-remove-above-line.html.
- fast/dynamic/float-remove-above-line-expected.txt: Updated.
- fast/dynamic/float-remove-above-line.html: Fixed inconsequential typo in end tag.
- 1:29 PM Changeset in webkit [56185] by
-
- 1 add in trunk/LayoutTests/fast/css/invalid-import-rule-insertion-expected.txt
Add expected results.
- 1:19 PM Changeset in webkit [56184] by
-
- 6 edits in trunk
2010-03-18 Antti Koivisto <koivisto@iki.fi>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=36102
[Qt] Scaling control API for tiled backing store
Commit the new scale synchronously after unfreeze to avoid ugliness.
- platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::TiledBackingStore): (WebCore::TiledBackingStore::setContentsScale): (WebCore::TiledBackingStore::commitScaleChange): (WebCore::TiledBackingStore::setContentsFrozen):
- platform/graphics/TiledBackingStore.h:
2010-03-18 Antti Koivisto <koivisto@iki.fi>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=36102
[Qt] Scaling control API for tiled backing store
The scale is set by passing the QGraphicsWebView scale to the backing store. The
only new API is the tiledBackingStoreFrozen property which allows disabling
all updates (for example during zoom animation).
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_scaleChanged): (QGraphicsWebViewPrivate::updateTiledBackingStoreScale): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::isTiledBackingStoreFrozen): (QGraphicsWebView::setTiledBackingStoreFrozen):
- Api/qgraphicswebview.h:
- Api/qwebframe.cpp:
- Api/qwebframe_p.h:
- 1:18 PM QtWebKitRelease20 edited by
- (diff)
- 1:07 PM Changeset in webkit [56183] by
-
- 3 edits in trunk/WebKitTools
2010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Add an overlay QGraphicsTextItem to QtLauncher so we can display FPS info
on the launcher and not on the terminal anymore.
[Qt] QtLauncher's FPS info should be displayed on an overlay text item
https://bugs.webkit.org/show_bug.cgi?id=36244
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::setFrameRateMeasurementEnabled): (WebViewGraphicsBased::updateFrameRate):
- QtLauncher/webview.h:
- 12:50 PM Changeset in webkit [56182] by
-
- 8 edits1 add in trunk
https://bugs.webkit.org/show_bug.cgi?id=36281
Reviewed by Simon Fraser.
Make sure an exception is raised if an @import rule is inserted in the wrong place.
Also make sure (so that this particular test case passes) that rgba(0, 0, 0, 0) is dumped
as transparent by getComputedStyle, since it most commonly occurs in background-color and
that default makes more sense than dumping rgba values.
Added fast/css/invalid-import-insertion.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::createColor):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::insertRule):
- 12:49 PM Changeset in webkit [56181] by
-
- 8 edits2 adds in trunk/WebKitTools
2010-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
First cut at SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36253
This patch contains a first attempt at writing a sheriff bot.
Currently, we're missing the logic that actually finds the SVN revision
numbers to complain about, but once we have that, we'll have the rest
of the infrustructure to ping IRC and to file bugs.
There's a lot to fill in for the SheriffBot, but this patch give us the
framework in which to do it.
This patch required a bit of refactoring of AbstractQueue because
SheriffBot is the first bot that doesn't process patches (it processes
SVN revisions). Accordingly, I've factored out AbstractPatchQueue to
hold the parts of AbstractQueue that are specific to dealing with
patches. Some of the choices here might not be obvious yet, but we can
tweak them as our needs become clearer.
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- Scripts/webkitpy/commands/sheriffbot.py: Added.
- Scripts/webkitpy/commands/sheriffbot_unittest.py: Added.
- Scripts/webkitpy/mock_bugzillatool.py:
Added a MockIRC object to the mock tool.
- Scripts/webkitpy/multicommandtool.py:
Added a finalize method so the tool can disconnect from IRC
cleanly instead of just droping the socket.
- Scripts/webkitpy/multicommandtool_unittest.py:
- Scripts/webkitpy/patch/patcher.py:
Added support for talking to IRC.
- Scripts/webkitpy/unittests.py:
We should add a commands/unittests.py file at some point to make
the commands module more self-contained.
- 12:32 PM Changeset in webkit [56180] by
-
- 5 edits in trunk/WebCore
2010-03-18 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Multiselect Popup - Listbox click simulation
https://bugs.webkit.org/show_bug.cgi?id=36177
Listbox popups will need to notify the corresponding select elements that a
selection change happened. The current HTMLSelectElement interface does not
allow multiple selections.
The new method listBoxSelectItem will be used for that. I have refactored part
of the mouse handling code in bug 36124 and I am now reusing it here for
<select multiple> popups. All the other cases will handled as they were before to be
sure that no side effects will show up.
- dom/SelectElement.cpp: (WebCore::SelectElement::updateListBoxSelection): (WebCore::SelectElement::listBoxOnChange):
- dom/SelectElement.h:
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxPopupClick):
- html/HTMLSelectElement.h:
- 12:14 PM Changeset in webkit [56179] by
-
- 3 edits in trunk/WebKitTools
2010-03-18 Antti Koivisto <koivisto@iki.fi>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=36102
[Qt] Scaling control API for tiled backing store
Add animated smooth zooming to Qt launcher when in tiled mode.
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::zoomAnimationFinished): (LauncherWindow::applyZoom): (LauncherWindow::zoomIn): (LauncherWindow::zoomOut):
- QtLauncher/webview.h: (WebViewGraphicsBased::graphicsWebView):
- 11:56 AM Changeset in webkit [56178] by
-
- 4 edits in trunk/WebKitTools
2010-03-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support using IRC accounts with a password
https://bugs.webkit.org/show_bug.cgi?id=36287
Add a global option to specify an IRC password so we can use the
sheriffbot account (which needs a password).
- Scripts/webkitpy/irc/ircbot.py:
- Scripts/webkitpy/irc/ircproxy.py:
- Scripts/webkitpy/patch/patcher.py:
- 11:37 AM Changeset in webkit [56177] by
-
- 1 edit2 copies in trunk/LayoutTests
Not reviewed.
https://bugs.webkit.org/show_bug.cgi?id=36210
plugins/resize-from-plugin.html fails on some platforms
Landing new results for Qt and Gtk, taken from buildbot.
Gtk results are a pass, although the difference in clip rect may indicate some issue to look into.
Qt results are a failure.
- platform/gtk/plugins/resize-from-plugin-expected.txt: Copied from LayoutTests/plugins/resize-from-plugin-expected.txt.
- platform/qt/plugins/resize-from-plugin-expected.txt: Copied from LayoutTests/plugins/resize-from-plugin-expected.txt.
- 11:33 AM Changeset in webkit [56176] by
-
- 2 edits in trunk/WebKitTools
2010-03-18 Eric Seidel <eric@webkit.org>
Just fixing missing parenthesis typo, no review.
- Scripts/webkitpy/commands/queries.py: '%' has higher precedence than 'or', use parentheses.
- 11:23 AM Changeset in webkit [56175] by
-
- 37 edits in trunk
2010-03-12 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314
- editing/deleting/non-smart-delete.html:
- editing/pasteboard/drag-drop-modifies-page.html:
- editing/pasteboard/page-zoom-expected.txt: Space is removed because we used to incorrectly smartpaste here. New behavior matches NSTextView.
- editing/style/apply-through-end-of-document-expected.txt: The change here is that selectall + smartpaste doesn't put a BR, but selectall + normal-paste does. Not sure if that's a bug or not, but it's not a side effect of this change.
- editing/style/style-boundary-005.html:
- platform/mac/editing/deleting/non-smart-delete-expected.checksum:
- platform/mac/editing/deleting/non-smart-delete-expected.png:
- platform/mac/editing/deleting/non-smart-delete-expected.txt:
- platform/mac/editing/execCommand/paste-1-expected.txt:
- platform/mac/editing/execCommand/paste-2-expected.txt:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.checksum:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/mac/editing/selection/expanding-selections-expected.txt:
- platform/mac/editing/selection/expanding-selections2-expected.txt:
- platform/mac/editing/selection/triple-click-in-pre-expected.txt: The above three results change because granularity is no longer part of the seleciton, so changes in granularity don't fire selection change notifications.
- platform/mac/editing/style/style-boundary-005-expected.checksum:
- platform/mac/editing/style/style-boundary-005-expected.png:
- platform/mac/editing/style/style-boundary-005-expected.txt:
2010-03-12 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314
- Consolidate all notions of selection-granularity into SelectionController.
- Now only mouse-based selections store a selection-granularity. This matches NSTextView.
New tests were added in http://trac.webkit.org/changeset/55913.
- WebCore.base.exp:
- editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::MoveSelectionCommand): (WebCore::MoveSelectionCommand::doApply):
- editing/MoveSelectionCommand.h: (WebCore::MoveSelectionCommand::create):
- editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::modify): (WebCore::SelectionController::clear):
- editing/SelectionController.h: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::granularity):
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::VisibleSelection): (WebCore::VisibleSelection::expandUsingGranularity): (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): (WebCore::VisibleSelection::validate):
- editing/VisibleSelection.h: (WebCore::operator==):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):
- page/DOMSelection.cpp: (WebCore::DOMSelection::extend):
- page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
- page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag):
- page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::selectionGranularity):
- page/Frame.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange):
2010-03-12 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundPosition):
- 11:22 AM Changeset in webkit [56174] by
-
- 4 edits2 adds in trunk
2010-03-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=36273
CSS3 :indeterminate and input type=radio test fails
The :indeterminate pseudo-class should apply to both radio buttons and checkboxes.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setIndeterminate): Use allowsIndeterminate() to determine if the input supports the indeterminate state. (WebCore::HTMLInputElement::preDispatchEventHandler): Use allowsIndeterminate() to determine whether to handle the indeterminate state. (WebCore::HTMLInputElement::postDispatchEventHandler): Ditto.
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::allowsIndeterminate): New utility method, returns true for radio buttons and checkboxes.
- 11:11 AM Changeset in webkit [56173] by
-
- 4 edits in trunk/WebCore
Unreviewed, build fix.
[V8] Turn npObjectTypeInfo into a function, make everyone happy.
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo): Added new function.
(npCreateV8ScriptObject):
- bindings/v8/NPV8Object.h: Turned npObjectTypeInfo into function.
- bindings/v8/V8NPObject.cpp: Replaced references to function
- 11:06 AM Changeset in webkit [56172] by
-
- 6 edits1 copy in trunk
Reviewed by Adam Roben and Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=36210
plugins/resize-from-plugin.html fails on some platforms
WebKitTools:
Turns out that most platforms don't use "cross-platform" main.cpp. Copied code added for
the test to their versions of the file.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_set_window):
- DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_SetWindow):
LayoutTests:
- platform/win/plugins/resize-from-plugin-expected.txt: Copied from LayoutTests/plugins/resize-from-plugin-expected.txt. Windows results are different, probably because windowed plug-ins just get the whole window as clip rect.
- platform/gtk/Skipped:
- platform/qt/Skipped: Unskipped the tests to see how they work with TestNetscapePlugin fixes from this patch.
- 11:03 AM Changeset in webkit [56171] by
-
- 2 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=36283
Reviewed by Simon Fraser.
The wrong constants were being used for the code that attempted to compact the background-repeat shorthand to
a single value.
Added fast/backgrounds/background-repeat-computed-style.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::fillRepeatToCSSValue):
- 10:57 AM Changeset in webkit [56170] by
-
- 3 edits1 move1 add1 delete in trunk
2010-03-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=36271
CSS3 :enabled on an input type=hidden element fails
The CSS3 selectors spec now makes it clear that hidden inputs should respect
the :enabled and :disabled pseudo-classes.
Test: fast/forms/hidden-input-enabled.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Remove checks for hidden inputs.
- 10:13 AM Changeset in webkit [56169] by
-
- 3 edits4 adds in trunk
WebCore: Intro text at Star Wars demo is clipped.
<rdar://problem/7560979>
https://bugs.webkit.org/show_bug.cgi?id=33909
Reviewed by Simon Fraser.
Test: compositing/repaint/layer-repaint.html
We are flipping the coordinates for drawing, therefore
we must flip them also when we invalidate the rectangles.
- platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::WebLayer::setNeedsDisplay):
LayoutTests: Intro text at Star Wars demo is clipped.
<rdar://problem/7560979>
https://bugs.webkit.org/show_bug.cgi?id=33909
Reviewed by Simon Fraser.
We are flipping the coordinates for drawing, therefore
we must flip them also when we invalidate the rectangles.
- compositing/repaint/layer-repaint.html: Added.
- platform/mac/compositing/repaint/layer-repaint-expected.checksum: Added.
- platform/mac/compositing/repaint/layer-repaint-expected.png: Added.
- platform/mac/compositing/repaint/layer-repaint-expected.txt: Added.
- 9:59 AM Changeset in webkit [56168] by
-
- 4 edits in trunk
2010-03-18 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
Missed a #include in V8Collection.h.
- bindings/v8/V8Collection.h:
- 9:50 AM Changeset in webkit [56167] by
-
- 2 edits2 adds in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=36284.
Reviewed by Simon Fraser.
Make sure the CSS parser properly rejects negative border widths.
Added fast/borders/negative-border-width.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- 9:38 AM Changeset in webkit [56166] by
-
- 44 edits1 add1 delete in trunk
2010-03-18 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Remove V8Index.h and all references to V8ClassIndex.
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/NPV8Object.cpp:
- bindings/v8/NPV8Object.h:
- bindings/v8/V8Collection.h:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8GCController.cpp:
- bindings/v8/V8Helpers.cpp:
- bindings/v8/V8Index.h: Removed.
- bindings/v8/V8IsolatedContext.h:
- bindings/v8/V8NPObject.cpp:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- bindings/v8/V8SVGPODTypeWrapper.h:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/WrapperTypeInfo.h: Move WrapperTypeInfo struct into its own file from V8Index.h.
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8EventSourceConstructor.cpp:
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
- bindings/v8/custom/V8HTMLAudioElementConstructor.h:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
- bindings/v8/custom/V8HTMLImageElementConstructor.h:
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
- bindings/v8/custom/V8HTMLOptionElementConstructor.h:
- bindings/v8/custom/V8HistoryCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- bindings/v8/custom/V8WebGLArrayCustom.h:
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
- bindings/v8/custom/V8WebKitPointConstructor.cpp:
- 9:20 AM Changeset in webkit [56165] by
-
- 3 edits in trunk/WebCore
2010-03-18 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Preserve console history between debugging sessions.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._settingsLoaded): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed):
- inspector/front-end/Settings.js: (WebInspector.Settings.prototype._load):
- 9:12 AM Changeset in webkit [56164] by
-
- 1 edit in trunk/WebCore/ChangeLog
Added reviewer name for r56155
- 8:58 AM Changeset in webkit [56163] by
-
- 4 edits in trunk
2010-03-18 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: Pausing and resuming of animations don't work as expected
https://bugs.webkit.org/show_bug.cgi?id=36219
The play-state layout test now works, and can be removed from the skip list.
- platform/qt/Skipped: animations/play-state.html is removed from the skipped list
2010-03-18 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: Pausing and resuming of animations don't work as expected
https://bugs.webkit.org/show_bug.cgi?id=36219
addAnimation and pauseAnimation were handling animation state changes in
the wrong way.
Apparently WebCore calls addAnimation for resuming, so we have to make
sure to resume an existing animation if that happens. Also, timeOffset
is now used for synchronization of the Qt animation clock with the
WebCore clock, as opposed to using it as a delay timer.
Both those fixes were necessary to get the layout test to work.
LayoutTests/animations/play-state.html now passed on Qt.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::updateState): (WebCore::GraphicsLayerQt::addAnimation): (WebCore::GraphicsLayerQt::pauseAnimation):
- 8:41 AM Changeset in webkit [56162] by
-
- 3 edits2 adds in trunk
2010-03-18 Adam Langley <agl@chromium.org>
Reviewed by David Levin.
[chromium] Fix inverted logic in per-strike renderer patch.
I screwed up in r55089 and got one of the conditions backwards. Thanks
to Roman Tsisyk for pointing it out.
- platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html: Added.
2010-03-18 Adam Langley <agl@chromium.org>
Reviewed by David Levin.
[chromium] Fix inverted logic in per-strike renderer patch.
I screwed up in r55089 and got one of the conditions backwards. Thanks
to Roman Tsisyk for pointing it out.
Test: platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
- 8:23 AM Changeset in webkit [56161] by
-
- 7 edits in trunk/WebCore
2010-03-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Show inherited styles for a selected DOM element
- English.lproj/localizedStrings.js:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties):
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._containsInherited): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.onpopulate):
- 7:59 AM Changeset in webkit [56160] by
-
- 3 edits in trunk/WebKitTools
2010-03-18 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add support to run-launcher to open the EFL example browser.
http://webkit.org/b/36181
- Scripts/webkitdirs.pm:
- Scripts/run-launcher:
- 7:49 AM Changeset in webkit [56159] by
-
- 2 edits in trunk/WebCore
Spatial Navigation: Add isNull and document convenience methods to FocusCandidate
https://bugs.webkit.org/show_bug.cgi?id=36167
Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <tonikitoo@webkit.org>
It turns out that Spatial Navigation related code (in FocusController.cpp for
instance) can be simplified and look better if FocusCandidate class offer some
convinience method. This patch introduces a couple of them (isNull and a Document
getter).
A followup refactoring patch will be making use of these helper methods.
- page/SpatialNavigation.h:
(WebCore::FocusCandidate::FocusCandidate): Added a "Node*" parameter
to FocusCandidate's constructor.
(WebCore::FocusCandidate::isNull): In the Spatial Navigation logic, a NULL
FocusCandidate object is one that does not hold a valid reference to a "Node*".
(WebCore::FocusCandidate::document): This method returns a pointer for the FocusCandidate
node's document, if |node| is a valid pointer.
- 7:42 AM Changeset in webkit [56158] by
-
- 2 edits in trunk/WebCore
2010-03-18 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Antti Koivisto.
[Qt] [Performance] GraphicsLayerQt updates the scene too often
https://bugs.webkit.org/show_bug.cgi?id=36158
This fix makes sure that flushChanges is only called when necessary,
by calling the notifySync function asynchronously, which makes sure flushChanges() is called
after the WebCore compositor has made all its changes.
This has shown a visual improvement on several test-cases.
- Makefile:
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): (WebCore::GraphicsLayerQtImpl::notifySyncRequired): (WebCore::GraphicsLayerQtImpl::notifyChange): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setMaskLayer): (WebCore::GraphicsLayerQt::setPosition): (WebCore::GraphicsLayerQt::setAnchorPoint): (WebCore::GraphicsLayerQt::setSize): (WebCore::GraphicsLayerQt::setTransform): (WebCore::GraphicsLayerQt::setChildrenTransform): (WebCore::GraphicsLayerQt::setPreserves3D): (WebCore::GraphicsLayerQt::setMasksToBounds): (WebCore::GraphicsLayerQt::setDrawsContent): (WebCore::GraphicsLayerQt::setBackgroundColor): (WebCore::GraphicsLayerQt::clearBackgroundColor): (WebCore::GraphicsLayerQt::setContentsOpaque): (WebCore::GraphicsLayerQt::setBackfaceVisibility): (WebCore::GraphicsLayerQt::setOpacity): (WebCore::GraphicsLayerQt::setContentsRect):
- 6:31 AM Changeset in webkit [56157] by
-
- 4 edits in trunk
2010-03-18 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] Failing tests http/tests/misc/image-blocked-src-change.html
& http/tests/misc/image-blocked-src-no-change.html
https://bugs.webkit.org/show_bug.cgi?id=36227
Removed tests from the list of Skipped:
http/tests/misc/image-blocked-src-no-change.html
http/tests/misc/image-blocked-src-change.html
http/tests/security/local-CSS-from-remote.html
http/tests/security/local-video-poster-from-remote.html
http/tests/security/frame-loading-via-document-write.html
http/tests/security/local-iFrame-from-remote.html
http/tests/security/local-video-src-from-remote.html
http/tests/security/local-image-from-remote.html
http/tests/security/local-JavaScript-from-remote.html
- platform/gtk/Skipped:
2010-03-18 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] Failing tests http/tests/misc/image-blocked-src-change.html
& http/tests/misc/image-blocked-src-no-change.html
https://bugs.webkit.org/show_bug.cgi?id=36227
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewConsoleMessage): print only the file name instead of the whole URI when printing messages with local URI's
- 5:47 AM Changeset in webkit [56156] by
-
- 4 edits in trunk/WebKitTools
2010-03-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach what-broke how to look up reviewer and author Committer objects by name
https://bugs.webkit.org/show_bug.cgi?id=36264
- Scripts/webkitpy/commands/queries.py:
- Add committer_by_name lookups for both reviewer and author
- Improve printing in the cases where lookups fail.
- Scripts/webkitpy/committers.py:
- Add committer_by_name
- Scripts/webkitpy/committers_unittest.py:
- Test committer_by_name
- 5:30 AM Changeset in webkit [56155] by
-
- 3 edits in trunk/WebCore
2010-03-18 Stephen White <senorblanco@chromium.org>
Parsing of rgb() colors in HTML canvas is still fairly slow.
findNamedColor() was showing up as hot, so this patch attempts to
avoid calling it by putting the rgb() check ahead of the named
colors. It also removes a call to Color::Color() from
CanvasStyle, which was doing a redundant check for the hex
color and named colors, which CSSParser already does. Finally, it
changes the ad-hoc parser to check for negative values, and clamps them
at zero. This avoids the lex/yacc path for rgb() colors with
negative color components.
Covered by fast/canvas/set-colors.html.
- css/CSSParser.cpp: (WebCore::parseInt): (WebCore::CSSParser::parseColor):
- html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::applyFillColor):
- 5:13 AM Changeset in webkit [56154] by
-
- 2 edits in trunk/LayoutTests
2010-03-18 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Unskip the tests that pass after the fix for bug 36139.
http/tests/appcache/foreign-iframe-main.html
http/tests/appcache/manifest-with-empty-file.html
http/tests/appcache/resource-redirect.html
- platform/qt/Skipped:
- 4:56 AM Changeset in webkit [56153] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-18 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to efl/ewk.
http://webkit.org/b/35931
- efl/ewk/ewk_settings.cpp: Added.
- efl/ewk/ewk_settings.h: Added.
- 1:55 AM Changeset in webkit [56152] by
-
- 2 edits in trunk/WebCore
<http://webkit.org/b/36246> Node::removeAllEventListenersSlowCase is declared but not used
Reviewed by Sam Weinig.
- dom/Node.h:
(WebCore::Node::removeAllEventListenersSlowCase): Removed
declaration. Implementation was removed in r48701.
Mar 17, 2010:
- 10:37 PM Changeset in webkit [56151] by
-
- 5 edits in trunk/WebKitTools
2010-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
create-rollout should actually fill out the description
https://bugs.webkit.org/show_bug.cgi?id=36261
- Scripts/webkitpy/commands/download.py:
The % operator was applied to the wrong string.
- Scripts/webkitpy/commands/download_unittest.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- Scripts/webkitpy/mock_bugzillatool.py:
Add support for seeing what we actually do with create_bug.
- 10:02 PM Changeset in webkit [56150] by
-
- 2 edits in trunk/JavaScriptCore
Update WebKit availability macros for release after 4.0.
Reviewed by Darin Adler and Mark Rowe.
- API/WebKitAvailability.h:
- 9:56 PM Changeset in webkit [56149] by
-
- 1 edit2 adds in trunk/WebCore
2010-03-17 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Oliver Hunt.
[Haiku] Implement ImageBuffer support
https://bugs.webkit.org/show_bug.cgi?id=35288
Covered by existing tests.
The StillImage class implements WebCore::Image by wrapping a native
BBitmap. It will be needed to implement WebCore::ImageBuffer. This
solution is just like it's done in the Qt port.
- platform/graphics/haiku/StillImageHaiku.cpp: Added. (WebCore::StillImage::StillImage): (WebCore::StillImage::destroyDecodedData): (WebCore::StillImage::decodedSize): (WebCore::StillImage::size): (WebCore::StillImage::nativeImageForCurrentFrame): (WebCore::StillImage::draw):
- platform/graphics/haiku/StillImageHaiku.h: Added. (WebCore::StillImage::create):
- 9:06 PM Changeset in webkit [56148] by
-
- 3 edits in trunk/WebCore
[Gtk+] Avoid making a copy of the HTTPHeaderMap.
ResourceRequest::httpHeaderFields() is returning a const
reference but we are storing it as a simple value. This
means that we run either the copy constructor or the assignment
operator and make a copy of the RefPtrs.
This extra copy can be avoided easily by storing
const reference.
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::toSoupMessage):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponseSoup::toSoupMessage):
- 8:58 PM Changeset in webkit [56147] by
-
- 1 edit56 adds in trunk/WebKit
2010-03-17 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add default theme files to efl/DefaultTheme.
http://webkit.org/b/36240
- efl/DefaultTheme/widget/radio/img_radio_on.png: Added.
- efl/DefaultTheme/radio/img_radio_off_hover.png: Added.
- efl/DefaultTheme/radio/img_radio_on_hover.png: Added.
- efl/DefaultTheme/radio/img_radio_off.png: Added.
- efl/DefaultTheme/radio/img_radio_off_focus.png: Added.
- efl/DefaultTheme/radio/img_radio_on_focus.png: Added.
- efl/DefaultTheme/combo/combo_normal.png: Added.
- efl/DefaultTheme/combo/combo_focus_button.png: Added.
- efl/DefaultTheme/combo/combo_hover_button.png: Added.
- efl/DefaultTheme/combo/combo_hover.png: Added.
- efl/DefaultTheme/combo/combo_focus.png: Added.
- efl/DefaultTheme/combo/combo_press_button.png: Added.
- efl/DefaultTheme/combo/combo_normal_button.png: Added.
- efl/DefaultTheme/combo/combo_press.png: Added.
- efl/DefaultTheme/combo/icon.png: Added.
- efl/DefaultTheme/file/file_normal.png: Added.
- efl/DefaultTheme/file/file_press.png: Added.
- efl/DefaultTheme/file/file_hover.png: Added.
- efl/DefaultTheme/file/file_focus.png: Added.
- efl/DefaultTheme/search/cancel/cancel_normal_button.png: Added.
- efl/DefaultTheme/search/cancel/cancel_normal_button2.png: Added.
- efl/DefaultTheme/search/decoration/decoration_normal_button.png: Added.
- efl/DefaultTheme/search/field/field_focused.png: Added.
- efl/DefaultTheme/search/field/field_normal.png: Added.
- efl/DefaultTheme/search/field/field_hovered.png: Added.
- efl/DefaultTheme/entry/img_normal.png: Added.
- efl/DefaultTheme/entry/img_hovered.png: Added.
- efl/DefaultTheme/entry/img_focused.png: Added.
- efl/DefaultTheme/check/img_check_off_hover.png: Added.
- efl/DefaultTheme/check/img_check_on.png: Added.
- efl/DefaultTheme/check/img_check_off_focus.png: Added.
- efl/DefaultTheme/check/img_check_on_focus.png: Added.
- efl/DefaultTheme/check/img_check_off.png: Added.
- efl/DefaultTheme/check/img_check_on_hover.png: Added.
- efl/DefaultTheme/scrollbar/scrollbar_knob_h.png: Added.
- efl/DefaultTheme/scrollbar/scrollbar_knob_v.png: Added.
- efl/DefaultTheme/scrollbar/scrollbar_hilight.png: Added.
- efl/DefaultTheme/scrollbar/scrollbar_v.png: Added.
- efl/DefaultTheme/scrollbar/scrollbar_h.png: Added.
- efl/DefaultTheme/button/img_button_normal.png: Added.
- efl/DefaultTheme/button/img_button_focus.png: Added.
- efl/DefaultTheme/button/img_button_hover.png: Added.
- efl/DefaultTheme/button/img_button_press.png: Added.
- 8:41 PM Changeset in webkit [56146] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Accelerated Compositing is now default on QtWebKit so the option
in QtLauncher must be true as default.
[Qt] QtLauncher's Accelerated Compositing option must be true as default
https://bugs.webkit.org/show_bug.cgi?id=36234
- QtLauncher/main.cpp: (LauncherWindow::applyPrefs): (LauncherWindow::toggleAcceleratedCompositing): (LauncherApplication::handleUserOptions):
- 8:24 PM Changeset in webkit [56145] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Commit queue should ignore (probably red) builders when landing rollouts
https://bugs.webkit.org/show_bug.cgi?id=36169
When landing a rollout, the builders are probably red, so we need to
ignore them in the subprocess too. Also, we might as well update the
working copy because we haven't validated anything about the current
revision prior to trying to land.
This change is testable, but it requires changing the mock executive to
log its arguments. That will generate a lot of expectation changes, so
I'd like to do that in a separate patch.
- Scripts/webkitpy/commands/queues.py:
- 8:07 PM Changeset in webkit [56144] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-17 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
PlatformTouchEventBuilder should not be resizing the touch point
array before appending touch points to it.
https://bugs.webkit.org/show_bug.cgi?id=36231
- src/WebInputEventConversion.cpp: (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
- 7:51 PM Changeset in webkit [56143] by
-
- 2 edits in trunk/WebCore
2010-03-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: When switching resources in the Resources panel, the Content tab is always selected
https://bugs.webkit.org/show_bug.cgi?id=36222
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):
- 7:25 PM Changeset in webkit [56142] by
-
- 5 edits in trunk
2010-03-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
undefined, NaN, and Infinity should be ReadOnly
https://bugs.webkit.org/show_bug.cgi?id=36263
Simply add the ReadOnly flag to these properties.
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
2010-03-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
undefined, NaN, and Infinity should be ReadOnly
https://bugs.webkit.org/show_bug.cgi?id=36263
Add tests for the attributes of undefined, NaN and Infinity on the
global object
- fast/js/getOwnPropertyDescriptor-expected.txt:
- fast/js/resources/getOwnPropertyDescriptor.js:
- 7:16 PM Changeset in webkit [56141] by
-
- 3 edits in trunk/WebKit/qt
2010-03-17 Antti Koivisto <koivisto@iki.fi>
Reviewed by Tor Arne Vestbø.
Fix Qt build with tiled backing store disabled.
- Api/qwebframe.cpp:
- Api/qwebframe_p.h:
- 6:59 PM Changeset in webkit [56140] by
-
- 6 edits in trunk
2010-03-17 Chang Shu <chang.shu@nokia.com>
Reviewed by Laszlo Gombos.
https://bugs.webkit.org/show_bug.cgi?id=36139
[Qt] Unskip the test that now passes.
platform/qt/Skipped:
2010-03-17 Chang Shu <chang.shu@nokia.com>
Reviewed by Laszlo Gombos.
https://bugs.webkit.org/show_bug.cgi?id=36139
[Qt] Clean up cache while setting cache quota. This behavior matches other platforms,
such as mac and gtk.
- Api/qwebsettings.cpp:
(QWebSettings::setOfflineWebApplicationCacheQuota):
2010-03-17 Chang Shu <chang.shu@nokia.com>
Reviewed by Laszlo Gombos.
https://bugs.webkit.org/show_bug.cgi?id=36139
[Qt] Clean up cache each time DumpRenderTree starts. This behavior
matches other platforms, such as mac and gtk.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- 6:32 PM Changeset in webkit [56139] by
-
- 3 edits in trunk/WebCore
databaseIdentifiers are not filtered for slashes
<rdar://problem/7708789> and https://bugs.webkit.org/show_bug.cgi?id=36243
Reviewed by Darin Adler.
In addition to filtering for '/' and '\', to remove the directory vulnerability
on all platforms, it seems worth it to also escape other characters that are
obviously dangerous or illegal to have in a filename (mostly inspired by the
Windows illegal-character list).
No new tests - It's unclear how a test could possibly work into our testing
infrastructure.
- page/SecurityOrigin.cpp:
(WebCore::): Added a 128-bool table "needsEscaping" that has a true/false answer
for lower-ASCII.
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::createFromDatabaseIdentifier): "Unescape" the host
component using the KURL utility.
(WebCore::shouldEscapeUChar): If the char is lower-ASCII, look it up in the
needsEscaping table. Otherwise, let it pass.
(WebCore::encodedHost): Modeled after KURL's host escaping method, but targeted
for the escaping considerations for the host component. We don't use the KURL
version because this one is "different" enough because it operates on UTF16 and
has its own "is bad character?" decider.
(WebCore::SecurityOrigin::databaseIdentifier): Create the escaped host if needed,
and use it instead of the unescaped host.
- page/SecurityOrigin.h:
- 6:17 PM Changeset in webkit [56138] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Adam Barth <abarth@webkit.org>
Unreviewed.
Turns out this needs to be a string.
- Scripts/webkitpy/bugzilla.py:
- 6:09 PM Changeset in webkit [56137] by
-
- 12 edits in trunk/WebKitTools
2010-03-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add more infrastructure for sheriff-bot, including making what-broke more awesome
https://bugs.webkit.org/show_bug.cgi?id=36254
- Scripts/webkitpy/bugzilla.py:
- Made the various URL methods return None when passed None.
- Scripts/webkitpy/bugzilla_unittest.py:
- Test that the url methods work as expected.
- Scripts/webkitpy/buildbot.py:
- Add a static Build.build_url so that its possible to generate a build url without a Build object.
- Give users a URL in _fetch_xmlrpc_build_dictionary error message.
- Scripts/webkitpy/changelogs.py:
- Add a new ChangeLogEntry class to encapsulate entry-parsing logic.
- Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code.
- Make ChangeLog.parse_latest_entry_from_file a public method.
- Scripts/webkitpy/changelogs_unittest.py:
- Add tests for new ChangeLog entry parsing.
- Scripts/webkitpy/commands/queries.py:
- Make "what-broke" not print "ok" builders, only failing ones.
- Print much more information on failing builders, including links and authorship/reviewer information.
- Scripts/webkitpy/commands/queues_unittest.py:
- Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests.
- Scripts/webkitpy/mock_bugzillatool.py:
- Move MockSCM away from using os.getcwd() as that was fragile (and wrong).
- Scripts/webkitpy/patch/patcher.py:
- Remove code which was broken now that this file has moved.
- Code was also redundant now that SCM.find_checkout_root() exists.
- Scripts/webkitpy/scm.py:
- Greatly simplify modified_changelogs now that I understand list comprehensions.
- Expect ChangeLogEntry objects instead of raw strings.
- Add changed_files_for_revision, committer_email_for_revision and contents_at_revision
- Add commit_with_message argument to all sites since someone half-added it before. :(
- Get rid of copy/paste code using _status_regexp()
- Scripts/webkitpy/scm_unittest.py:
- Fix these tests!
- Add new tests for new scm code.
- Fix spelling of "awsome" to "awesome".
- 5:37 PM Changeset in webkit [56136] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-03-17 Drew Wilson <atwilson@chromium.org>
Reviewed by David Levin.
Add tests for "load shared worker in iframe" case.
https://bugs.webkit.org/show_bug.cgi?id=36203
Makes sure that creating a worker simultaneously in a document and in
a child iframe works (you end up with a single instance).
- fast/workers/resources/shared-worker-count-connections.js: Added.
- fast/workers/resources/shared-worker-iframe.html: Added.
- fast/workers/shared-worker-in-iframe-expected.txt: Added.
- fast/workers/shared-worker-in-iframe.html: Added.
- 5:10 PM Changeset in webkit [56135] by
-
- 2 edits in trunk/JavaScriptCore
Speed up Math.round a little by removing unneeded special case
https://bugs.webkit.org/show_bug.cgi?id=36107
Reviewed by Oliver Hunt.
Test: fast/js/math.html
- runtime/MathObject.cpp:
(JSC::mathProtoFuncRound): This function had a special case for numbers
between -0.5 and -0.0 to return -0.0. But the algorithm in the function
already yields -0.0 for those cases, so the extra checking and branching
is unneeded.
- 4:40 PM Changeset in webkit [56134] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-03-17 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=36059
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvas-text-baseline-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-text-baseline-expected.png: Added.
- platform/qt/fast/canvas/canvas-text-baseline-expected.txt: Added.
- 4:39 PM Changeset in webkit [56133] by
-
- 5 edits in trunk/WebKitTools
2010-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Change post-rollout to create-rollout and have it make a new bug
instead of posting the rollout to the old bug.
https://bugs.webkit.org/show_bug.cgi?id=36250
The new bug blocks the old bug instead of adding more complexity to the
old bug. One tricky question is whether to create the bug if we're
unable to create a rollout patch. In this patch, we do create the bug,
but we might revist this question in the future.
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/download_unittest.py:
- Scripts/webkitpy/steps/createbug.py:
- 4:18 PM Changeset in webkit [56132] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Daniel Bates <dbates@rim.com>
Rubber-stamped by David Levin.
Add myself to the list of reviewers.
- Scripts/webkitpy/committers.py:
- 4:01 PM WebKit Team edited by
- Moved my entry from Committer to Reviewer. (diff)
- 3:38 PM Changeset in webkit [56131] by
-
- 5 edits3 adds in trunk
[v8] Avoid reentry into v8 after TerminateExecution() on a worker thread.
https://bugs.webkit.org/show_bug.cgi?id=36239
Reviewed by Dimitri Glazkov.
WebCore:
Test: fast/workers/termination-with-port-messages.html
- bindings/v8/V8Proxy.h:
(WebCore::throwError): Avoid throwing if v8 execution is terminated anyways.
- bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::proxy): Return V8 proxy as 0 if execution is terminating. Callers to check for 0 before invoking v8.
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval): Bail out if v8 proxy is 0.
(WebCore::toV8): Ditto
LayoutTests:
- fast/workers/resources/termination-with-port-messages.js: Added.
(echo):
(onmessage):
- fast/workers/termination-with-port-messages-expected.txt: Added.
- fast/workers/termination-with-port-messages.html: Added.
- 3:23 PM Changeset in webkit [56130] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-17 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL example browser to efl/EWebLauncher.
http://webkit.org/b/36176
- efl/EWebLauncher/main.c: Added.
- 2:58 PM Changeset in webkit [56129] by
-
- 2 edits in trunk/WebKit/chromium
[chromium] Roll Chromium builder's DEPS to current revs.
https://bugs.webkit.org/show_bug.cgi?id=36241
Reviewed by Dimitri Glazkov.
- DEPS:
- 2:47 PM Changeset in webkit [56128] by
-
- 11 edits1 delete in trunk/WebCore
2010-03-17 José Millán Soto <jmillan@igalia.com>
Reviewed by Adam Barth.
Change the way of prefetching DNS to allow prefetching function to use full URL
https://bugs.webkit.org/show_bug.cgi?id=35589
Creates a new function, ResourceHandle::prepareForURL, whose default implementation
calls prefetchDNS with the host of the given URL as the parameter.
Soup implementation of ResourceHandle::prepareForURL executes soup_session_prepare_for_uri.
Soup implementation of prefetchDNS is removed.
Changed various prefetchDNS calls to ResourceHandle::prepareForURL calls.
- GNUmakefile.am:
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
- page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement):
- platform/network/DNS.h:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::prepareForURL):
- platform/network/ResourceHandle.h:
- platform/network/chromium/DNSChromium.cpp: (WebCore::ResourceHandle::prepareForURL):
- platform/network/soup/DNSSoup.cpp: Removed.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL):
- wml/WMLAElement.cpp: (WebCore::WMLAElement::parseMappedAttribute):
- 2:11 PM Changeset in webkit [56127] by
-
- 15 edits2 deletes in trunk
2010-03-17 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
https://bugs.webkit.org/show_bug.cgi?id=36233
The patch for bug 33416, which added multisampling support to the
WebGL back buffer, uncovered some OpenGL driver bugs on the build
bots which need further investigation to determine the appropriate
workaround. Reverting this change, the minor build fix in 36189,
and the skipping of the affected tests in bug 36200.
Built and tested WebKit and Chromium and ran all WebGL layout
tests in both.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3D::readPixels):
2010-03-17 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
https://bugs.webkit.org/show_bug.cgi?id=36233
The patch for bug 33416, which added multisampling support to the
WebGL back buffer, uncovered some OpenGL driver bugs on the build
bots which need further investigation to determine the appropriate
workaround. Reverting this change, the minor build fix in 36189,
and the skipping of the affected tests in bug 36200.
Built and tested WebKit and Chromium and ran all WebGL layout
tests in both.
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/mac/Canvas3DLayer.h:
- platform/graphics/mac/Canvas3DLayer.mm: (-[Canvas3DLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]):
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::readPixels):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):
2010-03-17 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
https://bugs.webkit.org/show_bug.cgi?id=36233
The patch for bug 33416, which added multisampling support to the
WebGL back buffer, uncovered some OpenGL driver bugs on the build
bots which need further investigation to determine the appropriate
workaround. Reverting this change, the minor build fix in 36189,
and the skipping of the affected tests in bug 36200.
Built and tested WebKit and Chromium and ran all WebGL layout
tests in both.
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Removed.
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Removed.
- fast/canvas/webgl/context-attributes-expected.txt:
- fast/canvas/webgl/context-attributes.html:
- fast/canvas/webgl/gl-get-calls-expected.txt:
- fast/canvas/webgl/gl-get-calls.html:
- platform/mac/Skipped:
- 2:02 PM Changeset in webkit [56126] by
-
- 8 edits in trunk/WebCore
Optimize painting for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36113
Cache the progress bar's position, so it is not required to recalculate
it for each repaint.
Call repaintRectangle() when the position changes.
Reviewed by Darin Adler.
No new tests, as no new functionality introduced.
- html/HTMLProgressElement.cpp:
- platform/qt/RenderThemeQt.cpp:
- platform/qt/RenderThemeQt.h:
- rendering/RenderProgress.cpp:
- rendering/RenderProgress.h:
- rendering/RenderTheme.cpp:
- rendering/RenderTheme.h:
- 1:52 PM Changeset in webkit [56125] by
-
- 3 edits9 adds in trunk/WebKitTools
2010-03-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a way for the bots to send messages to IRC
https://bugs.webkit.org/show_bug.cgi?id=36235
We'll use these classes to notify #webkit about bad SVN revisions.
This patch just has some skeleton code for us to play with.
- Scripts/webkitpy/irc/init.py: Added.
- Scripts/webkitpy/irc/ircbot.py: Added.
A bot that knows how to talk to IRC.
- Scripts/webkitpy/irc/ircproxy.py: Added.
We need to run the bot on its own thread because the irclib needs
its own mainloop. This class provides an abstraction of the
threading.
- Scripts/webkitpy/irc/messagepump.py: Added.
- Scripts/webkitpy/irc/messagepump_unittest.py: Added.
- Scripts/webkitpy/irc/threadedmessagequeue.py: Added.
A thread-safe message queue for sending messages from the main
thread to the IRC thread.
- Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Added.
- Scripts/webkitpy/irc/unittests.py: Added.
- Scripts/webkitpy/thirdparty/autoinstalled/init.py:
Autoinstall irclib
- Scripts/webkitpy/unittests.py:
- 11:47 AM Changeset in webkit [56124] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-17 Mike Homey <glandium@debian.org>
Reviewed by Gustavo Noronha.
Build fix for SPARC. Fix missing macro value.
- wtf/Platform.h:
- 11:44 AM Changeset in webkit [56123] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Victor Wang <victorw@chromium.org>
Reviewed by Dimitri Glazkov.
Fix image_diff syntax in webkitpy/port/base.py.
The syntax is wrong if diff_filename is specified.
- Scripts/webkitpy/layout_tests/port/base.py:
- 11:22 AM Changeset in webkit [56122] by
-
- 2 edits in trunk/LayoutTests
- platform/gtk/Skipped: Also, resize-from-plugin.html got skipped twice tonight, removing one of the lines.
- 11:15 AM Changeset in webkit [56121] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to fix the build
- 11:11 AM Changeset in webkit [56120] by
-
- 2 edits in trunk/WebCore
Mac Buildfix: Using ASSERT_UNUSED instead of ASSERT.
Reviewed by Simon fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- dom/SelectElement.cpp:
(WebCore::SelectElement::listBoxDefaultEventHandler):
- 11:02 AM Changeset in webkit [56119] by
-
- 2 edits in trunk/LayoutTests
- platform/gtk/Skipped: Updated to reference a newly filed bug.
- 11:00 AM Changeset in webkit [56118] by
-
- 8 edits in trunk
Missing support for showing compositing layers borders and repaint count on Windows.
<rdar://problem/7760736>
<https://bugs.webkit.org/show_bug.cgi?id=36197>
Reviewed by Darin Adler.
WebCore:
- platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::WebLayer::drawInContext): Modified to use the correct font on Windows.
WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::showDebugBorders):
(WebPreferences::setShowDebugBorders):
(WebPreferences::showRepaintCounter):
(WebPreferences::setShowRepaintCounter):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
- 10:37 AM Changeset in webkit [56117] by
-
- 2 edits in trunk/WebKitTools
2010-03-16 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Christiansen.
Provide to QtLauncher a way to change the ViewportUpdateMode
when it's in graphics based mode.
[Qt] Make QtLaucher able to select the ViewportUpdateMode
https://bugs.webkit.org/show_bug.cgi?id=36175
- QtLauncher/main.cpp: (LauncherWindow::selectViewportUpdateMode): (LauncherWindow::createChrome):
- 10:25 AM Changeset in webkit [56116] by
-
- 3 edits in trunk/WebCore
Multiselect Popup - SelectElement refactoring. https://bugs.webkit.org/show_bug.cgi?id=36124
Reviewed by Antti Koivisto.
As it is today it is not possible to the menulists popups to tell SelectElement
that more then one option is selected. If you select one the other ones
selected state will turn off.
For <select multiple> I needed to extend the API used by menulist popups. This
is the first step. Just refactoring SelectElement without any behavior change.
Separating code that will be reused in future patches.
- dom/SelectElement.cpp:
(WebCore::SelectElement::updateSelectedState):
(WebCore::SelectElement::listBoxDefaultEventHandler):
- dom/SelectElement.h:
- 10:09 AM Changeset in webkit [56115] by
-
- 1 edit1 copy1 delete in trunk/WebCore
2010-03-17 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
Delete the correct file this time.
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: Copied from WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp.
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: Removed.
- 9:51 AM Changeset in webkit [56114] by
-
- 14 edits1 delete in trunk/WebCore
2010-03-17 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Remove custom bindings callbacks that aren't in use.
(The relevant .idl doesn't mark them as V8Custom or Custom).
- Android.v8bindings.mk:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8WebGLArrayCustom.h:
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: Removed.
- 9:11 AM Changeset in webkit [56113] by
-
- 2 edits in trunk/WebKitTools
2010-03-17 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Ambiguous error message when building for unspecified platform
https://bugs.webkit.org/show_bug.cgi?id=30203
Add an extra line information to the error message.
- Scripts/webkitdirs.pm:
- 8:24 AM Changeset in webkit [56112] by
-
- 3 edits in trunk/WebCore
2010-03-17 Steve Block <steveblock@google.com>
Reviewed by Dimitri Glazkov.
Adds ENABLE(WORKERS) guards to V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=36221
Build fix only, no new tests.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8Proxy.cpp: (WebCore::toV8Context):
- 7:57 AM ImprovingLifeOnWindows edited by
- Rolled out changeset 56044 as to broke the Windows Debug (test) bot. … (diff)
- 7:40 AM Changeset in webkit [56111] by
-
- 2 edits in trunk/LayoutTests
2010-03-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: update mimetype expectations in inspector tests.
- inspector/timeline-network-resource-expected.txt:
- 7:30 AM Changeset in webkit [56110] by
-
- 3 edits1 delete in trunk
2010-03-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: GTK tests fix - removed custom expectation that was
added with no good reason.
- inspector/timeline-test.js:
- platform/gtk/inspector/timeline-network-resource-expected.txt: Removed.
- 7:20 AM Changeset in webkit [56109] by
-
- 2 edits in trunk/WebCore
2010-03-17 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Remove unused reference to InspectorController from InspectorFrontend.
- inspector/InspectorFrontend.h:
- 7:08 AM Changeset in webkit [56108] by
-
- 14 edits in trunk
2010-03-17 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Timeline improvements - next iteration.
The top level records should be collapsed.
Virtually linked events should be nested in Timeline like Send Request and
corresponding Received Responce, Timer Install and Timer Fire etc.
It should be possible to see Main Resource request.
- inspector/InspectorController.cpp: (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didReceiveResponse):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
- inspector/InspectorTimelineAgent.h:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._findParentRecord): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype.resize): (WebInspector.TimelinePanel.prototype._createTopLevelRecord): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._clean): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype.get children): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
- inspector/front-end/inspector.css:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse):
- 6:51 AM Changeset in webkit [56107] by
-
- 11 edits in trunk/WebCore
2010-03-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Reimplement style-related audits using native API
https://bugs.webkit.org/show_bug.cgi?id=36172
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getAllStyles):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getMatchedCSSRules): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetAllStyles):
- inspector/InspectorFrontend.h:
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
- inspector/front-end/DOMAgent.js:
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 5:47 AM Changeset in webkit [56106] by
-
- 4 edits in trunk
WebKit/qt: [Qt] Enable accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=35866
Reviewed by Kenneth Rohde Christiansen.
- Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):
LayoutTests: [Qt] GraphicsLayer: fix test regressions
https://bugs.webkit.org/show_bug.cgi?id=36191
Reviewed by Kenneth Rohde Christiansen.
Enabling accelerated compositing (AC) by default make 3 tests fail.
AC is more important now than these tests, so they are skipped until
fix and AC is enabled.
- platform/qt/Skipped:
- animations/fill-mode-transform.html skipped
- animations/play-state.html skipped
- animations/simultaneous-start-left.html skipped
- 5:10 AM Changeset in webkit [56105] by
-
- 6 edits in trunk/WebCore
2010-03-17 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Replace instances of bzero in WebCore/bridge common code with memset
https://bugs.webkit.org/show_bug.cgi?id=36214
Syntax change only, no new tests.
- bridge/jni/JNIUtility.cpp: (JSC::Bindings::getJNIField):
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::dispatchValueFromInstance):
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue):
- bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJValue):
- bridge/jni/v8/JavaNPObjectV8.cpp: (JSC::Bindings::AllocJavaNPObject):
- 3:59 AM Changeset in webkit [56104] by
-
- 5 edits in trunk/WebCore
2010-03-17 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Mark inspector resources as changed so that they are reloaded on the next frontend connection.
Split resetScriptObjects into code specific for page navigation and insepctor frontend disconnection.
- WebCore.xcodeproj/project.pbxproj: Added InspectorWorkerResource.h to the project file.
- inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::releaseScriptObject):
- 2:57 AM Changeset in webkit [56103] by
-
- 2 edits in trunk/WebCore
2010-03-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Capture main resource load events in timeline panel.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
- 1:05 AM Changeset in webkit [56102] by
-
- 3 edits in trunk/LayoutTests
Disable new plugin tests from r56079 on Gtk and Qt, since they are failing.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 12:51 AM Changeset in webkit [56101] by
-
- 2 edits in trunk/LayoutTests
2010-03-17 Xan Lopez <xlopez@igalia.com>
Skip a couple of failing tests in the bots.
- platform/gtk/Skipped:
- 12:39 AM Changeset in webkit [56100] by
-
- 2 edits in trunk/WebCore
2010-03-17 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for AtomicString class
https://bugs.webkit.org/show_bug.cgi?id=35907
Inherits the following class from FastAllocBase because it is
instantiated by 'new':
class name - instantiated at: WebCore/'location'
AtomicString - WebCore/html/HTMLTableElement.cpp:525
- platform/text/AtomicString.h:
Mar 16, 2010:
- 11:50 PM Changeset in webkit [56099] by
-
- 2 edits in trunk/WebKitTools
2010-03-16 Adam Barth <abarth@webkit.org>
No review, rolling out r56044.
http://trac.webkit.org/changeset/56044
https://bugs.webkit.org/show_bug.cgi?id=36048
This patch broke Windows Debug (Tests)
- Scripts/webkitdirs.pm:
- 8:35 PM QtWebKitBackportingFixes edited by
- (diff)
- 6:53 PM Changeset in webkit [56098] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-16 James Hawkins <jhawkins@chromium.org>
Reviewed by David Levin.
[Chromium] Size the WebVector of forms after determining how many
forms are valid and will be returned.
No new tests, as this is only triggered by Chromium's use of the
WebFormElement API.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
- 6:05 PM Changeset in webkit [56097] by
-
- 4 edits in trunk/LayoutTests/platform
update skipped test locations since I moved my test before commit
- 5:31 PM Changeset in webkit [56096] by
-
- 13 edits3 adds in trunk
2010-03-16 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
Give keyboard focus to PluginDocuments by default
https://bugs.webkit.org/show_bug.cgi?id=36147
Test: http/tests/plugins/plugin-document-has-focus.html
- loader/PluginDocument.cpp: (WebCore::PluginDocument::pluginNode):
- loader/PluginDocument.h:
- page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument):
2010-03-16 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
Give keyboard focus to PluginDocuments by default
https://bugs.webkit.org/show_bug.cgi?id=36147
- http/tests/plugins/plugin-document-has-focus-expected.txt: Added.
- http/tests/plugins/plugin-document-has-focus.html: Added.
- http/tests/plugins/resources/plugin-document-has-focus.pl: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2010-03-16 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
Give keyboard focus to PluginDocuments by default
https://bugs.webkit.org/show_bug.cgi?id=36147
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginAllocate):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_SetWindow): (handleEventCarbon): (handleEventCocoa):
- 5:23 PM Changeset in webkit [56095] by
-
- 3 edits in trunk/WebKitLibraries
Fix incorrect glyph advances when using the Core Graphics (non-GDI) glyph look.
Reviewed by Sam Weinig.
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 5:10 PM Changeset in webkit [56094] by
-
- 5 edits2 adds in trunk
REGRESSION (r53857): Crash when tabbing to <map>
https://bugs.webkit.org/show_bug.cgi?id=36017
Reviewed by Darin Adler.
WebCore:
Test: fast/events/imagemap-norender-crash.html
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
LayoutTests:
Also fix the path to js-test-post.js in tab-imagemap.html.
- fast/events/imagemap-norender-crash-expected.txt: Added.
- fast/events/imagemap-norender-crash.html: Added.
- fast/events/tab-imagemap-expected.txt:
- fast/events/tab-imagemap.html:
- 4:39 PM Changeset in webkit [56093] by
-
- 2 edits in trunk/LayoutTests
2010-03-16 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
Temporarily disable WebGL layout tests failing due to multisampling
https://bugs.webkit.org/show_bug.cgi?id=36200
- platform/mac/Skipped:
- 4:14 PM Changeset in webkit [56092] by
-
- 2 edits in trunk/JavaScriptCore
Bug 36083 - REGRESSION (r55772-r55834): Crash in JavaScriptCore RegExp code on PowerPC
Reviewed by Oliver Hunt, Darin Adler.
The problem is a bug in our port of PCRE - that a read may take place from the first character in an
empty string. For the time being, revert to using a valid pointer in the data segment rather than
an invalid non-null pointer into the zero-page for the empty string's data pointer. A better fix for
this will be to remove PCRE.
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::empty):
- 4:05 PM Changeset in webkit [56091] by
-
- 2 edits in trunk/WebKitTools
Fix run-webkit-httpd on Windows.
Reviewed by Mark Rowe.
- Scripts/webkitperl/httpd.pm:
- 3:33 PM Changeset in webkit [56090] by
-
- 2 edits in trunk/WebKitTools
Tiger build fix.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Added more type casts to shut down warnings.
- 3:30 PM Changeset in webkit [56089] by
-
- 7 edits in trunk/LayoutTests
2010-03-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Alexey Proskuryakov.
fix webkit win test failures for smart delete
https://bugs.webkit.org/show_bug.cgi?id=36141
Works around https://bugs.webkit.org/show_bug.cgi?id=36140.
- editing/deleting/smart-delete-004.html:
- editing/pasteboard/smart-paste-002.html:
- editing/pasteboard/smart-paste-005.html:
- editing/pasteboard/smart-paste-007.html:
- platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
- 3:26 PM Changeset in webkit [56088] by
-
- 3 edits in trunk/WebCore
Build fix. No Review.
Correct missing includes in cURL network backend introduced
by recent changes in WebKit.
- platform/network/curl/ResourceHandleCurl.cpp: Add missing includes for SharedBuffer and PassRefPtr.
(WebCore::ResourceHandle::loadResourceSynchronously): Correct
constructor signature for ResourceHandle to match @r55688.
- platform/network/curl/ResourceHandleManager.cpp: Add missing include for RetainPtr.
- 3:18 PM ImprovingLifeOnWindows edited by
- Support for detecting the presence of the Windows Platform SDK was … (diff)
- 3:10 PM QtWebKitGraphics edited by
- (diff)
- 2:26 PM Changeset in webkit [56087] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.90
Tagging 1.1.90.
- 2:26 PM Changeset in webkit [56086] by
-
- 4 edits in trunk/WebKitTools
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36184
YouTube video resizing doesn't work with OOP plug-ins
Added a resizeTo() method, which calls resizePlugin() in JS with the same arguments,
and a lastSetWindowArguments property, which returns a string describing the last NPWindow
passed to NPN_SetWindow.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): (testResizeTo): (pluginInvoke):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_SetWindow):
- 2:07 PM Changeset in webkit [56085] by
-
- 12 edits in trunk/JavaScriptCore
Rolled out r56081 since it broke the Windows build.
- 1:58 PM Changeset in webkit [56084] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-16 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Build breakage from 33416
https://bugs.webkit.org/show_bug.cgi?id=36189
No new tests. Built release Chromium.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::reshape):
- 1:49 PM Changeset in webkit [56083] by
-
- 2 edits in trunk
2010-03-16 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Update library version for 1.1.90 release.
- configure.ac:
- 1:46 PM Changeset in webkit [56082] by
-
- 4 edits in trunk
2010-03-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump version for 1.1.90 release.
- configure.ac:
WebKit/gtk:
2010-03-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for 1.1.90 release.
- NEWS:
- 1:46 PM Changeset in webkit [56081] by
-
- 12 edits in trunk/JavaScriptCore
Added arrayLength function and used it instead of hand-written code.
Reviewed by Sam Weinig.
- JavaScriptCore.xcodeproj/project.pbxproj:
Removed PtrAndFlags.h. The file was removed long ago.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Use arrayLength.
- runtime/Collector.h:
(JSC::CollectorBitmap::count): Remove WTF:: prefix from use
of bitCount. In WTF we inject things into the global namespace
and this is no exception.
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate): Use arrayLength.
- runtime/JSFunction.h:
(JSC::JSFunction::nativeFunction): Remove WTF:: prefix as above.
(JSC::JSFunction::scopeChain): Ditto.
(JSC::JSFunction::setScopeChain): Ditto.
(JSC::JSFunction::setNativeFunction): Ditto.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset): Use arrayLength.
- runtime/JSImmediate.h:
(JSC::reinterpretDoubleToIntptr): Remove WTF:: prefix as above.
(JSC::reinterpretIntptrToDouble): Ditto.
- runtime/JSONObject.cpp:
(JSC::Stringifier::appendQuotedString): Use arrayLength.
(JSC::Stringifier::toJSON): Ditto.
(JSC::Stringifier::appendStringifiedValue): Ditto.
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings): Ditto.
- runtime/UString.cpp:
(JSC::UString::from): Use arrayLength.
- wtf/StdLibExtras.h:
(WTF::bitwise_cast): Marked this inline!
(WTF::arrayLength): Added function template (actually written by Sam).
Added using declarations for public things in WTF namespace defined
in this file.
- 1:44 PM Changeset in webkit [56080] by
-
- 2 edits in trunk/WebKit/gtk
2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Fix one too many empty lines in documentation of
window-obejct-cleared signal, which caused the documentation to be
rendered funny. Thanks to Martin Robinson for noticing.
- webkit/webkitwebview.cpp:
- 1:40 PM Changeset in webkit [56079] by
-
- 5 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36184
YouTube video resizing doesn't work with OOP plug-ins
Test: plugins/resize-from-plugin.html
We were calling _WKPHResizePluginInstance synchronously or asynchronously, depending on
whether the size has changed. But sync and async messages are not necessarily delivered in
order - plug-in host listens only to the former while waiting for a response to a message it
sent (a call to invoke() in this case).
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resize):
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]):
- 1:31 PM Changeset in webkit [56078] by
-
- 2 edits in trunk/WebKit/gtk
2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Add missing symbol to GeoLocation documentation
section.
- docs/webkitgtk-sections.txt:
- 12:35 PM Changeset in webkit [56077] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-03-16 Matej Urbančič <mateju@svn.gnome.org>
Reviewed by Gustavo Noronha.
Slovenian translation.
- sl.po: Added.
- 12:14 PM Changeset in webkit [56076] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-03-16 António Lima <amrlima@gmail.com>
Reviewed by Gustavo Noronha.
Translation for pt (Portuguese)
https://bugs.webkit.org/show_bug.cgi?id=36148
- pt.po: Added.
- 11:56 AM Changeset in webkit [56075] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-16 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35916
- efl/WebCoreSupport/ContextMenuClientEfl.cpp: Added.
- efl/WebCoreSupport/ContextMenuClientEfl.h: Added.
- 11:53 AM Changeset in webkit [56074] by
-
- 14 edits2 adds in trunk
2010-03-16 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416
Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
- src/GraphicsContext3D.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Windows.
2010-03-16 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416
Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Fix an index bug.
- platform/graphics/GraphicsContext3D.h: Add members/functions for multisampling/stencil buffer purpose.
- platform/graphics/mac/Canvas3DLayer.h: Add GraphicsContext3D as a member of Canvas3DLayer.
- platform/graphics/mac/Canvas3DLayer.mm: Add multisampling support.
- platform/graphics/mac/GraphicsContext3DMac.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Mac.
- platform/graphics/mac/GraphicsLayerCA.mm: Adjust to modified Canvas3DLayer init call.
2010-03-16 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Added.
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Added.
- fast/canvas/webgl/context-attributes-expected.txt: WebGL context attributes behavior changed with this fix.
- fast/canvas/webgl/context-attributes.html: Ditto.
- fast/canvas/webgl/gl-get-calls-expected.txt: Stencil buffer is enabled, thus Stencil Bits is no longer 0.
- fast/canvas/webgl/gl-get-calls.html: Ditto.
- 11:18 AM Changeset in webkit [56073] by
-
- 7 edits in trunk
2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
Added layout tests to get the number of rows and columns.
https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables
- platform/gtk/accessibility/table-hierarchy.html:
- platform/gtk/accessibility/table-hierarchy-expected.txt:
2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables
Causes "layout tables" to be exposed as AccessibilityTables for Gtk.
- accessibility/AccessibilityTable.cpp: (AccessibilityTable::isTableExposableThroughAccessibility):
2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables
Implements rowCount and columnCount for Gtk in DRT.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::rowCount): (AccessibilityUIElement::columnCount):
- 10:41 AM Changeset in webkit [56072] by
-
- 5 edits in trunk/WebKit/gtk
2010-03-16 Martin Robinson <Martin Robinson>
Reviewed by Xan Lopez.
can't input korean into lower all input box except adress input box in webkit gtk launcher
https://bugs.webkit.org/show_bug.cgi?id=32290
Make the GTK+ EditorClient properly handle different types of input module
behavior such as commit and preedit signals that happen outside of key event
filtering and multiple times in a row. Filter keyup events as well as keydown
events and call gtk_im_context_focus_{in/out} when the WebView focus changes.
Added tests for this behavior to the GTK+ unit tests.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): Handle this signal properly when it happens outside of key event filtering. (WebKit::imContextPreeditChanged): Immediately update the preedit state and do not reject empty preedits, so that cancellation works properly. (WebKit::EditorClient::updatePendingComposition): Add this method, which handles the situation where a commit signal happens when there is still a pending commit. (WebKit::EditorClient::shouldBeginEditing): Clear pending composition state before editing starts. (WebKit::EditorClient::shouldEndEditing): Clear pending composition state before editing ends. (WebKit::EditorClient::handleKeyboardEvent): No longer special case preedits which happen during key event filtering. When confirming a pending composition use insertText instead of confirmComposition. (WebKit::EditorClient::handleInputMethodKeydown):
- WebCoreSupport/EditorClientGtk.h: Make pendingComposition a member, so that multiple WebViews do not share state. (WebKit::EditorClient::webView): Added. (WebKit::EditorClient::treatContextCommitAsKeyEvent): Added. (WebKit::EditorClient::clearPendingComposition): Added.
- tests/testkeyevents.c: (test_keypress_events_load_status_cb): (map_event_cb): (setup_keyevent_test): (test_keypress_events): (element_text_equal_to): (test_ime_load_status_cb): (test_ime): (main):
- webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): (webkit_web_view_focus_in_event):
- 10:33 AM Changeset in webkit [56071] by
-
- 2 edits in trunk/WebCore
Unreviewed. Build fix for distcheck.
- 10:26 AM Changeset in webkit [56070] by
-
- 9 edits in trunk
2010-03-15 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36152
[chromium] Add support for history.pushState and history.replaceState
This is covered by the existing tests in fast/loader/stateobjects
- 9:58 AM Changeset in webkit [56069] by
-
- 2 edits in trunk/WebCore
Fix linker warnings when building WebCore on Windows
Rubber-stamped by Steve Falkenburg.
- WebCore.vcproj/WebCore.vcproj: Exclude JSDOMFormData.cpp from the
build, since it's already included in DerivedSources.cpp. Also let VS
sort this file as it saw fit.
- 9:53 AM QtWebKitGraphics edited by
- (diff)
- 9:49 AM Changeset in webkit [56068] by
-
- 6 edits in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=36121
[Qt] Make WebKit scrollbars work with tiling
Reviewed by Simon Hausmann.
Translate coordinates correctly.
- page/Frame.cpp:
(WebCore::Frame::tiledBackingStorePaintEnd):
WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=36121
[Qt] Make WebKit scrollbars work with tiling
Reviewed by Simon Hausmann.
- Use the scrollbar overlay (implemented for accelerated compositing) when in tiled mode.
- Make overlay compile unconditionally, enable on demand. This removes bunch of unneeded ifdefs.
- Update the scroll position to the backing store as needed.
- Renamed some methods.
- Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::):
(QGraphicsWebViewPrivate::createOrDeleteOverlay):
(QGraphicsWebViewPrivate::setRootGraphicsLayer):
(QGraphicsWebViewPrivate::updateCompositingScrollPosition):
(QGraphicsWebViewPrivate::scroll):
(QGraphicsWebViewPrivate::update):
(QGraphicsWebViewPrivate::graphicsItemVisibleRect):
(QGraphicsWebView::paint):
(QGraphicsWebView::setPage):
(QGraphicsWebView::updateGeometry):
(QGraphicsWebView::setGeometry):
- Api/qwebframe.cpp:
(QWebFramePrivate::renderFromTiledBackingStore):
- Api/qwebframe_p.h:
- 9:21 AM Changeset in webkit [56067] by
-
- 2 edits in trunk/LayoutTests
2010-03-16 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: inspector http test fix that migrates it to the new inspector api.
- http/tests/inspector/inspect-iframe-from-different-domain.html:
- 9:19 AM Changeset in webkit [56066] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-16 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Remove extra <new> include and add guards to operator new/delete definitions
https://bugs.webkit.org/show_bug.cgi?id=35967
Remove extra <new> header include from FastAlloc.cpp since it is included in
FastAlloc.h. Add ENABLE(GLOBAL_FASTMALLOC_NEW) macro guard to operator
new/delete/new []/delete [] definitions.
- wtf/FastMalloc.cpp:
- 9:18 AM Changeset in webkit [56065] by
-
- 2 edits in trunk/WebCore
2010-03-16 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Eric Seidel.
[Qt] MediaPlayerPrivate: Initialize m_mediaPlayerControl to 0 to
avoid crashes when no media services can be found.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
- 9:09 AM Changeset in webkit [56064] by
-
- 2 edits in trunk/WebCore
2010-03-16 Adam Barth <abarth@webkit.org>
Unreviewed.
noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092
Add missing "!" in plugin code. Should fix plugins/embed-inside-object
on Gtk and Qt.
- plugins/PluginView.cpp: (WebCore::PluginView::load):
- 9:00 AM Changeset in webkit [56063] by
-
- 2 edits1 delete in trunk/WebCore
2010-03-16 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Delete DerivedSourcesAllInOne.cpp.
- Android.v8bindings.mk:
- bindings/v8/DerivedSourcesAllInOne.cpp: Removed.
- 8:39 AM Changeset in webkit [56062] by
-
- 2 edits in trunk/JavaScriptCore
Roll out r55889, as it breaks the Qt port on Leopard
2010-03-11 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888
Use TARGETING_TIGER rather than BUILDING_ON_TIGER to determine the tags.
- 7:35 AM Changeset in webkit [56061] by
-
- 2 edits in trunk/WebCore
2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Revert r56006 as it caused functional issues. We will work on a
testcase, and rework the fix, and land when we have this a bit
more testable.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaPlayButton):
- 7:19 AM Changeset in webkit [56060] by
-
- 2 edits in trunk/WebKit/qt
2010-03-15 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Fix crash in QWebView::setPage()
tst_qwebpage was crashing on setPage(0)
- Api/qwebview.cpp: (QWebView::setPage):
- 6:58 AM Changeset in webkit [56059] by
-
- 5 edits in trunk/WebCore
2010-03-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Errors when inspecting styles of non-renderable elements in XHTML.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._addAttribute): (WebInspector.DOMWindow.prototype.Object):
- inspector/front-end/MetricsSidebarPane.js:
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.callback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._update):
- 6:37 AM Changeset in webkit [56058] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Unreviewed.
Fix Chromium Mac build: remove unused code.
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
- 6:32 AM Changeset in webkit [56057] by
-
- 6 edits in trunk
Spatial Navigation: Add a scrollIntoView call when focusing an element.
https://bugs.webkit.org/show_bug.cgi?id=36020
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
WebCore:
When focusing an element in Spatial Navigation logic, it is desired to make
this element visible in the current viewport. For that to happen, there
could be a call to Element's scrollIntoView method at focusing time. However
for visual aspects, it is preferable to scroll to an inflated rect of |element|
in order to consider the focus outline width.
As Element's scrollIntoView method does not provide this flexibility, patch adds
a custom scrollIntoView method to SpatialNavigation.h .
- page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
- page/SpatialNavigation.cpp:
(WebCore::scrollIntoView):
- page/SpatialNavigation.h:
LayoutTests:
- platform/gtk/Skipped: Unskip snav-iframe-with-offscreen-element.html
- 5:10 AM Changeset in webkit [56056] by
-
- 2 edits in trunk/LayoutTests
2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
[GStreamer] media/video-played-collapse.html
https://bugs.webkit.org/show_bug.cgi?id=36165
Skip apparently unreliable test. It used to fail locally and pass
on the bots, but the situation is inversed now. We need to
investigate this properly.
- platform/gtk/Skipped:
- 4:57 AM Changeset in webkit [56055] by
-
- 3 edits in trunk/WebCore
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372
Normalize timeout priorities through the GStreamer media player as
a whole. This should help avoid that any of them is starved.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::muteChanged):
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp: (webkit_video_sink_render):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcNeedDataCb): (webKitWebSrcEnoughDataCb): (webKitWebSrcSeekDataCb):
- 4:45 AM Changeset in webkit [56054] by
-
- 2 edits in trunk/WebCore
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372
Use default priority also for parsing data: URIs.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startData):
- 4:44 AM Changeset in webkit [56053] by
-
- 2 edits in trunk/WebCore
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372
Normalize SharedTimers priorities to always be
G_PRIORITY_DEFAULT. As it is currently, timers that should happen
immediately (0 miliseconds delay) end up delayed by a lot of time
due to glib starving lower priority sources.
- platform/gtk/SharedTimerGtk.cpp: (WebCore::setSharedTimerFireTime):
- 4:44 AM QtWebKitBugs edited by
- Make the new bug link easier to spot on the page (diff)
- 4:36 AM QtWebKitBugs edited by
- (diff)
- 4:35 AM QtWebKitBugs edited by
- (diff)
- 4:11 AM Changeset in webkit [56052] by
-
- 4 edits in trunk
2010-03-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add support for Fast Mobile Scrolling in the build system.
- configure.ac:
WebCore:
2010-03-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add support for Fast Mobile Scrolling in the build system.
- GNUmakefile.am:
- 3:59 AM Changeset in webkit [56051] by
-
- 62 edits2 copies1 add in trunk
2010-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
- GNUmakefile.am:
- WebCore.Inspector.exp:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.order:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
- inspector/ConsoleMessage.h:
- inspector/InspectorClient.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowVisible): (WebCore::InspectorController::frontendReady): (WebCore::InspectorController::willCloseFrontend): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::setInspectorFrontendClient): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::setFrontend): (WebCore::InspectorController::show): (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger):
- inspector/InspectorController.h: (WebCore::InspectorController::hasInspectorFrontendClient):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::~InspectorFrontend): (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::bringToFront): (WebCore::InspectorFrontend::inspectedURLChanged):
- inspector/InspectorFrontend.h:
- inspector/InspectorFrontendClient.h: Added. (WebCore::InspectorFrontendClient::~InspectorFrontendClient):
- inspector/InspectorFrontendClientLocal.cpp: Added. (WebCore::FrontendMenuProvider::create): (WebCore::FrontendMenuProvider::disconnect): (WebCore::FrontendMenuProvider::FrontendMenuProvider): (WebCore::FrontendMenuProvider::~FrontendMenuProvider): (WebCore::FrontendMenuProvider::populateContextMenu): (WebCore::FrontendMenuProvider::contextMenuItemSelected): (WebCore::FrontendMenuProvider::contextMenuCleared): (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::windowObjectCleared): (WebCore::InspectorFrontendClientLocal::frontendLoaded): (WebCore::InspectorFrontendClientLocal::canAttachWindow): (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::moveWindowBy): (WebCore::InspectorFrontendClientLocal::showContextMenu): (WebCore::InspectorFrontendClientLocal::setAttachedWindow): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowHeight):
- inspector/InspectorFrontendClientLocal.h: Added.
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::loaded): (WebCore::InspectorFrontendHost::attach): (WebCore::InspectorFrontendHost::detach): (WebCore::InspectorFrontendHost::closeWindow): (WebCore::InspectorFrontendHost::bringToFront): (WebCore::InspectorFrontendHost::inspectedURLChanged): (WebCore::InspectorFrontendHost::canAttachWindow): (WebCore::InspectorFrontendHost::setAttachedWindowHeight): (WebCore::InspectorFrontendHost::moveWindowBy): (WebCore::InspectorFrontendHost::showContextMenu):
- inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::create):
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.bringToFront): (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.close): (WebInspector.bringToFront): (WebInspector.inspectedURLChanged):
- loader/EmptyClients.h: (WebCore::EmptyInspectorClient::openInspectorFrontend):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::~Page):
- page/Page.h:
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::addInspectElementItem):
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::inspectorDestroyed): (WebInspectorClient::openInspectorFrontend): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::frontendLoaded): (WebInspectorFrontendClient::localizedStringsURL): (WebInspectorFrontendClient::hiddenPanels): (WebInspectorFrontendClient::bringToFront): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::setAttachedWindowHeight): (WebInspectorFrontendClient::inspectedURLChanged): (WebInspectorFrontendClient::updateWindowTitle): (-[WebInspectorWindowController dealloc]): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController close]): (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]): (-[WebInspectorWindowController attached]): (-[WebInspectorWindowController setFrontendClient:]): (-[WebInspectorWindowController destroyInspectorView]): (-[WebNodeHighlighter initWithInspectedWebView:]): (-[WebNodeHighlighter dealloc]): (-[WebNodeHighlighter highlightNode:]): (-[WebNodeHighlighter hideHighlight]): (-[WebNodeHighlighter didAttachWebNodeHighlight:]): (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
- WebInspector/WebInspector.mm: (-attach:): (-detach:):
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::~WebInspectorClient): (WebInspectorClient::openInspectorFrontend): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorClient::updateHighlight): (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::~WebInspectorFrontendClient): (WebInspectorFrontendClient::frontendLoaded): (WebInspectorFrontendClient::localizedStringsURL): (WebInspectorFrontendClient::hiddenPanels): (WebInspectorFrontendClient::bringToFront): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::setAttachedWindowHeight): (WebInspectorFrontendClient::inspectedURLChanged): (WebInspectorFrontendClient::closeWindowWithoutNotifications): (WebInspectorFrontendClient::showWindowWithoutNotifications): (WebInspectorFrontendClient::destroyInspectorView): (WebInspectorFrontendClient::updateWindowTitle): (WebInspectorFrontendClient::onGetMinMaxInfo): (WebInspectorFrontendClient::onSize): (WebInspectorFrontendClient::onClose): (WebInspectorFrontendClient::onSetFocus): (WebInspectorFrontendClient::onWebViewWindowPosChanging): (WebInspectorWndProc): (WebInspectorFrontendClient::windowReceivedMessage):
- WebCoreSupport/WebInspectorClient.h: (WebInspectorClient::frontendClosing):
- WebInspector.cpp: (WebInspector::attach): (WebInspector::detach):
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
- Api/qwebinspector.cpp: (QWebInspector::hideEvent): (QWebInspector::closeEvent):
- Api/qwebinspector.h:
- Api/qwebpage.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt): (WebCore::InspectorFrontendClientQt::frontendLoaded): (WebCore::InspectorFrontendClientQt::localizedStringsURL): (WebCore::InspectorFrontendClientQt::hiddenPanels): (WebCore::InspectorFrontendClientQt::bringToFront): (WebCore::InspectorFrontendClientQt::closeWindow): (WebCore::InspectorFrontendClientQt::attachWindow): (WebCore::InspectorFrontendClientQt::detachWindow): (WebCore::InspectorFrontendClientQt::setAttachedWindowHeight): (WebCore::InspectorFrontendClientQt::inspectedURLChanged): (WebCore::InspectorFrontendClientQt::updateWindowTitle):
- WebCoreSupport/InspectorClientQt.h:
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::notifyWebViewDestroyed): (WebKit::InspectorClient::InspectorClient): (WebKit::InspectorClient::inspectorDestroyed): (WebKit::InspectorClient::openInspectorFrontend): (WebKit::InspectorClient::highlight): (WebKit::InspectorClient::hideHighlight): (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting): (WebKit::InspectorFrontendClient::InspectorFrontendClient): (WebKit::InspectorFrontendClient::~InspectorFrontendClient): (WebKit::InspectorFrontendClient::destroyInspectorWindow): (WebKit::InspectorFrontendClient::localizedStringsURL): (WebKit::InspectorFrontendClient::hiddenPanels): (WebKit::InspectorFrontendClient::bringToFront): (WebKit::InspectorFrontendClient::closeWindow): (WebKit::InspectorFrontendClient::attachWindow): (WebKit::InspectorFrontendClient::detachWindow): (WebKit::InspectorFrontendClient::setAttachedWindowHeight): (WebKit::InspectorFrontendClient::inspectedURLChanged):
- WebCoreSupport/InspectorClientGtk.h:
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
- src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::openInspectorFrontend):
- src/InspectorClientImpl.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad): (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy): (WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
- src/WebDevToolsAgentImpl.h:
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsBringToFront): (WebKit::WebDevToolsFrontendImpl::jsInspectedURLChanged):
- src/WebDevToolsFrontendImpl.h:
- src/js/InjectDispatch.js: (close):
- 3:17 AM Changeset in webkit [56050] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-16 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium tests fix.
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
- 2:32 AM Changeset in webkit [56049] by
-
- 19 edits in trunk
2010-03-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: migrate to native styles inspector in
order to inspect styles from foreighn domains.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getStyles): (WebCore::InspectorBackend::getInlineStyle): (WebCore::InspectorBackend::getComputedStyle): (WebCore::InspectorBackend::applyStyleText): (WebCore::InspectorBackend::setStyleText): (WebCore::InspectorBackend::setStyleProperty): (WebCore::InspectorBackend::toggleStyleEnabled): (WebCore::InspectorBackend::setRuleSelector): (WebCore::InspectorBackend::addRule):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getInlineStyle): (WebCore::InspectorDOMAgent::getComputedStyle): (WebCore::InspectorDOMAgent::getMatchedCSSRules): (WebCore::InspectorDOMAgent::getAttributeStyles): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::bindStyle): (WebCore::InspectorDOMAgent::bindRule): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForRule): (WebCore::InspectorDOMAgent::uniqueStyleProperties): (WebCore::InspectorDOMAgent::longhandProperties): (WebCore::InspectorDOMAgent::shorthandPriority): (WebCore::InspectorDOMAgent::ruleAffectsNode): (WebCore::InspectorDOMAgent::toArray):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetEventListenersForNode): (WebCore::InspectorFrontend::didGetStyles): (WebCore::InspectorFrontend::didGetComputedStyle): (WebCore::InspectorFrontend::didGetInlineStyle): (WebCore::InspectorFrontend::didApplyStyleText): (WebCore::InspectorFrontend::didSetStyleText): (WebCore::InspectorFrontend::didSetStyleProperty): (WebCore::InspectorFrontend::didToggleStyleEnabled): (WebCore::InspectorFrontend::didSetRuleSelector): (WebCore::InspectorFrontend::didAddRule):
- inspector/InspectorFrontend.h:
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):
- inspector/front-end/ElementsTreeOutline.js:
- inspector/front-end/InjectedScript.js:
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.callback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.callback): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
- 1:53 AM Changeset in webkit [56048] by
-
- 2 edits in trunk
Add WebKitTools/TestResultServer/index.yaml to gitattributes to ignore for crlf conversion.
- .gitattributes:
- 12:39 AM Changeset in webkit [56047] by
-
- 4 edits in trunk/WebCore
2010-03-16 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
RenderText::m_text should be a String, not RefPtr<StringImpl>
https://bugs.webkit.org/show_bug.cgi?id=36010
Refactoring only, so no new tests.
- platform/text/PlatformString.h: (WebCore::String::makeLower): (WebCore::String::makeUpper): (WebCore::String::makeSecure): (WebCore::String::makeCapitalized): (WebCore::String::containsOnlyASCII):
- rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::containsOnlyWhitespace): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::setText): (WebCore::RenderText::previousOffset): (WebCore::RenderText::previousOffsetForBackwardDeletion): (WebCore::RenderText::nextOffset):
- rendering/RenderText.h: (WebCore::RenderText::text): (WebCore::RenderText::characters): (WebCore::RenderText::textLength):
- 12:27 AM Changeset in webkit [56046] by
-
- 8 edits2 adds in trunk
2010-03-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092
Test that the noscript element renders when @sandbox disables
JavaScript.
- fast/frames/sandboxed-iframe-noscript-expected.txt: Added.
- fast/frames/sandboxed-iframe-noscript.html: Added.
2010-03-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092
Instead of talking to Settings directly to figure out if JavaScript is
enabled in a frame, we need to talk to the ScriptController. The
ScriptController is better at answering that question because it knows
about @sandbox.
Test: fast/frames/sandboxed-iframe-noscript.html
- dom/Document.cpp: (WebCore::Document::Document):
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createRenderer):
- html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsNeeded):
- html/HTMLParser.cpp: (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::isInline):
- plugins/PluginView.cpp: (WebCore::PluginView::load):
- 12:11 AM Changeset in webkit [56045] by
-
- 4 edits in trunk/WebKitTools
2010-03-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add "what-broke" command for debugging when the tree broke
https://bugs.webkit.org/show_bug.cgi?id=36157
This is another step towards automated sheriffing of the webkit tree.
With this logic our scripts are able to determine what revision broke the
tree. Buildbot should do this for us, but unfortunately buildbot doesn't
expose this kind of aggregate information.
- Scripts/webkitpy/buildbot.py:
- Add new Builder and Build classes (which will eventually replace the custom dictionaries previously used).
- Split out more network logic into _fetch methods which will eventually be their own class for mocking.
- Use XMLRPC to communicate with the buildbot master instead of scraping build pages.
- Scripts/webkitpy/buildbot_unittest.py:
- Test the newly added buildbot classes.
- Scripts/webkitpy/commands/queries.py:
- Add an experimental what-broke command.
- 12:08 AM Changeset in webkit [56044] by
-
- 2 edits in trunk/WebKitTools
2010-03-15 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Detect if the Windows Platform SDK is missing when building with
Visual C++ Express Edition and inform the user to download it.
- Scripts/webkitdirs.pm:
Mar 15, 2010:
- 11:42 PM Changeset in webkit [56043] by
-
- 6 edits in trunk
2010-03-15 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Notification object should expose absolute URL of icon
https://bugs.webkit.org/show_bug.cgi?id=35800
Covered by existing tests.
- notifications/Notification.cpp: (WebCore::Notification::Notification):
- notifications/Notification.h: (WebCore::Notification::iconURL):
2010-03-15 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Notification object should expose absolute URL of icon
https://bugs.webkit.org/show_bug.cgi?id=35800
- public/WebNotification.h:
- src/WebNotification.cpp: (WebKit::WebNotification::iconURL):
- 11:25 PM Changeset in webkit [56042] by
-
- 1 edit1 add in trunk/WebCore
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35887
- platform/efl/ClipboardEfl.cpp: Added.
- platform/efl/PasteboardEfl.cpp: Added.
- 10:56 PM Changeset in webkit [56041] by
-
- 4 edits6 adds in trunk
2010-03-15 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Don't submit disabled menu options.
https://bugs.webkit.org/show_bug.cgi?id=35056
- fast/forms/menulist-disabled-selected-option-expected.txt: Added.
- fast/forms/menulist-disabled-selected-option.html: Added.
- fast/forms/menulist-submit-without-selection-expected.txt: Added.
- fast/forms/menulist-submit-without-selection.html: Added.
- fast/forms/script-tests/menulist-disabled-selected-option.js: Added.
- fast/forms/script-tests/menulist-submit-without-selection.js: Added.
2010-03-15 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Don't submit disabled menu options.
https://bugs.webkit.org/show_bug.cgi?id=35056
Test: fast/forms/menulist-disabled-selected-option.html
- dom/OptionElement.h:
- dom/SelectElement.cpp: (WebCore::SelectElement::appendFormData): If a selected option is disabled, skip it. Remove code for non-selected menulist because of compatibility with other browsers.
- 10:55 PM Changeset in webkit [56040] by
-
- 7 edits in trunk/WebKitTools
2010-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Let commit-queue land rollout patches even when the tree is red
https://bugs.webkit.org/show_bug.cgi?id=36155
Now the commit-queue will land patches whose name begins with "ROLLOUT "
even if the tree is red. The patches still go through the usual build
and test process, but they can be landed while the tree is on fire.
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- Scripts/webkitpy/commands/queuestest.py:
- Scripts/webkitpy/mock_bugzillatool.py:
- 10:50 PM Changeset in webkit [56039] by
-
- 1 edit1 add in trunk/WebCore
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35884
- platform/efl/FileSystemEfl.cpp: Added.
- 10:33 PM Changeset in webkit [56038] by
-
- 1 edit1 add in trunk/WebCore
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35882
- platform/efl/ContextMenuItemEfl.cpp: Added.
- 10:32 PM Changeset in webkit [56037] by
-
- 2 edits in trunk/WebKitSite
Tweak canvas perf demo.
- demos/canvas-perf/canvas.html:
- 10:15 PM Changeset in webkit [56036] by
-
- 4 edits in trunk
2010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=35502
[Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText
Simple change to stop tables from implementing AtkText.
- accessibility/gtk/AccessibilityObjectAtk.cpp: (getInterfaceMaskFromObject):
2010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=35502
[Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText
New test to be sure we do not accidentally implement AtkText for tables
- tests/testatk.c (testWebkitAtkGetTextInTable): (main):
- 9:58 PM Changeset in webkit [56035] by
-
- 6 edits in trunk
2010-03-15 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Adam Barth.
According to the updated specification, a data field should always
result in a newline character being appended to the data buffer
regardless if the data buffer contains any data or not. However, upon
event dispatch, the last newline will be removed. This differs from an
older version of the specification where a newline character was
appended before the data value only if the buffer already contained
data. As a result, EventSource now supports receiving events with empty
data or newline characters only. Updated test accordingly.
https://bugs.webkit.org/show_bug.cgi?id=33210
- http/tests/eventsource/eventsource-parse-event-stream-expected.txt:
- http/tests/eventsource/eventsource-parse-event-stream.html:
- http/tests/eventsource/resources/event-stream.php:
2010-03-15 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Adam Barth.
According to the updated specification, a data field should always
result in a newline character being appended to the data buffer
regardless if the data buffer contains any data or not. However, upon
event dispatch, the last newline will be removed. This differs from an
older version of the specification where a newline character was
appended before the data value only if the buffer already contained
data. As a result, EventSource now supports receiving events with empty
data or newline characters only.
https://bugs.webkit.org/show_bug.cgi?id=33210
- page/EventSource.cpp: (WebCore::EventSource::parseEventStreamLine):
- 9:43 PM Changeset in webkit [56034] by
-
- 4 edits1 add in trunk/WebKitTools
2010-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add webkit-patch post-rollout to upload rollouts to bugs.webkit.org for easy committing
https://bugs.webkit.org/show_bug.cgi?id=36154
This new command is a mashup of prepare-rollout and post. This command
will be used by an experimental bot to post rollouts of patches that
break things to bugs.webkit.org where they can be landed with the
greatest of ease.
- Scripts/webkitpy/commands/download.py:
- Scripts/webkitpy/commands/download_unittest.py:
- Scripts/webkitpy/steps/init.py:
- Scripts/webkitpy/steps/postdiffforrevert.py: Added.
- 9:41 PM Changeset in webkit [56033] by
-
- 3 edits2 adds in trunk
2010-03-15 Valters Svabe <vsvabe@gmail.com>
Reviewed by Darin Adler.
:after selector displays in wrong place with nested div
https://bugs.webkit.org/show_bug.cgi?id=32288
- fast/css-generated-content/block-after-expected.txt: Added.
- fast/css-generated-content/block-after.html: Added.
2010-03-15 Valters Svabe <vsvabe@gmail.com>
Reviewed by Darin Adler.
:after selector displays in wrong place with nested div
https://bugs.webkit.org/show_bug.cgi?id=32288
Make sure we don't append things after :after-generated content, if
it's inside an anonymous block.
Test: fast/css-generated-content/block-after.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChild):
- 9:15 PM Changeset in webkit [56032] by
-
- 2 edits in trunk/WebKitTools
2010-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch rollout should error out on conflicts
https://bugs.webkit.org/show_bug.cgi?id=36151
Instead of blindingly plowing ahead, we now throw an exception if there
are conflicts after applying a reverse diff.
- Scripts/webkitpy/scm.py:
- 9:07 PM Changeset in webkit [56031] by
-
- 1 edit1 add in trunk/JavaScriptCore
2010-03-15 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add a function to create a BREW instance without local variable declarations.
https://bugs.webkit.org/show_bug.cgi?id=34705
Add a template function to create a BREW instance in one line.
- wtf/brew/ShellBrew.h: Added. (WTF::createInstance):
- 8:27 PM Changeset in webkit [56030] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-15 Darin Fisher <darin@chromium.org>
Fix build bustage. We also need to pull down "third_party/tcmalloc"
- DEPS:
- 7:36 PM Changeset in webkit [56029] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed.
Removed a now-incorrect comment I forgot to remove in my last check-in.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavenge):
- 7:21 PM Changeset in webkit [56028] by
-
- 2 edits in trunk/JavaScriptCore
Fixed a portion of:
<rdar://problem/7165917> | https://bugs.webkit.org/show_bug.cgi?id=28676
Safari 4 does not release memory back to the operating system fast enough (28676)
Reviewed by Sam Weinig.
Every few seconds, release a percentage of the minimum unused page count
during that time period.
SunSpider reports no change, command-line or in-browser, Mac or Windows.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMalloc_PageHeap::initializeScavenger): Renamed shouldContinueScavenging
to shouldScavenge, since scavenging is no longer something that we interrupt.
(WTF::TCMalloc_PageHeap::scavenge): The new scavenging algorithm. Fixes
a bug where the old code would release only one item from each size class
per scavenge, potentially leaving large numbers of large-sized objects
unreleased for a long time.
(WTF::TCMalloc_PageHeap::shouldScavenge):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::GrowHeap):
(WTF::TCMalloc_PageHeap::scavengerThread):
(WTF::TCMalloc_PageHeap::periodicScavenge): Updated to track the minimum
value of free_committed_pages_ during a given scavenge period.
- 5:06 PM Changeset in webkit [56027] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-15 Darin Fisher <darin@chromium.org>
Fix build bustage. We also need to pull down "gfx"
- DEPS:
- 4:54 PM Changeset in webkit [56026] by
-
- 4 edits in trunk
WebKitTools: Unreviewed layout test fix.
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
GTK needs to implement press for this test to work.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::press):
LayoutTests: Unreviewed.
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
GTK needs to implement press in DRT before this test can work.
- platform/gtk/Skipped:
- 4:28 PM Changeset in webkit [56025] by
-
- 4 edits in trunk
Unreviewed layout test fix.
WebKitTools:
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
Windows needs to implement press in DRT.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::press):
LayoutTests:
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
This test must be skipped until https://bugs.webkit.org/show_bug.cgi?id=36145 is done.
- platform/win/Skipped:
- 4:28 PM Changeset in webkit [56024] by
-
- 5 edits in trunk/WebKit/chromium
2010-03-15 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=36131
Update include paths for chromium Rect, Point, and Size types.
Update DEPS to pull latest chromium code that reflects the
new location of these headers.
- DEPS:
- public/WebPoint.h:
- public/WebRect.h:
- public/WebSize.h:
- 4:20 PM Changeset in webkit [56023] by
-
- 1 edit1 add in trunk/WebCore
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Eric Seidel.
Add EFL port files to platform/efl.
http://webkit.org/b/35885
- platform/efl/KURLEfl.cpp: Added.
- 4:06 PM Changeset in webkit [56022] by
-
- 3 edits in trunk/WebKitTools
Unreviewed. Fix break of layout tests on win and gtk.
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
Attempting to implement press action for windows and gtk.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::press):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::press):
- 3:59 PM Changeset in webkit [56021] by
-
- 3 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=35843
Re-land reverted fix to JSString::getIndex()
Reviewed by Sam Weinig.
Calling getIndex() on a JSString in rope form may result in a JSException being thrown
if there is insuficient memory so value(exec) returns UString() with length zero,
which will be passed to jsSingleCharacterSubstring.
Add a slow case function to trap the error & return a safe null value, until the
exception is handled.
- runtime/JSString.cpp:
(JSC::JSString::getIndexSlowCase):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):
- 3:38 PM Changeset in webkit [56020] by
-
- 6 edits in trunk/WebKitTools
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
Reviewed by Beth Dakin.
- DumpRenderTree/AccessibilityUIElement.cpp:
(pressCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::press):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::press):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::press):
- 3:07 PM Changeset in webkit [56019] by
-
- 3 edits2 adds in trunk
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
Reviewed by Beth Dakin.
WebCore:
When a label element is used as a click event handler, and it doesn't have any
corresponding control, it should handle the action itself.
Test: accessibility/label-element-press.html
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::accessKeyAction):
LayoutTests:
- accessibility/label-element-press-expected.txt: Added.
- accessibility/label-element-press.html: Added.
- 2:56 PM Changeset in webkit [56018] by
-
- 2 edits in trunk/WebCore
2010-03-15 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 36135 - GCController::garbageCollectNow() crashes when called from garbage collection
<https://bugs.webkit.org/show_bug.cgi?id=36135>
<rdar://problem/7752552>
- bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectNow): Fail silently if garbage collection is
active rather than hitting the CRASH() reentrancy guard.
- 2:47 PM Changeset in webkit [56017] by
-
- 2 edits in trunk/WebCore
2010-03-15 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Drop out of compositing mode when no elements need to composite
https://bugs.webkit.org/show_bug.cgi?id=36134
When no more elements on the page need to be composited, drop out of compositing
mode altogether, including removing the layer-backed view that hosts the layers.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): If the list of child layers to attach at the root is empty, we have no composited layers, and can drop out of compositing mode by calling willMoveOffscreen().
(WebCore::RenderLayerCompositor::computeCompositingRequirements): In several places,
use willBeComposited rather than calling needsToBeComposited(), because it avoids
recomputing state that we know already (but assert that we're getting it right).
When we're assessing the root layer in post-order, see if we have any child layers that
are compositing, and also whether the root itself needs to composite. If neither are
true, then we can drop out of compositing mode.
(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Move the
"inCompositingMode() && layer->isRootLayer()" test out of requiresCompositingLayer()
and into needsToBeComposited() so that we can call requiresCompositingLayer() separately
on the root layer above.
- 2:33 PM Changeset in webkit [56016] by
-
- 1 edit1 add in trunk/WebCore
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35888
- platform/efl/SoundEfl.cpp: Added.
- 2:21 PM Changeset in webkit [56015] by
-
- 2 edits in trunk/JavaScriptCore
Add a long long version of abs() for MSVC.
Reviewed by Adam Roben.
- wtf/MathExtras.h:
(abs):
- 2:02 PM Changeset in webkit [56014] by
-
- 2 edits in trunk/WebKitTools
Add a new build slave to replace the existing SnowLeopard Leaks build slave which
appears to be suffering a slow and painful death at the hands of its graphics hardware.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 2:01 PM Changeset in webkit [56013] by
-
- 19 edits2 adds in trunk/LayoutTests
2010-03-15 Simon Fraser <Simon Fraser>
Rubber-stamped by Dan Bernstein.
Update some pixel results for composting tests; some were incorrect, and others had minor
pixel differences.
- platform/mac/compositing/color-matching/image-color-matching-expected.checksum:
- platform/mac/compositing/color-matching/image-color-matching-expected.png:
- platform/mac/compositing/direct-image-compositing-expected.checksum:
- platform/mac/compositing/direct-image-compositing-expected.png:
- platform/mac/compositing/overflow/overflow-scroll-expected.checksum:
- platform/mac/compositing/overflow/overflow-scroll-expected.png:
- platform/mac/compositing/reflections/animation-inside-reflection-expected.checksum:
- platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
- platform/mac/compositing/reflections/load-video-in-reflection-expected.checksum:
- platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
- platform/mac/compositing/reflections/nested-reflection-animated-expected.checksum:
- platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
- platform/mac/compositing/reflections/nested-reflection-transition-expected.checksum:
- platform/mac/compositing/reflections/nested-reflection-transition-expected.png:
- platform/mac/compositing/reflections/reflection-on-composited-expected.checksum:
- platform/mac/compositing/reflections/reflection-on-composited-expected.png:
- platform/mac/compositing/repaint/become-overlay-composited-layer-expected.checksum: Added.
- platform/mac/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
- platform/mac/compositing/repaint/layer-repaint-rects-expected.checksum:
- platform/mac/compositing/repaint/layer-repaint-rects-expected.png:
- 1:31 PM Changeset in webkit [56012] by
-
- 18 edits4 adds in trunk
WebCore: For continuous scrolling devices on the Mac (trackpads and Mighty/Magic
Mice), set the number of wheel ticks equal to the atomic increment of
the device: a pixel. This ensures that any scrolling action will
generate at least one wheel tick, regardless of the speed/length of
the gesture.
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>
Tests: fast/events/continuous-platform-wheelevent-in-scrolling-div.html
fast/events/platform-wheelevent-in-scrolling-div.html
- platform/mac/WebCoreSystemInterface.h: Modify method signature.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
- platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Call into
WebKitSystemInterface to determine both wheelTicksX/Y and deltaX/Y.
WKSI will query the event system for number of wheel ticks and
pixels/lines scrolled based on the device type.
WebKit/mac: Updated call to WKGetWheelEventDeltas() to match new method signature.
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]):
WebKitLibraries: Added two new output arguments to WKGetWheelEventDeltas() to return
the number of scroll wheel ticks in the x and y directions.
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=29601.
<rdar://problem/7453254>
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
LayoutTests: These tests verify that scrollwheel events (both continuous and
non-continuous) generate the expected pixel deltas in scrollable
regions, and also generate DOM mousewheel events with expected
wheelDelta values.
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>
- fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Added.
- fast/events/continuous-platform-wheelevent-in-scrolling-div.html: Added.
- fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.
- fast/events/platform-wheelevent-in-scrolling-div.html: Added.
- fast/events/wheelevent-in-scrolling-div-expected.txt: Rebased
expected results due to change in test output formatting.
- fast/events/wheelevent-in-scrolling-div.html: Modified to use common
js logging and assertion functions.
- platform/gtk/Skipped: DRT support needed by tests not yet implemented
in GTK port. See https://bugs.webkit.org/show_bug.cgi?id=36003.
- platform/mac-tiger/Skipped: DRT support needed by tests not possible
to implement in Tiger.
- platform/qt/Skipped: DRT support for tests not yet implemented in Qt
port. See https://bugs.webkit.org/show_bug.cgi?id=36004.
- platform/win/Skipped: DRT support for tests not yet implemented in
Windows port. See https://bugs.webkit.org/show_bug.cgi?id=36002.
- 1:30 PM Changeset in webkit [56011] by
-
- 3 edits in trunk/WebKit/chromium
2010-03-15 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
https://bugs.webkit.org/show_bug.cgi?id=36012
- public/GeolocationServiceBridgeChromium.h:
- src/GeolocationServiceBridgeChromium.cpp: (WebKit::GeolocationServiceBridgeImpl::startUpdating):
- 1:18 PM Changeset in webkit [56010] by
-
- 3 edits in trunk/WebCore
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] duration query optimizations
https://bugs.webkit.org/show_bug.cgi?id=36116
Don't reattempt duration queries that previously failed and cache
media duration only if it's known.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::durationChanged):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 1:11 PM Changeset in webkit [56009] by
-
- 3 edits in trunk/WebCore
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] updateStates called for all elements posting a state-change
https://bugs.webkit.org/show_bug.cgi?id=36115
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): Update player state only for state-change messages coming from playbin2 directly.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: (WebCore::MediaPlayerPrivate::pipeline): public accessor for the playbin element.
- 1:10 PM Changeset in webkit [56008] by
-
- 5 edits in trunk/WebKit/mac
-[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling
<https://bugs.webkit.org/show_bug.cgi?id=36125>
Reviewed by Adam Roben.
- WebView/WebDynamicScrollBarsView.h:
Added instance variables horizontalScrollingAllowedButScrollerHidden and
verticalScrollingAllowedButScrollerHidden. Renamed instance variables
hideHorizontal/VerticalScroller to alwaysHideHorizontal/VerticalScroller for clarity.
Declared methods -horizontalScrollingAllowed and -verticalScrollingAllowed.
Added comments.
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
Updated for instance variable renaming.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
Ditto.
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
New method, returns YES if the scroller is showing or the only reason that the scroller
is not showing is that setAlwaysHideHorizontalScrolling has been called.
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
New method, returns YES if the scroller is showing or the only reason that the scroller
is not showing is that setAlwaysHideVerticalScrolling has been called.
(-[WebDynamicScrollBarsView updateScrollers]):
Updated for instance variable renamings. Now updates horizontalScrollingAllowedButScrollerHidden
and verticalScrollingAllowedButScrollerHidden. Now takes the always-hidden state into account
in the early-return code path, to avoid taking it into account twice in the regular code path.
- WebView/WebFrameView.mm:
(-[WebFrameView _scrollToBeginningOfDocument]):
Use _isScrollable instead of _hasScrollBars.
(-[WebFrameView _scrollToEndOfDocument]):
Ditto.
(-[WebFrameView scrollToBeginningOfDocument:]):
Use _largestScrollableChild instead of _largestChildWithScrollBars.
(-[WebFrameView scrollToEndOfDocument:]):
Ditto.
(-[WebFrameView _pageVertically:]):
Use _isScrollable and _largestScrollableChild instead of _hasScrollBars
and _largestChildWithScrollBars.
(-[WebFrameView _pageHorizontally:]):
Ditto.
(-[WebFrameView _scrollLineVertically:]):
Ditto.
(-[WebFrameView _scrollLineHorizontally:]):
Ditto.
(-[WebFrameView keyDown:]):
Use _largestScrollableChild instead of _largestChildWithScrollBars.
(-[WebFrameView _isScrollable]):
New method, calls -[WebDynamicScrollBarsView horizontalScrollingAllowed] and
-[WebDynamicScrollBarsView verticalScrollingAllowed]
(-[WebFrameView _largestScrollableChild]):
New method, like _largestChildWithScrollBars but uses _isScrollable.
(-[WebFrameView _hasScrollBars]):
Added a comment that this is no longer used by Safari, and can thus probably be
deleted once we no longer want to support it for nightly build compatibility with
old versions of Safari.
(-[WebFrameView _largestChildWithScrollBars]):
Ditto.
- WebView/WebFrameViewPrivate.h:
Declared -_isScrollable and -_largestScrollableChild. Added comments to
_hasScrollBars and _largestChildWithScrollBars saying that they are no longer
used by Safari, and can thus probably be deleted once we no longer want to
support them for nightly build compatibility with old versions of Safari.
- 1:08 PM Changeset in webkit [56007] by
-
- 10 edits in trunk/WebCore
Clean up more bits of the open-source image decoders. In addition to
simplifying things somewhat, this makes all the decoders the same in
terms of how they construct "image reader" subclasses and init scale
data.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36040
No functional change, so no tests.
- platform/image-decoders/ImageDecoder.h: Reorder a few declarations to try and group/order members slightly better.
(WebCore::ImageDecoder::ImageDecoder):
- platform/image-decoders/gif/GIFImageDecoder.cpp: Move reader construction into decode(). Prep scale data in setSize(). Remove useless comment.
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::setSize):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::decode):
- platform/image-decoders/gif/GIFImageDecoder.h: Prep scale data in setSize().
- platform/image-decoders/gif/GIFImageReader.cpp: Prep scale data in setSize().
(GIFImageReader::read):
- platform/image-decoders/ico/ICOImageDecoder.cpp: Shorten code.
(WebCore::ICOImageDecoder::setSize):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Fix style. Move reader construction into decode().
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/jpeg/JPEGImageDecoder.h: Move reader construction into decode().
(WebCore::JPEGImageDecoder::filenameExtension):
- platform/image-decoders/png/PNGImageDecoder.cpp: Move reader construction into decode(). Track completion on decoder, not reader. Prep scale data in setSize(). Remove useless comment.
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::setSize):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):
- platform/image-decoders/png/PNGImageDecoder.h: Move reader construction into decode(). Track completion on decoder, not reader. Prep scale data in setSize().
(WebCore::PNGImageDecoder::filenameExtension):
(WebCore::PNGImageDecoder::isComplete):
- 1:00 PM Changeset in webkit [56006] by
-
- 2 edits in trunk/WebCore
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] video playback position query flood when mouse over the video element
https://bugs.webkit.org/show_bug.cgi?id=35333
Don't trigger a position query only to know which play/pause
button to display.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaPlayButton):
- 12:57 PM Changeset in webkit [56005] by
-
- 2 edits in trunk/WebKitTools
2010-03-15 Dirk Pranke <dpranke@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix a minor case where we'd deference a null pointer if we tried
to run new-run-webkit-tests on an unsupported platform (e.g.
Cygwin's python version).
- Scripts/webkitpy/layout_tests/port/factory.py:
- 10:27 AM Changeset in webkit [56004] by
-
- 5 edits1 add in trunk/WebCore
[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026
Reviewed by Nate Chapin.
Test: http/tests/local/send-form-data.html
- Android.v8bindings.mk:
- WebCore.gypi:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
- 10:27 AM Changeset in webkit [56003] by
-
- 29 edits6 adds in trunk
WebCore: Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024
Reviewed by Sam Weinig.
The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata
Test: http/tests/local/send-form-data.html
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.jscbindings.mk:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMFormDataCustom.cpp: Added.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
- bindings/scripts/CodeGeneratorJS.pm:
- html/DOMFormData.idl: Added.
- page/DOMWindow.idl:
LayoutTests: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024
Reviewed by Sam Weinig.
Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- http/tests/local/resources/send-form-data.js: Added.
- http/tests/local/send-form-data-expected.txt: Added.
- http/tests/local/send-form-data.html: Added.
- http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/qt/Skipped:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/win/Skipped:
- 10:14 AM Changeset in webkit [56002] by
-
- 14 edits in trunk
2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
Revised test of storage/databases in sandboxed iframes.
Verify that SECURITY_ERR is raised on access to
window.localStorage or window.openDatabase(). Also verify that
window.sessionStorage is now allowed in sandboxed iframes.
WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:
- http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
- http://dev.w3.org/html5/webdatabase/ (section 4.1)
- http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html
- fast/frames/resources/sandboxed-iframe-storage-disallowed.html: expect exceptions, not null
- fast/frames/sandboxed-iframe-storage-expected.txt: expect exceptions, not null
2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
Revise iframe sandbox behavior to match the updated HTML5 spec.
- Enables window.sessionStorage in sandboxed iframes.
- Raises SECURITY_ERR exceptions when window.localStorage or window.openDatabase() is blocked by iframe sandboxing.
Note: window.sessionStorage does not raise exceptions.
WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:
http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
http://dev.w3.org/html5/webdatabase/ (section 4.1)
http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html
- inspector/InspectorController.cpp: (WebCore::InspectorController::selectDOMStorage): exception handling
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent): exception handling
- page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): re-enabled in iframe sandbox (WebCore::DOMWindow::localStorage): raise exception rather than return null (WebCore::DOMWindow::openDatabase): raise exception rather than return null
- page/DOMWindow.h: added exceptions to interface
- page/DOMWindow.idl: added exceptions to interface
- page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessLocalStorage): renamed function to reflect its purpose
- storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch): exception handling
2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
Revise iframe sandbox behavior to match the updated HTML5 spec.
- Enables window.sessionStorage in sandboxed iframes.
- Raises SECURITY_ERR exceptions when window.localStorage or window.openDatabase() is blocked by iframe sandboxing.
Note: window.sessionStorage does not raise exceptions.
WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:
http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
http://dev.w3.org/html5/webdatabase/ (section 4.1)
http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html
- src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent): exception handling
- src/StorageEventDispatcherImpl.cpp: (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent): exception handling
- 9:41 AM Changeset in webkit [56001] by
-
- 3 edits in trunk/WebKitTools
Tell Subversion about more directories that expect to have .pyc files.
- Scripts/webkitpy/layout_tests: Added property svn:ignore.
- Scripts/webkitpy/layout_tests/port: Added property svn:ignore.
- 9:33 AM Changeset in webkit [56000] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-15 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Combine ctiTrampolines on ARM and Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=36014
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- 9:22 AM Changeset in webkit [55999] by
-
- 9 edits1 add in trunk/WebCore
2010-03-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement a progress indicator in the Audits panel
when resources are reloading
https://bugs.webkit.org/show_bug.cgi?id=35971
- English.lproj/localizedStrings.js:
- GNUmakefile.am:
- WebCore.gypi:
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype.get totalResources): (WebInspector.AuditLauncherView.prototype.set totalResources): (WebInspector.AuditLauncherView.prototype.get loadedResources): (WebInspector.AuditLauncherView.prototype.set loadedResources): (WebInspector.AuditLauncherView.prototype._resetResourceCount): (WebInspector.AuditLauncherView.prototype.resourceStarted): (WebInspector.AuditLauncherView.prototype.resourceFinished): (WebInspector.AuditLauncherView.prototype.reset): (WebInspector.AuditLauncherView.prototype._setAuditRunning): (WebInspector.AuditLauncherView.prototype._launchButtonClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI): (WebInspector.AuditLauncherView.prototype._updateResourceProgress): (WebInspector.AuditLauncherView.prototype._updateButton):
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype.resourceStarted): (WebInspector.AuditsPanel.prototype.resourceFinished): (WebInspector.AuditsPanel.prototype.reset):
- inspector/front-end/Images/spinner.gif: Added.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/audits.css: (.audit-launcher-view .resource-progress > img):
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 8:55 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:54 AM Changeset in webkit [55998] by
-
- 4 edits in trunk
2010-03-15 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
option-pageup/down should move cursor on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=36108
Remove waitUntilDone/notifyDone from the layout test, it's not needed
and causes timeouts on failure.
- editing/input/option-page-up-down.html:
2010-03-15 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
option-pageup/down should move cursor on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=36108
- src/EditorClientImpl.cpp: (WebKit::):
- 8:40 AM Changeset in webkit [55997] by
-
- 5 edits in trunk/WebKit/mac
Method name and parameter name mistakes from recent SPI addition
<https://bugs.webkit.org/show_bug.cgi?id=36119>
Reviewed by Dan Bernstein.
- WebView/WebDynamicScrollBarsView.h:
Renamed instance variable and method name from "setAllowXXX" to "setAllowsXXX".
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
Updated for renamed instance variable and method.
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
Changed parameter name from shouldBeVisible to shouldBeHidden.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
Ditto.
(-[WebDynamicScrollBarsView contentViewFrame]):
Updated for renamed instance variable.
(-[WebDynamicScrollBarsView tile]):
Ditto.
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
Ditto.
- WebView/WebFrame.mm:
(-[WebFrame setAllowsScrollersToOverlapContent:]):
Renamed method from setAllowXXX, and updated for same change in WebDynamicScrollBarsView.
- WebView/WebFramePrivate.h:
Renamed method name from "setAllowXXX" to "setAllowsXXX".
- 8:34 AM Changeset in webkit [55996] by
-
- 3 edits in trunk/WebCore
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] replace g_idle_add / g_timeout_add calls with Timers in the gstreamer player
https://bugs.webkit.org/show_bug.cgi?id=35735
Replaced g_idle_add calls with Timers immediately started once
only. The g_timeout_add was replaced by a periodic Timer.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedTimerFired): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::muteChangedTimerFired): (WebCore::MediaPlayerPrivate::muteChanged):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 8:20 AM Changeset in webkit [55995] by
-
- 5 edits in trunk
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Carlson.
media/video-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=35793
Only effectively load, and start buffering when playing, or when
the preload attribute is set.
Test: media/video-preload.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::commitLoad): (WebCore::MediaPlayerPrivate::prepareToPlay): (WebCore::MediaPlayerPrivate::setPreload):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 7:46 AM Changeset in webkit [55994] by
-
- 2 edits in trunk/WebKit/qt
2010-03-15 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
[Qt] Build fix if TILED_BACKING_STORE is disabled.
- Api/qwebframe.cpp: (QWebFramePrivate::renderContentsLayerAbsoluteCoords):
- 7:34 AM Changeset in webkit [55993] by
-
- 5 edits2 adds in trunk
2010-03-15 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Holger Freyther.
[Qt] Change and add expected results after the fix and also remove the test from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=36060
- platform/qt/Skipped:
- platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.checksum: Added.
- platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
- platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.txt:
2010-03-15 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Holger Freyther.
[Qt] The behavior of QGradient with no stops is defined differently from HTML5 spec,
where the latter requires the gradient to be transparent black. Explicitly added a
transparent black color stop to match the HTML5 behavior.
https://bugs.webkit.org/show_bug.cgi?id=36060
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
- 7:13 AM Changeset in webkit [55992] by
-
- 2 edits in trunk/WebCore
Some minor code clean ups in SpatialNavigation.cpp
Rubber-stamped by Holger Freyther.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- page/SpatialNavigation.cpp:
(WebCore::distanceInDirection):
(WebCore::deflateIfOverlapped):
- 6:02 AM Changeset in webkit [55991] by
-
- 2 edits in trunk/WebCore
2010-03-13 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Position of GraphBar elements is calculating more carefully
and they fully visible at the bottom of Timeline panel.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelineRecordGraphRow.prototype.update):
- 2:10 AM Changeset in webkit [55990] by
-
- 6 edits in trunk
2010-03-15 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
Selection.modify extends too far with 'lineboundary'.
https://bugs.webkit.org/show_bug.cgi?id=33413
- editing/selection/extend-selection-expected.txt:
- platform/win/editing/selection/extend-selection-expected.txt: Updated result to correct expectation that described the wrong behaviour for the selection expansion with 'lineboundary' granularity.
2010-03-15 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
Selection.modify extends too far with 'lineboundary'.
https://bugs.webkit.org/show_bug.cgi?id=33413
Selection.modify() with 'lineboundary' granularity implies just
"Go to the end of the line", unlike selection expansion with
other type of granularities. This change handled LineGranularity
as special case, to look-up end of line with UPSTREAM affinity.
Doing this prevents look-up algorithm to go next line.
Test: editing/selection/extend-selection-expected.txt
- dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Handled an edge case for node look-up with UPSTREAM.
- editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): Added UPSTREAM tweak for the case for LineGranularity.
- 1:34 AM Changeset in webkit [55989] by
-
- 2 edits in trunk/WebKit/gtk
2010-03-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Holger Freyther.
[GTK] GTK_WIDGET_IS_SENSITIVE is deprecated in GTK+ 2.20
https://bugs.webkit.org/show_bug.cgi?id=35909
- webkit/webkitwebview.cpp: GTK_WIDGET_IS_SENSITIVE has been deprecated in gtk 2.20. Use gtk_widget_is_sensitive when available.
- 1:33 AM Changeset in webkit [55988] by
-
- 6 edits5 adds in trunk
2010-03-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Always call PrintContext.end() from PrintContext::pageNumberForElement().
Without this change, WebKit remains in printing mode after determining the page number if the specified element is found.
- platform/gtk/Skipped:
- platform/mac/printing/return-from-printing-mode-expected.checksum: Added.
- platform/mac/printing/return-from-printing-mode-expected.png: Added.
- platform/mac/printing/return-from-printing-mode-expected.txt: Added.
- platform/qt/Skipped:
- platform/win/Skipped:
- printing/return-from-printing-mode.html: Added.
2010-03-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Always call PrintContext.end() from PrintContext::pageNumberForElement().
Without this change, WebKit remains in printing mode after determining the page number if the specified element is found.
Test: printing/return-from-printing-mode.html
- page/PrintContext.cpp: (WebCore::PrintContext::pageNumberForElement):
- 1:19 AM Changeset in webkit [55987] by
-
- 2 edits in trunk/WebCore
2010-03-11 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] progressTimer never stopped after EOS
https://bugs.webkit.org/show_bug.cgi?id=36007
Mark the pipeline as paused only if playback hasn't ended
yet. When didEnd() is triggered, the pipeline is paused (but
paused() still returns false) and a timeupdate event is fired,
those 2 conditions allow the HTMLMediaElement to stop the
progressTimer (in updatePlayerState, via mediaPlayerTimeChanged).
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::updateStates):
- 12:28 AM Changeset in webkit [55986] by
-
- 1 edit5 adds in trunk/WebKitTools
2010-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Operational scripts from running the EWS
https://bugs.webkit.org/show_bug.cgi?id=36097
These are the scripts I use to manage the EWS on EC2. If someone other
than me wants to run the EWS, these scripts might be helpful.
- EWSTools/boot.sh: Added.
- EWSTools/create-webkit-git: Added.
- EWSTools/screen-config: Added.
- EWSTools/start-queue.sh: Added.
- 12:04 AM Changeset in webkit [55985] by
-
- 2 edits in trunk/WebKit/mac
2010-03-14 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Remove unneeded dependency on non-string identifier for an NSTableColumn
https://bugs.webkit.org/show_bug.cgi?id=36106
- WebView/WebTextCompletionController.mm: (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier: because the table has only one column and that column does not need an identifier.
Mar 14, 2010:
Mar 13, 2010:
- 11:19 PM Changeset in webkit [55984] by
-
- 1 edit3 adds in trunk/WebKitSite
Added canvas perf demo for whatwg.
- demos/canvas-perf: Added.
- demos/canvas-perf/canvas.html: Added.
- demos/canvas-perf/kraken.jpg: Added.
- 11:16 PM Changeset in webkit [55983] by
-
- 3 edits in trunk/WebKitTools
2010-03-14 Adam Barth <abarth@webkit.org>
Unreviewed.
Fix the webkit-patch bots. Turns out they need the path of the main
script to run properly.
- Scripts/webkit-patch:
- Scripts/webkitpy/patch/patcher.py:
- 10:58 PM Changeset in webkit [55982] by
-
- 5 edits in trunk/WebKitTools
Tell Subversion about more directories that expect to have .pyc files.
- Scripts/webkitpy/init: Added property svn:ignore.
- Scripts/webkitpy/patch: Added property svn:ignore.
- Scripts/webkitpy/thirdparty: Added property svn:ignore.
- Scripts/webkitpy/thirdparty/autoinstalled: Added property svn:ignore.
- 6:28 PM Changeset in webkit [55981] by
-
- 5 edits in trunk
2010-03-14 Chang Shu <chang.shu@nokia.com>
Reviewed by Simon Hausmann.
[Qt] [Symbian] Added block for ENABLE_SYMBIAN_DIALOG_PROVIDERS
on Symbian platform.
https://bugs.webkit.org/show_bug.cgi?id=35919
- WebCore.pro:
2010-03-14 Chang Shu <chang.shu@nokia.com>
Reviewed by Simon Hausmann.
[Qt] [Symbian] Use Symbian native dialog providers for combo pupups.
https://bugs.webkit.org/show_bug.cgi?id=35919
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::ResetAndDestroy): (WebCore::QtFallbackWebPopup::showS60BrowserDialog):
- WebCoreSupport/QtFallbackWebPopup.h:
- 6:00 PM Changeset in webkit [55980] by
-
- 28 edits16 adds in trunk
Support for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=35937
Reviewed by Darin Adler.
WebCore:
Added support for HTMLProgressElement.
This implementation is enabled only for Qt, because only RenderThemeQt
was modified to actually draw the progress element.
The labels attribute of the progress element will be implemented in a
separate patch.
Tests: fast/dom/HTMLProgressElement/progress-element.html
fast/dom/HTMLProgressElement/set-progress-properties.html
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
- css/CSSValueKeywords.in:
- css/html.css:
- html/HTMLElement.cpp:
(WebCore::inlineTagList):
- html/HTMLElementsAllInOne.cpp:
- html/HTMLFormControlElement.cpp:
- html/HTMLFormControlElement.h:
- html/HTMLProgressElement.cpp: Added.
- html/HTMLProgressElement.h: Added.
- html/HTMLProgressElement.idl: Added.
- html/HTMLTagNames.in:
- page/DOMWindow.idl:
- platform/ThemeTypes.h:
- platform/qt/RenderThemeQt.cpp:
- platform/qt/RenderThemeQt.h:
- rendering/RenderObject.h:
- rendering/RenderProgress.cpp: Added.
- rendering/RenderProgress.h: Added.
- rendering/RenderTheme.cpp:
- rendering/RenderTheme.h:
LayoutTests:
- fast/dom/HTMLProgressElement: Added.
- fast/dom/HTMLProgressElement/progress-element.html: Added.
- fast/dom/HTMLProgressElement/script-tests: Added.
- fast/dom/HTMLProgressElement/script-tests/TEMPLATE.html: Added.
- fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js: Added.
- fast/dom/HTMLProgressElement/set-progress-properties.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/fast/dom/HTMLProgressElement: Added.
- platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
- platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
- platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
- platform/qt/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Added.
- 5:53 PM Changeset in webkit [55979] by
-
- 5 edits in trunk/WebKitTools
https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store
Reviewed by Simon Hausmann.
QtLauncher support and build flag in build-webkit.
- QtLauncher/main.cpp:
(LauncherWindow::applyPrefs):
(LauncherWindow::toggleTiledBackingStore):
(LauncherWindow::toggleResizesToContents):
(LauncherWindow::createChrome):
(LauncherApplication::handleUserOptions):
- QtLauncher/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::setResizesToContents):
(WebViewGraphicsBased::resizeEvent):
- QtLauncher/webview.h:
- Scripts/build-webkit:
- 5:51 PM Changeset in webkit [55978] by
-
- 6 edits in trunk/WebKit/qt
https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store
Reviewed by Simon Hausmann.
Implements a basic tiled backing store mechanism. Tiles are created and
deleted on demand. The page content is cached to the tiles. Tile content
is kept in sync with the document. Since the backing store covers area
larger than the currently visible viewport, the document can be scrolled
quickly without having to enter rendering tree painting.
The tile management code is platform independent. This patch has simple QPixmap
based tile implementation for Qt.
The feature is behind ENABLE_TILED_BACKING_STORE flag.
- Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::visibleRect):
(QGraphicsWebView::paint):
- Api/qwebframe.cpp:
(QWebFramePrivate::renderContentsLayerAbsoluteCoords):
- Api/qwebframe.h:
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
- Api/qwebsettings.h:
- 5:01 PM Changeset in webkit [55977] by
-
- 7 edits in trunk
2010-03-14 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set
https://bugs.webkit.org/show_bug.cgi?id=36095
Correct this test to cover the somewhat bizarre "correct" handling
of undefined dropEffect
- fast/events/drag-and-drop-expected.txt:
- fast/events/drag-and-drop.html:
2010-03-14 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set
https://bugs.webkit.org/show_bug.cgi?id=36095
The issue here is that while dropEffect is meant to be initialized
to "none", the behaviour of the drag is differs between dragEffect
not being set and dragEffect being explicitly set to "none"
This patch corrects this behaviour by making Clipboard distinguish
between the initial "none" value of dropEffect and an explicit "none".
This alone is insufficient for correct behaviour, we also need to
resurrect the removed defaultOperationForDrag function, but we now
use the function only when dragEffect is uninitialized. There are a
few tweaks to the behaviour of the defaultOperationForDrag as well
to ensure exactly the same set of outcomes for all cases that we
may hit it.
- dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): (WebCore::dragOpFromIEOp): (WebCore::Clipboard::destinationOperation):
- dom/Clipboard.h: (WebCore::Clipboard::dropEffect): (WebCore::Clipboard::dropEffectIsUninitialized):
- page/DragController.cpp: (WebCore::defaultOperationForDrag): (WebCore::DragController::tryDHTMLDrag):
- 4:40 PM Changeset in webkit [55976] by
-
- 8 edits5 adds in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store
Reviewed by Simon Hausmann.
Implements a basic tiled backing store mechanism. Tiles are created and
deleted on demand. The page content is cached to the tiles. Tile content
is kept in sync with the document. Since the backing store covers area
larger than the currently visible viewport, the document can be scrolled
quickly without having to enter rendering tree painting.
The tile management code is platform independent. This patch has simple QPixmap
based tile implementation for Qt.
The feature is behind ENABLE_TILED_BACKING_STORE flag.
- WebCore.pri:
- WebCore.pro:
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::setTiledBackingStoreEnabled):
(WebCore::Frame::tiledBackingStorePaintBegin):
(WebCore::Frame::tiledBackingStorePaint):
(WebCore::Frame::tiledBackingStorePaintEnd):
(WebCore::Frame::tiledBackingStoreContentsRect):
- page/Frame.h:
(WebCore::Frame::tiledBackingStore):
- page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setTiledBackingStoreEnabled):
- page/Settings.h:
(WebCore::Settings::tiledBackingStoreEnabled):
- platform/graphics/Tile.h: Added.
(WebCore::Tile::create):
(WebCore::Tile::coordinate):
(WebCore::Tile::rect):
- platform/graphics/TiledBackingStore.cpp: Added.
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::~TiledBackingStore):
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::viewportChanged):
(WebCore::TiledBackingStore::setContentsScale):
(WebCore::TiledBackingStore::tileDistance):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::dropOverhangingTiles):
(WebCore::TiledBackingStore::dropTilesOutsideRect):
(WebCore::TiledBackingStore::tileAt):
(WebCore::TiledBackingStore::setTile):
(WebCore::TiledBackingStore::removeTile):
(WebCore::TiledBackingStore::mapToContents):
(WebCore::TiledBackingStore::mapFromContents):
(WebCore::TiledBackingStore::contentsRect):
(WebCore::TiledBackingStore::tileRectForCoordinate):
(WebCore::TiledBackingStore::tileCoordinateForPoint):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::tileBufferUpdateTimerFired):
(WebCore::TiledBackingStore::startTileCreationTimer):
(WebCore::TiledBackingStore::tileCreationTimerFired):
(WebCore::TiledBackingStore::setContentsFrozen):
- platform/graphics/TiledBackingStore.h: Added.
(WebCore::TiledBackingStore::contentsScale):
(WebCore::TiledBackingStore::contentsFrozen):
- platform/graphics/TiledBackingStoreClient.h: Added.
- platform/graphics/qt/TileQt.cpp: Added.
(WebCore::checkeredPixmap):
(WebCore::Tile::Tile):
(WebCore::Tile::~Tile):
(WebCore::Tile::isDirty):
(WebCore::Tile::isReadyToPaint):
(WebCore::Tile::invalidate):
(WebCore::Tile::updateBackBuffer):
(WebCore::Tile::swapBackBufferToFront):
(WebCore::Tile::paint):
(WebCore::Tile::paintCheckerPattern):
- 2:44 PM Changeset in webkit [55975] by
-
- 16 edits2 deletes in trunk
WebCore: WebCore part of removing support for legacy versions of Core Graphics
Reviewed by Darin Adler.
- WebCore.vcproj/WebCore.vcproj: Removed FontDatabase.{cpp,h}
- platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs): Removed call to wkCanCreateCGFontWithLOGFONT(),
as it is now always true.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Ditto.
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Updated for
the removal of m_cgFont.
(WebCore::FontCustomPlatformData::fontPlatformData): Removed call to
wkCanCreateCGFontWithLOGFONT(), as it is now always true.
(WebCore::createFontCustomPlatformData): Ditto. Also updated for change to
the FontCustomPlatformData constructor.
- platform/graphics/win/FontCustomPlatformData.h: Removed m_cgFont member.
(WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed cgFont
parameter.
- platform/graphics/win/FontDatabase.cpp: Removed.
- platform/graphics/win/FontDatabase.h: Removed.
- platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::platformDataInit): Removed call to
wkCanCreateCGFontWithLOGFONT(), as it is now always true.
- platform/win/TemporaryLinkStubs.cpp:
(WebCore::populateFontDatabase): Removed stub.
WebKit/win: WebKit part of removing support for legacy versions of Core Graphics
Reviewed by Darin Adler.
- WebKitClassFactory.cpp:
(WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase().
- WebKitGraphics.cpp:
(makeFont): Ditto.
- WebTextRenderer.cpp:
(WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath().
WebKitLibraries: WebKitSystemInterface part of removing support for legacy versions of Core Graphics
Reviewed by Darin Adler.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h: Removed
wkCanCreateCGFontWithLOGFONT(), wkSetFontPlatformInfo(), wkAddFontsInDirectory(),
wkAddFontsAtPath(), wkAddFontsFromRegistry(), wkAddFontsFromPlist(), and
wkCreateFontsPlist().
- win/lib/WebKitSystemInterface.lib: Updated.
- win/lib/WebKitSystemInterface_debug.lib: Updated.
- 8:43 AM Changeset in webkit [55974] by
-
- 2 edits in trunk/WebCore
"event.ctrlKey" is always false when dragging an element with "ctrl" key down
https://bugs.webkit.org/show_bug.cgi?id=17113
Reviewed by Sam Weinig.
No new tests.
- page/DragController.cpp:
(WebCore::createMouseEvent):
Use the current state of the shift, ctrl, alt, and meta keys when creating the drag mouse event.
- 5:58 AM Changeset in webkit [55973] by
-
- 3 edits in trunk/WebCore
2010-03-13 Antonio Gomes <tonikitoo@webkit.org>
Not reviewed identation fix.
- manual-tests/spatial-navigation/spatial-navigation-test-cases.html:
Mar 13, 2010:
- 4:23 PM Changeset in webkit [55972] by
-
- 2 edits1 copy2 adds in trunk/WebKitTools
The webkit-patch script now displays a warning if run using
a version of Python less than 2.5. This will help users
understand why webkit-patch is erroring out if they are
using Python 2.4, for example.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=31533
- Scripts/webkit-patch:
- Moved most of the file contents to webkitpy/patch/patcher.py so the Python version can be checked before interpreting any code that can cause the script to error out.
- Added a configure_logging() method to enable any version warnings to show up.
- Added a main() method with calls to configure_logging(), check_version(), and the main webkit patch method.
- Scripts/webkitpy/patch/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- This file is required to make a folder a package.
- Scripts/webkitpy/patch/patcher.py: Added.
- Moved code from Scripts/webkit-patch.
- 3:48 PM Changeset in webkit [55971] by
-
- 4 edits in trunk/WebKitTools
Changed test-webkitpy so that messages logged as a side-effect
of unit-testing code do not get displayed to the screen. These
messages clutter up the unit test results if not filtered out.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35835
- Scripts/test-webkitpy:
- Adjusted the configure_logging() method to filter out any log messages from webkitpy.
- Also added an INFO message stating that most console logging is getting suppressed.
- Scripts/webkitpy/init/versioning.py:
- Added a log parameter to the check_version() method.
- Scripts/webkitpy/init/versioning_unittest.py:
- Qualified a call to check_version() with the parameter names.
- 2:36 PM Changeset in webkit [55970] by
-
- 3 edits1 copy3 adds in trunk/WebKitTools
The test-webkitpy script now warns the user if the script is
being run using a Python version different from the minimum
version the webkitpy package was meant to support.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35788
Warning developers if their Python version is too low will help
them understand why test-webkitpy is failing. Secondly, warning
developers if their Python version is higher than the minimum will
help them understand that their changes may not be okay for the
minimum supported version, even if test-webkitpy is passing.
- Scripts/test-webkitpy:
- Moved the "from ..._unittest import *" lines to the new file Scripts/webkitpy/unittests.py. This will allow the version-check warning to be displayed even if an error occurs while interpreting (i.e. importing) the unit test code.
- Added configure_logging() to configur logging for test-webkitpy.
- Added an init() method to configure logging and check the current Python version.
- Scripts/webkitpy/init/unittests.py: Added.
- Added a file to import all unit test modules in the webkitpy.init package.
- Scripts/webkitpy/init/versioning.py: Added.
- Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set it equal to 2.5.
- Added a compare_version() method to compare the current Python version against a target version.
- Added a check_version() method to check the current Python version against the current minimum supported version, and to log a warning message if the check fails.
- Scripts/webkitpy/init/versioning_unittest.py: Added.
- Added unit tests for the functions in versioning.py.
- Scripts/webkitpy/style/unittests.py:
- Fixed/updated a code comment.
- Scripts/webkitpy/unittests.py: Added.
- Moved the "from ..._unittest import *" lines from test-webkitpy.
- 2:10 PM Changeset in webkit [55969] by
-
- 6 edits1 copy1 add in trunk/WebKitTools
Moved all code in webkitpy/init.py to another location.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35828
Keeping webkitpy/init.py free of non-trivial code allows
calling code to import initialization code from webkitpy
before any errors or log messages occur due to code in
init.py. Such initialization code can include things like
version checking code and logging configuration code. This
also lets us move the autoinstall initialization code to a
location where it only executes if it is needed -- something
we have done in this patch.
- Scripts/webkitpy/init.py:
- Moved all executable code to the following location: webkitpy/thirdparty/autoinstalled/init.py
- Added a code comment to keep this file free of non-trivial code.
- Scripts/webkitpy/bugzilla.py:
- Updated mechanize import statement.
- Scripts/webkitpy/networktransaction.py:
- Updated mechanize import statement.
- Scripts/webkitpy/networktransaction_unittest.py:
- Updated mechanize import statement.
- Scripts/webkitpy/statusserver.py:
- Updated mechanize import statement.
- Scripts/webkitpy/thirdparty/autoinstalled/init.py: Added.
- Copied the code from webkitpy/init.py and updated it as necessary.
- 1:28 PM Changeset in webkit [55968] by
-
- 16 edits1 move2 adds in trunk/WebKitTools
Moved webkitpy/mock.py into webkitpy/thirdparty since it is
third-party code.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35499
Updated the import statement in all of the below except where noted.
- Scripts/webkitpy/bugzilla_unittest.py:
- Scripts/webkitpy/commands/commandtest.py:
- Scripts/webkitpy/commands/download_unittest.py:
- Scripts/webkitpy/commands/early_warning_system_unittest.py:
- Scripts/webkitpy/commands/queries_unittest.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- Scripts/webkitpy/commands/queuestest.py:
- Scripts/webkitpy/commands/upload.py:
- Scripts/webkitpy/commands/upload_unittest.py:
- Scripts/webkitpy/commands_references.py: Added.
- Added a file containing an absolute import of Mock so that the imports in the commands folder can import from this file (similar to style_references.py). This helps limit the number of affected files in future refactorings.
- Scripts/webkitpy/credentials_unittest.py:
- Scripts/webkitpy/mock.py: Removed.
- Moved to Scripts/webkitpy/thirdparty.
- Scripts/webkitpy/mock_bugzillatool.py:
- Scripts/webkitpy/patchcollection_unittest.py:
- Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
- Scripts/webkitpy/steps/steps_unittest.py:
- Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
- Scripts/webkitpy/steps_references.py: Added.
- Added a file containing an absolute import of Mock so that the imports in the steps folder can import from this file (similar to style_references.py). This helps limit the number of affected files in future refactorings.
- Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py.
- Also eliminated trailing white space and carriage returns.
- 11:28 AM Changeset in webkit [55967] by
-
- 2 edits in trunk/WebCore
2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC
https://bugs.webkit.org/show_bug.cgi?id=36034
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::OpacityAnimationQt::applyFrame):
- 10:54 AM Changeset in webkit [55966] by
-
- 2 edits in trunk/WebCore
2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayer: Opacity transitions end with begin value
https://bugs.webkit.org/show_bug.cgi?id=36019
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQt::updateCurrentTime):
- 10:35 AM Changeset in webkit [55965] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to efl/ewk.
http://webkit.org/b/35925
- efl/ewk/ewk_history.cpp: Added.
- efl/ewk/ewk_history.h: Added.
- 10:17 AM Changeset in webkit [55964] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to efl/ewk.
http://webkit.org/b/35928
- efl/ewk/ewk_main.cpp: Added.
- efl/ewk/ewk_main.h: Added.
- 10:12 AM Changeset in webkit [55963] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Enable accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=35866
Unreviewed. Roll-out r55955, because it broke 3 tests:
- animations/fill-mode-transform.html
- animations/play-state.html
- animations/simultaneous-start-left.html
- Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):
- 7:25 AM QtWebKitJournal edited by
- (diff)
- 5:43 AM Changeset in webkit [55962] by
-
- 3 edits in trunk/WebCore
2010-03-13 Dirk Schulze <krit@webkit.org>
No review, rolling out r55927.
http://trac.webkit.org/changeset/55927
https://bugs.webkit.org/show_bug.cgi?id=35793
Breaks Gtk build bots.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::setPreload):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 2:59 AM Changeset in webkit [55961] by
-
- 2 edits in trunk/WebKitTools
2010-03-12 Robert Hogan <robert@webkit.org>
Reviewed by Adam Barth.
Amend incorrect typo patch for QtLauncher.
- QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
- 2:44 AM Changeset in webkit [55960] by
-
- 1 edit19 adds in trunk/WebKitTools
2010-03-13 Victor Wang <victorw@chromium.org>
Add appengine app to host and serve webkit layout test results.
The app allows you post test result files (json) and serve them up.
Chromium flakiness dashboard will first use this app to host results.json
and expectations.json, but the files hosted by this app are not limited
to chromium results or json files. It can be used to host other files if needed.
- TestResultServer: Added.
- TestResultServer/app.yaml: Added.
- TestResultServer/handlers: Added.
- TestResultServer/handlers/init.py: Added.
- TestResultServer/handlers/menu.py: Added.
- TestResultServer/handlers/testfilehandler.py: Added.
- TestResultServer/index.yaml: Added.
- TestResultServer/main.py: Added.
- TestResultServer/model: Added.
- TestResultServer/model/init.py: Added.
- TestResultServer/model/testfile.py: Added.
- TestResultServer/stylesheets: Added.
- TestResultServer/stylesheets/form.css: Added.
- TestResultServer/stylesheets/menu.css: Added.
- TestResultServer/stylesheets/testfile.css: Added.
- TestResultServer/templates: Added.
- TestResultServer/templates/menu.html: Added.
- TestResultServer/templates/showfilelist.html: Added.
- TestResultServer/templates/uploadform.html: Added.
- 2:28 AM Changeset in webkit [55959] by
-
- 2 edits in trunk/WebKitTools
2010-03-13 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
new-run-webkit-tests fails with --debug option.
https://bugs.webkit.org/show_bug.cgi?id=36067
- Scripts/webkitpy/layout_tests/port/mac.py:
- 2:11 AM Changeset in webkit [55958] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to efl/ewk.
http://webkit.org/b/35924
- efl/ewk/ewk_frame.cpp: Added.
- efl/ewk/ewk_frame.h: Added.
- 1:54 AM Changeset in webkit [55957] by
-
- 1 edit1 add in trunk/WebKit
2010-03-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to efl/ewk.
http://webkit.org/b/35936
- efl/ewk/ewk_view_single.c: Added.
- 1:38 AM Changeset in webkit [55956] by
-
- 2 edits in trunk/WebKitTools
2010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Add "Show FPS" menu option to QtLauncher.
[Qt] QtLauncher need a menu option to show/hide FPS
https://bugs.webkit.org/show_bug.cgi?id=35794
- QtLauncher/main.cpp: (LauncherWindow::showFPS): (LauncherWindow::createChrome):
- 1:21 AM Changeset in webkit [55955] by
-
- 2 edits in trunk/WebKit/qt
2010-03-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=35866
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
- 1:04 AM Changeset in webkit [55954] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to efl/ewk.
http://webkit.org/b/35929
- efl/ewk/ewk_util.cpp: Added.
- efl/ewk/ewk_util.h: Added.
- 12:47 AM Changeset in webkit [55953] by
-
- 1 edit5 adds in trunk/WebKit
2010-03-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to efl/ewk.
http://webkit.org/b/35934
- efl/ewk/EWebKit.h: Added.
- efl/ewk/ewk_eapi.h: Added.
- efl/ewk/ewk_logging.h: Added.
- efl/ewk/ewk_private.h: Added.
- 12:31 AM Changeset in webkit [55952] by
-
- 3 edits in trunk/WebKit/chromium
2010-03-13 Eric Roman <eroman@chromium.org>
Reviewed by Adam Barth.
Add a firstPartyForCookies() property to WebDocument.
https://bugs.webkit.org/show_bug.cgi?id=35592
- public/WebDocument.h:
- src/WebDocument.cpp: (WebKit::WebDocument::firstPartyForCookies):
- 12:14 AM Changeset in webkit [55951] by
-
- 2 edits in trunk/WebKitTools
2010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Add a "Toggle FullScreen" option to QtLauncher Menu.
[Qt] QtLauncher needs an option to toggle FullScreen Mode
https://bugs.webkit.org/show_bug.cgi?id=35755
- QtLauncher/main.cpp: (LauncherWindow::init): (LauncherWindow::eventFilter): (LauncherWindow::initializeView): (LauncherWindow::toggleFullScreenMode): (LauncherWindow::createChrome):
Mar 12, 2010:
- 11:57 PM Changeset in webkit [55950] by
-
- 3 edits2 adds in trunk/LayoutTests
2010-03-12 Shu Chang <chang.shu@nokia.com>
Reviewed by David Levin.
[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=36057
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-size-change-after-layout-expected.png: Added.
- platform/qt/fast/canvas/canvas-size-change-after-layout-expected.txt:
- 11:07 PM Changeset in webkit [55949] by
-
- 19 edits in trunk
2010-03-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Glyphs - transform path not context
https://bugs.webkit.org/show_bug.cgi?id=36070
SVGFont should transform the path of a glyph, not the context. Modifying
the context causes wrong gradient transformations. This bug doesn't
influence CG because we generally fill or stroke texts with a mask image.
All other platforms provide a direct way to make the drawings.
- svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):
2010-03-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Glyphs - transform path not context
https://bugs.webkit.org/show_bug.cgi?id=36070
Some tests don't look pixel perfect after the SVGFont changes (difference of 0.1%).
They just need an update.
Tests for the changes on other platforms than CG are
- svg/batik/text/textEffect.svg
- svg/batik/text/textEffect3.svg
- svg/W3C-SVG-1.1/pservers-grad-08-b.svg
- platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
- platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
- platform/mac/svg/batik/text/textEffect-expected.checksum:
- platform/mac/svg/batik/text/textEffect-expected.png:
- platform/mac/svg/batik/text/textEffect3-expected.checksum:
- platform/mac/svg/batik/text/textEffect3-expected.png:
- platform/mac/svg/text/selection-doubleclick-expected.png:
- platform/mac/svg/text/selection-tripleclick-expected.png:
- 6:10 PM Changeset in webkit [55948] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (build fix).
- 5:56 PM Changeset in webkit [55947] by
-
- 2 edits in trunk/WebKit/win
Fixed broken build on Windows.
Added contditional compilation for accelerated compositing.
- WebView.cpp:
(WebView::deleteBackingStore):
(WebView::addToDirtyRegion):
(WebView::updateBackingStore):
- 5:39 PM Changeset in webkit [55946] by
-
- 14 edits in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
API naming is inconsistent
-and corresponding-
<rdar://problem/7729165>
Reviewed by Simon Fraser.
WebCore:
This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen." webkitEnterFullScreen and
webkitExitFullScreen have been maintained for now for backwards
compatibility.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitEnterFullscreen):
(WebCore::HTMLVideoElement::webkitExitFullscreen):
- html/HTMLVideoElement.h:
(WebCore::HTMLVideoElement::webkitEnterFullScreen):
(WebCore::HTMLVideoElement::webkitExitFullScreen):
- html/HTMLVideoElement.idl:
- platform/graphics/mac/MediaPlayerProxy.h:
WebKit/mac:
This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."
- Plugins/Hosted/NetscapePluginHostProxy.h:
(WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::didEnterFullscreen):
(WebKit::NetscapePluginHostProxy::didExitFullscreen):
(WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
(WKPCSetFullscreenWindowIsShowing):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
(-[WebNetscapePluginView _createPlugin]):
(-[WebNetscapePluginView _destroyPlugin]):
- WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):
WebKit/win:
This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."
- FullscreenVideoController.cpp:
(FullscreenVideoController::onMouseDown):
(FullscreenVideoController::onMouseMove):
(FullscreenVideoController::onMouseUp):
- FullscreenVideoController.h:
(FullscreenVideoController::fullscreenToHUDCoordinates):
- 5:02 PM Changeset in webkit [55945] by
-
- 2 edits in trunk/WebCore
2010-03-12 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Add virtual destructor to DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=36077
DOMWrapperWorld is RefCounted<DOMWrapperWorld>. IsolatedWorld
inherits from DOMWrapperWorld and has member variables
with destructors, so DOMWrapperWorld needs to have a declared virtual
d'tor to ensure that its derived class's destructors are called.
No new tests, no change in behavior
- bindings/v8/DOMWrapperWorld.h: (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
- 4:46 PM Changeset in webkit [55944] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (build fix).
- 3:49 PM Changeset in webkit [55943] by
-
- 10 edits in trunk
Bug 36075 - Clean up screwyness re static string impls & Identifiers.
Reviewed by Oliver Hunt.
- API/JSClassRef.cpp:
(OpaqueJSClass::~OpaqueJSClass): Classname may be null/empty, and these are an identifer. This is okay, since the null/empty strings are shared across all threads.
- JavaScriptCore.exp:
- runtime/Identifier.cpp:
(JSC::Identifier::add): No need to explicitly hash null reps, this is done in the ststic UStringImpl constructor.
(JSC::Identifier::addSlowCase): UStringImpl::empty() handled & checkCurrentIdentifierTable now called in the header.
(JSC::Identifier::checkCurrentIdentifierTable): Replaces checkSameIdentifierTable (this no longer checked the rep since the identifierTable pointer was removed from UString::Rep long ago).
- runtime/Identifier.h:
(JSC::Identifier::add): Replace call to checkSameIdentifierTable with call to checkCurrentIdentifierTable at head of function.
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::~UStringImpl): Remove call to checkConsistency - this function no longer checks anything interesting.
- runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::UStringOrRopeImpl): Set s_refCountFlagIsIdentifier in static constructor.
(JSC::UStringImpl::UStringImpl): remove calls to checkConsistency (see above), add new ASSERT to substring constructor.
(JSC::UStringImpl::setHash): ASSERT not static (static strings set the hash in their constructor, should not reach this code path).
(JSC::UStringImpl::create): Add missing ASSERT.
(JSC::UStringImpl::setIsIdentifier): ASSERT !isStatic() (static strings hash set in constructor).
WebCore:
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl): Add ASSERT
(WebCore::StringImpl::sharedBuffer): Add ASSERT
- platform/text/StringImpl.h:
(WebCore::StringImpl::setHash): Add ASSERT
(WebCore::StringImpl::isStatic): added.
- 3:17 PM Changeset in webkit [55942] by
-
- 2 edits in trunk/WebKit/win
Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
video HUD stays on top when switching to another window (e.g. via
Alt-Tab)
-and corresponding-
<rdar://problem/7547574>
Reviewed by Adam Roben.
The HUD was always on top because it had the WS_EX_TOPMOST style.
So I removed the style and made m_videoWindow the owner of
m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
is the focused window.
- FullscreenVideoController.cpp:
(FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
(FullscreenVideoController::createHUDWindow):
- 3:11 PM Changeset in webkit [55941] by
-
- 6 edits10 adds1 delete in trunk
Content of 3D tests appears at the bottom right corner sometimes.
<rdar://problem/7556244>
<https://bugs.webkit.org/show_bug.cgi?id=36027>
Reviewed by Simon Fraser.
WebCore:
There were two problems to solve here:
- the incorrect anchoring of the rootChildLayer that was causing the composited content to be positioned incorrectly
- the failure to paint the non composited content into the backing store when animating composited content.
The first problem has been solved by leaving the original anchor point for the
rootChildLayer and splitting the tasks of clipping and scrolling using two separate layers.
The second problem has been solved leveraging the knowledge that WebView has of the dirty region
of the backing store to pass this information to the layer renderer. This allows the renderer to force
a paint into the backing store before moving to the compositing.
Tests: compositing/geometry/horizontal-scroll-composited.html
compositing/geometry/vertical-scroll-composited.html
- manual-tests/win/horizontal-scroll-composited.html: Removed. This is now a layout test.
- manual-tests/win/milliondollar.html: Added.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Added initialization of dirty flag.
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::updateScrollFrame): Updated to resize and position the clip and scroll layers.
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
(WebCore::WKCACFLayerRenderer::createRenderer): Added new layer hierarchy.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Remove clip layer on destroy.
(WebCore::WKCACFLayerRenderer::resize):
(WebCore::WKCACFLayerRenderer::paint): Forcing paint massage to trigger paint into the backing store.
- platform/graphics/win/WKCACFLayerRenderer.h:
(WebCore::WKCACFLayerRenderer::setBackingStoreDirty): Added.
WebKit/win:
See detailed comments in WebCore/ChangeLog.
- WebView.cpp:
(WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
(WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
backing store dirty region.
(WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
(WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
(WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
We are passing width and height of the view content together with the offset for the scrolling.
It was confusing to pass it all as a rectangle, when it is not a rectangle.
LayoutTests:
- compositing/geometry/horizontal-scroll-composited.html: Added.
- compositing/geometry/vertical-scroll-composited.html: Added.
- compositing/resources/apple.jpg: Added.
- platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
- platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/mac/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
- platform/mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
- platform/mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
- platform/mac/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
- 2:58 PM Changeset in webkit [55940] by
-
- 2 edits in trunk/WebKitTools
2010-03-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Fix typo in websocket_server (path_from_base instead of
path_from_chromium_base).
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 2:49 PM Changeset in webkit [55939] by
-
- 2 edits in trunk/WebCore
2010-03-12 Robert Hogan <robert@webkit.org>
Not reviewed, build fix.
Revert http://trac.webkit.org/projects/webkit/changeset/55374 which broke
the !ENABLE(DATABASE) build on all platforms when attempting to fix the
--minimal build on Qt.
Support for SQLite now seems to be non-negotiable for the Qt build but making
it mandatory requires review, so re-break --minimal Qt build for now.
Qt build issue now tracked at https://bugs.webkit.org/show_bug.cgi?id=36073
- page/GeolocationPositionCache.cpp:
- 2:43 PM Changeset in webkit [55938] by
-
- 5 edits in trunk/WebKitTools
2010-03-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
new-run-webkit-tests --new-baseline doesn't work at all.
It attempts to call a method that isn't defined. To fix it, I
removed the unnecessary and unnecessarily confusing 'platform'
argument to the test_type constructor and use the Port object that
is passed in instead, since we are only ever generating a baseline
from the port that is currently executing.
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- 2:42 PM Changeset in webkit [55937] by
-
- 2 edits in trunk/WebKitTools
2010-03-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Fix new-run-webkit-tests --run-singly
This script option is currently broken - the script attempts to
dereference methods and variables that don't exist, which causes
the Chromium Linux valgrind bot to be quite unhappy. This has been
broken since r54449 when I renamed Port.start_test_driver to
Port.start_driver.
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- 2:31 PM Changeset in webkit [55936] by
-
- 2 edits in trunk/LayoutTests
2010-03-12 Dirk Schulze <krit@webkit.org>
Unreviewed LayoutTest update.
Result was not updated with r55930.
- platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
- 1:23 PM Changeset in webkit [55935] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7709115> REGRESSION: toolbar is missing at http://www.glom.org/
https://bugs.webkit.org/show_bug.cgi?id=35507
Reviewed by Alexey Proskuryakov.
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in
<http://trac.webkit.org/changeset/48818> to detect the two variants of
KHTMLFixes.css in @import rules as well as in <link> elements.
- 1:16 PM Changeset in webkit [55934] by
-
- 2 edits in trunk/WebCore
Bug 36052 - [Qt] REGRESSION(55878) 63 test cases crash
Reviewed by Geoff Garen.
r55878 changed UStringImpl::empty()->characters() to be non-null,
so TextBreakIteratorQt.cpp now should check the length of strings
(previously was assuming all strings with a non-null data pointer
had a length of at least 1).
- platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):
- 1:15 PM Changeset in webkit [55933] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-12 Garret Kelly <gdk@chromium.org>
Unreiviewed.
Fix Chromium Mac build. Last patch did not apply properly.
(Garret assures me this patch will actually work.)
- src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
- 12:48 PM Changeset in webkit [55932] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-12 Garret Kelly <gdk@chromium.org>
Unreviewed.
Fix Chromium Mac build. This time, with actual fixing goodness.
- src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
- 12:47 PM Changeset in webkit [55931] by
-
- 4 edits in trunk/WebKit/mac
Expose WebPDFView's underlying PDFDocument.
Patch by Andy Estes <aestes@apple.com> on 2010-03-12
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=36045
- WebView/WebDocumentPrivate.h: Create a new protocol called
WebDocumentPDF.
- WebView/WebPDFView.h: Have WebPDFView implement said protocol.
- WebView/WebPDFView.mm:
(-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
PDFDocument by implementing -(PDFDocument*)PDFDocument from
WebDocumentPDF.
- 12:43 PM Changeset in webkit [55930] by
-
- 5 edits4 adds in trunk
2010-03-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG fallback color doesn't work for bogus gradients.
https://bugs.webkit.org/show_bug.cgi?id=35479
Use a given fallback color on ignored gradients if present. Gradients
must be ignored, if one dimension of the objects boundingBox is zero.
Test: svg/custom/gradient-with-1d-boundingbox.svg
- svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::strokePaintServer):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):
2010-03-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG fallback color doesn't work for bogus gradients.
https://bugs.webkit.org/show_bug.cgi?id=35479
We now use a fallback color on ignored gradients for one dimensional objects,
either a given fallback color or black as default.
This causes a change of one LayoutTest, because it was done manually in the
gradient PaintServer, without respecting a given fallback color.
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
- platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
- platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
- platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
- svg/custom/gradient-with-1d-boundingbox.svg: Added.
- 12:36 PM Changeset in webkit [55929] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-12 Garret Kelly <gdk@chromium.org>
Unreviewed.
Fix Chromium Mac build.
- src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
- 12:29 PM Changeset in webkit [55928] by
-
- 16 edits1 delete in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=36069
Reviewed by Dan Bernstein.
Eliminate InlineRunBox.
- WebCore.xcodeproj/project.pbxproj:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::prevLineBox):
(WebCore::InlineFlowBox::nextLineBox):
(WebCore::InlineFlowBox::setNextLineBox):
(WebCore::InlineFlowBox::setPreviousLineBox):
- rendering/InlineRunBox.h: Removed.
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::InlineTextBox):
(WebCore::InlineTextBox::prevTextBox):
(WebCore::InlineTextBox::nextTextBox):
(WebCore::InlineTextBox::setNextTextBox):
(WebCore::InlineTextBox::setPreviousTextBox):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::localBoundingBox):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::attachLineBox):
(WebCore::RenderLineBoxList::removeLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::dirtyLineBoxes):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
(WebCore::RenderLineBoxList::checkConsistency):
- rendering/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::absoluteRects):
(WebCore::RenderSVGInline::absoluteQuads):
- rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::absoluteRects):
(WebCore::RenderSVGText::absoluteQuads):
(WebCore::RenderSVGText::objectBoundingBox):
- rendering/RenderText.cpp:
(WebCore::RenderText::extractTextBox):
(WebCore::RenderText::attachTextBox):
(WebCore::RenderText::removeTextBox):
(WebCore::RenderText::createInlineTextBox):
(WebCore::RenderText::positionLineBox):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):
- 12:11 PM Changeset in webkit [55927] by
-
- 3 edits in trunk/WebCore
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Carlson.
media/video-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=35793
Only effectively load, and start buffering when playing, or when
the preload attribute is set.
Test: media/video-preload.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::commitLoad): (WebCore::MediaPlayerPrivate::prepareToPlay): (WebCore::MediaPlayerPrivate::setPreload):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 12:06 PM Changeset in webkit [55926] by
-
- 30 edits7 deletes in trunk
Not reviewed, build fix.
Reverts 55920 and 55921. Landing for Jian Li.
WebCore:
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMFormDataCustom.cpp: Removed.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8DOMFormDataCustom.cpp: Removed.
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
- html/DOMFormData.idl: Removed.
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- http/tests/local/resources/send-form-data.js: Removed.
- http/tests/local/send-form-data-expected.txt: Removed.
- http/tests/local/send-form-data.html: Removed.
- http/tests/xmlhttprequest/resources/multipart-post-echo.php: Removed.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/qt/Skipped:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/win/Skipped:
- 12:03 PM Changeset in webkit [55925] by
-
- 2 edits in trunk/WebKitTools
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Fix critical being printed to stderr on every test. This is
because the jar is only being created when soup hits the HTTP
path. We should reconsider the time of its creation.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 11:57 AM Changeset in webkit [55924] by
-
- 2 edits in trunk/LayoutTests
Make the timeout in 'snav-unit-overflow-and-scroll-in-direction.html' 10x shorter (from 500ms to 50ms)
Rubber-stamped by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
- 11:45 AM Changeset in webkit [55923] by
-
- 3 edits in trunk/WebCore
2010-03-12 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Dirk Schulze.
[OpenVG] Add support for drawing text to PainterOpenVG
https://bugs.webkit.org/show_bug.cgi?id=35581
Doesn't come with any actual font classes, as OpenVG
by itself doesn't provide any access to platform fonts
but just the means to draw glyphs that have been loaded
manually before.
- platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::copyPaintState): (WebCore::PainterOpenVG::textDrawingMode): (WebCore::PainterOpenVG::setTextDrawingMode): (WebCore::PainterOpenVG::drawText):
- platform/graphics/openvg/PainterOpenVG.h:
- 11:25 AM Changeset in webkit [55922] by
-
- 6 edits in trunk/WebCore
2010-03-12 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Dirk Schulze.
[OpenVG] Use masks to implement non-rectilinear clipping
https://bugs.webkit.org/show_bug.cgi?id=35544
Requires some additional context switching logic to
make sure the right context is current when dealing
with the mask, because we don't store it by ourselves.
Initial version of this code was written by
Eli Fidler <efidler@rim.com>, I did a couple of
bug fixes and efficiency improvements since then.
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip):
- platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::~PlatformPainterState): (WebCore::PlatformPainterState::maskingEnabled): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::saveMaskIfNecessary): (WebCore::PainterOpenVG::intersectClipRect): (WebCore::PainterOpenVG::clipPath): (WebCore::PainterOpenVG::save):
- platform/graphics/openvg/PainterOpenVG.h: (WebCore::PainterOpenVG::):
- platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::makeCurrent): (WebCore::SurfaceOpenVG::makeCompatibleCurrent):
- platform/graphics/openvg/SurfaceOpenVG.h: (WebCore::SurfaceOpenVG::):
- 11:17 AM Changeset in webkit [55921] by
-
- 4 edits1 add in trunk/WebCore
[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026
Reviewed by Nate Chapin.
Test: http/tests/local/send-form-data.html
- WebCore.gypi:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.
(WebCore::V8DOMFormData::appendCallback):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
- 11:17 AM Changeset in webkit [55920] by
-
- 27 edits6 adds in trunk
WebCore: Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024
Reviewed by Sam Weinig.
The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata
Test: http/tests/local/send-form-data.html
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMFormDataCustom.cpp: Added.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
- bindings/scripts/CodeGeneratorJS.pm:
- html/DOMFormData.idl: Added.
- page/DOMWindow.idl:
LayoutTests: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024
Reviewed by Sam Weinig.
Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- http/tests/local/resources/send-form-data.js: Added.
- http/tests/local/send-form-data-expected.txt: Added.
- http/tests/local/send-form-data.html: Added.
- http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/qt/Skipped:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/win/Skipped:
- 11:11 AM Changeset in webkit [55919] by
-
- 5 edits in trunk/WebCore
2010-03-12 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Dirk Schulze.
[OpenVG] Add a SurfaceOpenVG constructor for EGL client buffer surfaces
https://bugs.webkit.org/show_bug.cgi?id=35538
SurfaceOpenVG can now not only encapsulate pbuffer
and window surfaces but also VGImage-based ones.
- platform/graphics/openvg/EGLDisplayOpenVG.cpp: (WebCore::EGLDisplayOpenVG::createPbufferFromClientBuffer):
- platform/graphics/openvg/EGLDisplayOpenVG.h:
- platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::SurfaceOpenVG):
- platform/graphics/openvg/SurfaceOpenVG.h:
- 11:06 AM Changeset in webkit [55918] by
-
- 2 edits in trunk/WebKitTools
Teach prepare-ChangeLog to find modified selectors in CSS files
Reviewed by Tim Hatcher.
Fixes <http://webkit.org/b/36064> prepare-ChangeLog should extract
modified selectors from CSS files
- Scripts/prepare-ChangeLog:
(get_function_line_ranges): Call get_selector_line_ranges_for_css for
.css files.
(get_selector_line_ranges_for_css): Added. Finds selectors and their
line ranges and returns them.
- 11:03 AM Changeset in webkit [55917] by
-
- 3 edits2 adds in trunk
2010-03-12 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
HTMLMediaElement crash when it is used after resource loading is canceled.
https://bugs.webkit.org/show_bug.cgi?id=35992
Adding a test to access the duration property of a video element after
resource loading was canceled.
- http/tests/media/video-cancel-load-expected.txt: Added.
- http/tests/media/video-cancel-load.html: Added.
2010-03-12 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
Fix a crash when resource loading of media element is canceled.
https://bugs.webkit.org/show_bug.cgi?id=35992
Use of HTMLMediaElement::duration() after resource loading was canceled
will cause a crash. This is because HTMLMediaElement::m_player is used
when NULL.
Test: http/tests/media/video-cancel-load.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::duration): Avoid calling to m_player when it is null. (WebCore::HTMLMediaElement::userCancelledLoad): Set m_readyState to HAVE_NOTHING.
- 10:45 AM Changeset in webkit [55916] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-12 Garret Kelly <gdk@chromium.org>
Reviewed by Eric Seidel.
Enable touch events in Chromium features gypi file.
https://bugs.webkit.org/show_bug.cgi?id=35994
- features.gypi:
- 10:36 AM Changeset in webkit [55915] by
-
- 9 edits in trunk/WebKit/gtk
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Kenneth Rohde Christiansen.
Misc documentation fixes. Fixes (almost) all warnings emitted by
the documentation build process. Only the broken references to JSC
objects remain.
- webkit/webkitsecurityorigin.cpp:
- webkit/webkitwebbackforwardlist.cpp:
- webkit/webkitwebdatasource.cpp:
- webkit/webkitwebframe.cpp:
- webkit/webkitwebhistoryitem.cpp:
- webkit/webkitwebinspector.cpp: (webkit_web_inspector_class_init):
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
- 10:28 AM Changeset in webkit [55914] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory
https://bugs.webkit.org/show_bug.cgi?id=20069
Reviewed by Darin Adler.
No test added, since with the CSS variables feature disabled, the pointer
to the freed memory is never dereferenced.
- css/CSSPrimitiveValue.cpp:
(WebCore::valueOrPropertyName): Changed to return a const AtomicString& from
a static table.
(WebCore::CSSPrimitiveValue::parserValue): Updated for the above change.
- 10:18 AM Changeset in webkit [55913] by
-
- 38 edits4 copies7 adds in trunk/LayoutTests
2010-03-05 Ojan Vafai <ojan@chromium.org>
Reviewed by David Levin.
Tests for smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314
Fixes the tests to make selections using the mouse in order
to force smart-delete. It also adds/modifies tests to have them correctly
identify cases where we are smart-deleting, but shouldn't be.
Fixing to smart-delete only on mouse-based selections will be a followup patch.
- editing/deleting/5390681-2.html:
- editing/deleting/non-smart-delete.html: Added.
- editing/deleting/smart-delete-001.html:
- editing/deleting/smart-delete-002.html:
- editing/deleting/smart-delete-003.html:
- editing/deleting/smart-delete-004.html:
- editing/editing.js: (doubleClick): (doubleClickAtSelectionStart):
- editing/pasteboard/4944770-2.html:
- editing/pasteboard/drag-drop-modifies-page.html:
- editing/pasteboard/smart-drag-drop.html: Added.
- editing/pasteboard/smart-paste-001.html:
- editing/pasteboard/smart-paste-002.html:
- editing/pasteboard/smart-paste-003.html:
- editing/pasteboard/smart-paste-004.html:
- editing/pasteboard/smart-paste-005.html:
- editing/pasteboard/smart-paste-007.html:
- editing/pasteboard/smart-paste-008.html:
- editing/selection/delete-word-granularity-text-control-expected.txt: Added.
- editing/selection/delete-word-granularity-text-control.html: Added.
- editing/selection/script-tests/delete-word-granularity-text-control.js: Added.
- editing/style/style-boundary-005.html:
- platform/mac/editing/deleting/non-smart-delete-expected.checksum: Added.
- platform/mac/editing/deleting/non-smart-delete-expected.png: Added.
- platform/mac/editing/deleting/non-smart-delete-expected.txt: Added.
- platform/mac/editing/deleting/smart-delete-001-expected.txt:
- platform/mac/editing/deleting/smart-delete-002-expected.txt:
- platform/mac/editing/deleting/smart-delete-003-expected.txt:
- platform/mac/editing/deleting/smart-delete-004-expected.txt:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.checksum:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
- platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/mac/editing/pasteboard/smart-drag-drop-expected.checksum: Added.
- platform/mac/editing/pasteboard/smart-drag-drop-expected.png: Added.
- platform/mac/editing/pasteboard/smart-drag-drop-expected.txt: Added.
- platform/mac/editing/pasteboard/smart-paste-001-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
- platform/mac/editing/style/style-boundary-005-expected.checksum:
- platform/mac/editing/style/style-boundary-005-expected.png:
- platform/mac/editing/style/style-boundary-005-expected.txt:
- 10:14 AM Changeset in webkit [55912] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-12 Darin Fisher <darin@chromium.org>
Fix Chromium build bustage.
Wrap usage of WebPrivatePtr from WebNode.h in a #if
WEBKIT_IMPLEMENTATION guard.
- public/WebNode.h:
- 10:03 AM Changeset in webkit [55911] by
-
- 2 edits in trunk/WebCore
Build fix.
- platform/chromium/PlatformKeyboardEventChromium.cpp:
- 9:54 AM Changeset in webkit [55910] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Fixing an embarrassing typo in ChangeLog.
- 9:06 AM Changeset in webkit [55909] by
-
- 16 edits2 adds in trunk
<rdar://problem/7694674> Hover states not updated when overflow section scrolls under stationary mouse pointer
https://bugs.webkit.org/show_bug.cgi?id=35949
Reviewed by Darin Adler.
WebCore:
Test: fast/events/overflow-scroll-fake-mouse-move.html
Soon after an overflow section scrolls under the mouse pointer, dispatch
a fake mouse move event. This is similar to how frame scrolling is handled
in WebKit, and has the effect of updating hover state, dispatching DOM mouse
events, and updating the tool tip.
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler): Initialize m_fakeMouseMoveEventTimer.
(WebCore::EventHandler::~EventHandler): Assert that the timer is not active.
(WebCore::EventHandler::clear): Stop the timer.
(WebCore::EventHandler::handleMousePressEvent): Cancel pending fake mouse
move events.
(WebCore::EventHandler::handleMouseMoveEvent): Ditto.
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad): If the mouse
is in the passed-in quad, ensure that a fake mouse move event is scheduled
to fire soon.
(WebCore::EventHandler::cancelFakeMouseMoveEvent): Does what the name says.
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Constructs a
PlatformMouseEvent with the current mouse location, modifier key state and
time stamp and calls mouseMoved().
- page/EventHandler.h:
- platform/PlatformKeyboardEvent.h: Declared getCurrentModifierState().
- platform/android/KeyEventAndroid.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
- platform/brew/PlatformKeyboardEventBrew.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
- platform/chromium/PlatformKeyboardEventChromium.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
- platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
- platform/gtk/KeyEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
- platform/haiku/PlatformKeyboardEventHaiku.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
- platform/mac/KeyEventMac.mm:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
- platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
- platform/win/KeyEventWin.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
- platform/wx/KeyboardEventWx.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset): Call
EventHandler::dispatchFakeMouseMoveEventSoonInQuad(). Moved things around
a little to avoid computing the repaint rect twice.
LayoutTests:
- fast/events/overflow-scroll-fake-mouse-move-expected.txt: Added.
- fast/events/overflow-scroll-fake-mouse-move.html: Added.
- fast/events/touch/basic-multi-touch-events.html:
- fast/events/touch/basic-single-touch-events.html:
- 9:03 AM Changeset in webkit [55908] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-12 Nicolas Weber <thakis@chromium.org>
Reviewed by David Levin.
[Chromium] Cmd-clicking submit buttons should submit in new tab
https://bugs.webkit.org/show_bug.cgi?id=36023
Take modifiers into account when clicking form buttons. E.g.
cmd-clicking a submit button will submit in a new background tab,
cmd-shift-clicking in a new foreground tab, shift-clicking in a new
window. (On windows/linux, it's ctrl instead of cmd.)
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):
- 8:56 AM Changeset in webkit [55907] by
-
- 2 edits in trunk/LayoutTests
2010-03-12 Csaba Osztrogonác <Csaba Osztrogonác>
[Qt] css1/box_properties/acid_test.html failed in release mode (32 bit).
But it passes in debug mode (32 and 64 bit) and in release mode (64 bit).
- platform/qt/Skipped: css1/box_properties/acid_test.html skipped again.
- 8:36 AM Changeset in webkit [55906] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-12 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Darin Fisher.
[chromium] Fix memory leak in WebImageDecoder API
https://bugs.webkit.org/show_bug.cgi?id=35946
- src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::setData): (WebKit::WebImageDecoder::getFrameAtIndex):
- 8:15 AM Changeset in webkit [55905] by
-
- 3 edits in trunk/WebKitTools
Build fix (for EWS). Make sure the new code builds on older soup.
Thanks to Dan Winship.
- 8:05 AM Changeset in webkit [55904] by
-
- 6 edits in trunk
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Carlson.
[GTK] DRT does not handle cookie policy setting
https://bugs.webkit.org/show_bug.cgi?id=36056
Implement cookie accept policy setting for GTK+'s LayoutTestController.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies):
LayoutTests
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Carlson.
[GTK] DRT does not handle cookie policy setting
https://bugs.webkit.org/show_bug.cgi?id=36056
Fix tests to request that the cookie acceptance policy always allows cookies.
- http/tests/media/video-cookie.html:
- http/tests/media/video-referer.html:
- 8:02 AM Changeset in webkit [55903] by
-
- 2 edits in trunk/WebKitTools
2010-03-12 Adam Langley <agl@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium]: update Linux layout test scripts for RedHat like systems.
(Tested on Fedora 12.)
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- 7:53 AM Changeset in webkit [55902] by
-
- 2 edits in trunk/LayoutTests
[Qt] Now css1/box_properties/acid_test.html passes, so we can unskip it.
original bug: https://bugs.webkit.org/show_bug.cgi?id=33834
- platform/qt/Skipped: css1/box_properties/acid_test.html unskipped.
- 7:45 AM Changeset in webkit [55901] by
-
- 2 edits in trunk/WebKit/mac
2010-03-12 Andy Estes <aestes@apple.com>
Reviewed by Brady Eidson.
Remove an unused method.
- Plugins/WebPluginController.mm: removed - (void)showURL:(NSURL *) inFrame:(NSString *)
- 7:28 AM Changeset in webkit [55900] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-12 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by David Levin.
Two functions tryConsumeCharacter() and tryConsumeCharacterClass() are
removed from yarr/RegexInterpreter.cpp because they are never called.
- yarr/RegexInterpreter.cpp:
- 7:16 AM Changeset in webkit [55899] by
-
- 2 edits in trunk/LayoutTests
[Qt] DRT failing on test introduced in r55499
https://bugs.webkit.org/show_bug.cgi?id=35729
Now fast/events/zoom-dblclick.html passes, so we can unskip it.
- platform/qt/Skipped: fast/events/zoom-dblclick.html unskipped.
- 7:12 AM Changeset in webkit [55898] by
-
- 2 edits in trunk/WebKitTools
Make svn-create-patch's diffs of ObjC header files more readable
Fixes <http://webkit.org/b/36055>.
Reviewed by John Sullivan.
- Scripts/svn-create-patch:
(diffOptionsForFile): Added. Returns the options that should be passed
to diff for the given file. All the options are the same for all
files, except for the option to specify which lines should be used as
hunk headers.
(generateDiff): Use diffOptionsForFile to get the options to pass to
diff.
(hunkHeaderLineRegExForFile): Added. Returns the regular expression
that should be used by diff to identify lines that should be included
after the "@@" in the hunk header lines of the diff. For ObjC[++]
source files, we use any lines starting with -, +, or
@implementation/@interface/@protocol. For ObjC[++] header files (which
we assume to be any .h files in a mac/ or objc/ directory), we use any
lines starting with @implementation/@interface/@protocol.
- 7:10 AM Changeset in webkit [55897] by
-
- 5 edits in trunk
2010-03-12 Scott Byer <scottbyer@chromium.org>
Reviewed by David Levin.
Popup font size needs to be exposed to clients.
https://bugs.webkit.org/show_bug.cgi?id=35990
Add function to expose the popup menu font size, add a field to
WebPopupMenuInfo that receives that information to convey that to
the web view client's createPopupMenu() call.
- WebCore/platform/chromium/PopupMenuChromium.cpp:
- WebCore/platform/chromium/PopupMenuChromium.h:
- WebKit/chromium/public/WebPopupMenuInfo.h:
- WebKit/chromium/src/ChromeClientImpl.cpp:
- 6:53 AM Changeset in webkit [55896] by
-
- 2 edits in trunk/WebCore
2010-03-12 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Webkit doesn't build with workers on and database off
https://bugs.webkit.org/show_bug.cgi?id=35997
Added missing ENABLE(DATABASE) guards.
- workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownStartTask::performTask):
- 6:25 AM Changeset in webkit [55895] by
-
- 2 edits in trunk/LayoutTests
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
[GTK] Fails fast/dom/Geolocation/maximum-age.htm
https://bugs.webkit.org/show_bug.cgi?id=36053
Skip new failing test.
- platform/gtk/Skipped:
- 6:25 AM Changeset in webkit [55894] by
-
- 4 edits in trunk
2010-03-12 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha.
Make the defaultCookieJar use a no-third-party policy. Most
applications set their own cookie jar, but DumpRenderTree doesn't,
so it was failing the new third-party-cookie test.
- platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar):
LayoutTests
2010-03-12 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha.
Revert previous; the test passes now.
- platform/gtk/Skipped:
- 6:06 AM Changeset in webkit [55893] by
-
- 8 edits4 adds in trunk
2010-03-12 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Test for referrer information being stripped when the header is removed in willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=35920
- http/tests/security/no-referrer-expected.txt: Added.
- http/tests/security/no-referrer.html: Added.
- http/tests/security/resources/no-referrer-frame.php: Added.
- http/tests/security/resources/no-referrer.php: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
2010-03-12 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Introduce setWillSendRequestClearHeader to LayoutTestController to selectively remove headers in willSendRequest. Used in http/tests/security/no-referrer.html
https://bugs.webkit.org/show_bug.cgi?id=35920
- DumpRenderTree/LayoutTestController.cpp: (setWillSendRequestClearHeaderCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::willSendRequestClearHeaders): (LayoutTestController::setWillSendRequestClearHeader):
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
- DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest):
- 5:44 AM Changeset in webkit [55892] by
-
- 5 edits in trunk/LayoutTests
2010-03-12 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Dirk Schulze.
Update two tests, whose pixel hash fail with --tolerance 0. No visible differences.
- platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
- platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
- platform/mac/svg/custom/gradient-stop-corner-cases-expected.checksum:
- platform/mac/svg/custom/gradient-stop-corner-cases-expected.png:
Mar 11, 2010:
- 11:24 PM Changeset in webkit [55891] by
-
- 4 edits in trunk/WebCore
2010-03-11 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable network state notifier when compiling against Qt 4.7
https://bugs.webkit.org/show_bug.cgi?id=35983
- WebCore.pri:
- platform/network/qt/NetworkStateNotifierPrivate.h:
- platform/network/qt/NetworkStateNotifierQt.cpp:
- 11:07 PM Changeset in webkit [55890] by
-
- 8 edits in trunk/WebCore
2010-03-11 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Adam Treat.
Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150
The frame view take into acount the list of fixed object when scrolling
the view. If the number of object is lower than a certain threshold, the pixel
are blitted, and the invalidated area updated.
- page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject): (WebCore::FrameView::scrollContentsFastPath):
- page/FrameView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
- platform/ScrollView.h:
- rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
- rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
- 10:46 PM Changeset in webkit [55889] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-11 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888
Use TARGETING_TIGER rather than BUILDING_ON_TIGER to determine the tags.
- wtf/VMTags.h:
- 10:11 PM Changeset in webkit [55888] by
-
- 12 edits in trunk
2010-03-11 Aaron Boodman <aa@chromium.org>
Kill WebDocument::applicationID() (part 1).
Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846
- notifications/Notification.cpp: (WebCore::Notification::Notification):
- notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission):
- notifications/NotificationPresenter.h:
2010-03-11 Aaron Boodman <aa@chromium.org>
Kill WebDocument::applicationID() (part 1).
Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846
- public/WebNotificationPresenter.h:
- src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
- src/NotificationPresenterImpl.h:
- src/WebDocument.cpp: (WebKit::WebDocument::applicationID):
2010-03-11 Aaron Boodman <aa@chromium.org>
Kill WebDocument::applicationID() (part 1).
Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
- WebCoreSupport/WebDesktopNotificationsDelegate.h:
- 9:41 PM Changeset in webkit [55887] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-11 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
The JSNative state was renamed to JSPrimitive. The new name better
coresponds to the ECMAScript standard.
Enum QScriptValuePrivate::States was renamed to State to obey Qt
coding style rules ("States" name suggests that a state could
mixed together with an other state using bitwise logic operators.
[Qt] QScriptValuePrivate::States has naming issues
https://bugs.webkit.org/show_bug.cgi?id=35968
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::refinedJSValue):
- 9:24 PM Changeset in webkit [55886] by
-
- 3 edits in trunk/LayoutTests
2010-03-11 Shu Chang <Chang.Shu@nokia.com>
Reviewed by David Levin.
[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=35969
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvas-resize-reset-expected.txt:
- 8:39 PM Changeset in webkit [55885] by
-
- 2 edits in trunk/JavaScriptCore
Add export.
Reviewed by NOBODY (Windows build fix).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 8:36 PM Changeset in webkit [55884] by
-
- 2 edits in trunk/WebKitTools
2010-03-11 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed.
Fix typo in websocket_server.py
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 8:07 PM Changeset in webkit [55883] by
-
- 2 edits in trunk/JavaScriptCore
Add export.
Reviewed by NOBODY (Windows build fix).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 7:51 PM Changeset in webkit [55882] by
-
- 9 edits in trunk/WebCore
[v8] Remove obsolete code for delayed dereferencing of DOM objects for single-heap, multithread v8 usage.
https://bugs.webkit.org/show_bug.cgi?id=36043
Reviewed by David Levin.
No new tests, no changes in functionality.
- bindings/v8/DOMData.cpp:
(WebCore::DOMData::DOMData):
- bindings/v8/DOMData.h:
(WebCore::DOMData::handleWeakObject):
- bindings/v8/DOMDataStore.cpp:
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::domObjectMap):
(WebCore::DOMDataStore::activeDomObjectMap):
(WebCore::DOMDataStore::domSvgElementInstanceMap):
(WebCore::DOMDataStore::domSvgObjectWithContextMap):
- bindings/v8/ScopedDOMDataStore.cpp:
(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
- bindings/v8/StaticDOMDataStore.cpp:
(WebCore::StaticDOMDataStore::StaticDOMDataStore):
- bindings/v8/StaticDOMDataStore.h:
- bindings/v8/V8DOMMap.cpp:
(WebCore::removeAllDOMObjectsInCurrentThread):
- 7:25 PM Changeset in webkit [55881] by
-
- 4 edits in trunk
Rubber stamped by Oliver Hunt.
Remove nonsense comments used in development & commited in error.
- runtime/UStringImpl.h:
WebCore:
- platform/text/StringImpl.h:
- 7:22 PM Changeset in webkit [55880] by
-
- 2 edits in trunk/WebKitTools
2010-03-11 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Adler.
Fixing minor typo in the commit queue status page.
https://bugs.webkit.org/show_bug.cgi?id=35979
- Scripts/webkitpy/commands/queues.py:
- 7:20 PM Changeset in webkit [55879] by
-
- 2 edits in trunk/JavaScriptCore
Remove export.
Reviewed by NOBODY (Windows build fix).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 7:14 PM Changeset in webkit [55878] by
-
- 8 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=36041
Remove unnecessary differences in common code between WebCore::StringImpl & JSC::UStringImpl
Reviewed by Oliver Hunt.
Much of the code in WebCore::StringImpl and JSC::UStringImpl is now very similar,
but has trivial and unnecessary formatting differences, such as the exact wording
of comments, missing ASSERTs, functions implemented in the .h vs .cpp etc.
- runtime/Identifier.cpp:
(JSC::Identifier::add): UStringImpl::empty() now automatically hashes, uas per WebCore strings.
(JSC::Identifier::addSlowCase): UStringImpl::empty() now automatically hashes, uas per WebCore strings.
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::~UStringImpl): Only call bufferOwnership() once, add missing ASSERTs.
(JSC::UStringImpl::createUninitialized): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::create): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::sharedBuffer): Rewritten to more closely match WebCore implementation, remove need for separate baseSharedBuffer() method.
- runtime/UStringImpl.h:
(JSC::UStringImpl::UStringImpl): Automatically hash static strings, ASSERT m_data & m_length are non-null/non-zero in non-static strings.
(JSC::UStringImpl::setHash): Add missing ASSERT.
(JSC::UStringImpl::create): Moved to .cpp / added missing check for empty string creation.
(JSC::UStringImpl::adopt): Vector.size() returns size_t, not unsigned.
(JSC::UStringImpl::cost): Renamed m_bufferSubstring -> m_substringBuffer
(JSC::UStringImpl::hash): Reordered in file.
(JSC::UStringImpl::existingHash): Reordered in file.
(JSC::UStringImpl::computeHash): Reordered in file, renamed parameter.
(JSC::UStringImpl::checkConsistency): rewrote ASSERT.
(JSC::UStringImpl::bufferOwnership): Return type should be BufferOwnership.
(JSC::UStringImpl::): Moved friends to head of class.
WebCore:
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::empty): Reordered in file, made empty()->characters() return a non-null value to match JSC.
(WebCore::StringImpl::createUninitialized): Added overflow check.
(WebCore::StringImpl::create): Reordered in file.
(WebCore::StringImpl::sharedBuffer): Reordered in file.
- platform/text/StringImpl.h:
(WebCore::StringImpl::): Remove ThreadGlobalData as friend, move SharableUChar & SharedUChar to WebCore namespace.
(WebCore::StringImpl::StringImpl): Made static constructor method (used to create empty string) take arguments, to match JSC & prevent accidental use.
(WebCore::StringImpl::setHash): Added missing ASSERT.
(WebCore::StringImpl::adopt): Make adpot work with Vectors with a non-zero inline capacity.
(WebCore::StringImpl::characters): Mark as const to match JSC.
(WebCore::StringImpl::hash): Use !m_hash instead of m_hash == 0.
(WebCore::StringImpl::computeHash): Remove redundant 'inline'.
- 7:04 PM Changeset in webkit [55877] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-11 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Fix the screen coordinate conversion of Chromium Mac mouse events for
multiple-moniter setups. Also changes the global coordinate values
to be computed from the event, rather than the instantaneous mouse
location, and reduces code duplication for location conversion.
Dual-sided patch with http://codereview.chromium.org/751002
- src/mac/WebInputEventFactory.mm: (WebKit::setWebEventLocationFromEventInView): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
- 6:47 PM Changeset in webkit [55876] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-03-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Applying h1 format to text node after HR tag fails to include first letter of text node.
https://bugs.webkit.org/show_bug.cgi?id=30148
This patch adds a test case to the above bug, which has been fixed by
http://trac.webkit.org/changeset/55705.
- editing/style/heading-text-after-hr-expected.txt: Added.
- editing/style/heading-text-after-hr.html: Added.
- 6:37 PM Changeset in webkit [55875] by
-
- 2 edits in trunk/WebKitTools
2010-03-11 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed.
Fix for WebSocket layout test runner on chromium/win port.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: register_cygwin and set CYGWIN_PATH
- 6:20 PM Changeset in webkit [55874] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-11 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35917
- efl/WebCoreSupport/InspectorClientEfl.h: Added.
- efl/WebCoreSupport/InspectorClientEfl.cpp: Added.
- 6:15 PM Changeset in webkit [55873] by
-
- 4 edits3 adds in trunk/LayoutTests
Add more test cases for Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=36038
Reviewed by Dmitry Titov.
- http/tests/local/resources/abe.png: Copied from LayoutTests/editing/resources/abe.png.
- http/tests/local/resources/empty.txt: Copied from LayoutTests/http/tests/appcache/resources/empty.txt.
- http/tests/local/resources/send-sliced-dragged-file.js:
- http/tests/local/send-sliced-dragged-file-expected.txt:
- http/tests/resources/post-and-verify.cgi: Added.
- http/tests/resources/write-temp-file.php:
- 6:03 PM Changeset in webkit [55872] by
-
- 1 edit2 adds in trunk/WebKit
2010-03-11 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35914
- efl/WebCoreSupport/DragClientEfl.h: Added.
- efl/WebCoreSupport/DragClientEfl.cpp: Added.
- 5:53 PM Changeset in webkit [55871] by
-
- 10 edits in trunk
<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
Reviewed by David Kilzer.
Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.
- Configurations/Base.xcconfig:
JavaScriptGlue:
- Configurations/Base.xcconfig:
WebCore:
- Configurations/Base.xcconfig:
WebKit/mac:
- Configurations/Base.xcconfig:
WebKitTools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- 5:37 PM Changeset in webkit [55870] by
-
- 4 edits4 adds in trunk
2010-03-11 Jungshik Shin <jshin@chromium.org>
[Chromium]: Plane 2 characters are rendered "blank"
(not even empty boxes) on Windows even when there are fonts to
cover them.
Test:LayoutTests/fast/text/international/plane2.html
- platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::LookupAltName): Add two ExtB fonts to the array (namePairs) that are used for Plane 2 character rendering. (WebCore::FontCache::getFontDataForCharacters): Add two more fonts to the fallback font list
- platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::getFallbackFamily): Fix the fallback font lookup to cover Plane 2 (CJK ExtB).
- 5:20 PM Changeset in webkit [55869] by
-
- 1 edit1 add in trunk/WebCore
2010-03-11 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35889
- platform/efl/SystemTimeEfl.cpp: Added.
- 4:50 PM Changeset in webkit [55868] by
-
- 2 edits in trunk/WebKitTools
2010-03-11 Victor Wang <victorw@chromium.org>
Reviewed by Dimitri Glazkov.
rebaseline_chromium_webkit_tests can generate new baselines for
all platforms so it needs to know two ports in order to work correctly:
the port that the script is running on and the port that it generates
new baselines for. Update rebaselining tool to handle both port correctly.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 4:44 PM Changeset in webkit [55867] by
-
- 26 edits in trunk
<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
Reviewed by Tim Hatcher.
Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
current Mac OS X version unless otherwise specified.
Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.
Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
may not be usable when targetting a different Mac OS X version.
Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/Version.xcconfig:
JavaScriptGlue:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebCore.xcconfig:
WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
WebKitTools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- DumpRenderTree/mac/DumpRenderTree.mm: Wrap the include of mach-o/getsect.h in 'extern "C"' as some versions of the
header in older SDKs do not do this inside the header.
- 4:40 PM Changeset in webkit [55866] by
-
- 14 edits in trunk/WebKit/chromium
2010-03-10 Darin Fisher <darin@chromium.org>
Reviewed by Jeremy Orlow.
Use WebPrivatePtr for WebNode
https://bugs.webkit.org/show_bug.cgi?id=36005
- public/WebElement.h:
- public/WebFormElement.h:
- public/WebInputElement.h:
- public/WebLabelElement.h:
- public/WebNode.h: (WebKit::WebNode::WebNode): (WebKit::WebNode::isNull): (WebKit::WebNode::unwrap): (WebKit::WebNode::constUnwrap):
- public/WebPrivatePtr.h: (WebKit::WebPrivatePtr::assign):
- src/WebDocument.cpp: (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::operator PassRefPtr<Document>):
- src/WebElement.cpp: (WebKit::WebElement::hasTagName): (WebKit::WebElement::WebElement): (WebKit::WebElement::operator=): (WebKit::WebElement::operator PassRefPtr<Element>):
- src/WebFormElement.cpp: (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::operator PassRefPtr<HTMLFormElement>):
- src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::operator PassRefPtr<HTMLInputElement>):
- src/WebLabelElement.cpp: (WebKit::WebLabelElement::correspondingControl): (WebKit::WebLabelElement::operator=): (WebKit::WebLabelElement::operator PassRefPtr<HTMLLabelElement>):
- src/WebNode.cpp: (WebKit::WebNode::reset): (WebKit::WebNode::assign): (WebKit::WebNode::equals): (WebKit::WebNode::parentNode): (WebKit::WebNode::createMarkup): (WebKit::WebNode::addEventListener): (WebKit::WebNode::removeEventListener): (WebKit::WebNode::simulateClick): (WebKit::WebNode::WebNode): (WebKit::WebNode::operator=): (WebKit::WebNode::operator PassRefPtr<Node>):
- 4:27 PM Changeset in webkit [55865] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Added the test that time out on Tiger bot to mac-tiger/Skipped.
- platform/mac-tiger/Skipped:
- 4:09 PM Changeset in webkit [55864] by
-
- 27 edits in trunk
Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
Reviewed by David Hyatt.
WebCore:
- loader/EmptyClients.h:
- page/Chrome.cpp:
- page/Chrome.h:
- page/ChromeClient.h:
- platform/HostWindow.h:
WebKit/chromium:
- src/ChromeClientImpl.cpp:
- src/ChromeClientImpl.h:
WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ChromeClientGtk.h:
WebKit/haiku:
- WebCoreSupport/ChromeClientHaiku.cpp:
- WebCoreSupport/ChromeClientHaiku.h:
WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
WebKit/qt:
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/ChromeClientQt.h:
WebKit/win:
- WebCoreSupport/WebChromeClient.cpp:
- WebCoreSupport/WebChromeClient.h:
WebKit/wx:
- WebKitSupport/ChromeClientWx.cpp:
- WebKitSupport/ChromeClientWx.h:
- 4:03 PM Changeset in webkit [55863] by
-
- 3 edits in trunk/LayoutTests
2010-03-11 Simon Fraser <Simon Fraser>
No review.
Need to turn on WebGL explicitly for these tests for Leopard.
- compositing/webgl/webgl-background-color.html:
- compositing/webgl/webgl-reflection.html:
- 4:03 PM Changeset in webkit [55862] by
-
- 9 edits1 delete in trunk/WebCore
2010-03-11 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Remove DOMObjectsInclude.h and update headers accordingly.
- WebCore.gypi:
- bindings/v8/DOMData.h:
- bindings/v8/DOMDataStore.h:
- bindings/v8/DOMObjectsInclude.h: Removed.
- bindings/v8/V8DOMMap.cpp:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8GCController.cpp:
- bindings/v8/V8Proxy.cpp:
- 4:02 PM Changeset in webkit [55861] by
-
- 7 edits2 adds in trunk
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=35965
<rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in
Test: plugins/round-trip-npobject.html
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Corrected the check - there is now a separate ProxyRuntimeObject class for proxy pbjects. (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Check if m_instanceProxy is still non-zero. The plug-in could have crashed while we were waiting for response. (WebKit::ProxyInstance::setFieldValue): Ditto.
- 3:57 PM Changeset in webkit [55860] by
-
- 2 edits in trunk/WebCore
2010-03-11 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
Remove duplicate entries revealed after sorting.
- WebCore.xcodeproj/project.pbxproj:
- 3:35 PM Changeset in webkit [55859] by
-
- 6 edits in trunk
2010-03-11 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
Sort the project files, also fixing some bogus spaces in the WebCore project.
- 3:14 PM Changeset in webkit [55858] by
-
- 6 edits in trunk/LayoutTests
Make appcache layouttests top-frame-*.html more robust for async checking event
https://bugs.webkit.org/show_bug.cgi?id=32047
Reviewed by Alexey Proskuryakov.
Modified the tests to watch for all termination conditions, eliminating the hardcoded
assumed order of the events from separate async event sources.
Also added check for "noupdate" event.
- http/tests/appcache/top-frame-2.html: Modified to be consistent with the other 2 tests.
- http/tests/appcache/top-frame-3-expected.txt:
- http/tests/appcache/top-frame-3.html: Used logic similar to top-frame-2.html to avoid assumption of the events order.
- http/tests/appcache/top-frame-4-expected.txt:
- http/tests/appcache/top-frame-4.html: Ditto.
- 3:13 PM Changeset in webkit [55857] by
-
- 2 edits in trunk/WebKitTools
2010-03-11 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=35905
REGRESSION(55699?): media/video-no-autoplay.html times out on Leopard Commit Bot
Make sure we reset the WebGL preference, so that WebGL doesn't get left
on after being enabled via layoutTestController.overridePreference(),
which in turn causes accelerated compositing to be enabled on Leopard
when we don't want it to be.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 2:42 PM Changeset in webkit [55856] by
-
- 2 edits in trunk/WebCore
2010-03-11 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Fix style issues and improve comments from
http://trac.webkit.org/changeset/55853.
- platform/animation/TimingFunction.h: (WebCore::TimingFunction::TimingFunction):
- 2:24 PM Changeset in webkit [55855] by
-
- 16 edits in trunk/WebCore
accessibilityIsIgnoredBase() needs to respect when platform says include
https://bugs.webkit.org/show_bug.cgi?id=36025
Reviewed by Beth Dakin.
Changed accessibilityIsIgnoredBase() to return a policy instead of a yes/no
answer. This allows the platform to make a yes decision on an element.
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::accessibilityIsIgnored):
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::accessibilityIsIgnored):
- accessibility/AccessibilityObject.h:
(WebCore::):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::accessibilityIsIgnored):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::accessibilityIsIgnored):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::accessibilityIsIgnored):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::accessibilityIsIgnored):
- accessibility/chromium/AccessibilityObjectChromium.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/qt/AccessibilityObjectQt.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/win/AccessibilityObjectWin.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/wx/AccessibilityObjectWx.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- 1:39 PM Changeset in webkit [55854] by
-
- 3 edits in trunk/WebCore
2010-03-11 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Fix build breakage with ENABLE_3D_CANVAS=0
https://bugs.webkit.org/show_bug.cgi?id=35995
No new tests; verified in Chromium that WebGL is disabled in
ENABLE_3D_CANVAS=0 builds.
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
- 12:24 PM Changeset in webkit [55853] by
-
- 2 edits in trunk/WebCore
2010-03-11 Nate Chapin <Nate Chapin>
Unreviewed, Chromium mac build fix.
Add an explicit copy constructor to TimingFunction.
http://trac.webkit.org/changeset/55835 trigged an inlining
bug in gcc that the copy constructor resolves.
- platform/animation/TimingFunction.h: (WebCore::TimingFunction::TimingFunction):
- 12:18 PM Changeset in webkit [55852] by
-
- 3 edits1 add4 deletes in trunk/LayoutTests
2010-03-11 Martin Robinson <Martin Robinson>
Reviewed by Adam Barth
Convert editing/selection/5136696.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=34306
- editing/selection/5136696-expected.txt: Added.
- editing/selection/5136696.html: Use dumpAsText now.
- platform/gtk/Skipped: Unskip this test in GTK+ now that it has expected result.
- platform/mac/editing/selection/5136696-expected.checksum: Removed.
- platform/mac/editing/selection/5136696-expected.png: Removed.
- platform/mac/editing/selection/5136696-expected.txt: Removed.
- platform/qt/editing/selection/5136696-expected.txt: Removed.
- platform/win/editing/selection/5136696-expected.txt: Removed.
- 12:01 PM Changeset in webkit [55851] by
-
- 2 edits in trunk
Teach git about ObjC files
Fixes <http://webkit.org/b/36015>.
Reviewed by Tim Hatcher.
- .gitattributes: Set the diff attribute for .m and .mm files, and .h
files in Mac-specific directories. This can be used to generate
more-readable diffs of ObjC files.
- 11:56 AM Changeset in webkit [55850] by
-
- 4 edits in trunk/WebKitTools
2010-03-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
rebaseline_chromium_webkit_tests doesn't handle other plaforms
correctly (e.g., if you run on the Mac platform and try to
rebaseline the WIN results, the result gets written into
platform/mac instead of platform/chromium-win). Also, this script
doesn't work on non-Chromium ports, so we need to fix that at some
point.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 11:28 AM Changeset in webkit [55849] by
-
- 2 edits in trunk/WebCore
Fixing GTK. No review.
support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021
We don't need to cast to AccessibilityRenderObject to get language().
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_document_get_locale):
- 11:19 AM Changeset in webkit [55848] by
-
- 8 edits2 adds in trunk
support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021
Reviewed by Darin Adler.
WebCore:
Allow non AccessibilityRenderObject classes to access the lang
attribute by moving the useful code into AccessibilityObject.
Test: platform/mac/accessibility/option-with-lang.html
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::language):
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::language):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::language):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
- platform/mac/accessibility/option-with-lang-expected.txt: Added.
- platform/mac/accessibility/option-with-lang.html: Added.
- 10:48 AM Changeset in webkit [55847] by
-
- 4 edits in trunk
[Qt] Access key modifier should be Ctrl+Alt for Darwin derived OS and Alt for the others
https://bugs.webkit.org/show_bug.cgi?id=35993
Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-11
Reviewed by Simon Hausmann.
WebCore:
- page/qt/EventHandlerQt.cpp:
(WebCore::EventHandler::accessKeyModifiers):
LayoutTests:
- platform/qt/Skipped:
- 10:38 AM Changeset in webkit [55846] by
-
- 3 edits in trunk
010-03-08 Brett Wilson <brettw@chromium.org>
Reviewed by Adam Barth.
Remove the deprecated argument to url_util::IsStandard in preparation
for deleting that version of the function. Pull the latest googleurl
with the new version for the Chromium builder.
- platform/KURLGoogle.cpp: (WebCore::KURL::isHierarchical):
- 9:02 AM BuildingQtOnSymbian edited by
- (diff)
- 9:00 AM BuildingQtOnSymbian edited by
- running on HW issues (diff)
- 8:03 AM Changeset in webkit [55845] by
-
- 2 edits in trunk/WebCore
[Qt] Make it possible to do builds with separate debug info in packages
Reviewed by Tor Arne Vestbø.
- WebCore.pro:
- 8:03 AM Changeset in webkit [55844] by
-
- 2 edits in trunk/WebCore
[Qt] Avoid double-buffering with Qt image decoders
Reviewed by Tor Arne Vestbø.
Pass QIODevice::Unbuffered when opening the QBuffer that
wraps the image data, to hint to Qt that no extra buffering
is needed.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
- 7:25 AM Changeset in webkit [55843] by
-
- 4 edits in trunk/WebCore
[Android] The platform touch events on Android are missing support
for key modifiers.
https://bugs.webkit.org/show_bug.cgi?id=35521
Reviewed by Jeremy Orlow.
Add support in PlatformToucHEventAndroid for the platform supplying
key modifiers with touch events.
Fixes Android so it now passes basic-single-touch-events.html.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Fix two compiler warnings.
- platform/PlatformTouchEvent.h:
(WebCore::PlatformTouchEvent::PlatformTouchEvent): Add support for
key modifiers on Android.
- platform/android/PlatformTouchEventAndroid.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent): ditto.
- 6:40 AM Changeset in webkit [55842] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986
Wrong files were placed in skipped lists.
- platform/gtk/Skipped:
- 3:38 AM Changeset in webkit [55841] by
-
- 5 edits3 adds in trunk
2010-03-10 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Implements Geolocation maximumAge property
https://bugs.webkit.org/show_bug.cgi?id=30676
Test: fast/dom/Geolocation/maximum-age.html
- WebCore.xcodeproj/project.pbxproj: Modified. Adds GeolocationPositionCache.h to Private headers
- page/Geolocation.cpp: Modified. (WebCore::Geolocation::GeoNotifier::setUseCachedPosition): Added. (WebCore::Geolocation::GeoNotifier::runSuccessCallback): Added. (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Added logic to handle using a cached position (WebCore::Geolocation::Watchers::contains): Added. Required to determine if a notifier is a watch request (WebCore::Geolocation::startRequest): Modified. Added logic to check for a cached position (WebCore::Geolocation::requestUsesCachedPosition): Added. Callback to Geolocation object when notifier uses a cached position (WebCore::Geolocation::makeCachedPositionCallbacks): Added. (WebCore::Geolocation::haveSuitableCachedPosition): Added. (WebCore::Geolocation::setIsAllowed): Modified. (WebCore::Geolocation::positionChanged): Modified. Make callbacks using cached position where appropriate (WebCore::Geolocation::geolocationServiceErrorOccurred): Modified. Make callbacks using cached position where appropriate
- page/Geolocation.h: Modified.
2010-03-10 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Implements Geolocation maximumAge property
https://bugs.webkit.org/show_bug.cgi?id=30676
- fast/dom/Geolocation/resources/maximum-age.js: Added. Checks that a cached position is used only when it should be.
- fast/dom/Geolocation/maximum-age.html: Added. HTML wraper for above test.
- fast/dom/Geolocation/maximum-age-expected.txt: Added. Expected result for above test.
- 2:57 AM Changeset in webkit [55840] by
-
- 2 edits in trunk/LayoutTests
2010-03-11 Philippe Normand <pnormand@igalia.com>
Unreviewed.
Unskip the fixed test that was (accidently?) re-skipped in r54205.
- platform/gtk/Skipped:
- 2:25 AM Changeset in webkit [55839] by
-
- 2 edits in trunk/LayoutTests
[Qt] storage/open-database-creation-callback-isolated-world.html was introduced in r55823,
but layoutTestController.evaluateScriptInIsolatedWorld() is unimplemented now.
- platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped.
- 2:16 AM Changeset in webkit [55838] by
-
- 2 edits in trunk/WebCore
Unreviewed buildfix after r55823. (To fix Qt --minimal build.)
I have déjà vu, I'm sure that I did it before. (r55598)
- bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added.
- 1:43 AM Changeset in webkit [55837] by
-
- 3 edits in trunk/WebCore
[Qt] Unreviewed buildfix after r55833.
Rename all instances of data() to characters()
- bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fieldNamed):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
- 1:29 AM Changeset in webkit [55836] by
-
- 2 edits in trunk/WebCore
2010-03-11 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
Allow custom memory allocation control for RenderLayerBacking class
https://bugs.webkit.org/show_bug.cgi?id=35857
Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
RenderLayerBacking - rendering/RenderLayer.cpp:3047
- rendering/RenderLayerBacking.h:
- 12:41 AM Changeset in webkit [55835] by
-
- 2 edits in trunk/WebCore
2010-03-11 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
Allow custom memory allocation control for TimingFunction struct
https://bugs.webkit.org/show_bug.cgi?id=35855
Inherits the following struct from FastAllocBase because it is
instantiated by 'new':
class name - instantiated at: WebCore/'location'
TimingFuction - platform/graphics/GraphicsLayer.h:89
- platform/animation/TimingFunction.h:
Mar 10, 2010:
- 11:53 PM Changeset in webkit [55834] by
-
- 3 edits in trunk/JavaScriptCore
Buildfix for Thumb-2 after r55684. Add branch8 and branchTest8 functions.
https://bugs.webkit.org/show_bug.cgi?id=35892
Reviewed by Gavin Barraclough.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::ldrb):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load8):
(JSC::MacroAssemblerARMv7::branch8):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::setTest8):
- 11:19 PM Changeset in webkit [55833] by
-
- 15 edits in trunk
Rubber stamped by Oliver Hunt.
Rename JSC::UStringImpl::data() to characters(), to match WebCore::StringImpl.
- API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::keyForCharacterSwitch):
- bytecompiler/NodesCodegen.cpp:
(JSC::processClauseList):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::Identifier::addSlowCase):
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
- runtime/UString.cpp:
(JSC::UString::toStrictUInt32):
(JSC::equal):
- runtime/UString.h:
(JSC::UString::data):
- runtime/UStringImpl.h:
(JSC::UStringImpl::characters):
(JSC::UStringImpl::hash):
(JSC::UStringImpl::setHash):
WebCore:
- bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::uchars):
- platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
- 11:07 PM Changeset in webkit [55832] by
-
- 2 edits in trunk/WebCore
Fix for r55825, threadsafeCopy no longer needs to special-case for
empty strings (in fact, doing so results in leaks).
Reviewed by Mark Rowe.
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::threadsafeCopy):
- 9:30 PM Changeset in webkit [55831] by
-
- 3 edits in trunk/LayoutTests
Unreviewed.
VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986
Wrong files were placed in skipped lists.
- platform/gtk/Skipped:
- platform/win/Skipped:
- 9:06 PM Changeset in webkit [55830] by
-
- 3 edits in trunk/LayoutTests
Unreviewed.
VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986
Skip this test since it uses tables and lists, which are not
supported on Tiger/Leopard.
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- 8:09 PM Changeset in webkit [55829] by
-
- 2 edits in trunk/WebKitTools
2010-03-10 Daniel Bates <dbates@rim.com>
Reviewed by Simon Hausmann.
Updates the subroutine builtDylibPathForName() so that it adds the "d" suffix to
the QtWebKit library name on Windows. This change makes run-launcher work again
under Windows. Moreover, this change corresponds to the change made in change-
set 53924 <http://trac.webkit.org/changeset/53924>.
- Scripts/webkitdirs.pm:
- 8:05 PM Changeset in webkit [55828] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Windows build fix - add an missing symbol to be exported
- 7:23 PM Changeset in webkit [55827] by
-
- 6 edits in trunk
2010-03-10 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
While calculating alpha channel, convert the floating point value to
an integer in [0, 256) with equal distribution.
https://bugs.webkit.org/show_bug.cgi?id=22150
- css/CSSParser.cpp: (WebCore::CSSParser::parseColorParameters):
2010-03-10 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
While calculating alpha channel, convert the floating point value to
an integer in [0, 256) with equal distribution.
Updated test results based on this new behavior.
https://bugs.webkit.org/show_bug.cgi?id=22150
- fast/canvas/canvas-alphaImageData-behavior-expected.txt:
- fast/canvas/canvas-alphaImageData-behavior.js:
- platform/qt/Skipped:
- 6:38 PM Changeset in webkit [55826] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-03-10 Adam Barth <abarth@webkit.org>
Unreviewed.
http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349
Remove another test that has the same problem. We need to find a way
to relaibly test what happens when you mix JavaScript URLs and
window.open.
- http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char-expected.txt: Removed.
- http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html: Removed.
- 6:36 PM Changeset in webkit [55825] by
-
- 13 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=35991
Would be faster to not use a thread specific to implement StringImpl::empty()
Reviewed by Darin Adler, Geoffrey Garen, Maciej Stachowiak.
Change JSC::UStringImpl's implementation of empty() match to match StringImpl's new implementation
(use a static defined within the empty() method), and change the interface to match too (return
a pointer not a reference).
~0% performance impact (possible minor progression from moving empty() from .h to .cpp).
- JavaScriptCore.exp:
- runtime/Identifier.cpp:
(JSC::Identifier::add):
(JSC::Identifier::addSlowCase):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::empty):
(JSC::UStringImpl::create):
- runtime/UStringImpl.h:
(JSC::UStringImpl::adopt):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):
WebCore:
Copy JavaScriptCore in making 'static' strings threadsafe, make the empty string a static,
shared by all threads.
~2% progression on Dromaeo DOM core & JS lib tests.
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
- platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::eventNames):
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::empty):
- platform/text/StringImpl.h:
(WebCore::StringImpl::deref):
(WebCore::StringImpl::hasOneRef):
- 6:19 PM Changeset in webkit [55824] by
-
- 5 edits in trunk/WebKit/mac
2010-03-10 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35975
<rdar://problem/7739922> Flash 10.1b crashes when generating snapshots
Do a version check before sending a drawRect event to a Flash plugin,
since 10.1.d51 has a bug that crashes when called this way.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]):
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView supportsSnapshotting]):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]):
- 6:18 PM Changeset in webkit [55823] by
-
- 21 edits9 adds in trunk
WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().
Reviewed by Adam Barth.
Tests: storage/open-database-creation-callback.html
storage/open-database-creation-callback-isolated-world.html
https://bugs.webkit.org/show_bug.cgi?id=34726
- Android.jscbindings.mk
- Android.v8bindings.mk
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
- bindings/js/JSDatabaseCallback.cpp: Added.
(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):
- bindings/js/JSDatabaseCallback.h: Added.
(WebCore::JSDatabaseCallback::create):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- bindings/v8/custom/V8DatabaseCallback.cpp: Added.
(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):
- bindings/v8/custom/V8DatabaseCallback.h: Added.
(WebCore::V8DatabaseCallback::create):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/Database.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):
- storage/Database.h:
(WebCore::Database::isNew):
- storage/DatabaseCallback.h: Added.
(WebCore::DatabaseCallback::~DatabaseCallback):
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
- workers/WorkerContext.h:
LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.
Reviewed by Adam Barth.
Also, fixing fast/frames/sandboxed-iframe-storage.html: calling
openDatabase() without at least 4 parameters should always fail,
because the database name, version, description and estimated size
are not optional according to the spec.
https://bugs.webkit.org/show_bug.cgi?id=34726
- fast/frames/resources/sandboxed-iframe-storage-allowed.html:
- fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
- fast/frames/sandboxed-iframe-storage-expected.txt:
- platform/qt/Skipped:
- storage/open-database-creation-callback-expected.txt: Added.
- storage/open-database-creation-callback.html: Added.
- storage/open-database-creation-callback-isolated-world-expected.txt: Added.
- storage/open-database-creation-callback-isolated-world.html: Added.
- 6:07 PM Changeset in webkit [55822] by
-
- 3 edits2 adds in trunk
2010-03-10 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Make Chrome consistently handle leading format characters in URLs
- http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char-expected.txt: Added.
- http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html: Added.
2010-03-10 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Make Chrome consistently handle leading format characters in URLs
Test: http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html
- platform/KURLGoogle.cpp:
- 5:19 PM Changeset in webkit [55821] by
-
- 14 edits2 adds in trunk/WebCore
Implementing DOMFormData class.
https://bugs.webkit.org/show_bug.cgi?id=35707
Reviewed by Dmitry Titov.
This patch only addresses the implementation of DOMFormData class and
moves the FormData construction logic from HTMLFormElement::createFormData
to FormData::create() so that it can be used by both HTMLFormElement
and XMLHttpRequest.
The DOMFormData IDL interface will be exposed in another patch and the
test will be added then.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/DOMFormData.cpp: Added.
- html/DOMFormData.h: Added.
- html/FormDataList.h:
(WebCore::FormDataList::encoding):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::createFormData):
(WebCore::HTMLFormElement::submit):
- html/HTMLFormElement.h:
- platform/network/FormData.cpp:
(WebCore::FormData::create):
(WebCore::FormData::createMultiPart):
(WebCore::FormData::appendDOMFormData):
- platform/network/FormData.h:
(WebCore::FormData::boundary):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
- xml/XMLHttpRequest.h:
- 4:59 PM Changeset in webkit [55820] by
-
- 4 edits3 adds in trunk/WebKit/chromium
2010-03-10 Darin Fisher <darin@chromium.org>
Reviewed by Jeremy Orlow.
Add API wrapper for WebCore::SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=35988
WebSerializedScriptValue is a wrapper around SerializedScriptValue.
WebPrivatePtr is used to simplify wrapping reference counted WebCore
types. This class is used to cleanup WebHistoryItem, and will be used
to clean up other classes in the WebKit API in a follow-up patch.
- WebKit.gyp:
- public/WebHistoryItem.h:
- public/WebPrivatePtr.h: Added.
- public/WebSerializedScriptValue.h: Added.
- src/WebHistoryItem.cpp:
- src/WebSerializedScriptValue.cpp: Added.
- 4:43 PM Changeset in webkit [55819] by
-
- 3 edits in trunk/LayoutTests
Skipping test on GTK and WIN. No Review.
VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986
Thought this test might pass on the other platforms, but no.
- platform/gtk/Skipped:
- platform/win/Skipped:
- 4:36 PM Changeset in webkit [55818] by
-
- 18 edits2 adds in trunk
VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986
Reviewed by Beth Dakin.
WebCore:
Elements that are subclassers of AXRenderObject have not been respecting
aria-hidden and other cases that would make them ignored. This applies
to tables, rows, cells, select boxes, sliders, and lists. Select boxes
also need to make sure their option elements respect aria-hidden as well.
Test: accessibility/aria-hidden-with-elements.html
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::accessibilityIsIgnored):
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::addChildren):
(WebCore::AccessibilityListBox::accessibilityIsIgnored):
(WebCore::AccessibilityListBox::doAccessibilityHitTest):
- accessibility/AccessibilityListBox.h:
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::accessibilityIsIgnored):
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredCommon):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::accessibilityIsIgnored):
- accessibility/AccessibilitySlider.h:
(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::accessibilityIsIgnored):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::accessibilityIsIgnored):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
- accessibility/AccessibilityTableColumn.h:
(WebCore::AccessibilityTableColumn::roleValue):
- accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
- accessibility/AccessibilityTableHeaderContainer.h:
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::accessibilityIsIgnored):
LayoutTests:
- accessibility/aria-hidden-with-elements-expected.txt: Added.
- accessibility/aria-hidden-with-elements.html: Added.
- 4:14 PM Changeset in webkit [55817] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, fixing Snow Leopard build.
- wtf/mac/MainThreadMac.mm: Forgot 'static' for a new local function.
(WTF::postTimer):
- 4:08 PM Changeset in webkit [55816] by
-
- 7 edits in trunk
Make Document::postTask to use a single queue of tasks, to fire them in order
https://bugs.webkit.org/show_bug.cgi?id=35943
Reviewed by Darin Adler.
The patch uses CFRunLoopTimer to schedule execution of tasks instead of performSelectorOnMainThread which apparently can starve other event sources.
The timer is used when the schedule request is coming on the main thread itself. This happens when the task is posted on the main thread or
when too many tasks are posted and the queue does 'stop and re-schedule' to make sure run loop has a chance to execute other events.
- wtf/mac/MainThreadMac.mm:
(WTF::timerFired):
(WTF::postTimer):
(WTF::scheduleDispatchFunctionsOnMainThread): Use timer posted to the current RunLoop if scheduling the task execution while on the main thread.
WebCore:
Test: existing worker-cloneport.html which was broken by initial patch in http://trac.webkit.org/changeset/55593.
Additional test which indirectly verifies the order of execution will come as part of https://bugs.webkit.org/show_bug.cgi?id=34726
- dom/Document.cpp:
(WebCore::Document::postTask): Always use the same task queue, independent of what thread is posting the task.
LayoutTests:
Updated the test since the order of events coming from independent task sources has changed.
This is a behavior change, but is consistent with the spec (which specifically says these events may be fired
in any order) and the last version of FF (3.5.8) which was completing the test successfully.
- http/tests/appcache/top-frame-2-expected.txt:
- http/tests/appcache/top-frame-2.html:
- 3:40 PM Changeset in webkit [55815] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: added new symbol.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:28 PM Changeset in webkit [55814] by
-
- 10 edits in trunk
2010-03-10 Sanjeev Radhakrishnan <sanjeevr@chromium.org>
Reviewed by Darin Fisher.
Allow a plugin to participate in the browser's print workflow.
https://bugs.webkit.org/show_bug.cgi?id=35550
- loader/PluginDocument.cpp:
- loader/PluginDocument.h:
- 3:27 PM Changeset in webkit [55813] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: removed old symbol.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:19 PM Changeset in webkit [55812] by
-
- 1 edit4 adds in trunk/WebKit
2010-03-10 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35913
- efl/WebCoreSupport/ChromeClientEfl.cpp: Added.
- efl/WebCoreSupport/ChromeClientEfl.h: Added.
- 3:11 PM Changeset in webkit [55811] by
-
- 5 edits in trunk/JavaScriptCore
Refactored fastCheckConsistency to match some review comments:
- renamed fastCheckConsistency to fastMallocSize, and changed ValueCheck to ASSERT that a pointer's fastMallocSize is not 0.
- implemented a version of fastMallocSize for tcmalloc.
Reviewed by Alexey Proskuryakov, Darin Adler, and Sam Weinig.
Also moved some pre-existing code around to avoid a problem related to
mismatched #define/#undef of malloc/free in this source file.
- JavaScriptCore.exp:
- wtf/FastMalloc.cpp:
(WTF::fastMallocSize): Renamed. Fixed indentation.
(WTF::TCMalloc_PageHeap::scavenge): Removed an incorrect ASSERT that
got in the way of testing the tcmalloc implementation. (More information
on why this ASSERT is incorrect is in <rdar://problem/7165917>.)
(WTF::TCMallocStats::fastMallocSize): Implemented for tcmalloc.
- wtf/FastMalloc.h: Updated for rename.
- wtf/ValueCheck.h:
(WTF::): Moved the ASSERT that used to be in fastCheckConsistency here.
- 3:00 PM Changeset in webkit [55810] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-10 John Abd-El-Malek <jam@chromium.org>
Reviewed by Nate Chapin.
[chromium]: Fix regression in mouse capture on Mac/Linux
https://bugs.webkit.org/show_bug.cgi?id=35987
- src/WebViewImpl.cpp:
- 2:44 PM Changeset in webkit [55809] by
-
- 2 edits in trunk/WebKit/win
2010-03-10 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
The build fix for my patch on bug #35763 wasn't quite right--it removed
the call entirely, instead of replacing it with the new API. This adds
the call to Database::setIsAvailable.
- WebView.cpp: Added a call to Database::setIsAvailable where change 55667 removed the old Settings API call <http://trac.webkit.org/changeset/55667>. (WebView::notifyPreferencesChanged):
- 2:26 PM Changeset in webkit [55808] by
-
- 5 edits in trunk/WebKit/chromium
2010-03-10 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
[chromium] add functionality to activate the focused node in a WebView
https://bugs.webkit.org/show_bug.cgi?id=35407
- public/WebDocument.h:
- public/WebNode.h:
- src/WebDocument.cpp: (WebKit::WebDocument::focusedNode): Added
- src/WebNode.cpp: (WebKit::WebNode::simulateClick): Added
- 2:19 PM Changeset in webkit [55807] by
-
- 2 edits in trunk/WebKitTools
Roll out the prepare-ChangeLog part of r55870
This change wasn't needed (prepare-ChangeLog calls svn-create-patch
when it's asked to print out diffs for the user) and was screwing up
its ability to find changed function names.
- Scripts/prepare-ChangeLog:
(diffCommand): Change the options we pass to svn-diff back to their
pre-r55870 form.
- 2:09 PM Changeset in webkit [55806] by
-
- 2 edits in trunk/WebCore
2010-03-10 Ilya Tikhonovsky <loislo@loislo-macbookpro.local>
Reviewed by Pavel Feldman.
Sidebar resize element height was adjusted.
Display name for Function Call details was adjusted.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- 1:59 PM Changeset in webkit [55805] by
-
- 5 edits in trunk/WebKit/chromium
2010-03-10 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=35952
Propagate mouse wheel events to Pepper plugins.
- src/WebInputEventConversion.cpp: (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
- src/WebInputEventConversion.h:
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleEvent): (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleWheelEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
- src/WebPluginContainerImpl.h:
- 1:58 PM Changeset in webkit [55804] by
-
- 2 edits in trunk/LayoutTests
2010-03-10 Antonio Gomes <tonikitoo@webkit.org>
The test was introduced in r55796, it has been failing in Gtk bots since then.
- platform/gtk/Skipped: fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html skipped until fix.
- 1:55 PM Changeset in webkit [55803] by
-
- 9 edits in trunk
2010-03-10 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT
Unskip test fast/events/multiline-link-arrow-navigation.html
- platform/qt/Skipped:
2010-03-10 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT
Unskip test fast/events/multiline-link-arrow-navigation.html
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): (LayoutTestController::setCaretBrowsingEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
2010-03-10 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT
Unskip test fast/events/multiline-link-arrow-navigation.html
Fix typo (superfluous space) in QWebSettings docs.
- Api/qwebpage.cpp: (qt_drt_enableCaretBrowsing):
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): fix typo in docs
- 1:52 PM Changeset in webkit [55802] by
-
- 3 edits in trunk/WebCore
2010-03-10 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos.
Fix https://bugs.webkig.org/show_bug.cgi?id=35207
When XHTMLMP is enabled, all xhtml documents fail to render for webkit portings wich use libxml2 tokenizer.
No new tests as all the xhtml test cases in LayoutTests/dom/xhtml fails without this fix when XHTMLMP is enabled.
- dom/Document.cpp: (WebCore::Document::isXHTMLMPDocument):
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::internalSubset): (WebCore::externalSubsetHandler):
- 1:34 PM Changeset in webkit [55801] by
-
- 5 edits1 add in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=35977
Reviewed by Sam Weinig.
Turns out the previous attempt to clear/reset cookies wasn't working because of the way
the URLs for the .js and its .cgi were being resolved.
So this is a better way to make the cookies consistent both before and after these tests.
If this fails to make cookie-related tests reliable, then we might have to bite the bullet
and give DRT itself the ability to forcibly remove cookies via API methods.
This would be bulletproof and could be automatic if a test declares itself "cookie sensitive"
but we'd lose the ability to reliably run these tests in the browser. :(
- http/tests/cookies/resources/resetCookies.js: Added.
- http/tests/cookies/resources/third-party-cookie-relaxing-iframe.html:
- http/tests/cookies/third-party-cookie-relaxing.html:
- http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html:
- http/tests/plugins/third-party-cookie-accept-policy.html:
- 1:34 PM Changeset in webkit [55800] by
-
- 6 edits in trunk
2010-03-10 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Adding all of the touch-related sources into Chromium's WebCore build.
https://bugs.webkit.org/show_bug.cgi?id=35874
Patch tested against the try bots, but the feature is exercised in the
fast/events/touch tests.
- WebCore.gypi:
2010-03-10 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Add support for converting WebTouchEvents to PlatformTouchEvents and
routing them into the EventHandler for the frame in which they
originate.
https://bugs.webkit.org/show_bug.cgi?id=35874
- src/ChromeClientImpl.h: (WebKit::ChromeClientImpl::needTouchEvents):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::touchEvent): Handle incoming WebTouchEvents, converting them to PlatformTouchEvents and sending them to the EventHandler. (WebKit::WebViewImpl::handleInputEvent): Now routes WebTouchEvents to the touchEvent handler.
- src/WebViewImpl.h:
- 12:37 PM Changeset in webkit [55799] by
-
- 6 edits in trunk/WebCore
2010-03-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: now that audits panel is added, add it to the
enums (for storing last active, etc.).
- inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::specialPanelForJSName):
- inspector/InspectorController.h: (WebCore::InspectorController::):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):
- inspector/front-end/inspector.js: (WebInspector.showAuditsPanel):
- 12:34 PM QtWebKitBugs edited by
- (diff)
- 12:33 PM Changeset in webkit [55798] by
-
- 49 edits1 delete in trunk
2010-03-10 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Instead of describing the type of a wrapped v8 object
with an enum value, use a pointer to struct with more complete
information.
Refactoring only, so new tests.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMData.cpp:
- bindings/v8/DOMData.h:
- bindings/v8/NPV8Object.cpp:
- bindings/v8/V8Collection.h:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8GCController.cpp:
- bindings/v8/V8Helpers.cpp:
- bindings/v8/V8Helpers.h:
- bindings/v8/V8Index.cpp: Removed.
- bindings/v8/V8Index.h:
- bindings/v8/V8NPObject.cpp:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
- bindings/v8/custom/V8HTMLAudioElementConstructor.h:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
- bindings/v8/custom/V8HTMLImageElementConstructor.h:
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
- bindings/v8/custom/V8HTMLOptionElementConstructor.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- bindings/v8/custom/V8MessageChannelConstructor.cpp:
- bindings/v8/custom/V8SharedWorkerCustom.cpp:
- bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
- bindings/v8/custom/V8WebGLArrayCustom.h:
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
- bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
- bindings/v8/custom/V8WebKitPointConstructor.cpp:
- bindings/v8/custom/V8WebSocketCustom.cpp:
- bindings/v8/custom/V8WorkerCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
- bindings/v8/custom/V8XSLTProcessorCustom.cpp:
- 12:18 PM Changeset in webkit [55797] by
-
- 1 edit3 adds in trunk/WebCore
Extend keyboard navigation to allow directional navigation (Manual tests)
https://bugs.webkit.org/show_bug.cgi?id=18662
Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Adds a manual tests for the Spatial Navigation feature comprasing varios
Html focusable elements (e.g. <a>, <table>, <iframe>) and much of the logic
provided by the feature.
- manual-tests/spatial-navigation/links.html: Added.
- manual-tests/spatial-navigation/spatial-navigation-test-cases.html: Added.
- 12:13 PM Changeset in webkit [55796] by
-
- 1 edit10 adds in trunk/LayoutTests
Extend keyboard navigation to allow directional navigation (LayoutTests - part V)
https://bugs.webkit.org/show_bug.cgi?id=18662
Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>
This patch adds three LayoutTests that ensure the correctness of Spatial Navigation algorithm
in the following iframe related traversals:
1) All focusable elements in a <iframe> should be accessible.
2) Focusable elements in an <iframe> should be accessible even when
current focused element is in another <iframe> in the same page.
- fast/events/spatial-navigation/snav-iframe-no-focusable-content.html: Added.
- fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html: Added.
- fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html: Added.
- 12:10 PM Changeset in webkit [55795] by
-
- 1 edit2 adds in trunk/LayoutTests
Extend keyboard navigation to allow directional navigation (LayoutTests - part IV)
https://bugs.webkit.org/show_bug.cgi?id=18662
Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>
This patch adds a LayoutTest that ensures that:
1) There is no unit overflow in the Spatial Navigation algorithm while
calculating the best node candidate to move focus to. To test that this
page positions some elements 10000000 pixels far from each other (distance
that can considered large enough for most of the Web Pages on the
Internet).
2) A best focusable candidate only gets focused if it is visible in the
current Viewport. Scroll-in-direction is performed otherwise.
- fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html: Added.
- 12:08 PM Changeset in webkit [55794] by
-
- 1 edit4 adds in trunk/LayoutTests
Extend keyboard navigation to allow directional navigation (LayoutTests - part III)
https://bugs.webkit.org/show_bug.cgi?id=18662
Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>
This patch adds two LayoutTests to ensure the correctness of the "Fully aligned"
precedence logic implemented by Spatial Navigation algorithm, either vertically or
horizontally: targets whose middle falls between the top and bottom of the current
focused element are preferably to move focus to, even if it is not the shortest distance.
- fast/events/spatial-navigation/snav-fully-aligned-vertically.html: Added.
- fast/events/spatial-navigation/snav-fully-aligned-horizontally.html: Added.
- 12:06 PM Changeset in webkit [55793] by
-
- 1 edit2 adds in trunk/WebCore
2010-03-10 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35890
- platform/efl/ScrollbarEfl.h: Added.
- platform/efl/ScrollbarThemeEfl.h: Added.
- 11:47 AM Changeset in webkit [55792] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-10 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Fixing build warning caused by using 0 instead of NULL as the sentiel
in a varargs call.
https://bugs.webkit.org/show_bug.cgi?id=35898
- src/gtk/WebInputEventFactory.cpp:
- 11:26 AM Changeset in webkit [55791] by
-
- 2 edits in trunk/WebKitTools
2010-03-10 Robert Hogan <robert@webkit.org>
Reviewed by Holger Freyther.
QtLauncher: Fix typo in conditional statement in
WebViewGraphicsBased::setFrameRateMeasurementEnabled.
'=' should be '=='!
- QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
- 11:17 AM Changeset in webkit [55790] by
-
- 5 edits1 add in trunk/WebCore
2010-03-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Audits panel needs an icon.
Landing icon attached by Timothy. Enabling panel!
- WebCore.gypi:
- inspector/front-end/Images/auditsIcon.png: Added.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- 10:59 AM Changeset in webkit [55789] by
-
- 3 edits in trunk/WebCore
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Roll-out r55657, as Xan noticed a bad degradation in playing
youtube HTML5 videos with it, that is fixed with it
reverted. Looks like we'll need to work a bit more on this.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedTimerFired): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::muteChangedTimerFired): (WebCore::MediaPlayerPrivate::muteChanged):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 10:41 AM Changeset in webkit [55788] by
-
- 2 edits in trunk/WebCore
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Fix ready state when buffering under PLAYING. We should not go
back to HaveNothing in that case.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::updateStates):
- 10:38 AM Changeset in webkit [55787] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Retrieve any dwItemData that's set on the context menu item in contextMenuItemByIdOrPosition().
- platform/win/ContextMenuWin.cpp:
- 10:31 AM Changeset in webkit [55786] by
-
- 5 edits in trunk/WebKitTools
Refactored and cleaned up the code for unit-testing logging.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=35845
- Scripts/webkitpy/init/logtesting.py:
- Added more information to the module docstring.
- Added an assertMessages() method to the UnitTestLogStream class. This simplifies the calling code.
- Renamed the UnitTestLog class to LogTesting, and reformulated
it as follows:
- Moved the logging configuration code from the init method to a new static setUp() method.
- Documented the init method to be private.
- Improved the code so that the root logger does not have its logging level changed. Instead we set the handler's level. This makes the unit testing more unintrusive.
- Updated the assertMessages() method to call the UnitTestLogStream class's assertMessages() method.
- More fully documented the class.
- Scripts/webkitpy/style/checker.py:
- Added a logger parameter to the configure_logging() method. This allows us to prevent test messages from being sent to the root logger during unit testing, which may be rendering to the screen, etc.
- Simplified the code by removing the _LevelLoggingFilter class.
- Replaced the _LevelLoggingFilter class with a one-line lambda expression in configure_logging().
- Scripts/webkitpy/style/checker_unittest.py:
- Changed relative imports to absolute to comply more with PEP8.
- In the ConfigureLoggingTest class:
- Changed the setUp() method to prevent test messages from being propagated to the root logger.
- Changed the _log() method to a data attribute.
- Updated to accommodate changes to logtesting.py.
- Scripts/webkitpy/style_references.py:
- Updated an import statement.
- 9:36 AM WikiStart edited by
- add a gdb section (diff)
- 9:35 AM Changeset in webkit [55785] by
-
- 1 edit2 adds in trunk/WebKitTools
2010-03-10 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
Python code for GDB 7 to support native printing of some WebCore types.
- gdb/webcore.py: Added.
- 9:06 AM Changeset in webkit [55784] by
-
- 8 edits8 adds in trunk
2010-03-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Add IndexedDatabase class and hook it up.
https://bugs.webkit.org/show_bug.cgi?id=35927
This change is mostly just adding the plumbing necessary for
the IndexedDatabaseRequest and IndexedDatabaseSync (not written
yet).
This code is non-functional, so no tests (yet).
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/ChromiumBridge.h:
- storage/IndexedDatabase.cpp: Added. (WebCore::IndexedDatabase::get):
- storage/IndexedDatabase.h: Added. (WebCore::IndexedDatabase::~IndexedDatabase):
- storage/IndexedDatabaseImpl.cpp: Added. (WebCore::IndexedDatabaseImpl::get): (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::open):
- storage/IndexedDatabaseImpl.h: Added.
- storage/chromium/IndexedDatabase.cpp: Added. (WebCore::IndexedDatabase::get):
- WebKit.gyp:
- public/WebIndexedDatabase.h: Added. (WebKit::WebIndexedDatabase::~WebIndexedDatabase):
- public/WebKitClient.h: (WebKit::WebKitClient::getIndexedDatabase):
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::getIndexedDatabase):
- src/IndexedDatabaseProxy.cpp: Added. (WebCore::IndexedDatabaseProxy::create): (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::~IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::open):
- src/IndexedDatabaseProxy.h: Added.
- 8:56 AM Changeset in webkit [55783] by
-
- 3 edits2 adds in trunk
Add one more parent check during node removal.
https://bugs.webkit.org/show_bug.cgi?id=35818
Reviewed by Sam Weinig.
WebCore:
Test: fast/dom/Node/mutation-blur.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild): Added check.
LayoutTests:
- fast/dom/Node/mutation-blur-expected.txt: Added.
- fast/dom/Node/mutation-blur.html: Added.
- 8:50 AM Changeset in webkit [55782] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/multicol/hit-test-above-or-below.html fails
https://bugs.webkit.org/show_bug.cgi?id=35973
The test was introduced in r55546, it has been failing since then.
- platform/qt/Skipped: fast/multicol/hit-test-above-or-below.html skipped until fix.
- 8:34 AM Changeset in webkit [55781] by
-
- 2 edits in trunk/WebCore
2010-03-10 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: added missing quote to localized strings.
- English.lproj/localizedStrings.js:
- 7:47 AM Changeset in webkit [55780] by
-
- 3 edits in trunk/WebKitTools
Make svn-create-patch and prepare-ChangeLog show better section headings for ObjC files
This makes the text at the end of each "@@" line in a diff actually
show the ObjC method or interface that contains the change, rather
than whatever the most-recently-defined C function was.
Fixes <http://webkit.org/b/35970>.
Reviewed by John Sullivan.
- Scripts/svn-create-patch: Pass -F'[-+@]' to diff so that it will
treat any lines starting with -, +, or @ as section heading lines.
This works well for ObjC files, and shouldn't affect other types of
files.
- Scripts/prepare-ChangeLog: Changed the options passed to diff to
match those used in svn-create-patch.
- 7:38 AM Changeset in webkit [55779] by
-
- 1 edit3 adds in trunk/WebCore
Commit files that were supposed to go in with the last checkin.
- 7:34 AM Changeset in webkit [55778] by
-
- 7 edits in trunk/WebCore
Baby steps towards IndexedDB: Start implementing callbacks.
https://bugs.webkit.org/show_bug.cgi?id=35911
Reviewed by Dimitry Glazkov.
This patch adds some infastructure for IndexedDB callbacks in V8.
It also adds a stub of IDBDatabaseRequest. In the near future,
I'll gut the event based implementation code, flesh out IDBReqest
further, and start plumbing IndexedDatabaseRequest.
Code is not testible because it doesn't work (yet).
- WebCore.gypi:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8CustomIDBCallback.h: Added.
(WebCore::V8CustomIDBCallback::create):
(WebCore::V8CustomIDBCallback::~V8CustomIDBCallback):
(WebCore::V8CustomIDBCallback::handleEvent):
(WebCore::V8CustomIDBCallback::V8CustomIDBCallback):
- bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
(WebCore::V8IndexedDatabaseRequest::openCallback):
- storage/IDBDatabaseRequest.h: Added.
(WebCore::IDBDatabaseRequest::request):
- storage/IDBDatabaseRequest.idl: Added.
- storage/IndexedDatabaseRequest.idl:
- 7:17 AM Changeset in webkit [55777] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-03-10 Priit Laes <plaes@plaes.org>
Reviewed by Gustavo Noronha.
Estonian translation.
- et.po: Added.
- 5:23 AM Changeset in webkit [55776] by
-
- 4 edits in trunk/WebKit
<rdar://problem/7735387> input type other than text won't work with autofill
<https://bugs.webkit.org/show_bug.cgi?id=35963>
Reviewed by Tim Hatcher.
WebKit/mac:
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation elementDoesAutoComplete:]):
Return true for any text field that's not a password, rather than only
for TEXT type.
WebKit/win:
- WebFrame.cpp:
(WebFrame::elementDoesAutoComplete):
Return true for any text field that's not a password, rather than only
for TEXT type.
- 4:44 AM BuildingQtOnWindows edited by
- (diff)
- 4:10 AM Changeset in webkit [55775] by
-
- 2 edits in trunk/WebKitTools
Link QtLauncher against the WebKit library using a relative rpath.
Reviewed by Tor Arne Vestbø.
This makes the launcher and the lib relocatable.
- QtLauncher/QtLauncher.pro:
- 2:46 AM Changeset in webkit [55774] by
-
- 2 edits3 adds in trunk/WebCore
[Qt] Non animated gifs are animated in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35955
Properly map Qt animated and non-animated values to WebCore's
understanding of animated and non-animated images. Currently
we can not map anything to the cAnimationLoopNone value.
- manual-tests/qt/qt-anim.gif: Added.
- manual-tests/qt/qt-gif-test.html: Added.
- manual-tests/qt/qt-noanim.gif: Added.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::repetitionCount):
- 2:44 AM Changeset in webkit [55773] by
-
- 3 edits2 adds in trunk
[CAIRO] DoS on iexploder test with high text stroke width.
https://bugs.webkit.org/show_bug.cgi?id=33759
Specifying a big text stroke width can make WebKitGTK+ spend
a very long time in the cairo library for stroking the path of
the text. The best way to prevent this from happening right now
is to not stroke paths with a certain width. Samuel proposed to
not stroke with a width that is twice the width of the text. The
reason to use twice the text width is that even one stroke of
any charachter to be drawn would cover the full width.
Test: fast/text/text-stroke-width-cairo-dos.html
WebCore:
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
Add a test case with the -webkit-text-stroke-width attribute
set to a high value to illustrate the issue.
- fast/text/text-stroke-width-cairo-dos-expected.txt: Added.
- fast/text/text-stroke-width-cairo-dos.html: Added.
- 1:41 AM Changeset in webkit [55772] by
-
- 4 edits in trunk/WebKitTools
[iExploder] Add new CSS Properties and HTML Attributes
The update-iexploder-cssproperties script was used to update
the various input files. The autobuffer HTML Attribute was removed
from WebKit and I manually added it back to the htmlattrs.in like
we have done it for other attributes in the past.
- 1:22 AM Changeset in webkit [55771] by
-
- 28 edits1 copy2 adds in trunk
2010-03-10 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: display list of active workers & support debugging
with fake workers.
https://bugs.webkit.org/show_bug.cgi?id=35568
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
- dom/Document.cpp: (WebCore::Document::inspectorController):
- dom/Document.h:
- dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::inspectorController):
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectScript): (WebCore::InjectedScriptHost::nextWorkerId): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::willDestroyWorker):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::willDestroyWorker):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCreateWorker): (WebCore::InspectorFrontend::willDestroyWorker):
- inspector/InspectorFrontend.h:
- inspector/InspectorWorkerResource.h: Added. (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::url): (WebCore::InspectorWorkerResource::isSharedWorker): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
- inspector/front-end/Checkbox.js: Added. (WebInspector.Checkbox.callbackWrapper): (WebInspector.Checkbox): (WebInspector.Checkbox.prototype.checked):
- inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.showInheritedToggleFunction): (WebInspector.StylePropertiesSection):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/WorkersSidebarPane.js: Added. (WebInspector.WorkersSidebarPane): (WebInspector.WorkersSidebarPane.prototype.addWorker): (WebInspector.WorkersSidebarPane.prototype.removeWorker): (WebInspector.WorkersSidebarPane.prototype.setInstrumentation): (WebInspector.WorkersSidebarPane.prototype.reset): (WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument): (WebInspector.Worker): (WebInspector.didCreateWorker): (WebInspector.willDestroyWorker):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker): (WebCore::AbstractWorker::contextDestroyed):
- workers/AbstractWorker.h: (WebCore::AbstractWorker::id):
- workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
- workers/Worker.cpp: (WebCore::Worker::Worker):
WebKit/chromium:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
- 1:02 AM Changeset in webkit [55770] by
-
- 3 edits in trunk/JavaScriptCore
2010-03-10 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Eric Seidel.
Make global new/delete operators configurable for all ports and disable it
for the wx port for now.
- wtf/FastMalloc.h:
- wtf/Platform.h:
- 12:41 AM Changeset in webkit [55769] by
-
- 1 edit1 add in trunk/WebKit/chromium
2010-03-10 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=35956
Create a grd file upstream for resources that chromium uses
that are pulled directly from the upstream repository.
- WebKit.grd: Added.
- 12:06 AM Changeset in webkit [55768] by
-
- 2 edits in trunk/WebKit/gtk
2010-03-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] testkeyevents doesn't stop if input event injection fails
https://bugs.webkit.org/show_bug.cgi?id=35922
- tests/testkeyevents.c: (load_status_cb): Added a safeguard to exit from the test if the input event injection failed.
Mar 9, 2010:
- 10:32 PM Changeset in webkit [55767] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix. Fix variable name change that somehow didn't
make it into the patch.
- 10:23 PM Changeset in webkit [55766] by
-
- 12 edits3 adds in trunk
Bug 28293 - [Chromium] event.datatransfer.getdata("text/uri-list") is treated the same as getdata("URL")
https://bugs.webkit.org/show_bug.cgi?id=28293
Reviewed by David Levin.
WebCore:
Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
correctly for event.dataTransfer.getData/setData. Currently both are treated
as synonyms, but for "URL", getData is supposed to only return the first valid URL
contained within the data for "text/uri-list" (see HTML5 spec).
Tests: editing/pasteboard/dataTransfer-setData-getData.html
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::clearURL):
(WebCore::ChromiumDataObject::hasValidURL):
(WebCore::ChromiumDataObject::getURL):
(WebCore::ChromiumDataObject::setURL):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::):
(WebCore::clipboardTypeFromMIMEType):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
(WebCore::DragData::canSmartReplace):
WebKit/chromium:
Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
correctly for event.dataTransfer.getData/setData. Currently both are treated
as synonyms, but for "URL", getData is supposed to only return the first valid URL
contained within the data for "text/uri-list" (see HTML5 spec).
Tests: editing/pasteboard/dataTransfer-setData-getData.html
- src/WebDragData.cpp:
(WebKit::WebDragData::url):
(WebKit::WebDragData::setURL):
LayoutTests:
Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
correctly for event.dataTransfer.getData/setData. Currently both are treated
as synonyms, but for "URL", getData is supposed to only return the first valid URL
contained within the data for "text/uri-list" (see HTML5 spec).
Layout test checks various combinations in a drag-n-drop operation.
Skipping on all other platforms since they don't implement this correctly, either.
- editing/pasteboard/dataTransfer-setData-getData.html: Added.
- editing/pasteboard/script-tests/dataTransfer-setData-getData.js: Added.
(dragTarget):
(moveMouseToCenterOfElement):
(dragOntoDragTarget):
(doDrop):
(test):
(runTest):
- platform/mac/Skipped:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 10:17 PM Changeset in webkit [55765] by
-
- 2 edits in trunk/WebCore
2010-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: REGRESSION: Tall image resources are cropped over the bottom.
- inspector/front-end/inspector.css:
- 10:13 PM Changeset in webkit [55764] by
-
- 2 edits in trunk/WebCore
2010-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: REGRESSION: Pressing up/down arrow key to change numeric
value in CSS property takes focus away.
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
- 9:46 PM Changeset in webkit [55763] by
-
- 3 edits in trunk/WebKitTools
2010-03-09 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed.
Obvious fix for --cgi-paths of pywebsocket.
- Scripts/run-webkit-websocketserver:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 9:32 PM Changeset in webkit [55762] by
-
- 10 edits4 adds in trunk
2010-03-09 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=21840
https://bugs.webkit.org/show_bug.cgi?id=23993
Fix an editing bug where replacing a selection would result in the
new text ending up inside nodes that were not visibly included in the
selection. Instead, move our destination position out of nodes that
were not visibly included.
Two new tests to verify the new behavior. Because we're now inserting
outside of some formatting nodes, some span tags are no longer necessary
for undoing formatting caused by these formatting nodes.
- editing/deleting/backspace-avoid-preceding-style-expected.txt: Added.
- editing/deleting/backspace-avoid-preceding-style.html: Added.
- editing/inserting/replace-at-visible-boundary-expected.txt: Added.
- editing/inserting/replace-at-visible-boundary.html: Added.
- platform/mac/editing/deleting/delete-3857753-fix-expected.txt:
- platform/mac/editing/inserting/insert-div-026-expected.txt:
- platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
- platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
- platform/mac/editing/style/font-family-with-space-expected.txt:
- platform/mac/editing/style/smoosh-styles-001-expected.txt:
- platform/mac/editing/style/style-boundary-005-expected.txt:
2010-03-09 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=21840
https://bugs.webkit.org/show_bug.cgi?id=23993
Fix an editing bug where replacing a selection would result in the
new text ending up inside nodes that were not visibly included in the
selection. Instead, move our destination position out of nodes that
were not visibly included.
Tests: editing/deleting/backspace-avoid-preceding-style.html
editing/inserting/replace-at-visible-boundary.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::positionAvoidingPrecedingNodes): (WebCore::ReplaceSelectionCommand::doApply):
- 8:53 PM Changeset in webkit [55761] by
-
- 9 edits in trunk
REGRESSION: WebInspector docking busted on Windows
<rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953
Reviewed by Tim Hatcher.
WebCore:
First off, a bit of settings-key related cleanup. If they're shared over multiple files, these
things should be properly declared Strings, not random loose char*'s.
Along with that change, we move the "inspectorStartsAttachedSettingName" from WebKit down to the
InspectorController in WebCore.
Finally, when the controller is ready to show the WebInspector window, it can use this newly
exposed settings key to call "setWindowVisible" directly instead of relying on "showWindow" to do
it indirectly.
- WebCore.base.exp:
- inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::saveFrontendSettings):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::frontendSettingsSettingName):
(WebCore::InspectorController::inspectorStartsAttachedSettingName):
(WebCore::InspectorController::scriptObjectReady): Using the new inspectorStartsAttachedSettingName
key and some "can I attach this?" logic, call setWindowVisible directly to display the inspector
window.
(WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): Use the InspectorController:: copy of the should attach settings key.
(-[WebInspectorWindowController attach]): Ditto.
(-[WebInspectorWindowController detach]): Ditto.
WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::attachWindow): Use the InspectorController:: copy of the should attach settings key.
(WebInspectorClient::detachWindow): Ditto.
(WebInspectorClient::showWindowWithoutNotifications): Ditto.
- 8:05 PM Changeset in webkit [55760] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=35951
<rdar://problem/7327060> Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80
- bridge/objc/objc_instance.mm: (createInstanceWrapperCache): Fix Tiger code path, too.
- 6:45 PM Changeset in webkit [55759] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.23
Tagging 1.1.23.
- 5:44 PM Changeset in webkit [55758] by
-
- 4 edits in trunk/WebKit/chromium
Reviewed by Darin Fisher.
Need to send mouse events to plugin when it has mouse capture
https://bugs.webkit.org/show_bug.cgi?id=35900
- public/WebInputEvent.h:
(WebKit::WebInputEvent::isMouseEventType):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::mouseDown):
(WebKit::WebViewImpl::mouseUp):
(WebKit::WebViewImpl::handleInputEvent):
- src/WebViewImpl.h:
- 5:29 PM Changeset in webkit [55757] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=35951
<rdar://problem/7327060> Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80
- bridge/objc/objc_instance.mm: (createInstanceWrapperCache): It's not correct to use object personality for keys, because the key can be a mutable object, so its hash can change over its lifetime.
- 4:49 PM Changeset in webkit [55756] by
-
- 2 edits in trunk/LayoutTests
[Qt] http/tests/plugins/third-party-cookie-accept-policy.html was introduced in r55738,
but layoutTestController.setAlwaysAcceptCookies() is missing.
- platform/qt/Skipped: http/tests/plugins/third-party-cookie-accept-policy.html skipped.
- 4:45 PM Changeset in webkit [55755] by
-
- 4 edits in trunk
Versioning.
- 4:43 PM Changeset in webkit [55754] by
-
- 1 copy in tags/Safari-533.2
New tag.
- 4:17 PM Changeset in webkit [55753] by
-
- 3 edits in trunk/WebCore
2010-03-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
Fix review comment accidentally overlooked in bug 35713
https://bugs.webkit.org/show_bug.cgi?id=35947
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
- editing/DeleteSelectionCommand.h:
- 3:41 PM Changeset in webkit [55752] by
-
- 5 edits4 adds in trunk
2010-03-03 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
undo after smartdelete should select the deleted space
https://bugs.webkit.org/show_bug.cgi?id=35713
- editing/undo/undo-smart-delete-reversed-selection-expected.txt: Added.
- editing/undo/undo-smart-delete-reversed-selection.html: Added.
- editing/undo/undo-smart-delete-word-expected.txt: Added.
- editing/undo/undo-smart-delete-word.html: Added.
2010-03-03 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
undo after smartdelete should select the deleted space
https://bugs.webkit.org/show_bug.cgi?id=35713
TextEdit behavior is to select the deleted space after a smartdelete.
Tests: editing/undo/undo-smart-delete-reversed-selection.html
editing/undo/undo-smart-delete-word.html
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete): (WebCore::DeleteSelectionCommand::initializePositionData):
- editing/DeleteSelectionCommand.h:
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setWithoutValidation): This assert looks bogus to me. undo-smart-delete-reversed-selection.html hits it but not as a result of the other changes in this patch. The granularity when deleting after making a wordgranularity selection is wordgranularity, not charactergranularity.
- 3:32 PM Changeset in webkit [55751] by
-
- 8 edits in trunk/JavaScriptCore
This caused a performance regression, by breaking the code
generator's logic to calculate the skip level for resolving
variables (traced by rdar:7683350) Reverting for now.
Reviewed by NOBODY (reverting r54510).
- parser/Grammar.y:
- parser/NodeConstructors.h:
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
- runtime/Identifier.cpp:
(JSC::Identifier::add):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- 3:07 PM Changeset in webkit [55750] by
-
- 5 edits in trunk
JavaScriptCore: Changed FastMalloc statistics reporting to be a bit clearer. We now
report:
- Reserved VM Bytes: the VM that has been mapped into the process.
- Committed VM Bytes: the subset of Reserved VM Bytes actually in use.
- Free List Bytes: the subset of Committed VM Bytes in a free list.
Reviewed by Darin Adler.
- wtf/FastMalloc.cpp:
(WTF::fastMallocStatistics):
(WTF::TCMallocStats::fastMallocStatistics): Updated to report the statistics
above. Standardized use of "ifdef WTF_CHANGES". Added a SpinLockHolder
around all statistics gathering, since it reads from the page heap.
- wtf/FastMalloc.h: Updated to report the statistics above.
WebKit/mac: Updated for FastMalloc reporting changes.
Reviewed by Darin Adler.
- Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics memoryStatistics]):
- 2:40 PM Changeset in webkit [55749] by
-
- 2 edits in trunk/WebKitTools
2010-03-09 Jakub Wieczorek <jwieczorek@webkit.org>
Unreviewed.
Adding myself to committers.py.
- Scripts/webkitpy/committers.py:
- 2:37 PM Changeset in webkit [55748] by
-
- 3 edits2 adds in trunk
2010-03-09 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Fisher.
Accept and bailout NULL widgets in ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=35796
- src/ChromiumBridge.cpp: (WebCore::toChromeClientImpl):
- 2:24 PM Changeset in webkit [55747] by
-
- 2 edits in trunk/WebCore
Rubber stamped by Adam Roben.
Load debug version of graphics library in Windows Debug_All builds.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
- 2:13 PM Google Summer of Code 2010 edited by
- (diff)
- 2:02 PM CommitterTips edited by
- Fix a few typos. (diff)
- 2:00 PM Changeset in webkit [55746] by
-
- 4 edits in trunk/WebKit
Fixed localized string key collision. update-webkit-localized-strings now
runs without errors.
Reviewed by Adam Roben.
WebKit:
- English.lproj/Localizable.strings:
Regenerated.
WebKit/win:
- WebCoreLocalizedStrings.cpp:
(WebCore::AXMenuListPopupActionVerb):
Used LPCTSTR_UI_STRING_KEY for the 2nd use of "press".
- 1:49 PM Changeset in webkit [55745] by
-
- 2 edits in trunk/WebKit
- StringsNotToBeLocalized.txt:
Brought this file up to date. update-webkit-localizable-strings still lists
one key collision, but that's a separate issue.
- 1:29 PM Changeset in webkit [55744] by
-
- 2 edits in trunk/LayoutTests
2010-03-09 Gustavo Noronha Silva <Gustavo Noronha Silva>
[GTK] Fails http/tests/plugins/third-party-cookie-accept-policy.html
https://bugs.webkit.org/show_bug.cgi?id=35942
Unreviewed. Skip test that fails, while we look for the
problem. This is likely a bug in soup.
- platform/gtk/Skipped:
- 1:25 PM Changeset in webkit [55743] by
-
- 4 edits in trunk
Unreviewed. Versioning, and documentation control files update for 1.1.23.
- 1:25 PM Changeset in webkit [55742] by
-
- 4 edits in trunk/LayoutTests
Fix my layouttest failures by resetting cookies before and after these new tests.
https://bugs.webkit.org/show_bug.cgi?id=26391
Reviewed by Alexey Proskuryakov.
- http/tests/cookies/third-party-cookie-relaxing.html:
- http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html:
- http/tests/plugins/third-party-cookie-accept-policy.html:
- 1:23 PM Changeset in webkit [55741] by
-
- 2 edits in trunk/WebKitTools
2010-03-09 Dirk Pranke <dpranke@chromium.org>
Reviewed by Nate Chapin.
Fix --clobber-old-results in new-run-webkit-tests.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 12:58 PM Changeset in webkit [55740] by
-
- 2 edits in trunk/WebKitSite
Add a link to the Contributors Meeting registration form in the sidebar
Rubber-stamped in advance by Adele Peterson.
- nav.inc: Added a link underneath "Trac".
- 11:56 AM Changeset in webkit [55739] by
-
- 2 edits in trunk/WebKitTools
Add the ability to dispatch scroll wheel events in DRT. This was
necessary in order to write a test for
https://bugs.webkit.org/show_bug.cgi?id=34700.
Patch by Andy Estes <aestes@apple.com> on 2010-03-09
Reviewed by Adele Peterson.
- DumpRenderTree/mac/EventSendingController.mm: Add support for two
new methods to EventSender: mouseScrollBy(x, y) and
continuousMouseScrollBy(x, y). The API to generate scroll events on
the mac was added in 10.5, so these methods are NOOPs on Tiger.
(+[EventSendingController isSelectorExcludedFromWebScript:]):
Regiester mouseScrollByX:andY: and continuousMouseScrollByX:andY:
(+[EventSendingController webScriptNameForSelector:]): Map JavaScript
method names to ObjC selectors.
(-[EventSendingController mouseScrollByX:andY:continuously:]): Generate
a scroll wheel event using CGEventCreateScrollWheelEvent() and dispatch
it to WebKit.
(-[EventSendingController continuousMouseScrollByX:andY:]): Generate a
continuous scrolling event by x and y pixels.
(-[EventSendingController mouseScrollByX:andY:]): Generate a notchy
scrolling event by x and y lines.
- 11:52 AM Changeset in webkit [55738] by
-
- 4 edits3 adds in trunk
Plug-ins don't always respect the cookie accept policy.
<rdar://problem/7338359> and https://bugs.webkit.org/show_bug.cgi?id=26391
Reviewed by Darin Adler.
WebCore:
The problem is that the various plug-in implementations call into a ResourceLoader
directly instead of filtering the request through FrameLoader. This bypassed the step
of adding extra fields to the requests, such as the firstPartyForCookies URL.
Since plug-in code is currently so strewn about and very platform specific, I
think reworking it needs to be a task for domain experts. I don't know the implications
of adding *all* the extra fields to plug-in requests, for example.
There's no harm in this targeted fix for the hole in our cookie accept policy until
plug-ins can more fundamentally change.
Test: http/tests/plugins/third-party-cookie-accept-policy.html
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::load): Don't load a resource without first giving the request
a firstPartyForCookies URL.
LayoutTests:
- http/tests/cookies/resources/cookie-utility.php:
- http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html: Added.
- http/tests/plugins/third-party-cookie-accept-policy.html: Added.
- 11:32 AM Changeset in webkit [55737] by
-
- 7 edits2 adds in trunk
WebCore: Check for null renderer in scrollNode().
https://bugs.webkit.org/show_bug.cgi?id=34700
Patch by Andy Estes <aestes@apple.com> on 2010-03-09
Reviewed by Adele Peterson.
Test: fast/events/remove-child-onscroll.html
- page/EventHandler.cpp:
(WebCore::scrollNode): Return early if node->renderer() == 0
LayoutTests: Create a test for https://bugs.webkit.org/show_bug.cgi?id=34700. This
test required implementing scroll wheel event dispatch in DRT and
currently only works on OS X 10.5+. Skip this test on other platforms
for the time being.
Patch by Andy Estes <aestes@apple.com> on 2010-03-09
Reviewed by Adele Peterson.
- fast/events/remove-child-onscroll-expected.txt: Added.
- fast/events/remove-child-onscroll.html: Added.
- platform/gtk/Skipped: Skip remove-child-onscroll.html
- platform/mac-tiger/Skipped: Skip remove-child-onscroll.html
- platform/qt/Skipped: Skip remove-child-onscroll.html
- platform/win/Skipped: Skip remove-child-onscroll.html
- 11:20 AM QtWebKitContrib edited by
- (diff)
- 11:18 AM QtWebKitContrib edited by
- (diff)
- 11:12 AM Changeset in webkit [55736] by
-
- 4 edits in trunk
Unreviewed distcheck fix
- 11:11 AM Changeset in webkit [55735] by
-
- 2 edits in trunk/LayoutTests
2010-03-09 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Adler.
Fix send-oncancel-event. It uses js-test-post, not
js-test-post-function.
https://bugs.webkit.org/show_bug.cgi?id=35880
- fast/events/touch/script-tests/send-oncancel-event.js: (touchcancelHandler):
- 10:45 AM Changeset in webkit [55734] by
-
- 2 edits in trunk/WebCore
2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix (only exposed by make distcheck). The
SharedWorkers files are not built, they need to be distributed.
- GNUmakefile.am:
- 10:43 AM Changeset in webkit [55733] by
-
- 3 edits in trunk/WebCore
2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Dirk Schulze.
[GStreamer] Buffering logic is not correct, and does not work very well
https://bugs.webkit.org/show_bug.cgi?id=35706
Fix buffering to match GStreamer expectancies regarding the
pipeline state, so that videos which really need buffering to play
correctly also work, while maintaining the convenience of
on-disk-buffering. This required a bit of shuffling of state
change handling.
No behaviour change expected.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::updateStates):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 10:35 AM Changeset in webkit [55732] by
-
- 2 edits in trunk/WebCore
2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Dirk Schulze.
[GStreamer] Buffering logic is not correct, and does not work very well
https://bugs.webkit.org/show_bug.cgi?id=35706
Do not call pause(), but set the GStreamer state directly. This is
just a GStreamer implementation detail, and this will avoid having
side effects in case we change the pause implementation in the
future.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::load):
- 10:25 AM Changeset in webkit [55731] by
-
- 2 edits in trunk/LayoutTests
2010-03-09 Simon Fraser <Simon Fraser>
Skip media/video-source-error.html on SnowLeopard, beacuse it fails sporadically.
This is covered by https://bugs.webkit.org/show_bug.cgi?id=32270.
- platform/mac-snowleopard/Skipped:
- 10:11 AM Changeset in webkit [55730] by
-
- 2 edits in trunk/WebKitTools
DRT build fix for Tiger. No review.
AX: hit testing a list box doesn't work anymore
https://bugs.webkit.org/show_bug.cgi?id=35893
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::elementAtPoint):
- 9:42 AM Changeset in webkit [55729] by
-
- 9 edits2 adds in trunk
AX: hit testing a list box doesn't work anymore
https://bugs.webkit.org/show_bug.cgi?id=35893
Reviewed by Darin Adler.
WebCore:
Since <option> elements don't have renderers, their hit testing needs
to be handled with a special case.
Test: platform/mac/accessibility/listbox-hit-test.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaIsHidden):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
WebKitTools:
- DumpRenderTree/AccessibilityController.cpp:
(getElementAtPointCallback):
(AccessibilityController::getJSClass):
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::elementAtPoint):
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::elementAtPoint):
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::elementAtPoint):
LayoutTests:
- platform/mac/accessibility/listbox-hit-test-expected.txt: Added.
- platform/mac/accessibility/listbox-hit-test.html: Added.
- 9:37 AM Changeset in webkit [55728] by
-
- 1 edit in trunk/WebCore/ChangeLog
2010-03-09 Pavel Feldman <pfeldman@chromium.org>
r55727 was landed with wrong commit messages. Should have been:
Reviewed by Timothy Hatcher.
Web Inspector: Refactor Audits panel presentation layer.
This change removes unnecessary complexity:
- Audit scores were not used
- Audit rule parameters are passed as rule constructor arguments
- View management aligned with the rest of the front-end
- Single TreeOutline is used for category results (no need to create sections for those)
- Rules code beautified and simplified where possible
- Some UI improvements applied (see attached screenshot)
- inspector/front-end/AuditCategories.js: (WebInspector.AuditCategories.PagePerformance.prototype.initialize): (WebInspector.AuditCategories.NetworkUtilization.prototype.initialize):
- inspector/front-end/AuditResultView.js: (WebInspector.AuditResultView): (WebInspector.AuditCategoryResultPane): (WebInspector.AuditCategoryResultPane.prototype._appendResult):
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.CombineExternalResourcesRule): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.CombineJsResourcesRule): (WebInspector.AuditRules.CombineCssResourcesRule): (WebInspector.AuditRules.MinimizeDnsLookupsRule): (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun): (WebInspector.AuditRules.ParallelizeDownloadRule): (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun): (WebInspector.AuditRules.UnusedCssRule): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): (WebInspector.AuditRules.CacheControlRule): (WebInspector.AuditRules.CacheControlRule.prototype.doRun): (WebInspector.AuditRules.CacheControlRule.prototype.execCheck): (WebInspector.AuditRules.BrowserCacheControlRule): (WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources): (WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks): (WebInspector.AuditRules.ProxyCacheControlRule): (WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks): (WebInspector.AuditRules.ImageDimensionsRule): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine): (WebInspector.AuditRules.StylesScriptsOrderRule): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.routine): (WebInspector.AuditRules.CookieRuleBase): (WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback): (WebInspector.AuditRules.CookieRuleBase.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies): (WebInspector.AuditRules.StaticCookielessRule): (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel): (WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback): (WebInspector.AuditsPanel.prototype._executeAudit): (WebInspector.AuditsPanel.prototype._reloadResources): (WebInspector.AuditsPanel.prototype._didMainResourceLoad): (WebInspector.AuditsPanel.prototype.showResults): (WebInspector.AuditsPanel.prototype.showLauncherView): (WebInspector.AuditsPanel.prototype.get visibleView): (WebInspector.AuditsPanel.prototype.set visibleView): (WebInspector.AuditsPanel.prototype.show): (WebInspector.AuditsPanel.prototype._clearButtonClicked): (WebInspector.AuditCategory.prototype.addRule): (WebInspector.AuditRule): (WebInspector.AuditRule.prototype.set severity): (WebInspector.AuditRule.prototype.run): (WebInspector.AuditRule.prototype.doRun): (WebInspector.AuditCategoryResult): (WebInspector.AuditCategoryResult.prototype.addRuleResult): (WebInspector.AuditRuleResult): (WebInspector.AuditRuleResult.prototype.addChild): (WebInspector.AuditRuleResult.prototype.addURL): (WebInspector.AuditRuleResult.prototype.addURLs): (WebInspector.AuditRuleResult.prototype.addSnippet):
- inspector/front-end/Settings.js:
- inspector/front-end/audits.css:
- inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.documentKeyDown):
- 9:34 AM Changeset in webkit [55727] by
-
- 8 edits in trunk/WebCore
2010-03-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
When enable resource tracking state changes use the same method as
location.reload for reloading inspected page.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::reloadPage):
- inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):
- 9:22 AM Changeset in webkit [55726] by
-
- 7 edits in trunk
2010-03-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
When enable resource tracking state changes use the same method as
location.reload for reloading inspected page.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::reloadPage):
- inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):
2010-03-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Use clean global object for devtools utility context instead of
trying to simulate inspected context.
- src/DebuggerAgentImpl.cpp:
- src/DebuggerAgentImpl.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::resetInspectorFrontendProxy):
- 8:24 AM Changeset in webkit [55725] by
-
- 2 edits in trunk/WebCore
2010-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: highlight text node containers while searching for node.
- inspector/InspectorController.cpp: (WebCore::InspectorController::mouseDidMoveOverElement):
- 7:51 AM QtWebKitRelease20 edited by
- (diff)
- 7:47 AM Changeset in webkit [55724] by
-
- 2 edits in trunk/LayoutTests
[Qt] editing/execCommand/move-selection-back-line.html fails in DRT.
https://bugs.webkit.org/show_bug.cgi?id=35921
- platform/qt/Skipped: editing/execCommand/move-selection-back-line.html skipped until fix.
- 7:46 AM QtWebKitRelease20Deployment created by
- 7:39 AM QtWebKitBugs edited by
- (diff)
- 6:46 AM Changeset in webkit [55723] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-03-09 Peteris Krisjanis <pecisk@gmail.com>
Reviewed by Gustavo Noronha.
Latvian translation.
- lv.po: Added.
- 6:42 AM Changeset in webkit [55722] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-03-09 Duy Nguyen <pclouds@gmail.com>
Reviewed by Gustavo Noronha.
Vietnamese translation update.
- vi.po:
- 6:36 AM Changeset in webkit [55721] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-03-09 Rimas Kudelis <rq@akl.lt>
Reviewed by Gustavo Noronha.
Lithuanian translation update.
- lt.po:
- 3:23 AM Changeset in webkit [55720] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
[Qt] perl websocket test(s) time out
https://bugs.webkit.org/show_bug.cgi?id=34879
It was fixed by r55719, so we can unskip websocket/tests/cookies/httponly-cookie.pl.
storage/open-database-creation-callback-isolated-world.html removed
from Skipped list, because it was removed from tree by r55635.
- platform/qt/Skipped:
- websocket/tests/cookies/httponly-cookie.pl unskipped.
- storage/open-database-creation-callback-isolated-world.html unskipped.
- 3:20 AM QtWebKitBugs edited by
- Add the all triaged bugs list (diff)
- 2:40 AM Changeset in webkit [55719] by
-
- 11 edits3 copies3 adds1 delete in trunk
2010-03-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
pywebsocket should support html and cgi in the same directory.
https://bugs.webkit.org/show_bug.cgi?id=34879
- websocket/tests/cookies: Removed.
- websocket/tests/cookies/echo-cookie_wsh.py: Removed.
- websocket/tests/cookies/httponly-cookie-expected.txt: Removed.
- websocket/tests/cookies/httponly-cookie.pl: Removed.
- websocket/tests/echo-cookie_wsh.py: Copied from LayoutTests/websocket/tests/cookies/echo-cookie_wsh.py.
- websocket/tests/httponly-cookie-expected.txt: Copied from LayoutTests/websocket/tests/cookies/httponly-cookie-expected.txt.
- websocket/tests/httponly-cookie.pl: Copied from LayoutTests/websocket/tests/cookies/httponly-cookie.pl.
2010-03-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
pywebsocket should support html and cgi in the same directory.
https://bugs.webkit.org/show_bug.cgi?id=34879
Import pywebsocket 0.4.9.2
Specify --server-host 127.0.0.1, so that it only binds listening socket
to 127.0.0.1 to prevent access from non-localhost.
Change --cgi-paths from /websocket/tests/cookies to /websocket/tests,
because pywebsocket 0.4.9.2 supports html and cgi in the same directory
and only executable (httponly-cookies.pl) will be handled as cgi
script.
- Scripts/run-webkit-tests:
- Scripts/run-webkit-websocketserver:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/thirdparty/pywebsocket/README.webkit:
- Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py:
- Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py:
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py:
- Scripts/webkitpy/thirdparty/pywebsocket/setup.py:
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py:
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added.
- 1:36 AM Changeset in webkit [55718] by
-
- 4 edits in trunk/JavaScriptCore
Rubber-stamped by Maciej Stachowiak.
Buildfix for ARM after r55684. Add branch8 and branchTest8 functions.
https://bugs.webkit.org/show_bug.cgi?id=35892
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::dataTransfer32):
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branchTest8):
- 1:01 AM Changeset in webkit [55717] by
-
- 3 edits in trunk/WebCore
2010-03-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] player code cleanups
https://bugs.webkit.org/show_bug.cgi?id=35868
Cleaned up the private instance variables of the player.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::mediaLocationChanged):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 1:01 AM Changeset in webkit [55716] by
-
- 7 edits2 copies2 moves in trunk/WebCore
2010-03-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] player code cleanups
https://bugs.webkit.org/show_bug.cgi?id=35868
Splitted GOwnPtrGtk.{cpp,h} to GOwnPtr{Soup,GStreamer}.{cpp,h}.
- GNUmakefile.am:
- platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Added. (WTF::GstElement):
- platform/graphics/gstreamer/GOwnPtrGStreamer.h: Added.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/gtk/GOwnPtrGtk.cpp: Removed.
- platform/gtk/GOwnPtrGtk.h: Removed.
- platform/network/soup/CookieJarSoup.cpp:
- platform/network/soup/DNSSoup.cpp:
- platform/network/soup/GOwnPtrSoup.cpp: Added. (WTF::SoupURI):
- platform/network/soup/GOwnPtrSoup.h: Added.
- platform/network/soup/ResourceHandleSoup.cpp:
- platform/network/soup/ResourceRequestSoup.cpp:
- 12:30 AM Changeset in webkit [55715] by
-
- 3 edits in trunk/WebKitTools
Simplified check-webkit-style's argument parsing code by removing
support for the vestigial "extra flag values" parameter.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34677
The "extra flag values" parameter was needed before WebKit
forked check-webkit-style from Google. It was used to pass
through the option parser those command-line flags that WebKit
required but that Google's parser did not support (the --git-commit
flag in particular).
We can remove the parameter now because it is no longer
needed and unnecessarily clutters the argument-parsing code.
- Scripts/webkitpy/style/optparser.py:
- Removed the extra_flag_values parameter from the CommandOptionValues class's constructor.
- Removed the extra_flags parameter from the ArgumentParser class's parse() method.
- Scripts/webkitpy/style/optparser_unittest.py:
- Removed from the unit tests all references to the extra_flag_values variable.
- 12:23 AM Changeset in webkit [55714] by
-
- 3 edits in trunk/WebCore
2010-03-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Should remove paddings of Win/Linux chromium's buttons
https://bugs.webkit.org/show_bug.cgi?id=35629
No new tests, but we may need to rebaseline bunch of expectation
images in chromium's tree.
- rendering/RenderThemeChromiumSkia.cpp:
- rendering/RenderThemeChromiumSkia.h:
Mar 8, 2010:
- 10:52 PM Changeset in webkit [55713] by
-
- 1 edit2 adds in trunk/WebKitTools
2010-03-08 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add EventSender
https://bugs.webkit.org/show_bug.cgi?id=35859
Add EventSender classes, which are going to be used by
DumpRenderTree Chromium port. These files are based on:
- src/webkit/tools/test_shell/event_sending_controller.cc
- src/webkit/tools/test_shell/event_sending_controller.h of Chromium rev.40492.
- DumpRenderTree/chromium/EventSender.cpp: Added.
- DumpRenderTree/chromium/EventSender.h: Added.
- 10:39 PM Changeset in webkit [55712] by
-
- 1 edit4 adds in trunk/WebKitTools
2010-03-08 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add PlainTextController and TextInputController
https://bugs.webkit.org/show_bug.cgi?id=35852
Add PlainTextController and TextInputController classes, which are going
to be used by DumpRenderTree Chromium port. These files are based on:
- src/webkit/tools/test_shell/plain_text_controller.{cc,h} and
- src/webkit/tools/test_shell/text_input_controller.{cc,h} of Chromium rev.40492.
- DumpRenderTree/chromium/PlainTextController.cpp: Added.
- DumpRenderTree/chromium/PlainTextController.h: Added.
- DumpRenderTree/chromium/TextInputController.cpp: Added.
- DumpRenderTree/chromium/TextInputController.h: Added.
- 10:29 PM Changeset in webkit [55711] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Unreviewed. Fix a wrong bug number.
- 10:24 PM Changeset in webkit [55710] by
-
- 7 edits3 adds in trunk
2010-03-08 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Implement HTML5 <hgroup> element.
https://bugs.webkit.org/show_bug.cgi?id=32943
The new test file tests:
- <p> closing,
- Residual style, and
- FormatBlock.
- fast/html/hgroup-element-expected.txt: Added.
- fast/html/hgroup-element.html: Added.
- fast/html/script-tests/hgroup-element.js: Added.
2010-03-08 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Implement HTML5 <hgroup> element.
https://bugs.webkit.org/show_bug.cgi?id=33369
<hgroup> should behave the same as <nav>, <section>, <article>, and <aside>.
<hgroup> has no specific parsing rules.
Test: fast/html/hgroup-element.html
- css/html.css: Add hgroup as a block element.
- editing/htmlediting.cpp: (WebCore::validBlockTag): Add hgroupTag.
- html/HTMLElement.cpp: (WebCore::createTagPriorityMap): Returns 5 for hgroupTag. (WebCore::blockTagList): Add hgroupTag.
- html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add hgroupTag.
- html/HTMLTagNames.in: Add hgroup.
- 9:34 PM Changeset in webkit [55709] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, Chromium build fix.
Reverting r55689.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 9:15 PM Changeset in webkit [55708] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: 'P' is not a type. Luckily, 'void' is.
- wtf/FastMalloc.cpp:
(WTF::fastCheckConsistency):
- 9:10 PM Changeset in webkit [55707] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: export a new symbol.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 8:57 PM Changeset in webkit [55706] by
-
- 5 edits in trunk/JavaScriptCore
Switching malloc implementations requires a world rebuild
https://bugs.webkit.org/show_bug.cgi?id=35899
Reviewed by Maciej Stachowiak.
- wtf/FastMalloc.cpp:
(WTF::fastCheckConsistency):
(WTF::TCMallocStats::fastCheckConsistency):
- wtf/FastMalloc.h:
- wtf/ValueCheck.h:
(WTF::): Moved pointer checking into a helper function in FastMalloc.cpp,
so you can switch malloc implementations without rebuilding the world.
- 8:32 PM Changeset in webkit [55705] by
-
- 4 edits2 adds in trunk
2010-03-08 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=32131
Work around a crash when inserting an ordered list. This was caused
by incorrect logic when trying to restore a range from a location.
We compute the offset using TextIterator, but were sometimes using
VisiblePosition::next() to iterate instead.
- editing/execCommand/insert-ordered-list-expected.txt: Added.
- editing/execCommand/insert-ordered-list.html: Added.
2010-03-08 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=32131
Crash when inserting an ordered list.
Test: editing/execCommand/insert-ordered-list.html
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
- editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
- 8:21 PM Changeset in webkit [55704] by
-
- 2 edits in trunk/WebKitTools
2010-03-08 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
Fix webkit-patch post and land to work well with security bug
https://bugs.webkit.org/show_bug.cgi?id=35733
Bugzilla requires authentication to access security bug page,
so call authenticate() if it failed to fetch bug page.
- Scripts/webkitpy/bugzilla.py:
- 5:47 PM Changeset in webkit [55703] by
-
- 2 edits in trunk/WebKit/mac
2010-03-08 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
Move the new method to the end of the MIG definitions file, to avoid breaking
compatibility between WebKit and older versions of WebKitPluginHost.
- Plugins/Hosted/WebKitPluginHost.defs:
- 5:33 PM Changeset in webkit [55702] by
-
- 8 edits in trunk/WebKit/mac
2010-03-08 Simon Fraser <Simon Fraser>
Reviewed by Kevin Decker.
<rdar://problem/7714340> Need to grab image snapshot of Core Animation plugins
Allow plug-ins using the Core Animation drawing model to be captured when doing a flattening paint,
by sending them a drawRect event as if they were software-painting.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::snapshot): New snapshot() method that calls over to the plugin host, and then draws the image that comes back.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]): If we don't have a software renderer, but we're doing a flattening paint, then call the snapshot method.
- Plugins/Hosted/WebKitPluginHost.defs: Added snapshot method.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView inFlatteningPaint]): New utility method that asks the FrameView whether the current paint behavior is flattening.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]): If the plug-in is using CA but this is a flattening paint, go ahead and send a drawRect event to the plug-in.
- 5:14 PM Changeset in webkit [55701] by
-
- 3 edits1 add in trunk
WebCore: Added a test for crash when you quit inside an unload handler.
rdar://problem/6958347
Reviewed by Dan Bernstein.
- manual-tests/quit-inside-unload.html: Added.
WebKit/mac: Fix crash when you quit inside an unload handler.
rdar://problem/6958347
Reviewed by Dan Bernstein.
Test: manual-tests/quit-inside-unload.html
- WebView/WebView.mm:
(-[WebView _closeWithFastTeardown]): Removed code to set
_private->closed since _close now does this earlier, before
calling this method.
(-[WebView _close]): Moved code to set _private->closed to the
top of this method.
(-[WebView setHostWindow:]): Rewrote the code that forbade
setting the host window after closing so that it only forbids
non-nil host windows. That way, the code to clear away the host
window can run safely after setting _private->closed, yet client
code cannot set a new host window after closing.
- 5:08 PM Changeset in webkit [55700] by
-
- 2 edits in trunk/WebKit/mac
Roll out a file I checked in by accident.
- WebView/WebView.mm: Back to previous version.
- 5:06 PM Changeset in webkit [55699] by
-
- 4 edits2 adds in trunk
2010-03-08 Darin Adler <Darin Adler>
Reviewed by Jon Honeycutt.
Don't auto-play <audio> and <video> elements loaded in background tabs
https://bugs.webkit.org/show_bug.cgi?id=35886
rdar://problem/7117745
- manual-tests/video-in-non-frontmost-tab.html: Added.
- manual-tests/resources/video-tab.html: Added.
- html/HTMLMediaElement.h: Added MediaCanStartListener as a base class, and added the mediaCanStart function as well as a boolean, m_isWaitingUntilMediaCanStart.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_isWaitingUntilMediaCanStart. (WebCore::HTMLMediaElement::~HTMLMediaElement): Call removeMediaCanStartListener if m_isWaitingUntilMediaCanStart is true. (WebCore::HTMLMediaElement::loadInternal): Set m_isWaitingUntilMediaCanStart and call addMediaCanStartListener if canStartMedia is false. (WebCore::HTMLMediaElement::mediaCanStart): Clear m_isWaitingUntilMediaCanStart and call loadInternal.
- 5:00 PM Changeset in webkit [55698] by
-
- 1 edit in trunk/LayoutTests/platform/mac-leopard/Skipped
Fixed path in mac-leopard Skipped file. Was animation, now animations
- 4:56 PM Changeset in webkit [55697] by
-
- 2 edits in trunk
This turns back on HW comp on Leopard (which I turned off in http://trac.webkit.org/changeset/55696) if you have WebGL turned on. I've added the failing tests to the Skipped file instead
- 4:39 PM Changeset in webkit [55696] by
-
- 1 edit in trunk/WebKit/mac/WebView/WebView.mm
Backed out the half of http://trac.webkit.org/changeset/55690 that turned on HW accel for Leopard which was causing LayoutTests to fail
- 4:38 PM Changeset in webkit [55695] by
-
- 2 edits in trunk/WebKit/chromium
Chromium build fix.
Updated for the removal of "mightDownloadFromHandle".
- 4:35 PM Changeset in webkit [55694] by
-
- 2 edits in trunk/WebKit/gtk
[GTK] Unreviewed buildfix after r55688.
- webkit/webkitdownload.cpp:
(webkit_download_start):
- 4:30 PM Changeset in webkit [55693] by
-
- 2 edits in trunk/WebCore
[GTK] Unreviewed buildfix after r55688.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart):
- 4:26 PM Changeset in webkit [55692] by
-
- 2 edits in trunk/WebCore
[GTK] Unreviewed buildfix after r55688.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::):
- 4:19 PM Changeset in webkit [55691] by
-
- 2 edits in trunk/WebCore
[Qt] Unreviewed buildfix after r55688.
- platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):
- 4:11 PM Changeset in webkit [55690] by
-
- 1 edit in trunk/LayoutTests/platform/mac-leopard/Skipped
Added animation/fill-mode-transform.html to Skipped list for Leopard until https://bugs.webkit.org/show_bug.cgi?id=35714 is fixed
- 3:56 PM Changeset in webkit [55689] by
-
- 2 edits in trunk/WebKitTools
2010-03-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitry Glazkov.
Fix --clobber-old-results in new-run-webkit-tests.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 3:52 PM Changeset in webkit [55688] by
-
- 8 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35879
Eliminate m_mightDownloadFromHandle
It was only used on Mac, and unnecessarily complicated the code.
No change in behavior, thus no test.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load):
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle):
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
- 3:44 PM Changeset in webkit [55687] by
-
- 10 edits in trunk/WebCore
Clean up usage of m_failed in open-source image decoders, part 1.
https://bugs.webkit.org/show_bug.cgi?id=35411
Reviewed by Adam Barth.
Makes setFailed() virtual so subclasses can override it (none do yet) to
do automatic cleanup on failure; makes it return a bool for easy
tailcalling; makes failed() the only way to access m_failed so
subclasses are assured setFailed() won't be bypassed. Plus one or two
other tiny cleanup bits.
Overriding setFailed() is coming in a subsequent patch because it can be
hairy and needs close review.
No functional change, so no tests.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::internalDecodeSize):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::forceLoadEverything):
(WebCore::ImageDecoderQt::clearPointers):
- platform/graphics/qt/ImageDecoderQt.h:
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::ImageDecoder):
(WebCore::ImageDecoder::setData):
(WebCore::ImageDecoder::setSize):
(WebCore::ImageDecoder::setFailed):
(WebCore::ImageDecoder::failed):
- platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::isSizeAvailable):
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::processFileHeader):
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::isSizeAvailable):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):
- platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectory):
(WebCore::ICOImageDecoder::processDirectoryEntries):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::isSizeAvailable):
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingFailed):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::isSizeAvailable):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::decode):
- platform/image-decoders/png/PNGImageDecoder.h:
- 3:14 PM Changeset in webkit [55686] by
-
- 7 edits2 adds in trunk
[Chromium] Reset multiple form submission protection on mouse events.
https://bugs.webkit.org/show_bug.cgi?id=35128
Reviewed by Darin Fisher.
WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::mouseDown):
LayoutTests:
- fast/forms/multiple-form-submission-protection-mouse-expected.txt: Copied from LayoutTests/editing/execCommand/copy-without-selection-expected.txt.
- fast/forms/multiple-form-submission-protection-mouse.html: Added.
- 2:54 PM Changeset in webkit [55685] by
-
- 4 edits in trunk
When WebGL is enabled, enable hardware compositing bypassing check for CoreVideo bug fix
https://bugs.webkit.org/show_bug.cgi?id=35759
- 2:54 PM PythonGuidelines edited by
- Added preliminary instructions on how to install new versions of … (diff)
- 2:45 PM Changeset in webkit [55684] by
-
- 6 edits in trunk/JavaScriptCore
2010-03-07 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
TypeInfo is unnecessarily large
https://bugs.webkit.org/show_bug.cgi?id=35850
Reduce the size of the type and flags members to a single
byte each, reducing the size of Structure by 8 bytes.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::branch8): (JSC::MacroAssemblerX86Common::branchTest8): (JSC::MacroAssemblerX86Common::setTest8): Add single byte branches, and correct setTest8 to do a single byte read from memory, and actually store the result
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::cmpb_im): (JSC::X86Assembler::testb_im):
- jit/JITCall.cpp: (JSC::JIT::emit_op_construct_verify):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
- runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::type):
- 2:38 PM Changeset in webkit [55683] by
-
- 3 edits in trunk/WebKit/chromium
2010-03-08 Michael Nordman <Michael Nordman>
Reviewed by Darin Fisher.
Quick fix for a chromium unit test failures around r55675 (repaint refactoring).
This change restores the tests for empty rects that were deleted.
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::invalidateContentsAndWindow):
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::invalidateContentsAndWindow):
- 2:16 PM Changeset in webkit [55682] by
-
- 5 edits in trunk/WebCore
2010-03-08 Darin Adler <Darin Adler>
Reviewed by Jon Honeycutt.
Fix minor style issues in HTMLMediaElement and classes derived from it.
Made many public members private and protected.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::screenRect): Got rid of a stray "const" and retstructured the function to use early return and get rid of a local.
- html/HTMLMediaElement.h: Made lots of members private and some protected. Also use private inheritance instead of public. Removed some unneeded includes.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Use player() instead of m_player; HTMLMediaElement data members are now private, not protected. (WebCore::HTMLVideoElement::supportsFullscreen): Ditto. (WebCore::HTMLVideoElement::videoWidth): Ditto. (WebCore::HTMLVideoElement::videoHeight): Ditto. (WebCore::HTMLVideoElement::hasAvailableVideoFrame): Ditto. (WebCore::HTMLVideoElement::webkitEnterFullScreen): Use isFullscreen() instead of m_isFullscreen; same reason. (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto. (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
- html/HTMLVideoElement.h: Removed an unneeded include. Made many public functions private. Got rid of unused paint function, which was replaced with paintCurrentFrameInContext a while back.
- 2:07 PM Changeset in webkit [55681] by
-
- 1 edit in trunk/WebKit/chromium/public/WebPluginContainer.h
take out temporary define
- 1:06 PM Changeset in webkit [55680] by
-
- 10 edits in trunk
2010-03-08 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk
- platform/gtk/accessibility/table-hierarchy.html:
- platform/gtk/accessibility/table-hierarchy-expected.txt:
2010-03-08 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk
Gives platforms the ability to exclude parts of an AccessibilityTable
from the accessible hierarchy.
- accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibilityTable.cpp: (AccessibilityTable::addChildren):
- accessibility/AccessibilityTableColumn.h: (accessibilityIsIgnored):
- accessibility/AccessibilityTableHeaderContainer.h: (accessibilityIsIgnored):
- accessibility/AccessibilityTableRow.cpp: (accessibilityIsIgnored):
- 12:31 PM Changeset in webkit [55679] by
-
- 5 edits in trunk/JavaScriptCore
Reverting 55035, this caused a regression.
(https://bugs.webkit.org/show_bug.cgi?id=35843)
Reviewed by NOBODY (reverting regression).
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::JSString::getStringPropertySlot):
- runtime/UStringImpl.cpp:
- runtime/UStringImpl.h:
- 12:22 PM Changeset in webkit [55678] by
-
- 2 edits in trunk/WebKitTools
Followup to https://bugs.webkit.org/show_bug.cgi?id=35532
Reviewed by NOBODY (but suggested by Steve Falkenburg and fixing a boneheaded mistake on my part last week)
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::apiTestGoToCurrentBackForwardItem): Can't pass in a null BOOL to WebKit APIs.
- 12:21 PM Changeset in webkit [55677] by
-
- 2 edits in trunk/WebKit/win
Unreviewed build fix for Windows.
Patch by Adam Treat <atreat@rim.com> on 2010-03-08
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::invalidateContents):
- 12:03 PM Changeset in webkit [55676] by
-
- 3 edits in trunk/WebCore
No review. Fix build break on Tiger intel release.
- html/Blob.cpp:
- html/Blob.h:
- 11:43 AM Changeset in webkit [55675] by
-
- 33 edits in trunk
WebCore: Refactor the HostWindow methods for repaint, scroll, invalidate and blit
of backingstore and window by eliminating the three bools that currently
exist as params of the repaint method.
https://bugs.webkit.org/show_bug.cgi?id=34214
Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.
I've added extra methods to provide the hosts with more semantic
information of what is being requested thus eliminating the need for
these bools.
No tests as this change should not introduce any behavior changes in any
of the ports.
https://bugs.webkit.org/show_bug.cgi?id=34214
- loader/EmptyClients.h:
(WebCore::EmptyChromeClient::invalidateContents):
(WebCore::EmptyChromeClient::invalidateWindow):
(WebCore::EmptyChromeClient::invalidateContentsAndWindow):
(WebCore::EmptyChromeClient::invalidateContentsForSlowScroll):
- page/Chrome.cpp:
(WebCore::Chrome::invalidateContents):
(WebCore::Chrome::invalidateWindow):
(WebCore::Chrome::invalidateContentsAndWindow):
(WebCore::Chrome::invalidateContentsForSlowScroll):
- page/Chrome.h:
- page/ChromeClient.h:
- page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
- platform/HostWindow.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):
WebKit/chromium: Adapt the chromium port to the refactoring of repaint methods.
Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=34214
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::invalidateContents):
(WebKit::ChromeClientImpl::invalidateWindow):
(WebKit::ChromeClientImpl::invalidateContentsAndWindow):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):
- src/ChromeClientImpl.h:
WebKit/gtk: Adapt the gtk port to the refactoring of repaint methods.
Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=34214
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ChromeClientGtk.h:
WebKit/haiku: Adapt the haiku port to the refactoring of repaint methods.
Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=34214
- WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::invalidateContents):
(WebCore::ChromeClientHaiku::invalidateWindow):
(WebCore::ChromeClientHaiku::invalidateContentsAndWindow):
(WebCore::ChromeClient::invalidateContentsForSlowScroll):
- WebCoreSupport/ChromeClientHaiku.h:
WebKit/mac: Adapt the mac port to the refactoring of repaint methods.
Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=34214
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::invalidateContents):
(WebChromeClient::invalidateWindow):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::invalidateContentsForSlowScroll):
WebKit/qt: Adapt the qt port to the refactoring of repaint methods.
Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=34214
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::invalidateContents):
(WebCore::ChromeClientQt::invalidateWindow):
(WebCore::ChromeClientQt::invalidateContentsAndWindow):
(WebCore::ChromeClientQt::invalidateContentsForSlowScroll):
- WebCoreSupport/ChromeClientQt.h:
WebKit/win: Adapt the win port to the refactoring of repaint methods.
Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=34214
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::invalidateContents):
(WebChromeClient::invalidateWindow):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::invalidateContentsForSlowScroll):
- WebCoreSupport/WebChromeClient.h:
WebKit/wx: Adapt the wx port to the refactoring of repaint methods.
Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=34214
- WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::invalidateContents):
(WebCore::ChromeClientWx::invalidateWindow):
(WebCore::ChromeClientWx::invalidateContentsForSlowScroll):
(WebCore::ChromeClientWx::invalidateContentsAndWindow):
- WebKitSupport/ChromeClientWx.h:
- 11:40 AM Changeset in webkit [55674] by
-
- 3 edits2 adds in trunk
2010-03-08 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
[V8] Block popups from inline script
https://bugs.webkit.org/show_bug.cgi?id=35474
Test that we block popups generated from <script>window.open(...)</script>.
- http/tests/security/popup-blocked-from-window-open-expected.txt: Added.
- http/tests/security/popup-blocked-from-window-open.html: Added.
2010-03-08 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
[V8] Block popups from inline script
https://bugs.webkit.org/show_bug.cgi?id=35474
Apparently, we're supposed to look at the sourceURL to figure out
whether we're running a script tag or a hyperlink. This logic is
copied from the JSC version.
Test: http/tests/security/popup-blocked-from-window-open.html
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::evaluate):
- 11:22 AM Changeset in webkit [55673] by
-
- 10 edits2 adds in trunk
2010-03-08 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Adler.
Added a new USE definition for secure text mode on the Mac.
https://bugs.webkit.org/show_bug.cgi?id=31265
- wtf/Platform.h:
2010-03-08 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Adler.
Move the details of secure text mode into WebCore/platform.
Move the higher-level logic for secure text mode from Frame
to SelectionController.
No new tests: no functional changes.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp: (WebCore::Document::setUseSecureKeyboardEntryWhenActive):
- editing/SelectionController.cpp: (WebCore::SelectionController::focusedOrActiveStateChanged): (WebCore::SelectionController::updateSecureKeyboardEntryIfActive): (WebCore::SelectionController::setUseSecureKeyboardEntry):
- editing/SelectionController.h:
- page/Frame.cpp: (WebCore::Frame::setDocument):
- page/Frame.h:
- platform/SecureTextInput.cpp: Added. (WebCore::enableSecureTextInput): (WebCore::disableSecureTextInput):
- platform/SecureTextInput.h: Added. (WebCore::enableSecureTextInput): (WebCore::disableSecureTextInput):
- 10:49 AM Changeset in webkit [55672] by
-
- 6 edits4 adds in trunk
Relax the 3rd party cookie policy in cases where it won't add a new tracking vector.
<rdar://problem/7163012> and https://bugs.webkit.org/show_bug.cgi?id=35824
Reviewed by Anders Carlsson.
WebCore:
Test: http/tests/cookies/third-party-cookie-relaxing.html
If the 3rd-party domain in question already has a cookie set, allow changes
by setting the first party url of the request to be the url of the request itself:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::makeFinalRequest):
Ditto:
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
I've filed <rdar://problem/7728508> to track changing the policy in our networking layer.
LayoutTests:
- http/tests/cookies/resources/cookie-utility.php: Added.
- http/tests/cookies/resources/third-party-cookie-relaxing-iframe.html: Added.
- http/tests/cookies/third-party-cookie-relaxing-expected.txt: Added.
- http/tests/cookies/third-party-cookie-relaxing.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 10:32 AM Changeset in webkit [55671] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Fixed incorrect import statement in validate-committer-lists:
webkitpy.BeautifulSoup -> webkitpy.thirdparty.BeautifulSoup.
- Scripts/validate-committer-lists:
- 10:13 AM Changeset in webkit [55670] by
-
- 33 edits2 copies4 adds in trunk
.: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993
Reviewed by Dmitry Titov.
Add ENABLE_BLOB_SLICE feature define.
- configure.ac:
JavaScriptCore: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993
Reviewed by Dmitry Titov.
Add ENABLE_BLOB_SLICE feature define.
Also fix a problem that JSValue.toInteger is not exposed on Windows.
- Configurations/FeatureDefines.xcconfig:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
WebCore: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993
Reviewed by Dmitry Titov.
The following semantic is adopted per the discussions on public-webapps:
1) File.slice() does a synchronous IO to capture the current size and
modification time and cache them in the resulting Blob.
2) Subsequent Blob operations, like Blob.slice and Blob.size simply
use the cached values.
3) When the underlying file data are accessed, like in XHR.send(), the
UA will check the cached modification time against the current
modification time to determine if the file has been changed or not.
An error or exception will be thrown if needed.
Also add ENABLE_BLOB_SLICE feature define.
Test: http/tests/local/send-sliced-dragged-file.html
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pri:
- html/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::size):
(WebCore::Blob::slice):
- html/Blob.h:
(WebCore::Blob::start):
(WebCore::Blob::length):
(WebCore::Blob::modificationTime):
- html/Blob.idl:
- platform/network/FormData.cpp:
(WebCore::FormData::deepCopy):
(WebCore::FormData::appendFile):
(WebCore::FormData::appendFileRange):
- platform/network/FormData.h:
(WebCore::FormDataElement::FormDataElement):
(WebCore::operator==):
- platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream):
(WebCore::openNextStream):
(WebCore::formCreate):
(WebCore::formOpen):
(WebCore::formRead):
(WebCore::setHTTPBody):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
WebKit/chromium: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993
Reviewed by Dmitry Titov.
Add ENABLE_BLOB_SLICE feature define.
- features.gypi:
WebKit/mac: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993
Reviewed by Dmitry Titov.
Add ENABLE_BLOB_SLICE feature define.
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993
Reviewed by Dmitry Titov.
Add ENABLE_BLOB_SLICE feature define.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
WebKitTools: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993
Reviewed by Dmitry Titov.
Add ENABLE_BLOB_SLICE feature define and flag for build-webkit. It is
currently only turned on for Mac.
- Scripts/build-webkit:
LayoutTests: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993
Reviewed by Dmitry Titov.
Add a new layout test to test slicing and sending a file. In addition,
two new scripts are introduced to create and touch the temp file.
Move some code from send-dragged-file.js to a new file
setup-file-input-element-for-drag.js so that it can be used by both
send-dragged-file.js and send-sliced-dragged-file.js to setup the input
element for the file dragging.
Since the Blob.slice is only enabled for Mac, we disable the new test
for all other platforms.
- fast/dom/Window/window-properties.html:
- http/tests/local/resources/file-for-drag-to-send.txt:
- http/tests/local/resources/send-dragged-file.js:
- http/tests/local/resources/send-sliced-dragged-file.js: Added.
- http/tests/local/resources/setup-file-input-element-for-drag.js: Added.
- http/tests/local/send-dragged-file.html:
- http/tests/local/send-sliced-dragged-file-expected.txt: Added.
- http/tests/local/send-sliced-dragged-file.html: Added.
- http/tests/resources/touch-temp-file.php: Added.
- http/tests/resources/write-temp-file.php: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 9:54 AM Changeset in webkit [55669] by
-
- 4 edits4 adds in trunk
2010-03-08 Daniel Bates <dbates@rim.com>
Reviewed by Simon Fraser.
Fixes an issue where we repaint the caret rectangle even if the associated
selection is not in a content editable element. This is extraneous since the
caret is only visible when the selection is in a content editable element.
Hence, we should only repaint the caret rectangle when the associated selection
is in a content editable element.
Note, we always paint the caret when caret browsing is enabled.
Test: fast/repaint/no-caret-repaint-in-non-content-editable-element.html
- editing/SelectionController.cpp: (WebCore::SelectionController::recomputeCaretRect): Modified to call method SelectionController::shouldRepaintCaret. (WebCore::SelectionController::shouldRepaintCaret): Added. (WebCore::SelectionController::invalidateCaretRect): Modified to call method SelectionController::shouldRepaintCaret.
- editing/SelectionController.h:
2010-03-08 Daniel Bates <dbates@rim.com>
Reviewed by Simon Fraser.
Tests that we do not repaint the caret rectangle when the associated selection is
not in a content editable element.
- fast/repaint/no-caret-repaint-in-non-content-editable-element.html: Added.
- platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
- platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
- platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
- 9:36 AM Changeset in webkit [55668] by
-
- 3 edits in trunk/WebCore
2010-03-08 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
YouTube HTML5 video never starts playing on Windows
https://bugs.webkit.org/show_bug.cgi?id=33954
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::rfc2616DateStringFromTime): New, create an rfc 2616 formatted string for an absolute time value. (WebCore::addCookieParam): New, add a cookie param and value to a string builder. (WebCore::MediaPlayerPrivate::setUpCookiesForQuickTime): Copy cookies for the movie to
be loaded from CFNetwork into WinINet so they are available when QuickTime tries to
download the movie.
(WebCore::MediaPlayerPrivate::load): Call setupCookiesForQuickTime.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- 9:26 AM Changeset in webkit [55667] by
-
- 2 edits in trunk/WebKit/win
2010-03-08 Daniel Bates <dbates@rim.com>
Unreviewed, build fix.
Attempt to fix the Windows builds by applying the corresponding change
made in bug #35763 <https://bugs.webkit.org/show_bug.cgi?id=35763>.
- WebView.cpp: Removed call to settings->setDatabasesEnabled since this setting no longer exists following changeset 55666 <http://trac.webkit.org/changeset/55666>. (WebView::notifyPreferencesChanged):
- 8:41 AM Changeset in webkit [55666] by
-
- 14 edits in trunk
2010-03-08 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763
No new tests; this code isn't called.
- WebCore.base.exp:
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
2010-03-08 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763
No new tests; this code isn't called.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
- src/WebSettingsImpl.h:
2010-03-08 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763
No new tests; this code isn't called.
- webkit/webkitwebview.cpp: Remove the calls into Settings. (DNDContentsRequest::webkit_web_view_update_settings): (DNDContentsRequest::webkit_web_view_settings_notify):
2010-03-08 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763
No new tests; this code isn't called.
- WebView/WebView.mm: Remove the call into Settings. (-[WebView _preferencesChangedNotification:]):
2010-03-08 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763
No new tests; this code isn't called.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): Remove the call into Settings.
- 7:57 AM Changeset in webkit [55665] by
-
- 2 edits in trunk/WebKit/qt
2010-03-08 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Binary incompatibility between Qt 4.6's WebKit and trunk in QWebSettings
https://bugs.webkit.org/show_bug.cgi?id=35858
Moved the enum value added in r54873 to the end of the enum, to preserve
binary compatibility. DnsPrefetchEnabled was in the last release and needs
to remain after LocalContentCanAccessRemoteUrls.
- Api/qwebsettings.h:
- 7:41 AM Changeset in webkit [55664] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-03-08 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Holger Freyther.
[Qt] Added expected results and remove the test from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=35810
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
- platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.txt: Added.
- 7:07 AM Changeset in webkit [55663] by
-
- 4 edits in trunk
2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
No review, rolling out r55662.
http://trac.webkit.org/changeset/55662
https://bugs.webkit.org/show_bug.cgi?id=35863
Need to be coordinated with bots setup
- http/conf/apache2-debian-httpd.conf:
2010-03-08 Gustavo Noronha Silva <Gustavo Noronha Silva>
No review, rolling out r55662.
http://trac.webkit.org/changeset/55662
https://bugs.webkit.org/show_bug.cgi?id=35863
Need to be coordinated with bots setup
- Scripts/run-webkit-tests:
- 6:23 AM Changeset in webkit [55662] by
-
- 4 edits in trunk
LayoutTests
2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
[GTK] Tests fail when running with ipv6 addresses available, on Debian systems
https://bugs.webkit.org/show_bug.cgi?id=35863
Also listen for SSL requests on the ipv6 address.
- http/conf/apache2-debian-httpd.conf:
WebKitTools
2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
[GTK] Tests fail when running with ipv6 addresses available, on Debian systems
https://bugs.webkit.org/show_bug.cgi?id=35863
If running on a Debian-based system, also listen on the ipv6 address.
- Scripts/run-webkit-tests:
- 6:08 AM QtWebKitBugs edited by
- (diff)
- 5:21 AM Changeset in webkit [55661] by
-
- 2 edits in trunk/LayoutTests
2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
[GTK] DRT needs to support synthesizing double clicks
https://bugs.webkit.org/show_bug.cgi?id=35862
Skip test that needs a new feature in DRT.
- platform/gtk/Skipped:
- 5:16 AM Changeset in webkit [55660] by
-
- 3 edits in trunk/LayoutTests
2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Rebaseline two tests that had their expected results
changed.
- platform/gtk/inspector/timeline-network-resource-expected.txt:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- 4:19 AM Changeset in webkit [55659] by
-
- 5 edits in trunk/WebKit/chromium
2010-03-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Pass the WebFrame into WebStorageArea::setItem so we can figure out the routing ID
https://bugs.webkit.org/show_bug.cgi?id=35758
This is necessary since setItem is sometimes blocked and the embedder might need
to display some piece of UI associated with such an event.
- public/WebStorageArea.h: (WebKit::WebStorageArea::setItem):
- src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::setItem):
- src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem):
- src/WebStorageAreaImpl.h:
- 3:39 AM QtWebKitBugs edited by
- (diff)
- 3:23 AM QtWebKitBugs edited by
- (diff)
- 3:19 AM QtWebKitBugs edited by
- (diff)
- 3:17 AM QtWebKitBugs edited by
- (diff)
- 2:07 AM QtWebKitBackportingFixes edited by
- (diff)
- 2:06 AM QtWebKitRelease20 created by
- 2:06 AM QtWebKit edited by
- (diff)
- 2:04 AM QtWebKitBackportingFixes edited by
- (diff)
- 1:57 AM QtWebKit edited by
- (diff)
- 12:16 AM Changeset in webkit [55658] by
-
- 2 edits in trunk/WebKitTools
[iexploder] Automatically update htmltags.in and htmlattrs.in too
https://bugs.webkit.org/show_bug.cgi?id=33755
Change the update-iexploder-cssproperites script to update
the htmlattrs.in and htmltags.in of WebKitTools/iExploder/htdocs
automatically as well.
Change the reading and writing code to work with parameters
and extend the method that is parsing the .in files to handle
the HTMLTagNames.in and the HTMLAttributeNames.in files.
Remove custom code to determine the revision of files with a
utility of VCUtils.pm to determine the revision of the directory
these files are located in. This will also work with git checkout.
- Scripts/update-iexploder-cssproperties:
- 12:13 AM Changeset in webkit [55657] by
-
- 3 edits in trunk/WebCore
2010-03-04 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GStreamer] replace g_idle_add / g_timeout_add calls with Timers in the gstreamer player
https://bugs.webkit.org/show_bug.cgi?id=35735
Replaced g_idle_add calls with Timers immediately started once
only. The g_timeout_add was replaced by a periodic Timer.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedTimerFired): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::muteChangedTimerFired): (WebCore::MediaPlayerPrivate::muteChanged):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Mar 7, 2010:
- 10:55 PM Changeset in webkit [55656] by
-
- 3 edits in trunk/WebKitTools
2010-03-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style: false positive for empty loop
https://bugs.webkit.org/show_bug.cgi?id=35717
- Scripts/webkitpy/style/processors/cpp.py:
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- 9:02 PM Changeset in webkit [55655] by
-
- 1 edit4 adds in trunk/WebKitTools
2010-03-07 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add AccessibilityController and AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=35774
Add AccessibilityController and AccessibilityUIElement classes,
which are going to be used by DumpRenderTree Chromium port. These
files are based on:
- src/webkit/tools/test_shell/accessibility_controller.{cc,h} and
- src/webkit/tools/test_shell/accessibility_ui_element.{cc,h} of Chromium rev.40492.
- DumpRenderTree/chromium/AccessibilityController.cpp: Added.
- DumpRenderTree/chromium/AccessibilityController.h: Added.
- DumpRenderTree/chromium/AccessibilityUIElement.cpp: Added.
- DumpRenderTree/chromium/AccessibilityUIElement.h: Added.
- 7:56 PM Changeset in webkit [55654] by
-
- 2 edits in trunk/WebCore
Chromium Linux build fix.
- platform/graphics/chromium/FontPlatformDataLinux.h: Add "class String" since a debug
only method returns a String.
- 7:06 PM Changeset in webkit [55653] by
-
- 4 edits in trunk
Chromium build fix.
WebCore:
- platform/chromium/ClipboardChromium.cpp: Include Image.h since we're using WebCore::Image.
WebKit/chromium:
- src/ChromiumBridge.cpp: Include SharedBuffer.h since WebCore::SharedBuffer is being used.
- 7:02 PM Changeset in webkit [55652] by
-
- 2 edits in trunk/WebKit/win
Windows build fix.
- WebKitPrefix.h: Include CoreFoundation/CoreFoundation.h from the Windows prefix header
since some WebCore headers rely on the types declared within being available via the prefix
header.
- 6:57 PM Changeset in webkit [55651] by
-
- 2 edits in trunk/WebCore
Gtk build fix.
- platform/network/soup/ResourceHandleSoup.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
- 6:51 PM Changeset in webkit [55650] by
-
- 2 edits in trunk/WebCore
Gtk build fix.
- platform/graphics/gtk/ImageGtk.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
- 6:38 PM Changeset in webkit [55649] by
-
- 2 edits in trunk/WebCore
Fix builds where USE_CG_SHADING is set.
- platform/graphics/cg/GradientCG.cpp: Include wtf/RetainPtr.h since WTF::RetainPtr is used when USE_CG_SHADING is set.
- 6:33 PM Changeset in webkit [55648] by
-
- 4 edits in trunk/WebCore
Windows build fix. Add some required includes.
- platform/graphics/win/ImageCGWin.cpp:
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/win/ClipboardWin.cpp:
- 6:29 PM Changeset in webkit [55647] by
-
- 2 edits in trunk/WebCore
Gtk build fix.
- platform/graphics/GraphicsContext.h: Include wtf/PassOwnPtr.h since some platforms use WTF::PassOwnPtr in this header.
- 6:27 PM Changeset in webkit [55646] by
-
- 2 edits in trunk/WebCore
Qt build fix.
- platform/network/qt/ResourceHandleQt.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
- 6:23 PM Changeset in webkit [55645] by
-
- 2 edits in trunk/WebKit/chromium
Chromium build fix.
- src/ResourceHandle.cpp: Include SharedBuffer.h since WebCore::SharedBuffer is being used.
- 6:18 PM Changeset in webkit [55644] by
-
- 2 edits in trunk/WebCore
Gtk build fix.
- platform/gtk/ClipboardGtk.cpp: Include Imageh since we're using WebCore::Image.
- 6:17 PM Changeset in webkit [55643] by
-
- 19 edits in trunk
Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
Rubber-stamped by Cameron Zwarich.
WebCore:
- loader/CachedCSSStyleSheet.cpp:
- loader/CachedFont.cpp:
- loader/CachedImage.cpp:
- loader/CachedResource.cpp:
- loader/CachedResource.h:
- loader/CachedScript.cpp:
- loader/CachedXSLStyleSheet.cpp:
- loader/icon/IconFetcher.cpp:
- loader/loader.cpp:
- page/Page.cpp:
- platform/graphics/Image.cpp:
- platform/graphics/Image.h:
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
- platform/graphics/cg/PDFDocumentImage.cpp:
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/mac/ImageMac.mm:
WebKit/mac:
- Misc/WebIconDatabase.mm:
- 6:05 PM Changeset in webkit [55642] by
-
- 2 edits in trunk/WebCore
Chromium build fix.
- platform/chromium/ChromiumDataObject.h: Include SharedBuffer.h since the inline constructor of this
class means that the pointed-to type of the RefPtr member must be available.
- 6:05 PM Changeset in webkit [55641] by
-
- 2 edits in trunk/WebCore
Qt build fix.
- platform/network/qt/DnsPrefetchHelper.cpp: Include PlatformString.h since we're using WebCore::String.
- 5:53 PM Changeset in webkit [55640] by
-
- 3 edits3 adds2 deletes in trunk
2010-03-07 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
https://bugs.webkit.org/show_bug.cgi?id=35472
Add tests for radio buttons in a form element, and merge an existing
radio button test to ValidityState-valueMissing-radio.html.
- fast/forms/ValidityState-valueMissing-007-expected.txt: Removed.
- fast/forms/ValidityState-valueMissing-007.html: Removed.
- fast/forms/ValidityState-valueMissing-radio-expected.txt: Added.
- fast/forms/ValidityState-valueMissing-radio.html: Added.
- fast/forms/script-tests/ValidityState-valueMissing-radio.js: Added.
2010-03-07 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
https://bugs.webkit.org/show_bug.cgi?id=35472
Test: fast/forms/ValidityState-valueMissing-radio.html
- html/HTMLInputElement.cpp: (WebCore::checkedRadioButtons): Move the location to be used by valueMissing(). (WebCore::HTMLInputElement::valueMissing): Use checkedRadioButtons() instead of document()->checkedRadioButtons().
- 5:52 PM Changeset in webkit [55639] by
-
- 12 edits in trunk
Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
Rubber-stamped by Cameron Zwarich.
WebCore:
- bindings/objc/DOM.mm:
- loader/CachedImage.h:
- loader/EmptyClients.h:
- platform/graphics/GlyphPageTreeNode.cpp:
- platform/text/CString.h:
- platform/text/String.cpp:
- platform/text/mac/TextCodecMac.cpp:
- svg/graphics/SVGResourceFilter.h:
- svg/graphics/filters/SVGFEImage.h:
WebKit/mac:
- Misc/WebNSPasteboardExtras.mm:
- 5:52 PM Changeset in webkit [55638] by
-
- 2 edits in trunk/WebCore
Completely remove two files that were deleted in r55635 from the Xcode project.
- WebCore.xcodeproj/project.pbxproj:
- 5:26 PM Changeset in webkit [55637] by
-
- 7 edits in trunk
Remove inconsistent "Too few arguments" handling for window.atob() and window.btoa()
https://bugs.webkit.org/show_bug.cgi?id=35848
Reviewed by Dan Bernstein.
WebCore:
- Take the opportunity to fully autogenerate window.atob() and window.btoa().
- bindings/js/JSDOMWindowCustom.cpp:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/Window/atob-btoa-expected.txt:
- fast/dom/Window/atob-btoa.html:
- 5:02 PM PythonGuidelines edited by
- Minor updates. Added a FIXME to include upgrade instructions. (diff)
- 10:15 AM Changeset in webkit [55636] by
-
- 4 edits2 adds in trunk
<rdar://problem/7722008> Column breaking ignores floats
https://bugs.webkit.org/show_bug.cgi?id=35837
Reviewed by Simon Fraser.
WebCore:
Test: fast/multicol/float-truncation.html
Introduce an earlier column-break if otherwise a float that could fit
inside a single column will be split between columns.
It is still possible for floats to be needlessly broken if initially
they fit in the column, but normal flow truncation then shortens the
column.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::visibleTopOfHighestFloatExtendingBelow): Added.
Returns the visible top of the highest descendant float that visibly
extends below the given y offset, ignoring floats that are taller than
the given maximum height.
(WebCore::RenderBlock::layoutColumns): If the initial column height
would cause a float to be split, truncate above the float.
- rendering/RenderBlock.h:
LayoutTests:
- fast/multicol/float-truncation-expected.txt: Added.
- fast/multicol/float-truncation.html: Added.
- 8:59 AM Changeset in webkit [55635] by
-
- 24 edits9 deletes in trunk
Not reviewed. Revert of r55593 which caused a regression of worker-cloneports.html.
REGRESSION(55593?): fast/workers/worker-cloneport.html is timing out on Leopard
https://bugs.webkit.org/show_bug.cgi?id=35819
WebCore:
- Android.jscbindings.mk:
- Android.v8bindings.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDatabaseCallback.cpp: Removed.
- bindings/js/JSDatabaseCallback.h: Removed.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
- bindings/v8/custom/V8DatabaseCallback.h: Removed.
- dom/Document.cpp:
(WebCore::Document::postTask):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
- storage/Database.h:
- storage/DatabaseCallback.h: Removed.
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
- workers/WorkerContext.h:
LayoutTests:
- fast/frames/resources/sandboxed-iframe-storage-allowed.html:
- fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
- fast/frames/sandboxed-iframe-storage-expected.txt:
- storage/open-database-creation-callback-expected.txt: Removed.
- storage/open-database-creation-callback-isolated-world-expected.txt: Removed.
- storage/open-database-creation-callback-isolated-world.html: Removed.
- storage/open-database-creation-callback.html: Removed.
- platform/qt/Skipped:
- platform/mac-leopard/Skipped: Enable the temporarily disabled test back.
- 12:16 AM Changeset in webkit [55634] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-07 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Small performance fix in the QScriptConverter::toString().
The QByteArray was replaced by the QVarLengthArray which doesn't
have to allocate any memory on heap.
[Qt] QScriptConverter::toString() should use QVarLengthArray instead of QByteArray
https://bugs.webkit.org/show_bug.cgi?id=35577
- qt/api/qscriptconverter_p.h: (QScriptConverter::toString):
Mar 6, 2010:
- 9:44 PM Changeset in webkit [55633] by
-
- 76 edits in trunk
Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.
Rubber-stamped by Sam Weinig.
Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.
- API/APICast.h:
- API/JSCallbackFunction.cpp:
- API/JSContextRef.cpp:
- API/JSObjectRef.cpp:
- API/JSValueRef.cpp:
- assembler/ARMAssembler.h:
- assembler/ARMv7Assembler.h:
- assembler/AbstractMacroAssembler.h:
- assembler/AssemblerBuffer.h:
- assembler/AssemblerBufferWithConstantPool.h:
- assembler/CodeLocation.h:
- assembler/LinkBuffer.h:
- assembler/MIPSAssembler.h:
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerCodeRef.h:
- assembler/MacroAssemblerMIPS.h:
- assembler/MacroAssemblerX86.h:
- assembler/MacroAssemblerX86Common.h:
- assembler/MacroAssemblerX86_64.h:
- assembler/RepatchBuffer.h:
- assembler/X86Assembler.h:
- jit/JIT.h:
- jit/JITCode.h:
- jit/JITInlineMethods.h:
- jit/JITStubs.h:
- os-win32/stdint.h:
- runtime/JSAPIValueWrapper.h:
- runtime/JSImmediate.h:
- wtf/ASCIICType.h:
- wtf/StdLibExtras.h:
- wtf/VMTags.h:
- yarr/RegexCompiler.h:
- yarr/RegexInterpreter.h:
- yarr/RegexJIT.h:
- yarr/RegexParser.h:
- yarr/RegexPattern.h:
WebCore:
Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.
- accessibility/AccessibilityObject.h:
- dom/XMLTokenizer.cpp:
- dom/XMLTokenizerLibxml2.cpp:
- dom/XMLTokenizerQt.cpp:
- editing/TextAffinity.h:
- loader/FrameLoaderClient.h:
- page/FocusController.cpp:
- page/FrameTree.cpp:
- page/Geolocation.h:
- page/PositionCallback.h:
- page/PositionErrorCallback.h:
- platform/Cursor.h:
- platform/FileSystem.h:
- platform/FloatConversion.h:
- platform/KeyboardCodes.h:
- platform/PlatformKeyboardEvent.h:
- platform/PlatformTouchPoint.h:
- platform/SuddenTermination.h:
- platform/Widget.h:
- platform/graphics/Color.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatSize.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/openvg/PainterOpenVG.h:
- platform/graphics/openvg/SurfaceOpenVG.h:
- platform/network/ResourceHandleClient.h:
- platform/text/Base64.cpp:
- rendering/style/SVGRenderStyle.h:
- xml/XSLTProcessor.cpp:
- xml/XSLTProcessorLibxslt.cpp:
- xml/XSLTProcessorQt.cpp:
WebKit/qt:
Remove unnecessary includes of wtf/Platform.h. This is already pulled in by the prefix header.
- WebCoreSupport/EditCommandQt.cpp:
- 7:31 PM Changeset in webkit [55632] by
-
- 7 edits3 adds in trunk/WebCore
Move debug only JS wrapper-set tracking code into its own file.
https://bugs.webkit.org/show_bug.cgi?id=35839
Reviewed by Dan Bernstein.
- GNUmakefile.am: Added new files.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSDOMBinding.cpp:
(WebCore::cacheDOMObjectWrapper):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
Updated for new signature for willCacheWrapper and didUncacheWrapper.
- bindings/js/JSDOMWrapper.cpp: Added.
(WebCore::DOMObject::~DOMObject):
(WebCore::DOMObject::defineOwnProperty):
Moved from JSDOMBinding.cpp.
- bindings/js/JSDebugWrapperSet.cpp: Added.
(WebCore::JSDebugWrapperSet::shared):
(WebCore::JSDebugWrapperSet::JSDebugWrapperSet):
- bindings/js/JSDebugWrapperSet.h: Added.
(WebCore::JSDebugWrapperSet::add):
(WebCore::JSDebugWrapperSet::remove):
(WebCore::JSDebugWrapperSet::contains):
(WebCore::JSDebugWrapperSet::willCacheWrapper):
(WebCore::JSDebugWrapperSet::didUncacheWrapper):
Moved from JSDOMBinding.cpp.
- 4:38 PM Changeset in webkit [55631] by
-
- 11 edits5 copies in trunk/WebCore
Rubber-stamped by Dan Bernstein.
Move DOMObjectHashTableMap, DOMWrapperWorld and WebCoreJSClientData into
their own files.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMObjectHashTableMap.cpp: Copied from bindings/js/JSDOMBinding.cpp.
- bindings/js/DOMObjectHashTableMap.h: Copied from bindings/js/JSDOMBinding.h.
(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):
- bindings/js/DOMWrapperWorld.cpp: Copied from bindings/js/JSDOMBinding.cpp.
(WebCore::forgetWorldOfDOMNodesForDocument):
- bindings/js/DOMWrapperWorld.h: Copied from bindings/js/JSDOMBinding.h.
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::rememberDocument):
(WebCore::DOMWrapperWorld::forgetDocument):
(WebCore::DOMWrapperWorld::isNormal):
(WebCore::debuggerWorld):
(WebCore::pluginWorld):
(WebCore::currentWorld):
(WebCore::Document::getWrapperCache):
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/ScriptController.cpp:
- bindings/js/WebCoreJSClientData.h: Copied from bindings/js/JSDOMBinding.h.
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::~WebCoreJSClientData):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::getAllWorlds):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):
- bindings/js/WorkerScriptController.cpp:
- 3:01 PM Changeset in webkit [55630] by
-
- 3 edits in trunk/WebCore
Rubber-stamped by Sam Weinig.
Remove an unused method.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): Changed comment.
(WebCore::RenderBlock::floatRect): Removed.
- rendering/RenderBlock.h: Removed floatRect().
- 1:45 PM Changeset in webkit [55629] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Chromium: Restore devtools window activate upon node search complete.
- src/js/DevTools.js:
- 1:42 PM Changeset in webkit [55628] by
-
- 2 edits in trunk/WebCore
2010-03-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make timeline overview bars transparent to mouse events.
- inspector/front-end/inspector.css:
- 10:14 AM Changeset in webkit [55627] by
-
- 3 edits in trunk/WebCore
2010-03-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Jeremy Orlow.
Web Inspector: switching to/from Timeline Panel moves scroller.
(Also added couple of record details items as I was fixing it).
- English.lproj/localizedStrings.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get defaultFocusedElement): (WebInspector.TimelinePanel.prototype.show): (WebInspector.TimelinePanel.prototype._refreshRecords):
- 7:30 AM Changeset in webkit [55626] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-06 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
[Chromium] Embedder initiated loads should not always stop existing loads
https://bugs.webkit.org/show_bug.cgi?id=33862
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::reload): (WebKit::WebFrameImpl::loadRequest): (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::loadData):
- 7:13 AM Changeset in webkit [55625] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-06 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
[Chromium] spurious WebViewClient::didStopLoading if changing
location.hash while a subframe is still loading
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage): Call isLoadingInAPISense, which checks subframes.
- 6:57 AM Changeset in webkit [55624] by
-
- 1 edit1 delete in trunk/WebCore
2010-03-06 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Removed unnecessary WinCE file.
The same functionality is provided by platform/win/SystemTimeWin.cpp.
https://bugs.webkit.org/show_bug.cgi?id=35799
- platform/wince/SystemTimeWince.cpp: Removed.
- 6:40 AM Changeset in webkit [55623] by
-
- 4 edits2 adds in trunk
2010-03-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk
- platform/gtk/accessibility/table-hierarchy.html: Added.
- platform/gtk/accessibility/table-hierarchy-expected.txt: Added.
2010-03-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk
This completes the fixing of the Atk table hierarchy which was started
in bug #35418.
- accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::determineAccessibilityRole):
- 6:23 AM Changeset in webkit [55622] by
-
- 2 edits in trunk/WebKit/gtk
2010-03-06 Arno Renevier <arno@renevier.net>
Reviewed by Eric Seidel.
[Gtk] GEOLOCATION_POLICY_DECISION_CANCELLED unused
https://bugs.webkit.org/show_bug.cgi?id=35803
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
- 5:57 AM Changeset in webkit [55621] by
-
- 2 edits1 copy2 deletes in trunk/JavaScriptCore
2010-03-06 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Share OwnPtr.
https://bugs.webkit.org/show_bug.cgi?id=35776
Share OwnPtr implementation with BREW MP and remove OwnPtrBrew.
- wtf/OwnPtrBrew.cpp: Added. (WTF::deleteOwnedPtr):
- wtf/OwnPtrCommon.h:
- wtf/brew/OwnPtrBrew.cpp: Removed.
- wtf/brew/OwnPtrBrew.h: Removed.
- 5:20 AM Changeset in webkit [55620] by
-
- 8 edits2 adds in trunk
2010-03-06 Hironori Bono <hbono@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active
Added a layout test that verifies a plugin can receive keyboard events.
Unfortunately, this test works only on Mac.
- platform/gtk/Skipped: Skipped the new test because of the lack of eventSender.
- platform/qt/Skipped: ditto.
- platform/win/Skipped: Skipped the new test because NPP_HandleEvent() is not implemented.
- plugins/keyboard-events-expected.txt: Added.
- plugins/keyboard-events.html: Added.
2010-03-06 Hironori Bono <hbono@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active
This change is a WebKit-side change for this issue. It dispatches
Char events to plug-ins so plug-ins can receive non-ASCII characters
as well as ASCII characters.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent):
2010-03-06 Hironori Bono <hbono@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active
To test keyboard events on the test plugin, this change implements
NPCocoaEventKeyDown and NPCocoaEventKeyUp handlers so the plugin
can write log messages.
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (handleEventCocoa): Implemented the event handlers for NPCocoaKeyDown and NPCocoaEventKeyUp.
- 5:03 AM Changeset in webkit [55619] by
-
- 7 edits in trunk
2010-03-06 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
Moved implementations of window.btoa() and window.atob() from
JSDOMWindow to DOMWindow, and make V8DOMWindow use DOMWindow
functions instead of having a separate implementation. As a side effect, the
error message has changed from "Cannot decode base64" to one that
indicates DOM Exception, which is compatible to Firefox.
Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=35723
- fast/dom/Window/atob-btoa-expected.txt: Rebaselined expectation due to change of error message.
2010-03-06 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
Moved implementations of window.btoa() and window.atob() from
JSDOMWindow to DOMWindow, and make V8DOMWindow use DOMWindow
functions instead of having a separate implementation. As a side effect, the
error message has changed from "Cannot decode base64" to one that
indicates DOM Exception, which is compatible to Firefox.
Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=35723
No new test. No new functionality.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): Moved conversion code to DOMWindow and invoke it. Argument checking remains here.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::atobCallback): (WebCore::V8DOMWindow::btoaCallback): Remove conversion code and call DOMWindow APIs. Although argument checking remains here.
- page/DOMWindow.cpp: (WebCore::hasMultibyteCharacters): (WebCore::DOMWindow::btoa): (WebCore::DOMWindow::atob):
- page/DOMWindow.h: Moved Conversion code from JSDOMWindow, modifing to fit JSC independent.
- 4:43 AM Changeset in webkit [55618] by
-
- 2 edits2 adds in trunk/WebKit/chromium
2010-03-06 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Darin Fisher.
Create WebKit API for WebCore::ImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=35415
- WebKit.gyp:
- public/WebImageDecoder.h: Added.
- src/WebImageDecoder.cpp: Added.
- 4:26 AM Changeset in webkit [55617] by
-
- 3 edits in trunk/WebCore
2010-03-06 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
Fix decoration position in search input field.
This patch fixes rendering of input field of "search" type, whose decoration
(loupe icon and close button) was wrongly positioned when the input field was
contained in a block with -webkit-transform property.
Chromium bug: http://crbug.com/20439
[Chromium] Decoration of "search" input field is wrongly rendered
https://bugs.webkit.org/show_bug.cgi?id=30245
No new tests, since this patch fixes an existing test
(fast/forms/search-transformed.html) in Chromium layout tests.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::convertToPaintingRect): Added. This method does almost the same thing as RenderThemeMac::convertToPaintingRect. (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): The position of the icon should not depend on its absolute position. (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): Ditto. (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): Ditto.
- rendering/RenderThemeChromiumSkia.h: Added new method.
- 3:50 AM Changeset in webkit [55616] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-03-06 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Added expected results and removed the test from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=35806
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
- platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
- platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.txt: Added.
- 3:31 AM Changeset in webkit [55615] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-06 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Implemented JIT_OPTIMIZE_NATIVE_CALL for WinCE
https://bugs.webkit.org/show_bug.cgi?id=33426
- jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
- 3:00 AM Changeset in webkit [55614] by
-
- 5 edits in trunk
2010-03-06 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: in Timeline panel, click followed with mouse move resets popover.
- inspector/front-end/Popover.js: (WebInspector.PopoverHelper.prototype._mouseDown): (WebInspector.PopoverHelper.prototype._mouseMove): (WebInspector.PopoverHelper.prototype._handleMouseAction):
Mar 5, 2010:
- 11:28 PM Changeset in webkit [55613] by
-
- 3 edits2 adds in trunk
2010-03-05 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=33247
Backwards cursor movement incorrect when previous block ends with <br>.
If the cursor is trying to move into a node that has a height of 0,
skip over it.
- editing/execCommand/move-selection-back-line-expected.txt: Added.
- editing/execCommand/move-selection-back-line.html: Added.
2010-03-05 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=33247
Backwards cursor movement incorrect when previous block ends with <br>.
If the cursor is trying to move into a node that has a height of 0,
skip over it.
Test: editing/execCommand/move-selection-back-line.html
- editing/visible_units.cpp: (WebCore::previousLinePosition):
- 11:11 PM Changeset in webkit [55612] by
-
- 2 edits in trunk/WebCore
2010-03-05 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Eric Seidel.
Enable resource loading callback while loading worker scripts
https://bugs.webkit.org/show_bug.cgi?id=35744
- workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously):
- 10:45 PM Changeset in webkit [55611] by
-
- 6 edits2 adds in trunk
2010-03-05 Chris Fleizach <Chris Fleizach>
Reviewed by Eric Seidel.
WAI-ARIA live region doesn't appear when <div> only has a <div> child
https://bugs.webkit.org/show_bug.cgi?id=35751
- platform/mac/accessibility/div-containing-div-with-aria-expected.txt: Added.
- platform/mac/accessibility/div-containing-div-with-aria.html: Added.
2010-03-05 Chris Fleizach <Chris Fleizach>
Reviewed by Eric Seidel.
WAI-ARIA live region doesn't appear when <div> only has a <div> child
https://bugs.webkit.org/show_bug.cgi?id=35751
Elements should not be ignored if they carry ARIA attributes in them.
Test: platform/mac/accessibility/div-containing-div-with-aria.html
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::supportsARIAAttributes):
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::supportsARIADropping): (WebCore::AccessibilityObject::supportsARIADragging):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::supportsARIADropping): (WebCore::AccessibilityRenderObject::supportsARIADragging): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
- 7:48 PM Changeset in webkit [55610] by
-
- 2 edits in trunk/WebKitTools
2010-03-05 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Eric Seidel.
Fix Print option on QtLauncher by calling print directly from QWebFrame.
[Qt] QtLauncher Print option is not working on QGraphicsView mode
https://bugs.webkit.org/show_bug.cgi?id=35769
- QtLauncher/main.cpp: (LauncherWindow::print):
- 7:16 PM Changeset in webkit [55609] by
-
- 1 edit1 add in trunk/WebCore
Add a manual test for crash in DOMWindow::clearTimeout when DOMWindow is not connected to Frame
https://bugs.webkit.org/show_bug.cgi?id=32353
Reviewed by Oliver Hunt.
- manual-tests/clearTimeout-crash-bug29832.html: Added.
- 7:04 PM Changeset in webkit [55608] by
-
- 3 edits3 adds in trunk
[v8] Remove wrong assert in GC callback.
https://bugs.webkit.org/show_bug.cgi?id=35757
Reviewed by David Levin.
WebCore:
Test: fast/workers/wrapper-map-gc.html
- bindings/v8/DOMData.h:
(WebCore::DOMData::handleWeakObject): remove ASSERT(isMainThread()), move another assert up to verify we are on the right thread.
LayoutTests:
- fast/workers/resources/wrapper-map-gc.js: Added.
- fast/workers/wrapper-map-gc.html: Added.
- fast/workers/wrapper-map-gc-expected.txt: Added.
- 6:52 PM Changeset in webkit [55607] by
-
- 14 edits4 copies10 adds in trunk
2010-03-05 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added tests for row and operator stretching.
Updated over, underover, and subsup due to row/operators in use.
- mathml/presentation/mo.xhtml: Added.
- mathml/presentation/row.xhtml: Added.
- platform/mac/mathml/presentation/mo-expected.checksum: Added.
- platform/mac/mathml/presentation/mo-expected.png: Added.
- platform/mac/mathml/presentation/mo-expected.txt: Added.
- platform/mac/mathml/presentation/over-expected.checksum:
- platform/mac/mathml/presentation/over-expected.png:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/row-expected.checksum: Added.
- platform/mac/mathml/presentation/row-expected.png: Added.
- platform/mac/mathml/presentation/row-expected.txt: Added.
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/underover-expected.checksum:
- platform/mac/mathml/presentation/underover-expected.png:
- platform/mac/mathml/presentation/underover-expected.txt:
2010-03-05 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added support for row layout with stretchy operators and
adjusted the over spacing for over and underover accordingly.
Tests: mathml/presentation/mo.xhtml
mathml/presentation/row.xhtml
- WebCore.xcodeproj/project.pbxproj:
- mathml/MathMLInlineContainerElement.cpp:
- mathml/MathMLTextElement.cpp:
- mathml/RenderMathMLMath.cpp: Added.
- mathml/RenderMathMLMath.h: Added.
- mathml/RenderMathMLOperator.cpp: Added.
- mathml/RenderMathMLOperator.h: Added.
- mathml/RenderMathMLRow.cpp: Added.
- mathml/RenderMathMLRow.h: Added.
- mathml/RenderMathMLUnderOver.cpp:
- mathml/mathtags.in:
- 6:34 PM Changeset in webkit [55606] by
-
- 3 edits in trunk/WebKit/chromium
2010-03-05 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
Take out code hack that flips the result of NPP_HandleEvent. This needs to move to
the NPAPI code so that Pepper plugins don't hit it.
https://bugs.webkit.org/show_bug.cgi?id=35779
- public/WebPluginContainer.h:
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
- 6:27 PM Changeset in webkit [55605] by
-
- 3 edits2 adds in trunk
2010-03-05 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=35772
Animation fill modes should be supported in the shorthand property
Add CSSPropertyWebkitAnimationFillMode to the list of properties
evaluated in the -webkit-animation shorthand.
Test: animations/animation-shorthand.html
- css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationShorthand):
- 5:09 PM Changeset in webkit [55604] by
-
- 2 edits in trunk/LayoutTests
2010-03-05 Eric Seidel <eric@webkit.org>
No review. Skipping recently regressed test to unblock the commit-queue (20 patches waiting).
REGRESSION(55593?): fast/workers/worker-cloneport.html is timing out on Leopard
https://bugs.webkit.org/show_bug.cgi?id=35819
- platform/mac-leopard/Skipped:
- 4:52 PM Changeset in webkit [55603] by
-
- 19 edits in trunk/WebKitTools
Changed the logging code for new-run-webkit-tests to use
module-specific loggers rather than the root logger. This is
a standard practice that allows logging specific to a package
to be configured independently of other modules.
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=35194
Added a line of the form "_log = logging.getLogger(<module>)"
to each module below, where <module> is the fully-qualified
name of the module, and updated the log lines to use the new
_log logger.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server_base.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 4:38 PM Changeset in webkit [55602] by
-
- 3 edits1 add in trunk/WebKitTools
2010-03-05 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
Split the command-line invocation of the Chromium/python LigHTTPd
server implementation out into its own top level script to make it
a more "public" interface and to resolve some awkward layering
issues. This script will be called directly by other test scripts in
the Chromium tree.
At some point this script should be made to work with Apache-based
implementations and on other ports. I have filed
https://bugs.webkit.org/show_bug.cgi?id=35820 for this.
Also fix a bug in port/factory where options.chromium could be
dereferenced even if it wasn't set, raising an exception.
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/new-run-webkit-httpd: Added
- 4:21 PM Changeset in webkit [55601] by
-
- 11 edits in trunk
2010-03-05 Dean Jackson <dino@apple.com>
Reviewed by NOBODY (OOPS!).
https://bugs.webkit.org/show_bug.cgi?id=35815
Animation Fill Modes fail on Windows
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSStyleSelector.cpp:
- platform/graphics/mac/GraphicsLayerCA.mm:
- use new enum value
- platform/animation/Animation.h:
- change bitfield type
- rendering/style/RenderStyleConstants.h:
- add new enum for fill mode
- 3:44 PM Changeset in webkit [55600] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-05 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (build fix).
Add enw exports to windows
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:29 PM Changeset in webkit [55599] by
-
- 5 edits in trunk/JavaScriptCore
2010-03-05 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
JSC should cache int to Identifier conversion as it does for ordinary strings
https://bugs.webkit.org/show_bug.cgi?id=35814
Make the NumericStrings cache cache unsigned ints in addition to signed.
We keep them separate from the int cache as it both simplifies code, and
also because the unsigned path is exclusive to property access and therefore
seems to have different usage patterns.
The primary trigger for the unsigned to Identifier propertyName conversion
is the construction of array-like objects out of normal objects. Given these
tend to be relative small numbers, and the array-like behaviour lends itself
to sequential values this patch also adds a non-colliding cache for all small
numbers.
- JavaScriptCore.exp:
- runtime/Identifier.cpp: (JSC::Identifier::from):
- runtime/Identifier.h:
- runtime/NumericStrings.h: (JSC::NumericStrings::add): (JSC::NumericStrings::lookup): (JSC::NumericStrings::lookupSmallString):
- 3:26 PM Changeset in webkit [55598] by
-
- 2 edits in trunk/WebCore
Unreviewed buildfix after r55593. (To fix Qt --minimal build.)
- bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added.
- 2:55 PM Changeset in webkit [55597] by
-
- 3 edits5 adds in trunk
2010-03-05 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com
https://bugs.webkit.org/show_bug.cgi?id=34065
<rdar://problem/7573509>
Fix one instance of this assertion (not necessarily the one seen on hulu.com).
If the layer that clippingRoot() is being called on is itself compositing,
then it acts as the clipping root. Without this, calls to RenderLayer::childrenClipRect()
and RenderLayer::selfClipRect() via FrameView::windowClipRectForLayer(), for plug-ins,
caused the caching of an incorrect clip rects root.
Test: compositing/geometry/object-clip-rects-assertion.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::clippingRoot):
- 2:53 PM Changeset in webkit [55596] by
-
- 2 edits in trunk/LayoutTests
2010-03-05 Dean Jackson <dino@apple.com>
No review.
Disabling animations/fill-mode-transform.html on Leopard
due to https://bugs.webkit.org/show_bug.cgi?id=35714
- platform/mac-leopard/Skipped:
- 2:46 PM Changeset in webkit [55595] by
-
- 2 edits in trunk/WebCore
2010-03-05 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Child clipping compositing layers don't show the blue debug color
https://bugs.webkit.org/show_bug.cgi?id=35807
Set a layer owner on the GraphicsLayers created for clipping children,
so that they can get to the debug settings that give them the blue color.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateClippingLayers):
- 2:43 PM Changeset in webkit [55594] by
-
- 3 edits4 adds in trunk
2010-03-05 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
MobileMe movie page is missing playback controls
https://bugs.webkit.org/show_bug.cgi?id=35805
<rdar://problem/7653169>
On pages with video or plug-ins, we run overlap tests to determine which layers
need to be composited. There was an ordering dependency bug in
RenderLayerCompositor::computeCompositingRequirements() that caused us to fail
to detect that a layer needed to be composited, resulting in page content
not being visible.
Specifically, layer->setHasCompositingDescendant() can change the answer
to needsToBeComposited(), when a layer has to clip compositing descendants.
So if we change setHasCompositingDescendant(), then we need to re-test
clipsCompositingDescendants() and add the layer to the overlap map if so.
Test: compositing/overflow/overflow-compositing-descendant.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 2:17 PM Changeset in webkit [55593] by
-
- 23 edits9 adds in trunk
WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().
Reviewed by Adam Barth.
Test: storage/open-database-creation-callback.html
https://bugs.webkit.org/show_bug.cgi?id=34726
- Android.jscbindings.mk
- Android.v8bindings.mk
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
- bindings/js/JSDatabaseCallback.cpp: Added.
(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):
- bindings/js/JSDatabaseCallback.h: Added.
(WebCore::JSDatabaseCallback::create):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- bindings/v8/custom/V8DatabaseCallback.cpp: Added.
(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):
- bindings/v8/custom/V8DatabaseCallback.h: Added.
(WebCore::V8DatabaseCallback::create):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/Database.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):
- storage/Database.h:
(WebCore::Database::isNew):
- storage/DatabaseCallback.h: Added.
(WebCore::DatabaseCallback::~DatabaseCallback):
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
- workers/WorkerContext.h:
LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.
Reviewed by Adam Barth.
Also, fixing fast/frames/sandboxed-iframe-storage.html: calling
openDatabase() without at least 4 parameters should always fail,
because the database name, version, description and estimated size
are not optional according to the spec.
https://bugs.webkit.org/show_bug.cgi?id=34726
- fast/frames/resources/sandboxed-iframe-storage-allowed.html:
- fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
- fast/frames/sandboxed-iframe-storage-expected.txt:
- platform/qt/Skipped:
- storage/open-database-creation-callback-expected.txt: Added.
- storage/open-database-creation-callback.html: Added.
- storage/open-database-creation-callback-isolated-world-expected.txt: Added.
- storage/open-database-creation-callback-isolated-world.html: Added.
- 1:04 PM Changeset in webkit [55592] by
-
- 13 edits in trunk
Fixed crash due to infinite recursion when viewing composited video on Windows
https://bugs.webkit.org/show_bug.cgi?id=35798
- 10:33 AM Changeset in webkit [55591] by
-
- 3 edits in trunk/LayoutTests
Update getComputedStyle results on Windows.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 10:26 AM Changeset in webkit [55590] by
-
- 2 edits in trunk/WebCore
2010-03-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
[Chromium] Missing commas in WebCore.gypi file make building Geo unpossible.
https://bugs.webkit.org/show_bug.cgi?id=35797
No new tests, this is a latent compile break.
- WebCore.gypi:
- 10:12 AM Changeset in webkit [55589] by
-
- 3 edits in trunk/LayoutTests
2010-03-05 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Use a movie that will hopefully fail to open less often on a headless
SnowLeopard bot.
- media/video-preload-expected.txt:
- media/video-preload.html: Use test.mp4 instead of silence.mpg.
- 9:39 AM QtWebKitBugs edited by
- (diff)
- 9:32 AM Changeset in webkit [55588] by
-
- 2 edits in trunk/LayoutTests
2010-03-05 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
media/video-preload.html fails on GTK, skip it.
- platform/gtk/Skipped:
- 9:13 AM Changeset in webkit [55587] by
-
- 7 edits2 adds in trunk
2010-03-04 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/7718442> Implement 'preload=none'
https://bugs.webkit.org/show_bug.cgi?id=35789
Don't load any media data when preload is 'none'.
Test: media/video-preload.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Don't call player's setPreload method
when autoplay is set.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setPreload): Set m_preload so we have the correct value when
the media engine is created.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_preload. (WebCore::MediaPlayerPrivate::resumeLoad): New, kick off postponed a load. (WebCore::MediaPlayerPrivate::load): Do nothing if preload is 'none' (WebCore::MediaPlayerPrivate::loadInternal): New, complete loading. (WebCore::MediaPlayerPrivate::prepareToPlay): New, resume a postponed load as someone
has called play().
(WebCore::MediaPlayerPrivate::setPreload): New, set m_preload.
2010-03-04 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/7718442> Implement 'preload=none'
https://bugs.webkit.org/show_bug.cgi?id=35789
Functional test of the 'proload' attribute.
- media/video-preload-expected.txt: Added.
- media/video-preload.html: Added.
- platform/win/Skipped: Skip on Windows for now.
- 8:53 AM Changeset in webkit [55586] by
-
- 3 edits in trunk/WebCore
2010-03-04 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Give CodeGeneratorV8.pm a much-needed spring cleaning.
- bindings/scripts/CodeGeneratorV8.pm: Remove unused code, fix style issues, make less hard-coded.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::addEventListenerCallback): (WebCore::V8DOMWindow::removeEventListenerCallback):
- 8:16 AM Changeset in webkit [55585] by
-
- 5 edits in trunk
[Gtk] Implement setSpatialNavigationEnabled in DRT.
https://bugs.webkit.org/show_bug.cgi?id=35705
Reviewed by Holger Freyther
Patch by Antonio Gomes <tonikitoo@webkit.org>
WebKitTools:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setSpatialNavigationEnabled):
LayoutTests:
- platform/gtk/Skipped:
- 8:13 AM Changeset in webkit [55584] by
-
- 26 edits3 deletes in trunk
2010-03-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Roll back r55522 since it regreses performance
according to chromium's page cycler.
- 8:07 AM Changeset in webkit [55583] by
-
- 3 edits in trunk/WebKit/gtk
[Gtk] Add 'enable-spatial-navigation' setting for Spatial Navigation on/off.
https://bugs.webkit.org/show_bug.cgi?id=35701
Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):
- webkit/webkitwebview.cpp:
(DNDContentsRequest::webkit_web_view_update_settings):
(DNDContentsRequest::webkit_web_view_settings_notify):
- 8:04 AM Changeset in webkit [55582] by
-
- 6 edits in trunk/WebKitTools
Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations.
https://bugs.webkit.org/show_bug.cgi?id=35699
Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- DumpRenderTree/LayoutTestController.cpp:
(setSpatialNavigationEnabledCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setSpatialNavigationEnabled):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setSpatialNavigationEnabled):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setSpatialNavigationEnabled):
- 8:01 AM Changeset in webkit [55581] by
-
- 2 edits in trunk/WebKitTools
[Qt] Add toggle on/off mechanism for Spatial Navigation in QtLauncher.
Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- QtLauncher/main.cpp:
(LauncherWindow::toggleSpatialNavigation):
(LauncherWindow::setupUI):
- 7:58 AM Changeset in webkit [55580] by
-
- 5 edits in trunk
[Qt] Add setSpatialNavigationEnabled method DRT
https://bugs.webkit.org/show_bug.cgi?id=33715
Reviewed by Simon Hausmann.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Added setSpatialNavigationEnabled support to Qt DRT.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setSpatialNavigationEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
Unskipped fast/events/spatial-navigation/
- 7:49 AM Changeset in webkit [55579] by
-
- 3 edits in trunk/WebKit/qt
[Qt] QWebSettings attribute for toggle Spatial Navigation on/off
https://bugs.webkit.org/show_bug.cgi?id=33714 (Qt API part)
Reviewed by Simon Hausmann.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Added 'SpatialNavigationEnabled' attribute to QWebSettings.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
- Api/qwebsettings.h:
- 7:48 AM Changeset in webkit [55578] by
-
- 1 edit4 adds in trunk/LayoutTests
Extend keyboard navigation to allow directional navigation (LayoutTests - part II)
https://bugs.webkit.org/show_bug.cgi?id=18662
Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
This patch adds two LayoutTest to ensure the basic table traversal correctness of
Spatial Navigation (SNav) algorithm: focusable elements in a <table> should be accessible.
- fast/events/spatial-navigation/snav-table-traversal.html: Added. Makes sure all elements in a <table> are accessible via Spatial Navigation.
- fast/events/spatial-navigation/snav-tiny-table-traversal.html: Added. Tests the similar table traversal scenario as above, but in this case the elements in the <table> are styled with 'font-size: small'. That way this test also validades that overlapping rects of elements too closed from each other are correctly handled.
- 7:46 AM Changeset in webkit [55577] by
-
- 5 edits3 adds in trunk/LayoutTests
Extend keyboard navigation to allow directional navigation (LayoutTests - part I)
https://bugs.webkit.org/show_bug.cgi?id=18662
Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
This patch adds support for auto testing the Spatial Navigation feature by:
1) Creating the directory where the tests are going to live in, named
fast/events/spatial-navigation/.
2) Skipping this directory by Mac, Qt, Gtk and Win.
3) Adding a JS file drives the test execution by processing, for each test,
a given set of arrow key actions and verify if the right expected Element
got the focus after each event processed. This file is
fast/events/spatial-navigation/resources/spatial-navigation-utils.js
- LayoutTests/fast/events/spatial-navigation/snav-vertical-superprecedence.html: Added.
- 7:42 AM QtWebKitJournal edited by
- (diff)
- 7:31 AM QtWebKitJournal edited by
- (diff)
- 7:31 AM QtWebKitJournal edited by
- (diff)
- 7:30 AM QtWebKitJournal edited by
- (diff)
- 7:28 AM QtWebKitJournal edited by
- (diff)
- 7:27 AM QtWebKitJournal edited by
- (diff)
- 7:23 AM QtWebKitJournal edited by
- (diff)
- 7:23 AM QtWebKitJournal edited by
- (diff)
- 7:22 AM QtWebKitJournal edited by
- (diff)
- 7:17 AM QtWebKit edited by
- (diff)
- 7:11 AM QtWebKitBugs edited by
- (diff)
- 6:06 AM QtWebKit edited by
- (diff)
- 6:06 AM QtWebKit edited by
- (diff)
- 4:58 AM Changeset in webkit [55576] by
-
- 25 edits6 adds in trunk
2010-03-05 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser and Chris Marrin.
Bug 26869: Add fill modes for CSS Animations
https://bugs.webkit.org/show_bug.cgi?id=26869
Tests: animations/fill-mode-removed.html
animations/fill-mode-transform.html
animations/fill-mode.html
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSParser.cpp:
- css/CSSParser.h:
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
- css/CSSStyleSelector.h:
- css/CSSValueKeywords.in:
- parse, assign and retrieve the value of the new -webkit-animation-fill-mode property
- page/animation/AnimationBase.cpp:
- page/animation/AnimationBase.h:
- new state in animation engine for a finished animation that is "filling" forwards in time. This allows the engine to keep the animation around and not revert to the old style.
- update the timer code to indicate it doesn't need to keep animating if it is filling
- now that animations can extend beyond their elapsed time, make sure progress works correctly with iteration counts
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
- ensure correct style value is returned at the right time by checking for fill mode
(WebCore::KeyframeAnimation::onAnimationEnd):
- continue to send the end event, but only remove the animation if it isn't filling forwards
- platform/animation/Animation.cpp:
- platform/animation/Animation.h:
- new fill mode member property
- platform/animation/AnimationList.cpp:
- ensure the fill mode is propagated to a list of style valus
- platform/graphics/mac/GraphicsLayerCA.mm:
- make hardware layers use Core Animation's fill mode
- 2:09 AM Changeset in webkit [55575] by
-
- 8 edits in trunk
2010-03-05 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Do not show link helper in popovers and/or for external resources.
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.hide):
- inspector/front-end/inspector.js: (WebInspector.documentMouseOver): (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.addMainEventListeners):
- 1:51 AM Changeset in webkit [55574] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-03-05 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket test to transfer null character
https://bugs.webkit.org/show_bug.cgi?id=35715
- websocket/tests/null-character-expected.txt: Added.
- websocket/tests/null-character.html: Added.
- websocket/tests/script-tests/null-character.js: Added.
- 1:35 AM Changeset in webkit [55573] by
-
- 7 edits4 adds in trunk
2010-03-05 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket onmessageerror event handler
https://bugs.webkit.org/show_bug.cgi?id=35570
- websocket/tests/error-detect-expected.txt: Added.
- websocket/tests/error-detect.html: Added.
- websocket/tests/script-tests/error-detect.js: Added.
- websocket/tests/unknown-frame-type_wsh.py: Added.
2010-03-05 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket onmessageerror event handler
https://bugs.webkit.org/show_bug.cgi?id=35570
Test: websocket/tests/error-detect.html
- websockets/WebSocket.cpp: (WebCore::WebSocketChannel::didConnect): assert scriptExecutionContext. (WebCore::WebSocketChannel::didReceiveMessage): assert scriptExecutionContext. (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didClose): assert scriptExecutionContext.
- websockets/WebSocket.h:
- websockets/WebSocket.idl: Add onerror event listener
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): call didReceiveMessageError if unknown frame tye is detected, or frame length overflowed.
- websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didReceiveMessageError):
Mar 4, 2010:
- 10:09 PM Changeset in webkit [55572] by
-
- 6 edits in trunk
2010-03-04 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Changing private members from PlatformTouchEvent and PlatformTouchPoint
to be protected, so that Chromium's PlatformTouchEventBuilder and
PlatformTouchPointBuilder can access them. Exercised by the
fast/events/touch tests.
https://bugs.webkit.org/show_bug.cgi?id=35760
- platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::~PlatformTouchEvent):
- platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::~PlatformTouchPoint):
2010-03-04 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Adding PlatformTouchEventBuilder and PlatformTouchPointBuilder for
converting Chromium WebTouchEvent and WebTouchPoint types to
corresponding WebCore types.
https://bugs.webkit.org/show_bug.cgi?id=35760
- src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState): (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder): (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
- src/WebInputEventConversion.h:
- 9:52 PM Changeset in webkit [55571] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-04 John Gregg <johnnyg@google.com>
Reviewed by Darin Fisher.
[chromium] WebDocument:applicationID() crashes on <meta> tag with no http-equiv attribute
https://bugs.webkit.org/show_bug.cgi?id=35771
- src/WebDocument.cpp: (WebKit::WebDocument::applicationID): check for presence of http-equiv attribute before lower()ing it.
- 9:50 PM Changeset in webkit [55570] by
-
- 5 edits3 adds in trunk
WebSocket crash bug when reloading the page while the WebSocket is busy
https://bugs.webkit.org/show_bug.cgi?id=35732
Reviewed by Alexey Proskuryakov.
WebCore:
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::disconnect): clear m_context from WebSocketChannel and WebSocketHandshake.
(WebCore::WebSocketChannel::didOpen): check m_context
(WebCore::WebSocketChannel::didClose): clear m_context
(WebCore::WebSocketChannel::didReceiveData): check m_context, and check m_client early before appending to buffer
- websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clearScriptExecutionContext): Added.
- websockets/WebSocketHandshake.h:
LayoutTests:
- websocket/tests/reload-crash-expected.txt: Added.
- websocket/tests/reload-crash.html: Added.
- websocket/tests/resoures/reload-crash-iframe.html: Added.
- 9:35 PM Changeset in webkit [55569] by
-
- 6 edits2 adds in trunk
2010-03-04 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
Refactoring: XMLHTTPRequest.open() should have all overloaded implementations
https://bugs.webkit.org/show_bug.cgi?id=35630
- http/tests/xmlhttprequest/open-async-overload-expected.txt: Added.
- http/tests/xmlhttprequest/open-async-overload.html: Added.
2010-03-04 MORITA Hajime <morrita@google.com>
Reviewed by Alexey Proskuryakov.
Refactoring: XMLHTTPRequest.open() should have all overloaded implementations
https://bugs.webkit.org/show_bug.cgi?id=35630
Test: http/tests/xmlhttprequest/open-async-overload.html
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::openCallback):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):
- xml/XMLHttpRequest.h:
- 9:18 PM Changeset in webkit [55568] by
-
- 3 edits in trunk/WebCore
2010-03-04 James Robinson <jamesr@google.com>
Reviewed by Eric Seidel.
Styles do not have to be synchronously rematched after every event dispatch
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
- 9:01 PM Changeset in webkit [55567] by
-
- 2 edits in trunk/WebCore
2010-03-04 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
maemo spelled as mameo in WebCore.pro
https://bugs.webkit.org/show_bug.cgi?id=35765
Spelling corrected.
- WebCore.pro:
- 8:34 PM Changeset in webkit [55566] by
-
- 3 edits2 adds in trunk
2010-03-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.
- editing/input/option-page-up-down-expected.txt: Added.
- editing/input/option-page-up-down.html: Added.
2010-03-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.
Test: editing/input/option-page-up-down.html
- editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
- 7:42 PM Changeset in webkit [55565] by
-
- 2 edits in trunk/WebKitTools
Find the framework relative to TARGET_BUILD_DIR as that has a more obvious value during production builds.
Rubber-stamped by Alice Liu.
- Scripts/check-for-webkit-framework-include-consistency:
- 5:33 PM Changeset in webkit [55564] by
-
- 18 edits2 adds in trunk
2010-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716
Add new opcodes for handling cached lookup of static value getters.
More or less the same as with JS getters, all that changes is that
instead of calling through a JSFunction we always know that we have
a C function to call.
For the patching routines in the JIT we now need to pass a few
new parameters to allow us to pass enough information to the stub
function to allow us to call the C function correctly. Logically
this shouldn't actually be necessary as all of these functions ignore
the identifier, but removing the ident parameter would require
somewhat involved changes to the way we implement getOwnPropertySlot,
etc.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):
- bytecode/Instruction.h: (JSC::Instruction::Instruction): (JSC::Instruction::):
- bytecode/Opcode.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::):
- runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
- runtime/Lookup.h: (JSC::getStaticPropertySlot): (JSC::getStaticValueSlot):
- runtime/PropertySlot.h: (JSC::PropertySlot::): (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::cachedPropertyType): (JSC::PropertySlot::isCacheable): (JSC::PropertySlot::isCacheableValue): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setCacheableCustom): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot): (JSC::PropertySlot::clearOffset): (JSC::PropertySlot::customGetter):
2010-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716
Add tests to ensure nothing horrifying happens to static property
getters if they're in a path where we end up caching lookups.
- fast/js/pic/cached-named-property-getter-expected.txt: Added.
- fast/js/pic/cached-named-property-getter.html: Added.
2010-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716
Update the obviously safe getters to allow caching
Test: fast/js/pic/cached-named-property-getter.html
- bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertySlot):
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::getOwnPropertySlot):
- 4:50 PM Changeset in webkit [55563] by
-
- 1 edit5 adds in trunk/WebKitTools
2010-03-04 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add CppVariant and CppBoundClass
https://bugs.webkit.org/show_bug.cgi?id=35634
Add CppVariant and CppBoundClass classes, which are going to be
used by DumpRenderTree Chromium port. These files are based on:
- src/webkit/glue/cpp_variant.{cc,h} and
- src/webkit/glue/cpp_bound_class.{cc,h} of Chromium rev.40492.
- DumpRenderTree/chromium/CppBoundClass.cpp: Added.
- DumpRenderTree/chromium/CppBoundClass.h: Added.
- DumpRenderTree/chromium/CppVariant.cpp: Added.
- DumpRenderTree/chromium/CppVariant.h: Added.
- 4:29 PM Changeset in webkit [55562] by
-
- 2 edits in trunk/WebKitTools
Build fix for older versions of Ruby.
- Scripts/check-for-webkit-framework-include-consistency:
- 4:23 PM Changeset in webkit [55561] by
-
- 3 edits1 add in trunk
Add a script to verify that WebKit framework headers are internally consistent.
Reviewed by Sam Weinig.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Run the script during the build and fail with
an error should the consistency check fail.
WebKitTools:
This script detects the following problematic situations:
- An exported WebKit header that includes a header from WebCore.
- An exported WebKit header that includes a header that does not exist in the WebKit framework.
- A public WebKit header that includes a private WebKit header.
- Scripts/check-for-webkit-framework-include-consistency: Added.
- 4:23 PM Changeset in webkit [55560] by
-
- 4 edits in trunk
<rdar://problem/7717249> DOMSVG.h includes a non-existent DOMSVGFEMorphologyElement.h
Reviewed by Sam Weinig.
WebCore:
- WebCore.xcodeproj/project.pbxproj: Copy DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h
in to the framework wrapper.
WebKit/mac:
- MigrateHeaders.make: Migrate DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h.
- 4:23 PM Changeset in webkit [55559] by
-
- 2 edits in trunk/WebKit/mac
Use a framework-style include to pull in WebInspector.h for consistency
with other parts of WebKit.
Reviewed by Sam Weinig.
- WebInspector/WebInspectorPrivate.h:
- 3:34 PM Changeset in webkit [55558] by
-
- 2 edits in trunk/WebKitTools
Making sure that the correct path is set before invoking
DumpRenderTree on cygwin.
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=35768
- Scripts/run-webkit-tests:
- 3:29 PM Changeset in webkit [55557] by
-
- 3 edits18 adds in trunk
2010-03-04 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Handles setting HTMLSelectElement.length with mutation handlers present
https://bugs.webkit.org/show_bug.cgi?id=33983
When setting an HTMLSelectElement's length attribute, option elements have to be added or removed to the select
as appropriate. This is a little tricky with mutation events since they might add, remove, or reorder elements
while option elements are being added or deleted.
Tests: fast/forms/select-set-length-optgroup.html
fast/forms/select-set-length-with-mutation-remove.html
fast/forms/select-set-length-with-mutation-reorder.html
fast/forms/select-set-length-with-mutation-reparent.html
fast/forms/select-set-length-with-mutation.html
fast/forms/select-set-length.html
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setLength):
2010-03-04 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Tests for setting an select's options.length attribute.
https://bugs.webkit.org/show_bug.cgi?id=33983
- fast/forms/script-tests/select-set-length-optgroup.js: Added.
- fast/forms/script-tests/select-set-length-with-mutation-remove.js: Added. (gc): (onRemove):
- fast/forms/script-tests/select-set-length-with-mutation-reorder.js: Added. (onRemove):
- fast/forms/script-tests/select-set-length-with-mutation-reparent.js: Added. (onRemove):
- fast/forms/script-tests/select-set-length-with-mutation.js: Added. (sel):
- fast/forms/script-tests/select-set-length.js: Added.
- fast/forms/select-set-length-expected.txt: Added.
- fast/forms/select-set-length-optgroup-expected.txt: Added.
- fast/forms/select-set-length-optgroup.html: Added.
- fast/forms/select-set-length-with-mutation-expected.txt: Added.
- fast/forms/select-set-length-with-mutation-remove-expected.txt: Added.
- fast/forms/select-set-length-with-mutation-remove.html: Added.
- fast/forms/select-set-length-with-mutation-reorder-expected.txt: Added.
- fast/forms/select-set-length-with-mutation-reorder.html: Added.
- fast/forms/select-set-length-with-mutation-reparent-expected.txt: Added.
- fast/forms/select-set-length-with-mutation-reparent.html: Added.
- fast/forms/select-set-length-with-mutation.html: Added.
- fast/forms/select-set-length.html: Added.
- 3:21 PM Changeset in webkit [55556] by
-
- 3 edits in trunk/WebCore
[Qt] Unreviewed buildfix after r55542 on Windows.
- WebCore.pro:
- plugins/win/PluginDatabaseWin.cpp removed.
- platform/win/WebCoreInstanceHandle.cpp added.
- platform/win/WebCoreInstanceHandle.cpp: Remove explicit qualification in namespace declaration to make gcc happy.
- 3:01 PM Changeset in webkit [55555] by
-
- 3 edits2 adds in trunk
2010-03-04 Nate Chapin <Nate Chapin>
Reviewed by Kenneth Rohde Christiansen.
Fix the case where we do a same document navigation, scroll,
then repeat the same document navigation. Currently, the second
navigation does nothing.
Test: fast/loader/repeat-same-document-navigation.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): Call scrollToFragment() whether or not the hash changed.
- 2:44 PM QtWebKitBugs edited by
- (diff)
- 2:31 PM Changeset in webkit [55554] by
-
- 6 edits in trunk
2010-03-04 Simon Fraser <Simon Fraser>
Build fix.
const long long cMaxDistance = numeric_limits<long long>::max() created global
initializers at the call sites, so replace with an inline function.
- page/FocusController.cpp: (WebCore::updateFocusCandidateIfCloser):
- page/SpatialNavigation.cpp: (WebCore::distanceInDirection):
- page/SpatialNavigation.h: (WebCore::maxDistance): (WebCore::FocusCandidate::FocusCandidate):
- 2:29 PM QtWebKitBugs edited by
- Repeat reporting link. Fill out the crashes part (diff)
- 2:15 PM Changeset in webkit [55553] by
-
- 2 edits in trunk/WebKitTools
2010-03-04 Simon Fraser <Simon Fraser>
Build fix: add exceptions to the check-for-global-initializers script
for FocusController and SpatialNavigation, and improve the script
to actually print out the globals found.
- Scripts/check-for-global-initializers:
- 1:52 PM Changeset in webkit [55552] by
-
- 2 edits in trunk/WebCore
Unreviewed attempt to fix Windows build.
- page/SpatialNavigation.cpp:
(WebCore::spatialDistance):
- 1:40 PM Changeset in webkit [55551] by
-
- 2 edits in trunk/WebKitTools
2010-03-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
Fix dangling reference to "port" instead of "self._port_obj" that
was preventing the http_server from starting on Windows.
- Scripts/webkitpy/layout_tests/port/http_server.py:
- 1:35 PM Changeset in webkit [55550] by
-
- 2 edits in trunk/WebCore
2010-03-04 Simon Fraser <Simon Fraser>
Build fix.
Delcare updateFocusCandidateIfCloser static to avoid warning.
- page/FocusController.cpp: (WebCore::updateFocusCandidateIfCloser):
- 1:11 PM Changeset in webkit [55549] by
-
- 7 edits in trunk
2010-03-04 Darin Fisher <darin@chromium.org>
Reviewed by Dmitry Titov.
[chromium] make history.{push,replace}State enabled at runtime
https://bugs.webkit.org/show_bug.cgi?id=35753
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setPushStateEnabled): (WebCore::RuntimeEnabledFeatures::pushStateEnabled): (WebCore::RuntimeEnabledFeatures::replaceStateEnabled):
- page/History.idl:
- 1:09 PM Changeset in webkit [55548] by
-
- 2 edits in trunk/WebCore
Unreviewed attempt to (again) fix Mac build.
- page/SpatialNavigation.cpp:
(WebCore::spatialDistance):
- 1:03 PM Changeset in webkit [55547] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix typos
- 1:02 PM Changeset in webkit [55546] by
-
- 3 edits2 adds in trunk
WebCore: Based on a pacth from Nick Jong.
Reviewed by Simon Fraser.
Improve selection in multi-column blocks when hitting points above or
below a column rect.
Test: fast/multicol/hit-test-above-or-below.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPointToColumnContents): If the point lies
within the horizontal range for a column, constrain it to the column (if
it is above) or the next column (if it is below).
LayoutTests: Added test for hit-testing points above or below the column rect.
Reviewed by Simon Fraser.
- fast/multicol/hit-test-above-or-below-expected.txt: Added.
- fast/multicol/hit-test-above-or-below.html: Added.
- 12:57 PM Changeset in webkit [55545] by
-
- 2 edits in trunk/WebCore
Attempt to fix Mac build.
Reviewed by Simon Frase.
- page/SpatialNavigation.cpp:
- 12:20 PM Changeset in webkit [55544] by
-
- 2 edits in trunk/WebCore
Add SpatialNavigation header and cpp to Mac XCode project file
Reviewed by Kenneth Christiansen.
Patch by Jesus Palencia <jesus.palencia@openbossa.org>
- WebCore.xcodeproj/project.pbxproj:
- 12:19 PM Changeset in webkit [55543] by
-
- 13 edits2 adds in trunk/WebCore
Extend keyboard navigation to allow directional navigation
https://bugs.webkit.org/show_bug.cgi?id=18662
Reviewed by Simon Fraser, Eric Seidel and Darin Adler.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Based on the initial work of Marco Barisione <marco.barisione@collabora.co.uk>
This patch implements the core logic of the 'Spatial Navigation' feature [1].
It improves the accessibility support of WebCore by extending the basic keyboard
navigation currently available (based on Tab forward and backward) with the
addition of a two-dimensional directional navigation by using Left, Right, Up and
Down arrow keys to move to the "nearest" element in the corresponding direction.
Highlights:
- Feature is turned off by default in Settings. Port specific APIs need to be added for toggling it on/off.
- Only elements viewed in the current viewport can have focus move to it. If the "nearest" is not in viewport dimensions, then a scroll-in-direction action is performed.
- The layout tests added run on Qt's DRT only for now (skipped for Mac, Win and Gtk).
Known issues (to be covered in follow-up bugs):
- Add port specific hooks to each DRT to enable/disable Spatial Navigation.
- Support for spatial navigation through form elements (<input>, <select>, etc) is be added.
- Make navigation keys customizable. It currently works with arrows keys only (up, down, right and left).
- Make it support modifiers (Alt, Ctrl and Shift).
[1] http://en.wikipedia.org/wiki/Spatial_navigation
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- page/EventHandler.cpp:
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::focusDirectionForKey):
(WebCore::EventHandler::defaultArrowEventHandler):
- page/EventHandler.h:
- page/FocusController.cpp:
(WebCore::FocusController::advanceFocus):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::advanceFocusDirectionally):
(WebCore::updateFocusCandidateIfCloser):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):
- page/FocusController.h:
- page/FocusDirection.h:
(WebCore::):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setSpatialNavigationEnabled):
- page/Settings.h:
(WebCore::Settings::isSpatialNavigationEnabled):
- page/SpatialNavigation.cpp: Added.
(WebCore::distanceInDirection):
(WebCore::renderRectRelativeToRootDocument):
(WebCore::alignmentForRects):
(WebCore::isHorizontalMove):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsPartiallyAligned):
(WebCore::spatialDistance):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isInRootDocument):
(WebCore::deflateIfOverlapped):
- page/SpatialNavigation.h: Added.
(WebCore::):
(WebCore::FocusCandidate::FocusCandidate):
- 12:08 PM Changeset in webkit [55542] by
-
- 10 edits2 adds1 delete in trunk
WebCore: This fixes the layering violation I committed yesterday by moving
Page::instanceHandle into its own file just in the WebCore
namespace.
Reviewed by Anders Carlsson.
Added WebCoreInstanceHandle.h + .cpp and removed PageWin.cpp
- WebCore.vcproj/WebCore.vcproj:
- page/win/PageWin.cpp: Removed.
Remove all instance handle code from Page.
- page/Page.h:
New files.
- platform/win/WebCoreInstanceHandle.cpp: Added.
- platform/win/WebCoreInstanceHandle.h: Added.
(WebCore::setInstanceHandle):
(WebCore::instanceHandle):
Switch to WebCore::instanceHandle() instead of
Page::instanceHandle() and include the new header.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::Pasteboard):
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::registerClass):
- platform/win/SharedTimerWin.cpp:
(WebCore::initializeOffScreenTimerWindow):
- plugins/win/PluginViewWin.cpp:
(WebCore::registerPluginView):
(WebCore::PluginView::platformStart):
WebKit/win: WebCore::Page::setInstanceHandle() is now just
WebCore::setInstanceHandle()
Reviewed by Anders Carlsson.
- WebKitDLL.cpp:
(DllMain):
- 11:30 AM Changeset in webkit [55541] by
-
- 6 edits in trunk
2010-03-04 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Simon Hausmann.
Make Qt DumpRenderTree EventSender able to send double click events
LayoutTests:
fast/events/dblclick-addEventListener.html
[Qt] DRT: Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35255
- platform/qt/Skipped:
2010-03-04 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Simon Hausmann.
Make Qt DumpRenderTree EventSender able to send double click events
LayoutTests:
fast/events/dblclick-addEventListener.html
[Qt] DRT: Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35255
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): (EventSender::mouseDown):
- DumpRenderTree/qt/EventSenderQt.h: (EventSender::resetClickCount):
- 11:15 AM Changeset in webkit [55540] by
-
- 2 edits in trunk/WebCore
[Gtk] Unreviewed build fix.
Patch by Antonio Gomes <tonikitoo@webkit.org>
'glib_file_name' renamed to 'gligFileName'.
- platform/graphics/gtk/ImageGtk.cpp:
(WebCore::Image::loadPlatformResource):
- 11:12 AM Changeset in webkit [55539] by
-
- 2 edits in trunk/WebKit/qt
2010-03-04 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] qwebelement.h does not include QtCore headers correctly
https://bugs.webkit.org/show_bug.cgi?id=35748
The header files of QtCore must be included as QtCore/foo.h.
- Api/qwebelement.h:
- 11:03 AM Changeset in webkit [55538] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium tests fix.
- src/js/Tests.js:
- 10:56 AM Changeset in webkit [55537] by
-
- 15 edits in trunk
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Remove two last synchronous calls from front-end to InspectorBackend.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::enableSearchingForNode): (WebCore::InspectorBackend::disableSearchingForNode): (WebCore::InspectorBackend::setPauseOnExceptionsState):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorContorller::setSearchingForNode): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::searchingForNodeWasEnabled): (WebCore::InspectorFrontend::searchingForNodeWasDisabled): (WebCore::InspectorFrontend::updatePauseOnExceptionsState):
- inspector/InspectorFrontend.h:
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.get statusBarItems): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.searchingForNodeWasEnabled): (WebInspector.ElementsPanel.prototype.searchingForNodeWasDisabled): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.enableSearchingForNode): (.WebInspector.InspectorBackendStub.prototype.disableSearchingForNode): (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptionsState):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get statusBarItems): (WebInspector.ScriptsPanel.prototype.updatePauseOnExceptionsState): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
- inspector/front-end/inspector.js: (WebInspector.searchingForNodeWasEnabled): (WebInspector.searchingForNodeWasDisabled): (WebInspector.updatePauseOnExceptionsState): WebKit/chromium:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
- 10:48 AM Changeset in webkit [55536] by
-
- 3 edits in trunk/WebCore
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Clicking on an error should take me to the error
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype.selectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):
- 10:46 AM Changeset in webkit [55535] by
-
- 12 edits in trunk
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Remove sync access to resourceTrackingEnabled.
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources): (WebInspector.AuditsPanel.prototype.show):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.enableDebugger): (.WebInspector.InspectorBackendStub.prototype.disableDebugger): (.WebInspector.InspectorBackendStub.prototype.enableProfiler): (.WebInspector.InspectorBackendStub.prototype.disableProfiler):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.get resourceTrackingEnabled): (WebInspector.ResourcesPanel.prototype.get visibleView): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._enableResourceTracking): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
- 10:43 AM Changeset in webkit [55534] by
-
- 1 edit in trunk/LayoutTests/fast/dom/Window/slow-unload-handler-expected.txt
Update test expectations from my recent checkin
- 10:43 AM Changeset in webkit [55533] by
-
- 5 edits in trunk/LayoutTests
Committed by Chang Shu: commit manually for bug 35687.
- 10:17 AM Changeset in webkit [55532] by
-
- 3 edits2 adds in trunk
2010-03-04 Antoine Quint <ml@graougraou.com>
Reviewed by Darin Adler.
DOM insertion mutation events should dispatch after a node is attached to the render tree
https://bugs.webkit.org/show_bug.cgi?id=35590
- fast/events/domnodeinsertedintodocument-dispatched-post-rendering-expected.txt: Added.
- fast/events/domnodeinsertedintodocument-dispatched-post-rendering.html: Added.
2010-03-04 Antoine Quint <ml@graougraou.com>
Reviewed by Darin Adler.
DOM insertion mutation events should dispatch after a node is attached to the render tree
https://bugs.webkit.org/show_bug.cgi?id=35590
Test: fast/events/domnodeinsertedintodocument-dispatched-post-rendering.html
Split off the internal-to-WebCore node insertion notification code from the DOM mutation
event dispatching, originally in dispatchChildInsertionEvents(), to a new static function
called notifyChildInserted(). This allows us to dispatch the mutation events at a later
time upon insertion of a child into to the tree, specifically _after_ attachment to the render
tree.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildInsertionEvents):
- 10:00 AM Changeset in webkit [55531] by
-
- 2 edits in trunk/WebCore
2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
Make paths relocatable on runtime on Windows
https://bugs.webkit.org/show_bug.cgi?id=32711
- platform/graphics/gtk/ImageGtk.cpp: (get_webkit_datadir): (WebCore::Image::loadPlatformResource):
- 9:35 AM Changeset in webkit [55530] by
-
- 5 edits in trunk/WebCore
2010-03-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Popup for Timeline panel will work in a tooltip mode
- inspector/front-end/Popover.js: (WebInspector.Popover): (WebInspector.Popover.prototype.show): (WebInspector.Popover.prototype.hide): (WebInspector.Popover.prototype._positionElement): (WebInspector.PopoverHelper): (WebInspector.PopoverHelper.prototype._mouseDown): (WebInspector.PopoverHelper.prototype._mouseMove.doHide): (WebInspector.PopoverHelper.prototype._mouseMove): (WebInspector.PopoverHelper.prototype._resetHoverTimer): (WebInspector.PopoverHelper.prototype.hidePopup): (WebInspector.PopoverHelper.prototype._mouseHover): (WebInspector.PopoverHelper.prototype._killHidePopupTimer):
- inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.reset):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._scheduleRefresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._adjustScrollPosition): (WebInspector.TimelinePanel.prototype._getPopoverAnchor): (WebInspector.TimelinePanel.prototype._showPopover): (WebInspector.TimelinePanel.prototype._closeRecordDetails): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype._onClick): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._createCell): (WebInspector.TimelinePanel.FormattedRecord.prototype._createRow): (WebInspector.TimelinePanel.FormattedRecord.prototype._createLinkRow): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.css:
- 9:25 AM Changeset in webkit [55529] by
-
- 2 edits in trunk/WebKit/mac
REGRESSION (31281): -[WebArchive initWithCoder:] leaks
<rdar://problem/7702420> and https://bugs.webkit.org/show_bug.cgi?id=35534
Reviewed by Geoff Garen.
- WebView/WebArchive.mm:
(-[WebArchive initWithCoder:]): Don't retain objects we don't own.
- 9:18 AM Changeset in webkit [55528] by
-
- 2 edits in trunk/WebCore
2010-03-04 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
Build fix after r55464.
No new tests, no new functionality.
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
- 8:14 AM Changeset in webkit [55527] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] storage/open-database-creation-callback-isolated-world.html was removed
from tree by r55488, so it should be removed from Qt Skipped list too.
- platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html removed.
- 7:41 AM Changeset in webkit [55526] by
-
- 1 edit7 adds in trunk/WebCore
2010-03-04 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/graphics/efl.
http://webkit.org/b/35539
- platform/graphics/efl/FloatRectEfl.cpp: Added.
- platform/graphics/efl/FontEfl.cpp: Added.
- platform/graphics/efl/IconEfl.cpp: Added.
- platform/graphics/efl/ImageEfl.cpp: Added.
- platform/graphics/efl/IntPointEfl.cpp: Added.
- platform/graphics/efl/IntRectEfl.cpp: Added.
- 7:25 AM Changeset in webkit [55525] by
-
- 1 edit2 adds in trunk/WebCore
2010-03-04 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/text/efl.
http://webkit.org/b/35740
- platform/text/efl/TextBreakIteratorInternalICUEfl.cpp: Added.
- 7:03 AM Changeset in webkit [55524] by
-
- 4 edits in trunk
2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=35726
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID
Removing orphaned #if USE.
- GNUmakefile.am:
2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=35726
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID
Removing orphaned #if USE.
- platform/ThreadGlobalData.h:
- 6:24 AM Changeset in webkit [55523] by
-
- 3 edits in trunk/WebCore
Trottle sync requests sent to the LocalStorage background thread
https://bugs.webkit.org/show_bug.cgi?id=34943
Reviewed by Darin Fisher.
Currently, once a second LocalStorage takes all keys/values which have
been changed and sends them to a background thread to sync. The problem
is that this background thread can get overwhelmed and stop being
responsive. This means that if any other page tries to start using
LocalStorage (and thus initiates the initial import) that'll block on
all the previous syncs completing.
To mitigate this, I'm adding code so that we never schedule another
sync task when another is still running. In order to keep the sync
tasks from growing exponentially when they do take longer than the
storage sync interval, I've also added a basic rate limiter. No effort
is made to ensure fairness/ordering of what gets synced nor is there
any way for this rate to be changed because most normal uses of
LocalStorage really shouldn't be hitting these types of limits anyway.
The only behavioral change that's observible in JavaScript is time based
and thus it's not practical to make new tests that aren't racy. The
existing layout tests cover LocalStorage pretty well, though.
- storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::scheduleFinalSync):
(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performSync):
- storage/StorageAreaSync.h:
- 6:00 AM Changeset in webkit [55522] by
-
- 27 edits2 copies1 add in trunk
2010-03-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Added support for worker instrumentation in inspector
(display list of active workers, allow debugging of workers
by injecting fake JS implementation)
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
- dom/Document.cpp: (WebCore::Document::inspectorController):
- dom/Document.h:
- dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::inspectorController):
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectScript): (WebCore::InjectedScriptHost::nextWorkerId): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::willDestroyWorker):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::willDestroyWorker):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCreateWorker): (WebCore::InspectorFrontend::willDestroyWorker):
- inspector/InspectorFrontend.h:
- inspector/InspectorWorkerResource.h: Added. (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::url): (WebCore::InspectorWorkerResource::isSharedWorker): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
- inspector/front-end/Checkbox.js: Added. (WebInspector.Checkbox.callbackWrapper): (WebInspector.Checkbox): (WebInspector.Checkbox.prototype.checked):
- inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/WorkersSidebarPane.js: Added. (WebInspector.WorkersSidebarPane): (WebInspector.WorkersSidebarPane.prototype.addWorker): (WebInspector.WorkersSidebarPane.prototype.removeWorker): (WebInspector.WorkersSidebarPane.prototype.setInstrumentation): (WebInspector.WorkersSidebarPane.prototype.reset): (WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument): (WebInspector.Worker): (WebInspector.didCreateWorker): (WebInspector.willDestroyWorker):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker): (WebCore::AbstractWorker::contextDestroyed):
- workers/AbstractWorker.h: (WebCore::AbstractWorker::id):
- workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
- workers/Worker.cpp: (WebCore::Worker::Worker):
- 5:58 AM Changeset in webkit [55521] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-04 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Remove a non-ASCII character introduced in the following bug.
put_by_id does will incorrectly cache writes where a specific value exists, where at the point of caching the same value is being written.
https://bugs.webkit.org/show_bug.cgi?id=35537
- runtime/JSObject.h: (JSC::JSObject::putDirectInternal):
- 5:39 AM Changeset in webkit [55520] by
-
- 27 edits in trunk
[Qt] Make the OUTPUT_DIR variable in qmake projects independent of build-webkit's logic.
Reviewed by Tor Arne Vestbø.
This also allows shadow builds relying only on qmake to work properly.
.:
- WebKit.pri:
- jsc.pro:
- qt/api/QtScript.pro:
- qt/tests/qscriptengine/qscriptengine.pro:
- qt/tests/qscriptvalue/qscriptvalue.pro:
- qt/tests/tests.pri:
WebCore:
- WebCore.pro:
WebKit\qt:
- tests/benchmarks/loading/loading.pro:
- tests/benchmarks/painting/painting.pro:
- tests/hybridPixmap/hybridPixmap.pro:
- tests/qgraphicswebview/qgraphicswebview.pro:
- tests/qwebelement/qwebelement.pro:
- tests/qwebframe/qwebframe.pro:
- tests/qwebhistory/qwebhistory.pro:
- tests/qwebhistoryinterface/qwebhistoryinterface.pro:
- tests/qwebinspector/qwebinspector.pro:
- tests/qwebpage/qwebpage.pro:
- tests/qwebplugindatabase/qwebplugindatabase.pro:
WebKitTools:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/ImageDiff.pro:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- QtLauncher/QtLauncher.pro:
- 5:17 AM QtWebKitBugs edited by
- (diff)
- 4:46 AM Changeset in webkit [55519] by
-
- 2 edits in trunk/WebKitTools
Enable to use built-product-archive on Qt platform.
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-03-04
Reviewed by Kenneth Rohde Christiansen.
- BuildSlaveSupport/built-product-archive:
- 4:29 AM Changeset in webkit [55518] by
-
- 2 edits in trunk/WebCore
[Qt] Avoid calling QFont::detach too often from FontQt
https://bugs.webkit.org/show_bug.cgi?id=35569
The letter- and wordspacing is inside the WebCore::Font class,
our QFont is located in the WebCore::FontPlatformData. Everytime
we need to use a QFont inside WebCore::Font we are calling the
font method which gets the QFont from the WebCore::FontPlatformData
and is applying the letter- and wordspacing. Internally this
will attempt to detach the QFont...
Avoid calling setLetterSpacing and setWordSpacing on QFont if
the WebCore::Font has the default applied.
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::font):
- 4:21 AM Changeset in webkit [55517] by
-
- 4 edits in trunk/WebCore
2010-03-04 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Nothing happens on navigation to resource via a link if resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=35574
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
- inspector/front-end/inspector.js: (WebInspector.documentMouseOver): (WebInspector.documentMouseOut): (WebInspector.hideBadLinkPopupIfNecessary): (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.showBadLinkPopup.popupOverOut): (WebInspector.showBadLinkPopup): (WebInspector.addMainEventListeners):
- 3:04 AM Changeset in webkit [55516] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] DRT is failing on new test introduced in r55499
Skipping it until fix.
https://bugs.webkit.org/show_bug.cgi?id=35729
- platform/qt/Skipped: fast/events/zoom-dblclick.html skipped
- 2:45 AM Changeset in webkit [55515] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix generation of forwaring headers
Reviewed by Kenneth Rohde Christiansen.
The dependencies were a bit wrong, so we ended up not generating
forwarding headers for qwebkitversion.h and qwebkitglobal.h
The forwardning headers are now the only targets depending on the
real headers. All other targets either depend on the generated
class headers, or the forwarding headers.
- Api/DerivedSources.pro:
- 1:41 AM Changeset in webkit [55514] by
-
- 5 edits in trunk
2010-03-04 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Oliver Hunt.
Update existing test to check that getUniformLocation() returns
null if the uniform requested is not found.
https://bugs.webkit.org/show_bug.cgi?id=34669
- fast/canvas/webgl/script-tests/uniform-location.js:
- fast/canvas/webgl/uniform-location-expected.txt:
2010-03-04 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Oliver Hunt.
getUniformLocation() now returns null if uniform requested
is not found.
https://bugs.webkit.org/show_bug.cgi?id=34669
Test:LayoutTests/fast/canvas/webgl/uniform-location.html
(added missing test)
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniformLocation):
- 1:24 AM Changeset in webkit [55513] by
-
- 4 edits in trunk
2010-03-04 John Abd-El-Malek <jam@chromium.org>
Reviewed by Adam Barth.
Fix incorrect setup of DateExtension.
https://bugs.webkit.org/show_bug.cgi?id=35710
- fast/dom/Window/resources/slow_unload_handler1.html:
2010-03-04 John Abd-El-Malek <jam@chromium.org>
Reviewed by Adam Barth.
Fix incorrect setup of DateExtension.
https://bugs.webkit.org/show_bug.cgi?id=35710
- bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep):
- 1:13 AM Changeset in webkit [55512] by
-
- 2 edits in trunk/WebKit/chromium
2010-03-04 Darin Fisher <darin@chromium.org>
Reviewed by Pavel Feldman.
Fix failing DevToolsSanityTest.TestResourceContentLength
https://bugs.webkit.org/show_bug.cgi?id=35725
http://trac.webkit.org/changeset/55466 missed one more spot
where contentLength needed to be renamed resourceSize.
- src/js/Tests.js:
- 12:57 AM Changeset in webkit [55511] by
-
- 4 edits10 adds in trunk
2010-03-04 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35603
SVG incorrectly allows nested <use> elements in a <use> shadow tree
Simplify the handling of invalid or missing use-targets by cloning them
to empty <g> elements rather than just allowing the <use> element to
be copied into the shadow tree, as this violates a number of assumptions
in the shadow tree handling code.
Tests: svg/custom/use-nested-disallowed-target.svg
svg/custom/use-nested-missing-target-added.svg
svg/custom/use-nested-missing-target-removed.svg
svg/custom/use-nested-missing-target.svg
svg/custom/use-nested-notarget.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::buildShadowAndInstanceTree): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
2010-03-04 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35603
SVG incorrectly allows nested <use> elements in a <use> shadow tree
Add test cases for various combinations of <use> and targets that aren't present.
- platform/mac/svg/custom/use-empty-reference-expected.txt: Added.
- svg/custom/use-nested-disallowed-target-expected.txt: Added.
- svg/custom/use-nested-disallowed-target.svg: Added.
- svg/custom/use-nested-missing-target-added-expected.txt: Added.
- svg/custom/use-nested-missing-target-added.svg: Added.
- svg/custom/use-nested-missing-target-expected.txt: Added.
- svg/custom/use-nested-missing-target-removed-expected.txt: Added.
- svg/custom/use-nested-missing-target-removed.svg: Added.
- svg/custom/use-nested-missing-target.svg: Added.
- svg/custom/use-nested-notarget-expected.txt: Added.
- svg/custom/use-nested-notarget.svg: Added.
- 12:51 AM Changeset in webkit [55510] by
-
- 2 edits7 moves in trunk/WebCore
2010-03-04 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Move Cairo-related font code from platform/graphics/gtk to
platform/graphics/cairo, so other ports may use them.
http://webkit.org/b/35539
- GNUmakefile.am:
- platform/graphics/cairo/FontCacheCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontCacheGtk.cpp.
- platform/graphics/cairo/FontCustomPlatformData.cpp: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp.
- platform/graphics/cairo/FontCustomPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.h.
- platform/graphics/cairo/FontPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontPlatformData.h.
- platform/graphics/cairo/FontPlatformDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp.
- platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Copied from WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp.
- platform/graphics/cairo/SimpleFontDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp.
- platform/graphics/gtk/FontCacheGtk.cpp: Removed.
- platform/graphics/gtk/FontCustomPlatformData.cpp: Removed.
- platform/graphics/gtk/FontCustomPlatformData.h: Removed.
- platform/graphics/gtk/FontPlatformData.h: Removed.
- platform/graphics/gtk/FontPlatformDataGtk.cpp: Removed.
- platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: Removed.
- platform/graphics/gtk/SimpleFontDataGtk.cpp: Removed.
- 12:34 AM Changeset in webkit [55509] by
-
- 4 edits2 adds in trunk
2010-03-04 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs with Skia
This test passes if it doesn't crash.
- platform/mac/Skipped: Skip the test on Mac, where it crashes.
- svg/custom/tiling-regular-hexagonal-crash-expected.txt: Added.
- svg/custom/tiling-regular-hexagonal-crash.svg: Added.
2010-03-04 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs
This fixes the crash, but the SVG still doesn't render properly.
Test: svg/custom/tiling-regular-hexagonal-crash.svg
- platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create): don't return 0 when the copy fails; instead return a blank bitmap. The caller doesn't check for 0 before dereferencing.
- 12:03 AM Changeset in webkit [55508] by
-
- 2 edits in trunk/WebCore
2010-03-04 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
Initialize m_isMultipartPayload in other ResourceResponse ctor.
In r55451 (bug 35628) I added an extra bool, but only initialized
it in one constructor.
https://bugs.webkit.org/show_bug.cgi?id=35719
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- 12:01 AM Changeset in webkit [55507] by
-
- 2 edits1 add in trunk/WebKit/chromium
2010-03-03 Garret Kelly <gdk@chromium.org>
Reviewed by Darin Fisher.
Adding touch event type and point type. Tested against the try bots.
https://bugs.webkit.org/show_bug.cgi?id=35691
- public/WebInputEvent.h: (WebKit::WebInputEvent::): (WebKit::WebInputEvent::isTouchEventType): (WebKit::WebTouchEvent::WebTouchEvent):
- public/WebTouchPoint.h: Added. (WebKit::WebTouchPoint::WebTouchPoint): (WebKit::WebTouchPoint::):
Mar 3, 2010:
- 11:18 PM Changeset in webkit [55506] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild of Interfaces
- 10:10 PM Changeset in webkit [55505] by
-
- 9 edits2 adds in trunk/WebCore
2010-03-03 Yuta Kitamura <yutak@chromium.org>
Reviewed by Alexey Proskuryakov.
Add a new class that stores information about Web Socket handshake request.
Instances of this class contain the necessary information to send a Web Socket
handshake request. In the future, this class will provide request information
to the Web Inspector.
WebSocketHandshake needs to provide request information
https://bugs.webkit.org/show_bug.cgi?id=34784
No new tests, since the current tests will suffice (LayoutTests/websocket/*).
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- websockets/WebSocketChannel.cpp:
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::clientHandshakeMessage): (WebCore::WebSocketHandshake::clientHandshakeRequest):
- websockets/WebSocketHandshake.h:
- websockets/WebSocketHandshakeRequest.cpp: Added. (WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::~WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::addExtraHeaderField): (WebCore::WebSocketHandshakeRequest::headerFields): (WebCore::WebSocketHandshakeRequest::host):
- websockets/WebSocketHandshakeRequest.h: Added.
- 9:19 PM Changeset in webkit [55504] by
-
- 2 edits in trunk/WebCore
2010-03-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Build fix after r55452.
No new tests, this is a build fix.
- page/Settings.cpp: (WebCore::Settings::setDatabasesEnabled):
- 9:17 PM Changeset in webkit [55503] by
-
- 5 edits in trunk/WebKit/win
Add a way to get an iframe's content frame
Reviewed by Jon Honeycutt.
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
Added case for DOMHTMLIFrameElement
- DOMHTMLClasses.cpp:
Adding the few DOMHTMLIFrameElement functions definitions that have
distinct implementations (all others just call parent implementation)
(DOMHTMLIFrameElement::QueryInterface):
(DOMHTMLIFrameElement::contentFrame):
- DOMHTMLClasses.h:
Most of these function declarations have definitions that just call the parent implementation
(DOMHTMLIFrameElement::DOMHTMLIFrameElement):
(DOMHTMLIFrameElement::AddRef):
(DOMHTMLIFrameElement::Release):
(DOMHTMLIFrameElement::throwException):
(DOMHTMLIFrameElement::callWebScriptMethod):
(DOMHTMLIFrameElement::evaluateWebScript):
(DOMHTMLIFrameElement::removeWebScriptKey):
(DOMHTMLIFrameElement::stringRepresentation):
(DOMHTMLIFrameElement::webScriptValueAtIndex):
(DOMHTMLIFrameElement::setWebScriptValueAtIndex):
(DOMHTMLIFrameElement::setException):
(DOMHTMLIFrameElement::nodeName):
(DOMHTMLIFrameElement::nodeValue):
(DOMHTMLIFrameElement::setNodeValue):
(DOMHTMLIFrameElement::nodeType):
(DOMHTMLIFrameElement::parentNode):
(DOMHTMLIFrameElement::childNodes):
(DOMHTMLIFrameElement::firstChild):
(DOMHTMLIFrameElement::lastChild):
(DOMHTMLIFrameElement::previousSibling):
(DOMHTMLIFrameElement::nextSibling):
(DOMHTMLIFrameElement::attributes):
(DOMHTMLIFrameElement::ownerDocument):
(DOMHTMLIFrameElement::insertBefore):
(DOMHTMLIFrameElement::replaceChild):
(DOMHTMLIFrameElement::removeChild):
(DOMHTMLIFrameElement::appendChild):
(DOMHTMLIFrameElement::hasChildNodes):
(DOMHTMLIFrameElement::cloneNode):
(DOMHTMLIFrameElement::normalize):
(DOMHTMLIFrameElement::isSupported):
(DOMHTMLIFrameElement::namespaceURI):
(DOMHTMLIFrameElement::prefix):
(DOMHTMLIFrameElement::setPrefix):
(DOMHTMLIFrameElement::localName):
(DOMHTMLIFrameElement::hasAttributes):
(DOMHTMLIFrameElement::isSameNode):
(DOMHTMLIFrameElement::isEqualNode):
(DOMHTMLIFrameElement::textContent):
(DOMHTMLIFrameElement::setTextContent):
(DOMHTMLIFrameElement::tagName):
(DOMHTMLIFrameElement::getAttribute):
(DOMHTMLIFrameElement::setAttribute):
(DOMHTMLIFrameElement::removeAttribute):
(DOMHTMLIFrameElement::getAttributeNode):
(DOMHTMLIFrameElement::setAttributeNode):
(DOMHTMLIFrameElement::removeAttributeNode):
(DOMHTMLIFrameElement::getElementsByTagName):
(DOMHTMLIFrameElement::getAttributeNS):
(DOMHTMLIFrameElement::setAttributeNS):
(DOMHTMLIFrameElement::removeAttributeNS):
(DOMHTMLIFrameElement::getAttributeNodeNS):
(DOMHTMLIFrameElement::setAttributeNodeNS):
(DOMHTMLIFrameElement::getElementsByTagNameNS):
(DOMHTMLIFrameElement::hasAttribute):
(DOMHTMLIFrameElement::hasAttributeNS):
(DOMHTMLIFrameElement::focus):
(DOMHTMLIFrameElement::blur):
(DOMHTMLIFrameElement::idName):
(DOMHTMLIFrameElement::setIdName):
(DOMHTMLIFrameElement::title):
(DOMHTMLIFrameElement::setTitle):
(DOMHTMLIFrameElement::lang):
(DOMHTMLIFrameElement::setLang):
(DOMHTMLIFrameElement::dir):
(DOMHTMLIFrameElement::setDir):
(DOMHTMLIFrameElement::className):
(DOMHTMLIFrameElement::setClassName):
(DOMHTMLIFrameElement::innerHTML):
(DOMHTMLIFrameElement::setInnerHTML):
(DOMHTMLIFrameElement::innerText):
(DOMHTMLIFrameElement::setInnerText):
- Interfaces/DOMHTML.idl:
Added IDOMHTMLIFrameElement interface
- 9:02 PM Changeset in webkit [55502] by
-
- 3 edits in trunk/JavaScriptCore
2010-03-03 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
QScriptValue::isObject fix.
Fix broken internal state evaluation from JSValue to JSNative / JSObject.
New function was introduced which should take care about promoting
JSValue state inside QScriptValuePrivate. It should be used instead of a
direct JSC C API call.
The bug exposed a weakness in autotest suite, as the QScriptValuePrivate
is based on state machine with lazy state evaluation, there is a possibility
that serial sequencial calls to the same public const function could return
different results. The patch fix the issue.
[Qt] Sometimes QScriptValue::isObject returns an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=35387
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::isError): (QScriptValuePrivate::isObject): (QScriptValuePrivate::isFunction): (QScriptValuePrivate::call): (QScriptValuePrivate::refineJSValue):
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::initScriptValues): (tst_QScriptValue::isValid_makeData): (tst_QScriptValue::isValid_test): (tst_QScriptValue::isBool_makeData): (tst_QScriptValue::isBool_test): (tst_QScriptValue::isBoolean_makeData): (tst_QScriptValue::isBoolean_test): (tst_QScriptValue::isNumber_makeData): (tst_QScriptValue::isNumber_test): (tst_QScriptValue::isFunction_test): (tst_QScriptValue::isNull_makeData): (tst_QScriptValue::isNull_test): (tst_QScriptValue::isString_makeData): (tst_QScriptValue::isString_test): (tst_QScriptValue::isUndefined_makeData): (tst_QScriptValue::isUndefined_test): (tst_QScriptValue::isObject_makeData): (tst_QScriptValue::isObject_test): (tst_QScriptValue::toString_makeData): (tst_QScriptValue::toString_test): (tst_QScriptValue::toNumber_makeData): (tst_QScriptValue::toNumber_test): (tst_QScriptValue::toBool_makeData): (tst_QScriptValue::toBool_test): (tst_QScriptValue::toBoolean_makeData): (tst_QScriptValue::toBoolean_test): (tst_QScriptValue::toInteger_makeData): (tst_QScriptValue::toInteger_test): (tst_QScriptValue::toInt32_makeData): (tst_QScriptValue::toInt32_test): (tst_QScriptValue::toUInt32_makeData): (tst_QScriptValue::toUInt32_test): (tst_QScriptValue::toUInt16_makeData): (tst_QScriptValue::toUInt16_test):
- 8:45 PM Changeset in webkit [55501] by
-
- 4 edits in trunk
2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
LayoutTests:
fast/events/key-events-in-input-text.html
fast/events/special-key-events-in-input-text.html
[Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=35694
- platform/qt/Skipped:
2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
LayoutTests:
fast/events/key-events-in-input-text.html
fast/events/special-key-events-in-input-text.html
[Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=35694
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode):
- 7:57 PM Changeset in webkit [55500] by
-
- 6 edits2 adds in trunk/JavaScriptCore
2010-03-03 Chao-ying Fu <fu@mips.com>
Reviewed by Gavin Barraclough.
MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144
The following changes enable MIPS YARR and YARR_JIT.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
- assembler/MIPSAssembler.h: Added. (JSC::MIPSRegisters::): (JSC::MIPSAssembler::MIPSAssembler): (JSC::MIPSAssembler::): (JSC::MIPSAssembler::JmpSrc::JmpSrc): (JSC::MIPSAssembler::JmpDst::JmpDst): (JSC::MIPSAssembler::JmpDst::isUsed): (JSC::MIPSAssembler::JmpDst::used): (JSC::MIPSAssembler::emitInst): (JSC::MIPSAssembler::nop): (JSC::MIPSAssembler::loadDelayNop): (JSC::MIPSAssembler::copDelayNop): (JSC::MIPSAssembler::move): (JSC::MIPSAssembler::li): (JSC::MIPSAssembler::lui): (JSC::MIPSAssembler::addiu): (JSC::MIPSAssembler::addu): (JSC::MIPSAssembler::subu): (JSC::MIPSAssembler::mult): (JSC::MIPSAssembler::mfhi): (JSC::MIPSAssembler::mflo): (JSC::MIPSAssembler::mul): (JSC::MIPSAssembler::andInsn): (JSC::MIPSAssembler::andi): (JSC::MIPSAssembler::nor): (JSC::MIPSAssembler::orInsn): (JSC::MIPSAssembler::ori): (JSC::MIPSAssembler::xorInsn): (JSC::MIPSAssembler::xori): (JSC::MIPSAssembler::slt): (JSC::MIPSAssembler::sltu): (JSC::MIPSAssembler::sltiu): (JSC::MIPSAssembler::sll): (JSC::MIPSAssembler::sllv): (JSC::MIPSAssembler::sra): (JSC::MIPSAssembler::srav): (JSC::MIPSAssembler::lw): (JSC::MIPSAssembler::lwl): (JSC::MIPSAssembler::lwr): (JSC::MIPSAssembler::lhu): (JSC::MIPSAssembler::sw): (JSC::MIPSAssembler::jr): (JSC::MIPSAssembler::jalr): (JSC::MIPSAssembler::jal): (JSC::MIPSAssembler::bkpt): (JSC::MIPSAssembler::bgez): (JSC::MIPSAssembler::bltz): (JSC::MIPSAssembler::beq): (JSC::MIPSAssembler::bne): (JSC::MIPSAssembler::bc1t): (JSC::MIPSAssembler::bc1f): (JSC::MIPSAssembler::newJmpSrc): (JSC::MIPSAssembler::appendJump): (JSC::MIPSAssembler::addd): (JSC::MIPSAssembler::subd): (JSC::MIPSAssembler::muld): (JSC::MIPSAssembler::lwc1): (JSC::MIPSAssembler::ldc1): (JSC::MIPSAssembler::swc1): (JSC::MIPSAssembler::sdc1): (JSC::MIPSAssembler::mtc1): (JSC::MIPSAssembler::mfc1): (JSC::MIPSAssembler::truncwd): (JSC::MIPSAssembler::cvtdw): (JSC::MIPSAssembler::ceqd): (JSC::MIPSAssembler::cngtd): (JSC::MIPSAssembler::cnged): (JSC::MIPSAssembler::cltd): (JSC::MIPSAssembler::cled): (JSC::MIPSAssembler::cueqd): (JSC::MIPSAssembler::coled): (JSC::MIPSAssembler::coltd): (JSC::MIPSAssembler::culed): (JSC::MIPSAssembler::cultd): (JSC::MIPSAssembler::label): (JSC::MIPSAssembler::align): (JSC::MIPSAssembler::getRelocatedAddress): (JSC::MIPSAssembler::getDifferenceBetweenLabels): (JSC::MIPSAssembler::size): (JSC::MIPSAssembler::executableCopy): (JSC::MIPSAssembler::getCallReturnOffset): (JSC::MIPSAssembler::linkJump): (JSC::MIPSAssembler::linkCall): (JSC::MIPSAssembler::linkPointer): (JSC::MIPSAssembler::relinkJump): (JSC::MIPSAssembler::relinkCall): (JSC::MIPSAssembler::repatchInt32): (JSC::MIPSAssembler::repatchPointer): (JSC::MIPSAssembler::repatchLoadPtrToLEA): (JSC::MIPSAssembler::relocateJumps): (JSC::MIPSAssembler::linkWithOffset): (JSC::MIPSAssembler::linkCallInternal):
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerMIPS.h: Added. (JSC::MacroAssemblerMIPS::MacroAssemblerMIPS): (JSC::MacroAssemblerMIPS::): (JSC::MacroAssemblerMIPS::add32): (JSC::MacroAssemblerMIPS::and32): (JSC::MacroAssemblerMIPS::lshift32): (JSC::MacroAssemblerMIPS::mul32): (JSC::MacroAssemblerMIPS::not32): (JSC::MacroAssemblerMIPS::or32): (JSC::MacroAssemblerMIPS::rshift32): (JSC::MacroAssemblerMIPS::sub32): (JSC::MacroAssemblerMIPS::xor32): (JSC::MacroAssemblerMIPS::load32): (JSC::MacroAssemblerMIPS::load32WithUnalignedHalfWords): (JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::loadPtrWithPatchToLEA): (JSC::MacroAssemblerMIPS::loadPtrWithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::load16): (JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::store32): (JSC::MacroAssemblerMIPS::supportsFloatingPoint): (JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate): (JSC::MacroAssemblerMIPS::pop): (JSC::MacroAssemblerMIPS::push): (JSC::MacroAssemblerMIPS::move): (JSC::MacroAssemblerMIPS::swap): (JSC::MacroAssemblerMIPS::signExtend32ToPtr): (JSC::MacroAssemblerMIPS::zeroExtend32ToPtr): (JSC::MacroAssemblerMIPS::branch32): (JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerMIPS::branch16): (JSC::MacroAssemblerMIPS::branchTest32): (JSC::MacroAssemblerMIPS::jump): (JSC::MacroAssemblerMIPS::branchAdd32): (JSC::MacroAssemblerMIPS::branchMul32): (JSC::MacroAssemblerMIPS::branchSub32): (JSC::MacroAssemblerMIPS::breakpoint): (JSC::MacroAssemblerMIPS::nearCall): (JSC::MacroAssemblerMIPS::call): (JSC::MacroAssemblerMIPS::ret): (JSC::MacroAssemblerMIPS::set32): (JSC::MacroAssemblerMIPS::setTest32): (JSC::MacroAssemblerMIPS::moveWithPatch): (JSC::MacroAssemblerMIPS::branchPtrWithPatch): (JSC::MacroAssemblerMIPS::storePtrWithPatch): (JSC::MacroAssemblerMIPS::tailRecursiveCall): (JSC::MacroAssemblerMIPS::makeTailRecursiveCall): (JSC::MacroAssemblerMIPS::loadDouble): (JSC::MacroAssemblerMIPS::storeDouble): (JSC::MacroAssemblerMIPS::addDouble): (JSC::MacroAssemblerMIPS::subDouble): (JSC::MacroAssemblerMIPS::mulDouble): (JSC::MacroAssemblerMIPS::convertInt32ToDouble): (JSC::MacroAssemblerMIPS::insertRelaxationWords): (JSC::MacroAssemblerMIPS::branchTrue): (JSC::MacroAssemblerMIPS::branchFalse): (JSC::MacroAssemblerMIPS::branchEqual): (JSC::MacroAssemblerMIPS::branchNotEqual): (JSC::MacroAssemblerMIPS::branchDouble): (JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32): (JSC::MacroAssemblerMIPS::linkCall): (JSC::MacroAssemblerMIPS::repatchCall):
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- wtf/Platform.h:
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
- 7:31 PM Changeset in webkit [55499] by
-
- 3 edits2 adds in trunk
2010-03-03 Chad Faragher <wyck@chromium.org>
Reviewed by Darin Adler.
Changed the double-click framework code to pass adjusted page
coordinates for zoomed pages. Added a new test to expose
mistreatment of mouse click coordinates during a double-click.
- fast/events/zoom-dblclick-expected.txt: Added.
- fast/events/zoom-dblclick.html: Added.
2010-03-03 Chad Faragher <wyck@chromium.org>
Reviewed by Darin Adler.
Changed the double-click framework code to pass adjusted page
coordinates for zoomed pages. Added a new test to expose
mistreatment of mouse click coordinates during a double-click.
Test: fast/events/zoom-dblclick.html
- dom/Node.cpp: (WebCore::Node::dispatchMouseEvent):
- 7:13 PM Changeset in webkit [55498] by
-
- 2 edits in trunk/WebKitTools
2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Simon Hausmann.
Add a missing 'm_' to class variables names.
[Qt] QtLauncher is not respecting class variable names
https://bugs.webkit.org/show_bug.cgi?id=35542
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::init): (LauncherWindow::sendTouchEvent): (LauncherWindow::eventFilter): (LauncherWindow::zoomIn): (LauncherWindow::zoomOut): (LauncherWindow::resetZoom): (LauncherWindow::setEditable): (LauncherWindow::setTouchMocking): (LauncherWindow::initializeView): (LauncherWindow::createChrome):
- 7:00 PM Changeset in webkit [55497] by
-
- 1 edit in tags/Safari-533.1.1/JavaScriptCore/ChangeLog
Remove extraneous ChangeLog entries.
- 6:56 PM Changeset in webkit [55496] by
-
- 4 edits in tags/Safari-533.1.1/JavaScriptCore
Merged r55495.
- 6:52 PM Changeset in webkit [55495] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- 6:42 PM Changeset in webkit [55494] by
-
- 3 edits in tags/Safari-533.1.1/JavaScriptCore
Merge r55492.
- 6:35 PM Changeset in webkit [55493] by
-
- 1 copy in tags/Safari-533.1.1
New tag.
- 6:33 PM Changeset in webkit [55492] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- 5:23 PM Changeset in webkit [55491] by
-
- 2 edits in trunk/WebCore
No review, rolling out r55474.
The patch broke fast/frames/sandboxed-iframe-storage.html
Last one (I hope).
- WebCore.xcodeproj/project.pbxproj:
- 5:20 PM Changeset in webkit [55490] by
-
- 3 edits in trunk/LayoutTests
Making database-lock-after-reload.html a bit more robust and
cleaning up some style issues.
Reviewed by Dimitri Glazkov.
- storage/database-lock-after-reload.html:
- storage/resources/database-lock-after-reload-2.html:
- 5:14 PM Changeset in webkit [55489] by
-
- 2 edits in trunk/WebKitTools
Rubber-stamped by Mark Rowe.
Exclude leaks in Java that build bot complains about.
- Scripts/run-webkit-tests:
- 5:09 PM Changeset in webkit [55488] by
-
- 2 edits9 deletes in trunk
No review, rolling out r55474.
The patch broke fast/frames/sandboxed-iframe-storage.html
Unfortunately, (the webkit-patch rollout and) I missed these in r55485.
WebCore:
- bindings/js/JSDatabaseCallback.cpp: Removed.
- bindings/js/JSDatabaseCallback.h: Removed.
- bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
- bindings/v8/custom/V8DatabaseCallback.h: Removed.
- storage/DatabaseCallback.h: Removed.
LayoutTests:
- storage/open-database-creation-callback-expected.txt: Removed.
- storage/open-database-creation-callback-isolated-world-expected.txt: Removed.
- storage/open-database-creation-callback-isolated-world.html: Removed.
- storage/open-database-creation-callback.html: Removed.
- 5:01 PM Changeset in webkit [55487] by
-
- 2 edits in trunk/WebCore
Fix a bug that could lead to a crash. Some parts of
SQLTransaction::checkAndHandleClosedDatabase() should only be run
when that method is invoked on the DB thread.
Reviewed by Dimitri Glazkov.
We cannot test this fix with a test, because the crash happens
only when all of the following conditions are met:
- A database is closing.
- A transaction on that database is in progress.
- The transaction is in a state where a statement/transaction
success/error callback needs to be invoked (so there's a task for
this transaction pending on the main thread).
- The DB thread finished processing all its tasks and called
SQLTransactionCoordinator::shutdown() before the main thread go to
that task.
The closest thing we have to a test is running
LayoutTests/storage/database-lock-after-reload.html 1000 times in
a row. Without the patch, the probability of a crash happening in
one of the runs is very high. With the patch, the test should
reliably run 1000 times in a row without a single crash.
https://bugs.webkit.org/show_bug.cgi?id=35624
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):
- 4:47 PM Changeset in webkit [55486] by
-
- 3 edits in trunk/WebCore
2010-03-03 Darin Fisher <darin@chromium.org>
Reviewed by Mark Rowe.
Page should not care about Chromium plug-in implementation details
https://bugs.webkit.org/show_bug.cgi?id=35623
- WebCore.gypi: Compile PluginViewNone.cpp
- page/Page.cpp: (WebCore::Page::privateBrowsingStateChanged): Remove conditional compilation for PLATFORM(CHROMIUM).
- 4:38 PM Changeset in webkit [55485] by
-
- 17 edits in trunk/WebCore
2010-03-03 David Levin <levin@chromium.org>
No review, rolling out r55474.
http://trac.webkit.org/changeset/55480
The patch broke fast/frames/sandboxed-iframe-storage.html
- Android.jscbindings.mk:
- Android.v8bindings.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- dom/Document.cpp: (WebCore::Document::postTask):
- page/DOMWindow.cpp: (WebCore::DOMWindow::openDatabase):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
- storage/Database.h:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase):
- workers/WorkerContext.h:
- 4:36 PM Changeset in webkit [55484] by
-
- 3 edits in trunk/WebCore
2010-03-03 David Levin <levin@chromium.org>
No review, rolling out r55480.
http://trac.webkit.org/changeset/55480
The patch broke fast/frames/sandboxed-iframe-storage.html
- storage/Database.cpp:
- storage/Database.h:
- 4:22 PM Changeset in webkit [55483] by
-
- 5 edits in trunk
Add virtual memory tags for TCMalloc and WebCore's purgeable buffers.
Reviewed by Geoff Garen.
- wtf/TCSystemAlloc.cpp:
(TryMmap): Use the VM tag.
- wtf/VMTags.h: Make use of VM_MEMORY_TCMALLOC and VM_MEMORY_WEBCORE_PURGEABLE_BUFFERS.
WebCore:
- platform/mac/PurgeableBufferMac.cpp:
(WebCore::PurgeableBuffer::create): Use the VM tag.
- 4:20 PM Changeset in webkit [55482] by
-
- 3 edits1 delete in trunk/LayoutTests
Not reviewed.
Try better to fix Java tests on Tiger bot.
- platform/mac-tiger/Skipped:
- platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Removed. This test gets different resultson each run when it fails, so it needs to be disabled on Tiger.
- platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added a newline I didn't get when copying actual results from buildbot.
- 4:05 PM Changeset in webkit [55481] by
-
- 3 edits in trunk/WebKitTools
Additional change to separate Accelerated Compositing test from 3D Rendering test
https://bugs.webkit.org/show_bug.cgi?id=35610
- 3:03 PM Changeset in webkit [55480] by
-
- 3 edits in trunk/WebCore
Move #include "DatabaseCallback.h" from Database.h to
Database.cpp.
Reviewed by nobody, build fix.
- storage/Database.cpp:
- storage/Database.h:
- 2:55 PM Changeset in webkit [55479] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip new test introduced in r55474, because of
missing layoutTestController.evaluateScriptInIsolatedWorld()
- platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped.
- 2:24 PM Changeset in webkit [55478] by
-
- 2 edits in trunk/WebCore
Fixed Mac build.
- WebCore.xcodeproj/project.pbxproj: Marked a couple of headers "private" so they can
be used in the WebKit project.
- 2:22 PM Changeset in webkit [55477] by
-
- 188 edits1 add in trunk/LayoutTests
Rubber-stamped by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35700
Some of the newly added Java tests fail randomly on buildbot
- fast/js/resources/js-test-post-async.js: Added a version that calls notifyDone(). I first wanted to add a notifyDone() call to js-test-post.js, but it turns out that multiple tests dump results after "TEST COMPLETE", and we need to get bots back to green fast.
- java/lc3: (Many files). Don't load two scripts dynamically, WebKit has issues with order of execution in this case.
- 2:06 PM Changeset in webkit [55476] by
-
- 2 edits in trunk/JavaScriptCore
Rubber stamped by Adam Roben.
Fix bogus xcopy that was polluting source tree at build time.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- 2:05 PM Changeset in webkit [55475] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=35044
Crash in XML tokenizer reloading zoom-coords-viewattr-01-b.svg
I'm often getting a crash even when opening the test for the first time in Safari, but it
doesn't seem to crash in DumpRenderTree. Still, I can't think of a stronger way to test for
this condition, so no new regression test.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end): Be prepared that parsing remaining input will pause parsing.
- 1:48 PM Changeset in webkit [55474] by
-
- 19 edits9 adds in trunk
WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().
Reviewed by Adam Barth.
Test: storage/open-database-creation-callback.html
https://bugs.webkit.org/show_bug.cgi?id=34726
- Android.jscbindings.mk
- Android.v8bindings.mk
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
- bindings/js/JSDatabaseCallback.cpp: Added.
(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):
- bindings/js/JSDatabaseCallback.h: Added.
(WebCore::JSDatabaseCallback::create):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- bindings/v8/custom/V8DatabaseCallback.cpp: Added.
(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):
- bindings/v8/custom/V8DatabaseCallback.h: Added.
(WebCore::V8DatabaseCallback::create):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- storage/Database.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):
- storage/Database.h:
(WebCore::Database::isNew):
- storage/DatabaseCallback.h: Added.
(WebCore::DatabaseCallback::~DatabaseCallback):
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
- workers/WorkerContext.h:
LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=34726
- storage/open-database-creation-callback-expected.txt: Added.
- storage/open-database-creation-callback.html: Added.
- storage/open-database-creation-callback-isolated-world-expected.txt: Added.
- storage/open-database-creation-callback-isolated-world.html: Added.
- 1:33 PM Changeset in webkit [55473] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Useless change to kick the Windows build into recompiling the idl files
- 1:25 PM Changeset in webkit [55472] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild
- 12:45 PM Changeset in webkit [55471] by
-
- 1 edit6 adds in trunk/LayoutTests
Not reviewed.
Two newly added Java tests fail on Tiger build bot.
Just land actual results as expected. I don't even know which behavior is more correct.
- platform/mac-tiger/java: Added.
- platform/mac-tiger/java/lc3: Added.
- platform/mac-tiger/java/lc3/JavaArray: Added.
- platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Added.
- platform/mac-tiger/java/lc3/JavaObject: Added.
- platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added.
- 11:34 AM Changeset in webkit [55470] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=35692
<rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView
- Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): Retain the challenge, just like it's done for sheet.
- 11:15 AM Changeset in webkit [55469] by
-
- 2 edits696 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35617
Import Mozilla LiveConnect 3 test suite
- java/lc3/sources: Added (many files). Sources for Mozilla test applet.
- java/jstests.jar: Added in compiled form, since it's unlikely that we'll ever need to modify the above sources.
- java/lc3.java: Added. (lc3): This is a small wrapper around jstests.jar. The latter only adds some classes, but WebKit needs an actual applet to call into Java. (lc3.createQAObject): Instantiate a class defined in jstests.jar by name. (lc3.stringToByteArray): A helper to make a byte array out of string. Tests originally relied on window.java package interface to do this, but it's not available in WebKit. We need more functions like this to work around other uses of window.java, but this is one I wrote for now.
- java/Makefile: Link test applets to Mozilla's jstests.jar. This is not needed for tests other than ones imported here, but it's also harmless, and I don't know how to write good makefiles.
- java/lc3: Added (many files). Tests were heavily reworked to run to completion, but PASS/FAIL results should not be generally relied upon. All html wrappers are identical.
- 11:05 AM Changeset in webkit [55468] by
-
- 3 edits in trunk/LayoutTests
2010-03-03 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Update expected results for fast/js/custom-constructors-expected.txt
- 10:51 AM Changeset in webkit [55467] by
-
- 7 edits in trunk
Enable LayoutTests/compositing for Windows when compositing is available
https://bugs.webkit.org/show_bug.cgi?id=35610
- 10:20 AM Changeset in webkit [55466] by
-
- 10 edits in trunk/WebCore
2010-03-03 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: resources panel only shows uncompressed resource size.
https://bugs.webkit.org/show_bug.cgi?id=35403
- English.lproj/localizedStrings.js:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.refresh):
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
- inspector/front-end/ImageView.js: (WebInspector.ImageView):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get resourceSize): (WebInspector.Resource.prototype.set resourceSize): (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.CompareBySize): (WebInspector.Resource.CompareByTransferSize):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphPercentages): (WebInspector.ResourceTransferSizeCalculator.prototype._value): (WebInspector.ResourceTransferSizeCalculator.prototype._networkBytes): (WebInspector.ResourceSidebarTreeElement.CompareByDescendingTransferSize): (WebInspector.ResourceGraph.prototype.refreshLabelPositions): (WebInspector.ResourceGraph.prototype.refresh):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 9:42 AM Changeset in webkit [55465] by
-
- 2 edits in trunk/WebCore
Build fix.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
- 9:24 AM Changeset in webkit [55464] by
-
- 11 edits in trunk
2010-03-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Get rid of synchronous debuggerEnabled, profilerEnabled calls.
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
- 9:19 AM Changeset in webkit [55463] by
-
- 12 edits4 adds4 deletes in trunk
2010-03-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
https://bugs.webkit.org/show_bug.cgi?id=35385
rdar://problem/7689602
Tests: media/audio-constructor-preload.html
media/video-dom-preload.html
- html/HTMLAttributeNames.in: Remove autobuffer, add preload
- html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::createForJSConstructor): set preload to 'auto' instead of
autobuffer to true.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_preload. (WebCore::HTMLMediaElement::parseMappedAttribute): Deal with 'preload' attribute. (WebCore::HTMLMediaElement::loadResource): Call setPreload() on the newly created MediaPlayer,
before calling load() so it can pass the setting through to the media engine.
(WebCore::HTMLMediaElement::preload): New.
(WebCore::HTMLMediaElement::setPreload): Ditto
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_preload. (WebCore::MediaPlayer::load): Pass m_preload to newly created media engine. (WebCore::MediaPlayer::preload): New, return m_preload. (WebCore::MediaPlayer::setPreload): New, set m_preload.
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::):
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPreload):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::setPreload): Renamed from setAutoplay, fix logic for preload.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2010-03-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
https://bugs.webkit.org/show_bug.cgi?id=35385
rdar://problem/7689602
- media/audio-constructor-autobuffer-expected.txt: Removed.
- media/audio-constructor-autobuffer.html: Removed.
- media/audio-constructor-preload-expected.txt: Added.
- media/audio-constructor-preload.html: Added.
- media/video-dom-autobuffer-expected.txt: Removed.
- media/video-dom-autobuffer.html: Removed.
- media/video-dom-preload-expected.txt: Added.
- media/video-dom-preload.html: Added.
- 7:21 AM QtWebKitBugs edited by
- (diff)
- 7:02 AM Changeset in webkit [55462] by
-
- 3 edits2 adds in trunk
<rdar://problem/7682756> Assertion failure when replacing the contents of a <select>
Reviewed by Sam Weinig.
WebCore:
Test: fast/dom/remove-children-notification-order.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren): Changed to call childrenChanged()
before calling removedFromDocument() on each removed child, which matches
the order removeChild() does things, and avoids the assertion. This required
temporarily storing the removed children in a vector.
Also added comments about other discrepancies between this function and
removeChild().
LayoutTests:
- fast/dom/remove-children-notification-order-expected.txt: Added.
- fast/dom/remove-children-notification-order.html: Added.
- 6:48 AM Changeset in webkit [55461] by
-
- 2 edits in trunk/WebCore
2010-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Document cookieURL and firstPartyForCookies
https://bugs.webkit.org/show_bug.cgi?id=35613
Some folks asked what the cookieURL and the firstPartyForCookies were
on IRC. This patch documents these properties in the code so folks
don't have to ask on IRC anymore.
- dom/Document.h:
- 6:42 AM Changeset in webkit [55460] by
-
- 4 edits in trunk/WebKitTools
2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Simon Hausmann.
Refactor QtLauncher so it respects command line arguments
and inherits settings when you clone or create a new window.
Implemented with help of Kenneth Rohde Christiansen.
[Qt] QtLauncher must be refactored to fix command line arguments usage
https://bugs.webkit.org/show_bug.cgi?id=35536
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::init): (LauncherWindow::isGraphicsBased): (applySetting): (LauncherWindow::applyPrefs): (LauncherWindow::initializeView): (LauncherWindow::newWindow): (LauncherWindow::cloneWindow): (LauncherWindow::createChrome): (main):
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
- QtLauncher/webview.h: (WebViewGraphicsBased::itemCacheMode): (WebViewGraphicsBased::frameRateMeasurementEnabled):
- 6:40 AM Google Summer of Code 2010 edited by
- (diff)
- 6:00 AM Google Summer of Code 2010 edited by
- (diff)
- 5:30 AM Changeset in webkit [55459] by
-
- 2 edits in trunk/WebCore
2010-03-03 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk]: assertion triggered when geolocation getCurrentPosition without an option argument.
https://bugs.webkit.org/show_bug.cgi?id=35666
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating):
- 5:17 AM Changeset in webkit [55458] by
-
- 2 edits in trunk/LayoutTests
2010-03-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
[GTK] build slaves need working geoclue service
https://bugs.webkit.org/show_bug.cgi?id=35674
Skip tests we're not really able to run for the time being.
- platform/gtk/Skipped:
- 4:44 AM Changeset in webkit [55457] by
-
- 6 edits in trunk
2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640
- GNUmakefile.am: On Windows with GCC, presence of declspec(dllexport) on some symbols disables the autoexport/autoimport feature for all others. Using regex here assures that all symbols that need to be exported in the dll are actually exported.
2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640
- GNUmakefile.am: dist two new files concerning mathml support.
2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640
- webkit/webkitdownload.cpp: Windows headers define ERROR which breaks the build. Undef ERROR if it is defined.
- 4:09 AM Changeset in webkit [55456] by
-
- 2 edits in trunk/WebCore
2010-03-03 Xan Lopez <xlopez@igalia.com>
Unreviewed distcheck fix.
Add new file to the build.
- GNUmakefile.am:
- 4:02 AM Changeset in webkit [55455] by
-
- 3 edits1 add in trunk/WebCore
Make IntPoint usable as a hash key
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=35586
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/IntPointHash.h: Added.
(WTF::IntPointHash::hash):
(WTF::IntPointHash::equal):
(WTF::):
- 12:24 AM Changeset in webkit [55454] by
-
- 2 edits in trunk/WebKit/gtk
2010-03-03 Philippe Normand <pnormand@igalia.com>
Unreviewed, build fix after r55452.
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_settings_notify): added missing braces.
- 12:07 AM Changeset in webkit [55453] by
-
- 3 edits in trunk/JavaScriptCore
2010-03-02 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Oliver Hunt.
Allow building smoothly on win32 and win64 using GCC
https://bugs.webkit.org/show_bug.cgi?id=35607
- jit/JITStubs.h:
- runtime/Collector.cpp: (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase):
Mar 2, 2010:
- 11:43 PM Changeset in webkit [55452] by
-
- 11 edits in trunk
2010-03-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.
No new tests; tested by existing storage tests.
- WebCore.base.exp: Export Database::setIsAvailable
- WebCore.xcodeproj/project.pbxproj: Export needed headers as Private
- page/DOMWindow.cpp: Read isAvailable, not Settings::isDatabaseEnabled (WebCore::DOMWindow::openDatabase):
- page/Settings.cpp: Add a call to Database::setIsAvailable. (WebCore::Settings::setDatabasesEnabled):
2010-03-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.
No new tests; tested by existing storage tests.
- webkit/webkitwebview.cpp: Add calls to Database::setIsAvailable (DNDContentsRequest::webkit_web_view_update_settings): (DNDContentsRequest::webkit_web_view_settings_notify):
2010-03-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.
No new tests; tested by existing storage tests.
- WebView/WebView.mm: Added a call to Database::setIsAvailable. (-[WebView _preferencesChangedNotification:]):
2010-03-02 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.
No new tests; tested by existing storage tests.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): Add a call to Database::setIsAvailable
- 11:22 PM Changeset in webkit [55451] by
-
- 5 edits in trunk
2010-03-02 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
add a flag to WebURLResponse so we can identify multipart content
https://bugs.webkit.org/show_bug.cgi?id=35628
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::isMultipartPayload): (WebCore::ResourceResponse::setIsMultipartPayload):
2010-03-02 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
add a flag to WebURLResponse so we can identify multipart content
https://bugs.webkit.org/show_bug.cgi?id=35628
- public/WebURLResponse.h:
- src/WebURLResponse.cpp: (WebKit::WebURLResponse::isMultipartPayload): (WebKit::WebURLResponse::setIsMultipartPayload):
- 10:46 PM Changeset in webkit [55450] by
-
- 3 edits2 deletes in trunk
2010-03-02 Tony Chang <tony@chromium.org>
Not reviewed, test fix.
Revert r55447 because the new layout test is crashing consistently
on Leopard Intel Debug (tests).
https://bugs.webkit.org/show_bug.cgi?id=35261
- svg/custom/tiling-regular-hexagonal-crash-expected.txt: Removed.
- svg/custom/tiling-regular-hexagonal-crash.svg: Removed.
2010-03-02 Tony Chang <tony@chromium.org>
Not reviewed, test fix.
Revert r55447 because the new layout test is crashing consistently
on Leopard Intel Debug (tests).
https://bugs.webkit.org/show_bug.cgi?id=35261
- platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create):
- 7:16 PM Changeset in webkit [55449] by
-
- 14 edits in trunk
2010-03-02 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Google Analytics triggers "blocked plugin" UI
https://bugs.webkit.org/show_bug.cgi?id=35565
Just like for running script, we need to distinguish between querying
whether plug-ins are enabled and actually blocking a page from
instantiating a plugin. We need to issue different callbacks to the
FrameLoaderClient so that the client can inform us that plug-ins are
disabled in some cases without showing the "plug-in blocked" UI.
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::allowPlugins):
- loader/FrameLoader.h: (WebCore::):
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::didNotAllowPlugins):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
- page/Page.cpp: (WebCore::Page::pluginData):
- plugins/MimeType.cpp: (WebCore::MimeType::enabledPlugin):
2010-03-02 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Google Analytics triggers "blocked plugin" UI
https://bugs.webkit.org/show_bug.cgi?id=35565
Plumb didNotAllowPlugins to the client.
- public/WebFrameClient.h: (WebKit::WebFrameClient::didNotAllowPlugins):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
- src/FrameLoaderClientImpl.h:
- 6:53 PM Changeset in webkit [55448] by
-
- 2 edits in trunk/WebCore
2010-03-02 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Support the HTTP OPTIONS verb (needed for preflight requests)
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
- 6:37 PM Changeset in webkit [55447] by
-
- 3 edits2 adds in trunk
2010-03-02 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs with Skia
This test passes if it doesn't crash.
- svg/custom/tiling-regular-hexagonal-crash-expected.txt: Added.
- svg/custom/tiling-regular-hexagonal-crash.svg: Added.
2010-03-02 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs
This fixes the crash, but the SVG still doesn't render properly.
Test: svg/custom/tiling-regular-hexagonal-crash.svg
- platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create): don't return 0 when the copy fails; instead return a blank bitmap. The caller doesn't check for 0 before dereferencing.
- 6:20 PM Changeset in webkit [55446] by
-
- 2 edits in trunk/WebCore
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] use geoclue providers with don't provide update
https://bugs.webkit.org/show_bug.cgi?id=35191
No new tests, behaviour depends on system.
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating):
- 5:43 PM Changeset in webkit [55445] by
-
- 2 edits in trunk/WebCore
2010-03-02 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Adler.
Remove unnecessary check.
https://bugs.webkit.org/show_bug.cgi?id=35513
- platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):
- 5:27 PM Changeset in webkit [55444] by
-
- 16 edits2 adds in trunk
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210
- GNUmakefile.am:
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210
- platform/gtk/Skipped:
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ChromeClientGtk.h:
- docs/webkitgtk-sections.txt:
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitgeolocationpolicydecision.cpp: Added. (webkit_geolocation_policy_decision_class_init): (webkit_geolocation_policy_decision_init): (webkit_geolocation_policy_decision_new): (webkit_geolocation_policy_allow): (webkit_geolocation_policy_deny):
- webkit/webkitgeolocationpolicydecision.h: Added.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
- webkitmarshal.list:
2010-03-02 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210
- DumpRenderTree/gtk/DumpRenderTree.cpp: (geolocationPolicyDecisionRequested): (createWebView):
- 4:59 PM Changeset in webkit [55443] by
-
- 2 edits in trunk/WebCore
2010-03-02 Darin Fisher <darin@chromium.org>
Fix chromium build bustage.
- page/Page.cpp: (WebCore::Page::privateBrowsingStateChanged): PluginView methods may not be called in the Chromium port.
- 4:48 PM Changeset in webkit [55442] by
-
- 5 edits in trunk
WebCore: Fix for <rdar://problem/7485289> WebKit crashes on systems that
don't support CoreAnimation
Reviewed by Darin Adler and Adam Roben.
WKCACFLayerRenderer::acceleratedCompositingAvailable() now creates
a dummy HWND so that it can step through the whole setHostWindow()
and createRenderer() process. createRenderer() also calls a new
function, hardwareCapabilitiesIndicateCoreAnimationSupport() which
can only be called once we have a d3dDevice.
setHostWindow() and createRenderer() now both return bools that
indicate whether or not they have succeeded.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::hardwareCapabilitiesIndicateCoreAnimationSupport):
(WebCore::CoreAnimationTesterWindowWndProc):
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
(WebCore::WKCACFLayerRenderer::shared):
(WebCore::WKCACFLayerRenderer::createRenderer):
- platform/graphics/win/WKCACFLayerRenderer.h:
(WebCore::WKCACFLayerRenderer::setHostWindow):
WebKit/win: Tiny WebKit portion of fix for <rdar://problem/7485289> WebKit
crashes on systems that don't support CoreAnimation
Reviewed by Darin Adler and Adam Roben.
setHostWindow() no longer calls createRenderer(), so now that has
to be called manually.
- WebView.cpp:
(WebView::setAcceleratedCompositing):
- 4:43 PM Changeset in webkit [55441] by
-
- 3 edits in trunk/WebCore
ScriptDebugServer shouldn't care that Mac does not use PluginView for plug-ins.
Rubber-stamped by Jon Honeycutt.
- bindings/js/ScriptDebugServer.cpp:
- plugins/PluginViewNone.cpp:
(WebCore::PluginView::setJavaScriptPaused): Add an empty implementation of setJavaScriptPaused.
- 4:36 PM Changeset in webkit [55440] by
-
- 3 edits in trunk/WebCore
Clean up the build fix r55437 by adding an empty implementation of privateBrowsingStateChanged in PluginViewNone.cpp
Rubber-stamped by Jon Honeycutt.
- page/Page.cpp:
- plugins/PluginViewNone.cpp:
(WebCore::PluginView::privateBrowsingStateChanged):
- 4:16 PM Changeset in webkit [55439] by
-
- 1 edit1 delete in trunk/WebKitTools
2010-03-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
Revert r55339 - the Chromium codebase downstream had a temporary
need for WebKitTools/pywebsocket to still exist after Chris Jerdonek
had moved it (scripts still referenced the old location). Those
scripts have been updated to the new location, so it should be safe
to delete this now.
- pywebsocket/mod_pywebsocket/standalone.py: Removed.
- 4:09 PM Changeset in webkit [55438] by
-
- 2 edits in trunk/WebKitExamplePlugins
NPWindow is now null in the Cocoa event model.
Reviewed by Kevin Decker.
- NetscapeInputMethodPlugin/main.m:
(handleDraw):
(NPP_HandleEvent):
- 3:39 PM Changeset in webkit [55437] by
-
- 2 edits in trunk/WebCore
Fix the Mac build.
- page/Page.cpp:
(WebCore::Page::privateBrowsingStateChanged): Mac doesn't use WebCore's PluginView class
for plug-ins, so provide an empty implementation of privateBrowsingStateChanged for Mac.
- 3:33 PM Changeset in webkit [55436] by
-
- 8 edits2 adds in trunk
WebCore: Add the capability to create and dispatch a WheelEvent in JavaScript.
Ensure the event's default handler is triggered in the same way as it is
during a PlatformWheelEvent.
Patch by Andy Estes <aestes@apple.com> on 2010-03-02
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35566
Test: fast/events/wheelevent-in-scrolling-div.html
- dom/Node.cpp: Ensure that the default behavior (scrolling) occurs for
wheel events originating both from the platform and from
JavaScript/ObjC.
(WebCore::Node::dispatchWheelEvent): Instantiate new WheelEvent with
the graunularity of the PlatformWheelEvent.
(WebCore::Node::defaultEventHandler): Add support for mousewheel events.
- dom/WheelEvent.cpp: Add three new member variables: m_deltaX, m_deltaY
and m_granularity. m_deltaX and m_deltaY differ from m_wheelDeltaX and
m_wheelDeltaY, which are the number of wheel ticks multiplied by 120 for
IE compatibility.
(WebCore::WheelEvent::WheelEvent): Initialize new member variables.
(WebCore::WheelEvent::initWheelEvent): Same.
(WebCore::WheelEvent::initWebKitWheelEvent): Same.
- dom/WheelEvent.h: See WheelEvent.cpp.
(WebCore::WheelEvent::): Add Granularity enum (Pixel, Line, Page).
(WebCore::WheelEvent::create): Add new arguments.
(WebCore::WheelEvent::deltaX): Amount of scroll in x direction.
(WebCore::WheelEvent::deltaY): Amount of scroll in y direction.
(WebCore::WheelEvent::granularity): Units of deltaX and deltaY.
- dom/WheelEvent.idl: Add initWebKitWheelEvent() to JavaScript. This is
the same as the initWheelEvent ObjC method. As the DOM Level 3 Events
specification is still a working draft and subject to change, prefix
'WebKit' to the method signature to indicate experimental support.
- page/EventHandler.cpp: Move the scroll handling from
handleWheelEvent() to defaultWheelEventHandler(), which is executed on
both PlatformWheelEvents and JavaScript WheelEvents.
(WebCore::scrollNode): Renamed from scrollAndAcceptEvent(). Remove
the PlatformWheelEvent from the argument list and instead return a
boolean indicating if the scroll event was accepted.
(WebCore::EventHandler::handleWheelEvent): Move scrolling code from here
(WebCore::EventHandler::defaultWheelEventHandler): ...to here.
- page/EventHandler.h: Add function signature.
LayoutTests: Add a test for the patch to https://bugs.webkit.org/show_bug.cgi?id=35566.
These can be run manually or from DRT.
Patch by Andy Estes <aestes@apple.com> on 2010-03-02
Reviewed by Maciej Stachowiak.
- fast/events/wheelevent-in-scrolling-div-expected.txt: Added.
- fast/events/wheelevent-in-scrolling-div.html: Added.
- 3:32 PM Changeset in webkit [55435] by
-
- 2 edits in trunk/WebKitTools
2010-03-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
new-run-webkit-tests on chromium-linux tests to see if
layout_test_helper exists, but we don't use layout_test_helper on
linux. The test derefences a None object, and we crash. This fixes
that.
- Scripts/webkitpy/layout_tests/port/chromium.py:
2010-03-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
r55388 (bug 35553) worked around a bug in Python's subprocess.Popen()
that was causing DRT to hang on exit in new-run-webkit-tests.
Unfortunately, that workaround doesn't work on chromium-win
(and the script fails completely). The good news is that the check
isn't actually necessary, and so this change makes it conditional.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 3:29 PM Changeset in webkit [55434] by
-
- 2 edits in trunk/WebKitTools
2010-03-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
r55388 (bug 35553) worked around a bug in Python's subprocess.Popen()
that was causing DRT to hang on exit in new-run-webkit-tests.
Unfortunately, that workaround doesn't work on chromium-win
(and the script fails completely). The good news is that the check
isn't actually necessary, and so this change makes it conditional.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 3:13 PM Changeset in webkit [55433] by
-
- 11 edits in trunk
Bug 35576: WebKit should tell plug-in instances when private browsing state changes
<http://webkit.org/b/35576>
Reviewed by Darin Adler.
WebCore:
Notify plug-in instances when the private browsing state changes to match the behavior of the
Mac plug-in code.
- page/Page.cpp:
(WebCore::Page::privateBrowsingStateChanged): Walk the frame tree and notify each PluginView that
the private browsing state has changed.
- page/Page.h:
- page/Settings.cpp:
(WebCore::Settings::setPrivateBrowsingEnabled): Notify the page that the private browsing state
has changed.
- plugins/PluginView.cpp:
(WebCore::PluginView::privateBrowsingStateChanged): Notify the plug-in instance of the new private
browsing state.
- plugins/PluginView.h:
WebKitTools:
TestNetscapePlugin is another bit of plug-in code where copy-paste was heavily used
when porting. Update the Windows and UNIX implementations of NPP_New and NPP_SetValue
to provide the expected behavior related to NPNVprivateModeBool. Hopefully this code
duplication can be cleaned up in the future.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
(webkit_test_plugin_set_value):
- DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_New):
(NPP_SetValue):
LayoutTests:
- platform/win/Skipped: Remove plugins/private-browsing-mode.html now that it passes.
- 3:13 PM Changeset in webkit [55432] by
-
- 11 edits in trunk
Bug 30348: Implement private mode for plug-ins on Windows
<http://webkit.org/b/30348> / <rdar://problem/7562261>
Reviewed by Oliver Hunt.
WebCore:
Rework PluginView::getValue and PluginView::getValueStatic to remove the amount of code that
was duplicated across platforms. getValue and getValueStatic now call in to platform-specific
variants that indicate whether they handled the query. If the query is not handled by the
platform-specific variants then the cross-platform handler has a chance to handle it.
- plugins/PluginView.cpp:
(WebCore::PluginView::getValueStatic): Give the platform-specific variant a chance to handle the
variable lookup. If it does not handle it, return an error.
(WebCore::PluginView::getValue): Give the platform-specific variant and platform-specific static
variant a chance to handle the variable lookup. If they do not handle it, apply the cross-platform
handler. At the moment the cross-platform code handles NPNVWindowNPObject, NPNVPluginElementNPObject,
and NPNVprivateModeBool as they have an identical implementation across ports.
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp:
(WebCore::PluginView::platformGetValue): PluginViewNone does not handle any lookups.
(WebCore::PluginView::platformGetValueStatic): Ditto.
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
platform-independent implementation.
- plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue): Fix a bug noticed while updating this code.
The Qt implementation of the handler for NPNVToolkit was relying on case fall-through
to have some values handled by the static handler. When NPNVprivateModeBool was added
it was placed before the default case, interferring with this fall-through. It now
explicitly indicates in this situation that it was not handled.
- plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
LayoutTests:
- platform/win/Skipped: Remove plugins/private-browsing-mode-2.html now that it passes.
- 2:27 PM Changeset in webkit [55431] by
-
- 3 edits in trunk/WebCore
Make the default constructor available to all platforms.
Reviewed by Sam Weinig.
- platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- platform/mac/KeyEventMac.mm:
- 2:24 PM Changeset in webkit [55430] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=35600
shouldBe() fails when comparing an array to null.
- fast/js/resources/js-test-pre.js: (areArraysEqual): This function is expected to be called with weird arguments, as it's used with array-like objects like WebGLByteArray. Made it resilient against exceptions raised when dealing with those.
- 2:21 PM Changeset in webkit [55429] by
-
- 8 edits in trunk
2010-03-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by David Levin.
Revert database thread changes that are no longer required
https://bugs.webkit.org/show_bug.cgi?id=35519
Jochen Eisinger created 55214 and 55247 to track which database
owns which thread. Dmitry suggested that this could also
be done via TLS, though. After exploring the options, Jochen
chose to go the TLS route, so these patches are no longer needed.
- wtf/Threading.h:
- wtf/ThreadingNone.cpp: (WTF::isMainThread):
- wtf/ThreadingPthreads.cpp: (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::pthreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::currentThread):
- wtf/ThreadingWin.cpp: (WTF::threadMap): (WTF::storeThreadHandleByIdentifier): (WTF::threadHandleForIdentifier): (WTF::createThreadInternal):
2010-03-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by David Levin.
Revert database thread changes that are no longer required
https://bugs.webkit.org/show_bug.cgi?id=35519
Jochen Eisinger created 55214 and 55247 to track which database
owns which thread. Dmitry suggested that this could also
be done via TLS, though. After exploring the options, Jochen
chose to go the TLS route, so these patches are no longer needed.
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::databaseThread):
- storage/DatabaseThread.h: (WebCore::DatabaseThread::getThreadID):
- 1:46 PM Changeset in webkit [55428] by
-
- 5 edits in trunk
Followup for REGRESSION(r51097) - Unable to log in to statefarm.com
<rdar://problem/7672667> and https://bugs.webkit.org/show_bug.cgi?id=35556
Reviewed by Sam Weinig.
WebCore:
- dom/ScriptElement.cpp:
(WebCore::ScriptElementData::shouldExecuteAsJavaScript): To more perfectly match Gecko's rule,
strip whitespace from the attribute values before comparing to window/onload/onload().
LayoutTests:
- fast/loader/for-window-event-onload-scripts-expected.txt:
- fast/loader/for-window-event-onload-scripts.html:
- 1:39 PM Changeset in webkit [55427] by
-
- 6 edits in trunk/JavaScriptCore
2010-03-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::toString().
More ECMA Script compliance, especially for values as NaN, Inifinite
and really big/small numbers.
[Qt] QScriptValue::toString() returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34850
- qt/api/qscriptconverter_p.h: (QScriptConverter::toString):
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toString):
- qt/tests/qscriptvalue/tst_qscriptvalue.cpp:
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toString_initData): (tst_QScriptValue::toString_makeData): (tst_QScriptValue::toString_test):
- 1:20 PM Changeset in webkit [55426] by
-
- 7 edits1 copy5 adds in trunk/JavaScriptCore
2010-03-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Introduce a new class; QScriptString.
The QScriptString class should act as a handle to "interned"
strings in a QScriptEngine.
[Qt] QtScript should provide QScriptString
https://bugs.webkit.org/show_bug.cgi?id=34843
- qt/api/QtScript.pro:
- qt/api/qscriptengine.cpp: (QScriptEngine::toStringHandle):
- qt/api/qscriptengine.h:
- qt/api/qscriptengine_p.h: (QScriptEnginePrivate::toStringHandle):
- qt/api/qscriptstring.cpp: Added. (QScriptString::QScriptString): (QScriptString::~QScriptString): (QScriptString::operator=): (QScriptString::isValid): (QScriptString::operator==): (QScriptString::operator!=): (QScriptString::toArrayIndex): (QScriptString::toString): (QScriptString::operator QString): (qHash):
- qt/api/qscriptstring.h: Added.
- qt/api/qscriptstring_p.h: Added. (QScriptStringPrivate::QScriptStringPrivate): (QScriptStringPrivate::~QScriptStringPrivate): (QScriptStringPrivate::get): (QScriptStringPrivate::isValid): (QScriptStringPrivate::operator==): (QScriptStringPrivate::operator!=): (QScriptStringPrivate::toArrayIndex): (QScriptStringPrivate::toString): (QScriptStringPrivate::id):
- qt/tests/qscriptstring/qscriptstring.pro: Added.
- qt/tests/qscriptstring/tst_qscriptstring.cpp: Added. (tst_QScriptString::tst_QScriptString): (tst_QScriptString::~tst_QScriptString): (tst_QScriptString::test): (tst_QScriptString::hash): (tst_QScriptString::toArrayIndex_data): (tst_QScriptString::toArrayIndex):
- qt/tests/tests.pro:
- 1:15 PM Changeset in webkit [55425] by
-
- 13 edits2 adds in trunk
aria-label isn't respected on option elements
https://bugs.webkit.org/show_bug.cgi?id=35400
Reviewed by Beth Dakin.
WebCore:
When aria-label is used on an <option> element, it can take three forms.
An option in a multi-select list, a popup button and the menu that is displayed
from the popup button. This patches the three requisite locations so that if
aria-label is used, the correct accessibility text is returned.
Test: platform/mac/accessibility/option-with-arialabel.html
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::stringValue):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::getAttribute):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getAttribute):
(WebCore::AccessibilityRenderObject::stringValue):
- platform/PopupMenuClient.h:
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::populate):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemAccessibilityText):
- rendering/RenderMenuList.h:
- rendering/RenderTextControlSingleLine.h:
(WebCore::RenderTextControlSingleLine::itemAccessibilityText):
WebKit/chromium:
- src/SuggestionsPopupMenuClient.h:
(WebKit::SuggestionsPopupMenuClient::itemAccessibilityText):
LayoutTests:
- platform/mac/accessibility/option-with-arialabel-expected.txt: Added.
- platform/mac/accessibility/option-with-arialabel.html: Added.
- 1:11 PM QtWebKitBugs edited by
- (diff)
- 1:08 PM QtWebKitBugs edited by
- title size adjustment (diff)
- 1:04 PM QtWebKit edited by
- link to the QtWebKitBugs page instead (diff)
- 1:01 PM QtWebKitContrib edited by
- Move bugs information to QtWebKitBugs (diff)
- 1:01 PM QtWebKitBugs created by
- 12:48 PM Changeset in webkit [55424] by
-
- 6 edits2 adds in trunk
2010-03-02 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
[V8] V8 should be notified of context disposals
https://bugs.webkit.org/show_bug.cgi?id=35526
Notify V8 of context disposals to allow it to clean up memory from those
contexts when idle. When disposing a context, start a timer that will
give V8 an idle notification after a while to force cleanup. Use a timer
to avoid performing an idle notification in the middle of navigation where
we know we are not idle.
- WebCore.gypi:
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::disposeContextHandles):
- bindings/v8/V8GCForContextDispose.cpp: Added. (WebCore::V8GCForContextDispose::V8GCForContextDispose): (WebCore::V8GCForContextDispose::notifyContextDisposed): (WebCore::V8GCForContextDispose::notifyIdleSooner): (WebCore::V8GCForContextDispose::instance): (WebCore::V8GCForContextDispose::pseudoIdleTimerFired):
- bindings/v8/V8GCForContextDispose.h: Added.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
2010-03-02 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
[V8] V8 should be notified of context disposals
https://bugs.webkit.org/show_bug.cgi?id=35526
Update V8 DEPS in order to get V8 API changes needed for context
disposal notifications.
- DEPS:
- 12:31 PM Changeset in webkit [55423] by
-
- 5 edits18 deletes in trunk/LayoutTests
2010-03-02 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
Merge ValidityState-stepMismatch-{number,range,unsupported}.html and
input-step-{number,range,unsupported}.html to other tests
https://bugs.webkit.org/show_bug.cgi?id=35435
- Merge ValidityState-stepMismatch-{number,range,unsupported}.html to ValidityState-stepMismatch.html
- Merge input-step--{number,range,unsupported}.html to input-step.html
- fast/forms/ValidityState-stepMismatch-expected.txt:
- fast/forms/ValidityState-stepMismatch-number-expected.txt: Removed.
- fast/forms/ValidityState-stepMismatch-number.html: Removed.
- fast/forms/ValidityState-stepMismatch-range-expected.txt: Removed.
- fast/forms/ValidityState-stepMismatch-range.html: Removed.
- fast/forms/ValidityState-stepMismatch-unsupported-expected.txt: Removed.
- fast/forms/ValidityState-stepMismatch-unsupported.html: Removed.
- fast/forms/input-step-number-expected.txt: Removed.
- fast/forms/input-step-number.html: Removed.
- fast/forms/input-step-range-expected.txt: Removed.
- fast/forms/input-step-range.html: Removed.
- fast/forms/input-step-unsupported-expected.txt: Removed.
- fast/forms/input-step-unsupported.html: Removed.
- fast/forms/input-stepup-stepdown-expected.txt:
- fast/forms/script-tests/ValidityState-stepMismatch-number.js: Removed.
- fast/forms/script-tests/ValidityState-stepMismatch-range.js: Removed.
- fast/forms/script-tests/ValidityState-stepMismatch-unsupported.js: Removed.
- fast/forms/script-tests/ValidityState-stepMismatch.js:
- fast/forms/script-tests/input-step-number.js: Removed.
- fast/forms/script-tests/input-step-range.js: Removed.
- fast/forms/script-tests/input-step-unsupported.js: Removed.
- fast/forms/script-tests/input-stepup-stepdown.js:
- 12:18 PM Changeset in webkit [55422] by
-
- 3 edits in trunk/WebCore
2010-03-02 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: adding missing image files to WebKit.qrc and gypi.
- WebCore.gypi:
- inspector/front-end/WebKit.qrc:
- 12:15 PM Changeset in webkit [55421] by
-
- 2 edits in trunk/WebCore
2010-03-02 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: Video element with 3d transform crashes when AC is enabled.
https://bugs.webkit.org/show_bug.cgi?id=35516
No new tests.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::setContentsToMedia):
- 11:50 AM Changeset in webkit [55420] by
-
- 2 edits in trunk/WebCore
2010-03-02 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Xan Lopez.
Use unsigned instead of uint which does not exist on windows
https://bugs.webkit.org/show_bug.cgi?id=35546
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::getCairoSurfacePixel): (WebCore::getGdkPixbufPixel):
- 11:33 AM Changeset in webkit [55419] by
-
- 7 edits in trunk
2010-03-02 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Add EnabledAtRuntime attribute to WebGLArray constructors
https://bugs.webkit.org/show_bug.cgi?id=35558
New functionality verified manually in Chromium; not possible to
write layout test. Ran WebGL tests in WebKit as well.
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebGLEnabled): (WebCore::RuntimeEnabledFeatures::webGLRenderingContextEnabled): (WebCore::RuntimeEnabledFeatures::webGLArrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLByteArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLUnsignedByteArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLShortArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLUnsignedShortArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLIntArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLUnsignedIntArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLFloatArrayEnabled):
- page/DOMWindow.idl:
2010-03-02 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Add EnabledAtRuntime attribute to WebGLArray constructors
https://bugs.webkit.org/show_bug.cgi?id=35558
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebGL): (WebKit::WebRuntimeFeatures::isWebGLEnabled):
- 11:12 AM Changeset in webkit [55418] by
-
- 2 edits in trunk
Ignore compiled Java test cases in .gitignore.
https://bugs.webkit.org/show_bug.cgi?id=35559
Reviewed by Alexey Proskuryakov.
- .gitignore:
- 11:10 AM Changeset in webkit [55417] by
-
- 2 edits in trunk/WebCore
2010-03-02 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Fail gracefully if NPN_GetProperty tries to retrieve a property that doesn't exist.
Required for passing LayoutTests/plugins/netscape-plugin-property-access-exception.html on Chromium.
- bindings/v8/NPV8Object.cpp: (_NPN_GetProperty): If the result is empty, don't try to convert it to an NPVariant and return false.
- 10:59 AM Changeset in webkit [55416] by
-
- 2 edits in trunk/WebCore
[V8] DOMCoreException should be visible as DOMException
https://bugs.webkit.org/show_bug.cgi?id=35552
Reviewed by Nate Chapin.
Fix V8 code generator to use the correct visible name.
- bindings/scripts/CodeGeneratorV8.pm:
- 10:34 AM Changeset in webkit [55415] by
-
- 2 edits in trunk/WebKitTools
2010-03-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Alexey Proskuryakov.
Test plugin still has issues with releasing objects, and variants
https://bugs.webkit.org/show_bug.cgi?id=35587
Fix the conditions for releasing the variants after calling
invoke, and avoid having a number of objects leak.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testDocumentOpen): (testWindowOpen):
- 10:33 AM Changeset in webkit [55414] by
-
- 9 edits2 adds in trunk
REGRESSION(r51097) - Unable to log in to statefarm.com
<rdar://problem/7672667> and https://bugs.webkit.org/show_bug.cgi?id=35556
Reviewed by Sam Weinig.
WebCore:
Test: fast/loader/for-window-event-onload-scripts.html
Match Gecko's rules for executing "for/event" scripts:
-If there's only a 'for' attribute, execute it.
-If there's only an 'event' attribute, execute it.
-If there's a 'for=window' and 'event=onload', execute it.
-If there's a 'for=window' and 'event=onload()', execute it.
-If there's any other combination of both 'for' and 'event', don't execute it.
- dom/ScriptElement.cpp:
(WebCore::ScriptElementData::shouldExecuteAsJavaScript):
- dom/ScriptElement.h:
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::eventAttributeValue):
- html/HTMLScriptElement.h:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::eventAttributeValue):
- svg/SVGScriptElement.h:
Add the event attribute name:
- html/HTMLAttributeNames.in:
LayoutTests:
- fast/loader/for-window-event-onload-scripts-expected.txt: Added.
- fast/loader/for-window-event-onload-scripts.html: Added.
- 10:19 AM Changeset in webkit [55413] by
-
- 3 edits in trunk/WebKit/chromium
2010-03-02 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Implement WebNode::equals and add inline operators for ==
and !=.
- public/WebNode.h: (WebKit::operator==): (WebKit::operator!=):
- src/WebNode.cpp: (WebKit::WebNode::equals):
- 9:52 AM Changeset in webkit [55412] by
-
- 2 edits1 add in trunk/WebCore
2010-03-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35555
QuickTime plugin content can spill outside the <object> tag
Set -masksToBounds on the layer that is handed to us by plug-ins, to ensure that sublayers
of that layer don't spill outside the <object> contents rect.
Manual test because it relies on QuickTime, and pixel results depend on movie loading timing.
- manual-tests/plugins/object-clipping.html: Added.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setupContentsLayer):
- 9:25 AM Changeset in webkit [55411] by
-
- 4 edits in trunk/WebKitTools
Refactored the StyleChecker class's file-processing method
_process_file(). This will make it easier to add new
file-processing capabilities to check-webkit-style.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=35490
- Scripts/webkitpy/style/checker.py:
- Added a _read_lines() method to the StyleChecker class that extracts the lines from a file.
- Replaced part of _process_file() with a call to the new _read_lines() method.
- Replaced another part of _process_file() with a call to the new CarriageReturnProcessor.process() method.
- Scripts/webkitpy/style/processors/common.py:
- Replaced the check_no_carriage_return() function with a new CarriageReturnProcessor class.
- Scripts/webkitpy/style/processors/common_unittest.py:
- Renamed the CarriageReturnTest class to CarriageReturnProcessorTest and updated it as necessary.
- 9:25 AM Changeset in webkit [55410] by
-
- 3 edits in trunk/LayoutTests
Fixing layout test problems. No review.
AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514
AXTable tests crash on Leopard/Tiger because tables don't exist. This test needs to be skipped
on those playtforms.
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- 9:11 AM QtWebKit edited by
- (diff)
- 8:48 AM Changeset in webkit [55409] by
-
- 5 edits2 adds in trunk/WebKitTools
2010-03-02 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Started using the logging module in check-webkit-style.
This provides more options for debugging and a more flexible,
uniform way to report messages to the end-user.
Also included classes in a central location to facilitate
the unit testing of logging code (setUp and tearDown of unit
test logging configurations, etc).
- Scripts/check-webkit-style:
- Added a call to configure_logging() in the beginning of main().
- Replaced two calls to sys.stderr.write() with appropriate logging calls.
- Scripts/webkitpy/init/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- Scripts/webkitpy/init/logtesting.py: Added.
- Added a UnitTestLogStream class to capture log output during unit tests.
- Added a UnitTestLog class that provides convenience methods for unit-testing logging code.
- Scripts/webkitpy/style/checker.py:
- Added a configure_logging() method.
- Added a _LevelLoggingFilter class to filter out log messages above a certain logging level.
- Removed the _stderr_write() method from the StyleChecker class and replaced its use with appropriate logging calls.
- Scripts/webkitpy/style/checker_unittest.py:
- Added a ConfigureLoggingTest class to unit test the configure_logging() method.
- Updated the StyleCheckerCheckFileTest class as necessary.
- Scripts/webkitpy/style_references.py:
- Added references to logtesting.UnitTestLog and logtesting.UnitTestLogStream.
- 8:22 AM Changeset in webkit [55408] by
-
- 10 edits in trunk
Expose SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
Fixes <http://webkit.org/b/35580> <rdar://problem/7706407>
Reviewed by Tim Hatcher.
WebCore:
Export SecurityOrigin::registerURLSchemeAsSecure
- WebCore.base.exp: Added symbol, sorted file.
WebKit/mac:
Add -[WebView _registerURLSchemeAsSecure:]
- WebView/WebView.mm:
(+[WebView _registerURLSchemeAsSecure:]):
- WebView/WebViewPrivate.h:
Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
WebKit/win:
Add IWebViewPrivate::registerURLSchemeAsSecure
- Interfaces/WebKit.idl: Touched to force a build.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::registerURLSchemeAsSecure):
- WebView.h:
Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
- 8:15 AM QtWebKit edited by
- (diff)
- 8:14 AM QtWebKit edited by
- (diff)
- 8:10 AM QtWebKitContrib edited by
- (diff)
- 8:09 AM QtWebKitContrib edited by
- (diff)
- 6:52 AM QtWebKitContrib edited by
- (diff)
- 6:50 AM QtWebKitContrib edited by
- (diff)
- 6:44 AM QtWebKitContrib edited by
- (diff)
- 6:37 AM Changeset in webkit [55407] by
-
- 4 edits5 adds in trunk/WebCore
2010-03-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: render breakpoints as border images instead of canvas.
- inspector/front-end/Images/breakpointBorder.png: Added.
- inspector/front-end/Images/breakpointConditionalBorder.png: Added.
- inspector/front-end/Images/breakpointConditionalCounterBorder.png: Added.
- inspector/front-end/Images/breakpointCounterBorder.png: Added.
- inspector/front-end/Images/programCounterBorder.png: Added.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._updateExecutionLine): (WebInspector.SourceFrame.prototype._addBreakpointToSource): (WebInspector.SourceFrame.prototype.resize):
- inspector/front-end/TextViewer.js: (WebInspector.TextChunk):
- inspector/front-end/textViewer.css:
- 6:09 AM CommitterTips edited by
- Added section about unreviewed commits. (diff)
- 6:06 AM CommitterTips edited by
- Added section about rolling out. (diff)
- 2:16 AM Changeset in webkit [55406] by
-
- 2 edits in trunk/WebCore
[Qt] Special case Font::floatWidthForComplexText for single space
https://bugs.webkit.org/show_bug.cgi?id=33876
For a single space we can go through the QFontMetric::width routine
instead of converting the WebCore::String to a QString and then
going through the QTextLine.
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForComplexText):
- 1:59 AM Changeset in webkit [55405] by
-
- 4 edits in trunk
[Gtk] Support private browsing mode in plugins.
https://bugs.webkit.org/show_bug.cgi?id=35500
Integrate the PluginViewQt.cpp changes from
r55358 into Gtk+ and unskip the test.
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::getValue):
- platform/gtk/Skipped:
- 1:12 AM Changeset in webkit [55404] by
-
- 3 edits in trunk/WebCore
2010-03-02 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Update Qt bridge to new named getter signature
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
- bridge/qt/qt_runtime.h:
- 1:01 AM PythonGuidelines created by
- Created Python page.
- 12:32 AM Changeset in webkit [55403] by
-
- 2 edits in trunk/JavaScriptCore
2010-03-02 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Export function on windows.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 12:31 AM WikiStart edited by
- Added link to Python Guidelines page. (diff)
- 12:30 AM Changeset in webkit [55402] by
-
- 2 edits8 moves1 add in trunk/WebCore
2010-03-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Move gstreamer-related source files to platform/graphics/gstreamer
https://bugs.webkit.org/show_bug.cgi?id=35518
Moved GStreamer-related files to platform/graphics/gstreamer so
other ports could benefit from this media player implementation.
- GNUmakefile.am:
- platform/graphics/gstreamer/DataSourceGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/DataSourceGStreamer.cpp. (_do_init): (webkit_data_src_base_init): (webkit_data_src_class_init): (webkit_data_src_reset): (webkit_data_src_init): (webkit_data_src_finalize): (webkit_data_src_change_state): (webkit_data_src_uri_get_type): (webkit_data_src_uri_get_protocols): (webkit_data_src_uri_get_uri): (webkit_data_src_uri_set_uri): (webkit_data_src_uri_handler_init):
- platform/graphics/gstreamer/DataSourceGStreamer.h: Renamed from WebCore/platform/graphics/gtk/DataSourceGStreamer.h.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp. (WebCore::greatestCommonDivisor): (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::notifyMuteIdleCallback): (WebCore::bufferingTimeoutCallback): (WebCore::playbackPosition): (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::create): (WebCore::MediaPlayerPrivate::registerMediaEngine): (WebCore::doGstInit): (WebCore::MediaPlayerPrivate::isAvailable): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::changePipelineState): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivate::cancelSeek): (WebCore::MediaPlayerPrivate::endPointTimerFired): (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::volumeChangedCallback): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::networkState): (WebCore::MediaPlayerPrivate::readyState): (WebCore::MediaPlayerPrivate::buffered): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::queryBufferingStats): (WebCore::MediaPlayerPrivate::maxTimeSeekable): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytes): (WebCore::MediaPlayerPrivate::cancelLoad): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::mediaLocationChanged): (WebCore::MediaPlayerPrivate::loadNextLocation): (WebCore::MediaPlayerPrivate::loadStateChanged): (WebCore::MediaPlayerPrivate::sizeChanged): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged): (WebCore::MediaPlayerPrivate::supportsMuting): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::muteChangedCallback): (WebCore::MediaPlayerPrivate::muteChanged): (WebCore::MediaPlayerPrivate::loadingFailed): (WebCore::MediaPlayerPrivate::setSize): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::repaint): (WebCore::MediaPlayerPrivate::paint): (WebCore::mimeTypeCache): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivate::supportsFullscreen): (WebCore::MediaPlayerPrivate::setAutobuffer): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Renamed from WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.h. (WebCore::MediaPlayerPrivate::pipelineReset):
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/VideoSinkGStreamer.cpp. (webkit_video_sink_base_init): (webkit_video_sink_init): (webkit_video_sink_timeout_func): (webkit_video_sink_render): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_unlock_stop): (webkit_video_sink_stop): (webkit_video_sink_start): (marshal_VOIDMINIOBJECT): (webkit_video_sink_class_init): (webkit_video_sink_new):
- platform/graphics/gstreamer/VideoSinkGStreamer.h: Renamed from WebCore/platform/graphics/gtk/VideoSinkGStreamer.h.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp. (doInit): (webkit_web_src_base_init): (webkit_web_src_class_init): (webkit_web_src_init): (webKitWebSrcFinalize): (webKitWebSrcSetProperty): (webKitWebSrcGetProperty): (webKitWebSrcStop): (webKitWebSrcStart): (webKitWebSrcChangeState): (webKitWebSrcUriGetType): (webKitWebSrcGetProtocols): (webKitWebSrcGetUri): (webKitWebSrcSetUri): (webKitWebSrcUriHandlerInit): (webKitWebSrcNeedDataMainCb): (webKitWebSrcNeedDataCb): (webKitWebSrcEnoughDataMainCb): (webKitWebSrcEnoughDataCb): (webKitWebSrcSeekMainCb): (webKitWebSrcSeekDataCb): (webKitWebSrcSetFrame): (StreamingClient::StreamingClient): (StreamingClient::~StreamingClient): (StreamingClient::willSendRequest): (StreamingClient::didReceiveResponse): (StreamingClient::didReceiveData): (StreamingClient::didFinishLoading): (StreamingClient::didFail): (StreamingClient::wasBlocked): (StreamingClient::cannotShowURL):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.h: Renamed from WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.h.
- 12:20 AM Changeset in webkit [55401] by
-
- 45 edits in trunk
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563
This removes the PropertySlot argument from getter functions, and makes them directly
pass the slot base. This makes the semantics for the functions match that of the
indexing getters.
On the down side, this means that we can no longer simply use a proxy function for
JS getters, so we now add another marker value to indicate that a getter is present
and branch accordingly.
Against all rationality sunspider reports this as a perf win, but i suspect it's just noise.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h: (JSC::::staticValueGetter): (JSC::::staticFunctionGetter): (JSC::::callbackGetter):
- JavaScriptCore.exp:
- runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h:
- runtime/JSFunction.cpp: (JSC::JSFunction::argumentsGetter): (JSC::JSFunction::callerGetter): (JSC::JSFunction::lengthGetter):
- runtime/JSFunction.h:
- runtime/NumberConstructor.cpp: (JSC::numberConstructorNaNValue): (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue):
- runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
- runtime/PropertySlot.h: (JSC::PropertySlot::getValue): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot):
- runtime/RegExpConstructor.cpp: (JSC::regExpConstructorDollar1): (JSC::regExpConstructorDollar2): (JSC::regExpConstructorDollar3): (JSC::regExpConstructorDollar4): (JSC::regExpConstructorDollar5): (JSC::regExpConstructorDollar6): (JSC::regExpConstructorDollar7): (JSC::regExpConstructorDollar8): (JSC::regExpConstructorDollar9): (JSC::regExpConstructorInput): (JSC::regExpConstructorMultiline): (JSC::regExpConstructorLastMatch): (JSC::regExpConstructorLastParen): (JSC::regExpConstructorLeftContext): (JSC::regExpConstructorRightContext):
- runtime/RegExpObject.cpp: (JSC::regExpObjectGlobal): (JSC::regExpObjectIgnoreCase): (JSC::regExpObjectMultiline): (JSC::regExpObjectSource): (JSC::regExpObjectLastIndex):
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563
Fix method signature and update code as appropriate
- UserObjectImp.cpp: (UserObjectImp::userObjectGetter):
- UserObjectImp.h:
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563
Fix up WebCore to use the new named getter function signature, update the
codegenerator to the new calling convention, and fix the custom bindings.
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter):
- bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter): (WebCore::childFrameGetter): (WebCore::namedItemGetter):
- bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::nameGetter):
- bindings/js/JSHTMLAllCollectionCustom.cpp: (WebCore::JSHTMLAllCollection::nameGetter):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::JSHTMLCollection::nameGetter):
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter):
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
- bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
- bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
- bindings/js/JSMimeTypeArrayCustom.cpp: (WebCore::JSMimeTypeArray::nameGetter):
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::nameGetter):
- bindings/js/JSNodeListCustom.cpp: (WebCore::JSNodeList::nameGetter):
- bindings/js/JSPluginArrayCustom.cpp: (WebCore::JSPluginArray::nameGetter):
- bindings/js/JSPluginCustom.cpp: (WebCore::JSPlugin::nameGetter):
- bindings/js/JSPluginElementFunctions.cpp: (WebCore::runtimeObjectPropertyGetter):
- bindings/js/JSPluginElementFunctions.h:
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::nameGetter):
- bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetList::nameGetter):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/runtime_array.cpp: (JSC::RuntimeArray::lengthGetter):
- bridge/runtime_array.h:
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::lengthGetter):
- bridge/runtime_method.h:
- bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::fallbackObjectGetter): (JSC::Bindings::RuntimeObject::fieldGetter): (JSC::Bindings::RuntimeObject::methodGetter):
- bridge/runtime_object.h:
- 12:10 AM Changeset in webkit [55400] by
-
- 2 edits in trunk/WebKit/qt
Symbian build fix.
[Qt] Updated the def file with one new export, to fix
QtLauncher linkage.
- symbian/eabi/QtWebKitu.def:
Mar 1, 2010:
- 8:14 PM Changeset in webkit [55399] by
-
- 4 edits in trunk/WebKit/win
Remove Windows line endings from some files.
Rubber-stamped by Alice Liu.
- Interfaces/IWebEmbeddedView.idl:
- WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::create):
(EmbeddedWidget::~EmbeddedWidget):
(EmbeddedWidget::createWindow):
(EmbeddedWidget::invalidateRect):
(EmbeddedWidget::setFrameRect):
(EmbeddedWidget::frameRectsChanged):
(EmbeddedWidget::setFocus):
(EmbeddedWidget::show):
(EmbeddedWidget::hide):
(EmbeddedWidget::windowClipRect):
(EmbeddedWidget::setParent):
(EmbeddedWidget::attachToWindow):
(EmbeddedWidget::detachFromWindow):
(EmbeddedWidget::didReceiveResponse):
(EmbeddedWidget::didReceiveData):
(EmbeddedWidget::didFinishLoading):
(EmbeddedWidget::didFail):
- WebCoreSupport/EmbeddedWidget.h:
(EmbeddedWidget::EmbeddedWidget):
- 8:14 PM Changeset in webkit [55398] by
-
- 2 edits in trunk/WebKit/win
Some WebKit DOMNode API is unimplemented.
https://bugs.webkit.org/show_bug.cgi?id=35554
Reviewed by Alice Liu.
- DOMCoreClasses.cpp:
(DOMNode::nextSibling):
Create a DOMNode to wrap m_node's next sibling, and assign it to the
out param 'result'.
(DOMNode::insertBefore):
Query for the DOMNode for newChild, and return early if we fail. Query
refChild for DOMNode. Call insertBefore(), passing the newChild's
WebCore node and refChild's WebCore node (if refChild is non-null). If
we successfully insert the child, fill the result out param with
newChild, ref it, and return S_OK. Otherwise, return E_FAIL.
(DOMNode::removeChild):
Query oldChild for DOMNode. If we fail, return E_FAIL. Call
removeChild(), passing the node's WebCore node. If this fails, return
E_FAIL. Otherwise, fill the result out param with oldChild, ref it, and
return S_OK.
- 8:08 PM Changeset in webkit [55397] by
-
- 7 edits in trunk
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
PropertySlot::getValue(ExecState, unsigned) unnecessarily converts index to an Identifier
https://bugs.webkit.org/show_bug.cgi?id=35561
Fix this by defining a separate property getter function for index getters. This allows
us to pass an unsigned number without the conversion to an Identifier. We then update
setCustomIndex to take this new getter type.
- runtime/PropertySlot.h: (JSC::PropertySlot::getValue): (JSC::PropertySlot::setCustom): (JSC::PropertySlot::setCustomIndex):
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
PropertySlot::getValue(ExecState, unsigned) unnecessarily converts index to an Identifier
https://bugs.webkit.org/show_bug.cgi?id=35561
Update bindings generation and the few manual indexing getters we have to use
the new PropertySlot API.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::indexGetter):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/runtime_array.cpp: (JSC::RuntimeArray::indexGetter):
- bridge/runtime_array.h:
- 6:24 PM Changeset in webkit [55396] by
-
- 1 edit3 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26520
Accessing a DOM node from a parent window in a child iframe moves the prototype to the child
iframe and resets it in the parent window
Adding a test for a bug that no longer occurs in ToT.
- fast/dom/cross-frame-node-prototype-expected.txt: Added.
- fast/dom/cross-frame-node-prototype.html: Added.
- fast/dom/resources/cross-frame-node-prototype-iframe.html: Added.
- 5:58 PM Changeset in webkit [55395] by
-
- 2 edits in trunk/WebKitTools
Fixing broken DRT on Leopard/Tiger. Second try.
AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- 5:50 PM Changeset in webkit [55394] by
-
- 2 edits in trunk/WebKitTools
Fixing broken DRT on Leopard/Tiger.
AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- 5:40 PM Changeset in webkit [55393] by
-
- 3 edits in trunk/LayoutTests
2010-03-01 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rebaseline the two editing tests we stopped skipping - we failed
to take the new caret position result into account while
unskipping these.
- platform/gtk/editing/selection/5109817-expected.txt:
- platform/gtk/editing/selection/5354455-2-expected.txt:
- 5:35 PM Changeset in webkit [55392] by
-
- 4 edits in trunk
WebKitTools
2010-03-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425
Check invoke's return code before releasing the variant, since
there's a chance it won't be properly initialized, leading to
memory corruption, in some cases.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testCallback): (testEnumerate): (testDocumentOpen): (testWindowOpen): (handleCallback):
LayoutTests
2010-03-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425
Unskip the tests that failed as a consequence of the memory
corruption.
- platform/gtk/Skipped:
- 5:29 PM Changeset in webkit [55391] by
-
- 2 edits in trunk/WebKitTools
2010-03-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by nobody. Build bustage :(
Fix stupid typo that I committed even after David Levin pointed
it out to me :(
- Scripts/webkitpy/layout_tests/port/mac.py:
- 5:19 PM Changeset in webkit [55390] by
-
- 13 edits2 adds in trunk
AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514
Reviewed by Darin Adler.
WebCore:
When a table's DOM is changed and an AX Table is not asked first for its children,
it would return wrong information. A table needs to make sure children are up to date in
all methods that can be called from the outside.
Test: platform/mac/accessibility/stale-table-rows.html
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clearChildren):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clearChildren):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::children):
- accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::needsToUpdateChildren):
(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::clearChildren):
(WebCore::AccessibilityTable::columns):
(WebCore::AccessibilityTable::rows):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::columnCount):
(WebCore::AccessibilityTable::rowCount):
(WebCore::AccessibilityTable::cellForColumnAndRow):
WebKitTools:
Add rowCount, columnCount for tables.
- DumpRenderTree/AccessibilityUIElement.cpp:
(rowCountCallback):
(columnCountCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
LayoutTests:
- platform/mac/accessibility/stale-table-rows-expected.txt: Added.
- platform/mac/accessibility/stale-table-rows.html: Added.
- 5:12 PM Changeset in webkit [55389] by
-
- 4 edits in trunk
2010-03-01 José Millán Soto <jmillan@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Right click does not activate text entry
https://bugs.webkit.org/show_bug.cgi?id=29177
Stop skipping some tests which where failing because of right click
not being correct handled.
- platform/gtk/Skipped:
2010-03-01 José Millán Soto <jmillan@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Right click does not activate text entry
https://bugs.webkit.org/show_bug.cgi?id=29177
Makes the frame handle the mouse click event before sending the
context menu event.
- webkit/webkitwebview.cpp: (PopupMenuPositionFunc): Function created to make the popup menu appear in the correct position, especially when invoked from the keyboard. (webkit_web_view_forward_context_menu_event): Mouse click event is sent to frame before creating context menu, PopupMenuPositionFunc used to determine the position where the menu should appear. (webkit_web_view_popup_menu_handler): Improved focused node position detection. Event button set to right button.
- 5:07 PM Changeset in webkit [55388] by
-
- 3 edits in trunk/WebKitTools
2010-03-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Work around a bug in Python's subprocess.Popen() that keeps us from
cleaning up DumpRenderTree / test_shell properly when we finish the
tests in new-run-webkit-tests.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- 4:56 PM Changeset in webkit [55387] by
-
- 26 edits1 add in trunk
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Convert the zoom mode (page vs. text-only) into a proper enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- GNUmakefile.am:
- WebCore.base.exp: Substituted symbols ZN7WebCore5Frame13setZoomFactorEfNS_8ZoomModeE and ZN7WebCore8Settings11setZoomModeENS_8ZoomModeE for ZN7WebCore5Frame13setZoomFactorEfb and ZN7WebCore8Settings16setZoomsTextOnlyEb, respectively.
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/Frame.cpp: (WebCore::Frame::zoomMode): (WebCore::Frame::shouldApplyTextZoom): (WebCore::Frame::shouldApplyPageZoom): (WebCore::Frame::setZoomFactor):
- page/Frame.h:
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setZoomMode):
- page/Settings.h: (WebCore::Settings::zoomMode):
- page/ZoomMode.h: Added. (WebCore::):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setZoomLevel):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_apply_zoom_level):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): (-[WebView _setZoomMultiplier:isTextOnly:]): (-[WebView _realZoomMultiplierIsTextOnly]):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- Api/qwebframe.cpp: (QWebFrame::setTextSizeMultiplier): (QWebFrame::setZoomFactor):
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- WebFrame.cpp: (WebFrame::setTextSizeMultiplier):
- WebView.cpp: (WebView::setZoomMultiplier): (WebView::zoomMultiplier): (WebView::canMakeTextLarger): (WebView::makeTextLarger): (WebView::canMakeTextSmaller): (WebView::makeTextSmaller): (WebView::notifyPreferencesChanged):
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
- WebFrame.cpp: (wxWebFrame::IncreaseTextSize): (wxWebFrame::DecreaseTextSize): (wxWebFrame::ResetTextSize):
- 4:22 PM Changeset in webkit [55386] by
-
- 9 edits1 copy5 adds in trunk
2010-03-01 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added test for basic msubsup support.
- mathml/presentation/subsup.xhtml: Added.
- platform/mac/mathml/presentation/subsup-expected.checksum: Added.
- platform/mac/mathml/presentation/subsup-expected.png: Added.
- platform/mac/mathml/presentation/subsup-expected.txt: Added.
2010-03-01 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added support for the msubsup element that also handles the msup and msub elements.
Test: mathml/presentation/subsup.xhtml
- WebCore.xcodeproj/project.pbxproj:
- mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/RenderMathMLSubSup.cpp: Added. (WebCore::RenderMathMLSubSup::RenderMathMLSubSup): (WebCore::RenderMathMLSubSup::addChild): (WebCore::RenderMathMLSubSup::stretchToHeight): (WebCore::RenderMathMLSubSup::nonOperatorHeight): (WebCore::RenderMathMLSubSup::layout): (WebCore::RenderMathMLSubSup::baselinePosition):
- mathml/RenderMathMLSubSup.h: Added. (WebCore::RenderMathMLSubSup::hasBase): (WebCore::RenderMathMLSubSup::):
- 4:18 PM Changeset in webkit [55385] by
-
- 4 edits in trunk/WebKit/win
<rdar://problem/7703368> IWebUIDelegatePrivate::embeddedViewWithArguments
is passed wrong arguments
Reviewed by Adam Roben.
- Interfaces/IWebUIDelegatePrivate.idl:
Update copyright strings. Added a new key for the plug-in source URL.
- Interfaces/WebKit.idl:
Update copyright strings.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
Pass the URL of the plug-in as the source URL. Pass the document's
base URI for the base URL.
- 4:05 PM Changeset in webkit [55384] by
-
- 2 edits in trunk/WebKitTools
2010-03-01 Arno Renevier <arno@renevier.net>
Reviewed by Xan Lopez.
webkit-build could pass unknown arguments to autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=35454
- Scripts/build-webkit:
- 3:49 PM Changeset in webkit [55383] by
-
- 2 edits in trunk/WebCore
2010-03-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: use dejavu sans mono 11px on linux.
- inspector/front-end/inspector.css:
- 3:17 PM Changeset in webkit [55382] by
-
- 2 edits in trunk/WebKitTools
2010-03-01 Dirk Pranke <dpranke@chromium.org>
Rubber-stamped by Dimitri Glazkov.
Fix breakage from r55372.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 2:51 PM Changeset in webkit [55381] by
-
- 11 edits in trunk
2010-03-01 Thatcher Ulrich <tulrich@google.com>
Reviewed by Darin Fisher.
Fix chromium iframe shims. Add another test case to the
iframes-shims test. After r53637, the plugin widget doesn't get
moved every paint. This used to hide the bug that if an iframe
gets added, the plugin's cutout rectangles don't get updated until
a layout happens.
https://bugs.webkit.org/show_bug.cgi?id=35184
- plugins/iframe-shims.html: test case that adds an iframe shim dynamically
2010-03-01 Thatcher Ulrich <tulrich@google.com>
Reviewed by Darin Fisher.
Fix chromium iframe shims. Add another test case to the
iframes-shims test. After r53637, the plugin widget doesn't get
moved every paint. This used to hide the bug that if an iframe
gets added, the plugin's cutout rectangles don't get updated until
a layout happens.
https://bugs.webkit.org/show_bug.cgi?id=35184
- platform/Widget.h: (WebCore::Widget::widgetPositionsUpdated): new virtual method
widgetPositionsUpdated() to notify widgets when other widgets on
the page have been repositioned.
- rendering/RenderView.cpp: (WebCore::RenderView::updateWidgetPositions): call widgetPositionsUpdated() on the widgets
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::widgetPositionsUpdated): call widgetPositionsUpdated() on the widget
- rendering/RenderWidget.h:
2010-03-01 Thatcher Ulrich <tulrich@google.com>
Reviewed by Darin Fisher.
Fix chromium iframe shims. Add another test case to the
iframes-shims test. After r53637, the plugin widget doesn't get
moved every paint. This used to hide the bug that if an iframe
gets added, the plugin's cutout rectangles don't get updated until
a layout happens.
https://bugs.webkit.org/show_bug.cgi?id=35184
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::widgetPositionsUpdated): do reportGeometry() to ensure that
the plugin is aware of the positions of cutouts on the page (for iframe shim behavior).
- src/WebPluginContainerImpl.h:
- 2:27 PM Changeset in webkit [55380] by
-
- 3 edits in trunk/WebKitTools
2010-03-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
EWS can hang for five hours when compile output is too big
https://bugs.webkit.org/show_bug.cgi?id=35545
- Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of 5MB. AppEngine seems to not like 5MB uploads. I'm not sure what the limit is. Let's try 1MB for a while and see how it goes.
- Scripts/webkitpy/networktransaction.py: Tune the default parameters to our exponential backoff. I'm not sure why I picked five hours as the retry limit. That seems way too large.
- 2:14 PM Changeset in webkit [55379] by
-
- 5 edits in trunk
Bug 35537 - put_by_id does will incorrectly cache writes where a specific value exists,
where at the point of caching the same value is being written.
Reviewed by Oliver Hunt.
When performing a put_by_id that is replacing a property already present on the object,
there are three interesting cases regarding the state of the specific value:
(1) No specific value set - nothing to do, leave the structure in it's current state,
can cache.
(2) A specific value was set, the new put is not of a specified value (i.e. function),
or is of a different specific value - in these cases we need to perform a despecifying
transition to clear the specific value in the structure, but having done so this is a
normal property so as such we can again cache normally.
(3) A specific value was set, and we are overwriting with the same value - in these cases
leave the structure unchanged, but since a specific value is set we cannot cache this
put (we would need the JIT to dynamically check the value being written matched).
Unfortunately, the current behaviour does not match this. the checks for a specific value
being present & the value matching are combined in such a way that in case (2), above we
will unnecessarily prevent the transition being cached, but in case (3) we will incorrectly
fail to prevent caching.
The bug exposes itself if multiple puts of the same specific value are performed to a
property, and erroneously the put is allowed to be cached by the JIT. Method checks may be
generated caching calls of this structure. Subsequent puts performed from JIT code may
write different values without triggering a despecify transition, and as such cached method
checks will continue to pass, despite the value having changed.
- runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
LayoutTests:
Add test case.
- fast/js/method-check-expected.txt:
- fast/js/script-tests/method-check.js:
(addOne):
(addOneHundred):
(totalizer.makeCall):
- 2:07 PM Changeset in webkit [55378] by
-
- 2 edits in trunk/WebKit/gtk
2010-03-01 Kalle Vahlman <zuh@iki.fi>
Reviewed by Gustavo Noronha Silva.
Queue a resize when either of the content dimensions change
https://bugs.webkit.org/show_bug.cgi?id=35489
The check for size changes only queued a resize if both of the content
dimensions change, leaving the widget size out-of-sync if eg. only the
width changes.
- WebCoreSupport/ChromeClientGtk.cpp:
- 1:51 PM Changeset in webkit [55377] by
-
- 2 edits in trunk/WebCore
2010-03-01 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Holger Freyther.
Dist some mathml related files
- GNUmakefile.am:
- 1:20 PM Changeset in webkit [55376] by
-
- 43 edits2 adds in trunk
2010-03-01 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Integer overflow in WebGL arrays
https://bugs.webkit.org/show_bug.cgi?id=35241
Test: fast/canvas/webgl/webgl-array-invalid-ranges.html
- bindings/js/JSWebGLArrayBufferConstructor.cpp: (WebCore::constructCanvasArrayBuffer):
- bindings/js/JSWebGLArrayBufferConstructor.h: (WebCore::construct):
- bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayFromArray):
- bindings/js/JSWebGLByteArrayConstructor.cpp: (WebCore::constructCanvasByteArray):
- bindings/js/JSWebGLFloatArrayConstructor.cpp: (WebCore::constructCanvasFloatArray):
- bindings/js/JSWebGLIntArrayConstructor.cpp: (WebCore::constructCanvasIntArray):
- bindings/js/JSWebGLShortArrayConstructor.cpp: (WebCore::constructCanvasShortArray):
- bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp: (WebCore::constructCanvasUnsignedByteArray):
- bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp: (WebCore::constructCanvasUnsignedIntArray):
- bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp: (WebCore::constructCanvasUnsignedShortArray):
- bindings/v8/V8Binding.cpp: (WebCore::toUInt32):
- bindings/v8/V8Binding.h: (WebCore::toUInt32):
- bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::V8WebGLArrayBuffer::constructorCallback):
- bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::constructWebGLArray): (WebCore::getWebGLArrayElement): (WebCore::setWebGLArrayFromArray): (WebCore::setWebGLArray):
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::constructorCallback):
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::constructorCallback):
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::constructorCallback):
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::constructorCallback):
- html/canvas/WebGLArray.cpp: (WebCore::WebGLArray::setImpl):
- html/canvas/WebGLArray.h: (WebCore::WebGLArray::verifySubRange): (WebCore::WebGLArray::clampOffsetAndNumElements):
- html/canvas/WebGLArrayBuffer.cpp: (WebCore::WebGLArrayBuffer::create): (WebCore::WebGLArrayBuffer::WebGLArrayBuffer): (WebCore::WebGLArrayBuffer::tryAllocate):
- html/canvas/WebGLArrayBuffer.h:
- html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::create): (WebCore::WebGLByteArray::WebGLByteArray): (WebCore::WebGLByteArray::slice):
- html/canvas/WebGLByteArray.h:
- html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::create): (WebCore::WebGLFloatArray::WebGLFloatArray): (WebCore::WebGLFloatArray::slice):
- html/canvas/WebGLFloatArray.h:
- html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::create): (WebCore::WebGLIntArray::WebGLIntArray): (WebCore::WebGLIntArray::slice):
- html/canvas/WebGLIntArray.h:
- html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::create): (WebCore::WebGLShortArray::WebGLShortArray): (WebCore::WebGLShortArray::slice):
- html/canvas/WebGLShortArray.h:
- html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::create): (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray): (WebCore::WebGLUnsignedByteArray::slice):
- html/canvas/WebGLUnsignedByteArray.h:
- html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::create): (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray): (WebCore::WebGLUnsignedIntArray::slice):
- html/canvas/WebGLUnsignedIntArray.h:
- html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::create): (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray): (WebCore::WebGLUnsignedShortArray::slice):
- html/canvas/WebGLUnsignedShortArray.h:
2010-03-01 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Integer overflow in WebGL arrays
https://bugs.webkit.org/show_bug.cgi?id=35241
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
- fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt: Added.
- fast/canvas/webgl/webgl-array-invalid-ranges.html: Added.
- 1:10 PM Changeset in webkit [55375] by
-
- 14 edits2 adds in trunk
REGRESSION: Telling a WebView to go to its current WebHistoryItem is broken.
<rdar://problem/7699371> and https://bugs.webkit.org/show_bug.cgi?id=35532
Reviewed by Sam Weinig.
WebCore:
Test: fast/loader/api-test-go-to-current-back-forward-item.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem): If the current item is the same as the target item, don't
consider this to be a same document navigation.
- page/Page.cpp:
(WebCore::Page::goToItem): Hard code the "going to the same item as the current item" relationship
as a precondition for stopping all loaders, as that will be a new document load.
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp:
(apiTestGoToCurrentBackForwardItemCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):
Stubs for now:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::apiTestGoToCurrentBackForwardItem):
LayoutTests:
- fast/loader/api-test-go-to-current-back-forward-item-expected.txt: Added.
- fast/loader/api-test-go-to-current-back-forward-item.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:04 PM Changeset in webkit [55374] by
-
- 2 edits in trunk/WebCore
2010-03-01 Robert Hogan <robert@webkit.org>
Reviewed by nobody, build fix.
Fix --minimal build. Add ENABLE(DATABASE) as compile time condition
for building file GeolocationPositionCache.cpp.
- page/GeolocationPositionCache.cpp:
- 12:41 PM Changeset in webkit [55373] by
-
- 12 edits in trunk/WebKitTools
2010-03-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
General cleanup of error handling in new-run-webkit-tests.
Add Port.check_build() call that is separate from Port.check_sys_deps()
(and add a --nocheck-build flag to skip). This breaks a circular
dependency where you would start the layout test helper before
checking sys deps, but checking sys deps was the thing that told
you if your binaries where there.
Also, made Port.check_sys_deps(), start_helper() and stop_helper()
optional by providing default implementations in the base class
rather than requiring ports to implement the routines regardless
of whether or not they were needed.
Lastly, tweak a bunch of log messages to be cleaner, including
changing messages in thirdparty/autoinstall.py to be silent at
the default log level.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/passing.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/thirdparty/autoinstall.py
- 11:36 AM Changeset in webkit [55372] by
-
- 5 edits in trunk/WebKitTools
2010-03-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
new-chromium-webkit-tests --platform=mac-leopard diffs are backwards
https://bugs.webkit.org/show_bug.cgi?id=35265
Some parts of the code passed arguments as
"actual, expected" and some passed as "expected, actual".
As you might imagine, this lead to great confusion and wrongness.
Standardize on "expected, actual" as that's the order which is
passed to the underlying diff tool.
Based on a patch by Eric Siedel <eric@webkit.org>.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py
- 11:01 AM UsingGitWithWebKit edited by
- (diff)
- 9:41 AM Changeset in webkit [55371] by
-
- 6 edits4 adds in trunk/WebCore
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Dirk Schulze.
[OpenVG] Implement support for paths
https://bugs.webkit.org/show_bug.cgi?id=34366
Adds an implementation of the Path class -
*almost* complete, but not quite because OpenVG
does not provide access to the points in a VGPath
unless one keeps track of all the points by
themselves, which we decided not to do.
Also hooked up to PainterOpenVG and GraphicsContext.
Further introduced is SharedResourceOpenVG, which is
intended as base class for paths and other OpenVG
resources (images, fonts) that WebKit creates as
long-lived objects. We are at a slight disadvantage
here as WebKit doesn't have the concept of resources
belonging to a specific (hardware graphics) context,
which is the reason why EGLDisplayOpenVG had to
provide a current display singleton; this class is
what actually requires that functionality.
Path::addArcTo() uses code by Yong Li <yoli@rim.com>.
- platform/graphics/Path.cpp:
- platform/graphics/Path.h:
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):
- platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::PainterOpenVG): (WebCore::PainterOpenVG::~PainterOpenVG): (WebCore::PainterOpenVG::transformPath): (WebCore::PainterOpenVG::beginPath): (WebCore::PainterOpenVG::addPath): (WebCore::PainterOpenVG::currentPath): (WebCore::PainterOpenVG::drawPath):
- platform/graphics/openvg/PainterOpenVG.h:
- platform/graphics/openvg/PathOpenVG.cpp: Added. (WebCore::PlatformPathOpenVG::PlatformPathOpenVG): (WebCore::PlatformPathOpenVG::operator=): (WebCore::PlatformPathOpenVG::~PlatformPathOpenVG): (WebCore::PlatformPathOpenVG::clear): (WebCore::PlatformPathOpenVG::createPath): (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::contains): (WebCore::Path::strokeContains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::strokeBoundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::hasCurrentPoint): (WebCore::Path::debugString): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::length): (WebCore::Path::pointAtLength): (WebCore::Path::normalAngleAtLength):
- platform/graphics/openvg/PlatformPathOpenVG.h: Added. (WebCore::PlatformPathOpenVG::vgPath):
- platform/graphics/openvg/SharedResourceOpenVG.cpp: Added. (WebCore::SharedResourceOpenVG::makeSharedContextCurrent): (WebCore::SharedResourceOpenVG::makeCompatibleContextCurrent):
- platform/graphics/openvg/SharedResourceOpenVG.h: Added.
- 8:18 AM Changeset in webkit [55370] by
-
- 2 edits in trunk/WebCore
2010-03-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, bring English.lproj/locallizedStrings.js back to binary (UTF) mode.
- English.lproj/localizedStrings.js:
- 7:51 AM Changeset in webkit [55369] by
-
- 7 edits in trunk/WebCore
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Nikolas Zimmermann.
[OpenVG] Convert from TransformationMatrix to AffineTransform.
https://bugs.webkit.org/show_bug.cgi?id=35445
Dirk Schulze previously introduced AffineTransform as
replacement for most TransformationMatrix occurrences
in GraphicsContext & Co., but did not update the OpenVG
graphics backend as there's no publicly available way
to build it. This commit now takes care of that.
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::isNonRotatedAffineTransformation): (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::applyTransformation): (WebCore::PainterOpenVG::transformation): (WebCore::PainterOpenVG::concatTransformation): (WebCore::PainterOpenVG::setTransformation): (WebCore::PainterOpenVG::scale): (WebCore::PainterOpenVG::rotate): (WebCore::PainterOpenVG::translate): (WebCore::PainterOpenVG::intersectClipRect):
- platform/graphics/openvg/PainterOpenVG.h:
- platform/graphics/openvg/VGUtils.cpp: (WebCore::VGMatrix::VGMatrix): (WebCore::VGMatrix::operator AffineTransform): (WebCore::VGMatrix::operator TransformationMatrix): (WebCore::AffineTransform::operator VGMatrix):
- platform/graphics/openvg/VGUtils.h:
- platform/graphics/transforms/AffineTransform.h:
- 7:34 AM Changeset in webkit [55368] by
-
- 2 edits in trunk/WebCore
[Qt] Fix segfault when drawing NPAPI plugins on Mac
Reviewed by Simon Hausmann.
Don't try to get a contexctRef for a null-pixmap. If the pixmap
size is 0,0 the private pixmap data has not yet been initialized.
- 7:34 AM Changeset in webkit [55367] by
-
- 5 edits in trunk
Fix the Qt build on Mac OS X/Cocoa 64-bit
Add missing implementation file to resolve JSC symbols.
Use the proper event/drawing-model guards instead of global 64-bit
guard for the NPAPI plugin implementation (view and package).
- 6:34 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 6:06 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 6:00 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 5:58 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 5:48 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 5:46 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 5:42 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 5:41 AM QtWebKitTableOfFeatures20 created by
- 5:41 AM QtWebKitFeatures20 edited by
- (diff)
- 5:40 AM QtWebKitFeatures20 created by
- 5:38 AM QtWebKit edited by
- (diff)
- 4:54 AM Changeset in webkit [55366] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog entries not showing the reviewer due to the ChangeLogs
having been made manually without the (OOPS!!!) part.
Rubberstamped by Gustavo Noronha
- 2:17 AM Changeset in webkit [55365] by
-
- 2 edits in trunk/LayoutTests
2010-02-27 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: callerScriptName and callerScriptLine should be obfuscated for timeline tests.
https://bugs.webkit.org/show_bug.cgi?id=35478
- ../../LayoutTests/inspector/timeline-test.js:
- 2:12 AM Changeset in webkit [55364] by
-
- 6 edits in trunk
2010-02-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disable breakpoint upon Shift-click.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._mouseMove):
- inspector/front-end/textViewer.css: Chromium: remove DevTools part that has been upstreamed.
- src/js/DevTools.js:
- 2:07 AM Changeset in webkit [55363] by
-
- 6 edits1 add2 deletes in trunk/WebKitTools
Unreviewed.
Rolling out: http://trac.webkit.org/changeset/55348
https://bugs.webkit.org/show_bug.cgi?id=35163
Rolling out since the changes to autoinstall do not work
with Python 2.4. In particular, ZipFile.extractall() was
added in Python 2.6.
- Scripts/webkitpy/init.py:
- Scripts/webkitpy/bugzilla.py:
- Scripts/webkitpy/init/init.py: Removed.
- Scripts/webkitpy/init/autoinstall.py: Removed.
- Scripts/webkitpy/networktransaction.py:
- Scripts/webkitpy/networktransaction_unittest.py:
- Scripts/webkitpy/statusserver.py:
- Scripts/webkitpy/thirdparty/autoinstall.py: Added.
- 1:44 AM Changeset in webkit [55362] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Unreviewed.
Fixing up ChangeLog after: http://trac.webkit.org/changeset/55361
Restoring deleted ChangeLog entry, and added new ChangeLog entry
for r55361.
- 1:19 AM Changeset in webkit [55361] by
-
- 5 edits3 deletes in trunk/WebKitTools
Unreviewed. Rolling out r55350: http://trac.webkit.org/changeset/55350
https://bugs.webkit.org/show_bug.cgi?id=33639
Need to roll out because this patch (pep8) depends on the newly rewritten
autoinstall.py (r55348), which is breaking for people with Python 2.4:
https://bugs.webkit.org/show_bug.cgi?id=35163#c21
That also needs to be rolled out and will be rolled out next.
Feb 28, 2010:
- 9:14 PM Changeset in webkit [55360] by
-
- 3 edits in trunk/WebKitTools
Exempted WebKitTools/Scripts/webkitpy/thirdparty from all
style checks except for the whitespace/carriage_return check
and the pep8 tab and trailing white space checks.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=35497
- Scripts/webkitpy/style/checker.py:
- Adjusted the _PATH_RULES_SPECIFIER configuration as necessary.
- Added enough pep8 categories to _all_categories() for the unit tests to pass.
- Scripts/webkitpy/style/checker_unittest.py:
- Updated the test_path_rules_specifier() unit test.
- 12:04 PM Changeset in webkit [55359] by
-
- 2 edits in trunk/WebCore
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35496
<rdar://problem/7663444> Opening newsweek.com and youtube.com has become very slow in debug builds
- css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getIDRules): (WebCore::CSSRuleSet::getClassRules): (WebCore::CSSRuleSet::getTagRules): Removed consistency checks, as they affect performance too much in this case.
- 4:57 AM Changeset in webkit [55358] by
-
- 7 edits2 adds in trunk
[Qt] Support private browsing mode in plugins
Add support for NPNVprivateModeBool property in plugins.
See also: https://developer.mozilla.org/En/Supporting_private_browsing_in_plugins
The NPNVprivateModeBool property is supported as scriptable property privateBrowsingEnabled
in the test WebKit plugin. The Mac platform also supports a cachedPrivateBrowsingEnabled
property implemented in the test plugin. This allows the Layout test plugins/private-browsing-mode.html
to retrieve the previous value of NPNVprivateModeBool in the test plugin. Due to the platform-specific
overhead required to support this bespoke property it is not implemented as part of this patch, instead
a new test, plugins/private-browsing-mode-2.html, is added to ensure that setting and resetting privateBrowsingEnabled works as expected.
Feb 27, 2010:
- 11:09 PM Changeset in webkit [55357] by
-
- 2 edits in trunk/WebCore
2010-02-27 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector shouldn't show a white color box for "-webkit-line-break: after-white-space"
https://bugs.webkit.org/show_bug.cgi?id=33478
- inspector/front-end/StylesSidebarPane.js:
- 2:45 PM Changeset in webkit [55356] by
-
- 2 edits in trunk/LayoutTests
2010-02-27 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Unskip test that we seem to pass now.
- platform/gtk/Skipped:
- 2:26 PM Changeset in webkit [55355] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-02-27 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add platform results for plugin test and unskip it. The filename
of our test plugin is not the same than the one expected in the
default result file.
- platform/gtk/Skipped:
- platform/gtk/plugins/plugin-javascript-access-expected.txt: Added.
- 12:46 PM ApplicationsGtk edited by
- (diff)
- 12:16 PM ApplicationsGtk edited by
- info about the WebKit option in the Balsa email client (diff)
- 9:47 AM Changeset in webkit [55354] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip new test introduced in r55353 because of missing drag&drop support.
- platform/qt/Skipped: fast/css/user-drag-none.html skipped.
- 4:39 AM Changeset in webkit [55353] by
-
- 5 edits2 adds in trunk
<rdar://problem/7696607> Links do not respect -webkit-user-drag: none
https://bugs.webkit.org/show_bug.cgi?id=35475
Reviewed by Maciej Stachowiak.
WebCore:
Test: fast/css/user-drag-none.html
- page/DragController.cpp:
(WebCore::DragController::mayStartDragAtEventLocation): Added a node
parameter. The image drag check is done against the node, rather than
than against the hit test result. This prevents a non-draggable image
with an auto-draggable ancestor from being dragged alone. The link drag
check now ignores links that are -webkit-user-drag: none.
- page/DragController.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::shouldDragAutoNode): Pass the current node
to mayStartDragAtEventLocation().
LayoutTests:
- fast/css/user-drag-none-expected.txt: Added.
- fast/css/user-drag-none.html: Added.
- 2:48 AM Changeset in webkit [55352] by
-
- 2 edits in trunk/WebCore
2010-02-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: REGRESSION: hangs when scrolling in Resource pane.
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype._highlightLines):
- 12:57 AM Changeset in webkit [55351] by
-
- 4 edits in trunk
WebCore:
2010-02-27 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Abort XEmbed plugin initialization if our parent is not anchored
in a widget hierarchy. This can happen when the browser window is
destroyed while the plugin is being loaded, and will lead to a
crash.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart):
LayoutTests:
2010-02-27 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
We now pass this test, unskip.
- platform/gtk/Skipped:
- 12:24 AM Changeset in webkit [55350] by
-
- 5 edits3 adds in trunk/WebKitTools
Added Python style checking to check-webkit-style using
the third-party pep8 module (via autoinstall).
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=33639
- Scripts/webkitpy/style/checker.py:
- Added PYTHON to FileType.
- Updated ProcessorDispatcher to return a PythonProcessor for *.py files.
- Scripts/webkitpy/style/checker_unittest.py:
- Updated the ProcessorDispatcher unit tests for *.py files.
- Scripts/webkitpy/style/processors/python.py: Added.
- Added PythonProcessor class.
- Scripts/webkitpy/style/processors/python_unittest.py: Added.
- Added PythonProcessor unit tests.
- Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
- Added a sample Python file to test the PythonProcessor.process() code path (since pep8 accepts a file path).
- Scripts/webkitpy/style/unittests.py:
- Updated the style unit test file to import python_unittest.py.
- Scripts/webkitpy/style_references.py:
- Adjusted style references to import pep8.
- 12:10 AM Changeset in webkit [55349] by
-
- 4 edits in trunk/WebKit/mac
2010-02-27 Jing Jin <jjin@apple.com>
Reviewed by Timothy Hatcher.
Move implementation of Bug 35449 into WebFramePrivate.
- WebView/WebFrame.h:
- WebView/WebFrame.mm: (-[WebFrame setAllowScrollersToOverlapContent:]): (-[WebFrame setAlwaysHideHorizontalScroller:]): (-[WebFrame setAlwaysHideVerticalScroller:]):
- WebView/WebFramePrivate.h:
- 12:04 AM Changeset in webkit [55348] by
-
- 6 edits3 adds1 delete in trunk/WebKitTools
Rewrote autoinstall.py to support unzipping *.zip files after
download, unzipping and extracting *.tar.gz files after download,
and copying installed files to a destination directory.
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35163
These changes will allow us to autoinstall pep8.py from the web
and to put our third-party autoinstalled code in an explicit
directory like webkitpy/thirdparty/autoinstalled. They should
also speed up imports from autoinstalled *.zip packages slightly
since *.pyc files cannot be generated when importing from
zipped packages.
- Scripts/webkitpy/init.py:
- Updated the autoinstall lines to use the new autoinstall methods.
- Added pep8.py to the list of auto-installed packages.
- Scripts/webkitpy/bugzilla.py:
- Updated mechanize import path.
- Scripts/webkitpy/init/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- Scripts/webkitpy/init/autoinstall.py: Added.
- Added AutoInstaller class.
- Added sample testing usage to main.
- Scripts/webkitpy/networktransaction.py:
- Updated mechanize import path.
- Scripts/webkitpy/networktransaction_unittest.py:
- Updated mechanize import path.
- Scripts/webkitpy/statusserver.py:
- Updated mechanize import path.
- Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
- Replaced with rewritten autoinstall in init/autoinstall.py.
Feb 26, 2010:
- 11:01 PM Changeset in webkit [55347] by
-
- 13 edits in trunk
2010-02-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: reload inspected page on Cmd+R / Ctrl+R / F5 key event in inspector.
Drive-by fix for couple of minor front-end problems.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::reloadPage):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.reloadPage):
- inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.copyText): (.WebInspector.InspectorFrontendHostStub.prototype.canAttachWindow):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.toggleAttach):
WebKit/chromium
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsCanAttachWindow):
- src/WebDevToolsFrontendImpl.h:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): (devtools.InspectorBackendImpl.prototype.toggleNodeSearch):
- 10:22 PM Changeset in webkit [55346] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-26 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Verify that the Nodes being enumerated are HTML elements.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
- 10:06 PM Changeset in webkit [55345] by
-
- 1 edit5 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- platform/efl/ScrollbarEfl.cpp: Added.
- platform/efl/EventLoopEfl.cpp: Added.
- platform/efl/PlatformKeyboardEventEfl.cpp: Added.
- platform/efl/DragImageEfl.cpp: Added.
- platform/efl/PlatformMouseEventEfl.cpp: Added.
- 9:49 PM Changeset in webkit [55344] by
-
- 1 edit3 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- platform/efl/CursorEfl.cpp: Added.
- platform/efl/LocalizedStringsEfl.cpp: Added.
- platform/efl/SearchPopupMenuEfl.cpp: Added.
- 9:32 PM Changeset in webkit [55343] by
-
- 1 edit5 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to page/efl.
http://webkit.org/b/35087
- WebCore/page/efl/DragControllerEfl.cpp: Added.
- WebCore/page/efl/FrameEfl.cpp: Added.
- WebCore/page/efl/AccessibilityObjectEfl.cpp: Added.
- WebCore/page/efl/EventHandlerEfl.cpp: Added.
- 9:16 PM Changeset in webkit [55342] by
-
- 1 edit6 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- WebCore/platform/efl/LoggingEfl.cpp: Added.
- WebCore/platform/efl/ScrollbarThemeEfl.cpp: Added.
- WebCore/platform/efl/TemporaryLinkStubs.cpp: Added.
- WebCore/platform/efl/ScrollViewEfl.cpp: Added.
- WebCore/platform/efl/SharedBufferEfl.cpp: Added.
- WebCore/platform/efl/DragDataEfl.cpp: Added.
- 8:59 PM Changeset in webkit [55341] by
-
- 3 edits in trunk/WebKitTools
2010-02-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Change the default port for new-run-webkit-tests when running on
a Mac from 'chromium-mac' to 'mac'. Add a '--chromium' switch to
pick up the default platform-specific version of chromium instead.
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 8:42 PM Changeset in webkit [55340] by
-
- 1 edit1 add in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- WebCore/platform/efl/RenderThemeEfl.cpp: Added.
- 7:53 PM Changeset in webkit [55339] by
-
- 2 edits in trunk/WebKitTools
010-02-26 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix
third time's the charm getting this path right?
- pywebsocket/mod_pywebsocket/standalone.py:
- 7:53 PM Changeset in webkit [55338] by
-
- 1 edit5 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- WebCore/platform/efl/PlatformWheelEventEfl.cpp: Added.
- WebCore/platform/efl/FileChooserEfl.cpp: Added.
- WebCore/platform/efl/ContextMenuEfl.cpp: Added.
- WebCore/platform/efl/PlatformScreenEfl.cpp: Added.
- WebCore/platform/efl/WidgetEfl.cpp: Added.
- 7:42 PM Changeset in webkit [55337] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, build fix.
- pywebsocket/mod_pywebsocket/standalone.py:
- 7:27 PM Changeset in webkit [55336] by
-
- 1 edit1 move1 add in trunk/WebKitTools
Moving the script to the right location.
Reviewed by NOBODY (OOPS!).
- pywebsocket/mod_pywebsocket: Added.
- pywebsocket/mod_pywebsocket/standalone.py: Copied from WebKitTools/pywebsocket/standalone.py.
- pywebsocket/standalone.py: Removed.
- 7:20 PM Changeset in webkit [55335] by
-
- 7 edits in trunk
2010-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Expose an API for ports to add schemes to the mixed content whitelist
https://bugs.webkit.org/show_bug.cgi?id=35438
Add a notion of a "secure" scheme that doesn't trigger mixed content
warnings. Let folks register new secure schemes in the same way they
can register "local" schemes.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent):
- page/SecurityOrigin.cpp: (WebCore::secureSchemes): (WebCore::SecurityOrigin::registerURLSchemeAsSecure): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsSecure):
- page/SecurityOrigin.h:
2010-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Expose an API for ports to add schemes to the mixed content whitelist
https://bugs.webkit.org/show_bug.cgi?id=35438
Expose registerURLSchemeAsSecure via the WebKit API.
- public/WebSecurityPolicy.h:
- src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsSecure):
- 6:59 PM Changeset in webkit [55334] by
-
- 2 edits in trunk/WebCore
2010-02-26 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsLayerQt: artifacts and wrong transformOrigin
This was due to wrong way of applying cache-mode and transformation
on a graphics-item with HTML. Cache-mode should be updated
when the content type updates, even if it was the same cache-mode
Test URL attached to the bug now works correctly.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::computeTransform): (WebCore::GraphicsLayerQtImpl::flushChanges):
- 6:51 PM Changeset in webkit [55333] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, fixing the license.
- pywebsocket/standalone.py:
- 6:43 PM Changeset in webkit [55332] by
-
- 3 edits in trunk/WebCore
2010-02-26 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Qt/Mac: Revert null timer removal (r51105)
https://bugs.webkit.org/show_bug.cgi?id=35396
r51105 removed the null timer event of the carbon event model. This however
breaks the flash of many sites.
Applying patch suggested by Girish Ramakrishnan in bug comment #1.
- plugins/PluginView.h:
- plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::platformStart): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::nullEventTimerFired): (WebCore::PluginView::mousePosForPlugin):
- 6:25 PM Changeset in webkit [55331] by
-
- 2 edits in trunk/WebCore
2010-02-26 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compile error with 3d-canvas
Replaced a direct gl call with a getProcAddress call
https://bugs.webkit.org/show_bug.cgi?id=35448
No new tests.
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::blendColor):
- 6:08 PM Changeset in webkit [55330] by
-
- 1 edit1 add in trunk/WebCore
2010-02-26 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kenneth Rohde Christiansen.
[BREWMP] Port EventHandler
https://bugs.webkit.org/show_bug.cgi?id=34796
Add platform-specific code required to implement EventHandler.
- page/brew/EventHandlerBrew.cpp: Added. (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::accessKeyModifiers):
- 5:51 PM Changeset in webkit [55329] by
-
- 1 edit2 adds in trunk/WebKitTools
Adding pywebsocket/standalone.py back to fix the Chromium webkit
canaries. Once all layout tests pass, we can get in the patch that
moves this directorty to WebKitTools/Scripts, update all Chromium
scripts, and revert this patch.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35464
- pywebsocket: Added.
- pywebsocket/standalone.py: Added.
- 5:51 PM Changeset in webkit [55328] by
-
- 1 edit8 adds in trunk/WebCore
2010-02-26 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Add EFL port files to platform/efl.
http://webkit.org/b/35087
- WebCore/platform/efl/ClipboardEfl.cpp: Added.
- WebCore/platform/efl/PopupMenuEfl.cpp: Added.
- WebCore/platform/efl/SharedTimerEfl.cpp: Added.
- WebCore/platform/efl/RenderThemeEfl.h: Added.
- WebCore/platform/efl/Language.cpp: Added.
- WebCore/platform/efl/CookieJarEfl.cpp: Added.
- WebCore/platform/efl/MIMETypeRegistryEfl.cpp: Added.
- 5:34 PM Changeset in webkit [55327] by
-
- 2 edits in trunk
2010-02-26 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] ignore WebKit/gtk/docs/GNUmakefile.in in .gitignore
https://bugs.webkit.org/show_bug.cgi?id=35424
- .gitignore:
- 5:17 PM Changeset in webkit [55326] by
-
- 2 edits in trunk/WebCore
2010-02-26 Robert Kroeger <rjkroege@chromium.org>
Reviewed by Nate Chapin
To fire each event handler registered on an SVG node once per
event, Chromium needs an implementation of wasCreatedFromMarkup
added to V8LazyEventListener.h that matches the one in
WebKit/WebCore/bindings/js/JSLazyEventListener.h.
This patch adds such a matching implementation of wasCreatedFromMarkup
to V8LazyEventListener.h.
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::wasCreatedFromMarkup):
- 5:00 PM Changeset in webkit [55325] by
-
- 3 edits in trunk/WebCore
2010-02-26 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] use geoclue_position_get_position_async to get geolocation position.
https://bugs.webkit.org/show_bug.cgi?id=35355
No new tests, behaviour depends on system.
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating): (WebCore::GeolocationServiceGtk::get_position):
- platform/gtk/GeolocationServiceGtk.h:
- 4:44 PM Changeset in webkit [55324] by
-
- 6 edits in trunk/WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=35449
Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content.
Patch by Jing Jin <jjin@apple.com> on 2010-02-26
Reviewed by Timothy Hatcher.
- WebView/WebDynamicScrollBarsView.h:
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]): Allows scrollbars to
overlap with the document and re-layouts the document.
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): Hides the horizontal scrollbar.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): Hides the vertical scrollbar.
(-[WebDynamicScrollBarsView contentViewFrame]): Calculates the appropriate frame based
on allowScrollersToOverlapContent.
(-[WebDynamicScrollBarsView tile]): If allowScrollersToOverlapContent is YES, set the
contentView's frame so it overlaps with the scrollbar.
(-[WebDynamicScrollBarsView updateScrollers]): Take into account hideHorizontalScroller
and hideVerticalScroller.
(-[WebDynamicScrollBarsView reflectScrolledClipView:]): set drawsBackground to NO when
scrollbars are overlapping with content, so we don't get trails during scrollbar draw updates.
- WebView/WebDynamicScrollBarsViewInternal.h:
- WebView/WebFrame.h:
- WebView/WebFrame.mm:
(-[WebFrame setAllowScrollersToOverlapContent:]): Hook for [WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]
(-[WebFrame setAlwaysHideHorizontalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]
(-[WebFrame setAlwaysHideVerticalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]
- 4:32 PM Changeset in webkit [55323] by
-
- 2 edits in trunk/WebCore
2010-02-26 Yaar Schnitman <yaar@chromium.org>
Chromium Win build fix.
- WebCore.gyp/WebCore.gyp: Added missing file to action input.
- 4:19 PM Changeset in webkit [55322] by
-
- 12 edits1 delete in trunk/JavaScriptCore
Rubber Stamped by Geoff Garen.
Remove wrec. All builds should have switched to yarr by now.
- Android.mk:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/RegExp.cpp:
(JSC::RegExp::match):
- runtime/RegExp.h:
- wrec: Removed.
- wrec/CharacterClass.cpp: Removed.
- wrec/CharacterClass.h: Removed.
- wrec/CharacterClassConstructor.cpp: Removed.
- wrec/CharacterClassConstructor.h: Removed.
- wrec/Escapes.h: Removed.
- wrec/Quantifier.h: Removed.
- wrec/WREC.cpp: Removed.
- wrec/WREC.h: Removed.
- wrec/WRECFunctors.cpp: Removed.
- wrec/WRECFunctors.h: Removed.
- wrec/WRECGenerator.cpp: Removed.
- wrec/WRECGenerator.h: Removed.
- wrec/WRECParser.cpp: Removed.
- wrec/WRECParser.h: Removed.
- wscript:
- 3:47 PM Changeset in webkit [55321] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-26 Brett Wilson <brettw@chromium.org>
Fix chromium build. This test's expectation became obsolete with
recent changes to KURL which my previous change brings Chromium's
port in compliance with.
- tests/KURLTest.cpp: (ComponentCase::TEST):
- 3:26 PM Changeset in webkit [55320] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-26 Yaar Schnitman <yaar@chromium.org>
Chromium build fix.
- features.gypi: Added missing new variable enable_svg.
- 3:18 PM Changeset in webkit [55319] by
-
- 3 edits in trunk/WebCore
2010-02-12 Brett Wilson <brettw@chromium.org>
Reviewed by Adam Barth.
Update the Google-URL version of KURL and the V8 bindings to the new
behavior of KURL.IsStandard.
This is covered by fast/dom/Window/invalid-protocol.html
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
- platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
- 3:13 PM Changeset in webkit [55318] by
-
- 4 edits1 add in trunk
2010-02-25 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Auto-generate and split DerivedSourcesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=33048
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_derivedsourcesallinone.py: Added.
- bindings/v8/DerivedSourcesAllInOne.cpp: Removed.
- 2:53 PM Changeset in webkit [55317] by
-
- 2 edits in trunk/WebCore
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapInstance::invokeMethod):
Reviewed by NOBODY (Build fix following r55312).
- 2:39 PM Changeset in webkit [55316] by
-
- 8 edits in trunk
WebKit/gtk
2009-12-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170
Add new signal to report when the document load is finished for a
frame.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad):
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
WebKitTools
2010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170
Fix reporting of unload handlers, so that it is emitted where
needed, not after it.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadFinished): (webViewDocumentLoadFinished): (createWebView):
LayoutTests
2010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170
Unskip tests that now pass.
- LayoutTests/platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: rebaselined.
- platform/gtk/Skipped:
- 2:30 PM Changeset in webkit [55315] by
-
- 4 edits2 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=35450
Crash when a Java array property accessor raises an exception
Test: java/inaccessible-class.html. Adding with a FAIL result, because this doesn't raise
an exception in Firefox. I don't know what the formally correct behavior is, but it's good
to avoid crashing.
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): Check if the result is null before interpreting it as an object or array.
- 2:27 PM Changeset in webkit [55314] by
-
- 3 edits in trunk/WebCore
2010-02-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Extend AffineTransform to mapQuad
https://bugs.webkit.org/show_bug.cgi?id=35444
This makes mapQuad available for AffineTransform. So that platforms
can make use of it after the switch from TransformationMatrix to
AffineTransform in GraphicsContext.
- platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::mapRect): mapRect already did the calculation for mapQuad but gave back the
boundingBox of the resulting FloatQuad.
(WebCore::AffineTransform::mapQuad):
- platform/graphics/transforms/AffineTransform.h:
- 2:26 PM Changeset in webkit [55313] by
-
- 2 edits in trunk/WebCore
Arrow keys do not scroll source view in Resources pane or Scripts pane.
<rdar://problem/7594367> and https://bugs.webkit.org/show_bug.cgi?id=34356
Reviewed by Pavel Feldman.
Handle vertical scrolling in the Text Viewer:
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer): Listen for the keydown event.
(WebInspector.TextViewer.prototype._handleKeyDown): If the event has no modifiers and refers
to an arrow key, scroll. The horizontal values were ripped from the default "pixels per scroll line"
value in ScrollBar.h.
- 2:21 PM Changeset in webkit [55312] by
-
- 24 edits1 add in trunk
Bug 35401 - Fix handling of errors in handling calls over bridge,
where base object bridge-type does not match method bridge-type.
Reviewed by Alexey Proskuryakov.
The code assumes users will only attempt to invoke a Java method
on a Java base object, etc.
Add language specific subclasses of RuntimeMethod, and pass the
RuntimeMethod into invokeMethod, so we can typecheck before
casting. Throw an exception on type mismatch.
WebCore:
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):new class to distinguish this type of RuntimeMethod.
(JSC::Bindings::CInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(JSC::Bindings::CInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
- bridge/c/c_instance.h:
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::JavaRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(JavaInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(JavaInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
- bridge/jni/jsc/JavaInstanceJSC.h:
- bridge/jsc/BridgeJSC.h:
- bridge/objc/objc_instance.h:
- bridge/objc/objc_instance.mm:
(ObjcRuntimeMethod::ObjcRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(ObjcInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(ObjcInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
(ObjcInstance::invokeObjcMethod): new method, takes an ObjcMethod* as an argument so that we don't need to dynamically determine the type.
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject): use new invokeObjcMethod method.
- bridge/runtime_method.cpp:
(JSC::callRuntimeMethod): pass RuntimeMethod as argument to invokeMethod, rather than its MethodList.
- bridge/runtime_object.cpp:
(JSC::RuntimeObject::methodGetter): use new getMethod method.
WebKit/mac:
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::PluginRuntimeMethod::PluginRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(WebKit::ProxyInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(WebKit::ProxyInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
LayoutTests:
- java/java-and-plugins.html: Add tests for passing mismatched this objects to methdods.
- 2:17 PM Changeset in webkit [55311] by
-
- 5 edits in trunk
2010-02-26 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Make the lookup table generator include an explicit cast to expected
type of the function. We do this because otherwise the blind intptr_t
cast that is subsequently applied allows incorrectly typed functions
to be inserted into the table, where they will only fail at runtime.
This change makes such errors produce a compile time failure.
- 2:07 PM Changeset in webkit [55310] by
-
- 4 edits1 copy13 adds in trunk
2010-02-26 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Basic tests for munder, munderover, and mover elements.
- mathml/presentation/over.xhtml: Added.
- mathml/presentation/under.xhtml: Added.
- mathml/presentation/underover.xhtml: Added.
- platform/mac/mathml/presentation/over-expected.checksum: Added.
- platform/mac/mathml/presentation/over-expected.png: Added.
- platform/mac/mathml/presentation/over-expected.txt: Added.
- platform/mac/mathml/presentation/under-expected.checksum: Added.
- platform/mac/mathml/presentation/under-expected.png: Added.
- platform/mac/mathml/presentation/under-expected.txt: Added.
- platform/mac/mathml/presentation/underover-expected.checksum: Added.
- platform/mac/mathml/presentation/underover-expected.png: Added.
- platform/mac/mathml/presentation/underover-expected.txt: Added.
2010-02-26 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Added basic support for the munder, munderover, and mover elements.
Tests: mathml/presentation/over.xhtml
mathml/presentation/under.xhtml
mathml/presentation/underover.xhtml
- WebCore.xcodeproj/project.pbxproj:
- mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/RenderMathMLUnderOver.cpp: Added. (WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver): (WebCore::RenderMathMLUnderOver::addChild): (WebCore::getOffsetHeight): (WebCore::RenderMathMLUnderOver::stretchToHeight): (WebCore::RenderMathMLUnderOver::layout): (WebCore::RenderMathMLUnderOver::baselinePosition): (WebCore::RenderMathMLUnderOver::nonOperatorHeight):
- mathml/RenderMathMLUnderOver.h: Added. (WebCore::RenderMathMLUnderOver::hasBase): (WebCore::RenderMathMLUnderOver::):
- 1:48 PM Changeset in webkit [55309] by
-
- 3 edits in trunk
[Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event.
https://bugs.webkit.org/show_bug.cgi?id=35432
Patch by Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Gustavo Noronha.
When a directional key-press event (arrow keys, End, Home, PageUp,
PageDown, etc) is synthesized by DRT's EventSender and it targets
an editor (e.g. <input type=text>, <textare>, etc), event is processed
by WebCore::EventHandler. On the other hand, if event target is not
an editor, event is bubbled up to Gtk+ for processing. In such cases,
if 'hardware_keycode' is not provided at event synthesize time
its processing fails (at some point in gtk_bindings_activate_event),
and no scroll action is performed.
Unskip fast/events/node-event-anchor-lock.html
- DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):
- platform/gtk/Skipped:
- 1:43 PM Changeset in webkit [55308] by
-
- 2 edits in trunk/WebCore
2010-02-24 Stephen White <senorblanco@chromium.org>
Reviewed by Darin Adler.
This CL implements a simple ad-hoc parser for CSS rgb() values.
If it fails, it returns false and the normal lex/yacc parser will
be invoked.
Covered by fast/canvas/canvas-bg.html, fast/canvas/canvas-bg-zoom.html,
and many more.
- css/CSSParser.cpp: (WebCore::parseInt): (WebCore::CSSParser::parseColor):
- 1:40 PM Changeset in webkit [55307] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-26 Darin Fisher <darin@chromium.org>
Fix mac warning (that gets treated as an error in the chromium build).
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cookiesEnabled):
- 1:33 PM Changeset in webkit [55306] by
-
- 2 edits in trunk/WebCore
2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=35419
3D canvas did not update when WTF_USE_ACCELERATED_COMPOSITING
was enabled but not from run-time settings. Added run-time
check that compositing is enabled.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::markContextChanged):
- 1:24 PM Changeset in webkit [55305] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-26 Antonio Gomes <tonikitoo@webkit.org>
Complementary commit of r55300. Missing "notify::" to signal name.
- tests/testwebview.c: (test_webkit_web_view_grab_focus):
- 1:16 PM Changeset in webkit [55304] by
-
- 2 edits in trunk/WebCore
2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Compilation failed because functions glSampleCoverage, glBlendEquation
and glActiveTexture were not available.
https://bugs.webkit.org/show_bug.cgi?id=35423
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::sampleCoverage):
- 12:59 PM Changeset in webkit [55303] by
-
- 2 edits in trunk/WebCore
2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=35380
Fixed compilation error when WTF_USE_ACCELERATED_COMPOSITING=0
- css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
- 12:42 PM Changeset in webkit [55302] by
-
- 2 edits in trunk/WebCore
2010-02-26 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Incorrect painting after a size changed.
https://bugs.webkit.org/show_bug.cgi?id=35412
No new tests. Bug fix in backend.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::paint): Provide the source rectangle, rather than inferring it.
- 12:41 PM Changeset in webkit [55301] by
-
- 2 edits in trunk/LayoutTests
2010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rebaseline of platform-specific results for test.
SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421
- platform/gtk/svg/custom/use-on-clip-path-with-transformation-expected.txt:
- 12:32 PM Changeset in webkit [55300] by
-
- 3 edits in trunk/WebKit/gtk
[GTK] Make webkit_web_view_grab_focus to active focus controller.
https://bugs.webkit.org/show_bug.cgi?id=35402
Reviewed by Xan Lopez.
Patch by Antonio Gomes <tonikitoo@webkit.org>
When programatically setting focus to an element in an inner document,
calling "hasFocus()" from this document returns FALSE, because
document's FocusController is not activated. It does not happen
if |document| is the main document.
Making webkit_web_view_grab_focus to actually activate the FocusController,
fixes the issue.
- tests/testwebview.c:
(server_callback):
(test_webkit_web_view_grab_focus):
- webkit/webkitwebview.cpp:
(webkit_web_view_grab_focus):
- 12:24 PM Changeset in webkit [55299] by
-
- 2 edits in trunk/WebCore
2010-02-26 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Incorrect handling of MIME types in Media Player
https://bugs.webkit.org/show_bug.cgi?id=35413
No new tests. Bug fix in backend.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::supportsType): Corrected logic.
- 12:20 PM Changeset in webkit [55298] by
-
- 2 edits in trunk/WebKit/gtk
Unreviewed.
Reverted last patch (r55295), it causes problems with the frames.
- WebCoreSupport/ChromeClientGtk.cpp:
- 12:08 PM Changeset in webkit [55297] by
-
- 3 edits in trunk/WebCore
2010-02-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=35418
[Gtk] Every table, including layout tables, should be exposed as a table
This patch exposes layout tables as tables. (Addressing the problematic table
hierarchy remains to be done.)
- accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::determineAccessibilityRole):
- 11:50 AM Changeset in webkit [55296] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-26 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] Symbian specific getCPUTime implemetation
https://bugs.webkit.org/show_bug.cgi?id=34742
Default implementation doesn't work on Symbian devices.
This change adds a proper implementation by
asking thread execution time from the current thread.
- runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
- 10:54 AM Changeset in webkit [55295] by
-
- 2 edits in trunk/WebKit/gtk
[GTK] Some region checks in scroll are not required
https://bugs.webkit.org/show_bug.cgi?id=35142
Reviewed by Xan Lopez.
Removes some of the operations checking the moved and invalidated
regions when scrolling, it is done already in
gdk_window_move_region.
- WebCoreSupport/ChromeClientGtk.cpp:
- 10:51 AM Changeset in webkit [55294] by
-
- 2 edits in trunk/WebKitSite
Rubber-stamped by Adele Peterson.
Update Security Group Members list.
- security/security-group-members.html:
- 10:47 AM Changeset in webkit [55293] by
-
- 2 edits in trunk/LayoutTests
2010-02-26 Dirk Schulze <krit@webkit.org>
Unreviewed LayoutTest fix.
SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421
This corrects a result of a new clip test for SVG.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt:
- 10:37 AM Changeset in webkit [55292] by
-
- 2 edits in trunk/WebKitTools
2010-02-26 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
new-webkit-run-tests: Extraneous parenthesis in websocket_server.py
https://bugs.webkit.org/show_bug.cgi?id=35436
- Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed extra paren.
- 10:13 AM Changeset in webkit [55291] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
[Qt] Update platform specific expected file after r55289.
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- 10:09 AM Changeset in webkit [55290] by
-
- 3 edits in trunk/WebCore
2010-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
XSSAuditor is super super super slow
https://bugs.webkit.org/show_bug.cgi?id=35373
In this patch, we separate the decoding cache for the page's URL and
form data. Previously, we used the same cache for both, which caused
us miss the cache every time when the page had form data (because the
cache only stored one entry). When the form data is large, we were
wasting a lot of time canonicalizing.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h:
- 10:02 AM Changeset in webkit [55289] by
-
- 43 edits2 adds2 deletes in trunk
2010-02-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421
Move SVGResourceClipper to RenderSVGResourceClipper. This follows the changes
of Masker and helps to clean up the SVG code. Code snippets from SVGClipPathElement
and SVGResourceClipper got combined in RenderSVGResourceClipper. DRT results are
more readable for clipPath's now. It's possible to see the unit type of clipper, as
well as it's childs instead of just one path.
- Android.mk:
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderSVGResource.h: (WebCore::):
- rendering/RenderSVGResourceClipper.cpp: Added. (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClients): (WebCore::RenderSVGResourceClipper::invalidateClient): (WebCore::RenderSVGResourceClipper::applyResource): (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
- rendering/RenderSVGResourceClipper.h: Added. (WebCore::RenderSVGResourceClipper::renderName): (WebCore::RenderSVGResourceClipper::resourceType): (WebCore::RenderSVGResourceClipper::clipPathUnits):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::deregisterFromResources):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources):
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::svgAttributeChanged): (WebCore::SVGClipPathElement::childrenChanged): (WebCore::SVGClipPathElement::createRenderer):
- svg/SVGClipPathElement.h: (WebCore::SVGClipPathElement::isValid):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
- svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isMarker):
- svg/graphics/SVGResourceClipper.cpp: Removed.
- svg/graphics/SVGResourceClipper.h: Removed.
2010-02-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421
Update results after the move of SVGResourceClipper. Results are better
readable and more sensible now.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
- platform/mac/svg/batik/text/textEffect2-expected.txt:
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/css/clippath-with-shadow-expected.txt:
- platform/mac/svg/custom/clip-path-child-changes-expected.txt:
- platform/mac/svg/custom/clip-path-display-none-child-expected.txt:
- platform/mac/svg/custom/clip-path-href-changes-expected.txt:
- platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
- platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
- platform/mac/svg/custom/clip-path-units-changes-expected.txt:
- platform/mac/svg/custom/clip-path-with-transform-expected.txt:
- platform/mac/svg/custom/empty-clip-path-expected.txt:
- platform/mac/svg/custom/focus-ring-expected.txt:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-clipPath-creation-expected.txt:
- platform/mac/svg/custom/recursive-clippath-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/text-clip-expected.txt:
- platform/mac/svg/custom/visibility-override-clip-expected.txt:
- platform/mac/svg/filters/filter-clip-expected.txt:
- svg/custom/use-clipped-transform-expected.txt:
- 8:53 AM Changeset in webkit [55288] by
-
- 2 edits in trunk/WebKit/qt
2010-02-26 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Simon Hausmann.
Fix documentation of QWebSettings::setUserStyleSheetUrl method
The base 64 data in the exemple shows a not valid code.
REGRESSION: QWebSettings::setUserStyleSheetUrl is not working with a data URL (Base64)
https://bugs.webkit.org/show_bug.cgi?id=34802
- Api/qwebsettings.cpp:
- 8:52 AM Changeset in webkit [55287] by
-
- 6 edits in trunk
The element that a touchevent is dispatched to isn't always right
https://bugs.webkit.org/show_bug.cgi?id=35431
Reviewed by Kenneth Rohde Christiansen.
WebCore:
The element that touch events are dispatched on is not always the
correct one, as the cached m_touchEventTarget member is only updated
when the first element of the PlatformTouchEvent touch list is in the
TouchPressed state.
This patch changes this behavior to dispatch the event to the target
of the touch that caused the event to be generated and eliminates the
m_touchEventTarget in favour of using the touch target hashmap. It also
simplifies the way in which the touchTargets list is generated as we
no longer have m_touchEventTarget (which was used previously to build
the list). The new behavior matches the observed behavior of the
iPhone and Android.
- page/EventHandler.cpp:
(WebCore::assembleTargetTouches): Added. new function to build the
targetTouches list. Filters a list of touches (passed) about
another given touch.
(WebCore::EventHandler::handleTouchEvent): Remove the
m_touchEventTarget member, and simplify the generation of the
TouchLists that are bundled with the TouchEVent object. Dispatch
the event to the target of the touch that caused the event to be
fired.
- page/EventHandler.h: Remove m_touchEventTarget.
LayoutTests:
- fast/events/touch/basic-single-touch-events-expected.txt: Updated
the targetTouches list expections.
- fast/events/touch/script-tests/basic-single-touch-events.js: ditto.
(verifyTouch):
- 8:51 AM Changeset in webkit [55286] by
-
- 4 edits1 move1 add in trunk/WebKitTools
Moved pywebsocket into the webkitpy/thirdparty directory and added
an associated README.webkit file to the pywebsocket directory.
This makes pywebsocket more consistent with the other third-party
Python code in our repository.
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=35198
- Scripts/run-webkit-tests:
- Updated paths to pywebsocket.
- Scripts/run-webkit-websocketserver:
- Updated paths to pywebsocket.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Updated paths to pywebsocket.
- Scripts/webkitpy/thirdparty/pywebsocket: Copied from WebKitTools/pywebsocket.
- Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
- Added a file containing information about the contents of the pywebsocket directory. This will make it easier to understand where the third-party code came from and what local changes have been made.
- pywebsocket: Removed.
- pywebsocket/COPYING: Removed.
- pywebsocket/MANIFEST.in: Removed.
- pywebsocket/README: Removed.
- pywebsocket/example: Removed.
- pywebsocket/example/echo_client.py: Removed.
- pywebsocket/example/echo_wsh.py: Removed.
- pywebsocket/mod_pywebsocket: Removed.
- pywebsocket/mod_pywebsocket/init.py: Removed.
- pywebsocket/mod_pywebsocket/dispatch.py: Removed.
- pywebsocket/mod_pywebsocket/handshake.py: Removed.
- pywebsocket/mod_pywebsocket/headerparserhandler.py: Removed.
- pywebsocket/mod_pywebsocket/memorizingfile.py: Removed.
- pywebsocket/mod_pywebsocket/msgutil.py: Removed.
- pywebsocket/mod_pywebsocket/standalone.py: Removed.
- pywebsocket/mod_pywebsocket/util.py: Removed.
- pywebsocket/setup.py: Removed.
- pywebsocket/test: Removed.
- pywebsocket/test/config.py: Removed.
- pywebsocket/test/mock.py: Removed.
- pywebsocket/test/run_all.py: Removed.
- pywebsocket/test/test_dispatch.py: Removed.
- pywebsocket/test/test_handshake.py: Removed.
- pywebsocket/test/test_memorizingfile.py: Removed.
- pywebsocket/test/test_mock.py: Removed.
- pywebsocket/test/test_msgutil.py: Removed.
- pywebsocket/test/test_util.py: Removed.
- pywebsocket/test/testdata: Removed.
- pywebsocket/test/testdata/handlers: Removed.
- pywebsocket/test/testdata/handlers/blank_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/origin_check_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/sub: Removed.
- pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Removed.
- pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Removed.
- pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Removed.
- 8:36 AM Changeset in webkit [55285] by
-
- 3 edits2 adds in trunk
2010-02-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Fisher.
Fix the handling of updates to #hash fragments to check for differences
post-canonicalization rather than comparing pre- to post-. Chromium
had a bug where we would set the #hash on an about:blank URL and generate
an onload event because we thought the URL (not just the fragment) was
changing.
- fast/loader/about-blank-hash-change-expected.txt: Added.
- fast/loader/about-blank-hash-change.html: Added.
2010-02-26 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Fisher.
Fix the handling of updates to #hash fragments to check for differences
post-canonicalization rather than comparing pre- to post-. Chromium
had a bug where we would set the #hash on an about:blank URL and generate
an onload event because we thought the URL (not just the fragment) was
changing.
Test: fast/loader/about-blank-hash-change.html
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::hashAccessorSetter):
- 8:19 AM Changeset in webkit [55284] by
-
- 2 edits in trunk/WebKitTools
2010-02-26 Chris Jerdonek <Chris Jerdonek>
Reviewed by Eric Seidel.
Changed the diff_parser module to log to a module-specific
logging.logger rather than the root logger.
- Scripts/webkitpy/diff_parser.py:
- 7:48 AM Changeset in webkit [55283] by
-
- 5 edits2 adds in trunk
2010-02-26 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
texImage2D and texSubImage2D taking ImageData ignore flipY and premultiplyAlpha
https://bugs.webkit.org/show_bug.cgi?id=34459
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html: Added.
2010-02-26 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
texImage2D and texSubImage2D taking ImageData ignore flipY and premultiplyAlpha
https://bugs.webkit.org/show_bug.cgi?id=34459
Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): Apply flipY and premultiplyAlpha to the texture data. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): Extract data from ImageData, applying flipY and premultiplyAlpha.
- platform/graphics/GraphicsContext3D.h: Add function extractImageData declaration.
- 7:30 AM Changeset in webkit [55282] by
-
- 11 edits in trunk
2010-02-26 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
Set viewport to canvas size upon context creation
https://bugs.webkit.org/show_bug.cgi?id=35057
- fast/canvas/webgl/bug-32888.html: Remove the gl.viewport call since it's done when WebGLRenderingContext is created.
- fast/canvas/webgl/gl-get-calls-expected.txt: The read-back viewport size should match the canvas size instead of (0, 0, 0, 0).
- fast/canvas/webgl/gl-get-calls.html: Remove the gl.viewport call since it's done when WebGLRenderingContext is created.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html: Ditto.
- fast/canvas/webgl/tex-sub-image-2d.html: Ditto.
- fast/canvas/webgl/texImage2DImageDataTest.html: Ditto.
- fast/canvas/webgl/triangle.html: Ditto.
- fast/canvas/webgl/viewport-unchanged-upon-resize.html: Ditto.
2010-02-26 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
Set viewport to canvas size upon context creation
https://bugs.webkit.org/show_bug.cgi?id=35057
Covered by existing tests, in particular fast/canvas/webgl/gl-get-calls.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Set the viewport size to match the canvas size.
- 6:56 AM Changeset in webkit [55281] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] fast/multicol/client-rects.html fails in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=34959
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/fast: Added.
- platform/qt/fast/multicol: Added.
- platform/qt/fast/multicol/client-rects-expected.txt: Platform specific expected file added.
- platform/qt/Skipped: fast/multicol/client-rects.html unskipped.
- 6:49 AM Changeset in webkit [55280] by
-
- 6 edits in trunk
[Qt] LayoutTestController.numberOfPages() should have default parameters
https://bugs.webkit.org/show_bug.cgi?id=35428
Reviewed by Kenneth Rohde Christiansen.
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: maxViewWidth and maxViewHeight moved to
LayoutTestController to converge to platform independent implementation.
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: Initialization of maxViewWidth and maxViewHeight added.
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- Default parameters for LayoutTestController.numberOfPages() added.
- maxViewWidth and maxViewHeight members added.
LayoutTests:
- platform/qt/Skipped: printing/css2.1 tests unskipped.
- 4:07 AM Changeset in webkit [55279] by
-
- 2 edits in trunk/LayoutTests
2010-02-26 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425
- platform/gtk/Skipped: Skipping another crasher related to bug 35425.
- 4:04 AM Changeset in webkit [55278] by
-
- 2 edits in trunk/WebCore
2010-02-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: touch InspectorController to force front-end deployment.
- inspector/InspectorController.cpp:
- 3:26 AM Changeset in webkit [55277] by
-
- 20 edits in trunk
2010-02-26 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: While the current timeline view in DevTools provides a great overview of
things happening, we should make it easier to locate the cause of an event,
e.g., link to JS where relevant.
Caller info support for all kind of Timeline events and new Function Call event will be added.
JSC can be patched the same way as it will be done for V8.
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
- bindings/js/ScriptCallStack.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willCallFunction): (WebCore::InspectorTimelineAgent::didCallFunction): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::instanceCount):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord): (WebCore::TimelineRecordFactory::createFunctionCallData):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/Popover.js: (WebInspector.Popover.prototype.hideWhenClicked): (WebInspector.Popover.prototype._positionElement):
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._closeRecordDetails): (WebInspector.TimelinePanel.prototype._onScroll): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordListRow.prototype._createCell): (WebInspector.TimelineRecordListRow.prototype._createRow): (WebInspector.TimelineRecordListRow.prototype._createLinkRow): (WebInspector.TimelineRecordListRow.prototype._generateBubbleContent): (WebInspector.TimelineRecordListRow.prototype._onClick):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.js: (WebInspector.linkifyResourceAsNode):
- 3:04 AM Changeset in webkit [55276] by
-
- 2 edits in trunk/LayoutTests
2010-02-26 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Skip failing tests.
Refine LayoutTests/printing/css2.1 with numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35334
- platform/qt/Skipped:
- 2:40 AM Changeset in webkit [55275] by
-
- 19 edits1 copy1 add in trunk/LayoutTests
2010-02-26 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Refine LayoutTests/printing/css2.1 with numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35334
Small refinements were done in paged-media-test-utils.js.
Note that WebKit doesn't pass page-break-after-003 for now.
- printing/css2.1/README.txt:
- printing/css2.1/page-break-after-000-expected.txt:
- printing/css2.1/page-break-after-000.html:
- printing/css2.1/page-break-after-001-expected.txt:
- printing/css2.1/page-break-after-001.html:
- printing/css2.1/page-break-after-002-expected.txt:
- printing/css2.1/page-break-after-002.html:
- printing/css2.1/page-break-after-003-expected.txt: Added.
- printing/css2.1/page-break-after-003.html: Added.
- printing/css2.1/page-break-after-004-expected.txt:
- printing/css2.1/page-break-after-004.html:
- printing/css2.1/page-break-before-000-expected.txt:
- printing/css2.1/page-break-before-000.html:
- printing/css2.1/page-break-before-001-expected.txt:
- printing/css2.1/page-break-before-001.html:
- printing/css2.1/page-break-before-002-expected.txt:
- printing/css2.1/page-break-before-002.html:
- printing/css2.1/page-break-inside-000-expected.txt:
- printing/css2.1/page-break-inside-000.html:
- printing/resources/paged-media-test-utils.js: (appendResult): (pageNumberForElementShouldBe): (numberOfPagesShouldBe): (runPrintingTest):
- 2:05 AM Changeset in webkit [55274] by
-
- 2 edits in trunk/LayoutTests
2010-02-26 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425
- platform/gtk/Skipped: Skipping crasher.
- 1:56 AM Changeset in webkit [55273] by
-
- 7 edits in trunk
2010-02-26 Jamey Hicks <jamey.hicks@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl()
Enables the use of alternate Web Inspector frontends by changing
the location of the frontend.
This is required so that the Web Inspector may be run from an
external process or an external tool such as Eclipse or Aptana may
be used instead of the in-process Web Inspector UI.
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings): (QWebSettings::setInspectorUrl): (QWebSettings::inspectorUrl):
- Api/qwebsettings.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::createPage):
2010-02-26 Jamey Hicks <jamey.hicks@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl()
Enables the use of alternate Web Inspector frontends by changing
the location of the frontend. The location is specified by providing
-inspector-url url
as an argument to QtLauncher.
This is required so that the Web Inspector may be run from an
external process or an external tool such as Eclipse or Aptana may
be used instead of the in-process Web Inspector UI.
- QtLauncher/main.cpp: (LauncherWindow::init): (LauncherApplication::handleUserOptions):
- 1:28 AM BuildingQtOnSymbian edited by
- (diff)
- 1:08 AM Changeset in webkit [55272] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-02-26 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
Adding two GTK layout test results for a new tests
added in r55259 and r55260.
- platform/gtk/svg/custom/use-on-clip-path-with-transformation-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt.
- platform/gtk/svg/filters/filter-on-tspan-expected.txt: Added.
- 12:39 AM Changeset in webkit [55271] by
-
- 20 edits6 adds2 deletes in trunk
Unreviewed. Roll-out r55263 because it broke fast/forms/textarea-type-spaces-pretty-diff.html.
https://bugs.webkit.org/show_bug.cgi?id=30946
WebCore:
- editing/CompositeEditCommand.cpp:
(WebCore::isWhitespace):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
- editing/InsertTextCommand.h:
- editing/htmlediting.cpp:
- editing/htmlediting.h:
LayoutTests:
- editing/execCommand/5142012-3-expected.txt:
- editing/inserting/rebalance-whitespace-1-expected.txt: Removed.
- editing/inserting/rebalance-whitespace-1.html: Removed.
- editing/pasteboard/5521237-expected.txt:
- platform/mac/editing/execCommand/5482023-expected.checksum:
- platform/mac/editing/execCommand/5482023-expected.png: Added.
- platform/mac/editing/execCommand/5482023-expected.txt:
- platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-2-expected.png: Added.
- platform/mac/editing/execCommand/remove-formatting-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-expected.png: Added.
- platform/mac/editing/execCommand/remove-formatting-expected.txt:
- platform/mac/editing/inserting/editable-html-element-expected.checksum:
- platform/mac/editing/inserting/editable-html-element-expected.png: Added.
- platform/mac/editing/inserting/editable-html-element-expected.txt:
- platform/mac/editing/pasteboard/4989774-expected.checksum:
- platform/mac/editing/pasteboard/4989774-expected.png: Added.
- platform/mac/editing/pasteboard/4989774-expected.txt:
- platform/mac/editing/selection/4983858-expected.checksum:
- platform/mac/editing/selection/4983858-expected.png: Added.
- platform/mac/editing/selection/4983858-expected.txt:
