Timeline
Jul 11, 2014:
- 10:08 PM Changeset in webkit [171020] by
-
- 4 edits in trunk/Source/WebCore
Partition the CSS rules based on the most specific filter of the rightmost fragment
https://bugs.webkit.org/show_bug.cgi?id=134828
Reviewed by Andreas Kling.
Previously, RuleSet was partitioning each rule based on the rightmost filter.
While fast, this had the side effect of putting many selectors with ID match in the class
bucket (because the selectors are generally written starting with the ID).
This patch replace the code of findBestRuleSetAndAdd() by a simple loop going over all
the simple selectors in the rightmost fragment to find the best bucket.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- css/RuleSet.cpp:
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
I unified ruleData.hasRightmostSelectorMatchingHTMLBasedOnRuleHash() and hasMultipartSelector().
(WebCore::RuleData::RuleData):
(WebCore::rulesCountForName):
(WebCore::RuleSet::addRule):
I removed the recursive part of findBestRuleSetAndAdd() (which was wrong anyway). The function
was useless so I just moved the algorithm to addRule() directly.
We first loop over all the CSSSelectors related by SubSelector, this correspond to the rightmost fragment.
If a filter with high specificity is found, we add the rule immediately and end there.
If a filter that is not very specific is found, we keep a pointer to the selector to use it later.
(WebCore::RuleSet::findBestRuleSetAndAdd): Deleted.
- css/RuleSet.h:
(WebCore::RuleData::hasMultipartSelector): Deleted.
- 8:54 PM Changeset in webkit [171019] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Unreviewed build fix after r170937.
- WebCore.vcxproj/WebCoreGeneratedWinCairo.make:
Update and apply changes applied to WebCoreGenerated.make in r170937.
- 6:49 PM Changeset in webkit [171018] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Crash when using a stale InspectableNode Node
https://bugs.webkit.org/show_bug.cgi?id=134849
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-11
Reviewed by Timothy Hatcher.
- inspector/PageConsoleAgent.cpp:
- 5:53 PM Changeset in webkit [171017] by
-
- 5 edits in trunk/Source/WebCore
[MSE] Separate MediaSource logging into its own log channel
https://bugs.webkit.org/show_bug.cgi?id=134809
Reviewed by Eric Carlson.
Separate out MediaSource logging (which can be quite verbose) into its own log channel,
distinct from the Media log channel. Add some per-sample logging and further sequester that
logging into its own MediaSourceSamples log channel.
Add the MediaSource and MediaSourceSamples channels:
- platform/Logging.h:
Move LOG(Media) -> LOG(MediaSource):
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::~MediaSource):
(WebCore::MediaSource::setReadyState):
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::removeSourceBuffer):
(WebCore::MediaSource::isTypeSupported):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime):
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::sourceBufferPrivateDidBecomeReadyForMoreSamples):
(WebCore::SourceBuffer::provideMediaData):
(WebCore::SourceBuffer::monitorBufferingRate):
(WebCore::SourceBuffer::textTrackAddCues):
(WebCore::SourceBuffer::hasFutureTime):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset):
(WebCore::SourceBufferPrivateAVFObjC::didFailToParseStreamDataWithError):
(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame):
(WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID):
(WebCore::SourceBufferPrivateAVFObjC::append):
(WebCore::SourceBufferPrivateAVFObjC::layerDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::flushAndEnqueueNonDisplayingSamples):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
- 4:54 PM Changeset in webkit [171016] by
-
- 2 edits in trunk/Source/WebCore
Phone numbers that span two lines are not detected.
<rdar://problem/17601146> and https://bugs.webkit.org/show_bug.cgi?id=134808
Reviewed by Tim Horton.
- editing/Editor.cpp:
(WebCore::Editor::scanSelectionForTelephoneNumbers): After scanning a range from the TextIterator,
create an "edge range" window around the end of the TextIterator range, and scan it.
Also make sure to not accumulate duplicate ranges that might have showed up in both the
TextIterator range and the edge window range.
- 4:24 PM Changeset in webkit [171015] by
-
- 8 edits in trunk/Source
Implement textStylingAtPosition in WK2.
https://bugs.webkit.org/show_bug.cgi?id=134843
<rdar://problem/17614981>
Source/WebCore:
Reviewed by Benjamin Poulain.
Adding some exports and making styleForSelectionStart public.
- WebCore.exp.in:
- editing/Editor.h:
Source/WebKit2:
Reviewed by Benjamin Poulain.
Adding information about typing attributes to EditorState so
that we can implement textStylingAtPosition.
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView textStylingAtPosition:inDirection:]):
(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView toggleBoldface:]):
(-[WKContentView toggleItalics:]):
(-[WKContentView toggleUnderline:]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
- 3:36 PM Changeset in webkit [171014] by
-
- 9 edits2 adds in trunk
REGRESSION (r168868): eBay 'see all' links fail due to different JS bindings conversion behavior.
https://bugs.webkit.org/show_bug.cgi?id=134841
<rdar://problem/17577563>
Reviewed by Simon Fraser.
Revert back to type int for Element.scroll* APIs in order to preserve exception handling
behavior.
Source/WebCore:
Test: cssom/non-subpixel-scroll-top-left-values.html
- dom/Element.cpp:
(WebCore::Element::scrollLeft):
(WebCore::Element::scrollTop):
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):
(WebCore::Element::scrollWidth):
(WebCore::Element::scrollHeight):
- dom/Element.h:
- dom/Element.idl:
- html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::scrollLeft):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::scrollTop):
(WebCore::HTMLBodyElement::setScrollTop):
(WebCore::HTMLBodyElement::scrollHeight):
(WebCore::HTMLBodyElement::scrollWidth):
- html/HTMLBodyElement.h:
LayoutTests:
- cssom/non-subpixel-scroll-top-left-values-expected.txt: Added.
- cssom/non-subpixel-scroll-top-left-values.html: Added.
- 2:54 PM Changeset in webkit [171013] by
-
- 9 edits in trunk/Source
Web Inspector: Debugger Pause button does not work
https://bugs.webkit.org/show_bug.cgi?id=134785
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- CMakeLists.txt:
- DerivedSources.make:
Minification strips the sourceURL command. Add it back with minification.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- inspector/CommandLineAPIModuleSource.js:
Minification strips the sourceURL command. Add it back with minification.
Source/WebInspectorUI:
Previously we were automatically resuming if we had no recognized
call frames in the call stack we get when paused. However, we
were accidentally skipping over anonymous scripts instead of
just Web Inspector originated call frames.
Now that we allow anonymous scripts we can step into anonymous
scripts (e.g. evals, new Function(...)) as expected.
Also, remove the condition of automatically resuming if the
call stack was empty. The UI handles this with "No Call Frames".
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.debuggerDidPause):
- 2:10 PM Changeset in webkit [171012] by
-
- 2 edits in trunk/Source/WebCore
Use the bare minimum tile coverage rect when under memory pressure.
<https://webkit.org/b/134837>
When the browser is under critical memory pressure, don't generate any
more tiles than are needed to cover the exposed viewport rect.
Reviewed by Pratik Solanki.
- page/FrameView.cpp:
(WebCore::FrameView::computeCoverageRect):
- 2:04 PM Changeset in webkit [171011] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: CSS Autocompletion: "background" only has colors, should support others
https://bugs.webkit.org/show_bug.cgi?id=134839
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-11
Reviewed by Timothy Hatcher.
Update and consolidate the background related CSS properties
and include sub-property completions in the shorthand property.
Also take the opportunity to add or update other properties
(-webkit-alt, -webkit-text-decoration-skip, -webkit-aspect-ratio)
and remove unnecessary newlines / commas in the list.
- UserInterface/Models/CSSKeywordCompletions.js:
- 1:26 PM Changeset in webkit [171010] by
-
- 13 edits2 adds in trunk
[CSS Grid Layout] Implement justify-self css property
https://bugs.webkit.org/show_bug.cgi?id=134419
Reviewed by Dean Jackson.
This change adds the justify-self property from CSS 3 Box Alignment
and implements the parsing.
From Blink r164685 by <jchaffraix@chromium.org>
Source/WebCore:
Test: fast/css/parse-justify-self.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::isItemPositionKeyword):
(WebCore::CSSParser::parseJustifySelf):
- css/CSSParser.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EJustifySelf):
(WebCore::CSSPrimitiveValue::operator EJustifySelfOverflowAlignment):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
- fast/css/parse-justify-self-expected.txt: Added.
- fast/css/parse-justify-self.html: Added.
- 12:47 PM Changeset in webkit [171009] by
-
- 6 edits in tags/Safari-538.46
Rollout r170675. <rdar://problem/17643689>.
- 12:00 PM Changeset in webkit [171008] by
-
- 2 edits in trunk/Source/WebCore
[Feature Queries] Feature Query CSS Grammar Productions Should Return a Value
https://bugs.webkit.org/show_bug.cgi?id=134810
Reviewed by Antti Koivisto.
The parsing return values are used to determine if a feature query is valid. Two
grammar productions have been updated to correctly return a value.
Tests exist for this feature but will not be run until the feature is turned on.
See https://bugs.webkit.org/show_bug.cgi?id=134404.
- css/CSSGrammar.y.in: Adding return values for two valid feature query productions.
- 11:56 AM Changeset in webkit [171007] by
-
- 2 edits in tags/Safari-538.46/Source/WebKit2
Merged r171003. <rdar://problem/17642184>
- 11:54 AM Changeset in webkit [171006] by
-
- 10 edits in tags/Safari-538.46
Merged r171001. <rdar://problem/17435776>
- 11:53 AM Changeset in webkit [171005] by
-
- 7 edits in trunk/Source
[Win] Enable DFG JIT.
https://bugs.webkit.org/show_bug.cgi?id=123615
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-07-11
Reviewed by Mark Lam.
Source/JavaScriptCore:
When the return type of a JIT generated function call is larger than 64-bit (e.g. SlowPathReturnType),
the normal call() implementation cannot be used on 64-bit Windows, because the 64-bit Windows ABI is different in this case.
Also, when generating calls with double arguments, we need to make sure the arguments are put in the correct registers,
since the register allocation differs on 64-bit Windows.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::callWithSlowPathReturnType): Added method to handle function calls where the return value type size is larger than 64-bit.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState): Move arguments to correct registers when there are floating point arguments.
(JSC::CCallHelpers::setupArgumentsWithExecStateForCallWithSlowPathReturnType): Added method.
- jit/JIT.h:
(JSC::JIT::appendCallWithSlowPathReturnType): Added method.
- jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheckAndSlowPathReturnType): Added method.
(JSC::JIT::callOperation): Call new method.
Source/WTF:
- wtf/Platform.h:
- 10:32 AM Changeset in webkit [171004] by
-
- 11 edits in trunk
Use a separate backdrop element to allow cues to have highlight and background color
https://bugs.webkit.org/show_bug.cgi?id=134821
<rdar://problem/15999721>
Reviewed by Eric Carlson.
Source/WebCore:
Add a new <div> element wrapping the existing cue <span>. This allows
us to have a highlight on the cue (in the <span> background), as well
as an overall background color.
- Modules/mediacontrols/mediaControlsApple.css:
(video::-webkit-media-text-track-display-backdrop): New markup for
the backdrop element of the caption.
- html/track/VTTCue.cpp:
(WebCore::VTTCue::cueBackdropShadowPseudoId): Added to
allow user customization of the cue backdrop.
(WebCore::VTTCue::initialize): Rename the old "m_cueBackgroundBox" to
"m_cueHighlightBox" and add a new "m_cueBackdropBox" member.
(WebCore::VTTCue::updateDisplayTree): Update for m_cueHighlightBox.
(WebCore::VTTCue::getDisplayTree): Make m_cueHighlightBox a child
of the new m_cueBackdropBox element, and add m_cueBackdropBox to
the display tree.
- html/track/VTTCue.h:
(WebCore::VTTCue::element):
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges):
Fix for missing caption style updates. Even if we are already
listening for caption changes, we still want to update the new
instance's style sheet to match.
(WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride):
- rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::initializeLayoutParameters): Take the new
<div> into consideration when looking for the Cue text element.
LayoutTests:
Updated tests for new formatting logic.
- platform/mac/media/track/track-cue-rendering-horizontal-expected.png:
- platform/mac/media/track/track-cue-rendering-horizontal-expected.txt:
- 10:15 AM Changeset in webkit [171003] by
-
- 2 edits in trunk/Source/WebKit2
Tighten WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=134834
Reviewed by Sam Weinig.
Define a much tighter sandbox profile for the WebContent process
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 9:29 AM Changeset in webkit [171002] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r170163?): Web content shifts revealing space equivalent to the find bar when clicking a link while a phrase is targeted via Cmd+F
https://bugs.webkit.org/show_bug.cgi?id=134833
<rdar://problem/17580021>
Reviewed by Zalan Bujtas.
Some versions of OS X Safari can't handle the new unfreeze timing. Revert back to DidFirstLayout on Mac.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
- 8:27 AM Changeset in webkit [171001] by
-
- 10 edits in trunk
Subpixel layout: return integral results for offset*, client*, scroll* by default.
https://bugs.webkit.org/show_bug.cgi?id=134651
Reviewed by Simon Fraser.
Revert to returning integral values for Element.offset* client* scroll* by default.
Fractional values break number of sites(tight design) and JS frameworks(fail to handle fractional values).
Since snapped dimension depends on both the original point and the width/height of the box,
we need to call RenderBoxModelObject::pixelSnapped*() helpers, instead of round().
Covered by existing tests
Source/WebCore:
- dom/Element.cpp:
(WebCore::subpixelMetricsEnabled):
(WebCore::convertToNonSubpixelValueIfNeeded):
(WebCore::Element::offsetLeft):
(WebCore::Element::offsetTop):
(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::clientLeft):
(WebCore::Element::clientTop):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
- page/Settings.in:
Source/WebKit/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferencesRefPrivate.h:
LayoutTests:
- cssom/subpixel-offsetleft-top-width-height-values-expected.txt:
- 7:19 AM Changeset in webkit [171000] by
-
- 4 edits2 adds in trunk
Subpixel rendering: icloud.com password arrow has clipped circle at some window sizes.
https://bugs.webkit.org/show_bug.cgi?id=134824
<rdar://problem/17612729>
Reviewed by Simon Fraser.
Transparent layer clipping needs device pixel offset adjusting.
Source/WebCore:
Test: fast/layers/wrong-clipping-semi-transparent-compositing-layer-on-subpixel-position.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
- rendering/RenderLayer.h:
LayoutTests:
- fast/layers/wrong-clipping-semi-transparent-compositing-layer-on-subpixel-position-expected.html: Added.
- fast/layers/wrong-clipping-semi-transparent-compositing-layer-on-subpixel-position.html: Added.
- 5:26 AM Changeset in webkit [170999] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r170995.
https://bugs.webkit.org/show_bug.cgi?id=134831
Causing odd crashes in debug builds (Requested by zdobersek on
#webkit).
Reverted changeset:
"[WTF] Add the move constructor, move assignment operator for
HashTable"
https://bugs.webkit.org/show_bug.cgi?id=130772
http://trac.webkit.org/changeset/170995
- 5:15 AM Changeset in webkit [170998] by
-
- 1 edit1 delete in trunk/Source/WebCore
Unreviewed. Remove unused file.
- html/shadow/MediaControlsGtk.h: Removed.
- 5:12 AM Changeset in webkit [170997] by
-
- 2 edits in trunk
[GTK] Enable VIDEO_TRACK by default
https://bugs.webkit.org/show_bug.cgi?id=134801
Reviewed by Philippe Normand.
- Source/cmake/OptionsGTK.cmake:
- 3:42 AM Changeset in webkit [170996] by
-
- 33 edits in trunk
[CSS Grid Layout] Update grid-auto-flow to the new syntax
https://bugs.webkit.org/show_bug.cgi?id=134057
Reviewed by Sergio Villar Senin.
Source/WebCore:
In last versions of the spec grid-auto-flow syntax has changed. New
syntax is:
[ row | column ] && dense? | stack && [ row | column ]?
Implemented parsing for new syntax and added/modified test cases in
current layout tests.
For the moment, the implementation keeps working in the same way, but
using "stack" value for grid-auto-flow property instead of "none". This
should be fixed in a follow-up patch once "stack" is properly
implemented.
Also "dense" needs to be reviewed. Right now auto-placement algorithm is
always "dense" and never "sparse".
No new tests, update current tests to add new cases.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Adapt to new syntax.
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue): Removed grid-auto-flow as it
is not a keyword anymore.
(WebCore::isKeywordPropertyID): Ditto.
(WebCore::CSSParser::parseValue): Add specific method for parsing
grid-auto-flow.
(WebCore::CSSParser::parseGridShorthand): Adapt parsing for
grid-auto-flow property inside the shorthand.
(WebCore::isValidGridAutoFlowId): Helper method to check if the CSSValue
id is a valid keyword for grid-auto-flow property.
(WebCore::CSSParser::parseGridAutoFlow): Implement new parsing for
grid-auto-flow.
- css/CSSParser.h: Method header for grid-auto-flow parsing.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator GridAutoFlow): Deleted.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Deleted.
- css/CSSValueKeywords.in: Add new keywords required by grid-auto-flow:
"dense" and "stack".
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): Remove
default handler as grid-auto-flow is not a keyword now.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty): Implement particular handler
for new grid-auto-flow syntax.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::placeItemsOnGrid): Keep old "none" behavior as
"stack" behavior for the moment.
(WebCore::RenderGrid::autoPlacementMajorAxisDirection): Use the new
helper methods in RenderStyle.
(WebCore::RenderGrid::autoPlacementMinorAxisDirection): Ditto.
- rendering/style/GridResolvedPosition.cpp:
(WebCore::GridResolvedPosition::resolveGridPositionsFromStyle): Again
keep old "none" behavior for "stack".
- rendering/style/RenderStyle.h: Add new helper methods to know the
direction and algorithm of grid-auto-flow property.
- rendering/style/RenderStyleConstants.h: Redefine GridAutoFlow enum
using flags for algorithm and direction.
- rendering/style/StyleGridData.h: Change m_gridAutoFlow type to
unsigned.
LayoutTests:
Adapted current tests to the new syntax. Keeping old "none" behavior
using "stack".
Add new use cases to cover the new syntax to grid-auto-flow-get-set.html
and grid-shorthand-get-set.html.
- fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
- fast/css-grid-layout/grid-auto-flow-get-set.html:
- fast/css-grid-layout/grid-auto-flow-resolution.html:
- fast/css-grid-layout/grid-auto-flow-update-expected.txt:
- fast/css-grid-layout/grid-auto-flow-update.html:
- fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
- fast/css-grid-layout/grid-item-z-index-change-repaint.html:
- fast/css-grid-layout/grid-item-z-index-stacking-context.html:
- fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
- fast/css-grid-layout/grid-shorthand-get-set.html:
- fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html:
- fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
- fast/css-grid-layout/resources/grid.css:
(.gridAutoFlowStack):
(.gridAutoFlowNone): Deleted.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- ietestcenter/css3/grid/grid-column-001.htm:
- ietestcenter/css3/grid/grid-column-002.htm:
- ietestcenter/css3/grid/grid-column-003.htm:
- svg/css/getComputedStyle-basic-expected.txt:
- 1:16 AM Changeset in webkit [170995] by
-
- 2 edits in trunk/Source/WTF
[WTF] Add the move constructor, move assignment operator for HashTable
https://bugs.webkit.org/show_bug.cgi?id=130772
Reviewed by Darin Adler.
HashTable has both copy constructor and copy assignment operator, meaning that the move constructor
and move assignment operator are implicitly deleted. This patch defines both to avoid unnecessary
copies when moves can be performed.
- wtf/HashTable.h:
(WTF::KeyTraits>::HashTable):
Jul 10, 2014:
- 11:17 PM Changeset in webkit [170994] by
-
- 10 edits in tags/Safari-538.46/Source
Merge patch from <rdar://problem/17631537>.
- 11:01 PM Changeset in webkit [170993] by
-
- 5 edits in trunk/Source
Versioning.
- 10:57 PM Changeset in webkit [170992] by
-
- 1 copy in tags/Safari-538.46
New Tag.
- 10:06 PM Changeset in webkit [170991] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Debugger Continue button is incorrectly sized
https://bugs.webkit.org/show_bug.cgi?id=134786
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-10
Reviewed by Timothy Hatcher.
Before this patch everything in the DebuggerDashboardView was flexing.
Normally, if the contents were not too wide, this would just behave
as expected and be centered. If the content was too wide, then each
element would flex uniformly and overlap uniformly. That was not expected.
This patch changes makes everything but the link have a non-flexible
size. If the link (at the end) flexs it will have a nice ellipsis
text truncation, and the rest of the content will be left justified.
This also fixes a few other minor issues seen in the view.
- UserInterface/Views/DebuggerDashboardView.css:
(.dashboard.debugger .navigation-bar):
Reduce the complexity, give the nav bar (the resume button) some simple padding.
(.dashboard.debugger > div):
Make everything non-flex by default.
(.dashboard.debugger > .location):
The location will have an inner element flex, so make it flex.
(.dashboard.debugger > .location > *):
Make everything in .location non-flex by default.
(.dashboard.debugger > .location .go-to-link):
Make the link flex and truncate cleanly.
(.dashboard.debugger > .location .function-name):
Fix vertical alignment when the toolbar has small icons.
- UserInterface/Views/DebuggerDashboardView.js:
(WebInspector.DebuggerDashboardView.prototype._rebuildLocation):
Fix class name spelling.
- 9:26 PM Changeset in webkit [170990] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix after r170970.
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformDefaultOpenGLCacheDirectory):
- 8:50 PM Changeset in webkit [170989] by
-
- 4 edits in trunk/Source/WebKit2
REGRESSION(r170970) REGRESSION(r170974): [GTK] Build broken.
https://bugs.webkit.org/show_bug.cgi?id=134825
Unreviewed GTK build fix.
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-07-10
- Shared/SessionState.h: Put ifdefs for ViewSnapshot on Mac port.
- Shared/WebBackForwardListItem.h: Idem.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultOpenGLCacheDirectory): Implement skeleton.
- 7:29 PM Changeset in webkit [170988] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] It should be safe to call WKContentViewInteraction's cleanupInteraction multiple times
https://bugs.webkit.org/show_bug.cgi?id=134820
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-10
Reviewed by Andreas Kling.
If a view is destroyed just after a crash, "cleanupInteraction" is called twice: once on crash,
once on dealloc.
The code handling _interactionViewsContainerView is using KVO to monitor transform changes. It is not safe
to remove the observer if we are not already observing on that view.
To solve the problem, this patch makes the cleanup actually remove the view so that setup and cleanup
are completely symmetrical. If cleanup is called twice, the second time would not enter the branch because
the view is already nil.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
- 5:49 PM Changeset in webkit [170987] by
-
- 3 edits2 adds in trunk/Source/WebKit2
[iOS WK2] Move WKInspectorHighlightView to its own file
https://bugs.webkit.org/show_bug.cgi?id=134819
Reviewed by Joseph Pecoraro.
WKInspectorHighlightView brought a lot of path/quad-related code into WKContentView.mm,
so move it into its own file.
- UIProcess/WKInspectorHighlightView.h: Added.
- UIProcess/WKInspectorHighlightView.mm: Added.
(-[WKInspectorHighlightView dealloc]):
(-[WKInspectorHighlightView _removeAllLayers]):
(-[WKInspectorHighlightView _createLayers:]):
(findIntersectionOnLineBetweenPoints):
(quadIntersection):
(layerPathWithHole):
(layerPath):
(-[WKInspectorHighlightView _layoutForNodeHighlight:]):
(-[WKInspectorHighlightView _layoutForRectsHighlight:]):
(-[WKInspectorHighlightView update:]):
- UIProcess/ios/WKContentView.mm:
(-[WKInspectorHighlightView initWithFrame:]): Deleted.
(-[WKInspectorHighlightView dealloc]): Deleted.
(-[WKInspectorHighlightView _removeAllLayers]): Deleted.
(-[WKInspectorHighlightView _createLayers:]): Deleted.
(findIntersectionOnLineBetweenPoints): Deleted.
(quadIntersection): Deleted.
(layerPathWithHole): Deleted.
(layerPath): Deleted.
(-[WKInspectorHighlightView _layoutForNodeHighlight:]): Deleted.
(-[WKInspectorHighlightView _layoutForRectsHighlight:]): Deleted.
(-[WKInspectorHighlightView update:]): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 5:12 PM Changeset in webkit [170986] by
-
- 5 edits3 adds in trunk
[iOS] Pasting rich content does not perform a two-step paste
https://bugs.webkit.org/show_bug.cgi?id=134795
Reviewed by Benjamin Poulain.
Source/WebCore:
UIKit requires writing something (anything!) to a particular pasteboard
during copy in order to flag the content as rich. When a paste occurs,
UIKit will read this flag and perform a two-step paste.
Test: platform/ios-sim/editing/pasteboard/two-step-paste.html
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::write):
LayoutTests:
Copy and paste some text, and make sure that the two step paste occurred.
The mechanism for detecting this is whether or not styles have changed appropriately.
- platform/ios-sim/editing/pasteboard/two-step-paste-expected.txt: Added.
- platform/ios-sim/editing/pasteboard/two-step-paste.html: Added.
Tools:
Two-step paste requires setting InputViewObeysDOMFocus on the UIWebBrowserView.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
- 5:04 PM Changeset in webkit [170985] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Update the ChangeLog per Pratik's review comments
- 5:02 PM Changeset in webkit [170984] by
-
- 5 edits in trunk/Source
[iOS] Some QuickLook documents are not displayed as previews
https://bugs.webkit.org/show_bug.cgi?id=134788
Reviewed by Pratik Solanki.
ResourceRequest::isMainResourceRequest() is not reliable (e.g. ResourceRequests reconstituted from an
NSURLRequest have no way to set this bit properly) and should probably be removed. Instead of using
isMainResourceRequest() to check if a QuickLookHandle should be created when the Network Process is in use,
just check if the current ResourceLoader is the same as the DocumentLoader's ResourceLoader.
No new tests. QuickLook is not testable from WebKit.
- platform/network/ios/QuickLook.mm:
(WebCore::QuickLookHandle::create):
- 4:57 PM Changeset in webkit [170983] by
-
- 2 edits in tags/Safari-538.45.1/Source/WebKit2
Merged r170979. <rdar://problem/17632687>
- 4:46 PM Changeset in webkit [170982] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r170935): WKWebView is always transparent until the first layer tree commit
https://bugs.webkit.org/show_bug.cgi?id=134818
<rdar://problem/17632468>
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(scrollViewBackgroundColor):
r170935 made it so that we would initialize the scroll view background color to an
invalid color until the first layer tree commit. We should go with white instead.
- 4:26 PM Changeset in webkit [170981] by
-
- 12 edits in trunk/Source/WebKit2
Add a mechanism to notify the UIProcess when an editing command is done executing.
https://bugs.webkit.org/show_bug.cgi?id=134807
Reviewed by Tim Horton.
Some editing commands have an effect on some parts of the system that
run inside the UIProcess. A good example are the cursor movement commands
that require an update of the autocorrection/autosuggestion machinery.
This patch adds a way to reliably know when the command has been executed
in the WebProcess. A previous attempt at solving this problem was added in
r170858 and was partially reverted in r170948.
The change also removes the selectionWillChange notification added in r170858.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::editorStateChanged):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::selectionWillChange): Deleted.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView executeEditCommandWithCallback:]):
(-[WKContentView _moveUp:withHistory:]):
(-[WKContentView _moveDown:withHistory:]):
(-[WKContentView _moveLeft:withHistory:]):
(-[WKContentView _moveRight:withHistory:]):
(-[WKContentView _moveToStartOfWord:withHistory:]):
(-[WKContentView _moveToStartOfParagraph:withHistory:]):
(-[WKContentView _moveToStartOfLine:withHistory:]):
(-[WKContentView _moveToStartOfDocument:withHistory:]):
(-[WKContentView _moveToEndOfWord:withHistory:]):
(-[WKContentView _moveToEndOfParagraph:withHistory:]):
(-[WKContentView _moveToEndOfLine:withHistory:]):
(-[WKContentView _moveToEndOfDocument:withHistory:]):
(-[WKContentView _selectionWillChange]): Deleted.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::executeEditCommand):
(WebKit::WebPageProxy::notifySelectionWillChange): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::executeEditCommandWithCallback):
- 4:20 PM Changeset in webkit [170980] by
-
- 4 edits in trunk/Source
[Mac] NSWindow warning: adding an unknown subview opening detached Inspector
https://bugs.webkit.org/show_bug.cgi?id=134813
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-10
Reviewed by Timothy Hatcher.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController window]):
Use a selector that will avoid the warning message.
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow):
Use a selector that will avoid the warning message.
- 4:17 PM Changeset in webkit [170979] by
-
- 2 edits in trunk/Source/WebKit2
Remove use of container relative restrictions in the network process sandbox
https://bugs.webkit.org/show_bug.cgi?id=134816
Reviewed by Anders Carlsson.
As i'm tidying up the various sandboxes and that's meaning we
need to reduce some file restrictions in the network process.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- 3:26 PM Changeset in webkit [170978] by
-
- 2 edits in trunk/Source/WebCore
[iOS WebKit2] Don't uninstall the memory pressure listener after first signal.
<https://webkit.org/b/134814>
The call to uninstall() should not be made on iOS since iOS doesn't use the
hold-off mechanism in MemoryPressureHandler.
Reviewed by Benjamin Poulain.
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
- 2:35 PM Changeset in webkit [170977] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed iOS build fix after r170974. Define id if building a non ObjC file.
- UIProcess/mac/ViewSnapshotStore.h:
- 2:28 PM Changeset in webkit [170976] by
-
- 5 edits in trunk/Source/WebCore
[MSE] Overlapping appended ranges must cause the decoder to flush and re-enqueue.
https://bugs.webkit.org/show_bug.cgi?id=134805
Reviewed by Eric Carlson.
When appending a range of media data which overlaps with an existing range, SourceBuffer
must cause the decoder to flush and re-enqueue samples. Those samples removed by appending
the overlapping range may have already been enqueued for display, and unless the decode
queue is flushed, corruption or decode errors may occur as the new samples are enqueued for
display.
Add a boolean flag onto TrackBuffer to indicate whether the decoder needs to be flushed and
re-enqueued the next time an append operation completes. Set this flag whenever samples are
removed due to overlapping or an explicit call to removeCodedFrames(). Move the contents of
sourceBufferPrivateSeekToTime() (which previously did flushing and re-enqueueing) into a new
function, reenqueueMediaForTime(), which can be called from sourceBufferPrivateAppendComplete().
Drive-by fix: findSyncSampleAfterDecodeIterator() would return the passed in iterator if that
sample is a sync-sample. Fix this to correctly return the next sync sample.
Drive-by fix: Use a SampleMap, rather than a DecodeOrderSampleMap, to track erased samples
so that the erasedSamples are correctly accounted for in both presentation and decode orders.
- Modules/mediasource/SampleMap.cpp:
(WebCore::SampleMap::empty): Add convenience method.
(WebCore::DecodeOrderSampleMap::findSyncSampleAfterDecodeIterator): Drive-by fix.
- Modules/mediasource/SampleMap.h:
(WebCore::SampleMap::decodeOrder): Added const accessor.
(WebCore::SampleMap::presentationOrder): Ditto.
(WebCore::SampleMap::addRange): Added.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::TrackBuffer::TrackBuffer): Add needsReenqueeing flag.
(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime): Move contents into reenqueueMediaForTime().
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Call reenqueMediaForTime() if necessary.
(WebCore::SourceBuffer::removeCodedFrames): Set needsReenqueing.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
(WebCore::SourceBuffer::provideMediaData): Drive-by fix.
(WebCore::SourceBuffer::reenqueueMediaForTime): Moved from sourceBufferPrivateSeekToTime().
- Modules/mediasource/SourceBuffer.h:
- 1:48 PM Changeset in webkit [170975] by
-
- 2 edits in trunk/Source/WebCore
ASSERT in SharedBuffer::maybeAppendDataArray() on MobileSafari launch
https://bugs.webkit.org/show_bug.cgi?id=134812
<rdar://problem/17628434>
Reviewed by Joseph Pecoraro.
Fix bug in my fix in r170930. Initialize the badly named m_shouldUsePurgeableMemory field to
false. This field indicates when it is okay to use purgeable memory and is set to true once
the resource is finished loading. By setting it to true in the constructor we were creating
purgeable memory while the resource was still being loaded and this triggered the assert.
No new tests. Should be covered by existing tests.
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::SharedBuffer):
- 1:33 PM Changeset in webkit [170974] by
-
- 20 edits in trunk/Source/WebKit2
Store ViewSnapshots directly on the WebBackForwardListItem
https://bugs.webkit.org/show_bug.cgi?id=134667
<rdar://problem/17082639>
Reviewed by Dan Bernstein.
Make ViewSnapshot a refcounted class. Store it directly on the back-forward item
instead of in a side map referenced by UUID. Switch to a very simple LRU eviction model for now.
This fixes a ton of snapshot management bugs; for example, we would start throwing out snapshots
in the page that was actively being interacted with *first* when evicting snapshots, instead of
preferring older snapshots. Additionally, we would not throw away snapshots when back forward items
became unreachable.
There is definitely room for improvement of the eviction mechanism, but this is closer to a time-tested implementation.
- Shared/SessionState.h:
Keep a ViewSnapshot instead of a UUID on the BackForwardListItemState.
- Shared/WebBackForwardListItem.h:
Fix some indented namespace contents.
(WebKit::WebBackForwardListItem::snapshot):
(WebKit::WebBackForwardListItem::setSnapshot):
(WebKit::WebBackForwardListItem::setSnapshotUUID): Deleted.
(WebKit::WebBackForwardListItem::snapshotUUID): Deleted.
Switch the snapshot getter/setter to operate on ViewSnapshots instead of UUIDs.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _takeViewSnapshot]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _takeViewSnapshot]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::takeViewSnapshot):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::takeViewSnapshot):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::takeViewSnapshot):
Adopt ViewSnapshot::create, return a PassRefPtr, and class-ify ViewSnapshot.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::endSwipeGesture):
- UIProcess/mac/ViewGestureController.h:
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::shouldUseSnapshotForSize):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::endSwipeGesture):
Grab the ViewSnapshot directly from the WebBackForwardListItem, and adopt the new functions.
- UIProcess/ios/WebMemoryPressureHandlerIOS.mm:
(WebKit::WebMemoryPressureHandler::WebMemoryPressureHandler):
Rename discardSnapshots to discardSnapshotImages, because we're really only discarding
the images; the render tree size/background color "snapshot" remains and is useful.
- UIProcess/mac/ViewSnapshotStore.h:
(WebKit::ViewSnapshot::setRenderTreeSize):
(WebKit::ViewSnapshot::renderTreeSize):
(WebKit::ViewSnapshot::setBackgroundColor):
(WebKit::ViewSnapshot::backgroundColor):
(WebKit::ViewSnapshot::setDeviceScaleFactor):
(WebKit::ViewSnapshot::deviceScaleFactor):
(WebKit::ViewSnapshot::imageSizeInBytes):
(WebKit::ViewSnapshot::surface):
(WebKit::ViewSnapshot::size):
(WebKit::ViewSnapshot::creationTime):
Make ViewSnapshot a refcounted class.
Add create functions which take an image (or slot ID), and relevant sizes.
It is expected that a ViewSnapshot is created with an image, and it is only possible
to remove that image, never to replace it. A new ViewSnapshot is required in that case.
Add setters for things that ViewSnapshotStore sets on the snapshot after the PageClient
retrieves it from the view. Add getters for things that the ViewGestureControllers need.
Remove removeSnapshotImage, getSnapshot, and the snapshot map.
- UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::~ViewSnapshotStore):
(WebKit::ViewSnapshotStore::didAddImageToSnapshot):
(WebKit::ViewSnapshotStore::willRemoveImageFromSnapshot):
Manage m_snapshotCacheSize and m_snapshotsWithImages via didAddImageToSnapshot and willRemoveImageFromSnapshot.
willRemoveImageFromSnapshot will -always- be called before the ViewSnapshot is destroyed.
(WebKit::ViewSnapshotStore::pruneSnapshots):
Switch to a simple LRU eviction model. As previously mentioned, it's possible to do better, but
this is much less broken than the previous implementation.
(WebKit::ViewSnapshotStore::recordSnapshot):
(WebKit::ViewSnapshotStore::discardSnapshotImages):
(WebKit::ViewSnapshot::create):
(WebKit::ViewSnapshot::ViewSnapshot):
(WebKit::ViewSnapshot::~ViewSnapshot):
(WebKit::ViewSnapshot::hasImage):
(WebKit::ViewSnapshot::clearImage):
(WebKit::ViewSnapshot::asLayerContents):
If a surface is Empty when it comes back from being volatile, throw away the surface
and notify the Store to remove it from m_snapshotCacheSize (via clearImage()).
(WebKit::ViewSnapshotStore::removeSnapshotImage): Deleted.
(WebKit::ViewSnapshotStore::getSnapshot): Deleted.
(WebKit::ViewSnapshotStore::discardSnapshots): Deleted.
- 1:24 PM Changeset in webkit [170973] by
-
- 4 edits in trunk/Source/WebCore
[iOS WebKit2] Some memory pressure relief tweaks.
<https://webkit.org/b/134811>
Split memory pressure relief into critical and non-critical sections.
Non-critical relief is for clearing out things that are really not
essential, e.g unused font data, text measurement caches, etc.
On iOS, only flip the "WebKit is under memory pressure" flag when we
are under *critical* memroy pressure, rather than doing it early on
and gimping ourselves because other processes are too big.
Also added logging for when we transition in/out of system pressure.
Reviewed by Geoffrey Garen.
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseNoncriticalMemory):
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
(WebCore::MemoryPressureHandler::releaseMemory):
- platform/MemoryPressureHandler.h:
(WebCore::MemoryPressureHandler::ReliefLogger::loggingEnabled):
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
- 1:04 PM Changeset in webkit [170972] by
-
- 16 edits in trunk/Source
Need Setting/WKPreference that allows clients to prevent scrollbars from drawing
on a secondary thread
https://bugs.webkit.org/show_bug.cgi?id=134778
-and corresponding-
<rdar://problem/17595333>
Reviewed by Tim Horton.
Source/WebCore:
This is a requirement for some types of performance tests. The patch adds a new
virtual function to ScrollableArea that forces subclasses to indicate the value of
the Setting. This is required because Scrollbar and ScrollableArea can’t get to
Settings on their own.
- page/FrameView.cpp:
(WebCore::FrameView::forceUpdateScrollbarsOnMainThreadForPerformanceTesting):
- page/FrameView.h:
- page/Settings.in:
- platform/ScrollableArea.h:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::supportsUpdateOnSecondaryThread):
- platform/win/PopupMenuWin.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::forceUpdateScrollbarsOnMainThreadForPerformanceTesting):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::forceUpdateScrollbarsOnMainThreadForPerformanceTesting):
- rendering/RenderListBox.h:
Source/WebKit2:
This is a requirement for some types of performance tests.
New pref.
- Shared/WebPreferencesDefinitions.h:
PDFPlugin has to implement this new ScrollableArea virtual function to indicate
the Setting’s value.
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::forceUpdateScrollbarsOnMainThreadForPerformanceTesting):
New pref.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 12:31 PM Changeset in webkit [170971] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Frequent assertion failures when swiping back
Reviewed by Dan Bernstein.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::dispatchAfterEnsuringDrawing):
Don't create an unused VoidCallback. It will assert when destroyed without being called.
- 11:33 AM Changeset in webkit [170970] by
-
- 7 edits in trunk/Source/WebKit2
Pass sandbox extension for GL cache over to webprocess
https://bugs.webkit.org/show_bug.cgi?id=134806
Reviewed by Anders Carlsson.
Add additional WebProcess parameters to pass an extension
that allows access to the opengl cache directory in the
host application's container.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::openGLCacheDirectory):
- UIProcess/WebContext.h:
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultOpenGLCacheDirectory):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 11:24 AM Changeset in webkit [170969] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fix my mis-merged ChangeLog from r170966
- 10:52 AM Changeset in webkit [170968] by
-
- 4 edits in trunk
Enable same features on all Windows ports.
https://bugs.webkit.org/show_bug.cgi?id=134715
Patch by Alex Christensen <achristensen@webkit.org> on 2014-07-10
Reviewed by Brent Fulgham.
Source/WTF:
- wtf/Platform.h:
Use REQUEST_ANIMATION_FRAME_TIMER on WinCairo.
WebKitLibraries:
- win/tools/vsprops/FeatureDefinesCairo.props:
Made identical to FeatureDefines.props.
- 10:07 AM Changeset in webkit [170967] by
-
- 2 edits in trunk/Source/WebKit2
iOS build fix.
- WebProcess/WebPage/ServicesOverlayController.h:
- 9:19 AM Changeset in webkit [170966] by
-
- 6 edits in trunk/Source
Phone number highlights should always be visible if the mouse hovers over.
<rdar://problem/17527476> and https://bugs.webkit.org/show_bug.cgi?id=134784
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
This is a fairly extensive rewrite of ServicesOverlayController.
It allows one selection highlight for the entire selection, and as many telephone number highlights as there are numbers.
If a telephone number highlight is hovered over, it wins and is painted.
If no telephone number highlight is hovered but the selection highlight is, then it is painted.
The purposes of each method are self evident by their name, and the concepts are mostly the same as they used to be.
The exception is establishHoveredTelephoneHighlight which gets a more detailed explanation below.
- Platform/Logging.h: Add a Services logging channel.
- WebProcess/WebPage/ServicesOverlayController.h:
(WebKit::TelephoneNumberData::TelephoneNumberData):
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::selectionRectsDidChange):
(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
(WebKit::ServicesOverlayController::clearHighlightState):
(WebKit::ServicesOverlayController::drawRect):
(WebKit::ServicesOverlayController::drawSelectionHighlight):
(WebKit::ServicesOverlayController::maybeDrawTelephoneNumberHighlight):
(WebKit::ServicesOverlayController::drawHighlight):
(WebKit::ServicesOverlayController::clearSelectionHighlight):
(WebKit::ServicesOverlayController::clearHoveredTelephoneNumberHighlight):
(WebKit::ServicesOverlayController::establishHoveredTelephoneHighlight): Starts walking the telephone number ranges and
creating a highlight for each one that doesn’t already have a highlight. If that highlight is also being hovered by
the mouse, then it is set as the hovered telephone number highlight and the method stops creating new highlights.
(WebKit::ServicesOverlayController::maybeCreateSelectionHighlight):
(WebKit::ServicesOverlayController::mouseEvent):
(WebKit::ServicesOverlayController::handleClick):
(WebKit::ServicesOverlayController::drawTelephoneNumberHighlight): Deleted.
(WebKit::ServicesOverlayController::drawCurrentHighlight): Deleted.
- 9:13 AM Changeset in webkit [170965] by
-
- 5 edits in trunk
[GTK][CMake] Add a 'distcheck' target
https://bugs.webkit.org/show_bug.cgi?id=130675
.:
Reviewed by Gustavo Noronha Silva.
- Source/PlatformGTK.cmake: Add distcheck target.
Tools:
Patch by Carlos Garcia Campos <cgarcia@igalia.com> and Martin Robinson <mrobinson@igalia.com> on 2014-07-10
Reviewed by Gustavo Noronha Silva.
Add --check option to make-dist script that builds and installs the tarball.
- gtk/make-dist.py:
(Distcheck.init):
(Distcheck.extract_tarball): Extratc the tarball.
(Distcheck.configure): Run cmake.
(Distcheck.configure.create_dir): Helper function to create a directory.
(Distcheck.build): Run make.
(Distcheck.install): Run make install.
(Distcheck.clean): Clean up the extracted tarball.
(Distcheck.check): Run all previous methods in order.
- gtk/manifest.txt: Add missing file.
- 9:11 AM Changeset in webkit [170964] by
-
- 4 edits1 add in trunk
[GTK] Use the same default options for production builds that previous stable releases
https://bugs.webkit.org/show_bug.cgi?id=134589
Reviewed by Martin Robinson.
.:
Change the default value of some features to match our stable releases.
Add FindCairoGL to find cairo-gl libraries and make accelearetd 2D
canvas depend on whether cairo-gl is found.
- Source/cmake/FindCairoGL.cmake: Added.
- Source/cmake/OptionsGTK.cmake:
Tools:
Make sure all features enabled in production builds are also
enabled in developer mode.
- Scripts/webkitperl/FeatureList.pm: Enable ACCELERATED_2D_CANVAS
and CSS_FILTERS for the GTK port.
- 8:39 AM Changeset in webkit [170963] by
-
- 4 edits in trunk/Source
Assertions or crashes under _takeViewSnapshot when restoring windows
https://bugs.webkit.org/show_bug.cgi?id=134792
Reviewed by Simon Fraser.
- UIProcess/API/mac/WKView.mm:
(-[WKView _takeViewSnapshot]):
Taking a window-server snapshot of a non-visible window tends to not succeed.
- platform/graphics/cocoa/IOSurface.mm:
(IOSurface::createFromImage):
- 5:23 AM Changeset in webkit [170962] by
-
- 1 edit4 adds in trunk/LayoutTests
[EFL] Unreviewed EFL gardening.
Rebaseline tests after r170304 and r170619.
- platform/efl/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.png: Added after r170304.
- platform/efl/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt: Added after r170304.
- platform/efl/fast/text/indic-expected.png: Added after r170619.
- platform/efl/fast/text/indic-expected.txt: Added after r170619.
- 5:14 AM Changeset in webkit [170961] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] Unreviewed EFL gardening.
Rebaseline tests after r170207.
- platform/efl/fast/text/khmer-lao-font-expected.txt: Added.
- 3:09 AM Changeset in webkit [170960] by
-
- 3 edits3 adds in trunk
[XHR] overrideMimeType() should be able to change encoding in HEADERS RECEIVED state
https://bugs.webkit.org/show_bug.cgi?id=128968
Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-07-10
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Moved response encoding computation from didReceiveResponse to didReceiveData, just before the decoder is instantiated.
This allows overrideMimeType to be changed within readystatechange event callback and have an impact on selected encoding.
Test: http/tests/xmlhttprequest/overridemimetype-headers-received-state-force-shiftjis.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didReceiveResponse): Removed m_responseEncoding computation from response and mimeTypeOverride.
(WebCore::XMLHttpRequest::didReceiveData): Added m_responseEncoding computation from response and mimeTypeOverride.
LayoutTests:
Added test equivalent to http://w3c-test.org/web-platform-tests/master/XMLHttpRequest/overridemimetype-headers-received-state-force-shiftjis.htm
The test sets overrideMimeType when xhr state is changed to HEADERS RECEIVED.
- http/tests/xmlhttprequest/overridemimetype-headers-received-state-force-shiftjis-expected.txt: Added.
- http/tests/xmlhttprequest/overridemimetype-headers-received-state-force-shiftjis.html: Added.
- http/tests/xmlhttprequest/resources/get-content.php: Added.
Jul 9, 2014:
- 11:35 PM Changeset in webkit [170959] by
-
- 2 edits in tags/Safari-538.45.1/Source/WebKit2
Merged r170948. <rdar://problem/17616971>
- 11:14 PM Changeset in webkit [170958] by
-
- 5 edits in trunk/Source/WebKit2
Buffer CSS and JS resources in network process before sending over to web process
https://bugs.webkit.org/show_bug.cgi?id=134560
<rdar://problem/16737186>
Reviewed by Antti Koivisto.
For CSS and JS resources, ask the network process to buffer the entire resource instead of
sending it to web process in chunks since the web process can't do anything with a partial
css or js file.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
- Shared/Network/NetworkResourceLoadParameters.h:
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- 11:08 PM Changeset in webkit [170957] by
-
- 5 edits in trunk/Source/WebCore
Fire connected/disconnected events for Gamepads.
https://bugs.webkit.org/show_bug.cgi?id=134386
Reviewed by Dean Jackson.
No new tests (No effect in a currently tested config)
- Modules/gamepad/GamepadManager.cpp:
(WebCore::navigatorGamepadFromDOMWindow): Handling converting a possibly-null Navigator into
a possibly null NavigatorGamepad.
(WebCore::GamepadManager::platformGamepadConnected): Notify blind Navigator/DOMWindows of all
previously attached Gamepads, then notify everybody of this new gamepad.
(WebCore::GamepadManager::platformGamepadDisconnected): Handle dispatching the disconnected
event to all registered DOMWindows.
(WebCore::GamepadManager::platformGamepadInputActivity): Notify blind Navigator/DOMWindows of all
attached Gamepads.
(WebCore::GamepadManager::makeGamepadVisible): Handles notifying setting up a new gamepads
with all NavigatorGamepads as well as dispatching the connected even to DOMWindows.
(WebCore::GamepadManager::registerDOMWindow):
(WebCore::GamepadManager::unregisterDOMWindow):
(WebCore::GamepadManager::makeGamepadsVisibileToBlindNavigators): Deleted.
- Modules/gamepad/GamepadManager.h:
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::gamepadAtIndex):
- Modules/gamepad/NavigatorGamepad.h:
- 10:59 PM Changeset in webkit [170956] by
-
- 5 edits in tags/Safari-538.45.1/Source
Versioning.
- 10:47 PM Changeset in webkit [170955] by
-
- 1 copy in tags/Safari-538.45.1
New tag.
- 10:32 PM Changeset in webkit [170954] by
-
- 2 edits in trunk/WebKitLibraries
[Win] Unreviewed build fix.
Build bots don't have a three-part default version string,
breaking pattern matching. Handle this case.
- win/tools/scripts/auto-version.pl:
- 10:06 PM Changeset in webkit [170953] by
-
- 10 edits in trunk/Source
[iOS][WK2] Disable text quantization while actively changing the page's scale factor
https://bugs.webkit.org/show_bug.cgi?id=134781
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-09
Reviewed by Tim Horton and Myles C. Maxfield.
Source/WebCore:
Query the chrome client to setup quantization on each layers.
- page/ChromeClient.h:
(WebCore::ChromeClient::hasStablePageScaleFactor):
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupFontSubpixelQuantization):
Source/WebKit2:
While zooming a page, text quantization causes glyphs to "move" in order to get to the closest
boundary for the current scale factor.
We do not want this to happen while dynamically changing the scale factor because the effect
is visible. To avoid this, we disable text quantization if the page's scale factor changes
in response to a non-stable contentRect update.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::hasStablePageScaleFactor):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::hasStablePageScaleFactor):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
- 9:38 PM Changeset in webkit [170952] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Use UIAlertController API in WKFileUploadPanel instead of SPI
https://bugs.webkit.org/show_bug.cgi?id=134777
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-09
Reviewed by Sam Weinig.
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel _showMediaSourceSelectionSheet]):
- 9:13 PM Changeset in webkit [170951] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Add new Public API in ewk_download_job.h to get size of the data already downloaded.
https://bugs.webkit.org/show_bug.cgi?id=134759
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-07-09
Reviewed by Gyuyoung Kim.
Add new API in ewk_download_job.h to get size of the data already downloaded.
- UIProcess/API/efl/ewk_download_job.cpp:
(ewk_download_job_received_data_length_get):
(EwkDownloadJob::receivedData):
- UIProcess/API/efl/ewk_download_job.h:
- UIProcess/API/efl/ewk_download_job_private.h:
- UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
(EWK2DownloadJobTest::on_download_requested):
(EWK2DownloadJobTest::on_download_finished):
- 9:11 PM Changeset in webkit [170950] by
-
- 3 edits in trunk/Source/JavaScriptCore
Use 16bits instructions for push/pop on ARMv7 when possible
https://bugs.webkit.org/show_bug.cgi?id=134753
Reviewed by Geoffrey Garen.
The patch r170839 mixed the code for push/pop pair and single push/pop.
That part was reverted in r170909.
This patch puts the code back but specialized for single push/pop.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::pop):
(JSC::ARMv7Assembler::push):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::pop):
(JSC::MacroAssemblerARMv7::push):
- 8:11 PM Changeset in webkit [170949] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Cache entry invalidated too early.
https://bugs.webkit.org/show_bug.cgi?id=134681
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-07-09
Reviewed by Alex Christensen.
When a cache entry has expired, it is invalidated when a request for the corresponding url is started.
This is too early, since the resource is possibly not modified (even though it has expired),
and the server might respond with a 304 (not modified) response.
When we then receive a 304 response, the cache entry is deleted, and we have no cached response/data to provide.
This can be solved by not invalidating the entry when a request for that url is started,
but instead invalidate when a 200 OK response is received (which means the resource has been modified).
- platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::isCached): Avoid invalidating cache entry when it has expired, wait until we know the server response.
- platform/network/curl/CurlCacheManager.h: Added const modifier.
- 7:18 PM Changeset in webkit [170948] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r170858): Safari freezes upon making a search on a website (yelp.com).
https://bugs.webkit.org/show_bug.cgi?id=134791
<rdar://problem/17616971>
Reviewed by Benjamin Poulain.
After r170858 we notify the keyboard too often about
the changed selection. This patch removes the notification
until we find a better way to do it that doesn't cause
deadlocks.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _selectionWillChange]):
(-[WKContentView _selectionChanged]):
- 6:42 PM Changeset in webkit [170947] by
-
- 37 edits in trunk/Source/WebCore
Revert r170413 and r170390
https://bugs.webkit.org/show_bug.cgi?id=134741
Reviewed by Benjamin Poulain.
These patches caused a variety of failures. I'm going to break them up into
smaller chunks and commit them separately at some point in the future.
Requesting a review from Ben Poulain because there were some conflicts with
r170561 in InlineTextBox.cpp and InlineTextBox.h.
- WebCore.exp.in:
- platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForText):
(WebCore::computeUnderlineType):
- platform/graphics/Font.h:
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::drawGlyphBuffer):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForSimpleText):
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::size):
(WebCore::GlyphBuffer::glyphs):
(WebCore::GlyphBuffer::advances):
(WebCore::GlyphBuffer::fontDataAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::offsetAt):
(WebCore::GlyphBuffer::reverse):
(WebCore::GlyphBuffer::offsetInString):
(WebCore::GlyphBuffer::swap):
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/Latin1TextIterator.h:
(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::currentCharacter):
- platform/graphics/SimpleFontData.h:
- platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::SurrogatePairAwareTextIterator):
- platform/graphics/SurrogatePairAwareTextIterator.h:
(WebCore::SurrogatePairAwareTextIterator::currentCharacter):
- platform/graphics/TextRun.h:
(WebCore::TextRun::length):
(WebCore::TextRun::charactersLength):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::glyphDataForCharacter):
(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):
- platform/graphics/WidthIterator.h:
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::adjustSelectionRectForComplexText):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontWin.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/wince/FontWinCE.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::selectionRectForComplexText):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::selectionState):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::positionForOffset):
(WebCore::InlineTextBox::constructTextRun):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::truncation):
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::getStringToRender):
- rendering/RenderCombineText.h:
- rendering/RenderTextLineBoxes.cpp:
(WebCore::ellipsisRectForBox):
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::localSelectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGInlineTextBox::paintText):
- rendering/svg/SVGInlineTextBox.h:
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::SVGTextQuery::extentOfCharacterCallback):
(WebCore::SVGTextQuery::characterNumberAtPositionCallback):
- rendering/svg/SVGTextQuery.h:
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::SVGGlyphToPathTranslator):
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
- rendering/svg/SVGTextRunRenderingContext.h:
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontData.h:
- 6:13 PM Changeset in webkit [170946] by
-
- 4 edits in trunk
Fix flaky loading tests
https://bugs.webkit.org/show_bug.cgi?id=133696
Reviewed by Ryosuke Niwa.
Source/WebCore:
In some cases, the Frame may be destroyed while the loader is
initializing. Make sure we don't delete it too early.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
LayoutTests:
- platform/wk2/TestExpectations: Unskip no-longer failing tests
- 6:05 PM Changeset in webkit [170945] by
-
- 2 edits in trunk/Source/WebKit2
Safari showing blank pages
https://bugs.webkit.org/show_bug.cgi?id=134790
<rdar://problem/17617166>
Reviewed by Simon Fraser.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Make sure to add the content view to the scroll view.
- 6:01 PM Changeset in webkit [170944] by
-
- 4 edits in trunk/Source/WebCore
Make IndirectCompositingReason an enum class
https://bugs.webkit.org/show_bug.cgi?id=134789
Reviewed by Tim Horton.
Make RenderLayer::IndirectCompositingReason an enum class, and change some code
in RenderLayerCompositor::reasonsForCompositing() to use a switch.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
- 5:50 PM Changeset in webkit [170943] by
-
- 4 edits in trunk/Source/WebKit2
Closed web views should never create new web processes
https://bugs.webkit.org/show_bug.cgi?id=134787
<rdar://problem/16892526>
Reviewed by Simon Fraser.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadHTMLString:baseURL:]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
Return nil if the returned navigation ID is 0.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess):
Assert that the page is not closed.
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
Add early returns if the page is closed.
- UIProcess/WebPageProxy.h:
- 5:29 PM Changeset in webkit [170942] by
-
- 10 edits in trunk/LayoutTests
[EFL] gardening after r170868
https://bugs.webkit.org/show_bug.cgi?id=134717
Unreviewed, EFL gardening.
Four tests have been rebaselined, and disable the gamepad tests
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-07-09
- platform/efl/TestExpectations: Disable the gamepad tests
- platform/efl/fast/text/atsui-multiple-renderers-expected.png:
- platform/efl/fast/text/atsui-multiple-renderers-expected.txt:
- platform/efl/fast/text/complex-text-opacity-expected.png:
- platform/efl/fast/text/complex-text-opacity-expected.txt:
- platform/efl/fast/text/midword-break-before-surrogate-pair-expected.png:
- platform/efl/fast/text/midword-break-before-surrogate-pair-expected.txt:
- platform/efl/transforms/2d/hindi-rotated-expected.png:
- platform/efl/transforms/2d/hindi-rotated-expected.txt:
- 5:25 PM Changeset in webkit [170941] by
-
- 2 edits in trunk/LayoutTests
[MSE] http/tests/media/media-source/mediasource-closed.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=134775
Reviewed by Eric Carlson.
Update the test to use isNaN rather than Number.isNaN.
- http/tests/media/media-source/mediasource-closed.html:
- 5:24 PM Changeset in webkit [170940] by
-
- 3 edits in trunk/WebKitLibraries
[Win] Unreviewed gardening.
- win/tools/scripts/auto-version.pl: Protect against
malformed paths (trailing backslashes).
- win/tools/scripts/feature-defines.pl: Make sure result
has an EOL character.
- 5:22 PM Changeset in webkit [170939] by
-
- 2 edits in trunk/Source/WTF
[Win] Unreviewed build fix after r170930.
- WTF.vcxproj/copy-files.cmd: Include cf files in
post-build copy operation.
- 5:18 PM Changeset in webkit [170938] by
-
- 5 edits in trunk/Source/WebCore
Make SharedBuffer::append(SharedBuffer*) be smarter about CFData and data arrays
https://bugs.webkit.org/show_bug.cgi?id=134731
Reviewed by Antti Koivisto.
If the target SharedBuffer has a CFDataRef or a data array then we can simply retain that
CFDataRef or data array elements in the SharedBuffer being appended to. This avoids
unnecessary copying.
No new tests because no functional changes.
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::maybeAppendPlatformData):
- platform/SharedBuffer.h:
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::maybeAppendPlatformData):
(WebCore::SharedBuffer::maybeAppendDataArray):
- platform/soup/SharedBufferSoup.cpp:
(WebCore::SharedBuffer::maybeAppendPlatformData):
- 4:48 PM Changeset in webkit [170937] by
-
- 42 edits8 moves in trunk
[Win] Remove uses of 'bash' in build system
https://bugs.webkit.org/show_bug.cgi?id=134782
<rdar://problem/17615533>
Reviewed by Dean Jackson.
Remove uses of 'bash' by replacing Windows-specific bash scripts
with Perl equivalents.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCorePreBuild.cmd:
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.pl: Copied from Source/JavaScriptCore/JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.sh.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.sh: Removed.
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl: Copied from Source/JavaScriptCore/JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh.
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh: Removed.
- JavaScriptCore.vcxproj/build-generated-files.pl: Copied from Source/JavaScriptCore/JavaScriptCore.vcxproj/build-generated-files.sh.
- JavaScriptCore.vcxproj/build-generated-files.sh: Removed.
- JavaScriptCore.vcxproj/jsc/jscPreBuild.cmd:
- JavaScriptCore.vcxproj/testRegExp/testRegExpPreBuild.cmd:
- JavaScriptCore.vcxproj/testapi/testapiPreBuild.cmd:
Source/WebCore:
- WebCore.vcxproj/WebCoreGenerated.make:
- WebCore.vcxproj/WebCoreGenerated.vcxproj:
- WebCore.vcxproj/WebCoreGenerated.vcxproj.filters:
- WebCore.vcxproj/WebCorePreBuild.cmd:
- WebCore.vcxproj/build-generated-files.pl: Copied from Source/WebCore/WebCore.vcxproj/build-generated-files.sh.
- WebCore.vcxproj/build-generated-files.sh: Removed.
- WebCore.vcxproj/migrate-scripts.pl: Copied from Source/WebCore/WebCore.vcxproj/migrate-scripts.sh.
- WebCore.vcxproj/migrate-scripts.sh: Removed.
Source/WebInspectorUI:
- WebInspectorUI.vcxproj/WebInspectorUI.make:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
- WebInspectorUI.vcxproj/build-webinspectorui.pl: Copied from Source/WebInspectorUI/WebInspectorUI.vcxproj/build-webinspectorui.sh.
- WebInspectorUI.vcxproj/build-webinspectorui.sh: Removed.
Source/WebKit:
- WebKit.vcxproj/Interfaces/FixMIDLHeaders.pl:
- WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
- WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:
- WebKit.vcxproj/WebKit/WebKitVersion.cmd:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd:
- WebKit.vcxproj/WebKitGUID/WebKitGUIDPreBuild.cmd:
Source/WTF:
- WTF.vcxproj/WTFGenerated.make:
- WTF.vcxproj/WTFGenerated.vcxproj:
- WTF.vcxproj/WTFGenerated.vcxproj.filters:
- WTF.vcxproj/WTFPreBuild.cmd:
- WTF.vcxproj/build-generated-files.pl: Copied from Source/WTF/WTF.vcxproj/build-generated-files.sh.
- WTF.vcxproj/build-generated-files.sh: Removed.
Tools:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
- WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
WebKitLibraries:
- win/tools/scripts/feature-defines.pl: Copied from WebKitLibraries/win/tools/scripts/feature-defines.sh.
- win/tools/scripts/feature-defines.sh: Removed.
- 3:33 PM Changeset in webkit [170936] by
-
- 4 edits in tags/Safari-538.45/Source
Merged r170924. <rdar://problem/16167838>
- 3:06 PM Changeset in webkit [170935] by
-
- 4 edits in trunk/Source
Support transparent WKWebViews
https://bugs.webkit.org/show_bug.cgi?id=134779
<rdar://problem/17351058>
Reviewed by Tim Horton.
Source/WebCore:
Schedule rebuilding the compositing layers if a FrameView's transparency changes.
- page/FrameView.cpp:
(WebCore::FrameView::setTransparent):
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Call _updateScrollViewBackground instead of setting the background color.
(contentZoomScale):
Use dot notation.
(scrollViewBackgroundColor):
Helper function that returns the scroll view background color.
If the web view isn't opaque, we want the scroll view to be transparent.
(-[WKWebView _updateScrollViewBackground]):
Call scrollViewBackgroundColor.
(-[WKWebView setOpaque:]):
Call WebPageProxy::setDrawsBackground and update the scroll view background.
(-[WKWebView setBackgroundColor:]):
Call setBackgroundColor on the content view.
- 2:58 PM Changeset in webkit [170934] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] WebKit can crash under QuickLookDocumentData::encode() when viewing a QuickLook preview
https://bugs.webkit.org/show_bug.cgi?id=134780
Reviewed by Tim Horton.
Don't use CFDataCreateWithBytesNoCopy() when we can't guarantee the lifetime of the copied-from DataReference
will match or exceed that of the CFDataRef. Copy the data instead.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveData):
- 2:56 PM Changeset in webkit [170933] by
-
- 9 edits in trunk
CSS canvas color parsing accepts invalid color identifiers
https://bugs.webkit.org/show_bug.cgi?id=134661
Reviewed by Benjamin Poulain.
Source/WebCore:
Current implementation of the CSSParser::parseSystemColor assumes
that if a valid cssValueKeywordID is got then it has to be a valid
color. Such assumption is wrong and lead to many bugs and layout
test failures.
The parseSystemFunction determines now whether the parsed color is
valid or not.
Addtionally, a new method has been added to share the logic of
determining whether a CSSValueID is a valid primitive values for
colors or not. Generally, we should avoid passing invalid color
identifiers to the theming API.
No new tests, but added additional cases to the
canvas-color-serialization.html, test-setting-canvas-color and
rgb-color-parse test.
- css/CSSParser.cpp:
(WebCore::validPrimitiveValueColor): Added.
(WebCore::parseColorValue):
(WebCore::CSSParser::parseSystemColor):
LayoutTests:
The parseSystemFunction determines now whether the parsed color is
valid or not.
The rgb-color-parser covers css style color parsing cases, which
already provide coverage for invalid color identifiers. I've added
a few more, though.
- fast/canvas/canvas-color-serialization-expected.txt:
- fast/canvas/script-tests/canvas-color-serialization.js:
- fast/css/test-setting-canvas-color-expected.txt:
- fast/css/test-setting-canvas-color.html:
- svg/dom/rgb-color-parser-expected.txt:
- svg/dom/rgb-color-parser.html:
- 2:37 PM Changeset in webkit [170932] by
-
- 8 edits in trunk
Source/WebCore: [MSE] http/tests/media/media-source/mediasource-remove.html is failing
https://bugs.webkit.org/show_bug.cgi?id=134768
Reviewed by Eric Carlson.
Fix multiple bugs causing mediasource-remove.html to fail:
Separate out setDuration() into setDurationInternal() so that steps which require
us to run the "duration change algorithm" don't bail out if the SoureBuffer is
inside updating().
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::setDurationInternal):
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
When removing coded frames, do so starting from the first sample in the range in
decode order, so that frames dependant on removed frames are themselves removed. Add
a convenience method in SampleMap findSampleWithPresentationTime(), and rename
findSampleAfterPresentationTime() to findSampleOnOrAfterPresentationTime() to correctly
reflect what the method does, and simplify its implementation by searching the map's keys
directly.
- Modules/mediasource/SampleMap.cpp:
(WebCore::PresentationOrderSampleMap::findSampleWithPresentationTime):
(WebCore::PresentationOrderSampleMap::findSampleOnOrAfterPresentationTime):
(WebCore::DecodeOrderSampleMap::findSyncSampleAfterPresentationTime):
(WebCore::PresentationOrderSampleMap::findSampleAfterPresentationTime): Deleted.
- Modules/mediasource/SampleMap.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::decodeTimeComparator):
(WebCore::SourceBuffer::removeCodedFrames):
Throw the correct exception (INVALID_STATE_ERR) from SourceBuffer::remove().
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::remove):
LayoutTests: [MSE] http/tests/media/media-source/mediasource-remove.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=134768
Reviewed by Eric Carlson.
Update mediasource-remove.html with the correct locations of sync-samples.
- http/tests/media/media-source/mediasource-remove.html:
- 2:36 PM Changeset in webkit [170931] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION(r167770): Cannot login in Evernote Safari extension
https://bugs.webkit.org/show_bug.cgi?id=134776
Reviewed by Enrica Casucci.
Unfortunately, NSWindowDidBecomeKeyNotification does not notify us when a popover becomes key
so we need to keep using the SPI (_windowChangedKeyState) I removed in r167770.
- WebView/WebView.mm:
(-[WebView _windowChangedKeyState]):
- 2:19 PM Changeset in webkit [170930] by
-
- 9 edits in trunk/Source/WebCore
Add SharedBuffer::wrapCFDataArray() and use it
https://bugs.webkit.org/show_bug.cgi?id=134733
Reviewed by Antti Koivisto.
No new tests. Should be covered by existing tests.
- platform/SharedBuffer.h:
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::wrapCFDataArray):
(WebCore::SharedBuffer::SharedBuffer):
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::handleDataArray): Deleted.
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveDataArray):
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveDataArray:]):
- 2:16 PM Changeset in webkit [170929] by
-
- 5 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Move Flush(SetLocal) store elimination to StrengthReductionPhase
https://bugs.webkit.org/show_bug.cgi?id=134739
Reviewed by Mark Hahnenberg.
I'm going to streamline CSE around clobberize() as part of
https://bugs.webkit.org/show_bug.cgi?id=134677, and so Flush(SetLocal) store
elimination wouldn't belong in CSE anymore. It doesn't quite belong anywhere, which
means that it belongs in StrengthReductionPhase, since that's intended to be our
dumping ground.
To do this I had to add some missing smarts to clobberize(). Previously clobberize()
could play a bit loose with reads of Variables because it wasn't used for store
elimination. The main client of read() was LICM, but it would only use it to
determine hoistability and anything that did a write() was not hoistable - so, we had
benign (but still wrong) missing read() calls in places that did write()s. This fixes
a bunch of those cases.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::setLocalStoreElimination): Deleted.
- dfg/DFGClobberize.cpp:
(JSC::DFG::accessesOverlap):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize): Make clobberize() smart enough for detecting when this store elimination would be sound.
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode): Implement the store elimination in terms of clobberize().
- 1:55 PM Changeset in webkit [170928] by
-
- 7 edits in trunk/Source
Move resource buffering from SynchronousNetworkLoaderClient to NetworkResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=134732
Reviewed by Darin Adler.
Source/WebCore:
No new tests because no functional changes.
- WebCore.exp.in:
Source/WebKit2:
Buffer the resource in NetworkResourceLoader instead of SynchronousNetworkLoaderClient. This
is in preparation for bug 134560 where we will be supporting JS and CSS resource buffering
that uses AsynchronousNetworkLoaderClient.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::bufferedData):
- NetworkProcess/SynchronousNetworkLoaderClient.cpp:
(WebKit::SynchronousNetworkLoaderClient::didReceiveBuffer):
(WebKit::SynchronousNetworkLoaderClient::didFinishLoading):
(WebKit::SynchronousNetworkLoaderClient::didFail):
(WebKit::SynchronousNetworkLoaderClient::sendDelayedReply):
- NetworkProcess/SynchronousNetworkLoaderClient.h:
- 1:52 PM Changeset in webkit [170927] by
-
- 2 edits in trunk/Source/WebCore
Fix the !USE(IOSURFACE) build.
- WebCore.exp.in:
- 12:47 PM Changeset in webkit [170926] by
-
- 5 edits in trunk/Source/WebKit2
[iOS][WK2] subviews of the unscaled view drift out during CA animations
https://bugs.webkit.org/show_bug.cgi?id=134751
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-09
Reviewed by Enrica Casucci.
It is not possible to animate the WKContentView and the inverse view in such a way
that the combined matrix remain the identity for every frame of the animation.
This patch solves the issue by moving the unscaled view as a sibling of WKContentView
instead of a child so that we do not need to update two scales simultaneously.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView _processDidExit]):
(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:]):
Set the z scale to 1 or no coordinate transform will work with this view.
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
Since we need to observe changes inside the animation block, the code now use KVO to observe changes of scale.
(-[WKContentView cleanupInteraction]):
(-[WKContentView unscaledView]):
(-[WKContentView inverseScale]):
(-[WKContentView observeValueForKeyPath:ofObject:change:context:]):
We update the utility views as usual. The extra bits here are to deal with views coming in during an animation.
If a new utility view comes in during a scaling animation, we do not want to start a new animation with the same curve
to end up at the right place. To avoid any issue, we just hide the view until the animation is finished.
(-[WKContentView hitTest:withEvent:]):
(-[WKContentView _showTapHighlight]):
(-[WKContentView _updateUnscaledView]): Deleted.
- 12:31 PM Changeset in webkit [170925] by
-
- 8 edits in trunk/Source
Use IOSurface ViewSnapshots everywhere on Mac, remove JPEG encoding path
https://bugs.webkit.org/show_bug.cgi?id=134773
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _takeViewSnapshot]):
- UIProcess/mac/ViewSnapshotStore.h:
- UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::ViewSnapshotStore):
(WebKit::ViewSnapshotStore::~ViewSnapshotStore):
(WebKit::ViewSnapshotStore::recordSnapshot):
(WebKit::ViewSnapshot::clearImage):
(WebKit::ViewSnapshot::asLayerContents):
(WebKit::createIOSurfaceFromImage): Deleted.
(WebKit::compressImageAsJPEG): Deleted.
(WebKit::ViewSnapshotStore::reduceSnapshotMemoryCost): Deleted.
(WebKit::ViewSnapshotStore::didCompressSnapshot): Deleted.
Remove all ViewSnapshot(Store) code related to JPEG-encoded snapshots.
Remove the "image" member on ViewSnapshot; Mac will always start out with an IOSurface instead.
Adopt WebCore::IOSurface::createFromImage to make that happen.
Add a comment noting that if a snapshot comes back empty, we should throw it away completely.
- WebCore.exp.in:
- platform/graphics/cocoa/IOSurface.h:
- platform/graphics/cocoa/IOSurface.mm:
(IOSurface::createFromImage):
Move make-an-IOSurface-from-a-CGImageRef into WebCore::IOSurface.
- 12:11 PM Changeset in webkit [170924] by
-
- 4 edits in trunk/Source
Implement Editor::fontAttributesForSelectionStart() or iOS.
https://bugs.webkit.org/show_bug.cgi?id=134771
<rdar://problem/16167838>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Implement for iOS the equivalent function we have for OS X.
- editing/ios/EditorIOS.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
Source/WebKit/mac:
- WebView/WebViewPrivate.h:
- 12:10 PM Changeset in webkit [170923] by
-
- 3 edits in trunk/Source/WebKit2
RemoteLayerBackingStore::ensureBackingStore should ensure that the entire backing store gets redrawn
https://bugs.webkit.org/show_bug.cgi?id=134772
Reviewed by Tim Horton.
- Shared/mac/RemoteLayerBackingStore.h:
(WebKit::RemoteLayerBackingStore::Buffer::operator bool):
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::ensureBackingStore):
- 11:05 AM Changeset in webkit [170922] by
-
- 22 edits in trunk
[Win] Remove use of 'grep' in build steps
https://bugs.webkit.org/show_bug.cgi?id=134770
<rdar://problem/17608783>
Reviewed by Tim Horton.
Replace uses of the grep command in Windows builds with the equivalent
Perl program.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCorePreBuild.cmd:
- JavaScriptCore.vcxproj/jsc/jscPreBuild.cmd:
- JavaScriptCore.vcxproj/testRegExp/testRegExpPreBuild.cmd:
- JavaScriptCore.vcxproj/testapi/testapiPreBuild.cmd:
Source/WebCore:
- WebCore.vcxproj/WebCoreGenerated.make:
- WebCore.vcxproj/WebCorePreBuild.cmd:
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::notifyFinished):
Source/WebKit:
- WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
- WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd:
- WebKit.vcxproj/WebKitGUID/WebKitGUIDPreBuild.cmd:
Source/WTF:
- WTF.vcxproj/WTFPreBuild.cmd:
Tools:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
- WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
- 10:49 AM Changeset in webkit [170921] by
-
- 7 edits in trunk/Source/WebCore
Added css jit profiler, disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=134695
Reviewed by Benjamin Poulain.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
Tell the RuleData when its compiled selector is used.
- css/RuleSet.cpp:
(WebCore::RuleData::RuleData):
Initialize the compiled selector use count to 0.
- css/RuleSet.h:
(WebCore::RuleData::~RuleData):
(WebCore::RuleData::compiledSelectorUsed):
Count and log the number of times a compiled selector is used.
- cssjit/SelectorCompiler.h:
Added option for CSS_SELECTOR_JIT_PROFILING set to 0 by default.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::execute):
Tell the SelectorData when its compiled selector is used.
- dom/SelectorQuery.h:
(WebCore::SelectorDataList::SelectorData::SelectorData):
(WebCore::SelectorDataList::SelectorData::~SelectorData):
(WebCore::SelectorDataList::SelectorData::compiledSelectorUsed):
Count and log the number of times a compiled selector is used.
- 10:17 AM Changeset in webkit [170920] by
-
- 8 edits in trunk/Source/WebCore
[iOS] caption size is sometimes incorrect in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=134740
Reviewed by Jer Noble.
Captions on iOS are displayed in fullscreen with a TextTrackRepresentation object. Because
the fullscreen video presentation is controlled by code in the UI process running on the
UI thread, WebCore is notified of changes to fullscreen state asynchronously. This resulted
in the TextTrackRepresentation object being created and/or destroyed too late some of the
time, which caused us to sometimes display captions incorrectly. Fix this by setting up and
tearing down the TextTrackRepresentation object when WebCore's 'webkitfullscreenchange'
event fires.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::enteredFullscreen): Notify text track container.
(WebCore::MediaControlsHost::exitedFullscreen): Ditto.
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediacontrols/MediaControlsHost.idl:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleFullscreenChange): Notify host of fullscreen change.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::requiresTextTrackRepresentation): Only return true when in
fullscreen.
(WebCore::HTMLMediaElement::setVideoFullscreenLayer): Call updateTextTrackDisplay.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): Initialize
m_updateTextTrackRepresentationStyle to false.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Move logic for creating
TextTrackRepresentation to updateTextTrackRepresentation.
(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize): New, split out of updateTimerFired.
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Move code to force immediate
font size change to updateActiveCuesFontSize.
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation): New, update
text track representation, creating first if necessary.
(WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation): Add an early
return if we don't have a text track representation.
(WebCore::MediaControlTextTrackContainerElement::updateStyleForTextTrackRepresentation): Early
return if there is nothing to be done.
(WebCore::MediaControlTextTrackContainerElement::enteredFullscreen): Force a caption update
if there are visible captions.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Set m_updateTextTrackRepresentationStyle
to true.
(WebCore::MediaControlTextTrackContainerElement::textTrackRepresentationBoundsChanged): Force a
caption update if there are visible captions.
- html/shadow/MediaControlElements.h:
- 10:12 AM Changeset in webkit [170919] by
-
- 2 edits in trunk/LayoutTests
fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html is failing in some bots
https://bugs.webkit.org/show_bug.cgi?id=134769
- TestExpectations: Skipping the test.
- 9:31 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:30 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:29 AM Changeset in webkit [170918] by
-
- 7 edits in trunk
[MSE] http/tests/media/media-source/mediasource-endofstream-invaliderror.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=134413
Reviewed by Eric Carlson.
Source/WebCore:
Update MediaSource.endOfStream() to take an optional enum instead of an optional String.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::endOfStream):
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/MediaSource.idl:
LayoutTests:
Fix an inadevntant editing error in mediasource-endofstream-invaliderror.html, and fix missing
whitespace at the end of http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt.
- http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt:
- http/tests/media/media-source/mediasource-endofstream-invaliderror.html:
- 8:58 AM WebKitGTK/2.2.x edited by
- add another patch proposal (diff)
- 8:49 AM Changeset in webkit [170917] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Unreviewed, update my list of email addresses.
- 6:54 AM Changeset in webkit [170916] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-07-09
- platform/gtk/TestExpectations: Report and mark new failing and flaky tests. Adjust some tests expectations.
- platform/gtk/css1/formatting_model/inline_elements-expected.txt: Rebaseline after r170875.
- 2:12 AM Changeset in webkit [170915] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r170889.
https://bugs.webkit.org/show_bug.cgi?id=134754
This patch is wrong (Requested by philn on #webkit).
Reverted changeset:
"[GTK] Gstreamer missing from the install-dependencies script"
https://bugs.webkit.org/show_bug.cgi?id=134727
http://trac.webkit.org/changeset/170889
- 2:12 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 12:29 AM Changeset in webkit [170914] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix crash caused by invalid cursor image.
https://bugs.webkit.org/show_bug.cgi?id=134663
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-07-09
Reviewed by Gyuyoung Kim.
Remove calling of updateCursor since the custom cursor image is invalid once a mouse is out of the webview.
- UIProcess/API/efl/EwkView.cpp:
(EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent):
- 12:01 AM Changeset in webkit [170913] by
-
- 5 edits in trunk/Source
Versioning.
Jul 8, 2014:
- 11:52 PM Changeset in webkit [170912] by
-
- 1 copy in tags/Safari-538.45
New Tag.
- 11:50 PM Changeset in webkit [170911] by
-
- 6 edits in trunk/Source/WebCore
DOMWindows should register themselves with the GamepadManager when they have event listeners
https://bugs.webkit.org/show_bug.cgi?id=134669
Reviewed by Dean Jackson.
No new tests (No effect in a currently tested config)
By having DOMWindows register with the GamepadManager when they have/don’t have gamepad event
listeners, we accomplish two things:
1 - It’s simple for GamepadManager to dispatch gamepad events directly to the DOMWindows interested.
2 - We know when to start monitoring for gamepad connections.
- Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::GamepadManager):
(WebCore::GamepadManager::registerNavigator):
(WebCore::GamepadManager::unregisterNavigator):
(WebCore::GamepadManager::registerDOMWindow):
(WebCore::GamepadManager::unregisterDOMWindow):
(WebCore::GamepadManager::maybeStartMonitoringGamepads): Start monitoring gamepads if there are any
registered DOMWindows or NavigatorGamepads, and we aren’t already monitoring them.
(WebCore::GamepadManager::maybeStopMonitoringGamepads): Stop monitoring gamepads if there aren’t any
registered DOMWindows or NavigatorGameads, and we have been monitoring them before now.
- Modules/gamepad/GamepadManager.h:
- dom/EventNames.h:
(WebCore::EventNames::isGamepadEventType):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::~DOMWindow): If registered for gamepad events, unregister now.
(WebCore::DOMWindow::incrementGamepadEventListenerCount): If this is the first gamepad event
listener, register with the GamepadManager now.
(WebCore::DOMWindow::decrementGamepadEventListenerCount): If this was the last gamepad event
listener, unregister from the GamepadManager now.
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
- page/DOMWindow.h:
- 10:56 PM Changeset in webkit [170910] by
-
- 5 edits in trunk
.: [EFL] Support Encrypted Media Extensions.
https://bugs.webkit.org/show_bug.cgi?id=134750
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2014-07-08
Reviewed by Gyuyoung Kim.
Webkit needs to play encrypted media contents when media player
is played by Media source extensions and normal video procedure.
- Source/cmake/OptionsEfl.cmake: Turn on ENABLE_ENCRYPTED_MEDIA_V2
Source/WebCore: [EFL] Fix the build break when ENABLE_ENCRYPTED_MEDIA_V2 is turned on.
https://bugs.webkit.org/show_bug.cgi?id=134750
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2014-07-08
Reviewed by Gyuyoung Kim.
When turning ENABLE_ENCRYPTED_MEDIA_V2 on, build break occurs.
Some source files need to be included in CMakeLists.txt file for build.
And wrap the included header file which is built only on mac and wince.
- CMakeLists.txt:
- Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp:
- 10:13 PM Changeset in webkit [170909] by
-
- 3 edits in trunk/Source/JavaScriptCore
Restore the assertion changed with 170839
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::pop):
(JSC::ARMv7Assembler::push):
Revert the Assembler part of 170839. The assertions do not match both encoding.
I'll add specific version of push and pop instead.
- 9:53 PM Changeset in webkit [170908] by
-
- 2 edits in trunk/Source/WebCore
[iOS] user caption preferences not applied
https://bugs.webkit.org/show_bug.cgi?id=134599
Reviewed by Sam Weinig.
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride): All Pages in a PageGroup
do not necessarily use the same PageUserContentController, so apply and remove caption user
the style sheet directly to each page rather than to the page group.
- 8:00 PM Changeset in webkit [170907] by
-
- 7 edits2 adds in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Phantom simplification should be in its own phase
https://bugs.webkit.org/show_bug.cgi?id=134742
Reviewed by Geoffrey Garen.
This moves Phantom simplification out of CSE, which greatly simplifies CSE and gives it
more focus. Also this finally adds a phase that removes empty Phantoms. We sort of had
this in CPSRethreading, but that phase runs too infrequently and doesn't run at all for
SSA.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAdjacencyList.h:
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren): Deleted.
- dfg/DFGPhantomRemovalPhase.cpp: Added.
(JSC::DFG::PhantomRemovalPhase::PhantomRemovalPhase):
(JSC::DFG::PhantomRemovalPhase::run):
(JSC::DFG::performCleanUp):
- dfg/DFGPhantomRemovalPhase.h: Added.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- 5:51 PM Changeset in webkit [170906] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r170894.
https://bugs.webkit.org/show_bug.cgi?id=134749
"It broke the build on mountainlion release 32bit" (Requested
by mmirman on #webkit).
Reverted changeset:
"Added css jit profiler, disabled by default."
https://bugs.webkit.org/show_bug.cgi?id=134695
http://trac.webkit.org/changeset/170894
- 5:01 PM Changeset in webkit [170905] by
-
- 4 edits1 add1 delete in trunk
[Win] Implement auto-version as a Perl program
https://bugs.webkit.org/show_bug.cgi?id=134745
<rdar://problem/17597801>
Reviewed by David Kilzer.
Source/WebKit:
Modify build commands to use new Perl version of the
auto-version script.
- WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
- WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:
WebKitLibraries:
Translate the auto-version.sh bash script into an equivalent
Perl script.
- win/tools/scripts/auto-version.pl: Added.
- win/tools/scripts/auto-version.sh: Removed.
- 4:58 PM Changeset in webkit [170904] by
-
- 2 edits in trunk/Websites/webkit.org
Update policy for Inactive Committer and Reviewer status
https://bugs.webkit.org/show_bug.cgi?id=134403
Reviewed by Nico Weber.
- coding/commit-review-policy.html:
- 4:31 PM Changeset in webkit [170903] by
-
- 2 edits in trunk/Source/JavaScriptCore
RemoteInspector::shared() should not call WTF::initializeMainThread()
<https://bugs.webkit.org/show_bug.cgi?id=134747>
<rdar://problem/17161482>
Reviewed by Joseph Pecoraro.
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::shared):
Don't call WTF::initializeMainThread(). WTF threading is initialized by
JSC::initializeThreading().
- 4:17 PM Changeset in webkit [170902] by
-
- 10 edits in trunk/Source/WebKit2
Remove WebBackForwardListItems when their owning page goes away
https://bugs.webkit.org/show_bug.cgi?id=134709
<rdar://problem/17584645>
Reviewed by Dan Bernstein.
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::pageID):
Add the associated PageID to the WebBackForwardListItem.
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::restoreFromState):
Push the current PageID onto the WebBackForwardListItem.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::removeWebPage):
Remove all of the WebBackForwardListItems from m_backForwardListItemMap when
the page they are associated with is removed.
(WebKit::WebProcessProxy::addBackForwardItem):
Push the PageID from the WebProcess onto the WebBackForwardListItem.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::idToHistoryItemMap):
(WebKit::historyItemToIDMap):
(WebKit::updateBackForwardItem):
(WebKit::WebBackForwardListProxy::addItemFromUIProcess):
(WebKit::WK2NotifyHistoryItemChanged):
(WebKit::WebBackForwardListProxy::idForItem):
(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::close):
- WebProcess/WebPage/WebBackForwardListProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
Keep track of the PageID that back-forward items were created by.
Pass the PageID along when registering WebBackForwardListItems.
- 4:11 PM Changeset in webkit [170901] by
-
- 2 edits in trunk/Source/WebCore
WebVideoFullscreenInterfaceAVKit should lazily create m_playerController.
https://bugs.webkit.org/show_bug.cgi?id=134706
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-07-08
Reviewed by Simon Fraser.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel):
Don't set the delegate if m_playerController isn't created.
- 3:54 PM Changeset in webkit [170900] by
-
- 2 edits in trunk/Tools
resolve-ChangeLogs fails when WebKit repository is a git submodule
https://bugs.webkit.org/show_bug.cgi?id=134734
Reviewed by David Kilzer.
When using resolve-ChangeLogs in a WebKit git repository with a
non-default arrangement of GIT_DIR and GIT_WORK_TREE, incorrect
paths are computed and the script fails mysteriously.
We were naively computing GIT_WORK_TREE as being one level above
GIT_DIR, but this is not the case for submodules or a manually
configured GIT_WORK_TREE or GIT_DIR location.
- Scripts/VCSUtils.pm:
(gitTreeDirectory): Added. Find the equivalent of GIT_WORK_TREE.
(determineVCSRoot): Calculate the working tree root directly.
- 3:42 PM Changeset in webkit [170899] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Debugger popovers should not dismiss when mousing over them
https://bugs.webkit.org/show_bug.cgi?id=134687
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-08
Reviewed by David Kilzer.
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._trackPopoverEvents):
Actually install the listeners in the set. Regression from code refactoring in r165052.
- 3:36 PM Changeset in webkit [170898] by
-
- 3 edits in trunk/Source/JavaScriptCore
VM::lastCachedString should be a Strong, not a Weak.
<https://webkit.org/b/134746>
Using Weak<JSString> for this regressed some of our bindings perf tests
due to Weak having to allocate a new WeakImpl every time the last cached
string changed. Make it a Strong instead should make that problem go away.
Reviewed by Geoffrey Garen.
- runtime/JSString.cpp:
(JSC::jsStringWithCacheSlowCase):
- runtime/VM.h:
- 3:36 PM Changeset in webkit [170897] by
-
- 39 edits in trunk/LayoutTests
Remove webkit prefix from pointer lock tests.
https://bugs.webkit.org/show_bug.cgi?id=134744
Patch by Alex Christensen <achristensen@webkit.org> on 2014-07-08
Reviewed by Brady Eidson.
- http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-expected.txt:
- http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock.html:
- http/tests/pointer-lock/iframe-sandboxed-expected.txt:
- http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-expected.txt:
- http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html:
- http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-expected.txt:
- http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html:
- http/tests/pointer-lock/iframe-sandboxed.html:
- http/tests/pointer-lock/pointerlockelement-different-origin-expected.txt:
- http/tests/pointer-lock/pointerlockelement-different-origin.html:
- http/tests/pointer-lock/pointerlockelement-same-origin-expected.txt:
- http/tests/pointer-lock/pointerlockelement-same-origin.html:
- http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-expected.txt:
- http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html:
- http/tests/resources/pointer-lock/iframe-common.js:
(document.onpointerlockchange):
(document.onpointerlockerror):
(document.onwebkitpointerlockchange): Deleted.
(document.onwebkitpointerlockerror): Deleted.
- http/tests/resources/pointer-lock/pointer-lock-test-harness.js:
(expectOnlyChangeEvent):
(expectOnlyErrorEvent):
(expectNoEvents):
- pointer-lock/bug90391-move-then-window-open-crash-expected.txt:
- pointer-lock/bug90391-move-then-window-open-crash.html:
- pointer-lock/lock-already-locked-expected.txt:
- pointer-lock/lock-already-locked.html:
- pointer-lock/lock-element-not-in-dom-expected.txt:
- pointer-lock/lock-element-not-in-dom.html:
- pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
- pointer-lock/locked-element-iframe-removed-from-dom.html:
- pointer-lock/locked-element-removed-from-dom-expected.txt:
- pointer-lock/locked-element-removed-from-dom.html:
- pointer-lock/mouse-event-api-expected.txt:
- pointer-lock/mouse-event-api.html:
- pointer-lock/mouse-event-delivery-expected.txt:
- pointer-lock/mouse-event-delivery.html:
- pointer-lock/pointer-lock-api-expected.txt:
- pointer-lock/pointer-lock-api.html:
- pointer-lock/pointerlockchange-event-on-lock-lost-expected.txt:
- pointer-lock/pointerlockchange-event-on-lock-lost.html:
- pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
- pointer-lock/pointerlockchange-pointerlockerror-events.html:
- pointer-lock/pointerlockelement-null-when-pending-expected.txt:
- pointer-lock/pointerlockelement-null-when-pending.html:
Remove webkit prefix on pointer lock functions and events.
This should have been done in r170585.
- 3:24 PM Changeset in webkit [170896] by
-
- 10 edits in trunk
[WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
https://bugs.webkit.org/show_bug.cgi?id=134645
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _compositingBordersVisible]):
(-[WKPreferences _setCompositingBordersVisible:]):
(-[WKPreferences _compositingRepaintCountersVisible]):
(-[WKPreferences _setCompositingRepaintCountersVisible:]):
(-[WKPreferences _tiledScrollingIndicatorVisible]):
(-[WKPreferences _setTiledScrollingIndicatorVisible:]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Expose layer borders, repaint counters, and the tiled scrolling indicator on WKPreferences, as SPI.
- WebView/WebPreferences.mm:
(-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]):
Remove an extra unnecessary space.
- MiniBrowser/mac/BrowserWindowController.h:
- MiniBrowser/mac/MainMenu.xib:
Add menu items for layer borders and the tiled scrolling indicator.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController validateMenuItem:]):
(-[WK1BrowserWindowController layerBordersAreVisible]):
(-[WK1BrowserWindowController toggleLayerBordersVisibility:]):
Add getters/setters/validators for layer borders.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController layerBordersAreVisible]):
(-[WK2BrowserWindowController toggleLayerBordersVisibility:]):
(-[WK2BrowserWindowController tiledScrollingIndicatorIsVisible]):
(-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]):
Add getters/setters/validators for layer borders and the tiled scrolling indicator.
(-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
(-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
Remove the WebKit2 version of the subpixel metrics pref, because it doesn't work, because
nothing in WebKit2 reads this default, and there is no WebKit2 API for adjusting this preference.
- 3:10 PM Changeset in webkit [170895] by
-
- 3 edits5 adds in trunk
Ensure we compute the height of replaced elements to 'auto' when appropriate.
https://bugs.webkit.org/show_bug.cgi?id=134700
Reviewed by David Hyatt.
Source/WebCore:
This fixes two issues:
1) If a replaced element has a percentage height specified then its
height should compute to 'auto' when its containing block does not
have a height 'specified explicitly'. We were taking this to mean when
its containing block's specified height value is 'auto' - in fact it
means when the containing block's computed height is auto.
2) Top and bottom on the containing block should only affect the
height of the block if that block has absolute or fixed position.
This brings us into line with IE, Firefox, and Chrome.
This is a port of Blink patches by Rob Hogan and David Vest.
Tests: css2.1/20110323/height-percentage-005.htm
fast/css/replaced-element-ignore-top-bottom.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):
LayoutTests:
- css2.1/20110323/height-percentage-005-expected.html: Added.
- css2.1/20110323/height-percentage-005.htm: Added.
- css2.1/20110323/support/black96x96.png: Added.
- fast/css/replaced-element-ignore-top-bottom-expected.txt: Added.
- fast/css/replaced-element-ignore-top-bottom.html: Added.
- 2:47 PM Changeset in webkit [170894] by
-
- 7 edits in trunk/Source/WebCore
Added css jit profiler, disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=134695
Patch by Alex Christensen <achristensen@webkit.org> on 2014-07-08
Reviewed by Benjamin Poulain.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
Tell the RuleData when its compiled selector is used.
- css/RuleSet.cpp:
(WebCore::RuleData::RuleData):
Initialize the compiled selector use count to 0.
- css/RuleSet.h:
(WebCore::RuleData::~RuleData):
(WebCore::RuleData::compiledSelectorUsed):
Count and log the number of times a compiled selector is used.
- cssjit/SelectorCompiler.h:
Added option for CSS_SELECTOR_JIT_PROFILING set to 0 by default.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::execute):
Tell the SelectorData when its compiled selector is used.
- dom/SelectorQuery.h:
(WebCore::SelectorDataList::SelectorData::SelectorData):
(WebCore::SelectorDataList::SelectorData::~SelectorData):
(WebCore::SelectorDataList::SelectorData::compiledSelectorUsed):
Count and log the number of times a compiled selector is used.
- 12:27 PM Changeset in webkit [170893] by
-
- 2 edits in trunk/Source/WebKit2
WKProcessPoolConfigurationPrivate's maximumProcessCount property has no effect
https://bugs.webkit.org/show_bug.cgi?id=134711
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _initWithConfiguration:]):
Respect the maximumProcessCount.
Currently the default limit is UINT_MAX; if maximumProcessCount = 0 (the default), we'll use that limit.
- 11:45 AM Changeset in webkit [170892] by
-
- 3 edits2 adds in trunk
Steps towards CMake on Windows.
https://bugs.webkit.org/show_bug.cgi?id=134716
Patch by Alex Christensen <achristensen@webkit.org> on 2014-07-08
Reviewed by Martin Robinson.
- CMakeLists.txt:
Added AppleWin and WinCairo to list of CMake ports.
- Source/cmake/OptionsAppleWin.cmake: Added.
- Source/cmake/OptionsWinCairo.cmake: Added.
- Source/cmake/OptionsWindows.cmake:
Windows needs to use the system malloc. Other options to come.
- 10:53 AM Changeset in webkit [170891] by
-
- 25 edits7 adds in trunk
[GTK] Move user style sheet API out of WebKitWebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=134551
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-07-08
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- PlatformGTK.cmake: Include the new source files in the build.
- UIProcess/API/C/gtk/WKView.cpp:
(WKViewCreate):
Adapt to the additional webkitWebViewBaseCreateWebPage() parameter.
- UIProcess/API/gtk/WebKitUserContent.cpp: Added.
(toUserContentInjectedFrames):
(toUserStyleLevel):
(toStringVector):
(_WebKitUserStyleSheet::_WebKitUserStyleSheet):
(webkit_user_style_sheet_ref):
(webkit_user_style_sheet_unref):
(webkit_user_style_sheet_new):
(webkitWebKitUserStyleSheetToUserStyleSheet):
- UIProcess/API/gtk/WebKitUserContent.h: Added.
- UIProcess/API/gtk/WebKitUserContentManager.cpp: Added.
(_WebKitUserContentManagerPrivate::_WebKitUserContentManagerPrivate):
(webkit_user_content_manager_class_init):
(webkit_user_content_manager_new):
(webkit_user_content_manager_add_style_sheet):
(webkit_user_content_manager_remove_all_style_sheets):
(webkitUserContentManagerGetUserContentControllerProxy):
- UIProcess/API/gtk/WebKitUserContentManager.h: Added.
- UIProcess/API/gtk/WebKitUserContentManagerPrivate.h: Added.
- UIProcess/API/gtk/WebKitUserContentPrivate.h: Added.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextCreatePageForWebView): Add a new parameter to allow
passing the WebKitUserContentManager that the web view will use.
- UIProcess/API/gtk/WebKitWebContextPrivate.h: Ditto.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Added handling of the
"user-content-manager" property on construction.
(webkitWebViewSetProperty): Added support for the
"user-content-manager" property.
(webkitWebViewGetProperty): Added support for the
"user-content-manager" property.
(webkit_web_view_class_init): Added the "user-content-manager"
property definition to the WebKitWebView class.
(webkit_web_view_new_with_related_view): Made related views share
the same WebKitUserContentManager used by the view they are
related to.
(webkit_web_view_new_with_user_content_manager): Added.
(webkit_web_view_get_user_content_manager): Added.
- UIProcess/API/gtk/WebKitWebView.h: Add new API methods.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreate): Added a parameter to pass the user
content manager.
(webkitWebViewBaseCreateWebPage): Added a parameter to pass the user
content manager.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Ditto.
- UIProcess/API/gtk/WebKitWebViewGroup.cpp: Removed the bits related
to user style sheet support from WebKitWebViewGroup.
(webkit_web_view_group_set_settings):
(toAPIArray): Deleted.
(webkit_web_view_group_add_user_style_sheet): Deleted.
(webkit_web_view_group_remove_all_user_style_sheets): Deleted.
- UIProcess/API/gtk/WebKitWebViewGroup.h: Deleted the API methods
for user style sheet handling.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added the new API
functions and types, and removed the methods which are no longer
available in WebKitWebViewGroup.
- UIProcess/API/gtk/webkit2.h: Add the new headers.
- UIProcess/UserContent/WebUserContentControllerProxy.cpp: Added
methods to add and remove user style sheets, alike those used for
user scripts.
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::addUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
- UIProcess/UserContent/WebUserContentControllerProxy.h: Ditto.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Adapt to the additional webkitWebViewBaseCreateWebPage() parameter.
- WebProcess/UserContent/WebUserContentController.cpp: Added methods
to add and remove user style sheets, alike those used for user scripts.
(WebKit::WebUserContentController::addUserStyleSheets):
(WebKit::WebUserContentController::removeAllUserStyleSheets):
- WebProcess/UserContent/WebUserContentController.h: Ditto.
- WebProcess/UserContent/WebUserContentController.messages.in:
Ditto.
Tools:
Removes testing user style sheet injection from
TestWebKitWebViewGroup and moves that into a new
TestWebKitUserContentManager, adapting the existing tests to the new
API. Also, it contains a new test case for
webkit_web_view_new_with_user_content_manager().
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Added.
(UserContentManagerTest::UserContentManagerTest):
(testWebViewNewWithUserContentManager):
(isStyleSheetInjectedForURLAtPath):
(fillURLListFromPaths):
(removeOldInjectedStyleSheetsAndResetLists):
(testUserContentManagerInjectedStyleSheet):
(serverCallback):
(beforeAll):
(afterAll):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
(beforeAll):
(afterAll):
(isStyleSheetInjectedForURLAtPath): Deleted.
(fillURLListFromPaths): Deleted.
(removeOldInjectedStyleSheetsAndResetLists): Deleted.
(testWebViewGroupInjectedStyleSheet): Deleted.
(serverCallback): Deleted.
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(WebViewTest::WebViewTest):
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
- 10:50 AM Layout Test Protocol edited by
- (diff)
- 10:50 AM Changeset in webkit [170890] by
-
- 9 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Get rid of Node::misc by moving the fields out of the union so that you can use replacement and owner simultaneously
https://bugs.webkit.org/show_bug.cgi?id=134730
Reviewed by Mark Lam.
This will allow for a better GCSE implementation.
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setReplacement):
- dfg/DFGEdgeDominates.h:
(JSC::DFG::EdgeDominates::operator()):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::clearReplacements):
(JSC::DFG::Graph::initializeNodeOwners):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::performSubstitutionForEdge):
- dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::attemptHoist):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
- dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::run):
- 10:49 AM Layout Test Protocol edited by
- (diff)
- 10:43 AM Layout Test Protocol edited by
- (diff)
- 10:33 AM Changeset in webkit [170889] by
-
- 2 edits in trunk/Tools
[GTK] Gstreamer missing from the install-dependencies script
https://bugs.webkit.org/show_bug.cgi?id=134727
Patch by Ziran Sun <ziran.sun@samsung.com> on 2014-07-08
Reviewed by Mario Sanchez Prada.
Added missing gstreamer dependencies for debian based systems.
- gtk/install-dependencies: Added 2 dependencies for apt-get.
- 10:26 AM Layout Test Protocol edited by
- (diff)
- 10:25 AM Layout Test Protocol edited by
- (diff)
- 10:03 AM Layout Test Protocol edited by
- (diff)
- 10:01 AM Layout Test Protocol created by
- 9:41 AM Changeset in webkit [170888] by
-
- 2 edits in trunk/Tools
Add myself to the watchlist for text-related files
https://bugs.webkit.org/show_bug.cgi?id=134707
Reviewed by Timothy Horton.
- Scripts/webkitpy/common/config/watchlist:
- 9:34 AM Changeset in webkit [170887] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Guard uses of RedirectedXCompositeWindow in WebKitWebViewBase with PLATFORM(X11)
https://bugs.webkit.org/show_bug.cgi?id=133871
Reviewed by Martin Robinson.
Guard uses of the RedirectedXCompositeWindow object in WebKitWebViewBase with the
PLATFORM(X11) build guard. This is required to properly support building the GTK
port only for the Wayland target.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseConstructed):
(webkitWebViewRenderAcceleratedCompositingResults):
(resizeWebKitWebViewBaseFromAllocation):
(webkitWebViewBaseUpdatePreferences):
(webkitWebViewBaseCreateWebPage):
- 8:26 AM Changeset in webkit [170886] by
-
- 1 copy in releases/WebKitGTK/webkit-2.4.4
Tagging the WebKitGTK+ 2.4.4 release
- 8:20 AM Changeset in webkit [170885] by
-
- 1 edit1 add in trunk/Source/WebCore
Unreviewed. Fix GObject DOM bindings API breaks test after r170700.
Add missing WebKitDOMXPathNSResolver.symbols that I forgot to add
in r170700.
- bindings/gobject/WebKitDOMXPathNSResolver.symbols: Added.
- 5:08 AM Changeset in webkit [170884] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4
Unreviewed. Update NEWS and Versions.m4 for 2.4.4 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.4.4.
- 5:06 AM Changeset in webkit [170883] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.am:
- 2:40 AM Changeset in webkit [170882] by
-
- 9 edits in releases/WebKitGTK/webkit-2.4
[GTK][Stable] Google Maps doesn't work with Version/X in the user agent
https://bugs.webkit.org/show_bug.cgi?id=134631
Reviewed by Sergio Villar Senin.
Source/WebCore:
Because of the JSC version used in stable branch, when the
Version/X string is present in the user agent, google maps uses
JavaScript API that we don't support. Move the google domain quirks
from WebKit1 to WebCore and add a quirk for google maps.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::googleDomains):
(WebCore::otherGoogleDomains):
(WebCore::isGoogleDomain): Returns whether the given host is a
known google domain
(WebCore::buildUserAgentString): Do not include the Version/X
string in the user agent if the ShouldNotIncludeSafariVersion
quirk is present.
(WebCore::standardUserAgentForURL): Add RequiresStandardUserAgent
quirk for any google doamin and ShouldNotIncludeSafariVersion for
Google Maps.
Source/WebKit/gtk:
Remove user agent quirks for google domains, since they are now
implemented in WebCore.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::userAgent): Pass the WebCore::URL
const reference to webkitWebSettingsUserAgentForURI().
- webkit/webkitwebsettings.cpp:
(webkitWebSettingsUserAgentForURI): Use
WebCore::standardUserAgentForURL() when site specific quirks are enabled.
- webkit/webkitwebsettingsprivate.h:
Tools:
Move user agent quirks tests from WebKit1 to WebCore.
- TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c:
(test_webkit_web_settings_user_agent):
- 2:24 AM Changeset in webkit [170881] by
-
- 4 edits in trunk
Add option to specify output file location in sunspider.
https://bugs.webkit.org/show_bug.cgi?id=134339
Patch by Gergo Balogh <gbalogh.u-szeged@partner.samsung.com> on 2014-07-08
Reviewed by Darin Adler.
PerformanceTests/SunSpider:
- sunspider:
Tools:
- Scripts/run-sunspider:
Jul 7, 2014:
- 10:56 PM Changeset in webkit [170880] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. iOS build fix after r170871.
- rendering/RenderThemeIOS.mm:
(WebCore::adjustInputElementButtonStyle):
- 10:51 PM Changeset in webkit [170879] by
-
- 2 edits in trunk/Tools
Unreviewed build fix.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
Make Common.cpp excluded from both 32-bit and 64-bit builds.
- 9:35 PM Changeset in webkit [170878] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the build after r170876
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-07
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::linkCode):
- 9:26 PM Changeset in webkit [170877] by
-
- 3 edits2 adds in trunk
Subpixel rendering: icloud.com password arrow has clipped circle at some window sizes.
https://bugs.webkit.org/show_bug.cgi?id=134710
<rdar://problem/17545291>
Reviewed by Simon Fraser.
Transparent layer clipping needs device pixel snapping.
Source/WebCore:
Test: fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
LayoutTests:
- fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position-expected.html: Added.
- fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position.html: Added.
- 9:23 PM Changeset in webkit [170876] by
-
- 35 edits in trunk/Source
LinkBuffer should not keep a reference to the MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=134668
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
In FTL, the LinkBuffer can outlive the MacroAssembler that was used for code generation.
When that happens, the pointer m_assembler points to released memory. That was not causing
issues because the attribute is not used after linking, but that was not particularily
future proof.
This patch refactors LinkBuffer to avoid any lifetime risk. The MacroAssembler is now passed
as a reference, it is used for linking but no reference is ever stored with the LinkBuffer.
While fixing the call sites to use a reference, I also discovered LinkBuffer.h was included
everywhere. I refactored some #include to avoid that.
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::linkCode):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
- bytecode/Watchpoint.cpp:
- dfg/DFGDisassembler.cpp:
- dfg/DFGDisassembler.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGPlan.cpp:
- dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
(JSC::DFG::osrEntryThunkGenerator):
- ftl/FTLCompile.cpp:
(JSC::FTL::generateICFastPath):
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLJSCall.cpp:
- ftl/FTLJSCall.h:
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationThunkGenerator):
(JSC::FTL::slowPathCallThunkGenerator):
- jit/ArityCheckFailReturnThunks.cpp:
(JSC::ArityCheckFailReturnThunks::returnPCsFor):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITCall.cpp:
(JSC::JIT::privateCompileClosureCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::privateCompileClosureCall):
- jit/JITDisassembler.cpp:
- jit/JITDisassembler.h:
- jit/JITOpcodes.cpp:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
- jit/RegisterPreservationWrapperGenerator.cpp:
(JSC::generateRegisterPreservationWrapper):
(JSC::registerRestorationThunkGenerator):
- jit/Repatch.cpp:
(JSC::generateByIdStub):
(JSC::tryCacheGetByID):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryRepatchIn):
(JSC::linkClosureCall):
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
- jit/ThunkGenerators.cpp:
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::linkForThunkGenerator):
(JSC::linkClosureCallForThunkGenerator):
(JSC::virtualForThunkGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
- llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
Source/WebCore:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
- 9:13 PM Changeset in webkit [170875] by
-
- 6 edits2 adds in trunk
Subpixel rendering: Inline box decoration rounds to integral.
https://bugs.webkit.org/show_bug.cgi?id=134523
<rdar://problem/17530298>
Reviewed by Darin Adler.
This patch removes 2 integral roundings from InlineFlowBox:
- Border and padding sizes are implicitly integral truncated by the 'int' return type of borderLogicalLeft/Right()/paddingLogicalLeft/Right(). It results in losing fractional border/padding values.
- Painting rectangle is explicitly rounded which pushes border and other decoration elements to odd device pixel positions on retina displays.
These values get pixel snapped right before calling in to GraphicsContext::*.
Source/WebCore:
Test: fast/inline/hidpi-inline-text-decoration-with-subpixel-value.html
- rendering/InlineBox.h:
(WebCore::InlineBox::frameRect):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::roundedFrameRect): Deleted.
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):
(WebCore::InlineFlowBox::paddingLogicalLeft):
(WebCore::InlineFlowBox::paddingLogicalRight):
LayoutTests:
- fast/inline/hidpi-inline-text-decoration-with-subpixel-value-expected.html: Added.
- fast/inline/hidpi-inline-text-decoration-with-subpixel-value.html: Added.
- platform/mac/css1/formatting_model/inline_elements-expected.txt:
- 9:00 PM Changeset in webkit [170874] by
-
- 2 edits in trunk/LayoutTests
[EFL] gardening after r170864
https://bugs.webkit.org/show_bug.cgi?id=134713
Unreviewed, EFL gardening.
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-07-07
- platform/efl/TestExpectations: Report and mark several unexpected image-only failures.
- 8:22 PM Changeset in webkit [170873] by
-
- 3 edits in trunk/Source/WebCore
Pass RenderLayer reference instead of pointer to RenderLayer::paintingExtent().
https://bugs.webkit.org/show_bug.cgi?id=134714
Reviewed by Simon Fraser.
No change in functionality.
- rendering/RenderLayer.cpp: * -> &
(WebCore::expandClipRectForRegionAndReflection):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::transparencyClipBox):
(WebCore::paintingExtent):
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::paintingExtent): Deleted.
- rendering/RenderLayer.h:
- 7:40 PM Changeset in webkit [170872] by
-
- 2 edits in trunk/Source/WebKit2
Turn on accelerated drawing for WebKit2 by default
https://bugs.webkit.org/show_bug.cgi?id=134708
<rdar://problem/17584642>
Reviewed by Simon Fraser.
- Shared/WebPreferencesDefinitions.h:
Make Mac match iOS, in that accelerated drawing is on by default.
- 7:27 PM Changeset in webkit [170871] by
-
- 8 edits in trunk/Source/WebCore
Remove misleadingly-named Font::isSVGFont()
https://bugs.webkit.org/show_bug.cgi?id=134697
Reviewed by Dean Jackson.
Being a SVG font is a property of the FontData object, not
the Font object. Providing an isSVGFont() function on the
Font class will likely lead to incorrect code and non-obvious
bugs.
No new tests because there is no behavior change.
- platform/graphics/Font.h:
(WebCore::Font::isSVGFont): Deleted.
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::primaryFontDataIsSystemFont):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::constructTextRun):
- rendering/RenderBlock.cpp:
(WebCore::constructTextRunInternal):
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun):
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::constructTextRun):
(WebCore::SVGTextMetrics::SVGTextMetrics):
- 6:56 PM Changeset in webkit [170870] by
-
- 2 edits in trunk/Source/WebKit2
Don't leak _WKRemoteObjectRegistry in WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=134703
Reviewed by Simon Fraser.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController _remoteObjectRegistry]):
Adoption is important!!
- 6:52 PM Changeset in webkit [170869] by
-
- 13 edits in trunk/Source/WebCore
Move Gamepad index down into PlatformGamepad.
https://bugs.webkit.org/show_bug.cgi?id=134670
Reviewed by Darin Adler.
PlatformGamepads always have an inherent index anyways.
This will make things easier in all upcoming work.
- Modules/gamepad/Gamepad.cpp:
(WebCore::Gamepad::Gamepad):
- Modules/gamepad/Gamepad.h:
- Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::platformGamepadConnected):
(WebCore::GamepadManager::platformGamepadDisconnected):
(WebCore::GamepadManager::makeGamepadsVisibileToBlindNavigators):
- Modules/gamepad/GamepadManager.h:
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::gamepadsBecameVisible):
(WebCore::NavigatorGamepad::gamepadConnected):
(WebCore::NavigatorGamepad::gamepadDisconnected):
- Modules/gamepad/NavigatorGamepad.h:
- platform/GamepadProviderClient.h:
- platform/PlatformGamepad.h:
(WebCore::PlatformGamepad::index):
(WebCore::PlatformGamepad::PlatformGamepad):
- platform/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::HIDGamepad):
- platform/mac/HIDGamepad.h:
- platform/mac/HIDGamepadProvider.cpp:
(WebCore::HIDGamepadProvider::deviceAdded):
(WebCore::HIDGamepadProvider::deviceRemoved):
(WebCore::HIDGamepadProvider::removeGamepadForDevice):
- platform/mac/HIDGamepadProvider.h:
- 6:38 PM Changeset in webkit [170868] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: CSS style declaration editor should ignore empty lines when determining prefix whitespace
https://bugs.webkit.org/show_bug.cgi?id=134704
Reviewed by Joseph Pecoraro.
When checking for zero-length prefix whitespace, completely empty lines are now ignored
as these lines are most often used for organizing rules into groups and often have their
whitespace removed due to trailing whitespace removal conventions.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
- 5:14 PM Changeset in webkit [170867] by
-
- 5 edits in branches/safari-537.75-branch/Source
Versioning.
- 5:10 PM Changeset in webkit [170866] by
-
- 1 copy in tags/Safari-537.75.18
New Tag.
- 5:07 PM Changeset in webkit [170865] by
-
- 4 edits in branches/safari-537.75-branch/Source
Merged r169927. <rdar://problem/17563093>
- 4:44 PM Changeset in webkit [170864] by
-
- 15 edits in trunk/Source
[UI-side compositing] Support reflections on custom layers like video
https://bugs.webkit.org/show_bug.cgi?id=134701
Reviewed by Tim Horton.
Source/WebCore:
Add a LayerTypeWebGLLayer layer type, and support casting to PlatformCALayerRemoteCustom.
- WebCore.exp.in: Export PlatformCALayerMac::layerTypeForPlatformLayer(CALayer*), and sort.
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::isPlatformCALayerRemoteCustom):
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::layerTypeForPlatformLayer):
(PlatformCALayerMac::PlatformCALayerMac):
(PlatformCALayerMac::commonInit):
Source/WebKit2:
For video reflections, we have to support cloning of PlatformCALayerRemoteCustom
in the web process. Do so by implementing PlatformCALayerRemoteCustom::clone(),
which does the right gyrations to get AVPlayerLayers cloned, then makes a
new PlatformCALayerRemoteCustom to wrap the new layer. This ends up getting
its own context hosting ID, allowing the clone to show in the UI process.
Attempt to do the same for WebGL, but turn it off because it breaks.
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode): Unconditionally encode/decode
the hostingContextID. It will be 0 for most layers.
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
(WebKit::RemoteLayerTreeTransaction::description):
- UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::create): Creation with a custom PlatformLayer* always
creates a PlatformCALayerRemoteCustom.
(WebKit::PlatformCALayerRemote::clone): Factor some code.
(WebKit::PlatformCALayerRemote::updateClonedLayerProperties):
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::create):
(WebKit::PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(WebKit::PlatformCALayerRemoteCustom::clone): Clone by making an instance of the
correct type of platform layer when possible, then wrapping a PlatformCALayerRemoteCustom
around it.
(WebKit::PlatformCALayerRemoteCustom::contents):
(WebKit::PlatformCALayerRemoteCustom::setContents):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWasCreated):
(WebKit::RemoteLayerTreeContext::layerWillBeDestroyed):
- 4:44 PM Changeset in webkit [170863] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception debugging iOS 7 NetworkAgent.loadResource is unavailable
https://bugs.webkit.org/show_bug.cgi?id=134689
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-07
Reviewed by Darin Adler.
Gracefully handle if NetworkAgent.loadResource is unavailable.
- UserInterface/Controllers/SourceMapManager.js:
(WebInspector.SourceMapManager.prototype._loadAndParseSourceMap):
- UserInterface/Models/SourceMapResource.js:
- 4:44 PM Changeset in webkit [170862] by
-
- 5 edits in trunk/Source
[UI-side compositing] Crash when starting a filter transition on a reflected layer
https://bugs.webkit.org/show_bug.cgi?id=134694
Reviewed by Tim Horton.
Source/WebCore:
Don't call the owner if we failed to find the animation key (which actually
isn't used by PlatformCALayerMac anyway).
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(-[WebAnimationDelegate animationDidStart:]):
Source/WebKit2:
When cloned layers had animations, we would fire two animationDidStart callbacks,
but the second would pass an empty animationKey string to the web process, resulting
in a crash.
Fix by not blindly copying all layer properties when cloning PlatformCALayerRemotes,
since the clone would include addedAnimations, and then get the same animations
added on top by the caller.
Also protect against an empty animation key in the animationDidStart callback.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::animationDidStart):
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):
(WebKit::PlatformCALayerRemote::clone): Don't copy all the properties; copy
them manually as PlatformCALayerMac does. Only copy the big things if they don't
have their default values.
(WebKit::PlatformCALayerRemote::copyFiltersFrom): Need an implementation of this
for clone() to call.
- 4:44 PM Changeset in webkit [170861] by
-
- 2 edits in trunk/Tools
Have MiniBrowser log and reload if the Web Content Process crashes
https://bugs.webkit.org/show_bug.cgi?id=134691
Reviewed by Tim Horton.
Implement _webViewWebProcessDidCrash, log and reload when the web process
crashes.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController _webViewWebProcessDidCrash:]):
- 4:33 PM Changeset in webkit [170860] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
Merge r170011 from trunk.
2014-06-16 Michael Saboff <msaboff@apple.com>
Convert ASSERT in inlineFunctionForCapabilityLevel to early return
https://bugs.webkit.org/show_bug.cgi?id=133903
Reviewed by Mark Hahnenberg.
Hardened code by Converting ASSERT to return CannotCompile.
- dfg/DFGCapabilities.h: (JSC::DFG::inlineFunctionForCapabilityLevel):
- 4:18 PM Changeset in webkit [170859] by
-
- 2 edits in trunk/Source/WebKit2
Nearly everything in the UIProcess "leaks" when WKWebView is torn down
https://bugs.webkit.org/show_bug.cgi?id=134699
<rdar://problem/17581777>
Reviewed by Simon Fraser.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Adoption is important!
- 2:42 PM Changeset in webkit [170858] by
-
- 9 edits in trunk/Source/WebKit2
REGRESSION(iOS WK2): arrow keys movements don't work.
https://bugs.webkit.org/show_bug.cgi?id=134561
<rdar://problem/16827629>
Reviewed by Benjamin Poulain.
This change add the implementations for cursor movement selectors.
It also provides a mechanism to ensure that every selection
change in WebKit is reflected in UIKit so that it can update the
autocorrection data. This way we ensure that the autocorraction state
is consistent even when selection changes are originated by JavaScript.
WebPageProxy::editorStateChanged now notifies the page client when the
selection is about to change as well as when it actually changed.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::editorStateChanged):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::selectionWillChange):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cut:]): Removed incorrect calls to textWillChange and
textDidChange.
(-[WKContentView paste:]):
(-[WKContentView _moveUp:withHistory:]):
(-[WKContentView _moveDown:withHistory:]):
(-[WKContentView _moveLeft:withHistory:]):
(-[WKContentView _moveRight:withHistory:]):
(-[WKContentView _moveToStartOfWord:withHistory:]):
(-[WKContentView _moveToStartOfParagraph:withHistory:]):
(-[WKContentView _moveToStartOfLine:withHistory:]):
(-[WKContentView _moveToStartOfDocument:withHistory:]):
(-[WKContentView _moveToEndOfWord:withHistory:]):
(-[WKContentView _moveToEndOfParagraph:withHistory:]):
(-[WKContentView _moveToEndOfLine:withHistory:]):
(-[WKContentView _moveToEndOfDocument:withHistory:]):
(-[WKContentView _selectionWillChange]):
(-[WKContentView _selectionChanged]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::notifySelectionWillChange):
- 2:06 PM Changeset in webkit [170857] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fast path for jsStringWithCache() when asked for the same string repeatedly.
<https://webkit.org/b/134635>
Reviewed by Darin Adler.
Follow-up to r170818 addressing a review comment by Geoff Garen.
- runtime/JSString.cpp:
(JSC::jsStringWithCacheSlowCase):
- 1:52 PM Changeset in webkit [170856] by
-
- 8 edits in trunk/Source/WebKit2
Add SPI for saving and restoring a WKWebView's _WKSessionState
https://bugs.webkit.org/show_bug.cgi?id=134693
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKPage.cpp:
(WKPageRestoreFromSessionState):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _sessionState]):
(-[WKWebView _restoreFromSessionStateData:]):
(-[WKWebView _restoreFromSessionState:]):
(-[WKWebView _restoreSessionState:andNavigate:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/Cocoa/_WKSessionState.mm:
(-[_WKSessionState _initWithSessionState:]):
- UIProcess/API/Cocoa/_WKSessionStateInternal.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromSessionState):
- UIProcess/WebPageProxy.h:
- 1:39 PM Changeset in webkit [170855] by
-
- 36 edits14 adds in branches/ftlopt
[ftlopt] Infer immutable object properties
https://bugs.webkit.org/show_bug.cgi?id=134567
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
This introduces a new way of inferring immutable object properties. A property is said to
be immutable if after its creation (i.e. the transition that creates it), we never
overwrite it (i.e. replace it) or delete it. Immutability is a property of an "own
property" - so if we say that "f" is immutable at "o" then we are implying that "o" has "f"
directly and not on a prototype. More specifically, the immutability inference will prove
that a property on some structure is immutable. This means that, for example, we may have a
structure S1 with property "f" where we claim that "f" at S1 is immutable, but S1 has a
transition to S2 that adds a new property "g" and we may claim that "f" at S2 is actually
mutable. This is mainly for convenience; it allows us to decouple immutability logic from
transition logic. Immutability can be used to constant-fold accesses to objects at
DFG-time. The DFG needs to prove the following to constant-fold the access:
- The base of the access must be a constant object pointer. We prove that a property at a structure is immutable, but that says nothing of its value; each actual instance of that property may have a different value. So, a constant object pointer is needed to get an actual constant instance of the immutable value.
- A check (or watchpoint) must have been emitted proving that the object has a structure that allows loading the property in question.
- The replacement watchpoint set of the property in the structure that we've proven the object to have is still valid and we add a watchpoint to it lazily. The replacement watchpoint set is the key new mechanism that this change adds. It's possible that we have proven that the object has one of many structures, in which case each of those structures needs a valid replacement watchpoint set.
The replacement watchpoint set is created the first time that any access to the property is
cached. A put replace cache will create, and immediately invalidate, the watchpoint set. A
get cache will create the watchpoint set and make it start watching. Any non-cached put
access will invalidate the watchpoint set if one had been created; the underlying algorithm
ensures that checking for the existence of a replacement watchpoint set is very fast in the
common case. This algorithm ensures that no cached access needs to ever do any work to
invalidate, or check the validity of, any replacement watchpoint sets. It also has some
other nice properties:
- It's very robust in its definition of immutability. The strictest that it will ever be is that for any instance of the object, the property must be written to only once, specifically at the time that the property is created. But it's looser than this in practice. For example, the property may be written to any number of times before we add the final property that the object will have before anyone reads the property; this works since for optimization purposes we only care if we detect immutability on the structure that the object will have when it is most frequently read from, not any previous structure that the object had. Also, we may write to the property any number of times before anyone caches accesses to it.
- It is mostly orthogonal to structure transitions. No new structures need to be created to track the immutability of a property. Hence, there is no risk from this feature causing more polymorphism. This is different from the previous "specificValue" constant inference, which did cause additional structures to be created and sometimes those structures led to fake polymorphism. This feature does leverage existing transitions to do some of the watchpointing: property deletions don't fire the replacement watchpoint set because that would cause a new structure and so the mandatory structure check would fail. Also, this feature is guaranteed to never kick in for uncacheable dictionaries because those wouldn't allow for cacheable accesses - and it takes a cacheable access for this feature to be enabled.
- No memory overhead is incurred except when accesses to the property are cached. Dictionary properties will typically have no meta-data for immutability. The number of replacement watchpoint sets we allocate is proportional to the number of inline caches in the program, which is typically must smaller than the number of structures or even the number of objects.
This inference is far more powerful than the previous "specificValue" inference, so this
change also removes all of that code. It's interesting that the amount of code that is
changed to remove that feature is almost as big as the amount of code added to support the
new inference - and that's if you include the new tests in the tally. Without new tests,
it appears that the new feature actually touches less code!
There is one corner case where the previous "specificValue" inference was more powerful.
You can imagine someone creating objects with functions as self properties on those
objects, such that each object instance had the same function pointers - essentially,
someone might be trying to create a vtable but failing at the whole "one vtable for many
instances" concept. The "specificValue" inference would do very well for such programs,
because a structure check would be sufficient to prove a constant value for all of the
function properties. This new inference will fail because it doesn't track the constant
values of constant properties; instead it detects the immutability of otherwise variable
properties (in the sense that each instance of the property may have a different value).
So, the new inference requires having a particular object instance to actually get the
constant value. I think it's OK to lose this antifeature. It took a lot of code to support
and was a constant source of grief in our transition logic, and there doesn't appear to be
any real evidence that programs benefited from that particular kind of inference since
usually it's the singleton prototype instance that has all of the functions.
This change is a speed-up on everything. date-format-xparb and both SunSpider/raytrace and
V8/raytrace seem to be the biggest winners among the macrobenchmarks; they see >5%
speed-ups. Many of our microbenchmarks see very large performance improvements, even 80% in
one case.
- bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::GetByIdVariant):
(JSC::GetByIdVariant::operator=):
(JSC::GetByIdVariant::attemptToMerge):
(JSC::GetByIdVariant::dumpInContext):
- bytecode/GetByIdVariant.h:
(JSC::GetByIdVariant::alternateBase):
(JSC::GetByIdVariant::specificValue): Deleted.
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeForStubInfo):
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdVariant.cpp:
(JSC::PutByIdVariant::operator=):
(JSC::PutByIdVariant::setter):
(JSC::PutByIdVariant::dumpInContext):
- bytecode/PutByIdVariant.h:
(JSC::PutByIdVariant::specificValue): Deleted.
- bytecode/Watchpoint.cpp:
(JSC::WatchpointSet::fireAllSlow):
(JSC::WatchpointSet::fireAll): Deleted.
- bytecode/Watchpoint.h:
(JSC::WatchpointSet::fireAll):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::tryGetConstantProperty):
(JSC::DFG::Graph::visitChildren):
- dfg/DFGGraph.h:
- dfg/DFGWatchableStructureWatchingPhase.cpp:
(JSC::DFG::WatchableStructureWatchingPhase::run):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
- jit/JITOperations.cpp:
- jit/Repatch.cpp:
(JSC::repatchByIdSelfAccess):
(JSC::generateByIdStub):
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::putToScopeCommon):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::mayInterceptStoreTo):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitive):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putDirectNonIndexAccessor):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defaultValue):
(JSC::getCallableObjectSlow): Deleted.
(JSC::JSObject::getPropertySpecificValue): Deleted.
- runtime/JSObject.h:
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectOffset):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putOwnDataProperty):
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::getCallableObject): Deleted.
- runtime/JSScope.cpp:
(JSC::abstractAccess):
- runtime/PropertyMapHashTable.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
(JSC::PropertyTable::copy):
- runtime/PropertyTable.cpp:
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::visitChildren): Deleted.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::allocateRareData):
(JSC::Structure::ensurePropertyReplacementWatchpointSet):
(JSC::Structure::startWatchingPropertyForReplacements):
(JSC::Structure::didCachePropertyReplacement):
(JSC::Structure::startWatchingInternalProperties):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::getConcurrently):
(JSC::Structure::get):
(JSC::Structure::add):
(JSC::Structure::visitChildren):
(JSC::Structure::prototypeChainMayInterceptStoreTo):
(JSC::Structure::dump):
(JSC::Structure::despecifyDictionaryFunction): Deleted.
(JSC::Structure::despecifyFunctionTransition): Deleted.
(JSC::Structure::despecifyFunction): Deleted.
(JSC::Structure::despecifyAllFunctions): Deleted.
(JSC::Structure::putSpecificValue): Deleted.
- runtime/Structure.h:
(JSC::Structure::startWatchingPropertyForReplacements):
(JSC::Structure::startWatchingInternalPropertiesIfNecessary):
(JSC::Structure::startWatchingInternalPropertiesIfNecessaryForEntireChain):
(JSC::Structure::transitionDidInvolveSpecificValue): Deleted.
(JSC::Structure::disableSpecificFunctionTracking): Deleted.
- runtime/StructureInlines.h:
(JSC::Structure::getConcurrently):
(JSC::Structure::didReplaceProperty):
(JSC::Structure::propertyReplacementWatchpointSet):
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::destroy):
- runtime/StructureRareData.h:
- tests/stress/infer-constant-global-property.js: Added.
(foo.Math.sin):
(foo):
- tests/stress/infer-constant-property.js: Added.
(foo):
- tests/stress/jit-cache-poly-replace-then-cache-get-and-fold-then-invalidate.js: Added.
(foo):
(bar):
- tests/stress/jit-cache-replace-then-cache-get-and-fold-then-invalidate.js: Added.
(foo):
(bar):
- tests/stress/jit-put-to-scope-global-cache-watchpoint-invalidate.js: Added.
(foo):
(bar):
- tests/stress/llint-cache-replace-then-cache-get-and-fold-then-invalidate.js: Added.
(foo):
(bar):
- tests/stress/llint-put-to-scope-global-cache-watchpoint-invalidate.js: Added.
(foo):
(bar):
- tests/stress/repeat-put-to-scope-global-with-same-value-watchpoint-invalidate.js: Added.
(foo):
(bar):
LayoutTests:
- js/regress/infer-constant-global-property-expected.txt: Added.
- js/regress/infer-constant-global-property.html: Added.
- js/regress/infer-constant-property-expected.txt: Added.
- js/regress/infer-constant-property.html: Added.
- js/regress/script-tests/infer-constant-global-property.js: Added.
- js/regress/script-tests/infer-constant-property.js: Added.
- 1:28 PM Changeset in webkit [170854] by
-
- 3 edits5 copies in trunk/Source/WebKit2
Add a stubbed out _WKSessionState class
https://bugs.webkit.org/show_bug.cgi?id=134690
Reviewed by Geoffrey Garen.
- UIProcess/API/Cocoa/_WKSessionState.h: Copied from Source/WebKit2/UIProcess/LegacySessionStateCoding.h.
- UIProcess/API/Cocoa/_WKSessionState.mm: Copied from Source/WebKit2/UIProcess/LegacySessionStateCoding.h.
(-[_WKSessionState initWithData:]):
(-[_WKSessionState data]):
- UIProcess/API/Cocoa/_WKSessionStateInternal.h: Copied from Source/WebKit2/UIProcess/LegacySessionStateCoding.h.
- UIProcess/Cocoa/SessionStateCoding.h: Copied from Source/WebKit2/UIProcess/LegacySessionStateCoding.h.
- UIProcess/Cocoa/SessionStateCoding.mm: Copied from Source/WebKit2/UIProcess/LegacySessionStateCoding.h.
(WebKit::encodeSessionState):
(WebKit::decodeSessionState):
- UIProcess/LegacySessionStateCoding.h:
- WebKit2.xcodeproj/project.pbxproj:
- 12:52 PM Changeset in webkit [170853] by
-
- 3 edits in trunk/Source/WebKit2
Some of the WKPreferences (API) property getters read like questions
https://bugs.webkit.org/show_bug.cgi?id=134678
<rdar://problem/17576847>
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKPreferences.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences javaScriptIsEnabled]):
(-[WKPreferences javaIsEnabled]):
(-[WKPreferences plugInsAreEnabled]):
(-[WKPreferences isJavaScriptEnabled]): Deleted.
(-[WKPreferences isJavaEnabled]): Deleted.
(-[WKPreferences arePlugInsEnabled]): Deleted.
- 11:50 AM Changeset in webkit [170852] by
-
- 2 edits in trunk/Source/WebKit2
ServicesOverlayController menus show up in the wrong place.
<rdar://problem/17130576> and https://bugs.webkit.org/show_bug.cgi?id=134684
Reviewed by Tim Horton.
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged): Handle cases where
the telephone number is in a subframe.
(WebKit::ServicesOverlayController::handleClick): The click point is always in main frame document
coordinates, so convert it to window coordinates using the main frame’s FrameView.
- 11:31 AM Changeset in webkit [170851] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add missing ENABLE(FTL_JIT) guards
https://bugs.webkit.org/show_bug.cgi?id=134680
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-07-07
Reviewed by Darin Adler.
- ftl/FTLDWARFDebugLineInfo.cpp:
- ftl/FTLDWARFDebugLineInfo.h:
- ftl/FTLGeneratedFunction.h:
- 11:30 AM Changeset in webkit [170850] by
-
- 5 edits in branches/safari-537.75-branch/Source
Versioning.
- 11:21 AM Changeset in webkit [170849] by
-
- 2 edits in trunk/Source/WebCore
[iOS WebGL] Fix crash with too many nested glsl functions.
https://bugs.webkit.org/show_bug.cgi?id=134683
<rdar://problem/17541529>
Patch by Alex Christensen <achristensen@webkit.org> on 2014-07-07
Reviewed by Geoffrey Garen.
This fixes the Khronos WebGL 1.0.3 test nested-functions-should-not-crash.html.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
Add SH_LIMIT_CALL_STACK_DEPTH to extraCompileOptions.
- 11:18 AM Changeset in webkit [170848] by
-
- 2 edits in trunk/Tools
update-webkitgtk-libs script fails by unsatisfied dependencies
https://bugs.webkit.org/show_bug.cgi?id=134547
Reviewed by Martin Robinson.
Install libxcb-xfixes0-dev, needed to build Mesa.
- gtk/install-dependencies:
- 10:52 AM Changeset in webkit [170847] by
-
- 1 edit2 adds in trunk/LayoutTests
Add test to ensure that SVGDocumentExtensions::rebuildElements() doesn't rebuild invalid elements
https://bugs.webkit.org/show_bug.cgi?id=134417
<rdar://problem/17479854>
Reviewed by David Kilzer.
Add a test that implicitly checks that the list of SVG elements to be rebuilt doesn't contain
removed elements. Run this test in DRT with Guard Malloc/MallocScribble (or the platform-
specific equivalent) enabled.
- svg/custom/overwrite-page-that-has-use-elements-expected.txt: Added.
- svg/custom/overwrite-page-that-has-use-elements.html: Added.
- 10:20 AM Changeset in webkit [170846] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Mac gardening after r170817.
- platform/mac-wk2/TestExpectations:
- 9:21 AM Changeset in webkit [170845] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] Assertion failure in NavigationState::LoaderClient::didStartProvisionalLoadForFrame (navigationID) when navigating through the page cache
https://bugs.webkit.org/show_bug.cgi?id=134682
Reviewed by Tim Horton.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::didStartProvisionalLoadForFrame): Replaced the
assertion with a FIXME.
(WebKit::NavigationState::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
Ditto.
(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame): Ditto.
(WebKit::NavigationState::LoaderClient::didCommitLoadForFrame): Ditto.
(WebKit::NavigationState::LoaderClient::didFinishDocumentLoadForFrame): Ditto.
(WebKit::NavigationState::LoaderClient::didFinishLoadForFrame): Ditto.
(WebKit::NavigationState::LoaderClient::didFailLoadWithErrorForFrame): Ditto.
- 4:48 AM Changeset in webkit [170844] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix cursor artifacts on naver map site.
https://bugs.webkit.org/show_bug.cgi?id=134649
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-07-07
Reviewed by Gyuyoung Kim.
Old evas cursor and ecore x cursor are reset before new cursor is applied.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::updateCursor):
- 2:04 AM Changeset in webkit [170843] by
-
- 5 edits in trunk/Source
Enable ARMv7 disassembler for the GTK port
https://bugs.webkit.org/show_bug.cgi?id=134676
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- CMakeLists.txt: Add ARMv7DOpcode.cpp file to the build.
- disassembler/ARMv7/ARMv7DOpcode.cpp: Include the string.h header for strlen().
Source/WTF:
- wtf/Platform.h: Enable the ARMv7 disassembler for the GTK port when
targeting the ARMv7 architecture.
- 12:38 AM Changeset in webkit [170842] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
Remove failure expectations for tests that have been passing after r168046, r168350, r168400,
r168479, r169309, r169620, r169689 and r169799.
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-07-07
- platform/gtk/TestExpectations:
- 12:16 AM Changeset in webkit [170841] by
-
- 6 edits6 adds in trunk
[CSS Blending]The background images set on the root element will blend on an initial white backdrop.
https://bugs.webkit.org/show_bug.cgi?id=134342
Reviewed by Dean Jackson.
Source/WebCore:
Tests: css3/blending/background-blend-mode-body-image.html
css3/blending/background-blend-mode-body-transparent-color-and-image.html
css3/blending/background-blend-mode-body-transparent-image.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
If the background layers have blend modes, we paint the base background color first,
before starting a new transparency layer. After creating the transparency layer,
the base background will be skipped, and the background layers will blend on top of
a transparent backdrop.
(WebCore::RenderBox::paintFillLayer):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
This method is able to paint only the base background color (BaseBackgroundColorOnly),
skipping the background-color and background-images. This option is available only
on bottom layer of the root renderer and only if the background color is not opaque,
otherwise the method will return early.
Another option is to paint the root background without using the base background color
(BaseBackgroundColorSkip).
- rendering/RenderBoxModelObject.h:
Adding the BaseBackgroundColorUsage enum.
LayoutTests:
- css3/blending/background-blend-mode-body-image-expected.html: Added.
- css3/blending/background-blend-mode-body-image.html: Added.
- css3/blending/background-blend-mode-body-transparent-color-and-image-expected.html: Added.
- css3/blending/background-blend-mode-body-transparent-color-and-image.html: Added.
- css3/blending/background-blend-mode-body-transparent-image-expected.html: Added.
- css3/blending/background-blend-mode-body-transparent-image.html: Added.
- 12:14 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
Jul 6, 2014:
- 11:26 PM Changeset in webkit [170840] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] The tap highlight ID is not invalidated when a long press ends
https://bugs.webkit.org/show_bug.cgi?id=134660
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-06
Reviewed by Darin Adler.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _cancelInteraction]):
(-[WKContentView _finishInteraction]):
(cancelPotentialTapIfNecessary):
I messed that up in r170600. I only accounted for the web process being too fast.
If the web process is too slow, _cancelInteraction or _finishInteraction happen before
_didGetTapHighlightForRequest:, and we also need to nuke the tap highlight.
- 11:24 PM Changeset in webkit [170839] by
-
- 5 edits in trunk/Source/JavaScriptCore
[ARMv7] Use 16 bits instructions for push/pop when possible
https://bugs.webkit.org/show_bug.cgi?id=134656
Reviewed by Andreas Kling.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::pop):
(JSC::ARMv7Assembler::push):
(JSC::ARMv7Assembler::ARMInstructionFormatter::oneWordOp7Imm9):
Add the 16 bits version of push and pop.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::pop):
(JSC::MacroAssemblerARMv7::push):
Use the new push/pop instead of a regular load/store.
- disassembler/ARMv7/ARMv7DOpcode.cpp:
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterList):
- disassembler/ARMv7/ARMv7DOpcode.h:
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::registerMask):
Fix the disassembler for push/pop:
-The register mask was on 7 bits for some reason.
-The code printing the registers was comparing a register ID with a register
mask.
- 11:04 PM Changeset in webkit [170838] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] Don't support dynamically enabling the RemoteLayerTree debug indicator
https://bugs.webkit.org/show_bug.cgi?id=134644
Reviewed by Darin Adler.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setShouldShowDebugIndicator): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::preferencesDidChange):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::initializeDebugIndicator):
(WebKit::RemoteLayerTreeDrawingAreaProxy::setShouldShowDebugIndicator): Deleted.
The indicator depends on the live layer tree commits coming in, including layer creation,
so it can't be turned on after the root layer is created. Even a refresh is insufficient
to get it working; the debug indicator really needs to exist from the first commit.
So, don't even attempt to dynamically enable the indicator; create it at
RemoteLayerTreeDrawingAreaProxy construction time if the pref is enabled.
- 10:02 PM Changeset in webkit [170837] by
-
- 18 edits in trunk
Turn on img@sizes compile flag
https://bugs.webkit.org/show_bug.cgi?id=134634
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.
Source/WebKit:
- mac/Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig: Moved compile flag to alphabetical order.
Source/WTF:
- wtf/FeatureDefines.h: Added compile flag definition.
Tools:
- Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props: Added compile flag.
LayoutTests:
- TestExpectations: Turned on layout tests for the img@sizes feature.
- 9:49 PM Changeset in webkit [170836] by
-
- 27 edits in branches/ftlopt/Source/JavaScriptCore
Add more coverage for the profile_types_with_high_fidelity op code.
https://bugs.webkit.org/show_bug.cgi?id=134616
Patch by Saam Barati <sbarati@apple.com> on 2014-07-03
Reviewed by Filip Pizlo.
More operations are now being recorded by the profile_types_with_high_fidelity
opcode. Specifically: function parameters, function return values,
function 'this' value, get_by_id, get_by_value, resolve nodes, function return
values at the call site. Added more flags to the profile_types_with_high_fidelity
opcode so more focused tasks can take place when the instruction is
being linked in CodeBlock. Re-worked the type profiler to search
through character offset ranges when asked for the type of an expression
at a given offset. Removed redundant calls to Structure::toStructureShape
in HighFidelityLog and TypeSet by caching calls based on StructureID.
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::scopeDependentProfile):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::returnStatementTypeSet):
- bytecode/TypeLocation.h:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::highFidelityTypeProfileExpressionInfoForBytecodeOffset):
(JSC::UnlinkedCodeBlock::addHighFidelityTypeProfileExpressionInfo):
- bytecode/UnlinkedCodeBlock.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::emitProfileTypesWithHighFidelity):
(JSC::BytecodeGenerator::emitGetFromScopeWithProfile):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::emitPutToScopeWithProfile):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitPutByVal):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitHighFidelityTypeProfilingExpressionInfo):
- bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::emitBytecode):
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
(JSC::PrefixNode::emitResolve):
(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::AssignDotNode::emitBytecode):
(JSC::ReadModifyDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):
(JSC::ReadModifyBracketNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypeForVariableAtOffset):
(Inspector::InspectorRuntimeAgent::getRuntimeTypeForVariableInTextRange): Deleted.
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/protocol/Runtime.json:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::getFromScopeCommon):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- runtime/HighFidelityLog.cpp:
(JSC::HighFidelityLog::processHighFidelityLog):
(JSC::HighFidelityLog::actuallyProcessLogThreadFunction):
(JSC::HighFidelityLog::recordTypeInformationForLocation): Deleted.
- runtime/HighFidelityLog.h:
(JSC::HighFidelityLog::recordTypeInformationForLocation):
- runtime/HighFidelityTypeProfiler.cpp:
(JSC::HighFidelityTypeProfiler::getTypesForVariableInAtOffset):
(JSC::HighFidelityTypeProfiler::getGlobalTypesForVariableAtOffset):
(JSC::HighFidelityTypeProfiler::getLocalTypesForVariableAtOffset):
(JSC::HighFidelityTypeProfiler::insertNewLocation):
(JSC::HighFidelityTypeProfiler::findLocation):
(JSC::HighFidelityTypeProfiler::getTypesForVariableInRange): Deleted.
(JSC::HighFidelityTypeProfiler::getGlobalTypesForVariableInRange): Deleted.
(JSC::HighFidelityTypeProfiler::getLocalTypesForVariableInRange): Deleted.
(JSC::HighFidelityTypeProfiler::getLocationBasedHash): Deleted.
- runtime/HighFidelityTypeProfiler.h:
(JSC::LocationKey::LocationKey): Deleted.
(JSC::LocationKey::hash): Deleted.
(JSC::LocationKey::operator==): Deleted.
- runtime/Structure.cpp:
(JSC::Structure::toStructureShape):
- runtime/Structure.h:
- runtime/TypeSet.cpp:
(JSC::TypeSet::TypeSet):
(JSC::TypeSet::addTypeForValue):
(JSC::TypeSet::seenTypes):
(JSC::TypeSet::removeDuplicatesInStructureHistory): Deleted.
- runtime/TypeSet.h:
(JSC::StructureShape::setConstructorName):
- runtime/VM.cpp:
(JSC::VM::getTypesForVariableAtOffset):
(JSC::VM::dumpHighFidelityProfilingTypes):
(JSC::VM::getTypesForVariableInRange): Deleted.
- runtime/VM.h:
- 8:42 PM Changeset in webkit [170835] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself to committers.
- Scripts/webkitpy/common/config/contributors.json:
- 7:06 PM Changeset in webkit [170834] by
-
- 2 edits in trunk/Source/JavaScriptCore
Flags value of SourceCodeKey should be unique for each case.
https://bugs.webkit.org/show_bug.cgi?id=134435
Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2014-07-06
Reviewed by Darin Adler.
Different combinations of CodeType and JSParserStrictness could generate same m_flags value because
the value of CodeType and the value of JSParserStrictness shares a bit inside m_flags member variable.
Shift the value of CodeType one bit farther to the left so those values don't overlap.
- runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey):
- 6:22 PM Changeset in webkit [170833] by
-
- 4 edits in trunk/Source/WebCore
Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeHelpers
https://bugs.webkit.org/show_bug.cgi?id=134647
Reviewed by Andreas Kling.
Use type cast macro and generation tag for isFoo() and toFoo() in some MathML classes.
No new tests, no behavior change.
- mathml/MathMLElement.h: Place MathMLElementTypeHelpers.h to the bottom of the
file so that functions from that file can use the Element|Node classes and other things defined in this file.
- mathml/MathMLMencloseElement.h:
(WebCore::toMathMLMencloseElement): Deleted.
- mathml/mathtags.in:
- 6:18 PM Changeset in webkit [170832] by
-
- 10 edits in trunk/Source/WebCore
CSS JIT: Ensure resolvingMode size is 1 byte
https://bugs.webkit.org/show_bug.cgi?id=134662
Reviewed by Benjamin Poulain.
Since selector compiler uses MacroAssembler::branch8 for SelectorChecker::Mode,
we should ensure sizeof(SelectorChecker::Mode) == 1.
Old implementation works only in little endianness environments.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchedResult):
(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
- css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::ElementRuleCollector):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
- css/SelectorChecker.h:
- css/StyleInvalidationAnalysis.cpp:
(WebCore::invalidateStyleRecursively):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::pseudoStyleRulesForElement):
- css/StyleResolver.h:
(WebCore::checkRegionSelector):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::jumpIfNotResolvingStyle):
(WebCore::SelectorCompiler::elementIsActiveForStyleResolution):
(WebCore::SelectorCompiler::elementIsHoveredForStyleResolution):
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):
- 5:01 PM Changeset in webkit [170831] by
-
- 3 edits in trunk/Source/WebKit2
Speculative fix for: NetworkProcess sometimes hangs under copyDefaultCredentialForProtectionSpace
https://bugs.webkit.org/show_bug.cgi?id=134666
Reviewed by Tim Horton.
- Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::encode): Encode whether or not the query dictionary exists.
(WebKit::SecItemRequestData::decode): Only fail when query dictionary fails to decode if we expect one.
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::secItemRequest): If the request is of type Invalid, log an error message asking
for a bug, and respond with an "invalid parameter" error.
- 1:05 PM Changeset in webkit [170830] by
-
- 5 edits in trunk/Source
Don't throttle layer flushes when the main resource is a GIF
https://bugs.webkit.org/show_bug.cgi?id=134650
Source/WebCore:
<rdar://problem/17490712>
Reviewed by Simon Fraser.
Avoid throttling big image animations.
- page/FrameView.cpp:
(WebCore::determineLayerFlushThrottleState):
Disable for image documents.
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::updateLayerFlushThrottling):
Refactor a bit.
- page/LayerFlushThrottleState.h:
Rename the flag.
Source/WebKit2:
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::adjustLayerFlushThrottling):
- 11:03 AM Changeset in webkit [170829] by
-
- 2 edits in trunk/Source/WebCore
Inline NodeListsNodeData helpers more aggressively.
<https://webkit.org/b/134654>
Get rid of call overhead costs when retrieving NodeLists and
HTMLCollections from Document. These functions have very few clients,
so there's no real reason to keep them out of line.
Reviewed by Antti Koivisto.
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
- 11:01 AM Changeset in webkit [170828] by
-
- 4 edits in trunk/Source/WebCore
Inline Node's rare data getters.
<https://webkit.org/b/134652>
There was a fair bit of overhead when calling Node::ensureRareData()
from Document's collection getters. This patch inlines the case where
we've already materialized the rare data.
Reviewed by Antti Koivisto.
- dom/Node.cpp:
(WebCore::Node::materializeRareData):
(WebCore::Node::rareData): Deleted.
(WebCore::Node::ensureRareData): Deleted.
- dom/Node.h:
- dom/NodeRareData.h:
(WebCore::Node::rareData):
(WebCore::Node::ensureRareData):
Jul 5, 2014:
- 5:03 PM Changeset in webkit [170827] by
-
- 2 edits in trunk/Source/WebCore
[iOS] MediaDocument should set a viewport
https://bugs.webkit.org/show_bug.cgi?id=134658
<rdar://problem/17552339>
Reviewed by Zalan Bujtas.
A MediaDocument should fill the viewport, so set its
initial-scale to 1 and make it non-zoomable.
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure): Create
a <head> element and a <meta> element with a 1:1 viewport.
- 10:56 AM Changeset in webkit [170826] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r170825.
https://bugs.webkit.org/show_bug.cgi?id=134653
broke debug builds (Requested by kling on #webkit).
Reverted changeset:
"Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS
macro and generateTypeHelpers"
https://bugs.webkit.org/show_bug.cgi?id=134647
http://trac.webkit.org/changeset/170825
- 10:36 AM Changeset in webkit [170825] by
-
- 4 edits in trunk/Source/WebCore
Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeHelpers
https://bugs.webkit.org/show_bug.cgi?id=134647
Reviewed by Andreas Kling.
Use type cast macro and generation tag for isFoo() and toFoo() in some MathML classes.
No new tests, no behavior change.
- mathml/MathMLElement.h: Place MathMLElementTypeHelpers.h to the bottom of the
file so that functions from that file can use the Element|Node classes and other things defined in this file.
(WebCore::isMathMLElement): Deleted.
- mathml/MathMLMencloseElement.h:
(WebCore::toMathMLMencloseElement): Deleted.
- mathml/mathtags.in:
- 3:29 AM Changeset in webkit [170824] by
-
- 2 edits in trunk/Tools
[EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
https://bugs.webkit.org/show_bug.cgi?id=134648
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-07-05
Reviewed by Gyuyoung Kim.
As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.
- efl/install-dependencies:
Jul 4, 2014:
- 11:33 PM Changeset in webkit [170823] by
-
- 8 edits in trunk
[EFL] Support Geolocation
https://bugs.webkit.org/show_bug.cgi?id=134439
Reviewed by Antonio Gomes.
.:
- Source/cmake/OptionsEfl.cmake: Turn on ENABLE_GEOLOCATION.
Source/WebCore:
Add geoclue files in order to enable geolocation for EFL port.
- PlatformEfl.cmake:
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.
LayoutTests:
- platform/efl/TestExpectations: Unskip geolocation tests.
- 10:25 PM Changeset in webkit [170822] by
-
- 4 edits in trunk/Source/WebCore
CSS JIT: compile :in-range and :out-of-range
https://bugs.webkit.org/show_bug.cgi?id=134639
Reviewed by Andreas Kling.
The pseudo class :in-range and :out-of-range are trivial non-inlined selectors.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/SelectorCheckerTestFunctions.h:
(WebCore::isInRange):
(WebCore::isOutOfRange):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
- 9:43 PM Changeset in webkit [170821] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
Merge trunk r169595.
2014-06-04 Filip Pizlo <fpizlo@apple.com>
DFG::Safepoint::begin() should set m_didCallBegin before releasing the rightToRun lock, because otherwise, Safepoint::checkLivenessAndVisitChildren() may assert due to a race
https://bugs.webkit.org/show_bug.cgi?id=133525
<rdar://problem/16790296>
Reviewed by Oliver Hunt.
- dfg/DFGSafepoint.cpp: (JSC::DFG::Safepoint::begin):
- 9:28 PM Changeset in webkit [170820] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
https://bugs.webkit.org/show_bug.cgi?id=134485
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-07-04
Reviewed by Gyuyoung Kim.
Use script_execute_callback to get selected/highlighted text and show in search bar.
- MiniBrowser/efl/main.c:
(script_execute_callback):
(on_key_down):
- 9:13 PM Changeset in webkit [170819] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt][REGRESSION] debug tests fail because PutByIdDirect is now implemented in terms of In
https://bugs.webkit.org/show_bug.cgi?id=134642
Rubber stamped by Andreas Kling.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
- 8:36 PM Changeset in webkit [170818] by
-
- 10 edits in trunk/Source
Fast path for jsStringWithCache() when asked for the same string repeatedly.
<https://webkit.org/b/134635>
Source/JavaScriptCore:
Also moved the whole thing from WebCore to JavaScriptCore since it
makes more sense here, and inline the lightweight checks, leaving only
the hashmap stuff out of line.
Reviewed by Darin Adler.
- runtime/JSString.cpp:
(JSC::jsStringWithCacheSlowCase):
- runtime/JSString.h:
(JSC::jsStringWithCache):
- runtime/VM.h:
Source/WebCore:
Reviewed by Darin Adler.
- WebCore.exp.in:
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringWithCache): Deleted.
- bindings/js/JSDOMBinding.h:
(WebCore::JSValueTraits<String>::arrayJSValue):
(WebCore::jsStringWithCache): Deleted.
- bridge/c/c_utility.cpp:
(JSC::Bindings::convertNPVariantToValue):
- loader/cache/CachedResourceHandle.h:
- 8:03 PM Changeset in webkit [170817] by
-
- 3 edits2 adds in trunk
Subpixel rendering: ebay.com rotating billboard on the main page has cut off buttons.
https://bugs.webkit.org/show_bug.cgi?id=134636
<rdar://problem/17529112>
Reviewed by Darin Adler.
Missing pixel snapping when clipping the transparency layer for BackgroundBleedUseTransparencyLayer.
Clipping needs to take the same snapping strategy as the rest of the painting code.
Source/WebCore:
Test: fast/borders/border-radius-on-subpixel-position-non-hidpi.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
LayoutTests:
- fast/borders/border-radius-on-subpixel-position-non-hidpi-expected.html: Added.
- fast/borders/border-radius-on-subpixel-position-non-hidpi.html: Added.
- 6:29 PM Changeset in webkit [170816] by
-
- 4 edits in trunk/Source/WebCore
QualifiedName should use RefPtr<QualifiedNameImpl> internally.
<https://webkit.org/b/132796>
We were not inlining ~QualifiedName() and it was showing up in some
profiles (over 1% on dom-attr.html.)
This patch modernizes QualifiedName a bit by using RefPtr to store
the QualifiedNameImpl instead of doing manual ref() and deref()
in out-of-line functions.
Reviewed by Darin Adler.
- WebCore.exp.in:
- dom/QualifiedName.cpp:
(WebCore::QNameComponentsTranslator::translate):
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::~QualifiedName): Deleted.
(WebCore::QualifiedName::deref): Deleted.
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::create):
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::isHashTableDeletedValue):
(WebCore::QualifiedName::~QualifiedName):
(WebCore::QualifiedName::operator=):
(WebCore::QualifiedName::impl):
(WebCore::QualifiedName::ref): Deleted.
- 4:03 PM Changeset in webkit [170815] by
-
- 2 edits in trunk/Source/WebCore
[iOS] [Media] Prevent page zoom if it started in the video element
https://bugs.webkit.org/show_bug.cgi?id=134640
<rdar://problem/16630794>
Reviewed by Sam Weinig.
In r170572 I attempted to prevent the page zoom from happening
when the user was attempting to fullscreen the video. That fix was
not complete, because it relied on the touchstart event being
sent before a gesture event. It turns out this doesn't always happen,
so we need to apply the same check in the gesture event - if the
gesture began with two fingers on the media, don't do a page zoom.
The exception is zooming out, if you've managed to make the video
cover the entire screen (also, the pinch-out-of-fullscreen gesture
does not get handled by WebKit).
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handleBaseGestureChange): Add a check to
make sure our pinch didn't start in the video element.
- 3:27 PM Changeset in webkit [170814] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2]Fix build break in EFL WK2
https://bugs.webkit.org/show_bug.cgi?id=134629
Unreviewed build fix.
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-07-04
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::scheduleCompositingLayerFlushImmediately):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
- 3:26 PM Changeset in webkit [170813] by
-
- 5 edits in trunk/Source/WebCore
[CoordinatedGraphics] Use the C++11 syntax to clean-up for loops
https://bugs.webkit.org/show_bug.cgi?id=134594
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-07-04
Reviewed by Darin Adler.
Convert a couple of loops to range-based for
No change in functionality, no new tests.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::purgeBackingStores):
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStore::removeAllTiles):
(WebCore::CoordinatedBackingStore::paintToTextureMapper):
(WebCore::CoordinatedBackingStore::drawBorder):
(WebCore::CoordinatedBackingStore::drawRepaintCounter):
(WebCore::CoordinatedBackingStore::commitTileOperations):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):
(WebCore::CoordinatedGraphicsScene::commitPendingBackingStoreOperations):
- 2:54 PM Changeset in webkit [170812] by
-
- 2 edits in trunk/Tools
Build fix after r170811.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController reload:]):
- 2:00 PM Changeset in webkit [170811] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] -[WKWebView _reload] is unused
https://bugs.webkit.org/show_bug.cgi?id=134638
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _reload]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 1:49 PM Changeset in webkit [170810] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Take TopContentInset into account when sending dictionary lookup point to PluginView
https://bugs.webkit.org/show_bug.cgi?id=134624
<rdar://problem/17222041>
Reviewed by Sam Weinig.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::performDictionaryLookupAtLocation):
Perform the same coordinate conversion we use for mouse events, which happens
to take the top content inset into account.
- 12:54 PM Changeset in webkit [170809] by
-
- 6 edits in trunk/Source/WebCore
CTTE: ScriptElement always has a HTTPScriptElement or SVGScriptElement.
<https://webkit.org/b/134637>
Have ScriptElement store the pointer to the more specific subclass
element as a reference. Also made the constructor protected since
nobody should instantiate ScriptElement directly.
Reviewed by Antti Koivisto.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::childrenChanged):
(WebCore::ScriptElement::dispatchErrorEvent):
(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::executeScript):
(WebCore::ScriptElement::notifyFinished):
(WebCore::ScriptElement::ignoresLoadRequest):
(WebCore::ScriptElement::scriptContent):
- dom/ScriptElement.h:
(WebCore::ScriptElement::element):
- dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::queueScriptForExecution):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::HTMLScriptElement):
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::SVGScriptElement):
- 12:12 PM Changeset in webkit [170808] by
-
- 10 edits in trunk
input type=range element should only fire change events after committing a value
https://bugs.webkit.org/show_bug.cgi?id=134545
Patch by Julien Quint <pom@graougraou.com> on 2014-07-04
Reviewed by Dean Jackson.
Source/WebCore:
A "change" event was fired every time the slider thumb element was dragged
by the user. The "change" event is now fired only after the thumb
element has stopped moving; previously, both "input" and "change" events
where dispatched while changes were being made. This new behavior is
consistent with the specification (cf.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#event-input-change),
as well as other implementations such as Firefox and Chrome.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls): Listen to the "input" event
rather than the "change" event for the timeline control in order to
keep track of value changes when the user is dragging the thumb.
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::setValue): Dispatch "change" event while
setting the new value rather than dispatching later, since setting the
value now clears the change flag.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::setValue): Update the text value of the
control in the case when no event is to be dispatched, so that this
value can be checked the next time a "change" event dispatch is
requested.
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint): Removed the
dispatch of the "change" event, and no longer track the text value of
the element as a result of dispatching a "change" event.
(WebCore::SliderThumbElement::stopDragging): Dispatch the "change" event
on completing the drag.
LayoutTests:
Two existing tests are updated to count "input" events as well as
"change" events. The tests now verify that "change" is only fired once
after every slider drag completes, whereas "input" may be fired more
than once.
- fast/forms/range/range-drag-expected.txt:
- fast/forms/range/range-drag-when-toggled-disabled-expected.txt:
- fast/forms/range/range-drag-when-toggled-disabled.html:
- fast/forms/range/range-drag.html:
- 11:07 AM Changeset in webkit [170807] by
-
- 4 edits in trunk/Source/WebCore
CTTE: ApplicationCacheHost always has a DocumentLoader.
<https://webkit.org/b/b/128435>
Have ApplicationCacheHost store the backpointer to its owning
DocumentLoader as a reference.
Reviewed by Sam Weinig.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::ApplicationCacheHost):
(WebCore::ApplicationCacheHost::~ApplicationCacheHost):
(WebCore::ApplicationCacheHost::selectCacheWithoutManifest):
(WebCore::ApplicationCacheHost::selectCacheWithManifest):
(WebCore::ApplicationCacheHost::maybeLoadMainResource):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainResponse):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainError):
(WebCore::ApplicationCacheHost::failedLoadingMainResource):
(WebCore::ApplicationCacheHost::finishedLoadingMainResource):
(WebCore::ApplicationCacheHost::maybeLoadResource):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForError):
(WebCore::ApplicationCacheHost::maybeLoadSynchronously):
(WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
(WebCore::ApplicationCacheHost::stopDeferringEvents):
(WebCore::ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache):
(WebCore::ApplicationCacheHost::update):
(WebCore::ApplicationCacheHost::swapCache):
(WebCore::ApplicationCacheHost::abort):
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
- loader/appcache/ApplicationCacheHost.h:
(WebCore::ApplicationCacheHost::documentLoader): Deleted.
- 8:31 AM Changeset in webkit [170806] by
-
- 17 edits1 add in trunk/LayoutTests
buildAccessibilityTree() needs to be removed from individual layout tests
https://bugs.webkit.org/show_bug.cgi?id=95286
Reviewed by Chris Fleizach.
Extracted two functions to 'dump' and 'touch' the accessibility
hierarchies out of different layout tests and into a single file,
living in LayoutTests/resources/accessibility-helper.js
- resources/accessibility-helper.js: Added.
(dumpAccessibilityTree): New, based on buildAccessibilityTree()
for the cases where it was used to actually 'dump' it into the output.
(touchAccessibilityTree): Same, but for the cases where we don't
want to dump the accessibility tree, just to make sure is generated.
Updated affected layout tests to use the newly added helper functions.
- accessibility/adjacent-continuations-cause-assertion-failure.html: Updated.
- accessibility/children-changed-sends-notification.html: Ditto.
- accessibility/deleting-iframe-destroys-axcache.html: Ditto.
- accessibility/div-within-anchors-causes-crash.html: Ditto.
- accessibility/first-letter-text-transform-causes-crash.html: Ditto.
- accessibility/image-map-update-parent-crash.html: Ditto.
- accessibility/table-with-empty-thead-causes-crash.html: Ditto.
- platform/efl/accessibility/media-emits-object-replacement.html: Ditto.
- platform/gtk/accessibility/entry-and-password.html: Ditto.
- platform/gtk/accessibility/media-emits-object-replacement.html: Ditto.
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Ditto.
Updated Mac specific expectations not to print the "End of test" element.
- platform/mac-wk2/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated.
- platform/mac/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Ditto.
- platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Ditto.
- platform/mac/accessibility/div-within-anchors-causes-crash-expected.txt: Ditto.
- 6:55 AM Changeset in webkit [170805] by
-
- 3 edits2 adds in trunk
REGRESSION(r159345): Lines are clipped between pages when printing web content from Safari
https://bugs.webkit.org/show_bug.cgi?id=134633
Source/WebCore:
<rdar://problem/17088936>
Reviewed by Zalan Bujtas.
Test: printing/simple-lines-break.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
Disable simple lines if global pagination is enabled.
Printing does not currently use flow threads which we already test for.
LayoutTests:
Reviewed by Zalan Bujtas.
- printing/simple-lines-break-expected.html: Added.
- printing/simple-lines-break.html: Added.
- 4:19 AM Changeset in webkit [170804] by
-
- 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r170707 - [GTK] WebKitVersion.h should be shared between UI and Web Process APIs
https://bugs.webkit.org/show_bug.cgi?id=134538
Reviewed by Martin Robinson.
To be able to check current version from web extensions too.
- UIProcess/API/gtk/WebKitVersion.h.in: Allow to include WebKitVersion.h also from webkit-web-extension.h.
- WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h: Include WebKitVersion.h.
- 3:46 AM Changeset in webkit [170803] by
-
- 7 edits in releases/WebKitGTK/webkit-2.4
Merge r163519 - Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro
https://bugs.webkit.org/show_bug.cgi?id=128267
Reviewed by Andreas Kling.
Source/WTF:
Remove the WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS macro that was manually defined for compilers
that support the C++11 initializer lists. The feature is well supported in Clang, MSVC and also GCC. It
was actually already used unguarded in HashSet.
- wtf/Compiler.h:
- wtf/HashMap.h:
(WTF::HashMap::HashMap):
- wtf/Vector.h:
(WTF::Vector::Vector):
Tools:
Remove the COMPILER_SUPPORTS(CXX_GENERALIZED_INITIALIZERS) as the underlying macro is also
being removed since the feature is supported by all the compilers the project approves.
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
- 3:33 AM Changeset in webkit [170802] by
-
- 2 edits in trunk/Tools
Typo in watchlist config means four specific people get Cc'd on everything
https://bugs.webkit.org/show_bug.cgi?id=134626
Reviewed by Gyuyoung Kim.
- Scripts/webkitpy/common/config/watchlist:
Remove leading pipe, which meant that this rule matched everything!
- 2:58 AM Changeset in webkit [170801] by
-
- 3 edits in trunk/Source/WebKit2
2014-07-04 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK WK2 build fix after r170787.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scheduleCompositingLayerFlushImmediately):
- WebProcess/WebPage/DrawingAreaImpl.h:
- 1:55 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:55 AM Changeset in webkit [170800] by
-
- 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Merge r170526 - [GTK] 8tracks.com triggers annoying pop-up window/installation of "About protocol source plugin" (GStreamer?)
https://bugs.webkit.org/show_bug.cgi?id=133605
Reviewed by Carlos Garcia Campos.
Don't attempt to load blank URLs with the GStreamer media
player. Those URLs trigger the codec installer which is useless in
this scenario. This patch also renames some of the variables of
the ::load method, as suggested by Carlos.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Check video-sink validity before disconnecting its signal handlers.
(WebCore::MediaPlayerPrivateGStreamer::load): Don't load blank
URLs (about:blank).
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Disconnect repaint handler only if it's valid.
- 1:50 AM Changeset in webkit [170799] by
-
- 7 edits in trunk/Source
Source/WebCore: Unreviewed. Fixing the build after r170795.
Mac didn't like that change as it seems to properly typedef long long to int64_t.
That's not the case on 64-bit Linux (for some reason), so I'm changing the type of
the two long long variables in FormDataElement to int64_t to avoid any further trouble.
- platform/network/FormData.h:
Source/WebKit2: Unreviewed. Reverting the bad changes introduced in r170795.
- Platform/IPC/ArgumentDecoder.cpp:
(IPC::ArgumentDecoder::decode): Deleted.
- Platform/IPC/ArgumentDecoder.h:
- Platform/IPC/ArgumentEncoder.cpp:
(IPC::ArgumentEncoder::encode): Deleted.
- Platform/IPC/ArgumentEncoder.h:
- 1:48 AM Changeset in webkit [170798] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Merge r169896 - [GTK] fails to build with --disable-webgl --disable-accelerated-compositing
https://bugs.webkit.org/show_bug.cgi?id=131267
Reviewed by Philippe Normand.
Add missing headers needed for Float32Array::create().
- Modules/webaudio/AudioBuffer.cpp:
- 1:48 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:38 AM Changeset in webkit [170797] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Merge r169935 - [GTK] GLContextEGL.cpp: conflicting declaration 'typedef ptrdiff_t GLintptr'
https://bugs.webkit.org/show_bug.cgi?id=133550
Reviewed by Gustavo Noronha Silva.
Cairo includes some definitions from GLX that conflict with the
ones provided by our GLES2 headers (GLintptr, GLsizeiptr).
Since GLContextEGL doesn't use any GLX functions we can safely
disable the inclusion of those functions in that source file.
- platform/graphics/egl/GLContextEGL.cpp:
- 1:36 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:28 AM Changeset in webkit [170796] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Tools
Merge r169768 - [GTK][gtkdoc] remove -Wcast-align
https://bugs.webkit.org/show_bug.cgi?id=133640
Apparently gcc warns that GParamSpec is not castable to
GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
though ARM hackers claim that those only need 4byte alignment. As long as gcc
behaves that way, this warning is not very useful, also they break the Debian
packaging.
This patch appends the compiler flag -Wno-align-cast for the gtkdoc
scanner compilation, thus the compiler ignores the previous
-Waling-cast flag.
Reviewed by Martin Robinson.
- gtk/generate-gtkdoc:
(get_generator_for_config):
- 1:27 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:24 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:23 AM Changeset in webkit [170795] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed. Fixing the build for ports on 64-bit Linux.
Add IPC encoding and decoding overloads for the long long type, needed
after r170755 started encoding and decoding long long variables in
FormDataElement.
- Platform/IPC/ArgumentDecoder.cpp:
(IPC::ArgumentDecoder::decode):
- Platform/IPC/ArgumentDecoder.h:
- Platform/IPC/ArgumentEncoder.cpp:
(IPC::ArgumentEncoder::encode):
- Platform/IPC/ArgumentEncoder.h:
- 1:09 AM Changeset in webkit [170794] by
-
- 3 edits in releases/WebKitGTK/webkit-2.4/Source/JavaScriptCore
[GTK] [Stable] Crash while playing a video
https://bugs.webkit.org/show_bug.cgi?id=133940
Unreviewed. Rolling out r160688.
- jit/CCallHelpers.h:
- jit/Repatch.cpp:
(JSC::generateProtoChainAccessStub):
(JSC::tryBuildGetByIDList):
- 12:55 AM Changeset in webkit [170793] by
-
- 5 edits in releases/WebKitGTK/webkit-2.4
Merge r170359 - Source/WebCore: [ATK] Don't ignore links rendered as blocks.
https://bugs.webkit.org/show_bug.cgi?id=130941
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-24
Reviewed by Mario Sanchez Prada.
- /m/usr/src/webkit-trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(WebCore::AccessibilityObject::objectFocusedAndCaretOffsetUnignored): Don't ignore links
when they are renderered with display:block.
LayoutTests: [ATK] Extended the test for accessibility of text inside "span" block in "a" block
with the tests for caret movements in these cases.
https://bugs.webkit.org/show_bug.cgi?id=130941
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-24
Reviewed by Mario Sanchez Prada.
- platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt:
- platform/gtk/accessibility/text-in-span-block-in-a-block.html:
Added testing for text-caret-moved signal. Added one more "a" element to the set.
- 12:55 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:50 AM Changeset in webkit [170792] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.4
Merge r169936 - Source/WebCore: [ATK] Fix text inside "span" block in "a" block was not accessible.
https://bugs.webkit.org/show_bug.cgi?id=132349
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp: Add link role to the list of roles whose objects always expose atk_text interface.
LayoutTests: [ATK] Add test for accessibility of text inside "span" block in "a" block.
https://bugs.webkit.org/show_bug.cgi?id=132349
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.
- platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt: Added.
- platform/gtk/accessibility/text-in-span-block-in-a-block.html: Added.
- 12:48 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:43 AM Changeset in webkit [170791] by
-
- 10 edits6 adds in releases/WebKitGTK/webkit-2.4
Merge r169483 - Tools: [ATK] Added new accessibility signal: text-caret-moved.
Make AccessibilityUIElement.setSelectedTextRange work
as atk_text_set_caret_offset when given offset == 0.
https://bugs.webkit.org/show_bug.cgi?id=132527
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-05-30
Reviewed by Mario Sanchez Prada.
text-caret-moved signal in accessibilityController is needed to
implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
as LayoutTests. Add the signal to the controller.
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(setSelectedTextRange): Change return type to bool.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(axObjectEventListener): Add notification name AXTextCaretMoved, allow
for extra arguments passed to handler and use it for text-caret-moved offset.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connect callback to new listener for ATK:AtkText:text-caret-moved.
Refactor so that failures be reported.
Initialize atk interfaces before trying to connect to them, see
https://bugzilla.gnome.org/show_bug.cgi?id=729922
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Simplify code by using a vector in place of dozen variables.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
Comment about not synchronizing with accessibilityController.
LayoutTests: [ATK] Convert caret offset tests from testatk.c.
https://bugs.webkit.org/show_bug.cgi?id=132527
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-05-30
Reviewed by Mario Sanchez Prada.
The tests are replicated from testatk.c file, functions
testWebkitAtkCaretOffsets()
testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces()
The file was present in webkit1. Removed from trunk in r166977, so
the last version was
https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c?rev=166976
What could not be verified in the same way:
- Whether element implements ATK_TEXT. If setCaretOffset
succeeds, it confirms that element is text as well. But in cases
when setCaretOffset must fail I see no way to confirm it is text
element.
- Whether position is correct through a call to
atk_text_get_caret_offset. text-caret-moved signal value is
tested instead.
Anyway these cases don't look crucial, so they are skipped.
- platform/gtk/resources/atk-helpers.js: Added.
(setCaretOffset): Added.
- platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces-expected.txt: Added.
- platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces.html: Added.
- platform/gtk/accessibility/caret-offsets-expected.txt: Added.
- platform/gtk/accessibility/caret-offsets.html: Added.
- 12:43 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:26 AM Changeset in webkit [170790] by
-
- 19 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r170423 - [GTK] Windowed plugins visibility doesn't work
https://bugs.webkit.org/show_bug.cgi?id=131487
Reviewed by Anders Carlsson.
Implement plugins visibility changes and add a new message to
notify the UI process when a windowed plugin is shown/hidden to
show/hide the plugin widget.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::visibilityDidChange): Add
implementation to notify the plugin about visibility change.
(WebKit::PluginControllerProxy::windowedPluginVisibilityDidChange):
Send WindowedPluginVisibilityDidChange to the plugin proxy.
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginControllerProxy.messages.in: Add VisibilityDidChange message.
- UIProcess/WebPageProxy.h: Add windowedPluginVisibilityDidChange
to handle WindowedPluginVisibilityDidChange message.
- UIProcess/WebPageProxy.messages.in: Add WindowedPluginVisibilityDidChange message.
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::windowedPluginVisibilityDidChange):
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::createPluginContainer): Do not show the
plugins by default.
(WebKit::WebPageProxy::windowedPluginVisibilityDidChange): Show or hide the plugin widget.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin): Initialize m_isVisible.
(WebKit::NetscapePlugin::visibilityDidChange): Add visible parameter and save it in m_isVisible
member, calling platformVisibilityDidChange() only when it has actually changed.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformVisibilityDidChange): Notify the controller about visibility change.
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::visibilityDidChange): Send VisibilityDidChange message to the plugin controller proxy.
(WebKit::PluginProxy::windowedPluginVisibilityDidChange): Notify the controller about visibility change.
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginProxy.messages.in: Add WindowedPluginVisibilityDidChange message.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin): Also call viewVisibilityDidChange() when the plugin is initialized.
(WebKit::PluginView::setParentVisible): Override this Widget method to update the plugin visibility when parent
widget is shown/hidden.
(WebKit::PluginView::viewVisibilityDidChange): Pass visible parameter to visibilityDidChange().
(WebKit::PluginView::windowedPluginVisibilityDidChange): Send WindowedPluginVisibilityDidChange message to the UI process.
- WebProcess/Plugins/PluginView.h:
- 12:26 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:16 AM Changeset in webkit [170789] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r170633 - [GTK] Annotations for WebResource.get_data produce wrong signature in Vala binding
https://bugs.webkit.org/show_bug.cgi?id=134476
Patch by Evan Nemerson <evan@nemerson.com> on 2014-07-01
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitWebResource.cpp: Add array length and
element-type annotations to return value of webkit_web_resource_get_data_finish().
- 12:14 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:13 AM Changeset in webkit [170788] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/ThirdParty/ANGLE
[GTK] [Stable] Crash in TSymbolTableLevel::~TSymbolTableLevel with GCC 4.9
https://bugs.webkit.org/show_bug.cgi?id=134593
Unreviewed. Backported from Mozilla by Mike Hommey <mh+mozilla@glandium.org>
https://bugzilla.mozilla.org/show_bug.cgi?id=1025576
https://code.google.com/p/angleproject/issues/detail?id=651
- src/compiler/SymbolTable.cpp:
(TSymbolTableLevel::~TSymbolTableLevel):
- 12:10 AM Changeset in webkit [170787] by
-
- 9 edits in trunk/Source/WebKit2
[iOS][WK2] Black web view after un-suspending process
https://bugs.webkit.org/show_bug.cgi?id=134623
<rdar://problem/17513223>
Reviewed by Simon Fraser.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
Add an argument to viewStateDidChange that allows callers (-[WKContentView _applicationWillEnterForeground:])
to force us to wait for a synchronous reply from the Web process after performing a view state change.
(WebKit::WebPageProxy::dispatchViewStateChange):
Move the has-been-in-window-and-now-is-newly-in-window check into dispatchViewStateChange.
Adjust the logic surrounding going into/out of window by factoring out the IsInWindow-did-change check, for clarity.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _applicationWillEnterForeground:]):
As previously mentioned, wait for a reply when foregrounding.
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlushImmediately):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
(WebKit::RemoteLayerTreeDrawingArea::viewStateDidChange):
Make sure to schedule a commit immediately if the UI process is waiting for a reply.
Previously we assumed that a commit would be scheduled anyway because we would have to reparent the
layer tree, but that doesn't happen in the suspension-without-unparenting case. Also, we want to skip
all throttling in this case.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlushImmediately):
Jul 3, 2014:
- 10:38 PM Changeset in webkit [170786] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
https://bugs.webkit.org/show_bug.cgi?id=134486
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-07-03
Reviewed by Gyuyoung Kim.
Use on_search_close_button_clicked() callback to close search bar and on_search_text_found() callback to show search count.
- MiniBrowser/efl/main.c:
(search_box_show):
(search_box_hide):
(on_search_close_button_clicked):
(on_search_text_found):
(window_create):
- 6:12 PM Changeset in webkit [170785] by
-
- 7 edits in trunk/Source/WebKit2
Should not take background task assertion for NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=134622
Reviewed by Tim Horton.
When the WebContent wants to complete a task in the background we take a process assertion on the child process, and also need to prevent the UI process from suspending.
However for the NetworkProcess we always just hold a process assertion, and don't want this to interfere with UIApp suspension.
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):
- ProcessAssertion -> ProcessAndUIAssertion
- UIProcess/ProcessAssertion.cpp:
(WebKit::ProcessAssertion::ProcessAssertion):
- assignment -> initializer list.
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):
(WebKit::ProcessAndUIAssertion::~ProcessAndUIAssertion):
(WebKit::ProcessAndUIAssertion::setState):
- added no-op implementation.
(WebKit::ProcessAssertion::~ProcessAssertion): Deleted.
- UIProcess/ProcessAssertion.h:
- removed ~ProcessAssertion, added ProcessAndUIAssertion class.
- UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::didConnnectToProcess):
- ProcessAssertion -> ProcessAndUIAssertion
- UIProcess/ProcessThrottler.h:
- ProcessAssertion -> ProcessAndUIAssertion
- UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAssertion::ProcessAssertion):
- assignment -> initializer list.
- moved code to manage WKProcessAssertionBackgroundTaskManager
(WebKit::ProcessAssertion::setState):
- moved code to manage WKProcessAssertionBackgroundTaskManager
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):
(WebKit::ProcessAndUIAssertion::~ProcessAndUIAssertion):
(WebKit::ProcessAndUIAssertion::setState):
- moved code to manage WKProcessAssertionBackgroundTaskManager from ProcessAssertion.
(WebKit::ProcessAssertion::~ProcessAssertion): Deleted.
- delete - moved code to manage WKProcessAssertionBackgroundTaskManager
- 6:09 PM Changeset in webkit [170784] by
-
- 5 edits in trunk/Source/WebKit2
Clean up Brady's mess on iOS.
- Platform/mac/StringUtilities.h:
- Platform/mac/StringUtilities.mm:
- 5:48 PM Changeset in webkit [170783] by
-
- 3 edits in trunk/Source/WebKit2
[iOS WK2] Compositing layers draw outside page bounds
https://bugs.webkit.org/show_bug.cgi?id=134619
<rdar://problem/16953222>
Reviewed by Benjamin Poulain.
With the new rubber-banding behavior, we no longer have the root content layer clipping all
the web layers, but this resulted in web layers which were moved outside the viewport by CSS
transforms not being clipped.
Fix by adding a clipping layer inside the scroll view, above _rootContentView. This layer
normally has the same bounds as the content, but when rubber-banding or pinching,
it takes the union of the content bounds and the rect used for fixed positioning.
To make scrolling work as expected in this scenario, when it has non-zero offset, it
has to compensate by setting its bounds origin.
The bounds of the clipping layer are updated on scrolling/zooming, and when the
layer commit tells us that the content size changed.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateScrollViewBackground]):
- UIProcess/ios/WKContentView.mm:
(-[WKContentView initWithFrame:context:configuration:webView:]):
(-[WKContentView updateFixedClippingView:]):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
(-[WKContentView _didCommitLayerTree:]):
- 5:39 PM Changeset in webkit [170782] by
-
- 15 edits1 copy1 add in trunk/Source
When showing the selection menu, include menu options for all selected phone numbers.
<rdar://problem/16983434>, <rdar://problem/16874568>, and https://bugs.webkit.org/show_bug.cgi?id=134613
Reviewed by Tim Horton.
Source/WebCore:
- English.lproj/Localizable.strings:
- dom/Range.cpp:
(WebCore::rangesOverlap): Fix reversed arguments that caused some types of overlaps to not be detected.
Source/WebKit2:
Move some telephone number menu logic from WebKitSystemInterface here.
Also provide utility to get just the one menu item relevant to a telephone number.
- Platform/mac/MenuUtilities.h:
- Platform/mac/MenuUtilities.mm: Added.
(WebKit::menuItemForTelephoneNumber):
(WebKit::menuItemsForTelephoneNumber):
- Platform/mac/StringUtilities.h:
- Platform/mac/StringUtilities.mm:
(WebKit::formattedPhoneNumberString): Return a localized formatted phone number.
Add a member to track the selected phone numbers:
- Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::selectedTelephoneNumbers):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu): Also add menu items for each phone number that is
in the selection.
Switch away from a WKSI method, and remove a lot of unneeded forward declarations and soft linking:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showTelephoneNumberMenu):
(WebKit::WebPageProxy::showSelectionServiceMenu):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::drawSelectionHighlight):
(WebKit::ServicesOverlayController::handleClick): Pass the phone numbers along.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::handleSelectionServiceClick): Pass the phone numbers along.
- 5:36 PM Changeset in webkit [170781] by
-
- 2 edits in trunk/Source/WebKit2
WKProcessAssertionBackgroundTaskManager should clear member if task expires
https://bugs.webkit.org/show_bug.cgi?id=134618
Reviewed by Anders Carlson.
Failure to do so results in a warning, and could result in us erroneously completing a background task too soon.
- UIProcess/ios/ProcessAssertionIOS.mm:
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
- remove local variable, _backgroundTask = UIBackgroundTaskInvalid;
- 5:15 PM Changeset in webkit [170780] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed iOS build fix for r170774.
Remove some unnecessary WTF::moves on iOS:
error: static_assert failed "T is not an lvalue reference; move() is unnecessary."
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::getQueuedTouchEventsForPage):
(WebKit::EventDispatcher::touchEvent):
- 5:08 PM Changeset in webkit [170779] by
-
- 3 edits1 add in trunk/Source/WebKit2
Try to fix the iOS build.
Add WebPageProxyCocoa.mm for code shared between iOS and OS X. Put the recent searches save/restore code there.
- UIProcess/Cocoa/WebPageProxyCocoa.mm: Added.
(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
- UIProcess/mac/WebPageProxyMac.mm:
- WebKit2.xcodeproj/project.pbxproj:
- 4:47 PM Changeset in webkit [170778] by
-
- 2 edits in trunk/Source/WTF
Unreivewed, fix build break on EFL and GTK since r170767.
- wtf/CMakeLists.txt: Exclude Decoder.h and Encoder.h because those files were removed.
- 4:46 PM Changeset in webkit [170777] by
-
- 5 edits in trunk/Source
Versioning.
- 4:31 PM Changeset in webkit [170776] by
-
- 14 edits in trunk/Source/WebKit2
<rdar://problem/16337741> The UI process needs to track the number of HTTP subresource loads in progress (or at least whether there are any)
https://bugs.webkit.org/show_bug.cgi?id=134615
Reviewed by Anders Carlsson.
Added a _networkRequestsInProgress boolean property to WKWebView.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm: Added no-op overrides of new
PageLoadStateObserver member functions.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _networkRequestsInProgress]): New getter that gets this state from the
PageLoadState.
- UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared new property.
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::willChangeNetworkRequestsInProgress):: Override this new
PageLoadState::Observer member function by sending the appropriate KVO change message to the
WKWebView.
(WebKit::NavigationState::didChangeNetworkRequestsInProgress): Ditto.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::commitChanges): Check for changes to networkRequestsInProgress
and call the observers if needed.
(WebKit::PageLoadState::reset): Reset networkRequestsInProgress in the uncommitted state.
(WebKit::PageLoadState::setNetworkRequestsInProgress): Set networkRequestsInProgress in the
uncommitted state.
- UIProcess/PageLoadState.h:
(WebKit::PageLoadState::networkRequestsInProgress): Added this getter.
(WebKit::PageLoadState::Data::Data): Initialize new networkRequestsInProgress member.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setNetworkRequestsInProgress): Added. Updates the PageLoadState.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Added SetNetworkRequestsInProgress message.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): Call
WebPage::addResourceRequest.
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoading): Call
WebPage::removeResourceRequest.
(WebKit::WebFrameLoaderClient::dispatchDidFailLoading): Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addResourceRequest): Added. If the new request is for an HTTP-family URL,
add its identifier to the set of network resourece request identifiers. If the set was
previously empty, send the WebPageProxy a message.
(WebKit::WebPage::removeResourceRequest): Added. Remove the identifier from the set. If it
becomes empty, send the WebPageProxy a message.
- WebProcess/WebPage/WebPage.h:
- 3:31 PM Changeset in webkit [170775] by
-
- 3 edits in trunk/Source/WebKit2
Remove two unused functions
https://bugs.webkit.org/show_bug.cgi?id=134614
Reviewed by Andreas Kling.
- UIProcess/LegacySessionStateCoding.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeLegacySessionHistoryEntryData): Deleted.
(WebKit::decodeLegacySessionHistoryEntryData): Deleted.
- 3:13 PM Changeset in webkit [170774] by
-
- 689 edits in trunk
Add WTF::move()
https://bugs.webkit.org/show_bug.cgi?id=134500
Source/JavaScriptCore:
Rubber-stamped by Anders Carlsson.
Substitute WTF::move() for std::move().
- bytecode/CodeBlock.h:
- bytecode/UnlinkedCodeBlock.cpp:
- bytecompiler/BytecodeGenerator.cpp:
- dfg/DFGGraph.cpp:
- dfg/DFGJITCompiler.cpp:
- dfg/DFGStackLayoutPhase.cpp:
- dfg/DFGWorklist.cpp:
- heap/DelayedReleaseScope.h:
- heap/HeapInlines.h:
[...]
Source/WebCore:
Rubber-stamped by Anders Carlsson.
Substitute WTF::move() for std::move().
- Modules/battery/NavigatorBattery.cpp:
- Modules/encryptedmedia/MediaKeys.cpp:
- Modules/gamepad/NavigatorGamepad.cpp:
- Modules/gamepad/deprecated/NavigatorGamepad.cpp:
- Modules/geolocation/NavigatorGeolocation.cpp:
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
- Modules/indexeddb/IDBDatabaseBackend.cpp:
- Modules/indexeddb/IDBDatabaseBackend.h:
[...]
Source/WebKit/ios:
Rubber-stamped by Anders Carlsson.
Substitute WTF::move() for std::move().
- WebCoreSupport/WebFixedPositionContent.mm:
(-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
- WebCoreSupport/WebInspectorClientIOS.mm:
(WebInspectorFrontendClient::WebInspectorFrontendClient):
Source/WebKit/mac:
Rubber-stamped by Anders Carlsson.
Substitute WTF::move() for std::move().
- History/WebHistoryItem.mm:
(-[WebHistoryItem initFromDictionaryRepresentation:]):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
(WebKit::NetscapePluginInstanceProxy::setCurrentReply):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchWillSubmitForm):
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
- WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
Source/WebKit/win:
Rubber-stamped by Anders Carlsson.
Substitute WTF::move() for std::move().
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
- WebHistory.cpp:
(createUserInfoFromArray):
- WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
- WebView.cpp:
(WebView::addToDirtyRegion):
(WebView::scrollBackingStore):
Source/WebKit2:
Rubber-stamped by Anders Carlsson.
Substitute WTF::move() for std::move().
- DatabaseProcess/DatabaseProcess.cpp:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- Platform/IPC/ArgumentCoders.h:
- Platform/IPC/ArgumentDecoder.cpp:
- Platform/IPC/Connection.cpp:
- Platform/IPC/Connection.h:
[...]
Source/WTF:
Reviewed by Darin Adler.
Substitution of WTF::move() for std::move() rubber-stamped by Anders Carlsson.
Implement WTF::move(), a replacement for std::move(). WTF::move() is less error
prone than std::move() as it compile asserts that its argument is a non-const
lvalue reference before ultimately casting it to a rvalue reference (via std::move).
- wtf/Deque.h: Substitute WTF::move() for std::move().
- wtf/HashMap.h: Ditto.
- wtf/HashSet.h: Ditto.
- wtf/HashTable.h: Ditto.
- wtf/IteratorAdaptors.h: Ditto.
- wtf/IteratorRange.h: Ditto.
- wtf/ListHashSet.h: Ditto.
- wtf/MainThread.cpp: Ditto.
[...]
- wtf/StdLibExtras.h:
(WTF::move): Added.
[...]
Tools:
Rubber-stamped by Anders Carlsson.
Substitute WTF::move() for std::move().
- DumpRenderTree/win/DRTDataObject.cpp:
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
- TestWebKitAPI/Tests/WTF/HashSet.cpp:
- TestWebKitAPI/Tests/WTF/RefPtr.cpp:
- TestWebKitAPI/Tests/WTF/Vector.cpp:
- TestWebKitAPI/Tests/WTF/WTFString.cpp:
- TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added FIXME comments that explain that some of the sub-tests
aren't actually testing move semantics in tests: MoveAssignmentFromSameType, MoveAssignmentFromSimilarType,
ConstructionFromSameType, and ConstructionFromSimilarType.
- TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
- 3:11 PM Changeset in webkit [170773] by
-
- 6 edits in trunk/Source
[iOS][WK2] Fix small bugs of dynamicViewportSizeUpdate that were causing inaccuracies in the computed target
https://bugs.webkit.org/show_bug.cgi?id=134582
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-03
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.exp.in:
- platform/ScrollView.h:
(WebCore::ScrollView::unobscuredContentSize):
- platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::unobscuredContentRect):
(WebCore::ScrollView::setUnobscuredContentSize):
Source/WebKit2:
This patch fixes two small bugs that were causing "jumpiness" on animated resize:
1) The new scale was less accurate than the target scale, making the WebProcess force a worse scale on the content.
2) The code putting back the rects in view was ignoring the obscured insets, constraining the scroll position more
than it should be.
The first problem was cause by a series of rounding issues accumulating to the fact that "scale != targetScale"
was almost never true.
The first issue is that the unobscured content size was stored in integer coordinates. Because of that, it was
impossible to determine accurately how much content is in the view.
The outcome was that visibleHorizontalFraction was very inaccurate compared to what the UIProcess computed.
Another issue affecting the scale is that scaleAfterViewportWidthChange was computing the widthToKeepInView
on floating point. Since ARM64 does all those computations on doubles in the UIProcess, the value would be quite
different from the received targetScale.
Finally, the code uses withinEpsilon() instead of a strict equality to reduce the effect of rounding errors.
For the second issue, the problem was that I was bounding the exposed rect to the page bounds. It is completely
valid to have an exposed rect outside the page bounds, that area is just under the obscured insets.
On the other hand, the unobscured rect needs to be within the bounds as we do not want to rotate to a rubberbanding
position. The fix is simply to put the right rect into bounds, and the horizontal/vertical adjustement applies on
both rects.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::scaleAfterViewportWidthChange):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::updateVisibleContentRects):
- 2:52 PM Changeset in webkit [170772] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- UIProcess/mac/WebPageProxyMac.mm:
- 2:34 PM Changeset in webkit [170771] by
-
- 4 edits in tags/Safari-538.44.1/Source/WebCore
Merged r170762.
- 2:29 PM Changeset in webkit [170770] by
-
- 4 edits in tags/Safari-538.44.1/Source/WebCore
- 2:04 PM Changeset in webkit [170769] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
SSA DCE should process blocks in forward order
https://bugs.webkit.org/show_bug.cgi?id=134611
Reviewed by Andreas Kling.
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
- tests/stress/dead-value-with-mov-hint-in-another-block.js: Added.
(foo):
- 2:04 PM Changeset in webkit [170768] by
-
- 3 edits1 delete in trunk/Source/WebKit2
Get rid of WebPageProxyCF.cpp
https://bugs.webkit.org/show_bug.cgi?id=134609
Reviewed by Dan Bernstein.
- UIProcess/cf/WebPageProxyCF.cpp: Removed.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
- WebKit2.xcodeproj/project.pbxproj:
- 1:46 PM Changeset in webkit [170767] by
-
- 6 edits2 deletes in trunk/Source
Get rid of Encoder.h and Decoder.h from WTF
https://bugs.webkit.org/show_bug.cgi?id=134600
Reviewed by Darin Adler.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/Decoder.h: Removed.
- wtf/Encoder.h: Removed.
- 1:22 PM Changeset in webkit [170766] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
JSActivation::symbolTablePut() should invalidate variable watchpoints
https://bugs.webkit.org/show_bug.cgi?id=134602
Reviewed by Oliver Hunt.
Usually stores to captured variables cause us to invalidate the variable watchpoint because CodeBlock does so
during linking - we essentially assume that if it's at all possible for an inner function to store to a
variable we declare then this variable cannot be a constant. But this misses the dynamic store case, i.e.
JSActivation::symbolTablePut(). Part of the problem here is that JSActivation duplicates
JSSymbolTableObject's symbolTablePut() logic, which did have the invalidation. This patch keeps that code
duplicated, but fixes JSActivation::symbolTablePut() to do the right thing.
- runtime/JSActivation.cpp:
(JSC::JSActivation::symbolTablePut):
- runtime/JSSymbolTableObject.h:
(JSC::symbolTablePut):
- tests/stress/constant-closure-var-with-dynamic-invalidation.js: Added.
(.):
- 1:10 PM Changeset in webkit [170765] by
-
- 5 edits2 adds in trunk
[Mac] WebKit1 WebView iframe not responding to scroll gestures
https://bugs.webkit.org/show_bug.cgi?id=134569
<rdar://problem/17309008>
Reviewed by Simon Fraser.
Source/WebCore:
New test: platform/mac/fast/scrolling/scroll-iframe-fragment.html
WK1 scrollable areas are implemented on top of PlatformWidget (i.e., NSView) objects. They only
perform a scroll operation if the EventHandler::handleWheelEvent method returns 'false', indicating
that the Cocoa layer should do scrolling work. This is in contrast to WK2, where the scrolling is
handled separately and we return 'true' from EventHandler::handleWheelEvent to indicate that the
scroll event has been handled and that no other work is needed. This mismatch in the meaning of
EventHandler::handleWheelEvent means that WK1 views do not properly handle scroll wheel events.
To correct this, we need to see if we are acting on an Element backed by a PlatformWidget. When we
are (the WK1 case) we want to return 'false' to instruct the Cocoa object to do the scroll operation.
To implement proper latching behavior in WK1, we must return 'true' in the case where we are latched
to a PlatformWidget, and that PlatformWidget did not start the scroll gesture at the edge of
the region in the dominant scroll direction.
Finally, additional logic was needed to determine whether the PlatformWidget is scrolled to the
edge in the dominant scroll direction.
- page/EventHandler.cpp:
(WebCore::EventHandler::platformCompleteWheelEvent): Added stub.
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Added stub.
(WebCore::EventHandler::handleWheelEvent): Call new platformCompletePlatformWidgetWheelEvent if the
event was handled for a PlatformWidget.
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
(WebCore::widgetForEventTarget): Added helper function.
(WebCore::scrollViewForEventTarget): Added helper function.
(WebCore::eventTargetIsPlatformWidget): Added helper function.
(WebCore::EventHandler::platformPrepareForWheelEvents): Check whether we are at a scrolled edge
for the NSView (PlatformWidget) case.
(WebCore::EventHandler::platformCompleteWheelEvent): Return 'false' when handling WK1-style scrolls.
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Added. We generally want to
return false so the PlatformWidget handles scrolling, except in the case where we are latched to
a PlatformWidget, which has already performed its scroll, and we want to avoid propegating a
scroll event to an enclosing region.
LayoutTests:
- platform/mac/fast/scrolling/scroll-iframe-fragment-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-iframe-fragment.html: Added.
- 1:06 PM Changeset in webkit [170764] by
-
- 4 edits in trunk
Broken build with build-webkit --no-video
https://bugs.webkit.org/show_bug.cgi?id=134587
Reviewed by Darin Adler.
MEDIA_CONTROLS_SCRIPT requires VIDEO enabled.
.:
- Source/cmake/WebKitFeatures.cmake: Added the dependency for ENABLE_MEDIA_CONTROLS_SCRIPT.
Source/WTF:
- wtf/FeatureDefines.h: Added error message for dependency failure.
- 1:01 PM Changeset in webkit [170763] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Revise the flat find indicator secondary highlight shadows
https://bugs.webkit.org/show_bug.cgi?id=134607
<rdar://problem/17554828>
Reviewed by Brady Eidson.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::drawRect):
Bring back the secondary highlight shadow, with new constants.
- 12:48 PM Changeset in webkit [170762] by
-
- 4 edits in trunk/Source/WebCore
Preserve old behavior of creating an NSURLRequest of the exact same type as passed to us
https://bugs.webkit.org/show_bug.cgi?id=134605
<rdar://problem/17544641>
Reviewed by Andreas Kling.
We have client code that passes us a subclass of NSURLRequest to load resource. Later when
we call willSendRequest, they test to make sure they get an object of the same type. My
optimization in r170642 broke this path when I cleared out the NSURLRequest object. We
already had code in updateNSURLRequest() that was taking this quirk into account but I broke
that. Fix it by reverting to old behavior for such clients.
No new tests though we need one. I will add it later.
- platform/network/cf/ResourceRequest.h:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):
- platform/network/ios/ResourceRequestIOS.mm:
(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::clearOrUpdateNSURLRequest):
- 12:30 PM Changeset in webkit [170761] by
-
- 12 edits in trunk/Source/WebKit2
[iOS][WK2] Sometimes the swipe snapshot stays up too long
https://bugs.webkit.org/show_bug.cgi?id=134506
<rdar://problem/17496803>
Reviewed by Simon Fraser.
Implement a transaction callback mechanism.
The UI process can register a callback at any point, generally immediately after sending a message to the Web process.
It will then send another message (in-order) with the callback ID to the Web process, which will put it into the next transaction
(scheduling a new one if needed). When the transaction comes back to the UI process, the callbacks are performed.
This ensures that the callback fires alongside a commit that includes the results of whatever messages were sent before it was registered.
For now, all callbacks are fired just before committing layer changes, but it's possible future patches will want post-commit callbacks.
Make use of this to remove the ViewGestureControllerIOS snapshots at the right time.
- Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::callbackIDs):
(WebKit::RemoteLayerTreeTransaction::setCallbackIDs):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
Add a vector of callback IDs to the transaction; encode and decode as appropriate.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::dispatchAfterEnsuringDrawing):
(WebKit::DrawingAreaProxy::lastVisibleTransactionID): Deleted.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::~RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::dispatchAfterEnsuringDrawing):
Add dispatchAfterEnsuringDrawing, which takes a function.
When a callback is added, we send the callback ID to the Web process via the AddTransactionCallbackID message.
Perform callbacks listed in the incoming transaction's vector of callback IDs.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::addTransactionCallbackID):
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::addTransactionCallbackID):
Keep track of the pending callback IDs on the drawing area, and move them into the transaction.
We schedule a flush when installing a transaction callback on the premise that
sometimes the action (goToBackForwardListItem in the swipe case) might have already occurred
and been committed by the time the Web process receives AddTransactionCallbackID, so we need
to cause another commit to send the callbacks across. If said commit is still pending, this is a no-op.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(allViewGestureControllers):
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::willCommitPostSwipeTransitionLayerTree):
(WebKit::ViewGestureController::setRenderTreeSize):
- UIProcess/mac/ViewGestureController.h:
Keep a side-map of page IDs to ViewGestureControllers, so that we can safely get back to
our ViewGestureController from the callback.
When the callback fires, if it succeeded, set m_shouldRemoveSnapshotWhenTargetRenderTreeSizeHit,
so that the commit (which is about to occur immediately after the callback returns) which calls
setRenderTreeSize will (perhaps) remove the snapshot.
If it failed, we remove the snapshot immediately, as this usually happens if the Web process crashed.
- 12:16 PM Changeset in webkit [170760] by
-
- 2 edits in trunk/Source/WebKit2
Followup to "rects sent to ServicesOverlayController are wrong"
https://bugs.webkit.org/show_bug.cgi?id=134568
Rubberstamped by Tim Horton.
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::drawSelectionHighlight): Don’t check to see if the
proposed rect intersects the dirty rect. We always need to include all rects that form
the selection when creating the DDHighlight.
- 12:04 PM Changeset in webkit [170759] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] RemoteLayerTreeDrawingAreaProxy re-checks a preference every commit for no reason
https://bugs.webkit.org/show_bug.cgi?id=134586
Reviewed by Benjamin Poulain.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setShouldShowDebugIndicator):
(WebKit::DrawingAreaProxy::showDebugIndicator): Deleted.
(WebKit::DrawingAreaProxy::isShowingDebugIndicator): Remove this, nobody is using it.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::preferencesDidChange):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::setShouldShowDebugIndicator):
(WebKit::RemoteLayerTreeDrawingAreaProxy::showDebugIndicator): Deleted.
Check the debug indicator pref at construction time, and update the state when it changes.
Checking it every commit was surprisingly expensive.
- 10:56 AM Changeset in webkit [170758] by
-
- 16 edits in trunk/Source
Selection rects sent to ServicesOverlayController are wrong.
<rdar://problem/16727796> and https://bugs.webkit.org/show_bug.cgi?id=134568
Reviewed by Darin Adler (and Tim Horton and Ryosuke Niwa).
Source/WebCore:
- WebCore.exp.in:
Update the gatherer to keep GapRects separate from LayoutRects:
- editing/SelectionRectGatherer.cpp:
(WebCore::SelectionRectGatherer::addRects):
(WebCore::SelectionRectGatherer::Notifier::~Notifier):
(WebCore::SelectionRectGatherer::clearAndCreateNotifier):
- editing/SelectionRectGatherer.h:
- page/EditorClient.h:
(WebCore::EditorClient::selectionRectsDidChange): Updated to take LayoutRects and GapRects separately.
Change RenderSelectionInfo to also hang on to the individual rects that formed the final bounding rect:
- rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::RenderSelectionInfo): If the RenderObject is a RenderText, then call
collectSelectionRectsForLineBoxes instead of selectionRectForRepaint.
(WebCore::RenderSelectionInfo::rects):
- rendering/RenderText.cpp:
(WebCore::RenderText::collectSelectionRectsForLineBoxes): Added
(WebCore::RenderText::selectionRectForRepaint):
- rendering/RenderText.h:
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::collectSelectionRectsForRange): Added
- rendering/RenderTextLineBoxes.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::setSubtreeSelection): Add the list of rects to the gatherer instead of just
the bounding rect.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::selectionRectsDidChange): Also pass the GapRects to the ServicesOverlayController.
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebPage/ServicesOverlayController.h:
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::expandForGap):
(WebKit::compactRectsWithGapRects): Combine 3+ rects down to exactly 3 rects, then expand them based on GapRects.
(WebKit::ServicesOverlayController::selectionRectsDidChange): Call compactRectsWithGapRects, then reverse the list.
(WebKit::ServicesOverlayController::drawSelectionHighlight): Tell data detectors to flip this.
(WebKit::ServicesOverlayController::drawTelephoneNumberHighlight): Tell data detectors to flip this.
(WebKit::ServicesOverlayController::drawCurrentHighlight): No need to flip this anymore.
- 10:13 AM Changeset in webkit [170757] by
-
- 2 edits in trunk/Source/WebKit2
Ensure frame creation messages get through to UI process
https://bugs.webkit.org/show_bug.cgi?id=134591
<rdar://problem/16918218>
Reviewed by Anders Carlsson.
If we are middle of handling a synchronous message from UI process a frame creation message back gets delayed.
The subsequent synchronous DecidePolicyForNavigationAction message expects that the frame creation
message has arrived first and fails.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
Send messages with DispatchMessageEvenWhenWaitingForSyncReply so they always go through in order.
- 10:09 AM Changeset in webkit [170756] by
-
- 4 edits4 deletes in trunk/Source/WebKit2
Get rid of DecoderAdapter and EncoderAdapter
https://bugs.webkit.org/show_bug.cgi?id=134598
Reviewed by Andreas Kling.
- CMakeLists.txt:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/DecoderAdapter.cpp: Removed.
- WebProcess/WebPage/DecoderAdapter.h: Removed.
- WebProcess/WebPage/EncoderAdapter.cpp: Removed.
- WebProcess/WebPage/EncoderAdapter.h: Removed.
- WebProcess/WebPage/WebPage.cpp:
- 10:05 AM Changeset in webkit [170755] by
-
- 6 edits in trunk/Source
Stop using EncoderAdapter/DecoderAdapter for FormData
https://bugs.webkit.org/show_bug.cgi?id=134571
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
- platform/network/FormData.cpp:
(WebCore::encodeElement): Deleted.
(WebCore::decodeElement): Deleted.
(WebCore::FormData::encode): Deleted.
(WebCore::FormData::decode): Deleted.
- platform/network/FormData.h:
(WebCore::FormDataElement::encode):
(WebCore::FormDataElement::decode):
(WebCore::FormData::encode):
(WebCore::FormData::decode):
Source/WebKit2:
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
- 9:19 AM Changeset in webkit [170754] by
-
- 8 edits in trunk/Source
Possible crash in IconDatabase in WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread
<rdar://problem/17437687> and https://bugs.webkit.org/show_bug.cgi?id=134517
Reviewed by Eric Carlson.
Source/WebCore:
Since WebCore::IconDatabase is not RefCounted there’s no obvious way to keep it alive until it is
truly no longer needed.
This isn’t generally a problem because they are usually a singleton that lasts the lifetime of the process.
In the WebKit2 case, WebCore::IconDatabases can come and go as their owning WebIconDatabases come and go.
So we can rely on WebIconDatabase to handle the lifetime appropriately.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::close): If the database is actually closed, notify the client.
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::isOpen): Take into account whether there’s any main thread callbacks, plus what
is covered by isOpenBesidesMainThreadCallbacks.
(WebCore::IconDatabase::isOpenBesidesMainThreadCallbacks): Take into account whether the sync thread
is still running and whether or not the database file is still open.
(WebCore::IconDatabase::checkClosedAfterMainThreadCallback): Checks to see if the database has just
become 100% closed and - if so - notify the client.
(WebCore::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread): Updated to increment the main thread
callback count and to call checkClosedAfterMainThreadCallback when done.
(WebCore::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread): Ditto.
(WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread): Ditto.
(WebCore::IconDatabase::dispatchDidFinishURLImportOnMainThread): Ditto.
- loader/icon/IconDatabase.h:
- loader/icon/IconDatabaseClient.h:
(WebCore::IconDatabaseClient::didClose): Added. For the IconDatabase to tell its client it is 100% closed.
Source/WebKit2:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext): Instead of directly deref’ing the WebIconDatabase, ask it to
deref itself when appropriate.
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::WebIconDatabase):
(WebKit::WebIconDatabase::didClose): If this WebIconDatabase is supposed to deref itself when
appropriate, do so now.
(WebKit::WebIconDatabase::derefWhenAppropriate): If the WebCore::IconDatabase is still open then
defer this deref.
- UIProcess/WebIconDatabase.h:
- 8:46 AM Changeset in webkit [170753] by
-
- 2 edits in trunk/Source/WebCore
AX: VoiceOver does not read aria-expanded attribute on controls in Safari
https://bugs.webkit.org/show_bug.cgi?id=134527
Reviewed by Mario Sanchez Prada.
Expose whether the ARIA expanded property is present or not.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilitySupportsARIAExpanded]):
- 7:55 AM Changeset in webkit [170752] by
-
- 2 edits in trunk/Tools
[JavaScriptCore] Add --cmakeargs option to build-jsc.
https://bugs.webkit.org/show_bug.cgi?id=134590
Reviewed by Ryosuke Niwa.
- Scripts/build-jsc:
- 7:17 AM WebKitGTK/2.4.x edited by
- (diff)
- 6:36 AM Changeset in webkit [170751] by
-
- 2 edits in trunk
[GTK] The list of features shown by cmake is not accurate
https://bugs.webkit.org/show_bug.cgi?id=134588
Reviewed by Gustavo Noronha Silva.
The problem is that some options might change after the feature
list has been printed.
- Source/cmake/OptionsGTK.cmake: Find package dependencies before
setting the default values of features and set WEBGL value
depending on the dependencies, and API_TEST depending on whether
developer mode is enabled or not.
- 5:49 AM Changeset in webkit [170750] by
-
- 2 edits in trunk/Tools
Add option to specify jsc args in run-sunspider.
https://bugs.webkit.org/show_bug.cgi?id=134341
Patch by Gergo Balogh <gbalogh.u-szeged@partner.samsung.com> on 2014-07-03
Reviewed by Csaba Osztrogonác.
- Scripts/run-sunspider:
- 1:04 AM Changeset in webkit [170749] by
-
- 4 edits in trunk
[CMAKE] Add WEBKIT_OPTION_DEPEND macro to resolve macro dependency
https://bugs.webkit.org/show_bug.cgi?id=134578
Reviewed by Gyuyoung Kim.
Some options depend on another option such as ENABLE_VIDEO_TRACK and ENABLE_VIDEO.
This patch adds WEBKIT_OPTION_DEPEND to check the depending option and
disable related option if it is not ON.
- Source/cmake/OptionsEfl.cmake: Removed hack for option dependency.
- Source/cmake/OptionsGTK.cmake: Ditto.
- Source/cmake/WebKitFeatures.cmake: Added WEBKIT_OPTION_DEPEND macro.
- 12:56 AM Changeset in webkit [170748] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r170676): [GTK] UI process crashes when the Web Process crashes
https://bugs.webkit.org/show_bug.cgi?id=134541
Reviewed by Gyuyoung Kim.
It happens when attaching a new web process, because it tries to
encode a null SessionState.
- UIProcess/LegacySessionStateCodingNone.cpp:
(WebKit::encodeLegacySessionState): Return an empty API::Data
object instead of nullptr.
(WebKit::encodeLegacySessionHistoryEntryData): Ditto.
- 12:53 AM Changeset in webkit [170747] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION(r170743): [GTK] [EFL] Build broken.
https://bugs.webkit.org/show_bug.cgi?id=134585
Reviewed by Philippe Normand.
Add ENABLE(PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC) guards where needed.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Jul 2, 2014:
- 9:25 PM Changeset in webkit [170746] by
-
- 4 edits in trunk/Source/WebCore
Removing an element with CSS -webkit-overflow-scrolling: touch breaks
subsequent touch events
<https://bugs.webkit.org/show_bug.cgi?id=134584>
<rdar://problem/17202021>
This issue is caused by the order of teardown for RenderLayers.
RenderLayer clears its m_backing in its destructor, calling the
RenderLayerBacking destructor. The RenderLayerBacking destructor calls
RenderLayerCompositor::willRemoveScrollingLayer(), which tries to
access the RenderLayer's backing that has already been cleared. This
causes us to skip the call to ChromeClient::removeScrollingLayer(),
resulting in a stale view that can block touch events.
Reviewed by Simon Fraser.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateScrollingLayers):
When calling willRemoveScrollingLayerWithBacking(), pass both the layer
and the RenderLayerBacking.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
Renamed. Use the passed RenderLayerBacking, as the RenderLayer's
backing might have already been cleared.
(WebCore::RenderLayerCompositor::willRemoveScrollingLayer): Deleted.
- rendering/RenderLayerCompositor.h:
Renamed willRemoveScrollingLayer() to
willRemoveScrollingLayerWithBacking() and added a parameter.
- 9:03 PM Changeset in webkit [170745] by
-
- 5 edits1 add in trunk
Tools: [GTK] Unreviewed gardening.
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-07-02
- Scripts/run-gtk-tests:
(TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage
LayoutTests: Unreviewed gardening.
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-07-02
- platform/gtk/TestExpectations: Report and mark several flaky tests.
- platform/gtk/fast/text/indic-expected.txt: Added. Add baseline for GTK.
- platform/mac-wk2/TestExpectations: Report and mark flaky test http/tests/cache/iframe-304-crash.html.
- 8:52 PM Changeset in webkit [170744] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Make is safe/fast to use the animated resize API without resizing anything
https://bugs.webkit.org/show_bug.cgi?id=134570
Reviewed by Enrica Casucci.
Today, if someone calls _beginAnimatedResizeWithUpdates-_endAnimatedResize, it is always a very heavy process
forcing a relayout and can cause synchronous operations.
We should not force the caller of the API to maintain their own state tracking, we should do that for them.
With this patch, we track everything we need for a resize and only do the heavy lifting if anything has actually changed.
- UIProcess/API/Cocoa/WKWebView.mm:
(activeMinimumLayoutSize):
(activeMinimumLayoutSizeForMinimalUI):
(activeMaximumUnobscuredSize):
(activeOrientation):
This code is used in both _didRelaunchProcess and _beginAnimatedResizeWithUpdates. It is moved to static functions
to avoid having it in two places.
(-[WKWebView _didRelaunchProcess]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
The updates now goes like this:
1) Set _isAnimatingResize to prevent the undesired side effects updateBlock() if we really need to resize.
2) Get all the original values before calling the update block.
3) Call the update block.
4a) If nothing useful for resize has changed, reset _isAnimatingResize to false.
We also need to update the visible content rect because the update block may have changed something unrelated
to the view size (scale, scroll position, etc).
4b) If we really need to resize, proceed as usual.
(-[WKWebView _endAnimatedResize]):
With the changes in _beginAnimatedResizeWithUpdates:, _isAnimatingResize is only set for real cases of animated resize,
bail out early if that flag isn't set.
The remaining code is unchanged, it is just not indented due to the removal of the if() branch.
- 8:31 PM Changeset in webkit [170743] by
-
- 3 edits in trunk/Source/WebKit2
Improve handling of primary offscreen plugins.
https://bugs.webkit.org/show_bug.cgi?id=134528.
<rdar://problem/17471864>
Reviewed by Dean Jackson.
- WebProcess/Plugins/PluginView.cpp:
Determine whether or not the plugin starts offscreen when the plugin is initialized.
(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Use the PluginProcessTypeNormal for offscreen plugins that are potentially primary plugins.
- 8:03 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 7:47 PM Changeset in webkit [170742] by
-
- 4 edits in tags/Safari-538.44.1/Source/WebCore
Roll out r170578.
- 7:31 PM Changeset in webkit [170741] by
-
- 6 edits in trunk/Tools
Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
https://bugs.webkit.org/show_bug.cgi?id=134581
Reviewed by Tim Horton.
Should be removed unused EFL bot info.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
(EWS):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- TestResultServer/static-dashboards/builders.jsonp:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
- 7:14 PM Changeset in webkit [170740] by
-
- 5 edits in tags/Safari-538.44.1/Source
Versioning.
- 7:03 PM Changeset in webkit [170739] by
-
- 1 copy in tags/Safari-538.44.1
New tag.
- 5:59 PM Changeset in webkit [170738] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION(WK2): Undo does not work in text fields in Safari.
https://bugs.webkit.org/show_bug.cgi?id=134572
<rdar://problem/17542238>
Reviewed by Benjamin Poulain.
This patch adds for iOS the same implementation we have already for OS X.
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(-[WKEditCommandObjC initWithWebEditCommandProxy:]):
(-[WKEditCommandObjC command]):
(-[WKEditorUndoTargetObjC undoEditing:]):
(-[WKEditorUndoTargetObjC redoEditing:]):
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
- 5:55 PM Changeset in webkit [170737] by
-
- 4 edits in trunk/Source/WebKit2
ProcessAssertion should also prevent UIApp suspension
https://bugs.webkit.org/show_bug.cgi?id=134563
Reviewed by Dan Bernstein.
If the application suspends then the child processes will, too.
Use beginBackgroundTaskWithName:expirationHandler: to request that the application remain runnable
while waiting for background tasks to complete.
- UIProcess/ProcessAssertion.cpp:
(WebKit::ProcessAssertion::~ProcessAssertion):
- Added destructor.
- UIProcess/ProcessAssertion.h:
- Added destructor.
- UIProcess/ios/ProcessAssertionIOS.mm:
(+[WKProcessAssertionBackgroundTaskManager shared]):
- singleton WKProcessAssertionBackgroundTaskManager.
(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager dealloc]):
- register/remove notification handlers.
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
- if we need to be runnable make sure we're holding a BackgroundTask, if not release it.
(-[WKProcessAssertionBackgroundTaskManager _applicationDidEnterBackgroundOrWillEnterForeground:]):
- detect when the app enters/leaves foreground; calls to _updateBackgroundTask.
(-[WKProcessAssertionBackgroundTaskManager incrementNeedsToRunInBackgroundCount]):
(-[WKProcessAssertionBackgroundTaskManager decrementNeedsToRunInBackgroundCount]):
- interface to update the count; calls to _updateBackgroundTask.
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::~ProcessAssertion):
- count ProcessAssertions in and out of existance.
(WebKit::ProcessAssertion::setState):
- count when the state changes.
- 4:41 PM Changeset in webkit [170736] by
-
- 12 edits2 adds in branches/ftlopt/Source/JavaScriptCore
Added In for cells to the FTL
- 4:02 PM Changeset in webkit [170735] by
-
- 5 edits in trunk/Source/WebCore
Ensure that the WebKit bundle version in the user agent string continues to match the current format.
<https://webkit.org/b/134524> / <rdar://problem/17447771>
Reviewed by Simon Fraser.
- page/cocoa/UserAgent.h:
- page/cocoa/UserAgent.mm:
(WebCore::userVisibleWebKitBundleVersionFromFullVersion): Updated to take an NSString now that it's internal
to the file.
(WebCore::userAgentBundleVersionFromFullVersionString): Limit the bundle version included in the user agent
string to three components.
- page/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName): Update to call userAgentBundleVersionFromFullVersionString.
- page/mac/UserAgentMac.mm:
(WebCore::standardUserAgentWithApplicationName): Ditto.
- 4:02 PM Changeset in webkit [170734] by
-
- 10 edits in trunk/Source
<https://webkit.org/b/134522> Remove duplication in code that prepares the user agent string on Mac and iOS
Reviewed by Simon Fraser.
Source/WebCore:
- page/cocoa/UserAgent.h:
- page/cocoa/UserAgent.mm:
(WebCore::userVisibleWebKitBundleVersionFromFullVersion): Moved from WebKit2.
- page/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName): Pass the WebKit bundle version through userVisibleWebKitBundleVersionFromFullVersion
before including it in the user agent string.
- page/mac/UserAgentMac.mm:
(WebCore::standardUserAgentWithApplicationName): Ditto.
Source/WebKit/mac:
- WebView/WebView.mm:
(webKitBundleVersionString): Return the entire CFBundleVersion now that WebCore handles formatting it.
(+[WebView _standardUserAgentWithApplicationName:]):
Source/WebKit2:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::webKitBundleVersionString): Return the entire CFBundleVersion now that WebCore handles formatting it.
(WebKit::WebPageProxy::standardUserAgent):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::webKitBundleVersionString): Ditto.
(WebKit::WebPageProxy::standardUserAgent):
- 3:54 PM Changeset in webkit [170733] by
-
- 10 edits in trunk/Source/WebKit2
Restrict network process sandbox
https://bugs.webkit.org/show_bug.cgi?id=134360
Reviewed by Sam Weinig.
Add more restrictions to the network process sandbox.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
Always use the cache directory provided in the initialization parameters,
and make sure we consume the cookie directory extension.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
Make the sandbox profile much more restrictive.
- Shared/Network/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode): (WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
The network process now requires an extension to access
its cookie storage.
- Shared/mac/SandboxUtilities.cpp: (WebKit::pathForProcessContainer):
- Shared/mac/SandboxUtilities.h:
We need to be able to get hold of our container so
that we can get the correct cookie storage directory.
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess):
We have to pass in the an extension for the cookie storage directory when
initalising the network process
- UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformDefaultCookieStorageDirectory):
Make sure we provide the correct location on IOS
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
Consume the cookie storage extension
- 3:52 PM Changeset in webkit [170732] by
-
- 2 edits in trunk/Source/WebKit2
URTBF after r170725.
- CMakeLists.txt: Removed Shared/LegacySessionState.cpp.
- 3:52 PM Changeset in webkit [170731] by
-
- 2 edits in trunk/Source/WebKit2
URTBF after r170719 for !CF platforms.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sessionStateData): Deleted.
(WebKit::WebPageProxy::restoreFromSessionStateData): Deleted.
- 3:38 PM Changeset in webkit [170730] by
-
- 7 edits1 copy3 moves1 add in trunk/Source
<https://webkit.org/b/134521> iOS should use shared code to determine the system marketing version
Reviewed by Simon Fraser.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Add the new files, and sort the groups they're in.
- page/cocoa/UserAgent.h: Copied from Source/WebCore/page/mac/UserAgent.h.
- page/cocoa/UserAgent.mm: Renamed from Source/WebCore/page/mac/UserAgent.h.
Move systemMarketingVersionForUserAgentString to a location where it can be shared between
Mac and iOS.
- page/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName): Switch to systemMarketingVersionForUserAgentString.
- page/mac/UserAgentMac.mm:
- platform/cocoa/SystemVersion.h: Renamed from Source/WebCore/platform/mac/SystemVersionMac.h.
- platform/cocoa/SystemVersion.mm: Renamed from Source/WebCore/platform/mac/SystemVersionMac.mm.
Move to a location that makes it clear this is shared between Mac and iOS. Enable the modern Mac
codepath for iOS as well.
Source/WebKit2:
- Shared/ios/ChildProcessIOS.mm: Update #import.
- Shared/mac/ChildProcessMac.mm: Ditto.
- 3:34 PM Changeset in webkit [170729] by
-
- 4 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Allocate a new GetterSetter if we change the value of any of its entries other than when they were previously null, so that if we constant-infer an accessor slot then we immediately get the function constant for free
https://bugs.webkit.org/show_bug.cgi?id=134518
Reviewed by Mark Hahnenberg.
This has no real effect right now, particularly since almost all uses of
setSetter/setGetter were already allocating a branch new GetterSetter. But once we start
doing more aggressive constant property inference, this change will allow us to remove
all runtime checks from getter/setter calls.
- runtime/GetterSetter.cpp:
(JSC::GetterSetter::withGetter):
(JSC::GetterSetter::withSetter):
- runtime/GetterSetter.h:
(JSC::GetterSetter::setGetter):
(JSC::GetterSetter::setSetter):
- runtime/JSObject.cpp:
(JSC::JSObject::defineOwnNonIndexProperty):
- 3:14 PM Changeset in webkit [170728] by
-
- 3 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Rename notifyTransitionFromThisStructure to didTransitionFromThisStructure
Rubber stamped by Mark Hahnenberg.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::didTransitionFromThisStructure):
(JSC::Structure::notifyTransitionFromThisStructure): Deleted.
- runtime/Structure.h:
- 3:12 PM Changeset in webkit [170727] by
-
- 3 edits in trunk/Source/WebCore
Remove keyed coding from FormData
https://bugs.webkit.org/show_bug.cgi?id=134565
Reviewed by Tim Horton.
- platform/network/FormData.cpp:
(WebCore::encodeElement): Deleted.
(WebCore::decodeElement): Deleted.
(WebCore::FormData::encode): Deleted.
(WebCore::FormData::decode): Deleted.
- platform/network/FormData.h:
- 3:04 PM Changeset in webkit [170726] by
-
- 4 edits in trunk/Source/WebCore
Get rid of the HistoryItem encoding/decoding in WebCore
https://bugs.webkit.org/show_bug.cgi?id=134564
Reviewed by Beth Dakin.
- WebCore.exp.in:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTree): Deleted.
(WebCore::encodeRect): Deleted.
(WebCore::encodeSize): Deleted.
(WebCore::HistoryItem::encodeBackForwardTreeNode): Deleted.
(WebCore::DecodeRecursionStackElement::DecodeRecursionStackElement): Deleted.
(WebCore::decodeRect): Deleted.
(WebCore::decodeSize): Deleted.
(WebCore::HistoryItem::decodeBackForwardTree): Deleted.
- history/HistoryItem.h:
- 2:49 PM Changeset in webkit [170725] by
-
- 6 edits2 deletes in trunk/Source/WebKit2
Rip out more dead code
https://bugs.webkit.org/show_bug.cgi?id=134562
Reviewed by Andreas Kling.
- Shared/LegacySessionState.cpp: Removed.
- Shared/LegacySessionState.h: Removed.
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem): Deleted.
(WebKit::WebBackForwardListItem::backForwardData): Deleted.
(WebKit::WebBackForwardListItem::setBackForwardData): Deleted.
(WebKit::WebBackForwardListItem::encode): Deleted.
(WebKit::WebBackForwardListItem::decode): Deleted.
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::create): Deleted.
(WebKit::WebBackForwardListItem::setOriginalURL): Deleted.
(WebKit::WebBackForwardListItem::setURL): Deleted.
(WebKit::WebBackForwardListItem::setTitle): Deleted.
- UIProcess/WebPageProxy.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.cpp:
- 2:35 PM Changeset in webkit [170724] by
-
- 5 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Remove the functionality for cloning StructureRareData since we never do that anymore.
Rubber stamped by Mark Hahnenberg.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::cloneRareDataFrom): Deleted.
- runtime/Structure.h:
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::clone): Deleted.
(JSC::StructureRareData::StructureRareData): Deleted.
- runtime/StructureRareData.h:
(JSC::StructureRareData::needsCloning): Deleted.
- 2:31 PM Changeset in webkit [170723] by
-
- 10 edits in trunk/Source/WebKit2
RestoreSession should take a vector of BackForwardListItemStates
https://bugs.webkit.org/show_bug.cgi?id=134558
Reviewed by Tim Horton.
- Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::itemStates):
- UIProcess/WebBackForwardList.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::creationParameters):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::restoreSession):
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 2:13 PM Changeset in webkit [170722] by
-
- 7 edits in trunk/Source/WebKit2
Store the back forward list item id inside BackForwardListItemState
https://bugs.webkit.org/show_bug.cgi?id=134557
Reviewed by Tim Horton.
- Shared/SessionState.cpp:
(WebKit::BackForwardListItemState::encode):
(WebKit::BackForwardListItemState::decode):
- Shared/SessionState.h:
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::encode):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::itemID):
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::restoreFromState):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- 2:05 PM Changeset in webkit [170721] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. EFL and GTK build fix after r170716.
- UIProcess/LegacySessionStateCodingNone.cpp:
(WebKit::decodeLegacySessionState): Update method signature.
- 2:03 PM Changeset in webkit [170720] by
-
- 2 edits in tags/Safari-538.44/Source/WTF
Merged r170713.
- 1:43 PM Changeset in webkit [170719] by
-
- 5 edits1 delete in trunk/Source/WebKit2
Begin ripping out the old session state code
https://bugs.webkit.org/show_bug.cgi?id=134556
Reviewed by Andreas Kling.
- UIProcess/WebBackForwardList.h:
- UIProcess/WebPageProxy.h:
- UIProcess/cf/WebBackForwardListCF.cpp: Removed.
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData): Deleted.
(WebKit::WebPageProxy::restoreFromSessionStateData): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 1:29 PM Changeset in webkit [170718] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] Fix crash when glsl expressions are too complex.
https://bugs.webkit.org/show_bug.cgi?id=134554
<rdar://problem/17540462>
Reviewed by Dean Jackson.
This fixes the Khronos test conformance/glsl/bugs/long-expressions-should-not-crash.html.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
Add SH_LIMIT_EXPRESSION_COMPLEXITY to the ANGLE compile options.
- 1:22 PM Changeset in webkit [170717] by
-
- 1 edit2 adds in trunk/LayoutTests
REGRESSION(160908): vube.com video won't play after going into and out of fullscreen
https://bugs.webkit.org/show_bug.cgi?id=134489
Reviewed by Zalan Bujtas.
- fullscreen/full-screen-plugin-expected.txt: Added.
- fullscreen/full-screen-plugin.html: Added.
- 1:19 PM Changeset in webkit [170716] by
-
- 8 edits in trunk/Source/WebKit2
Use legacy state coding directly in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=134553
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKPage.cpp:
(WKPageRestoreFromSessionState):
- UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateCreateFromData):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _sessionStateData]):
(-[WKWebView _sessionState]):
(-[WKWebView _restoreFromSessionStateData:]):
(-[WKWebView _restoreFromSessionState:]):
(releaseNSData): Deleted.
- UIProcess/LegacySessionStateCoding.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::restoreFromState): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeLegacySessionState):
- 12:55 PM Changeset in webkit [170715] by
-
- 2 edits in trunk/Tools
Unreviewed. Moved self to reviewers list.
- Scripts/webkitpy/common/config/contributors.json:
Moved self to reviewers list, added WebGL to expertise.
- 12:48 PM Changeset in webkit [170714] by
-
- 5 edits in trunk/Source/WebCore
WebCore JIT: rename registerCount to something less generic and add new types for lists of registers and lists of stack references
https://bugs.webkit.org/show_bug.cgi?id=134552
Reviewed by Alex Christensen.
Little cleanup:
-The name registerCount was a little too generic. Rename that to "maximumRegisterCount" to avoid confusion.
-Add a new type RegisterVector for any vector holding registers. This is just to avoid repeating the inline
size everywhere, no functional change.
-Same idea for the stack: welcome StackReferenceVector!
- cssjit/FunctionCall.h:
(WebCore::FunctionCall::saveAllocatedCallerSavedRegisters):
Remove the appendVector here. It was unnecessarily cautious, StackAllocator already protect us
from mistakes.
- cssjit/RegisterAllocator.h:
(WebCore::RegisterAllocator::allocatedRegisters):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Changing from the count of "calleeSavedRegisterCount" to "maximumRegisterCount" will cause
calleeSavedRegisterStackReferences to always overallocate.
The code generator is never on the heap, so that should not change anything.
- cssjit/StackAllocator.h:
(WebCore::StackAllocator::push):
(WebCore::StackAllocator::pop):
- 12:40 PM Changeset in webkit [170713] by
-
- 2 edits in trunk/Source/WTF
iOS build fix after http://trac.webkit.org/changeset/170697.
Unreviewed.
- wtf/Deque.h:
- 11:30 AM Changeset in webkit [170712] by
-
- 2 edits in trunk/LayoutTests
Skip fast/canvas/webgl/tex-image-and-sub-image-2d-with-potentially-subsampled-image.html
on Mountain Lion. It doesn't support such large textures (or at least our
bots don't).
- platform/mac/TestExpectations:
- 10:40 AM Changeset in webkit [170711] by
-
- 3 edits in trunk/Source/WebKit2
Add -[WKWebView _sessionStateData] and -[WKWebView _restoreFromSessionStateData:]
https://bugs.webkit.org/show_bug.cgi?id=134549
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _sessionState]):
(-[WKWebView _sessionStateData]):
(-[WKWebView _restoreFromSessionState:]):
(-[WKWebView _restoreFromSessionStateData:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 10:33 AM Changeset in webkit [170710] by
-
- 16 edits in trunk/Source
Remove some code only needed for versions of Safari that are no longer supported
https://bugs.webkit.org/show_bug.cgi?id=134537
Reviewed by Anders Carlsson.
Source/WebCore:
- bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _rectOnScreen]): Deleted.
(-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): Deleted.
(-[DOMHTMLInputElement _selectedRange]): Deleted.
- bindings/objc/DOMPrivate.h:
- editing/EditorCommand.cpp:
(WebCore::createCommandMap):
Source/WebKit/mac:
- History/WebHistoryItem.mm:
- Misc/WebKitVersionChecks.h:
- WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin domain]): Deleted.
- WebInspector/WebInspector.mm:
(-showTimeline:): Deleted.
(+webInspector): Deleted.
(-setWebFrame:): Deleted.
(-window): Deleted.
(-showWindow:): Deleted.
- WebView/WebFrame.mm:
(-[WebFrame reload]):
- WebView/WebPDFView.mm:
(-[WebPDFView menuForEvent:]):
(-[WebPDFView _anyPDFTagsFoundInMenu:]): Deleted.
- WebView/WebView.mm:
(-[WebView _initWithFrame:frameName:groupName:]):
(-[WebView _preferencesChanged:]):
(-[WebView initWithFrame:frameName:groupName:]):
(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): Deleted.
(+[WebView _setAlwaysUseATSU:]): Deleted.
(-[WebView _needsUnrestrictedGetMatchedCSSRules]): Deleted.
- WebView/WebViewPrivate.h:
Source/WTF:
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- 9:02 AM Changeset in webkit [170709] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] MediaPlayerPrivateGStreamer.cpp fails to build when VIDEO_TRACK is enabled and using GSTREAMER_MPEGTS
https://bugs.webkit.org/show_bug.cgi?id=134548
Reviewed by Philippe Normand.
Include AtomicStringHash.h when ENABLE(VIDEO_TRACK) && USE(GSTREAMER_MPEGTS)
since it's used by HashMap<AtomicString, RefPtr<InbandMetadataTextTrackPrivateGStreamer>>
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 8:24 AM Changeset in webkit [170708] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Unstable headers should include webkitdomdefines-unstable.h
https://bugs.webkit.org/show_bug.cgi?id=134540
Reviewed by Martin Robinson.
Instead of the class header that can only be included from webkitdom.h.
- bindings/scripts/CodeGeneratorGObject.pm:
(WriteData):
- 8:22 AM Changeset in webkit [170707] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] WebKitVersion.h should be shared between UI and Web Process APIs
https://bugs.webkit.org/show_bug.cgi?id=134538
Reviewed by Martin Robinson.
To be able to check current version from web extensions too.
- UIProcess/API/gtk/WebKitVersion.h.in: Allow to include WebKitVersion.h also from webkit-web-extension.h.
- WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h: Include WebKitVersion.h.
- 8:13 AM Changeset in webkit [170706] by
-
- 2 edits in trunk/Tools
[GTK] Make dist only works when run from the source directory
https://bugs.webkit.org/show_bug.cgi?id=134543
Reviewed by Martin Robinson.
Since the paths in the manifest are relative to the source dir,
and the script expects the current working directory to be the
source directory, resolve all passed in relative paths while
parsing the arguments and then change the current working
directory.
- gtk/make-dist.py:
- 8:11 AM Changeset in webkit [170705] by
-
- 5 edits in trunk
[GTK] make dist is broken
https://bugs.webkit.org/show_bug.cgi?id=134542
Reviewed by Martin Robinson.
.:
- Source/PlatformGTK.cmake: Remove ENABLE_WEBKIT check.
Tools:
- gtk/make-dist.py: Rename command line options to match what cmake uses.
- gtk/manifest.txt: Remove WebKit1 references and add WebKitDOM documentation.
- 4:03 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 2:52 AM Changeset in webkit [170704] by
-
- 4 edits in trunk
REGRESSION(r170008): [GTK] Layout Tests fast/forms/option-constructor-selected.html and fast/forms/select-live-pseudo-selectors.html crash.
https://bugs.webkit.org/show_bug.cgi?id=134399
Reviewed by Chris Fleizach.
Source/WebCore:
Check that the value of optionIndex passed as a parameter is valid
before calling didUpdateActiveOption() over the item of the menu
list, to prevent crashes in platforms where renderers (and therefore
accessibility objects) might not be created for items at the time
of calling AccessibilityMenuList::didUpdateActiveOption().
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::didUpdateActiveOption): Added check.
LayoutTests:
Removing Crash expectations for two layout tests.
- platform/gtk/TestExpectations: Updated.
- 1:22 AM Changeset in webkit [170703] by
-
- 1 copy in tags/Safari-538.44
New Tag.
- 12:19 AM Changeset in webkit [170702] by
-
- 22 edits3 adds in trunk
[GTK] WebKitWebView::create should receive information about the navigation action
https://bugs.webkit.org/show_bug.cgi?id=133680
Reviewed by Martin Robinson.
Source/WebKit2:
Add WebKitNavigationAction boxed type representing a navigation
action to be passed as parameter of WebKitWebView::create
signal. In the future it could be also for the
WebKitNavigationPolicyDecision class. The class contains
information about a navigation action like the navigation type,
the request, the mouse button and key modifiers and whether it was
started by a user gesture. This information is needed to be able
to implement a proper popup blocker. Since all that information is
not provided by the C API, we have switched the UI client to use a
custom client derived from API::UIClient. This also avoids a lot
of toAPI -> toImpl unneeded conversions.
- PlatformGTK.cmake: Add new files to compilation.
- UIProcess/API/gtk/WebKitHitTestResult.cpp:
(webkitHitTestResultCreate): Use a WebHitTestResult::Data const
reference instead of a pointer to a WebHitTestResult.
(webkitHitTestResultCompare): Ditto.
- UIProcess/API/gtk/WebKitHitTestResultPrivate.h:
- UIProcess/API/gtk/WebKitNavigationAction.cpp: Added.
(webkitNavigationActionCreate): Create a WebKitNavigationAction
for the given ResourceRequest and NavigationActionData.
(webkit_navigation_action_copy):
(webkit_navigation_action_free):
(webkit_navigation_action_get_navigation_type):
(webkit_navigation_action_get_mouse_button):
(webkit_navigation_action_get_modifiers):
(webkit_navigation_action_get_request):
(webkit_navigation_action_is_user_gesture):
- UIProcess/API/gtk/WebKitNavigationAction.h: Added.
- UIProcess/API/gtk/WebKitNavigationActionPrivate.h: Added.
- UIProcess/API/gtk/WebKitNavigationPolicyDecision.h:
- UIProcess/API/gtk/WebKitPrivate.cpp:
(toGdkModifiers):
(toWebKitNavigationType):
(toWebKitMouseButton):
- UIProcess/API/gtk/WebKitPrivate.h:
- UIProcess/API/gtk/WebKitUIClient.cpp:
(UIClient::UIClient): Implement the UIClient using a custom class.
(attachUIClientToView): Set the UIClient directly to the WebPageProxy.
(createNewPage): Deleted.
(showPage): Deleted.
(closePage): Deleted.
(runJavaScriptAlert): Deleted.
(runJavaScriptConfirm): Deleted.
(runJavaScriptPrompt): Deleted.
(toolbarsAreVisible): Deleted.
(setToolbarsAreVisible): Deleted.
(menuBarIsVisible): Deleted.
(setMenuBarIsVisible): Deleted.
(statusBarIsVisible): Deleted.
(setStatusBarIsVisible): Deleted.
(isResizable): Deleted.
(setIsResizable): Deleted.
(getWindowFrame): Deleted.
(setWindowFrame): Deleted.
(mouseDidMoveOverElement): Deleted.
(printFrame): Deleted.
(runOpenPanel): Deleted.
(decidePolicyForGeolocationPermissionRequest): Deleted.
(runModal): Deleted.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewCreate): Add WebKitNavigationAction parameter.
(webkit_web_view_class_init): Add WebKitNavigationAction paramter
to CREATE signal.
(webkitWebViewCreateNewPage): Add WebKitNavigationAction parameter
and pass it to the signal callbacks.
(webkitWebViewMouseTargetChanged): Use a WebHitTestResult::Data
const reference.
(webkitWebViewPopulateContextMenu): Ditto.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/WebKitWindowProperties.cpp:
(webkitWindowPropertiesUpdateFromWebWindowFeatures): Use a
WebCore::WindowFeatures const reference.
- UIProcess/API/gtk/WebKitWindowPropertiesPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/webkit2.h: Include WebKitNavigationAction.h.
Tools:
Add unit test to check the WebKitNavigationAction passed to
WebKitWebView::create callback.
- MiniBrowser/gtk/BrowserWindow.c:
(webViewCreate): Add WebKitNavigationAction parameter.
- TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
(testWebViewCreateNavigationData):
(beforeAll):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
(createCallback):
- 12:09 AM Changeset in webkit [170701] by
-
- 8 edits in trunk
[GTK] Do not add forward declaration of class struct for interfaces
https://bugs.webkit.org/show_bug.cgi?id=134297
Reviewed by Martin Robinson.
Source/WebCore:
- PlatformGTK.cmake: Make files generated by
gobject-generate-headers.pl script depend on it.
- bindings/gobject/WebKitDOMEventTarget.h: Remove forward declaration.
- bindings/gobject/WebKitDOMNodeFilter.h: Ditto
- bindings/gobject/WebKitDOMXPathNSResolver.h: Ditto.
- bindings/scripts/gobject-generate-headers.pl: Use Iface instead
of Class suffix for interfaces.
Tools:
Add Iface symbol to documentation instead of Class for interfaces.
- gtk/webkitdom.py:
(WebKitDOMDocGeneratorSections.write_section):
- 12:04 AM Changeset in webkit [170700] by
-
- 7 edits7 adds in trunk
[GTK] XPathNSResolver should be exposed as an interface instead of as a class
https://bugs.webkit.org/show_bug.cgi?id=134028
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Add custom implementation of WebKitDOMXPathNSResolver to expose it
as an interface instead of a class. It also includes an internal
default implementation of the interface to support methods that
create a XPathNSResolver using the native implementation.
- PlatformGTK.cmake: Add new files to compilation.
- bindings/gobject/GObjectXPathNSResolver.cpp: Added.
(WebCore::GObjectXPathNSResolver::~GObjectXPathNSResolver):
(WebCore::GObjectXPathNSResolver::lookupNamespaceURI): Call
webkit_dom_xpath_ns_resolver_lookup_namespace_uri().
- bindings/gobject/GObjectXPathNSResolver.h: Added.
(WebCore::GObjectXPathNSResolver::create):
(WebCore::GObjectXPathNSResolver::GObjectXPathNSResolver): Create
a new GObjectXPathNSResolver for the given WebKitDOMXPathNSResolver.
- bindings/gobject/WebKitDOMXPathNSResolver.cpp: Added.
(webkit_dom_xpath_ns_resolver_default_init):
(webkit_dom_xpath_ns_resolver_lookup_namespace_uri):
(webkitDOMNativeXPathNSResolverFinalize):
(webkitDOMNativeXPathNSResolverConstructor):
(webkit_dom_native_xpath_ns_resolver_init):
(webkit_dom_native_xpath_ns_resolver_class_init):
(webkitDOMNativeXPathNSResolverLookupNamespaceURI):
(webkitDOMXPathNSResolverIfaceInit):
(WebKit::core): Return the native XPathNSResolver when using the
internal implementation or create a custom XPathNSResolver when
using a user provided WebKitDOMXPathNSResolver.
(WebKit::kit):
- bindings/gobject/WebKitDOMXPathNSResolver.h: Added.
- bindings/gobject/WebKitDOMXPathNSResolverPrivate.h: Added.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction): Add exceptions for XPathNSResolver since
the core method returns a PassRefPtr.
Tools:
Add unit tests to check WebKitDOMXPathNSResolver API when using the
native one and a user provided one.
- Scripts/webkitpy/style/checker.py: Add WebKitDOMXPathNSResolver
to the list of GTK+ public API exceptions.
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Added.
(webkitXPathNSResolverLookupNamespaceURI):
(webkitXPathNSResolverDOMXPathNSResolverIfaceInit):
(webkit_xpath_ns_resolver_init):
(webkit_xpath_ns_resolver_class_init):
(WebKitDOMXPathNSResolverTest::create):
(WebKitDOMXPathNSResolverTest::webPageFromArgs):
(WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
(WebKitDOMXPathNSResolverTest::runTest):
(registerTests):
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Added.
(runTest):
(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):
(serverCallback):
(beforeAll):
(afterAll):
- gtk/webkitdom.py:
(WebKitDOMDocGeneratorSections.write_section): Add
WebKitDOMXPathNSResolver to the list of interfaces.
Jul 1, 2014:
- 11:44 PM Changeset in webkit [170699] by
-
- 6 edits4 deletes in trunk
The OpenType MATH table is not read on Mac
https://bugs.webkit.org/show_bug.cgi?id=133569
Reviewed by Chris Fleizach.
Source/WebCore:
An incorrect tag format is used to load the OpenType MATH table on Mac.
This commit makes the format consistent with what is used for other tables on Mac.
This will allow to load the MATH table and to use it for the MathML rendering.
No new tests. platform/graphics/opentype already contains tests for the OpenType MATH support.
- platform/graphics/opentype/OpenTypeMathData.cpp:
LayoutTests:
We update the references for some tests in LayoutTests/mathml/opentype/ and remove the failure from TestExpectations.
Other tests require a font with a MATH table to be installed on Mac bots and to be used by default (bug 133603).
- platform/mac-wk2/mathml/opentype/opentype-stretchy-expected.txt: Removed.
- platform/mac/TestExpectations: Enable mathml/opentype/opentype-stretchy-horizontal.html and mathml/opentype/opentype-stretchy.html.
- platform/mac/mathml/horizontal-LatinModern-expected.txt: Removed. This file should not have been in this directory.
- platform/mac/mathml/horizontal-LatinModern-munderover-expected.txt: Removed. This file should not have been in this directory.
- platform/mac/mathml/opentype-stretchy-horizontal-expected.txt: Removed. This file should not have been in this directory.
- platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Add text reference.
- platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Add text reference.
- 10:57 PM Changeset in webkit [170698] by
-
- 5 edits in trunk/Source
[Win64] Unreviewed build fix.
Source/WebCore:
- WebCore.vcxproj/WebCore.vcxproj:
Exclude CA files from 32 and 64 bit WinCairo builds.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj:
Don't use a precompiled header in 32 or 63 bit builds of MockCDM.cpp.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Corrected 64-bit linker symbols.
- 9:49 PM Changeset in webkit [170697] by
-
- 7 edits in trunk/Source
Reduce dynamic memory allocation in css jit.
https://bugs.webkit.org/show_bug.cgi?id=134416
Reviewed by Benjamin Poulain.
Source/WebCore:
- cssjit/FunctionCall.h:
(WebCore::FunctionCall::saveAllocatedRegisters):
- cssjit/RegisterAllocator.h:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
- cssjit/StackAllocator.h:
(WebCore::StackAllocator::push):
(WebCore::StackAllocator::pop):
Use inlineCapacity template parameter to reduce malloc calls.
I use 32 as the inline capacity for non-register related vectors because that
is probably big enough for the selector compiler, and if it is not then a malloc
call will not be significant because the selector is very complex.
Source/WTF:
- wtf/Deque.h:
Added inlineCapacity optional template parameter.
- 9:49 PM Changeset in webkit [170696] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix occurrence of two cursors on WK2 EFL.
https://bugs.webkit.org/show_bug.cgi?id=134436
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-07-01
Reviewed by Anders Carlsson.
ecore_x_window_cursor is released when ecore_evas_object_cursor should be shown in order to avoid occurrence of two cursors.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::updateCursor):
- 8:44 PM Changeset in webkit [170695] by
-
- 4 edits in trunk
Fix build break on EFL and GTK ports since r170683
https://bugs.webkit.org/show_bug.cgi?id=134536
Unreviewed, build fix.
Source/WebKit2:
- CMakeLists.txt:
Tools:
- TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
- 8:35 PM Changeset in webkit [170694] by
-
- 24 edits in trunk
WebVTT percentage value can be a float
https://bugs.webkit.org/show_bug.cgi?id=134511
Reviewed by Brent Fulgham.
Source/WebCore:
No new tests, existing tests modified.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::setLine): int -> double.
(WebCore::TextTrackCueGeneric::setPosition): Ditto.
- html/track/TextTrackCueGeneric.h:
- html/track/VTTCue.cpp:
(WebCore::VTTCue::setLine): Ditto.
(WebCore::VTTCue::setPosition): Ditto.
(WebCore::VTTCue::setCueSettings): Support floating point values for line, position, and size.
(WebCore::scanPercentage): Deleted.
- html/track/VTTCue.h:
- html/track/VTTScanner.cpp:
(WebCore::VTTScanner::scanFloat): Support negative values.
- html/track/VTTScanner.h:
- html/track/WebVTTParser.cpp: Include parseFloatPercentageValue in non-WEBVTT_REGIONS builds.
- html/track/WebVTTParser.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Drive by change to take a cue
reference rather than a pointer.
(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings): Ditto.
(WebCore::InbandTextTrackPrivateAVF::removeCompletedCues): Loop over all cues, don't LOG that
we are asking the client to delete the cue because the client will have already deleted
it when status when to GenericCueData::Complete.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
LayoutTests:
- media/track/captions-webvtt/tc015-positioning-ltr.vtt:
- media/track/captions-webvtt/tc015-positioning.vtt:
- media/track/captions-webvtt/tc017-line-position.vtt:
- media/track/captions-webvtt/tc018-align-text-line-position.vtt:
- media/track/captions-webvtt/tc019-cue-size.vtt:
- media/track/track-webvtt-tc015-positioning-expected.txt:
- media/track/track-webvtt-tc015-positioning.html:
- media/track/track-webvtt-tc017-line-position-expected.txt:
- media/track/track-webvtt-tc017-line-position.html:
- media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
- media/track/track-webvtt-tc018-align-text-line-position.html:
- media/video-test.js:
(testCues):
- 8:21 PM Changeset in webkit [170693] by
-
- 2 edits in trunk/Source/WebKit2
Make LogsPageMessagesToSystemConsoleEnabled a global debug preference
https://bugs.webkit.org/show_bug.cgi?id=134534
Reviewed by Joseph Pecoraro.
- Shared/WebPreferencesDefinitions.h:
- 8:06 PM Changeset in webkit [170692] by
-
- 2 edits in trunk/Source/WebKit2
Handle invalid data more gracefully.
Reviewed by Anders Carlsson.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeFormData):
(WebKit::decodeBackForwardTreeNode):
- 7:50 PM Changeset in webkit [170691] by
-
- 2 edits in trunk/LayoutTests
Fix this test; it was waiting about 32 years for the end of an animation.
What we really care about is the start of the animation.
- compositing/animation/keyframe-order.html:
- 7:43 PM Changeset in webkit [170690] by
-
- 2 edits in trunk/Source/WebCore
Improve behavior of position:sticky on zoomed pages
https://bugs.webkit.org/show_bug.cgi?id=134535
<rdar://problem/12898829>
Reviewed by Dean Jackson.
Despite r138036, position:sticky still had incorrect behavior in zoomed pages.
Fix by removing the scaling of the rect from viewportConstrainedVisibleContentRect(),
since all the other math happens in unscaled coordinates.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::constrainingRectForStickyPosition):
- 7:24 PM Changeset in webkit [170689] by
-
- 2 edits in trunk/Source/WebKit2
Add a missing return statement in WKPageCopySessionState.
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKPage.cpp:
(WKPageCopySessionState):
- 6:36 PM Changeset in webkit [170688] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove WebChromeClient code that was only needed for Safari versions earlier than 3.1
https://bugs.webkit.org/show_bug.cgi?id=134531
Reviewed by Daniel Bates.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::exceededDatabaseQuota):
- 6:27 PM Changeset in webkit [170687] by
-
- 2 edits in trunk/Source/WebKit2
Don't encode/decode the snapshot UUID
https://bugs.webkit.org/show_bug.cgi?id=134532
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeSessionHistory):
(WebKit::decodeSessionHistoryEntry):
- 6:24 PM Changeset in webkit [170686] by
-
- 10 edits in trunk/Source/WebKit2
Unreviewed, rolling out r170608.
https://bugs.webkit.org/show_bug.cgi?id=134533
Safari keeps crashing on device due to sandbox violation.
(Requested by enrica on #webkit).
Reverted changeset:
"Restrict network process sandbox"
https://bugs.webkit.org/show_bug.cgi?id=134360
http://trac.webkit.org/changeset/170608
- 5:57 PM Changeset in webkit [170685] by
-
- 6 edits in trunk
Encode/decode CFURLRequestRefs when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=134454
<rdar://problem/17510980>
Reviewed by Andreas Kling.
Source/WebKit2:
Use new helper methods to serialize/deserialize CFURLRequestRef directly so we can avoid
creating NSURLRequest.
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceMavericks.a:
- libWebKitSystemInterfaceMountainLion.a:
- 5:49 PM Changeset in webkit [170684] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Fix a race between the short tap and long tap highlight
https://bugs.webkit.org/show_bug.cgi?id=134530
Reviewed by Enrica Casucci.
There was a potential race of event that can theoretically cause WKContentViewInteraction
to call [WKContentView _showTapHighlight] after all interactions have been cancelled.
The race would be like this:
1) On a short tap, _singleTapRecognized: is called, a tap highlight ID is defined and
_potentialTapInProgress is set to YES.
2) For some reason, the gesture is cancelled. The method _singleTapDidReset is called,
setting _potentialTapInProgress but leaving the tap highlight ID as valid.
3) The UIProcess receives the tap highlight information from the WebProcess, _didGetTapHighlightForRequest:
has a valid ID, _potentialTapInProgress is false -> the highlight is shown right away as if a long tap
was in progress.
The missing piece that causes this is _singleTapDidReset: must also invalidate the tap highlight ID. This is done
in the new static function cancelPotentialTapIfNecessary().
Just invalidating the ID would create another race:
1) Short tap gesture recognizer starts.
2) The long press recognizer starts before (1) is commited.
3) The long press recognizers sets up its own tap highlight ID.
4) The short tap gesture recognizer resets, erasing the tap highlight ID defined in (3).
To avoid this, the long press gesture recognizers immediately cancels any potential tap in progress.
If _singleTapDidReset: is called before (3), this does nothing. If the reset is called after (3),
_singleTapDidReset does nothing.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _highlightLongPressRecognized:]):
(cancelPotentialTapIfNecessary):
(-[WKContentView _singleTapDidReset:]):
- 5:47 PM Changeset in webkit [170683] by
-
- 8 edits in trunk
Add ABI hacks to allow WKPageRef to use WKSessionStateRef
https://bugs.webkit.org/show_bug.cgi?id=134529
Reviewed by Sam Weinig.
- UIProcess/API/APISessionState.h:
Add a sessionState() getter.
- UIProcess/API/C/WKPage.cpp:
(WKPageCopySessionState):
Add a hack where we return a WKSessionStateRef if the least significant bit of the context pointer
is 1, and a WKDataRef otherwise.
(WKPageRestoreFromSessionState):
Handle both WKDataRef and WKSessionStateref.
- UIProcess/API/C/WKPage.h:
Use WKTypeRefs for state saving and restoration.
- UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateCopyData):
Add helper function.
- 5:43 PM Changeset in webkit [170682] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] Fix PVRTC extension.
https://bugs.webkit.org/show_bug.cgi?id=134525
Patch by Alex Christensen <achristensen@webkit.org> on 2014-07-01
Reviewed by Dean Jackson.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions):
Remove the return false which I mistakenly committed in r170128
and make the gl error match the S3TC error and the khronos test.
- 5:13 PM Changeset in webkit [170681] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Hexadecimal color values in all CSS editors are purple when they should be blue
https://bugs.webkit.org/show_bug.cgi?id=133997
Reviewed by Joseph Pecoraro.
CodeMirror 4 removed the style for hex colors from the CSS tokenizer.
Feature has been added to CodeMirrorAdditions.js.
- UserInterface/Views/CodeMirrorAdditions.js: Added hex-color to style for a valid hexadecimal color.
- UserInterface/Views/SyntaxHighlightingDefaultTheme.css: Added selector for hexadecimal color.
- 5:12 PM Changeset in webkit [170680] by
-
- 17 edits1 delete in branches/ftlopt/Source
[ftlopt] DebuggerCallFrame::scope() should return a DebuggerScope.
<https://webkit.org/b/134420>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Previously, DebuggerCallFrame::scope() returns a JSActivation (and relevant
peers) which the WebInspector will use to introspect CallFrame variables.
Instead, we should be returning a DebuggerScope as an abstraction layer that
provides the introspection functionality that the WebInspector needs. This
is the first step towards not forcing every frame to have a JSActivation
object just because the debugger is enabled.
- Instantiate the debuggerScopeStructure as a member of the JSGlobalObject instead of the VM. This allows JSObject::globalObject() to be able to return the global object for the DebuggerScope.
- On the DebuggerScope's life-cycle management:
The DebuggerCallFrame is designed to be "valid" only during a debugging session
(while the debugger is broken) through the use of a DebuggerCallFrameScope in
Debugger::pauseIfNeeded(). Once the debugger resumes from the break, the
DebuggerCallFrameScope destructs, and the DebuggerCallFrame will be invalidated.
We can't guarantee (from this code alone) that the Inspector code isn't still
holding a ref to the DebuggerCallFrame (though they shouldn't), but by contract,
the frame will be invalidated, and any attempt to query it will return null values.
This is pre-existing behavior.
Now, we're adding the DebuggerScope into the picture. While a single debugger
pause session is in progress, the Inspector may request the scope from the
DebuggerCallFrame. While the DebuggerCallFrame is still valid, we want
DebuggerCallFrame::scope() to always return the same DebuggerScope object.
This is why we hold on to the DebuggerScope with a strong ref.
If we use a weak ref instead, the following cooky behavior can manifest:
- The Inspector calls Debugger::scope() to get the top scope.
- The Inspector iterates down the scope chain and is now only holding a reference to a parent scope. It is no longer referencing the top scope.
- A GC occurs, and the DebuggerCallFrame's weak m_scope ref to the top scope gets cleared.
- The Inspector calls DebuggerCallFrame::scope() to get the top scope again but gets a different DebuggerScope instance.
- The Inspector iterates down the scope chain but never sees the parent scope instance that retained a ref to in step 2 above. This is because when iterating this new DebuggerScope instance (which has no knowledge of the previous parent DebuggerScope instance), a new DebuggerScope instance will get created for the same parent scope.
Since the DebuggerScope is a JSObject, it's liveness is determined by its reachability.
However, it's "validity" is determined by the life-cycle of its owner DebuggerCallFrame.
When the owner DebuggerCallFrame gets invalidated, its debugger scope chain (if
instantiated) will also get invalidated. This is why we need the
DebuggerScope::invalidateChain() method. The Inspector should not be using the
DebuggerScope instance after its owner DebuggerCallFrame is invalidated. If it does,
those methods will do nothing or returned a failed status.
- debugger/Debugger.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::evaluate):
(JSC::DebuggerCallFrame::invalidate):
(JSC::DebuggerCallFrame::vm):
(JSC::DebuggerCallFrame::lexicalGlobalObject):
- debugger/DebuggerCallFrame.h:
- debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::DebuggerScope):
(JSC::DebuggerScope::finishCreation):
(JSC::DebuggerScope::visitChildren):
(JSC::DebuggerScope::className):
(JSC::DebuggerScope::getOwnPropertySlot):
(JSC::DebuggerScope::put):
(JSC::DebuggerScope::deleteProperty):
(JSC::DebuggerScope::getOwnPropertyNames):
(JSC::DebuggerScope::defineOwnProperty):
(JSC::DebuggerScope::next):
(JSC::DebuggerScope::invalidateChain):
(JSC::DebuggerScope::isWithScope):
(JSC::DebuggerScope::isGlobalScope):
(JSC::DebuggerScope::isFunctionScope):
- debugger/DebuggerScope.h:
(JSC::DebuggerScope::create):
(JSC::DebuggerScope::Iterator::Iterator):
(JSC::DebuggerScope::Iterator::get):
(JSC::DebuggerScope::Iterator::operator++):
(JSC::DebuggerScope::Iterator::operator==):
(JSC::DebuggerScope::Iterator::operator!=):
(JSC::DebuggerScope::isValid):
(JSC::DebuggerScope::jsScope):
(JSC::DebuggerScope::begin):
(JSC::DebuggerScope::end):
- inspector/JSJavaScriptCallFrame.cpp:
(Inspector::JSJavaScriptCallFrame::scopeType):
(Inspector::JSJavaScriptCallFrame::scopeChain):
- inspector/JavaScriptCallFrame.h:
(Inspector::JavaScriptCallFrame::scopeChain):
- inspector/ScriptDebugServer.cpp:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::debuggerScopeStructure):
- runtime/JSObject.h:
(JSC::JSObject::isWithScope):
- runtime/JSScope.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
Source/WebCore:
No new tests.
- ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
- This is not in use. Hence, we can remove it.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::attachDebugger):
- We should acquire the JSLock before modifying a JS global object.
- 5:08 PM Changeset in webkit [170679] by
-
- 4 edits in trunk/Source/WebKit2
WKPageRestoreFromSessionState should use the new session state restore code path
https://bugs.webkit.org/show_bug.cgi?id=134526
Reviewed by Tim Horton.
- UIProcess/API/C/WKPage.cpp:
(WKPageRestoreFromSessionState):
Use the new code path.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromState):
Only restore the back-forward state if we have a back-forward list.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeSessionHistory):
Save the original URL string as well.
(WebKit::decodeV1SessionHistory):
If we don't have a current index, set it to Nullopt instead of 0.
- 4:57 PM Changeset in webkit [170678] by
-
- 3 edits2 adds in trunk
AX: iOS does not expose ARIA toggle buttons at all (not even as a regular button)
https://bugs.webkit.org/show_bug.cgi?id=133875
Reviewed by Enrica Casucci.
Source/WebCore:
Support the toggle button type in iOS.
Test: platform/ios-sim/accessibility/toggle-button.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
LayoutTests:
- platform/ios-sim/accessibility/toggle-button-expected.txt: Added.
- platform/ios-sim/accessibility/toggle-button.html: Added.
- 4:40 PM Changeset in webkit [170677] by
-
- 4 edits in trunk/Source/JavaScriptCore
Debugger's breakpoint list should not be a Vector.
<https://webkit.org/b/134514>
Reviewed by Geoffrey Garen.
The debugger currently stores breakpoint data as entries in a Vector (see
BreakpointsInLine). It also keeps a fast map look up of breakpoint IDs to
the breakpoint data (see m_breakpointIDToBreakpoint). Because a Vector can
compact or reallocate its backing store, this can causes all sorts of havoc.
The m_breakpointIDToBreakpoint map assumes that the breakpoint data doesn't
move in memory.
The fix is to replace the BreakpointsInLine Vector with a BreakpointsList
doubly linked list.
- debugger/Breakpoint.h:
(JSC::Breakpoint::Breakpoint):
(JSC::BreakpointsList::~BreakpointsList):
- debugger/Debugger.cpp:
(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::hasBreakpoint):
- debugger/Debugger.h:
- 4:40 PM Changeset in webkit [170676] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. EFL and GTK build fix since r170654.
- UIProcess/LegacySessionStateCodingNone.cpp: Add a dummy encodeLegacySessionState(const SessionState&).
(WebKit::encodeLegacySessionState):
- 4:26 PM Changeset in webkit [170675] by
-
- 6 edits6 adds in trunk
[iOS] Subsampled JPEG images do not draw correctly via the canvas APIs
https://bugs.webkit.org/show_bug.cgi?id=134513
<rdar://problem/12078860>
<rdar://problem/16745393>
Reviewed by Tim Horton.
Source/WebCore:
Subsampled images (e.g. JPEG) were not consistently using
their original dimensions and subsampled dimensions. This caused
things like texImage2D to pack the pixels incorrectly, or drawImage
to squish the rendering.
Renamed m_scale to m_subsamplingScale on FrameData.
Tests: fast/canvas/image-potential-subsample.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-potentially-subsampled-image.html
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::cacheFrame): Rename to m_subsamplingScale.
(WebCore::BitmapImage::frameAtIndex): Ditto.
- platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData): Ditto.
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::FrameData::clear): Ditto.
(WebCore::BitmapImage::BitmapImage): Ditto.
(WebCore::BitmapImage::draw): Use a scaledSrcRect that reflects the subsampled size,
rather than assuming the srcRect accurately reflects how many pixels we have
in the Bitmap.
(WebCore::BitmapImage::copyUnscaledFrameAtIndex):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage): Similar fix, although this
time we just ask the image decoder to take into account the subsampled size
when it is "generating" a frame, causing it to use the bitmap data it has already
decoded.
LayoutTests:
Add Canvas2D and WebGL tests that exercise a very large JPEG image.
The WebGL test is mostly copied from the WebGL test suite, so please
excuse the coding style.
- fast/canvas/image-potential-subsample-expected.txt: Added.
- fast/canvas/image-potential-subsample.html: Added.
- fast/canvas/resources/image-8000x8000.jpg: Added.
- fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-potentially-subsampled-image.js: Added.
(.init):
(.runOneIteration):
(.runTestOnImage):
(.runTest):
(generateTest):
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-potentially-subsampled-image-expected.txt: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-potentially-subsampled-image.html: Added.
- 4:22 PM Changeset in webkit [170674] by
-
- 2 edits in trunk/Source/WebKit2
Crash in WebDocumentLoader::setNavigationID
https://bugs.webkit.org/show_bug.cgi?id=134520
Reviewed by Anders Carlsson.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::didReceivePolicyDecision): Null-check the policy document loader.
- 4:01 PM Changeset in webkit [170673] by
-
- 2 edits in trunk/Source/WebKit2
Build fix.
- UIProcess/API/APILoaderClient.h:
(API::LoaderClient::didDestroyNavigation):
- 3:40 PM Changeset in webkit [170672] by
-
- 15 edits9 adds in branches/ftlopt/Source/JavaScriptCore
[ftlopt] DFG bytecode parser should turn PutById with nothing but a Setter stub as stuff+handleCall, and handleCall should be allowed to inline if it wants to
https://bugs.webkit.org/show_bug.cgi?id=130756
Reviewed by Oliver Hunt.
The enables exposing the call to setters in the DFG, and then inlining it. Previously we
already supproted inlined-cached calls to setters from within put_by_id inline caches,
and the DFG could certainly emit such IC's. Now, if an IC had a setter call, then the DFG
will either emit the GetGetterSetterByOffset/GetSetter/Call combo, or it will do one
better and inline the call.
A lot of the core functionality was already available from the previous work to inline
getters. So, there are some refactorings in this patch that move preexisting
functionality around. For example, the work to figure out how the DFG should go about
getting to what we call the "loaded value" - i.e. the GetterSetter object reference in
the case of accessors - is now shared in ComplexGetStatus, and both GetByIdStatus and
PutByIdStatus use it. This means that we can keep the safety checks common. This patch
also does additional refactorings in DFG::ByteCodeParser so that we can continue to reuse
handleCall() for all of the various kinds of calls we can now emit.
83% speed-up on getter-richards, 2% speed-up on box2d.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/ComplexGetStatus.cpp: Added.
(JSC::ComplexGetStatus::computeFor):
- bytecode/ComplexGetStatus.h: Added.
(JSC::ComplexGetStatus::ComplexGetStatus):
(JSC::ComplexGetStatus::skip):
(JSC::ComplexGetStatus::takesSlowPath):
(JSC::ComplexGetStatus::kind):
(JSC::ComplexGetStatus::attributes):
(JSC::ComplexGetStatus::specificValue):
(JSC::ComplexGetStatus::offset):
(JSC::ComplexGetStatus::chain):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::GetByIdVariant):
- bytecode/PolymorphicPutByIdList.h:
(JSC::PutByIdAccess::PutByIdAccess):
(JSC::PutByIdAccess::setter):
(JSC::PutByIdAccess::structure):
(JSC::PutByIdAccess::chainCount):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):
(JSC::PutByIdStatus::makesCalls):
- bytecode/PutByIdStatus.h:
(JSC::PutByIdStatus::makesCalls): Deleted.
- bytecode/PutByIdVariant.cpp:
(JSC::PutByIdVariant::PutByIdVariant):
(JSC::PutByIdVariant::operator=):
(JSC::PutByIdVariant::replace):
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::setter):
(JSC::PutByIdVariant::writesStructures):
(JSC::PutByIdVariant::reallocatesStorage):
(JSC::PutByIdVariant::makesCalls):
(JSC::PutByIdVariant::dumpInContext):
- bytecode/PutByIdVariant.h:
(JSC::PutByIdVariant::PutByIdVariant):
(JSC::PutByIdVariant::structure):
(JSC::PutByIdVariant::oldStructure):
(JSC::PutByIdVariant::alternateBase):
(JSC::PutByIdVariant::specificValue):
(JSC::PutByIdVariant::callLinkStatus):
(JSC::PutByIdVariant::replace): Deleted.
(JSC::PutByIdVariant::transition): Deleted.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCallWithoutSettingResult):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
- jit/Repatch.cpp:
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::takesSlowPathInDFGForImpureProperty):
- runtime/IntendedStructureChain.h:
- tests/stress/exit-from-setter.js: Added.
- tests/stress/poly-chain-setter.js: Added.
(Cons):
(foo):
(test):
- tests/stress/poly-chain-then-setter.js: Added.
(Cons1):
(Cons2):
(foo):
(test):
- tests/stress/poly-setter-combo.js: Added.
(Cons1):
(Cons2):
(foo):
(test):
(.test):
- tests/stress/poly-setter-then-self.js: Added.
(foo):
(test):
(.test):
- tests/stress/weird-setter-counter.js: Added.
(foo):
(test):
- tests/stress/weird-setter-counter-syntactic.js: Added.
(foo):
(test):
- 3:34 PM Changeset in webkit [170671] by
-
- 3 edits in trunk/Source/WebKit2
Use the new legacy session state coding in WKPageCopySessionState
https://bugs.webkit.org/show_bug.cgi?id=134516
Reviewed by Tim Horton.
- UIProcess/API/C/WKPage.cpp:
(WKPageCopySessionState):
Call encodeLegacySessionState.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeSessionHistoryEntryData):
Use leakPtr() so we won't attempt to double-free the buffer.
(WebKit::createDictionary):
Fix a typo.
(WebKit::encodeLegacySessionState):
Don't encode the provisional URL if it's empty.
- 3:25 PM Changeset in webkit [170670] by
-
- 2 edits in trunk/Source/WebKit2
AX: [iOS WebKit2] Support for Speak selection
https://bugs.webkit.org/show_bug.cgi?id=134512
Reviewed by Darin Adler.
Implement a method that Speak Selection can use to retrieve the selected content.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView accessibilityRetrieveSpeakSelectionContent]):
- 3:19 PM Changeset in webkit [170669] by
-
- 2 edits in trunk/Source/WebKit2
Update the highest back-forward list item ID in the other WebBackForwardListItem constructor
https://bugs.webkit.org/show_bug.cgi?id=134515
Reviewed by Tim Horton.
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
- 2:21 PM Changeset in webkit [170668] by
-
- 2 edits in trunk/Source/WebKit2
Fix ServicesOverlayController teardown
<rdar://problem/17523998> and https://bugs.webkit.org/show_bug.cgi?id=134510
Reviewed by Mark Rowe.
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::~ServicesOverlayController): Flipped logic on null-checking the overlay.
- 2:16 PM Changeset in webkit [170667] by
-
- 7 edits in trunk
[Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
<rdar://problem/17523159>
https://bugs.webkit.org/show_bug.cgi?id=134496
Reviewed by Beth Dakin.
Source/WebKit2:
- Adds _automaticallyAdjustsContentInsets SPI to both WKView and WKWebView.
- Defaults _automaticallyAdjustsContentInsets to NO for WKView to keep legacy clients working.
- Defaults _automaticallyAdjustsContentInsets to YES for WKWebView.
- UIProcess/API/Cocoa/WKViewPrivate.h:
Add _automaticallyAdjustsContentInsets SPI.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Default _automaticallyAdjustsContentInsets to YES for WKWebView.
(-[WKWebView _setTopContentInset:]):
(-[WKWebView _topContentInset]):
Change to forward to the WKView, since we now do coalescing and caching there.
(-[WKWebView _setAutomaticallyAdjustsContentInsets:]):
(-[WKWebView _automaticallyAdjustsContentInsets]):
Forward to the WKView.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Add _automaticallyAdjustsContentInsets SPI.
- UIProcess/API/mac/WKView.mm:
(-[WKView renewGState]):
Ensure the contentInset is updated when the view changes, as its relative location to the toolbar may have changed.
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
(-[WKView observeValueForKeyPath:ofObject:change:context:]):
Add observers for the contentLayoutRect and titlebarAppearsTransparent properties on the window. If either of them
change, we need to recalculate the content inset.
(-[WKView _updateContentInsetsIfAutomatic]):
If _automaticallyAdjustsContentInsets is YES, follow the same rules as AppKit in setting the top content inset. Like
AppKit this is only done when:
- The window's style mask has the NSFullSizeContentViewWindowMask bit.
- The window does not have titlebarAppearsTransparent set.
- And we are not in an enclosing NSScrollView.
(-[WKView _setTopContentInset:]):
(-[WKView _topContentInset]):
Coalesce setting the topContentInset to avoid a visual lag when resizing the window that was caused by us sending
multiple topContentInsets to the WebContentProcess per runloop cycle. The reason for the lag was that at the time
we observe the contentLayoutRect changing, our view may not yet be in its final position yet, so the inset will be
temporarily wrong. When the view is finally positioned correctly, we will get a renewGState, at which point we will
again calculate the inset, which now will be correct. Since these both happen in the same runloop iteration, we can
just defer sending the inset to the WebContentProcess.
(-[WKView _setAutomaticallyAdjustsContentInsets:]):
(-[WKView _automaticallyAdjustsContentInsets]):
Add the new SPI.
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController windowDidLoad]):
Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
- 2:13 PM Changeset in webkit [170666] by
-
- 1 delete in trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp.rej
Oops, didn't mean to commit this.
- 2:12 PM Changeset in webkit [170665] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Selected DOM element highlights invisible near bottom of the viewport (topContentInset?)
https://bugs.webkit.org/show_bug.cgi?id=133818
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-01
Reviewed by Beth Dakin.
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
Take the topContentInset into account when sizing the InspectorOverlay's FrameView.
- 2:07 PM Changeset in webkit [170664] by
-
- 6 edits1 add in trunk/Source/WebKit2
Add a function for restoring page state given a SessionState object
https://bugs.webkit.org/show_bug.cgi?id=134509
Reviewed by Tim Horton.
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::itemState):
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::saveState):
- UIProcess/WebBackForwardList.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::saveState):
- UIProcess/WebPageProxy.h:
- 1:45 PM Changeset in webkit [170663] by
-
- 7 edits in trunk
[CMake] Add necessary support for building for the Wayland target
https://bugs.webkit.org/show_bug.cgi?id=134160
Reviewed by Darin Adler.
.:
- Source/cmake/FindGTK3.cmake: Check for the gtk+-x11-3.0 package if the X11 target
is enabled, and that its version matches the version of the generic package. Same
for the gtk+-wayland-3.0 package and the Wayland target.
- Source/cmake/OptionsCommon.cmake: Don't add the -DXP_UNIX definition here.
- Source/cmake/OptionsEfl.cmake: Add -DXP_UNIX here for the EFL port, under the same
condition as in OptionsCommon.cmake. ENABLE_X11_TARGET is enabled by default for EFL
so they keep building the TestNetscapePlugin target.
- Source/cmake/OptionsGTK.cmake: Enable the X11 target and disable the Wayland target
by default. Group all the X11-specific macro definitions (WTF_PLATFORM_X11, MOZ_X11,
XP_UNIX) and only add them if the X11 target is enabled. Similar goes for the Wayland
target and WTF_PLATFORM_WAYLAND. The Wayland target requires GTK+ 3.12.0, so that's
the minimum required version as soon as that target is enabled. Only search for GLX
if the X11 target is enabled.
Tools:
- CMakeLists.txt: Only build the TestNetscapePlugIn target in case
the X11 windowing target is enabled.
- 1:38 PM Changeset in webkit [170662] by
-
- 2 edits in trunk/Source/WebKit2
Followup for: Combine the Telephone and Selection overlay controllers, updating UI behavior.
https://bugs.webkit.org/show_bug.cgi?id=134461
Rubberstamped by Tim Horton.
- WebProcess/WebPage/mac/ServicesOverlayController.mm: Include the correct constant.
- 1:29 PM Changeset in webkit [170661] by
-
- 8 edits1 copy in trunk
AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
https://bugs.webkit.org/show_bug.cgi?id=134492
Reviewed by Andreas Kling.
Source/WebCore:
Support the indeterminate attribute in AX code.
Test: Update existing test: accessibility/aria-checked-mixed-value
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::checkboxOrRadioValue):
Tools:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isIndeterminate):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::isIndeterminate):
LayoutTests:
- accessibility/aria-checked-mixed-value-expected.txt:
- accessibility/aria-checked-mixed-value.html:
- platform/mac/accessibility/aria-checked-mixed-value-expected.txt: Added.
- 1:22 PM Changeset in webkit [170660] by
-
- 21 edits in trunk/Source/WebKit2
[Cocoa] Navigation parameter in navigation delegate messages is nil for navigations started by the Web Content process
https://bugs.webkit.org/show_bug.cgi?id=134482
Reviewed by Tim Horton.
- UIProcess/API/APILoaderClient.h:
(API::LoaderClient::didDestroyNavigation): New client function, called when a navigation ID
is not going to be used anymore.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _restoreFromSessionState:]): If restoring triggered a navigation, create a
WKNavigation for its ID.
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::createLoadRequestNavigation): Removed FIXME, because we now remove
navigations from the map in LoaderClient::didDestroyNavigation.
(WebKit::NavigationState::createBackForwardNavigation): Ditto.
(WebKit::NavigationState::createReloadNavigation): Ditto.
(WebKit::NavigationState::createLoadDataNavigation): Ditto.
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction): If we are only
getting a navigation ID now, create a WKNavigation for it. Also changed to create the
NSURLRequest lazily.
(WebKit::NavigationState::LoaderClient::didStartProvisionalLoadForFrame): Assert that
navigationID is not zero and that it maps to an existing WKNavigation.
(WebKit::NavigationState::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
Ditto.
(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame): Ditto.
(WebKit::NavigationState::LoaderClient::didCommitLoadForFrame): Ditto.
(WebKit::NavigationState::LoaderClient::didFinishDocumentLoadForFrame): Ditto.
(WebKit::NavigationState::LoaderClient::didFinishLoadForFrame): Ditto.
(WebKit::NavigationState::LoaderClient::didFailLoadWithErrorForFrame): Ditto.
(WebKit::NavigationState::LoaderClient::didDestroyNavigation): Override the new client
function to remove the navigation from the map.
(WebKit::NavigationState::LoaderClient::processDidCrash): Clear the navigations map.
- UIProcess/WebFrameListenerProxy.cpp:
(WebKit::WebFrameListenerProxy::WebFrameListenerProxy): Initialize new m_navigationID
member variable.
(WebKit::WebFrameListenerProxy::receivedPolicyDecision): Pass the navigation ID to
WebFrame::receivedPolicyDecision.
- UIProcess/WebFrameListenerProxy.h:
(WebKit::WebFrameListenerProxy::navigationID): Added this accessor.
(WebKit::WebFrameListenerProxy::setNavigationID): Ditto.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::receivedPolicyDecision): Added navigationID parameter, which is
passed along to the WebPageProxy.
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision): Added navigationID parameter, which is
passed along in the message to the Web Content process.
(WebKit::WebPageProxy::restoreFromSessionStateData): Changed to return a navigation ID of 0.
(WebKit::WebPageProxy::restoreFromState): Changed to return a navigation ID if one was
started.
(WebKit::WebPageProxy::didDestroyNavigation): Added. Calls the new client function.
(WebKit::WebPageProxy::decidePolicyForNavigationAction): Added navigationID and
newNavigationID parameters. If a main-frame navigation doesn’t already have an ID, assign it
a new ID and return it in the newNavigationID parmeter as well as setting it on the listener
for the asynchronous case.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Added navigationID and newNavigationID parameters.
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData): Changed to return a navigation ID if
one was started.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse): Updated for additional
parameter.
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Send the navigation
ID to the UI process, get the new navigation ID from the reply, and set it on the document
loader.
- WebProcess/WebPage/WebDocumentLoader.cpp:
(WebKit::WebDocumentLoader::detachFromFrame): Override to let the UI process know that the
navigation ID will not be used anymore.
- WebProcess/WebPage/WebDocumentLoader.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::didReceivePolicyDecision): Added navigationID parameter, set it on the
document loader.
(WebKit::WebFrame::documentLoaderDetached): Pass the message along to the UI process.
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceivePolicyDecision): Pass new navigationID parameter along.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Added navigationID parameter.
- 12:43 PM Changeset in webkit [170659] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- WebKit2.xcodeproj/project.pbxproj:
- 12:42 PM Changeset in webkit [170658] by
-
- 2 edits in trunk/Source/WebKit2
Temporarily encode and decode the snapshot UUID
https://bugs.webkit.org/show_bug.cgi?id=134507
Reviewed by Tim Horton.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeSessionHistory):
(WebKit::decodeSessionHistoryEntry):
(WebKit::decodeSessionHistoryEntries):
- 12:34 PM Changeset in webkit [170657] by
-
- 3 edits in trunk/Source/WebKit2
Implement encodeSessionHistoryEntryData
https://bugs.webkit.org/show_bug.cgi?id=134505
Reviewed by Tim Horton.
- UIProcess/API/C/WKPage.cpp:
(WKPageCopySessionState):
Add back a missing null check for the filter pointer.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeSessionHistoryEntryData):
- 12:15 PM Changeset in webkit [170656] by
-
- 7 edits2 adds in trunk
[UI-side compositing] Bad spinner on news.google.com: animations need to be ordered
https://bugs.webkit.org/show_bug.cgi?id=134504
<rdar://problem/17507892>
Reviewed by Tim Horton.
Source/WebKit2:
The layer's addedAnimations property needs to maintain order, since the order
in which transforms are applied is important.
- Shared/mac/RemoteLayerTreeTransaction.h: Use a Vector<pair<>> for addedAnimations.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::dumpChangedLayers):
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
(WebKit::PlatformCAAnimationRemote::updateLayerAnimations):
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::addAnimationForKey): If this is a new entry, we
can just append to addedAnimations, otherwise we have to find the existing one
and update its properties.
(WebKit::PlatformCALayerRemote::removeAnimationForKey): Do linear search to
find the animation to remove (this list will normally be short).
LayoutTests:
Test that the transforms from the animation are applied in the correct order.
- compositing/animation/keyframe-order-expected.html: Added.
- compositing/animation/keyframe-order.html: Added.
- 12:10 PM Changeset in webkit [170655] by
-
- 2 edits in trunk/Source/WebCore
Typing an automatic text replacement phrase after a br in contenteditable is not rendered as expected
https://bugs.webkit.org/show_bug.cgi?id=133883
Reviewed by Enrica Casucci.
enclosingDeletableElement() makes sure that the element's container is editable, but not
that it is capable of having content inside it (like how a <br> can't).
No new tests. I don't think this is testable because it requires setting some state in System Preferences.
- editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
- 12:04 PM Changeset in webkit [170654] by
-
- 3 edits in trunk/Source/WebKit2
Add a encodeLegacySessionState function
https://bugs.webkit.org/show_bug.cgi?id=134502
Reviewed by Tim Horton.
- UIProcess/LegacySessionStateCoding.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeSessionHistoryEntryData):
(WebKit::encodeLegacySessionHistoryEntryData):
(WebKit::createDictionary):
(WebKit::encodeSessionHistory):
(WebKit::encodeLegacySessionState):
- 11:41 AM Changeset in webkit [170653] by
-
- 9 edits in trunk/Source/WebKit2
[Cocoa] WebProcess doesn't follow localization of UI process when run as a service
https://bugs.webkit.org/show_bug.cgi?id=133126
<rdar://problem/13396515>
Patch by Alexey Proskuryakov.
Reviewed by Tim Horton.
- Configurations/WebContentService.Development.xcconfig:
- Configurations/WebContentService.xcconfig:
Figure out which of the two keys to use. CFBundleAllowMixedLocalizations was
a workaround before we got CFBundleFollowParentLocalization, and these cannot be
used together.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::connectToService): Set up
XPC bootstrap for CFBundle to use.
- WebKit2.xcodeproj/project.pbxproj: Added a script that applies the key to Info.plist.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:
Removed CFBundleAllowMixedLocalizations, we now add it programmatically.
- 11:29 AM Changeset in webkit [170652] by
-
- 6 edits in trunk/Source
[iOS] Unreviewed build fix after r170640.
Source/WebCore:
- page/EditorClient.h:
(WebCore::EditorClient::selectedTelephoneNumberRangesChanged):
Add ifdefs to make everything compile and link.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::selectedTelephoneNumberRangesChanged):
(WebKit::WebEditorClient::selectionRectsDidChange):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebPage/WebPage.h:
Add ifdefs to make everything compile and link.
- 11:00 AM Changeset in webkit [170651] by
-
- 3 edits in trunk/Source/WebKit2
Add WKSessionStateGetTypeID
https://bugs.webkit.org/show_bug.cgi?id=134499
Reviewed by Tim Horton.
- UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateGetTypeID):
- UIProcess/API/C/WKSessionStateRef.h:
- 10:49 AM Changeset in webkit [170650] by
-
- 13 edits in trunk
Remove unnecessary calls to std::move()
https://bugs.webkit.org/show_bug.cgi?id=134493
Reviewed by Anders Carlsson.
Source/WebCore:
- Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::CDM):
- css/CSSGrammar.y.in:
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::formatNumberValue):
- css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect):
Source/WebKit2:
- Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::tryWrapInCFData):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::certificateInfo): Return a WebCore::CertificateInfo instead
of const WebCore::CertificateInfo& to avoid returning a dangling reference to
a local variable. Also, remove the unnecessary calls to std::move() as the compiler
will invoke the move constructor for WebCore::CertificateInfo on return from the
function.
- WebProcess/WebPage/WebFrame.h:
Tools:
- TestWebKitAPI/Tests/WTF/HashSet.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
(TestWebKitAPI::TEST):
- 10:46 AM Changeset in webkit [170649] by
-
- 8 edits in trunk/Source/WebKit2
Add a BackForwardListItemState struct and put the snapshot UUID there
https://bugs.webkit.org/show_bug.cgi?id=134497
Reviewed by Sam Weinig.
- Shared/SessionState.cpp:
(WebKit::PageState::encode):
(WebKit::PageState::decode):
(WebKit::BackForwardListItemState::encode):
(WebKit::BackForwardListItemState::decode):
- Shared/SessionState.h:
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::backForwardData):
(WebKit::WebBackForwardListItem::setBackForwardData):
(WebKit::WebBackForwardListItem::encode):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::setPageState):
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::originalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::url):
(WebKit::WebBackForwardListItem::setTitle):
(WebKit::WebBackForwardListItem::title):
(WebKit::WebBackForwardListItem::setSnapshotUUID):
(WebKit::WebBackForwardListItem::snapshotUUID):
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::restoreFromState):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeSessionHistoryEntries):
- 10:33 AM Changeset in webkit [170648] by
-
- 2 edits in trunk/Source/WebKit/ios
[iOS] Compile fix with pointer lock enabled.
https://bugs.webkit.org/show_bug.cgi?id=134472
Reviewed by Pratik Solanki.
- WebView/WebPDFViewPlaceholder.mm:
(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
Add parameters required for pointer lock.
- 10:29 AM Changeset in webkit [170647] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself to the reviewers list to make commit bot happy.
- Scripts/webkitpy/common/config/contributors.json:
- 10:25 AM Changeset in webkit [170646] by
-
- 3 edits2 adds in trunk
Subpixel rendering: Pixel crack in breadcrumbs at devforums.apple.com.
https://bugs.webkit.org/show_bug.cgi?id=134491
Reviewed by Simon Fraser.
Do not early round geometry values, while computing background image position. It changes the final
subpixel values and that could lead to wrong snap positions.
pixelSnapBackgroundImageGeometryForPainting() takes care of geometry snapping.
Source/WebCore:
Test: fast/backgrounds/background-image-size-double-rounding.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
LayoutTests:
- fast/backgrounds/background-image-size-double-rounding-expected.html: Added.
- fast/backgrounds/background-image-size-double-rounding.html: Added.
- 10:14 AM Changeset in webkit [170645] by
-
- 2 edits in trunk/Source/WebKit2
Add encodeInteger and decodeInteger for remote object encoder and decoder.
https://bugs.webkit.org/show_bug.cgi?id=134453
In 64bit system, encodeInteger/decodeInteger is by default mapped into encodeInt64/decodeInt64. For
32bit system, they are mapped to encodeInt32/decodeInt32. However, since we don't have encodeInt32/decodeInt32
implementation in WKRemoteObjectCoder, we could hit crash in 32bit systems.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-07-01
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder encodeInteger:forKey:]): Instead of creating a new number type UInt32, use encodeInt64 for
encoding NSInteger.
(-[WKRemoteObjectDecoder decodeIntegerForKey:]):
- 10:04 AM Changeset in webkit [170644] by
-
- 8 edits in trunk/Source/WebKit2
Use an std::function for filtering session state data
https://bugs.webkit.org/show_bug.cgi?id=134481
Reviewed by Sam Weinig.
- UIProcess/API/C/WKPage.cpp:
(WKPageCopySessionState):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _sessionState]):
- UIProcess/WebBackForwardList.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sessionStateData):
- UIProcess/WebPageProxy.h:
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData):
- 9:59 AM Changeset in webkit [170643] by
-
- 2 edits in trunk/Source/WebKit2
Clean up the WebKit build from unused parameter warning in Webkit2/UIProcess module
https://bugs.webkit.org/show_bug.cgi?id=134294
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-07-01
Reviewed by Darin Adler.
- UIProcess/API/APIUIClient.h:
(API::UIClient::reachedApplicationCacheOriginQuota):
- 9:45 AM Changeset in webkit [170642] by
-
- 4 edits in trunk/Source/WebCore
Create NSURLRequest lazily when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=134441
Reviewed by Andreas Kling.
No new tests. Should be covered by existing tests.
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::encodingRequiresPlatformData):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::nsURLRequest):
- 9:43 AM Changeset in webkit [170641] by
-
- 2 edits in trunk/Source/WebKit2
Build fix.
Forgot to commit locally before pushing.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::servicesOverlayController): s/this/*this/
- 9:22 AM Changeset in webkit [170640] by
-
- 9 edits1 move1 add5 deletes in trunk/Source
Combine the Telephone and Selection overlay controllers, updating UI behavior.
https://bugs.webkit.org/show_bug.cgi?id=134461
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.exp.in:
- dom/Range.cpp:
(WebCore::Range::contains): Returns true if the Range completely contains the passed-in Range.
- dom/Range.h:
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::selectedTelephoneNumberRangesChanged):
(WebKit::WebEditorClient::selectionRectsDidChange):
Remove the separate Selection overlay controller:
- WebProcess/WebPage/SelectionOverlayController.cpp: Removed.
- WebProcess/WebPage/ServicesOverlayController.h: Renamed from Source/WebKit2/WebProcess/WebPage/SelectionOverlayController.h.
(WebKit::ServicesOverlayController::create):
- WebProcess/WebPage/mac/SelectionOverlayControllerMac.mm: Removed.
Remove the separate TelephoneNumber overlay controller:
- WebProcess/WebPage/TelephoneNumberOverlayController.cpp: Removed.
- WebProcess/WebPage/TelephoneNumberOverlayController.h: Removed.
- WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm: Removed.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::servicesOverlayController):
(WebKit::WebPage::telephoneNumberOverlayController): Deleted.
(WebKit::WebPage::selectionOverlayController): Deleted.
(WebKit::WebPage::didChangeScrollOffsetForFrame): Deleted.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::serviceControlsEnabled): Deleted.
ServicesOverlayController is a combination of the old TelephoneNumber and Selection overlay controllers.
A lot of code duplication is resolved, and things are generally easier to follow.
It enforces displaying a telephone number highlight if precisely one telephone number is selected, or
the selection highlight if the selection contains more than a single phone number
- WebProcess/WebPage/mac/ServicesOverlayController.mm: Added.
(WebKit::textQuadsToBoundingRectForRange):
(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::destroyOverlay):
(WebKit::ServicesOverlayController::pageOverlayDestroyed):
(WebKit::ServicesOverlayController::willMoveToWebPage):
(WebKit::ServicesOverlayController::didMoveToWebPage):
(WebKit::ServicesOverlayController::createOverlayIfNeeded):
(WebKit::ServicesOverlayController::selectionRectsDidChange):
(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
(WebKit::ServicesOverlayController::clearHighlightState):
(WebKit::ServicesOverlayController::drawRect):
(WebKit::ServicesOverlayController::drawSelectionHighlight):
(WebKit::ServicesOverlayController::drawTelephoneNumberHighlight):
(WebKit::ServicesOverlayController::drawCurrentHighlight):
(WebKit::ServicesOverlayController::mouseEvent):
(WebKit::ServicesOverlayController::handleClick):
- 8:22 AM Changeset in webkit [170639] by
-
- 2 edits in trunk/Tools
webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
https://bugs.webkit.org/show_bug.cgi?id=40095
Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-07-01
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
(Bugzilla):
(Bugzilla.bug_id_for_attachment_id): ditto.
- 8:16 AM Changeset in webkit [170638] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION(160908): vube.com video won't play after going into and out of fullscreen
https://bugs.webkit.org/show_bug.cgi?id=134489
Reviewed by Zalan Bujtas.
Test: fullscreen/full-screen-plugin.html
It is difficult to restore the render tree correctly in all cases after removing a full screen
renderer from the tree. r160908 avoided dealing with this by simply always reconstructing the subtree.
Unfortunately plugin lifetime is currently tied to its renderer so this would cause the plugin to restart.
With this patch we avoid reconstruction in normal cases and only force it if the render tree is complicated.
- dom/Document.cpp:
(WebCore::unwrapFullScreenRenderer):
Force reconstruction conditionally.
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
- rendering/RenderFullScreen.cpp:
(WebCore::RenderFullScreen::wrapRenderer):
(WebCore::RenderFullScreen::unwrapRenderer):
Deal with the simple case of single child, possibly in anonymous wrapper.
In other cases request reconstruction.
This is covered by the existing fullscreen tests.
- rendering/RenderFullScreen.h:
- 6:10 AM Changeset in webkit [170637] by
-
- 19 edits in trunk/Tools
[webkitpy] Refactor pluralizer in grammar.py
https://bugs.webkit.org/show_bug.cgi?id=133067
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-07-01
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
(Printer.print_workers_and_shards):
(Printer._print_one_line_summary):
- Scripts/webkitpy/test/printer.py:
(Printer.print_result):
- Scripts/webkitpy/tool/bot/feeders.py:
(EWSFeeder.feed):
- Scripts/webkitpy/tool/bot/flakytestreporter.py:
(FlakyTestReporter._lookup_bug_for_flaky_test):
- Scripts/webkitpy/tool/bot/irc_command.py:
(Rollout._check_diff_failure):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_rollout):
- Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchProcessingCommand._process_patch.execute):
(ProcessBugsMixin._fetch_list_of_patches_to_process):
(ProcessURLsMixin._fetch_list_of_patches_to_process):
- Scripts/webkitpy/tool/commands/queries.py:
(WhatBroke.execute):
- Scripts/webkitpy/tool/commands/suggestnominations.py:
(SuggestNominations._print_nominations):
(SuggestNominations._print_counts):
- Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
(_make_options):
(test_basic):
(test_with_verbose):
- Scripts/webkitpy/tool/commands/upload.py:
(PostCommits.execute):
- Scripts/webkitpy/tool/grammar.py:
(pluralize):
- Scripts/webkitpy/tool/grammar_unittest.py:
(GrammarTest.test_join_with_separators):
(GrammarTest):
(GrammarTest.test_plural):
(GrammarTest.test_pluralize):
- Scripts/webkitpy/tool/multicommandtool.py:
(Command.check_arguments_and_execute):
- Scripts/webkitpy/tool/steps/obsoletepatches.py:
(ObsoletePatches.run):
- Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
(PrepareChangeLogForRevert._message_for_revert):
- 5:07 AM WebKitGTK/2.4.x edited by
- (diff)
- 5:07 AM Changeset in webkit [170636] by
-
- 14 edits2 adds in releases/WebKitGTK/webkit-2.4
Merge r169799 - [GTK] Use a different user agent string depending on the site
https://bugs.webkit.org/show_bug.cgi?id=132681
Reviewed by Anders Carlsson.
Source/WebCore:
We have changed the user agent string several times to try to fix
broken websites that require specific things in the UA string to
properly work. But everytime we change the UA string to fix a
website we break others. We could use different UA string
depending on the website. UserAgentGtk code has also been cleaned
up, using NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL
and avoiding unneeded conversions to UTF-8.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::UserAgentQuirks::UserAgentQuirks): New helper private
class to handle user agent quirks.
(WebCore::UserAgentQuirks::add):
(WebCore::UserAgentQuirks::contains):
(WebCore::UserAgentQuirks::isEmpty):
(WebCore::platformForUAString): Bring back this method that was
removed to always pretend to be Macintosh.
(WebCore::platformVersionForUAString): Return a different platform
version depending on the actual platform.
(WebCore::versionForUAString): Return the WebKit version.
(WebCore::buildUserAgentString): Helper function to build the user
agent taking into account the UserAgentQuirks received.
(WebCore::standardUserAgentStatic): Standard user agent string
when no quirks are present.
(WebCore::standardUserAgent):
(WebCore::standardUserAgentForURL): New method that returns the
user agent string for the given URL.
- platform/gtk/UserAgentGtk.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_class_init): Enable site specific quirks setting
by default.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::userAgent): Pass the given URL to WebPage.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::userAgent): Try to get the user agent for the
URL received falling back to the current one otherwise.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::platformUserAgent): Added.
- WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::platformUserAgent): Return null String.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformUserAgent): Use WebCore::standardUserAgentForURL() when site specific quirks
setting is enabled.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformUserAgent): Return null String.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformUserAgent): Return null String.
Tools:
Add a unit test to check user agent quirks.
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
(testWebKitSettings): Site specific quirks setting is now enabled
by default.
- 4:32 AM Changeset in webkit [170635] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] IPC messages' arguments() method returns const std::tuple<> copies
https://bugs.webkit.org/show_bug.cgi?id=131975
Reviewed by Darin Adler.
The arguments() method of the different IPC message objects should return a const reference
to the std::tuple<> containing the arguments, instead of a const value. This avoids copying
the std::tuple<> every time the arguments are encoded, and works best with the
ArgumentEncoder::encode<std::tuple<...>>(const std::tuple<...>&) template instantiation.
The unit test baselines are updated accordingly.
- Scripts/webkit2/LegacyMessages-expected.h:
(Messages::WebPage::LoadURL::arguments):
(Messages::WebPage::LoadSomething::arguments):
(Messages::WebPage::TouchEvent::arguments):
(Messages::WebPage::AddEvent::arguments):
(Messages::WebPage::LoadSomethingElse::arguments):
(Messages::WebPage::DidReceivePolicyDecision::arguments):
(Messages::WebPage::Close::arguments):
(Messages::WebPage::PreferencesDidChange::arguments):
(Messages::WebPage::SendDoubleAndFloat::arguments):
(Messages::WebPage::SendInts::arguments):
(Messages::WebPage::CreatePlugin::arguments):
(Messages::WebPage::RunJavaScriptAlert::arguments):
(Messages::WebPage::GetPlugins::arguments):
(Messages::WebPage::GetPluginProcessConnection::arguments):
(Messages::WebPage::TestMultipleAttributes::arguments):
(Messages::WebPage::TestParameterAttributes::arguments):
(Messages::WebPage::TemplateTest::arguments):
(Messages::WebPage::SetVideoLayerID::arguments):
(Messages::WebPage::DidCreateWebProcessConnection::arguments):
(Messages::WebPage::InterpretKeyEvent::arguments):
(Messages::WebPage::DeprecatedOperation::arguments):
(Messages::WebPage::ExperimentalOperation::arguments):
- Scripts/webkit2/Messages-expected.h:
(Messages::WebPage::LoadURL::arguments):
(Messages::WebPage::LoadSomething::arguments):
(Messages::WebPage::TouchEvent::arguments):
(Messages::WebPage::AddEvent::arguments):
(Messages::WebPage::LoadSomethingElse::arguments):
(Messages::WebPage::DidReceivePolicyDecision::arguments):
(Messages::WebPage::Close::arguments):
(Messages::WebPage::PreferencesDidChange::arguments):
(Messages::WebPage::SendDoubleAndFloat::arguments):
(Messages::WebPage::SendInts::arguments):
(Messages::WebPage::CreatePlugin::arguments):
(Messages::WebPage::RunJavaScriptAlert::arguments):
(Messages::WebPage::GetPlugins::arguments):
(Messages::WebPage::GetPluginProcessConnection::arguments):
(Messages::WebPage::TestMultipleAttributes::arguments):
(Messages::WebPage::TestParameterAttributes::arguments):
(Messages::WebPage::TemplateTest::arguments):
(Messages::WebPage::SetVideoLayerID::arguments):
(Messages::WebPage::DidCreateWebProcessConnection::arguments):
(Messages::WebPage::InterpretKeyEvent::arguments):
(Messages::WebPage::DeprecatedOperation::arguments):
(Messages::WebPage::ExperimentalOperation::arguments):
- Scripts/webkit2/MessagesSuperclass-expected.h:
(Messages::WebPage::LoadURL::arguments):
- Scripts/webkit2/messages.py:
(message_to_struct_declaration):
- 4:29 AM Changeset in webkit [170634] by
-
- 5 edits in trunk/Source/WebCore
Remove remaining Vector<> copies in WebCore accessibility code
https://bugs.webkit.org/show_bug.cgi?id=133263
Reviewed by Darin Adler.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::notificationPostTimerFired): Don't copy the Vector member and
then clear it -- move it into the local variable instead.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::ariaLabeledByText): Move the axElements Vector into
the AccessibilityText constructor.
(WebCore::AccessibilityNodeObject::stringValue): Create a const reference to the Vector of
HTMLSelectElement's list items instead of copying it.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityText::AccessibilityText): Take the Vector parameter by non-const
value and move it into the member variable.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue): Create a const reference to the Vector
of HTMLSelectElement's list items instead of copying it.
(WebCore::AccessibilityRenderObject::ariaSelectedRows): Wrap the AccessibilityChildrenVector
iteration in a lambda. Use it to iterate over either the newly-constructed Vector (in case
the object has the tree role) or the reference to the vector returned by
AccessibilityTable::rows() (in case the object is an AccessibilityTable instance).
- 2:10 AM Changeset in webkit [170633] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Annotations for WebResource.get_data produce wrong signature in Vala binding
https://bugs.webkit.org/show_bug.cgi?id=134476
Patch by Evan Nemerson <evan@nemerson.com> on 2014-07-01
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitWebResource.cpp: Add array length and
element-type annotations to return value of webkit_web_resource_get_data_finish().
- 1:17 AM Changeset in webkit [170632] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Can not convert ‘sessionState.WebKit::SessionState::provisionalURL’ from ‘WebCore::URL’ to ‘bool’
https://bugs.webkit.org/show_bug.cgi?id=134487
Rubber-stamped by Carlos Garcia Campos.
- UIProcess/WebPageProxy.cpp: Use isNull().
(WebKit::WebPageProxy::restoreFromState):
- 12:57 AM Changeset in webkit [170631] by
-
- 3 edits1 copy1 move in trunk/Source/WebKit2
Fix build break on EFL and GTK ports since r170611 and r170614
https://bugs.webkit.org/show_bug.cgi?id=134479
Reviewed by Carlos Garcia Campos.
Add LegacySessionStateCodingNone.cpp in order to fix build break on EFL and GTK ports. Additionally
SessionStateConversion.cpp is added to CMakeLists.txt as well.
- CMakeLists.txt:
- UIProcess/LegacySessionStateCoding.h: Copied from Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.h.
- UIProcess/LegacySessionStateCodingNone.cpp: Renamed from Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.h.
(WebKit::encodeLegacySessionHistoryEntryData):
(WebKit::decodeLegacySessionState):
(WebKit::decodeLegacySessionHistoryEntryData):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::restoreFromState):
- WebKit2.xcodeproj/project.pbxproj:
Jun 30, 2014:
- 9:16 PM Changeset in webkit [170630] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r170605.
https://bugs.webkit.org/show_bug.cgi?id=134484
The changes cause crashes on ARM64 (Requested by benjaminp on
#webkit).
Reverted changeset:
"Reduce dynamic memory allocation in css jit."
https://bugs.webkit.org/show_bug.cgi?id=134416
http://trac.webkit.org/changeset/170605
- 8:12 PM Changeset in webkit [170629] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] The long press gesture recognizers should not block the pinch gesture
https://bugs.webkit.org/show_bug.cgi?id=134477
<rdar://problem/17514936>
Reviewed by Tim Horton.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:canPreventGestureRecognizer:]):
- 7:19 PM Changeset in webkit [170628] by
-
- 8 edits21 adds in branches/ftlopt
Merge r169121 from trunk.
2014-05-19 Mark Hahnenberg <mhahnenberg@apple.com>
JSArray::shiftCountWith* could be more efficient
https://bugs.webkit.org/show_bug.cgi?id=133011
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Our current implementations of shiftCountWithAnyIndexingType and shiftCountWithArrayStorage
are scared of the presence of any holes in the array. We can mitigate this somewhat by enabling
them to correctly handle holes, thus avoiding the slowest of slow paths in most cases.
- runtime/ArrayStorage.h: (JSC::ArrayStorage::indexingHeader): (JSC::ArrayStorage::length): (JSC::ArrayStorage::hasHoles):
- runtime/IndexingHeader.h: (JSC::IndexingHeader::publicLength): (JSC::IndexingHeader::from):
- runtime/JSArray.cpp: (JSC::JSArray::shiftCountWithArrayStorage): (JSC::JSArray::shiftCountWithAnyIndexingType): (JSC::JSArray::unshiftCountWithArrayStorage):
- runtime/JSArray.h: (JSC::JSArray::shiftCountForShift): (JSC::JSArray::shiftCountForSplice): (JSC::JSArray::shiftCount):
- runtime/Structure.cpp: (JSC::Structure::holesRequireSpecialBehavior):
- runtime/Structure.h:
LayoutTests:
Added a performance regression test which tests the contiguous shift case. We're ~85% faster
on this microbenchmark with this patch.
Also added a bunch of tests for each permutation of contiguous/array storage with no holes, holes,
and holes that require special behavior (e.g. indexed properties in the prototype chain).
- js/array-storage-splice-holes-expected.txt: Added.
- js/array-storage-splice-holes-require-special-behavior-expected.txt: Added.
- js/array-storage-splice-holes-require-special-behavior.html: Added.
- js/array-storage-splice-holes.html: Added.
- js/array-storage-splice-no-holes-expected.txt: Added.
- js/array-storage-splice-no-holes.html: Added.
- js/contiguous-splice-holes-expected.txt: Added.
- js/contiguous-splice-holes-require-special-behavior-expected.txt: Added.
- js/contiguous-splice-holes-require-special-behavior.html: Added.
- js/contiguous-splice-holes.html: Added.
- js/contiguous-splice-no-holes-expected.txt: Added.
- js/contiguous-splice-no-holes.html: Added.
- js/regress/array-splice-contiguous-expected.txt: Added.
- js/regress/array-splice-contiguous.html: Added.
- js/regress/script-tests/array-splice-contiguous.js: Added. (foo):
- js/script-tests/array-storage-splice-holes-require-special-behavior.js: Added.
- js/script-tests/array-storage-splice-holes.js: Added.
- js/script-tests/array-storage-splice-no-holes.js: Added.
- js/script-tests/contiguous-splice-holes-require-special-behavior.js: Added.
- js/script-tests/contiguous-splice-holes.js: Added.
- js/script-tests/contiguous-splice-no-holes.js: Added.
- 6:40 PM Changeset in webkit [170627] by
-
- 3 edits in trunk/Source/WebKit2
Add WebPageProxy::restoreFromState
https://bugs.webkit.org/show_bug.cgi?id=134480
Reviewed by Tim Horton.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromState):
- UIProcess/WebPageProxy.h:
- 6:29 PM Changeset in webkit [170626] by
-
- 4 edits in trunk/Source/WebKit2
Add a function to restore a WebBackForwardList object from a BackForwardListState object
https://bugs.webkit.org/show_bug.cgi?id=134478
Reviewed by Tim Horton.
- UIProcess/WebBackForwardList.cpp:
(WebKit::generateWebBackForwardItemID):
(WebKit::WebBackForwardList::restoreFromState):
- UIProcess/WebBackForwardList.h:
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::generateWebBackForwardItemID): Deleted.
- 6:06 PM Changeset in webkit [170625] by
-
- 10 edits in trunk/Source
Change the AddBackForwardItem message to take a page state object
https://bugs.webkit.org/show_bug.cgi?id=134475
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::setPageState):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
- 5:50 PM Changeset in webkit [170624] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Add a flatter find-in-page current match indicator style
https://bugs.webkit.org/show_bug.cgi?id=134434
<rdar://problem/16225673>
Reviewed by Simon Fraser.
- UIProcess/FindIndicator.cpp:
(WebKit::findIndicatorsForTextRectsOverlap):
(WebKit::FindIndicator::frameRect):
(WebKit::flatHighlightColor):
(WebKit::flatRimShadowColor):
(WebKit::flatDropShadowColor):
(WebKit::FindIndicator::draw):
Add a flatter find indicator, with a bigger shadow.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::getFindIndicatorBitmapAndRect):
(WebKit::FindController::hideFindIndicator):
(WebKit::FindController::drawRect):
Don't paint a shadow behind the secondary matches if we're using the new style.
- 5:45 PM Changeset in webkit [170623] by
-
- 3 edits in trunk/Tools
[iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=134133
Reviewed by Simon Fraser.
Replace it with CTFontManagerRegisterGraphicsFont
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontIOS):
- 5:42 PM Changeset in webkit [170622] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Improve double-tap-to-scroll on image documents
https://bugs.webkit.org/show_bug.cgi?id=134474
<rdar://problem/17496778>
Reviewed by Enrica Casucci.
On image document, we were always rendering the center of the image as the origin, which broke
double tap to scroll.
This patch improves on this in two ways:
1) If the hit testing already got the image, only change the type to replaced (to get the right
scaling behavior for images since the type is block on iOS's image document).
2) If the hit testing is outside the image, only center the axis that is not in the image.
This way, we "fix" the component that is not valid, and keep the vali component.
This works great for viewing comics on iPad.
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
- 5:38 PM Changeset in webkit [170621] by
-
- 2 edits in trunk/Source/WebCore
[iOS][WK2] Do not put tap highlight on images that are not in links, and on applet/embed/object
https://bugs.webkit.org/show_bug.cgi?id=134471
<rdar://problem/17513542>
Reviewed by Enrica Casucci.
UIKit has some special code to avoid tap highlight on certain type of object. This is not very flexible
since the page has no way of overriding that behavior.
This patch implement the same feature by changing the default stylesheet. The tap highlight is disabled
by default for those object, and enabled for images that are in a link.
- css/html.css:
(applet, embed, object, img):
(:-webkit-any-link img):
- 5:27 PM Changeset in webkit [170620] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (WK2): Weird selection behavior on autos.yahoo.com, en.wikipedia.org.
https://bugs.webkit.org/show_bug.cgi?id=134466
<rdar://problem/16817263>
Reviewed by Benjamin Poulain.
Avoid selecting blocks across frame boundaries and skip non-selectable
blocks. If the only block we find is almost the same height as the
visible area, we should not select at all.
This patch also fixes the logic to compute the next block when
shrinking the selection. When calculating the new range after shrinking,
we should not include the block that corresponds to the current handle position.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::expandedRangeFromHandle):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::updateSelectionWithTouches):
- 5:17 PM Changeset in webkit [170619] by
-
- 3 edits4 adds in trunk
All Indic text is rendered as boxes on iOS
https://bugs.webkit.org/show_bug.cgi?id=134464
Reviewed by Simon Fraser.
Source/WebCore:
I made a typo in r170207.
Test: fast/text/indic.html
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
LayoutTests:
Simply draw some indic text and test that against currently good metric values.
- fast/text/indic.html: Added
- platform/ios-sim/fast/text/indic-expected.txt: Added.
- platform/mac/fast/text/indic-expected.txt: Added.
- platform/mac/fast/text/indic-expected.png: Added.
- 5:14 PM Changeset in webkit [170618] by
-
- 2 edits in trunk/Source/WebCore
[iOS] languageSpecificFallbackFont() is not consistent
https://bugs.webkit.org/show_bug.cgi?id=134473
Reviewed by Darin Adler.
It can use "<" throughout the function as well as keeping the fallthrough behavior consistent.
No tests because there is no behavior change.
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
- 5:11 PM Changeset in webkit [170617] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed gardening.
- WebCore.vcxproj/WebCore.vcxproj: Do not compile JSFileException
and JSFileReaderSync multiple times.
- 5:04 PM Changeset in webkit [170616] by
-
- 2 edits in trunk/Source/WebCore
Avoid copying function object in lambda function in ScrollingThread::dispatchBarrier(); actually use move semantics
https://bugs.webkit.org/show_bug.cgi?id=134470
Reviewed by Anders Carlsson.
Currently we always copy construct the captured std::function object when calling callOnMainThread()
in the lambda function created in ScrollingThread::dispatchBarrier() because captured variables are
const in a lambda expression's body by default. That is, the std::function object is captured as const.
Instead, we should mark this lambda expression as mutable so the captured std::function object is
non-const and hence we can use move semantics when passing it to callOnMainThread().
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatchBarrier):
- 5:00 PM Changeset in webkit [170615] by
-
- 2 edits in trunk/Source/WTF
Make TransformIterator::TransformIterator() take rvalue references
https://bugs.webkit.org/show_bug.cgi?id=134468
Reviewed by Darin Adler.
It's unnecessary to support TransformIterator::TransformIterator() taking const lvalue references
as we only call it with rvalues. As a side benefit, we can use move semantics to initialize the
members of TransformIterator.
- wtf/IteratorAdaptors.h:
(WTF::TransformIterator::TransformIterator): Make constructor take arguments as rvalue references.
(WTF::makeTransformIterator): Substitute std::move() for std::forward().
- 4:39 PM Changeset in webkit [170614] by
-
- 5 edits in trunk/Source/WebKit2
WebBackForwardListItem should not store back-forward data
https://bugs.webkit.org/show_bug.cgi?id=134469
Reviewed by Darin Adler.
Change WebBackForwardListItem::backForwardData to encode the main frame state lazily,
and change WebBackForwardListItem::setBackForwardData to decode it into the main frame state.
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::backForwardData):
(WebKit::WebBackForwardListItem::setBackForwardData):
(WebKit::WebBackForwardListItem::encode):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::backForwardData): Deleted.
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
- 4:26 PM Changeset in webkit [170613] by
-
- 3 edits in trunk/Source/WebKit2
WebBackForwardListItems should hold on to PageState objects
https://bugs.webkit.org/show_bug.cgi?id=134467
Reviewed by Darin Adler.
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::encode):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::originalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::url):
(WebKit::WebBackForwardListItem::setTitle):
(WebKit::WebBackForwardListItem::title):
- 4:24 PM Changeset in webkit [170612] by
-
- 2 edits in trunk/Source/WebKit2
Add a missing semicolon in WKContentViewInteraction
- UIProcess/ios/WKContentViewInteraction.mm:
(nsSizeForTapHighlightBorderRadius):
I messed up this when fixing the patch on landing.
- 4:05 PM Changeset in webkit [170611] by
-
- 6 edits in trunk/Source
Adopt the legacy session decoding inside WebPage::restoreSession for now
https://bugs.webkit.org/show_bug.cgi?id=134465
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeLegacySessionHistoryEntryData):
- UIProcess/mac/LegacySessionStateCoding.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
- 3:58 PM Changeset in webkit [170610] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Don't crash on status bar tap with overflow scroll views
https://bugs.webkit.org/show_bug.cgi?id=134459
Reviewed by Tim Horton.
The tiled scrolling indicator parents UIViews under CALayers, but that causes
those views to miss -willMoveToWindow:nil notifications on teardown. This can leave
deleted UIScrollViews in UIKit's "scroll to top" list.
Fix by not making UIScrollViews in the debug layer tree host.
- UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
- 3:52 PM Changeset in webkit [170609] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r170578.
https://bugs.webkit.org/show_bug.cgi?id=134462
causes assertions loading nytimes.com on iOS (Requested by
smfr on #webkit).
Reverted changeset:
"Create NSURLRequest lazily when USE(CFNETWORK) is enabled"
https://bugs.webkit.org/show_bug.cgi?id=134441
http://trac.webkit.org/changeset/170578
- 3:51 PM Changeset in webkit [170608] by
-
- 10 edits in trunk/Source/WebKit2
Restrict network process sandbox
https://bugs.webkit.org/show_bug.cgi?id=134360
Reviewed by Sam Weinig.
Add more restrictions to the network process sandbox.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
Always use the cache directory provided in the initialization parameters,
and make sure we consume the cookie directory extension.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
Make the sandbox profile much more restrictive.
- Shared/Network/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode): (WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
The network process now requires an extension to access
its cookie storage.
- Shared/mac/SandboxUtilities.cpp: (WebKit::pathForProcessContainer):
- Shared/mac/SandboxUtilities.h:
We need to be able to get hold of our container so
that we can get the correct cookie storage directory.
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess):
We have to pass in the an extension for the cookie storage directory when
initalising the network process
- UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformDefaultCookieStorageDirectory):
Make sure we provide the correct location on IOS
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
Consume the cookie storage extension
- 3:50 PM Changeset in webkit [170607] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Turn off scrollsToTop on overflow UIScrollViews
https://bugs.webkit.org/show_bug.cgi?id=134456
Reviewed by Tim Horton.
Set scrollsToTop to NO on our UIScrollViews created for overflow scrolling, since
we don't have a good strategy for when to allow it, and doing so would also require
some smarts in the main UIScrollView.
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
- 3:50 PM Changeset in webkit [170606] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (Okemo): The contextual menu on tap and hold does not cancel the other gestures.
https://bugs.webkit.org/show_bug.cgi?id=134463
<rdar://problem/17388907>
Reviewed by Benjamin Poulain.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _longPressRecognized:]):
- 3:48 PM Changeset in webkit [170605] by
-
- 7 edits in trunk/Source
Reduce dynamic memory allocation in css jit.
https://bugs.webkit.org/show_bug.cgi?id=134416
Reviewed by Benjamin Poulain.
Source/WebCore:
- cssjit/FunctionCall.h:
(WebCore::FunctionCall::FunctionCall):
(WebCore::FunctionCall::saveAllocatedCallerSavedRegisters):
- cssjit/RegisterAllocator.h:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
Use inlineCapacity template parameter to reduce malloc calls.
I use 16 and 32 as the inline capacity for non-register related vectors because that
is probably big enough for the selector compiler, and if it is not then a malloc
call will not be significant because the selector is very complex.
- cssjit/StackAllocator.h:
(WebCore::StackAllocator::push):
Pass a vector of stack references to match calls to pop and to avoid a call to appendVector.
Source/WTF:
- wtf/Deque.h:
Added inlineCapacity optional template parameter.
- 3:22 PM Changeset in webkit [170604] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
CodeBlock::stronglyVisitWeakReferences should mark DFG::CommonData::weakStructureReferences
https://bugs.webkit.org/show_bug.cgi?id=134455
Reviewed by Geoffrey Garen.
Otherwise we get hanging pointers which can cause us to die later.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitWeakReferences):
- 3:14 PM Changeset in webkit [170603] by
-
- 2 edits in trunk/Source/WebKit2
Implement the last pieces of encodeFrameStateNode
https://bugs.webkit.org/show_bug.cgi?id=134460
Reviewed by Andreas Kling.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataEncoder::operator<<):
(WebKit::isValidEnum):
(WebKit::encodeFormDataElement):
(WebKit::encodeFormData):
(WebKit::encodeFrameStateNode):
- 3:13 PM Changeset in webkit [170602] by
-
- 3 edits in trunk/LayoutTests
js/script-tests/function-apply-many-args.js fails on ARM
https://bugs.webkit.org/show_bug.cgi?id=126588
Reviewed by Mark Lam.
Removed three test cases that fail on some platforms and pass on others due
to stack size. Other test cases cover what will fit on a stack or what will
throw an out of stack exception.
- js/function-apply-many-args-expected.txt:
- js/script-tests/function-apply-many-args.js:
- 3:12 PM Changeset in webkit [170601] by
-
- 6 edits in trunk
Add option to run-jsc-stress-testes to filter out tests that use large heaps
https://bugs.webkit.org/show_bug.cgi?id=134458
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Added test to skip js1_5/Regress/regress-159334.js when testing on a memory limited device.
- tests/mozilla/mozilla-tests.yaml:
Tools:
Added new --memory-limited to filter out tests that have large heap usage.
Such tests are either tagged with @largeHeap or logic is added to their .yaml file.
- Scripts/run-jsc-stress-tests:
LayoutTests:
- js/regress/script-tests/lots-of-fields.js: Added @largeHeap tag to skip when
running on a memoryLimited device.
- 3:10 PM Changeset in webkit [170600] by
-
- 5 edits in trunk/Source/WebKit2
[iOS][WK2] Move tap highlight to the inverseScaleRootView
https://bugs.webkit.org/show_bug.cgi?id=134424
<rdar://problem/17480880>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-30
Reviewed by Tim Horton.
Enrica introduced the inverseScaleRootView that is a dynamic version of _highlightRootView.
This patch moves the tap highlight from its own inverse root to inverseScaleRootView. This provides better handling
of scale, better behavior on crash, and remove one extra view from the hierarchy.
The code is pretty much the same, just moved around. Some of the changes:
Now the code needs to handle repainting live when the view scale. To do that, _showTapHighlightXXX was split in two:
-_showTapHighlight to setup the view.
-_updateTapHighlight to update the view based on the current scale.
Since the view updates live on scaling, we need to recompute the coordinates for each update. To do that, the _potentialTapHighlightInformation
was generalized to handle all cases of highlight.
Since we can no longer test for the nullity of _potentialTapHighlightInformation,
a new attribute is introduced for that: _hasTapHighlightForPotentialTap.
The last bit of change concern reentering the tap highlight. This becomes quite simple:
1) _isTapHighlightIDValid is updated before the animation starts
so that it can be set again during an animation.
2) The animation checks the "finished" flags before removing the view from its superview
to avoid breaking the new animation.
- UIProcess/API/Cocoa/WKWebView.mm:
(withinEpsilon): Deleted.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
Make _updateUnscaledView conditional to scale changes, that thing isn't cheap!
- UIProcess/ios/WKContentViewInteraction.h:
(withinEpsilon):
Move withinEpsilon() from WKContentView to use it from both classes.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView _updateUnscaledView]):
(-[WKContentView _updateTapHighlight]):
(-[WKContentView _showTapHighlight]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
(-[WKContentView _cancelInteraction]):
(-[WKContentView _finishInteraction]):
(-[WKContentView _singleTapDidReset:]):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView _showTapHighlightWithColor:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]): Deleted.
- 2:53 PM Changeset in webkit [170599] by
-
- 5 edits in trunk/Source
Add code for encoding legacy session history entries
https://bugs.webkit.org/show_bug.cgi?id=134452
Reviewed by Andreas Kling.
Source/WebKit2:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataEncoder::HistoryEntryDataEncoder):
(WebKit::HistoryEntryDataEncoder::operator<<):
(WebKit::HistoryEntryDataEncoder::finishEncoding):
(WebKit::HistoryEntryDataEncoder::encodeArithmeticType):
(WebKit::HistoryEntryDataEncoder::encodeFixedLengthData):
(WebKit::HistoryEntryDataEncoder::grow):
(WebKit::HistoryEntryDataEncoder::growCapacity):
(WebKit::encodeFrameStateNode):
(WebKit::encodeLegacySessionHistoryEntryData):
(WebKit::decodeSessionHistoryEntryData):
(WebKit::decodeLegacySessionHistoryEntryData):
- UIProcess/mac/LegacySessionStateCoding.h:
Source/WTF:
- wtf/MallocPtr.h:
(WTF::MallocPtr::malloc):
(WTF::MallocPtr::realloc):
- 2:25 PM Changeset in webkit [170598] by
-
- 3 edits in trunk/Source/WebCore
Use non-thumb registers in armv7 css jit.
https://bugs.webkit.org/show_bug.cgi?id=134450
Reviewed by Geoff Garen.
- cssjit/RegisterAllocator.h:
(WebCore::RegisterAllocator::isValidRegister):
(WebCore::RegisterAllocator::isCallerSavedRegister):
Use additional general purpose registers.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Always succeed when compiling css selectors.
- 2:21 PM Changeset in webkit [170597] by
-
- 5 edits2 adds in trunk
Tiles on bottom of screen are not always allocated when necessary
https://bugs.webkit.org/show_bug.cgi?id=134272
Reviewed by Simon Fraser.
Source/WebCore:
The initial visibleRect is in the coordinate of the root layer, so its origin
is at the top left of the view. The initial rect we were using doesn't
include the contents inset, so it was too short, which was causing tiles near
the bottom of the screen to not always be allocated if the tile threshold was
close to the bottom of the view. Instead, we want to include the contents
inset size so the visible rect includes the entire view.
GraphicsLayerCA::recursiveCommitChanges() takes care of mapping and cropping
the visible rect into the tiled layer's coordinate system, at which point it
is used for visible tile logic.
Test: platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html
- platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::update):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
LayoutTests:
Apply a content inset, then dump visible rects.
- platform/mac-wk2/tiled-drawing/visible-rect-content-inset-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html: Added.
- compositing/visible-rect/iframe-no-layers.html: For WK2, the size of the visibleRect
includes the size of the border of the iframe. In order to elliminate platform
differences, set this border to 0.
- 1:57 PM Changeset in webkit [170596] by
-
- 2 edits in trunk/Tools
DRT in iOS sim crashes while loading fonts
https://bugs.webkit.org/show_bug.cgi?id=134451
Reviewed by Geoffrey Garen.
The magic linker symbols had the same name, and were therefore being unified
to a single font file. Then, adding the same file twice was failing.
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontsIOS):
- 12:01 PM Changeset in webkit [170595] by
-
- 3 edits in trunk/Source/WebCore
[Win] Unreviewed project gardening.
- WebCore.vcxproj/WebCore.vcxproj: Clean up path information so
files appear in appropriate places in project view.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- 11:48 AM Changeset in webkit [170594] by
-
- 4 edits in trunk/Source/JavaScriptCore
Avoid copying closed variables vector; actually use move semantics
Rubber-stamped by Oliver Hunt.
Currently we always copy the closed variables vector passed by Parser::closedVariables()
to ProgramNode::setClosedVariables() because these member functions return and take a const
rvalue reference, respectively. Instead, these member functions should take an return a non-
constant rvalue reference so that we actually move the closed variables vector from the Parser
object to the Node object.
- parser/Nodes.cpp:
(JSC::ProgramNode::setClosedVariables): Remove const qualifier for argument.
- parser/Nodes.h:
(JSC::ScopeNode::setClosedVariables): Ditto.
- parser/Parser.h:
(JSC::Parser::closedVariables): Remove const qualifier on return type.
(JSC::parse): Remove extraneous call to std::move(). Calling std::move() is unnecessary here
because Parser::closedVariables() returns an rvalue reference.
- 11:27 AM Changeset in webkit [170593] by
-
- 2 edits in tags/Safari-538.43.40/Source/WebKit2
Merged r170569. <rdar://problem/17500555>
- 11:24 AM Changeset in webkit [170592] by
-
- 2 edits in tags/Safari-538.43.40/Source/WebCore
Merged r170533. <rdar://problem/16801069>
- 11:22 AM Changeset in webkit [170591] by
-
- 2 edits in trunk/LayoutTests
Reduce memory required for js/typedarray-zero-size.js
https://bugs.webkit.org/show_bug.cgi?id=134448
Reviewed by Mark Hahnenberg.
Reduce the loop count from 10000 to 4000 to further reduce memory requirements
on older devices.
- js/script-tests/typedarray-zero-size.js:
- 11:06 AM Changeset in webkit [170590] by
-
- 5 edits in trunk/Source/WebCore
Remove redundant repaintCompositedLayers() parameter and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=134431
Reviewed by Darin Adler.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords): Deleted.
(WebCore::RenderLayer::convertToLayerCoords): Deleted.
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintCompositedLayers):
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):
- rendering/RenderLayerCompositor.h:
- 10:57 AM Changeset in webkit [170589] by
-
- 10 edits1 copy in trunk/Source/JavaScriptCore
JSContext Inspection: Provide a way to use a non-Main RunLoop for Inspector JavaScript Evaluations
https://bugs.webkit.org/show_bug.cgi?id=134371
Reviewed by Timothy Hatcher.
- API/JSContextPrivate.h:
- API/JSContext.mm:
(-[JSContext _debuggerRunLoop]):
(-[JSContext _setDebuggerRunLoop:]):
Private API for setting the CFRunLoop for a debugger to evaluate in.
- API/JSContextRefInternal.h: Added.
- API/JSContextRef.cpp:
(JSGlobalContextGetDebuggerRunLoop):
(JSGlobalContextSetDebuggerRunLoop):
Internal API for setting a CFRunLoop on a JSContextRef.
Set this on the debuggable.
- inspector/remote/RemoteInspectorDebuggable.h:
- inspector/remote/RemoteInspectorDebuggableConnection.h:
(Inspector::RemoteInspectorBlock::RemoteInspectorBlock):
(Inspector::RemoteInspectorBlock::~RemoteInspectorBlock):
(Inspector::RemoteInspectorBlock::operator=):
(Inspector::RemoteInspectorBlock::operator()):
Moved into the header.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::inspectorDebuggable):
Lets store the RunLoop on the debuggable instead of this core
platform agnostic class, so expose the debuggable.
- inspector/remote/RemoteInspectorDebuggableConnection.mm:
(Inspector::RemoteInspectorHandleRunSourceGlobal):
(Inspector::RemoteInspectorQueueTaskOnGlobalQueue):
(Inspector::RemoteInspectorInitializeGlobalQueue):
Rename the global functions for clarity.
(Inspector::RemoteInspectorHandleRunSourceWithInfo):
Handler for private run loops.
(Inspector::RemoteInspectorDebuggableConnection::RemoteInspectorDebuggableConnection):
(Inspector::RemoteInspectorDebuggableConnection::~RemoteInspectorDebuggableConnection):
(Inspector::RemoteInspectorDebuggableConnection::dispatchAsyncOnDebuggable):
(Inspector::RemoteInspectorDebuggableConnection::setupRunLoop):
(Inspector::RemoteInspectorDebuggableConnection::teardownRunLoop):
(Inspector::RemoteInspectorDebuggableConnection::queueTaskOnPrivateRunLoop):
Setup and teardown and use private run loop sources if the debuggable needs it.
- 10:42 AM Changeset in webkit [170588] by
-
- 5 edits in tags/Safari-538.43.40/Source
Versioning.
- 10:39 AM Changeset in webkit [170587] by
-
- 1 copy in tags/Safari-538.43.40
New Tag.
- 10:37 AM Changeset in webkit [170586] by
-
- 2 edits in trunk/LayoutTests
Reduce memory required for js/typedarray-zero-size.js
https://bugs.webkit.org/show_bug.cgi?id=134448
Reviewed by Darin Adler.
Making the loop count down reduces memory usage from ~190MB to ~22MB while
still testing the original issue.
- js/script-tests/typedarray-zero-size.js:
- 9:59 AM Changeset in webkit [170585] by
-
- 11 edits in trunk/Source/WebCore
Remove webkit prefix from pointer lock.
https://bugs.webkit.org/show_bug.cgi?id=134312
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-30
Reviewed by Dean Jackson.
- dom/Document.cpp:
(WebCore::Document::exitPointerLock):
(WebCore::Document::pointerLockElement):
(WebCore::Document::webkitExitPointerLock): Deleted.
(WebCore::Document::webkitPointerLockElement): Deleted.
- dom/Document.h:
- dom/Document.idl:
- dom/Element.cpp:
(WebCore::Element::requestPointerLock):
(WebCore::Element::webkitRequestPointerLock): Deleted.
- dom/Element.h:
- dom/Element.idl:
- dom/EventNames.h:
- dom/MouseEvent.idl:
- dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):
(WebCore::MouseRelatedEvent::webkitMovementX): Deleted.
(WebCore::MouseRelatedEvent::webkitMovementY): Deleted.
- page/PointerLockController.cpp:
(WebCore::PointerLockController::PointerLockController):
Initialize all data members.
(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
- 8:13 AM Changeset in webkit [170584] by
-
- 2 edits in trunk/Source/WebCore
U16_IS_SURROGATE should not be called with a UChar32
https://bugs.webkit.org/show_bug.cgi?id=134440
Reviewed by Darin Adler.
No new tests because there is no behavior change.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence):
- 7:48 AM Changeset in webkit [170583] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add missing ENABLE(DFG_JIT) guards
https://bugs.webkit.org/show_bug.cgi?id=134444
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-30
Reviewed by Darin Adler.
- dfg/DFGFunctionWhitelist.cpp:
- dfg/DFGFunctionWhitelist.h:
- 7:45 AM Changeset in webkit [170582] by
-
- 3 edits in trunk/Tools
Remove Qt cruft from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=134445
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-30
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(QtPort): Deleted.
(QtPort.build_webkit_command): Deleted.
(QtPort.run_webkit_tests_command): Deleted.
(QtWK2Port): Deleted.
(QtWK2Port.build_webkit_command): Deleted.
(QtWK2Port.run_webkit_tests_command): Deleted.
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest): Deleted.
(DeprecatedPortTest.test_qt_port): Deleted.
(DeprecatedPortTest.test_qt_wk2_port): Deleted.
- 1:46 AM Changeset in webkit [170581] by
-
- 5 edits in trunk/Source/WebCore
[EFL] Remove m_evasObject from Widget
https://bugs.webkit.org/show_bug.cgi?id=134442
Reviewed by Gyuyoung Kim.
Since WebKit1/EFL was dropped, we don't need to keep the m_evasObject
in the Widget.cpp because it's not used for WebKit2/Efl.
- platform/Widget.h:
(WebCore::Widget::evasObject): Deleted.
- platform/efl/ScrollbarEfl.cpp:
Removed WebKit1/Efl specific code which uses m_evasObject.
It will be a dummy until WebKit2/Efl support proper scrollbar implementation.
(WebCore::ScrollbarEfl::ScrollbarEfl):
(WebCore::ScrollbarEfl::~ScrollbarEfl):
(WebCore::ScrollbarEfl::setParent):
(WebCore::ScrollbarEfl::frameRectsChanged):
(WebCore::ScrollbarEfl::invalidate):
(ScrollbarEfl::ScrollbarEfl): Deleted.
(ScrollbarEfl::~ScrollbarEfl): Deleted.
(scrollbarEflEdjeMessage): Deleted.
(ScrollbarEfl::setParent): Deleted.
(ScrollbarEfl::updateThumbPosition): Deleted.
(ScrollbarEfl::updateThumbProportion): Deleted.
(ScrollbarEfl::updateThumbPositionAndProportion): Deleted.
(ScrollbarEfl::frameRectsChanged): Deleted.
(ScrollbarEfl::invalidate): Deleted.
- platform/efl/ScrollbarEfl.h:
Removed unnecessary methods. In addition, applied final, override keyword.
(WebCore::ScrollbarEfl::handleMouseMoveEvent): Deleted.
(WebCore::ScrollbarEfl::handleMouseOutEvent): Deleted.
(WebCore::ScrollbarEfl::handleMousePressEvent): Deleted.
(WebCore::ScrollbarEfl::handleMouseReleaseEvent): Deleted.
- platform/efl/WidgetEfl.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::setEvasObject): Deleted.
- 1:35 AM Changeset in webkit [170580] by
-
- 3 edits in trunk/Source/WebCore
Fix deprecated warning with bison 3
https://bugs.webkit.org/show_bug.cgi?id=133791
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-30
Reviewed by Csaba Osztrogonác.
No new tests because no functional changes.
- css/CSSGrammar.y.in:
- xml/XPathGrammar.y:
- 1:32 AM Changeset in webkit [170579] by
-
- 3 edits in trunk/Source/WebCore
Remove HarfBuzzShaper::setDrawRange()
https://bugs.webkit.org/show_bug.cgi?id=134243
Reviewed by Gyuyoung Kim.
setDrawRange() is not used anywhere. Remove it.
And m_fromIndex and m_toIndex are changed by only setDrawRange().
So remove them too and use the default values instead of them.
No new tests, no behavior changes.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun):
currentCharacterIndex is unsigned, always greater than 0. Clean up if statements.
(WebCore::HarfBuzzShaper::setDrawRange): Deleted.
- platform/graphics/harfbuzz/HarfBuzzShaper.h:
Jun 29, 2014:
- 11:36 PM Changeset in webkit [170578] by
-
- 4 edits in trunk/Source/WebCore
Create NSURLRequest lazily when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=134441
Reviewed by Sam Weinig.
No new tests. Should be covered by exsting tests.
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::nsURLRequest):
- 9:43 PM Changeset in webkit [170577] by
-
- 2 edits2 deletes in trunk/Source/WebCore
[EFL] Remove netscape plugin implementation from WebCore
https://bugs.webkit.org/show_bug.cgi?id=134438
Reviewed by Gyuyoung Kim.
Because WebKit1/Efl was dropped, PluginPackageEfl.cpp and PluginViewEfl.cpp are not necessary.
- PlatformEfl.cmake:
- plugins/efl/PluginPackageEfl.cpp: Removed.
- plugins/efl/PluginViewEfl.cpp: Removed.
- plugins/x11/PluginViewX11.cpp: Removed.
This file is to share common code between WebKit1/Efl and WebKit1/GTk.
Now, both ports are dropped WebKit1 support and the GTK port already removed the related files at r167016.
- 9:07 PM Changeset in webkit [170576] by
-
- 30 edits19 adds in trunk
Add support for HTMLImageElement's sizes attribute
https://bugs.webkit.org/show_bug.cgi?id=133620
Reviewed by Dean Jackson.
.:
Added an ENABLE_PICTURE_SIZES compile flag.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
Added an ENABLE_PICTURE_SIZES compile flag.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Tests: fast/dom/HTMLImageElement/sizes/image-sizes-1x.html
fast/dom/HTMLImageElement/sizes/image-sizes-2x.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html
http/tests/loading/sizes/preload-image-sizes-2x.html
http/tests/loading/sizes/preload-image-sizes.html
This patch adds support for HTMLImageElement's sizes attribute and the
related srcset extended syntax as defined in
http://picture.responsiveimages.org/.
This sizes attribute syntax is added to the CSSGrammar and parsed by
the CSSParser.
The SourceSizeList class is generated by the parser, and used to get
the final source size.
HTMLImageElement and HTMLPreloadScanner send this value to
HTMLSrcsetParser.
HTMLSrcsetParser uses this value in order to pick the right resource.
- CMakeLists.txt: Added css/SourceSizeList.cpp.
- Configurations/FeatureDefines.xcconfig: Added the PICTURE_SIZES flag.
- WebCore.vcxproj/WebCore.vcxproj: Added css/SourceSizeList.*.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added css/SourceSizeList.*.
- WebCore.xcodeproj/project.pbxproj: Added css/SourceSizeList.*.
- css/CSSGrammar.y.in: Added 4 grammar rules that define a Media condition,
Source size list, Source size length and source size.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseSizesAttribute): Parse the sizes attribute.
(WebCore::CSSParser::detectAtToken): Set the token to SIZESATTR.
- css/CSSParser.h:
- css/SourceSizeList.cpp: Added. Defined the SourceSize and SourceSizeList classes.
(WebCore::SourceSize::match):
(WebCore::computeLength):
(WebCore::defaultValue):
(WebCore::SourceSize::length):
(WebCore::SourceSizeList::parseSizesAttribute):
(WebCore::SourceSizeList::getEffectiveSize):
- css/SourceSizeList.h: Added.
(WebCore::SourceSize::SourceSize):
(WebCore::SourceSizeList::append):
- html/HTMLImageElement.cpp: Integrated sizes attribute parsing and added currentSrc.
(WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::currentSrc):
- html/HTMLImageElement.h:
- html/HTMLImageElement.idl:
- html/parser/HTMLDocumentParser.cpp: Added information required for sizes parsing to
HTMLPreloadScanner calls.
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):
- html/parser/HTMLPreloadScanner.cpp: Integrated sizes attribute parsing.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
- html/parser/HTMLSrcsetParser.cpp: Added 'w' descriptor parsing sizes based normalization.
(WebCore::parseDescriptors):
(WebCore::pickBestImageCandidate):
(WebCore::bestFitSourceForImageAttributes):
- html/parser/HTMLSrcsetParser.h:
Source/WebKit/mac:
Added an ENABLE_PICTURE_SIZES compile flag.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Added an ENABLE_PICTURE_SIZES compile flag.
- Configurations/FeatureDefines.xcconfig:
Tools:
Added an ENABLE_PICTURE_SIZES compile flag.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
These layout tests check that the sizes attribute and the related
srcset syntax are well supported, that the right resource is displayed,
that the currentSrc attribute is well supported and also that the right
resource is preloaded.
- fast/dom/HTMLImageElement/resources/currentSrcHelper.js: Added.
(fileName):
(currentSrcFileName):
- fast/dom/HTMLImageElement/resources/image-set-4x.png: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-1x-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-1x.html: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-2x-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-2x.html: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-change-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html: Added.
- http/tests/loading/sizes/preload-image-sizes-2x-expected.txt: Added.
- http/tests/loading/sizes/preload-image-sizes-2x.html: Added.
- http/tests/loading/sizes/preload-image-sizes-expected.txt: Added.
- http/tests/loading/sizes/preload-image-sizes.html: Added.
- 2:51 PM Changeset in webkit [170575] by
-
- 4 edits in trunk/Source/WebCore
No need to lazily initialize ResourceResponse internals when accessing timing data.
<https://webkit.org/b/134437>
<rdar://problem/17499876>
When building with ENABLE(WEB_TIMING), the last thing that would happen when
serializing a ResourceResponse in the network process is that we'd retrieve
the ResourceLoadTiming to encode it as part of the response. Doing so would
trigger the lazy instantiation of ResourceResponse's internal data structures.
Since timing data is not actually lazily instantiated, we can just not do that.
This shaves off ~550ms of network process main thread time on PLT, reducing
response latency by not doing unnecessary stuff before letting the web process
look at the downloaded data.
Reviewed by Gavin Barraclough.
- WebCore.exp.in:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::resourceLoadTiming): Deleted.
(WebCore::ResourceResponseBase::setResourceLoadTiming): Deleted.
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::resourceLoadTiming):
- 1:59 PM Changeset in webkit [170574] by
-
- 4 edits1 copy2 adds in trunk/Source/WebCore
Refactor ResourceRequest into Cocoa and iOS specific files
https://bugs.webkit.org/show_bug.cgi?id=134430
Reviewed by Andreas Kling.
No new tests because no functional changes.
- WebCore.xcodeproj/project.pbxproj:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::applyWebArchiveHackForMail): Deleted.
- platform/network/cocoa/ResourceRequestCocoa.mm: Copied from Source/WebCore/platform/network/mac/ResourceRequestMac.mm.
(WebCore::ResourceRequest::nsURLRequest):
(WebCore::ResourceRequest::cfURLRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdateResourceHTTPBody):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::ResourceRequest::setStorageSession):
- platform/network/ios/ResourceRequestIOS.mm: Added.
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::initQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::ResourceRequest::nsURLRequest): Deleted.
(WebCore::ResourceRequest::cfURLRequest): Deleted.
(WebCore::ResourceRequest::doUpdateResourceRequest): Deleted.
(WebCore::ResourceRequest::doUpdateResourceHTTPBody): Deleted.
(WebCore::ResourceRequest::doUpdatePlatformRequest): Deleted.
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Deleted.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Deleted.
(WebCore::ResourceRequest::setStorageSession): Deleted.
- 10:10 AM Changeset in webkit [170573] by
-
- 3 edits2 adds in trunk
TextCodecICU::encode turns the whole string as yen signs if there is any backslash in it
https://bugs.webkit.org/show_bug.cgi?id=133678
Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-06-29
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: fast/encoding/backslash-encoding-jp.html
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::encode): fixed the copy of characters other than backslash.
LayoutTests:
- fast/encoding/backslash-encoding-jp-expected.txt: Added.
- fast/encoding/backslash-encoding-jp.html: Added.
- 8:27 AM BuildingQtOnWindows edited by
- small "typo" (diff)
- 8:18 AM BuildingQtOnWindows edited by
- Added the SQLite dependency information, added some notes and a bit … (diff)
Jun 28, 2014:
- 7:44 PM Changeset in webkit [170572] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Pinching into a video (fullscreen gesture) leaves page zoomed in
https://bugs.webkit.org/show_bug.cgi?id=134433
<rdar://problem/16630794>
Reviewed by Eric Carlson.
Detect the number of target touches (those directly on the
video element) and disable the page zoom if it looks
like the user is trying to trigger fullscreen.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handleBaseGestureStart): If we are seeing
two touches in this video element, don't trigger fullscreen. The
exception is if we haven't yet started playback.
(ControllerIOS.prototype.handleBaseGestureChange): Don't allow fullscreen
if we haven't started playback (iOS 7 behaviour).
(ControllerIOS.prototype.handleWrapperTouchStart): Keep track of the
number of targetted touches.
- 4:49 PM Changeset in webkit [170571] by
-
- 17 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Reduce the GC's influence on optimization decisions
https://bugs.webkit.org/show_bug.cgi?id=134427
Reviewed by Oliver Hunt.
This is a slight speed-up on some platforms, that arises from a bunch of fixes that I made
while trying to make the GC keep more structures alive
(https://bugs.webkit.org/show_bug.cgi?id=128072).
The fixes are, roughly:
- If the GC clears an inline cache, then this no longer causes the IC to be forever polymorphic.
- If we exit in inlined code into a function that tries to OSR enter, then we jettison sooner.
- Some variables being uninitialized led to rage-recompilations.
This is a pretty strong step in the direction of keeping more Structures alive and not
blowing away code just because a Structure died. But, it seems like there is still a slight
speed-up to be had from blowing away code that references dead Structures.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
(JSC::shouldMarkTransition):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::determineLiveness):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeForStubInfo):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::isSupportedForInlining):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForClosureCall):
(JSC::DFG::mightInlineFunctionForConstruct):
- dfg/DFGCapabilities.h:
- dfg/DFGCommonData.h:
- dfg/DFGDesiredWeakReferences.cpp:
(JSC::DFG::DesiredWeakReferences::reallyAdd):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- ftl/FTLForOSREntryJITCode.cpp:
(JSC::FTL::ForOSREntryJITCode::ForOSREntryJITCode): These variables being uninitialized is benign in terms of correctness but can sometimes cause rage-recompilations. For some reason it took this patch to reveal this.
- ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- runtime/Executable.cpp:
(JSC::ExecutableBase::destroy):
(JSC::NativeExecutable::destroy):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::destroy):
(JSC::ScriptExecutable::installCode):
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
- runtime/Executable.h:
(JSC::ScriptExecutable::setDidTryToEnterInLoop):
(JSC::ScriptExecutable::didTryToEnterInLoop):
(JSC::ScriptExecutable::addressOfDidTryToEnterInLoop):
(JSC::ScriptExecutable::ScriptExecutable): Deleted.
- runtime/StructureInlines.h:
(JSC::Structure::storedPrototypeObject):
(JSC::Structure::storedPrototypeStructure):
- 3:39 PM Changeset in webkit [170570] by
-
- 10 edits in trunk/Source/WebKit2
[iOS][WK2] PDFs never load inline again after the Web process crashes
https://bugs.webkit.org/show_bug.cgi?id=134432
<rdar://problem/17484205>
Reviewed by Dan Bernstein.
After a crash, the WebPage never gets mimeTypesWithCustomContentProviders filled back in.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Add mimeTypesWithCustomContentProviders to WebPageCreationParameters.
- UIProcess/Cocoa/WKWebViewContentProviderRegistry.h:
- UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
(-[WKWebViewContentProviderRegistry addPage:]):
We don't need to send the MIME types across when a page is added, because it already got them in its creation parameters.
(-[WKWebViewContentProviderRegistry removePage:]):
(-[WKWebViewContentProviderRegistry _mimeTypesWithCustomContentProviders]):
Return a vector of all registered MIME types.
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::mimeTypesWithCustomContentProviders):
- UIProcess/PageClient.h:
Add (iOS only for now) mimeTypesWithCustomContentProviders to PageClient.
- 3:31 PM Changeset in webkit [170569] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION: WebPageProxy::attributedSubstringForCharacterRangeAsync never calls its callback function
https://bugs.webkit.org/show_bug.cgi?id=134429
Reviewed by Tim Horton.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):
- 7:50 AM Changeset in webkit [170568] by
-
- 7 edits in trunk/Source
[iOS WK2] position:fixed inside accelerated overflow:scroll is jumpy
https://bugs.webkit.org/show_bug.cgi?id=134426
<rdar://problem/17474523>
Reviewed by Tim Horton.
After committing a new layer tree (with possibly stale position:fixed layer
positions), we need the scrolling tree to update those positions based on
the current scroll offset.
Source/WebCore:
Give ScrollingTreeScrollingNode an implementation of updateLayersAfterAncestorChange()
which is required to update fixed/sticky child nodes.
- WebCore.exp.in:
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::updateLayersAfterAncestorChange):
- page/scrolling/ScrollingTreeScrollingNode.h:
Source/WebKit2:
To achieve that, implement ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterAncestorChange()
and have it add to the cumulative delta the difference between the last committed scroll
position and the current scroll position.
Also make sure that ScrollingTreeOverflowScrollingNodeIOS doesn't call back to scrollViewDidScroll()
when we're updating its scroll position inside a scrolling tree commit.
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::ScrollingTreeOverflowScrollingNodeIOS):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterAncestorChange):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll):
- 2:06 AM Changeset in webkit [170567] by
-
- 11 edits in trunk/Source/WebCore
[GTK] Use public getter/setter in GObject DOM bindings properties implementation.
https://bugs.webkit.org/show_bug.cgi?id=134390.
Patch by Juan A. Suarez Romero <jasuarez@igalia.com> and Carlos Garcia Campos <cgarcia@igalia.com> on 2014-06-28
Reviewed by Carlos Garcia Campos.
The current GObject DOM bindings generator is duplicating code when
implementing the get/set_property methods and the public
getters/setters, instead of making one invoking the other.
This commit changes this behaviour so the code is not duplicated,
making it easier to maintain.
No new tests needed.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty):
(GenerateProperties):
(WriteData):
(GetCoreObject): Deleted.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(webkit_dom_test_active_dom_object_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(webkit_dom_test_event_constructor_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(webkit_dom_test_exception_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestNondeterministic.cpp:
(webkit_dom_test_nondeterministic_set_property):
(webkit_dom_test_nondeterministic_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
(webkit_dom_test_typedefs_set_property):
(webkit_dom_test_typedefs_get_property):
- bindings/scripts/test/GObject/WebKitDOMattribute.cpp:
(webkit_dom_test_exception_get_property):
(webkit_dom_attribute_get_property):
- 1:44 AM Changeset in webkit [170566] by
-
- 3 edits2 adds in trunk
[New Multicolumn] Elements with rounded corners and overflow:hidden do not properly clip their content
https://bugs.webkit.org/show_bug.cgi?id=133941
Reviewed by Darin Adler.
Source/WebCore:
When having a multicol element inside an element with overflow:hidden and border-radius,
the fragments representing the columns need to have the border radius set also, to ensure
proper clipping.
Test: fast/multicol/newmulticol/multicol-clip-rounded-corners.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::collectFragments):
LayoutTests:
Added test for multicol element inside an element with overflow:hidden and border radius.
- fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html: Added.
- fast/multicol/newmulticol/multicol-clip-rounded-corners.html: Added.
Jun 27, 2014:
- 10:51 PM Changeset in webkit [170565] by
-
- 2 edits in trunk/Tools
check-webkit-style should check the order of #imports as well as #includes
https://bugs.webkit.org/show_bug.cgi?id=134428
Reviewed by Dan Bernstein.
- Scripts/webkitpy/style/checkers/cpp.py:
Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
- 10:43 PM Changeset in webkit [170564] by
-
- 38 edits1 add2 deletes in branches/ftlopt
[ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
https://bugs.webkit.org/show_bug.cgi?id=134333
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This is engineered to provide loads of information to the profiler without incurring any
costs when the profiler is disabled. It's the oldest trick in the book: the thing that
fires the watchpoint doesn't actually create anything to describe the reason why it was
fired; instead it creates a stack-allocated FireDetail subclass instance. Only if the
FireDetail::dump() virtual method is called does anything happen.
Currently we use this to produce very fine-grained data for Structure watchpoints and
some cases of variable watchpoints. For all other situations, the given reason is just a
string constant, by using StringFireDetail. If we find a situation where that string
constant is insufficient to diagnose an issue then we can change it to provide more
fine-grained information.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::jettison):
- bytecode/CodeBlock.h:
- bytecode/CodeBlockJettisoningWatchpoint.cpp:
(JSC::CodeBlockJettisoningWatchpoint::fireInternal):
- bytecode/CodeBlockJettisoningWatchpoint.h:
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp: Removed.
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.h: Removed.
- bytecode/StructureStubClearingWatchpoint.cpp:
(JSC::StructureStubClearingWatchpoint::fireInternal):
- bytecode/StructureStubClearingWatchpoint.h:
- bytecode/VariableWatchpointSet.h:
(JSC::VariableWatchpointSet::invalidate):
(JSC::VariableWatchpointSet::finalizeUnconditionally):
- bytecode/VariableWatchpointSetInlines.h:
(JSC::VariableWatchpointSet::notifyWrite):
- bytecode/Watchpoint.cpp:
(JSC::StringFireDetail::dump):
(JSC::WatchpointSet::fireAll):
(JSC::WatchpointSet::fireAllSlow):
(JSC::WatchpointSet::fireAllWatchpoints):
(JSC::InlineWatchpointSet::fireAll):
- bytecode/Watchpoint.h:
(JSC::FireDetail::FireDetail):
(JSC::FireDetail::~FireDetail):
(JSC::StringFireDetail::StringFireDetail):
(JSC::Watchpoint::fire):
(JSC::WatchpointSet::fireAll):
(JSC::WatchpointSet::touch):
(JSC::WatchpointSet::invalidate):
(JSC::InlineWatchpointSet::fireAll):
(JSC::InlineWatchpointSet::touch):
- dfg/DFGCommonData.h:
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- jsc.cpp:
(WTF::Masquerader::create):
- profiler/ProfilerCompilation.cpp:
(JSC::Profiler::Compilation::setJettisonReason):
(JSC::Profiler::Compilation::toJS):
- profiler/ProfilerCompilation.h:
(JSC::Profiler::Compilation::setJettisonReason): Deleted.
- runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::transfer):
- runtime/ArrayBufferNeuteringWatchpoint.cpp:
(JSC::ArrayBufferNeuteringWatchpoint::fireAll):
- runtime/ArrayBufferNeuteringWatchpoint.h:
- runtime/CommonIdentifiers.h:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/Identifier.cpp:
(JSC::Identifier::dump):
- runtime/Identifier.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::addFunction):
(JSC::JSGlobalObject::haveABadTime):
- runtime/JSSymbolTableObject.cpp:
(JSC::VariableWriteFireDetail::dump):
- runtime/JSSymbolTableObject.h:
(JSC::VariableWriteFireDetail::VariableWriteFireDetail):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):
- runtime/PropertyName.h:
(JSC::PropertyName::dump):
- runtime/Structure.cpp:
(JSC::Structure::notifyTransitionFromThisStructure):
- runtime/Structure.h:
(JSC::Structure::notifyTransitionFromThisStructure): Deleted.
- runtime/SymbolTable.cpp:
(JSC::SymbolTableEntry::notifyWriteSlow):
(JSC::SymbolTable::WatchpointCleanup::finalizeUnconditionally):
- runtime/SymbolTable.h:
(JSC::SymbolTableEntry::notifyWrite):
- runtime/VM.cpp:
(JSC::VM::addImpureProperty):
Source/WebCore:
No new tests because no change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
Tools:
- Scripts/display-profiler-output:
- 6:34 PM Changeset in webkit [170563] by
-
- 4 edits2 adds in trunk
Subpixel rendering: Background clipping with subpixel behaves differently when composited.
https://bugs.webkit.org/show_bug.cgi?id=134422
Reviewed by Simon Fraser.
Adjust cliprect with the subpixel offset from the graphics layer the same way we do it for painting.
It ensures that cliprect starts from the right position when graphics layer is not on the same
coordinates as the associated render layer.
Source/WebCore:
Test: compositing/hidpi-compositing-layer-with-subpixel-offset-accumulation-clipping.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::applyFilters):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
(WebCore::RenderLayer::paintOverflowControlsForFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
LayoutTests:
- compositing/hidpi-compositing-layer-with-subpixel-offset-accumulation-clipping-expected.html: Added.
- compositing/hidpi-compositing-layer-with-subpixel-offset-accumulation-clipping.html: Added.
- 5:19 PM Changeset in webkit [170562] by
-
- 18 edits4 adds in trunk/Source
[Win] Implement parts of the AVFOUNDATION_LOADER_DELEGATE logic for Windows
https://bugs.webkit.org/show_bug.cgi?id=134418
Reviewed by Eric Carlson.
../WebCore:
Land an initial implementation of AVFOUNDATION_LOADER_DELEGATE for
Windows.
- DerivedSources.cpp: Add new IDL files
- DerivedSources.make: Add check for AVFOUNDATION_LOADER_DELEGATE.
- Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp: Added (ported from
Objective C.)
- WebCore.vcxproj/WebCore.vcxproj: Update for new files.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.vcxproj/WebCoreCommon.props: Add new search paths.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj: Update for new files.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters: Ditto.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::extractKeyURIKeyIDAndCertificateFromInitData):
Moved from MediaPlayerPrivateAVFoundationObjC.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h:
Update for new API calls.
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp: Added.
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h: Added.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
Updated for new AVFOUNDATION_LOADER_DELEGATE methods.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp: Added.
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.h: Added.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
Remove method that was moved to base class.
../WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add new
export.
- 4:32 PM Changeset in webkit [170561] by
-
- 5 edits in trunk/Source/WebCore
Remove BufferForAppendingHyphen
https://bugs.webkit.org/show_bug.cgi?id=134376
Reviewed by Darin Adler.
It is legacy, from a time when that code was using a Vector.
The problem is that StringBuilder's memory was also implicitly used to keep
the string alive for the lifespan of the TextRun. That seems quite dangerous
as changes in StringBuilder could have changed that.
To fix the lifetime issue, my first idea was to make it explicit by passing
a String reference to hold the memory alive, and a boolean to say if the text
need an hyphen. The problem with that is this code is very hot and I made things
worse.
The solution with this patch is to just pass a pointer to a String to do both
the buffer reference, and the decision to add the hyphen. Having a single
argument with 2 meanings is not pretty but that's not worse than the old buffer.
- editing/TextIterator.cpp:
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::constructTextRun):
(WebCore::adjustCharactersAndLengthForHyphen): Deleted.
- rendering/InlineTextBox.h:
(WebCore::BufferForAppendingHyphen::BufferForAppendingHyphen): Deleted.
- rendering/RenderText.cpp:
- 4:28 PM Changeset in webkit [170560] by
-
- 2 edits in trunk/Source/WebCore
Lazily link frameworks in WebVideoFullscreenInterfaceAVKit.
https://bugs.webkit.org/show_bug.cgi?id=134407
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-27
Reviewed by Eric Carlson.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController init]):
Load AVPlayerController on use.
(WebVideoFullscreenInterfaceAVKit::WebVideoFullscreenInterfaceAVKit):
Remove loading on construction.
(WebVideoFullscreenInterfaceAVKit::setCurrentTime): Load AVValueTiming on use.
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): Load several classes on use.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Load UIColor on use.
- 3:29 PM Changeset in webkit [170559] by
-
- 2 edits in trunk/Source/WebCore
Remove extra operations from 64-bit or on armv7.
https://bugs.webkit.org/show_bug.cgi?id=134408
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-27
Reviewed by Geoffrey Garen.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
Only do or operations if it would change values.
Often we're only setting one flag, so half the operations are not necessary.
- 3:12 PM Changeset in webkit [170558] by
-
- 2 edits in trunk/Source/WebCore
ScrollView::rootViewToTotalContents() needs to take topContentInset into account
https://bugs.webkit.org/show_bug.cgi?id=134415
-and corresponding-
<rdar://problem/17473633>
Reviewed by Simon Fraser.
This affects hit testing in headers aka PageBanners.
The root view will be anchored above the start of the total contents if there is a
topContentInset, so the inset value should be subtracted to get into the right
coordinate space here.
- platform/ScrollView.cpp:
(WebCore::ScrollView::rootViewToTotalContents):
- 2:58 PM Changeset in webkit [170557] by
-
- 15 edits1 add in trunk/Source
Flush throttling with remote layers
https://bugs.webkit.org/show_bug.cgi?id=134398
Reviewed by Darin Adler.
Source/WebCore:
With remote layer trees the flush scheduling lives in the WebKit2 layer. The throttling code
needs to live there as well.
Add the required callbacks and disable the existing throttling code in RenderLayerCompositor
when remote layers are in use. Later we can get rid of the RenderLayerCompositor throttling code.
- WebCore.xcodeproj/project.pbxproj:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
- page/ChromeClient.h:
(WebCore::ChromeClient::adjustLayerFlushThrottling):
- page/FrameView.cpp:
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::loadProgressingStatusChanged):
Factor the progress status change activities to a function.
(WebCore::FrameView::updateLayerFlushThrottling):
(WebCore::FrameView::setExposedRect):
Move the call to adjustTiledBackingCoverage from WebKit to here.
(WebCore::FrameView::updateLayerFlushThrottlingInAllFrames): Deleted.
- page/FrameView.h:
- page/LayerFlushThrottleState.h: Added.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::adjustLayerFlushThrottling):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::adjustLayerFlushThrottling):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
Delay layer flushes during page loading.
If use interacts with the page the next flush in unthrottled even if loading is in progress.
(WebKit::RemoteLayerTreeDrawingArea::adjustLayerFlushThrottling):
Compute the new delay. The first visual flush uses a shorter delay.
Flush immediately when we are no longer throttling.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
- 2:57 PM Changeset in webkit [170556] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
Unreviewed build fix after r169795.
Fixed ASSERT for 32 bit build.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
- 2:44 PM Changeset in webkit [170555] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
Don't fold a UInt32ToNumber with DoOverflow to Identity since that would result in an Identity that takes an Int32 and returns a DoubleRep
https://bugs.webkit.org/show_bug.cgi?id=134412
Reviewed by Mark Hahnenberg.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setReplacement):
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
- tests/stress/uint32-to-number-fold-constant-with-do-overflow.js: Added.
(foo):
(bar):
(baz):
- 2:36 PM Changeset in webkit [170554] by
-
- 3 edits in trunk/Source/WebKit2
[iOS][WK2] <select> tapping "next" does not save new picker value
https://bugs.webkit.org/show_bug.cgi?id=134409
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-27
Reviewed by Enrica Casucci.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView accessoryTab:]):
We know the assisted node will change, so call endEditing
before the assisted node changes in the WebProcess.
(-[WKContentView _stopAssistingNode]):
Ensure we call endEditing to trigger controlEndEditing.
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKMultipleSelectPicker initWithView:]):
(-[WKMultipleSelectPicker pickerView:row:column:checked:]):
(-[WKSelectSinglePicker dealloc]):
Style fixes.
- 2:11 PM Changeset in webkit [170553] by
-
- 6 edits in trunk/Source/WebCore
The user pressing a button on a gamepad should cause gamepads to become visible to all NavigatorGamepads.
https://bugs.webkit.org/show_bug.cgi?id=134375
Reviewed by Darin Adler.
No new tests (Not yet a tested config)
- Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::platformGamepadConnected): Also call to makeGamepadsVisibileToBlindNavigators.
(WebCore::GamepadManager::platformGamepadDisconnected):
(WebCore::GamepadManager::platformGamepadInputActivity): Call makeGamepadsVisibileToBlindNavigators.
(WebCore::GamepadManager::makeGamepadsVisibileToBlindNavigators): Walk through each blind navigator
notifying it of each connected Gamepad.
(WebCore::GamepadManager::registerNavigator): Also add to the blind navigator set.
(WebCore::GamepadManager::unregisterNavigator): Also remove from the blind navigator set.
- Modules/gamepad/GamepadManager.h:
- platform/GamepadProviderClient.h: Added platformGamepadInputActivity.
- platform/mac/HIDGamepadProvider.cpp:
(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::valuesChanged): Set the input notification timer which will notify the clients
that a button was pressed.
(WebCore::HIDGamepadProvider::inputNotificationTimerFired): Perform that notification.
- platform/mac/HIDGamepadProvider.h:
- 2:04 PM Changeset in webkit [170552] by
-
- 2 edits in trunk/Source/WebKit/mac
InfoClick (from Nisus Software) dies on viewing found items
<rdar://problem/17395601>
https://bugs.webkit.org/show_bug.cgi?id=134410
Reviewed by Andy Estes.
InfoClick was calling -[WebPreferences setPrivateBrowsingEnabled:] before
setting up a WebView (or anything else that would have set up WebKitSystemInterface),
which now requires a set up WebKitSystemInterface. We can fix this by initializing
it from +[WebPreferences initialize].
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Add call to InitWebCoreSystemInterface().
(+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
Remove now unnecessary call to InitWebCoreSystemInterface().
- 2:03 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 1:53 PM Changeset in webkit [170551] by
-
- 3 edits in trunk/Source/WebCore
HIDGamepads should populate themselves with initial input values
https://bugs.webkit.org/show_bug.cgi?id=134381
Reviewed by Darin Adler.
No new tests (Not yet a tested config)
- platform/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::getCurrentValueForElement):
(WebCore::HIDGamepad::initElements): Loop through all the saved elements to get current values.
(WebCore::HIDGamepad::maybeAddButton):
(WebCore::HIDGamepad::maybeAddAxis):
- platform/mac/HIDGamepad.h:
(WebCore::HIDGamepadElement::HIDGamepadElement):
(WebCore::HIDGamepadButton::HIDGamepadButton):
(WebCore::HIDGamepadAxis::HIDGamepadAxis):
- 1:47 PM Changeset in webkit [170550] by
-
- 8 edits in trunk/Source
Source/JavaScriptCore: Add feature flag for link long-press gesture.
Reviewed by Enrica Casucci.
- Configurations/FeatureDefines.xcconfig: Add ENABLE_LINK_LONG_PRESS.
Patch by Peyton Randolph <prandolph@apple.com> on 2014-06-27
Source/WebCore: Add feature flag for link long-press gesture.
https://bugs.webkit.org/show_bug.cgi?id=134262
Patch by Peyton Randolph <prandolph@apple.com> on 2014-06-27
Reviewed by Enrica Casucci.
- Configurations/FeatureDefines.xcconfig:
Add ENABLE_LINK_LONG_PRESS.
Source/WebKit/mac: Add feature flag for link long-press gesture.
https://bugs.webkit.org/show_bug.cgi?id=134262
Patch by Peyton Randolph <prandolph@apple.com> on 2014-06-27
Reviewed by Enrica Casucci.
- Configurations/FeatureDefines.xcconfig:
Add ENABLE_LINK_LONG_PRESS.
Source/WebKit2: Add feature flag for link long-press gesture.
Reviewed by Enrica Casucci.
- Configurations/FeatureDefines.xcconfig: Add ENABLE_LINK_LONG_PRESS.
Patch by Peyton Randolph <prandolph@apple.com> on 2014-06-27
- 1:35 PM Changeset in webkit [170549] by
-
- 4 edits in trunk/Source/WebCore
HIDGamepadProvider should only be active when someone is interested in Gamepads.
https://bugs.webkit.org/show_bug.cgi?id=134374
Reviewed by Darin Adler.
No new tests (Not yet a tested config)
- Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::registerNavigator): Add some logging.
(WebCore::GamepadManager::unregisterNavigator): Ditto.
- platform/mac/HIDGamepadProvider.cpp:
(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::connectionDelayTimerFired): Stop suppressing connection callbacks
(WebCore::HIDGamepadProvider::openAndScheduleManager):
(WebCore::HIDGamepadProvider::closeAndUnscheduleManager): Stop listening for gamepad events, and clear
all current gamepads.
(WebCore::HIDGamepadProvider::startMonitoringGamepads): If the first client, call openAndScheduleManager
(WebCore::HIDGamepadProvider::stopMonitoringGamepads): If the last client, call closeAndUnscheduleManager
(WebCore::HIDGamepadProvider::deviceAdded): If this callback came while we were suppressing connection
callbacks, it is a startup event for already-connected gamepads. Stop suppressing callbacks in a later
spin of the runloop.
(WebCore::HIDGamepadProvider::deviceRemoved):
- platform/mac/HIDGamepadProvider.h:
(WebCore::HIDGamepadProvider::setShouldDispatchCallbacks): Deleted.
- 1:31 PM Changeset in webkit [170548] by
-
- 3 edits in trunk/Source/WebCore
Prevent unnecessary register saving in css jit.
https://bugs.webkit.org/show_bug.cgi?id=133955
Reviewed by Geoff Garen.
- cssjit/FunctionCall.h:
(WebCore::FunctionCall::prepareAndCall):
(WebCore::FunctionCall::cleanupPostCall):
(WebCore::FunctionCall::saveAllocatedCallerSavedRegisters):
(WebCore::FunctionCall::restoreAllocatedCallerSavedRegisters):
(WebCore::FunctionCall::saveAllocatedRegisters): Renamed to saveAllocatedCallerSavedRegisters.
(WebCore::FunctionCall::restoreAllocatedRegisters): Renamed to restoreAllocatedCallerSavedRegisters.
Only push caller saved registers before function calls.
- cssjit/RegisterAllocator.h:
(WebCore::RegisterAllocator::isValidRegister):
Corrected register ranges.
(WebCore::RegisterAllocator::isCallerSavedRegister): Added.
- 12:54 PM Changeset in webkit [170547] by
-
- 35 edits in trunk/LayoutTests
Unreviewed gardening; fix whitespace issues in the W3C Media Source expected results.
- http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt:
- http/tests/media/media-source/mediasource-append-buffer-expected.txt:
- http/tests/media/media-source/mediasource-append-stream-expected.txt:
- http/tests/media/media-source/mediasource-appendwindow-expected.txt:
- http/tests/media/media-source/mediasource-buffered-expected.txt:
- http/tests/media/media-source/mediasource-closed-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framerate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-a-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-framerate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-framesize-expected.txt:
- http/tests/media/media-source/mediasource-duration-expected.txt:
- http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt:
- http/tests/media/media-source/mediasource-endofstream-invaliderror.html:
- http/tests/media/media-source/mediasource-getvideoplaybackquality-expected.txt:
- http/tests/media/media-source/mediasource-is-type-supported-expected.txt:
- http/tests/media/media-source/mediasource-multiple-attach-expected.txt:
- http/tests/media/media-source/mediasource-play-expected.txt:
- http/tests/media/media-source/mediasource-play-then-seek-back-expected.txt:
- http/tests/media/media-source/mediasource-redundant-seek-expected.txt:
- http/tests/media/media-source/mediasource-remove-expected.txt:
- http/tests/media/media-source/mediasource-seek-beyond-duration-expected.txt:
- http/tests/media/media-source/mediasource-seek-during-pending-seek-expected.txt:
- http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt:
- http/tests/media/media-source/mediasource-sourcebufferlist-expected.txt:
- 12:22 PM Changeset in webkit [170546] by
-
- 6 edits in trunk/Source/WebCore
Custom scrollbars should not create ScrollbarPainters on Mac
https://bugs.webkit.org/show_bug.cgi?id=134406
-and corresponding-
<rdar://problem/16178301>
Reviewed by Tim Horton.
The solution here is to return early in ScrollbarThemeMac::registerScrollbar() if
the scrollbar is custom. However, since this function is called during the
RenderScrollbar and Scrollbar constructor, we need to re-implement
Scrollbar::isCustomScrollbar() to return a member variable that is passed into the
constructor. Otherwise, we will get Scrollbar’s implementation is
isCustomScrollbar() wrongfully returning false since instead of the derived
class’s implementation.
Scrollbar constructor now has an option parameter isCustomScrollbar that defaults
to false. That value is returned by isCustomScrollbar()
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):
- platform/Scrollbar.h:
Return early if this is a custom scrollbar since the rest of the function deals
with creating a native scrollbar and getting it in the right state.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
Send true to the Scrollbar constructor to indicate that this is a custom
scrollbar.
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::RenderScrollbar):
- rendering/RenderScrollbar.h:
- 12:17 PM Changeset in webkit [170545] by
-
- 2 edits in trunk/Source/WebCore
[Mac] AVMetadataKeySpaceISOUserData not defined on 10.8
https://bugs.webkit.org/show_bug.cgi?id=134401
Reviewed by Jer Noble.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::metadataType): Use SOFT_LINK_POINTER_OPTIONAL for AVMetadataKeySpaceISOUserData
so we don't have problems on OS versions where it isn't defined.
- 11:55 AM Changeset in webkit [170544] by
-
- 3 edits2 adds in trunk
REGRESSION (r168685): css calc() expression fails
https://bugs.webkit.org/show_bug.cgi?id=134059
Source/WebCore:
The expression 'calc((100% - 20px) / 3' did not work properly after r168685,
because primitiveType() function in CSSCalculationValue.cpp has handled
CalcPercentLength and CalcPercentNumber categories as if they were angles.
The patch fixes this incorrect behavior.
Reviewed by Simon Fraser.
Test: fast/css/calc-percentage-pixel.html
- css/CSSCalculationValue.cpp:
LayoutTests:
Added test demonstrates that expressions like
'calc((100% - 20px) / 3' work correctly again.
Reviewed by Simon Fraser.
- fast/css/calc-percentage-pixel-expected.html: Added.
- fast/css/calc-percentage-pixel.html: Added.
- 11:45 AM Changeset in webkit [170543] by
-
- 3 edits in trunk/Source/WebCore
[MSE] http/tests/media/media-source/mediasource-append-buffer.html is failing
https://bugs.webkit.org/show_bug.cgi?id=134389
Reviewed by Eric Carlson.
Two subtests in mediasource-append-buffer.html are failing. Bring setDuration() up to spec
by throwing an exception if the duration is called while any SourceBuffer is updating. Do
not cancel pending events when a SourceBuffer is removed from its MediaSource. And mark the
SourceBuffer as having pending activity if there are pending events to be fired.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setDuration):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removedFromMediaSource):
(WebCore::SourceBuffer::hasPendingActivity):
- 11:43 AM Changeset in webkit [170542] by
-
- 47 edits22 copies46 adds44 deletes in trunk/LayoutTests
[MSE] Import latest Media Source tests from W3C test suite
https://bugs.webkit.org/show_bug.cgi?id=134388
Reviewed by Eric Carlson.
Import the most recent Media Source tests from the proposed W3C test suite:
<https://github.com/acolwell/web-platform-tests/tree/submission/acolwell/media-source/media-source>
No ports currently enable these tests, so update the expected results for each
test with the ideal expected result.
- http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt:
- http/tests/media/media-source/mediasource-addsourcebuffer.html:
- http/tests/media/media-source/mediasource-append-buffer-expected.txt:
- http/tests/media/media-source/mediasource-append-buffer.html:
- http/tests/media/media-source/mediasource-append-stream-expected.txt: Added.
- http/tests/media/media-source/mediasource-append-stream.html: Added.
- http/tests/media/media-source/mediasource-appendwindow-expected.txt: Added.
- http/tests/media/media-source/mediasource-appendwindow.html: Added.
- http/tests/media/media-source/mediasource-buffered-expected.txt:
- http/tests/media/media-source/mediasource-buffered.html:
- http/tests/media/media-source/mediasource-closed-expected.txt:
- http/tests/media/media-source/mediasource-closed.html:
- http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-mp4-av-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-framesize.html:
- http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framerate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framesize.html:
- http/tests/media/media-source/mediasource-config-change-webm-a-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-a-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-webm-av-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-framesize.html:
- http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-webm-v-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-webm-v-framerate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-framerate.html:
- http/tests/media/media-source/mediasource-config-change-webm-v-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-framesize.html:
- http/tests/media/media-source/mediasource-config-changes.js:
- http/tests/media/media-source/mediasource-duration-expected.txt: Added.
- http/tests/media/media-source/mediasource-duration.html: Added.
- http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt: Added.
- http/tests/media/media-source/mediasource-endofstream-invaliderror.html: Added.
- http/tests/media/media-source/mediasource-getvideoplaybackquality-expected.txt: Added.
- http/tests/media/media-source/mediasource-getvideoplaybackquality.html: Added.
- http/tests/media/media-source/mediasource-is-type-supported-expected.txt:
- http/tests/media/media-source/mediasource-is-type-supported.html:
- http/tests/media/media-source/mediasource-multiple-attach-expected.txt:
- http/tests/media/media-source/mediasource-multiple-attach.html:
- http/tests/media/media-source/mediasource-play-expected.txt:
- http/tests/media/media-source/mediasource-play-then-seek-back-expected.txt: Added.
- http/tests/media/media-source/mediasource-play-then-seek-back.html: Added.
- http/tests/media/media-source/mediasource-play.html:
- http/tests/media/media-source/mediasource-redundant-seek-expected.txt: Added.
- http/tests/media/media-source/mediasource-redundant-seek.html: Added.
- http/tests/media/media-source/mediasource-remove-expected.txt: Added.
- http/tests/media/media-source/mediasource-remove.html: Added.
- http/tests/media/media-source/mediasource-seek-beyond-duration-expected.txt: Added.
- http/tests/media/media-source/mediasource-seek-beyond-duration.html: Added.
- http/tests/media/media-source/mediasource-seek-during-pending-seek-expected.txt: Added.
- http/tests/media/media-source/mediasource-seek-during-pending-seek.html: Added.
- http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt: Added.
- http/tests/media/media-source/mediasource-sourcebuffer-mode.html: Added.
- http/tests/media/media-source/mediasource-sourcebufferlist-expected.txt:
- http/tests/media/media-source/mediasource-sourcebufferlist.html:
- http/tests/media/media-source/mediasource-util.js:
- http/tests/media/media-source/mp4/test-a-128k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/media-source/mp4/test-a-128k-44100Hz-1ch.mp4: Added.
- http/tests/media/media-source/mp4/test-a-192k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/media-source/mp4/test-a-192k-44100Hz-1ch.mp4: Added.
- http/tests/media/media-source/mp4/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-v-128k-320x240-24fps-8kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-v-128k-320x240-24fps-8kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-v-128k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-v-128k-320x240-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-v-128k-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-v-128k-640x480-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-v-256k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-v-256k-320x240-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test.mp4: Added.
- http/tests/media/media-source/seek-to-end-after-duration-change-expected.txt: Removed.
- http/tests/media/media-source/seek-to-end-after-duration-change.html: Removed.
- http/tests/media/media-source/video-media-source-abort-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-abort.html: Removed.
- http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-add-and-remove-buffers.html: Removed.
- http/tests/media/media-source/video-media-source-append-in-ended-state-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-append-in-ended-state.html: Removed.
- http/tests/media/media-source/video-media-source-append-with-offset-in-ended-state-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-append-with-offset-in-ended-state.html: Removed.
- http/tests/media/media-source/video-media-source-async-events-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-async-events.html: Removed.
- http/tests/media/media-source/video-media-source-closed-on-htmlmediaelement-destruction-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-closed-on-htmlmediaelement-destruction.html: Removed.
- http/tests/media/media-source/video-media-source-duration-boundaryconditions-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-duration-boundaryconditions.html: Removed.
- http/tests/media/media-source/video-media-source-duration-changed-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-duration-changed.html: Removed.
- http/tests/media/media-source/video-media-source-duration-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-duration.html: Removed.
- http/tests/media/media-source/video-media-source-errors-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-errors.html: Removed.
- http/tests/media/media-source/video-media-source-event-attributes-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-event-attributes.html: Removed.
- http/tests/media/media-source/video-media-source-garbage-collection-before-sourceopen-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-garbage-collection-before-sourceopen.html: Removed.
- http/tests/media/media-source/video-media-source-is-type-supported-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-is-type-supported.html: Removed.
- http/tests/media/media-source/video-media-source-objects-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-objects.html: Removed.
- http/tests/media/media-source/video-media-source-play-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-play.html: Removed.
- http/tests/media/media-source/video-media-source-reject-append-after-reopening-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-reject-append-after-reopening.html: Removed.
- http/tests/media/media-source/video-media-source-seek-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-seek.html: Removed.
- http/tests/media/media-source/video-media-source-sourcebufferlist-crash-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-sourcebufferlist-crash.html: Removed.
- http/tests/media/media-source/video-media-source-state-changes-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-state-changes.html: Removed.
- http/tests/media/media-source/video-media-source-zero-byte-append-in-ended-state-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-zero-byte-append-in-ended-state.html: Removed.
- http/tests/media/media-source/webm/segment-info.js: Added.
- http/tests/media/media-source/webm/test-a-128k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/media-source/webm/test-a-128k-44100Hz-1ch.webm: Added.
- http/tests/media/media-source/webm/test-a-192k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/media-source/webm/test-a-192k-44100Hz-1ch.webm: Added.
- http/tests/media/media-source/webm/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-v-128k-320x240-24fps-8kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-v-128k-320x240-24fps-8kfr.webm: Added.
- http/tests/media/media-source/webm/test-v-128k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-v-128k-320x240-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-v-128k-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-v-128k-640x480-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-v-256k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-v-256k-320x240-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-vp8-vorbis-webvtt.webm: Added.
- http/tests/media/media-source/webm/test.webm: Added.
- 11:28 AM Changeset in webkit [170541] by
-
- 14 edits in trunk/Source
[iOS WK2] Fix touch-scrollable elements with overflow:scroll on just one axis, and RTL scrolling
https://bugs.webkit.org/show_bug.cgi?id=134377
<rdar://problem/16762224>
Reviewed by Tim Horton.
Source/WebCore:
Make -webkit-overflow-scrolling:touch scrolling work correctly when one axis
has overflow:scroll and the other overflow:hidden. Also fix scrolling in RTL
contexts.
An RTL scroller with overflow-x:hidden will have a non-zero scroll origin,
and needs to truncate the scrolled content on the left side. To pass the
correct geometry to the UI process, we need to introduce the concept of
"reachable" size as well as total content size; normally these are the same,
but will differ when scrolling is only allowed on one axis but there is overflow
on both axes.
To get the reachable size, add RenderLayer::scrollableContentsSize().
RenderLayer::visibleSize() was wrong; the function should return the size of the
scrollable portion, but used layer size which includes borders. Fix to use pixelSnappedClientWidth()/Height(),
which is what we use for scrollbar computations.
- WebCore.exp.in:
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::updateFrameScrollingNode):
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode):
- page/scrolling/ScrollingCoordinator.h:
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setReachableContentsSize):
- page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::ScrollingStateScrollingNode::reachableContentsSize):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
- page/scrolling/ScrollingTreeScrollingNode.h:
(WebCore::ScrollingTreeScrollingNode::reachableContentsSize):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::visibleSize):
(WebCore::RenderLayer::scrollableContentsSize):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::updateScrollingLayerWithClient):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
Source/WebKit2:
Make -webkit-overflow-scrolling:touch scrolling work correctly when one axis
has overflow:scroll and the other overflow:hidden. Also fix scrolling in RTL
contexts.
An RTL scroller with overflow-x:hidden will have a non-zero scroll origin,
and needs to truncate the scrolled content on the left side. To pass the
correct geometry to the UI process, we need to introduce the concept of
"reachable" size as well as total content size; normally these are the same,
but will differ when scrolling is only allowed on one axis but there is overflow
on both axes.
ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren() uses the total and
reachable content sizes to set a negative edge inset on the left (for RTL) or top
(for bottom-to-top) so prevent scrolling into these areas.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):
(WebKit::RemoteScrollingTreeTextStream::dump):
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
- 11:13 AM Changeset in webkit [170540] by
-
- 2 edits in trunk/Source/WebKit2
Fix various leaks, RetainPtrs should adopt allocs
https://bugs.webkit.org/show_bug.cgi?id=134308
Reviewed by Alexey Proskuryakov.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _remoteObjectRegistry]):
- 11:13 AM Changeset in webkit [170539] by
-
- 4 edits in trunk/Source/WebCore
[Feature Queries] Fix feature queries build on Mac
https://bugs.webkit.org/show_bug.cgi?id=134359
Reviewed by Antti Koivisto.
Update the XCode project and Feature Queries code to build on Mac.
There are existing tests for supports in the LayoutTests/css3 directory.
- WebCore.xcodeproj/project.pbxproj: Add the Feature Queries files
to the XCode project.
- css/CSSGrammar.y.in: Update CSSParserExpression to CSSParserValueList.
- css/DOMWindowCSS.idl: Add ImplementationLacksVTable metadata.
- 11:09 AM Changeset in webkit [170538] by
-
- 2 edits in trunk/Source/WebKit2
Remove unused definitions that were mistakenly added back in r170323 and then again in r170329
https://bugs.webkit.org/show_bug.cgi?id=134397
Reviewed by Geoff Garen.
- UIProcess/API/Cocoa/WKBackForwardList.mm:
- 11:08 AM Changeset in webkit [170537] by
-
- 17 edits7 adds in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
Rebaseline tests after r170207, r170249, r170304, r170418 and r170433.
Update expectations for new crashing tests.
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-27
- platform/gtk/TestExpectations: Report and mark new crashing tests. Adjust some tests expectations.
- platform/gtk/fast/canvas/canvas-blend-image-expected.txt: Rebaseline after r170433.
- platform/gtk/fast/canvas/canvas-blend-solid-expected.txt: Rebaseline after r170433.
- platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Rebaseline after r170249.
- platform/gtk/fast/dynamic/text-combine-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt: Added. Add baseline after r170304.
- platform/gtk/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Added. Rebaseline after r170418.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added. Rebaseline after r170418.
- platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/text/emphasis-vertical-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/text/international/002-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/text/international/text-combine-image-test-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/text/international/text-spliced-font-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/text/international/wrap-CJK-001-expected.txt: Added. Rebaseline after r170418.
- platform/gtk/fast/text/khmer-lao-font-expected.txt: Added. Add baseline after r170207.
- platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt: Rebaseline after r170418.
- platform/gtk/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added. Rebaseline after r170433.
- platform/gtk/svg/filters/feBlend-all-blendmodes-expected.txt: Added. Add baseline after r170433.
- 11:06 AM Changeset in webkit [170536] by
-
- 2 edits in trunk/Source/WTF
[ARMv7] Skip one particularly expensive fastFree() alignment check.
<https://webkit.org/b/134402>
The size class alignment check in fastFree() was crazy expensive on ARMv7
due to its use of modulo. Disabling it shaves 470ms off of PLT main thread
time in the web process.
Note that this was very hard to identify in profiles due to TCO.
Reviewed by Gavin Barraclough.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 10:50 AM Changeset in webkit [170535] by
-
- 2 edits in trunk/Source/WebCore
[MSE] media/media-source/media-source-tracks.html is crashy
https://bugs.webkit.org/show_bug.cgi?id=134385
Reviewed by Eric Carlson.
Fix the refactoring error (self assignment) introduced by r170488.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
- 10:49 AM Changeset in webkit [170534] by
-
- 3 edits2 adds in trunk
XHR should keep attributes on instance
https://bugs.webkit.org/show_bug.cgi?id=134363
Reviewed by Sam Weinig.
Source/WebCore:
Test: js/dom/xhr-prototype-define-property.html
Having them on the prototype broke some sites due to the fact that these DOM attributes are currently
not configurable. Once we make them configurable, we can move XHR attributes back to the prototype.
- bindings/scripts/CodeGeneratorJS.pm:
(InterfaceRequiresAttributesOnInstanceForCompatibility):
LayoutTests:
Added a new test for defining properties on XHR prototype.
- js/dom/xhr-prototype-define-property-expected.txt: Added.
- js/dom/xhr-prototype-define-property.html: Added.
- 10:06 AM Changeset in webkit [170533] by
-
- 2 edits in trunk/Source/WebCore
removeCodedFrames should modify ref to TrackBuffer no a copy.
https://bugs.webkit.org/show_bug.cgi?id=134380
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-27
Reviewed by Daniel Bates.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removeCodedFrames):
Iterate with a reference.
- 9:55 AM Changeset in webkit [170532] by
-
- 2 edits in trunk/Source/WebCore
Set cliprect radius unconditionally in RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=134396
Reviewed by Simon Fraser.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- 9:41 AM Changeset in webkit [170531] by
-
- 8 edits4 adds in trunk
[CSS Grid Layout] Interaction between auto-placement and column / row spanning
https://bugs.webkit.org/show_bug.cgi?id=110633
Reviewed by Sergio Villar Senin.
Source/WebCore:
Modify auto-placement algorithm in order to support span in both
definite and automatic positions.
This patch fixes examples like:
grid-row: auto;
grid-column: 2 / span 3;
And also:
grid-row: auto;
grid-column: span 3;
Tests: fast/css-grid-layout/grid-item-auto-placement-automatic-span.html
fast/css-grid-layout/grid-item-auto-placement-definite-span.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::isEmptyAreaEnough): New method that
checks if a grid area is or not empty.
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea): Updated method
that now receives two arguments with the span value in both directions.
(WebCore::RenderGrid::ensureGridSize): Renamed from gridRow(). Adapted
method to grow in both directions at the same time if needed. It ensures
that the grid is big enough to insert a new item.
(WebCore::RenderGrid::insertItemIntoGrid): Only leave the method that
receives a GridCoordinate. It uses ensureGridSize() before inserting the
item in the grid.
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator): Ensure that
the grid is big enough to place the largest span for auto-positioned
items.
(WebCore::RenderGrid::createEmptyGridAreaAtSpecifiedPositionsOutsideGrid):
New method that returns a GridCoordinate outside current grid with the
requested dimensions.
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid): Adapted
method to calculate the item's span and use the new version of
nextEmptyGridArea(). If an empty area is not found it uses
createEmptyGridAreaAtSpecifiedPositionsOutsideGrid() to place the item.
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid): Ditto.
(WebCore::RenderGrid::growGrid): Renamed to ensureGridSize().
- rendering/RenderGrid.h: Modify methods headers and add new method
signature.
- rendering/style/GridCoordinate.h:
(WebCore::GridSpan::integerSpan): Add new simple method to return the
span value of a position.
- rendering/style/GridResolvedPosition.cpp:
(WebCore::GridResolvedPosition::resolveGridPositionsFromAutoPlacementPosition):
Implement method to take into account span in auto-placement algorithm.
(WebCore::GridResolvedPosition::adjustGridPositionsFromStyle): Add new
checks related with named grid line spans in auto-positioned items,
which is not allowed according to the spec.
- rendering/style/GridResolvedPosition.h: Update method header.
LayoutTests:
Add new specific test cases for span in auto-placement algorithm.
- fast/css-grid-layout/grid-item-auto-placement-automatic-span-expected.txt: Added.
- fast/css-grid-layout/grid-item-auto-placement-automatic-span.html: Added.
- fast/css-grid-layout/grid-item-auto-placement-definite-span-expected.txt: Added.
- fast/css-grid-layout/grid-item-auto-placement-definite-span.html: Added.
- fast/css-grid-layout/grid-item-spanning-resolution.html: Update test
case now that span in auto-positioned items is supported.
- 9:01 AM Changeset in webkit [170530] by
-
- 3 edits5 adds in trunk
[XHR] open method must uppercase only standard method types
https://bugs.webkit.org/show_bug.cgi?id=134264
Patch by Mahesh Kulkarni <mahesh.kk@samsung.com> on 2014-06-27
Reviewed by Darin Adler.
Source/WebCore:
As per step-5 of http://xhr.spec.whatwg.org/#the-open()-method only
DELETE, PUT, GET, POST, OPTIONS, HEAD are standard. Use other methods as is without case change.
All tests from w3c-test suite pass http://w3c-test.org/XMLHttpRequest/open-method-case-sensitive.htm.
This merges blink changes from r176592.
Tests: http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html
http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod):
LayoutTests:
All tests from w3c-test suite pass http://w3c-test.org/XMLHttpRequest/open-method-case-sensitive.htm.
This merges blink changes from r176592.
- http/tests/xmlhttprequest/resources/echo-request-method.php: Added.
- http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html: Added.
- http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html: Added.
- 8:51 AM Changeset in webkit [170529] by
-
- 2 edits in trunk/Source/WebCore
Increase priority on SharedTimer source.
http://bugs.webkit.org/show_bug.cgi?id=134109
While running webkit on a Debian virtual machine I stumbled upon an issue where JS
setTimeout callbacks were not being properly invoked due to machine limitations and the
usage of a low priority on setTimeout timers.
This patch increases the SharedTimer source priority to use the default glib priority which
fixes the issue, making setTimeout JS calls work properly on the test environment.
Reviewed by Gustavo Noronha Silva.
- platform/gtk/SharedTimerGtk.cpp:
(WebCore::setSharedTimerFireInterval):
- 7:20 AM Changeset in webkit [170528] by
-
- 2 edits in trunk/Source/WebCore
Remove redundant offsetFromAncestor() call from RenderLayer::localClipRect().
https://bugs.webkit.org/show_bug.cgi?id=134378
Reviewed by Simon Fraser.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- 7:00 AM Changeset in webkit [170527] by
-
- 6 edits in trunk/Tools
[EFL] Remove efl-wk2 from baseline search path
https://bugs.webkit.org/show_bug.cgi?id=134391
Reviewed by Gyuyoung Kim.
As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
are merged efl-wk2 search path should be removed.
- Scripts/webkitpy/port/base.py:
(Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
- Scripts/webkitpy/port/efl.py:
(EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
(EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
- 5:10 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 4:33 AM WebKitGTK/2.4.x edited by
- (diff)
- 4:28 AM Changeset in webkit [170526] by
-
- 3 edits in trunk/Source/WebCore
[GTK] 8tracks.com triggers annoying pop-up window/installation of "About protocol source plugin" (GStreamer?)
https://bugs.webkit.org/show_bug.cgi?id=133605
Reviewed by Carlos Garcia Campos.
Don't attempt to load blank URLs with the GStreamer media
player. Those URLs trigger the codec installer which is useless in
this scenario. This patch also renames some of the variables of
the ::load method, as suggested by Carlos.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Check video-sink validity before disconnecting its signal handlers.
(WebCore::MediaPlayerPrivateGStreamer::load): Don't load blank
URLs (about:blank).
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Disconnect repaint handler only if it's valid.
- 12:28 AM Changeset in webkit [170525] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JavaScriptCore] FTL buildfix for EFL platform.
https://bugs.webkit.org/show_bug.cgi?id=133546
Reviewed by Darin Adler.
- ftl/FTLAbstractHeap.cpp:
(JSC::FTL::IndexedAbstractHeap::IndexedAbstractHeap):
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::forStackmaps):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::opposite):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Constant::dump):
- llvm/InitializeLLVMPOSIX.cpp:
(JSC::initializeLLVMPOSIX):
- 12:27 AM Changeset in webkit [170524] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Expose getter and setter functions for attributes named type
https://bugs.webkit.org/show_bug.cgi?id=134300
Reviewed by Martin Robinson.
We skip those because the getter conflicts with the get_type()
function of all GObjects. We should use a different name for them. As
a general rule we use the last word of the class name, something like:
webkit_dom_blob_get_type() -> webkit_dom_blob_get_blob_type()
webkit_dom_event_get_type() -> webkit_dom_event_get_event_type()
It's consistent with other existing DOM methods like
webkit_dom_xpath_result_get_result_type() or webkit_dom_css_value_get_css_value_type().
This patch also adds some exceptions for particular cases.
- bindings/gobject/webkitdom.symbols: Add new public symbols.
- bindings/scripts/CodeGeneratorGObject.pm:
(GetFunctionSigName): Helper function to return the function name
that takes into account all exceptions when generating getters and
setters of attributes named type. Otherwise the name is returned unmodified.
(GenerateFunction): Use GetFunctionSigName().
(GenerateFunctions): Do not skip functions for type attributes.
- 12:18 AM Changeset in webkit [170523] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary #include in HistoryController
https://bugs.webkit.org/show_bug.cgi?id=134369
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2014-06-27
Reviewed by Daniel Bates.
After the landing of https://webkit.org/b/130099, HistoryController doesn't need
WebCore::Settings class. So we can remove the related header.
- loader/HistoryController.cpp:
Jun 26, 2014:
- 11:16 PM Changeset in webkit [170522] by
-
- 3 edits in trunk/Websites/webkit.org
Remove Qt instructions from http://www.webkit.org/building/tools.html
https://bugs.webkit.org/show_bug.cgi?id=134384
Reviewed by Tim Horton.
- building/tools.html:
- css/main.css:
(.mac-instructions, .unix-instructions, .windows-instructions, .gtk-instructions, .efl-instructions):
(.mac-instructions, .unix-instructions, .windows-instructions, .gtk-instructions, .qt-instructions, .efl-instructions): Deleted.
- 11:06 PM Changeset in webkit [170521] by
-
- 2 edits in trunk/Tools
prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
https://bugs.webkit.org/show_bug.cgi?id=134387
Reviewed by Tim Horton.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
- 10:35 PM Changeset in webkit [170520] by
-
- 2 edits in trunk/Tools
prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
https://bugs.webkit.org/show_bug.cgi?id=134383
Reviewed by Tim Horton.
- Scripts/prepare-ChangeLog:
(method_decl_to_selector): Strip out the return type and parameter types before splitting at
colons.
- 10:33 PM Changeset in webkit [170519] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION (r170287): SVGDocumentExtensions::rebuildElements() called on removed element
https://bugs.webkit.org/show_bug.cgi?id=134304
Patch by Jeongeun Kim <je_julie.kim@samsung.com> on 2014-06-26
Reviewed by Daniel Bates.
Roll out <http://trac.webkit.org/170287> (https://bugs.webkit.org/show_bug.cgi?id=134186)
as it led to SVGDocumentExtensions::rebuildElements() being called on an element(s) that
may no longer be in the document.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
- dom/Document.cpp:
(WebCore::Document::commonTeardown):
(WebCore::Document::implicitClose):
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::startAnimations):
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::rebuildElements):
- svg/SVGDocumentExtensions.h:
- 9:31 PM Changeset in webkit [170518] by
-
- 4 edits2 adds in trunk
[iOS][WK2] Distant focusable element may not be scrolled into view when focused using keyboard
https://bugs.webkit.org/show_bug.cgi?id=134309
<rdar://problem/17427385>
Reviewed by Darin Adler.
.:
Add a manual test to ensure that we scroll to a distant focused text field when it's focused
using the keyboard.
- ManualTests/ios/scroll-to-distant-keyboard-focused-text-field.html: Added.
Source/WebKit2:
Fixes an issue where the focusable element may not be scrolled into view when it's focused by
using the keyboard accessory (i.e. the < and > buttons). In particular, we don't scroll a
keyboard focused text field into view when it's positioned significantly outside the visible region.
- UIProcess/ios/WKContentViewInteraction.h: Added an instance variable called _didAccessoryTabInitiateFocus
to track whether an accessory tab initiated the focus of the focusable element.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]): Clear _didAccessoryTabInitiateFocus so that we're in a good state
should the WebProcess crash between the time the UIProcess receives the accessory tab request and the
WebProcess calls back to the UIProcess to zoom/scroll to the newly focused element.
(-[WKContentView _displayFormNodeInputView]): Modified to pass an empty rectangle for the selection
rectangle to -_zoomToFocusRect to avoid constraining the scroll to the newly focused element when it
was focused using the keyboard accessory tab buttons
(-[WKContentView accessoryTab:]): Modified to set _didAccessoryTabInitiateFocus to YES. We'll set
this boolean to NO in -_displayFormNodeInputView.
- 8:20 PM Changeset in webkit [170517] by
-
- 3 edits6 adds in trunk
iOS 8 beta 2 ES6 'Set' clear() broken
https://bugs.webkit.org/show_bug.cgi?id=134346
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
The object map was not cleared :(.
Kudos to Ashley Gullen for tracking this and making a regression test.
Credit to Oliver for finding the missing code.
- runtime/MapData.h:
(JSC::MapData::clear):
LayoutTests:
- js/script-tests/set-clear.js: Added.
- js/set-clear-expected.txt: Added.
- js/set-clear.html: Added.
- 7:43 PM Changeset in webkit [170516] by
-
- 2 edits in trunk/Tools
MiniBrowser should support a preference to override the default URL
https://bugs.webkit.org/show_bug.cgi?id=134373
Reviewed by Darin Adler.
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
overriding the default URL, and use it if there is.
- 7:11 PM Changeset in webkit [170515] by
-
- 4 edits in trunk/Source/WebKit2
[iOS][WK2] Implement WKPDFView smart magnification
https://bugs.webkit.org/show_bug.cgi?id=134269
<rdar://problem/17272825>
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _currentContentView]):
(contentZoomScale):
Factor _currentContentView out of contentZoomScale.
(-[WKWebView _zoomToRect:WebCore::atScale:origin:WebCore::]):
(-[WKWebView _scrollToRect:WebCore::origin:WebCore::minimumScrollDistance:]):
(-[WKWebView _contentRectForUserInteraction]):
Use it in a bunch more places so we query the right view when zooming/scrolling for smart magnification.
- UIProcess/ios/WKPDFView.h:
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView scrollViewDidScroll:]):
(-[WKPDFView _revalidateViews]):
(-[WKPDFView zoom:to:atPoint:kind:]):
(-[WKPDFView resetZoom:]):
Implement zoom:to:atPoint:kind: and resetZoom: UIPDFPageViewDelegate methods.
Convert the rects/points and forward them on to the WKWebView to do the zoom.
resetZoom: doesn't provide the gesture origin, so we zoom out using the view center as our origin.
Avoid parenting new UIPDFPageViews while starting a zoom; they'll end up with a bizarre
animation on them and go flying across the screen (even before _isAnimatingZoom is set).
- 7:05 PM Changeset in webkit [170514] by
-
- 5 edits in trunk/Source
[WK2] Pinch-zoom shadows can overlap headers and footers
https://bugs.webkit.org/show_bug.cgi?id=134372
<rdar://problem/16004095>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::shadowLayerPositionForFrame):
(WebKit::shadowLayerBoundsForFrame):
Compute the initial shadow layer and shadow bounds exactly as RenderLayerCompositor does
(in updateRootLayerPosition and friends). Also, clip the shadow layer to the old document rect,
otherwise it can extend over top of the header/footers. The content is automatically clipped to
this rect by the root content layer, but the shadow is outside of that.
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToLayers):
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
Pass all of the arguments to constrainScrollPositionForOverhang, not just half of them.
There's still a bug where we constrain incorrectly with header/footer layers, but that
will be addressed elsewhere.
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):
Make use of the new helpers.
- WebCore.exp.in:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
Put header/footer layers in front of the root content layer instead of behind.
Ideally nothing would ever overlap them, but this will give them precedence regardless.
- 6:10 PM Changeset in webkit [170513] by
-
- 2 edits in trunk/Source/WebCore
[Win] Always NULL-terminate the string in createUTF8String()
<http://webkit.org/b/134353>
<rdar://problem/17471783>
Reviewed by Brent Fulgham.
- plugins/PluginView.cpp:
(WebCore::createUTF8String): Pull out CString length into local
variable. Switch to use memcpy. Always NULL-terminate the
string.
- 5:28 PM Changeset in webkit [170512] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Crash in WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered const + 13
https://bugs.webkit.org/show_bug.cgi?id=134367
Reviewed by Darin Adler.
Add a couple of null-checks to protect against methods being called in the brief time
between when the object is created and when it's asked to load.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered):
- 5:27 PM Changeset in webkit [170511] by
-
- 2 edits in trunk/Source/WebCore
Rearrange conditions to find invalid protocol in NavigatorContentUtils::verifyProtocolHandlerScheme()
https://bugs.webkit.org/show_bug.cgi?id=134289
Reviewed by Darin Adler.
If we do early return when there is invalid protocol, we're able to avoid unnecessary call flow.
No new tests, covered by existing tests.
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::verifyProtocolHandlerScheme):
- 4:59 PM Changeset in webkit [170510] by
-
- 2 edits in trunk/Tools
[Win] Fix potential buffer overrun in DLLLauncher
https://bugs.webkit.org/show_bug.cgi?id=134351
<rdar://problem/17469185>
Reviewed by Darin Adler.
- win/DLLLauncher/DLLLauncherMain.cpp: Correct error
in end-of-buffer calculation.
- 4:54 PM Changeset in webkit [170509] by
-
- 7 edits in tags/Safari-538.43/Source
Merged r170503. <rdar://problem/17271965>
- 4:53 PM Changeset in webkit [170508] by
-
- 2 edits in trunk/Source/WebKit2
Don't leak WKBrowsingContextControllers
https://bugs.webkit.org/show_bug.cgi?id=134368
<rdar://problem/17476582>
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKView.mm:
(-[WKView browsingContextController]):
Adoption is important.
- 4:48 PM Changeset in webkit [170507] by
-
- 2 edits in tags/Safari-538.43/Source/WebCore
Merged r170478. <rdar://problem/17309186>
- 4:44 PM Changeset in webkit [170506] by
-
- 2 edits in trunk/Source/WebCore
[WK1] Use native touch event's timestamp for DOM touch event
https://bugs.webkit.org/show_bug.cgi?id=134326
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-26
Reviewed by Enrica Casucci.
- platform/ios/PlatformEventFactoryIOS.mm:
(WebCore::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
Use device event timestamp to get more accurate timing information. This also removes
the variance introduced by WebKit when computing velocity/acceleration/etc.
- 4:43 PM Changeset in webkit [170505] by
-
- 2 edits in tags/Safari-538.43/Source/WebCore
Merged r170485. <rdar://problem/16853657>
- 4:17 PM Changeset in webkit [170504] by
-
- 2 edits in trunk/Source/WebCore
Memcache migth not be pruned when it should for https pages
https://bugs.webkit.org/show_bug.cgi?id=134361
Reviewed by Geoffrey Garen.
There is no reason we should not try to prune in case of a https resource.
No observable change in behavior, no tests.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
Call prune unconditionally and remove an unnecessary branch.
- 4:15 PM Changeset in webkit [170503] by
-
- 7 edits in trunk/Source
REGRESSION: Mountain Lion: Gmail's "in new window" view of mail threads is very slow to load its content
https://bugs.webkit.org/show_bug.cgi?id=133882
<rdar://problem/17271965>
Reviewed by Brady Eidson.
Source/WebCore:
This goes to pre-r161796 behavior on 10.8 and 10.9. We schedule the requests internally,
and only give 6 of them to CFNetwork at a time. Except for synchronous requests,
which still use the improved approach, and don't count against 6 connections.
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleLoad):
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::resourcePrioritiesEnabled):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Deleted.
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
Source/WebKit2:
- NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:
(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):
Same fix as in WebCore.
- 4:07 PM Changeset in webkit [170502] by
-
- 2 edits in trunk/Tools
[EFL] Missing dependency between freetype6 and fontconfig libs.
https://bugs.webkit.org/show_bug.cgi?id=134190
Reviewed by Gyuyoung Kim.
The external dependencies contain the freetype6 and the fontconfig libs.
The fontconfig lib requires freetype, but the dependency is not set in
the efl/jhbuild.modules file. So, during building the external libs,
fontconfig uses the freetype package of the system, while WebKit
binaries will use freetype from the WebKitBuild/Dependency directory.
There are more similar dependencies that were not indicated in the
jhbuild.modules file.
- efl/jhbuild.modules: Added dependencies between libs.
- 4:03 PM Changeset in webkit [170501] by
-
- 2 edits in trunk/Source/WTF
Bump FastMalloc thread cache max size to 1MB on iOS.
<https://webkit.org/b/134365>
The previous limit (512kB) comes from the old days of very-low-memory
devices, and we can now afford to spend another 512kB here.
Note that we already have a mechanism to purge FastMalloc caches on
system memory pressure.
Looks like a ~400ms progression on PLT.
Reviewed by Geoff Garen.
- wtf/FastMalloc.cpp:
- 3:37 PM Changeset in webkit [170500] by
-
- 22 edits5 moves1 delete in trunk/Source
Remove use of PlatformStrategies for Gamepad API.
https://bugs.webkit.org/show_bug.cgi?id=134348
Source/WebCore:
Reviewed by Dean Jackson.
No new tests (Not yet a tested config)
Introduce a virtual GamepadProvider with a process-global shared provider.
The base implementation of the GamepadProvider does nothing.
- platform/GamepadProvider.cpp: Renamed from Source/WebKit/mac/WebCoreSupport/WebHIDGamepadController.h.
(WebCore::GamepadProvider::shared):
(WebCore::GamepadProvider::setSharedProvider):
(WebCore::GamepadProvider::startMonitoringGamepads):
(WebCore::GamepadProvider::stopMonitoringGamepads):
(WebCore::GamepadProvider::platformGamepads):
- platform/GamepadProvider.h: Renamed from Source/WebCore/platform/GamepadStrategy.h.
(WebCore::GamepadProvider::~GamepadProvider):
- platform/GamepadProviderClient.h: Renamed from Source/WebCore/platform/GamepadStrategyClient.h.
(WebCore::GamepadProviderClient::~GamepadProviderClient):
GamepadManager is now a GamepadProviderClient:
- Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::GamepadManager):
(WebCore::GamepadManager::registerNavigator):
(WebCore::GamepadManager::unregisterNavigator):
- Modules/gamepad/GamepadManager.h:
Remove the GamepadStrategy altogether:
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::gamepadStrategy): Deleted.
Call to the shared GamepadProvider instead of the strategy:
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::gamepads):
(WebCore::NavigatorGamepad::gamepadsBecameVisible):
(WebCore::NavigatorGamepad::gamepadConnected):
HIDGamepadListener is now a subclass of GamepadProvider that implements the HID based management.
LegacyWebKit on Mac will install the shared HIDGamepadProvider instead of the default GamepadProvider:
- platform/mac/HIDGamepadProvider.cpp: Renamed from Source/WebCore/platform/mac/HIDGamepadListener.cpp.
(WebCore::deviceMatchingDictionary):
(WebCore::deviceAddedCallback):
(WebCore::deviceRemovedCallback):
(WebCore::deviceValuesChangedCallback):
(WebCore::HIDGamepadProvider::shared):
(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::indexForNewlyConnectedDevice):
(WebCore::HIDGamepadProvider::startMonitoringGamepads):
(WebCore::HIDGamepadProvider::stopMonitoringGamepads):
(WebCore::HIDGamepadProvider::deviceAdded):
(WebCore::HIDGamepadProvider::deviceRemoved):
(WebCore::HIDGamepadProvider::valuesChanged):
(WebCore::HIDGamepadProvider::removeGamepadForDevice):
- platform/mac/HIDGamepadProvider.h: Renamed from Source/WebCore/platform/mac/HIDGamepadListener.h.
(WebCore::HIDGamepadProvider::platformGamepads):
(WebCore::HIDGamepadProvider::setShouldDispatchCallbacks):
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/HIDGamepad.h: Fix incorrect comment
Source/WebKit:
Reviewed by Dean Jackson.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Reviewed by Dean Jackson.
Remove all the GamepadStrategy gunk:
- WebCoreSupport/WebHIDGamepadController.mm: Removed.
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createGamepadStrategy): Deleted.
(WebPlatformStrategies::startMonitoringGamepads): Deleted.
(WebPlatformStrategies::stopMonitoringGamepads): Deleted.
(WebPlatformStrategies::platformGamepads): Deleted.
Instead, install the HIDGamepadProvider as the shared GamepadProvider:
- WebView/WebView.mm:
(WebKitInitializeGamepadProviderIfNecessary):
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit/win:
Reviewed by Dean Jackson.
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createGamepadStrategy): Deleted.
- WebCoreSupport/WebPlatformStrategies.h:
- 3:22 PM Changeset in webkit [170499] by
-
- 2 edits in trunk/Source/WebCore
Skip memcmp()ing fully downloaded resources after they become mmap()able.
<https://webkit.org/b/134362>
When we receive word that a downloaded resource is now available for mmap()ing
from the file system, we don't need to compare against the buffered data,
since even if there were a mismatch, the cached version should be the canonical one.
This was added as belt-and-suspenders while the supporting mechanism was being
developed in CFNetwork, and there's no evidence of a race today. This change
turns the runtime checks into debug-only assertions.
Saves ~300ms of main thread time on PLT.
Reviewed by Geoff Garen.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::tryReplaceEncodedData):
- 3:18 PM Changeset in webkit [170498] by
-
- 2 edits in trunk/Source/WTF
Define TARGET_OS_IPHONE to 0 for non-darwin ports
https://bugs.webkit.org/show_bug.cgi?id=134347
Reviewed by Darin Adler.
A follow-up to r169880 to make it easier to reason about
the code. The purpose of this change to allow
"#if TARGET_OS_IPHONE" in public header files.
- wtf/Platform.h:
- 3:15 PM Changeset in webkit [170497] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Command-/ (slash) now auto-comments code via CodeMirror 4. Should remove as command to pause
https://bugs.webkit.org/show_bug.cgi?id=134313
Reviewed by Timothy Hatcher.
Changed alternate command to pause/resume from command-slash to command-backslash.
Command-slash sets/unsets comments in all code editors.
- UserInterface/Models/KeyboardShortcut.js: Added Backslash.
- UserInterface/Views/DebuggerSidebarPanel.js: Changed pauseOrResumeAlternateKeyboardShortcut to use Backslash instead of Slash.
- 3:12 PM Changeset in webkit [170496] by
-
- 3 edits in trunk/Source/WebKit/mac
[iOS] Remove User Default for iOS TextField Debugging
https://bugs.webkit.org/show_bug.cgi?id=134356
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-26
Reviewed by Timothy Hatcher.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
- 2:23 PM Changeset in webkit [170495] by
-
- 6 edits in trunk/Source/WebKit2
[iOS] Add API for opting into character selection granularity
https://bugs.webkit.org/show_bug.cgi?id=134354
Reviewed by Geoff Garen.
- Shared/API/Cocoa/WKFoundation.h: Added a definition of WK_ENUM_AVAILABLE_IOS.
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
(WKSelectionGranularity): Added this enum with two values, one representing dynamic
granularity( the current, default behavior) and one representing character granularity.
Delcared new selectionGranularity property.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]): Copy the _selectionGranularity ivar.
- UIProcess/ios/WKContentViewInteraction.mm:
(toUIWebSelectionMode): Added this helper function for mapping WKSelectionGranularity values
to UIWebSelectionMode values.
(-[WKContentView setupInteraction]): Use a selection assistant with the mode specified in
the configuration.
(-[WKContentView _stopAssistingKeyboard]): Ditto.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture): Changed the behavior of the loupe gesture type in
non-editable text to select a word, rather than an empty range, matching the UITextView
behavior.
- 2:14 PM Changeset in webkit [170494] by
-
- 8 edits in tags/Safari-538.43/Source
Fix up for <rdar://problem/17446703>
- 2:07 PM Changeset in webkit [170493] by
-
- 2 edits in tags/Safari-538.43/Source/WebKit2
Merged r170492.
- 1:37 PM Changeset in webkit [170492] by
-
- 2 edits in trunk/Source/WebKit2
Change the target membership of WKBackForwardListPrivate.h from WebKit2 to WebKit.
Rubber-stamped by Dan Bernstein.
- WebKit2.xcodeproj/project.pbxproj:
- 1:17 PM Changeset in webkit [170491] by
-
- 2 edits in trunk/Source/WebKit2
Remove a useless return in WebPageProxyIOS
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-26
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::updateVisibleContentRects):
Darin caught this mistake in r170460.
- 12:37 PM Changeset in webkit [170490] by
-
- 25 edits7 adds in branches/ftlopt/Source/JavaScriptCore
Web Inspector: debugger should be able to show variable types
https://bugs.webkit.org/show_bug.cgi?id=133395
Patch by Saam Barati <sbarati@apple.com> on 2014-06-24
Reviewed by Filip Pizlo.
Increase the amount of type information the VM gathers when directed
to do so. This initial commit is working towards the goal of
capturing, and then showing (via the Web Inspector) type information for all
assignment and load operations. This patch doesn't have the feature fully
implemented, but it ensures the VM has no performance regressions
unless the feature is specifically turned on.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
- bytecode/CodeBlock.h:
- bytecode/Instruction.h:
- bytecode/TypeLocation.h: Added.
(JSC::TypeLocation::TypeLocation):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::emitProfileTypesWithHighFidelity):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitPutByVal):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::isProfilingTypesWithHighFidelity):
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode):
- heap/Heap.cpp:
(JSC::Heap::collect):
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypeForVariableInTextRange):
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/protocol/Runtime.json:
- jsc.cpp:
(GlobalObject::finishCreation):
(functionDumpTypesForAllVariables):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::putToScopeCommon):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- runtime/HighFidelityLog.cpp: Added.
(JSC::HighFidelityLog::initializeHighFidelityLog):
(JSC::HighFidelityLog::~HighFidelityLog):
(JSC::HighFidelityLog::recordTypeInformationForLocation):
(JSC::HighFidelityLog::processHighFidelityLog):
(JSC::HighFidelityLog::actuallyProcessLogThreadFunction):
- runtime/HighFidelityLog.h: Added.
(JSC::HighFidelityLog::HighFidelityLog):
- runtime/HighFidelityTypeProfiler.cpp: Added.
(JSC::HighFidelityTypeProfiler::getTypesForVariableInRange):
(JSC::HighFidelityTypeProfiler::getGlobalTypesForVariableInRange):
(JSC::HighFidelityTypeProfiler::getLocalTypesForVariableInRange):
(JSC::HighFidelityTypeProfiler::insertNewLocation):
(JSC::HighFidelityTypeProfiler::getLocationBasedHash):
- runtime/HighFidelityTypeProfiler.h: Added.
- runtime/Options.h:
- runtime/Structure.cpp:
(JSC::Structure::toStructureShape):
- runtime/Structure.h:
- runtime/SymbolTable.cpp:
(JSC::SymbolTable::SymbolTable):
(JSC::SymbolTable::cloneCapturedNames):
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::uniqueIDForRegister):
(JSC::SymbolTable::globalTypeSetForRegister):
(JSC::SymbolTable::globalTypeSetForVariable):
- runtime/SymbolTable.h:
(JSC::SymbolTable::add):
(JSC::SymbolTable::set):
- runtime/TypeSet.cpp: Added.
(JSC::TypeSet::TypeSet):
(JSC::TypeSet::getRuntimeTypeForValue):
(JSC::TypeSet::addTypeForValue):
(JSC::TypeSet::removeDuplicatesInStructureHistory):
(JSC::TypeSet::seenTypes):
(JSC::TypeSet::dumpSeenTypes):
(JSC::StructureShape::StructureShape):
(JSC::StructureShape::markAsFinal):
(JSC::StructureShape::addProperty):
(JSC::StructureShape::propertyHash):
(JSC::StructureShape::leastUpperBound):
(JSC::StructureShape::stringRepresentation):
- runtime/TypeSet.h: Added.
(JSC::StructureShape::create):
(JSC::TypeSet::create):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::getTypesForVariableInRange):
(JSC::VM::updateHighFidelityTypeProfileState):
(JSC::VM::dumpHighFidelityProfilingTypes):
- runtime/VM.h:
(JSC::VM::isProfilingTypesWithHighFidelity):
(JSC::VM::highFidelityLog):
(JSC::VM::highFidelityTypeProfiler):
(JSC::VM::nextLocation):
(JSC::VM::getNextUniqueVariableID):
- 12:21 PM Changeset in webkit [170489] by
-
- 3 edits in branches/ftlopt/Source/JavaScriptCore
Remove unused instantiation of the WithScope structure.
<https://webkit.org/b/134331>
Reviewed by Oliver Hunt.
The WithScope structure instance is the VM is unused, and is now removed.
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 11:49 AM Changeset in webkit [170488] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Refactoring: Use C++11 for-loops in SourceBuffer.
https://bugs.webkit.org/show_bug.cgi?id=134352
Reviewed by Darin Adler.
Use C++11 style for-loops where appropriate in SourceBuffer now that the
SampleMap ordered objects support them.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime):
(WebCore::SourceBuffer::sourceBufferPrivateFastSeekTimeForMediaTime):
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::validateInitializationSegment):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
- 11:32 AM Changeset in webkit [170487] by
-
- 2 edits in trunk/Source/WebCore
[iOS]: Tapping <button> outside of a form is no longer working
https://bugs.webkit.org/show_bug.cgi?id=134319
<rdar://problem/17213346>
Reviewed by Daniel Bates.
Restore behavior of allowing <button> clicks outside of <form>.
This used to be iOS behavior before it was removed in favor of the
OpenSource (Android?) behavior. Now, willRespondToMouseClickEvents
is only used by iOS, so lets restore the iOS behavior.
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
- 11:31 AM Changeset in webkit [170486] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build-fix. Remove unintentionial rename of MediaTime.h -> MediaTimeHash.h.
- Modules/mediasource/SampleMap.h:
- 11:29 AM Changeset in webkit [170485] by
-
- 2 edits in trunk/Source/WebCore
[iOS] no need to deactivate audio session
https://bugs.webkit.org/show_bug.cgi?id=134350
Reviewed by Jer Noble.
- platform/audio/mac/MediaSessionManagerMac.cpp:
(MediaSessionManager::updateSessionState): Don't bother calling
AudioSession::setActive(false), WebCore's audio session will be deactivated
automatically if another application begins playing audio.
- 11:17 AM Changeset in webkit [170484] by
-
- 4 edits in trunk/Source/WebCore
[MSE] Refactoring: Differentiate between SampleMap decode and presentation order methods
https://bugs.webkit.org/show_bug.cgi?id=134349
Reviewed by Geoffrey Garen.
Refactor SampleMap to clarify the distinction between methods which return decode-order
iterators and ones which retun presentation-order iterators.
Add two classes, PresentationOrderSampleMap and DecodeOrderSampleMap, to contain the actual
MediaTime-to-Sample maps, and move the methods returning presentation-order and decode-order
iterators to each, respectively. Rename the {presentation,decode}{Begin,End}() methods to
begin() and end() so the objects can be used in C++11 for-loops.
Update all the call sites in SourceBuffer to use the new ordered objects.
- Modules/mediasource/SampleMap.cpp:
(WebCore::SampleIsLessThanMediaTimeComparator::operator()): Use new ordered objects.
(WebCore::SampleIsGreaterThanMediaTimeComparator::operator()): Ditto.
(WebCore::SampleMap::clear): Ditto.
(WebCore::SampleMap::addSample): Ditto.
(WebCore::SampleMap::removeSample): Ditto.
(WebCore::PresentationOrderSampleMap::findSampleContainingPresentationTime): Renamed from SampleMap version.
(WebCore::PresentationOrderSampleMap::findSampleAfterPresentationTime): Ditto.
(WebCore::DecodeOrderSampleMap::findSampleWithDecodeTime): Ditto.
(WebCore::PresentationOrderSampleMap::reverseFindSampleContainingPresentationTime): Ditto.
(WebCore::PresentationOrderSampleMap::reverseFindSampleBeforePresentationTime): Ditto.
(WebCore::DecodeOrderSampleMap::reverseFindSampleWithDecodeTime): Ditto.
(WebCore::DecodeOrderSampleMap::findSyncSamplePriorToPresentationTime): Ditto.
(WebCore::DecodeOrderSampleMap::findSyncSamplePriorToDecodeIterator): Ditto.
(WebCore::DecodeOrderSampleMap::findSyncSampleAfterPresentationTime): Ditto.
(WebCore::DecodeOrderSampleMap::findSyncSampleAfterDecodeIterator): Ditto.
(WebCore::PresentationOrderSampleMap::findSamplesBetweenPresentationTimes): Ditto.
(WebCore::PresentationOrderSampleMap::findSamplesWithinPresentationRange): Ditto.
(WebCore::DecodeOrderSampleMap::findDependentSamples): Ditto.
- Modules/mediasource/SampleMap.h:
(WebCore::PresentationOrderSampleMap::begin): Renamed from presentationBegin().
(WebCore::PresentationOrderSampleMap::end): Renamed from presentationEnd().
(WebCore::PresentationOrderSampleMap::rbegin): Renamed from reversePresentationBegin().
(WebCore::PresentationOrderSampleMap::rend): Renamed from reversePresentationEnd().
(WebCore::DecodeOrderSampleMap::begin): Renamed from decodeBegin().
(WebCore::DecodeOrderSampleMap::end): Renamed from decodeEnd().
(WebCore::DecodeOrderSampleMap::rbegin): Renamed from reverseDecodeBegin().
(WebCore::DecodeOrderSampleMap::rend): Renamed from reverseDecodeEnd().
(WebCore::SampleMap::SampleMap): Create new ordered objects.
(WebCore::SampleMap::sizeInBytes): Use new ordered objects.
(WebCore::SampleMap::decodeOrder): Simple accessor.
(WebCore::SampleMap::presentationOrder): Simple accessor.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime): Use new ordered objects.
(WebCore::SourceBuffer::sourceBufferPrivateFastSeekTimeForMediaTime): Ditto.
(WebCore::SourceBuffer::removeCodedFrames): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
(WebCore::SourceBuffer::bufferedSamplesForTrackID): Ditto.
- 10:22 AM Changeset in webkit [170483] by
-
- 18 edits in trunk
[Win] Expose Cache Information to WinLauncher
https://bugs.webkit.org/show_bug.cgi?id=134318
Reviewed by Dean Jackson.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add missing
MemoryStatistics files to the WIndows build.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Copy the
CFDictionaryPropertyBag header to WebKit API directory.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Expose the dictionary accessor for the CFDictionaryPropertyBag.
Source/WebKit/win:
- Interfaces/IWebCoreStatistics.idl: Add missing
API added to WebKit since this was last updated.
- WebCache.cpp:
(WebCache::statistics): Add missing elements for
purgable and purged data.
- WebCoreStatistics.cpp: Provide implementaions.
- WebCoreStatistics.h: Ditto.
Tools:
- WinLauncher/Common.cpp: Update for new dialog.
- WinLauncher/WinLauncher.cpp: Add support for WebCache
and WebCoreStatistics.
- WinLauncher/WinLauncher.h:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
Update for new Cache Dialog.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
WTF.lib
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
for new Dialog.
- 10:01 AM Changeset in webkit [170482] by
-
- 7 edits1 delete in trunk/Source
Add an undo group for each dictated utterance in WebKit
https://bugs.webkit.org/show_bug.cgi?id=134086
Applied review comments from Sam Weinig.
Move the associated USE #define into Platform.h.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- editing/mac/TextUndoInsertionMarkup.h: Removed.
- editing/mac/TextUndoInsertionMarkupMac.h:
Source/WebKit2:
- UIProcess/PageClient.h:
Source/WTF:
- wtf/Platform.h:
- 9:52 AM Changeset in webkit [170481] by
-
- 2 edits in trunk/Tools
[Win] Unreviewed gardening. Use consistent line-endings in file.
- WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
'\r\n' EOL.
- 8:30 AM Changeset in webkit [170480] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::FunctionWhitelist::parseFunctionNamesInFile does not close file
<http://webkit.org/b/134343>
<rdar://problem/17459487>
Reviewed by Michael Saboff.
- dfg/DFGFunctionWhitelist.cpp:
(JSC::DFG::FunctionWhitelist::parseFunctionNamesInFile):
Close the file handle, and log an error on failure.
- 8:00 AM Changeset in webkit [170479] by
-
- 2 edits in trunk/Source/WebCore
[EFL][WK2] Fix Debug Build Error in Webcore module.
https://bugs.webkit.org/show_bug.cgi?id=134345
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-06-26
Reviewed by Zalan Bujtas.
Use static cast to change the type of variable to fix error
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setDrawRange):
- 7:05 AM Changeset in webkit [170478] by
-
- 2 edits in trunk/Source/WebCore
[Mac] allow host application to canonicalize media urls
https://bugs.webkit.org/show_bug.cgi?id=134329
Reviewed by Dean Jackson.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::canonicalURL): New, use NSURLProtocol to canonicalize a URL.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Call canonicalURL.
- 1:20 AM Changeset in webkit [170477] by
-
- 8 edits in tags/Safari-538.43/Source
Merge patch for <rdar://problem/17446703>.
- 12:48 AM Changeset in webkit [170476] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Add padding for future expansion to WebKitDOMEventTargetIface
https://bugs.webkit.org/show_bug.cgi?id=134298
Reviewed by Martin Robinson.
- bindings/gobject/WebKitDOMEventTarget.h:
- 12:45 AM Changeset in webkit [170475] by
-
- 5 edits in trunk/Source/WebCore
[GTK] Add support for constants in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=133983
Reviewed by Martin Robinson.
- bindings/gobject/webkitdom.symbols: Add stable constants.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateHeader): Add constants to the header.
(Generate): Pass the interface object to GenerateHeader to get the constants
(IsInterfaceSymbol): Helper function that returns whether the given
symbol belongs to the interface. Check also constants now.
(ReadStableSymbols): Use IsInterfaceSymbol().
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- 12:30 AM Changeset in webkit [170474] by
-
- 5 edits6 adds in trunk
[CSS Grid Layout] Properly support for z-index on grid items
https://bugs.webkit.org/show_bug.cgi?id=103329
Reviewed by Benjamin Poulain.
From Blink r157620 by <jchaffraix@chromium.org> and r172402 by
<wangxianzhu@chromium.org>.
Source/WebCore:
The specification says that grid should match flexbox and force
grid items to be stacking context if z-index is set, regardless
of 'position'. After this change, this is what happens.
Previously z-index changes of static positioned objects were ignored.
However, z-index is applicable for some static positioned objects,
such as grid items. Ignoring them makes the object not to be properly
painted on z-index change.
As StyleResolver has ensured that z-index is non-auto only if
applicable, RenderStyle::changeRequiresLayerRepaint() should not check
again (with inconsistent conditions).
Tests: fast/css-grid-layout/grid-item-z-index-change-repaint.html
fast/css-grid-layout/grid-item-z-index-stacking-context.html
fast/css-grid-layout/grid-item-z-index-support.html
- css/StyleResolver.cpp:
(WebCore::isDisplayFlexibleOrGridBox): Add new method to check if parent
display is flexbox or grid.
(WebCore::StyleResolver::adjustRenderStyle): Use new method in z-index
condition.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayerRepaint): Move z-index checks
out of non-static positioned objects if.
LayoutTests:
- css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt: Test rebaseline.
- fast/css-grid-layout/grid-item-z-index-change-repaint-expected.html: Added.
- fast/css-grid-layout/grid-item-z-index-change-repaint.html: Added.
- fast/css-grid-layout/grid-item-z-index-stacking-context-expected.html: Added.
- fast/css-grid-layout/grid-item-z-index-stacking-context.html: Added.
- fast/css-grid-layout/grid-item-z-index-support-expected.txt: Added.
- fast/css-grid-layout/grid-item-z-index-support.html: Added.
- 12:25 AM Changeset in webkit [170473] by
-
- 5 edits in trunk/Source
Versioning.
- 12:24 AM Changeset in webkit [170472] by
-
- 1 copy in tags/Safari-538.43
New Tag.
Jun 25, 2014:
- 11:45 PM Changeset in webkit [170471] by
-
- 3 edits in trunk/Source/WebKit2
Don't allow sudden termination while writing to local storage.
https://bugs.webkit.org/show_bug.cgi?id=134254.
<rdar://problem/15093854>.
Reviewed by Darin Adler.
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):
Disable sudden termination when a database update is scheduled.
(WebKit::LocalStorageDatabase::updateDatabase):
Re-enable sudden termination when the update completes.
- UIProcess/Storage/LocalStorageDatabase.h:
- 11:41 PM Changeset in webkit [170470] by
-
- 4 edits in trunk/Tools
[JavaScriptCore] Make build-jsc output format better.
https://bugs.webkit.org/show_bug.cgi?id=133547
Reviewed by Ryosuke Niwa.
- Scripts/build-jsc: Emit built time information on successful builds.
(writeCongrats):
- Scripts/build-webkit: Move formatBuildTime function into webkitdirs.pm.
(cMakeArgsFromFeatures):
(formatBuildTime): Deleted.
- Scripts/webkitdirs.pm:
(formatBuildTime):
- 11:35 PM Changeset in webkit [170469] by
-
- 2 edits in trunk/Source/WebCore
HIDGamepad should use CFIndex when looping
https://bugs.webkit.org/show_bug.cgi?id=134337
Reviewed by Dan Bernstein.
- platform/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::initElementsFromArray): Replace int with CFIndex, and use
a local variable for CFArrayCount.
- 10:28 PM Changeset in webkit [170468] by
-
- 2 edits in trunk/Source/WebCore
Build fix attempt after r170465.
- platform/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::initElementsFromArray):
- 10:25 PM Changeset in webkit [170467] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Radio buttons and checkboxes vanish when redrawn
https://bugs.webkit.org/show_bug.cgi?id=134335
Reviewed by Dan Bernstein.
I screwed up when landing r170343 by moving some code around
which broke the logic. We need to query the animation
state for controls after we draw (both statically and animated).
- platform/mac/ThemeMac.mm:
(WebCore::paintToggleButton): We need to check the state of animation again, after
we draw.
- 10:00 PM Changeset in webkit [170466] by
-
- 11 edits in trunk/Source/WebKit2
[iOS][WK2] Update the long press interactions correctly when an overflow scroll view scrolls
https://bugs.webkit.org/show_bug.cgi?id=134334
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-25
Reviewed by Simon Fraser.
- UIProcess/PageClient.h:
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll):
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollViewWillStartPanGesture):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewWillStartPanGesture): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::overflowScrollViewWillStartPanGesture):
(WebKit::PageClientImpl::overflowScrollViewDidScroll):
(WebKit::PageClientImpl::scrollViewWillStartPanGesture): Deleted.
- UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeWillStartPanGesture):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::overflowScrollViewWillStartPanGesture):
(WebKit::WebPageProxy::overflowScrollViewDidScroll):
(WebKit::WebPageProxy::scrollViewWillStartPanGesture): Deleted.
- 9:49 PM Changeset in webkit [170465] by
-
- 12 edits4 copies4 adds in trunk/Source
Add HID-based gamepad implementation for Mac
https://bugs.webkit.org/show_bug.cgi?id=134324
Reviewed by Dean Jackson.
Source/WebCore:
No new tests (Not yet a tested config)
- Modules/gamepad/Gamepad.cpp:
(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::updateFromPlatformGamepad): Update the Gamepad’s data from the passed-in PlatformGamepad.
- Modules/gamepad/Gamepad.h:
- Modules/gamepad/GamepadButton.h:
(WebCore::GamepadButton::create): Change to use Ref instead of RefPtr.
GamepadManager is a GamepadStrategyClient that receives notifications from the platform gamepad implementation
and forwards them to NavigatorGamepad objects. In the future it will also handle event dispatch and exposing
gamepads to the API layer when a button is pressed:
- Modules/gamepad/GamepadManager.cpp: Added.
(WebCore::GamepadManager::shared):
(WebCore::GamepadManager::GamepadManager):
(WebCore::GamepadManager::platformGamepadConnected):
(WebCore::GamepadManager::platformGamepadDisconnected):
(WebCore::GamepadManager::registerNavigator):
(WebCore::GamepadManager::unregisterNavigator):
- Modules/gamepad/GamepadManager.h:
The NavigatorGamepad supplement actually manages visibility of Gamepads on a per-DOMWindow basis:
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::NavigatorGamepad):
(WebCore::NavigatorGamepad::~NavigatorGamepad):
(WebCore::NavigatorGamepad::from):
(WebCore::NavigatorGamepad::gamepads):
(WebCore::NavigatorGamepad::gamepadsBecameVisible):
(WebCore::NavigatorGamepad::gamepadConnected):
(WebCore::NavigatorGamepad::gamepadDisconnected):
- Modules/gamepad/NavigatorGamepad.h:
(WebCore::NavigatorGamepad::navigationStart):
HIDGamepad is a PlatformGamepad that wraps an IOHIDDeviceRef and keeps input values updated:
- platform/mac/HIDGamepad.cpp: Added.
(WebCore::HIDGamepad::HIDGamepad):
(WebCore::HIDGamepad::initElements):
(WebCore::HIDGamepad::initElementsFromArray):
(WebCore::HIDGamepad::maybeAddButton):
(WebCore::HIDGamepad::maybeAddAxis):
(WebCore::HIDGamepad::valueChanged):
- platform/mac/HIDGamepad.h: Added.
(WebCore::HIDGamepadElement::HIDGamepadElement):
(WebCore::HIDGamepadElement::~HIDGamepadElement):
(WebCore::HIDGamepadElement::isButton):
(WebCore::HIDGamepadElement::isAxis):
(WebCore::HIDGamepadButton::HIDGamepadButton):
(WebCore::HIDGamepadAxis::HIDGamepadAxis):
(WebCore::HIDGamepad::hidDevice):
HIDGamepadListener wraps an IOHIDManagerRef and continuously listens for changes to Gamepad-type
devices plugged in to the system:
- platform/mac/HIDGamepadListener.cpp: Added.
(WebCore::deviceMatchingDictionary):
(WebCore::deviceAddedCallback):
(WebCore::deviceRemovedCallback):
(WebCore::deviceValuesChangedCallback):
(WebCore::HIDGamepadListener::shared):
(WebCore::HIDGamepadListener::HIDGamepadListener):
(WebCore::HIDGamepadListener::indexForNewlyConnectedDevice):
(WebCore::HIDGamepadListener::deviceAdded):
(WebCore::HIDGamepadListener::deviceRemoved):
(WebCore::HIDGamepadListener::valuesChanged):
(WebCore::HIDGamepadListener::removeGamepadForDevice):
- platform/mac/HIDGamepadListener.h: Copied from Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp.
(WebCore::HIDGamepadListenerClient::~HIDGamepadListenerClient):
(WebCore::HIDGamepadListener::setClient):
(WebCore::HIDGamepadListener::platformGamepads):
(WebCore::HIDGamepadListener::setShouldDispatchCallbacks):
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Add a class that acts as an intermediary between the GamepadStrategyClient
and the HIDGamepadListener:
- WebCoreSupport/WebHIDGamepadController.h:
- WebCoreSupport/WebHIDGamepadController.mm:
(WebHIDGamepadController::shared):
(WebHIDGamepadController::WebHIDGamepadController):
(WebHIDGamepadController::gamepadConnected):
(WebHIDGamepadController::gamepadDisconnected):
(WebHIDGamepadController::registerGamepadStrategyClient):
(WebHIDGamepadController::unregisterGamepadStrategyClient):
Implement the strategies by using the HIDGamepadListener:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::startMonitoringGamepads):
(WebPlatformStrategies::stopMonitoringGamepads):
(WebPlatformStrategies::platformGamepads):
- 9:44 PM Changeset in webkit [170464] by
-
- 3 edits in trunk/Source/WebCore
WebProgressTracker updates progress too frequently
https://bugs.webkit.org/show_bug.cgi?id=134185
Reviewed by Tim Horton.
The old code throttled the progress update to when either 100ms has passed or the delta is at least 2%
but this was still not enough in pages that loaded in sub-seconds. The new code always throttles it at 200ms.
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::incrementProgress):
- loader/ProgressTracker.h:
- 9:15 PM Changeset in webkit [170463] by
-
- 4 edits in trunk/Source/WebKit2
[iOS WK2] Page jumps when rubber-banding on azuremagazine.com
https://bugs.webkit.org/show_bug.cgi?id=134238
<rdar://problem/16918228>
Reviewed by Benjamin Poulain.
If the scroll view is in the process of rubber-banding when -setContentSize: is called,
it clamps the scroll offsets between zero and the max value, which visibly interrupts the
rubberband. This can easily happen now that we continually send scroll events to the page
on scrolling, especially when pages like azuremagazine.com do fake sticky by toggling
in-flow elements into position:fixed.
Fix by computing the amount of rubber-band before calling -setContentSize:, and then
restoring the contentOffset with the same amount of rubber-band even when the content size
is different, for top/left rubberbands.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:WebKit::]):
- UIProcess/ios/WKScrollView.h:
- UIProcess/ios/WKScrollView.mm:
(-[WKScrollView _currentTopLeftRubberbandAmount]):
(-[WKScrollView _restoreContentOffsetWithRubberbandAmount:]):
(-[WKScrollView _setContentSizePreservingContentOffsetDuringRubberband:]):
- 9:15 PM Changeset in webkit [170462] by
-
- 8 edits in trunk/Source
[iOS WK2] Fixed position elements jump around when zooming
https://bugs.webkit.org/show_bug.cgi?id=134328
<rdar://problem/17447048>
Reviewed by Zalan Bujtas.
If a given remote layer tree commit contains changes of layers for viewport-constrained
objects, then the associated scrolling tree also needs to show that the layers changed,
since we need to re-run the "viewport changed" logic in the UI process to get the
layers correctly positioned for the current zoom level.
The bug was that page scale changes resulted in small "pixel alignment" position
changes which touched layers, but we didn't commit any scrolling tree changes. So
the scrolling tree commit would result in visibly stale layer positions, with no scrolling tree
update to adjust them for the current transient zoom.
Fix by making use of the existing "alignment offset" field in the ViewportConstraints
data, and having RemoteScrollingCoordinatorProxy::connectStateNodeLayers() note that
fixed or sticky layers changed if any properties of fixed or sticky scrolling tree
nodes were updated.
Source/WebCore:
- page/scrolling/ScrollingConstraints.h:
(WebCore::StickyPositionViewportConstraints::operator==):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::pixelAlignmentOffset):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateGeometry):
- platform/graphics/ca/GraphicsLayerCA.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):
Source/WebKit2:
- UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
- 9:15 PM Changeset in webkit [170461] by
-
- 2 edits in trunk/Source/WebCore
[iOS WK2] Tweak the logic used to choose the scale at which position:fixed gets pushed out of view
https://bugs.webkit.org/show_bug.cgi?id=134323
Reviewed by Benjamin Poulain.
Previously we used a fixed scale (1.2x) at which we'd start pushing position:fixed elements
out of the viewport. This worked well on iPad, but terribly on iPhone. Instead, choose a scale
relative to how much of the page is visible width-wise, the threshold being 2/3 of the page width.
The width is clamped to get reasonable behavior on wide pages.
- page/FrameView.cpp:
(WebCore::FrameView::rectForViewportConstrainedObjects):
- 9:15 PM Changeset in webkit [170460] by
-
- 4 edits in trunk/Source/WebKit2
REGRESSION (r170325): UI process crashes in lastCommittedLayerTreeTransactionID() when the Web Content process crashes
https://bugs.webkit.org/show_bug.cgi?id=134284
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-25
Reviewed by Simon Fraser.
The crash was caused by the access to the Drawing Area after the crash.
This lead to discovering another bug: m_lastVisibleContentRectUpdate could have been updated after WebPageProxy::resetState(),
which in turn would prevent valid updates when a new WebProcess is created.
This patch fixes both issues by moving the VisibleContentRectUpdateInfo to be internal to WebPageProxy,
then early return if we get there in an invalid state.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::updateVisibleContentRects):
- 8:59 PM Changeset in webkit [170459] by
-
- 14 edits3 adds in trunk/Source
Add new platform gamepad abstractions
https://bugs.webkit.org/show_bug.cgi?id=134325
Reviewed by Dean Jackson.
Source/WebCore:
No new tests (Not yet a tested config)
- GamepadStrategy lets ports customize the 3 basic behaviors needed for a gamepad implementation to feed the API in WebCore.
- GamepadStrategyClient gives arbitrary objects in WebCore the ability to register for callbacks with the GamepadStrategy.
- PlatformGamepad is a platform-agnostic object that represents the data that feeds into the Gamepad object that is exposed to web content.
The code in this patch is dead as-is, but https://bugs.webkit.org/show_bug.cgi?id=134324
will contain an immediate follow-up patch that uses it.
Makes sense to review them separately.
- WebCore.xcodeproj/project.pbxproj:
- platform/GamepadStrategy.h: Added.
(WebCore::GamepadStrategy::~GamepadStrategy):
- platform/GamepadStrategyClient.h: Added.
(WebCore::GamepadStrategyClient::~GamepadStrategyClient):
- platform/PlatformGamepad.h: Added.
(WebCore::PlatformGamepad::~PlatformGamepad):
(WebCore::PlatformGamepad::id):
(WebCore::PlatformGamepad::lastUpdateTime):
(WebCore::PlatformGamepad::connectTime):
(WebCore::PlatformGamepad::PlatformGamepad):
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::gamepadStrategy):
(WebCore::PlatformStrategies::PlatformStrategies):
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createGamepadStrategy):
(WebPlatformStrategies::startMonitoringGamepads):
(WebPlatformStrategies::stopMonitoringGamepads):
(WebPlatformStrategies::platformGamepads):
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createGamepadStrategy):
- WebCoreSupport/WebPlatformStrategies.h:
Source/WebKit2:
- NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createGamepadStrategy):
- NetworkProcess/NetworkProcessPlatformStrategies.h:
Actually return a GamepadStrategy in WK2 with no implementation for now:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createGamepadStrategy):
(WebKit::WebPlatformStrategies::startMonitoringGamepads):
(WebKit::WebPlatformStrategies::stopMonitoringGamepads):
(WebKit::WebPlatformStrategies::platformGamepads):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 7:39 PM Changeset in webkit [170458] by
-
- 6 edits in trunk/Source/WebCore
Assertion failed: CGPathAddRoundedRect asserts on non-renderable rounded rectangle.
https://bugs.webkit.org/show_bug.cgi?id=134288
Reviewed by Simon Fraser.
Speculative fix. This changeset attempts to address a possible mantissa overflow of radius
when checking whether the rounded rectangle is renderable.
We convert both the radius and the rectangle values to CGFloat(float/double) to perform
this renderable check, instead of always using float.
- platform/graphics/FloatRoundedRect.cpp:
(WebCore::FloatRoundedRect::Radii::scale): Move scale(float, float) from RoundedRect to FloatRoundedRect.
(WebCore::FloatRoundedRect::isRenderable): Add check if radius is >= 0.
- platform/graphics/FloatRoundedRect.h:
- platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::Radii::scale):
(WebCore::RoundedRect::pixelSnappedRoundedRectForPainting): use FloatRoundeRect::Radii.
- platform/graphics/RoundedRect.h:
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::platformAddPathForRoundedRect): use epsilon() to ensure width/height is always >= even with mantissa overflow.
- 7:10 PM Changeset in webkit [170457] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, CMake build fix after r170450
- CMakeLists.txt: Add ProcessAssertion.cpp and ProcessThrottler.cpp.
- UIProcess/ProcessAssertion.cpp: Replace #import with #include.
- 6:34 PM Changeset in webkit [170456] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Rules panel's strikethrough gets confused at -webkit-align-items: flex-start;
https://bugs.webkit.org/show_bug.cgi?id=133515
Reviewed by Timothy Hatcher.
The CSS style declaration text editor uses the author's shortest instance of prefix whitespace
to create an indentation baseline for the style editor. This needs to consider the possibility
that there is no whitespace prefixing one of the rules. Also clarified a FIXME line.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js: Account for zero-length whitespace.
- 6:22 PM Changeset in webkit [170455] by
-
- 2 edits in trunk/Source/WebCore
[MSE] removeCodedFrames() can remove more than it should
https://bugs.webkit.org/show_bug.cgi?id=134320
Reviewed by Geoff Garen.
removeCodedFrames() can remove more samples than it should because it compares an iterator
in presentation timespace to one in decode timespace. Clean up this code by removing frames
in decode order. Rename variables and add comments to make explicit which timespace defines
the iterators being used.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removeCodedFrames):
- 6:04 PM Changeset in webkit [170454] by
-
- 6 edits in trunk/LayoutTests
compositing/visible-rect/iframe-no-layers.html is broken and confusing
https://bugs.webkit.org/show_bug.cgi?id=134317
Reviewed by Simon Fraser.
The test doesn't wait for scrolling to occur and has unnecessary style stanzas.
- compositing/visible-rect/iframe-no-layers.html:
- compositing/visible-rect/resources/subframe-with-layers.html:
- platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/ios-sim/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
- 5:55 PM Changeset in webkit [170453] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Shadow layer is in the wrong place while pinch-zooming
https://bugs.webkit.org/show_bug.cgi?id=134321
Reviewed by Dan Bernstein.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToLayers):
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):
The anchor point of the shadow layer changed, so we no longer need to shift our position to the center.
- 5:52 PM Changeset in webkit [170452] by
-
- 2 edits in trunk/Source/WebKit2
Fixed crashes after r170450.
Reviewed by Tim Horton.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy): Removed iOS platform #ifdef around
initialization of m_throttler.
- 5:51 PM Changeset in webkit [170451] by
-
- 19 edits in trunk/Source
Crash in ScrollingTree::isRubberBandInProgress()
https://bugs.webkit.org/show_bug.cgi?id=134316
-and corresponding-
<rdar://problem/16247911>
Reviewed by Geoffrey Garen.
Source/WebCore:
This crash appears to have been caused by http://trac.webkit.org/changeset/161276
which moved the ScrollingNode creation code from ScrollingTree over to
ScrollingCoordinator. This creates a thread safety issue. In the crashing case, we
believe that the ScrollingCoordinator's ScrollingTree pointer had been null-ed out
even though the ScrollingTree was kept alive by the bind call to propagate
commitNewTreeState() over to the scrolling thread. The fix is to move node
creation back to the ScrollingTree and to use the this pointer to create new
nodes rather than the ScrollingCoordinator's ScrollingTree pointer.
Don't allow ScrollingCoordinator to handle ScrollingTreeNode creation.
- page/scrolling/AsyncScrollingCoordinator.h:
Re-name createNode to createScrollingTreeNode().
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
- page/scrolling/ScrollingTree.h:
Remove this implementation of createNode that called into the
ScrollingCoordinator.
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::createNode): Deleted.
- page/scrolling/ThreadedScrollingTree.h:
Don't allow ScrollingCoordinator to handle ScrollingTreeNode creation.
- page/scrolling/ios/ScrollingCoordinatorIOS.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.mm:
(WebCore::ScrollingCoordinatorIOS::createScrollingTreeNode): Deleted.
Re-name createNode to createScrollingTreeNode, and actually create the nodes here.
- page/scrolling/ios/ScrollingTreeIOS.cpp:
(WebCore::ScrollingTreeIOS::createScrollingTreeNode):
(WebCore::ScrollingTreeIOS::createNode): Deleted.
- page/scrolling/ios/ScrollingTreeIOS.h:
Don't allow ScrollingCoordinator to handle ScrollingTreeNode creation.
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::createScrollingTreeNode): Deleted.
Add the implementation of createScrollingTreeNode() for the Mac to
ScrollingTreeMac since it can create Mac-specific nodes.
- page/scrolling/mac/ScrollingTreeMac.cpp:
(ScrollingTreeMac::createScrollingTreeNode):
- page/scrolling/mac/ScrollingTreeMac.h:
Source/WebKit2:
Move all ScrollingTreeNode creation from ScrollingCoordinator subclasses into
ScrollingTree subclasses.
- UIProcess/Scrolling/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::createScrollingTreeNode):
(WebKit::RemoteScrollingTree::createNode): Deleted.
- UIProcess/Scrolling/RemoteScrollingTree.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::createScrollingTreeNode): Deleted.
- 5:34 PM Changeset in webkit [170450] by
-
- 14 edits1 copy4 moves in trunk/Source/WebKit2
Web process should become active when sent a message that requires a callback
https://bugs.webkit.org/show_bug.cgi?id=134315
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]): Removed one-off code to
acquire an activity token, now that WebPageProxy::takeSnapshot does it automatically for us.
- UIProcess/GenericCallback.h:
(WebKit::CallbackBase::CallbackBase): Made this constructor take and adopt an activity
token.
(WebKit::GenericCallback::create): Added an optional activity token parameter.
(WebKit::GenericCallback::GenericCallback): Pass the activity token to the CallbackBase
constructor.
(WebKit::CallbackMap::put): Added an activity token parameter, which is passed along to
GenericCallback::create.
- UIProcess/ProcessAssertion.cpp: Moved from Source/WebKit2/UIProcess/ios/ProcessAssertion.mm.
This copy includes generic no-op implementations for platforms that don’t have assertions.
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::setState):
- UIProcess/ProcessAssertion.h: Moved from Source/WebKit2/UIProcess/ios/ProcessAssertion.h.
Changed platform #ifdefs to make this usable by all platforms.
- UIProcess/ProcessThrottler.cpp: Moved from Source/WebKit2/UIProcess/ios/ProcessThrottler.mm.
Removed iOS platform #ifdef.
- UIProcess/ProcessThrottler.h: Moved from Source/WebKit2/UIProcess/ios/ProcessThrottler.h.
Ditto.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateCommand): Create a background activity token and pass it
along to CallbackMap::put.
(WebKit::WebPageProxy::runJavaScriptInMainFrame): Ditto.
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation): Ditto.
(WebKit::WebPageProxy::getSourceForFrame): Ditto.
(WebKit::WebPageProxy::getContentsAsString): Ditto.
(WebKit::WebPageProxy::getBytecodeProfile): Ditto.
(WebKit::WebPageProxy::getSelectionOrContentsAsString): Ditto.
(WebKit::WebPageProxy::getSelectionAsWebArchiveData): Ditto.
(WebKit::WebPageProxy::getMainResourceDataOfFrame): Ditto.
(WebKit::WebPageProxy::getResourceDataFromFrame): Ditto.
(WebKit::WebPageProxy::getWebArchiveOfFrame): Ditto.
(WebKit::WebPageProxy::getMarkedRangeAsync): Ditto.
(WebKit::WebPageProxy::getSelectedRangeAsync): Ditto.
(WebKit::WebPageProxy::characterIndexForPointAsync): Ditto.
(WebKit::WebPageProxy::firstRectForCharacterRangeAsync): Ditto.
(WebKit::WebPageProxy::takeSnapshot): Ditto.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::sendProcessWillSuspend): Moved from WebProcessProxyIOS.mm.
(WebKit::WebProcessProxy::sendCancelProcessWillSuspend): Ditto.
(WebKit::WebProcessProxy::processReadyToSuspend): Ditto.
(WebKit::WebProcessProxy::didCancelProcessSuspension): Ditto.
- UIProcess/WebProcessProxy.h: Removed iOS platform #ifdef.
- UIProcess/WebProcessProxy.messages.in: Ditto.
- UIProcess/ios/ProcessAssertionIOS.mm: Renamed from Source/WebKit2/UIProcess/ios/ProcessAssertion.mm.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::selectWithGesture): Changed to pass the function directly to
CallbackMap::put, along with a background activity token.
(WebKit::WebPageProxy::updateSelectionWithTouches): Ditto.
(WebKit::WebPageProxy::requestAutocorrectionData): Ditto.
(WebKit::WebPageProxy::applyAutocorrection): Ditto.
(WebKit::WebPageProxy::requestDictationContext): Ditto.
(WebKit::WebPageProxy::requestAutocorrectionContext): Ditto.
(WebKit::WebPageProxy::selectWithTwoTouches): Ditto.
- UIProcess/ios/WebProcessProxyIOS.mm:
(WebKit::WebProcessProxy::sendProcessWillSuspend): Moved to WebProcessProxy.cpp.
(WebKit::WebProcessProxy::sendCancelProcessWillSuspend): Ditto.
(WebKit::WebProcessProxy::processReadyToSuspend): Ditto.
(WebKit::WebProcessProxy::didCancelProcessSuspension): Ditto.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync): Create a background
activity token and pass it along to CallbackMap::put.
- WebKit2.xcodeproj/project.pbxproj: Updated for moves and copies.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Moved iOS platform #ifdef.
- WebProcess/WebProcess.h: Ditto.
- WebProcess/WebProcess.messages.in: Ditto.
- 5:33 PM Changeset in webkit [170449] by
-
- 2 edits in trunk/Source/WebCore
iOS build fix after http://trac.webkit.org/changeset/170447.
Unreviewed.
- editing/mac/TextUndoInsertionMarkup.h:
- 4:58 PM Changeset in webkit [170448] by
-
- 2 edits in trunk/Source/WebKit/mac
Should _updateVisibilityState on view hide/unhide.
https://bugs.webkit.org/show_bug.cgi?id=134314
rdar://17171803
Reviewed by Sam Weinig.
- WebView/WebView.mm:
(-[WebView viewDidHide]):
(-[WebView viewDidUnhide]):
- 4:50 PM Changeset in webkit [170447] by
-
- 21 edits3 adds in trunk
Add an undo group for each dictated utterance in WebKit
https://bugs.webkit.org/show_bug.cgi?id=134086
Reviewed by Enrica Casucci.
Source/WebCore:
Provide a mechanism for ending the current undo group on a text insertion.
This allows a stream of text, that is normally part of one undo group, to be
broken up so that subsequent undo commands will only undo portions of the text stream.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- editing/mac/TextUndoInsertionMarkup.h: Added.
- editing/mac/TextUndoInsertionMarkup.mm: Added.
(WebCore::shouldRegisterInsertionUndoGroup):
(WebCore::registerInsertionUndoGrouping):
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView validAttributesForMarkedText]):
(-[WebHTMLView insertText:]):
Source/WebKit2:
- UIProcess/API/mac/WKView.mm:
(-[WKView insertText:replacementRange:]):
(-[WKView validAttributesForMarkedText]):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerInsertionUndoGrouping):
(WebKit::WebPageProxy::insertTextAsync):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::registerInsertionUndoGrouping):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::registerInsertionUndoGrouping):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::insertDictatedTextAsync):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::insertTextAsync):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::insertDictatedTextAsync):
Tools:
Create a method for creating attributed strings with the undo insertion marker.
- DumpRenderTree/mac/TextInputController.m:
(+[TextInputController isSelectorExcludedFromWebScript:]):
(+[TextInputController webScriptNameForSelector:]):
(-[TextInputController stringWithUndoGroupingInsertion:]):
- 4:41 PM Changeset in webkit [170446] by
-
- 2 edits in trunk/Websites/webkit.org
[Win] Whoops! DirectX SDK is still needed.
- building/tools.html: Put DirectX instruction back.
- 4:13 PM Changeset in webkit [170445] by
-
- 21 edits2 adds in trunk/Source
[iOS]: WK2 Inspector Node Search
https://bugs.webkit.org/show_bug.cgi?id=134279
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-25
Reviewed by Benjamin Poulain.
Source/WebCore:
- WebCore.exp.in:
Export Node::inspect for WebKit2.
Source/WebKit2:
- UIProcess/ios/WKInspectorNodeSearchGestureRecognizer.h: Added.
- UIProcess/ios/WKInspectorNodeSearchGestureRecognizer.mm: Added.
(-[WKInspectorNodeSearchGestureRecognizer locationInView:]):
(-[WKInspectorNodeSearchGestureRecognizer _processTouches:state:]):
(-[WKInspectorNodeSearchGestureRecognizer touchesBegan:withEvent:]):
(-[WKInspectorNodeSearchGestureRecognizer touchesMoved:withEvent:]):
(-[WKInspectorNodeSearchGestureRecognizer touchesEnded:withEvent:]):
(-[WKInspectorNodeSearchGestureRecognizer touchesCancelled:withEvent:]):
(-[WKInspectorNodeSearchGestureRecognizer reset]):
Gesture recognizer that tracks a single touch, updates as that touch
moves, and ends when that touch is cancelled or ends. The location
of the gesture recognizer is the location of the touch it was tracking.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
Handle the inspector node search gesture recognizer if needed.
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
Helpers to add and remove the default gestures.
(-[WKContentView _enableInspectorNodeSearch]):
(-[WKContentView _disableInspectorNodeSearch]):
When node search is enabled, remove all gesture recognizers and
replace with a single inspector node search gesture recognizer.
Likewise, inverse that when disabled.
(-[WKContentView _inspectorNodeSearchRecognized:]):
Notify the WebProcess of new touch positions during node search.
(-[WKContentView hasSelectablePositionAtPoint:]):
When inspector node search is enabled, disable selection.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::inspectorNodeSearchMovedToPosition):
Send a mouse move to the new location. WebCore will update the highlight.
(WebKit::WebPage::inspectorNodeSearchEndedAtPosition):
Inspect the node at the location.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _enableInspectorNodeSearch]):
(-[WKWebView _disableInspectorNodeSearch]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::enableInspectorNodeSearch):
(WebKit::PageClientImpl::disableInspectorNodeSearch):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::inspectorNodeSearchMovedToPosition):
(WebKit::WebPageProxy::inspectorNodeSearchEndedAtPosition):
(WebKit::WebPageProxy::enableInspectorNodeSearch):
(WebKit::WebPageProxy::disableInspectorNodeSearch):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::didSetSearchingForNode):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::enableInspectorNodeSearch):
(WebKit::WebPage::disableInspectorNodeSearch):
Pass the inspector node search state up from the WebProcess
to the WKContentView in the UIProcess. Likewise some messages
in the reverse direction.
- 3:58 PM Changeset in webkit [170444] by
-
- 10 edits in trunk/Source
Add support for 5-tuple versioning.
Reviewed by David Farler.
- 3:45 PM Changeset in webkit [170443] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] REGRESSION(r170336) - zero tolerance seeks are ignored.
https://bugs.webkit.org/show_bug.cgi?id=134310
Reviewed by Brent Fulgham.
Tests for zero tolerance seeks were inadvertantly reversed in r170336.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
- 3:37 PM Changeset in webkit [170442] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/17448049> REGRESSION (r170254): Input methods don’t work
https://bugs.webkit.org/show_bug.cgi?id=134311
Reviewed by Tim Horton.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getSelectedRangeAsync): Removed code that accidentally put the
callback function into a throwaway EditingRangeCallback.
- 2:59 PM Changeset in webkit [170441] by
-
- 3 edits in trunk/Source/JavaScriptCore
2014-06-25 Geoffrey Garen <ggaren@apple.com>
Build fix.
Unreviewed.
- runtime/JSDateMath.cpp: (JSC::parseDateFromNullTerminatedCharacters):
- runtime/VM.cpp: (JSC::VM::resetDateCache): Use std::numeric_limits instead of QNaN constant since that constant doesn't exist anymore.
- 2:51 PM Changeset in webkit [170440] by
-
- 9 edits3 deletes in trunk
Unreviewed, rolling out r166876.
Caused some ECMA test262 failures
Reverted changeset:
"Date object needs to check for ES5 15.9.1.14 TimeClip limit."
https://bugs.webkit.org/show_bug.cgi?id=131248
http://trac.webkit.org/changeset/166876
- 2:43 PM Changeset in webkit [170439] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Rotating a zoomed PDF leads to weird scrolling behavior
https://bugs.webkit.org/show_bug.cgi?id=134286
Reviewed by Benjamin Poulain.
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView _computePageAndDocumentFrames]):
The WKPDFView frame and scroll view content size need to be scaled.
(-[WKPDFView web_setScrollView:]): Deleted.
(-[WKPDFView web_initWithFrame:webView:]):
Get rid of _documentFrame, and don't set it at initWithFrame: time (it's not useful yet).
- 2:32 PM Changeset in webkit [170438] by
-
- 3 edits in trunk/Source/WebCore
[MSE][Mac] Pause playback when readyState drops below HAVE_FUTURE_DATA, and do not complete seek until it rises above HAVE_METADATA.
https://bugs.webkit.org/show_bug.cgi?id=134306
Reviewed by Eric Carlson.
Pause the synchronizer before seeking, and do not resume the synchronizer until it both reports that the seek completed,
and that the readyState rises above HAVE_METADATA. In every other location where we change the rate of the synchronizer,
gate that rate change on the above.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC): Check shouldBePlaying().
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance): Unset m_seekCompleted.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal): Pause the synchronizer.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setRateDouble): Check shouldBePlaying().
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::shouldBePlaying): Test m_seeking, !m_seekCompleted, and the readyState.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setReadyState): Set m_seekCompleted; check shouldBePlaying() and play if appropriate.
- 2:31 PM Changeset in webkit [170437] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Update monitorSourceBuffers to match recent spec changes
https://bugs.webkit.org/show_bug.cgi?id=134305
Reviewed by Eric Carlson.
In W3C bug #24347, the text for the third clause of Source Buffer Monitoring was updated. Update our
implementation to match the new text.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::monitorSourceBuffers):
- 2:15 PM Changeset in webkit [170436] by
-
- 5 edits in branches/ftlopt/Source/JavaScriptCore
Structure bit fields should have a consistent format
https://bugs.webkit.org/show_bug.cgi?id=134307
Reviewed by Filip Pizlo.
Currently we use C-style bit fields for a number of member variables in Structure to save space.
This makes it difficult to load these fields in the JIT. We should instead use our own bitfield
format to make it easy to load and test these variables in JIT code.
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectNonIndexAccessor):
(JSC::JSObject::reifyStaticFunctionsForDelete):
- runtime/Structure.cpp:
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::add):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData):
(JSC::Structure::cloneRareDataFrom):
(JSC::Structure::getConcurrently):
(JSC::Structure::putSpecificValue):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::visitChildren):
(JSC::Structure::checkConsistency):
- runtime/Structure.h:
(JSC::Structure::isExtensible):
(JSC::Structure::isDictionary):
(JSC::Structure::isUncacheableDictionary):
(JSC::Structure::propertyAccessesAreCacheable):
(JSC::Structure::previousID):
(JSC::Structure::setHasGetterSetterPropertiesWithProtoCheck):
(JSC::Structure::setContainsReadOnlyProperties):
(JSC::Structure::disableSpecificFunctionTracking):
(JSC::Structure::objectToStringValue):
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::setPreviousID):
(JSC::Structure::clearPreviousID):
(JSC::Structure::previous):
(JSC::Structure::rareData):
(JSC::Structure::didTransition): Deleted.
(JSC::Structure::hasGetterSetterProperties): Deleted.
(JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto): Deleted.
(JSC::Structure::setHasGetterSetterProperties): Deleted.
(JSC::Structure::hasNonEnumerableProperties): Deleted.
(JSC::Structure::staticFunctionsReified): Deleted.
(JSC::Structure::setStaticFunctionsReified): Deleted.
- runtime/StructureInlines.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache):
(JSC::Structure::checkOffsetConsistency):
- 2:04 PM Changeset in webkit [170435] by
-
- 29 edits in trunk/Source/WebCore
Use references instead of pointers in RenderTheme.
https://bugs.webkit.org/show_bug.cgi?id=134261
Reviewed by Zalan Bujtas.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::shouldHaveSpinButton):
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::updateAppearance):
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSizeConstraints):
(WebCore::RenderThemeEfl::applyEdjeRTLState):
(WebCore::RenderThemeEfl::isControlStyled):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::supportsFocusRing):
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbSize):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):
(WebCore::RenderThemeEfl::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeEfl::animationDurationForProgressBar):
- platform/efl/RenderThemeEfl.h:
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::supportsFocusRing):
(WebCore::RenderThemeGtk::adjustButtonStyle):
(WebCore::RenderThemeGtk::adjustMenuListStyle):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
(WebCore::adjustSearchFieldIconStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
(WebCore::RenderThemeGtk::adjustSliderTrackStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle):
(WebCore::borderRadiiFromStyle):
(WebCore::RenderThemeGtk::paintMediaSliderTrack):
(WebCore::RenderThemeGtk::paintMediaSliderThumb):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeGtk::adjustProgressBarStyle):
(WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeGtk::animationDurationForProgressBar):
(WebCore::RenderThemeGtk::calculateProgressRect):
- platform/gtk/RenderThemeGtk.h:
- platform/gtk/RenderThemeGtk2.cpp:
(WebCore::setToggleSize):
(WebCore::RenderThemeGtk::setCheckboxSize):
(WebCore::RenderThemeGtk::setRadioSize):
(WebCore::RenderThemeGtk::comboBoxArrowSize):
(WebCore::RenderThemeGtk::getComboBoxPadding):
(WebCore::RenderThemeGtk::popupInternalPaddingLeft):
(WebCore::RenderThemeGtk::popupInternalPaddingRight):
(WebCore::RenderThemeGtk::popupInternalPaddingTop):
(WebCore::RenderThemeGtk::popupInternalPaddingBottom):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::setToggleSize):
(WebCore::RenderThemeGtk::setCheckboxSize):
(WebCore::RenderThemeGtk::setRadioSize):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::popupInternalPaddingLeft):
(WebCore::RenderThemeGtk::popupInternalPaddingRight):
(WebCore::RenderThemeGtk::popupInternalPaddingTop):
(WebCore::RenderThemeGtk::popupInternalPaddingBottom):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::layout):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
- rendering/RenderMediaControls.h:
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::adjustInnerStyle):
(RenderMenuList::computeIntrinsicLogicalWidths):
(RenderMenuList::menuStyle):
- rendering/RenderMeter.cpp:
(WebCore::RenderMeter::updateLogicalWidth):
(WebCore::RenderMeter::computeLogicalHeight):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintOutline):
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::updateAnimationState):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::isControlStyled):
(WebCore::RenderTheme::supportsFocusRing):
(WebCore::RenderTheme::stateChanged):
(WebCore::RenderTheme::adjustCheckboxStyle):
(WebCore::RenderTheme::adjustRadioStyle):
(WebCore::RenderTheme::adjustButtonStyle):
(WebCore::RenderTheme::adjustInnerSpinButtonStyle):
(WebCore::RenderTheme::adjustTextFieldStyle):
(WebCore::RenderTheme::adjustTextAreaStyle):
(WebCore::RenderTheme::adjustMenuListStyle):
(WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::meterSizeForBounds):
(WebCore::RenderTheme::animationRepeatIntervalForProgressBar):
(WebCore::RenderTheme::animationDurationForProgressBar):
(WebCore::RenderTheme::adjustProgressBarStyle):
(WebCore::RenderTheme::shouldHaveSpinButton):
(WebCore::RenderTheme::adjustMediaControlStyle):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSliderThumbSize):
(WebCore::RenderTheme::adjustSearchFieldStyle):
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderTheme::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::supportsHover):
(WebCore::RenderTheme::minimumMenuListSize):
(WebCore::RenderTheme::popupInternalPaddingLeft):
(WebCore::RenderTheme::popupInternalPaddingRight):
(WebCore::RenderTheme::popupInternalPaddingTop):
(WebCore::RenderTheme::popupInternalPaddingBottom):
(WebCore::RenderTheme::popupMenuSize):
(WebCore::RenderTheme::setCheckboxSize):
(WebCore::RenderTheme::setRadioSize):
(WebCore::RenderTheme::setButtonSize):
- rendering/RenderThemeIOS.h:
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustCheckboxStyle):
(WebCore::RenderThemeIOS::isControlStyled):
(WebCore::RenderThemeIOS::adjustRadioStyle):
(WebCore::RenderThemeIOS::popupInternalPaddingRight):
(WebCore::RenderThemeIOS::adjustRoundBorderRadius):
(WebCore::RenderThemeIOS::adjustMenuListButtonStyle):
(WebCore::RenderThemeIOS::adjustSliderTrackStyle):
(WebCore::RenderThemeIOS::adjustSliderThumbSize):
(WebCore::RenderThemeIOS::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeIOS::animationDurationForProgressBar):
(WebCore::RenderThemeIOS::adjustSearchFieldStyle):
(WebCore::RenderThemeIOS::adjustButtonStyle):
(WebCore::RenderThemeIOS::setButtonSize):
(WebCore::RenderThemeIOS::shouldHaveSpinButton):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::controlSizeForFont):
(WebCore::RenderThemeMac::sizeForFont):
(WebCore::RenderThemeMac::sizeForSystemFont):
(WebCore::RenderThemeMac::setSizeFromFont):
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::controlSizeForSystemFont):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::progressBarRectForBounds):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeMac::animationDurationForProgressBar):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::popupInternalPaddingLeft):
(WebCore::RenderThemeMac::popupInternalPaddingRight):
(WebCore::RenderThemeMac::popupInternalPaddingTop):
(WebCore::RenderThemeMac::popupInternalPaddingBottom):
(WebCore::RenderThemeMac::popupMenuSize):
(WebCore::RenderThemeMac::minimumMenuListSize):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::setSearchCellState):
(WebCore::RenderThemeMac::setSearchFieldSize):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::isControlStyled):
(WebCore::RenderThemeSafari::adjustRepaintRect):
(WebCore::RenderThemeSafari::baselinePosition):
(WebCore::RenderThemeSafari::controlSizeForFont):
(WebCore::RenderThemeSafari::sizeForFont):
(WebCore::RenderThemeSafari::sizeForSystemFont):
(WebCore::RenderThemeSafari::setSizeFromFont):
(WebCore::RenderThemeSafari::setFontFromControlSize):
(WebCore::RenderThemeSafari::controlSizeForSystemFont):
(WebCore::RenderThemeSafari::paintCheckbox):
(WebCore::RenderThemeSafari::setCheckboxSize):
(WebCore::RenderThemeSafari::paintRadio):
(WebCore::RenderThemeSafari::setRadioSize):
(WebCore::RenderThemeSafari::setButtonPaddingFromControlSize):
(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::setButtonSize):
(WebCore::RenderThemeSafari::adjustTextFieldStyle):
(WebCore::RenderThemeSafari::adjustTextAreaStyle):
(WebCore::RenderThemeSafari::paintMenuList):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::popupInternalPaddingLeft):
(WebCore::RenderThemeSafari::popupInternalPaddingRight):
(WebCore::RenderThemeSafari::popupInternalPaddingTop):
(WebCore::RenderThemeSafari::popupInternalPaddingBottom):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
(WebCore::RenderThemeSafari::minimumMenuListSize):
(WebCore::RenderThemeSafari::adjustSliderThumbStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbSize):
(WebCore::RenderThemeSafari::setSearchFieldSize):
(WebCore::RenderThemeSafari::adjustSearchFieldStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeSafari::adjustMeterStyle):
(WebCore::RenderThemeSafari::meterSizeForBounds):
(WebCore::RenderThemeSafari::paintMeter):
- rendering/RenderThemeSafari.h:
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::supportsHover):
(WebCore::RenderThemeWin::supportsFocusRing):
(WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWin::setCheckboxSize):
(WebCore::RenderThemeWin::paintTextField):
(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::adjustSliderThumbSize):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWin::adjustMeterStyle):
(WebCore::RenderThemeWin::meterSizeForBounds):
(WebCore::RenderThemeWin::paintMeter):
- rendering/RenderThemeWin.h:
(WebCore::RenderThemeWin::paintCheckbox):
(WebCore::RenderThemeWin::paintRadio):
(WebCore::RenderThemeWin::setRadioSize):
(WebCore::RenderThemeWin::paintTextArea):
(WebCore::RenderThemeWin::popupOptionSupportsTextIndent):
(WebCore::RenderThemeWin::paintSearchFieldDecorationPart):
(WebCore::RenderThemeWin::adjustButtonStyle):
(WebCore::RenderThemeWin::adjustTextFieldStyle):
(WebCore::RenderThemeWin::adjustTextAreaStyle):
(WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
- 1:42 PM Changeset in webkit [170434] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Update the time base of event's timestamp when the system time changes
https://bugs.webkit.org/show_bug.cgi?id=134293
Reviewed by Anders Carlsson.
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::cachedStartupTimeIntervalSince1970): Since events timestamps are absolute time, they also
need to be updated if the system clock changes.
- 12:03 PM Changeset in webkit [170433] by
-
- 20 edits3 adds in trunk
Add all blend modes to feBlend
feBlend should support all blend modes from CSS and Canvas
https://bugs.webkit.org/show_bug.cgi?id=134296
Source/WebCore:
Reviewed by Dean Jackson.
Add all blend modes to <feBlend> (the SVG filter primitive) that are also
supported by HTML Canvas and CSS.
In addition, add "normal" blend mode to HTML Canvas as requested by the
CSS Compositing and Blending specification. (Referenced from HTML Canvas.)
With this change, SVG, CSS and Canvas truly share the same blend modes and
even the same keywords. This is much easier to for web authors.
http://www.w3.org/TR/2014/CR-compositing-1-20140220/#ltblendmodegt
Test: svg/filters/feBlend-all-blendmodes.svg
- platform/graphics/GraphicsTypes.cpp: Reorder blend mode text streams to match
enumeration order. Add a new function to parse blend modes independent of
compositing modes. Add a string "normal" that is supported by CSS, feBlend and
HTML Canvas now.
(WebCore::parseBlendMode):
(WebCore::parseCompositeAndBlendOperator):
- platform/graphics/GraphicsTypes.h: Reorder BlendMode enumeration values to match the SVG JS enumeration for blend modes.
- platform/graphics/cpu/arm/filters/FEBlendNEON.h: Move all software code that is no
longer required by the software path but still used by NEON here.
(WebCore::FEBlend::platformApplySoftware):
(WebCore::FEBlend::platformApplyNEON):
- platform/graphics/filters/FEBlend.cpp:
Use drawImageBuffer() to blend the results of previous filter primitives. This
allows removing more than 60% of the code.
(WebCore::FEBlend::FEBlend):
(WebCore::FEBlend::create):
(WebCore::FEBlend::blendMode):
(WebCore::FEBlend::setBlendMode):
(WebCore::FEBlend::platformApplySoftware):
(WebCore::FEBlend::dump):
(WebCore::FEBlend::externalRepresentation):
(WebCore::feBlendNormal): Deleted.
(WebCore::feBlendMultiply): Deleted.
(WebCore::feBlendScreen): Deleted.
(WebCore::feBlendDarken): Deleted.
(WebCore::feBlendLighten): Deleted.
(WebCore::feBlendUnknown): Deleted.
(WebCore::platformApply): Deleted.
(WebCore::FEBlend::platformApplyGeneric): Deleted.
(WebCore::operator<<): Deleted.
- platform/graphics/filters/FEBlend.h:
- svg/SVGAnimatedEnumeration.cpp: Use the global BlendMode enumeration.
(WebCore::enumerationValueForTargetAttribute):
- svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::SVGFEBlendElement): Use the global BlendMode enumeration.
No new enumeration values added or exposed to SVG DOM as requested by SVG WG.
(WebCore::SVGFEBlendElement::parseAttribute):
- svg/SVGFEBlendElement.h: Replace BlendModeType with global BlendMode enumeration. Remove
blend mode parsing code and use the code in GraphicsTypes instead.
(WebCore::SVGPropertyTraits<BlendMode>::highestEnumValue):
(WebCore::SVGPropertyTraits<BlendMode>::toString):
(WebCore::SVGPropertyTraits<BlendModeType>::highestEnumValue): Deleted.
(WebCore::SVGPropertyTraits<BlendModeType>::toString): Deleted.
(WebCore::SVGPropertyTraits<BlendModeType>::fromString): Deleted.
LayoutTests:
Added tests for new blend modes in feBlend as well as a test for 'normal' blend mode
on HTML Canvas.
Reviewed by Dean Jackson.
- fast/canvas/canvas-blend-image-expected.txt:
- fast/canvas/canvas-blend-solid-expected.txt:
- fast/canvas/script-tests/canvas-blend-image.js: Test 'normal' blend mode in Canvas.
(prepareTestScenario):
- fast/canvas/script-tests/canvas-blend-solid.js: Ditto.
(prepareTestScenario):
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: DRT output is lowercase now.
- platform/mac/svg/filters/feBlend-all-blendmodes-expected.png: Added.
- platform/mac/svg/filters/feBlend-all-blendmodes-expected.txt: Added.
- svg/filters/feBlend-all-blendmodes.svg: Added. Tests all blend modes now supported by feBlend.
- svg/filters/feBlend-invalid-mode.xhtml: Add an upper bound check as well.
- 10:34 AM Changeset in webkit [170432] by
-
- 2 edits in trunk/Tools
Provide javascript aware backtrace script for lldb
https://bugs.webkit.org/show_bug.cgi?id=134276
Reviewed by Jer Noble.
- lldb/lldb_webkit.py:
(lldb_init_module):
(btjs): New scripted command to display a backtrace that shows JavaScript frames with details.
- 10:24 AM Changeset in webkit [170431] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Unreviewed gardening.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Update to
put various files in proper IDE categories.
- 10:00 AM Changeset in webkit [170430] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed iOS build fix after r170425.
- accessibility/AccessibilityProgressIndicator.cpp:
- accessibility/AccessibilityProgressIndicator.h:
- 9:56 AM Changeset in webkit [170429] by
-
- 5 edits2 adds in trunk
AX: Crash at com.apple.WebCore: WebCore::AlternativeTextController::removeDictationAlternativesForMarker + 43
https://bugs.webkit.org/show_bug.cgi?id=134226
Reviewed by Enrica Casucci.
Source/WebCore:
Unchecked access of details pointer in the Document marker led to the crash.
It seems erroneous to allow creation of a DocumentMarker without details when one is expected, because it
carries the dictation context (not just the description).
Also, add in ASSERTs to catch scenarios where a nullptr might be passed in.
Test: platform/mac/editing/input/crash-for-empty-text-alternative.html
- dom/DocumentMarker.cpp:
(WebCore::DocumentMarker::DocumentMarker):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::removeDictationAlternativesForMarker):
LayoutTests:
- platform/mac-wk2/TestExpectations:
Skip test on wk2 because dictation related tests are not yet supported (89401)
- platform/mac/editing/input/crash-for-empty-text-alternative-expected.txt: Added.
- platform/mac/editing/input/crash-for-empty-text-alternative.html: Added.
- 9:37 AM Changeset in webkit [170428] by
-
- 18 edits1 add in trunk/Source
[Win64] ASM LLINT is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=130638
Source/JavaScriptCore:
This patch adds a new LLINT assembler backend for Win64, and implements it.
It makes adjustments to follow the Win64 ABI spec. where it's found to be needed.
Also, LLINT and JIT is enabled for Win64.
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-06-25
Reviewed by Mark Lam.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Added JITStubsMSVC64.asm.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- JavaScriptCore/JavaScriptCore.vcxproj/jsc/jscCommon.props: Increased stack size to avoid stack overflow in tests.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.sh: Generate assembler source file for Win64.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::call): Follow Win64 ABI spec.
- jit/JITStubsMSVC64.asm: Added.
- jit/Repatch.cpp:
(JSC::emitPutTransitionStub): Compile fix.
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator): Follow Win64 ABI spec.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Ditto.
- llint/LLIntOfflineAsmConfig.h: Enable new llint backend for Win64.
- llint/LowLevelInterpreter.asm: Implement new Win64 backend, and follow Win64 ABI spec.
- llint/LowLevelInterpreter64.asm: Ditto.
- offlineasm/asm.rb: Compile fix.
- offlineasm/backends.rb: Add new llint backend for Win64.
- offlineasm/settings.rb: Compile fix.
- offlineasm/x86.rb: Implement new llint Win64 backend.
Source/WTF:
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-06-25
Reviewed by Mark Lam.
- wtf/Platform.h: Enable LLINT and JIT for Win64.
- 8:09 AM Changeset in webkit [170427] by
-
- 2 edits in trunk/Tools
REGRESSION (r170426) Broke two python tests
https://bugs.webkit.org/show_bug.cgi?id=134299
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/port/efl.py:
(EflPort._search_paths): Added search path for efl-wk2.
- 5:25 AM Changeset in webkit [170426] by
-
- 6 edits in trunk/Tools
[EFL] Remove WebKit1 related code from scripts
https://bugs.webkit.org/show_bug.cgi?id=134195
Reviewed by Laszlo Gombos.
After removing WebKit1 from EFL port, still there is some code left related to DumpRenderTree,
EWebLauncher. Also running layout tests does not require adding -2/--webkit-test-runner switch.
- Scripts/run-launcher: MiniBrowser now runs as default without -2 switch.
- Scripts/webkitdirs.pm:
(builtDylibPathForName): Remove reference to libewebkit.so
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options): Script runs WKTR by default.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init): Ditto.
- Scripts/webkitpy/port/efl.py:
(EflPort._search_paths): Remove efl-wk2 from baseline search path.
(EflPort.show_results_html_file): Run MiniBrowser as result viewer.
- 5:04 AM Changeset in webkit [170425] by
-
- 50 edits in trunk
Remove build guard for progress element
https://bugs.webkit.org/show_bug.cgi?id=134292
Reviewed by Benjamin Poulain.
.:
The build flag is no longer needed as it is always on.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
The build flag is no longer needed as it is always on.
No new tests as there is no new behaviour.
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer):
- accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::create):
(WebCore::AccessibilityProgressIndicator::valueForRange):
(WebCore::AccessibilityProgressIndicator::maxValueForRange):
(WebCore::AccessibilityProgressIndicator::minValueForRange):
(WebCore::AccessibilityProgressIndicator::progressElement):
- accessibility/AccessibilityProgressIndicator.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
- css/html.css:
(progress::-webkit-progress-value):
- html/HTMLProgressElement.cpp:
- html/HTMLProgressElement.h:
- html/HTMLProgressElement.idl:
- html/HTMLTagNames.in:
- html/shadow/ProgressShadowElement.cpp:
- html/shadow/ProgressShadowElement.h:
- platform/efl/DefaultTheme/CMakeLists.txt:
- platform/efl/DefaultTheme/default.edc:
- platform/efl/RenderThemeEfl.cpp:
(WebCore::toEdjeGroup):
(WebCore::RenderThemeEfl::applyEdjeRTLState):
(WebCore::RenderThemeEfl::paintProgressBar):
- platform/efl/RenderThemeEfl.h:
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::calculateProgressRect):
- platform/gtk/RenderThemeGtk.h:
- platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::paintProgressBar):
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintProgressBar):
- rendering/RenderObject.h:
(WebCore::RenderObject::isSnapshottedPlugIn):
(WebCore::RenderObject::isProgress):
- rendering/RenderProgress.cpp:
- rendering/RenderProgress.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::progressBarRectForBounds):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintProgressBar):
- rendering/RenderThemeIOS.h:
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintProgressBar):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintProgressBar):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
The build flag is no longer needed as it is always on.
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
LayoutTests:
Remove PROGRESS_ELEMENT from the comment to reflect the change.
- fast/dom/wrapper-classes.html:
- 3:43 AM Changeset in webkit [170424] by
-
- 19 edits in trunk/Source/WebCore
Unreviewed. Update GObject DOM bindings test results after r170422.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(WebKit::wrapTestActiveDOMObject):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(WebKit::wrapTestCallback):
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
(WebKit::wrapTestCustomNamedGetter):
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(WebKit::wrapTestEventConstructor):
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(WebKit::wrapTestEventTarget):
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(WebKit::wrapTestException):
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.cpp:
(WebKit::wrapTestGenerateIsReachable):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(WebKit::wrapTestInterface):
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
(WebKit::wrapTestMediaQueryListListener):
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
(WebKit::wrapTestNamedConstructor):
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(WebKit::wrapTestNode):
- bindings/scripts/test/GObject/WebKitDOMTestNondeterministic.cpp:
(WebKit::wrapTestNondeterministic):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(WebKit::wrapTestObj):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
(WebKit::wrapTestOverloadedConstructors):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(WebKit::wrapTestSerializedScriptValueInterface):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
(WebKit::wrapTestTypedefs):
- bindings/scripts/test/GObject/WebKitDOMattribute.cpp:
(WebKit::wrapattribute):
- bindings/scripts/test/GObject/WebKitDOMreadonly.cpp:
(WebKit::wrapreadonly):
- 3:38 AM Changeset in webkit [170423] by
-
- 19 edits in trunk/Source/WebKit2
[GTK] Windowed plugins visibility doesn't work
https://bugs.webkit.org/show_bug.cgi?id=131487
Reviewed by Anders Carlsson.
Implement plugins visibility changes and add a new message to
notify the UI process when a windowed plugin is shown/hidden to
show/hide the plugin widget.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::visibilityDidChange): Add
implementation to notify the plugin about visibility change.
(WebKit::PluginControllerProxy::windowedPluginVisibilityDidChange):
Send WindowedPluginVisibilityDidChange to the plugin proxy.
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginControllerProxy.messages.in: Add VisibilityDidChange message.
- UIProcess/WebPageProxy.h: Add windowedPluginVisibilityDidChange
to handle WindowedPluginVisibilityDidChange message.
- UIProcess/WebPageProxy.messages.in: Add WindowedPluginVisibilityDidChange message.
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::windowedPluginVisibilityDidChange):
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::createPluginContainer): Do not show the
plugins by default.
(WebKit::WebPageProxy::windowedPluginVisibilityDidChange): Show or hide the plugin widget.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin): Initialize m_isVisible.
(WebKit::NetscapePlugin::visibilityDidChange): Add visible parameter and save it in m_isVisible
member, calling platformVisibilityDidChange() only when it has actually changed.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformVisibilityDidChange): Notify the controller about visibility change.
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::visibilityDidChange): Send VisibilityDidChange message to the plugin controller proxy.
(WebKit::PluginProxy::windowedPluginVisibilityDidChange): Notify the controller about visibility change.
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginProxy.messages.in: Add WindowedPluginVisibilityDidChange message.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin): Also call viewVisibilityDidChange() when the plugin is initialized.
(WebKit::PluginView::setParentVisible): Override this Widget method to update the plugin visibility when parent
widget is shown/hidden.
(WebKit::PluginView::viewVisibilityDidChange): Pass visible parameter to visibilityDidChange().
(WebKit::PluginView::windowedPluginVisibilityDidChange): Send WindowedPluginVisibilityDidChange message to the UI process.
- WebProcess/Plugins/PluginView.h:
Jun 24, 2014:
- 11:54 PM Changeset in webkit [170422] by
-
- 48 edits in trunk
[GTK] Some of DOM bindings macros are misnamed
https://bugs.webkit.org/show_bug.cgi?id=121543
Patch by Tomas Popela <tpopela@redhat.com> on 2014-06-24
Reviewed by Carlos Garcia Campos.
As we are using WebKitDOM as a namespace we should unify all type macros
to have WEBKIT_DOM_TYPE prefix instead of WEBKIT_TYPE_DOM. Also add
more exceptions to decamelize function in GObject bindings generator
to fix the names of bindings for BR, HR, UL, OL, DL and LI elements.
Source/WebCore:
- bindings/gobject/GObjectEventListener.cpp:
(WebCore::GObjectEventListener::handleEvent):
- bindings/gobject/WebKitDOMEventTarget.h:
- bindings/gobject/WebKitDOMNodeFilter.h:
- bindings/gobject/WebKitDOMObject.h:
- bindings/gobject/webkitdom.symbols:
- bindings/scripts/CodeGeneratorGObject.pm:
(decamelize):
(GetParentGObjType):
(GenerateProperty):
(GenerateHeader):
(GenerateCFile):
(GenerateEventTargetIface):
- bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(WebKit::wrapFloat64Array):
- bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(WebKit::wrapTestActiveDOMObject):
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(WebKit::wrapTestCallback):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
(WebKit::wrapTestCustomNamedGetter):
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(WebKit::wrapTestEventConstructor):
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(WebKit::wrapTestEventTarget):
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(WebKit::wrapTestException):
- bindings/scripts/test/GObject/WebKitDOMTestException.h:
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.cpp:
(WebKit::wrapTestGenerateIsReachable):
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
(WebKit::wrapTestMediaQueryListListener):
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
(WebKit::wrapTestNamedConstructor):
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(WebKit::wrapTestNode):
- bindings/scripts/test/GObject/WebKitDOMTestNode.h:
- bindings/scripts/test/GObject/WebKitDOMTestNondeterministic.cpp:
(WebKit::wrapTestNondeterministic):
- bindings/scripts/test/GObject/WebKitDOMTestNondeterministic.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(WebKit::wrapTestObj):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
(WebKit::wrapTestOverloadedConstructors):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
(WebKit::wrapTestTypedefs):
(webkit_dom_test_typedefs_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
- bindings/scripts/test/GObject/WebKitDOMattribute.cpp:
(WebKit::wrapattribute):
- bindings/scripts/test/GObject/WebKitDOMattribute.h:
- bindings/scripts/test/GObject/WebKitDOMreadonly.cpp:
(WebKit::wrapreadonly):
- bindings/scripts/test/GObject/WebKitDOMreadonly.h:
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
- gtk/webkitdom.py:
(WebKitDOMDocGeneratorSections._dom_class_decamelize):
(WebKitDOMDocGeneratorSections.write_section):
- 11:45 PM Changeset in webkit [170421] by
-
- 5 edits in trunk/Source/JavaScriptCore
Add support routines to provide descriptive JavaScript backtraces
https://bugs.webkit.org/show_bug.cgi?id=134278
Reviewed by Mark Lam.
- interpreter/CallFrame.cpp:
(JSC::CallFrame::dump):
(JSC::CallFrame::describeFrame):
- interpreter/CallFrame.h:
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dumpForBacktrace):
- runtime/JSCJSValue.h:
- 11:44 PM Changeset in webkit [170420] by
-
- 2 edits in trunk/Source/WTF
Run the FastMalloc scavenger thread on iOS as well.
<https://webkit.org/b/134287>
<rdar://problem/17446198>
Reviewed by Gavin Barraclough.
- wtf/FastMalloc.cpp:
- 11:31 PM Changeset in webkit [170419] by
-
- 2 edits in trunk/Tools
[EFL] Install Latin Modern Math on the bots
https://bugs.webkit.org/show_bug.cgi?id=134153
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules: Switch back to https://github.com/ for the webkitgtk-test-fonts.
- 9:56 PM Changeset in webkit [170418] by
-
- 13 edits in trunk
Tools: [EFL] [GTK] Use Latin Modern Math in the jhbuild environments.
https://bugs.webkit.org/show_bug.cgi?id=134153
Reviewed by Martin Robinson.
- efl/jhbuild.modules: Use webkitgtk-test-fonts.git instead of the zip archive and upgrade to 0.0.5.
- gtk/jhbuild.modules: Upgrade webkitgtk-test-fonts to 0.0.5.
LayoutTests: [EFL] [GTK] Update the MathML test references.
https://bugs.webkit.org/show_bug.cgi?id=134153
Reviewed by Martin Robinson.
We update the GTK references after the move to Latin Modern Math.
- mathml/presentation/bug95015-expected.html: hide the base X since it is causing antialiasing diff.
- mathml/presentation/bug95015.html: ditto
- platform/efl/TestExpectations: enable some tests again (the references must be updated).
- platform/gtk/TestExpectations: enable OpenType MATH test again, mark mo-stacked-glyphs as failing.
- platform/gtk/mathml/presentation/menclose-notation-default-longdiv-expected.txt: update reference.
- platform/gtk/mathml/presentation/mo-stretch-expected.png: ditto
- platform/gtk/mathml/presentation/mo-stretch-expected.txt: ditto
- platform/gtk/mathml/presentation/roots-expected.png: ditto
- platform/gtk/mathml/presentation/roots-expected.txt: ditto
- 9:30 PM Changeset in webkit [170417] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r170414.
https://bugs.webkit.org/show_bug.cgi?id=134291
the patch added a test that fails on almost every Mac tester
(Requested by rniwa on #webkit).
Reverted changeset:
"Tiles on bottom of screen are not always allocated when
necessary"
https://bugs.webkit.org/show_bug.cgi?id=134272
http://trac.webkit.org/changeset/170414
- 8:13 PM Changeset in webkit [170416] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: clicking "Show All Nodes" button throws TypeError
https://bugs.webkit.org/show_bug.cgi?id=133701
Reviewed by Timothy Hatcher.
The method used for isEventWithinDisclosureTriangle needs to consider the possibility that the
targeted TreeElement isn't contained within the visible DOM, for instance in the case of the
"Show All Nodes" button immediately after it is pressed.
- UserInterface/Views/TreeOutline.js:
(TreeElement.prototype.isEventWithinDisclosureTriangle): Check to make sure TreeElement node is in the visible DOM.
- 6:28 PM Changeset in webkit [170415] by
-
- 2 edits in trunk/Tools
Unreviewed, update my speciality.
- Scripts/webkitpy/common/config/contributors.json:
- 6:25 PM Changeset in webkit [170414] by
-
- 4 edits2 adds in trunk
Tiles on bottom of screen are not always allocated when necessary
https://bugs.webkit.org/show_bug.cgi?id=134272
Reviewed by Simon Fraser.
Source/WebCore:
The initial visibleRect is in the coordinate of the root layer, so its origin
is at the top left of the view. The initial rect we were using doesn't
include the contents inset, so it was too short, which was causing tiles near
the bottom of the screen to not always be allocated if the tile threshold was
close to the bottom of the view. Instead, we want to include the contents
inset size so the visible rect includes the entire view.
GraphicsLayerCA::recursiveCommitChanges() takes care of mapping and cropping
the visible rect into the tiled layer's coordinate system, at which point it
is used for visible tile logic.
Test: platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html
- platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::update):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
LayoutTests:
Apply a content inset, then dump visible rects.
- platform/mac-wk2/tiled-drawing/visible-rect-content-inset-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html: Added.
- 6:19 PM Changeset in webkit [170413] by
-
- 4 edits in trunk/Source/WebCore
InlineTextBox's m_len can be an unsigned (rather than an unsigned short)
https://bugs.webkit.org/show_bug.cgi?id=134173
Reviewed by Daniel Bates.
After Zalan's talks with Kling, it seems that the simple line layout code
might alleviate the need for the space savings in InlineTextBox. Given this,
it would be beneficial to be a little more safe by using unsigneds throughout.
For example, we have code like "void setLen(unsigned len) { m_len = len; }"
which might silently break if given particular inputs.
No new tests because there is no behavior change.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::truncation):
- rendering/RenderTextLineBoxes.cpp:
(WebCore::ellipsisRectForBox):
- 5:56 PM Changeset in webkit [170412] by
-
- 5 edits in trunk/LayoutTests
AX: Remove tight platform expectation coupling form roles-exposed layout test.
https://bugs.webkit.org/show_bug.cgi?id=134123
Reviewed by Chris Fleizach.
Don't enforce platform specific differences in the test itself. This is what the various expectation files are for.
- accessibility/roles-exposed-expected.txt:
- accessibility/roles-exposed.html:
- platform/mac-mountainlion/accessibility/roles-exposed-expected.txt:
- platform/mac/accessibility/roles-exposed-expected.txt:
- 5:53 PM Changeset in webkit [170411] by
-
- 2 edits in trunk/Source/WebCore
Speculative 32-bit Mac build fix after r170402.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence):
- 5:36 PM Changeset in webkit [170410] by
-
- 3 edits in trunk/Websites/webkit.org
[Win] Remove some out-of-date stuff from our instructions.
https://bugs.webkit.org/show_bug.cgi?id=134282
Reviewed by Tim Horton.
- building/build.html: Remove reference to "Platform SDK" which we don't manuall
install anymore (it's part of Visual Studio 2013).
- building/tools.html: We no longer need QuickTime SDK, QuickTime Player, or
the DirectX SDK.
- 5:18 PM Changeset in webkit [170409] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] We should not start potential tap activation unless the tap gesture recognizer succeed
https://bugs.webkit.org/show_bug.cgi?id=134277
<rdar://problem/17439973>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-24
Reviewed by Anders Carlsson.
- UIProcess/ios/WKSyntheticClickTapGestureRecognizer.m:
(-[WKSyntheticClickTapGestureRecognizer setState:]):
We were calling the _gestureRecognizedAction even for failure states. The potential activation work
is not light on the Web Process, we should not start if we don't care about the result.
- 5:15 PM Changeset in webkit [170408] by
-
- 4 edits in trunk/Source/WebKit2
[iOS][WK2] Adopt the C API of UIWebTouchEventsGestureRecognizer for touch event mapping
https://bugs.webkit.org/show_bug.cgi?id=134234
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-24
Reviewed by Tim Horton.
The C API is more efficient and expose properties we will need for other patches. This patch moves from
getting each value independently on UIWebTouchEventsGestureRecognizer to the single structure exposed
by _UIWebTouchEvent.
- Shared/NativeWebTouchEvent.h:
- Shared/ios/NativeWebTouchEventIOS.mm:
(WebKit::convertTouchPhase):
(WebKit::extractWebTouchPoint):
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _webTouchEventsRecognized:]):
- 5:13 PM Changeset in webkit [170407] by
-
- 2 edits in trunk/Source/WebKit/mac
WK1 WebFrameNetworkingContext cleanup: do not instanciate an empty NSString to create an empty WTF::String
https://bugs.webkit.org/show_bug.cgi?id=134222
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-24
Reviewed by Andreas Kling.
- WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::sourceApplicationIdentifier):
- 4:50 PM Changeset in webkit [170406] by
-
- 27 edits in trunk/Source
[iOS]: WK2 Inspector Node Highlighting
https://bugs.webkit.org/show_bug.cgi?id=134257
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-24
Reviewed by Timothy Hatcher.
Source/WebCore:
Some clients want to get highlights with the scroll applied,
others do not. Provide a CoordinateSpace param to be used for
getting a highlight (only used on iOS).
- WebCore.exp.in:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::getHighlight):
- inspector/InspectorController.h:
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::getHighlight):
(WebCore::buildObjectForRendererFragments):
- inspector/InspectorOverlay.h:
(WebCore::Highlight::Highlight):
- testing/Internals.cpp:
(WebCore::Internals::inspectorHighlightRects):
Source/WebKit/mac:
- WebInspector/WebNodeHighlightView.mm:
(-[WebNodeHighlightView layoutSublayers:]):
Source/WebKit2:
- Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Highlight>::encode):
(IPC::ArgumentCoder<Highlight>::decode):
Add a way to encode a WebCore::Highlight struct.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _showInspectorHighlight:WebCore::]):
(-[WKWebView _hideInspectorHighlight]):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::showInspectorHighlight):
(WebKit::PageClientImpl::hideInspectorHighlight):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::showInspectorHighlight):
(WebKit::WebPageProxy::hideInspectorHighlight):
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight):
(WebKit::WebInspectorClient::hideHighlight):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::showInspectorHighlight):
(WebKit::WebPage::hideInspectorHighlight):
Send web process highlight / hideHighlight messages up to
the UIProcess so it can highlight in the WKContentView.
Pass up a WebCore::Highlight in Document coordinates.
- UIProcess/ios/WKContentView.h:
- UIProcess/ios/WKContentView.mm:
(-[WKInspectorHighlightView initWithFrame:]):
(-[WKInspectorHighlightView dealloc]):
(-[WKInspectorHighlightView _removeAllLayers]):
(-[WKInspectorHighlightView _createLayers:]):
(findIntersectionOnLineBetweenPoints):
(quadIntersection):
(layerPathWithHole):
(layerPath):
(-[WKInspectorHighlightView _layoutForNodeHighlight:]):
(-[WKInspectorHighlightView _layoutForRectsHighlight:]):
(-[WKInspectorHighlightView update:]):
Reuse the WebKit1 code to turn highlight float quads into CAShapeLayers.
(-[WKContentView _showInspectorHighlight:WebCore::]):
(-[WKContentView _hideInspectorHighlight]):
Show and hide the highlight view with the respective WebCore::Highlight.
- 4:39 PM Changeset in webkit [170405] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Uncaught exception when deallocating AVSampleBufferDisplayLayer
https://bugs.webkit.org/show_bug.cgi?id=134281
Reviewed by Brent Fulgham.
AVSampleBufferDisplayLayer is throwing an exception from its -dealloc method because KVO observers exist
at the time of dealloc. Remove the observer for outputObscuredDueToInsufficientExternalProtection inside
-stopObservingLayer.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener stopObservingLayer:]):
- 4:33 PM Changeset in webkit [170404] by
-
- 3 edits4 adds in trunk
WKContextHistoryClient::didNavigateWithNavigationData is passed incorrect URL when history.pushState is used
<https://webkit.org/b/134271> / <rdar://problem/16270167>
Reviewed by Brady Eidson.
Source/WebCore:
Tests: http/tests/globalhistory/history-delegate-pushstate.html
http/tests/globalhistory/history-delegate-replacestate.html
- page/History.cpp:
(WebCore::History::stateObjectAdded): Call HistoryController after updating the document's URL so that the
URL will reflect the destination of the navigation when FrameLoaderClient::updateGlobalHistory is called.
LayoutTests:
- http/tests/globalhistory/history-delegate-pushstate-expected.txt: Added.
- http/tests/globalhistory/history-delegate-pushstate.html: Added.
- http/tests/globalhistory/history-delegate-replacestate-expected.txt: Added.
- http/tests/globalhistory/history-delegate-replacestate.html: Added.
- 4:33 PM Changeset in webkit [170403] by
-
- 4 edits in trunk/Source/WebKit2
Simplify decodeLegacySessionState
https://bugs.webkit.org/show_bug.cgi?id=134280
Reviewed by Andreas Kling.
There's no need to use a LegacySessionStateDecoder object with a single member,
just make all functions static and only export a single entry point; decodeLegacySessionState.
No functionality change, just moving code around.
- UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateCreateFromData):
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeSessionHistoryEntryData):
(WebKit::decodeSessionHistoryEntry):
(WebKit::decodeSessionHistoryEntries):
(WebKit::decodeV0SessionHistory):
(WebKit::decodeV1SessionHistory):
(WebKit::decodeSessionHistory):
(WebKit::decodeLegacySessionState):
(WebKit::LegacySessionStateDecoder::LegacySessionStateDecoder): Deleted.
(WebKit::LegacySessionStateDecoder::~LegacySessionStateDecoder): Deleted.
(WebKit::LegacySessionStateDecoder::decodeSessionState): Deleted.
(WebKit::LegacySessionStateDecoder::decodeSessionHistory): Deleted.
(WebKit::LegacySessionStateDecoder::decodeV0SessionHistory): Deleted.
(WebKit::LegacySessionStateDecoder::decodeV1SessionHistory): Deleted.
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntries): Deleted.
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntry): Deleted.
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData): Deleted.
- UIProcess/mac/LegacySessionStateCoding.h:
- 4:32 PM Changeset in webkit [170402] by
-
- 2 edits in trunk/Source/WebCore
advanceByCombiningCharacterSequence() can be simplified
https://bugs.webkit.org/show_bug.cgi?id=133591
Reviewed by Dean Jackson.
Use U16_NEXT() because it already does what we're trying to do.
No new tests because there is no behavior change.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence):
- 4:18 PM Changeset in webkit [170401] by
-
- 2 edits in tags/Safari-538.42.1/Source/WebKit2
Merged r170385. <rdar://problem/17427740>
- 4:17 PM Changeset in webkit [170400] by
-
- 24 edits in trunk/Source
Enable GAMEPAD in the Mac build, but disabled at runtime.
https://bugs.webkit.org/show_bug.cgi?id=134255
Reviewed by Dean Jackson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- runtime/JSObject.h: Export JSObject::removeDirect() to allow disabling functions at runtime.
Source/WebCore:
No new tests (No changes to a tested config).
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Add the ability to have a function be EnabledAtRuntime by
removing such functions from the prototype if they are disabled.
Change the three new objects and the one new function to be EnabledAtRuntime
- Modules/gamepad/Gamepad.idl:
- Modules/gamepad/GamepadButton.idl:
- Modules/gamepad/GamepadEvent.idl:
- Modules/gamepad/NavigatorGamepad.idl:
Add a RuntimeEnabledFeature for Gamepads:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::gamepadsEnabled):
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences gamepadsEnabled]):
(-[WebPreferences setGamepadsEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetGamepadsEnabled):
(WKPreferencesGetGamepadsEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 4:16 PM Changeset in webkit [170399] by
-
- 10 edits2 moves1 delete in branches/ftlopt/Source
[ftlopt] Renamed DebuggerActivation to DebuggerScope.
<https://webkit.org/b/134273>
Reviewed by Michael Saboff.
Source/JavaScriptCore:
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- debugger/DebuggerActivation.cpp: Removed.
- debugger/DebuggerActivation.h: Removed.
- debugger/DebuggerScope.cpp: Copied from ../../trunk/Source/JavaScriptCore/debugger/DebuggerActivation.cpp.
(JSC::DebuggerScope::DebuggerScope):
(JSC::DebuggerScope::finishCreation):
(JSC::DebuggerScope::visitChildren):
(JSC::DebuggerScope::className):
(JSC::DebuggerScope::getOwnPropertySlot):
(JSC::DebuggerScope::put):
(JSC::DebuggerScope::deleteProperty):
(JSC::DebuggerScope::getOwnPropertyNames):
(JSC::DebuggerScope::defineOwnProperty):
(JSC::DebuggerActivation::DebuggerActivation): Deleted.
(JSC::DebuggerActivation::finishCreation): Deleted.
(JSC::DebuggerActivation::visitChildren): Deleted.
(JSC::DebuggerActivation::className): Deleted.
(JSC::DebuggerActivation::getOwnPropertySlot): Deleted.
(JSC::DebuggerActivation::put): Deleted.
(JSC::DebuggerActivation::deleteProperty): Deleted.
(JSC::DebuggerActivation::getOwnPropertyNames): Deleted.
(JSC::DebuggerActivation::defineOwnProperty): Deleted.
- debugger/DebuggerScope.h: Copied from ../../trunk/Source/JavaScriptCore/debugger/DebuggerActivation.h.
(JSC::DebuggerScope::create):
(JSC::DebuggerActivation::create): Deleted.
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
Source/WebCore:
No new tests.
- ForwardingHeaders/debugger/DebuggerActivation.h: Removed.
- Removed because this is not used.
Source/WebKit/mac:
- WebView/WebScriptDebugDelegate.mm:
- Removed unneeded #include.
- 3:56 PM Changeset in webkit [170398] by
-
- 3 edits2 adds in trunk
CSS JIT: Add positionInRootFragments to SelectorFragment
https://bugs.webkit.org/show_bug.cgi?id=133609
Reviewed by Benjamin Poulain.
Some non-backtrack-related predicates use relationToRightFragment information
to decide whether checkingContext->elementStyle should be refered.
To make it works correctly, add the positionInRootFragments field to SelectorFragment.
When positionInRootFragments == Rightmost and relationToRightFragment == Rightmost,
we should see checkingContext->elementStyle.
Source/WebCore:
Test: fast/selectors/first-child-update-with-renderer.html
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::shouldUseRenderStyleFromCheckingContext):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
LayoutTests:
- fast/selectors/first-child-update-with-renderer-expected.txt: Added.
- fast/selectors/first-child-update-with-renderer.html: Added.
- 3:38 PM Changeset in webkit [170397] by
-
- 2 edits in trunk/Source/WebCore
[Fullscreen][Mac] WKView is not firstResponder after entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=134270
Reviewed by Jon Honeycutt.
The WebCoreFullScreenWindow's firstResponder is reset when the full screen animation completes and
the window's style is changed to a fullscreen style. Save the firstResponder, and if it's still in
the window's view hierarchy after the style changes, reset it to the firstResponder.
- platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow setStyleMask:]):
- 3:33 PM Changeset in webkit [170396] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Pass AVSampleBufferDisplayLayer HDCP status through to EME
https://bugs.webkit.org/show_bug.cgi?id=134221
Reviewed by Eric Carlson.
Pass the outputObscuredDueToInsufficientExternalProtection property of AVSampleBufferDisplayLayer
as an error to the associated MediaKeySession object.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener invalidate]):
(-[WebAVSampleBufferErrorListener beginObservingLayer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
- 3:32 PM Changeset in webkit [170395] by
-
- 3 edits in trunk/Source/WebKit2
Add support for v0 legacy decoding
https://bugs.webkit.org/show_bug.cgi?id=134275
Reviewed by Andreas Kling.
- Shared/SessionState.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeV0SessionHistory):
(WebKit::LegacySessionStateDecoder::decodeV1SessionHistory):
- 3:24 PM Changeset in webkit [170394] by
-
- 5 edits in trunk/Source/WebKit2
Add SPI for clearing an entire back-forward list
https://bugs.webkit.org/show_bug.cgi?id=134274
Reviewed by Dan Bernstein.
Add -[WKBackForwardList _clear] which only clears the back-forward items, and
change -[WKBackForwardList _removeAllItems] to remove all items including the current one.
- UIProcess/API/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList _removeAllItems]):
(-[WKBackForwardList _clear]):
- UIProcess/API/Cocoa/WKBackForwardListPrivate.h:
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::removeAllItems):
- UIProcess/WebBackForwardList.h:
- 3:02 PM Changeset in webkit [170393] by
-
- 5 edits in trunk/Source/WebKit2
Add iOS specific frame state member variables
https://bugs.webkit.org/show_bug.cgi?id=134268
Reviewed by Andreas Kling.
- Shared/SessionState.cpp:
(WebKit::FrameState::encode):
(WebKit::FrameState::decode):
- Shared/SessionState.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::decodeBackForwardTreeNode):
- WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toFrameState):
(WebKit::applyFrameState):
- 2:18 PM Changeset in webkit [170392] by
-
- 5 edits in tags/Safari-538.42.1/Source
Versioning.
- 2:16 PM Changeset in webkit [170391] by
-
- 1 copy in tags/Safari-538.42.1
New tag.
- 2:04 PM Changeset in webkit [170390] by
-
- 36 edits in trunk/Source/WebCore
Use unsigneds instead of ints for indexes into a string in text layout code
https://bugs.webkit.org/show_bug.cgi?id=133592
Reviewed by Zalan Bujtas.
Migrate much of the text-handling code to use unsigneds for indexes into a string.
No new tests because there is no behavior change.
- WebCore.exp.in:
- platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForText):
(WebCore::computeUnderlineType):
- platform/graphics/Font.h:
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::drawGlyphBuffer):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForSimpleText):
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::size):
(WebCore::GlyphBuffer::glyphs):
(WebCore::GlyphBuffer::advances):
(WebCore::GlyphBuffer::fontDataAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::offsetAt):
(WebCore::GlyphBuffer::reverse):
(WebCore::GlyphBuffer::offsetInString):
(WebCore::GlyphBuffer::swap):
- platform/graphics/GraphicsContext.cpp:
(WebCore::TextRunIterator::atEnd):
- platform/graphics/Latin1TextIterator.h:
(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::currentCharacter):
- platform/graphics/SimpleFontData.h:
- platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::SurrogatePairAwareTextIterator):
- platform/graphics/SurrogatePairAwareTextIterator.h:
(WebCore::SurrogatePairAwareTextIterator::currentCharacter):
- platform/graphics/TextRun.h:
(WebCore::TextRun::length):
(WebCore::TextRun::charactersLength):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::glyphDataForCharacter):
(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):
- platform/graphics/WidthIterator.h:
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::adjustSelectionRectForComplexText):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontWin.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/wince/FontWinCE.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::selectionRectForComplexText):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::selectionState):
(WebCore::adjustCharactersAndLengthForHyphen):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::positionForOffset):
(WebCore::InlineTextBox::constructTextRun):
- rendering/InlineTextBox.h:
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::getStringToRender):
- rendering/RenderCombineText.h:
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::localSelectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGInlineTextBox::paintText):
- rendering/svg/SVGInlineTextBox.h:
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::SVGTextQuery::extentOfCharacterCallback):
(WebCore::SVGTextQuery::characterNumberAtPositionCallback):
- rendering/svg/SVGTextQuery.h:
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::SVGGlyphToPathTranslator):
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
- rendering/svg/SVGTextRunRenderingContext.h:
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontData.h:
- 1:59 PM Changeset in webkit [170389] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: TypeError when hovering over "Show All Nodes" button in the Dom Tree inspector
https://bugs.webkit.org/show_bug.cgi?id=133699
Reviewed by Geoffrey Garen.
The call to element._createTooltipForNode() was failing because element was sometimes not a
DOMTreeOutline but rather only a TreeElement (in the case of the "Show All Nodes" button specifically).
A check for type fixes this issue.
- UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype._onmousemove): Check for presence of _createTooltipForNode.
- 1:56 PM WebKitGTK/2.4.x edited by
- added changeset links for recent entries (diff)
- 1:45 PM Changeset in webkit [170388] by
-
- 2 edits in trunk/Source/WebKit2
iOS WebKit2: block selection tends to prefer block to single words even when the page is zoomed.
https://bugs.webkit.org/show_bug.cgi?id=134267
<rdar://problem/17138059>
Reviewed by Benjamin Poulain.
When trying to find the best selection match for the position where the tap occurs,
we need to take into account the page scale. This patch applies the scale factor
to the selection rect before comparing it with the desired size.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::rangeForWebSelectionAtPosition):
- 1:40 PM Changeset in webkit [170387] by
-
- 3 edits in trunk/Source/WebKit2
Add code to convert HistoryItem to PageState
https://bugs.webkit.org/show_bug.cgi?id=134263
Reviewed by Andreas Kling.
- WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toHTTPBody):
(WebKit::toFrameState):
(WebKit::toPageState):
- WebProcess/WebCoreSupport/SessionStateConversion.h:
- 1:29 PM Changeset in webkit [170386] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION (r169703): Invalid cast in JSC::asGetterSetter / JSC::JSObject::defineOwnNonIndexProperty
https://bugs.webkit.org/show_bug.cgi?id=134046
Reviewed by Filip Pizlo.
- runtime/GetterSetter.h:
(JSC::asGetterSetter):
- runtime/JSObject.cpp:
(JSC::JSObject::defineOwnNonIndexProperty): We need to check for a CustomGetterSetter here as well as
a normal GetterSetter. If we encounter a CustomGetterSetter, we delete it, create a new normal GetterSetter,
and insert it like normal. We also need to check for CustomAccessors when checking for unconfigurable properties.
- 1:18 PM Changeset in webkit [170385] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WebKit2] Disable screen font substitution by default.
<https://webkit.org/b/134266>
<rdar://problem/17427740>
Just like OS X >= 10.9, screen font substitution should be disabled
by default in WebKit2 for iOS.
Reviewed by Anders Carlsson.
- Shared/WebPreferencesDefinitions.h:
- 12:59 PM Changeset in webkit [170384] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processNativeSamples): Cast variadic argument to int.
- 12:52 PM Changeset in webkit [170383] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] PutByIdFlush can also be converted to a PutByOffset so don't assert otherwise
https://bugs.webkit.org/show_bug.cgi?id=134265
Reviewed by Geoffrey Garen.
More assertion fallout from the PutById folding work.
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToPutByOffset):
- 12:51 PM Changeset in webkit [170382] by
-
- 12 edits2 adds in branches/ftlopt/Source/JavaScriptCore
[ftlopt] GC should notify us if it resets to_this
https://bugs.webkit.org/show_bug.cgi?id=128231
Reviewed by Geoffrey Garen.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeList.json:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finalizeUnconditionally):
- bytecode/Instruction.h:
- bytecode/ToThisStatus.cpp: Added.
(JSC::merge):
(WTF::printInternal):
- bytecode/ToThisStatus.h: Added.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- 12:49 PM Changeset in webkit [170381] by
-
- 31 edits in trunk/Source
[Win] MSVC mishandles enums in bitfields
https://bugs.webkit.org/show_bug.cgi?id=134237
Reviewed by Michael Saboff.
Replace uses of enum types in bit fields with unsigned to
avoid losing a bit to hold the sign value. This can result
in Windows interpreting the value of the field improperly.
- bytecode/StructureStubInfo.h:
- parser/Nodes.h:
../WebCore:
- loader/ResourceLoaderOptions.h:
- platform/network/ResourceRequestBase.h:
- platform/network/cf/ResourceResponse.h:
- rendering/RenderLayer.h:
- rendering/RenderMarquee.h:
- 12:38 PM WebKitGTK/2.4.x edited by
- Added 2 AX ATK bugs: 132349, 130941, with necessary 132527. (diff)
- 12:38 PM Changeset in webkit [170380] by
-
- 2 edits in trunk/Source/WebCore
Try to fix build.
- WebCore.exp.in: Remove duplicate export, this should be in the iOS section only.
- 12:35 PM Changeset in webkit [170379] by
-
- 28 edits2 adds in trunk/Source/WebCore
[Mac] process raw VTT in-band captions
https://bugs.webkit.org/show_bug.cgi?id=134178
Reviewed by Jer Noble.
- CMakeLists.txt: Add ISOVTTCue.cpp|h.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- html/track/BufferedLineReader.h:
(WebCore::BufferedLineReader::reset): New, empty the input buffer.
Make it possible to process WebVTT captions.
- html/track/InbandGenericTextTrack.cpp:
(WebCore::InbandGenericTextTrack::parser): Allocate, if necessary, and return a WebVTT parser.
(WebCore::InbandGenericTextTrack::parseWebVTTCueData): Pass a cue to the parser.
(WebCore::InbandGenericTextTrack::parseWebVTTFileHeader): Pass a VTT file header to the parser.
(WebCore::InbandGenericTextTrack::newCuesParsed): Parser callback.
(WebCore::InbandGenericTextTrack::newRegionsParsed): Ditto.
(WebCore::InbandGenericTextTrack::fileFailedToParse): Ditto.
- html/track/InbandGenericTextTrack.h:
- html/track/InbandTextTrack.h:
- html/track/InbandWebVTTTextTrack.cpp:
(WebCore::InbandWebVTTTextTrack::parser): New, parser accessor.
(WebCore::InbandWebVTTTextTrack::parseWebVTTCueData): New, parse VTT data in an ISOWebVTTCue
object.
(WebCore::InbandWebVTTTextTrack::newCuesParsed): Cleanup.
(WebCore::InbandWebVTTTextTrack::newRegionsParsed): Implement.
(WebCore::InbandWebVTTTextTrack::fileFailedToParse): Change the error message.
- html/track/InbandWebVTTTextTrack.h:
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::TextTrackCueGenericBoxElement): Change cue parameter
from a pointer to a reference.
(WebCore::TextTrackCueGeneric::createDisplayTree): Ditto.
- html/track/VTTCue.cpp:
(WebCore::VTTCueBox::create): Change cue parameter from a pointer to a reference.
(WebCore::VTTCueBox::VTTCueBox): Ditto.
(WebCore::VTTCueBox::getCue): Return a reference.
(WebCore::VTTCueBox::applyCSSProperties): m_cue is a reference, not a pointer.
(WebCore::VTTCue::create): New, create a VTTCue from WebVTTCueData.
(WebCore::VTTCue::VTTCue): New, internal constructor that takes a WebVTTCueData.
(WebCore::VTTCue::initialize): New, shared constructor initialization.
(WebCore::VTTCue::createDisplayTree): m_cue is a reference, not a pointer.
(WebCore::VTTCue::markFutureAndPastNodes): Ditto.
(WebCore::VTTCue::setCueSettings): Ditto.
- html/track/VTTCue.h:
(WebCore::VTTCueBox::create): Deleted.
(WebCore::VTTCue::create): Deleted.
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::parseFileHeader): New. Reset the line reader buffer and parser state,
call the parser.
(WebCore::WebVTTParser::parseCueData): Create a cue from ISOWebVTTCue.
(WebCore::WebVTTParser::collectTimingsAndSettings): Return immediately if the string is empty.
(WebCore::WebVTTParser::collectTimeStamp): Ditto.
- html/track/WebVTTParser.h:
(WebCore::WebVTTCueData::originalStartTime): New.
(WebCore::WebVTTCueData::setOriginalStartTime): New.
(WebCore::WebVTTCueData::WebVTTCueData):
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::getNewCues): Cleanup, use the new VTTCue::create.
Parse ISO WebVTT cue boxes.
- platform/graphics/ISOVTTCue.cpp: Added.
(WebCore::ISOBox::ISOBox):
(WebCore::ISOBox::peekType):
(WebCore::ISOBox::peekLength):
(WebCore::ISOBox::peekString):
(WebCore::vttCueBoxType):
(WebCore::vttIdBoxType):
(WebCore::vttSettingsBoxType):
(WebCore::vttPayloadBoxType):
(WebCore::vttCurrentTimeBoxType):
(WebCore::vttCueSourceIDBoxType):
(WebCore::ISOWebVTTCue::boxType):
(WebCore::ISOWebVTTCue::ISOWebVTTCue):
- platform/graphics/ISOVTTCue.h: Added.
(WebCore::ISOBox::boxHeaderSize):
(WebCore::ISOBox::length):
(WebCore::ISOBox::type):
(WebCore::ISOWebVTTCue::presentationTime):
(WebCore::ISOWebVTTCue::duration):
(WebCore::ISOWebVTTCue::sourceID):
(WebCore::ISOWebVTTCue::id):
(WebCore::ISOWebVTTCue::originalStartTime):
(WebCore::ISOWebVTTCue::settings):
(WebCore::ISOWebVTTCue::cueText):
- platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::InbandTextTrackPrivateClient::parseWebVTTFileHeader): New.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF): Add a cue format parameter.
(WebCore::InbandTextTrackPrivateAVF::processCue): Call processNativeSamples.
(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings): Add logging. Minor cleanup.
(WebCore::InbandTextTrackPrivateAVF::processNativeSamples): New, process an array of
CMSampleBuffers, create ISOWebVTTCue from the sample data.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
(WebCore::InbandTextTrackPrivateAVCF::InbandTextTrackPrivateAVCF):
- platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.h:
(WebCore::InbandTextTrackPrivateAVCF::create):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::processMediaSelectionOptions):
(WebCore::LegibleOutputData::LegibleOutputData):
(WebCore::AVFWrapper::processCue):
(WebCore::AVFWrapper::legibleOutputCallback):
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
(WebCore::InbandTextTrackPrivateAVFObjC::create): Add a cue format parameter.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::InbandTextTrackPrivateAVFObjC): Ditto.
- platform/graphics/avfoundation/InbandTextTrackPrivateLegacyAVFObjC.cpp:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::InbandTextTrackPrivateLegacyAVFObjC): Pass cue
format to base class.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Improve logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Don't leak an NSDictionary.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Don't process media selection
options until we have tracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processCue): Pass native samples as well as
attributed strings to track.
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
- platform/graphics/avfoundation/objc/OutOfBandTextTrackPrivateAVF.h:
(WebCore::OutOfBandTextTrackPrivateAVF::OutOfBandTextTrackPrivateAVF):
- platform/graphics/avfoundation/objc/OutOfBandTextTrackPrivateAVF.h:
(WebCore::OutOfBandTextTrackPrivateAVF::OutOfBandTextTrackPrivateAVF):
- 12:18 PM Changeset in webkit [170378] by
-
- 6 edits2 adds in trunk/Source
Add PageState to HistoryItem conversion code
https://bugs.webkit.org/show_bug.cgi?id=134259
Reviewed by Andreas Kling.
Source/WebKit2:
- Shared/SessionState.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeBackForwardTreeNode):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/SessionStateConversion.cpp: Added.
(WebKit::toFormData):
(WebKit::applyFrameState):
(WebKit::toHistoryItem):
- WebProcess/WebCoreSupport/SessionStateConversion.h: Added.
Source/WTF:
- wtf/Optional.h:
(WTF::Optional::valueOr):
- 12:09 PM Changeset in webkit [170377] by
-
- 4 edits in trunk/Source
Only flush layers when the exposed rect actually changes
https://bugs.webkit.org/show_bug.cgi?id=134248
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::setExposedContentRect):
- 12:06 PM Changeset in webkit [170376] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] StructureAbstractValue::onlyStructure() should return nullptr if isClobbered()
https://bugs.webkit.org/show_bug.cgi?id=134256
Reviewed by Michael Saboff.
This isn't testable right now (i.e. it's benign) but we should get it right anyway. The
point is to be able to precisely model what goes on in the snippets of code between a
side-effect and an InvalidationPoint.
This patch also cleans up onlyStructure() by delegating more work to
StructureSet::onlyStructure().
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::onlyStructure):
- 12:04 PM Changeset in webkit [170375] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt][REGRESSION] PutById AI is introducing watchable structures without watching them
https://bugs.webkit.org/show_bug.cgi?id=134260
Reviewed by Geoffrey Garen.
This was causing loads of assertion failures in debug builds.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- 11:23 AM Changeset in webkit [170374] by
-
- 2 edits in trunk/Source/WebCore
Remove references to "Shader.h" which doesn't currently exist in the project.
Rubberstamped by Andreas Kling.
- WebCore.xcodeproj/project.pbxproj:
- 10:44 AM Changeset in webkit [170373] by
-
- 6 edits in trunk/Source
[iOS] DOMWindow::outerWidth and outerHeight don't return useful values, so return 0.
Also, revert r169281.
https://bugs.webkit.org/show_bug.cgi?id=134233
<rdar://problem/17060183>
Reviewed by Benjamin Poulain.
Source/WebCore:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::outerHeight):
(WebCore::DOMWindow::outerWidth):
Source/WebKit2:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::windowFrame): Deleted.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::convertToUserSpace):
- 10:29 AM Changeset in webkit [170372] by
-
- 2 edits in trunk/Source/WebKit/mac
Fixed the iOS build after r170358.
- WebView/WebView.mm:
(kit):
- 10:24 AM Changeset in webkit [170371] by
-
- 2 edits in trunk/Source/WebKit2
Initialize WKWebViewConfiguration properties to their default values.
https://bugs.webkit.org/show_bug.cgi?id=134216
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-24
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
add -init method to initialize _mediaPlaybackRequiresUserAction and _mediaPlaybackAllowsAirPlay.
- 10:20 AM Changeset in webkit [170370] by
-
- 4 edits in trunk/Source/WebCore
Don't set AudioSession active while interrupted.
https://bugs.webkit.org/show_bug.cgi?id=134239
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-24
Reviewed by Eric Carlson.
To activate the AudioSession there must be a session with audio or video
and being playing or paused.
- platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::hasActive): added
(WebCore::MediaSessionManager::beginInterruption): updateSessionState
(WebCore::MediaSessionManager::sessionWillBeginPlayback): updateSessionState
- platform/audio/MediaSessionManager.h: declare hasActive()
- platform/audio/mac/MediaSessionManagerMac.cpp:
(MediaSessionManager::updateSessionState): use hasActive()
- 10:18 AM Changeset in webkit [170369] by
-
- 2 edits in trunk/Source/WebKit2
Add missing semicolon.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateVisibleContentRects]):
- 10:17 AM Changeset in webkit [170368] by
-
- 9 edits in trunk/Source/WebKit/mac
Remove unused history visit code from WebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=134201
Reviewed by Sam Weinig.
- History/HistoryPropertyList.h:
- History/HistoryPropertyList.mm:
(HistoryPropertyListWriter::HistoryPropertyListWriter):
(HistoryPropertyListWriter::writeHistoryItem):
- History/WebHistory.mm:
(-[WebHistoryPrivate visitedURL:withTitle:]):
(-[WebHistoryPrivate addItem:discardDuplicate:]):
(-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
(-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): Deleted.
(-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]): Deleted.
- History/WebHistoryInternal.h:
- History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem initFromDictionaryRepresentation:]):
(-[WebHistoryItem _visitedWithTitle:]):
(-[WebHistoryItem setVisitCount:]): Deleted.
(-[WebHistoryItem _mergeAutoCompleteHints:]): Deleted.
(-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]): Deleted.
(-[WebHistoryItem _recordInitialVisit]): Deleted.
(timeToDay): Deleted.
(-[WebHistoryItem _padDailyCountsForNewVisit:]): Deleted.
(-[WebHistoryItem _collapseDailyVisitsToWeekly]): Deleted.
(-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]): Deleted.
(-[WebHistoryItem _setLastVisitedTimeInterval:]): Deleted.
- History/WebHistoryItemInternal.h:
- History/WebHistoryItemPrivate.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::updateGlobalHistory):
- 10:05 AM Changeset in webkit [170367] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r170336): Crash in HTMLMediaElement::seekTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=134253
Rubber-stamped by Eric Carlson.
Now that seekWithTolerance() has been split up into an asyncronous section, the null-checks in seekWithTolerance()
need to be re-performed in seekTimerFired(), in case the m_player has been cleared between when the seek was initiated
and when the asynchronous section is performed.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::seekTimerFired):
- 9:47 AM Changeset in webkit [170366] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Unreviewed, update my list of email addresses.
- 9:18 AM Changeset in webkit [170365] by
-
- 7 edits5 copies in trunk/Tools
[Win] Clean up and refactor WinLauncher
https://bugs.webkit.org/show_bug.cgi?id=134209
Reviewed by Tim Thorton.
Relanding r170339 and r170340 with correct WinLauncher.h file.
- WinLauncher/Common.cpp: Copied from WinLauncher/WinLauncher.cpp.
(PrintView):
(ToggleMenuItem):
(WndProc):
(BackButtonProc):
(ForwardButtonProc):
(loadURL):
(shouldUseFullDesktop): Deleted.
(SimpleEventListener::SimpleEventListener): Deleted.
(SimpleEventListener::handleEvent): Deleted.
(WinLauncherWebHost::updateAddressBar): Deleted.
(WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
(WinLauncherWebHost::QueryInterface): Deleted.
(WinLauncherWebHost::AddRef): Deleted.
(WinLauncherWebHost::Release): Deleted.
(updateMenuItemForHistoryItem): Deleted.
(showLastVisitedSites): Deleted.
(WinLauncherWebHost::didFinishLoadForFrame): Deleted.
(resizeSubViews): Deleted.
(setToDefaultPreferences): Deleted.
(wWinMain): Deleted.
(MyRegisterClass): Deleted.
(LaunchInspector): Deleted.
(NavigateForwardOrBackward): Deleted.
(NavigateToHistory): Deleted.
- WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
(DOMEventListener::Release):
(WebScriptObject::WebScriptObject): Deleted.
(WebScriptObject::~WebScriptObject): Deleted.
(WebScriptObject::throwException): Deleted.
(WebScriptObject::callWebScriptMethod): Deleted.
(WebScriptObject::evaluateWebScript): Deleted.
(WebScriptObject::removeWebScriptKey): Deleted.
(WebScriptObject::stringRepresentation): Deleted.
(WebScriptObject::webScriptValueAtIndex): Deleted.
(WebScriptObject::setWebScriptValueAtIndex): Deleted.
(WebScriptObject::setException): Deleted.
(DOMEventListener::throwException): Deleted.
(DOMEventListener::callWebScriptMethod): Deleted.
(DOMEventListener::evaluateWebScript): Deleted.
(DOMEventListener::removeWebScriptKey): Deleted.
(DOMEventListener::stringRepresentation): Deleted.
(DOMEventListener::webScriptValueAtIndex): Deleted.
(DOMEventListener::setWebScriptValueAtIndex): Deleted.
(DOMEventListener::setException): Deleted.
(DOMEventListener::handleEvent): Deleted.
- WinLauncher/DOMDefaultImpl.h:
(WebScriptObject::QueryInterface): Deleted.
(WebScriptObject::AddRef): Deleted.
(WebScriptObject::Release): Deleted.
(DOMObject::QueryInterface): Deleted.
(DOMEventListener::QueryInterface): Deleted.
(DOMEventListener::AddRef): Deleted.
(DOMEventListener::Release): Deleted.
- WinLauncher/WinLauncher.cpp:
(WinLauncher::WinLauncher):
(WinLauncher::init):
(WinLauncher::prepareViews):
(WinLauncher::setFrameLoadDelegate):
(WinLauncher::setUIDelegate):
(WinLauncher::setAccessibilityDelegate):
(WinLauncher::mainFrame):
(WinLauncher::seedInitialDefaultPreferences):
(WinLauncher::setToDefaultPreferences):
(updateMenuItemForHistoryItem):
(WinLauncher::showLastVisitedSites):
(WinLauncher::launchInspector):
(WinLauncher::navigateForwardOrBackward):
(WinLauncher::navigateToHistory):
(WinLauncher::goBack):
(WinLauncher::goForward):
(WinLauncher::loadURL):
(shouldUseFullDesktop): Deleted.
(SimpleEventListener::SimpleEventListener): Deleted.
(SimpleEventListener::handleEvent): Deleted.
(WinLauncherWebHost::updateAddressBar): Deleted.
(WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
(WinLauncherWebHost::QueryInterface): Deleted.
(WinLauncherWebHost::AddRef): Deleted.
(WinLauncherWebHost::Release): Deleted.
(showLastVisitedSites): Deleted.
(WinLauncherWebHost::didFinishLoadForFrame): Deleted.
(resizeSubViews): Deleted.
(subclassForLayeredWindow): Deleted.
(computeFullDesktopFrame): Deleted.
(DllMain): Deleted.
(getAppDataFolder): Deleted.
(setToDefaultPreferences): Deleted.
(setCacheFolder): Deleted.
(createCrashReport): Deleted.
(wWinMain): Deleted.
(MyRegisterClass): Deleted.
(AbortProc): Deleted.
(getPrinterDC): Deleted.
(initDocStruct): Deleted.
(PrintView): Deleted.
(ToggleMenuItem): Deleted.
(LaunchInspector): Deleted.
(NavigateForwardOrBackward): Deleted.
(NavigateToHistory): Deleted.
(WndProc): Deleted.
(EditProc): Deleted.
(BackButtonProc): Deleted.
(ForwardButtonProc): Deleted.
(About): Deleted.
(loadURL): Deleted.
(dllLauncherEntryPoint): Deleted.
- WinLauncher/WinLauncher.h:
(WinLauncher::standardPreferences):
(WinLauncher::privatePreferences):
(WinLauncher::hasWebView):
(WinLauncher::usesLayeredWebView):
(WinLauncherWebHost::WinLauncherWebHost): Deleted.
(WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
(WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): Deleted.
(WinLauncherWebHost::didCommitLoadForFrame): Deleted.
(WinLauncherWebHost::didReceiveTitle): Deleted.
(WinLauncherWebHost::didChangeIcons): Deleted.
(WinLauncherWebHost::didReceiveIcon): Deleted.
(WinLauncherWebHost::didFailLoadWithError): Deleted.
(WinLauncherWebHost::didChangeLocationWithinPageForFrame): Deleted.
(WinLauncherWebHost::willPerformClientRedirectToURL): Deleted.
(WinLauncherWebHost::didCancelClientRedirectForFrame): Deleted.
(WinLauncherWebHost::willCloseFrame): Deleted.
(WinLauncherWebHost::windowScriptObjectAvailable): Deleted.
(WinLauncherWebHost::didClearWindowObject): Deleted.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
- WinLauncher/WinLauncherReplace.h:
(processCrashReport):
- WinLauncher/WinLauncherWebHost.cpp: Copied from WinLauncher/WinLauncher.cpp.
(WinLauncherWebHost::updateAddressBar):
(WinLauncherWebHost::QueryInterface):
(WinLauncherWebHost::AddRef):
(WinLauncherWebHost::Release):
(WinLauncherWebHost::didFinishLoadForFrame):
(shouldUseFullDesktop): Deleted.
(updateMenuItemForHistoryItem): Deleted.
(showLastVisitedSites): Deleted.
(resizeSubViews): Deleted.
(subclassForLayeredWindow): Deleted.
(computeFullDesktopFrame): Deleted.
(DllMain): Deleted.
(getAppDataFolder): Deleted.
(setToDefaultPreferences): Deleted.
(setCacheFolder): Deleted.
(createCrashReport): Deleted.
(wWinMain): Deleted.
(MyRegisterClass): Deleted.
(AbortProc): Deleted.
(getPrinterDC): Deleted.
(initDocStruct): Deleted.
(PrintView): Deleted.
(ToggleMenuItem): Deleted.
(LaunchInspector): Deleted.
(NavigateForwardOrBackward): Deleted.
(NavigateToHistory): Deleted.
(WndProc): Deleted.
(EditProc): Deleted.
(BackButtonProc): Deleted.
(ForwardButtonProc): Deleted.
(About): Deleted.
(loadURL): Deleted.
(dllLauncherEntryPoint): Deleted.
- WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
(WinLauncherWebHost::WinLauncherWebHost):
(WinLauncherWebHost::didStartProvisionalLoadForFrame):
(WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
(WinLauncherWebHost::didCommitLoadForFrame):
(WinLauncherWebHost::didReceiveTitle):
(WinLauncherWebHost::didChangeIcons):
(WinLauncherWebHost::didReceiveIcon):
(WinLauncherWebHost::didFailLoadWithError):
(WinLauncherWebHost::didChangeLocationWithinPageForFrame):
(WinLauncherWebHost::willPerformClientRedirectToURL):
(WinLauncherWebHost::didCancelClientRedirectForFrame):
(WinLauncherWebHost::willCloseFrame):
(WinLauncherWebHost::windowScriptObjectAvailable):
(WinLauncherWebHost::didClearWindowObject):
- WinLauncher/WinMain.cpp: Copied from WinLauncher/WinLauncher.cpp.
(wWinMain):
(MyRegisterClass):
(shouldUseFullDesktop): Deleted.
(SimpleEventListener::SimpleEventListener): Deleted.
(SimpleEventListener::handleEvent): Deleted.
(WinLauncherWebHost::updateAddressBar): Deleted.
(WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
(WinLauncherWebHost::QueryInterface): Deleted.
(WinLauncherWebHost::AddRef): Deleted.
(WinLauncherWebHost::Release): Deleted.
(updateMenuItemForHistoryItem): Deleted.
(showLastVisitedSites): Deleted.
(WinLauncherWebHost::didFinishLoadForFrame): Deleted.
(resizeSubViews): Deleted.
(subclassForLayeredWindow): Deleted.
(computeFullDesktopFrame): Deleted.
(DllMain): Deleted.
(getAppDataFolder): Deleted.
(setToDefaultPreferences): Deleted.
(setCacheFolder): Deleted.
(createCrashReport): Deleted.
(AbortProc): Deleted.
(getPrinterDC): Deleted.
(initDocStruct): Deleted.
(PrintView): Deleted.
(ToggleMenuItem): Deleted.
(LaunchInspector): Deleted.
(NavigateForwardOrBackward): Deleted.
(NavigateToHistory): Deleted.
(WndProc): Deleted.
(EditProc): Deleted.
(BackButtonProc): Deleted.
(ForwardButtonProc): Deleted.
(About): Deleted.
(loadURL): Deleted.
(dllLauncherEntryPoint): Deleted.
- 9:18 AM Changeset in webkit [170364] by
-
- 6 edits in trunk/Source
Fix unused parameter warnings if inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=134244
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-24
Reviewed by Zalan Bujtas.
Source/WebCore:
No new tests, no behavior change.
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::startProfiling):
(WebCore::InspectorInstrumentation::stopProfiling):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didFinishXHRLoading):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
(WKBundleInspectorShow):
(WKBundleInspectorClose):
(WKBundleInspectorEvaluateScriptForTest):
(WKBundleInspectorSetPageProfilingEnabled):
- 9:14 AM Changeset in webkit [170363] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Add null-check in sourceBufferPrivateAppendComplete().
https://bugs.webkit.org/show_bug.cgi?id=133230
Reviewed by Eric Carlson.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Bail early if the
SourceBuffer has been removed from the MediaSource.
- 9:05 AM Changeset in webkit [170362] by
-
- 2 edits in trunk/Tools
[iOS] getsectdata() is deprecated and we use it in DRT
https://bugs.webkit.org/show_bug.cgi?id=134122
Reviewed by Alexey Proskuryakov.
Migrate to using magic linker symbols.
No tests because there should be no behavior change
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontsIOS):
- 7:38 AM Changeset in webkit [170361] by
-
- 6 edits in trunk/Source/WebKit2
WKWebView doesn't respect -[UIScrollView contentInset]
https://bugs.webkit.org/show_bug.cgi?id=134230
<rdar://problem/17429107>
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setHasCustomContentView:loadedMIMEType:WTF::]):
Call initWithFrame and pass the WKWebView along.
(-[WKWebView _adjustedContentOffset:]):
New helper method that takes a content offset as a CGPoint and offsets it by the computed content inset.
(-[WKWebView _computedContentInset]):
New helper method that returns the _obscuredInsets, or if it's zero, the scroll view's content inset.
(-[WKWebView _processDidExit]):
Use _computedContentInset.
(-[WKWebView _didCommitLayerTree:WebKit::]):
use _computedContentInset.
(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:]):
Use _computedContentInset.
(-[WKWebView _scrollToContentOffset:WebCore::]):
Use _computedContentInset.
(-[WKWebView _updateVisibleContentRects]):
If we have a custom content view, call web_computedContentInsetDidChange.
(-[WKWebView _setObscuredInsets:]):
Don't call web_setObscuredInsets: if we have a custom content view.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
Add new methods.
- UIProcess/Cocoa/WKWebViewContentProvider.h:
Add new methods.
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView web_initWithFrame:webView:]):
Set the _webView and _scrollView ivars.
(-[WKPDFView _offsetForPageNumberIndicator]):
Get the computed content offset from the WKWebView.
(-[WKPDFView web_computedContentInsetDidChange]):
Update the page indicator.
(-[WKPDFView initWithFrame:]): Deleted.
(-[WKPDFView web_setObscuredInsets:]): Deleted.
- UIProcess/ios/WKScrollView.mm:
(-[WKScrollView setContentInset:]):
Call _updateVisibleContentRects.
- 7:24 AM Changeset in webkit [170360] by
-
- 36 edits in trunk/Source/WebCore
Unreviewed, rolling out r170337.
https://bugs.webkit.org/show_bug.cgi?id=134250
caused 3 layout tests to crash on debug. (Requested by zalan
on #webkit).
Reverted changeset:
"Use unsigneds instead of ints for indexes into a string in
text layout code"
https://bugs.webkit.org/show_bug.cgi?id=133592
http://trac.webkit.org/changeset/170337
- 4:09 AM Changeset in webkit [170359] by
-
- 5 edits in trunk
Source/WebCore: [ATK] Don't ignore links rendered as blocks.
https://bugs.webkit.org/show_bug.cgi?id=130941
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-24
Reviewed by Mario Sanchez Prada.
- /m/usr/src/webkit-trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(WebCore::AccessibilityObject::objectFocusedAndCaretOffsetUnignored): Don't ignore links
when they are renderered with display:block.
LayoutTests: [ATK] Extended the test for accessibility of text inside "span" block in "a" block
with the tests for caret movements in these cases.
https://bugs.webkit.org/show_bug.cgi?id=130941
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-24
Reviewed by Mario Sanchez Prada.
- platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt:
- platform/gtk/accessibility/text-in-span-block-in-a-block.html:
Added testing for text-caret-moved signal. Added one more "a" element to the set.
- 4:02 AM Changeset in webkit [170358] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION(r170235): Remove incorrect ifdef guard
https://bugs.webkit.org/show_bug.cgi?id=134246
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-24
Reviewed by Csaba Osztrogonác.
- WebView/WebView.mm:
(-[WebView _visibilityState]):
- 3:09 AM Changeset in webkit [170357] by
-
- 2 edits in trunk/Tools
Name moving. Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 2:22 AM Changeset in webkit [170356] by
-
- 2 edits in trunk/Tools
Remove EFL WK1 watch category
https://bugs.webkit.org/show_bug.cgi?id=134231
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/config/watchlist: Removed EFL WK1 category.
- 2:15 AM Changeset in webkit [170355] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Update GObject DOM bindings test results after r170351.
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
- 2:02 AM Changeset in webkit [170354] by
-
- 3 edits in trunk/LayoutTests
[EFL] Merge efl-wk2 and efl test expectations files
https://bugs.webkit.org/show_bug.cgi?id=134245
Unreviewed gardening after removing WebKit1.
- platform/efl-wk2/TestExpectations: An empty file left, as deleting it may break flakiness dashboard.
- platform/efl/TestExpectations: Merged with platform/efl-wk2/TestExpectations.
- 1:36 AM Changeset in webkit [170353] by
-
- 2 edits in trunk/Source/WTF
[JavaScriptCore] Enable concurrent JIT on EFL.
https://bugs.webkit.org/show_bug.cgi?id=134242
Reviewed by Csaba Osztrogonác.
- wtf/Platform.h:
- 1:09 AM Changeset in webkit [170352] by
-
- 1 edit1 delete in trunk/Tools
[ATK] Remove some unused code from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=134191
Reviewed by Chris Fleizach.
DumpRenderTree's accessibility code could be removed since GTK and EFL has stopped supporting WK1.
- DumpRenderTree/atk/AccessibilityCallbacks.h: Removed.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Removed.
- DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Removed.
- DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Removed.
- DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Removed.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Removed.
- 12:14 AM Changeset in webkit [170351] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix GTK+ build after r170309.
Skip functions returning arrays in GObject DOM bindings.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction):
Jun 23, 2014:
- 11:55 PM Changeset in webkit [170350] by
-
- 2 edits in trunk/Websites/webkit.org
Drop the cross organizational support requirement from reviewer nomination policy
https://bugs.webkit.org/show_bug.cgi?id=134240
Reviewed by Gyuyoung Kim.
Removed.
- coding/commit-review-policy.html:
- 11:34 PM Changeset in webkit [170349] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Search field is not shown properly on doing ctrl+f on Minibrowser.
https://bugs.webkit.org/show_bug.cgi?id=134025
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-06-23
Reviewed by Gyuyoung Kim.
Use EVAS_HINT_FILL in evas_object_size_hint_align_set() api.
- MiniBrowser/efl/main.c:
(window_create):
- 11:15 PM Changeset in webkit [170348] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, fix build warning.
Source/WebKit2/WebProcess/WebPage/DrawingArea.h:117:18: warning: unused parameter ‘wantsDidUpdateViewState’ [-Wunused-parameter]
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::viewStateDidChange):
- 11:12 PM Changeset in webkit [170347] by
-
- 16 edits3 deletes in trunk
[EFL] Replace RefPtr<Evas_Object> with UniquePtrEfl
https://bugs.webkit.org/show_bug.cgi?id=134236
Reviewed by Gyuyoung Kim.
Source/WebCore:
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
- platform/efl/RenderThemeEfl.h:
- platform/graphics/efl/CairoUtilitiesEfl.cpp:
(WebCore::evasObjectFromCairoImageSurface):
- platform/graphics/efl/CairoUtilitiesEfl.h:
- platform/graphics/efl/ImageEfl.cpp:
(WebCore::BitmapImage::getEvasObject):
Source/WebKit2:
- PlatformEfl.cmake:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::updateCursor):
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/SnapshotImageGL.cpp:
- UIProcess/API/efl/ewk_favicon_database.cpp:
(ewk_favicon_database_icon_get):
- UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp: Removed.
Source/WTF:
Although there are ref/unref for Evas_Object, it's bit odd so we should call evas_object_del to destroy it.
So, this patch replaced RefPtr<Evas_Object> with UniquePtrEfl for the simplicity.
- wtf/PlatformEfl.cmake: Removed RefPtrEfl.cpp from source list.
- wtf/efl/RefPtrEfl.cpp: Removed.
- wtf/efl/RefPtrEfl.h: Removed.
Tools:
- ImageDiff/efl/ImageDiff.cpp:
(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):
- 10:45 PM Changeset in webkit [170346] by
-
- 6 edits1 add5 deletes in trunk/Tools
Rolling out r170340 and r170339.
Changeset r170339 broke the Apple Windows Debug and Release builds.
Reverted changesets:
"[Win] Build fix after r134209"
http://trac.webkit.org/changeset/170340
"[Win] Clean up and refactor WinLauncher"
https://bugs.webkit.org/show_bug.cgi?id=134209
http://trac.webkit.org/changeset/170339
- 9:38 PM Changeset in webkit [170345] by
-
- 2 edits in trunk/Source/WebCore
Chapter forward/backward should seek to beginning/end.
https://bugs.webkit.org/show_bug.cgi?id=134225
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-23
Reviewed by Eric Carlson.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController seekChapterBackward:]): forwards to -seekToBeginning
(-[WebAVPlayerController seekChapterForward:]): forwards to -seekToEnd
- 9:12 PM Changeset in webkit [170344] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] REGRESSION (r169324): Page jumps to top when you type into a text field
https://bugs.webkit.org/show_bug.cgi?id=134219
<rdar://problem/17279113>
Reviewed by Benjamin Poulain.
Fixes an issue where typing into a text field may cause a noticeable jump to the top of
the page.
Currently when updating the visual content rectangles we always constrain the scroll offset
(s_x, s_y) such that 0 <= s_x <= "content width" - "visible width" and 0 <= s_y <= "content height" - "visible height".
However the UIProcess may want to scroll the page by an offset outside of this range to
create a visually pleasing result. In particular, on iOS we may scroll the page slightly
outside of this range (e.g. s_y > 0 = "content height" - "visible height") when a form
control is focused so as to be consistent with platform convention.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects): Temporarily disable content edge constraint when
updating scroll offset.
- 7:24 PM Changeset in webkit [170343] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Don't draw focus rings if we are animating controls
https://bugs.webkit.org/show_bug.cgi?id=134232
<rdar://problem/17381121>
Reviewed by Tim Horton.
Controls in native apps do not draw their focus rings as they
animate (in Yosemite). Turn this off for WebKit too. It turns
out that when we were drawing them, they were in the wrong
place anyway.
Since we don't animate controls when testing, we can't really test this.
- platform/mac/ThemeMac.mm:
(WebCore::paintToggleButton): Only draw the focus ring if the
NSButtonCell is not animating.
- 7:18 PM Changeset in webkit [170342] by
-
- 3 edits in trunk/Source/WebCore
[ATK] Remove some unnecessary code from WebKitAccessibleWrapperAtk
https://bugs.webkit.org/show_bug.cgi?id=134193
Reviewed by Gyuyoung Kim.
It was used along with DRT. Since we have stopped support WK1/DRT, it won't be needed.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetFocusedElement): Deleted.
- accessibility/atk/WebKitAccessibleWrapperAtk.h:
- 6:23 PM Changeset in webkit [170341] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/17413374> [iOS] Application cache size per origin is not limited
https://bugs.webkit.org/show_bug.cgi?id=134229
Reviewed by Anders Carlsson.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess): Set the default quota per origin to the same
value it is set in Legacy WebKit.
- 5:56 PM Changeset in webkit [170340] by
-
- 2 edits in trunk/Tools
[Win] Build fix after r134209
- WinLauncher/WinMain.cpp: Must include the resources file
before Common.cpp.
- 5:51 PM Changeset in webkit [170339] by
-
- 6 edits1 copy1 move3 adds in trunk/Tools
[Win] Clean up and refactor WinLauncher
https://bugs.webkit.org/show_bug.cgi?id=134209
Reviewed by Tim Horton.
Make WinLauncher a class, and move all non-class driver functions
into "Common.cpp" and "WinMain.cpp". These files are distinct
to allow some internal tools to reuse the code in 'Common'.
- WinLauncher/Common.cpp: Added. Consists of code moved from
'WinLauncher.cpp' that can be reused for other tools.
(subclassForLayeredWindow):
(computeFullDesktopFrame):
(DllMain):
(getAppDataFolder):
(setCacheFolder):
(createCrashReport):
(AbortProc):
(getPrinterDC):
(initDocStruct):
(PrintView):
(ToggleMenuItem):
(WndProc):
(EditProc):
(BackButtonProc):
(ForwardButtonProc):
(About):
(loadURL):
(dllLauncherEntryPoint):
- WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
(DOMEventListener::Release):
(WebScriptObject::WebScriptObject): Deleted.
(WebScriptObject::~WebScriptObject): Deleted.
(WebScriptObject::throwException): Deleted.
(WebScriptObject::callWebScriptMethod): Deleted.
(WebScriptObject::evaluateWebScript): Deleted.
(WebScriptObject::removeWebScriptKey): Deleted.
(WebScriptObject::stringRepresentation): Deleted.
(WebScriptObject::webScriptValueAtIndex): Deleted.
(WebScriptObject::setWebScriptValueAtIndex): Deleted.
(WebScriptObject::setException): Deleted.
(DOMEventListener::throwException): Deleted.
(DOMEventListener::callWebScriptMethod): Deleted.
(DOMEventListener::evaluateWebScript): Deleted.
(DOMEventListener::removeWebScriptKey): Deleted.
(DOMEventListener::stringRepresentation): Deleted.
(DOMEventListener::webScriptValueAtIndex): Deleted.
(DOMEventListener::setWebScriptValueAtIndex): Deleted.
(DOMEventListener::setException): Deleted.
(DOMEventListener::handleEvent): Deleted.
- WinLauncher/DOMDefaultImpl.h:
(WebScriptObject::QueryInterface): Deleted.
(WebScriptObject::AddRef): Deleted.
(WebScriptObject::Release): Deleted.
(DOMObject::QueryInterface): Deleted.
(DOMEventListener::QueryInterface): Deleted.
(DOMEventListener::AddRef): Deleted.
(DOMEventListener::Release): Deleted.
- WinLauncher/WinLauncher.cpp: Converted stand-alone implementation
into a C++ class and removed WinAPI code.
(WinLauncher::WinLauncher):
(WinLauncher::init):
(WinLauncher::prepareViews):
(WinLauncher::setFrameLoadDelegate):
(WinLauncher::setUIDelegate):
(WinLauncher::setAccessibilityDelegate):
(WinLauncher::mainFrame):
(WinLauncher::seedInitialDefaultPreferences):
(WinLauncher::setToDefaultPreferences):
(updateMenuItemForHistoryItem):
(WinLauncher::showLastVisitedSites):
(WinLauncher::launchInspector):
(WinLauncher::navigateForwardOrBackward):
(WinLauncher::navigateToHistory):
(WinLauncher::goBack):
(WinLauncher::goForward):
(WinLauncher::loadURL):
(shouldUseFullDesktop): Deleted.
(SimpleEventListener::SimpleEventListener): Deleted.
(SimpleEventListener::handleEvent): Deleted.
(WinLauncherWebHost::updateAddressBar): Deleted.
(WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
(WinLauncherWebHost::QueryInterface): Deleted.
(WinLauncherWebHost::AddRef): Deleted.
(WinLauncherWebHost::Release): Deleted.
(showLastVisitedSites): Deleted.
(WinLauncherWebHost::didFinishLoadForFrame): Deleted.
(resizeSubViews): Deleted.
(subclassForLayeredWindow): Deleted.
(computeFullDesktopFrame): Deleted.
(DllMain): Deleted.
(getAppDataFolder): Deleted.
(setToDefaultPreferences): Deleted.
(setCacheFolder): Deleted.
(createCrashReport): Deleted.
(wWinMain): Deleted.
(MyRegisterClass): Deleted.
(AbortProc): Deleted.
(getPrinterDC): Deleted.
(initDocStruct): Deleted.
(PrintView): Deleted.
(ToggleMenuItem): Deleted.
(LaunchInspector): Deleted.
(NavigateForwardOrBackward): Deleted.
(NavigateToHistory): Deleted.
(WndProc): Deleted.
(EditProc): Deleted.
(BackButtonProc): Deleted.
(ForwardButtonProc): Deleted.
(About): Deleted.
(loadURL): Deleted.
(dllLauncherEntryPoint): Deleted.
- WinLauncher/WinLauncher.h: Removed.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
- WinLauncher/WinLauncherReplace.h:
(processCrashReport):
- WinLauncher/WinLauncherWebHost.cpp: Added.
(SimpleEventListener::SimpleEventListener):
(SimpleEventListener::handleEvent):
(WinLauncherWebHost::updateAddressBar):
(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost::QueryInterface):
(WinLauncherWebHost::AddRef):
(WinLauncherWebHost::Release):
(WinLauncherWebHost::didFinishLoadForFrame):
- WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
Moved WinLauncherWebHost implementation from WinLauncher.cpp into
its own set of files.
(WinLauncherWebHost::WinLauncherWebHost):
(WinLauncherWebHost::didStartProvisionalLoadForFrame):
(WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
(WinLauncherWebHost::didCommitLoadForFrame):
(WinLauncherWebHost::didReceiveTitle):
(WinLauncherWebHost::didChangeIcons):
(WinLauncherWebHost::didReceiveIcon):
(WinLauncherWebHost::didFailLoadWithError):
(WinLauncherWebHost::didChangeLocationWithinPageForFrame):
(WinLauncherWebHost::willPerformClientRedirectToURL):
(WinLauncherWebHost::didCancelClientRedirectForFrame):
(WinLauncherWebHost::willCloseFrame):
(WinLauncherWebHost::windowScriptObjectAvailable):
(WinLauncherWebHost::didClearWindowObject):
- WinLauncher/WinMain.cpp: Added. This consists of code from
WinLauncher that is unique to the WinLauncher utility, and is
not part of the WinLauncher class.
(wWinMain):
(MyRegisterClass):
- 5:49 PM Changeset in webkit [170338] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, EFL build fix after r170330.
- WebProcess/WebPage/WebPage.cpp: Guard WKStringCF.h with PLATFORM(COCOA) macro.
- 5:29 PM Changeset in webkit [170337] by
-
- 36 edits in trunk/Source/WebCore
Use unsigneds instead of ints for indexes into a string in text layout code
https://bugs.webkit.org/show_bug.cgi?id=133592
Reviewed by Zalan Bujtas.
Migrate much of the text-handling code to use unsigneds for indexes into a string.
No new tests because there is no behavior change.
- WebCore.exp.in:
- platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForText):
(WebCore::computeUnderlineType):
- platform/graphics/Font.h:
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::drawGlyphBuffer):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForSimpleText):
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::size):
(WebCore::GlyphBuffer::glyphs):
(WebCore::GlyphBuffer::advances):
(WebCore::GlyphBuffer::fontDataAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::offsetAt):
(WebCore::GlyphBuffer::reverse):
(WebCore::GlyphBuffer::offsetInString):
(WebCore::GlyphBuffer::swap):
- platform/graphics/GraphicsContext.cpp:
(WebCore::TextRunIterator::atEnd):
- platform/graphics/Latin1TextIterator.h:
(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::currentCharacter):
- platform/graphics/SimpleFontData.h:
- platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::SurrogatePairAwareTextIterator):
- platform/graphics/SurrogatePairAwareTextIterator.h:
(WebCore::SurrogatePairAwareTextIterator::currentCharacter):
- platform/graphics/TextRun.h:
(WebCore::TextRun::length):
(WebCore::TextRun::charactersLength):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::glyphDataForCharacter):
(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):
- platform/graphics/WidthIterator.h:
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::adjustSelectionRectForComplexText):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontWin.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/wince/FontWinCE.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::selectionRectForComplexText):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::selectionState):
(WebCore::adjustCharactersAndLengthForHyphen):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::positionForOffset):
(WebCore::InlineTextBox::constructTextRun):
- rendering/InlineTextBox.h:
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::getStringToRender):
- rendering/RenderCombineText.h:
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::localSelectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGInlineTextBox::paintText):
- rendering/svg/SVGInlineTextBox.h:
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::SVGTextQuery::extentOfCharacterCallback):
(WebCore::SVGTextQuery::characterNumberAtPositionCallback):
- rendering/svg/SVGTextQuery.h:
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::SVGGlyphToPathTranslator):
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
- rendering/svg/SVGTextRunRenderingContext.h:
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontData.h:
- 5:08 PM Changeset in webkit [170336] by
-
- 7 edits2 adds in trunk
HTMLMediaElement seek algorithm should allow cancelling previous seeks.
https://bugs.webkit.org/show_bug.cgi?id=134116
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-seek-double.html
Fulfill the requirement of the §4.7.14.9 seeking algorithm to do steps 5+ asynchronously and cancel
previous instances of the algorithm.
For the html/ parts of the algorithm, implement this by adding a seek timer, which when fired will
issue steps 5-12. MediaPlayerPrivateAVFoundation will already coalesce multiple seek operations, so nothing
additional needs be done there. However, MediaPlayerPrivateMediaSourceAVFObjC needs to implement the same
pending seek logic in case additional seeks were issued after the html/ algorithm reached step 12.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize the new m_seekTimer.
(WebCore::HTMLMediaElement::parseAttribute): Clear the seek timer.
(WebCore::HTMLMediaElement::seekInternal): Differentiate between DOM seeks and internal seeks.
(WebCore::HTMLMediaElement::seekWithTolerance:) Split into the seekTimerFired() method.
(WebCore::HTMLMediaElement::seekTimerFired:) Added, split from seekWithTolerance().
- html/HTMLMediaElement.h:
- html/MediaController.cpp:
(MediaController::bringElementUpToSpeed): Call seekInternal().
(WebCore::HTMLMediaElement::PendingSeek::PendingSeek): Added convenience struct for storing seek requests.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::PendingSeek::PendingSeek): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC): Modify the time jumped
handler to not clear the m_seeking flag if another seek request is pending.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
LayoutTests:
- media/video-seek-double-expected.txt: Added.
- media/video-seek-double.html: Added.
- 5:03 PM Changeset in webkit [170335] by
-
- 9 edits in trunk/Source
[WK2] Use the page background color instead of white when swipe snapshots were purged (134218)
https://bugs.webkit.org/show_bug.cgi?id=134218
<rdar://problem/17426454>
Reviewed by Benjamin Poulain.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateScrollViewBackground]):
(-[WKWebView WebKit::]):
- UIProcess/API/mac/WKView.mm:
(-[WKView _takeViewSnapshot]):
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::shouldUseSnapshotForSize):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::retrieveSnapshotForItem): Deleted.
- UIProcess/mac/ViewSnapshotStore.h:
Store a color along with each snapshot.
Set the background color of the swipe snapshot layer accordingly.
- WebCore.exp.in:
- 4:56 PM Changeset in webkit [170334] by
-
- 3 edits1 add in trunk/Source/WebKit2
Add -[WKBackForwardList _removeAllItems]
https://bugs.webkit.org/show_bug.cgi?id=134227
<rdar://problem/17291623>
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList _removeAllItems]):
- UIProcess/API/Cocoa/WKBackForwardListPrivate.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 4:45 PM Changeset in webkit [170333] by
-
- 2 edits2 deletes in trunk/Source/WebCore
[iOS] remove InbandTextTrackPrivateAVFIOS
https://bugs.webkit.org/show_bug.cgi?id=134220
Reviewed by Benjamin Poulain.
- WebCore.xcodeproj/project.pbxproj: Remove references to InbandTextTrackPrivateAVFIOS.
- platform/graphics/ios/InbandTextTrackPrivateAVFIOS.h: Removed.
- platform/graphics/ios/InbandTextTrackPrivateAVFIOS.mm: Removed.
- 4:17 PM Changeset in webkit [170332] by
-
- 29 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r170323.
https://bugs.webkit.org/show_bug.cgi?id=134224
lots of build breakage (Requested by bradeeoh on #webkit).
Reverted changeset:
"[Mac] process raw VTT in-band captions"
https://bugs.webkit.org/show_bug.cgi?id=134178
http://trac.webkit.org/changeset/170323
- 4:16 PM Changeset in webkit [170331] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/17413498> [Cocoa] Expose WebPreferences::offlineWebApplicationCacheEnabled
https://bugs.webkit.org/show_bug.cgi?id=134217
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _offlineApplicationCacheIsEnabled]):
(-[WKPreferences _setOfflineApplicationCacheIsEnabled:]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h: Added _offlineWebApplicationCacheIsEnabled
property.
- 4:15 PM Changeset in webkit [170330] by
-
- 10 edits in trunk
Add SPI for Injected Bundle to provide user agent for a given URL.
https://bugs.webkit.org/show_bug.cgi?id=133562
Patch by Grant Kennell <gkennell@apple.com> on 2014-06-23
Reviewed by Sam Weinig.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Added delegate method to WebProcess PluIn protocol to provide UserAgent per URL.
- WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h: Added new typedef for function pointer for this new delegate call. Added new version (V8) of bundle loader client struct containing a function pointer of that new type.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(userAgentForURL): Makes delegate call with the new method.
(setUpPageLoaderClient): Sets the struct's new function pointer to the new method.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::userAgentForURL):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::userAgent):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::userAgent): Began using the new API to ask for user agent
instead of simply returning what had been stored.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::userAgent): Deleted.
- 4:13 PM Changeset in webkit [170329] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r170324.
https://bugs.webkit.org/show_bug.cgi?id=134223
lots of build breakage (Requested by bradeeoh on #webkit).
Reverted changeset:
"Unreviewed, revert an unintentional change committed with
r170323."
http://trac.webkit.org/changeset/170324
- 4:12 PM Changeset in webkit [170328] by
-
- 2 edits in trunk/Source/WebCore
Fix release build
- Modules/indexeddb/IDBTransactionCoordinator.cpp:
(WebCore::IDBTransactionCoordinator::canRunTransaction):
- 3:38 PM Changeset in webkit [170327] by
-
- 3 edits2 adds in trunk
Database process crashes when multiple transactions attempt to run at once
https://bugs.webkit.org/show_bug.cgi?id=134139
Reviewed by David Kilzer.
Source/WebCore:
Ensure that only one transaction can be running at a time.
Test: storage/indexeddb/transaction-overlapping.html
- Modules/indexeddb/IDBTransactionCoordinator.cpp:
(WebCore::IDBTransactionCoordinator::canRunTransaction):
LayoutTests:
- storage/indexeddb/transaction-overlapping-expected.txt: Added.
- storage/indexeddb/transaction-overlapping.html: Added.
- 3:12 PM Changeset in webkit [170326] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][wk2] Don't use view snapshots if the destination layer is a different size
https://bugs.webkit.org/show_bug.cgi?id=134210
<rdar://problem/17369463>
Reviewed by Benjamin Poulain.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
Only use the view snapshot if the snapshot is the same (in device space) size
as the layer it's going to be put into, and only if the device scale factor is
the same as it was when the snapshot was taken.
- 3:05 PM Changeset in webkit [170325] by
-
- 30 edits in trunk/Source
[iOS][WK2] Make the state restore from HistoryItem more precise and reliable
https://bugs.webkit.org/show_bug.cgi?id=134150
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-23
Reviewed by Tim Horton.
Source/WebCore:
The two biggest changes for WebCore are:
-Store everything we need to handle changes of ViewportConfiguration on HistoryItem.
-Store the exposedRect with floating point coordinates.
- WebCore.exp.in:
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
We cannot determine a good scroll position from the WebProcess because the obscured insets can change
arbitrarily in the UIProcess. When we scroll here from the WebProcess, we would force an invalid position
to the UIProcess with the next layer tree update.
To avoid any problem, we prohibit scrolling when restoring the focus appearance.
- history/HistoryItem.cpp:
(WebCore::encodeRect):
(WebCore::encodeSize):
(WebCore::HistoryItem::encodeBackForwardTreeNode):
(WebCore::decodeRect):
(WebCore::decodeSize):
(WebCore::HistoryItem::decodeBackForwardTree):
- history/HistoryItem.h:
(WebCore::HistoryItem::exposedContentRect):
(WebCore::HistoryItem::setExposedContentRect):
(WebCore::HistoryItem::unobscuredContentRect):
(WebCore::HistoryItem::setUnobscuredContentRect):
(WebCore::HistoryItem::minimumLayoutSizeInScrollViewCoordinates):
(WebCore::HistoryItem::setMinimumLayoutSizeInScrollViewCoordinates):
(WebCore::HistoryItem::contentSize):
(WebCore::HistoryItem::setContentSize):
(WebCore::HistoryItem::exposedContentPosition): Deleted.
(WebCore::HistoryItem::setExposedContentPosition): Deleted.
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
- page/FrameView.h:
- platform/ScrollView.h:
- platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::exposedContentRect):
(WebCore::ScrollView::setExposedContentRect):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::didChangeVisibleRect):
Source/WebKit2:
This patch make several little improvements to improve how we restore the visible content rect and scale
from the HistoryItem.
The biggest architectural change is that the exposed rect is now restored on the UIProcess instead of the WebProcess,
this ensure we restore the same position regardless of any modification of obscured areas.
- Shared/VisibleContentRectUpdateInfo.cpp:
(WebKit::VisibleContentRectUpdateInfo::encode):
(WebKit::VisibleContentRectUpdateInfo::decode):
- Shared/VisibleContentRectUpdateInfo.h:
(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::VisibleContentRectUpdateInfo::lastLayerTreeTransactionId):
(WebKit::WebPage::updateVisibleContentRects):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
A race between the UIProcess and the WebProcess could cause the viewport of the next page to be influenced by updates
of the previous page. To avoid that, VisibleContentRectUpdateInfo keeps track of the last transaction seen at the time
of the update.
The WebProcess updates the size and scale of the content through layer tree updates. If an update was generated for a layer tree
update of the old page, none of the information is valid for the current content. Since the UIProcess drives the state in case of conflicts,
the WebProcess was updating the scale of the current page based on incorrect information.
To avoid the problems, we save the layer tree transaction ID when we commit a new page. Only updates after that transaction are useful
for the current page.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _processDidExit]):
(withinEpsilon):
(changeContentOffsetBoundedInValidRange):
(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView _restorePageStateToExposedRect:WebCore::scale:]):
(-[WKWebView _restorePageStateToUnobscuredCenter:WebCore::scale:]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::restorePageState):
(WebKit::PageClientImpl::restorePageCenterAndScale):
Restoring the state is now done by WKWebView. The state is only updated on the next layer tree commit,
this is done to avoid any jumping if the page has scrolled since we tried to restore its state.
Both update path end up calling _updateVisibleContentRects. This is because the update on the WebProcess
never sets the ScrollPosition (because it does not know the current state of the obscured insets). Pushing
a new VisibleContentRect will nicely udpates the exposed rect, scroll position, fixed elements, etc.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::restorePageState):
(WebKit::WebPageProxy::restorePageCenterAndScale):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
(WebKit::RemoteLayerTreeDrawingAreaProxy::lastCommittedLayerTreeTransactionID):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
- WebProcess/WebCoreSupport/ios/WebFrameLoaderClientIOS.mm:
(WebKit::WebFrameLoaderClient::saveViewStateToItem):
(WebKit::WebFrameLoaderClient::restoreViewState):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::didCommitLoad):
- WebProcess/WebPage/WebPage.h:
Get rid of m_obscuredTopInset. It was a bad idea. The UIProcess updates the obscured insets a lot during
page load, the value we used to restore the scroll position was frequently stale.
(WebKit::WebPage::userHasChangedPageScaleFactor): Deleted.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::savePageState):
(WebKit::scaleAfterViewportWidthChange):
(WebKit::relativeCenterAfterContentSizeChange):
(WebKit::adjustExposedRectForNewScale):
Extract this out of dynamicViewportSizeUpdate(). It is useful to adjust the exposed rect when restoring a HistoryItem
to a ViewportConfiguration that is different from when it was saved.
(WebKit::WebPage::restorePageState):
There are two variations of restorePage:
1) If the viewport configuration is compatible, restore the exact scale and position of the page.
2) Otherwise, restore the scale and position similarily to dynamicViewportSizeUpdate().
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::adjustExposedRectForBoundedScale):
(WebKit::RemoteLayerTreeDrawingArea::currentTransactionID):
Expose the transactionID for the race issue on VisibleRectUpdate.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::setExposedContentRect):
Store the exposed rect in floating point coordinates. This makes it possible to restore that exact
position when needed.
- 3:04 PM Changeset in webkit [170324] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, revert an unintentional change committed with r170323.
- UIProcess/API/Cocoa/WKBackForwardList.mm:
- 2:56 PM Changeset in webkit [170323] by
-
- 30 edits2 adds in trunk/Source
[Mac] process raw VTT in-band captions
https://bugs.webkit.org/show_bug.cgi?id=134178
Reviewed by NOBODY (OOPS!).
- CMakeLists.txt: Add ISOVTTCue.cpp|h.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- html/track/BufferedLineReader.h:
(WebCore::BufferedLineReader::reset): New, empty the input buffer.
Make it possible to process WebVTT captions.
- html/track/InbandGenericTextTrack.cpp:
(WebCore::InbandGenericTextTrack::parser): Allocate, if necessary, and return a WebVTT parser.
(WebCore::InbandGenericTextTrack::parseWebVTTCueData): Pass a cue to the parser.
(WebCore::InbandGenericTextTrack::parseWebVTTFileHeader): Pass a VTT file header to the parser.
(WebCore::InbandGenericTextTrack::newCuesParsed): Parser callback.
(WebCore::InbandGenericTextTrack::newRegionsParsed): Ditto.
(WebCore::InbandGenericTextTrack::fileFailedToParse): Ditto.
- html/track/InbandGenericTextTrack.h:
- html/track/InbandTextTrack.h:
- html/track/InbandWebVTTTextTrack.cpp:
(WebCore::InbandWebVTTTextTrack::parser): New, parser accessor.
(WebCore::InbandWebVTTTextTrack::parseWebVTTCueData): New, parse VTT data in an ISOWebVTTCue
object.
(WebCore::InbandWebVTTTextTrack::newCuesParsed): Cleanup.
(WebCore::InbandWebVTTTextTrack::newRegionsParsed): Implement.
(WebCore::InbandWebVTTTextTrack::fileFailedToParse): Change the error message.
- html/track/InbandWebVTTTextTrack.h:
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::TextTrackCueGenericBoxElement): Change cue parameter
from a pointer to a reference.
(WebCore::TextTrackCueGeneric::createDisplayTree): Ditto.
- html/track/VTTCue.cpp:
(WebCore::VTTCueBox::create): Change cue parameter from a pointer to a reference.
(WebCore::VTTCueBox::VTTCueBox): Ditto.
(WebCore::VTTCueBox::getCue): Return a reference.
(WebCore::VTTCueBox::applyCSSProperties): m_cue is a reference, not a pointer.
(WebCore::VTTCue::create): New, create a VTTCue from WebVTTCueData.
(WebCore::VTTCue::VTTCue): New, internal constructor that takes a WebVTTCueData.
(WebCore::VTTCue::initialize): New, shared constructor initialization.
(WebCore::VTTCue::createDisplayTree): m_cue is a reference, not a pointer.
(WebCore::VTTCue::markFutureAndPastNodes): Ditto.
(WebCore::VTTCue::setCueSettings): Ditto.
- html/track/VTTCue.h:
(WebCore::VTTCueBox::create): Deleted.
(WebCore::VTTCue::create): Deleted.
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::parseFileHeader): New. Reset the line reader buffer and parser state,
call the parser.
(WebCore::WebVTTParser::parseCueData): Create a cue from ISOWebVTTCue.
(WebCore::WebVTTParser::collectTimingsAndSettings): Return immediately if the string is empty.
(WebCore::WebVTTParser::collectTimeStamp): Ditto.
- html/track/WebVTTParser.h:
(WebCore::WebVTTCueData::originalStartTime): New.
(WebCore::WebVTTCueData::setOriginalStartTime): New.
(WebCore::WebVTTCueData::WebVTTCueData):
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::getNewCues): Cleanup, use the new VTTCue::create.
- platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::InbandTextTrackPrivateClient::parseWebVTTFileHeader): New.
Parse ISO WebVTT cue boxes.
- platform/graphics/ISOVTTCue.cpp: Added.
(WebCore::ISOBox::ISOBox):
(WebCore::ISOBox::peekType):
(WebCore::ISOBox::peekLength):
(WebCore::ISOBox::peekString):
(WebCore::vttCueBoxType):
(WebCore::vttIdBoxType):
(WebCore::vttSettingsBoxType):
(WebCore::vttPayloadBoxType):
(WebCore::vttCurrentTimeBoxType):
(WebCore::vttCueSourceIDBoxType):
(WebCore::ISOWebVTTCue::boxType):
(WebCore::ISOWebVTTCue::ISOWebVTTCue):
- platform/graphics/ISOVTTCue.h: Added.
(WebCore::ISOBox::boxHeaderSize):
(WebCore::ISOBox::length):
(WebCore::ISOBox::type):
(WebCore::ISOWebVTTCue::presentationTime):
(WebCore::ISOWebVTTCue::duration):
(WebCore::ISOWebVTTCue::sourceID):
(WebCore::ISOWebVTTCue::id):
(WebCore::ISOWebVTTCue::originalStartTime):
(WebCore::ISOWebVTTCue::settings):
(WebCore::ISOWebVTTCue::cueText):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF): Add a cue format parameter.
(WebCore::InbandTextTrackPrivateAVF::processCue): Call processNativeSamples.
(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings): Add logging. Minor cleanup.
(WebCore::InbandTextTrackPrivateAVF::processNativeSamples): New, process an array of
CMSampleBuffers, create ISOWebVTTCue from the sample data.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
(WebCore::InbandTextTrackPrivateAVFObjC::create): Add a cue format parameter.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::InbandTextTrackPrivateAVFObjC): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Improve logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Don't leak an NSDictionary.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Don't process media selection
options until we have tracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processCue): Pass native samples as well as
attributed strings to track.
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
- platform/graphics/avfoundation/objc/OutOfBandTextTrackPrivateAVF.h:
(WebCore::OutOfBandTextTrackPrivateAVF::OutOfBandTextTrackPrivateAVF):
- platform/graphics/avfoundation/InbandTextTrackPrivateLegacyAVFObjC.cpp:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::InbandTextTrackPrivateLegacyAVFObjC): Pass cue
format to base class.
- platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
(WebCore::InbandTextTrackPrivateAVCF::InbandTextTrackPrivateAVCF): Ditto.
- platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.h:
- 2:40 PM Changeset in webkit [170322] by
-
- 2 edits in trunk/Source/WebKit2
Policy delegate methods should use CompletionHandlerCallChecker
https://bugs.webkit.org/show_bug.cgi?id=134215
Reviewed by Dan Bernstein.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):
- 2:33 PM Changeset in webkit [170321] by
-
- 11 edits in trunk/Source/WebKit2
Don't use the WK prefix for internal C++ types
https://bugs.webkit.org/show_bug.cgi?id=134214
Reviewed by Dan Bernstein.
- Shared/AssistedNodeInformation.cpp:
(WebKit::OptionItem::encode):
(WebKit::OptionItem::decode):
(WebKit::WKOptionItem::encode): Deleted.
(WebKit::WKOptionItem::decode): Deleted.
- Shared/AssistedNodeInformation.h:
(WebKit::OptionItem::OptionItem):
(WebKit::AssistedNodeInformation::AssistedNodeInformation):
(WebKit::WKOptionItem::WKOptionItem): Deleted.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView inputView]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView _updateAccessory]):
(-[WKContentView textInputTraits]):
(-[WKContentView assistedNodeSelectOptions]):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):
(-[WKContentView _stopAssistingNode]):
- UIProcess/ios/forms/WKFormInputControl.mm:
(-[WKDateTimePicker initWithView:datePickerMode:]):
(-[WKFormInputControl initWithView:]):
- UIProcess/ios/forms/WKFormSelectControl.h:
- UIProcess/ios/forms/WKFormSelectControl.mm:
(adjustedFontSize):
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKOptionPickerCell initWithOptionItem:]):
(-[WKOptionGroupPickerCell initWithOptionItem:]):
(-[WKMultipleSelectPicker initWithView:]):
(-[WKMultipleSelectPicker pickerView:viewForRow:forComponent:reusingView:]):
(-[WKMultipleSelectPicker pickerView:row:column:checked:]):
(-[WKSelectSinglePicker pickerView:attributedTitleForRow:forComponent:]):
(-[WKSelectSinglePicker pickerView:didSelectRow:inComponent:]):
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectTableViewController initWithView:hasGroups:]):
(-[WKSelectTableViewController tableView:numberOfRowsInSection:]):
(-[WKSelectTableViewController tableView:titleForHeaderInSection:]):
(-[WKSelectTableViewController populateCell:withItem:]):
(-[WKSelectTableViewController findItemIndexAt:]):
(-[WKSelectTableViewController findItemAt:]):
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectTableViewController tableView:didSelectRowAtIndexPath:]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getAssistedNodeInformation):
- 2:32 PM Changeset in webkit [170320] by
-
- 14 edits in trunk/Source/WebKit2
[Cocoa] No way to grant storage quotas for web application cache
https://bugs.webkit.org/show_bug.cgi?id=134213
Reviewed by Anders Carlsson.
- UIProcess/API/APIUIClient.h:
(API::UIClient::reachedApplicationCacheOriginQuota): Added this new client function, with
a default implementation that calls the completion handler with the current quota.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Declared a new delegate method.
- UIProcess/API/Cocoa/_WKSecurityOrigin.mm:
(-[_WKSecurityOrigin _initWithSecurityOrigin:WebCore::]): Changed the parameter into a const
reference, since we copy it.
- UIProcess/API/Cocoa/_WKSecurityOriginInternal.h:
- UIProcess/Cocoa/UIDelegate.h: Override API::UIClient::reachedApplicationCacheOriginQuota.
Added flag to m_delegateMethods struct for new delegate method.
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate): Set new flag in m_delegateMethods struct.
(WebKit::UIDelegate::UIClient::exceededDatabaseQuota): Updated for change in
_WKSecurityOrigin initializer.
(WebKit::UIDelegate::UIClient::reachedApplicationCacheOriginQuota): Added. Calls the new
delegate method.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reachedApplicationCacheOriginQuota): Added. Forwards the message to
the UI client.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Added ReachedApplicationCacheOriginQuota message.
- WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:
(API::InjectedBundle::PageUIClient::didReachApplicationCacheOriginQuota): Changed the return
type to bool, indicating whether the client handled the callback.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota): Return the
appropriate value.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota): If the bundle client didn’t
handle the callback, send a message the the UI process, and update the quota with the reply.
- 2:32 PM Changeset in webkit [170319] by
-
- 17 edits in trunk/Source/WebKit2
[wk2] Synchronously wait a short time for a layer tree update after bringing a web view in-window
https://bugs.webkit.org/show_bug.cgi?id=134189
Reviewed by Simon Fraser.
Make the old behavior of -[WKView endDeferringViewInWindowChangesSync] the default; synchronously wait
for a fraction of a second when a page that was previously in-window but currently isn't comes back in-window,
until new content is painted (or we hit a timeout).
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::waitForDidUpdateViewState):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForDidUpdateViewState):
Delegate waitForDidUpdateViewState to the DrawingAreaProxys, because behavior is very dependent on them.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::coreAnimationDidCommitLayers):
(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateViewState):
Implement waitForDidUpdateViewState for the RemoteLayerTree; it waits for CommitLayerTree.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::dispatchViewStateChange):
(WebKit::WebPageProxy::waitForDidUpdateViewState):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::viewSize): Deleted.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::didUpdateViewState):
- UIProcess/API/mac/WKView.mm:
(-[WKView endDeferringViewInWindowChangesSync]):
Always waitForDidUpdateViewState when a page that was previously in-window but currently isn't comes back in-window.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::viewStateDidChange):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setViewState):
(WebKit::WebPage::didUpdateViewStateTimerFired): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::viewStateDidChange):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::viewStateDidChange):
(WebKit::TiledCoreAnimationDrawingArea::didUpdateViewStateTimerFired):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::didUpdateViewStateTimerFired): Deleted.
Delegate sending of didUpdateViewState to the DrawingAreas (RemoteLayerTreeDrawingArea won't send it,
because the UI process waits for CommitLayerTree instead).
- 2:27 PM Changeset in webkit [170318] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Crash in SourceBuffer::sourceBufferPrivateDidReceiveRenderingError()
https://bugs.webkit.org/show_bug.cgi?id=134211
Reviewed by Eric Carlson.
Null-check m_source before dereferencing, as the SourceBuffer may have been removed
from its MediaSource before this error was received.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError):
- 2:24 PM Changeset in webkit [170317] by
-
- 2 edits in tags/Safari-538.42/Source/WebKit2
Merged r170311.
- 2:12 PM Changeset in webkit [170316] by
-
- 15 edits in trunk/Source/WebKit2
[iOS][wk2] Ensure that layers are marked volatile before allowing the process to suspend
https://bugs.webkit.org/show_bug.cgi?id=134004
<rdar://problem/17186342>
Reviewed by Simon Fraser.
WebKit tries to make layers volatile when unparented, but sometimes isn't given
a chance to do so before the process gets suspended, so we end up with lots of
non-volatile surfaces that should really be volatile.
- Shared/mac/RemoteLayerBackingStoreCollection.h:
- Shared/mac/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::markBackingStoreVolatileImmediately):
(WebKit::RemoteLayerBackingStoreCollection::markAllBackingStoreVolatileImmediatelyIfPossible):
Add markAllBackingStoreVolatileImmediatelyIfPossible, which tries to mark *all*
buffers of *all* backing store, (live and unreachable), (front, back, and secondary),
volatile right away. It returns false if any buffer isn't marked volatile (because it was in-use).
- UIProcess/ios/ProcessThrottler.h:
- UIProcess/ios/ProcessThrottler.mm:
(WebKit::ProcessThrottler::updateAssertion):
(WebKit::ProcessThrottler::processReadyToSuspend):
(WebKit::ProcessThrottler::didCancelProcessSuspension):
- UIProcess/ios/WebProcessProxyIOS.mm:
(WebKit::WebProcessProxy::sendCancelProcessWillSuspend):
(WebKit::WebProcessProxy::didCancelProcessSuspension):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
If the UI process is waiting for the Web process to confirm that it can suspend
and something happens (the view is reparented) that cancels the suspension, inform
the Web process that this happened, so that it can cancel any cleanup that might still be taking place.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
If a view goes in-window, dispatch the view state change immediately without delay,
to minimize the latency between coming in-window and being ready to go.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::markLayersVolatileImmediatelyIfPossible):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
Schedule a flush when we change the root layer; otherwise, we can end up
detaching the root layer but changing nothing else, and never committing that change.
(WebKit::RemoteLayerTreeDrawingArea::markLayersVolatileImmediatelyIfPossible):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::processWillSuspend):
(WebKit::WebProcess::cancelProcessWillSuspend):
(WebKit::WebProcess::markAllLayersVolatileIfPossible):
(WebKit::WebProcess::processSuspensionCleanupTimerFired):
When the UI process is going to suspend the process, it sends us ProcessWillSuspend,
and defers the suspension until we send a ProcessReadyToSuspend back.
Delay ProcessReadyToSuspend until all layers in our process have been marked volatile.
We'll keep trying every 20ms until they're all volatile. For safety, the UI process will eventually
stop waiting for us, but the volatility change is usually applied successfully within the first
or second timer callback.
- 2:01 PM Changeset in webkit [170315] by
-
- 3 edits in trunk/Source/WebCore
Reduce synchronous layout triggered by JavaScript-based media controls
https://bugs.webkit.org/show_bug.cgi?id=134208
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-23
Reviewed by Eric Carlson.
Avoid always querying the offsetWidth and offsetHeight of the timeline
by only calculating these values when the timeline may change size.
Also avoid doing work in a few cases where properties did not
actually change.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.setNeedsTimelineMetricsUpdate):
(Controller.prototype.updateTimelineMetricsIfNeeded):
Only update the timeline metrics when they may have changed.
(Controller.prototype.updateControls):
(Controller.prototype.handleTimelineMouseMove):
(Controller.prototype.progressFillStyle):
(Controller.prototype.showControls):
(Controller.prototype.addControls):
Mark timeline metrics need update based on various UI changes.
(Controller.prototype.setStatusHidden):
Only do work if the hidden status changed.
Mark timeline metrics need update if the timeline is changed.
(Controller.prototype.updateProgress):
Use cached timeline metrics instead of always querying offsetWidth/offsetHeight.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS):
(ControllerIOS.prototype.updateControls):
(ControllerIOS.prototype.updateProgress):
Use cached timeline metrics instead of always querying offsetWidth/offsetHeight.
(ControllerIOS.prototype.handleWirelessPlaybackChange):
Mark timeline metrics need update as button may have changed.
(ControllerIOS.prototype.handleWirelessTargetAvailableChange):
Only do work if the availability changed.
Mark timeline metrics need update as a new button may have appeared.
(ControllerIOS.prototype.set pageScaleFactor):
Only do work if the page scale factor changed.
- 1:24 PM Changeset in webkit [170314] by
-
- 2 edits in trunk/Source/WebCore
Add skeleton code for updated Gamepad API
https://bugs.webkit.org/show_bug.cgi?id=134165
Unreviewed - Forgotten review feedback from http://trac.webkit.org/changeset/170309
- Modules/gamepad/GamepadButton.idl: Forgot to commit the removal of NoInterfaceObject here.
- 1:19 PM Changeset in webkit [170313] by
-
- 5 edits in trunk/Source/WebKit2
Ensure that we always use symlink free paths when specifying cache directories
https://bugs.webkit.org/show_bug.cgi?id=134206
Reviewed by Anders Carlsson.
Sandboxing will deny symlink based paths, so we use realpath to create extensions.
This leaves us in the position of an extension using a visually different path
from other parts of the process code. This patch simply makes sure that we always
use the realpath for cache directories, so making debugging easier and also ensuring
that we don't ever accidentally try to use a path with symlinks that will thus get
denied.
- Shared/SandboxExtension.h:
(WebKit::stringByResolvingSymlinksInPath):
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::stringByResolvingSymlinksInPath):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureNetworkProcess):
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
(WebKit::WebContext::platformDefaultDiskCacheDirectory):
(WebKit::WebContext::platformDefaultWebSQLDatabaseDirectory):
(WebKit::WebContext::platformDefaultIconDatabasePath):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
- 12:58 PM Changeset in webkit [170312] by
-
- 3 edits in trunk/Source/JavaScriptCore
Inline the UnlinkedInstructionStream::Reader logic.
<https://webkit.org/b/134203>
This class is only used by CodeBlock to unpack the unlinked instructions,
and we were spending 0.5% of total time on PLT calling Reader::next().
Move the logic to the header file and mark it ALWAYS_INLINE.
Reviewed by Geoffrey Garen.
- bytecode/UnlinkedInstructionStream.cpp:
- bytecode/UnlinkedInstructionStream.h:
(JSC::UnlinkedInstructionStream::Reader::Reader):
(JSC::UnlinkedInstructionStream::Reader::read8):
(JSC::UnlinkedInstructionStream::Reader::read32):
(JSC::UnlinkedInstructionStream::Reader::next):
- 12:35 PM Changeset in webkit [170311] by
-
- 2 edits in trunk/Source/WebKit2
Unregister notification observer registered in r170156.
https://bugs.webkit.org/show_bug.cgi?id=134204.
Reviewed by Tim Horton.
- UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]):
- 12:29 PM Changeset in webkit [170310] by
-
- 2 edits1 copy1 add in trunk/LayoutTests
Fix a test case failing on WK1 after r170296.
There is now a non-visual render tree dump difference between WK1 and Wk2 results here due to wk1 requiring an additional style synchronization.
- platform/mac-wk2/editing/inserting: Added.
- platform/mac-wk2/editing/inserting/break-blockquote-after-delete-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt.
- platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
- 12:19 PM Changeset in webkit [170309] by
-
- 11 edits12 adds in trunk/Source/WebCore
Add skeleton code for updated Gamepad API
https://bugs.webkit.org/show_bug.cgi?id=134165
Reviewed by Dean Jackson.
No new tests (No change in behavior for any tested configuration)
Interface and dummy implementation for the Gamepad object:
- Modules/gamepad/Gamepad.cpp: Added.
(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::~Gamepad):
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):
- Modules/gamepad/Gamepad.h: Added.
- Modules/gamepad/Gamepad.idl: Added.
Interface and dummy implementation for the GamepadButton object:
- Modules/gamepad/GamepadButton.cpp: Added.
(WebCore::GamepadButton::GamepadButton):
(WebCore::GamepadButton::pressed):
- Modules/gamepad/GamepadButton.h: Added.
(WebCore::GamepadButton::create):
(WebCore::GamepadButton::value):
(WebCore::GamepadButton::setValue):
- Modules/gamepad/GamepadButton.idl: Added.
Interface and dummy implementation for the GamepadEvent object:
- Modules/gamepad/GamepadEvent.cpp: Added.
(WebCore::GamepadEvent::GamepadEvent):
- Modules/gamepad/GamepadEvent.h: Added.
(WebCore::GamepadEventInit::GamepadEventInit):
(WebCore::GamepadEvent::~GamepadEvent):
(WebCore::GamepadEvent::create):
(WebCore::GamepadEvent::gamepad):
- Modules/gamepad/GamepadEvent.idl: Added.
- dom/EventNames.in:
Interface and dummy implementation for additions to the Navigator object:
- Modules/gamepad/NavigatorGamepad.cpp: Added.
(WebCore::NavigatorGamepad::NavigatorGamepad):
(WebCore::NavigatorGamepad::supplementName):
(WebCore::NavigatorGamepad::from):
(WebCore::NavigatorGamepad::getGamepads):
(WebCore::NavigatorGamepad::gamepads):
- Modules/gamepad/NavigatorGamepad.h: Added.
- Modules/gamepad/NavigatorGamepad.idl: Added.
Bindings additions necessary for these new interfaces:
- bindings/js/JSDOMBinding.h:
(WebCore::JSValueTraits<double>::arrayJSValue):
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDictionary.h:
Project file stuff:
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCoreCommon.props:
- WebCore.vcxproj/copyForwardingHeaders.cmd:
- WebCore.xcodeproj/project.pbxproj:
- DerivedSources.make:
- 12:02 PM Changeset in webkit [170308] by
-
- 2 edits in trunk/Source/WebCore
Catch Obj-C exceptions thrown by _linenPatternImage
https://bugs.webkit.org/show_bug.cgi?id=134202
Reviewed by Geoffrey Garen.
Catch Objective-C exceptions thrown by _linenPatternImage and
-[NSImage CGImageForProposedRect:context:hints:].
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::linenBackgroundColor):
- 12:00 PM Changeset in webkit [170307] by
-
- 4 edits2 adds in trunk
CSS clip property should make layers non-opaque
https://bugs.webkit.org/show_bug.cgi?id=134147
Source/WebCore:
<rdar://problem/17324579>
Reviewed by Tim Horton.
https://www.fairphone.com has position:fixed elements with clip: rect(...)
but we were making those layers opaque, resulting in garbage pixels
in areas outside the clip rect.
Fix by checking for the clip property in RenderBox::backgroundIsKnownToBeOpaqueInRect().
Test: compositing/contents-opaque/opaque-with-clip.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
Reviewed by Tim Horton.
- compositing/contents-opaque/opaque-with-clip-expected.html: Added.
- compositing/contents-opaque/opaque-with-clip.html: Added.
- 12:00 PM Changeset in webkit [170306] by
-
- 5 edits2 adds in trunk
Adding a mask on a simple color compositing layer removes the content
https://bugs.webkit.org/show_bug.cgi?id=134127
Reviewed by Dean Jackson.
Source/WebCore:
In r169053 I moved some updateDrawsContent() into updateAfterDescendents(),
but this isn't called when a composited layer gains or loses a mask (which
doesn't cause a layout). This caused us to fail to allocate backing store
when gaining a mask, resulting in missing content.
Fix by calling updateAfterDescendents() from RenderLayer::styleChange()
when the layer config isn't changing.
Also remove a condition in isSimpleContainerCompositingLayer() that caused us
to fall off the simple layer path for masked layers, since this works just
fine.
Test: compositing/masks/solid-color-masked.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
LayoutTests:
- compositing/masks/mask-layer-size-expected.txt:
- compositing/masks/solid-color-masked-expected.html: Added.
- compositing/masks/solid-color-masked.html: Added.
- 12:00 PM Changeset in webkit [170305] by
-
- 2 edits in trunk/Tools
Enable the Web Inspector in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=134148
Reviewed by Joseph Pecoraro.
Set the pref to enable Web Inspector in both WK1 and WK2 windows.
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate applicationDidFinishLaunching:]):
- 11:56 AM Changeset in webkit [170304] by
-
- 23 edits3 adds in trunk
[New Multicolumn] Writing mode changes on the <html> and RenderView need to
be propagated to column sets and flow thread children of those renderers.
https://bugs.webkit.org/show_bug.cgi?id=134121
<rdar://problem/16884527>
Reviewed by Dean Jackson.
Source/WebCore:
Added fast/multicol/pagination/RightToLeft-rl-dynamic.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::styleDidChange):
Refactor the propagation code for column sets and flow thread styles into a helper
function that is called here.
(WebCore::RenderBlockFlow::updateStylesForColumnChildren):
- rendering/RenderBlockFlow.h:
Add a new helper function for recalculating the styles of the column sets and
flow thread in response to changes.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
When the style is changed for a root element or the RenderView in response to
writing mode and direction changes, make sure that style gets propagated to
the column children by calling the new helper function.
LayoutTests:
- fast/multicol/pagination/RightToLeft-rl-dynamic.html: Added.
- platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-lr-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-tb-expected.png:
- platform/mac/fast/multicol/pagination/nested-transforms-expected.png:
- 11:25 AM Changeset in webkit [170303] by
-
- 9 edits3 adds in trunk/Source/WebKit2
[Cocoa] No way to grant storage quotas for WebSQL
https://bugs.webkit.org/show_bug.cgi?id=134175
Reviewed by Anders Carlsson.
- Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::securityOrigin): Changed to return a non-const reference.
- UIProcess/API/APIUIClient.h:
(API::UIClient::exceededDatabaseQuota): Added a completion handler parameter than takes the
new quota, and changed the return type to void.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient): Changed the override of exceededDatabaseQuota to call the
completion handler with the new quota, or with the existing quota if the client doesn’t
implement the callback.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Declared new delegate method.
- UIProcess/API/Cocoa/_WKSecurityOrigin.h: Added.
- UIProcess/API/Cocoa/_WKSecurityOrigin.mm: Added.
(-[_WKSecurityOrigin _initWithSecurityOrigin:WebCore::]): Store the origin in an ivar.
(-[_WKSecurityOrigin protocol]): Added this accessor.
(-[_WKSecurityOrigin host]): Ditto.
(-[_WKSecurityOrigin port]): Ditto.
- UIProcess/API/Cocoa/_WKSecurityOriginInternal.h: Added.
- UIProcess/Cocoa/UIDelegate.h: Override API::UIClient::exceededDatabaseQuota. Added flag
to m_delegateMethods struct for new delegate method.
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate): Set new flag in m_delegateMethods struct.
(WebKit::UIDelegate::UIClient::exceededDatabaseQuota): Added. Calls the new delegate method.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::exceededDatabaseQuota): Updated for the new client interface: now
passing a completion handler that replies with the new quota.
- WebKit2.xcodeproj/project.pbxproj: Added references to new files, sorted a group.
- 11:16 AM Changeset in webkit [170302] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=134183
Follow-up review from Sam Weinig.
- platform/graphics/GraphicsContext3D.h: Merge another bit of MAC and IOS
code.
- ChangeLog: Actually read his review comments this time.
- 11:01 AM Changeset in webkit [170301] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Uncaught exception crash when destroying MediaPlayerPrivateAVFoundationObjC
https://bugs.webkit.org/show_bug.cgi?id=134198
Reviewed by Eric Carlson.
Now that we always create an AVPlayerLayer when creating an AVPlayer, but we don't
return that layer from platformLayer() unless we've been asked to, we no longer are
asked to destroy our video layer from MediaPlayerPrivateAVFoundation::tearDownVideoRendering().
Instead, explicitly destroy our video layer (and remove the KVO-observer which is
causing this exception) in the MediaPlayerPrivateAVFoundationObjC destructor.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):
- 10:50 AM Changeset in webkit [170300] by
-
- 2 edits in trunk/Source/WebKit2
More build fixing after r170295.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 10:39 AM Changeset in webkit [170299] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix build.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 10:27 AM Changeset in webkit [170298] by
-
- 14 edits in trunk/Source/WebKit2
Give read-only properties proper ownership attributes
https://bugs.webkit.org/show_bug.cgi?id=134197
<rdar://problem/16830117>
Reviewed by Dan Bernstein.
Also, make WKFrameInfo conform to NSCopying since it's a data-only object and thus intended to be copied.
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKFrameInfo.mm:
(-[WKFrameInfo copyWithZone:]):
(-[WKFrameInfo setRequest:]): Deleted.
- UIProcess/API/Cocoa/WKNavigation.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
- UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction setSourceFrame:]):
(-[WKNavigationAction setTargetFrame:]):
- UIProcess/API/Cocoa/WKNavigationActionInternal.h:
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKUserScript.h:
- UIProcess/API/Cocoa/WKWebView.h:
- 10:07 AM Changeset in webkit [170297] by
-
- 4 edits in trunk/Source/WebCore
Remove unused FrameView::setUseCustomFixedPositionLayoutRect().
<https://webkit.org/b/134194>
Reviewed by Anders Carlsson.
- WebCore.exp.in:
- page/FrameView.cpp:
(WebCore::FrameView::setUseCustomFixedPositionLayoutRect): Deleted.
- page/FrameView.h:
- 10:02 AM Changeset in webkit [170296] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION (r160908): Unable to unset bold while entering text
https://bugs.webkit.org/show_bug.cgi?id=134196
<rdar://problem/17051653>
Reviewed by Andreas Kling.
No test, this code path is used by some WK1 API clients only.
- editing/Editor.cpp:
(WebCore::Editor::styleForSelectionStart):
This needs to update the style before requesting the renderer.
- editing/Editor.h:
- editing/ios/EditorIOS.mm:
(WebCore::styleForSelectionStart): Deleted.
- editing/mac/EditorMac.mm:
(WebCore::styleForSelectionStart): Deleted.
Removed the duplicated functions, moved to Editor.cpp.
- 9:39 AM Changeset in webkit [170295] by
-
- 5 edits in trunk/Source/WebCore
[iOS] Fix video in WebGL.
https://bugs.webkit.org/show_bug.cgi?id=133511
Reviewed by Jer Noble.
- WebCore.exp.in:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin):
(WebCore::wkAVAssetResolvedURL): Deleted.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Declare and use resolvedURL on AVURLAsset instead of using wkAVAssetResolvedURL through WebKitSystemInterface.
- 8:25 AM Changeset in webkit [170294] by
-
- 1 edit8 copies1 delete in trunk/LayoutTests
[EFL] Move WebKit2 test results into LayoutTests/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=134192
Unreviewed gardening, moving files into LayoutTests/platform/efl after removing EFL WebKit1.
- platform/efl/webaudio/oscillator-custom-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/oscillator-custom-expected.wav.
- platform/efl/webaudio/oscillator-sawtooth-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/oscillator-sawtooth-expected.wav.
- platform/efl/webaudio/oscillator-sine-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/oscillator-sine-expected.wav.
- platform/efl/webaudio/oscillator-square-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/oscillator-square-expected.wav.
- platform/efl/webaudio/oscillator-triangle-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/oscillator-triangle-expected.wav.
- platform/efl/webaudio/up-mixing-mono-51-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/up-mixing-mono-51-expected.wav.
- platform/efl/webaudio/up-mixing-mono-stereo-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/up-mixing-mono-stereo-expected.wav.
- platform/efl/webaudio/up-mixing-stereo-51-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/up-mixing-stereo-51-expected.wav.
- 8:21 AM Changeset in webkit [170293] by
-
- 1 edit5 moves in trunk/LayoutTests
[EFL] Move WebKit2 test results into LayoutTests/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=134192
Unreviewed gardening, moving files into LayoutTests/platform/efl after removing EFL WebKit1.
- platform/efl/webaudio/audiobuffersource-loop-points-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-loop-points-expected.wav.
- platform/efl/webaudio/audiobuffersource-multi-channels-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-multi-channels-expected.wav.
- platform/efl/webaudio/audiobuffersource-playbackrate-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-playbackrate-expected.wav.
- platform/efl/webaudio/gain-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/gain-expected.wav.
- platform/efl/webaudio/mixing-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/mixing-expected.wav.
- 8:13 AM Changeset in webkit [170292] by
-
- 1 edit40 copies1 move5 adds2 deletes in trunk/LayoutTests
[EFL] Move WebKit2 test results into LayoutTests/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=134192
Unreviewed gardening, moving files into LayoutTests/platform/efl after removing EFL WebKit1.
- platform/efl/fast/: Renamed from LayoutTests/platform/efl-wk2/fast/.
- platform/efl/webaudio/audiobuffersource-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/audiobuffersource-expected.wav.
- platform/efl/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav.
- platform/efl/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.txt: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.txt.
- platform/efl/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.txt: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.txt.
- platform/efl/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.txt: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.txt.
- platform/efl/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav.
- platform/efl/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Renamed from LayoutTests/platform/efl-wk2/webaudio/codec-tests/wav/24bit-44khz-expected.wav.
- 7:59 AM Changeset in webkit [170291] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r168046): Incorrect handling of object information in WebCore::RenderFlowThread::removeLineRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=133587
Reviewed by Antti Koivisto.
When an object flowed in multicol is moved from in-flow positioning to out-of-flow positioning,
its information must be removed from the flowthread prior to the change being made.
Otherwise, the flow thread will no longer be its containing block and a reference to it
will not be possible to obtain.
No new tests can be added because the code still hits in an unrelated assertion followed by a null dereference.
The issue was discussed with Antti Koivisto and we decided its better to fix this problem first and
handle the following issue in a separate bug.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::styleWillChange):
- rendering/RenderObject.h:
(WebCore::RenderObject::flowThreadContainingBlock):
- 7:59 AM Changeset in webkit [170290] by
-
- 9 edits87 copies5 adds25 deletes in trunk/LayoutTests
[EFL] Move WebKit2 test results into LayoutTests/platform/efl
Unreviewed gardening, moving files into LayoutTests/platform/efl after removing EFL WebKit1.
- platform/efl/accessibility/: Renamed from LayoutTests/platform/efl-wk2/accessibility/.
- platform/efl/compositing/: Renamed from LayoutTests/platform/efl-wk2/compositing/.
- platform/efl/editing/: Renamed from LayoutTests/platform/efl-wk2/editing/.
- platform/efl/fast/: Renamed from LayoutTests/platform/efl-wk2/fast/.
- platform/efl/http/: Renamed from LayoutTests/platform/efl-wk2/http/.
- platform/efl/ietestcenter: Renamed from LayoutTests/platform/efl-wk2/ietestcenter/.
- platform/efl/inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local-expected.txt: Renamed from LayoutTests/platform/efl-wk2/inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local-expected.txt.
- platform/efl/loader/go-back-cached-main-resource-expected.txt: Renamed from LayoutTests/platform/efl-wk2/loader/go-back-cached-main-resource-expected.txt.
- platform/efl/media/video-layer-crash-expected.png: Renamed from LayoutTests/platform/efl-wk2/media/video-layer-crash-expected.png.
- platform/efl/media/video-transformed-expected.png: Renamed from LayoutTests/platform/efl-wk2/media/video-transformed-expected.png.
- platform/efl/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/efl-wk2/media/video-zoom-controls-expected.png.
- platform/efl/media/video-zoom-expected.png: Renamed from LayoutTests/platform/efl-wk2/media/video-zoom-expected.png.
- platform/efl/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Renamed from LayoutTests/platform/efl-wk2/plugins/npruntime/object-from-destroyed-plugin-expected.txt.
- platform/efl/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Renamed from LayoutTests/platform/efl-wk2/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt.
- platform/efl/svg/: Renamed from LayoutTests/platform/efl-wk2/svg/.
- platform/efl/transforms/2d/hindi-rotated-expected.png:
- platform/efl/transforms/2d/hindi-rotated-expected.txt:
- 6:33 AM Changeset in webkit [170289] by
-
- 1 edit110 deletes in trunk/Source/WebKit
[EFL] Remove the WebKit1 EFL code
https://bugs.webkit.org/show_bug.cgi?id=134096
Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2014-06-23
Reviewed by Gyuyoung Kim.
- PlatformEfl.cmake: Removed.
- efl: Removed entire efl directory.
- 5:13 AM Changeset in webkit [170288] by
-
- 8 edits3 adds in trunk
[EFL] Platform support for WebSpeech feature.
https://bugs.webkit.org/show_bug.cgi?id=116438
Reviewed by Csaba Osztrogonác.
.:
Add ENABLE_SPEECH_SYNTHESIS flag to have Speech Synthesis in EFL.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/WebCore:
It's a first step of adding support for Speech Synthesis in EFL port.
Just stub out required API and support for compilation.
- CMakeLists.txt:
- PlatformEfl.cmake:
- PlatformGTK.cmake: Added some idls to not break GTK build.
- platform/PlatformSpeechSynthesizer.h:
- platform/efl/PlatformSpeechSynthesisProviderEfl.cpp: Added.
(WebCore::PlatformSpeechSynthesisProviderEfl::PlatformSpeechSynthesisProviderEfl):
(WebCore::PlatformSpeechSynthesisProviderEfl::~PlatformSpeechSynthesisProviderEfl):
(WebCore::PlatformSpeechSynthesisProviderEfl::initializeVoiceList):
(WebCore::PlatformSpeechSynthesisProviderEfl::pause):
(WebCore::PlatformSpeechSynthesisProviderEfl::resume):
(WebCore::PlatformSpeechSynthesisProviderEfl::speak):
(WebCore::PlatformSpeechSynthesisProviderEfl::cancel):
- platform/efl/PlatformSpeechSynthesisProviderEfl.h: Added.
- platform/efl/PlatformSpeechSynthesizerEfl.cpp: Added.
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::cancel):
- 4:11 AM Changeset in webkit [170287] by
-
- 6 edits in trunk/Source/WebCore
Make it clear to get m_svgExtensions using svgExtensions().
https://bugs.webkit.org/show_bug.cgi?id=134186.
Patch by Jeongeun Kim <je_julie.kim@samsung.com> on 2014-06-23
Reviewed by Dirk Schulze.
This patch makes sure that the purpose of code is to get m_svgExtensions
as changing accessSVGExtensions() to svgExtensions().
svgExtensions() is a getter API and accessSVGExtensions() checks
the presence of m_svgExtensions and create m_svgExtensions if it does not exist.
No new tests, no behavior change.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
- dom/Document.cpp:
(WebCore::Document::commonTeardown):
(WebCore::Document::implicitClose):
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::startAnimations):
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::rebuildElements):
- svg/SVGDocumentExtensions.h:
- 1:09 AM Changeset in webkit [170286] by
-
- 2 edits1 delete in trunk/LayoutTests
REGRESSION (r170257) http/tests/navigation/javascriptlink-frames.html fails on MountainLion
https://bugs.webkit.org/show_bug.cgi?id=134182
Rebaseline for Mountain Lion.
- platform/mac-mountainlion/TestExpectations: Removed.
- platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt:
- 1:04 AM Changeset in webkit [170285] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=134183
Reviewed by Sam Weinig.
GraphicsContext3D has a reference to a WebGLLayer that was
hidden behind a PlatformLayer. This meant we had to cast it
to use a WebGLLayer method.
- platform/graphics/GraphicsContext3D.h: Replace RefPtr<PlatformLayer>
with RefPtr<WebGLLayer>.
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::~GraphicsContext3D): No need to cast.
- 12:27 AM Changeset in webkit [170284] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, GTK build fix after r170274.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
Drawing::m_webPage changed to reference.
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::setNeedsDisplayInRect):
(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::updatePreferences):
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::updateBackingStoreState):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
- WebProcess/WebPage/DrawingAreaImpl.h:
- 12:10 AM Changeset in webkit [170283] by
-
- 2 edits in trunk
Unreviewed, GTK build fix after r170266.
- Source/cmake/OptionsGTK.cmake: Geoclue also requires gio-unix.
Jun 22, 2014:
- 9:28 PM Changeset in webkit [170282] by
-
- 5 edits in trunk/Source/WebCore
Make offset from ancestor computation explicit by moving it to the callers.
https://bugs.webkit.org/show_bug.cgi?id=134168.
Reviewed by Simon Fraser.
Explicit offset computation helps code reading and less error-prone than passing
the offset pointer and compute it locally when it is null.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::transparencyClipBox):
(WebCore::performOverlapTests):
(WebCore::RenderLayer::setupClipPath):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
- 8:46 PM Changeset in webkit [170281] by
-
- 5 edits in trunk/Source
Versioning.
- 8:42 PM Changeset in webkit [170280] by
-
- 1 copy in tags/Safari-538.42
New Tag.
- 7:25 PM Changeset in webkit [170279] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r170163): It made everything crash on EFL
https://bugs.webkit.org/show_bug.cgi?id=134097
Unreviewed EFL layout test and perforamcne crash fix.
- WebProcess/WebPage/WebPage.cpp: Add a null check for m_mainFrame.
(WebKit::WebPage::didCompletePageTransition):
- 7:15 PM Changeset in webkit [170278] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed EFL build fix since r170274. Use reference for m_webPage member variable.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::CoordinatedDrawingArea):
(WebKit::CoordinatedDrawingArea::setNeedsDisplay):
(WebKit::CoordinatedDrawingArea::setNeedsDisplayInRect):
(WebKit::CoordinatedDrawingArea::forceRepaint):
(WebKit::CoordinatedDrawingArea::updatePreferences):
(WebKit::CoordinatedDrawingArea::mainFrameContentSizeChanged):
(WebKit::CoordinatedDrawingArea::layerHostDidFlushLayers):
(WebKit::CoordinatedDrawingArea::updateBackingStoreState):
(WebKit::CoordinatedDrawingArea::sendDidUpdateBackingStoreState):
(WebKit::CoordinatedDrawingArea::suspendPainting):
(WebKit::CoordinatedDrawingArea::resumePainting):
(WebKit::CoordinatedDrawingArea::enterAcceleratedCompositingMode):
(WebKit::CoordinatedDrawingArea::display):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
- 6:32 PM Changeset in webkit [170277] by
-
- 3 edits in trunk/Source/WebKit2
[iOS][wk2] Swiping back sometimes results in a missing (not blank) swipe snapshot
https://bugs.webkit.org/show_bug.cgi?id=134181
Reviewed by Benjamin Poulain.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):
(WebKit::ViewGestureController::removeSwipeSnapshot):
- UIProcess/mac/ViewGestureController.h:
Make it explicit that we should only remove the swipe snapshot when a
big-enough render tree size arrives *after the swipe ends*.
- 6:19 PM Changeset in webkit [170276] by
-
- 1 edit1 add in trunk/LayoutTests
REGRESSION (r170257) http/tests/navigation/javascriptlink-frames.html fails on MountainLion
https://bugs.webkit.org/show_bug.cgi?id=134182
Unreviewed gardening.
- platform/mac-mountainlion/TestExpectations: Added, skip the test.
- 6:02 PM Changeset in webkit [170275] by
-
- 13 edits9 adds in branches/ftlopt
[ftlopt] Fold GetById/PutById to MultiGetByOffset/GetByOffset or MultiPutByOffset/PutByOffset, which implies handling non-singleton sets
https://bugs.webkit.org/show_bug.cgi?id=134090
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This pretty much finishes off the work to eliminate the special-casing of singleton
structure sets by making it possible to fold GetById and PutById to various polymorphic
forms of the ByOffset nodes.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h:
- bytecode/PutByIdVariant.h:
(JSC::PutByIdVariant::constantChecks):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::addChecks):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToMultiGetByOffset):
(JSC::DFG::Node::convertToMultiPutByOffset):
- dfg/DFGSpeculativeJIT64.cpp: Also convert all release assertions to DFG assertions in this file, because I was hitting some of them while debugging.
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Strict):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::set):
LayoutTests:
- js/regress/fold-get-by-id-to-multi-get-by-offset-expected.txt: Added.
- js/regress/fold-get-by-id-to-multi-get-by-offset-rare-int-expected.txt: Added.
- js/regress/fold-get-by-id-to-multi-get-by-offset-rare-int.html: Added.
- js/regress/fold-get-by-id-to-multi-get-by-offset.html: Added.
- js/regress/fold-put-by-id-to-multi-put-by-offset-expected.txt: Added.
- js/regress/fold-put-by-id-to-multi-put-by-offset.html: Added.
- js/regress/script-tests/fold-get-by-id-to-multi-get-by-offset-rare-int.js: Added.
(foo):
(fu):
(bar):
(.bar):
(Number):
- js/regress/script-tests/fold-get-by-id-to-multi-get-by-offset.js: Added.
(foo):
(fu):
(bar):
(.bar):
(Number):
- js/regress/script-tests/fold-put-by-id-to-multi-put-by-offset.js: Added.
(foo):
(fu):
(bar):
(.bar):
- 5:51 PM Changeset in webkit [170274] by
-
- 22 edits in trunk/Source/WebKit2
Thread some references through the remote layer tree code
https://bugs.webkit.org/show_bug.cgi?id=134177
Reviewed by Zalan Bujtas.
A first pass at references for never-null things (first pass because I didn't touch the collections).
Things that aren't straightforward reference-threading:
- Shared/mac/RemoteLayerBackingStoreCollection.h:
- Shared/mac/RemoteLayerBackingStoreCollection.mm:
Remove the unimplemented/nonexistant RemoteLayerBackingStoreCollection::create.
Make RemoteLayerBackingStoreCollection constructor not take a context, because m_context is never used.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
Factor out grabbing the PlatformLayerID in a few places.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
Use WebPage::mainFrameView() instead of WebPage::corePage()->mainFrame().view().
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
- WebProcess/WebPage/DrawingArea.cpp:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:om):
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:
- Shared/mac/RemoteLayerBackingStore.mm:
References.
- 5:34 PM Changeset in webkit [170273] by
-
- 5 edits in trunk/Source/WebCore
Transition layer offsets from LayoutPoint to LayoutSize.
https://bugs.webkit.org/show_bug.cgi?id=134156
Reviewed by Simon Fraser.
Use better representation for offset values.
No change in functionality.
- platform/graphics/LayoutSize.h:
(WebCore::roundedForPainting):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::fragmentsBoundingBox):
- rendering/RenderLayer.cpp:
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::computeReferenceBox):
(WebCore::RenderLayer::setupClipPath):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::collectLayerFragments):
- 5:13 PM Changeset in webkit [170272] by
-
- 2 edits in trunk/Source/WebCore
Attempted iOS build fix.
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::~GraphicsContext3D): Cast to WebGLLayer.
- 5:00 PM Changeset in webkit [170271] by
-
- 4 edits in trunk/Source/WebCore
[Apple] WebGL layer may use GC3D after free with remote layer hosting
https://bugs.webkit.org/show_bug.cgi?id=134179
<rdar://problem/17412931>
Reviewed by Tim Horton.
With remote layer hosting, a WebGLLayer may attempt to draw after
the GraphicsContext3D has been destroyed. We need to make sure
the GC3D tells the WebGLLayer that it is no longer valid.
While here, I changed some return 0 to return nullptr, the
name of the ObjC property member from m_context to _context,
and removed some unnecessary .get() calls.
This is tested by run-webkit-tests with the --remote-layer-tree
option.
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D): No need for .get().
(WebCore::GraphicsContext3D::~GraphicsContext3D): Set the context reference on WebGLLayer
to be null.
(WebCore::GraphicsContext3D::setRenderbufferStorageFromDrawable): No need for .get().
- platform/graphics/mac/WebGLLayer.h: Set the context reference on WebGLLayer
to be null.
- platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer initWithGraphicsContext3D:]): Rename m_context to _context.
(-[WebGLLayer copyCGLPixelFormatForDisplayMask:]): Check for null.
(-[WebGLLayer copyCGLContextForPixelFormat:]): Rename to _context.
(-[WebGLLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Check for null.
(-[WebGLLayer copyImageSnapshotWithColorSpace:]): Ditto.
(-[WebGLLayer display]): Ditto.
- 11:35 AM Changeset in webkit [170270] by
-
- 4 edits3 adds in trunk
[WK2] Frameset frames are not scrollable after loading (and should be)
https://bugs.webkit.org/show_bug.cgi?id=134151
<rdar://problem/17403365>
Reviewed by Dan Bates.
Source/WebCore:
When loading a <frameset>, we could end up with an empty non-fast-scrollable
region for the main frame, because after the initial frameset document layout,
nothing updated the non-fast scrollable region as the subframes added their
scrollable areas to the the main frame's scrollable area set.
Fix by having addScrollableArea() and removeScrollableArea() trigger an update
of the non-fast scrollable region.
Test: platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html
- page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
(WebCore::FrameView::scrollableAreaSetChanged):
- page/FrameView.h:
LayoutTests:
Frameset test that dumps the scrolling tree.
- platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/resources/scrollable-page.html: Added.
- 11:21 AM Changeset in webkit [170269] by
-
- 8 edits in trunk/Source/WebKit2
Replace a couple of uses of bind with lambdas
https://bugs.webkit.org/show_bug.cgi?id=134172
Reviewed by Sam Weinig.
- Platform/IPC/Connection.cpp:
(IPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
(IPC::Connection::connectionDidClose):
(IPC::Connection::dispatchMessage):
(IPC::Connection::dispatchConnectionDidClose): Deleted.
- Platform/IPC/Connection.h:
- Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::NP_Deallocate):
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginThreadAsyncCall):
(WebKit::NetscapePlugin::handlePluginThreadAsyncCall): Deleted.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::forceRepaintAsync):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
- 11:09 AM Changeset in webkit [170268] by
-
- 36 edits in trunk/Source/WebCore
Unreviewed, rolling out r170265.
https://bugs.webkit.org/show_bug.cgi?id=134174
Broke editing tests (Requested by litherum on #webkit).
Reverted changeset:
"Use unsigneds instead of ints for indexes into a string in
text layout code"
https://bugs.webkit.org/show_bug.cgi?id=133592
http://trac.webkit.org/changeset/170265
- 11:06 AM Changeset in webkit [170267] by
-
- 11 edits in trunk
Have scrollingTreeAsText() dump the non-fast-scrollable region
https://bugs.webkit.org/show_bug.cgi?id=134149
Reviewed by Sam Weinig.
Source/WebCore:
Dump the non-fast-scrollable region (as an array of rects).
- WebCore.exp.in:
- page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):
Source/WebKit2:
Dump the non-fast-scrollable region (as an array of rects).
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingTreeTextStream::dump):
LayoutTests:
Rebaselined.
- platform/mac-wk2/tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt:
- 10:49 AM Changeset in webkit [170266] by
-
- 2 edits in trunk
Disable gamepad feature on EFL and GTK ports by default
https://bugs.webkit.org/show_bug.cgi?id=134169
Reviewed by Brady Eidson.
- Source/cmake/OptionsEfl.cmake: Disable ENABLE_GAMEPAD_DEPRECATED.
- 10:17 AM Changeset in webkit [170265] by
-
- 36 edits in trunk/Source/WebCore
Use unsigneds instead of ints for indexes into a string in text layout code
https://bugs.webkit.org/show_bug.cgi?id=133592
Reviewed by Zalan Bujtas.
Migrate much of the text-handling code to use unsigneds for indexes into a string.
No new tests because there is no behavior change.
- WebCore.exp.in:
- platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForText):
(WebCore::computeUnderlineType):
- platform/graphics/Font.h:
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::drawGlyphBuffer):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::adjustSelectionRectForSimpleText):
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::size):
(WebCore::GlyphBuffer::glyphs):
(WebCore::GlyphBuffer::advances):
(WebCore::GlyphBuffer::fontDataAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::offsetAt):
(WebCore::GlyphBuffer::reverse):
(WebCore::GlyphBuffer::offsetInString):
(WebCore::GlyphBuffer::swap):
- platform/graphics/GraphicsContext.cpp:
(WebCore::TextRunIterator::atEnd):
- platform/graphics/Latin1TextIterator.h:
(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::currentCharacter):
- platform/graphics/SimpleFontData.h:
- platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::SurrogatePairAwareTextIterator):
- platform/graphics/SurrogatePairAwareTextIterator.h:
(WebCore::SurrogatePairAwareTextIterator::currentCharacter):
- platform/graphics/TextRun.h:
(WebCore::TextRun::length):
(WebCore::TextRun::charactersLength):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::glyphDataForCharacter):
(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):
- platform/graphics/WidthIterator.h:
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::adjustSelectionRectForComplexText):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/win/FontWin.cpp:
(WebCore::Font::adjustSelectionRectForComplexText):
(WebCore::Font::getGlyphsAndAdvancesForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/wince/FontWinCE.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::selectionRectForComplexText):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::selectionState):
(WebCore::adjustCharactersAndLengthForHyphen):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::positionForOffset):
(WebCore::InlineTextBox::constructTextRun):
- rendering/InlineTextBox.h:
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::getStringToRender):
- rendering/RenderCombineText.h:
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::localSelectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGInlineTextBox::paintText):
- rendering/svg/SVGInlineTextBox.h:
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair):
(WebCore::SVGTextMetricsBuilder::advance):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::SVGTextQuery::extentOfCharacterCallback):
(WebCore::SVGTextQuery::characterNumberAtPositionCallback):
- rendering/svg/SVGTextQuery.h:
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::SVGGlyphToPathTranslator):
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
- rendering/svg/SVGTextRunRenderingContext.h:
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontData.h:
- 9:58 AM Changeset in webkit [170264] by
-
- 3 edits in trunk/Source/WebKit2
Add IPC decoding support to BackForwardListState
https://bugs.webkit.org/show_bug.cgi?id=134171
Reviewed by Dan Bernstein.
- Shared/SessionState.cpp:
(WebKit::isValidEnum):
(WebKit::HTTPBody::Element::decode):
(WebKit::HTTPBody::decode):
(WebKit::FrameState::decode):
(WebKit::PageState::decode):
(WebKit::BackForwardListState::decode):
- Shared/SessionState.h:
- 9:47 AM Changeset in webkit [170263] by
-
- 2 edits in trunk/Source/WebKit2
Address a review comment.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::markInvalid):
(WebKit::decodeFormDataElement):
- 9:34 AM Changeset in webkit [170262] by
-
- 2 edits in trunk/Source/WebKit2
Implement the rest of back forward tree decoding
https://bugs.webkit.org/show_bug.cgi?id=134166
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::decodeFormDataElement):
(WebKit::decodeFormData):
(WebKit::decodeBackForwardTreeNode):
- 9:33 AM Changeset in webkit [170261] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] WKWebViewConfiguration.allowsInlineMediaPlayback has no effect
https://bugs.webkit.org/show_bug.cgi?id=134170
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]): Fixed a typo.
Jun 21, 2014:
- 10:52 PM Changeset in webkit [170260] by
-
- 2 edits in trunk/Tools
Disable gamepad feature on EFL and GTK ports by default
https://bugs.webkit.org/show_bug.cgi?id=134169
Reviewed by Brady Eidson.
EFL and GTK ports disabled Gamepad feature now. Besides current implementation
was treated to 'deprecated' status.
ENABLE_GAMEPAD_DEPRECATED is disabled for now. There is build break on EFL port.
- Scripts/webkitperl/FeatureList.pm:
- 10:50 PM Changeset in webkit [170259] by
-
- 2 edits in trunk/Source/WebCore
createCairoGLSurface should take in a FloatSize reference as its first parameter
https://bugs.webkit.org/show_bug.cgi?id=134159
Reviewed by Martin Robinson.
The ImageBuffer constructor operates with a FloatSize reference, which is also
passed to createCairoGLSurface when accelerated 2D canvas support is enabled.
That function should take in a reference to the same type.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::createCairoGLSurface):
- 10:46 PM Changeset in webkit [170258] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fixing the GTK+ build after r170253.
- UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): WebPreferences::create()
now takes an additional String argument.
- 4:55 PM Changeset in webkit [170257] by
-
- 46 edits3 adds in trunk
[Mac] Margins for new form controls need tweaking
https://bugs.webkit.org/show_bug.cgi?id=134135
<rdar://problem/17262164>
Reviewed by Sam Weinig.
Source/WebCore:
Take 2 of this patch. Only the mac-mountainlion LayoutTest
results are different from the first attempt.
With the newer animated controls in OS X Yosemite, we need
to tweak the fudge-factor margins for positioning. In a recent
patch I added another fudge, which I'm removing with this. I'm
not sure where the older values came from, but I've checked with
the latest AppKit sources and am using the sizes they implement
for the controls.
This will rebaseline a lot of tests, since I've made small tweaks
to the form layout.
- platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): New margin amounts.
(WebCore::radioSizes): New sizes.
(WebCore::radioMargins): New margin amounts.
(WebCore::paintToggleButton): No need to call the positioning fudge any more.
(WebCore::checkboxOffsets): Deleted.
(WebCore::radioOffsets): Deleted.
LayoutTests:
Take 2 of this patch adds some Mountain Lion results.
Rebaseline a bunch of results since some <input> dimensions
changed slightly.
- platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt:
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.png: Added.
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt:
- platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt:
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.png: Added.
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt:
- platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt:
- platform/mac-mountainlion/fast/forms/input-value-expected.txt:
- platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
- platform/mac-mountainlion/http/tests/navigation/javascriptlink-frame-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/css1/box_properties/acid_test-expected.png:
- platform/mac/css1/box_properties/acid_test-expected.txt:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/mac/fast/block/basic/011-expected.png:
- platform/mac/fast/block/basic/011-expected.txt:
- platform/mac/fast/block/margin-collapse/103-expected.png:
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/forms/basic-inputs-expected.png:
- platform/mac/fast/forms/basic-inputs-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/formmove-expected.txt:
- platform/mac/fast/forms/formmove2-expected.png:
- platform/mac/fast/forms/formmove2-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/inline/positionedLifetime-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.png:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/width100percent-radio-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
- 4:27 PM Changeset in webkit [170256] by
-
- 39 edits in trunk/Source
Remove static tables for bindings that use eager reification
https://bugs.webkit.org/show_bug.cgi?id=134126
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectCustomAccessor):
- runtime/Structure.h:
(JSC::Structure::setHasCustomGetterSetterProperties):
Change setHasCustomGetterSetterProperties to behave like setHasGetterSetterProperties, and set
the m_hasReadOnlyOrGetterSetterPropertiesExcludingProto bit if the property is not proto.
Without this, JSObject::put() won't think there are any setters on the prototype chain of an
object that has no static lookup table and uses eagerly reified custom getter/setter properties.
Source/WebCore:
This shaves about 1MB off of WebCore's .o files.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.h:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSattribute.h:
- bindings/scripts/test/JS/JSreadonly.cpp:
- bindings/scripts/test/JS/JSreadonly.h:
- 3:33 PM Changeset in webkit [170255] by
-
- 2 edits in trunk/Source/WebKit/mac
Tried to fix the iOS build after r170235.
- WebView/WebView.mm:
- 3:25 PM Changeset in webkit [170254] by
-
- 3 edits in trunk/Source/WebKit2
CallbackMap::put should be able to take an unwrapped function
https://bugs.webkit.org/show_bug.cgi?id=134104
Reviewed by Anders Carlsson.
- UIProcess/GenericCallback.h:
(WebKit::CallbackMap::put): Added an overload that takes a function and creates and puts a
callback. Changed both overloads of put() to return the callback ID.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateCommand):
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getBytecodeProfile):
(WebKit::WebPageProxy::getContentsAsMHTMLData):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):
(WebKit::WebPageProxy::getMarkedRangeAsync):
(WebKit::WebPageProxy::getSelectedRangeAsync):
(WebKit::WebPageProxy::characterIndexForPointAsync):
(WebKit::WebPageProxy::firstRectForCharacterRangeAsync):
(WebKit::WebPageProxy::takeSnapshot):
- 3:02 PM Changeset in webkit [170253] by
-
- 11 edits in trunk/Source/WebKit2
Make it possible to override debug preferences on a per-identifier basis as well as globally
https://bugs.webkit.org/show_bug.cgi?id=134164
Reviewed by Dan Bernstein.
- Shared/WebPreferencesDefinitions.h:
- Shared/WebPreferencesKeys.cpp:
- Shared/WebPreferencesKeys.h:
- Shared/WebPreferencesStore.cpp:
(WebKit::defaults):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::create):
(WebKit::WebPreferences::createWithLegacyDefaults):
(WebKit::WebPreferences::WebPreferences):
- UIProcess/WebPreferences.h:
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::debugUserDefaultsValue):
(WebKit::setDebugBoolValueIfInUserDefaults):
(WebKit::WebPreferences::platformInitializeStore):
- 2:01 PM Changeset in webkit [170252] by
-
- 2 edits in trunk/Source/WebKit2
Begin work on decoding form data
https://bugs.webkit.org/show_bug.cgi?id=134163
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::isValid):
(WebKit::isValidEnum):
(WebKit::decodeFormDataElement):
(WebKit::decodeFormData):
(WebKit::decodeBackForwardTreeNode):
- 1:05 PM Changeset in webkit [170251] by
-
- 2 edits in trunk/Source/WebKit2
Only initialize WebPreferences from NSUserDefaults if there's an identifier
https://bugs.webkit.org/show_bug.cgi?id=134162
Reviewed by Sam Weinig.
We don't want to allow changing preferences by registering user defaults.
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::WebPreferences::platformInitializeStore):
- 12:41 PM Changeset in webkit [170250] by
-
- 2 edits in trunk/Source/WebKit2
Begin work on decoding the back/forward tree
https://bugs.webkit.org/show_bug.cgi?id=134161
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntries):
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::decodeArithmeticType):
(WebKit::HistoryEntryDataDecoder::bufferIsLargeEnoughToContain):
(WebKit::decodeBackForwardTreeNode):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
(WebKit::HistoryEntryDataDecoder::decode): Deleted.
- 12:07 PM Changeset in webkit [170249] by
-
- 22 edits9 moves1 add in trunk
Gamepad API - Deprecate the existing implementation
https://bugs.webkit.org/show_bug.cgi?id=134108
Reviewed by Timothy Hatcher.
-Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
.:
-Add the "Deprecated" suffix to some implementation files
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
-Move some implementation files into a "deprecated" subdirectory.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
-Move some implementation files into a "deprecated" subdirectory.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- PlatformGTK.cmake:
- Modules/gamepad/deprecated/Gamepad.cpp: Renamed from Source/WebCore/Modules/gamepad/Gamepad.cpp.
- Modules/gamepad/deprecated/Gamepad.h: Renamed from Source/WebCore/Modules/gamepad/Gamepad.h.
- Modules/gamepad/deprecated/Gamepad.idl: Renamed from Source/WebCore/Modules/gamepad/Gamepad.idl.
- Modules/gamepad/deprecated/GamepadList.cpp: Renamed from Source/WebCore/Modules/gamepad/GamepadList.cpp.
- Modules/gamepad/deprecated/GamepadList.h: Renamed from Source/WebCore/Modules/gamepad/GamepadList.h.
- Modules/gamepad/deprecated/GamepadList.idl: Renamed from Source/WebCore/Modules/gamepad/GamepadList.idl.
- Modules/gamepad/deprecated/NavigatorGamepad.cpp: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp.
- Modules/gamepad/deprecated/NavigatorGamepad.h: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.h.
- Modules/gamepad/deprecated/NavigatorGamepad.idl: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.idl.
- platform/Gamepads.h:
- platform/efl/GamepadsEfl.cpp:
- platform/gtk/GamepadsGtk.cpp:
- platform/linux/GamepadDeviceLinux.cpp:
- platform/linux/GamepadDeviceLinux.h:
Source/WebKit/mac:
-Move some implementation files into a "deprecated" subdirectory.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
-Move some implementation files into a "deprecated" subdirectory.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
-Move some implementation files into a "deprecated" subdirectory.
- wtf/FeatureDefines.h:
- 11:52 AM Changeset in webkit [170248] by
-
- 2 edits in trunk/Source/WebKit2
Implement more of HistoryEntryDataDecoder
https://bugs.webkit.org/show_bug.cgi?id=134146
Reviewed by Sam Weinig.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::decode):
(WebKit::HistoryEntryDataDecoder::decodeFixedLengthData):
(WebKit::HistoryEntryDataDecoder::alignBufferPosition):
(WebKit::HistoryEntryDataDecoder::alignedBuffer):
(WebKit::HistoryEntryDataDecoder::alignedBufferIsLargeEnoughToContain):
(WebKit::HistoryEntryDataDecoder::markInvalid):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
- 11:27 AM Changeset in webkit [170247] by
-
- 2 edits in trunk/Source/WebCore
Mark TextRun's constructors as explicit
https://bugs.webkit.org/show_bug.cgi?id=134124
Reviewed by Sam Weinig.
After r170072, nobody is implicitly converting a string to a TextRun. Therefore,
we can make the constructors explicit.
No new tests because there is no behavior change.
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
- 9:24 AM Changeset in webkit [170246] by
-
- 25 edits6 moves in trunk
Unreviewed, rolling out r170244.
https://bugs.webkit.org/show_bug.cgi?id=134157
GTK/EFL bindings generator works differently, making this
patch not work there. Will fix entire patch after a rollout.
(Requested by bradee-oh on #webkit).
Reverted changeset:
"Gamepad API - Deprecate the existing implementation"
https://bugs.webkit.org/show_bug.cgi?id=134108
http://trac.webkit.org/changeset/170244
- 8:55 AM Changeset in webkit [170245] by
-
- 2 edits in trunk/Source/WebCore
Fix the mismatched header build guards in WebKitDOMNodeFilterPrivate.h
which are throwing compilation warnings when building with Clang.
- bindings/gobject/WebKitDOMNodeFilterPrivate.h:
- 8:43 AM Changeset in webkit [170244] by
-
- 25 edits6 moves in trunk
Gamepad API - Deprecate the existing implementation
https://bugs.webkit.org/show_bug.cgi?id=134108
Reviewed by Timothy Hatcher.
-Add new "GAMEPAD_DEPRECATED" build flag, moving the existing implementation to use it
-Add the "Deprecated" suffix to some implementation files
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- CMakeLists.txt:
- PlatformGTK.cmake:
- Configurations/FeatureDefines.xcconfig:
- Modules/gamepad/GamepadDeprecated.cpp: Renamed from Source/WebCore/Modules/gamepad/Gamepad.cpp.
- Modules/gamepad/GamepadDeprecated.h: Renamed from Source/WebCore/Modules/gamepad/Gamepad.h.
- Modules/gamepad/GamepadDeprecated.idl: Renamed from Source/WebCore/Modules/gamepad/Gamepad.idl.
- Modules/gamepad/GamepadList.cpp:
- Modules/gamepad/GamepadList.h:
- Modules/gamepad/GamepadList.idl:
- Modules/gamepad/NavigatorGamepadDeprecated.cpp: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp.
- Modules/gamepad/NavigatorGamepadDeprecated.h: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.h.
- Modules/gamepad/NavigatorGamepadDeprecated.idl: Renamed from Source/WebCore/Modules/gamepad/NavigatorGamepad.idl.
- platform/Gamepads.h:
- platform/efl/GamepadsEfl.cpp:
- platform/gtk/GamepadsGtk.cpp:
- platform/linux/GamepadDeviceLinux.cpp:
- platform/linux/GamepadDeviceLinux.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
- 8:06 AM Changeset in webkit [170243] by
-
- 6 edits in trunk/Source/WebKit2
[CoordinatedGraphics][WK2][EFL] Page is moved to (0,0) position before rendering content
https://bugs.webkit.org/show_bug.cgi?id=133300
Reviewed by Csaba Osztrogonác.
When new page is loaded, PageViewportController::didCommitLoad() calls PageViewportController::syncVisibleContents()
with initial position via applyPositionAfterRenderingContents() before starting to render
new page by PageViewportController::didRenderFrame(). This call flow causes that webview shows
incomplete tiles to the user during a few milliseconds. To fix showing incomplete tiles during
the page loading, this patch adds a flag so that we don't show the incomplete tiles until showing
new page.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/efl/EwkView.h:
(EwkView::setWaitingForNewPage):
(EwkView::waitingForNewPage):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
- 8:02 AM Changeset in webkit [170242] by
-
- 38 edits in trunk
Unreviewed, rolling out r170228.
https://bugs.webkit.org/show_bug.cgi?id=134155
Caused 9 layout test failures on Mountain Lion
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)/builds/19216
(Requested by bradee-oh on #webkit).
Reverted changeset:
"[Mac] Margins for new form controls need tweaking"
https://bugs.webkit.org/show_bug.cgi?id=134135
http://trac.webkit.org/changeset/170228
- 7:59 AM Changeset in webkit [170241] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Create and attach the AVPlayerLayer to the AVPlayer immediately if the media element is <video>.
https://bugs.webkit.org/show_bug.cgi?id=134131
Reviewed by Eric Carlson.
The AVPlayer uses the presence of an AVPlayerLayer to decide which alternate to display in the case of
HLS streams with audio-only alternates. To give the AVPlayer the most information with which to make its
decision, always create and attach an AVPlayerLayer before attaching an AVPlayerItem to the AVPlayerLayer.
In addition, retrieve the <video> element bounds and create an AVPlayerLayer with a matching size, so that
the AVPlayer can choose an alternate with the correct dimensions.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasLayerRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer):
- 7:55 AM Changeset in webkit [170240] by
-
- 25 edits in trunk/Source/WebInspectorUI
Web Inspector: UI fonts should pull from system fonts automatically to whatever degree possible
https://bugs.webkit.org/show_bug.cgi?id=133966
Reviewed by Timothy Hatcher.
Updated font families to use -webkit-system-font, and set this on the body to be
inherited. Also made sure that popovers use Menlo as the default. Updated
autocompletions with system font names.
- UserInterface/Models/CSSKeywordCompletions.js: Updated completions with available system fonts.
- UserInterface/Controllers/CodeMirrorGradientEditingController.css:
- UserInterface/Views/Breakpoint.css:
- UserInterface/Views/ButtonNavigationItem.css:
- UserInterface/Views/ButtonToolbarItem.css:
- UserInterface/Views/CSSStyleDeclarationSection.css:
- UserInterface/Views/CSSStyleDeclarationTextEditor.css:
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
- UserInterface/Views/CodeMirrorOverrides.css:
- UserInterface/Views/DataGrid.css:
- UserInterface/Views/DebuggerDashboardView.css:
- UserInterface/Views/DetailsSection.css:
- UserInterface/Views/FindBanner.css:
- UserInterface/Views/GoToLineDialog.css:
- UserInterface/Views/HierarchicalPathComponent.css:
- UserInterface/Views/Main.css:
- UserInterface/Views/NavigationSidebarPanel.css:
- UserInterface/Views/ProbeSetDataGrid.css:
- UserInterface/Views/RulesStyleDetailsPanel.css:
- UserInterface/Views/ScopeBar.css:
- UserInterface/Views/SourceCodeTextEditor.css:
- UserInterface/Views/TimelineDataGrid.css:
- UserInterface/Views/TimelineRuler.css:
- UserInterface/Views/TimelineSidebarPanel.css:
Changes to fonts. Set default font stack to -webkit-system-font, sans-serif. Default size is
11px. Only changes to this default size or changes to the font (to Menlo, monospace usually) remain.
- 7:52 AM Changeset in webkit [170239] by
-
- 2 edits in trunk/Source/WebCore
Implement ios -[WAKWindow convertBaseToScreen:]
https://bugs.webkit.org/show_bug.cgi?id=134053
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-21
Reviewed by Eric Carlson.
- platform/ios/wak/WAKWindow.mm:
(-[WAKWindow convertBaseToScreen:]):
Traverse layer hierarchy and convert point.
(-[WAKWindow convertScreenToBase:]):
Traverse layer hierarchy and convert point.
- 7:51 AM Changeset in webkit [170238] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Esc in quick console no longer toggles console drawer
https://bugs.webkit.org/show_bug.cgi?id=134068
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-21
Reviewed by Timothy Hatcher.
For Escape to toggle console behavior we were relying on the Escape
keyboard event to propagate up to the window and be handled by
QuickConsole's global keyboard shortcut. With CodeMirror 4, all
editors have a default "Esc" key handler to reduce multiple selections
to a single selection. Unfortunately this always prevents default,
which our keyboard shortcut respects and doesn't toggle the console.
Workaround this by putting a specific handler for when a Console
Prompt is empty and the Escape key is triggered. This does not go
through the normal ConsolePrompt delegate because the delegate
is never the QuickConsole, it is actually the JavaScript log.
- UserInterface/Views/ConsolePrompt.js:
(WebInspector.ConsolePrompt):
(WebInspector.ConsolePrompt.prototype.set escapeKeyHandlerWhenEmpty):
(WebInspector.ConsolePrompt.prototype._handleEscapeKey):
- UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.this.prompt.escapeKeyHandlerWhenEmpty):
(WebInspector.QuickConsole):
- 7:43 AM Changeset in webkit [170237] by
-
- 2 edits in trunk/Source/WebKit2
Commit queue has been failing due to a build failure in WKFoundation.h
https://bugs.webkit.org/show_bug.cgi?id=134152
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2014-06-21
Reviewed by Csaba Osztrogonác.
Landed by Brady Eidson.
The build failure was caused by WKFoundation.h erroneously redefining
NSURLSessionAuthChallengeDisposition even when building with 10.9 SDK.
The availability of this type depends on the version of SDK,
not the target operating system.
- Shared/API/Cocoa/WKFoundation.h:
- 1:53 AM Changeset in webkit [170236] by
-
- 2 edits1 add in trunk/Tools
[Inspector][EFL] Can't resume a special break point on EFL inspector
https://bugs.webkit.org/show_bug.cgi?id=129294
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Gyuyoung Kim.
Patch our EFL 1.9 with the fix landed in upstream EFL 1.10
by Ryuan Choi - <https://phab.enlightenment.org/D790>
- efl/jhbuild.modules:
- efl/patches/ecore.patch: Added.
- 1:49 AM Changeset in webkit [170235] by
-
- 39 edits in trunk
Removing PAGE_VISIBILITY_API compile guard.
https://bugs.webkit.org/show_bug.cgi?id=133844
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Gavin Barraclough.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests because no functional changes.
- Configurations/FeatureDefines.xcconfig:
- Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
- dom/Document.cpp:
(WebCore::Document::hidden):
- dom/Document.h:
- dom/Document.idl:
- dom/Element.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- page/Page.cpp:
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::visibilityState):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
- page/Page.h:
- page/PageVisibilityState.cpp:
- page/PageVisibilityState.h:
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled):
- page/Settings.h:
- platform/audio/MediaSession.cpp:
(WebCore::MediaSession::updateClientDataBuffering):
- platform/audio/MediaSession.h:
Source/WebKit/efl:
- ewk/ewk_view.cpp:
(ewk_view_visibility_state_set):
(ewk_view_visibility_state_get):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
(-[WebView _visibilityState]):
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
- 1:46 AM Changeset in webkit [170234] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARM traditional buildfix after r169942.
https://bugs.webkit.org/show_bug.cgi?id=134100
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-21
Reviewed by Zoltan Herczeg.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::abortWithReason): Added.
- 1:07 AM Changeset in webkit [170233] by
-
- 2 edits in trunk/Source/WebCore
[GTK][EFL] Use OpenType MATH fonts by default.
https://bugs.webkit.org/show_bug.cgi?id=133604
Reviewed by Chris Fleizach.
In order to support stretching of horizontal operators and large
operators in display mode as well as to improve the drawing of radicals,
we need to use an OpenType MATH table. This commit makes the MathML code
try "Latin Modern Math" first, which is an OpenType version of Knuth's
popular Computer Modern font and is packaged with most TeX
distributions (e.g. TeX Live on Linux). This should work well on the
EFL & GTK ports for which the initial OpenType MATH support has been
tested. Other ports will be handled later.
No new tests. This is already tested in LayoutTests/mathml/opentype/.
- css/mathml.css:
(math): Add "Latin Modern Math" as the first font-family of the <math> element.
Jun 20, 2014:
- 11:04 PM Changeset in webkit [170232] by
-
- 6 edits23 moves1 add11 deletes in trunk/LayoutTests
Remove latinmodern-math.woff from LayoutTests/mathml/opentype
https://bugs.webkit.org/show_bug.cgi?id=134094
Reviewed by Martin Robinson.
We remove latinmodern-math.woff from the source and make mathml/opentype/*LatinModern* tests not font-specific, so that each platform will use whatever OpenType MATH is available.
Until bug 133604 is fixed and Latin Modern Math installed on the Linux bots, the tests are marked as failed. More generally, we need to fix bug 133603.
The test mathml/opentype/roots-LatinModern is removed since it will duplicate mathml/presentation/roots.xhtml when OpenType MATH fonts are available.
- mathml/opentype/LICENSE-LatinModern.txt: Removed.
- mathml/opentype/horizontal-munderover.html: Renamed from LayoutTests/mathml/opentype/horizontal-LatinModern-munderover.html.
- mathml/opentype/horizontal.html: Renamed from LayoutTests/mathml/opentype/horizontal-LatinModern.html.
- mathml/opentype/large-operators-LatinModern.html: Removed.
- mathml/opentype/large-operators.html: Added.
- mathml/opentype/latinmodern-math.woff: Removed.
- mathml/opentype/opentype-stretchy-horizontal.html:
- mathml/opentype/roots-LatinModern.html: Removed.
- mathml/opentype/vertical.html: Renamed from LayoutTests/mathml/opentype/vertical-LatinModern.html.
- platform/efl/TestExpectations:
- platform/efl/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/horizontal-LatinModern-expected.txt.
- platform/efl/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
- platform/efl/mathml/opentype/large-operators-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/large-operators-LatinModern-expected.png.
- platform/efl/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/large-operators-LatinModern-expected.txt.
- platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Removed.
- platform/efl/mathml/opentype/vertical-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/vertical-LatinModern-expected.png.
- platform/efl/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/efl/mathml/opentype/vertical-LatinModern-expected.txt.
- platform/gtk/TestExpectations:
- platform/gtk/mathml/opentype/horizontal-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-expected.png.
- platform/gtk/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-expected.txt.
- platform/gtk/mathml/opentype/horizontal-munderover-expected.png: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-munderover-expected.png.
- platform/gtk/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
- platform/gtk/mathml/opentype/large-operators-expected.png: Renamed from LayoutTests/platform/efl/mathml/opentype/large-operators-LatinModern-expected.png.
- platform/gtk/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/large-operators-LatinModern-expected.txt.
- platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Removed.
- platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Removed.
- platform/gtk/mathml/opentype/vertical-expected.png: Renamed from LayoutTests/platform/efl/mathml/opentype/vertical-LatinModern-expected.png.
- platform/gtk/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/opentype/vertical-LatinModern-expected.txt.
- platform/mac-wk2/mathml/opentype/large-operators-LatinModern-expected.txt: Removed.
- platform/mac-wk2/mathml/opentype/vertical-LatinModern-expected.txt: Removed.
- platform/mac/TestExpectations:
- platform/mac/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/horizontal-LatinModern-expected.txt.
- platform/mac/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
- platform/mac/mathml/opentype/large-operators-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/large-operators-LatinModern-expected.txt.
- platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Removed.
- platform/mac/mathml/opentype/vertical-expected.txt: Renamed from LayoutTests/platform/mac/mathml/opentype/vertical-LatinModern-expected.txt.
- platform/win/TestExpectations:
- platform/win/mathml/opentype/horizontal-expected.txt: Renamed from LayoutTests/platform/win/mathml/opentype/horizontal-LatinModern-expected.txt.
- platform/win/mathml/opentype/horizontal-munderover-expected.txt: Renamed from LayoutTests/platform/win/mathml/opentype/horizontal-LatinModern-munderover-expected.txt.
- platform/win/mathml/opentype/roots-LatinModern-expected.txt: Removed.
- 11:00 PM Changeset in webkit [170231] by
-
- 1 edit1 delete in trunk/LayoutTests
[EFL] Remove WebKit1 test results
https://bugs.webkit.org/show_bug.cgi?id=134137
Reviewed by Daniel Bates.
- platform/efl-wk1: Removed entire directory which contains the WebKit1 EFL test results.
- 10:53 PM Changeset in webkit [170230] by
-
- 3 edits2 copies3 deletes in trunk/Tools
[EFL] Remove DumpRenderTree/efl and EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=134138
Reviewed by Gyuyoung Kim.
DumpRenderTree/efl and EWebLauncher are not necessary anymore because WebKit1 EFL will be removed.
- CMakeLists.txt:
- DumpRenderTree/PlatformEfl.cmake: Removed.
- DumpRenderTree/efl: Removed entire directory.
- EWebLauncher: Ditto.
- WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Renamed from Tools/DumpRenderTree/efl/FontManagement.cpp.
(buildPath):
(getCoreFontFiles):
(addFontDirectory):
(addFontFiles):
(getCustomBuildDir):
(getPlatformFontsPath):
(addFontsToEnvironment):
- WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Renamed from Tools/DumpRenderTree/efl/FontManagement.h.
- WebKitTestRunner/PlatformEfl.cmake:
- 10:09 PM Changeset in webkit [170229] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed EFL build fix since r170224.
Add retainPlatformLayer() and releasePlatformLayer() in ScrollingStateNodeCoordinatedGraphics.cpp
as well. Thouse functions were missed in r170224.
- page/scrolling/ScrollingStateNode.h:
- page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp:
(WebCore::LayerRepresentation::retainPlatformLayer):
(WebCore::LayerRepresentation::releasePlatformLayer):
- 8:10 PM Changeset in webkit [170228] by
-
- 38 edits in trunk
[Mac] Margins for new form controls need tweaking
https://bugs.webkit.org/show_bug.cgi?id=134135
<rdar://problem/17262164>
Reviewed by Sam Weinig.
Source/WebCore:
With the newer animated controls in OS X Yosemite, we need
to tweak the fudge-factor margins for positioning. In a recent
patch I added another fudge, which I'm removing with this. I'm
not sure where the older values came from, but I've checked with
the latest AppKit sources and am using the sizes they implement
for the controls.
This will rebaseline a lot of tests, since I've made small tweaks
to the form layout.
- platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): New margin amounts.
(WebCore::radioSizes): New sizes.
(WebCore::radioMargins): New margin amounts.
(WebCore::paintToggleButton): No need to call the positioning fudge any more.
(WebCore::checkboxOffsets): Deleted.
(WebCore::radioOffsets): Deleted.
LayoutTests:
Rebaseline a bunch of results since some <input> dimensions
changed slightly.
- platform/mac/css1/box_properties/acid_test-expected.png:
- platform/mac/css1/box_properties/acid_test-expected.txt:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/mac/fast/block/basic/011-expected.png:
- platform/mac/fast/block/basic/011-expected.txt:
- platform/mac/fast/block/margin-collapse/103-expected.png:
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/forms/basic-inputs-expected.png:
- platform/mac/fast/forms/basic-inputs-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/formmove-expected.txt:
- platform/mac/fast/forms/formmove2-expected.png:
- platform/mac/fast/forms/formmove2-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/inline/positionedLifetime-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.png:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/width100percent-radio-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
- 7:33 PM Changeset in webkit [170227] by
-
- 2 edits in trunk/Source/WebCore
Fix css jit on armv7.
https://bugs.webkit.org/show_bug.cgi?id=134143
<rdar://problem/17348060>
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-20
Reviewed by Benjamin Poulain.
This fixes the acid3 test.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
Correct high and low bits.
- 5:11 PM Changeset in webkit [170226] by
-
- 4 edits in trunk/Source/WebKit2
Implement more of LegacySessionStateDecoder
https://bugs.webkit.org/show_bug.cgi?id=134145
Reviewed by Sam Weinig.
- Shared/SessionState.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntry):
(WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
(WebKit::HistoryEntryDataDecoder::finishDecoding):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
- UIProcess/mac/LegacySessionStateCoding.h:
- 4:48 PM Changeset in webkit [170225] by
-
- 5 edits in trunk/Source/WebKit2
Implement more of LegacySessionStateDecoder
https://bugs.webkit.org/show_bug.cgi?id=134144
Reviewed by Sam Weinig.
- Shared/SessionState.cpp:
(WebKit::BackForwardListState::encode):
(WebKit::SessionState::encode): Deleted.
- Shared/SessionState.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::decodeSessionState):
(WebKit::LegacySessionStateDecoder::decodeSessionHistory):
(WebKit::LegacySessionStateDecoder::decodeV0SessionHistory):
(WebKit::LegacySessionStateDecoder::decodeV1SessionHistory):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntries):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntry):
- UIProcess/mac/LegacySessionStateCoding.h:
- 4:44 PM Changeset in webkit [170224] by
-
- 5 edits1 move1 add in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=134117
Unreproducible crashes under WebCore::ScrollingTree::updateTreeFromStateNode()
from messaging a deleted Obj-C object
-and corresponding-
<rdar://problem/17149252>
Reviewed by Simon Fraser.
This is a speculative fix. It makes LayerRepresentation retain m_platformLayer.
- WebCore.exp.in:
- page/scrolling/ScrollingStateNode.h:
(WebCore::LayerRepresentation::LayerRepresentation):
(WebCore::LayerRepresentation::~LayerRepresentation):
(WebCore::LayerRepresentation::operator=):
(WebCore::LayerRepresentation::operator==):
(WebCore::LayerRepresentation::operator ==): Deleted.
Make this ASSERT an ASSERT_WITH_SECURITY_IMPLICATION
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
Moved ScrollingStateNodeMac.mm, which was empty anyway, to cocoa/
ScrollingStateNode.mm so that iOS can use it too.
- page/scrolling/cocoa: Added.
- page/scrolling/cocoa/ScrollingStateNode.mm: Copied from page/scrolling/mac/ScrollingStateNodeMac.mm.
Actual implementation for retain and release.
(WebCore::LayerRepresentation::retainPlatformLayer):
(WebCore::LayerRepresentation::releasePlatformLayer):
Deleted.
- page/scrolling/mac/ScrollingStateNodeMac.mm: Removed.
- 4:40 PM Changeset in webkit [170223] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. build fix for the cmake based ports since r170188
- CMakeLists.txt: Added LegacySessionState.cpp in source list.
- 4:37 PM Changeset in webkit [170222] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] No way to get the main frame’s main resource’s data
https://bugs.webkit.org/show_bug.cgi?id=134113
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _getMainResourceDataWithCompletionHandler:]): Added. Calls
WebPageProxy::getMainResourceDataOfFrame and invokes the completion handler form the
callback.
- UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared new method.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getMainResourceDataOfFrame): Made it safe to pass a NULL frame into
this function.
- 4:21 PM Changeset in webkit [170221] by
-
- 2 edits in trunk/Tools
Name moving. Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 3:57 PM Changeset in webkit [170220] by
-
- 6 edits in trunk/Source/WebCore
Introduce RenderLayer::offsetFromAncestorLayer() to make convertToLayerCoords() calls with
LayoutPoint(0, 0) as parameter more explicit.
https://bugs.webkit.org/show_bug.cgi?id=134092
Reviewed by Simon Fraser.
Most of the RenderLayer::convertToLayerCoords() callers are only interested in
the offset from the ancestor layer by passing LayoutPoint(0, 0) as the coordinate to convert.
Introducing offsetFromAncestorLayer() makes those calls more explicit/self-explanatory.
It helps simplifying the callsite's code.
No change in functionality.
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):
(WebCore::RenderGeometryMap::push):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeOffsetFromRoot):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForRegionAndReflection):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::offsetFromAncestorLayer):
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGeometry):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):
- 3:46 PM Changeset in webkit [170219] by
-
- 7 edits6 copies in trunk/Source/WebKit2
Introduce a WKSessionStateRef object
https://bugs.webkit.org/show_bug.cgi?id=134136
Reviewed by Tim Horton.
WKSessionStateRef is going to hold session state, making it possible to migrate state from one
webpage to another without having to do any serialization/deserialization.
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- Shared/SessionState.cpp:
(WebKit::SessionState::encode):
- Shared/SessionState.h:
- UIProcess/API/APISessionState.cpp: Added.
(API::SessionState::create):
(API::SessionState::SessionState):
(API::SessionState::~SessionState):
- UIProcess/API/APISessionState.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateCreateFromData):
- UIProcess/API/C/WKSessionStateRef.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::LegacySessionStateDecoder::LegacySessionStateDecoder):
(WebKit::LegacySessionStateDecoder::~LegacySessionStateDecoder):
(WebKit::LegacySessionStateDecoder::decodeSessionState):
- UIProcess/mac/LegacySessionStateCoding.h:
- WebKit2.xcodeproj/project.pbxproj:
- 3:42 PM Changeset in webkit [170218] by
-
- 4 edits in trunk/Source/WebKit2
iOS WebKit2: selection handles become too large when zooming a page.
https://bugs.webkit.org/show_bug.cgi?id=134084
<rdar://problem/16799164>
Reviewed by Benjamin Poulain.
Since the document view is zoomed, we add a subview that has the inverse transform
of the document view. This new view becomes the root for the selection hierarchy.
The new view has zero size, not to interfere with the existing gestures on the WKContenView
therefore we implement hitTest to detect interaction with the selection elements.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView unscaledView]):
(-[WKContentView inverseScale]):
(-[WKContentView _updateUnscaledView]):
(-[WKContentView hitTest:withEvent:::]):
(-[WKContentView selectedTextRange]):
- 3:40 PM Changeset in webkit [170217] by
-
- 2 edits in trunk/Source/WebKit2
Snapshotting WKThumbnailViews should not tell Web processes backing unparented WKViews that they're in window
https://bugs.webkit.org/show_bug.cgi?id=134134
<rdar://problem/17402119>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setThumbnailView:]):
Re-evaluating our in-window state is only useful if we're going to use the live layer tree;
snapshots can be taken of unparented views with no trouble. Plus, doing so sets off a chain of
expensive things in the Web process which we can avoid if using snapshots.
- 3:38 PM Changeset in webkit [170216] by
-
- 3 edits in trunk/Source/WebKit2
WKThumbnailView should only use live layer trees before the snapshot arrives for parented WKViews
https://bugs.webkit.org/show_bug.cgi?id=134129
<rdar://problem/17401591>
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView initWithFrame:fromWKView:]):
Add a white background to WKThumbnailView, so that if we have no snapshot and no layer tree,
the view isn't transparent.
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateThumbnailViewLayer]):
We currently pull the live layer tree into the WKThumbnailView even in snapshot mode,
before the snapshot arrives, to avoid flashing when transitioning a live WKView to a thumbnail view.
This is, however, not useful for unparented WKViews, because their layer tree will be detached
and we'll flash anyway. So, only do that when the WKView is parented.
- 3:27 PM Changeset in webkit [170215] by
-
- 5 edits in branches/ftlopt/Source/JavaScriptCore
Merge r169903 to the branch.
2014-06-12 Mark Hahnenberg <mhahnenberg@apple.com>
Move structureHasRareData out of TypeInfo
https://bugs.webkit.org/show_bug.cgi?id=133800
Reviewed by Andreas Kling.
StructureHasRareData was originally put in TypeInfo to avoid making Structure bigger,
but we have a few spare bits in Structure so it would be nice to remove this hack.
- runtime/JSTypeInfo.h: (JSC::TypeInfo::newImpurePropertyFiresWatchpoints): (JSC::TypeInfo::structureHasRareData): Deleted.
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::allocateRareData): (JSC::Structure::cloneRareDataFrom):
- runtime/Structure.h: (JSC::Structure::previousID): (JSC::Structure::objectToStringValue): (JSC::Structure::setObjectToStringValue): (JSC::Structure::setPreviousID): (JSC::Structure::clearPreviousID): (JSC::Structure::previous): (JSC::Structure::rareData):
- runtime/StructureInlines.h: (JSC::Structure::setEnumerationCache): (JSC::Structure::enumerationCache):
- 3:10 PM Changeset in webkit [170214] by
-
- 3 edits in trunk/Source/WebKit2
WebKit delegate methods should document their default behaviors
https://bugs.webkit.org/show_bug.cgi?id=134132
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- 3:06 PM Changeset in webkit [170213] by
-
- 2 edits in trunk/Source/WebKit2
Fix lots of WK2 test crashes.
We don't always have a ScrollingCoordinator.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 3:05 PM Changeset in webkit [170212] by
-
- 2 edits in trunk/Source/WebKit2
Always use XPC on iOS
https://bugs.webkit.org/show_bug.cgi?id=134130
Reviewed by Sam Weinig.
- UIProcess/ios/WebProcessProxyIOS.mm:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
(WebKit::shouldUseXPC): Deleted.
- 3:00 PM Changeset in webkit [170211] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- Shared/SessionState.cpp:
- 2:55 PM Changeset in webkit [170210] by
-
- 3 edits in trunk/Source/WebKit2
Add ArgumentEncoder support to PageState and friends
https://bugs.webkit.org/show_bug.cgi?id=134128
Reviewed by Andreas Kling.
Change the classes to structs, get rid of the constructors/destructors
and add encode member functions.
- Shared/SessionState.cpp:
(WebKit::HTTPBody::Element::encode):
(WebKit::HTTPBody::encode):
(WebKit::FrameState::encode):
(WebKit::PageState::encode):
(WebKit::HTTPBody::Element::Element): Deleted.
(WebKit::HTTPBody::Element::~Element): Deleted.
(WebKit::FrameState::FrameState): Deleted.
(WebKit::FrameState::~FrameState): Deleted.
(WebKit::PageState::PageState): Deleted.
(WebKit::PageState::~PageState): Deleted.
- Shared/SessionState.h:
(WebKit::HTTPBody::Element::type): Deleted.
- 2:36 PM Changeset in webkit [170209] by
-
- 4 edits in trunk/Source
Add encoding and decoding support for WTF::Optional
https://bugs.webkit.org/show_bug.cgi?id=134125
Reviewed by Andreas Kling.
Source/WebKit2:
- Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<WTF::Optional<T>>::encode):
(IPC::ArgumentCoder<WTF::Optional<T>>::decode):
Source/WTF:
- wtf/Optional.h:
(WTF::Optional::operator=):
- 2:21 PM Changeset in webkit [170208] by
-
- 4 edits30 deletes in trunk/Source/WebCore
Removing dead code in platform/graphics/gpu
https://bugs.webkit.org/show_bug.cgi?id=134065
Reviewed by Simon Fraser.
No new tests because there is no behavior change.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/gpu/LoopBlinnClassifier.cpp: Removed.
- platform/graphics/gpu/LoopBlinnClassifier.h: Removed.
- platform/graphics/gpu/LoopBlinnConstants.h: Removed.
- platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp: Removed.
- platform/graphics/gpu/LoopBlinnLocalTriangulator.h: Removed.
- platform/graphics/gpu/LoopBlinnMathUtils.cpp: Removed.
- platform/graphics/gpu/LoopBlinnMathUtils.h: Removed.
- platform/graphics/gpu/LoopBlinnPathCache.cpp: Removed.
- platform/graphics/gpu/LoopBlinnPathCache.h: Removed.
- platform/graphics/gpu/LoopBlinnPathProcessor.h: Removed.
- platform/graphics/gpu/LoopBlinnShader.cpp: Removed.
- platform/graphics/gpu/LoopBlinnShader.h: Removed.
- platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Removed.
- platform/graphics/gpu/LoopBlinnSolidFillShader.h: Removed.
- platform/graphics/gpu/LoopBlinnTextureCoords.cpp: Removed.
- platform/graphics/gpu/LoopBlinnTextureCoords.h: Removed.
- platform/graphics/gpu/Shader.cpp: Removed.
- platform/graphics/gpu/Shader.h: Removed.
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: Removed.
- platform/graphics/gpu/SharedGraphicsContext3D.h: Removed.
- platform/graphics/gpu/mac/DrawingBufferMac.mm: Removed.
- platform/graphics/gpu/opencl/FilterContextOpenCL.cpp: Removed.
- platform/graphics/gpu/opencl/FilterContextOpenCL.h: Removed.
- platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFEFlood.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFEImage.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFEMerge.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFESourceAlpha.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFESourceGraphic.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLFETurbulence.cpp: Removed.
- platform/graphics/gpu/opencl/OpenCLHandle.h: Removed.
- 2:17 PM Changeset in webkit [170207] by
-
- 3 edits3 adds in trunk
[iOS] Support Khmer and Lao fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=134114
Reviewed by Enrica Casucci.
Source/WebCore:
iOS has fonts which have glyphs for the Khmer and Lao languages.
This patch also does a little refactoring of the language-specific fallback
font path to increase readability.
Test: fast/text/khmer-lao-font.html
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
(WebCore::FontCache::systemFallbackForCharacters):
LayoutTests:
Simply dump the render tree of a page that includes Khmer and Lao text. The success
of this test depends on font font metrics being different than system fallback font
(which just shows rectangles instead of glyphs).
- fast/text/khmer-lao-font.html: Added.
- platform/ios-sim/fast/text/khmer-lao-font-expected.txt: Added.
- platform/mac/fast/text/khmer-lao-font-expected.txt: Added.
- 2:08 PM Changeset in webkit [170206] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself to committers.
- Scripts/webkitpy/common/config/contributors.json:
- 2:03 PM Changeset in webkit [170205] by
-
- 4 edits in trunk/Source
Give NPAPI post requests a default content type
https://bugs.webkit.org/show_bug.cgi?id=134120
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):
- 2:00 PM Changeset in webkit [170204] by
-
- 2 edits in trunk/Source/WebKit2
Always commit the scrolling tree when we flush layers
https://bugs.webkit.org/show_bug.cgi?id=134115
Reviewed by Beth Dakin.
The scrolling state tree contains bare pointers to GraphicsLayers, which get
converted to CALayers at commit time. To avoid a window of time where those
GraphicsLayer pointers go stale, commit the scrolling tree whenever we flush the
compositing layer tree.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 1:56 PM Changeset in webkit [170203] by
-
- 4 edits2 adds in trunk
REGRESSION (r169972): fix issue when removing masks from compositing layers
https://bugs.webkit.org/show_bug.cgi?id=134118
<rdar://problem/17366654>
Reviewed by Dean Jackson.
Source/WebCore:
After r169972 when removing the mask, we could destroy the mask
layer before the call into m_graphicsLayer->setMaskLayer(), which would
try to call functions on the old mask. Fix by clearing the mask layer
on the GraphicsLayer before the mask layer gets destroyed.
Test: compositing/masks/toggle-mask.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateMaskLayer):
- rendering/RenderLayerBacking.h:
LayoutTests:
Test that toggles the mask on a composited element.
- compositing/masks/toggle-mask-expected.txt: Added.
- compositing/masks/toggle-mask.html: Added.
- 1:54 PM Changeset in webkit [170202] by
-
- 2 edits in trunk/Source/WTF
Add copy/move constructors and assignment operators to WTF::Optional
https://bugs.webkit.org/show_bug.cgi?id=134119
Reviewed by Andreas Kling.
- wtf/Optional.h:
(WTF::Optional::Optional):
(WTF::Optional::operator=):
- 1:48 PM Changeset in webkit [170201] by
-
- 4 edits in trunk/Source
[Cocoa] Release freed up blocks from the JS heap after simulated memory pressure.
<https://webkit.org/b/134112>
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- heap/BlockAllocator.h:
Source/WebCore:
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
- 1:36 PM Changeset in webkit [170200] by
-
- 3 edits in trunk/Source/WebCore
Remove redundant RenderLayer::computeOffsetFromRoot() function.
https://bugs.webkit.org/show_bug.cgi?id=134088
Reviewed by Benjamin Poulain.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::computeOffsetFromRoot): Deleted.
- rendering/RenderLayer.h:
- 1:22 PM Changeset in webkit [170199] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself to committers.
- Scripts/webkitpy/common/config/contributors.json:
- 12:16 PM Changeset in webkit [170198] by
-
- 11 edits6 adds in trunk
[iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord previews)
https://bugs.webkit.org/show_bug.cgi?id=134085
Source/WebCore:
<rdar://problem/16440586>
Reviewed by Tim Horton.
When nodes were detached from the scrolling tree, we would previously throw away
all descendant nodes, expecting that they would be re-attached as we walk the compositing
layer tree in RenderLayerCompositor.
However, this doesn't work across frame boundaries; the subframe may never update
its compositing layers again, so would lose all its scrolling nodes.
Fix by having ScrollingStateTree::detachNode() by default set aside subframe nodes
into a hash map. On reattach, we'll look in the hash map and pull out an existing node
(with its children intact) if possible.
Tests: platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html
platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html
platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame.html
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::detachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNodeAndAllDescendants):
(WebCore::ScrollingStateTree::recursiveNodeWillBeRemoved):
- page/scrolling/ScrollingStateTree.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState): Go back to removing the deleted
nodes from m_nodeMap first.
(WebCore::ScrollingTree::removeDestroyedNodes): There is no need for this to
actually make use of ScrollingTreeNode* any more; the ASSERT(!node->parent())
is bogus because it can fire when whole subtrees are removed, and to clear the
latched node we just need the ID.
Source/WebKit2:
<rdar://problem/16440586>
Reviewed by Tim Horton.
Add some debug-only assertions that check that the number of nodes we encoded is
the expected number.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::encode):
LayoutTests:
Reviewed by Tim Horton.
Tests that add and remove a fixed container of a scroll-coordinated iframe.
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/resources/doc-with-sticky.html:
- 12:14 PM Changeset in webkit [170197] by
-
- 9 edits in trunk/Source
Handle scrolling tree modifications which remove intermediate nodes
https://bugs.webkit.org/show_bug.cgi?id=134082
Reviewed by Tim Horton.
When updating the scrolling tree from the state tree, we failed to maintain
the children arrays correctly. Fix by removing all children on scrolling nodes,
and allowing the calls on children to add them back. A temporary hash map
keeps the nodes alive.
The state tree's m_nodesRemovedSinceLastCommit was also made into a HashSet,
to make it easier to handle removal followed by re-insertion.
Source/WebCore:
- WebCore.exp.in:
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode): If a node is (possibly re-)added,
remove it from m_nodesRemovedSinceLastCommit.remove.
(WebCore::ScrollingStateTree::willRemoveNode):
(WebCore::ScrollingStateTree::setRemovedNodes):
- page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::removedNodes):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::updateTreeFromStateNode): Clean up to have only one call
to updateBeforeChildren(), and remove all children from the scrolling node
before visiting state children.
(WebCore::ScrollingTree::removeDestroyedNodes): It was very wrong to assume
that all non-root nodes were parented in the root! Now we don't need to
remove from the parent anyway.
- page/scrolling/ScrollingTree.h:
- page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::children):
Source/WebKit2:
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::RemoteScrollingTreeTextStream::dump):
- 12:14 PM Changeset in webkit [170196] by
-
- 29 edits in trunk/Source
Make ScrollingTreeNodes refounted, for easier tree reconfiguration
https://bugs.webkit.org/show_bug.cgi?id=134075
Reviewed by Tim Horton.
Make ScrollingTreeNode be ref-counted.
Source/WebCore:
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::updateTreeFromStateNode):
- page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::rootNode):
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::appendChild):
- page/scrolling/ScrollingTreeNode.h:
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::createNode):
- page/scrolling/ThreadedScrollingTree.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.mm:
(WebCore::ScrollingCoordinatorIOS::createScrollingTreeNode):
- page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
- page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:
(WebCore::ScrollingTreeFrameScrollingNodeIOS::create):
- page/scrolling/ios/ScrollingTreeIOS.cpp:
(WebCore::ScrollingTreeIOS::createNode):
- page/scrolling/ios/ScrollingTreeIOS.h:
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::createScrollingTreeNode):
- page/scrolling/mac/ScrollingTreeFixedNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::create):
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::create):
- page/scrolling/mac/ScrollingTreeStickyNode.h:
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::create):
Source/WebKit2:
- UIProcess/Scrolling/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::createNode):
- UIProcess/Scrolling/RemoteScrollingTree.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::create):
- WebProcess/Scrolling/RemoteScrollingCoordinator.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::createScrollingTreeNode):
- 12:05 PM Changeset in webkit [170195] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] No way to get the MIME type of the main frame
https://bugs.webkit.org/show_bug.cgi?id=134111
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _MIMEType]): Added. Returns the MIME type of the main frame, or nil.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 11:32 AM Changeset in webkit [170194] by
-
- 8 edits in trunk/Tools
Make WebKit2 more accessible in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=134099
Reviewed by Anders Carlsson.
- MiniBrowser/mac/AppDelegate.h:
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate applicationDidFinishLaunching:]):
(-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
(-[BrowserAppDelegate _useWebKit2ByDefault]):
(-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
(-[BrowserAppDelegate validateMenuItem:]):
- MiniBrowser/mac/MainMenu.xib:
Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
Make the non-default new-window menu item always show up, because people often don't find it
when you have to press option to have it show up.
- MiniBrowser/mac/BrowserWindowController.h:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithWindow:]):
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController validateMenuItem:]):
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController validateMenuItem:]):
Use the cached [menuItem action] like the earlier cases do.
- 11:29 AM Changeset in webkit [170193] by
-
- 3 edits in trunk/Source/WebCore
iOS build fix after http://trac.webkit.org/changeset/170167.
Reviewed by Geoff Garen.
- bindings/js/JSDeviceMotionEventCustom.cpp:
- bindings/js/JSDeviceOrientationEventCustom.cpp:
- 10:58 AM Changeset in webkit [170192] by
-
- 2 edits in trunk/Source/WebKit2
[iOS]: Overrelease of RetainPtr object in file upload
https://bugs.webkit.org/show_bug.cgi?id=134072
Reviewed by Brady Eidson.
This ivar is a RetainPtr, the release will be done automatically
for us when we assign to nil or destruct.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView fileUploadPanelDidDismiss:]):
- 10:57 AM Changeset in webkit [170191] by
-
- 2 edits2 adds in trunk/Source/WebKit2
Begin stubbing out new session state classes
https://bugs.webkit.org/show_bug.cgi?id=134110
Reviewed by Geoffrey Garen.
The basic idea is that these classes will replace the data blobs representing HistoryItems
that we currently send back and forth between the web and UI processes.
- Shared/SessionState.cpp: Added.
(WebKit::HTTPBody::Element::Element):
(WebKit::HTTPBody::Element::~Element):
(WebKit::FrameState::FrameState):
(WebKit::FrameState::~FrameState):
(WebKit::PageState::PageState):
(WebKit::PageState::~PageState):
- Shared/SessionState.h: Added.
(WebKit::HTTPBody::Element::type):
- WebKit2.xcodeproj/project.pbxproj:
- 10:25 AM Changeset in webkit [170190] by
-
- 2 edits in trunk/Source/WebCore
Enable synchronous willSendRequest on iOS
https://bugs.webkit.org/show_bug.cgi?id=134081
<rdar://problem/17350927>
Reviewed by Andreas Kling.
We lost the call to make willSendrequest callbacks be synchronous if possible during code
refactoring. The call is present in ResourceHandleMac.mm but that code is not called when
we use the CFNetwork based loader. Call the SPI in setupRequest().
No new tests because existing tests should cover this functionality.
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
- 10:20 AM Changeset in webkit [170189] by
-
- 4 edits in trunk/Tools
Teach run-{safari, webkit-app} about iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=133986
Reviewed by David Kilzer.
Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
and run-safari.
- Scripts/old-run-webkit-tests:
(installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
to call it.
(openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
(quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().
- Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used
(say, by specifying the optional command-line argument --simulator). For now, die() with an error
when the iOS device SDK is used as we don't support launching an app on the device at this time.
- Scripts/webkitdirs.pm:
(xcodeSDKVersion): Added.
(setupIOSWebKitEnvironment): Added.
(installedMobileSafariBundle): Added.
(mobileSafariBundle): Added.
(plistPathFromBundle): Added.
(appIdentiferFromBundle): Added.
(appDisplayNameFromBundle): Added.
(loadIPhoneSimulatorNotificationIfNeeded): Added.
(openIOSSimulator): Added.
(quitIOSSimulator): Added.
(iosSimulatorDeviceByName): Added.
(iosSimulatorRuntime): Added.
(findOrCreateSimulatorForIOSDevice): Added.
(runIOSWebKitAppInSimulator): Added.
(installAndLaunchIOSWebKitAppInSimulator): Added.
(runIOSWebKitApp): Added.
(runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
die() with an error when the iOS device SDK is used as we don't support launching Safari on the
device at this time.
- 10:16 AM Changeset in webkit [170188] by
-
- 8 edits2 moves in trunk/Source/WebKit2
Rename SessionState to LegacySessionState
https://bugs.webkit.org/show_bug.cgi?id=134107
Reviewed by Dan Bernstein.
- Shared/LegacySessionState.cpp: Renamed from Source/WebKit2/Shared/SessionState.cpp.
(IPC::ArgumentCoder<RefPtr<T>>::encode):
(IPC::ArgumentCoder<RefPtr<T>>::decode):
(WebKit::LegacySessionState::LegacySessionState):
(WebKit::LegacySessionState::isEmpty):
(WebKit::LegacySessionState::encode):
(WebKit::LegacySessionState::decode):
- Shared/LegacySessionState.h: Renamed from Source/WebKit2/Shared/SessionState.h.
(WebKit::LegacySessionState::list):
(WebKit::LegacySessionState::currentIndex):
- Shared/WebPageCreationParameters.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 9:35 AM Changeset in webkit [170187] by
-
- 4 edits2 adds in trunk
Add WTF::Optional class
https://bugs.webkit.org/show_bug.cgi?id=134083
Reviewed by Andreas Kling.
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/Optional.h: Added.
(WTF::Optional::Optional):
(WTF::Optional::~Optional):
(WTF::Optional::operator bool):
(WTF::Optional::value):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/Optional.cpp: Added.
(TestWebKitAPI::TEST):
- 8:39 AM Changeset in webkit [170186] by
-
- 2 edits in trunk/Tools
Adding myself to Commiters list.
- 6:47 AM Changeset in webkit [170185] by
-
- 2 edits in trunk/Source/WebKit2
Document the underlying types of the WKWindowFeatures rect properties
https://bugs.webkit.org/show_bug.cgi?id=134103
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWindowFeatures.h:
- 3:24 AM Changeset in webkit [170184] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Do not build quota files when QUOTA is disabled
https://bugs.webkit.org/show_bug.cgi?id=134101
Reviewed by Philippe Normand.
- CMakeLists.txt: Remove exception for GTK+ that is no longer
required since r170173.
- PlatformGTK.cmake: Generate GObject DOM bindings for Quota when enabled.
- 1:49 AM Changeset in webkit [170183] by
-
- 2 edits in trunk/Source/WebKit2
PluginProcessMainUnix should only scan for plugins when X11 plugin architecture is enabled
https://bugs.webkit.org/show_bug.cgi?id=134098
Reviewed by Carlos Garcia Campos.
- PluginProcess/unix/PluginProcessMainUnix.cpp: Guard the call to NetscapePluginModule::scanPlugin()
with PLUGIN_ARCHITECTURE(X11) since the declaration has the same build guard. In case the X11 plugin
architecture is not enabled the program exits with EXIT_FAILURE.
- 1:28 AM Changeset in webkit [170182] by
-
- 4 edits in trunk/Source/WebCore
[CSS Grid Layout] Add GridSpan::iterator
https://bugs.webkit.org/show_bug.cgi?id=134058
Reviewed by Bem Jones-Bey.
Once that GridResolvedPosition has been introduced in r169934, this
patch adds a GridSpan::iterator which allows to simplify the loops over
GridResolvedPositions.
From now on we could use range-based for loops.
No new tests as it is already covered by current tests
(fast/css-grid-layout/).
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeNormalizedFractionBreadth): Change loop to
ranged-based for.
(WebCore::RenderGrid::insertItemIntoGrid): Ditto.
(WebCore::RenderGrid::gridAreaBreadthForChild): Ditto.
- rendering/style/GridCoordinate.h: Define GridSpan::iterator.
(WebCore::GridSpan::begin): Return resolved initial position.
(WebCore::GridSpan::end): Return next to resolved final position.
- rendering/style/GridResolvedPosition.h:
(WebCore::GridResolvedPosition::operator*): Add operator required by
range-based for loops.
(WebCore::GridResolvedPosition::operator!=): Add not equal operator.
- 12:55 AM Changeset in webkit [170181] by
-
- 2 edits in trunk/Tools
[EFL] Add gstreamer as dependecy of EFL after r169785
https://bugs.webkit.org/show_bug.cgi?id=134066
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-20
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- 12:35 AM Changeset in webkit [170180] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix GTK+ debug build after r170174.
- bindings/gobject/WebKitDOMNodeFilter.cpp:
(WebKit::nodeFilterObjectDestroyedCallback):
- 12:33 AM Changeset in webkit [170179] by
-
- 15 edits in trunk/Source
LayerPool’d PlatformCALayerRemote/RemoteLayerBackingStore can have stale context pointers
https://bugs.webkit.org/show_bug.cgi?id=134050
<rdar://problem/17315114>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::layerPool):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
(WebKit::RemoteLayerTreeContext::layerPool):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::buildTransaction):
Ensure that layers being committed are always in the context that is committing them.
Use a LayerPool per RemoteLayerTreeContext, to avoid moving layers between contexts.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::platformReleaseMemory):
Drain all LayerPools upon memory pressure.
- platform/graphics/ca/LayerPool.cpp:
(WebCore::LayerPool::LayerPool):
(WebCore::LayerPool::~LayerPool):
(WebCore::LayerPool::allLayerPools):
(WebCore::LayerPool::sharedPool): Deleted.
- platform/graphics/ca/LayerPool.h:
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::createCompatibleLayerWithSize):
Add createCompatibleLayerWithSize, which optionally tries to take said layer from the LayerPool.
(WebCore::PlatformCALayer::moveToLayerPool):
Add moveToLayerPool, which moves the layer to the LayerPool.
(WebCore::PlatformCALayer::layerPool):
The LayerPool for each layer is obtained via PlatformCALayer::layerPool(), which subclasses can override for special behaviors.
The base class uses a global LayerPool.
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/TileController.cpp:
(WebCore::TileController::createTileLayer):
- platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::removeTiles):
- 12:31 AM Changeset in webkit [170178] by
-
- 4 edits in trunk/Source/WebKit2
WKContentViewInteraction isn't cleaned up when the Web Content process crashes
https://bugs.webkit.org/show_bug.cgi?id=134080
<rdar://problem/17387652> and <rdar://problem/16848360>
Reviewed by Benjamin Poulain.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _processDidExit]):
Tear down WKContentViewInteraction when the process crashes.
(-[WKContentView _didRelaunchProcess]):
Set WKContentViewInteraction back up when the process is relaunched.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
Clear the SmartMagnificationController, which is a message receiver and thus must be re-created with the new page.
Remove all gesture recognizers from the content view.
Clear _fileUploadPanel, else we'll get an assert the next time we try to open one.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessExited):
Give the PageClient a chance to clean up *before* we clean up internals;
it is at a higher level and some cleanup depends on WebPageProxy members
not having been cleared yet.
- 12:10 AM Changeset in webkit [170177] by
-
- 3 edits in trunk/Tools
[EFL] Merge url_utils.c to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=134095
Reviewed by Csaba Osztrogonác.
url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.
- MiniBrowser/efl/CMakeLists.txt:
Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.
- MiniBrowser/efl/main.c:
(has_scheme): Copied from url_utils.c
(url_from_user_input): Ditto.
- 12:00 AM Changeset in webkit [170176] by
-
- 4 edits in trunk/Tools
Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-19
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_gtk_wk2_port):
(DeprecatedPortTest.test_efl_port): Deleted.
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineExpectations.test_rebaseline_expectations):
Jun 19, 2014:
- 11:52 PM Changeset in webkit [170175] by
-
- 4 edits in trunk
[EFL][CMAKE] Disable WebKit1 build as a default
https://bugs.webkit.org/show_bug.cgi?id=134093
Reviewed by Gyuyoung Kim.
.:
Disable WebKit1 build and enable WebKit2 build for the EFL port.
- Source/cmake/OptionsEfl.cmake:
Tools:
- CMakeLists.txt:
- 11:44 PM Changeset in webkit [170174] by
-
- 7 edits8 adds in trunk
[GTK] webkit_dom_document_create_tree_walker impossible to use due to WebKitDOMNodeFilter
https://bugs.webkit.org/show_bug.cgi?id=93002
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Add custom implementation of WebKitDOMNodeFilter to expose it as
an interface instead of a class.
- PlatformGTK.cmake: Add new files to compilation.
- bindings/gobject/GObjectNodeFilterCondition.cpp: Added.
(WebCore::GObjectNodeFilterCondition::~GObjectNodeFilterCondition):
Reset the NodeFilter WebCore object associated to the
WebKitDOMNodeFilter object.
(WebCore::GObjectNodeFilterCondition::acceptNode): Call webkit_dom_node_filter_accept_node().
- bindings/gobject/GObjectNodeFilterCondition.h: Added.
(WebCore::GObjectNodeFilterCondition::create): Create a new
GObjectNodeFilterCondition for the given WebKitDOMNodeFilter.
(WebCore::GObjectNodeFilterCondition::GObjectNodeFilterCondition):
- bindings/gobject/WebKitDOMNodeFilter.cpp: Added.
(webkit_dom_node_filter_default_init):
(webkit_dom_node_filter_accept_node):
(WebKit::nodeFilterMap): Map NodeFilter WebCore objects to
WebKitDOMNodeFilter objects.
(WebKit::nodeFilterObjectDestroyedCallback): Remove the node
filter form the map when the WebKitDOMNodeFilter objecrt is destroyed.
(WebKit::kit): Return the WebKitDOMNodeFilter object for the given
NodeFilter WebCore object.
(WebKit::core): Get or create a NodeFilter WebCore object
associated to the given WebKitDOMNodeFilter.
- bindings/gobject/WebKitDOMNodeFilter.h: Added.
- bindings/gobject/WebKitDOMNodeFilter.symbols: Added.
- bindings/gobject/WebKitDOMNodeFilterPrivate.h: Added.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction): Add exceptions for NodeFilter parameters since
the core method returns a PassRefPtr.
Tools:
Add unit tests to check WebKitDOMNodefilter API used from both
TreeWalker and NodeIterator.
- Scripts/webkitpy/style/checker.py: Add exceptions for GTK+
public headers and add WebKitDOMNodeFilter to the list of exceptions.
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Added.
(webkitNodeFilterAcceptNode):
(webkitNodeFilterDOMNodeFilterIfaceInit):
(webkit_node_filter_init):
(webkit_node_filter_class_init):
(WebKitDOMNodeFilterTest::create):
(WebKitDOMNodeFilterTest::webPageFromArgs):
(WebKitDOMNodeFilterTest::testTreeWalker):
(WebKitDOMNodeFilterTest::testNodeIterator):
(WebKitDOMNodeFilterTest::runTest):
(registerTests):
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Added.
(runTest):
(testWebKitDOMNodeFilterTreeWalker):
(testWebKitDOMNodeFilterNodeIterator):
(beforeAll):
(afterAll):
- gtk/webkitdom.py:
(WebKitDOMDocGeneratorSections.init):
(WebKitDOMDocGeneratorSections._symbol_list):
(WebKitDOMDocGeneratorSections.write_section):
- 11:24 PM Changeset in webkit [170173] by
-
- 29 edits in trunk
[GTK] Limit the amount of API exposed to GObject DOM bindings API
https://bugs.webkit.org/show_bug.cgi?id=133726
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Split the GObject DOM bindings API into stable and unstable. The
unstable API is not included in the main webkitdom.h file, so that
to use it users have to include the headers individually and
define a macro WEBKIT_DOM_USE_UNSTABLE_API. For unstable methods
of stable classes we generate a {ClassName}Unstable.h header file
containing the unstable API. From now on we only keep backwards
compatibility for the stable API.
- PlatformGTK.cmake: Split GObject DOM bindings related variables
into Stable and Unstable. Add also
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_media_element_set_current_time): Deleted.
(webkit_dom_text_track_get_kind): Deleted.
(webkit_dom_text_track_get_mode): Deleted.
(webkit_dom_text_track_set_mode): Deleted.
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols: Remove custom symbols
added due to API changes.
- bindings/gobject/WebKitDOMPrivate.h: Include webkitdomdefines-unstable.h.
- bindings/gobject/webkitdom.symbols: Remove all unstable symbols.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Do not skip webkit_dom_html_media_element_set_current_time anymore.
(GenerateHeader): Only force single header include for stable
headers and add WEBKIT_DOM_USE_UNSTABLE_API #ifdef to unstable headers.
(GenerateFunction): Only add stable symbols to the symbols
array. Add function prototypes to main header or unstable header
depending on whether it's an unstable symbol for a stable class or
not. Also add Stability gtk-doc tag to unstable methods.
(GenerateEndHeader): Add required #endifs
(WriteData): Write also an Unstable.h header when appropriate and
only generate a symbols file for stable classes.
(ReadStableSymbols): Read the stable symbols for the current class.
(GenerateInterface): Call ReadStableSymbols.
- bindings/scripts/gobject-generate-headers.pl: Generate webkitdomdefines-unstable.h.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
- bindings/scripts/test/GObject/WebKitDOMTestException.h:
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestNode.h:
- bindings/scripts/test/GObject/WebKitDOMTestNondeterministic.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
- bindings/scripts/test/GObject/WebKitDOMattribute.h:
- bindings/scripts/test/GObject/WebKitDOMreadonly.h:
Tools:
Don't make fatal finding files without a .symbols file, since now
only the stable DOM API has .symbols files.
- gtk/webkitdom.py:
(get_all_webkitdom_symbol_files):
- 7:56 PM Changeset in webkit [170172] by
-
- 8 edits in trunk/Tools
Remove efl wk1 buildbot and ews
https://bugs.webkit.org/show_bug.cgi?id=134089
Reviewed by Benjamin Poulain.
EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- QueueStatusServer/config/queues.py:
- Scripts/webkitpy/common/config/ews.json:
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(QtWK2Port.run_webkit_tests_command):
(EflPort): Deleted.
(EflPort.build_webkit_command): Deleted.
- Scripts/webkitpy/port/builders.py:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- TestResultServer/static-dashboards/loader_unittests.js:
- 7:12 PM Changeset in webkit [170171] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed fix after r170130.
- JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.vcxproj:
Corrected directory so it can find common.props when opening Visual Studio.
- 6:39 PM Changeset in webkit [170170] by
-
- 3 edits in trunk/Source/WebKit2
Removed unused SPI -[WKWebView _runJavaScriptInMainFrame:].
Rubber-stamped by Simon Fraser.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _runJavaScriptInMainFrame:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 6:31 PM Changeset in webkit [170169] by
-
- 2 edits in trunk/Source/WebCore
When simulating memory pressure, GC *after* releasing WebCore resources.
Since clearing the page cache is likely to create lots of garbage, defer the
synchronous GC until after the WebCore pressure relief, so we can see the
effect of clearing out all those pages.
Rubber-stamped by Gavin Barraclough.
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
- 5:49 PM Changeset in webkit [170168] by
-
- 5 edits in trunk/Source/WebKit2
Use a single map for all callback types in WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=134069
Reviewed by Tim Horton.
- UIProcess/GenericCallback.h:
(WebKit::CallbackMap::take):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::printFinishedCallback):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::drawPagesForPrinting):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):
(WebKit::WebPageProxy::attributedStringForCharacterRangeCallback):
- 4:42 PM Changeset in webkit [170167] by
-
- 86 edits in trunk/Source/WebCore
Move generate prototype and constructor classes into the generated implementation files
https://bugs.webkit.org/show_bug.cgi?id=134054
Reviewed by Oliver Hunt.
In an effort to reduce the size of the generated bindings headers, which is important
as the generated headers get included in a lot of places, this patch moves the prototype
and constructor declarations from the header to implementation file. This works because,
for the most part, no code cares about the prototype or constructors except the instance.
There are a few exceptions which had to be accounted for:
- The global objects (JSDOMWindow and JSWorkerGlobalScope) need to have their prototypes available during initialization, so they remain in the header.
- JSLocation requires customizing some aspects of the prototype behavior, so its prototype, and any future class that uses JSCustomNamedGetterOnPrototype or JSCustomDefineOwnPropertyOnPrototype, remains in the header.
- A few classes had custom constructor functions. Instead of keeping the entire constructor in the header, I opted for pulling just the static constructor function into the header, and modifying the custom constructors to use the DOMConstructorObject type as the callee, since the more specific type was unnecessary.
As a result of making these changes, I was also able to remove the #include of JSDOMBinding.h from
all the headers, which brought in quite a bit.
- bindings/js/JSAudioContextCustom.cpp:
(WebCore::constructJSAudioContext):
(WebCore::JSAudioContextConstructor::constructJSAudioContext): Deleted.
- bindings/js/JSBlobCustom.cpp:
(WebCore::constructJSBlob):
(WebCore::JSBlobConstructor::constructJSBlob): Deleted.
- bindings/js/JSCryptoCustom.cpp:
- bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::constructJSDOMFormData):
(WebCore::JSDOMFormDataConstructor::constructJSDOMFormData): Deleted.
- bindings/js/JSDOMMimeTypeArrayCustom.cpp:
- bindings/js/JSDOMPluginArrayCustom.cpp:
- bindings/js/JSDOMPluginCustom.cpp:
- bindings/js/JSDataCueCustom.cpp:
(WebCore::constructJSDataCue):
(WebCore::JSDataCueConstructor::constructJSDataCue): Deleted.
- bindings/js/JSDataTransferCustom.cpp:
- bindings/js/JSEventCustom.cpp:
- bindings/js/JSFileReaderCustom.cpp:
- bindings/js/JSHistoryCustom.cpp:
- bindings/js/JSIDBAnyCustom.cpp:
- bindings/js/JSIDBDatabaseCustom.cpp:
- bindings/js/JSIDBObjectStoreCustom.cpp:
- bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::finishCreation):
- bindings/js/JSImageDataCustom.cpp:
- bindings/js/JSInspectorFrontendHostCustom.cpp:
- bindings/js/JSLocationCustom.cpp:
- bindings/js/JSMessagePortCustom.cpp:
- bindings/js/JSMutationObserverCustom.cpp:
(WebCore::constructJSMutationObserver):
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver): Deleted.
- bindings/js/JSSQLResultSetRowListCustom.cpp:
- bindings/js/JSSQLTransactionSyncCustom.cpp:
- bindings/js/JSSVGLengthCustom.cpp:
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::constructJSSharedWorker):
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Deleted.
- bindings/js/JSStorageCustom.cpp:
- bindings/js/JSUserMessageHandlersNamespaceCustom.cpp:
- bindings/js/JSWebKitPointCustom.cpp:
(WebCore::constructJSWebKitPoint):
(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint): Deleted.
- bindings/js/JSWorkerCustom.cpp:
(WebCore::constructJSWorker):
(WebCore::JSWorkerConstructor::constructJSWorker): Deleted.
- bindings/js/SerializedScriptValue.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GeneratePrototypeDeclaration):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
(HeaderNeedsPrototypeDeclaration):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.h:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSattribute.h:
- bindings/scripts/test/JS/JSreadonly.cpp:
- bindings/scripts/test/JS/JSreadonly.h:
- 3:57 PM Changeset in webkit [170166] by
-
- 2 edits in trunk/Source/WebKit2
Another build fix attempt.
- Shared/API/Cocoa/WKFoundation.h:
- 3:50 PM Changeset in webkit [170165] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] Legacy processes are installed inside WebKit.framework
https://bugs.webkit.org/show_bug.cgi?id=134079
Reviewed by Anders Carlsson.
- Configurations/All.xcconfig: Exclude the legacy processes on iOS so they don’t get copied.
- Configurations/BaseLegacyProcess.xcconfig: Set SKIP_INSTALL to YES on iOS.
- 3:23 PM Changeset in webkit [170164] by
-
- 2 edits in trunk/Source/WebKit2
It's OS X, not OSX...
- Shared/API/Cocoa/WKFoundation.h:
- 3:15 PM Changeset in webkit [170163] by
-
- 4 edits in trunk/Source/WebKit2
Unfreeze the layer tree on DidFirstVisuallyNonEmptyLayout
https://bugs.webkit.org/show_bug.cgi?id=134073
Reviewed by Simon Fraser.
DidFirstLayout is too early and we usually get a blank page. This doesn't match the existing iOS behavior either.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 3:04 PM Changeset in webkit [170162] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the Mavericks build.
- Shared/API/Cocoa/WKFoundation.h:
- 2:51 PM Changeset in webkit [170161] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] StructureSet::onlyStructure() should return nullptr if it's not a singleton (instead of asserting)
https://bugs.webkit.org/show_bug.cgi?id=134077
Reviewed by Sam Weinig.
This makes StructureSet and StructureAbstractValue more consistent and fixes a debug assert
in the abstract interpreter.
- bytecode/StructureSet.h:
(JSC::StructureSet::onlyStructure):
- 1:54 PM Changeset in webkit [170160] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Need SPI to determine if the WKWebView is displaying a standalone image
https://bugs.webkit.org/show_bug.cgi?id=134071
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isDisplayingStandaloneImageDocument]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 1:47 PM Changeset in webkit [170159] by
-
- 1 edit6 adds in branches/ftlopt/LayoutTests
[ftlopt] LICM should be able to hoist CheckStructure even if the loop clobbers structures so long as the structures being checked are watchable
https://bugs.webkit.org/show_bug.cgi?id=134056
Unreviewed, just landing the test cases for this attempted optimization. The test cases
will still be valid once we find a smart way of doing this optimization.
- js/regress/hoist-poly-check-structure-effectful-loop-expected.txt: Added.
- js/regress/hoist-poly-check-structure-effectful-loop.html: Added.
- js/regress/hoist-poly-check-structure-expected.txt: Added.
- js/regress/hoist-poly-check-structure.html: Added.
- js/regress/script-tests/hoist-poly-check-structure-effectful-loop.js: Added.
(foo):
(test):
- js/regress/script-tests/hoist-poly-check-structure.js: Added.
(foo):
(test):
- 12:59 PM Changeset in webkit [170158] by
-
- 5 edits in trunk/Source/WebKit2
Use a single map for all callback types in WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=134069
Reviewed by Anders Carlsson.
- UIProcess/GenericCallback.h:
(WebKit::CallbackBase::as): Added. Performs a dynamic cast to a specific callback type.
(WebKit::CallbackBase::CallbackBase): Added a type parameter, which is used to initialize
the new m_type member.
(WebKit::GenericCallback::GenericCallback): Pass the type to the base class constructor.
(WebKit::GenericCallback::type): Added. Returns a unique type.
(WebKit::GenericCallback::invalidate): Now virtual.
(WebKit::CallbackMap::put): Adds the callback to the map.
(WebKit::CallbackMap::take): Removes the callback from the map, and dynamically casts it to
the specified type.
(WebKit::CallbackMap::invalidate): Invalidates the map.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateCommand):
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getBytecodeProfile):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):
(WebKit::WebPageProxy::forceRepaint):
(WebKit::WebPageProxy::clearLoadDependentCallbacks):
(WebKit::WebPageProxy::voidCallback):
(WebKit::WebPageProxy::dataCallback):
(WebKit::WebPageProxy::imageCallback):
(WebKit::WebPageProxy::stringCallback):
(WebKit::WebPageProxy::scriptValueCallback):
(WebKit::WebPageProxy::computedPagesCallback):
(WebKit::WebPageProxy::validateCommandCallback):
(WebKit::WebPageProxy::unsignedCallback):
(WebKit::WebPageProxy::editingRangeCallback):
(WebKit::WebPageProxy::rectForCharacterRangeCallback):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::computePagesForPrinting):
(WebKit::WebPageProxy::drawRectToImage):
(WebKit::WebPageProxy::drawPagesToPDF):
(WebKit::WebPageProxy::getMarkedRangeAsync):
(WebKit::WebPageProxy::getSelectedRangeAsync):
(WebKit::WebPageProxy::characterIndexForPointAsync):
(WebKit::WebPageProxy::firstRectForCharacterRangeAsync):
(WebKit::WebPageProxy::takeSnapshot):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::gestureCallback):
(WebKit::WebPageProxy::touchesCallback):
(WebKit::WebPageProxy::autocorrectionDataCallback):
(WebKit::WebPageProxy::dictationContextCallback):
(WebKit::WebPageProxy::autocorrectionContextCallback):
(WebKit::WebPageProxy::selectWithGesture):
(WebKit::WebPageProxy::updateSelectionWithTouches):
(WebKit::WebPageProxy::requestAutocorrectionData):
(WebKit::WebPageProxy::applyAutocorrection):
(WebKit::WebPageProxy::requestDictationContext):
(WebKit::WebPageProxy::requestAutocorrectionContext):
(WebKit::WebPageProxy::selectWithTwoTouches):
- 12:51 PM Changeset in webkit [170157] by
-
- 5 edits in trunk/Source/WebKit2
No way to handle HTTP Authentication with WKWebView
https://bugs.webkit.org/show_bug.cgi?id=134067
<rdar://problem/17317874>
Reviewed by Dan Bernstein.
Add a public webView:didReceiveAuthenticationChallenge:completionHandler: delegate method and get rid of the SPI.
- Shared/API/Cocoa/WKFoundation.h:
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame):
- 12:23 PM Changeset in webkit [170156] by
-
- 6 edits in trunk/Source/WebKit2
Don't kill the UIProcess until all local storage transactions have been committed.
https://bugs.webkit.org/show_bug.cgi?id=134042.
<rdar://problem/16660724>.
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm: Add a listener for the application will terminate notification.
(-[WKView _applicationWillTerminate:]):
(-[WKView initWithFrame:context:configuration:webView:]):
- UIProcess/WebContext.cpp: Calls code in StorageManager to cleanup local storage transactions upon application termination.
(WebKit::WebContext::applicationWillTerminate):
- UIProcess/WebContext.h:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::applicationWillTerminate):
Dispatch local storage cleanup task to background thread and make sure the UIProcess can't exit early.
- UIProcess/Storage/StorageManager.h:
- 11:56 AM Changeset in webkit [170155] by
-
- 2 edits in trunk/Source/WebKit2
2014-06-19 Oliver Hunt <oliver@apple.com>
Switch to using the process parameters during initialisation
to determine whether we hsould be using the network process.
RS=Sam Weinig
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
- 11:33 AM Changeset in webkit [170154] by
-
- 6 edits in trunk/Source/WebKit2
Copy SharedBuffer data into IPC message directly
https://bugs.webkit.org/show_bug.cgi?id=133920
Reviewed by Anders Carlsson.
When data array callbacks are enabled, we currently merge all the CFDataRefs in SharedBuffer
into one contiguous memory buffer when creating IPC::DataReference. This patch creates a
subclass of DataReference that uses SharedBuffer::getSomeData() to copy the data directly
into the IPC message.
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):
- Platform/IPC/ArgumentEncoder.cpp:
(IPC::ArgumentEncoder::reserve): Added.
(IPC::ArgumentEncoder::grow):
- Platform/IPC/ArgumentEncoder.h:
- Platform/IPC/DataReference.cpp:
(IPC::SharedBufferDataReference::encode):
- Platform/IPC/DataReference.h:
(IPC::DataReference::~DataReference):
- 10:53 AM Changeset in webkit [170153] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Compile errors related to http header field names.
https://bugs.webkit.org/show_bug.cgi?id=134029
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-06-19
Reviewed by Brent Fulgham.
Http header field names should now be specified with an enum, not a string.
- platform/network/curl/MultipartHandle.cpp:
(WebCore::MultipartHandle::didReceiveResponse):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::getProtectionSpace):
- 10:48 AM Changeset in webkit [170152] by
-
- 3 edits in trunk/Tools
check-webkit-style does not understand Obj-C literal syntax for NSDictionary
<http://webkit.org/b/134061>
Reviewed by Dan Bernstein.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing): Ignore '@' immediately before '{'.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_before_braces): Add unit test for
'{' block syntax and '@{' Objective-C liternal NSDitionary
syntax.
- 10:41 AM Changeset in webkit [170151] by
-
- 2 edits in trunk/Source/WebCore
Put the divider in the right place.
- DerivedSources.make:
- 10:41 AM Changeset in webkit [170150] by
-
- 2 edits in trunk/Source/WebCore
Address a review comment from Darin.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willLoadXHR):
- 10:29 AM Changeset in webkit [170149] by
-
- 2 edits in trunk/Source/WebKit/win
Try to fix Windows build.
- WebFrame.h:
- 10:29 AM Changeset in webkit [170148] by
-
- 3 edits in trunk/Source/WebCore
Simplify two HistoryController member functions
https://bugs.webkit.org/show_bug.cgi?id=134064
Reviewed by Dan Bernstein.
Remove the FrameLoadType parameter from recursiveSetProvisionalItem,
use early returns and modern loops.
- loader/HistoryController.cpp:
(WebCore::HistoryController::goToItem):
(WebCore::HistoryController::recursiveSetProvisionalItem):
(WebCore::HistoryController::recursiveGoToItem):
- loader/HistoryController.h:
- 9:32 AM Changeset in webkit [170147] by
-
- 56 edits in trunk
Remove ENABLE(LLINT) and ENABLE(LLINT_C_LOOP) guards
https://bugs.webkit.org/show_bug.cgi?id=130389
Reviewed by Mark Lam.
Removed ENABLE(LLINT) since we always build with it, and changed ENABLE(LLINT_C_LOOP)
into !ENABLE(JIT) since they are mutually exclusive.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- CMakeLists.txt:
- assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::createLLIntCodePtr):
(JSC::MacroAssemblerCodeRef::createLLIntCodeRef):
- assembler/MaxFrameExtentForSlowPathCall.h:
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFromLLInt):
- bytecode/CodeBlock.cpp:
(JSC::dumpStructure):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::frameRegisterCount):
- bytecode/CodeBlock.h:
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
- heap/Heap.cpp:
(JSC::Heap::gatherJSStackRoots):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
- interpreter/Interpreter.h:
(JSC::Interpreter::getOpcodeID):
- interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
(JSC::JSStack::committedByteCount):
- interpreter/JSStack.h:
- interpreter/JSStackInlines.h:
(JSC::JSStack::ensureCapacityFor):
(JSC::JSStack::topOfFrameFor):
(JSC::JSStack::setStackLimit):
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
- jit/JIT.h:
(JSC::JIT::compileCTINativeCall):
- jit/JITExceptions.h:
- jit/JITThunks.cpp:
(JSC::JITThunks::ctiNativeCall):
(JSC::JITThunks::ctiNativeConstruct):
- llint/LLIntCLoop.cpp:
- llint/LLIntCLoop.h:
- llint/LLIntData.cpp:
(JSC::LLInt::initialize):
(JSC::LLInt::Data::performAssertions):
- llint/LLIntData.h:
(JSC::LLInt::Data::performAssertions): Deleted.
- llint/LLIntEntrypoint.cpp:
- llint/LLIntEntrypoint.h:
- llint/LLIntExceptions.cpp:
- llint/LLIntExceptions.h:
- llint/LLIntOfflineAsmConfig.h:
- llint/LLIntOffsetsExtractor.cpp:
(JSC::LLIntOffsetsExtractor::dummy):
- llint/LLIntOpcode.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LLIntThunks.cpp:
- llint/LLIntThunks.h:
- llint/LowLevelInterpreter.cpp:
- llint/LowLevelInterpreter.h:
- runtime/CommonSlowPaths.cpp:
- runtime/CommonSlowPaths.h:
- runtime/ErrorHandlingScope.cpp:
(JSC::ErrorHandlingScope::ErrorHandlingScope):
(JSC::ErrorHandlingScope::~ErrorHandlingScope):
- runtime/Executable.cpp:
(JSC::setupLLInt):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreading):
- runtime/JSCJSValue.h:
- runtime/JSCJSValueInlines.h:
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::sanitizeStackForVM):
- runtime/VM.h:
(JSC::VM::canUseJIT): Deleted.
Source/WTF:
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
- wtf/Platform.h:
- 9:22 AM Changeset in webkit [170146] by
-
- 2 edits in trunk/Source/WebCore
MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL() leaks an NSMutableArray
<http://webkit.org/b/134052>
Reviewed by Eric Carlson.
Fixes the following static analyzer warning:
WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:688:43: warning: Potential leak of an object stored into 'outOfBandTracks'
NSMutableArray* outOfBandTracks = [[NSMutableArray alloc] init];
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
Use RetainPtr<NSMutableArray> to prevent a leak. Use
Objective-C literals to clean up the code.
- 2:14 AM Changeset in webkit [170145] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Updated text expectations after r170138.
- platform/gtk/accessibility/image-map2-expected.txt: Updated.
- platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Updated.
- 12:25 AM Changeset in webkit [170144] by
-
- 2 edits in trunk/LayoutTests
[EFL] Add expectations for failing svg/wicd/rightsizing-grid.xhtml layout test
https://bugs.webkit.org/show_bug.cgi?id=133982
Unreviewed gardening.
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-06-19
- platform/efl/TestExpectations:
Jun 18, 2014:
- 10:54 PM Changeset in webkit [170143] by
-
- 14 edits in trunk/Source/WebCore
ScriptExecutionContext::Task, FileThread::Task parameters should be values
https://bugs.webkit.org/show_bug.cgi?id=134035
Reviewed by Anders Carlsson.
r170106 and similar previous changesets enforced ScriptExecutionContext::Task and
FileThread::Task parameters as rvalue references. There's technically nothing wrong
with that, but since both classes are move-only it is also not strictly required.
Accepting these parameters as values is more common in C++ value semantics as well.
- dom/Document.cpp:
(WebCore::Document::postTask):
- dom/Document.h:
- dom/ScriptExecutionContext.h:
- fileapi/FileThread.cpp:
(WebCore::FileThread::postTask):
- fileapi/FileThread.h:
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::postTask):
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- 10:37 PM Changeset in webkit [170142] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fixing the GTK+ build after r170114.
- UIProcess/API/gtk/WebKitAuthenticationRequest.cpp:
(webkit_authentication_request_get_proposed_credential):
The core() accessor has been renamed to credential().
- 9:34 PM Changeset in webkit [170141] by
-
- 17 edits21 adds in branches/ftlopt
DFG AI and constant folder should be able to precisely prune MultiGetByOffset/MultiPutByOffset even if the base structure abstract value is not a singleton
https://bugs.webkit.org/show_bug.cgi?id=133918
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
This also adds pruning of PutStructure, since I basically had no choice but
to implement such logic within MultiPutByOffset.
Also adds a bunch of PutById cache status dumping to bytecode dumping.
- bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::dumpInContext):
- bytecode/GetByIdVariant.h:
(JSC::GetByIdVariant::structureSet):
- bytecode/PutByIdVariant.h:
(JSC::PutByIdVariant::oldStructure):
- bytecode/StructureSet.cpp:
(JSC::StructureSet::filter):
(JSC::StructureSet::filterArrayModes):
- bytecode/StructureSet.h:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::changeStructure):
(JSC::DFG::AbstractValue::contains):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::couldBeType):
(JSC::DFG::AbstractValue::isType):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::addBaseCheck):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::freezeStrong):
- dfg/DFGGraph.h:
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::operator=):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
- tests/stress/fold-multi-get-by-offset-to-get-by-offset-without-folding-the-structure-check.js: Added.
(foo):
(fu):
(bar):
(baz):
(.bar):
(.baz):
- tests/stress/fold-multi-put-by-offset-to-put-by-offset-without-folding-the-structure-check.js: Added.
(foo):
(fu):
(bar):
(baz):
(.bar):
(.baz):
- tests/stress/prune-multi-put-by-offset-replace-or-transition-variant.js: Added.
(foo):
(fu):
(bar):
(baz):
(.bar):
(.baz):
LayoutTests:
- js/regress/fold-multi-get-by-offset-to-get-by-offset-expected.txt: Added.
- js/regress/fold-multi-get-by-offset-to-get-by-offset.html: Added.
- js/regress/fold-multi-get-by-offset-to-poly-get-by-offset-expected.txt: Added.
- js/regress/fold-multi-get-by-offset-to-poly-get-by-offset.html: Added.
- js/regress/fold-multi-put-by-offset-to-poly-put-by-offset-expected.txt: Added.
- js/regress/fold-multi-put-by-offset-to-poly-put-by-offset.html: Added.
- js/regress/fold-multi-put-by-offset-to-put-by-offset-expected.txt: Added.
- js/regress/fold-multi-put-by-offset-to-put-by-offset.html: Added.
- js/regress/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset-expected.txt: Added.
- js/regress/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset.html: Added.
- js/regress/fold-put-structure-expected.txt: Added.
- js/regress/fold-put-structure.html: Added.
- js/regress/script-tests/fold-multi-get-by-offset-to-get-by-offset.js: Added.
(foo):
(fu):
(bar):
(.bar):
- js/regress/script-tests/fold-multi-get-by-offset-to-poly-get-by-offset.js: Added.
(foo):
(fu):
(bar):
(.bar):
- js/regress/script-tests/fold-multi-put-by-offset-to-poly-put-by-offset.js: Added.
(foo):
(fu):
(bar):
(.bar):
- js/regress/script-tests/fold-multi-put-by-offset-to-put-by-offset.js: Added.
(foo):
(fu):
(bar):
(.bar):
- js/regress/script-tests/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset.js: Added.
(foo):
(fu):
(bar):
(.bar):
- js/regress/script-tests/fold-put-structure.js: Added.
(foo):
(fu):
(bar):
(.bar):
- 9:16 PM Changeset in webkit [170140] by
-
- 3 edits in trunk/Source/WebKit2
Try to fix the Mountain Lion build.
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame):
- 8:11 PM Changeset in webkit [170139] by
-
- 5 edits in trunk/Source/WebKit2
Remove RemoteLayerBackingStore’s RemoteLayerTreeContext pointer
https://bugs.webkit.org/show_bug.cgi?id=134055
Reviewed by Simon Fraser.
- Shared/mac/RemoteLayerBackingStore.h:
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::RemoteLayerBackingStore):
(WebKit::RemoteLayerBackingStore::~RemoteLayerBackingStore):
(WebKit::RemoteLayerBackingStore::ensureBackingStore):
(WebKit::RemoteLayerBackingStore::display):
(WebKit::RemoteLayerBackingStore::drawInContext):
Remove RemoteLayerBackingStore's RemoteLayerTreeContext pointer. Instead, use the PlatformCALayer's.
Pass the PlatformCALayer in to the constructor, and remove it from ensureBackingStore();
RemoteLayerBackingStore is (for now) strictly tied to a single layer.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::ensureBackingStore):
(WebKit::PlatformCALayerRemote::updateBackingStore):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
(WebKit::PlatformCALayerRemote::context):
- 7:19 PM Changeset in webkit [170138] by
-
- 11 edits in trunk
Web Inspector: AXI: expose aria-relevant
https://bugs.webkit.org/show_bug.cgi?id=130913
Reviewed by Joseph Pecoraro.
Expose ARIA live region relevance in Web Inspector.
E.g. "Live: Assertive (Additions, Text)"
Source/WebCore:
Test: inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties): Support for liveRegionRelevant.
- inspector/protocol/DOM.json: Defined enum values and array passed to client.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js: New strings.
- UserInterface/Models/DOMNode.js: One additional property passed.
- UserInterface/Views/DOMNodeDetailsSidebarPanel.js: UI updates to support new property.
LayoutTests:
- inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Minor update.
- inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt: Updated with new output.
- inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html: Updated with new elements.
- 5:30 PM Changeset in webkit [170137] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Modernize one-method authentication
https://bugs.webkit.org/show_bug.cgi?id=134051
Reviewed by Anders Carlsson.
Instead of an NSURLConnection-style delegate method that takes a challenge and responds to
its sender, provide an NSURLSession-style method that takes a challenge and a completion
handler.
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Declared new delegate method, replacing
old unused method.
- UIProcess/Cocoa/NavigationState.h: Renamed flag in m_navigationDelegateMethods struct.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate): Check for new delegate method and update
new flag.
(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame): If
the delegate implements the new method, return true (if it cannot handle the protection
space, it can reject it through the completion handler), except for server-trust
authentication, which is not supported yet.
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame): If the
delegate implements the new method, call it, passing a completion handler that calls the
right AuthenticationDecisionListener function based on its disposition and credential
parameters.
- 5:21 PM Changeset in webkit [170136] by
-
- 10 edits in trunk
Add rebeccapurple to CSS named color list
https://bugs.webkit.org/show_bug.cgi?id=133804
Reviewed by Jer Noble.
Source/WebCore:
Add the named color "rebeccapurple" (#639).
- css/SVGCSSValueKeywords.in:
- platform/ColorData.gperf:
Source/WebInspectorUI:
Add the named color "rebeccapurple" (#639).
- UserInterface/External/CodeMirror/css.js:
- UserInterface/Models/CSSKeywordCompletions.js:
- UserInterface/Models/Color.js:
LayoutTests:
Add the named color "rebeccapurple" (#639).
- fast/css/named-colors-expected.txt:
- fast/css/named-colors.html:
- 5:20 PM Changeset in webkit [170135] by
-
- 4 edits in trunk
Fix flaky beforeload tests
https://bugs.webkit.org/show_bug.cgi?id=133685
Reviewed by David Kilzer.
Source/WebCore:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
LayoutTests:
- platform/wk2/TestExpectations: Unskip tests that are no longer flaky
- 5:13 PM Changeset in webkit [170134] by
-
- 19 edits in trunk/Source
Make FrameLoadType a strongly typed enum
https://bugs.webkit.org/show_bug.cgi?id=134047
Reviewed by Andreas Kling.
Source/WebCore:
- history/BackForwardController.cpp:
(WebCore::BackForwardController::goBackOrForward):
(WebCore::BackForwardController::goBack):
(WebCore::BackForwardController::goForward):
- history/PageCache.cpp:
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
- loader/FrameLoader.cpp:
(WebCore::isBackForwardLoadType):
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::isReplacing):
(WebCore::FrameLoader::setReplacing):
(WebCore::FrameLoader::subresourceCachePolicy):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::shouldPerformFragmentNavigation):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):
- loader/FrameLoaderTypes.h:
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreDocumentState):
(WebCore::HistoryController::updateForReload):
(WebCore::HistoryController::isReplaceLoadTypeWithProvisionalItem):
(WebCore::HistoryController::isReloadTypeWithProvisionalItem):
- loader/NavigationAction.cpp:
(WebCore::navigationType):
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::PolicyChecker):
(WebCore::PolicyChecker::checkNavigationPolicy):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::cachePolicy):
- loader/icon/IconController.cpp:
(WebCore::IconController::startLoader):
Source/WebKit/mac:
- WebView/WebFrame.mm:
(toWebFrameLoadType):
(-[WebFrame _loadType]):
- WebView/WebView.mm:
(-[WebView _loadBackForwardListFromOtherView:]):
(-[WebView goToBackForwardItem:]):
Source/WebKit/win:
- WebView.cpp:
(WebView::goToBackForwardItem):
(WebView::loadBackForwardListFromOtherView):
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
(WebKit::shouldReuseCommittedSandboxExtension):
(WebKit::WebPage::didCommitLoad):
- 5:11 PM Changeset in webkit [170133] by
-
- 14 edits in trunk/Source/WebKit2
Simplify WebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=134049
Reviewed by Andreas Kling.
- Shared/API/c/WKSecurityOrigin.cpp:
(WKSecurityOriginCreateFromString):
(WKSecurityOriginCreateFromDatabaseIdentifier):
(WKSecurityOriginCopyDatabaseIdentifier):
(WKSecurityOriginCopyToString):
(WKSecurityOriginCopyProtocol):
(WKSecurityOriginCopyHost):
(WKSecurityOriginGetPort):
- Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::securityOrigin):
(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier): Deleted.
(WebKit::WebSecurityOrigin::protocol): Deleted.
(WebKit::WebSecurityOrigin::host): Deleted.
(WebKit::WebSecurityOrigin::port): Deleted.
(WebKit::WebSecurityOrigin::databaseIdentifier): Deleted.
(WebKit::WebSecurityOrigin::toString): Deleted.
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::deleteEntriesForOrigin):
- UIProcess/Storage/StorageManager.h:
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):
- UIProcess/WebKeyValueStorageManager.cpp:
(WebKit::didGetStorageDetailsByOrigin):
- UIProcess/WebOriginDataManagerProxy.cpp:
(WebKit::WebOriginDataManagerProxy::deleteEntriesForOrigin):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::exceededDatabaseQuota):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
- UIProcess/ios/WKGeolocationProviderIOS.mm:
(-[WKGeolocationProviderIOS decidePolicyForGeolocationRequestFromOrigin:frame:request:window:]):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exceededDatabaseQuota):
- 5:06 PM Changeset in webkit [170132] by
-
- 4 edits in trunk/Source/WebCore
[curl] Unreviewed speculative build fix after r170021.
- platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::setResponseFromCachedHeaders):
(WebCore::CurlCacheEntry::parseResponseHeaders):
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::didReceiveHeader):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::getProtectionSpace):
(WebCore::headerCallback):
Use HTTPHeaderName constants.
- 4:49 PM Changeset in webkit [170131] by
-
- 5 edits in trunk/Source/WebCore
Move the removeNode() tree walking from ScrollingStateNote into ScrollingStateTree
https://bugs.webkit.org/show_bug.cgi?id=134043
Reviewed by Beth Dakin.
It's cleaner if ScrollingStateTree does the descendant walk when removing nodes.
We can simply start the "willBeRemoved" walk at the node in question.
Have willRemoveNode() just remove the node from the m_stateNodeMap directly, rather
than this happening in a separate walk of m_nodesRemovedSinceLastCommit.
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::removeDescendant): Deleted.
(WebCore::ScrollingStateNode::willBeRemovedFromStateTree): Deleted.
- page/scrolling/ScrollingStateNode.h:
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::detachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNodeAndAllDescendants):
(WebCore::ScrollingStateTree::recursiveNodeWillBeRemoved):
(WebCore::ScrollingStateTree::willRemoveNode):
(WebCore::ScrollingStateTree::removeNode): Deleted.
- page/scrolling/ScrollingStateTree.h:
- 4:42 PM Changeset in webkit [170130] by
-
- 7 edits5 adds in trunk/Source
Add FTL to Windows build.
https://bugs.webkit.org/show_bug.cgi?id=134015
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
Added ftl source files.
- JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
Added ftl and llvm directories to include path.
- JavaScriptCore.vcxproj/libllvmForJSC: Added.
- JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.props: Added.
- JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.vcxproj: Added.
- JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.vcxproj.filters: Added.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileArithMinOrMax):
MSVC doesn't like to divide by zero while compiling. Use std::nan instead.
- llvm/InitializeLLVMWin.cpp: Added.
(JSC::initializeLLVMImpl):
Implemented dynamic loading and linking for Windows.
Source/WebKit:
- WebKit.vcxproj/WebKit.sln:
Added libllvmForJSC with a dependency on JavaScriptCoreGenerated, but don't build it yet.
- 4:16 PM Changeset in webkit [170129] by
-
- 19 edits in branches/ftlopt/Source/JavaScriptCore
Remove CompoundType and LeafType
https://bugs.webkit.org/show_bug.cgi?id=134037
Reviewed by Filip Pizlo.
We don't use them for anything. We'll replace them with a generic CellType type for all
the objects that are JSCells, aren't JSObjects, and for which we generally don't care about
their JSType at runtime.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- runtime/ArrayBufferNeuteringWatchpoint.cpp:
(JSC::ArrayBufferNeuteringWatchpoint::createStructure):
- runtime/Executable.h:
(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
- runtime/JSPromiseDeferred.h:
(JSC::JSPromiseDeferred::createStructure):
- runtime/JSPromiseReaction.h:
(JSC::JSPromiseReaction::createStructure):
- runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
- runtime/JSType.h:
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
- runtime/MapData.h:
(JSC::MapData::createStructure):
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::createStructure):
- runtime/RegExp.h:
(JSC::RegExp::createStructure):
- runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayValueMap::createStructure):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- runtime/StructureChain.h:
(JSC::StructureChain::createStructure):
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::createStructure):
- runtime/SymbolTable.h:
(JSC::SymbolTable::createStructure):
- runtime/WeakMapData.h:
(JSC::WeakMapData::createStructure):
- 4:14 PM Changeset in webkit [170128] by
-
- 2 edits in trunk/Source/WebCore
[iOS WebGL] Fixed WEBGL_compressed_texture_pvrtc.
https://bugs.webkit.org/show_bug.cgi?id=133561
Based on Blink r153971 by bajones@chromium.org.
Reviewed by Dean Jackson.
No new tests, but this should fix webgl-compressed-texture-pvrtc.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContext::validateCompressedTexSubDimensions):
Added checks for pvrtc.
- 4:13 PM Changeset in webkit [170127] by
-
- 3 edits in tags/Safari-538.41/Source/WebKit2
Merged r170126.
- 4:04 PM Changeset in webkit [170126] by
-
- 3 edits in trunk/Source/WebKit2
Add back WKPageRunJavaScriptInMainFrame_b for now
https://bugs.webkit.org/show_bug.cgi?id=134045
<rdar://problem/17368879>
Reviewed by Tim Horton.
Reverted changeset:
"Remove WKPageRunJavaScriptInMainFrame_b"
https://bugs.webkit.org/show_bug.cgi?id=133926
http://trac.webkit.org/changeset/169991
- 3:57 PM Changeset in webkit [170125] by
-
- 4 edits in trunk/Source/WebKit/win
Remove IWebFramePrivate::loadType
https://bugs.webkit.org/show_bug.cgi?id=134044
Reviewed by Tim Horton.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
(WebFrame::loadType): Deleted.
(WebFrame::unused2): Deleted.
- WebFrame.h:
- 3:32 PM Changeset in webkit [170124] by
-
- 2 edits in trunk/Source/WebCore
Work around a Windows compiler crash.
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createFromSelection):
- 3:32 PM Changeset in webkit [170123] by
-
- 2 edits in trunk/Source/WebKit2
Simplify WebPageProxy::saveRecentSearches and WebPageProxy::loadRecentSearches
https://bugs.webkit.org/show_bug.cgi?id=134041
Reviewed by Andreas Kling.
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
- 3:19 PM Changeset in webkit [170122] by
-
- 2 edits in trunk/Tools
All of MiniBrowser's WKWebViews should share a configuration
https://bugs.webkit.org/show_bug.cgi?id=134017
Reviewed by Anders Carlsson.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
Share a single WKWebViewConfiguration between all of MiniBrowser's views.
This means that they'll share things like preferences, visited links, etc.
It also means that we'll properly share processes once we hit the process limit.
- 3:10 PM Changeset in webkit [170121] by
-
- 3 edits6 adds in trunk
Subtrees with :first-child and :last-child are not invalidated when siblings are added/removed
https://bugs.webkit.org/show_bug.cgi?id=133934
Reviewed by Antti Koivisto.
Source/WebCore:
When adding/removing nodes on an element, we try to invalidate only the elements that are
affected. In the case of :first-child and :last-child, that optimizations is implemented
through two types of flags that are updated during style resolution.
The first flag is childrenAffectedByFirstChildRules (childrenAffectedByLastChildRules),
set on the parent of any element that could be affected by :first-child (:last-child).
The other part of the optimization is marking the style itself with firstChildState (lastChildState)
to further reduce invalidations.
The problem in this case happen with a subtree of element is detached. Since there is no renderer,
the computed style is resolved ad-hoc and stored directly on the element. When the element is moved,
the computed style was never cleared because the invalidation optimizations were not handling
elements without style.
Credit to Yusuke Suzuki for discovering the issue and creating test cases.
Tests: fast/css/getComputedStyle/empty-update-without-renderer.html
fast/css/getComputedStyle/first-child-update-without-renderer.html
fast/css/getComputedStyle/last-child-update-without-renderer.html
- dom/Element.cpp:
(WebCore::checkForEmptyStyleChange):
Clean up: pull the style directly from the function instead of expection the call sites to do that.
Refine the checks to avoid invalidation.
(WebCore::checkForSiblingStyleChanges):
Do not early return if the parent is detached, the children may still need invalidation.
When there is no renderer, assume the worst first-child/last-child and force the invalidation.
(WebCore::Element::childrenChanged):
LayoutTests:
- fast/css/getComputedStyle/empty-update-without-renderer-expected.txt: Added.
- fast/css/getComputedStyle/empty-update-without-renderer.html: Added.
- fast/css/getComputedStyle/first-child-update-without-renderer-expected.txt: Added.
- fast/css/getComputedStyle/first-child-update-without-renderer.html: Added.
- fast/css/getComputedStyle/last-child-update-without-renderer-expected.txt: Added.
- fast/css/getComputedStyle/last-child-update-without-renderer.html: Added.
- 2:52 PM Changeset in webkit [170120] by
-
- 7 edits10 adds in trunk
REGRESSION (r167856): Unable to log into HSBC app
https://bugs.webkit.org/show_bug.cgi?id=133991
<rdar://problem/17044839>
Reviewed by David Kilzer.
Source/WebCore:
Following <http://trac.webkit.org/changeset/167856> we disallow "navigation to any URL that is
invalid, except for JavaScript URLs, which need not be valid." A byproduct of this policy
decision is that we no longer notify the WebKit client to about a navigation if the destination
URL is invalid. And some apps, including the HSBC app for iOS, have logic to intercept URLs
as a means to pass data from their WebView-embedded web app to the WebView. We should expose a
setting called allowNavigationToInvalidURL (disabled by default on all ports and conditionally
enabled on iOS) to toggle whether WebCore allows navigation to any URL, even if its invalid,
so as to not break clients that intercept URLs and have custom logic to handle them.
Tests: fast/loader/allow-redirect-to-invalid-url-using-javascript.html
fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html
fast/loader/disallow-redirect-to-invalid-url-using-javascript.html
fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::shouldScheduleNavigation): Modified to only validate
the URL when the setting allowNavigationToInvalidURL is disabled.
- page/Settings.in: Added setting allowNavigationToInvalidURL (disabled by default).
Source/WebKit/mac:
Only enable the setting allowNavigationToInvalidURL for iOS app linked against WebKit/UIKit before iOS 8.
- Misc/WebKitVersionChecks.h: Added macro constant WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Enable or disable the setting allowNavigationToInvalidURL as appropriate.
LayoutTests:
Add tests to ensure that the WebKit client will be notified to service a redirect to an invalid
URL when the setting allowNavigationToInvalidURL is enabled and will not be notified when
the setting is disabled.
- fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Added.
- fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Added.
- fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Added.
- fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Added.
- fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt: Added.
- fast/loader/disallow-redirect-to-invalid-url-using-javascript.html: Added.
- fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Added.
- fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html: Added.
- fast/loader/resources/redirect-to-invalid-url-using-javascript.html: Added.
- fast/loader/resources/redirect-to-invalid-url-using-meta-refresh.html: Added.
- 2:50 PM Changeset in webkit [170119] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix after r170107.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMod):
Use non-template sub for armv7s.
- 2:43 PM Changeset in webkit [170118] by
-
- 17 edits in trunk/Source
Make ScrollingStateNodes refcounted, and other minor cleanup
https://bugs.webkit.org/show_bug.cgi?id=134040
Reviewed by Beth Dakin.
Source/WebCore:
Prepare for future scrolling frame gyrations by making
ScrollingStateNodes refcounted.
Rename ScrollingStateNode::removeChild() to removeDescendant()
since that's what it does. Also rename didRemoveNode() to willRemoveNode()
to better match the behavior.
Use 'auto' in more places.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::syncChildPositions):
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::create):
(WebCore::ScrollingStateFixedNode::clone):
- page/scrolling/ScrollingStateFixedNode.h:
- page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::create):
(WebCore::ScrollingStateFrameScrollingNode::clone):
- page/scrolling/ScrollingStateFrameScrollingNode.h:
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::cloneAndReset):
(WebCore::ScrollingStateNode::appendChild):
(WebCore::ScrollingStateNode::removeDescendant):
(WebCore::ScrollingStateNode::willBeRemovedFromStateTree):
(WebCore::ScrollingStateNode::removeChild): Deleted.
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::children):
- page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
(WebCore::ScrollingStateOverflowScrollingNode::create):
(WebCore::ScrollingStateOverflowScrollingNode::clone):
- page/scrolling/ScrollingStateOverflowScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::create):
(WebCore::ScrollingStateStickyNode::clone):
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::removeNode):
(WebCore::ScrollingStateTree::willRemoveNode):
(WebCore::ScrollingStateTree::didRemoveNode): Deleted.
- page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::setRootStateNode):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
Source/WebKit2:
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::encodeNodeAndDescendants):
- 2:41 PM Changeset in webkit [170117] by
-
- 2 edits in trunk/Source/JavaScriptCore
-[JSContext setName:] leaks NSString
<http://webkit.org/b/134038>
Reviewed by Joseph Pecoraro.
Fixes the following static analyzer warning:
JavaScriptCore/API/JSContext.mm:200:73: warning: Potential leak of an object
JSStringRef nameJS = name ? JSStringCreateWithCFString((CFStringRef)[name copy]) : nullptr;
- API/JSContext.mm:
(-[JSContext setName:]): Autorelease the copy of |name|.
- 2:40 PM Changeset in webkit [170116] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Do not add padding when magnifying replaced elements
https://bugs.webkit.org/show_bug.cgi?id=134019
Reviewed by Tim Horton.
Having margins for regular blocks make sense to improve readability. For replaced elements,
we should follow iOS's UI and display edge to edge.
- UIProcess/ios/SmartMagnificationController.mm:
(WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):
- 2:38 PM Changeset in webkit [170115] by
-
- 7 edits in trunk/Source/WebKit2
[iOS][WK2] Re-sync didCommitLoadForMainFrame with its corresponding tile update
https://bugs.webkit.org/show_bug.cgi?id=134009
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-18
Reviewed by Tim Horton.
WKWebView assumed the first _didCommitLayerTree: after _didCommitLoadForMainFrame
had the state of the page being loaded.
This is not always true. Sometimes, a set of tiles can be rendering asynchronously while the next
page is loaded, and does not flush the queue until after didCommitLoadForMainFrame is executed.
Tim introduced a transactionID with each layer tree update. This patch uses that to synchronize
WKWebView with the right set of tiles.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView _updateVisibleContentRects]):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
(WebKit::RemoteLayerTreeDrawingAreaProxy::nextLayerTreeTransactionID):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::willCommitLayerTree):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
- 1:56 PM Changeset in webkit [170114] by
-
- 5 edits in trunk/Source/WebKit2
Simplify WebCredential
https://bugs.webkit.org/show_bug.cgi?id=134036
Reviewed by Andreas Kling.
- UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreate):
(WKCredentialCreateWithCertificateInfo):
(WKCredentialCopyUser):
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):
- UIProcess/Authentication/WebCredential.cpp:
(WebKit::WebCredential::credential):
(WebKit::WebCredential::core): Deleted.
(WebKit::WebCredential::user): Deleted.
- UIProcess/Authentication/WebCredential.h:
(WebKit::WebCredential::create): Deleted.
- 12:40 PM Changeset in webkit [170113] by
-
- 18 edits in trunk/Source
Adopt modern C++11 loops and fix WebArchive creation functions
https://bugs.webkit.org/show_bug.cgi?id=134032
Reviewed by Andreas Kling.
Source/WebCore:
Use modern loops in a couple of places, fix DocumentLoader::subresources() to return a Vector,
and stop using Vectors of PassRefPtrs.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::textInserted):
(WebCore::Document::textRemoved):
(WebCore::Document::textNodesMerged):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::subresources):
(WebCore::DocumentLoader::getSubresources): Deleted.
- loader/DocumentLoader.h:
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::dump):
- loader/appcache/ApplicationCache.h:
(WebCore::ApplicationCache::resources):
(WebCore::ApplicationCache::begin): Deleted.
(WebCore::ApplicationCache::end): Deleted.
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::fillResourceList):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::empty):
(WebCore::ApplicationCacheStorage::storeCopyOfCache):
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):
- loader/archive/cf/LegacyWebArchive.h:
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
Source/WebKit/mac:
- WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
- WebView/WebDataSource.mm:
(-[WebDataSource subresources]):
Source/WebKit2:
- Shared/APIWebArchive.cpp:
(API::WebArchive::WebArchive):
- 12:19 PM Changeset in webkit [170112] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION: Style declaration editor: placeholder misaligned
https://bugs.webkit.org/show_bug.cgi?id=134012
Reviewed by Timothy Hatcher.
Removed a rule needed to align the placeholder for selectors in
the style declation text editors with no rules declared in
http://trac.webkit.org/changeset/170077. The necessary
rule has been added back to fix the issue.
- UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .CodeMirror-placeholder):
- 12:19 PM Changeset in webkit [170111] by
-
- 2 edits in trunk/Source/WebKit2
Give WKWebView on iOS a mobile user agent
https://bugs.webkit.org/show_bug.cgi?id=134034
<rdar://problem/17346489>
Reviewed by Enrica Casucci.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- 12:14 PM Changeset in webkit [170110] by
-
- 2 edits in trunk/Source/WebKit2
Remove stale include, header was removed in r170101.
Unreviewed build fix.
- Shared/API/Cocoa/WebKitPrivate.h:
- 11:57 AM Changeset in webkit [170109] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFGGraph::m_doubleConstantMap will not map 0 values correctly.
<https://webkit.org/b/133994>
Reviewed by Geoffrey Garen.
DFGGraph::m_doubleConstantsMap should not use a double as a key to its HashMap,
because it means two unfortunate things:
- It will probably break for zero.
- It will think that -0 is the same as +0 under some circumstances, size -0==+0 even though they are distinct values (for example 1/-0 != 1/+0).
The fix is to use std::unordered_map which does not require special empty
and deleted values, and to use the raw bits instead of the double value as
the key.
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::addressOfDoubleConstant):
- 11:03 AM Changeset in webkit [170108] by
-
- 4 edits1 add in trunk/Source
Add CF type cast function templates and use them in KeyedDecoder in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=134033
Reviewed by Sam Weinig.
Source/WebKit2:
- Shared/cf/KeyedDecoder.cpp:
(WebKit::KeyedDecoder::KeyedDecoder):
(WebKit::KeyedDecoder::decodeBytes):
(WebKit::KeyedDecoder::decodeBool):
(WebKit::KeyedDecoder::decodeInt32):
(WebKit::KeyedDecoder::decodeInt64):
(WebKit::KeyedDecoder::decodeFloat):
(WebKit::KeyedDecoder::decodeDouble):
(WebKit::KeyedDecoder::decodeString):
(WebKit::KeyedDecoder::beginObject):
(WebKit::KeyedDecoder::beginArray):
(WebKit::KeyedDecoder::beginArrayElement):
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/cf/TypeCasts.h: Added.
(WTF::dynamic_cf_cast):
Returns null if the given CFTypeRef object doesn't have the right type.
(WTF::checked_cf_cast):
ASSERTs (with security implication) if the given CFTypeRef object is null or doesn't have the right type.
- 10:58 AM Changeset in webkit [170107] by
-
- 5 edits in trunk/Source
Remove duplicate code using sdiv.
https://bugs.webkit.org/show_bug.cgi?id=133764
Reviewed by Daniel Bates.
Source/JavaScriptCore:
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::sdiv):
Make sdiv a template to match arm64.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):
Remove duplicate code that was identical except for sdiv not being a template.
Source/WebCore:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Use template sdiv for apple armv7s and arm64.
- 10:53 AM Changeset in webkit [170106] by
-
- 12 edits in trunk/Source/WebCore
ScriptExecutionContext::Task parameters should always be rvalue references
https://bugs.webkit.org/show_bug.cgi?id=133615
Reviewed by Darin Adler.
ScriptExecutionContext::Task parameters should be rvalue references as the
passed-in objects are always ScriptExecutionContext::Task rvalues that were
implicitly constructed from a lambda function or rvalues of objects that
derive from ScriptExecutionContext::Task.
This isn't really necessary since ScriptExecutionContext::Task is non-copyable
and we have to use move semantics anyway, but it makes it clear that these
objects are expiring rvalues that must be properly dealt with.
- dom/Document.cpp:
(WebCore::Document::postTask):
- dom/Document.h:
- dom/ScriptExecutionContext.h:
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::postTask):
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- 10:48 AM Changeset in webkit [170105] by
-
- 2 edits in trunk/Tools
[GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
https://bugs.webkit.org/show_bug.cgi?id=133971
Reviewed by Martin Robinson.
- gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for
building for the Wayland target. The latest 3.12 version is required to match
the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
as well due to GTK+ depending on a newer version.
- 10:21 AM Changeset in webkit [170104] by
-
- 4 edits in tags/Safari-538.41/Source/WebKit2
Merged r170100.
- 10:20 AM Changeset in webkit [170103] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Compile errors when trying to compile CA code.
https://bugs.webkit.org/show_bug.cgi?id=134030
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-06-18
Reviewed by Simon Fraser.
WinCairo does not USE(CA).
- WebCore.vcxproj/WebCore.vcxproj:
- platform/graphics/ca/TileController.h:
- 10:08 AM Changeset in webkit [170102] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, rolling out r170099.
https://bugs.webkit.org/show_bug.cgi?id=134031
Introduced a layouttest failure to the mac bots (Requested by
bradeeoh on #webkit).
Reverted changeset:
"Mark mathml/wbr-in-mroot-crash.html as "Timeout Pass""
https://bugs.webkit.org/show_bug.cgi?id=130353
http://trac.webkit.org/changeset/170099
- 10:02 AM Changeset in webkit [170101] by
-
- 6 edits1 delete in trunk/Source/WebKit2
Remove the unused _WKBackForwardListDidChangeNotification.
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKBackForwardList.mm:
- UIProcess/API/Cocoa/WKBackForwardListInternal.h:
- UIProcess/API/Cocoa/WKBackForwardListPrivate.h: Removed.
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::didChangeBackForwardList): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 8:09 AM Changeset in webkit [170100] by
-
- 4 edits in trunk/Source/WebKit2
Set main thread QoS policies after IPC initialization.
<https://webkit.org/b/134014>
Something was flipping the QoS level back to "unspecified" after
setting it in the ChildProcess initialization code. Pending a better
understanding of what really happens, move the code to a later stage,
after IPC channels are up and running. Now the priority sticks.
Reviewed by Anders Carlsson.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::initialize):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 6:03 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:45 AM Changeset in webkit [170099] by
-
- 3 edits in trunk/LayoutTests
Mark mathml/wbr-in-mroot-crash.html as "Timeout Pass"
https://bugs.webkit.org/show_bug.cgi?id=130353
Unreviewed gardening.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
Jun 17, 2014:
- 11:54 PM Changeset in webkit [170098] by
-
- 5 edits in trunk/Source
Versioning.
- 11:52 PM Changeset in webkit [170097] by
-
- 1 copy in tags/Safari-538.41
New Tag.
- 11:21 PM Changeset in webkit [170096] by
-
- 2 edits in trunk/Tools
[EFL] Turn on NOSNIFF in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=134010
Reviewed by Csaba Osztrogonác.
r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.
- Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.
- 11:19 PM Changeset in webkit [170095] by
-
- 2 edits in trunk/Tools
MiniBrowser should show Web Content process pids in the window title
https://bugs.webkit.org/show_bug.cgi?id=134016
Reviewed by Sam Weinig.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
- 9:27 PM Changeset in webkit [170094] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] WKWebView's _privateBrowsingEnabled property is unused
https://bugs.webkit.org/show_bug.cgi?id=134013
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _privateBrowsingEnabled]): Deleted.
(-[WKWebView _setPrivateBrowsingEnabled:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 7:48 PM Changeset in webkit [170093] by
-
- 2 edits in trunk/LayoutTests
Fix 'lint-test-files' warnings on run-webkit-test -2
https://bugs.webkit.org/show_bug.cgi?id=134011
Unreviewed.
Remove entries referring to non-existing files from TestExpectations.
- platform/mac-wk2/TestExpectations:
- 7:30 PM Changeset in webkit [170092] by
-
- 17 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] PutStructure and PhantomPutStructure shouldn't leave the world in a clobbered state
https://bugs.webkit.org/show_bug.cgi?id=134002
Reviewed by Mark Hahnenberg.
The effect of this bug was that if we had a PutStructure or PhantomPutStructure then any
JSConstants would be in a Clobbered state, so we wouldn't take advantage of our knowledge
of the structure if that structure was watchable.
Also kill PhantomPutStructure.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::observeTransition):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::observeTransitions):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::visitChildren):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasTransition):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureAbstractValue.cpp:
(JSC::DFG::StructureAbstractValue::observeTransition):
(JSC::DFG::StructureAbstractValue::observeTransitions):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
- dfg/DFGWatchableStructureWatchingPhase.cpp:
(JSC::DFG::WatchableStructureWatchingPhase::run):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure): Deleted.
- 6:35 PM Changeset in webkit [170091] by
-
- 9 edits in trunk/Source
[iOS][wk2] Use ImageDocument to display subframe PDFs
https://bugs.webkit.org/show_bug.cgi?id=133944
<rdar://problem/17205983>
Reviewed by Dan Bates.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
Make a ImageDocument to show our subframe PDF, if the setting is enabled.
- html/ImageDocument.cpp:
(WebCore::ImageDocument::finishedParsing):
(WebCore::ImageDocument::createDocumentStructure):
Set the ResourceResponse on the ImageElement upon creation, instead of
when the load finishes. This way, when the internal CachedImage creates
its Image, it can have the correct MIME type for the response, and can
make a PDFDocumentImage if necessary.
We never noticed this before because CachedImage falls back to making a
BitmapImage, and that was the only case that was normally used.
Throw an explicit white background behind PDF ImageDocuments; PDFDocumentImage
paints with a transparent background, but when used as an ImageDocument
it seems reasonable to assume that there should be a white page background
(similar to what PDFPlugin and friends do).
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::createDocument):
Don't make a PDFDocument if we want to use an ImageDocument for this subframe PDF.
- page/Settings.in:
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::isPDFMIMEType):
- platform/MIMETypeRegistry.h:
Expose the already implemented pdfMIMETypes table just like all the rest.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Always use ImageDocument for subframe PDFs in WebKit2 on iOS.
- 6:16 PM Changeset in webkit [170090] by
-
- 12 edits6 adds in branches/ftlopt
[ftlopt] DFG put_by_id should inline accesses with a slightly polymorphic base
https://bugs.webkit.org/show_bug.cgi?id=133964
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::appendVariant):
(JSC::PutByIdStatus::computeForStubInfo):
- bytecode/PutByIdVariant.cpp:
(JSC::PutByIdVariant::oldStructureForTransition):
(JSC::PutByIdVariant::writesStructures):
(JSC::PutByIdVariant::reallocatesStorage):
(JSC::PutByIdVariant::attemptToMerge):
(JSC::PutByIdVariant::attemptToMergeTransitionWithReplace):
(JSC::PutByIdVariant::dumpInContext):
- bytecode/PutByIdVariant.h:
(JSC::PutByIdVariant::PutByIdVariant):
(JSC::PutByIdVariant::replace):
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::structure):
(JSC::PutByIdVariant::oldStructure):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::visitChildren):
- dfg/DFGNode.cpp:
(JSC::DFG::MultiPutByOffsetData::writesStructures):
(JSC::DFG::MultiPutByOffsetData::reallocatesStorage):
- ftl/FTLAbbreviations.h:
(JSC::FTL::getLinkage):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol):
LayoutTests:
- js/regress/put-by-id-replace-and-transition-expected.txt: Added.
- js/regress/put-by-id-replace-and-transition.html: Added.
- js/regress/put-by-id-slightly-polymorphic-expected.txt: Added.
- js/regress/put-by-id-slightly-polymorphic.html: Added.
- js/regress/script-tests/put-by-id-replace-and-transition.js: Added.
- js/regress/script-tests/put-by-id-slightly-polymorphic.js: Added.
- 5:32 PM Changeset in webkit [170089] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix with ENABLE_NOSNIFF after r170021
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::mimeTypeAllowedByNosniff):
- 5:28 PM Changeset in webkit [170088] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: PrettyPrinting regression on "var a=1"
https://bugs.webkit.org/show_bug.cgi?id=134001
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-17
Reviewed by Timothy Hatcher.
Previously operators did not get a token type. After a CodeMirror
update they now have a token type of "operator".
- Tools/PrettyPrinting/CodeMirrorFormatters.js:
- UserInterface/Views/CodeMirrorFormatters.js:
- 5:17 PM Changeset in webkit [170087] by
-
- 2 edits1 add in trunk/Source/WebKit2
Make it possible to use -[NSBundle classNamed:] to find WebKitLegacy classes
https://bugs.webkit.org/show_bug.cgi?id=134008
<rdar://problem/17037600>
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/LegacyBundleForClass.mm: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 5:02 PM Changeset in webkit [170086] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r170082.
https://bugs.webkit.org/show_bug.cgi?id=134006
Breaks build. (Requested by mlam on #webkit).
Reverted changeset:
"DFGGraph::m_doubleConstantMap will not map 0 values
correctly."
https://bugs.webkit.org/show_bug.cgi?id=133994
http://trac.webkit.org/changeset/170082
- 5:02 PM Changeset in webkit [170085] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Added Jono Wells <jonowells@apple.com> to contributors.json file.
- Scripts/webkitpy/common/config/contributors.json:
- 4:36 PM Changeset in webkit [170084] by
-
- 5 edits in trunk/Source/WebKit2
Expose the location of website data
https://bugs.webkit.org/show_bug.cgi?id=134000
<rdar://problem/17350498>
Reviewed by Dan Bernstein.
Also, remove the bundle ID from the website data path for containerized apps.
- Shared/mac/SandboxUtilities.cpp:
(WebKit::processIsAppSandboxed):
- Shared/mac/SandboxUtilities.h:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(+[WKProcessPool _websiteDataURLForContainerWithURL:]):
(websiteDataDirectoryURL):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- 4:33 PM Changeset in webkit [170083] by
-
- 12 edits in trunk/Source
Improve enter and exit fullscreen transition by using two step transition.
https://bugs.webkit.org/show_bug.cgi?id=133706
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-17
Reviewed by Simon Fraser.
Source/WebCore:
setupFullscreen, creates the fullscreen views ready to receive the video layer.
Once they are in place, didSetupFullscreen will move the video layer into the
new view hierarchy and initiate enterFullscreen to animate.
Reverse process for exit fullscreen.
- WebCore.exp.in: Add exports.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController enterFullscreen:]):
Refactor into didSetupFullscreen.
(-[WebVideoFullscreenController didSetupFullscreen]):
Move the video layer once fullscreen is ready to receive it.
(-[WebVideoFullscreenController didExitFullscreen]):
Move the video layer back into we the web page, and initiate cleanup.
(-[WebVideoFullscreenController didCleanupFullscreen]):
Refactord cleanup from didExitFullscreen.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h: Add delcarations.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
Refactored from enterFullscreen. Builds views ready to receive video layer.
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
Animates into fullscreen.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
Animates from fullscreen. Cleanup is refactored into cleanupFullscreen()
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreen):
Refactored from exitFullscreen(), removes views.
Source/WebKit2:
Add setupFullscreen()/didSetupFullscreen() and cleanupFullscreen()/didCleanupFullscreen()
to the proxies. And refactor enter/exit fullscreen to do some of the work in setup/cleanup.
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
Add four methods mentioned above.
- UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:
Add Setup/Cleanup functions.
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): does what enterFullscreen used to do.
(WebKit::WebVideoFullscreenManagerProxy::didCleanupFullscreen): forward IPC.
(WebKit::WebVideoFullscreenManagerProxy::didSetupFullscreen): forward IPC.
(WebKit::WebVideoFullscreenManagerProxy::enterFullscreenWithID): changed to enterFullscreen
- WebProcess/ios/WebVideoFullscreenManager.h: Add didSetup/didCleanup
- WebProcess/ios/WebVideoFullscreenManager.messages.in: Add didSetup/didCleanup
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::enterFullscreenForNode): refactored,
some implementation moves to didSetupFullscreen.
(WebKit::WebVideoFullscreenManager::didSetupFullscreen):
Moves the video layer over to the hosted layer, and initiates fullscreen.
(WebKit::WebVideoFullscreenManager::didExitFullscreen): refactored,
some implementation moves to didCleanupFullscreen, and initiates cleanup.
(WebKit::WebVideoFullscreenManager::didCleanupFullscreen):
Final cleanup refactored from didExitFullscreen()
- 4:05 PM Changeset in webkit [170082] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFGGraph::m_doubleConstantMap will not map 0 values correctly.
<https://webkit.org/b/133994>
Reviewed by Geoffrey Garen.
DFGGraph::m_doubleConstantsMap should not use a double as a key to its HashMap,
because it means two unfortunate things:
- It will probably break for zero.
- It will think that -0 is the same as +0 under some circumstances, size -0==+0 even though they are distinct values (for example 1/-0 != 1/+0).
The fix is to use std::unordered_map which does not require special empty
and deleted values, and to use the raw bits instead of the double value as
the key.
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::addressOfDoubleConstant):
- 3:35 PM Changeset in webkit [170081] by
-
- 2 edits in trunk/Source/WTF
Misused PLATFORM(MIDDLE_ENDIAN) and PLATFORM(BIG_ENDIAN).
https://bugs.webkit.org/show_bug.cgi?id=128301
Reviewed by Daniel Bates.
Endianness is a CPU attribute, not a PLATFORM. PLATFORM() macro is replaced to CPU().
- wtf/text/ASCIIFastPath.h:
(WTF::copyLCharsFromUCharSource):
- 3:35 PM Changeset in webkit [170080] by
-
- 21 edits in trunk/Source/WebInspectorUI
Web Inspector: Two lines in CSS rule are hidden until resize or click
https://bugs.webkit.org/show_bug.cgi?id=133951
Reviewed by Joseph Pecoraro.
Update to CodeMirror 4.2 fixed the issue.
- Tools/PrettyPrinting/codemirror.js:
- Tools/PrettyPrinting/css.js:
- Tools/PrettyPrinting/javascript.js:
- UserInterface/External/CodeMirror/clojure.js:
- UserInterface/External/CodeMirror/closebrackets.js:
- UserInterface/External/CodeMirror/codemirror.js:
- UserInterface/External/CodeMirror/coffeescript.js:
- UserInterface/External/CodeMirror/comment.js:
- UserInterface/External/CodeMirror/css.js:
- UserInterface/External/CodeMirror/htmlmixed.js:
- UserInterface/External/CodeMirror/javascript.js:
- UserInterface/External/CodeMirror/livescript.js:
- UserInterface/External/CodeMirror/matchbrackets.js:
- UserInterface/External/CodeMirror/overlay.js:
- UserInterface/External/CodeMirror/placeholder.js:
- UserInterface/External/CodeMirror/runmode.js:
- UserInterface/External/CodeMirror/sass.js:
- UserInterface/External/CodeMirror/searchcursor.js:
- UserInterface/External/CodeMirror/sql.js:
- UserInterface/External/CodeMirror/xml.js:
Update CodeMirror 4.1 to CodeMirror 4.2.0.
- 3:29 PM Changeset in webkit [170079] by
-
- 8 edits3 adds in trunk
Fix error messages for incorrect hex literals
https://bugs.webkit.org/show_bug.cgi?id=133998
Reviewed by Mark Lam.
Source/JavaScriptCore:
Ensure that the error messages for bogus hex literals actually
make sense.
- parser/Lexer.cpp:
(JSC::Lexer<T>::lex):
- parser/ParserTokens.h:
LayoutTests:
Update tests for sane error messages.
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T2-expected.txt:
- 3:27 PM Changeset in webkit [170078] by
-
- 7 edits in trunk
[GTK] Fix the handling of resize events after r169505.
https://bugs.webkit.org/show_bug.cgi?id=133517
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-17
Reviewed by Martin Robinson.
Tools:
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
need at least 900x640 pixels to pass.
- Scripts/webkitpy/port/xvfbdriver_unittest.py:
(XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
(XvfbDriverTest.test_start_pixel_tests): Update resolution.
(XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
(XvfbDriverTest.test_start_next_worker): Update resolution.
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
be requested over the main widget instead of the window.
(WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
the Mac port.
(WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
(WTR::PlatformWebView::setWindowFrame): Set the size and position
of the Window and the web view.
LayoutTests:
- platform/gtk/TestExpectations: Remove the expectations for the
tests that now pass.
- platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:
Rebaseline results.
- 3:26 PM Changeset in webkit [170077] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: style declaration editor: visual highlight doesn't match actual selected text
https://bugs.webkit.org/show_bug.cgi?id=133965
Reviewed by Joseph Pecoraro.
Update styles for css style editor to fix highlighting visual mismatch glitch.
- UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .CodeMirror-placeholder):
(.css-style-text-editor > .CodeMirror pre):
(.css-style-text-editor.read-only > .CodeMirror pre):
Updated styles to eliminate highlight mismatch by adjusting the padding and
text-indent values.
- 3:17 PM Changeset in webkit [170076] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fixes bug where building JSC sometimes crashes at build-symbol-table-index.py. Also adds licenses.
https://bugs.webkit.org/show_bug.cgi?id=133814
Reviewed by Filip Pizlo.
Adds the "shopt -s nullglob" line necessary to prevent the loop in the shell
script from using "*.o" as a file when no other files in the directory exist.
- build-symbol-table-index.sh: Added license.
- copy-llvm-ir-to-derived-sources.sh: Added license and "shopt -s nullglob" line.
- 3:05 PM Changeset in webkit [170075] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] enable background audio in WK2
https://bugs.webkit.org/show_bug.cgi?id=133996
Reviewed by Jer Noble.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist: Mark as
allowed to play audio when in the background.
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Ditto.
- 2:50 PM Changeset in webkit [170074] by
-
- 19 edits in trunk/Source/WebCore
Remove unnecessary Structure flags from generated bindings
https://bugs.webkit.org/show_bug.cgi?id=133992
Reviewed by Daniel Bates.
- Remove OverridesVisitChildren flag from DOM prototype objects. They never implement visitChildren.
- Remove OverridesGetOwnPropertySlot and ImplementsHasInstance from DOM constructor objects. getOwnPropertySlot is never implemented and ImplementsHasInstance is inherited automatically from DOMConstructorObject.
- If we are not changing any flags, we now don't emit StructureFlags at all for the class.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GeneratePrototypeDeclaration):
(GenerateConstructorDeclaration):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::JSTestActiveDOMObjectPrototype::JSTestActiveDOMObjectPrototype):
(WebCore::JSTestActiveDOMObjectConstructor::createStructure):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTargetPrototype::JSTestEventTargetPrototype):
(WebCore::JSTestEventTargetConstructor::createStructure):
- bindings/scripts/test/JS/JSTestException.h:
(WebCore::JSTestExceptionPrototype::JSTestExceptionPrototype):
(WebCore::JSTestExceptionConstructor::createStructure):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
(WebCore::JSTestGenerateIsReachablePrototype::JSTestGenerateIsReachablePrototype):
(WebCore::JSTestGenerateIsReachableConstructor::createStructure):
- bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructorPrototype::JSTestNamedConstructorPrototype):
(WebCore::JSTestNamedConstructorConstructor::createStructure):
- bindings/scripts/test/JS/JSTestNode.h:
(WebCore::JSTestNodePrototype::JSTestNodePrototype):
- bindings/scripts/test/JS/JSTestNondeterministic.h:
(WebCore::JSTestNondeterministicPrototype::JSTestNondeterministicPrototype):
(WebCore::JSTestNondeterministicConstructor::createStructure):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::JSTestOverloadedConstructorsPrototype::JSTestOverloadedConstructorsPrototype):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::JSTestTypedefsPrototype::JSTestTypedefsPrototype):
- bindings/scripts/test/JS/JSattribute.h:
(WebCore::JSattributePrototype::JSattributePrototype):
(WebCore::JSattributeConstructor::createStructure):
- bindings/scripts/test/JS/JSreadonly.h:
(WebCore::JSreadonlyPrototype::JSreadonlyPrototype):
(WebCore::JSreadonlyConstructor::createStructure):
- 2:48 PM Changeset in webkit [170073] by
-
- 2 edits in trunk/Tools
Unreviewed. Added self to list of committers.
- 2:28 PM Changeset in webkit [170072] by
-
- 17 edits2 adds in trunk
[iOS] Input type=time elements styled with SVG fonts have 0 width
https://bugs.webkit.org/show_bug.cgi?id=133524
Reviewed by Simon Fraser.
Source/WebCore:
Refactor how the LocalizedDateCache returns maximum widths for input elements. Currently,
measuring the width of an SVG font requires a RenderObject for context, which the
LocalizedDateCache can't know about (it would be a platform violation). Instead, the
LocalizedDateCache can return the strings that it would use to measure the width, and the
caller can actually run the width computation.
Test: fast/forms/time-input-svg-font.html
- platform/text/PlatformLocale.h:
- platform/text/ios/LocalizedDateCache.h:
- platform/text/ios/LocalizedDateCache.mm:
(WebCore::LocalizedDateCache::maximumWidthForDateType): Take a delegate which can
measure text
(WebCore::LocalizedDateCache::calculateMaximumWidth): Perform maximum width
computation using delegate.
- platform/text/mac/LocaleMac.h:
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::formatDateTime):
(WebCore::LocaleMac::maximumWidthForDateType): Deleted. Short-circuit this and go
directly to the LocalizedDateCache. This makes sense because we have to explicitly
insert computed values back into the cache in this new model.
- rendering/RenderThemeIOS.mm:
(WebCore::adjustInputElementButtonStyle): Create a delegate and pass it to the
LocalizedDateCache
LayoutTests:
Simply render a variety of input elements with SVG fonts, and make sure they have sane widths. Note that this
test is not platform-specific, even though the bug is.
- fast/forms/time-input-svg-font-expected.txt: Added.
- fast/forms/time-input-svg-font.html: Added.
- 2:06 PM Changeset in webkit [170071] by
-
- 24 edits2 adds in trunk
[UI-side compositing] fix reflections on composited layers
https://bugs.webkit.org/show_bug.cgi?id=133942
Reviewed by Tim Horton.
Source/WebCore:
Fix reflections on composited layers. There are two main set of changes.
First, a PlatformCALayerRemote which is a clone has to track the layer
it is a clone of, so it knows where to grab the contents from in the UI process.
This layer may be told that its contents need updating out of order during
recursiveBuildTransaction(), so we need some small changes in RemoteLayerTreeContext
to allow a layer to add itself to the set of layers requiring commit.
In the UI process, a new step is added to RemoteLayerTreeHost::updateLayerTree()
to go through clones, and copy their contents from the origin layer.
The second set of changes makes platformCALayerLayerDidDisplay() work for
UI-side compositing by not taking a PlatformLayer*, but instead a PlatformCALayer*.
PlatformCALayer::setContentsChanged() changed to copyContentsFromLayer() so we know
what the origin layer is.
Test: compositing/reflections/repaint-with-reflection.html
- WebCore.exp.in:
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::layerDidDisplay): Deleted.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::LayerClient::platformCALayerLayerDidDisplay): Deleted.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::layerDidDisplay):
(WebCore::GraphicsLayerCA::findOrMakeClone):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::platformCALayerLayerDidDisplay):
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::copyContentsFromLayer):
(PlatformCALayerMac::superlayer):
(PlatformCALayerMac::setContentsChanged): Deleted.
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback):
- platform/graphics/mac/WebLayer.mm:
(-[WebSimpleLayer display]):
Source/WebKit2:
Fix reflections on composited layers. There are two main set of changes.
First, a PlatformCALayerRemote which is a clone has to track the layer
it is a clone of, so it knows where to grab the contents from in the UI process.
This layer may be told that its contents need updating out of order during
recursiveBuildTransaction(), so we need some small changes in RemoteLayerTreeContext
to allow a layer to add itself to the set of layers requiring commit.
In the UI process, a new step is added to RemoteLayerTreeHost::updateLayerTree()
to go through clones, and copy their contents from the origin layer.
The second set of changes makes platformCALayerLayerDidDisplay() work for
UI-side compositing by not taking a PlatformLayer*, but instead a PlatformCALayer*.
PlatformCALayer::setContentsChanged() changed to copyContentsFromLayer() so we know
what the origin layer is.
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display): Remove the early return so we can always
call platformCALayerLayerDidDisplay().
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::clone):
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::copyContentsFromLayer):
(WebKit::PlatformCALayerRemote::setClonedLayer):
(WebKit::PlatformCALayerRemote::setContentsChanged): Deleted.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
(WebKit::PlatformCALayerRemote::properties):
(WebKit::PlatformCALayerRemote::context):
LayoutTests:
Test with a reflected div, that repaints on a timer to test backing
store updating on the clone.
- compositing/reflections/repaint-with-reflection-expected.html: Added.
- compositing/reflections/repaint-with-reflection.html: Added.
- 1:19 PM Changeset in webkit [170070] by
-
- 5 edits in trunk/Source/WebCore
Use strongly typed enums for AnimationState and AnimationInputState
https://bugs.webkit.org/show_bug.cgi?id=133988
Reviewed by Tim Horton.
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::AnimationBase):
(WebCore::nameForState):
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::updatePlayState):
(WebCore::AnimationBase::timeToNextService):
(WebCore::AnimationBase::goIntoEndingOrLoopingState):
(WebCore::AnimationBase::freezeAtTime):
(WebCore::AnimationBase::beginAnimationUpdateTime):
- page/animation/AnimationBase.h:
(WebCore::AnimationBase::clear):
(WebCore::AnimationBase::onAnimationStartResponse):
(WebCore::AnimationBase::waitingToStart):
(WebCore::AnimationBase::preActive):
(WebCore::AnimationBase::postActive):
(WebCore::AnimationBase::fillingForwards):
(WebCore::AnimationBase::paused):
(WebCore::AnimationBase::inPausedState):
(WebCore::AnimationBase::isNew):
(WebCore::AnimationBase::waitingForStartTime):
(WebCore::AnimationBase::waitingForStyleAvailable):
(WebCore::AnimationBase::isAnimatingProperty):
(WebCore::AnimationBase::styleAvailable):
(WebCore::AnimationBase::compositeAnimation):
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::onAnimationEnd):
(WebCore::ImplicitAnimation::sendTransitionEvent):
(WebCore::ImplicitAnimation::reset):
(WebCore::ImplicitAnimation::setOverridden):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::sendAnimationEvent):
- 1:17 PM Changeset in webkit [170069] by
-
- 3 edits in trunk/Source/WebKit2
Remove session state methods from WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=133995
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKBrowsingContextController.h:
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController sessionState]): Deleted.
(-[WKBrowsingContextController restoreFromSessionState:]): Deleted.
- 12:53 PM Changeset in webkit [170068] by
-
- 6 edits in trunk
Unreviewed, rolling out r170058.
https://bugs.webkit.org/show_bug.cgi?id=133993
Caused 4 webkitpy failures on the bots (Requested by bradee-oh
on #webkit).
Reverted changeset:
"[GTK] Fix the handling of resize events after r169505."
https://bugs.webkit.org/show_bug.cgi?id=133517
http://trac.webkit.org/changeset/170058
- 12:17 PM Changeset in webkit [170067] by
-
- 3 edits in trunk/Source/WebKit2
Only show telephone number highlights if only one number is selected
<rdar://problem/16874568> and https://bugs.webkit.org/show_bug.cgi?id=133989
Reviewed by Tim Horton.
Add a flag to TelephoneNumberData to remember if it was hovered over:
- WebProcess/WebPage/TelephoneNumberOverlayController.h:
(WebKit::TelephoneNumberData::hovered):
(WebKit::TelephoneNumberData::setHovered):
(WebKit::TelephoneNumberData::TelephoneNumberData):
- WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:
(WebKit::TelephoneNumberOverlayController::drawRect): Only draw the highlight if one
phone number is selected.
(WebKit::TelephoneNumberOverlayController::mouseEvent): Update the hover state of the
current phone number, and setNeedsDisplay if the hover state changes.
(WebKit::TelephoneNumberOverlayController::clearHighlights):
- 12:04 PM Changeset in webkit [170066] by
-
- 4 edits in trunk/Source/WebKit2
Remove WKContentView _setFindIndicator:fadeOut:animate:
https://bugs.webkit.org/show_bug.cgi?id=133976
Reviewed by Anders Carlsson.
Find indicators are totally internal to FindController on iOS,
we don't need to push them to the content view via PageClient,
so this code was unused.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::setFindIndicator):
- UIProcess/ios/WKContentView.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _setFindIndicator:WebKit::fadeOut:animate:]): Deleted.
- 12:03 PM Changeset in webkit [170065] by
-
- 7 edits in trunk/Source
Web process main thread priority is lower than some network process threads.
<https://webkit.org/b/133987>
<rdar://problem/17330300>
Source/WebKit2:
Mark the main thread as "user initiated" in process entry.
Reviewed by Maciej Stachowiak.
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::initialize):
Source/WTF:
Bring all of our threads to the appropriate priority level by opting in to the
threading QoS APIs. By marking them "user initiated", they still yield to UI
interaction, but take priority over background tasks.
Reviewed by Maciej Stachowiak.
- wtf/Platform.h:
- wtf/Threading.cpp:
(WTF::setCurrentThreadIsUserInitiated):
- wtf/Threading.h:
- wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal):
- 12:01 PM Changeset in webkit [170064] by
-
- 8 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Fold constant Phis
https://bugs.webkit.org/show_bug.cgi?id=133967
Reviewed by Mark Hahnenberg.
It's surprising but we didn't really do this before. Or, rather, we only did it
incidentally when we would likely crash if it ever happened.
Making this work required cleaning up the validater a bit, so I did that too. I also added
mayExit() validation for nodes that didn't have origin.forExit (i.e. nodes that end up in
the Phi header of basic blocks). But this required beefing up mayExit() a bit.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGAdjacencyList.h:
(JSC::DFG::AdjacencyList::isEmpty):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::fixUpsilons):
- dfg/DFGInPlaceAbstractState.h:
- dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run):
(JSC::DFG::LICMPhase::attemptHoist):
- dfg/DFGMayExit.cpp:
(JSC::DFG::mayExit):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::validateSSA):
- 12:00 PM Changeset in webkit [170063] by
-
- 2 edits in trunk/Source/WebCore
Avoid synchronous layout in window.scrollTo(0,0) when already at (0,0)
<https://webkit.org/b/133893>
Going from 0,0 to 0,0 is a no-op since there is no way a layout will
affect the current scroll position.
We don't send scroll events when moving to the previous position,
so this change is not observable.
Reviewed by Anders Carlsson.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollTo):
- 11:02 AM Changeset in webkit [170062] by
-
- 2 edits in trunk/Tools
Update import-w3c-tests to reflect current W3C test repo directory structure
https://bugs.webkit.org/show_bug.cgi?id=133460
Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-06-17
Reviewed by Bem Jones-Bey.
Removed all references to test status, which are no longer reflected in the
directory names in the W3C CSS test repo. No tests are required for this
change, the existing tests pass.
- Scripts/webkitpy/w3c/test_importer.py:
(main):
(TestImporter.init):
(TestImporter.find_importable_tests):
(TestImporter.setup_destination_directory):
(TestImporter.write_import_log):
(TestImporter.update_test_status): Deleted.
- 10:59 AM Changeset in webkit [170061] by
-
- 2 edits in trunk/Source/WTF
Enable css jit for armv7 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=133961
<rdar://problem/17310631>
Reviewed by Andreas Kling.
- wtf/Platform.h:
Enable css jit for ARM thumb on iOS.
- 10:52 AM Changeset in webkit [170060] by
-
- 19 edits2 adds in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Get rid of NodeDoesNotExit and also get rid of StoreEliminationPhase
https://bugs.webkit.org/show_bug.cgi?id=133985
Reviewed by Michael Saboff and Mark Hahnenberg.
Store elimination phase has never been very profitable, and now that LLVM can do dead
store elimination for us, this phase is just completely pointless.
This phase is also the primary user of NodeDoesNotExit, which is a flag that the CFA
computes. It computes it poorly and we often get bugs in it. It's also a lot of code to
maintain.
This patch does introduce a new mayExit() calculator that is independent of the CFA and
should be enough for most of the previous NodeDoesNotExit users. Currently it's only used
for assertions in the DFG backend, but we could use it if we ever brought back any of the
other optimizations that previously relied upon NodeDoesNotExit.
This is performance-neutral, except for SunSpider, where it's a speed-up.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractInterpreter.h:
(JSC::DFG::AbstractInterpreter::filterEdgeByUse):
(JSC::DFG::AbstractInterpreter::filterByType):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::startExecuting):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::invalidationPointElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(JSC::DFG::performCSE):
(JSC::DFG::CSEPhase::globalVarStoreElimination): Deleted.
(JSC::DFG::CSEPhase::scopedVarStoreElimination): Deleted.
(JSC::DFG::CSEPhase::putStructureStoreElimination): Deleted.
(JSC::DFG::CSEPhase::putByOffsetStoreElimination): Deleted.
(JSC::DFG::CSEPhase::SetLocalStoreEliminationResult::SetLocalStoreEliminationResult): Deleted.
(JSC::DFG::performStoreElimination): Deleted.
- dfg/DFGCSEPhase.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::resetExitStates): Deleted.
- dfg/DFGGraph.h:
- dfg/DFGMayExit.cpp: Added.
(JSC::DFG::mayExit):
- dfg/DFGMayExit.h: Added.
- dfg/DFGNode.h:
(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(JSC::DFG::Node::setCanExit): Deleted.
(JSC::DFG::Node::canExit): Deleted.
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
- dfg/DFGNodeFlags.h:
- dfg/DFGNodeType.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::bail):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 10:49 AM Changeset in webkit [170059] by
-
- 3 edits in trunk/Source/WebCore
Fix css jit register usage on armv7.
https://bugs.webkit.org/show_bug.cgi?id=133952
Reviewed by Benjamin Poulain.
- cssjit/RegisterAllocator.h:
List r7 as a callee saved register, which it is.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateEpilogue):
Save r6, which is used as a temporary register and must be preserved.
- 10:49 AM Changeset in webkit [170058] by
-
- 6 edits in trunk
[GTK] Fix the handling of resize events after r169505.
https://bugs.webkit.org/show_bug.cgi?id=133517
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-17
Reviewed by Martin Robinson.
Tools:
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
need at least 900x640 pixels to pass.
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
be requested over the main widget instead of the window.
(WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
the Mac port.
(WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
(WTR::PlatformWebView::setWindowFrame): Set the size and position
of the Window and the web view.
LayoutTests:
- platform/gtk/TestExpectations: Remove the expectations for the tests
that now pass.
- platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:
Rebaseline results.
- 10:29 AM Changeset in webkit [170057] by
-
- 5 edits in trunk/Source/WebCore
Use references instead of pointers to RenderBlock in enclosingBoxModelObject()
https://bugs.webkit.org/show_bug.cgi?id=133978
Patch by Miyoung Shin <myid.shin@samsung.com> on 2014-06-17
Reviewed by Andreas Kling.
Just a straightforward conversion from pointers to references.
No new tests, no behavior change.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingBoxModelObject):
- rendering/RenderObject.h:
- 10:23 AM Changeset in webkit [170056] by
-
- 5 edits in trunk/Source/WebKit2
Add SPI to get the NSURLRequest from a WKNavigationResponse
https://bugs.webkit.org/show_bug.cgi?id=133984
<rdar://problem/17006399>
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKNavigationResponse.mm:
(-[WKNavigationResponse _request]):
- UIProcess/API/Cocoa/WKNavigationResponseInternal.h:
- UIProcess/API/Cocoa/WKNavigationResponsePrivate.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):
- 9:16 AM Changeset in webkit [170055] by
-
- 5 edits in trunk
String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=133968
Reviewed by Anders Carlsson.
Source/WTF:
Made the rvalue reference overload of isolatedCopy() non-const, so that std::move(*this) is
an rvalue reference that can be moved, rather than copied, into the returned String.
- wtf/text/WTFString.cpp:
(WTF::String::isolatedCopy):
- wtf/text/WTFString.h:
Tools:
- TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
share an impl() with the original.
- 6:29 AM Changeset in webkit [170054] by
-
- 4 edits in trunk
[EFL][WK2] Skip failing EFL API tests
https://bugs.webkit.org/show_bug.cgi?id=133981
Reviewed by Csaba Osztrogonác.
UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
Source/WebKit2:
- PlatformEfl.cmake:
Tools:
- TestWebKitAPI/PlatformEfl.cmake:
- 4:31 AM Changeset in webkit [170053] by
-
- 2 edits in trunk/LayoutTests
[EFL] Add expectations for three failing/flaky layout tests.
https://bugs.webkit.org/show_bug.cgi?id=133977
Unreviewed EFL gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-06-17
- platform/efl/TestExpectations:
- 2:58 AM Changeset in webkit [170052] by
-
- 2 edits in trunk
Remove the USE_GTK2=1 branch in OptionsGTK.cmake. This used to determine
GTK+ and GDK libraries and include directories for the GTK+ 2 dependency,
but we now only support GTK+ 3. The GTK+ 2 dependency is still required
by the plugin process, but it is searched and utilized separately.
Rubber-stamped by Carlos Garcia Campos.
- Source/cmake/OptionsGTK.cmake:
- 12:49 AM Changeset in webkit [170051] by
-
- 2 edits in trunk/Source/WebCore
Cache the gst_query_get_n_buffering_ranges() return value for the for-loop conditional
https://bugs.webkit.org/show_bug.cgi?id=133953
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::buffered): Avoid the extra call in the for-loop
conditional expression by caching the return value of gst_query_get_n_buffering_ranges().
- 12:47 AM Changeset in webkit [170050] by
-
- 2 edits in trunk/Source/WebCore
Avoid Vector<char> copies in the OffsetBuffer constructor
https://bugs.webkit.org/show_bug.cgi?id=133956
Reviewed by Andreas Kling.
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::OffsetBuffer::OffsetBuffer): Take the Vector parameter by value and
move it into the member variable.
(WebCore::openFunc): Move the Vector object into the OffsetBuffer constructor.
- 12:43 AM Changeset in webkit [170049] by
-
- 3 edits2 adds in trunk
[MSE] Overwritten samples are removed from buffered ranges using decode times; added samples using presentation times
https://bugs.webkit.org/show_bug.cgi?id=133959
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-overlapping-append-buffered.html
Explicitly call presentationTime() on removed samples, rather than implicitly asking for the iterator's "first"
member. When iterating over samples, "first" can either be presentation time, or decode time, depending on which
iteration method is called. In the case of removing samples, this was using the decode time incorrectly.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
LayoutTests:
- media/media-source/media-source-overlapping-append-buffered-expected.txt: Added.
- media/media-source/media-source-overlapping-append-buffered.html: Added.
- 12:42 AM Changeset in webkit [170048] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for the GTK+ port. Removing the *Callback::create() wrappings
for lambda callbacks that aren't required anymore after the changes in r170041.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):
(webkit_web_view_save):
(webkit_web_view_save_to_file):
Jun 16, 2014:
- 10:45 PM Changeset in webkit [170047] by
-
- 5 edits76 moves1 add in trunk/LayoutTests
[CSS Regions] Move the overflow tests to a separate folder
https://bugs.webkit.org/show_bug.cgi?id=130089
Reviewed by Andrei Bucur.
Move the overflow tests inside fast/regions/overflow folder.
Adjust tests paths and TestExpectations files accordingly.
- fast/regions/overflow/overflow-3dtransformed-region-expected.txt: Renamed from LayoutTests/fast/regions/overflow-3dtransformed-region-expected.txt.
- fast/regions/overflow/overflow-3dtransformed-region.html: Renamed from LayoutTests/fast/regions/overflow-3dtransformed-region.html.
- fast/regions/overflow/overflow-auto-after-float-expected.html: Renamed from LayoutTests/fast/regions/overflow-auto-after-float-expected.html.
- fast/regions/overflow/overflow-auto-after-float.html: Renamed from LayoutTests/fast/regions/overflow-auto-after-float.html.
- fast/regions/overflow/overflow-content-transform-rotate-expected.html: Renamed from LayoutTests/fast/regions/overflow-content-transform-rotate-expected.html.
- fast/regions/overflow/overflow-content-transform-rotate.html: Renamed from LayoutTests/fast/regions/overflow-content-transform-rotate.html.
- fast/regions/overflow/overflow-content-zero-height-region-expected.html: Renamed from LayoutTests/fast/regions/overflow-content-zero-height-region-expected.html.
- fast/regions/overflow/overflow-content-zero-height-region.html: Renamed from LayoutTests/fast/regions/overflow-content-zero-height-region.html.
- fast/regions/overflow/overflow-first-and-last-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-first-and-last-regions-expected.html.
- fast/regions/overflow/overflow-first-and-last-regions-in-container-hidden-expected.html: Renamed from LayoutTests/fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html.
- fast/regions/overflow/overflow-first-and-last-regions-in-container-hidden.html: Renamed from LayoutTests/fast/regions/overflow-first-and-last-regions-in-container-hidden.html.
- fast/regions/overflow/overflow-first-and-last-regions.html: Renamed from LayoutTests/fast/regions/overflow-first-and-last-regions.html.
- fast/regions/overflow/overflow-in-uniform-regions-dynamic-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-uniform-regions-dynamic-expected.html.
- fast/regions/overflow/overflow-in-uniform-regions-dynamic.html: Renamed from LayoutTests/fast/regions/overflow-in-uniform-regions-dynamic.html.
- fast/regions/overflow/overflow-in-uniform-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-uniform-regions-expected.html.
- fast/regions/overflow/overflow-in-uniform-regions.html: Renamed from LayoutTests/fast/regions/overflow-in-uniform-regions.html.
- fast/regions/overflow/overflow-in-variable-width-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-expected.html.
- fast/regions/overflow/overflow-in-variable-width-regions-inline-bt-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-bt-expected.html.
- fast/regions/overflow/overflow-in-variable-width-regions-inline-bt.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-bt.html.
- fast/regions/overflow/overflow-in-variable-width-regions-inline-continuation-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-continuation-expected.html.
- fast/regions/overflow/overflow-in-variable-width-regions-inline-continuation.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-continuation.html.
- fast/regions/overflow/overflow-in-variable-width-regions-inline-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-expected.html.
- fast/regions/overflow/overflow-in-variable-width-regions-inline-lr-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-lr-expected.html.
- fast/regions/overflow/overflow-in-variable-width-regions-inline-lr.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-lr.html.
- fast/regions/overflow/overflow-in-variable-width-regions-inline-rl-expected.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-rl-expected.html.
- fast/regions/overflow/overflow-in-variable-width-regions-inline-rl.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline-rl.html.
- fast/regions/overflow/overflow-in-variable-width-regions-inline.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions-inline.html.
- fast/regions/overflow/overflow-in-variable-width-regions.html: Renamed from LayoutTests/fast/regions/overflow-in-variable-width-regions.html.
- fast/regions/overflow/overflow-last-region-horiz-bt-expected.html: Renamed from LayoutTests/fast/regions/overflow-last-region-horiz-bt-expected.html.
- fast/regions/overflow/overflow-last-region-horiz-bt.html: Renamed from LayoutTests/fast/regions/overflow-last-region-horiz-bt.html.
- fast/regions/overflow/overflow-last-region-vert-lr-expected.html: Renamed from LayoutTests/fast/regions/overflow-last-region-vert-lr-expected.html.
- fast/regions/overflow/overflow-last-region-vert-lr.html: Renamed from LayoutTests/fast/regions/overflow-last-region-vert-lr.html.
- fast/regions/overflow/overflow-last-region-vert-rl-expected.html: Renamed from LayoutTests/fast/regions/overflow-last-region-vert-rl-expected.html.
- fast/regions/overflow/overflow-last-region-vert-rl.html: Renamed from LayoutTests/fast/regions/overflow-last-region-vert-rl.html.
- fast/regions/overflow/overflow-moving-below-floats-in-variable-width-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.html.
- fast/regions/overflow/overflow-moving-below-floats-in-variable-width-regions.html: Renamed from LayoutTests/fast/regions/overflow-moving-below-floats-in-variable-width-regions.html.
- fast/regions/overflow/overflow-nested-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-nested-regions-expected.html.
- fast/regions/overflow/overflow-nested-regions.html: Renamed from LayoutTests/fast/regions/overflow-nested-regions.html.
- fast/regions/overflow/overflow-not-moving-below-floats-in-variable-width-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.html.
- fast/regions/overflow/overflow-not-moving-below-floats-in-variable-width-regions.html: Renamed from LayoutTests/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html.
- fast/regions/overflow/overflow-region-float-expected.html: Renamed from LayoutTests/fast/regions/overflow-region-float-expected.html.
- fast/regions/overflow/overflow-region-float.html: Renamed from LayoutTests/fast/regions/overflow-region-float.html.
- fast/regions/overflow/overflow-region-inline-expected.html: Renamed from LayoutTests/fast/regions/overflow-region-inline-expected.html.
- fast/regions/overflow/overflow-region-inline.html: Renamed from LayoutTests/fast/regions/overflow-region-inline.html.
- fast/regions/overflow/overflow-region-transform-expected.html: Renamed from LayoutTests/fast/regions/overflow-region-transform-expected.html.
- fast/regions/overflow/overflow-region-transform.html: Renamed from LayoutTests/fast/regions/overflow-region-transform.html.
- fast/regions/overflow/overflow-rtl-in-variable-width-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-rtl-in-variable-width-regions-expected.html.
- fast/regions/overflow/overflow-rtl-in-variable-width-regions.html: Renamed from LayoutTests/fast/regions/overflow-rtl-in-variable-width-regions.html.
- fast/regions/overflow/overflow-scrollable-1-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-1-expected.html.
- fast/regions/overflow/overflow-scrollable-1.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-1.html.
- fast/regions/overflow/overflow-scrollable-2-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-2-expected.html.
- fast/regions/overflow/overflow-scrollable-2.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-2.html.
- fast/regions/overflow/overflow-scrollable-3-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-3-expected.html.
- fast/regions/overflow/overflow-scrollable-3.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-3.html.
- fast/regions/overflow/overflow-scrollable-fit-complex-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-fit-complex-expected.html.
- fast/regions/overflow/overflow-scrollable-fit-complex.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-fit-complex.html.
- fast/regions/overflow/overflow-scrollable-fit-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-fit-expected.html.
- fast/regions/overflow/overflow-scrollable-fit.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-fit.html.
- fast/regions/overflow/overflow-scrollable-nested-expected.txt: Renamed from LayoutTests/fast/regions/overflow-scrollable-nested-expected.txt.
- fast/regions/overflow/overflow-scrollable-nested.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-nested.html.
- fast/regions/overflow/overflow-scrollable-rel-pos-fragment-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment-expected.html.
- fast/regions/overflow/overflow-scrollable-rel-pos-fragment.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-rel-pos-fragment.html.
- fast/regions/overflow/overflow-scrollable-rotated-fragment-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-rotated-fragment-expected.html.
- fast/regions/overflow/overflow-scrollable-rotated-fragment.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-rotated-fragment.html.
- fast/regions/overflow/overflow-scrollable-unsplittable-fragment-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment-expected.html.
- fast/regions/overflow/overflow-scrollable-unsplittable-fragment.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-unsplittable-fragment.html.
- fast/regions/overflow/overflow-scrollable-varying-width-1-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-varying-width-1-expected.html.
- fast/regions/overflow/overflow-scrollable-varying-width-1.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-varying-width-1.html.
- fast/regions/overflow/overflow-scrollable-varying-width-2-expected.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-varying-width-2-expected.html.
- fast/regions/overflow/overflow-scrollable-varying-width-2.html: Renamed from LayoutTests/fast/regions/overflow-scrollable-varying-width-2.html.
- fast/regions/overflow/overflow-size-change-in-variable-width-regions-expected.html: Renamed from LayoutTests/fast/regions/overflow-size-change-in-variable-width-regions-expected.html.
- fast/regions/overflow/overflow-size-change-in-variable-width-regions.html: Renamed from LayoutTests/fast/regions/overflow-size-change-in-variable-width-regions.html.
- fast/regions/overflow/overflow-size-change-with-stacking-context-expected.html: Renamed from LayoutTests/fast/regions/overflow-size-change-with-stacking-context-expected.html.
- fast/regions/overflow/overflow-size-change-with-stacking-context-rtl-expected.html: Renamed from LayoutTests/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.html.
- fast/regions/overflow/overflow-size-change-with-stacking-context-rtl.html: Renamed from LayoutTests/fast/regions/overflow-size-change-with-stacking-context-rtl.html.
- fast/regions/overflow/overflow-size-change-with-stacking-context.html: Renamed from LayoutTests/fast/regions/overflow-size-change-with-stacking-context.html.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 10:39 PM Changeset in webkit [170046] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix when MHTML is enabled after r170041
- UIProcess/API/C/WKPage.cpp:
(WKPageGetContentsAsMHTMLData):
- 10:35 PM Changeset in webkit [170045] by
-
- 3 edits2 adds in trunk
[CSSRegions] Region with border radius and overflow:hidden does not clip content
https://bugs.webkit.org/show_bug.cgi?id=133476
Reviewed by Andrei Bucur.
Source/WebCore:
When setting the clip before painting the named flow content,
use the region's foreground rect to take the region's border radius
into account if needed.
Test: fast/regions/region-border-radius-overflow-clip.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFlowThreadIfRegionForFragments):
LayoutTests:
- fast/regions/region-border-radius-overflow-clip-expected.html: Added.
- fast/regions/region-border-radius-overflow-clip.html: Added.
- 9:59 PM Changeset in webkit [170044] by
-
- 2 edits in trunk/Source/WebCore
Extract prototype declaration generation into a helper function
https://bugs.webkit.org/show_bug.cgi?id=133969
Reviewed by Dan Bernstein.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GeneratePrototypeDeclaration):
- 9:43 PM Changeset in webkit [170043] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Remove workaround for icon display bug in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=133962
Reviewed by Gyuyoung Kim.
Since we bumped EFL to 1.9, this workaround is unnecessary.
- MiniBrowser/efl/main.c:
(update_view_favicon):
- 8:55 PM Changeset in webkit [170042] by
-
- 46 edits in trunk/Source
Move forward declaration of bindings static functions into their implementation files
https://bugs.webkit.org/show_bug.cgi?id=133943
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- runtime/CommonIdentifiers.h:
Add a few identifiers that are needed by the DOM.
Source/WebCore:
- Moves the forward declaration of static functions for generated files to the implementation.
- Adds a new extended attribute, ForwardDeclareInHeader, for functions that still need a forward declaration in the header.
- bindings/js/JSDOMBinding.h:
(WebCore::nonCachingStaticFunctionGetter):
Move this helper here from JSDOMWindowCustom.cpp.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
Switch to comparing the property name directly rather than looking up in the static table and
comparing function pointers.
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::getOwnPropertySlotDelegate):
Switch to comparing the property name directly rather than looking up in the static table and
comparing function pointers and start using the nonCachingStaticFunctionGetter<> helper.
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::putDelegate):
Switch to comparing the property name directly rather than looking up in the static table and
comparing function pointers and start using the nonCachingStaticFunctionGetter<> helper.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
Move forward declaration creation to the implementation file where possible.
- bindings/scripts/IDLAttributes.txt:
Add ForwardDeclareInHeader.
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
Add ForwardDeclareInHeader where necessary.
- 8:52 PM Changeset in webkit [170041] by
-
- 11 edits in trunk/Source/WebKit2
Part 2 of: Change GenericCallback<> function parameters into std::function<>
https://bugs.webkit.org/show_bug.cgi?id=133927
Reviewed by Sam Weinig.
- UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame):
(WKPageRenderTreeExternalRepresentation):
(WKPageGetSourceForFrame):
(WKPageGetContentsAsString):
(WKPageGetBytecodeProfile):
(WKPageGetSelectionAsWebArchiveData):
(WKPageValidateCommand):
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView evaluateJavaScript:completionHandler:]):
- UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
(-[WKView startSpeaking:]):
(-[WKView selectedRangeWithCompletionHandler:]):
(-[WKView markedRangeWithCompletionHandler:]):
(-[WKView hasMarkedTextWithCompletionHandler:]):
(-[WKView firstRectForCharacterRange:completionHandler:]):
(-[WKView characterIndexForPoint:completionHandler:]):
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::clearSiteData):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateCommand):
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getBytecodeProfile):
(WebKit::WebPageProxy::getContentsAsMHTMLData):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit::WebPageProxy::getMarkedRangeAsync):
(WebKit::WebPageProxy::getSelectedRangeAsync):
(WebKit::WebPageProxy::characterIndexForPointAsync):
(WebKit::WebPageProxy::firstRectForCharacterRangeAsync):
(WebKit::WebPageProxy::takeSnapshot):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _define:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]):
(-[WKContentView requestDictationContext:]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::updateSelectionWithTouches):
(WebKit::WebPageProxy::requestAutocorrectionData):
(WebKit::WebPageProxy::applyAutocorrection):
(WebKit::WebPageProxy::requestDictationContext):
(WebKit::WebPageProxy::requestAutocorrectionContext):
- 7:26 PM Changeset in webkit [170040] by
-
- 5 edits in trunk/Tools
[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=131472
Reviewed by Martin Robinson.
This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
when running WebKitTestRunner with the Xvfb driver.
- gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
- gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
installed.
- gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
deal.
- 7:17 PM Changeset in webkit [170039] by
-
- 2 edits in trunk/Tools
Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
https://bugs.webkit.org/show_bug.cgi?id=133792
Patch by Tanay C <tanay.c@samsung.com> on 2014-06-16
Reviewed by Gyuyoung Kim.
- MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
(show_file_entry_dialog):
(window_create):
- 6:23 PM Changeset in webkit [170038] by
-
- 6 edits in trunk/Source
Unreviewed build fix after r170029
Use String() instead of AtomicString().
Source/WebCore:
- platform/network/HTTPParsers.cpp:
(WebCore::parseHTTPHeader):
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessageHeaders):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::toSoupMessage):
Source/WebKit2:
- UIProcess/InspectorServer/HTTPRequest.cpp:
(WebKit::HTTPRequest::parseHeaders):
- 4:56 PM Changeset in webkit [170037] by
-
- 19 edits in trunk/Source
[Win] Use TileController on Windows
https://bugs.webkit.org/show_bug.cgi?id=133895
Reviewed by Tim Horton.
../WebCore:
- WebCore.vcxproj/WebCore.vcxproj: Add Tiled Drawing files.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- platform/graphics/TiledBacking.h: No longer Cocoa-only.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Windows
now uses the same layer type as Mac.
- platform/graphics/ca/LayerPool.cpp:
(WebCore::LayerPool::takeLayerWithSize): Use nullptr
rather than nil for C++ code.
- platform/graphics/ca/PlatformCALayer.cpp:
- platform/graphics/ca/PlatformCALayer.h: Expose necessary
drawing functions for Windows port.
- platform/graphics/ca/TileController.cpp: Remove unneeded
header include for WebLayer.
- platform/graphics/ca/TileCoverageMap.cpp: Correct #includes.
- platform/graphics/ca/TileGrid.h: Not just for Cococa.
- platform/graphics/ca/mac/PlatformCALayerMac.mm: Remove
extra whitespace.
- platform/graphics/ca/mac/PlatformCALayerMac.h: Remove
unneeded overload.
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::collectRectsToPaint): Added stub.
(PlatformCALayer::drawLayerContents): Added.
(PlatformCALayer::frameForLayer): Added.
(PlatformCALayerWin::PlatformCALayerWin): Remove unneeded
assert now that we support these types. Add TileController
support.
(PlatformCALayerWin::setEdgeAntialiasingMask): Added.
(printLayer): Add newly-supported tile types.
(PlatformCALayerWin::tiledBacking): Added.
- platform/graphics/ca/win/PlatformCALayerWin.h: Update to
support Tiled Drawing.
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::PlatformCALayerWinInternal): Update to
recognize newly-supported layer types.
(PlatformCALayerWinInternal::setNeedsDisplay): Ditto.
(PlatformCALayerWinInternal::setSublayers): Ditto.
(PlatformCALayerWinInternal::getSublayers): Ditto.
(PlatformCALayerWinInternal::removeAllSublayers): Ditto.
(PlatformCALayerWinInternal::insertSublayer): Ditto.
(PlatformCALayerWinInternal::sublayerCount): Ditto.
(PlatformCALayerWinInternal::indexOfSublayer): Ditto.
(PlatformCALayerWinInternal::sublayerAtIndex): Ditto.
(PlatformCALayerWinInternal::setBounds): Ditto.
(PlatformCALayerWinInternal::setFrame): Ditto.
(PlatformCALayerWinInternal::drawTile): Ditto.
(PlatformCALayerWinInternal::createTileController): Ditto.
(PlatformCALayerWinInternal::tiledBacking): Ditto.
- platform/graphics/ca/win/PlatformCALayerWinInternal.h: Update to use
TileController.
../WebKit2:
- WebProcess/WebPage/mac/PlatformCALayerRemote.h: Remove
unneeded overload.
- 4:48 PM Changeset in webkit [170036] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][wk2] Swipe snapshots are removed too quickly if there is no saved render tree size
https://bugs.webkit.org/show_bug.cgi?id=133891
Reviewed by Simon Fraser.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):
If we don't know the target render tree size, wait until the first layer tree commit
that comes in, instead of removing the snapshot when the gesture ends.
- 4:45 PM Changeset in webkit [170035] by
-
- 10 edits in trunk/Source/WebKit2
[iOS][wk2] Swiping back briefly shows the previous page before loading the new one
https://bugs.webkit.org/show_bug.cgi?id=133885
Reviewed by Simon Fraser.
Remove a race between the UI and Web processes when removing the swipe snapshot.
Previously, it was possible to get a commit from the Web process with layer content
(and render tree size) from the previous page *after* sending the navigation request
to the page, because of the asynchronicity of layer tree commits. This could cause
the snapshot to be removed early (if the previous fully-loaded page had a sufficiently
large render tree size), revealing the old tiles underneath the snapshot.
- Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::transactionID):
(WebKit::RemoteLayerTreeTransaction::setTransactionID):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::lastVisibleTransactionID):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::coreAnimationDidCommitLayers):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
Keep track of an ever-increasing transaction ID in RemoteLayerTreeDrawingArea(Proxy).
It increments in the UI process at didUpdate time, because the Web process cannot
have started on a new layer tree commit until didUpdate is sent.
It increments in the Web process at commit time.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):
- UIProcess/mac/ViewGestureController.h:
Adopt transaction IDs; don't remove the snapshot until the commit
that includes the navigation arrives.
- 4:19 PM Changeset in webkit [170034] by
-
- 9 edits in trunk
Parser statementDepth accounting needs to account for when a function body excludes its braces.
<https://webkit.org/b/133832>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
In some cases (e.g. when a Function object is instantiated from a string), the
function body source may not include its braces. The parser needs to account
for this when calculating its statementDepth.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):
- bytecode/UnlinkedCodeBlock.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseStatement):
- Also fixed the error message for declaring nested functions in strict mode to be more accurate.
- parser/Parser.h:
(JSC::Parser<LexerType>::parse):
(JSC::parse):
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
LayoutTests:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- Added cases for declaring functions in strict mode.
- Added caught error to the test result logging if it's not a SyntaxError. This helps catch the issue in this bug which was erroneously throwing RangeErrors.
- 3:57 PM Changeset in webkit [170033] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary style invalidation in RenderTextControl::styleDidChange().
<https://webkit.org/b/133949>
This explicit invalidation of the text control's inner text element
was hacked in to fix an editing test back in 2011, long before lazy
render tree construction.
It should be safe to remove, since doing so doesn't affect any tests.
Reviewed by Antti Koivisto.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
- 3:57 PM Changeset in webkit [170032] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/17327707> [Cocoa] Expose WebPreferences::storageBlockingPolicy
https://bugs.webkit.org/show_bug.cgi?id=133958
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKPreferences.mm:
(toStorageBlockingPolicy): Added this helper conversion function.
(toAPI): Ditto.
(-[WKPreferences _storageBlockingPolicy]): Added this getter.
(-[WKPreferences _setStorageBlockingPolicy:]): Added this setter.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h: Declared new _storageBlockingPolicy property
and _WKStorageBlockingPolicy enum.
- 3:46 PM Changeset in webkit [170031] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build.
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::setHeaderFields):
- 3:42 PM Changeset in webkit [170030] by
-
- 2 edits in trunk/Source/WebCore
Accept-Ranges is not specific to GStreamer.
- platform/network/HTTPHeaderNames.in:
- 3:28 PM Changeset in webkit [170029] by
-
- 22 edits in trunk/Source
Don't use AtomicString in HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=133957
<rdar://problem/15256572>
Reviewed by Andreas Kling.
Source/WebCore:
Use the string data that comes from the generated HTTPHeaderNames.cpp file
for sharing header name data instead. In the future we can do something more fancy where
we'll hash the HTTPHeaderName enum directly, but this is good enough for now.
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readHTTPHeaders):
- WebCore.exp.in:
- inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForHeaders):
- loader/CrossOriginPreflightResultCache.cpp:
(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::parseHeader):
- loader/cache/CachedResource.cpp:
(WebCore::shouldUpdateHeaderAfterRevalidation):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
(WebCore::internHTTPHeaderNameString):
(WebCore::HTTPHeaderMap::get):
(WebCore::HTTPHeaderMap::set):
(WebCore::HTTPHeaderMap::add):
(WebCore::CaseFoldingCStringTranslator::hash): Deleted.
(WebCore::CaseFoldingCStringTranslator::equal): Deleted.
(WebCore::CaseFoldingCStringTranslator::translate): Deleted.
- platform/network/HTTPHeaderMap.h:
- platform/network/HTTPHeaderNames.in:
- platform/network/HTTPParsers.cpp:
(WebCore::parseHTTPHeader):
- platform/network/HTTPParsers.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::httpHeaderField):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::addHTTPHeaderField):
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::addHTTPHeaderField):
- platform/network/ResourceResponseBase.h:
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setRequestHeader):
(WebCore::XMLHttpRequest::setRequestHeaderInternal):
(WebCore::XMLHttpRequest::getRequestHeader):
(WebCore::XMLHttpRequest::getResponseHeader):
- xml/XMLHttpRequest.h:
Source/WebKit2:
Update for WebCore changes.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<HTTPHeaderMap>::decode):
- 2:44 PM Changeset in webkit [170028] by
-
- 3 edits in trunk/Source/WebCore
AX: Safari crashed once in WebCore::AccessibilityObject::ariaIsHidden
https://bugs.webkit.org/show_bug.cgi?id=133825
Reviewed by Enrica Casucci.
Sometimes asking accessibilityIsIgnored() will cause a newObject to be detached immediately after its created.
The creation function holds a reference with RefPtr as long as it lives, but when that method returns, the object goes away.
With that out of the way, I saw the same backtrace lead to updateLayoutIgnorePendingStylesheets being called while still inLayout.
I tried my best but could not create a reproducible layout test.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateBackingStore):
- 2:22 PM Changeset in webkit [170027] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Add more GStreamer-specific header names that are required
after changes in r170021, fixing the build for ports using GStreamer.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived):
- platform/network/HTTPHeaderNames.in:
- 2:01 PM Changeset in webkit [170026] by
-
- 2 edits in trunk/Source/WebCore
AX: Crash at WebCore::AXObjectCache::textChanged
https://bugs.webkit.org/show_bug.cgi?id=133873
Reviewed by Enrica Casucci.
This looks like a very similar problem to
https://bugs.webkit.org/show_bug.cgi?id=133825
The object is being created and deallocated almost right away because calling accessibilityIsIgnored triggers
a deferred layout that invalidates the associated render element.
Despite my best efforts, I could not come up with a way to reproduce this in a layout test.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- 1:33 PM Changeset in webkit [170025] by
-
- 14 edits in trunk/Source
Change ResourceRequestBase::addHTTPHeaderFields to setHTTPHeaderFields instead
https://bugs.webkit.org/show_bug.cgi?id=133925
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.exp.in:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setHTTPHeaderFields):
(WebCore::ResourceRequestBase::addHTTPHeaderFields): Deleted.
- platform/network/ResourceRequestBase.h:
- plugins/PluginView.cpp:
(WebCore::PluginView::handlePost):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Source/WebKit2:
- PluginProcess/PluginControllerProxy.h:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ResourceRequest>::decode):
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_PostURL):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):
- WebProcess/Plugins/PluginView.h:
- 12:52 PM Changeset in webkit [170024] by
-
- 12 edits in trunk/Source/WebCore
Use references instead of pointers to RenderBlock in RenderObject::enclosingBox().
https://bugs.webkit.org/show_bug.cgi?id=133902
Patch by Jeongeun Kim <je_julie.kim@samsung.com> on 2014-06-16
Reviewed by Andreas Kling.
Just a straightforward conversion from pointers to references.
No new tests, no behavior change.
- bindings/objc/DOMUIKitExtensions.mm:
(-[DOMHTMLElement structuralComplexityContribution]):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForRendererFragments):
- page/EventHandler.cpp:
(WebCore::scrollNode):
(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::logicalScrollOverflow):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- rendering/RenderBox.cpp:
(WebCore::computeInlineStaticDistance):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computedRegionRangeForBox):
(WebCore::RenderFlowThread::objectShouldFragmentInFlowRegion):
(WebCore::RenderFlowThread::objectInFlowRegion):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingBox): Removed FIXME comment
- rendering/RenderObject.h:
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::owningRenderer):
- 12:46 PM Changeset in webkit [170023] by
-
- 4 edits in trunk/Source/WebCore
Use HTTPHeaderName in more places
https://bugs.webkit.org/show_bug.cgi?id=133948
Reviewed by Andreas Kling.
- loader/cache/CachedRawResource.cpp:
(WebCore::shouldIgnoreHeaderForCacheReuse):
- platform/network/HTTPHeaderNames.in:
- xml/XMLHttpRequest.cpp:
(WebCore::isSetCookieHeader):
(WebCore::isForbiddenRequestHeader):
(WebCore::XMLHttpRequest::isAllowedHTTPHeader):
(WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Deleted.
(WebCore::staticData): Deleted.
- 12:27 PM Changeset in webkit [170022] by
-
- 2 edits in trunk/Source/JavaScriptCore
Change the order of the alias analysis passes to align with the opt pipeline of LLVM
https://bugs.webkit.org/show_bug.cgi?id=133753
Patch by Juergen Ributzka <juergen@apple.com> on 2014-06-16
Reviewed by Geoffrey Garen.
The order in which the alias analysis passes are added affects also the
order in which they are utilized. Change the order to align with the
one use by LLVM itself. The last alias analysis pass added will be
evaluated first. With this change we first perform a basic alias
analysis and then use the type-based alias analysis (if required).
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- 12:26 PM Changeset in webkit [170021] by
-
- 19 edits in trunk/Source
Add HTTPHeaderName overloads on ResourceResponseBase
https://bugs.webkit.org/show_bug.cgi?id=133946
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::lastModified):
- loader/CrossOriginAccessControl.cpp:
(WebCore::passesAccessControlCheck):
- loader/CrossOriginPreflightResultCache.cpp:
(WebCore::CrossOriginPreflightResultCacheItem::parse):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::didBeginDocument):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::canUseSheet):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::mimeType):
- platform/network/HTTPHeaderNames.in:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
- platform/network/ResourceResponseBase.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::getAllResponseHeaders):
(WebCore::XMLHttpRequest::getResponseHeader):
(WebCore::XMLHttpRequest::responseMIMEType):
(WebCore::XMLHttpRequest::didReceiveResponse):
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::buildHTTPHeaders):
- 12:26 PM Changeset in webkit [170020] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the arguments passed to the LLVM dylib
https://bugs.webkit.org/show_bug.cgi?id=133757
Patch by Juergen Ributzka <juergen@apple.com> on 2014-06-16
Reviewed by Geoffrey Garen.
The LLVM command line argument parser assumes that the first argument
is the program name. We need to add a fake program name, otherwise the
first argument will be parsed as program name and ignored.
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
- 12:04 PM Changeset in webkit [170019] by
-
- 2 edits in trunk/Source/WebKit2
Fixed a typo in the last change.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
- 12:00 PM Changeset in webkit [170018] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Remove WKPreferences persistence in user defaults
https://bugs.webkit.org/show_bug.cgi?id=133945
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKPreferences.h: Removed userDefaultsKeyPrefix property and
initializer with userDefaultsKeyPrefix parameter.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]): Changed to initialize an instance with an empty identifier, which
means that it won’t persist to user defaults.
(-[WKPreferences initWithUserDefaultsKeyPrefix:]): Deleted.
(-[WKPreferences userDefaultsKeyPrefix]): Deleted.
- 11:20 AM Changeset in webkit [170017] by
-
- 4 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Remove the DFG optimization fixpoint and remove some obvious reasons why we previously benefited from it
https://bugs.webkit.org/show_bug.cgi?id=133931
Reviewed by Oliver Hunt.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Trigger constant-folding for GetMyArgumentByVal (which means turning it into GetLocalUnlinked) and correct the handling of Upsilon so we don't fold them away.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants): Implement constant-folding for GetMyArgumentByVal.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl): Remove the fixpoint.
- 11:03 AM Changeset in webkit [170016] by
-
- 11 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] DFG OSR entry should have a crystal-clear story for when it's safe to enter at a block with a set of values
https://bugs.webkit.org/show_bug.cgi?id=133935
Reviewed by Oliver Hunt.
- bytecode/Operands.h:
(JSC::Operands::Operands):
(JSC::Operands::ensureLocals):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::filter): Now we can compute intersections of abstract values!
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::makeFullTop): Completeness.
(JSC::DFG::AbstractValue::bytecodeTop): Completeness.
(JSC::DFG::AbstractValue::fullTop): Completeness. We end up using this one.
- dfg/DFGBasicBlock.cpp:
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::ensureLocals):
- dfg/DFGBasicBlock.h: Remember the intersection of all things ever proven.
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::run): Compute the intersection.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants): No need for the weirdo merge check since this fixes the root of the problem.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dumpBlockHeader): Better dumping.
(JSC::DFG::Graph::dump): Better dumping.
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry): Use the intersected abstract value.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock): Assert if the intersected state indicates the block shouldn't execute.
- 10:41 AM Changeset in webkit [170015] by
-
- 6 edits in trunk/Source/WebCore
"nullable" sequence support is incomplete (i.e. sequence<NativeType>?) https://bugs.webkit.org/show_bug.cgi?id=131240
eeviewed by Darin Adler.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
Nullable sequences are not fully supported in WebKit's
code generator machinery. Although the generated code
does add "is nullable" check to the evaluation condition
(i.e. if (arg.isNull() ...)), when the JSValue that holds a "null" JSObject is actually to be "converted"
to a native Vector<T>, it fails.
The reason for the failure is in JSDOMBindings::toNativeArray.
This method verifies that JSValue does not hold a "non-null"
object, and it bails out.
Analogly, the "ref ptr" variant of this method (toRefPtrNativeArray)
does support nullables.
Patch fixes it be checking for a "null" JSValue check before hand.
Tests: Binding tests updated.
- bindings/js/JSDOMBinding.h:
(WebCore::toNativeArray):
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
- Modules/websocket/WebSocket.idl:
Removed one overload ctor now that
we can use nullable sequences.
- 10:23 AM Changeset in webkit [170014] by
-
- 4 edits in trunk/Source/WebCore
[MSE][Mac] Occasional image corruption after seeking
https://bugs.webkit.org/show_bug.cgi?id=133879
Reviewed by Eric Carlson.
Change the order of operations for seeks: change the current time of the AVSampleBufferRenderSynchronizer
before flushing and appending non-displaying samples.
Rather than having a single function which retrieves the fast seek time and then seeks, split this out
into two functions: one which gets the fast seek time, and one which seeks. (The later of course already
exists: seekToTime()).
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::fastSeekTimeForMediaTime): Renamed from seekToTime()
(WebCore::MediaSourcePrivateAVFObjC::seekToTime): Deleted.
- 9:45 AM Changeset in webkit [170013] by
-
- 27 edits in trunk/Source/WebCore
Have ScriptExecutionContext::Task functions take in a ScriptExecutionContext reference
https://bugs.webkit.org/show_bug.cgi?id=133795
Reviewed by Andreas Kling.
The pointer to the ScriptExecutionContext object that is passed to the C++11 lambdas or
helper functions wrapped in ScriptExecutionContext::Task is never null, so that parameter
should be a reference instead.
- Modules/webdatabase/Database.cpp:
(WebCore::Database::~Database):
(WebCore::Database::runTransaction):
(WebCore::Database::scheduleTransactionCallback):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks): Dereference the
member variable that holds a never-null pointer to the ScriptExecutionContext. This should
similarly be a reference.
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmountCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageErrorCallback):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::workerGlobalScopeDidSend):
(WebCore::workerGlobalScopeDidGetBufferedAmount):
(WebCore::workerGlobalScopeDidConnect):
(WebCore::workerGlobalScopeDidReceiveMessage):
(WebCore::workerGlobalScopeDidReceiveBinaryData):
(WebCore::workerGlobalScopeDidUpdateBufferedAmount):
(WebCore::workerGlobalScopeDidStartClosingHandshake):
(WebCore::workerGlobalScopeDidClose):
(WebCore::workerGlobalScopeDidReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadConnect):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSend):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadClose):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadFail):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSuspend):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadResume):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
- bindings/js/JSDOMGlobalObjectTask.cpp:
(WebCore::JSGlobalObjectTask::JSGlobalObjectTask):
- dom/Document.cpp:
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::Task::performTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
- dom/StringCallback.cpp:
(WebCore::StringCallback::scheduleCallback):
- fileapi/FileReader.cpp:
(WebCore::delayedAbort):
(WebCore::FileReader::abort):
(WebCore::FileReader::doAbort): Deleted.
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadDestroy):
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCancel):
(WebCore::workerGlobalScopeDidSendData):
(WebCore::workerGlobalScopeDidReceiveResponse):
(WebCore::workerGlobalScopeDidReceiveData):
(WebCore::workerGlobalScopeDidFinishLoading):
(WebCore::workerGlobalScopeDidFail):
(WebCore::workerGlobalScopeDidFailAccessControlCheck):
(WebCore::workerGlobalScopeDidFailRedirectCheck):
- loader/WorkerThreadableLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::postListenerTask):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::crossThreadRemoveRequestFromCache):
(WebCore::MemoryCache::crossThreadRemoveRequestFromSessionCaches):
- loader/cache/MemoryCache.h:
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
(WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask):
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::enqueueEvent):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::close):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::workerObjectDestroyed):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::Task::performTask):
- workers/WorkerScriptLoader.cpp:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
- 9:42 AM Changeset in webkit [170012] by
-
- 6 edits in trunk/Source
Page::findStringMatchingRanges() should take Vector<RefPtr<Range>> by reference instead of pointer
https://bugs.webkit.org/show_bug.cgi?id=133677
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in: Update the changed symbol.
- page/Page.cpp:
(WebCore::Page::findStringMatchingRanges): The method expects the matchRanges parameter to be non-null,
so it should take in that parameter by reference instead of pointer.
- page/Page.h:
Source/WebKit2:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString): Update the call to Page::findStringMatchingRanges() to pass
in a Vector<RefPtr<Range>> reference instead of a pointer.
(WebKit::FindController::findStringMatches): Ditto.
- 9:40 AM Changeset in webkit [170011] by
-
- 2 edits in trunk/Source/JavaScriptCore
Convert ASSERT in inlineFunctionForCapabilityLevel to early return
https://bugs.webkit.org/show_bug.cgi?id=133903
Reviewed by Mark Hahnenberg.
Hardened code by Converting ASSERT to return CannotCompile.
- dfg/DFGCapabilities.h:
(JSC::DFG::inlineFunctionForCapabilityLevel):
- 9:33 AM Changeset in webkit [170010] by
-
- 3 edits2 adds in trunk
REGRESSION (r168046): Incorrect layout for multicol spanners when moving from one thread to another
https://bugs.webkit.org/show_bug.cgi?id=133589
Reviewed by Antti Koivisto.
Source/WebCore:
When a spanner is moved from a multicol thread to another, its placeholder
must be properly repositioned.
Test: fast/multicol/newmulticol/spanner-crash.html
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted):
LayoutTests:
- fast/multicol/newmulticol/spanner-crash-expected.txt: Added.
- fast/multicol/newmulticol/spanner-crash.html: Added.
- 9:20 AM Changeset in webkit [170009] by
-
- 5 edits in releases/WebKitGTK/webkit-2.4
[Gtk] [Stable] Fix the "Safari" part of the UA
https://bugs.webkit.org/show_bug.cgi?id=133855
Reviewed by Martin Robinson.
Source/WebCore:
We claim to be Safari (among others) to ensure maximum
compatibility with existing web sites. Since Safari 3.0 valid
Safari UA strings look like this "Version/X Safari/Y" while in our
UA it's "Safari/Y Version/6.0".
This is wrong and is causing "unsupported browser" issues in
many important sites as live.com our icloud.com.
Apart from that I'm bumping the Safari Version in the UA to 8.0 as
we're already claiming to be "Safari/538.15" which should be
pretty equivalent to Safari 8 in terms of features.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::standardUserAgent):
Tools:
Added a couple of tests to verify that the Safari part of our UA
looks like "Version/X Safari/Y" instead of "Safari/Y Version/X"
which is causing "unsupported browser" issues.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
(testWebKitSettingsUserAgent):
- TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c:
(test_webkit_web_settings_user_agent):
- 8:01 AM Changeset in webkit [170008] by
-
- 9 edits2 adds2 deletes in trunk
[ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
https://bugs.webkit.org/show_bug.cgi?id=133512
Reviewed by Chris Fleizach.
Source/WebCore:
Make sure that AccessibilityMenuList objects update their active
option when it changes, which will send a platform-dependent
accessibility-related notification when needed.
Test: accessibility/combo-box-collapsed-selection-changed.html
- rendering/RenderMenuList.cpp:
(RenderMenuList::didUpdateActiveOption): Keep the out-of-bounds
check for the index passed but don't avoid updating the option for
the associated AccessibilityMenuList object if the selected list
item does not have a renderer, because that could be the case for
cases where the popup (and its elements) would be rendered in the
UI Process (e.g. GTK+ port uses GtkMenu and GtkMenuItem for that).
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::didUpdateActiveOption): Ensure
that the AccessibilityMenuListPopup object for a given menu list
has accessibility children before updating its active option.
Tools:
Added support for connecting to AtkSelection's 'selection-changed'
signal, and print it out as AXSelectedChildrenChanged in the tests.
Also removed some dead code, that became useless after r169487.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
LayoutTests:
Re-implemented test for combo boxes in terms of addNotificationListener()
instead of using the (already deprecated) logAccessibilityEvents method,
and made the test cross platform (as the fix is not platform specific).
- accessibility/combo-box-collapsed-selection-changed.html:
Implemented based on the former gtk-only test, and made it cross-platform.
- accessibility/combo-box-collapsed-selection-changed-expected.txt: New.
- platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Removed.
- platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Removed.
Updated expectation for test that checks that a notification is
sent when navigating through a multiselection list box, now that
we are actually printing such a notification.
- accessibility/multiselect-list-reports-active-option-expected.txt: Updated.
Removed two expected failures from TestExpectations for tests that
are now passing, one for the combo box test mentioned above and
another one for a test that is passing as well now, after applying
this fix: accessibility/menu-list-sends-change-notification.html
- platform/gtk/TestExpectations: Removed two 'failure' expectations.
- platform/mac/TestExpectations: Skip accessiblity test timing out, probably because
those kind of notifications while navigating a combo box are not needed in the Mac.
- 5:17 AM Changeset in webkit [170007] by
-
- 7 edits3 deletes in trunk
Unreviewed, rolling out r170003.
https://bugs.webkit.org/show_bug.cgi?id=133938
This patch broke GTK build (Requested by kczech on #webkit).
Reverted changeset:
"[EFL] Platform support for WebSpeech feature."
https://bugs.webkit.org/show_bug.cgi?id=116438
http://trac.webkit.org/changeset/170003
- 4:31 AM Changeset in webkit [170006] by
-
- 2 edits in trunk/Source/WebCore
Draw radicals with glyphs for better rendering.
https://bugs.webkit.org/show_bug.cgi?id=119038
Unreviewed ASSERT fix.
- rendering/mathml/RenderMathMLRoot.h:
- 3:07 AM Changeset in webkit [170005] by
-
- 20 edits10 adds in trunk
Draw radicals with glyphs for better rendering
https://bugs.webkit.org/show_bug.cgi?id=119038
Reviewed by Chris Fleizach.
Source/WebCore:
We rewrite RenderMathMLRoot in order to fix bugs with SVG transforms and dynamic modification of children and allow drawing with an OpenType MATH table.
The drawing of the radical sign (without the top bar) is now moved to a RenderMathMLRadicalOperator class inheriting from RenderMathMLOperator.
This class fallbacks to the original drawing with graphic primitives if an OpenType MATH table is not available.
Tests: mathml/opentype/roots-LatinModern.html
mathml/presentation/mroot-transform.html
- CMakeLists.txt: add files to build system.
- WebCore.vcxproj/WebCore.vcxproj: ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto
- css/mathml.css: remove rules for msqrt/mroot. The "script level" in mroot is not incremented by 2 as specified in the spec.
(math, mrow, mfenced, merror, mphantom, mstyle, menclose):
(mroot > *:last-child):
(math, mrow, mfenced, msqrt, mroot, merror, mphantom, mstyle, menclose): Deleted.
(msqrt > *): Deleted.
(mroot): Deleted. This rule was causing bug 126516.
(mroot > * + *): Deleted.
- rendering/RenderObject.h: Add two new isRenderMathML* functions for dynamic casting.
(WebCore::RenderObject::isRenderMathMLRadicalOperator):
(WebCore::RenderObject::isRenderMathMLRootWrapper):
- rendering/mathml/RenderMathMLOperator.cpp: Accept a set of operator dictionary flags, all disabled by default. This is to allow anonymous radicas, which don't have any flag.
isFencedOperator() is now replaced with the more general isAnonymous() since we allow anonymous radical operator fors msqrt/mroot.
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute):
(WebCore::RenderMathMLOperator::setOperatorPropertiesFromOpDictEntry):
(WebCore::RenderMathMLOperator::SetOperatorProperties):
(WebCore::RenderMathMLOperator::updateTokenContent):
- rendering/mathml/RenderMathMLOperator.h: Allow class to be overriden, redefine the anonymous constructor, remove isFencedOperator().
- rendering/mathml/RenderMathMLRadicalOperator.cpp: Added.
(WebCore::RenderMathMLRadicalOperator::RenderMathMLRadicalOperator):
(WebCore::RenderMathMLRadicalOperator::stretchTo):
(WebCore::RenderMathMLRadicalOperator::SetOperatorProperties):
(WebCore::RenderMathMLRadicalOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLRadicalOperator::computeLogicalHeight):
(WebCore::RenderMathMLRadicalOperator::paint):
(WebCore::RenderMathMLRadicalOperator::trailingSpaceError):
- rendering/mathml/RenderMathMLRadicalOperator.h: Added.
- rendering/mathml/RenderMathMLRoot.cpp: Rewritten. Some parts to use graphic primitives are moved to RenderMathMLRadicalOperator.cpp.
(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::baseWrapper):
(WebCore::RenderMathMLRoot::radicalWrapper):
(WebCore::RenderMathMLRoot::indexWrapper):
(WebCore::RenderMathMLRoot::radicalOperator):
(WebCore::RenderMathMLRoot::restructureWrappers):
(WebCore::RenderMathMLRoot::addChild):
(WebCore::RenderMathMLRoot::styleDidChange):
(WebCore::RenderMathMLRoot::updateFromElement):
(WebCore::RenderMathMLRoot::updateStyle):
(WebCore::RenderMathMLRoot::firstLineBaseline):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRootWrapper::createAnonymousWrapper):
(WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring):
(WebCore::RenderMathMLRootWrapper::removeChild):
(WebCore::RenderMathMLRoot::paddingTop): Deleted.
(WebCore::RenderMathMLRoot::paddingBottom): Deleted.
(WebCore::RenderMathMLRoot::paddingLeft): Deleted.
(WebCore::RenderMathMLRoot::paddingRight): Deleted.
(WebCore::RenderMathMLRoot::paddingBefore): Deleted.
(WebCore::RenderMathMLRoot::paddingAfter): Deleted.
(WebCore::RenderMathMLRoot::paddingStart): Deleted.
(WebCore::RenderMathMLRoot::paddingEnd): Deleted.
(WebCore::RenderMathMLRoot::index): Deleted.
- rendering/mathml/RenderMathMLRoot.h: Rewritten.
(WebCore::RenderMathMLRootWrapper::RenderMathMLRootWrapper):
LayoutTests:
We update the reference for some tests with radicals and update the expectation of tests for addition/removal of children in an msqrt/mroot element.
We also add a test for bug 126516 (SVG transforms not applied to mroot) and a new test for radical drawing using an OpenType MATH table.
- TestExpectations: enable the tests for addition/removal of children.
- mathml/opentype/roots-LatinModern.html: Added.
- mathml/presentation/mroot-transform-expected.html: Added.
- mathml/presentation/mroot-transform.html: Added.
- platform/efl/TestExpectations: mark failures for bad references.
- platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Added.
- platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Added.
- platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Added.
- platform/gtk/mathml/presentation/mo-stretch-expected.png: update reference.
- platform/gtk/mathml/presentation/mo-stretch-expected.txt: update reference.
- platform/gtk/mathml/presentation/roots-expected.png: update reference.
- platform/gtk/mathml/presentation/roots-expected.txt: update reference.
- platform/mac/TestExpectations: mark failures for bad references.
- platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Added.
- platform/win/TestExpectations: mark failures for bad references.
- platform/win/mathml/opentype/roots-LatinModern-expected.txt: Added.
- 2:23 AM EFLHistoryApiTutorial edited by
- (diff)
- 2:09 AM Changeset in webkit [170004] by
-
- 2 edits in trunk/LayoutTests
[EFL] Change expectations for three failing or flaky layout tests.
https://bugs.webkit.org/show_bug.cgi?id=133861
Unreviewed EFL gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-06-16
- platform/efl/TestExpectations:
- 1:25 AM Changeset in webkit [170003] by
-
- 7 edits3 adds in trunk
[EFL] Platform support for WebSpeech feature.
https://bugs.webkit.org/show_bug.cgi?id=116438
Reviewed by Gyuyoung Kim.
.:
Add ENABLE_SPEECH_SYNTHESIS flag to have Speech Synthesis in EFL.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/WebCore:
It's a first step of adding support for Speech Synthesis in EFL port.
Just stub out required API and support for compilation.
- CMakeLists.txt:
- PlatformEfl.cmake:
- platform/PlatformSpeechSynthesizer.h:
- platform/efl/PlatformSpeechSynthesisProviderEfl.cpp: Added.
(WebCore::PlatformSpeechSynthesisProviderEfl::PlatformSpeechSynthesisProviderEfl):
(WebCore::PlatformSpeechSynthesisProviderEfl::~PlatformSpeechSynthesisProviderEfl):
(WebCore::PlatformSpeechSynthesisProviderEfl::initializeVoiceList):
(WebCore::PlatformSpeechSynthesisProviderEfl::pause):
(WebCore::PlatformSpeechSynthesisProviderEfl::resume):
(WebCore::PlatformSpeechSynthesisProviderEfl::speak):
(WebCore::PlatformSpeechSynthesisProviderEfl::cancel):
- platform/efl/PlatformSpeechSynthesisProviderEfl.h: Added.
- platform/efl/PlatformSpeechSynthesizerEfl.cpp: Added.
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::cancel):
- 12:25 AM Changeset in webkit [170002] by
-
- 4 edits in trunk/Source/WebKit2
Unreviewed build fixes for the EFL and GTK+ ports after r169994 and 170000.
- UIProcess/API/C/WKPluginSiteDataManager.cpp: Undefine the None macro under X11.
- UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkit_cookie_manager_get_accept_policy): Remove unnecessary ::create() wrappings.
(webkit_cookie_manager_get_domains_with_cookies): Ditto.
- UIProcess/API/gtk/WebKitWebResource.cpp:
(webkit_web_resource_get_data): Ditto.
Jun 15, 2014:
- 11:54 PM Changeset in webkit [170001] by
-
- 8 edits8 adds in trunk
CSS JIT: add support for the :lang() pseudo class
https://bugs.webkit.org/show_bug.cgi?id=133913
Reviewed by Andreas Kling.
Source/WebCore:
The selector is already very expensive to begin with, just implement it with
a function call.
It is also done after every other filter since it is so inefficient.
Tests: fast/selectors/lang-conflict.html
fast/selectors/lang-empty.html
fast/selectors/lang-specificity-xml.xhtml
fast/selectors/lang-specificity.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/SelectorCheckerTestFunctions.h:
(WebCore::matchesLangPseudoClass):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsInLanguage):
- dom/Element.cpp:
(WebCore::Element::computeInheritedLanguage):
- dom/ElementData.cpp:
(WebCore::ElementData::findLanguageAttribute):
- dom/ElementData.h:
LayoutTests:
- fast/selectors/lang-conflict-expected.txt: Added.
- fast/selectors/lang-conflict.html: Added.
- fast/selectors/lang-empty-expected.txt: Added.
- fast/selectors/lang-empty.html: Added.
- fast/selectors/lang-specificity-expected.txt: Added.
- fast/selectors/lang-specificity-xml-expected.txt: Added.
- fast/selectors/lang-specificity-xml.xhtml: Added.
- fast/selectors/lang-specificity.html: Added.
- 9:09 PM Changeset in webkit [170000] by
-
- 38 edits in trunk/Source/WebKit2
Part 1 of Change GenericCallback<> function parameters into std::function<>
https://bugs.webkit.org/show_bug.cgi?id=133927
Reviewed by Sam Weinig.
- UIProcess/API/C/WKApplicationCacheManager.cpp:
(WKApplicationCacheManagerGetApplicationCacheOrigins):
- UIProcess/API/C/WKContext.cpp:
(WKContextGetStatistics):
(WKContextGetStatisticsWithOptions):
- UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerGetHostnamesWithCookies):
(WKCookieManagerGetHTTPCookieAcceptPolicy):
- UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerGetDatabasesByOrigin):
(WKDatabaseManagerGetDatabaseOrigins):
- UIProcess/API/C/WKFrame.cpp:
(WKFrameGetMainResourceData):
(WKFrameGetResourceData):
(WKFrameGetWebArchive):
- UIProcess/API/C/WKKeyValueStorageManager.cpp:
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):
- UIProcess/API/C/WKMediaCacheManager.cpp:
(WKMediaCacheManagerGetHostnamesWithMediaCache):
- UIProcess/API/C/WKOriginDataManager.cpp:
(WKOriginDataManagerGetOrigins):
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerGetSitesWithData):
- UIProcess/API/C/WKResourceCacheManager.cpp:
(WKResourceCacheManagerGetCacheOrigins):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _getWebArchiveDataWithCompletionHandler:]):
- UIProcess/API/mac/WKView.mm:
(-[WKView attributedSubstringForProposedRange:completionHandler:]):
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::getSitesWithData):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
- UIProcess/WebApplicationCacheManagerProxy.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::getStatistics):
- UIProcess/WebContext.h:
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
- UIProcess/WebDatabaseManagerProxy.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::getWebArchive):
(WebKit::WebFrameProxy::getMainResourceData):
(WebKit::WebFrameProxy::getResourceData):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::getStorageDetailsByOrigin):
- UIProcess/WebKeyValueStorageManager.h:
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
- UIProcess/WebMediaCacheManagerProxy.h:
- UIProcess/WebOriginDataManagerProxy.cpp:
(WebKit::WebOriginDataManagerProxy::getOrigins):
- UIProcess/WebOriginDataManagerProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
- UIProcess/WebResourceCacheManagerProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::selectWithGesture):
(WebKit::WebPageProxy::selectWithTwoTouches):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):
- 9:08 PM Changeset in webkit [169999] by
-
- 2 edits in trunk/Source/WTF
iOS build fix after r169995.
- wtf/RetainPtr.h:
- 8:23 PM Changeset in webkit [169998] by
-
- 7 edits in trunk/Source/WebKit2
<rdar://problem/17291697> [Cocoa] Can’t tell at policy decision time whether WebKit can handle the request
https://bugs.webkit.org/show_bug.cgi?id=133930
Reviewed by Sam Weinig.
- Shared/NavigationActionData.cpp:
(WebKit::NavigationActionData::NavigationActionData): Initialize new member canHandleRequest
to false.
(WebKit::NavigationActionData::encode): Encode canHandleRequest.
(WebKit::NavigationActionData::decode): Decode it.
- Shared/NavigationActionData.h: Declared new boolean member canHandleRequest.
- UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction _initWithNavigationActionData:]): Set new ivar _canHandleRequest from
the action data.
(-[WKNavigationAction _canHandleRequest]): Added this getter.
- UIProcess/API/Cocoa/WKNavigationActionPrivate.h: Declared new property _canHandleRequest.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow): Set canHandleRequest in the NavigationActionData.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto.
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
- 6:45 PM Changeset in webkit [169997] by
-
- 10 edits in trunk
[EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
https://bugs.webkit.org/show_bug.cgi?id=133841
Reviewed by Gyuyoung Kim.
Source/WebKit2:
Ewk_Settings object is a member of Ewk_Page_Group.
So, Ewk_Page_Group is better place for the getter of Ewk_Settings.
- UIProcess/API/efl/ewk_page_group.cpp:
(ewk_page_group_settings_get): Added instead of ewk_view_settings_get.
- UIProcess/API/efl/ewk_page_group.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_settings_get): Deleted.
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_page_group.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F): Deleted.
Tools:
- MiniBrowser/efl/main.c:
(window_create):
- 4:38 PM Changeset in webkit [169996] by
-
- 2 edits in trunk/Tools
Set the svn:ignore property on an Xcode project to ignore user and workspace data.
- jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
- 4:16 PM Changeset in webkit [169995] by
-
- 14 edits in trunk/Source
Add an autorelease() member function to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=133929
Reviewed by Dan Bernstein.
Source/WebCore:
- bindings/objc/DOM.mm:
(-[DOMNode renderedImage]):
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
- bindings/objc/DOMUIKitExtensions.mm:
(-[DOMHTMLImageElement dataRepresentation:]):
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):
Source/WebKit/mac:
- WebView/WebDataSource.mm:
(-[WebDataSource data]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _selectionDraggingImage]):
(-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
- WebView/WebResource.mm:
(-[WebResource data]):
Source/WebKit2:
- Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(-[_WKRemoteObjectRegistry remoteObjectProxyWithInterface:]):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView navigationDelegate]):
(-[WKWebView UIDelegate]):
(-[WKWebView loadRequest:]):
(-[WKWebView loadHTMLString:baseURL:]):
(-[WKWebView goToBackForwardListItem:]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _historyDelegate]):
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
(WebKit::animationValueFromKeyframeValue):
Source/WTF:
- wtf/RetainPtr.h:
- 1:50 PM Changeset in webkit [169994] by
-
- 5 edits in trunk/Source/WebKit2
Get rid of VoidAPICallback
https://bugs.webkit.org/show_bug.cgi?id=133928
Reviewed by Sam Weinig.
- UIProcess/API/C/WKPage.cpp:
(WKPageForceRepaint): Wrap the API callback in a generic callback here.
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerClearSiteData): Ditto.
(WKPluginSiteDataManagerClearAllSiteData): Ditto.
- UIProcess/GenericCallback.h:
(WebKit::GenericCallback::performCallback): Added this helper for 0-argument callbacks.
(WebKit::VoidCallback::create): Deleted.
(WebKit::VoidCallback::~VoidCallback): Deleted.
(WebKit::VoidCallback::performCallback): Deleted.
(WebKit::VoidCallback::invalidate): Deleted.
(WebKit::VoidCallback::VoidCallback): Deleted.
(WebKit::VoidAPICallback::create): Deleted.
- UIProcess/mac/WKFullScreenWindowController.h:
- 12:35 PM Changeset in webkit [169993] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for the GTK+ port after r169990.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetState): Pass the error value to
the rest of invalidateCallbackMap calls.
- 12:12 PM Changeset in webkit [169992] by
-
- 2 edits in trunk/Tools
Fix build.
- TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
(callRunJavaScriptBlockAndRelease):
(runJavaScriptInMainFrame):
(TEST_F):
- 11:23 AM Changeset in webkit [169991] by
-
- 3 edits in trunk/Source/WebKit2
Remove WKPageRunJavaScriptInMainFrame_b
https://bugs.webkit.org/show_bug.cgi?id=133926
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKPage.cpp:
(callRunJavaScriptBlockAndRelease): Deleted.
(WKPageRunJavaScriptInMainFrame_b): Deleted.
- UIProcess/API/C/WKPage.h:
- 11:07 AM Changeset in webkit [169990] by
-
- 12 edits in trunk/Source/WebKit2
invalidateCallbackMap doesn’t pass the error parameter on to invalidate(), so script completion handler is passed the wrong error
https://bugs.webkit.org/show_bug.cgi?id=133921
<rdar://problem/17316653>
Reviewed by Dan Bernstein.
- UIProcess/GenericCallback.h:
(WebKit::VoidCallback::performCallback):
(WebKit::VoidCallback::invalidate):
(WebKit::VoidAPICallback::create):
(WebKit::invalidateCallbackMap):
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::invalidate):
(WebKit::WebPluginSiteDataManager::clearSiteData):
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::contextDestroyed):
(WebKit::WebApplicationCacheManagerProxy::processDidClose):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::contextDestroyed):
(WebKit::WebCookieManagerProxy::processDidClose):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::contextDestroyed):
(WebKit::WebDatabaseManagerProxy::processDidClose):
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::contextDestroyed):
(WebKit::WebMediaCacheManagerProxy::processDidClose):
- UIProcess/WebOriginDataManagerProxy.cpp:
(WebKit::WebOriginDataManagerProxy::contextDestroyed):
(WebKit::WebOriginDataManagerProxy::processDidClose):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::contextDestroyed):
(WebKit::WebResourceCacheManagerProxy::processDidClose):
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController dealloc]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
- 9:33 AM Changeset in webkit [169989] by
-
- 4 edits in trunk/Source/WebCore
Adopt HTTPHeaderName in ResourceResponseBase
https://bugs.webkit.org/show_bug.cgi?id=133919
Reviewed by Sam Weinig.
- platform/network/HTTPHeaderNames.in:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::updateHeaderParsedState):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::addHTTPHeaderField):
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::ResourceResponseBase::hasCacheValidatorFields):
(WebCore::parseDateValueInHeader):
(WebCore::ResourceResponseBase::date):
(WebCore::ResourceResponseBase::age):
(WebCore::ResourceResponseBase::expires):
(WebCore::ResourceResponseBase::lastModified):
(WebCore::ResourceResponseBase::isAttachment):
- platform/network/ResourceResponseBase.h:
- 4:04 AM Changeset in webkit [169988] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for the GTK+ port after r169987.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_can_execute_editing_command): The first passed-in parameter
is now a reference to a const String object.
Jun 14, 2014:
- 7:10 PM Changeset in webkit [169987] by
-
- 5 edits in trunk/Source/WebKit2
Replace StringImpl* callback parameters with const String&
https://bugs.webkit.org/show_bug.cgi?id=133922
Reviewed by Sam Weinig.
- UIProcess/API/C/WKPage.cpp:
(toGenericCallbackFunction): Added this helper function to wrap a WKStringRef-returning
API callback in a generic const String&-returning callback.
(WKPageRenderTreeExternalRepresentation):
(WKPageGetSourceForFrame):
(WKPageGetContentsAsString):
(WKPageGetBytecodeProfile):
(WKPageValidateCommand):
- UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
(-[WKView startSpeaking:]):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _define:]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
- 5:07 PM Changeset in webkit [169986] by
-
- 2 edits in trunk/Source/WebKit2
Additional iOS build fix.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _define:]):
(selectionChangedWithGesture):
(selectionChangedWithTouch):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
- 4:32 PM Changeset in webkit [169985] by
-
- 2 edits in trunk/Source/WebKit2
iOS build fix.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
- 4:11 PM Changeset in webkit [169984] by
-
- 14 edits in trunk/Source/WebKit2
Get rid of GenericAPICallback
https://bugs.webkit.org/show_bug.cgi?id=133909
Reviewed by Sam Weinig.
In preparation for passing callbacks as functions, replace GenericAPICallback::create, which
returned a GenericCallback, with a function template that returns an appropriate callback
function.
- UIProcess/API/C/WKApplicationCacheManager.cpp:
(WKApplicationCacheManagerGetApplicationCacheOrigins):
- UIProcess/API/C/WKContext.cpp:
(WKContextGetStatistics):
(WKContextGetStatisticsWithOptions):
- UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerGetHostnamesWithCookies):
(WKCookieManagerGetHTTPCookieAcceptPolicy):
- UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerGetDatabasesByOrigin):
(WKDatabaseManagerGetDatabaseOrigins):
- UIProcess/API/C/WKFrame.cpp:
(WKFrameGetMainResourceData):
(WKFrameGetResourceData):
(WKFrameGetWebArchive):
- UIProcess/API/C/WKKeyValueStorageManager.cpp:
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):
- UIProcess/API/C/WKMediaCacheManager.cpp:
(WKMediaCacheManagerGetHostnamesWithMediaCache):
- UIProcess/API/C/WKOriginDataManager.cpp:
(WKOriginDataManagerGetOrigins):
- UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame):
(WKPageRenderTreeExternalRepresentation):
(WKPageGetSourceForFrame):
(WKPageGetContentsAsString):
(WKPageGetBytecodeProfile):
(WKPageGetSelectionAsWebArchiveData):
(WKPageGetContentsAsMHTMLData):
(WKPageDrawPagesToPDF):
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerGetSitesWithData):
- UIProcess/API/C/WKResourceCacheManager.cpp:
(WKResourceCacheManagerGetCacheOrigins):
- UIProcess/GenericCallback.h:
(WebKit::toGenericCallbackFunction): Added. Given a C SPI callback function, returns a generic
callback function that wraps it.
- 3:44 PM Changeset in webkit [169983] by
-
- 2 edits in trunk/Source/WebKit2
Reverted the last change, which broken the Mac build.
- UIProcess/GenericCallback.h:
(WebKit::invalidateCallbackMap):
- 2:59 PM Changeset in webkit [169982] by
-
- 2 edits in trunk/Source/WebKit2
Tried to fix the GTK build.
- UIProcess/GenericCallback.h:
(WebKit::invalidateCallbackMap):
- 2:35 PM Changeset in webkit [169981] by
-
- 2 edits in trunk/Source/WebCore
Simplify ResourceRequest constructors
https://bugs.webkit.org/show_bug.cgi?id=133911
Reviewed by Sam Weinig.
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
- 1:57 PM Changeset in webkit [169980] by
-
- 2 edits in trunk/Source/WebCore
Fix the ARM64 build
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
- 1:38 PM Changeset in webkit [169979] by
-
- 12 edits in trunk/Source
Store DOM constants directly in the JS object rather than jumping through a custom accessor
https://bugs.webkit.org/show_bug.cgi?id=133898
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- runtime/Lookup.h:
(JSC::HashTableValue::attributes):
Switch attributes to be stored as an unsigned rather than an unsigned char, since there is no difference in memory use
and will make adding more flags possibles.
(JSC::HashTableValue::propertyGetter):
(JSC::HashTableValue::propertyPutter):
Change assertion to use BuiltinOrFunctionOrConstant.
(JSC::HashTableValue::constantInteger):
Added.
(JSC::getStaticPropertySlot):
(JSC::getStaticValueSlot):
Use PropertySlot::setValue() for constants during static lookup.
(JSC::reifyStaticProperties):
Put the constant directly on the object when eagerly reifying.
- runtime/PropertySlot.h:
Add ConstantInteger flag and BuiltinOrFunctionOrConstant helper.
Source/WebCore:
Instead of implementing constants as custom accessors that just happen to return a value,
we now store the constant directly in the HashTableValue array (where the GetValueFunc used
to be).
- For the case where the constant is accessed via the static table (still in use for instances and some prototypes), the static lookup function will set the value on the property slot, instead of passing a function pointer.
- For the case where the constant is eagerly reified (most prototypes and all constructors) the constant is put directly in the object.
In micro benchmarks this looks to be around a 4x speedup on the use of DOM constants.
This also removes support for constant strings in IDL, which we had no uses of.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
Remove code to generate forward declaration of constant accessor functions.
(GenerateImplementation):
Remove code to generate implementation of constant accessor functions.
(GenerateHashTableValueArray):
Plant the constant directly in the value array.
- bindings/scripts/IDLParser.pm:
(parseConstValue):
Remove support for constant strings.
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/TestObj.idl:
Update test results.
- 1:33 PM Changeset in webkit [169978] by
-
- 3 edits in trunk/Source/WebCore
Simplify Document::processHttpEquiv
https://bugs.webkit.org/show_bug.cgi?id=133910
Reviewed by Andreas Kling.
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- platform/network/HTTPHeaderNames.in:
- 12:39 PM Changeset in webkit [169977] by
-
- 2 edits in trunk/Source/WebCore
GCController should return FastMalloc memory to the system.
<https://webkit.org/b/133884>
Reviewed by Anders Carlsson.
Speculative test fix; I'm kinda suspecting that some tests are reporting
more memory used because we did a GC but didn't get around to returning
free pages to the system yet.
- bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectNow):
- 12:13 PM Changeset in webkit [169976] by
-
- 4 edits in trunk/Source/WebCore
Generate HTTP header names that are required by WebKitWebSrc
https://bugs.webkit.org/show_bug.cgi?id=133906
Reviewed by Anders Carlsson.
WebKitWebSrc implementation sets icy-metadata and transferMode.dlna HTTP headers
on ResourceRequest objects. The two headers are added to HTTPHeaderNames.in, and
a small tweak is added to the generator script to avoid the dot in the second
header's name (which would otherwise generate invalid C++).
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart):
- platform/network/HTTPHeaderNames.in:
- platform/network/create-http-header-name-table:
- 12:10 PM Changeset in webkit [169975] by
-
- 5 edits in trunk/Source/WebCore
Replace some uses of ResourceRequestBase::addHTTPHeaderField with setHTTPHeaderField
https://bugs.webkit.org/show_bug.cgi?id=133907
Reviewed by Andreas Kling.
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeRequest):
- platform/network/HTTPHeaderNames.in:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::applyBasicAuthorizationHeader):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::applyBasicAuthorizationHeader):
- 10:49 AM Changeset in webkit [169974] by
-
- 15 edits in trunk/Source/WebCore
Add a ResourceRequestBase::setHTTPHeaderField overload that takes a HTTPHeaderName
https://bugs.webkit.org/show_bug.cgi?id=133881
Reviewed by Sam Weinig.
- WebCore.exp.in:
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
- loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::addExtraFieldsToRequest):
- loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- page/EventSource.cpp:
(WebCore::EventSource::connect):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::doStart):
- platform/network/HTTPHeaderNames.in:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::httpHeaderField):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::httpContentType):
(WebCore::ResourceRequestBase::setHTTPContentType):
(WebCore::ResourceRequestBase::httpReferrer):
(WebCore::ResourceRequestBase::setHTTPReferrer):
(WebCore::ResourceRequestBase::httpOrigin):
(WebCore::ResourceRequestBase::setHTTPOrigin):
(WebCore::ResourceRequestBase::httpUserAgent):
(WebCore::ResourceRequestBase::setHTTPUserAgent):
(WebCore::ResourceRequestBase::httpAccept):
(WebCore::ResourceRequestBase::setHTTPAccept):
- platform/network/ResourceRequestBase.h:
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest):
- 10:43 AM Changeset in webkit [169973] by
-
- 6 edits in trunk/Source/JavaScriptCore
operationCreateArguments could cause a GC during OSR exit
https://bugs.webkit.org/show_bug.cgi?id=133905
Reviewed by Filip Pizlo.
Defer GC via new wrapper functions for operationCreateArguments and operationCreateInlinedArguments
for use by OSR exit stubs.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::ArgumentsRecoveryGenerator::generateFor):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- 10:40 AM Changeset in webkit [169972] by
-
- 5 edits6 adds in trunk
Masks disappear when layers become tiled
https://bugs.webkit.org/show_bug.cgi?id=133892
<rdar://problem/17309793>
Reviewed by Tim Horton.
Source/WebCore:
There were several problems with tiled mask layers.
First, when a layer became tiled it failed to re-apply the platform layer
for its mask; fixed by adding MaskLayerChanged to the set of flags in
swapFromOrToTiledLayer().
Secondly, in CA, a mask layer's superlayer is the layer which is it masking,
so the if (oldLayer->superlayer())... code in swapFromOrToTiledLayer() would
erroneously try to swap out a sublayer on the superlayer with the mask.
Thirdly, the mask layer is updated after its host layer, but when the mask layer
become tiled, there was no code that updated the mask platform layer on its
host layer. Fix by:
- setting a bit on a layer to note that it's being used as a mask.
- setting the parent of such a layer to its host layer (mimicking CA)
- when the mask becomes tiled, dirtying the MaskLayerChanged bit on its parent and adding a clause to commitLayerChangesAfterSublayers() to update the mask layer.
Finally, ASSERTION FAILED: owningGraphicsLayer()->isCommittingChanges() would
fire because we failed to set the m_isCommittingChanges flag while committing
the mask layer. Fix by moving the TemporaryChange<bool> that sets this flag
into commitLayerChangesBeforeSublayers() and commitLayerChangesAfterSublayers().
Also used safe casts in more places in GraphicsLayerCA.
Tests: compositing/masks/become-tiled-mask.html
compositing/masks/cease-tiled-mask.html
compositing/masks/tiled-mask.html
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::removeFromParent):
(WebCore::GraphicsLayer::setMaskLayer):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setIsMaskLayer):
(WebCore::GraphicsLayer::isMaskLayer):
(WebCore::GraphicsLayer::setMaskLayer): Deleted.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::removeFromParent):
(WebCore::GraphicsLayerCA::setMaskLayer):
(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::commitLayerChangesAfterSublayers):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::replicatedLayerRoot):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::propagateLayerChangeToReplicas):
(WebCore::GraphicsLayerCA::fetchCloneLayers):
LayoutTests:
Tests for masking as they go into and out of tiled mode.
- compositing/masks/become-tiled-mask-expected.html: Added.
- compositing/masks/become-tiled-mask.html: Added.
- compositing/masks/cease-tiled-mask-expected.html: Added.
- compositing/masks/cease-tiled-mask.html: Added.
- compositing/masks/tiled-mask-expected.html: Added.
- compositing/masks/tiled-mask.html: Added.
- 10:12 AM Changeset in webkit [169971] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- UIProcess/API/mac/WKView.mm:
(-[WKView selectedRangeWithCompletionHandler:]):
(-[WKView markedRangeWithCompletionHandler:]):
(-[WKView hasMarkedTextWithCompletionHandler:]):
(-[WKView attributedSubstringForProposedRange:completionHandler:]):
(-[WKView firstRectForCharacterRange:completionHandler:]):
(-[WKView characterIndexForPoint:completionHandler:]):
- 9:06 AM Changeset in webkit [169970] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Compile errors related to http headers.
https://bugs.webkit.org/show_bug.cgi?id=133901
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-06-14
Reviewed by Brent Fulgham.
Http headers should now be specified with an enum, not a string.
- platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::parseResponseHeaders):
- platform/network/curl/MultipartHandle.cpp:
(WebCore::MultipartHandle::didReceiveResponse):
- 8:53 AM Changeset in webkit [169969] by
-
- 4 edits in trunk/Source/WebKit2
Unreviewed build fix for the GTK+ port.
Fixing the callback lambda parameters after r169962.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationPrintPagesForFrame):
- UIProcess/API/gtk/WebKitWebResource.cpp:
(webkit_web_resource_get_data):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):
(webkit_web_view_save):
(webkit_web_view_save_to_file):
- 8:43 AM Changeset in webkit [169968] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r169960.
- platform/graphics/ca/PlatformCALayer.cpp: Add missing include
for snprintf on Windows.
- 3:18 AM Changeset in webkit [169967] by
-
- 2 edits in trunk
[EFL] Remove duplicated compiler flag
https://bugs.webkit.org/show_bug.cgi?id=133838
Reviewed by Anders Carlsson.
In r169798, literal-suffix was added for EFL port in order to fix build break. However,
it added to common compiler options. So, it is duplicated.
- Source/cmake/WebKitHelpers.cmake:
- 2:04 AM Changeset in webkit [169966] by
-
- 6 edits in trunk/Source
Source/WebCore: URTBF after r169943 and r169946.
- platform/network/HTTPHeaderMap.h: Removed maybe accidental deletion of the only one add function.
- platform/network/HTTPHeaderNames.in: Added Sec-WebSocket-Key.
Source/WebKit2: URTBF after r169943 and r169946, use the format of set/get.
- UIProcess/InspectorServer/WebInspectorServer.cpp:
(WebKit::WebInspectorServer::didReceiveUnrecognizedHTTPRequest):
- UIProcess/InspectorServer/WebSocketServerConnection.cpp:
(WebKit::WebSocketServerConnection::readHTTPMessage):
(WebKit::WebSocketServerConnection::upgradeToWebSocketServerConnection):
- 1:01 AM Changeset in webkit [169965] by
-
- 20 edits10 deletes in trunk
Unreviewed, rolling out r169963.
https://bugs.webkit.org/show_bug.cgi?id=133899
Assertion in mathml/roots-removeChild.html (Requested by fredw
on #webkit).
Reverted changeset:
"Draw radicals with glyphs for better rendering"
https://bugs.webkit.org/show_bug.cgi?id=119038
http://trac.webkit.org/changeset/169963
Patch by Commit Queue <commit-queue@webkit.org> on 2014-06-14
Jun 13, 2014:
- 11:31 PM Changeset in webkit [169964] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r167635): Reference leak in NetworkResourceLoader while loads are being deferred.
<https://webkit.org/b/133894>
<rdar://problem/17312299>
Don't self-ref() in start() until we actually start; if page loads are being
deferred, start() will be called again once deferral stops.
This was causing us to leak the entire NetworkResourceLoader object graph.
Reviewed by Brady Eidson.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::start):
- 11:18 PM Changeset in webkit [169963] by
-
- 20 edits10 adds in trunk
Draw radicals with glyphs for better rendering
https://bugs.webkit.org/show_bug.cgi?id=119038
Reviewed by Chris Fleizach.
Source/WebCore:
We rewrite RenderMathMLRoot in order to fix bugs with SVG transforms and dynamic modification of children and allow drawing with an OpenType MATH table.
The drawing of the radical sign (without the top bar) is now moved to a RenderMathMLRadicalOperator class inheriting from RenderMathMLOperator.
This class fallbacks to the original drawing with graphic primitives if an OpenType MATH table is not available.
Tests: mathml/opentype/roots-LatinModern.html
mathml/presentation/mroot-transform.html
- CMakeLists.txt: add files to build system.
- WebCore.vcxproj/WebCore.vcxproj: ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto
- css/mathml.css: remove rules for msqrt/mroot. The "script level" in mroot is not incremented by 2 as specified in the spec.
(math, mrow, mfenced, merror, mphantom, mstyle, menclose):
(mroot > *:last-child):
(math, mrow, mfenced, msqrt, mroot, merror, mphantom, mstyle, menclose): Deleted.
(msqrt > *): Deleted.
(mroot): Deleted. This rule was causing bug 126516.
(mroot > * + *): Deleted.
- rendering/RenderObject.h: Add two new isRenderMathML* functions for dynamic casting.
(WebCore::RenderObject::isRenderMathMLRadicalOperator):
(WebCore::RenderObject::isRenderMathMLRootWrapper):
- rendering/mathml/RenderMathMLOperator.cpp: Accept a set of operator dictionary flags, all disabled by default. This is to allow anonymous radicas, which don't have any flag.
isFencedOperator() is now replaced with the more general isAnonymous() since we allow anonymous radical operator fors msqrt/mroot.
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute):
(WebCore::RenderMathMLOperator::setOperatorPropertiesFromOpDictEntry):
(WebCore::RenderMathMLOperator::SetOperatorProperties):
(WebCore::RenderMathMLOperator::updateTokenContent):
- rendering/mathml/RenderMathMLOperator.h: Allow class to be overriden, redefine the anonymous constructor, remove isFencedOperator().
- rendering/mathml/RenderMathMLRadicalOperator.cpp: Added.
(WebCore::RenderMathMLRadicalOperator::RenderMathMLRadicalOperator):
(WebCore::RenderMathMLRadicalOperator::stretchTo):
(WebCore::RenderMathMLRadicalOperator::SetOperatorProperties):
(WebCore::RenderMathMLRadicalOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLRadicalOperator::computeLogicalHeight):
(WebCore::RenderMathMLRadicalOperator::paint):
(WebCore::RenderMathMLRadicalOperator::trailingSpaceError):
- rendering/mathml/RenderMathMLRadicalOperator.h: Added.
- rendering/mathml/RenderMathMLRoot.cpp: Rewritten. Some parts to use graphic primitives are moved to RenderMathMLRadicalOperator.cpp.
(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::baseWrapper):
(WebCore::RenderMathMLRoot::radicalWrapper):
(WebCore::RenderMathMLRoot::indexWrapper):
(WebCore::RenderMathMLRoot::radicalOperator):
(WebCore::RenderMathMLRoot::restructureWrappers):
(WebCore::RenderMathMLRoot::addChild):
(WebCore::RenderMathMLRoot::styleDidChange):
(WebCore::RenderMathMLRoot::updateFromElement):
(WebCore::RenderMathMLRoot::updateStyle):
(WebCore::RenderMathMLRoot::firstLineBaseline):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRootWrapper::createAnonymousWrapper):
(WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring):
(WebCore::RenderMathMLRootWrapper::removeChild):
(WebCore::RenderMathMLRoot::paddingTop): Deleted.
(WebCore::RenderMathMLRoot::paddingBottom): Deleted.
(WebCore::RenderMathMLRoot::paddingLeft): Deleted.
(WebCore::RenderMathMLRoot::paddingRight): Deleted.
(WebCore::RenderMathMLRoot::paddingBefore): Deleted.
(WebCore::RenderMathMLRoot::paddingAfter): Deleted.
(WebCore::RenderMathMLRoot::paddingStart): Deleted.
(WebCore::RenderMathMLRoot::paddingEnd): Deleted.
(WebCore::RenderMathMLRoot::index): Deleted.
- rendering/mathml/RenderMathMLRoot.h: Rewritten.
(WebCore::RenderMathMLRootWrapper::RenderMathMLRootWrapper):
LayoutTests:
We update the reference for some tests with radicals and enable the tests for addition/removal of children in an msqrt/mroot element.
We also add a test for bug 126516 (SVG transforms not applied to mroot) and a new test for radical drawing using an OpenType MATH table.
- TestExpectations: enable the tests for addition/removal of children.
- mathml/opentype/roots-LatinModern.html: Added.
- mathml/presentation/mroot-transform-expected.html: Added.
- mathml/presentation/mroot-transform.html: Added.
- platform/efl/TestExpectations: mark failures for bad references.
- platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Added.
- platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Added.
- platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Added.
- platform/gtk/mathml/presentation/mo-stretch-expected.png: update reference.
- platform/gtk/mathml/presentation/mo-stretch-expected.txt: update reference.
- platform/gtk/mathml/presentation/roots-expected.png: update reference.
- platform/gtk/mathml/presentation/roots-expected.txt: update reference.
- platform/mac/TestExpectations: mark failures for bad references.
- platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Added.
- platform/win/TestExpectations: mark failures for bad references.
- platform/win/mathml/opentype/roots-LatinModern-expected.txt: Added.
- 10:32 PM Changeset in webkit [169962] by
-
- 10 edits in trunk/Source/WebKit2
Make GenericCallback variadic
https://bugs.webkit.org/show_bug.cgi?id=133897
Reviewed by Sam Weinig.
Also eliminated legacy callback functions and all CallbackBase derived classes outside of
GenericCallback.h.
- UIProcess/API/C/WKPage.cpp:
(WKPageValidateCommand): Changed legacy callback (with leading bool parameter) into modern
callback (with trailing error parameter).
(WKPageComputePagesForPrinting): Ditto.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _getWebArchiveDataWithCompletionHandler:]): Ditto.
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]): Ditto.
- UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView _requestSnapshotIfNeeded]): Ditto.
- UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]): Ditto.
(-[WKView startSpeaking:]): Ditto.
- UIProcess/AutoCorrectionCallback.h: Replaced CallbackBase derived classes with
GenericCallback specializations.
- UIProcess/GenericCallback.h:
- Made GenericCallback variadic:
(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::invalidate):
(WebKit::GenericAPICallback::create):
- Replaced CallbackBase derived classes with GenericCallback specializations:
(WebKit::GenericCallback::create): Deleted.
(WebKit::ComputedPagesCallback::create): Deleted.
(WebKit::ComputedPagesCallback::~ComputedPagesCallback): Deleted.
(WebKit::ComputedPagesCallback::performCallbackWithReturnValue): Deleted.
(WebKit::ComputedPagesCallback::invalidate): Deleted.
(WebKit::ComputedPagesCallback::ComputedPagesCallback): Deleted.
(WebKit::ImageCallback::create): Deleted.
(WebKit::ImageCallback::~ImageCallback): Deleted.
(WebKit::ImageCallback::performCallbackWithReturnValue): Deleted.
(WebKit::ImageCallback::invalidate): Deleted.
(WebKit::ImageCallback::ImageCallback): Deleted.
- UIProcess/WebPageProxy.h: Replaced CallbackBase derived classes with GenericCallback
specializations.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]): Changed
legacy callback (with leading bool parameter) into modern callback (with trailing error
parameter).
(-[WKContentView requestDictationContext:]): Ditto.
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]): Ditto.
- UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Ditto.
(-[WKPrintingView _askPageToComputePageRects]): Ditto.
(-[WKPrintingView _drawPreview:]): Ditto.
- 10:09 PM Changeset in webkit [169961] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed; fix the build.
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):
- 7:59 PM Changeset in webkit [169960] by
-
- 9 edits in trunk/Source/WebCore
Move utility functions from WebLayer to PlatformCALayer
https://bugs.webkit.org/show_bug.cgi?id=133887
<rdar://problem/17309622>
Reviewed by Simon Fraser.
Move some utility functions from WebLayer.h/.mm to PlatformCALayer.
Provide ObjC implementation in PlatformCALayerMac. A future patch will
provide corresponding Windows versions.
- WebCore.exp.in:
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::drawRepaintIndicator):
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/TileController.cpp:
(WebCore::TileController::blankPixelCountForTiles):
- platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::platformCALayerPaintContents):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::collectRectsToPaint):
(PlatformCALayer::drawLayerContents):
(PlatformCALayer::frameForLayer):
- platform/graphics/mac/WebLayer.h:
- platform/graphics/mac/WebLayer.mm:
(-[WebLayer drawInContext:]):
(WebCore::collectRectsToPaint): Deleted.
(WebCore::drawLayerContents): Deleted.
(WebCore::drawRepaintIndicator): Deleted.
(WebCore::frameForLayer): Deleted.
- 5:35 PM Changeset in webkit [169959] by
-
- 4 edits in trunk/Source
Unreviewed disabling css jit on armv7. It's not quite ready yet.
Source/WebCore:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Removed extra comma.
Source/WTF:
- wtf/Platform.h:
Disable css jit on armv7.
- 5:18 PM Changeset in webkit [169958] by
-
- 2 edits in trunk/Source/WTF
Enable css jit for armv7 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=133890
<rdar://problem/17310631>
Reviewed by Andreas Kling.
- wtf/Platform.h:
Enable css jit for ARM thumb on iOS.
- 5:04 PM Changeset in webkit [169957] by
-
- 2 edits in trunk/Source/WebKit2
Clean up layers in RemoteLayerTreeHost::clearLayers().
https://bugs.webkit.org/show_bug.cgi?id=133888
Reviewed by Tim Horton.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::clearLayers):
- 4:37 PM CommitterTips edited by
- (diff)
- 4:37 PM Changeset in webkit [169956] by
-
- 2 edits in trunk/Source/WebCore
Make css jit compile on armv7.
https://bugs.webkit.org/show_bug.cgi?id=133889
Reviewed by Benjamin Poulain.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::moduloHelper):
(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Implement modulo using a function call for now.
- 4:01 PM Changeset in webkit [169955] by
-
- 5 edits in trunk/Source/WebCore
Use the callOnMainThread version that takes an std::function in BlobResourceHandle::start()
https://bugs.webkit.org/show_bug.cgi?id=133886
Reviewed by Andreas Kling.
Also replace a couple of NSAutoreleasePools with @autoreleasepool and an OwnPtr with an std::unique_ptr.
- page/scrolling/mac/ScrollingThreadMac.mm:
(WebCore::ScrollingThread::threadRunLoopSourceCallback):
- platform/mac/SharedTimerMac.mm:
(WebCore::PowerObserver::PowerObserver):
(WebCore::timerFired):
(WebCore::setSharedTimerFireInterval):
(WebCore::PowerObserver::create): Deleted.
(WebCore::PowerObserver::didReceiveSystemPowerNotification): Deleted.
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::start):
(WebCore::delayedStartBlobResourceHandle): Deleted.
- platform/network/BlobResourceHandle.h:
- 3:52 PM Changeset in webkit [169954] by
-
- 36 edits in trunk/Source/WebCore
Constructors should eagerly reify their properties too
https://bugs.webkit.org/show_bug.cgi?id=133822
Reviewed by Andreas Kling.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
Constructors should never need to use the lazy property HashTable, so we can just
remove its getOwnPropertySlot completely.
(ConstructorHasProperties):
Add helper to determine if we need to reify any properties.
(GenerateConstructorHelperMethods):
Reify if needed, and remove the implementation of getOwnPropertySlot.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.h:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSattribute.h:
- bindings/scripts/test/JS/JSreadonly.cpp:
- bindings/scripts/test/JS/JSreadonly.h:
Update tests.
- 3:26 PM Changeset in webkit [169953] by
-
- 3 edits in trunk/Source/WebCore
Make css jit allocator smarter.
https://bugs.webkit.org/show_bug.cgi?id=133834
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-13
Reviewed by Benjamin Poulain.
- cssjit/RegisterAllocator.h:
(WebCore::RegisterAllocator::allocateRegister):
(WebCore::RegisterAllocator::deallocateRegister):
(WebCore::RegisterAllocator::reserveCalleeSavedRegisters):
(WebCore::LocalRegister::LocalRegister):
(WebCore::RegisterAllocator::RegisterAllocator):
Use a Deque for the registers. Allocate from the front and deallocate to the back to cycle the register usage.
(WebCore::RegisterAllocator::allocateRegisterWithPreference):
(WebCore::LocalRegisterWithPreference::LocalRegisterWithPreference):
Added the ability to specify that we prefer a certain register if it is available while allocating.
These functions always return a register. It is just a different register than preferred if the preferred register is not available.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueExactMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeFunctionCallValueMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
Whenever we are allocating a register for the second argument, we should specify that we
prefer to have argumentGPR1 to reduce register swapping when preparing for a function call.
This cannot be done for argumentGPR0 because elementAddressRegister is argumentGPR0 and it is always allocated.
- 3:24 PM Changeset in webkit [169952] by
-
- 3 edits in trunk/Source/WebCore
set setUsesExternalPlaybackWhileExternalScreenIsActive based on fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=133829
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-13
Reviewed by Eric Carlson.
When playing inline and external screen is active, don't use external playback.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
declare updateDisableExternalPlayback()
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
call updateDisableExternalPlayback when player is created
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer):
call updateDisableExternalPlayback when fullscreen mode changes
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateDisableExternalPlayback):
update setUsesExternalPlaybackWhileExternalScreenIsActive based on fullscreen mode
- 3:18 PM Changeset in webkit [169951] by
-
- 4 edits in trunk/Source
OSR exit should barrier the Executables for all InlineCallFrames, not just those on the stack at the time of exit
https://bugs.webkit.org/show_bug.cgi?id=133880
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
We could have exited due to a value received from an inlined block that's no longer on
the stack, so we should just barrier all InlineCallFrames.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::adjustAndJumpToTarget):
Source/WTF:
- wtf/Bag.h:
(WTF::Bag::iterator::operator!=): Add != to the Bag iterator so we can use it in range-based iteration.
- 2:49 PM Changeset in webkit [169950] by
-
- 20 edits8 adds2 deletes in branches/ftlopt
[ftlopt] A DFG inlined ById access variant should not speak of a chain, but only of what structures to test the base for, whether to use a constant as an alternate base for the actual access, and what structures to check on what additional cell constants
https://bugs.webkit.org/show_bug.cgi?id=133821
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
This allows us to efficiently cache accesses that differ only in the prototypes on the path
from the base to the prototype that has the field.
It also simplifies a bunch of code - IntendedStructureChain is now just an intermediate
data structure.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/ConstantStructureCheck.cpp: Added.
(JSC::ConstantStructureCheck::dumpInContext):
(JSC::ConstantStructureCheck::dump):
(JSC::structureFor):
(JSC::areCompatible):
(JSC::mergeInto):
- bytecode/ConstantStructureCheck.h: Added.
(JSC::ConstantStructureCheck::ConstantStructureCheck):
(JSC::ConstantStructureCheck::operator!):
(JSC::ConstantStructureCheck::constant):
(JSC::ConstantStructureCheck::structure):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::GetByIdVariant):
(JSC::GetByIdVariant::operator=):
(JSC::GetByIdVariant::attemptToMerge):
(JSC::GetByIdVariant::dumpInContext):
- bytecode/GetByIdVariant.h:
(JSC::GetByIdVariant::constantChecks):
(JSC::GetByIdVariant::alternateBase):
(JSC::GetByIdVariant::GetByIdVariant): Deleted.
(JSC::GetByIdVariant::chain): Deleted.
- bytecode/PutByIdVariant.cpp:
(JSC::PutByIdVariant::dumpInContext):
- bytecode/PutByIdVariant.h:
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::constantChecks):
(JSC::PutByIdVariant::structureChain): Deleted.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::emitChecks):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::cellConstantWithStructureCheck): Deleted.
(JSC::DFG::ByteCodeParser::structureChainIsStillValid): Deleted.
(JSC::DFG::ByteCodeParser::emitPrototypeChecks): Deleted.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
- dfg/DFGDesiredStructureChains.cpp: Removed.
- dfg/DFGDesiredStructureChains.h: Removed.
- dfg/DFGGraph.h:
(JSC::DFG::Graph::watchpoints):
(JSC::DFG::Graph::chains): Deleted.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::isStillValid):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::cancel):
- dfg/DFGPlan.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::gatherChecks):
- runtime/IntendedStructureChain.h:
(JSC::IntendedStructureChain::at):
(JSC::IntendedStructureChain::operator[]):
LayoutTests:
- js/regress/poly-chain-access-different-prototypes-expected.txt: Added.
- js/regress/poly-chain-access-different-prototypes-simple-expected.txt: Added.
- js/regress/poly-chain-access-different-prototypes-simple.html: Added.
- js/regress/poly-chain-access-different-prototypes.html: Added.
- js/regress/script-tests/poly-chain-access-different-prototypes-simple.js: Added.
- js/regress/script-tests/poly-chain-access-different-prototypes.js: Added.
- 2:30 PM Changeset in webkit [169949] by
-
- 8 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Constant folding and strength reduction should work in SSA
https://bugs.webkit.org/show_bug.cgi?id=133839
Reviewed by Oliver Hunt.
- dfg/DFGAtTailAbstractState.cpp:
(JSC::DFG::AtTailAbstractState::AtTailAbstractState):
(JSC::DFG::AtTailAbstractState::forNode):
- dfg/DFGAtTailAbstractState.h:
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::convertToConstant):
- dfg/DFGIntegerCheckCombiningPhase.cpp:
(JSC::DFG::IntegerCheckCombiningPhase::rangeKeyAndAddend): Fix an unrelated regression that this uncovered.
- dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::LICMPhase):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- 2:13 PM Changeset in webkit [169948] by
-
- 2 edits4 moves in trunk/Source/WebCore
Convert LayerPool and TileCoverageMap from ObjC to C++
https://bugs.webkit.org/show_bug.cgi?id=133862
<rdar://problem/17302883>
Reviewed by Simon Fraser.
This just moves two ObjC files from the mac subdirectory to the parent and
revises the project to build them as C++.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/ca/LayerPool.cpp: Copied from platform/graphics/ca/mac/LayerPool.mm.
- platform/graphics/ca/LayerPool.h: Copied from platform/graphics/ca/mac/LayerPool.h.
- platform/graphics/ca/TileCoverageMap.cpp: Copied from platform/graphics/ca/mac/TileCoverageMap.mm.
- platform/graphics/ca/TileCoverageMap.h: Copied from platform/graphics/ca/mac/TileCoverageMap.h.
- platform/graphics/ca/mac/LayerPool.h: Removed.
- platform/graphics/ca/mac/LayerPool.mm: Removed.
- platform/graphics/ca/mac/TileCoverageMap.h: Removed.
- platform/graphics/ca/mac/TileCoverageMap.mm: Removed.
- 1:43 PM Changeset in webkit [169947] by
-
- 7 edits in trunk/Source
Make css jit compile for armv7.
https://bugs.webkit.org/show_bug.cgi?id=133596
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-13
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- assembler/MacroAssembler.h:
Use branchPtr on ARM_THUMB2.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::addPtrNoFlags):
(JSC::MacroAssemblerARMv7::or32):
(JSC::MacroAssemblerARMv7::test32):
(JSC::MacroAssemblerARMv7::branch):
(JSC::MacroAssemblerARMv7::branchPtr):
Added macros necessary for css jit.
Source/WebCore:
- cssjit/FunctionCall.h:
(WebCore::FunctionCall::swapArguments):
Implemented for ARM_THUMB2 and removed allocator hack.
- cssjit/RegisterAllocator.h:
Added list of ARM_THUMB2 general purpose registers.
(WebCore::RegisterAllocator::isValidRegister):
Added ARM register range and corrected ARM64 register range now that r15 is tempRegister.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
Return CannotCompile if compiling fails because of lack of registers.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateEpilogue):
Implemented for ARM_THUMB2.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Return false if the selector cannot be compiled because of lack of registers.
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
Added code using 32-bit operations and used macro assembler for 64-bit operations.
(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Implemented for APPLE_ARMV7S, where sdiv is not a template in the assembler.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributesMatching):
Use addPtr instead of add64.
- 1:37 PM Changeset in webkit [169946] by
-
- 9 edits in trunk/Source
Add a HTTPHeaderMap::get overload that takes an HTTPHeaderName
https://bugs.webkit.org/show_bug.cgi?id=133877
Reviewed by Andreas Kling.
Source/WebCore:
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::serverWebSocketProtocol):
(WebCore::WebSocketHandshake::serverSetCookie):
(WebCore::WebSocketHandshake::serverSetCookie2):
(WebCore::WebSocketHandshake::serverUpgrade):
(WebCore::WebSocketHandshake::serverConnection):
(WebCore::WebSocketHandshake::serverWebSocketAccept):
- WebCore.exp.in:
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::get):
- platform/network/HTTPHeaderMap.h:
- platform/network/HTTPHeaderNames.in:
- plugins/PluginView.cpp:
(WebCore::PluginView::handlePost):
Source/WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parsePostBuffer):
- 1:34 PM Changeset in webkit [169945] by
-
- 20 edits10 deletes in trunk
Unreviewed, rolling out r169939.
https://bugs.webkit.org/show_bug.cgi?id=133878
This patch raises assertions on mac (Requested by fredw on
#webkit).
Reverted changeset:
"Draw radicals with glyphs for better rendering"
https://bugs.webkit.org/show_bug.cgi?id=119038
http://trac.webkit.org/changeset/169939
Patch by Commit Queue <commit-queue@webkit.org> on 2014-06-13
- 12:54 PM Changeset in webkit [169944] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix ARMv7.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::abortWithReason):
- 12:35 PM Changeset in webkit [169943] by
-
- 6 edits in trunk/Source/WebCore
Add a HTTPHeaderMap::set overload that takes a HTTPHeaderName
https://bugs.webkit.org/show_bug.cgi?id=133874
Reviewed by Tim Horton.
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::set):
- platform/network/HTTPHeaderMap.h:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
- 11:56 AM Changeset in webkit [169942] by
-
- 8 edits in trunk/Source/JavaScriptCore
Even better diagnostics from DFG traps
https://bugs.webkit.org/show_bug.cgi?id=133836
Reviewed by Oliver Hunt.
We now stuff the DFG::NodeType into a register before bailing. Also made the
DFGBailed abort reason a bit more specific. As planned, the new abort reasons use
different numbers than any previous abort reasons.
- assembler/AbortReason.h:
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::abortWithReason):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::abortWithReason):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::abortWithReason):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::abortWithReason):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::bail):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT.h:
- 11:56 AM Changeset in webkit [169941] by
-
- 5 edits in trunk/Source/WebCore
Add a HTTPHeaderMap::find overload that takes a HTTPHeaderName
https://bugs.webkit.org/show_bug.cgi?id=133872
Reviewed by Andreas Kling.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::get):
(WebCore::HTTPHeaderMap::find):
- platform/network/HTTPHeaderMap.h:
- platform/network/HTTPHeaderNames.in:
- 11:48 AM Changeset in webkit [169940] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Added some flaky and failing tests to TestExpectations.
Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-06-13
- platform/gtk/TestExpectations:
- 11:14 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:08 AM Changeset in webkit [169939] by
-
- 20 edits10 adds in trunk
Draw radicals with glyphs for better rendering
https://bugs.webkit.org/show_bug.cgi?id=119038
Reviewed by Chris Fleizach.
Source/WebCore:
We rewrite RenderMathMLRoot in order to fix bugs with SVG transforms and dynamic modification of children and allow drawing with an OpenType MATH table.
The drawing of the radical sign (without the top bar) is now moved to a RenderMathMLRadicalOperator class inheriting from RenderMathMLOperator.
This class fallbacks to the original drawing with graphic primitives if an OpenType MATH table is not available.
Tests: mathml/opentype/roots-LatinModern.html
mathml/presentation/mroot-transform.html
- CMakeLists.txt: add files to build system.
- WebCore.vcxproj/WebCore.vcxproj: ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto
- css/mathml.css: remove rules for msqrt/mroot. The "script level" in mroot is not incremented by 2 as specified in the spec.
(math, mrow, mfenced, merror, mphantom, mstyle, menclose):
(mroot > *:last-child):
(math, mrow, mfenced, msqrt, mroot, merror, mphantom, mstyle, menclose): Deleted.
(msqrt > *): Deleted.
(mroot): Deleted. This rule was causing bug 126516.
(mroot > * + *): Deleted.
- rendering/RenderObject.h: Add two new isRenderMathML* functions for dynamic casting.
(WebCore::RenderObject::isRenderMathMLRadicalOperator):
(WebCore::RenderObject::isRenderMathMLRootWrapper):
- rendering/mathml/RenderMathMLOperator.cpp: Accept a set of operator dictionary flags, all disabled by default. This is to allow anonymous radicas, which don't have any flag.
isFencedOperator() is now replaced with the more general isAnonymous() since we allow anonymous radical operator fors msqrt/mroot.
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute):
(WebCore::RenderMathMLOperator::setOperatorPropertiesFromOpDictEntry):
(WebCore::RenderMathMLOperator::SetOperatorProperties):
(WebCore::RenderMathMLOperator::updateTokenContent):
- rendering/mathml/RenderMathMLOperator.h: Allow class to be overriden, redefine the anonymous constructor, remove isFencedOperator().
- rendering/mathml/RenderMathMLRadicalOperator.cpp: Added.
(WebCore::RenderMathMLRadicalOperator::RenderMathMLRadicalOperator):
(WebCore::RenderMathMLRadicalOperator::stretchTo):
(WebCore::RenderMathMLRadicalOperator::SetOperatorProperties):
(WebCore::RenderMathMLRadicalOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLRadicalOperator::computeLogicalHeight):
(WebCore::RenderMathMLRadicalOperator::paint):
(WebCore::RenderMathMLRadicalOperator::trailingSpaceError):
- rendering/mathml/RenderMathMLRadicalOperator.h: Added.
- rendering/mathml/RenderMathMLRoot.cpp: Rewritten. Some parts to use graphic primitives are moved to RenderMathMLRadicalOperator.cpp.
(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::baseWrapper):
(WebCore::RenderMathMLRoot::radicalWrapper):
(WebCore::RenderMathMLRoot::indexWrapper):
(WebCore::RenderMathMLRoot::radicalOperator):
(WebCore::RenderMathMLRoot::restructureWrappers):
(WebCore::RenderMathMLRoot::addChild):
(WebCore::RenderMathMLRoot::styleDidChange):
(WebCore::RenderMathMLRoot::updateFromElement):
(WebCore::RenderMathMLRoot::updateStyle):
(WebCore::RenderMathMLRoot::firstLineBaseline):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRootWrapper::createAnonymousWrapper):
(WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring):
(WebCore::RenderMathMLRootWrapper::removeChild):
(WebCore::RenderMathMLRoot::paddingTop): Deleted.
(WebCore::RenderMathMLRoot::paddingBottom): Deleted.
(WebCore::RenderMathMLRoot::paddingLeft): Deleted.
(WebCore::RenderMathMLRoot::paddingRight): Deleted.
(WebCore::RenderMathMLRoot::paddingBefore): Deleted.
(WebCore::RenderMathMLRoot::paddingAfter): Deleted.
(WebCore::RenderMathMLRoot::paddingStart): Deleted.
(WebCore::RenderMathMLRoot::paddingEnd): Deleted.
(WebCore::RenderMathMLRoot::index): Deleted.
- rendering/mathml/RenderMathMLRoot.h: Rewritten.
(WebCore::RenderMathMLRootWrapper::RenderMathMLRootWrapper):
LayoutTests:
We update the reference for some tests with radicals and enable the tests for addition/removal of children in an msqrt/mroot element.
We also add a test for bug 126516 (SVG transforms not applied to mroot) and a new test for radical drawing using an OpenType MATH table.
- TestExpectations: enable the tests for addition/removal of children.
- mathml/opentype/roots-LatinModern.html: Added.
- mathml/presentation/mroot-transform-expected.html: Added.
- mathml/presentation/mroot-transform.html: Added.
- platform/efl/TestExpectations: mark failures for bad references.
- platform/efl/mathml/opentype/roots-LatinModern-expected.txt: Added.
- platform/gtk/mathml/opentype/roots-LatinModern-expected.png: Added.
- platform/gtk/mathml/opentype/roots-LatinModern-expected.txt: Added.
- platform/gtk/mathml/presentation/mo-stretch-expected.png: update reference.
- platform/gtk/mathml/presentation/mo-stretch-expected.txt: update reference.
- platform/gtk/mathml/presentation/roots-expected.png: update reference.
- platform/gtk/mathml/presentation/roots-expected.txt: update reference.
- platform/mac/TestExpectations: mark failures for bad references.
- platform/mac/mathml/opentype/roots-LatinModern-expected.txt: Added.
- platform/win/TestExpectations: mark failures for bad references.
- platform/win/mathml/opentype/roots-LatinModern-expected.txt: Added.
- 11:04 AM Changeset in webkit [169938] by
-
- 5 edits in trunk/Source/WebKit2
[iOS] Networking process always decodes keys
https://bugs.webkit.org/show_bug.cgi?id=133863
Reviewed by Anders Carlsson.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer): Call checkEntitlements on iOS, too.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::checkEntitlements): On iOS, allow decoding keys
if the application has the appropriate keychain access group.
- Shared/cf/ArgumentCodersCF.cpp:
(IPC::setAllowsDecodingSecKeyRef): Added. Sets static bool.
(IPC::decode): Check the secKeyRefDecodingAllowed bool before decoding a key.
- Shared/cf/ArgumentCodersCF.h:
- 10:33 AM Changeset in webkit [169937] by
-
- 10 edits in trunk/Source
Add overloads of HTTPHeaderMap::find and remove that take enums
https://bugs.webkit.org/show_bug.cgi?id=133823
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.exp.in:
Update symbols.
- WebCore.xcodeproj/project.pbxproj:
Make HTTPHeaderNames.h private.
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::contains):
Convert the enum value to a string and call the contains overload that takes a string.
(WebCore::HTTPHeaderMap::remove):
Convert the enum value to a string and call the remove overload that takes a string.
- platform/network/HTTPHeaderMap.h:
Add new overloads taking HTTPHeaderName and mark the versions taking string literals as deleted.
- platform/network/HTTPHeaderNames.in:
Add new header names.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::clearHTTPContentType):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPOrigin):
(WebCore::ResourceRequestBase::clearHTTPUserAgent):
(WebCore::ResourceRequestBase::clearHTTPAccept):
Update functions to use HTTPHeaderName enums.
(WebCore::ResourceRequestBase::isConditional):
(WebCore::ResourceRequestBase::makeUnconditional):
Simplify these.
Source/WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parsePostBuffer):
Update for WebCore changes.
- 10:32 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:35 AM WebKitGTK/2.4.x edited by
- UA bug: replaced link for trunk by link for stable (diff)
- 9:12 AM Changeset in webkit [169936] by
-
- 3 edits2 adds in trunk
Source/WebCore: [ATK] Fix text inside "span" block in "a" block was not accessible.
https://bugs.webkit.org/show_bug.cgi?id=132349
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp: Add link role to the list of roles whose objects always expose atk_text interface.
LayoutTests: [ATK] Add test for accessibility of text inside "span" block in "a" block.
https://bugs.webkit.org/show_bug.cgi?id=132349
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-13
Reviewed by Mario Sanchez Prada.
- platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt: Added.
- platform/gtk/accessibility/text-in-span-block-in-a-block.html: Added.
- 7:25 AM WebKitGTK/2.4.x edited by
- point to the changesets rather than the bugs (diff)
- 6:33 AM Changeset in webkit [169935] by
-
- 2 edits in trunk/Source/WebCore
[GTK] GLContextEGL.cpp: conflicting declaration 'typedef ptrdiff_t GLintptr'
https://bugs.webkit.org/show_bug.cgi?id=133550
Reviewed by Gustavo Noronha Silva.
Cairo includes some definitions from GLX that conflict with the
ones provided by our GLES2 headers (GLintptr, GLsizeiptr).
Since GLContextEGL doesn't use any GLX functions we can safely
disable the inclusion of those functions in that source file.
- platform/graphics/egl/GLContextEGL.cpp:
- 6:09 AM Changeset in webkit [169934] by
-
- 12 edits2 adds in trunk/Source/WebCore
[CSS Grid Layout] Introduce an explicit type for resolved grid positions
https://bugs.webkit.org/show_bug.cgi?id=131732
Reviewed by Sergio Villar Senin.
We were using simple size_t integers to represent resolved grid
positions in our internal data structures. This change allows us to
clarify the code, avoid potential off by one mistakes, and move the
resolving code to a central place.
A new class GridResolvedPosition has been created and the related
methods have been moved there from RenderGrid.
GridSpan is now defined by two GridResolvedPosition, so all the code
using it has been modified to adapt it to GridResolvedPosition.
No new tests as it is already covered by current tests
(fast/css-grid-layout/).
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSGridTemplateAreasValue.cpp:
(WebCore::stringForPosition):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateAreasRow):
- css/StyleResolver.cpp:
(WebCore::createImplicitNamedGridLinesFromGridArea):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeNormalizedFractionBreadth):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::insertItemIntoGrid):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisDirection):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::explicitGridColumnCount): Deleted.
(WebCore::RenderGrid::explicitGridRowCount): Deleted.
(WebCore::isColumnSide): Deleted.
(WebCore::isStartSide): Deleted.
(WebCore::RenderGrid::explicitGridSizeForSide): Deleted.
(WebCore::RenderGrid::resolveGridPositionsFromAutoPlacementPosition): Deleted.
(WebCore::gridLinesForSide): Deleted.
(WebCore::implicitNamedGridLineForSide): Deleted.
(WebCore::isNonExistentNamedLineOrArea): Deleted.
(WebCore::RenderGrid::adjustGridPositionsFromStyle): Deleted.
(WebCore::RenderGrid::resolveGridPositionsFromStyle): Deleted.
(WebCore::RenderGrid::resolveNamedGridLinePositionFromStyle): Deleted.
(WebCore::RenderGrid::resolveGridPositionFromStyle): Deleted.
(WebCore::RenderGrid::resolveGridPositionAgainstOppositePosition): Deleted.
(WebCore::RenderGrid::resolveNamedGridLinePositionAgainstOppositePosition): Deleted.
(WebCore::firstNamedGridLineBeforePosition): Deleted.
(WebCore::RenderGrid::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition): Deleted.
(WebCore::RenderGrid::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition): Deleted.
- rendering/RenderGrid.h:
- rendering/style/GridCoordinate.h:
(WebCore::GridSpan::GridSpan):
(WebCore::GridSpan::operator==):
- rendering/style/GridPosition.h:
(WebCore::GridPosition::adjustGridPositionForRowEndColumnEndSide): Deleted.
(WebCore::GridPosition::adjustGridPositionForSide): Deleted.
- rendering/style/GridResolvedPosition.cpp: Added.
(WebCore::isColumnSide):
(WebCore::isStartSide):
(WebCore::explicitGridSizeForSide):
(WebCore::GridResolvedPosition::resolveGridPositionsFromAutoPlacementPosition):
(WebCore::gridLinesForSide):
(WebCore::implicitNamedGridLineForSide):
(WebCore::isNonExistentNamedLineOrArea):
(WebCore::GridResolvedPosition::adjustGridPositionsFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionsFromStyle):
(WebCore::GridResolvedPosition::resolveNamedGridLinePositionFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveNamedGridLinePositionAgainstOppositePosition):
(WebCore::firstNamedGridLineBeforePosition):
(WebCore::GridResolvedPosition::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
- rendering/style/GridResolvedPosition.h: Added.
(WebCore::GridResolvedPosition::adjustGridPositionForRowEndColumnEndSide):
(WebCore::GridResolvedPosition::adjustGridPositionForSide):
(WebCore::GridResolvedPosition::GridResolvedPosition):
(WebCore::GridResolvedPosition::operator++):
(WebCore::GridResolvedPosition::operator==):
(WebCore::GridResolvedPosition::operator<):
(WebCore::GridResolvedPosition::operator>):
(WebCore::GridResolvedPosition::operator<=):
(WebCore::GridResolvedPosition::operator>=):
(WebCore::GridResolvedPosition::toInt):
(WebCore::GridResolvedPosition::next):
- 5:58 AM WebKitGTK/2.4.x edited by
- (diff)
- 4:53 AM WebKitGTK/2.4.x edited by
- added 133403 (diff)
- 3:16 AM Changeset in webkit [169933] by
-
- 3 edits in trunk/LayoutTests
[EFL] Change expectations for two failing layout tests.
https://bugs.webkit.org/show_bug.cgi?id=133805
Unreviewed EFL gradening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-06-13
- platform/efl/TestExpectations:
- platform/efl/fast/multicol/newmulticol/client-rects-expected.txt:
- 2:01 AM Changeset in webkit [169932] by
-
- 2 edits in trunk/Tools
Create MSE and EME watchlist
https://bugs.webkit.org/show_bug.cgi?id=133810
Reviewed by Eric Carlson.
- Scripts/webkitpy/common/config/watchlist: Create MSEEME
definition and add Eric Carlson and myself to it.
Jun 12, 2014:
- 11:40 PM Changeset in webkit [169931] by
-
- 10 edits3 deletes in trunk
[GTK] Remove all deprecated API from GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=133728
Reviewed by Martin Robinson.
Source/WebCore:
Remove all deprecated symbols from the GObject DOM bindings,
keeping the deprecation infraestructure for future API breaks.
- PlatformGTK.cmake: Remove WebKitDOMDeprecated files from the
build.
- bindings/gobject/WebKitDOMDeprecated.cpp: Removed.
- bindings/gobject/WebKitDOMDeprecated.h: Removed.
- bindings/gobject/WebKitDOMDeprecated.symbols: Removed.
- bindings/gobject/webkitdom.symbols: Updated to the current API.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Remove exceptions for deprecated API.
(GetFunctionDeprecationInformation): Ditto.
(GetEffectiveFunctionName): Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(webkit_dom_test_event_target_dispatch_event): Deleted.
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.symbols:
- dom/Element.idl: Remove GObject exception.
Tools:
- gtk/webkitdom.py:
(WebKitDOMDocGenerator): Remove all deleted classes from the list.
(WebKitDOMDocGeneratorSections.init): Fix a typo in member initialization.
- 9:56 PM Changeset in webkit [169930] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix assertions under JSC::setNeverInline() when running js tests in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=133840
Reviewed by Filip Pizlo.
Fix ASSERT(exec->vm().currentThreadIsHoldingAPILock()); under JSC::setNeverInline()
when running DFG tests.
- API/JSCTestRunnerUtils.cpp:
(JSC::numberOfDFGCompiles):
(JSC::setNeverInline):
- 9:20 PM Changeset in webkit [169929] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Do not update the viewport configuration on load until the first viewport arguments is received
https://bugs.webkit.org/show_bug.cgi?id=133719
<rdar://problem/17008149>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-12
Reviewed by Simon Fraser.
When pages are loaded from the page cache, we were updating the viewport to the initial values
in WebPage::dynamicViewportSizeUpdate(), then update the viewport again when the page's viewport argument
are received.
The problem is that was messing up with text autosizing. The page would relayout with the default viewport
configuration, adopt the text autosizing parameters from that size, then remain in that state when
the actual viewport configuration would be set.
With this patch, the viewport configuration is updated from the values in WebCore instead of with default values.
For new documents, this is strictly equivalent. For documents coming from the page cache, the values are from
the previous state of the page, which ensure we do not restart negotiating a viewport configuration from scratch.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
- 8:58 PM Changeset in webkit [169928] by
-
- 17 edits in trunk
Subpixel rendering: Make <input type=> and <button> elements' decoration subpixel aware.
https://bugs.webkit.org/show_bug.cgi?id=133812
<rdar://problem/17286309>
Reviewed by Simon Fraser.
Enable <input type=> and <button> decoration painting on subpixel positions.
The theme size is still integral, but its position is snapped to device pixels.
Theme's label, the InlineTextBox is already subpixel position aware.
webkit.org/b/132005 tracks the rest of the themes.
Source/WebCore:
Not testable.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::boundingBoxForQuads): Keep integral snapping for now.
- platform/Theme.h:
(WebCore::Theme::paint):
(WebCore::Theme::inflateControlPaintRect):
- platform/mac/ThemeMac.h:
- platform/mac/ThemeMac.mm:
(WebCore::inflateRect):
(WebCore::configureToggleButton):
(WebCore::sharedRadioCell):
(WebCore::sharedCheckboxCell):
(WebCore::paintToggleButton):
(WebCore::setUpButtonCell):
(WebCore::button):
(WebCore::paintButton):
(WebCore::paintStepper):
(WebCore::ThemeMac::inflateControlPaintRect):
(WebCore::ThemeMac::paint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addVisualOverflowFromTheme): Keep integral snapping for now.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::addRegionsVisualOverflowFromTheme): Keep integral snapping for now.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::adjustRepaintRect):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
LayoutTests:
- platform/mac-mountainlion/compositing/contents-opaque/control-layer-expected.txt:
- platform/mac/compositing/contents-opaque/control-layer-expected.txt:
- 6:53 PM Changeset in webkit [169927] by
-
- 4 edits in trunk/Source
[Win] Avoid fork bomb during build
https://bugs.webkit.org/show_bug.cgi?id=133837
<rdar://problem/17296034>
Reviewed by Tim Horton.
- JavaScriptCore.vcxproj/build-generated-files.sh: Use a
reasonable default value when the 'num-cpus' script is not available.
../WebCore:
- WebCore.vcxproj/build-generated-files.sh: Use a reasonable
default value when the 'num-cpus' script is not available.
- 6:49 PM Changeset in webkit [169926] by
-
- 13 edits in trunk/Source
Add support for thread/WorkQueue QoS
https://bugs.webkit.org/show_bug.cgi?id=130688
Reviewed by Anders Carlson & Simon Fraser.
Source/WebCore:
WebCore's ScrollingThread should be UserInteractive.
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::threadCallback):
- ScrollingThread should be UserInteractive
Source/WebKit2:
The EventDispatcher's WorkQueue should be UserInteractive.
- Platform/WorkQueue.cpp:
(WorkQueue::create):
- pass QOS to constructor.
(WorkQueue::WorkQueue):
- pass QOS to platformInitialize.
- Platform/WorkQueue.h:
- added enum, arguments.
- Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::platformInitialize):
- has extra argument.
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::platformInitialize):
- has extra argument.
- Platform/mac/WorkQueueMac.cpp:
(platformQOS):
- map from enum to platform type.
(WorkQueue::platformInitialize):
- set the QoS of the dispatch queue.
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::EventDispatcher):
- EventDispatcher's WorkQueue should be UserInteractive.
- config.h:
- added HAVE_QOS_CLASSES
Source/WTF:
Add the ability to mark threads as UserInteractive.
- wtf/Threading.cpp:
(WTF::setCurrentThreadIsUserInteractive):
- added method to set QoS of current thread to UserInteractive.
- wtf/Threading.h:
- added declaration.
- 5:55 PM Changeset in webkit [169925] by
-
- 2 edits in trunk/Tools
[iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
https://bugs.webkit.org/show_bug.cgi?id=133835
Reviewed by Tim Horton.
Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
- WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(-[WebKitTestRunnerWindow initWithFrame:]):
(-[WebKitTestRunnerWindow setFrame:]):
- 5:55 PM Changeset in webkit [169924] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Tiny hack to fix WebKitTestRunner view visibility
https://bugs.webkit.org/show_bug.cgi?id=133833
Reviewed by Tim Horton.
PageClientImplIOS in WebKitTestRunner has a null m_webView, so isViewInWindow
was returning false, which confused things.
Fix by falling back to a check on the content view if the m_webView is nil.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewInWindow):
- 5:27 PM Changeset in webkit [169923] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Build fix after r169919.
- WebCore.xcodeproj/project.pbxproj: The 'TileController.h' file must be a private header.
- 5:07 PM Changeset in webkit [169922] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Speculative build fix after r169921.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
- 4:49 PM Changeset in webkit [169921] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Stop observing the sample buffer renderers when destroying them.
https://bugs.webkit.org/show_bug.cgi?id=133831
Reviewed by Beth Dakin.
Release our retain on our AVSampleBufferDisplayLayer and AVSampleBufferAudioRenderer by stopping
our observation of its properties when removing them from the SourceBufferPrivateAVFObjC object.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
- 4:30 PM Changeset in webkit [169920] by
-
- 7 edits in trunk/Source/JavaScriptCore
Remove some dead / unused code.
<https://webkit.org/b/133828>
Reviewed by Filip Pizlo.
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createBuiltinExecutable):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedFunctionExecutable::create):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
- parser/Parser.h:
(JSC::DepthManager::DepthManager): Deleted.
(JSC::DepthManager::~DepthManager): Deleted.
- runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- 4:10 PM Changeset in webkit [169919] by
-
- 2 edits4 moves in trunk/Source/WebCore
Correct file locations after r169914. These should have been
in platform/graphics/ca.
Rubberstamped by Tim Horton.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/ca/TileController.cpp: Copied from platform/graphics/ca/mac/TileController.cpp.
- platform/graphics/ca/TileController.h: Copied from platform/graphics/ca/mac/TileController.h.
- platform/graphics/ca/TileGrid.cpp: Copied from platform/graphics/ca/mac/TileGrid.cpp.
- platform/graphics/ca/TileGrid.h: Copied from platform/graphics/ca/mac/TileGrid.h.
- platform/graphics/ca/mac/TileController.cpp: Removed.
- platform/graphics/ca/mac/TileController.h: Removed.
- platform/graphics/ca/mac/TileGrid.cpp: Removed.
- platform/graphics/ca/mac/TileGrid.h: Removed.
- 3:48 PM Changeset in webkit [169918] by
-
- 2 edits in tags/Safari-538.40/Source/WebCore
Merged r169917.
- 3:44 PM Changeset in webkit [169917] by
-
- 2 edits in trunk/Source/WebCore
Fix the build after r169913.
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
- 3:41 PM Changeset in webkit [169916] by
-
- 3 edits in tags/Safari-538.40/Source/WebCore
Merged r169913. <rdar://problem/17032752>
- 3:36 PM Changeset in webkit [169915] by
-
- 2 edits in trunk/Source/WebCore
Collect correct web timing data from CFNetwork.
https://bugs.webkit.org/show_bug.cgi?id=133824
<rdar://problem/17273654>
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-12
Reviewed by Simon Fraser.
Covered by existing web timing tests.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::getConnectionTimingData):
Use _kCFNTimingDataFetchStart as the reference start time key.
- 3:34 PM Changeset in webkit [169914] by
-
- 5 edits2 moves in trunk/Source/WebCore
Convert TileController and TileGrid from ObjC to C++
https://bugs.webkit.org/show_bug.cgi?id=133819
<rdar://problem/17291841>
Reviewed by Tim Horton.
Convert TileGrid.mm and TileController.mm into C++ implementations. This required creating a 'frameForLayer'
wrapper to call the 'frame' method of the CALayer object.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/ca/mac/TileController.cpp: Copied from platform/graphics/ca/mac/TileController.mm.
(WebCore::TileController::blankPixelCountForTiles):
- platform/graphics/ca/mac/TileController.mm: Removed.
- platform/graphics/ca/mac/TileGrid.cpp: Copied from platform/graphics/ca/mac/TileGrid.mm.
- platform/graphics/ca/mac/TileGrid.h:
- platform/graphics/ca/mac/TileGrid.mm: Removed.
- platform/graphics/mac/WebLayer.h:
- platform/graphics/mac/WebLayer.mm:
(WebCore::frameForLayer): Wrapper function to hide ObjC call from C++ compilation unit.
- 3:24 PM Changeset in webkit [169913] by
-
- 3 edits in trunk/Source/WebCore
[iOS WK2] Fix crash on back/foward swipe
https://bugs.webkit.org/show_bug.cgi?id=133826
<rdar://problem/17032752>
Reviewed by Tim Horton.
AsyncScrollingCoordinator::frameViewForScrollingNode() would crash with a null root
state node, because HistoryController::restoreScrollPositionAndViewState() tried
to restore scroll position (via restoreViewState()) before hooking up the scrolling
coordinator.
Fix by doing the scrollingCoordinator->frameViewRootLayerDidChange() before
calling restoreViewState().
Also add a defensive null-check on the root state node in updateScrollPositionAfterAsyncScrollTimerFired().
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewForScrollingNode):
- 2:21 PM Changeset in webkit [169912] by
-
- 3 edits in trunk/Source/WebKit2
Add SPI for image controls and service controls preferences.
<rdar://problem/17292209> and https://bugs.webkit.org/show_bug.cgi?id=133820
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetServiceControlsEnabled):
(WKPreferencesGetServiceControlsEnabled):
(WKPreferencesSetImageControlsEnabled):
(WKPreferencesGetImageControlsEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- 1:54 PM Changeset in webkit [169911] by
-
- 2 edits in trunk/Source/WebCore
Add a space after the comma.
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::add):
- 1:40 PM Changeset in webkit [169910] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Allow reading com.apple.universalaccess preferences
https://bugs.webkit.org/show_bug.cgi?id=133817
<rdar://problem/17028261>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb.in:
- 1:34 PM Changeset in webkit [169909] by
-
- 5 edits in trunk/Source/WebKit/win
[Win] Avoid crashes in code that converted CFDictionaries to HashMap
https://bugs.webkit.org/show_bug.cgi?id=133813
<rdar://problem/17291647>
Reviewed by Tim Horton.
- WebHistory.cpp: Add empty string checks to avoid crashes in
hash function.
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):
(WebHistory::itemForURL):
(WebHistory::removeItemForURLString):
(WebHistory::itemForURLString):
- WebPreferences.cpp: Ditto.
(WebPreferences::getInstanceForIdentifier):
(WebPreferences::setInstance):
(WebPreferences::removeReferenceForIdentifier):
- WebView.cpp: Ditto. Also convert OwnPtr uses in this file
to std::unique_ptr.
(WebView::close):
(WebView::handleMouseEvent):
(WebView::registerEmbeddedViewMIMEType):
(WebView::shouldUseEmbeddedView):
(WebView::enterFullscreenForNode):
(WebView::fullScreenController):
- WebView.h:
- 1:23 PM Changeset in webkit [169908] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<HTTPHeaderMap>::decode):
(CoreIPC::ArgumentCoder<ResourceRequest>::decode):
- 12:56 PM Changeset in webkit [169907] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-12
- platform/gtk/TestExpectations: Report and mark new failures and
timeouts.
- platform/gtk/fast/forms/placeholder-position-expected.txt:
Rebaseline test after r169780.
- 12:50 PM Changeset in webkit [169906] by
-
- 6 edits in trunk/Source/WebCore
Move header value merging to HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=133815
Reviewed by Andreas Kling.
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::set):
(WebCore::HTTPHeaderMap::add):
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::addHTTPHeaderField):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::addHTTPHeaderField):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setRequestHeaderInternal):
- 12:07 PM Changeset in webkit [169905] by
-
- 2 edits in trunk/Source/WebKit2
Fixed a harmless error message when rewrite-availability-macros.sh is run in a clean build.
Rubber-stamped by Anders Carlsson.
- mac/rewrite-availability-macros.sh:
- 11:50 AM Changeset in webkit [169904] by
-
- 12 edits1 add in trunk/Source/WebCore
Add ShapeValue.cpp and move ShapeValue::isImageValid() there
https://bugs.webkit.org/show_bug.cgi?id=133809
Reviewed by Antti Koivisto.
This gets rid of CachedImage.h (and ResourceRequest and friends) from RenderStyle.h.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::shapePropertyValue):
- css/CSSCrossfadeValue.cpp:
- css/CSSFilterImageValue.cpp:
- css/StyleResolver.h:
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
- rendering/ShapeValue.cpp: Added.
(WebCore::ShapeValue::isImageValid):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::referenceBox):
(WebCore::ShapeOutsideInfo::computedShape):
(WebCore::ShapeOutsideInfo::isEnabledFor):
- rendering/style/ShapeValue.h:
(WebCore::ShapeValue::type):
(WebCore::ShapeValue::setImage):
(WebCore::ShapeValue::ShapeValue):
(WebCore::ShapeValue::isImageValid): Deleted.
- 11:38 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:37 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:22 AM Changeset in webkit [169903] by
-
- 5 edits in trunk/Source/JavaScriptCore
Move structureHasRareData out of TypeInfo
https://bugs.webkit.org/show_bug.cgi?id=133800
Reviewed by Andreas Kling.
StructureHasRareData was originally put in TypeInfo to avoid making Structure bigger,
but we have a few spare bits in Structure so it would be nice to remove this hack.
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::newImpurePropertyFiresWatchpoints):
(JSC::TypeInfo::structureHasRareData): Deleted.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::allocateRareData):
(JSC::Structure::cloneRareDataFrom):
- runtime/Structure.h:
(JSC::Structure::previousID):
(JSC::Structure::objectToStringValue):
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::setPreviousID):
(JSC::Structure::clearPreviousID):
(JSC::Structure::previous):
(JSC::Structure::rareData):
- runtime/StructureInlines.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache):
- 10:42 AM Changeset in webkit [169902] by
-
- 9 edits6 adds in branches/ftlopt
[ftlopt] DFG get_by_id should inline chain accesses with a slightly polymorphic base
https://bugs.webkit.org/show_bug.cgi?id=133751
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::appendVariant):
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::attemptToMerge):
- bytecode/GetByIdVariant.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::emitPrototypeChecks):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::IntendedStructureChain):
(JSC::IntendedStructureChain::isStillValid):
(JSC::IntendedStructureChain::isNormalized):
(JSC::IntendedStructureChain::terminalPrototype):
(JSC::IntendedStructureChain::operator==):
(JSC::IntendedStructureChain::visitChildren):
(JSC::IntendedStructureChain::dumpInContext):
(JSC::IntendedStructureChain::chain): Deleted.
- runtime/IntendedStructureChain.h:
(JSC::IntendedStructureChain::prototype):
(JSC::IntendedStructureChain::operator!=):
(JSC::IntendedStructureChain::head): Deleted.
LayoutTests:
- js/regress/poly-chain-access-expected.txt: Added.
- js/regress/poly-chain-access-simpler-expected.txt: Added.
- js/regress/poly-chain-access-simpler.html: Added.
- js/regress/poly-chain-access.html: Added.
- js/regress/script-tests/poly-chain-access-simpler.js: Added.
- js/regress/script-tests/poly-chain-access.js: Added.
- 10:33 AM Changeset in webkit [169901] by
-
- 2 edits in tags/Safari-538.40/Source/WTF
Merged r169900.
- 9:35 AM Changeset in webkit [169900] by
-
- 2 edits in trunk/Source/WTF
Fix Mac after r169880.
This revision added a C++ comment to Platform.h, which breaks sandbox profile
preprocessing.
Also, I do not believe that this comment was entirely accurate - we've always used
this technique with GCC, so there has to be more to it. So, I just removed the comment.
- wtf/Platform.h:
- 9:13 AM Changeset in webkit [169899] by
-
- 6 edits in branches/safari-537.60-branch/Source
Unreviewed build fix. (Merge r167685)
Source/JavaScriptCore:
- DerivedSources.make: Specify path to Perl/Python to avoid
build failures under Python 2.7+.
Source/WebCore:
- DerivedSources.make: Specify path to Perl/Python to avoid
build failures under Python 2.7+.
Source/WTF:
- WTF.vcxproj/WTFGenerated.make: Specify path to Perl/Python
to avoid build failures under Python 2.7+.
- 7:53 AM Changeset in webkit [169898] by
-
- 11 edits in trunk/Source/WebCore
Subpixel rendering: Make <select> element's decoration subpixel aware.
https://bugs.webkit.org/show_bug.cgi?id=133781
<rdar://problem/17272083>
Reviewed by Simon Fraser.
Enable <select> decoration painting on subpixel positions.
The theme size is still integral, but its position is snapped to device pixels.
Theme's label, the InlineTextBox is already subpixel position aware.
webkit.org/b/132005 tracks the rest of the themes.
Not testable.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMenuList):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::inflateRect):
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::progressBarRectForBounds):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::inflateRect): Deleted.
- 7:09 AM Changeset in webkit [169897] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Crash in MediaSourcePrivateAVFObjC::naturalSize()
https://bugs.webkit.org/show_bug.cgi?id=133789
Reviewed by Eric Carlson.
Add null-check to proctect against being queried for the naturalSize before we have a
m_mediaSourcePrivate.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::naturalSize):
- 7:07 AM Changeset in webkit [169896] by
-
- 2 edits in trunk/Source/WebCore
[GTK] fails to build with --disable-webgl --disable-accelerated-compositing
https://bugs.webkit.org/show_bug.cgi?id=131267
Reviewed by Philippe Normand.
Add missing headers needed for Float32Array::create().
- Modules/webaudio/AudioBuffer.cpp:
- 7:06 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 7:04 AM Changeset in webkit [169895] by
-
- 5 edits in trunk/Source
Versioning.
- 7:03 AM Changeset in webkit [169894] by
-
- 1 copy in tags/Safari-538.40
New Tag.
- 6:25 AM WebKitGTK/2.4.x edited by
- changed bug id to trac changset (diff)
- 5:53 AM Changeset in webkit [169893] by
-
- 2 edits in trunk/Tools
[GTK] Performance tests should be always ran with WKTR.
https://bugs.webkit.org/show_bug.cgi?id=133780
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-12
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.init): Enable webkit_test_runner when port
is GTK.
- 5:47 AM Changeset in webkit [169892] by
-
- 4 edits in trunk
[GTK] REGRESSION: application name is not correctly appended to the UA
https://bugs.webkit.org/show_bug.cgi?id=133793
Reviewed by Carlos Garcia Campos.
Source/WebCore:
We must use a blank to separate the default UA provided by WebKitGtk
from the application name coming from the public API.
Added an extra test case to the API tests to catch regressions.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::standardUserAgent):
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
(testWebKitSettingsUserAgent):
- 5:41 AM Changeset in webkit [169891] by
-
- 3 edits in trunk/Source/WebCore
WorkerRunLoop::Task::performTask should take in WorkerGlobalScope* to avoid downcasting
https://bugs.webkit.org/show_bug.cgi?id=133616
Reviewed by Andreas Kling.
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::Task::performTask): Demand the context parameter to be a pointer
to WorkerGlobalScope instead of ScriptExecutionContext, avoiding an unnecessary downcast.
In the future this complete code path should use a reference to WorkerGlobalScope instead
of a pointer.
- workers/WorkerRunLoop.h:
- 5:03 AM WebKitGTK/2.4.x edited by
- (diff)
- 4:39 AM Changeset in webkit [169890] by
-
- 4 edits in trunk/LayoutTests
[EFL] Change expectations for three failing js/dom layout tests.
https://bugs.webkit.org/show_bug.cgi?id=133743
Unreviewed EFL gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-06-12
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt:
- 3:10 AM Changeset in webkit [169889] by
-
- 2 edits3 adds in trunk/Source/JavaScriptCore
Allow enum guards to be generated from the replay json files
https://bugs.webkit.org/show_bug.cgi?id=133399
Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-06-12
Reviewed by Csaba Osztrogonác.
- replay/scripts/CodeGeneratorReplayInputs.py:
(Type.init):
(InputsModel.parse_type_with_framework_name):
(Generator.generate_header):
(Generator.generate_implementation):
- replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.cpp: Added.
(Test::HandleWheelEvent::HandleWheelEvent):
(Test::HandleWheelEvent::~HandleWheelEvent):
(JSC::InputTraits<Test::HandleWheelEvent>::type):
(JSC::InputTraits<Test::HandleWheelEvent>::encode):
(JSC::InputTraits<Test::HandleWheelEvent>::decode):
(JSC::EncodingTraits<WebCore::PlatformWheelEventPhase>::encodeValue):
(JSC::EncodingTraits<WebCore::PlatformWheelEventPhase>::decodeValue):
- replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h: Added.
(JSC::InputTraits<Test::HandleWheelEvent>::queue):
(Test::HandleWheelEvent::platformEvent):
- replay/scripts/tests/generate-enum-with-guard.json: Added.
- 2:41 AM Changeset in webkit [169888] by
-
- 2 edits in trunk/LayoutTests
[EFL] Change expectations for three failing layout tests.
https://bugs.webkit.org/show_bug.cgi?id=133738
Unreviewed EFL layout tests gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-06-12
- platform/efl/TestExpectations:
- 2:25 AM Changeset in webkit [169887] by
-
- 4 edits in trunk
[GTK] Unsupported browser in www.icloud.com
https://bugs.webkit.org/show_bug.cgi?id=133403
Reviewed by Martin Robinson.
Source/WebCore:
We claim to be Safari (among others) to ensure maximum
compatibility with existing web sites. Valid Safari UA strings do
always (since Safari 3.0) contain the string "Version/X" before
the "Safari/X" part. We were wrongly only adding it in very
specific cases and we were placing it at the wrong position as it
must precede the "Safari/X" part.
From now on we unconditionally prepend the "Version/X" string to
the "Safari/X" part as we always claim to be Safari. This makes
the NeedsSafariVersion6 quirk invalid. This not only fixes
"unsupported browser" issues in icloud.com, but also in
globalforestwatch.com and live.com among many others.
Apart from that I'm bumping the Safari Version in the UA to 8.0 as
we're already claiming to be "Safari/538.35"" which corresponds to
Safari 8 beta.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::buildUserAgentString):
(WebCore::standardUserAgentForURL):
Tools:
- TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
quirk that was removed.
- 1:50 AM Changeset in webkit [169886] by
-
- 13 edits in trunk/Source/JavaScriptCore
Unreviewed. Fix GTK+ build after r169823.
Include StructureInlines.h in a few more files to fix linking
issues due to JSC::Structure::get undefined symbol.
- runtime/ArrayIteratorConstructor.cpp:
- runtime/ArrayIteratorPrototype.cpp:
- runtime/JSConsole.cpp:
- runtime/JSMapIterator.cpp:
- runtime/JSSet.cpp:
- runtime/JSSetIterator.cpp:
- runtime/JSWeakMap.cpp:
- runtime/MapIteratorPrototype.cpp:
- runtime/MapPrototype.cpp:
- runtime/SetIteratorPrototype.cpp:
- runtime/SetPrototype.cpp:
- runtime/WeakMapPrototype.cpp:
- 1:01 AM Changeset in webkit [169885] by
-
- 2 edits in trunk/Source/JavaScriptCore
[EFL] One more URTBF after r169823 to make ARM64 build happy too.
- runtime/JSMap.cpp:
- 12:37 AM Changeset in webkit [169884] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Remove view mode API
https://bugs.webkit.org/show_bug.cgi?id=133725
Reviewed by Martin Robinson.
It currently does nothing because support for view source mode was
removed from WebCore.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkit_web_view_set_view_mode): Deleted.
(webkit_web_view_get_view_mode): Deleted.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- 12:25 AM Changeset in webkit [169883] by
-
- 5 edits in trunk/Source
Avoid creating a CFData when checking if a resource is file backed
https://bugs.webkit.org/show_bug.cgi?id=133783
Reviewed by Andreas Kling.
Source/WebCore:
Export SharedBuffer::hasPlatformData().
No new tests because no functional changes.
- WebCore.exp.in:
- platform/SharedBuffer.h:
Source/WebKit2:
When a resource is file backed, we have it as a single CFDataRef in SharedBuffer. Add an
early return in tryGetShareableHandleFromSharedBuffer() so we don't end up creating a new
CFDataRef if we don't already have one in SharedBuffer. If we had to create a CFDataRef, the
it can't have been a file backed resource.
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):
Jun 11, 2014:
- 11:36 PM Changeset in webkit [169882] by
-
- 3 edits in tags/Safari-538.39.41/WebKitLibraries
Rolling out r169873
- 11:36 PM Changeset in webkit [169881] by
-
- 2 edits in trunk/Source/WebKit2
Fix build break on EFL and GTK ports since r169820
https://bugs.webkit.org/show_bug.cgi?id=133786
Reviewed by Philippe Normand.
ENABLE_PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC macro are missing in PluginView::pluginSnapshotTimerFired().
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginSnapshotTimerFired):
- 11:18 PM Changeset in webkit [169880] by
-
- 5 edits in trunk/Source
[EFL][GTK] Ultimate fix not to have build failures
in the future because of "#if TARGET_OS_IPHONE" guards.
Unreviewed buildfix.
Source/WebKit2:
Revert the previous wrong fix attempt r169879.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Source/WTF:
- wtf/Platform.h: Define TARGET_OS_IPHONE to 0 on EFL and GTK.
- 10:45 PM Changeset in webkit [169879] by
-
- 3 edits in trunk/Source/WebKit2
Fix build break on EFL port since r169869
https://bugs.webkit.org/show_bug.cgi?id=133785
Unreviewed, fix a build break on EFL port.
Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2014-06-11
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Use defined(TARGET_OS_IPHONE).
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: ditto.
- 10:22 PM Changeset in webkit [169878] by
-
- 2 edits in trunk
Unreviewed, rolling out r169877.
https://bugs.webkit.org/show_bug.cgi?id=133784
rollout wrong build fix approach for EFL port (Requested by
gyuyoung on #webkit).
Reverted changeset:
"Unreviewed, EFL build fix since r169869."
http://trac.webkit.org/changeset/169877
- 10:03 PM Changeset in webkit [169877] by
-
- 2 edits in trunk
Unreviewed, EFL build fix since r169869.
Additionally literal-suffix is removed in EFL compile flag, because it is duplicated.
- Source/cmake/WebKitHelpers.cmake: Treat undef error as build warning.
- 8:24 PM Changeset in webkit [169876] by
-
- 2 edits in tags/Safari-538.39.41/Source/WebCore
Re-merged r169855. <rdar://problem/16746383>
- 8:12 PM Changeset in webkit [169875] by
-
- 2 edits in tags/Safari-538.39.41/Source/WebCore
Re-merged r169843. <rdar://problem/16746383>
- 8:09 PM Changeset in webkit [169874] by
-
- 11 edits in tags/Safari-538.39.41/Source/WebCore
Re-merged r169830. <rdar://problem/16746383>
- 7:55 PM Changeset in webkit [169873] by
-
- 3 edits in tags/Safari-538.39.41/WebKitLibraries
Re-merged r169817. <rdar://problem/17009091>
- 7:24 PM Changeset in webkit [169872] by
-
- 4 edits2 adds in trunk
SVGGlyphToPathTranslator ASSERTs when encountering a missing glyph in an SVG font
https://bugs.webkit.org/show_bug.cgi?id=133528
Reviewed by Simon Fraser.
Source/WebCore:
Turns out this assertion is benign. We can take an early out of advance() (which
is then handled properly by Font::dashesForIntersectionsWithRect()
Test: svg/custom/skip-underline-missing-glyph.html
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect): Rather than skip partial results,
don't skip anything at all to be consistent.
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::advance): Take an early out to avoid an ASSERT.
LayoutTests:
Make sure that no ASSERT occurs in this situation. In addition, make sure that the
whole element doesn't get skip:ink gaps. This will need to be updated when we
support SVG + non-SVG mixed runs.
- svg/custom/skip-underline-missing-glyph-expected.html: Added
- svg/custom/skip-underline-missing-glyph.html: Added
- 7:11 PM Changeset in webkit [169871] by
-
- 3 edits in tags/Safari-538.39.41/WebKitLibraries
Roll out changes from 17009091
- 7:10 PM Changeset in webkit [169870] by
-
- 12 edits in tags/Safari-538.39.41/Source/WebCore
Roll out changes for 16746383.
- 7:03 PM Changeset in webkit [169869] by
-
- 14 edits in trunk
[iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
https://bugs.webkit.org/show_bug.cgi?id=133779
Reviewed by Benjamin Poulain.
Source/WebCore:
Add a "testing" viewport configuration with initial scale of 1.
- WebCore.exp.in:
- page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::testingParameters):
- page/ViewportConfiguration.h:
Source/WebKit2:
Support a custom viewport configuration for testing, on iOS.
- UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _frameOrBoundsChanged]): Call setViewportConfigurationMinimumLayoutSize()
just as WKWebView does.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetUseTestingViewportConfiguration): New SPI to set a viewport config for testing.
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::setUseTestingViewportConfiguration):
(WebKit::WebPage::isUsingTestingViewportConfiguration):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::resetViewportDefaultConfiguration):
Tools:
Tell the WebPage to use the testing viewport configuration from the injected bundle.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage): Code cleanup.
- WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
on iOS.
- 5:46 PM Changeset in webkit [169868] by
-
- 2 edits in trunk/Source/WebCore
Keep CFDataRefs in SharedBuffer instead of merging them
https://bugs.webkit.org/show_bug.cgi?id=133775
Reviewed by Alexey Proskuryakov.
Instead of merging the CFDataRefs into one buffer, save them in as CFDataRefs in
SharedBuffer. They will get merged when code calls buffer() later on.
No new tests because no functional changes.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::handleDataArray):
- 5:39 PM Performance Tests edited by
- Update ports and links (diff)
- 5:32 PM Changeset in webkit [169867] by
-
- 2 edits in trunk/Source/WebKit/mac
WebFrameNetworkContext should not have a sourceApplicationIdentifier in WK1.
https://bugs.webkit.org/show_bug.cgi?id=133772
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-11
Reviewed by Jer Noble.
Return empty string from sourceApplicationIdentifier for WK1.
- WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::sourceApplicationIdentifier):
- 5:30 PM Changeset in webkit [169866] by
-
- 4 edits in trunk
editing/selection/selection-in-iframe-removed-crash.html or selection-invalid-offset.html crashes intermittently
https://bugs.webkit.org/show_bug.cgi?id=111521
<rdar://problem/15159351>
Reviewed by Brady Eidson.
Source/WebCore:
Covered by existing tests.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData): Bail out if the
load was canceled from under receivedFirstData(). Since this is where we commit the
load, there are ample opportunities for scripts or clients to do anything.
LayoutTests:
- platform/mac/TestExpectations: Removed expectations for the tests.
- 5:30 PM Changeset in webkit [169865] by
-
- 3 edits in tags/Safari-538.39.41/Source/WebCore
Merged r169855.
- 5:25 PM Changeset in webkit [169864] by
-
- 15 edits in branches/ftlopt/Source/JavaScriptCore
Readded native calling to the FTL and Split the DFG nodes
Call and Construct into NativeCall and NativeConstruct
to better represent their semantics.
https://bugs.webkit.org/show_bug.cgi?id=133660
Reviewed by Filip Pizlo.
- dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Added NativeCall and NativeConstruct case
- dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::addCall): added NativeCall case. (JSC::DFG::ByteCodeParser::handleCall): set to return NativeCall or NativeConstruct instead of Call or Construct in the presence of a native function.
- dfg/DFGClobberize.h: (JSC::DFG::clobberize): added NativeCall and NativeConstruct case.
- dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC): added NativeCall and NativeConstruct case.
- dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): added NativeCall and NativeConstruct case.
- dfg/DFGNode.h: (JSC::DFG::Node::hasHeapPrediction): added NativeCall and NativeConstruct case. (JSC::DFG::Node::canBeKnownFunction): changed to NativeCall and NativeConstruct. (JSC::DFG::Node::hasKnownFunction): changed to NativeCall and NativeConstruct.
- dfg/DFGNodeType.h: added NativeCall and NativeConstruct.
- dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate): added NativeCall and NativeConstruct case.
- dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute): added NativeCall and NativeConstruct case.
- dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::emitCall): ditto (JSC::DFG::SpeculativeJIT::compile): ditto
- dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::emitCall): ditto (JSC::DFG::SpeculativeJIT::compile): ditto
- ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile): ditto
- ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::lower): ditto (JSC::FTL::LowerDFGToLLVM::compileNode): ditto. (JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct): Added. (JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct): removed NativeCall and NativeConstruct functionality. (JSC::FTL::LowerDFGToLLVM::didOverflowStack): added NativeCall and NativeConstruct case.
- runtime/JSCJSValue.h: added JS_EXPORT_PRIVATE to toInteger as it is apparently needed.
Patch by Matthew Mirman <mmirman@apple.com> on 2014-06-11
- 5:14 PM Changeset in webkit [169863] by
-
- 10 edits in trunk/Source/WebKit2
Remove unused VisibleContentRectUpdateInfo update ID
https://bugs.webkit.org/show_bug.cgi?id=133777
Reviewed by Benjamin Poulain.
Remove some unused code.
- Shared/VisibleContentRectUpdateInfo.cpp:
(WebKit::VisibleContentRectUpdateInfo::encode):
(WebKit::VisibleContentRectUpdateInfo::decode):
- Shared/VisibleContentRectUpdateInfo.h:
(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::operator==):
(WebKit::VisibleContentRectUpdateInfo::updateID): Deleted.
- Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::setLastVisibleContentRectUpdateID): Deleted.
(WebKit::RemoteLayerTreeTransaction::lastVisibleContentRectUpdateID): Deleted.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::nextVisibleContentRectUpdateID): Deleted.
(WebKit::WebPageProxy::lastVisibleContentRectUpdateID): Deleted.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::willCommitLayerTree):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
- 5:14 PM Changeset in webkit [169862] by
-
- 3 edits2 adds in trunk
Subpixel rendering: RenderBox's content clipping should clip on device pixel boundary.
https://bugs.webkit.org/show_bug.cgi?id=133767
<rdar://problem/17272365>
Reviewed by Simon Fraser.
Push RenderBox's content clipping to device pixel boundaries. Integral snapping makes
content cut off prematurely.
Source/WebCore:
Test: fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
LayoutTests:
- fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden-expected.html: Added.
- fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html: Added.
- 4:57 PM Changeset in webkit [169861] by
-
- 4 edits in trunk/Source/WebCore
Remove XHRReplayData::addHeader
https://bugs.webkit.org/show_bug.cgi?id=133776
Reviewed by Antti Koivisto.
Just pass the HTTP header map to XHRReplayData::create directly.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willLoadXHR):
- inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::create):
(WebCore::XHRReplayData::XHRReplayData):
(WebCore::XHRReplayData::addHeader): Deleted.
- inspector/NetworkResourcesData.h:
- 4:53 PM Changeset in webkit [169860] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 4:49 PM Changeset in webkit [169859] by
-
- 1 copy in tags/Safari-537.60.18
New Tag.
- 4:43 PM Changeset in webkit [169858] by
-
- 5 edits in tags/Safari-538.39.41/Source
Version bump.
- 4:42 PM Changeset in webkit [169857] by
-
- 2 edits in tags/Safari-538.39.41/Source/WebCore
Merge r169843.
- 4:17 PM Changeset in webkit [169856] by
-
- 3 edits in branches/safari-537.60-branch/Source/WebCore
Merge r169842.
2014-06-11 Brent Fulgham <Brent Fulgham>
[Win] Avoid deadlock with AVFoundation
https://bugs.webkit.org/show_bug.cgi?id=133762
<rdar://problem/17128248>
Reviewed by Eric Carlson.
Always invoke our notifications asynchronously so that we do not
execute long-running code while holding the AVFWrapper map mutex
lock. AVFoundationCF callbacks can deadlock if we call into AVF
while holding this lock.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::AVFWrapper::legibleOutputCallback): Correct bad assertion.
- 4:12 PM Changeset in webkit [169855] by
-
- 3 edits in trunk/Source/WebCore
Fix the Mac build.
- WebCore.exp.in: Exported ZN7WebCore19ResourceRequestBase15setHTTPReferrerERKN3WTF6StringE
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: Moved ivar declarations to @interface to account for the 32-bit legacy runtime.
- 4:06 PM Changeset in webkit [169854] by
-
- 3 edits2 adds in trunk/Source/WebKit2
[Cocoa] Move CompletionHandlerCallChecker into a separate file
https://bugs.webkit.org/show_bug.cgi?id=133774
Reviewed by Anders Carlsson.
- Shared/Cocoa/CompletionHandlerCallChecker.h: Added.
- Shared/Cocoa/CompletionHandlerCallChecker.mm: Added.
(WebKit::CompletionHandlerCallChecker::create):
(WebKit::CompletionHandlerCallChecker::CompletionHandlerCallChecker):
(WebKit::CompletionHandlerCallChecker::~CompletionHandlerCallChecker):
(WebKit::CompletionHandlerCallChecker::didCallCompletionHandler):
(WebKit::CompletionHandlerCallChecker::classImplementingDelegateMethod):
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::CompletionHandlerCallChecker::create): Deleted.
(WebKit::CompletionHandlerCallChecker::~CompletionHandlerCallChecker): Deleted.
(WebKit::CompletionHandlerCallChecker::didCallCompletionHandler): Deleted.
(WebKit::CompletionHandlerCallChecker::CompletionHandlerCallChecker): Deleted.
(WebKit::CompletionHandlerCallChecker::classImplementingDelegateMethod): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 3:55 PM Changeset in webkit [169853] by
-
- 4 edits in trunk/Source/JavaScriptCore
Inline caching should try to flatten uncacheable dictionaries
https://bugs.webkit.org/show_bug.cgi?id=133683
Reviewed by Geoffrey Garen.
There exists a body of JS code that deletes properties off of objects (especially function/constructor objects),
which puts them into an uncacheable dictionary state. This prevents all future inline caching for these objects.
If properties are deleted out of the object during its initialization, we can enable caching for that object by
attempting to flatten it when we see we're trying to do inline caching with that object. We then record that we
performed this flattening optimization in the object's Structure. If it ever re-enters the uncacheable dictionary
state then we can just give up on caching that object.
In refactoring some of the code in tryCacheGetById and tryBuildGetByIdList to reduce some duplication, I added
the InlineCacheAction enum, a new way to indicate the success or failure of an inline caching attempt. I changed
the other inline caching functions to return this enum rather than the opaque booleans that we were previously
returning.
- jit/Repatch.cpp:
(JSC::actionForCell):
(JSC::tryCacheGetByID):
(JSC::repatchGetByID):
(JSC::tryBuildGetByIDList):
(JSC::buildGetByIDList):
(JSC::tryCachePutByID):
(JSC::repatchPutByID):
(JSC::tryBuildPutByIdList):
(JSC::buildPutByIdList):
(JSC::tryRepatchIn):
(JSC::repatchIn):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::flattenDictionaryStructure):
- runtime/Structure.h:
(JSC::Structure::hasBeenFlattenedBefore):
- 3:52 PM Changeset in webkit [169852] by
-
- 3 edits in trunk/Source/WebCore
Make FrameView 8 bytes smaller
https://bugs.webkit.org/show_bug.cgi?id=133771
Reviewed by Anders Carlsson.
m_borderX and m_borderY were historical cruft.
- page/FrameView.cpp:
(WebCore::FrameView::reset):
- page/FrameView.h:
- 3:49 PM Changeset in webkit [169851] by
-
- 6 edits in trunk/Source/WebKit2
[iOS] Clear UIProcess visual state after WebProcess crash
https://bugs.webkit.org/show_bug.cgi?id=133664
<rdar://problem/16952742>
Reviewed by Benjamin Poulain.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didRelaunchProcess]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didRelaunchProcess):
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::~RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::clearLayers):
- 3:47 PM Changeset in webkit [169850] by
-
- 2 edits in trunk/Source/WebKit2
Implement swipeWithEvent for non-fluid swipes
https://bugs.webkit.org/show_bug.cgi?id=133766
<rdar://problem/17126889>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView swipeWithEvent:]):
On non-fluid swipes, go back or forward depending on the swipe direction.
- 3:41 PM Changeset in webkit [169849] by
-
- 3 edits3 adds in trunk
WindowFeatures arguments shoud ignore invalid characters in values
<http://webkit.org/b/133703>
<rdar://problem/17254118>
Reviewed by Andy Estes.
Source/WebCore:
Test: fast/dom/Window/window-property-invalid-characters-ignored.html
- page/WindowFeatures.cpp:
(WebCore::WindowFeatures::WindowFeatures): Set |length| based on
|buffer|, not |features|. Switch to using a for loop. Switch
to unsigned types since we are working with positive offsets
into a String.
LayoutTests:
- fast/dom/Window/resources/window-property-invalid-characters-ignored.html: Added.
- fast/dom/Window/window-property-invalid-characters-ignored-expected.txt: Added.
- fast/dom/Window/window-property-invalid-characters-ignored.html: Added.
- 3:40 PM Changeset in webkit [169848] by
-
- 3 edits2 adds in trunk
Viewport arguments should ignore invalid characters in values
<http://webkit.org/b/133555>
<rdar://problem/17179650>
Reviewed by Daniel Bates.
Source/WebCore:
Test: fast/viewport/viewport-warnings-7.html
- dom/Document.cpp:
(WebCore::Document::processArguments): Set |length| based on
|buffer|, not |features|. Switch to using a for loop. Switch
to unsigned types since we are working with positive offsets
into a String.
LayoutTests:
- fast/viewport/viewport-warnings-7-expected.txt: Added.
- fast/viewport/viewport-warnings-7.html: Added.
- 3:34 PM Changeset in webkit [169847] by
-
- 3 edits in trunk/Source/WebCore
Move some HTTP header field accessors to ResourceRequestBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=133773
Reviewed by Andreas Kling.
This will avoid having to include HTTPHeaderNames.h from ResourceRequestBase.h.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::httpContentType):
(WebCore::ResourceRequestBase::setHTTPContentType):
(WebCore::ResourceRequestBase::httpReferrer):
(WebCore::ResourceRequestBase::setHTTPReferrer):
(WebCore::ResourceRequestBase::httpOrigin):
(WebCore::ResourceRequestBase::setHTTPOrigin):
(WebCore::ResourceRequestBase::httpUserAgent):
(WebCore::ResourceRequestBase::setHTTPUserAgent):
(WebCore::ResourceRequestBase::httpAccept):
(WebCore::ResourceRequestBase::setHTTPAccept):
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::httpContentType): Deleted.
(WebCore::ResourceRequestBase::setHTTPContentType): Deleted.
(WebCore::ResourceRequestBase::httpReferrer): Deleted.
(WebCore::ResourceRequestBase::setHTTPReferrer): Deleted.
(WebCore::ResourceRequestBase::httpOrigin): Deleted.
(WebCore::ResourceRequestBase::setHTTPOrigin): Deleted.
(WebCore::ResourceRequestBase::httpUserAgent): Deleted.
(WebCore::ResourceRequestBase::setHTTPUserAgent): Deleted.
(WebCore::ResourceRequestBase::httpAccept): Deleted.
(WebCore::ResourceRequestBase::setHTTPAccept): Deleted.
- 3:31 PM Changeset in webkit [169846] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Xcode cannot infer that the WebKit target implicitly depends on WebCore.framework
https://bugs.webkit.org/show_bug.cgi?id=133765
Reviewed by Anders Carlsson.
- Configurations/WebKit.xcconfig: Move linking against WebCore from OTHER_LDFLAGS here...
- WebKit2.xcodeproj/project.pbxproj: ...to the Link Binary With Libraries build phase here.
- 3:08 PM Changeset in webkit [169845] by
-
- 7 edits in trunk/Tools
WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
https://bugs.webkit.org/show_bug.cgi?id=133770
Reviewed by Anders Carlsson.
Push the per-test view configuration up to TestController, so that platforms
can modify the behavior. This also allows platform-specific changes (e.g.
for threaded scrolling) to made without #ifefs.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::updateWebViewSizeForTest):
(WTR::TestController::updateWindowScaleForTest):
(WTR::shouldUseFixedLayout):
(WTR::TestController::updateLayoutTypeForTest):
(WTR::TestController::platformConfigureViewForTest):
(WTR::TestController::configureViewForTest):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::sizeWebViewForCurrentTest): Deleted.
(WTR::changeWindowScaleIfNeeded): Deleted.
(WTR::shouldUseThreadedScrolling): Deleted.
(WTR::updateThreadedScrollingForCurrentTest): Deleted.
(WTR::shouldUseFixedLayout): Deleted.
(WTR::updateLayoutType): Deleted.
- WebKitTestRunner/TestInvocation.h:
(WTR::TestInvocation::pathOrURL):
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::shouldMakeViewportFlexible):
(WTR::TestController::platformConfigureViewForTest):
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::shouldUseThreadedScrolling):
(WTR::TestController::platformConfigureViewForTest):
- 3:01 PM Changeset in webkit [169844] by
-
- 4 edits in trunk/Source/WebCore
Remove some more unneeded member functions from HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=133768
Reviewed by Simon Fraser.
- loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::find): Deleted.
(WebCore::HTTPHeaderMap::keys): Deleted.
- platform/network/HTTPHeaderMap.h:
- 2:57 PM Changeset in webkit [169843] by
-
- 2 edits in trunk/Source/WebCore
Unreviwed Mac release build fix; mark the keyPath parameter as unused.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
- 2:49 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 2:43 PM Changeset in webkit [169842] by
-
- 2 edits in trunk/Source/WebCore
[Win] Avoid deadlock with AVFoundation
https://bugs.webkit.org/show_bug.cgi?id=133762
<rdar://problem/17128248>
Reviewed by Eric Carlson.
Always invoke our notifications asynchronously so that we do not
execute long-running code while holding the AVFWrapper map mutex
lock. AVFoundationCF callbacks can deadlock if we call into AVF
while holding this lock.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
- 2:42 PM Changeset in webkit [169841] by
-
- 2 edits in trunk/Source/WebCore
[CMake] One more URTBF after r169826.
- CMakeLists.txt: Generate files to the proper place.
- 2:38 PM Changeset in webkit [169840] by
-
- 2 edits in trunk/Tools
[EFL] Add dependencies packages to efl install-dependencies file
https://bugs.webkit.org/show_bug.cgi?id=133720
Reviewed by Csaba Osztrogonác.
After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
install doxygen and libssl-dev because efl 1.9 depends on those libraries.
- efl/install-dependencies:
- 2:33 PM Changeset in webkit [169839] by
-
- 2 edits in trunk/Source/WebCore
[CMake]URTBF after r169826.
- CMakeLists.txt: Typo fix.
- 2:32 PM Changeset in webkit [169838] by
-
- 11 edits in tags/Safari-538.39.41/Source/WebCore
Merge r169830.
- 2:29 PM Changeset in webkit [169837] by
-
- 2 edits in trunk/Tools
Unreviewed. Moving myself to the list of reviewers.
- Scripts/webkitpy/common/config/contributors.json:
- 2:28 PM Changeset in webkit [169836] by
-
- 4 edits in trunk/Source/WebCore
Get rid of an unneeded HTTPHeaderMap::remove overload
https://bugs.webkit.org/show_bug.cgi?id=133763
Reviewed by Andreas Kling.
Change HTTPHeaderMap::remove to return whether an entry was removed or not and simplify
ResourceRequestBase::clearHTTPAuthorization.
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::remove):
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
- 2:28 PM Changeset in webkit [169835] by
-
- 3 edits in tags/Safari-538.39.41/WebKitLibraries
Update WKSI for <rdar://problem/17009091>.
Rubber stamped by Eric Carlson.
- libWebKitSystemInterfaceMavericks.a:
- libWebKitSystemInterfaceMountainLion.a:
- 2:28 PM Changeset in webkit [169834] by
-
- 2 edits in trunk/Source/JavaScriptCore
[EFL] URTBF after r169823.
- bindings/ScriptValue.cpp: Missing include added.
- 2:21 PM Changeset in webkit [169833] by
-
- 1 copy in tags/Safari-538.39.41
Tagging.
- 2:11 PM Changeset in webkit [169832] by
-
- 2 edits9 adds in trunk/LayoutTests
[iOS] Enable fast/viewport tests
<http://webkit.org/b/133754>
Reviewed by Andy Estes.
- platform/ios-sim/Skipped:
- Stop skipping fast/viewport tests.
- platform/ios-sim/fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-xhtmlmp-expected.txt: Added.
- platform/ios-sim/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt: Added.
- iOS never supported these "legacy" viewport modes, so add platform-specific results with current behavior.
- 2:04 PM Changeset in webkit [169831] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove an unnecessary asObject(this) call inside JSObject::fastGetOwnPropertySlot.
Rubber-stamped by Andreas Kling.
- runtime/JSObject.h:
(JSC::JSObject::fastGetOwnPropertySlot):
- 2:02 PM Changeset in webkit [169830] by
-
- 11 edits in trunk/Source/WebCore
[EME][Mac] Propagate errors from AVSampleBufferDisplayLayer through to MSE
https://bugs.webkit.org/show_bug.cgi?id=133747
Reviewed by Eric Carlson.
Abstract out the delivery of errors in MediaKeySession into its own method, which can be triggered by
CDMSession objects through the CDMSessionClient interface:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):
(WebCore::MediaKeySession::sendMessage):
(WebCore::MediaKeySession::sendError):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError):
- Modules/mediasource/SourceBuffer.h:
- platform/graphics/SourceBufferPrivateClient.h:
- platform/graphics/CDMSession.h:
Add an Objective-C object which can listen for error KVO notifications:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
(WebCore::SourceBufferPrivateAVFObjCErrorClient::~SourceBufferPrivateAVFObjCErrorClient):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener initWithParent:WebCore::]):
(-[WebAVSampleBufferErrorListener dealloc]):
(-[WebAVSampleBufferErrorListener invalidate]):
(-[WebAVSampleBufferErrorListener beginObservingLayer:]):
(-[WebAVSampleBufferErrorListener stopObservingLayer:]):
(-[WebAVSampleBufferErrorListener beginObservingRenderer:]):
(-[WebAVSampleBufferErrorListener stopObservingRenderer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVSampleBufferErrorListener layerFailedToDecode:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::registerForErrorNotifications):
(WebCore::SourceBufferPrivateAVFObjC::unregisterForErrorNotifications):
(WebCore::SourceBufferPrivateAVFObjC::layerDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):
Register for the new error notifications:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC): Moved to source file.
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC): Register for error notifications.
(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC): Unregister for error notifications.
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError): Pass through to CDMSessionClient.
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError): Ditto.
- 1:49 PM Changeset in webkit [169829] by
-
- 2 edits in trunk/Source/WebCore
Don't force CharacterData to override getOwnPropertySlot.
<https://webkit.org/b/133717>
This was preventing us from taking the GetByVal fast path for Text nodes
since they inherit from CharacterData and having a "length" attribute
meant we gave them a custom getOwnPropertySlot, despite not actually
needing it for anything.
Reviewed by Anders Carlsson.
- bindings/scripts/CodeGeneratorJS.pm:
(AttributeShouldBeOnInstance):
- 1:46 PM Changeset in webkit [169828] by
-
- 2 edits in trunk/LayoutTests
inspector-protocol/debugger/breakpoint-action-detach.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=133761
- TestExpectations: Skipped it. Updated bug number for another inspector-protocol
test while at it.
- 1:43 PM Changeset in webkit [169827] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] Don't dispatch view state changes immediately
https://bugs.webkit.org/show_bug.cgi?id=133713
Reviewed by Simon Fraser.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::dispatchViewStateChange):
(WebKit::WebPageProxy::updateViewState): Deleted.
- UIProcess/WebPageProxy.h:
On PLATFORM(COCOA), wait until just before CA is going to commit the UI process layer
tree to dispatch view state changes to the Web process. This avoids sending multiple
view state change messages to the Web process within one run-loop cycle, for example
when a view is moved around in the view hierarchy but the view state otherwise remains the same.
- 1:42 PM Changeset in webkit [169826] by
-
- 5 edits2 adds in trunk/Source/WebCore
Add a script that generates a gperf hash for HTTP header names
https://bugs.webkit.org/show_bug.cgi?id=133760
Reviewed by Andreas Kling.
This is the first step towards getting rid of AtomicString from HTTPHeaderMap.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/HTTPHeaderNames.in: Added.
- platform/network/create-http-header-name-table: Added.
(HTTPHeaderName):
- 1:37 PM Changeset in webkit [169825] by
-
- 3 edits in trunk/Source/WebKit2
Make it possible for waitForAndDispatchImmediately to bail if a sync message comes in from the other direction
https://bugs.webkit.org/show_bug.cgi?id=133708
Reviewed by Anders Carlsson.
- Platform/IPC/Connection.cpp:
(IPC::WaitForMessageState):
(IPC::Connection::Connection):
(IPC::Connection::waitForMessage):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::connectionDidClose):
- Platform/IPC/Connection.h:
(IPC::Connection::waitForAndDispatchImmediately):
Remove the waitForMessageMap, and assert that we're only ever waiting for one message at a time.
This simplifies this code a bit, and we never wait on more than one message at a time, so it was unnecessary.
Add a flag to waitForAndDispatchImmediately, InterruptWaitingIfSyncMessageArrives, which will cause
waitForAndDispatchImmediately to bail if a sync message arrives, to avoid pointlessly blocking both processes
for the entire timeout.
- 1:21 PM Changeset in webkit [169824] by
-
- 6 edits in trunk/Source
Turning on DUMP_PROPERTYMAP_STATS causes a build failure
https://bugs.webkit.org/show_bug.cgi?id=133673
Reviewed by Andreas Kling.
Source/JavaScriptCore:
Rewrote the property map statistics code because the old code wasn't building,
and it was also mixing numbers for lookups and insertions/removals.
New logging code records the number of calls to PropertyTable::find (finds) and
PropertyTable::get/PropertyTable::findWithString separately so that we can quantify
the number of probing during updates and lookups.
- jsc.cpp:
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::find):
(JSC::PropertyTable::get):
(JSC::PropertyTable::findWithString):
(JSC::PropertyTable::add):
(JSC::PropertyTable::remove):
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):
- runtime/Structure.cpp:
(JSC::PropertyMapStatisticsExitLogger::PropertyMapStatisticsExitLogger):
(JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):
Source/WTF:
Added DEFINE_GLOBAL_FOR_LOGGING to allow running a destructor in logging code
that needs to be enabled in release builds (e.g. for JavaScriptCore).
- wtf/StdLibExtras.h:
- 1:16 PM Changeset in webkit [169823] by
-
- 5 edits in trunk/Source/JavaScriptCore
Always inline JSValue::get() and Structure::get().
<https://webkit.org/b/133755>
Reviewed by Ryosuke Niwa.
These functions get really hot, so ask the compiler to be more
aggressive about inlining them.
~28% speed-up on Ryosuke's microbenchmark for accessing nextSibling
through GetByVal.
- runtime/JSArrayIterator.cpp:
- runtime/JSCJSValue.cpp:
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::get):
- runtime/JSPromiseDeferred.cpp:
- runtime/StructureInlines.h:
(JSC::Structure::get):
- 1:15 PM Changeset in webkit [169822] by
-
- 2 edits in trunk/Source/JavaScriptCore
Structure::get should instantiate DeferGC only when materializing property map
https://bugs.webkit.org/show_bug.cgi?id=133727
Rubber-stamped by Andreas Kling.
Make materializePropertyMapIfNecessary always inline.
This is ~12% improvement on the microbenchmark attached in the bug.
- runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
- 1:13 PM Changeset in webkit [169821] by
-
- 2 edits in trunk/Source/WebKit2
Restrict database process profile
https://bugs.webkit.org/show_bug.cgi?id=133750
Reviewed by Alexey Proskuryakov.
Make the sandbox profile much more restrictive.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
- 12:59 PM Changeset in webkit [169820] by
-
- 5 edits in trunk/Source/WebKit2
Don't snapshot offscreen plugins that would normally be considered primary plugins after they are moved in view.
https://bugs.webkit.org/show_bug.cgi?id=133667.
<rdar://problem/16743250>
Reviewed by Tim Horton.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
(WebKit::PluginView::pluginSnapshotTimerFired):
Set the display state to Playing if the following is true:
The plugin in question is large enough to be considered the primary snapshot and either:
a) The maximum number of snapshot retries has been reached and no good snapshot has been found.
b) The plugin is moved to be on-screen while the snapshot attempts are in progress.
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::plugInIntersectsSearchRect): Re-factor out intersection logic.
(WebKit::WebPage::plugInIsPrimarySize): Re-factor out primary plugin size logic.
(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Use the above two methods here.
- WebProcess/WebPage/WebPage.h:
- 12:55 PM Changeset in webkit [169819] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
Ensured Native Calls and Construct and associated checks
are only emitted during ftl mode.
https://bugs.webkit.org/show_bug.cgi?id=133718
Patch by Matthew Mirman <mmirman@apple.com> on 2014-06-11
Reviewed by Filip Pizlo.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall): Added check for ftl mode
before attaching the native function to Call or Construct.
- 12:49 PM Changeset in webkit [169818] by
-
- 7 edits in trunk/Source/WebKit2
Move more WKPreferences to WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=133756
<rdar://problem/17271468>
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKPreferences.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences setMinimumFontSize:]):
(-[WKPreferences suppressesIncrementalRendering]): Deleted.
(-[WKPreferences setSuppressesIncrementalRendering:]): Deleted.
(-[WKPreferences allowsInlineMediaPlayback]): Deleted.
(-[WKPreferences setAllowsInlineMediaPlayback:]): Deleted.
(-[WKPreferences mediaPlaybackRequiresUserAction]): Deleted.
(-[WKPreferences setMediaPlaybackRequiresUserAction:]): Deleted.
(-[WKPreferences mediaPlaybackAllowsAirPlay]): Deleted.
(-[WKPreferences setMediaPlaybackAllowsAirPlay:]): Deleted.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
- WebKit2.xcodeproj/project.pbxproj:
- 12:31 PM Changeset in webkit [169817] by
-
- 3 edits in trunk/WebKitLibraries
Update WKSI for <rdar://problem/17009091>.
Rubber stamped by Eric Carlson.
- libWebKitSystemInterfaceMavericks.a:
- libWebKitSystemInterfaceMountainLion.a:
- 12:29 PM Changeset in webkit [169816] by
-
- 5 edits in trunk/Source/JavaScriptCore
Structure::get should instantiate DeferGC only when materializing property map
https://bugs.webkit.org/show_bug.cgi?id=133727
Reviewed by Geoffrey Garen.
DeferGC instances in Structure::get was added in http://trac.webkit.org/r157539 in order to avoid
collecting the property table newly created by materializePropertyMapIfNecessary since GC can happen
when GCSafeConcurrentJITLocker goes out of scope.
However, always instantiating DeferGC inside Structure::get introduced a new performance bottleneck
in JSObject::getPropertySlot because frequently incrementing and decrementing a counter in vm.m_heap
and running a release assertion inside Heap::incrementDeferralDepth() is expensive.
Work around this by instantiating DeferGC only when we're actually calling materializePropertyMap,
and immediately storing a pointer to the newly created property table in the stack before DeferGC
goes out of scope so that the property table will be marked.
This shows 13-16% improvement on the microbenchmark attached in the bug.
- runtime/JSCJSValue.cpp:
- runtime/JSObject.h:
(JSC::JSObject::fastGetOwnPropertySlot):
- runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
- runtime/StructureInlines.h:
(JSC::Structure::get):
- 11:40 AM Changeset in webkit [169815] by
-
- 3 edits in trunk/Source/JavaScriptCore
Some JSValue::get() micro-optimzations.
<https://webkit.org/b/133739>
Tighten some of the property lookup code to improve performance of the
eagerly reified prototype attributes:
- Instead of converting the property name to an integer at every step in the prototype chain, move that to a separate pass at the end since it should be a rare case.
- Cache the StructureIDTable in a local instead of fetching it from the Heap on every step.
- Make fillCustomGetterPropertySlot inline. It was out-of-lined based on the assumption that clients would mostly be cacheable GetByIds, and it gets pretty hot (~1%) in GetByVal.
- Pass the Structure directly to fillCustomGetterPropertySlot instead of refetching it from the StructureIDTable.
Reviewed by Geoff Garen.
- runtime/JSObject.cpp:
(JSC::JSObject::fillCustomGetterPropertySlot): Deleted.
- runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::fillCustomGetterPropertySlot):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::getOwnPropertySlotSlow): Deleted.
- 11:36 AM Changeset in webkit [169814] by
-
- 3 edits in trunk/Source/WebCore
ROLLOUT: r153510: Broke Table borders on Wikipedia
https://bugs.webkit.org/show_bug.cgi?id=132802
<rdar://problem/16792562>
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::alignLeftRightBorderPaintRect): Deleted.
(WebCore::RenderTableCell::alignTopBottomBorderPaintRect): Deleted.
- rendering/RenderTableCell.h:
- 11:06 AM Changeset in webkit [169813] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2 iOS: Unable to open UI menu for "open in new tab" for links on yahoo.com.
https://bugs.webkit.org/show_bug.cgi?id=133749
<rdar://problem/17165992>
Reviewed by Brady Eidson.
The URL returned to the UIProcess as string needs to be encoded.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 10:44 AM Changeset in webkit [169812] by
-
- 7 edits in trunk/Source/WebKit2
Move suppressesIncrementalRendering to WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=133707
<rdar://problem/17271468>
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKPreferences.h:
Get rid of suppressesIncrementalRendering.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Set the suppressesIncrementalRenderingKey key in webPageConfiguration.preferenceValues.
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
Add suppressesIncrementalRendering.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
Assign suppressesIncrementalRendering.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Copy webPageConfiguration.preferenceValues to m_configurationPreferenceValues.
(WebKit::WebPageProxy::preferencesStore):
If m_configurationPreferenceValues is empty, just return m_preferences->store(). Otherwise,
copy the store and apply the configuration preference values.
(WebKit::WebPageProxy::preferencesDidChange):
Call preferencesStore() so we'll get the configuration preference values as well.
(WebKit::WebPageProxy::creationParameters):
Ditto.
- UIProcess/WebPageProxy.h:
- 10:27 AM Changeset in webkit [169811] by
-
- 6 edits in trunk/Source/WebCore
[Curl] Empty headers in request response.
https://bugs.webkit.org/show_bug.cgi?id=133483
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-06-11
Reviewed by Brent Fulgham.
When a request is taken from the cache, its cached response headers are empty, if the cache entry was created in the same session.
It is only when the cache entry is loaded from disc, that the response headers are properly set.
We need to set the cached response headers in both cases.
There is also an issue if two jobs are loading the same url at the same time.
Both jobs will then write to the cache content file, and create invalid content.
This can be fixed by only letting the first request write to the content file.
- platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::CurlCacheEntry):
(WebCore::CurlCacheEntry::isLoading): Added method to check if cache entry is loading the content.
(WebCore::CurlCacheEntry::saveResponseHeaders): Set the cached response headers when response is saved.
(WebCore::CurlCacheEntry::invalidate): To be on the safe side, close content file when entry is invalidated.
(WebCore::CurlCacheEntry::parseResponseHeaders): Made parameter const.
- platform/network/curl/CurlCacheEntry.h: Keep track of which job is creating this cache entry.
(WebCore::CurlCacheEntry::getJob):
- platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::loadIndex): When cache entry is loaded from disc, there is no associated job.
(WebCore::CurlCacheManager::didReceiveResponse): Bail out if cache entry is already currently loading,
otherwise associate this job with the new cache entry.
(WebCore::CurlCacheManager::didFinishLoading): Changed parameter type.
(WebCore::CurlCacheManager::isCached): Don't report the url as cached if it's currently loading content.
(WebCore::CurlCacheManager::didReceiveData): Don't write to the content file if the entry is not associated with the job.
(WebCore::CurlCacheManager::didFail): Changed parameter type.
- platform/network/curl/CurlCacheManager.h: Changed parameter type.
- platform/network/curl/ResourceHandleManager.cpp: Ditto.
(WebCore::writeCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
- 10:03 AM Changeset in webkit [169810] by
-
- 19 edits in trunk/Source/WebCore
REGRESSION (r133705): Layout Test js/dom/webidl-type-mapping.html is failing
https://bugs.webkit.org/show_bug.cgi?id=133736
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Turns out we can't remove the HashTable yet after all, as JavaScriptCore
relies on hasSetterOrReadonlyProperties bit to make put work correctly. We
can, however, skip creating the table, and just use the value array during
reification.
- 9:12 AM Changeset in webkit [169809] by
-
- 2 edits in trunk/Source/WebCore
AX: iOS: VoiceOver ignores input type = date in Safari on iOS7
https://bugs.webkit.org/show_bug.cgi?id=133709
Reviewed by Mario Sanchez Prada.
The date field on iOS appears as a popup button, which is not a type we had encountered for <input> types.
This returns an appropriate role in that case.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- 8:37 AM Changeset in webkit [169808] by
-
- 2 edits in trunk/Tools
[EFL] Drop to maintain EFL 32bit release bot
https://bugs.webkit.org/show_bug.cgi?id=133710
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
- 8:36 AM Changeset in webkit [169807] by
-
- 4 edits2 adds in trunk/Source/WebKit2
Wrap NSURLRequest in bundle API
https://bugs.webkit.org/show_bug.cgi?id=133732
<rdar://problem/17267217>
Reviewed by Andreas Kling.
Patch by Dan Bernstein.
We don't want to construct actual NSURLRequests in the web process side unless really needed as it is slow.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
- Shared/Cocoa/WKNSURLRequest.h: Added.
(WebKit::wrapper):
- Shared/Cocoa/WKNSURLRequest.mm: Added.
Add a wrapper object that initializes the underlying NSURLRequest on-demand.
(-[WKNSURLRequest _web_createTarget]):
(-[WKNSURLRequest URL]):
(-[WKNSURLRequest copyWithZone:]):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(willSendRequestForFrame):
(didInitiateLoadForResource):
- 7:42 AM Changeset in webkit [169806] by
-
- 1 edit1 add2 deletes in trunk/LayoutTests
[GTK] Unreviewed GTK gardening
Add missing GTK expectations file after test added at r169390, and removed specific
ones for tests now passing with default ones after r169403.
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-06-11
- platform/gtk/fast/dom/webtiming-document-open-expected.txt: Removed.
- platform/gtk/fast/dom/webtiming-navigate-within-document-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination/nested-transforms-expected.txt: Added.
- 7:30 AM Changeset in webkit [169805] by
-
- 10 edits in trunk/Source/WebKit2
<rdar://problem/17218629> [Cocoa] WKWebView’s canGoBack and canGoForward properties are not KVO-compliant
https://bugs.webkit.org/show_bug.cgi?id=133722
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm: Added no-op overrides of new
PageLoadStateObserver member functions.
- UIProcess/API/Cocoa/WKWebView.h: Documented the canGoBack and canGoForward properties as
being KVO-compliant.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView canGoBack]): Changed to get the return value from the page load state.
(-[WKWebView canGoForward]): Ditto.
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::willChangeCanGoBack): Override this new PageLoadStateObserver
member function by sending the appropriate KVO change message to the WKWebView.
(WebKit::NavigationState::didChangeCanGoBack): Ditto.
(WebKit::NavigationState::willChangeCanGoForward): Ditto.
(WebKit::NavigationState::didChangeCanGoForward): Ditto.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::commitChanges): Check for changes to canGoBack and canGoForward
and call the observers if needed.
(WebKit::PageLoadState::canGoBack): Added. Returns the value from the committed state.
(WebKit::PageLoadState::setCanGoBack): Added. Sets the value in the uncommitted state.
(WebKit::PageLoadState::canGoForward): Added. Returns the value from the committed state.
(WebKit::PageLoadState::setCanGoForward): Added. Sets the value in the uncommitted state.
- UIProcess/PageLoadState.h:
(WebKit::PageLoadState::Data::Data): Added canGoBack and canGoForward boolean members.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList): Update the page load state with the new
state of canGoBack and canGoForward.
- UIProcess/WebPageProxy.h: Removed unused member variables m_canGoBack and m_canGoForward.
- 5:50 AM Changeset in webkit [169804] by
-
- 2 edits in trunk/LayoutTests
[EFL] Updated expectations for accessibility/lists.html test
https://bugs.webkit.org/show_bug.cgi?id=132818
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-06-11
Reviewed by Mario Sanchez Prada.
- platform/efl-wk1/accessibility/lists-expected.txt:
- 5:22 AM Changeset in webkit [169803] by
-
- 3 edits in trunk/Source/WebKit2
Avoid Vector copies in WebNotificationManagerProxy::providerDidCloseNotifications(), FindController::findStringMatches()
https://bugs.webkit.org/show_bug.cgi?id=133676
Reviewed by Andreas Kling.
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications): Move the newly-created
Vector object into the HashMap<>::add() call.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findStringMatches): Movethe newly-create Vector object into the
Vector<>::append() call.
- 5:20 AM Changeset in webkit [169802] by
-
- 2 edits in trunk/Source/WebCore
Avoid FontGlyphsCacheKey copy in FontGlyphsCacheEntry constructor
https://bugs.webkit.org/show_bug.cgi?id=133674
Reviewed by Andreas Kling.
- platform/graphics/Font.cpp:
(WebCore::FontGlyphsCacheEntry::FontGlyphsCacheEntry): The FontGlyphsCacheKey
variable is already passed-in as an rvalue reference, so it should be moved
into the constructor of the corresponding member variable instead of copied.
- 4:56 AM Changeset in webkit [169801] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Add missing test cases for EWK2ViewTest.
https://bugs.webkit.org/show_bug.cgi?id=133715
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-06-11
Reviewed by Gyuyoung Kim.
Add missing test cases for ewk_view.h APIs, ewk_view_stop(), ewk_view_html_string_load(), ewk_view_theme_get(),
ewk_view_feed_touch_event(), ewk_view_text_find_highlight_clear(), ewk_view_text_find(), ewk_view_text_matches_count(),
ewk_view_page_contents_get(), ewk_view_script_execute().
- PlatformEfl.cmake:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 3:46 AM Changeset in webkit [169800] by
-
- 2 edits in trunk/Source/WebCore
Fix the build after after r169789 on platforms that build with -Wunused-const-variable
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable): Don't create the value array if it'll never be used.
- 12:38 AM Changeset in webkit [169799] by
-
- 15 edits1 add in trunk
[GTK] Use a different user agent string depending on the site
https://bugs.webkit.org/show_bug.cgi?id=132681
Reviewed by Anders Carlsson.
Source/WebCore:
We have changed the user agent string several times to try to fix
broken websites that require specific things in the UA string to
properly work. But everytime we change the UA string to fix a
website we break others. We could use different UA string
depending on the website. UserAgentGtk code has also been cleaned
up, using NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL
and avoiding unneeded conversions to UTF-8.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::UserAgentQuirks::UserAgentQuirks): New helper private
class to handle user agent quirks.
(WebCore::UserAgentQuirks::add):
(WebCore::UserAgentQuirks::contains):
(WebCore::UserAgentQuirks::isEmpty):
(WebCore::platformForUAString): Bring back this method that was
removed to always pretend to be Macintosh.
(WebCore::platformVersionForUAString): Return a different platform
version depending on the actual platform.
(WebCore::versionForUAString): Return the WebKit version.
(WebCore::buildUserAgentString): Helper function to build the user
agent taking into account the UserAgentQuirks received.
(WebCore::standardUserAgentStatic): Standard user agent string
when no quirks are present.
(WebCore::standardUserAgent):
(WebCore::standardUserAgentForURL): New method that returns the
user agent string for the given URL.
- platform/gtk/UserAgentGtk.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_class_init): Enable site specific quirks setting
by default.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::userAgent): Pass the given URL to WebPage.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::userAgent): Try to get the user agent for the
URL received falling back to the current one otherwise.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::platformUserAgent): Added.
- WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::platformUserAgent): Return null String.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformUserAgent): Use WebCore::standardUserAgentForURL() when site specific quirks
setting is enabled.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformUserAgent): Return null String.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformUserAgent): Return null String.
Tools:
Add a unit test to check user agent quirks.
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
(testWebKitSettings): Site specific quirks setting is now enabled
by default.
- 12:13 AM Changeset in webkit [169798] by
-
- 2 edits in trunk
Unreviewed, EFL build fix. Treat literal-suffix error as build warning.
- Source/cmake/WebKitHelpers.cmake:
- 12:02 AM Changeset in webkit [169797] by
-
- 4 edits in trunk/Source
[Win] Unreviewed build fix.
Source/WebCore:
- platform/network/curl/ResourceRequest.h:
Include missing PassOwnPtr.h.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Fixed 64-bit linker symbol.
