Timeline



Feb 19, 2008:

6:17 PM Changeset in webkit [30421] by Darin Adler
  • 6 edits in trunk/WebCore

Reviewed by Sam.

  • removed use of DeprecatedString for font family names
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Update for name change.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseFontFamily): Update to use new appendSpaceSeparated function and String rather than DeprecatedString.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Updated for name change.
  • css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::FontFamilyValue): Replaced code using a regular expression with code that does the same thing more efficiently. (WebCore::FontFamilyValue::appendSpaceSeparated): Added. (WebCore::FontFamilyValue::cssText): Updated for name change.
  • css/FontFamilyValue.h: Changed DeprecatedString to String. Renamed fontName to familyName and parsedFontName to m_familyName. Removed unused genericFamilyType and m_genericFamilyType. Added appendSpaceSeparated so that m_familyName can be private instead of public.
6:07 PM Changeset in webkit [30420] by Darin Adler
  • 2 edits in trunk/WebCore
  • fix build when SVG is not enabled
  • rendering/RenderTreeAsText.cpp: Added include of "TextStream.h".
5:55 PM Changeset in webkit [30419] by andersca@apple.com
  • 23 edits in trunk/WebCore

Reviewed by Darin.

Change all classes in xml/ to start out with a ref count of 1.


  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSXMLHttpRequest.cpp: (WebCore::JSXMLHttpRequest::JSXMLHttpRequest):
  • bindings/js/JSXSLTProcessor.cpp: (WebCore::JSXSLTProcessor::JSXSLTProcessor):
  • bindings/objc/DOMCustomXPathNSResolver.h: (WebCore::DOMCustomXPathNSResolver::create):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Document.cpp: (WebCore::Document::applyXSLTransform): (WebCore::Document::createExpression): (WebCore::Document::createNSResolver): (WebCore::Document::evaluate):
  • xml/DOMParser.h: (WebCore::DOMParser::create): (WebCore::DOMParser::DOMParser):
  • xml/NativeXPathNSResolver.h: (WebCore::NativeXPathNSResolver::create):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::create):
  • xml/XMLSerializer.h: (WebCore::XMLSerializer::create): (WebCore::XMLSerializer::XMLSerializer):
  • xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::createNSResolver):
  • xml/XPathEvaluator.h: (WebCore::XPathEvaluator::create): (WebCore::XPathEvaluator::XPathEvaluator):
  • xml/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): (WebCore::XPathExpression::evaluate):
  • xml/XPathExpression.h: (WebCore::XPathExpression::create): (WebCore::XPathExpression::XPathExpression):
  • xml/XPathNSResolver.h:
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
  • xml/XPathResult.h: (WebCore::XPathResult::create):
  • xml/XPathValue.cpp: (WebCore::XPath::Value::modifiableNodeSet):
  • xml/XPathValue.h: (WebCore::XPath::ValueData::create): (WebCore::XPath::ValueData::ValueData): (WebCore::XPath::Value::Value):
  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::create): (WebCore::XSLTProcessor::XSLTProcessor):
5:51 PM Changeset in webkit [30418] by Darin Adler
  • 9 edits in trunk

WebCore:

Reviewed by Sam.

  • Trimmed down TextStream and weaned it from DeprecatedString.
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge renderTreeAsExternalRepresentation]): Removed now-unneeded call to getNSString.
  • platform/text/TextStream.cpp: Removed unused functions. Use snprintf instead of sprintf, for better security. (WebCore::TextStream::release): Added.
  • platform/text/TextStream.h: Removed lots of unneeded stuff.
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Changed to use String instead of DeprecatedString.
  • rendering/RenderTreeAsText.h: Ditto.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGInlineTextBox): Use "\n" instead of endl. (WebCore::write): Ditto. (WebCore::writeRenderResources): Ditto.

WebKit/win:

Reviewed by Sam.

  • WebFrame.cpp: (WebFrame::renderTreeAsExternalRepresentation): Changed to use String instead of DeprecatedString.
5:43 PM Changeset in webkit [30417] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes


This brings performance on the phone back to old levels. Andre and I are doing
some formal testing to see exactly where we stand.

  • dom/Position.cpp: (WebCore::enclosingBlockIgnoringEditability): Added. This is enclosingBlock without the expensive editability checks. upstream and downstream can avoid those because they do their own editability checking. (WebCore::Position::upstream): (WebCore::Position::downstream):
4:41 PM Changeset in webkit [30416] by harrison@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3663560> AXLink for a "name" (anchor) on same page should include an AXLinkedUIElementAttribute

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject linkedUIElement]): Returns the linked-to AX object (if the specified one is ignored by accessibility, returns the next un-ignored one by traversing the DOM).


(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
Support NSAccessibilityLinkedUIElementsAttribute.

4:00 PM Changeset in webkit [30415] by Darin Adler
  • 39 edits in trunk/WebCore

Reviewed by Sam.

  • Removed old debugging aids, Node::dump, RenderObject::dump, and RenderObject::information, that used DeprecatedString.
  • dom/CharacterData.cpp: Removed override of Node::dump.
  • dom/CharacterData.h: Ditto.
  • dom/Element.cpp: Ditto.
  • dom/Element.h: Ditto.
  • dom/EventTargetNode.cpp: Ditto.
  • dom/EventTargetNode.h: Ditto.
  • dom/Node.cpp: Removed Node::dump.
  • dom/Node.h: Ditto.
  • rendering/RenderBlock.cpp: Removed override of RenderObject::dump.
  • rendering/RenderBlock.h: Ditto.
  • rendering/RenderFrameSet.cpp: Ditto.
  • rendering/RenderFrameSet.h: Ditto.
  • rendering/RenderObject.cpp: Removed RenderObject::dump and RenderObject::information.
  • rendering/RenderObject.h: Ditto.
  • rendering/RenderTable.cpp: Removed override of RenderObject::dump.
  • rendering/RenderTable.h: Ditto.
  • rendering/RenderTableCell.cpp: Ditto.
  • rendering/RenderTableCell.h: Ditto.
  • rendering/RenderTableCol.cpp: Ditto.
  • rendering/RenderTableCol.h: Ditto.
  • rendering/RenderTableSection.cpp: Ditto.
  • rendering/RenderTableSection.h: Ditto.
  • rendering/RenderTreeAsText.h: Removed unneeded include of TextStream.h and added forward declarations as appropriate.
  • svg/SVGSVGElement.cpp: Removed unneeded include of TextStream.h.
  • svg/graphics/SVGResourceClipper.cpp: And here.
  • svg/graphics/SVGResourceFilter.cpp: Ditto.
  • svg/graphics/filters/SVGFEBlend.cpp: Ditto.
  • svg/graphics/filters/SVGFEComponentTransfer.cpp: Ditto.
  • svg/graphics/filters/SVGFEComposite.cpp: Ditto.
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto.
  • svg/graphics/filters/SVGFEGaussianBlur.cpp: Ditto.
  • svg/graphics/filters/SVGFEImage.cpp: Ditto.
  • svg/graphics/filters/SVGFEMerge.cpp: Ditto.
  • svg/graphics/filters/SVGFEMorphology.cpp: Ditto.
  • svg/graphics/filters/SVGFEOffset.cpp: Ditto.
  • svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto.
  • svg/graphics/filters/SVGFETurbulence.cpp: Ditto.
  • svg/graphics/filters/SVGFilterEffect.cpp: Ditto.
3:26 PM Changeset in webkit [30414] by Beth Dakin
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Sam.

Fix for <rdar://problem/5729674> Seed: Crash in
RenderButton::setStyle at ​http://www.dinorpg.com

Inputs should not honor first-letter.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):

LayoutTests:

Reviewed by Sam.

Test for <rdar://problem/5729674> Seed: Crash in
RenderButton::setStyle at ​http://www.dinorpg.com

  • fast/forms/input-first-letter.html: Added.
  • platform/mac/fast/forms/input-first-letter-expected.checksum: Added.
  • platform/mac/fast/forms/input-first-letter-expected.png: Added.
  • platform/mac/fast/forms/input-first-letter-expected.txt: Added.
3:23 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
2:09 PM Changeset in webkit [30413] by andersca@apple.com
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin.

Change OpaqueJSClass and RootObject to start with a ref count of 1.


  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): (OpaqueJSClass::createNoAutomaticPrototype): (OpaqueJSClass::create):
  • API/JSClassRef.h:
  • API/JSObjectRef.cpp: (JSClassCreate):
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::create): (KJS::Bindings::RootObject::RootObject):
1:13 PM Changeset in webkit [30412] by mitz@apple.com
  • 11 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15

Test: fast/text/wbr-styled.html

Changed RenderWordBreak to inherit from RenderText instead of
RenderInline.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/RenderFlow.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::renderName): (WebCore::RenderText::isTextFragment): (WebCore::RenderText::isWordBreak):
  • rendering/RenderText.h:
  • rendering/RenderWordBreak.cpp: (WebCore::RenderWordBreak::RenderWordBreak):
  • rendering/RenderWordBreak.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15
  • fast/text/wbr-styled.html: Added.
  • platform/mac-leopard/fast/text/wbr-styled-expected.checksum: Added.
  • platform/mac-leopard/fast/text/wbr-styled-expected.png: Added.
  • platform/mac/fast/css-generated-content/wbr-with-before-content-expected.txt:
  • platform/mac/fast/text/wbr-pre-expected.txt:
  • platform/mac/fast/text/wbr-styled-expected.txt: Added.
11:42 AM Changeset in webkit [30411] by andersca@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog

11:42 AM Changeset in webkit [30410] by andersca@apple.com
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

WARNING: NO TEST CASES ADDED OR CHANGED

  • ChangeLog:
  • WebCore.base.exp:
  • loader/mac/LoaderNSURLExtras.h:
  • loader/mac/LoaderNSURLExtras.m: Move unused functions to WebKit (where they are used)


(vectorContainsString):
Use const references.


  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: Remove wkNSURLProtocolClassForReqest.

WebKit/mac:

Reviewed by Darin.

Move back WebKit methods that were unused in WebCore.


  • Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_isEmpty]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isFileURL]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setTitle):
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
11:28 AM Changeset in webkit [30409] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore


These changes bring deleting performance back to old levels on the phone
except for deleting the first space to the right of a word, which we are
still working on.

  • dom/Position.cpp: (WebCore::Position::upstream): Avoid the use of enclosingBlock when determining if we have left the original enclosing block or entered a new one, and avoid rootEditableElement for determining if we have changed editability. These operations are expensive. (WebCore::Position::downstream): Ditto.
11:16 AM Changeset in webkit [30408] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

Rubber stamped by Anders.

  • removed explicit initialization to 1 for RefCounted; that's now the default
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Removed RefCounted initializer.

WebCore:

Rubber stamped by Anders.

  • removed explicit initialization to 1 for RefCounted; that's now the default
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): Removed RefCounted initializer.
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): Ditto.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Ditto.
11:08 AM Changeset in webkit [30407] by beidson@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Geoff

Fixed a bug in DRT --threaded mode

  • DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: (startJavaScriptThreads): Don't detach the newly created thread. The later call to stopJavaScriptThreads() tries to pthread_join() each thread that had been created, but you can't join a detached thread!
11:06 AM Changeset in webkit [30406] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • wtf/RefCounted.h: (WTF::RefCounted::RefCounted): Have refcounts default to 1. This allows us to start removing the explicit initialization of RefCounted from classes and eventually we can remove the ability to have the initial count of 0 entirely.
10:25 AM Changeset in webkit [30405] by andersca@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Make ResourceLoader and ResourceHandle start out with a refcount of 1.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::create):
  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::create):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
5:05 AM Changeset in webkit [30404] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-02-19 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] tab focusing doesn't work

GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
the meta key state.

Use GDK_META_MASK where available, otherwise do not support the meta
key. This matches the behaviour of other applications.

Also add a comment noting that the platform event constructors need to
be kept in sync (it's not obvious that there are multiple places that
check the key state).

  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/gtk/MouseEventGtk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Feb 18, 2008:

11:17 PM Changeset in webkit [30403] by beidson@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Sam Weinig's white rhino tusk stamp

SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop):
11:15 PM Changeset in webkit [30402] by beidson@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig's rubberstamp

SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase

  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop):
11:04 PM Changeset in webkit [30401] by mrowe@apple.com
  • 3 edits in branches/Safari-3-1-branch/LayoutTests

Merge r30399.

11:03 PM Changeset in webkit [30400] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Make Drosera work on Vista.


Runtime type library registration on Vista requires use of two new call:
RegisterTypeLibraryForUser and UnRegisterTypeLibraryForUser, which write to
HKCU. LoadTypeLib[Ex] registers under HKLM, which fails under vista due to UAC.


Reviewed by Adam.

  • WebKitDLL.cpp: (DllUnregisterServer): Call UnRegisterTypeLibraryForUser if available. Fix version number. (DllRegisterServer): Call RegisterTypeLibraryForUser if available.
10:24 PM Changeset in webkit [30399] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Adam Roben in California.

  • remove unnecessary and erroneous layoutTestController calls from a test
  • fast/css/font-face-multiple-remote-sources.html:
  • platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt:
9:42 PM Changeset in webkit [30398] by mrowe@apple.com
  • 5 edits
    2 adds in branches/Safari-3-1-branch

Merge r30395.

9:41 PM Changeset in webkit [30397] by mrowe@apple.com
  • 4 edits
    4 adds in branches/Safari-3-1-branch

Merge r30392.

9:40 PM Changeset in webkit [30396] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30389.

9:19 PM Changeset in webkit [30395] by beidson@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

Reviewed by Darin

Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released

Test: platform/mac/plugins/webScriptObject-exception-deadlock.html

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject valueForKey:]): The line resultObj = [super valueForKey:key]; // defaults to throwing an exception says it all - it throws an exception. This method also happens to hold the JSLock. Problematically, when the exeception is thrown and the method exited, the JSLock is never released. Fix that without otherwise changing behavior by holding the JSLock in two individual scopes - Right before the exception and right after.

WebKitTools:

Changes by Geoff Garen, Reviewed by Darin

Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released

DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html

[WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread. If the lock has leaked,
this series of method calls will deadlock. If things are good, it will complete successfully.

  • DumpRenderTree/mac/ObjCController.m: (runJavaScriptThread): (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController testValueForKey]):

LayoutTests:

Reviewed by Darin

Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released

  • platform/mac-tiger/Skipped: Removed 2 hanging tests that now don't hang
  • platform/mac/plugins/webScriptObject-exception-deadlock-expected.txt: Added.
  • platform/mac/plugins/webScriptObject-exception-deadlock.html: Added.
8:07 PM Changeset in webkit [30394] by pewtermoose@webkit.org
  • 4 edits in trunk

Remove FindSafari's Release configuration.

6:21 PM Changeset in webkit [30393] by Darin Adler
  • 20 edits in trunk

WebCore:

Reviewed by Sam.

  • reduce use of DeprecatedString and memory allocations in processing of CSS
  • remove unnecessary double -> float -> double trip in the CSS parser
  • cleaned up names and structure in CSS grammar
  • css/CSSGrammar.y: Remove getPropertyID and getValueID. Both are now in CSSParser.cpp instead, and they now work on ParseString and String objects and don't require the caller to put the string into a char*. Gave members of the %union more sensible names, removed duplicates, and sorted into a logical order. Put the %expect back in, rather than leaving it commented out.
  • css/CSSParser.cpp: (WebCore::equalIgnoringCase): Added. (WebCore::hasPrefix): Added. (WebCore::CSSParser::parseTransitionProperty): Changed to call the new cssPropertyID, which obviates the need to call lower() and utf8() or to allocate memory at all. Also used equalIgnoringCase rather than putting the value into a String just to compare it. (WebCore::CSSParser::lex): Replaced convertASCIIToFloat with charactersToDouble. This change along with the CSSGrammar.y change, removes the double -> float -> double round trip, and affects the result of one layout test. (WebCore::cssPropertyID): Added. Gets the property ID from the gperf hash table, but without allocating any memory. (WebCore::cssValueKeywordID): Ditto.
  • css/CSSParser.h: Removed declaration for deprecatedString function (now used only in CSSParser.cpp; soon to be deleted). Added cssPropertyID and cssValueKeywordID functions.
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Call cssPropertyID instead of propertyID. (WebCore::CSSStyleDeclaration::getPropertyValue): Ditto. (WebCore::CSSStyleDeclaration::getPropertyPriority): Ditto. (WebCore::CSSStyleDeclaration::getPropertyShorthand): Ditto. (WebCore::CSSStyleDeclaration::isPropertyImplicit): Ditto. (WebCore::CSSStyleDeclaration::setProperty): Ditto. (WebCore::CSSStyleDeclaration::removeProperty): Ditto. (WebCore::CSSStyleDeclaration::isPropertyName): Ditto.
  • css/CSSStyleDeclaration.h: Removed unnecessary includes, unnecessary Noncopyable boilerplate, and the getPropertyID function declaration along with its associated apology comment.
  • css/makevalues.pl: Generate constants instead of macros for CSS value numbers (but not an enumeration, like properties, since you rarely have any reason to handle all values, but often have a reason to handle all properties). Renamed the constant for the number of CSS value keywords from CSS_VAL_TOTAL to numCSSValueKeywords, and added maxCSSValueKeywordLength.
  • platform/text/String.cpp: (WebCore::charactersToDouble): Made this function more efficient by using a stack buffer rather than a CString.

LayoutTests:

Reviewed by Sam.

  • generate new results for the one test that was altered by the double -> float -> double trip taken by numeric values in the CSS parser

This test appears under three different names in three different
parts of our test suite.

  • platform/mac/css1/box_properties/acid_test-expected.checksum: Updated.
  • platform/mac/css1/box_properties/acid_test-expected.png: Ditto.
  • platform/mac/css1/box_properties/acid_test-expected.txt: Ditto.
  • platform/mac/css2.1/t09-c5526c-display-00-e-expected.checksum: Ditto.
  • platform/mac/css2.1/t09-c5526c-display-00-e-expected.png: Ditto.
  • platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt: Ditto.
  • platform/mac/fast/block/basic/011-expected.checksum: Ditto.
  • platform/mac/fast/block/basic/011-expected.png: Ditto.
  • platform/mac/fast/block/basic/011-expected.txt: Ditto.
6:13 PM Changeset in webkit [30392] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms

Test: fast/css/font-face-multiple-remote-sources.html

  • css/CSSFontFace.cpp: (WebCore::CSSFontFace::fontLoaded):
  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::fontLoaded):

LayoutTests:

  • test for <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms
  • fast/css/font-face-multiple-remote-sources.html: Added.
  • platform/mac/fast/css/font-face-multiple-remote-sources-expected.checksum: Added.
  • platform/mac/fast/css/font-face-multiple-remote-sources-expected.png: Added.
  • platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt: Added.
5:12 PM Changeset in webkit [30391] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): Added. (WebCore::cssPropertyName): Reimplement to not use DeprecatedString. Also made faster by using a Vector<UChar> and eliminating all the string operations.
4:54 PM Changeset in webkit [30390] by Darin Adler
  • 2 edits in trunk/WebKit/mac

Reviewed by Sam.

  • Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of DeprecatedString.
4:48 PM Changeset in webkit [30389] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-02-18 Stephanie Lewis <Stephanie Lewis>

Reviewed by Adam.

Remove workaround for <rdar://problem/5695848>.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
4:48 PM Changeset in webkit [30388] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Reviewed by Sam.

  • Api/qwebnetworkinterface.cpp: (QWebNetworkRequestPrivate::init): Removed use of DeprecatedString.
4:25 PM Changeset in webkit [30387] by weinig@apple.com
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Geoff Garen.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::setDebugger):
  • kjs/date_object.cpp: (KJS::dateProtoFuncGetYear):

WebCore:

Reviewed by Geoff Garen.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript):
3:04 PM Changeset in webkit [30386] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-18 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17381
[CURL] Regression: data URL parsing broken after DeprecatedString removal (Acid2)

This patch resolves the regression for the GTK+ port.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):
3:03 PM Changeset in webkit [30385] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2008-02-18 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17312
[GTK] Webview Transparent Background

Add support for WebView background transparency.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
3:03 PM Changeset in webkit [30384] by alp@webkit.org
  • 3 edits in trunk/WebKit/gtk

2008-02-18 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Implement webkit_web_view_get_focused_frame()

Equivalent to selectedFrame in the Mac API.

  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
1:43 PM Changeset in webkit [30383] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): Use String instead of DeprecatedString. (WebCore::ResourceHandle::start): Ditto.
1:42 PM Changeset in webkit [30382] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): Use String instead of DeprecatedString. (WebCore::cookies): Ditto.
1:40 PM Changeset in webkit [30381] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • removed use of DeprecatedString in the Color class
  • platform/graphics/Color.cpp: (WebCore::Color::parseHexColor): Streamlined logic a bit with early returns. Used toASCIIHexValue a character at a time rather than using toIntStrict in base 16 mode. (WebCore::findNamedColor): Added. Uses a fixed-size char buffer to look up a color using the gperf-generated findColor function. Saves a memory allocation vs. the old version that called DeprecatedString::latin1(). (WebCore::Color::setNamedColor): Changed to use findNamedColor.
1:28 PM Changeset in webkit [30380] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

  • wtf/ASCIICType.h: (WTF::toASCIIHexValue): Added.
1:20 PM Changeset in webkit [30379] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Changed to use String instead of DeprecatedString.
1:16 PM Changeset in webkit [30378] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer): Changed to use String instead of DeprecatedString.
12:13 PM Changeset in webkit [30377] by weinig@apple.com
  • 7 edits
    3 deletes in trunk/WebCore

Reviewed and landed by Sam.

Remove DeprecatedStringList.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • editing/markup.cpp:
  • platform/DeprecatedStringList.cpp: Removed.
  • platform/DeprecatedStringList.h: Removed.
  • platform/mac/DeprecatedStringListMac.mm: Removed.
11:55 AM Changeset in webkit [30376] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30370.

11:49 AM Changeset in webkit [30375] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • css/CSSPrimitiveValueMappings.h: Add default cases to all the switch statements. This will ease the way some day if we decide to use an enum instead of int; otherwise we'll have a ton of "unhandled enum value" warnings here.
11:21 AM Changeset in webkit [30374] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-18 Alp Toker <​alp@atoker.com>

Build fix for GTK+ < 2.10. Fall back to simple text clipboard copy
with older GTK+ versions for now.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
10:59 AM Changeset in webkit [30373] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • WebCore.base.exp: Export a couple of WebCore::String functions we plan to use in the future in WebKit.
10:58 AM Changeset in webkit [30372] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • DerivedSources.make: Added the scripts to the ENABLE_SVG versions of the rules for CSSPropertyNames.h and CSSValueKeywords.h. Somehow that got left out, so the files would not be regenerated if the scripts were changed (but would if SVG was disabled).
10:41 AM Changeset in webkit [30371] by ap@webkit.org
  • 2 edits in trunk/WebCore

Suggested by Darin.

  • platform/KURL.h: (WebCore::KURL::operator const String&): Added, to avoid unexpected conversion via UString (as in bug 17418).
10:23 AM Changeset in webkit [30370] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-02-18 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5744899> Crash in Flash when clicking "Yes" to abort
slow script Flash 9 dialog at ​http://www.kidzui.com

When navigating to a new page, we stop all outstanding PluginStreams.
Flash hangs in the call to NPP_URLNotify. It eventually displays the
"slow script" dialog, which relinquishes control to the system. While
this dialog is running, the request we are in the process of cancelling
completes, and we re-enter Flash to deliver the data. When the dialog
is dismissed, the internal state of Flash has changed, and Flash
crashes with a null dereference.

To work around this, we can defer loading before entering plug-in code,
so that even if a plug-in yields to the system, we won't get callbacks
while we're handling a callback.

  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Defers loads while calling into plug-in. (WebCore::PluginStream::destroyStream): Same. (WebCore::PluginStream::deliverData): Same. (WebCore::PluginStream::didFail): Protect 'this' from deletion by destroyStream. Null out m_loader only after destroyStream returns. (WebCore::PluginStream::didFinishLoading): Same.
10:14 AM Changeset in webkit [30369] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=17418
REGRESSION: Assertion failure dragging image (JSLock::lockCount() > 0)

  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage): Explicitly convert from KURL to String, as an implicit conversion uses UString and thus needs a JSLock.
7:14 AM QtWebKitTodo edited by Simon Hausmann
(diff)
6:33 AM QtWebKitTodo edited by Simon Hausmann
(diff)
4:15 AM QtWebKitTodo edited by Simon Hausmann
(diff)
1:10 AM QtWebKitTodo edited by Simon Hausmann
(diff)

Feb 17, 2008:

10:45 PM Changeset in webkit [30368] by weinig@apple.com
  • 2 edits in trunk/WebCore

Roll out r30360.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
10:31 PM Changeset in webkit [30367] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Make JavaScriptCore and WebKit's FEATURE_DEFINES match WebCore.

10:25 PM Changeset in webkit [30366] by weinig@apple.com
  • 2 edits in trunk/WebCore

Mac build fix.

  • WebCore.xcodeproj/project.pbxproj:
9:47 PM Changeset in webkit [30365] by sfalken@apple.com
  • 1 edit in branches/Safari-3-1-branch/WebCore/ChangeLog

ChangeLog fix.

9:43 PM Changeset in webkit [30364] by sfalken@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Build fix.

  • WebCore.vcproj/build-generated-files.sh:
6:32 PM Changeset in webkit [30363] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-02-17 Alp Toker <​alp@atoker.com>

Attempt to fix the Wx build (has been broken all weekend).

Stub out some graphics functions.

  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::isEmpty):
6:02 PM Changeset in webkit [30362] by alp@webkit.org
  • 4 edits
    2 copies
    2 moves
    2 adds in trunk

2008-02-17 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Alexey Proskuryakov.

​http://bugs.webkit.org/show_bug.cgi?id=16989
bug 16989 : Add send() flag checks in XmlHttpRequest

  • Splitted xmlhttprequest-abort-readystate in 2 test cases (xmlhttprequest-abort-readystate-shouldDispatchEvent and xmlhttprequest-abort-readystate-shouldNotDispatchEvent)
  • Added test case for the 2 send() flag checks in XmlHttpRequest::send and XmlHttpRequest::setRequestHeader
4:22 PM Changeset in webkit [30361] by weinig@apple.com
  • 11 edits in trunk

WebCore:

Reviewed by Dan Bernstein.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR

  • Updated fast/events/event-instanceof.html to test document.createEvent("MessageEvent").
  • DerivedSources.make: Generate Objective-C binding for DOMProgressEvent which was missing.
  • WebCore.xcodeproj/project.pbxproj: Add missing DOMProgressEvent files to the project.
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS): Clean up and add case for SVGZoomEvent that was missing.
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _wrapEvent:WebCore::]): Clean up and add cases for ProgressEvent and MessageEvent that were missing.
  • dom/Document.cpp: (WebCore::Document::createEvent): Add case for MessageEvent.

WebKit/mac:

Reviewed by Dan Bernstein.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR

  • MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were mistakenly not migrated.

LayoutTests:

Reviewed by Dan Bernstein.

Update test for ​http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR

  • fast/events/event-instanceof-expected.txt:
  • fast/events/resources/event-instanceof.js: Test MessageEvent as well.
4:14 PM Changeset in webkit [30360] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-17 Adam Treat <​treat@kde.org>

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=17008
Meta refresh does not work with cache turned off

Fix for issue noticed on ​http://adserver.vivox.com/2

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
3:53 PM Changeset in webkit [30359] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-17 Alp Toker <​alp@atoker.com>

Reviewed by Sam Weinig.

Fix for change made in r30355. Issue noticed by İsmail Dönmez.

Verify SSL certs by default, but allow checks to be disabled with an
environment variable (WEBKIT_IGNORE_SSL_ERRORS) for now.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
12:21 PM Changeset in webkit [30358] by ap@webkit.org
  • 2 edits in trunk/WebKit/win

​http://bugs.webkit.org/show_bug.cgi?id=17397
<rdar://problem/5748245> REGRESSION (r30236-30336): Cannot backspace/enter in forms on Windows

  • WebKit.vcproj/WebKit.vcproj: Add ENABLE_CROSS_DOCUMENT_MESSAGING definitions.
11:28 AM Changeset in webkit [30357] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

Reviewed by Mark Rowe.

  • disable the non-ASCII parts of a test case for the ASCII code path because it is failing on the (Tiger) buildbots for an unrelated reason.
  • fast/text/fixed-pitch-control-characters.html:
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum:
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.png:
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.txt:
9:59 AM Changeset in webkit [30356] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • wtf/ListHashSet.h: (WTF::swap): Removed stray return statement.
7:36 AM Changeset in webkit [30355] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-17 Bin Chen <​binary.chen@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17404
Bug 17404: curl certification problem

Disable SSL cert verification until we have a way of distributing
certs and/or reporting SSL errors to the user.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
7:09 AM Changeset in webkit [30354] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-17 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

DevHelp fails to load local files; URL truncated by one character.

Fix a ​file:// URL regression introduced in KURL.cpp r30243.

  • platform/KURL.cpp: (WebCore::KURL::KURL):
4:12 AM Changeset in webkit [30353] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

2008-02-17 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Mark Rowe.

Fix a crash introduced in changeset #29985 by moving the dereference to after
the null check.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
2:46 AM Changeset in webkit [30352] by mrowe@apple.com
  • 15 edits in branches/Safari-3-1-branch

Merge r30331.

2:45 AM Changeset in webkit [30351] by mrowe@apple.com
  • 5 edits in branches/Safari-3-1-branch

Merge r30330.

2:44 AM Changeset in webkit [30350] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30329.

2:43 AM Changeset in webkit [30349] by mrowe@apple.com
  • 7 edits in branches/Safari-3-1-branch

Merge r30328.

2:42 AM Changeset in webkit [30348] by mrowe@apple.com
  • 23 edits
    1 move
    2 adds in branches/Safari-3-1-branch

Merge r30326.

2:40 AM Changeset in webkit [30347] by mrowe@apple.com
  • 23 edits
    1 add in branches/Safari-3-1-branch/WebCore

Merge r30325.

2:39 AM Changeset in webkit [30346] by mrowe@apple.com
  • 8 edits
    1 copy
    5 adds in branches/Safari-3-1-branch

Merge r30323.

1:03 AM WebKit Team edited by mitz@apple.com
Edited my entry to humor Sam (diff)
12:50 AM Changeset in webkit [30345] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/forms/control-clip-overflow.html

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): Account for control clipping. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.

LayoutTests:

Reviewed by Darin Adler.

  • fast/forms/control-clip-overflow.html: Added.
  • platform/mac/fast/forms/control-clip-overflow-expected.checksum: Added.
  • platform/mac/fast/forms/control-clip-overflow-expected.png: Added.
  • platform/mac/fast/forms/control-clip-overflow-expected.txt: Added.

Feb 16, 2008:

9:48 PM Changeset in webkit [30344] by oliver@apple.com
  • 2 edits in trunk/WebCore

Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp

Reviewed by Eric S

Use cross-platform code to determine the dirty rects for
fill and stroke operations

7:43 PM Changeset in webkit [30343] by weinig@apple.com
  • 8 edits in trunk/WebCore

Reviewed by Darin Adler.

Take another step in the direction of getting rid of DeprecatedString
by moving all the to{NumericType} off of it.

  • Create free functions that take a UChar* buffer and length to do the string-to-number conversions. This allows us to avoid two allocations if we don't already have a String and is consistent with the design we would like going forward.
  • Since the toInt (and family) functions on DeprecatedString were slightly different than the ones on String (they didn't allow trailing garbage), an extra set of 'Strict' toInt functions were added that have this behavior.
  • platform/graphics/Color.cpp: (WebCore::Color::parseHexColor):
  • platform/text/PlatformString.h:
  • platform/text/String.cpp: (WebCore::String::percentage): (WebCore::String::toIntStrict): (WebCore::String::toUIntStrict): (WebCore::String::toInt64Strict): (WebCore::String::toUInt64Strict): (WebCore::String::toUInt): (WebCore::String::toDouble): (WebCore::isCharacterAllowedInBase): (WebCore::toIntegralType): (WebCore::lengthOfCharactersAsInteger): (WebCore::charactersToIntStrict): (WebCore::charactersToUIntStrict): (WebCore::charactersToInt64Strict): (WebCore::charactersToUInt64Strict): (WebCore::charactersToInt): (WebCore::charactersToUInt): (WebCore::charactersToInt64): (WebCore::charactersToUInt64): (WebCore::charactersToDouble): (WebCore::charactersToFloat):
  • platform/text/StringImpl.cpp: (WebCore::parseLength): (WebCore::StringImpl::toIntStrict): (WebCore::StringImpl::toUIntStrict): (WebCore::StringImpl::toInt64Strict): (WebCore::StringImpl::toUInt64Strict): (WebCore::StringImpl::toInt): (WebCore::StringImpl::toUInt): (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64): (WebCore::StringImpl::toDouble): (WebCore::StringImpl::toFloat):
  • platform/text/StringImpl.h:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseClockValue):
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
7:08 PM Changeset in webkit [30342] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix fixed-pitch font measurement of control characters that render as zero-width space

Test: fast/text/fixed-pitch-control-characters.html

  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache):

LayoutTests:

Reviewed by Sam Weinig.

  • test fixed-pitch font measurement of control characters that render as zero-width space
  • fast/text/fixed-pitch-control-characters.html: Added.
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum: Added.
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.png: Added.
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.txt: Added.
2:04 PM Changeset in webkit [30341] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix.

1:06 PM WebKit Team edited by weinig@apple.com
Add areas of knowledge for Sam Weinig (diff)
1:02 PM WebKit Team edited by weinig@apple.com
Remove Tristan as he is no longer at Apple (diff)
9:41 AM Changeset in webkit [30340] by Darin Adler
  • 1 edit
    3 moves in trunk/LayoutTests
  • disable some failing tests; someone can re-enable after fixing the problems causing them to fail or generating new expected results

​http://bugs.webkit.org/show_bug.cgi?id=17391

  • fast/frames/iframe-scroll-page-up-down.html: Removed.
  • fast/frames/iframe-scroll-page-up-down.html-disabled: Copied from fast/frames/iframe-scroll-page-up-down.html.

​http://bugs.webkit.org/show_bug.cgi?id=17392

  • svg/batik/text/textBiDi.svg: Removed.
  • svg/batik/text/textBiDi.svg-disabled: Copied from svg/batik/text/textBiDi.svg.

​http://bugs.webkit.org/show_bug.cgi?id=17393

  • svg/custom/use-on-symbol-inside-pattern.svg: Removed.
  • svg/custom/use-on-symbol-inside-pattern.svg-disabled: Copied from svg/custom/use-on-symbol-inside-pattern.svg.
9:35 AM Changeset in webkit [30339] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Clean up some old log entries.

3:09 AM Changeset in webkit [30338] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-02-16 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

Cross document messaging GTK+/autotools build fix.

  • GNUmakefile.am:

Feb 15, 2008:

10:44 PM Changeset in webkit [30337] by oliver@apple.com
  • 3 edits in trunk/WebCore

Build fix for Qt and Cairo builds

10:00 PM Changeset in webkit [30336] by oliver@apple.com
  • 8 edits in trunk/WebCore

Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Refactor CanvasRenderingContext2D::drawImage(HTMLCanvasElement) to remove evil ifdefs

Reviewed by Dan B.

Add logic draw(ImageBuffer*) method to GraphicsContext to handle
painting the source canvas content.

9:57 PM Changeset in webkit [30335] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

  • skip a test for a Leopard-only NSHTTPURLResponse bug workaround
  • platform/mac-tiger/Skipped:
7:23 PM Changeset in webkit [30334] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Using GetNativeFontInfoDesc() to generate the hash value was leading to duplicate entries in the HashMap. Use the font object's pointer instead.

​http://bugs.webkit.org/show_bug.cgi?id=17371

6:51 PM Changeset in webkit [30333] by adachan@apple.com
  • 2 edits in trunk/WebCore

When parsing url we get from a CFURLRef, we need to null terminate
the string for the case when url ends with a '/'.

Reviewed by Darin.

  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL):
6:02 PM Changeset in webkit [30332] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Added 2 skipped tests

  • platform/mac-tiger/Skipped:
4:51 PM Changeset in webkit [30331] by beidson@apple.com
  • 15 edits in trunk

WebCore:

Reviewed by Darin

Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
a page has closed or loaded a new document

Deciding to make the Database I/O semantic the same as loaders/XHR when a document is shut down, this patch implements
a policy of shutting down the databases in a document at the same time. This includes removing all pending transactions
in a database, cutting off an queued statements in the current transaction, and preventing further callbacks from being
made.

No new layout tests with this patch as the current layout tests were catching this issue in a plethora of ways already
(crashing, unexpected exceptions and output, etc)

  • dom/Document.cpp: (WebCore::Document::~Document): Don't actually stop the database thread here - it better have been stopped already. Add an assertion to that effect. (WebCore::Document::addOpenDatabase): Add a new database handle to this Document's open database set (WebCore::Document::removeOpenDatabase): Remove such a handle (WebCore::Document:: stopDatabases): Call "close" on all open Database handles for this document
  • dom/Document.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): In addition to canceling all resource loads and XHRs, stop all database I/O
  • platform/MessageQueue.h: (WebCore::MessageQueue::killed):
  • platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop): Added. Explicit stop to cut off a transaction so it won't try anymore SQL activity
  • platform/sql/SQLiteTransaction.h:
  • storage/Database.cpp: (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::markAsDeletedAndClose): Check if the thread has terminated before committing to waiting on the thread. (WebCore::Database::stop): Stop this database, including all queued transactions and callbacks
  • storage/Database.h: (WebCore::Database::stopped):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::terminationRequested):
  • storage/DatabaseThread.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL): Throw an exception if a new executeSQL comes in after a database is closed (WebCore::SQLTransaction::checkAndHandleClosedDatabase): Added. Clears queued statements and clear the next step when the database has been closed since the last step/callback was run. Also stops the current SQLite transaction, if any (WebCore::SQLTransaction::performNextStep): (WebCore::SQLTransaction::performPendingCallback):
  • storage/SQLTransaction.h:

LayoutTests:

Reviewed by Darin

Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
a page has closed or loaded a new document

  • storage/close-during-stress-test-expected.txt: Update results - this test contained output from a javascript callback that never should have taken place
4:44 PM Changeset in webkit [30330] by adele@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs

The immediate cause of this bug was that we stopped sending keypress events for the tab key when it is used to advance focus.
We had a special case for forward-tab in designMode, where the default behavior was to insert a tab key (or respect the keypress handler behavior).
This change makes the shift-tab behavior match the forward-tab behavior.

If the site had put their event handler (which does the indenting) on the keydown event, then this problem would have been avoided.
This is something we should look into and maybe advise the site on in the future. However, it's a low-risk change to just make tab and shift-tab uniform
in this respect, so I think this is the way to go for right now.

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTabEventHandler):

LayoutTests:

Reviewed by Darin.

Updated test for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs

  • editing/inserting/typing-tab-designmode-expected.txt:
  • editing/inserting/typing-tab-designmode.html:
3:47 PM Changeset in webkit [30329] by andersca@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Alice.

<rdar://problem/5738678>
REGRESSION: "Loading" status remains when uploading file to .Mac iDisk via Safari


Use the new CFNetwork functions for setting body parts.


  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): (WebCore::httpBodyFromRequest):
3:39 PM Changeset in webkit [30328] by ggaren@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Anders Carlsson.


Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
surveys no longer work due to XMLHttpRequest exceptions


Reverted some exception throwing code from r12194.


To comply with the W3C draft spec, we used to throw an exception when
trying to access responseText and responseXML at the wrong time, but
that turned out to be a compatibility problem.


Now, matching Firefox and previous versions of WebKit, we never throw
an exception when accessing responseText or responseXML.


See ​http://www.mail-archive.com/public-webapi@w3.org/msg02756.html.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML):

LayoutTests:

Reviewed by Anders Carlsson.


Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
surveys no longer work due to XMLHttpRequest exceptions


Updated layout tests to expect an exception not to be thrown.


  • http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html:
  • http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html:
  • http/tests/xmlhttprequest/zero-length-response-expected.txt:
  • http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:
3:27 PM Changeset in webkit [30327] by alice.liu@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

minor correction to my last Changlog entry.

3:25 PM Changeset in webkit [30326] by justin.garcia@apple.com
  • 23 edits
    3 adds
    1 delete in trunk

WebCore:

Reviewed by Dan Bernstein.

<rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace


Rolled out <​http://trac.webkit.org/projects/webkit/changeset/29667>

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved):

LayoutTests:

Reviewed by Dan Bernstein.


<rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace


Disabled:

  • editing/selection/inconsistent-in-removeChildNode.html: Removed.
  • editing/selection/inconsistent-in-removeChildNode.html-disabled: Added.


Demonstrates fix:

  • editing/undo/5738768-expected.txt: Added.
  • editing/undo/5738768.html: Added.


During a shouldChangeSelection call, the old selection is no longer null because
nodeWillBeRemoved doesn't blow it away:

  • platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-in-bold-expected.txt:

During a shouldChangeSelection call, the old selection is now null because
nodeWillBeRemoved blows it away:

  • platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:


More instances of <rdar://problem/5729315>, where, during a shouldChangeSelection
call content that held the old selection is still around but it wouldn't make sense
to leave the selection there, so we shouldn't call shouldChangeSelection at all:

  • platform/mac/editing/style/remove-underline-expected.txt:
  • platform/mac/editing/style/unbold-in-bold-expected.txt:

Similar changes, but ones where I've also updated pixel results for old, unrelated fixes:

  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
  • platform/mac/editing/deleting/delete-leading-ws-001-expected.checksum:
  • platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-011-expected.checksum:
  • platform/mac/editing/deleting/delete-line-011-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.checksum:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/execCommand/paste-2-expected.checksum:
  • platform/mac/editing/execCommand/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-012-expected.checksum:
  • platform/mac/editing/selection/4960116-expected.checksum:
3:18 PM Changeset in webkit [30325] by alice.liu@apple.com
  • 23 edits
    1 add in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/5741440> REGRESSION (r28496): After deactivating JavaScript, scripts embedded in the HTML page continue to run


Before this patch, Frame::scriptProxy() would only return null in the case that javascript was
disabled and if the script proxy field wasn't set (which would only be the case if the window
hasn't loaded anything yet). Not all callers of scriptProxy() always check for a non-null return
value. Those that did check would effectively be checking if javascript was enabled before proceeding.
This fix consists of 2 elements: first, make sure that scriptProxy() will never return null, regardless
of whether javascript is disabled. This will mean that callers who don't check for null won't crash.
Second, callers who did check for null now instead check for javascript being disabled. This means that
code paths intended for preventing javascript from being run will be making the correct check. Another
minor addition to this patch is that I added a function on Frame to be a shortcut for checking if javascript
is enabled.

  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/kjs_html.cpp: (WebCore::runtimeObjectImplementsCall):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::isEnabled):
  • bindings/js/kjs_proxy.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::retrieveWindow): (KJS::Window::retrieve):
  • dom/Document.cpp: (WebCore::Document::createHTMLEventListener):
  • dom/EventTarget.cpp: (WebCore::EventTarget::dispatchGenericEvent):
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::userGestureHint): (WebCore::FrameLoader::open): (WebCore::FrameLoader::dispatchWindowObjectAvailable): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
  • manual-tests/disable-javascript-reload.html: Added.
  • page/Frame.cpp: (WebCore::Frame::scriptProxy): (WebCore::Frame::bindingRootObject): (WebCore::Frame::windowScriptNPObject):
  • page/Frame.h:
  • page/InspectorController.cpp: (WebCore::canPassNodeToJavaScript):
  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener):
2:30 PM Changeset in webkit [30324] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30285.

1:30 PM Changeset in webkit [30323] by mitz@apple.com
  • 8 edits
    6 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

Test: http/tests/loading/text-content-type-with-binary-extension.html

Refined the workaround for <rdar://problem/5321972> to exclude files
with extensions that are known to be associated with binary MIME types.

  • WebCore.xcodeproj/project.pbxproj: Added WebCoreURLResponse.{h,mm}.
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Moved the workaround logic into WebCoreURLResponse.
  • platform/network/mac/WebCoreURLResponse.h: Added.
  • platform/network/mac/WebCoreURLResponse.mm: Added. (createBinaryExtensionsSet): Returns a set of extensions known to belong to MIME types of binary data. (-[NSURLResponse _webcore_MIMEType]): (-[NSHTTPURLResponse _webcore_MIMEType]): Forces the MIME type from application/octet-stream to text/plain if that is the specified Content-Type, unless the extension is in the binary extensions set.

WebKit/mac:

Reviewed by Alexey Proskuryakov.

  • WebView/WebDataSource.mm: (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _responseMIMEType]): (-[WebDataSource subresources]): (-[WebDataSource subresourceForURL:]):
  • WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:]):
  • WebView/WebResourcePrivate.h:

LayoutTests:

Reviewed by Alexey Proskuryakov.

  • http/tests/loading/resources/.htaccess: Added.
  • http/tests/loading/resources/binaryData.m4a: Added.
  • http/tests/loading/text-content-type-with-binary-extension-expected.txt: Added.
  • http/tests/loading/text-content-type-with-binary-extension.html: Added.
1:28 PM Changeset in webkit [30322] by mrowe@apple.com
  • 6 edits in branches/Safari-3-1-branch

Merge r30276.

1:27 PM Changeset in webkit [30321] by mrowe@apple.com
  • 17 edits in branches/Safari-3-1-branch

Merge r30269.

1:26 PM Changeset in webkit [30320] by weinig@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Reviewed and rubber-stamped by Oliver Hunt.

Add leopard specific results for stroke-width-click.svg to work around
a CG regression.

  • platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Added.
1:08 PM Changeset in webkit [30319] by mitz@apple.com
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Dave Hyatt.

  • manual-tests/transitions.html: Added.
  • page/AnimationController.cpp: (WebCore::CompositeImplicitAnimation::animate): Changed to use the transition properties of the current style rather than the target style. (WebCore::AnimationControllerPrivate::get): Changed to not create an animation if the style does not have transitions. (WebCore::AnimationController::updateImplicitAnimations): Added code to return the target style if the current style is not animating.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setAnimatableStyle): Changed to call updateImplicitAnimations() even if the current style does not have transitions, because we may be animating out of a style that had them.
12:44 PM Changeset in webkit [30318] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebKitTools

Merge r30242.

12:44 PM Changeset in webkit [30317] by mrowe@apple.com
  • 3 edits in branches/Safari-3-1-branch/LayoutTests

Merge r30241.

12:43 PM Changeset in webkit [30316] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30240.

12:43 PM Changeset in webkit [30315] by mrowe@apple.com
  • 6 edits in branches/Safari-3-1-branch

Merge r30239.

12:42 PM Changeset in webkit [30314] by mrowe@apple.com
  • 14 edits
    2 adds in branches/Safari-3-1-branch

Merge r30238.

12:41 PM Changeset in webkit [30313] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30237.

12:41 PM Changeset in webkit [30312] by mrowe@apple.com
  • 3 edits
    3 adds in branches/Safari-3-1-branch

Merge r30235.

12:40 PM Changeset in webkit [30311] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30233.

12:40 PM Changeset in webkit [30310] by mrowe@apple.com
  • 10 edits in branches/Safari-3-1-branch

Merge r30222.

12:39 PM Changeset in webkit [30309] by mrowe@apple.com
  • 3 edits in branches/Safari-3-1-branch/WebCore

Merge r30218.

12:38 PM Changeset in webkit [30308] by mrowe@apple.com
  • 3 edits
    2 adds in branches/Safari-3-1-branch

Merge r30213.

12:37 PM Changeset in webkit [30307] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebKit/win

Merge r30206.

12:06 PM Changeset in webkit [30306] by ap@webkit.org
  • 1 edit
    1 delete in trunk/WebCore

Rubber-stamped by Darin.

Remove an obsolete WebCore readme file.

  • README: Removed.
11:46 AM Changeset in webkit [30305] by mrowe@apple.com
  • 7 edits
    4 adds in branches/Safari-3-1-branch

Merge r30195.

11:45 AM Changeset in webkit [30304] by mrowe@apple.com
  • 3 edits
    3 adds in branches/Safari-3-1-branch

Merge r30191.

11:45 AM Changeset in webkit [30303] by mrowe@apple.com
  • 1 edit in branches/Safari-3-1-branch/WebCore/platform/sql/SQLiteDatabase.cpp

Merge r30190.

11:44 AM Changeset in webkit [30302] by mrowe@apple.com
  • 7 edits in branches/Safari-3-1-branch/WebCore

Merge r30189.

11:44 AM Changeset in webkit [30301] by mrowe@apple.com
  • 5 edits in branches/Safari-3-1-branch/WebCore

Merge r30184.

11:43 AM Changeset in webkit [30300] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30179.

11:43 AM Changeset in webkit [30299] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/JavaScriptCore

Merge r30177.

11:42 AM Changeset in webkit [30298] by mrowe@apple.com
  • 2 edits
    2 adds in branches/Safari-3-1-branch/LayoutTests

Merge r30176.

11:42 AM Changeset in webkit [30297] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30174.

11:41 AM Changeset in webkit [30296] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30173.

11:41 AM Changeset in webkit [30295] by mrowe@apple.com
  • 13 edits
    3 adds in branches/Safari-3-1-branch/WebCore

Merge r30172.

11:40 AM Changeset in webkit [30294] by mrowe@apple.com
  • 3 edits
    3 adds in branches/Safari-3-1-branch

Merge r30171.

10:29 AM Changeset in webkit [30293] by weinig@apple.com
  • 13 edits in trunk/WebCore

Reviewed by Darin Adler.

Remove more uses of DeprecatedString in preparation of getting rid of it.

  • bridge/mac/WebCoreScriptDebugger.mm:
  • css/CSSCursorImageValue.cpp: (WebCore::isSVGCursorIdentifier): (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • css/CSSStyleSelector.h:
  • dom/Element.cpp: (WebCore::Element::dump): (WebCore::Element::formatForDebugger):
  • dom/Position.cpp: (WebCore::Position::debugPosition): (WebCore::Position::formatForDebugger):
  • dom/Range.cpp: (WebCore::Range::formatForDebugger):
  • dom/Text.cpp: (WebCore::Text::formatForDebugger):
  • editing/Selection.cpp: (WebCore::Selection::debugPosition): (WebCore::Selection::formatForDebugger):
  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::debugPosition):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::notifyFinished):
  • svg/SVGFontFaceElement.cpp: (WebCore::mapAttributeToCSSProperty):
10:25 AM Changeset in webkit [30292] by mrowe@apple.com
  • 3 edits
    4 adds in branches/Safari-3-1-branch

Merge r30162.

10:25 AM Changeset in webkit [30291] by alp@webkit.org
  • 2 edits in trunk

2008-02-15 Alp Toker <​alp@atoker.com>

Reviewed by Holger.

GTK+ configure script cleanups

Categorize the configuration summary printout.
Bump GTK+ requirement to 2.8.
Rename 'webkit_target' to just 'target'.
Don't check for pthread on Win32.

  • configure.ac:
10:24 AM Changeset in webkit [30290] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch/JavaScriptCore

Merge r30158.

10:24 AM Changeset in webkit [30289] by mrowe@apple.com
  • 21 edits
    2 copies
    15 adds
    2 deletes in branches/Safari-3-1-branch

Merge r30157.

10:22 AM Changeset in webkit [30288] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30154.

10:22 AM Changeset in webkit [30287] by mrowe@apple.com
  • 2 edits
    4 adds in branches/Safari-3-1-branch

Merge r30153.

10:18 AM Changeset in webkit [30286] by mrowe@apple.com
  • 3 edits in branches/Safari-3-1-branch/WebCore

Merge r30146.

10:04 AM Changeset in webkit [30285] by Adam Roben
  • 2 edits in trunk/WebCore
  • bindings/scripts/CodeGenerator.pm: Touch this to force bindings to regenerate.
9:58 AM Changeset in webkit [30284] by Adam Roben
  • 2 edits in branches/Safari-3-1-branch/LayoutTests

Remove MessageEvent output from window-properties.html since that interface will be disabled as well

Reviewed by Sam.

  • fast/dom/Window/window-properties-expected.txt:
9:56 AM Changeset in webkit [30283] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebKit/mac

Merge r30120.

9:56 AM Changeset in webkit [30282] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebKit/mac

Merge r30119.

9:55 AM Changeset in webkit [30281] by mrowe@apple.com
  • 3 edits
    4 adds in branches/Safari-3-1-branch

Merge r30116.

9:55 AM Changeset in webkit [30280] by mrowe@apple.com
  • 1 edit in branches/Safari-3-1-branch/WebCore/css/CSSStyleSelector.cpp

Merge r30115.

9:54 AM Changeset in webkit [30279] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch/WebCore/rendering

Merge r30114.

9:54 AM Changeset in webkit [30278] by mrowe@apple.com
  • 1 edit in branches/Safari-3-1-branch/WebCore/css/CSSStyleSelector.cpp

Merge r30113.

9:54 AM Changeset in webkit [30277] by mrowe@apple.com
  • 70 edits in branches/Safari-3-1-branch/WebCore

Merge r30112.

9:49 AM Changeset in webkit [30276] by Adam Roben
  • 6 edits in trunk

Mac build fix

JavaScriptCore:

Make JavaScriptCore's FEATURE_DEFINES match WebCore's

Reviewed by Mark.

  • Configurations/JavaScriptCore.xcconfig:

WebKit/mac:

Make WebKit's FEATURE_DEFINES match WebCore's

Reviewed by Mark.

  • Configurations/WebKit.xcconfig:

WebKitTools:

Fix a typo that broke the Mac build

Reviewed by Mark.

  • Scripts/build-webkit:
9:13 AM Changeset in webkit [30275] by mrowe@apple.com
  • 6 edits in branches/Safari-3-1-branch

Merge r30105.

9:12 AM Changeset in webkit [30274] by mrowe@apple.com
  • 8 edits in branches/Safari-3-1-branch/WebCore

Merge r30104.

9:12 AM Changeset in webkit [30273] by mrowe@apple.com
  • 3 edits
    2 adds in branches/Safari-3-1-branch

Merge r30101.

9:04 AM Changeset in webkit [30272] by Adam Roben
  • 2 edits in trunk/WebCore

Try to fix Qt/GTK+ builds

  • WebCore.pro: Remove MessageEvent.{idl,cpp} from the unconditional parts of this file.
8:51 AM Changeset in webkit [30271] by Adam Roben
  • 4 edits in branches/Safari-3-1-branch/LayoutTests

Disable postMessage tests since postMessage is disabled

Reviewed by Mitz.

  • fast/dom/Window/window-properties-expected.txt: Updated result.
  • platform/mac/Skipped: Skip tests that depend on postMessage
  • platform/win/Skipped: Ditto.
8:36 AM Changeset in webkit [30270] by Adam Roben
  • 8 edits in trunk

Turn on cross-document messaging support by default

top level:

Turn on cross-document messaging support by default

Reviewed by Darin.

  • configure.ac:

WebCore:

Turn on cross-document messaging support by default

Reviewed by Darin.

  • Configurations/WebCore.xcconfig:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:

WebKitTools:

Turn on cross-document messaging support by default

Reviewed by Darin.

  • Scripts/build-webkit:
8:36 AM Changeset in webkit [30269] by Adam Roben
  • 17 edits in trunk

Conditionalize cross-document messaging support

top level:

Conditionalize cross-document messaging support

The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.

Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.

Reviewed by Darin.

  • configure.ac:

WebCore:

Conditionalize cross-document messaging support

The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.

Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.

Reviewed by Darin.

  • GNUmakefile.am:
  • WebCore.vcproj/build-generated-files.sh:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/Event.cpp: (WebCore::Event::isMessageEvent):
  • dom/Event.h:
  • dom/MessageEvent.cpp:
  • dom/MessageEvent.h:
  • dom/MessageEvent.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

WebKitTools:

Conditionalize cross-document messaging support

The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.

Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.

Reviewed by Darin.

  • Scripts/build-webkit:
7:18 AM Changeset in webkit [30268] by Darin Adler
  • 2 edits in trunk/WebKit/win

Reviewed by Adam.

  • quick fix for a problem causing an assertion on launch
  • WebFrame.cpp: (WebFrame::loadData): Make an empty KURL even if the BSTR is null. Later we might want to rethink this.
3:41 AM Changeset in webkit [30267] by alp@webkit.org
  • 3 edits in trunk/WebKit/gtk

2008-02-15 Alp Toker <​alp@atoker.com>

Fix the GTK+ build following breakage introduced in r30243.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::objectContentType):
2:53 AM Changeset in webkit [30266] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30098.

2:52 AM Changeset in webkit [30265] by mrowe@apple.com
  • 5 edits in branches/Safari-3-1-branch/WebCore

Merge r30097.

2:52 AM Changeset in webkit [30264] by mrowe@apple.com
  • 4 edits
    5 adds in branches/Safari-3-1-branch

Merge r30096.

1:53 AM Changeset in webkit [30263] by mrowe@apple.com
  • 5 edits in branches/Safari-3-1-branch

Merge r30087.

1:52 AM Changeset in webkit [30262] by mrowe@apple.com
  • 7 edits
    1 add in branches/Safari-3-1-branch/WebKit/win

Merge r30086.

1:51 AM Changeset in webkit [30261] by mrowe@apple.com
  • 3 edits in branches/Safari-3-1-branch/WebCore

Merge r30085.

1:51 AM Changeset in webkit [30260] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch/WebKitLibraries

Merge r30084.

1:33 AM Changeset in webkit [30259] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30081.

1:33 AM Changeset in webkit [30258] by mrowe@apple.com
  • 3 edits in branches/Safari-3-1-branch/WebCore

Merge r30080.

1:32 AM Changeset in webkit [30257] by mrowe@apple.com
  • 4 edits
    2 adds in branches/Safari-3-1-branch/WebCore

Merge r30079.

1:31 AM Changeset in webkit [30256] by mrowe@apple.com
  • 23 edits in branches/Safari-3-1-branch/WebCore

Merge r30078.

1:30 AM Changeset in webkit [30255] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30077.

1:30 AM Changeset in webkit [30254] by mrowe@apple.com
  • 12 edits in branches/Safari-3-1-branch/WebCore

Merge r30076.

1:29 AM Changeset in webkit [30253] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30075.

12:21 AM Changeset in webkit [30252] by Darin Adler
  • 2 edits in trunk/WebCore
  • another Qt build fix
  • platform/qt/KURLQt.cpp: (WebCore::KURL::operator QUrl): Use the characters directly, not ascii(). Eliminate references to urlString.
12:12 AM Changeset in webkit [30251] by Darin Adler
  • 4 edits in trunk

WebCore:

  • another Qt build fix
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage): Use KURL instead of String.

WebKit/gtk:

  • another try at fixing the build
  • webkit/webkitwebview.cpp: Added some explicit conversions to KURL.
Note: See TracTimeline for information about the timeline view.