Timeline



Jun 11, 2008:

11:52 PM Changeset in webkit [34508] by mitz@apple.com
  • 2 edits in trunk

Reverting changes I accidently made in r34507.

11:44 PM Changeset in webkit [34507] by mitz@apple.com
  • 33 edits
    6 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Tests: fast/parser/p-in-scope-strict.html

fast/parser/p-in-scope.html

  • html/HTMLParagraphElement.h: (WebCore::HTMLParagraphElement::endTagRequirement): Changed to require an end tag. The explicit closing of one P element by another is now done in error checking, and therefore takes scope into account, allowing for <p><button><p>, for example.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): Initialize m_hasPElementInScope. (WebCore::isScopingTag): Added. Returns whether the given tag represents a scoping element as defined in HTML 5 section 8.2.3.2. (WebCore::HTMLParser::formCreateErrorCheck): Added a call to pCloserCreateErrorCheck(). (WebCore::HTMLParser::ddCreateErrorCheck): Ditto. (WebCore::HTMLParser::dtCreateErrorCheck): Ditto. (WebCore::HTMLParser::nestedPCloserCreateErrorCheck): Added for use with <li>, which both closes P elements in scope and any previous LI. (WebCore::HTMLParser::pCloserCreateErrorCheck): Added. If there is a P element in scope, acts as if a </p> tag was seen. (WebCore::HTMLParser::pCloserStrictCreateErrorCheck): Ditto, but only in strict mode. Used for <table>. (WebCore::HTMLParser::getNode): Added entries for tags that close a P element in scope. (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added code to reset m_hasPElementInScope. (WebCore::HTMLParser::pushBlock): Added code to update m_hasPElementInScope. (WebCore::HTMLParser::popOneBlockCommon): Ditto. (WebCore::HTMLParser::checkIfHasPElementInScope): Added. Updates m_hasPElementInScope.
  • html/HTMLParser.h: (WebCore::HTMLParser::hasPElementInScope): Added. Calls checkIfHasPElementInScope() if needed and returns whether there is a P element in scope.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/block/basic/001.html:
  • fast/block/positioning/absolute-in-inline-ltr-2.html:
  • fast/block/positioning/absolute-in-inline-ltr-3.html:
  • fast/block/positioning/absolute-in-inline-ltr.html:
  • fast/block/positioning/absolute-in-inline-rtl-2.html:
  • fast/block/positioning/absolute-in-inline-rtl-3.html:
  • fast/block/positioning/absolute-in-inline-rtl.html:
  • fast/block/positioning/absolute-in-inline-short-ltr.html:
  • fast/block/positioning/absolute-in-inline-short-rtl.html:
  • fast/block/positioning/auto/006.html:
  • fast/inline/continuation-outlines-with-layers.html:
  • fast/inline/continuation-outlines.html:
  • fast/parser/p-in-scope-expected.txt: Added.
  • fast/parser/p-in-scope-strict-expected.txt: Added.
  • fast/parser/p-in-scope-strict.html: Added.
  • fast/parser/p-in-scope.html: Added.
  • fast/parser/resources/p-in-scope.css: Added.
  • fast/parser/resources/p-in-scope.js: Added.
  • fast/repaint/subtree-root-clip-2.html:
  • platform/mac/fast/block/basic/001-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-ltr-2-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-ltr-3-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-ltr-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-short-ltr-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
  • platform/mac/fast/block/positioning/auto/006-expected.txt:
  • platform/mac/fast/inline/continuation-outlines-expected.txt:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.txt:
11:41 PM Changeset in webkit [34506] by abarth@webkit.org
  • 8 edits
    20 adds in trunk

WebCore:

008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=19460

Update the security context of a document after calling document.open
or document.write. Basically, when a script open()s a document, the
document gains the security context of the script. Our implementation
now matches Firefox 3 on all these tests.

Tests: http/tests/security/aboutBlank/security-context-alias.html

http/tests/security/aboutBlank/security-context-grandchildren-alias.html
http/tests/security/aboutBlank/security-context-grandchildren.html
http/tests/security/aboutBlank/security-context-window-open.html
http/tests/security/aboutBlank/security-context-with-base-tag.html
http/tests/security/aboutBlank/security-context-write.html
http/tests/security/aboutBlank/security-context-writeln.html
http/tests/security/aboutBlank/security-context.html
http/tests/security/cookies/document-open.html

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln):
  • dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::write): (WebCore::Document::writeln):
  • dom/Document.h:

LayoutTests:

008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Tests for the security context of about:blank documents. These test
results all match Firefox 3.

  • fast/dom/resource-locations-in-created-html-document.html:
  • http/tests/security/aboutBlank/resources/iframe-with-about-blank-children.html: Added.
  • http/tests/security/aboutBlank/security-context-alias-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-alias.html: Added.
  • http/tests/security/aboutBlank/security-context-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-alias-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-alias.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren.html: Added.
  • http/tests/security/aboutBlank/security-context-window-open-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-window-open.html: Added.
  • http/tests/security/aboutBlank/security-context-with-base-tag-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-with-base-tag.html: Added.
  • http/tests/security/aboutBlank/security-context-write-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-write.html: Added.
  • http/tests/security/aboutBlank/security-context-writeln-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-writeln.html: Added.
  • http/tests/security/aboutBlank/security-context.html: Added.
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • http/tests/security/cookies/document-open-expected.txt: Added.
  • http/tests/security/cookies/document-open.html: Added.
11:41 PM Changeset in webkit [34505] by abarth@webkit.org
  • 7 edits
    5 adds in trunk

WebCore:

2008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=19460

Compute the cookie context at the same time as the SecurityOrigin.

Tests: http/tests/security/cookies/create-document.html

http/tests/security/cookies/xmlhttprequest.html

  • dom/Document.cpp: (WebCore::Document::cookie): (WebCore::Document::initSecurityOrigin):
  • dom/Document.h:
  • platform/SecurityOrigin.cpp:
  • platform/SecurityOrigin.h:

LayoutTests:

2008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=19460

Test esoteric cookie contexts.

  • http/tests/security/cookies/create-document-expected.txt: Added.
  • http/tests/security/cookies/create-document.html: Added.
  • http/tests/security/cookies/resources/simple.xml: Added.
  • http/tests/security/cookies/xmlhttprequest-expected.txt: Added.
  • http/tests/security/cookies/xmlhttprequest.html: Added.
10:15 PM Changeset in webkit [34504] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

WebCore:

2008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed and tweaked by Sam Weinig.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19242
Data URLs should set an Access-Control-Origin of "null"

Correctly generate "null" as the value of the Access-Control-Origin
header for cross-site XMLHttpRequests for data URLs.

Test: http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlOrigin): (WebCore::XMLHttpRequest::crossSiteAccessRequest): (WebCore::XMLHttpRequest::handleAsynchronousMethodCheckResult):
  • xml/XMLHttpRequest.h:

LayoutTests:

2008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed and tweaked by Sam Weinig.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=19242
Data URLs should set an Access-Control-Origin of "null"

Test that we correctly generate "null" as the value for the
Access-Control-Origin header when making requests from a data URL.

  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
7:51 PM Changeset in webkit [34503] by weinig@apple.com
  • 1 edit in trunk/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt

Add missing newline

7:26 PM Changeset in webkit [34502] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2008-06-11 Sam Weinig <​sam@webkit.org>

Update results on non-leopard platforms to fix the buildbot.

  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
7:19 PM Changeset in webkit [34501] by weinig@apple.com
  • 1 edit in trunk/LayoutTests/http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi

Set executable bit

5:33 PM Changeset in webkit [34500] by cwzwarich@webkit.org
  • 5 edits
    3 adds in trunk

2008-06-11 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 19498: REGRESSION (r34497): crash while loading GMail
<​https://bugs.webkit.org/show_bug.cgi?id=19498>

JavaScriptCore:

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrueOptimized): (KJS::CodeGenerator::emitJumpIfTrue):
  • VM/CodeGenerator.h:
  • kjs/nodes.cpp: (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock):

LayoutTests:

  • fast/js/logical-or-jless-expected.txt: Added.
  • fast/js/logical-or-jless.html: Added.
  • fast/js/resources/logical-or-jless.js: Added.
3:01 PM Changeset in webkit [34499] by Darin Adler
  • 8 edits in trunk/JavaScriptCore

2008-06-11 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • a little bit of cleanup and prep for some upcoming optimizations
  • JavaScriptCore.exp: Re-sorted this file (with sort command line tool).
  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump): Fixed printf to avoid warnings -- to use %lu we need to make sure the type is unsigned long.
  • kjs/object.cpp: (KJS::Error::create): Eliminated unused error names array, and also put the strings into the code since there was already a switch statment. This also avoids having to contemplate a hypothetical access past the end of the array.
  • kjs/object.h: Got rid of errorNames.
  • kjs/property_slot.cpp: Deleted unused ungettableGetter.
  • kjs/property_slot.h: Ditto.
  • wtf/AlwaysInline.h: Added LIKELY alongside UNLIKELY.
12:55 PM Changeset in webkit [34498] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2008-06-11 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

Add support for "*" wildcarding for Access-Control.

Test: http/tests/xmlhttprequest/access-control-basic-allow-star.html

  • xml/AccessItem.cpp: (WebCore::AccessItem::AccessItem): (WebCore::AccessItem::parseAccessItem): (WebCore::AccessItem::matches):

LayoutTests:

2008-06-11 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

Add basic test for "*" wildcarding for Access-Control.

  • http/tests/xmlhttprequest/access-control-basic-allow-star-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-star.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi: Added.
12:48 PM Changeset in webkit [34497] by cwzwarich@webkit.org
  • 7 edits in trunk/JavaScriptCore

2008-06-11 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 19457: Create fused opcodes for tests and conditional jumps
<​https://bugs.webkit.org/show_bug.cgi?id=19457>

Add a new jless instruction, and modify the code generator to emit it
instead of the pair (less, jtrue).

Gives a 3.6% improvement on SunSpider.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): (KJS::CodeGenerator::emitOpcode): (KJS::CodeGenerator::retrieveLastBinaryOp): (KJS::CodeGenerator::rewindBinaryOp): (KJS::CodeGenerator::emitJump): (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse): (KJS::CodeGenerator::emitMove): (KJS::CodeGenerator::emitNot): (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitStrictEqual): (KJS::CodeGenerator::emitNotStrictEqual): (KJS::CodeGenerator::emitLess): (KJS::CodeGenerator::emitLessEq): (KJS::CodeGenerator::emitPreInc): (KJS::CodeGenerator::emitPreDec): (KJS::CodeGenerator::emitPostInc): (KJS::CodeGenerator::emitPostDec): (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitAdd): (KJS::CodeGenerator::emitMul): (KJS::CodeGenerator::emitDiv): (KJS::CodeGenerator::emitMod): (KJS::CodeGenerator::emitSub): (KJS::CodeGenerator::emitLeftShift): (KJS::CodeGenerator::emitRightShift): (KJS::CodeGenerator::emitUnsignedRightShift): (KJS::CodeGenerator::emitBitAnd): (KJS::CodeGenerator::emitBitXOr): (KJS::CodeGenerator::emitBitOr): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitInstanceOf): (KJS::CodeGenerator::emitTypeOf): (KJS::CodeGenerator::emitIn): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitNewObject): (KJS::CodeGenerator::emitNewArray): (KJS::CodeGenerator::emitResolve): (KJS::CodeGenerator::emitGetScopedVar): (KJS::CodeGenerator::emitPutScopedVar): (KJS::CodeGenerator::emitResolveBase): (KJS::CodeGenerator::emitResolveWithBase): (KJS::CodeGenerator::emitResolveFunction): (KJS::CodeGenerator::emitGetById): (KJS::CodeGenerator::emitPutById): (KJS::CodeGenerator::emitPutGetter): (KJS::CodeGenerator::emitPutSetter): (KJS::CodeGenerator::emitDeleteById): (KJS::CodeGenerator::emitGetByVal): (KJS::CodeGenerator::emitPutByVal): (KJS::CodeGenerator::emitDeleteByVal): (KJS::CodeGenerator::emitPutByIndex): (KJS::CodeGenerator::emitNewFunction): (KJS::CodeGenerator::emitNewRegExp): (KJS::CodeGenerator::emitNewFunctionExpression): (KJS::CodeGenerator::emitCall): (KJS::CodeGenerator::emitReturn): (KJS::CodeGenerator::emitEnd): (KJS::CodeGenerator::emitConstruct): (KJS::CodeGenerator::emitPushScope): (KJS::CodeGenerator::emitPopScope): (KJS::CodeGenerator::emitDebugHook): (KJS::CodeGenerator::emitComplexJumpScopes): (KJS::CodeGenerator::emitJumpScopes): (KJS::CodeGenerator::emitNextPropertyName): (KJS::CodeGenerator::emitGetPropertyNames): (KJS::CodeGenerator::emitCatch): (KJS::CodeGenerator::emitThrow): (KJS::CodeGenerator::emitNewError): (KJS::CodeGenerator::emitJumpSubroutine): (KJS::CodeGenerator::emitSubroutineReturn):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.cpp: (KJS::):
  • VM/Opcode.h:
12:37 PM Changeset in webkit [34496] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2008-06-11 Darin Adler <Darin Adler>

Reviewed by Alexey.

  • kjs/array_instance.cpp: (KJS::ArrayInstance::checkConsistency): Added. Empty inline version for when consistency checks are turned off. (KJS::ArrayInstance::ArrayInstance): Check consistency after construction. (KJS::ArrayInstance::~ArrayInstance): Check consistency before destruction. (KJS::ArrayInstance::put): Check consistency before and after. (KJS::ArrayInstance::deleteProperty): Ditto. (KJS::ArrayInstance::setLength): Ditto. (KJS::compareByStringPairForQSort): Use typedef for clarity. (KJS::ArrayInstance::sort): Check consistency before and after. Also broke the loop to set up sorting into two separate passes. Added FIXMEs about various exception safety issues. Added code to set m_numValuesInVector after sorting. (KJS::ArrayInstance::compactForSorting): Ditto.
  • kjs/array_instance.h: Added a definition of an enum for the types of consistency check and a declaration of the consistency checking function.
11:30 AM Changeset in webkit [34495] by justin.garcia@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2008-06-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric.

<​https://bugs.webkit.org/show_bug.cgi?id=19455>
Crash at RenderObject::childAt during JustifyCenter

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Added a FIXME.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): If we're removing a line break that consists of a single '\n' in a text node by itself, remove the whole text node instead of just emptying it out.
  • editing/Selection.cpp: (WebCore::Selection::validate): Added a FIXME about canonicalizing to positions that aren't candidates.
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): When the base and/or extent are about to be removed but the start and end aren't, change the base and extent to the start and end, but don't re-validate the selection, since doing so could move the start and end into the node that is about to be removed.

LayoutTests:

2008-06-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric.

<​https://bugs.webkit.org/show_bug.cgi?id=19455>
Crash at RenderObject::childAt during JustifyCenter

  • editing/execCommand/19455-expected.txt: Added.
  • editing/execCommand/19455.html: Added.
11:27 AM Changeset in webkit [34494] by Chris Fleizach
  • 2 edits in trunk/WebCore

<rdar://problem/5990049> AXTextMarker bytes getting messed up when getting AXTextMarkerRangeForUnorderedTextMarkersParameterizedAttribute

8:19 AM Changeset in webkit [34493] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-11 Adriaan de Groot <​groot@kde.org>

Reviewed by Simon.

Fix compilation with Sun Studio 12

It seems like the compiler instantiates a different template version. I.e.,
instead of parseUASheet<char [nnnn]>, it's probably instantiating
parseUASheet<char *>, which then passes 4 or 8 as the size value.

8:10 AM Changeset in webkit [34492] by Simon Hausmann
  • 3 edits in trunk/WebCore

Benjamin Meyer <​bmeyer@trolltech.com>

Fixed a crash when a slot connect to QWebPage::unsupportedContent would show a
modal dialog with an event loop.

We have a queued connection to various signals in the QNetworkReply, for which
it can happen that after releasing the QNetworkReply and disconnecting from it
a slot connected to one of the signals may still be called due to a posted
MetaCall event due to the queued connections. This patch removes the posted
events explicitly, fixes the coding style a bit and makes sure the same happens
when abort() is called.

8:10 AM Changeset in webkit [34491] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <​ariya.hidayat@trolltech.com>

Fix left-click and middle-click mouse event are not properly accepted.

When copying or pasting text using left or middle-click, the event must be
accepted so that it will not be potentially processed further by the parent
and/or sub-classed widget.

7:57 AM Disk Cache edited by ben@meyerhome.net
(diff)
7:56 AM Changeset in webkit [34490] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <​ariya.hidayat@trolltech.com>

Fix input element does not accept character typed in using AltGr.

EditorClient is modified to catch AltGr and Ctrl+Alt key combination.
This fixes ​http://trolltech.com/developer/task-tracker/index_html?id=207050&method=entry

7:56 AM Disk Cache created by ben@meyerhome.net

Jun 10, 2008:

10:51 PM Changeset in webkit [34489] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx Linux build fix. Only use -undefined dynamic_lookup flag under Mac.

10:18 PM Changeset in webkit [34488] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Reorder include dirs so that WebCore/html/HTMLElementFactory.h appears before WebCore/DerivedSources/HTMLElementFactory.h. (See note in commit for more details. This is probably not the right fix, but this will get us buildinguntil the right fix is in place.)

10:16 PM Changeset in webkit [34487] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx build fix. Link against libedit on Mac since HAVE(READLINE) is defined there.

2:31 PM Changeset in webkit [34486] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • fix the text encoding in this test
  • editing/selection/move-left-right.html:
2:06 PM Changeset in webkit [34485] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by mjs.

Fix disconnected event listener crasher
m_disconnectedNodesWithEventListeners not updated when nodes adopted
​https://bugs.webkit.org/show_bug.cgi?id=19451

I failed to find a way to make this crash DRT, I can crash Debug Safari consistently.

  • dom/EventTarget.cpp: (WebCore::EventTarget::willMoveToNewOwnerDocument): (WebCore::EventTarget::didMoveToNewOwnerDocument):
  • dom/EventTarget.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::willMoveToNewOwnerDocument): (WebCore::EventTargetNode::didMoveToNewOwnerDocument):
  • dom/EventTargetNode.h:
1:49 PM Changeset in webkit [34484] by jchaffraix@webkit.org
  • 6 edits in trunk/WebCore

WebCore:

2008-06-10 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Part of bug 19200: *.in files should embed more information
​https://bugs.webkit.org/show_bug.cgi?id=19200

Move more parameters to the XML files.

  • dom/make_names.pl:
  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:
  • svg/svgattrs.in:
  • svg/svgtags.in:
9:56 AM Changeset in webkit [34483] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

2008-06-10 Maciej Stachowiak <​mjs@apple.com>

Not reviewed.


  • tweak newly added markup.
  • blog/wp-content/themes/webkit/header.php:
9:54 AM Changeset in webkit [34482] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2008-06-10 Joerg Bornemann <​joerg.bornemann@trolltech.com>

Reviewed by Simon.

For the qmake based build make it possible to build against makespecs where
QMAKE_CC is defined in a configuration file included from qmake.conf.

9:47 AM Changeset in webkit [34481] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

2008-05-26 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=19323

Implemented the QWebPage::editable property.

Small documentation fixes by Simon.

8:59 AM ApplicationsGtk edited by alp@atoker.com
Add GIMP (diff)
7:54 AM Changeset in webkit [34480] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=16503
match limit takes at least 13% of the time on the SunSpider regexp-dna test

Make the limit test slightly more efficient. It is not clear how much of a win it is,
as the improvement on regexp-dna varies from 2.3% to 0.6% depending on what revision I
apply the patch to. Today, the win on regexp-dna was minimal, but the total win was whopping
0.5%, due to random code generation changes.

  • pcre/pcre_exec.cpp: (match): Avoid loading a constant on each iteration.
7:22 AM Changeset in webkit [34479] by mjs@apple.com
  • 2 edits
    1 add in trunk/WebKitSite

2008-06-10 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Adele.

  • add short title and multisize icon


  • blog/wp-content/themes/webkit/header.php:
  • images/surfin-safari.icns: Added.
1:58 AM Changeset in webkit [34478] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2008-06-09 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Make sure web action in context menus have the right enablement,
while not messing up other web actions not included in the menu.

12:48 AM Changeset in webkit [34477] by christian@webkit.org
  • 7 edits in trunk/WebKit/gtk

Apply GTK coding style to WebKit Gtk public headers

​https://bugs.webkit.org/show_bug.cgi?id=16676

Reviewed by Alp Toker and Darin Adler.

Jun 9, 2008:

10:42 PM Changeset in webkit [34476] by alp@webkit.org
  • 4 edits in trunk

2008-06-09 Alp Toker <​alp@nuanti.com>

gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
each of the tools since these are no longer set globally.

9:58 PM Changeset in webkit [34475] by mitz@apple.com
  • 6 edits in trunk

WebCore:

Reviewed by Justin Garcia.

Tests added to editing/selection/move-left-right.html

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): When falling back from visual to logical movement, restart at the original position rather than an intermediate position. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Ditto.

LayoutTests:

Reviewed by Justin Garcia.

  • editing/selection/move-left-right-expected.txt:
  • editing/selection/move-left-right.html:
  • platform/mac/editing/selection/move-left-right-expected.txt:
8:42 PM Changeset in webkit [34474] by mrowe@apple.com
  • 2 edits in tags/Safari-5525.18/JavaScriptCore

Merge r34204.

8:41 PM Changeset in webkit [34473] by mrowe@apple.com
  • 3 edits
    3 adds in branches/Safari-3-1-branch

Merge r34204.

3:54 PM Changeset in webkit [34472] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

2008-06-07 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Maciej.

Windows build fix.

  • platform/graphics/win/QTMovieWin.cpp: (initializeSupportedTypes):
2:02 PM Changeset in webkit [34471] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Sam.

Add an include for readline/history.h to fix the build for Darwin users
with the GNU readline library installed. Also, clean up the style of
the HAVE(READLINE) check.

  • kjs/testkjs.cpp: (runInteractive):
10:10 AM Changeset in webkit [34470] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-06-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 17531: Add interactive mode to testkjs
<​https://bugs.webkit.org/show_bug.cgi?id=17531>

This is a cleaned up version of Sam's earlier patch to add an
interactive mode to testkjs.

Readline support is only enabled on Darwin platforms for now, but
other ports can enable it by defining HAVE_READLINE in kjs/config.h.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/config.h:
  • kjs/testkjs.cpp: (Options::Options): (runWithScripts): (runInteractive): (printUsageStatement): (parseArguments): (kjsmain):
7:58 AM Changeset in webkit [34469] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-06-09 Benjamin C Meyer <​ben@meyerhome.net>

Reviewed by Simon

Add Shift-Space shortcut to go up one screen, the opposite of Space
which goes down one screen.

5:55 AM Changeset in webkit [34468] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-09 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Use the text color from QStyle when styling form elements.

3:59 AM Changeset in webkit [34467] by jchaffraix@webkit.org
  • 8 edits in trunk/WebCore

WebCore:

2008-06-07 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Part of bug 19200: *.in files should embed more information
​https://bugs.webkit.org/show_bug.cgi?id=19200

  • Added a parameters hash that will hold the parameters we used to give in the command line.
  • Added "tags" / "attrs" XML tag parsing to fill the parameters hash.
  • Moved namespace, namespaceURI, namespacePrefix and cppNamespace in the *.in files.


  • dom/make_names.pl:
  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:
  • svg/svgattrs.in:
  • svg/svgtags.in:
  • svg/xlinkattrs.in:
  • xml/xmlattrs.in:
12:56 AM Changeset in webkit [34466] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-09 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Darin.

Incorporated Darin's comments to bug 18965.

12:30 AM Changeset in webkit [34465] by abarth@webkit.org
  • 1 edit
    14 copies
    37 deletes in trunk/LayoutTests

Backout 34464. The build bot didn't like the new tests.

Jun 8, 2008:

11:26 PM Changeset in webkit [34464] by abarth@webkit.org
  • 1 edit
    37 adds
    14 deletes in trunk/LayoutTests

2008-06-08 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Alder.

​https://bugs.webkit.org/show_bug.cgi?id=16631

Improve coverage of our frame navigation test cases. This revealed a
bug in plugin navigation (we aren't setting the opener properly), but
that's probably better addressed in a separate patch.

  • http/tests/security/frameNavigation/navigation-ALLOWED-child-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-child.html: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-descendant-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-descendant.html: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-not-opener-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-not-opener.html: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-opener-child-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-opener-child.html: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-popup-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-popup.html: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent.html: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-popup-child-form-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-popup-child-form.html: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink.html: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-popup-child-location-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-popup-child-location.html: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-popup-child-open-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-popup-child-open.html: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin.html: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-sibling-form-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-sibling-form.html: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink.html: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-sibling-location-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-sibling-location.html: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-sibling-open-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-sibling-open.html: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin-expected.txt: Added.
  • http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin.html: Added.
  • http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Removed.
  • http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Removed.
  • http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Removed.
  • http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Removed.
  • http/tests/security/frameNavigation/resources/iframe.html: Added.
  • http/tests/security/frameNavigation/resources/lib.js: Added.
  • http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Removed.
  • http/tests/security/frameNavigation/resources/navigation-happened.html: Removed.
  • http/tests/security/frameNavigation/resources/open.html: Added.
  • http/tests/security/frameNavigation/resources/ready.html: Added.
  • http/tests/security/frameNavigation/resources/target.html: Added.
  • http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Removed.
  • http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Removed.
  • http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Removed.
  • http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Removed.
  • http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
  • http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Removed.
  • http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Removed.
  • http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Removed.
11:26 PM Changeset in webkit [34463] by abarth@webkit.org
  • 4 edits
    1 copy
    1 add in trunk/LayoutTests

2008-06-08 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=16856

Fix tests not to rely on broken javascript URL behavior.

  • fast/events/event-listener-html-non-html-confusion.html:
  • fast/replaced/image-map-bug16782-expected.txt: Added.
  • fast/replaced/image-map-bug16782.html: Added.
  • fast/replaced/image-map.html:
  • svg/custom/prevent-default.svg:
10:20 PM Changeset in webkit [34462] by cwzwarich@webkit.org
  • 3 edits in trunk/LayoutTests

2008-06-08 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 17931: Incorrect decompilation with |new|
<​https://bugs.webkit.org/show_bug.cgi?id=17931>

This bug was fixed by SquirrelFish, but we should add a test.

  • fast/js/function-toString-parentheses-expected.txt:
  • fast/js/resources/function-toString-parentheses.js:
9:47 PM Changeset in webkit [34461] by cwzwarich@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

2008-06-08 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 17932: "ASSERTION FAILED: type != Continue" with do/while and try/finally
<​https://bugs.webkit.org/show_bug.cgi?id=17932>

This bug was fixed by SquirrelFish, but we should add a test, as well
as tests for related issues found while developing SquirrelFish.

  • fast/js/continue-break-multiple-labels-expected.txt:
  • fast/js/continue-break-multiple-labels.html:
  • fast/js/resources/continue-break-multiple-labels.js: Added.
9:37 PM Changeset in webkit [34460] by abarth@webkit.org
  • 3 edits
    11 adds in trunk

WebCore:

2008-06-08 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Inherit document.URL from parent's document.URL, not document.baseURI.

​https://bugs.webkit.org/show_bug.cgi?id=19257

Tests: http/tests/security/cookies/assign-document-url.html

http/tests/security/cookies/base-about-blank.html
http/tests/security/cookies/base-tag.html
http/tests/security/cookies/basic.html

  • dom/Document.cpp: (WebCore::Document::open):

LayoutTests:

2008-06-08 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Alder.

Add a number of tests for document.cookie access.

​https://bugs.webkit.org/show_bug.cgi?id=19257

  • http/tests/security/cookies: Added.
  • http/tests/security/cookies/assign-document-url-expected.txt: Added.
  • http/tests/security/cookies/assign-document-url.html: Added.
  • http/tests/security/cookies/base-about-blank-expected.txt: Added.
  • http/tests/security/cookies/base-about-blank.html: Added.
  • http/tests/security/cookies/base-tag-expected.txt: Added.
  • http/tests/security/cookies/base-tag.html: Added.
  • http/tests/security/cookies/basic-expected.txt: Added.
  • http/tests/security/cookies/basic.html: Added.
  • http/tests/security/cookies/resources: Added.
  • http/tests/security/cookies/resources/set-a-cookie.html: Added.
8:39 PM Changeset in webkit [34459] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fix font asserts in wx port. Our computeHash function should generate the same hash for two identical fonts which are different objects, which it wasn't doing before.

​https://bugs.webkit.org/show_bug.cgi?id=19310

7:12 PM Changeset in webkit [34458] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()

Test: fast/multicol/content-height-zero-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutColumns): Changed to not keep creating overflow columns that have zero height, because they do not help with fitting content in.

LayoutTests:

  • test for <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()

Reviewed by Darin Adler.

  • fast/multicol/content-height-zero-crash-expected.txt: Added.
  • fast/multicol/content-height-zero-crash.html: Added.
5:57 PM Changeset in webkit [34457] by cwzwarich@webkit.org
  • 7 edits in trunk

2008-06-08 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 19346: REGRESSION: Mootools 1.2 Class inheritance broken in post-SquirrelFish merge
<​https://bugs.webkit.org/show_bug.cgi?id=19346>

A check for whether a function's caller is eval code accidentally included
the case where the caller's caller is native code. Add a CodeType field to
CodeBlock and use this for the eval caller test instead.

JavaScriptCore:

  • VM/CodeBlock.h: (KJS::CodeBlock::CodeBlock): (KJS::ProgramCodeBlock::ProgramCodeBlock): (KJS::EvalCodeBlock::EvalCodeBlock):
  • VM/Machine.cpp: (KJS::getCallerFunctionOffset):
  • kjs/nodes.cpp: (KJS::FunctionBodyNode::generateCode): (KJS::ProgramNode::generateCode):

LayoutTests:

  • fast/js/function-dot-arguments-and-caller-expected.txt:
  • fast/js/function-dot-arguments-and-caller.html:
3:18 PM ApplicationsGtk edited by alp@atoker.com
Add NewsKit and Galaxium (diff)
1:57 PM Changeset in webkit [34456] by Adam Roben
  • 2 edits
    1 add in trunk/WebCore

Fix Bug 18837: Database panel fails to display tables if any value is NULL

<​https://bugs.webkit.org/show_bug.cgi?id=18837>

Reviewed by Darin Adler.

Test: manual-tests/inspector/display-sql-null.html

  • manual-tests/inspector/display-sql-null.html: Added.
  • page/inspector/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForResult): Convert all objects to strings before operating on them.
1:57 PM Changeset in webkit [34455] by Adam Roben
  • 2 edits
    1 add in trunk/WebCore

Fix Bug 19438: Transaction errors are never displayed in database query view

<​https://bugs.webkit.org/show_bug.cgi?id=19438>

Reviewed by Darin Adler.

Test: manual-tests/inspector/display-sql-transaction-error.html

  • manual-tests/inspector/display-sql-transaction-error.html: Added.
  • page/inspector/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): Use _executeSqlError as the error callback for executeSql. (WebInspector.DatabaseQueryView.prototype._queryError): Changed to only take two parameters. This matches what we'll be passed if db.transaction fails. (WebInspector.DatabaseQueryView.prototype._executeSqlError): Added. Calls through to _queryError.
1:36 PM Changeset in webkit [34454] by Darin Adler
  • 3 edits in trunk/WebCore

2008-06-08 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=18840
[CAIRO] Clipping-support for SVG

Support for clipping in SVG/Cairo and fixes transformation of paths.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
  • svg/graphics/cairo/SVGResourceClipperCairo.cpp: (WebCore::SVGResourceClipper::applyClip):
1:33 PM Changeset in webkit [34453] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-08 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=18663
Add text-stroke support to Cairo.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
1:30 PM Changeset in webkit [34452] by Darin Adler
  • 7 edits
    3 adds in trunk

WebCore:

2008-06-08 Vincent Ricard <​magic@magicninja.org>

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=16489
WebKit does not support ElementTraversal specification

Tests: fast/dom/Element/element-traversal.html

  • dom/Element.cpp: (WebCore::Element::firstElementChild): (WebCore::Element::lastElementChild): (WebCore::Element::previousElementSibling): (WebCore::Element::nextElementSibling): (WebCore::Element::childElementCount):
  • dom/Element.h:
  • dom/Element.idl:

LayoutTests:

2008-06-08 Vincent Ricard <​magic@magicninja.org>

Reviewed by Darin.

test cases for ​https://bugs.webkit.org/show_bug.cgi?id=16489
WebKit does not support ElementTraversal specification

  • fast/dom/Element/element-traversal-expected.txt: Added.
  • fast/dom/Element/element-traversal.html: Added.
  • fast/dom/Element/resources/element-traversal.js: Added.
  • fast/dom/domListEnumeration-expected.txt: Updated since Element now has 5 new properties. It would be good to rewrite this test so it doesn't have to be updated every time we add a property to Node or Element.
  • fast/dom/resources/domListEnumeration.js: Ditto.
1:01 PM Changeset in webkit [34451] by Darin Adler
  • 4 edits in trunk

WebCore:

2008-06-08 Bradley Meck <​genisis329@gmail.com>

Reviewed by Darin.

Test: fast/css/invalid-cursor-property-crash.html

Changed check for empty url() to be a check for null since url() is valid
CSS even if it is empty.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseBorderImage):

LayoutTests:

2008-06-08 Bradley Meck <​genisis329@gmail.com>

Reviewed and tweaked by Darin.

We should really add some more tests for this. One text-only test each for the
four different sites that handle URLs (cursor image, list style image, fill image,
border image) that were fixed. Currently this covers only the cursor image.

  • fast/css/invalid-cursor-property-crash.html: Updated test to expect the url() to be expanded into the URL of the document itself. The text of the test is now a bit misleading, but it still tests that it's not a crash, and now it also doubles as a check that url() is handled properly.
12:41 PM Changeset in webkit [34450] by Darin Adler
  • 3 edits
    3 adds in trunk

WebCore:

2008-06-08 Vincent Ricard <​magic@magicninja.org>

Reviewed by Darin.

Bug 18041: DOMNodeRemoved events are sent twice

Test: fast/dom/Node/DOMNodeRemovedEvent.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild):

LayoutTests:

2008-06-08 Vincent Ricard <​magic@magicninja.org>

Reviewed by Darin.

Test case for
Bug 18041: DOMNodeRemoved events are sent twice

  • fast/dom/Node/DOMNodeRemovedEvent-expected.txt: Added.
  • fast/dom/Node/DOMNodeRemovedEvent.html: Added.
  • fast/dom/Node/resources/DOMNodeRemovedEvent.js: Added.
12:31 PM Changeset in webkit [34449] by Darin Adler
  • 11 edits
    3 adds in trunk

WebCore:

2008-06-08 Tony Chang <​idealisms@gmail.com>

Reviewed by Eric Seidel.

Move the drag text delay value into the platform specific files.

Test: editing/selection/drag-text-delay.html

  • page/EventHandler.cpp:
  • page/EventHandler.h:
  • page/gtk/EventHandlerGtk.cpp:
  • page/mac/EventHandlerMac.mm:
  • page/qt/EventHandlerQt.cpp:
  • page/win/EventHandlerWin.cpp:
  • page/wx/EventHandlerWx.cpp:

LayoutTests:

2008-06-08 Tony Chang <​idealisms@gmail.com>

Reviewed by Eric Seidel.


Also updated two tests which depend on the drag text delay to be greater
than 0 by making them no longer select text before the mouse down.

  • editing/selection/drag-text-delay-expected.txt: Added.
  • editing/selection/drag-text-delay.html: Added.
  • platform/mac/editing/selection/drag-text-delay-expected.txt: Added.
  • fast/events/autoscroll.html:
  • fast/forms/input-readonly-autoscroll.html:
12:21 PM Changeset in webkit [34448] by Darin Adler
  • 3 edits
    2 adds in trunk

WebCore:

2008-06-08 Rob Buis <​buis@kde.org>

Reviewed by Darin.

Test: svg/custom/getPresentationAttribute-modify.svg

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute): Unshare the mapped style declaration if it is shared before returning the presentation attribute.

LayoutTests:

2008-06-08 Rob Buis <​buis@kde.org>

Reviewed by Darin.

  • svg/custom/getPresentationAttribute-modify-expected.txt: Added.
  • svg/custom/getPresentationAttribute-modify.svg: Added.
12:08 PM Changeset in webkit [34447] by Darin Adler
  • 2 edits in trunk/LayoutTests

2008-06-08 Eric Roman <​minatoar@gmail.com>

Reviewed by Adam Roben.

  • http/tests/security/cross-frame-access-call.html: Enable popups for this layout test. The test checks that window.open is returns undefined (same-domain enforcement), however unless popups are enabled it returns undefined regardless.
12:04 PM Changeset in webkit [34446] by alp@webkit.org
  • 4 edits in trunk

2008-06-08 Alp Toker <​alp@nuanti.com>

autotools/GTK+ build system cleanup. Don't include WebKit API in the
WebCore build as it's no longer needed since r34426.

11:39 AM Changeset in webkit [34445] by Darin Adler
  • 3 edits in trunk/WebCore

2008-06-08 Jonathan Haas <​myrdred@gmail.com>

Reviewed by Eric Seidel.
Tweaked by Darin while landing to make it compile.

Haven't figured out a way to make an automated test for this.

  • svg/SVGGlyphElement.h: Made arabicForm unsigned so it fits into its 3-bit field. Did the same for orientation's 2-bit field.
  • svg/SVGFont.cpp: Did a bit of minor tweaking. (WebCore::isCompatibleArabicForm): Added a cast to avoid a warning since the type is now different.
11:22 AM Changeset in webkit [34444] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-08 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Antti.

Generate the media MIME type list dynamically.

  • platform/graphics/win/QTMovieWin.cpp: (initializeSupportedTypes):
11:16 AM Changeset in webkit [34443] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-08 Christian Persch <​chpe@gnome.org>

Reviewed by Darin.

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView): Initialise the NPP's pdata member to 0.
11:07 AM Changeset in webkit [34442] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-08 Darin Adler <Darin Adler>

Reviewed by Mitz.

  • plugins/PluginDebug.h: Don't compile the errorStrings array if LOG_DISABLED is set.
10:44 AM Changeset in webkit [34441] by mitz@apple.com
  • 2 edits in trunk/BugsSite

Reviewed by Adam Roben.

  • update trac URL in PrettyPatch
  • PrettyPatch/PrettyPatch.rb:
9:10 AM Changeset in webkit [34440] by alp@webkit.org
  • 3 edits in trunk

2008-06-08 Alp Toker <​alp@nuanti.com>

Rubber-stamped by Mark Rowe.

Bring back -fstrict-aliasing for JavaScriptCore which was removed in
r31821, since aliasing issues have now been fixed.

Use -O3, not -O2 for the JavaScriptCore build.

  • GNUmakefile.am:
  • configure.ac:
9:01 AM Changeset in webkit [34439] by Darin Adler
  • 2 edits in trunk/WebKitTools

2008-06-08 Darin Adler <Darin Adler>

  • Scripts/make-js-test-wrappers: Added another exception.

Jun 7, 2008:

10:56 PM Changeset in webkit [34438] by mitz@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Dave Hyatt.

Covered by fast/css/remove-shorthand.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::initShorthandMap): Fixed a typo which mapped the background shorthand to the mask properties.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/css/remove-shorthand-expected.txt:
  • fast/css/remove-shorthand.html:
8:50 PM Changeset in webkit [34437] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-07 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Dan Bernstein.

Bug 17928: testkjs shouldn't require "-f"
<​https://bugs.webkit.org/show_bug.cgi?id=17928>

  • kjs/testkjs.cpp: (printUsageStatement): (parseArguments):
6:57 PM Changeset in webkit [34436] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-06-07 Brent Fulgham <​bfulgham@gmail.com>

Cairo build fix for r34432

  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
6:44 PM Changeset in webkit [34435] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-06-07 Jan Michael Alonzo <​jmalonzo@webkit.org>

Confirmed by Christian Dywan.

Gtk build fix for r34432

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_history_item_add): (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): (WebKit::core):
6:12 PM Changeset in webkit [34434] by Darin Adler
  • 2 edits in trunk/WebKit/gtk

2008-06-07 Darin Adler <Darin Adler>

  • try to fix build after HistoryItem changes
  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): Use HistoryItem::create. (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): Ditto. I also believe this fixes a memory leak in the old version.
5:20 PM Changeset in webkit [34433] by cwzwarich@webkit.org
  • 4 edits
    1 delete in trunk

2008-06-07 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Timothy.

Remove the --squirrelfish option from SunSpider, as it is no longer needed.

SunSpider:


  • sunspider:
  • tests/LIST-SQUIRRELFISH: Removed.

WebKitTools:

  • Scripts/run-sunspider:
3:51 PM Changeset in webkit [34432] by Darin Adler
  • 100 edits in trunk

WebCore:

2008-06-07 Darin Adler <Darin Adler>

Reviewed by Mitz.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toHTMLCanvasStyle):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
  • bindings/js/JSNodeFilterCondition.h: (WebCore::JSNodeFilterCondition::create):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter):
  • bindings/js/JSSVGLazyEventListener.h: (WebCore::JSSVGLazyEventListener::create):
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::flipX): (WebCore::JSSVGMatrix::flipY): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
  • bindings/js/JSSVGPODTypeWrapper.h: (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create): (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly): (WebCore::JSSVGPODTypeWrapperCreatorForList::create): (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList): (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper): (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::commonExit): (WebCore::commonExitReadOnly): (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
  • bindings/js/kjs_binding.cpp: (WebCore::setDOMException):
  • bindings/js/kjs_events.h: (WebCore::JSUnprotectedEventListener::create): (WebCore::JSEventListener::create): (WebCore::JSLazyEventListener::create):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::createHTMLEventHandler): (WebCore::KJSProxy::createSVGEventHandler):
  • bindings/objc/DOM.mm: (WebCore::ObjCNodeFilterCondition::create): (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): (WebCore::ObjCNodeFilterCondition::acceptNode): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForNinePieceImage): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSFontFace.h: (WebCore::CSSFontFace::create): (WebCore::CSSFontFace::CSSFontFace):
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseCounterContent): (WebCore::CSSParser::parseShape): (WebCore::BorderImageParseContext::commitBorderImage):
  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
  • css/CSSSegmentedFontFace.h: (WebCore::CSSSegmentedFontFace::create):
  • css/Counter.h: (WebCore::Counter::create): (WebCore::Counter::Counter):
  • css/DashboardRegion.h: (WebCore::DashboardRegion::create): (WebCore::DashboardRegion::DashboardRegion):
  • css/Rect.h: (WebCore::Rect::create): (WebCore::Rect::Rect):
  • dom/ChildNodeList.h: (WebCore::ChildNodeList::create):
  • dom/ClassNodeList.h: (WebCore::ClassNodeList::create):
  • dom/Clipboard.h:
  • dom/DOMCoreException.h: (WebCore::DOMCoreException::create):
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::instance):
  • dom/DOMImplementation.h: (WebCore::DOMImplementation::DOMImplementation):
  • dom/Document.cpp: (WebCore::Document::addWindowEventListener): (WebCore::Document::removeWindowEventListener): (WebCore::Document::setDecoder): (WebCore::Document::images): (WebCore::Document::applets): (WebCore::Document::embeds): (WebCore::Document::plugins): (WebCore::Document::objects): (WebCore::Document::scripts): (WebCore::Document::links): (WebCore::Document::forms): (WebCore::Document::anchors): (WebCore::Document::all): (WebCore::Document::windowNamedItems): (WebCore::Document::documentNamedItems):
  • dom/Document.h:
  • dom/DynamicNodeList.h:
  • dom/EventException.h: (WebCore::EventException::create): (WebCore::EventException::EventException):
  • dom/EventListener.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::addEventListener): (WebCore::EventTarget::removeEventListener):
  • dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
  • dom/ExceptionBase.h:
  • dom/NameNodeList.h: (WebCore::NameNodeList::create):
  • dom/Node.cpp: (WebCore::Node::childNodes): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName): (WebCore::Node::querySelectorAll):
  • dom/NodeFilterCondition.h:
  • dom/NodeList.h:
  • dom/RangeException.h: (WebCore::RangeException::create): (WebCore::RangeException::RangeException):
  • dom/RegisteredEventListener.h: (WebCore::RegisteredEventListener::create):
  • dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
  • dom/SelectorNodeList.h:
  • dom/StaticNodeList.cpp: (WebCore::StaticNodeList::StaticNodeList):
  • dom/StaticNodeList.h: (WebCore::StaticNodeList::adopt):
  • dom/TagNodeList.h: (WebCore::TagNodeList::create):
  • history/HistoryItem.cpp: (WebCore::defaultNotifyHistoryItemChanged): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::copy):
  • history/HistoryItem.h: (WebCore::HistoryItem::create):
  • html/CanvasGradient.h:
  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
  • html/CanvasPattern.h: (WebCore::CanvasPattern::create):
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::setStrokeColor): (WebCore::CanvasRenderingContext2D::setFillColor): (WebCore::CanvasRenderingContext2D::createPattern):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle):
  • html/CanvasStyle.h: (WebCore::CanvasStyle::create):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::create):
  • html/HTMLCollection.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::children):
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::create):
  • html/HTMLFormCollection.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::elements):
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::areas):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): (WebCore::HTMLMediaElement::willSaveToCache):
  • html/HTMLNameCollection.h: (WebCore::HTMLNameCollection::create):
  • html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::create):
  • html/HTMLOptionsCollection.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::options):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::rows): (WebCore::HTMLTableElement::tBodies):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::cells):
  • html/HTMLTableRowsCollection.cpp: (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): (WebCore::HTMLTableRowsCollection::create):
  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows):
  • html/MediaError.h: (WebCore::MediaError::create): (WebCore::MediaError::MediaError):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::write): (WebCore::FrameLoader::createHistoryItem):
  • loader/ImageDocument.cpp: (WebCore::ImageEventListener::create): (WebCore::ImageEventListener::ImageEventListener): (WebCore::ImageDocument::createDocumentStructure):
  • loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::create):
  • page/Page.cpp: (WebCore::Page::userStyleSheet):
  • svg/SVGException.h: (WebCore::SVGException::create): (WebCore::SVGException::SVGException):
  • svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::create): (WebCore::ConditionEventListener::ConditionEventListener): (WebCore::SVGSMILElement::connectConditions):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequestException.h: (WebCore::XMLHttpRequestException::create): (WebCore::XMLHttpRequestException::XMLHttpRequestException):
  • xml/XPathException.h: (WebCore::XPathException::create): (WebCore::XPathException::XPathException):
  • xml/XPathResult.cpp: (WebCore::InvalidatingEventListener::create): (WebCore::InvalidatingEventListener::InvalidatingEventListener): (WebCore::XPathResult::XPathResult):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):

WebKit/mac:

2008-06-07 Darin Adler <Darin Adler>

Reviewed by Mitz.

  • History/WebHistoryItem.mm: (-[WebHistoryItem init]): (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
  • WebView/WebView.mm: (+[WebView _decodeData:]):

WebKit/win:

2008-06-07 Darin Adler <Darin Adler>

Reviewed by Mitz.

  • WebHistoryItem.cpp: (WebHistoryItem::createInstance): (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::initWithURLString):
3:49 PM Changeset in webkit [34431] by weinig@apple.com
  • 9 edits in trunk/LayoutTests

2008-06-07 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix random failures of XSS tests by using window.postMessage().

  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame.html:
  • http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
  • http/tests/security/resources/cross-frame-access.js:
  • http/tests/security/resources/cross-frame-iframe-with-explicit-domain-set.html:
  • http/tests/security/resources/cross-frame-iframe.html:
  • platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
3:37 PM Changeset in webkit [34430] by mitz@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Sam Weinig.

  • fast/text/selection-painted-separately.html: Added.
  • platform/mac/fast/text/selection-painted-separately-expected.checksum: Added.
  • platform/mac/fast/text/selection-painted-separately-expected.png: Added.
  • platform/mac/fast/text/selection-painted-separately-expected.txt: Added.
2:56 PM Changeset in webkit [34429] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-07 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Eric.

Bug 17548: JavaScriptCore print(a, b) differs from Spidermonkey Behavior
<​https://bugs.webkit.org/show_bug.cgi?id=17548>

  • kjs/testkjs.cpp: (functionPrint):
12:32 PM Changeset in webkit [34428] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-07 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Sam.

Bug 17547: JavaScriptCore print() differs from Spidermonkey Behavior
<​https://bugs.webkit.org/show_bug.cgi?id=17547>

  • kjs/testkjs.cpp: (functionPrint):
12:02 PM Changeset in webkit [34427] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2008-06-07 Adam Barth <​abarth@webkit.org>

Reviewed by Sam.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=17911

  • http/tests/security/resources/iframe-for-synchronous-form.html: Added.
  • http/tests/security/xss-DENIED-synchronous-form-expected.txt: Added.
  • http/tests/security/xss-DENIED-synchronous-form.html: Added.
11:07 AM Changeset in webkit [34426] by christian@webkit.org
  • 6 edits in trunk

Remove PLATFORM ifdefs from ContextMenu.cpp

​https://bugs.webkit.org/show_bug.cgi?id=17324

Reviewed by Alp Toker.

3:59 AM Changeset in webkit [34425] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

More build fixes.

  • kjs/JSGlobalData.cpp: Fixed an included file name for case-sensitive file systems, fixed JSGlobalData::threadInstance() for non-multithreaded builds.
3:41 AM Changeset in webkit [34424] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Build fix - actually adding JSGlobalData.cpp to non-Mac builds!

3:36 AM Changeset in webkit [34423] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by ap.

Still more CSSParser cleanup

  • use c++ style member initializers in CSSParser()
  • change m_styleElement to m_styleSheet and make it a CSSStyleSheet
  • finally add my copyright to the files I've been cleaning
  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createMediaRule): (WebCore::CSSParser::createStyleRule):
  • css/CSSParser.h:
  • css/SVGCSSParser.cpp:
3:35 AM Changeset in webkit [34422] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by ap.

More CSSParser cleanup

  • rename CSSParser::id to m_id
  • rename CSSParser::data to m_data
  • fix a few whitespace and argument name issues
  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseValue):
  • css/CSSParser.h:
3:35 AM Changeset in webkit [34421] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by ap.

Rename CSSParser::strict to m_strict

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundColor): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseTransitionDuration): (WebCore::CSSParser::parseTransitionRepeatCount): (WebCore::CSSParser::parseTimingFunctionValue): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseColorFromValue): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::CSSParser::parseBorderImage):
  • css/CSSParser.h:
3:34 AM Changeset in webkit [34420] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by ap.

Rename CSSParser::defaultNamespace to m_defaultNamespace

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet):
  • css/CSSParser.h:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addNamespace):
3:34 AM Changeset in webkit [34419] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by ap.

Rename CSSParser::important to m_important

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange):
  • css/CSSParser.h:
3:33 AM Changeset in webkit [34418] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by ap.

Yet another cleanup patch for CSSParser
Rename CSSParser::valueList to m_valueList

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::checkForOrphanedUnits): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransitionProperty): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::parseCounter): (WebCore::CSSParser::parseGradient): (WebCore::CSSParser::parseCanvas): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin):
  • css/CSSParser.h:
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
3:32 AM Changeset in webkit [34417] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by ap.

More cleanup to CSSParser, rename mediaQuery to m_mediaQuery
Remove CSSParser::current and CSSParser::currentParser and use
the magic of YYLEX_PARAM instead.

  • css/CSSParser.cpp: (WebCore::enterGeneratedParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseRule): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseMediaQuery):
  • css/CSSParser.h:
3:20 AM Changeset in webkit [34416] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Try to fix Gtk/gcc 4.3 build.

  • kjs/JSGlobalData.h: Include ustring.h instead of forward-declaring UString::Rep.
2:57 AM Changeset in webkit [34415] by jchaffraix@webkit.org
  • 4 edits in trunk/WebCore

WebCore:

2008-06-07 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Part of bug 19200: *.in files should embed more information
​https://bugs.webkit.org/show_bug.cgi?id=19200

  • Added XML attributes' parsing.
  • Moved (most) capitalization and audio hacks in the *.in files.
  • dom/make_names.pl:
  • html/HTMLTagNames.in:
  • svg/svgtags.in:
1:20 AM Changeset in webkit [34414] by mitz@apple.com
  • 2 edits in trunk/WebCore

2008-06-07 Pierre-Luc Beaudoin <​pierre-luc.beaudoin@collabora.co.uk>

With the help of Jonathon Jongsma.

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19279
REGRESSION (r32660): Text not redrawn correctly when selection changes

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Add a condition for when ePos <= sPos
12:58 AM Changeset in webkit [34413] by cwzwarich@webkit.org
  • 3 edits in trunk/LayoutTests

2008-06-07 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 17663: Wrong sequencing of argument list evaluation
<​https://bugs.webkit.org/show_bug.cgi?id=17663>

SquirrelFish fixed this bug, but we should add a test.

LayoutTests:

  • fast/js/order-of-operations-expected.txt:
  • fast/js/resources/order-of-operations.js:
Note: See TracTimeline for information about the timeline view.