Timeline
Aug 27, 2009:
- 11:17 PM Changeset in webkit [47857] by
-
- 5 edits in trunk
JSON Stringifier does not follow ES5 spec for handling of Number, String and Boolean objects
https://bugs.webkit.org/show_bug.cgi?id=28797
Reviewed by Maciej Stachowiak
Fixed unwrapBoxedPrimitive to do the right thing, which necessitated a couple of new exception
checks, and corrected the logic in gap to correctly convert Number and String objects.
- 9:54 PM Changeset in webkit [47856] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Skipping worker-lifecycle.html test since it generates a deadlock on snowleopard.
Tracked as https://bugs.webkit.org/show_bug.cgi?id=28795.
- platform/mac-snowleopard/Skipped:
- 8:09 PM Changeset in webkit [47855] by
-
- 2 edits in trunk/WebCore
2009-08-27 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Removed ASSERT_NOT_REACHED, because indeed this ASSERT is reached in
fast/canvas/change-context.html. And it's alright to reach it.
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Removed assertion.
- 7:03 PM Changeset in webkit [47854] by
-
- 2 edits in trunk/WebCore
2009-08-27 Jeremy Orlow <jorlow@chromium.org>
Not reviewed. Build fix for http://trac.webkit.org/changeset/47840
Peter's change forgot one m_decoder->
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- 6:58 PM Changeset in webkit [47853] by
-
- 2 edits in trunk/WebCore
2009-08-27 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[V8] Add NULL-check, since the context ain't changeable no more, and
thus getContext could return 0.
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Added NULL-check.
- 6:38 PM Changeset in webkit [47852] by
-
- 6 edits in trunk
2009-08-27 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Eric Seidel.
dataTransfer.types() should include type "Files" when files are present in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28780
Add dataTransfer type "Files" to the chromium port. Add eseidel's
patch for same for the mac port.
- platform/chromium/ClipboardChromium.cpp:
2009-08-27 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Eric Seidel.
dataTransfer.types() should include type "Files" when files are present in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28780
Test dataTransfer.types "Files" access for all ports.
- http/tests/security/clipboard/clipboard-file-access-expected.txt:
- http/tests/security/clipboard/resources/clipboard-file-access.js:
- 6:20 PM Changeset in webkit [47851] by
-
- 7 edits in trunk/WebCore
Removed GL_ from all constants, and gl prefix from all calls
https://bugs.webkit.org/show_bug.cgi?id=28773
This was done for the external API in CanvasRenderingContext3D and
the internal API in GraphicsContext3D.
- 6:08 PM Changeset in webkit [47850] by
-
- 2 edits in trunk/LayoutTests
Tweak to force worker object to get GC'd.
Reviewed by Oliver Hunt.
- fast/workers/resources/dedicated-worker-lifecycle.js:
- 6:00 PM Changeset in webkit [47849] by
-
- 3 edits in trunk/WebCore
2009-08-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Qt and Gtk build fixes. Not reviewed.
Add CanvasRenderingContext3D.idl to the build scripts.
- GNUmakefile.am:
- WebCore.pro:
- 5:31 PM Changeset in webkit [47848] by
-
- 2 edits in trunk/WebKit
- StringsNotToBeLocalized.txt:
Brought up to date, other than the problem mentioned in https://bugs.webkit.org/show_bug.cgi?id=28792
- 5:27 PM Changeset in webkit [47847] by
-
- 6 edits in trunk
JSON.stringify replacer array does not accept values that are not string primitives.
https://bugs.webkit.org/show_bug.cgi?id=28788
Reviewed by Adam Roben
Update the JSON stringifier to initialise its replacer array according to the most
recent version of the spec.
- 5:13 PM Changeset in webkit [47846] by
-
- 3 edits in trunk/WebCore
2009-08-27 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Release the storage mutex whenever leaving JavaScript execution.
https://bugs.webkit.org/show_bug.cgi?id=28789
http://dev.w3.org/html5/spec/Overview.html#storage-mutex describes the
required behavior. After we leave JavaScript, we must be sure the storage
mutex has been released. At the end of evaluate(), if localStorage has been
instantiated, tell it to release any locks that may be applicable.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- 5:11 PM Changeset in webkit [47845] by
-
- 4 edits in trunk
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=28753
<rdar://problem/7173448> Excessive number of threads (and a crash)
Coalesce DNS prefetch requests to reduce strain on CFHost. Currently, the algorithm is as follows:
- when resolver is idle, the first few requests are sent immediately (they may or may not hit the wire);
- if there are a few requests in flight already, coalesce all requests for one second;
- to avoid pathological cases with lots of links to different sites on a page, only ask CFHost about a handful of names (dropping the rest).
Coalescing reduces the number of requests dramatically, as prefetchDNS is called for each
link, and these tend to have identical host name.
- platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::DNSResolveQueue): (WebCore::DNSResolveQueue::shared): (WebCore::DNSResolveQueue::add): (WebCore::DNSResolveQueue::decrementRequestCount): (WebCore::DNSResolveQueue::fired): (WebCore::clientCallback): (WebCore::DNSResolveQueue::resolve): (WebCore::prefetchDNS):
- 5:08 PM Changeset in webkit [47844] by
-
- 5 edits in trunk
JavaScriptCore: Link the testapi against CFLite when building the WinCairo port.
Reviewed by Adam Roben.
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Add new Release_CFLite target. Update all targets to inherit from either the JavaScriptCF.vsprops (Apple target) or the JavaScriptCFLite.vsprops file (WinCairo target).
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Remove input file CoreFoundation.lib. This is provided by either the JavaScriptCF.vsprops or JavaScriptCFLite.vsprops file.
WebKit/win: Modify Release_Cairo target to build testapi using the
Release_CFLite target so that the correct CoreFoundation
(in this case, CFLite.dll) is linked.
Reviewed by Adam Roben.
- WebKit.vcproj/WebKit.sln:
- 4:55 PM Changeset in webkit [47843] by
-
- 43 edits2 adds in trunk
Final patch for Canvas 3D support
https://bugs.webkit.org/show_bug.cgi?id=28018
This hooks everything up and provides a working implementation of
Canvas 3D. I plumb the creation of the 3D canvas down to GraphicsLayer,
passing the opaque context and texture pointers so a Canvas3DLayer can be
created (more on that later). It also plumbs changes to the 3D canvas so
that Canvas3DLayer can recomposite the results.
A 3D Canvas element needs a RenderLayer and compositing layer to render.
This is because it renders to an off-screen texture in the GPU and then
hands it to a Canvas3DLayer, which is a subclass of CAOpenGLLayer, to
render that texture as a 3D quad. This keeps everything in GPU memory to
maximize performance. When a CanvasRenderingContext3D is created it
forces a style recalc which creates the RenderLayer and compositing
layer if needed.
I repurposed an existing flag which was put in place for animation to accomplish
this. This flag is passed to setNeedsStyleRecalc(), and I renamed it from
AnimationStyleChange to SyntheticStyleChange. It essentially says that you need
to do a complete style recalc, even though the style itself has not really
changed.
This patch also fixes a couple of bugs discovered when testing with 3d-canvas
turned on. I also added a constructor DOMWindow.idl for CanvasRenderingContext3D.
This is needed when making a JS wrapper for the object so the prototype
property can be set.
- 4:35 PM Changeset in webkit [47842] by
-
- 2 edits in trunk/JavaScriptCore
Fix Windows-specific crash due to missing memory clearing call.
Reviewed by Geoff Garen.
- runtime/Collector.cpp:
(JSC::Heap::allocateBlock):
- 4:16 PM Changeset in webkit [47841] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28751
Clean up ImageDecoder*.cpp a bit.
Reviewed by Eric Seidel.
- platform/image-decoders/ImageDecoder.cpp: Put functions in the same order as in the header file. Also, since there's already an anonymous namespace in this file, use it to enclose the local helper functions.
(WebCore::):
(WebCore::ImageDecoder::upperBoundScaledX):
(WebCore::ImageDecoder::lowerBoundScaledX):
(WebCore::ImageDecoder::scaledY):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::RGBA32Buffer::width): Style fix.
(WebCore::RGBA32Buffer::height): Style fix.
- platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
(WebCore::RGBA32Buffer::copyBitmapData): Ensure m_size is set correctly.
(WebCore::RGBA32Buffer::asNewNativeImage): Remove unneeded temp.
(WebCore::RGBA32Buffer::operator=): Simplify.
- platform/image-decoders/wx/ImageDecoderWx.cpp:
(WebCore::RGBA32Buffer::asNewNativeImage): Try and collect spaced-out temps under loop comment to show they're all related. Use size_t for iterating over elements of a Vector.
(WebCore::RGBA32Buffer::width): Style fix.
(WebCore::RGBA32Buffer::height): Style fix.
- 4:14 PM Changeset in webkit [47840] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28751
Clean up ImageSource.* in preparation for more fixes on bug 27965.
Reviewed by Eric Seidel.
- platform/graphics/ImageSource.cpp: Put functions in the same order as in header file.
(WebCore::ImageSource::isSizeAvailable): Shorten.
(WebCore::ImageSource::size): Shorten.
(WebCore::ImageSource::frameSizeAtIndex): Shorten.
(WebCore::ImageSource::repetitionCount): Shorten.
(WebCore::ImageSource::frameIsCompleteAtIndex):
- platform/graphics/ImageSource.h: Shorten #ifdef section a bit by sharing common typedefs.
- 3:58 PM Changeset in webkit [47839] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Skip HTML5 worker lifecycle test added in r47837 as it depends on unimplemented functionality in DRT.
- platform/qt/Skipped:
- 3:05 PM Changeset in webkit [47838] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: JavaScriptCore_debug.def missing some exports. Apple
Windows build does not use this file, so it was not noticed previously.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 2:57 PM Changeset in webkit [47837] by
-
- 4 edits8 adds in trunk/LayoutTests
Need to write tests for worker lifecycle mechanisms.
https://bugs.webkit.org/show_bug.cgi?id=28714
Reviewed by David Levin.
- fast/workers/dedicated-worker-lifecycle-expected.txt: Added.
- fast/workers/dedicated-worker-lifecycle.html: Added.
- fast/workers/resources/create-shared-worker-frame.html: Added.
- fast/workers/resources/dedicated-worker-lifecycle.js: Added.
Broke out "orphaned worker" lifecycle tests because they only apply to dedicated workers.
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
(orphanedTimeoutWorkerExited):
- fast/workers/resources/shared-worker-lifecycle.js: Added.
Added tests for the various shared worker lifecycle cases (makes sure that refcounts are properly updated when documents close).
(runTests):
(createWorkerFrame):
(closeFrame):
(closeFrame1):
(closeFrame2):
(closeFrame3):
(closeFrame4):
(complete):
- fast/workers/resources/worker-lifecycle.js:
Updated test so it can run in a browser (with incorrect output) to aid in debugging.
(runTests.worker.onmessage):
(runTests):
(workerExited):
- fast/workers/resources/worker-util.js: Added.
Moved some common utilities out of worker-lifecycle.js and into this file so they can be shared with other tests.
(log):
(gc):
(waitUntilWorkerThreadsExit):
(waitUntilThreadCountMatches.return):
(waitUntilThreadCountMatches):
(ensureThreadCountMatches):
(done):
- fast/workers/shared-worker-frame-lifecycle-expected.txt: Added.
- fast/workers/shared-worker-frame-lifecycle.html-disabled: Added.
- fast/workers/shared-worker-lifecycle.html-disabled:
- fast/workers/worker-lifecycle.html:
- 2:38 PM Changeset in webkit [47836] by
-
- 7 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28785
Add ImageDecoder.cpp to various build files so platforms will be able to
use it. Move an ENABLE to not cover the whole file, in preparation for
adding a bunch of code. Simplify #ifdefs in ImageDecoder.h to be "Skia
vs. everyone else", which also gives new platforms a reasonable default
behavior.
Reviewed by Eric Seidel.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::):
- platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::getAddr):
- 1:55 PM Changeset in webkit [47835] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28784
Reviewed by Dave Kilzer.
Add an exported method to flush pending repaints.
- WebCore.base.exp:
- page/FrameView.cpp:
(WebCore::FrameView::layoutIfNeededRecursive):
(WebCore::FrameView::flushDeferredRepaints):
- page/FrameView.h:
- 1:45 PM Changeset in webkit [47834] by
-
- 3 edits in trunk/JavaScriptCore
x86-64 GTK broken due to code offsets changing, pointers sometimes packed into immediates.
https://bugs.webkit.org/show_bug.cgi?id=28317
Reviewed by Oliver Hunt.
Missed one, fix part II.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::move):
- assembler/X86Assembler.h:
(JSC::CAN_SIGN_EXTEND_8_32):
- 1:39 PM Changeset in webkit [47833] by
-
- 2 edits in trunk/WebCore
2009-08-27 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Eric Seidel.
[V8] Expose files from the pasteboard in drop events.
https://bugs.webkit.org/show_bug.cgi?id=28782
Update chromium port to expose dataTransfer.files() as per
HTML5 drag drop (Aug 2009 edition).
- platform/chromium/ClipboardChromium.cpp:
- 1:29 PM Changeset in webkit [47832] by
-
- 3 edits in trunk/LayoutTests
2009-08-27 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Eric Seidel.
clipboard file access tests use "dragentered" instead of "dragenter"
https://bugs.webkit.org/show_bug.cgi?id=28761
Use dragenter and log these events. Add a dragleave test to check
that drag files are not visible in dragleave events.
- http/tests/security/clipboard/clipboard-file-access-expected.txt:
- http/tests/security/clipboard/resources/clipboard-file-access.js:
- 12:40 PM Changeset in webkit [47831] by
-
- 9 edits in trunk/WebCore
2009-08-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dmitry Glazkov.
ScriptState now keeps explicit Handle of devtools front-end
utility context instead of trying to retrieve it from inspected
Frame.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope):
- bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::~ScriptState): (WebCore::scriptStateFromPage):
- bindings/v8/ScriptState.h: (WebCore::ScriptState::context):
- bindings/v8/ScriptValue.h: (WebCore::ScriptValue::~ScriptValue):
- inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
- 12:37 PM Changeset in webkit [47830] by
-
- 3 edits in trunk/WebCore
2009-08-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Console won't close.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._updateModifiedNodes):
- inspector/front-end/utilities.js: (Node.prototype.isAncestor):
- 12:16 PM Changeset in webkit [47829] by
-
- 3 edits3 adds in trunk
2009-08-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add a test to make sure that image/link drags don't contain junk file arrays.
https://bugs.webkit.org/show_bug.cgi?id=28755
- editing/pasteboard/files-during-page-drags-expected.txt: Added.
- editing/pasteboard/files-during-page-drags.html: Added.
- editing/pasteboard/resources/files-during-page-drags.js: Added.
2009-08-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix a typo in files() causing image drags to have junk file arrays.
https://bugs.webkit.org/show_bug.cgi?id=28755
Test: editing/pasteboard/files-during-page-drags.html
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::files):
- 12:15 PM Changeset in webkit [47828] by
-
- 5 edits in trunk
JSON parser accepts trailing comma in array literals
https://bugs.webkit.org/show_bug.cgi?id=28779
Reviewed by Alexey Proskuryakov.
Update parser to correctly fail if there's a trailing comma.
- 11:46 AM Changeset in webkit [47827] by
-
- 5 edits in trunk/WebCore
Not reviewed. Build fix for Chromium.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-08-27
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 11:07 AM Changeset in webkit [47826] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- DerivedSources.cpp: Added JSPageTransitionEvent.cpp to DerivedSources.cpp.
- 10:52 AM Changeset in webkit [47825] by
-
- 1 edit in trunk/WebCore/ChangeLog
Zap gremlins from a recent ChangeLog entry.
- 10:46 AM Changeset in webkit [47824] by
-
- 25 edits13 adds in trunk
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=28758
<rdar://problem/6440869> Implement pageshow and pagehide events for b/f cache (28758)
Tests: fast/events/pageshow-pagehide-on-back-cached.html
fast/events/pageshow-pagehide-on-back-uncached.html
fast/events/pageshow-pagehide.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Dispatch pagehide event (this function is called both when a document goes away, and when it goes to b/f cache).
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Dispatch pagehide right before unload. (WebCore::DOMWindow::dispatchPageTransitionEvent): Do what it takes to add a new event handler that can be installed on Window object. (WebCore::DOMWindow::onpagehide): Ditto. (WebCore::DOMWindow::setOnpagehide): Ditto. (WebCore::DOMWindow::onpageshow): Ditto. (WebCore::DOMWindow::setOnpageshow): Ditto.
- history/CachedFrame.cpp: (WebCore::CachedFrame::restore): Dispatch pageshow for a page that isn't being restored from cache.
- dom/PageTransitionEvent.cpp: Added. (WebCore::PageTransitionEvent::PageTransitionEvent): (WebCore::PageTransitionEvent::~PageTransitionEvent): (WebCore::PageTransitionEvent::initPageTransitionEvent):
- dom/PageTransitionEvent.h: Added. (WebCore::PageTransitionEvent::create): (WebCore::PageTransitionEvent::isPageTransitionEvent): (WebCore::PageTransitionEvent::persisted):
- dom/PageTransitionEvent.idl: Added. Add event class implementation.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Support inline listener definition (note that adding listeners to document.body programmatically is not supported, matching Firefox).
- dom/Document.cpp: (WebCore::Document::implicitClose): Dispatch pageshow event right before load event. (WebCore::Document::dispatchPageTransitionEvent): Do what it takes to add a new event for Docuemnt. (WebCore::Document::createEvent): Ditto.
- dom/Document.h: Added dispatchPageTransitionEvent.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- dom/Event.cpp: (WebCore::Event::isPageTransitionEvent):
- dom/Event.h:
- dom/EventNames.h:
- html/HTMLAttributeNames.in:
- page/DOMWindow.h:
- page/DOMWindow.idl: Do what it takes to add a new event type.
- 9:35 AM Changeset in webkit [47823] by
-
- 1 edit1 add in trunk/WebCore
2009-08-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by NOBODY (build fix).
Adding missing file from previous commit.
- inspector/front-end/SummaryBar.js: Added. (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.get calculator): (WebInspector.SummaryBar.prototype.set calculator): (WebInspector.SummaryBar.prototype.reset): (WebInspector.SummaryBar.prototype.update): (WebInspector.SummaryBar.prototype._drawSwatch.drawSwatchSquare): (WebInspector.SummaryBar.prototype._drawSwatch): (WebInspector.SummaryBar.prototype._drawSummaryGraph.var): (WebInspector.SummaryBar.prototype._drawSummaryGraph): (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill): (WebInspector.SummaryBar.prototype._fadeOutRect): (WebInspector.SummaryBar.prototype._makeLegendElement):
- 9:09 AM Changeset in webkit [47822] by
-
- 7 edits in trunk/WebCore
2009-08-27 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Factor out Factor out summary bar from Resources panel.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateSummaryGraph): (WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition): (WebInspector.ResourcesPanel.prototype._changeSortingFunction):
- inspector/front-end/SummaryBar.js: Added. (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.get calculator): (WebInspector.SummaryBar.prototype.set calculator): (WebInspector.SummaryBar.prototype.reset): (WebInspector.SummaryBar.prototype.update): (WebInspector.SummaryBar.prototype._drawSwatch.drawSwatchSquare): (WebInspector.SummaryBar.prototype._drawSwatch): (WebInspector.SummaryBar.prototype._drawSummaryGraph.var): (WebInspector.SummaryBar.prototype._drawSummaryGraph): (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill): (WebInspector.SummaryBar.prototype._fadeOutRect): (WebInspector.SummaryBar.prototype._makeLegendElement):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- 8:38 AM Changeset in webkit [47821] by
-
- 4 edits in trunk/WebCore
2009-08-26 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Start adding heap profiler to Inspector (hidden behind a flag.)
- English.lproj/localizedStrings.js:
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.get statusBarItems): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.addProfile): (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._snapshotClicked):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: added Preferences.heapProfilerPresent flag.
- 8:24 AM Changeset in webkit [47820] by
-
- 2 edits in trunk/WebCore
2009-08-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Metrics sidebar editing is broken.
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update):
- 7:54 AM Changeset in webkit [47819] by
-
- 2 edits in trunk/WebCore
2009-08-27 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Make KURLGoogle.cpp's decodeURLEscapeSequences decode %00 to match
KURL.cpp. This makes the XSSAuditor tests pass when using KURLGoogle.
- platform/KURLGoogle.cpp: (WebCore::decodeURLEscapeSequences):
- 7:43 AM BuildingQtOnOSX edited by
- (diff)
- 7:38 AM BuildingQtOnOSX edited by
- (diff)
- 5:27 AM Changeset in webkit [47818] by
-
- 3 edits in trunk/WebKit/qt
2009-08-27 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Ariya Hidayat.
QWebHistory::clear() modifications.
Clear() method was changed. If QWebHistory is empty (there is no
elements even current) clear() do nothing. If there at least one
element clear() will delete everything apart of current.
New autotests in QWebHistory
New autotests were added to QWebHistory. They should check some crashes
in save and restore state process and clear() method and general
behavior on where QWebHistory::count() == 0 or QWebHistory::count() == 1
- Api/qwebhistory.cpp: (QWebHistory::clear):
- tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::back): (tst_QWebHistory::forward): (tst_QWebHistory::saveAndRestore_crash_1): (tst_QWebHistory::saveAndRestore_crash_2): (tst_QWebHistory::saveAndRestore_crash_3): (tst_QWebHistory::clear):
- 4:40 AM Changeset in webkit [47817] by
-
- 2 edits in trunk/WebKit/qt
2009-08-27 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Cleanup, old and commented part of source code was removed.
Fix some formatting problems.
- Api/qwebhistory_p.h: (QWebHistoryPrivate::QWebHistoryPrivate):
- 4:18 AM Changeset in webkit [47816] by
-
- 2 edits in trunk/WebCore
2009-08-27 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Build fix, missing functions after r47763.
- platform/qt/Localizations.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
- 2:44 AM Changeset in webkit [47815] by
-
- 21 edits in trunk/LayoutTests
2009-08-27 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt]Update expecteds (t150*) in css2.1 and remove from Skipped. This affects 20 files.
- platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
- platform/qt/css2.1/t1504-c523-font-style-00-b-expected.txt:
- platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt:
- platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
- platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
- platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-01-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-02-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-09-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
- 2:42 AM Changeset in webkit [47814] by
-
- 18 edits in trunk/LayoutTests
2009-08-27 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Update outdated font metrics in these css1 tests since we pass them.
- platform/qt/Skipped:
- platform/qt/css1/box_properties/clear-expected.txt:
- platform/qt/css1/box_properties/clear_float-expected.txt:
- platform/qt/css1/box_properties/float-expected.txt:
- platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
- platform/qt/css1/box_properties/float_margin-expected.txt:
- platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
- platform/qt/css1/box_properties/height-expected.txt:
- platform/qt/css1/box_properties/width-expected.txt:
- platform/qt/css1/cascade/cascade_order-expected.txt:
- platform/qt/css1/cascade/important-expected.txt:
- platform/qt/css1/classification/display-expected.txt:
- platform/qt/css1/classification/list_style-expected.txt:
- platform/qt/css1/classification/list_style_image-expected.txt:
- platform/qt/css1/classification/list_style_position-expected.txt:
- platform/qt/css1/classification/list_style_type-expected.txt:
- platform/qt/css1/classification/white_space-expected.txt:
- 2:07 AM Changeset in webkit [47813] by
-
- 2 edits in trunk/LayoutTests
2009-08-26 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Skip HTML5 input-list tests added in r47767.
- platform/qt/Skipped:
- 1:39 AM Changeset in webkit [47812] by
-
- 4 edits3 adds in trunk
'this' in JSON.parse reviver is the global object
https://bugs.webkit.org/show_bug.cgi?id=28752
Reviewed by Gavin Barraclough.
This is a technically simple change, we merely update the code for calling
the reviver function to pass the correct this object. Doing so however
exposes the holder to arbitrary mutation by the reviver function so it is
necessary for us to now guard all property accesses against the possibility
of failure.
- 12:26 AM Changeset in webkit [47811] by
-
- 3 edits in trunk
2009-08-27 Priit Laes <plaes@plaes.org>
Reviewed by Xan Lopez.
[GTK] Out-of-srcdir build problem
https://bugs.webkit.org/show_bug.cgi?id=28741
- GNUmakefile.am, autotools/webkit.m4: Fix problem with out-of-srcdir builds. Also bump required glib version.
Aug 26, 2009:
- 11:38 PM Changeset in webkit [47810] by
-
- 2 edits in trunk/WebKitTools
2009-08-26 Cameron McCormack <cam@mcc.id.au>
Reviewed by David Kilzer.
Make prepare-ChangeLog notice property changes
https://bugs.webkit.org/show_bug.cgi?id=28675
Make the generated ChangeLog entry include a short description of
property changes if there were such changes. Also make
prepare-ChangeLog not bail if the only changes are property changes.
- Scripts/prepare-ChangeLog:
- 11:33 PM Changeset in webkit [47809] by
-
- 6 edits4 adds in trunk/LayoutTests
2009-08-26 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Re-baselined and created new isolatedWorld tests to play nice with localStorage & sessionStorage.
https://bugs.webkit.org/show_bug.cgi?id=27992
- http/tests/security/isolatedWorld/all-window-properties.html: Re-baselined.
- http/tests/security/isolatedWorld/storage-properties-expected.txt: Added.
- http/tests/security/isolatedWorld/storage-properties.html: Added.
- http/tests/security/isolatedWorld/storage-prototype-expected.txt: Added.
- http/tests/security/isolatedWorld/storage-prototype.html: Added.
- platform/qtk/Skipped: Added new tests.
- platform/mac/Skipped: Added new tests.
- platform/qt/Skipped: Added new tests.
- platform/win/Skipped: Added new tests.
- 10:22 PM Changeset in webkit [47808] by
-
- 39 edits in trunk/WebCore
2009-08-26 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Removing trailing whitespaces from all storage classes.
- storage/ChangeVersionWrapper.cpp:
- storage/Database.cpp:
- storage/Database.h:
- storage/DatabaseDetails.h:
- storage/DatabaseThread.cpp:
- storage/DatabaseTracker.cpp:
- storage/DatabaseTracker.h:
- storage/LocalStorageTask.cpp:
- storage/LocalStorageTask.h:
- storage/LocalStorageThread.cpp:
- storage/LocalStorageThread.h:
- storage/OriginQuotaManager.cpp:
- storage/OriginUsageRecord.cpp:
- storage/OriginUsageRecord.h:
- storage/SQLError.h:
- storage/SQLResultSetRowList.h:
- storage/SQLStatement.cpp:
- storage/SQLStatement.h:
- storage/SQLStatementCallback.h:
- storage/SQLStatementErrorCallback.h:
- storage/SQLTransaction.cpp:
- storage/SQLTransaction.h:
- storage/SQLTransactionCallback.h:
- storage/SQLTransactionErrorCallback.h:
- storage/Storage.cpp:
- storage/Storage.h:
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp:
- storage/StorageAreaImpl.h:
- storage/StorageAreaSync.cpp:
- storage/StorageAreaSync.h:
- storage/StorageEvent.cpp:
- storage/StorageEvent.h:
- storage/StorageMap.cpp:
- storage/StorageMap.h:
- storage/StorageNamespaceImpl.cpp:
- storage/StorageSyncManager.cpp:
- storage/StorageSyncManager.h:
- 10:21 PM Changeset in webkit [47807] by
-
- 8 edits in trunk
2009-08-26 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
2009-08-26 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
2009-08-26 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
A bunch of our LayoutTests rely on our old behavior, so we explicitly
grant local files universal access during testing. Mainly, these tests
involve making XMLHttpRequests for data URLs.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 8:49 PM EFLWebKit edited by
- (diff)
- 7:45 PM Changeset in webkit [47806] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix: added some exported symbols
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 7:26 PM Changeset in webkit [47805] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28763, flickering when opacity changes.
Reviewed by Anders Carlsson.
Make opacity changes from < 1 to 1 and from 1 to < 1 cause a relayout to happen. We need
to do this in order for overflow information to be properly recomputed.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- 7:07 PM Changeset in webkit [47804] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix: Removed some exported symbols that no longer exist.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-26
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 7:02 PM Changeset in webkit [47803] by
-
- 2 edits in trunk/LayoutTests
2009-08-26 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (Build fix).
Fixup test after r47801: skip the first 'waiting' event because it is fired
when we call play() and there isn't enough media to begin playback immediately,
but we are interested in the 'waiting' event fired when the movie runs
out of loaded media.
- http/tests/media/video-play-stall-seek.html:
- 6:16 PM Changeset in webkit [47802] by
-
- 2 edits in trunk/JavaScriptCore
x86-64 GTK broken due to code offsets changing, pointers sometimes packed into immediates.
https://bugs.webkit.org/show_bug.cgi?id=28317
Reviewed by Olliejver Hunt.
We rely on a slightly OS X specific behaviour, that x86-64 applications have a 4Gb zero page,
so pointers are never representable as a 32-bit integer, and always have to be represented by
a separate immediate load instruction, rather than within the immediate field of an arithmetic
or memory operation.
We explicitly check for a couple of cases where a value might be representable in 32-bit, but
these probably never kick in on Mac OS, and only kick in to hose GTK. Deleting these does not
show a performance degradation on SunSpider. Remove.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::storePtr):
(JSC::MacroAssemblerX86_64::branchPtr):
- 5:47 PM Changeset in webkit [47801] by
-
- 7 edits2 adds in trunk
2009-08-26 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
HTMLMediaElement sometimes loses events
https://bugs.webkit.org/show_bug.cgi?id=28762
<rdar://problem/7172437>
A media element triggers the resource selection algorithm if
play() is called when the networkState attribute is NETWORK_EMPTY, but
it also immediately queues 'play' and either 'waiting' or 'playing' events.
One of the steps in preparing to load is to flush pending events, so those
events were lost if the load timer fired quickly enough. Fixed by deleting
pending events before scheduling the load timer.
Test: media/audio-play-event.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::scheduleLoad):
Do nothing if the load timer is already scheduled. Call prepareForLoad so queue of
pending events is flushed immediately.
(WebCore::HTMLMediaElement::scheduleNextSourceChild):
New, start the load timer without flushing pending events.
(WebCore::HTMLMediaElement::load):
Call prepareForLoad();
(WebCore::HTMLMediaElement::prepareForLoad):
New, load setup code moved from loadInternal.
(WebCore::HTMLMediaElement::loadInternal):
Moved some setup code to prepareForLoad so it can be invoked immediately before
arming the load timer.
(WebCore::HTMLMediaElement::setNetworkState):
Call scheduleNextSourceChild instead of scheduleLoad as the later now clears
pending events.
- html/HTMLMediaElement.h:
Declare scheduleNextSourceChild.
2009-08-26 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
HTMLMediaElement sometimes loses events
https://bugs.webkit.org/show_bug.cgi?id=28762
<rdar://problem/7172437>
- media/audio-play-event.html:
- media/audio-play-event-expected.txt:
Added.
- media/video-play-empty-events-expected.txt:
Updated results for previously missed events.
- media/video-src-remove.html:
- media/video-timeupdate-during-playback-expected.txt:
Restructured to make results less timing dependent.
- 5:35 PM QtWebKit edited by
- add OSX building instructions link (diff)
- 5:33 PM BuildingQtOnOSX edited by
- (diff)
- 5:32 PM BuildingQtOnOSX edited by
- (diff)
- 5:29 PM BuildingQtOnOSX edited by
- (diff)
- 4:40 PM BuildingOnWindows edited by
- Added notice about proper ordering of Cygwin\bin in the list of VC++ … (diff)
- 4:40 PM Changeset in webkit [47800] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28751
Switch ICO decoder from a Vector of raw pointers to a Vector of
OwnPtrs now that that is possible. Makes code slightly simpler.
Reviewed by Eric Seidel.
- platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectory):
- platform/image-decoders/ico/ICOImageDecoder.h:
- 4:00 PM Changeset in webkit [47799] by
-
- 12 edits in trunk/JavaScriptCore
A bit of Collector refatoring.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-26
Reviewed by Oliver Hunt.
SunSpider says no change. v8 says 1.003x faster (1.02x faster on splay).
- JavaScriptCore.exp:
- runtime/JSCell.cpp:
(JSC::JSCell::toPrimitive):
(JSC::JSCell::getPrimitiveNumber):
(JSC::JSCell::toBoolean):
(JSC::JSCell::toNumber):
(JSC::JSCell::toString):
(JSC::JSCell::toObject): Removed pure virtual functions from
JSCell, so the collector can construct one. This allowed
me to remove a bunch of ASSERT_NOT_REACHED throughout the
code, too.
- runtime/JSCell.h:
(JSC::JSCell::JSCell): ditto
(JSC::Heap::heap): Inlined this function because it's trivial.
- JavaScriptCore.exp:
- runtime/Collector.cpp:
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks): Renamed freeHeap to freeBlocks, since
it doesn't actually free the Heap object.
(JSC::Heap::heapAllocate):
(JSC::Heap::sweep):
- runtime/Collector.h: Refactored block allocation and destruction
into helper functions.
- runtime/GetterSetter.cpp:
- runtime/JSAPIValueWrapper.cpp:
- runtime/JSPropertyNameIterator.cpp: Removed dummy implementations
of pure virtual functions. (See above.)
- 3:30 PM Changeset in webkit [47798] by
-
- 3 edits4 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=28718, image inside relpositioned inline doesn't paint.
Make sure vertical overflow is still computed across self-painting layers, even though it isn't
propagated to parents.
Reviewed by Dan Bernstein.
Added fast/repaint/rel-positioned-inline-with-overflow.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeVerticalOverflow):
LayoutTests: Add layout test for relpositioned inline regression.
Reviewed by Dan Bernstein.
- fast/repaint/rel-positioned-inline-with-overflow.html: Added.
- platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum: Added.
- platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
- platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.txt: Added.
- 2:57 PM Changeset in webkit [47797] by
-
- 10 edits in trunk
WebCore: ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
https://bugs.webkit.org/show_bug.cgi?id=28735
Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Darin Fisher.
Renaming the method to imply its wider implications of affecting cookies
over any protocol that supports them.
No change in functionality so no new tests.
- WebCore.order:
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
(WebCore::ResourceRequestBase::allowCookies):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::equalIgnoringHeaderFields):
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateFromSoupMessage):
WebKit/win: ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
https://bugs.webkit.org/show_bug.cgi?id=28735
Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Darin Fisher.
- WebMutableURLRequest.cpp:
(WebMutableURLRequest::setHTTPShouldHandleCookies):
- 2:54 PM Changeset in webkit [47796] by
-
- 4 edits4 adds in trunk
WebCore:
Made RenderInline::clippedOverflowRectForRepaint() actually include
overflow.
Reviewed by Dave Hyatt.
Test: fast/repaint/inline-overflow.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisibleOverflowBoundingBox): Added. Returns
the bounding box of all lines’ visible overflow boxes (under the
assumption that the first and last lines determine the top and
bottom, respectively).
(WebCore::RenderInline::clippedOverflowRectForRepaint): Changed to use
linesVisibleOverflowBoundingBox() instead of linesBoundingBox().
- rendering/RenderInline.h:
LayoutTests:
Test that RenderInline::clippedOverflowRectForRepaint() actually
includes overflow.
Reviewed by Dave Hyatt.
- fast/repaint/inline-overflow-expected.checksum: Added.
- fast/repaint/inline-overflow-expected.png: Added.
- fast/repaint/inline-overflow-expected.txt: Added.
- fast/repaint/inline-overflow.html: Added.
- 2:33 PM Changeset in webkit [47795] by
-
- 3 edits in trunk/JavaScriptCore
End re-roll-in of r47738:47740 with Windows crash fixed
2009-08-26 Geoffrey Garen <ggaren@apple.com>
Build fix: start out with a 32-bit value to avoid a shortening warning.
- runtime/Collector.cpp: (JSC::Heap::sweep):
2009-08-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Substantially reduced VM thrash in the GC heap.
1.08x faster on v8 (1.60x faster on v8-splay).
1.40x faster on bench-alloc-nonretained.
1.90x faster on bench-alloc-retained.
SunSpider says no change.
- runtime/Collector.cpp: (JSC::Heap::heapAllocate): Fixed a long-standing bug: update a few local variables unconditionally after calling collect(), since they may be used even if we don't "goto scan". (In the bug I saw, usedBlocks got out of sync with heap.usedBlocks). (JSC::Heap::sweep): Keep enough free heap space to accomodate the number of objects we'll allocate before the next GC, plus 25%, for good measure.
- runtime/Collector.h: Bumped the block size to 256k. This seems to give the best cache performance, and it prevents us from initiating lots of VM traffic to recover very small chunks of memory.
Begin re-roll-in of r47738:47740 with Windows crash fixed
- 2:26 PM Changeset in webkit [47794] by
-
- 1 edit1 add in trunk/LayoutTests
Follow-up to http://trac.webkit.org/changeset/47790. Add windows
specific results that are the same as the results next to the test,
since windows falls back on platform/mac.
Patch by Julie Parent <jparent@chromium.org> on 2009-08-26
Reviewed by Maciej Stachowiak.
- platform/win/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.
- 2:25 PM BuildingQtOnOSX created by
- Initial Page for OSX build instructions
- 1:47 PM Changeset in webkit [47793] by
-
- 6 edits in trunk
WebCore: minor style correction and include fix for notifications
https://bugs.webkit.org/show_bug.cgi?id=28745
Patch by John Gregg <johnnyg@google.com> on 2009-08-26
Reviewed by David Levin.
No change in behavior, so no tests.
- bindings/js/JSDesktopNotificationsCustom.cpp: add include of Error.h
- notifications/Notification.cpp: change enum style to InterCaps
(WebCore::Notification::Notification):
- notifications/NotificationPresenter.h:
(WebCore::NotificationPresenter::):
WebKitTools: Minor style correction and include fix for notifications
https://bugs.webkit.org/show_bug.cgi?id=28745
Patch by John Gregg <johnnyg@google.com> on 2009-08-26
Reviewed by David Levin.
- DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: change to correct EnumStyle
(DRTDesktopNotificationPresenter::checkNotificationPermission):
- 1:45 PM Changeset in webkit [47792] by
-
- 14 edits1 copy2 adds in trunk
WebKitTools: XMLHttpRequest.withCredentials=false shouldn't save cookies.
https://bugs.webkit.org/show_bug.cgi?id=28743
Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Alexey Proskuryakov.
Added the support to the layout test controller on OSX and
Windows (for CFNETWORK) to allow for changing the accept cookie
policy.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Added a bool
to track the state of accepting cookies.
(setAlwaysAcceptCookiesCallback): Standard wrapper method
to go from js to a C++ method.
(LayoutTestController::staticFunctions): Added the
setAlwaysAcceptCookies method to the js layoutTestController.
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::alwaysAcceptCookies): Returns the value.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setAlwaysAcceptCookies): Stub out method.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues): Reset the accept cookie to
its default.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setAlwaysAcceptCookies): Does the work for
OSX to change the cookie accept policy.
- DumpRenderTree/win/DumpRenderTree.cpp:
(setAlwaysAcceptCookies): Method to handle all the calls necessary
to change the accept cookie policy on Windows.
(resetDefaultsToConsistentValues): Reset the accept cookie to
its default.
- DumpRenderTree/win/DumpRenderTreeWin.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setAlwaysAcceptCookies): Stub out method.
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setAlwaysAcceptCookies): Stub out method.
LayoutTests: XMLHttpRequest.withCredentials=false shouldn't save cookies.
https://bugs.webkit.org/show_bug.cgi?id=28743
Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Alexey Proskuryakov.
Added a test to verify that XMLHttpRequest.withCredentials=false doesn't
save cookies.
- http/tests/xmlhttprequest/cross-origin-cookie-storage-expected.txt: Added.
- http/tests/xmlhttprequest/cross-origin-cookie-storage.html: Added.
- http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php: Added.
- http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added the ability
to check for a cookie by name.
- platform/gtk/Skipped: Skip the new test.
- platform/qt/Skipped: Ditto.
- 1:45 PM Changeset in webkit [47791] by
-
- 20 edits in trunk
JavaScriptCore: postMessage() spec now supports sending arrays of ports
https://bugs.webkit.org/show_bug.cgi?id=26902
Reviewed by David Levin.
Added OwnPtr to VectorTraits so we can store OwnPtrs in Vectors.
- wtf/VectorTraits.h:
WebCore: postMessage() spec now supports sending arrays of ports
https://bugs.webkit.org/show_bug.cgi?id=26902
Reviewed by David Levin.
Added support for sending multiple ports at once via postMessage(). JS bindings will be updated in an upcoming patch.
No new tests, since the new functionality is not exposed via new JS bindings yet, so the old tests suffice.
- WebCore.xcodeproj/project.pbxproj:
Mark MessagePort.h and MessagePortChannel.h as private since they are used by WebKit now.
- dom/MessageEvent.cpp:
Updated APIs to support passing MessagePortArrays.
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::messagePort):
- dom/MessageEvent.h:
(WebCore::MessageEvent::create):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::MessageEvent::ports):
- dom/MessagePort.cpp:
(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
Added new static function to extract a MessagePortChannelArray from a MessagePortArray.
(WebCore::MessagePort::entanglePorts):
Added new static function to generate a MessagePortArray (entangled ports) from a MessagePortChannelArray.
- dom/MessagePort.h:
- dom/MessagePortChannel.cpp:
EventData now contains a MessagePortChannelArray field instead of a single MessagePortChannel.
(WebCore::MessagePortChannel::EventData::create):
(WebCore::MessagePortChannel::EventData::EventData):
- dom/MessagePortChannel.h:
(WebCore::MessagePortChannel::EventData::channels):
- page/DOMWindow.cpp:
(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
- page/DOMWindow.h:
- workers/DedicatedWorkerContext.cpp:
(WebCore::DedicatedWorkerContext::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::DedicatedWorkerContext::dispatchMessage):
- workers/DedicatedWorkerContext.h:
- workers/Worker.cpp:
(WebCore::Worker::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::Worker::dispatchMessage):
- workers/Worker.h:
- workers/WorkerContextProxy.h:
- workers/WorkerMessagingProxy.cpp:
Updated WorkerObjectProxy and WorkerContextProxy API implementations to support sending multiple MessagePorts.
(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerContextTask::MessageWorkerContextTask):
(WebCore::MessageWorkerContextTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::MessageWorkerTask):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
- workers/WorkerMessagingProxy.h:
- workers/WorkerObjectProxy.h:
Updated WorkerObjectProxy and WorkerContextProxy APIs to support sending multiple MessagePorts.
- 1:26 PM Changeset in webkit [47790] by
-
- 3 edits1 add in trunk/LayoutTests
Add Mac specific results for xhr-missing-file-expection test since it
incorrectly always has statusText of "OK" due to
https://bugs.webkit.org/show_bug.cgi?id=24572 and update the results
that are next to the file to use "Not Found" since that is more correct
and matches IE, FF, Chrome.
Patch by Julie Parent <jparent@chromium.org> on 2009-08-26
Reviewed by Alex Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=28723
- http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt:
- platform/mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.
- platform/win/Skipped: Stop skipping the test.
- 1:25 PM Changeset in webkit [47789] by
-
- 2 edits in trunk/WebKitTools
2009-08-26 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed.
Remove accidentally left in clobber option.
https://bugs.webkit.org/show_bug.cgi?id=28400
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
- 1:05 PM Changeset in webkit [47788] by
-
- 3 edits11 adds in trunk/WebCore
2009-08-26 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
SocketStreamHandle interface for WebSocket API
https://bugs.webkit.org/show_bug.cgi?id=28037
Add build systems only for GNUmakefile.am and WebCore.xcodeproj.now.
Other build systems will be updated once the code is functional.
Tests will be landed once this code is complete and functional.
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/SocketStreamErrorBase.cpp: Added.
- platform/network/SocketStreamErrorBase.h: Added.
- platform/network/SocketStreamHandleBase.cpp: Added.
- platform/network/SocketStreamHandleBase.h: Added.
- platform/network/SocketStreamHandleClient.h: Added.
- platform/network/cf/SocketStreamError.h: Added.
- platform/network/cf/SocketStreamHandle.h: Added.
- platform/network/cf/SocketStreamHandleCFNet.cpp: Added.
- platform/network/soup/SocketStreamError.h: Added.
- platform/network/soup/SocketStreamHandle.h: Added.
- platform/network/soup/SocketStreamHandleSoup.cpp: Added.
- 1:04 PM Changeset in webkit [47787] by
-
- 3 edits in trunk/WebKitTools
2009-08-17 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Mark Rowe.
Add canary-style Chromium WebKit build slave to the waterfall.
https://bugs.webkit.org/show_bug.cgi?id=28400
- BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
- 12:55 PM Changeset in webkit [47786] by
-
- 2 edits in trunk/WebCore
2009-08-26 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] setTimeout does not convert non-string argument to string
https://bugs.webkit.org/show_bug.cgi?id=28739
Convert non-string argument to setTimeout to string in the V8
bindings.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
- 11:48 AM Changeset in webkit [47785] by
-
- 3 edits in trunk/WebKitSite
Upgrade WordPress to the latest version.
- blog/wp-includes/version.php:
- blog/wp-login.php:
- 11:08 AM Changeset in webkit [47784] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-26 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Remove duplicated files from file list.
- GNUmakefile.am:
- 10:40 AM Changeset in webkit [47783] by
-
- 3 edits in trunk/JavaScriptCore
More export fixes.
- 10:33 AM Changeset in webkit [47782] by
-
- 3 edits in trunk/JavaScriptCore
Hopefully fix all the exports from JSC on windows
- 10:12 AM Changeset in webkit [47781] by
-
- 6 edits in trunk/JavaScriptCore
Build fix
- 9:52 AM Changeset in webkit [47780] by
-
- 69 edits1 copy4 adds in trunk
[ES5] Implement getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=28724
Reviewed by Gavin Barraclough.
JavaScriptCore:
Implement the core runtime support for getOwnPropertyDescriptor.
This adds a virtual getOwnPropertyDescriptor method to every class
that implements getOwnPropertySlot that shadows the behaviour of
getOwnPropertySlot. The alternative would be to make getOwnPropertySlot
(or PropertySlots in general) provide property attribute information,
but quick testing showed this to be a regression.
WebCore:
Implement the WebCore side of getOwnPropertyDescriptor. This
requires a custom implementation of getOwnPropertyDescriptor
for every class with a custom implementation of getOwnPropertySlot.
The bindings generator has been updated to generate appropriate
versions of getOwnPropertyDescriptor for the general case where
a custom getOwnPropertyDescriptor is not needed. ES5 is vague
about how getOwnPropertyDescriptor should work in the context of
"host" functions with polymorphic GetOwnProperty, so it seems
okay that occasionally we "guess" what attributes -- eg. determining
whether a property is writable.
Test: fast/js/getOwnPropertyDescriptor.html
- 7:08 AM Changeset in webkit [47779] by
-
- 2 edits in trunk/WebCore
2009-08-26 Vincent Untz <vuntz@gnome.org>
Reviewed by Xan Lopez.
GObject checks for NULL (and not 0) in g_object_get, so use that
as we were already doing elsewhere to make the compiler happy.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasAudio):
- 7:06 AM Changeset in webkit [47778] by
-
- 2 edits in trunk/WebCore
2009-08-26 Alpha Lam <hclam@chromium.org>
Reviewed by David Levin.
RenderThemeMac.mm has incorrect casting for media control element.
https://bugs.webkit.org/show_bug.cgi?id=28730
MediaControlMuteButtonElement was incorrectly casted to
MediaControlPlayButtonElement. This is corrected in this patch.
No new tests because this is code cleanup and is already covered by existing
media layout tests.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaMuteButton):
- 6:56 AM Changeset in webkit [47777] by
-
- 2 edits in trunk/WebCore
2009-08-26 Robert Sesek <rsesek@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Multi-value select boxes cannot do non-contiguous selection on Mac
https://bugs.webkit.org/show_bug.cgi?id=28670
Change the condition regarding the key modifier check for non-contiguous
selection on a multi-value list from just PLATFORM(MAC) to
PLATFORM(MAC) (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)). No new tests. This patch only changes the condition on which a certain mouse
event modifier key is used.
- dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
- 6:31 AM Changeset in webkit [47776] by
-
- 4 edits in trunk/WebKit/gtk
2009-08-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=28738
Expose undo/redo functionality in WebKitWebView
Expose undo/redo functionality in WebKitWebView, keeping the
default bindings as they were.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::):
- webkit/webkitwebview.cpp: (webkit_web_view_real_undo): (webkit_web_view_real_redo): (webkit_web_view_class_init): (webkit_web_view_can_undo): (webkit_web_view_undo): (webkit_web_view_can_redo): (webkit_web_view_redo):
- webkit/webkitwebview.h:
- 12:46 AM Changeset in webkit [47775] by
-
- 7 edits in trunk/JavaScriptCore
How many copies of the parameters do you need?
https://bugs.webkit.org/show_bug.cgi?id=28701
Reviewed by Darin Adler.
The function parameters in JSC get copied a lot - and unnecessarily so.
Originally this happened due to duplicating FunctionBodyNodes on recompilation,
though the problem has been exacerbated by copying the parameters from the
original function body onto the executable, then back onto the real body that
will be generated (this happens on every function). And this is all made worse
since the data structures in question are a little ugly - C style arrays of C++
objects containing ref counts, so they need a full copy-construct (rather than
a simple memcpy).
This can all be greatly simplified by just punting the parameters off into
their own ref-counted object, and forgoing all the copying.
~no performance change, possible slight progression.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
- parser/Nodes.cpp:
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::finishParsing):
- parser/Nodes.h:
(JSC::FunctionBodyNode::parameters):
(JSC::FunctionBodyNode::parameterCount):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compile):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::paramString):
- runtime/Executable.h:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::parameterCount):
Aug 25, 2009:
- 10:49 PM Changeset in webkit [47774] by
-
- 3 edits in trunk/WebCore
2009-08-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein
r47744 causes media/video-controls-with-mutation-event-handler.html to crash
https://bugs.webkit.org/show_bug.cgi?id=28732
- rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement):
Don't call setAttribute from the construtor, any registered mutation event
listener will cause a crash.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):
Set the maxAttr here instead of in the constructor.
- 10:46 PM Changeset in webkit [47773] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Skip the new test fast/dom/Window/timer-resume-on-navigation-back.html
on gtk and qt - their DRT does not yet implement overridePreference.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 10:17 PM Changeset in webkit [47772] by
-
- 5 edits2 adds in trunk
WebCore: Timers from cached pages fire instantly rather than the after the specified timeout delay
https://bugs.webkit.org/show_bug.cgi?id=28683
Reviewed by Brady Eidson.
Test: fast/dom/Window/timer-resume-on-navigation-back.html
- history/CachedPage.cpp:
(WebCore::CachedPage::restore): Remove duplicated Frame::restore() call, since
it should be done only once in FrameLoader::open(cachedFrame)
- page/DOMTimer.cpp: Added a debug-only flag and ASSERT to catch out-of-order suspense/restore.
(WebCore::DOMTimer::DOMTimer): Ditto.
(WebCore::DOMTimer::suspend): Ditto.
(WebCore::DOMTimer::resume): Ditto.
- page/DOMTimer.h: Ditto.
LayoutTests: Timers from cached pages fire instantly rather than the specified timeout delay
https://bugs.webkit.org/show_bug.cgi?id=28683
Reviewed by Brady Eidson.
Added test to verify the fix - it uses page cache and measures the timer callback fire time.
- fast/dom/Window/timer-resume-on-navigation-back-expected.txt: Added.
- fast/dom/Window/timer-resume-on-navigation-back.html: Added.
- 10:10 PM Changeset in webkit [47771] by
-
- 2 edits1 add in trunk/WebCore
2009-08-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Setting the volume of a media element has no effect if called too early
https://bugs.webkit.org/show_bug.cgi?id=28731
- manual-tests/audio-volume.html:
Added.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate):
Don't bail if metadata hasn't been loaded, it is fine to set rate and/or
volume as soon as the movie has been created.
- 8:02 PM Changeset in webkit [47770] by
-
- 2 edits in trunk/WebCore
DocumentThreadableLoader::getShouldUseCredentialStorage should allow for synchronous callbacks from SubresourceLoader::create.
https://bugs.webkit.org/show_bug.cgi?id=28728
Patch by David Levin <levin@chromium.org> on 2009-08-25
Reviewed by Maciej Stachowiak.
Test: This code path is exercised while running xhr layout tests in chromium.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): When called
back synchronously, the loader is 0, so the assert is changed to allow for that.
(WebCore::DocumentThreadableLoader::loadRequest): Synchronous callbacks may be
done before SubresourceLoader::create finishes, so ensure that any previous loader
-- from a preflight request -- is cleared before calling SubresourceLoader::create.
- 6:06 PM Changeset in webkit [47769] by
-
- 2 edits in trunk/WebKitLibraries
Rubber stamped by Steve Falkenburg.
debug_wincairo.vsprops was linking against wrong C runtime.
- win/tools/vsprops/debug_wincairo.vsprops: Link to correct C runtime (as in the standard 'debug.vsprops' file.)
- 5:57 PM Changeset in webkit [47768] by
-
- 2 edits in trunk/WebCore
Stop installing IDL files in to the framework.
- WebCore.xcodeproj/project.pbxproj:
- 5:51 PM Changeset in webkit [47767] by
-
- 6 edits4 adds in trunk
2009-08-25 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Support for HTMLInputElement::list and HTMLInputElement::selectedOption.
https://bugs.webkit.org/show_bug.cgi?id=27756
Tests: fast/forms/input-list.html
fast/forms/input-selectedoption.html
- html/HTMLAttributeNames.in:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::list): (WebCore::HTMLInputElement::selectedOption):
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl:
2009-08-25 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Support for HTMLInputElement::list and HTMLInputElement::selectedOption.
https://bugs.webkit.org/show_bug.cgi?id=27756
- fast/forms/input-list-expected.txt: Added.
- fast/forms/input-list.html: Added.
- fast/forms/input-selectedoption-expected.txt: Added.
- fast/forms/input-selectedoption.html: Added.
- 5:42 PM Changeset in webkit [47766] by
-
- 11 edits1 add in branches/one-view
WebCore: Some work on one-view WebKit.
Patch by Darin Adler <Darin Adler> on 2009-08-25
Reviewed by David Hyatt.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMousePressEventToSubframe): Send the event to the
frame -- don't involve the NSView objects.
(WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.
(WebCore::EventHandler::passMouseReleaseEventToSubframe): Ditto.
WebKit: Some work on one-view WebKit.
Patch by Darin Adler <Darin Adler> on 2009-08-25
Reviewed by David Hyatt.
- WebKit.xcodeproj/project.pbxproj: Added WebView/WebViewEventHandling.mm.
WebKit/mac: Some work on one-view WebKit.
Patch by Darin Adler <Darin Adler> on 2009-08-25
Reviewed by David Hyatt.
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag): Change code to use WebView instead of
WebHTMLView.
- WebView/WebHTMLView.mm:
(-[WebHTMLView rightMouseUp:]): ASSERT_NOT_REACHED.
(-[WebHTMLView menuForEvent:]): Ditto.
(-[WebHTMLView mouseDown:]): Ditto.
(-[WebHTMLView mouseDragged:]): Ditto.
(-[WebHTMLView mouseUp:]): Ditto.
(-[WebHTMLView otherMouseDown:]): Ditto.
(-[WebHTMLView otherMouseDragged:]): Ditto.
(-[WebHTMLView otherMouseUp:]): Ditto.
(-[WebHTMLView _mouseDownEvent]): Ditto.
- WebView/WebView.mm:
(-[WebView _close]): Call _closingEventHandling.
(-[WebView viewWillMoveToWindow:]): Added calls to
_removeMouseMovedObserverUnconditionally and _addMouseMovedObserver.
(-[WebView _windowDidBecomeKey:]): Added non-main-thread handling,
and _addMouseMovedObserver
(-[WebView _windowDidResignKey:]): Added non-main-thread handling,
completion controller code, and _removeMouseMovedObserver.
(-[WebView _windowWillOrderOnScreen:]): Added non-main-thread handling.
(-[WebView _windowWillClose:]): Ditto.
- WebView/WebViewData.h: Added toolTip, lastToolTipTag, trackingRectOwner,
trakcingRectUserData, observingMouseMovedNotifications, and exposeInputContext.
- WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]): Release a few more things. Sorted the list
of things to release with the sort tool.
- WebView/WebViewEventHandling.mm: Added. Moved a lot of code in here.
- WebView/WebViewInternal.h: Moved items to the WebViewEventHandling
category.
- 5:33 PM Changeset in webkit [47765] by
-
- 1 copy in branches/one-view
Create a branch for some one-view WebKit work.
- 4:24 PM Changeset in webkit [47764] by
-
- 3 edits in trunk/WebKitTools
2009-08-25 Cameron McCormack <cam@mcc.id.au>
Reviewed by Darin Adler.
make-script-test-wrappers should be executable
https://bugs.webkit.org/show_bug.cgi?id=28669
Make make-script-test-wrappers and update-sources-list.py both be
executable.
- Scripts/update-sources-list.py:
- Scripts/make-script-test-wrappers:
- 4:07 PM Changeset in webkit [47763] by
-
- 44 edits12 adds in trunk
2009-08-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible (edit)
https://bugs.webkit.org/show_bug.cgi?id=28081
Test: accessibility/media-element.html
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
Add AccessibilityMediaControls.cpp/.h
- accessibility/AXObjectCache.cpp:
- accessibility/AXObjectCache.h: (WebCore::AXObjectCache::getOrCreate):
Create AccessibilityMediaControl. Update Copyright
- accessibility/AccessibilityMediaControls.cpp:
- accessibility/AccessibilityMediaControls.h:
Added.
- accessibility/AccessibilityObject.cpp:
- accessibility/AccessibilityObject.h:
Add isMediaTimeline. Update Copyright.
- accessibility/AccessibilitySlider.h:
Make constructor protected instead of private so AccessibilityMediaTimeline can
call it.
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
Add NSAccessibilityValueDescriptionAttribute to range attributes.
(-[AccessibilityObjectWrapper subrole]):
Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.
- dom/Node.h:
add isMediaControlElement.
- page/mac/WebCoreViewFactory.h:
- platform/LocalizedStrings.h:
- platform/mac/LocalizedStringsMac.mm: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
New, return localized media controller strings.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):
Move inside of "#if ENABLE(VIDEO)"
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):
- rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::MediaControlElement):
Initialize m_displayType.
(WebCore::MediaControlElement::MediaControlElement):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
Fix style.
(WebCore::MediaControlInputElement::MediaControlInputElement):
Set m_displayType based on pseudo style ID.
(WebCore::MediaControlInputElement::MediaControlInputElement):
rename local "o" to "object".
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
Update for MediaControlInputElement constructor change.
(WebCore::MediaControlTimeDisplayElement::formatTime):
New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.
(WebCore::MediaControlTimeDisplayElement::setCurrentValue):
New, set text to current time.
- rendering/MediaControlElements.h:
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
Create controls in tab order.
(WebCore::RenderMedia::formatTime):
Moved to MediaControlTimeDisplayElement::formatTime.
(WebCore::RenderMedia::updateTimeDisplay):
Call MediaControlTimeDisplayElement::setCurrentValue.
- rendering/RenderMedia.h:
2009-08-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081
Add localized strings for media controller accessiblility.
- English.lproj/Localizable.strings:
2009-08-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaControlElementString:]): (-[WebViewFactory localizedMediaControlElementHelpText:]): (-[WebViewFactory localizedMediaTimeDescription:]):
New.
2009-08-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081
- WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
New.
2009-08-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081
- accessibility/media-element.html: Added.
- platform/mac/accessibility/media-element-expected.txt: Added.
- media/video-controls-visible-audio-only.html:
- platform/mac-leopard/accessibility/media-element-expected.txt: Added.
- platform/mac-leopard/media/controls-drag-timebar-expected.txt: Added.
- platform/mac-leopard/media/controls-strict-expected.txt: Added.
- platform/mac-leopard/media/video-controls-rendering-expected.txt: Added.
- platform/mac-leopard/media/video-display-toggle-expected.txt: Added.
- platform/win/media/controls-strict-expected.txt: Added.
- platform/win/media/video-controls-rendering-expected.txt: Added.
- platform/win/media/video-display-toggle-expected.txt: Added.
Added.
- platform/mac-leopard/media/audio-controls-rendering-expected.txt:
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/video-zoom-controls-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.txt:
- platform/mac/media/video-zoom-controls-expected.txt:
- platform/win/media/audio-controls-rendering-expected.txt:
- platform/win/media/controls-after-reload-expected.txt:
- platform/win/media/controls-drag-timebar-expected.txt:
- platform/win/media/controls-styling-expected.txt:
Update for controller element tab order change.
- platform/gtk/Skipped:
- platform/win/Skipped:
Skip new test.
- 4:03 PM Changeset in webkit [47762] by
-
- 6 edits in trunk
WebKit/win: Build fix for Windows.
Revise Debug_Cairo build target to build testapi, jsc, WinLauncher,
DumpRenderTree, and TestNetscapeAPI using WinCairo debug build
settings so they link against the proper libraries.
- WebKit.vcproj/WebKit.sln:
WebKitTools: Build fix
Revise Debug_Cairo targets to point inherit from the
debug_wincairo.vsprops property sheet so that they link
against the proper libraries in Debug build.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- WinLauncher/WinLauncher.vcproj:
- 3:59 PM Changeset in webkit [47761] by
-
- 1 edit in trunk/WebKitLibraries/win/tools/scripts/PRODUCTVERSION
Versioning.
- 3:54 PM Changeset in webkit [47760] by
-
- 3 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_CFLite target that inherits from the debug_wincairo property sheet and therefore links to the proper debug library.
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_CFLite target that inherits from the debug_wincairo property sheet and therefore links to the proper debug library.
Reviewed by NOBODY (Buildfix).
- 3:43 PM Changeset in webkit [47759] by
-
- 3 edits in trunk/JavaScriptCore
Rolled out r44739. Causes crash on Windows.
- 3:38 PM Changeset in webkit [47758] by
-
- 3 edits in trunk/WebCore
[V8] Fix Canvas layout test failures in Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=28720
Reviewed by David Levin.
The previous fix r47757 does not handle the V8 object conversion correctly.
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- 2:04 PM Changeset in webkit [47757] by
-
- 7 edits in trunk/WebCore
[V8] Fix compiling errors in Chromium build caused by Canvas3D changes from r47752.
https://bugs.webkit.org/show_bug.cgi?id=28717
Reviewed by David Levin.
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- 1:40 PM Changeset in webkit [47756] by
-
- 4 edits in trunk/WebCore
2009-08-25 Alpha Lam <hclam@chromium.org>
Reviewed by David Levin.
[chromium] Implement media volume slider for chromium
https://bugs.webkit.org/show_bug.cgi?id=28715
Provided the implementation of the volume slider and its container for
chromium port. With this change there will be a usable volume control
slider for chromium theme.
No new tests since this is covered by existing media layout tests.
- css/mediaControlsChromium.css: CSS style for the volume slider.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::mediaSliderThumbImage): Returns the image for slider thumb. (WebCore::mediaVolumeSliderThumbImage): Returns the image for volume slider thumb. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Paints the track with one vertical white line. (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Adjusts thumb sizes according to the images. (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Paints slider thumb image. (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Paints volume slider thumb image.
- 12:56 PM Changeset in webkit [47755] by
-
- 1 edit in trunk/WebCore/html/HTMLCanvasElement.cpp
Fixed a build problem on Tiger
- 12:45 PM Changeset in webkit [47754] by
-
- 1 edit2 adds in trunk/WebCore
Missed checking in 2 Canvas3D files
https://bugs.webkit.org/show_bug.cgi?id=28018
- 12:31 PM Changeset in webkit [47753] by
-
- 3 edits3 adds in trunk
2009-08-25 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
[V8] Exception from JavaScript propagates to main script
https://bugs.webkit.org/show_bug.cgi?id=26433
Test that both compile time and runtime exceptions thrown in
javascript URLs are isolated from the main script.
- fast/dom/javascript-url-exception-isolation-expected.txt: Added.
- fast/dom/javascript-url-exception-isolation.html: Added.
- fast/dom/resources/javascript-url-exception-isolation.js: Added.
2009-08-25 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
[V8] Exception from JavaScript propagates to main script
https://bugs.webkit.org/show_bug.cgi?id=26433
Make sure that exceptions thrown both at compile time and at
runtime in javascript URLs are isolated from the main script.
Test: fast/dom/javascript-url-exception-isolation.html
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
- 11:45 AM Changeset in webkit [47752] by
-
- 27 edits in trunk
Added all new Canvas3D files to the build
https://bugs.webkit.org/show_bug.cgi?id=28018
This also hooks up CanvasRenderingContext as the common base class for
CanvasRenderingContext2D and CanvasRenderingContext3D. And it adds a bit
of logic throughout to support the new CanvasRenderingContext3D object.
But nothing is hooked up yet.
- 11:30 AM Changeset in webkit [47751] by
-
- 6 edits in trunk
PLATFORM(CFNETWORK) should be USE(CFNETWORK).
https://bugs.webkit.org/show_bug.cgi?id=28713
Patch by David Levin <levin@chromium.org> on 2009-08-25
Reviewed by Adam Roben.
- wtf/Platform.h: Added a #define to catch this issue in the
future. The define would generate an error on gcc without the
space in the expansion, but Visual C++ needs the space to cause an error.
WebKit/win:
Also, moved the #if header section after the other #includes.
- WebError.cpp:
(WebError::localizedDescription):
WebKitTools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(main):
- 10:14 AM Changeset in webkit [47750] by
-
- 6 edits1 add in trunk
JavaScriptCore: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.
Reviewed by Steve Falkenburg.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modify Cairo debug build to inherit from new debug_cairo property sheet.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Modify to look for debug CFLite when in debug build.
WebKit/win: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.
Reviewed by Steve Falkenburg.
- WebKit.vcproj/WebKit.vcproj: Modify Debug_Cairo target to inherit from new debug_wincairo property sheet, instead of the current debug sheet.
WebKitLibraries: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.
Reviewed by Steve Falkenburg.
- win/tools/vsprops/debug_wincairo.vsprops: Added.
- 10:09 AM Changeset in webkit [47749] by
-
- 4 edits in trunk/WebCore
REGRESSION (r47630): fast/repaint/background-generated.html is failing
https://bugs.webkit.org/show_bug.cgi?id=28704
Reviewed by Anders Carlsson.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize): Handle SizeNone.
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::FillLayer): Initialize the size type to SizeNone.
- rendering/style/FillLayer.h:
(WebCore::FillSize::FillSize): Changed assignment to initialization and
removed redundant assignment to size.
- 9:28 AM Changeset in webkit [47748] by
-
- 2 edits in trunk/WebCore
2009-08-25 Yusuke Sato <yusukes@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Complex text doesn't show up with text stroking
https://bugs.webkit.org/show_bug.cgi?id=28707
Skip the NULL check of m_hdc if Windows GDI is not in use.
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawComplexText):
- 6:14 AM Changeset in webkit [47747] by
-
- 8 edits in trunk/LayoutTests
[Qt] Update outdated metrics in css1/font_properties. All tests pass.
Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-08-25
Reviewed by Ariya Hidayat.
- platform/qt/Skipped:
- platform/qt/css1/font_properties/font-expected.txt:
- platform/qt/css1/font_properties/font_family-expected.txt:
- platform/qt/css1/font_properties/font_size-expected.txt:
- platform/qt/css1/font_properties/font_style-expected.txt:
- platform/qt/css1/font_properties/font_variant-expected.txt:
- platform/qt/css1/font_properties/font_weight-expected.txt:
- 6:12 AM Changeset in webkit [47746] by
-
- 4 edits in trunk/WebKit/qt
2009-08-25 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Ariya Hidayat.
Bug 28708 - Make possible to better use ResourceError in FrameLoaderClientQt class.
- Api/qwebframe.cpp: (QWebFrame::requestedUrl):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): (WebCore::FrameLoaderClientQt::postProgressFinishedNotification): (WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoad):
- WebCoreSupport/FrameLoaderClientQt.h:
- 6:08 AM Changeset in webkit [47745] by
-
- 8 edits12 adds in trunk/LayoutTests
[Qt] Update outdated font metrics and add expected files for new tests.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-08-25
Reviewed by Ariya Hidayat.
- platform/qt/Skipped:
- platform/qt/fast/backgrounds/001-expected.txt:
- platform/qt/fast/backgrounds/animated-gif-as-background-expected.txt: Added.
- platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt: Added.
- platform/qt/fast/backgrounds/animated-svg-as-mask-expected.txt: Added.
- platform/qt/fast/backgrounds/background-clip-text-expected.txt: Added.
- platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
- platform/qt/fast/backgrounds/background-origin-root-element-expected.txt: Added.
- platform/qt/fast/backgrounds/background-position-1-expected.txt: Added.
- platform/qt/fast/backgrounds/background-position-rounding-expected.txt: Added.
- platform/qt/fast/backgrounds/mask-composite-expected.txt: Added.
- platform/qt/fast/backgrounds/opacity-on-document-element-expected.txt: Added.
- platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt: Added.
- platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
- platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
- platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
- platform/qt/fast/backgrounds/size/zero-expected.txt: Added.
- platform/qt/fast/backgrounds/solid-color-context-restore-expected.txt:
- platform/qt/fast/backgrounds/svg-as-mask-expected.txt: Added.
- 5:04 AM Changeset in webkit [47744] by
-
- 18 edits in trunk/WebCore
2009-08-25 Alpha Lam <hclam@chromium.org>
Reviewed by David Levin.
Media controls panel does not have a volume control slider
https://bugs.webkit.org/show_bug.cgi?id=28241
Introduced "-webkit-media-controls-volume-slider",
"-webkit-media-controls-volume-slider-container" and the supporting
implementation. Also added appearances of "media-volume-slider" and
"media-volume-slider-container".
The implementation of the controls are in WebCore::MediaControlElements.
Logic to trigger the display of the volume controls are in WebCore::RenderMedia.
No new tests since this change doesn't have theme implementation and the
volume slider is disabled by default.
- accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation): Marks that volume slider is vertical.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added corresponding CSS values.
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): ditto.
- css/CSSSelector.h: (WebCore::CSSSelector::): ditto.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
- css/CSSValueKeywords.in: ditto.
- css/mediaControls.css: Makes the volume slider disabled by default.
- platform/ThemeTypes.h: Defines theme parts for volume slider and its container. (WebCore::):
- rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): (WebCore::MediaControlVolumeSliderContainerElement::styleForElement): Adjust the CSS values for "display", "postion", "left" and "top" according to member variables. (WebCore::MediaControlVolumeSliderContainerElement::setVisible): Affects the "display" CSS value. (WebCore::MediaControlVolumeSliderContainerElement::setPosition): Affects the "left" and "top" CSS values. (WebCore::MediaControlVolumeSliderContainerElement::hitTest): Hit testing this element. (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Modifies the volume using the slider value, allows dragging.
- rendering/MediaControlElements.h: (WebCore::): Added definition for MediaControlVolumeSliderElement and MediaControlVolumeSliderContainerElement. (WebCore::MediaControlVolumeSliderContainerElement::isVisible): Inline getter.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): Updates styles for volume container and volume slider. (WebCore::RenderMedia::createVolumeSliderContainer): Creates volume slider container and attach to panel. (WebCore::RenderMedia::createVolumeSlider): Creates volume slider and attach to volume slider container. (WebCore::RenderMedia::updateControls): Updates volume container and volume slider. (WebCore::RenderMedia::updateVolumeSliderContainer): Sets the visibility and position of volume slider container and its child. (WebCore::RenderMedia::forwardEvent): Hit testing the volume slider container and volume slider to toggle the visibility and forward events to slider.
- rendering/RenderMedia.h: Added definition for RenderMedia::updateVolumeSliderContainer().
- rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart): Not implemented.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Makes volume slider vertical. (WebCore::RenderSlider::thumbRect): ditto. (WebCore::RenderSlider::mouseEventIsInThumb): ditto. (WebCore::RenderSlider::setValueForPosition): ditto. (WebCore::RenderSlider::positionForOffset): ditto. (WebCore::RenderSlider::currentPosition): ditto. (WebCore::RenderSlider::trackSize): ditto.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): Adjust style for volume slider thumb. (WebCore::RenderTheme::paint): Paints volume control parts using theme.
- rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaVolumeSliderContainer): Naive implementation to be overridden. (WebCore::RenderTheme::paintMediaVolumeSliderTrack): ditto. (WebCore::RenderTheme::paintMediaVolumeSliderThumb): ditto.
- rendering/style/RenderStyleConstants.h: (WebCore::): Constants for volume control parts.
- 4:36 AM Changeset in webkit [47743] by
-
- 5 edits in trunk
[Qt/Mac] Use CONFIG+=build_all only when building libraries
Reviewed by Ariya Hidayat.
If no configuration is specified when building WebKit we pass the
debug_and_release option to QMake which results in Makefiles for
both configurations being generated.
Previously we built both of these configurations by default, for
all targets (both the QtWebKit framework/dyldlib and the various
executables such as QtLauncher and tests). This makes sense for
the libraries, which get the _debug suffix and can be loaded on
demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
ended up building the same executable twice.
We now only build one instance of each executable, and since this
is a developer build we build the debug-version. Passing either
--debug or --release to build-webkit will override this, and
even in the default case the release version can still be built
by running 'make release' in the the build directory of each
target.
- WebCore.pro:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- Scripts/webkitdirs.pm:
- 12:18 AM Changeset in webkit [47742] by
-
- 2 edits in trunk/WebCore
2009-08-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=28690
Build failure in webkitgtk+-1.1.3
Do not use deprecated function to unref a pixbuf.
- platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor):
Aug 24, 2009:
- 11:53 PM Changeset in webkit [47741] by
-
- 8 edits2 adds in trunk
2009-08-24 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Barth.
Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
<https://bugs.webkit.org/show_bug.cgi?id=27827>.
Because of the lack of mappings from GDK key-codes to WebKit key-codes,
Chromium cannot send valid key-codes to JavaScript when a user types
function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
To write layout tests for this issue, added mappings from function-key
names to platform-specific key-codes to EventSendingController objects
so that eventSender.keyDown() can send function-key events without using
platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
is only for Mac. So this change adds this new test to Skipped tests for other
platforms to prevent this change from crashing the build trees.)
- fast/events/keydown-function-keys-expected.txt: Added.
- fast/events/keydown-function-keys.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2009-08-24 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Barth.
Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
<https://bugs.webkit.org/show_bug.cgi?id=27827>.
Because of the lack of mappings from GDK key-codes to WebKit key-codes,
Chromium cannot send valid key-codes to JavaScript when a user types
function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
To write layout tests for this issue, added mappings from function-key
names to platform-specific key-codes to EventSendingController objects
so that eventSender.keyDown() can send function-key events without using
platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
is only for Mac. So this change adds this new test to Skipped tests for other
platforms to prevent this change from crashing the build trees.)
Test: fast/events/keydown-function-keys.html
- platform/chromium/KeyCodeConversionGtk.cpp: Add mappings from GDK key-codes to WebKit key-code for function keys. (WebCore::windowsKeyCodeForKeyEvent):
2009-08-24 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Barth.
Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
<https://bugs.webkit.org/show_bug.cgi?id=27827>.
Because of the lack of mappings from GDK key-codes to WebKit key-codes,
Chromium cannot send valid key-codes to JavaScript when a user types
function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
To write layout tests for this issue, added mappings from function-key
names to platform-specific key-codes to EventSendingController objects
so that eventSender.keyDown() can send function-key events without using
platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
is only for Mac. So this change adds this new test to Skipped tests for other
platforms to prevent this change from crashing the build trees.)
- DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]):
- 9:23 PM Changeset in webkit [47740] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: start out with a 32-bit value to avoid a shortening warning.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-24
- runtime/Collector.cpp:
(JSC::Heap::sweep):
- 9:09 PM Changeset in webkit [47739] by
-
- 3 edits in trunk/JavaScriptCore
Substantially reduced VM thrash in the GC heap.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-24
Reviewed by Oliver Hunt.
1.08x faster on v8 (1.60x faster on v8-splay).
1.40x faster on bench-alloc-nonretained.
1.90x faster on bench-alloc-retained.
SunSpider says no change.
- runtime/Collector.cpp:
(JSC::Heap::heapAllocate): Fixed a long-standing bug: update a few local
variables unconditionally after calling collect(), since they may be used
even if we don't "goto scan". (In the bug I saw, usedBlocks got out of
sync with heap.usedBlocks).
(JSC::Heap::sweep): Keep enough free heap space to accomodate
the number of objects we'll allocate before the next GC, plus 25%, for
good measure.
- runtime/Collector.h: Bumped the block size to 256k. This seems to give
the best cache performance, and it prevents us from initiating lots of
VM traffic to recover very small chunks of memory.
- 7:53 PM Changeset in webkit [47738] by
-
- 19 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=28691
Do not retain ScopeNodes outside of parsing
Reviewed by Oliver Adler & Darin Hunt.
There is now no need for these to exist outside of parsing - their use in the runtime is replaced by Executable types.
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
(JSC::evaluateInGlobalCallFrame):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- parser/Nodes.cpp:
(JSC::ScopeNodeData::ScopeNodeData):
(JSC::ProgramNode::create):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::create):
- parser/Nodes.h:
(JSC::ScopeNode::adoptData):
(JSC::FunctionBodyNode::parameterCount):
- parser/Parser.cpp:
- parser/Parser.h:
(JSC::Parser::arena):
(JSC::Parser::Parser):
(JSC::Parser::parse):
- runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
(JSC::arrayProtoFuncSort):
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compile):
(JSC::FunctionExecutable::compile):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::copyParameters):
(JSC::FunctionExecutable::paramString):
- runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::sourceID):
(JSC::ScriptExecutable::sourceURL):
(JSC::ScriptExecutable::lineNo):
(JSC::ScriptExecutable::lastLine):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::recordParse):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::make):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::jitCode):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::numericCompareFunction):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
- 5:50 PM Changeset in webkit [47737] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28698
Avoid unnecessary transformations for the window resizer rect.
Reviewed by Simon Fraser.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::setFrameRect):
- 5:42 PM Changeset in webkit [47736] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
<rdar://problem/7161900> REGRESSION: 100 MB membuster leak on windows due to 47391
(DNS prefetching support)
- platform/network/cf/DNSCFNet.cpp: (WebCore::prefetchDNS): Use a run loop from secondary thread on Windows, because there isn't one on main one.
- 5:09 PM Changeset in webkit [47735] by
-
- 3 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=28374
Cross-scheme requests should not be blocked by appcache rules
Test: http/tests/appcache/different-scheme.html
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache): Resources with different schemes can never be loaded from appcache.
- 5:03 PM Changeset in webkit [47734] by
-
- 6 edits2 adds in trunk
Reviewed by Darin Adler and Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=28688
REGRESSION(r24994): Cannot create a frame with a javascript URL
Test: http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
- bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL):
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL):
- bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Omit the checks if there is no document in frame yet.
- 3:58 PM Changeset in webkit [47733] by
-
- 2 edits in trunk/LayoutTests
2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Skip the correct test (media/video-currentTime-set.html, not
media/video-currentTime-set2.html).
- platform/gtk/Skipped:
- 3:47 PM Changeset in webkit [47732] by
-
- 2 edits in trunk/LayoutTests
2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Skip 3 new tests, and reenable some of the media tests, now that
the bot it fixed to handle the fact that it doesn't have a sound
card.
- platform/gtk/Skipped:
- 2:56 PM Changeset in webkit [47731] by
-
- 2 edits in trunk/LayoutTests
2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Skip again tests that we enabled, since they are
failing on the bot. The tests do pass, but there is an environment
configuration problem with GStreamer on the bot (possibly related
to the fact that it has no sound card).
- platform/gtk/Skipped:
- 2:37 PM Changeset in webkit [47730] by
-
- 2 edits in trunk/JavaScriptCore
- runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::put): Landed revised version I had tested but forgot
to land. Leave out the branch, since we don't need one.
- 2:21 PM Changeset in webkit [47729] by
-
- 2 edits in trunk/WebCore
2009-08-24 Nate Chapin <Nate Chapin>
Reviewed by Eric Seidel.
Fix crash in fast/css/rem-dynamic-scaling.html due to a freed
RenderStyle being accessed.
- dom/Element.cpp: (WebCore::Element::recalcStyle): Make currentStyle a RefPtr.
- 2:08 PM Changeset in webkit [47728] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Mark Rowe.
Skip loader/go-back-to-different-window-size.html for qt and gtk.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 2:05 PM Changeset in webkit [47727] by
-
- 3 edits in trunk/JavaScriptCore
Array index miss case creates a string every time
https://bugs.webkit.org/show_bug.cgi?id=28664
Patch by Darin Adler <Darin Adler> on 2009-08-24
Reviewed by Geoff Garen.
SunSpider test results I saw:
0.5% faster overall
1% faster on crypto-aes
20% faster on crypto-md5
13% faster on crypto-sha1
- runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype): Initialize m_hasNoPropertiesWithUInt32Names
to true.
(JSC::ObjectPrototype::put): Clearly m_hasNoPropertiesWithUInt32Names if the new
property has a name that is the string form of a UInt32.
(JSC::ObjectPrototype::getOwnPropertySlot): Don't call JSObject::getOwnPropertySlot
if m_hasNoPropertiesWithUInt32Names is true, and it is highly likely to be true.
- runtime/ObjectPrototype.h: Added declarations for the above.
- 1:45 PM Changeset in webkit [47726] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5743105> Long freezing during loading and selecting text
of a large table
https://bugs.webkit.org/show_bug.cgi?id=14918
Reviewed by Simon Fraser.
- rendering/RenderView.cpp:
(WebCore::RenderView::setSelection): Added calls to
beginDeferredRepaints() and endDeferredRepaints() around the
invalidation of the selection, in order to better coalesce multiple
invalid rectangles.
- 1:26 PM Changeset in webkit [47725] by
-
- 5 edits in trunk/WebCore
2009-08-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Simplify findTreeElement code, get rid of potential infinite loop.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
- inspector/front-end/treeoutline.js: (TreeOutline.prototype.getCachedTreeElement): (TreeOutline.prototype.findTreeElement):
- inspector/front-end/utilities.js: (isAncestorNode): ():
- 1:20 PM Changeset in webkit [47724] by
-
- 2 edits in trunk/WebCore
2009-08-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Do expand local scope when hitting the break
- inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
- 1:16 PM Changeset in webkit [47723] by
-
- 1 edit3 adds in trunk/LayoutTests
Reviewed by Brady Eidson.
Add test for https://bugs.webkit.org/show_bug.cgi?id=28659.
Cached page should be formatted according to the current window size, not the cached frame's size.
- loader: Added.
- loader/go-back-to-different-window-size-expected.txt: Added.
- loader/go-back-to-different-window-size.html: Added.
- 12:55 PM Changeset in webkit [47722] by
-
- 2 edits in trunk/WebCore
Reviewed by Steve Falkenburg.
Make sure we use the current FrameView's frame rect when
going back to a cached page.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::open):
- 12:10 PM Changeset in webkit [47721] by
-
- 2 edits3 adds in trunk/LayoutTests
2009-08-24 Eric Seidel <eric@webkit.org>
No review, just updating results.
Support placeholder on textarea
https://bugs.webkit.org/show_bug.cgi?id=21248
Update expected test results form windows bot.
- platform/win/fast/forms/basic-textareas-expected.txt:
- platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
- platform/win/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
- platform/win/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
- 11:35 AM Changeset in webkit [47720] by
-
- 3 edits3 adds in trunk
2009-08-24 Cameron McCormack <cam@mcc.id.au>
Reviewed by Darin Adler.
Modifying <text rotate=""> doesn't clear the corresponding SVGAnimatedNumberList
https://bugs.webkit.org/show_bug.cgi?id=28673
- svg/dom/resources/text-rotate-live.js: Added. (getRotate): (getAndSetRotate):
- svg/dom/text-rotate-live-expected.txt: Added.
- svg/dom/text-rotate-live.html: Added.
2009-08-24 Cameron McCormack <cam@mcc.id.au>
Reviewed by Darin Adler.
Modifying <text rotate=""> doesn't clear the corresponding SVGAnimatedNumberList
https://bugs.webkit.org/show_bug.cgi?id=28673
Test: svg/dom/text-rotate-live.html
- svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse): Clear the list before adding the parsed numbers.
- 11:07 AM Changeset in webkit [47719] by
-
- 4 edits in trunk
2009-08-24 Simon Fraser <Simon Fraser>
Reviewed by NOBODY (build fix)
Turn off ENABLE_3D_CANVAS in the xconfig files.
- Configurations/FeatureDefines.xcconfig:
- 11:02 AM Changeset in webkit [47718] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.13
Tagging WebKitGTK+ 1.1.13
- 9:40 AM Changeset in webkit [47717] by
-
- 3 edits in trunk/WebCore
2009-08-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Only expand local scope when hitting the break
- inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
- 9:26 AM Changeset in webkit [47716] by
-
- 6 edits in trunk
WebCore:
background-size fails to parse if a single length/percentage/auto is followed by a comma
https://bugs.webkit.org/show_bug.cgi?id=28674
Reviewed by Simon Fraser.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFillSize): Added an allowComma parameter,
which is set to false when this method consumes a comma. Moved
handling of 'contain' and 'cover' from parseFillProperty into this
method.
(WebCore::CSSParser::parseFillProperty): Set allowComma to true before
processing the next value, and pass allowComma to parseFillSize.
- css/CSSParser.h:
LayoutTests:
background-size fails to parse if a single length/percentage/auto is followed by a comma
https://bugs.webkit.org/show_bug.cgi?id=28674
Reviewed by Simon Fraser.
- fast/backgrounds/size/parsing-background-size-values-expected.txt:
- fast/backgrounds/size/resources/parsing-background-size-values.js:
- 9:02 AM Changeset in webkit [47715] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Fix a typo in my distcheck build fix.
- GNUmakefile.am:
- 8:41 AM Changeset in webkit [47714] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
News about the 1.1.13 release.
- NEWS:
- 8:28 AM Changeset in webkit [47713] by
-
- 5 edits in trunk
2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Bump package and so versions for 1.1.13 release.
- configure.ac:
WebKit/gtk
2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Add new symbols, and an index of new symbols for the 1.1.13
release.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 7:55 AM Changeset in webkit [47712] by
-
- 2 edits3 adds in trunk/WebCore
2009-08-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] Support for cursors that are images
https://bugs.webkit.org/show_bug.cgi?id=28346
Added support for cursors which are images for CursorGtk. Added
a manual test for this.
- manual-tests/gtk/cursor-image.html: Added.
- manual-tests/gtk/resources/redcursor.cur: Added.
- platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor):
- 7:48 AM Changeset in webkit [47711] by
-
- 1 edit6 adds in trunk/LayoutTests
Unreviewed. Add missing files from former commit 47709.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-08-24
- platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Added.
- platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Added.
- platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Added.
- platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Added.
- platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Added.
- platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Added.
- 7:30 AM Changeset in webkit [47710] by
-
- 6 edits in trunk
WebCore:
2009-08-24 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] Integrate GStreamer video with the graphics backend
https://bugs.webkit.org/show_bug.cgi?id=16356
Improves GStreamer backend implementation of MediaPlayerPrivate class.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateErrorCallback): Send proper MediaPlayer error for different GStreamer errors to MediaPlayerPrivate. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Move static initialization boolean to a better place. (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): Return if error occured, do not consider the source as stream if duration query failed. (WebCore::MediaPlayerPrivate::currentTime): Return if error occured, use an early return. (WebCore::MediaPlayerPrivate::seek): Return if error occured. (WebCore::MediaPlayerPrivate::setEndTime): Remove implementation since this function doesn't seem to be used anywhere in WebCore. (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::setRate): Seek to current time when rate is set. (WebCore::MediaPlayerPrivate::maxTimeBuffered): Return if error occured. (WebCore::MediaPlayerPrivate::maxTimeSeekable): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytesKnown): (WebCore::MediaPlayerPrivate::totalBytes): Ditto. (WebCore::MediaPlayerPrivate::updateStates): Return if error occured, update after seek ended with a successful change (WebCore::MediaPlayerPrivate::didEnd): Do not pause the playbin when end is reached. (WebCore::MediaPlayerPrivate::loadingFailed): Update network state with the given error. (WebCore::mimeTypeCache): Gather supported mime types from GStreamer. (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivate::supportsFullscreen): First step towards fullscreen support. (WebCore::MediaPlayerPrivate::createGSTPlayBin): Use playbin2 instead of playbin, do not set playbin's audio sink.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func): Use C++ casts, decrease reference count of async queue at the end of the idle function. (webkit_video_sink_render): Increase reference count of async queue. (webkit_video_sink_stop): Remove any idle functions with the sink as data.
LayoutTests:
2009-08-24 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] Integrate GStreamer video with the graphics backend
https://bugs.webkit.org/show_bug.cgi?id=16356
Enable media tests that now pass.
- platform/gtk/Skipped:
- 7:26 AM Changeset in webkit [47709] by
-
- 2 edits in trunk/LayoutTests
[Qt] Add results with updated font metrics for passing tests added in
r28637 and remove them from Skipped.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-08-24
Reviewed by Ariya Hidayat.
- platform/qt/Skipped:
- platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Added.
- platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Added.
- platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Added.
- platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Added.
- platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Added.
- platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Added.
- 6:38 AM Changeset in webkit [47708] by
-
- 2 edits6 adds in trunk/WebCore
Remaining new files for Canvas3D
https://bugs.webkit.org/show_bug.cgi?id=28018
- 4:58 AM Changeset in webkit [47707] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-08-24 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
- platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
- platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
- platform/qt/fast/repaint/inline-block-resize-expected.txt: Added.
- 4:05 AM Changeset in webkit [47706] by
-
- 2 edits in trunk/LayoutTests
2009-08-24 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Skip new test added in r47630
- platform/qt/Skipped: Skip fast/backgrounds/size/parsing-inherit.html.
- 3:18 AM Changeset in webkit [47705] by
-
- 5 edits in trunk/LayoutTests
2009-08-24 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Update the outdated metrics for doctype tests. All tests pass.
- platform/qt/Skipped:
- platform/qt/fast/doctypes/001-expected.txt:
- platform/qt/fast/doctypes/002-expected.txt:
- platform/qt/fast/doctypes/004-expected.txt:
- 3:09 AM Changeset in webkit [47704] by
-
- 1 edit19 adds in trunk/LayoutTests
2009-08-24 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Add results for new tests added in r47678.
- platform/qt/fast/block/margin-collapse/block-inside-inline: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.txt: Added.
- platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Added.
- 3:09 AM Changeset in webkit [47703] by
-
- 11 edits in trunk/WebCore
2009-08-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Migrate call frames interaction to the InjectedScript-based schema.
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleTextMessage):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.get domWindow): (InspectorController.openInInspectedWindow): (InspectorController.getCallFrames): (InspectorController.evaluateInCallFrame):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.generateStylesheet):
- inspector/front-end/InjectedScript.js: (InjectedScript.evaluate): (InjectedScript._evaluateOn): (InjectedScript.openInInspectedWindow): (InjectedScript.getCallFrames): (InjectedScript.evaluateInCallFrame): (InjectedScript._callFrameForId): (InjectedScript._objectForId): (InjectedScript.CallFrameProxy): (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype._update):
- inspector/front-end/ObjectProxy.js: (WebInspector.ObjectPropertyProxy):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
- inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update): (WebInspector.ScopeVariableTreeElement.prototype.onattach): (WebInspector.ScopeVariableTreeElement.prototype.onexpand): (WebInspector.ScopeVariableTreeElement.prototype.oncollapse):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame): (WebInspector.ScriptsPanel.prototype.variablesInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.debuggerPaused.callback): (WebInspector.ScriptsPanel.prototype.debuggerPaused):
- 1:28 AM Changeset in webkit [47702] by
-
- 21 edits9 adds in trunk
2009-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
- Add tests for the placeholder attribute and DOM property of the textarea element.
- Correct the results for input-text-maxlength.html https://bugs.webkit.org/show_bug.cgi?id=21248
- fast/forms/resources/textarea-placeholder-dom-property.js: Added.
- fast/forms/textarea-placeholder-dom-property-expected.txt: Added.
- fast/forms/textarea-placeholder-dom-property.html: Added.
- fast/forms/textarea-placeholder-pseudo-style.html: Added.
- fast/forms/textarea-placeholder-set-attribute.html: Added.
- fast/forms/textarea-placeholder-set-value.html: Added.
- platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
- platform/mac/fast/forms/input-text-maxlength-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
- platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
- platform/mac/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
- platform/qt/fast/forms/input-text-maxlength-expected.txt:
- platform/win/fast/forms/input-text-maxlength-expected.txt:
2009-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Add support for the placeholder attribute and DOM property of the textarea element.
https://bugs.webkit.org/show_bug.cgi?id=21248
A DOM node for an INPUT element doesn't have a flag for placeholder
visibility anymore. This patch also fixes a bug that a renderer
doesn't reflect a corresponding DOM value change.
Tests: fast/forms/textarea-placeholder-dom-property.html
fast/forms/textarea-placeholder-pseudo-style.html
fast/forms/textarea-placeholder-set-attribute.html
fast/forms/textarea-placeholder-set-value.html
- css/html.css: Add the default style for placeholder of textarea.
- dom/InputElement.cpp: Cleanup for m_placeholderShouldBeVisible removal (WebCore::InputElement::dispatchFocusEvent): (WebCore::InputElement::dispatchBlurEvent): (WebCore::InputElement::placeholderShouldBeVisible): (WebCore::InputElement::updatePlaceholderVisibility): (WebCore::InputElement::setValueFromRenderer): (WebCore::InputElementData::InputElementData):
- dom/InputElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent): (WebCore::HTMLInputElement::dispatchBlurEvent): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::placeholderShouldBeVisible):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::updatePlaceholderVisibility):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::placeholderShouldBeVisible): (WebCore::HTMLTextAreaElement::updatePlaceholderVisibility): (WebCore::HTMLTextAreaElement::dispatchFocusEvent): (WebCore::HTMLTextAreaElement::dispatchBlurEvent):
- html/HTMLTextAreaElement.h:
- html/HTMLTextAreaElement.idl:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::styleDidChange): (WebCore::RenderTextControl::setInnerTextStyle): (WebCore::RenderTextControl::updatePlaceholderVisibility):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine): (WebCore::RenderTextControlMultiLine::nodeAtPoint): (WebCore::RenderTextControlMultiLine::updateFromElement): (WebCore::RenderTextControlMultiLine::createInnerTextStyle): (WebCore::RenderTextControlMultiLine::textBaseStyle):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::textBaseStyle): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
- rendering/RenderTextControlSingleLine.h:
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchFocusEvent): (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::placeholderShouldBeVisible):
- 12:14 AM Changeset in webkit [47701] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
Unreviewed.
Change my mail address on the list of committers.
- 12:02 AM Changeset in webkit [47700] by
-
- 2 edits in trunk/LayoutTests
2009-08-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix regression in editing tests by changing expected file to the
Mac one, since we now default to Mac in the EditingBehavior
setting.
- platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:
- 12:01 AM Changeset in webkit [47699] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix a couple of typos.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
Aug 23, 2009:
- 11:00 PM Changeset in webkit [47698] by
-
- 6 edits in trunk/WebCore
2009-08-23 Dirk Schulze <krit@webkit.org>
Reviewed by Mark Rowe.
Code clean-up and build fix for filters enabled builds. Moved SVGNames.h
into #if ENABLE(SVG) for Document.cpp and added SVGNames.h to the other
files. They are needed there after r47688.
- dom/Document.cpp:
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGFELightElement.h:
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- 8:44 PM Changeset in webkit [47697] by
-
- 8 edits in trunk
WebCore:
2009-08-23 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed, build fix for make distcheck on GTK+.
- GNUmakefile.am: Added files needed for the build.
- bindings/js/JSDOMWindowCustom.cpp: Protect SharedWorker include with #if clause.
- bindings/js/JSEventTarget.cpp: Dito.
- dom/Document.cpp: Dito.
- loader/FrameLoader.cpp: Dito.
2009-08-23 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed build fix for make distcheck.
- GNUmakefile.am: Added files required for the build.
- 2:42 PM Changeset in webkit [47696] by
-
- 3 edits in trunk/WebCore
2009-08-23 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Inspector: Throws an Error on "null"
https://bugs.webkit.org/show_bug.cgi?id=28665
- inspector/front-end/InjectedScript.js: (InjectedScript.evaluate):
- 12:49 PM Changeset in webkit [47695] by
-
- 2 edits in trunk/WebCore
2009-08-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often
- inspector/front-end/InjectedScript.js: (InjectedScript.getProperties): (InjectedScript.createProxyObject):
- 12:24 PM Changeset in webkit [47694] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update editing-behavior property here too.
- webkit/webkitwebview.cpp: (webkit_web_view_settings_notify):
- 10:04 AM Changeset in webkit [47693] by
-
- 2 edits in trunk/WebKit/gtk
2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubberstamped by Gustavo Noronha.
Fix regressions introduced by http://trac.webkit.org/changeset/47690.
Update the setting whenever the property gets set.
- webkit/webkitwebview.cpp: (webkit_web_view_settings_notify):
- 3:08 AM Changeset in webkit [47692] by
-
- 2 edits in trunk/WebKitTools
2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] API for disabling local file access to web URLs
https://bugs.webkit.org/show_bug.cgi?id=28663
Enable this setting for DRT.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- 2:05 AM Changeset in webkit [47691] by
-
- 2 edits in trunk/LayoutTests
2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Not reviewed. Skip new tests from
http://trac.webkit.org/changeset/47678 and the appcache HTTP
authentication tests (https://bugs.webkit.org/show_bug.cgi?id=28668)
- platform/gtk/Skipped:
- 1:45 AM Changeset in webkit [47690] by
-
- 3 edits in trunk/WebKit/gtk
2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] API for disabling local file access to web URLs
https://bugs.webkit.org/show_bug.cgi?id=28663
Add a setting to enable or disable file access to web URLs. It's
disabled by default for security reasons.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
- 12:18 AM Changeset in webkit [47689] by
-
- 2 edits in trunk/WebCore
2009-08-22 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly
https://bugs.webkit.org/show_bug.cgi?id=28345
When doing the conversion between cairo_surface_t* and GdkPixbuf*
account for the differences in the respective formats' in-memory
image format.
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::getCairoSurfacePixel): (WebCore::getGdkPixbufPixel): (WebCore::BitmapImage::getGdkPixbuf):
