Timeline
Aug 29, 2009:
- 4:59 PM Changeset in webkit [47883] by
-
- 3 edits2 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=28829
Crash in AccessibilityRenderObject::activeDescendant when trying to set aria-activedescendant to something without a renderer
Reviewed by Dan Bernstein.
Test: accessibility/aria-activedescendant-crash.html
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::activeDescendant): Nil check.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=28829
Crash in AccessibilityRenderObject::activeDescendant when trying to set aria-activedescendant to something without a renderer
Reviewed by Dan Bernstein.
- accessibility/aria-activedescendant-crash-expected.txt: Added.
- accessibility/aria-activedescendant-crash.html: Added.
Aug 28, 2009:
- 11:56 PM Changeset in webkit [47882] by
-
- 6 edits in trunk
2009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Oliver Hunt.
Gtk Build broken for OSX Quartz
https://bugs.webkit.org/show_bug.cgi?id=28727
Define XP_UNIX for non-Win OS builds.
- GNUmakefile.am:
Check for XP_UNIX instead of GTK or X11 to ease building of the Gtk
port in Mac and Unix/Linux.
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::getValue): (WebCore::PluginView::init):
- 6:51 PM Changeset in webkit [47881] by
-
- 4 edits in trunk/WebKitTools
2009-08-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue needs a master process
https://bugs.webkit.org/show_bug.cgi?id=28040
Add a bugzilla-tool commit-queue command
Keeps per-bug logs, but doesn't yet upload them anywhere.
- Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
- Scripts/modules/buildbot.py: remove noisy log message
- Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
- 4:37 PM Changeset in webkit [47880] by
-
- 2 edits in trunk/WebKitLibraries
Define _CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1
to automatically use secure versions of C runtime lib calls on Windows.
https://bugs.webkit.org/show_bug.cgi?id=28824
Reviewed by Adam Roben.
- win/tools/vsprops/common.vsprops:
- 4:31 PM Changeset in webkit [47879] by
-
- 2 edits in trunk/LayoutTests
2009-08-28 Gustavo Noronha Silva <Gustavo Noronha Silva>
Re-skipping tests that still fail on the bot.
- platform/gtk/Skipped:
- 4:13 PM Changeset in webkit [47878] by
-
- 2 edits in trunk/LayoutTests
2009-08-28 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unskip some passing tests, skip new tests that are failing.
- platform/gtk/Skipped:
- 4:08 PM Changeset in webkit [47877] by
-
- 2 edits in trunk/WebCore
2009-08-28 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe
Wrap WebkitCSSTransformValues in the correct class of DOM wrapper.
https://bugs.webkit.org/show_bug.cgi?id=27727
When fetching the DOM wrapper for a WebkitCSSTransformValue (which is a kind of
CSSValueList), we need to ask the value list whether it's a WebkitCSSTransformValue,
because there is not a unique enum value for WebkitCSSTransformValue.
- bindings/objc/DOMCSS.mm: (kitClass):
- 3:09 PM Changeset in webkit [47876] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28308
Fix some warnings introduced by r47381.
Reviewed by Jan Michael Alonzo.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::convertCMYKToRGBA):
(WebCore::convertRGBToRGBA):
- 3:03 PM Changeset in webkit [47875] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=21442
Make sure filesystemPathFromUrlOrTitle() returns a string with length
<= MAX_PATH - 1.
- platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle):
- 2:44 PM Changeset in webkit [47874] by
-
- 5 edits1 copy2 deletes in trunk/WebCore
2009-08-28 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Adding Chromium's VFS for Linux and Mac.
- WebCore.gypi:
- platform/chromium/ChromiumBridge.h:
- platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::openDatabase): (WebCore::SQLiteFileSystem::deleteDatabaseFile):
- platform/sql/chromium/SQLiteFileSystemChromiumLinux.cpp: Removed.
- platform/sql/chromium/SQLiteFileSystemChromiumMac.cpp: Removed.
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: Added.
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
- 2:16 PM Changeset in webkit [47873] by
-
- 2 edits in trunk/LayoutTests
set-dangerous-headers.html shouldn't set allowed header to same value
as forbidden headers. AUTHORIZATION is an allowed header, and the
value is being set to "foobar" like the forbidden headers, which causes
the test to fail when run using http server that doesn't strip the
AUTHORIZATION header.
https://bugs.webkit.org/show_bug.cgi?id=28818
Patch by Julie Parent <jparent@chromium.org> on 2009-08-28
Reviewed by Alexey Proskuryakov.
- http/tests/xmlhttprequest/set-dangerous-headers.html:
- 11:59 AM Changeset in webkit [47872] by
-
- 8 edits in trunk/WebCore
2009-08-28 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Made bindings use Node::setOnEvent functions for Node descendants
instead of Node::setAttributeEventListener.
Node::setAttributeEventListener is an internal function and
doesn't do the forwarding to DOM window that is required for some
HTML elements.
https://bugs.webkit.org/show_bug.cgi?id=28709
Tests added in http://trac.webkit.org/changeset/47326 now pass with V8.
- bindings/scripts/CodeGeneratorV8.pm: Now generates EventListener accessors for Node descendants instead of using custom callbacks.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener): Moved from V8NodeCustom.cpp.
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Fixed a bug in signature.
- bindings/v8/V8Utilities.cpp: (WebCore::createHiddenDependency): (WebCore::removeHiddenDependency): Changed signature to accept Handle instead of Local.
- bindings/v8/V8Utilities.h:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Removed custom callbacks for EventListener accessors.
- 11:40 AM Changeset in webkit [47871] by
-
- 2 edits in trunk/WebCore
2009-08-28 Ben Murdoch <benm@google.com>
Implements V8CustomVoidCallback reporting any exceptions that were thrown from the callback function.
- bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback): Checks if the callback raised an exception and reports it to WebCore if so.
- 11:34 AM Changeset in webkit [47870] by
-
- 4 edits in trunk/WebKit
WebKit: update-webkit-localizable-strings script can no longer complete
https://bugs.webkit.org/show_bug.cgi?id=28792
Reviewed by John Sullivan.
- English.lproj/Localizable.strings:
WebKit/mac: update-webkit-localizable-strings script can no longer complete
https://bugs.webkit.org/show_bug.cgi?id=28792
Reviewed by John Sullivan.
- WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):
- 11:29 AM Changeset in webkit [47869] by
-
- 3 edits in trunk/WebCore
Not reviewed (build fix).
- platform/graphics/qt/ImageDecoderQt.cpp: Accidentally added some spaces.
(WebCore::ImageDecoder::create):
(WebCore::ImageDecoderQt::ImageDecoderQt):
- platform/graphics/qt/ImageDecoderQt.h: Make constructor public so factory function can access it (this seemed better than making ImageDecoder a friend).
- 11:08 AM Changeset in webkit [47868] by
-
- 7 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=27965
Move ImageDecoder creation function to a factory function on
ImageDecoder. This is arguably where it makes the most sense anyway,
and it will (soon) allow ImageSourceQt.cpp to have one less dedicated
function.
Reviewed by Eric Seidel.
- platform/graphics/ImageSource.cpp:
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoder::create):
- platform/graphics/qt/ImageDecoderQt.h:
- platform/graphics/qt/ImageSourceQt.cpp:
(WebCore::ImageSource::setData):
- platform/image-decoders/ImageDecoder.cpp:
- platform/image-decoders/ImageDecoder.h:
- 11:00 AM Changeset in webkit [47867] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28785
Combine duplicated code from ImageDecoder*.cpp into the main
ImageDecoder.cpp.
Reviewed by Eric Seidel.
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::zeroFill):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::setStatus):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
- platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
- platform/image-decoders/wx/ImageDecoderWx.cpp:
- 8:24 AM Changeset in webkit [47866] by
-
- 25 edits1 add in trunk
2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable
Adding files for the new test for window-related issues (starting
with scrollbar policy).
- GNUmakefile.am:
WebCore
2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable
Override setScrollbarModes to correctly forward scrollbar modes
policy changes to client code, via a new platform-specific method,
scrollbarsPolicyDidChange.
- page/ChromeClient.h: (WebCore::ChromeClient::scrollbarsPolicyDidChange):
- platform/ScrollView.cpp: (WebCore::ScrollView::createScrollbar):
- platform/ScrollView.h:
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setScrollbarModes):
WebKit/gtk
2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable
Add properties and a signal to report scrollbar policy changes to
client code, and a default handler that does the right thing when
using GtkScrolledWindow.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scrollbarsModeDidChange):
- WebCoreSupport/ChromeClientGtk.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_get_property): (webkit_web_frame_class_init): (webkit_web_frame_get_horizontal_scrollbar_policy): (webkit_web_frame_get_vertical_scrollbar_policy):
- webkit/webkitwebframe.h:
- tests/testwindow.c: Added. (load_finished_cb): (test_webkit_window_scrollbar_policy): (main):
WebKit/*
Added empty implementation of new ChromeClient method.
- 8:12 AM Changeset in webkit [47865] by
-
- 3 edits in trunk/WebKit/gtk
2009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Add view source mode API
https://bugs.webkit.org/show_bug.cgi?id=28805
Implement setter and getter for "view source" mode.
- webkit/webkitwebview.cpp: (webkit_web_view_set_view_source_mode): (webkit_web_frame_get_view_source_mode):
- webkit/webkitwebview.h:
- 7:27 AM Changeset in webkit [47864] by
-
- 4 edits5 adds in trunk
2009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] Geolocation needs permission API before being enabled by default
Unskip the Geolocation tests and rebaseline three DOM tests.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt: Added.
- platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Added.
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Added.
Build the Gtk port with geolocation enabled. This option is only
enabled for the buildbot. The autotools option will be enabled by
default once the permissions API is implemented.
- Scripts/build-webkit:
- 6:58 AM Changeset in webkit [47863] by
-
- 3 edits in trunk/WebCore
[Qt/Mac] Un-blacklist the QuickTime plugin
Patch by Cédric Luthi <cedric.luthi@gmail.com> on 2009-08-28
Reviewed by Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=28768
Now that the drawing model is properly negotiated, there is no need the
blacklist the QuickTime plugin anymore.
This revealed a bug in PluginView::performRequest: it should not initiate a
request if the plugin has been stopped, which is what happens when a plugin
only supports the QuickDraw drawing model.
- plugins/PluginView.cpp:
- plugins/mac/PluginPackageMac.cpp:
- 6:42 AM Changeset in webkit [47862] by
-
- 3 edits in trunk/WebCore
2009-08-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Set DOM agent document to 0 in InspectorController::close to
make DOM agent remove DOM listeners from the inspected document.
Replace windowVisible checks with m_frontend checks to as inspector
window lives in a different process in Chromium while frontend proxy
is in the inspected page process.
- inspector/InspectorController.cpp: (WebCore::InspectorController::inspect): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::close): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::addProfile):
- inspector/InspectorController.h:
- 6:23 AM Changeset in webkit [47861] by
-
- 3 edits in trunk/WebCore
2009-08-28 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Remove dependency of SummaryBar on WebInspector.resourceCategories.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get categories):
- inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.update):
- 5:28 AM Changeset in webkit [47860] by
-
- 41 edits in trunk/LayoutTests
2009-08-28 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Adapt expecteds of css2.1/t0401* to new metrics. Remove these files from Skipped. (39 files)
- platform/qt/Skipped:
- platform/qt/css2.1/t040102-keywords-00-b-expected.txt:
- platform/qt/css2.1/t040102-keywords-01-b-expected.txt:
- platform/qt/css2.1/t040103-case-00-b-expected.txt:
- platform/qt/css2.1/t040103-case-01-c-expected.txt:
- platform/qt/css2.1/t040103-escapes-00-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-01-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-02-d-expected.txt:
- platform/qt/css2.1/t040103-escapes-03-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-04-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-05-c-expected.txt:
- platform/qt/css2.1/t040103-escapes-06-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-07-b-expected.txt:
- platform/qt/css2.1/t040103-escapes-08-b-expected.txt:
- platform/qt/css2.1/t040103-ident-00-c-expected.txt:
- platform/qt/css2.1/t040103-ident-01-c-expected.txt:
- platform/qt/css2.1/t040103-ident-02-c-expected.txt:
- platform/qt/css2.1/t040103-ident-03-c-expected.txt:
- platform/qt/css2.1/t040103-ident-04-c-expected.txt:
- platform/qt/css2.1/t040103-ident-05-c-expected.txt:
- platform/qt/css2.1/t040103-ident-06-c-expected.txt:
- platform/qt/css2.1/t040103-ident-07-c-expected.txt:
- platform/qt/css2.1/t040103-ident-08-c-expected.txt:
- platform/qt/css2.1/t040103-ident-09-c-expected.txt:
- platform/qt/css2.1/t040103-ident-10-c-expected.txt:
- platform/qt/css2.1/t040103-ident-11-c-expected.txt:
- platform/qt/css2.1/t040103-ident-12-c-expected.txt:
- platform/qt/css2.1/t040103-ident-13-c-expected.txt:
- platform/qt/css2.1/t040105-atkeyw-00-b-expected.txt:
- platform/qt/css2.1/t040105-atkeyw-01-b-expected.txt:
- platform/qt/css2.1/t040105-atkeyw-02-b-expected.txt:
- platform/qt/css2.1/t040105-atrule-00-b-expected.txt:
- platform/qt/css2.1/t040105-atrule-01-b-expected.txt:
- platform/qt/css2.1/t040105-atrule-02-b-expected.txt:
- platform/qt/css2.1/t040105-atrule-03-b-expected.txt:
- platform/qt/css2.1/t040105-atrule-04-b-expected.txt:
- platform/qt/css2.1/t040105-import-00-b-expected.txt:
- platform/qt/css2.1/t040105-import-01-b-expected.txt:
- platform/qt/css2.1/t040109-c17-comments-00-b-expected.txt:
- platform/qt/css2.1/t040109-c17-comments-01-b-expected.txt:
- 2:00 AM Changeset in webkit [47859] by
-
- 2 edits in trunk/WebCore
2009-08-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed (patching in l18n change that was missing due to
the git binary diff format).
- English.lproj/localizedStrings.js:
- 1:08 AM Changeset in webkit [47858] by
-
- 3 edits in trunk/WebCore
2009-08-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make XSSAuditor go fast
https://bugs.webkit.org/show_bug.cgi?id=28667
Make the XSSAuditor go faster by implementing two optimizations:
1) We avoid canonicalizing scripts that are larger than the page's URL.
This saves a bunch of time for large inline scripts.
2) We memoize canonicalizing the page's URL because it's silly to
canonicalize repeated for each inline event listener.
These optimizations have a measurable affect on the intl1 page cycler.
No behavior change.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::MemoizingURLCanonicalizer::canonicalizeURL): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::canSetBaseElementURL): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h:
Aug 27, 2009:
- 11:17 PM Changeset in webkit [47857] by
-
- 5 edits in trunk
JSON Stringifier does not follow ES5 spec for handling of Number, String and Boolean objects
https://bugs.webkit.org/show_bug.cgi?id=28797
Reviewed by Maciej Stachowiak
Fixed unwrapBoxedPrimitive to do the right thing, which necessitated a couple of new exception
checks, and corrected the logic in gap to correctly convert Number and String objects.
- 9:54 PM Changeset in webkit [47856] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Skipping worker-lifecycle.html test since it generates a deadlock on snowleopard.
Tracked as https://bugs.webkit.org/show_bug.cgi?id=28795.
- platform/mac-snowleopard/Skipped:
- 8:09 PM Changeset in webkit [47855] by
-
- 2 edits in trunk/WebCore
2009-08-27 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Removed ASSERT_NOT_REACHED, because indeed this ASSERT is reached in
fast/canvas/change-context.html. And it's alright to reach it.
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Removed assertion.
- 7:03 PM Changeset in webkit [47854] by
-
- 2 edits in trunk/WebCore
2009-08-27 Jeremy Orlow <jorlow@chromium.org>
Not reviewed. Build fix for http://trac.webkit.org/changeset/47840
Peter's change forgot one m_decoder->
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- 6:58 PM Changeset in webkit [47853] by
-
- 2 edits in trunk/WebCore
2009-08-27 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[V8] Add NULL-check, since the context ain't changeable no more, and
thus getContext could return 0.
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Added NULL-check.
- 6:38 PM Changeset in webkit [47852] by
-
- 6 edits in trunk
2009-08-27 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Eric Seidel.
dataTransfer.types() should include type "Files" when files are present in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28780
Add dataTransfer type "Files" to the chromium port. Add eseidel's
patch for same for the mac port.
- platform/chromium/ClipboardChromium.cpp:
2009-08-27 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Eric Seidel.
dataTransfer.types() should include type "Files" when files are present in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28780
Test dataTransfer.types "Files" access for all ports.
- http/tests/security/clipboard/clipboard-file-access-expected.txt:
- http/tests/security/clipboard/resources/clipboard-file-access.js:
- 6:20 PM Changeset in webkit [47851] by
-
- 7 edits in trunk/WebCore
Removed GL_ from all constants, and gl prefix from all calls
https://bugs.webkit.org/show_bug.cgi?id=28773
This was done for the external API in CanvasRenderingContext3D and
the internal API in GraphicsContext3D.
- 6:08 PM Changeset in webkit [47850] by
-
- 2 edits in trunk/LayoutTests
Tweak to force worker object to get GC'd.
Reviewed by Oliver Hunt.
- fast/workers/resources/dedicated-worker-lifecycle.js:
- 6:00 PM Changeset in webkit [47849] by
-
- 3 edits in trunk/WebCore
2009-08-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Qt and Gtk build fixes. Not reviewed.
Add CanvasRenderingContext3D.idl to the build scripts.
- GNUmakefile.am:
- WebCore.pro:
- 5:31 PM Changeset in webkit [47848] by
-
- 2 edits in trunk/WebKit
- StringsNotToBeLocalized.txt:
Brought up to date, other than the problem mentioned in https://bugs.webkit.org/show_bug.cgi?id=28792
- 5:27 PM Changeset in webkit [47847] by
-
- 6 edits in trunk
JSON.stringify replacer array does not accept values that are not string primitives.
https://bugs.webkit.org/show_bug.cgi?id=28788
Reviewed by Adam Roben
Update the JSON stringifier to initialise its replacer array according to the most
recent version of the spec.
- 5:13 PM Changeset in webkit [47846] by
-
- 3 edits in trunk/WebCore
2009-08-27 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Release the storage mutex whenever leaving JavaScript execution.
https://bugs.webkit.org/show_bug.cgi?id=28789
http://dev.w3.org/html5/spec/Overview.html#storage-mutex describes the
required behavior. After we leave JavaScript, we must be sure the storage
mutex has been released. At the end of evaluate(), if localStorage has been
instantiated, tell it to release any locks that may be applicable.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- 5:11 PM Changeset in webkit [47845] by
-
- 4 edits in trunk
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=28753
<rdar://problem/7173448> Excessive number of threads (and a crash)
Coalesce DNS prefetch requests to reduce strain on CFHost. Currently, the algorithm is as follows:
- when resolver is idle, the first few requests are sent immediately (they may or may not hit the wire);
- if there are a few requests in flight already, coalesce all requests for one second;
- to avoid pathological cases with lots of links to different sites on a page, only ask CFHost about a handful of names (dropping the rest).
Coalescing reduces the number of requests dramatically, as prefetchDNS is called for each
link, and these tend to have identical host name.
- platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::DNSResolveQueue): (WebCore::DNSResolveQueue::shared): (WebCore::DNSResolveQueue::add): (WebCore::DNSResolveQueue::decrementRequestCount): (WebCore::DNSResolveQueue::fired): (WebCore::clientCallback): (WebCore::DNSResolveQueue::resolve): (WebCore::prefetchDNS):
- 5:08 PM Changeset in webkit [47844] by
-
- 5 edits in trunk
JavaScriptCore: Link the testapi against CFLite when building the WinCairo port.
Reviewed by Adam Roben.
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Add new Release_CFLite target. Update all targets to inherit from either the JavaScriptCF.vsprops (Apple target) or the JavaScriptCFLite.vsprops file (WinCairo target).
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Remove input file CoreFoundation.lib. This is provided by either the JavaScriptCF.vsprops or JavaScriptCFLite.vsprops file.
WebKit/win: Modify Release_Cairo target to build testapi using the
Release_CFLite target so that the correct CoreFoundation
(in this case, CFLite.dll) is linked.
Reviewed by Adam Roben.
- WebKit.vcproj/WebKit.sln:
- 4:55 PM Changeset in webkit [47843] by
-
- 43 edits2 adds in trunk
Final patch for Canvas 3D support
https://bugs.webkit.org/show_bug.cgi?id=28018
This hooks everything up and provides a working implementation of
Canvas 3D. I plumb the creation of the 3D canvas down to GraphicsLayer,
passing the opaque context and texture pointers so a Canvas3DLayer can be
created (more on that later). It also plumbs changes to the 3D canvas so
that Canvas3DLayer can recomposite the results.
A 3D Canvas element needs a RenderLayer and compositing layer to render.
This is because it renders to an off-screen texture in the GPU and then
hands it to a Canvas3DLayer, which is a subclass of CAOpenGLLayer, to
render that texture as a 3D quad. This keeps everything in GPU memory to
maximize performance. When a CanvasRenderingContext3D is created it
forces a style recalc which creates the RenderLayer and compositing
layer if needed.
I repurposed an existing flag which was put in place for animation to accomplish
this. This flag is passed to setNeedsStyleRecalc(), and I renamed it from
AnimationStyleChange to SyntheticStyleChange. It essentially says that you need
to do a complete style recalc, even though the style itself has not really
changed.
This patch also fixes a couple of bugs discovered when testing with 3d-canvas
turned on. I also added a constructor DOMWindow.idl for CanvasRenderingContext3D.
This is needed when making a JS wrapper for the object so the prototype
property can be set.
- 4:35 PM Changeset in webkit [47842] by
-
- 2 edits in trunk/JavaScriptCore
Fix Windows-specific crash due to missing memory clearing call.
Reviewed by Geoff Garen.
- runtime/Collector.cpp:
(JSC::Heap::allocateBlock):
- 4:16 PM Changeset in webkit [47841] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28751
Clean up ImageDecoder*.cpp a bit.
Reviewed by Eric Seidel.
- platform/image-decoders/ImageDecoder.cpp: Put functions in the same order as in the header file. Also, since there's already an anonymous namespace in this file, use it to enclose the local helper functions.
(WebCore::):
(WebCore::ImageDecoder::upperBoundScaledX):
(WebCore::ImageDecoder::lowerBoundScaledX):
(WebCore::ImageDecoder::scaledY):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::RGBA32Buffer::width): Style fix.
(WebCore::RGBA32Buffer::height): Style fix.
- platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
(WebCore::RGBA32Buffer::copyBitmapData): Ensure m_size is set correctly.
(WebCore::RGBA32Buffer::asNewNativeImage): Remove unneeded temp.
(WebCore::RGBA32Buffer::operator=): Simplify.
- platform/image-decoders/wx/ImageDecoderWx.cpp:
(WebCore::RGBA32Buffer::asNewNativeImage): Try and collect spaced-out temps under loop comment to show they're all related. Use size_t for iterating over elements of a Vector.
(WebCore::RGBA32Buffer::width): Style fix.
(WebCore::RGBA32Buffer::height): Style fix.
- 4:14 PM Changeset in webkit [47840] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28751
Clean up ImageSource.* in preparation for more fixes on bug 27965.
Reviewed by Eric Seidel.
- platform/graphics/ImageSource.cpp: Put functions in the same order as in header file.
(WebCore::ImageSource::isSizeAvailable): Shorten.
(WebCore::ImageSource::size): Shorten.
(WebCore::ImageSource::frameSizeAtIndex): Shorten.
(WebCore::ImageSource::repetitionCount): Shorten.
(WebCore::ImageSource::frameIsCompleteAtIndex):
- platform/graphics/ImageSource.h: Shorten #ifdef section a bit by sharing common typedefs.
- 3:58 PM Changeset in webkit [47839] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Skip HTML5 worker lifecycle test added in r47837 as it depends on unimplemented functionality in DRT.
- platform/qt/Skipped:
- 3:05 PM Changeset in webkit [47838] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: JavaScriptCore_debug.def missing some exports. Apple
Windows build does not use this file, so it was not noticed previously.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 2:57 PM Changeset in webkit [47837] by
-
- 4 edits8 adds in trunk/LayoutTests
Need to write tests for worker lifecycle mechanisms.
https://bugs.webkit.org/show_bug.cgi?id=28714
Reviewed by David Levin.
- fast/workers/dedicated-worker-lifecycle-expected.txt: Added.
- fast/workers/dedicated-worker-lifecycle.html: Added.
- fast/workers/resources/create-shared-worker-frame.html: Added.
- fast/workers/resources/dedicated-worker-lifecycle.js: Added.
Broke out "orphaned worker" lifecycle tests because they only apply to dedicated workers.
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
(orphanedTimeoutWorkerExited):
- fast/workers/resources/shared-worker-lifecycle.js: Added.
Added tests for the various shared worker lifecycle cases (makes sure that refcounts are properly updated when documents close).
(runTests):
(createWorkerFrame):
(closeFrame):
(closeFrame1):
(closeFrame2):
(closeFrame3):
(closeFrame4):
(complete):
- fast/workers/resources/worker-lifecycle.js:
Updated test so it can run in a browser (with incorrect output) to aid in debugging.
(runTests.worker.onmessage):
(runTests):
(workerExited):
- fast/workers/resources/worker-util.js: Added.
Moved some common utilities out of worker-lifecycle.js and into this file so they can be shared with other tests.
(log):
(gc):
(waitUntilWorkerThreadsExit):
(waitUntilThreadCountMatches.return):
(waitUntilThreadCountMatches):
(ensureThreadCountMatches):
(done):
- fast/workers/shared-worker-frame-lifecycle-expected.txt: Added.
- fast/workers/shared-worker-frame-lifecycle.html-disabled: Added.
- fast/workers/shared-worker-lifecycle.html-disabled:
- fast/workers/worker-lifecycle.html:
- 2:38 PM Changeset in webkit [47836] by
-
- 7 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28785
Add ImageDecoder.cpp to various build files so platforms will be able to
use it. Move an ENABLE to not cover the whole file, in preparation for
adding a bunch of code. Simplify #ifdefs in ImageDecoder.h to be "Skia
vs. everyone else", which also gives new platforms a reasonable default
behavior.
Reviewed by Eric Seidel.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::):
- platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::getAddr):
- 1:55 PM Changeset in webkit [47835] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28784
Reviewed by Dave Kilzer.
Add an exported method to flush pending repaints.
- WebCore.base.exp:
- page/FrameView.cpp:
(WebCore::FrameView::layoutIfNeededRecursive):
(WebCore::FrameView::flushDeferredRepaints):
- page/FrameView.h:
- 1:45 PM Changeset in webkit [47834] by
-
- 3 edits in trunk/JavaScriptCore
x86-64 GTK broken due to code offsets changing, pointers sometimes packed into immediates.
https://bugs.webkit.org/show_bug.cgi?id=28317
Reviewed by Oliver Hunt.
Missed one, fix part II.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::move):
- assembler/X86Assembler.h:
(JSC::CAN_SIGN_EXTEND_8_32):
- 1:39 PM Changeset in webkit [47833] by
-
- 2 edits in trunk/WebCore
2009-08-27 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Eric Seidel.
[V8] Expose files from the pasteboard in drop events.
https://bugs.webkit.org/show_bug.cgi?id=28782
Update chromium port to expose dataTransfer.files() as per
HTML5 drag drop (Aug 2009 edition).
- platform/chromium/ClipboardChromium.cpp:
- 1:29 PM Changeset in webkit [47832] by
-
- 3 edits in trunk/LayoutTests
2009-08-27 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Eric Seidel.
clipboard file access tests use "dragentered" instead of "dragenter"
https://bugs.webkit.org/show_bug.cgi?id=28761
Use dragenter and log these events. Add a dragleave test to check
that drag files are not visible in dragleave events.
- http/tests/security/clipboard/clipboard-file-access-expected.txt:
- http/tests/security/clipboard/resources/clipboard-file-access.js:
- 12:40 PM Changeset in webkit [47831] by
-
- 9 edits in trunk/WebCore
2009-08-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dmitry Glazkov.
ScriptState now keeps explicit Handle of devtools front-end
utility context instead of trying to retrieve it from inspected
Frame.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
- bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope):
- bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::~ScriptState): (WebCore::scriptStateFromPage):
- bindings/v8/ScriptState.h: (WebCore::ScriptState::context):
- bindings/v8/ScriptValue.h: (WebCore::ScriptValue::~ScriptValue):
- inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
- 12:37 PM Changeset in webkit [47830] by
-
- 3 edits in trunk/WebCore
2009-08-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Console won't close.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._updateModifiedNodes):
- inspector/front-end/utilities.js: (Node.prototype.isAncestor):
- 12:16 PM Changeset in webkit [47829] by
-
- 3 edits3 adds in trunk
2009-08-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add a test to make sure that image/link drags don't contain junk file arrays.
https://bugs.webkit.org/show_bug.cgi?id=28755
- editing/pasteboard/files-during-page-drags-expected.txt: Added.
- editing/pasteboard/files-during-page-drags.html: Added.
- editing/pasteboard/resources/files-during-page-drags.js: Added.
2009-08-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix a typo in files() causing image drags to have junk file arrays.
https://bugs.webkit.org/show_bug.cgi?id=28755
Test: editing/pasteboard/files-during-page-drags.html
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::files):
- 12:15 PM Changeset in webkit [47828] by
-
- 5 edits in trunk
JSON parser accepts trailing comma in array literals
https://bugs.webkit.org/show_bug.cgi?id=28779
Reviewed by Alexey Proskuryakov.
Update parser to correctly fail if there's a trailing comma.
- 11:46 AM Changeset in webkit [47827] by
-
- 5 edits in trunk/WebCore
Not reviewed. Build fix for Chromium.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-08-27
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 11:07 AM Changeset in webkit [47826] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- DerivedSources.cpp: Added JSPageTransitionEvent.cpp to DerivedSources.cpp.
- 10:52 AM Changeset in webkit [47825] by
-
- 1 edit in trunk/WebCore/ChangeLog
Zap gremlins from a recent ChangeLog entry.
- 10:46 AM Changeset in webkit [47824] by
-
- 25 edits13 adds in trunk
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=28758
<rdar://problem/6440869> Implement pageshow and pagehide events for b/f cache (28758)
Tests: fast/events/pageshow-pagehide-on-back-cached.html
fast/events/pageshow-pagehide-on-back-uncached.html
fast/events/pageshow-pagehide.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Dispatch pagehide event (this function is called both when a document goes away, and when it goes to b/f cache).
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Dispatch pagehide right before unload. (WebCore::DOMWindow::dispatchPageTransitionEvent): Do what it takes to add a new event handler that can be installed on Window object. (WebCore::DOMWindow::onpagehide): Ditto. (WebCore::DOMWindow::setOnpagehide): Ditto. (WebCore::DOMWindow::onpageshow): Ditto. (WebCore::DOMWindow::setOnpageshow): Ditto.
- history/CachedFrame.cpp: (WebCore::CachedFrame::restore): Dispatch pageshow for a page that isn't being restored from cache.
- dom/PageTransitionEvent.cpp: Added. (WebCore::PageTransitionEvent::PageTransitionEvent): (WebCore::PageTransitionEvent::~PageTransitionEvent): (WebCore::PageTransitionEvent::initPageTransitionEvent):
- dom/PageTransitionEvent.h: Added. (WebCore::PageTransitionEvent::create): (WebCore::PageTransitionEvent::isPageTransitionEvent): (WebCore::PageTransitionEvent::persisted):
- dom/PageTransitionEvent.idl: Added. Add event class implementation.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Support inline listener definition (note that adding listeners to document.body programmatically is not supported, matching Firefox).
- dom/Document.cpp: (WebCore::Document::implicitClose): Dispatch pageshow event right before load event. (WebCore::Document::dispatchPageTransitionEvent): Do what it takes to add a new event for Docuemnt. (WebCore::Document::createEvent): Ditto.
- dom/Document.h: Added dispatchPageTransitionEvent.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- dom/Event.cpp: (WebCore::Event::isPageTransitionEvent):
- dom/Event.h:
- dom/EventNames.h:
- html/HTMLAttributeNames.in:
- page/DOMWindow.h:
- page/DOMWindow.idl: Do what it takes to add a new event type.
- 9:35 AM Changeset in webkit [47823] by
-
- 1 edit1 add in trunk/WebCore
2009-08-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by NOBODY (build fix).
Adding missing file from previous commit.
- inspector/front-end/SummaryBar.js: Added. (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.get calculator): (WebInspector.SummaryBar.prototype.set calculator): (WebInspector.SummaryBar.prototype.reset): (WebInspector.SummaryBar.prototype.update): (WebInspector.SummaryBar.prototype._drawSwatch.drawSwatchSquare): (WebInspector.SummaryBar.prototype._drawSwatch): (WebInspector.SummaryBar.prototype._drawSummaryGraph.var): (WebInspector.SummaryBar.prototype._drawSummaryGraph): (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill): (WebInspector.SummaryBar.prototype._fadeOutRect): (WebInspector.SummaryBar.prototype._makeLegendElement):
- 9:09 AM Changeset in webkit [47822] by
-
- 7 edits in trunk/WebCore
2009-08-27 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Factor out Factor out summary bar from Resources panel.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateSummaryGraph): (WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition): (WebInspector.ResourcesPanel.prototype._changeSortingFunction):
- inspector/front-end/SummaryBar.js: Added. (WebInspector.SummaryBar): (WebInspector.SummaryBar.prototype.get calculator): (WebInspector.SummaryBar.prototype.set calculator): (WebInspector.SummaryBar.prototype.reset): (WebInspector.SummaryBar.prototype.update): (WebInspector.SummaryBar.prototype._drawSwatch.drawSwatchSquare): (WebInspector.SummaryBar.prototype._drawSwatch): (WebInspector.SummaryBar.prototype._drawSummaryGraph.var): (WebInspector.SummaryBar.prototype._drawSummaryGraph): (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill): (WebInspector.SummaryBar.prototype._fadeOutRect): (WebInspector.SummaryBar.prototype._makeLegendElement):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- 8:38 AM Changeset in webkit [47821] by
-
- 4 edits in trunk/WebCore
2009-08-26 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Start adding heap profiler to Inspector (hidden behind a flag.)
- English.lproj/localizedStrings.js:
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.get statusBarItems): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.addProfile): (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._snapshotClicked):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: added Preferences.heapProfilerPresent flag.
- 8:24 AM Changeset in webkit [47820] by
-
- 2 edits in trunk/WebCore
2009-08-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Metrics sidebar editing is broken.
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update):
- 7:54 AM Changeset in webkit [47819] by
-
- 2 edits in trunk/WebCore
2009-08-27 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Make KURLGoogle.cpp's decodeURLEscapeSequences decode %00 to match
KURL.cpp. This makes the XSSAuditor tests pass when using KURLGoogle.
- platform/KURLGoogle.cpp: (WebCore::decodeURLEscapeSequences):
- 7:43 AM BuildingQtOnOSX edited by
- (diff)
- 7:38 AM BuildingQtOnOSX edited by
- (diff)
- 5:27 AM Changeset in webkit [47818] by
-
- 3 edits in trunk/WebKit/qt
2009-08-27 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Ariya Hidayat.
QWebHistory::clear() modifications.
Clear() method was changed. If QWebHistory is empty (there is no
elements even current) clear() do nothing. If there at least one
element clear() will delete everything apart of current.
New autotests in QWebHistory
New autotests were added to QWebHistory. They should check some crashes
in save and restore state process and clear() method and general
behavior on where QWebHistory::count() == 0 or QWebHistory::count() == 1
- Api/qwebhistory.cpp: (QWebHistory::clear):
- tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::back): (tst_QWebHistory::forward): (tst_QWebHistory::saveAndRestore_crash_1): (tst_QWebHistory::saveAndRestore_crash_2): (tst_QWebHistory::saveAndRestore_crash_3): (tst_QWebHistory::clear):
- 4:40 AM Changeset in webkit [47817] by
-
- 2 edits in trunk/WebKit/qt
2009-08-27 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Cleanup, old and commented part of source code was removed.
Fix some formatting problems.
- Api/qwebhistory_p.h: (QWebHistoryPrivate::QWebHistoryPrivate):
- 4:18 AM Changeset in webkit [47816] by
-
- 2 edits in trunk/WebCore
2009-08-27 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Build fix, missing functions after r47763.
- platform/qt/Localizations.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
- 2:44 AM Changeset in webkit [47815] by
-
- 21 edits in trunk/LayoutTests
2009-08-27 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt]Update expecteds (t150*) in css2.1 and remove from Skipped. This affects 20 files.
- platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
- platform/qt/css2.1/t1504-c523-font-style-00-b-expected.txt:
- platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt:
- platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
- platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
- platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-01-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-02-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-09-b-expected.txt:
- platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
- 2:42 AM Changeset in webkit [47814] by
-
- 18 edits in trunk/LayoutTests
2009-08-27 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Update outdated font metrics in these css1 tests since we pass them.
- platform/qt/Skipped:
- platform/qt/css1/box_properties/clear-expected.txt:
- platform/qt/css1/box_properties/clear_float-expected.txt:
- platform/qt/css1/box_properties/float-expected.txt:
- platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
- platform/qt/css1/box_properties/float_margin-expected.txt:
- platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
- platform/qt/css1/box_properties/height-expected.txt:
- platform/qt/css1/box_properties/width-expected.txt:
- platform/qt/css1/cascade/cascade_order-expected.txt:
- platform/qt/css1/cascade/important-expected.txt:
- platform/qt/css1/classification/display-expected.txt:
- platform/qt/css1/classification/list_style-expected.txt:
- platform/qt/css1/classification/list_style_image-expected.txt:
- platform/qt/css1/classification/list_style_position-expected.txt:
- platform/qt/css1/classification/list_style_type-expected.txt:
- platform/qt/css1/classification/white_space-expected.txt:
- 2:07 AM Changeset in webkit [47813] by
-
- 2 edits in trunk/LayoutTests
2009-08-26 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Skip HTML5 input-list tests added in r47767.
- platform/qt/Skipped:
- 1:39 AM Changeset in webkit [47812] by
-
- 4 edits3 adds in trunk
'this' in JSON.parse reviver is the global object
https://bugs.webkit.org/show_bug.cgi?id=28752
Reviewed by Gavin Barraclough.
This is a technically simple change, we merely update the code for calling
the reviver function to pass the correct this object. Doing so however
exposes the holder to arbitrary mutation by the reviver function so it is
necessary for us to now guard all property accesses against the possibility
of failure.
- 12:26 AM Changeset in webkit [47811] by
-
- 3 edits in trunk
2009-08-27 Priit Laes <plaes@plaes.org>
Reviewed by Xan Lopez.
[GTK] Out-of-srcdir build problem
https://bugs.webkit.org/show_bug.cgi?id=28741
- GNUmakefile.am, autotools/webkit.m4: Fix problem with out-of-srcdir builds. Also bump required glib version.
Aug 26, 2009:
- 11:38 PM Changeset in webkit [47810] by
-
- 2 edits in trunk/WebKitTools
2009-08-26 Cameron McCormack <cam@mcc.id.au>
Reviewed by David Kilzer.
Make prepare-ChangeLog notice property changes
https://bugs.webkit.org/show_bug.cgi?id=28675
Make the generated ChangeLog entry include a short description of
property changes if there were such changes. Also make
prepare-ChangeLog not bail if the only changes are property changes.
- Scripts/prepare-ChangeLog:
- 11:33 PM Changeset in webkit [47809] by
-
- 6 edits4 adds in trunk/LayoutTests
2009-08-26 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Re-baselined and created new isolatedWorld tests to play nice with localStorage & sessionStorage.
https://bugs.webkit.org/show_bug.cgi?id=27992
- http/tests/security/isolatedWorld/all-window-properties.html: Re-baselined.
- http/tests/security/isolatedWorld/storage-properties-expected.txt: Added.
- http/tests/security/isolatedWorld/storage-properties.html: Added.
- http/tests/security/isolatedWorld/storage-prototype-expected.txt: Added.
- http/tests/security/isolatedWorld/storage-prototype.html: Added.
- platform/qtk/Skipped: Added new tests.
- platform/mac/Skipped: Added new tests.
- platform/qt/Skipped: Added new tests.
- platform/win/Skipped: Added new tests.
- 10:22 PM Changeset in webkit [47808] by
-
- 39 edits in trunk/WebCore
2009-08-26 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Removing trailing whitespaces from all storage classes.
- storage/ChangeVersionWrapper.cpp:
- storage/Database.cpp:
- storage/Database.h:
- storage/DatabaseDetails.h:
- storage/DatabaseThread.cpp:
- storage/DatabaseTracker.cpp:
- storage/DatabaseTracker.h:
- storage/LocalStorageTask.cpp:
- storage/LocalStorageTask.h:
- storage/LocalStorageThread.cpp:
- storage/LocalStorageThread.h:
- storage/OriginQuotaManager.cpp:
- storage/OriginUsageRecord.cpp:
- storage/OriginUsageRecord.h:
- storage/SQLError.h:
- storage/SQLResultSetRowList.h:
- storage/SQLStatement.cpp:
- storage/SQLStatement.h:
- storage/SQLStatementCallback.h:
- storage/SQLStatementErrorCallback.h:
- storage/SQLTransaction.cpp:
- storage/SQLTransaction.h:
- storage/SQLTransactionCallback.h:
- storage/SQLTransactionErrorCallback.h:
- storage/Storage.cpp:
- storage/Storage.h:
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp:
- storage/StorageAreaImpl.h:
- storage/StorageAreaSync.cpp:
- storage/StorageAreaSync.h:
- storage/StorageEvent.cpp:
- storage/StorageEvent.h:
- storage/StorageMap.cpp:
- storage/StorageMap.h:
- storage/StorageNamespaceImpl.cpp:
- storage/StorageSyncManager.cpp:
- storage/StorageSyncManager.h:
- 10:21 PM Changeset in webkit [47807] by
-
- 8 edits in trunk
2009-08-26 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
2009-08-26 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
2009-08-26 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
A bunch of our LayoutTests rely on our old behavior, so we explicitly
grant local files universal access during testing. Mainly, these tests
involve making XMLHttpRequests for data URLs.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 8:49 PM EFLWebKit edited by
- (diff)
- 7:45 PM Changeset in webkit [47806] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix: added some exported symbols
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 7:26 PM Changeset in webkit [47805] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28763, flickering when opacity changes.
Reviewed by Anders Carlsson.
Make opacity changes from < 1 to 1 and from 1 to < 1 cause a relayout to happen. We need
to do this in order for overflow information to be properly recomputed.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- 7:07 PM Changeset in webkit [47804] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix: Removed some exported symbols that no longer exist.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-26
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 7:02 PM Changeset in webkit [47803] by
-
- 2 edits in trunk/LayoutTests
2009-08-26 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (Build fix).
Fixup test after r47801: skip the first 'waiting' event because it is fired
when we call play() and there isn't enough media to begin playback immediately,
but we are interested in the 'waiting' event fired when the movie runs
out of loaded media.
- http/tests/media/video-play-stall-seek.html:
- 6:16 PM Changeset in webkit [47802] by
-
- 2 edits in trunk/JavaScriptCore
x86-64 GTK broken due to code offsets changing, pointers sometimes packed into immediates.
https://bugs.webkit.org/show_bug.cgi?id=28317
Reviewed by Olliejver Hunt.
We rely on a slightly OS X specific behaviour, that x86-64 applications have a 4Gb zero page,
so pointers are never representable as a 32-bit integer, and always have to be represented by
a separate immediate load instruction, rather than within the immediate field of an arithmetic
or memory operation.
We explicitly check for a couple of cases where a value might be representable in 32-bit, but
these probably never kick in on Mac OS, and only kick in to hose GTK. Deleting these does not
show a performance degradation on SunSpider. Remove.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::storePtr):
(JSC::MacroAssemblerX86_64::branchPtr):
- 5:47 PM Changeset in webkit [47801] by
-
- 7 edits2 adds in trunk
2009-08-26 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
HTMLMediaElement sometimes loses events
https://bugs.webkit.org/show_bug.cgi?id=28762
<rdar://problem/7172437>
A media element triggers the resource selection algorithm if
play() is called when the networkState attribute is NETWORK_EMPTY, but
it also immediately queues 'play' and either 'waiting' or 'playing' events.
One of the steps in preparing to load is to flush pending events, so those
events were lost if the load timer fired quickly enough. Fixed by deleting
pending events before scheduling the load timer.
Test: media/audio-play-event.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::scheduleLoad):
Do nothing if the load timer is already scheduled. Call prepareForLoad so queue of
pending events is flushed immediately.
(WebCore::HTMLMediaElement::scheduleNextSourceChild):
New, start the load timer without flushing pending events.
(WebCore::HTMLMediaElement::load):
Call prepareForLoad();
(WebCore::HTMLMediaElement::prepareForLoad):
New, load setup code moved from loadInternal.
(WebCore::HTMLMediaElement::loadInternal):
Moved some setup code to prepareForLoad so it can be invoked immediately before
arming the load timer.
(WebCore::HTMLMediaElement::setNetworkState):
Call scheduleNextSourceChild instead of scheduleLoad as the later now clears
pending events.
- html/HTMLMediaElement.h:
Declare scheduleNextSourceChild.
2009-08-26 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
HTMLMediaElement sometimes loses events
https://bugs.webkit.org/show_bug.cgi?id=28762
<rdar://problem/7172437>
- media/audio-play-event.html:
- media/audio-play-event-expected.txt:
Added.
- media/video-play-empty-events-expected.txt:
Updated results for previously missed events.
- media/video-src-remove.html:
- media/video-timeupdate-during-playback-expected.txt:
Restructured to make results less timing dependent.
- 5:35 PM QtWebKit edited by
- add OSX building instructions link (diff)
- 5:33 PM BuildingQtOnOSX edited by
- (diff)
- 5:32 PM BuildingQtOnOSX edited by
- (diff)
- 5:29 PM BuildingQtOnOSX edited by
- (diff)
- 4:40 PM BuildingOnWindows edited by
- Added notice about proper ordering of Cygwin\bin in the list of VC++ … (diff)
- 4:40 PM Changeset in webkit [47800] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28751
Switch ICO decoder from a Vector of raw pointers to a Vector of
OwnPtrs now that that is possible. Makes code slightly simpler.
Reviewed by Eric Seidel.
- platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectory):
- platform/image-decoders/ico/ICOImageDecoder.h:
- 4:00 PM Changeset in webkit [47799] by
-
- 12 edits in trunk/JavaScriptCore
A bit of Collector refatoring.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-26
Reviewed by Oliver Hunt.
SunSpider says no change. v8 says 1.003x faster (1.02x faster on splay).
- JavaScriptCore.exp:
- runtime/JSCell.cpp:
(JSC::JSCell::toPrimitive):
(JSC::JSCell::getPrimitiveNumber):
(JSC::JSCell::toBoolean):
(JSC::JSCell::toNumber):
(JSC::JSCell::toString):
(JSC::JSCell::toObject): Removed pure virtual functions from
JSCell, so the collector can construct one. This allowed
me to remove a bunch of ASSERT_NOT_REACHED throughout the
code, too.
- runtime/JSCell.h:
(JSC::JSCell::JSCell): ditto
(JSC::Heap::heap): Inlined this function because it's trivial.
- JavaScriptCore.exp:
- runtime/Collector.cpp:
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks): Renamed freeHeap to freeBlocks, since
it doesn't actually free the Heap object.
(JSC::Heap::heapAllocate):
(JSC::Heap::sweep):
- runtime/Collector.h: Refactored block allocation and destruction
into helper functions.
- runtime/GetterSetter.cpp:
- runtime/JSAPIValueWrapper.cpp:
- runtime/JSPropertyNameIterator.cpp: Removed dummy implementations
of pure virtual functions. (See above.)
- 3:30 PM Changeset in webkit [47798] by
-
- 3 edits4 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=28718, image inside relpositioned inline doesn't paint.
Make sure vertical overflow is still computed across self-painting layers, even though it isn't
propagated to parents.
Reviewed by Dan Bernstein.
Added fast/repaint/rel-positioned-inline-with-overflow.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeVerticalOverflow):
LayoutTests: Add layout test for relpositioned inline regression.
Reviewed by Dan Bernstein.
- fast/repaint/rel-positioned-inline-with-overflow.html: Added.
- platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum: Added.
- platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
- platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.txt: Added.
- 2:57 PM Changeset in webkit [47797] by
-
- 10 edits in trunk
WebCore: ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
https://bugs.webkit.org/show_bug.cgi?id=28735
Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Darin Fisher.
Renaming the method to imply its wider implications of affecting cookies
over any protocol that supports them.
No change in functionality so no new tests.
- WebCore.order:
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
(WebCore::ResourceRequestBase::allowCookies):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::equalIgnoringHeaderFields):
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateFromSoupMessage):
WebKit/win: ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
https://bugs.webkit.org/show_bug.cgi?id=28735
Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Darin Fisher.
- WebMutableURLRequest.cpp:
(WebMutableURLRequest::setHTTPShouldHandleCookies):
- 2:54 PM Changeset in webkit [47796] by
-
- 4 edits4 adds in trunk
WebCore:
Made RenderInline::clippedOverflowRectForRepaint() actually include
overflow.
Reviewed by Dave Hyatt.
Test: fast/repaint/inline-overflow.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisibleOverflowBoundingBox): Added. Returns
the bounding box of all lines’ visible overflow boxes (under the
assumption that the first and last lines determine the top and
bottom, respectively).
(WebCore::RenderInline::clippedOverflowRectForRepaint): Changed to use
linesVisibleOverflowBoundingBox() instead of linesBoundingBox().
- rendering/RenderInline.h:
LayoutTests:
Test that RenderInline::clippedOverflowRectForRepaint() actually
includes overflow.
Reviewed by Dave Hyatt.
- fast/repaint/inline-overflow-expected.checksum: Added.
- fast/repaint/inline-overflow-expected.png: Added.
- fast/repaint/inline-overflow-expected.txt: Added.
- fast/repaint/inline-overflow.html: Added.
- 2:33 PM Changeset in webkit [47795] by
-
- 3 edits in trunk/JavaScriptCore
End re-roll-in of r47738:47740 with Windows crash fixed
2009-08-26 Geoffrey Garen <ggaren@apple.com>
Build fix: start out with a 32-bit value to avoid a shortening warning.
- runtime/Collector.cpp: (JSC::Heap::sweep):
2009-08-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Substantially reduced VM thrash in the GC heap.
1.08x faster on v8 (1.60x faster on v8-splay).
1.40x faster on bench-alloc-nonretained.
1.90x faster on bench-alloc-retained.
SunSpider says no change.
- runtime/Collector.cpp: (JSC::Heap::heapAllocate): Fixed a long-standing bug: update a few local variables unconditionally after calling collect(), since they may be used even if we don't "goto scan". (In the bug I saw, usedBlocks got out of sync with heap.usedBlocks). (JSC::Heap::sweep): Keep enough free heap space to accomodate the number of objects we'll allocate before the next GC, plus 25%, for good measure.
- runtime/Collector.h: Bumped the block size to 256k. This seems to give the best cache performance, and it prevents us from initiating lots of VM traffic to recover very small chunks of memory.
Begin re-roll-in of r47738:47740 with Windows crash fixed
- 2:26 PM Changeset in webkit [47794] by
-
- 1 edit1 add in trunk/LayoutTests
Follow-up to http://trac.webkit.org/changeset/47790. Add windows
specific results that are the same as the results next to the test,
since windows falls back on platform/mac.
Patch by Julie Parent <jparent@chromium.org> on 2009-08-26
Reviewed by Maciej Stachowiak.
- platform/win/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.
- 2:25 PM BuildingQtOnOSX created by
- Initial Page for OSX build instructions
- 1:47 PM Changeset in webkit [47793] by
-
- 6 edits in trunk
WebCore: minor style correction and include fix for notifications
https://bugs.webkit.org/show_bug.cgi?id=28745
Patch by John Gregg <johnnyg@google.com> on 2009-08-26
Reviewed by David Levin.
No change in behavior, so no tests.
- bindings/js/JSDesktopNotificationsCustom.cpp: add include of Error.h
- notifications/Notification.cpp: change enum style to InterCaps
(WebCore::Notification::Notification):
- notifications/NotificationPresenter.h:
(WebCore::NotificationPresenter::):
WebKitTools: Minor style correction and include fix for notifications
https://bugs.webkit.org/show_bug.cgi?id=28745
Patch by John Gregg <johnnyg@google.com> on 2009-08-26
Reviewed by David Levin.
- DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: change to correct EnumStyle
(DRTDesktopNotificationPresenter::checkNotificationPermission):
- 1:45 PM Changeset in webkit [47792] by
-
- 14 edits1 copy2 adds in trunk
WebKitTools: XMLHttpRequest.withCredentials=false shouldn't save cookies.
https://bugs.webkit.org/show_bug.cgi?id=28743
Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Alexey Proskuryakov.
Added the support to the layout test controller on OSX and
Windows (for CFNETWORK) to allow for changing the accept cookie
policy.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Added a bool
to track the state of accepting cookies.
(setAlwaysAcceptCookiesCallback): Standard wrapper method
to go from js to a C++ method.
(LayoutTestController::staticFunctions): Added the
setAlwaysAcceptCookies method to the js layoutTestController.
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::alwaysAcceptCookies): Returns the value.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setAlwaysAcceptCookies): Stub out method.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues): Reset the accept cookie to
its default.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setAlwaysAcceptCookies): Does the work for
OSX to change the cookie accept policy.
- DumpRenderTree/win/DumpRenderTree.cpp:
(setAlwaysAcceptCookies): Method to handle all the calls necessary
to change the accept cookie policy on Windows.
(resetDefaultsToConsistentValues): Reset the accept cookie to
its default.
- DumpRenderTree/win/DumpRenderTreeWin.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setAlwaysAcceptCookies): Stub out method.
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setAlwaysAcceptCookies): Stub out method.
LayoutTests: XMLHttpRequest.withCredentials=false shouldn't save cookies.
https://bugs.webkit.org/show_bug.cgi?id=28743
Patch by David Levin <levin@chromium.org> on 2009-08-26
Reviewed by Alexey Proskuryakov.
Added a test to verify that XMLHttpRequest.withCredentials=false doesn't
save cookies.
- http/tests/xmlhttprequest/cross-origin-cookie-storage-expected.txt: Added.
- http/tests/xmlhttprequest/cross-origin-cookie-storage.html: Added.
- http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php: Added.
- http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added the ability
to check for a cookie by name.
- platform/gtk/Skipped: Skip the new test.
- platform/qt/Skipped: Ditto.
- 1:45 PM Changeset in webkit [47791] by
-
- 20 edits in trunk
JavaScriptCore: postMessage() spec now supports sending arrays of ports
https://bugs.webkit.org/show_bug.cgi?id=26902
Reviewed by David Levin.
Added OwnPtr to VectorTraits so we can store OwnPtrs in Vectors.
- wtf/VectorTraits.h:
WebCore: postMessage() spec now supports sending arrays of ports
https://bugs.webkit.org/show_bug.cgi?id=26902
Reviewed by David Levin.
Added support for sending multiple ports at once via postMessage(). JS bindings will be updated in an upcoming patch.
No new tests, since the new functionality is not exposed via new JS bindings yet, so the old tests suffice.
- WebCore.xcodeproj/project.pbxproj:
Mark MessagePort.h and MessagePortChannel.h as private since they are used by WebKit now.
- dom/MessageEvent.cpp:
Updated APIs to support passing MessagePortArrays.
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::messagePort):
- dom/MessageEvent.h:
(WebCore::MessageEvent::create):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::MessageEvent::ports):
- dom/MessagePort.cpp:
(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
Added new static function to extract a MessagePortChannelArray from a MessagePortArray.
(WebCore::MessagePort::entanglePorts):
Added new static function to generate a MessagePortArray (entangled ports) from a MessagePortChannelArray.
- dom/MessagePort.h:
- dom/MessagePortChannel.cpp:
EventData now contains a MessagePortChannelArray field instead of a single MessagePortChannel.
(WebCore::MessagePortChannel::EventData::create):
(WebCore::MessagePortChannel::EventData::EventData):
- dom/MessagePortChannel.h:
(WebCore::MessagePortChannel::EventData::channels):
- page/DOMWindow.cpp:
(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
- page/DOMWindow.h:
- workers/DedicatedWorkerContext.cpp:
(WebCore::DedicatedWorkerContext::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::DedicatedWorkerContext::dispatchMessage):
- workers/DedicatedWorkerContext.h:
- workers/Worker.cpp:
(WebCore::Worker::postMessage):
Now accepts a MessagePortArray parameter instead of a single MessagePort.
(WebCore::Worker::dispatchMessage):
- workers/Worker.h:
- workers/WorkerContextProxy.h:
- workers/WorkerMessagingProxy.cpp:
Updated WorkerObjectProxy and WorkerContextProxy API implementations to support sending multiple MessagePorts.
(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerContextTask::MessageWorkerContextTask):
(WebCore::MessageWorkerContextTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::MessageWorkerTask):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
- workers/WorkerMessagingProxy.h:
- workers/WorkerObjectProxy.h:
Updated WorkerObjectProxy and WorkerContextProxy APIs to support sending multiple MessagePorts.
- 1:26 PM Changeset in webkit [47790] by
-
- 3 edits1 add in trunk/LayoutTests
Add Mac specific results for xhr-missing-file-expection test since it
incorrectly always has statusText of "OK" due to
https://bugs.webkit.org/show_bug.cgi?id=24572 and update the results
that are next to the file to use "Not Found" since that is more correct
and matches IE, FF, Chrome.
Patch by Julie Parent <jparent@chromium.org> on 2009-08-26
Reviewed by Alex Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=28723
- http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt:
- platform/mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.
- platform/win/Skipped: Stop skipping the test.
- 1:25 PM Changeset in webkit [47789] by
-
- 2 edits in trunk/WebKitTools
2009-08-26 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed.
Remove accidentally left in clobber option.
https://bugs.webkit.org/show_bug.cgi?id=28400
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
- 1:05 PM Changeset in webkit [47788] by
-
- 3 edits11 adds in trunk/WebCore
2009-08-26 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
SocketStreamHandle interface for WebSocket API
https://bugs.webkit.org/show_bug.cgi?id=28037
Add build systems only for GNUmakefile.am and WebCore.xcodeproj.now.
Other build systems will be updated once the code is functional.
Tests will be landed once this code is complete and functional.
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/SocketStreamErrorBase.cpp: Added.
- platform/network/SocketStreamErrorBase.h: Added.
- platform/network/SocketStreamHandleBase.cpp: Added.
- platform/network/SocketStreamHandleBase.h: Added.
- platform/network/SocketStreamHandleClient.h: Added.
- platform/network/cf/SocketStreamError.h: Added.
- platform/network/cf/SocketStreamHandle.h: Added.
- platform/network/cf/SocketStreamHandleCFNet.cpp: Added.
- platform/network/soup/SocketStreamError.h: Added.
- platform/network/soup/SocketStreamHandle.h: Added.
- platform/network/soup/SocketStreamHandleSoup.cpp: Added.
- 1:04 PM Changeset in webkit [47787] by
-
- 3 edits in trunk/WebKitTools
2009-08-17 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Mark Rowe.
Add canary-style Chromium WebKit build slave to the waterfall.
https://bugs.webkit.org/show_bug.cgi?id=28400
- BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
- 12:55 PM Changeset in webkit [47786] by
-
- 2 edits in trunk/WebCore
2009-08-26 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] setTimeout does not convert non-string argument to string
https://bugs.webkit.org/show_bug.cgi?id=28739
Convert non-string argument to setTimeout to string in the V8
bindings.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
- 11:48 AM Changeset in webkit [47785] by
-
- 3 edits in trunk/WebKitSite
Upgrade WordPress to the latest version.
- blog/wp-includes/version.php:
- blog/wp-login.php:
- 11:08 AM Changeset in webkit [47784] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-26 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Remove duplicated files from file list.
- GNUmakefile.am:
- 10:40 AM Changeset in webkit [47783] by
-
- 3 edits in trunk/JavaScriptCore
More export fixes.
- 10:33 AM Changeset in webkit [47782] by
-
- 3 edits in trunk/JavaScriptCore
Hopefully fix all the exports from JSC on windows
- 10:12 AM Changeset in webkit [47781] by
-
- 6 edits in trunk/JavaScriptCore
Build fix
- 9:52 AM Changeset in webkit [47780] by
-
- 69 edits1 copy4 adds in trunk
[ES5] Implement getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=28724
Reviewed by Gavin Barraclough.
JavaScriptCore:
Implement the core runtime support for getOwnPropertyDescriptor.
This adds a virtual getOwnPropertyDescriptor method to every class
that implements getOwnPropertySlot that shadows the behaviour of
getOwnPropertySlot. The alternative would be to make getOwnPropertySlot
(or PropertySlots in general) provide property attribute information,
but quick testing showed this to be a regression.
WebCore:
Implement the WebCore side of getOwnPropertyDescriptor. This
requires a custom implementation of getOwnPropertyDescriptor
for every class with a custom implementation of getOwnPropertySlot.
The bindings generator has been updated to generate appropriate
versions of getOwnPropertyDescriptor for the general case where
a custom getOwnPropertyDescriptor is not needed. ES5 is vague
about how getOwnPropertyDescriptor should work in the context of
"host" functions with polymorphic GetOwnProperty, so it seems
okay that occasionally we "guess" what attributes -- eg. determining
whether a property is writable.
Test: fast/js/getOwnPropertyDescriptor.html
- 7:08 AM Changeset in webkit [47779] by
-
- 2 edits in trunk/WebCore
2009-08-26 Vincent Untz <vuntz@gnome.org>
Reviewed by Xan Lopez.
GObject checks for NULL (and not 0) in g_object_get, so use that
as we were already doing elsewhere to make the compiler happy.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasAudio):
- 7:06 AM Changeset in webkit [47778] by
-
- 2 edits in trunk/WebCore
2009-08-26 Alpha Lam <hclam@chromium.org>
Reviewed by David Levin.
RenderThemeMac.mm has incorrect casting for media control element.
https://bugs.webkit.org/show_bug.cgi?id=28730
MediaControlMuteButtonElement was incorrectly casted to
MediaControlPlayButtonElement. This is corrected in this patch.
No new tests because this is code cleanup and is already covered by existing
media layout tests.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaMuteButton):
- 6:56 AM Changeset in webkit [47777] by
-
- 2 edits in trunk/WebCore
2009-08-26 Robert Sesek <rsesek@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Multi-value select boxes cannot do non-contiguous selection on Mac
https://bugs.webkit.org/show_bug.cgi?id=28670
Change the condition regarding the key modifier check for non-contiguous
selection on a multi-value list from just PLATFORM(MAC) to
PLATFORM(MAC) (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)). No new tests. This patch only changes the condition on which a certain mouse
event modifier key is used.
- dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
- 6:31 AM Changeset in webkit [47776] by
-
- 4 edits in trunk/WebKit/gtk
2009-08-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=28738
Expose undo/redo functionality in WebKitWebView
Expose undo/redo functionality in WebKitWebView, keeping the
default bindings as they were.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::):
- webkit/webkitwebview.cpp: (webkit_web_view_real_undo): (webkit_web_view_real_redo): (webkit_web_view_class_init): (webkit_web_view_can_undo): (webkit_web_view_undo): (webkit_web_view_can_redo): (webkit_web_view_redo):
- webkit/webkitwebview.h:
- 12:46 AM Changeset in webkit [47775] by
-
- 7 edits in trunk/JavaScriptCore
How many copies of the parameters do you need?
https://bugs.webkit.org/show_bug.cgi?id=28701
Reviewed by Darin Adler.
The function parameters in JSC get copied a lot - and unnecessarily so.
Originally this happened due to duplicating FunctionBodyNodes on recompilation,
though the problem has been exacerbated by copying the parameters from the
original function body onto the executable, then back onto the real body that
will be generated (this happens on every function). And this is all made worse
since the data structures in question are a little ugly - C style arrays of C++
objects containing ref counts, so they need a full copy-construct (rather than
a simple memcpy).
This can all be greatly simplified by just punting the parameters off into
their own ref-counted object, and forgoing all the copying.
~no performance change, possible slight progression.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
- parser/Nodes.cpp:
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::finishParsing):
- parser/Nodes.h:
(JSC::FunctionBodyNode::parameters):
(JSC::FunctionBodyNode::parameterCount):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compile):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::paramString):
- runtime/Executable.h:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::parameterCount):
