Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 21, 2009:

7:39 PM Changeset in webkit [51291] by Joseph Pecoraro

• 2 edits in trunk/WebCore

2009-11-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Support Ctrl+P and Ctrl+N, Readline keyboard shortcuts in the Console
​https://bugs.webkit.org/show_bug.cgi?id=31400

Handle the following when on a Mac:

Ctrl+P = Previous (like Up arrow)
Ctrl+N = Next (like Down arrow)

No longer rerun autocompletion when just pushing a modifier key
like Control, Alt, Shift, or Meta.

Improved arrow key behavior with Multiline code in the Console, with the following behavior:

Up = Previous Command if on First Line (caret moves to the end of the first line)

otherwise default caret movement in text.

Down = Next Command if on Last Line (caret naturally moves to the end)

otherwise default caret movement in text.

• inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.handleKeyEvent): handle new keyboard shortcuts (WebInspector.TextPrompt.prototype.isCaretOnFirstLine): check if the caret is on the top line (WebInspector.TextPrompt.prototype.isCaretOnLastLine): check if the caret is on the bottom line (WebInspector.TextPrompt.prototype._upKeyPressed): (WebInspector.TextPrompt.prototype._downKeyPressed): (WebInspector.TextPrompt.prototype._moveBackInHistory): (WebInspector.TextPrompt.prototype._moveForwardInHistory):

7:04 PM Changeset in webkit [51290] by jberlin@webkit.org

• 2 edits in trunk/WebCore

Adds a tooltip containing the full url of the resource to each element
in the Resources panel so that it is possible to quickly see the query
parameters.
​https://bugs.webkit.org/show_bug.cgi?id=19103

Reviewed by Timothy Hatcher.

• inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourceSidebarTreeElement.prototype.refresh):
Set the tooltip to be the resource's url.

4:18 PM Changeset in webkit [51289] by Simon Fraser

• 5 edits in trunk

2009-11-21 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
​https://bugs.webkit.org/show_bug.cgi?id=31588

In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
so that findRule() and deleteRule() work with these keywords.

• css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::findRuleIndex):

3:13 PM Changeset in webkit [51288] by eric@webkit.org

• 2 edits in trunk/JavaScriptCore

2009-11-21 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt][Mac] Turn on multiple JavaScript threads for QtWebkit on Mac
​https://bugs.webkit.org/show_bug.cgi?id=31753

• wtf/Platform.h:

1:34 PM Changeset in webkit [51287] by eric@webkit.org

• 8 edits in trunk/WebKitTools

2009-11-21 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool --help spews way too much text
​https://bugs.webkit.org/show_bug.cgi?id=31771

• Scripts/bugzilla-tool:
  • Remove self.cached_scm initialization hack.
• Scripts/modules/buildbot.py:
  • Make default_host accessible to callers.
• Scripts/modules/commands/download.py:
  • Phrase help for all commands consistently and remove spurious help text punctuation.
• Scripts/modules/commands/queries.py: Ditto.
• Scripts/modules/commands/queues.py: Ditto.
• Scripts/modules/commands/upload.py: Ditto.
• Scripts/modules/multicommandtool.py:
  • Add HelpPrintingOptionParser.format_epilog to replace NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
  • Make --help only show a list of commands like "svn help" and "git help" do -- previously --help was listing all commands and options.
  • Sort list of commands alphabetically.

1:32 PM Changeset in webkit [51286] by jhoneycutt@apple.com

• 2 edits in trunk/WebKit/win

2009-11-21 Jon Honeycutt <​jhoneycutt@apple.com>

Windows build fix. Unreviewed.

• Interfaces/IWebSerializedJSValue.idl:

1:26 PM Changeset in webkit [51285] by eric@webkit.org

• 3 edits in trunk/WebCore

2009-11-21 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31647

Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.

No functionality was changed. So, no new tests.

• dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::~KeyboardEvent):
• dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr. (WebCore::KeyboardEvent::keyEvent):

1:12 PM Changeset in webkit [51284] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-21 Eric Seidel <​eric@webkit.org>

No review. Fixing a typo from the previous patch for bug 31767.

AbstractQueue.run_bugzilla_tool throws an exception
​https://bugs.webkit.org/show_bug.cgi?id=31769

• Scripts/modules/commands/queues.py:

7:50 AM Changeset in webkit [51283] by eric@webkit.org

• 5 edits in trunk/WebKitTools

2009-11-21 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
​https://bugs.webkit.org/show_bug.cgi?id=31767

What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
Since we don't have a good way to test BugzillaTool pieces, I've
left out a test for now.

• Scripts/bugzilla-tool:
  • Add a path() implementation to expose bugzilla-tool's file path to commit-queue.
• Scripts/modules/commands/queues.py:
  • Use tool.path() instead of file.
• Scripts/modules/multicommandtool.py:
  • Add a new path() method to MultiComandTool.
• Scripts/modules/multicommandtool_unittest.py:
  • Provide a path() method. Little point in testing this mock implementation.

7:37 AM Changeset in webkit [51282] by abarth@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-21 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix. Turns out I was testing the wrong copy of
WebKitTools.

• Scripts/modules/commands/download.py:

7:29 AM Changeset in webkit [51281] by abarth@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Convert check-style to use LandingSequence
​https://bugs.webkit.org/show_bug.cgi?id=31763

Instead of manipulating the working copy by hand, we should use the
LandingSequence in CheckStyle. This will make this code eaiser to
test.

• Scripts/modules/commands/download.py:

12:53 AM Web Inspector Update.ja edited by keishi@webkit.org

(diff)

12:52 AM WebKit nightlies support HTML5 noreferrer link relation.ja created by keishi@webkit.org

12:50 AM Web Inspector Update.ja edited by keishi@webkit.org

(diff)

12:48 AM Surfin' Safari Translations edited by keishi@webkit.org

(diff)

Nov 20, 2009:

8:50 PM Changeset in webkit [51280] by jhoneycutt@apple.com

• 2 edits in trunk/WebKit/win

DOMElement::tagName() is unimplemented

​https://bugs.webkit.org/show_bug.cgi?id=31746

Reviewed by Darin Adler.

• DOMCoreClasses.cpp:

(DOMElement::tagName):
Create a BString from the element's tag name, and release its BSTR
into result.

8:50 PM Changeset in webkit [51279] by jhoneycutt@apple.com

• 2 edits in trunk/WebKit/win

DOMNode::childNodes() is unimplemented

​https://bugs.webkit.org/show_bug.cgi?id=31745

Reviewed by Darin Adler.

• DOMCoreClasses.cpp:

(DOMNode::childNodes):
Create a DOMNodeList from the node's child nodes.

8:06 PM Changeset in webkit [51278] by abarth@webkit.org

• 2 edits
  2 copies in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Unit test query commands
​https://bugs.webkit.org/show_bug.cgi?id=31755

These tests are pretty rough, but hopefully they'll grow.

• Scripts/modules/commands/queries_unittest.py: Added.
• Scripts/modules/mock_bugzillatool.py: Added.
• Scripts/run-webkit-unittests:

7:53 PM Changeset in webkit [51277] by abarth@webkit.org

• 6 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
​https://bugs.webkit.org/show_bug.cgi?id=31758

• Scripts/modules/multicommandtool.py:
  • Allow passing of explicit commands to MultiCommandTool.init
• Scripts/modules/multicommandtool_unittest.py:
  • Use new Command.name naming system.
  • Test Command auto-discovery.
• Scripts/modules/workqueue.py:
  • bug_id no longer exists, use patchbug_id instead.
• Scripts/modules/workqueue_unittest.py:
  • WorkQueues require names now.
  • should_proceed_with_work_item must return a patch object.

7:29 PM Changeset in webkit [51276] by Chris Fleizach

• 13 edits
  2 adds in trunk

WAI-ARIA: add support for aria-owns
​https://bugs.webkit.org/show_bug.cgi?id=31702

Reviewed by Beth Dakin.

WebCore:

Re-organized how accessibilityAttributeNames are returned so
that it's possible for an element to add an attribute based on
a dynamic value. In this case, we only want to add AXOwn if the
element actually supports aria-owns.

Test: platform/mac/accessibility/aria-owns.html

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::supportsARIAOwns):
(WebCore::AccessibilityObject::ariaOwnsElements):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaOwnsElements):
(WebCore::AccessibilityRenderObject::supportsARIAOwns):

• accessibility/AccessibilityRenderObject.h:
• accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

• html/HTMLAttributeNames.in:

WebKitTools:

• DumpRenderTree/AccessibilityUIElement.cpp:

(ariaOwnsElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):

• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::ariaOwnsElementAtIndex):

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::ariaOwnsElementAtIndex):

• DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::ariaOwnsElementAtIndex):

LayoutTests:

• platform/mac/accessibility/aria-owns-expected.txt: Added.
• platform/mac/accessibility/aria-owns.html: Added.

7:14 PM Changeset in webkit [51275] by eric@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix exception thrown when running the commit-queue.

• Scripts/modules/statusbot.py: patch is optional.
• Scripts/modules/workqueue.py: WorkQUeue requires a name.

6:54 PM Changeset in webkit [51274] by hyatt@apple.com

• 4 edits in trunk/WebKit/win

Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
serialization into a separate serialize() function that can be called after the object has been
created.

Reviewed by Jon Honeycutt.

Fix a typo in serialize() caused when fixing build bustage (put a ! back in).

• Interfaces/IWebSerializedJSValue.idl:
• WebSerializedJSValue.cpp:

(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::serialize):
(WebSerializedJSValue::deserialize):

• WebSerializedJSValue.h:

6:36 PM Changeset in webkit [51273] by bweinstein@apple.com

• 7 edits in trunk/WebKit/win

Another go at the Windows Build Fix - this is a couple steps of it,
so a little more involved than most build fixes.

Reviewed by Dave Hyatt.

• Interfaces/IWebSerializedJSValue.idl:
• Interfaces/JavaScriptCoreAPITypes.idl:
• WebKit.vcproj/Interfaces.vcproj:
• WebSerializedJSValue.cpp:

(WebSerializedJSValue::deserialize):

• WebSerializedJSValue.h:

6:07 PM Changeset in webkit [51272] by hyatt@apple.com

• 2 edits in trunk/WebKit/mac

Make sure to export WebSerializedJSValue.

Reviewed by Darin Adler.

• WebKit.exp:

5:54 PM Changeset in webkit [51271] by bweinstein@apple.com

• 5 edits
  1 add in trunk/WebKit/win

Build fix for Windows - only declare JSContextRef once, instead
of in two different idl files. Create a new file to hold the
definition of JSContextRef.

Reviewed by Dave Hyatt.

• Interfaces/IWebFrameLoadDelegate.idl:
• Interfaces/IWebSerializedJSValue.idl:
• Interfaces/JavaScriptCoreAPITypes.idl: Added.
• Interfaces/WebKit.idl:
• WebKit.vcproj/Interfaces.vcproj:

5:44 PM Changeset in webkit [51270] by eric.carlson@apple.com

• 12 edits in trunk

2009-11-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

• css/mediaControls.css:

Define closed caption toggle button.

• rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):

Create closed caption toggle button in display order.

• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):

Don't require MediaControllerThemeQuickTime theme for captions toggle button.
No need to check if the movie has video, a closed captions track is a video
track.

2009-11-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceLeopard.a:
• libWebKitSystemInterfaceSnowLeopard.a:
• libWebKitSystemInterfaceTiger.a:

2009-11-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

Remove closed captions test from skipped list.

• platform/mac-leopard/Skipped:
• platform/mac-tiger/Skipped:

5:34 PM Changeset in webkit [51269] by jianli@chromium.org

• 3 edits in trunk/WebKit/chromium

Not reviewed. Fix chromium build.

• public/WebAccessibilityRole.h:

(WebKit::):

• src/AssertMatchingEnums.cpp:

5:18 PM Changeset in webkit [51268] by Joseph Pecoraro

• 2 edits in trunk/WebCore

2009-11-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Running code in the Console that ends with a
single line comment no longer produces a parse error.

• inspector/front-end/InjectedScript.js: (InjectedScript._evaluateOn):

5:17 PM Changeset in webkit [51267] by hyatt@apple.com

• 6 edits
  5 adds in trunk/WebKit

Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore
and exposes the ability to do JS value serialization/deserialization to WebKit clients.

Reviewed by Oliver Hunt and Jon Honeycutt.

WebKit:

• WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

• WebView/WebSerializedJSValue.h: Added.
• WebView/WebSerializedJSValue.mm: Added.

(-[WebSerializedJSValue initWithValue:context:]):
(-[WebSerializedJSValue deserialize:]):
(-[WebSerializedJSValue dealloc]):

WebKit/win:

• Interfaces/IWebSerializedJSValue.idl: Added.
• Interfaces/WebKit.idl:
• WebKit.vcproj/WebKit.vcproj:
• WebSerializedJSValue.cpp: Added.

(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::AddRef):
(WebSerializedJSValue::Release):
(WebSerializedJSValue::QueryInterface):
(WebSerializedJSValue::deserialize):

• WebSerializedJSValue.h: Added.

5:15 PM Changeset in webkit [51266] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach the StatusBot how to support more than just the commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=31754

• Scripts/modules/workqueue.py: Another typo.

5:09 PM Changeset in webkit [51265] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach the StatusBot how to support more than just the commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=31754

• Scripts/modules/commands/queues.py: Fix silly typo.

5:02 PM Changeset in webkit [51264] by eric@webkit.org

• 7 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach the StatusBot how to support more than just the commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=31754

• CommitQueueStatus/index.yaml:
  • Add indices required for the new queries.
• CommitQueueStatus/queue_status.py:
  • Add a patch-status page and move update_status to update-status.
  • Only display "commit-queue" status records for the commit-queue.
  • Add support for a queue_name property on status records.
  • Fix _int_from_request to actually work.
• CommitQueueStatus/update_status.html:
  • Add support for a queue_name on status records.
  • Remove unused list of bug ids.
  • Scripts/modules/commands/queues.py
    • Make the queues pass the patch instead of the bug_id to StatusBot.
• Scripts/modules/statusbot.py:
  • Support passing the queue_name to the status updates.
  • Support fetching patch status with patch_status().
• Scripts/modules/workqueue.py:
  • Pass the patch to the StatusBot instead of the bug_id.
  • Let WorkQueues have a name.

4:15 PM Changeset in webkit [51263] by abarth@webkit.org

• 2 edits
  7 adds in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move bugzilla-tool commands into their own file
​https://bugs.webkit.org/show_bug.cgi?id=31752

This will let us write unit tests.

• Scripts/bugzilla-tool:
• Scripts/modules/commands/init.py: Added.
• Scripts/modules/commands/download.py: Added.
• Scripts/modules/commands/queries.py: Added.
• Scripts/modules/commands/queues.py: Added.
• Scripts/modules/commands/upload.py: Added.
• Scripts/modules/grammar.py: Added.

4:00 PM Changeset in webkit [51262] by eric@webkit.org

• 12 edits in trunk

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
​https://bugs.webkit.org/show_bug.cgi?id=31706

• platform/mac/accessibility/aria-grouping-roles-expected.txt:
• platform/mac/accessibility/aria-grouping-roles.html:

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
​https://bugs.webkit.org/show_bug.cgi?id=31706

• accessibility/AccessibilityObject.cpp:
• accessibility/AccessibilityObject.h:
• accessibility/mac/AccessibilityObjectWrapper.mm:

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
​https://bugs.webkit.org/show_bug.cgi?id=31706

• English.lproj/Localizable.strings:
• StringsNotToBeLocalized.txt:

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
​https://bugs.webkit.org/show_bug.cgi?id=31706

• WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory AXARIAContentGroupText:]):

2:54 PM Changeset in webkit [51261] by abarth@webkit.org

• 1 edit in trunk/WebKitTools/ChangeLog

Fix ChangeLog

2:52 PM Changeset in webkit [51260] by abarth@webkit.org

• 4 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.
Reviewed by Eric Seidel.

BuildQueue should check if the tree is currently buildable
​https://bugs.webkit.org/show_bug.cgi?id=31744

• Scripts/bugzilla-tool:
• Scripts/modules/landingsequence.py:
• Scripts/modules/webkitlandingscripts.py:

2:51 PM Changeset in webkit [51259] by abarth@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move prepare_clean_working_directory into the LandingSequence
​https://bugs.webkit.org/show_bug.cgi?id=31743

• Scripts/bugzilla-tool:
• Scripts/modules/landingsequence.py:

2:34 PM Changeset in webkit [51258] by yael.aharon@nokia.com

• 3 edits in trunk/LayoutTests

Unreviewed fix.

Fix file names in the skipped list, for files added in ​http://trac.webkit.org/changeset/51257.

1:40 PM Changeset in webkit [51257] by yael.aharon@nokia.com

• 7 edits
  4 adds in trunk

NPN_ReloadPlugins does not reload the page even if reloadPages is true.
​https://bugs.webkit.org/show_bug.cgi?id=30460

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
It already refreshes plugins and reloads pages when necessary.

Tests: plugins/reloadplugins-and-pages.html

plugins/reloadplugins-no-pages.html

• plugins/PluginInfoStore.cpp:

(WebCore::refreshPlugins):

WebKitTools:

Added code for calling NPN_ReloadPlugins with reloadPages true and false.

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:

(pluginInvoke):

LayoutTests:

Added tests for calling NPN_ReloadPlugins with reloadPages being true and false.

1:32 PM Changeset in webkit [51256] by oliver@apple.com

• 4 edits in trunk/WebCore

<rdar://7409188> WebKit needs to be able to serialize and deserialize objects.

Reviewed by Dave Hyatt.

Expose WebCore object serialization to WebKit.

1:29 PM Changeset in webkit [51255] by bweinstein@apple.com

• 2 edits in trunk/WebCore

Fixes <​http://webkit.org/b/31741>.
Web Inspector: User Entered Data on the console should show up no matter what filters.

Reviewed by Tim Hatcher.

Always show .console-user-command-result, no matter what the filter say
we should do with the other classes.

• inspector/front-end/inspector.css:

1:29 PM Changeset in webkit [51254] by ap@apple.com

• 1 edit
  2 adds in trunk/LayoutTests

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25381
Needs test: jQuery animation crashing Safari

Adding a regression test for a bug that doesn't reproduce in ToT.

• fast/dynamic/jQuery-animation-crash-expected.txt: Added.
• fast/dynamic/jQuery-animation-crash.html: Added.

1:03 PM Changeset in webkit [51253] by abarth@webkit.org

• 5 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Pass the port information to the child process
​https://bugs.webkit.org/show_bug.cgi?id=31736

We need to do this so the child process knows what to build!

• Scripts/bugzilla-tool:
• Scripts/modules/landingsequence.py:
• Scripts/modules/webkitport.py:
• Scripts/modules/webkitport_unittest.py:

12:26 PM Changeset in webkit [51252] by ap@apple.com

• 2 edits in trunk/LayoutTests

WebSocket tests still don't work on Windows, disabling for futher invesigation.

• platform/win/Skipped:

11:55 AM Changeset in webkit [51251] by bweinstein@apple.com

• 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Fix a closing tag issue in the vcproj and remove tabs.

11:51 AM Changeset in webkit [51250] by bweinstein@apple.com

• 7 edits in trunk/WebCore

Fixes <​http://webkit.org/b/31700>.
Web Inspector: isMac should be in one central location + Cached.

Reviewed by Tim Hatcher.

We should cache the value of isMac, and make the indexOf call in one
single location, because we are calling it from multiple places, and saving
the result can save us time, and make the call sites simpler.

• inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

• inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._updateFilter):

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleKeyEvent):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

• inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._loaded):

• inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):
(WebInspector.isMac):

11:31 AM Changeset in webkit [51249] by abarth@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Support Qt port in build-queue
​https://bugs.webkit.org/show_bug.cgi?id=31733

• Scripts/bugzilla-tool:

11:22 AM Changeset in webkit [51248] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement a build-queue
​https://bugs.webkit.org/show_bug.cgi?id=31725

Currently this just builds the first 10 patches in the review queue.
We'll want to do something smarter soon.

• Scripts/bugzilla-tool:

11:22 AM Changeset in webkit [51247] by ap@apple.com

• 2 edits in trunk/LayoutTests

Enabling WebSocket tests on Windows - let's see if they pass after the recent fixes.

• platform/win/Skipped:

11:19 AM Changeset in webkit [51246] by Joseph Pecoraro

• 1 edit
  1 delete in trunk/WebCore

2009-11-19 Joseph Pecoraro <Joseph Pecoraro>

Removed .DS_Store accidentally added in last (r51245).

11:11 AM Changeset in webkit [51245] by Joseph Pecoraro

• 12 edits
  3 adds in trunk/WebCore

2009-11-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Add Console Only Layout Mode
​https://bugs.webkit.org/show_bug.cgi?id=30282

Adds a Console Panel, which allows for a Full size Console. This
extends the Drawer to the size of a Panel. This also fixes previous
resize issues with the Drawer.

• inspector/front-end/ConsolePanel.js: added. (WebInspector.ConsolePanel): (WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide):
• inspector/front-end/Drawer.js: (WebInspector.Drawer): (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console. (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide.animationFinished): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full (WebInspector.Drawer.prototype.enterPanelMode): (WebInspector.Drawer.prototype.exitPanelMode): (WebInspector.Drawer.prototype.immediatelyExitPanelMode): (WebInspector.Drawer.prototype._cancelAnimationIfNeeded): (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight): (WebInspector.Drawer.prototype._animationDuration): (WebInspector.Drawer.prototype._startStatusBarDragging): (WebInspector.Drawer.prototype._statusBarDragging): (WebInspector.Drawer.prototype._endStatusBarDragging):

Miscellaneous changes and cleanup.

• English.lproj/localizedStrings.js: "Console" toolbar title.
• inspector/front-end/ConsoleView.js: removed unnecessary element reordering
• inspector/front-end/Images/consoleIcon.png: added.
• inspector/front-end/inspector.css: added icon.
• inspector/front-end/inspector.html:
• inspector/front-end/inspector.js: (WebInspector._createPanels): create console panel (WebInspector.windowResize): resize drawer if necessary (WebInspector.documentKeyDown): esc should not toggle the console when in panel mode (WebInspector.animateStyle): start animation interval, returns the interval key (WebInspector.toggleAttach): resize drawer if necessary (WebInspector.showConsolePanel): restore the panel when the inspector restarts (WebInspector.showProfileForURL): style fix

Restore the panel when the inspector restarts.

• inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::specialPanelForJSName):
• inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):

Build files.

• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• inspector/front-end/WebKit.qrc:

11:06 AM Changeset in webkit [51244] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make commit-queue and style-queue show up in help
​https://bugs.webkit.org/show_bug.cgi?id=31724

We need to store their names on their class to make these commands
properly register themselves with MultiCommandTool.

• Scripts/bugzilla-tool:

10:57 AM Changeset in webkit [51243] by eric@webkit.org

• 4 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement bugzilla-tool build-attachment
​https://bugs.webkit.org/show_bug.cgi?id=31722

This command builds an attachment from bugzilla. It leaves the built
patch in the working copy.

• Scripts/bugzilla-tool:
• Scripts/modules/landingsequence.py:
• Scripts/modules/webkitlandingscripts.py:

10:40 AM Changeset in webkit [51242] by bweinstein@apple.com

• 7 edits in trunk/WebCore

Fixes <​http://webkit.org/b/31699>.
Web Inspector: Should Cache Values of InspectorController.platform() and port().

Reviewed by Tim Hatcher.

Refactor the Inspector to cache the value of InspectorController.platform
and InspectorController.port, because those need to call into C++, they are
being called more and more as we add platform specific keyboard shortcuts, and
they shouldn't change in the lifecycle of the Web Inspector.

• inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

• inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._updateFilter):

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleKeyEvent):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

• inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._loaded):

• inspector/front-end/inspector.js:

(WebInspector.get platform):
(WebInspector.get port):
(WebInspector.loaded):
(WebInspector.documentKeyDown):
(WebInspector.toolbarDragStart):

9:53 AM Changeset in webkit [51241] by eric@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

2009-11-20 Victor Wang <​victorw@chromium.org>

Reviewed by Darin Adler.

Add expected pixel result for layout test input-file-re-render

​https://bugs.webkit.org/show_bug.cgi?id=31696

• platform/mac/fast/forms/input-file-re-render-expected.checksum: Added.
• platform/mac/fast/forms/input-file-re-render-expected.png: Added.

9:49 AM Changeset in webkit [51240] by krit@webkit.org

• 8 edits in trunk/WebCore

2009-11-20 Dirk Schulze <​krit@webkit.org>

Unreviewed build fix for filters enabled builds.

• platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
• platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
• platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
• svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::applyFilter):
• svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
• svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
• svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

9:45 AM Changeset in webkit [51239] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT release event does not create the state correctly
​https://bugs.webkit.org/show_bug.cgi?id=31717

• WebKitTools/DumpRenderTree/gtk/EventSender.cpp:

9:27 AM Changeset in webkit [51238] by eric.carlson@apple.com

• 7 edits in trunk

2009-11-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7389945> QTKit based media engine should not claim to support
fullscreen on Leopard

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsFullscreen):

Only return true on SnowLeopard for now.

• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):

No need to special case MediaFullscreenButtonPart as the default implementation
asks the media engine if it supports fullscreen.

2009-11-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7389945> QTKit based media engine should not claim to support fullscreen on Leopard

Update test results.

• platform/mac/media/audio-controls-rendering-expected.checksum:
• platform/mac/media/audio-controls-rendering-expected.png:
• platform/mac/media/audio-controls-rendering-expected.txt:

6:54 AM Changeset in webkit [51237] by abarth@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

MultiCommandTool should find Command objects automatically instead of with a manual list
​https://bugs.webkit.org/show_bug.cgi?id=31710

• Scripts/bugzilla-tool:
• Scripts/modules/multicommandtool.py:
  • Use some wild python-fu to crawl all the known subclasses of Command.

6:45 AM Changeset in webkit [51236] by abarth@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix. Added missing import.

• Scripts/bugzilla-tool:

6:44 AM Changeset in webkit [51235] by abarth@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix. I failed to update LandingSequence.test
properly.

• Scripts/modules/landingsequence.py:

6:21 AM QtWebKitBackportingFixes created by Simon Hausmann

5:47 AM QtWebKitContrib edited by Simon Hausmann

(diff)

4:29 AM QtWebKitJournal edited by Simon Hausmann

(diff)

3:18 AM Changeset in webkit [51234] by Girish Ramakrishnan

• 4 edits in trunk/WebCore

[Qt] Implement support for rendering plugins on Qt/Mac when a page is used
without a QWebView or when inside QGraphicsWebView.

Reviewed by Simon Hausmann.

Patch by Yongjun Zhang <​yongjun.zhang@nokia.com> and

Girish Ramakrishnan <Girish Ramakrishnan>

Currently, the code provides the cgcontext of the PlatformPluginWidget to
the plugin. This approach does not work when we are printing, or using
QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
of the QPaintDevice's context.

To solve all cases and keep the code simple, we render the plugin to an
offscreen pixmap in all cases. This way, the plugin always renders to the
CGContext of the pixmap and we then use QPainter to blit the pixmap into
the QPaintDevice. We also create a fake window and set it's WindowRef in
NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.

Now, that's the theory. In practice, ATM, mouse events do not work when using
the fake window. So, setPlatformPluginWidget() is still called when using QWebView
so that there are no regressions after this patch. Once we get mouse events
working, setPlatformPluginWidget will be removed.

​https://bugs.webkit.org/show_bug.cgi?id=31183

1:01 AM Changeset in webkit [51233] by eric@webkit.org

• 2 edits
  2 adds in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Create LandingSequence as the all-sing, all-dance landing class
​https://bugs.webkit.org/show_bug.cgi?id=31709

Client can inherit from this class to carefully control exactly which
steps they wish to have happen in the landing sequence.

• Scripts/bugzilla-tool:
• Scripts/modules/landingsequence.py: Added.
• Scripts/modules/webkitlandingscripts.py: Added.

Nov 19, 2009:

11:01 PM Changeset in webkit [51232] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
​https://bugs.webkit.org/show_bug.cgi?id=31707

This is to help when we implement build-attachment.

• Scripts/bugzilla-tool:

10:43 PM Changeset in webkit [51231] by eric@webkit.org

• 3 edits
  2 copies in trunk/WebKitTools

2009-11-19 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Support Qt port in bugzilla-tool
​https://bugs.webkit.org/show_bug.cgi?id=31701

Now we support building with Qt!

• Scripts/bugzilla-tool:
• Scripts/modules/webkitport.py: Added.
• Scripts/modules/webkitport_unittest.py: Added.
• Scripts/run-webkit-unittests:

10:20 PM Changeset in webkit [51230] by eric@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-19 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Adam Barth.

Remove inserting stderr into patch in bugzilla-tool
​https://bugs.webkit.org/show_bug.cgi?id=29914

Modify SCM python module's run_command function to avoid return of stderr
by default, so stderr won't be inserted into the patches.
Modify the related unit test.

• Scripts/modules/scm.py:
• Scripts/modules/scm_unittest.py:

10:17 PM Changeset in webkit [51229] by Joseph Pecoraro

• 2 edits in trunk/WebCore

2009-11-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Resync Resources Backend and Frontend
​https://bugs.webkit.org/show_bug.cgi?id=31705

• inspector/front-end/Resource.js: resync enum values with backend (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases

10:03 PM Changeset in webkit [51228] by eric@webkit.org

• 4 edits in trunk

2009-11-19 Steve Block <​steveblock@google.com>

Android port lacks configuration in Platform.h and config.h.
​https://bugs.webkit.org/show_bug.cgi?id=31671

• wtf/Platform.h: Modified. Added Android-specific configuration.

2009-11-19 Steve Block <​steveblock@google.com>

Reviewed by Darin Fisher.

Android port lacks configuration in Platform.h and config.h.
​https://bugs.webkit.org/show_bug.cgi?id=31671

Build change only. No new tests possible.

• config.h: Modified. Added Android-specific configuration.

9:44 PM Changeset in webkit [51227] by rolandsteiner@chromium.org

• 3 edits
  2 adds in trunk

2009-11-20 Roland Steiner <​rolandsteiner@chromium.org>

WebCore: Change default stylesheet to reset text indentation for ruby elements by default.
(​https://bugs.webkit.org/show_bug.cgi?id=31247)

Reviewed by Darin Adler.

Test: fast/ruby/ruby-text-indent.html

• css/html.css: reset text-indent on <ruby> and <rt> elements

LayoutTests: Test checking that CSS 'text-indent' does not affect ruby rendering by default.
(​https://bugs.webkit.org/show_bug.cgi?id=31247)

Reviewed by Darin Adler.

• fast/ruby/ruby-text-indent-expected.txt: Added.
• fast/ruby/ruby-text-indent.html: Added.

6:18 PM Changeset in webkit [51226] by eric@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool needs per-command help
​https://bugs.webkit.org/show_bug.cgi?id=31697

Added support for "bugzilla-tool help command-name"
and a unit test to make sure it works.

• Scripts/modules/multicommandtool.py:
• Scripts/modules/multicommandtool_unittest.py:

6:12 PM Changeset in webkit [51225] by bweinstein@apple.com

• 2 edits in trunk/WebCore

Fixes <​http://webkit.org/b/22754>.
Web Inspector: Keyboard shortcut for Element finder.

Reviewed by Darin Adler.

Use Command + Shift + C as a shortcut for Node Search, to
match the Firebug shortcut to do the same thing.

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleKeyEvent):

5:09 PM Changeset in webkit [51224] by eric@webkit.org

• 12 edits in trunk/WebKit/chromium

2009-11-19 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Fisher.

Make chromium/webkit/glue/FormFieldValues use the WebKit API

​https://bugs.webkit.org/show_bug.cgi?id=31650

• public/WebElement.h:
• public/WebFormElement.h:
• public/WebInputElement.h: (WebKit::WebInputElement::):
• public/WebNode.h:
• src/AssertMatchingEnums.cpp:
• src/DOMUtilitiesPrivate.cpp: (WebKit::nameOfInputElement):
• src/DOMUtilitiesPrivate.h:
• src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill): (WebKit::EditorClientImpl::doAutofill):
• src/WebFormElement.cpp: (WebKit::WebFormElement::name): (WebKit::WebFormElement::method): (WebKit::WebFormElement::getNamedElements): (WebKit::WebFormElement::getInputElements):
• src/WebInputElement.cpp: (WebKit::WebInputElement::isEnabledFormControl): (WebKit::WebInputElement::inputType): (WebKit::WebInputElement::formControlType): (WebKit::WebInputElement::value): (WebKit::WebInputElement::dispatchFormControlChangeEvent): (WebKit::WebInputElement::setSelectionRange): (WebKit::WebInputElement::name): (WebKit::WebInputElement::nameForAutofill):
• src/WebNode.cpp: (WebKit::WebNode::frame):

4:55 PM Changeset in webkit [51223] by eric@webkit.org

• 3 edits
  2 adds in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move MultiCommandTool and Command into a separate file and add some basic unit tests
​https://bugs.webkit.org/show_bug.cgi?id=31695

• Scripts/bugzilla-tool:
• Scripts/modules/multicommandtool.py: Added.
• Scripts/modules/multicommandtool_unittest.py: Added.
• Scripts/run-webkit-unittests:

4:53 PM Changeset in webkit [51222] by ap@apple.com

• 13 edits
  2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31690
Make SocketStreamHandleCFNet work on Windows

• WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.

• platform/network/ResourceHandle.h: Removed loaderRunLoop().

• platform/network/cf/LoaderRunLoopCF.cpp: Added. (WebCore::emptyPerform): (WebCore::runLoaderThread): (WebCore::loaderRunLoop):
• platform/network/cf/LoaderRunLoopCF.h: Added. Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because it's needed for more than just resource loading.

• platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.

• platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.

• platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to main thread.
• platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of inoperable main run loop.

(WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::readStreamCallbackMainThread):
(WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
Forward stream events to main thread on Windows.

4:47 PM Changeset in webkit [51221] by eric@webkit.org

• 2 edits in trunk/WebCore

2009-11-19 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Adler.

Quick style fix.
​https://bugs.webkit.org/show_bug.cgi?id=27777

• platform/graphics/cg/PDFDocumentImage.cpp:

4:30 PM Changeset in webkit [51220] by bweinstein@apple.com

• 2 edits
  1 delete in trunk/LayoutTests/platform/win/fast/table

Update Windows expected pixel results, and remove the RenderTree results, because they are the same as the Mac.

4:25 PM Changeset in webkit [51219] by Beth Dakin

• 3 edits in trunk/WebCore

Build fix. No review needed.

• platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):

• rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaButton):

4:02 PM Changeset in webkit [51218] by Beth Dakin

• 2 edits in trunk/WebCore

Build fix. No review needed.

• rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintCheckbox):
(WebCore::RenderThemeChromiumSkia::paintRadio):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

3:58 PM Changeset in webkit [51217] by Beth Dakin

• 3 edits in trunk/WebCore

Build fix. No review needed.

• platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

• platform/graphics/qt/StillImageQt.h:

3:53 PM Changeset in webkit [51216] by Beth Dakin

• 2 edits in trunk/WebCore

Build fix. No review needed.

• rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

3:50 PM Changeset in webkit [51215] by Beth Dakin

• 2 edits in trunk/WebCore

Build fix. No review needed.

• plugins/PluginView.cpp:

(WebCore::PluginView::paintMissingPluginIcon):

3:46 PM Changeset in webkit [51214] by Beth Dakin

• 2 edits in trunk/WebCore

Build fix. No review needed.

• platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

3:38 PM Changeset in webkit [51213] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

No review, just adding a FIXME.

Split out command parsing and help printing from BugzillaTool
​https://bugs.webkit.org/show_bug.cgi?id=31688

• Scripts/bugzilla-tool: Add an extra comment about current design failures.

3:36 PM Changeset in webkit [51212] by Beth Dakin

• 42 edits
  9 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
color-correction work with untagged images

Reviewed by Darin Adler.

Image's draw(), drawPattern(), and fillWithSolidColor() functions
now take a ColorSpace. A bunch of classes inherit from Image, so
draw() and drawPattern() functions there must also take a
ColorSpace.

• platform/graphics/Image.cpp:

(WebCore::Image::fillWithSolidColor):
(WebCore::Image::drawTiled):

• platform/graphics/Image.h:
• platform/graphics/BitmapImage.h:
• platform/graphics/GeneratedImage.cpp:

(WebCore::GeneratedImage::draw):
(WebCore::GeneratedImage::drawPattern):

• platform/graphics/GeneratedImage.h:
• platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

• platform/graphics/cg/PDFDocumentImage.h:
• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

• svg/graphics/SVGImage.h:

All of the drawImage() functions and drawTiled() functions of
GraphicsContext now take a ColorSpace.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):

• platform/graphics/GraphicsContext.h:

This is where the actual work is done.

• platform/graphics/cg/ImageCG.cpp:

(WebCore::imageWithColorSpace): New static function that returns a
copy of the given image in the given ColorSpace *IF* we should use
the given ColorSpace. We will ignore the color space if the image
is tagged and return 0.
(WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to
call imageWithColorSpace().
(WebCore::Image::drawPattern): Same.

Attempt to keep all ports building.

• platform/graphics/cairo/ImageCairo.cpp:

(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

• platform/graphics/haiku/ImageHaiku.cpp:

(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

• platform/graphics/qt/ImageQt.cpp:

(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):

• platform/graphics/skia/BitmapImageSingleFrameSkia.h:
• platform/graphics/skia/ImageSkia.cpp:

(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

• platform/graphics/wx/ImageWx.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::drawPattern):

Callers of GraphicsContext's drawImage() and drawTiled() functions
now need to send a ColorSpace.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):

• platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

• platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::apply):

• platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::apply):

• platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::apply):

• platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintResizer):

• rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

• rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

• svg/graphics/SVGPaintServerPattern.cpp:

(WebCore::SVGPaintServerPattern::setup):

• svg/graphics/SVGResourceFilter.cpp:

(WebCore::SVGResourceFilter::applyFilter):

• svg/graphics/filters/SVGFEMerge.cpp:

(WebCore::FEMerge::apply):

• svg/graphics/filters/SVGFEOffset.cpp:

(WebCore::FEOffset::apply):

• svg/graphics/filters/SVGFETile.cpp:

(WebCore::FETile::apply):

LayoutTests: Tests for ​https://bugs.webkit.org/show_bug.cgi?id=31321 Make
-webkit-color-correction work with untagged images

Reviewed by Darin Adler.

• fast/css/color-correction-on-background-image.html: Added.
• fast/css/color-correction-untagged-images.html: Added.
• fast/css/resources/purple-noprofile.png: Added.
• platform/mac/fast/css/color-correction-on-background-image-expected.checksum: Added.
• platform/mac/fast/css/color-correction-on-background-image-expected.png: Added.
• platform/mac/fast/css/color-correction-on-background-image-expected.txt: Added.
• platform/mac/fast/css/color-correction-untagged-images-expected.checksum: Added.
• platform/mac/fast/css/color-correction-untagged-images-expected.png: Added.
• platform/mac/fast/css/color-correction-untagged-images-expected.txt: Added.

3:32 PM Changeset in webkit [51211] by dimich@chromium.org

• 2 edits in trunk/JavaScriptCore

isMainThread() on Chromium (Mac and Linux) is so slow it timeouts LayoutTests..
​https://bugs.webkit.org/show_bug.cgi?id=31693

Reviewed by David Levin.

• wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): grab and use the pthread_t of the main thread instead of ThreadIdentifier.
(WTF::isMainThread): Ditto.

3:30 PM Changeset in webkit [51210] by Michelangelo De Simone

• 3 edits in trunk/LayoutTests

2009-11-19 Michelangelo De Simone <Michelangelo De Simone>

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>
Files missed when landing patch.

• platform/qt/Skipped:
• platform/win/Skipped:

3:28 PM Changeset in webkit [51209] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Split out command parsing and help printing from BugzillaTool
​https://bugs.webkit.org/show_bug.cgi?id=31688

• Scripts/bugzilla-tool:
  • Add new MultiCommandTool class to contain option parsing and help printing logic.
  • Rename private methods to use _ pattern.
  • MultiCommandTool has two abstract methods should_show_command_help and should_execute_command. -

3:21 PM Changeset in webkit [51208] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Re-factor help printing to use modern python idioms
​https://bugs.webkit.org/show_bug.cgi?id=31685

• Scripts/bugzilla-tool:

3:12 PM Changeset in webkit [51207] by eric@webkit.org

• 4 edits in trunk/WebCore

2009-11-19 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Adler.

Properly create a CGImageRef on non-PLATFORM(MAC).
​https://bugs.webkit.org/show_bug.cgi?id=27777

• platform/graphics/cg/ImageSourceCG.cpp: (WebCore::sharedBufferGetBytesAtPosition): (WebCore::sharedBufferRelease): (WebCore::ImageSource::setData):
• platform/graphics/cg/ImageSourceCG.h:
• platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged):

2:16 PM Changeset in webkit [51206] by ap@apple.com

• 2 edits in trunk/LayoutTests

Trying to enable WebSocket tests on Tiger again, as the bot seems to behave now.

• platform/mac-tiger/Skipped:

2:04 PM Changeset in webkit [51205] by oliver@apple.com

• 2 edits
  1 add in trunk/WebCore

-webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
​https://bugs.webkit.org/show_bug.cgi?id=31656

Reviewed Dave Hyatt

Make sure we're a child of the painting root before drawing overflow features.

1:29 PM Changeset in webkit [51204] by dimich@chromium.org

• 2 edits in trunk/WebCore

Not reviewed, attempt to fix Chromium build.

• rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.

1:02 PM Changeset in webkit [51203] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

commit-queue empty queue logs twice
​https://bugs.webkit.org/show_bug.cgi?id=31679

• Scripts/bugzilla-tool:

12:28 PM Changeset in webkit [51202] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

bugzilla-tool's reviewer/committer rejection message should be clearer
​https://bugs.webkit.org/show_bug.cgi?id=31126

Add more explanatory prose to bugzilla-tool's flag permission rejection message.

• Scripts/modules/bugzilla.py:

12:25 PM Changeset in webkit [51201] by eric@webkit.org

• 3 edits
  2 adds in trunk

2009-11-19 Rahul Kuchhal <​kuchhal@chromium.org>

Reviewed by Darin Adler.

Do not assert when a high number is used for roman numerals in lists.
​https://bugs.webkit.org/show_bug.cgi?id=31652

• fast/lists/ol-start-roman.html: Added.
• platform/mac/fast/lists/ol-start-roman-expected.txt: Added.

2009-11-19 Rahul Kuchhal <​kuchhal@chromium.org>

Reviewed by Darin Adler.

Do not assert when a high number is used for roman numerals in lists.
​https://bugs.webkit.org/show_bug.cgi?id=31652

Test: fast/lists/ol-start-roman.html

• rendering/RenderListMarker.cpp: (WebCore::toRoman): Increase the char array size.

12:14 PM Changeset in webkit [51200] by kov@webkit.org

• 2 edits in trunk/WebCore

Rubber-stamped by Oliver Hunt.

Add translatable strings to cover validationMessage, after
r51172. Already covered by existing test.

• platform/gtk/LocalizedStringsGtk.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

12:12 PM Changeset in webkit [51199] by eric@webkit.org

• 3 edits in trunk/JavaScriptCore

2009-11-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove HAVE(STRING_H) guard from JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=31668

• config.h:
• runtime/UString.cpp:

11:59 AM Changeset in webkit [51198] by dumi@chromium.org

• 2 edits in trunk/JavaScriptCore

Fixing a bug in MessageQueue::removeIf() that leads to an
assertion failure.

Reviewed by Dmitry Titov.

​https://bugs.webkit.org/show_bug.cgi?id=31657

• wtf/MessageQueue.h:

(WTF::MessageQueue::removeIf):

11:54 AM Changeset in webkit [51197] by eric@webkit.org

• 9 edits in trunk

2009-11-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove HAVE(FLOAT_H) guard
​https://bugs.webkit.org/show_bug.cgi?id=31661

JavaScriptCore has a dependency on float.h, there is
no need to guard float.h.

• runtime/DatePrototype.cpp: Remove include directive for float.h as it is included in MathExtras.h already.
• runtime/Operations.cpp: Ditto.
• runtime/UString.cpp: Ditto.
• wtf/dtoa.cpp: Ditto.
• wtf/MathExtras.h: Remove HAVE(FLOAT_H) guard.
• wtf/Platform.h: Ditto.

2009-11-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove HAVE(FLOAT_H) guard
​https://bugs.webkit.org/show_bug.cgi?id=31661

WebCore has a dependency on float.h, there is
no need to guard float.h.

No new tests as there is no functional change.

• html/HTMLInputElement.cpp: Remove include directive for float.h as it is included in MathExtras.h already.

11:41 AM Changeset in webkit [51196] by eric@webkit.org

• 6 edits in trunk

2009-11-19 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

Updated timeline paint test to ignore width and height. GTK+ testing
uses a different top level window size than other platforms.

​https://bugs.webkit.org/show_bug.cgi?id=31402

• inspector/timeline-paint-expected.txt:
• inspector/timeline-test.js:
• platform/win/Skipped:

2009-11-19 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

Forces a WM_PAINT event on calling layoutTestController.display()
in order to enable the timeline-paint.html test on Windows.
::UpdateWindow() does not force an event becaue the window is
not visible.

​https://bugs.webkit.org/show_bug.cgi?id=31402

• DumpRenderTree/win/DumpRenderTree.cpp: (displayWebView):

11:28 AM Changeset in webkit [51195] by eric@webkit.org

• 8 edits
  2 adds in trunk

2009-11-19 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

WAI-ARIA roles not supported on image map <area>
​https://bugs.webkit.org/show_bug.cgi?id=31525

• accessibility/aria-used-on-image-maps-expected.txt: Added.
• accessibility/aria-used-on-image-maps.html: Added.
• platform/gtk/Skipped:
• platform/win/Skipped:

11:03 AM Changeset in webkit [51194] by Simon Fraser

• 2 edits in trunk/WebCore

2009-11-19 Simon Fraser <Simon Fraser>

Reviewed by Pavel Feldman.

Instrumentation should account for painting in compositing layers
​https://bugs.webkit.org/show_bug.cgi?id=31674

Add calls to InspectorTimelineAgent for painting into compositing layers,
which is not accounted for in FrameView::paintContents().

• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): Avoid fetching the FrameView multiple times.

(WebCore::inspectorTimelineAgent):
(WebCore::RenderLayerBacking::paintContents):

10:21 AM Changeset in webkit [51193] by Michelangelo De Simone

• 2 edits in trunk/WebKitTools

2009-11-19 Michelangelo De Simone <Michelangelo De Simone>

No review needed.

Added myself to committers list.

• Scripts/modules/committers.py:

10:16 AM Changeset in webkit [51192] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Bugzilla-tool command classes should match command names
​https://bugs.webkit.org/show_bug.cgi?id=31666

I renamed all the commands except CommitMessageForCurrentDiff because
the new name would conflict with an existing class.

• Scripts/bugzilla-tool:

10:14 AM Changeset in webkit [51191] by eric.carlson@apple.com

• 49 edits
  3 adds in trunk

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

Test: media/media-captions.html

• WebCore.base.exp:
• accessibility/AccessibilityMediaControls.cpp: (WebCore::AccessibilityMediaControl::controlTypeName):

Define ShowClosedCaptionsButton and HideClosedCaptionsButton.

• css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

Add MediaToggleClosedCaptionsButtonPart.

• css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):

Define and match mediaControlsToggleClosedCaptionsButton.

• css/CSSSelector.h: (WebCore::CSSSelector::):
• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

Define and match PseudoMediaControlsToggleClosedCaptions.

• css/CSSValueKeywords.in:

Define and use media-toggle-closed-captions-button.

• css/mediaControls.css:
• css/mediaControlsQuickTime.css:

Add webkit-media-controls-toggle-closed-captions-button.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):

Initialize m_closedCaptionsVisible.

(WebCore::HTMLMediaElement::loadInternal):

Set m_closedCaptionsVisible to false.

(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::closedCaptionsVisible):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):

New, captions internal methods.

(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitHasClosedCaptions):

New, captions DOM API.

• html/HTMLMediaElement.h:
• html/HTMLMediaElement.idl:

Declare methods needed for captions API.

• platform/ThemeTypes.h:

Add MediaToggleClosedCaptionsButtonPart.

• platform/android/LocalizedStringsAndroid.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

Add empty implmentations.

• platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::hasClosedCaptions): (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):

New, empty implementations of media engine closed caption functions.

(WebCore::MediaPlayer::hasClosedCaptions):
(WebCore::MediaPlayer::setClosedCaptionsVisible):

New, call media engine closed caption functions.

• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions): (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):

Declare new media engine methods.

• platform/graphics/mac/MediaPlayerPrivateQTKit.h:
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):

New, QTKit implementation of closed caption methods.

• platform/gtk/LocalizedStringsGtk.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText):

Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:

Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.

• rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement):

Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.

(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):

New, implement the closed caption toggle button,

• rendering/MediaControlElements.h:

Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
declare MediaControlToggleClosedCaptionsButtonElement.

• rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): (WebCore::RenderMedia::createToggleClosedCaptionsButton): (WebCore::RenderMedia::createStatusDisplay): (WebCore::RenderMedia::updateControls): (WebCore::RenderMedia::forwardEvent):
• rendering/RenderMedia.h:

Deal with m_toggleClosedCaptionsButton.

• rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint):

Deal with MediaToggleClosedCaptionsButtonPart.

• rendering/RenderTheme.h:
• rendering/RenderThemeMac.h:

Declare paintMediaToggleClosedCaptionsButton.

• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):

New.

(WebCore::RenderThemeMac::shouldRenderMediaControlPart):

Don't render captions toggle button unless we are using the new theme, the
movie has captions, and the movie is in a <video> element since we currently
rely on QTKit to render the captions.

• rendering/style/RenderStyleConstants.h:

Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

• media/media-captions-expected.txt: Added.
• media/media-captions.html: Added.
• media/content/counting-captioned.mov: Added.

• platform/gtk/Skipped:
• platform/mac-leopard/Skipped:
• platform/mac-tiger/Skipped:
• platform/win/Skipped:

Skipped on platforms that don't support closed captions yet.

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

• English.lproj/Localizable.strings:

Add strings for toggle captions button.

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

Add QTMovieHasClosedCaptions and QTMovieSetShowClosedCaptions.

• WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaControlElementString:]): (-[WebViewFactory localizedMediaControlElementHelpText:]):

Add accessibility help strings for media controller closed caption button.

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

• WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText):

Add accessibility help strings for media controller closed caption button.

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

• WebKitSystemInterface.h:

Add prototypes for WKQTMovieHasClosedCaptions and WKQTMovieSetShowClosedCaptions,
define WKMediaUIPartToggleClosedCaptionsButton.

10:10 AM Changeset in webkit [51190] by kevino@webkit.org

• 2 edits in trunk/WebCore

wx build fix. Add missing header.

9:43 AM Changeset in webkit [51189] by ap@apple.com

• 3 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31634
Ignore realm for proxy protection spaces

Only affects WebSocket proxy authentication, cannot be tested in DRT.

• platform/network/ProtectionSpace.cpp: (WebCore::operator==):
• platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):

9:42 AM Changeset in webkit [51188] by eric@webkit.org

• 7 edits in trunk

2009-11-19 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

​https://bugs.webkit.org/show_bug.cgi?id=31669

• platform/gtk/Skipped:

2009-11-19 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

​https://bugs.webkit.org/show_bug.cgi?id=31669

• webkit/webkitwebinspector.cpp: (webkit_web_inspector_show):
• webkit/webkitwebinspector.h:

2009-11-19 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

​https://bugs.webkit.org/show_bug.cgi?id=31669

• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector):

6:23 AM Changeset in webkit [51187] by kenneth@webkit.org

• 2 edits in trunk/WebKitTools

Minor refactoring + more documentation.

Reviewed by Simon Hausmann.

• DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::clearHistory):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

6:12 AM Changeset in webkit [51186] by eric@webkit.org

• 2 edits
  3 adds in trunk/WebKit/qt

2009-11-19 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add instantiation tests for QWebInspector.

• tests/qwebinspector/qwebinspector.pro: Added.
• tests/qwebinspector/tst_qwebinspector.cpp: Added. (tst_QWebInspector::attachAndDestroy):
• tests/tests.pro:

6:04 AM Changeset in webkit [51185] by eric@webkit.org

• 2 edits in trunk/WebKit/qt

2009-11-19 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix QWebInspector destruction problem.
​https://bugs.webkit.org/show_bug.cgi?id=31664

• Api/qwebpage.cpp: (QWebPage::~QWebPage):

5:47 AM Changeset in webkit [51184] by Simon Hausmann

• 9 edits in trunk

[Qt] Normalize signal and slot signatures.

Patch by Olivier Goffart <​ogoffart@trolltech.com> on 2009-11-19
Reviewed by Simon Hausmann.

WebCore:

• platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):

WebKit/qt:

• Api/qgraphicswebview.cpp:

(QGraphicsWebView::setPage):

• Api/qwebview.cpp:

(QWebView::setPage):

• WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::setFrame):

• docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp:

(wrapInFunction):

• tests/qwebframe/tst_qwebframe.cpp:
• tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::modified):
(tst_QWebPage::database):

5:46 AM Changeset in webkit [51183] by Simon Hausmann

• 2 edits in trunk/JavaScriptCore

Build fix for 32-bit Sparc machines: these machines are big-endian.

Patch by Thiago Macieira <​thiago.macieira@nokia.com> on 2009-11-19
Reviewed by Simon Hausmann.

• wtf/Platform.h:

5:03 AM Changeset in webkit [51182] by eric@webkit.org

• 7 edits in trunk/WebCore

2009-11-19 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Store cookie domains in the WebInspector object

The cookie domains have been moved from StoragePanel into WebInspector.
Also, the document URLs are now passed inside the WebInspector.addResource()
payload rather than pushed directly from InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=31627

• inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didFinishLoading):
• inspector/InspectorFrontend.cpp:
• inspector/InspectorFrontend.h:
• inspector/InspectorResource.cpp: (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
• inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addCookieDomain):
• inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.addCookieDomain): (WebInspector.reset):

4:32 AM Changeset in webkit [51181] by hamaji@chromium.org

• 5 edits
  4 adds
  15 deletes in trunk/LayoutTests

2009-11-19 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Some tests in fast/css-generated-content can be dumpAsText test
​https://bugs.webkit.org/show_bug.cgi?id=31663

• fast/css-generated-content/absolute-position-inside-inline-expected.txt: Added.
• fast/css-generated-content/absolute-position-inside-inline.html:
• fast/css-generated-content/hit-test-generated-content-expected.txt: Added.
• fast/css-generated-content/hit-test-generated-content.html:
• fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Added.
• fast/css-generated-content/positioned-background-hit-test-crash.html:
• fast/css-generated-content/spellingToolTip-assert-expected.txt: Added.
• fast/css-generated-content/spellingToolTip-assert.html:
• platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.checksum: Removed.
• platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.png: Removed.
• platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.txt: Removed.
• platform/mac/fast/css-generated-content/hit-test-generated-content-expected.checksum: Removed.
• platform/mac/fast/css-generated-content/hit-test-generated-content-expected.png: Removed.
• platform/mac/fast/css-generated-content/hit-test-generated-content-expected.txt: Removed.
• platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.checksum: Removed.
• platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.png: Removed.
• platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Removed.
• platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.checksum: Removed.
• platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.png: Removed.
• platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.txt: Removed.
• platform/qt/fast/css-generated-content/absolute-position-inside-inline-expected.txt: Removed.
• platform/qt/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Removed.
• platform/qt/fast/css-generated-content/spellingToolTip-assert-expected.txt: Removed.

2:41 AM Changeset in webkit [51180] by ukai@chromium.org

• 2 edits in trunk/WebKitTools

2009-11-19 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel.

Ignore websocket tests when --no-http is specified.
​https://bugs.webkit.org/show_bug.cgi?id=31662

• Scripts/run-webkit-tests:

1:34 AM Changeset in webkit [51179] by zoltan@webkit.org

• 10 edits in trunk/WebCore

Allow custom memory allocation control for the other part of platform directory in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=31585

Reviewed by Darin Adler.

Inherits the following classes from FastAllocBase because these are
instantiated by 'new':

class RegularExpression - instantiated at: WebCore/page/Frame.cpp:415
class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
class Path - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
class FontPlatformData - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:

class Cursors - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
class NetworkStateNotifier - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71

class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119

• platform/graphics/MediaPlayerPrivate.h:
• platform/graphics/Path.h:
• platform/graphics/qt/FontPlatformData.h:
• platform/graphics/transforms/TransformationMatrix.h:
• platform/image-decoders/ImageDecoder.h:
• platform/network/NetworkStateNotifier.h:
• platform/network/ResourceRequestBase.h:
• platform/qt/CursorQt.cpp:
• platform/text/RegularExpression.h:

12:15 AM Changeset in webkit [51178] by mitz@apple.com

• 5 edits in trunk/LayoutTests

Update the test fast/overflow/004.html to make it match the test
description and expected results.
​https://bugs.webkit.org/show_bug.cgi?id=31455

Patch by Kinuko Yasuda <​kinuko@google.com> on 2009-11-19
Reviewed by Dan Bernstein.

• fast/overflow/004.html:
• platform/mac/fast/overflow/004-expected.checksum:
• platform/mac/fast/overflow/004-expected.png:
• platform/mac/fast/overflow/004-expected.txt:

Nov 18, 2009:

11:18 PM Changeset in webkit [51177] by Laszlo Gombos

• 2 edits in trunk/WebCore

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r51172.

• platform/qt/Localizations.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

10:18 PM Changeset in webkit [51176] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-18 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Normalize ' and " in bugzilla-tool
​https://bugs.webkit.org/show_bug.cgi?id=31655

We decided " is better than ' and we should be consistent.

• Scripts/bugzilla-tool:

10:17 PM Changeset in webkit [51175] by mitz@apple.com

• 4 edits
  4 adds in trunk

WebCore: Fixed <rdar://problem/7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer

Reviewed by Simon Fraser.

Tests: fast/layers/clip-rects-transformed-2.html

fast/layers/clip-rects-transformed.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
that is either transformed or composited. During painting and hit
testing, when a transformed or composited layer is hit, it becomes the
new root layer, which ultimately gets passed to calculateRects().
(WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
root layer to calculateRects(), and return the bounding box of the
transformed rectangle.
(WebCore::RenderLayer::selfClipRect): Ditto.

• rendering/RenderLayer.h:

LayoutTests: Test for <rdar://problem/7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer

Reviewed by Simon Fraser.

• fast/layers/clip-rects-transformed-2-expected.txt: Added.
• fast/layers/clip-rects-transformed-2.html: Added.
• fast/layers/clip-rects-transformed-expected.txt: Added.
• fast/layers/clip-rects-transformed.html: Added.

10:03 PM Changeset in webkit [51174] by Laszlo Gombos

• 36 edits
  6 deletes in trunk

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
​https://bugs.webkit.org/show_bug.cgi?id=29469

• JavaScriptCore.pro:
• jsc.pro:
• wtf/unicode/qt4/UnicodeQt4.h:

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
​https://bugs.webkit.org/show_bug.cgi?id=29469

• Api/qcookiejar.cpp: Removed.
• Api/qcookiejar.h: Removed.
• Api/qgraphicswebview.cpp: (QGraphicsWebView::event):
• Api/qwebframe.cpp: (QWebFrame::load):
• Api/qwebframe.h:
• Api/qwebkitglobal.h:
• Api/qwebnetworkinterface.cpp: Removed.
• Api/qwebnetworkinterface.h: Removed.
• Api/qwebnetworkinterface_p.h: Removed.
• Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::acceptNavigationRequest): (QWebPage::acceptNavigationRequest): (QWebPage::action): (QWebPage::userAgentForUrl):
• Api/qwebpage.h:
• Api/qwebpage_p.h:
• Api/qwebview.cpp: (QWebView::load): (QWebView::event):
• Api/qwebview.h:
• QtLauncher/main.cpp: (MainWindow::print): (MainWindow::setupUI): (main):
• WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientQt::startDownload): (WebCore::FrameLoaderClientQt::createPlugin):

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
​https://bugs.webkit.org/show_bug.cgi?id=29469

No new tests as there is no change if compiled with
Qt v4.4 or later version.

• WebCore.pro:
• dom/XMLTokenizerQt.cpp: (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::doWrite): (WebCore::XMLTokenizer::startDocument): (WebCore::XMLTokenizer::parseDtd):
• platform/graphics/qt/FontQt.cpp:
• platform/graphics/qt/FontQt43.cpp: Removed.
• platform/graphics/qt/ImageQt.cpp:
• platform/network/ResourceHandleInternal.h:
• platform/network/qt/QNetworkReplyHandler.cpp:
• platform/network/qt/QNetworkReplyHandler.h:
• platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::setDefersLoading):
• platform/network/qt/ResourceRequest.h:
• platform/network/qt/ResourceRequestQt.cpp:
• platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::clearData):
• platform/qt/CookieJarQt.cpp: (WebCore::cookieJar): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
• platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode): (WebCore::windowsKeyCodeForKeyEvent):
• platform/text/qt/TextBoundaries.cpp:
• platform/text/qt/TextBreakIteratorQt.cpp:
• plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
​https://bugs.webkit.org/show_bug.cgi?id=29469

• DumpRenderTree/qt/DumpRenderTree.pro:
• DumpRenderTree/qt/ImageDiff.pro:

9:47 PM Changeset in webkit [51173] by hamaji@chromium.org

• 2 edits in trunk/WebKitTools

2009-11-18 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

GitTest.test_create_binary_patch fails if /tmp is symlink
​https://bugs.webkit.org/show_bug.cgi?id=31536

• Scripts/modules/scm_unittest.py:

9:38 PM Changeset in webkit [51172] by tkent@chromium.org

• 28 edits
  3 adds in trunk

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

• fast/dom/domListEnumeration-expected.txt: updated with new property
• fast/dom/script-tests/domListEnumeration.js: ditto
• fast/forms/script-tests/validationMessage.js: Added.
• fast/forms/validationMessage-expected.txt: Added.
• fast/forms/validationMessage.html: Added.
• platform/gtk/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

Test: fast/forms/validationMessage.html

• html/HTMLButtonElement.idl: validationMessage attribute
• html/HTMLFieldSetElement.idl: validationMessage attribute
• html/HTMLFormControlElement.cpp:
• html/HTMLFormControlElement.h:
• html/HTMLInputElement.idl: validationMessage attribute
• html/HTMLSelectElement.idl: validationMessage attribute
• html/HTMLTextAreaElement.idl: validationMessage attribute
• html/ValidityState.cpp: new method to retrieve pertinent localized text
• html/ValidityState.h:
• page/mac/WebCoreViewFactory.h:
• platform/LocalizedStrings.h:
• platform/android/LocalizedStringsAndroid.cpp:
• platform/gtk/LocalizedStringsGtk.cpp:
• platform/haiku/LocalizedStringsHaiku.cpp:
• platform/mac/LocalizedStringsMac.mm:
• platform/wx/LocalizedStringsWx.cpp:

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

• English.lproj/Localizable.strings: new localizable strings

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

• src/LocalizedStrings.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

• WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory validationMessageValueMissingText]): (-[WebViewFactory validationMessageTypeMismatchText]): (-[WebViewFactory validationMessagePatternMismatchText]): (-[WebViewFactory validationMessageTooLongText]): (-[WebViewFactory validationMessageRangeUnderflowText]): (-[WebViewFactory validationMessageRangeOverflowText]): (-[WebViewFactory validationMessageStepMismatchText]):

2009-11-18 Michelangelo De Simone <​micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

• WebCoreLocalizedStrings.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

9:09 PM Changeset in webkit [51171] by Laszlo Gombos

• 2 edits in trunk/WebCore

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

Fix a typo. Remove the trailing semicolon
from an include directive after r51137.

No new tests as there is no functional change.

• platform/qt/QWebPageClient.h:

8:52 PM Changeset in webkit [51170] by Laszlo Gombos

• 2 edits in trunk/WebCore

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r51159.

Include float.h for DBL_MANT_DIG. Not sure why this
is not a problem for other ports.

• html/HTMLInputElement.cpp:

7:15 PM Changeset in webkit [51169] by rolandsteiner@chromium.org

• 4 edits
  2 adds in trunk

WebCore: Bug 31574 - Crashing bug when removing <ruby> element
(​https://bugs.webkit.org/show_bug.cgi?id=31574)

Reviewed by Darin Adler.

Cause of the bug:
1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
4.) this triggers the special handling of child removal in RenderRubyRun that

causes it to destroy itself

5.) On returning from all this the renderer crashes when accessing a member

or virtual function on this now illegal object.

I therefore added a flag that tracks if the ruby run is being destroyed.
If so, avoid doing the special handling in removeChild that caused this.
It's not the most elegant solution, but the easiest to implement without
touching unrelated code. Also, it's self-documenting.

Test: fast/ruby/ruby-remove.html

• rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::destroy):
(WebCore::RenderRubyRun::removeChild):

• rendering/RenderRubyRun.h:

LayoutTests: Bug 31574 - Crashing bug when removing <ruby> element
(​https://bugs.webkit.org/show_bug.cgi?id=31574)

Reviewed by Darin Adler.

Layout test to verify it no longer crashes when the <ruby> element
is being removed.

• fast/ruby/ruby-remove-expected.txt: Added.
• fast/ruby/ruby-remove.html: Added.

7:12 PM Changeset in webkit [51168] by tkent@chromium.org

• 7 edits in trunk/JavaScriptCore

2009-11-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Move UString::from(double) implementation to new
WTF::doubleToStringInJavaScriptFormat(), and expose it because WebCore
code will use it.
​https://bugs.webkit.org/show_bug.cgi?id=31330

• Introduce new function createRep(const char*, unsigned) and UString::UString(const char*, unsigned) to reduce 2 calls to strlen().
• Fix a bug that dtoa() doesn't update *rve if the input value is NaN or Infinity.

No new tests because this doesn't change the behavior.

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• runtime/UString.cpp: (JSC::createRep): (JSC::UString::UString): (JSC::UString::from): Move the code to doubleToStringInJavaScriptFormat().
• runtime/UString.h:
• wtf/dtoa.cpp: (WTF::dtoa): Fix a bug about rve. (WTF::append): A helper for doubleToStringInJavaScriptFormat(). (WTF::doubleToStringInJavaScriptFormat): Move the code from UString::from(double).
• wtf/dtoa.h:

6:53 PM Changeset in webkit [51167] by eric@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-18 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Adler.

Configuration for Chromium Build Slaves.

​https://bugs.webkit.org/show_bug.cgi?id=31442

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/master.cfg:

6:46 PM Changeset in webkit [51166] by eric@webkit.org

• 4 edits in trunk

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
​https://bugs.webkit.org/show_bug.cgi?id=31643

• JavaScriptCore.pro:

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
​https://bugs.webkit.org/show_bug.cgi?id=31643

No new tests as there is no functional change.

• WebCore.pro:

6:38 PM Changeset in webkit [51165] by eric@webkit.org

• 1 edit
  1 add in trunk/WebCore

2009-11-18 Yong Li <​yong.li@torchmobile.com>

Reviewed by Eric Seidel.

Implement TextBoundaries for WINCE port.
​https://bugs.webkit.org/show_bug.cgi?id=27371

• platform/text/wince/TextBoundariesWince.cpp: Added.

6:30 PM Changeset in webkit [51164] by eric@webkit.org

• 1 edit
  2 adds in trunk/WebCore

2009-11-18 Yong Li <​yong.li@torchmobile.com>

Reviewed by Eric Seidel.

Implement TextBreakIterator for WINCE port.
​https://bugs.webkit.org/show_bug.cgi?id=27371

• platform/text/wince/TextBreakIteratorWince.cpp: Added.

6:15 PM Changeset in webkit [51163] by tkent@chromium.org

• 5 edits
  18 adds in trunk

2009-11-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Tests for ValidityState.typeMismatch for the following types of INPUT element:

date, datetime, datetime-local, month, time and week

​https://bugs.webkit.org/show_bug.cgi?id=31342

• fast/forms/ValidityState-typeMismatch-date-expected.txt: Added.
• fast/forms/ValidityState-typeMismatch-date.html: Added.
• fast/forms/ValidityState-typeMismatch-datetime-expected.txt: Added.
• fast/forms/ValidityState-typeMismatch-datetime.html: Added.
• fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt: Added.
• fast/forms/ValidityState-typeMismatch-datetimelocal.html: Added.
• fast/forms/ValidityState-typeMismatch-month-expected.txt: Added.
• fast/forms/ValidityState-typeMismatch-month.html: Added.
• fast/forms/ValidityState-typeMismatch-time-expected.txt: Added.
• fast/forms/ValidityState-typeMismatch-time.html: Added.
• fast/forms/ValidityState-typeMismatch-week-expected.txt: Added.
• fast/forms/ValidityState-typeMismatch-week.html: Added.
• fast/forms/script-tests/ValidityState-typeMismatch-date.js: Added.
• fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: Added.
• fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: Added.
• fast/forms/script-tests/ValidityState-typeMismatch-month.js: Added.
• fast/forms/script-tests/ValidityState-typeMismatch-time.js: Added.
• fast/forms/script-tests/ValidityState-typeMismatch-week.js: Added.

2009-11-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Add support for ValidityState.typeMismatch for the following INPUT types:

date datetime datetime-local month time week

​https://bugs.webkit.org/show_bug.cgi?id=31342

Tests: fast/forms/ValidityState-typeMismatch-date.html

fast/forms/ValidityState-typeMismatch-datetime.html
fast/forms/ValidityState-typeMismatch-datetimelocal.html
fast/forms/ValidityState-typeMismatch-month.html
fast/forms/ValidityState-typeMismatch-time.html
fast/forms/ValidityState-typeMismatch-week.html

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::formStringToISODateTime): Check the type validity of the specified type and string using the ISODateTime class.
• html/HTMLInputElement.h:
• html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): Check the type validity for date, datetime, datetime-local, month, time and week with HTMLInputElemtn::formStringToISODateTime()

6:13 PM Changeset in webkit [51162] by mjs@apple.com

• 4 edits in trunk/WebCore

2009-11-18 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
​https://bugs.webkit.org/show_bug.cgi?id=31237

Also speeds up Dromaeo DOM Core tests by 1.31x.

• bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^{2) behavior. The subtree mark bit was no longer effective; instead I changed things so only a node that has no ancestors with wrappers would do marking; there should be only one in the typical case (the root of the detached subtree).}
• dom/Node.cpp: (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
• dom/Node.h: ditto

6:07 PM Changeset in webkit [51161] by Darin Adler

• 7 edits in trunk/WebCore

Get rid of the redundant strokeType and fillType data members on
a GraphicsContext as well as the FillOrStrokeType enum. Use
null pointers instead.

Reviewed by Sam Weinig.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokeColor): Null out the pattern
and gradient.
(WebCore::GraphicsContext::setFillColor): Ditto.
(WebCore::GraphicsContext::setStrokePattern): Null out the graident.
(WebCore::GraphicsContext::setFillPattern): Ditto.
(WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
(WebCore::GraphicsContext::setFillGradient): Ditto.

• platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::setPlatformFill): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::setPlatformStroke): Ditto.

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
(WebCore::GraphicsContext::applyFillPattern): Ditto.
(WebCore::calculateDrawingMode): Use fillPattern and strokePattern
to see if there is a pattern instead of fillType and strokeType.
(WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
fillPattern, and strokePattern instead of fillType and strokeType.
(WebCore::GraphicsContext::fillPath): Added FIXME about color space that
is used in the pattern and gradient case probably erroneously. Moved
gradient code inside an if statement. Streamlined pattern code and
use an if statement. No switch any more.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.
(WebCore::GraphicsContext::strokeRect): Ditto.

• platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.

• platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
(WebCore::GraphicsContext::fillRect): Ditto.

6:01 PM Changeset in webkit [51160] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-18 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

workqueue.py results in totally broken commit-queue UI
​https://bugs.webkit.org/show_bug.cgi?id=31645

• Scripts/bugzilla-tool:
  • Remove unneeded use of PatchCollection.
  • Grab a new copy of the cq'd patches every run of the queue.

5:48 PM Changeset in webkit [51159] by eric@webkit.org

• 9 edits
  12 adds in trunk

2009-11-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Add tests for ValidityState.stepMismatch.
​https://bugs.webkit.org/show_bug.cgi?id=31331

• fast/forms/ValidityState-stepMismatch-number-expected.txt: Added.
• fast/forms/ValidityState-stepMismatch-number.html: Added.
• fast/forms/ValidityState-stepMismatch-range-expected.txt: Added.
• fast/forms/ValidityState-stepMismatch-range.html: Added.
• fast/forms/ValidityState-stepMismatch-unsupported-expected.txt: Added.
• fast/forms/ValidityState-stepMismatch-unsupported.html: Added.
• fast/forms/input-step-expected.txt: Added.
• fast/forms/input-step.html: Added.
• fast/forms/script-tests/ValidityState-stepMismatch-number.js: Added.
• fast/forms/script-tests/ValidityState-stepMismatch-range.js: Added.
• fast/forms/script-tests/ValidityState-stepMismatch-unsupported.js: Added.
• fast/forms/script-tests/input-step.js: Added.

2009-11-18 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Support for step attribute and ValidityStae.stepMismatch for
type=number and range. stepMismatch will be false if the
difference between the current value and a multiple of the step
value is very small.

Change the behavior of RenderSlider so that it always has a value
rounded to the step attribute value.

​https://bugs.webkit.org/show_bug.cgi?id=31331

Tests: fast/forms/ValidityState-stepMismatch-number.html

fast/forms/ValidityState-stepMismatch-range.html
fast/forms/ValidityState-stepMismatch-unsupported.html
fast/forms/input-step.html

• html/HTMLAttributeNames.in: Add "step".
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::getStepParameters): (WebCore::HTMLInputElement::getAllowedValueStep):
• html/HTMLInputElement.h:
• html/HTMLInputElement.idl: Add "step".
• html/ValidityState.cpp: (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
• html/ValidityState.h:
• rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::clampValue):

5:27 PM Changeset in webkit [51158] by dimich@chromium.org

• 2 edits in trunk/WebCore

Need to ASSERT(isMainThread()) in ThreadShared methods.
​https://bugs.webkit.org/show_bug.cgi?id=31637

Reviewed by Darin Adler.

Added ASSERT(IsMainThread()) to all following methods:

• platform/TreeShared.h:

(WebCore::TreeShared::TreeShared):
(WebCore::TreeShared::~TreeShared):
(WebCore::TreeShared::ref):
(WebCore::TreeShared::deref):
(WebCore::TreeShared::setParent):
(WebCore::TreeShared::parent):

5:00 PM Changeset in webkit [51157] by eric@webkit.org

• 3 edits in trunk/WebCore

2009-11-18 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Eric Seidel.

Add plugin visibility manual test

​https://bugs.webkit.org/show_bug.cgi?id=31542

• manual-tests/plugins/windowed.html:
• manual-tests/plugins/windowless.html:

4:52 PM Changeset in webkit [51156] by eric@webkit.org

• 2 edits
  1 add in trunk/WebCore

2009-11-18 Patrick Mueller <​Patrick_Mueller@us.ibm.com>

Reviewed by Pavel Feldman.

Web Inspector - remember last script displayed in Scripts panel
​https://bugs.webkit.org/show_bug.cgi?id=27552

Manual test added

• inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showScript): (WebInspector.ScriptsPanel.prototype.showResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._goBack): (WebInspector.ScriptsPanel.prototype._goForward):
• manual-tests/inspector/remember-last-script.html: Added.

4:43 PM Changeset in webkit [51155] by eric@webkit.org

• 2 edits in trunk/WebCore

2009-11-18 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

Win chromium is slow to draw transparent texts
​https://bugs.webkit.org/show_bug.cgi?id=31258

Create bounded transparency layers instead of just clipping.

No new tests because this is just a performance improvement.

• platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):

4:35 PM Changeset in webkit [51154] by eric@webkit.org

• 8 edits in trunk

2009-11-18 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Update expected result after Qt4.6 upgrade.
​https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

• platform/qt/editing/deleting/5408255-expected.txt:

2009-11-18 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Add support for displaying deleteButton.
​https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

• WebCore.qrc:
• platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):

2009-11-18 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Add support for displaying deleteButton.
​https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

• Api/qwebsettings.cpp: (graphics):
• Api/qwebsettings.h:

4:26 PM Changeset in webkit [51153] by eric@webkit.org

• 2 edits in trunk/WebCore

2009-11-18 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Eric Seidel.

Fix Qt build without JavaScript debugger.

​https://bugs.webkit.org/show_bug.cgi?id=31575

• page/Console.idl:

4:18 PM Changeset in webkit [51152] by eric@webkit.org

• 2 edits in trunk/WebKitSite

2009-11-18 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

Make 80 patches a formal requirement for reviewership
​https://bugs.webkit.org/show_bug.cgi?id=31313
Per discussion on the webkit-reviewers list:
​http://lists.webkit.org/mailman/private.cgi/webkit-reviewers/2009-November/000795.html

• coding/commit-review-policy.html:

4:05 PM Changeset in webkit [51151] by dbates@webkit.org

• 3 edits
  10 adds in trunk

2009-11-18 Daniel Bates <​dbates@webkit.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/7138265>

Fixes an issue where setting the height of a table row programmatically
(via JavaScript) causes the table to be improperly rendered because the
height of each row in the table is not recalculated with respect to the
CSS height property.

In particular, programmatically setting the height of some table row causes
the rows of that table to be rendered with a height equal to the minimum
height required by the cells in that row, regardless of any specified cell
heights. Instead, when RenderTableSection::recalcCells is called, the height
of each row should be set to the CSS height property just as we do in
RenderTableSection::addChild.

Test: fast/table/row-height-recalc2.html

• rendering/RenderTableSection.cpp: (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added. (WebCore::RenderTableSection::addChild): Moved code that set row height into method WebCore::setRowHeightToRowStyleHeightIfNotRelative. (WebCore::RenderTableSection::recalcCells): Modified to call WebCore::setRowHeightToRowStyleHeightIfNotRelative.

2009-11-18 Daniel Bates <​dbates@webkit.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/7138265>

Tests that setting the height of a table row programmatically (via JavaScript)
recalculates the height of the rows in the table.

• fast/table/row-height-recalc2.html: Added.
• platform/mac/fast/table/row-height-recalc2-expected.checksum: Added.
• platform/mac/fast/table/row-height-recalc2-expected.png: Added.
• platform/mac/fast/table/row-height-recalc2-expected.txt: Added.
• platform/qt/fast/table/row-height-recalc2-expected.checksum: Added.
• platform/qt/fast/table/row-height-recalc2-expected.png: Added.
• platform/qt/fast/table/row-height-recalc2-expected.txt: Added.
• platform/win/fast/table/row-height-recalc2-expected.checksum: Added.
• platform/win/fast/table/row-height-recalc2-expected.png: Added.
• platform/win/fast/table/row-height-recalc2-expected.txt: Added.

3:57 PM Changeset in webkit [51150] by jparent@chromium.org

• 2 edits in trunk/LayoutTests

Reduce flakiness in zero-duration-with-non-zero-delay-end.html by
increasing a timeout.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31646

• transitions/zero-duration-with-non-zero-delay-end.html:

3:47 PM Changeset in webkit [51149] by zoltan@webkit.org

• 11 edits in trunk/WebCore

Allow custom memory allocation control for the part of platform directory in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=31473

Reviewed by Darin Adler.

Inherits the following classes from FastAllocBase because these are
instantiated by 'new':

class AnimationList - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
class Color - instantiated at WebCore/rendering/RenderTheme.cpp:48
struct Length - instantiated at WebCore/platform/Length.cpp:103
class PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
class ContextMenuItem - instantiated at WebCore/platform/ContextMenu.cpp:70
class DeprecatedPtrList - instantiated at WebCore/rendering/RenderBlock.cpp:2284

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:

class GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
class FontCache - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
struct MediaPlayerFactory - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
class DeprecatedPtrListNode - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53

• platform/ContextMenuItem.h:
• platform/DeprecatedPtrList.h:
• platform/DeprecatedPtrListImpl.cpp:
• platform/Length.h:
• platform/PlatformKeyboardEvent.h:
• platform/animation/AnimationList.h:
• platform/graphics/Color.h:
• platform/graphics/FontCache.h:
• platform/graphics/GraphicsContextPrivate.h:
• platform/graphics/MediaPlayer.cpp:

3:46 PM Changeset in webkit [51148] by eric@webkit.org

• 10 edits in trunk

2009-11-18 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31186

Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.

No functionality was changed. So, no tests were included.

• bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
• dom/Document.cpp: (WebCore::Document::setFocusedNode):
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited. (WebCore::RenderTextControl::subtreeHasChanged):
• rendering/RenderTextControl.h: (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited. (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited. (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
• rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
• wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):

2009-11-18 Daniel Bates <​dbates@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31186

Changes associated with renaming RenderTextControl::isUserEdited.

• DOMHTMLClasses.cpp: (DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited. (DOMHTMLTextAreaElement::isUserEdited): Ditto.

3:44 PM Changeset in webkit [51147] by weinig@apple.com

• 8 edits
  3 deletes in trunk

Make the Mac Geolocation API async.

Reviewed by Anders Carlsson.

WebKit:

• WebKit.xcodeproj/project.pbxproj: Remove WebGeolocation.

WebKit/mac:

• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::requestGeolocationPermissionForFrame):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener allow]):
(-[WebGeolocationPolicyListener deny]):
Add WebGeolocationPolicyListener implementation of the new WebGeolocationPolicyListener
protocol and use if to implement requestGeolocationPermissionForFrame using the new async
API.

• WebCoreSupport/WebGeolocation.mm: Removed.
• WebCoreSupport/WebGeolocationInternal.h: Removed.
• WebCoreSupport/WebGeolocationMock.mm: Remove bogus include.
• WebCoreSupport/WebGeolocationPrivate.h: Removed.
• WebView/WebUIDelegatePrivate.h: Remove requestGeolocationPermission and add

WebGeolocationPolicyListener protocol and decidePolicyForGeolocationRequestFromOrigin delegate
method.

WebKitTools:

Update DRT to use the new async Mac Geolocation API.

• DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):

3:36 PM Changeset in webkit [51146] by eric@webkit.org

• 3 edits
  1 delete in trunk/WebCore

2009-11-18 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
​https://bugs.webkit.org/show_bug.cgi?id=31499

No new tests, just a build cleanup.

• WebCore.gypi:
• bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
• bindings/v8/custom/V8CustomBinding.h:

3:29 PM Changeset in webkit [51145] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Add and option to toggle HTML5 datalist support to build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=31599

• Scripts/build-webkit:

3:25 PM Changeset in webkit [51144] by Nate Chapin

• 4 edits in trunk

2009-11-18 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

Remove Chromium's unnecessary dependency on wtf's tcmalloc files.

​https://bugs.webkit.org/show_bug.cgi?id=31648

• JavaScriptCore.gyp/JavaScriptCore.gyp:

3:23 PM Applications using WebKit edited by blythe_yee@apple.com

(diff)

3:18 PM Changeset in webkit [51143] by kevino@webkit.org

• 15 edits in trunk

Reviewed by Kevin Ollivier.

Enable wx plugin support using the Windows implementation as a base.

​https://bugs.webkit.org/show_bug.cgi?id=31636

3:10 PM Changeset in webkit [51142] by eric@webkit.org

• 2 edits in trunk/WebKit/chromium

2009-11-18 Evan Stade <​estade@chromium.org>

Reviewed by Darin Fisher.

Menu button shows wrong content in Chromium
​https://bugs.webkit.org/show_bug.cgi?id=31448

Make context menu button (VK_APPS) show context menu for node that has
keyboard focus. This affects both the content and the positioning.

• src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):

3:02 PM Changeset in webkit [51141] by eric@webkit.org

• 2 edits in trunk/JavaScriptCore

2009-11-18 Thiago Macieira <​thiago.macieira@nokia.com>

Reviewed by Gavin Barraclough.

[Qt] Implement symbol hiding for JSC's JIT functions.

These functions are implemented directly in assembly, so they need the
proper directives to enable/disable visibility. On ELF systems, it's
.hidden, whereas on Mach-O systems (Mac) it's .private_extern. On
Windows, it's not necessary since you have to explicitly export. I
also implemented the AIX idiom, though it's unlikely anyone will
implement AIX/POWER JIT.
​https://bugs.webkit.org/show_bug.cgi?id=30864

• jit/JITStubs.cpp:

2:49 PM Changeset in webkit [51140] by eric@webkit.org

• 1 edit
  2 adds in trunk/WebCore

2009-11-18 Andrei Popescu <​andreip@google.com>

Reviewed by Dimitri Glazkov.

[Android] Add shared timer and sound utilities to platform/android
​https://bugs.webkit.org/show_bug.cgi?id=31584

No new tests required, this is platform specific code.

• platform/android/SharedTimerAndroid.cpp: Added. (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
• platform/android/SoundAndroid.cpp: Added. (WebCore::systemBeep):

2:41 PM Changeset in webkit [51139] by eric@webkit.org

• 4 edits in trunk/WebCore

2009-11-18 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Fix profile tree nodes loss after focus / restore actions.

Focusing on a node is currently implemented via nodes reattaching
with some caching involved. It seems that not all code was updated
to handle this scenario correctly.

​https://bugs.webkit.org/show_bug.cgi?id=31553

• inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._restore): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
• inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.insertChild): (WebInspector.DataGridNode.prototype._detach): (WebInspector.DataGridNode.prototype.savePosition): (WebInspector.DataGridNode.prototype.restorePosition):
• inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridTree.prototype.focus): (WebInspector.TopDownProfileDataGridTree.prototype.restore):

2:37 PM Changeset in webkit [51138] by dbates@webkit.org

• 2 edits in trunk/WebKitSite

2009-11-18 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31610

Adds property "min-width" to #title so that the width of the title
element on each page is at least 790px. In particular, this makes
the page <​http://webkit.org/security/security-group-members.html>
consistent, in appearance, to the rest of the site.

• css/main.css:

2:33 PM Changeset in webkit [51137] by eric@webkit.org

• 2 edits in trunk/WebCore

2009-11-18 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPageClient.h needs in some cases QCursor, but it does not
include it
​https://bugs.webkit.org/show_bug.cgi?id=31527

No new tests as this is just a coding style fix that affects the
build of some not yet submitted patches (i.e. for bug 30173).

• platform/qt/QWebPageClient.h:

2:25 PM Changeset in webkit [51136] by eric@webkit.org

• 2 edits in trunk/WebCore

2009-11-18 Nicolas Roard <​nicolas@roard.com>

Reviewed by Dimitri Glazkov.

InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
​https://bugs.webkit.org/show_bug.cgi?id=31504

• inspector/InspectorTimelineAgent.h:Added the guard.

2:08 PM Changeset in webkit [51135] by snej@chromium.org

• 2 edits in trunk/WebCore

Build fix to my previous checkin, for Windows Chromium

• svg/SVGAnimatedProperty.h:

(WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.

2:05 PM Changeset in webkit [51134] by Joseph Pecoraro

• 5 edits in trunk/WebCore

2009-11-18 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Directly Access <head> Instead of Searching for It
​https://bugs.webkit.org/show_bug.cgi?id=31641

Changed old access of the head element (document.getElementsByTagName)
to just use the document.head accessor.

• inspector/front-end/FontView.js: (WebInspector.FontView):
• inspector/front-end/InjectedScript.js: (InjectedScript.addStyleSelector):
• inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
• inspector/front-end/inspector.js: (windowLoaded):

2:04 PM Changeset in webkit [51133] by weinig@apple.com

• 3 edits in trunk/WebCore

Fix two Geolocation assertions.

Reviewed by Anders Carlsson.

• page/Chrome.cpp:

(WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
is not called from JS.

• page/Geolocation.cpp:

(WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
a RefPtr first.

2:02 PM Changeset in webkit [51132] by ap@apple.com

• 2 edits in trunk/WebCore

Case sensitive file system build fix.

• platform/network/Credential.h: It's not WTF, just wtf.

1:54 PM Changeset in webkit [51131] by agolden@apple.com

• 4 edits in trunk/WebCore

Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
objects and WebCore::Credential objects without losing certificate information.

Reviewed by Alexey Proskuryakov

1:49 PM Changeset in webkit [51130] by darin@chromium.org

• 5 edits in trunk/WebKit/chromium

2009-11-17 Darin Fisher <​darin@chromium.org>

Reviewed by Dmitry Titov.

Minor cleanup in WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=31616

• public/WebFormElement.h: Add missing WEBKIT_API prefix.
• public/WebNode.h: Add missing WEBKIT_API prefix.
• src/WebFormElement.cpp: (WebKit::WebFormElement::action): Make action getter const.
• src/WebNode.cpp: (WebKit::WebNode::frame): Utilize WebFrameImpl::fromFrame.

1:31 PM Changeset in webkit [51129] by oliver@apple.com

• 2 edits in trunk/LayoutTests

Update expected results of fixed test.

12:46 PM Changeset in webkit [51128] by oliver@apple.com

• 4 edits in trunk

Interpreter may do an out of range access when throwing an exception in the profiler.
​https://bugs.webkit.org/show_bug.cgi?id=31635

Reviewed by Alexey Proskuryakov.

Add bounds check.

12:25 PM Changeset in webkit [51127] by dimich@chromium.org

• 4 edits in trunk/WebCore

Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
​https://bugs.webkit.org/show_bug.cgi?id=31615

Reviewed by Eric Seidel.

• dom/Document.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::ScriptExecutionContextTaskTimer::fired):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::performTask):
(WebCore::Document::postTask):

• dom/ScriptExecutionContext.cpp:
• dom/ScriptExecutionContext.h:

12:09 PM Changeset in webkit [51126] by ap@apple.com

• 2 edits in trunk/LayoutTests

Disabling WebSocket tests on Tiger back, they still hang.

• platform/mac-tiger/Skipped:

11:57 AM Changeset in webkit [51125] by snej@chromium.org

• 9 edits in trunk/WebCore

Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
by causing the right v8-to-WebCore conversion function to be called for every parameter.
This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
To enforce correctness, I added a mode that disables implicit
String-->AtomicString conversions while compiling the generated bindings.
​https://bugs.webkit.org/show_bug.cgi?id=31168

Reviewed by Darin Adler.

• bindings/scripts/CodeGeneratorV8.pm: Generate usage of V8Parameter class.
• bindings/v8/DerivedSourcesAllInOne.cpp: Enable NO_IMPLICIT_ATOMICSTRING.
• bindings/v8/V8Binding.h: Add V8Parameter class.
• css/WebKitCSSKeyframesRule.h: Make AtomicString conversions explicit.
• dom/Document.idl: Remove obsolete [HintAtomic] annotation.
• platform/text/AtomicString.h: Added NO_IMPLICIT_ATOMICSTRING option.
• svg/SVGAnimatedTemplate.h: Change some return types to String to avoid implicit conversion.
• svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.

11:49 AM Changeset in webkit [51124] by Darin Adler

• 3 edits in trunk/WebCore

Move FillOrStrokeType out of public header.

Reviewed by Dan Bernstein.

• platform/graphics/GraphicsContext.h: Updated copyright date to cover

some years we published Apple changes, sorted forward declarations,
removed FillOrStrokeType enum.

• platform/graphics/GraphicsContextPrivate.h: Updated copyright date

to cover some years we published Apple changes, sorted includes,
moved FillOrStrokeType enum here.

11:37 AM Changeset in webkit [51123] by Csaba Osztrogonác

• 2 edits in trunk/JavaScriptCore

Fix the clobber list of cacheFlush for ARM and Thumb2 on Linux
​https://bugs.webkit.org/show_bug.cgi?id=31631

Patch by Gabor Loki <​loki@inf.u-szeged.hu> on 2009-11-18
Reviewed by Darin Adler.

• jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

11:23 AM Changeset in webkit [51122] by cmarrin@apple.com

• 17 edits in trunk

Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
​https://bugs.webkit.org/show_bug.cgi?id=31601

These are used to debug accelerated compositing layers. I removed
the platform specific code from GraphicsLayerCA.mm and added calls
to GraphicsLayerClient to get it from the higher levels. The values
now get cached in RenderLayerCompositing and are queried from there
by RenderLayerBacking (which implements the GraphicsLayerClient interface).

10:26 AM Changeset in webkit [51121] by pfeldman@chromium.org

• 3 edits in trunk/WebCore

2009-11-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Get rid of metrics and properties sidebars'
flickering.

​https://bugs.webkit.org/show_bug.cgi?id=31629

• inspector/front-end/MetricsSidebarPane.js:
• inspector/front-end/PropertiesSidebarPane.js:

10:21 AM Changeset in webkit [51120] by jparent@chromium.org

• 2 edits in trunk/LayoutTests

Eliminate flakiness in file-URL-with-port-number by removing a setTimeout.
The timeout caused the test to fail about 2% of the time on the Chromium builders.
The timeout exists to catch cases where the iframe does not load, but the test
framework already will handle this (albeit with a longer timeout).

Reviewed by Dmitry Titov.

• fast/loader/file-URL-with-port-number.html:

10:12 AM Changeset in webkit [51119] by bweinstein@apple.com

• 3 edits in trunk/WebCore

Fixes <​http://webkit.org/b/31606>.
Web Inspector: Enter/Return key should enter edit mode for Editable Fields.

Reviewed by Pavel Feldman.

This implements Enter starting editing mode in an editable DataGrid. If the
DataGrid is editable and the user hits return, startEditing the first child
of the selected node. Also refactored some editing functions to take an
event target instead of the event itself, because the functions only needed
the target. Lastly, added had return in editing mode stop propogation, because
when enter was hit to confirm text, it would propagate back to the datagrid
and try to start editing again.

• inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._ondblclick):
(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype.handleKeyEvent):
(WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
(WebInspector.DataGrid.prototype._mouseDownInDataTable):
(WebInspector.DataGrid.prototype._clickInDataTable):

• inspector/front-end/inspector.js:

(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):

9:57 AM Changeset in webkit [51118] by benm@google.com

• 3 edits
  3 adds in trunk

HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
​https://bugs.webkit.org/show_bug.cgi?id=31593

Reviewed by Darin Adler.

WebCore:

Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.

LayoutTests:

• fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-whitespace.js: Added.
• fast/dom/HTMLAnchorElement/set-href-attribute-whitespace-expected.txt: Added.
• fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html: Added.

9:38 AM Changeset in webkit [51117] by pfeldman@chromium.org

• 2 edits in trunk/WebCore

2009-11-18 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Touch InspectorController so that frontend
JS files are deployed on Windows.

• inspector/InspectorController.cpp:

9:30 AM Changeset in webkit [51116] by ap@apple.com

• 2 edits in trunk/LayoutTests

Trying to enable WebSocket tests on Tiger again, now that bug 31603 is fixed.

• platform/mac-tiger/Skipped:

9:25 AM Changeset in webkit [51115] by pfeldman@chromium.org

• 3 edits in trunk

2009-11-18 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: clone timeline records array instead of
copying reference on invalidate all.

​https://bugs.webkit.org/show_bug.cgi?id=31596

• inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):

8:38 AM Changeset in webkit [51114] by kenneth@webkit.org

• 2 edits in trunk/WebKitTools

Change the initialization order so that the controllers
will be created before exporting them to the JS DOM window.

Reviewed by Simon Hausmann.

• DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):

8:17 AM QtWebKitAPI edited by Simon Hausmann

(diff)

8:16 AM Changeset in webkit [51113] by kenneth@webkit.org

• 2 edits in trunk/WebKitTools

Fix a code copy and paste error. m_page should be page.

Reviewed by Simon Hausmann.

• DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::createWindow):

8:15 AM QtWebKitAPI edited by Simon Hausmann

(diff)

8:14 AM QtWebKitAPI edited by Simon Hausmann

(diff)

8:05 AM QtWebKitAPI created by Simon Hausmann

7:49 AM QtWebKitContrib edited by Simon Hausmann

(diff)

7:02 AM Changeset in webkit [51112] by Simon Fraser

• 2 edits in trunk/WebCore

2009-11-18 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Elements don't drop out of compositing layers when animation ends
​https://bugs.webkit.org/show_bug.cgi?id=31613
<rdar://problem/7402913>

Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
are compositing anyway for other reasons. Doing so can cause those layers
to stay in compositing mode even after animations finish, because needsToBeComposited()
continues to return true.

No new tests because it's not possible to determine which elements are in
compositing layers from DRT output.

• rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):

6:27 AM Changeset in webkit [51111] by Simon Hausmann

• 2 edits in trunk/WebKit/qt

[Qt] Make the QWebElement::render() test pass when pixmaps aren't 32 bit.

Patch by Paul Olav Tvete <​paul.tvete@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

• tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::render):

5:22 AM Changeset in webkit [51110] by Simon Hausmann

• 2 edits in trunk/JavaScriptCore

[Qt] Fix detection of linux-g++

Patch by Harald Fernengel <​harald.fernengel@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

Never use "linux-g++*" to check for linux-g++, since this will break embedded
builds which use linux-arm-g++ and friends. Use 'linux*-g++*' to check for any
g++ on linux mkspec.

• JavaScriptCore.pri:

5:20 AM Changeset in webkit [51109] by kov@webkit.org

• 2 edits in trunk/WebKit/gtk

Properly localize documentation strings for the tab-key-cycles-through-elements property.

5:20 AM Changeset in webkit [51108] by kov@webkit.org

• 4 edits in trunk

Ensure that tabKeyCyclesThroughElements is true by default.

5:19 AM Changeset in webkit [51107] by Simon Hausmann

• 2 edits in trunk/WebKit/qt

Clarify and simplify the legal section in the overview documentation,
after review with our legal team.

Reviewed by Tor Arne Vestbø.

• docs/qtwebkit.qdoc:

4:58 AM Changeset in webkit [51106] by vestbo@webkit.org

• 2 edits in trunk/WebKit/qt

[Qt] Add QtLauncher support for opening links in the default browser

Reviewed by Simon Hausmann.

This can be triggered by either the context menu or by clicking a link
while holding down the Alt key. Opening a link in a new windows is
triggered by holding down Shift.

• QtLauncher/main.cpp:

4:53 AM Changeset in webkit [51105] by Girish Ramakrishnan

• 3 edits in trunk/WebCore

[Qt] Mac Plugins: Remove null timer

Reviewed by Tor Arne Vestbø.

A null timer was used to send mouse move events. Instead, we now use
move events to send nullEvent. This brings down CPU usage by 20-30%.

​https://bugs.webkit.org/show_bug.cgi?id=31624

4:48 AM Changeset in webkit [51104] by kov@webkit.org

• 2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

[GTK] Failing test media/video-document-types.html
​https://bugs.webkit.org/show_bug.cgi?id=31352

Match what Mac has been doing since r36001: cancel the main load,
and handle failures caused by 'will be handled by plugin' errors.

Covered by test media/video-document-types.html

• WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::committedLoad):
(WebKit::FrameLoaderClient::shouldFallBack):

2:29 AM Changeset in webkit [51103] by Simon Hausmann

• 3 edits
  4 adds in trunk

[Qt] WebKit crashes when loading certain SVG images

Patch by Benjamin Poulain <​benjamin.poulain@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

WebCore:

Check if the familly exist before creating the PlatformData from it.

​https://bugs.webkit.org/show_bug.cgi?id=29443

Test: svg/text/text-font-invalid.html

• platform/graphics/qt/FontFallbackListQt.cpp:

(WebCore::FontFallbackList::fontDataAt):

LayoutTests:

Added a test for a crash of QtWebkit when loading SVG images.

​https://bugs.webkit.org/show_bug.cgi?id=29443

• svg/text/resources/text-font-invalid.svg: Added.
• svg/text/text-font-invalid-expected.txt: Added.
• svg/text/text-font-invalid.html: Added.

Nov 17, 2009:

10:51 PM Changeset in webkit [51102] by darin@chromium.org

• 2 edits in trunk/WebCore

2009-11-17 Nicolas Weber <​thakis@chromium.org>

Reviewed by Darin Fisher.

Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
after navigation.
​https://bugs.webkit.org/show_bug.cgi?id=31609

• platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showExternal): Set parent for external dropdowns, so that |PopupListBox::hidePopup()| can successfully notify its parent's client.

9:19 PM Changeset in webkit [51101] by tkent@chromium.org

• 4 edits
  3 adds in trunk

2009-11-17 Hayato Ito <​hayato@google.com>

Reviewed by Darin Adler.

Avoid infinite mutual recursion when deeply nested tags are loaded
​https://bugs.webkit.org/show_bug.cgi?id=30651

• fast/parser/block-nesting-cap-table-expected.txt: Added.
• fast/parser/block-nesting-cap-table.html: Added.
• fast/parser/script-tests/block-nesting-cap-table.js: Added.

2009-11-17 Hayato Ito <​hayato@google.com>

Reviewed by Darin Adler.

Avoid infinite mutual recursion when deeply nested tags are loaded
​https://bugs.webkit.org/show_bug.cgi?id=30651

Test: fast/parser/block-nesting-cap-table.html

• html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken): (WebCore::tagPriorityOfNode): (WebCore::HTMLParser::limitBlockDepth): (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth): (WebCore::HTMLParser::insertNode):
• html/HTMLParser.h:

8:18 PM Changeset in webkit [51100] by jhoneycutt@apple.com

• 2 edits in trunk/JavaScriptCore

Add JSContextRefPrivate.h to list of copied files.

Reviewed by Mark Rowe.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:

5:12 PM Changeset in webkit [51099] by mrowe@apple.com

• 2 edits in trunk/WebKitTools

<​http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X

Reviewed by Alexey Proskuryakov.

• pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.

This prevents symlinks from confusing the descendant check.

5:08 PM Changeset in webkit [51098] by bfulgham@webkit.org

• 2 edits in trunk/WebCore

Rubber-stamped by Alexey Proskuryakov.

Final clean-ups for minor coding standard violations.
​https://bugs.webkit.org/show_bug.cgi?id=26102.

• platform/graphics/cairo/GraphicsContextCairo.cpp:

4:35 PM Changeset in webkit [51097] by dimich@chromium.org

• 5 edits
  2 adds in trunk

WebCore: In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
​https://bugs.webkit.org/show_bug.cgi?id=31567

Patch by Johnny Ding <​jnd@chromium.org> on 2009-11-17
Reviewed by Darin Adler.

• dom/ScriptElement.cpp:

(WebCore::ScriptElementData::shouldExecuteAsJavaScript):

LayoutTests: In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
Change the original test to pure js test, and test the situation about script tags which have text or language attribute.
​https://bugs.webkit.org/show_bug.cgi?id=31567

Patch by Johnny Ding <​jnd@chromium.org> on 2009-11-17
Reviewed by Darin Adler.

• fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt:
• fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html:
• fast/dom/HTMLScriptElement/script-tests: Added.
• fast/dom/HTMLScriptElement/script-tests/script-for-attribute-unexpected-execution.js: Added.

(ScriptForAttributeExecute):

4:31 PM Changeset in webkit [51096] by mrowe@apple.com

• 3 edits
  2 adds in trunk

<​http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run

Reviewed by Alexey Proskuryakov.

WebKitTools:

If the WebSocket server fails to start have DRT load an error page in place of tests that require the
server to be up rather than having run-webkit-tests abort immediately.

• Scripts/run-webkit-tests:

LayoutTests:

• websocket/resources/server-failed-to-start.html: Error page that will be loaded in place of websocket

tests when the server fails to start.

4:24 PM Changeset in webkit [51095] by dimich@chromium.org

• 2 edits in trunk/WebKit/chromium

Revert r50887, it regressed handling of cmd-left when a text box is focused.
​https://bugs.webkit.org/show_bug.cgi?id=31566

Patch by Nicolas Weber <​thakis@chromium.org> on 2009-11-17
Reviewed by Darin Fisher, Dmitry Titov.

• src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::keyboardEvent):

4:08 PM CommitQueue edited by thakis@chromium.org

(diff)

3:38 PM Changeset in webkit [51094] by jhoneycutt@apple.com

• 2 edits in trunk/WebKit/win

Implement DOMHTMLInputElement::replaceCharactersInRange().

​https://bugs.webkit.org/show_bug.cgi?id=31492

Reviewed by Dan Bernstein.

• DOMHTMLClasses.cpp:

(DOMHTMLInputElement::replaceCharactersInRange):
Get the text of the input field. Replace the given range with the
replacement text, and set this new string as the input element's value.
Select from index to the end of the field. This matches the
implementation in the Obj-C bindings.

3:37 PM Changeset in webkit [51093] by jhoneycutt@apple.com

• 2 edits in trunk/WebKit/win

DOMHTMLOptionElement is missing some functionality.

​https://bugs.webkit.org/show_bug.cgi?id=31491

Reviewed by Dan Bernstein.

• DOMHTMLClasses.cpp:

(DOMHTMLOptionElement::text):
Cast m_element to an HTMLOptionElement, and call its text() function.
(DOMHTMLOptionElement::label):
Ditto, for label().

3:37 PM Changeset in webkit [51092] by jhoneycutt@apple.com

• 2 edits in trunk/WebKit/win

DOMHTMLSelectElement is missing some implementation.

​https://bugs.webkit.org/show_bug.cgi?id=31489

Reviewed by Dan Bernstein.

• DOMHTMLClasses.cpp:

(DOMHTMLSelectElement::options):
Cast m_element to an HTMLSelectElement. If it has no options, return
E_FAIL. Otherwise, create a DOMHTMLOptionsCollection to wrap the
options, and return it.
(DOMHTMLSelectElement::activateItemAtIndex):
If the index is out of bounds, return E_FAIL. Otherwise, select the
item.

3:37 PM Changeset in webkit [51091] by jhoneycutt@apple.com

• 3 edits in trunk/WebKit/win

DOMHTMLOptionsCollection is missing some implementation.

​https://bugs.webkit.org/show_bug.cgi?id=31488

Reviewed by Dan Bernstein.

• DOMHTMLClasses.cpp:

(DOMHTMLOptionsCollection::DOMHTMLOptionsCollection):
Initialize m_collection.
(DOMHTMLOptionsCollection::createInstance):
Create a DOMHTMLOptionsCollection. If we fail to query for
IDOMHTMLOptionsCollection, delete it, and return 0. Otherwise, return
the result.
(DOMHTMLOptionsCollection::length):
(DOMHTMLOptionsCollection::item):
Create a DOMNode for the WebCore Node. If this is 0, return E_FAIL.
(DOMHTMLOptionsCollection::namedItem):
Correct the signature of this function.

• DOMHTMLClasses.h:

Declare DOMHTMLOptionsCollection::createInstance(). Correct the
signature of namedItem() to match IDOMHTMLOptionsCollection. Add a
member to DOMHTMLOptionsCollection to hold the WebCore object.

3:37 PM Changeset in webkit [51090] by jhoneycutt@apple.com

• 2 edits in trunk/WebKit/win

DOMHTMLInputElement::rectOnScreen() returns the wrong rect

​https://bugs.webkit.org/show_bug.cgi?id=31487

Reviewed by Darin Adler.

• DOMHTMLClasses.cpp:

(DOMHTMLInputElement::rectOnScreen):
Return the rect on screen, not the rect in the window.

2:07 PM Changeset in webkit [51089] by bweinstein@apple.com

• 2 edits in trunk/LayoutTests

Rubber-stamped by Pavel Feldman.

Skip inspector tests that are flaky on Windows Release - this is being tracked by:
​https://bugs.webkit.org/show_bug.cgi?id=31596.

• platform/win/Skipped:

1:40 PM Changeset in webkit [51088] by jparent@chromium.org

• 4 edits in trunk/LayoutTests

Eliminate flakiness in char-encoding tests by removing setTimeout,
that was working around an old issue.
​https://bugs.webkit.org/show_bug.cgi?id=31571

Reviewed by Darin Adler.

• fast/encoding/char-encoding-mac.html:
• fast/encoding/char-encoding.html:
• fast/encoding/resources/char-encoding-utils.js:

1:30 PM Changeset in webkit [51087] by kenneth@webkit.org

• 2 edits in trunk/WebKitTools

Unreviewed buildbot fix.

Revert part of earlier patch and add comment, as it
was causing timeouts on the buildbot.

• DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::notifyDone):

12:38 PM Changeset in webkit [51086] by eric@webkit.org

• 3 edits in trunk/JavaScriptCore

2009-11-17 Martin Robinson <​martin.james.robinson@gmail.com>

Reviewed by Adam Barth.

[GTK] Style cleanup for GOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=31506

Remove forward declaration in GOwnPtr and do some style cleanup.

• wtf/GOwnPtr.cpp:
• wtf/GOwnPtr.h: (WTF::GOwnPtr::GOwnPtr): (WTF::GOwnPtr::~GOwnPtr): (WTF::GOwnPtr::get): (WTF::GOwnPtr::release): (WTF::GOwnPtr::outPtr): (WTF::GOwnPtr::set): (WTF::GOwnPtr::clear): (WTF::GOwnPtr::operator*): (WTF::GOwnPtr::operator->): (WTF::GOwnPtr::operator!): (WTF::GOwnPtr::operator UnspecifiedBoolType): (WTF::GOwnPtr::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr): (WTF::freeOwnedGPtr):

12:11 PM Changeset in webkit [51085] by eric@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-17 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

commit-queue is failing to set reviewer in ChangeLogs
​https://bugs.webkit.org/show_bug.cgi?id=31592

• Scripts/bugzilla-tool: Clarify the "applying" log message.
• Scripts/modules/bugzilla.py:
  • Add a new _validate_committer_and_reviewer function as a temporary solution until we can make a real Attachment object which knows how to fill in its committer/reviewer fields automatically.

12:05 PM Changeset in webkit [51084] by kenneth@webkit.org

• 2 edits in trunk/WebKitTools

Make the timeout 15 sec as for the other DRT's and make
it print out the same output when a test timeout.

Reviewed by Oliver Hunt.

• DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::waitUntilDone):
(LayoutTestController::notifyDone):
(LayoutTestController::timerEvent):

11:56 AM Changeset in webkit [51083] by yael.aharon@nokia.com

• 2 edits in trunk/WebKit/qt

[Qt] QGLLauncher does not support drag&drop of local files
​https://bugs.webkit.org/show_bug.cgi?id=31057

Reviewed by Kenneth Rohde Christiansen.

Enable accepting files in QGraphicsWebView.

• Api/qgraphicswebview.cpp:

(QGraphicsWebView::QGraphicsWebView):
(QGraphicsWebView::dragEnterEvent):

11:33 AM Changeset in webkit [51082] by bfulgham@webkit.org

• 2 edits in trunk/WebKit/win

Correct build error in Debug_Cairo target after @49705.

Reviewed by NOBODY - Build Fix.

• WebKit.vcproj/WebKit.vcproj: Revise JavaScriptCore.lib dependency to have proper "_debug" suffix needed by the Debug_Cairo target.

11:27 AM Web Inspector edited by timothy@apple.com

(diff)

11:26 AM WebInspector created by timothy@apple.com

Copied from Web Inspector

11:11 AM Changeset in webkit [51081] by bweinstein@apple.com

• 1 edit in trunk/WebCore/inspector/InspectorController.cpp

Touch InspectorController to force the Inspector HTML and JS files to be
updated.

10:57 AM Changeset in webkit [51080] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

Not reviewed, follow up to r51072: rename skipped entries

• platform/qt/Skipped:

10:52 AM Changeset in webkit [51079] by Joseph Pecoraro

• 2 edits in trunk/WebKitTools

2009-11-17 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Fixed typos in comments.

• Scripts/modules/committers.py:

10:42 AM Changeset in webkit [51078] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Crashing tests after updating to Qt-4.6.0
​https://bugs.webkit.org/show_bug.cgi?id=31591

Reviewed by Kenneth Rohde Christiansen.

• platform/qt/Skipped: Put tests into skiplist temporarily.

10:37 AM Changeset in webkit [51077] by bweinstein@apple.com

• 4 edits in trunk/WebKit/win

Touch files to try to fix the build.

Reviewed by NOBODY - Build Fix.

• Interfaces/IWebInspector.idl:
• Interfaces/WebKit.idl:
• WebKit.vcproj/Interfaces.vcproj:

9:55 AM Changeset in webkit [51076] by tonikitoo@webkit.org

• 2 edits in trunk/WebKit/qt

[Qt] better test coverage for ErrorPageExtension
​https://bugs.webkit.org/show_bug.cgi?id=31583

Reviewed by Kenneth Christiansen.

Improved the coverage of current ErrorPageExtension tests by
adding autotests involving frameset and iframes.

• tests/qwebpage/tst_qwebpage.cpp:

(ErrorPage::extension): Make the ErrorPageExtension
to work for all frames, not only the main frame.
(tst_QWebPage::errorPageExtension): Stop using
the 'frameset.html' resouce in this method since
an autotest specific for frameset's is being added.
(tst_QWebPage::errorPageExtensionInIFrames): Added.
(tst_QWebPage::errorPageExtensionInFrameset): Added.

6:14 AM Changeset in webkit [51075] by pfeldman@chromium.org

• 1 edit
  6 moves
  2 adds in trunk/LayoutTests

2009-11-17 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed, tests fix. Follow up to r51072: move
platform-specific results for fast/inspector into
fast/inspector-support.

• platform/mac/fast/inspector-support/matchedrules-expected.checksum: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.checksum.
• platform/mac/fast/inspector-support/matchedrules-expected.png: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.png.
• platform/mac/fast/inspector-support/matchedrules-expected.txt: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.txt.
• platform/mac/fast/inspector-support/style-expected.txt: Renamed from LayoutTests/platform/mac/fast/inspector/style-expected.txt.
• platform/qt/fast/inspector-support/matchedrules-expected.txt: Renamed from LayoutTests/platform/qt/fast/inspector/matchedrules-expected.txt.
• platform/qt/fast/inspector-support/style-expected.txt: Renamed from LayoutTests/platform/qt/fast/inspector/style-expected.txt.

5:54 AM Changeset in webkit [51074] by kov@webkit.org

• 2 edits in trunk/LayoutTests

Actually skip the inspector console tests while the problem
discussed in ​https://bugs.webkit.org/show_bug.cgi?id=31472 is
fixed.

5:38 AM Changeset in webkit [51073] by pfeldman@chromium.org

• 5 edits in trunk

2009-11-17 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed, build fix. Follow up to r51072: rename skipped entries
for the tests that were moved. Also skipped console tests on GTK
while investigating and touched Interfaces.vcproj to clobber win bot.

• platform/gtk/Skipped:
• platform/qt/Skipped:

5:11 AM Changeset in webkit [51072] by pfeldman@chromium.org

• 37 edits
  10 moves
  2 adds in trunk

2009-11-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Make DRT show web inspector for tests in inspector/ folder.

• Updated DRT to show/close inspector for all tests under /inspector
• Introduced LayoutTestController::setTimelineProfilingEnabled and WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
• Removed reload on each inspector test
• Renamed fast/inspector to fast/inspector-support in order not to trigger inspector for those.
• Reimplemented timeline tests in order to get rid of reload there.
• Moved tests that don't require harness into the fast group.

​https://bugs.webkit.org/show_bug.cgi?id=31472

WebCore:

• WebCore.Inspector.exp:
• inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord):

WebKitTools:

• DumpRenderTree/LayoutTestController.cpp: (setTimelineProfilingEnabledCallback): (closeWebInspectorCallback): (LayoutTestController::staticFunctions):
• DumpRenderTree/LayoutTestController.h:
• DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldOpenWebInspector): (runTest):
• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTimelineProfilingEnabled):
• DumpRenderTree/mac/DumpRenderTree.mm: (shouldOpenWebInspector): (runTest):
• DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setTimelineProfilingEnabled):
• DumpRenderTree/win/DumpRenderTree.cpp: (shouldOpenWebInspector): (runTest):
• DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setTimelineProfilingEnabled):

LayoutTests:

• fast/inspector-support/cssURLQuotes-expected.txt: Renamed from LayoutTests/fast/inspector/cssURLQuotes-expected.txt.
• fast/inspector-support/cssURLQuotes.html: Renamed from LayoutTests/fast/inspector/cssURLQuotes.html.
• fast/inspector-support/matchedrules.html: Renamed from LayoutTests/fast/inspector/matchedrules.html.
• fast/inspector-support/style.html: Renamed from LayoutTests/fast/inspector/style.html.
• fast/inspector-support/uncaught-dom1-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom1-exception-expected.txt.
• fast/inspector-support/uncaught-dom1-exception.html: Renamed from LayoutTests/inspector/uncaught-dom1-exception.html.
• fast/inspector-support/uncaught-dom3-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom3-exception-expected.txt.
• fast/inspector-support/uncaught-dom3-exception.html: Renamed from LayoutTests/inspector/uncaught-dom3-exception.html.
• fast/inspector-support/uncaught-dom8-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom8-exception-expected.txt.
• fast/inspector-support/uncaught-dom8-exception.html: Renamed from LayoutTests/inspector/uncaught-dom8-exception.html.
• inspector/inspector-test.js: (onload): (evaluateInWebInspector): (notifyDone):
• inspector/resources/timeline-iframe-data.html: Added.
• inspector/timeline-layout-expected.txt:
• inspector/timeline-layout.html:
• inspector/timeline-mark-timeline.html:
• inspector/timeline-paint.html:
• inspector/timeline-parse-html-expected.txt:
• inspector/timeline-parse-html.html:
• inspector/timeline-recalculate-styles-expected.txt:
• inspector/timeline-recalculate-styles.html:
• inspector/timeline-script-tag-1-expected.txt:
• inspector/timeline-script-tag-1.html:
• inspector/timeline-script-tag-2-expected.txt:
• inspector/timeline-script-tag-2.html:
• inspector/timeline-script-tag-2.js:
• inspector/timeline-test.js: (printTimelineRecords): (): (dumpTimelineRecords): (printProps): (frontend_getTimelineResults):

WebKit/mac:

• WebInspector/WebInspector.h:
• WebInspector/WebInspector.mm: (-isTimelineProfilingEnabled): (-setTimelineProfilingEnabled:):

WebKit/win:

• Interfaces/IWebInspector.idl:
• WebInspector.cpp: (WebInspector::isTimelineProfilingEnabled): (WebInspector::setTimelineProfilingEnabled):
• WebInspector.h:

WebKit/gtk:

• webkit/webkitwebinspector.cpp: (webkit_web_inspector_class_init): (webkit_web_inspector_set_property): (webkit_web_inspector_get_property):

4:40 AM Changeset in webkit [51071] by benm@google.com

• 1 edit
  4 adds in trunk/WebCore

[Android] Android is missing the implementation of the GeolocationService iface.
​https://bugs.webkit.org/show_bug.cgi?id=31554

Patch by Andrei Popescu <​andreip@google.com> on 2009-11-17
Reviewed by Dimitri Glazkov.

No new tests required as this is platform specific code.

• platform/android/GeolocationServiceAndroid.cpp: Added.

(WebCore::GeolocationServiceAndroid::create):
(WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
(WebCore::GeolocationServiceAndroid::startUpdating):
(WebCore::GeolocationServiceAndroid::stopUpdating):
(WebCore::GeolocationServiceAndroid::suspend):
(WebCore::GeolocationServiceAndroid::resume):
(WebCore::GeolocationServiceAndroid::newPositionAvailable):
(WebCore::GeolocationServiceAndroid::newErrorAvailable):
(WebCore::GeolocationServiceAndroid::timerFired):
(WebCore::GeolocationServiceAndroid::isPositionMovement):
(WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
(WebCore::GeolocationServiceAndroid::isPositionMoreTimely):

• platform/android/GeolocationServiceAndroid.h: Added.

(WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
(WebCore::GeolocationServiceAndroid::lastPosition):
(WebCore::GeolocationServiceAndroid::lastError):

• platform/android/GeolocationServiceBridge.cpp: Added.

(WebCore::):
(WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
(WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
(WebCore::GeolocationServiceBridge::start):
(WebCore::GeolocationServiceBridge::stop):
(WebCore::GeolocationServiceBridge::setEnableGps):
(WebCore::GeolocationServiceBridge::newLocationAvailable):
(WebCore::GeolocationServiceBridge::newErrorAvailable):
(WebCore::GeolocationServiceBridge::toGeoposition):
(WebCore::GeolocationServiceBridge::startJavaImplementation):
(WebCore::GeolocationServiceBridge::stopJavaImplementation):

• platform/android/GeolocationServiceBridge.h: Added.

1:36 AM Changeset in webkit [51070] by hamaji@chromium.org

• 7 edits
  1 add in trunk/LayoutTests

2009-11-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Eric Seidel.

Fix http tests so that they do not submit a GET form to about:blank.

Original tests expected that submitting an empty form to <about:blank> navigates
the browser to <about:blank?>, not <about:blank>. However, some other browsers
do not act like Safari, and in fact the layout test runner of Chromium was
failing to run these tests.

Prior to this patch, a test that only checks this behavior was added, so now
we can remove the dependency on it from these tests.

Some HTTP tests submit a GET form to about:blank
​https://bugs.webkit.org/show_bug.cgi?id=30423

• http/tests/navigation/onload-navigation-iframe-2-expected.txt:
• http/tests/navigation/onload-navigation-iframe-2.html:
• http/tests/navigation/onload-navigation-iframe-expected.txt:
• http/tests/navigation/onload-navigation-iframe-timeout-expected.txt:
• http/tests/navigation/onload-navigation-iframe-timeout.html:
• http/tests/navigation/onload-navigation-iframe.html:
• http/tests/navigation/resources/blank.txt: Added.

1:27 AM Changeset in webkit [51069] by hamaji@chromium.org

• 1 edit
  2 adds in trunk/LayoutTests

2009-11-17 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Darin Adler.

Add a test to check the behavior of submitting a GET form to <about:blank>.

Currently Safari redirects the browser to <about:blank?>, while some other
browsers do not (including Firefox and Chromium). The objective of this test is
to express the current behavior of Safari and to become ready to remove
unintentional dependency on it from several tests.

Some HTTP tests submit a GET form to about:blank
​https://bugs.webkit.org/show_bug.cgi?id=30423

• fast/forms/get-forms-to-about-blank-expected.txt: Added.
• fast/forms/get-forms-to-about-blank.html: Added.

12:41 AM Changeset in webkit [51068] by oliver@apple.com

• 6 edits in trunk

Incorrect use of JavaScriptCore API in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=31577

Reviewed by Maciej Stachowiak

Return undefined rather than a literal null.