Timeline



May 17, 2010:

11:01 PM Changeset in webkit [59656] by atwilson@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed test expectations update for chromium.

  • platform/chromium-mac/html5lib/runner-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt: Added.
10:56 PM Changeset in webkit [59655] by tkent@chromium.org
  • 8 edits in trunk

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
​http://trac.webkit.org/changeset/59652
​https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js: (runTest):
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
​http://trac.webkit.org/changeset/59652
​https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
​http://trac.webkit.org/changeset/59652
​https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_bestURL]):
10:51 PM Changeset in webkit [59654] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement RAWTEXT tokenizer states
​https://bugs.webkit.org/show_bug.cgi?id=39267

More tokenizer states. There's a bunch of functionality notImplemented
that we'll come back to.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::tokenize):
  • html/HTML5Tokenizer.h:
10:17 PM Changeset in webkit [59653] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement more parser states in HTML5Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39265

This patch implements some easy states. I'll come back and do the
harder states later.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::tokenize): (WebCore::HTML5Tokenizer::emitParseError):
  • html/HTML5Tokenizer.h:
10:11 PM Changeset in webkit [59652] by tkent@chromium.org
  • 8 edits in trunk

2010-05-17 Daniel Cheng <​dcheng@chromium.org>

DragData::asURL() shouldn't do file validity checks
​https://bugs.webkit.org/show_bug.cgi?id=38711

Several layout tests depended on the fact that dropping a file would
never trigger navigation. This never happened to occur in the past,
since it just so happened that the filenames used in the tests never
resolved to files that exist. Since DragData::asURL() no longer tries
to verify file existence, the layout tests were updated to either
suppress navigation or log any navigation that should occur as part of
the test.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js: (runTest.window.onbeforeunload): (runTest):
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

2010-05-17 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Darin Adler.

DragData::asURL() shouldn't do file validity checks
​https://bugs.webkit.org/show_bug.cgi?id=38711

There's no point to trying to make sure the file is valid in
DragData::asURL(). It's better to ask for forgiveness than to ask for
permission, since asking for permission is prone to race conditions
and results in unnecessary I/O. Consumers of this function either:

  • need to verify the file exists themselves (e.g. the loader)
  • don't care about file validity (rich text drag-and-drop)
  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):

2010-05-17 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Darin Adler.

DragData::asURL() shouldn't do file validity checks
​https://bugs.webkit.org/show_bug.cgi?id=38711

Change [NSPasteboard _web_bestURL] to still return a file URL for paths
that don't exist. Callers who care about the existence of the file or
whether or not it is a directory should check themselves when they
want to use the file. The directory check has been left in for now,
since the Mac implementation of ResourceHandle, which uses this function
indirectly via DragController::performDrag) handles directories somewhat
non-intuitively: it opens the parent directory in the Finder, rather
than opening the directory itself.

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_bestURL]):
10:05 PM Changeset in webkit [59651] by tkent@chromium.org
  • 6 edits in trunk

Unreviewed. Roll out r59650.
A workaround of a buildbot issue triggered by r59650 wasn't resolved by r59646.

9:56 PM Changeset in webkit [59650] by tkent@chromium.org
  • 6 edits in trunk

[DRT/Chromium] Fix repaint, WebGL, textarea tests
​https://bugs.webkit.org/show_bug.cgi?id=39054

Reviewed by Dimitri Glazkov.

WebKit/chromium:

  • DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion and textAreaResizeCorner.png
  • WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
  • features.gypi: Enable ENABLE_3D_CANVAS.

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::canvas): Remove m_paintRect initialization in canvas().

This line updated m_paintRect unexpectedly during paintRect().
We don't need to initialize m_paintRect because show() does it.

9:46 PM Changeset in webkit [59649] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-16 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Add tests for Bug 31267 - :nth-child(-2n) should match no element.
​http://trac.webkit.org/changeset/58300 has fixed this already.
​https://bugs.webkit.org/show_bug.cgi?id=31267

  • fast/css/nth-child-negative-a-param-expected.txt: Added.
  • fast/css/nth-child-negative-a-param.html: Added.
9:27 PM Changeset in webkit [59648] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update states in HTML5Tokenizer to match HTML5 spec
​https://bugs.webkit.org/show_bug.cgi?id=39264

I've also implemented the DataState. More states to follow.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::reset): (WebCore::HTML5Tokenizer::tokenize):
  • html/HTML5Tokenizer.h: (WebCore::HTML5Tokenizer::):
9:24 PM Changeset in webkit [59647] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed.

Update a test for the behavior change of r59645.
​https://bugs.webkit.org/show_bug.cgi?id=39162

  • fast/forms/script-tests/willvalidate.js:
  • fast/forms/willvalidate-expected.txt:
9:04 PM Changeset in webkit [59646] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

Chromium Windows build system does not rebuild correctly when
enabling/disabling a feature
​https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by David Levin.

Add a workaround of this issue.

  • Scripts/update-webkit: Chromium-Windows only: If WebKit/chromium/features.gyp has been updated, remove WebKit/chromium/Debug and WebKit/chromium/Release.
8:57 PM Changeset in webkit [59645] by tkent@chromium.org
  • 7 edits in trunk

':valid' CSS selector should not be applied to some form controls
​https://bugs.webkit.org/show_bug.cgi?id=39162

Reviewed by Darin Adler.

WebCore:

  • html/HTMLElement.cpp:

(WebCore::inlineTagList): Always includes progressTag. This change is
needed in a case of no ENABLE_PROGRESS_TAG. Without this change and
ENABLE_PROGRESS_TAG, <progress> tags disappear.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::recalcWillValidate):

Return false for SUBMIT and IMAGE.

  • html/HTMLProgressElement.h:

(WebCore::HTMLProgressElement::recalcWillValidate):

Return false. This change is needed in a case of ENABLE_PROGRESS_TAG.

LayoutTests:

Add test cases for

  • <input type=submit>
  • <input type=image>
  • <progress>
  • <meter>
  • fast/css/pseudo-valid-unapplied-expected.txt:
  • fast/css/pseudo-valid-unapplied.html:
8:41 PM Changeset in webkit [59644] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove load-related code from HTML5Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39263

This code is related to reloading resources and not to tokenizing. In
the PreloadScanner, these concerns are coupled, but we want to decouple
them.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::HTML5Tokenizer): (WebCore::HTML5Tokenizer::~HTML5Tokenizer): (WebCore::HTML5Tokenizer::begin): (WebCore::HTML5Tokenizer::end): (WebCore::HTML5Tokenizer::reset): (WebCore::HTML5Tokenizer::write): (WebCore::HTML5Tokenizer::consumeEntity): (WebCore::HTML5Tokenizer::tokenize): (WebCore::HTML5Tokenizer::processAttribute): (WebCore::HTML5Tokenizer::emitCharacter): (WebCore::HTML5Tokenizer::emitTag):
  • html/HTML5Tokenizer.h:
8:25 PM Changeset in webkit [59643] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add HTML5Tokenizer to the build system on Mac
​https://bugs.webkit.org/show_bug.cgi?id=39262

This file will be easier to work with if we're actually compiling it.
Hopefully we'll get this wired into the PreloadScanner soon. Once we
start actually calling the code, we'll add it to the build system on
other platforms.

  • WebCore.xcodeproj/project.pbxproj:
8:24 PM Changeset in webkit [59642] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Oops, meant ebx not eax there. Fix Qt (and probably Win too).

Reviewed by Geoff Garen.

  • jit/JITOpcodes32_64.cpp:
8:21 PM Changeset in webkit [59641] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39261

  • html/HTML5Tokenizer.cpp: Rename PreloadScanner to HTML5Tokenizer.
  • html/HTML5Tokenizer.h: ditto.
8:15 PM Changeset in webkit [59640] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39261

This time copy the cpp from the right file.

  • html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.cpp.
8:08 PM Changeset in webkit [59639] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=39261

  • html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.h.
  • html/HTML5Tokenizer.h: Copied from WebCore/html/PreloadScanner.h.
8:06 PM Changeset in webkit [59638] by abarth@webkit.org
  • 1 edit
    21 adds in trunk/LayoutTests

2010-05-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add the html5lib HTML parser tests
​https://bugs.webkit.org/show_bug.cgi?id=39260

We currently fail a bunch of these. Hopefully we'll get better as we
implement the HTML5 parser.

Source: ​http://gsnedders.html5.org/html5lib-tests/runner.html

  • html5lib/resources/dom2string.js: Added. (String.prototype.toAsciiLowerCase): (indent): (dom2string):
  • html5lib/resources/tests1.dat: Added.
  • html5lib/resources/tests10.dat: Added.
  • html5lib/resources/tests11.dat: Added.
  • html5lib/resources/tests12.dat: Added.
  • html5lib/resources/tests13.dat: Added.
  • html5lib/resources/tests14.dat: Added.
  • html5lib/resources/tests15.dat: Added.
  • html5lib/resources/tests16.dat: Added.
  • html5lib/resources/tests2.dat: Added.
  • html5lib/resources/tests3.dat: Added.
  • html5lib/resources/tests4.dat: Added.
  • html5lib/resources/tests5.dat: Added.
  • html5lib/resources/tests6.dat: Added.
  • html5lib/resources/tests7.dat: Added.
  • html5lib/resources/tests8.dat: Added.
  • html5lib/resources/tests9.dat: Added.
  • html5lib/runner-expected.txt: Added.
  • html5lib/runner.html: Added.
7:39 PM Changeset in webkit [59637] by barraclough@apple.com
  • 20 edits in trunk/JavaScriptCore

Bug 39252 - Move host/native JSFunction's NativeFunction onto NativeExecutable.

Reviewed by Geoff Garen.

Currently host functions reuse JSFunction's ScopeChain as storage for their
NativeFunction (the C function pointer to the host function implementation).
Instead, move this onto NativeExecutable. This will allow host functions to
have a scopechain (which will be implemented as a separate patch).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITStubs.cpp:

(JSC::JITThunks::specializedThunk):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiNativeCall):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):

  • jit/ThunkGenerators.h:
  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::function):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):

  • runtime/JSFunction.h:

(JSC::JSFunction::scope):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::getThunk):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

6:38 PM Changeset in webkit [59636] by atwilson@chromium.org
  • 4 edits in trunk/WebKitTools

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59631.
​http://trac.webkit.org/changeset/59631
​https://bugs.webkit.org/show_bug.cgi?id=39255

chromium canaries can no longer run webkit_tests, suspect this
change. (Requested by atwilson on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:28 PM Changeset in webkit [59635] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-05-17 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Windows: Speed of indeterminate progress bar should be constant
​https://bugs.webkit.org/show_bug.cgi?id=39211

No new tests, animation effect can be confirmed only manually.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::paintProgressBar):
5:58 PM Changeset in webkit [59634] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for Qt and Chromium. Added missing #include in Frame.h.

​https://bugs.webkit.org/show_bug.cgi?id=39147

  • page/Frame.h: Now includes CSSMutableStyleDeclaration.h.
5:19 PM Changeset in webkit [59633] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-05-17 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Remove unused member member from Document
​https://bugs.webkit.org/show_bug.cgi?id=39251

Remove m_associatedHistoryItems from Document; it is never used.

  • dom/Document.h:
5:15 PM Changeset in webkit [59632] by Darin Adler
  • 3 edits in trunk/WebCore

Fix Qt build.

  • page/Frame.cpp:

(WebCore::Frame::setTypingStyle): Move back to make non-inline.

  • page/Frame.h: Removed inline version of setTypingStyle.
5:15 PM Changeset in webkit [59631] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Attempt to make new-run-webkit-tests --help more sane
​https://bugs.webkit.org/show_bug.cgi?id=37836

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Add a FIXME about options.singly and options.batch_size being different.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add support for hidden options.
    • Add option groupings to attempt to simplify --help.
    • Fix a bunch of option helps to start with a capitalized verb.
    • Hide a bunch of options which make no sense to users.
    • Sort options in --help.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
    • Add tests for option sorting.
4:48 PM Changeset in webkit [59630] by Darin Adler
  • 4 edits in trunk/WebCore

2010-05-14 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

Frame has many trivial member functions that should be inlined
​https://bugs.webkit.org/show_bug.cgi?id=39147

  • WebCore.base.exp: Export the functions that are now inlined.
  • page/Frame.cpp: (WebCore::Frame::removeEditingStyleFromBodyElement): Removed the body of this function.
  • page/Frame.h: (WebCore::Frame::init): Moved here from .cpp. (WebCore::Frame::loader): Ditto. (WebCore::Frame::redirectScheduler): Ditto. (WebCore::Frame::view): Ditto. (WebCore::Frame::script): Ditto. (WebCore::Frame::document): Ditto. (WebCore::Frame::selection): Ditto. (WebCore::Frame::editor): Ditto. (WebCore::Frame::animation): Ditto. (WebCore::Frame::mark): Ditto. (WebCore::Frame::setMark): Ditto. (WebCore::Frame::zoomFactor): Ditto. (WebCore::Frame::jsStatusBarText): Ditto. (WebCore::Frame::jsDefaultStatusBarText): Ditto. (WebCore::Frame::needsReapplyStyles): Ditto. (WebCore::Frame::typingStyle): Ditto. (WebCore::Frame::setTypingStyle): Ditto. (WebCore::Frame::clearTypingStyle): Ditto. (WebCore::Frame::ownerElement): Ditto. (WebCore::Frame::isDisconnected): Ditto. (WebCore::Frame::setIsDisconnected): Ditto. (WebCore::Frame::excludeFromTextSearch): Ditto. (WebCore::Frame::setExcludeFromTextSearch): Ditto. (WebCore::Frame::inViewSourceMode): Ditto. (WebCore::Frame::setInViewSourceMode): Ditto. (WebCore::Frame::markedTextMatchesAreHighlighted): Ditto. (WebCore::Frame::tree): Ditto. (WebCore::Frame::page): Ditto. (WebCore::Frame::detachFromPage): Ditto. (WebCore::Frame::eventHandler): Ditto. (WebCore::Frame::shouldClose): Ditto.
4:03 PM Changeset in webkit [59629] by andersca@apple.com
  • 11 edits in trunk/WebCore

2010-05-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=39247
<rdar://problem/7994707>
Move rarely used data members to the rare structures, thus saving memory.

Move rarely used member variables from StyleInheritedData and StyleVisualData to
StyleRareInheritedData and StyleRareNonInheritedData, namely:

indent, cursorData, m_effectiveZoom, widows and orphans move from StyleInheritedData to StyleRareInheritedData.
m_counterIncrement and m_counterReset move from StyleVisualData to StyleRareNonInheritedData.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): (WebCore::RenderStyle::addCursor): (WebCore::RenderStyle::setCursorList): (WebCore::RenderStyle::clearCursorList):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::textIndent): (WebCore::InheritedFlags::effectiveZoom): (WebCore::InheritedFlags::counterIncrement): (WebCore::InheritedFlags::counterReset): (WebCore::InheritedFlags::cursors): (WebCore::InheritedFlags::widows): (WebCore::InheritedFlags::orphans): (WebCore::InheritedFlags::setTextIndent): (WebCore::InheritedFlags::setEffectiveZoom): (WebCore::InheritedFlags::setCounterIncrement): (WebCore::InheritedFlags::setCounterReset): (WebCore::InheritedFlags::setWidows): (WebCore::InheritedFlags::setOrphans):
  • rendering/style/StyleInheritedData.cpp: (WebCore::StyleInheritedData::StyleInheritedData): (WebCore::StyleInheritedData::operator==):
  • rendering/style/StyleInheritedData.h:
  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::cursorDataEquivalent): (WebCore::StyleRareInheritedData::operator==):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h:
  • rendering/style/StyleVisualData.cpp: (WebCore::StyleVisualData::StyleVisualData):
  • rendering/style/StyleVisualData.h: (WebCore::StyleVisualData::operator==):
3:25 PM Changeset in webkit [59628] by jamesr@google.com
  • 6 edits
    4 adds in trunk/LayoutTests

2010-05-17 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Rebaseline fast/multicol pixel results on mac
​https://bugs.webkit.org/show_bug.cgi?id=39241

  • fast/multicol/client-rects-expected.checksum:
  • fast/multicol/client-rects-expected.png:
  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/mac/fast/multicol/nested-columns-expected.png: Added.
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
3:21 PM Changeset in webkit [59627] by atwilson@chromium.org
  • 8 edits
    6 adds in trunk/LayoutTests

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/nested-columns-expected.png: Added.
1:46 PM QtWebKitTableOfFeatures20 edited by noam.rosenthal@nokia.com
(diff)
1:45 PM Changeset in webkit [59626] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Robert Hogan <​robert@webkit.org>

Rubber-stamped by Eric Seidel.

Fix --no-svg build.

I have no idea where the SVG-dependent include of this file is hidden, but
it is probably better to include it explicitly anyway like V8WorkerContextCustom.cpp.

  • bindings/js/JSWorkerContextCustom.cpp:
1:39 PM Changeset in webkit [59625] by atwilson@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewd: Update Chromium test expectations.

  • platform/chromium-win/fast/multicol/nested-columns-expected.txt: Added.
1:29 PM Changeset in webkit [59624] by hyatt@apple.com
  • 3 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39231

Reviewed by Dan Bernstein.

Fix failures in the RTL portion of fast/multicol/layers-in-multicol.html. Make sure block children of RTL blocks are positioned using
the reduced column width instead of the total content width.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestContents):
(WebCore::RenderBlock::adjustForColumns):

12:36 PM Changeset in webkit [59623] by robert@webkit.org
  • 7 edits
    4 adds in trunk

2010-05-17 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Icon Database by default in Qt DRT

Unskip:

http/tests/misc/favicon-loads-with-images-disabled.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

Qt returns 5 (QNetworkReply::OperationCanceledError) instead of -999 for the XFrameOptions tests,
so update accordingly.

​https://bugs.webkit.org/show_bug.cgi?id=37382

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added. Qt returns 5 instead of -999.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added. Qt returns 5 instead of -999.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added. Qt returns 5 instead of -999.

2010-05-17 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Icon Database by default in Qt DRT

Unskip:

http/tests/misc/favicon-loads-with-images-disabled.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

​https://bugs.webkit.org/show_bug.cgi?id=37382

Add support for layoutTestController.setIconDatabaseEnabled and layoutTestController.disableImageLoading().
The XFrameOptions tests were failing because of an extra resource load callback for favicon.ico requests.
These extra callbacks are removed by supporting both of the above layoutTestContoller commands.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::drtStoragePath):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::disableImageLoading): (LayoutTestController::setIconDatabaseEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
12:33 PM Changeset in webkit [59622] by mrowe@apple.com
  • 12 edits in branches/safari-533-branch

<rdar://problem/7987585> Disable SVG filters.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools:

  • Scripts/build-webkit:
12:32 PM Changeset in webkit [59621] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch

<rdar://problem/7987743> Disable Blob.slice.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:32 PM Changeset in webkit [59620] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch

<rdar://problem/7987750> Disable progress element.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:09 PM Changeset in webkit [59619] by jpetsovits@rim.com
  • 6 edits
    3 adds in trunk/WebCore

2010-05-17 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by George Staikos.

[OpenVG] Add support for decoding and drawing images
​https://bugs.webkit.org/show_bug.cgi?id=36072

OpenVG has a maximum image size (how large is
specific to the OpenVG implementation), so this
requires us to store them as separate image tiles.

Image decoding and initial drawing code by
Adam Treat <​atreat@rim.com>. Image decoder
downsampling support by Yong Li <​yoli@rim.com>.

  • platform/graphics/ImageSource.h:
  • platform/graphics/openvg/ImageOpenVG.cpp: Added. (WebCore::FrameData::clear): (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::adjustSourceRectForDownSampling): (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern): (WebCore::Image::loadPlatformResource):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::drawImage): (WebCore::PainterOpenVG::asNewNativeImage):
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/openvg/TiledImageOpenVG.cpp: Added. (WebCore::TiledImageOpenVG::TiledImageOpenVG): (WebCore::TiledImageOpenVG::operator=): (WebCore::TiledImageOpenVG::~TiledImageOpenVG): (WebCore::TiledImageOpenVG::numTiles): (WebCore::TiledImageOpenVG::numColumns): (WebCore::TiledImageOpenVG::numRows): (WebCore::TiledImageOpenVG::setTile): (WebCore::TiledImageOpenVG::tilesInRect): (WebCore::TiledImageOpenVG::tile): (WebCore::TiledImageOpenVG::tileRect): (WebCore::TiledImageOpenVG::detachTiles): (WebCore::TiledImageOpenVG::destroyTiles):
  • platform/graphics/openvg/TiledImageOpenVG.h: Added. (WebCore::TiledImageOpenVG::size): (WebCore::TiledImageOpenVG::maxTileSize):
  • platform/graphics/openvg/VGUtils.cpp: (WebCore::VGUtils::bytesForImage): (WebCore::VGUtils::bytesForImageScanline): (WebCore::VGUtils::imageFormatBitsPerPixel): (WebCore::VGUtils::endianAwareImageFormat):
  • platform/graphics/openvg/VGUtils.h:
  • platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage):
11:42 AM Changeset in webkit [59618] by yaar@chromium.org
  • 3 edits in trunk/WebCore

2010-05-17 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Adler.

Fix JSC's generation of 'Optional' arguments. When a single 'Optional' extended attribute precedes multiple method arguments, all of these arguments are optional as a group (either all or non must be specified). This fix, which makes JSC compliant with V8 and with the Web IDL specs, is pretty harmless, since Optional is currently not being used anywhere in JSC, but it blocks further work on overloads.
​https://bugs.webkit.org/show_bug.cgi?id=39227

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
11:05 AM Changeset in webkit [59617] by weinig@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39192
Remove unused PERFECT_HASH code CodeGeneratorJS.

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:
10:57 AM Changeset in webkit [59616] by hyatt@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test of columns inside columns. The test also puts a RenderLayer in the 2nd column of the 2nd column
to make sure layer positioning works across nested columns.

Reviewed by Dan Bernstein.

  • fast/multicol/nested-columns.html: Added.
  • platform/mac/fast/multicol/nested-columns-expected.txt: Added.
10:54 AM Changeset in webkit [59615] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Jeremy Orlow.

Remove debug code that was introduced to help narrow down the
source of a crash.
​https://bugs.webkit.org/show_bug.cgi?id=36426

No change in behavior, so no new tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):
10:43 AM Changeset in webkit [59614] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-05-17 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix compilation with QT_NO_COMBOBOX
​https://bugs.webkit.org/show_bug.cgi?id=38324

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/QtFallbackWebPopup.cpp:
  • WebCoreSupport/QtFallbackWebPopup.h:
10:32 AM Changeset in webkit [59613] by eric@webkit.org
  • 6 edits
    3 adds in trunk

2010-05-17 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify proper behavior of createImageData(ImageData)
and createImageData(width, height) with negative arguments.
​https://bugs.webkit.org/show_bug.cgi?id=39189

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

  • fast/canvas/canvas-createImageData-expected.txt: Added.
  • fast/canvas/canvas-createImageData.html: Added.
  • fast/canvas/script-tests/canvas-createImageData.js: Added.

2010-05-17 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Bring CanvasRenderingContext2D's createImageData() in line with HTML5 spec
Added createImageData(ImageData) which returns a new ImageData with the same size as the one passed.
Changed createImageData(width, height) to use the absolute values of width and height.

​https://bugs.webkit.org/show_bug.cgi?id=39189

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

Test: fast/canvas/canvas-createImageData.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::createImageData):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:
8:37 AM Changeset in webkit [59612] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebCore

This was missing from previous commit.

  • platform/qt/QWebPageClient.h:

(QWebPageClient::graphicsItemVisibleRect):

8:34 AM Changeset in webkit [59611] by antti.j.koivisto@nokia.com
  • 11 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39218
[Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.

Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in the WebKit level.

  • page/ChromeClient.h:

(WebCore::ChromeClient::visibleRectForTiledBackingStore):

  • page/Frame.cpp:

(WebCore::Frame::tiledBackingStoreVisibleRect):

  • page/Frame.h:
  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::checkVisibleRectChanged):
(WebCore::TiledBackingStore::createTiles):

  • platform/graphics/TiledBackingStore.h:
  • platform/graphics/TiledBackingStoreClient.h:

WebKit/qt:

Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.

Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in WebKit the level.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::paint):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::visibleRectForTiledBackingStore):

  • WebCoreSupport/ChromeClientQt.h:
8:04 AM Changeset in webkit [59610] by Adam Roben
  • 3 edits
    1 add in trunk/WebCore

Periodically try to reset a lost IDirect3DDevice9 until we succeed

This is how MSDN says we must respond to a lost device (see
<​http://msdn.microsoft.com/en-us/library/bb174714(v=VS.85).aspx>).

Only testable by a manual test, unfortunately.

Fixes <rdar://problem/7986906> <​http://webkit.org/b/39139> Pages that
use hardware acceleration don't repaint after waking computer from
sleep

Reviewed by John Sullivan.

  • manual-tests/no-repaint-after-wake-from-sleep.html: Added. This is

the Poster Circle demo from webkit.org/blog, but with instructions for
putting the computer to sleep and waking it up again.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Initialize new
member that tells us whether we need to try to reset the device before
rendering.
(WebCore::WKCACFLayerRenderer::resize): Changed to tell resetDevice
the reason why the device needs to be reset (which is because the
window's size has changed).
(WebCore::WKCACFLayerRenderer::render): Before we do anything else,
check if we need to reset the device before rendering. If we do, try
to reset it. If that fails, bail out and set a timer to try again
later. If we discover that the device is lost when calling
IDirect3DDevice9::Present and resetting the device fails, bail out and
set a timer to try again later.
(WebCore::WKCACFLayerRenderer::resetDevice): Changed to return a
boolean indicating whether resetting succeeded or not. Added a
ResetReason parameter so callers can specify whey the device needs to
be reset. Before trying to do anything, we call
IDirect3DDevice9::TestCooperativeLevel to find out whether the device
can be reset currently. If it can't, we set a flag to tell ourselves
that the device must be reset before we next render, and indicate to
the caller that the reset failed. If we thought the device was lost
but it turns out not to be, we don't have to do anything and can tell
the caller that the reset succeeded. Otherwise we go ahead and reset
the device as before, and indicate to the caller that the reset
succeeded.

  • platform/graphics/win/WKCACFLayerRenderer.h: Changed resetDevice to

return a boolean and take a ResetReason parameter. Added a comment
about when and why this function should be called. And added
m_mustResetLostDeviceBeforeRendering.

8:04 AM Changeset in webkit [59609] by Adam Roben
  • 2 edits in trunk/WebCore

Call CARenderOGLPurge whenever we call IDirect3DDevice9::Reset

MSDN says that all resoures allocated with D3DPOOL_DEFAULT must be
destroyed before calling IDirect3DDevice9::Reset. The only way to
guarantee this with Core Animation is to call CARenderOGLPurge.

Unfortunately this isn't testable at the moment, as we don't use any
features of Core Animation (e.g., mask layers) that actually make this
required. But it seems like a good idea to fix the code now so that
if/when we do start using those features we won't run into problems.

Fixes <​http://webkit.org/b/39159> WKCACFLayerRenderer::resetDevice
might fail due to failing to destroy all D3DPOOL_DEFAULT resources

Reviewed by John Sullivan.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::render): Moved the call to
CARenderOGLPurge from here...
(WebCore::WKCACFLayerRenderer::resetDevice): ...to here, so that it
will be called whenever we reset the device (e.g., when resizing the
window).

7:42 AM Changeset in webkit [59608] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Build fix. Remove bashism from build system.

  • GNUmakefile.am:
7:25 AM Changeset in webkit [59607] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-05-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59483.
​http://trac.webkit.org/changeset/59483
​https://bugs.webkit.org/show_bug.cgi?id=39215

"page_cycler_intl1 regression on Linux" (Requested by yurys on
#webkit).

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
6:49 AM Changeset in webkit [59606] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

REGRESSION(59563): [Qt] JSValue QtClass::fallbackObject can be optimized

Reviewed by Laszlo Gombos.

Patch declared a variable index, which shadowed an earlier declared
variable.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

6:33 AM Changeset in webkit [59605] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-05-14 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest is not a proper ActiveDomObject
​https://bugs.webkit.org/show_bug.cgi?id=39001

Add IDBRequest interface to the IsActiveDomType
routine of the CodeGeneratorV8.pm.

Rename IDBRequest::m_stopped to m_suspended and reset
the flag when resume() is called.

No new tests, Indexed Database isn't yet testable.

  • bindings/scripts/CodeGeneratorV8.pm:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
6:22 AM Changeset in webkit [59604] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Xan Lopez <​xlopez@igalia.com>

Do not include the indexed database headers if the feature is not
enabled. Should fix the build in GTK+.

  • bindings/js/JSEventCustom.cpp:
5:55 AM Changeset in webkit [59603] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Xan Lopez <​xlopez@igalia.com>

Try to fix GTK+ build.

  • GNUmakefile.am:
4:20 AM Changeset in webkit [59602] by jorlow@chromium.org
  • 30 edits
    12 copies
    2 moves
    6 adds in trunk

2010-05-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up IndexedDB events
​https://bugs.webkit.org/show_bug.cgi?id=39117

Add the beginnings of a test for IndexedDB. It currently fails, but we'll
update this (and/or add other tests) as things start passing.

Disable it on all !Chromium platforms since none of them compile it
in. (Note that Chromium keeps it behind a runtime flag at the moment,
despite compiling it in...so don't worry.)

This also makes evalAndLog return the result of the evaluation. I think
this was just an oversight when I originally added it, and it's going to
come in useful for these tests.

  • fast/js/resources/js-test-pre.js: (evalAndLog):
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/indexeddb/basics-expected.txt: Added.
  • storage/indexeddb/basics.html: Added.
  • storage/indexeddb/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
  • storage/indexeddb/script-tests/basics.js: Added. (eventShared): (successFunction): (errorFunction): (test):

2010-05-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up IndexedDB events
​https://bugs.webkit.org/show_bug.cgi?id=39117

Implement the indexed database event interfaces as proposed by Mozilla.
Refactor the run time type detection code that was in IDBRequest into its own
class named IDBAny. Use this new class within the new event classes and
IDBResults.

Test: storage/indexeddb/basics.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/js/JSIDBAnyCustom.cpp: Added. (WebCore::toJS):
  • bindings/js/JSIDBRequestCustom.cpp: Removed.
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8IDBAnyCustom.cpp: Added. (WebCore::toV8):
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
  • dom/Event.cpp: (WebCore::Event::isIDBErrorEvent): (WebCore::Event::isIDBSuccessEvent):
  • dom/Event.h:
  • storage/IDBAny.cpp: Added. (WebCore::IDBAny::create): (WebCore::IDBAny::IDBAny): (WebCore::IDBAny::~IDBAny): (WebCore::IDBAny::idbDatabaseRequest): (WebCore::IDBAny::indexedDatabaseRequest): (WebCore::IDBAny::serializedScriptValue): (WebCore::IDBAny::set):
  • storage/IDBAny.h: Added. (WebCore::IDBAny::): (WebCore::IDBAny::type):
  • storage/IDBAny.idl: Added.
  • storage/IDBErrorEvent.cpp: Added. (WebCore::IDBErrorEvent::create): (WebCore::IDBErrorEvent::IDBErrorEvent): (WebCore::IDBErrorEvent::~IDBErrorEvent):
  • storage/IDBErrorEvent.h: Added. (WebCore::IDBErrorEvent::code): (WebCore::IDBErrorEvent::message): (WebCore::IDBErrorEvent::isIDBErrorEvent):
  • storage/IDBErrorEvent.idl: Added.
  • storage/IDBEvent.cpp: Added. (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::~IDBEvent): (WebCore::IDBEvent::source):
  • storage/IDBEvent.h: Added.
  • storage/IDBEvent.idl: Added.
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h: (WebCore::IDBRequest::create): (WebCore::IDBRequest::result):
  • storage/IDBRequest.idl:
  • storage/IDBSuccessEvent.cpp: Added. (WebCore::IDBSuccessEvent::create): (WebCore::IDBSuccessEvent::IDBSuccessEvent): (WebCore::IDBSuccessEvent::~IDBSuccessEvent): (WebCore::IDBSuccessEvent::result):
  • storage/IDBSuccessEvent.h: Added. (WebCore::IDBSuccessEvent::isIDBSuccessEvent):
  • storage/IDBSuccessEvent.idl: Added.
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
1:44 AM Changeset in webkit [59601] by yurys@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2010-05-17 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
1:11 AM Changeset in webkit [59600] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-17 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Laszlo Gombos.

[Qt] Remove WinCE endian dedection.
​https://bugs.webkit.org/show_bug.cgi?id=38511

Windows CE supports little-endian format only.
Correct dedection was added in r57804.

  • wtf/Platform.h:
1:10 AM Changeset in webkit [59599] by mjs@apple.com
  • 2 edits in trunk/SunSpider

Browser-hosted version of SunSpider runs tests twice as many times as advertised
​https://bugs.webkit.org/show_bug.cgi?id=39201

Reviewed by Mark Rowe.

  • make-hosted: Make sure to reset test list after every test suite.
1:03 AM Changeset in webkit [59598] by Chris Jerdonek
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed.

Removed the stray equals sign from the reviewer's name in the
"Reviewed by" line of the ChangeLog entry for r59596:

​http://trac.webkit.org/changeset/59596

12:42 AM Changeset in webkit [59597] by yurys@chromium.org
  • 8 edits
    15 adds
    1 delete in trunk/LayoutTests

2010-05-17 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-win/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/column-rules-expected.txt:
  • platform/chromium-win/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt: Added.
  • platform/chromium-win/fast/multicol/single-line-expected.txt:
12:34 AM Changeset in webkit [59596] by Chris Jerdonek
  • 7 edits in trunk/WebCore

2010-05-16 Chris Jerdonek <Chris Jerdonek>

Reviewed by =Adam Barth.

Refactored FrameLoader::changeLocation() and urlSelected() to share more code.

​https://bugs.webkit.org/show_bug.cgi?id=38827

No change in behavior, so no new tests.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • bindings/js/ScriptController.h:
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • bindings/v8/ScriptController.h:
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
    • Changed to call the new private overload of urlSelected().

(WebCore::FrameLoader::urlSelected):

  • Added a private overload of urlSelected().
  • Changed the public urlSelected() to call the private overload.

(WebCore::FrameLoader::submitForm):

  • loader/FrameLoader.h:
    • Added a private overload of urlSelected().
  • loader/FrameLoaderTypes.h:
    • Added a ShouldReplaceDocumentIfJavaScriptURL enum.
12:06 AM Changeset in webkit [59595] by ukai@chromium.org
  • 7 edits
    1 add in trunk/WebKitTools

2010-05-17 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel.

Chromium: Add --chromium option to new-run-webkit-websocketserver
​https://bugs.webkit.org/show_bug.cgi?id=37664

os.environ setup and setup_mount for cygwin are moved in ChromiumWinPort.setup_environ_for_server.

  • Scripts/new-run-webkit-httpd: Remove passing register_cygwin.
  • Scripts/new-run-webkit-websocketserver: Add --chromium flag. Remove passing register_cygwin. Create port object using options.
  • Scripts/webkitpy/layout_tests/port/base.py: Add setup_environ_for_server().
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/http_server.py: Remove register_cygwin_parameter. Call setup_environ_for_server().
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Ditto.

May 16, 2010:

11:10 PM Changeset in webkit [59594] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed

Patch by Takeshi Yoshino <​tyoshino@google.com> on 2010-05-16
Update test_expectations.txt for Chromium
fast/loader/recursive-before-unload-crash.html is flaky on Linux and Win
See ​http://code.google.com/p/chromium/issues/detail?id=44229 for detail.

  • platform/chromium/test_expectations.txt:
11:10 PM Changeset in webkit [59593] by dbates@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-05-16 Daniel Bates <​dbates@rim.com>

Reviewed by Chris Jerdonek.

​https://bugs.webkit.org/show_bug.cgi?id=39184

Adds function VCSUtils::parseSvnProperty to parse an SVN property with
either a single-line or multi-line value change.

  • Scripts/VCSUtils.pm:
    • Added function parseSvnProperty. We will use this function towards resolving Bug #38885 <​https://bugs.webkit.org/show_bug.cgi?id=38885>.
    • Removed FIXME comment above function parseSvnPropertyValue, since it is being used by parseSvnProperty.
    • Modified function parseSvnPropertyValue to break out of "while (<$fileHandle>)" loop when it encounters the start of the next property so that it can be processed by its caller, parseSvnPropertyValue. We reference this bullet below by (*).
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Added.
    • Added unit tests.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
    • Changed the name of the unit test "simple multi-line '-' change" to "single-line '-' change followed by empty line" since the former was an incorrect description of this test.
    • Added unit test "single-line '-' change followed by the next property", and "multi-line '-' change followed by the next property" to test (*) above.
9:58 PM Changeset in webkit [59592] by dbates@webkit.org
  • 23 edits
    1 add in trunk/WebCore

2010-05-16 Daniel Bates <​dbates@rim.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=39196

Rollout changeset 59274 <​http://trac.webkit.org/changeset/59274>.

Prepared on behalf of David Hyatt.

"Not worth the memory use." Just roll this out.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection): (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox): (WebCore::EllipsisBox::height):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::height): (WebCore::InlineBox::adjustPosition): (WebCore::InlineBox::canAccommodateEllipsis):
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isInlineBox): (WebCore::InlineBox::hasVirtualHeight): (WebCore::InlineBox::setHasVirtualHeight): (WebCore::InlineBox::virtualHeight): (WebCore::InlineBox::setWidth): (WebCore::InlineBox::width): (WebCore::InlineBox::setX): (WebCore::InlineBox::x): (WebCore::InlineBox::setY): (WebCore::InlineBox::y): (WebCore::InlineBox::baselinePosition): (WebCore::InlineBox::lineHeight):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::computeVerticalOverflow): (WebCore::InlineFlowBox::nodeAtPoint): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask): (WebCore::InlineFlowBox::paintTextDecorations):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::visibleOverflowRect): (WebCore::InlineFlowBox::topLayoutOverflow): (WebCore::InlineFlowBox::bottomLayoutOverflow): (WebCore::InlineFlowBox::leftLayoutOverflow): (WebCore::InlineFlowBox::rightLayoutOverflow): (WebCore::InlineFlowBox::layoutOverflowRect): (WebCore::InlineFlowBox::topVisualOverflow): (WebCore::InlineFlowBox::bottomVisualOverflow): (WebCore::InlineFlowBox::leftVisualOverflow): (WebCore::InlineFlowBox::rightVisualOverflow): (WebCore::InlineFlowBox::visualOverflowRect): (WebCore::InlineFlowBox::setHorizontalOverflowPositions): (WebCore::InlineFlowBox::setVerticalOverflowPositions):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::nodeAtPoint): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintCompositionUnderline): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::setSpaceAdd):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPointWithInlineChildren):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren):
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineFlowBox):
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::createTextBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootInlineBox):
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint): (WebCore::RenderText::firstRunX): (WebCore::RenderText::firstRunY):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::closestLeafChildForXPos):
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox): (WebCore::SVGInlineFlowBox::virtualHeight): (WebCore::SVGInlineFlowBox::setHeight):
  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::virtualHeight): (WebCore::SVGInlineTextBox::setHeight): (WebCore::SVGInlineTextBox::selectionTop): (WebCore::SVGInlineTextBox::selectionHeight):
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox): (WebCore::SVGRootInlineBox::virtualHeight): (WebCore::SVGRootInlineBox::setHeight):
  • rendering/TrailingFloatsRootInlineBox.h: Added. (WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox): (WebCore::TrailingFloatsRootInlineBox::virtualHeight):
9:08 PM Changeset in webkit [59591] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-13 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

REGRESSION: Crash by pasting to a textarea with white-space:nowrap
​https://bugs.webkit.org/show_bug.cgi?id=38992

  • editing/pasteboard/paste-plaintext-nowrap-expected.txt: Added.
  • editing/pasteboard/paste-plaintext-nowrap.html: Added.

2010-05-13 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

REGRESSION: Crash by pasting to a textarea with white-space:nowrap
​https://bugs.webkit.org/show_bug.cgi?id=38992

Test: editing/pasteboard/paste-plaintext-nowrap.html

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::highestVisuallyEquivalentDivBelowRoot): (WebCore::InsertParagraphSeparatorCommand::doApply):
8:34 PM Changeset in webkit [59590] by hyatt@apple.com
  • 2 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39194

Reviewed by Dan Bernstein.

Fix all of the multi-column painting and hit testing functions to properly account for RTL directionality.

Added fast/multicol/column-count-with-rules.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::adjustRectForColumns):

8:03 PM Changeset in webkit [59589] by mitz@apple.com
  • 5 edits in trunk/WebCore

Fix SVG test failures after r59588.

Reviewed by Dave Hyatt.

Updated SVG InlineBox virtual method overrides to match HTML ones. Removed
SVGInlineFlowBox::verticallyAlignBoxes() since InlineFlowBox no longer declares
verticallyAlignBoxes().

  • rendering/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::placeBoxesHorizontally):

  • rendering/SVGInlineFlowBox.h:
  • rendering/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::placeBoxesHorizontally):
(WebCore::SVGRootInlineBox::verticallyAlignBoxes):

  • rendering/SVGRootInlineBox.h:
6:43 PM Changeset in webkit [59588] by mitz@apple.com
  • 10 edits in trunk/WebCore

Move transient glyph overflow and fallback font data from a global to the stack
​https://bugs.webkit.org/show_bug.cgi?id=39050

Reviewed by Darin Adler.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read glyph overflow from the map.
(WebCore::InlineFlowBox::computeLogicalBoxHeights): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read fallback fonts from the map.
(WebCore::InlineFlowBox::computeVerticalOverflow): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read glyph overflow from the map.

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: Removed setFallbackFonts(), fallbackFonts(), setGlyphOverflow(),

and glyphOverflow(). Removed s_glyphOverflowAndFallbackFontsMap.

  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a GlyphOverflowAndFallbackFontsMap
parameter. Write fallback fonts and glyph overflow into the map.
(WebCore::RenderBlock::computeVerticalPositionsForLine): Added a GlyphOverflowAndFallbackFontsMap
parameter. Pass it down to verticallyAlignBoxes().
(WebCore::RenderBlock::layoutInlineChildren): Create a GlyphOverflowAndFallbackFontsMap on the
stack and pass it down to computeHorizontalPositionsForLine(), computeVerticalPositionsForLine(),
and verticallyAlignBoxes().

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticallyAlignBoxes): Added a GlyphOverflowAndFallbackFontsMap parameter.
Pass it down to computeLogicalBoxHeights() and computeVerticalOverflow().

  • rendering/RootInlineBox.h:
  • rendering/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutInlineBoxes): Updated.

6:02 PM Changeset in webkit [59587] by Simon Fraser
  • 2 edits in trunk/JavaScriptCore

2010-05-16 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Reduce the size of FunctionExecutable
​https://bugs.webkit.org/show_bug.cgi?id=39180

Change m_numVariables from a size_t to 31 bits in a bitfield,
packed with another bit for m_forceUsesArguments (which in turn
get packed with the base class).

Reduces the size of FunctionExecutable from 160 to 152 bytes.

  • runtime/Executable.h: (JSC::FunctionExecutable::variableCount): (JSC::FunctionExecutable::FunctionExecutable):
6:00 PM Changeset in webkit [59586] by tony@chromium.org
  • 4 edits
    2 copies
    3 adds in trunk

2010-05-16 Tony Chang <​tony@chromium.org>

Not reviewed, fixing layout test.

Add tiger and SL results. Remove Inspect Element from leopard results.

  • platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt:
  • platform/mac-snowleopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
  • platform/mac-tiger/editing/spelling/context-menu-suggestions-expected.txt: Added.

2010-05-16 Tony Chang <​tony@chromium.org>

Not reviewed, fixing layout test.

Don't output Inspect Element since this is not enabled on the bots,
but most developers probably have it installed.

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController contextClick:]):
5:26 PM Changeset in webkit [59585] by tony@chromium.org
  • 9 edits
    3 adds in trunk

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
​https://bugs.webkit.org/show_bug.cgi?id=25639

  • editing/spelling/context-menu-suggestions.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
​https://bugs.webkit.org/show_bug.cgi?id=25639

Test: editing/spelling/context-menu-suggestions.html

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

2010-05-12 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
​https://bugs.webkit.org/show_bug.cgi?id=25639

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController contextClick:]): add a bool parameter that

when true, dumps the context menu items to stdout.

4:48 PM Changeset in webkit [59584] by crogers@google.com
  • 6 edits in branches/audio/WebCore/audio

compile fixes for Snow Leopard

4:42 PM Changeset in webkit [59583] by weinig@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39190
Shave a word off of GlyphPageTreeNode
<rdar://problem/7990428>

Reviewed by Dan Bernstein.

  • platform/graphics/GlyphPageTreeNode.h:

(WebCore::GlyphPageTreeNode::GlyphPageTreeNode):

2:46 PM Changeset in webkit [59582] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify proper handling of invalid arguments to getImageData().
Updated old putImageData() test with correct expectations.

​https://bugs.webkit.org/show_bug.cgi?id=39175

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation

  • fast/canvas/canvas-getImageData-invalid-expected.txt: Added.
  • fast/canvas/canvas-getImageData-invalid.html: Added.
  • fast/canvas/canvas-putImageData-expected.txt:
  • fast/canvas/canvas-putImageData.js:
  • fast/canvas/script-tests/canvas-getImageData-invalid.js: Added.

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Properly handle invalid arguments to CanvasRenderingContext2D's getImageData() and putImageData().
Both should throw NOT_SUPPORTED_ERR when called with nonfinite arguments.
getImageData() should throw INDEX_SIZE_ERR if either width or height is 0.

​https://bugs.webkit.org/show_bug.cgi?id=39175

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation

Test: fast/canvas/canvas-getImageData-invalid.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData): (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData):
2:08 PM Changeset in webkit [59581] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify that Canvas's toDataURL() is case insensitive wrt the mimeType argument.
​https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Added.
  • fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Added. (tryMimeType):
  • platform/gtk/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
​https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html

  • dom/CanvasSurface.cpp: (WebCore::CanvasSurface::toDataURL):
1:13 PM Changeset in webkit [59580] by robert@webkit.org
  • 14 edits in trunk

[Qt] Fix FrameLoaderClientQt.cpp to print relative filename paths correctly.

2010-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix FrameLoaderClientQt.cpp to print relative filename paths correctly.

Move qt_* functions in FrameLoaderClientQt, EditorClientQt, and NotificationPresenterClientQt
to DumpRenderTreeSupportQt. Create new functions to replace them in DumpRenderTreeSupportQt.
Support for the old function names is retained until confirmed that no one uses them outside
QtWebKit.

​https://bugs.webkit.org/show_bug.cgi?id=38867

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpFrameLoader): (DumpRenderTreeSupportQt::dumpResourceLoadCallbacks): (DumpRenderTreeSupportQt::dumpResourceLoadCallbacksPath): (DumpRenderTreeSupportQt::setWillSendRequestReturnsNullOnRedirect): (DumpRenderTreeSupportQt::setWillSendRequestReturnsNull): (DumpRenderTreeSupportQt::setWillSendRequestClearHeaders): (DumpRenderTreeSupportQt::dumpEditingCallbacks): (DumpRenderTreeSupportQt::dumpSetAcceptsEditing): (DumpRenderTreeSupportQt::dumpNotification): (qt_dump_frame_loader): (qt_dump_resource_load_callbacks): (qt_dump_resource_load_callbacks_path): (qt_set_will_send_request_returns_null_on_redirect): (qt_set_will_send_request_returns_null): (qt_set_will_send_request_clear_headers): (qt_dump_editing_callbacks): (qt_dump_set_accepts_editing): (qt_dump_notification):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp:
  • WebCoreSupport/EditorClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtDescriptionSuitableForTestResult):
  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp:
  • WebCoreSupport/NotificationPresenterClientQt.h:

Update Qt DRT to use frame loader, editor client and notificaiton presenter
functions in DumpRenderTreeSupportQt.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::dumpFrameLoadCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::setWillSendRequestReturnsNullOnRedirect): (LayoutTestController::setWillSendRequestReturnsNull): (LayoutTestController::setWillSendRequestClearHeader):

Unskip fast/loader/main-document-url-for-non-http-loads.html

  • platform/qt/Skipped:
11:01 AM Changeset in webkit [59579] by eric@webkit.org
  • 4 edits in trunk

2010-05-16 Mike Belshe <​mbelshe@chromium.org>

Reviewed by Dimitri Glazkov.

Add a flag to the ResourceResponse for tracking if a request was
fetched via the TLS/Next-Protocol-Negotiation mechanism.

Also cleaned up the style in ResourceResponse to group the flags
together (and alphabetically) and hopefully improve readability of
the file.

​https://bugs.webkit.org/show_bug.cgi?id=39078

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasNpnNegotiated): (WebKit::WebURLResponse::setWasNpnNegotiated):
10:50 AM Changeset in webkit [59578] by eric@webkit.org
  • 6 edits in trunk

2010-05-16 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59571.
​http://trac.webkit.org/changeset/59571
​https://bugs.webkit.org/show_bug.cgi?id=39054

Broke Cr Win, but we didn't notice immediately due to
​https://bugs.webkit.org/show_bug.cgi?id=38926. It's possible
that this didn't actually break Cr Win, but rather that bug
38926 necessitates a clean compile after this and sucessive
checkins only produced a partial recompile and thus failed to
build.

  • DEPS:
  • WebKit.gyp:
  • features.gypi:

2010-05-16 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59571.
​http://trac.webkit.org/changeset/59571
​https://bugs.webkit.org/show_bug.cgi?id=39054

Broke Cr Win, but we didn't notice immediately due to
​https://bugs.webkit.org/show_bug.cgi?id=38926. It's possible
that this didn't actually break Cr Win, but rather that bug
38926 necessitates a clean compile after this and sucessive
checkins only produced a partial recompile and thus failed to
build.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::canvas):
10:24 AM Changeset in webkit [59577] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-05-16 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Shrink SimpleFontData
​https://bugs.webkit.org/show_bug.cgi?id=39179

Change SimpleFontData to have a pointer to the m_glyphToBoundsMap,
and to allocate this lazily. This reduces the size of the class from
5632 to 1536 bytes.

  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::boundsForGlyph):
8:43 AM Changeset in webkit [59576] by Simon Fraser
  • 9 edits in trunk/WebCore

2010-05-15 Simon Fraser <Simon Fraser>

Reviewed by Maciej Stachowiak.

Reduce the size of CachedResource
​https://bugs.webkit.org/show_bug.cgi?id=39171

Make protected data members of CachedResource private, to allow for
easier rearrangement, and hide the fact that enums are in bitfields.

Rearrange the data members of CachedResource to save 32 bytes per instance
in 64-bit. Also modernized the constructor code.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::didAddClient): (WebCore::CachedCSSStyleSheet::data): (WebCore::CachedCSSStyleSheet::checkNotify): (WebCore::CachedCSSStyleSheet::error):
  • loader/CachedFont.cpp: (WebCore::CachedFont::load): (WebCore::CachedFont::didAddClient): (WebCore::CachedFont::data): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::ensureSVGFontData): (WebCore::CachedFont::checkNotify): (WebCore::CachedFont::error):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::load): (WebCore::CachedImage::didAddClient): (WebCore::CachedImage::allClientsRemoved): (WebCore::CachedImage::image): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::checkNotify): (WebCore::CachedImage::destroyDecodedData):
  • loader/CachedImage.h: (WebCore::CachedImage::stillNeedsLoad):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::type): (WebCore::CachedResource::preloadResult): (WebCore::CachedResource::status): (WebCore::CachedResource::setStatus): (WebCore::CachedResource::isLoaded): (WebCore::CachedResource::isLoading): (WebCore::CachedResource::setErrorOccurred):
  • loader/CachedScript.cpp: (WebCore::CachedScript::didAddClient): (WebCore::CachedScript::data): (WebCore::CachedScript::checkNotify): (WebCore::CachedScript::error):
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::didAddClient): (WebCore::CachedXSLStyleSheet::data): (WebCore::CachedXSLStyleSheet::checkNotify): (WebCore::CachedXSLStyleSheet::error):
6:44 AM Changeset in webkit [59575] by eric@webkit.org
  • 5 edits in trunk

2010-05-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59574.
​http://trac.webkit.org/changeset/59574
​https://bugs.webkit.org/show_bug.cgi?id=39176

Supposedly broke cr-win, but the errors seems somewhat
unrelated (Requested by abarth on #webkit).

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::setSecurityInfo): (WebCore::ResourceResponse::isContentFiltered): (WebCore::ResourceResponse::setIsContentFiltered): (WebCore::ResourceResponse::setAppCacheID): (WebCore::ResourceResponse::setAppCacheManifestURL): (WebCore::ResourceResponse::setWasFetchedViaSPDY): (WebCore::ResourceResponse::setIsMultipartPayload): (WebCore::ResourceResponse::setResponseTime):

2010-05-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59574.
​http://trac.webkit.org/changeset/59574
​https://bugs.webkit.org/show_bug.cgi?id=39176

Supposedly broke cr-win, but the errors seems somewhat
unrelated (Requested by abarth on #webkit).

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp:
1:58 AM Changeset in webkit [59574] by eric@webkit.org
  • 4 edits in trunk

2010-05-16 Mike Belshe <​mbelshe@chromium.org>

Reviewed by Dimitri Glazkov.

Add a flag to the ResourceResponse for tracking if a request was
fetched via the TLS/Next-Protocol-Negotiation mechanism.

Also cleaned up the style in ResourceResponse to group the flags
together (and alphabetically) and hopefully improve readability of
the file.

​https://bugs.webkit.org/show_bug.cgi?id=39078

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasNpnNegotiated): (WebKit::WebURLResponse::setWasNpnNegotiated):
1:55 AM Changeset in webkit [59573] by robert@webkit.org
  • 8 edits in trunk

[Qt]Unskip security/set-form-autocomplete-attribute.html

2010-05-16 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt]Unskip security/set-form-autocomplete-attribute.html

Add support for layoutTestController.elementDoesAutoCompleteForElementWithId().

​https://bugs.webkit.org/show_bug.cgi?id=38859

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • platform/qt/Skipped:
1:49 AM Changeset in webkit [59572] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Prospective Qt/Mac build fix.

The friend declaration of QGraphicsWidget confuses gcc and thinks that it's an implicit
forward declaration, moving the class into the WebCore namespace (WebCore::QGraphicsWidget).

The declaration seems useless as no method of QGraphicsWidget is going to call anything
in this class.

  • WebCoreSupport/PageClientQt.h:
1:47 AM Changeset in webkit [59571] by eric@webkit.org
  • 6 edits in trunk

2010-05-16 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix repaint, WebGL, textarea tests
​https://bugs.webkit.org/show_bug.cgi?id=39054

  • DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion and textAreaResizeCorner.png
  • WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
  • features.gypi: Enable ENABLE_3D_CANVAS.

2010-05-16 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix repaint, WebGL, textarea tests
​https://bugs.webkit.org/show_bug.cgi?id=39054

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::canvas): Remove m_paintRect initialization in canvas(). This line updated m_paintRect unexpectedly during paintRect(). We don't need to initialize m_paintRect because show() does it.
1:10 AM Changeset in webkit [59570] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-16 Dan Bernstein <​mitz@apple.com>

Reviewed by Darin Adler.

Scalar types allocated on the heap due to misuse of DEFINE_STATIC_LOCAL
​https://bugs.webkit.org/show_bug.cgi?id=39086

Use global variables directly.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::createUtilityContext):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::shouldUseATSUIAPI):
12:58 AM Changeset in webkit [59569] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to check proper return value (null) from invalid canvas getContext() calls.

​https://bugs.webkit.org/show_bug.cgi?id=39150

  • fast/canvas/canvas-getContext-invalid-expected.txt: Added.
  • fast/canvas/canvas-getContext-invalid.html: Added.
  • fast/canvas/script-tests/canvas-getContext-invalid.js: Added.

2010-05-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas's getContext() must return null when called with an invalid/unsupported parameter.
(HTML5 spec 4.8.11): ​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvas-getcontext

​https://bugs.webkit.org/show_bug.cgi?id=39150

Test: fast/canvas/canvas-getContext-invalid.html

  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
12:44 AM Changeset in webkit [59568] by eric@webkit.org
  • 4 edits in trunk

2010-05-16 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

Removed 5 http/history tests from Skipped file

[GTK] Improve reporting of frame loader callbacks in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36454

  • platform/gtk/Skipped:

2010-05-16 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Improve reporting of frame loader callbacks in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadStatusNotified): (createWebView): added connection to notify::load-status and signal callback

May 15, 2010:

11:57 PM Changeset in webkit [59567] by eric@webkit.org
  • 3 edits
    3 deletes in trunk

2010-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59565.
​http://trac.webkit.org/changeset/59565
​https://bugs.webkit.org/show_bug.cgi?id=39173

Broke GTK (Requested by abarth on #webkit).

  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Removed.
  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Removed.
  • fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Removed.

2010-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59565.
​http://trac.webkit.org/changeset/59565
​https://bugs.webkit.org/show_bug.cgi?id=39173

Broke GTK (Requested by abarth on #webkit).

  • dom/CanvasSurface.cpp: (WebCore::CanvasSurface::toDataURL):
8:50 PM Changeset in webkit [59566] by dbates@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-15 Daniel Bates <​dbates@rim.com>

Reviewed by Chris Jerdonek.

​https://bugs.webkit.org/show_bug.cgi?id=39170

Add function parseSvnPropertyValue to parse single-line and multi-line
property values of an SVN property change.

  • Scripts/VCSUtils.pm:

Added function parseSvnPropertyValue. We will use this as part of
Bug #38885 <​https://bugs.webkit.org/show_bug.cgi?id=38885>.

  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl: Added.
8:15 PM Changeset in webkit [59565] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-15 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify that Canvas's toDataURL() is case insensitive wrt the mimeType argument.
​https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Added.
  • fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Added. (tryMimeType):

2010-05-15 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
​https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html

  • dom/CanvasSurface.cpp: (WebCore::CanvasSurface::toDataURL):
8:03 PM Changeset in webkit [59564] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Anders Bakken <​agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

QObject::objectName() returns a QString and QtField::name()
creates a temporary QByteArray object and returns constData() from it.
This is not safe.

This patch changes the signature of the function to return a
QByteArray instead of const char *.

​https://bugs.webkit.org/show_bug.cgi?id=39010

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getPropertyNames): (JSC::Bindings::QtField::name):
  • bridge/qt/qt_runtime.h:
7:52 PM Changeset in webkit [59563] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-15 Anders Bakken <​agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Don't unnecessarily copy data when searching for methods in QtClass.

[Qt] JSValue QtClass::fallbackObject can be optimized
​https://bugs.webkit.org/show_bug.cgi?id=37684

  • bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject):
7:34 PM Changeset in webkit [59562] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-15 Anders Bakken <​agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Identifier::ascii() is not threadsafe and shouldn't be used for
converting to and from QString/QByteArray.

​https://bugs.webkit.org/show_bug.cgi?id=39009

  • bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject): (JSC::Bindings::QtClass::fieldNamed):
7:22 PM Changeset in webkit [59561] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-15 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on the spec and Philip Taylor's test suite, createImageData() should throw
an INDEX_SIZE_ERR exception if either the sw or sh arguments are zero.
The link to the spec:
​http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.imageData.getcreate.zero

​https://bugs.webkit.org/show_bug.cgi?id=39166

The complete test suite is in the process of checking in.
​https://bugs.webkit.org/show_bug.cgi?id=20553

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
7:08 PM Changeset in webkit [59560] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-05-15 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

[chromium] Expose element accessor on WebPluginContainer
​https://bugs.webkit.org/show_bug.cgi?id=39152

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::element):
  • src/WebPluginContainerImpl.h:
6:43 PM Changeset in webkit [59559] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

XMLHttpRequest.getResponseHeader doesn't need to be custom
​https://bugs.webkit.org/show_bug.cgi?id=39125

I don't see any reason this method needs to be custom. No new tests
because there's no behavior change.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.idl:
5:30 PM Changeset in webkit [59558] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by David Hyatt.

Rebaseline client-rects.html on Qt
​https://bugs.webkit.org/show_bug.cgi?id=39169

  • platform/qt/Skipped:
  • platform/qt/fast/multicol/client-rects-expected.txt:
5:19 PM Changeset in webkit [59557] by eric@webkit.org
  • 14 edits in trunk/WebCore

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

XMLHttpRequest.setRequestHeader shouldn't be custom
​https://bugs.webkit.org/show_bug.cgi?id=39124

I don't see any reason why this method needs to be custom. No tests
because no behavior change.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::methodThatRequiresAllArgsCallback): (WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback): (WebCore::ConfigureV8TestObjTemplate):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.idl:
3:33 PM Changeset in webkit [59556] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=39048
<rdar://problem/7978384> REGRESSION (r55802): XML errors on Google maps ("Entity 'nbsp' not
defined") with JavaScript disabled

Google Maps goes into mobile mode if JavaScript is disabled for some reason, and sends XHTML
content with XHTML Mobile DOCTYPE. We want to handle it whether XHTMLMP is enabled or not.

Test: fast/doctypes/xhtml-with-xhtmlmp-doctype.xhtml

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::externalSubsetHandler): Restore pre-55802 behavior for builds that don't have XHTMLMP enabled. Given that r55802 negated the condition without breaking XHTMLMP, this line is actually always needed.
3:29 PM Changeset in webkit [59555] by eric@webkit.org
  • 8 edits in trunk

2010-05-15 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Dmitry Titov.

Implement canEstablishDatabase call for workers.
​https://bugs.webkit.org/show_bug.cgi?id=38742

  • public/WebCommonWorkerClient.h:
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::allowDatabase): (WebKit::WebWorkerBase::allowDatabaseTask): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::cancel): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::result): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::signalCompleted): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::didComplete):
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::allowDatabase):

2010-05-15 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Dmitry Titov.

Add allowDatabase method to TestWebWorker.
​https://bugs.webkit.org/show_bug.cgi?id=38742

  • DumpRenderTree/chromium/TestWebWorker.h: (TestWebWorker::allowDatabase):
3:19 PM Changeset in webkit [59554] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Fixing LayerChromium hierarchy updates where due to mixed ownership
handling, sublayer updates didn't always properly update parent-to-child
and child-to-parent pointers in sync.
​https://bugs.webkit.org/show_bug.cgi?id=39138

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::setNeedsCommit): Typo fix. (WebCore::LayerChromium::insertSublayer): (WebCore::LayerChromium::removeFromSuperlayer): (WebCore::LayerChromium::removeSublayer): (WebCore::LayerChromium::replaceSublayer): (WebCore::LayerChromium::removeAllSublayers): (WebCore::LayerChromium::setSublayers):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setSuperlayer):
3:08 PM Changeset in webkit [59553] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Timothy Hatcher.

Got rid of absolute positioning in favor of flex boxes where possible.
Added shadow for help window.
Changed window style names to more comprehensible.
​https://bugs.webkit.org/show_bug.cgi?id=39120

  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen):
  • inspector/front-end/helpScreen.css: (.help-window-outer): (body.attached .help-window-outer): (.help-window-main): (body.attached .help-window-main): (.help-window-caption): (body.attached .help-window-caption): (.help-window-title): (.help-scrollable): (.help-close-button): (body.platform-mac .help-close-button): (body:not(.platform-mac) .help-close-button):
1:29 PM Changeset in webkit [59552] by Simon Hausmann
  • 1 edit
    19 deletes in trunk/WebKitTools

[Qt] Rename QtLauncher to QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=37665

Rubber-stamped by Antti Koivisto.

Forgot to remove the original directory after the rename.

  • QtLauncher: Removed.
1:23 PM Changeset in webkit [59551] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59549.
​http://trac.webkit.org/changeset/59549
​https://bugs.webkit.org/show_bug.cgi?id=39167

Broke Chromium build (Requested by abarth on #webkit).

  • bindings/scripts/CodeGeneratorV8.pm:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
1:03 PM Changeset in webkit [59550] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-15 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Adding code path for composited layers (LayerChromium) containing only
an Image element.
​https://bugs.webkit.org/show_bug.cgi?id=39142

No new tests, covered under the existing tests for composited layers.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::updateContentsImage):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::setContents):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::contents):
12:53 PM Changeset in webkit [59549] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest is not a proper ActiveDomObject
​https://bugs.webkit.org/show_bug.cgi?id=39001

Add IDBRequest interface to the IsActiveDomType
routine of the CodeGeneratorV8.pm.

Rename IDBRequest::m_stopped to m_suspended and reset
the flag when resume() is called.

No new tests, Indexed Database isn't yet testable.

  • bindings/scripts/CodeGeneratorV8.pm:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
12:41 PM Changeset in webkit [59548] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Andrei Bucur <​abucur@adobe.com>

Reviewed by Gustavo Noronha Silva.

Functions using the cairo_pattern_t object returned by
Pattern::createPlatformPattern sould destroy it after the painting
operation. Failing to do so causes memory leaks.

Test: No test was added because the patch adds no new functionality.
It just completes the normal life cycle of a cairo_pattern_t object.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke):
12:22 PM Changeset in webkit [59547] by oliver@apple.com
  • 7 edits in trunk

2010-05-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Incorrect codegen for slowcase of < in 64-bit
​https://bugs.webkit.org/show_bug.cgi?id=39151

Call the correct stud for the slowcases of the < operator.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jless):

2010-05-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Incorrect codegen for slowcase of < in 64-bit
​https://bugs.webkit.org/show_bug.cgi?id=39151

Add yet more tests for the < operator when comparing integer strings.

  • fast/js/comparison-operators-greater-expected.txt:
  • fast/js/comparison-operators-less-expected.txt:
  • fast/js/script-tests/comparison-operators-greater.js:
  • fast/js/script-tests/comparison-operators-less.js:
11:56 AM Changeset in webkit [59546] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59544.
​http://trac.webkit.org/changeset/59544
​https://bugs.webkit.org/show_bug.cgi?id=39165

Cased LayoutTest to start crashing (Requested by abarth on
#webkit).

  • Scripts/old-run-webkit-tests:
11:38 AM Changeset in webkit [59545] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-15 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Darin Adler.

Fix bug ​https://bugs.webkit.org/show_bug.cgi?id=38890

  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
11:26 AM Changeset in webkit [59544] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-15 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

Ensure DRT loads GAIL (Gtk+ module), for a11y tests
​https://bugs.webkit.org/show_bug.cgi?id=38648

Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port

  • Scripts/old-run-webkit-tests:
10:34 AM Changeset in webkit [59543] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-15 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

[chromium] Adding a notification on WebViewClient when a new
node gets focused.
​https://bugs.webkit.org/show_bug.cgi?id=38508

  • public/WebViewClient.h: (WebKit::WebViewClient::focusedNodeChanged):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focusedNodeChanged):
10:01 AM Changeset in webkit [59542] by yael.aharon@nokia.com
  • 5 edits in trunk/LayoutTests

Unreviewed.

Update expected results after 59541

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
9:41 AM Changeset in webkit [59541] by yael.aharon@nokia.com
  • 26 edits
    16 adds in trunk

Initial support for HTMLMeterElement
​https://bugs.webkit.org/show_bug.cgi?id=38140

Reviewed by Kent Tamura.

WebCore:

This patch adds support for HTMLMeterElement, including default rendering
of the meter element. That is because some platforms do not have a native gauge.
The feature is turned on only for the Qt platform.

Tests: fast/dom/HTMLMeterElement/meter-element.html

fast/dom/HTMLMeterElement/set-meter-properties.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • css/html.css:

(meter):
(meter::-webkit-meter):

  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::inlineTagList):

  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLMeterElement.cpp: Added.

(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::create):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore::HTMLMeterElement::formControlType):
(WebCore::HTMLMeterElement::parseMappedAttribute):
(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::optimum):
(WebCore::HTMLMeterElement::setOptimum):

  • html/HTMLMeterElement.h: Added.

(WebCore::HTMLMeterElement::recalcWillValidate):

  • html/HTMLMeterElement.idl: Added.
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:
  • platform/ThemeTypes.h:
  • rendering/RenderMeter.cpp: Added.

(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::layout):
(WebCore::RenderMeter::updateFromElement):

  • rendering/RenderMeter.h: Added.

(WebCore::RenderMeter::renderName):
(WebCore::RenderMeter::isMeter):
(WebCore::toRenderMeter):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isMeter):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::paintMeter):

  • rendering/RenderTheme.h:

LayoutTests:

  • fast/dom/HTMLMeterElement: Added.
  • fast/dom/HTMLMeterElement/meter-element.html: Added.
  • fast/dom/HTMLMeterElement/script-tests: Added.
  • fast/dom/HTMLMeterElement/script-tests/TEMPLATE.html: Added.
  • fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js: Added.
  • fast/dom/HTMLMeterElement/set-meter-properties-expected.txt: Added.
  • fast/dom/HTMLMeterElement/set-meter-properties.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/fast/dom/HTMLMeterElement: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/win/Skipped:
9:36 AM Changeset in webkit [59540] by eric@webkit.org
  • 10 edits
    3 copies
    5 adds in trunk

2010-05-15 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
​https://bugs.webkit.org/show_bug.cgi?id=34992

  • storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test.
  • storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do.
  • storage/change-version-handle-reuse.js: This is the extracted shared core of the test.
  • storage/execute-sql-args.html: Refactored to share code with the worker version of the test.
  • storage/execute-sql-args.js: This is the extracted shared core of the test.

These are the worker versions of the tests; they're tiny shims around shared code.

  • fast/workers/storage/execute-sql-args-worker-expected.txt: Added.
  • fast/workers/storage/execute-sql-args-worker.html: Added.
  • fast/workers/storage/change-version-handle-reuse-worker-expected.txt: Added.
  • fast/workers/storage/change-version-handle-reuse-worker.html: Added. This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side.
  • fast/workers/storage/resources/database-worker-controller.js: Added. This file is the boilerplate for the worker side of the database tests. It will import and run the actual test on command, and will report back completion and exceptions.
  • fast/workers/storage/resources/database-worker.js: Added.

2010-05-15 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
​https://bugs.webkit.org/show_bug.cgi?id=34992

Tests: storage/change-version-handle-reuse-worker.html

storage/execute-sql-args-worker.html

  • bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding. (WebCore::JSWorkerContext::openDatabase):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there. (WebCore::V8WorkerContext::openDatabaseCallback):

Add NoStaticTables flags to all objects now shared with workers.

  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.h: Add databaseExceededQuota.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now. (WebCore::WorkerContext::openDatabase): Remove invalid assertion.

Add the IDL for the call to openDatabase.

  • workers/WorkerContext.idl:
7:00 AM Changeset in webkit [59539] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-05-15 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by Simon Hausmann.

This patch fixes the build failure of WebKit on Linux for Qt4.5
​https://bugs.webkig.org/show_bug.cgi?id=39108

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::syncLayers):
  • WebCoreSupport/QtPlatformPlugin.cpp:
6:49 AM Changeset in webkit [59538] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-05-15 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

Add script to check for minimum python version and install if missing on Tiger
​https://bugs.webkit.org/show_bug.cgi?id=38886

Per Maciej's request on webkit-dev:
​https://lists.webkit.org/pipermail/webkit-dev/2010-May/012785.html
provide a script which can automatically install Python on Tiger where
the system provided version is too old to be of use.

Note this uses the official Mac Python installer from python.org.
This installs a copy of Python in /Library/Frameworks/Python.framework.
It also makes symlinks from /usr/local/bin to the Python.framework/bin.

I have tested this script on Leopard and it worked fine. I have not
tested it on Tiger as I do not have access to a Tiger machine. In
either case this should provide a great starting point for someone
wishing to upgrade their copy of Python on Tiger.

Future patches can make our scripts depend on a success return from this
script and then they can either skip tests/sections for which python is
insufficient, or they can fail themselves.

  • Scripts/ensure-valid-python: Added.
6:37 AM Changeset in webkit [59537] by eric@webkit.org
  • 6 edits
    36 adds in trunk

2010-05-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
​http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • cmake/FindCFLite.cmake: Added.
  • cmake/FindCairo.cmake: Added.
  • cmake/FindEFL.cmake: Added.
  • cmake/FindFreetype.cmake: Added.
  • cmake/FindGDK-PixBuf.cmake: Added.
  • cmake/FindGDK.cmake: Added.
  • cmake/FindGIO.cmake: Added.
  • cmake/FindGlib.cmake: Added.
  • cmake/FindICU.cmake: Added.
  • cmake/FindLibSoup2.cmake: Added.
  • cmake/FindLibXlst.cmake: Added.
  • cmake/FindPango.cmake: Added.
  • cmake/FindSqlite.cmake: Added.
  • cmake/LibFindMacros.cmake: Added.
  • cmake/OptionsCommon.cmake: Added.
  • cmake/OptionsEfl.cmake: Added.
  • cmake/WebKitEfl.cmake: Added.
  • cmake/WebKitFS.cmake: Added.
  • cmake/WebKitFeatures.cmake: Added.
  • cmake/WebKitGenerators.cmake: Added.
  • cmake/WebKitHelpers.cmake: Added.
  • cmake/WebKitMacros.cmake: Added.
  • cmakeconfig.h.cmake: Added.

2010-05-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
​http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • CMakeListsEfl.txt: Added.
  • config.h: Add conditional to look for cmakeconfig.h.
  • jsc/CMakeLists.txt: Added.
  • jsc/CMakeListsEfl.txt: Added.
  • wtf/CMakeLists.txt: Added.
  • wtf/CMakeListsEfl.txt: Added.

2010-05-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
​http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • CMakeListsEfl.txt: Added.
  • config.h: Add conditional to look for cmakeconfig.h.

2010-05-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
​http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • CMakeListsEfl.txt: Added.
6:14 AM Changeset in webkit [59536] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Clipboard.setData doesn't need to be custom
​https://bugs.webkit.org/show_bug.cgi?id=39133

The implementation of the custom binding for this function was a bit
different than its declaration in the IDL file. I've updated the IDL
to match the implementation, but we probably should check whether our
behavior is correct with respect to the specification.

No tests because I've maintained our current behavior.

  • bindings/js/JSClipboardCustom.cpp:
  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • dom/Clipboard.idl:
5:09 AM Changeset in webkit [59535] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-15 Xan Lopez <​xlopez@igalia.com>

Skip failing test, it depends on one patch still in the commit
queue.

  • platform/gtk/Skipped:
3:42 AM Changeset in webkit [59534] by eric@webkit.org
  • 9 edits
    2 copies
    1 add in trunk/WebKitTools

2010-05-15 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Display queue position inside EWS bubbles
​https://bugs.webkit.org/show_bug.cgi?id=38979

This ended up being a lot of clean-up to our status server code.

Added a new WorkItems model, a form with which to fill it,
and taught the Attachment class how to calculate the current queue
postion for an attachment using the data in WorkItems.

I also finally made statusbubble.* and dashboard.* not use copy-paste code.

The Attachment class has this summary() method which is very
controller/view-like and does not belong in a model class.
This patch got rid of all direct uses of summary().

  • QueueStatusServer/handlers/dashboard.py:
    • Build row objects to hand off to the view instead of handing off a summary object and expecting the view to process it directly.
  • QueueStatusServer/handlers/statusbubble.py:
    • Build bubble object and hand them off to the view.
  • QueueStatusServer/handlers/updatestatus.py:
    • Code cleanup. Just move some code into _queue_status_from_request to make the main put() handler easier to read.
  • QueueStatusServer/handlers/updateworkitems.py: Added.
    • Controller to handle storing WorkItems model objects.
  • QueueStatusServer/main.py:
    • Add route for /update-work-items
  • QueueStatusServer/model/attachment.py:
    • Add new methods to replace direct summary() access.
    • Teach attachment how to calculate queue positions from WorkItems data.
  • QueueStatusServer/model/queues.py:
    • Move name_with_underscores here for easier re-use.
  • QueueStatusServer/model/workitems.py: Added.
    • New model for storing what items are currently queue for any bot.
  • QueueStatusServer/templates/dashboard.html:
    • Kill the copy/paste code!
  • QueueStatusServer/templates/statusbubble.html:
    • Kill the copy/paste code!
  • QueueStatusServer/templates/updateworkitems.html: Added.
    • Simple form for updating a queue's current work items.
3:14 AM Changeset in webkit [59533] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-05-15 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Adam Barth.

V8 overload support ported to JSC. Unforking of overloaded declarations in WebGL & Canvas will be done in subsequent patches.
​https://bugs.webkit.org/show_bug.cgi?id=38920

Note that JSTestCallback.cpp/h include minor irrelevant changes too since somebody forgot to update them after changing the JS generator.

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp: (WebCore::JSTestCallback::JSTestCallback): (WebCore::JSTestCallback::~JSTestCallback):
  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): (WebCore::testObjPrototypeFunctionOverloadedMethod):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
2:55 AM Changeset in webkit [59532] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-05-15 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail

The "announcement" is now made in the form of an object attribute
associated with the AtkObject.

  • platform/gtk/accessibility/object-attributes.html: Added.
  • platform/gtk/accessibility/object-attributes-expected.txt: Added.

2010-05-15 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail

The "announcement" is now made in the form of an object attribute
associated with the AtkObject.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_attributes):

2010-05-15 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail

The "announcement" is now made in the form of an object attribute
associated with the AtkObject.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::allAttributes): (attributeSetToString):
2:44 AM Changeset in webkit [59531] by eric@webkit.org
  • 4 edits in trunk

2010-05-15 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

Accessibility: Implement isSelected in DRT for GTK
​https://bugs.webkit.org/show_bug.cgi?id=31018

Do not skip aria-controls-with-tabs.html anymore

  • platform/gtk/Skipped:

2010-05-15 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

Accessibility: Implement isSelected in DRT for GTK
​https://bugs.webkit.org/show_bug.cgi?id=31018

Implement AccessibilityUIElement::isSelected() for Gtk

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isSelected):
2:33 AM Changeset in webkit [59530] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-05-15 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Update notifications test results
​https://bugs.webkit.org/show_bug.cgi?id=39126
Add missing line endings.

  • fast/notifications/notifications-replace-expected.txt:
  • fast/notifications/notifications-request-permission-expected.txt:
  • fast/notifications/notifications-rtl-expected.txt:
2:21 AM Changeset in webkit [59529] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-15 Evan Stade <​estade@chromium.org>

Reviewed by Adam Barth.

[chromium] "Check spelling in this field" context menu item always checked
​https://bugs.webkit.org/show_bug.cgi?id=39018

Initialize all POD members of WebContextMenuData in a default
constructor.

No tests because this code would need some major refactoring to unit
test, and AFAICT it's not testable via layout tests. See note at top
of getCustomMenuFromDefaultItems.

  • public/WebContextMenuData.h: (WebKit::WebContextMenuData::WebContextMenuData):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2:10 AM Changeset in webkit [59528] by eric@webkit.org
  • 6 edits in trunk

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Show a console message when X-Frame-Options blocks a load
​https://bugs.webkit.org/show_bug.cgi?id=39087

Update expected results to show the console message.

  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:

2010-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Show a console message when X-Frame-Options blocks a load
​https://bugs.webkit.org/show_bug.cgi?id=39087

The blank page confuses people when X-Frame-Options blocks a load. The
console message should at least give them a hint as to what's going on.

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
1:58 AM Changeset in webkit [59527] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-05-15 Chao-ying Fu <​fu@mips.com>

Reviewed by Oliver Hunt.

Update MIPS JIT for unsigned right shift, Math.sqrt, load16
​https://bugs.webkit.org/show_bug.cgi?id=38412

Fixed MIPS build failure.

  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::srl): (JSC::MIPSAssembler::srlv): (JSC::MIPSAssembler::sqrtd):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::urshift32): (JSC::MacroAssemblerMIPS::sqrtDouble): (JSC::MacroAssemblerMIPS::load16): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
  • jit/JSInterfaceJIT.h:
1:46 AM Changeset in webkit [59526] by eric@webkit.org
  • 11 edits
    1 copy in trunk

2010-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Geoffrey Garen.

WebInspector: JSC Should provide heap size info for Timeline panel.
​https://bugs.webkit.org/show_bug.cgi?id=38420

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/Collector.cpp: (JSC::Heap::size):
  • runtime/Collector.h:

2010-05-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Geoffrey Garen.

WebInspector: JSC Should provide heap size info for Timeline panel.
​https://bugs.webkit.org/show_bug.cgi?id=38420

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptGCEvent.cpp: Added. (WebCore::ScriptGCEvent::getHeapSize):
  • bindings/js/ScriptGCEvent.h:
1:25 AM Changeset in webkit [59525] by eric@webkit.org
  • 6 edits in trunk

2010-05-15 Dave Tapuska <​dtapuska@rim.com>

Reviewed by Darin Adler.

Add a new define for we need strict arena alignment. ARMv5 with
double word instructions set this value.

  • wtf/Platform.h:

2010-05-15 Dave Tapuska <​dtapuska@rim.com>

Reviewed by Darin Adler.

Fix alignment faults on ARMv5TE architectures.

In debug mode the RenderAreaDebugHeader was 12 bytes which
caused an alignment failure for RenderObjects because they
would start on a 4 byte boundary. Align the RenderArenaDebugHeader
using the ARENA_ALIGN macro.

In NDEBUG mode the RenderArena objects come from a pool which
has 4 byte alignment. Allow the alignment to be based on the
AllocAlignmentInteger. This define will be activated for ARMv5TE.

​https://bugs.webkit.org/show_bug.cgi?id=19946

May 14, 2010:

11:50 PM Changeset in webkit [59524] by darin@chromium.org
  • 18 edits in trunk/WebKit/chromium

2010-05-14 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Remove temporary relative include paths
​https://bugs.webkit.org/show_bug.cgi?id=38776

  • public/WebPasswordAutocompleteListener.h:
  • src/FrameLoaderClientImpl.h:
  • src/PlatformMessagePortChannel.h:
  • src/WebAnimationControllerImpl.h:
  • src/WebBindings.cpp:
  • src/WebDataSourceImpl.h:
  • src/WebDevToolsAgentPrivate.h:
  • src/WebFileChooserCompletionImpl.h:
  • src/WebFrameImpl.h:
  • src/WebInputEventConversion.h:
  • src/WebPluginContainerImpl.h:
  • src/WebPluginLoadObserver.h:
  • src/WebPopupMenuImpl.h:
  • src/WebSettingsImpl.h:
  • src/WebViewImpl.h:
  • src/WebWorkerClientImpl.h:
  • src/WrappedResourceRequest.h:
  • src/WrappedResourceResponse.h:
11:32 PM Changeset in webkit [59523] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-05-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

XMLHttpRequest.overrideMimeType doesn't need to be custom
​https://bugs.webkit.org/show_bug.cgi?id=39127

I don't see any reason why this method should be custom. No tests
because no behavior change.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.idl:
11:28 PM Changeset in webkit [59522] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

scm.py should use self.run instead of run_command
​https://bugs.webkit.org/show_bug.cgi?id=38957

We've wanted to do this for a while, but it's a prerequiste for running
SVN from the cwd instead of the checkout_root.

  • Scripts/webkitpy/common/checkout/scm.py:
11:27 PM Changeset in webkit [59521] by sfalken@apple.com
  • 5 edits in tags/Safari-533.9.3

Versioning.

11:11 PM Changeset in webkit [59520] by sfalken@apple.com
  • 2 edits in tags/Safari-533.9.3/WebCore

Merge r59515.

11:07 PM Changeset in webkit [59519] by sfalken@apple.com
  • 1 copy in tags/Safari-533.9.3

New tag.

11:05 PM Changeset in webkit [59518] by sfalken@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59515.

10:32 PM Changeset in webkit [59517] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-14 Adam Barth <​abarth@webkit.org>

Unreviewed.

Skip new test that fails on Qt. I'm sure skipping is the wrong thing
but no one is around to help me figure out what the right thing to do
is and I don't want to leave the bot red all weekend.

  • platform/qt/Skipped:
9:46 PM Changeset in webkit [59516] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=39095
<rdar://problem/7984158> REGRESSION (r53085): Infinite recursion in Position::getInlineBoxAndOffset when changing writing direction to right-to-left

Reviewed by Dave Hyatt.

Test: editing/selection/applystyle-to-inline-inside-block.html

  • dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Now that this function correctly goes in and out of editable areas by calling

downstreamIgnoringEditingBoundaries and upstreamIgnoringEditingBoundaries for blocks (added in r58665), we no longer need a special case to
jump out to the parent when we hit an inline (which was added in r53085 when this issue was introduced).

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=39095
<rdar://problem/7984158> REGRESSION (r53085): Infinite recursion in Position::getInlineBoxAndOffset when changing writing direction to right-to-left

Reviewed by Dave Hyatt.

  • editing/selection/applystyle-to-inline-in-block-expected.txt: Added.
  • editing/selection/applystyle-to-inline-in-block.html: Added.
8:49 PM Changeset in webkit [59515] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Hopefully a last fix for the build. Call -mkdir instead of mkdir, so we don't bail if the mkdir call fails. Additionally,
use the %Env% syntax instead of $(Env), which is what we need if we are referring to Windows environment variables instead
of nmake variables.

Reviewed by Mark Rowe.

  • WebCore.vcproj/WebCore.make:
8:40 PM Changeset in webkit [59514] by Stephanie Lewis
  • 6 edits in trunk

Update order files.

Rubber-stamped by Mark Rowe.

JavaScriptCore:

WebCore:

  • WebCore.order:

WebKit/mac:

  • WebKit.order:
8:17 PM Changeset in webkit [59513] by hyatt@apple.com
  • 16 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=39137

Reviewed by Simon Fraser.

WebCore:

Make RenderLayers position properly inside multicolumn layout.

(1) Create RenderLayers when column properties are specified. This allows descendant layers to easily
know they are inside a multicolumn layout when positioning.

(2) Patch updateLayerPosition to offset the layer into the first column that contains the layer. Splitting
of a layer across columns still does not work, but the layer will now at least appear in the first column in
which it occurs.

(3) Fix pagination bugs caused by the fact that visual overflow doesn't propagate up the line box tree when layers
are involved. Make sure to use lineTop and lineBottom in this case (it's not perfect, but it gets most cases
working properly). With this change elements like <video> will paginate properly and not get split across pages.

(4) Make column repainting and layer positioning work with RTL columns by fixing adjustForColumns to
account for RTL.

(5) Fix RTL pagination by making sure the column pagination rects are the content width of the whole block and not just
the width of one column.

Added fast/multicol/layers-in-multicol.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderBox.h:

(WebCore::RenderBox::locationOffset):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::requiresLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::requiresLayer):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::specifiesColumns):

LayoutTests:

Reset all multicolumn test results now that columns create RenderLayers.

  • fast/multicol/client-rects-expected.txt:
  • fast/multicol/layers-in-multicol.html: Added.
  • fast/multicol/single-line-expected.txt:
  • platform/mac/fast/multicol/column-rules-expected.txt:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.txt:


Add a layout test for various types of RenderLayers inside multicol layouts.

  • platform/mac/fast/multicol/layers-in-multicol-expected.txt: Added.
7:54 PM Changeset in webkit [59512] by eric@webkit.org
  • 5 edits in trunk

2010-05-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Consider implementing addOriginAccessWhitelistEntry method
​https://bugs.webkit.org/show_bug.cgi?id=37578

Remove deprecated methods.

  • public/WebSecurityPolicy.h:
  • src/WebSecurityPolicy.cpp:

2010-05-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Consider implementing addOriginAccessWhitelistEntry method
​https://bugs.webkit.org/show_bug.cgi?id=37578

Remove deprecated methods.

  • DumpRenderTree/chromium/LayoutTestController.cpp
  • DumpRenderTree/chromium/LayoutTestController.h
6:57 PM Changeset in webkit [59511] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-14 Leon Clarke <​leonclarke@google.com>

Reviewed by Steve Block.

Refactor signature of tokenizeRelAttribute and the variables it refers to so that new features don't keep changing the signature, and make m_disabledState into an enum.
​https://bugs.webkit.org/show_bug.cgi?id=38900

No new tests. Refactoring only.

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute): (WebCore::HTMLLinkElement::isAlternate): (WebCore::HTMLLinkElement::isDisabled): (WebCore::HTMLLinkElement::isEnabledViaScript): (WebCore::HTMLLinkElement::isIcon): (WebCore::HTMLLinkElement::):
  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::processAttribute):
6:43 PM Changeset in webkit [59510] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer caches directly composited images
​https://bugs.webkit.org/show_bug.cgi?id=38444

Directly-composited images and solid fills shouldn't be cached, as that cache
is never used (see GraphicsLayerQtImpl::paint). Cache is only relevant for HTML content,
but we were missing that test.
The fix makes sure we only cache HTML content.

No new tests: this is a minor optimization.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
6:18 PM Changeset in webkit [59509] by mrowe@apple.com
  • 5 edits in tags/Safari-533.9.2

Versioning.

6:08 PM Changeset in webkit [59508] by mrowe@apple.com
  • 2 edits in tags/Safari-533.9.2/WebCore

Merge r59505.

5:56 PM Changeset in webkit [59507] by mrowe@apple.com
  • 1 copy in tags/Safari-533.9.2

New tag.

5:55 PM Changeset in webkit [59506] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59505.

5:45 PM Changeset in webkit [59505] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Build fix. Had the environment variables wrong for source and destination of the copy operation
that was added.

Reviewed by Mark Rowe.

  • WebCore.vcproj/WebCore.make:
5:29 PM Changeset in webkit [59504] by ap@apple.com
  • 2 edits
    4 moves in trunk/LayoutTests

Inspired by Simon Fraser, rubber-stamped by Geoff Garen.

Disabled Sputnik tests that take over 10 seconds in debug builds on my MacBook Pro.

  • platform/mac-tiger/Skipped: These tests were alrady skipped on Tiger, no need to skip explicitly any more.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html: Removed.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html-disabled: Copied from fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html: Removed.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html-disabled: Copied from fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html: Removed.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html-disabled: Copied from fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html: Removed.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html-disabled: Copied from fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html.
5:08 PM Changeset in webkit [59503] by eric@webkit.org
  • 9 edits in trunk/JavaScriptCore

2010-05-14 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Implementation of QtScript API that provide method to convert a value to an object.

[Qt] QtScript is missing toObject API
​https://bugs.webkit.org/show_bug.cgi?id=36594

  • qt/api/qscriptengine.cpp: (QScriptEngine::toObject):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptvalue.cpp: (QScriptValue::toObject):
  • qt/api/qscriptvalue.h:
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toObject):
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::toObject): (tst_QScriptEngine::toObjectTwoEngines):
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::toObjectSimple):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
4:34 PM Changeset in webkit [59502] by abarth@webkit.org
  • 7 edits in trunk/WebCore

2010-05-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom bindings for HTMLInputElement
​https://bugs.webkit.org/show_bug.cgi?id=38344

Fix a bug in the TestObj.idl file and update expected results. This
was originally part of a larger change reviewed by Eric, but I'm
landing it separately to help me understand the more interesting bits
of the patch clearly.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithGetterException):
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj setAttrWithGetterException:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
4:12 PM Changeset in webkit [59501] by jparent@chromium.org
  • 2 edits in trunk/BugsSite

Bugzilla: Only show "Rietveld Review" link when in-rietveld is set to +.

Reviewed by Ojan Vafai.

​https://bugs.webkit.org/show_bug.cgi?id=39141

  • template/en/custom/attachment/list.html.tmpl:
3:54 PM Changeset in webkit [59500] by jparent@chromium.org
  • 2 edits in trunk/BugsSite

Bugzilla: Don't send mail if the only change is to the in-rietveld flag.

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=39090

  • Bugzilla/BugMail.pm:
3:52 PM EFLWebKit edited by leandro@profusion.mobi
(diff)
3:52 PM EFLWebKit edited by leandro@profusion.mobi
(diff)
3:50 PM EFLWebKit edited by leandro@profusion.mobi
(diff)
3:50 PM EFLWebKit edited by leandro@profusion.mobi
(diff)
3:37 PM Changeset in webkit [59499] by kbr@google.com
  • 30 edits
    64 moves in trunk

2010-05-14 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
​https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData):

2010-05-14 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
​https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSArrayBufferConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.cpp. (WebCore::): (WebCore::JSArrayBufferConstructor::JSArrayBufferConstructor): (WebCore::constructCanvasArrayBuffer): (WebCore::JSArrayBufferConstructor::getConstructData):
  • bindings/js/JSArrayBufferConstructor.h: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.h. (WebCore::construct):
  • bindings/js/JSArrayBufferViewCustom.cpp: Copied from WebCore/bindings/js/JSWebGLArrayCustom.cpp. (WebCore::toJS): (WebCore::JSArrayBufferView::slice):
  • bindings/js/JSArrayBufferViewHelper.h: Copied from WebCore/bindings/js/JSWebGLArrayHelper.h.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray): (WebCore::JSDOMWindow::webGLArrayBuffer): (WebCore::JSDOMWindow::webGLByteArray): (WebCore::JSDOMWindow::webGLUnsignedByteArray): (WebCore::JSDOMWindow::webGLIntArray): (WebCore::JSDOMWindow::webGLUnsignedIntArray): (WebCore::JSDOMWindow::webGLShortArray): (WebCore::JSDOMWindow::webGLUnsignedShortArray): (WebCore::JSDOMWindow::webGLFloatArray):
  • bindings/js/JSFloatArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.cpp. (WebCore::): (WebCore::JSFloatArrayConstructor::JSFloatArrayConstructor): (WebCore::constructCanvasFloatArray): (WebCore::JSFloatArrayConstructor::getConstructData):
  • bindings/js/JSFloatArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.h.
  • bindings/js/JSFloatArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayCustom.cpp. (WebCore::JSFloatArray::indexSetter): (WebCore::toJS): (WebCore::JSFloatArray::set):
  • bindings/js/JSInt16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.cpp. (WebCore::): (WebCore::JSInt16ArrayConstructor::JSInt16ArrayConstructor): (WebCore::constructCanvasShortArray): (WebCore::JSInt16ArrayConstructor::getConstructData):
  • bindings/js/JSInt16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.h.
  • bindings/js/JSInt16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayCustom.cpp. (WebCore::JSInt16Array::indexSetter): (WebCore::toJS): (WebCore::JSInt16Array::set):
  • bindings/js/JSInt32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.cpp. (WebCore::): (WebCore::JSInt32ArrayConstructor::JSInt32ArrayConstructor): (WebCore::constructCanvasIntArray): (WebCore::JSInt32ArrayConstructor::getConstructData):
  • bindings/js/JSInt32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.h.
  • bindings/js/JSInt32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayCustom.cpp. (WebCore::JSInt32Array::indexSetter): (WebCore::toJS): (WebCore::JSInt32Array::set):
  • bindings/js/JSInt8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.cpp. (WebCore::): (WebCore::JSInt8ArrayConstructor::JSInt8ArrayConstructor): (WebCore::constructCanvasByteArray): (WebCore::JSInt8ArrayConstructor::getConstructData):
  • bindings/js/JSInt8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.h.
  • bindings/js/JSInt8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayCustom.cpp. (WebCore::JSInt8Array::indexSetter): (WebCore::toJS): (WebCore::JSInt8Array::set):
  • bindings/js/JSUint16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp. (WebCore::): (WebCore::JSUint16ArrayConstructor::JSUint16ArrayConstructor): (WebCore::constructCanvasUnsignedShortArray): (WebCore::JSUint16ArrayConstructor::getConstructData):
  • bindings/js/JSUint16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.h.
  • bindings/js/JSUint16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayCustom.cpp. (WebCore::JSUint16Array::indexSetter): (WebCore::toJS): (WebCore::JSUint16Array::set):
  • bindings/js/JSUint32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp. (WebCore::): (WebCore::JSUint32ArrayConstructor::JSUint32ArrayConstructor): (WebCore::constructCanvasUnsignedIntArray): (WebCore::JSUint32ArrayConstructor::getConstructData):
  • bindings/js/JSUint32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.h.
  • bindings/js/JSUint32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayCustom.cpp. (WebCore::JSUint32Array::indexSetter): (WebCore::toJS): (WebCore::JSUint32Array::set):
  • bindings/js/JSUint8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp. (WebCore::): (WebCore::JSUint8ArrayConstructor::JSUint8ArrayConstructor): (WebCore::constructCanvasUnsignedByteArray): (WebCore::JSUint8ArrayConstructor::getConstructData):
  • bindings/js/JSUint8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.h.
  • bindings/js/JSUint8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayCustom.cpp. (WebCore::JSUint8Array::indexSetter): (WebCore::toJS): (WebCore::JSUint8Array::set):
  • bindings/js/JSWebGLArrayBufferConstructor.cpp: Removed.
  • bindings/js/JSWebGLArrayBufferConstructor.h: Removed.
  • bindings/js/JSWebGLArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLArrayHelper.h: Removed.
  • bindings/js/JSWebGLByteArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLByteArrayConstructor.h: Removed.
  • bindings/js/JSWebGLByteArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLFloatArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLFloatArrayConstructor.h: Removed.
  • bindings/js/JSWebGLFloatArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLIntArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLIntArrayConstructor.h: Removed.
  • bindings/js/JSWebGLIntArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::bufferData): (WebCore::JSWebGLRenderingContext::bufferSubData): (WebCore::JSWebGLRenderingContext::texImage2D): (WebCore::JSWebGLRenderingContext::texSubImage2D): (WebCore::dataFunctionf): (WebCore::dataFunctioni): (WebCore::dataFunctionMatrix):
  • bindings/js/JSWebGLShortArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLShortArrayConstructor.h: Removed.
  • bindings/js/JSWebGLShortArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLUnsignedByteArrayConstructor.h: Removed.
  • bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLUnsignedIntArrayConstructor.h: Removed.
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLUnsignedShortArrayConstructor.h: Removed.
  • bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: Removed.
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayBufferCustom.cpp. (WebCore::V8ArrayBuffer::constructorCallback):
  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.cpp. (WebCore::toV8): (WebCore::V8ArrayBufferView::sliceCallback):
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.h. (WebCore::constructWebGLArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::WebGLArrayBufferAccessorGetter): (WebCore::V8DOMWindow::WebGLByteArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedByteArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLShortArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedShortArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLIntArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedIntArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLFloatArrayAccessorGetter):
  • bindings/v8/custom/V8FloatArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLFloatArrayCustom.cpp. (WebCore::V8FloatArray::constructorCallback): (WebCore::V8FloatArray::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Int16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLShortArrayCustom.cpp. (WebCore::V8Int16Array::constructorCallback): (WebCore::V8Int16Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Int32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLIntArrayCustom.cpp. (WebCore::V8Int32Array::constructorCallback): (WebCore::V8Int32Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Int8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLByteArrayCustom.cpp. (WebCore::V8Int8Array::constructorCallback): (WebCore::V8Int8Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp. (WebCore::V8Uint16Array::constructorCallback): (WebCore::V8Uint16Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp. (WebCore::V8Uint32Array::constructorCallback): (WebCore::V8Uint32Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp. (WebCore::V8Uint8Array::constructorCallback): (WebCore::V8Uint8Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLArrayCustom.h: Removed.
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: Removed.
  • html/canvas/ArrayBuffer.cpp: Copied from WebCore/html/canvas/WebGLArrayBuffer.cpp. (WebCore::ArrayBuffer::create): (WebCore::ArrayBuffer::ArrayBuffer): (WebCore::ArrayBuffer::data): (WebCore::ArrayBuffer::byteLength): (WebCore::ArrayBuffer::~ArrayBuffer): (WebCore::ArrayBuffer::tryAllocate):
  • html/canvas/ArrayBuffer.h: Copied from WebCore/html/canvas/WebGLArrayBuffer.h.
  • html/canvas/ArrayBuffer.idl: Copied from WebCore/html/canvas/WebGLArrayBuffer.idl.
  • html/canvas/ArrayBufferView.cpp: Copied from WebCore/html/canvas/WebGLArray.cpp. (WebCore::ArrayBufferView::ArrayBufferView): (WebCore::ArrayBufferView::~ArrayBufferView): (WebCore::ArrayBufferView::setImpl): (WebCore::ArrayBufferView::calculateOffsetAndLength):
  • html/canvas/ArrayBufferView.h: Copied from WebCore/html/canvas/WebGLArray.h. (WebCore::ArrayBufferView::buffer): (WebCore::ArrayBufferView::verifySubRange): (WebCore::ArrayBufferView::clampOffsetAndNumElements):
  • html/canvas/ArrayBufferView.idl: Copied from WebCore/html/canvas/WebGLArray.idl.
  • html/canvas/FloatArray.cpp: Copied from WebCore/html/canvas/WebGLFloatArray.cpp. (WebCore::FloatArray::create): (WebCore::FloatArray::FloatArray): (WebCore::FloatArray::slice):
  • html/canvas/FloatArray.h: Copied from WebCore/html/canvas/WebGLFloatArray.h. (WebCore::FloatArray::set): (WebCore::FloatArray::item):
  • html/canvas/FloatArray.idl: Copied from WebCore/html/canvas/WebGLFloatArray.idl.
  • html/canvas/Int16Array.cpp: Copied from WebCore/html/canvas/WebGLShortArray.cpp. (WebCore::Int16Array::create): (WebCore::Int16Array::Int16Array): (WebCore::Int16Array::slice):
  • html/canvas/Int16Array.h: Copied from WebCore/html/canvas/WebGLShortArray.h.
  • html/canvas/Int16Array.idl: Copied from WebCore/html/canvas/WebGLShortArray.idl.
  • html/canvas/Int32Array.cpp: Copied from WebCore/html/canvas/WebGLIntArray.cpp. (WebCore::Int32Array::create): (WebCore::Int32Array::Int32Array): (WebCore::Int32Array::slice):
  • html/canvas/Int32Array.h: Copied from WebCore/html/canvas/WebGLIntArray.h.
  • html/canvas/Int32Array.idl: Copied from WebCore/html/canvas/WebGLIntArray.idl.
  • html/canvas/Int8Array.cpp: Copied from WebCore/html/canvas/WebGLByteArray.cpp. (WebCore::Int8Array::create): (WebCore::Int8Array::Int8Array): (WebCore::Int8Array::slice):
  • html/canvas/Int8Array.h: Copied from WebCore/html/canvas/WebGLByteArray.h.
  • html/canvas/Int8Array.idl: Copied from WebCore/html/canvas/WebGLByteArray.idl.
  • html/canvas/IntegralTypedArrayBase.h: Copied from WebCore/html/canvas/WebGLIntegralTypedArrayBase.h. (WebCore::IntegralTypedArrayBase::set): (WebCore::IntegralTypedArrayBase::item): (WebCore::IntegralTypedArrayBase::IntegralTypedArrayBase):
  • html/canvas/TypedArrayBase.h: Copied from WebCore/html/canvas/WebGLTypedArrayBase.h. (WebCore::TypedArrayBase::set): (WebCore::TypedArrayBase::TypedArrayBase): (WebCore::TypedArrayBase::create):
  • html/canvas/Uint16Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.cpp. (WebCore::Uint16Array::create): (WebCore::Uint16Array::Uint16Array): (WebCore::Uint16Array::slice):
  • html/canvas/Uint16Array.h: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.h.
  • html/canvas/Uint16Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.idl.
  • html/canvas/Uint32Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.cpp. (WebCore::Uint32Array::create): (WebCore::Uint32Array::Uint32Array): (WebCore::Uint32Array::slice):
  • html/canvas/Uint32Array.h: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.h.
  • html/canvas/Uint32Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.idl.
  • html/canvas/Uint8Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.cpp. (WebCore::Uint8Array::create): (WebCore::Uint8Array::Uint8Array): (WebCore::Uint8Array::slice):
  • html/canvas/Uint8Array.h: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.h.
  • html/canvas/Uint8Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.idl.
  • html/canvas/WebGLArray.cpp: Removed.
  • html/canvas/WebGLArray.h: Removed.
  • html/canvas/WebGLArray.idl: Removed.
  • html/canvas/WebGLArrayBuffer.cpp: Removed.
  • html/canvas/WebGLArrayBuffer.h: Removed.
  • html/canvas/WebGLArrayBuffer.idl: Removed.
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData):
  • html/canvas/WebGLBuffer.h: (WebCore::WebGLBuffer::elementArrayBuffer):
  • html/canvas/WebGLByteArray.cpp: Removed.
  • html/canvas/WebGLByteArray.h: Removed.
  • html/canvas/WebGLByteArray.idl: Removed.
  • html/canvas/WebGLFloatArray.cpp: Removed.
  • html/canvas/WebGLFloatArray.h: Removed.
  • html/canvas/WebGLFloatArray.idl: Removed.
  • html/canvas/WebGLGetInfo.cpp: (WebCore::WebGLGetInfo::WebGLGetInfo): (WebCore::WebGLGetInfo::getWebGLFloatArray): (WebCore::WebGLGetInfo::getWebGLIntArray): (WebCore::WebGLGetInfo::getWebGLUnsignedByteArray):
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLIntArray.cpp: Removed.
  • html/canvas/WebGLIntArray.h: Removed.
  • html/canvas/WebGLIntArray.idl: Removed.
  • html/canvas/WebGLIntegralTypedArrayBase.h: Removed.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::vertexAttrib1fv): (WebCore::WebGLRenderingContext::vertexAttrib2fv): (WebCore::WebGLRenderingContext::vertexAttrib3fv): (WebCore::WebGLRenderingContext::vertexAttrib4fv): (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter): (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter): (WebCore::WebGLRenderingContext::getWebGLUnsignedByteArrayParameter):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLShortArray.cpp: Removed.
  • html/canvas/WebGLShortArray.h: Removed.
  • html/canvas/WebGLShortArray.idl: Removed.
  • html/canvas/WebGLTypedArrayBase.h: Removed.
  • html/canvas/WebGLUnsignedByteArray.cpp: Removed.
  • html/canvas/WebGLUnsignedByteArray.h: Removed.
  • html/canvas/WebGLUnsignedByteArray.idl: Removed.
  • html/canvas/WebGLUnsignedIntArray.cpp: Removed.
  • html/canvas/WebGLUnsignedIntArray.h: Removed.
  • html/canvas/WebGLUnsignedIntArray.idl: Removed.
  • html/canvas/WebGLUnsignedShortArray.cpp: Removed.
  • html/canvas/WebGLUnsignedShortArray.h: Removed.
  • html/canvas/WebGLUnsignedShortArray.idl: Removed.
  • page/DOMWindow.idl:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):

2010-05-14 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
​https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • fast/dom/script-tests/constructed-objects-prototypes.js: (constructorPropertiesOnWindow):
  • fast/dom/script-tests/prototype-inheritance-2.js: (constructorNamesForWindow):

2010-05-14 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
​https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • Scripts/do-webcore-rename: Handle the case where some renames are substrings of others. Support renaming files containing custom JS bindings. If isDOMTypeRename is non-zero, expand the regexp which rewrites the file's contents in order to support custom JS bindings.
3:32 PM Changeset in webkit [59498] by sfalken@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7985864> Connection properties dictionary should use standard callbacks for keys, values
​https://bugs.webkit.org/show_bug.cgi?id=39132

Reviewed by Sam Weinig.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::createConnectionProperties):

3:27 PM Changeset in webkit [59497] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebKit/win/ChangeLog

Merge r59438.

3:27 PM Changeset in webkit [59496] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch/WebKit/win

Merge r59434.

3:14 PM Changeset in webkit [59495] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-05-14 Abhishek Arya <​inferno@chromium.org>

Reviewed by David Hyatt.

Tests that large colspan in a fixed table layout does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=38261

  • fast/table/fixed-table-layout-large-colspan-crash-expected.txt: Added.
  • fast/table/fixed-table-layout-large-colspan-crash.html: Added.

2010-05-14 Abhishek Arya <​inferno@chromium.org>

Reviewed by David Hyatt.

Move the m_width(Length) and m_columns(RenderTable::ColumnStruct)
vector out-of-bounds check out of the ASSERT into the main code.
​https://bugs.webkit.org/show_bug.cgi?id=38261

Test: fast/table/fixed-table-layout-large-colspan-crash.html

  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
3:08 PM Changeset in webkit [59494] by mrowe@apple.com
  • 5 edits in tags/Safari-533.9.1

Versioning.

3:04 PM Changeset in webkit [59493] by mrowe@apple.com
  • 2 edits in tags/Safari-533.9.1/WebCore

Merge r59481.

2:54 PM Changeset in webkit [59492] by mrowe@apple.com
  • 1 copy in tags/Safari-533.9.1

New tag.

2:54 PM Changeset in webkit [59491] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59481.

2:14 PM Changeset in webkit [59490] by eric@webkit.org
  • 28 edits in trunk

2010-05-14 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59489.
​http://trac.webkit.org/changeset/59489
​https://bugs.webkit.org/show_bug.cgi?id=37815

abarth broke the known universe and then some.

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:

2010-05-14 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r59489.
​http://trac.webkit.org/changeset/59489
​https://bugs.webkit.org/show_bug.cgi?id=37815

abarth broke the known universe and then some.

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):
1:52 PM Changeset in webkit [59489] by abarth@webkit.org
  • 28 edits in trunk

2010-05-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
​https://bugs.webkit.org/show_bug.cgi?id=37815

Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
​https://bugs.webkit.org/show_bug.cgi?id=37815

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
1:49 PM Changeset in webkit [59488] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2010-05-14 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

Update tools.html to mention that Tiger users require a newer Python
​https://bugs.webkit.org/show_bug.cgi?id=38822

Also updated the instructions that only Tiger users need
to install a subversion client. Newer OSes already have
subversion included in the install.

  • building/tools.html:
1:36 PM Changeset in webkit [59487] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Adding resized image caching for Skia.
​https://bugs.webkit.org/show_bug.cgi?id=39085

Patch by Sergey Ulanov <​sergeyu@chromium.org> on 2010-05-14
Reviewed by Dmitry Titov and Brett Wilson.

Tests: HTML5 video on YouTube.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::Image::drawPattern): Use bitmap->resizedBitmap() to cache resized image when possible.

1:32 PM Changeset in webkit [59486] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=39008
<rdar://problem/7976142> REGRESSION (r58950): Webkit crashes on clicking back button when in Hotmail

Test: fast/parser/tokenizer-close-during-document-write.html

  • dom/Document.cpp: (WebCore::Document::write): Check that the tokenizer is still around after calling write(). It can become null (as it happens in regression test), and I don't see any guarantee that it would never be replaced with a different one (but I can't make a test for that).
1:31 PM Changeset in webkit [59485] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Fix the code indentation inside a namespace to be consistent with the
style guide.

Rubber-stamped by Dmitry Titov.

  • workers/GenericWorkerTask.h:
1:24 PM Changeset in webkit [59484] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and rename
all occurrences of GenericWorkerTask* to GenericTask* in this file.
​https://bugs.webkit.org/show_bug.cgi?id=39129

Reviewed by Dmitry Titov.

I will have another patch to rename the file and move it to the right
place.

  • workers/GenericWorkerTask.h:

(WebCore::):
(WebCore::GenericTask1::create):
(WebCore::GenericTask1::GenericTask1):
(WebCore::GenericTask2::create):
(WebCore::GenericTask2::GenericTask2):
(WebCore::GenericTask3::create):
(WebCore::GenericTask3::GenericTask3):
(WebCore::GenericTask4::create):
(WebCore::GenericTask4::GenericTask4):
(WebCore::GenericTask5::create):
(WebCore::GenericTask5::GenericTask5):
(WebCore::GenericTask6::create):
(WebCore::GenericTask6::GenericTask6):
(WebCore::GenericTask7::create):
(WebCore::GenericTask7::GenericTask7):
(WebCore::GenericTask8::create):
(WebCore::GenericTask8::GenericTask8):
(WebCore::createCallbackTask):

1:16 PM Changeset in webkit [59483] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-14 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] don't call fontconfig twice in complex text path
​https://bugs.webkit.org/show_bug.cgi?id=38701

Previously getFontDataForCharacters would call fontconfig once to
resolve a font name, then pass that name to getCachedFontPlatformData
to load the font. This would be two trips through fontconfig (including
IPCs). With this change, we completely load the font in the first pass.

This patch is actually the same code as in r58341, which was reverted
because of a performance problem; a performance improvement has now
been committed, and with that change in place this change improves
the Chromium intl2 page cycler performance by another 5%.

See also ​https://bugs.webkit.org/show_bug.cgi?id=37904 .

Test: fast/text/international/bold-bengali.html
(Was checked in as part of the first attempt at this change, continues
to pass after this change.)

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
12:49 PM Changeset in webkit [59482] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Young Han Lee <​joybro@company100.net>

Reviewed by Darin Adler.

Don't include RetainPtr.h unless PLATFORM(CF) is set.
The RetainPtr is only used for CF platform in this class.
​https://bugs.webkit.org/show_bug.cgi?id=39043

No new tests, there is no new functionality.

  • platform/network/curl/ResourceHandleManager.cpp:
12:21 PM Changeset in webkit [59481] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Build fix, we need to copy over the files in $(WebKitOutputDir)/include/JavaScriptCore/private before
WebCore builds. This is because we are building a couple WTF files in WebCore and JavaScriptCore.

Reviewed by Adam Roben.

  • WebCore.vcproj/WebCore.make:
12:18 PM Changeset in webkit [59480] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch rollout throws exception if bug is already open
​https://bugs.webkit.org/show_bug.cgi?id=38803

This was caused by someone incorrectly wrapping the code. :p
I'm going to have to start demanding unit tests for wrapping changes...

I also fixed the code to be able to reopen bugs which were never confirmed.
Before it regressed, the code would just log in that case. Now it actually
will reopen the bug, but there is a FIXME about how the logic is a bit backwards.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
    • Yay testing!
11:59 AM Changeset in webkit [59479] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-05-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

Temporarily remove a few test cases that failed on leopard bot.
​https://bugs.webkit.org/show_bug.cgi?id=33805

  • fast/canvas/webgl/texture-npot-expected.txt: Removed failed test cases.
  • fast/canvas/webgl/texture-npot.html: Ditto.
11:49 AM Changeset in webkit [59478] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-14 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium: update test expectations.

  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt:
9:55 AM Changeset in webkit [59477] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2010-05-14 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Attempt to fix chromium's memory bot error.

More :visited link optimizations to reduce memory usage
​https://bugs.webkit.org/show_bug.cgi?id=39084

The original change (r59386) adds check for m_element in initElement.
As don't initialize m_element in the constructor of CSSStyleSelector,
valgrind complains.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
9:33 AM Changeset in webkit [59476] by jorlow@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2010-05-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Instead of rebaslining prototype-inheritance for Chromium, add indexedDB to its exceptions
​https://bugs.webkit.org/show_bug.cgi?id=39122

The test has a way to name properties that shouldn't be tested (used when they're not enabled
by most ports). Use this feature rather than creating custom baselines.

  • fast/dom/script-tests/prototype-inheritance.js:
  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
9:03 AM Changeset in webkit [59475] by jorlow@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Rebaseline prototype-inheritance
​https://bugs.webkit.org/show_bug.cgi?id=39116

IndexedDB is now turned on for Chromium's test shell. I'm not sure
if this is the correct behavior or not (can someone confirm which it is?)
but we should get this test running again so we can catch real regressions.
And, before taking this out from behind a flag, we should be sure to fix it.

  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Added.
8:59 AM QtWebKitBugs edited by Simon Hausmann
(diff)
8:24 AM Changeset in webkit [59474] by Simon Hausmann
  • 5 edits
    3 copies
    2 deletes in trunk

.: [Qt] Rename QtLauncher to QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=37665

Rubber-stamped by Antti Koivisto.

  • WebKit.pro:

WebKitTools: [Qt] Rename QtLauncher to QtTestBrowser

Rubber-stamped by Antti Koivisto.

  • QtTestBrowser: Copied from WebKitTools/QtLauncher.
  • QtTestBrowser/QtLauncher.pro: Removed.
  • QtTestBrowser/QtLauncher.qrc: Removed.
  • QtTestBrowser/QtTestBrowser.pro: Copied from WebKitTools/QtLauncher/QtLauncher.pro.
  • QtTestBrowser/QtTestBrowser.qrc: Copied from WebKitTools/QtLauncher/QtLauncher.qrc.
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:
8:12 AM QtWebKitTriageRoster edited by jesus@webkit.org
(diff)
8:11 AM QtWebKitBugs edited by jesus@webkit.org
(diff)
7:47 AM Changeset in webkit [59473] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

CSSParser::parseColor() shouldn't alter 'color' unless passed a valid color string.
​https://bugs.webkit.org/show_bug.cgi?id=39031

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles): Don't depend on old behavior.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): Remove dead code.
7:16 AM Changeset in webkit [59472] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Jens Alfke <​snej@chromium.org>

Reviewed by John Sullivan.

Don't clear yellow autofill highlight from text fields until the user edits them.
​https://bugs.webkit.org/show_bug.cgi?id=39032
No new tests (Couldn't find any autofill tests. The flag doesn't seem to be exposed to JS.)

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::handleFocusEvent): Don't clear the autofilled flag. (WebCore::HTMLInputElement::setValueFromRenderer): Clear the autofilled flag.
5:57 AM Changeset in webkit [59471] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed, unskip passing tests.

[Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=37381

  • platform/qt/Skipped:
    • animations/simultaneous-start-left.html unskipped.
    • animations/dynamic-stylesheet-loading.html unskipped.
5:52 AM Changeset in webkit [59470] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-05-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must implement OpenGL ES 2.0 semantics for NPOT textures
​https://bugs.webkit.org/show_bug.cgi?id=33805

  • fast/canvas/webgl/texture-npot-expected.txt: Added.
  • fast/canvas/webgl/texture-npot.html: Added.

2010-05-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Must implement OpenGL ES 2.0 semantics for NPOT textures
​https://bugs.webkit.org/show_bug.cgi?id=33805

Test: fast/canvas/webgl/texture-npot.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Create black 1x1 textures. (WebCore::WebGLRenderingContext::bindTexture): Set texture dimensionality. (WebCore::WebGLRenderingContext::copyTexImage2D): Error check, set texture size. (WebCore::WebGLRenderingContext::drawArrays): Bind to black textures if needed. (WebCore::WebGLRenderingContext::drawElements): Bind to black textures if needed. (WebCore::WebGLRenderingContext::generateMipmap): Error check. (WebCore::WebGLRenderingContext::texImage2DBase): Error check, set texture size. (WebCore::WebGLRenderingContext::texParameterf): Set texture parameter. (WebCore::WebGLRenderingContext::texParameteri): Ditto. (WebCore::WebGLRenderingContext::handleNPOTTextures): Bind to black textures if needed before draw, and bind back to original textures after draw.
  • html/canvas/WebGLRenderingContext.h: Add black 1x1 textures.
  • html/canvas/WebGLTexture.cpp: Add support to track NPOT textures. (WebCore::WebGLTexture::createBlackTexture1x1): Create a black 1x1 texture. (WebCore::WebGLTexture::WebGLTexture): Initialize parameters and states. (WebCore::WebGLTexture::setDimensionality): Set dimensionality. (WebCore::WebGLTexture::setParameteri): Set parameter. (WebCore::WebGLTexture::setParameterf): Ditto. (WebCore::WebGLTexture::setSize): Set level 0 texture size. (WebCore::WebGLTexture::isNPOT): Whether the texture is NPOT. (WebCore::WebGLTexture::updateNPOTStates): Calculate NPOT and NeedToUseBlackTexture states.
  • html/canvas/WebGLTexture.h: Add support to track NPOT textures. (WebCore::WebGLTexture::isNPOT): (WebCore::WebGLTexture::needToUseBlackTexture):
5:39 AM Changeset in webkit [59469] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-14 Chao-ying Fu <​fu@mips.com>

Reviewed by Oliver Hunt.

String Indexing Failure on JSVALUE32 targets
​https://bugs.webkit.org/show_bug.cgi?id=39034

Remove zero-extend/shift-right code on regT1, because we already have
it in emit_op_get_by_val().

  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator):
5:36 AM Changeset in webkit [59468] by pfeldman@chromium.org
  • 17 edits
    3 adds in trunk/WebCore

2010-05-14 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add help on keyboard shortcuts (take 2).

​https://bugs.webkit.org/show_bug.cgi?id=38667

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._registerShortcuts):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._keyDown):
  • inspector/front-end/HelpScreen.js: Added.
  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/ScriptsPanel.js:
5:32 AM QtWebKitTriageRoster edited by Csaba Osztrogonác
(diff)
5:28 AM Changeset in webkit [59467] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-05-14 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Eric Seidel.

Make ImageDiff depend on webkit (again).
​https://bugs.webkit.org/show_bug.cgi?id=39000

  • WebKit.gyp:
5:16 AM Changeset in webkit [59466] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-05-14 James Simonsen <​simonjam+webkit@google.com>

Reviewed by Darin Fisher.

[chromium] Expose volume through WebMediaPlayerClient
​https://bugs.webkit.org/show_bug.cgi?id=38947

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::volume):
  • src/WebMediaPlayerClientImpl.h:
5:03 AM QtWebKitJournal edited by Simon Hausmann
(diff)
4:55 AM Changeset in webkit [59465] by eric@webkit.org
  • 10 edits in trunk

2010-05-14 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Update chromium port to send/receive cached metadata
​https://bugs.webkit.org/show_bug.cgi?id=38665

No new tests because no new functionality.

  • platform/chromium/ChromiumBridge.h:
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::responseTime): (WebCore::ResourceResponse::setResponseTime):

2010-05-14 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Update chromium port to send/receive cached metadata
​https://bugs.webkit.org/show_bug.cgi?id=38665

  • public/WebKitClient.h: (WebKit::WebKitClient::cacheMetadata):
  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveCachedMetadata):
  • public/WebURLResponse.h:
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cacheMetadata):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveCachedMetadata): (WebCore::ResourceHandle::cacheMetadata):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::responseTime): (WebKit::WebURLResponse::setResponseTime):
4:32 AM Changeset in webkit [59464] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Stop CCing webkit-bot-watchers
​https://bugs.webkit.org/show_bug.cgi?id=39020

webkit-bot-watchers is somewhat of a failed experiment. No one
subscribed to the list (not even me). Removing it from the code
because wms says it bounces email sometimes.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
4:24 AM Changeset in webkit [59463] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

Fix a VS2010 assert in std::copy
​https://bugs.webkit.org/show_bug.cgi?id=38630

Reviewed by Alexey Proskuryakov.

The assert complains that the output iterator is null.

  • wtf/Vector.h:

(WTF::::operator):

4:21 AM Changeset in webkit [59462] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-14 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Chromium-specific fix to prevent zombie infobars.

​https://bugs.webkit.org/show_bug.cgi?id=38948

  • bindings/v8/ScriptController.cpp (WebCore::ScriptController::processingUserGesture): Require a more definite "no" signal.
  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::fire): Use a very strong yes / no signal; no need for "possible" here.
  • dom/UserGestureIndicator.h:
  • dom/UserGestureIndicator.cpp: Adapt to tri-state: definitely yes; definitely no; not sure.
3:55 AM Changeset in webkit [59461] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION: webkit-patch commit-message throws exception
​https://bugs.webkit.org/show_bug.cgi?id=38997

  • Scripts/webkitpy/tool/commands/upload.py:
    • Fix to respect and pass the --squash and --git-commit options.
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
    • Fix the unit test to use the central MockCheckout instead of its own custom Mock which didn't require enough parameters.
2:58 AM Changeset in webkit [59460] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] JavaScript unable to invoke methods declared in QML
​https://bugs.webkit.org/show_bug.cgi?id=38949

Patch by Aaron Kennedy <​tffeeb@gmail.com> on 2010-05-14
Reviewed by Simon Hausmann.

JavaScript code executed by webkit cannot call into QML declared
methods, as it does not check for dynamic meta objects.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::stringValue): Use QMetaObject::metacall.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call): Ditto.

2:50 AM Changeset in webkit [59459] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Ben Murdoch <​benm@google.com>

Reviewed by Darin Fisher.

Touch events are disabled by default when using V8.
​https://bugs.webkit.org/show_bug.cgi?id=38990

Touch events are protected by a compile time guard, so it's safe to
assume that the runtime flag should be enabled by default when this
guard is present.

No new tests, build fix for Android.

  • bindings/generic/RuntimeEnabledFeatures.cpp: enable touch events by default.
2:29 AM Changeset in webkit [59458] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch

<rdar://problem/7677994> Disable WebGL

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

  • Scripts/build-webkit:
2:23 AM Changeset in webkit [59457] by jorlow@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-14 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Rebaseline storage/domstorage/quota.html
​https://bugs.webkit.org/show_bug.cgi?id=38996

Chromium enforces quota on session storage and thus expects to "fail"
the first part of this test.

  • platform/chromium-mac/storage/domstorage/quota-expected.txt: Added.
  • platform/chromium-win/storage/domstorage/quota-expected.txt: Added.
2:14 AM Changeset in webkit [59456] by Simon Hausmann
  • 15 edits in trunk/WebKit/qt

[Qt] Merge overhaul of the QtWebKit API documentation

Patch by Kent Hansen <​kent.hansen@nokia.com>, Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>, Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>, Henry Haverinen <Henry Haverinen>, Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>, Andreas Kling <​andreas.kling@nokia.com> on 2010-05-14
Reviewed by Simon Hausmann.

Numerous improvements in wording, qdoc warning fixes and
clarifications, done in a team work effort.

No functional changes.

  • Api/qwebdatabase.cpp:
  • Api/qwebelement.cpp:
  • Api/qwebframe.cpp:
  • Api/qwebhistoryinterface.cpp:
  • Api/qwebinspector.cpp:
  • Api/qwebkitversion.cpp:
  • Api/qwebpage.cpp:
  • Api/qwebpluginfactory.cpp:
  • Api/qwebsecurityorigin.cpp:
  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:
  • docs/qtwebkit.qdoc:
  • docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp:

(wrapInFunction):

  • docs/webkitsnippets/webelement/main.cpp:

(findButtonAndClick):
(autocomplete1):
(autocomplete2):
(main):

2:04 AM Changeset in webkit [59455] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Documentation: Fix overview grouping.

Patch by Martin Smith <​msmith@trolltech.com> on 2010-05-14
Reviewed by Simon Hausmann.

  • docs/qtwebkit.qdoc:
1:49 AM Changeset in webkit [59454] by yurys@chromium.org
  • 7 edits
    2 adds in trunk/LayoutTests

2010-05-14 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium: update test expectations.

  • platform/chromium-linux/editing/deleting/5408255-expected.checksum:
  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt: Added.
  • platform/chromium-mac/editing/deleting/5408255-expected.checksum: Added.
  • platform/chromium-win/editing/deleting/5408255-expected.checksum:
  • platform/chromium-win/editing/deleting/5408255-expected.txt:
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/4895428-1-expected.txt:
  • platform/chromium-win/editing/selection/4895428-4-expected.txt:
1:44 AM Changeset in webkit [59453] by eric@webkit.org
  • 2 edits in trunk/WebKit

2010-05-14 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by David Levin.

[EF] Include missing header.
​http://webkit.org/b/38905

  • efl/ewk/ewk_main.cpp: Include PageGroup.h
1:43 AM Changeset in webkit [59452] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKitTools

Merge r59177.

1:32 AM Changeset in webkit [59451] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-14 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Laszlo Gombos.

[QT] Update the Symbian version for the user agent
​https://bugs.webkit.org/show_bug.cgi?id=38389

Update the user agent for Symbian2 to Symbian4

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
1:23 AM Changeset in webkit [59450] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Disable the Audits panel and Workers sidebar in the Web Inspector.

Patch by Timothy Hatcher <​timothy@apple.com> on 2010-05-13
<rdar://problem/7947035>

Reviewed by Ada Chan.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel): Don't make a workers sidebar pane.
(WebInspector.ScriptsPanel.prototype.reset): Null check workers sidebar pane.

  • inspector/front-end/Settings.js: Set auditsPanelEnabled to false.
  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.didCreateWorker): Null check workers sidebar pane.
(WebInspector.didDestroyWorker): Ditto.

1:21 AM Changeset in webkit [59449] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-14 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Simon Hausmann.

Implemented createJavaAppletWidget to activate Java applet support.

​https://bugs.webkit.org/show_bug.cgi?id=33044

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
1:09 AM Changeset in webkit [59448] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 George Wright <​gwright@rim.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=38909

Update JSDataGridColumnListCustom.cpp to call identifierToAtomicString()
on the property name.

  • bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::canGetItemsForName): (WebCore::JSDataGridColumnList::nameGetter):
12:43 AM Changeset in webkit [59447] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Add test to check that setting various CanvasRenderingContext2D properties
to invalid values is ignored.

​https://bugs.webkit.org/show_bug.cgi?id=38841

  • fast/canvas/canvas-invalid-values-expected.txt: Added.
  • fast/canvas/canvas-invalid-values.html: Added.
  • fast/canvas/script-tests/canvas-invalid-values.js: Added. (trySettingMiterLimit): (trySettingLineWidth): (trySettingShadowBlur): (trySettingShadowOffsetX): (trySettingShadowOffsetY):

2010-05-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Ignore invalid values for various CanvasRenderingContext2D properties
(lineWidth, miterLimit, shadowOffsetX, shadowOffsetY and shadowBlur)

​https://bugs.webkit.org/show_bug.cgi?id=38841

Test: fast/canvas/canvas-invalid-values.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setLineWidth): (WebCore::CanvasRenderingContext2D::setMiterLimit): (WebCore::CanvasRenderingContext2D::setShadowOffsetX): (WebCore::CanvasRenderingContext2D::setShadowOffsetY): (WebCore::CanvasRenderingContext2D::setShadowBlur):
12:08 AM Changeset in webkit [59446] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed, test expectation update.

deleted-host-in-resource-load-delegate-callback.html sometimes crashes on Windows Release.

May 13, 2010:

11:35 PM Changeset in webkit [59445] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with new exports.

  • symbian/eabi/QtWebKitu.def: Add missing gc symbol for QtLauncher
11:18 PM Changeset in webkit [59444] by Simon Fraser
  • 1 edit
    1 add in trunk/LayoutTests

2010-05-13 Simon Fraser <Simon Fraser>

Fixing test failure.

Adding resource that should have been added in r59443.

  • compositing/iframes/resources/subframe.html: Added.
10:32 PM Changeset in webkit [59443] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-05-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

iframes in compositing layers don't redraw correctly on scrolling
​https://bugs.webkit.org/show_bug.cgi?id=39096

When an iframe ends up in a compositing layer (that is painting to its backing store), we need
to turn off blitting on scrolling. RenderView::paintBoxDecorations() already has code to do this
for transformed frames, so do the same thing when the frame is enclosed in a compositing layer.

Test: compositing/iframes/iframe-copy-on-scroll.html

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
9:17 PM Changeset in webkit [59442] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-13 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] enable DRT build in chromium (for the last time)
​https://bugs.webkit.org/show_bug.cgi?id=39109

  • WebKit.gyp:
9:01 PM Changeset in webkit [59441] by tkent@chromium.org
  • 2 edits in trunk

Unreviewed. Move a ChangeLog entry inserted to a wrong file.

8:56 PM Changeset in webkit [59440] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-13 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Kent Tamura.

Update text_expectations.txt for Chromium
fast/forms/input-text-paste-maxlength.html is flaky on Linux Debug
See ​http://code.google.com/p/chromium/issues/detail?id=44150 for detail.

  • platform/chromium/test_expectations.txt:
8:49 PM Changeset in webkit [59439] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Update test_expectations.txt for Chromium.
fast/forms/implicit-submission.html is flaky on Linux.
See ​http://crbug.com/43890 for detail.

Patch by Takeshi Yoshino <​tyoshino@google.com> on 2010-05-13
Reviewed by Shinichiro Hamaji.

  • platform/chromium/test_expectations.txt:
7:25 PM Changeset in webkit [59438] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/ChangeLog

Update the bug number in the ChangeLog that I just committed.

7:10 PM Changeset in webkit [59437] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

7:09 PM Changeset in webkit [59436] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review.

[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
​https://bugs.webkit.org/show_bug.cgi?id=39101

  • platform/gtk/Skipped: Skip failing test.
7:09 PM Changeset in webkit [59435] by mrowe@apple.com
  • 1 copy in tags/Safari-533.9

New tag.

7:08 PM Changeset in webkit [59434] by bweinstein@apple.com
  • 5 edits in trunk/WebKit/win

<rdar://problem/7975410>

Reviewed by Tim Hatcher.

Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.

  • Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
  • Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
  • WebView.cpp:

(WebView::reportException): Make sure the function was called with a context from a WebView, and call

WebCore::reportException.

  • WebView.h:
7:08 PM Changeset in webkit [59433] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

6:52 PM Changeset in webkit [59432] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Merge r59418.

6:51 PM Changeset in webkit [59431] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59330.

6:51 PM Changeset in webkit [59430] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Merge r59387.

6:51 PM Changeset in webkit [59429] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59417.

6:06 PM Changeset in webkit [59428] by Martin Robinson
  • 2 edits
    56 adds in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Finish adding css1 baselines for GTK+.

  • platform/gtk/Skipped: Unskip tests which now have baselines.
  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/box_properties/width-expected.txt: Added.
  • platform/gtk/css1/cascade/cascade_order-expected.txt: Added.
  • platform/gtk/css1/cascade/important-expected.txt: Added.
  • platform/gtk/css1/classification/display-expected.txt: Added.
  • platform/gtk/css1/classification/list_style-expected.txt: Added.
  • platform/gtk/css1/classification/list_style_image-expected.txt: Added.
  • platform/gtk/css1/classification/list_style_position-expected.txt: Added.
  • platform/gtk/css1/classification/list_style_type-expected.txt: Added.
  • platform/gtk/css1/classification/white_space-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_color-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_image-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_position-expected.txt: Added.
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt: Added.
  • platform/gtk/css1/color_and_background/color-expected.txt: Added.
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt: Added.
  • platform/gtk/css1/font_properties/font-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_family-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_size-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_style-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_variant-expected.txt: Added.
  • platform/gtk/css1/font_properties/font_weight-expected.txt: Added.
  • platform/gtk/css1/formatting_model/canvas-expected.txt: Added.
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt: Added.
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt: Added.
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt: Added.
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt: Added.
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt: Added.
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt: Added.
  • platform/gtk/css1/pseudo/anchor-expected.txt: Added.
  • platform/gtk/css1/pseudo/firstletter-expected.txt: Added.
  • platform/gtk/css1/pseudo/firstline-expected.txt: Added.
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt: Added.
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt: Added.
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt: Added.
  • platform/gtk/css1/text_properties/line_height-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_align-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_decoration-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_indent-expected.txt: Added.
  • platform/gtk/css1/text_properties/text_transform-expected.txt: Added.
  • platform/gtk/css1/text_properties/vertical_align-expected.txt: Added.
  • platform/gtk/css1/text_properties/word_spacing-expected.txt: Added.
  • platform/gtk/css1/units/color_units-expected.txt: Added.
  • platform/gtk/css1/units/length_units-expected.txt: Added.
  • platform/gtk/css1/units/percentage_units-expected.txt: Added.
  • platform/gtk/css1/units/urls-expected.txt: Added.
6:03 PM Changeset in webkit [59427] by mrowe@apple.com
  • 13 edits in branches/safari-533-branch/WebCore

Merge r59281.

6:03 PM Changeset in webkit [59426] by mrowe@apple.com
  • 7 edits
    1 copy
    1 add in branches/safari-533-branch

Merge r59381.

6:03 PM Changeset in webkit [59425] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Merge r59372.

6:03 PM Changeset in webkit [59424] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r59391.

6:03 PM Changeset in webkit [59423] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59374.

6:02 PM Changeset in webkit [59422] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533-branch

Merge r59384.

6:02 PM Changeset in webkit [59421] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59351.

6:02 PM Changeset in webkit [59420] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59337.

5:04 PM Changeset in webkit [59419] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Correcting baseline.

  • platform/gtk/css1/basic/class_as_selector-expected.txt: Correct baseline.
5:01 PM Changeset in webkit [59418] by timothy@apple.com
  • 5 edits in trunk

WebCore: Expose WebCore::reportException and WebCore::toJSDOMWindow symbols.

Reviewed by Sam Weinig.

  • WebCore.base.exp: Expose reportException and toJSDOMWindow.

WebKit/mac: Allow reporting exceptions that occur when using JavaScriptCore APIs
to the Web Inspector.

<rdar://problem/7975410>

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(+[WebView _reportException:inContext:]): Call WebCore::reportException after checking
that the global object is a DOMWindow.

  • WebView/WebViewPrivate.h: Added _reportException:inContext:.
4:59 PM Changeset in webkit [59417] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-05-13 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Clearing Breakpoints Too Often
​https://bugs.webkit.org/show_bug.cgi?id=39094

Minor resets should preserve both workers and breakpoints.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
4:58 PM Changeset in webkit [59416] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with new exports.

  • symbian/eabi/QtWebKitu.def:
4:46 PM Changeset in webkit [59415] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59025.

4:46 PM Changeset in webkit [59414] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r58954.

4:46 PM Changeset in webkit [59413] by mrowe@apple.com
  • 13 edits
    4 adds in branches/safari-533-branch

Merge r59243.

4:46 PM Changeset in webkit [59412] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59210.

4:46 PM Changeset in webkit [59411] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch

Merge r59232.

4:46 PM Changeset in webkit [59410] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch/WebCore

Merge r59239.

4:46 PM Changeset in webkit [59409] by mrowe@apple.com
  • 6 edits in branches/safari-533-branch/WebCore

Merge r59189.

4:46 PM Changeset in webkit [59408] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59186.

4:45 PM Changeset in webkit [59407] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533-branch

Merge r59199.

4:45 PM Changeset in webkit [59406] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-533-branch/WebCore

Merge r59263.

4:45 PM Changeset in webkit [59405] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/ChangeLog

Merge r59242.

4:45 PM Changeset in webkit [59404] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533-branch

Merge r59241.

4:45 PM Changeset in webkit [59403] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59247.

4:45 PM Changeset in webkit [59402] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/JavaScriptCore

Merge r59202.

4:45 PM Changeset in webkit [59401] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch/JavaScriptCore

Merge r59196.

4:45 PM Changeset in webkit [59400] by mrowe@apple.com
  • 15 edits
    1 add in branches/safari-533-branch

Merge r59187.

4:44 PM Changeset in webkit [59399] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch

Merge r59336.

4:41 PM Changeset in webkit [59398] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review needed.

[GTK] Some test results are one pixel different on x86_64
​https://bugs.webkit.org/show_bug.cgi?id=39022

  • platform/gtk/Skipped: Skipping this test because of single-pixel difference.
4:22 PM Changeset in webkit [59397] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Platform specific expected file updated after r59385.

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

  • platform/qt/editing/deleting/5408255-expected.txt: updated.
4:14 PM Changeset in webkit [59396] by Simon Fraser
  • 14 edits
    1 copy
    2 adds in trunk

2010-05-13 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Fix scrolling in composited iframes
​https://bugs.webkit.org/show_bug.cgi?id=39088
<rdar://problem/7980099>

When propagating compositing out of iframes, we have to update the position of the iframe content
layers on scrolling.

Test: compositing/iframes/scrolling-iframe.html

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged): Call updateContentLayerScrollPosition() when scrolling.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Renamed setRootPlatformLayerClippingBox() to updateContentLayerOffset().
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: Rename m_clippingLayer to m_clipLayer to go better with m_scrollLayer. (WebCore::RenderLayerCompositor::updateContentLayerOffset): Renamed from setRootPlatformLayerClippingBox().

Set the size of the clipping layer from the FrameView now, so that scrollbars are not clipped out.
Update the scroll layer position too.

(WebCore::RenderLayerCompositor::updateContentLayerScrollPosition): Set the position of the scroll layer

when the ScrollView is scrolled.

(WebCore::RenderLayerCompositor::rootPlatformLayer): m_clippingLayer rename.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): m_clippingLayer rename. Also create m_scrollLayer at

the same time as the clip layer, and clean it up as necessary.

(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): m_clippingLayer rename, and clean up the m_scrollLayer too.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): m_clippingLayer rename

4:14 PM Changeset in webkit [59395] by Martin Robinson
  • 2 edits
    62 adds in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Adding baselines for many of the css1 tests. I've checked these manually.

  • platform/gtk/Skipped: Unskipping tests.
  • platform/gtk/css1/basic/class_as_selector-expected.txt: Added.
  • platform/gtk/css1/basic/comments-expected.txt: Added.
  • platform/gtk/css1/basic/containment-expected.txt: Added.
  • platform/gtk/css1/basic/contextual_selectors-expected.txt: Added.
  • platform/gtk/css1/basic/grouping-expected.txt: Added.
  • platform/gtk/css1/basic/id_as_selector-expected.txt: Added.
  • platform/gtk/css1/basic/inheritance-expected.txt: Added.
  • platform/gtk/css1/box_properties/acid_test-expected.txt: Added.
  • platform/gtk/css1/box_properties/border-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_color-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_color_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_left_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_right_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_style-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_style_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_top_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_width-expected.txt: Added.
  • platform/gtk/css1/box_properties/border_width_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/clear-expected.txt: Added.
  • platform/gtk/css1/box_properties/clear_float-expected.txt: Added.
  • platform/gtk/css1/box_properties/float-expected.txt: Added.
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt: Added.
  • platform/gtk/css1/box_properties/float_margin-expected.txt: Added.
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt: Added.
  • platform/gtk/css1/box_properties/height-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_left-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_left_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_right-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_right_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_top-expected.txt: Added.
  • platform/gtk/css1/box_properties/margin_top_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_bottom-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_left-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_left_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_right-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_right_inline-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_top-expected.txt: Added.
  • platform/gtk/css1/box_properties/padding_top_inline-expected.txt: Added.
3:56 PM Changeset in webkit [59394] by weinig@apple.com
  • 2 edits in trunk/WebCore

Follow up to:
Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>

Reviewed by Anders Carlsson.

Fix failing tests on Leopard.

Initialize m_hasCachedCSSText in CSSPrimitiveValue::init methods.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cssText): Add extra assertion.

3:45 PM Changeset in webkit [59393] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

No review. Rebaselining test after r59385.

  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Rebaseline
3:39 PM Changeset in webkit [59392] by beidson@apple.com
  • 3 edits in trunk/LayoutTests

Adding fast/loader/recursive-before-unload-crash-expected.html to the gtk skipped list
because it needs more logging in its DRT to pass:

  • platform/gtk/Skipped:

Adding fast/loader/recursive-before-unload-crash-expected.html to the qt skipped list
because it's hanging:

  • platform/qt/Skipped:
3:39 PM Changeset in webkit [59391] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=39089
<rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode

Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
investigate a more extensible solution when there are more, and we know what the
typical restictions are.

  • Misc/WebNSURLExtras.mm: (allCharactersAllowedByTLDRules): (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
3:33 PM Changeset in webkit [59390] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-13 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Can't submit a form with <input type=checkbox required>
​https://bugs.webkit.org/show_bug.cgi?id=39065

  • fast/forms/interactive-validation-required-checkbox-expected.txt: Added.
  • fast/forms/interactive-validation-required-checkbox.html: Added.

2010-05-13 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Can't submit a form with <input type=checkbox required>
​https://bugs.webkit.org/show_bug.cgi?id=39065

Test: fast/forms/interactive-validation-required-checkbox.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): Update the validity cache when a checkbox state is changed.
3:12 PM Changeset in webkit [59389] by beidson@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by NOBODY (Layout test fix)

Add Tiger specific results for my new test.

  • platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Copied from fast/loader/recursive-before-unload-crash-expected.txt.
3:07 PM Changeset in webkit [59388] by kbr@google.com
  • 12 edits in trunk

2010-05-13 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.

Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::ArrayBufferAccessorGetter): (WebCore::V8DOMWindow::Int8ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter): (WebCore::V8DOMWindow::Int16ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter): (WebCore::V8DOMWindow::Int32ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter): (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
  • page/DOMWindow.idl:

2010-05-13 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all layout tests (including WebGL) in Safari, and WebGL tests in
Chromium.

Test: revised array-unit-tests.html to test both type names.
Revised global prototype and constructor tests to ignore new types.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/js/script-tests/global-constructors.js:
2:51 PM Changeset in webkit [59387] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39084

Reviewed by Anders Carlsson.

Improve :visited style resolution to reduce its memory footprint and to make some speed adjustments and
simplifications.

(1) Tie the caching of link state on CSSStyleSelector to the element. Just clear out the element when
style resolution finishes for the unvisited case to avoid caching across external calls. The internal
calls share the cache just fine by doing this.

(2) Delete the RenderStyle if the link is unvisited. This shouldn't take long enough to make us vulnerable
to timing attacks, and it makes sure the overall footprint stays the way it used to be for unvisited links.

(3) Limit the set of properties that can be applied to :visited links to only the colors it supports. This
stops images from being loadable from :visited rules.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::init):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::isValidVisitedLinkProperty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::colorIncludingFallback):

2:32 PM Changeset in webkit [59386] by weinig@apple.com
  • 4 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>

Reviewed by Darin Adler.

  • Use an external cache to speedup cssText for CSSPrimitiveValue instead of an extra member variable.
  • css/CSSPrimitiveValue.cpp:

(WebCore::cssTextCache):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

1:48 PM Changeset in webkit [59385] by enrica@apple.com
  • 8 edits
    2 adds in trunk

Adding block elements to a block and removing them changes the height of the element.
​https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): resetting m_childrenInline flag to true when layout a block with no children.

LayoutTests:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

  • editing/deleting/delete-block-contents-004-expected.txt: Added.
  • editing/deleting/delete-block-contents-004.html: Added.

The following tests results have been updated to reflect the new renderer structure.

  • editing/deleting/in-visibly-empty-root-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
1:31 PM Changeset in webkit [59384] by beidson@apple.com
  • 6 edits
    2 adds in trunk

Repro crash at www.sears.com (infinite recursion in beforeunload handler)
<rdar://problem/7965182> and ​https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/recursive-before-unload-crash.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldClose): Copied from Frame, with the pageDismissal flag set.

  • loader/FrameLoader.h:
  • page/Frame.cpp:

(WebCore::Frame::shouldClose): Forward to the new FrameLoader::shouldClose().

  • page/Frame.h:

(WebCore::Frame::existingDOMWindow):

LayoutTests:

  • fast/loader/recursive-before-unload-crash-expected.txt: Added.
  • fast/loader/recursive-before-unload-crash.html: Added.
1:06 PM Changeset in webkit [59383] by eric@webkit.org
  • 8 edits in trunk

2010-05-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59376.
​http://trac.webkit.org/changeset/59376
​https://bugs.webkit.org/show_bug.cgi?id=39080

Broke window prototype tests (Requested by jamesr on #webkit).

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-05-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r59376.
​http://trac.webkit.org/changeset/59376
​https://bugs.webkit.org/show_bug.cgi?id=39080

Broke window prototype tests (Requested by jamesr on #webkit).

  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webGLFloatArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • page/DOMWindow.idl:
12:35 PM Changeset in webkit [59382] by diegohcg@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-13 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve QtLauncher user agent dialog resize
​https://bugs.webkit.org/show_bug.cgi?id=39062

  • QtLauncher/main.cpp: (LauncherWindow::showUserAgentDialog):
12:24 PM Changeset in webkit [59381] by pfeldman@chromium.org
  • 7 edits
    1 copy
    1 add in trunk

2010-05-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: A disabled style property cannot be deleted.

​https://bugs.webkit.org/show_bug.cgi?id=39057

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText):

2010-05-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: A disabled style property cannot be deleted.

​https://bugs.webkit.org/show_bug.cgi?id=39057

  • inspector/elements-tests.js: (frontend_getSelectedElementStyles):
  • inspector/styles-disable-then-delete-expected.txt: Added.
  • inspector/styles-disable-then-delete.html: Added.
  • inspector/styles-disable-then-enable.html:
12:15 PM Changeset in webkit [59380] by diegohcg@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-11 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebPage::inputMethods failing on Maemo5
​https://bugs.webkit.org/show_bug.cgi?id=38685

Check if the SIP (Software Input Panel) is triggered, which usually happens
in the case of a mobile platforms, an user input form receives a mouse click.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
12:08 PM Changeset in webkit [59379] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

Fix yet another typo in my original hack.
I also added another unit test for this fix.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
11:59 AM Changeset in webkit [59378] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing
​https://bugs.webkit.org/show_bug.cgi?id=38655

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-05-11
Reviewed by Laszlo Gombos.

Fix double free by moving the connect till after the resize.

The bug is causes by the fact that a resize of an empty page causes a
layout, thus deleting the qgraphicswebview before setHtml is called,
which then deletes it again, causing a double free.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::crashOnViewlessWebPages):

11:54 AM Changeset in webkit [59377] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Regression(r59152): QGraphicsPageClient is not forwarding scroll and update events to view ​https://bugs.webkit.org/show_bug.cgi?id=39016

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-05-12
Reviewed by Laszlo Gombos.

Some forward calls got lost during the refatory.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::scroll):
(WebCore::PageClientQGraphicsWidget::update):

11:51 AM Changeset in webkit [59376] by kbr@google.com
  • 8 edits in trunk

2010-05-12 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.

Test: revised array-unit-tests.html to test both type names.

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled): (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled): (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::ArrayBufferAccessorGetter): (WebCore::V8DOMWindow::Int8ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter): (WebCore::V8DOMWindow::Int16ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter): (WebCore::V8DOMWindow::Int32ArrayAccessorGetter): (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter): (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
  • page/DOMWindow.idl:

2010-05-12 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Alias WebGLArray type names to TypedArray type names
​https://bugs.webkit.org/show_bug.cgi?id=39036

Exposed the existing WebGL<T>Array constructor functions on the
DOMWindow under the naming convention in the TypedArray spec. The
implementations will be renamed in a subsequent bug, and the
aliases to the WebGL<T>Array type names eventually removed. Ran
all WebGL layout tests in Safari and Chromium.

Test: revised array-unit-tests.html to test both type names.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
11:44 AM BuildingQtOnLinux edited by ikipou@gmail.com
Update the minimal verison of Qt required to compile WebKit (diff)
11:33 AM Changeset in webkit [59375] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

My previous (unreviewed) hack didn't actually work due to checking "mac" instead of "Mac".
This change fixes my hack, and unit tests it.

  • Scripts/webkitpy/tool/mocktool.py:
    • Make it possible to make run_command log too.
  • Scripts/webkitpy/tool/steps/runtests.py:
    • Fix my hack to actually work.
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Test my hack (and basic RunTests behavior as well).
11:17 AM Changeset in webkit [59374] by beidson@apple.com
  • 3 edits in trunk/WebCore

Part of <rdar://problem/7965182> and ​https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by John Sullivan.

No new tests. (No change in behavior)

m_unloadEventBeingDispatched was already overloaded to include both unload and pagehide events.
In general, these are "page dismissal" events, and might also include beforeunload, so let's rename
the flag!

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::pageHidden):

  • loader/FrameLoader.h:
10:59 AM Changeset in webkit [59373] by tonikitoo@webkit.org
  • 8 edits in trunk

2010-05-13 Antonio Gomes <​tonikitoo@webkit.org>, Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Kenneth Christiansen.

[Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
​https://bugs.webkit.org/show_bug.cgi?id=37759

WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::markerTextForListItem): (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

WebKitTools:

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::computedStyleIncludingVisitedInfo):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

  • platform/qt/Skipped:
10:57 AM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
10:55 AM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
10:27 AM Changeset in webkit [59372] by Joseph Pecoraro
  • 4 edits in trunk/WebCore

2010-05-13 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Event Markers should be hidden in Resource's "Size" Graph
​https://bugs.webkit.org/show_bug.cgi?id=39074

Added Show / Hide event dividers functionality to the timeline grid,
and included delegation functions in AbstractTimelinePanel.

  • inspector/front-end/AbstractTimelinePanel.js: delegate to the inner grid (WebInspector.AbstractTimelinePanel.prototype.hideEventDividers): (WebInspector.AbstractTimelinePanel.prototype.showEventDividers):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): save a reference to the size graph item to know when its selected (WebInspector.ResourcesPanel.prototype._graphSelected): if the size graph is selected hide the dividers, otherwise show them
  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.hideEventDividers): set the container to display: none (WebInspector.TimelineGrid.prototype.showEventDividers): set the container to display: block
10:08 AM Changeset in webkit [59371] by Adam Roben
  • 5 edits in trunk/WebKitTools

Convert status bar text to UTF-8 before logging it on Windows

We were previously logging the text using printf("%S", bstr). This
converts the UTF-16 BSTR to a multibyte string using wctomb, which
uses the codepage for the current locale to perform the conversion.
The conversion was failing, causing printf to bail and truncate the
string. By converting to UTF-8 manually before logging, we avoid this
issue (and also end up with UTF-8 output, which is what the expected
results contain). We may have to do this in other places in DRT,
eventually.

Fixes <​http://webkit.org/b/38849> REGRESSION (r59016):
plugins/set-status.html fails on Windows

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(toUTF8): Moved this here from FrameLoadDelegate. Renamed from
BSTRtoString.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of toUTF8.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: Removed BSTRtoString.

(descriptionSuitableForTestResult): Updated for rename.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::setStatusText): Convert the status bar text to UTF-8
before logging it so that Windows won't try (and fail) to convert it
to the current locale's codepage.

10:07 AM Changeset in webkit [59370] by Adam Roben
  • 2 edits in trunk/SunSpider

Fix typo in sunspider-compare-results.js that caused incorrect two-sample t statistics to be computed

Fixes <​http://webkit.org/b/38768> SunSpider computes incorrect
two-sample t statistics

Reviewed by Darin Adler.

  • resources/sunspider-compare-results.js:

(sunspiderCompareResults.resultLine): Fixed the calculation of the t
variable to match the definition of a two-sample t statistic. Looks
like this was just a simple typo.

8:35 AM Changeset in webkit [59369] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Events tests failing
​https://bugs.webkit.org/show_bug.cgi?id=31436

Unskip these two test which are now passing.

  • platform/gtk/Skipped: Unskip two tests.
8:34 AM Changeset in webkit [59368] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: main inspector toolbar takes noticeable time to expand.

​https://bugs.webkit.org/show_bug.cgi?id=39013

  • src/js/DevTools.js: (devtools.domContentLoaded):
8:21 AM Changeset in webkit [59367] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Two forms tests failing
​https://bugs.webkit.org/show_bug.cgi?id=31435

Unskip passing tests.

  • platform/gtk/Skipped: Unskip these tests, because they are passing now.
7:56 AM Changeset in webkit [59366] by chang.shu@nokia.com
  • 2 edits in trunk/WebCore

2010-05-13 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on the spec and Philip Taylor's test suite, strokeStyle and fillStyle attributes
must initially have the string value #000000.
The link to the spec:
​http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.colours.default

​https://bugs.webkit.org/show_bug.cgi?id=39068

The complete test suite is in the process of checking in.
​https://bugs.webkit.org/show_bug.cgi?id=20553

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State):
7:41 AM Changeset in webkit [59365] by yurys@chromium.org
  • 17 edits
    3 deletes in trunk/WebCore

2010-05-13 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, rolling out r59360.
​http://trac.webkit.org/changeset/59360
​https://bugs.webkit.org/show_bug.cgi?id=38667

It broke Chromium Win build

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._keyDown):
  • inspector/front-end/HelpScreen.js: Removed.
  • inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut._makeKeyFromCodeAndModifiers):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/ShortcutsHelp.js: Removed.
  • inspector/front-end/SidebarPane.js: (WebInspector.SidebarPane.prototype._onTitleKeyDown):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.removeSection):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleKeyDown):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css: Removed.
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector._searchKeyDown): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
  • inspector/front-end/utilities.js:
7:39 AM Changeset in webkit [59364] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-13 Eric Seidel <​eric@webkit.org>

Unreviewed hack, attempting to get the commit-queue running again.

Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
​https://bugs.webkit.org/show_bug.cgi?id=39067

I had this hack locally on the commit-queue, but it's fragile
and broke this morning. It will work much better if committed
to the repository. In either case it's temporary while we
work up a real fix for bug 38912.

  • Scripts/webkitpy/common/config/ports.py:
    • Expose an is_leopard() method.
  • Scripts/webkitpy/tool/steps/runtests.py:
    • Don't run compositing/iframes tests on the commit-queue under leopard.
7:35 AM Changeset in webkit [59363] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=39063
[Qt] Tiled backing store checker pattern does not paint correctly when scaling factor is not 1

Reviewed by Kenneth Rohde Christiansen.

Use the dirty rect that has been adjusted for scaling instead of the original one.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::paint):

7:07 AM Changeset in webkit [59362] by chang.shu@nokia.com
  • 2 edits in trunk/WebCore

2010-05-13 Chang Shu <​chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on Philip Taylor's test suite, resetting the canvas
state resets the current path.
​https://bugs.webkit.org/show_bug.cgi?id=38934

The complete test suite is in the process of checking in.
​https://bugs.webkit.org/show_bug.cgi?id=20553

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset):
6:48 AM Changeset in webkit [59361] by yurys@chromium.org
  • 8 edits
    1 delete in trunk/LayoutTests

2010-05-13 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Chromium build fix. Partially rever r59277 which updated Chromium's expectations
after r59270. r59270 was reverted, so we need to revert Chromium's expectations.

  • platform/chromium-linux/editing/deleting/5408255-expected.checksum:
  • platform/chromium-mac/editing/deleting/5408255-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/5408255-expected.checksum:
  • platform/chromium-win/editing/deleting/5408255-expected.txt:
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/4895428-1-expected.txt:
  • platform/chromium-win/editing/selection/4895428-4-expected.txt:
  • platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:
6:42 AM Changeset in webkit [59360] by pfeldman@chromium.org
  • 17 edits
    3 adds in trunk/WebCore

2010-05-13 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Added help screen with keyboard shortcuts.
​https://bugs.webkit.org/show_bug.cgi?id=38667

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._registerShortcuts):
  • inspector/front-end/HelpScreen.js: Added.
  • inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.makeDescriptor): (WebInspector.KeyboardShortcut.shortcutToString): (WebInspector.KeyboardShortcut._modifiersToString):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.ScriptsPanel.prototype._registerShortcuts):
  • inspector/front-end/ShortcutsHelp.js: Added.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.removeSection): (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/helpScreen.css: Added.
5:12 AM Changeset in webkit [59359] by hamaji@chromium.org
  • 2 edits in trunk

2010-05-13 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Shinichiro Hamaji.

Update test_expectations.txt for Chromium.
fast/forms/implicit-submission.html is flaky on Linux.
See ​http://crbug.com/43890 for detail.

  • platform/chromium/test_expectations.txt:
5:05 AM Changeset in webkit [59358] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

No review, attempted build fix.

Try to fix Tiger build with some gratuitous initialization of
seemingly uninitialized variables.

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::tryCreateUninitialized):

2:43 AM Changeset in webkit [59357] by hamaji@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-13 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Darin Adler.

Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
​https://bugs.webkit.org/show_bug.cgi?id=25047

  • fast/css/run-in-children-expected.txt: Added.
  • fast/css/run-in-children.html: Added.

2010-05-13 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Darin Adler.

Fix a bug in handleRunInChild where only the first child run-in block
is inserted because removeChildNode clears next sibling.
​https://bugs.webkit.org/show_bug.cgi?id=25047

Test: fast/css/run-in-children.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
2:37 AM Changeset in webkit [59356] by alex
  • 2 edits in trunk/WebCore

2010-05-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

In case there is no expose event we render the theme in a pixmap
and copy it to the cairo context. This is slow but it is used just
in case we are printing nowadays.

[GTK] Theme does not render when printing
​https://bugs.webkit.org/show_bug.cgi?id=38896

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget):
2:36 AM Changeset in webkit [59355] by mjs@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-05-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.

Various JavaScript string optimizations
​https://bugs.webkit.org/show_bug.cgi?id=39051

Approximately 1% SunSpider speedup.


  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin): Remove branches from the hot code path by moving the first pass outside the loop, and duplicating the hot loop to extract the loop-invariant branch.
  • runtime/RegExp.cpp: (JSC::RegExp::match): resize ovector to 0 instead of clearing to avoid thrash in case of large matches.
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::performMatch): Mark ALWAYS_INLINE to make the compiler respect our authority.
  • runtime/StringPrototype.cpp: (JSC::jsSpliceSubstringsWithSeparators): Inline. (JSC::stringProtoFuncSubstring): Rewrite boundary condition checks to reduce the number of floating point comparisons and branches.
1:52 AM Changeset in webkit [59354] by ukai@chromium.org
  • 3 edits in trunk

WebKitTools: Unreviewed fix. Revert previous change.

Even if with-statments are changed in websocket_server.py, it also claims syntax error for with statement in http_server.py.
Until python 2.5 is installed on tiger bot, skips websocket/tests on tiger.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: use with statement

LayoutTests: Unreviewed.

Skip websocket/tests on tiger, until Python 2.5 is installed on tiger bot.

  • platform/mac-tiger/Skipped: Add websocket/tests
1:52 AM Changeset in webkit [59353] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

WebSocket: pywebsocket 0.5
​https://bugs.webkit.org/show_bug.cgi?id=38034

Reviewed by David Levin.

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

  • Scripts/new-run-webkit-websocketserver: Add --output-dir option.
  • Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
  • Scripts/run-webkit-websocketserver: Ditto.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
  • Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
  • Scripts/webkitpy/thirdparty/pywebsocket: Removed.
1:21 AM Changeset in webkit [59352] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed fix.

On tiger bot, it claims syntax error for with statement.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: rewrite with statement with try-finally.
12:32 AM Changeset in webkit [59351] by yuzo@google.com
  • 3 edits
    2 adds in trunk

2010-05-12 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Fix Bug 35014 - Modifying UA rules from page JS crashes
​https://bugs.webkit.org/show_bug.cgi?id=35014

  • fast/css/modify-ua-rules-from-javascript-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
  • fast/css/modify-ua-rules-from-javascript.html: Added.

2010-05-12 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Fix Bug 35014 - Modifying UA rules from page JS crashes
Added a NULL check.
​https://bugs.webkit.org/show_bug.cgi?id=35014

Test: fast/css/modify-ua-rules-from-javascript.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
12:28 AM Changeset in webkit [59350] by ukai@chromium.org
  • 6 edits
    35 deletes in trunk/WebKitTools

2010-05-13 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by David Levin.

WebSocket: pywebsocket 0.5
​https://bugs.webkit.org/show_bug.cgi?id=38034

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

  • Scripts/new-run-webkit-websocketserver: Add --output-dir option.
  • Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
  • Scripts/run-webkit-websocketserver: Ditto.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
  • Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
  • Scripts/webkitpy/thirdparty/pywebsocket: Removed.
Note: See TracTimeline for information about the timeline view.