Timeline



Dec 1, 2010:

11:01 PM Changeset in webkit [73111] by dbates@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-12-01 Daniel Bates <​dbates@rim.com>

Remove file LayoutTests/platform/gtk/Skipped.rej which was
inadvertently committed in changeset 72675 <​http://trac.webkit.org/changeset/72675>.

  • platform/gtk/Skipped.rej: Removed.
10:15 PM Changeset in webkit [73110] by jianli@chromium.org
  • 6 edits
    3 copies in branches/chromium/597

Merge 72866 - Add send(ArrayBuffer) to XMLHttpRequest per XMLHttpRequest Level 2 spec
​https://bugs.webkit.org/show_bug.cgi?id=50199

Reviewed by David Levin.

WebCore:

Test: http/tests/xmlhttprequest/send-array-buffer.html

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

  • xml/XMLHttpRequest.h:

LayoutTests:

  • http/tests/xmlhttprequest/resources/post-echo-as-ascii.cgi: Added.
  • http/tests/xmlhttprequest/send-array-buffer-expected.txt: Added.
  • http/tests/xmlhttprequest/send-array-buffer.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

BUG=65046
TEST=Layout test
TBR=​jianli@chromium.org
Review URL: ​http://codereview.chromium.org/5569001

8:38 PM Changeset in webkit [73109] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the GTK build.

  • GNUmakefile.am: Use a full path to OSAllocator*.cpp.
8:28 PM Changeset in webkit [73108] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the EFL Linux build.

  • CMakeListsEfl.txt: Added OSAllocator to the project.
8:27 PM Changeset in webkit [73107] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Eric Seidel <​eric@webkit.org>

Unreviewed.

compositing/iframes/overlapped-nested-iframes.html is ridiculously flaky
​https://bugs.webkit.org/show_bug.cgi?id=50255

Skipping it to stop the madness.

  • platform/mac-snowleopard/Skipped:
8:04 PM Changeset in webkit [73106] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

Try to fix the Qt build: Include all OS files for Qt's sake, and then
use #ifdefs in the files to exclude things based on OS.

This is a pretty bad way to manage platforms -- hopefully we can
fix the Qt build system and move away from this in the future.

  • wtf/OSAllocatorPosix.cpp:
  • wtf/OSAllocatorSymbian.cpp:
  • wtf/OSAllocatorWin.cpp:
  • wtf/wtf.pri:
7:50 PM Changeset in webkit [73105] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the Chromium build.

  • JavaScriptCore.gypi: This is a Windows build file, so use OSAllocatorWin.cpp.
7:39 PM Changeset in webkit [73104] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the GTK build.

  • GNUmakefile.am: Added OSAllocator to another project.
7:31 PM Changeset in webkit [73103] by victorw@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-12-01 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium image test expectations.

  • platform/chromium-mac/platform/mac/editing: Added.
  • platform/chromium-mac/platform/mac/editing/spelling: Added.
  • platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
  • platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.
  • platform/chromium-win/platform/mac/editing/spelling: Added.
  • platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
  • platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.
7:23 PM Changeset in webkit [73102] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the GTK Linux build.

7:18 PM Changeset in webkit [73101] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the Qt Linux build.

  • wtf/OSAllocatorPosix.cpp: Use the right errno.h.
7:04 PM Changeset in webkit [73100] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Removing out of date expectation.

  • platform/chromium/test_expectations.txt:
7:01 PM Changeset in webkit [73099] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix Windows build: export some more symbols.

6:56 PM Changeset in webkit [73098] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix 64-bit build.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::windowAndViewFramesChanged):

6:52 PM Changeset in webkit [73097] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the Qt Linux build.

  • wtf/wtf.pri: Use the POSIX OSAllocator for Qt Linux.
6:42 PM Changeset in webkit [73096] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: commit doesn't have a return value.

  • wtf/OSAllocatorWin.cpp:

(WTF::OSAllocator::commit):

6:36 PM Changeset in webkit [73095] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix: Export some symbols.

6:34 PM Changeset in webkit [73094] by ggaren@apple.com
  • 2 edits
    2 adds in trunk

Build fix: Added a forwarding header.

JavaScriptGlue:

  • ForwardingHeaders/wtf/OSAllocator.h: Added.

WebCore:

  • ForwardingHeaders/wtf/OSAllocator.h: Added.
6:27 PM Changeset in webkit [73093] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Moving test expecation upstream.

  • platform/chromium/test_expectations.txt:
6:22 PM Changeset in webkit [73092] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix.

  • JavaScriptCore.xcodeproj/project.pbxproj: Export OSAllocator.h as private

so other projects can see it.

  • wtf/OSAllocatorPosix.cpp: #include UnusedParam.h for UNUSED_PARAM.
6:13 PM Changeset in webkit [73091] by ggaren@apple.com
  • 9 edits
    4 adds
    1 delete in trunk/JavaScriptCore

Baby step toward a cross-platform virtual memory abstraction: created
an all-static OSAllocator class and changed MarkStack to use it.

Reviewed by Sam Weinig.

  • JavaScriptCore.xcodeproj/project.pbxproj: Added OSAllocatorPosix.cpp.
  • runtime/MarkStack.h:

(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack): Use OSAllocator instead of rolling our
own platform-specific code.

  • runtime/MarkStackNone.cpp: Removed. Nothing used this.
  • runtime/MarkStackPosix.cpp:
  • runtime/MarkStackSymbian.cpp:
  • runtime/MarkStackWin.cpp: Removed custom platform-specific code, since

we use the OSAllocator abstraction now.

  • wtf/OSAllocator.h: Added.
  • wtf/OSAllocatorPosix.cpp: Added.

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release):

  • wtf/OSAllocatorSymbian.cpp: Added.

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release):

  • wtf/OSAllocatorWin.cpp: Added.

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release): The new OSAllocator abstraction.

  • wtf/wtf.pri: Added OSAllocatorSymbian.cpp.
5:55 PM Changeset in webkit [73090] by andersca@apple.com
  • 17 edits in trunk/WebKit2

Give the fake Carbon window the right bounds
​https://bugs.webkit.org/show_bug.cgi?id=50361

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::windowAndViewFramesChanged):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):
Pass both the window frame and view frame along.

(-[WKView renewGState]):
Call _updateWindowAndViewFrames.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::windowAndViewFramesChanged):
Pass both the window frame and view frame along.

  • UIProcess/WebPageProxy.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPostInitialize):
We don't want a title bar in our fake window.

(WebKit::computeFakeWindowBoundsRect):
Compute the fake window bounds.

(WebKit::NetscapePlugin::windowAndViewFramesChanged):
Update the fake window bounds.

  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::windowAndViewFramesChanged):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::windowAndViewFramesChanged):
(WebKit::PluginView::initializePlugin):

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndViewFramesChanged):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::windowFrameInScreenCoordinates):
(WebKit::WebPage::viewFrameInWindowCoordinates):

  • WebProcess/WebPage/WebPage.messages.in:

Pass both the window frame and view frame along.

5:50 PM Changeset in webkit [73089] by thakis@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-12-01 Nico Weber <​thakis@chromium.org>

More baselines after ​http://trac.webkit.org/changeset/72689
​https://bugs.webkit.org/show_bug.cgi?id=50040

The rebaseline script didn't find these, because they're only wrong
in platform/mac-leopard. I use Snow Leopard, so the script didn't look
there. The bots on the other hand use Leopard, so they complain. I
manually copied the expectations from platfrom/mac to
platform/chromium-mac. Explanation by jamesr.

  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum: Added.
5:19 PM Changeset in webkit [73088] by Darin Adler
  • 45 edits
    4 adds in trunk

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::getGuessesForWord):
  • src/EditorClientImpl.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::getGuessesForWord):
  • WebCoreSupport/EditorClientQt.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::getGuessesForWord):
  • WebCoreSupport/EditorClientGtk.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::getGuessesForWord):
  • WebCoreSupport/WebEditorClient.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::getGuessesForWord):
  • WebKitSupport/EditorClientWx.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

This patch is for supporting multiple correction suggestion panel on Mac OS X.
The behavior and implementation is similar to that of reversion candiate panel.

  • WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
  • WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class. Added code to handle new multiple suggestion canidate panel type. (WebEditorClient::showCorrectionPanel): (WebEditorClient::getGuessesForWord):

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::getGuessesForWord):
  • WebCoreSupport/EditorClientHaiku.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::getGuessesForWord):
  • WebCoreSupport/EditorClientWinCE.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signature defined in base class.

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::getGuessesForWord):
  • WebCoreSupport/EditorClientEfl.h:

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Test: platform/mac/editing/spelling/delete-autocorrected-word-1.html
Manual test: WebCore/manual-tests/autocorrection/dismiss-multiple-guesses.html

WebCore/manual-tests/autocorrection/select-from-multiple-guesses.html

This patch is for supporting multiple correction suggestion panel on Mac OS X.
The behavior and implementation is similar to that of reversion candiate panel.

  • WebCore.exp.in: Added and removed symbols.
  • editing/CorrectionPanelInfo.h: Added new correction panel type, PanelTypeSpellingSuggestions.
  • editing/Editor.cpp: (WebCore::markerTypesForAutocorrection): Convenient function for getting marker types to be added to autocorrected word. (WebCore::boundingBoxForRange): Convenient function for calculating the bounding box of a range. (WebCore::markerTypesForReplacement): Convenient function for getting marker types to be added to word that has been replaced by various correction panel. (WebCore::Editor::respondToChangedSelection): Added code to trigger timer for multiple suggestion panel. (WebCore::Editor::guessesForMisspelledSelection): Adopted new signature of EditorClient::getGuessesForWord(). (WebCore::Editor::markMisspellingsAfterTypingToWord): Adopted new signature of applyCorrectionPanelInfo(). (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto. (WebCore::Editor::correctionPanelTimerFired): Added code to handle new multiple suggestion panel. (WebCore::Editor::handleCorrectionPanelResult): Replaced handleRejectedCorrection(), since with new AppKit correction panel API, not only rejection, but also confirmation can be handled in callback. (WebCore::Editor::stopCorrectionPanelTimer): Moved the code that clears correction panel info from dismissCorrectionPanel() to this function to fix a bug that would occur when deleting autocorrected word. (WebCore::Editor::dismissCorrectionPanel): Ditto. (WebCore::Editor::applyCorrectionPanelInfo): Added code to handle new multiple suggestion panel.
  • editing/Editor.h: Replaced handleRejectedCorrection() with handleCorrectionPanelResult(). Changed the signature of applyCorrectionPanelInfo() to hanlde new correction panel type.
  • editing/TextCheckingHelper.cpp: (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Adopted new EditorClient::getGuessesForWord().
  • editing/TextCheckingHelper.h: Made paragraphRange() public.
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature defined in base class. (WebCore::EmptyEditorClient::getGuessesForWord): Ditto.
  • manual-tests/autocorrection/dismiss-multiple-guesses.html: Added.
  • manual-tests/autocorrection/select-from-multiple-guesses.html: Added.
  • page/EditorClient.h: Changed showCorrectionPanel() to allow passing multiple correction candidates. Changed getGuessesForWord() to allow passing in contextual text for better correction suggestions (for those spellcheckers that utilizes such contextual information).

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt: Added.
  • platform/mac/editing/spelling/delete-autocorrected-word-1.html: Added.

2010-12-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Support multiple correction candidates panel for misspelled word on Mac OS X.
​https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>

Adopted new function signatures defined in base class.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::getGuessesForWord):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::showCorrectionPanel):
4:56 PM Changeset in webkit [73087] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=50360

Reviewed by James Robinson.

Make sure to include the origin adjustment code that I added on Mac to keep truncation-rtl.html passing.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

4:23 PM Changeset in webkit [73086] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Land Windows specific results for /vertical-scrollbar-in-rtl.html
after r73063.

  • platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
4:21 PM Changeset in webkit [73085] by rniwa@webkit.org
  • 4 edits
    4 copies in branches/chromium/597

Merge 73052 - 2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea)
​https://bugs.webkit.org/show_bug.cgi?id=47808

The crash was caused by moveParagraphWithClones' not copying the entire paragraph
when called by doApplyForSingleParagraph, which was induced by a bug in
cloneParagraphUnderNewElement which ended the cloning process early when the start node
and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement
by calling traverseNextSibling(outerNode) instead of nextSibling().

Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null.

Tests: editing/execCommand/switch-multiple-list-items-crash.html

editing/execCommand/switch-multiple-list-items.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):

2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea)
​https://bugs.webkit.org/show_bug.cgi?id=47808

Added tests to ensure WebKit can switch the type of multiple list items without a crash.

  • editing/execCommand/switch-multiple-list-items-crash-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items-crash.html: Added.
  • editing/execCommand/switch-multiple-list-items-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items.html: Added.

TBR=​rniwa@webkit.org
BUG=59557
Review URL: ​http://codereview.chromium.org/5536001

4:14 PM Changeset in webkit [73084] by Simon Fraser
  • 2 edits in trunk/WebKit2

2010-12-01 Simon Fraser <Simon Fraser>

Reviewed by John Sullivan.

Hit testing broken on sibling views of the WKView
<rdar://problem/8718397>

Make sure that hitView is not null when comparing with the
_layerHostingView.

  • UIProcess/API/mac/WKView.mm: (-[WKView hitTest:]):
4:06 PM Changeset in webkit [73083] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Implement the remaining PluginController/Plugin member functions
​https://bugs.webkit.org/show_bug.cgi?id=50356

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::cancelStreamLoad):
(WebKit::PluginControllerProxy::cancelManualStreamLoad):
(WebKit::PluginControllerProxy::setStatusbarText):
(WebKit::PluginControllerProxy::pluginProcessCrashed):
(WebKit::PluginControllerProxy::frameDidFinishLoading):
(WebKit::PluginControllerProxy::frameDidFail):
(WebKit::PluginControllerProxy::manualStreamDidReceiveResponse):
(WebKit::PluginControllerProxy::manualStreamDidReceiveData):
(WebKit::PluginControllerProxy::manualStreamDidFinishLoading):
(WebKit::PluginControllerProxy::manualStreamDidFail):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::frameDidFinishLoading):
(WebKit::PluginProxy::frameDidFail):
(WebKit::PluginProxy::manualStreamDidReceiveResponse):
(WebKit::PluginProxy::manualStreamDidReceiveData):
(WebKit::PluginProxy::manualStreamDidFinishLoading):
(WebKit::PluginProxy::manualStreamDidFail):
(WebKit::PluginProxy::windowFrameChanged):
(WebKit::PluginProxy::cancelStreamLoad):
(WebKit::PluginProxy::cancelManualStreamLoad):
(WebKit::PluginProxy::setStatusbarText):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
4:03 PM Changeset in webkit [73082] by mihaip@chromium.org
  • 4 edits in trunk/WebKitTools

2010-12-01 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

build-webkit --chromium always updates DEPS and re-generates project files
​https://bugs.webkit.org/show_bug.cgi?id=50340

Make build-webkit --chromium invoke update-webkit-chromium only when
--update-chromium is passed in, so that we don't add 20 seconds to all
builds.

Making all invocations update was added with r61883, with the goal of
making EWS bots always update. The bots will switch to using this flag
(as will all other webkit-patch build steps) so nothing should change
for them.

  • Scripts/webkitdirs.pm:
  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
4:02 PM Changeset in webkit [73081] by hyatt@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46645

Reviewed by Dan Bernstein.

Generalize overflow section scrollOriginX code to be a point and to work in both horizontal
and vertical modes.

Not testable yet, since the rightmost/leftmost/topmost/lowestPosition functions are returning
horrendously wrong values in the vertical text case for overflow:auto objects.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateOverflowStatus):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::scrolledContentOffset):
(WebCore::RenderLayer::scrollXOffset):
(WebCore::RenderLayer::scrollYOffset):
(WebCore::RenderLayer::scrollToXOffset):
(WebCore::RenderLayer::scrollToYOffset):

3:59 PM Changeset in webkit [73080] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-12-01 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a --dry-run / -n flag
​https://bugs.webkit.org/show_bug.cgi?id=50045

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3:58 PM Changeset in webkit [73079] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-12-01 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by James Robinson.

[chromium] renderer does not realize hardware compositing is disabled and crashes
​https://bugs.webkit.org/show_bug.cgi?id=50264

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setRootGraphicsLayer): repaint always (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): null check (WebKit::WebViewImpl::reallocateRenderer):
3:55 PM Changeset in webkit [73078] by sfalken@apple.com
  • 28 edits in trunk

WinCairo build should not use link-time code generation (LTCG)
​https://bugs.webkit.org/show_bug.cgi?id=50353

Reviewed by Adam Roben.

JavaScriptCore:

WebCore:

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:

WebKit/win:

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKit2:

  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • FindSafari/FindSafari.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • record-memory-win/record-memory-win.vcproj:
3:32 PM Changeset in webkit [73077] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:23 PM Changeset in webkit [73076] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
adding the file to the sources list was not enough to force the rebuild.

  • DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Remove an empty line at the end of this file to force a rebuild.
3:14 PM WebKitGtkLayoutTests edited by Martin Robinson
Combined all required packages into one list. Removed … (diff)
3:09 PM Changeset in webkit [73075] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Don't let harmless errorlevels from the "set" utility leak into project-specific build scripts

When using set to unset an environment variable that didn't previously
exist, set raises the errorlevel to 1. This was leaking into
project-specific scripts, causing them to think the build has failed.
We now clear the errorlevel after we finish setting environment
variables.

Fixes <​http://webkit.org/b/50350> Windows builds mysteriously fail in
some configurations

Reviewed by Steve Falkenburg.

  • win/tools/vsprops/common.vsprops: Call "cmd /c" after setting

environment variables to get rid of any errorlevel that "set" set.

3:08 PM Changeset in webkit [73074] by Adam Roben
  • 2 edits in trunk

Teach git to ignore files installed by WebKitSupportLibrary and WebKitAuxiliaryLibrary

Fixes <​http://webkit.org/b/50348> Git complains about lots of
untracked files in WebKitLibraries/win

Reviewed by Steve Falkenburg.

  • .gitignore: Added files from these libraries.
3:04 PM Changeset in webkit [73073] by Simon Fraser
  • 4 edits in trunk/WebKit2

2010-12-01 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Size changes on layer-backed drawing areas don't always end up with the correct value
​https://bugs.webkit.org/show_bug.cgi?id=50351
<rdar://problem/8692966>

When the UI process does not receive didSetSize messages promptly,
LayerBackedDrawingAreaProxy::setSize() bails early based on the
m_isWaitingForDidSetFrameNotification flag.

In this situation, the final size may be incorrect. didSetSize()
needs to compare the size that the web process has to the expected size,
and send a final setSize if they differ.

  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize): (WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage):
  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::setSize):
3:01 PM WebKitGtkLayoutTests edited by dbates@webkit.org
Added dependency on otf-stix (diff)
2:44 PM Changeset in webkit [73072] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Tony Chang <​tony@chromium.org>

Unreviewed, one more try to get chromium drt bots green.

  • platform/chromium/test_expectations.txt:
2:27 PM Changeset in webkit [73071] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix <rdar://problem/8717674>.

Reviewed by Sam Weinig..

  • WebProcess/com.apple.WebProcess.sb:

Allow the UI process to issue file-write extensions.

2:24 PM Changeset in webkit [73070] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix windows build.

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

2:16 PM Changeset in webkit [73069] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Add missing file to the TestNetscapePlugin sources list after r73057.

  • GNUmakefile.am: Add missing file.
2:15 PM Changeset in webkit [73068] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Another windows build fix.

  • UIProcess/API/C/win/WKView.cpp:

(WKViewCreate):

2:08 PM Changeset in webkit [73067] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Attempt to fix Windows build.

  • UIProcess/API/C/win/WKViewPrivate.cpp:
  • UIProcess/API/C/win/WKViewPrivate.h:
2:00 PM Changeset in webkit [73066] by weinig@apple.com
  • 65 edits
    10 adds in trunk

Add PageGrouping to WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=50332

Reviewed by Anders Carlsson.

WebKit2:

  • Adds WKPageGroupRef and WKBundlePageGroupRef API objects (backed by WebPageGroup and WebPageGroupProxy respectively).
  • Moves visibleToInjectedBundle from page to PageGroup.
  • Make userScript/userStyleSheet functions take a page group parameter.
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • Shared/WebPageGroupData.cpp: Added.

(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):

  • Shared/WebPageGroupData.h: Added.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetPageGroup):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPageGroup.cpp: Added.

(WKPageGroupGetTypeID):
(WKPageGroupCreateWithIdentifier):
(WKPageGroupCopyIdentifier):

  • UIProcess/API/C/WKPageGroup.h: Added.
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/API/C/win/WKView.cpp:

(WKViewCreate):

  • UIProcess/API/C/win/WKView.h:
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]):
(-[WKView initWithFrame:pageNamespaceRef:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::QWKPagePrivate):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::inspectorPageGroup):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebPageGroup.cpp: Added.

(WebKit::generatePageGroupID):
(WebKit::webPageGroupMap):
(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::get):
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):

  • UIProcess/WebPageGroup.h: Added.

(WebKit::WebPageGroup::identifier):
(WebKit::WebPageGroup::pageGroupID):
(WebKit::WebPageGroup::data):
(WebKit::WebPageGroup::type):

  • UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::createWebPage):

  • UIProcess/WebPageNamespace.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageGroup):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/win/WebView.h:

(WebKit::WebView::create):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleAddUserScript):
(WKBundleAddUserStyleSheet):
(WKBundleRemoveUserScript):
(WKBundleRemoveUserStyleSheet):
(WKBundleRemoveUserScripts):
(WKBundleRemoveUserStyleSheets):
(WKBundleRemoveAllUserContent):
(WKBundleOverrideXSSAuditorEnabledForTestRunner):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetPageGroup):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageGroup.cpp: Added.

(WKBundlePageGroupGetTypeID):
(WKBundlePageGroupCopyIdentifier):

  • WebProcess/InjectedBundle/API/c/WKBundlePageGroup.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner):
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
(WebKit::InjectedBundle::didInitializePageGroup):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundleClient.cpp:

(WebKit::InjectedBundleClient::didInitializePageGroup):

  • WebProcess/InjectedBundle/InjectedBundleClient.h:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::create):
(WebKit::WebPage::WebPage):
(WebKit::WebPage::close):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::pageGroup):

  • WebProcess/WebPage/WebPageGroupProxy.cpp: Added.

(WebKit::WebPageGroupProxy::create):
(WebKit::WebPageGroupProxy::~WebPageGroupProxy):

  • WebProcess/WebPage/WebPageGroupProxy.h: Added.

(WebKit::WebPageGroupProxy::identifier):
(WebKit::WebPageGroupProxy::pageGroupID):
(WebKit::WebPageGroupProxy::isVisibleToInjectedBundle):
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
(WebKit::WebPageGroupProxy::type):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):

  • WebProcess/WebProcess.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

WebKitTools:

  • Update testing harnesses to deal with new PageGroup API.
  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(WKBundleInitialize):

  • TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):
(TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
(TestWebKitAPI::InjectedBundleController::initializeTestNamed):

  • TestWebKitAPI/InjectedBundleController.h:
  • TestWebKitAPI/InjectedBundleTest.h:

(TestWebKitAPI::InjectedBundleTest::initialize):
(TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):

  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextForInjectedBundleTest):

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:

(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):

  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

  • TestWebKitAPI/win/PlatformWebViewWin.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didInitializePageGroup):
(WTR::InjectedBundle::initialize):
(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::pageGroup):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::addUserScript):
(WTR::LayoutTestController::addUserStyleSheet):
(WTR::LayoutTestController::setXSSAuditorEnabled):

  • WebKitTestRunner/TestController.cpp:
  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView):

1:53 PM Changeset in webkit [73065] by barraclough@apple.com
  • 7 edits in trunk

JavaScriptCore: 010-12-01 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCF.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/testapi/testapi.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added property svn:eol-style.

LayoutTests: Bug 50298 - /()()()()()()()()()(?:(\10a|b)(X|Y))+/.exec("bXXaYYaY") ASSERTs

Reviewed by Sam Weinig.

  • fast/regex/script-tests/pcre-test-1.js:

Enable regex643, this now works.

1:49 PM Changeset in webkit [73064] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Ojan Vafai <​ojan@chromium.org>

[chromium] Green tree.
-​http://trac.webkit.org/changeset/73057 caused plugins/get-user-agent-with-null-npp-from-npp-new.html
-Clean up a couple mistakes from ​http://trac.webkit.org/changeset/73059
-add a bug ID for fast/regex/pcre-test-1.html

  • platform/chromium/test_expectations.txt:
1:31 PM Changeset in webkit [73063] by hyatt@apple.com
  • 13 edits
    8 adds
    2 deletes in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46645

Reviewed by Darin Adler.

Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
recently added for horizontal RTL documents and applies it to writing modes as well. Now the
scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.

This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
makes them behave the same as the cross-platform code (allowing for cross-platform results to be
landed).

WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::adjustViewSize):

  • page/mac/WebCoreFrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::minimumScrollPosition):
(WebCore::ScrollView::valueChanged):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(WebCore::ScrollView::scrollOrigin):

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetScrollPosition):
(WebCore::ScrollView::platformSetScrollOrigin):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxDecorations):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):
(WebCore::RenderView::docTop):
(WebCore::RenderView::docHeight):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docWidth):

  • rendering/RenderView.h:

WebKit/mac:

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
(-[WebDynamicScrollBarsView scrollOrigin]):

  • WebView/WebFrameView.mm:

(-[WebFrameView _scrollToBeginningOfDocument]):
(-[WebFrameView _scrollToEndOfDocument]):

LayoutTests:

  • fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
  • fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
  • fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
  • fast/dom/vertical-scrollbar-in-rtl.html: Added.
  • fast/dom/vertical-scrollbar-when-dir-change-expected.txt: Added.
  • fast/dom/vertical-scrollbar-when-dir-change.html: Added.
  • platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
  • platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Removed.
1:21 PM Changeset in webkit [73062] by steveblock@google.com
  • 5 edits
    1 add in trunk/WebCore

2010-11-30 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Upstream recent changes to WebCore/platform/network/android
​https://bugs.webkit.org/show_bug.cgi?id=50224

Android implementation changes only, no new tests.

  • platform/network/NetworkingContext.h:
  • platform/network/android/CookieJarAndroid.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled):
  • platform/network/android/ProxyServerAndroid.cpp: Added. (WebCore::proxyServersForURL):
  • platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously):
  • platform/network/android/ResourceRequestAndroid.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
1:10 PM Changeset in webkit [73061] by victorw@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-12-01 Victor Wang <​victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations.

  • platform/chromium/fast/xmlhttprequest: Added.
  • platform/chromium/fast/xmlhttprequest/xmlhttprequest-responsetype-abort-expected.txt: Added.
  • platform/chromium/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Added.
  • platform/chromium/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Added.
1:01 PM Changeset in webkit [73060] by sfalken@apple.com
  • 107 edits in trunk

.: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • .gitattributes:

ANGLE: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • src/libEGL/libEGL.vcproj: Added property svn:eol-style.
  • src/libGLESv2/libGLESv2.vcproj: Added property svn:eol-style.

JavaScriptCore: 010-12-01 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCF.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added property svn:eol-style.
  • JavaScriptCore.vcproj/testapi/testapi.vcproj: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added property svn:eol-style.

WebCore: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • WebCore.vcproj/QTMovieWin.vcproj: Modified property svn:eol-style.
  • WebCore.vcproj/QTMovieWinCommon.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
  • WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.
  • WebCore.vcproj/WebCore.vcproj: Modified property svn:eol-style.
  • WebCore.vcproj/WebCoreCFNetwork.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreCG.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreCURL.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreCairo.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreCommon.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreGenerated.vcproj: Modified property svn:eol-style.
  • WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreMediaQT.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCorePthreads.vsprops: Added property svn:eol-style.
  • WebCore.vcproj/WebCoreQuartzCore.vsprops: Added property svn:eol-style.

WebKit/win: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • WebKit.vcproj/Interfaces.vcproj: Modified property svn:eol-style.
  • WebKit.vcproj/InterfacesCommon.vsprops: Added property svn:eol-style.
  • WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
  • WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
  • WebKit.vcproj/WebKit.vcproj: Modified property svn:eol-style.
  • WebKit.vcproj/WebKitGUID.vcproj: Modified property svn:eol-style.
  • WebKit.vcproj/WebKitGUIDCommon.vsprops: Added property svn:eol-style.
  • WebKit.vcproj/WebKitLibCommon.vsprops: Added property svn:eol-style.

WebKit2: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • win/WebKit2.submit.sln: Added property svn:eol-style.
  • win/WebKit2.vcproj: Added property svn:eol-style.
  • win/WebKit2Apple.vsprops: Added property svn:eol-style.
  • win/WebKit2CFLite.vsprops: Added property svn:eol-style.
  • win/WebKit2Common.vsprops: Added property svn:eol-style.
  • win/WebKit2DirectX.vsprops: Added property svn:eol-style.
  • win/WebKit2Generated.vcproj: Added property svn:eol-style.
  • win/WebKit2GeneratedCommon.vsprops: Added property svn:eol-style.
  • win/WebKit2WebProcess.vcproj: Added property svn:eol-style.
  • win/WebKit2WebProcessCommon.vsprops: Added property svn:eol-style.

WebKitLibraries: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • win/tools/vsprops/WinCairo.vsprops: Added property svn:eol-style.
  • win/tools/vsprops/cURL.vsprops: Added property svn:eol-style.
  • win/tools/vsprops/debug_wincairo.vsprops: Added property svn:eol-style.

WebKitTools: vcproj changes can't be applied cleanly by the Windows EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=50328

Reviewed by Adam Roben.

  • CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
  • CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
  • DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
  • DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
  • DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
  • DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
  • DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
  • DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
  • FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
  • FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
  • MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
  • MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
  • MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
  • MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
  • MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
  • TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
  • TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
  • TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
  • TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
  • WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
  • WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
  • WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
  • WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
  • WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
  • WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
  • WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
  • WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
  • record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
  • record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
12:47 PM Changeset in webkit [73059] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-12-01 Tony Chang <​tony@chromium.org>

Unreviewed, merging drt_expectations into test_expectations in
anticipation of the switch.

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
12:46 PM Changeset in webkit [73058] by Simon Fraser
  • 5 edits in trunk/WebKit2

2010-12-01 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Crash when closing WebKit2 window with accelerated composting content
​https://bugs.webkit.org/show_bug.cgi?id=50307
<rdar://problem/8640126>

When the web page is closing, notify the drawing area, so that
the layer-backed drawing area can kill the runloop obsever,
then clear it. Clearing it is not sufficient, since the drawing
area is ref-counted.

  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::onPageClose):
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformClear): (WebKit::LayerBackedDrawingArea::onPageClose):
12:12 PM Changeset in webkit [73057] by andersca@apple.com
  • 13 edits
    3 adds in trunk

Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
​https://bugs.webkit.org/show_bug.cgi?id=50336

Reviewed by Darin Adler.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_UserAgent):
Call the static NetscapePlugin::userAgent function instead.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent):
If the passed in NPP is null, get the NetscapePlugin currently executing NPP_New.

(WebKit::NetscapePlugin::initialize):
Keep track of the plug-in currently executing NPP_New.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

WebKitTools:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Add new test.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_New):
Add default implementation/

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.

(GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
(GetUserAgentWithNullNPPFromNPPNew::NPP_New):
Get the user agent.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_New):
Call PluginTest::NPP_New.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

Add new files.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:

(webkit_test_plugin_new_instance):
Call PluginTest::NPP_New.

LayoutTests:

Add tests.

  • plugins/get-user-agent-with-null-npp-from-npp-new-expected.txt: Added.
  • plugins/get-user-agent-with-null-npp-from-npp-new.html: Added.
12:04 PM Changeset in webkit [73056] by barraclough@apple.com
  • 6 edits in trunk

Bug 50297 - \s in YARR should match BOMs.

Rubber stamped by Sam Weinig.

JavaScriptCore:

  • create_regex_tables:

LayoutTests:

This exposes a Sputnik bug, tracked by:
​http://code.google.com/p/sputniktests/issues/detail?id=34
Checking in expected failing results.

  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.12_CharacterClassEscape/S15.10.2.12_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.12_CharacterClassEscape/S15.10.2.12_A2_T1-expected.txt:
  • fast/regex/script-tests/pcre-test-1.js:
12:04 PM Changeset in webkit [73055] by vangelis@chromium.org
  • 8 edits in trunk

2010-11-30 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Get the value of the accelerated compositing triggers from the Settings
class. This allows setting the triggers via command line flags.
​https://bugs.webkit.org/show_bug.cgi?id=50301

  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAcceleratedCompositingFor3DTransformsEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForVideoEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForPluginsEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForCanvasEnabled): (WebKit::WebSettingsImpl::setAcceleratedCompositingForAnimationEnabled):
  • src/WebSettingsImpl.h:

2010-11-30 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Adds accelerated compositing trigger flags to Settings to allow
ports to set them via command line flags, etc.
​https://bugs.webkit.org/show_bug.cgi?id=50301

  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAcceleratedCompositingFor3DTransformsEnabled): (WebCore::Settings::setAcceleratedCompositingForVideoEnabled): (WebCore::Settings::setAcceleratedCompositingForPluginsEnabled): (WebCore::Settings::setAcceleratedCompositingForCanvasEnabled): (WebCore::Settings::setAcceleratedCompositingForAnimationEnabled):
  • page/Settings.h: (WebCore::Settings::acceleratedCompositingFor3DTransformsEnabled): (WebCore::Settings::acceleratedCompositingForVideoEnabled): (WebCore::Settings::acceleratedCompositingForPluginsEnabled): (WebCore::Settings::acceleratedCompositingForCanvasEnabled): (WebCore::Settings::acceleratedCompositingForAnimationEnabled):
11:55 AM Changeset in webkit [73054] by mitz@apple.com
  • 1 edit
    1 copy
    1 add in trunk/LayoutTests

Re-added Leopard-specific results for editing/text-iterator/findString.html. In the Leopard version
of ICU, the full stop character is a word separator, so an at-word-starts search for "org" in
"webkit.org" matches.

  • platform/mac-leopard/editing/text-iterator: Added.
  • platform/mac-leopard/editing/text-iterator/findString-expected.txt: Copied from LayoutTests/editing/text-iterator/findString-expected.txt.
11:54 AM Changeset in webkit [73053] by Darin Adler
  • 2 edits in trunk/WebCore

Fixed warning seen on buildbot.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::SharedValues::SharedValues): Added #if.

11:50 AM Changeset in webkit [73052] by rniwa@webkit.org
  • 4 edits
    4 adds in trunk

2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea)
​https://bugs.webkit.org/show_bug.cgi?id=47808

The crash was caused by moveParagraphWithClones' not copying the entire paragraph
when called by doApplyForSingleParagraph, which was induced by a bug in
cloneParagraphUnderNewElement which ended the cloning process early when the start node
and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement
by calling traverseNextSibling(outerNode) instead of nextSibling().

Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null.

Tests: editing/execCommand/switch-multiple-list-items-crash.html

editing/execCommand/switch-multiple-list-items.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):

2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea)
​https://bugs.webkit.org/show_bug.cgi?id=47808

Added tests to ensure WebKit can switch the type of multiple list items without a crash.

  • editing/execCommand/switch-multiple-list-items-crash-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items-crash.html: Added.
  • editing/execCommand/switch-multiple-list-items-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items.html: Added.
11:46 AM Changeset in webkit [73051] by kevino@webkit.org
  • 6 edits in trunk

[wx] Build fixes after recent trunk changes.

11:41 AM Changeset in webkit [73050] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, upstreaming test suppression.

  • platform/chromium/test_expectations.txt:
11:39 AM Changeset in webkit [73049] by rniwa@webkit.org
  • 4 edits
    4 deletes in trunk

2010-12-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73047.
​http://trac.webkit.org/changeset/73047
​https://bugs.webkit.org/show_bug.cgi?id=50339

missing bug number (Requested by rniwa on #webkit).

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):

2010-12-01 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r73047.
​http://trac.webkit.org/changeset/73047
​https://bugs.webkit.org/show_bug.cgi?id=50339

missing bug number (Requested by rniwa on #webkit).

  • editing/execCommand/switch-multiple-list-items-crash-expected.txt: Removed.
  • editing/execCommand/switch-multiple-list-items-crash.html: Removed.
  • editing/execCommand/switch-multiple-list-items-expected.txt: Removed.
  • editing/execCommand/switch-multiple-list-items.html: Removed.
11:34 AM Changeset in webkit [73048] by bweinstein@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

Add failing Windows expected results for tests that involve the xhr.arrayBuffer = 'arraybuffer',
which works on Mac, but not on Windows.

Getting arrayBuffer working on Windows is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=50334.

  • platform/win/fast/xmlhttprequest: Added.
  • platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-abort-expected.txt: Added.
  • platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Added.
  • platform/win/http/tests/xmlhttprequest: Added.
  • platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Added.
11:28 AM Changeset in webkit [73047] by rniwa@webkit.org
  • 4 edits
    4 adds in trunk

2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

The crash was caused by moveParagraphWithClones' not copying the entire paragraph
when called by doApplyForSingleParagraph, which was induced by a bug in
cloneParagraphUnderNewElement which ended the cloning process early when the start node
and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement
by calling traverseNextSibling(outerNode) instead of nextSibling().

Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null.

Tests: editing/execCommand/switch-multiple-list-items-crash.html

editing/execCommand/switch-multiple-list-items.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):

2010-12-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.

Added tests to ensure WebKit can switch the type of multiple list items without a crash.

  • editing/execCommand/switch-multiple-list-items-crash-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items-crash.html: Added.
  • editing/execCommand/switch-multiple-list-items-expected.txt: Added.
  • editing/execCommand/switch-multiple-list-items.html: Added.
11:13 AM Changeset in webkit [73046] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-12-01 Grace Kloba <​klobag@chromium.org>

Reviewed by Kenneth Russell.

[chromium] ContentLayerChromium shader should honor the platform Sk_x_SHIFT value instead of assuming BGRA color
​https://bugs.webkit.org/show_bug.cgi?id=50189

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues):Use SK_B32_SHIFT to decide whether to use RGBA or BGRA shader for Skia port.
11:08 AM Changeset in webkit [73045] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

One last Windows build fix.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):

10:59 AM Changeset in webkit [73044] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):

10:51 AM Changeset in webkit [73043] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip another HTMLProgressElement test on Windows, because it's not turned on for Windows yet. Adding
progress element support on Windows is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=49769.

  • platform/win/Skipped:
10:43 AM Changeset in webkit [73042] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • UIProcess/win/WebView.h:
10:41 AM XBL2UseCases edited by Dimitri Glazkov
(diff)
10:40 AM Changeset in webkit [73041] by vitalyr@chromium.org
  • 12 edits in trunk/LayoutTests

2010-12-01 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating test expectations and rebaselining.

  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt:
  • platform/chromium/test_expectations.txt:
10:37 AM Changeset in webkit [73040] by yurys@chromium.org
  • 2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 73021 - 2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not make helpScreen.css lazily loaded.
​https://bugs.webkit.org/show_bug.cgi?id=50304

  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): (WebInspector.HelpScreen.prototype._onBlur):
  • inspector/front-end/inspector.html:

BUG=64913
TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/5487001

10:36 AM Changeset in webkit [73039] by mitz@apple.com
  • 6 edits in trunk/WebKitTools

WebKitTestRunner needs layoutTestController.findString
​https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Darin Adler.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
10:34 AM Changeset in webkit [73038] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-12-01 Tony Chang <​tony@chromium.org>

Unreviewed, rolling chromium deps to r67811.

  • DEPS:
10:28 AM Changeset in webkit [73037] by yurys@chromium.org
  • 1 edit in branches/chromium/597/WebCore/css/CSSImportRule.cpp

Merge 72988 - 2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Dave Hyatt.

Web Inspector: [CRASH] on "Revert to this revision" of style with import.
​https://bugs.webkit.org/show_bug.cgi?id=50256

Rolled back one line from ​http://trac.webkit.org/changeset/36904 as agreed with
David.

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):

BUG=64916
TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/5482001

10:23 AM Changeset in webkit [73036] by andersca@apple.com
  • 24 edits in trunk/WebKit2

Get rid of DrawingAreaBase
​https://bugs.webkit.org/show_bug.cgi?id=50329

Reviewed by Andreas Kling.

  • Scripts/webkit2/messages.py:
  • Shared/DrawingAreaInfo.h:

(WebKit::DrawingAreaInfo::DrawingAreaInfo):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
(-[WKView _pageDidEnterAcceleratedCompositing]):
(-[WKView _pageDidLeaveAcceleratedCompositing]):

  • UIProcess/API/qt/qgraphicswkview.cpp:

(QGraphicsWKView::takeSnapshot):
(QGraphicsWKViewPrivate::commitScale):

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
(WebKit::ChunkedUpdateDrawingAreaProxy::setSize):
(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
(WebKit::ChunkedUpdateDrawingAreaProxy::update):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::nextIdentifier):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::info):

  • UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):
(WebKit::LayerBackedDrawingAreaProxy::setSize):
(WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible):
(WebKit::LayerBackedDrawingAreaProxy::update):

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeAcceleratedCompositing):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):
(WebKit::DrawingArea::DrawingArea):

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::info):

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
(WebKit::LayerBackedDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::TiledDrawingArea):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::changeAcceleratedCompositingMode):

10:19 AM Changeset in webkit [73035] by yurys@chromium.org
  • 10 edits in branches/chromium/597/WebCore

Merge 72938 - 2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement "Revert to this revision" in resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=50107

  • inspector/Inspector.idl:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::setStyleSheetText2):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::reparseStyleSheet):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get contentTimestamp): (WebInspector.Resource.prototype.setInitialContent): (WebInspector.Resource.prototype.isLocallyModified): (WebInspector.Resource.prototype.setContent.else.finished): (WebInspector.Resource.prototype.setContent): (WebInspector.Resource.prototype.revertToThis.callback): (WebInspector.Resource.prototype.revertToThis): (WebInspector.Resource.prototype.get baseRevision): (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.FrameResourceTreeElement.prototype._contentChanged): (WebInspector.ResourceRevisionTreeElement): (WebInspector.ResourceRevisionTreeElement.prototype.onattach): (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._editLine): (WebInspector.SourceView.prototype._editLineComplete): (WebInspector.SourceView.prototype._revertEditLine):

BUG=64915
TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/5446003

10:15 AM Changeset in webkit [73034] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Cleaning up test expectations.

  • platform/chromium/test_expectations.txt:
9:58 AM Changeset in webkit [73033] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Tony Chang <​tony@chromium.org>

Unreviewed, update drt expectations.

  • platform/chromium/drt_expectations.txt:
9:49 AM Changeset in webkit [73032] by thakis@chromium.org
  • 2 edits in trunk/WebCore

2010-12-01 Nico Weber <​thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Fix clang warnings caused by -Wlogical-op-parentheses
​https://bugs.webkit.org/show_bug.cgi?id=50324

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
9:46 AM Changeset in webkit [73031] by yurys@chromium.org
  • 1 edit in branches/chromium/597/WebCore/inspector/front-end/InjectedScript.js

Merge 72903 - 2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make copy(node) work in console.
​https://bugs.webkit.org/show_bug.cgi?id=50180

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/5469002

9:25 AM Changeset in webkit [73030] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Build fix for GTK+.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::typeAheadFind): Uncomment mistakenly commented line.
9:18 AM Changeset in webkit [73029] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-01 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating test expectations.

  • platform/chromium/test_expectations.txt:
9:07 AM Changeset in webkit [73028] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Try using svn:eol-style native on a vcproj file.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
9:04 AM Changeset in webkit [73027] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unrreviewed.

[Qt] Add focus ring outline color support
​https://bugs.webkit.org/show_bug.cgi?id=50325

Focus ring outline color is unsupported now.
Add failing tests to the Skipped list until fix.

  • platform/qt/Skipped:
    • fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html added
    • fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html added
    • fast/images/imagemap-focus-ring-outline-color.html added
8:49 AM Changeset in webkit [73026] by Patrick Gansterer
  • 1 edit
    2 adds in trunk/WebKitTools

2010-12-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Add WinCELauncher
​https://bugs.webkit.org/show_bug.cgi?id=50217

  • WinCELauncher/main.cpp: Added.
8:46 AM Changeset in webkit [73025] by Martin Robinson
  • 4 edits
    2 adds in trunk

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Open menulists should support typeahead find
​https://bugs.webkit.org/show_bug.cgi?id=27443

Added a GTK+-specific layout test to track typeahead find state.

  • platform/gtk/fast/forms/menulist-typeahead-find-expected.txt: Added.
  • platform/gtk/fast/forms/menulist-typeahead-find.html: Added.

2010-12-01 Apelete Seketeli <​apelete@seketeli.org> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Open menulists should support typeahead find
​https://bugs.webkit.org/show_bug.cgi?id=27443

Added typeahead find support for open GTK+ menulists.

Test: platform/gtk/fast/forms/menulist-typeahead-find.html

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::PopupMenuGtk): Initialize new members. (WebCore::PopupMenuGtk::show): Track currently selected menu item via a signal handler. (WebCore::PopupMenuGtk::typeAheadFind): Added. (WebCore::PopupMenuGtk::menuUnmapped): Reset typeahead find state when menu is unmapped. (WebCore::PopupMenuGtk::resetTypeAheadFindState): Added. (WebCore::PopupMenuGtk::selectItemCallback): Added. (WebCore::PopupMenuGtk::keyPressEventCallback): Added.
  • platform/gtk/PopupMenuGtk.h: Added new members to track typeahead find state.
8:36 AM Changeset in webkit [73024] by Nikolas Zimmermann
  • 28 edits in trunk/WebCore

2010-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Xan Lopez.

Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedNumber
​https://bugs.webkit.org/show_bug.cgi?id=50323

Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_NUMBER / DEFINE_ANIMATED_NUMBER.
The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.

No functional changes, thus no new tests.

  • svg/SVGAnimatedNumber.h:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFELightElement.cpp:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMorphologyElement.cpp:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGPathElement.cpp:
  • svg/SVGPathElement.h:
  • svg/SVGStopElement.cpp:
  • svg/SVGStopElement.h: (WebCore::SVGStopElement::isGradientStop):
8:15 AM Changeset in webkit [73023] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Sliders are not transformed after r50188
​https://bugs.webkit.org/show_bug.cgi?id=50317

Need to call updateLayerTransform during slider layout, as sliders
may be transformed.

No new tests. This patch should make fast/forms/slider-transformed.html
pass on the GTK+ bots.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Call updateLayerTransform here.
8:13 AM Changeset in webkit [73022] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-12-01 Martin Robinson <​mrobinson@igalia.com>

Skip failing tests for text height on GTK
​https://bugs.webkit.org/show_bug.cgi?id=50314

  • platform/gtk/Skipped: Skip failing tests.
7:52 AM Changeset in webkit [73021] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not make helpScreen.css lazily loaded.
​https://bugs.webkit.org/show_bug.cgi?id=50304

  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): (WebInspector.HelpScreen.prototype._onBlur):
  • inspector/front-end/inspector.html:
7:41 AM Changeset in webkit [73020] by Nikolas Zimmermann
  • 23 edits in trunk/WebCore

2010-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Xan Lopez.

Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLengthList/SVGNumberList/SVGTransformList
​https://bugs.webkit.org/show_bug.cgi?id=50322

Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_(LENGTH|NUMBER|TRANSFORM)_LIST / DEFINE_ANIMATED_(LENGTH|NUMBER|TRANSFORM).
The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.

No functional changes, thus no new tests.

  • svg/SVGAnimatedLengthList.h:
  • svg/SVGAnimatedNumberList.h:
  • svg/SVGAnimatedTransformList.h:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGGradientElement.cpp:
  • svg/SVGGradientElement.h: (WebCore::SVGGradientElement::needsPendingResourceHandling):
  • svg/SVGPatternElement.cpp:
  • svg/SVGPatternElement.h:
  • svg/SVGPolygonElement.cpp:
  • svg/SVGPolylineElement.cpp:
  • svg/SVGStyledTransformableElement.cpp:
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
  • svg/SVGTextElement.h: (WebCore::SVGTextElement::localCoordinateSpaceTransform):
  • svg/SVGTextPositioningElement.cpp:
  • svg/SVGTextPositioningElement.h:
  • svg/properties/SVGAnimatedPropertyMacros.h:
7:32 AM Changeset in webkit [73019] by chang.shu@nokia.com
  • 1 edit
    3 moves
    2 adds in trunk/LayoutTests

2010-12-01 Chang Shu <​chang.shu@nokia.com>

Reviewed by Laszlo Gombos.

Move orientation event test case to a better place.
​https://bugs.webkit.org/show_bug.cgi?id=32492

  • fast/dom/DeviceOrientation/create-event-orientationchange-expected.txt: Removed.
  • fast/dom/DeviceOrientation/create-event-orientationchange.html: Removed.
  • fast/dom/DeviceOrientation/script-tests/create-event-orientationchange.js: Removed.
  • fast/dom/Orientation: Added.
  • fast/dom/Orientation/create-event-orientationchange-expected.txt: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-orientationchange-expected.txt.
  • fast/dom/Orientation/create-event-orientationchange.html: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-orientationchange.html.
  • fast/dom/Orientation/script-tests: Added.
  • fast/dom/Orientation/script-tests/create-event-orientationchange.js: Copied from LayoutTests/fast/dom/DeviceOrientation/script-tests/create-event-orientationchange.js.
6:14 AM Changeset in webkit [73018] by apavlov@chromium.org
  • 4 edits in trunk

2010-12-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: name-only property appears in style declaration but not in the Styles pane
​https://bugs.webkit.org/show_bug.cgi?id=49663

Check that at least one property has been parsed from the user input.

WebCore:

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::setPropertyText):

LayoutTests:

  • inspector/styles-new-API.html:
5:29 AM Changeset in webkit [73017] by caseq@chromium.org
  • 5 edits in trunk

2010-12-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: disable cookies tab in network resource view by default, enable for chromium
​https://bugs.webkit.org/show_bug.cgi?id=50249

  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView): (WebInspector.NetworkItemView.prototype.resize):
  • inspector/front-end/Settings.js:

2010-12-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: disable cookies tab in network resource view by default, enable for chromium
​https://bugs.webkit.org/show_bug.cgi?id=50249

  • src/js/DevTools.js:
4:17 AM Changeset in webkit [73016] by Nikolas Zimmermann
  • 40 edits in trunk/WebCore

2010-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Xan Lopez.

Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLength
​https://bugs.webkit.org/show_bug.cgi?id=50316

Introduce DECLARE_ANIMATED_LENGTH / DEFINE_ANIMATED_LENGTH, splitting up the original DECLARE_ANIMATED_PROPERTY_NEW macro
in a part that goes in the .cpp file and another that remains in the header. This avoids having to include SVGNames.h
in all SVG*Element files.

No functional changes, thus no new tests.

  • svg/SVGAnimatedLength.h:
  • svg/SVGCircleElement.cpp:
  • svg/SVGCircleElement.h: (WebCore::SVGCircleElement::isValid):
  • svg/SVGCursorElement.cpp:
  • svg/SVGCursorElement.h: (WebCore::SVGCursorElement::isValid):
  • svg/SVGEllipseElement.cpp:
  • svg/SVGEllipseElement.h: (WebCore::SVGEllipseElement::isValid):
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
  • svg/SVGForeignObjectElement.h: (WebCore::SVGForeignObjectElement::isValid):
  • svg/SVGImageElement.cpp:
  • svg/SVGImageElement.h: (WebCore::SVGImageElement::isValid):
  • svg/SVGLineElement.cpp:
  • svg/SVGLineElement.h: (WebCore::SVGLineElement::isValid): (WebCore::SVGLineElement::supportsMarkers):
  • svg/SVGLinearGradientElement.cpp:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp:
  • svg/SVGMaskElement.h: (WebCore::SVGMaskElement::isValid): (WebCore::SVGMaskElement::needsPendingResourceHandling):
  • svg/SVGPatternElement.cpp:
  • svg/SVGPatternElement.h: (WebCore::SVGPatternElement::isValid): (WebCore::SVGPatternElement::needsPendingResourceHandling):
  • svg/SVGRadialGradientElement.cpp:
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp:
  • svg/SVGRectElement.h: (WebCore::SVGRectElement::isValid):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
  • svg/SVGSVGElement.h: (WebCore::SVGSVGElement::isValid): (WebCore::SVGSVGElement::setContainerSize): (WebCore::SVGSVGElement::containerSize): (WebCore::SVGSVGElement::hasSetContainerSize): (WebCore::SVGSVGElement::currentTranslate): (WebCore::SVGSVGElement::timeContainer): (WebCore::SVGSVGElement::isSVG): (WebCore::SVGSVGElement::rendererIsNeeded):
  • svg/SVGTextContentElement.cpp:
  • svg/SVGTextContentElement.h: (WebCore::SVGTextContentElement::isValid): (WebCore::SVGTextContentElement::isTextContent):
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.h:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h: (WebCore::SVGUseElement::isValid): (WebCore::SVGUseElement::setUpdatesBlocked): (WebCore::SVGUseElement::isPendingResource):
  • svg/properties/SVGAnimatedPropertyMacros.h:
4:03 AM Changeset in webkit [73015] by commit-queue@webkit.org
  • 5 edits in trunk

2010-12-01 Anton D'Auria <​adauria@apple.com>

Reviewed by Kevin Decker.

Private browsing denies read access to local and session storage,
so updating expected test results.

​https://bugs.webkit.org/show_bug.cgi?id=49329

  • storage/domstorage/localstorage/private-browsing-affects-storage-expected.txt:
  • storage/domstorage/sessionstorage/private-browsing-affects-storage-expected.txt:

2010-12-01 Anton D'Auria <​adauria@apple.com>

Reviewed by Kevin Decker.

Deny access to local and session storage in private browsing mode.
​https://bugs.webkit.org/show_bug.cgi?id=49329

  • storage/Storage.cpp: (WebCore::Storage::length): (WebCore::Storage::key): (WebCore::Storage::getItem): (WebCore::Storage::contains):
3:41 AM Changeset in webkit [73014] by Philippe Normand
  • 4 edits in trunk/WebCore

2010-12-01 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

Volume control not correctly initialized
​https://bugs.webkit.org/show_bug.cgi?id=36299

Replaced the mute/volume Timers with g_timeouts which are (for
now, at least) more reliable than Timers for one-shot-fire-now
actions.

Test: media/video-volume.html

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::~MediaPlayer): Reset the raw pointers to 0 when destructing the player.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateVolumeChangeTimeoutCallback): (WebCore::mediaPlayerPrivateMuteChangeTimeoutCallback): (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVolumeChange): (WebCore::MediaPlayerPrivateGStreamer::volumeChanged): (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfMute): (WebCore::MediaPlayerPrivateGStreamer::muteChanged): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Set playbin2 volume/mute base on MediaPlayer related values.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
3:32 AM Changeset in webkit [73013] by hayato@chromium.org
  • 5 edits in trunk/LayoutTests

2010-12-01 Hayato Ito <​hayato@chromium.org>

Unreviewed trivial fix.

Removed fast/regex/{test1,test4}.html because they were removed from tree by r72990

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
2:47 AM Changeset in webkit [73012] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-12-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Cleanup main CMakeLists.txt after r72664, r72672 and r72667
​https://bugs.webkit.org/show_bug.cgi?id=50232

  • CMakeLists.txt: Removed obsolete dependencies.
12:57 AM Changeset in webkit [73011] by Nikolas Zimmermann
  • 25 edits
    1 add in trunk/WebCore

2010-12-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Cleanup SVGPropertyTraits
​https://bugs.webkit.org/show_bug.cgi?id=50229

Move all template specializations for non-POD types (eg. SVGLength, SVGLengthList, etc.) from SVGPropertyTraits
into the right SVG* classes, to avoid having to include a dozen SVG*.h files in SVGPropertyTraits.h, which is
included by all DOM/JS/V8 binding files and SVGElement.h.

No new functionality, thus no new tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • svg/SVGAngle.h:
  • svg/SVGLength.h:
  • svg/SVGLengthList.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGNumberList.h:
  • svg/SVGPatternElement.h:
  • svg/SVGPointList.h:
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGRect.h: Added.
  • svg/SVGSVGElement.h:
  • svg/SVGStringList.h:
  • svg/SVGSymbolElement.h:
  • svg/SVGTransformList.h:
  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.h:
  • svg/properties/SVGListProperty.h:
  • svg/properties/SVGPropertyTraits.h:
  • svg/properties/SVGTransformListPropertyTearOff.h:
12:13 AM Changeset in webkit [73010] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

  • platform/qt/Skipped:
    • editing/selection/5109817.html: removed, because it was removed from tree by r73009
    • fast/regex/test1.html: removed, because it was removed from tree by r72990
    • fast/regex/test4.html: removed, because it was removed from tree by r72990

Nov 30, 2010:

9:37 PM Changeset in webkit [73009] by commit-queue@webkit.org
  • 2 edits
    1 add
    15 deletes in trunk/LayoutTests

2010-11-30 Avi Drissman <​avi@google.com>

Reviewed by Darin Adler.

Add preference to not select when right-clicked
​https://bugs.webkit.org/show_bug.cgi?id=23351

Removed 5109817 because it is entirely superseded by
context-menu-text-selection; updated 5354455-1 to explicitly set the
editing behavior and test all three platforms.

  • editing/selection/5109817.html: Removed.
  • editing/selection/5354455-1-expected.txt: Added.
  • editing/selection/5354455-1.html:
  • platform/chromium-win/editing/selection/5109817-expected.txt: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.txt: Removed.
  • platform/gtk/editing/selection/5109817-expected.txt: Removed.
  • platform/gtk/editing/selection/5354455-1-expected.txt: Removed.
  • platform/mac-leopard/editing/selection/5109817-expected.checksum: Removed.
  • platform/mac-leopard/editing/selection/5109817-expected.png: Removed.
  • platform/mac/editing/selection/5109817-expected.checksum: Removed.
  • platform/mac/editing/selection/5109817-expected.png: Removed.
  • platform/mac/editing/selection/5109817-expected.txt: Removed.
  • platform/mac/editing/selection/5354455-1-expected.txt: Removed.
  • platform/win/editing/selection/5109817-expected.checksum: Removed.
  • platform/win/editing/selection/5109817-expected.png: Removed.
  • platform/win/editing/selection/5109817-expected.txt: Removed.
  • platform/win/editing/selection/5354455-1-expected.txt: Removed.
8:36 PM Changeset in webkit [73008] by tkent@chromium.org
  • 14 edits in trunk/WebCore

Refactor HTMLInputElement: Move a part of HTMLInputElement::
defaultEventHandler() to InputTypes
​https://bugs.webkit.org/show_bug.cgi?id=50097

Reviewed by Darin Adler.

Move all of keyboard-related event handling to InputType.

No new tests because this should not change any behavior.

  • html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::handleKeydownEvent):
(WebCore::BaseButtonInputType::handleKeypressEvent):
(WebCore::BaseButtonInputType::handleKeyupEvent):

  • html/BaseButtonInputType.h:
  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::handleKeydownEvent):
(WebCore::BaseCheckableInputType::handleKeypressEvent):

  • html/BaseCheckableInputType.h:
  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::handleKeyupEvent):

  • html/CheckboxInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

We remove !implicitSubmission check for callBaseClassEarly because
implicitSubmission can not be true for keydown event and keypress
event at this point.

  • html/InputType.cpp:

(WebCore::InputType::shouldSubmitImplicitly):

Returns true for a keypress event with "\r". Note that we don't overload
this function for BUTTON, FILE, IMAGE, RESET, and SUBMIT because a
keypress event with "\r" for these types returns from HTMLInputElement::defaultEventHandler()
before implicit submission checking.

(WebCore::InputType::handleKeypressEvent):
(WebCore::InputType::handleKeyupEvent):

  • html/InputType.h:
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):

  • html/RadioInputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::shouldSubmitImplicitly):

  • html/TextFieldInputType.h:
8:18 PM Changeset in webkit [73007] by benjamin.poulain@nokia.com
  • 6 edits in trunk

2010-11-30 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement layoutTestController.findString
​https://bugs.webkit.org/show_bug.cgi?id=50236

Add support for the new advanced findString().

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::findString):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-11-30 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement layoutTestController.findString
​https://bugs.webkit.org/show_bug.cgi?id=50236

Add the missing function to the LayoutTestController.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::findString):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
7:59 PM Changeset in webkit [73006] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-11-30 Nicolas Dufresne <​nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Fix wrong type in assert return value
​https://bugs.webkit.org/show_bug.cgi?id=50208

Use appropriate return type in different g_return_val_if_fail(). This
removes some compiler warning.

  • webkit/webkitwebdatasource.cpp: (webkit_web_data_source_is_loading):
  • webkit/webkitwebframe.cpp: (webkit_web_frame_page_number_for_element_by_id): (webkit_web_frame_number_of_pages):
7:38 PM Changeset in webkit [73005] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2010-11-30 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Xan Lopez.

[gtk] SVGLineElement-dom-requiredFeatures.html and
SVGLineElement-svgdom-requiredFeatures.html failing in the bots
​https://bugs.webkit.org/show_bug.cgi?id=49529

Replaced fill with stroke and increased the line size. This fixes
the problem clicking the element.

  • platform/gtk/Skipped:
  • svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js:
  • svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js:
7:19 PM Changeset in webkit [73004] by rniwa@webkit.org
  • 3 edits in trunk/WebKit2

2010-11-30 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed speculative build fix for Windows.

  • UIProcess/win/WebView.cpp: (WebKit::WebView::pageDidEnterAcceleratedCompositing): (WebKit::WebView::pageDidLeaveAcceleratedCompositing): (WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
  • UIProcess/win/WebView.h:
7:19 PM Changeset in webkit [73003] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-11-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move CSS generator logic into main CMakeLists.txt file
​https://bugs.webkit.org/show_bug.cgi?id=50230

  • CMakeLists.txt:
7:12 PM Changeset in webkit [73002] by ojan@chromium.org
  • 9 edits in trunk

2010-11-30 Ojan Vafai <​ojan@chromium.org>

Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
​https://bugs.webkit.org/show_bug.cgi?id=50288

2010-11-29 Adam Barth <​abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
​https://bugs.webkit.org/show_bug.cgi?id=50182
A display-isolated URL can only be displayed (e.g., put in an iframe,
hyperlinked to) by documents from that scheme. In a sense, this is a
generalization of some of the protections we give file URLs, but
instead of lumping them all together into one "local" bucket, this
patch creates a separate bucket for each scheme.
For a while, I tried using a separate bucket for each origin. That
would have played nicely with what Blob URLs are trying to do, but some
"chrome" URL pages rely on being able to display other chrome URL
pages, even in different origins. For example, the New Tab Page shows
thumbnails from the "thumbnail" host.
This patch also removes a bunch of unused code. I've also propagated
the "deprecated" status of deprecatedCanDisplay to
deprecatedShouldTreatURLAsLocal because that method has no other
callers and is really asking for uppercase/lowercase bugs. I dream of
someday removing these functions.
page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canDisplay):
(WebCore::SecurityOrigin::deprecatedCanDisplay):
platform/SchemeRegistry.cpp:
(WebCore::displayIsolatedURLSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsLocal):
(WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
(WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
platform/SchemeRegistry.h:
2010-11-29 Adam Barth <​abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs

​https://bugs.webkit.org/show_bug.cgi?id=50182

This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.
public/WebSecurityPolicy.h:
src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay): (WebCore::SecurityOrigin::deprecatedCanDisplay):
  • platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::registerURLSchemeAsLocal): (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal): (WebCore::SchemeRegistry::localURLSchemes): (WebCore::SchemeRegistry::shouldTreatURLAsLocal): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
  • platform/SchemeRegistry.h:

2010-11-30 Ojan Vafai <​ojan@chromium.org>

Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
​https://bugs.webkit.org/show_bug.cgi?id=50288

2010-11-29 Adam Barth <​abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
​https://bugs.webkit.org/show_bug.cgi?id=50182
A display-isolated URL can only be displayed (e.g., put in an iframe,
hyperlinked to) by documents from that scheme. In a sense, this is a
generalization of some of the protections we give file URLs, but
instead of lumping them all together into one "local" bucket, this
patch creates a separate bucket for each scheme.
For a while, I tried using a separate bucket for each origin. That
would have played nicely with what Blob URLs are trying to do, but some
"chrome" URL pages rely on being able to display other chrome URL
pages, even in different origins. For example, the New Tab Page shows
thumbnails from the "thumbnail" host.
This patch also removes a bunch of unused code. I've also propagated
the "deprecated" status of deprecatedCanDisplay to
deprecatedShouldTreatURLAsLocal because that method has no other
callers and is really asking for uppercase/lowercase bugs. I dream of
someday removing these functions.
2010-11-29 Adam Barth <​abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs

​https://bugs.webkit.org/show_bug.cgi?id=50182

This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.

  • public/WebSecurityPolicy.h:
  • src/WebSecurityPolicy.cpp:

2010-11-30 Ojan Vafai <​ojan@chromium.org>

Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
​https://bugs.webkit.org/show_bug.cgi?id=50288

2010-11-29 Adam Barth <​abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
​https://bugs.webkit.org/show_bug.cgi?id=50182
A display-isolated URL can only be displayed (e.g., put in an iframe,
hyperlinked to) by documents from that scheme. In a sense, this is a
generalization of some of the protections we give file URLs, but
instead of lumping them all together into one "local" bucket, this
patch creates a separate bucket for each scheme.
For a while, I tried using a separate bucket for each origin. That
would have played nicely with what Blob URLs are trying to do, but some
"chrome" URL pages rely on being able to display other chrome URL
pages, even in different origins. For example, the New Tab Page shows
thumbnails from the "thumbnail" host.
This patch also removes a bunch of unused code. I've also propagated
the "deprecated" status of deprecatedCanDisplay to
deprecatedShouldTreatURLAsLocal because that method has no other
callers and is really asking for uppercase/lowercase bugs. I dream of
someday removing these functions.
2010-11-29 Adam Barth <​abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs

​https://bugs.webkit.org/show_bug.cgi?id=50182

This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.

  • Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::localSchemes):
7:00 PM Changeset in webkit [73001] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-30 Ojan Vafai <​ojan@chromium.org>

[chromium] Update inaccurate test expectation and mark fast/regex/pcre-test-1.html as
timing out after ​http://trac.webkit.org/changeset/72990/.

  • platform/chromium/test_expectations.txt:
6:51 PM Changeset in webkit [73000] by Chris Fleizach
  • 4 edits
    2 adds in trunk

WebKit duplicates AXValue and AXDescription on abbr
​https://bugs.webkit.org/show_bug.cgi?id=50260

Reviewed by Beth Dakin.

WebCore:

stringValue() and accessibilityDescription() were returning the same value for static text with
an aria-label. Static text elements should not have an accessibility description, they
should only have a stringValue.

Test: platform/mac/accessibility/static-text-with-aria-label.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaAccessibilityDescription):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::text):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • platform/mac/accessibility/static-text-with-aria-label-expected.txt: Added.
  • platform/mac/accessibility/static-text-with-aria-label.html: Added.
6:46 PM Changeset in webkit [72999] by barraclough@apple.com
  • 7 edits in trunk

JavaScriptCore: Fixed review comments following bug #48101.
Mostly typos, plus gave quantifyInfinite a symbolic name.

Reviewed by Darin Adler.

  • yarr/RegexCompiler.cpp:

(JSC::Yarr::RegexPatternConstructor::quantifyAtom):
(JSC::Yarr::RegexPatternConstructor::checkForTerminalParentheses):

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
(JSC::Yarr::Interpreter::matchParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalEnd):

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):

  • yarr/RegexParser.h:

(JSC::Yarr::Parser::parseTokens):
(JSC::Yarr::parse):

LayoutTests: Ooops, file checked in with incorrect properties.

Reviewed by Darin Adler.

  • fast/regex/script-tests/repeat-match-waldemar.js: Removed property svn:executable.
6:20 PM Changeset in webkit [72998] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Qt build.

  • UIProcess/API/qt/qgraphicswkview.cpp:

(QGraphicsWKView::takeSnapshot):
(QGraphicsWKViewPrivate::commitScale):

6:19 PM Changeset in webkit [72997] by Martin Robinson
  • 1 edit
    1 add in trunk/LayoutTests

2010-11-30 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a GTK+ test.

  • platform/gtk/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added. This platform-specific result is needed because of bug #50303.
6:11 PM Changeset in webkit [72996] by andersca@apple.com
  • 16 edits in trunk/WebKit2

Change DrawingArea and DrawingAreaProxy to not inherit from DrawingAreaBase
​https://bugs.webkit.org/show_bug.cgi?id=50300

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaBase::]):
(-[WKView _pageDidEnterAcceleratedCompositing]):
(-[WKView _pageDidLeaveAcceleratedCompositing]):

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::nextDrawingAreaID):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::info):

  • UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):
(WebKit::DrawingArea::DrawingArea):

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::info):

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
(WebKit::LayerBackedDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::TiledDrawingArea):

  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::changeAcceleratedCompositingMode):

6:09 PM Changeset in webkit [72995] by rniwa@webkit.org
  • 7 edits in trunk/WebCore

2010-11-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

[HTML5] Rename member variables of HTMLScriptElement
​https://bugs.webkit.org/show_bug.cgi?id=49705

Renamed m_wasCreatedByParser to m_wasInsertedByParser, m_requested to m_isExternalScript,
m_isEvaluated to m_wasAlreadyStarted, and m_firedLoad to m_haveFiredLoad.

Also made ScriptElement's haveFiredLoadEvent and removed HTMLScriptElement's haveFiredLoadEvent.
This effectively adds the same function to SVGScriptElement, which isn't currently used anywhere.

No new tests are added since this is a refactoring.

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::ScriptElement): (WebCore::ScriptElement::insertedIntoDocument): (WebCore::ScriptElement::childrenChanged): (WebCore::ScriptElement::finishParsingChildren): (WebCore::ScriptElement::requestScript): (WebCore::ScriptElement::evaluateScript): (WebCore::ScriptElement::executeScript): (WebCore::ScriptElement::ignoresLoadRequest):
  • dom/ScriptElement.h: (WebCore::ScriptElement::haveFiredLoadEvent): (WebCore::ScriptElement::setHaveFiredLoadEvent): (WebCore::ScriptElement::wasInsertedByParser): (WebCore::ScriptElement::wasAlreadyStarted):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::HTMLScriptElement): (WebCore::HTMLScriptElement::create): (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren):
  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement): (WebCore::SVGScriptElement::create): (WebCore::SVGScriptElement::svgAttributeChanged): (WebCore::SVGScriptElement::insertedIntoDocument): (WebCore::SVGScriptElement::dispatchLoadEvent): (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren):
  • svg/SVGScriptElement.h:
6:00 PM Changeset in webkit [72994] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

5:59 PM Changeset in webkit [72993] by mrowe@apple.com
  • 5 edits
    1 delete in tags/Safari-534.13

Merge r72989.

5:58 PM Changeset in webkit [72992] by mrowe@apple.com
  • 3 edits in tags/Safari-534.13/WebKit2

Merge r72981.

5:53 PM Changeset in webkit [72991] by Darin Adler
  • 3 edits in trunk/WebCore

Rolled back most of the FileReaderLoader changes to fix 32-bit builds.

  • fileapi/FileReaderLoader.cpp: Changed types back to unsigned from unsigned long long
  • fileapi/FileReaderLoader.h: Ditto.
5:52 PM Changeset in webkit [72990] by barraclough@apple.com
  • 2 edits
    6 adds
    9 deletes in trunk/LayoutTests

LayoutTests/fast/regex currently contains a number of test cases ported from PCRE's test suites.
There are two key problems with these tests:

  • They use their own harness, and cannot be run from jsc without building all of WebKit.
  • They expect PCRE expression syntax, including extended syntax, backwards assertions, etc.

Rubber stamped by Oliver Hunt.

Rewrite all tests to comply to ECMA compatible syntax
(ish - we support octal escapes), and use the normal 'shouldBe' test style.

  • fast/js/resources/standalone-pre.js:

(areArraysEqual):

Fixed bug, where expected is an array we call areArraysEqual,
this should first check that actual is an array.

  • fast/regex/pcre-test-1-expected.txt: Added.
  • fast/regex/pcre-test-1.html: Added.
  • fast/regex/pcre-test-4-expected.txt: Added.
  • fast/regex/pcre-test-4.html: Added.
  • fast/regex/script-tests/pcre-test-1.js: Added.
  • fast/regex/script-tests/pcre-test-4.js: Added.

Added new version of PCRE tests.

  • fast/regex/pcre-test-runner.js: Removed.
  • fast/regex/test1-expected.txt: Removed.
  • fast/regex/test1.html: Removed.
  • fast/regex/test4-expected.txt: Removed.
  • fast/regex/test4.html: Removed.
  • fast/regex/testinput1: Removed.
  • fast/regex/testinput4: Removed.
  • fast/regex/testoutput1: Removed.
  • fast/regex/testoutput4: Removed.

Removed old version of PCRE tests.

5:48 PM Changeset in webkit [72989] by mitz@apple.com
  • 5 edits
    1 delete in trunk

Text search should treat all matches as word-start matches when the target begins with a separator character
​https://bugs.webkit.org/show_bug.cgi?id=50302

Reviewed by Darin Adler.

WebCore:

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::SearchBuffer): Disable the AtWordStarts option if it was specified and
the target string begins with one of the "separator" characters.

LayoutTests:

  • editing/text-iterator/findString.html:
  • editing/text-iterator/findString-expected.txt:
  • platform/mac-leopard/editing/text-iterator: Removed.
  • platform/mac-leopard/editing/text-iterator/findString-expected.txt: Removed.
5:42 PM Changeset in webkit [72988] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Dave Hyatt.

Web Inspector: [CRASH] on "Revert to this revision" of style with import.
​https://bugs.webkit.org/show_bug.cgi?id=50256

Rolled back one line from ​http://trac.webkit.org/changeset/36904 as agreed with
David.

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
5:36 PM Changeset in webkit [72987] by Martin Robinson
  • 4 edits
    2 adds in trunk

2010-11-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
​https://bugs.webkit.org/show_bug.cgi?id=50283

Add platform exceptions for these tests. While this change fixes most issues
with them there are still bugs with our shadow code which prevents a total
pass.

  • platform/gtk/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Added.

2010-11-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
​https://bugs.webkit.org/show_bug.cgi?id=50283

Adjust the mask rectangle for Cairo shadows, so that the origin
is not affected by the scale of the transformation matrix.

  • platform/graphics/ContextShadow.h: Make this Qt-only member global.
  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::beginShadowLayer): Save the original layer area. (WebCore::ContextShadow::endShadowLayer): If the target context has a scale transform, make sure not to scale the blur distance when blitting the shadow.
5:30 PM Changeset in webkit [72986] by mrowe@apple.com
  • 1 copy in tags/Safari-534.13

New tag.

5:27 PM Changeset in webkit [72985] by Darin Adler
  • 14 edits in trunk/WebCore

2010-11-30 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Make ProgressEvent 64-bit instead of 32-bit
​https://bugs.webkit.org/show_bug.cgi?id=50289

  • dom/ProgressEvent.cpp: (WebCore::ProgressEvent::ProgressEvent): Changed arguments to unsigned long long. (WebCore::ProgressEvent::initProgressEvent): Ditto.
  • dom/ProgressEvent.h: Fixed formatting. Changed types to unsigned long long. Made isProgressEvent override private.
  • dom/ProgressEvent.idl: Tweaked formatting and changed types to unsigned long long.
  • fileapi/FileReader.cpp: Removed unneeded includes. Used static on const so we'd get an error if the same constant was in a header. (WebCore::FileReader::didReceiveData): Removed unneeded WTF prefix. (WebCore::FileReader::fireEvent): Got rid of local variables that would narrow bytes loaded and total bytes to 32-bit.
  • fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::didReceiveResponse): Restructured code a bit and added comments. Also added handling for when ArrayBuffer::create returns 0. (WebCore::FileReaderLoader::didReceiveData): Fixed handling of case where more data arrives than is expected so it won't overrun the buffer. Also broke an assertion into two and improved a comment.
  • fileapi/FileReaderLoader.h: Changed bytesLoaded and totalBytes to unsigned long long.
  • fileapi/FileWriter.cpp: (WebCore::FileWriter::fireEvent): Removed narrowing casts in call to ProgressEvent::create.
  • html/canvas/ArrayBuffer.cpp: (WebCore::ArrayBuffer::tryAllocate): Added a comment because the code here seems wrong.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didSendData): Removed narrowing casts in call to XMLHttpRequestProgressEvent::create. (WebCore::XMLHttpRequest::didReceiveData): Removed narrowing casts in call to dispatchProgressEvent.
  • xml/XMLHttpRequestProgressEvent.h: Fixed formatting. Changed types to unsigned long long. Made isXMLHttpRequestProgressEvent override private.
  • xml/XMLHttpRequestProgressEvent.idl: Tweaked formatting and changed types to unsigned long long.
  • xml/XMLHttpRequestProgressEventThrottle.cpp: (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): Changed types to unsigned long long.
  • xml/XMLHttpRequestProgressEventThrottle.h: Changed types to unsigned long long.
5:17 PM Changeset in webkit [72984] by jamesr@google.com
  • 3 edits
    1 copy in branches/chromium/597/WebCore

Merge 72860 - 2010-11-29 Ilya Sherman <​isherman@chromium.org>

Reviewed by Kent Tamura.

Ensure that option elements are rendered with normal font weight on Windows/Linux
​https://bugs.webkit.org/show_bug.cgi?id=50055

  • WebCore.gyp/WebCore.gyp: include themeChromiumSkia.css
  • css/themeChromiumSkia.css: Added. (option): font-weight: normal !important;
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): include themeChromiumSkia.css

TBR=​isherman@chromium.org
BUG=63919

5:11 PM Changeset in webkit [72983] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-11-30 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

WTF project missing build-stopping code from its pre-build event
​https://bugs.webkit.org/show_bug.cgi?id=50281

4:59 PM Changeset in webkit [72982] by Simon Fraser
  • 2 edits in trunk/WebKit2

2010-11-30 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Context menus broken after WebKit2 goes into accelerated composting mode.
​https://bugs.webkit.org/show_bug.cgi?id=50296

Override hitTest: on the WKView to exclude the child layer-backed view from
hit testing, so that context menus work.

  • UIProcess/API/mac/WKView.mm: (-[WKView hitTest:]):
4:56 PM Changeset in webkit [72981] by mrowe@apple.com
  • 3 edits in trunk/WebKit2

Build fix.

Reviewed by Sam Weinig.

  • Configurations/BaseTarget.xcconfig: Don't run Copy Files and Run Script build phases

during installhdrs. It's not necessary, and it results in Xcode attempting to copy the
plug-in shim dylib when it has not yet been built.

  • WebKit2.xcodeproj/project.pbxproj: Stop copying the .xcconfig file in to the application

wrapper.

4:53 PM XBL2UseCases edited by Dimitri Glazkov
(diff)
4:53 PM Changeset in webkit [72980] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • Scripts/webkit2/messages.py:
4:40 PM Changeset in webkit [72979] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-11-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Cleanup UTF8.cpp
​https://bugs.webkit.org/show_bug.cgi?id=49581

Use macros and functions instead of range values directly.

  • wtf/unicode/UTF8.cpp: (WTF::Unicode::inlineUTF8SequenceLength): (WTF::Unicode::UTF8SequenceLength): (WTF::Unicode::convertUTF16ToUTF8): (WTF::Unicode::readUTF8Sequence): (WTF::Unicode::convertUTF8ToUTF16):
  • wtf/unicode/UnicodeMacrosFromICU.h: Added U_IS_SUPPLEMENTARY macro.
4:37 PM Changeset in webkit [72978] by andersca@apple.com
  • 6 edits
    1 move in trunk/WebKit2

Rename DrawingAreaBase.h to DrawingAreaInfo.h.

Reviewed by Sam Weinig.

  • Shared/DrawingAreaInfo.h: Renamed from WebKit2/Shared/DrawingAreaBase.h.

(WebKit::DrawingAreaBase::DrawingAreaInfo::DrawingAreaInfo):
(WebKit::DrawingAreaBase::~DrawingAreaBase):
(WebKit::DrawingAreaBase::info):
(WebKit::DrawingAreaBase::DrawingAreaBase):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/DrawingAreaProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.h:
  • win/WebKit2.vcproj:
4:32 PM Changeset in webkit [72977] by rniwa@webkit.org
  • 8 edits in trunk/LayoutTests

2010-11-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(r72861): editing/selection/click-left-of-rtl-wrapping-text.html and
modify-up-on-rtl-wrapping-text.html fail on all but Mac platform
​https://bugs.webkit.org/show_bug.cgi?id=50204

Fixed the tests. Instead of using "ex" to specify the width of the container div,
the tests now auto-detect the correct width by comparing the computed height to
the expected height deduced from the height of one line and the expected number of lines.

  • editing/selection/click-left-of-rtl-wrapping-text-expected.txt:
  • editing/selection/click-left-of-rtl-wrapping-text.html:
  • editing/selection/modify-up-on-rtl-wrapping-text.html:
4:13 PM Changeset in webkit [72976] by yael.aharon@nokia.com
  • 6 edits
    4 adds in trunk

Progress and meter elements should take a form in their constructor like any other form control.
​https://bugs.webkit.org/show_bug.cgi?id=50195

Reviewed by Darin Adler.

WebCore:

Tests: fast/dom/HTMLMeterElement/meter-element-form.html

fast/dom/HTMLProgressElement/progress-element-form.html

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::create):

  • html/HTMLMeterElement.h:
  • html/HTMLProgressElement.h:
  • html/HTMLTagNames.in:

LayoutTests:

  • fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-element-form.html: Added.
  • fast/dom/HTMLProgressElement/progress-element-form-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-element-form.html: Added.
4:01 PM Changeset in webkit [72975] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-30 Tony Chang <​tony@chromium.org>

Unreviewed, remove dupe expectation for chromium win drt.

  • platform/chromium/drt_expectations.txt:
3:55 PM Changeset in webkit [72974] by tony@chromium.org
  • 5 edits in trunk

2010-11-30 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
​https://bugs.webkit.org/show_bug.cgi?id=49036

No new tests: Covered by plugins/npruntime/get-int-identifier-special-values.html

In ​http://codereview.chromium.org/11574, the forked chromium test
plugin changed how it testGetIntIdentifier to work around a change
caused by a silverlight specific plugin fix:
​http://codereview.chromium.org/11569/diff/1/2

It's not clear to me that this change is needed anymore since
silverlight has had multiple releases, testing without this patch
works on a test windows build, and safari win seems to run silverlight
without this either. Since there's no test for this behavior, I'm
rolling it out so we can match the upstream test.

  • bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant):

2010-11-30 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
​https://bugs.webkit.org/show_bug.cgi?id=49036

  • DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32

for CppVariants.

(LayoutTestController::cppVariantToBool):
(LayoutTestController::cppVariantToInt32):
(LayoutTestController::setDatabaseQuota):
(LayoutTestController::evaluateInWebInspector):
(LayoutTestController::setMockGeolocationError):

3:48 PM Changeset in webkit [72973] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • PluginProcess/mac/PluginProcessShim.cpp:
3:44 PM Changeset in webkit [72972] by andersca@apple.com
  • 6 edits
    1 copy in trunk/WebKit2

Add a simple shim function for Debugger().
​https://bugs.webkit.org/show_bug.cgi?id=50268

Reviewed by Dan Bernstein.

  • PluginProcess/PluginProcess.h:
  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::initShouldCallRealDebugger):
We only want to call the real Debugger() function when USERBREAK is set.

(WebKit::shouldCallRealDebugger):
Return whether USERBREAK is set.

(WebKit::PluginProcess::initializeShim):
Initialize the shim.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):
Call PluginProcess::initializeShim.

  • PluginProcess/mac/PluginProcessShim.cpp:

(WebKit::WebKitPluginProcessShimInitialize):
This now takes a struct of callbacks.

(WebKit::shimDebugger):
Call the shouldCallDebugger function. If it returns true, the real Debugger() function should be called.

  • PluginProcess/mac/PluginProcessShim.h:
  • WebKit2.xcodeproj/project.pbxproj:
3:39 PM XBL2UseCases edited by Dimitri Glazkov
(diff)
3:31 PM Changeset in webkit [72971] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-30 Tony Chang <​tony@chromium.org>

Unreviewed, try to green the chromium win DRT bot.

  • platform/chromium/drt_expectations.txt:
3:27 PM Changeset in webkit [72970] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-30 Ojan Vafai <​ojan@chromium.org>

[chromium] Mark failing tests after ​http://trac.webkit.org/changeset/72962/
to green the chromium tree.

  • platform/chromium/test_expectations.txt:
3:21 PM Changeset in webkit [72969] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2010-11-30 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Computing style on a stale node while sending pending accessibility notification.
​https://bugs.webkit.org/show_bug.cgi?id=50162

Retain node pointer members of AccessibilityImageMapLink.

Test: accessibility/image-map-title-causes-crash.html

  • accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::parentObject): (WebCore::AccessibilityImageMapLink::anchorElement): (WebCore::AccessibilityImageMapLink::url): (WebCore::AccessibilityImageMapLink::elementRect):
  • accessibility/AccessibilityImageMapLink.h: (WebCore::AccessibilityImageMapLink::areaElement): (WebCore::AccessibilityImageMapLink::mapElement): (WebCore::AccessibilityImageMapLink::node):
  • dom/Document.cpp: (WebCore::Document::clearAXObjectCache):

2010-11-30 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Computing style on a stale node while sending pending accessibility notification.
​https://bugs.webkit.org/show_bug.cgi?id=50162

  • accessibility/image-map-title-causes-crash-expected.txt: Added.
  • accessibility/image-map-title-causes-crash.html: Added.
3:19 PM XBL2UseCases created by Dimitri Glazkov
3:17 PM Changeset in webkit [72968] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-11-30 James Robinson <​jamesr@chromium.org>

Reviewed by Tony Chang.

Build fix - add parens in foo
bar && baz to make gcc happy

​https://bugs.webkit.org/show_bug.cgi?id=50276

gcc 4.4 warns that statements of the form "foo
bar && baz". It wants

parens around the "bar && baz" part to make it clear which way the logical
operators bind.

  • editing/TextIterator.cpp: (WebCore::SearchBuffer::search):
2:57 PM Changeset in webkit [72967] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

Fixed a crash seen when using a PageAllocation to store itself.

Reviewed by Gavin Barraclough.

  • wtf/PageAllocation.h:

(WTF::PageAllocation::systemDeallocate): Zero out m_base before unmapping
it, in case unmapping m_base unmaps the PageAllocation.

  • wtf/BumpPointerAllocator.h:

(WTF::BumpPointerPool::destroy): Now this work-around isn't needed!

2:50 PM Changeset in webkit [72966] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-30 Eric Seidel <​eric@webkit.org>

Reviewed by Tony Chang.

update-webkit should call git fetch before git svn rebase
​https://bugs.webkit.org/show_bug.cgi?id=50273

After discussion on webkit-dev, we've decided to move the "default"
git setup to pulling updates from git.webkit.org in preference
to rebuilding the local svn index using git svn fetch every time.

This change should have no effect on people using the "old" git setup
and should dramatically increase the speed of updates for those using
the "new" git setup along with update-webkit. I'm about to move the
EWS and other queues over to this setup once this lands.

  • Scripts/update-webkit:
2:30 PM Changeset in webkit [72965] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-11-30 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Update yasm entry in DEPS to match downstream
​https://bugs.webkit.org/show_bug.cgi?id=50274

​http://src.chromium.org/viewvc/chrome?view=rev&revision=67540 changed the downstream DEPS rule
for yasm to pull unconditionally rather than pulling in each deps_os. This changes the WebKit
chromium DEPS to match.

  • DEPS:
2:18 PM Changeset in webkit [72964] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2010-11-30 Ojan Vafai <​ojan@chromium.org>

[chromium] Add new expected result after ​http://trac.webkit.org/changeset/72689
and update test expectations to match the builders and pull the appropriate bits
from the downstream expectations file.

  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium/test_expectations.txt:
2:07 PM Changeset in webkit [72963] by mario@webkit.org
  • 4 edits in trunk

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

GTK: AX: implement press in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36146

Unskipped test accessibility/label-element-press.html.

  • platform/gtk/Skipped: Unskip passing test.

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

GTK: AX: implement press in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36146

Implement AccessibilityUIElement::press() for GTK.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::press): Implemented.
1:57 PM Changeset in webkit [72962] by dbates@webkit.org
  • 5 edits
    12 adds in trunk

2010-11-30 Daniel Bates <​dbates@rim.com>

Reviewed by David Hyatt.

Focused <area> should use CSS properties of <area> instead of associated <img>
​https://bugs.webkit.org/show_bug.cgi?id=49888

Fixes an issue where the CSS properties of an <area> were not used when
the <area> was focused.

Currently, when focusing an <area> (say by pressing option + tab in Mac
Safari) we use the CSS style information for the <img> associated with
the <area>. Instead, we should use the CSS style information for the
focused <area>. In particular, this will make the us honor the outline-
color property of a focused <area> when drawing its focus ring.

Tests: fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html

fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html
fast/images/imagemap-focus-ring-outline-color.html

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRing): Use the style information of the focused <area> when drawing the focus ring for it.

2010-11-30 Daniel Bates <​dbates@rim.com>

Reviewed by David Hyatt.

Focused <area> should use CSS properties of <area> instead of associated <img>
​https://bugs.webkit.org/show_bug.cgi?id=49888

Updated the test result for test fast/images/imagemap-focus-ring.html. Added
test to verify that the color of the focus ring for a focused <area> is
the outline-color specified by the :focus pseudo-class .

Also, added tests to ensure that outline-color is not inherited (by default) as per
section 18.4 of the CSS 2.1 spec <​http://www.w3.org/TR/CSS2/ui.html#dynamic-outlines>,
unless explicitly inherited.

  • fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html: Added.
  • fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html: Added.
  • fast/images/imagemap-focus-ring-outline-color.html: Added.
  • platform/mac/fast/images/imagemap-focus-ring-expected.checksum: Updated result.
  • platform/mac/fast/images/imagemap-focus-ring-expected.png: Ditto.
  • platform/mac/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/mac/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
1:56 PM Changeset in webkit [72961] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-11-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Darin Adler.

m_hasNonEnumerableProperties is never initialized in Structure
​https://bugs.webkit.org/show_bug.cgi?id=50266

  • runtime/Structure.cpp: (JSC::Structure::Structure): initialize member variable.
1:49 PM Changeset in webkit [72960] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-11-30 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

[chromium] enable WebCore compiler warnings on Linux take 3
​https://bugs.webkit.org/show_bug.cgi?id=50258

  • WebCore.gyp/WebCore.gyp:
1:38 PM Changeset in webkit [72959] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-30 Ojan Vafai <​ojan@chromium.org>

[chromium] Update expectations to de-orange the builders.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
1:16 PM Changeset in webkit [72958] by mario@webkit.org
  • 8 edits in trunk

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement ROLE_COMBO_BOX
​https://bugs.webkit.org/show_bug.cgi?id=25678

Implement the remaining bits for combo boxes.

This patch finishes the implementation, from the point of view of
the Atk library, of those objects exposed to ATK as combo boxes,
and their related elements (menus and menu items). It therefore
implements the proper interfaces for each type of object related
to combo boxes (AtkSelection for the combo box, AtkText for every
menu item and AtkAction for the combo box, the menu and the menu
items), takes care of emitting the proper signals when focus or a
given a selection changes and adds a new unit test to check all
this new stuff.

Make possible to ask an AccessibleMenuListOption for a sensible
string representation, so far only available through the private
and MSAA related method nameForMSAA. Just moved the implementation
of that method to an overriden version of stringValue(), which is
platform independent, and called that from nameForMSAA().

  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListOption.cpp: (WebCore::AccessibilityMenuListOption::nameForMSAA): Just call to stringValue(), which holds from now on that used to be here. (WebCore::AccessibilityMenuListOption::stringValue): New, override of AccessibilityObject::stringValue() to return a proper string.

Emit the missing signals when a selection is made.

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification): Emit the usual 'focus' signals when a selection is made over the combo box.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject): Ensure the EXPANDABLE and EXPANDED Atk states are added to the state set when needed. (listObjectForSelection): New, returns the proper list object (the one holding the list of available options as its children) for an specific AtkObject implementing AtkSelection. This is needed because sometimes the selectable options are not directly children of the AtkSelection object (i.e. a combo box has a 'menu' object as its only child of it, holding the list of options as children). (optionFromList): Use listObjectForSelection() to get the actual object holding the list of children as the available options. (optionFromSelection): Add support for combo boxes. (webkit_accessible_selection_add_selection): Ditto. (webkit_accessible_selection_clear_selection): Ditto. (webkit_accessible_selection_get_selection_count): Ditto. (webkit_accessible_selection_is_child_selected): Ditto. (webkit_accessible_selection_remove_selection): Ditto. (webkit_accessible_text_get_text): Makes sure stringValue() is considered to get the result substring when it was already considered when checking the maximum text length for the object. (getInterfaceMaskFromObject): Make sure the AtkSelection interface is implemented for the combo boxes, that the AtkText is implemented for the menu items and that the AtkAction interface is now implemented for every object (WebCore will decide what to do).

Avoid a segfault crash when using this from unit tests.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show): Make sure we got a valid GdkWindow before calling gdk_window_get_origin() over it.

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement ROLE_COMBO_BOX
​https://bugs.webkit.org/show_bug.cgi?id=25678

New test to check the implementation of the combo boxes.

  • tests/testatk.c: (testWebkitAtkComboBox): New test, checking that the roles and the implemented interfaces for a combo box and its descendants work. (main): Added the new unit test.
1:05 PM Changeset in webkit [72957] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Pass the plug-in process shim in DYLD_INSERT_LIBRARIES when launching the plug-in process
​https://bugs.webkit.org/show_bug.cgi?id=50262

Reviewed by Sam Weinig.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

Add an EnvironmentVariables class that allows for easy modification of the environment variables
passed to posix_spawn.

(WebKit::ProcessLauncher::launchProcess):
When spawning the plug-in process, insert the plug-in process shim.

12:59 PM Changeset in webkit [72956] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-30 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] GraphicsContext: Avoid unnecessarily copying the painter's QTransform

Stash the transform in a const reference (QPainter::transform() returns one)
instead of making a copy in the shadow drawing parts of fillPath, strokePath and fillRect.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
12:53 PM Changeset in webkit [72955] by andersca@apple.com
  • 2 edits
    3 adds in trunk/WebKit2

Add plug-in process shim
​https://bugs.webkit.org/show_bug.cgi?id=50261

Reviewed by Sam Weinig.

  • Configurations/PluginProcessShim.xcconfig: Added.
  • PluginProcess/mac/PluginProcessShim.cpp: Added.

(PluginProcessShimInitialize):

  • PluginProcess/mac/PluginProcessShim.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
12:41 PM Changeset in webkit [72954] by vangelis@chromium.org
  • 14 edits in trunk

2010-11-29 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

Provide more fine grained control to ports over when to turn on accelerated
compositing.
​https://bugs.webkit.org/show_bug.cgi?id=49998

As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
has now been replaced by allowedCompositingTriggers which returns a bitfield of
all the features which can trigger the compositor.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/ChromeClientImpl.h:

2010-11-29 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

Provide more fine grained control to ports over when to turn on accelerated
compositing.
​https://bugs.webkit.org/show_bug.cgi?id=49998

As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
has now been replaced by allowedCompositingTriggers which returns a bitfield of
all the features which can trigger the compositor.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::allowedCompositingTriggers):
  • WebCoreSupport/ChromeClientQt.h:

2010-11-30 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Simon Fraser.

Provide more fine grained control to ports over when to turn on
accelerated compositing.
​https://bugs.webkit.org/show_bug.cgi?id=49998

The RenderLayerCompositor now checks with the chrome client whether
3d transforms, video, plugins, canvas and animation require
switching over to the composited path. Layers that overlap composited
content will still turn into composited layers regardless of the
setting.

  • css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
  • page/ChromeClient.h: (WebCore::ChromeClient::allowedCompositingTriggers):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::canRender3DTransforms): (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::currentTransform):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateLayerTransform):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags): (WebCore::RenderLayerCompositor::canRender3DTransforms): (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForTransform): (WebCore::RenderLayerCompositor::requiresCompositingForVideo): (WebCore::RenderLayerCompositor::requiresCompositingForCanvas): (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
  • rendering/RenderLayerCompositor.h:
12:35 PM Changeset in webkit [72953] by dbates@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2010-11-30 Daniel Bates <​dbates@rim.com>

Reviewed by Alexey Proskuryakov.

Change and focus events happen in different order if using tab vs. clicking
​https://bugs.webkit.org/show_bug.cgi?id=6181

Tests to ensure adherence to section 7.4.2 of the HTML5 spec.
<​http://www.w3.org/TR/html5/editing.html#focus-management> with respect to
focusing on an <input>, modifying its contents, and defocusing it either by
pressing the tab key or clicking on another element.

  • fast/events/check-defocus-event-order-when-triggered-by-mouse-click-expected.txt: Added.
  • fast/events/check-defocus-event-order-when-triggered-by-mouse-click.html: Added.
  • fast/events/check-defocus-event-order-when-triggered-by-tab-expected.txt: Added.
  • fast/events/check-defocus-event-order-when-triggered-by-tab.html: Added.
  • fast/events/resources/record-events.js: Added. (registerElementsAndEventsToRecord): (beginRecordingEvents.callback): (beginRecordingEvents): (endRecordingEvents.callback): (endRecordingEvents): (_processEachRegisteredElement): (_recordEvent): (checkThatEventsFiredInOrder.eventTarget): (checkThatEventsFiredInOrder.elementIdOrTagName): (checkThatEventsFiredInOrder):
12:27 PM Changeset in webkit [72952] by xji@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-30 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Scroll position might not be exactly the same after page ZoomIn and ZoomOut, for example, they are not exactly the same in Windows platform.
Change to test that the scroll position before and after ZoomIn/Out are close enough.
Rebaseline horizontal-scrollbar-when-dir-change in Win7.

  • fast/dom/horizontal-scrollbar-in-rtl.html:
  • platform/win/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt:
12:18 PM Changeset in webkit [72951] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-11-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Plug leak in SoupCache
​https://bugs.webkit.org/show_bug.cgi?id=50142

Free the cache file contents when we don't need them anymore.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_load):
12:02 PM Changeset in webkit [72950] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

Fix the Windows build by copying WKFindOptions.h into WebKitOutputDir with the other headers.

  • win/WebKit2Generated.make:
12:00 PM Changeset in webkit [72949] by ojan@chromium.org
  • 58 edits
    2 adds in trunk/LayoutTests

2010-11-30 Ojan Vafai <​ojan@chromium.org>

[chromium] New expected result after ​http://trac.webkit.org/changeset/72926/.
That patch unintentionally fixed a bug where the skia codepath was drawing paths twice.
The new results better match the platform/mac results (borders are grey instead of black).

  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum: Added.
  • platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegionA-expected.checksum:
  • platform/chromium-linux/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.checksum:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.checksum:
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.png:
  • platform/chromium-linux/svg/custom/recursive-gradient-expected.checksum:
  • platform/chromium-linux/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.checksum:
  • platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.checksum:
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.png:
  • platform/chromium-win/svg/custom/pattern-y-offset-expected.checksum:
  • platform/chromium-win/svg/custom/pattern-y-offset-expected.png:
  • platform/chromium-win/svg/custom/recursive-gradient-expected.checksum:
  • platform/chromium-win/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.checksum:
  • platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium/test_expectations.txt:
11:57 AM Changeset in webkit [72948] by abecsi@webkit.org
  • 10 edits in trunk/WebCore

2010-11-30 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] Make QtWebKit with V8 build on Linux.
​https://bugs.webkit.org/show_bug.cgi?id=50244

No new tests needed.

  • WebCore.pri: add missing idl file
  • WebCore.pro: enable Linux build
  • bindings/scripts/CodeGeneratorV8.pm: add missing headers
  • bindings/v8/ScriptControllerQt.cpp: fix instantiation (WebCore::ScriptController::qtScriptEngine):
  • bindings/v8/V8GCController.cpp: fix guard (WebCore::V8GCController::checkMemoryUsage):
  • inspector/CodeGeneratorInspector.pm: add missing header
  • loader/ResourceLoadScheduler.cpp: ditto
  • loader/cache/MemoryCache.cpp: ditto
  • loader/loader.cpp: ditto
11:48 AM Changeset in webkit [72947] by hyatt@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=50183

Reviewed by Simon Fraser.

Code got commented out by accident during render tree refactoring last year. Put the code back in, since
it hurts performance to have that line commented out.

In order to put this code back in, I had to fix some bugs with preferred width computations and
overflow: scroll. Make the pref widths computation create the scrollbar if it doesn't exist yet.

Make sure the scrollbar size is included prior to checking for defined width/min-width/max-width values. Otherwise
the scrollbar inflates the width beyond the fixed size that was specified.

For table cells, there is an additional wrinkle. Make sure not to include the scrollbar size as part of the minimum
intrinsic width so that we don't incorrectly grow.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::computePreferredLogicalWidths):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):

11:44 AM Changeset in webkit [72946] by mitz@apple.com
  • 2 edits in trunk/WebKit2

Try to fix the Windows build.

  • win/WebKit2.vcproj:
11:35 AM Changeset in webkit [72945] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed.

Submitted for Kenji Imasaki <​imasaki@chromium.org>.

Update test expectations for Chromium to enable expectation analyzer for video.

  • platform/chromium/test_expectations.txt:
11:35 AM Changeset in webkit [72944] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-11-30 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

Attempt to fix windows debug chromium build.

  • html/TimeInputType.cpp: Added include providing isfinite.
11:33 AM Changeset in webkit [72943] by mitz@apple.com
  • 1 edit
    1 copy
    1 add in trunk/LayoutTests

Added Leopard-specific results for editing/text-iterator/findString.html. In the Leopard version
of ICU, the full stop character is a word separator, so an at-word-starts search for "org" in
"webkit.org" matches.

  • platform/mac-leopard/editing/text-iterator: Added.
  • platform/mac-leopard/editing/text-iterator/findString-expected.txt: Copied from LayoutTests/editing/text-iterator/findString-expected.txt.
11:31 AM Changeset in webkit [72942] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-30 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating test expectations.

  • platform/chromium/test_expectations.txt:
11:31 AM Changeset in webkit [72941] by Darin Adler
  • 5 edits in trunk/WebCore

2010-11-30 Darin Adler <Darin Adler>

Reviewed by Jon Honeycutt.

DOM binding code generator scripts import unused File::stat Perl module
​https://bugs.webkit.org/show_bug.cgi?id=50250

  • bindings/scripts/CodeGeneratorCPP.pm: Removed "using File::stat".
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
11:27 AM Changeset in webkit [72940] by mihaip@chromium.org
  • 5 edits in trunk/WebKitTools

2010-11-29 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

config.webkit_base_dir returns a path with a trailing slash
​https://bugs.webkit.org/show_bug.cgi?id=50197

config.webkit_base_dir() should return a path without a trailing slash,
like all the other methods that return paths.

Undoes MockFileSytem changes by r72640, since they're no longer
necessary for GetBaselinesTest to pass.

  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
11:23 AM Changeset in webkit [72939] by mihaip@chromium.org
  • 6 edits in trunk/WebKitTools

2010-11-30 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: baseline display tweaks
​https://bugs.webkit.org/show_bug.cgi?id=50207

Determine which baselines were used when running the tests and higlight
them in the UI. Sort platform names alphabetically.

Also makes the server URL be launched in the user's browser
automatically.

  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
11:16 AM Changeset in webkit [72938] by pfeldman@chromium.org
  • 11 edits in trunk/WebCore

2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement "Revert to this revision" in resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=50107

  • inspector/Inspector.idl:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::setStyleSheetText2):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::reparseStyleSheet):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get contentTimestamp): (WebInspector.Resource.prototype.setInitialContent): (WebInspector.Resource.prototype.isLocallyModified): (WebInspector.Resource.prototype.setContent.else.finished): (WebInspector.Resource.prototype.setContent): (WebInspector.Resource.prototype.revertToThis.callback): (WebInspector.Resource.prototype.revertToThis): (WebInspector.Resource.prototype.get baseRevision): (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.FrameResourceTreeElement.prototype._contentChanged): (WebInspector.ResourceRevisionTreeElement): (WebInspector.ResourceRevisionTreeElement.prototype.onattach): (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._editLine): (WebInspector.SourceView.prototype._editLineComplete): (WebInspector.SourceView.prototype._revertEditLine):
11:14 AM Changeset in webkit [72937] by mitz@apple.com
  • 14 edits
    1 add in trunk

WebKit2: Injected bundle support for <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
​https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Anders Carlsson.

  • Shared/API/c/WKFindOptions.h: Added. Moved the definition of WKFindOptions here from WKPage.h.
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toFindOptions): Moved from WKAPICast.h.

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.h:
  • WebKit2.xcodeproj/project.pbxproj: Added WKFindOptions.h.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageFindString): Added.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findStringFromInjectedBundle): Added.

  • WebProcess/WebPage/WebPage.h:

WebKitTools: <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
​https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Anders Carlsson.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::findString): Added.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests: <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
​https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Anders Carlsson.

  • platform/mac-wk2/Skipped: Removed editing/text-iterator/findString.html.
11:02 AM Changeset in webkit [72936] by Adam Roben
  • 2 edits in trunk/WebCore

Clean up WebCore.vcproj's bindings filter

I added files that we compile (via an all-in-one file) but weren't in
the .vcproj, removed files that no longer exist, and added the scripts
we use.

Fixes <​http://webkit.org/b/50248> WebCore.vcproj's bindings filter is
out-of-date

Reviewed by Darin Adler.

  • WebCore.vcproj/WebCore.vcproj:
10:52 AM Changeset in webkit [72935] by Dimitri Glazkov
  • 4 edits
    2 copies in branches/chromium/597

Merge 72807 - 2010-11-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION (r71934): Main search field at Apple tech specs does not accept typing
​https://bugs.webkit.org/show_bug.cgi?id=49868

  • fast/forms/disabled-search-input-expected.txt: Added.
  • fast/forms/disabled-search-input.html: Added.

2010-11-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION (r71934): Main search field at Apple tech specs does not accept typing
​https://bugs.webkit.org/show_bug.cgi?id=49868

The problem here was that the inner text element of search input was first laid out as
disabled and thus with a 0-height. This would prevent a hit test to ever reach it, even
if it's enabled.

Test: fast/forms/disabled-search-input.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasLineIfEmpty): Removed a check for textarea that is no longer necessary.
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty): Added an override to ensure that

an empty inner text element is always one-line high.

TBR=Dimitri Glazkov
Review URL: ​http://codereview.chromium.org/5389004

10:45 AM Changeset in webkit [72934] by Dimitri Glazkov
  • 1 add in branches/chromium/597/codereview.settings

Added codereview settings file.

10:43 AM Changeset in webkit [72933] by jamesr@google.com
  • 5 edits
    15 deletes in branches/chromium/597

Merge 72864 - 2010-11-29 James Robinson <​jamesr@chromium.org>

BUG=64654
TBR=jamesr

[chromium] REGRESSION(72470): Crash in skia on some images
​https://bugs.webkit.org/show_bug.cgi?id=50201

Reverts r72470

  • platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/image-rescale-expected.checksum: Removed.
  • platform/mac/svg/custom/image-rescale-expected.png: Removed.
  • platform/mac/svg/custom/image-rescale-expected.txt: Removed.
  • platform/mac/svg/custom/image-rescale-scroll-expected.checksum: Removed.
  • platform/mac/svg/custom/image-rescale-scroll-expected.png: Removed.
  • platform/mac/svg/custom/image-rescale-scroll-expected.txt: Removed.
  • platform/mac/test_expectations.txt:
  • svg/custom/image-rescale-scroll.html: Removed.
  • svg/custom/image-rescale.svg: Removed.
  • svg/custom/resources/image-rescale.jpg: Removed.

2010-11-29 James Robinson <​jamesr@chromium.org>

[chromium] REGRESSION(72470): Crash in skia on some images
​https://bugs.webkit.org/show_bug.cgi?id=50201

Reverts r72470

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::drawResampledBitmap):

TBR=​jamesr@google.com

10:35 AM Changeset in webkit [72932] by Adam Roben
  • 2 edits in trunk/WebCore

Move JSIDB* files to the DerivedSources filter

This correctly reflects their location on disk. (They were formerly
listed under bindings/js.)

  • WebCore.vcproj/WebCore.vcproj:
10:31 AM Changeset in webkit [72931] by xji@chromium.org
  • 5 edits
    2 adds in trunk

2010-11-30 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Remove clampNegativeToZero in adjustScrollPositionWithinRange.
​https://bugs.webkit.org/show_bug.cgi?id=50203

  • platform/ScrollView.cpp: (WebCore::ScrollView::adjustScrollPositionWithinRange):

2010-11-30 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Unskip fast/dom/horizontal-scrollbar-in-rtl.html and fast/dom/horizontal-scrollbar-when-dir-change.html in Chromium and Win7.
Rebaseline after r72852.
​https://bugs.webkit.org/show_bug.cgi?id=50203

  • platform/chromium/test_expectations.txt:
  • platform/win/Skipped:
  • platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/win/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
10:20 AM Changeset in webkit [72930] by Adam Roben
  • 2 edits in trunk/LayoutTests

Try to fix timing-out tests on WebKit2 by skipping an earlier test

I'll file a bug if this fixes the problem.

  • platform/mac-wk2/Skipped:
10:20 AM Changeset in webkit [72929] by Adam Roben
  • 2 edits in trunk/WebCore

Remove duplicate files from WebCore.vcproj

Rubber-stamped by Steve Falkenburg.

  • WebCore.vcproj/WebCore.vcproj:
10:20 AM Changeset in webkit [72928] by Adam Roben
  • 2 edits in trunk/WebCore

Let VS do its thang with WebCore.vcproj

I just removed and readded AnimationBase.cpp.

Rubber-stamped by Steve Falkenburg.

  • WebCore.vcproj/WebCore.vcproj:
10:17 AM Changeset in webkit [72927] by mario@webkit.org
  • 3 edits
    2 adds in trunk

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

ASSERT failing for combo boxes when selection changes
​https://bugs.webkit.org/show_bug.cgi?id=50062

  • fast/forms/select-option-accesskey-crash-expected.txt: Added.
  • fast/forms/select-option-accesskey-crash.html: Added

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

ASSERT failing for combo boxes when selection changes
​https://bugs.webkit.org/show_bug.cgi?id=50062

Don't call listBoxOnChange for elements using menu lists.

Test: fast/forms/select-option-accesskey-crash.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::accessKeySetSelectedIndex): Extra check to decide whether to call menuListOnChange() or listBoxOnChange() instead of always calling listBoxOnChange().
10:13 AM Changeset in webkit [72926] by andreas.kling@nokia.com
  • 37 edits in trunk

2010-11-30 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument.
​https://bugs.webkit.org/show_bug.cgi?id=48516

No new tests, this is refactoring only.

fillPath() -> fillPath(const Path&)
strokePath() -> strokePath(const Path&)
clipPath(WindRule) -> clipPath(const Path&, WindRule)

drawPath() was only used by CG, so made it PLATFORM(CG) specific.

The Qt, CG and Cairo implementations are best-effort.
For the rest, I've put beginPath/addPath and FIXMEs in the three affected methods.

  • WebCore.exp.in:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke):
  • inspector/InspectorController.cpp: (WebCore::drawOutlinedQuad):
  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
  • mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clipPath):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse): (WebCore::addConvexPolygonToPath): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::clipConvexPolygon): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::clipPath):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillPath):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clipPath):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clipPath):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
  • rendering/RenderSVGResource.h: (WebCore::RenderSVGResource::postApplyResource):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::pathOnlyClipping):
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourceGradient.h:
  • rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::postApplyResource):
  • rendering/RenderSVGResourcePattern.h:
  • rendering/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::postApplyResource):
  • rendering/RenderSVGResourceSolidColor.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::finishRenderSVGContent):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::fillAndStrokePath):
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::releasePaintingResource): (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting): (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
  • rendering/svg/SVGInlineTextBox.h:
  • svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):

2010-11-30 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument
​https://bugs.webkit.org/show_bug.cgi?id=48516

  • UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::draw):
10:00 AM Changeset in webkit [72925] by satish@chromium.org
  • 11 edits in trunk/LayoutTests

2010-11-30 Satish Sampath <​satish@chromium.org>

Unreviewed, updating a speech input pixel test expectations with new baselines.

  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium/test_expectations.txt:
9:54 AM Changeset in webkit [72924] by ap@apple.com
  • 4 edits
    4 adds in trunk

Reviewed by Darin Adler and Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=44152
<rdar://problem/8324423> CSSOM should match DOM in discarding wrapper-less parents.

We have existing behaviors where parent objects in detached subtrees are not preserved:

  • if a root of a node tree doesn't have a wrapper, it's immediately destroyed, making its children parentNode attribute null;
  • relationship between a <style> or <link> node and its stylesheet is immediately broken when the node is removed from document (in this case, regardless of wrapper existence).

Both match Firefox. For consistency, CSSOM should do the same. In fact, it already partially
does - CSSRule.parentRule gets zeroed out when the parent rule is destroyed.

Tests: fast/dom/StyleSheet/detached-parent-rule-without-wrapper.html

fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html

  • css/StyleSheet.cpp: (WebCore::StyleSheet::~StyleSheet): Clear out child rule parent.
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::insertedIntoDocument): Keep the new assertion from firing. This function was adding a rule to style sheet, without telling the rule about it.
9:53 AM Changeset in webkit [72923] by sfalken@apple.com
  • 22 edits
    33 adds in trunk

2010-11-30 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

All projects on Windows should use cmd files for build events
​https://bugs.webkit.org/show_bug.cgi?id=50213

  • WebKit.vcproj/InterfacesCommon.vsprops:
  • WebKit.vcproj/InterfacesPostBuild.cmd: Added.
  • WebKit.vcproj/InterfacesPreBuild.cmd: Added.
  • WebKit.vcproj/WebKitGUIDCommon.vsprops:
  • WebKit.vcproj/WebKitGUIDPostBuild.cmd: Added.
  • WebKit.vcproj/WebKitGUIDPreBuild.cmd: Added.
  • WebKit.vcproj/WebKitLibCommon.vsprops:
  • WebKit.vcproj/WebKitLibPostBuild.cmd: Added.
  • WebKit.vcproj/WebKitLibPreBuild.cmd: Added.

2010-11-30 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

All projects on Windows should use cmd files for build events
​https://bugs.webkit.org/show_bug.cgi?id=50213

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
  • WebCore.vcproj/QTMovieWinPostBuild.cmd: Added.
  • WebCore.vcproj/QTMovieWinPreBuild.cmd: Added.
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCorePostBuild.cmd: Added.
  • WebCore.vcproj/WebCorePreBuild.cmd: Added.

2010-11-30 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

All projects on Windows should use cmd files for build events
​https://bugs.webkit.org/show_bug.cgi?id=50213

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
  • DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
  • DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
  • DumpRenderTree/win/ImageDiffCommon.vsprops:
  • DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
  • DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
  • MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
  • MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
  • MiniBrowser/MiniBrowserPostBuild.cmd: Added.
  • MiniBrowser/MiniBrowserPreBuild.cmd: Added.
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
  • TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
  • WebKitAPITest/WebKitAPITestCommon.vsprops:
  • WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
  • WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
  • WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
  • WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
  • WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
  • WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
  • WinLauncher/WinLauncherCommon.vsprops:
  • WinLauncher/WinLauncherPostBuild.cmd: Added.
  • WinLauncher/WinLauncherPreBuild.cmd: Added.

2010-11-30 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

All projects on Windows should use cmd files for build events
​https://bugs.webkit.org/show_bug.cgi?id=50213

  • win/WebKit2Common.vsprops:
  • win/WebKit2WebProcessCommon.vsprops:
  • win/WebKit2WebProcessPostBuild.cmd: Added.
  • win/WebKit2WebProcessPreBuild.cmd: Added.
  • win/WebKitPostBuild.cmd: Added.
  • win/WebKitPreBuild.cmd: Added.
  • win/WebKitPreLink.cmd: Added.
9:48 AM Changeset in webkit [72922] by ojan@chromium.org
  • 16 edits
    5 adds in trunk/LayoutTests

2010-11-30 Ojan Vafai <​ojan@chromium.org>

[chromium] Rebaselines. Details below.

  • platform/chromium-linux/fast/overflow/overflow-update-transform-expected.checksum: Added.
  • platform/chromium-linux/fast/overflow/overflow-update-transform-expected.png: Added. Just scrollbar pixel differences.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png: ​https://bugs.webkit.org/show_bug.cgi?id=50206
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png:
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.txt: Added. Completes ​http://trac.webkit.org/changeset/72875/
  • platform/chromium-win/fast/overflow/overflow-update-transform-expected.checksum: Added.
  • platform/chromium-win/fast/overflow/overflow-update-transform-expected.png: Added. Just scrollbar pixel differences.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png: ​https://bugs.webkit.org/show_bug.cgi?id=50206
  • platform/chromium/test_expectations.txt:
9:34 AM Changeset in webkit [72921] by Dimitri Glazkov
  • 1 copy in branches/chromium/597

Branching Chromium 597

9:18 AM Changeset in webkit [72920] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-30 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating test expectations.

  • platform/chromium/test_expectations.txt:
8:58 AM Changeset in webkit [72919] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-30 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

[Qt] Early return if setResizesToContentsUsingLayoutSize() is called with already-set size

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setResizesToContentsUsingLayoutSize):
8:47 AM Changeset in webkit [72918] by apavlov@chromium.org
  • 5 edits in trunk/WebCore

2010-11-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72914.
​http://trac.webkit.org/changeset/72914
​https://bugs.webkit.org/show_bug.cgi?id=50241

"pfeldman has a revision management patch both for CSS and JS"
(Requested by apavlov on #webkit).

  • English.lproj/localizedStrings.js:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::reparseStyleSheet):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleSheet.prototype.getText): (WebInspector.CSSStyleSheet.prototype.setText):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceRevisionTreeElement.prototype.onattach): (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart):
8:29 AM Changeset in webkit [72917] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-11-30 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

New fast canvas test to ensure correct behavior of canvas with
drawImage + shadow after scaling
​https://bugs.webkit.org/show_bug.cgi?id=50202

The shadow offsets of the drawn images must not be affected by the
scaling transformation.

  • fast/canvas/canvas-scale-drawImage-shadow-expected.txt: Added.
  • fast/canvas/canvas-scale-drawImage-shadow.html: Added.
  • fast/canvas/script-tests/canvas-scale-drawImage-shadow.js: Added.
8:26 AM Changeset in webkit [72916] by Patrick Gansterer
  • 1 edit
    2 adds in trunk/WebKit/wince

2010-11-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Add WebView
​https://bugs.webkit.org/show_bug.cgi?id=50216

  • WebView.cpp: Added.
  • WebView.h: Added.
7:33 AM Changeset in webkit [72915] by satish@chromium.org
  • 6 edits in trunk

2010-11-25 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Fix rendering of speech button when setting the attribute dynamically.
​https://bugs.webkit.org/show_bug.cgi?id=50077

  • fast/speech/input-appearance-speechbutton.html:

2010-11-25 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Fix rendering of speech button when setting the attribute dynamically.
​https://bugs.webkit.org/show_bug.cgi?id=50077

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::speechAttributeChanged):
  • rendering/RenderTextControlSingleLine.h:
7:28 AM Changeset in webkit [72914] by apavlov@chromium.org
  • 5 edits in trunk/WebCore

2010-11-30 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Enable switching between revisions of stylesheets
​https://bugs.webkit.org/show_bug.cgi?id=50227

Drive-by fix: styleSheetChanged() call needed after a stylesheet reparsing on setStyleSheetText2().

  • English.lproj/localizedStrings.js:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::reparseStyleSheet):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setStyleSheetText): (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleSheet.prototype.getText):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceRevisionTreeElement.prototype.onattach): (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
7:25 AM Changeset in webkit [72913] by Adam Roben
  • 4 edits in trunk/LayoutTests

Fix recently-added bug numbers

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
7:14 AM Changeset in webkit [72912] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-30 John Knottenbelt <​jknotten@chromium.org>

Reviewed by David Levin.

V8 binding for DOMTimeStamp should be Number, not Date
​https://bugs.webkit.org/show_bug.cgi?id=49963

  • fast/dom/domtimestamp-is-number-expected.txt: Added.
  • fast/dom/domtimestamp-is-number.html: Added.
  • fast/dom/script-tests/domtimestamp-is-number.js: Added. (do_check):

2010-11-30 John Knottenbelt <​jknotten@chromium.org>

Reviewed by David Levin.

V8 binding for DOMTimeStamp should be Number, not Date
​https://bugs.webkit.org/show_bug.cgi?id=49963

Test: fast/dom/domtimestamp-is-number.html

  • bindings/scripts/CodeGeneratorV8.pm:
7:06 AM Changeset in webkit [72911] by Adam Roben
  • 5 edits in trunk/LayoutTests

Update mac-wk2 Skipped file and add some bug numbers to other Skipped files

  • platform/mac-wk2/Skipped: Added current failures.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

Added bug numbers for implementing layoutTestController.findString.

6:35 AM Changeset in webkit [72910] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-11-30 Thiago Macieira <​thiago.macieira@nokia.com>

Reviewed by Andreas Kling.

[Qt] QWebFrame::load(QNetworkRequest) should respect the CustomVerbAttribute

For CustomOperation requests, pass the CustomVerbAttribute on to
the WebCore::ResourceRequest.

  • Api/qwebframe.cpp: (QWebFrame::load):
6:30 AM Changeset in webkit [72909] by Martin Robinson
  • 3 edits in trunk/WebKit/gtk

2010-11-30 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Test fast/events/mouseover-mouseout2.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=50214

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
  • webkit/webkitwebview.cpp: (webkit_web_view_query_tooltip):
5:54 AM Changeset in webkit [72908] by Patrick Gansterer
  • 2 edits in trunk

2010-11-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Use preprocessor argument in GENERATE_DOM_NAMES
​https://bugs.webkit.org/show_bug.cgi?id=49886

  • cmake/WebKitMacros.cmake:
5:40 AM Changeset in webkit [72907] by reni@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Leak with GraphicsContext::takeOwnershipOfPlatformContext()
​https://bugs.webkit.org/show_bug.cgi?id=49916

Reviewed by Andreas Kling.

Change the order of calling QPainter::device() and QPainter::end(), so device() will return with a valid device.
No new test is needed.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):

5:19 AM Changeset in webkit [72906] by Patrick Gansterer
  • 4 edits in trunk

2010-11-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move generator logic into WebCore CMakeLists.txt file
​https://bugs.webkit.org/show_bug.cgi?id=49885

  • cmake/WebKitMacros.cmake:

2010-11-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move generator logic into main CMakeLists.txt file
​https://bugs.webkit.org/show_bug.cgi?id=49885

Also make the generator calls more portable.

  • CMakeLists.txt:
4:34 AM Changeset in webkit [72905] by mario@webkit.org
  • 3 edits
    2 deletes in trunk

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, rolling out r72902.
​http://trac.webkit.org/changeset/72902
​https://bugs.webkit.org/show_bug.cgi?id=50062

This change is causing layout test failures on the Tests bots
for the mac platform.

  • accessibility/select-menulist-crash-expected.txt: Removed.
  • accessibility/select-menulist-crash.html: Removed.

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, rolling out r72902.
​http://trac.webkit.org/changeset/72902
​https://bugs.webkit.org/show_bug.cgi?id=50062

This change is causing layout test failures on the Tests bots
for the mac platform.

  • dom/SelectElement.cpp: (WebCore::SelectElement::accessKeySetSelectedIndex):
3:27 AM Changeset in webkit [72904] by commit-queue@webkit.org
  • 5 edits in trunk

2010-11-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72764.
​http://trac.webkit.org/changeset/72764
​https://bugs.webkit.org/show_bug.cgi?id=50215

This change is causing assertion failures on the debug bots.
(Requested by mrobinson on #webkit).

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_detach):

2010-11-30 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72764.
​http://trac.webkit.org/changeset/72764
​https://bugs.webkit.org/show_bug.cgi?id=50215

This change is causing assertion failures on the debug bots.
(Requested by mrobinson on #webkit).

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyStatus):
  • tests/testatk.c: (main):
3:12 AM Changeset in webkit [72903] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make copy(node) work in console.
​https://bugs.webkit.org/show_bug.cgi?id=50180

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
2:55 AM Changeset in webkit [72902] by mario@webkit.org
  • 3 edits
    2 adds in trunk

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Darin Adler.

ASSERT failing for combo boxes when selection changes
​https://bugs.webkit.org/show_bug.cgi?id=50062

  • accessibility/select-menulist-crash-expected.txt: Added.
  • accessibility/select-menulist-crash.html: Added.

2010-11-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Darin Adler.

ASSERT failing for combo boxes when selection changes
​https://bugs.webkit.org/show_bug.cgi?id=50062

Don't call listBoxOnChange for elements using menu lists.

Test: accessibility/select-menulist-crash.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::accessKeySetSelectedIndex): Extra check to decide whether to call menuListOnChange() or listBoxOnChange() instead of always calling listBoxOnChange().
2:36 AM Changeset in webkit [72901] by jochen@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-11-30 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] pass webframe to web frame client's cookieJar
​https://bugs.webkit.org/show_bug.cgi?id=50148

  • public/WebFrameClient.h: (WebKit::WebFrameClient::cookieJar):
  • src/ChromiumBridge.cpp: (WebCore::getCookieJar):
2:20 AM Changeset in webkit [72900] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-30 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Path stroke shadow has incorrect behavior when using ctx.scale(x,y)
​https://bugs.webkit.org/show_bug.cgi?id=50198

New fast canvas test to ensure correct behavior of path stroke shadow
when using scaling.

  • fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
  • fast/canvas/canvas-scale-strokePath-shadow.html: Added.
  • fast/canvas/script-tests/canvas-scale-strokePath-shadow.js: Added.

2010-11-30 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Path stroke shadow has incorrect behavior when using ctx.scale(x,y)
​https://bugs.webkit.org/show_bug.cgi?id=50198

Handle the special case when scaling is used and translate the shadow
offset accordingly. The correct behavior is ensured in ContextShadow
already, the issue only happens when using a non-blur shadow.

Test: fast/canvas/canvas-scale-strokePath-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokePath):
2:11 AM Changeset in webkit [72899] by Nikolas Zimmermann
  • 6 edits in trunk/LayoutTests

2010-11-30 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Update mac-leopard pixel baseline to pass with tolerance 0.
Update svg/dom/SVGTransformList-basics.xhtml mac baseline, after my last SVGList commit.

  • platform/mac-leopard/svg/batik/text/smallFonts-expected.checksum:
  • platform/mac-leopard/svg/batik/text/smallFonts-expected.png:
  • platform/mac-leopard/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/dom/SVGTransformList-basics-expected.checksum:
  • platform/mac/svg/dom/SVGTransformList-basics-expected.png:
2:03 AM Changeset in webkit [72898] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-30 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Path filling should keep shadow offset after context scaling
​https://bugs.webkit.org/show_bug.cgi?id=50194

New fast canvas test to ensure correct behavior of path fill shadow
when using scaling.

  • fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Added.
  • fast/canvas/canvas-scale-fillPath-shadow.html: Added.
  • fast/canvas/script-tests/canvas-scale-fillPath-shadow.js: Added.

2010-11-30 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Path filling should keep shadow offset after context scaling
​https://bugs.webkit.org/show_bug.cgi?id=50194

Handle the special case when scaling is used and translate the shadow
offset accordingly. The correct behavior is ensured in ContextShadow
already, the issue only happens when using a non-blur shadow.

Test: fast/canvas/canvas-scale-fillPath-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
1:58 AM Changeset in webkit [72897] by jochen@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

  • configure.ac: bump version for 1.3.7 release.
12:56 AM Changeset in webkit [72896] by Csaba Osztrogonác
  • 129 edits in trunk/LayoutTests

[Qt] Fix bugs when building WebKit with Qt 4.7.1
​https://bugs.webkit.org/show_bug.cgi?id=46248

Reviewed by Andreas Kling.

Migrate to Qt 4.7.1, add failing tests to the Skipped list,
remove passing tests from Skipped list, update expected files.

  • platform/qt/Skipped:
  • platform/qt/css1/basic/class_as_selector-expected.txt:
  • platform/qt/css1/basic/comments-expected.txt:
  • platform/qt/css1/basic/containment-expected.txt:
  • platform/qt/css1/basic/contextual_selectors-expected.txt:
  • platform/qt/css1/basic/grouping-expected.txt:
  • platform/qt/css1/basic/id_as_selector-expected.txt:
  • platform/qt/css1/basic/inheritance-expected.txt:
  • platform/qt/css1/box_properties/border-expected.txt:
  • platform/qt/css1/box_properties/border_bottom-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_width-expected.txt:
  • platform/qt/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_color-expected.txt:
  • platform/qt/css1/box_properties/border_color_inline-expected.txt:
  • platform/qt/css1/box_properties/border_inline-expected.txt:
  • platform/qt/css1/box_properties/border_left-expected.txt:
  • platform/qt/css1/box_properties/border_left_inline-expected.txt:
  • platform/qt/css1/box_properties/border_left_width-expected.txt:
  • platform/qt/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_right-expected.txt:
  • platform/qt/css1/box_properties/border_right_inline-expected.txt:
  • platform/qt/css1/box_properties/border_right_width-expected.txt:
  • platform/qt/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_style-expected.txt:
  • platform/qt/css1/box_properties/border_style_inline-expected.txt:
  • platform/qt/css1/box_properties/border_top-expected.txt:
  • platform/qt/css1/box_properties/border_top_inline-expected.txt:
  • platform/qt/css1/box_properties/border_top_width-expected.txt:
  • platform/qt/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/qt/css1/box_properties/border_width-expected.txt:
  • platform/qt/css1/box_properties/border_width_inline-expected.txt:
  • platform/qt/css1/box_properties/clear-expected.txt:
  • platform/qt/css1/box_properties/clear_float-expected.txt:
  • platform/qt/css1/box_properties/float-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_margin-expected.txt:
  • platform/qt/css1/box_properties/height-expected.txt:
  • platform/qt/css1/box_properties/margin-expected.txt:
  • platform/qt/css1/box_properties/margin_bottom-expected.txt:
  • platform/qt/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_left-expected.txt:
  • platform/qt/css1/box_properties/margin_left_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/box_properties/margin_right_inline-expected.txt:
  • platform/qt/css1/box_properties/margin_top-expected.txt:
  • platform/qt/css1/box_properties/margin_top_inline-expected.txt:
  • platform/qt/css1/box_properties/padding-expected.txt:
  • platform/qt/css1/box_properties/padding_bottom-expected.txt:
  • platform/qt/css1/box_properties/padding_bottom_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_left-expected.txt:
  • platform/qt/css1/box_properties/padding_left_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_right-expected.txt:
  • platform/qt/css1/box_properties/padding_right_inline-expected.txt:
  • platform/qt/css1/box_properties/padding_top-expected.txt:
  • platform/qt/css1/box_properties/padding_top_inline-expected.txt:
  • platform/qt/css1/box_properties/width-expected.txt:
  • platform/qt/css1/cascade/cascade_order-expected.txt:
  • platform/qt/css1/cascade/important-expected.txt:
  • platform/qt/css1/classification/display-expected.txt:
  • platform/qt/css1/classification/list_style-expected.txt:
  • platform/qt/css1/classification/list_style_image-expected.txt:
  • platform/qt/css1/classification/list_style_position-expected.txt:
  • platform/qt/css1/classification/list_style_type-expected.txt:
  • platform/qt/css1/color_and_background/background-expected.txt:
  • platform/qt/css1/color_and_background/background_attachment-expected.txt:
  • platform/qt/css1/color_and_background/background_color-expected.txt:
  • platform/qt/css1/color_and_background/background_image-expected.txt:
  • platform/qt/css1/color_and_background/background_position-expected.txt:
  • platform/qt/css1/color_and_background/background_repeat-expected.txt:
  • platform/qt/css1/color_and_background/color-expected.txt:
  • platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/qt/css1/font_properties/font-expected.txt:
  • platform/qt/css1/font_properties/font_family-expected.txt:
  • platform/qt/css1/font_properties/font_size-expected.txt:
  • platform/qt/css1/font_properties/font_style-expected.txt:
  • platform/qt/css1/font_properties/font_variant-expected.txt:
  • platform/qt/css1/font_properties/font_weight-expected.txt:
  • platform/qt/css1/formatting_model/canvas-expected.txt:
  • platform/qt/css1/formatting_model/floating_elements-expected.txt:
  • platform/qt/css1/formatting_model/height_of_lines-expected.txt:
  • platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/qt/css1/formatting_model/inline_elements-expected.txt:
  • platform/qt/css1/formatting_model/replaced_elements-expected.txt:
  • platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/qt/css1/pseudo/anchor-expected.txt:
  • platform/qt/css1/pseudo/firstletter-expected.txt:
  • platform/qt/css1/pseudo/firstline-expected.txt:
  • platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/qt/css1/text_properties/letter_spacing-expected.txt:
  • platform/qt/css1/text_properties/line_height-expected.txt:
  • platform/qt/css1/text_properties/text_align-expected.txt:
  • platform/qt/css1/text_properties/text_decoration-expected.txt:
  • platform/qt/css1/text_properties/text_indent-expected.txt:
  • platform/qt/css1/text_properties/text_transform-expected.txt:
  • platform/qt/css1/text_properties/vertical_align-expected.txt:
  • platform/qt/css1/text_properties/word_spacing-expected.txt:
  • platform/qt/css1/units/color_units-expected.txt:
  • platform/qt/css1/units/length_units-expected.txt:
  • platform/qt/css1/units/percentage_units-expected.txt:
  • platform/qt/css1/units/urls-expected.txt:
  • platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • platform/qt/editing/inserting/paragraph-separator-03-expected.txt:
  • platform/qt/editing/pasteboard/5027857-expected.txt:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/qt/editing/pasteboard/paste-pre-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-019-expected.txt:
  • platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/dom/gc-10-expected.txt:
  • platform/qt/fast/forms/isindex-placeholder-expected.txt:
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/qt/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/qt/fast/lists/003-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/qt/fast/text/international/hindi-whitespace-expected.txt:
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/qt/svg/custom/bug45331-expected.txt:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
12:15 AM Changeset in webkit [72895] by yurys@chromium.org
  • 24 edits in trunk/WebCore

2010-11-30 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: make ScriptCallStack and ScriptArguments reference counted
​https://bugs.webkit.org/show_bug.cgi?id=50156

No new tests. This refactoring is covered with existing inspector tests.

  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profile): (WebCore::JSConsole::profileEnd):
  • bindings/js/ScriptCallStackFactory.cpp: (WebCore::createScriptCallStack): (WebCore::createScriptArguments):
  • bindings/js/ScriptCallStackFactory.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::customArgsAndExceptionCallback):
  • bindings/v8/ScriptCallStackFactory.cpp: (WebCore::createScriptCallStack): (WebCore::createScriptArguments):
  • bindings/v8/ScriptCallStackFactory.h:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler): (WebCore::V8ConsoleMessage::dispatchNow):
  • bindings/v8/V8ConsoleMessage.h:
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback): (WebCore::V8Console::assertCallback): (WebCore::V8Console::profileCallback): (WebCore::V8Console::profileEndCallback):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup):
  • inspector/InspectorController.h:
  • inspector/ScriptArguments.cpp: (WebCore::ScriptArguments::create):
  • inspector/ScriptArguments.h:
  • inspector/ScriptCallFrame.h:
  • inspector/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size):
  • inspector/ScriptCallStack.h:
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::debug): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::dirxml): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profile): (WebCore::Console::profileEnd): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::warn):
  • page/Console.h:

Nov 29, 2010:

11:56 PM Changeset in webkit [72894] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Windows build fix (part 2).
Define Visual Studio internal variables used in pre-build/pre-link/post-build commands in environment for separated cmd files.

  • win/tools/vsprops/common.vsprops:
11:55 PM Changeset in webkit [72893] by sfalken@apple.com
  • 11 edits in trunk/JavaScriptCore

Windows build fix (part 1). Use correct environment variable syntax in cmd files.

11:39 PM Changeset in webkit [72892] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

GTK DumpRenderTree build fix after r72887.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::findString):

11:32 PM Changeset in webkit [72891] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix for non-ICU platforms after r72887.

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::prependContext):

11:30 PM Changeset in webkit [72890] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Windows DumpRenderTree build fix after r72887.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::findString): Added empty implementation.

11:25 PM Changeset in webkit [72889] by mitz@apple.com
  • 4 edits in trunk/LayoutTests

Skip editing/text-iterator/findString.html on platforms that do not have an implementation of
layoutTestController.findString()

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
11:08 PM Changeset in webkit [72888] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-11-29 MORITA Hajime <​morrita@google.com>

Unreviewed, updated expectations (unskip some passing tests).

  • platform/chromium/test_expectations.txt:
10:39 PM Changeset in webkit [72887] by mitz@apple.com
  • 44 edits
    1 move
    3 adds in trunk

JavaScriptCore: WTF support for <rdar://problem/8650085> adding word-prefix search options to the text search API.
​https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

  • wtf/unicode/UnicodeMacrosFromICU.h: Copied additional macros from icu/unicode/utf16.h.

WebCore: WebCore part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
​https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

Test: editing/text-iterator/findString.html

  • GNUmakefile.am: Added FindOptions.h.
  • WebCore.exp.in: Export the new methods that take FindOptions.
  • WebCore.gypi: Added FindOptions.h.
  • WebCore.pro: Added FindOptions.h and TextBoundaries.{cpp,h}.
  • WebCore.vcproj/WebCore.vcproj: Added FindOptions.h.
  • WebCore.xcodeproj/project.pbxproj: Added FindOptions.h and TextBoundaries.cpp.
  • editing/Editor.cpp:

(WebCore::Editor::firstVisibleRange): Changed to use FindOptions.
(WebCore::Editor::lastVisibleRange): Ditto.
(WebCore::Editor::nextVisibleRange): Ditto.
(WebCore::Editor::findString): Ditto.
(WebCore::Editor::countMatchesForText): Ditto.

  • editing/Editor.h: Added a version of findString() that takes FindOptions. Changed

countMatchesForText() to take FindOptions. Made nextVisibleRange() private and changed it
and firstVisibleRange() and lastVisibleRange() to take FindOptions.

  • editing/FindOptions.h: Added.
  • editing/TextIterator.cpp:

Augmented SearchBuffer with an optional prefix, which is not searched, but provides context
for determining word boundaries.
(WebCore::isSeparator): Added. Identifies a class of characters used to determine where
“words” are embedded in a word.
(WebCore::SearchBuffer::SearchBuffer): Changed to take FindOptions. Added initialization of
m_options, m_prefixLength and m_needsMoreContext.
(WebCore::SearchBuffer::append): Adjust m_prefixLength as part of the prefix gets pushed out
of the buffer.
(WebCore::SearchBuffer::needsMoreContext): Added.
(WebCore::SearchBuffer::prependContext): Added.
(WebCore::SearchBuffer::isWordStartMatch): Added.
(WebCore::SearchBuffer::search): Changed to account for the context prefix. When searching
only for word prefix matches, maintains enough context before a tentative match when moving
it to the beginning of the buffer. Reject matches that are not at word starts if requested.
Adjust m_prefixLength when pushing characters out of the buffer.
(WebCore::findPlainText): Changed to work with FindOptions. Feed the search buffer with context
if and as long as it requires more of it.

  • editing/TextIterator.h: Added a version of findPlainText() that takes FindOptions.
  • editing/visible_units.cpp: Moved {end,start}Of{First,Last}WordBoundary to TextBoundaries.cpp.
  • page/Page.cpp:

(WebCore::Page::findString): Changed to work with FindOptions.
(WebCore::Page::markAllMatchesForText): Ditto.

  • page/Page.h: Added FindOptions-based findString() and markAllMatchesForText().
  • platform/text/TextBoundaries.cpp:

(WebCore::endOfFirstWordBoundaryContext): Moved here from visible_units.cpp.
(WebCore::startOfLastWordBoundaryContext): Ditto.

  • platform/text/TextBoundaries.h:

WebKit/mac: WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
​https://bugs.webkit.org/show_bug.cgi?id=50038
Based on a patch from Darin Adler.

Reviewed by Darin Adler.

  • WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and

replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
method. Made WebHTMLView conform to the new protocol.

  • WebView/WebHTMLView.mm:

(coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
-findString:options:.
(-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
(-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().

  • WebView/WebPDFView.mm:

(-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.

  • WebView/WebView.mm:

(-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
-countMatchesForText:options:highlight:limit:markMatches.
(-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
(-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
-findString:options:.
(incrementFrame): Changed to use WebFindOptions.
(findString): Added this helper method that performs the search using the best supported
method for the document view.
(-[WebView findString:options:]): Changed -searchFor::::: into this.
(-[WebView canMarkAllTextMatches]):
(-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
WebFindOptions.
(-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
(-[WebView rectsForTextMatches]): Ditto.

  • WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version

of countMatchesForText:.

WebKit2: WebKit2 part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
​https://bugs.webkit.org/show_bug.cgi?id=50038
Based on a patch from Darin Adler.

Reviewed by Darin Adler.

  • Shared/WebFindOptions.h: Renamed FindOptions.h to this to account for WebCore’s new private

FindOptions.h. Added and reordered FindOptions and rolled FindDirection into FindOptions.

  • UIProcess/API/C/WKAPICast.h: Removed toFindDirection().

(WebKit::toFindOptions): Updated for new values.

  • UIProcess/API/C/WKPage.cpp:

(WKPageFindString): Removed separate WKFindDirection.
(WKPageCountStringMatches): Replaces caseInsensitive boolean with WKFindOptions.

  • UIProcess/API/C/WKPage.h: Removed WKFindDirection and updated WKFindOptions.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findString): Removed separate FindDirection.
(WebKit::WebPageProxy::countStringMatches): Replaced caseInsensitive boolean with FindOptions.

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj: Updated for the header rename.
  • WebProcess/WebPage/FindController.cpp:

(WebKit::core): Added. Converts WebKit2 FindOptions to WebCore FindOptions.
(WebKit::FindController::countStringMatches): Changed to use FindOptions.
(WebKit::FindController::findString): Ditto.

  • WebProcess/WebPage/FindController.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findString): Ditto.
(WebKit::WebPage::countStringMatches): Ditto.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Ditto.

WebKitTools: DumpRenderTree changes for testing the text search API.
​https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

  • DumpRenderTree/LayoutTestController.cpp:

(findStringCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::findString):

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController find:]):

LayoutTests: Added text search tests, in particular testing word-prefix search.
​https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

  • editing/text-iterator/findString-expected.txt: Added.
  • editing/text-iterator/findString.html: Added.
10:28 PM Changeset in webkit [72886] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

[chromium] Fix expectations for fast/block/basic/truncation-rtl.html

  • platform/chromium/test_expectations.txt:
10:14 PM Changeset in webkit [72885] by sfalken@apple.com
  • 6 edits
    9 adds in trunk/JavaScriptCore

2010-11-29 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

JavaScriptCore projects on Windows should use cmd files for build events
​https://bugs.webkit.org/show_bug.cgi?id=50193

10:11 PM Changeset in webkit [72884] by commit-queue@webkit.org
  • 21 edits
    4 adds in trunk

2010-11-29 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

when empty, clicking "down" on outer-spin-button returns "max value"
​https://bugs.webkit.org/show_bug.cgi?id=45491

It is required to calculate UTC/DST offsets to retrieve the current local milliseconds for
date/time type inputs. WTF::currentTimeMS() returns a UTC time, and WTF::getLocalTime()
returns a struct tm, not milliseconds.

Calculating milliseconds from a struct tm is not simple since timegm() cannot be used in all
environments. This calculation is already done in calculateUTCOffset(), and complicated.
Duplicating this complicated calculation is unreasonable because of maintainability.
To achieve this without duplication, we must call calculate{UTC|DST}Offset in some way.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/DateMath.cpp: Changed calculateUTCOffset() and calculateDSTOffset() to external functions. (WTF::calculateUTCOffset): (WTF::calculateDSTOffset):
  • wtf/DateMath.h:

2010-11-29 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

when empty, clicking "down" on outer-spin-button returns "max value"
​https://bugs.webkit.org/show_bug.cgi?id=45491

  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/input-stepup-stepdown-from-renderer.html: Added.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Added. (): (setInputAttributes): (stepUp): (stepDown): (stepUpExplicitBounds): (stepDownExplicitBounds):

2010-11-29 Dai Mikurube <​dmikurube@google.com>

Reviewed by Kent Tamura.

when empty, clicking "down" on outer-spin-button returns "max value"
​https://bugs.webkit.org/show_bug.cgi?id=45491

Modified stepping-up/down from renderer

  • to clamp steps,
  • to handle empty values (described below), and
  • to apply them for range type inputs.

Stepping-up/down for empty values are handled "the empty as 0."
For example :

  • If 0 is in-range, and matches to step value "down" -> -step "up" -> +step If -step or +step is out of range, new value should be 0.
  • If 0 is smaller than the minimum value "down" -> the minimum value "up" -> the minimum value
  • If 0 is larger than the maximum value "down" -> the maximum value "up" -> the maximum value
  • If 0 is in-range, but not matched to step value "down" -> smaler matched value nearest to 0.

e.g. <input type=number min=-100 step=3> -> -1

"up" -> larger matched value nearest to 0.

e.g. <input type=number min=-100 step=3> -> 2

As for date/datetime-local/month/time/week types, the empty is assumed as "current local date/time".
As for datetime type, the empty is assumed as "current date/time in UTC".

As for range input types, changed stepping from renderer to use stepUpFromRenderer().
It was calculated with stepUp() from RangeInputType::handleKeydownEvent().

Test: fast/forms/input-stepup-stepdown-from-renderer.html

  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local time
  • html/BaseDateAndTimeInputType.h:
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current UTC time
  • html/DateTimeInputType.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Modified it to clamp steps, support empty values and support range type inputs
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isRangeControl):
  • html/InputType.cpp: (WebCore::InputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns 0
  • html/InputType.h:
  • html/MonthInputType.cpp: (WebCore::MonthInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local month
  • html/MonthInputType.h:
  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): Added comments and modified it to use stepUpFromRenderer()
  • html/TimeInputType.cpp: (WebCore::TimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local time
  • html/TimeInputType.h:
  • manual-tests/input-type-datetime-default-value.html: Added manual tests for default values of date/time inputs since they are "the current local/UTC time", which cannot be tested automatically.
9:40 PM Changeset in webkit [72883] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

Update listing for spatial nav tests after they were moved
in ​http://trac.webkit.org/changeset/72880/.

  • platform/chromium/test_expectations.txt:
9:21 PM Changeset in webkit [72882] by kinuko@chromium.org
  • 5 edits
    1 delete in trunk/LayoutTests

2010-11-24 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed; updating test expectations.

  • fast/filesystem/async-operations-expected.txt:
  • fast/filesystem/read-directory-expected.txt:
  • fast/filesystem/simple-persistent-expected.txt:
  • fast/filesystem/simple-temporary-expected.txt:
  • platform/chromium-linux/fast/filesystem/async-operations-expected.txt: Removed.
9:14 PM Changeset in webkit [72881] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

[chromium] Hopefully final modification to text_expectations to green chromium bots.

  • platform/chromium/test_expectations.txt:
9:09 PM Changeset in webkit [72880] by tonikitoo@webkit.org
  • 4 edits
    59 moves
    2 adds in trunk/LayoutTests

2010-11-28 Antonio Gomes <​agomes@rim.com>

Reviewed by Kenneth Rohde Christiansen.

Spatial navigation: move tests to its own feature directory
​https://bugs.webkit.org/show_bug.cgi?id=50133

Patch basically moves all spatial navigation tests out of the fast/events folder,
putting them all under /fast/spatial-navigation.

Some needed changes in some tests and Skipped files were also made, but there is not
any content changes in the tests.

  • fast/events/spatial-navigation: Moved to fast/spatial-navigation
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:
9:06 PM Changeset in webkit [72879] by ojan@chromium.org
  • 1 edit
    20 adds in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

[chromium] Rebaseline results after ​http://trac.webkit.org/changeset/72802/.
The only differences are in the scrollbars.
The original patch included the chromium-linux results in addition to the
platform/mac results.

  • platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.png: Added.
9:01 PM Changeset in webkit [72878] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-11-29 Ryosuke Niwa <​rniwa@webkit.org>

More unreviewed rebaseline for r72861.

  • platform/chromium-linux/editing/selection/home-end-expected.txt: Removed.
8:53 PM Changeset in webkit [72877] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

[chromium] Some more expectations updates to green chromium bots.

  • platform/chromium/test_expectations.txt:
8:48 PM Changeset in webkit [72876] by abarth@webkit.org
  • 8 edits in trunk

2010-11-29 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
​https://bugs.webkit.org/show_bug.cgi?id=50182

A display-isolated URL can only be displayed (e.g., put in an iframe,
hyperlinked to) by documents from that scheme. In a sense, this is a
generalization of some of the protections we give file URLs, but
instead of lumping them all together into one "local" bucket, this
patch creates a separate bucket for each scheme.

For a while, I tried using a separate bucket for each origin. That
would have played nicely with what Blob URLs are trying to do, but some
"chrome" URL pages rely on being able to display other chrome URL
pages, even in different origins. For example, the New Tab Page shows
thumbnails from the "thumbnail" host.

This patch also removes a bunch of unused code. I've also propagated
the "deprecated" status of deprecatedCanDisplay to
deprecatedShouldTreatURLAsLocal because that method has no other
callers and is really asking for uppercase/lowercase bugs. I dream of
someday removing these functions.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay): (WebCore::SecurityOrigin::deprecatedCanDisplay):
  • platform/SchemeRegistry.cpp: (WebCore::displayIsolatedURLSchemes): (WebCore::SchemeRegistry::registerURLSchemeAsLocal): (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal): (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
  • platform/SchemeRegistry.h:

2010-11-29 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
​https://bugs.webkit.org/show_bug.cgi?id=50182

This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.

  • public/WebSecurityPolicy.h:
  • src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):
8:37 PM Changeset in webkit [72875] by xji@chromium.org
  • 6 edits in trunk/LayoutTests

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Unreviewed rebaseline for Chromium after r72852.

  • platform/chromium-linux/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/chromium-linux/fast/block/basic/truncation-rtl-expected.png:
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.png:
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.txt:
8:31 PM Changeset in webkit [72874] by rniwa@webkit.org
  • 9 edits in trunk/LayoutTests

2010-11-29 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed rebaseline for r72861. Also disabled editing/selection/click-left-of-rtl-wrapping-text.html and
editing/selection/modify-up-on-rtl-wrapping-text.html on Gtk, Qt, Windows, Chromium Windows and Chromium Linux.

  • editing/selection/extend-selection-home-end-expected.txt:
  • platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt:
  • platform/chromium-win/editing/selection/home-end-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/win/editing/selection/extend-selection-home-end-expected.txt:
8:29 PM Changeset in webkit [72873] by chang.shu@nokia.com
  • 1 edit
    3 moves in trunk/LayoutTests

2010-11-29 Chang Shu <​chang.shu@nokia.com>

Reviewed by Laszlo Gombos.

Fix the typo in the test case to make it work when ORIENTATION_EVENTS is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=50171

  • fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt: Removed.
  • fast/dom/DeviceOrientation/create-event-onorientationchange.html: Removed.
  • fast/dom/DeviceOrientation/create-event-orientationchange-expected.txt: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt.
  • fast/dom/DeviceOrientation/create-event-orientationchange.html: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange.html.
  • fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js: Removed.
  • fast/dom/DeviceOrientation/script-tests/create-event-orientationchange.js: Copied from LayoutTests/fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js.
8:26 PM Changeset in webkit [72872] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Unreviewed fix typo.

  • platform/chromium/test_expectations.txt:
8:19 PM Changeset in webkit [72871] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

[Chromium] Reflection tests are now fixed. Remove from test_expectations.

  • platform/chromium/test_expectations.txt:
8:12 PM Changeset in webkit [72870] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-29 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Leaks in SoupCache code
​https://bugs.webkit.org/show_bug.cgi?id=50161

Fixes some memory leaks in SoupCache code.

  • platform/network/soup/cache/soup-http-input-stream.c: (send_async_finished): Added a missing g_object_unref.
  • platform/network/soup/cache/webkit/soup-cache.c: (get_cacheability): Added soup_header_free_param_list. (webkit_soup_cache_entry_set_freshness): Ditto. (webkit_soup_cache_send_response): Ditto. (webkit_soup_cache_has_response): Ditto.
8:11 PM Changeset in webkit [72869] by xji@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Unreviewed.

Temporarily skip fast/dom/horizontal-scrollbar-in-rtl.html and fast/dom/horizontal-scrollbar-when-dir-change.html due to bug 50203 (after r72852).

  • platform/chromium/test_expectations.txt:
  • platform/win/Skipped:
7:34 PM Changeset in webkit [72868] by jnd@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-29 Johnny Ding <​jnd@chromium.org>

Unreviewed: Add myself to the list of Committers.

  • Scripts/webkitpy/common/config/committers.py:
7:28 PM Changeset in webkit [72867] by xji@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Unreviewed rebaseline for Win7 after r72852.

  • platform/win/fast/block: Added.
  • platform/win/fast/block/basic: Added.
  • platform/win/fast/block/basic/truncation-rtl-expected.txt: Added.
7:20 PM Changeset in webkit [72866] by jianli@chromium.org
  • 8 edits
    3 adds in trunk

Add send(ArrayBuffer) to XMLHttpRequest per XMLHttpRequest Level 2 spec
​https://bugs.webkit.org/show_bug.cgi?id=50199

Reviewed by David Levin.

WebCore:

Test: http/tests/xmlhttprequest/send-array-buffer.html

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

  • xml/XMLHttpRequest.h:

LayoutTests:

  • http/tests/xmlhttprequest/resources/post-echo-as-ascii.cgi: Added.
  • http/tests/xmlhttprequest/send-array-buffer-expected.txt: Added.
  • http/tests/xmlhttprequest/send-array-buffer.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
7:16 PM Changeset in webkit [72865] by xji@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Unreviewed.

Skip fast/dom/tab-in-right-alignment.html for GTK and Win due to
unimplemented textInputController (after r72847).

  • platform/gtk/Skipped:
  • platform/win/Skipped:
7:11 PM Changeset in webkit [72864] by jamesr@google.com
  • 5 edits
    15 deletes in trunk

2010-11-29 James Robinson <​jamesr@chromium.org>

[chromium] REGRESSION(72470): Crash in skia on some images
​https://bugs.webkit.org/show_bug.cgi?id=50201

Reverts r72470

  • platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/image-rescale-expected.checksum: Removed.
  • platform/mac/svg/custom/image-rescale-expected.png: Removed.
  • platform/mac/svg/custom/image-rescale-expected.txt: Removed.
  • platform/mac/svg/custom/image-rescale-scroll-expected.checksum: Removed.
  • platform/mac/svg/custom/image-rescale-scroll-expected.png: Removed.
  • platform/mac/svg/custom/image-rescale-scroll-expected.txt: Removed.
  • platform/mac/test_expectations.txt:
  • svg/custom/image-rescale-scroll.html: Removed.
  • svg/custom/image-rescale.svg: Removed.
  • svg/custom/resources/image-rescale.jpg: Removed.

2010-11-29 James Robinson <​jamesr@chromium.org>

[chromium] REGRESSION(72470): Crash in skia on some images
​https://bugs.webkit.org/show_bug.cgi?id=50201

Reverts r72470

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::drawResampledBitmap):
7:06 PM Changeset in webkit [72863] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Crash when iframe transfers from one page to another and has child frames.
​https://bugs.webkit.org/show_bug.cgi?id=50200

Reviewed by David Levin.

  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument):
avoid overriding 'didTransfer' which has the result of previous check.

7:00 PM Changeset in webkit [72862] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed reabseline for r72852.

  • platform/gtk/fast/block/basic/truncation-rtl-expected.txt:
6:54 PM Changeset in webkit [72861] by rniwa@webkit.org
  • 9 edits
    4 adds in trunk

2010-11-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by David Hyatt.

up arrow doesn't work with RTL text with word wrapping
​https://bugs.webkit.org/show_bug.cgi?id=41987

The bug was caused by positionForPoint's not returning the correct affinity when the x coordiate
is to the left of the first line, and startOfLine's incorrectly moving position to the previous candidate.

Fixed the bug by returning upstream VisiblePosition in positionForPoint if the first inline text box's offset
is greater than 0. Also removed the code added by ​http://trac.webkit.org/changeset/23608 since this changeset
does not add any test, and the problem described in the changelog reproduces regardless of the code's presence.

Tests: editing/selection/click-left-of-rtl-wrapping-text.html

editing/selection/modify-up-on-rtl-wrapping-text.html

  • editing/visible_units.cpp: (WebCore::startOfLine):
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):

2010-11-29 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by David Hyatt.

up arrow doesn't work with RTL text with word wrapping
​https://bugs.webkit.org/show_bug.cgi?id=41987

Added tests to ensure WebKit places caret at the right position in soft-wrapping RTL text when clicking
to the left of RTL text or when moving upwards at the end of line.

  • editing/selection/click-left-of-rtl-wrapping-text-expected.txt: Added.
  • editing/selection/click-left-of-rtl-wrapping-text.html: Added.
  • editing/selection/home-end-expected.txt: RTL's expected result now matches LTR's.
  • editing/selection/modify-up-on-rtl-wrapping-text-expected.txt: Added.
  • editing/selection/modify-up-on-rtl-wrapping-text.html: Added.
  • platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: RTL's expected result now matches LTR's.
  • platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Ditto.
  • platform/mac/editing/selection/extend-selection-home-end-expected.txt: Ditto.
  • platform/win/editing/selection/extend-selection-home-end-expected.txt: Ditto.
6:34 PM Changeset in webkit [72860] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2010-11-29 Ilya Sherman <​isherman@chromium.org>

Reviewed by Kent Tamura.

Ensure that option elements are rendered with normal font weight on Windows/Linux
​https://bugs.webkit.org/show_bug.cgi?id=50055

  • WebCore.gyp/WebCore.gyp: include themeChromiumSkia.css
  • css/themeChromiumSkia.css: Added. (option): font-weight: normal !important;
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): include themeChromiumSkia.css
6:07 PM Changeset in webkit [72859] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

<rdar://problem/8694997> DumpRenderTree fails to build.

Reviewed by Adele Peterson.

  • DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
6:06 PM Changeset in webkit [72858] by mrowe@apple.com
  • 2 edits
    2 moves in trunk/WebKitTools

<rdar://problem/8694997> DumpRenderTree fails to build.

Reviewed by Adele Peterson.

  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
  • DumpRenderTree/mac/PerlSupport/Makefile:
5:55 PM Changeset in webkit [72857] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed build fix.

  • win/WebKit2.vcproj: Add missing vsprops association for

Debug_Cairo_CFLite target.

5:51 PM Changeset in webkit [72856] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Unreviewed build correction.

  • WebKit.vcproj/WebKit.vcproj: Update WebKit project to use WinCairo.vsprops definition for appropriate build targets.
5:41 PM Changeset in webkit [72855] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed build fix.

  • WebCore.vcproj/WebCoreCairo.vsprops: Provide missing WIN_CAIRO definition so that proper targets are build.
  • platform/graphics/win/cairo/FontPlatformData.h:

(WebCore::FontPlatformData::orientation): Add missing implementation.

5:40 PM Changeset in webkit [72854] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by NOBODY.

Rebaseline truncation-rtl-expected.txt after ​http://trac.webkit.org/changeset/72852

  • platform/qt/fast/block/basic/truncation-rtl-expected.txt:
5:18 PM Changeset in webkit [72853] by crogers@google.com
  • 8 edits
    1 delete in trunk

2010-11-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Switch web audio code to use FloatPoint3D instead of Vector3
​https://bugs.webkit.org/show_bug.cgi?id=50186

  • wtf/Vector3.h: Removed.

2010-11-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Switch web audio code to use FloatPoint3D instead of Vector3
​https://bugs.webkit.org/show_bug.cgi?id=50186

No new tests since audio API is not yet implemented.

  • platform/audio/Cone.cpp: (WebCore::ConeEffect::gain):
  • platform/audio/Cone.h:
  • platform/graphics/FloatPoint3D.h: (WebCore::FloatPoint3D::isZero): (WebCore::operator*): (WebCore::FloatPoint3D::distanceTo):
  • webaudio/AudioListener.h: (WebCore::AudioListener::setPosition): (WebCore::AudioListener::position): (WebCore::AudioListener::setOrientation): (WebCore::AudioListener::orientation): (WebCore::AudioListener::setUpVector): (WebCore::AudioListener::upVector): (WebCore::AudioListener::setVelocity): (WebCore::AudioListener::velocity):
  • webaudio/AudioPannerNode.cpp: (WebCore::AudioPannerNode::AudioPannerNode): (WebCore::AudioPannerNode::getAzimuthElevation): (WebCore::AudioPannerNode::dopplerRate): (WebCore::AudioPannerNode::distanceConeGain):
  • webaudio/AudioPannerNode.h: (WebCore::AudioPannerNode::position): (WebCore::AudioPannerNode::setPosition): (WebCore::AudioPannerNode::orientation): (WebCore::AudioPannerNode::setOrientation): (WebCore::AudioPannerNode::velocity): (WebCore::AudioPannerNode::setVelocity):
5:11 PM Changeset in webkit [72852] by xji@chromium.org
  • 17 edits
    12 adds in trunk

2010-11-29 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
​https://bugs.webkit.org/show_bug.cgi?id=23556

Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
pages with a left overflow.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgramaticScroll]): (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]): (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]): (-[WebDynamicScrollBarsView setScrollOriginX:]): (-[WebDynamicScrollBarsView scrollOriginX]):
  • WebView/WebFrameView.mm: (-[WebFrameView _scrollToBeginningOfDocument]): (-[WebFrameView _scrollToEndOfDocument]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]):

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
​https://bugs.webkit.org/show_bug.cgi?id=23556

For RTL page, save left layout overflow and include it into the document
size during layout. Use the left layout overflow when scroll and paint
the page. Behavior on LTR page should be untouched since left layout
overflow is set as 0 for LTR page.

Tests: fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html

fast/dom/horizontal-scrollbar-in-rtl.html
fast/dom/horizontal-scrollbar-when-dir-change.html
fast/dom/left-overflow-in-ltr.html
fast/dom/right-overflow-in-rtl.html

  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): Save negative of left layout overflow as scroll X origin. And includes left layout overflow into document size.
  • page/mac/WebCoreFrameView.h: Add methods for setting and getting scroll X origin.
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::maximumScrollPosition): Minus scroll X origin from maximum horizontal scroll position. (WebCore::ScrollView::minimumScrollPosition): (WebCore::ScrollView::adjustScrollPositionWithinRange): (WebCore::ScrollView::valueChanged): (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetContentsSize): (WebCore::ScrollView::platformSetScrollPosition): (WebCore::ScrollView::platformSetScrollOriginX):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::paintRootBoxDecorations): Include left layout overflow into canvas size.
  • rendering/RenderView.cpp: (WebCore::RenderView::layout): Save left layout overflow. (WebCore::RenderView::docLeft): (WebCore::RenderView::docWidth): Include left layout overflow into doc width for RTL page.
  • rendering/RenderView.h:

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
​https://bugs.webkit.org/show_bug.cgi?id=23556

For RTL page, save left layout overflow and include it into the document
size during layout. Use the left layout overflow when scroll and paint
the page. Behavior on LTR page should be untouched since left layout
overflow is set as 0 for LTR page.

  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
  • fast/dom/horizontal-scrollbar-in-rtl.html: Added.
  • fast/dom/horizontal-scrollbar-when-dir-change.html: Added.
  • fast/dom/left-overflow-in-ltr.html: Added.
  • fast/dom/right-overflow-in-rtl.html: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/dom/left-overflow-in-ltr-expected.txt: Added.
  • platform/mac/fast/dom/right-overflow-in-rtl-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
  • fast/dom/horizontal-scrollbar-in-rtl.html: Added.
  • fast/dom/horizontal-scrollbar-when-dir-change.html: Added.
  • fast/dom/left-overflow-in-ltr.html: Added.
  • fast/dom/right-overflow-in-rtl.html: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/dom/left-overflow-in-ltr-expected.txt: Added.
  • platform/mac/fast/dom/right-overflow-in-rtl-expected.txt: Added.
4:57 PM Changeset in webkit [72851] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Cursor does not always change back to arrow when exiting image document
​https://bugs.webkit.org/show_bug.cgi?id=50190
<rdar://problem/8665265>

Reviewed by Sam Weinig.

  • Shared/mac/WebEventFactory.mm:

(WebKit::mouseEventTypeForEvent):
(WebKit::globalPointForEvent):
(WebKit::pointForEvent):
Handle the NSMouseEntered and NSMouseExited events.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:]):
We want entered and exited events for this tracking area.
Add mouseEntered and mouseExited handlers.

4:53 PM Changeset in webkit [72850] by Simon Fraser
  • 6 edits
    3 adds
    2 deletes in trunk

2010-11-29 Simon Fraser <Simon Fraser>

Reviewed by Ojan Vafai.

bunch of pixel failures after ​http://trac.webkit.org/changeset/72839/
​https://bugs.webkit.org/show_bug.cgi?id=50188

We need to call updateLayerTransform() for reflections, and
table rows as well.

  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::layout):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
4:40 PM Changeset in webkit [72849] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

Mark tests as failing after ​http://trac.webkit.org/changeset/72839/.

  • platform/chromium/test_expectations.txt:
4:17 PM Changeset in webkit [72848] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

Mark fast/dom/StyleSheet/gc-declaration-parent-rule.html failing after ​http://trac.webkit.org/changeset/72833/

  • platform/chromium/test_expectations.txt:
4:12 PM Changeset in webkit [72847] by xji@chromium.org
  • 6 edits
    2 adds in trunk

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Fix tab overflow problem when alignment is not left.
​https://bugs.webkit.org/show_bug.cgi?id=25459

I checked WordPad in Windows, TextEdit in Mac, OpenOffice, and Google doc.
In all of them, (when the writing mode is horizontal) when the alignment is not
left alignment, the length of tab is computed based on the tab's position
relative to the left start of line, not based on the tab's position relative
to the left edge of the document.

WebKit should follow the same.

The m_xPos in each TextRun should be relative to the left start of the line,
not left start of its containing block (in right alignment and center alignment,
left start of the line is not the same as left start of the containing block).
So, when the text is drawn, the width of tab is consistent with the width
computed in RenderBlock::computeInlineDirectionPositionsForLine().

I did not test vertical writing mode, but I think the same rule should apply.

Test: fast/dom/tab-in-right-alignment.html

  • platform/graphics/TextRun.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::textPos):
  • rendering/InlineTextBox.h:

2010-11-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Fix tab overflow problem when alignment is not left.
​https://bugs.webkit.org/show_bug.cgi?id=25459

I checked WordPad in Windows, TextEdit in Mac, OpenOffice, and Google doc.
In all of them, (when the writing mode is horizontal) when the alignment is not
left alignment, the length of tab is computed based on the tab's position
relative to the left start of line, not based on the tab's position relative
to the left edge of the document.

WebKit should follow the same.

The m_xPos in each TextRun should be relative to the left start of the line,
not left start of its containing block (in right alignment and center alignment,
left start of the line is not the same as left start of the containing block).
So, when the text is drawn, the width of tab is consistent with the width
computed in RenderBlock::computeInlineDirectionPositionsForLine().

I did not test vertical writing mode, but I think the same rule should apply.

  • fast/dom/tab-in-right-alignment-expected.txt: Added.
  • fast/dom/tab-in-right-alignment.html: Added.
  • platform/qt/Skipped:
4:09 PM Changeset in webkit [72846] by sfalken@apple.com
  • 5 edits
    2 adds in trunk

2010-11-29 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files
​https://bugs.webkit.org/show_bug.cgi?id=49858

We're migrating our prebuild/prelink/postbuild steps out of vcproj and vsprops files:

  • To simplify editing (editing vsprops build steps is confusing).
  • For more readable diffs.

2010-11-19 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files
​https://bugs.webkit.org/show_bug.cgi?id=49858


We're migrating our prebuild/prelink/postbuild steps out of vcproj and vsprops files:

  • To simplify editing (editing vsprops build steps is confusing).
  • For more readable diffs.


To add a prebuild/prelink/postbuild step for a vcproj,
Add a new file named {ProjectName}PreBuild|PreLink|PostBuild.cmd to the project directory.
For example, a WTF prebuild script would be named WTFPreBuild.cmd and would be located
in the directory JavaScriptCore/JavaScriptCore.vcproj/WTF (alongside WTF.vcproj).

  • win/tools/vsprops/common.vsprops:
  • win/tools/vsprops/release.vsprops:
3:51 PM Changeset in webkit [72845] by Simon Fraser
  • 1 edit
    1 add in trunk/LayoutTests

2010-11-29 Simon Fraser <Simon Fraser>

Add Qt-specific result.

  • platform/qt/fast/overflow/overflow-update-transform-expected.txt: Added.
3:48 PM Changeset in webkit [72844] by tkent@chromium.org
  • 3 edits in trunk/WebKit/chromium

[Chromium] Add substitution parameters to WebKitClient::queryLocalizedString()
​https://bugs.webkit.org/show_bug.cgi?id=50053

Reviewed by Darin Fisher.

  • public/WebKitClient.h:

(WebKit::WebKitClient::queryLocalizedString): Add overload functions with

substitution string parameters, and remove the integer parameter overload.

  • src/LocalizedStrings.cpp:

(WebCore::query): Add string parameter overloads, and remove the integer parameter overload.
(WebCore::multipleFileUploadText): Call the string parameter query().
(WebCore::validationMessageTooLongText): Pass the parameters to query().
(WebCore::validationMessageRangeUnderflowText): ditto.
(WebCore::validationMessageRangeOverflowText): ditto.
(WebCore::validationMessageStepMismatchText): ditto.

3:37 PM Changeset in webkit [72843] by mnaganov@chromium.org
  • 9 edits in trunk/WebCore

2010-11-29 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Request JSON-serialized heap snapshot from JS engine.
This simplifies heap snapshots interaction and API. Instead of
having objects representing snapshot entities, the whole snapshot
is transferred to WebInspector and parsed there.

​https://bugs.webkit.org/show_bug.cgi?id=49974

  • bindings/js/ScriptHeapSnapshot.h: (WebCore::ScriptHeapSnapshot::OutputStream::~OutputStream): (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot): (WebCore::ScriptHeapSnapshot::writeJSON): (WebCore::ScriptHeapSnapshot::ScriptHeapSnapshot):
  • bindings/v8/ScriptHeapSnapshot.cpp: (WebCore::ScriptHeapSnapshot::writeJSON):
  • bindings/v8/ScriptHeapSnapshot.h: (WebCore::ScriptHeapSnapshot::OutputStream::~OutputStream):
  • inspector/Inspector.idl:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getProfile):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotEdgesIterator): (WebInspector.HeapSnapshotEdgesIterator.prototype.get done): (WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement): (WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden): (WebInspector.HeapSnapshotEdgesIterator.prototype.get name): (WebInspector.HeapSnapshotEdgesIterator.prototype.next): (WebInspector.HeapSnapshotEdgesIterator.prototype.get node): (WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex): (WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex): (WebInspector.HeapSnapshotEdgesIterator.prototype._getType): (WebInspector.HeapSnapshotNodeWrapper): (WebInspector.HeapSnapshotNodeWrapper.prototype.get edges): (WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount): (WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount): (WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden): (WebInspector.HeapSnapshotNodeWrapper.prototype.get name): (WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize): (WebInspector.HeapSnapshotNodeWrapper.prototype._getName): (WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges): (WebInspector.HeapSnapshotNodeWrapper.prototype._getType): (WebInspector.HeapSnapshot): (WebInspector.HeapSnapshot.prototype._init): (WebInspector.HeapSnapshot.prototype.get rootEdges): (WebInspector.HeapSnapshotView.prototype.snapshotLoaded): (WebInspector.HeapSnapshotView.prototype._loadProfile.processLoadedSnapshot): (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype._convertSnapshot): (WebInspector.HeapSnapshotView.prototype._prepareProfile.mergeRetainers): (WebInspector.HeapSnapshotView.prototype._prepareProfile): (WebInspector.HeapSnapshotView.prototype._sortData):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):
  • inspector/front-end/inspector.js: (WebInspector.addHeapSnapshotChunk): (WebInspector.finishHeapSnapshot):
3:35 PM Changeset in webkit [72842] by ggaren@apple.com
  • 4 edits in trunk

Improved accuracy of command-line SunSpider.

Reviewed by Gavin Barraclough.

JavaScriptCore:

  • jsc.cpp:

(functionRun): Changed the "run" function to run a given test in
its own global object. Previously, all tests ran in the same global
object, which created name conflicts, and made globals from previous
tests artificially survive into later tests.

Also changed "run" to return the elapsed milliseconds when running a
given test, for slightly more accurate numbers.

(functionCheckSyntax): Ditto on returning elapsed milliseconds.

SunSpider:

  • resources/sunspider-standalone-driver.js: Use the returned number of

elapsed milliseconds from "run" and "checkSyntax" instead of measuring
ourselves, for slightly more accurate numbers.

3:34 PM Changeset in webkit [72841] by andersca@apple.com
  • 19 edits in trunk/WebKit2

Should be able to pause and resume downloads
​https://bugs.webkit.org/show_bug.cgi?id=50185
<rdar://problem/8691135>

Reviewed by Darin Adler.

  • UIProcess/API/C/WKContext.h:

Add didCancel callback.

  • UIProcess/API/C/WKDownload.cpp:

(WKDownloadGetResumeData):
(WKDownloadCancel):
Call the respective DownloadProxy member functions.

  • UIProcess/API/C/WKDownload.h:
  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::cancel):
Send Cancel to the WebProcess.

(WebKit::DownloadProxy::didFail):
This now takes a resumeData reference.

(WebKit::DownloadProxy::didCancel):
Set the resume data and call didCancel.

  • UIProcess/Downloads/DownloadProxy.h:

(WebKit::DownloadProxy::resumeData):
Return the resume data.

  • UIProcess/Downloads/DownloadProxy.messages.in:

Add DidCancel message, Add resume data to DidFail.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didCancel):
Call the didCancel context client function.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didFail):
This now takes a resume data argument as well.

(WebKit::Download::didCancel):
Send DidCancel.

  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::cancelDownload):
Look up the download and cancel it.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::cancel):
Add stub.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::cancel):
Cancel the download.

(-[WKDownloadAsDelegate download:didFailWithError:]):
Pass the resume data along.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::cancel):
Add stub.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::cancelDownload):
Ask the download manager to cancel the download.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Add CancelDownload message.

3:28 PM Changeset in webkit [72840] by dimich@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed, updated expectations for a test fixed on Chromium side.
​http://code.google.com/p/chromium/issues/detail?id=61655

  • platform/chromium-mac/security/block-test-no-port-expected.txt: Added.
  • platform/chromium-win/security/block-test-no-port-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:13 PM Changeset in webkit [72839] by Simon Fraser
  • 11 edits
    2 adds in trunk

2010-11-29 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

layer()->currentTransform() is stale when layout changes the box size
​https://bugs.webkit.org/show_bug.cgi?id=50175

RenderLayer::updateTransform() is fairly expensive, so we
have to avoid calling it from RenderBox::applyLayerTransformToRect()
every time. This requires that we update the layer's transform
during layout, instead of from updateLayerPositions() which is too late.

So call updateLayerTransform() from the various layout methods
on renderers that can be transformed, and remove it from
updateLayerPositions().

Test: fast/overflow/overflow-update-transform.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::applyLayerTransformToRect): (WebCore::RenderBox::updateLayerTransform):
  • rendering/RenderBox.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::layout):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
3:03 PM Changeset in webkit [72838] by crogers@google.com
  • 3 edits
    3 adds in trunk/WebCore

2010-11-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add remaining custom JSC web audio bindings
​https://bugs.webkit.org/show_bug.cgi?id=50172

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioBufferSourceNodeCustom.cpp: Added. (WebCore::JSAudioBufferSourceNode::setBuffer):
  • bindings/js/JSConvolverNodeCustom.cpp: Added. (WebCore::JSConvolverNode::setBuffer):
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp: Added. (WebCore::JSJavaScriptAudioNode::markChildren):
  • webaudio/AudioBufferSourceNode.idl:
  • webaudio/ConvolverNode.idl:
2:48 PM Changeset in webkit [72837] by ojan@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

[Chromium] Mark tests as failing after ​http://trac.webkit.org/changeset/72819.
And rebaseline loader/reload-subresource-when-type-changes.html after
​http://trac.webkit.org/changeset/72817. The difference is that V8 logs a different
error string.

  • platform/chromium-mac/loader/reload-subresource-when-type-changes-expected.txt: Added.
  • platform/chromium-win/loader/reload-subresource-when-type-changes-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:45 PM Changeset in webkit [72836] by xan@webkit.org
  • 4 edits in trunk

2010-11-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

  • configure.ac: bump version for 1.3.7 release.

WebKit/gtk:

2010-11-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

  • NEWS: update for 1.3.7 release.
2:44 PM Changeset in webkit [72835] by yael.aharon@nokia.com
  • 4 edits
    3 adds in trunk

HTMLFormElement.elements doesn't include fieldsets
​https://bugs.webkit.org/show_bug.cgi?id=48193

Reviewed by Darin Adler.

WebCore:

Add fieldset and keygen to the list of form collection elements, by making them enumeratable.
This patch does not add object element to the list. A separate bug will do that.

Test: fast/forms/form-collection-elements.html

  • html/HTMLFieldSetElement.h:

(WebCore::HTMLFieldSetElement::isEnumeratable):

  • html/HTMLKeygenElement.h:

(WebCore::HTMLKeygenElement::isEnumeratable):

LayoutTests:

  • fast/forms/form-collection-elements-expected.txt: Added.
  • fast/forms/form-collection-elements.html: Added.
  • fast/forms/script-tests/form-collection-elements.js: Added.
2:35 PM Changeset in webkit [72834] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-11-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Get distcheck going.

  • GNUmakefile.am:
2:24 PM Changeset in webkit [72833] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=50181
CSS style declarations don't GC protect parents

Test: fast/dom/StyleSheet/gc-declaration-parent-rule.html

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::markChildren): Protect the parent rule.
2:10 PM Changeset in webkit [72832] by loislo@chromium.org
  • 3 edits in trunk/WebCore

2010-11-29 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: UI fix. In Timeline, Paint events "Location" value is displayed
in a confusing manner. The format string should be changed from %d x %d
pattern to (%d, %d).

​https://bugs.webkit.org/show_bug.cgi?id=50178

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
2:06 PM Changeset in webkit [72831] by Darin Adler
  • 4 edits in trunk

2010-11-29 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Remove a couple unneeded overflow checks
​https://bugs.webkit.org/show_bug.cgi?id=49816

  • wtf/text/CString.cpp: (WTF::CString::init): Use an ASSERT instead of an overflow check with CRASH.

2010-11-29 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Remove a couple unneeded overflow checks
​https://bugs.webkit.org/show_bug.cgi?id=49816

  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::encode): Use an ASSERT instead of an overflow check with CRASH.
2:02 PM Changeset in webkit [72830] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-29 Gavin Peters <​gavinp@chromium.org>

Reviewed by Ojan Vafai.

unloadable-script not testing both cases
​https://bugs.webkit.org/show_bug.cgi?id=50177

  • http/tests/misc/unloadable-script-expected.txt:
  • http/tests/misc/unloadable-script.html:
1:47 PM Changeset in webkit [72829] by mitz@apple.com
  • 2 edits in trunk/WebKitLibraries

WebKitSystemInterface.h piece of r72438.

Patch by Anders Carlsson <​andersca@apple.com> on 2010-11-29
Reviewed by Sam Weinig and Simon Fraser.

  • WebKitSystemInterface.h:
1:43 PM Changeset in webkit [72828] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-11-29 Tony Chang <​tony@chromium.org>

Unreviewed, disable warnings again on chromium linux

  • WebCore.gyp/WebCore.gyp:
1:38 PM Changeset in webkit [72827] by Dimitri Glazkov
  • 1 edit
    1 delete in trunk/WebKit/chromium

2010-11-29 Dimitri Glazkov <Dimitri Glazkov>

Remove Build directory that was erroneously added in r72103.

  • Build: Removed.
1:37 PM Changeset in webkit [72826] by commit-queue@webkit.org
  • 18 edits
    4 adds
    2 deletes in trunk

2010-11-29 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

getBoundingClientRect: Do not truncate the coordinates to integers
​https://bugs.webkit.org/show_bug.cgi?id=48110

Enhanced some of the tests for getBoundingClientRect, and added zooming tests.

  • css3/zoom-coords-expected.txt: Updated.
  • css3/zoom-coords.xhtml: Wrapped the <svg> elements in a <div>, to avoid re-layout on zooming or resizing. Added a test for getBoundingClientRect on unzoomed elements.
  • fast/dom/Element/getBoundingClientRect-expected.txt: Updated.
  • fast/dom/Element/getBoundingClientRect.html: Accounted for non-integer coordinates; used the Ahem font for uniform results; removed the hard-coded dependencies on font metrics.
  • fast/dom/Range/getBoundingClientRect-expected.txt: Updated.
  • fast/dom/Range/getBoundingClientRect.html: Accounted for non-integer coordinates; used the Ahem font for uniform results; removed the hard-coded dependencies on font metrics.
  • platform/chromium-win/fast/dom/Element/getBoundingClientRect-expected.txt: Deleted.
  • platform/chromium-win/fast/dom/Range/getBoundingClientRect-expected.txt: Deleted.
  • svg/custom/getBBox-js.svg: Fixed indentation.
  • svg/custom/getBoundingClientRect.xhtml: Wrapped the <svg> elements in a <div>, to avoid re-layout on zooming or resizing.
  • svg/zoom/page/zoom-getBoundingClientRect-expected.txt: Added.
  • svg/zoom/page/zoom-getBoundingClientRect.xhtml: Added.
  • svg/zoom/page/zoom-zoom-coords-expected.txt: Added.
  • svg/zoom/page/zoom-zoom-coords.xhtml: Added.
  • svg/zoom/resources/testPageZoom.js: Added call to completeDynamicTest on post-zoom. (completeDynamicTest): Added.

2010-11-29 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

getBoundingClientRect: Do not truncate the coordinates to integers
​https://bugs.webkit.org/show_bug.cgi?id=48110

Remove the float-to-int coordinate conversions inside getBoundingClientRect,
to comply with the CSSOM View Module API.

Tests: fast/dom/Element/getBoundingClientRect.html

fast/dom/Range/getBoundingClientRect.html
svg/zoom/page/zoom-getBoundingClientRect.xhtml
svg/zoom/page/zoom-zoom-coords.xhtml

  • dom/ClientRect.cpp: (WebCore::ClientRect::ClientRect): Added overload to allow a FloatRect argument.
  • dom/ClientRect.h: (WebCore::ClientRect::create): Ditto.
  • dom/Element.cpp: (Element::getBoundingClientRect): Removed conversion from FloatRect to IntRect.
  • dom/Range.cpp: (WebCore::Range::getBoundingClientRect): Ditto.
  • rendering/RenderObject.h: (adjustIntRectForAbsoluteZoom): Removed. (adjustFloatRectForAbsoluteZoom): Added.
  • rendering/style/RenderStyle.h: (adjustFloatForAbsoluteZoom): Added.
1:27 PM Changeset in webkit [72825] by Dimitri Glazkov
  • 5 edits in trunk/WebCore

2010-11-29 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Converge means of querying a parent node into one way, which is Node::parentNode.
​https://bugs.webkit.org/show_bug.cgi?id=49686

A follow-up to r72259, which explicitly forbids further use of Node::parent by
making it private.

No change in behavior, so no new tests.

  • dom/Document.cpp: (WebCore::Document::styleForElementIgnoringPendingStylesheets): Changed to use parentNode. (WebCore::Document::hoveredNodeDetached): Ditto. (WebCore::Document::activeChainNodeDetached): Ditto.
  • dom/Node.h: Made Node::parent private.
  • page/SpatialNavigation.cpp: (WebCore::canBeScrolledIntoView): Changed to use parentNode.
  • xml/XSLTProcessorQt.cpp: (WebCore::XSLTProcessor::transformToString): Ditto.
1:22 PM Changeset in webkit [72824] by tony@chromium.org
  • 3 edits in trunk/WebCore

2010-11-29 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

[chromium] try to enable WebCore compiler warnings on linux
​https://bugs.webkit.org/show_bug.cgi?id=50168

  • WebCore.gyp/WebCore.gyp:
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::setPadding): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::glyphIndexForXPositionInScriptRun):
1:09 PM Changeset in webkit [72823] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Robustify react-to-vsprops-changes.py against changes to its location or the location of the .vsprops files

Suggested by John Sullivan.

Removed file_modification_times.
(main): Use glob.glob to find the .vsprops files and assert that we found some.

1:08 PM Changeset in webkit [72822] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Touch wtf/Platform.h whenever any .vsprops file changes

This will cause all files to be recompiled, which will make changes to
preprocessor macros (e.g., ENABLE_*) actually take effect.

Fixes <​http://webkit.org/b/50167> Windows build fails when ENABLE_*
macros are changed (because not enough files are rebuilt)

Reviewed by John Sullivan.

(main): Touch wtf/Platform.h if it's older than any .vsprops file. Also
added some comments and logging to make it clearer what the script is
doing and why.

1:01 PM Changeset in webkit [72821] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Update react-to-vsprops-changes.py after r72555

.vsprops files are no longer accessed relative to $WebKitLibrariesDir.

Fixes <​http://webkit.org/b/50166> REGRESSION (r72555):
react-to-vsprops-changes.py no longer works for people with a
non-default $WebKitLibrariesDir

Reviewed by John Sullivan.

(main): Always look in WebKitLibraries/win for .vsprops files, not in
$WebKitLibrariesDir.

12:43 PM Changeset in webkit [72820] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

Unreviewed build fix.

Mark tests as failing after ​http://trac.webkit.org/changeset/72817/
to green chromium tree.

  • platform/chromium/test_expectations.txt:
12:36 PM Changeset in webkit [72819] by ap@apple.com
  • 4 edits
    4 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=50165
CSS style rules don't GC protect parents

Tests: fast/dom/StyleSheet/gc-parent-rule.html

fast/dom/StyleSheet/gc-parent-stylesheet.html

  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::markChildren): Mark parents. The code is super naive compared to what we have for nodes - but CSSOM has shallow hierarchies, so it should be OK.
  • css/CSSRule.idl: Added CustomMarkFunction.
12:22 PM Changeset in webkit [72818] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <​ojan@chromium.org>

Unreviewed. Build fix.

New test expectations and test_expectations update due to ​http://trac.webkit.org/changeset/72813/.

  • platform/chromium-mac/fast/js/regexp-overflow-expected.txt:
  • platform/chromium-win/fast/js/regexp-overflow-expected.txt:
  • platform/chromium/test_expectations.txt:
11:45 AM Changeset in webkit [72817] by commit-queue@webkit.org
  • 3 edits
    2 moves
    6 adds in trunk

2010-11-29 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

Web page can prevent WebKit from loading subresources on other
pages (cache poisoning)
​https://bugs.webkit.org/show_bug.cgi?id=35404

  • http/tests/misc/unloadable-script-expected.txt: Renamed from LayoutTests/fast/loader/unloadable-script-expected.txt.
  • http/tests/misc/unloadable-script.html: Renamed from LayoutTests/fast/loader/unloadable-script.html.
  • loader/reload-subresource-when-type-changes-expected.txt: Added.
  • loader/reload-subresource-when-type-changes.html: Added.
  • loader/resources/image1.png: Added.
  • loader/resources/image2.png: Added.
  • loader/resources/reload-subresource-when-type-changes.js: Added.

2010-11-29 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

Web page can prevent WebKit from loading subresources on other
pages (cache poisoning)
​https://bugs.webkit.org/show_bug.cgi?id=35404

Tests: http/tests/misc/unloadable-script.html

loader/reload-subresource-when-type-changes.html

  • loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::requestResource):
11:44 AM Changeset in webkit [72816] by kbalazs@webkit.org
  • 5 edits in trunk/WebKit2

2010-11-29 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Roben.

[WK2] Support repeating timers
​https://bugs.webkit.org/show_bug.cgi?id=50024

Added boolean member for TimerBase on PLATFORM(WIN)
and PLATFORM(QT) to be able to differentiate between
repeating and one shot operating mode. Change the confusing
signature of TimerBase::start: use a bool for selecting
operating mode.

  • Platform/RunLoop.h: (RunLoop::TimerBase::startRepeating): (RunLoop::TimerBase::startOneShot):
  • Platform/mac/RunLoopMac.mm: (RunLoop::TimerBase::start):
  • Platform/qt/RunLoopQt.cpp: (RunLoop::TimerBase::timerFired): Only stop the timer if it is not in repeating mode. (RunLoop::TimerBase::TimerBase): (RunLoop::TimerBase::start):
  • Platform/win/RunLoopWin.cpp: (RunLoop::TimerBase::timerFired): Only stop the timer if it is not in repeating mode. (RunLoop::TimerBase::TimerBase): (RunLoop::TimerBase::start):
11:31 AM QtWebKitContrib edited by siddharth.mathur@nokia.com
added Webkit with Git links (diff)
11:19 AM Changeset in webkit [72815] by Adam Roben
  • 1 edit
    4 adds in trunk/LayoutTests

Check in new Windows results after r72678

Right-clicking no longer triggers a selection in DRT on Windows, so we
don't match Mac anymore.

  • platform/win/editing/selection/5109817-expected.checksum: Added.
  • platform/win/editing/selection/5109817-expected.png: Added.
  • platform/win/editing/selection/5109817-expected.txt: Added.
  • platform/win/editing/selection/5354455-1-expected.txt: Added.
11:08 AM Changeset in webkit [72814] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-11-29 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Crash in WebCore::CSSStyleSelector::loadPendingImages
​https://bugs.webkit.org/show_bug.cgi?id=50149

Null-check style->boxReflect() when loading pending style images.

Test: fast/reflections/pending-reflection-mask-crash.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::loadPendingImages):
10:52 AM Changeset in webkit [72813] by barraclough@apple.com
  • 10 edits
    3 adds in trunk

Bug 48100 - YARR allows what seems like a bogus character-class range

Reviewed by Sam Weinig.

JavaScriptCore:

Per ECMA-262 character classes containing character ranges containing
character classes are invalid, eg:

/[\d-x]/
/[x-\d]/
/[\d-\d]/

These should throw a syntax error.

  • yarr/RegexParser.h:

LayoutTests:

Add/update layout test results.

  • fast/js/regexp-overflow-expected.txt:
  • fast/js/regexp-ranges-and-escaped-hyphens-expected.txt:
  • fast/js/script-tests/regexp-overflow.js:
  • fast/js/script-tests/regexp-ranges-and-escaped-hyphens.js:
  • fast/regex/invalid-range-in-class-expected.txt: Added.
  • fast/regex/invalid-range-in-class.html: Added.
  • fast/regex/script-tests/invalid-range-in-class.js: Added.
  • fast/regex/test1-expected.txt:
  • fast/regex/test4-expected.txt:
  • fast/regex/testinput4:
10:46 AM Changeset in webkit [72812] by andersca@apple.com
  • 8 edits in trunk/WebKit2

Downloads: When the web process crashes, call error callbacks for pending downloads
​https://bugs.webkit.org/show_bug.cgi?id=50164
<rdar://problem/8691170>

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.h:

Add processDidCrash callback.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::~DownloadProxy):
Assert that the web context is null.

(WebKit::DownloadProxy::processDidClose):
Call the processDidCrash callback.

(WebKit::DownloadProxy::didFinish):
(WebKit::DownloadProxy::didFail):
Call downloadFinished.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processDidClose):
Call processDidClose on all pending downloads.

(WebKit::WebContext::downloadFinished):
Remove the download proxy from the map.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::processDidCrash):
Call the processDidCrash callback function.

10:36 AM Changeset in webkit [72811] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon inspecting user style sheet.
​https://bugs.webkit.org/show_bug.cgi?id=50109

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
10:22 AM QtWebKitRelease21 edited by Csaba Osztrogonác
Add buildbot link (diff)
10:19 AM Changeset in webkit [72810] by caseq@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-11-29 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Darin Fisher.

Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Added WebDevToolsAgent::inspect()
​https://bugs.webkit.org/show_bug.cgi?id=49727

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::inspectNode):
  • src/WebDevToolsAgentImpl.h:
10:18 AM QtWebKitRelease20 edited by Csaba Osztrogonác
Add buildbot link (diff)
10:17 AM Changeset in webkit [72809] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-11-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Implement WebCore::directoryName
​https://bugs.webkit.org/show_bug.cgi?id=50031

Also fix handling of paths without path separator.

  • platform/wince/FileSystemWinCE.cpp: (WebCore::reverseFindPathSeparator): (WebCore::makeAllDirectories): (WebCore::pathGetFileName): (WebCore::directoryName):
9:52 AM Changeset in webkit [72808] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-11-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Simplify directoryName in FileSystemWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=50028

  • platform/win/FileSystemWin.cpp: (WebCore::directoryName):
9:52 AM Changeset in webkit [72807] by Dimitri Glazkov
  • 4 edits
    2 adds in trunk

2010-11-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION (r71934): Main search field at Apple tech specs does not accept typing
​https://bugs.webkit.org/show_bug.cgi?id=49868

  • fast/forms/disabled-search-input-expected.txt: Added.
  • fast/forms/disabled-search-input.html: Added.

2010-11-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION (r71934): Main search field at Apple tech specs does not accept typing
​https://bugs.webkit.org/show_bug.cgi?id=49868

The problem here was that the inner text element of search input was first laid out as
disabled and thus with a 0-height. This would prevent a hit test to ever reach it, even
if it's enabled.

Test: fast/forms/disabled-search-input.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasLineIfEmpty): Removed a check for textarea that is no longer necessary.
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty): Added an override to ensure that

an empty inner text element is always one-line high.

9:42 AM Changeset in webkit [72806] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/chromium

2010-11-29 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Remove python_24 dependency, because it is no longer necessary.

  • DEPS: Removed python_24 dependency.
9:39 AM Changeset in webkit [72805] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating test expecations.

  • platform/chromium/test_expectations.txt:
9:23 AM Changeset in webkit [72804] by mario@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-29 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
​https://bugs.webkit.org/show_bug.cgi?id=50154

Added missing checks to allAttributes().

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::allAttributes): Added missing checks.
9:01 AM Changeset in webkit [72803] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Try fixing python test failure from commit 72802.

  • platform/mac/test_expectations.txt:
8:18 AM Changeset in webkit [72802] by inferno@chromium.org
  • 5 edits
    35 adds in trunk

2010-11-29 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by Dirk Schulze.

Large input numbers cause overflow during SVG parsing, leading to crash
​https://bugs.webkit.org/show_bug.cgi?id=49546

Values outside the range supported by float lead to Infinity() or NaN()
during parsing, leading to subsequent crashes. Modified
parser to verify number is in the supported range, and return false if not.

Tests: svg/custom/svg-parse-overflow-1.html

svg/custom/svg-parse-overflow-2.html
svg/custom/svg-parse-overflow-3.html
svg/custom/svg-parse-overflow-4.html
svg/custom/svg-parse-overflow-5.html

  • svg/SVGParserUtilities.cpp: (WebCore::isValidRange): (WebCore::genericParseNumber):

2010-11-29 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by Dirk Schulze.

Large input numbers cause overflow during SVG parsing, leading to crash
​https://bugs.webkit.org/show_bug.cgi?id=49546

Values outside the range supported by float lead to Infinity() or NaN()
during parsing, leading to subsequent crashes. Modified
parser to verify number is in the supported range, and return false if not.

  • platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/svg-parse-overflow-1-expected.checksum: Added.
  • platform/mac/svg/custom/svg-parse-overflow-1-expected.png: Added.
  • platform/mac/svg/custom/svg-parse-overflow-1-expected.txt: Added.
  • platform/mac/svg/custom/svg-parse-overflow-2-expected.checksum: Added.
  • platform/mac/svg/custom/svg-parse-overflow-2-expected.png: Added.
  • platform/mac/svg/custom/svg-parse-overflow-2-expected.txt: Added.
  • platform/mac/svg/custom/svg-parse-overflow-3-expected.checksum: Added.
  • platform/mac/svg/custom/svg-parse-overflow-3-expected.png: Added.
  • platform/mac/svg/custom/svg-parse-overflow-3-expected.txt: Added.
  • platform/mac/svg/custom/svg-parse-overflow-4-expected.checksum: Added.
  • platform/mac/svg/custom/svg-parse-overflow-4-expected.png: Added.
  • platform/mac/svg/custom/svg-parse-overflow-4-expected.txt: Added.
  • platform/mac/svg/custom/svg-parse-overflow-5-expected.checksum: Added.
  • platform/mac/svg/custom/svg-parse-overflow-5-expected.png: Added.
  • platform/mac/svg/custom/svg-parse-overflow-5-expected.txt: Added.
  • platform/mac/test_expectations.txt:
  • svg/custom/svg-parse-overflow-1.html: Added.
  • svg/custom/svg-parse-overflow-2.html: Added.
  • svg/custom/svg-parse-overflow-3.html: Added.
  • svg/custom/svg-parse-overflow-4.html: Added.
  • svg/custom/svg-parse-overflow-5.html: Added.
8:16 AM Changeset in webkit [72801] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Antonio Gomes <​agomes@rim.com>

Rubber stamped by Csaba Osztrogonác.

Clean up mac-wk2 Skipped file wrt spatial navigation tests.

  • platform/mac-wk2/Skipped:
8:04 AM Changeset in webkit [72800] by yurys@chromium.org
  • 8 edits
    3 adds in trunk

2010-11-29 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display name of an object constructor as the object's type
​https://bugs.webkit.org/show_bug.cgi?id=50063

Name of the function that has created given object is used as the object's
type when it's displayed in the inspector front-end(in case of V8). Before
this change, it was always a value of the object's constructor.name property
which is confusing in some cases(see the test).

Removed check for jsEngine from the InjectedScript.js, all VM-specific code
is now encapsulated on the bindings layer.

Test: inspector/console-object-constructor-name.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::JSInjectedScriptHost::constructorName):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::constructorNameCallback):
  • inspector/InjectedScriptHost.idl:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):

2010-11-29 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display name of an object constructor as the object's type
​https://bugs.webkit.org/show_bug.cgi?id=50063

  • inspector/console-object-constructor-name-expected.txt: Added.
  • inspector/console-object-constructor-name.html: Added.
  • inspector/extensions-events-expected.txt:
  • platform/chromium/inspector/console-object-constructor-name-expected.txt: Added.
7:51 AM Changeset in webkit [72799] by jeremy@chromium.org
  • 2 edits in trunk/WebCore

2010-11-29 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24346

Remove temporary workaround to load Gears plugin.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
7:45 AM Changeset in webkit [72798] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-11-29 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skipping crashing test.

[GStreamer] fast/events/tabindex-focus-blur-all.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=50155

  • platform/gtk/Skipped:
7:40 AM Changeset in webkit [72797] by yael.aharon@nokia.com
  • 4 edits in trunk/WebCore

Spatial Navigation: Store more information in FocusCandidate
​https://bugs.webkit.org/show_bug.cgi?id=50153

Reviewed by Antonio Gomes.

More information should be stored in FocusCandidate, to avoid
recalculating it when running the spatial navigation algorithm.

No new tests, since this is code refactoring only.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::canBeScrolledIntoView):

  • page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate):

7:12 AM Changeset in webkit [72796] by Dimitri Glazkov
  • 6 edits in trunk

2010-11-29 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Use the right focusable check to avoid multiple focus/blur events being fired from inside of the shadow DOM.
​https://bugs.webkit.org/show_bug.cgi?id=49977

  • fast/events/shadow-boundary-crossing-2.html: Added a test for multiple focus events.
  • fast/events/shadow-boundary-crossing-2-expected.txt: Added new test expectation.

2010-11-29 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Use the right focusable check to avoid multiple focus/blur events being fired from inside of the shadow DOM.
​https://bugs.webkit.org/show_bug.cgi?id=49977

  • editing/SelectionController.cpp: (WebCore::SelectionController::setFocusedNodeIfNeeded): Added a FIXME to remove redundant code.
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Changed to use isMouseFocusable, which is what shadow DOM elements

override, and added a FIXME to convert to use shadow DOM-aware traversal instead of render tree traversal.

Test: fast/events/shadow-boundary-crossing-2.html

7:06 AM Changeset in webkit [72795] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix after r72715

  • WebCore.vcproj/WebCore.vcproj: Add a missing </File> tag to fix an

XML syntax error.

6:47 AM Changeset in webkit [72794] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk

2010-11-29 Bernhard Bauer <​bauerb@chromium.org>

Reviewed by Jeremy Orlow.

Remove databaseFileName from IDBFactoryBackendImpl
​https://bugs.webkit.org/show_bug.cgi?id=50150

No new tests, since functionality is unchanged.

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::openSQLiteDatabase):
  • storage/IDBFactoryBackendImpl.h:

2010-11-29 Bernhard Bauer <​bauerb@chromium.org>

Reviewed by Jeremy Orlow.

Remove databaseFileName from WebIDBFactory
​https://bugs.webkit.org/show_bug.cgi?id=50150

  • WebKit.gyp:
  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • src/WebIDBFactory.cpp: Removed.
6:29 AM Changeset in webkit [72793] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GStreamer] take video sink ownership with gst_object API
​https://bugs.webkit.org/show_bug.cgi?id=49011

Use gst_object_ref_sink instead of g_object_ref_sink to avoid
possible leaks.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
5:28 AM Changeset in webkit [72792] by Laszlo Gombos
  • 6 edits in trunk

2010-11-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Allow pre-generation for package builds for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=50139

Use a build variable for the generated directory path and set the
value based on CONFIG just like for WebKit1.

For non-package builds use a relative base path for the
genrated directory just like for WebKit1.

  • DerivedSources.pro:
  • WebKit2.pro:

2010-11-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Allow pre-generation for package builds for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=50139

Use a build variable for the generated directory path and set the
value based on CONFIG just like for WebKit1.

For non-package builds use a relative base path for the
genrated directory just like for WebKit1.

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
5:20 AM Changeset in webkit [72791] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

[Mac] fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html fails
​https://bugs.webkit.org/show_bug.cgi?id=47449

Reviewed by Antonio Gomes.

Remove test from skip list, it is passing now.

  • platform/mac/Skipped:
5:15 AM Changeset in webkit [72790] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

[Mac] fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html fails
​https://bugs.webkit.org/show_bug.cgi?id=47448

Reviewed by Antonio Gomes.

Remove test from skip list, it is passing now and does not depend on font metrics anymore.

  • platform/mac/Skipped:
4:35 AM Changeset in webkit [72789] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-29 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Tooltips should be fully keyboard accessible
​https://bugs.webkit.org/show_bug.cgi?id=25525

Position the tooltip under the current focused element when the
tooltip has been triggered using the keyboard.

  • webkit/webkitwebview.cpp: (webkit_web_view_query_tooltip): (webkit_web_view_show_help): (webkit_web_view_class_init):
4:05 AM Changeset in webkit [72788] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-29 Jan Erik Hanssen <​jhanssen@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

QtWebKit asserts when selecting elided text.
​https://bugs.webkit.org/show_bug.cgi?id=45391

Ensure that the length passed to fromRawDataWithoutRef() does
not exceed the length of the string.

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::selectionRectForSimpleText):
3:50 AM Changeset in webkit [72787] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-29 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Tooltips not shown when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=50143

Convert tooltip area to window coordinates so that tooltips are
shown even after scrolling.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
3:28 AM Changeset in webkit [72786] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-11-26 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Styles Gear Menu Choice to Display Colors "As Authored"
​https://bugs.webkit.org/show_bug.cgi?id=31614

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Color.js: (WebInspector.Color.prototype.toString): (WebInspector.Color.prototype._parse.this.rgba.set 0): (WebInspector.Color.prototype._parse.set WebInspector): (WebInspector.Color.prototype._parse):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.nextFormat): (WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay):
2:41 AM Changeset in webkit [72785] by hans@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: update tutorial.html
​https://bugs.webkit.org/show_bug.cgi?id=50140

removeObjectStore() was renamed to deleteObjectStore()

  • storage/indexeddb/tutorial.html:
2:12 AM Changeset in webkit [72784] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2010-11-29 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
​https://bugs.webkit.org/show_bug.cgi?id=50141

New fast canvas test to ensure correct fillRect shadow when using
ctx.scale(x,y).

  • fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Added.
  • fast/canvas/canvas-scale-fillRect-shadow.html: Added.
  • fast/canvas/script-tests/canvas-scale-fillRect-shadow.js: Added.

2010-11-29 Helder Correia <​helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
​https://bugs.webkit.org/show_bug.cgi?id=50141

Don't apply scaling transformation to shadow offsets.

Test: fast/canvas/canvas-scale-fillRect-shadow.html

  • platform/graphics/ContextShadow.h:
  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):

Nov 28, 2010:

10:45 PM Changeset in webkit [72783] by Dimitri Glazkov
  • 7 edits in trunk

2010-11-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Default event handlers should also be using event retargeting.
​https://bugs.webkit.org/show_bug.cgi?id=49986

  • fast/events/shadow-boundary-crossing-2.html: Added a test.
  • fast/events/shadow-boundary-crossing-2-expected.txt: Modified expectations to include new test.

2010-11-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Default event handlers should also be using event retargeting.
​https://bugs.webkit.org/show_bug.cgi?id=49986

Test: fast/events/shadow-boundary-crossing-2.html

  • dom/EventContext.cpp: (WebCore::EventContext::defaultEventHandler): Added.
  • dom/EventContext.h: Added decl.
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Changed to use event retargeting for

default event handlers.

5:06 PM Changeset in webkit [72782] by morrita@google.com
  • 7 edits in trunk

2010-11-23 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

REGRESSION: Text on <input type="search"> is not spellchecked.
​https://bugs.webkit.org/show_bug.cgi?id=49651

  • editing/spelling/spellcheck-attribute.html: Added <input type="search"> cases.
  • editing/spelling/spellcheck-attribute-expected.txt:

2010-11-23 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

REGRESSION: Text on <input type="search"> is not spellchecked.
​https://bugs.webkit.org/show_bug.cgi?id=49651

TextControlInnerElement::isSpellCheckingEnabled() didn't consider
non-root shadow elelements and always went false for <input type="search>.
This change unifies shadow and host handling into Element::isSpellCheckingEnabled().

Test: editing/spelling/spellcheck-attribute.html

  • dom/Element.cpp: (WebCore::Element::isSpellCheckingEnabled):
  • rendering/TextControlInnerElements.cpp:
  • rendering/TextControlInnerElements.h:
4:45 PM Changeset in webkit [72781] by barraclough@apple.com
  • 8 edits
    6 adds in trunk

Bug 48101 - Yarr gives different results for /(?:a*?){2,}/

Reviewed by Sam Weinig.

JavaScriptCore:

The test cases in the linked mozilla bug demostrate a couple of
problems in subpattern matching. These bugs lie in the optimized
cases - for matching parentheses with a quantity count of 1, and
for matching greedy quantified parentheses at the end of a regex
(which do not backtrack).

In both of these cases we are failing to correctly handle empty
matches. In the case of parenthese-single matches (quantity count
one) we are failing to test for empty matches at all. In the case
of terminal subpattern matches we do currenty check, however there
is a subtler bug here too. In the case of an empty match we will
presently immediately fall through to the next alternative (or
complete the regex match), whereas upon a failed match we should
be backtracking into the failing alternative, to give it a chance
to match further (e.g. consider /a??b?|a/.exec("ab") - upon first
attempting to match the first alternative this will match the empty
string - since a?? is non-greedy, however rather than moving on to
the second alternative we should be re-matching the first one, at
which point the non-greedy a?? will match, and as such the result
should be "ab", not "a").

Terminal sunpattern matching contains a second bug, too. The frame
location values in the subpattern should be being allocated with
the outer disjunction's frame (as we do for the parentheses-single
optimization). Consider the following three regexes:

/a*(?:b*)*c*/
/a*(?:b*)c*/
/a*(?:b*)*/

Considering only the frame location required by the atoms a,b, and
c, (ignoring space associated with the nested subpattern) the first
regex (a normal subpattern match) requires a frame size of 2 for
the outer disjunction, (to backtrack terms a & c), with each
iteration of the subpattern requiring a frame of size 1 (in order
to backtrack b). In the case of the second regex (where the
parentheses-single optimization will kick in) the outer frame must
be set up with a frame size of 3, since the outer frame will also
be used when running the nested subpattern. We will currently only
allocate a farme of size 1 for the outer disjuntion (to contain a),
howver the frame size should be 2 (since the subpattern will be
evaluated in the outer frame). In addition to failing to allocate
frame space the frame offsets are also presently invalid - in the
case of the last regex b's frame location will be set assuming it
to be the first term in the frame, whereas in this case b lies
after the term a, and should be taking a separate frame location.

In order to correctly allocate the frame for terminal subpattern
matches we must move this optimization back up from the JIT into
the compiler (and thus interpreter too), since this is where the
frame allocation takes place.

  • yarr/RegexCompiler.cpp:

(JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
(JSC::Yarr::RegexPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::compileRegex):

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
(JSC::Yarr::Interpreter::matchParenthesesOnceEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
(JSC::Yarr::Interpreter::matchParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::matchParenthesesTerminalEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalEnd):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):

  • yarr/RegexInterpreter.h:
  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateParenthesesSingle):
(JSC::Yarr::RegexGenerator::generateParenthesesGreedyNoBacktrack):
(JSC::Yarr::RegexGenerator::generateTerm):

  • yarr/RegexPattern.h:

(JSC::Yarr::PatternTerm::PatternTerm):

LayoutTests:

Add layout tests for corner cases of repeat matches in regular expressions,
and of the examples documented in the ECMA-262 spec .

  • fast/regex/ecma-regex-examples-expected.txt: Added.
  • fast/regex/ecma-regex-examples.html: Added.
  • fast/regex/repeat-match-waldemar-expected.txt: Added.
  • fast/regex/repeat-match-waldemar.html: Added.
  • fast/regex/script-tests/ecma-regex-examples.js: Added.
  • fast/regex/script-tests/repeat-match-waldemar.js: Added.
10:51 AM Changeset in webkit [72780] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-28 Antonio Gomes <​agomes@rim.com>

Reviewed by Kenneth Rohde Christiansen.

Spatial Navigation: use isSpatialNaviagtionEnabled from SpatialNavigation.h in HTMLInputElement::defaultEventHandler
​https://bugs.webkit.org/show_bug.cgi?id=50131

For all isSpatialNavigationEnabled calls throughout WebCore, we decided to use the static method in
SpatialNavigation.h instead of directly checking from the one in Settings.h. Reason: in a soon future,
there will be a isCaretBrowsing check incorporated into this method (and probably renaming it accordingly)
to avoid feature conflicts (spatial navigation x caret browsing).

No new tests needed.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
10:32 AM Changeset in webkit [72779] by Laszlo Gombos
  • 4 edits in trunk

2010-11-28 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Move some build logic from Qt to platform independent code
​https://bugs.webkit.org/show_bug.cgi?id=50134

Remove the creation of the directories under $$OUTPUT_DIR/include
as these will be handled by the fwheader_generator target.

Remove the explicit generation of $$OUTPUT_DIR/WebKit2/generated as
this is not required.

  • DerivedSources.pro:

2010-11-28 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Move some build logic from Qt to platform independent code
​https://bugs.webkit.org/show_bug.cgi?id=50134

Create target directories inside generate-forwarding-headers.pl.

  • Scripts/generate-forwarding-headers.pl:
9:34 AM Changeset in webkit [72778] by Laszlo Gombos
  • 2 edits in trunk

2010-11-28 Laszlo Gombos <Laszlo Gombos>

Reviewed by Antonio Gomes.

[Qt] Remove unused BASE_DIR from the build system
​https://bugs.webkit.org/show_bug.cgi?id=50132

  • WebKit.pri:

Nov 27, 2010:

6:54 PM Changeset in webkit [72777] by commit-queue@webkit.org
  • 13 edits
    1 add in trunk/WebCore

2010-11-27 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Darin Adler.

Move Position::EditingBoundaryCrossingRule to a new header file
​https://bugs.webkit.org/show_bug.cgi?id=49630

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Position.cpp: (WebCore::downstreamIgnoringEditingBoundaries): (WebCore::upstreamIgnoringEditingBoundaries):
  • dom/Position.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):
  • editing/EditingBoundary.h: Added.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::isStartOfParagraph): (WebCore::isEndOfParagraph):
  • editing/visible_units.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
1:15 AM Changeset in webkit [72776] by rwlbuis@webkit.org
  • 4 edits
    3 adds in trunk

2010-11-26 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Simon Fraser.

Percentage z offset in transform-origin should make the property invalid
​https://bugs.webkit.org/show_bug.cgi?id=48704

Discard transform-origin property when parsing invalid Z value.

Test: fast/css/transform-origin-parsing.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseTransformOriginShorthand): (WebCore::CSSParser::parseTransformOrigin):
  • css/CSSParser.h:
Note: See TracTimeline for information about the timeline view.